gdb/ChangeLog

   1 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * psymtab.c (print_partial_symbols): Handle missing domain_enum
   4         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
   5
   6 2019-09-03  Tom Tromey  <tromey@adacore.com>
   7
   8         * ada-valprint.c (ada_val_print_num): Don't recurse for range
   9         types.
  10         (has_negatives): Unbias a range type bound.
  11         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
  12         * gdbtypes.c (operator==): Handle new field.
  13         (create_range_type): Add "bias" parameter.
  14         (create_static_range_type, resolve_dynamic_range): Update.
  15         * gdbtypes.h (struct range_bounds) <bias>: New member.
  16         (create_range_type): Add bias parameter.
  17         * printcmd.c (print_scalar_formatted): Unbias range types.
  18         * value.c (unpack_long): Unbias range types.
  19         (pack_long): Bias range types.
  20
  21 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  22
  23         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
  24         probe arguments.
  25
  26 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  27
  28         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
  29         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
  30         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
  31         (compile_probe_arg): Likewise.
  32         * probe.h (get_argument_count): Likewise.
  33         * solib-svr4.c (solib_event_probe_action): Likewise.
  34         * stap-probe.c (stap_probe::get_argument_count): Likewise.
  35
  36 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  37
  38         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
  39         code to here...
  40         (svr4_create_solib_event_breakpoints): ...from here.
  41
  42 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
  43
  44         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
  45         suffix from warning message.
  46
  47 2019-08-30  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-winsource.h (struct tui_source_window_base)
  50         <refresh_all>: Don't declare.
  51         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
  52         Remove.
  53         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
  54         tui_show_locator_content.
  55         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
  56         declare.
  57         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
  58         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
  59         declare.
  60
  61 2019-08-30  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
  64
  65 2019-08-30  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-stack.c (_initialize_tui_stack): Move later.
  68         Remove unnecessary forward declarations.
  69
  70 2019-08-30  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
  73         rerender.
  74         (tui_update_locator_fullname, tui_show_frame_info): Don't call
  75         tui_show_locator_content.
  76
  77 2019-08-30  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
  80         (tui_locator_window::rerender): Rewrite using body of previous
  81         tui_show_locator_content.
  82
  83 2019-08-30  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
  86         set_locator_fullname>: New methods.
  87         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  88         Rename from tui_set_locator_fullname.
  89         (tui_locator_window::set_locator_info): Rename from
  90         tui_set_locator_info.  Return bool.
  91         (tui_update_locator_fullname, tui_show_frame_info): Update.
  92
  93 2019-08-30  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
  96
  97 2019-08-30  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 100         call touchwin.
 101
 102 2019-08-30  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-wingeneral.c (box_win): Assume win_info and
 105         win_info->handle cannot be NULL.
 106
 107 2019-08-30  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 110         refresh_window>: Declare.
 111         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 112         resize.
 113         (tui_data_item_window::rerender): Rename from
 114         tui_display_register.
 115         (tui_data_item_window::refresh_window): New method.
 116         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 117         no-op.
 118
 119 2019-08-30  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 122         regs_column_count, current_group>: Move later.  Now private.
 123         <get_current_group>: New method.
 124         * tui/tui-regs.c (tui_reg_command): Update.
 125         * tui/tui-layout.c (tui_set_layout): Update.
 126
 127 2019-08-30  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 130         (tui_data_window::rerender): Don't call
 131         check_and_display_highlight_if_needed.
 132         (tui_data_window::refresh_all): Remove call to
 133         erase_data_content.
 134
 135 2019-08-30  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 138         (tui_data_window::display_registers_from)
 139         (tui_data_window::display_reg_element_at_line)
 140         (tui_data_window::display_registers_from_line): Remove checks of
 141         "empty".
 142
 143 2019-08-30  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 146         Don't declare.
 147         * tui/tui-regs.c (tui_data_window::show_registers): Call
 148         rerender.
 149         (tui_data_window::rerender): Rename from display_all_data.
 150         (tui_data_window::rerender): Remove old implementation.
 151
 152 2019-08-30  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 155         text.
 156         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 157
 158 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 159             Sergio Durigan Junior  <sergiodj@redhat.com>
 160
 161         PR win32/24284
 162         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 163
 164 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 165
 166         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 167         when searching for types.
 168
 169 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 170
 171         * f-lang.c (f_language_defn): Use f_print_typedef.
 172         * f-lang.h (f_print_typedef): Declare.
 173         * f-typeprint.c (f_print_typedef): Define.
 174
 175 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 176
 177         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 178
 179 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 180
 181         * cli/cli-utils.c (info_print_options_defs): Delete.
 182         (make_info_print_options_def_group): Delete.
 183         (extract_info_print_options): Delete.
 184         (info_print_command_completer): Delete.
 185         (info_print_args_help): Add extra parameter, and optionally
 186         include text about -n flag.
 187         * cli/cli-utils.h (struct info_print_options): Delete.
 188         (extract_info_print_options): Delete declaration.
 189         (info_print_command_completer): Delete declaration.
 190         (info_print_args_help): Add extra parameter, extend header
 191         comment.
 192         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 193         search_symbols.
 194         * stack.c (struct info_print_options): New type.
 195         (info_print_options_defs): New file scoped variable.
 196         (make_info_print_options_def_group): New static function.
 197         (info_print_command_completer): New static function.
 198         (info_locals_command): Update to use new local functions.
 199         (info_args_command): Likewise.
 200         (_initialize_stack): Add extra parameter to calls to
 201         info_print_args_help.
 202         * symtab.c (search_symbols): Add extra parameter, use this to
 203         possibly excluse non-debug symbols.
 204         (symtab_symbol_info): Add extra parameter, which is passed on to
 205         search_symbols.
 206         (struct info_print_options): New type.
 207         (info_print_options_defs): New file scoped variable.
 208         (make_info_print_options_def_group): New static function.
 209         (info_print_command_completer): New static function.
 210         (info_variables_command): Update to use local functions, and pass
 211         extra parameter through to symtab_symbol_info.
 212         (info_functions_command): Likewise.
 213         (info_types_command): Pass additional argument through to
 214         symtab_symbol_info.
 215         (rbreak_command): Pass extra argument to search_symbols.
 216         (_initialize_symtab): Add extra arguments for calls to
 217         info_print_args_help, and update help text for 'info variables',
 218         'whereis', and 'info functions' commands.
 219         * symtab.h (search_symbols): Add extra argument to declaration.
 220         * NEWS: Mention new flags.
 221
 222 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 223
 224         * symtab.c (lookup_static_symbol): Call the new function (and move
 225         it down to be next to lookup_global_symbol).
 226         (struct global_sym_lookup_data): Add block_enum member and rename to...
 227         (struct global_or_static_sym_lookup_data): ...this.
 228         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 229         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 230         (lookup_symbol_global_or_static_iterator_cb): ...this.
 231         (lookup_global_or_static_symbol): New function.
 232         (lookup_global_symbol): Call new function.
 233
 234 2019-08-26  Tom de Vries  <tdevries@suse.de>
 235
 236         PR c++/24852
 237         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 238         when pc_probe.prob == NULL.
 239
 240 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 241
 242         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 243         variable symbol_linkage to symbol_linkage_.
 244
 245 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 246
 247         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 248         represent whether the symbol is static, dynamic, or we don't
 249         know.
 250
 251 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 252
 253         * gdb/rx-tdep.c (rx_register_names): New.
 254         (rx_register_name): Delete.
 255         (rx_psw_type): Delete.
 256         (rx_fpsw_type): Delete.
 257         (rx_register_type): Delete.
 258         (rx_gdbarch_init): Convert target-descriptions.
 259         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 260         * gdb/features/Makefile: Add rx.xml.
 261         * gdb/features/rx.xml: New.
 262         * gdb/features/rx.c: Generated.
 263         * gdb/NEWS: Mention target description support.
 264
 265 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 266
 267         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 268         *slot_ptr.
 269
 270 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 271
 272         * configure.ac: Don't check for 'dlfcn.h' (moved to
 273         gdbsupport/common.m4).
 274         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 275         'gdbsupport/'.
 276         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 277         * compile/compile-c-support.c: Include
 278         'gdbsupport/gdb-dlfcn.h'.
 279         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 280         * gdb-dlfcn.c: Move to...
 281         * gdbsupport/gdb-dlfcn.c: ... here.
 282         * gdb-dlfcn.h: Move to...
 283         * gdbsupport/gdb-dlfcn.h: ... here.
 284
 285 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 286
 287         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 288         the offset field signed.
 289
 290 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 291
 292         * python/lib/gdb/__init__.py (_execute_file): New function.
 293         * python/python.c (python_run_simple_file): Call gdb._execute_file
 294         on Windows.
 295
 296 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 297
 298         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 299         all uses as this was never set to anything but a zero value.
 300
 301 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 302
 303         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 304
 305 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 306
 307         * tui/tui-data.h (tui_gen_win_info): Add an =default
 308         move constructor, required by some GCC versions.
 309
 310 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 311
 312         * go32-nat.c (go32_sysinfo): Add hygon_p.
 313
 314 2019-08-20  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 317         line_from_reg_element_no, first_reg_element_no_inline,
 318         display_all_data, delete_data_content_windows,
 319         erase_data_content>: Now private.
 320
 321 2019-08-20  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 324         (tui_unhighlight_win, tui_highlight_win)
 325         (tui_win_info::make_window): Update.
 326         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 327
 328 2019-08-20  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 331         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 332         (MAX_PID_WIDTH): Move to tui-stack.c.
 333         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 334         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 335         (MAX_PID_WIDTH): Move from tui-data.h.
 336
 337 2019-08-20  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 340         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 341         (box_win): Update.
 342         (tui_gen_win_info::make_window): Rename from tui_make_window.
 343         (tui_win_info::make_window): New method.
 344         (tui_gen_win_info::make_visible): Update.
 345         * tui/tui-source.c (tui_source_window::set_contents): Update.
 346         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 347         (tui_data_window::display_registers_from): Update.
 348         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 349         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 350         Declare.
 351         <can_box>: Remove.
 352         <title>: Remove.
 353         (struct tui_win_info) <make_window>: Declare.
 354         <can_box>: Now virtual.
 355         <title>: New member.
 356         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 357         * tui/tui-command.c (tui_cmd_window::resize): Update.
 358
 359 2019-08-20  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 362         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 363         (tui_data_window::check_register_values): Update.
 364
 365 2019-08-20  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-regs.h (struct tui_data_window): Use
 368         DISABLE_COPY_AND_ASSIGN.
 369         <regs_content>: Change type, removing unique_ptr.
 370         <tui_data_window>: Add move constructor.
 371         * tui/tui-regs.c (tui_data_window::show_registers)
 372         (tui_data_window::show_register_group)
 373         (tui_data_window::display_registers_from)
 374         (tui_data_window::display_registers_from)
 375         (tui_data_window::first_data_item_displayed)
 376         (tui_data_window::delete_data_content_windows)
 377         (tui_data_window::rerender, tui_data_window::refresh_window)
 378         (tui_data_window::check_register_values): Update.
 379
 380 2019-08-20  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 383         show_register_group>: Declare.
 384         (tui_show_register_group): Don't declare.
 385         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 386         tui_show_registers.
 387         (tui_data_window::show_register_group): Rename from
 388         tui_show_register_group.
 389         (tui_data_window::check_register_values, tui_reg_command):
 390         Update.
 391         * tui/tui-layout.c (tui_set_layout): Update.
 392
 393 2019-08-20  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 396         Declare.
 397         (tui_check_register_values): Don't declare.
 398         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 399         from tui_check_register_values.
 400         * tui/tui-hooks.c (tui_register_changed): Update.
 401
 402 2019-08-20  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-regs.c (tui_reg_layout): Move later.
 405         (tui_show_registers): Don't enable TUI mode or change layout.
 406
 407 2019-08-20  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-regs.h (struct tui_data_item_window)
 410         <~tui_data_item_window>: Remove.
 411         <content>: Now a unique_xmalloc_ptr.
 412         * tui/tui-regs.c (tui_register_format): Return a
 413         unique_xmalloc_ptr.
 414         (tui_get_register): Update.
 415         (~tui_data_item_window): Remove.
 416         (tui_data_window::display_registers_from, tui_display_register):
 417         Update.
 418         * tui/tui-io.h (tui_expand_tabs): Update.
 419         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 420         Remove "col" parameter.
 421
 422 2019-08-20  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 425         field.
 426         * tui/tui-regs.c (~tui_data_item_window): Update.
 427
 428 2019-08-20  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 431         earlier.
 432
 433 2019-08-20  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 436
 437 2019-08-20  Tom Tromey  <tom@tromey.com>
 438
 439         * tui/tui-source.h (struct tui_source_window): Update.
 440         * tui/tui-regs.c (tui_show_registers): Update.
 441         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 442         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 443         (NO_REGS_STRING): Remove defines.
 444
 445 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 446
 447         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 448         unnecessary thread walk if remote doesn't support the packet.
 449
 450 2019-08-19  Tom Tromey  <tromey@adacore.com>
 451
 452         * python/py-value.c (value_has_field): Fix indentation.
 453
 454 2019-08-19  Tom Tromey  <tromey@adacore.com>
 455
 456         * printcmd.c (do_one_display, info_display_command): Update.
 457         * block.h (contained_in): Return bool.  Add allow_nested
 458         parameter.
 459         * block.c (contained_in): Return bool.  Add allow_nested
 460         parameter.
 461
 462 2019-08-19  Tom Tromey  <tom@tromey.com>
 463
 464         * configure: Rebuild.
 465         * configure.ac: Disallow the combination of -static-libstdc++ and
 466         source highlight.
 467         * source-cache.c (get_language_name): Handle rust.
 468         (source_cache::get_source_lines): Ignore highlighting exceptions.
 469
 470 2019-08-16  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 473         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 474         (struct tui_source_window_base) <make_visible, refresh_window,
 475         resize>: Remove methods.
 476         <execution_info>: Remove field.
 477         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 478         (tui_show_source_line, tui_source_window_base)
 479         (~tui_source_window_base): Update.
 480         (tui_source_window_base::resize)
 481         (tui_source_window_base::make_visible)
 482         (tui_source_window_base::refresh_window): Remove.
 483         (tui_source_window_base::update_exec_info): Update.
 484         * tui/tui-source.c (tui_source_window::set_contents): Update.
 485         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 486
 487 2019-08-16  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 490         deprecated_query_hook.
 491
 492 2019-08-16  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 495         (tui_update_source_windows_with_line): Update.
 496         * tui/tui-source.h (struct tui_source_window)
 497         <show_symtab_source>: Declare.
 498         (tui_show_symtab_source): Don't declare.
 499         * tui/tui-source.c (tui_show_symtab_source): Rename from
 500         tui_show_symtab_source.
 501
 502 2019-08-16  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-winsource.h (struct tui_source_window_base)
 505         <set_contents>: Declare.
 506         * tui/tui-winsource.c
 507         (tui_source_window_base::update_source_window_as_is): Update.
 508         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 509         Declare.
 510         (tui_set_source_content): Don't declare.
 511         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 512         tui_set_source_content.
 513         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 514         Declare.
 515         (tui_set_disassem_content): Don't declare.
 516         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 517         tui_set_disassem_content.
 518
 519 2019-08-16  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-winsource.h (struct tui_source_window_base)
 522         <update_breakpoint_info>: Declare.
 523         (tui_update_breakpoint_info): Don't declare.
 524         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 525         (tui_update_all_breakpoint_info): Update.
 526         (tui_source_window_base::update_breakpoint_info): Rename from
 527         tui_update_breakpoint_info.
 528         (tui_source_window_base::update_exec_info): Update.
 529
 530 2019-08-16  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-winsource.h (struct tui_source_window_base)
 533         <update_source_window>: Declare.
 534         (tui_update_source_window): Don't declare.
 535         * tui/tui-winsource.c
 536         (tui_source_window_base::update_source_window): Rename from
 537         tui_update_source_window.
 538         (tui_source_window_base::rerender): Update.
 539         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 540         * tui/tui-disasm.c (tui_show_disassem)
 541         (tui_show_disassem_and_update_source)
 542         (tui_disasm_window::maybe_update): Update.
 543
 544 2019-08-16  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-winsource.h (struct tui_source_window_base)
 547         <update_source_window_as_is>: Declare.
 548         (tui_update_source_window_as_is): Don't declare.
 549         * tui/tui-winsource.c (tui_update_source_window): Update
 550         (tui_source_window_base::update_source_window_as_is): Rename from
 551         tui_update_source_window_as_is.
 552         (tui_source_window_base::refill): Update.
 553         * tui/tui-source.c (tui_show_symtab_source): Update.
 554         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 555         Update.
 556
 557 2019-08-16  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-winsource.h (tui_update_source_window)
 560         (tui_update_source_window_as_is): Remove "noerror" parameter.
 561         * tui/tui-winsource.c (tui_update_source_window)
 562         (tui_update_source_window_as_is): Remove "noerror" parameter.
 563         (tui_update_source_windows_with_addr)
 564         (tui_update_source_windows_with_line)
 565         (tui_source_window_base::rerender)
 566         (tui_source_window_base::refill): Update.
 567         * tui/tui-source.h (tui_set_source_content)
 568         (tui_show_symtab_source): Remove "noerror" parameter.
 569         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 570         parameter.
 571         (tui_show_symtab_source): Likewise.
 572         (tui_source_window::maybe_update): Update.
 573         * tui/tui-disasm.c (tui_show_disassem)
 574         (tui_show_disassem_and_update_source)
 575         (tui_disasm_window::do_scroll_vertical)
 576         (tui_disasm_window::maybe_update): Update.
 577
 578 2019-08-16  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui.c (tui_is_window_visible): Update.
 581         * tui/tui-wingeneral.c (tui_make_window)
 582         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 583         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 584         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 585         (tui_set_win_height_command, parse_scrolling_args): Update.
 586         * tui/tui-source.c (tui_source_window::style_changed): Update.
 587         * tui/tui-regs.c (tui_show_registers)
 588         (tui_data_window::first_data_item_displayed)
 589         (tui_data_window::delete_data_content_windows)
 590         (tui_check_register_values, tui_reg_command): Update.
 591         * tui/tui-disasm.c (tui_show_disassem): Update.
 592         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 593         method.
 594         <is_visible>: Remove field.
 595         * tui/tui-data.c (tui_next_win, tui_prev_win)
 596         (tui_delete_invisible_windows): Update.
 597
 598 2019-08-16  Tom Tromey  <tom@tromey.com>
 599
 600         * tui/tui-winsource.h (struct tui_source_window_base)
 601         <m_has_locator>: Remove.
 602         * tui/tui-layout.c (show_source_disasm_command, show_data)
 603         (show_source_or_disasm_and_command): Update.
 604
 605 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 606
 607         * NEWS (Other MI changes): New subsection.
 608         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 609         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 610         * arch-utils.c (default_get_pc_address_flags): New function.
 611         * arch-utils.h (default_get_pc_address_flags): New declaration.
 612         * gdbarch.sh: Add get_pc_address_flags.
 613         * gdbarch.c: Regenerate.
 614         * gdbarch.h: Likewise.
 615         * stack.c (print_pc): New function.
 616         (print_frame_info) (print_frame): Call print_pc.
 617
 618 2019-08-16  Tom de Vries  <tdevries@suse.de>
 619
 620         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 621         print_objfile_section_info.
 622
 623 2019-08-15  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 626         calling update_cmdwin_start_line.
 627         * tui/tui-winsource.h (struct tui_source_window_base)
 628         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 629         <rerender>: Declare.
 630         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 631         Call rerender.
 632         (tui_source_window_base::set_new_height): Remove.
 633         (tui_source_window_base::rerender): Rename from
 634         do_make_visible_with_new_height.
 635         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 636         resize method.
 637         (tui_win_info::make_invisible_and_set_new_height)
 638         (tui_win_info::make_visible_with_new_height): Remove.
 639         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 640         Declare.
 641         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 642         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 643         do_make_visible_with_new_height>: Don't declare.
 644         <rerender>: Declare.
 645         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 646         set_new_height.
 647         (tui_data_window::do_make_visible_with_new_height): Remove.
 648         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 649         call tui_show_locator_content.
 650         (tui_gen_win_info::resize): Call rerender.
 651         (show_source_or_disasm_and_command): Don't call
 652         tui_show_locator_content.
 653         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 654         method.
 655         (struct tui_win_info) <rerender>: Declare.
 656         <set_new_height, make_invisible_and_set_new_height,
 657         make_visible_with_new_height>: Don't declare.
 658         * tui/tui-data.c (tui_win_list::rerender): New method.
 659         * tui/tui-command.h (struct tui_cmd_window)
 660         <do_make_visible_with_new_height>: Don't declare.
 661         * tui/tui-command.c
 662         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 663
 664 2019-08-15  Tom Tromey  <tromey@adacore.com>
 665
 666         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 667         * ada-lang.c (ada_enum_name): Likewise.
 668
 669 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 670
 671         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 672         leading underscore.
 673         (GdbOutputErrorFile): Likewise.
 674         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 675         accordingly.
 676         (execute_unwinders): Rename to have a leading underscore.
 677         (auto_load_packages): Likewise.
 678         (global scope): Adjust call to auto_load_packages accordingly.
 679         (GdbSetPythonDirectory): Likewise.
 680         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 681         instead of execute_unwinders.
 682
 683 2019-08-15  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 686         (show_data): Don't change window visibility.
 687         (tui_gen_win_info::resize): Remove special case for command
 688         window.  Use wresize, when available.
 689         (show_source_or_disasm_and_command): Don't change window
 690         visibility.
 691         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 692         <make_visible>: New method.
 693         * tui/tui-command.c (tui_cmd_window::resize): New method.
 694
 695 2019-08-15  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 698         (struct tui_source_windows): New.
 699         * tui/tui-winsource.c (tui_display_main): Update.
 700         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 701         (new_height_ok, parse_scrolling_args): Update.
 702         * tui/tui-layout.c (show_layout, show_data): Update.
 703         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 704         (tui_add_to_source_windows): Don't declare.
 705         * tui/tui-data.c (source_windows, tui_source_windows)
 706         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 707
 708 2019-08-15  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 711         Rename from reset.
 712         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 713         * tui/tui-layout.c (show_source_disasm_command, show_data):
 714         Update.
 715         (tui_gen_win_info::resize): Rename.
 716         (show_source_or_disasm_and_command): Update.
 717         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 718         reset.
 719
 720 2019-08-15  Tom Tromey  <tom@tromey.com>
 721
 722         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 723         * tui/tui-interp.c (tui_interp::init): Don't call
 724         tui_initialize_static_data.
 725         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 726
 727 2019-08-15  Tom Tromey  <tom@tromey.com>
 728
 729         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 730         examine tui_win_list.
 731
 732 2019-08-15  Tom Tromey  <tom@tromey.com>
 733
 734         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 735         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 736         tui_clear_source_content.
 737         (tui_clear_source_content): Remove.
 738         (tui_source_window_base::do_erase_source_content): Hoist call to
 739         content.clear().
 740         * tui/tui-stack.c (tui_show_frame_info): Don't call
 741         tui_clear_source_content.
 742
 743 2019-08-15  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-winsource.h (struct tui_source_window_base)
 746         <do_erase_source_content>: New method.
 747         <erase_source_content>: New method.
 748         (tui_erase_source_content): Don't declare.
 749         * tui/tui-winsource.c (tui_clear_source_content): Update.
 750         (tui_source_window_base::do_erase_source_content): Rename from
 751         tui_erase_source_content.
 752         (tui_source_window_base::show_source_content): Update.
 753         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 754         * tui/tui-source.h (struct tui_source_window)
 755         <erase_source_content>: New method.
 756         * tui/tui-disasm.h (struct tui_disasm_window)
 757         <erase_source_content>: New method.
 758
 759 2019-08-15  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 762         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 763         constructor.
 764         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 765         * tui/tui-source.c (tui_set_source_content): Update.
 766         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 767
 768 2019-08-15  Tom Tromey  <tom@tromey.com>
 769
 770         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 771         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 772         tui-source.c.
 773         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 774         Declare.
 775         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 776         method.
 777         (tui_source_window::maybe_update): Update.
 778
 779 2019-08-15  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 782         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 783         tui-disasm.c.
 784         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 785         Declare.
 786         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 787         method.
 788         (tui_disasm_window::maybe_update): Update.
 789
 790 2019-08-15  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-winsource.h (struct tui_source_window_base)
 793         <maybe_update>: Declare.
 794         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 795         method.
 796         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 797         Declare.
 798         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 799         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 800         Declare.
 801         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 802
 803 2019-08-15  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 806
 807 2019-08-15  Tom Tromey  <tom@tromey.com>
 808
 809         * tui/tui-wingeneral.c: Include tui-stack.h.
 810         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 811         (struct tui_locator_window): Move from tui-data.h.
 812         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 813         (tui_initialize_static_data): Move from tui-data.c.
 814         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 815         (struct tui_locator_window): Move to tui-stack.c.
 816         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 817         (tui_initialize_static_data): Move to tui-stack.c.
 818
 819 2019-08-15  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-layout.c (show_source_disasm_command)
 822         (show_source_or_disasm_and_command): Use make_visible method, not
 823         tui_make_window.
 824         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 825         Remove.
 826
 827 2019-08-15  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-wingeneral.h (tui_make_window): Update.
 830         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 831         parameter.
 832         (tui_gen_win_info::make_visible): Update.
 833         * tui/tui-regs.c (tui_data_window::display_registers_from):
 834         Update.
 835         * tui/tui-layout.c (show_source_disasm_command)
 836         (show_source_or_disasm_and_command): Update.
 837         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 838         (enum tui_box): Remove.
 839         (struct tui_win_info) <can_box>: New method.
 840         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 841         method.
 842
 843 2019-08-15  Tom de Vries  <tdevries@suse.de>
 844
 845         * linux-nat-trad.c: Include gdbarch.h.
 846
 847 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 848
 849         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 850         register sizes.
 851
 852 2019-08-14  Tom Tromey  <tromey@adacore.com>
 853
 854         * darwin-nat.c: Include gdbarch.h.
 855         * darwin-nat-info.c: Include gdbarch.h.
 856
 857 2019-08-13  Tom Tromey  <tom@tromey.com>
 858
 859         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 860         Remove.
 861         * tui/tui-data.c (tui_initialize_static_data): Update.
 862
 863 2019-08-13  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-winsource.h (struct tui_exec_info_window)
 866         <~tui_exec_info_window, maybe_allocate_content, get_content,
 867         m_content>: Remove.
 868         (struct tui_source_window_base) <set_exec_info_content,
 869         show_exec_info_content>: Don't declare.
 870         * tui/tui-winsource.c
 871         (tui_exec_info_window::maybe_allocate_content): Remove.
 872         (tui_source_window_base::update_exec_info): Rename from
 873         set_exec_info_content.
 874         (tui_source_window_base::show_exec_info_content)
 875         (tui_source_window_base::update_exec_info): Remove.
 876
 877 2019-08-13  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 880         declare.
 881         * tui/tui-winsource.c (tui_update_source_window_as_is)
 882         (tui_update_source_windows_with_addr, tui_erase_source_content):
 883         Update.
 884         (tui_clear_exec_info_content): Remove.
 885
 886 2019-08-13  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 889         declare.
 890         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 891         call tui_erase_exec_info_content.
 892         (tui_clear_exec_info_content): Rename from
 893         tui_erase_exec_info_content.
 894         (tui_clear_exec_info_content): Delete.
 895
 896 2019-08-13  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-winsource.h (struct tui_source_window_base)
 899         <show_exec_info_content>: Declare.
 900         (tui_show_exec_info_content): Don't declare.
 901         * tui/tui-winsource.c
 902         (tui_source_window_base::show_exec_info_content): Rename from
 903         tui_show_exec_info_content.
 904         (tui_source_window_base::update_exec_info): Update.
 905
 906 2019-08-13  Tom Tromey  <tom@tromey.com>
 907
 908         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 909         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 910         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 911         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 912         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 913         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 914         ... here.
 915
 916 2019-08-13  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-winsource.h (struct tui_source_window_base)
 919         <update_exec_info>: Declare.
 920         (tui_update_exec_info): Don't declare.
 921         * tui/tui-winsource.c (tui_update_source_window_as_is)
 922         (tui_source_window_base::refresh_all)
 923         (tui_update_all_breakpoint_info): Update.
 924         (tui_source_window_base::update_exec_info): Rename from
 925         tui_update_exec_info.
 926         * tui/tui-stack.c (tui_show_frame_info): Update.
 927
 928 2019-08-13  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-winsource.h (struct tui_source_window_base)
 931         <set_exec_info_content>: Declare.
 932         (tui_set_exec_info_content): Don't declare.
 933         * tui/tui-winsource.c
 934         (tui_source_window_base::set_exec_info_content): Rename from
 935         tui_set_exec_info_content.
 936         (tui_update_exec_info): Update.
 937
 938 2019-08-13  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-winsource.h (struct tui_source_window_base)
 941         <show_source_content>: Declare.
 942         (tui_show_source_content): Don't declare.
 943         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 944         (tui_source_window_base::show_source_content): Rename from
 945         tui_show_source_content.
 946         (tui_source_window_base::refresh_all): Update.
 947         * tui/tui-layout.c (show_source_disasm_command)
 948         (show_source_or_disasm_and_command): Update.
 949
 950 2019-08-13  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-winsource.c (tui_erase_source_content)
 953         (tui_show_source_content, tui_source_window_base::refresh_all):
 954         Update.
 955         * tui/tui-wingeneral.h
 956         (tui_check_and_display_highlight_if_needed): Don't declare.
 957         * tui/tui-wingeneral.c
 958         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 959         check_and_display_highlight_if_needed.
 960         * tui/tui-win.c (tui_rehighlight_all)
 961         (tui_win_info::make_visible_with_new_height): Update.
 962         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 963         (tui_data_window::erase_data_content)
 964         (tui_data_window::display_all_data): Update.
 965         * tui/tui-data.h (struct tui_win_info)
 966         <check_and_display_highlight_if_needed>: Declare.
 967
 968 2019-08-13  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-win.c (tui_resize_all): Call
 971         tui_delete_invisible_windows.
 972         * tui/tui-layout.c (show_layout): Call
 973         tui_delete_invisible_windows.
 974         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 975         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 976
 977 2019-08-13  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 980         tui_add_win_to_layout.
 981
 982 2019-08-13  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 985         * tui/tui-layout.c (tui_default_win_height): Now static.
 986
 987 2019-08-13  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 990         single switch.
 991         (show_source_disasm_command, show_source_or_disasm_and_command):
 992         Don't check current layout.
 993
 994 2019-08-13  Tom Tromey  <tom@tromey.com>
 995
 996         * tui/tui-wingeneral.c (make_all_visible): Remove.
 997         (tui_make_all_invisible): Simplify.
 998         * tui/tui-layout.c (tui_make_all_invisible): Move from
 999         tui-wingeneral.c; simplify.
1000         (show_layout): Hoist call to tui_make_all_invisible.
1001         (show_data): Don't call tui_make_all_invisible.
1002
1003 2019-08-13  Tom Tromey  <tom@tromey.com>
1004
1005         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1006         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1007
1008 2019-08-13  Tom Tromey  <tom@tromey.com>
1009
1010         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1011         tui-data.c.
1012         (show_source_disasm_command, show_data)
1013         (show_source_or_disasm_and_command): Don't use
1014         tui_set_current_layout_to.
1015         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1016         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1017         tui-layout.c.
1018         (tui_set_current_layout_to): Remove.
1019
1020 2019-08-13  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-layout.c (tui_set_layout): Update.
1023         * tui/tui-data.h (struct tui_layout_def): Remove.
1024         (tui_layout_def): Don't declare.
1025         * tui/tui-data.c (layout_def): Remove.
1026         (tui_layout_def): Remove.
1027
1028 2019-08-13  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-winsource.h (struct tui_source_window_base)
1031         <clear_detail>: No longer "override".
1032         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1033         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1034         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1035         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1036         Remove.
1037         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1038
1039 2019-08-13  Tom Tromey  <tromey@adacore.com>
1040
1041         * tracepoint.c: Don't include readline.h or history.h.
1042
1043 2019-08-12  Tom Tromey  <tom@tromey.com>
1044
1045         * configure: Rebuild.
1046         * configure.ac: Check for readline 7.
1047         * NEWS: Mention readline 7 requirement.
1048         * README: Update.
1049
1050 2019-08-12  Tom Tromey  <tom@tromey.com>
1051
1052         * mingw-hdep.c (gdb_select): Remove readline hack.
1053
1054 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1055
1056         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1057         when the function fails.
1058
1059 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1060
1061         * s390-tdep.c (s390_type_align): New function.
1062         (s390_gdbarch_init): Set it as type_align gdbarch method.
1063
1064 2019-08-09  Tom de Vries  <tdevries@suse.de>
1065
1066         PR gdb/24591
1067         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1068         pc_low with relocation offset.
1069
1070 2019-08-07  Tom Tromey  <tromey@adacore.com>
1071
1072         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1073         (print_frame_args): Update.
1074         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1075         Update.
1076         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1077         * frame.h (struct frame_arg): Add initializers.
1078         <error>: Now a unique_xmalloc_ptr.
1079
1080 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1081
1082         * NEWS: Expand the Pointer Authentication entry.
1083         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1084         (aarch64_frame_unmask_lr): ... to this.
1085         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1086         Call aarch64_frame_unmask_lr.
1087         * frame.c (struct frame_info): Add "masked" variable.
1088         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1089         (fprint_frame): Check for masked pc.
1090         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1091         declarations.
1092         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1093         * stack.c (print_frame): Check for masked pc.
1094
1095 2019-08-06  Tom Tromey  <tom@tromey.com>
1096
1097         * stabsread.c (patch_block_stabs, read_one_struct_field)
1098         (read_enum_type): Use obstack_strndup.
1099         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1100         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1101         * dwarf2read.c (guess_full_die_structure_name)
1102         (anonymous_struct_prefix): Use obstack_strndup.
1103         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1104         * c-exp.y (yylex): Use obstack_strndup.
1105         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1106         (write_var_or_type): Use obstack_strndup.
1107
1108 2019-08-06  Tom Tromey  <tom@tromey.com>
1109
1110         * symfile.c (reread_symbols): Use obstack_strdup.
1111         * stabsread.c (read_type): Use obstack_strdup.
1112         * gdb_obstack.h (obstack_strdup): New overload.
1113         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1114         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1115         (dwarf2_canonicalize_name): Use obstack_strdup.
1116         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1117         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1118         Use obstack_strdup.
1119
1120 2019-08-06  Tom Tromey  <tom@tromey.com>
1121
1122         * gdb_obstack.h (obstack_strdup): Define.
1123         * gdb_obstack.c (obstack_strdup): Don't define.
1124
1125 2019-08-06  Tom Tromey  <tom@tromey.com>
1126
1127         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1128         obstack_strdup.
1129         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1130         obstack_strdup.
1131         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1132         * stabsread.c (common_block_start): Use obstack_strdup.
1133         * objfiles.c (set_objfile_main_name, objfile): Use
1134         obstack_strdup.
1135         * namespace.c (add_using_directive): Use obstack_strdup.
1136         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1137         * jit.c (finalize_symtab): Use obstack_strdup.
1138         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1139         (guess_partial_die_structure_name, partial_die_info::fixup)
1140         (dwarf2_name): Use obstack_strdup.
1141         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1142         obstack_strdup.
1143         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1144         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1145         obstack_strdup.
1146         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1147
1148 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1149
1150         * unittests/help-doc-selftests.c: New file.
1151         * Makefile.in: Add the new file.
1152
1153 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1154
1155         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1156         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1157         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1158         the trailing '.' is not output, and the first character is uppercased.
1159         (print_help_for_command): Update call to print_doc_line.
1160         (print_doc_of_command): Likewise.
1161         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1162         * cli/cli-option.c (append_indented_doc): Do not append newline.
1163         (build_help_option): Append newline after first appended_indented_doc
1164         only if a second call is done.
1165         (build_help): Append 2 new lines before each option, except the first
1166         one.
1167         * compile/compile.c (_initialize_compile): Add new lines after
1168         %OPTIONS%, when not at the end of the help.
1169         Change help doc or code
1170         producing the help doc to respect the invariants.
1171         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1172         Also removed the new line after 'Options:', as all other commands
1173         do not put an empty line between 'Options:' and the first option.
1174         * printcmd.c (_initialize_printcmd): Likewise.
1175         * stack.c (_initialize_stack): Likewise.
1176         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1177         incorrectly telling COMMAND is optional.
1178         * ada-lang.c (_initialize_ada_language): Change help doc or code
1179         producing the help doc to respect the invariants.
1180         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1181         * breakpoint.c (_initialize_breakpoint): Likewise.
1182         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1183         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1184         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1185         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1186         _initialize_cli_style): Likewise.
1187         * corelow.c (core_target_info): Likewise.
1188         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1189         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1190         * filesystem.c (_initialize_filesystem): Likewise.
1191         * frame.c (_initialize_frame): Likewise.
1192         * gnu-nat.c (add_task_commands): Likewise.
1193         * infcall.c (_initialize_infcall): Likewise.
1194         * infcmd.c (_initialize_infcmd): Likewise.
1195         * interps.c (_initialize_interpreter): Likewise.
1196         * language.c (_initialize_language): Likewise.
1197         * linux-fork.c (_initialize_linux_fork): Likewise.
1198         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1199         * maint.c (_initialize_maint_cmds): Likewise.
1200         * memattr.c (_initialize_mem): Likewise.
1201         * printcmd.c (_initialize_printcmd): Likewise.
1202         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1203         _RegEx): Likewise.
1204         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1205         * record-btrace.c (_initialize_record_btrace): Likewise.
1206         * record-full.c (_initialize_record_full): Likewise.
1207         * record.c (_initialize_record): Likewise.
1208         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1209         * regcache.c (_initialize_regcache): Likewise.
1210         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1211         _initialize_remote): Likewise.
1212         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1213         * serial.c (_initialize_serial): Likewise.
1214         * skip.c (_initialize_step_skip): Likewise.
1215         * source.c (_initialize_source): Likewise.
1216         * stack.c (_initialize_stack): Likewise.
1217         * symfile.c (_initialize_symfile): Likewise.
1218         * symtab.c (_initialize_symtab): Likewise.
1219         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1220         * top.c (init_main): Likewise.
1221         * tracefile-tfile.c (tfile_target_info): Likewise.
1222         * tracepoint.c (_initialize_tracepoint): Likewise.
1223         * tui/tui-win.c (_initialize_tui_win): Likewise.
1224         * utils.c (add_internal_problem_command): Likewise.
1225         * valprint.c (value_print_option_defs): Likewise.
1226
1227 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1228
1229         PR build/24886
1230         * configure.ac: Drop enable-libmcheck support.
1231         * configure, config.in: Rebuild.
1232         * libmcheck.m4: Remove.
1233         * acinclude.m4: Don't include it.
1234         * Makefile.in: Don't distribute it.
1235         * top.c (print_gdb_configuration): Don't mention it.
1236
1237 2019-08-06  Tom Tromey  <tom@tromey.com>
1238
1239         * utils.c (set_output_style): Sometimes pass stream to
1240         emit_style_escape.
1241         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1242         * record-btrace.c (btrace_insn_history): Update.
1243         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1244         method.
1245         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1246         Update initializers.
1247         <m_uiout>: New field.
1248         <m_di>: Move lower.
1249         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1250         Remove "uiout" parameter.
1251         (dump_insns): Update.
1252         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1253         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1254
1255 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1256
1257         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1258         (error_in_psymtab_expansion): Likewise.
1259         (lookup_symbol_via_quick_fns): Likewise.
1260         (basic_lookup_transparent_type_quick): Likewise.
1261         (basic_lookup_transparent_type_1): Likewise.
1262
1263 2019-08-06  Tom Tromey  <tromey@adacore.com>
1264
1265         * source.c (last_source_error): Now bool.
1266         (print_source_lines_base): Make "noprint" bool.  Only open
1267         source file when last_source_visited changes.
1268
1269 2019-08-06  Tom Tromey  <tromey@adacore.com>
1270
1271         * annotate.c (annotate_source_line): Use g_source_cache.
1272         * source-cache.c (source_cache::get_plain_source_lines): Change
1273         parameters.  Populate m_offset_cache.
1274         (source_cache::ensure): New method.
1275         (source_cache::get_line_charpos): New method.
1276         (extract_lines): Move lower.  Change parameters.
1277         (source_cache::get_source_lines): Move lower.
1278         * source-cache.h (class source_cache): Update comment.
1279         <get_line_charpos>: New method.
1280         <get_source_lines>: Update comment.
1281         <clear>: Clear m_offset_cache.
1282         <get_plain_source_lines>: Change parameters.
1283         <ensure>: New method
1284         <m_offset_cache>: New member.
1285         * source.c (forget_cached_source_info_for_objfile): Update.
1286         (info_source_command): Use g_source_cache.
1287         (find_source_lines, open_source_file_with_line_charpos): Remove.
1288         (print_source_lines_base, search_command_helper): Use g_source_cache.
1289         * source.h (open_source_file_with_line_charpos): Don't declare.
1290         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1291         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1292         Use g_source_cache.
1293
1294 2019-08-06  Tom Tromey  <tromey@adacore.com>
1295
1296         * source-cache.c (source_cache::get_plain_source_lines):
1297         Remove "first_line" and "last_line" parameters.
1298         (source_cache::get_source_lines): Cache plain text.
1299         * source-cache.h (class source_cache)
1300         <get_plain_source_lines>: Update.
1301
1302 2019-08-06  Tom Tromey  <tromey@adacore.com>
1303
1304         * source-cache.c (extract_lines): No longer a method.
1305         Changed type of parameter.  Include final newline.
1306         (selftests::extract_lines_test): New function.
1307         (_initialize_source_cache): Likewise.
1308         * source-cache.h (class source_cache)
1309         <extract_lines>: Don't declare.
1310
1311 2019-08-06  Tom Tromey  <tromey@adacore.com>
1312
1313         * breakpoint.c (init_breakpoint_sal): Update.
1314         (breakpoint): Update.
1315         * breakpoint.h (struct breakpoint) <filter>: Now a
1316         unique_xmalloc_ptr.
1317
1318 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1319
1320         * NEWS: Mention dictionary access on blocks.
1321         * python/py-block.c (blpy_getitem): New function.
1322         (block_object_as_mapping): New struct.
1323         (block_object_type): Use new struct for tp_as_mapping field.
1324
1325 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1326
1327         * objfiles.h (objfile): Add a comment describing partial symbols.
1328
1329 2019-08-05  Tom Tromey  <tromey@adacore.com>
1330
1331         * compile/compile.c (_initialize_compile): Use _(), not N_().
1332         * thread.c (_initialize_thread): Use _(), not N_().
1333         * stack.c (_initialize_stack): Use _(), not N_().
1334         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1335
1336 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1337
1338         * dwarf2read.c (struct dw2_symtab_iterator):
1339         <want_specific_block>: Remove.
1340         <block_index>: Change type to gdb::optional.
1341         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1342         change type of BLOCK_INDEX parameter to gdb::optional.
1343         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1344         (dw2_lookup_symbol): Don't pass argument for
1345         WANT_SPECIFIC_BLOCK.
1346         (dw2_expand_symtabs_for_function): Don't pass argument for
1347         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1348         (class dw2_debug_names_iterator)
1349         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1350         parameter, change BLOCK_INDEX type to gdb::optional.
1351         <m_want_specific_block>: Remove.
1352         <m_block_index>: Change type to gdb::optional.
1353         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1354         gdb::optional.  Re-write in function of gdb::optional.
1355         (dw2_debug_names_lookup_symbol): Don't pass argument for
1356         WANT_SPECIFIC_BLOCK.
1357         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1358         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1359         BLOCK_INDEX.
1360
1361 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1362
1363         * NEWS: Mention changes to "info sources" command.
1364
1365 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1366
1367         * symtab.c (filename_partial_match_opts): New struct type.
1368         (struct output_source_filename_data): New members
1369         regexp, c_regexp, partial_match.
1370         (output_source_filename): Use new members to decide to print file.
1371         (info_sources_option_defs): New variable.
1372         (make_info_sources_options_def_group, print_info_sources_header,
1373         info_sources_command_completer):
1374         New functions.
1375         (info_sources_command): Read new optional arguments.
1376         (_initialize_symtab): Update info sources help.
1377
1378 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1379
1380         * ada-lang.c (exception_support_info_v0): Renamed from...
1381         (default_exception_support_info): ... this.  Create new
1382         definition for v1.
1383         (ada_has_this_exception_support): Look up catch_handlers_sym.
1384         (ada_exception_support_info_sniffer): Try v0 after default.
1385
1386 2019-08-01  Tom Tromey  <tromey@adacore.com>
1387
1388         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1389         gdbarch.h.
1390
1391 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1392
1393         * s12z-tdep.c: Fix include path for s12z-opc.h.
1394
1395 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1396
1397         * NEWS: Require GNU make 3.82.
1398
1399 2019-07-16  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1402         declare.
1403
1404 2019-07-30  Tom Tromey  <tromey@adacore.com>
1405
1406         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1407
1408 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1409
1410         * printcmd.c (print_address_symbolic): Print negative offsets.
1411         (build_address_symbolic): Force signed arithmetic when computing
1412         offset.
1413
1414 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1415
1416         PR/24474: Add a function to lookup static variables.
1417         * NEWS: Mention this new function.
1418         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1419         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1420         * python/python.c (python_GdbMethods): Add new function.
1421
1422 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1423
1424         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1425         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1426         (objfpy_lookup_static_symbol): New function.
1427         (objfile_object_methods): Add new functions.
1428
1429 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1430
1431         * NEWS: Mention 'set|show print frame-info'.  Mention new
1432         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1433         backtrace argument.  Mention that python frame filtering code
1434         is now consistent with what 'backtrace' command prints.
1435
1436 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1437
1438         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1439         comments.
1440         (print_frame_info_auto, print_frame_info_source_line,
1441         print_frame_info_location, print_frame_info_source_and_location,
1442         print_frame_info_location_and_address, print_frame_info_short_location):
1443         New declarations.
1444         (struct frame_print_options): New member print_frame_info.
1445         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1446         * stack.h (get_user_print_what_frame_info): New declaration.
1447         (frame_show_address): New declaration.
1448         * stack.c (print_frame_arguments_choices): New value 'presence'.
1449         (print_frame_info_auto, print_frame_info_source_line,
1450         print_frame_info_location, print_frame_info_source_and_location,
1451         print_frame_info_location_and_address, print_frame_info_short_location,
1452         print_frame_info_choices, print_frame_info_print_what): New definitions.
1453         (print_frame_args): Only print dots for args if print frame-arguments
1454         is 'presence'.
1455         (frame_print_option_defs): New element for "frame-info".
1456         (get_user_print_what_frame_info): New function.
1457         (frame_show_address): Make non static.  Move comment to stack.h.
1458         (print_frame_info_to_print_what): New function.
1459         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1460         to decide what to print.
1461         (backtrace_command_1): Handle the new print_frame_arguments_presence
1462         value.
1463         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1464         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1465         (py_print_frame): In non-mi mode, use LOCATION as default for
1466         print_what, similarly to frame information printed directly by
1467         backtrace command. Handle frame-info user option in non MI mode.
1468
1469 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1470
1471         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1472         Add case for debugging 32-bit target on 64-bit host.  Revise
1473         comment.
1474
1475 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1476
1477         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1478         instead of find_function_entry_range_from_pc.
1479
1480 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1481
1482         * stack.c (find_frame_funname): Remove code which preferred
1483         minsym over symtab sym in "certain pathological cases".
1484
1485         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1486         parameter.  Change type of "do_demangle" to bool.
1487         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1488         Pass suitable "prefer_sym_over_minsym" flag to
1489         build_address_symbolic().  Don't output "+" for negative offsets.
1490         * printcmd.c (print_address_symbolic): Update invocation of
1491         build_address_symbolic to include a "prefer_sym_over_minsym"
1492         flag.
1493         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1494         Restrict cases in which use of minimal symbol is preferred to that
1495         of a found symbol.  Update comments.
1496
1497         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1498         for entry pc when entry pc is out of range for that FDE.
1499
1500 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1501
1502         PR gdb/24839:
1503         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1504         type.
1505
1506 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1507
1508         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1509         this function's Python signature.
1510
1511
1512 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1513
1514         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1515         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1516         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1517         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1518         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1519
1520
1521 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1522
1523         * h8300-tdep.c (h8300_register_name_common): New.
1524         h8300_register_name): Use h8300_register_name_common.
1525         (h8300s_register_name): Likewise.
1526         (h8300sx_register_name): Likewise.
1527         (h8300h_register_nam): New.
1528         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1529
1530
1531 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1532
1533         * arm-tdep.c (arm_skip_cmse_entry): New function.
1534         (arm_is_sgstubs_section): New function.
1535         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1536
1537 2019-07-22  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1540         Don't self-assign.
1541
1542 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1545         type_print.
1546
1547 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1548
1549         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1550         so that GDB doesn't match any msymbols when searching in the
1551         TYPES_DOMAIN.
1552         (print_symbol_info): Print using typedef_print or type_print based
1553         on the type of the symbol.  Add updated FIXME comment moved from...
1554         (_initialize_symtab): ... move and update FIXME comment to above.
1555
1556 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * NEWS: Mention adding -q option to "info types".
1559         * symtab.c (struct info_types_options): New struct.
1560         (info_types_options_defs): New variable.
1561         (make_info_types_options_def_group): New function.
1562         (info_types_command): Use gdb::option framework to parse options.
1563         (info_types_command_completer): New function.
1564         (_initialize_symtab): Extend the help text on "info types" and
1565         register command completer.
1566
1567 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1568
1569         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1570         (lookup_symbol_in_objfile): Change int to block_enum and add a
1571         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1572
1573 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1574
1575         * MAINTAINERS (Write After Approval): Add self.
1576
1577 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1578
1579         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1580         instruction to the dummy code region.
1581
1582 2019-07-19  Tom Tromey  <tromey@adacore.com>
1583
1584         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1585         (ARGSUSED, PARAMS, __func__): Remove rules.
1586
1587 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1588
1589         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1590         * features/arm/arm-with-iwmmxt.c: Remove.
1591         * features/arm/arm-with-iwmmxt.xml: Remove.
1592         * features/arm/arm-with-m-fpa-layout.c: Remove.
1593         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1594         * features/arm/arm-with-m-vfp-d16.c: Remove.
1595         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1596         * features/arm/arm-with-m.c: Remove.
1597         * features/arm/arm-with-m.xml: Remove.
1598         * features/arm/arm-with-neon.c: Remove.
1599         * features/arm/arm-with-neon.xml: Remove.
1600         * features/arm/arm-with-vfpv2.c: Remove.
1601         * features/arm/arm-with-vfpv2.xml: Remove.
1602         * features/arm/arm-with-vfpv3.c: Remove.
1603         * features/arm/arm-with-vfpv3.xml: Remove.
1604
1605 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1606
1607         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1608
1609 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1610
1611         * arch/aarch32.c (aarch32_create_target_description): Create
1612         target descriptions using features.
1613         * arch/arm.c (arm_create_target_description)
1614         (arm_create_mprofile_target_description): Likewise.
1615         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1616
1617 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1618
1619         * Makefile.in: Add new files.
1620         * aarch32-tdep.c: New file.
1621         * aarch32-tdep.h: New file.
1622         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1623         Call aarch32_read_description.
1624         * arch/aarch32.c: New file.
1625         * arch/aarch32.h: New file.
1626         * arch/arm.c (arm_create_target_description)
1627         (arm_create_mprofile_target_description): New function.
1628         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1629         (arm_create_target_description)
1630         (arm_create_mprofile_target_description): New declaration.
1631         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1632         read_description functions.
1633         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1634         Likewise.
1635         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1636         * arm-tdep.c (tdesc_arm_list): New variable.
1637         (arm_register_g_packet_guesses): Call create description functions.
1638         (arm_read_description) (arm_read_mprofile_description): New
1639         function.
1640         * arm-tdep.h (arm_read_description)
1641         (arm_read_mprofile_description): Add declaration.
1642         * configure.tgt: Add new files.
1643
1644 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1645
1646         * top.c (new_ui_command): Open specified terminal just once.
1647
1648 2019-07-18  Tom Tromey  <tromey@adacore.com>
1649
1650         * symtab.c (main_name): Constify return type.
1651         * symfile.c (set_initial_language): Update.
1652         * symtab.h (main_name): Constify return type.
1653
1654 2019-07-17  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-winsource.c (tui_update_source_window)
1657         (tui_update_source_window_as_is)
1658         (tui_update_source_windows_with_line): Remove return.
1659         * tui/tui-disasm.c (tui_show_disassem)
1660         (tui_show_disassem_and_update_source): Remove return.
1661         * tui/tui.c (tui_reset): Remove return.
1662         * tui/tui-wingeneral.c
1663         (tui_check_and_display_highlight_if_needed): Remove return.
1664
1665 2019-07-17  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1668
1669 2019-07-17  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-winsource.h (struct tui_exec_info_window)
1672         (struct tui_source_window_base): Move from tui-data.h.
1673         * tui/tui-winsource.c: Move many method definitions from
1674         elsewhere.  Remove "structuring" comments.
1675         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1676         (tui_source_window_base::refresh_window): Move to
1677         tui-winsource.c.
1678         * tui/tui-win.c (tui_source_window_base::refresh_all)
1679         (tui_source_window_base::update_tab_width)
1680         (tui_source_window_base::set_new_height)
1681         (tui_source_window_base::do_make_visible_with_new_height): Move to
1682         tui-winsource.c.
1683         * tui/tui-source.h: Update.
1684         * tui/tui-source.c (tui_source_window_base::reset): Move to
1685         tui-winsource.c.
1686         * tui/tui-disasm.h: Update.
1687         * tui/tui-data.h (struct tui_exec_info_window): Move to
1688         tui-winsource.h.
1689         (struct tui_source_window_base): Likewise.
1690         * tui/tui-data.c (tui_source_window_base::clear_detail)
1691         (tui_source_window_base, ~tui_source_window_base): Move to
1692         tui-winsource.c.
1693
1694 2019-07-17  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-win.c (tui_resize_all)
1697         (tui_source_window_base::update_tab_width)
1698         (tui_adjust_win_heights): Update.
1699         (tui_win_info::make_invisible_and_set_new_height): Rename from
1700         make_invisible_and_set_new_height.
1701         * tui/tui-data.h (struct tui_win_info)
1702         <make_invisible_and_set_new_height>: New method.
1703
1704 2019-07-17  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui.c: Update.
1707         * tui/tui-source.h (struct tui_source_window): Move from
1708         tui-data.h.
1709         * tui/tui-layout.c: Update.
1710         * tui/tui-disasm.c: Update.
1711         * tui/tui-data.h (struct tui_source_window): Move to
1712         tui-source.h.
1713
1714 2019-07-17  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1717         tui-data.h.
1718         * tui/tui-data.h (struct tui_disasm_window): Move to
1719         tui-disasm.h.
1720
1721 2019-07-17  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-regs.h (struct tui_data_item_window): Move from
1724         tui-data.h.
1725         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1726         * tui/tui-data.h (struct tui_data_item_window): Move to
1727         tui-regs.h.
1728         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1729
1730 2019-07-17  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui.c: Update.
1733         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1734         (tui_cmd_window::max_height): Move to tui-command.c.
1735         * tui/tui-layout.c: Update.
1736         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1737         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1738         tui-command.c.
1739         * tui/tui-command.h (struct tui_cmd_window): Move from
1740         tui-data.h.
1741         * tui/tui-command.c: Remove "structuring" comments.
1742         (tui_cmd_window::clear_detail)
1743         (tui_cmd_window::do_make_visible_with_new_height)
1744         (tui_cmd_window::max_height): Move from elsewhere.
1745
1746 2019-07-17  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1749         Now static.
1750         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1751         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1752
1753 2019-07-17  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui.c: Update.
1756         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1757         tui-regs.c.
1758         * tui/tui-windata.h: Remove file.
1759         * tui/tui-windata.c: Remove file.
1760         * tui/tui-win.c (tui_data_window::set_new_height)
1761         (tui_data_window::do_make_visible_with_new_height): Move to
1762         tui-regs.c.
1763         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1764         * tui/tui-regs.c: Remove "structuring" comments.
1765         (tui_data_window::first_data_item_displayed)
1766         (tui_data_window::delete_data_content_windows)
1767         (tui_data_window::erase_data_content)
1768         (tui_data_window::display_all_data)
1769         (tui_data_window::refresh_all)
1770         (tui_data_window::do_scroll_vertical)
1771         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1772         (tui_data_window::do_make_visible_with_new_height)
1773         (tui_data_window::refresh_window): Move from elsewhere.
1774         (_initialize_tui_regs): Move to end of file.
1775         * tui/tui-layout.c: Update.
1776         * tui/tui-hooks.c: Update.
1777         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1778         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1779         tui-regs.c.
1780         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1781
1782 2019-07-17  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1785         seen.
1786
1787 2019-07-17  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-win.c (tui_source_window_base::set_new_height)
1790         (tui_source_window_base::do_make_visible_with_new_height): Use
1791         m_has_locator field directly.
1792         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1793         method.
1794         (struct tui_source_window_base) <has_locator>: Likewise.
1795
1796 2019-07-17  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1799         Don't declare.
1800         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1801         Remove.
1802         * tui/tui-win.c (tui_source_window_base::set_new_height)
1803         (tui_source_window_base::set_new_height)
1804         (make_invisible_and_set_new_height)
1805         (tui_source_window_base::do_make_visible_with_new_height)
1806         (tui_source_window_base::do_make_visible_with_new_height):
1807         Update.
1808         * tui/tui-layout.c (show_source_disasm_command, show_data)
1809         (show_source_or_disasm_and_command): Update.
1810         * tui/tui-layout.c (show_layout): Update.
1811
1812 2019-07-17  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-layout.c (make_data_window): Remove.
1815         (show_data): Unify creation and re-initialization cases.
1816
1817 2019-07-17  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-layout.c (make_source_window, make_disasm_window):
1820         Remove.
1821         (show_data): Unify creation and re-initialization cases.
1822
1823 2019-07-17  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-layout.c (make_command_window): Remove.
1826         (show_source_disasm_command, show_source_or_disasm_and_command):
1827         Unify creation and re-initialization cases.
1828
1829 2019-07-17  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1832         creation and re-initialization cases.
1833
1834 2019-07-17  Tom Tromey  <tom@tromey.com>
1835
1836         * tui/tui-regs.c (tui_get_register): Return void.
1837
1838 2019-07-17  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1841         Simplify.
1842
1843 2019-07-17  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1846         resetting.
1847
1848 2019-07-17  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1851         * tui/tui-regs.c (tui_reg_layout): New function.
1852         (tui_show_registers, tui_reg_command): Use it.
1853         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1854         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1855         parameters.
1856         (tui_layout_command): Remove.
1857
1858 2019-07-17  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-layout.h (tui/tui-layout): Return void.
1861         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1862
1863 2019-07-17  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-layout.c (show_source_disasm_command, show_data):
1866         Update.
1867         (reset_locator): Remove.
1868         (show_source_or_disasm_and_command): Update.
1869
1870 2019-07-17  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-source.c (tui_source_window_base::reset): Remove
1873         win_type parameter.
1874         * tui/tui-layout.c (make_command_window, make_source_window)
1875         (make_disasm_window, make_data_window)
1876         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1877         (reset_locator, show_source_or_disasm_and_command): Update.
1878         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1879         win_type parameter.
1880         (struct tui_source_window_base) <reset>: Likewise.
1881
1882 2019-07-17  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-layout.c (show_source_disasm_command): Use
1885         reset_locator.
1886         (reset_locator): New function.
1887         (init_and_make_win): Remove.
1888         (show_source_or_disasm_and_command): Use reset_locator.
1889
1890 2019-07-17  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1893         condition.
1894         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1895         Remove condition.
1896         * tui/tui-source.c (tui_source_window_base::reset): New method.
1897         * tui/tui-layout.c (make_command_window): Don't call
1898         init_and_make_win.
1899         (make_source_window, make_disasm_window): Don't call
1900         make_source_or_disasm_window.
1901         (make_data_window): Don't call init_and_make_win.  Change calling
1902         convention.
1903         (show_source_disasm_command, show_data): Simplify.
1904         (make_source_or_disasm_window): Remove.
1905         (show_source_or_disasm_and_command): Simplify.
1906         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1907         (struct tui_source_window_base) <reset>: Likewise.
1908         <execution_info>: Remove initializer.
1909         * tui/tui-data.c (tui_source_window_base): Initialize
1910         execution_info.
1911
1912 2019-07-17  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1915         variable.
1916
1917 2019-07-17  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui.c (tui_rl_other_window): Update.
1920         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1921         superclass method first.  Always iterate over regs_content.
1922         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1923         method.
1924         * tui/tui-win.c (tui_set_focus_command): Update.
1925
1926 2019-07-17  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-win.c (tui_set_focus_command): Rename from
1929         tui_set_focus.  Call tui_enable.
1930         (tui_set_focus_command): Remove.
1931
1932 2019-07-17  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1935         refresh_window.
1936         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1937         touchwin.
1938         (tui_data_window::refresh_window): Call refresh_window on data
1939         items.  Always call superclass refresh_window.
1940         (tui_win_info::refresh): Remove.
1941         (tui_source_window_base::refresh_window): Update.
1942         (tui_refresh_all): Update.
1943         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1944         refresh_window.
1945         (show_source_or_disasm_and_command): Likewise.
1946         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1947         (struct tui_source_window_base) <refresh>: Likewise.
1948
1949 2019-07-17  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-winsource.c (tui_clear_source_content)
1952         (tui_show_source_content): Update.
1953         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1954         whether content is empty.
1955         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1956         Remove.
1957
1958 2019-07-17  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1961         window's contents.
1962         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1963         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1964
1965 2019-07-17  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1968         (struct tui_data_item_window): Update.
1969
1970 2019-07-17  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1973         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1974         defines.
1975
1976 2019-07-17  Tom Tromey  <tom@tromey.com>
1977
1978         * tui/tui-winsource.h (tui_erase_source_content)
1979         (tui_clear_source_content): Remove "display_prompt" parameter.
1980         * tui/tui-winsource.c (tui_update_source_window_as_is)
1981         (tui_update_source_windows_with_addr): Update.
1982         (tui_clear_source_content): Remove "display_prompt" parameter.
1983         (tui_erase_source_content): Likewise.  Simplify.
1984         (tui_show_source_content): Update.
1985         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1986         * tui/tui-stack.c (tui_show_frame_info): Update.
1987         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1988         Remove defines.
1989
1990 2019-07-17  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1993         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1994         parameter.
1995         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1996         parameter.
1997
1998 2019-07-17  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-winsource.c (tui_clear_source_content)
2001         (tui_show_source_content, tui_show_exec_info_content)
2002         (tui_clear_exec_info_content): Update.
2003         * tui/tui-stack.c (tui_show_locator_content): Update.
2004         (tui_show_frame_info): Update.
2005         * tui/tui-source.h (tui_source_window): Don't declare.
2006         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2007         from tui_source_is_displayed.
2008         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2009         Remove field.
2010         (struct tui_source_window_base) <content_in_use>: New field.  Now
2011         bool.
2012         (struct tui_source_window) <showing_source_p>: New method.
2013         (TUI_SRC_WIN): Change cast.
2014         * tui/tui-data.c (tui_initialize_static_data): Update.
2015
2016 2019-07-17  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2019         location_matches_p.
2020         * tui/tui-source.c (tui_source_window::location_matches_p): New
2021         method.
2022         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2023         method.
2024         * tui/tui-data.h (struct tui_source_window_base)
2025         <location_matches_p>: New method.
2026         (struct tui_source_window, struct tui_disasm_window)
2027         <location_matches_p>: Likewise.
2028
2029 2019-07-17  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-win.c (tui_set_win_height_command): Rename from
2032         tui_set_win_height.
2033         (tui_set_win_height_command): Remove.
2034
2035 2019-07-17  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-source.c (tui_source_window): New constructor.  Add
2038         observer.
2039         (~tui_source_window): New destructor.
2040         (tui_source_window::style_changed): New method.
2041         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2042         (tui_attach_detach_observers): Update.
2043         * tui/tui-data.h (struct tui_source_window): Make constructor not
2044         inline.  Add destructor.
2045         (struct tui_source_window) <style_changed>: New method.
2046         <m_observable>: New member.
2047
2048 2019-07-17  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2051         * tui/tui-win.c (tui_resize_all): Fix typo.
2052
2053 2019-07-17  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2056         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2057         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2058         * tui/tui-win.c (window_name_completer): Use foreach.
2059         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2060         (update_tab_width): Likewise.
2061         * tui/tui-layout.c (show_layout): Update.
2062         * tui/tui-data.h (class tui_window_iterator): New.
2063         (struct all_tui_windows): New.
2064         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2065
2066 2019-07-17  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2069         parameter.  Don't reference globals.
2070         (tui_reg_command): Update.
2071
2072 2019-07-17  Tom Tromey  <tom@tromey.com>
2073
2074         * tui/tui-regs.c (tui_show_registers): Simplify.
2075
2076 2019-07-17  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-regs.c (tui_show_registers): Update.
2079         (tui_show_register_group): Add win_info parameter.
2080
2081 2019-07-17  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2084         Rename from tui_display_reg_element_at_line.
2085         (tui_data_window::display_registers_from_line): Update.
2086         * tui/tui-data.h (struct tui_data_window)
2087         <display_reg_element_at_line>: New method.
2088
2089 2019-07-17  Tom Tromey  <tom@tromey.com>
2090
2091         * tui/tui-regs.h (tui_display_registers_from)
2092         (tui_display_registers_from_line): Don't declare.
2093         * tui/tui-windata.c (tui_data_window::display_all_data)
2094         (tui_data_window::refresh_all)
2095         (tui_data_window::do_scroll_vertical): Update.
2096         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2097         from tui_display_registers_from.
2098         (tui_display_reg_element_at_line): Update.
2099         (tui_data_window::display_registers_from_line): Rename from
2100         tui_display_registers_from_line.
2101         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2102         display_registers_from_line>: New methods.
2103
2104 2019-07-17  Tom Tromey  <tom@tromey.com>
2105
2106         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2107         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2108         from tui_erase_data_content.
2109         (tui_data_window::display_all_data)
2110         (tui_data_window::refresh_all)
2111         (tui_data_window::do_scroll_vertical): Update.
2112         * tui/tui-regs.c (tui_show_registers): Update.
2113         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2114         New method.
2115
2116 2019-07-17  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2119         declare.
2120         * tui/tui-windata.c
2121         (tui_data_window::delete_data_content_windows): Rename from
2122         tui_delete_data_content_windows.
2123         (tui_data_window::display_all_data)
2124         (tui_data_window::do_scroll_vertical): Update.
2125         * tui/tui-data.h (struct tui_data_window)
2126         <delete_data_content_windows>: New method.
2127
2128 2019-07-17  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2131         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2132
2133 2019-07-17  Tom Tromey  <tom@tromey.com>
2134
2135         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2136         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2137         from tui_display_all_data.
2138         * tui/tui-win.c
2139         (tui_data_window::do_make_visible_with_new_height): Update.
2140         * tui/tui-regs.c (tui_show_registers): Update.
2141         * tui/tui-layout.c (tui_set_layout): Update.
2142         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2143         method.
2144
2145 2019-07-17  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2148         * tui/tui-windata.c (tui_display_data_from): Remove.
2149         (tui_data_window::refresh_all): Update.
2150
2151 2019-07-17  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2154         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2155         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2156         tui_display_registers_from_line.
2157         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2158         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2159         "force_display" parameter.
2160
2161 2019-07-17  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2164         declare.
2165         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2166         Rename from tui_first_reg_element_no_inline.
2167         (tui_display_reg_element_at_line)
2168         (tui_display_registers_from_line): Update.
2169         * tui/tui-data.h (struct tui_data_window)
2170         <first_reg_element_no_inline>: New method.
2171
2172 2019-07-17  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-windata.c (tui_display_data_from)
2175         (tui_data_window::do_scroll_vertical): Update.
2176         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2177         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2178         Rename from tui_line_from_reg_element_no.
2179         (tui_display_registers_from_line): Update.
2180         * tui/tui-data.h (struct tui_data_window)
2181         <line_from_reg_element_no>: New method.
2182
2183 2019-07-17  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2186         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2187         tui_last_regs_line_no.
2188         (tui_display_reg_element_at_line)
2189         (tui_display_registers_from_line): Update.
2190         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2191         method.
2192
2193 2019-07-17  Tom Tromey  <tom@tromey.com>
2194
2195         PR tui/24722:
2196         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2197         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2198         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2199         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2200         (tui_update_breakpoint_info): Likewise.
2201         * tui/tui-hooks.c (tui_event_create_breakpoint)
2202         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2203         Update.
2204
2205 2019-07-17  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2208
2209 2019-07-17  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-winsource.c (tui_update_source_window_as_is)
2212         (tui_update_source_windows_with_addr): Update.
2213         * tui/tui-source.h (tui_set_source_content)
2214         (tui_show_symtab_source): Add "win_info" parameter.
2215         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2216         parameter.
2217         (tui_show_symtab_source): Likewise.
2218
2219 2019-07-17  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-wingeneral.c
2222         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2223
2224 2019-07-17  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2227         (struct tui_cmd_window) <can_scroll>: New method.
2228         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2229         method.
2230
2231 2019-07-17  Tom Tromey  <tromey@adacore.com>
2232
2233         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2234         do_field_signed>: Rename.  Change type of "value".
2235         * ui-out.c (ui_out::field_signed): Rename from field_int.
2236         Change type of "value".
2237         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2238         type of "value".
2239         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2240         do_field_int.  Change type of "value".
2241         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2242         do_field_int.  Change type of "value".
2243         * tracepoint.c (trace_status_mi, tfind_1)
2244         (print_one_static_tracepoint_marker): Update.
2245         * thread.c (print_thread_info_1, print_selected_thread_frame):
2246         Update.
2247         * stack.c (print_frame, print_frame_info): Update.
2248         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2249         Update.
2250         * source.c (print_source_lines_base): Update.
2251         * skip.c (info_skip_command): Update.
2252         * record-btrace.c (btrace_ui_out_decode_error)
2253         (btrace_call_history_src_line): Update.
2254         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2255         Update.
2256         * progspace.c (print_program_space): Update.
2257         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2258         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2259         do_field_int.  Change type of "value".
2260         * mi/mi-out.c (mi_ui_out::do_table_begin)
2261         (mi_ui_out::do_table_header): Update.
2262         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2263         type of "value".
2264         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2265         (mi_cmd_data_list_changed_registers, output_register)
2266         (mi_cmd_data_read_memory, mi_load_progress)
2267         (mi_cmd_trace_frame_collected): Update.
2268         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2269         Update.
2270         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2271         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2272         (mi_cmd_var_list_children, varobj_update_one): Update.
2273         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2274         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2275         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2276         * inferior.c (print_inferior): Update.
2277         * gdb_bfd.c (print_one_bfd): Update.
2278         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2279         Update.
2280         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2281         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2282         do_field_int.  Change type of "value".
2283         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2284         do_field_int.  Change type of "value".
2285         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2286         (print_one_breakpoint_location, print_it_catch_fork)
2287         (print_one_catch_fork, print_it_catch_vfork)
2288         (print_one_catch_vfork, print_it_catch_solib)
2289         (print_it_catch_exec, print_it_ranged_breakpoint)
2290         (print_mention_watchpoint, print_mention_masked_watchpoint)
2291         (bkpt_print_it, update_static_tracepoint): Update.
2292         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2293         * break-catch-syscall.c (print_it_catch_syscall): Update.
2294         * ada-tasks.c (print_ada_task_info): Update.
2295         * ada-lang.c (print_it_exception, print_mention_exception):
2296         Update.
2297
2298 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2299
2300         PR breakpoints/24541
2301         * gdbarch.c: Regenerate.
2302         * gdbarch.h: Regenerate.
2303         * gdbarch.sh: Adjust return type and parameter types for
2304         'stap_adjust_register'.
2305         (i386_stap_adjust_register): Adjust signature and return new
2306         register name.
2307         * stap-probe.c (stap_parse_register_operand): Adjust use of
2308         'gdbarch_stap_adjust_register'.
2309
2310 2019-07-17  Tom Tromey  <tromey@adacore.com>
2311
2312         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2313         declare VEC.
2314         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2315         std::vector.
2316         (struct s390_process_info): Add initializers.
2317         (s390_add_process): Use new.
2318         (s390_linux_nat_target::low_forget_process): Use delete.
2319         (s390_linux_nat_target::low_new_fork)
2320         (s390_linux_nat_target::stopped_by_watchpoint)
2321         (s390_linux_nat_target::low_prepare_to_resume)
2322         (s390_linux_nat_target::insert_watchpoint)
2323         (s390_linux_nat_target::insert_hw_breakpoint)
2324         (s390_linux_nat_target::remove_watchpoint)
2325         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2326
2327 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2328
2329         * aarch64-fbsd-nat.c: Include regcache.h.
2330         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2331         argument.
2332         (aarch64_fbsd_nat_target::fetch_registers)
2333         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2334         variable.
2335         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2336
2337 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2338
2339         * fbsd-nat.c: Include gdbarch.h.
2340
2341 2019-07-15  Tom Tromey  <tromey@adacore.com>
2342
2343         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2344
2345 2019-07-15  Tom Tromey  <tromey@adacore.com>
2346
2347         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2348         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2349         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2350         * cli-out.c (cli_ui_out::do_field_int): New method.
2351         * ui-out.c (ui_out::field_unsigned): New method.
2352         * symfile.c (generic_load): Use field_unsigned.
2353         (print_transfer_performance): Likewise.
2354         * record-btrace.c (ui_out_field_uint): Remove.
2355         (btrace_call_history_insn_range, btrace_call_history): Use
2356         field_unsigned.
2357         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2358         field_unsigned.
2359         * ui-out.h (class ui_out) <field_unsigned>: New method.
2360         <do_field_unsigned>: Likewise.
2361
2362 2019-07-15  Tom Tromey  <tromey@adacore.com>
2363
2364         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2365         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2366         * target.c (flash_erase_command): Use field_string.
2367         * infrun.c (print_signal_received_reason): Use field_string.
2368         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2369         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2370         field_string.
2371         * ada-tasks.c (print_ada_task_info): Use field_string.
2372
2373 2019-07-15  Tom Tromey  <tromey@adacore.com>
2374
2375         * target.c (flash_erase_command): Use field_core_addr.
2376         * symfile.c (generic_load): Use field_core_addr.
2377         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2378         Use field_core_addr.
2379         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2380         field_core_addr.
2381
2382 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2383
2384         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2385         value if its desired type is smaller than a CORE_ADDR and signed.
2386
2387 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2388
2389         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2390         of changes to field names, and use new is_reference field to
2391         decide if a property is a reference or not.
2392         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2393         field.
2394         (struct dwarf2_property_baton): Update header comment, rename
2395         'referenced_type' to 'property_type' and update comments.
2396         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2397         default property type, store in property baton, update to take
2398         accound of renamed field.
2399         (read_func_scope): Update call to attr_to_dynamic_prop.
2400         (read_array_type): Likewise.
2401         (dwarf2_per_cu_addr_sized_int_type): New function.
2402         (read_subrange_index_type): Move type finding code to
2403         dwarf2_per_cu_addr_sized_int_type.
2404         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2405         (dwarf2_per_cu_addr_type): New function.
2406         (set_die_type): Update calls to attr_to_dynamic_prop.
2407
2408 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2409
2410         * dwarf2read.c (read_subrange_index_type): New function.
2411         (read_subrange_type): Move code into new function and call it.
2412         * gdbtypes.c (create_range_type): Add some asserts.
2413
2414 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2415
2416         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2417         update return statements.
2418         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2419         declaration, and update comment to match.
2420         * gdbtypes.c (resolve_dynamic_array): Update call to
2421         dwarf2_evaluate_property to match new return type.
2422
2423 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * valarith.c (value_subscripted_rvalue): Change lowerbound
2426         parameter type from int to LONGEST.
2427         * value.h (value_subscripted_rvalue): Likewise in declaration.
2428
2429 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2430
2431         * cli/cli-utils.c (info_print_command_completer): New function.
2432         * cli/cli-utils.h: Add 'completer.h' include, and forward
2433         declaration for 'struct cmd_list_element'.
2434         (info_print_command_completer): Declare.
2435         * stack.c (_initialize_stack): Add completer for 'info locals' and
2436         'info args'.
2437         * symtab.c (_initialize_symtab): Add completer for 'info
2438         variables' and 'info functions'.
2439         * NEWS: Mention completion for additional info commands.
2440
2441 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2442
2443         * cli/cli-utils.c (extract_info_print_args): Delete.
2444         (extract_arg_maybe_quoted): Delete.
2445         (info_print_options_defs): New variable.
2446         (make_info_print_options_def_group): New function.
2447         (extract_info_print_options): Define new function.
2448         * cli/cli-utils.h (extract_info_print_args): Delete.
2449         (struct info_print_options): New structure.
2450         (extract_info_print_options): Declare new function.
2451         * stack.c (info_locals_command): Update to use new
2452         extract_info_print_options, also add a header comment.
2453         (info_args_command): Likewise.
2454         * symtab.c (info_variables_command): Likewise.
2455         (info_functions_command): Likewise.
2456
2457 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2458
2459         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2460         to extract string arguments.
2461         * common/common-utils.c (extract_string_maybe_quoted): New function.
2462         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2463
2464 2019-07-11  Tom Tromey  <tromey@adacore.com>
2465
2466         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2467         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2468         * top.h (gdbinit): Don't declare.
2469         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2470         into...
2471         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2472         * top.c (gdb_init): Don't call init_cli_cmds.
2473         (gdbinit): Remove.
2474         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2475
2476 2019-07-11  Tom Tromey  <tromey@adacore.com>
2477
2478         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2479         after it has been moved.
2480
2481 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2482
2483         * valops.c (value_must_coerce_to_target): Change return type to
2484         bool.
2485         * value.h (value_must_coerce_to_target): Likewise.
2486
2487 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2488
2489         * breakpoint.c (is_hardware_watchpoint): Remove
2490         forward-declaration.
2491         (is_masked_watchpoint): Change return type to bool.
2492         (is_tracepoint): Likewise.
2493         (is_breakpoint): Likewise.
2494         (is_hardware_watchpoint): Likewise.
2495         (is_watchpoint): Likewise.
2496         (is_no_memory_software_watchpoint): Likewise.
2497         (is_catchpoint): Likewise.
2498         (breakpoint_1): Make FILTER parameter's return type bool.
2499         is_masked_watchpoint): Change return type to bool.
2500         (save_breakpoints): Make FILTER parameter's return type bool.
2501         * breakpoint.h (is_breakpoint): Change return type to bool.
2502         (is_watchpoint): Likewise.
2503         (is_catchpoint): Likewise.
2504         (is_tracepoint): Likewise.
2505
2506 2019-07-10  Tom Tromey  <tom@tromey.com>
2507
2508         * defs.h: Don't include gdbarch.h.
2509         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2510         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2511         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2512         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2513         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2514         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2515         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2516         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2517         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2518         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2519         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2520         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2521         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2522         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2523         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2524         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2525         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2526         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2527         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2528         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2529         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2530         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2531         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2532         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2533         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2534         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2535         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2536
2537 2019-07-10  Tom Tromey  <tromey@adacore.com>
2538
2539         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2540         * breakpoint.c (init_ada_exception_breakpoint): Register as
2541         bp_catchpoint.
2542         (print_one_breakpoint_location, print_one_breakpoint): Use
2543         is_ada_exception_catchpoint.
2544         * ada-lang.c (class ada_catchpoint_location): Pass
2545         bp_loc_software_breakpoint to bp_location constructor.
2546         (is_ada_exception_catchpoint): New function.
2547
2548 2019-07-10  Tom Tromey  <tromey@adacore.com>
2549
2550         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2551         VEC.
2552         (struct arm_exidx_entry): New method operator<.
2553         (struct arm_exidx_data) <section_maps>: Change type.
2554         (arm_exidx_data_free): Remove.
2555         (arm_exidx_data_key): Change type.  Move lower.
2556         (arm_exidx_new_objfile): Update.
2557         (arm_compare_exidx_entries): Remove.
2558         (arm_find_exidx_entry, _initialize_arm_tdep)
2559
2560 2019-07-10  Tom Tromey  <tromey@adacore.com>
2561
2562         * solib-spu.c (ocl_program_data_key): Change type.
2563         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2564         Update.
2565
2566 2019-07-10  Tom Tromey  <tromey@adacore.com>
2567
2568         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2569         (struct solib_aix_inferior_data) <library_list>: Change type.
2570         (solib_aix_inferior_data_handle): Change type.
2571         (get_solib_aix_inferior_data): Update.
2572         (solib_aix_free_library_list): Remove.
2573         (library_list_start_library): Update.
2574         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2575         return type.
2576         (solib_aix_get_library_list)
2577         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2578         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2579
2580 2019-07-10  Tom Tromey  <tromey@adacore.com>
2581
2582         * solib-dsbt.c (struct dsbt_info): Add initializers.
2583         (solib_dsbt_pspace_data): Change type.
2584         (dsbt_pspace_data_cleanup): Remove.
2585         (get_dsbt_info, _initialize_dsbt_solib): Update.
2586
2587 2019-07-10  Tom Tromey  <tromey@adacore.com>
2588
2589         * spu-tdep.c (spu_overlay_data): Change type.
2590         (spu_get_overlay_table, spu_overlay_new_objfile)
2591         (_initialize_spu_tdep): Update.
2592
2593 2019-07-10  Tom Tromey  <tromey@adacore.com>
2594
2595         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2596         destructor.
2597         (dbx_objfile_data_key): Change type and declare later.
2598         (DBX_SYMFILE_INFO): Rewrite.
2599         * dbxread.c (dbx_objfile_data_key): Change type.
2600         (dbx_symfile_init): Update.
2601         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2602         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2603         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2604
2605 2019-07-10  Tom Tromey  <tromey@adacore.com>
2606
2607         * jit.c (jit_program_space_key): Change type.  Move lower.
2608         (get_jit_program_space_data): Update.
2609         (jit_program_space_data_cleanup): Remove.
2610         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2611         Update.
2612         (struct jit_program_space_data): Add initializers.
2613
2614 2019-07-10  Tom Tromey  <tromey@adacore.com>
2615
2616         * solib-darwin.c (struct darwin_info): Add initializers.
2617         (solib_darwin_pspace_data): Change type.
2618         (darwin_pspace_data_cleanup): Remove.
2619         (get_darwin_info, _initialize_darwin_solib): Update.
2620
2621 2019-07-10  Tom Tromey  <tromey@adacore.com>
2622
2623         * remote-sim.c (struct sim_inferior_data): Add initializers,
2624         constructor, and destructor.
2625         (sim_inferior_data_key): Change type.  Move lower.
2626         (check_for_duplicate_sim_descriptor): Update.
2627         (get_sim_inferior_data): Use new.  Update.
2628         (~sim_inferior_data_cleanup): Rename from
2629         sim_inferior_data_cleanup.  Simplify.
2630         (gdbsim_close_inferior, simulator_command)
2631         (sim_command_completer, _initialize_remote_sim): Update.
2632         (next_pid, INITIAL_PID): Move earlier.
2633
2634 2019-07-10  Tom Tromey  <tromey@adacore.com>
2635
2636         * python/python-internal.h (create_thread_object): Return
2637         gdbpy_ref.
2638         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2639         * python/py-inferior.c (struct threadlist_entry): Add
2640         constructor.
2641         <thread_obj>: Now a gdbpy_ref.
2642         (thread_to_thread_object): Update.
2643         (add_thread_object): Use new.
2644         (delete_thread_object): Use delete.
2645         (infpy_threads): Update.
2646         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2647         GIL.
2648
2649 2019-07-10  Tom Tromey  <tromey@adacore.com>
2650
2651         * valops.c (value_cast): Specialize error message for Ada.
2652
2653 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2654
2655         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2656
2657 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2658
2659         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2660         bpstat_should_step): Return bool, adjust comments.
2661         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2662         bpstat_should_step): Likewise.
2663
2664 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2665
2666         * features/Makefile: Use feature target descriptions for Arm.
2667         * features/arm/arm-core.c: Generate new file.
2668         * features/arm/arm-fpa.c: Likewise.
2669         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2670         * features/arm/arm-m-profile.c: Likewise.
2671         * features/arm/arm-vfpv2.c: Likewise.
2672         * features/arm/arm-vfpv3.c: Likewise.
2673         * features/arm/xscale-iwmmxt.c: Likewise.
2674         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2675
2676 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2677
2678         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2679         ptrace earlier.
2680
2681 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2682
2683         * features/aarch64-pauth.c: Regenerate.
2684
2685 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2686
2687         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2688         bool.
2689         (bpstat_what): Use false instead of 0.
2690
2691 2019-07-09  Pedro Alves  <palves@redhat.com>
2692
2693         * break-catch-throw.c (is_exception_catchpoint): New.
2694         * breakpoint.c (print_one_breakpoint_location): New parameter
2695         'raw_loc'.  Handle it.  Use
2696         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2697         looking at the breakpoint's type.
2698         (print_one_breakpoint): If handling "maint info breakpoints", also
2699         print locations of exception catchpoints.
2700         * breakpoint.h (is_exception_catchpoint): Declare.
2701
2702 2019-07-09  Pedro Alves  <palves@redhat.com>
2703
2704         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2705         "addr" field.
2706         (allocate_location_exception_catchpoint): New.
2707         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2708         (initialize_throw_catchpoint_ops): Install
2709         allocate_location_exception_catchpoint as allocate_location
2710         method.
2711         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2712         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2713         bp_loc_other.
2714         (breakpoint_address_is_meaningful): Delete.
2715         (bl_address_is_meaningful): New.
2716         (breakpoint_locations_match): Adjust comment.
2717         (bp_location_from_bp_type): New, factored out of...
2718         (bp_location::bp_location(breakpoint *)): ... this.
2719         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2720         factored out of...
2721         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2722         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2723         breakpoint_address_is_meaningful.
2724         (bp_locations_compare): Adjust comment.
2725         (update_global_location_list): Use bl_address_is_meaningful
2726         instead of breakpoint_address_is_meaningful.
2727         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2728         explicit.
2729         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2730         * python/py-breakpoint.c (bppy_get_location): No longer check
2731         whether location is null.
2732
2733 2019-07-09  Pedro Alves  <palves@redhat.com>
2734
2735         PR c++/15468
2736         * breakpoint.c (print_one_breakpoint_location): Remove
2737         single-location assert.
2738
2739 2019-07-09  Tom Tromey  <tom@tromey.com>
2740
2741         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2742         * configure: Rebuild.
2743         * configure.ac: Change common to gdbsupport.
2744         * gdbsupport: Rename from common.
2745         * acinclude.m4: Change common to gdbsupport.
2746         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2747         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2748         gdbsupport.
2749         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2750         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2751         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2752         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2753         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2754         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2755         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2756         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2757         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2758         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2759         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2760         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2761         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2762         coff-pe-read.c, command.h, compile/compile-c-support.c,
2763         compile/compile-c.h, compile/compile-cplus-symbols.c,
2764         compile/compile-cplus-types.c, compile/compile-cplus.h,
2765         compile/compile-loc2c.c, compile/compile.c, completer.c,
2766         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2767         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2768         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2769         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2770         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2771         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2772         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2773         features/aarch64-core.c, features/aarch64-fpu.c,
2774         features/aarch64-pauth.c, features/aarch64-sve.c,
2775         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2776         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2777         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2778         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2779         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2780         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2781         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2782         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2783         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2784         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2785         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2786         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2787         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2788         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2789         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2790         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2791         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2792         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2793         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2794         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2795         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2796         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2797         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2798         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2799         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2800         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2801         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2802         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2803         minsyms.c, mips-linux-tdep.c, namespace.h,
2804         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2805         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2806         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2807         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2808         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2809         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2810         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2811         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2812         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2813         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2814         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2815         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2816         procfs.c, producer.c, progspace.h, psymtab.h,
2817         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2818         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2819         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2820         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2821         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2822         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2823         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2824         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2825         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2826         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2827         target-memory.c, target.c, target.h, target/waitstatus.c,
2828         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2829         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2830         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2831         unittests/array-view-selftests.c,
2832         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2833         unittests/common-utils-selftests.c,
2834         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2835         unittests/format_pieces-selftests.c,
2836         unittests/function-view-selftests.c,
2837         unittests/lookup_name_info-selftests.c,
2838         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2839         unittests/mkdir-recursive-selftests.c,
2840         unittests/observable-selftests.c,
2841         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2842         unittests/parse-connection-spec-selftests.c,
2843         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2844         unittests/scoped_fd-selftests.c,
2845         unittests/scoped_mmap-selftests.c,
2846         unittests/scoped_restore-selftests.c,
2847         unittests/string_view-selftests.c, unittests/style-selftests.c,
2848         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2849         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2850         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2851         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2852         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2853         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2854
2855 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2856
2857         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2858         bool value.
2859         (decode_digits_ordinary): Set explicit_line field in sal.
2860         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2861         symtab_and_line that was set on an explicit line number in
2862         assembler code.  Do always update the recorded symtab and line if
2863         we do skip the prologue.
2864
2865 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2866
2867         * breakpoint.c (set_breakpoint_location_function): Remove
2868         explicit_loc parameter.
2869         (momentary_breakpoint_from_master): Update call to
2870         set_breakpoint_location_function.
2871         (add_location_to_breakpoint): Likewise.
2872
2873 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2874
2875         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2876         required features based on default bfd type when no specific bfd
2877         is present.
2878
2879 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2880
2881         * NEWS: Mention that GDB printf and eval commands can now print
2882         C-style and Ada-style convenience var strings without
2883         calling the inferior.
2884         * printcmd.c (printf_c_string): Locally print GDB internal var
2885         instead of transiting via the inferior.
2886         (printf_wide_c_string): Likewise.
2887
2888 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2889
2890         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2891
2892 2019-07-04  Tom Tromey  <tom@tromey.com>
2893
2894         PR tui/24724:
2895         * tui/tui-winsource.c (tui_clear_source_content): Update.
2896         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2897         (tui_update_breakpoint_info): Update.
2898         (tui_set_exec_info_content): Update.
2899         * tui/tui-source.c (tui_set_source_content_nil): Update.
2900         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2901         has_break.
2902         * tui/tui-data.h (enum tui_bp_flag): New.
2903         (tui_bp_flags): New enum flags type.
2904         (struct tui_source_element) <break_mode>: Change type.  Rename
2905         from has_break.
2906         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2907         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2908         constants.
2909         * tui/tui-winsource.h: Fix comment.
2910
2911 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2912
2913         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2914         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2915         (store_fpregs_to_thread)
2916         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2917         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2918         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2919         (IWMMXT_REGS_SIZE): Add define.
2920         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2921         (fetch_vfp_regs, store_vfp_regs)
2922         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2923         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2924
2925 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2926
2927         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2928         defines.
2929         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2930         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2931         (ARM_INT_REGISTER_SIZE): ...to this.
2932         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2933         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2934         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2935         (arm_linux_collect_gregset, supply_nwfpe_register)
2936         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2937         defines.
2938         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2939         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2940         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2941         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2942         (arm_return_in_memory, arm_store_return_value)
2943         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2944         (arm_record_ld_st_multiple): Likewise.
2945         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2946         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2947
2948 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2949
2950         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2951         AARCH64_DISPLACED_MODIFIED_INSNS.
2952         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2953         (aarch64_displaced_step_copy_insn): Likewise.
2954         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2955         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2956         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2957         ARM_DISPLACED_MODIFIED_INSNS.
2958         * arm-tdep.c (arm_gdbarch_init): Likewise.
2959         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2960         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2961         (struct arm_displaced_step_closure): Use
2962         ARM_DISPLACED_MODIFIED_INSNS.
2963
2964 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2965
2966         * features/Makefile: Remove unused xml files.
2967         * features/aarch64.xml: Remove.
2968         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2969         * features/i386/amd64-avx-avx512.xml: Remove.
2970         * features/i386/amd64-avx-linux.xml: Remove.
2971         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2972         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2973         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2974         * features/i386/amd64-avx-mpx.xml: Remove.
2975         * features/i386/amd64-avx.xml: Remove.
2976         * features/i386/amd64-linux.xml: Remove.
2977         * features/i386/amd64-mpx-linux.xml: Remove.
2978         * features/i386/amd64-mpx.xml: Remove.
2979         * features/i386/amd64.xml: Remove.
2980         * features/i386/i386-avx-avx512-linux.xml: Remove.
2981         * features/i386/i386-avx-avx512.xml: Remove.
2982         * features/i386/i386-avx-linux.xml: Remove.
2983         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2984         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2985         * features/i386/i386-avx-mpx-linux.xml: Remove.
2986         * features/i386/i386-avx-mpx.xml: Remove.
2987         * features/i386/i386-avx.xml: Remove.
2988         * features/i386/i386-linux.xml: Remove.
2989         * features/i386/i386-mmx-linux.xml: Remove.
2990         * features/i386/i386-mmx.xml: Remove.
2991         * features/i386/i386-mpx-linux.xml: Remove.
2992         * features/i386/i386-mpx.xml: Remove.
2993         * features/i386/i386.xml: Remove.
2994         * features/i386/x32-avx-avx512-linux.xml: Remove.
2995         * features/i386/x32-avx-linux.xml: Remove.
2996         * features/i386/x32-linux.xml: Remove.
2997
2998 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2999
3000         * regformats/aarch64.dat: Remove.
3001         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3002         * regformats/i386/amd64-avx-linux.dat: Remove.
3003         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3004         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3005         * regformats/i386/amd64-linux.dat: Remove.
3006         * regformats/i386/amd64-mpx-linux.dat: Remove.
3007         * regformats/i386/amd64.dat: Remove.
3008         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3009         * regformats/i386/i386-avx-linux.dat: Remove.
3010         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3011         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3012         * regformats/i386/i386-linux.dat: Remove.
3013         * regformats/i386/i386-mmx-linux.dat: Remove.
3014         * regformats/i386/i386-mpx-linux.dat: Remove.
3015         * regformats/i386/i386.dat: Remove.
3016         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3017         * regformats/i386/x32-avx-linux.dat: Remove.
3018         * regformats/i386/x32-linux.dat: Remove.
3019
3020 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3021
3022         * aarch64-tdep.c: Remove xml self tests.
3023         * amd64-linux-tdep.c: Likewise.
3024         * amd64-tdep.c: Likewise.
3025         * i386-linux-tdep.c: Likewise.
3026         * i386-tdep.c: Likewise.
3027
3028 2019-07-03  Pedro Alves  <palves@redhat.com>
3029
3030         PR cli/24732
3031         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3032         (pipe_cmd_option_defs): New.
3033         (make_pipe_cmd_options_def_group): New.
3034         (pipe_command): Use gdb::option::process_options.
3035         (pipe_command_completer): New function.
3036         (_initialize_cli_cmds): Install completer for "pipe" command.
3037
3038 2019-07-03  Pedro Alves  <palves@redhat.com>
3039
3040         * cli/cli-option.c (union option_value) <string>: New field.
3041         (struct option_def_and_value): Add ctor, move ctor, dtor and
3042         use DISABLE_COPY_AND_ASSIGN.
3043         (option_def_and_value::clear_value): New.
3044         (parse_option, save_option_value_in_ctx, get_val_type_str)
3045         (add_setshow_cmds_for_options): Handle var_string.
3046         * cli-option.h (union option_def::var_address) <string>: New
3047         field.
3048         (struct string_option_def): New.
3049         * maint-test-options.c (struct test_options_opts): Add default
3050         ctor and use DISABLE_COPY_AND_ASSIGN.
3051         <string_opt>: New field.
3052         (test_options_opts::~test_options_opts): New.
3053         (test_options_opts::dump): Also dump "-string".
3054         (test_options_option_defs): Install "string.
3055
3056 2019-07-03  Pedro Alves  <palves@redhat.com>
3057
3058         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3059         option_value with a null enumeration.
3060         (complete_options): Save the option values in the context.
3061         (save_option_value_in_ctx): New, factored out from ...
3062         (process_options): ... here.
3063         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3064         of the function.
3065         * maint-test-options.c (test_options_opts::dump): New, factored
3066         out from ...
3067         (maintenance_test_options_command_mode): ... here.
3068         (maintenance_test_options_command_completion_result): Delete.
3069         (maintenance_test_options_command_completion_text): Update
3070         comment.
3071         (maintenance_show_test_options_completion_result): Change
3072         prototype.  Just print
3073         maintenance_test_options_command_completion_text.
3074         (save_completion_result): New.
3075         (maintenance_test_options_completer_mode): Pass options context to
3076         complete_options, and then save a dump.
3077         (_initialize_maint_test_options): Use add_cmd to install "maint
3078         show test-options-completion-result".
3079
3080 2019-07-03  Pedro Alves  <palves@redhat.com>
3081
3082         * NEWS (New commands): Mention "with" and "maint with".
3083         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3084         (with_command, with_command_completer): New.
3085         (pipe_command): Adjust to new repeat_previous
3086         interface.
3087         (_initialize_cli_cmds): Install the "with" command and its "w"
3088         alias.
3089         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3090         declarations.
3091         * cli/cli-setshow.c (parse_cli_var_uinteger)
3092         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3093         argument strings for all var_types.
3094         (get_setshow_command_value_string): New, factored out from ...
3095         (do_show_command): ... this.
3096         * cli/cli-setshow.h: Include <string>.
3097         (get_setshow_command_value_string): Declare.
3098         * command.h (repeat_previous): Now returns const char *.  Adjust
3099         comment.
3100         * maint.c: Include "cli/cli-cmds.h".
3101         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3102         (_initialize_maint_cmds): Register the "maintenance with" command.
3103         * top.c (repeat_previous): Move bits from pipe_command here:
3104         Return the saved command line, if any; error out if there's no
3105         command to relaunch.
3106
3107 2019-07-03  Pedro Alves  <palves@redhat.com>
3108
3109         * NEWS (New commands): Mention "maint set/show test-settings"
3110         instead of "maint test-settings".
3111         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3112         (maintenance_test_settings_set_list): Rename to ...
3113         (maintenance_set_test_settings_list): ... this.
3114         (maintenance_test_settings_show_list): Rename to  ...
3115         (maintenance_show_test_settings_list): ... this.
3116         (maintenance_test_settings_cmd): Delete.
3117         (maintenance_test_settings_set_cmd): ...
3118         (maintenance_set_test_settings_cmd): ... this.
3119         (maintenance_test_settings_show_cmd): ...
3120         (maintenance_show_test_settings_cmd): ... this.
3121         (maintenance_test_settings_show_value_cmd):
3122         (maintenance_show_test_settings_value_cmd): ... this.
3123         (_initialize_maint_test_settings): No longer install the "maint
3124         test-settings" prefix command.  Rename "maint test-settings set"
3125         to "maint set test-settings", and "maint test-settings show" to
3126         "maint show test-settings".  Adjust all subcommands.
3127
3128 2019-07-03  Pedro Alves  <palves@redhat.com>
3129
3130         * maint-test-settings.c: Fix file's intro comment.  Replace all
3131         references to "test-options" with references to "test-settings",
3132         in comments.
3133
3134 2019-07-03  Pedro Alves  <palves@redhat.com>
3135
3136         * maint-test-settings.c (maintenance_test_settings_xxx)
3137         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3138         New.
3139         (maintenance_test_settings_enums): Use them.
3140         (maintenance_test_settings_enum): Default to
3141         maintenance_test_settings_xxx.
3142         (_initialize_maint_test_settings): Initialize
3143         MAINTENANCE_TEST_SETTINGS_FILENAME.
3144
3145 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3146
3147         * breakpoint.h (remove_breakpoints_inf): Change return type to
3148         void, move function documentation here.
3149         * breakpoint.c (remove_breakpoints_inf): Change return type to
3150         void, move function documentation to header.
3151
3152 2019-07-02  Pedro Alves  <palves@redhat.com>
3153
3154         * NEWS (Completion improvements): Mention "info threads".
3155         * thread.c (struct info_threads_opts, info_threads_option_defs)
3156         (make_info_threads_options_def_group): New.
3157         (info_threads_command): Use gdb::option::process_options.
3158         (info_threads_command_completer): New.
3159         (_initialize_thread): Use gdb::option::build_help to build the
3160         help text for "info threads".
3161
3162 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3163
3164         * defs.h (generic_load): Move from here...
3165         * symfile.h (generic_load): ... to here.  Rename name parameter
3166         to args.
3167         * symfile.c (generic_load): Add comment.
3168
3169 2019-07-01  Tom Tromey  <tromey@adacore.com>
3170
3171         * dwarf2read.c
3172         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3173         declaration of without_params.  Fix formatting.
3174
3175 2019-07-01  Tom Tromey  <tromey@adacore.com>
3176
3177         * ada-exp.y (find_primitive_type): Update.
3178         * ada-lang.h (ada_lookup_symbol): Update.
3179         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3180         parameter.
3181         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3182
3183 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3184
3185         PR breakpoints/24541
3186         * gdbarch.c: Regenerate.
3187         * gdbarch.h: Regenerate.
3188         * gdbarch.sh: Add 'stap_adjust_register'.
3189         * i386-tdep.c: Include '<unordered_set>'.
3190         (i386_stap_adjust_register): New function.
3191         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3192         * stap-probe.c (stap_parse_register_operand): Call
3193         'gdbarch_stap_adjust_register'.
3194
3195 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3196
3197         PR python/24742
3198         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3199         * python/python.c (do_start_initialization): Use 'xmalloc'
3200         instead of 'PyMem_Malloc'.
3201
3202 2019-06-28  Tom Tromey  <tromey@adacore.com>
3203
3204         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3205         for Ada.
3206
3207 2019-06-27  Tom Tromey  <tromey@adacore.com>
3208
3209         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3210         objfile_key.
3211         (arm_find_mapping_symbol, arm_record_special_symbol)
3212         (_initialize_arm_tdep): Update.
3213         (arm_objfile_data_free): Remove.
3214
3215 2019-06-27  Tom Tromey  <tromey@adacore.com>
3216
3217         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3218         to cp_print_static_field.
3219
3220 2019-06-26  Tom Tromey  <tromey@adacore.com>
3221
3222         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3223         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3224         declare.
3225
3226 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3227
3228         * features/aarch64-core.c (create_feature_aarch64_core):
3229         Regenerate.
3230         * features/aarch64-core.xml: Add cpsr flags.
3231
3232 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3233
3234         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3235         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3236
3237 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3238
3239         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3240         field.
3241         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3242         use.
3243         (arm_record_special_symbol): Don't insert new symbol in sorted
3244         position, push it at the end.
3245
3246 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3247
3248         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3249         (arm_mapping_symbol_s): Remove.
3250         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3251         (arm_mapping_symbol_vec): New typedef.
3252         (struct arm_per_objfile): Add constructor.
3253         <section_maps>: Change type to
3254         std::unique_ptr<arm_mapping_symbol_vec[]>.
3255         (arm_compare_mapping_symbols): Remove.
3256         (arm_find_mapping_symbol): Adjust to section_maps type change.
3257         (arm_objfile_data_free): Call delete on arm_per_objfile.
3258         (arm_record_special_symbol): Adjust to section_maps type change.
3259         Allocate arm_per_objfile with new.
3260
3261 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3262
3263         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3264         with the command prefix.
3265
3266 2019-06-25  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3269         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3270
3271 2019-06-25  Tom Tromey  <tom@tromey.com>
3272
3273         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3274         type.
3275         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3276         protected.
3277
3278 2019-06-25  Tom Tromey  <tom@tromey.com>
3279
3280         * tui/tui-winsource.c
3281         (tui_source_window_base::set_is_exec_point_at): Add check against
3282         LOA_ADDRESS.
3283
3284 2019-06-25  Tom Tromey  <tom@tromey.com>
3285
3286         * tui/tui-source.c (tui_set_source_content): Don't check before
3287         xfree.
3288         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3289
3290 2019-06-25  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-winsource.h (tui_update_source_window_as_is)
3293         (tui_alloc_source_buffer, tui_line_is_displayed)
3294         (tui_addr_is_displayed): Change type of win_info.
3295         * tui/tui-winsource.c (tui_update_source_window_as_is)
3296         (tui_clear_source_content, tui_show_source_line)
3297         (tui_show_source_content, tui_source_window_base::refill)
3298         (tui_source_window_base::set_is_exec_point_at)
3299         (tui_source_window_base::set_is_exec_point_at)
3300         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3301         (tui_alloc_source_buffer, tui_line_is_displayed)
3302         (tui_addr_is_displayed): Change type of win_info.  Update.
3303         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3304         (tui_source_window_base::do_make_visible_with_new_height):
3305         Update.
3306         * tui/tui-source.c (tui_set_source_content)
3307         (tui_set_source_content_nil)
3308         (tui_source_window::do_scroll_vertical): Update.
3309         * tui/tui-layout.c (show_layout): Update.
3310         * tui/tui-disasm.c (tui_set_disassem_content)
3311         (tui_disasm_window::do_scroll_vertical): Update.
3312         * tui/tui-data.h (tui_win_content): Remove.
3313         (struct tui_gen_win_info) <content, content_size>: Remove.
3314         (struct tui_source_element): Add initializers and destructor.
3315         (union tui_which_element, struct tui_win_element): Remove.
3316         (struct tui_source_window_base) <content>: New field.
3317         (struct tui_data_window): Remove destructor.
3318         (tui_alloc_content, tui_free_win_content)
3319         (tui_free_all_source_wins_content): Don't declare.
3320         * tui/tui-data.c (tui_initialize_static_data): Update.
3321         (init_content_element, tui_alloc_content): Remove.
3322         (~tui_gen_win_info): Update.
3323         (~tui_data_window, tui_free_all_source_wins_content)
3324         (tui_free_win_content, free_content, free_content_elements):
3325         Remove.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-winsource.h (tui_clear_source_content)
3330         (tui_erase_source_content, tui_show_source_content): Change type
3331         of win_info.
3332         * tui/tui-winsource.c (tui_clear_source_content)
3333         (tui_erase_source_content, tui_show_source_content): Change type
3334         of win_info.
3335         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3336         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3337         win_info.
3338         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3339         win_info.
3340         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3341
3342 2019-06-25  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-winsource.c (tui_clear_source_content)
3345         (tui_source_window_base::set_is_exec_point_at): Update.
3346         * tui/tui-source.c (tui_set_source_content_nil): Update.
3347         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3348         a bool.
3349         * tui/tui-data.c (init_content_element): Update.
3350
3351 2019-06-25  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3354         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3355         * tui/tui-layout.c (init_and_make_win): Update.
3356         * tui/tui.h (enum tui_win_type): Update.
3357         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3358         tui_win_is_auxillary.
3359         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3360         tui_win_is_auxillary.
3361
3362 2019-06-25  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3365         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3366         (tui_delete_data_content_windows, tui_display_all_data)
3367         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3368         Update.
3369         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3370         * tui/tui-regs.c (tui_last_regs_line_no)
3371         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3372         (tui_show_registers): Update.
3373         (tui_show_register_group): Return void.  Update.
3374         (tui_display_registers_from, tui_display_reg_element_at_line)
3375         (tui_display_registers_from_line, tui_check_register_values):
3376         Update.
3377         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3378         member.
3379         (struct tui_data_window) <regs_content>: Now a std::vector.
3380         <regs_content_count>: Remove.
3381         (tui_add_content_elements, tui_free_data_content): Don't declare.
3382         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3383         (init_content_element): Remove DATA_WIN case.  Add assert.
3384         (tui_add_content_elements): Remove.
3385         (tui_data_window): Update.
3386         (tui_free_data_content): Remove.
3387         (free_content_elements): Remove DATA_WIN case.
3388
3389 2019-06-25  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-data.c (tui_data_item_window): Update.
3392         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3393         * tui/tui-windata.c (tui_display_all_data)
3394         (tui_display_data_from_line): Update.
3395         (tui_check_data_values): Remove.
3396         * tui/tui-regs.c (tui_show_register_group)
3397         (tui_display_reg_element_at_line): Update.
3398         * tui/tui-hooks.c (tui_register_changed)
3399         (tui_refresh_frame_and_register_information): Call
3400         tui_check_register_values.
3401         * tui/tui-data.h (struct tui_data_window) <data_content,
3402         data_content_count, data_type>: Remove.
3403         (enum tui_data_type): Remove.
3404
3405         * tui/tui-data.c (tui_data_window::clear_detail)
3406         (~tui_data_window): Update.
3407
3408 2019-06-25  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3411         declare.
3412         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3413         Rename from tui_first_data_item_displayed.  Update.
3414         (tui_data_window::refresh_all)
3415         (tui_data_window::do_scroll_vertical): Update.
3416         * tui/tui-data.h (struct tui_data_window)
3417         <first_data_item_displayed>: Declare new method.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3422         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3423         contents...
3424         (tui_initialize_static_data): ...here.
3425
3426 2019-06-25  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3429         (tui_display_registers_from, tui_check_register_values): Update.
3430         (tui_display_register): Remove win_info parameter; update.
3431         (tui_get_register): Change type of parameters.
3432         * tui/tui-data.h (struct tui_data_element): Remove.
3433         (union tui_which_element) <data>: Remove.
3434         <data_window>: Change type.
3435         (struct tui_data_item_window): New.
3436         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3437         case.  Add assert.
3438         (~tui_data_item_window): New destructor.
3439         (free_content_elements): Remove DATA_ITEM_WIN case.
3440
3441 2019-06-25  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3444         Remove.
3445
3446 2019-06-25  Tom Tromey  <tom@tromey.com>
3447
3448         * tui/tui-data.h (struct tui_command_element): Remove.
3449         (union tui_which_element) <command>: Remove.
3450         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3451         assert.
3452         (free_content_elements): Remove CMD_WIN case.
3453
3454 2019-06-25  Tom Tromey  <tom@tromey.com>
3455
3456         * tui/tui-layout.c (tui_set_layout): Update.
3457         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3458         * tui/tui-data.c (layout_def): Update.
3459
3460 2019-06-25  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3463         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3464         (tui_source_window_base::set_new_height): Update.
3465         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3466         Update.
3467         (tui_set_locator_fullname, tui_set_locator_info)
3468         (tui_show_frame_info): Update.
3469         * tui/tui-source.c (tui_set_source_content)
3470         (tui_source_is_displayed): Update.
3471         * tui/tui-layout.c (show_source_disasm_command, show_data)
3472         (show_source_or_disasm_and_command): Update.
3473         * tui/tui-disasm.c (tui_set_disassem_content)
3474         (tui_get_begin_asm_address): Update.
3475         * tui/tui-data.h (struct tui_locator_element): Remove.
3476         (union tui_which_element) <locator>: Remove.
3477         (struct tui_locator_window): New.
3478         (tui_locator_win_info_ptr): Change return type.
3479         * tui/tui-data.c (_locator): Change type.
3480         (tui_locator_win_info_ptr): Change return type.
3481         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3482         (tui_alloc_content): Add assert.
3483
3484 2019-06-25  Tom Tromey  <tom@tromey.com>
3485
3486         * tui/tui-winsource.c
3487         (tui_exec_info_window::maybe_allocate_content): New method.
3488         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3489         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3490         (make_source_or_disasm_window): Add cast.
3491         * tui/tui-data.h (union tui_which_element) <simple_string>:
3492         Remove.
3493         (struct tui_source_info): New.
3494         (struct tui_source_window_base) <execution_info>: Change type.
3495         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3496         case, and add assert.
3497         (tui_alloc_content): Add assert.
3498
3499 2019-06-25  Tom Tromey  <tom@tromey.com>
3500
3501         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3502         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3503         * tui/tui-data.c (tui_alloc_win_info): Remove.
3504
3505 2019-06-25  Tom Tromey  <tom@tromey.com>
3506
3507         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3508         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3509         can_highlight.
3510
3511 2019-06-25  Tom Tromey  <tom@tromey.com>
3512
3513         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3514         make_visible_with_new_height method.
3515         (tui_win_info::make_visible_with_new_height): New method.
3516         (tui_source_window_base::do_make_visible_with_new_height)
3517         (tui_data_window::do_make_visible_with_new_height)
3518         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3519         (make_visible_with_new_height): Remove.
3520         (tui_resize_all, tui_adjust_win_heights): Use
3521         make_visible_with_new_height method.
3522         * tui/tui-data.h (struct tui_win_info)
3523         <do_make_visible_with_new_height, make_visible_with_new_height>:
3524         New methods.
3525         (struct tui_source_window_base, struct tui_data_window)
3526         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3527         methods.
3528
3529 2019-06-25  Tom Tromey  <tom@tromey.com>
3530
3531         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3532         method.
3533         (update_tab_width): Call update_tab_width method.
3534         * tui/tui-data.h (struct tui_win_info)
3535         (struct tui_source_window_base) <update_tab_width>: New methods.
3536
3537 2019-06-25  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3540         parameter.
3541         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3542         parameter.
3543         (tui_gen_win_info::make_visible): Update.
3544         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3545         parameter.
3546         * tui/tui-data.h (enum tui_box): New enum.
3547         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3548
3549 2019-06-25  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3552         init_and_make_win for EXEC_INFO_WIN.
3553         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3554         longer inline.
3555         (struct tui_win_info) <~tui_win_info>: Inline.
3556         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3557         Don't declare.
3558         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3559         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3560         Remove.
3561         (tui_initialize_static_data): Update.
3562         (~tui_gen_win_info): Handle more cleanup here.
3563         (~tui_source_window_base): Delete "execution_info".
3564         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3565
3566 2019-06-25  Tom Tromey  <tom@tromey.com>
3567
3568         * tui/tui-layout.c (make_command_window): Don't set
3569         can_highlight.
3570         (show_source_disasm_command): Call the reset method.
3571         (show_data): Don't set can_highlight.  Call the reset method.
3572         (tui_gen_win_info::reset): Rename from init_gen_win_info
3573         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3574         (show_source_or_disasm_and_command): Call the reset method.
3575         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3576         (struct tui_cmd_window): Set can_highlight.
3577
3578 2019-06-25  Tom Tromey  <tom@tromey.com>
3579
3580         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3581         from make_visible.
3582         (tui_make_visible, tui_make_invisible): Rewrite.
3583         (tui_win_info::make_visible): Remove.
3584         (tui_source_window_base::make_visible): Update.
3585         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3586         method.  Moved from...
3587         (struct tui_win_info) <make_visible>: ...here.
3588
3589 2019-06-25  Tom Tromey  <tom@tromey.com>
3590
3591         * tui/tui-winsource.c
3592         (tui_source_window_base::do_scroll_horizontal): Remove direction
3593         parameter.
3594         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3595         direction parameter.
3596         * tui/tui-win.c (tui_win_info::forward_scroll)
3597         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3598         (tui_win_info::right_scroll): Update.
3599         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3600         direction parameter.
3601         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3602         direction parameter.
3603         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3604         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3605         Remove direction parameter.
3606         (struct tui_source_window_base, struct tui_source_window)
3607         (struct tui_disasm_window, struct tui_data_window)
3608         (struct tui_cmd_window): Update.
3609
3610 2019-06-25  Tom Tromey  <tom@tromey.com>
3611
3612         * tui/tui-winsource.h (tui_set_exec_info_content)
3613         (tui_show_exec_info_content, tui_erase_exec_info_content)
3614         (tui_clear_exec_info_content, tui_update_exec_info): Change
3615         argument to tui_source_window_base.
3616         * tui/tui-winsource.c (tui_set_exec_info_content)
3617         (tui_show_exec_info_content, tui_erase_exec_info_content)
3618         (tui_clear_exec_info_content, tui_update_exec_info): Change
3619         argument to tui_source_window_base.
3620
3621 2019-06-25  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3624         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3625
3626 2019-06-25  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3629         check.
3630
3631 2019-06-25  Tom Tromey  <tom@tromey.com>
3632
3633         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3634         type to void.
3635         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3636         type to void.
3637         * tui/tui-source.c (tui_set_source_content): Update.
3638         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3639
3640 2019-06-25  Tom Tromey  <tom@tromey.com>
3641
3642         * tui/tui-win.c (window_name_completer, tui_set_focus)
3643         (tui_all_windows_info): Use name method.
3644         * tui/tui-data.h (struct tui_gen_win_info)
3645         (struct tui_source_window, struct tui_disasm_window)
3646         (struct tui_data_window, struct tui_cmd_window) <name>: New
3647         method.
3648         (tui_win_name): Don't declare.
3649         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3650         (tui_win_name): Remove.
3651
3652 2019-06-25  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-winsource.h (tui_update_source_window)
3655         (tui_update_source_window_as_is): Change parameter type.
3656         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3657         to be a tui_source_window_base.
3658         (tui_update_source_window_as_is): Likewise.
3659         * tui/tui-win.c (make_visible_with_new_height): Update.
3660
3661 2019-06-25  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-winsource.c (tui_erase_source_content)
3664         (tui_show_source_content, tui_show_exec_info_content)
3665         (tui_erase_exec_info_content): Use refresh_window method.
3666         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3667         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3668         from tui_refresh_win.
3669         (tui_data_window::refresh_window): New method.
3670         (tui_win_info::refresh, tui_source_window_base::refresh)
3671         (tui_refresh_all): Use refresh_window method.
3672         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3673         method.
3674         * tui/tui-regs.c (tui_display_register): Call refresh_window
3675         method.
3676         * tui/tui-layout.c (show_source_disasm_command)
3677         (show_source_or_disasm_and_command): Call refresh_window method.
3678         * tui/tui-data.h (struct tui_gen_win_info)
3679         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3680         New method.
3681
3682 2019-06-25  Tom Tromey  <tom@tromey.com>
3683
3684         * tui/tui.c (tui_rl_other_window, tui_enable)
3685         (tui_is_window_visible, tui_get_command_dimension): Update.
3686         * tui/tui-winsource.c (tui_update_source_window_as_is)
3687         (tui_clear_source_content, tui_erase_source_content)
3688         (tui_show_source_line, tui_source_window_base::refill)
3689         (tui_source_window_base::do_scroll_horizontal)
3690         (tui_source_window_base::set_is_exec_point_at)
3691         (tui_update_breakpoint_info, tui_set_exec_info_content)
3692         (tui_alloc_source_buffer, tui_line_is_displayed)
3693         (tui_addr_is_displayed): Update.
3694         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3695         (tui_check_and_display_highlight_if_needed)
3696         (tui_win_info::make_visible, tui_win_info::refresh)
3697         (tui_refresh_all): Update.
3698         * tui/tui-windata.c (tui_first_data_item_displayed)
3699         (tui_delete_data_content_windows, tui_erase_data_content)
3700         (tui_display_all_data, tui_data_window::refresh_all)
3701         (tui_check_data_values): Update.
3702         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3703         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3704         (tui_win_info::backward_scroll, tui_refresh_all_win)
3705         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3706         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3707         (tui_source_window_base::set_new_height)
3708         (tui_data_window::set_new_height)
3709         (make_invisible_and_set_new_height)
3710         (make_visible_with_new_height, new_height_ok)
3711         (parse_scrolling_args): Update.
3712         * tui/tui-stack.c (tui_show_frame_info): Update.
3713         * tui/tui-source.c (tui_set_source_content)
3714         (tui_set_source_content_nil, tui_source_is_displayed)
3715         (tui_source_window::do_scroll_vertical): Update.
3716         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3717         (tui_display_registers_from, tui_display_reg_element_at_line)
3718         (tui_check_register_values, tui_reg_command): Update.
3719         * tui/tui-layout.c (tui_default_win_height)
3720         (show_source_disasm_command, show_data, init_and_make_win)
3721         (show_source_or_disasm_and_command): Update.
3722         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3723         (tui_redisplay_readline, tui_mld_flush)
3724         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3725         (tui_getc): Update.
3726         * tui/tui-disasm.c (tui_set_disassem_content)
3727         (tui_disasm_window::do_scroll_vertical): Update.
3728         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3729         Now virtual.
3730         (struct tui_win_info): Derive from tui_gen_win_info.
3731         <~tui_win_info>: Mark as override.
3732         <generic>: Remove member.
3733         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3734         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3735         (~tui_data_window, ~tui_win_info)
3736         (tui_free_all_source_wins_content): Update.
3737         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3738
3739 2019-06-25  Tom Tromey  <tom@tromey.com>
3740
3741         * tui/tui-layout.c (init_and_make_win): Use new.
3742         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3743         destructor, initializers.
3744         (tui_alloc_generic_win_info): Don't declare.
3745         * tui/tui-data.c (_locator): Add argument to constructor.
3746         (source_win, disasm_win): New globals.
3747         (exec_info): Remove.
3748         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3749         Update.
3750         (tui_alloc_generic_win_info): Remove.
3751         (init_content_element): Use new.
3752         (tui_win_info::tui_win_info): Update.
3753         (free_content_elements) <case DATA_WIN>: Use delete.
3754
3755 2019-06-25  Tom Tromey  <tom@tromey.com>
3756
3757         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3758         * tui/tui-windata.c (tui_first_data_item_displayed)
3759         (tui_delete_data_content_windows): Update.
3760         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3761         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3762         (tui_display_registers_from, tui_check_register_values): Update.
3763         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3764         pointer.
3765         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3766         window.
3767         (tui_free_data_content): Update.
3768         (free_content_elements) <case DATA_WIN>: Free the window.
3769
3770 2019-06-25  Tom Tromey  <tom@tromey.com>
3771
3772         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3773         Update.
3774         * tui/tui-layout.c (make_command_window)
3775         (show_source_disasm_command, show_data, init_and_make_win)
3776         (show_source_or_disasm_and_command): Update.
3777         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3778         method.
3779         <can_highight, is_highlighted>: Now bool.
3780         (tui_set_win_highlight): Don't declare.
3781         * tui/tui-data.c (tui_set_win_highlight): Remove.
3782
3783 2019-06-25  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-wingeneral.c (make_visible): Remove check of window
3786         type.
3787
3788 2019-06-25  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-win.c (tui_win_info::max_height)
3791         (tui_cmd_window::max_height): New methods.
3792         (new_height_ok): Call max_height.
3793         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3794         <max_height>: New method.
3795
3796 2019-06-25  Tom Tromey  <tom@tromey.com>
3797
3798         * tui/tui-win.c (tui_source_window_base::set_new_height)
3799         (tui_data_window::set_new_height): New methods.
3800         (make_invisible_and_set_new_height): Call set_new_height method.
3801         * tui/tui-data.h (struct tui_win_info)
3802         (struct tui_source_window_base, struct tui_data_window)
3803         <set_new_height>: New method.
3804
3805 2019-06-25  Tom Tromey  <tom@tromey.com>
3806
3807         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3808         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3809         tui_refresh_data_win.
3810         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3811         method.
3812         (tui_refresh_all_win): Call the refresh_all method.
3813         (tui_set_focus): Likewise.
3814         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3815         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3816         Likewise.
3817
3818 2019-06-25  Tom Tromey  <tom@tromey.com>
3819
3820         * tui/tui-winsource.h (tui_refill_source_window)
3821         (tui_set_is_exec_point_at): Don't declare.
3822         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3823         (tui_source_window_base::refill): Rename from
3824         tui_refill_source_window.
3825         (tui_source_window_base::do_scroll_horizontal): Update.
3826         (tui_source_window_base::set_is_exec_point_at): Rename from
3827         tui_set_is_exec_point_at.
3828         (tui_update_all_breakpoint_info): Update.
3829         * tui/tui-stack.c (tui_show_frame_info): Update.
3830         * tui/tui-layout.c (show_data): Add cast.
3831         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3832         * tui/tui-data.h (struct tui_source_window_base) <refill,
3833         set_is_exec_point_at>: New methods.
3834         (tui_source_windows, tui_add_to_source_windows): Update types.
3835         (tui_add_to_source_windows): Remove redundant declaration.
3836         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3837         (tui_source_windows): Change return type.
3838         (tui_clear_source_windows_detail): Update.
3839         (tui_add_to_source_windows): Change type of parameter.
3840         (tui_free_all_source_wins_content): Update.
3841
3842 2019-06-25  Tom Tromey  <tom@tromey.com>
3843
3844         * tui/tui-wingeneral.c (tui_win_info::refresh)
3845         (tui_source_window_base::refresh): New methods.
3846         (tui_refresh_all): Call the refresh method.
3847         * tui/tui-data.h (struct tui_win_info)
3848         (struct tui_source_window_base) <refresh>: New method.
3849
3850 2019-06-25  Tom Tromey  <tom@tromey.com>
3851
3852         * tui/tui.h (tui_is_window_visible): Return bool.
3853         * tui/tui.c (tui_is_window_visible): Return bool.
3854         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3855         (tui_make_visible, tui_make_invisible)
3856         (tui_win_info::make_visible)
3857         (tui_source_window_base::make_visible, make_all_visible)
3858         (tui_make_all_visible, tui_make_all_invisible): Update.
3859         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3860         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3861         bool.
3862         (struct tui_win_info, struct tui_source_window_base)
3863         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3864         * tui/tui-data.c (tui_init_generic_part): Update.
3865
3866 2019-06-25  Tom Tromey  <tom@tromey.com>
3867
3868         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3869         (tui_source_window_base::make_visible): New methods.
3870         (make_all_visible): Make method call.
3871         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3872         (struct tui_source_window_base, struct tui_cmd_window): Override
3873         make_visible.
3874         (tui_win_is_source_type): Don't declare.
3875         * tui/tui-data.c (tui_win_is_source_type): Remove.
3876
3877 2019-06-25  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3880         NULL check.
3881
3882 2019-06-25  Tom Tromey  <tom@tromey.com>
3883
3884         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3885         Inline constructor.  Add initializers for members.
3886         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3887         constructors; now inline in class.
3888
3889 2019-06-25  Tom Tromey  <tom@tromey.com>
3890
3891         * tui/tui-regs.c (tui_show_registers): Update.
3892         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3893         bool.
3894         * tui/tui-data.c (tui_data_window::clear_detail)
3895         (tui_data_window): Update.
3896
3897 2019-06-25  Tom Tromey  <tom@tromey.com>
3898
3899         * tui/tui-windata.c (tui_display_all_data)
3900         (tui_display_data_from_line, tui_display_data_from)
3901         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3902         Update.
3903         * tui/tui-regs.c (tui_last_regs_line_no)
3904         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3905         (tui_show_registers, tui_show_register_group)
3906         (tui_display_registers_from, tui_display_reg_element_at_line)
3907         (tui_display_registers_from_line, tui_check_register_values)
3908         (tui_reg_next, tui_reg_prev): Update.
3909         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3910         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3911         tui_data_window.
3912         (struct tui_win_info) <detail>: Remove.  Add new fields from
3913         tui_data_info.
3914         (TUI_DATA_WIN): Add cast.
3915         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3916         (~tui_data_window): Simplify.
3917
3918 2019-06-25  Tom Tromey  <tom@tromey.com>
3919
3920         * tui/tui-layout.c (show_source_disasm_command)
3921         (show_source_or_disasm_and_command): Update.
3922         * tui/tui-io.c (update_cmdwin_start_line)
3923         (tui_redisplay_readline): Update.
3924         * tui/tui-data.h (struct tui_command_info): Remove.
3925         (struct tui_win_info) <detail>: Remove command_info member.
3926         (struct tui_data_window) <start_line>: New member, from
3927         tui_command_info.
3928         (TUI_CMD_WIN): Add casts.
3929
3930 2019-06-25  Tom Tromey  <tom@tromey.com>
3931
3932         * tui/tui-winsource.c (tui_update_source_window)
3933         (tui_refill_source_window)
3934         (tui_source_window_base::do_scroll_horizontal)
3935         (tui_update_breakpoint_info, tui_set_exec_info_content)
3936         (tui_show_exec_info_content, tui_erase_exec_info_content)
3937         (tui_clear_exec_info_content): Update.
3938         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3939         Update.
3940         * tui/tui-win.c (make_invisible_and_set_new_height)
3941         (make_visible_with_new_height): Update.
3942         * tui/tui-source.c (tui_set_source_content)
3943         (tui_show_symtab_source): Update.
3944         * tui/tui-layout.c (extract_display_start_addr)
3945         (show_source_disasm_command, show_data)
3946         (make_source_or_disasm_window)
3947         (show_source_or_disasm_and_command): Update.
3948         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3949         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3950         "gdbarch".
3951         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3952         to tui_source_window_base.
3953         (struct tui_win_info) <detail>: Remove source_info member.
3954         (struct tui_source_window_base) <has_locator>: Inline.
3955         Move contents from tui_source_info; rename has_locator member to
3956         m_has_locator.
3957         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3958         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3959         header file.
3960         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3961         Simplify.
3962         (tui_free_all_source_wins_content): Cast to
3963         tui_source_window_base.
3964
3965 2019-06-25  Tom Tromey  <tom@tromey.com>
3966
3967         * tui/tui-win.c (make_invisible_and_set_new_height)
3968         (make_visible_with_new_height): Call has_locator method.
3969         * tui/tui-layout.c (show_source_disasm_command, show_data)
3970         (show_source_or_disasm_and_command): Update for bool change.
3971         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3972         (tui_win_info) <has_locator>: New method.
3973         (struct tui_source_window_base) <has_locator>: New method.
3974         (tui_win_has_locator): Don't declare.
3975         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3976         from tui_win_has_locator.
3977         (tui_source_window_base): Use false, not FALSE.
3978
3979 2019-06-25  Tom Tromey  <tom@tromey.com>
3980
3981         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3982         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3983         clear_detail method directly.
3984         (tui_clear_win_detail): Remove.
3985
3986 2019-06-25  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3989         "this", not TUI_DISASM_WIN.
3990
3991 2019-06-25  Tom Tromey  <tom@tromey.com>
3992
3993         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3994         declare.
3995         * tui/tui-winsource.c
3996         (tui_source_window_base::do_scroll_horizontal): Rename from
3997         tui_horizontal_source_scroll.
3998         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3999         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4000         from tui_vertical_data_scroll.
4001         * tui/tui-win.h (tui_scroll): Don't declare.
4002         * tui/tui-win.c (tui_win_info::forward_scroll)
4003         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4004         (tui_win_info::right_scroll): Rename and update.
4005         (tui_scroll_forward_command, tui_scroll_backward_command)
4006         (tui_scroll_left_command, tui_scroll_right_command): Update.
4007         (tui_scroll): Remove.
4008         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4009         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4010         from tui_vertical_source_scroll.
4011         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4012         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4013         from tui_vertical_disassem_scroll.
4014         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4015         do_scroll_horizontal>: New methods.
4016         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4017         Likewise.
4018         (struct tui_source_window_base): Add do_scroll_horizontal.
4019         (struct tui_source_window, struct tui_disasm_window): Add
4020         do_scroll_vertical.
4021         (struct tui_data_window, struct tui_cmd_window): Add
4022         do_scroll_horizontal and do_scroll_vertical.
4023         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4024
4025 2019-06-25  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-data.h (struct tui_source_window_base): New struct.
4028         (struct tui_source_window): Derive from tui_source_window_base.
4029         (struct tui_disasm_window): New struct.
4030         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4031         from tui_source_window::clear_detail.
4032         (tui_source_window_base): Rename from tui_source_window.
4033         (~tui_source_window_base): Rename from ~tui_source_window.
4034         (tui_alloc_win_info): Create a tui_disasm_window.
4035
4036 2019-06-25  Tom Tromey  <tom@tromey.com>
4037
4038         * tui/tui-data.h (struct tui_source_window)
4039         (struct tui_data_window): Declare destructors.
4040         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4041         destructors.
4042         (tui_win_info): Simplify.
4043
4044 2019-06-25  Tom Tromey  <tom@tromey.com>
4045
4046         * tui/tui-winsource.c (tui_display_main)
4047         (tui_update_source_windows_with_addr)
4048         (tui_update_all_breakpoint_info): Update.
4049         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4050         (new_height_ok, parse_scrolling_args): Update.
4051         * tui/tui-stack.c (tui_show_frame_info): Update.
4052         * tui/tui-data.h (struct tui_list): Remove.
4053         (tui_source_windows): Return a reference to a std::vector.
4054         * tui/tui-data.c (source_windows): Now a std::vector.
4055         (tui_source_windows): Change return type.
4056         (tui_clear_source_windows): Rewrite.
4057         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4058         (tui_free_all_source_wins_content): Rewrite.
4059
4060 2019-06-25  Tom Tromey  <tom@tromey.com>
4061
4062         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4063         (struct tui_data_window, struct tui_cmd_window): Declare
4064         clear_detail method.
4065         * tui/tui-data.c (tui_source_window::clear_detail)
4066         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4067         methods.
4068         (tui_clear_win_detail): Simplify.
4069
4070 2019-06-25  Tom Tromey  <tom@tromey.com>
4071
4072         * tui/tui-layout.c (make_source_window, make_disasm_window)
4073         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4074         Return the new window.
4075         (show_source_disasm_command, show_data)
4076         (show_source_or_disasm_and_command): Update.
4077
4078 2019-06-25  Tom Tromey  <tom@tromey.com>
4079
4080         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4081         parameter.  Return the new window.
4082         (show_source_disasm_command): Update and remove NULL check.
4083         (show_source_or_disasm_and_command): Update.
4084
4085 2019-06-25  Tom Tromey  <tom@tromey.com>
4086
4087         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4088
4089 2019-06-25  Tom Tromey  <tom@tromey.com>
4090
4091         * tui/tui-data.h (struct tui_win_info): Make constructor
4092         protected.  Make destructor virtual.  Add initializers.
4093         (tui_source_window, tui_data_window, tui_cmd_window): New
4094         classes.
4095         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4096         constructor.  Add "type" parameter.
4097         (tui_source_window, tui_data_window, tui_cmd_window): New
4098         constructors.
4099         (tui_alloc_win_info): Instantiate the appropriate subclass.
4100
4101 2019-06-25  Tom Tromey  <tom@tromey.com>
4102
4103         * tui/tui-win.c (tui_resize_all): Use delete.
4104         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4105         destructor.
4106         (tui_free_window): Don't declare.
4107         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4108         Update.
4109
4110 2019-06-25  Tom Tromey  <tom@tromey.com>
4111
4112         * tui/tui-data.h (struct tui_win_info): Add constructor.
4113         * tui/tui-data.c (tui_alloc_win_info): Use new.
4114         (tui_free_window): Use delete.
4115
4116 2019-06-22  Tom Tromey  <tom@tromey.com>
4117
4118         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4119         declare.
4120         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4121
4122 2019-06-22  Tom Tromey  <tom@tromey.com>
4123
4124         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4125         declare.
4126         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4127
4128 2019-06-22  Tom de Vries  <tdevries@suse.de>
4129
4130         * dwarf2read.c (create_addrmap_from_aranges)
4131         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4132         instead of '%zu'.
4133
4134 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4135
4136         * dwarf2read.h (dwarf2_section_info_def): Remove.
4137         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4138         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4139         std::vector<dwarf2_section_info>.
4140         (struct dwo_file) <~dwo_file>: Remove.
4141         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4142         types field.
4143         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4144         (dwarf2_read_debug_names): Likewise.
4145         (create_debug_types_hash_table): Change parameter type to
4146         array_view, adjust code accordingly.
4147         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4148         (partial_die_info::fixup): Likewise.
4149         (determine_prefix): Likewise.
4150         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4151
4152 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4153
4154         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4155         gdb_bfd_ref_ptr.
4156         <~dwo_file>: Remove call to gdb_bfd_unref.
4157         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4158         gdb_bfd_ref_ptr::get.
4159
4160 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4161
4162         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4163         type to htab_up.
4164         * dwarf2read.c (struct dwo_file): Initialize fields.
4165         <~dwo_file>: New.
4166         (free_dwo_file): Remove, move content to ~dwo_file.
4167         (struct dwo_file_deleter): Remove.
4168         (dwo_file_up>: Remove custom deleter.
4169         (free_dwo_files): Remove.
4170         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4171         dwo_files.
4172         (process_skeletonless_type_units): Call unique_ptr::get.
4173         (allocate_dwo_file_hash_table): Add deleter to created hash
4174         table.  Change return type to htab_up.
4175         (lookup_dwo_file_slot): Don't memset dwo_file, call
4176         unique_ptr::get.
4177         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4178         (create_dwo_unit_in_dwp_v2): Likewise.
4179         (open_and_init_dwo_file): Likewise.
4180         (free_dwo_file_from_slot): Remove.
4181
4182 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4183
4184         * dwarf2read.h (struct dwarf2_section_info) <readin,
4185         is_virtual>: Change type to bool.
4186         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4187         true instead of 1.
4188
4189 2019-06-19  Tom Tromey  <tom@tromey.com>
4190
4191         * tui/tui-data.h (tui_init_content_element): Don't declare.
4192
4193 2019-06-19  Tom Tromey  <tom@tromey.com>
4194
4195         * tui/tui-data.h (tui_init_win_info): Don't declare.
4196
4197 2019-06-19  Tom de Vries  <tdevries@suse.de>
4198
4199         * dwarf2read.h (abstract_to_concrete): Change type to
4200         std::unordered_map<sect_offset, std::vector<sect_offset>,
4201         gdb::hash_enum<sect_offset>>.
4202
4203 2019-06-19  Tom Tromey  <tromey@adacore.com>
4204
4205         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4206         EVAL_AVOID_SIDE_EFFECTS specially.
4207
4208 2019-06-19  Tom Tromey  <tromey@adacore.com>
4209
4210         * source-cache.c (highlighter): New global.
4211         (source_cache::get_source_lines): Create a highlighter on demand.
4212
4213 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * defs.h (deprecated_interactive_hook): Delete declaration.
4216         * interps.c (clear_interpreter_hooks): Remove use of
4217         deprecated_interactive_hook.
4218         * top.c (deprecated_interactive_hook): Delete definition.
4219         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4220
4221 2019-06-18  Tom de Vries  <tdevries@suse.de>
4222
4223         PR gdb/24515
4224         * dwarf2read.h (abstract_to_concrete): Change type from
4225         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4226         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4227         * dwarf2read.c (read_variable): Update.
4228         (dwarf2_fetch_die_loc_sect_off): Update.
4229
4230 2019-06-17  Tom de Vries  <tdevries@suse.de>
4231
4232         PR gdb/24617
4233         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4234         accessing parent[parent_len - 1].
4235
4236 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4237
4238         PR gdb/24364
4239         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4240         call dtrace_process_dof with NULL dof.
4241
4242 2019-06-16  Tom de Vries  <tdevries@suse.de>
4243
4244         PR gdb/24445
4245         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4246
4247 2019-06-16  Tom Tromey  <tom@tromey.com>
4248
4249         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4250         (make_all_visible): Use address of member.
4251
4252 2019-06-16  Tom Tromey  <tom@tromey.com>
4253
4254         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4255         (tui_free_window, free_content, free_content_elements): Remove
4256         unnecessary cast.
4257         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4258         cast.
4259         * tui/tui-regs.c (tui_show_register_group)
4260         (tui_display_registers_from, tui_display_reg_element_at_line):
4261         Remove unnecessary cast.
4262
4263 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4264
4265         * linux-nat.c (normal_mask): Delete.
4266         (_initialize_linux_nat): Don't initialise normal_mask.
4267
4268 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4269
4270         PR gdb/24445
4271         * dwarf-index-write.h (write_psymtabs_to_index): Add
4272         dwz_basename parameter.
4273         * dwarf-index-write.c (write_gdbindex): Move file writing to
4274         write_gdbindex_1.  Change return type void.
4275         (assert_file_size): Move up, remove filename parameter.
4276         (write_gdbindex_1): New function.
4277         (write_debug_names): Change return type to void, call
4278         assert_file_size.
4279         (struct index_wip_file): New struct.
4280         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4281         file logic to index_wip_file.  Write index for dwz file if
4282         needed.
4283         (save_gdb_index_command): Pass basename of dwz file, if present.
4284         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4285         build-id of dwz file, if present.
4286         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4287         (dwarf2_get_dwz_file): Likewise.
4288         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4289         (dwarf2_get_dwz_file): Likewise.
4290
4291 2019-06-16  Tom Tromey  <tom@tromey.com>
4292
4293         * coffread.c (process_coff_symbol): Use xstrdup.
4294         * value.c (create_internalvar): Use xstrdup.
4295
4296 2019-06-16  Tom Tromey  <tom@tromey.com>
4297
4298         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4299         * breakpoint.c (stopin_command, stopat_command)
4300         (until_break_command, decode_location_default): Remove unnecessary
4301         cast.
4302         * utils.c (subset_compare): Remove unnecessary cast.
4303         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4304         cast.
4305         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4306         cast.
4307         * infcmd.c (path_command): Remove unnecessary cast.
4308         * coffread.c (decode_type): Remove unnecessary cast.
4309         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4310         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4311         * tui/tui-stack.c (tui_show_locator_content)
4312         (tui_show_frame_info): Remove unnecessary cast.
4313         * tui/tui-win.c (tui_scroll_forward_command)
4314         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4315         (parse_scrolling_args): Remove unnecessary cast.
4316         * tui/tui-data.c (init_win_info, tui_del_window)
4317         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4318         (free_content_elements): Remove unnecessary cast.
4319         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4320         unnecessary cast.
4321         * tui/tui-source.c (tui_set_source_content)
4322         (tui_vertical_source_scroll): Remove unnecessary cast.
4323         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4324         cast.
4325         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4326         * tui/tui-regs.c (tui_display_registers_from)
4327         (tui_display_register): Remove unnecessary cast.
4328         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4329         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4330         (make_visible): Remove unnecessary cast.
4331         * tui/tui-winsource.c (tui_erase_source_content)
4332         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4333         unnecessary cast.
4334         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4335         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4336         * stabsread.c (read_type, read_array_type, read_range_type):
4337         Remove unnecessary cast.
4338         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4339         (parse_symbol, parse_type, upgrade_type, parse_external)
4340         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4341         unnecessary cast.
4342         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4343
4344 2019-06-16  Tom Tromey  <tom@tromey.com>
4345
4346         * tui/tui-data.c (tui_alloc_generic_win_info)
4347         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4348         checks.
4349
4350 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4351             Andrew Burgess  <andrew.burgess@embecosm.com>
4352
4353         * f-typeprint.c (f_print_type): Don't return early for not
4354         associated or not allocated types.
4355         (f_type_print_varspec_suffix): Add print_rank parameter and print
4356         ranks of array types in case they dangling.
4357         (f_type_print_base): Add print_rank parameter.
4358
4359 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * NEWS: Mention new MI commands.
4362         * break-catch-throw.c (enum exception_event_kind): Move to
4363         breakpoint.h.
4364         (print_mention_exception_catchpoint): Output text as a single
4365         message.
4366         (catch_exception_command_1): Rename to...
4367         (catch_exception_event): ...this, make non-static, update header
4368         command, and change some parameter types.
4369         (catch_catch_command): Update for changes to
4370         catch_exception_command_1.
4371         (catch_throw_command): Likewise.
4372         (catch_rethrow_command): Likewise.
4373         * breakpoint.c (enum exception_event_kind): Delete.
4374         * breakpoint.h (enum exception_event_kind): Moved here from
4375         break-catch-throw.c.
4376         (catch_exception_event): Declare.
4377         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4378         (mi_cmd_catch_throw): New function.
4379         (mi_cmd_catch_rethrow): New function.
4380         (mi_cmd_catch_catch): New function.
4381         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4382         'catch-catch' entries.
4383         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4384         (mi_cmd_catch_rethrow): Declare.
4385         (mi_cmd_catch_catch): Declare.
4386
4387 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4388
4389         * annotate.c (annotate_source_line): Change return type to void,
4390         update implementation to match.
4391         * annotate.h (annotate_source_line): Change return type to void,
4392         update header comment.
4393         * stack.c (print_frame_info): Don't change what frame information
4394         is printed based on whether annotations are on or not.
4395
4396 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4397
4398         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4399         (annotate_source): Make static.
4400         (annotate_source_line): Moved from source.c and renamed from
4401         identify_source_line.  Update the return type.
4402         * annotate.h (annotate_source): Delete declaration.
4403         (annotate_source_line): Declaration moved from source.h, and
4404         renamed from identify_source_line.  Return type updated.
4405         * source.c (identify_source_line): Moved to annotate.c and renamed
4406         to annotate_source_line.
4407         (info_line_command): Remove check of annotation_level.
4408         * source.h (identify_source_line): Move declaration to annotate.h
4409         and rename to annotate_source_line.
4410         * stack.c: Add 'annotate.h' include.
4411         (print_frame_info): Remove check of annotation_level before
4412         calling annotate_source_line.
4413
4414 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4415
4416         * source-cache.c (source_cache::get_plain_source_lines): Use
4417         open_source_file_with_line_charpos instead of just
4418         open_source_file, remove call to find_source_lines.
4419         (source_cache::get_source_lines): Likewise.
4420         * source.c (find_source_lines): Make static.
4421         (get_filename_and_charpos): Renamed into...
4422         (open_source_file_with_line_charpos): ..this along with changes to
4423         return a scoped_fd, and some other minor clean ups.
4424         (identify_source_line): Use open_source_file_with_line_charpos.
4425         (search_command_helper): Use open_source_file_with_line_charpos
4426         instead of just open_source_file, remove call to
4427         find_source_lines.
4428         * source.h (open_source_file_with_line_charpos): Declare new
4429         function.
4430         (find_source_lines): Delete declaration.
4431
4432 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4433
4434         * source.c (get_filename_and_charpos): Remove fullname
4435         parameter.
4436         (identify_source_line): Update call to get_filename_and_charpos.
4437
4438 2019-06-14  Tom Tromey  <tromey@adacore.com>
4439
4440         PR gdb/24502:
4441         * ui-style.h (skip_ansi_escape): Update comment.
4442         * ui-file.h (class no_terminal_escape_file): New class.
4443         * ui-file.c (no_terminal_escape_file::write)
4444         (no_terminal_escape_file::puts): New methods.
4445         * cli/cli-logging.c (handle_redirections): Use
4446         no_terminal_escape_file.
4447
4448 2019-06-14  Tom Tromey  <tromey@adacore.com>
4449
4450         * NEWS: Move convenience variable news above Python news.
4451
4452 2019-06-14  Tom Tromey  <tom@tromey.com>
4453
4454         * gnulib: Move directory to top-level.
4455         * configure.ac: Don't configure gnulib.
4456         * configure: Rebuild.
4457         * common/common-defs.h: Use new path to gnulib.
4458         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4459         (GNULIB_H): Remove.
4460         (INCGNU): Look in new gnulib location.
4461         (HFILES_NO_SRCDIR): Remove gnulib files.
4462         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4463         (generated_files): Remove GNULIB_H.
4464         ($(LIBGNU), all-lib): Remove targets.
4465         (distclean): Don't mention GNULIB_BUILDDIR.
4466         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4467
4468 2019-06-14  Tom Tromey  <tromey@adacore.com>
4469
4470         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4471         Warn if symbol file does not provide any symbols.
4472
4473 2019-06-14  Tom Tromey  <tromey@adacore.com>
4474
4475         * source.c (find_and_open_source): Respect basenames_may_differ.
4476
4477 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4478
4479         * annotate.c (annotate_breakpoints_invalid): Make use of
4480         scoped_restore_terminal_state.
4481         (annotate_frames_invalid): Likewise.
4482
4483 2019-06-14  Tom Tromey  <tromey@adacore.com>
4484
4485         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4486         allow assignment to an internalvar.
4487
4488 2019-06-14  Tom Tromey  <tromey@adacore.com>
4489
4490         * ada-lex.l: Allow "_" in attribute names.
4491
4492 2019-06-14  Tom Tromey  <tromey@adacore.com>
4493
4494         PR gdb/24653:
4495         * regcache.c (registers_changed): Don't call alloca.
4496         * top.c (execute_command): Don't call alloca.
4497
4498 2019-06-13  Pedro Alves  <palves@redhat.com>
4499
4500         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4501         'expression'.  When parsing an expression, error out if there's
4502         junk after "unlimited".
4503         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4504         (do_set_command): Adjust calls to is_unlimited_literal.
4505
4506 2019-06-13  Pedro Alves  <palves@redhat.com>
4507
4508         * compile/compile.c (make_compile_options_def_group): Add braces
4509         around array_view initializer.
4510         * thread.c (make_thread_apply_all_options_def_group)
4511         (make_thread_apply_all_options_def_group): Likewise.
4512
4513 2019-06-13  Pedro Alves  <palves@redhat.com>
4514
4515         * NEWS (New commands): Mention "maint test-options
4516         require-delimiter", "maint test-options unknown-is-error", "maint
4517         test-options unknown-is-operand" and "maint show
4518         test-options-completion-result".
4519         (New command options, command completion): New section.
4520         (Completion improvements): New section.
4521         Mention that you can abbreviate "unlimited".
4522
4523 2019-06-13  Pedro Alves  <palves@redhat.com>
4524
4525         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4526         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4527         * unittests/cli-utils-selftests.c (test_parse_flags)
4528         (test_parse_flags_qcs): Delete.
4529         (test_cli_utils): Don't call deleted functions.
4530
4531 2019-06-13  Pedro Alves  <palves@redhat.com>
4532
4533         * thread.c: Include "cli/cli-option.h".
4534         (tp_array_compar_ascending): Global.
4535         (tp_array_compar): Delete function.
4536         (tp_array_compar_ascending, tp_array_compar_descending): New
4537         functions.
4538         (ascending_option_def, qcs_flag_option_def)
4539         (thr_qcs_flags_option_defs)
4540         (make_thread_apply_all_options_def_group)
4541         (make_thread_apply_options_def_group): New.
4542         (thread_apply_all_command): Use gdb::option::process_options.
4543         (thread_apply_command_completer)
4544         (thread_apply_all_command_completer): New.
4545         (thread_apply_command): Use gdb::option::process_options.
4546         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4547         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4548         to generate help text of "thread apply".  Adjust "taas"'s help.
4549         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4550         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4551
4552 2019-06-13  Pedro Alves  <palves@redhat.com>
4553
4554         * thread.c (thread_apply_command): Check for invalid TID with
4555         isdigit instead of !isalpha.
4556
4557 2019-06-13  Pedro Alves  <palves@redhat.com>
4558
4559         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4560         (validate_flags_qcs): New.
4561         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4562         (validate_flags_qcs): Declare.
4563         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4564         (make_frame_apply_options_def_group): New.
4565         (frame_apply_command_count): Process options with
4566         gdb::option::process_options.
4567         (frame_apply_completer): New.
4568         (frame_apply_level_completer, frame_apply_all_completer)
4569         (frame_apply_completer): New.
4570         (_initialize_stack): Update help of "frame apply", "frame apply
4571         level", "frame apply all" and "faas" to mention supported options
4572         and install command completers.
4573         * stack.h (frame_apply_all_completer): Declare.
4574         * thread.c: Include "stack.h".
4575         (tfaas_command): Add "--".
4576         (_initialize_thread): Update help "tfaas" to mention supported
4577         options and install command completer.
4578
4579 2019-06-13  Pedro Alves  <palves@redhat.com>
4580
4581         * completer.c (complete_nested_command_line): New.
4582         (gdb_completion_word_break_characters_throw): Add assertion.
4583         * completer.h (complete_nested_command_line): Declare.
4584
4585 2019-06-13  Pedro Alves  <palves@redhat.com>
4586
4587         * stack.c (parse_backtrace_qualifiers): New.
4588         (backtrace_command): Use it.
4589         (backtrace_command_completer): Complete on qualifiers.
4590
4591 2019-06-13  Pedro Alves  <palves@redhat.com>
4592
4593         * frame.c: Include "cli/cli-option.h.
4594         (user_set_backtrace_options): New.
4595         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4596         Delete.
4597         (get_prev_frame): Adjust.
4598         (boolean_option_def, uinteger_option_def)
4599         (set_backtrace_option_defs): New.
4600         (_initialize_frame): Adjust and use
4601         gdb::option::add_setshow_cmds_for_options to install "set
4602         backtrace past-main" and "set backtrace past-entry".
4603         * frame.h: Include "cli/cli-option.h".
4604         (struct frame_print_options): Forward declare.
4605         (print_frame_arguments_all, print_frame_arguments_scalars)
4606         (print_frame_arguments_none): Declare.
4607         (print_entry_values): Delete declaration.
4608         (struct frame_print_options, user_frame_print_options): New.
4609         (struct set_backtrace_options): New.
4610         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4611         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4612         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4613         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4614         (list_args_or_locals): Add frame_print_options parameter.
4615         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4616         * python/py-framefilter.c (enumerate_args): Pass down
4617         USER_FRAME_PRINT_OPTIONS.
4618         * stack.c: Include "cli/cli-option.h".
4619         (print_frame_arguments_all, print_frame_arguments_scalars)
4620         (print_frame_arguments_none): Declare.
4621         (print_raw_frame_arguments, print_entry_values): Delete.
4622         (user_frame_print_options): New.
4623         (boolean_option_def, enum_option_def, frame_print_option_defs):
4624         New.
4625         (struct backtrace_cmd_options): New.
4626         (bt_flag_option_def): New.
4627         (backtrace_command_option_defs): New.
4628         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4629         (print_frame_arg, read_frame_arg, print_frame_args)
4630         (print_frame_info, print_frame): Add frame_print_options parameter
4631         and use it.
4632         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4633         (backtrace_command_1): Add frame_print_options and
4634         backtrace_cmd_options parameters and use them.
4635         (make_backtrace_options_def_group): New.
4636         (backtrace_command): Process command options with
4637         gdb::option::process_options.
4638         (backtrace_command_completer): New.
4639         (_initialize_stack): Extend "backtrace"'s help to mention
4640         supported options.  Install completer for "backtrace".
4641         Install some settings commands with add_setshow_cmds_for_options.
4642
4643 2019-06-13  Pedro Alves  <palves@redhat.com>
4644
4645         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4646         and that "set/show print raw frame-arguments" are now deprecated.
4647
4648         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4649         command.
4650         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4651         * stack.c (_initialize_stack): Install "set/show print
4652         raw-frame-arguments", and deprecate "set/show print raw
4653         frame-arguments".
4654         * valprint.c (_initialize_valprint): Deprecate "set/show print
4655         raw".
4656
4657 2019-06-13  Pedro Alves  <palves@redhat.com>
4658
4659         * compile/compile.c (struct compile_options): New.
4660         (compile_flag_option_def, compile_command_option_defs)
4661         (make_compile_options_def_group): New.
4662         (compile_file_command): Handle options with
4663         gdb::option::process_options.
4664         (compile_file_command_completer): New function.
4665         (compile_code_command): Handle options with
4666         gdb::option::process_options.
4667         (compile_code_command_completer): New function.
4668         (_initialize_compiler): Install completers for "compile code" and
4669         "compile file".  Mention available options in "compile code" and
4670         "compile code"'s help.
4671         * completer.c (advance_to_completion_word): New, factored out from
4672         ...
4673         (advance_to_expression_complete_word_point): ... this.
4674         (advance_to_filename_complete_word_point): New.
4675         * completer.h (advance_to_filename_complete_word_point): New
4676         declaration.
4677
4678 2019-06-13  Pedro Alves  <palves@redhat.com>
4679
4680         * compile/compile.c: Include "cli/cli-option.h".
4681         (compile_print_value): Scope data pointer is now a
4682         value_print_options pointer; adjust.
4683         (compile_print_command): Process options.  Scope data pointer is
4684         now a value_print_options pointer; adjust.
4685         (_initialize_compile): Update "compile print"'s help to include
4686         supported options.  Install a completer for "compile print".
4687         * cp-valprint.c (show_vtblprint, show_objectprint)
4688         (show_static_field_print): Delete.
4689         (_initialize_cp_valprint): Don't install "set print
4690         static-members", "set print vtbl", "set print object" here.
4691         * printcmd.c: Include "cli/cli-option.h" and
4692         "common/gdb_optional.h".
4693         (print_command_parse_format): Rework to fill in a
4694         value_print_options instead of a format_data.
4695         (print_value): Change parameter type from format_data pointer to
4696         value_print_options reference.  Adjust.
4697         (print_command_1): Process options.  Adjust to pass down a
4698         value_print_options.
4699         (print_command_completer): New.
4700         (_initialize_printcmd): Install print_command_completer as
4701         handle_brkchars completer for the "print" command.  Update
4702         "print"'s help to include supported options.
4703         * valprint.c: Include "cli/cli-option.h".
4704         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4705         here from cp-valprint.c.
4706         (boolean_option_def, uinteger_option_def)
4707         (value_print_option_defs, make_value_print_options_def_group):
4708         New.  Use gdb::option::add_setshow_cmds_for_options to install
4709         "set print elements", "set print null-stop", "set print repeats",
4710         "set print pretty", "set print union", "set print array", "set
4711         print address", "set print symbol", "set print array-indexes".
4712         * valprint.h: Include <string> and "cli/cli-option.h".
4713         (make_value_print_options_def_group): Declare.
4714         (print_value): Change parameter type from format_data pointer to
4715         value_print_options reference.
4716         (print_command_completer): Declare.
4717
4718 2019-06-13  Pedro Alves  <palves@redhat.com>
4719
4720         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4721         (COMMON_SFILES): Add maint-test-settings.c.
4722         * cli/cli-decode.c (boolean_enums): New global, factored out from
4723         ...
4724         (add_setshow_boolean_cmd): ... here.
4725         * cli/cli-decode.h (boolean_enums): Declare.
4726         * cli/cli-option.c: New file.
4727         * cli/cli-option.h: New file.
4728         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4729         factored out from ...
4730         (parse_cli_boolean_value(const char *)): ... this.
4731         (is_unlimited_literal): Change parameter type to pointer to
4732         pointer.  Adjust and advance ARG pointer.
4733         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4734         (parse_cli_var_enum): New, factored out from ...
4735         (do_set_command): ... this.  Adjust.
4736         * cli/cli-setshow.h (parse_cli_boolean_value)
4737         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4738         (parse_cli_var_enum): Declare.
4739         * cli/cli-utils.c: Include "cli/cli-option.h".
4740         (get_ulongest): New.
4741         * cli/cli-utils.h (get_ulongest): Declare.
4742         (check_for_argument): New overloads.
4743         * maint-test-options.c: New file.
4744
4745 2019-06-13  Pedro Alves  <palves@redhat.com>
4746
4747         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4748         parse a range if "-" is at the end of the string.
4749
4750 2019-06-13  Pedro Alves  <palves@redhat.com>
4751
4752         * cli/cli-setshow.c (parse_auto_binary_operation)
4753         (parse_cli_boolean_value): Don't allow "o".
4754
4755 2019-06-13  Pedro Alves  <palves@redhat.com>
4756
4757         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4758         * NEWS: Mention maint test-settings KIND.
4759         * maint-test-settings.c: New file.
4760
4761 2019-06-13  Pedro Alves  <palves@redhat.com>
4762
4763         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4764         completer.
4765         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4766         "set" completers.
4767
4768 2019-06-13  Pedro Alves  <palves@redhat.com>
4769
4770         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4771         after item.
4772
4773 2019-06-13  Pedro Alves  <palves@redhat.com>
4774
4775         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4776
4777 2019-06-13  Pedro Alves <palves@redhat.com>
4778
4779         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4780         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4781         call.
4782         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4783         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4784         calls.
4785         (check_for_argument): Skip spaces after argument.
4786
4787 2019-06-13  Pedro Alves  <palves@redhat.com>
4788
4789         * thread.c (thread_apply_command): Adjust TID parsing.
4790         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4791         detected before end of string.
4792         (tid_is_in_list): Error out if LIST is invalid.
4793
4794 2019-06-13  Pedro Alves  <palves@redhat.com>
4795
4796         * completer.c (complete_line_internal_1): Rewind completion word
4797         point.
4798         (completion_tracker::advance_custom_word_point_by): Change
4799         parameter type to int.
4800         * completer.h (completion_tracker::advance_custom_word_point_by):
4801         Likewise.
4802
4803 2019-06-13  Pedro Alves  <palves@redhat.com>
4804
4805         * completer.c (advance_to_completion_word): Handle delimiters.
4806
4807 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4808
4809         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4810
4811 2019-06-11  Tom Tromey  <tom@tromey.com>
4812
4813         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4814         (xmalloc_failed): Move to alloc.c.
4815         * alloc.c: New file.
4816         * Makefile.in (COMMON_SFILES): Add alloc.c.
4817
4818 2019-06-11  Tom Tromey  <tom@tromey.com>
4819
4820         * nat/linux-waitpid.c: Don't include server.h.
4821         (linux_debug): Remove.
4822         (my_waitpid): Update.
4823
4824 2019-06-11  Tom Tromey  <tromey@adacore.com>
4825
4826         * infcall.c (_initialize_infcall): Remove trailing newline from
4827         help.
4828         * user-regs.c (_initialize_user_regs): Remove trailing newline
4829         from help.
4830         * typeprint.c (_initialize_typeprint): Remove trailing newline
4831         from help.
4832         * reverse.c (_initialize_reverse): Remove trailing newlines from
4833         help.
4834         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4835         from help.
4836         * language.c (add_set_language_command): Remove trailing newline
4837         from help.
4838         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4839         help.
4840         * disasm.c (_initialize_disasm): Remove trailing newline from
4841         help.
4842         * top.c (init_main): Remove trailing newline from help.
4843         * interps.c (_initialize_interpreter): Remove trailing newline
4844         from help.
4845         * btrace.c (_initialize_btrace): Remove trailing newlines from
4846         help.
4847         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4848         from help.
4849         * python/python.c (_initialize_python): Remove trailing newline
4850         from help.
4851         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4852         help.
4853         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4854         from help.  Reformat some text.
4855         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4856         from help.
4857         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4858         newline from help.
4859
4860 2019-06-11  Tom Tromey  <tromey@adacore.com>
4861
4862         * darwin-nat.c (darwin_decode_exception_message)
4863         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4864
4865 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4866
4867         * valops.c (value_slice): Check for not allocated or not
4868         associated values.
4869
4870 2019-06-10  Tom de Vries  <tdevries@suse.de>
4871
4872         PR gdb/24618
4873         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4874         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4875         invalid.
4876
4877 2019-06-10  Tom de Vries  <tdevries@suse.de>
4878
4879         PR gdb/24611
4880         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4881         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4882
4883 2019-06-10  Tom de Vries  <tdevries@suse.de>
4884
4885         PR symtab/24545
4886         * symtab.c (struct demangled_name_entry): Add language field.
4887         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4888         static minimal symbol".  Set and use language field.
4889
4890 2019-06-10  Tom Tromey  <tromey@adacore.com>
4891
4892         * ada-lang.c (_initialize_ada_language): Update help text.
4893
4894 2019-06-10  Tom Tromey  <tromey@adacore.com>
4895
4896         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4897         with a newline.
4898         * guile/guile.c (handle_boot_error): Don't end warning with a
4899         newline.
4900         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4901         warning with a newline.
4902         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4903         newline.
4904         (s12z_frame_cache): Likewise.
4905         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4906         a newline.
4907         * solib-svr4.c (disable_probes_interface): Don't end warning with
4908         a newline.
4909         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4910         newline.
4911         * python/python.c (do_finish_initialization): Don't end warning
4912         with a newline.
4913
4914 2019-06-10  Tom Tromey  <tom@tromey.com>
4915
4916         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4917         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4918         gdbpy_enter.
4919
4920 2019-06-10  Tom Tromey  <tromey@adacore.com>
4921
4922         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4923         data.
4924         (elf_new_init): Don't call stabsread_new_init.
4925         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4926         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4927         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4928
4929 2019-06-10  Tom de Vries  <tdevries@suse.de>
4930
4931         PR symtab/16264
4932         PR symtab/24517
4933         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4934
4935 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4936
4937         * source.c (find_and_open_source): Also rewrite relative file
4938         names.
4939
4940 2019-04-26  Amos Bird  <amosbird@gmail.com>
4941
4942         * annotate.c (annotate_thread_exited): Add "thread-exited"
4943         annotation.
4944
4945 2019-06-06  Tom Tromey  <tromey@adacore.com>
4946
4947         * maint.h (class scoped_command_stats): Use
4948         DISABLE_COPY_AND_ASSIGN.
4949         <print_time>: New method.
4950         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4951         print_time.
4952         (scoped_command_stats::print_time): New method.
4953
4954 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4955
4956         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4957         instructions of lengths 6 or 8 bytes.
4958
4959 2019-06-04  Pedro Alves  <palves@redhat.com>
4960
4961         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4962
4963         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4964         * breakpoint.c (condition_completer): Likewise.
4965         * cli/cli-dump.c (scan_expression): Likewise.
4966         * common/filestuff.c (mkdir_recursive): Likewise.
4967         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4968         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4969         (gdb_abspath): Likewise.
4970         * compile/compile-cplus-types.c
4971         (compile_cplus_instance::decl_name): Likewise.
4972         * completer.c (complete_explicit_location):
4973         (signal_completer, reg_or_group_completer_1): Likewise.
4974         * cp-support.c (cp_remove_params_if_any): Likewise.
4975         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4976         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4977         * infcmd.c (strip_bg_char): Likewise.
4978         * linespec.c (copy_token_string): Likewise.
4979         * mi/mi-main.c (output_cores): Likewise.
4980         * psymtab.c (psymtab_search_name):
4981         * symfile.c (test_set_ext_lang_command): Likewise.
4982         * target.c (target_fileio_read_stralloc): Likewise.
4983         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4984         * value.c (complete_internalvar): Likewise.
4985
4986 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4987
4988         Add objfile property to gdb.Type.
4989         * NEWS: Mention Python API addition.
4990         * python/py-type.c (typy_get_objfile): New method.
4991
4992 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4993
4994         * NEWS: Mention the new set|show style [title|highlight].
4995         Mention changes to "show style", "help" and "apropos".
4996
4997 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4998
4999         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5000         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5001         instead of print_help_for_command.
5002         (print_doc_of_command): New function.
5003         (help_list): Add 'apropos -v word' suggestion.
5004         (print_help_for_command): Style the command name using title style.
5005         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5006         (_initialize_cli_cmds): Describe -v in apropos_command help.
5007
5008 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5009
5010         * cli/cli-style.h (cli_style_option): Add name in constructor,
5011         add m_name class member, add constructor with intensity,
5012         add name class function.
5013         (cli_style_option::add_setshow_commands): Remove name argument.
5014         (highlight_style, title_style): New styles.
5015         * cli/cli-style.c (do_show): New function that shows a style
5016         characteristic styling the style name with itself.
5017         (set_style_name): New function.
5018         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5019         Update all callers according to the changes in cli/cli-style.h.
5020         * utils.h (fputs_highlighted): New function.
5021         * utils.c (fputs_highlighted): Likewise.
5022
5023 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5024
5025         * NEWS: Mention new pipe command and new convenience variables.
5026
5027 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5028
5029         * cli/cli-cmds.c (pipe_command): New function.
5030         (_initialize_cli_cmds): Call add_com for pipe_command.
5031         Define | as an alias for pipe.
5032         (exit_status_set_internal_vars): New function.
5033         (shell_escape): Call exit_status_set_internal_vars.
5034         cli/cli-decode.c (find_command_name_length): Recognize | as
5035         a single character command.
5036
5037 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5038
5039         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5040         top.c (execute_command_to_ui_file): New function, mostly a copy
5041         of execute_command_to_string.
5042         (execute_command_to_string): Implement by calling
5043         execute_command_to_ui_file.
5044
5045 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5046
5047         * top.h (saved_command_line): Remove declaration.
5048         * top.c (previous_saved_command_line, previous_repeat_arguments):
5049         New variables.
5050         (saved_command_line): Make static, define together with other
5051         'repeat variables'.
5052         (dont_repeat): Clear repeat_arguments.
5053         (repeat_previous, get_saved_command_line, save_command_line):
5054         New functions.
5055         (gdb_init): Initialize saved_command_line
5056         and previous_saved_command_line.
5057         * main.c (captured_main_1): Remove saved_command_line initialization.
5058         * event-top.c (handle_line_of_input): Update to use
5059         the new 'repeat' related functions instead of direct access to
5060         saved_command_line.
5061         * command.h (repeat_previous, get_saved_command_line,
5062         save_command_line): New declarations.
5063         (dont_repeat): Add comment.
5064
5065 2019-05-30  Tom Tromey  <tromey@adacore.com>
5066
5067         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5068         Fix comment.
5069         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5070
5071 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5072
5073         PR cli/24587
5074         * completer.c (complete): Initialize variable word.
5075
5076 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5077
5078         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5079         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5080         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5081         'body' is NULL to the outter 'if', protecting the '!is_define'
5082         situation as well.
5083
5084 2019-05-29  Tom Tromey  <tromey@adacore.com>
5085
5086         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5087         (dwarf_unknown): New function.
5088         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5089         (dwarf_type_encoding_name): Use dwarf_unknown.
5090
5091 2019-05-29  Tom Tromey  <tromey@adacore.com>
5092
5093         PR c++/20020:
5094         * cp-valprint.c (cp_print_value_fields): Call
5095         cp_print_static_field inside "try".
5096
5097 2019-05-29  Tom Tromey  <tromey@adacore.com>
5098
5099         * inflow.c (struct terminal_info): Add default operator=.
5100         * configure: Rebuild.
5101         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5102         -Wdeprecated-copy-dtor, -Wredundant-move.
5103
5104 2019-05-29  Tom Tromey  <tromey@adacore.com>
5105
5106         * NEWS: Add entry.
5107         * infcmd.c (print_return_value_1): Handle finish_print
5108         option.
5109         (show_print_finish): New function.
5110         (_initialize_infcmd): Add "set/show print finish" commands.
5111         * valprint.c (user_print_options): Initialize new member.
5112         * valprint.h (struct value_print_options) <finish_print>: New
5113         member.
5114
5115 2019-05-28  Tom Tromey  <tromey@adacore.com>
5116
5117         * ada-lang.c (ada_remove_Xbn_suffix)
5118         (find_old_style_renaming_symbol)
5119         (parse_old_style_renaming): Remove.
5120         (ada_find_renaming_symbol): Don't call
5121         find_old_style_renaming_symbol.
5122         (ada_is_renaming_symbol): Rename from
5123         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5124         bool.  Now static.
5125         (ada_read_var_value): Update and simplify.
5126         * ada-exp.y (write_var_or_type): Remove old code.
5127
5128 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5129
5130         * event-top.c: Remove include comment.
5131         * inflow.c (class scoped_ignore_sigttou): Move from here...
5132         * inflow.h (class scoped_ignore_sigttou): ...to here.
5133         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5134         * top.c:  Remove include comment.
5135
5136 2019-05-27  Tom Tromey  <tom@tromey.com>
5137
5138         * NEWS: Fix typo.
5139
5140 2019-05-22  Tom Tromey  <tromey@adacore.com>
5141
5142         * target.c (target_follow_exec): Constify parameter.
5143         * target-delegates.c: Rebuild.
5144         * remote.c (remote_target::follow_exec): Constify parameter.
5145         * infrun.c (follow_exec): Constify parameter.
5146         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5147         (target_follow_exec): Likewise.
5148
5149 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5150
5151         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5152         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5153
5154 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5155
5156         * NEWS: Add debugredirect and testsuite sections.
5157
5158 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5159
5160         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5161         target descriptions using exclusively floating point register name
5162         aliases.
5163
5164 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         PR gdb/18644:
5167         * f-lang.c (build_fortran_types): Handle the case where
5168         gdbarch_floatformat_for_type returns a nullptr.
5169
5170 2019-05-21  Tom de Vries  <tdevries@suse.de>
5171
5172         PR cli/24587
5173         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5174
5175 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5176
5177         PR gdb/18644:
5178         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5179         16-byte floats.
5180         * i386-tdep.c (i386_floatformat_for_type): Use
5181         floatformats_ia64_quad for the 16-byte floating point component
5182         within a fortran 32-byte complex number.
5183
5184 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5185
5186         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5187         delete default constructor.
5188         (find_partial_die): Update to return const struct.
5189         (partial_die_parent_scope): Move variable declaration into scope
5190         of its use and change its type to auto.
5191         (guess_partial_die_structure_name): Likewise.
5192         (partial_die_info::fixup): Likewise.
5193
5194 2019-05-17  Tom Tromey  <tromey@adacore.com>
5195
5196         * source.c (find_and_open_source): Remove cast.
5197
5198 2019-05-17  Tom Tromey  <tromey@adacore.com>
5199
5200         * annotate.c (annotate_source): Make "filename" const.
5201         * annotate.h (annotate_source): Use const.
5202
5203 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5204
5205         * disasm.c (set_disassembler_options): Send errors to stderr.
5206
5207 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5208
5209         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5210         (cli_interp_base::set_logging): Check debug_redirect.
5211         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5212         * cli/cli-logging.c (debug_redirect): Add static variable.
5213         (pop_output_files): Add default param.
5214         (handle_redirections): Print debug setting.
5215         (show_logging_command): Likewise.
5216         (_initialize_cli_logging): Add debugredirect command.
5217         * interps.c (current_interp_set_logging): Add debug_redirect
5218         parameter.
5219         * interps.h (set_logging): Add debug_redirect parameter.
5220         (current_interp_set_logging): Likewise.
5221         * mi/mi-common.h: Likewise.
5222         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5223
5224 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5225             Tom Tromey  <tromey@adacore.com>
5226
5227         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5228         directly.
5229         * cli/cli-interp.h (make_logging_output): Remove declaration.
5230         * cli/cli-logging.c (make_logging_output): Remove function.
5231         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5232         directly.
5233         * ui-file.c (tee_file::tee_file): Remove bools.
5234         (tee_file::~tee_file): Remove deletes.
5235         * ui-file.h (tee_file): Remove bools.
5236
5237 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5238
5239         * mi/mi-cmds.h (mi_cmd_complete): New function.
5240         * mi/mi-main.c (mi_cmd_complete): Likewise.
5241         * mi/mi-cmds.c: Define new MI command -complete.
5242         * NEWS: Mention new -complete command.
5243
5244 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5245
5246         * completer.h (complete): New function.
5247         * completer.c (complete): Likewise.
5248         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5249         function defined in completer.h.
5250
5251 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5252
5253         * MAINTAINERS (Write After Approval): Add myself.
5254
5255 2019-05-17  Tom de Vries  <tdevries@suse.de>
5256
5257         PR gdb/24094
5258         * dwarf2read.c (struct cu_partial_die_info): New struct.
5259         (find_partial_die): Return cu_partial_die_info.
5260         (partial_die_parent_scope, guess_partial_die_structure_name)
5261         (partial_die_info::fixup): Handle new return type of find_partial_die.
5262
5263 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5264
5265         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5266         "std::string", simplifying the algorithm.
5267
5268 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5269
5270         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5271         (stap_static_probe_ops::get_probes): Likewise.
5272
5273 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5274
5275         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5276         '-')" and "else if".
5277         (stap_parse_single_operand): Join checks for
5278         "gdbarch_stap_parse_special_token_p" and
5279         "gdbarch_stap_parse_special_token" in the same "if" statement.
5280         Invert check when verifying for operation on register
5281         displacement.
5282
5283 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5284
5285         * stap-probe.c (stap_get_opcode): Update comment.
5286         (stap_get_expected_argument_type): Likewise.
5287         (handle_stap_probe): Likewise.
5288
5289 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5290
5291         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5292         return type to 'bool'.  Adjust comment.  Use 'bool' when
5293         appropriate.
5294         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5295         * stap-probe.c (stap_parse_argument_1): Likewise.
5296         (stap_is_operator): Likewise.
5297         (stap_is_generic_prefix): Likewise.
5298         (stap_is_register_prefix): Likewise.
5299         (stap_is_register_indirection_prefix): Likewise.
5300         (stap_is_integer_prefix): Likewise.
5301         (stap_generic_check_suffix): Likewise.
5302         (stap_check_integer_suffix): Likewise.
5303         (stap_check_register_suffix): Likewise.
5304         (stap_check_register_indirection_suffix): Likewise.
5305         (stap_parse_register_operand): Likewise.
5306         (stap_parse_single_operand): Likewise.
5307         (stap_parse_argument_1): Likewise.
5308         (stap_probe::get_argument_count): Likewise.
5309         (stap_is_operator): Likewise.
5310
5311 2019-05-16  Tom Tromey  <tromey@adacore.com>
5312
5313         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5314         keyword to foreach.
5315
5316 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5317
5318         * linux-thread-db.c (try_thread_db_load_1): Change return type
5319         to bool.
5320         (try_thread_db_load): Likewise.
5321         (try_thread_db_load_from_pdir_1): Likewise.
5322         (try_thread_db_load_from_pdir): Likewise.
5323         (try_thread_db_load_from_sdir): Likewise.
5324         (try_thread_db_load_from_dir): Likewise.
5325         (thread_db_load_search): Likewise.
5326         (has_libpthread): Likewise.
5327         (thread_db_load): Likewise.
5328
5329 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5330
5331         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5332         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5333         NULL, and complain/return if that's the case.
5334
5335 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5336
5337         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5338         (advance, posn, abstract_read_memory): New functions.
5339         [struct mem_read_abstraction]: New struct.
5340         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5341
5342 2019-05-14  Tom Tromey  <tromey@adacore.com>
5343
5344         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5345         value is not lval_memory.
5346
5347 2019-05-14  Tom Tromey  <tromey@adacore.com>
5348
5349         * solib.c (info_sharedlibrary_command): Style the file name.
5350
5351 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5352
5353         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5354         (aarch64_vnv_type): Likewise.
5355         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5356         * common/tdesc.c: Likewise.
5357         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5358         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5359         * features/aarch64-fpu.xml: Add ieee half view.
5360         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5361         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5362         * gdbtypes.h (struct builtin_type): Likewise.
5363         (struct objfile_type): Likewise.
5364
5365 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5366
5367         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5368         typo.
5369         * location.h (string_to_event_location): Likewise.
5370
5371 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5372
5373         GDB 8.3 released.
5374
5375 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5376
5377         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5378         New variable declaration.
5379         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5380         New variable.
5381         (print_one_breakpoint): Use ui_out::test_flags and new global
5382         variable to compute use_fixed_output.
5383         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5384         Remove.
5385         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5386         (mi_multi_location_breakpoint_output_fixed): Remove.
5387         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5388         new variable.
5389         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5390         fix_multi_location_breakpoint_output flag if version >= 3.
5391         * ui-out.h (enum ui_out_flag)
5392         <fix_multi_location_breakpoint_output>: New enumerator.
5393
5394 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5395
5396         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5397
5398 2019-05-10  Tom Tromey  <tromey@adacore.com>
5399
5400         * ada-lang.c (catch_ada_completer): New function.
5401         (_initialize_ada_language): Use it.
5402
5403 2019-05-10  Tom Tromey  <tromey@adacore.com>
5404
5405         * thread.c (print_thread_info): Make "requested_threads" const.
5406         * gdbthread.h (print_thread_info): Make "requested_threads"
5407         const.
5408         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5409         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5410
5411 2019-05-08  Tom Tromey  <tom@tromey.com>
5412
5413         * gdbtypes.c (objfile_type_data): Change type.
5414         (objfile_type, _initialize_gdbtypes): Update.
5415
5416 2019-05-08  Tom Tromey  <tom@tromey.com>
5417
5418         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5419         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5420         (_initialize_dwarf2_frame): Update.
5421
5422 2019-05-08  Tom Tromey  <tom@tromey.com>
5423
5424         * objc-lang.c (objc_objfile_data): Change type.
5425         (find_methods): Update.
5426         (_initialize_objc_lang): Remove.
5427
5428 2019-05-08  Tom Tromey  <tom@tromey.com>
5429
5430         * stabsread.c (rs6000_builtin_type_data): Change type.
5431         (rs6000_builtin_type, _initialize_stabsread): Update.
5432
5433 2019-05-08  Tom Tromey  <tom@tromey.com>
5434
5435         * mips-tdep.c (mips_pdr_data): Remove.
5436         (_initialize_mips_tdep): Update.
5437
5438 2019-05-08  Tom Tromey  <tom@tromey.com>
5439
5440         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5441         (hppa_init_objfile_priv_data, read_unwind_info)
5442         (find_unwind_entry, _initialize_hppa_tdep): Update.
5443
5444 2019-05-08  Tom Tromey  <tom@tromey.com>
5445
5446         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5447         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5448         on obstack.
5449         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5450
5451 2019-05-08  Tom Tromey  <tom@tromey.com>
5452
5453         * mdebugread.c (basic_type_data): Change type.
5454         (basic_type, _initialize_mdebugread): Update.
5455
5456 2019-05-08  Tom Tromey  <tom@tromey.com>
5457
5458         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5459
5460 2019-05-08  Tom Tromey  <tom@tromey.com>
5461
5462         * nto-tdep.c (nto_inferior_data_reg): Change type.
5463         (nto_inferior_data): Update.
5464         (nto_inferior_data_cleanup, nto_new_inferior_data)
5465         (_initialize_nto_tdep): Remove.
5466         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5467
5468 2019-05-08  Tom Tromey  <tom@tromey.com>
5469
5470         * ada-lang.c (struct ada_inferior_data): Add initializers.
5471         (ada_inferior_data): Change type.
5472         (ada_inferior_data_cleanup): Remove.
5473         (get_ada_inferior_data, ada_inferior_exit)
5474         (struct ada_pspace_data): Add initializers, destructor.
5475         (ada_pspace_data_handle): Change type.
5476         (get_ada_pspace_data): Update.
5477         (ada_pspace_data_cleanup): Remove.
5478
5479 2019-05-08  Tom Tromey  <tom@tromey.com>
5480
5481         * coffread.c (struct coff_symfile_info): Add initializers.
5482         (coff_objfile_data_key): Move lower.  Change type.
5483         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5484         Update.
5485         (coff_free_info): Remove.
5486
5487 2019-05-08  Tom Tromey  <tom@tromey.com>
5488
5489         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5490         (fbsd_pspace_data_handle): Move lower.  Change type.
5491         (get_fbsd_pspace_data): Update.
5492         (fbsd_pspace_data_cleanup): Remove.
5493         (_initialize_fbsd_tdep): Update.
5494
5495 2019-05-08  Tom Tromey  <tom@tromey.com>
5496
5497         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5498         (get_ada_tasks_pspace_data): Update.
5499         (ada_tasks_pspace_data_cleanup): Remove.
5500         (_initialize_tasks): Update.
5501         (ada_tasks_inferior_data_handle): Change type.
5502         (get_ada_tasks_inferior_data): Update.
5503         (ada_tasks_inferior_data_cleanup): Remove.
5504         (struct ada_tasks_pspace_data): Add initializers.
5505
5506 2019-05-08  Tom Tromey  <tom@tromey.com>
5507
5508         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5509         * symfile-debug.c (debug_sym_get_probes): Change type.
5510         * stap-probe.c (handle_stap_probe):
5511         (stap_static_probe_ops::get_probes): Change type.
5512         * probe.h (class static_probe_ops) <get_probes>: Change type.
5513         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5514         (parse_probes_in_pspace): Update.
5515         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5516         Update.
5517         (any_static_probe_ops::get_probes): Change type.
5518         * elfread.c (elfread_data): New typedef.
5519         (probe_key): Change type.
5520         (elf_get_probes): Likewise.  Update.
5521         (probe_key_free): Remove.
5522         (_initialize_elfread): Update.
5523         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5524         Change type.
5525         (dtrace_process_dof_probe, dtrace_process_dof)
5526         (dtrace_static_probe_ops::get_probe): Change type.
5527
5528 2019-05-08  Tom Tromey  <tom@tromey.com>
5529
5530         * xcoffread.c (struct xcoff_symfile_info): Rename from
5531         coff_symfile_info.  Add initializers.
5532         (xcoff_objfile_data_key): Move lower.  Change type.
5533         (XCOFF_DATA): Rewrite.
5534         (xcoff_free_info): Remove.
5535         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5536         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5537         (xcoff_initial_scan): Update.
5538
5539 2019-05-08  Tom Tromey  <tom@tromey.com>
5540
5541         * solib-svr4.c (struct svr4_info): Add initializers and
5542         destructor.
5543         <probes_table>: Now an htab_up.
5544         (solib_svr4_pspace_data): Change type.
5545         (free_probes_table): Simplify.
5546         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5547         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5548         (probes_table_remove_objfile_probes, register_solib_event_probe)
5549         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5550         (_initialize_svr4_solib): Update.
5551
5552 2019-05-08  Tom Tromey  <tom@tromey.com>
5553
5554         * remote.c (remote_pspace_data): Change type.
5555         (remote_pspace_data_cleanup): Remove.
5556         (get_remote_exec_file, set_pspace_remote_exec_file)
5557         (_initialize_remote): Update.
5558
5559 2019-05-08  Tom Tromey  <tom@tromey.com>
5560
5561         * breakpoint.c (breakpoint_objfile_key): Change type.
5562         (get_breakpoint_objfile_data): Update.
5563         (free_breakpoint_objfile_data): Remove.
5564         (_initialize_breakpoint): Update.
5565
5566 2019-05-08  Tom Tromey  <tom@tromey.com>
5567
5568         * linux-tdep.c (struct linux_info): Add initializers.
5569         (linux_inferior_data): Move.  Change type.
5570         (invalidate_linux_cache_inf): Update.
5571         (linux_inferior_data_cleanup): Remove.
5572         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5573
5574 2019-05-08  Tom Tromey  <tom@tromey.com>
5575
5576         * auxv.c (auxv_inferior_data): Move.  Change type.
5577         (auxv_inferior_data_cleanup): Remove.
5578         (invalidate_auxv_cache_inf): Rewrite.
5579         (get_auxv_inferior_data, _initialize_auxv): Update.
5580
5581 2019-05-08  Tom Tromey  <tom@tromey.com>
5582
5583         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5584         (symfile_debug_objfile_data_key): Change type.
5585         (symfile_debug_installed, debug_qf_has_symbols)
5586         (debug_qf_find_last_source_symtab)
5587         (debug_qf_forget_cached_source_info)
5588         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5589         (debug_qf_print_stats, debug_qf_dump)
5590         (debug_qf_expand_symtabs_for_function)
5591         (debug_qf_expand_all_symtabs)
5592         (debug_qf_expand_symtabs_with_fullname)
5593         (debug_qf_map_matching_symbols)
5594         (debug_qf_expand_symtabs_matching)
5595         (debug_qf_find_pc_sect_compunit_symtab)
5596         (debug_qf_map_symbol_filenames)
5597         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5598         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5599         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5600         (debug_sym_read_linetable, debug_sym_relocate): Update.
5601         (symfile_debug_free_objfile): Remove.
5602         (install_symfile_debug_logging, _initialize_symfile_debug):
5603         Update.
5604
5605 2019-05-08  Tom Tromey  <tom@tromey.com>
5606
5607         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5608         allocate_on_obstack.
5609         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5610         (get_dwarf2_per_objfile): Update.
5611         (set_dwarf2_per_objfile): Remove.
5612         (dwarf2_has_info, dwarf2_get_section_info): Update.
5613         (dwarf2_free_objfile): Remove.
5614         (_initialize_dwarf2_read): Update.
5615
5616 2019-05-08  Tom Tromey  <tom@tromey.com>
5617
5618         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5619         initializers.
5620         <unsupported_script_warning_printed,
5621         script_not_found_warning_printed>: Now bool.
5622         (auto_load_pspace_data): Change type.
5623         (~auto_load_pspace_info): Rename from
5624         auto_load_pspace_data_cleanup.
5625         (get_auto_load_pspace_data, init_loaded_scripts_info)
5626         (clear_section_scripts, maybe_print_unsupported_script_warning)
5627         (maybe_print_script_not_found_warning, _initialize_auto_load):
5628         Update.
5629
5630 2019-05-08  Tom Tromey  <tom@tromey.com>
5631
5632         * objfiles.c (objfile_pspace_info): Add destructor and
5633         initializers.
5634         (objfiles_pspace_data): Change type.
5635         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5636         (get_objfile_pspace_data): Update.
5637         (objfiles_bfd_data): Change type.
5638         (get_objfile_bfd_data): Update.
5639         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5640
5641 2019-05-08  Tom Tromey  <tom@tromey.com>
5642
5643         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5644         Change type.
5645         (get_catch_syscall_inferior_data): Update.
5646         (catch_syscall_inferior_data_cleanup): Remove.
5647         (_initialize_break_catch_syscall): Update.
5648
5649 2019-05-08  Tom Tromey  <tom@tromey.com>
5650
5651         * inflow.c (struct terminal_info): Add destructor and
5652         initializers.
5653         (inflow_inferior_data): Change type.
5654         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5655         (get_inflow_inferior_data, inflow_inferior_exit)
5656         (swap_terminal_info, _initialize_inflow): Update.
5657
5658 2019-05-08  Tom Tromey  <tom@tromey.com>
5659
5660         * target-dcache.c (target_dcache_cleanup): Remove.
5661         (target_dcache_aspace_key): Change type.
5662         (target_dcache_init_p, target_dcache_invalidate)
5663         (target_dcache_get, target_dcache_get_or_init)
5664         (_initialize_target_dcache): Update.
5665         * dcache.h (struct dcache_deleter): New.
5666
5667 2019-05-08  Tom Tromey  <tom@tromey.com>
5668
5669         * symtab.c (struct symbol_cache): Add destructor and
5670         initializers.
5671         (symbol_cache_key): Move.  Change type.
5672         (make_symbol_cache, free_symbol_cache): Remove.
5673         (get_symbol_cache): Update.
5674         (symbol_cache_cleanup): Remove.
5675         (ALL_PSPACES, symbol_cache_flush)
5676         (maintenance_print_symbol_cache)
5677         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5678         Update.
5679
5680 2019-05-08  Tom Tromey  <tom@tromey.com>
5681
5682         * symtab.c (struct main_info): Add destructor and initializers.
5683         (main_progspace_key): Move.  Change type.
5684         (get_main_info): Update.
5685         (main_info_cleanup): Remove.
5686         (_initialize_symtab): Update.
5687
5688 2019-05-08  Tom Tromey  <tom@tromey.com>
5689
5690         * registry.h (DECLARE_REGISTRY): Define the _key class.
5691
5692 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5693
5694         * NEWS: Merge two 'New commands' sections.
5695
5696 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5697
5698         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5699         parameter and use Ada language definition instead.
5700         (ada_val_print_ptr): Remove unused language parameter.
5701         (ada_val_print_num): Remove language parameter and use Ada language
5702         definition instead.
5703         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5704         parameter.
5705         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5706         parameter and use Ada language definition instead.
5707         (ada_val_print_1): Update all ada_val_print_xxx calls.
5708         Remove language parameter.
5709         (ada_val_print): Update ada_val_print_1 call.
5710
5711 2019-05-08  Tom Tromey  <tromey@adacore.com>
5712
5713         * remote.c (remote_hw_watchpoint_limit)
5714         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5715         Now static.
5716
5717 2019-05-08  Tom Tromey  <tromey@adacore.com>
5718
5719         * maint.c (_initialize_maint_cmds): Move initialization code to
5720         remote.c.
5721         (watchdog, show_watchdog): Move to remote.c.
5722         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5723         "watchdog" static.
5724         (_initialize_remote): Move initialization code from maint.c.
5725         * defs.h (watchdog): Don't declare.
5726
5727 2019-05-08  Tom Tromey  <tromey@adacore.com>
5728
5729         * tui/tui-interp.c: Include main.h.
5730         * interps.c: Include main.h.
5731         * main.h (interpreter_p): Declare.
5732         * defs.h (interpreter_p): Don't declare.
5733
5734 2019-05-08  Tom Tromey  <tromey@adacore.com>
5735
5736         * dwarf2loc.c: Include dwarf2read.h.
5737         * defs.h (read_unsigned_leb128): Don't declare.
5738         * dwarf2read.h (read_unsigned_leb128): Declare.
5739
5740 2019-05-08  Tom Tromey  <tromey@adacore.com>
5741
5742         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5743         method.
5744
5745 2019-05-08  Tom Tromey  <tromey@adacore.com>
5746
5747         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5748         when no wrap column is set.
5749
5750 2019-05-08  Tom Tromey  <tromey@adacore.com>
5751
5752         * c-lang.c (c_get_string): Handle non-C-style arrays.
5753
5754 2019-05-08  Tom Tromey  <tromey@adacore.com>
5755
5756         * typeprint.c (print_offset_data::update): Print the bit offset,
5757         not the number of bits remaining.
5758
5759 2019-05-08  Tom Tromey  <tromey@adacore.com>
5760
5761         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5762         padding at end of comment.
5763
5764 2019-05-08  Tom Tromey  <tromey@adacore.com>
5765
5766         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5767         Compare main types.
5768
5769 2019-05-06  Tom Tromey  <tom@tromey.com>
5770
5771         * common/scoped_mmap.c: Include common-defs.h.
5772         * common/scoped_mmap.h: Don't include config.h.
5773
5774 2019-05-04  Tom Tromey  <tom@tromey.com>
5775
5776         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5777         (struct aarch64_call_info): Add initializers.
5778         <si>: Now a std::vector.
5779         (pass_on_stack, aarch64_push_dummy_call): Update.
5780
5781 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5782             Tom Tromey  <tom@tromey.com>
5783
5784         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5785         (ppc_threads): Now a std::vector.  Now static.
5786         (hwdebug_find_thread_points_by_tid)
5787         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5788         Update.
5789
5790 2019-05-04  Tom Tromey  <tom@tromey.com>
5791
5792         * arc-tdep.c (arc_tdesc_init): Return bool.
5793
5794 2019-05-04  Tom Tromey  <tom@tromey.com>
5795
5796         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5797         Use gdb_assert_not_reached.
5798
5799 2019-05-04  Tom Tromey  <tom@tromey.com>
5800
5801         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5802         "false".
5803
5804 2019-05-04  Tom Tromey  <tom@tromey.com>
5805
5806         * arc-tdep.c (arc_tdesc_init): Use bool.
5807
5808 2019-05-04  Tom Tromey  <tom@tromey.com>
5809
5810         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5811
5812 2019-05-04  Tom Tromey  <tom@tromey.com>
5813
5814         * cli/cli-cmds.c (valid_command_p): Return bool.
5815
5816 2019-05-04  Tom Tromey  <tom@tromey.com>
5817
5818         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5819         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5820
5821 2019-05-04  Raul Tambre  <raul@tambre.ee>
5822
5823         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5824         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5825         operator for comparison.
5826
5827 2019-05-04  Tom Tromey  <tom@tromey.com>
5828
5829         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5830         (lookup_partial_symbol, print_partial_symbols)
5831         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5832         (psymbol_compare): Update.
5833         (add_psymbol_to_bcache): Clear the entire psymbol.
5834         (maintenance_check_psymtabs): Update.
5835         * psympriv.h (struct partial_symbol): Don't derive from
5836         general_symbol_info.
5837         <obj_section, unrelocated_address, address,
5838         set_unrelocated_address>: Update.
5839         <ginfo>: New member.
5840         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5841         (debug_names::write_psymbols): Update.
5842
5843 2019-05-04  Tom de Vries  <tdevries@suse.de>
5844
5845         * contrib/cc-with-tweaks.sh: Support -n arg.
5846
5847 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5848
5849         * corelow.c (core_target::detach): Ensure frame cache and
5850         register caches are cleared.
5851         inferior.c (exit_inferior_1): Likewise.
5852
5853 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5854             Tom Tromey  <tom@tromey.com>
5855
5856         * dictionary.c (collate_pending_symbols_by_language): Remove
5857         "struct" from foreach.
5858         * symtab.c (lookup_global_symbol_from_objfile)
5859         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5860         foreach.
5861         * ser-tcp.c (net_open): Remove "struct" from foreach.
5862         * objfiles.c (objfile_relocate, objfile_rebase)
5863         (objfile_has_symbols): Remove "struct" from foreach.
5864         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5865         from foreach.
5866         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5867         foreach.
5868         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5869         "struct" from foreach.
5870         * ada-lang.c (create_excep_cond_exprs)
5871         (ada_exception_catchpoint_cond_string): Remove "struct" from
5872         foreach.
5873
5874 2019-05-03  Tom Tromey  <tromey@adacore.com>
5875
5876         * ada-exp.y (convert_char_literal): Check suffix of each
5877         enumerator.
5878
5879 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5880
5881         PR ada/21406:
5882         * ada-exp.y (yywrap): Don't define.
5883         * ada-lex.l (%option): Add noyywrap
5884         (yywrap): Remove.
5885
5886 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5887
5888         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5889         _WIN32_WINNT to the XP level, unless already defined to a higher
5890         level.
5891
5892         * unittests/parse-connection-spec-selftests.c:
5893         * ser-tcp.c:
5894         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5895         override.
5896
5897         * symfile.c (find_separate_debug_file): Remove colon from the
5898         drive spec of DOS/Windows file names of the target, so that the
5899         file name produced from DEBUGDIR and the target's directory will
5900         be valid on DOS/Windows systems.
5901
5902 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5903
5904         * rust-lang.c (val_print_struct): Handle printing structures
5905         containing strings.
5906
5907 2019-05-02  Tom Tromey  <tromey@adacore.com>
5908
5909         * valarith.c (_initialize_valarith): Remove.
5910
5911 2019-05-01  Tom Tromey  <tromey@adacore.com>
5912
5913         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5914         bitfields.
5915
5916 2019-05-01  Tom Tromey  <tromey@adacore.com>
5917
5918         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5919         for big-endian copies.
5920
5921 2019-04-30  Ali Tamur  <tamur@google.com>
5922         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5923         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5924         (read_3_bytes): New function.
5925
5926 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5927
5928         * windows-nat.c (main_thread_id): Delete.
5929         (handle_output_debug_string): Replace main_thread_id by
5930         current_event.dwThreadId.
5931         (fake_create_process): Likewise.
5932         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5933         Do not set main_thread_id.
5934         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5935         current_event.dwThreadId.
5936         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5937
5938 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5939
5940         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5941         Use current_event.dwThreadId instead of main_thread_id.
5942
5943 2019-04-30  Tom Tromey  <tromey@adacore.com>
5944
5945         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5946         (create_excep_cond_exprs): Iterate over program spaces.
5947         (ada_exception_catchpoint_cond_string): Examine all minimal
5948         symbols for exception types.
5949
5950 2019-04-30  Tom Tromey  <tromey@adacore.com>
5951
5952         PR c++/24470:
5953         * dwarf2read.c (process_structure_scope): Handle case where type
5954         has template parameters but no symbol was created.
5955
5956 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5957             Chris January  <chris.january@arm.com>
5958
5959         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5960         qualifier.
5961         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5962
5963 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5964
5965         * f-typeprint.c (f_print_type): Update rules for printing
5966         whitespace.
5967         (f_type_print_varspec_suffix): Likewise.
5968
5969 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5970             Chris January  <chris.january@arm.com>
5971
5972         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5973         function arguments.
5974
5975 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5976
5977         * f-lang.c (build_fortran_types): Change name of void type to
5978         lower case.
5979         * f-typeprint.c (f_type_print_base): Print the name of the void
5980         type, rather than a fixed string.
5981         * f-valprint.c (f_decorations): Use lower case void string.
5982
5983 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5984             Chris January  <chris.january@arm.com>
5985
5986         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5987         types for Fortran.
5988
5989 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5990             Chris January  <chris.january@arm.com>
5991             David Lecomber  <david.lecomber@arm.com>
5992
5993         * f-exp.y (BINOP_INTRINSIC): New token.
5994         (exp): New parser rule handling BINOP_INTRINSIC.
5995         (f77_keywords): Add new builtin procedures.
5996         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5997         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5998         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5999         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6000         (print_unop_subexp_f): New function.
6001         (print_binop_subexp_f): New function.
6002         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6003         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6004         (dump_subexp_body_f): Likewise.
6005         (operator_check_f): Likewise.
6006         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6007         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6008
6009 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6010
6011         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6012         UNOP_KIND.
6013         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6014         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6015         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6016         (operator_length_f): New fuction.
6017         (print_subexp_f): New function.
6018         (op_name_f): New function.
6019         (dump_subexp_body_f): New function.
6020         (operator_check_f): New function.
6021         (exp_descriptor_f): Replace standard expression handling functions
6022         with new functions.
6023         * gdb/fortran-operator.def: New file.
6024         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6025         * gdb/std-operator.def: Remove UNOP_KIND.
6026
6027 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6028
6029         * std-operator.def: Remove unbalanced, stray double quote
6030         character.
6031
6032 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6033             Chris January  <chris.january@arm.com>
6034             Daniel Everett  <daniel.everett@arm.com>
6035             Nick Forrington  <nick.forrington@arm.com>
6036             Richard Bunt  <richard.bunt@arm.com>
6037
6038         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6039         of depth when printing anonymous structs or unions.
6040         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6041         Don't print either the top-level value, or the children if the
6042         max-depth is exceeded.
6043         (ppscm_print_children): When printing the key of a map, allow one
6044         extra level of depth.
6045         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6046         print either the top-level value, or the children if the max-depth
6047         is exceeded.
6048         (print_children): When printing the key of a map, allow one extra
6049         level of depth.
6050         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6051         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6052         (user_print_options): Initialise max_depth field.
6053         (val_print_scalar_or_string_type_p): New function.
6054         (val_print): Check to see if the max depth has been reached.
6055         (val_print_check_max_depth): Define new function.
6056         (show_print_max_depth): New function.
6057         (_initialize_valprint): Add 'print max-depth' option.
6058         * valprint.h (struct value_print_options) <max_depth>: New field.
6059         (val_print_check_max_depth): Declare new function.
6060         * NEWS: Document new feature.
6061
6062 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6063
6064         * ada-lang.c (ada_language_defn): Initialise new field.
6065         * c-lang.c (c_is_string_type_p): New function.
6066         (c_language_defn): Initialise new field.
6067         (cplus_language_defn): Initialise new field.
6068         (asm_language_defn): Initialise new field.
6069         (minimal_language_defn): Initialise new field.
6070         * c-lang.h (c_is_string_type_p): Declare new function.
6071         * d-lang.c (d_language_defn): Initialise new field.
6072         * f-lang.c (f_is_string_type_p): New function.
6073         (f_language_defn): Initialise new field.
6074         * go-lang.c (go_is_string_type_p): New function.
6075         (go_language_defn): Initialise new field.
6076         * language.c (default_is_string_type_p): New function.
6077         (unknown_language_defn): Initialise new field.
6078         (auto_language_defn): Initialise new field.
6079         * language.h (struct language_defn) <la_is_string_type_p>: New
6080         member variable.
6081         (default_is_string_type_p): Declare new function.
6082         * m2-lang.c (m2_language_defn): Initialise new field.
6083         * objc-lang.c (objc_language_defn): Initialise new field.
6084         * opencl-lang.c (opencl_language_defn): Initialise new field.
6085         * p-lang.c (pascal_is_string_type_p): New function.
6086         (pascal_language_defn): Initialise new field.
6087         * rust-lang.c (rust_is_string_type_p): New function.
6088         (rust_language_defn): Initialise new field.
6089
6090 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6093         New field.
6094         * ada-lang.c (ada_language_defn): Initialise new field.
6095         * c-lang.c (c_language_defn): Likewise.
6096         (cplus_language_defn): Likewise.
6097         (asm_language_defn): Likewise.
6098         (minimal_language_defn): Likewise.
6099         * d-lang.c (d_language_defn): Likewise.
6100         * f-lang.c (f_language_defn): Likewise.
6101         * go-lang.c (go_language_defn): Likewise.
6102         * language.c (unknown_language_defn): Likewise.
6103         (auto_language_defn): Likewise.
6104         * m2-lang.c (m2_language_defn): Likewise.
6105         * objc-lang.c (objc_language_defn): Likewise.
6106         * opencl-lang.c (opencl_language_defn): Likewise.
6107         * p-lang.c (pascal_language_defn): Likewise.
6108         * rust-lang.c (rust_language_defn): Likewise.
6109
6110 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6111
6112         * ada-lang.c (ada_is_character_type): Change return type to bool.
6113         (ada_is_string_type): Likewise.
6114         * ada-lang.h (ada_is_character_type): Update declaration
6115         (ada_is_string_type): Likewise.
6116
6117 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6118
6119         Support style in 'frame|thread apply'
6120
6121         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6122         * record.c (record_start, record_stop): Update callers of
6123         execute_command_to_string with false.
6124         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6125         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6126         methods.
6127         (class string_file): New constructor with term_out parameter.
6128         Override methods term_out and can_emit_style_escape.  New member
6129         term_out.
6130         (class stdio_file): Override can_emit_style_escape.
6131         (class tee_file): Override term_out and can_emit_style_escape.
6132         * utils.h (can_emit_style_escape): Remove.
6133         * utils.c (can_emit_style_escape): Likewise.
6134         Update all callers of can_emit_style_escape (SOMESTREAM) to
6135         SOMESTREAM->can_emit_style_escape.
6136         * source-cache.c (source_cache::get_source_lines): Likewise.
6137         * stack.c (frame_apply_command_count): Call execute_command_to_string
6138         passing the term_out characteristic of the current gdb_stdout.
6139         * thread.c (thr_try_catch_cmd): Likewise.
6140         * top.c (execute_command_to_string): pass term_out parameter
6141         to construct the string_file for the command output.
6142         * ui-file.c (term_cli_styling): New function (most code moved
6143         from utils.c can_emit_style_escape).
6144         (string_file::string_file, string_file::can_emit_style_escape,
6145         stdio_file::can_emit_style_escape, tee_file::term_out,
6146         tee_file::can_emit_style_escape): New functions.
6147
6148 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6149
6150         * NEWS: Mention the new set|show may-call-functions.
6151         * infcall.c (may_call_functions_p): New variable.
6152         (show_may_call_functions_p): New function.
6153         (call_function_by_hand_dummy): Throws an error if not
6154         may-call-functions.
6155         (_initialize_infcall): Call add_setshow_boolean_cmd for
6156         may-call-functions.
6157
6158 2019-04-25  Keith Seitz  <keiths@redhat.com>
6159
6160         PR c++/24367
6161         * cp-support.c (inspect_type): Don't attempt substitutions
6162         of symbol with the same name.
6163
6164 2019-04-25  Tom Tromey  <tromey@adacore.com>
6165
6166         PR gdb/24475:
6167         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6168         static.
6169
6170 2019-04-25  Tom Tromey  <tromey@adacore.com>
6171
6172         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6173         rvalue reference.
6174         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6175         (gdb_xml_parser::parse): Use std::move.
6176         * python/python-internal.h (gdbpy_convert_exception): Take a const
6177         reference.
6178         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6179         std::move.
6180         * python/py-utils.c (gdbpy_convert_exception): Take a const
6181         reference.
6182         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6183         Use std::move.
6184         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6185         Use std::move.
6186         * mi/mi-main.c (mi_print_exception): Take a const reference.
6187         * main.c (handle_command_errors): Take a const reference.
6188         * linespec.c (parse_linespec): Use std::move.
6189         * infcall.c (run_inferior_call): Use std::move.
6190         (call_function_by_hand_dummy): Use std::move.
6191         * exec.c (try_open_exec_file): Use std::move.
6192         * exceptions.h (exception_print, exception_fprintf)
6193         (exception_print_same): Update.
6194         * exceptions.c (print_exception, exception_print)
6195         (exception_fprintf, exception_print_same): Change parameters to
6196         const reference.
6197         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6198         * common/new-op.c: Use std::move.
6199         * common/common-exceptions.h (struct gdb_exception): Add move
6200         constructor.
6201         (struct gdb_exception_error, struct gdb_exception_quit, struct
6202         gdb_quit_bad_alloc): Change constructor to move constructor.
6203         (throw_exception): Change parameter to rvalue reference.
6204         * common/common-exceptions.c (throw_exception): Take rvalue
6205         reference.
6206         * cli/cli-interp.c (safe_execute_command): Use std::move.
6207         * breakpoint.c (insert_bp_location, location_to_sals): Use
6208         std::move.
6209
6210 2019-04-25  Tom Tromey  <tromey@adacore.com>
6211
6212         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6213         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6214         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6215         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6216         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6217         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6218         guile/scm-value.c: Use unpack.
6219         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6220         gdbscm_gdb_exception.
6221         (gdbscm_throw_gdb_exception): Likewise.
6222         (struct gdbscm_gdb_exception): New.
6223         (unpack): New function.
6224         (gdbscm_wrap): Use unpack.
6225
6226 2019-04-25  Tom Tromey  <tromey@adacore.com>
6227
6228         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6229         (gdb_rl_callback_handler): Use std::move.
6230         * common/common-exceptions.h (struct gdb_exception): Add move
6231         assignment operator.
6232         (throw_exception_sjlj): Change "exception" to const reference.
6233         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6234         (throw_exception_sjlj): Change "exception" to const reference.
6235
6236 2019-04-25  Tom Tromey  <tromey@adacore.com>
6237
6238         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6239         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6240         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6241         Update.
6242         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6243         Update.
6244         * mi/mi-interp.c (mi_interp::exec): Update.
6245         * linespec.c (parse_linespec): Update.
6246         * infcall.c (run_inferior_call): Update.
6247         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6248         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6249         (gdbscm_lookup_global_symbol): Update.
6250         * guile/scm-param.c (gdbscm_parameter_value): Update.
6251         * guile/scm-frame.c (gdbscm_frame_read_register)
6252         (gdbscm_frame_read_var): Update.
6253         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6254         * exec.c (try_open_exec_file): Update.
6255         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6256         (gdb_rl_callback_handler): Update.
6257         * common/common-exceptions.h (exception_none): Don't declare.
6258         * common/common-exceptions.c (exception_none): Don't define.
6259         (struct catcher) <exception>: Update.
6260         * cli/cli-interp.c (safe_execute_command): Update.
6261         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6262
6263 2019-04-25  Ali Tamur  <tamur@google.com>
6264
6265         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6266         (read_attribute_value): Likewise.
6267         (dwarf2_read_addr_index): Update comment.
6268         (read_str_index): Add DW_FORM_strx.
6269         (dwarf2_string_attr): Likewise.
6270         (dwarf2_const_value_attr): Likewise.
6271         (dump_die_shallow): Likewise.
6272         (dwarf2_fetch_constant_bytes): Likewise.
6273         (skip_form_bytes): Likewise.
6274         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6275
6276 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6277
6278         PR corefiles/11608
6279         PR corefiles/18187
6280         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6281         OFFSET.  Verify if current mapping contains an ELF header.
6282         (linux_find_memory_regions_full): Adjust call to
6283         dump_mapping_p.
6284
6285 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6286             Kang Li <kanglictf@gmail.com>
6287
6288         PR gdb/21600
6289
6290         * dwarf2-frame.c (read_initial_length): Be consistent about using
6291         unsigned representation of length.
6292         (decode_frame_entry_1): Likewise.  Check for wraparound of
6293         end pointer as well as buffer overflow.
6294
6295 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6296
6297         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6298         "vq".
6299
6300 2019-04-24  Tom Tromey  <tromey@adacore.com>
6301
6302         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6303
6304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6305
6306         * s12z-tdep.c (s12z_unwind_pc): Delete.
6307         (s12z_unwind_sp): Delete.
6308         (s12z_gdbarch_init): Don't register deleted functions with
6309         gdbarch.
6310
6311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6312
6313         * rl78-tdep.c (rl78_unwind_sp): Delete.
6314         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6315
6316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6317
6318         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6319         (xstormy16_unwind_pc): Delete.
6320         (xstormy16_dummy_id): Delete.
6321         (xstormy16_gdbarch_init): Don't register deleted functions with
6322         gdbarch.
6323
6324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6325
6326         * vax-tdep.c (vax_unwind_pc): Delete.
6327         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6328
6329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6330
6331         * v850-tdep.c (v850_unwind_sp): Delete.
6332         (v850_unwind_pc): Delete.
6333         (v850_dummy_id): Delete.
6334         (v850_gdbarch_init): Don't register deleted functions with
6335         gdbarch.
6336
6337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6338
6339         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6340         (tilegx_unwind_pc): Delete.
6341         (tilegx_unwind_dummy_id): Delete.
6342         (tilegx_gdbarch_init): Don't register deleted functions with
6343         gdbarch.
6344
6345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6346
6347         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6348         (tic6x_dummy_id): Delete.
6349         (tic6x_gdbarch_init): Don't register deleted functions with
6350         gdbarch.
6351
6352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6353
6354         * sparc-tdep.c (sparc_unwind_pc): Delete.
6355         (sparc32_gdbarch_init): Don't register deleted function with
6356         gdbarch.
6357
6358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6359
6360         * sh-tdep.c (sh_unwind_sp): Delete.
6361         (sh_unwind_pc): Delete.
6362         (sh_dummy_id): Delete.
6363         (sh_gdbarch_init): Don't register deleted functions with
6364         gdbarch.
6365
6366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6367
6368         * score-tdep.c (score_unwind_sp): Delete.
6369         (score_unwind_pc): Delete.
6370         (score_dummy_id): Delete.
6371         (score_gdbarch_init): Don't register deleted functions with
6372         gdbarch.
6373
6374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6375
6376         * rx-tdep.c (rx_unwind_pc): Delete.
6377         (rx_unwind_sp): Delete.
6378         (rx_dummy_id): Delete.
6379         (rx_gdbarch_init): Don't register deleted functions with
6380         gdbarch.  Update comment.
6381
6382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6383
6384         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6385         (rs6000_dummy_id): Delete.
6386         (rs6000_gdbarch_init): Don't register deleted functions with
6387         gdbarch.
6388
6389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6390
6391         * or1k-tdep.c (or1k_dummy_id): Delete.
6392         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6393
6394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6395
6396         * nios2-tdep.c (nios2_dummy_id): Delete.
6397         (nios2_unwind_sp): Delete.
6398         (nios2_gdbarch_init): Don't register deleted functions with
6399         gdbarch.
6400
6401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6402
6403         * nds32-tdep.c (nds32_dummy_id): Delete.
6404         (nds32_unwind_pc): Delete.
6405         (nds32_unwind_sp): Delete.
6406         (nds32_gdbarch_init): Don't register deleted functions with
6407         gdbarch.
6408
6409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6410
6411         * msp430-tdep.c (msp430_unwind_pc): Delete.
6412         (msp430_unwind_sp): Delete.
6413         (msp430_dummy_id): Delete.
6414         (msp430_gdbarch_init): Don't register deleted functions with
6415         gdbarch.
6416
6417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6418
6419         * moxie-tdep.c (moxie_unwind_sp): Delete.
6420         (moxie_unwind_pc): Delete.
6421         (moxie_dummy_id): Delete.
6422         (moxie_gdbarch_init): Don't register deleted functions with
6423         gdbarch.
6424
6425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6426
6427         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6428         (mn10300_unwind_pc): Delete.
6429         (mn10300_unwind_sp): Delete.
6430         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6431         mn10300_unwind_sp.
6432         (mn10300_frame_unwind_init): Don't register deleted functions with
6433         gdbarch.
6434
6435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6436
6437         * mep-tdep.c (mep_unwind_pc): Delete.
6438         (mep_unwind_sp): Delete.
6439         (mep_dummy_id): Delete.
6440         (mep_gdbarch_init): Don't register deleted functions with
6441         gdbarch.
6442
6443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6444
6445         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6446         (m68hc11_unwind_sp): Delete.
6447         (m68hc11_gdbarch_init): Don't register deleted functions with
6448         gdbarch.
6449
6450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6451
6452         * m32r-tdep.c (m32r_unwind_sp): Delete.
6453         (m32r_unwind_pc): Delete.
6454         (m32r_dummy_id): Delete.
6455         (m32r_gdbarch_init): Don't register deleted functions with
6456         gdbarch.
6457
6458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6459
6460         * m32c-tdep.c (m32c_unwind_pc): Delete.
6461         (m32c_unwind_sp): Delete.
6462         (m32c_dummy_id): Delete.
6463         (m32c_gdbarch_init): Don't register deleted functions with
6464         gdbarch.
6465
6466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6467
6468         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6469         (lm32_unwind_pc): Delete.
6470         (lm32_dummy_id): Delete.
6471         (lm32_gdbarch_init): Don't register deleted functions with
6472         gdbarch.
6473
6474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6475
6476         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6477         (iq2000_unwind_pc): Delete.
6478         (iq2000_dummy_id): Delete.
6479         (iq2000_gdbarch_init): Don't register deleted functions with
6480         gdbarch.
6481
6482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6483
6484         * nds32-tdep.c (nds32_type_align): Delete.
6485         (nds32_push_dummy_call): Use type_align instead.
6486
6487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6488
6489         * arm-tdep.c (arm_type_align): Only handle vector override case.
6490         (arm_push_dummy_call): Use type_align.
6491         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6492
6493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6494
6495         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6496         case.
6497         (pass_on_stack): Use type_align.
6498         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6499         function.
6500
6501 2019-04-23  Tom Tromey  <tromey@adacore.com>
6502
6503         * dwarf2read.c (line_header::file_name_at): Remove unused
6504         overload.
6505
6506 2019-04-23  Tom de Vries  <tdevries@suse.de>
6507
6508         PR gdb/24438
6509         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6510         invocation.
6511
6512
6513 2019-03-27  Ali Tamur  <tamur@google.com>
6514
6515         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6516         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6517         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6518         (dwarf_expr_context::get_addr_index): Likewise
6519         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6520         (symbol_needs_eval_context::get_addr_index): Likewise
6521         (disassemble_dwarf_expression): Add DW_OP_addrx
6522         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6523         (read_cutu_die_from_dwo): Update comment
6524         (skip_one_die): Add DW_FORM_addrx
6525         (read_attribute_value): Likewise
6526         (var_decode_location): Add DW_OP_addrx
6527         (dwarf2_const_value_attr): Add DW_FORM_addrx
6528         (dump_die_shallow): Likewise
6529         (dwarf2_fetch_constant_bytes): Likewise
6530         (decode_locdesc): Add DW_OP_addrx
6531         (skip_form_bytes): Add DW_FORM_addrx
6532
6533 2019-04-22  Ali Tamur  <tamur@google.com>
6534
6535         * MAINTAINERS (Write After Approval): Add self.
6536
6537 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6538
6539         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6540         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6541         (open_symbol_file_object): Likewise.
6542         (svr4_default_sos): Add info parameter.
6543         (svr4_read_so_list): Likewise.
6544         (svr4_current_sos_direct): Adjust functions calls to pass down
6545         info.
6546         (svr4_current_sos_1): Add info parameter.
6547         (svr4_current_sos): Call get_svr4_info, pass info down to
6548         svr4_current_sos_1.
6549         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6550         get_svr4_info.
6551         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6552         get_svr4_info.
6553         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6554         to get_svr4_info.
6555         (probes_table_remove_objfile_probes): Likewise.
6556         (register_solib_event_probe): Add info parameter.
6557         (solist_update_incremental): Pass info parameter down to
6558         svr4_read_so_list.
6559         (disable_probes_interface): Add info parameter.
6560         (svr4_handle_solib_event): Pass current_program_space to
6561         get_svr4_info.  Adjust disable_probes_interface cleanup.
6562         (svr4_create_probe_breakpoints): Add info parameter, pass it
6563         down to register_solib_event_probe.
6564         (svr4_create_solib_event_breakpoints): Add info parameter,
6565         pass it down to svr4_create_probe_breakpoints.
6566         (enable_break): Pass info down to
6567         svr4_create_solib_event_breakpoints.
6568         (svr4_solib_create_inferior_hook): Pass current_program_space to
6569         get_svr4_info.
6570         (svr4_clear_solib): Likewise.
6571
6572 2019-04-22  Pedro Alves  <palves@redhat.com>
6573
6574         * solib-svr4.c (svr4_free_objfile_observer): New.
6575         (probe_and_action::objfile): New field.
6576         (probes_table_htab_remove_objfile_probes)
6577         (probes_table_remove_objfile_probes): New functions.
6578         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6579         in the new probe_and_action.  Don't store the probe in 'lookup'.
6580         (svr4_create_probe_breakpoints): Pass objfile to
6581         register_solib_event_probe.
6582         (_initialize_svr4_solib): Register a free_objfile observer.
6583
6584 2019-04-19  Tom Tromey  <tom@tromey.com>
6585
6586         * common/queue.h: Remove.
6587
6588 2019-04-19  Tom Tromey  <tom@tromey.com>
6589
6590         * event-loop.c: Don't include "common/queue.h".
6591
6592 2019-04-19  Tom Tromey  <tom@tromey.com>
6593
6594         * remote.c (remote_target): Use delete.
6595         * remote-notif.h: Include <list>, not "common/queue.h".
6596         (notif_client_p): Remove typedef.
6597         (remote_notif_state): Add constructor, destructor, initializer.
6598         <notif_queue>: Now a std::list.
6599         (remote_notif_state_xfree): Don't declare.
6600         * remote-notif.c (remote_notif_process, handle_notification)
6601         (remote_notif_state_allocate): Update.
6602         (~remote_notif_state): Rename from remote_notif_state_xfree.
6603
6604 2019-04-19  Tom Tromey  <tom@tromey.com>
6605
6606         * symfile.c (reread_symbols): Update.
6607         * objfiles.c (objfile_register_static_link)
6608         (objfile_lookup_static_link): Update
6609         (~objfile) Don't delete static_links.
6610         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6611
6612 2019-04-19  Tom Tromey  <tom@tromey.com>
6613
6614         * type-stack.h (struct type_stack) <insert>: Constify string.
6615         * type-stack.c (type_stack::insert): Constify string.
6616         * gdbtypes.h (lookup_template_type): Update.
6617         (address_space_name_to_int): Update.
6618         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6619         const.
6620         (lookup_template_type): Make name const.
6621         * c-exp.y: Update rules.
6622         (lex_one_token, classify_name, classify_inner_name)
6623         (c_print_token): Update.
6624         * p-exp.y: Update rules.
6625         (yylex): Update.
6626         * f-exp.y: Update rules.
6627         (yylex): Update.
6628         * d-exp.y: Update rules.
6629         (lex_one_token, classify_name, classify_inner_name): Update.
6630         * parse.c (write_dollar_variable, copy_name): Return std::string.
6631         * parser-defs.h (copy_name): Change return type.
6632         * m2-exp.y: Update rules.
6633         (yylex): Update.
6634         * go-exp.y (lex_one_token): Update.
6635         Update rules.
6636         (classify_unsafe_function, classify_packaged_name)
6637         (classify_name, yylex): Update.
6638
6639 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6640
6641         * configure.ac: add --enable-source-highlight switch.
6642         * configure: Regenerate.
6643         * top.c (print_gdb_version): plumb --enable-source-highlight
6644         status to "show configuration".
6645
6646 2019-04-19  Tom Tromey  <tromey@adacore.com>
6647
6648         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6649         Check ADA_TYPE_P.
6650         (empty_record, ada_template_to_fixed_record_type_1)
6651         (template_to_static_fixed_type)
6652         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6653         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6654         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6655         macros.
6656
6657 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6658
6659         PR symtab/24423:
6660         * source.c (print_source_lines_base): Advance "iter" when a
6661         control character is seen.
6662
6663 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6664
6665         * inferior.h (struct infcall_suspend_state_deleter):
6666         Catch exception in destructor to avoid crash.
6667
6668 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6669
6670         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6671         close to the add_com "shell".
6672
6673 2019-04-18  Tom Tromey  <tromey@adacore.com>
6674
6675         * process-stratum-target.h (class process_stratum_target)
6676         <stratum>: Add "final".
6677
6678 2019-04-17  Tom Tromey  <tromey@adacore.com>
6679
6680         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6681         against nullptr before use.
6682
6683 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6684
6685         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6686
6687 2019-04-17  Jim Wilson  <jimw@sifive.com>
6688             Andrew Burgess  <andrew.burgess@embecosm.com>
6689
6690         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6691         code read might fail, assume 4-byte breakpoint in that case.
6692
6693 2019-04-15  Leszek Swirski  <leszeks@google.com>
6694
6695         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6696         rather than a hand-rolled POD check when checking for forced MEMORY
6697         classification.
6698
6699 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6700
6701         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6702         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6703         function.
6704         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6705         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6706         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6707         declaration.
6708
6709 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6710
6711         * aarch64-linux-nat.c
6712         (aarch64_linux_nat_target::thread_architecture): Add override.
6713         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6714         each VQ.
6715
6716 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6717
6718         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6719
6720 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6721
6722         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6723         target types of size 96-bits, add some additional comments, and
6724         check that the builtin type we found was the correct size.
6725
6726 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6727
6728         * utils.c (prompt_for_continue): Don't restore the styling at the
6729         end, as applied_style has the wrong value.  This fixes styling in
6730         long lists of file names that are interrupted by the "Continue?"
6731         prompt.
6732
6733 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6734
6735         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6736         * c-lang.c (c_language_defn): Likewise.
6737         (cplus_language_defn): Likewise.
6738         (asm_language_defn): Likewise.
6739         (minimal_language_defn): Likewise.
6740         * d-lang.c (d_language_defn): Likewise.
6741         * f-lang.c (f_language_defn): Likewise.
6742         * go-lang.c (go_language_defn): Likewise.
6743         * language.c (unknown_language_defn): Likewise.
6744         (auto_language_defn): Likewise.
6745         * language.h (struct language_defn): Remove la_magic field.
6746         (LANG_MAGIC): Delete.
6747         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6748         * objc-lang.c (objc_language_defn): Likewise.
6749         * opencl-lang.c (opencl_language_defn): Likewise.
6750         * p-lang.c (pascal_language_defn): Likewise.
6751         * rust-lang.c (rust_language_defn): Likewise.
6752
6753 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6754
6755         * riscv-tdep.c (riscv_type_align): New function.
6756         (riscv_type_alignment): Delete.
6757         (riscv_arg_location): Use 'type_align'.
6758         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6759
6760 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6761
6762         * gdbtypes.c (type_align): A struct with no non-static fields also
6763         has alignment of 1.
6764
6765 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6766
6767         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6768         component to 0.
6769         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6770         member.
6771         (riscv_struct_info::analyse): New implementation using new
6772         analyse_inner member function.
6773         (riscv_struct_info::field_offset): New member function.
6774         (riscv_struct_info::m_offsets): New member variable.
6775         (riscv_struct_info::analyse_inner): New private member function,
6776         takes the old implementation of riscv_struct_info::analyse but
6777         extended to track field offsets.
6778         (riscv_call_arg_struct): Update the struct folding special cases
6779         to handle cases where empty C++ structs, which are non-zero
6780         length, are found.
6781         (riscv_arg_location): Initialise the length of each location, a
6782         non-zero length now indicates the location is in use.
6783         (riscv_push_dummy_call): Allow for the first location having a
6784         non-zero offset when setting up arguments.
6785         (riscv_return_value): Likewise, but for return values.
6786
6787 2019-04-11  Tom Tromey  <tromey@adacore.com>
6788
6789         * utils.c (internal_vproblem): Make "msg" const.
6790
6791 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6792
6793         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6794         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6795         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6796         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6797
6798 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6799
6800         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6801         function.
6802         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6803         of amd64_collect_native_gregset.
6804         (amd64_linux_nat_target::store_registers): Likewise.
6805
6806 2019-04-10  Tom Tromey  <tom@tromey.com>
6807
6808         * symtab.c (lookup_global_symbol_from_objfile)
6809         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6810         * objfiles.h (class separate_debug_iterator): New.
6811         (class separate_debug_range): New.
6812         (struct objfile) <separate_debug_objfiles>: New method.
6813         (objfile_separate_debug_iterate): Don't declare.
6814         * objfiles.c (separate_debug_iterator::operator++): Rename from
6815         objfile_separate_debug_iterate.
6816         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6817         iterator.
6818         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6819         iterator.
6820
6821 2019-04-10  Tom Tromey  <tom@tromey.com>
6822
6823         * symfile.c (reread_symbols): Remove old comment.
6824         * objfiles.c (free_all_objfiles): Fix a typo.
6825
6826 2019-04-10  Tom Tromey  <tom@tromey.com>
6827
6828         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6829         * minsyms.c (lookup_minimal_symbol): Use foreach.
6830         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6831         (lookup_minimal_symbol_solib_trampoline): Likewise.
6832         * symfile.c (reread_symbols): Use foreach.
6833
6834 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6835             Tom Tromey  <tromey@adacore.com>
6836
6837         PR rust/24414:
6838         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6839         (rust_lex_int_test): Change "value" to be LONGEST.
6840         (rust_lex_tests): Add test for long integer literal.
6841
6842 2019-04-09  Tom Tromey  <tromey@adacore.com>
6843
6844         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6845         to bool.
6846         (extended_remote_target::attach): Update.
6847         (remote_target::remote_notice_new_inferior): Update.
6848         (remote_target::add_current_inferior_and_thread): Update.
6849         * inferior.c (exit_inferior_1): Use "false".
6850         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6851
6852 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6853
6854         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6855         the "start" command.
6856
6857 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6858
6859         * python/py-inferior.c (infpy_thread_from_thread_handle):
6860         Adjust comments to reflect renaming of thread_from_thread_handle
6861         to thread_from_handle.  Adjust keywords.  Fix type error message.
6862         (inferior_object_methods): Add thread_from_handle.  Retain
6863         thread_from_thread_handle, but mark it as deprecated.
6864
6865 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6866
6867         * gdbthread.h (find_thread_by_handle): Revise declaration.
6868         * thread.c (find_thread_by_handle): Likewise.  Adjust
6869         implementation too.
6870         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6871         support for buffer objects as handles.
6872
6873 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6874
6875         * python/py-infthread.c (thpy_thread_handle): New function.
6876         (thread_object_methods): Register thpy_thread_handle.
6877
6878 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6879
6880         * gdbthread.h (thread_to_thread_handle): Declare.
6881         * thread.c (gdbtypes.h): Include.
6882         (thread_to_thread_handle): New function.
6883
6884         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6885         (target_thread_info_to_thread_handle): Declare.
6886         * target.c (target_thread_info_to_thread_handle): New function.
6887         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6888         * target-delegates.c: Regenerate.
6889
6890         * linux-thread-db.c (class thread_db_target): Add method
6891         thread_info_to_thread_handle.
6892         (thread_db_target::thread_info_to_thread_handle): Define.
6893         * remote.c (class remote_target): Add new method
6894         thread_info_to_thread_handle.
6895         (remote_target::thread_info_to_thread_handle): Define.
6896
6897 2019-04-08  Pedro Alves  <palves@redhat.com>
6898
6899         * common/common-exceptions.c (throw_exception): Don't create
6900         named object to throw; throw directly.
6901         (throw_it): Likewise.  Don't initialize gdb_exception::message
6902         here, with new; pass FMT and AP to the ctor instead.
6903         * common/common-exceptions.h: Include <string>.
6904         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6905         const char *, va_list)): New ctor.  Use std::make_shared.
6906         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6907         errors)): Delete.
6908         (gdb_exception_error::gdb_exception_error(enum errors, const char
6909         *, va_list)): New.
6910         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6911         Add assertion.
6912         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6913         errors)): Delete.
6914         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6915         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6916         Add assertion.
6917
6918 2019-04-08  Tom Tromey  <tom@tromey.com>
6919
6920         * valops.c (value_rtti_indirect_type): Replace throw_exception
6921         with throw.
6922         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6923         with throw.
6924         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6925         throw.
6926         * target.c (target_translate_tls_address): Replace throw_exception
6927         with throw.
6928         * stack.c (frame_apply_command_count): Replace throw_exception
6929         with throw.
6930         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6931         throw.
6932         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6933         with throw.
6934         * rs6000-tdep.c (rs6000_frame_cache)
6935         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6936         * remote.c: Replace throw_exception with throw.
6937         * record-full.c (record_full_message, record_full_wait_1)
6938         (record_full_restore): Replace throw_exception with throw.
6939         * record-btrace.c:
6940         (get_thread_current_frame_id, record_btrace_start_replaying)
6941         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6942         (cmd_record_btrace_start): Replace throw_exception with throw.
6943         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6944         throw.
6945         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6946         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6947         * linespec.c:
6948         (find_linespec_symbols): Replace throw_exception with throw.
6949         * infrun.c (displaced_step_prepare, resume): Replace
6950         throw_exception with throw.
6951         * infcmd.c (post_create_inferior): Replace throw_exception with
6952         throw.
6953         * inf-loop.c (inferior_event_handler): Replace throw_exception
6954         with throw.
6955         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6956         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6957         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6958         (get_prev_frame_always, get_frame_pc_if_available)
6959         (get_frame_address_in_block_if_available, get_frame_language):
6960         Replace throw_exception with throw.
6961         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6962         throw_exception with throw.
6963         * eval.c (fetch_subexp_value, evaluate_var_value)
6964         (evaluate_funcall, evaluate_subexp_standard): Replace
6965         throw_exception with throw.
6966         * dwarf2loc.c (call_site_find_chain)
6967         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6968         Replace throw_exception with throw.
6969         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6970         with throw.
6971         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6972         throw.
6973         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6974         * completer.c (complete_line_internal): Replace throw_exception
6975         with throw.
6976         * compile/compile-object-run.c (compile_object_run): Replace
6977         throw_exception with throw.
6978         * cli/cli-script.c (process_next_line): Replace throw_exception
6979         with throw.
6980         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6981         (btrace_enable, btrace_maint_update_pt_packets): Replace
6982         throw_exception with throw.
6983         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6984         throw_exception with throw.
6985         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6986         throw_exception with throw.
6987         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6988         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6989         * aarch64-tdep.c (aarch64_make_prologue_cache)
6990         (aarch64_make_stub_cache): Replace throw_exception with throw.
6991
6992 2019-04-08  Tom Tromey  <tom@tromey.com>
6993
6994         * common/common-exceptions.c (throw_exception): Rename from
6995         throw_exception_cxx.  Remove old copy.  Make argument const.
6996         (throw_it): Create and throw exception objects directly.
6997         * common/common-exceptions.h (throw_exception): Make argument
6998         const.
6999         (struct gdb_exception_error): Add constructor.
7000         (struct gdb_exception_quit): Add constructor.
7001
7002 2019-04-08  Tom Tromey  <tom@tromey.com>
7003
7004         * common/common-exceptions.h (exception_rethrow): Don't declare.
7005         (TRY_SJLJ): Update comment.
7006         (TRY, CATCH, END_CATCH): Remove.
7007         * common/common-exceptions.c (exception_rethrow): Remove.
7008
7009 2019-04-08  Tom Tromey  <tom@tromey.com>
7010
7011         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7012         Remove.
7013         (gdb_exception_error): Rename from
7014         gdb_exception_RETURN_MASK_ERROR.
7015         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7016         (gdb_quit_bad_alloc): Update.
7017         * aarch64-tdep.c: Update.
7018         * ada-lang.c: Update.
7019         * ada-typeprint.c: Update.
7020         * ada-valprint.c: Update.
7021         * amd64-tdep.c: Update.
7022         * arch-utils.c: Update.
7023         * break-catch-throw.c: Update.
7024         * breakpoint.c: Update.
7025         * btrace.c: Update.
7026         * c-varobj.c: Update.
7027         * cli/cli-cmds.c: Update.
7028         * cli/cli-interp.c: Update.
7029         * cli/cli-script.c: Update.
7030         * common/common-exceptions.c: Update.
7031         * common/new-op.c: Update.
7032         * common/selftest.c: Update.
7033         * compile/compile-c-symbols.c: Update.
7034         * compile/compile-cplus-symbols.c: Update.
7035         * compile/compile-object-load.c: Update.
7036         * compile/compile-object-run.c: Update.
7037         * completer.c: Update.
7038         * corelow.c: Update.
7039         * cp-abi.c: Update.
7040         * cp-support.c: Update.
7041         * cp-valprint.c: Update.
7042         * darwin-nat.c: Update.
7043         * disasm-selftests.c: Update.
7044         * dtrace-probe.c: Update.
7045         * dwarf-index-cache.c: Update.
7046         * dwarf-index-write.c: Update.
7047         * dwarf2-frame-tailcall.c: Update.
7048         * dwarf2-frame.c: Update.
7049         * dwarf2loc.c: Update.
7050         * dwarf2read.c: Update.
7051         * eval.c: Update.
7052         * event-loop.c: Update.
7053         * event-top.c: Update.
7054         * exec.c: Update.
7055         * f-valprint.c: Update.
7056         * fbsd-tdep.c: Update.
7057         * frame-unwind.c: Update.
7058         * frame.c: Update.
7059         * gdbtypes.c: Update.
7060         * gnu-v3-abi.c: Update.
7061         * guile/guile-internal.h: Update.
7062         * guile/scm-block.c: Update.
7063         * guile/scm-breakpoint.c: Update.
7064         * guile/scm-cmd.c: Update.
7065         * guile/scm-disasm.c: Update.
7066         * guile/scm-frame.c: Update.
7067         * guile/scm-lazy-string.c: Update.
7068         * guile/scm-math.c: Update.
7069         * guile/scm-param.c: Update.
7070         * guile/scm-ports.c: Update.
7071         * guile/scm-pretty-print.c: Update.
7072         * guile/scm-symbol.c: Update.
7073         * guile/scm-symtab.c: Update.
7074         * guile/scm-type.c: Update.
7075         * guile/scm-value.c: Update.
7076         * i386-linux-tdep.c: Update.
7077         * i386-tdep.c: Update.
7078         * inf-loop.c: Update.
7079         * infcall.c: Update.
7080         * infcmd.c: Update.
7081         * infrun.c: Update.
7082         * jit.c: Update.
7083         * language.c: Update.
7084         * linespec.c: Update.
7085         * linux-fork.c: Update.
7086         * linux-nat.c: Update.
7087         * linux-tdep.c: Update.
7088         * linux-thread-db.c: Update.
7089         * main.c: Update.
7090         * mi/mi-cmd-break.c: Update.
7091         * mi/mi-cmd-stack.c: Update.
7092         * mi/mi-interp.c: Update.
7093         * mi/mi-main.c: Update.
7094         * objc-lang.c: Update.
7095         * p-valprint.c: Update.
7096         * parse.c: Update.
7097         * ppc-linux-tdep.c: Update.
7098         * printcmd.c: Update.
7099         * python/py-arch.c: Update.
7100         * python/py-breakpoint.c: Update.
7101         * python/py-cmd.c: Update.
7102         * python/py-finishbreakpoint.c: Update.
7103         * python/py-frame.c: Update.
7104         * python/py-framefilter.c: Update.
7105         * python/py-gdb-readline.c: Update.
7106         * python/py-inferior.c: Update.
7107         * python/py-infthread.c: Update.
7108         * python/py-lazy-string.c: Update.
7109         * python/py-linetable.c: Update.
7110         * python/py-objfile.c: Update.
7111         * python/py-param.c: Update.
7112         * python/py-prettyprint.c: Update.
7113         * python/py-progspace.c: Update.
7114         * python/py-record-btrace.c: Update.
7115         * python/py-record.c: Update.
7116         * python/py-symbol.c: Update.
7117         * python/py-type.c: Update.
7118         * python/py-unwind.c: Update.
7119         * python/py-utils.c: Update.
7120         * python/py-value.c: Update.
7121         * python/python.c: Update.
7122         * record-btrace.c: Update.
7123         * record-full.c: Update.
7124         * remote-fileio.c: Update.
7125         * remote.c: Update.
7126         * riscv-tdep.c: Update.
7127         * rs6000-aix-tdep.c: Update.
7128         * rs6000-tdep.c: Update.
7129         * rust-exp.y: Update.
7130         * rust-lang.c: Update.
7131         * s390-tdep.c: Update.
7132         * selftest-arch.c: Update.
7133         * solib-dsbt.c: Update.
7134         * solib-frv.c: Update.
7135         * solib-spu.c: Update.
7136         * solib-svr4.c: Update.
7137         * solib.c: Update.
7138         * sparc64-linux-tdep.c: Update.
7139         * stack.c: Update.
7140         * symfile-mem.c: Update.
7141         * symmisc.c: Update.
7142         * target.c: Update.
7143         * thread.c: Update.
7144         * top.c: Update.
7145         * tracefile-tfile.c: Update.
7146         * tui/tui.c: Update.
7147         * typeprint.c: Update.
7148         * unittests/cli-utils-selftests.c: Update.
7149         * unittests/parse-connection-spec-selftests.c: Update.
7150         * valops.c: Update.
7151         * valprint.c: Update.
7152         * value.c: Update.
7153         * varobj.c: Update.
7154         * windows-nat.c: Update.
7155         * x86-linux-nat.c: Update.
7156         * xml-support.c: Update.
7157
7158 2019-04-08  Tom Tromey  <tom@tromey.com>
7159
7160         * xml-support.c: Use C++ exception handling.
7161         * x86-linux-nat.c: Use C++ exception handling.
7162         * windows-nat.c: Use C++ exception handling.
7163         * varobj.c: Use C++ exception handling.
7164         * value.c: Use C++ exception handling.
7165         * valprint.c: Use C++ exception handling.
7166         * valops.c: Use C++ exception handling.
7167         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7168         handling.
7169         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7170         * typeprint.c: Use C++ exception handling.
7171         * tui/tui.c: Use C++ exception handling.
7172         * tracefile-tfile.c: Use C++ exception handling.
7173         * top.c: Use C++ exception handling.
7174         * thread.c: Use C++ exception handling.
7175         * target.c: Use C++ exception handling.
7176         * symmisc.c: Use C++ exception handling.
7177         * symfile-mem.c: Use C++ exception handling.
7178         * stack.c: Use C++ exception handling.
7179         * sparc64-linux-tdep.c: Use C++ exception handling.
7180         * solib.c: Use C++ exception handling.
7181         * solib-svr4.c: Use C++ exception handling.
7182         * solib-spu.c: Use C++ exception handling.
7183         * solib-frv.c: Use C++ exception handling.
7184         * solib-dsbt.c: Use C++ exception handling.
7185         * selftest-arch.c: Use C++ exception handling.
7186         * s390-tdep.c: Use C++ exception handling.
7187         * rust-lang.c: Use C++ exception handling.
7188         * rust-exp.y: Use C++ exception handling.
7189         * rs6000-tdep.c: Use C++ exception handling.
7190         * rs6000-aix-tdep.c: Use C++ exception handling.
7191         * riscv-tdep.c: Use C++ exception handling.
7192         * remote.c: Use C++ exception handling.
7193         * remote-fileio.c: Use C++ exception handling.
7194         * record-full.c: Use C++ exception handling.
7195         * record-btrace.c: Use C++ exception handling.
7196         * python/python.c: Use C++ exception handling.
7197         * python/py-value.c: Use C++ exception handling.
7198         * python/py-utils.c: Use C++ exception handling.
7199         * python/py-unwind.c: Use C++ exception handling.
7200         * python/py-type.c: Use C++ exception handling.
7201         * python/py-symbol.c: Use C++ exception handling.
7202         * python/py-record.c: Use C++ exception handling.
7203         * python/py-record-btrace.c: Use C++ exception handling.
7204         * python/py-progspace.c: Use C++ exception handling.
7205         * python/py-prettyprint.c: Use C++ exception handling.
7206         * python/py-param.c: Use C++ exception handling.
7207         * python/py-objfile.c: Use C++ exception handling.
7208         * python/py-linetable.c: Use C++ exception handling.
7209         * python/py-lazy-string.c: Use C++ exception handling.
7210         * python/py-infthread.c: Use C++ exception handling.
7211         * python/py-inferior.c: Use C++ exception handling.
7212         * python/py-gdb-readline.c: Use C++ exception handling.
7213         * python/py-framefilter.c: Use C++ exception handling.
7214         * python/py-frame.c: Use C++ exception handling.
7215         * python/py-finishbreakpoint.c: Use C++ exception handling.
7216         * python/py-cmd.c: Use C++ exception handling.
7217         * python/py-breakpoint.c: Use C++ exception handling.
7218         * python/py-arch.c: Use C++ exception handling.
7219         * printcmd.c: Use C++ exception handling.
7220         * ppc-linux-tdep.c: Use C++ exception handling.
7221         * parse.c: Use C++ exception handling.
7222         * p-valprint.c: Use C++ exception handling.
7223         * objc-lang.c: Use C++ exception handling.
7224         * mi/mi-main.c: Use C++ exception handling.
7225         * mi/mi-interp.c: Use C++ exception handling.
7226         * mi/mi-cmd-stack.c: Use C++ exception handling.
7227         * mi/mi-cmd-break.c: Use C++ exception handling.
7228         * main.c: Use C++ exception handling.
7229         * linux-thread-db.c: Use C++ exception handling.
7230         * linux-tdep.c: Use C++ exception handling.
7231         * linux-nat.c: Use C++ exception handling.
7232         * linux-fork.c: Use C++ exception handling.
7233         * linespec.c: Use C++ exception handling.
7234         * language.c: Use C++ exception handling.
7235         * jit.c: Use C++ exception handling.
7236         * infrun.c: Use C++ exception handling.
7237         * infcmd.c: Use C++ exception handling.
7238         * infcall.c: Use C++ exception handling.
7239         * inf-loop.c: Use C++ exception handling.
7240         * i386-tdep.c: Use C++ exception handling.
7241         * i386-linux-tdep.c: Use C++ exception handling.
7242         * guile/scm-value.c: Use C++ exception handling.
7243         * guile/scm-type.c: Use C++ exception handling.
7244         * guile/scm-symtab.c: Use C++ exception handling.
7245         * guile/scm-symbol.c: Use C++ exception handling.
7246         * guile/scm-pretty-print.c: Use C++ exception handling.
7247         * guile/scm-ports.c: Use C++ exception handling.
7248         * guile/scm-param.c: Use C++ exception handling.
7249         * guile/scm-math.c: Use C++ exception handling.
7250         * guile/scm-lazy-string.c: Use C++ exception handling.
7251         * guile/scm-frame.c: Use C++ exception handling.
7252         * guile/scm-disasm.c: Use C++ exception handling.
7253         * guile/scm-cmd.c: Use C++ exception handling.
7254         * guile/scm-breakpoint.c: Use C++ exception handling.
7255         * guile/scm-block.c: Use C++ exception handling.
7256         * guile/guile-internal.h: Use C++ exception handling.
7257         * gnu-v3-abi.c: Use C++ exception handling.
7258         * gdbtypes.c: Use C++ exception handling.
7259         * frame.c: Use C++ exception handling.
7260         * frame-unwind.c: Use C++ exception handling.
7261         * fbsd-tdep.c: Use C++ exception handling.
7262         * f-valprint.c: Use C++ exception handling.
7263         * exec.c: Use C++ exception handling.
7264         * event-top.c: Use C++ exception handling.
7265         * event-loop.c: Use C++ exception handling.
7266         * eval.c: Use C++ exception handling.
7267         * dwarf2read.c: Use C++ exception handling.
7268         * dwarf2loc.c: Use C++ exception handling.
7269         * dwarf2-frame.c: Use C++ exception handling.
7270         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7271         * dwarf-index-write.c: Use C++ exception handling.
7272         * dwarf-index-cache.c: Use C++ exception handling.
7273         * dtrace-probe.c: Use C++ exception handling.
7274         * disasm-selftests.c: Use C++ exception handling.
7275         * darwin-nat.c: Use C++ exception handling.
7276         * cp-valprint.c: Use C++ exception handling.
7277         * cp-support.c: Use C++ exception handling.
7278         * cp-abi.c: Use C++ exception handling.
7279         * corelow.c: Use C++ exception handling.
7280         * completer.c: Use C++ exception handling.
7281         * compile/compile-object-run.c: Use C++ exception handling.
7282         * compile/compile-object-load.c: Use C++ exception handling.
7283         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7284         * compile/compile-c-symbols.c: Use C++ exception handling.
7285         * common/selftest.c: Use C++ exception handling.
7286         * common/new-op.c: Use C++ exception handling.
7287         * cli/cli-script.c: Use C++ exception handling.
7288         * cli/cli-interp.c: Use C++ exception handling.
7289         * cli/cli-cmds.c: Use C++ exception handling.
7290         * c-varobj.c: Use C++ exception handling.
7291         * btrace.c: Use C++ exception handling.
7292         * breakpoint.c: Use C++ exception handling.
7293         * break-catch-throw.c: Use C++ exception handling.
7294         * arch-utils.c: Use C++ exception handling.
7295         * amd64-tdep.c: Use C++ exception handling.
7296         * ada-valprint.c: Use C++ exception handling.
7297         * ada-typeprint.c: Use C++ exception handling.
7298         * ada-lang.c: Use C++ exception handling.
7299         * aarch64-tdep.c: Use C++ exception handling.
7300
7301 2019-04-08  Tom Tromey  <tom@tromey.com>
7302
7303         * xml-support.c (gdb_xml_parser::parse): Update.
7304         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7305         * value.c (show_convenience): Update.
7306         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7307         (test_parse_flags_qcs): Update.
7308         * thread.c (thr_try_catch_cmd): Update.
7309         * target.c (target_translate_tls_address): Update.
7310         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7311         (info_frame_command_core, frame_apply_command_count): Update.
7312         * rust-exp.y (rust_lex_exception_test): Update.
7313         * riscv-tdep.c (riscv_print_one_register_info): Update.
7314         * remote.c (remote_target::enable_btrace): Update.
7315         * record-btrace.c (record_btrace_enable_warn): Update.
7316         * python/py-utils.c (gdbpy_convert_exception): Update.
7317         * printcmd.c (do_one_display, print_variable_and_value): Update.
7318         * mi/mi-main.c (mi_print_exception): Update.
7319         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7320         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7321         * linux-nat.c (linux_nat_target::attach): Update.
7322         * linux-fork.c (class scoped_switch_fork_info): Update.
7323         * infrun.c (displaced_step_prepare): Update.
7324         * infcall.c (call_function_by_hand_dummy): Update.
7325         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7326         * gnu-v3-abi.c (print_one_vtable): Update.
7327         * frame.c (get_prev_frame_always): Update.
7328         * f-valprint.c (info_common_command_for_block): Update.
7329         * exec.c (try_open_exec_file): Update.
7330         * exceptions.c (print_exception, exception_print)
7331         (exception_fprintf, exception_print_same): Update.
7332         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7333         * dwarf-index-cache.c (index_cache::store)
7334         (index_cache::lookup_gdb_index): Update.
7335         * darwin-nat.c (maybe_cache_shell): Update.
7336         * cp-valprint.c (cp_print_value_fields): Update.
7337         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7338         (gcc_cplus_symbol_address): Update.
7339         * compile/compile-c-symbols.c (gcc_convert_symbol)
7340         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7341         * common/selftest.c: Update.
7342         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7343         a std::string.
7344         (exception_try_scope_entry, exception_try_scope_exit): Don't
7345         declare.
7346         (struct exception_try_scope): Remove.
7347         (TRY): Don't use exception_try_scope.
7348         (struct gdb_exception): Add constructor, operator=.
7349         <what>: New method.
7350         (struct gdb_exception_RETURN_MASK_ALL)
7351         (struct gdb_exception_RETURN_MASK_ERROR)
7352         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7353         (struct gdb_quit_bad_alloc): Update.
7354         * common/common-exceptions.c (exception_none): Change
7355         initializer.
7356         (struct catcher) <state, exception>: Initialize inline.
7357         <prev>: Remove member.
7358         (current_catcher): Remove.
7359         (catchers): New global.
7360         (exceptions_state_mc_init): Simplify.
7361         (catcher_pop): Remove.
7362         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7363         (try_scope_depth, exception_try_scope_entry)
7364         (exception_try_scope_exit): Remove.
7365         (throw_exception_sjlj): Update.
7366         (exception_messages, exception_messages_size): Remove.
7367         (throw_it): Simplify.
7368         (gdb_exception_sliced_copy): Remove.
7369         (throw_exception_cxx): Update.
7370         * cli/cli-script.c (script_from_file): Update.
7371         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7372         Update.
7373         * ada-valprint.c (ada_val_print): Update.
7374         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7375         (create_excep_cond_exprs): Update.
7376
7377 2019-04-08  Tom Tromey  <tom@tromey.com>
7378
7379         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7380         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7381         (TRY, CATCH, END_CATCH): Remove some definitions.
7382         * common/common-exceptions.c: Don't use GDB_XCPT.
7383         (catcher_list_size): Remove.
7384         (throw_exception, throw_it): Simplify.
7385
7386 2019-04-05  Tom Tromey  <tom@tromey.com>
7387
7388         Revert the header-sorting patch.
7389         * ft32-tdep.c: Revert.
7390         * frv-tdep.c: Revert.
7391         * frv-linux-tdep.c: Revert.
7392         * frame.c: Revert.
7393         * frame-unwind.c: Revert.
7394         * frame-base.c: Revert.
7395         * fork-child.c: Revert.
7396         * findvar.c: Revert.
7397         * findcmd.c: Revert.
7398         * filesystem.c: Revert.
7399         * filename-seen-cache.h: Revert.
7400         * filename-seen-cache.c: Revert.
7401         * fbsd-tdep.c: Revert.
7402         * fbsd-nat.h: Revert.
7403         * fbsd-nat.c: Revert.
7404         * f-valprint.c: Revert.
7405         * f-typeprint.c: Revert.
7406         * f-lang.c: Revert.
7407         * extension.h: Revert.
7408         * extension.c: Revert.
7409         * extension-priv.h: Revert.
7410         * expprint.c: Revert.
7411         * exec.h: Revert.
7412         * exec.c: Revert.
7413         * exceptions.c: Revert.
7414         * event-top.c: Revert.
7415         * event-loop.c: Revert.
7416         * eval.c: Revert.
7417         * elfread.c: Revert.
7418         * dwarf2read.h: Revert.
7419         * dwarf2read.c: Revert.
7420         * dwarf2loc.c: Revert.
7421         * dwarf2expr.h: Revert.
7422         * dwarf2expr.c: Revert.
7423         * dwarf2-frame.c: Revert.
7424         * dwarf2-frame-tailcall.c: Revert.
7425         * dwarf-index-write.h: Revert.
7426         * dwarf-index-write.c: Revert.
7427         * dwarf-index-common.c: Revert.
7428         * dwarf-index-cache.h: Revert.
7429         * dwarf-index-cache.c: Revert.
7430         * dummy-frame.c: Revert.
7431         * dtrace-probe.c: Revert.
7432         * disasm.h: Revert.
7433         * disasm.c: Revert.
7434         * disasm-selftests.c: Revert.
7435         * dictionary.c: Revert.
7436         * dicos-tdep.c: Revert.
7437         * demangle.c: Revert.
7438         * dcache.h: Revert.
7439         * dcache.c: Revert.
7440         * darwin-nat.h: Revert.
7441         * darwin-nat.c: Revert.
7442         * darwin-nat-info.c: Revert.
7443         * d-valprint.c: Revert.
7444         * d-namespace.c: Revert.
7445         * d-lang.c: Revert.
7446         * ctf.c: Revert.
7447         * csky-tdep.c: Revert.
7448         * csky-linux-tdep.c: Revert.
7449         * cris-tdep.c: Revert.
7450         * cris-linux-tdep.c: Revert.
7451         * cp-valprint.c: Revert.
7452         * cp-support.c: Revert.
7453         * cp-namespace.c: Revert.
7454         * cp-abi.c: Revert.
7455         * corelow.c: Revert.
7456         * corefile.c: Revert.
7457         * continuations.c: Revert.
7458         * completer.h: Revert.
7459         * completer.c: Revert.
7460         * complaints.c: Revert.
7461         * coffread.c: Revert.
7462         * coff-pe-read.c: Revert.
7463         * cli-out.h: Revert.
7464         * cli-out.c: Revert.
7465         * charset.c: Revert.
7466         * c-varobj.c: Revert.
7467         * c-valprint.c: Revert.
7468         * c-typeprint.c: Revert.
7469         * c-lang.c: Revert.
7470         * buildsym.c: Revert.
7471         * buildsym-legacy.c: Revert.
7472         * build-id.h: Revert.
7473         * build-id.c: Revert.
7474         * btrace.c: Revert.
7475         * bsd-uthread.c: Revert.
7476         * breakpoint.h: Revert.
7477         * breakpoint.c: Revert.
7478         * break-catch-throw.c: Revert.
7479         * break-catch-syscall.c: Revert.
7480         * break-catch-sig.c: Revert.
7481         * blockframe.c: Revert.
7482         * block.c: Revert.
7483         * bfin-tdep.c: Revert.
7484         * bfin-linux-tdep.c: Revert.
7485         * bfd-target.c: Revert.
7486         * bcache.c: Revert.
7487         * ax-general.c: Revert.
7488         * ax-gdb.h: Revert.
7489         * ax-gdb.c: Revert.
7490         * avr-tdep.c: Revert.
7491         * auxv.c: Revert.
7492         * auto-load.c: Revert.
7493         * arm-wince-tdep.c: Revert.
7494         * arm-tdep.c: Revert.
7495         * arm-symbian-tdep.c: Revert.
7496         * arm-pikeos-tdep.c: Revert.
7497         * arm-obsd-tdep.c: Revert.
7498         * arm-nbsd-tdep.c: Revert.
7499         * arm-nbsd-nat.c: Revert.
7500         * arm-linux-tdep.c: Revert.
7501         * arm-linux-nat.c: Revert.
7502         * arm-fbsd-tdep.c: Revert.
7503         * arm-fbsd-nat.c: Revert.
7504         * arm-bsd-tdep.c: Revert.
7505         * arch-utils.c: Revert.
7506         * arc-tdep.c: Revert.
7507         * arc-newlib-tdep.c: Revert.
7508         * annotate.h: Revert.
7509         * annotate.c: Revert.
7510         * amd64-windows-tdep.c: Revert.
7511         * amd64-windows-nat.c: Revert.
7512         * amd64-tdep.c: Revert.
7513         * amd64-sol2-tdep.c: Revert.
7514         * amd64-obsd-tdep.c: Revert.
7515         * amd64-obsd-nat.c: Revert.
7516         * amd64-nbsd-tdep.c: Revert.
7517         * amd64-nbsd-nat.c: Revert.
7518         * amd64-nat.c: Revert.
7519         * amd64-linux-tdep.c: Revert.
7520         * amd64-linux-nat.c: Revert.
7521         * amd64-fbsd-tdep.c: Revert.
7522         * amd64-fbsd-nat.c: Revert.
7523         * amd64-dicos-tdep.c: Revert.
7524         * amd64-darwin-tdep.c: Revert.
7525         * amd64-bsd-nat.c: Revert.
7526         * alpha-tdep.c: Revert.
7527         * alpha-obsd-tdep.c: Revert.
7528         * alpha-nbsd-tdep.c: Revert.
7529         * alpha-mdebug-tdep.c: Revert.
7530         * alpha-linux-tdep.c: Revert.
7531         * alpha-linux-nat.c: Revert.
7532         * alpha-bsd-tdep.c: Revert.
7533         * alpha-bsd-nat.c: Revert.
7534         * aix-thread.c: Revert.
7535         * agent.c: Revert.
7536         * addrmap.c: Revert.
7537         * ada-varobj.c: Revert.
7538         * ada-valprint.c: Revert.
7539         * ada-typeprint.c: Revert.
7540         * ada-tasks.c: Revert.
7541         * ada-lang.c: Revert.
7542         * aarch64-tdep.c: Revert.
7543         * aarch64-ravenscar-thread.c: Revert.
7544         * aarch64-newlib-tdep.c: Revert.
7545         * aarch64-linux-tdep.c: Revert.
7546         * aarch64-linux-nat.c: Revert.
7547         * aarch64-fbsd-tdep.c: Revert.
7548         * aarch64-fbsd-nat.c: Revert.
7549         * aarch32-linux-nat.c: Revert.
7550
7551 2019-04-05  Tom Tromey  <tom@tromey.com>
7552
7553         * ft32-tdep.c: Sort headers.
7554         * frv-tdep.c: Sort headers.
7555         * frv-linux-tdep.c: Sort headers.
7556         * frame.c: Sort headers.
7557         * frame-unwind.c: Sort headers.
7558         * frame-base.c: Sort headers.
7559         * fork-child.c: Sort headers.
7560         * findvar.c: Sort headers.
7561         * findcmd.c: Sort headers.
7562         * filesystem.c: Sort headers.
7563         * filename-seen-cache.h: Sort headers.
7564         * filename-seen-cache.c: Sort headers.
7565         * fbsd-tdep.c: Sort headers.
7566         * fbsd-nat.h: Sort headers.
7567         * fbsd-nat.c: Sort headers.
7568         * f-valprint.c: Sort headers.
7569         * f-typeprint.c: Sort headers.
7570         * f-lang.c: Sort headers.
7571         * extension.h: Sort headers.
7572         * extension.c: Sort headers.
7573         * extension-priv.h: Sort headers.
7574         * expprint.c: Sort headers.
7575         * exec.h: Sort headers.
7576         * exec.c: Sort headers.
7577         * exceptions.c: Sort headers.
7578         * event-top.c: Sort headers.
7579         * event-loop.c: Sort headers.
7580         * eval.c: Sort headers.
7581         * elfread.c: Sort headers.
7582         * dwarf2read.h: Sort headers.
7583         * dwarf2read.c: Sort headers.
7584         * dwarf2loc.c: Sort headers.
7585         * dwarf2expr.h: Sort headers.
7586         * dwarf2expr.c: Sort headers.
7587         * dwarf2-frame.c: Sort headers.
7588         * dwarf2-frame-tailcall.c: Sort headers.
7589         * dwarf-index-write.h: Sort headers.
7590         * dwarf-index-write.c: Sort headers.
7591         * dwarf-index-common.c: Sort headers.
7592         * dwarf-index-cache.h: Sort headers.
7593         * dwarf-index-cache.c: Sort headers.
7594         * dummy-frame.c: Sort headers.
7595         * dtrace-probe.c: Sort headers.
7596         * disasm.h: Sort headers.
7597         * disasm.c: Sort headers.
7598         * disasm-selftests.c: Sort headers.
7599         * dictionary.c: Sort headers.
7600         * dicos-tdep.c: Sort headers.
7601         * demangle.c: Sort headers.
7602         * dcache.h: Sort headers.
7603         * dcache.c: Sort headers.
7604         * darwin-nat.h: Sort headers.
7605         * darwin-nat.c: Sort headers.
7606         * darwin-nat-info.c: Sort headers.
7607         * d-valprint.c: Sort headers.
7608         * d-namespace.c: Sort headers.
7609         * d-lang.c: Sort headers.
7610         * ctf.c: Sort headers.
7611         * csky-tdep.c: Sort headers.
7612         * csky-linux-tdep.c: Sort headers.
7613         * cris-tdep.c: Sort headers.
7614         * cris-linux-tdep.c: Sort headers.
7615         * cp-valprint.c: Sort headers.
7616         * cp-support.c: Sort headers.
7617         * cp-namespace.c: Sort headers.
7618         * cp-abi.c: Sort headers.
7619         * corelow.c: Sort headers.
7620         * corefile.c: Sort headers.
7621         * continuations.c: Sort headers.
7622         * completer.h: Sort headers.
7623         * completer.c: Sort headers.
7624         * complaints.c: Sort headers.
7625         * coffread.c: Sort headers.
7626         * coff-pe-read.c: Sort headers.
7627         * cli-out.h: Sort headers.
7628         * cli-out.c: Sort headers.
7629         * charset.c: Sort headers.
7630         * c-varobj.c: Sort headers.
7631         * c-valprint.c: Sort headers.
7632         * c-typeprint.c: Sort headers.
7633         * c-lang.c: Sort headers.
7634         * buildsym.c: Sort headers.
7635         * buildsym-legacy.c: Sort headers.
7636         * build-id.h: Sort headers.
7637         * build-id.c: Sort headers.
7638         * btrace.c: Sort headers.
7639         * bsd-uthread.c: Sort headers.
7640         * breakpoint.h: Sort headers.
7641         * breakpoint.c: Sort headers.
7642         * break-catch-throw.c: Sort headers.
7643         * break-catch-syscall.c: Sort headers.
7644         * break-catch-sig.c: Sort headers.
7645         * blockframe.c: Sort headers.
7646         * block.c: Sort headers.
7647         * bfin-tdep.c: Sort headers.
7648         * bfin-linux-tdep.c: Sort headers.
7649         * bfd-target.c: Sort headers.
7650         * bcache.c: Sort headers.
7651         * ax-general.c: Sort headers.
7652         * ax-gdb.h: Sort headers.
7653         * ax-gdb.c: Sort headers.
7654         * avr-tdep.c: Sort headers.
7655         * auxv.c: Sort headers.
7656         * auto-load.c: Sort headers.
7657         * arm-wince-tdep.c: Sort headers.
7658         * arm-tdep.c: Sort headers.
7659         * arm-symbian-tdep.c: Sort headers.
7660         * arm-pikeos-tdep.c: Sort headers.
7661         * arm-obsd-tdep.c: Sort headers.
7662         * arm-nbsd-tdep.c: Sort headers.
7663         * arm-nbsd-nat.c: Sort headers.
7664         * arm-linux-tdep.c: Sort headers.
7665         * arm-linux-nat.c: Sort headers.
7666         * arm-fbsd-tdep.c: Sort headers.
7667         * arm-fbsd-nat.c: Sort headers.
7668         * arm-bsd-tdep.c: Sort headers.
7669         * arch-utils.c: Sort headers.
7670         * arc-tdep.c: Sort headers.
7671         * arc-newlib-tdep.c: Sort headers.
7672         * annotate.h: Sort headers.
7673         * annotate.c: Sort headers.
7674         * amd64-windows-tdep.c: Sort headers.
7675         * amd64-windows-nat.c: Sort headers.
7676         * amd64-tdep.c: Sort headers.
7677         * amd64-sol2-tdep.c: Sort headers.
7678         * amd64-obsd-tdep.c: Sort headers.
7679         * amd64-obsd-nat.c: Sort headers.
7680         * amd64-nbsd-tdep.c: Sort headers.
7681         * amd64-nbsd-nat.c: Sort headers.
7682         * amd64-nat.c: Sort headers.
7683         * amd64-linux-tdep.c: Sort headers.
7684         * amd64-linux-nat.c: Sort headers.
7685         * amd64-fbsd-tdep.c: Sort headers.
7686         * amd64-fbsd-nat.c: Sort headers.
7687         * amd64-dicos-tdep.c: Sort headers.
7688         * amd64-darwin-tdep.c: Sort headers.
7689         * amd64-bsd-nat.c: Sort headers.
7690         * alpha-tdep.c: Sort headers.
7691         * alpha-obsd-tdep.c: Sort headers.
7692         * alpha-nbsd-tdep.c: Sort headers.
7693         * alpha-mdebug-tdep.c: Sort headers.
7694         * alpha-linux-tdep.c: Sort headers.
7695         * alpha-linux-nat.c: Sort headers.
7696         * alpha-bsd-tdep.c: Sort headers.
7697         * alpha-bsd-nat.c: Sort headers.
7698         * aix-thread.c: Sort headers.
7699         * agent.c: Sort headers.
7700         * addrmap.c: Sort headers.
7701         * ada-varobj.c: Sort headers.
7702         * ada-valprint.c: Sort headers.
7703         * ada-typeprint.c: Sort headers.
7704         * ada-tasks.c: Sort headers.
7705         * ada-lang.c: Sort headers.
7706         * aarch64-tdep.c: Sort headers.
7707         * aarch64-ravenscar-thread.c: Sort headers.
7708         * aarch64-newlib-tdep.c: Sort headers.
7709         * aarch64-linux-tdep.c: Sort headers.
7710         * aarch64-linux-nat.c: Sort headers.
7711         * aarch64-fbsd-tdep.c: Sort headers.
7712         * aarch64-fbsd-nat.c: Sort headers.
7713         * aarch32-linux-nat.c: Sort headers.
7714
7715 2019-04-04  Tom Tromey  <tom@tromey.com>
7716
7717         * varobj.c (varobj_create): Update.
7718         * rust-exp.y (struct rust_parser) <update_innermost_block,
7719         lookup_symbol>: New methods.
7720         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7721         Rename.
7722         (rust_parser::rust_lookup_type)
7723         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7724         * printcmd.c (display_command, do_one_display): Update.
7725         * parser-defs.h (struct parser_state) <parser_state>: Add
7726         "tracker" parameter.
7727         (block_tracker): New member.
7728         (class innermost_block_tracker) <innermost_block_tracker>: Add
7729         "types" parameter.
7730         <reset>: Remove method.
7731         (innermost_block): Don't declare.
7732         (null_post_parser): Update.
7733         * parse.c (innermost_block): Remove global.
7734         (write_dollar_variable): Update.
7735         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7736         Remove "tracker_types" parameter.
7737         (parse_expression): Add "tracker" parameter.
7738         (parse_expression_for_completion): Update.
7739         (null_post_parser): Add "tracker" parameter.
7740         * p-exp.y: Update rules.
7741         * m2-exp.y: Update rules.
7742         * language.h (struct language_defn) <la_post_parser>: Add
7743         "tracker" parameter.
7744         * go-exp.y: Update rules.
7745         * f-exp.y: Update rules.
7746         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7747         parameter.
7748         * d-exp.y: Update rules.
7749         * c-exp.y: Update rules.
7750         * breakpoint.c (set_breakpoint_condition): Create an
7751         innermost_block_tracker.
7752         (watch_command_1): Likewise.
7753         * ada-lang.c (resolve): Add "tracker" parameter.
7754         (resolve_subexp): Likewise.
7755         * ada-exp.y (write_var_from_sym): Update.
7756
7757 2019-04-04  Tom Tromey  <tom@tromey.com>
7758
7759         * type-stack.h: New file.
7760         * type-stack.c: New file.
7761         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7762         type-stack.h.
7763         (insert_into_type_stack, insert_type, push_type, push_type_int)
7764         (insert_type_address_space, pop_type, pop_type_int)
7765         (pop_typelist, pop_type_stack, append_type_stack)
7766         (push_type_stack, get_type_stack, push_typelist)
7767         (follow_type_instance_flags, follow_types): Don't declare.
7768         * parse.c (type_stack): Remove global.
7769         (parse_exp_in_context): Update.
7770         (insert_into_type_stack, insert_type, push_type, push_type_int)
7771         (insert_type_address_space, pop_type, pop_type_int)
7772         (pop_typelist, pop_type_stack, append_type_stack)
7773         (push_type_stack, get_type_stack, push_typelist)
7774         (follow_type_instance_flags, follow_types): Remove (moved to
7775         type-stack.c).
7776         * f-exp.y (type_stack): New global.
7777         Update rules.
7778         (push_kind_type, f_parse): Update.
7779         * d-exp.y (type_stack): New global.
7780         Update rules.
7781         (d_parse): Update.
7782         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7783         Update rules.
7784         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7785         (HFILES_NO_SRCDIR): Add type-stack.h.
7786
7787 2019-04-04  Tom Tromey  <tom@tromey.com>
7788
7789         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7790         (rust_parser::convert_ast_to_expression, rust_parse)
7791         (rust_lex_test_completion, rust_lex_tests): Update.
7792         * parser-defs.h (struct expr_completion_state): New.
7793         (struct parser_state) <parser_state>: Add completion parameter.
7794         <mark_struct_expression, mark_completion_tag>: New methods.
7795         <parse_completion, m_completion_state>: New members.
7796         (prefixify_expression, null_post_parser): Update.
7797         (mark_struct_expression, mark_completion_tag): Don't declare.
7798         * parse.c (parse_completion, expout_last_struct)
7799         (expout_tag_completion_type, expout_completion_name): Remove
7800         globals.
7801         (parser_state::mark_struct_expression)
7802         (parser_state::mark_completion_tag): Now methods.
7803         (prefixify_expression): Add last_struct parameter.
7804         (prefixify_subexp): Likewise.
7805         (parse_exp_1): Update.
7806         (parse_exp_in_context): Add cstate parameter.  Update.
7807         (parse_expression_for_completion): Create an
7808         expr_completion_state.
7809         (null_post_parser): Add "completion" parameter.
7810         * p-exp.y: Update rules.
7811         (yylex): Update.
7812         * language.h (struct language_defn) <la_post_parser>: Add
7813         "completing" parameter.
7814         * go-exp.y: Update rules.
7815         (lex_one_token): Update.
7816         * expression.h (parse_completion): Don't declare.
7817         * d-exp.y: Update rules.
7818         (lex_one_token): Update rules.
7819         * c-exp.y: Update rules.
7820         (lex_one_token): Update.
7821         * ada-lang.c (resolve): Add "parse_completion" parameter.
7822         (resolve_subexp): Likewise.
7823         (ada_resolve_function): Likewise.
7824
7825 2019-04-04  Tom Tromey  <tom@tromey.com>
7826
7827         * parser-defs.h (struct parser_state) <start_arglist,
7828         end_arglist>: New methods.
7829         <arglist_len, m_funcall_chain>: New members.
7830         (arglist_len, start_arglist, end_arglist): Don't declare.
7831         * parse.c (arglist_len, funcall_chain): Remove global.
7832         (start_arglist, end_arglist): Remove functions.
7833         (parse_exp_in_context): Update.
7834         * p-exp.y: Update rules.
7835         * m2-exp.y: Update rules.
7836         * go-exp.y: Update rules.
7837         * f-exp.y: Update rules.
7838         * d-exp.y: Update rules.
7839         * c-exp.y: Update rules.
7840
7841 2019-04-04  Tom Tromey  <tom@tromey.com>
7842
7843         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7844         lex_operator, push_back>: New methods.
7845         Update all rules.
7846         (rust_parser::lex_hex, lex_escape): Rename and update.
7847         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7848         (rust_parser::lex_operator): Rename and update.
7849         (rust_parser::lex_number, rustyylex, rustyyerror)
7850         (rust_lex_test_init, rust_lex_test_sequence)
7851         (rust_lex_test_push_back, rust_lex_tests): Update.
7852         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7853         parameter.
7854         <lexptr, prev_lexptr>: New members.
7855         (lexptr, prev_lexptr): Don't declare.
7856         * parse.c (lexptr, prev_lexptr): Remove globals.
7857         (parse_exp_in_context): Update.
7858         * p-exp.y (yylex, yyerror): Update.
7859         * m2-exp.y (parse_number, yylex, yyerror): Update.
7860         * go-exp.y (lex_one_token, yyerror): Update.
7861         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7862         * d-exp.y (lex_one_token, yyerror): Update.
7863         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7864         (lex_one_token, yyerror): Update.
7865         * ada-lex.l (YY_INPUT): Update.
7866         (rewind_to_char): Update.
7867         * ada-exp.y (yyerror): Update.
7868
7869 2019-04-04  Tom Tromey  <tom@tromey.com>
7870
7871         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7872         * parser-defs.h (struct parser_state) <parser_state>: Add new
7873         parameter.
7874         <comma_terminates>: New member.
7875         (comma_terminates): Don't declare global.
7876         * parse.c (comma_terminates): Remove global.
7877         (parse_exp_in_context): Update.
7878         * p-exp.y (yylex): Update.
7879         * m2-exp.y (yylex): Update.
7880         * go-exp.y (lex_one_token): Update.
7881         * f-exp.y (yylex): Update.
7882         * d-exp.y (lex_one_token): Update.
7883         * c-exp.y (lex_one_token): Update.
7884         * ada-lex.l: Update.
7885
7886 2019-04-04  Tom Tromey  <tom@tromey.com>
7887
7888         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7889         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7890         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7891         * parser-defs.h (paren_depth): Don't declare.
7892         * parse.c (paren_depth): Remove global.
7893         (parse_exp_in_context): Update.
7894         * p-exp.y (paren_depth): New global.
7895         (pascal_parse): Initialize it.
7896         * m2-exp.y (paren_depth): New global.
7897         (m2_parse): Initialize it.
7898         * go-exp.y (paren_depth): New global.
7899         (go_parse): Initialize it.
7900         * f-exp.y (paren_depth): New global.
7901         (f_parse): Initialize it.
7902         * d-exp.y (paren_depth): New global.
7903         (d_parse): Initialize it.
7904         * c-exp.y (paren_depth): New global.
7905         (c_parse): Initialize it.
7906         * ada-lex.l (paren_depth): New global.
7907         (lexer_init): Initialize it.
7908
7909 2019-04-04  Tom Tromey  <tom@tromey.com>
7910
7911         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7912         (rust_parser::convert_ast_to_type)
7913         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7914         * parser-defs.h (struct parser_state) <parser_state>: Add
7915         parameters.  Initialize new members.
7916         <expression_context_block, expression_context_pc>: New members.
7917         * parse.c (expression_context_block, expression_context_pc):
7918         Remove globals.
7919         (parse_exp_in_context): Update.
7920         * p-exp.y: Update all rules.
7921         (yylex): Update.
7922         * m2-exp.y: Update all rules.
7923         (yylex): Update.
7924         * go-exp.y (yylex): Update.
7925         * f-exp.y (yylex): Update.
7926         * d-exp.y: Update all rules.
7927         (yylex): Update.
7928         * c-exp.y: Update all rules.
7929         (lex_one_token, classify_name, yylex, c_parse): Update.
7930         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7931
7932 2019-04-04  Tom Tromey  <tom@tromey.com>
7933
7934         * gdbarch.h, gdbarch.c: Rebuild.
7935         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7936         * stap-probe.h:
7937         (struct stap_parse_info): Replace "parser_state" with
7938         "expr_builder".
7939         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7940         (parser_state): New class.
7941         * parse.c (expr_builder): Rename.
7942         (expr_builder::release): Rename.
7943         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7944         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7945         (write_exp_elt_longcst, write_exp_elt_floatcst)
7946         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7947         (write_exp_string_vector, write_exp_bitstring)
7948         (write_exp_msymbol, mark_struct_expression)
7949         (write_dollar_variable)
7950         (insert_type_address_space, increase_expout_size): Replace
7951         "parser_state" with "expr_builder".
7952         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7953         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7954         "parser_state" with "expr_builder".
7955
7956 2019-04-04  Tom Tromey  <tom@tromey.com>
7957
7958         * rust-exp.y: Replace "parse_language" with method call.
7959         * p-exp.y:
7960         (yylex): Replace "parse_language" with method call.
7961         * m2-exp.y:
7962         (yylex): Replace "parse_language" with method call.
7963         * go-exp.y (classify_name): Replace "parse_language" with method
7964         call.
7965         * f-exp.y (yylex): Replace "parse_language" with method call.
7966         * d-exp.y (lex_one_token): Replace "parse_language" with method
7967         call.
7968         * c-exp.y:
7969         (lex_one_token, classify_name, yylex): Replace "parse_language"
7970         with method call.
7971         * ada-exp.y (find_primitive_type, type_char)
7972         (type_system_address): Replace "parse_language" with method call.
7973
7974 2019-04-04  Tom Tromey  <tom@tromey.com>
7975
7976         * rust-exp.y: Replace "parse_gdbarch" with method call.
7977         * parse.c (write_dollar_variable, insert_type_address_space):
7978         Replace "parse_gdbarch" with method call.
7979         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7980         call.
7981         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7982         call.
7983         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7984         "parse_gdbarch" with method call.
7985         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7986         with method call.
7987         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7988         "parse_gdbarch" with method call.
7989         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7990         "parse_gdbarch" with method call.
7991         * c-exp.y (parse_type, parse_number, classify_name): Replace
7992         "parse_gdbarch" with method call.
7993         * ada-lex.l: Replace "parse_gdbarch" with method call.
7994         * ada-exp.y (parse_type, find_primitive_type, type_char)
7995         (type_system_address): Replace "parse_gdbarch" with method call.
7996
7997 2019-04-04  Tom Tromey  <tom@tromey.com>
7998
7999         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8000         * stap-probe.c (stap_parse_argument): Update.
8001         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8002         initial_size parameter.
8003         * rust-exp.y (rust_lex_tests): Update.
8004         * parse.c (parser_state): Update.
8005         (parse_exp_in_context): Update.
8006         * parser-defs.h (struct parser_state) <parser_state>: Remove
8007         "initial_size" parameter.
8008
8009 2019-04-04  Tom Tromey  <tom@tromey.com>
8010
8011         * parser-defs.h (increase_expout_size): Don't declare.
8012         * parse.c (increase_expout_size): Now static.
8013
8014 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8015
8016         * gnu-nat.c (gnu_nat_target::wait): Fix
8017         target_waitstatus_to_string call.
8018
8019 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8020
8021         * eval.c (evaluate_subexp_standard): Handle internal functions
8022         during Fortran function call handling.
8023
8024 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8025
8026         * NEWS: Mention new internal functions.
8027         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8028         (read_base_type): Use dwarf2_init_complex_target_type.
8029         * value.c (creal_internal_fn): New function.
8030         (cimag_internal_fn): New function.
8031         (_initialize_values): Register new internal functions.
8032
8033 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8034
8035         * infrun.c (stop_all_threads): If debug_infrun, always
8036         trace the wait status after wait_one, using
8037         target_waitstatus_to_string and target_pid_to_str.
8038         (handle_inferior_event): Replace various trace of
8039         wait status kind by a single trace.
8040         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8041         wait status kind image by target_waitstatus_to_string.
8042         * target/waitstatus.c (target_waitstatus_to_string): Fix
8043         obsolete comment.
8044
8045 2019-04-01  Tom Tromey  <tromey@adacore.com>
8046
8047         PR symtab/23331:
8048         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8049
8050 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8051             Pedro Alves  <palves@redhat.com>
8052
8053         * top.c (quit_force): Call 'finalize_values'.
8054         * value.c (finalize_values): New function.
8055         * value.h (finalize_values): Declare.
8056
8057 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8058
8059         * NEWS: Announce $_gdb_major and $_gdb_minor.
8060
8061         * top.c (init_gdb_version_vars): New function.
8062         (gdb_init): Call init_gdb_version_vars.
8063
8064 2019-03-29  Tom Tromey  <tromey@adacore.com>
8065
8066         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8067         help text.  Remove dead code.
8068
8069 2019-03-29  Keith Seitz  <keiths@redhat.com>
8070
8071         From Siddhesh Poyarekar:
8072         * f-lang.h (f77_get_upperbound): Return LONGEST.
8073         (f77_get_lowerbound): Likewise.
8074         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8075         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8076         print them.
8077         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8078         plongest to format print it.
8079         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8080         (f77_get_upperbound): Likewise.
8081         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8082         LOWER_BOUND to LONGEST.
8083         (f77_create_arrayprint_offset_tbl): Likewise.
8084
8085 2019-03-29  Keith Seitz  <keiths@redhat.com>
8086
8087         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8088         %s/pulongest for TYPE_LENGTH instead of %d in format
8089         strings.
8090         * ada-typerint.c (ada_print_type): Likewise.
8091         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8092         * compile/compile-c-support.c (generate_register_struct): Likewise.
8093         * gdbtypes.c (recursive_dump_type): Likewise.
8094         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8095         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8096         instead of %d in format strings.
8097         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8098         to std::min to ULONGEST.
8099         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8100         instead of %d in format strings.
8101         * tracepoint.c (info_scope_command): Likewise.
8102         * typeprint.c (print_offset_data::update)
8103         (print_offset_data::finish): Likewise.
8104         * xtensa-tdep.c (xtensa_store_return_value)
8105         (xtensa_push_dummy_call): Likewise.
8106
8107 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8108
8109         * windows-nat.c (display_selector): Fixed format specifications
8110         for 64-bit Cygwin.
8111
8112 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8113
8114         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8115
8116 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8117
8118         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8119         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8120         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8121         (nios2_linux_init_abi): Install it.
8122
8123 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8124
8125         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8126
8127 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8128
8129         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8130
8131 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8132             Tom Tromey  <tromey@adacore.com>
8133
8134         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8135
8136 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8137
8138         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8139         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8140         method to compute the bounds of range types. Also print "[evaluated]"
8141         if the bounds' values come from a dynamic evaluation.
8142
8143 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8144
8145         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8146         whitespace when pretty printing is on.
8147
8148 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8149
8150         * ppc-linux-nat.c: Add include.
8151
8152 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8153
8154         * NEWS: Mention AArch64 Pointer Authentication.
8155
8156 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8157
8158         * arm-linux-nat.c: Add include.
8159
8160 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8161
8162         * source-cache.c (source_cache::get_source_lines): Re-read
8163         fullname after calling open_source_file.
8164
8165 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8166
8167         * NEWS: Mention TLS support for FreeBSD.
8168
8169 2019-03-25  Tom Tromey  <tromey@adacore.com>
8170
8171         * minsyms.c (BUNCH_SIZE): Update comment.
8172         (~minimal_symbol_reader): Remove old comment.
8173         (compact_minimal_symbols): Update comment.
8174         (minimal_symbol_reader::install): Remove old comment.  Update
8175         other comments.
8176
8177 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8178
8179         * s390-linux-nat.c: Add include.
8180
8181 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8182
8183         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8184         Call linux_get_hwcap.
8185         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8186         Likewise.
8187         (aarch64_linux_get_hwcap): Remove function.
8188         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8189         declaration.
8190         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8191         linux_get_hwcap.
8192         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8193         * linux-tdep.c (linux_get_hwcap): Add function.
8194         (linux_get_hwcap2): Likewise.
8195         * linux-tdep.h (linux_get_hwcap): Add declaration.
8196         (linux_get_hwcap2): Likewise.
8197         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8198         (ppc_linux_get_hwcap2): Likewise.
8199         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8200         linux_get_hwcap.
8201         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8202         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8203         (ppc_linux_nat_target::read_description): Likewise.
8204         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8205         * s390-linux-nat.c: Likewise.
8206         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8207
8208 2019-03-24  Tom Tromey  <tom@tromey.com>
8209
8210         * ada-lang.c (standard_lookup): Simplify initialization.
8211         (ada_lookup_symbol_nonlocal): Simplify return.
8212         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8213         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8214         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8215         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8216         initialization.
8217         * solib.c (solib_global_lookup): Simplify.
8218         * symtab.c (null_block_symbol): Remove.
8219         (symbol_cache_lookup): Simplify returns.
8220         (lookup_language_this): Simplify returns.
8221         (lookup_symbol_aux): Simplify return.
8222         (lookup_local_symbol): Simplify returns.
8223         (lookup_global_symbol_from_objfile): Simplify return.
8224         (lookup_symbol_in_objfile_symtabs)
8225         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8226         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8227         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8228         * cp-namespace.c (cp_lookup_bare_symbol)
8229         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8230         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8231         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8232         (cp_lookup_symbol_via_imports): Simplify initialization.
8233         (find_symbol_in_baseclass): Likewise.
8234         * symtab.h (null_block_symbol): Remove.
8235         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8236         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8237         (d_lookup_symbol_module): Likewise.
8238         (find_symbol_in_baseclass): Simplify initialization.
8239
8240 2019-03-24  Tom Tromey  <tom@tromey.com>
8241
8242         * expression.h: Don't include symtab.h.
8243         (struct block): Forward declare.
8244
8245 2019-03-24  Tom Tromey  <tom@tromey.com>
8246
8247         * c-exp.y (typebase): Remove casts.
8248         * gdbtypes.c (lookup_unsigned_typename, )
8249         (lookup_signed_typename): Remove cast.
8250         * eval.c (parse_to_comma_and_eval): Remove cast.
8251         * parse.c (write_dollar_variable): Remove cast.
8252         * block.h (struct block) <superblock>: Now const.
8253         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8254         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8255         (map_block): Make "block" const.
8256         * symfile.h (struct quick_symbol_functions)
8257         <map_matching_symbols>: Constify block argument to "callback".
8258         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8259         const.
8260         (find_pc_sect_compunit_symtab): Make "b" const.
8261         (find_symbol_at_address): Likewise.
8262         (search_symbols): Likewise.
8263         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8264         (dw2_debug_names_lookup_symbol): Likewise.
8265         (dw2_map_matching_symbols): Update.
8266         * p-valprint.c (pascal_val_print): Remove "block".
8267         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8268         (aux_add_nonlocal_symbols): Make "block" const.
8269         (resolve_subexp): Remove cast.
8270         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8271         const.
8272         (iterate_over_file_blocks): Likewise.
8273         * f-exp.y (%union) <bval>: Remove.
8274         * coffread.c (patch_opaque_types): Make "b" const.
8275         * spu-tdep.c (spu_catch_start): Make "block" const.
8276         * c-valprint.c (print_unpacked_pointer): Remove "block".
8277         * symmisc.c (dump_symtab_1): Make "b" const.
8278         (block_depth): Make "block" const.
8279         * d-exp.y (%union) <bval>: Remove.
8280         * cp-support.h (cp_lookup_rtti_type): Update.
8281         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8282         * psymtab.c (psym_lookup_symbol): Make "block" const.
8283         (maintenance_check_psymtabs): Make "b" const.
8284         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8285         (enumerate_locals, enumerate_args): Update.
8286         * python/py-symtab.c (stpy_global_block): Make "block" const.
8287         (stpy_static_block): Likewise.
8288         * inline-frame.c (block_starting_point_at): Make "new_block"
8289         const.
8290         * block.c (find_block_in_blockvector): Make return type const.
8291         (blockvector_for_pc_sect): Make "b" const.
8292         (find_block_in_blockvector): Make "b" const.
8293
8294 2019-03-23  Tom Tromey  <tom@tromey.com>
8295
8296         * varobj.c (varobj_create): Update.
8297         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8298         * printcmd.c (display_command, do_one_display): Don't reset
8299         innermost_block.
8300         * parser-defs.h (enum innermost_block_tracker_type): Move to
8301         expression.h.
8302         (innermost_block): Update comment.
8303         * parse.c (parse_exp_1): Add tracker_types parameter.
8304         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8305         tracker_types parameter.  Reset innermost_block.
8306         (parse_exp_in_context): Remove.
8307         (parse_expression_for_completion): Update.
8308         * objfiles.c (~objfile): Don't reset expression_context_block or
8309         innermost_block.
8310         * expression.h (enum innermost_block_tracker_type): Move from
8311         parser-defs.h.
8312         (parse_exp_1): Add tracker_types parameter.
8313         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8314         reset innermost_block.
8315
8316 2019-03-23  Tom Tromey  <tom@tromey.com>
8317
8318         * objfiles.h: Include bcache.h.
8319
8320 2019-03-23  Tom Tromey  <tom@tromey.com>
8321
8322         * linespec.c (get_current_search_block): Use
8323         scoped_restore_current_language.
8324         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8325
8326 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8327             Jiong Wang  <jiong.wang@arm.com>
8328
8329         * aarch64-linux-tdep.c
8330         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8331         section.
8332         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8333
8334 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8335             Jiong Wang  <jiong.wang@arm.com>
8336
8337         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8338         instructions.
8339         (aarch64_analyze_prologue_test): Add PACIASP test.
8340         (aarch64_prologue_prev_register): Unmask PC value.
8341
8342 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8343             Jiong Wang  <jiong.wang@arm.com>
8344
8345         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8346         (aarch64_dwarf2_prev_register): Unmask PC value.
8347         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8348         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8349         DW_CFA_AARCH64_negate_ra_state.
8350         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8351
8352 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8353             Jiong Wang  <jiong.wang@arm.com>
8354
8355         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8356         registers.
8357         (aarch64_pseudo_register_name): Likewise.
8358         (aarch64_pseudo_register_type): Likewise.
8359         (aarch64_pseudo_register_reggroup_p): Likewise.
8360         (aarch64_gdbarch_init): Add pauth registers.
8361         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8362         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8363         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8364         (struct gdbarch_tdep): Add regnum for ra_state.
8365
8366 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8367             Jiong Wang  <jiong.wang@arm.com>
8368
8369         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8370
8371 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8372             Jiong Wang  <jiong.wang@arm.com>
8373
8374         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8375         function.
8376         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8377         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8378         (aarch64_gdbarch_init): Add puth registers.
8379         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8380         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8381         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8382
8383 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8384             Jiong Wang  <jiong.wang@arm.com>
8385
8386         * aarch64-linux-nat.c
8387         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8388         * aarch64-linux-tdep.c
8389         (aarch64_linux_core_read_description): Likewise.
8390         (aarch64_linux_get_hwcap): New function.
8391         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8392         (aarch64_linux_get_hwcap): New declaration.
8393
8394 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8395             Jiong Wang  <jiong.wang@arm.com>
8396
8397         * aarch64-linux-nat.c
8398         (aarch64_linux_nat_target::read_description): Add pauth param.
8399         * aarch64-linux-tdep.c
8400         (aarch64_linux_core_read_description): Likewise.
8401         * aarch64-tdep.c (struct target_desc): Add in pauth.
8402         (aarch64_read_description): Add pauth param.
8403         (aarch64_gdbarch_init): Likewise.
8404         * aarch64-tdep.h (aarch64_read_description): Likewise.
8405         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8406         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8407         * features/Makefile: Add new files.
8408         * features/aarch64-pauth.c: New file.
8409         * features/aarch64-pauth.xml: New file.
8410
8411 2019-03-20  Tom Tromey  <tromey@adacore.com>
8412
8413         * infrun.c (handle_inferior_event): Rename from
8414         handle_inferior_event_1.  Create a scoped_value_mark.
8415         (handle_inferior_event): Remove.
8416
8417 2019-03-19  Tom Tromey  <tromey@adacore.com>
8418
8419         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8420         * infrun.h (print_stop_event): Add "displays" parameter.
8421         * infrun.c (print_stop_event): Add "displays" parameter.
8422
8423 2019-03-19  Pedro Alves  <palves@redhat.com>
8424
8425         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8426         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8427         to -1.  Fix TABs vs spaces.
8428         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8429         * tui/tui-out.h (tui_ui_out) Add intro comments.
8430         <m_line, m_start_of_line>: In-class initialize, and add describing
8431         comment.
8432
8433 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8434
8435         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8436         variable names.
8437         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8438
8439 2019-03-18  Pedro Alves  <palves@redhat.com>
8440             Eli Zaretskii <eliz@gnu.org>
8441
8442         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8443         m_line and m_start_of_line.
8444
8445 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8446
8447         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8448         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8449         it returns a newline.  This fixes a regression in TU mode, whereby
8450         the next line is output on the same screen line as the user input.
8451
8452 2019-03-18  Tom Tromey  <tromey@adacore.com>
8453
8454         * minsyms.c (minimal_symbol_reader::install): Remove call to
8455         obstack_blank.
8456
8457 2019-03-18  Pedro Alves  <palves@redhat.com>
8458
8459         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8460         New globals.
8461         (apply_style): New, factored out from ...
8462         (apply_ansi_escape): ... this.  Handle reverse video mode.
8463         (tui_set_reverse_mode): New function.
8464         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8465         * tui/tui-winsource.c (tui_show_source_line): Use
8466         tui_set_reverse_mode instead of setting A_STANDOUT.
8467         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8468         New setter methods.
8469
8470 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8471
8472         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8473         Handle tabs.
8474
8475 2019-03-18  Tom Tromey  <tromey@adacore.com>
8476
8477         * ada-lang.c (empty_array): Add "high" parameter.
8478         (ada_evaluate_subexp): Update.
8479
8480 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8481
8482         * unittests/string_view-selftests.c: Define
8483         _initialize_string_view_selftests unconditionally.
8484
8485 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8486
8487         PR gdb/24350
8488         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8489
8490 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8491
8492         PR gdb/24351
8493         * windows-nat.c (display_selector): Fix format specifiers.
8494
8495 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8496
8497         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8498         tui_refill_source_window instead of tui_refresh_win, to update the
8499         current execution line.  This fixes redisplay of the current line
8500         when stepping through the code with "next" or "step".
8501
8502 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8503
8504         * source-cache.c (source_cache::get_source_lines): Call
8505         find_source_lines to initialize s->nlines.  This fixes vertical
8506         scrolling of TUI source window when the DOWN arrow is pressed.
8507
8508 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8509
8510         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8511         linux-thread-db.c (_initialize_thread_db): Likewise.
8512
8513 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8514
8515         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8516         wclrtoeol in tui_show_source_line".  This reverts changes made in
8517         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8518
8519 2019-03-15  Tom Tromey  <tom@tromey.com>
8520
8521         * symtab.h (struct minimal_symbol): Derive from
8522         general_symbol_info.
8523         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8524         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8525         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8526         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8527         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8528         (MSYMBOL_SEARCH_NAME): Update.
8529         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8530         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8531         * minsyms.c (minimal_symbol_reader::record_full): Update.
8532
8533 2019-03-15  Tom Tromey  <tom@tromey.com>
8534
8535         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8536
8537 2019-03-15  Tom Tromey  <tom@tromey.com>
8538
8539         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8540         unique_xmalloc_ptr.
8541         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8542         Update.
8543         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8544         (build_minimal_symbol_hash_tables)
8545         (minimal_symbol_reader::install): Update.
8546
8547 2019-03-15  Tom Tromey  <tom@tromey.com>
8548
8549         * symtab.c (create_demangled_names_hash): Update.
8550         (symbol_set_names): Update.
8551         * objfiles.h (struct objfile_per_bfd_storage)
8552         <demangled_names_hash>: Now an htab_up.
8553         * objfiles.c (objfile_per_bfd_storage): Simplify.
8554
8555 2019-03-15  Tom Tromey  <tom@tromey.com>
8556
8557         * objfiles.h (struct objfile_per_bfd_storage): Declare
8558         destructor.
8559         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8560         New.
8561         (get_objfile_bfd_data): Use new.  Don't initialize
8562         language_of_main.
8563         (free_objfile_per_bfd_storage): Remove.
8564         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8565
8566 2019-03-15  Tom Tromey  <tom@tromey.com>
8567
8568         * symfile.c (reread_symbols): Update.
8569         * objfiles.c (objfile::objfile): Update.
8570         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8571         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8572         comment.
8573         (minimal_symbol_reader::install): Update.
8574         (terminate_minimal_symbol_table): Remove.
8575         * jit.c (jit_object_close_impl): Update.
8576
8577 2019-03-15  Tom Tromey  <tom@tromey.com>
8578
8579         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8580         initializations.
8581
8582 2019-03-15  Tom Tromey  <tom@tromey.com>
8583
8584         * objfiles.h (struct objfile_per_bfd_storage)
8585         <demangled_hash_languages>: Now a bitset.
8586         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8587         (lookup_minimal_symbol): Update.
8588
8589 2019-03-15  Tom Tromey  <tom@tromey.com>
8590
8591         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8592         Don't return the symbol.
8593         * coffread.c (record_minimal_symbol): Use record_full.
8594
8595 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8596
8597         The MS-Windows port of ncurses fails to switch to a color pair if
8598         one or both of the colors are the implicit default colors.  This
8599         change records the default colors when TUI is initialized, and
8600         then specifies them explicitly when a color pair uses the default
8601         colors.  This allows color styling in TUI mode on MS-Windows.
8602
8603         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8604         ncurses_norm_attr.
8605         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8606         colors in ncurses_norm_attr.
8607         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8608         "none", replace it with the default color recorded in
8609         ncurses_norm_attr.
8610
8611 2019-03-14  Tom Tromey  <tromey@adacore.com>
8612
8613         * source-cache.h (class source_cache) <get_source_lines>: Return
8614         std::string.
8615         * source-cache.c (source_cache::extract_lines): Handle case where
8616         first_pos==npos.  Return std::string.
8617         (source_cache::get_source_lines): Update.
8618
8619 2019-03-14  Tom Tromey  <tromey@adacore.com>
8620
8621         * NEWS: Add item for "style sources" commands.
8622         * source-cache.c (source_cache::get_source_lines): Check
8623         source_styling.
8624         * cli/cli-style.c (source_styling): New global.
8625         (_initialize_cli_style): Add "style sources" commands.
8626         (show_style_sources): New function.
8627         * cli/cli-style.h (source_styling): Declare.
8628
8629 2019-03-14  Pedro Alves  <palves@redhat.com>
8630             Tom Tromey  <tromey@adacore.com>
8631
8632         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8633         * tui/tui-winsource.c (tui_refill_source_window): New function,
8634         from...
8635         (tui_horizontal_source_scroll): ... here.  Move some logic.
8636         * cli/cli-style.c (set_style_enabled): Notify new observable.
8637         * tui/tui-hooks.c (tui_redisplay_source): New function.
8638         (tui_attach_detach_observers): Attach or detach
8639         tui_redisplay_source.
8640         * observable.h (source_styling_changed): New observable.
8641         * observable.c: Define source_styling_changed observable.
8642
8643 2019-03-13  Tom Tromey  <tromey@adacore.com>
8644
8645         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8646         (i386_gnu_nat_target::store_registers): Update.
8647         * target-debug.h (target_debug_print_std_string): New macro.
8648         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8649         * windows-tdep.c (display_one_tib): Update.
8650         * tui/tui-stack.c (tui_make_status_line): Update.
8651         * top.c (print_inferior_quit_action): Update.
8652         * thread.c (thr_try_catch_cmd): Update.
8653         (add_thread_with_info): Update.
8654         (thread_target_id_str): Update.
8655         (thr_try_catch_cmd): Update.
8656         (thread_command): Update.
8657         (thread_find_command): Update.
8658         * record-btrace.c (record_btrace_target::info_record)
8659         (record_btrace_resume_thread, record_btrace_target::resume)
8660         (record_btrace_cancel_resume, record_btrace_step_thread)
8661         (record_btrace_target::wait, record_btrace_target::wait)
8662         (record_btrace_target::wait, record_btrace_target::stop): Update.
8663         * progspace.c (print_program_space): Update.
8664         * process-stratum-target.c
8665         (process_stratum_target::thread_address_space): Update.
8666         * linux-fork.c (linux_fork_mourn_inferior)
8667         (detach_checkpoint_command, info_checkpoints_command)
8668         (linux_fork_context): Update.
8669         (linux_fork_detach): Update.
8670         (class scoped_switch_fork_info): Update.
8671         (delete_checkpoint_command): Update.
8672         * infrun.c (follow_fork_inferior): Update.
8673         (follow_fork_inferior): Update.
8674         (proceed_after_vfork_done): Update.
8675         (handle_vfork_child_exec_or_exit): Update.
8676         (follow_exec): Update.
8677         (displaced_step_prepare_throw): Update.
8678         (displaced_step_restore): Update.
8679         (start_step_over): Update.
8680         (resume_1): Update.
8681         (clear_proceed_status_thread): Update.
8682         (proceed): Update.
8683         (print_target_wait_results): Update.
8684         (do_target_wait): Update.
8685         (context_switch): Update.
8686         (stop_all_threads): Update.
8687         (restart_threads): Update.
8688         (finish_step_over): Update.
8689         (handle_signal_stop): Update.
8690         (switch_back_to_stepped_thread): Update.
8691         (keep_going_pass_signal): Update.
8692         (print_exited_reason): Update.
8693         (normal_stop): Update.
8694         * inferior.c (inferior_pid_to_str): Change return type.
8695         (print_selected_inferior): Update.
8696         (add_inferior): Update.
8697         (detach_inferior): Update.
8698         * dummy-frame.c (fprint_dummy_frames): Update.
8699         * dcache.c (dcache_info_1): Update.
8700         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8701         (btrace_fetch, btrace_clear): Update.
8702         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8703         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8704         type.
8705         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8706         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8707         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8708         * gdbarch.c, gdbarch.h: Rebuild.
8709         * gdbarch.sh (core_pid_to_str): Change return type.
8710         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8711         return type.
8712         (windows_nat_target::pid_to_str): Change return type.
8713         (windows_delete_thread): Update.
8714         (windows_nat_target::attach): Update.
8715         (windows_nat_target::files_info): Update.
8716         * target-delegates.c: Rebuild.
8717         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8718         return type.
8719         (sol_thread_target::pid_to_str): Change return type.
8720         * remote.c (class remote_target) <pid_to_str>: Change return
8721         type.
8722         (remote_target::pid_to_str): Change return type.
8723         (extended_remote_target::attach, remote_target::remote_stop_ns)
8724         (remote_target::remote_notif_remove_queued_reply)
8725         (remote_target::push_stop_reply, remote_target::disable_btrace):
8726         Update.
8727         (extended_remote_target::attach): Update.
8728         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8729         type.
8730         (gdbsim_target::pid_to_str): Change return type.
8731         * ravenscar-thread.c (struct ravenscar_thread_target)
8732         <pid_to_str>: Change return type.
8733         (ravenscar_thread_target::pid_to_str): Change return type.
8734         * procfs.c (class procfs_target) <pid_to_str>: Change return
8735         type.
8736         (procfs_target::pid_to_str): Change return type.
8737         (procfs_target::attach): Update.
8738         (procfs_target::detach): Update.
8739         (procfs_target::fetch_registers): Update.
8740         (procfs_target::store_registers): Update.
8741         (procfs_target::wait): Update.
8742         (procfs_target::files_info): Update.
8743         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8744         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8745         return type.
8746         (nto_procfs_target::pid_to_str): Change return type.
8747         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8748         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8749         return type.
8750         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8751         (exit_lwp): Update.
8752         (attach_proc_task_lwp_callback, get_detach_signal)
8753         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8754         (linux_nat_target::resume, wait_lwp, stop_callback)
8755         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8756         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8757         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8758         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8759         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8760         type.
8761         (inf_ptrace_target::attach): Update.
8762         (inf_ptrace_target::files_info): Update.
8763         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8764         type.
8765         (go32_nat_target::pid_to_str): Change return type.
8766         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8767         (gnu_nat_target::wait): Update.
8768         (gnu_nat_target::wait): Update.
8769         (gnu_nat_target::resume): Update.
8770         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8771         (fbsd_nat_target::wait): Update.
8772         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8773         type.
8774         (darwin_nat_target::attach): Update.
8775         * corelow.c (class core_target) <pid_to_str>: Change return type.
8776         (core_target::pid_to_str): Change return type.
8777         * target.c (normal_pid_to_str): Change return type.
8778         (default_pid_to_str): Likewise.
8779         (target_pid_to_str): Change return type.
8780         (target_translate_tls_address): Update.
8781         (target_announce_detach): Update.
8782         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8783         return type.
8784         (bsd_uthread_target::pid_to_str): Change return type.
8785         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8786         type.
8787         (bsd_kvm_target::pid_to_str): Change return type.
8788         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8789         return type.
8790         (aix_thread_target::pid_to_str): Change return type.
8791         * target.h (struct target_ops) <pid_to_str>: Change return type.
8792         (target_pid_to_str, normal_pid_to_str): Likewise.
8793         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8794         type.
8795         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8796         type.
8797         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8798         return type.
8799         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8800         type.
8801         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8802         type.
8803         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8804         return type.
8805
8806 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8807
8808         * NEWS: Mention that the new default MI version is 3.  Mention
8809         changes to the output of commands and events that deal with
8810         multi-location breakpoints.
8811         * breakpoint.c: Include "mi/mi-out.h".
8812         (print_one_breakpoint): Change output syntax if using MI version
8813         >= 3.
8814         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8815         New.
8816         (mi_multi_location_breakpoint_output_fixed): New.
8817         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8818         (mi_cmd_fix_multi_location_breakpoint_output): New.
8819         (mi_multi_location_breakpoint_output_fixed): New.
8820         * mi/mi-cmds.c (mi_cmds): Register command
8821         -fix-multi-location-breakpoint-output.
8822         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8823         interpreter "mi".
8824
8825 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8826
8827         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8828         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8829         instantiate mi_ui_out based on interpreter name.
8830         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8831         * mi/mi-main.c (mi_load_progress): Likewise.
8832
8833 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8834
8835         * NEWS: Combine separate "New targets" sections for 8.3.
8836
8837 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8838
8839         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8840         (ppcfbsd_init_abi): Install gdbarch
8841         "fetch_tls_load_module_address" and "get_thread_local_address"
8842         methods.
8843
8844 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8845
8846         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8847         (riscv_fbsd_init_abi): Install gdbarch
8848         "fetch_tls_load_module_address" and "get_thread_local_address"
8849         methods.
8850
8851 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8852
8853         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8854         (i386fbsd_init_abi): Install gdbarch
8855         "fetch_tls_load_module_address" and "get_thread_local_address"
8856         methods.
8857
8858 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8859
8860         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8861         (amd64fbsd_init_abi): Install gdbarch
8862         "fetch_tls_load_module_address" and "get_thread_local_address"
8863         methods.
8864
8865 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8866
8867         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8868         (struct fbsd_pspace_data): New type.
8869         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8870         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8871         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8872         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8873         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8874
8875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8876
8877         * gdbtypes.c (lookup_struct_elt): New function.
8878         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8879         * gdbtypes.h (struct struct_elt): New type.
8880         (lookup_struct_elt): New prototype.
8881
8882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8883
8884         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8885         remove disabled code block.
8886
8887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8888
8889         * gdbarch.sh (get_thread_local_address): New method.
8890         * gdbarch.h, gdbarch.c: Regenerate.
8891         * target.c (target_translate_tls_address): Use
8892         gdbarch_get_thread_local_address if present instead of
8893         target::get_thread_local_address.
8894
8895 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8896
8897         * target.h (target::get_thread_local_address): Update comment.
8898
8899 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8900
8901         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8902         objfile->separate_debug_objfile_backlink if not NULL.
8903
8904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8905
8906         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8907         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8908         (amd64bsd_store_inferior_registers): Likewise.
8909         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8910         Enable segment base registers.
8911         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8912         PT_GETFSBASE and PT_GETGSBASE.
8913         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8914         PT_SETGSBASE.
8915         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8916         segment base registers.
8917         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8918
8919 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8920
8921         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8922         Update calls to i386_target_description to add 'segments'
8923         parameter.
8924         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8925         add segment base registers.
8926         * arch/i386.c (i386_create_target_description): Add 'segments'
8927         parameter to enable segment base registers.
8928         * arch/i386.h (i386_create_target_description): Likewise.
8929         * features/i386/32bit-segments.xml: New file.
8930         * features/i386/32bit-segments.c: Generate.
8931         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8932         call to i386_target_description to add 'segments' parameter.
8933         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8934         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8935         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8936         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8937         if feature is present.
8938         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8939         Add 'segments' parameter to call to i386_target_description.
8940         (i386_target_description): Add 'segments' parameter to enable
8941         segment base registers.
8942         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8943         to call to i386_target_description.
8944         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8945         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8946         Define I386_NUM_REGS.
8947         (i386_target_description): Add 'segments' parameter to enable
8948         segment base registers.
8949
8950 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8951
8952         PR/24325
8953         * source-cache.c: #undef open and close, to avoid unresolved
8954         externals during linking.
8955
8956 2019-03-12  Tom Tromey  <tromey@adacore.com>
8957
8958         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8959         const.  Add initializers.
8960         (_initialize_remote): Don't initialize ptid globals.
8961
8962 2019-03-12  Pedro Alves  <palves@redhat.com>
8963
8964         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8965
8966 2019-03-12  Pedro Alves  <palves@redhat.com>
8967
8968         * cp-name-parser.y (main): Remove unused 'len' variable.
8969
8970 2019-03-12  Tom Tromey  <tromey@adacore.com>
8971
8972         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8973         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8974
8975 2019-03-12  Tom Tromey  <tromey@adacore.com>
8976
8977         * linux-nat.c (iterate_over_lwps): Update.
8978         (stop_callback): Remove parameter.
8979         (stop_wait_callback, detach_callback, resume_set_callback)
8980         (select_singlestep_lwp_callback, set_ignore_sigint)
8981         (status_callback, resumed_callback, resume_clear_callback)
8982         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8983         data parameter.
8984         (linux_nat_target::detach, linux_nat_target::resume)
8985         (linux_stop_and_wait_all_lwps, select_event_lwp)
8986         (linux_nat_filter_event, linux_nat_wait_1)
8987         (linux_nat_target::kill, linux_nat_target::stop)
8988         (linux_nat_target::stop): Update.
8989         (linux_nat_resume_callback): Change type.
8990         (resume_stopped_resumed_lwps, count_events_callback)
8991         (select_event_lwp_callback): Likewise.
8992         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8993         * arm-linux-nat.c (struct update_registers_data): Remove.
8994         (update_registers_callback): Change type.
8995         (arm_linux_insert_hw_breakpoint1): Update.
8996         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8997         parameter.
8998         (x86_linux_dr_set_addr): Update.
8999         (x86_linux_dr_set_control): Update.
9000         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9001         (iterate_over_lwps): Use gdb::function_view.
9002         * nat/aarch64-linux-hw-point.c (struct
9003         aarch64_dr_update_callback_param): Remove.
9004         (debug_reg_change_callback): Change type.
9005         (aarch64_notify_debug_reg_change): Update.
9006         * s390-linux-nat.c (s390_refresh_per_info): Update.
9007
9008 2019-03-11  Tom Tromey  <tromey@adacore.com>
9009
9010         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9011         redundant assignment to "this_cu".
9012
9013 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9014
9015         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9016
9017 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9018
9019         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9020         from...
9021         (rank_one_type): ... this.
9022
9023 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9024
9025         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9026         from...
9027         (rank_one_type): ... this.
9028
9029 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9030
9031         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9032         from...
9033         (rank_one_type): ... this.
9034
9035 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9036
9037         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9038         from...
9039         (rank_one_type): ... this.
9040
9041 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9042
9043         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9044         from...
9045         (rank_one_type): ... this.
9046
9047 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9048
9049         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9050         from...
9051         (rank_one_type): ... this.
9052
9053 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9054
9055         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9056         from...
9057         (rank_one_type): ... this.
9058
9059 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9060
9061         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9062         from...
9063         (rank_one_type): ... this.
9064
9065 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9066
9067         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9068         from...
9069         (rank_one_type): ... this.
9070
9071 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9072
9073         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9074         from...
9075         (rank_one_type): ... this.
9076
9077 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9078
9079         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9080         from...
9081         (rank_one_type): ... this.
9082
9083 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9084
9085         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9086         from...
9087         (rank_one_type): ... this.
9088
9089 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9090
9091         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9092         inferior-events' shows the example events.
9093
9094 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9095
9096         Support styling on native MS-Windows console
9097
9098         PR/24315
9099         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9100         on MS-Windows if $TERM is not defined.
9101
9102         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9103
9104         * posix-hdep.c (gdb_console_fputs):
9105         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9106         functions.
9107         * ui-file.h (gdb_console_fputs): Add prototype.
9108
9109         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9110         back to fputs only if the former returns zero.
9111
9112 2019-03-07  Tom Tromey  <tom@tromey.com>
9113
9114         * symmisc.c (print_symbol_bcache_statistics): Update.
9115         (print_objfile_statistics): Update.
9116         * symfile.c (allocate_symtab): Update.
9117         * stabsread.c: Don't include bcache.h.
9118         * psymtab.h (struct psymbol_bcache): Don't declare.
9119         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9120         (psymbol_bcache_init, psymbol_bcache_free)
9121         (psymbol_bcache_get_bcache): Don't declare.
9122         * psymtab.c (struct psymbol_bcache): Remove.
9123         (psymtab_storage::psymtab_storage): Update.
9124         (psymtab_storage::~psymtab_storage): Update.
9125         (psymbol_bcache_init, psymbol_bcache_free)
9126         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9127         (add_psymbol_to_bcache): Update.
9128         (allocate_psymtab): Update.
9129         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9130         macro_cache>: No longer pointers.
9131         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9132         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9133         * macrotab.c (macro_bcache): Update.
9134         * macroexp.c: Don't include bcache.h.
9135         * gdbtypes.c (check_types_worklist): Update.
9136         (types_deeply_equal): Remove TRY/CATCH.  Update.
9137         * elfread.c (elf_symtab_read): Update.
9138         * dwarf2read.c: Don't include bcache.h.
9139         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9140         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9141         (print_bcache_statistics, bcache_memory_used): Don't declare.
9142         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9143         methods.  Rename all data members.
9144         * bcache.c (struct bcache): Move to bcache.h.
9145         (bcache::expand_hash_table): Rename from expand_hash_table.
9146         (bcache): Remove.
9147         (bcache::insert): Rename from bcache_full.
9148         (bcache::compare): Rename from bcache_compare.
9149         (bcache_xmalloc): Remove.
9150         (bcache::~bcache): Rename from bcache_xfree.
9151         (bcache::print_statistics): Rename from print_bcache_statistics.
9152         (bcache::memory_used): Rename from bcache_memory_used.
9153
9154 2019-03-07  Pedro Alves  <palves@redhat.com>
9155
9156         * infrun.c (normal_stop): Also check for
9157         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9158
9159 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9160
9161         * f-lang.c (value_from_host_double): Moved to...
9162         * value.c (value_from_host_double): ...here.
9163         * value.h (value_from_host_double): Declare.
9164         * guile/scm-math.c (vlscm_convert_typed_number): Use
9165         value_from_host_double.
9166         (vlscm_convert_number): Likewise.
9167         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9168         * python/py-value.c (convert_value_from_python): Likewise.
9169
9170 2019-03-06  Tom Tromey  <tom@tromey.com>
9171
9172         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9173
9174 2019-03-06  Tom Tromey  <tom@tromey.com>
9175
9176         * utils.h (free_current_contents): Don't declare.
9177         * utils.c (free_current_contents): Remove.
9178
9179 2019-03-06  Tom Tromey  <tom@tromey.com>
9180
9181         * top.c (quit_force): Update.
9182         * main.c (captured_command_loop): Update.
9183         * common/new-op.c (operator new): Update.
9184         * common/common-exceptions.c (struct catcher)
9185         <save_cleanup_chain>: Remove member.
9186         (exceptions_state_mc_init): Update.
9187         (exception_try_scope_entry): Return nullptr.
9188         (exception_try_scope_exit, exception_rethrow)
9189         (throw_exception_sjlj, throw_exception_cxx): Update.
9190         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9191         (all_cleanups, do_cleanups, discard_cleanups)
9192         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9193         (restore_cleanups, restore_final_cleanups): Don't declare.
9194         (do_final_cleanups): Remove parameter.
9195         * common/cleanups.c (cleanup_chain, make_cleanup)
9196         (make_cleanup_dtor, all_cleanups, do_cleanups)
9197         (discard_my_cleanups, discard_cleanups)
9198         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9199         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9200         (null_cleanup): Remove.
9201         (do_final_cleanups): Remove parameter.
9202
9203 2019-03-06  Tom Tromey  <tom@tromey.com>
9204
9205         * remote.c (remote_target::remote_parse_stop_reply): Use
9206         unique_xmalloc_ptr.
9207
9208 2019-03-06  Tom Tromey  <tom@tromey.com>
9209
9210         * stabsread.c (struct stabs_field_info): Rename from field_info.
9211         <list, fnlist>: Add initializers.
9212         <obstack>: New member.
9213         (read_member_functions, read_struct_fields, read_baseclasses):
9214         Allocate on obstack.  Don't use cleanups.
9215         (read_one_struct_field, read_member_functions, read_struct_fields)
9216         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9217         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9218         (read_struct_type): Update.
9219
9220 2019-03-06  Tom Tromey  <tom@tromey.com>
9221
9222         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9223         * common/filestuff.h (make_cleanup_close): Don't declare.
9224         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9225         Remove.
9226
9227 2019-03-06  Tom Tromey  <tom@tromey.com>
9228
9229         * solib-aix.c: Use make_scope_exit.
9230
9231 2019-03-06  Tom Tromey  <tom@tromey.com>
9232
9233         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9234         Use make_scope_exit.
9235
9236 2019-03-06  Tom Tromey  <tom@tromey.com>
9237
9238         * solib-svr4.c (disable_probes_interface): Remove parameter.
9239         (svr4_handle_solib_event): Use make_scope_exit.
9240
9241 2019-03-06  Tom Tromey  <tom@tromey.com>
9242
9243         * remote.c (struct stop_reply_deleter): Remove.
9244         (stop_reply_up): Update.
9245         (struct stop_reply): Derive from notif_event.  Don't typedef.
9246         <regcache>: Now a std::vector.
9247         (stop_reply_xfree): Remove.
9248         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9249         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9250         (remote_target::discard_pending_stop_replies): Use delete.
9251         (remote_target::remote_parse_stop_reply): Update.
9252         (remote_target::process_stop_reply): Update.
9253         * remote-notif.h (struct notif_event): Add virtual destructor.
9254         Remove "dtr" member.
9255         (struct notif_client) <alloc_event>: Return a unique_ptr.
9256         (notif_event_xfree): Don't declare.
9257         (notif_event_up): New typedef.
9258         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9259         (notif_event_xfree, do_notif_event_xfree): Remove.
9260         (remote_notif_state_xfree): Update.
9261
9262 2019-03-06  Tom Tromey  <tom@tromey.com>
9263
9264         * infrun.c (displaced_step_clear_cleanup): Now a
9265         forward_scope_exit type.
9266         (displaced_step_prepare_throw): Update.
9267         (displaced_step_fixup): Update.
9268
9269 2019-03-06  Tom Tromey  <tom@tromey.com>
9270
9271         * inferior.h (class inferior): Update comment.
9272         * gdbthread.h (class thread_info): Update comment.
9273
9274 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9275             Tom Tromey  <tom@tromey.com>
9276
9277         * stabsread.h (struct stab_section_list): Remove.
9278         (coffstab_build_psymtabs): Update.
9279         * dbxread.c (symbuf_sections): Now a std::vector.
9280         (sect_idx): New global.
9281         (fill_symbuf): Update.
9282         (coffstab_build_psymtabs): Change type of stabsects parameter.
9283         Update.
9284         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9285         std::vector.
9286         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9287         (coff_locate_sections): Update.
9288         (coff_symfile_read): Remove cleanups.  Update.
9289         (init_stringtab): Add storage parameter.
9290         (free_stringtab, free_stringtab_cleanup): Remove.
9291         (init_lineno): Add storage parameter.
9292         (free_linetab, free_linetab_cleanup): Remove.
9293
9294 2019-03-06  Pedro Alves  <palves@redhat.com>
9295
9296         * linux-fork.c (fork_info::clobber_regs): Delete.
9297         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9298         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9299         comment.  Adjust.
9300         (scoped_switch_fork_info::scoped_switch_fork_info)
9301         (checkpoint_command, linux_fork_context): Adjust
9302         fork_save_infrun_state calls.
9303
9304 2019-03-06  Pedro Alves  <palves@redhat.com>
9305
9306         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9307         (inf_has_multiple_threads): Return 'bool' and rewrite using
9308         inferior_info::threads().
9309
9310 2019-03-06  Pedro Alves  <palves@redhat.com>
9311
9312         * linux-fork.c: Include <list>.
9313         (fork_list): Now a std::list instance.
9314         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9315         (forks_exist_p, find_last_fork): Adjust.
9316         (new_fork): Delete.
9317         (one_fork_p): New.
9318         (add_fork): Adjust.
9319         (free_fork): Delete, folded into fork_info::~fork_info().
9320         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9321         Adjust.
9322         (init_fork_list): Delete.
9323         (linux_fork_killall, linux_fork_mourn_inferior)
9324         (linux_fork_detach, info_checkpoints_command): Adjust.
9325         (_initialize_linux_fork): No longer call init_fork_list.
9326
9327 2019-03-06  Pedro Alves  <palves@redhat.com>
9328
9329         * linux-fork.c (new_fork): New, split out of ...
9330         (add_fork): ... this.  Return void.  Move "first fork" special
9331         case from here, to ...
9332         (checkpoint_command): ... here.
9333         * linux-linux.h (add_fork): Return void.
9334
9335 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9336
9337         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9338
9339 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9340             Chris January  <chris.january@arm.com>
9341             David Lecomber  <david.lecomber@arm.com>
9342
9343         * f-exp.y: New token, UNOP_INTRINSIC.
9344         (exp): New pattern using UNOP_INTRINSIC token.
9345         (f77_keywords): Add 'abs' keyword.
9346         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9347         (value_from_host_double): New function.
9348         (evaluate_subexp_f): Support UNOP_ABS.
9349
9350 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9351
9352         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9353         types.
9354
9355 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9356
9357         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9358         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9359         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9360
9361 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9362
9363         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9364
9365 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9366             Chris January  <chris.january@arm.com>
9367
9368         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9369         * f-exp.y: Define 'KIND' token.
9370         (exp): New pattern for KIND expressions.
9371         (ptype): Handle types with a kind extension.
9372         (direct_abs_decl): Extend to spot kind extensions.
9373         (f77_keywords): Add 'kind' to the list.
9374         (push_kind_type): New function.
9375         (convert_to_kind_type): New function.
9376         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9377         * parse.c (operator_length_standard): Likewise.
9378         * parser-defs.h (enum type_pieces): Add tp_kind.
9379         * std-operator.def: Add UNOP_KIND.
9380
9381 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9382
9383         * f-exp.y (f_parse): Set yydebug.
9384
9385 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9386
9387         * f-lang.c (evaluate_subexp_f): New function.
9388         (exp_descriptor_f): New global.
9389         (f_language_defn): Use exp_descriptor_f instead of
9390         exp_descriptor_standard.
9391
9392 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9393
9394         * f-exp.y (struct token): Add comments.
9395         (dot_ops): Remove uppercase versions and the end marker.
9396         (f77_keywords): Likewise.
9397         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9398         entries in the dot_ops array are case insensitive, and use
9399         strncasecmp to compare strings.  Also some whitespace cleanup in
9400         this area.  Similar for the f77_keywords array, except entries in
9401         this list might be case sensitive.
9402
9403 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9404
9405         * f-exp.y (struct f77_boolean_val): Add comments.
9406         (boolean_values): Remove uppercase versions, and end marker.
9407         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9408         and use strncasecmp to achieve case insensitivity.  Additionally,
9409         perform whitespace cleanup around this code.
9410
9411 2019-03-06  Tom Tromey  <tromey@adacore.com>
9412
9413         * remote-sim.c (gdbsim_target_open): Use result of
9414         gdb_argv::release.
9415
9416 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9417         Dirk Schubert  <dirk.schubert@arm.com>
9418         Chris January  <chris.january@arm.com>
9419
9420         * eval.c (evaluate_subexp_standard): Call Fortran argument
9421         wrapping logic.
9422         * f-lang.c (struct value): A value which can be passed into a
9423         Fortran function call.
9424         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9425         where appropriate.
9426         (struct type): Value ready for a Fortran function call.
9427         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9428         is needed.
9429         * f-lang.h (fortran_argument_convert): Declaration.
9430         (fortran_preserve_arg_pointer): Declaration.
9431         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9432
9433 2019-03-05  Tom Tromey  <tromey@adacore.com>
9434
9435         * python/py-prettyprint.c (print_string_repr): Remove #if.
9436         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9437
9438 2019-03-05  Tom Tromey  <tromey@adacore.com>
9439
9440         * target.c (the_dummy_target): Move later.  Change type to
9441         "dummy_target".
9442         (initialize_targets): Don't initialize the_dummy_target.
9443
9444 2019-03-05  Tom Tromey  <tromey@adacore.com>
9445
9446         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9447         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9448
9449 2019-03-05  Tom Tromey  <tromey@adacore.com>
9450
9451         * windows-nat.c (windows_nat_target::attach)
9452         (windows_nat_target::detach): Don't call gdb_flush.
9453         * valprint.c (generic_val_print, val_print, val_print_string):
9454         Don't call gdb_flush.
9455         * utils.c (defaulted_query): Don't call gdb_flush.
9456         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9457         * target.c (target_announce_detach): Don't call gdb_flush.
9458         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9459         * remote.c (extended_remote_target::attach): Don't call
9460         gdb_flush.
9461         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9462         * printcmd.c (do_examine): Don't call gdb_flush.
9463         (info_display_command): Don't call gdb_flush.
9464         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9465         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9466         * memattr.c (info_mem_command): Don't call gdb_flush.
9467         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9468         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9469         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9470         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9471         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9472         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9473         (gnu_nat_target::detach): Don't call gdb_flush.
9474         * f-valprint.c (f_val_print): Don't call gdb_flush.
9475         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9476         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9477         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9478         gdb_flush.
9479         * c-valprint.c (c_val_print): Don't call gdb_flush.
9480         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9481
9482 2019-03-05  Tom Tromey  <tromey@adacore.com>
9483
9484         * varobj.c (update_dynamic_varobj_children): Update.
9485         (install_default_visualizer): Use reset, not release.
9486         * value.c (set_internalvar): Update.
9487         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9488         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9489         ATTRIBUTE_UNUSED_RESULT.
9490
9491 2019-03-05  Tom Tromey  <tromey@adacore.com>
9492
9493         * remote.c (class scoped_remote_fd) <release>: Add
9494         ATTRIBUTE_UNUSED_RESULT.
9495
9496 2019-03-05  Tom Tromey  <tromey@adacore.com>
9497
9498         * macroexp.c (struct macro_buffer) <release>: Add
9499         ATTRIBUTE_UNUSED_RESULT.
9500
9501 2019-03-05  Tom Tromey  <tromey@adacore.com>
9502
9503         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9504         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9505         ATTRIBUTE_UNUSED_RESULT.
9506
9507 2019-03-05  Tom Tromey  <tromey@adacore.com>
9508
9509         * common/scoped_fd.h (class scoped_fd) <release>: Add
9510         ATTRIBUTE_UNUSED_RESULT.
9511
9512 2019-03-05  Tom Tromey  <tromey@adacore.com>
9513
9514         * parser-defs.h (struct parser_state) <release>: Add
9515         ATTRIBUTE_UNUSED_RESULT.
9516
9517 2019-03-05  Tom Tromey  <tromey@adacore.com>
9518
9519         * utils.h (class gdb_argv) <release>: Add
9520         ATTRIBUTE_UNUSED_RESULT.
9521         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9522
9523 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9524
9525         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9526         for-loop range, to avoid compiler warnings.
9527
9528         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9529         avoid compiler warnings about unused variables.
9530
9531         * NEWS: Mention end of support for native debugging on MS-Windows
9532         before XP.
9533
9534         PR gdb/24292
9535         * common/netstuff.c:
9536         * gdbserver/gdbreplay.c
9537         * gdbserver/remote-utils.c:
9538         * ser-tcp.c:
9539         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9540         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9541         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9542         'getaddrinfo' and 'freeaddrinfo' were not available before
9543         Windows XP, and mingw.org's MinGW headers by default define
9544         _WIN32_WINNT to 0x500.
9545
9546 2019-03-01  Gary Benson <gbenson@redhat.com>
9547
9548         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9549
9550 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9551             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9552
9553         PR gdb/8527
9554         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9555         set_sigint_trap, clear_sigint_trap.
9556
9557 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9558
9559         * target.c (target_detach): Clear the regcache and the
9560         frame cache.
9561
9562 2019-02-27  Pedro Alves  <palves@redhat.com>
9563
9564         * utils.c (set_screen_size): When we cap the height/width sizes,
9565         tweak the corresponding command variable to show "unlimited":
9566
9567 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9568             Pedro Alves  <palves@redhat.com>
9569
9570         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9571         before calling rl_set_screen_size.
9572
9573 2019-02-27  Tom Tromey  <tromey@adacore.com>
9574
9575         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9576         define.
9577         * python/py-value.c: Remove Python 2.4 workaround.
9578         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9579         workaround.
9580         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9581         Python 2.4 workaround.
9582         * python/python-internal.h: Remove Python 2.4 comment.
9583         (Py_ssize_t): Don't define.
9584         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9585         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9586         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9587         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9588         * python/python.c (do_start_initialization): Remove Python 2.4
9589         workaround.
9590         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9591         (print_children): Remove Python 2.4 workaround.
9592         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9593         workaround.
9594         (CHARBUFFERPROC_NAME): Remove.
9595         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9596         Python 2.4 workaround.
9597
9598 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9599
9600         * NEWS: Note minimum Python version.
9601
9602 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9603
9604         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9605         code from these functions.  Remove corresponding ifdefs.  Use
9606         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9607         Remove gotos and target of gotos.
9608         (infpy_search_memory): Likewise.
9609
9610 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9611
9612         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9613         (hppa_gdbarch_init): Don't register deleted functions with
9614         gdbarch.
9615
9616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9617
9618         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9619         (h8300_unwind_sp): Delete.
9620         (h8300_dummy_id): Delete.
9621         (h8300_gdbarch_init): Don't register deleted functions with
9622         gdbarch.
9623
9624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9625
9626         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9627         (ft32_unwind_pc): Delete.
9628         (ft32_unwind_sp): Delete.
9629         (ft32_gdbarch_init): Don't register deleted functions with
9630         gdbarch.
9631
9632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9633
9634         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9635         (frv_unwind_pc): Delete.
9636         (frv_unwind_sp): Delete.
9637         (frv_gdbarch_init): Don't register deleted functions with
9638         gdbarch.
9639
9640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9641
9642         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9643         (riscv_unwind_pc): Delete.
9644         (riscv_unwind_sp): Delete.
9645         (riscv_gdbarch_init): Don't register deleted functions with
9646         gdbarch.
9647
9648 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9649
9650         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9651         (csky_unwind_pc): Delete.
9652         (csky_unwind_sp): Delete.
9653         (csky_gdbarch_init): Don't register deleted functions with
9654         gdbarch.
9655
9656 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9657
9658         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9659         (cris_unwind_pc): Delete.
9660         (cris_unwind_sp): Delete.
9661         (cris_gdbarch_init): Don't register deleted functions with
9662         gdbarch.
9663
9664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9665
9666         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9667         (bfin_unwind_pc): Delete.
9668         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9669
9670 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9671
9672         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9673         (arm_unwind_pc): Delete.
9674         (arm_unwind_sp): Delete.
9675         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9676
9677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9678
9679         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9680         (arc_unwind_pc): Delete.
9681         (arc_unwind_sp): Delete.
9682         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9683
9684 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9685
9686         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9687         (alpha_unwind_pc): Delete.
9688         (alpha_gdbarch_init): Don't register deleted functions with
9689         gdbarch.
9690
9691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9692
9693         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9694         (aarch64_unwind_pc): Delete.
9695         (aarch64_unwind_sp): Delete.
9696         (aarch64_gdbarch_init): Don't register deleted functions with
9697         gdbarch.
9698
9699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9700
9701         * gdbtypes.c (type_align): Don't consider static members when
9702         computing structure alignment.
9703
9704 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9705
9706         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9707         return 0 for other types.
9708         * arch-utils.c (default_type_align): Always return 0.
9709         * gdbarch.h: Regenerate.
9710         * gdbarch.sh (type_align): Extend comment.
9711         * gdbtypes.c (type_align): Add additional comments, always call
9712         gdbarch_type_align before applying the default rules.
9713         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9714         generic code will then apply a suitable default.
9715         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9716         types, return 0 for other types.
9717
9718 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9719
9720         * NEWS: Create a new section for the next release branch.
9721         Rename the section of the current branch, now that it has
9722         been cut.
9723
9724 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9725
9726         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9727         * version.in: Bump version to 8.3.50.DATE-git.
9728
9729 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9730
9731         * aix-thread.c (ptid_cmp): Remove unused variable.
9732         (get_signaled_thread): Likewise.
9733         (store_regs_user_thread): Likewise.
9734         (store_regs_kernel_thread): Likewise.
9735         (fetch_regs_kernel_thread): Remove shadowed variable.
9736
9737 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9738
9739         * features/riscv/32bit-cpu.xml: Add register numbers.
9740         * features/riscv/32bit-fpu.c: Regenerate.
9741         * features/riscv/32bit-fpu.xml: Add register numbers.
9742         * features/riscv/64bit-cpu.xml: Add register numbers.
9743         * features/riscv/64bit-fpu.c: Regenerate.
9744         * features/riscv/64bit-fpu.xml: Add register numbers.
9745
9746 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9747
9748         * NEWS: Mention two argument form of gdb.Value constructor.
9749         * python/py-value.c (convert_buffer_and_type_to_value): New
9750         function.
9751         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9752         Add support for handling an optional second argument.  Call
9753         convert_buffer_and_type_to_value as appropriate.
9754         * python/python-internal.h (Py_buffer_deleter): New struct.
9755         (Py_buffer_up): New typedef.
9756
9757 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9758
9759         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9760         instead of releasing ownership.
9761
9762 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9763
9764         * dwarf2read.c (open_and_init_dwp_file): Call
9765         elf_numsections instead of bfd_count_sections to initialize
9766         dwp_file->num_sections.
9767
9768 2019-02-25  Tom Tromey  <tromey@adacore.com>
9769
9770         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9771
9772 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9773
9774         * gcore.in: Add '--readnever' option when invoking GDB.
9775
9776 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9777
9778         * MAINTAINERS: Update my email address.
9779
9780 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9781
9782         * build-id.c (build_id_to_debug_bfd_1): New function.
9783         (build_id_to_debug_bfd): Look for separate debug file in
9784         sysroot.
9785
9786 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9787
9788         * gdbarch.sh: Update the copyright year range that is placed into
9789         generated files.
9790
9791 2019-02-22  Keith Seitz  <keiths@redhat.com>
9792
9793         PR symtab/23853
9794         * linespec.c (create_sals_line_offset): Search for the default
9795         symtab's filename instead of its fullname.
9796
9797 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9798
9799         * NEWS: Update style defaults.
9800
9801 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9802
9803         * main.c (captured_main_1): Disable styling in batch mode.
9804
9805 2019-02-20  Tom Tromey  <tom@tromey.com>
9806
9807         * symtab.c (symtab_symbol_info): Fix typos.
9808
9809 2019-02-20  Tom Tromey  <tromey@adacore.com>
9810
9811         * findcmd.c (_initialize_mem_search): Use upper case for
9812         metasyntactic variables.
9813
9814 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9815
9816         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9817         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9818
9819 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9820
9821         * top.h (source_file_name): Change to std::string.
9822         * top.c (source_file_name): Likewise.
9823         (command_line_input): Adjust.
9824         * cli/cli-script.c (script_from_file): Adjust.
9825
9826 2019-02-19  Tom Tromey  <tromey@adacore.com>
9827
9828         * ravenscar-thread.c
9829         (ravenscar_thread_target::update_thread_list): Don't call
9830         ada_build_task_list.
9831         * ada-lang.h (ada_build_task_list): Don't declare.
9832         * ada-tasks.c (struct ada_tasks_inferior_data)
9833         <task_list_valid_p>: Now bool.
9834         (read_known_tasks, ada_task_list_changed)
9835         (ada_tasks_invalidate_inferior_data): Update.
9836         (read_known_tasks_array): Return bool.
9837         (read_known_tasks_list): Likewise.
9838         (read_known_tasks): Return void.
9839         (ada_build_task_list): Now static.
9840
9841 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9842
9843         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9844         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9845
9846 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9847
9848         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9849         variant for ada_tasks_pspace_data_handle and
9850         ada_tasks_inferior_data_handle.
9851         (ada_tasks_pspace_data_cleanup): New function.
9852         (ada_tasks_inferior_data_cleanup): New function.
9853
9854 2019-02-17  Tom Tromey  <tom@tromey.com>
9855
9856         * macrotab.h (macro_source_fullname): Return a std::string.
9857         * macrotab.c (macro_include, check_for_redefinition)
9858         (macro_undef, macro_lookup_definition, foreach_macro)
9859         (foreach_macro_in_scope): Update.
9860         (macro_source_fullname): Return a std::string.
9861         * macrocmd.c (show_pp_source_pos): Update.
9862
9863 2019-02-17  Tom Tromey  <tom@tromey.com>
9864
9865         * macrocmd.c (show_pp_source_pos): Style the file names.
9866
9867 2019-02-17  Tom Tromey  <tom@tromey.com>
9868
9869         PR tui/24197:
9870         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9871
9872 2019-02-17  Tom Tromey  <tom@tromey.com>
9873
9874         * ada-lang.c (user_select_syms): Use filtered printing.
9875         * utils.c (wrap_style): New global.
9876         (desired_style): Remove.
9877         (emit_style_escape): Add stream parameter.
9878         (set_output_style, reset_terminal_style, prompt_for_continue):
9879         Update.
9880         (flush_wrap_buffer): Only flush gdb_stdout.
9881         (wrap_here): Set wrap_style.
9882         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9883         treat escape sequences as a character.  Change when wrap buffer is
9884         flushed.
9885         (fputs_styled): Do not set the output style when the default is
9886         requested.
9887         * ui-style.h (struct ui_file_style) <is_default>: New method.
9888         * source.c (print_source_lines_base): Emit escape sequences in one
9889         piece.
9890
9891 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9892
9893         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9894         integers and enumeration types.
9895
9896 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9897
9898         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9899         instead of lookup_symbol_in_language
9900         (do_exact_match): New function.
9901         (ada_get_symbol_name_matcher): Return do_exact_match when
9902         doing a verbatim match.
9903
9904 2019-02-15  Tom Tromey  <tromey@adacore.com>
9905
9906         * ravenscar-thread.c (ravenscar_thread_target::resume)
9907         (ravenscar_thread_target::wait): Special case wildcard requests.
9908
9909 2019-02-15  Tom Tromey  <tromey@adacore.com>
9910
9911         * ravenscar-thread.c (base_ptid): Remove.
9912         (struct ravenscar_thread_target) <close>: New method.
9913         <m_base_ptid>: New member.
9914         <update_inferior_ptid, active_task, task_is_currently_active,
9915         runtime_initialized>: Declare methods.
9916         <ravenscar_thread_target>: Add constructor.
9917         (ravenscar_thread_target::task_is_currently_active)
9918         (ravenscar_thread_target::update_inferior_ptid)
9919         (ravenscar_runtime_initialized): Rename.  Now methods.
9920         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9921         (ravenscar_thread_target::update_thread_list): Update.
9922         (ravenscar_thread_target::active_task): Now method.
9923         (ravenscar_thread_target::store_registers)
9924         (ravenscar_thread_target::prepare_to_store)
9925         (ravenscar_thread_target::prepare_to_store)
9926         (ravenscar_thread_target::mourn_inferior): Update.
9927         (ravenscar_inferior_created): Use "new" to create target.
9928         (ravenscar_thread_target::get_ada_task_ptid): Update.
9929         (_initialize_ravenscar): Don't initialize base_ptid.
9930         (ravenscar_ops): Remove global.
9931
9932 2019-02-15  Tom Tromey  <tromey@adacore.com>
9933
9934         * target.h (push_target): Declare new overload.
9935         * target.c (push_target): New overload, taking an rvalue reference.
9936         * remote.c (remote_target::open_1): Use push_target overload.
9937         * corelow.c (core_target_open): Use push_target overload.
9938
9939 2019-02-15  Tom Tromey  <tromey@adacore.com>
9940
9941         * ravenscar-thread.c (is_ravenscar_task)
9942         (ravenscar_task_is_currently_active): Return bool.
9943         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9944         (_initialize_ravenscar): Remove "(void)".
9945         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9946         Return bool.
9947
9948 2019-02-15  Tom Tromey  <tromey@adacore.com>
9949
9950         * ravenscar-thread.c (ravenscar_runtime_initializer)
9951         (has_ravenscar_runtime, get_running_thread_id)
9952         (ravenscar_thread_target::resume): Fix indentation.
9953
9954 2019-02-15  Tom Tromey  <tromey@adacore.com>
9955
9956         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9957         from ravenscar_arch_ops.
9958         (sparc_ravenscar_ops::fetch_registers)
9959         (sparc_ravenscar_ops::store_registers): Now methods.
9960         (sparc_ravenscar_prepare_to_store): Remove.
9961         (sparc_ravenscar_ops): Redefine.
9962         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9963         methods and destructor.  Remove members.
9964         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9965         (ravenscar_thread_target::store_registers)
9966         (ravenscar_thread_target::prepare_to_store): Update.
9967         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9968         Remove.
9969         (struct ppc_ravenscar_powerpc_ops): Derive from
9970         ravenscar_arch_ops.
9971         (ppc_ravenscar_powerpc_ops::fetch_registers)
9972         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9973         (ppc_ravenscar_powerpc_ops): Redefine.
9974         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9975         (ppc_ravenscar_e500_ops::fetch_registers)
9976         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9977         (ppc_ravenscar_e500_ops): Redefine.
9978         * aarch64-ravenscar-thread.c
9979         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9980         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9981         (aarch64_ravenscar_fetch_registers)
9982         (aarch64_ravenscar_store_registers): Now methods.
9983         (aarch64_ravenscar_ops): Redefine.
9984
9985 2019-02-15  Tom Tromey  <tromey@adacore.com>
9986
9987         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9988         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9989         (ravenscar_thread_target::stopped_by_watchpoint)
9990         (ravenscar_thread_target::stopped_data_address)
9991         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9992
9993 2019-02-15  Tom Tromey  <tromey@adacore.com>
9994
9995         * ravenscar-thread.c: Fix some typos.
9996
9997 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9998             Tom Tromey  <tromey@adacore.com>
9999
10000         * ada-lang.c (ada_exception_sal): Change addr_string to a
10001         std::string.
10002         (create_ada_exception_catchpoint): Update.
10003
10004 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10005             Tom Tromey  <tromey@adacore.com>
10006
10007         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10008         (bp_location_ops): Remove.
10009         (base_breakpoint_allocate_location): Update.
10010         (free_bp_location): Update.
10011         * ada-lang.c (class ada_catchpoint_location)
10012         <ada_catchpoint_location>: Remove ops parameter.
10013         (ada_catchpoint_location_dtor): Remove.
10014         (ada_catchpoint_location_ops): Remove.
10015         (allocate_location_exception): Update.
10016         * breakpoint.h (struct bp_location_ops): Remove.
10017         (class bp_location) <bp_location>: Remove bp_location_ops
10018         parameter.
10019         <~bp_location>: Add destructor.
10020         <ops>: Remove.
10021
10022 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10023             Pedro Alves  <palves@redhat.com>
10024
10025         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10026         'PATH_MAX'.
10027
10028 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10029             Samuel Thibault  <samuel.thibault@gnu.org>
10030             Thomas Schwinge  <thomas@codesourcery.com>
10031
10032         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10033         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10034
10035 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10036
10037         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10038         (check_empty): Use "const char *".
10039
10040         * gnu-nat.c (gnu_nat_target::detach): Instead of
10041         'detach_inferior (pid)' call
10042         'detach_inferior (find_inferior_pid (pid))'.
10043
10044         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10045         'nat/fork-inferior.o'.
10046         * gnu-nat.c: #include "nat/fork-inferior.h".
10047
10048         * gnu-nat.c (gnu_nat_target::detach): Instead of
10049         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10050         * gnu-nat.h: #include "inf-child.h".
10051         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10052         'i386_gnu_nat_target::fetch_registers'.
10053         (gnu_store_registers): Rename/move to
10054         'i386_gnu_nat_target::store_registers'.
10055
10056         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10057         * gnu-nat.h (mach_thread_info): New function.
10058         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10059
10060         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10061
10062 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10063
10064         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10065
10066 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10067
10068         * windows-nat.c (windows_add_thread): Add new parameter
10069         "main_thread_p" with default value set to false.  Update
10070         function documentation as well as all callers.
10071         (windows_delete_thread): Likewise.
10072         (fake_create_process): Update call to windows_add_thread.
10073         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10074         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10075         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10076         call to windows_delete_thread.
10077
10078 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10079
10080         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10081
10082 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10083
10084         * symfile.c (find_separate_debug_file): Use canonical path of
10085         sysroot with child_path instead of gdb_sysroot if it is valid.
10086
10087 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10088
10089         * symfile.c (find_separate_debug_file): Use child_path to
10090         determine if an object file is under a sysroot.
10091
10092 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10093
10094         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10095         unittests/child-path-selftests.c.
10096         * common/pathstuff.c (child_path): New function.
10097         * common/pathstuff.h (child_path): New prototype.
10098         * unittests/child-path-selftests.c: New file.
10099
10100 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10101
10102         * symfile.c (find_separate_debug_file): Look for separate debug
10103         files in debug directories under the sysroot.
10104
10105 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10106
10107         * symtab.h (struct minimal_symbol data_p): New const method.
10108         (struct minimal_symbol text_p): Likewise.
10109         * symtab.c (output_source_filename): Use file name style
10110         to print file name.
10111         (print_symbol_info): Likewise.
10112         (print_msymbol_info): Use address style to print addresses.
10113         Use function name style to print executable text symbols.
10114         (expand_symtab_containing_pc): Use data_p.
10115         (find_pc_sect_compunit_symtab): Likewise.
10116
10117 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10118
10119         * breakpoint.c (describe_other_breakpoints): Use address style
10120         to print addresses.
10121         (say_where): Likewise.
10122
10123 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10124
10125         * ada-typeprint.c (print_func_type): Print function name
10126         style to print function name.
10127         * c-typeprint.c (c_print_type_1): Likewise.
10128
10129 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10130
10131         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10132         for execve.
10133
10134 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10135
10136         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10137         type_stack.
10138
10139 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10140
10141         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10142         TYPE_CODE_REF types.
10143
10144 2019-02-08  Jim Wilson  <jimw@sifive.com>
10145
10146         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10147         (riscv_linux_fregset): New.
10148         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10149
10150 2019-02-07  Tom Tromey  <tom@tromey.com>
10151
10152         * thread.c (thread_cancel_execution_command): Update.
10153         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10154         methods.
10155         (struct thread_fsm_ops): Remove.
10156         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10157         (thread_fsm_should_stop, thread_fsm_return_value)
10158         (thread_fsm_set_finished, thread_fsm_finished_p)
10159         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10160         Don't declare.
10161         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10162         * infrun.c (clear_proceed_status_thread)
10163         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10164         (print_stop_event): Update.
10165         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10166         Add constructor.
10167         (step_command_fsm_ops): Remove.
10168         (new_step_command_fsm): Remove.
10169         (step_1): Update.
10170         (step_command_fsm::should_stop): Rename from
10171         step_command_fsm_should_stop.
10172         (step_command_fsm::clean_up): Rename from
10173         step_command_fsm_clean_up.
10174         (step_command_fsm::do_async_reply_reason): Rename from
10175         step_command_fsm_async_reply_reason.
10176         (struct until_next_fsm): Inherit from thread_fsm.  Add
10177         constructor.
10178         (until_next_fsm_ops): Remove.
10179         (new_until_next_fsm): Remove.
10180         (until_next_fsm::should_stop): Rename from
10181         until_next_fsm_should_stop.
10182         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10183         (until_next_fsm::do_async_reply_reason): Rename from
10184         until_next_fsm_async_reply_reason.
10185         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10186         constructor.  Change type of breakpoint.
10187         (finish_command_fsm_ops): Remove.
10188         (new_finish_command_fsm): Remove.
10189         (finish_command_fsm::should_stop): Rename from
10190         finish_command_fsm_should_stop.
10191         (finish_command_fsm::clean_up): Rename from
10192         finish_command_fsm_clean_up.
10193         (finish_command_fsm::return_value): Rename from
10194         finish_command_fsm_return_value.
10195         (finish_command_fsm::do_async_reply_reason): Rename from
10196         finish_command_fsm_async_reply_reason.
10197         (finish_command): Update.
10198         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10199         Add constructor.
10200         (call_thread_fsm_ops): Remove.
10201         (call_thread_fsm::call_thread_fsm): Rename from
10202         new_call_thread_fsm.
10203         (call_thread_fsm::should_stop): Rename from
10204         call_thread_fsm_should_stop.
10205         (call_thread_fsm::should_notify_stop): Rename from
10206         call_thread_fsm_should_notify_stop.
10207         (run_inferior_call, call_function_by_hand_dummy): Update.
10208         * cli/cli-interp.c (should_print_stop_to_console): Update.
10209         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10210         Add constructor.  Change type of location_breakpoint,
10211         caller_breakpoint.
10212         (until_break_fsm_ops): Remove.
10213         (new_until_break_fsm): Remove.
10214         (until_break_fsm::should_stop): Rename from
10215         until_break_fsm_should_stop.
10216         (until_break_fsm::clean_up): Rename from
10217         until_break_fsm_clean_up.
10218         (until_break_fsm::do_async_reply_reason): Rename from
10219         until_break_fsm_async_reply_reason.
10220         (until_break_command): Update.
10221         * thread-fsm.c: Remove.
10222         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10223
10224 2019-02-07  Tom Tromey  <tom@tromey.com>
10225
10226         * yy-remap.h: Add include guard.
10227         * xtensa-tdep.h: Add include guard.
10228         * xcoffread.h: Rename include guard.
10229         * varobj-iter.h: Add include guard.
10230         * tui/tui.h: Rename include guard.
10231         * tui/tui-winsource.h: Rename include guard.
10232         * tui/tui-wingeneral.h: Rename include guard.
10233         * tui/tui-windata.h: Rename include guard.
10234         * tui/tui-win.h: Rename include guard.
10235         * tui/tui-stack.h: Rename include guard.
10236         * tui/tui-source.h: Rename include guard.
10237         * tui/tui-regs.h: Rename include guard.
10238         * tui/tui-out.h: Rename include guard.
10239         * tui/tui-layout.h: Rename include guard.
10240         * tui/tui-io.h: Rename include guard.
10241         * tui/tui-hooks.h: Rename include guard.
10242         * tui/tui-file.h: Rename include guard.
10243         * tui/tui-disasm.h: Rename include guard.
10244         * tui/tui-data.h: Rename include guard.
10245         * tui/tui-command.h: Rename include guard.
10246         * tic6x-tdep.h: Add include guard.
10247         * target/waitstatus.h: Rename include guard.
10248         * target/wait.h: Rename include guard.
10249         * target/target.h: Rename include guard.
10250         * target/resume.h: Rename include guard.
10251         * target-float.h: Rename include guard.
10252         * stabsread.h: Add include guard.
10253         * rs6000-tdep.h: Add include guard.
10254         * riscv-fbsd-tdep.h: Add include guard.
10255         * regformats/regdef.h: Rename include guard.
10256         * record.h: Rename include guard.
10257         * python/python.h: Rename include guard.
10258         * python/python-internal.h: Rename include guard.
10259         * python/py-stopevent.h: Rename include guard.
10260         * python/py-ref.h: Rename include guard.
10261         * python/py-record.h: Rename include guard.
10262         * python/py-record-full.h: Rename include guard.
10263         * python/py-record-btrace.h: Rename include guard.
10264         * python/py-instruction.h: Rename include guard.
10265         * python/py-events.h: Rename include guard.
10266         * python/py-event.h: Rename include guard.
10267         * procfs.h: Add include guard.
10268         * proc-utils.h: Add include guard.
10269         * p-lang.h: Add include guard.
10270         * or1k-tdep.h: Rename include guard.
10271         * observable.h: Rename include guard.
10272         * nto-tdep.h: Rename include guard.
10273         * nat/x86-linux.h: Rename include guard.
10274         * nat/x86-linux-dregs.h: Rename include guard.
10275         * nat/x86-gcc-cpuid.h: Add include guard.
10276         * nat/x86-dregs.h: Rename include guard.
10277         * nat/x86-cpuid.h: Rename include guard.
10278         * nat/ppc-linux.h: Rename include guard.
10279         * nat/mips-linux-watch.h: Rename include guard.
10280         * nat/linux-waitpid.h: Rename include guard.
10281         * nat/linux-ptrace.h: Rename include guard.
10282         * nat/linux-procfs.h: Rename include guard.
10283         * nat/linux-osdata.h: Rename include guard.
10284         * nat/linux-nat.h: Rename include guard.
10285         * nat/linux-namespaces.h: Rename include guard.
10286         * nat/linux-btrace.h: Rename include guard.
10287         * nat/glibc_thread_db.h: Rename include guard.
10288         * nat/gdb_thread_db.h: Rename include guard.
10289         * nat/gdb_ptrace.h: Rename include guard.
10290         * nat/fork-inferior.h: Rename include guard.
10291         * nat/amd64-linux-siginfo.h: Rename include guard.
10292         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10293         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10294         * nat/aarch64-linux.h: Rename include guard.
10295         * nat/aarch64-linux-hw-point.h: Rename include guard.
10296         * mn10300-tdep.h: Add include guard.
10297         * mips-linux-tdep.h: Add include guard.
10298         * mi/mi-parse.h: Rename include guard.
10299         * mi/mi-out.h: Rename include guard.
10300         * mi/mi-main.h: Rename include guard.
10301         * mi/mi-interp.h: Rename include guard.
10302         * mi/mi-getopt.h: Rename include guard.
10303         * mi/mi-console.h: Rename include guard.
10304         * mi/mi-common.h: Rename include guard.
10305         * mi/mi-cmds.h: Rename include guard.
10306         * mi/mi-cmd-break.h: Rename include guard.
10307         * m2-lang.h: Add include guard.
10308         * location.h: Rename include guard.
10309         * linux-record.h: Rename include guard.
10310         * linux-nat.h: Add include guard.
10311         * linux-fork.h: Add include guard.
10312         * i386-darwin-tdep.h: Rename include guard.
10313         * hppa-linux-offsets.h: Add include guard.
10314         * guile/guile.h: Rename include guard.
10315         * guile/guile-internal.h: Rename include guard.
10316         * gnu-nat.h: Rename include guard.
10317         * gdb-stabs.h: Rename include guard.
10318         * frv-tdep.h: Add include guard.
10319         * f-lang.h: Add include guard.
10320         * event-loop.h: Add include guard.
10321         * darwin-nat.h: Rename include guard.
10322         * cp-abi.h: Rename include guard.
10323         * config/sparc/nm-sol2.h: Rename include guard.
10324         * config/nm-nto.h: Rename include guard.
10325         * config/nm-linux.h: Add include guard.
10326         * config/i386/nm-i386gnu.h: Rename include guard.
10327         * config/djgpp/nl_types.h: Rename include guard.
10328         * config/djgpp/langinfo.h: Rename include guard.
10329         * compile/gcc-cp-plugin.h: Add include guard.
10330         * compile/gcc-c-plugin.h: Add include guard.
10331         * compile/compile.h: Rename include guard.
10332         * compile/compile-object-run.h: Rename include guard.
10333         * compile/compile-object-load.h: Rename include guard.
10334         * compile/compile-internal.h: Rename include guard.
10335         * compile/compile-cplus.h: Rename include guard.
10336         * compile/compile-c.h: Rename include guard.
10337         * common/xml-utils.h: Rename include guard.
10338         * common/x86-xstate.h: Rename include guard.
10339         * common/version.h: Rename include guard.
10340         * common/vec.h: Rename include guard.
10341         * common/tdesc.h: Rename include guard.
10342         * common/selftest.h: Rename include guard.
10343         * common/scoped_restore.h: Rename include guard.
10344         * common/scoped_mmap.h: Rename include guard.
10345         * common/scoped_fd.h: Rename include guard.
10346         * common/safe-iterator.h: Rename include guard.
10347         * common/run-time-clock.h: Rename include guard.
10348         * common/refcounted-object.h: Rename include guard.
10349         * common/queue.h: Rename include guard.
10350         * common/ptid.h: Rename include guard.
10351         * common/print-utils.h: Rename include guard.
10352         * common/preprocessor.h: Rename include guard.
10353         * common/pathstuff.h: Rename include guard.
10354         * common/observable.h: Rename include guard.
10355         * common/netstuff.h: Rename include guard.
10356         * common/job-control.h: Rename include guard.
10357         * common/host-defs.h: Rename include guard.
10358         * common/gdb_wait.h: Rename include guard.
10359         * common/gdb_vecs.h: Rename include guard.
10360         * common/gdb_unlinker.h: Rename include guard.
10361         * common/gdb_unique_ptr.h: Rename include guard.
10362         * common/gdb_tilde_expand.h: Rename include guard.
10363         * common/gdb_sys_time.h: Rename include guard.
10364         * common/gdb_string_view.h: Rename include guard.
10365         * common/gdb_splay_tree.h: Rename include guard.
10366         * common/gdb_setjmp.h: Rename include guard.
10367         * common/gdb_ref_ptr.h: Rename include guard.
10368         * common/gdb_optional.h: Rename include guard.
10369         * common/gdb_locale.h: Rename include guard.
10370         * common/gdb_assert.h: Rename include guard.
10371         * common/filtered-iterator.h: Rename include guard.
10372         * common/filestuff.h: Rename include guard.
10373         * common/fileio.h: Rename include guard.
10374         * common/environ.h: Rename include guard.
10375         * common/common-utils.h: Rename include guard.
10376         * common/common-types.h: Rename include guard.
10377         * common/common-regcache.h: Rename include guard.
10378         * common/common-inferior.h: Rename include guard.
10379         * common/common-gdbthread.h: Rename include guard.
10380         * common/common-exceptions.h: Rename include guard.
10381         * common/common-defs.h: Rename include guard.
10382         * common/common-debug.h: Rename include guard.
10383         * common/cleanups.h: Rename include guard.
10384         * common/buffer.h: Rename include guard.
10385         * common/btrace-common.h: Rename include guard.
10386         * common/break-common.h: Rename include guard.
10387         * cli/cli-utils.h: Rename include guard.
10388         * cli/cli-style.h: Rename include guard.
10389         * cli/cli-setshow.h: Rename include guard.
10390         * cli/cli-script.h: Rename include guard.
10391         * cli/cli-interp.h: Rename include guard.
10392         * cli/cli-decode.h: Rename include guard.
10393         * cli/cli-cmds.h: Rename include guard.
10394         * charset-list.h: Add include guard.
10395         * buildsym-legacy.h: Rename include guard.
10396         * bfin-tdep.h: Add include guard.
10397         * ax.h: Rename include guard.
10398         * arm-linux-tdep.h: Add include guard.
10399         * arm-fbsd-tdep.h: Add include guard.
10400         * arch/xtensa.h: Rename include guard.
10401         * arch/tic6x.h: Add include guard.
10402         * arch/i386.h: Add include guard.
10403         * arch/arm.h: Rename include guard.
10404         * arch/arm-linux.h: Rename include guard.
10405         * arch/arm-get-next-pcs.h: Rename include guard.
10406         * arch/amd64.h: Add include guard.
10407         * arch/aarch64-insn.h: Rename include guard.
10408         * arch-utils.h: Rename include guard.
10409         * annotate.h: Add include guard.
10410         * amd64-darwin-tdep.h: Rename include guard.
10411         * aarch64-linux-tdep.h: Add include guard.
10412         * aarch64-fbsd-tdep.h: Add include guard.
10413         * aarch32-linux-nat.h: Add include guard.
10414
10415 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10416
10417         * macrotab.c (macro_define_internal): New function that
10418         factorizes macro_define_object_internal and macro_define_function
10419         code.
10420         (macro_define_object_internal): Use macro_define_internal.
10421         (macro_define_function): Likewise.
10422
10423 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10424
10425         * macrocmd.c (extract_identifier): Return
10426         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10427         callers.
10428
10429 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10430
10431         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10432
10433 2019-02-05  Tom Tromey  <tom@tromey.com>
10434
10435         * target.c (target_stack::unpush): Move assertion earlier.
10436
10437 2019-01-30  Tom Tromey  <tom@tromey.com>
10438
10439         PR python/23615:
10440         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10441         (gdbpy_parse_and_eval): Likewise.
10442         * python/python-internal.h (gdbpy_allow_threads): New class.
10443
10444 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10445
10446         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10447         (aarch64_fbsd_fpregmap): Move earlier.
10448         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10449         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10450         instead of individual calls to trad_frame_set_reg_addr.
10451         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10452         earlier.
10453         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10454         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10455         instead of individual calls to trad_frame_set_reg_addr.
10456
10457 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10458
10459         * CONTRIBUTE: Replace contribution list with wiki link.
10460
10461 2019-01-25  Tom Tromey  <tom@tromey.com>
10462
10463         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10464
10465 2019-01-25  Tom Tromey  <tom@tromey.com>
10466
10467         * xtensa-linux-nat.c: Fix common/ includes.
10468         * xml-support.h: Fix common/ includes.
10469         * xml-support.c: Fix common/ includes.
10470         * x86-linux-nat.c: Fix common/ includes.
10471         * windows-nat.c: Fix common/ includes.
10472         * varobj.h: Fix common/ includes.
10473         * varobj.c: Fix common/ includes.
10474         * value.c: Fix common/ includes.
10475         * valops.c: Fix common/ includes.
10476         * utils.c: Fix common/ includes.
10477         * unittests/xml-utils-selftests.c: Fix common/ includes.
10478         * unittests/utils-selftests.c: Fix common/ includes.
10479         * unittests/unpack-selftests.c: Fix common/ includes.
10480         * unittests/tracepoint-selftests.c: Fix common/ includes.
10481         * unittests/style-selftests.c: Fix common/ includes.
10482         * unittests/string_view-selftests.c: Fix common/ includes.
10483         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10484         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10485         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10486         * unittests/rsp-low-selftests.c: Fix common/ includes.
10487         * unittests/parse-connection-spec-selftests.c: Fix common/
10488         includes.
10489         * unittests/optional-selftests.c: Fix common/ includes.
10490         * unittests/offset-type-selftests.c: Fix common/ includes.
10491         * unittests/observable-selftests.c: Fix common/ includes.
10492         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10493         * unittests/memrange-selftests.c: Fix common/ includes.
10494         * unittests/memory-map-selftests.c: Fix common/ includes.
10495         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10496         * unittests/function-view-selftests.c: Fix common/ includes.
10497         * unittests/environ-selftests.c: Fix common/ includes.
10498         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10499         * unittests/common-utils-selftests.c: Fix common/ includes.
10500         * unittests/cli-utils-selftests.c: Fix common/ includes.
10501         * unittests/array-view-selftests.c: Fix common/ includes.
10502         * ui-file.c: Fix common/ includes.
10503         * tui/tui-io.c: Fix common/ includes.
10504         * tracepoint.h: Fix common/ includes.
10505         * tracepoint.c: Fix common/ includes.
10506         * tracefile-tfile.c: Fix common/ includes.
10507         * top.h: Fix common/ includes.
10508         * top.c: Fix common/ includes.
10509         * thread.c: Fix common/ includes.
10510         * target/waitstatus.h: Fix common/ includes.
10511         * target/waitstatus.c: Fix common/ includes.
10512         * target.h: Fix common/ includes.
10513         * target.c: Fix common/ includes.
10514         * target-memory.c: Fix common/ includes.
10515         * target-descriptions.c: Fix common/ includes.
10516         * symtab.h: Fix common/ includes.
10517         * symfile.c: Fix common/ includes.
10518         * stap-probe.c: Fix common/ includes.
10519         * spu-linux-nat.c: Fix common/ includes.
10520         * sparc-nat.c: Fix common/ includes.
10521         * source.c: Fix common/ includes.
10522         * solib.c: Fix common/ includes.
10523         * solib-target.c: Fix common/ includes.
10524         * ser-unix.c: Fix common/ includes.
10525         * ser-tcp.c: Fix common/ includes.
10526         * ser-pipe.c: Fix common/ includes.
10527         * ser-base.c: Fix common/ includes.
10528         * selftest-arch.c: Fix common/ includes.
10529         * s12z-tdep.c: Fix common/ includes.
10530         * rust-exp.y: Fix common/ includes.
10531         * rs6000-aix-tdep.c: Fix common/ includes.
10532         * riscv-tdep.c: Fix common/ includes.
10533         * remote.c: Fix common/ includes.
10534         * remote-notif.h: Fix common/ includes.
10535         * remote-fileio.h: Fix common/ includes.
10536         * remote-fileio.c: Fix common/ includes.
10537         * regcache.h: Fix common/ includes.
10538         * regcache.c: Fix common/ includes.
10539         * record-btrace.c: Fix common/ includes.
10540         * python/python.c: Fix common/ includes.
10541         * python/py-type.c: Fix common/ includes.
10542         * python/py-inferior.c: Fix common/ includes.
10543         * progspace.h: Fix common/ includes.
10544         * producer.c: Fix common/ includes.
10545         * procfs.c: Fix common/ includes.
10546         * proc-api.c: Fix common/ includes.
10547         * printcmd.c: Fix common/ includes.
10548         * ppc-linux-nat.c: Fix common/ includes.
10549         * parser-defs.h: Fix common/ includes.
10550         * osdata.c: Fix common/ includes.
10551         * obsd-nat.c: Fix common/ includes.
10552         * nat/x86-linux.c: Fix common/ includes.
10553         * nat/x86-linux-dregs.c: Fix common/ includes.
10554         * nat/x86-dregs.h: Fix common/ includes.
10555         * nat/x86-dregs.c: Fix common/ includes.
10556         * nat/ppc-linux.c: Fix common/ includes.
10557         * nat/mips-linux-watch.h: Fix common/ includes.
10558         * nat/mips-linux-watch.c: Fix common/ includes.
10559         * nat/linux-waitpid.c: Fix common/ includes.
10560         * nat/linux-ptrace.h: Fix common/ includes.
10561         * nat/linux-ptrace.c: Fix common/ includes.
10562         * nat/linux-procfs.c: Fix common/ includes.
10563         * nat/linux-personality.c: Fix common/ includes.
10564         * nat/linux-osdata.c: Fix common/ includes.
10565         * nat/linux-namespaces.c: Fix common/ includes.
10566         * nat/linux-btrace.h: Fix common/ includes.
10567         * nat/linux-btrace.c: Fix common/ includes.
10568         * nat/fork-inferior.c: Fix common/ includes.
10569         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10570         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10571         * nat/aarch64-linux.c: Fix common/ includes.
10572         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10573         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10574         * namespace.h: Fix common/ includes.
10575         * mips-linux-tdep.c: Fix common/ includes.
10576         * minsyms.c: Fix common/ includes.
10577         * mi/mi-parse.h: Fix common/ includes.
10578         * mi/mi-main.c: Fix common/ includes.
10579         * mi/mi-cmd-env.c: Fix common/ includes.
10580         * memrange.h: Fix common/ includes.
10581         * memattr.c: Fix common/ includes.
10582         * maint.h: Fix common/ includes.
10583         * maint.c: Fix common/ includes.
10584         * main.c: Fix common/ includes.
10585         * machoread.c: Fix common/ includes.
10586         * location.c: Fix common/ includes.
10587         * linux-thread-db.c: Fix common/ includes.
10588         * linux-nat.c: Fix common/ includes.
10589         * linux-fork.c: Fix common/ includes.
10590         * inline-frame.c: Fix common/ includes.
10591         * infrun.c: Fix common/ includes.
10592         * inflow.c: Fix common/ includes.
10593         * inferior.h: Fix common/ includes.
10594         * inferior.c: Fix common/ includes.
10595         * infcmd.c: Fix common/ includes.
10596         * inf-ptrace.c: Fix common/ includes.
10597         * inf-child.c: Fix common/ includes.
10598         * ia64-linux-nat.c: Fix common/ includes.
10599         * i387-tdep.c: Fix common/ includes.
10600         * i386-tdep.c: Fix common/ includes.
10601         * i386-linux-tdep.c: Fix common/ includes.
10602         * i386-linux-nat.c: Fix common/ includes.
10603         * i386-go32-tdep.c: Fix common/ includes.
10604         * i386-fbsd-tdep.c: Fix common/ includes.
10605         * i386-fbsd-nat.c: Fix common/ includes.
10606         * guile/scm-type.c: Fix common/ includes.
10607         * guile/guile.c: Fix common/ includes.
10608         * go32-nat.c: Fix common/ includes.
10609         * gnu-nat.c: Fix common/ includes.
10610         * gdbthread.h: Fix common/ includes.
10611         * gdbarch-selftests.c: Fix common/ includes.
10612         * gdb_usleep.c: Fix common/ includes.
10613         * gdb_select.h: Fix common/ includes.
10614         * gdb_bfd.c: Fix common/ includes.
10615         * gcore.c: Fix common/ includes.
10616         * fork-child.c: Fix common/ includes.
10617         * findvar.c: Fix common/ includes.
10618         * fbsd-nat.c: Fix common/ includes.
10619         * event-top.c: Fix common/ includes.
10620         * event-loop.c: Fix common/ includes.
10621         * dwarf2read.c: Fix common/ includes.
10622         * dwarf2loc.c: Fix common/ includes.
10623         * dwarf2-frame.c: Fix common/ includes.
10624         * dwarf-index-cache.c: Fix common/ includes.
10625         * dtrace-probe.c: Fix common/ includes.
10626         * disasm-selftests.c: Fix common/ includes.
10627         * defs.h: Fix common/ includes.
10628         * csky-tdep.c: Fix common/ includes.
10629         * cp-valprint.c: Fix common/ includes.
10630         * cp-support.h: Fix common/ includes.
10631         * cp-support.c: Fix common/ includes.
10632         * corelow.c: Fix common/ includes.
10633         * completer.h: Fix common/ includes.
10634         * completer.c: Fix common/ includes.
10635         * compile/compile.c: Fix common/ includes.
10636         * compile/compile-loc2c.c: Fix common/ includes.
10637         * compile/compile-cplus-types.c: Fix common/ includes.
10638         * compile/compile-cplus-symbols.c: Fix common/ includes.
10639         * command.h: Fix common/ includes.
10640         * cli/cli-dump.c: Fix common/ includes.
10641         * cli/cli-cmds.c: Fix common/ includes.
10642         * charset.c: Fix common/ includes.
10643         * build-id.c: Fix common/ includes.
10644         * btrace.h: Fix common/ includes.
10645         * btrace.c: Fix common/ includes.
10646         * breakpoint.h: Fix common/ includes.
10647         * breakpoint.c: Fix common/ includes.
10648         * ax.h:
10649         (enum agent_op): Fix common/ includes.
10650         * ax-general.c (struct aop_map): Fix common/ includes.
10651         * ax-gdb.c: Fix common/ includes.
10652         * auxv.c: Fix common/ includes.
10653         * auto-load.c: Fix common/ includes.
10654         * arm-tdep.c: Fix common/ includes.
10655         * arch/riscv.c: Fix common/ includes.
10656         * arch/ppc-linux-common.c: Fix common/ includes.
10657         * arch/i386.c: Fix common/ includes.
10658         * arch/arm.c: Fix common/ includes.
10659         * arch/arm-linux.c: Fix common/ includes.
10660         * arch/arm-get-next-pcs.c: Fix common/ includes.
10661         * arch/amd64.c: Fix common/ includes.
10662         * arch/aarch64.c: Fix common/ includes.
10663         * arch/aarch64-insn.c: Fix common/ includes.
10664         * arch-utils.c: Fix common/ includes.
10665         * amd64-windows-tdep.c: Fix common/ includes.
10666         * amd64-tdep.c: Fix common/ includes.
10667         * amd64-sol2-tdep.c: Fix common/ includes.
10668         * amd64-obsd-tdep.c: Fix common/ includes.
10669         * amd64-nbsd-tdep.c: Fix common/ includes.
10670         * amd64-linux-tdep.c: Fix common/ includes.
10671         * amd64-linux-nat.c: Fix common/ includes.
10672         * amd64-fbsd-tdep.c: Fix common/ includes.
10673         * amd64-fbsd-nat.c: Fix common/ includes.
10674         * amd64-dicos-tdep.c: Fix common/ includes.
10675         * amd64-darwin-tdep.c: Fix common/ includes.
10676         * agent.c: Fix common/ includes.
10677         * ada-lang.h: Fix common/ includes.
10678         * ada-lang.c: Fix common/ includes.
10679         * aarch64-tdep.c: Fix common/ includes.
10680
10681 2019-01-25  Tom Tromey  <tom@tromey.com>
10682
10683         * common/create-version.sh: Use common/version.h.
10684
10685 2019-01-24  Pedro Alves  <palves@redhat.com>
10686
10687         * infrun.c (signal_stop, signal_print, signal_program)
10688         (signal_catch, signal_pass): Now arrays instead of pointers.
10689         (update_signals_program_target, do_target_resume)
10690         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10691         * linux-nat.c (linux_nat_target::pass_signals)
10692         (linux_nat_target::create_inferior, linux_nat_target::attach):
10693         Adjust.
10694         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10695         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10696         * procfs.c (procfs_target::pass_signals): Adjust.
10697         * record-full.c (record_full_target::resume): Adjust.
10698         * remote.c (remote_target::pass_signals)
10699         (remote_target::program_signals): Adjust.
10700         * target-debug.h (target_debug_print_signals): Now takes a
10701         gdb::array_view as parameter.  Adjust.
10702         * target.h (target_ops) <pass_signals, program_signals>: Replace
10703         pointer and length parameters with gdb::array_view.
10704         (target_pass_signals, target_program_signals): Likewise.
10705         * target-delegates.c: Regenerate.
10706
10707 2019-01-24  Pedro Alves  <palves@redhat.com>
10708
10709         * common/forward-scope-exit.h
10710         (forward_scope_exit::forward_scope_exit): Pass arguments to
10711         m_bind_function directly, instead of creating a std::bind and
10712         copying that.
10713
10714 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10715
10716         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10717         for static members.
10718         (pass_in_v_vfp_candidate): Likewise.
10719
10720 2019-01-23  Tom Tromey  <tom@tromey.com>
10721             Pedro Alves  <palves@redhat.com>
10722
10723         * regcache.c (class regcache_invalidator): Remove.
10724         (regcache::raw_write): Use make_scope_exit.
10725
10726 2019-01-23  Tom Tromey  <tom@tromey.com>
10727
10728         * ui-out.h (class ui_out_emit_type): Update comment.
10729
10730 2019-01-23  Tom Tromey  <tom@tromey.com>
10731
10732         * infrun.c (fetch_inferior_event): Update comment.
10733
10734 2019-01-23  Tom Tromey  <tom@tromey.com>
10735             Pedro Alves  <palves@redhat.com>
10736
10737         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10738         parameter.
10739         (fetch_inferior_event): Use SCOPE_EXIT.
10740
10741
10742 2019-01-23  Tom Tromey  <tom@tromey.com>
10743             Pedro Alves  <palves@redhat.com>
10744
10745         * infrun.c (disable_thread_events): Delete.
10746         (stop_all_threads): Use SCOPE_EXIT.
10747
10748 2019-01-23  Tom Tromey  <tom@tromey.com>
10749             Pedro Alves  <palves@redhat.com>
10750
10751         * symfile.c: Include forward-scope-exit.h.
10752         (clear_symtab_users_cleanup): Replace forward declaration with
10753         a FORWARD_SCOPE_EXIT.
10754         (syms_from_objfile_1): Use the forward_scope_exit and
10755         gdb::optional instead of cleanup_function.
10756         (reread_symbols): Use the forward_scope_exit instead of
10757         cleanup_function.
10758         (clear_symtab_users_cleanup): Remove function.
10759
10760 2019-01-23  Tom Tromey  <tom@tromey.com>
10761             Pedro Alves  <palves@redhat.com>
10762
10763         * linux-nat.c: Include scope-exit.h.
10764         (cleanup_target_stop): Remove.
10765         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10766         SCOPE_EXIT.
10767
10768 2019-01-23  Tom Tromey  <tom@tromey.com>
10769             Pedro Alves  <palves@redhat.com>
10770
10771         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10772         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10773
10774 2019-01-23  Tom Tromey  <tom@tromey.com>
10775             Andrew Burgess  <andrew.burgess@embecosm.com>
10776             Pedro Alves  <palves@redhat.com>
10777
10778         * infrun.c (fetch_inferior_event): Use scope_exit.
10779         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10780         * top.c (execute_command): Use scope_exit.
10781         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10782         * utils.c (do_bpstat_clear_actions_cleanup)
10783         (make_bpstat_clear_actions_cleanup): Remove.
10784
10785 2019-01-23  Tom Tromey  <tom@tromey.com>
10786             Pedro Alves  <palves@redhat.com>
10787
10788         * infrun.c: Include "common/scope-exit.h"
10789         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10790         (wait_for_inferior): Use SCOPE_EXIT.
10791         (fetch_inferior_event): Use scope_exit.
10792
10793 2019-01-23  Tom Tromey  <tom@tromey.com>
10794             Pedro Alves  <palves@redhat.com>
10795
10796         * breakpoint.c (create_breakpoint): Remove cleanup.
10797
10798 2019-01-23  Tom Tromey  <tom@tromey.com>
10799             Andrew Burgess  <andrew.burgess@embecosm.com>
10800             Pedro Alves  <palves@redhat.com>
10801
10802 2019-01-23  Pedro Alves  <palves@redhat.com>
10803
10804         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10805
10806 2019-01-23  Pedro Alves  <palves@redhat.com>
10807             Andrew Burgess  <andrew.burgess@embecosm.com>
10808
10809         * gdbthread.h: Include "common/forward-scope-exit.h".
10810         (scoped_finish_thread_state): Redefine custom class in terms of
10811         forward_scope_exit.
10812
10813 2019-01-23  Pedro Alves  <palves@redhat.com>
10814             Andrew Burgess  <andrew.burgess@embecosm.com>
10815
10816         * common/forward-scope-exit.h: New file.
10817
10818 2019-01-23  Pedro Alves  <palves@redhat.com>
10819             Andrew Burgess  <andrew.burgess@embecosm.com>
10820             Tom Tromey  <tom@tromey.com>
10821
10822         * common/scope-exit.h: New file.
10823
10824 2019-01-23  Pedro Alves  <palves@redhat.com>
10825
10826         * common/preprocessor.h (ESC): Rename to ...
10827         (ESC_PARENS): ... this.
10828         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10829         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10830
10831 2019-01-23  Tom Tromey  <tom@tromey.com>
10832
10833         * language.h (class scoped_switch_to_sym_language_if_auto):
10834         Initialize m_lang in both cases.
10835
10836 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10837
10838         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10839         with XCNEW.
10840
10841 2019-01-22  Tom Tromey  <tom@tromey.com>
10842
10843         * corelow.c: Do not include sys/file.h.
10844
10845 2019-01-22  Tom Tromey  <tom@tromey.com>
10846
10847         * tui/tui-wingeneral.h: Include gdb_curses.h.
10848
10849 2019-01-22  Tom Tromey  <tom@tromey.com>
10850
10851         * source-cache.h (class source_cache) <get_source_lines,
10852         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10853
10854 2019-01-22  Tom Tromey  <tom@tromey.com>
10855
10856         * remote-fileio.h (struct remote_target): Declare.
10857
10858 2019-01-22  Tom Tromey  <tom@tromey.com>
10859
10860         * python/py-arch.c: Do not include py-ref.h.
10861         * python/py-bpevent.c: Do not include py-ref.h.
10862         * python/py-cmd.c: Do not include py-ref.h.
10863         * python/py-continueevent.c: Do not include py-ref.h.
10864         * python/py-event.h: Do not include py-ref.h.
10865         * python/py-evtregistry.c: Do not include py-ref.h.
10866         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10867         * python/py-frame.c: Do not include py-ref.h.
10868         * python/py-framefilter.c: Do not include py-ref.h.
10869         * python/py-function.c: Do not include py-ref.h.
10870         * python/py-infevents.c: Do not include py-ref.h.
10871         * python/py-linetable.c: Do not include py-ref.h.
10872         * python/py-objfile.c: Do not include py-ref.h.
10873         * python/py-param.c: Do not include py-ref.h.
10874         * python/py-prettyprint.c: Do not include py-ref.h.
10875         * python/py-progspace.c: Do not include py-ref.h.
10876         * python/py-symbol.c: Do not include py-ref.h.
10877         * python/py-symtab.c: Do not include py-ref.h.
10878         * python/py-type.c: Do not include py-ref.h.
10879         * python/py-unwind.c: Do not include py-ref.h.
10880         * python/py-utils.c: Do not include py-ref.h.
10881         * python/py-value.c: Do not include py-ref.h.
10882         * python/py-varobj.c: Do not include py-ref.h.
10883         * python/py-xmethods.c: Do not include py-ref.h.
10884         * python/python.c: Do not include py-ref.h.
10885         * varobj.c: Do not include py-ref.h.
10886
10887 2019-01-22  Tom Tromey  <tom@tromey.com>
10888
10889         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10890         keyword for bcache.
10891
10892 2019-01-22  Tom Tromey  <tom@tromey.com>
10893
10894         * compile/compile-cplus-types.c: Remove a comment by #include.
10895
10896 2019-01-22  Tom Tromey  <tom@tromey.com>
10897
10898         * compile/gcc-c-plugin.h: Include compile-internal.h.
10899
10900 2019-01-22  Tom Tromey  <tom@tromey.com>
10901
10902         * stabsread.c (EXTERN): Do not define.
10903         (symnum, next_symbol_text_func, processing_gcc_compilation)
10904         (within_function, global_sym_chain, global_stabs)
10905         (previous_stab_code, this_object_header_files)
10906         (n_this_object_header_files)
10907         (n_allocated_this_object_header_files): Define.
10908         * stabsread.h (EXTERN): Never define.  Use "extern".
10909
10910 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10911
10912         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10913         history_value.
10914
10915 2019-01-21  Tom Tromey  <tom@tromey.com>
10916
10917         * ui-out.c: Fix includes.
10918         * tui/tui-source.c: Fix includes.
10919         * target.c: Fix includes.
10920         * remote.c: Fix includes.
10921         * regcache.c: Fix includes.
10922         * python/py-block.c: Fix includes.
10923         * printcmd.c: Fix includes.
10924         * or1k-tdep.c: Fix includes.
10925         * mi/mi-main.c: Fix includes.
10926         * m32r-tdep.c: Fix includes.
10927         * csky-tdep.c: Fix includes.
10928         * compile/compile-cplus-types.c: Fix includes.
10929         * cli/cli-interp.c: Fix includes.
10930
10931 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10932
10933         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10934         for padding.
10935
10936 2019-01-16  Tom Tromey  <tom@tromey.com>
10937
10938         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10939         earlier.
10940         (struct objfile) <msymbols_range>: Move from top level.
10941         <msymbols>: New method.
10942         (class objfile_msymbols): Remove.
10943         * symtab.c (default_collect_symbol_completion_matches_break_on):
10944         Update.
10945         * symmisc.c (dump_msymbols): Update.
10946         * stabsread.c (scan_file_globals): Update.
10947         * objc-lang.c (info_selectors_command, info_classes_command)
10948         (find_methods): Update.
10949         * minsyms.c (find_solib_trampoline_target): Update.
10950         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10951         * coffread.c (coff_symfile_read): Update.
10952         * ada-lang.c (ada_lookup_simple_minsym)
10953         (ada_collect_symbol_completion_matches): Update.
10954
10955 2019-01-16  Tom Tromey  <tom@tromey.com>
10956
10957         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10958         type.  Remove no-argument constructor.
10959         <iterator::operator++>: Simplify.
10960         <begin>: Update.
10961         <end>: Use minimal_symbol_count.
10962
10963 2019-01-16  Tom Tromey  <tom@tromey.com>
10964
10965         * objfiles.h (struct objfile) <psymtabs>: New method.
10966         (class objfile_psymtabs): Remove.
10967         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10968         typedef.
10969         <range>: New method.
10970         (require_partial_symbols): Change return type.
10971         * psymtab.c (require_partial_symbols)
10972         (psym_expand_symtabs_matching): Update.
10973         * mdebugread.c (parse_partial_symbols): Update.
10974         * dbxread.c (dbx_end_psymtab): Update.
10975
10976 2019-01-15  Tom Tromey  <tom@tromey.com>
10977
10978         * symtab.c (lookup_objfile_from_block)
10979         (lookup_symbol_in_objfile_symtabs)
10980         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10981         (find_line_symtab, info_sources_command)
10982         (default_collect_symbol_completion_matches_break_on)
10983         (make_source_files_completion_list): Update.
10984         * symmisc.c (print_objfile_statistics, dump_objfile)
10985         (maintenance_print_symbols, maintenance_info_symtabs)
10986         (maintenance_check_symtabs, maintenance_info_line_tables):
10987         Update.
10988         * source.c (select_source_symtab)
10989         (forget_cached_source_info_for_objfile): Update.
10990         * objfiles.h (class objfile_compunits): Remove.
10991         (struct objfile) <compunits_range>: New typedef.
10992         (compunits): New method.
10993         * objfiles.c (objfile_relocate1): Update.
10994         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10995         * maint.c (count_symtabs_and_blocks): Update.
10996         * linespec.c (iterate_over_all_matching_symtabs): Update.
10997         * cp-support.c (add_symbol_overload_list_qualified): Update.
10998         * coffread.c (coff_symtab_read): Update.
10999         * ada-lang.c (add_nonlocal_symbols)
11000         (ada_collect_symbol_completion_matches)
11001         (ada_add_global_exceptions): Update.
11002
11003 2019-01-15  Tom Tromey  <tom@tromey.com>
11004
11005         * progspace.h (program_space) <objfiles_safe_range>: New
11006         typedef.
11007         <objfiles_safe>: New method.
11008         * objfiles.h (class all_objfiles_safe): Remove.
11009         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11010         * jit.c (jit_inferior_exit_hook): Update.
11011
11012 2019-01-17  Tom Tromey  <tom@tromey.com>
11013
11014         * progspace.h (program_space) <objfiles_range>: New typedef.
11015         <objfiles>: New method.
11016         <objfiles_head>: Rename from objfiles.
11017         (object_files): Update.
11018         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11019         * guile/scm-pretty-print.c
11020         (ppscm_find_pretty_printer_from_objfiles): Update.
11021         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11022         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11023         Update.
11024         * python/py-progspace.c (pspy_get_objfiles): Update.
11025         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11026         Update.
11027         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11028         (objfpy_lookup_objfile_by_build_id): Update.
11029         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11030         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11031         Update.
11032         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11033         (expand_symtab_containing_pc, lookup_objfile_from_block)
11034         (lookup_static_symbol, basic_lookup_transparent_type)
11035         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11036         (find_line_symtab, info_sources_command)
11037         (default_collect_symbol_completion_matches_break_on)
11038         (make_source_files_completion_list, find_main_name): Update.
11039         * symmisc.c (print_symbol_bcache_statistics)
11040         (print_objfile_statistics, maintenance_print_symbols)
11041         (maintenance_print_msymbols, maintenance_print_objfiles)
11042         (maintenance_info_symtabs, maintenance_check_symtabs)
11043         (maintenance_expand_symtabs, maintenance_info_line_tables):
11044         Update.
11045         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11046         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11047         (map_overlay_command, unmap_overlay_command)
11048         (simple_overlay_update, expand_symtabs_matching)
11049         (map_symbol_filenames): Update.
11050         * symfile-debug.c (set_debug_symfile): Update.
11051         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11052         Update.
11053         * source.c (select_source_symtab, forget_cached_source_info):
11054         Update.
11055         * solib.c (solib_read_symbols): Update.
11056         * solib-spu.c (append_ocl_sos): Update.
11057         * psymtab.c (maintenance_print_psymbols)
11058         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11059         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11060         * printcmd.c (info_symbol_command): Update.
11061         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11062         Update.
11063         * objfiles.h (class all_objfiles): Remove.
11064         * objfiles.c (have_partial_symbols, have_full_symbols)
11065         (have_minimal_symbols, qsort_cmp, update_section_map)
11066         (shared_objfile_contains_address_p)
11067         (default_iterate_over_objfiles_in_search_order): Update.
11068         * objc-lang.c (info_selectors_command, info_classes_command)
11069         (find_methods): Update.
11070         * minsyms.c (find_solib_trampoline_target): Update.
11071         * maint.c (maintenance_info_sections)
11072         (maintenance_translate_address, count_symtabs_and_blocks):
11073         Update.
11074         * main.c (captured_main_1): Update.
11075         * linux-thread-db.c (try_thread_db_load_from_pdir)
11076         (has_libpthread): Update.
11077         * linespec.c (iterate_over_all_matching_symtabs)
11078         (search_minsyms_for_name): Update.
11079         * jit.c (jit_find_objf_with_entry_addr): Update.
11080         * hppa-tdep.c (find_unwind_entry)
11081         (hppa_lookup_stub_minimal_symbol): Update.
11082         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11083         Update.
11084         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11085         (elf_gnu_ifunc_resolve_by_got): Update.
11086         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11087         * dwarf-index-write.c (save_gdb_index_command): Update.
11088         * cp-support.c (add_symbol_overload_list_qualified): Update.
11089         * breakpoint.c (create_overlay_event_breakpoint)
11090         (create_longjmp_master_breakpoint)
11091         (create_std_terminate_master_breakpoint)
11092         (create_exception_master_breakpoint): Update.
11093         * blockframe.c (find_pc_partial_function): Update.
11094         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11095         (ada_collect_symbol_completion_matches)
11096         (ada_add_global_exceptions): Update.
11097
11098 2019-01-17  Tom Tromey  <tom@tromey.com>
11099
11100         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11101         declare VEC.
11102         (solib_target_parse_libraries): Change return type.
11103         (library_list_start_segment, library_list_start_section)
11104         (library_list_end_library, library_list_start_library); Update.
11105         (solib_target_free_library_list): Remove.
11106         (solib_target_parse_libraries): Remove cleanup.  Change return
11107         type.
11108         (solib_target_current_sos): Update.
11109
11110 2019-01-17  Tom Tromey  <tromey@bapiya>
11111
11112         * valprint.c: Replace "the the" with "the".
11113         * symtab.c: Replace "the the" with "the".
11114         * solib.c: Replace "the the" with "the".
11115         * solib-dsbt.c: Replace "the the" with "the".
11116         * linespec.c: Replace "the the" with "the".
11117         * dwarf2loc.h: Replace "the the" with "the".
11118         * amd64-windows-tdep.c: Replace "the the" with "the".
11119         * aarch64-tdep.c: Replace "the the" with "the".
11120
11121 2019-01-16  Keith Seitz  <keiths@redhat.com>
11122
11123         PR gdb/23773
11124         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11125         <builder>: Rename to ..
11126         <m_builder>: ... this and make private.
11127         (dwarf2_cu::get_builder): New method.  Change all users of
11128         `builder' to use this method.
11129         (dwarf2_start_symtab): Move to ...
11130         (dwarf2_cu::start_symtab): ... here.  Update all callers
11131         (setup_type_unit_groups): Move to ...
11132         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11133         callers.
11134         (dwarf2_cu::reset_builder): New method.
11135         (process_full_compunit, process_full_type_unit): Use
11136         dwarf2_cu::reset_builder.
11137         (follow_die_offset): Record the ancestor CU if it is different
11138         from the followed DIE's CU.
11139         (follow_die_sig_1): Likewise.
11140
11141 2019-01-15  Tom Tromey  <tom@tromey.com>
11142
11143         * remote.c (class remote_state) <buf>: Now a char_vector.
11144         <buf_size>: Remove.
11145         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11146         parameter.
11147         (remote_target::getpkt_or_notif_sane_1)
11148         (remote_target::getpkt_sane)
11149         (remote_target::getpkt_or_notif_sane): Likewise.
11150         (class remote_target) <putpkt>: New overload.
11151         (remote_target::read_frame): Change type of "buf_p".  Remove
11152         sizeof_p parameter.
11153         (packet_ok): New overload.
11154         (packet_check_result): New overload.
11155         Update all uses.
11156
11157 2019-01-14  Tom Tromey  <tom@tromey.com>
11158
11159         * remote-notif.c (handle_notification, remote_notif_ack)
11160         (remote_notif_parse): Make "buf" const.
11161         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11162         const.
11163         (remote_notif_parse, remote_notif_ack, handle_notification):
11164         Likewise.
11165         * remote.c (remote_notif_stop_parse): Make "buf" const.
11166         (remote_target::remote_parse_stop_reply): Make "buf" const.
11167         (remote_notif_stop_ack): Make "buf" const.
11168
11169 2019-01-14  Tom Tromey  <tom@tromey.com>
11170
11171         * remote.c (remote_console_output): Make parameter const.
11172
11173 2019-01-14  Tom Tromey  <tom@tromey.com>
11174
11175         * target-debug.h (target_debug_print_signals): Constify.
11176         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11177         * procfs.c (procfs_target::pass_signals): Update.
11178         * linux-nat.c (linux_nat_target::pass_signals): Update.
11179         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11180         * target-delegates.c: Rebuild.
11181         * remote.c (remote_target::program_signals): Update.
11182         (remote_target::pass_signals): Update.
11183         * target.c (target_pass_signals): Constify argument.
11184         (target_program_signals): Likewise.
11185         * target.h (struct target_ops) <pass_signals, program_signals>:
11186         Constify argument.
11187         (target_pass_signals, target_program_signals): Constify argument.
11188
11189 2019-01-14  Tom Tromey  <tom@tromey.com>
11190
11191         PR tui/28819:
11192         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11193
11194 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11195
11196         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11197         field.
11198         * rs6000-tdep.c: Include reggroups.h.
11199         (IS_V_ALIAS_PSEUDOREG): Define.
11200         (rs6000_register_name): Return names for the "vX" aliases.
11201         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11202         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11203         aliases.  Call default_register_reggroup_p for all other
11204         pseudo-registers.
11205         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11206         New functions.
11207         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11208         Handle "vX" aliases.
11209         (v_alias_pseudo_register_collect): New function.
11210         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11211         (rs6000_gdbarch_init): Initialize "vX" aliases as
11212         pseudo-registers.  Restore registration of
11213         rs6000_pseudo_register_reggroup_p with
11214         set_tdesc_pseudo_register_reggroup_p.
11215
11216 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11217
11218         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11219         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11220         set_gdbarch_num_pseudo_regs.
11221
11222 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11223
11224         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11225         Remove arg prefixname, add do_set and do_show.
11226         Add member functions set_list and show_list.
11227         * cli/cli-style.c (class cli_style_option): Update accordingly.
11228         (style_set_list): Move to file scope.
11229         (style_show_list): Likewise.
11230         (set_style): Call help_list.
11231         (show_style): Call cmd_show_list.
11232         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11233         Update to use the new macro.
11234
11235 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11236
11237         * ada-lang.c (_initialize_ada_language): Expand the help text
11238         for the "catch exception" command.
11239
11240 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11241
11242         * symtab.c (matching_obj_sections): Initialize obj,
11243         declare it closer to its usage.
11244
11245 2019-01-10  Tom Tromey  <tom@tromey.com>
11246
11247         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11248         (basic_inf_threads_range): Remove.
11249         (inf_threads_range, inf_non_exited_threads_range)
11250         (safe_inf_threads_range): Use next_adapter.
11251
11252 2019-01-10  Keith Seitz  <keiths@redhat.com>
11253
11254         PR gdb/23712
11255         PR symtab/23010
11256         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11257         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11258
11259 2019-01-10  Keith Seitz  <keiths@redhat.com>
11260
11261         PR gdb/23712
11262         PR symtab/23010
11263         * dictionary.c (pending_to_vector): Remove.
11264         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11265         Remove _1 suffix, replacing functions of the same name.  Update
11266         all callers.
11267         (dict_create_hashed, dict_create_hashed_expandable)
11268         (dict_create_linear, dict_create_linear_expandable, dict_free)
11269         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11270         Make functions static.
11271
11272 2019-01-10  Keith Seitz  <keiths@redhat.com>
11273
11274         PR gdb/23712
11275         PR symtab/23010
11276         * dictionary.h (struct dictionary): Replace declaration with
11277         multidictionary.
11278         (dict_create_hashed, dict_create_hashed_expandable)
11279         (dict_create_linear, dict_create_linear_expandable)
11280         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11281         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11282         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11283         taking multidictionary argument.
11284         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11285         * block.h (struct block) <dict>: Change to multidictionary
11286         and rename `multidict'.
11287         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11288         symmisc.c: Update all dictionary references to multidictionary.
11289
11290 2019-01-10  Keith Seitz  <keiths@redhat.com>
11291
11292         PR gdb/23712
11293         PR symtab/23010
11294         * dictionary.c: Include unordered_map.
11295         (pending_to_vector): New function.
11296         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11297         Rewrite the non-"_1" functions to take vector instead
11298         of linked list.
11299         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11300         "new" _1 versions of the same name.
11301         (multidictionary): Define.
11302         (std::hash<enum language): New definition.
11303         (collate_pending_symbols_by_language, mdict_create_hashed)
11304         (mdict_create_hashed_expandable, mdict_create_linear)
11305         (mdict_create_linear_expandable, mdict_free)
11306         (find_language_dictionary, create_new_language_dictionary)
11307         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11308         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11309         (mdict_size, mdict_empty): New functions.
11310         * dictionary.h (mdict_iterator): Define.
11311
11312 2019-01-10  Pedro Alves  <palves@redhat.com>
11313
11314         * breakpoint.c (read_uploaded_action)
11315         (create_tracepoint_from_upload): Adjust to use
11316         gdb::unique_xmalloc_ptr.
11317         * ctf.c (ctf_write_uploaded_tp):
11318         (SET_ARRAY_FIELD): Use emplace_back.
11319         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11320         * tracefile-tfile.c (tfile_write_uploaded_tp):
11321         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11322         gdb::unique_xmalloc_ptr.
11323         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11324         at_string, cond_string, cmd_strings>: Replace char pointers
11325         with gdb::unique_xmalloc_ptr.
11326
11327 2019-01-10  Pedro Alves  <palves@redhat.com>
11328
11329         * solib-target.c (library_list_start_library): Don't xstrdup name.
11330
11331 2019-01-10  Pedro Alves  <palves@redhat.com>
11332
11333         * mdebugread.c (parse_partial_symbols): Use
11334         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11335
11336 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11337
11338         * linux-fork.c (scoped_switch_fork_info)
11339         <~scoped_switch_fork_info>: Fix incorrect variable name.
11340
11341 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11342
11343         * linux-fork.c (scoped_switch_fork_info)
11344         <scoped_switch_fork_info>: Make explicit.
11345         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11346
11347 2019-01-10  Tom Tromey  <tom@tromey.com>
11348
11349         * objfiles.h (objfile::reset_psymtabs): Update.
11350         * objfiles.c (objfile::objfile): Update.
11351         * psymtab.h (psymtab_storage::obstack): Update.
11352         (psymtab_storage::m_obstack): Use gdb::optional.
11353         (class psymtab_storage): Update comment.  Remove objfile
11354         parameter.
11355         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11356
11357 2019-01-10  Tom Tromey  <tom@tromey.com>
11358
11359         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11360         <free_psymtabs>: Now private.
11361         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11362         (allocate_psymtab): Use new method.
11363
11364 2019-01-10  Tom Tromey  <tom@tromey.com>
11365
11366         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11367         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11368         * mdebugread.c (parse_partial_symbols): Use
11369         allocate_dependencies.
11370         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11371         allocate_dependencies.
11372         (process_psymtab_comp_unit_reader)
11373         (build_type_psymtab_dependencies): Likewise.
11374         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11375
11376 2019-01-10  Tom Tromey  <tom@tromey.com>
11377
11378         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11379         PSYMBOL_SET_LANGUAGE.
11380         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11381
11382 2019-01-10  Tom Tromey  <tom@tromey.com>
11383
11384         * psymtab.h (psymtab_storage::obstack): New method.
11385         <m_obstack>: Rename from obstack; now private.
11386         * psymtab.c (psymtab_storage): Update.
11387         * dwarf2read.c (create_addrmap_from_index)
11388         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11389         Update.
11390
11391 2019-01-10  Tom Tromey  <tom@tromey.com>
11392
11393         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11394         * objfiles.h (objfile::reset_psymtabs): New method.
11395
11396 2019-01-10  Tom Tromey  <tom@tromey.com>
11397
11398         * symmisc.c (print_symbol_bcache_statistics): Update.
11399         (print_objfile_statistics): Update.
11400         * symfile.c (reread_symbols): Update.
11401         * psymtab.h (class psymtab_storage): New.
11402         * psymtab.c (psymtab_storage): New constructor.
11403         (~psymtab_storage): New destructor.
11404         (require_partial_symbols): Update.
11405         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11406         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11407         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11408         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11409         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11410         (start_psymtab_common, end_psymtab_common)
11411         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11412         (allocate_psymtab): Update.
11413         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11414         Update.
11415         (dump_psymtab_addrmap, maintenance_print_psymbols)
11416         (maintenance_check_psymtabs): Update.
11417         (class objfile_psymtabs): Move to objfiles.h.
11418         * psympriv.h (discard_psymtab): Now inline.
11419         (psymtab_discarder::psymtab_discarder): Update.
11420         (psymtab_discarder::~psymtab_discarder): Update.
11421         (ALL_OBJFILE_PSYMTABS): Rewrite.
11422         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11423         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11424         Remove fields.
11425         <partial_symtabs>: New field.
11426         (class objfile_psymtabs): Move from psymtab.h.  Update.
11427         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11428         psymbol_cache.
11429         (objfile::~objfile): Don't destroy psymbol_cache.
11430         * mdebugread.c (parse_partial_symbols): Update.
11431         * dwarf2read.c (create_addrmap_from_index)
11432         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11433         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11434         (add_partial_subprogram, dwarf2_ranges_read): Update.
11435         * dwarf-index-write.c (write_address_map)
11436         (write_one_signatured_type, recursively_write_psymbols)
11437         (class debug_names, class debug_names, write_psymtabs_to_index):
11438         Update.
11439
11440 2019-01-10  Tom Tromey  <tom@tromey.com>
11441
11442         * symtab.h (SYMBOL_SET_NAMES): Update.
11443         (symbol_set_names): Update.
11444         (MSYMBOL_SET_NAMES): Update.
11445         * symtab.c (symbol_set_names): Change argument to be an
11446         objfile_per_bfd_storage.
11447         * psymtab.c (add_psymbol_to_bcache): Update.
11448         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11449
11450 2019-01-10  Tom Tromey  <tom@tromey.com>
11451
11452         * symtab.c (create_demangled_names_hash): Change argument to be an
11453         objfile_per_bfd_storage.
11454         (symbol_set_names): Update.
11455
11456 2019-01-10  Tom Tromey  <tom@tromey.com>
11457
11458         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11459         init_psymbol_list.
11460         * psymtab.c (init_psymbol_list): Do nothing if already called.
11461         * psympriv.h (init_psymbol_list): Add comment.
11462         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11463         init_psymbol_list.
11464         * dbxread.c (dbx_symfile_read): Unconditionally call
11465         init_psymbol_list.
11466
11467 2019-01-10  Tom Tromey  <tom@tromey.com>
11468
11469         * xcoffread.c (scan_xcoff_symtab): Update.
11470         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11471         "where".
11472         * mdebugread.c (parse_partial_symbols)
11473         (handle_psymbol_enumerators): Update.
11474         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11475         * dbxread.c (read_dbx_symtab): Update.
11476         * psympriv.h (psymbol_placement): New enum.
11477         (add_psymbol_to_list): Update.
11478
11479 2019-01-10  Tom Tromey  <tom@tromey.com>
11480
11481         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11482         static_psymbols parameters.
11483         (scan_xcoff_symtab): Update.
11484         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11485         static_psymbols parameters.
11486         * psympriv.h (start_psymtab_common): Update.
11487         * mdebugread.c (parse_partial_symbols): Update.
11488         * dwarf2read.c (create_partial_symtab): Update.
11489         * dbxread.c (read_dbx_symtab): Update.
11490         (start_psymtab): Remove global_psymbols and static_psymbols
11491         parameters.
11492
11493 2019-01-10  Tom Tromey  <tom@tromey.com>
11494
11495         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11496         * psymtab.c (allocate_psymtab): Add comment.
11497         * psympriv.h (allocate_psymtab): Add comment.
11498         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11499         initializations.
11500         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11501
11502 2019-01-10  Tom Tromey  <tom@tromey.com>
11503
11504         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11505         Don't declare.
11506         * mipsread.c: Include mdebugread.h.
11507         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11508         Declare.
11509         * elfread.c: Include mdebugread.h.
11510
11511 2019-01-09  Tom Tromey  <tom@tromey.com>
11512
11513         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11514         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11515         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11516         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11517         (psym_lookup_symbol, psym_find_last_source_symtab)
11518         (psym_forget_cached_source_info, psym_print_stats)
11519         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11520         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11521         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11522         (psym_find_compunit_symtab_by_address)
11523         (maintenance_print_psymbols, maintenance_info_psymtabs)
11524         (maintenance_check_psymtabs): Use ranged for.
11525         * psymtab.h (class objfile_psymtabs): New.
11526         (require_partial_symbols): Return objfile_psymtabs.
11527         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11528
11529 2019-01-09  Tom Tromey  <tom@tromey.com>
11530
11531         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11532         (find_pc_mapped_section, list_overlays_command)
11533         (map_overlay_command, unmap_overlay_command)
11534         (simple_overlay_update): Use all_objfiles.
11535         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11536         * printcmd.c (info_symbol_command): Use all_objfiles.
11537         * objfiles.h (ALL_OBJSECTIONS): Remove.
11538         * maint.c (maintenance_translate_address): Use all_objfiles.
11539         * gcore.c (gcore_create_callback): Use all_objfiles.
11540         (objfile_find_memory_regions): Likewise.
11541
11542 2019-01-09  Tom Tromey  <tom@tromey.com>
11543
11544         * symtab.c (find_line_symtab, info_sources_command)
11545         (make_source_files_completion_list): Use objfile_compunits.
11546         * source.c (select_source_symtab): Use objfile_compunits.
11547         * objfiles.h (struct objfile): Update comment.
11548         (ALL_OBJFILES): Remove.
11549         (ALL_FILETABS): Remove.
11550         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11551         objfile_compunits.
11552
11553 2019-01-09  Tom Tromey  <tom@tromey.com>
11554
11555         * symmisc.c (print_objfile_statistics, dump_objfile)
11556         (maintenance_print_symbols): Use compunit_filetabs.
11557         * source.c (forget_cached_source_info_for_objfile): Use
11558         compunit_filetabs.
11559         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11560         (ALL_FILETABS): Use compunit_filetabs.
11561         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11562         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11563
11564 2019-01-09  Tom Tromey  <tom@tromey.com>
11565
11566         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11567         (compunit_filetabs): New.
11568         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11569         compunit_filetabs.
11570         (info_sources_command, make_source_files_completion_list): Remove
11571         declaration.
11572         * symmisc.c (print_objfile_statistics, dump_objfile)
11573         (maintenance_print_symbols): Remove declaration.
11574         (maintenance_info_symtabs): Use compunit_filetabs.
11575         (maintenance_info_line_tables): Likewise.
11576         * source.c (select_source_symtab): Change local variable name.
11577         (forget_cached_source_info_for_objfile): Remove declaration.
11578         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11579         * objfiles.c (objfile_relocate1): Remove declaration.
11580         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11581         declaration.
11582         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11583         * coffread.c (coff_symtab_read): Remove declaration.
11584         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11585         compunit_filetabs.
11586
11587 2019-01-09  Tom Tromey  <tom@tromey.com>
11588
11589         * symtab.c (lookup_objfile_from_block)
11590         (find_pc_sect_compunit_symtab, search_symbols)
11591         (default_collect_symbol_completion_matches_break_on): Use
11592         objfile_compunits.
11593         * objfiles.h (ALL_COMPUNITS): Remove.
11594         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11595         * cp-support.c (add_symbol_overload_list_qualified): Use
11596         objfile_compunits.
11597         * ada-lang.c (ada_collect_symbol_completion_matches)
11598         (ada_add_global_exceptions): Use objfile_compunits.
11599
11600 2019-01-09  Tom Tromey  <tom@tromey.com>
11601
11602         * source.c (select_source_symtab)
11603         (forget_cached_source_info_for_objfile): Remove declaration.
11604         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11605         declaration.
11606         * maint.c (count_symtabs_and_blocks): Remove declaration.
11607         * cp-support.c (add_symbol_overload_list_qualified): Remove
11608         declaration.
11609         * coffread.c (coff_symtab_read): Remove declaration.
11610         * symtab.c (lookup_symbol_in_objfile_symtabs)
11611         (basic_lookup_transparent_type_1): Use objfile_compunits.
11612         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11613         (info_sources_command, search_symbols)
11614         (default_collect_symbol_completion_matches_break_on)
11615         (make_source_files_completion_list): Remove declaration.
11616         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11617         (ada_collect_symbol_completion_matches)
11618         (ada_add_global_exceptions): Remove declaration.
11619         * linespec.c (iterate_over_all_matching_symtabs): Use
11620         objfile_compunits.
11621         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11622         (class objfile_compunits): New.
11623         (ALL_COMPUNITS): Use objfile_compunits.
11624         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11625         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11626         objfile_compunits.
11627         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11628
11629 2019-01-09  Tom Tromey  <tom@tromey.com>
11630
11631         * symtab.c (search_symbols)
11632         (default_collect_symbol_completion_matches_break_on): Use
11633         objfile_msymbols.
11634         * ada-lang.c (ada_lookup_simple_minsym)
11635         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11636         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11637         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11638         objfile_msymbols.
11639         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11640         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11641         * objc-lang.c (find_methods): Use objfile_msymbols.
11642         (info_selectors_command, info_classes_command): Likewise.
11643         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11644         * objfiles.h (class objfile_msymbols): New.
11645         (ALL_OBJFILE_MSYMBOLS): Remove.
11646         (ALL_MSYMBOLS): Remove.
11647
11648 2019-01-09  Tom Tromey  <tom@tromey.com>
11649
11650         * common/next-iterator.h (next_adapter): Add Iterator template
11651         parameter.
11652         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11653         (class all_objfiles_safe): New.
11654         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11655         * objfiles.c (put_objfile_before): Update comment.
11656         (add_separate_debug_objfile): Likewise.
11657         (free_all_objfiles): Use all_objfiles_safe.
11658         (objfile_purge_solibs): Likewise.
11659
11660 2019-01-09  Tom Tromey  <tom@tromey.com>
11661
11662         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11663         (expand_symtab_containing_pc, lookup_static_symbol)
11664         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11665         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11666         all_objfiles.
11667         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11668         * breakpoint.c (create_overlay_event_breakpoint)
11669         (create_longjmp_master_breakpoint)
11670         (create_std_terminate_master_breakpoint)
11671         (create_exception_master_breakpoint): Use all_objfiles.
11672         * linux-thread-db.c (try_thread_db_load_from_pdir)
11673         (has_libpthread): Use all_objfiles.
11674         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11675         * linespec.c (iterate_over_all_matching_symtabs)
11676         (search_minsyms_for_name): Use all_objfiles.
11677         * maint.c (maintenance_info_sections): Use all_objfiles.
11678         * main.c (captured_main_1): Use all_objfiles.
11679         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11680         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11681         * guile/scm-pretty-print.c
11682         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11683         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11684         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11685         (maintenance_print_msymbols): Use all_objfiles.
11686         * source.c (select_source_symtab): Use all_objfiles.
11687         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11688         * symfile.c (remove_symbol_file_command)
11689         (expand_symtabs_matching, map_symbol_filenames): Use
11690         all_objfiles.
11691         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11692         all_objfiles.
11693         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11694         * objc-lang.c (find_methods): Use all_objfiles.
11695         * objfiles.c (have_partial_symbols, have_full_symbols)
11696         (have_minimal_symbols, qsort_cmp)
11697         (default_iterate_over_objfiles_in_search_order): Use
11698         all_objfiles.
11699         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11700         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11701         (maintenance_check_psymtabs): Use all_objfiles.
11702         (ALL_PSYMTABS): Remove.
11703         * compile/compile-object-run.c (do_module_cleanup): Use
11704         all_objfiles.
11705         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11706         * cp-support.c (add_symbol_overload_list_qualified): Use
11707         all_objfiles.
11708         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11709         Use all_objfiles.
11710         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11711         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11712         all_objfiles.
11713         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11714         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11715         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11716         Uses all_objfiles.
11717         * solib.c (solib_read_symbols): Use all_objfiles
11718
11719 2019-01-09  Tom Tromey  <tom@tromey.com>
11720
11721         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11722         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11723         all_objfiles.
11724         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11725         * symmisc.c (print_symbol_bcache_statistics)
11726         (print_objfile_statistics, maintenance_print_objfiles)
11727         (maintenance_info_symtabs, maintenance_check_symtabs)
11728         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11729         all_objfiles.
11730         * source.c (forget_cached_source_info): Use all_objfiles.
11731         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11732         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11733         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11734         * objfiles.c (update_section_map): Use all_objfiles.
11735         (shared_objfile_contains_address_p): Likewise.
11736         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11737         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11738
11739 2019-01-09  Tom Tromey  <tom@tromey.com>
11740
11741         * common/next-iterator.h: New file.
11742         * objfiles.h (class all_objfiles): New.
11743         (struct objfile_iterator): New.
11744
11745 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11746
11747         * NEWS: Move the description of the changed "frame", "select-frame",
11748          and "info frame" commands to the Changed commands section.
11749
11750 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11751
11752         * gdbtypes.c (check_stub_method_group): Remove handling of old
11753         mangling schemes.
11754         * linespec.c (find_methods): Likewise.
11755         * stabsread.c (read_member_functions): Likewise.
11756         * valops.c (search_struct_method): Likewise.
11757         (value_struct_elt_for_reference): Likewise.
11758         * NEWS: Mention this change.
11759
11760 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11761
11762         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11763         print_source_lines.
11764         * source.c (print_source_lines_base): Update line number check.
11765         (print_source_lines): New function.
11766         (source_lines_range::source_lines_range): New function.
11767         * source.h (class source_lines_range): New class.
11768         (print_source_lines): New declaration.
11769
11770 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11771
11772         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11773
11774 2019-01-08  Tom Tromey  <tom@tromey.com>
11775             Simon Marchi  <simon.marchi@ericsson.com>
11776
11777         PR gdb/24060
11778         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11779         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11780         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11781         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11782         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11783         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11784
11785 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11786
11787         * source.c (select_source_symtab): Move header comment to
11788         declaration in source.h.
11789         (forget_cached_source_info_for_objfile): Likewise.
11790         (forget_cached_source_info): Likewise.
11791         (identify_source_line): Likewise.
11792         * source.h (identify_source_line): Move declaration from symtab.h
11793         and add comment from source.c
11794         (print_source_lines): Likewise.
11795         (forget_cached_source_info_for_objfile): Likewise.
11796         (forget_cached_source_info): Likewise.
11797         (select_source_symtab): Likewise.
11798         (enum print_source_lines_flag): Move definition from symtab.h.
11799         * symtab.h (identify_source_line): Move declaration to source.h.
11800         (print_source_lines): Likewise.
11801         (forget_cached_source_info_for_objfile): Likewise.
11802         (forget_cached_source_info): Likewise.
11803         (select_source_symtab): Likewise.
11804         (enum print_source_lines_flag): Move definition to source.h.
11805         * tui/tui-hooks.c: Add 'source.h' include.
11806
11807 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11808
11809         * source.c (print_source_lines_base): Handle requests to print
11810         reverse line number sequences, and guard against empty lines
11811         string.
11812
11813 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11814
11815         * source.c (print_source_lines_base): Fix skip of '\r' if next
11816         character is '\n'.
11817
11818 2019-01-06  Tom Tromey  <tom@tromey.com>
11819
11820         * c-exp.y (struct c_parse_state) <macro_original_text,
11821         expansion_obstack>: New member.
11822         (macro_original_text, expansion_obstack): Remove globals.
11823         (scan_macro_expansion, scanning_macro_expansion)
11824         (finished_macro_expansion): Update.
11825         (scan_macro_cleanup): Remove.
11826         (yylex, c_parse): Update.
11827
11828 2019-01-06  Tom Tromey  <tom@tromey.com>
11829
11830         * c-exp.y (struct c_parse_state) <strings>: New member.
11831         (operator_stoken): Update.
11832
11833 2019-01-06  Tom Tromey  <tom@tromey.com>
11834
11835         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11836         (union type_stack_elt) <typelist_val>: Now a pointer to
11837         std::vector.
11838         (type_stack_cleanup): Don't declare.
11839         (push_typelist): Update.
11840         * parse.c (pop_typelist): Return a std::vector.
11841         (push_typelist): Take a std::vector.
11842         (follow_types): Update.  Do not free args.
11843         (type_stack_cleanup): Remove.
11844         * c-exp.y (struct c_parse_state): New.
11845         (cpstate): New global.
11846         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11847         (nonempty_typelist): Update.
11848         (func_mod): Create a new vector.
11849         (c_parse): Create a c_parse_state.
11850         (check_parameter_typelist): Do not delete params.
11851         (function_method): Update.  Do not delete type_list.
11852
11853 2019-01-06  Tom Tromey  <tom@tromey.com>
11854
11855         PR gdb/28155:
11856         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11857         check_typedef.
11858         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11859         (print_return_value): Likewise.
11860
11861 2019-01-05  Tom Tromey  <tom@tromey.com>
11862
11863         * contrib/cleanup_check.py: Remove.
11864         * contrib/gcc-with-excheck: Remove.
11865         * contrib/exsummary.py: Remove.
11866         * contrib/excheck.py: Remove.
11867
11868 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11869
11870         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11871         NULL. Initialize tpprev to NULL instead of assigning it
11872         to NULL on the next statement.
11873         * windows-nat.c (windows_delete_thread): Remove check for
11874         main_thread_id before printing thread exit notifications.
11875         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11876         Remove thread ID check against main_thread_id.
11877         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11878         windows_delete_thread.
11879         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11880
11881 2019-01-04  Tom Tromey  <tom@tromey.com>
11882
11883         * compile/compile.c (_initialize_compile): Use upper case for
11884         metasyntactic variables.
11885         * symmisc.c (_initialize_symmisc): Use upper case for
11886         metasyntactic variables.
11887         * psymtab.c (_initialize_psymtab): Use upper case for
11888         metasyntactic variables.
11889         * demangle.c (demangle_command): Use upper case for metasyntactic
11890         variables.
11891         (_initialize_demangler): Likewise.
11892         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11893         variables.
11894
11895 2019-01-03  Tom Tromey  <tom@tromey.com>
11896
11897         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11898
11899 2019-01-03  Tom Tromey  <tom@tromey.com>
11900
11901         * python/py-symtab.c (salpy_str): Update.
11902         (struct salpy_sal_object) <symtab>: Now a PyObject.
11903         (salpy_dealloc): Update.
11904         (del_objfile_sal): Use gdbpy_ref.
11905
11906 2019-01-03  Tom Tromey  <tom@tromey.com>
11907
11908         * python/py-type.c (convert_field): Use new_reference.  Return
11909         gdbpy_ref.
11910         (make_fielditem): Return gdbpy_ref.
11911         (typy_fields): Update.
11912         (typy_getitem): Update.
11913         (field_name): Return gdbpy_ref.  Use new_reference.
11914         (typy_iterator_iternext): Update.
11915
11916 2019-01-03  Tom Tromey  <tom@tromey.com>
11917
11918         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11919
11920 2019-01-03  Tom Tromey  <tom@tromey.com>
11921
11922         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11923         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11924         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11925         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11926         (pspy_set_type_printers): Likewise.
11927         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11928         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11929         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11930         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11931         (objfpy_set_type_printers): Likewise.
11932
11933 2019-01-03  Tom Tromey  <tom@tromey.com>
11934
11935         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11936         (gdbpy_print_stack): Use gdbpy_err_fetch.
11937         * python/python-internal.h (class gdbpy_err_fetch): New class.
11938         (class gdbpy_enter) <m_error_type, m_error_value,
11939         m_error_traceback>: Remove.
11940         <m_error>: New member.
11941         (gdbpy_exception_to_string): Don't declare.
11942         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11943         * python/py-value.c (convert_value_from_python): Use
11944         gdbpy_err_fetch.
11945         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11946         gdbpy_exception_to_string.
11947         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11948         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11949         gdbpy_err_fetch.
11950
11951 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11952
11953         * linux-nat.c (delete_lwp_cleanup): Delete.
11954         (struct lwp_deleter): New struct.
11955         (lwp_info_up): New typedef.
11956         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11957         lwp_info_up.
11958
11959 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11960
11961         * linux-fork.c (class scoped_switch_fork_info): New class.
11962         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11963
11964 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11965
11966         * valops.c (find_overload_match): Remove use of null_cleanup, and
11967         calls to do_cleanups.
11968
11969 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11970
11971         * compile/compile-cplus-types.c
11972         (compile_cplus_instance::decl_name): Handle changes to
11973         cp_func_name.
11974         * cp-support.c (cp_func_name): Update header comment, update
11975         return type.
11976         * cp-support.h (cp_func_name): Update return type in declaration.
11977         * valops.c (find_overload_match): Move temp_func local to top
11978         level of function and change its type.  Use temp_func to hold and
11979         delete temporary string obtained from cp_func_name.
11980
11981 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11982
11983         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11984         gdb::char_vector, remove cleanup, and update uses of `msg`.
11985
11986 2019-01-03  Jim Wilson  <jimw@sifive.com>
11987
11988         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11989
11990 2019-01-02  Tom Tromey  <tom@tromey.com>
11991
11992         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11993         (tdesc_parse_xml): Remove cleanups.
11994         * target-descriptions.h (make_cleanup_free_target_description):
11995         Don't declare.
11996         (target_desc_deleter): New struct.
11997         (target_desc_up): New typedef.
11998         * target-descriptions.c (target_desc_deleter::operator()): Rename
11999         from free_target_description.
12000         (make_cleanup_free_target_description): Remove.
12001
12002 2019-01-02  Tom Tromey  <tom@tromey.com>
12003
12004         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12005         constructor, destructor.
12006         (linespec_parser): Remove typedef.
12007         (~linespec_parser): Rename from linespec_parser_delete.
12008         (linespec_lex_to_end, linespec_complete_label)
12009         (linespec_complete): Update.
12010         (decode_line_full): Remove cleanups.
12011         (decode_line_1): Update.
12012
12013 2019-01-02  Tom Tromey  <tom@tromey.com>
12014
12015         * python/python-internal.h (inferior_to_inferior_object): Change
12016         return type.
12017         * python/py-exitedevent.c (create_exited_event_object): Update.
12018         * python/py-inferior.c (inferior_to_inferior_object): Return
12019         gdbpy_ref.
12020         (python_new_inferior, python_inferior_deleted)
12021         (thread_to_thread_object, delete_thread_object)
12022         (build_inferior_list, gdbpy_selected_inferior): Update.
12023         * python/py-infthread.c (create_thread_object): Update.  Also fail
12024         if inferior_to_inferior_object fails.
12025
12026 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12027
12028         * inferior.h (class inferior) <displaced_step_state>: New field.
12029         * infrun.h (struct displaced_step_state): Move here from
12030         infrun.c.  Initialize fields, add constructor.
12031         <inf>: Remove field.
12032         <reset>: New method.
12033         * infrun.c (struct displaced_step_inferior_state): Move to
12034         infrun.h.
12035         (displaced_step_inferior_states): Remove.
12036         (get_displaced_stepping_state): Adust.
12037         (displaced_step_in_progress_any_inferior): Adjust.
12038         (displaced_step_in_progress_thread): Adjust.
12039         (displaced_step_in_progress): Adjust.
12040         (add_displaced_stepping_state): Remove.
12041         (get_displaced_step_closure_by_addr): Adjust.
12042         (remove_displaced_stepping_state): Remove.
12043         (infrun_inferior_exit): Call displaced_step_state.reset.
12044         (use_displaced_stepping): Don't check for NULL.
12045         (displaced_step_prepare_throw): Call
12046         get_displaced_stepping_state.
12047         (displaced_step_fixup): Don't check for NULL.
12048         (prepare_for_detach): Don't check for NULL.
12049
12050 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12051
12052         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12053          in case of call that did not complete.
12054
12055 2019-01-02  Andrey Utkin  <autkin@undo.io>
12056
12057         * symfile.c (find_separate_debug_file): Fix search of debug files for
12058         remote debuggee.
12059
12060 2019-01-02  Tom Tromey  <tom@tromey.com>
12061
12062         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12063         indentation.
12064         * python/py-frame.c (frapy_older): Remove cast.
12065         (frapy_newer): Likewise.
12066         * python/py-breakpoint.c (local_setattro): Remove cast.
12067         * python/py-arch.c (archpy_name): Remove local variable.
12068         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12069
12070 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12071
12072         * unittests/basic_string_view/element_access/char/empty.cc:
12073         Fix year range in copyright header.
12074
12075 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12076
12077         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12078         Delete.
12079         <operator==>: Update with for removed field.
12080         <hash>: Likewise.
12081         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12082         <isa_features>: ...this.
12083         <abi_features>: New field.
12084         (riscv_isa_flen): Update comment.
12085         (riscv_abi_xlen): New declaration.
12086         (riscv_abi_flen): New declaration.
12087         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12088         isa_features.
12089         (riscv_abi_xlen): New function.
12090         (riscv_isa_flen): Update to get answer from isa_features.
12091         (riscv_abi_flen): New function.
12092         (riscv_has_fp_abi): Update to get answer from abi_features.
12093         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12094         xlen and flen.
12095         (riscv_call_info) <xlen, flen>: Update comment.
12096         (riscv_call_arg_struct): Remove invalid assertions
12097         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12098         is removed.
12099         (riscv_gdbarch_init): Gather isa features and abi features
12100         separately, ensure both match on the gdbarch when reusing an old
12101         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12102         a target with 64-bit float hardware.
12103
12104 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12105
12106         * source.c (search_command_helper): Stop reverse search
12107         when line 1 has been searched.
12108
12109 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12110
12111         * record-full.c (record_full_base_target::close): Rewrite
12112         record_full_core_buf_list free logic.
12113
12114 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12115
12116         * break-catch-syscall.c (print_one_catch_syscall): xfree
12117         the last text.
12118
12119 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12120
12121         * top.c (print_gdb_version): Update Copyright year in version
12122         message.
12123
12124 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12125
12126         Update copyright year range in all GDB files.
12127
12128 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12129
12130         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12131
12132 For older changes see ChangeLog-2018.
12133 \f
12134 Local Variables:
12135 mode: change-log
12136 left-margin: 8
12137 fill-column: 74
12138 version-control: never
12139 coding: utf-8
12140 End:
12141