gdb/ChangeLog

   1 2019-06-14  Tom Tromey  <tom@tromey.com>
   2
   3         * gnulib: Move directory to top-level.
   4         * configure.ac: Don't configure gnulib.
   5         * configure: Rebuild.
   6         * common/common-defs.h: Use new path to gnulib.
   7         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
   8         (GNULIB_H): Remove.
   9         (INCGNU): Look in new gnulib location.
  10         (HFILES_NO_SRCDIR): Remove gnulib files.
  11         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
  12         (generated_files): Remove GNULIB_H.
  13         ($(LIBGNU), all-lib): Remove targets.
  14         (distclean): Don't mention GNULIB_BUILDDIR.
  15         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
  16
  17 2019-06-14  Tom Tromey  <tromey@adacore.com>
  18
  19         * symfile.c (add_symbol_file_command): Remove obsolete comment.
  20         Warn if symbol file does not provide any symbols.
  21
  22 2019-06-14  Tom Tromey  <tromey@adacore.com>
  23
  24         * source.c (find_and_open_source): Respect basenames_may_differ.
  25
  26 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
  27
  28         * annotate.c (annotate_breakpoints_invalid): Make use of
  29         scoped_restore_terminal_state.
  30         (annotate_frames_invalid): Likewise.
  31
  32 2019-06-14  Tom Tromey  <tromey@adacore.com>
  33
  34         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
  35         allow assignment to an internalvar.
  36
  37 2019-06-14  Tom Tromey  <tromey@adacore.com>
  38
  39         * ada-lex.l: Allow "_" in attribute names.
  40
  41 2019-06-14  Tom Tromey  <tromey@adacore.com>
  42
  43         PR gdb/24653:
  44         * regcache.c (registers_changed): Don't call alloca.
  45         * top.c (execute_command): Don't call alloca.
  46
  47 2019-06-13  Pedro Alves  <palves@redhat.com>
  48
  49         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
  50         'expression'.  When parsing an expression, error out if there's
  51         junk after "unlimited".
  52         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  53         (do_set_command): Adjust calls to is_unlimited_literal.
  54
  55 2019-06-13  Pedro Alves  <palves@redhat.com>
  56
  57         * compile/compile.c (make_compile_options_def_group): Add braces
  58         around array_view initializer.
  59         * thread.c (make_thread_apply_all_options_def_group)
  60         (make_thread_apply_all_options_def_group): Likewise.
  61
  62 2019-06-13  Pedro Alves  <palves@redhat.com>
  63
  64         * NEWS (New commands): Mention "maint test-options
  65         require-delimiter", "maint test-options unknown-is-error", "maint
  66         test-options unknown-is-operand" and "maint show
  67         test-options-completion-result".
  68         (New command options, command completion): New section.
  69         (Completion improvements): New section.
  70         Mention that you can abbreviate "unlimited".
  71
  72 2019-06-13  Pedro Alves  <palves@redhat.com>
  73
  74         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
  75         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
  76         * unittests/cli-utils-selftests.c (test_parse_flags)
  77         (test_parse_flags_qcs): Delete.
  78         (test_cli_utils): Don't call deleted functions.
  79
  80 2019-06-13  Pedro Alves  <palves@redhat.com>
  81
  82         * thread.c: Include "cli/cli-option.h".
  83         (tp_array_compar_ascending): Global.
  84         (tp_array_compar): Delete function.
  85         (tp_array_compar_ascending, tp_array_compar_descending): New
  86         functions.
  87         (ascending_option_def, qcs_flag_option_def)
  88         (thr_qcs_flags_option_defs)
  89         (make_thread_apply_all_options_def_group)
  90         (make_thread_apply_options_def_group): New.
  91         (thread_apply_all_command): Use gdb::option::process_options.
  92         (thread_apply_command_completer)
  93         (thread_apply_all_command_completer): New.
  94         (thread_apply_command): Use gdb::option::process_options.
  95         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
  96         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
  97         to generate help text of "thread apply".  Adjust "taas"'s help.
  98         * tid-parse.c (tid_range_parser::in_thread_range): New method.
  99         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 100
 101 2019-06-13  Pedro Alves  <palves@redhat.com>
 102
 103         * thread.c (thread_apply_command): Check for invalid TID with
 104         isdigit instead of !isalpha.
 105
 106 2019-06-13  Pedro Alves  <palves@redhat.com>
 107
 108         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 109         (validate_flags_qcs): New.
 110         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 111         (validate_flags_qcs): Declare.
 112         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 113         (make_frame_apply_options_def_group): New.
 114         (frame_apply_command_count): Process options with
 115         gdb::option::process_options.
 116         (frame_apply_completer): New.
 117         (frame_apply_level_completer, frame_apply_all_completer)
 118         (frame_apply_completer): New.
 119         (_initialize_stack): Update help of "frame apply", "frame apply
 120         level", "frame apply all" and "faas" to mention supported options
 121         and install command completers.
 122         * stack.h (frame_apply_all_completer): Declare.
 123         * thread.c: Include "stack.h".
 124         (tfaas_command): Add "--".
 125         (_initialize_thread): Update help "tfaas" to mention supported
 126         options and install command completer.
 127
 128 2019-06-13  Pedro Alves  <palves@redhat.com>
 129
 130         * completer.c (complete_nested_command_line): New.
 131         (gdb_completion_word_break_characters_throw): Add assertion.
 132         * completer.h (complete_nested_command_line): Declare.
 133
 134 2019-06-13  Pedro Alves  <palves@redhat.com>
 135
 136         * stack.c (parse_backtrace_qualifiers): New.
 137         (backtrace_command): Use it.
 138         (backtrace_command_completer): Complete on qualifiers.
 139
 140 2019-06-13  Pedro Alves  <palves@redhat.com>
 141
 142         * frame.c: Include "cli/cli-option.h.
 143         (user_set_backtrace_options): New.
 144         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 145         Delete.
 146         (get_prev_frame): Adjust.
 147         (boolean_option_def, uinteger_option_def)
 148         (set_backtrace_option_defs): New.
 149         (_initialize_frame): Adjust and use
 150         gdb::option::add_setshow_cmds_for_options to install "set
 151         backtrace past-main" and "set backtrace past-entry".
 152         * frame.h: Include "cli/cli-option.h".
 153         (struct frame_print_options): Forward declare.
 154         (print_frame_arguments_all, print_frame_arguments_scalars)
 155         (print_frame_arguments_none): Declare.
 156         (print_entry_values): Delete declaration.
 157         (struct frame_print_options, user_frame_print_options): New.
 158         (struct set_backtrace_options): New.
 159         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 160         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 161         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 162         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 163         (list_args_or_locals): Add frame_print_options parameter.
 164         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 165         * python/py-framefilter.c (enumerate_args): Pass down
 166         USER_FRAME_PRINT_OPTIONS.
 167         * stack.c: Include "cli/cli-option.h".
 168         (print_frame_arguments_all, print_frame_arguments_scalars)
 169         (print_frame_arguments_none): Declare.
 170         (print_raw_frame_arguments, print_entry_values): Delete.
 171         (user_frame_print_options): New.
 172         (boolean_option_def, enum_option_def, frame_print_option_defs):
 173         New.
 174         (struct backtrace_cmd_options): New.
 175         (bt_flag_option_def): New.
 176         (backtrace_command_option_defs): New.
 177         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 178         (print_frame_arg, read_frame_arg, print_frame_args)
 179         (print_frame_info, print_frame): Add frame_print_options parameter
 180         and use it.
 181         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 182         (backtrace_command_1): Add frame_print_options and
 183         backtrace_cmd_options parameters and use them.
 184         (make_backtrace_options_def_group): New.
 185         (backtrace_command): Process command options with
 186         gdb::option::process_options.
 187         (backtrace_command_completer): New.
 188         (_initialize_stack): Extend "backtrace"'s help to mention
 189         supported options.  Install completer for "backtrace".
 190         Install some settings commands with add_setshow_cmds_for_options.
 191
 192 2019-06-13  Pedro Alves  <palves@redhat.com>
 193
 194         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 195         and that "set/show print raw frame-arguments" are now deprecated.
 196
 197         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 198         command.
 199         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 200         * stack.c (_initialize_stack): Install "set/show print
 201         raw-frame-arguments", and deprecate "set/show print raw
 202         frame-arguments".
 203         * valprint.c (_initialize_valprint): Deprecate "set/show print
 204         raw".
 205
 206 2019-06-13  Pedro Alves  <palves@redhat.com>
 207
 208         * compile/compile.c (struct compile_options): New.
 209         (compile_flag_option_def, compile_command_option_defs)
 210         (make_compile_options_def_group): New.
 211         (compile_file_command): Handle options with
 212         gdb::option::process_options.
 213         (compile_file_command_completer): New function.
 214         (compile_code_command): Handle options with
 215         gdb::option::process_options.
 216         (compile_code_command_completer): New function.
 217         (_initialize_compiler): Install completers for "compile code" and
 218         "compile file".  Mention available options in "compile code" and
 219         "compile code"'s help.
 220         * completer.c (advance_to_completion_word): New, factored out from
 221         ...
 222         (advance_to_expression_complete_word_point): ... this.
 223         (advance_to_filename_complete_word_point): New.
 224         * completer.h (advance_to_filename_complete_word_point): New
 225         declaration.
 226
 227 2019-06-13  Pedro Alves  <palves@redhat.com>
 228
 229         * compile/compile.c: Include "cli/cli-option.h".
 230         (compile_print_value): Scope data pointer is now a
 231         value_print_options pointer; adjust.
 232         (compile_print_command): Process options.  Scope data pointer is
 233         now a value_print_options pointer; adjust.
 234         (_initialize_compile): Update "compile print"'s help to include
 235         supported options.  Install a completer for "compile print".
 236         * cp-valprint.c (show_vtblprint, show_objectprint)
 237         (show_static_field_print): Delete.
 238         (_initialize_cp_valprint): Don't install "set print
 239         static-members", "set print vtbl", "set print object" here.
 240         * printcmd.c: Include "cli/cli-option.h" and
 241         "common/gdb_optional.h".
 242         (print_command_parse_format): Rework to fill in a
 243         value_print_options instead of a format_data.
 244         (print_value): Change parameter type from format_data pointer to
 245         value_print_options reference.  Adjust.
 246         (print_command_1): Process options.  Adjust to pass down a
 247         value_print_options.
 248         (print_command_completer): New.
 249         (_initialize_printcmd): Install print_command_completer as
 250         handle_brkchars completer for the "print" command.  Update
 251         "print"'s help to include supported options.
 252         * valprint.c: Include "cli/cli-option.h".
 253         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 254         here from cp-valprint.c.
 255         (boolean_option_def, uinteger_option_def)
 256         (value_print_option_defs, make_value_print_options_def_group):
 257         New.  Use gdb::option::add_setshow_cmds_for_options to install
 258         "set print elements", "set print null-stop", "set print repeats",
 259         "set print pretty", "set print union", "set print array", "set
 260         print address", "set print symbol", "set print array-indexes".
 261         * valprint.h: Include <string> and "cli/cli-option.h".
 262         (make_value_print_options_def_group): Declare.
 263         (print_value): Change parameter type from format_data pointer to
 264         value_print_options reference.
 265         (print_command_completer): Declare.
 266
 267 2019-06-13  Pedro Alves  <palves@redhat.com>
 268
 269         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 270         (COMMON_SFILES): Add maint-test-settings.c.
 271         * cli/cli-decode.c (boolean_enums): New global, factored out from
 272         ...
 273         (add_setshow_boolean_cmd): ... here.
 274         * cli/cli-decode.h (boolean_enums): Declare.
 275         * cli/cli-option.c: New file.
 276         * cli/cli-option.h: New file.
 277         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 278         factored out from ...
 279         (parse_cli_boolean_value(const char *)): ... this.
 280         (is_unlimited_literal): Change parameter type to pointer to
 281         pointer.  Adjust and advance ARG pointer.
 282         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 283         (parse_cli_var_enum): New, factored out from ...
 284         (do_set_command): ... this.  Adjust.
 285         * cli/cli-setshow.h (parse_cli_boolean_value)
 286         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 287         (parse_cli_var_enum): Declare.
 288         * cli/cli-utils.c: Include "cli/cli-option.h".
 289         (get_ulongest): New.
 290         * cli/cli-utils.h (get_ulongest): Declare.
 291         (check_for_argument): New overloads.
 292         * maint-test-options.c: New file.
 293
 294 2019-06-13  Pedro Alves  <palves@redhat.com>
 295
 296         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 297         parse a range if "-" is at the end of the string.
 298
 299 2019-06-13  Pedro Alves  <palves@redhat.com>
 300
 301         * cli/cli-setshow.c (parse_auto_binary_operation)
 302         (parse_cli_boolean_value): Don't allow "o".
 303
 304 2019-06-13  Pedro Alves  <palves@redhat.com>
 305
 306         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 307         * NEWS: Mention maint test-settings KIND.
 308         * maint-test-settings.c: New file.
 309
 310 2019-06-13  Pedro Alves  <palves@redhat.com>
 311
 312         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 313         completer.
 314         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 315         "set" completers.
 316
 317 2019-06-13  Pedro Alves  <palves@redhat.com>
 318
 319         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 320         after item.
 321
 322 2019-06-13  Pedro Alves  <palves@redhat.com>
 323
 324         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 325
 326 2019-06-13  Pedro Alves <palves@redhat.com>
 327
 328         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 329         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 330         call.
 331         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 332         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 333         calls.
 334         (check_for_argument): Skip spaces after argument.
 335
 336 2019-06-13  Pedro Alves  <palves@redhat.com>
 337
 338         * thread.c (thread_apply_command): Adjust TID parsing.
 339         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 340         detected before end of string.
 341         (tid_is_in_list): Error out if LIST is invalid.
 342
 343 2019-06-13  Pedro Alves  <palves@redhat.com>
 344
 345         * completer.c (complete_line_internal_1): Rewind completion word
 346         point.
 347         (completion_tracker::advance_custom_word_point_by): Change
 348         parameter type to int.
 349         * completer.h (completion_tracker::advance_custom_word_point_by):
 350         Likewise.
 351
 352 2019-06-13  Pedro Alves  <palves@redhat.com>
 353
 354         * completer.c (advance_to_completion_word): Handle delimiters.
 355
 356 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 357
 358         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 359
 360 2019-06-11  Tom Tromey  <tom@tromey.com>
 361
 362         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 363         (xmalloc_failed): Move to alloc.c.
 364         * alloc.c: New file.
 365         * Makefile.in (COMMON_SFILES): Add alloc.c.
 366
 367 2019-06-11  Tom Tromey  <tom@tromey.com>
 368
 369         * nat/linux-waitpid.c: Don't include server.h.
 370         (linux_debug): Remove.
 371         (my_waitpid): Update.
 372
 373 2019-06-11  Tom Tromey  <tromey@adacore.com>
 374
 375         * infcall.c (_initialize_infcall): Remove trailing newline from
 376         help.
 377         * user-regs.c (_initialize_user_regs): Remove trailing newline
 378         from help.
 379         * typeprint.c (_initialize_typeprint): Remove trailing newline
 380         from help.
 381         * reverse.c (_initialize_reverse): Remove trailing newlines from
 382         help.
 383         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 384         from help.
 385         * language.c (add_set_language_command): Remove trailing newline
 386         from help.
 387         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 388         help.
 389         * disasm.c (_initialize_disasm): Remove trailing newline from
 390         help.
 391         * top.c (init_main): Remove trailing newline from help.
 392         * interps.c (_initialize_interpreter): Remove trailing newline
 393         from help.
 394         * btrace.c (_initialize_btrace): Remove trailing newlines from
 395         help.
 396         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 397         from help.
 398         * python/python.c (_initialize_python): Remove trailing newline
 399         from help.
 400         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 401         help.
 402         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 403         from help.  Reformat some text.
 404         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 405         from help.
 406         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 407         newline from help.
 408
 409 2019-06-11  Tom Tromey  <tromey@adacore.com>
 410
 411         * darwin-nat.c (darwin_decode_exception_message)
 412         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 413
 414 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 415
 416         * valops.c (value_slice): Check for not allocated or not
 417         associated values.
 418
 419 2019-06-10  Tom de Vries  <tdevries@suse.de>
 420
 421         PR gdb/24618
 422         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 423         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 424         invalid.
 425
 426 2019-06-10  Tom de Vries  <tdevries@suse.de>
 427
 428         PR gdb/24611
 429         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 430         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 431
 432 2019-06-10  Tom de Vries  <tdevries@suse.de>
 433
 434         PR symtab/24545
 435         * symtab.c (struct demangled_name_entry): Add language field.
 436         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 437         static minimal symbol".  Set and use language field.
 438
 439 2019-06-10  Tom Tromey  <tromey@adacore.com>
 440
 441         * ada-lang.c (_initialize_ada_language): Update help text.
 442
 443 2019-06-10  Tom Tromey  <tromey@adacore.com>
 444
 445         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 446         with a newline.
 447         * guile/guile.c (handle_boot_error): Don't end warning with a
 448         newline.
 449         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 450         warning with a newline.
 451         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 452         newline.
 453         (s12z_frame_cache): Likewise.
 454         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 455         a newline.
 456         * solib-svr4.c (disable_probes_interface): Don't end warning with
 457         a newline.
 458         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 459         newline.
 460         * python/python.c (do_finish_initialization): Don't end warning
 461         with a newline.
 462
 463 2019-06-10  Tom Tromey  <tom@tromey.com>
 464
 465         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 466         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 467         gdbpy_enter.
 468
 469 2019-06-10  Tom Tromey  <tromey@adacore.com>
 470
 471         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 472         data.
 473         (elf_new_init): Don't call stabsread_new_init.
 474         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 475         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 476         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 477
 478 2019-06-10  Tom de Vries  <tdevries@suse.de>
 479
 480         PR symtab/16264
 481         PR symtab/24517
 482         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 483
 484 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 485
 486         * source.c (find_and_open_source): Also rewrite relative file
 487         names.
 488
 489 2019-04-26  Amos Bird  <amosbird@gmail.com>
 490
 491         * annotate.c (annotate_thread_exited): Add "thread-exited"
 492         annotation.
 493
 494 2019-06-06  Tom Tromey  <tromey@adacore.com>
 495
 496         * maint.h (class scoped_command_stats): Use
 497         DISABLE_COPY_AND_ASSIGN.
 498         <print_time>: New method.
 499         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 500         print_time.
 501         (scoped_command_stats::print_time): New method.
 502
 503 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 506         instructions of lengths 6 or 8 bytes.
 507
 508 2019-06-04  Pedro Alves  <palves@redhat.com>
 509
 510         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 511
 512         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 513         * breakpoint.c (condition_completer): Likewise.
 514         * cli/cli-dump.c (scan_expression): Likewise.
 515         * common/filestuff.c (mkdir_recursive): Likewise.
 516         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 517         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 518         (gdb_abspath): Likewise.
 519         * compile/compile-cplus-types.c
 520         (compile_cplus_instance::decl_name): Likewise.
 521         * completer.c (complete_explicit_location):
 522         (signal_completer, reg_or_group_completer_1): Likewise.
 523         * cp-support.c (cp_remove_params_if_any): Likewise.
 524         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 525         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 526         * infcmd.c (strip_bg_char): Likewise.
 527         * linespec.c (copy_token_string): Likewise.
 528         * mi/mi-main.c (output_cores): Likewise.
 529         * psymtab.c (psymtab_search_name):
 530         * symfile.c (test_set_ext_lang_command): Likewise.
 531         * target.c (target_fileio_read_stralloc): Likewise.
 532         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 533         * value.c (complete_internalvar): Likewise.
 534
 535 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 536
 537         Add objfile property to gdb.Type.
 538         * NEWS: Mention Python API addition.
 539         * python/py-type.c (typy_get_objfile): New method.
 540
 541 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 542
 543         * NEWS: Mention the new set|show style [title|highlight].
 544         Mention changes to "show style", "help" and "apropos".
 545
 546 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 547
 548         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 549         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 550         instead of print_help_for_command.
 551         (print_doc_of_command): New function.
 552         (help_list): Add 'apropos -v word' suggestion.
 553         (print_help_for_command): Style the command name using title style.
 554         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 555         (_initialize_cli_cmds): Describe -v in apropos_command help.
 556
 557 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 558
 559         * cli/cli-style.h (cli_style_option): Add name in constructor,
 560         add m_name class member, add constructor with intensity,
 561         add name class function.
 562         (cli_style_option::add_setshow_commands): Remove name argument.
 563         (highlight_style, title_style): New styles.
 564         * cli/cli-style.c (do_show): New function that shows a style
 565         characteristic styling the style name with itself.
 566         (set_style_name): New function.
 567         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 568         Update all callers according to the changes in cli/cli-style.h.
 569         * utils.h (fputs_highlighted): New function.
 570         * utils.c (fputs_highlighted): Likewise.
 571
 572 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 573
 574         * NEWS: Mention new pipe command and new convenience variables.
 575
 576 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 577
 578         * cli/cli-cmds.c (pipe_command): New function.
 579         (_initialize_cli_cmds): Call add_com for pipe_command.
 580         Define | as an alias for pipe.
 581         (exit_status_set_internal_vars): New function.
 582         (shell_escape): Call exit_status_set_internal_vars.
 583         cli/cli-decode.c (find_command_name_length): Recognize | as
 584         a single character command.
 585
 586 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 587
 588         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 589         top.c (execute_command_to_ui_file): New function, mostly a copy
 590         of execute_command_to_string.
 591         (execute_command_to_string): Implement by calling
 592         execute_command_to_ui_file.
 593
 594 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 595
 596         * top.h (saved_command_line): Remove declaration.
 597         * top.c (previous_saved_command_line, previous_repeat_arguments):
 598         New variables.
 599         (saved_command_line): Make static, define together with other
 600         'repeat variables'.
 601         (dont_repeat): Clear repeat_arguments.
 602         (repeat_previous, get_saved_command_line, save_command_line):
 603         New functions.
 604         (gdb_init): Initialize saved_command_line
 605         and previous_saved_command_line.
 606         * main.c (captured_main_1): Remove saved_command_line initialization.
 607         * event-top.c (handle_line_of_input): Update to use
 608         the new 'repeat' related functions instead of direct access to
 609         saved_command_line.
 610         * command.h (repeat_previous, get_saved_command_line,
 611         save_command_line): New declarations.
 612         (dont_repeat): Add comment.
 613
 614 2019-05-30  Tom Tromey  <tromey@adacore.com>
 615
 616         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 617         Fix comment.
 618         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 619
 620 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 621
 622         PR cli/24587
 623         * completer.c (complete): Initialize variable word.
 624
 625 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 626
 627         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 628         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 629         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 630         'body' is NULL to the outter 'if', protecting the '!is_define'
 631         situation as well.
 632
 633 2019-05-29  Tom Tromey  <tromey@adacore.com>
 634
 635         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 636         (dwarf_unknown): New function.
 637         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 638         (dwarf_type_encoding_name): Use dwarf_unknown.
 639
 640 2019-05-29  Tom Tromey  <tromey@adacore.com>
 641
 642         PR c++/20020:
 643         * cp-valprint.c (cp_print_value_fields): Call
 644         cp_print_static_field inside "try".
 645
 646 2019-05-29  Tom Tromey  <tromey@adacore.com>
 647
 648         * inflow.c (struct terminal_info): Add default operator=.
 649         * configure: Rebuild.
 650         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 651         -Wdeprecated-copy-dtor, -Wredundant-move.
 652
 653 2019-05-29  Tom Tromey  <tromey@adacore.com>
 654
 655         * NEWS: Add entry.
 656         * infcmd.c (print_return_value_1): Handle finish_print
 657         option.
 658         (show_print_finish): New function.
 659         (_initialize_infcmd): Add "set/show print finish" commands.
 660         * valprint.c (user_print_options): Initialize new member.
 661         * valprint.h (struct value_print_options) <finish_print>: New
 662         member.
 663
 664 2019-05-28  Tom Tromey  <tromey@adacore.com>
 665
 666         * ada-lang.c (ada_remove_Xbn_suffix)
 667         (find_old_style_renaming_symbol)
 668         (parse_old_style_renaming): Remove.
 669         (ada_find_renaming_symbol): Don't call
 670         find_old_style_renaming_symbol.
 671         (ada_is_renaming_symbol): Rename from
 672         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 673         bool.  Now static.
 674         (ada_read_var_value): Update and simplify.
 675         * ada-exp.y (write_var_or_type): Remove old code.
 676
 677 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 678
 679         * event-top.c: Remove include comment.
 680         * inflow.c (class scoped_ignore_sigttou): Move from here...
 681         * inflow.h (class scoped_ignore_sigttou): ...to here.
 682         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 683         * top.c:  Remove include comment.
 684
 685 2019-05-27  Tom Tromey  <tom@tromey.com>
 686
 687         * NEWS: Fix typo.
 688
 689 2019-05-22  Tom Tromey  <tromey@adacore.com>
 690
 691         * target.c (target_follow_exec): Constify parameter.
 692         * target-delegates.c: Rebuild.
 693         * remote.c (remote_target::follow_exec): Constify parameter.
 694         * infrun.c (follow_exec): Constify parameter.
 695         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 696         (target_follow_exec): Likewise.
 697
 698 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 699
 700         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 701         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 702
 703 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 704
 705         * NEWS: Add debugredirect and testsuite sections.
 706
 707 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 708
 709         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 710         target descriptions using exclusively floating point register name
 711         aliases.
 712
 713 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 714
 715         PR gdb/18644:
 716         * f-lang.c (build_fortran_types): Handle the case where
 717         gdbarch_floatformat_for_type returns a nullptr.
 718
 719 2019-05-21  Tom de Vries  <tdevries@suse.de>
 720
 721         PR cli/24587
 722         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 723
 724 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 725
 726         PR gdb/18644:
 727         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 728         16-byte floats.
 729         * i386-tdep.c (i386_floatformat_for_type): Use
 730         floatformats_ia64_quad for the 16-byte floating point component
 731         within a fortran 32-byte complex number.
 732
 733 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 736         delete default constructor.
 737         (find_partial_die): Update to return const struct.
 738         (partial_die_parent_scope): Move variable declaration into scope
 739         of its use and change its type to auto.
 740         (guess_partial_die_structure_name): Likewise.
 741         (partial_die_info::fixup): Likewise.
 742
 743 2019-05-17  Tom Tromey  <tromey@adacore.com>
 744
 745         * source.c (find_and_open_source): Remove cast.
 746
 747 2019-05-17  Tom Tromey  <tromey@adacore.com>
 748
 749         * annotate.c (annotate_source): Make "filename" const.
 750         * annotate.h (annotate_source): Use const.
 751
 752 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 753
 754         * disasm.c (set_disassembler_options): Send errors to stderr.
 755
 756 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 757
 758         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 759         (cli_interp_base::set_logging): Check debug_redirect.
 760         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 761         * cli/cli-logging.c (debug_redirect): Add static variable.
 762         (pop_output_files): Add default param.
 763         (handle_redirections): Print debug setting.
 764         (show_logging_command): Likewise.
 765         (_initialize_cli_logging): Add debugredirect command.
 766         * interps.c (current_interp_set_logging): Add debug_redirect
 767         parameter.
 768         * interps.h (set_logging): Add debug_redirect parameter.
 769         (current_interp_set_logging): Likewise.
 770         * mi/mi-common.h: Likewise.
 771         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 772
 773 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 774             Tom Tromey  <tromey@adacore.com>
 775
 776         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 777         directly.
 778         * cli/cli-interp.h (make_logging_output): Remove declaration.
 779         * cli/cli-logging.c (make_logging_output): Remove function.
 780         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 781         directly.
 782         * ui-file.c (tee_file::tee_file): Remove bools.
 783         (tee_file::~tee_file): Remove deletes.
 784         * ui-file.h (tee_file): Remove bools.
 785
 786 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 787
 788         * mi/mi-cmds.h (mi_cmd_complete): New function.
 789         * mi/mi-main.c (mi_cmd_complete): Likewise.
 790         * mi/mi-cmds.c: Define new MI command -complete.
 791         * NEWS: Mention new -complete command.
 792
 793 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 794
 795         * completer.h (complete): New function.
 796         * completer.c (complete): Likewise.
 797         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 798         function defined in completer.h.
 799
 800 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 801
 802        * MAINTAINERS (Write After Approval): Add myself.
 803
 804 2019-05-17  Tom de Vries  <tdevries@suse.de>
 805
 806         PR gdb/24094
 807         * dwarf2read.c (struct cu_partial_die_info): New struct.
 808         (find_partial_die): Return cu_partial_die_info.
 809         (partial_die_parent_scope, guess_partial_die_structure_name)
 810         (partial_die_info::fixup): Handle new return type of find_partial_die.
 811
 812 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 813
 814         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 815         "std::string", simplifying the algorithm.
 816
 817 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 818
 819         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 820         (stap_static_probe_ops::get_probes): Likewise.
 821
 822 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 823
 824         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 825         '-')" and "else if".
 826         (stap_parse_single_operand): Join checks for
 827         "gdbarch_stap_parse_special_token_p" and
 828         "gdbarch_stap_parse_special_token" in the same "if" statement.
 829         Invert check when verifying for operation on register
 830         displacement.
 831
 832 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 833
 834         * stap-probe.c (stap_get_opcode): Update comment.
 835         (stap_get_expected_argument_type): Likewise.
 836         (handle_stap_probe): Likewise.
 837
 838 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 839
 840         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 841         return type to 'bool'.  Adjust comment.  Use 'bool' when
 842         appropriate.
 843         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 844         * stap-probe.c (stap_parse_argument_1): Likewise.
 845         (stap_is_operator): Likewise.
 846         (stap_is_generic_prefix): Likewise.
 847         (stap_is_register_prefix): Likewise.
 848         (stap_is_register_indirection_prefix): Likewise.
 849         (stap_is_integer_prefix): Likewise.
 850         (stap_generic_check_suffix): Likewise.
 851         (stap_check_integer_suffix): Likewise.
 852         (stap_check_register_suffix): Likewise.
 853         (stap_check_register_indirection_suffix): Likewise.
 854         (stap_parse_register_operand): Likewise.
 855         (stap_parse_single_operand): Likewise.
 856         (stap_parse_argument_1): Likewise.
 857         (stap_probe::get_argument_count): Likewise.
 858         (stap_is_operator): Likewise.
 859
 860 2019-05-16  Tom Tromey  <tromey@adacore.com>
 861
 862         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 863         keyword to foreach.
 864
 865 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 866
 867         * linux-thread-db.c (try_thread_db_load_1): Change return type
 868         to bool.
 869         (try_thread_db_load): Likewise.
 870         (try_thread_db_load_from_pdir_1): Likewise.
 871         (try_thread_db_load_from_pdir): Likewise.
 872         (try_thread_db_load_from_sdir): Likewise.
 873         (try_thread_db_load_from_dir): Likewise.
 874         (thread_db_load_search): Likewise.
 875         (has_libpthread): Likewise.
 876         (thread_db_load): Likewise.
 877
 878 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 879
 880         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 881         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 882         NULL, and complain/return if that's the case.
 883
 884 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 885
 886         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 887         (advance, posn, abstract_read_memory): New functions.
 888         [struct mem_read_abstraction]: New struct.
 889         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 890
 891 2019-05-14  Tom Tromey  <tromey@adacore.com>
 892
 893         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 894         value is not lval_memory.
 895
 896 2019-05-14  Tom Tromey  <tromey@adacore.com>
 897
 898         * solib.c (info_sharedlibrary_command): Style the file name.
 899
 900 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 901
 902         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 903         (aarch64_vnv_type): Likewise.
 904         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 905         * common/tdesc.c: Likewise.
 906         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 907         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 908         * features/aarch64-fpu.xml: Add ieee half view.
 909         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 910         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 911         * gdbtypes.h (struct builtin_type): Likewise.
 912         (struct objfile_type): Likewise.
 913
 914 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 915
 916         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 917         typo.
 918         * location.h (string_to_event_location): Likewise.
 919
 920 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 921
 922         GDB 8.3 released.
 923
 924 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 925
 926         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 927         New variable declaration.
 928         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 929         New variable.
 930         (print_one_breakpoint): Use ui_out::test_flags and new global
 931         variable to compute use_fixed_output.
 932         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 933         Remove.
 934         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 935         (mi_multi_location_breakpoint_output_fixed): Remove.
 936         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 937         new variable.
 938         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 939         fix_multi_location_breakpoint_output flag if version >= 3.
 940         * ui-out.h (enum ui_out_flag)
 941         <fix_multi_location_breakpoint_output>: New enumerator.
 942
 943 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 944
 945         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 946
 947 2019-05-10  Tom Tromey  <tromey@adacore.com>
 948
 949         * ada-lang.c (catch_ada_completer): New function.
 950         (_initialize_ada_language): Use it.
 951
 952 2019-05-10  Tom Tromey  <tromey@adacore.com>
 953
 954         * thread.c (print_thread_info): Make "requested_threads" const.
 955         * gdbthread.h (print_thread_info): Make "requested_threads"
 956         const.
 957         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 958         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 959
 960 2019-05-08  Tom Tromey  <tom@tromey.com>
 961
 962         * gdbtypes.c (objfile_type_data): Change type.
 963         (objfile_type, _initialize_gdbtypes): Update.
 964
 965 2019-05-08  Tom Tromey  <tom@tromey.com>
 966
 967         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 968         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 969         (_initialize_dwarf2_frame): Update.
 970
 971 2019-05-08  Tom Tromey  <tom@tromey.com>
 972
 973         * objc-lang.c (objc_objfile_data): Change type.
 974         (find_methods): Update.
 975         (_initialize_objc_lang): Remove.
 976
 977 2019-05-08  Tom Tromey  <tom@tromey.com>
 978
 979         * stabsread.c (rs6000_builtin_type_data): Change type.
 980         (rs6000_builtin_type, _initialize_stabsread): Update.
 981
 982 2019-05-08  Tom Tromey  <tom@tromey.com>
 983
 984         * mips-tdep.c (mips_pdr_data): Remove.
 985         (_initialize_mips_tdep): Update.
 986
 987 2019-05-08  Tom Tromey  <tom@tromey.com>
 988
 989         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 990         (hppa_init_objfile_priv_data, read_unwind_info)
 991         (find_unwind_entry, _initialize_hppa_tdep): Update.
 992
 993 2019-05-08  Tom Tromey  <tom@tromey.com>
 994
 995         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 996         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 997         on obstack.
 998         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 999
1000 2019-05-08  Tom Tromey  <tom@tromey.com>
1001
1002         * mdebugread.c (basic_type_data): Change type.
1003         (basic_type, _initialize_mdebugread): Update.
1004
1005 2019-05-08  Tom Tromey  <tom@tromey.com>
1006
1007         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1008
1009 2019-05-08  Tom Tromey  <tom@tromey.com>
1010
1011         * nto-tdep.c (nto_inferior_data_reg): Change type.
1012         (nto_inferior_data): Update.
1013         (nto_inferior_data_cleanup, nto_new_inferior_data)
1014         (_initialize_nto_tdep): Remove.
1015         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1016
1017 2019-05-08  Tom Tromey  <tom@tromey.com>
1018
1019         * ada-lang.c (struct ada_inferior_data): Add initializers.
1020         (ada_inferior_data): Change type.
1021         (ada_inferior_data_cleanup): Remove.
1022         (get_ada_inferior_data, ada_inferior_exit)
1023         (struct ada_pspace_data): Add initializers, destructor.
1024         (ada_pspace_data_handle): Change type.
1025         (get_ada_pspace_data): Update.
1026         (ada_pspace_data_cleanup): Remove.
1027
1028 2019-05-08  Tom Tromey  <tom@tromey.com>
1029
1030         * coffread.c (struct coff_symfile_info): Add initializers.
1031         (coff_objfile_data_key): Move lower.  Change type.
1032         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1033         Update.
1034         (coff_free_info): Remove.
1035
1036 2019-05-08  Tom Tromey  <tom@tromey.com>
1037
1038         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1039         (fbsd_pspace_data_handle): Move lower.  Change type.
1040         (get_fbsd_pspace_data): Update.
1041         (fbsd_pspace_data_cleanup): Remove.
1042         (_initialize_fbsd_tdep): Update.
1043
1044 2019-05-08  Tom Tromey  <tom@tromey.com>
1045
1046         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1047         (get_ada_tasks_pspace_data): Update.
1048         (ada_tasks_pspace_data_cleanup): Remove.
1049         (_initialize_tasks): Update.
1050         (ada_tasks_inferior_data_handle): Change type.
1051         (get_ada_tasks_inferior_data): Update.
1052         (ada_tasks_inferior_data_cleanup): Remove.
1053         (struct ada_tasks_pspace_data): Add initializers.
1054
1055 2019-05-08  Tom Tromey  <tom@tromey.com>
1056
1057         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1058         * symfile-debug.c (debug_sym_get_probes): Change type.
1059         * stap-probe.c (handle_stap_probe):
1060         (stap_static_probe_ops::get_probes): Change type.
1061         * probe.h (class static_probe_ops) <get_probes>: Change type.
1062         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1063         (parse_probes_in_pspace): Update.
1064         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1065         Update.
1066         (any_static_probe_ops::get_probes): Change type.
1067         * elfread.c (elfread_data): New typedef.
1068         (probe_key): Change type.
1069         (elf_get_probes): Likewise.  Update.
1070         (probe_key_free): Remove.
1071         (_initialize_elfread): Update.
1072         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1073         Change type.
1074         (dtrace_process_dof_probe, dtrace_process_dof)
1075         (dtrace_static_probe_ops::get_probe): Change type.
1076
1077 2019-05-08  Tom Tromey  <tom@tromey.com>
1078
1079         * xcoffread.c (struct xcoff_symfile_info): Rename from
1080         coff_symfile_info.  Add initializers.
1081         (xcoff_objfile_data_key): Move lower.  Change type.
1082         (XCOFF_DATA): Rewrite.
1083         (xcoff_free_info): Remove.
1084         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1085         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1086         (xcoff_initial_scan): Update.
1087
1088 2019-05-08  Tom Tromey  <tom@tromey.com>
1089
1090         * solib-svr4.c (struct svr4_info): Add initializers and
1091         destructor.
1092         <probes_table>: Now an htab_up.
1093         (solib_svr4_pspace_data): Change type.
1094         (free_probes_table): Simplify.
1095         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1096         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1097         (probes_table_remove_objfile_probes, register_solib_event_probe)
1098         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1099         (_initialize_svr4_solib): Update.
1100
1101 2019-05-08  Tom Tromey  <tom@tromey.com>
1102
1103         * remote.c (remote_pspace_data): Change type.
1104         (remote_pspace_data_cleanup): Remove.
1105         (get_remote_exec_file, set_pspace_remote_exec_file)
1106         (_initialize_remote): Update.
1107
1108 2019-05-08  Tom Tromey  <tom@tromey.com>
1109
1110         * breakpoint.c (breakpoint_objfile_key): Change type.
1111         (get_breakpoint_objfile_data): Update.
1112         (free_breakpoint_objfile_data): Remove.
1113         (_initialize_breakpoint): Update.
1114
1115 2019-05-08  Tom Tromey  <tom@tromey.com>
1116
1117         * linux-tdep.c (struct linux_info): Add initializers.
1118         (linux_inferior_data): Move.  Change type.
1119         (invalidate_linux_cache_inf): Update.
1120         (linux_inferior_data_cleanup): Remove.
1121         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1122
1123 2019-05-08  Tom Tromey  <tom@tromey.com>
1124
1125         * auxv.c (auxv_inferior_data): Move.  Change type.
1126         (auxv_inferior_data_cleanup): Remove.
1127         (invalidate_auxv_cache_inf): Rewrite.
1128         (get_auxv_inferior_data, _initialize_auxv): Update.
1129
1130 2019-05-08  Tom Tromey  <tom@tromey.com>
1131
1132         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1133         (symfile_debug_objfile_data_key): Change type.
1134         (symfile_debug_installed, debug_qf_has_symbols)
1135         (debug_qf_find_last_source_symtab)
1136         (debug_qf_forget_cached_source_info)
1137         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1138         (debug_qf_print_stats, debug_qf_dump)
1139         (debug_qf_expand_symtabs_for_function)
1140         (debug_qf_expand_all_symtabs)
1141         (debug_qf_expand_symtabs_with_fullname)
1142         (debug_qf_map_matching_symbols)
1143         (debug_qf_expand_symtabs_matching)
1144         (debug_qf_find_pc_sect_compunit_symtab)
1145         (debug_qf_map_symbol_filenames)
1146         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1147         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1148         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1149         (debug_sym_read_linetable, debug_sym_relocate): Update.
1150         (symfile_debug_free_objfile): Remove.
1151         (install_symfile_debug_logging, _initialize_symfile_debug):
1152         Update.
1153
1154 2019-05-08  Tom Tromey  <tom@tromey.com>
1155
1156         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1157         allocate_on_obstack.
1158         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1159         (get_dwarf2_per_objfile): Update.
1160         (set_dwarf2_per_objfile): Remove.
1161         (dwarf2_has_info, dwarf2_get_section_info): Update.
1162         (dwarf2_free_objfile): Remove.
1163         (_initialize_dwarf2_read): Update.
1164
1165 2019-05-08  Tom Tromey  <tom@tromey.com>
1166
1167         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1168         initializers.
1169         <unsupported_script_warning_printed,
1170         script_not_found_warning_printed>: Now bool.
1171         (auto_load_pspace_data): Change type.
1172         (~auto_load_pspace_info): Rename from
1173         auto_load_pspace_data_cleanup.
1174         (get_auto_load_pspace_data, init_loaded_scripts_info)
1175         (clear_section_scripts, maybe_print_unsupported_script_warning)
1176         (maybe_print_script_not_found_warning, _initialize_auto_load):
1177         Update.
1178
1179 2019-05-08  Tom Tromey  <tom@tromey.com>
1180
1181         * objfiles.c (objfile_pspace_info): Add destructor and
1182         initializers.
1183         (objfiles_pspace_data): Change type.
1184         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1185         (get_objfile_pspace_data): Update.
1186         (objfiles_bfd_data): Change type.
1187         (get_objfile_bfd_data): Update.
1188         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1189
1190 2019-05-08  Tom Tromey  <tom@tromey.com>
1191
1192         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1193         Change type.
1194         (get_catch_syscall_inferior_data): Update.
1195         (catch_syscall_inferior_data_cleanup): Remove.
1196         (_initialize_break_catch_syscall): Update.
1197
1198 2019-05-08  Tom Tromey  <tom@tromey.com>
1199
1200         * inflow.c (struct terminal_info): Add destructor and
1201         initializers.
1202         (inflow_inferior_data): Change type.
1203         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1204         (get_inflow_inferior_data, inflow_inferior_exit)
1205         (swap_terminal_info, _initialize_inflow): Update.
1206
1207 2019-05-08  Tom Tromey  <tom@tromey.com>
1208
1209         * target-dcache.c (target_dcache_cleanup): Remove.
1210         (target_dcache_aspace_key): Change type.
1211         (target_dcache_init_p, target_dcache_invalidate)
1212         (target_dcache_get, target_dcache_get_or_init)
1213         (_initialize_target_dcache): Update.
1214         * dcache.h (struct dcache_deleter): New.
1215
1216 2019-05-08  Tom Tromey  <tom@tromey.com>
1217
1218         * symtab.c (struct symbol_cache): Add destructor and
1219         initializers.
1220         (symbol_cache_key): Move.  Change type.
1221         (make_symbol_cache, free_symbol_cache): Remove.
1222         (get_symbol_cache): Update.
1223         (symbol_cache_cleanup): Remove.
1224         (ALL_PSPACES, symbol_cache_flush)
1225         (maintenance_print_symbol_cache)
1226         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1227         Update.
1228
1229 2019-05-08  Tom Tromey  <tom@tromey.com>
1230
1231         * symtab.c (struct main_info): Add destructor and initializers.
1232         (main_progspace_key): Move.  Change type.
1233         (get_main_info): Update.
1234         (main_info_cleanup): Remove.
1235         (_initialize_symtab): Update.
1236
1237 2019-05-08  Tom Tromey  <tom@tromey.com>
1238
1239         * registry.h (DECLARE_REGISTRY): Define the _key class.
1240
1241 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * NEWS: Merge two 'New commands' sections.
1244
1245 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1246
1247         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1248         parameter and use Ada language definition instead.
1249         (ada_val_print_ptr): Remove unused language parameter.
1250         (ada_val_print_num): Remove language parameter and use Ada language
1251         definition instead.
1252         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1253         parameter.
1254         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1255         parameter and use Ada language definition instead.
1256         (ada_val_print_1): Update all ada_val_print_xxx calls.
1257         Remove language parameter.
1258         (ada_val_print): Update ada_val_print_1 call.
1259
1260 2019-05-08  Tom Tromey  <tromey@adacore.com>
1261
1262         * remote.c (remote_hw_watchpoint_limit)
1263         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1264         Now static.
1265
1266 2019-05-08  Tom Tromey  <tromey@adacore.com>
1267
1268         * maint.c (_initialize_maint_cmds): Move initialization code to
1269         remote.c.
1270         (watchdog, show_watchdog): Move to remote.c.
1271         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1272         "watchdog" static.
1273         (_initialize_remote): Move initialization code from maint.c.
1274         * defs.h (watchdog): Don't declare.
1275
1276 2019-05-08  Tom Tromey  <tromey@adacore.com>
1277
1278         * tui/tui-interp.c: Include main.h.
1279         * interps.c: Include main.h.
1280         * main.h (interpreter_p): Declare.
1281         * defs.h (interpreter_p): Don't declare.
1282
1283 2019-05-08  Tom Tromey  <tromey@adacore.com>
1284
1285         * dwarf2loc.c: Include dwarf2read.h.
1286         * defs.h (read_unsigned_leb128): Don't declare.
1287         * dwarf2read.h (read_unsigned_leb128): Declare.
1288
1289 2019-05-08  Tom Tromey  <tromey@adacore.com>
1290
1291         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1292         method.
1293
1294 2019-05-08  Tom Tromey  <tromey@adacore.com>
1295
1296         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1297         when no wrap column is set.
1298
1299 2019-05-08  Tom Tromey  <tromey@adacore.com>
1300
1301         * c-lang.c (c_get_string): Handle non-C-style arrays.
1302
1303 2019-05-08  Tom Tromey  <tromey@adacore.com>
1304
1305         * typeprint.c (print_offset_data::update): Print the bit offset,
1306         not the number of bits remaining.
1307
1308 2019-05-08  Tom Tromey  <tromey@adacore.com>
1309
1310         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1311         padding at end of comment.
1312
1313 2019-05-08  Tom Tromey  <tromey@adacore.com>
1314
1315         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1316         Compare main types.
1317
1318 2019-05-06  Tom Tromey  <tom@tromey.com>
1319
1320         * common/scoped_mmap.c: Include common-defs.h.
1321         * common/scoped_mmap.h: Don't include config.h.
1322
1323 2019-05-04  Tom Tromey  <tom@tromey.com>
1324
1325         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1326         (struct aarch64_call_info): Add initializers.
1327         <si>: Now a std::vector.
1328         (pass_on_stack, aarch64_push_dummy_call): Update.
1329
1330 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1331             Tom Tromey  <tom@tromey.com>
1332
1333         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1334         (ppc_threads): Now a std::vector.  Now static.
1335         (hwdebug_find_thread_points_by_tid)
1336         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1337         Update.
1338
1339 2019-05-04  Tom Tromey  <tom@tromey.com>
1340
1341         * arc-tdep.c (arc_tdesc_init): Return bool.
1342
1343 2019-05-04  Tom Tromey  <tom@tromey.com>
1344
1345         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1346         Use gdb_assert_not_reached.
1347
1348 2019-05-04  Tom Tromey  <tom@tromey.com>
1349
1350         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1351         "false".
1352
1353 2019-05-04  Tom Tromey  <tom@tromey.com>
1354
1355         * arc-tdep.c (arc_tdesc_init): Use bool.
1356
1357 2019-05-04  Tom Tromey  <tom@tromey.com>
1358
1359         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1360
1361 2019-05-04  Tom Tromey  <tom@tromey.com>
1362
1363         * cli/cli-cmds.c (valid_command_p): Return bool.
1364
1365 2019-05-04  Tom Tromey  <tom@tromey.com>
1366
1367         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1368         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1369
1370 2019-05-04  Raul Tambre  <raul@tambre.ee>
1371
1372         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1373         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1374         operator for comparison.
1375
1376 2019-05-04  Tom Tromey  <tom@tromey.com>
1377
1378         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1379         (lookup_partial_symbol, print_partial_symbols)
1380         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1381         (psymbol_compare): Update.
1382         (add_psymbol_to_bcache): Clear the entire psymbol.
1383         (maintenance_check_psymtabs): Update.
1384         * psympriv.h (struct partial_symbol): Don't derive from
1385         general_symbol_info.
1386         <obj_section, unrelocated_address, address,
1387         set_unrelocated_address>: Update.
1388         <ginfo>: New member.
1389         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1390         (debug_names::write_psymbols): Update.
1391
1392 2019-05-04  Tom de Vries  <tdevries@suse.de>
1393
1394         * contrib/cc-with-tweaks.sh: Support -n arg.
1395
1396 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1397
1398         * corelow.c (core_target::detach): Ensure frame cache and
1399         register caches are cleared.
1400         inferior.c (exit_inferior_1): Likewise.
1401
1402 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1403             Tom Tromey  <tom@tromey.com>
1404
1405         * dictionary.c (collate_pending_symbols_by_language): Remove
1406         "struct" from foreach.
1407         * symtab.c (lookup_global_symbol_from_objfile)
1408         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1409         foreach.
1410         * ser-tcp.c (net_open): Remove "struct" from foreach.
1411         * objfiles.c (objfile_relocate, objfile_rebase)
1412         (objfile_has_symbols): Remove "struct" from foreach.
1413         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1414         from foreach.
1415         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1416         foreach.
1417         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1418         "struct" from foreach.
1419         * ada-lang.c (create_excep_cond_exprs)
1420         (ada_exception_catchpoint_cond_string): Remove "struct" from
1421         foreach.
1422
1423 2019-05-03  Tom Tromey  <tromey@adacore.com>
1424
1425         * ada-exp.y (convert_char_literal): Check suffix of each
1426         enumerator.
1427
1428 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1429
1430         PR ada/21406:
1431         * ada-exp.y (yywrap): Don't define.
1432         * ada-lex.l (%option): Add noyywrap
1433         (yywrap): Remove.
1434
1435 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1436
1437         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1438         _WIN32_WINNT to the XP level, unless already defined to a higher
1439         level.
1440
1441         * unittests/parse-connection-spec-selftests.c:
1442         * ser-tcp.c:
1443         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1444         override.
1445
1446         * symfile.c (find_separate_debug_file): Remove colon from the
1447         drive spec of DOS/Windows file names of the target, so that the
1448         file name produced from DEBUGDIR and the target's directory will
1449         be valid on DOS/Windows systems.
1450
1451 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * rust-lang.c (val_print_struct): Handle printing structures
1454         containing strings.
1455
1456 2019-05-02  Tom Tromey  <tromey@adacore.com>
1457
1458         * valarith.c (_initialize_valarith): Remove.
1459
1460 2019-05-01  Tom Tromey  <tromey@adacore.com>
1461
1462         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1463         bitfields.
1464
1465 2019-05-01  Tom Tromey  <tromey@adacore.com>
1466
1467         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1468         for big-endian copies.
1469
1470 2019-04-30  Ali Tamur  <tamur@google.com>
1471         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1472         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1473         (read_3_bytes): New function.
1474
1475 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1476
1477         * windows-nat.c (main_thread_id): Delete.
1478         (handle_output_debug_string): Replace main_thread_id by
1479         current_event.dwThreadId.
1480         (fake_create_process): Likewise.
1481         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1482         Do not set main_thread_id.
1483         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1484         current_event.dwThreadId.
1485         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1486
1487 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1488
1489         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1490         Use current_event.dwThreadId instead of main_thread_id.
1491
1492 2019-04-30  Tom Tromey  <tromey@adacore.com>
1493
1494         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1495         (create_excep_cond_exprs): Iterate over program spaces.
1496         (ada_exception_catchpoint_cond_string): Examine all minimal
1497         symbols for exception types.
1498
1499 2019-04-30  Tom Tromey  <tromey@adacore.com>
1500
1501         PR c++/24470:
1502         * dwarf2read.c (process_structure_scope): Handle case where type
1503         has template parameters but no symbol was created.
1504
1505 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1506             Chris January  <chris.january@arm.com>
1507
1508         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1509         qualifier.
1510         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1511
1512 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1513
1514         * f-typeprint.c (f_print_type): Update rules for printing
1515         whitespace.
1516         (f_type_print_varspec_suffix): Likewise.
1517
1518 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1519             Chris January  <chris.january@arm.com>
1520
1521         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1522         function arguments.
1523
1524 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1525
1526         * f-lang.c (build_fortran_types): Change name of void type to
1527         lower case.
1528         * f-typeprint.c (f_type_print_base): Print the name of the void
1529         type, rather than a fixed string.
1530         * f-valprint.c (f_decorations): Use lower case void string.
1531
1532 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1533             Chris January  <chris.january@arm.com>
1534
1535         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1536         types for Fortran.
1537
1538 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1539             Chris January  <chris.january@arm.com>
1540             David Lecomber  <david.lecomber@arm.com>
1541
1542         * f-exp.y (BINOP_INTRINSIC): New token.
1543         (exp): New parser rule handling BINOP_INTRINSIC.
1544         (f77_keywords): Add new builtin procedures.
1545         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1546         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1547         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1548         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1549         (print_unop_subexp_f): New function.
1550         (print_binop_subexp_f): New function.
1551         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1552         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1553         (dump_subexp_body_f): Likewise.
1554         (operator_check_f): Likewise.
1555         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1556         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1557
1558 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1559
1560         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1561         UNOP_KIND.
1562         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1563         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1564         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1565         (operator_length_f): New fuction.
1566         (print_subexp_f): New function.
1567         (op_name_f): New function.
1568         (dump_subexp_body_f): New function.
1569         (operator_check_f): New function.
1570         (exp_descriptor_f): Replace standard expression handling functions
1571         with new functions.
1572         * gdb/fortran-operator.def: New file.
1573         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1574         * gdb/std-operator.def: Remove UNOP_KIND.
1575
1576 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * std-operator.def: Remove unbalanced, stray double quote
1579         character.
1580
1581 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1582             Chris January  <chris.january@arm.com>
1583             Daniel Everett  <daniel.everett@arm.com>
1584             Nick Forrington  <nick.forrington@arm.com>
1585             Richard Bunt  <richard.bunt@arm.com>
1586
1587         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1588         of depth when printing anonymous structs or unions.
1589         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1590         Don't print either the top-level value, or the children if the
1591         max-depth is exceeded.
1592         (ppscm_print_children): When printing the key of a map, allow one
1593         extra level of depth.
1594         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1595         print either the top-level value, or the children if the max-depth
1596         is exceeded.
1597         (print_children): When printing the key of a map, allow one extra
1598         level of depth.
1599         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1600         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1601         (user_print_options): Initialise max_depth field.
1602         (val_print_scalar_or_string_type_p): New function.
1603         (val_print): Check to see if the max depth has been reached.
1604         (val_print_check_max_depth): Define new function.
1605         (show_print_max_depth): New function.
1606         (_initialize_valprint): Add 'print max-depth' option.
1607         * valprint.h (struct value_print_options) <max_depth>: New field.
1608         (val_print_check_max_depth): Declare new function.
1609         * NEWS: Document new feature.
1610
1611 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * ada-lang.c (ada_language_defn): Initialise new field.
1614         * c-lang.c (c_is_string_type_p): New function.
1615         (c_language_defn): Initialise new field.
1616         (cplus_language_defn): Initialise new field.
1617         (asm_language_defn): Initialise new field.
1618         (minimal_language_defn): Initialise new field.
1619         * c-lang.h (c_is_string_type_p): Declare new function.
1620         * d-lang.c (d_language_defn): Initialise new field.
1621         * f-lang.c (f_is_string_type_p): New function.
1622         (f_language_defn): Initialise new field.
1623         * go-lang.c (go_is_string_type_p): New function.
1624         (go_language_defn): Initialise new field.
1625         * language.c (default_is_string_type_p): New function.
1626         (unknown_language_defn): Initialise new field.
1627         (auto_language_defn): Initialise new field.
1628         * language.h (struct language_defn) <la_is_string_type_p>: New
1629         member variable.
1630         (default_is_string_type_p): Declare new function.
1631         * m2-lang.c (m2_language_defn): Initialise new field.
1632         * objc-lang.c (objc_language_defn): Initialise new field.
1633         * opencl-lang.c (opencl_language_defn): Initialise new field.
1634         * p-lang.c (pascal_is_string_type_p): New function.
1635         (pascal_language_defn): Initialise new field.
1636         * rust-lang.c (rust_is_string_type_p): New function.
1637         (rust_language_defn): Initialise new field.
1638
1639 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1640
1641         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1642         New field.
1643         * ada-lang.c (ada_language_defn): Initialise new field.
1644         * c-lang.c (c_language_defn): Likewise.
1645         (cplus_language_defn): Likewise.
1646         (asm_language_defn): Likewise.
1647         (minimal_language_defn): Likewise.
1648         * d-lang.c (d_language_defn): Likewise.
1649         * f-lang.c (f_language_defn): Likewise.
1650         * go-lang.c (go_language_defn): Likewise.
1651         * language.c (unknown_language_defn): Likewise.
1652         (auto_language_defn): Likewise.
1653         * m2-lang.c (m2_language_defn): Likewise.
1654         * objc-lang.c (objc_language_defn): Likewise.
1655         * opencl-lang.c (opencl_language_defn): Likewise.
1656         * p-lang.c (pascal_language_defn): Likewise.
1657         * rust-lang.c (rust_language_defn): Likewise.
1658
1659 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1660
1661         * ada-lang.c (ada_is_character_type): Change return type to bool.
1662         (ada_is_string_type): Likewise.
1663         * ada-lang.h (ada_is_character_type): Update declaration
1664         (ada_is_string_type): Likewise.
1665
1666 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1667
1668         Support style in 'frame|thread apply'
1669
1670         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1671         * record.c (record_start, record_stop): Update callers of
1672         execute_command_to_string with false.
1673         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1674         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1675         methods.
1676         (class string_file): New constructor with term_out parameter.
1677         Override methods term_out and can_emit_style_escape.  New member
1678         term_out.
1679         (class stdio_file): Override can_emit_style_escape.
1680         (class tee_file): Override term_out and can_emit_style_escape.
1681         * utils.h (can_emit_style_escape): Remove.
1682         * utils.c (can_emit_style_escape): Likewise.
1683         Update all callers of can_emit_style_escape (SOMESTREAM) to
1684         SOMESTREAM->can_emit_style_escape.
1685         * source-cache.c (source_cache::get_source_lines): Likewise.
1686         * stack.c (frame_apply_command_count): Call execute_command_to_string
1687         passing the term_out characteristic of the current gdb_stdout.
1688         * thread.c (thr_try_catch_cmd): Likewise.
1689         * top.c (execute_command_to_string): pass term_out parameter
1690         to construct the string_file for the command output.
1691         * ui-file.c (term_cli_styling): New function (most code moved
1692         from utils.c can_emit_style_escape).
1693         (string_file::string_file, string_file::can_emit_style_escape,
1694         stdio_file::can_emit_style_escape, tee_file::term_out,
1695         tee_file::can_emit_style_escape): New functions.
1696
1697 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1698
1699         * NEWS: Mention the new set|show may-call-functions.
1700         * infcall.c (may_call_functions_p): New variable.
1701         (show_may_call_functions_p): New function.
1702         (call_function_by_hand_dummy): Throws an error if not
1703         may-call-functions.
1704         (_initialize_infcall): Call add_setshow_boolean_cmd for
1705         may-call-functions.
1706
1707 2019-04-25  Keith Seitz  <keiths@redhat.com>
1708
1709         PR c++/24367
1710         * cp-support.c (inspect_type): Don't attempt substitutions
1711         of symbol with the same name.
1712
1713 2019-04-25  Tom Tromey  <tromey@adacore.com>
1714
1715         PR gdb/24475:
1716         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1717         static.
1718
1719 2019-04-25  Tom Tromey  <tromey@adacore.com>
1720
1721         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1722         rvalue reference.
1723         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1724         (gdb_xml_parser::parse): Use std::move.
1725         * python/python-internal.h (gdbpy_convert_exception): Take a const
1726         reference.
1727         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1728         std::move.
1729         * python/py-utils.c (gdbpy_convert_exception): Take a const
1730         reference.
1731         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1732         Use std::move.
1733         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1734         Use std::move.
1735         * mi/mi-main.c (mi_print_exception): Take a const reference.
1736         * main.c (handle_command_errors): Take a const reference.
1737         * linespec.c (parse_linespec): Use std::move.
1738         * infcall.c (run_inferior_call): Use std::move.
1739         (call_function_by_hand_dummy): Use std::move.
1740         * exec.c (try_open_exec_file): Use std::move.
1741         * exceptions.h (exception_print, exception_fprintf)
1742         (exception_print_same): Update.
1743         * exceptions.c (print_exception, exception_print)
1744         (exception_fprintf, exception_print_same): Change parameters to
1745         const reference.
1746         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1747         * common/new-op.c: Use std::move.
1748         * common/common-exceptions.h (struct gdb_exception): Add move
1749         constructor.
1750         (struct gdb_exception_error, struct gdb_exception_quit, struct
1751         gdb_quit_bad_alloc): Change constructor to move constructor.
1752         (throw_exception): Change parameter to rvalue reference.
1753         * common/common-exceptions.c (throw_exception): Take rvalue
1754         reference.
1755         * cli/cli-interp.c (safe_execute_command): Use std::move.
1756         * breakpoint.c (insert_bp_location, location_to_sals): Use
1757         std::move.
1758
1759 2019-04-25  Tom Tromey  <tromey@adacore.com>
1760
1761         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1762         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1763         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1764         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1765         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1766         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1767         guile/scm-value.c: Use unpack.
1768         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1769         gdbscm_gdb_exception.
1770         (gdbscm_throw_gdb_exception): Likewise.
1771         (struct gdbscm_gdb_exception): New.
1772         (unpack): New function.
1773         (gdbscm_wrap): Use unpack.
1774
1775 2019-04-25  Tom Tromey  <tromey@adacore.com>
1776
1777         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1778         (gdb_rl_callback_handler): Use std::move.
1779         * common/common-exceptions.h (struct gdb_exception): Add move
1780         assignment operator.
1781         (throw_exception_sjlj): Change "exception" to const reference.
1782         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1783         (throw_exception_sjlj): Change "exception" to const reference.
1784
1785 2019-04-25  Tom Tromey  <tromey@adacore.com>
1786
1787         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1788         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1789         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1790         Update.
1791         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1792         Update.
1793         * mi/mi-interp.c (mi_interp::exec): Update.
1794         * linespec.c (parse_linespec): Update.
1795         * infcall.c (run_inferior_call): Update.
1796         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1797         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1798         (gdbscm_lookup_global_symbol): Update.
1799         * guile/scm-param.c (gdbscm_parameter_value): Update.
1800         * guile/scm-frame.c (gdbscm_frame_read_register)
1801         (gdbscm_frame_read_var): Update.
1802         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1803         * exec.c (try_open_exec_file): Update.
1804         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1805         (gdb_rl_callback_handler): Update.
1806         * common/common-exceptions.h (exception_none): Don't declare.
1807         * common/common-exceptions.c (exception_none): Don't define.
1808         (struct catcher) <exception>: Update.
1809         * cli/cli-interp.c (safe_execute_command): Update.
1810         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1811
1812 2019-04-25  Ali Tamur  <tamur@google.com>
1813
1814         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1815         (read_attribute_value): Likewise.
1816         (dwarf2_read_addr_index): Update comment.
1817         (read_str_index): Add DW_FORM_strx.
1818         (dwarf2_string_attr): Likewise.
1819         (dwarf2_const_value_attr): Likewise.
1820         (dump_die_shallow): Likewise.
1821         (dwarf2_fetch_constant_bytes): Likewise.
1822         (skip_form_bytes): Likewise.
1823         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1824
1825 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1826
1827         PR corefiles/11608
1828         PR corefiles/18187
1829         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1830         OFFSET.  Verify if current mapping contains an ELF header.
1831         (linux_find_memory_regions_full): Adjust call to
1832         dump_mapping_p.
1833
1834 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1835             Kang Li <kanglictf@gmail.com>
1836
1837         PR gdb/21600
1838
1839         * dwarf2-frame.c (read_initial_length): Be consistent about using
1840         unsigned representation of length.
1841         (decode_frame_entry_1): Likewise.  Check for wraparound of
1842         end pointer as well as buffer overflow.
1843
1844 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1845
1846         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1847         "vq".
1848
1849 2019-04-24  Tom Tromey  <tromey@adacore.com>
1850
1851         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1852
1853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * s12z-tdep.c (s12z_unwind_pc): Delete.
1856         (s12z_unwind_sp): Delete.
1857         (s12z_gdbarch_init): Don't register deleted functions with
1858         gdbarch.
1859
1860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * rl78-tdep.c (rl78_unwind_sp): Delete.
1863         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1864
1865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1866
1867         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1868         (xstormy16_unwind_pc): Delete.
1869         (xstormy16_dummy_id): Delete.
1870         (xstormy16_gdbarch_init): Don't register deleted functions with
1871         gdbarch.
1872
1873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1874
1875         * vax-tdep.c (vax_unwind_pc): Delete.
1876         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1877
1878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1879
1880         * v850-tdep.c (v850_unwind_sp): Delete.
1881         (v850_unwind_pc): Delete.
1882         (v850_dummy_id): Delete.
1883         (v850_gdbarch_init): Don't register deleted functions with
1884         gdbarch.
1885
1886 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1887
1888         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1889         (tilegx_unwind_pc): Delete.
1890         (tilegx_unwind_dummy_id): Delete.
1891         (tilegx_gdbarch_init): Don't register deleted functions with
1892         gdbarch.
1893
1894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1897         (tic6x_dummy_id): Delete.
1898         (tic6x_gdbarch_init): Don't register deleted functions with
1899         gdbarch.
1900
1901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1902
1903         * sparc-tdep.c (sparc_unwind_pc): Delete.
1904         (sparc32_gdbarch_init): Don't register deleted function with
1905         gdbarch.
1906
1907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1908
1909         * sh-tdep.c (sh_unwind_sp): Delete.
1910         (sh_unwind_pc): Delete.
1911         (sh_dummy_id): Delete.
1912         (sh_gdbarch_init): Don't register deleted functions with
1913         gdbarch.
1914
1915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1916
1917         * score-tdep.c (score_unwind_sp): Delete.
1918         (score_unwind_pc): Delete.
1919         (score_dummy_id): Delete.
1920         (score_gdbarch_init): Don't register deleted functions with
1921         gdbarch.
1922
1923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * rx-tdep.c (rx_unwind_pc): Delete.
1926         (rx_unwind_sp): Delete.
1927         (rx_dummy_id): Delete.
1928         (rx_gdbarch_init): Don't register deleted functions with
1929         gdbarch.  Update comment.
1930
1931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1932
1933         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1934         (rs6000_dummy_id): Delete.
1935         (rs6000_gdbarch_init): Don't register deleted functions with
1936         gdbarch.
1937
1938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * or1k-tdep.c (or1k_dummy_id): Delete.
1941         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1942
1943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1944
1945         * nios2-tdep.c (nios2_dummy_id): Delete.
1946         (nios2_unwind_sp): Delete.
1947         (nios2_gdbarch_init): Don't register deleted functions with
1948         gdbarch.
1949
1950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * nds32-tdep.c (nds32_dummy_id): Delete.
1953         (nds32_unwind_pc): Delete.
1954         (nds32_unwind_sp): Delete.
1955         (nds32_gdbarch_init): Don't register deleted functions with
1956         gdbarch.
1957
1958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1959
1960         * msp430-tdep.c (msp430_unwind_pc): Delete.
1961         (msp430_unwind_sp): Delete.
1962         (msp430_dummy_id): Delete.
1963         (msp430_gdbarch_init): Don't register deleted functions with
1964         gdbarch.
1965
1966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1967
1968         * moxie-tdep.c (moxie_unwind_sp): Delete.
1969         (moxie_unwind_pc): Delete.
1970         (moxie_dummy_id): Delete.
1971         (moxie_gdbarch_init): Don't register deleted functions with
1972         gdbarch.
1973
1974 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1975
1976         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1977         (mn10300_unwind_pc): Delete.
1978         (mn10300_unwind_sp): Delete.
1979         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1980         mn10300_unwind_sp.
1981         (mn10300_frame_unwind_init): Don't register deleted functions with
1982         gdbarch.
1983
1984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1985
1986         * mep-tdep.c (mep_unwind_pc): Delete.
1987         (mep_unwind_sp): Delete.
1988         (mep_dummy_id): Delete.
1989         (mep_gdbarch_init): Don't register deleted functions with
1990         gdbarch.
1991
1992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1993
1994         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1995         (m68hc11_unwind_sp): Delete.
1996         (m68hc11_gdbarch_init): Don't register deleted functions with
1997         gdbarch.
1998
1999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2000
2001         * m32r-tdep.c (m32r_unwind_sp): Delete.
2002         (m32r_unwind_pc): Delete.
2003         (m32r_dummy_id): Delete.
2004         (m32r_gdbarch_init): Don't register deleted functions with
2005         gdbarch.
2006
2007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2008
2009         * m32c-tdep.c (m32c_unwind_pc): Delete.
2010         (m32c_unwind_sp): Delete.
2011         (m32c_dummy_id): Delete.
2012         (m32c_gdbarch_init): Don't register deleted functions with
2013         gdbarch.
2014
2015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2016
2017         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2018         (lm32_unwind_pc): Delete.
2019         (lm32_dummy_id): Delete.
2020         (lm32_gdbarch_init): Don't register deleted functions with
2021         gdbarch.
2022
2023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2024
2025         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2026         (iq2000_unwind_pc): Delete.
2027         (iq2000_dummy_id): Delete.
2028         (iq2000_gdbarch_init): Don't register deleted functions with
2029         gdbarch.
2030
2031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2032
2033         * nds32-tdep.c (nds32_type_align): Delete.
2034         (nds32_push_dummy_call): Use type_align instead.
2035
2036 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2037
2038         * arm-tdep.c (arm_type_align): Only handle vector override case.
2039         (arm_push_dummy_call): Use type_align.
2040         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2041
2042 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2043
2044         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2045         case.
2046         (pass_on_stack): Use type_align.
2047         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2048         function.
2049
2050 2019-04-23  Tom Tromey  <tromey@adacore.com>
2051
2052         * dwarf2read.c (line_header::file_name_at): Remove unused
2053         overload.
2054
2055 2019-04-23  Tom de Vries  <tdevries@suse.de>
2056
2057         PR gdb/24438
2058         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2059         invocation.
2060
2061
2062 2019-03-27  Ali Tamur  <tamur@google.com>
2063
2064         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2065         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2066         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2067         (dwarf_expr_context::get_addr_index): Likewise
2068         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2069         (symbol_needs_eval_context::get_addr_index): Likewise
2070         (disassemble_dwarf_expression): Add DW_OP_addrx
2071         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2072         (read_cutu_die_from_dwo): Update comment
2073         (skip_one_die): Add DW_FORM_addrx
2074         (read_attribute_value): Likewise
2075         (var_decode_location): Add DW_OP_addrx
2076         (dwarf2_const_value_attr): Add DW_FORM_addrx
2077         (dump_die_shallow): Likewise
2078         (dwarf2_fetch_constant_bytes): Likewise
2079         (decode_locdesc): Add DW_OP_addrx
2080         (skip_form_bytes): Add DW_FORM_addrx
2081
2082 2019-04-22  Ali Tamur  <tamur@google.com>
2083
2084         * MAINTAINERS (Write After Approval): Add self.
2085
2086 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2087
2088         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2089         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2090         (open_symbol_file_object): Likewise.
2091         (svr4_default_sos): Add info parameter.
2092         (svr4_read_so_list): Likewise.
2093         (svr4_current_sos_direct): Adjust functions calls to pass down
2094         info.
2095         (svr4_current_sos_1): Add info parameter.
2096         (svr4_current_sos): Call get_svr4_info, pass info down to
2097         svr4_current_sos_1.
2098         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2099         get_svr4_info.
2100         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2101         get_svr4_info.
2102         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2103         to get_svr4_info.
2104         (probes_table_remove_objfile_probes): Likewise.
2105         (register_solib_event_probe): Add info parameter.
2106         (solist_update_incremental): Pass info parameter down to
2107         svr4_read_so_list.
2108         (disable_probes_interface): Add info parameter.
2109         (svr4_handle_solib_event): Pass current_program_space to
2110         get_svr4_info.  Adjust disable_probes_interface cleanup.
2111         (svr4_create_probe_breakpoints): Add info parameter, pass it
2112         down to register_solib_event_probe.
2113         (svr4_create_solib_event_breakpoints): Add info parameter,
2114         pass it down to svr4_create_probe_breakpoints.
2115         (enable_break): Pass info down to
2116         svr4_create_solib_event_breakpoints.
2117         (svr4_solib_create_inferior_hook): Pass current_program_space to
2118         get_svr4_info.
2119         (svr4_clear_solib): Likewise.
2120
2121 2019-04-22  Pedro Alves  <palves@redhat.com>
2122
2123         * solib-svr4.c (svr4_free_objfile_observer): New.
2124         (probe_and_action::objfile): New field.
2125         (probes_table_htab_remove_objfile_probes)
2126         (probes_table_remove_objfile_probes): New functions.
2127         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2128         in the new probe_and_action.  Don't store the probe in 'lookup'.
2129         (svr4_create_probe_breakpoints): Pass objfile to
2130         register_solib_event_probe.
2131         (_initialize_svr4_solib): Register a free_objfile observer.
2132
2133 2019-04-19  Tom Tromey  <tom@tromey.com>
2134
2135         * common/queue.h: Remove.
2136
2137 2019-04-19  Tom Tromey  <tom@tromey.com>
2138
2139         * event-loop.c: Don't include "common/queue.h".
2140
2141 2019-04-19  Tom Tromey  <tom@tromey.com>
2142
2143         * remote.c (remote_target): Use delete.
2144         * remote-notif.h: Include <list>, not "common/queue.h".
2145         (notif_client_p): Remove typedef.
2146         (remote_notif_state): Add constructor, destructor, initializer.
2147         <notif_queue>: Now a std::list.
2148         (remote_notif_state_xfree): Don't declare.
2149         * remote-notif.c (remote_notif_process, handle_notification)
2150         (remote_notif_state_allocate): Update.
2151         (~remote_notif_state): Rename from remote_notif_state_xfree.
2152
2153 2019-04-19  Tom Tromey  <tom@tromey.com>
2154
2155         * symfile.c (reread_symbols): Update.
2156         * objfiles.c (objfile_register_static_link)
2157         (objfile_lookup_static_link): Update
2158         (~objfile) Don't delete static_links.
2159         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2160
2161 2019-04-19  Tom Tromey  <tom@tromey.com>
2162
2163         * type-stack.h (struct type_stack) <insert>: Constify string.
2164         * type-stack.c (type_stack::insert): Constify string.
2165         * gdbtypes.h (lookup_template_type): Update.
2166         (address_space_name_to_int): Update.
2167         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2168         const.
2169         (lookup_template_type): Make name const.
2170         * c-exp.y: Update rules.
2171         (lex_one_token, classify_name, classify_inner_name)
2172         (c_print_token): Update.
2173         * p-exp.y: Update rules.
2174         (yylex): Update.
2175         * f-exp.y: Update rules.
2176         (yylex): Update.
2177         * d-exp.y: Update rules.
2178         (lex_one_token, classify_name, classify_inner_name): Update.
2179         * parse.c (write_dollar_variable, copy_name): Return std::string.
2180         * parser-defs.h (copy_name): Change return type.
2181         * m2-exp.y: Update rules.
2182         (yylex): Update.
2183         * go-exp.y (lex_one_token): Update.
2184         Update rules.
2185         (classify_unsafe_function, classify_packaged_name)
2186         (classify_name, yylex): Update.
2187
2188 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2189
2190         * configure.ac: add --enable-source-highlight switch.
2191         * configure: Regenerate.
2192         * top.c (print_gdb_version): plumb --enable-source-highlight
2193         status to "show configuration".
2194
2195 2019-04-19  Tom Tromey  <tromey@adacore.com>
2196
2197         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2198         Check ADA_TYPE_P.
2199         (empty_record, ada_template_to_fixed_record_type_1)
2200         (template_to_static_fixed_type)
2201         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2202         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2203         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2204         macros.
2205
2206 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2207
2208         PR symtab/24423:
2209         * source.c (print_source_lines_base): Advance "iter" when a
2210         control character is seen.
2211
2212 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2213
2214         * inferior.h (struct infcall_suspend_state_deleter):
2215         Catch exception in destructor to avoid crash.
2216
2217 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2218
2219         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2220         close to the add_com "shell".
2221
2222 2019-04-18  Tom Tromey  <tromey@adacore.com>
2223
2224         * process-stratum-target.h (class process_stratum_target)
2225         <stratum>: Add "final".
2226
2227 2019-04-17  Tom Tromey  <tromey@adacore.com>
2228
2229         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2230         against nullptr before use.
2231
2232 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2233
2234         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2235
2236 2019-04-17  Jim Wilson  <jimw@sifive.com>
2237             Andrew Burgess  <andrew.burgess@embecosm.com>
2238
2239         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2240         code read might fail, assume 4-byte breakpoint in that case.
2241
2242 2019-04-15  Leszek Swirski  <leszeks@google.com>
2243
2244         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2245         rather than a hand-rolled POD check when checking for forced MEMORY
2246         classification.
2247
2248 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2249
2250         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2251         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2252         function.
2253         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2254         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2255         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2256         declaration.
2257
2258 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2259
2260         * aarch64-linux-nat.c
2261         (aarch64_linux_nat_target::thread_architecture): Add override.
2262         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2263         each VQ.
2264
2265 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2266
2267         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2268
2269 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2270
2271         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2272         target types of size 96-bits, add some additional comments, and
2273         check that the builtin type we found was the correct size.
2274
2275 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2276
2277         * utils.c (prompt_for_continue): Don't restore the styling at the
2278         end, as applied_style has the wrong value.  This fixes styling in
2279         long lists of file names that are interrupted by the "Continue?"
2280         prompt.
2281
2282 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2285         * c-lang.c (c_language_defn): Likewise.
2286         (cplus_language_defn): Likewise.
2287         (asm_language_defn): Likewise.
2288         (minimal_language_defn): Likewise.
2289         * d-lang.c (d_language_defn): Likewise.
2290         * f-lang.c (f_language_defn): Likewise.
2291         * go-lang.c (go_language_defn): Likewise.
2292         * language.c (unknown_language_defn): Likewise.
2293         (auto_language_defn): Likewise.
2294         * language.h (struct language_defn): Remove la_magic field.
2295         (LANG_MAGIC): Delete.
2296         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2297         * objc-lang.c (objc_language_defn): Likewise.
2298         * opencl-lang.c (opencl_language_defn): Likewise.
2299         * p-lang.c (pascal_language_defn): Likewise.
2300         * rust-lang.c (rust_language_defn): Likewise.
2301
2302 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2303
2304         * riscv-tdep.c (riscv_type_align): New function.
2305         (riscv_type_alignment): Delete.
2306         (riscv_arg_location): Use 'type_align'.
2307         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2308
2309 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2310
2311         * gdbtypes.c (type_align): A struct with no non-static fields also
2312         has alignment of 1.
2313
2314 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2315
2316         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2317         component to 0.
2318         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2319         member.
2320         (riscv_struct_info::analyse): New implementation using new
2321         analyse_inner member function.
2322         (riscv_struct_info::field_offset): New member function.
2323         (riscv_struct_info::m_offsets): New member variable.
2324         (riscv_struct_info::analyse_inner): New private member function,
2325         takes the old implementation of riscv_struct_info::analyse but
2326         extended to track field offsets.
2327         (riscv_call_arg_struct): Update the struct folding special cases
2328         to handle cases where empty C++ structs, which are non-zero
2329         length, are found.
2330         (riscv_arg_location): Initialise the length of each location, a
2331         non-zero length now indicates the location is in use.
2332         (riscv_push_dummy_call): Allow for the first location having a
2333         non-zero offset when setting up arguments.
2334         (riscv_return_value): Likewise, but for return values.
2335
2336 2019-04-11  Tom Tromey  <tromey@adacore.com>
2337
2338         * utils.c (internal_vproblem): Make "msg" const.
2339
2340 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2341
2342         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2343         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2344         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2345         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2346
2347 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2348
2349         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2350         function.
2351         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2352         of amd64_collect_native_gregset.
2353         (amd64_linux_nat_target::store_registers): Likewise.
2354
2355 2019-04-10  Tom Tromey  <tom@tromey.com>
2356
2357         * symtab.c (lookup_global_symbol_from_objfile)
2358         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2359         * objfiles.h (class separate_debug_iterator): New.
2360         (class separate_debug_range): New.
2361         (struct objfile) <separate_debug_objfiles>: New method.
2362         (objfile_separate_debug_iterate): Don't declare.
2363         * objfiles.c (separate_debug_iterator::operator++): Rename from
2364         objfile_separate_debug_iterate.
2365         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2366         iterator.
2367         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2368         iterator.
2369
2370 2019-04-10  Tom Tromey  <tom@tromey.com>
2371
2372         * symfile.c (reread_symbols): Remove old comment.
2373         * objfiles.c (free_all_objfiles): Fix a typo.
2374
2375 2019-04-10  Tom Tromey  <tom@tromey.com>
2376
2377         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2378         * minsyms.c (lookup_minimal_symbol): Use foreach.
2379         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2380         (lookup_minimal_symbol_solib_trampoline): Likewise.
2381         * symfile.c (reread_symbols): Use foreach.
2382
2383 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2384             Tom Tromey  <tromey@adacore.com>
2385
2386         PR rust/24414:
2387         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2388         (rust_lex_int_test): Change "value" to be LONGEST.
2389         (rust_lex_tests): Add test for long integer literal.
2390
2391 2019-04-09  Tom Tromey  <tromey@adacore.com>
2392
2393         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2394         to bool.
2395         (extended_remote_target::attach): Update.
2396         (remote_target::remote_notice_new_inferior): Update.
2397         (remote_target::add_current_inferior_and_thread): Update.
2398         * inferior.c (exit_inferior_1): Use "false".
2399         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2400
2401 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2402
2403         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2404         the "start" command.
2405
2406 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2407
2408         * python/py-inferior.c (infpy_thread_from_thread_handle):
2409         Adjust comments to reflect renaming of thread_from_thread_handle
2410         to thread_from_handle.  Adjust keywords.  Fix type error message.
2411         (inferior_object_methods): Add thread_from_handle.  Retain
2412         thread_from_thread_handle, but mark it as deprecated.
2413
2414 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2415
2416         * gdbthread.h (find_thread_by_handle): Revise declaration.
2417         * thread.c (find_thread_by_handle): Likewise.  Adjust
2418         implementation too.
2419         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2420         support for buffer objects as handles.
2421
2422 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2423
2424         * python/py-infthread.c (thpy_thread_handle): New function.
2425         (thread_object_methods): Register thpy_thread_handle.
2426
2427 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2428
2429         * gdbthread.h (thread_to_thread_handle): Declare.
2430         * thread.c (gdbtypes.h): Include.
2431         (thread_to_thread_handle): New function.
2432
2433         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2434         (target_thread_info_to_thread_handle): Declare.
2435         * target.c (target_thread_info_to_thread_handle): New function.
2436         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2437         * target-delegates.c: Regenerate.
2438
2439         * linux-thread-db.c (class thread_db_target): Add method
2440         thread_info_to_thread_handle.
2441         (thread_db_target::thread_info_to_thread_handle): Define.
2442         * remote.c (class remote_target): Add new method
2443         thread_info_to_thread_handle.
2444         (remote_target::thread_info_to_thread_handle): Define.
2445
2446 2019-04-08  Pedro Alves  <palves@redhat.com>
2447
2448         * common/common-exceptions.c (throw_exception): Don't create
2449         named object to throw; throw directly.
2450         (throw_it): Likewise.  Don't initialize gdb_exception::message
2451         here, with new; pass FMT and AP to the ctor instead.
2452         * common/common-exceptions.h: Include <string>.
2453         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2454         const char *, va_list)): New ctor.  Use std::make_shared.
2455         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2456         errors)): Delete.
2457         (gdb_exception_error::gdb_exception_error(enum errors, const char
2458         *, va_list)): New.
2459         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2460         Add assertion.
2461         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2462         errors)): Delete.
2463         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2464         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2465         Add assertion.
2466
2467 2019-04-08  Tom Tromey  <tom@tromey.com>
2468
2469         * valops.c (value_rtti_indirect_type): Replace throw_exception
2470         with throw.
2471         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2472         with throw.
2473         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2474         throw.
2475         * target.c (target_translate_tls_address): Replace throw_exception
2476         with throw.
2477         * stack.c (frame_apply_command_count): Replace throw_exception
2478         with throw.
2479         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2480         throw.
2481         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2482         with throw.
2483         * rs6000-tdep.c (rs6000_frame_cache)
2484         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2485         * remote.c: Replace throw_exception with throw.
2486         * record-full.c (record_full_message, record_full_wait_1)
2487         (record_full_restore): Replace throw_exception with throw.
2488         * record-btrace.c:
2489         (get_thread_current_frame_id, record_btrace_start_replaying)
2490         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2491         (cmd_record_btrace_start): Replace throw_exception with throw.
2492         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2493         throw.
2494         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2495         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2496         * linespec.c:
2497         (find_linespec_symbols): Replace throw_exception with throw.
2498         * infrun.c (displaced_step_prepare, resume): Replace
2499         throw_exception with throw.
2500         * infcmd.c (post_create_inferior): Replace throw_exception with
2501         throw.
2502         * inf-loop.c (inferior_event_handler): Replace throw_exception
2503         with throw.
2504         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2505         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2506         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2507         (get_prev_frame_always, get_frame_pc_if_available)
2508         (get_frame_address_in_block_if_available, get_frame_language):
2509         Replace throw_exception with throw.
2510         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2511         throw_exception with throw.
2512         * eval.c (fetch_subexp_value, evaluate_var_value)
2513         (evaluate_funcall, evaluate_subexp_standard): Replace
2514         throw_exception with throw.
2515         * dwarf2loc.c (call_site_find_chain)
2516         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2517         Replace throw_exception with throw.
2518         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2519         with throw.
2520         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2521         throw.
2522         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2523         * completer.c (complete_line_internal): Replace throw_exception
2524         with throw.
2525         * compile/compile-object-run.c (compile_object_run): Replace
2526         throw_exception with throw.
2527         * cli/cli-script.c (process_next_line): Replace throw_exception
2528         with throw.
2529         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2530         (btrace_enable, btrace_maint_update_pt_packets): Replace
2531         throw_exception with throw.
2532         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2533         throw_exception with throw.
2534         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2535         throw_exception with throw.
2536         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2537         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2538         * aarch64-tdep.c (aarch64_make_prologue_cache)
2539         (aarch64_make_stub_cache): Replace throw_exception with throw.
2540
2541 2019-04-08  Tom Tromey  <tom@tromey.com>
2542
2543         * common/common-exceptions.c (throw_exception): Rename from
2544         throw_exception_cxx.  Remove old copy.  Make argument const.
2545         (throw_it): Create and throw exception objects directly.
2546         * common/common-exceptions.h (throw_exception): Make argument
2547         const.
2548         (struct gdb_exception_error): Add constructor.
2549         (struct gdb_exception_quit): Add constructor.
2550
2551 2019-04-08  Tom Tromey  <tom@tromey.com>
2552
2553         * common/common-exceptions.h (exception_rethrow): Don't declare.
2554         (TRY_SJLJ): Update comment.
2555         (TRY, CATCH, END_CATCH): Remove.
2556         * common/common-exceptions.c (exception_rethrow): Remove.
2557
2558 2019-04-08  Tom Tromey  <tom@tromey.com>
2559
2560         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2561         Remove.
2562         (gdb_exception_error): Rename from
2563         gdb_exception_RETURN_MASK_ERROR.
2564         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2565         (gdb_quit_bad_alloc): Update.
2566         * aarch64-tdep.c: Update.
2567         * ada-lang.c: Update.
2568         * ada-typeprint.c: Update.
2569         * ada-valprint.c: Update.
2570         * amd64-tdep.c: Update.
2571         * arch-utils.c: Update.
2572         * break-catch-throw.c: Update.
2573         * breakpoint.c: Update.
2574         * btrace.c: Update.
2575         * c-varobj.c: Update.
2576         * cli/cli-cmds.c: Update.
2577         * cli/cli-interp.c: Update.
2578         * cli/cli-script.c: Update.
2579         * common/common-exceptions.c: Update.
2580         * common/new-op.c: Update.
2581         * common/selftest.c: Update.
2582         * compile/compile-c-symbols.c: Update.
2583         * compile/compile-cplus-symbols.c: Update.
2584         * compile/compile-object-load.c: Update.
2585         * compile/compile-object-run.c: Update.
2586         * completer.c: Update.
2587         * corelow.c: Update.
2588         * cp-abi.c: Update.
2589         * cp-support.c: Update.
2590         * cp-valprint.c: Update.
2591         * darwin-nat.c: Update.
2592         * disasm-selftests.c: Update.
2593         * dtrace-probe.c: Update.
2594         * dwarf-index-cache.c: Update.
2595         * dwarf-index-write.c: Update.
2596         * dwarf2-frame-tailcall.c: Update.
2597         * dwarf2-frame.c: Update.
2598         * dwarf2loc.c: Update.
2599         * dwarf2read.c: Update.
2600         * eval.c: Update.
2601         * event-loop.c: Update.
2602         * event-top.c: Update.
2603         * exec.c: Update.
2604         * f-valprint.c: Update.
2605         * fbsd-tdep.c: Update.
2606         * frame-unwind.c: Update.
2607         * frame.c: Update.
2608         * gdbtypes.c: Update.
2609         * gnu-v3-abi.c: Update.
2610         * guile/guile-internal.h: Update.
2611         * guile/scm-block.c: Update.
2612         * guile/scm-breakpoint.c: Update.
2613         * guile/scm-cmd.c: Update.
2614         * guile/scm-disasm.c: Update.
2615         * guile/scm-frame.c: Update.
2616         * guile/scm-lazy-string.c: Update.
2617         * guile/scm-math.c: Update.
2618         * guile/scm-param.c: Update.
2619         * guile/scm-ports.c: Update.
2620         * guile/scm-pretty-print.c: Update.
2621         * guile/scm-symbol.c: Update.
2622         * guile/scm-symtab.c: Update.
2623         * guile/scm-type.c: Update.
2624         * guile/scm-value.c: Update.
2625         * i386-linux-tdep.c: Update.
2626         * i386-tdep.c: Update.
2627         * inf-loop.c: Update.
2628         * infcall.c: Update.
2629         * infcmd.c: Update.
2630         * infrun.c: Update.
2631         * jit.c: Update.
2632         * language.c: Update.
2633         * linespec.c: Update.
2634         * linux-fork.c: Update.
2635         * linux-nat.c: Update.
2636         * linux-tdep.c: Update.
2637         * linux-thread-db.c: Update.
2638         * main.c: Update.
2639         * mi/mi-cmd-break.c: Update.
2640         * mi/mi-cmd-stack.c: Update.
2641         * mi/mi-interp.c: Update.
2642         * mi/mi-main.c: Update.
2643         * objc-lang.c: Update.
2644         * p-valprint.c: Update.
2645         * parse.c: Update.
2646         * ppc-linux-tdep.c: Update.
2647         * printcmd.c: Update.
2648         * python/py-arch.c: Update.
2649         * python/py-breakpoint.c: Update.
2650         * python/py-cmd.c: Update.
2651         * python/py-finishbreakpoint.c: Update.
2652         * python/py-frame.c: Update.
2653         * python/py-framefilter.c: Update.
2654         * python/py-gdb-readline.c: Update.
2655         * python/py-inferior.c: Update.
2656         * python/py-infthread.c: Update.
2657         * python/py-lazy-string.c: Update.
2658         * python/py-linetable.c: Update.
2659         * python/py-objfile.c: Update.
2660         * python/py-param.c: Update.
2661         * python/py-prettyprint.c: Update.
2662         * python/py-progspace.c: Update.
2663         * python/py-record-btrace.c: Update.
2664         * python/py-record.c: Update.
2665         * python/py-symbol.c: Update.
2666         * python/py-type.c: Update.
2667         * python/py-unwind.c: Update.
2668         * python/py-utils.c: Update.
2669         * python/py-value.c: Update.
2670         * python/python.c: Update.
2671         * record-btrace.c: Update.
2672         * record-full.c: Update.
2673         * remote-fileio.c: Update.
2674         * remote.c: Update.
2675         * riscv-tdep.c: Update.
2676         * rs6000-aix-tdep.c: Update.
2677         * rs6000-tdep.c: Update.
2678         * rust-exp.y: Update.
2679         * rust-lang.c: Update.
2680         * s390-tdep.c: Update.
2681         * selftest-arch.c: Update.
2682         * solib-dsbt.c: Update.
2683         * solib-frv.c: Update.
2684         * solib-spu.c: Update.
2685         * solib-svr4.c: Update.
2686         * solib.c: Update.
2687         * sparc64-linux-tdep.c: Update.
2688         * stack.c: Update.
2689         * symfile-mem.c: Update.
2690         * symmisc.c: Update.
2691         * target.c: Update.
2692         * thread.c: Update.
2693         * top.c: Update.
2694         * tracefile-tfile.c: Update.
2695         * tui/tui.c: Update.
2696         * typeprint.c: Update.
2697         * unittests/cli-utils-selftests.c: Update.
2698         * unittests/parse-connection-spec-selftests.c: Update.
2699         * valops.c: Update.
2700         * valprint.c: Update.
2701         * value.c: Update.
2702         * varobj.c: Update.
2703         * windows-nat.c: Update.
2704         * x86-linux-nat.c: Update.
2705         * xml-support.c: Update.
2706
2707 2019-04-08  Tom Tromey  <tom@tromey.com>
2708
2709         * xml-support.c: Use C++ exception handling.
2710         * x86-linux-nat.c: Use C++ exception handling.
2711         * windows-nat.c: Use C++ exception handling.
2712         * varobj.c: Use C++ exception handling.
2713         * value.c: Use C++ exception handling.
2714         * valprint.c: Use C++ exception handling.
2715         * valops.c: Use C++ exception handling.
2716         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2717         handling.
2718         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2719         * typeprint.c: Use C++ exception handling.
2720         * tui/tui.c: Use C++ exception handling.
2721         * tracefile-tfile.c: Use C++ exception handling.
2722         * top.c: Use C++ exception handling.
2723         * thread.c: Use C++ exception handling.
2724         * target.c: Use C++ exception handling.
2725         * symmisc.c: Use C++ exception handling.
2726         * symfile-mem.c: Use C++ exception handling.
2727         * stack.c: Use C++ exception handling.
2728         * sparc64-linux-tdep.c: Use C++ exception handling.
2729         * solib.c: Use C++ exception handling.
2730         * solib-svr4.c: Use C++ exception handling.
2731         * solib-spu.c: Use C++ exception handling.
2732         * solib-frv.c: Use C++ exception handling.
2733         * solib-dsbt.c: Use C++ exception handling.
2734         * selftest-arch.c: Use C++ exception handling.
2735         * s390-tdep.c: Use C++ exception handling.
2736         * rust-lang.c: Use C++ exception handling.
2737         * rust-exp.y: Use C++ exception handling.
2738         * rs6000-tdep.c: Use C++ exception handling.
2739         * rs6000-aix-tdep.c: Use C++ exception handling.
2740         * riscv-tdep.c: Use C++ exception handling.
2741         * remote.c: Use C++ exception handling.
2742         * remote-fileio.c: Use C++ exception handling.
2743         * record-full.c: Use C++ exception handling.
2744         * record-btrace.c: Use C++ exception handling.
2745         * python/python.c: Use C++ exception handling.
2746         * python/py-value.c: Use C++ exception handling.
2747         * python/py-utils.c: Use C++ exception handling.
2748         * python/py-unwind.c: Use C++ exception handling.
2749         * python/py-type.c: Use C++ exception handling.
2750         * python/py-symbol.c: Use C++ exception handling.
2751         * python/py-record.c: Use C++ exception handling.
2752         * python/py-record-btrace.c: Use C++ exception handling.
2753         * python/py-progspace.c: Use C++ exception handling.
2754         * python/py-prettyprint.c: Use C++ exception handling.
2755         * python/py-param.c: Use C++ exception handling.
2756         * python/py-objfile.c: Use C++ exception handling.
2757         * python/py-linetable.c: Use C++ exception handling.
2758         * python/py-lazy-string.c: Use C++ exception handling.
2759         * python/py-infthread.c: Use C++ exception handling.
2760         * python/py-inferior.c: Use C++ exception handling.
2761         * python/py-gdb-readline.c: Use C++ exception handling.
2762         * python/py-framefilter.c: Use C++ exception handling.
2763         * python/py-frame.c: Use C++ exception handling.
2764         * python/py-finishbreakpoint.c: Use C++ exception handling.
2765         * python/py-cmd.c: Use C++ exception handling.
2766         * python/py-breakpoint.c: Use C++ exception handling.
2767         * python/py-arch.c: Use C++ exception handling.
2768         * printcmd.c: Use C++ exception handling.
2769         * ppc-linux-tdep.c: Use C++ exception handling.
2770         * parse.c: Use C++ exception handling.
2771         * p-valprint.c: Use C++ exception handling.
2772         * objc-lang.c: Use C++ exception handling.
2773         * mi/mi-main.c: Use C++ exception handling.
2774         * mi/mi-interp.c: Use C++ exception handling.
2775         * mi/mi-cmd-stack.c: Use C++ exception handling.
2776         * mi/mi-cmd-break.c: Use C++ exception handling.
2777         * main.c: Use C++ exception handling.
2778         * linux-thread-db.c: Use C++ exception handling.
2779         * linux-tdep.c: Use C++ exception handling.
2780         * linux-nat.c: Use C++ exception handling.
2781         * linux-fork.c: Use C++ exception handling.
2782         * linespec.c: Use C++ exception handling.
2783         * language.c: Use C++ exception handling.
2784         * jit.c: Use C++ exception handling.
2785         * infrun.c: Use C++ exception handling.
2786         * infcmd.c: Use C++ exception handling.
2787         * infcall.c: Use C++ exception handling.
2788         * inf-loop.c: Use C++ exception handling.
2789         * i386-tdep.c: Use C++ exception handling.
2790         * i386-linux-tdep.c: Use C++ exception handling.
2791         * guile/scm-value.c: Use C++ exception handling.
2792         * guile/scm-type.c: Use C++ exception handling.
2793         * guile/scm-symtab.c: Use C++ exception handling.
2794         * guile/scm-symbol.c: Use C++ exception handling.
2795         * guile/scm-pretty-print.c: Use C++ exception handling.
2796         * guile/scm-ports.c: Use C++ exception handling.
2797         * guile/scm-param.c: Use C++ exception handling.
2798         * guile/scm-math.c: Use C++ exception handling.
2799         * guile/scm-lazy-string.c: Use C++ exception handling.
2800         * guile/scm-frame.c: Use C++ exception handling.
2801         * guile/scm-disasm.c: Use C++ exception handling.
2802         * guile/scm-cmd.c: Use C++ exception handling.
2803         * guile/scm-breakpoint.c: Use C++ exception handling.
2804         * guile/scm-block.c: Use C++ exception handling.
2805         * guile/guile-internal.h: Use C++ exception handling.
2806         * gnu-v3-abi.c: Use C++ exception handling.
2807         * gdbtypes.c: Use C++ exception handling.
2808         * frame.c: Use C++ exception handling.
2809         * frame-unwind.c: Use C++ exception handling.
2810         * fbsd-tdep.c: Use C++ exception handling.
2811         * f-valprint.c: Use C++ exception handling.
2812         * exec.c: Use C++ exception handling.
2813         * event-top.c: Use C++ exception handling.
2814         * event-loop.c: Use C++ exception handling.
2815         * eval.c: Use C++ exception handling.
2816         * dwarf2read.c: Use C++ exception handling.
2817         * dwarf2loc.c: Use C++ exception handling.
2818         * dwarf2-frame.c: Use C++ exception handling.
2819         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2820         * dwarf-index-write.c: Use C++ exception handling.
2821         * dwarf-index-cache.c: Use C++ exception handling.
2822         * dtrace-probe.c: Use C++ exception handling.
2823         * disasm-selftests.c: Use C++ exception handling.
2824         * darwin-nat.c: Use C++ exception handling.
2825         * cp-valprint.c: Use C++ exception handling.
2826         * cp-support.c: Use C++ exception handling.
2827         * cp-abi.c: Use C++ exception handling.
2828         * corelow.c: Use C++ exception handling.
2829         * completer.c: Use C++ exception handling.
2830         * compile/compile-object-run.c: Use C++ exception handling.
2831         * compile/compile-object-load.c: Use C++ exception handling.
2832         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2833         * compile/compile-c-symbols.c: Use C++ exception handling.
2834         * common/selftest.c: Use C++ exception handling.
2835         * common/new-op.c: Use C++ exception handling.
2836         * cli/cli-script.c: Use C++ exception handling.
2837         * cli/cli-interp.c: Use C++ exception handling.
2838         * cli/cli-cmds.c: Use C++ exception handling.
2839         * c-varobj.c: Use C++ exception handling.
2840         * btrace.c: Use C++ exception handling.
2841         * breakpoint.c: Use C++ exception handling.
2842         * break-catch-throw.c: Use C++ exception handling.
2843         * arch-utils.c: Use C++ exception handling.
2844         * amd64-tdep.c: Use C++ exception handling.
2845         * ada-valprint.c: Use C++ exception handling.
2846         * ada-typeprint.c: Use C++ exception handling.
2847         * ada-lang.c: Use C++ exception handling.
2848         * aarch64-tdep.c: Use C++ exception handling.
2849
2850 2019-04-08  Tom Tromey  <tom@tromey.com>
2851
2852         * xml-support.c (gdb_xml_parser::parse): Update.
2853         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2854         * value.c (show_convenience): Update.
2855         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2856         (test_parse_flags_qcs): Update.
2857         * thread.c (thr_try_catch_cmd): Update.
2858         * target.c (target_translate_tls_address): Update.
2859         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2860         (info_frame_command_core, frame_apply_command_count): Update.
2861         * rust-exp.y (rust_lex_exception_test): Update.
2862         * riscv-tdep.c (riscv_print_one_register_info): Update.
2863         * remote.c (remote_target::enable_btrace): Update.
2864         * record-btrace.c (record_btrace_enable_warn): Update.
2865         * python/py-utils.c (gdbpy_convert_exception): Update.
2866         * printcmd.c (do_one_display, print_variable_and_value): Update.
2867         * mi/mi-main.c (mi_print_exception): Update.
2868         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2869         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2870         * linux-nat.c (linux_nat_target::attach): Update.
2871         * linux-fork.c (class scoped_switch_fork_info): Update.
2872         * infrun.c (displaced_step_prepare): Update.
2873         * infcall.c (call_function_by_hand_dummy): Update.
2874         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2875         * gnu-v3-abi.c (print_one_vtable): Update.
2876         * frame.c (get_prev_frame_always): Update.
2877         * f-valprint.c (info_common_command_for_block): Update.
2878         * exec.c (try_open_exec_file): Update.
2879         * exceptions.c (print_exception, exception_print)
2880         (exception_fprintf, exception_print_same): Update.
2881         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2882         * dwarf-index-cache.c (index_cache::store)
2883         (index_cache::lookup_gdb_index): Update.
2884         * darwin-nat.c (maybe_cache_shell): Update.
2885         * cp-valprint.c (cp_print_value_fields): Update.
2886         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2887         (gcc_cplus_symbol_address): Update.
2888         * compile/compile-c-symbols.c (gcc_convert_symbol)
2889         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2890         * common/selftest.c: Update.
2891         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2892         a std::string.
2893         (exception_try_scope_entry, exception_try_scope_exit): Don't
2894         declare.
2895         (struct exception_try_scope): Remove.
2896         (TRY): Don't use exception_try_scope.
2897         (struct gdb_exception): Add constructor, operator=.
2898         <what>: New method.
2899         (struct gdb_exception_RETURN_MASK_ALL)
2900         (struct gdb_exception_RETURN_MASK_ERROR)
2901         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2902         (struct gdb_quit_bad_alloc): Update.
2903         * common/common-exceptions.c (exception_none): Change
2904         initializer.
2905         (struct catcher) <state, exception>: Initialize inline.
2906         <prev>: Remove member.
2907         (current_catcher): Remove.
2908         (catchers): New global.
2909         (exceptions_state_mc_init): Simplify.
2910         (catcher_pop): Remove.
2911         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2912         (try_scope_depth, exception_try_scope_entry)
2913         (exception_try_scope_exit): Remove.
2914         (throw_exception_sjlj): Update.
2915         (exception_messages, exception_messages_size): Remove.
2916         (throw_it): Simplify.
2917         (gdb_exception_sliced_copy): Remove.
2918         (throw_exception_cxx): Update.
2919         * cli/cli-script.c (script_from_file): Update.
2920         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2921         Update.
2922         * ada-valprint.c (ada_val_print): Update.
2923         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2924         (create_excep_cond_exprs): Update.
2925
2926 2019-04-08  Tom Tromey  <tom@tromey.com>
2927
2928         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2929         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2930         (TRY, CATCH, END_CATCH): Remove some definitions.
2931         * common/common-exceptions.c: Don't use GDB_XCPT.
2932         (catcher_list_size): Remove.
2933         (throw_exception, throw_it): Simplify.
2934
2935 2019-04-05  Tom Tromey  <tom@tromey.com>
2936
2937         Revert the header-sorting patch.
2938         * ft32-tdep.c: Revert.
2939         * frv-tdep.c: Revert.
2940         * frv-linux-tdep.c: Revert.
2941         * frame.c: Revert.
2942         * frame-unwind.c: Revert.
2943         * frame-base.c: Revert.
2944         * fork-child.c: Revert.
2945         * findvar.c: Revert.
2946         * findcmd.c: Revert.
2947         * filesystem.c: Revert.
2948         * filename-seen-cache.h: Revert.
2949         * filename-seen-cache.c: Revert.
2950         * fbsd-tdep.c: Revert.
2951         * fbsd-nat.h: Revert.
2952         * fbsd-nat.c: Revert.
2953         * f-valprint.c: Revert.
2954         * f-typeprint.c: Revert.
2955         * f-lang.c: Revert.
2956         * extension.h: Revert.
2957         * extension.c: Revert.
2958         * extension-priv.h: Revert.
2959         * expprint.c: Revert.
2960         * exec.h: Revert.
2961         * exec.c: Revert.
2962         * exceptions.c: Revert.
2963         * event-top.c: Revert.
2964         * event-loop.c: Revert.
2965         * eval.c: Revert.
2966         * elfread.c: Revert.
2967         * dwarf2read.h: Revert.
2968         * dwarf2read.c: Revert.
2969         * dwarf2loc.c: Revert.
2970         * dwarf2expr.h: Revert.
2971         * dwarf2expr.c: Revert.
2972         * dwarf2-frame.c: Revert.
2973         * dwarf2-frame-tailcall.c: Revert.
2974         * dwarf-index-write.h: Revert.
2975         * dwarf-index-write.c: Revert.
2976         * dwarf-index-common.c: Revert.
2977         * dwarf-index-cache.h: Revert.
2978         * dwarf-index-cache.c: Revert.
2979         * dummy-frame.c: Revert.
2980         * dtrace-probe.c: Revert.
2981         * disasm.h: Revert.
2982         * disasm.c: Revert.
2983         * disasm-selftests.c: Revert.
2984         * dictionary.c: Revert.
2985         * dicos-tdep.c: Revert.
2986         * demangle.c: Revert.
2987         * dcache.h: Revert.
2988         * dcache.c: Revert.
2989         * darwin-nat.h: Revert.
2990         * darwin-nat.c: Revert.
2991         * darwin-nat-info.c: Revert.
2992         * d-valprint.c: Revert.
2993         * d-namespace.c: Revert.
2994         * d-lang.c: Revert.
2995         * ctf.c: Revert.
2996         * csky-tdep.c: Revert.
2997         * csky-linux-tdep.c: Revert.
2998         * cris-tdep.c: Revert.
2999         * cris-linux-tdep.c: Revert.
3000         * cp-valprint.c: Revert.
3001         * cp-support.c: Revert.
3002         * cp-namespace.c: Revert.
3003         * cp-abi.c: Revert.
3004         * corelow.c: Revert.
3005         * corefile.c: Revert.
3006         * continuations.c: Revert.
3007         * completer.h: Revert.
3008         * completer.c: Revert.
3009         * complaints.c: Revert.
3010         * coffread.c: Revert.
3011         * coff-pe-read.c: Revert.
3012         * cli-out.h: Revert.
3013         * cli-out.c: Revert.
3014         * charset.c: Revert.
3015         * c-varobj.c: Revert.
3016         * c-valprint.c: Revert.
3017         * c-typeprint.c: Revert.
3018         * c-lang.c: Revert.
3019         * buildsym.c: Revert.
3020         * buildsym-legacy.c: Revert.
3021         * build-id.h: Revert.
3022         * build-id.c: Revert.
3023         * btrace.c: Revert.
3024         * bsd-uthread.c: Revert.
3025         * breakpoint.h: Revert.
3026         * breakpoint.c: Revert.
3027         * break-catch-throw.c: Revert.
3028         * break-catch-syscall.c: Revert.
3029         * break-catch-sig.c: Revert.
3030         * blockframe.c: Revert.
3031         * block.c: Revert.
3032         * bfin-tdep.c: Revert.
3033         * bfin-linux-tdep.c: Revert.
3034         * bfd-target.c: Revert.
3035         * bcache.c: Revert.
3036         * ax-general.c: Revert.
3037         * ax-gdb.h: Revert.
3038         * ax-gdb.c: Revert.
3039         * avr-tdep.c: Revert.
3040         * auxv.c: Revert.
3041         * auto-load.c: Revert.
3042         * arm-wince-tdep.c: Revert.
3043         * arm-tdep.c: Revert.
3044         * arm-symbian-tdep.c: Revert.
3045         * arm-pikeos-tdep.c: Revert.
3046         * arm-obsd-tdep.c: Revert.
3047         * arm-nbsd-tdep.c: Revert.
3048         * arm-nbsd-nat.c: Revert.
3049         * arm-linux-tdep.c: Revert.
3050         * arm-linux-nat.c: Revert.
3051         * arm-fbsd-tdep.c: Revert.
3052         * arm-fbsd-nat.c: Revert.
3053         * arm-bsd-tdep.c: Revert.
3054         * arch-utils.c: Revert.
3055         * arc-tdep.c: Revert.
3056         * arc-newlib-tdep.c: Revert.
3057         * annotate.h: Revert.
3058         * annotate.c: Revert.
3059         * amd64-windows-tdep.c: Revert.
3060         * amd64-windows-nat.c: Revert.
3061         * amd64-tdep.c: Revert.
3062         * amd64-sol2-tdep.c: Revert.
3063         * amd64-obsd-tdep.c: Revert.
3064         * amd64-obsd-nat.c: Revert.
3065         * amd64-nbsd-tdep.c: Revert.
3066         * amd64-nbsd-nat.c: Revert.
3067         * amd64-nat.c: Revert.
3068         * amd64-linux-tdep.c: Revert.
3069         * amd64-linux-nat.c: Revert.
3070         * amd64-fbsd-tdep.c: Revert.
3071         * amd64-fbsd-nat.c: Revert.
3072         * amd64-dicos-tdep.c: Revert.
3073         * amd64-darwin-tdep.c: Revert.
3074         * amd64-bsd-nat.c: Revert.
3075         * alpha-tdep.c: Revert.
3076         * alpha-obsd-tdep.c: Revert.
3077         * alpha-nbsd-tdep.c: Revert.
3078         * alpha-mdebug-tdep.c: Revert.
3079         * alpha-linux-tdep.c: Revert.
3080         * alpha-linux-nat.c: Revert.
3081         * alpha-bsd-tdep.c: Revert.
3082         * alpha-bsd-nat.c: Revert.
3083         * aix-thread.c: Revert.
3084         * agent.c: Revert.
3085         * addrmap.c: Revert.
3086         * ada-varobj.c: Revert.
3087         * ada-valprint.c: Revert.
3088         * ada-typeprint.c: Revert.
3089         * ada-tasks.c: Revert.
3090         * ada-lang.c: Revert.
3091         * aarch64-tdep.c: Revert.
3092         * aarch64-ravenscar-thread.c: Revert.
3093         * aarch64-newlib-tdep.c: Revert.
3094         * aarch64-linux-tdep.c: Revert.
3095         * aarch64-linux-nat.c: Revert.
3096         * aarch64-fbsd-tdep.c: Revert.
3097         * aarch64-fbsd-nat.c: Revert.
3098         * aarch32-linux-nat.c: Revert.
3099
3100 2019-04-05  Tom Tromey  <tom@tromey.com>
3101
3102         * ft32-tdep.c: Sort headers.
3103         * frv-tdep.c: Sort headers.
3104         * frv-linux-tdep.c: Sort headers.
3105         * frame.c: Sort headers.
3106         * frame-unwind.c: Sort headers.
3107         * frame-base.c: Sort headers.
3108         * fork-child.c: Sort headers.
3109         * findvar.c: Sort headers.
3110         * findcmd.c: Sort headers.
3111         * filesystem.c: Sort headers.
3112         * filename-seen-cache.h: Sort headers.
3113         * filename-seen-cache.c: Sort headers.
3114         * fbsd-tdep.c: Sort headers.
3115         * fbsd-nat.h: Sort headers.
3116         * fbsd-nat.c: Sort headers.
3117         * f-valprint.c: Sort headers.
3118         * f-typeprint.c: Sort headers.
3119         * f-lang.c: Sort headers.
3120         * extension.h: Sort headers.
3121         * extension.c: Sort headers.
3122         * extension-priv.h: Sort headers.
3123         * expprint.c: Sort headers.
3124         * exec.h: Sort headers.
3125         * exec.c: Sort headers.
3126         * exceptions.c: Sort headers.
3127         * event-top.c: Sort headers.
3128         * event-loop.c: Sort headers.
3129         * eval.c: Sort headers.
3130         * elfread.c: Sort headers.
3131         * dwarf2read.h: Sort headers.
3132         * dwarf2read.c: Sort headers.
3133         * dwarf2loc.c: Sort headers.
3134         * dwarf2expr.h: Sort headers.
3135         * dwarf2expr.c: Sort headers.
3136         * dwarf2-frame.c: Sort headers.
3137         * dwarf2-frame-tailcall.c: Sort headers.
3138         * dwarf-index-write.h: Sort headers.
3139         * dwarf-index-write.c: Sort headers.
3140         * dwarf-index-common.c: Sort headers.
3141         * dwarf-index-cache.h: Sort headers.
3142         * dwarf-index-cache.c: Sort headers.
3143         * dummy-frame.c: Sort headers.
3144         * dtrace-probe.c: Sort headers.
3145         * disasm.h: Sort headers.
3146         * disasm.c: Sort headers.
3147         * disasm-selftests.c: Sort headers.
3148         * dictionary.c: Sort headers.
3149         * dicos-tdep.c: Sort headers.
3150         * demangle.c: Sort headers.
3151         * dcache.h: Sort headers.
3152         * dcache.c: Sort headers.
3153         * darwin-nat.h: Sort headers.
3154         * darwin-nat.c: Sort headers.
3155         * darwin-nat-info.c: Sort headers.
3156         * d-valprint.c: Sort headers.
3157         * d-namespace.c: Sort headers.
3158         * d-lang.c: Sort headers.
3159         * ctf.c: Sort headers.
3160         * csky-tdep.c: Sort headers.
3161         * csky-linux-tdep.c: Sort headers.
3162         * cris-tdep.c: Sort headers.
3163         * cris-linux-tdep.c: Sort headers.
3164         * cp-valprint.c: Sort headers.
3165         * cp-support.c: Sort headers.
3166         * cp-namespace.c: Sort headers.
3167         * cp-abi.c: Sort headers.
3168         * corelow.c: Sort headers.
3169         * corefile.c: Sort headers.
3170         * continuations.c: Sort headers.
3171         * completer.h: Sort headers.
3172         * completer.c: Sort headers.
3173         * complaints.c: Sort headers.
3174         * coffread.c: Sort headers.
3175         * coff-pe-read.c: Sort headers.
3176         * cli-out.h: Sort headers.
3177         * cli-out.c: Sort headers.
3178         * charset.c: Sort headers.
3179         * c-varobj.c: Sort headers.
3180         * c-valprint.c: Sort headers.
3181         * c-typeprint.c: Sort headers.
3182         * c-lang.c: Sort headers.
3183         * buildsym.c: Sort headers.
3184         * buildsym-legacy.c: Sort headers.
3185         * build-id.h: Sort headers.
3186         * build-id.c: Sort headers.
3187         * btrace.c: Sort headers.
3188         * bsd-uthread.c: Sort headers.
3189         * breakpoint.h: Sort headers.
3190         * breakpoint.c: Sort headers.
3191         * break-catch-throw.c: Sort headers.
3192         * break-catch-syscall.c: Sort headers.
3193         * break-catch-sig.c: Sort headers.
3194         * blockframe.c: Sort headers.
3195         * block.c: Sort headers.
3196         * bfin-tdep.c: Sort headers.
3197         * bfin-linux-tdep.c: Sort headers.
3198         * bfd-target.c: Sort headers.
3199         * bcache.c: Sort headers.
3200         * ax-general.c: Sort headers.
3201         * ax-gdb.h: Sort headers.
3202         * ax-gdb.c: Sort headers.
3203         * avr-tdep.c: Sort headers.
3204         * auxv.c: Sort headers.
3205         * auto-load.c: Sort headers.
3206         * arm-wince-tdep.c: Sort headers.
3207         * arm-tdep.c: Sort headers.
3208         * arm-symbian-tdep.c: Sort headers.
3209         * arm-pikeos-tdep.c: Sort headers.
3210         * arm-obsd-tdep.c: Sort headers.
3211         * arm-nbsd-tdep.c: Sort headers.
3212         * arm-nbsd-nat.c: Sort headers.
3213         * arm-linux-tdep.c: Sort headers.
3214         * arm-linux-nat.c: Sort headers.
3215         * arm-fbsd-tdep.c: Sort headers.
3216         * arm-fbsd-nat.c: Sort headers.
3217         * arm-bsd-tdep.c: Sort headers.
3218         * arch-utils.c: Sort headers.
3219         * arc-tdep.c: Sort headers.
3220         * arc-newlib-tdep.c: Sort headers.
3221         * annotate.h: Sort headers.
3222         * annotate.c: Sort headers.
3223         * amd64-windows-tdep.c: Sort headers.
3224         * amd64-windows-nat.c: Sort headers.
3225         * amd64-tdep.c: Sort headers.
3226         * amd64-sol2-tdep.c: Sort headers.
3227         * amd64-obsd-tdep.c: Sort headers.
3228         * amd64-obsd-nat.c: Sort headers.
3229         * amd64-nbsd-tdep.c: Sort headers.
3230         * amd64-nbsd-nat.c: Sort headers.
3231         * amd64-nat.c: Sort headers.
3232         * amd64-linux-tdep.c: Sort headers.
3233         * amd64-linux-nat.c: Sort headers.
3234         * amd64-fbsd-tdep.c: Sort headers.
3235         * amd64-fbsd-nat.c: Sort headers.
3236         * amd64-dicos-tdep.c: Sort headers.
3237         * amd64-darwin-tdep.c: Sort headers.
3238         * amd64-bsd-nat.c: Sort headers.
3239         * alpha-tdep.c: Sort headers.
3240         * alpha-obsd-tdep.c: Sort headers.
3241         * alpha-nbsd-tdep.c: Sort headers.
3242         * alpha-mdebug-tdep.c: Sort headers.
3243         * alpha-linux-tdep.c: Sort headers.
3244         * alpha-linux-nat.c: Sort headers.
3245         * alpha-bsd-tdep.c: Sort headers.
3246         * alpha-bsd-nat.c: Sort headers.
3247         * aix-thread.c: Sort headers.
3248         * agent.c: Sort headers.
3249         * addrmap.c: Sort headers.
3250         * ada-varobj.c: Sort headers.
3251         * ada-valprint.c: Sort headers.
3252         * ada-typeprint.c: Sort headers.
3253         * ada-tasks.c: Sort headers.
3254         * ada-lang.c: Sort headers.
3255         * aarch64-tdep.c: Sort headers.
3256         * aarch64-ravenscar-thread.c: Sort headers.
3257         * aarch64-newlib-tdep.c: Sort headers.
3258         * aarch64-linux-tdep.c: Sort headers.
3259         * aarch64-linux-nat.c: Sort headers.
3260         * aarch64-fbsd-tdep.c: Sort headers.
3261         * aarch64-fbsd-nat.c: Sort headers.
3262         * aarch32-linux-nat.c: Sort headers.
3263
3264 2019-04-04  Tom Tromey  <tom@tromey.com>
3265
3266         * varobj.c (varobj_create): Update.
3267         * rust-exp.y (struct rust_parser) <update_innermost_block,
3268         lookup_symbol>: New methods.
3269         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3270         Rename.
3271         (rust_parser::rust_lookup_type)
3272         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3273         * printcmd.c (display_command, do_one_display): Update.
3274         * parser-defs.h (struct parser_state) <parser_state>: Add
3275         "tracker" parameter.
3276         (block_tracker): New member.
3277         (class innermost_block_tracker) <innermost_block_tracker>: Add
3278         "types" parameter.
3279         <reset>: Remove method.
3280         (innermost_block): Don't declare.
3281         (null_post_parser): Update.
3282         * parse.c (innermost_block): Remove global.
3283         (write_dollar_variable): Update.
3284         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3285         Remove "tracker_types" parameter.
3286         (parse_expression): Add "tracker" parameter.
3287         (parse_expression_for_completion): Update.
3288         (null_post_parser): Add "tracker" parameter.
3289         * p-exp.y: Update rules.
3290         * m2-exp.y: Update rules.
3291         * language.h (struct language_defn) <la_post_parser>: Add
3292         "tracker" parameter.
3293         * go-exp.y: Update rules.
3294         * f-exp.y: Update rules.
3295         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3296         parameter.
3297         * d-exp.y: Update rules.
3298         * c-exp.y: Update rules.
3299         * breakpoint.c (set_breakpoint_condition): Create an
3300         innermost_block_tracker.
3301         (watch_command_1): Likewise.
3302         * ada-lang.c (resolve): Add "tracker" parameter.
3303         (resolve_subexp): Likewise.
3304         * ada-exp.y (write_var_from_sym): Update.
3305
3306 2019-04-04  Tom Tromey  <tom@tromey.com>
3307
3308         * type-stack.h: New file.
3309         * type-stack.c: New file.
3310         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3311         type-stack.h.
3312         (insert_into_type_stack, insert_type, push_type, push_type_int)
3313         (insert_type_address_space, pop_type, pop_type_int)
3314         (pop_typelist, pop_type_stack, append_type_stack)
3315         (push_type_stack, get_type_stack, push_typelist)
3316         (follow_type_instance_flags, follow_types): Don't declare.
3317         * parse.c (type_stack): Remove global.
3318         (parse_exp_in_context): Update.
3319         (insert_into_type_stack, insert_type, push_type, push_type_int)
3320         (insert_type_address_space, pop_type, pop_type_int)
3321         (pop_typelist, pop_type_stack, append_type_stack)
3322         (push_type_stack, get_type_stack, push_typelist)
3323         (follow_type_instance_flags, follow_types): Remove (moved to
3324         type-stack.c).
3325         * f-exp.y (type_stack): New global.
3326         Update rules.
3327         (push_kind_type, f_parse): Update.
3328         * d-exp.y (type_stack): New global.
3329         Update rules.
3330         (d_parse): Update.
3331         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3332         Update rules.
3333         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3334         (HFILES_NO_SRCDIR): Add type-stack.h.
3335
3336 2019-04-04  Tom Tromey  <tom@tromey.com>
3337
3338         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3339         (rust_parser::convert_ast_to_expression, rust_parse)
3340         (rust_lex_test_completion, rust_lex_tests): Update.
3341         * parser-defs.h (struct expr_completion_state): New.
3342         (struct parser_state) <parser_state>: Add completion parameter.
3343         <mark_struct_expression, mark_completion_tag>: New methods.
3344         <parse_completion, m_completion_state>: New members.
3345         (prefixify_expression, null_post_parser): Update.
3346         (mark_struct_expression, mark_completion_tag): Don't declare.
3347         * parse.c (parse_completion, expout_last_struct)
3348         (expout_tag_completion_type, expout_completion_name): Remove
3349         globals.
3350         (parser_state::mark_struct_expression)
3351         (parser_state::mark_completion_tag): Now methods.
3352         (prefixify_expression): Add last_struct parameter.
3353         (prefixify_subexp): Likewise.
3354         (parse_exp_1): Update.
3355         (parse_exp_in_context): Add cstate parameter.  Update.
3356         (parse_expression_for_completion): Create an
3357         expr_completion_state.
3358         (null_post_parser): Add "completion" parameter.
3359         * p-exp.y: Update rules.
3360         (yylex): Update.
3361         * language.h (struct language_defn) <la_post_parser>: Add
3362         "completing" parameter.
3363         * go-exp.y: Update rules.
3364         (lex_one_token): Update.
3365         * expression.h (parse_completion): Don't declare.
3366         * d-exp.y: Update rules.
3367         (lex_one_token): Update rules.
3368         * c-exp.y: Update rules.
3369         (lex_one_token): Update.
3370         * ada-lang.c (resolve): Add "parse_completion" parameter.
3371         (resolve_subexp): Likewise.
3372         (ada_resolve_function): Likewise.
3373
3374 2019-04-04  Tom Tromey  <tom@tromey.com>
3375
3376         * parser-defs.h (struct parser_state) <start_arglist,
3377         end_arglist>: New methods.
3378         <arglist_len, m_funcall_chain>: New members.
3379         (arglist_len, start_arglist, end_arglist): Don't declare.
3380         * parse.c (arglist_len, funcall_chain): Remove global.
3381         (start_arglist, end_arglist): Remove functions.
3382         (parse_exp_in_context): Update.
3383         * p-exp.y: Update rules.
3384         * m2-exp.y: Update rules.
3385         * go-exp.y: Update rules.
3386         * f-exp.y: Update rules.
3387         * d-exp.y: Update rules.
3388         * c-exp.y: Update rules.
3389
3390 2019-04-04  Tom Tromey  <tom@tromey.com>
3391
3392         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3393         lex_operator, push_back>: New methods.
3394         Update all rules.
3395         (rust_parser::lex_hex, lex_escape): Rename and update.
3396         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3397         (rust_parser::lex_operator): Rename and update.
3398         (rust_parser::lex_number, rustyylex, rustyyerror)
3399         (rust_lex_test_init, rust_lex_test_sequence)
3400         (rust_lex_test_push_back, rust_lex_tests): Update.
3401         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3402         parameter.
3403         <lexptr, prev_lexptr>: New members.
3404         (lexptr, prev_lexptr): Don't declare.
3405         * parse.c (lexptr, prev_lexptr): Remove globals.
3406         (parse_exp_in_context): Update.
3407         * p-exp.y (yylex, yyerror): Update.
3408         * m2-exp.y (parse_number, yylex, yyerror): Update.
3409         * go-exp.y (lex_one_token, yyerror): Update.
3410         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3411         * d-exp.y (lex_one_token, yyerror): Update.
3412         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3413         (lex_one_token, yyerror): Update.
3414         * ada-lex.l (YY_INPUT): Update.
3415         (rewind_to_char): Update.
3416         * ada-exp.y (yyerror): Update.
3417
3418 2019-04-04  Tom Tromey  <tom@tromey.com>
3419
3420         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3421         * parser-defs.h (struct parser_state) <parser_state>: Add new
3422         parameter.
3423         <comma_terminates>: New member.
3424         (comma_terminates): Don't declare global.
3425         * parse.c (comma_terminates): Remove global.
3426         (parse_exp_in_context): Update.
3427         * p-exp.y (yylex): Update.
3428         * m2-exp.y (yylex): Update.
3429         * go-exp.y (lex_one_token): Update.
3430         * f-exp.y (yylex): Update.
3431         * d-exp.y (lex_one_token): Update.
3432         * c-exp.y (lex_one_token): Update.
3433         * ada-lex.l: Update.
3434
3435 2019-04-04  Tom Tromey  <tom@tromey.com>
3436
3437         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3438         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3439         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3440         * parser-defs.h (paren_depth): Don't declare.
3441         * parse.c (paren_depth): Remove global.
3442         (parse_exp_in_context): Update.
3443         * p-exp.y (paren_depth): New global.
3444         (pascal_parse): Initialize it.
3445         * m2-exp.y (paren_depth): New global.
3446         (m2_parse): Initialize it.
3447         * go-exp.y (paren_depth): New global.
3448         (go_parse): Initialize it.
3449         * f-exp.y (paren_depth): New global.
3450         (f_parse): Initialize it.
3451         * d-exp.y (paren_depth): New global.
3452         (d_parse): Initialize it.
3453         * c-exp.y (paren_depth): New global.
3454         (c_parse): Initialize it.
3455         * ada-lex.l (paren_depth): New global.
3456         (lexer_init): Initialize it.
3457
3458 2019-04-04  Tom Tromey  <tom@tromey.com>
3459
3460         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3461         (rust_parser::convert_ast_to_type)
3462         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3463         * parser-defs.h (struct parser_state) <parser_state>: Add
3464         parameters.  Initialize new members.
3465         <expression_context_block, expression_context_pc>: New members.
3466         * parse.c (expression_context_block, expression_context_pc):
3467         Remove globals.
3468         (parse_exp_in_context): Update.
3469         * p-exp.y: Update all rules.
3470         (yylex): Update.
3471         * m2-exp.y: Update all rules.
3472         (yylex): Update.
3473         * go-exp.y (yylex): Update.
3474         * f-exp.y (yylex): Update.
3475         * d-exp.y: Update all rules.
3476         (yylex): Update.
3477         * c-exp.y: Update all rules.
3478         (lex_one_token, classify_name, yylex, c_parse): Update.
3479         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3480
3481 2019-04-04  Tom Tromey  <tom@tromey.com>
3482
3483         * gdbarch.h, gdbarch.c: Rebuild.
3484         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3485         * stap-probe.h:
3486         (struct stap_parse_info): Replace "parser_state" with
3487         "expr_builder".
3488         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3489         (parser_state): New class.
3490         * parse.c (expr_builder): Rename.
3491         (expr_builder::release): Rename.
3492         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3493         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3494         (write_exp_elt_longcst, write_exp_elt_floatcst)
3495         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3496         (write_exp_string_vector, write_exp_bitstring)
3497         (write_exp_msymbol, mark_struct_expression)
3498         (write_dollar_variable)
3499         (insert_type_address_space, increase_expout_size): Replace
3500         "parser_state" with "expr_builder".
3501         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3502         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3503         "parser_state" with "expr_builder".
3504
3505 2019-04-04  Tom Tromey  <tom@tromey.com>
3506
3507         * rust-exp.y: Replace "parse_language" with method call.
3508         * p-exp.y:
3509         (yylex): Replace "parse_language" with method call.
3510         * m2-exp.y:
3511         (yylex): Replace "parse_language" with method call.
3512         * go-exp.y (classify_name): Replace "parse_language" with method
3513         call.
3514         * f-exp.y (yylex): Replace "parse_language" with method call.
3515         * d-exp.y (lex_one_token): Replace "parse_language" with method
3516         call.
3517         * c-exp.y:
3518         (lex_one_token, classify_name, yylex): Replace "parse_language"
3519         with method call.
3520         * ada-exp.y (find_primitive_type, type_char)
3521         (type_system_address): Replace "parse_language" with method call.
3522
3523 2019-04-04  Tom Tromey  <tom@tromey.com>
3524
3525         * rust-exp.y: Replace "parse_gdbarch" with method call.
3526         * parse.c (write_dollar_variable, insert_type_address_space):
3527         Replace "parse_gdbarch" with method call.
3528         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3529         call.
3530         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3531         call.
3532         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3533         "parse_gdbarch" with method call.
3534         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3535         with method call.
3536         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3537         "parse_gdbarch" with method call.
3538         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3539         "parse_gdbarch" with method call.
3540         * c-exp.y (parse_type, parse_number, classify_name): Replace
3541         "parse_gdbarch" with method call.
3542         * ada-lex.l: Replace "parse_gdbarch" with method call.
3543         * ada-exp.y (parse_type, find_primitive_type, type_char)
3544         (type_system_address): Replace "parse_gdbarch" with method call.
3545
3546 2019-04-04  Tom Tromey  <tom@tromey.com>
3547
3548         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3549         * stap-probe.c (stap_parse_argument): Update.
3550         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3551         initial_size parameter.
3552         * rust-exp.y (rust_lex_tests): Update.
3553         * parse.c (parser_state): Update.
3554         (parse_exp_in_context): Update.
3555         * parser-defs.h (struct parser_state) <parser_state>: Remove
3556         "initial_size" parameter.
3557
3558 2019-04-04  Tom Tromey  <tom@tromey.com>
3559
3560         * parser-defs.h (increase_expout_size): Don't declare.
3561         * parse.c (increase_expout_size): Now static.
3562
3563 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3564
3565         * gnu-nat.c (gnu_nat_target::wait): Fix
3566         target_waitstatus_to_string call.
3567
3568 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3569
3570         * eval.c (evaluate_subexp_standard): Handle internal functions
3571         during Fortran function call handling.
3572
3573 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3574
3575         * NEWS: Mention new internal functions.
3576         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3577         (read_base_type): Use dwarf2_init_complex_target_type.
3578         * value.c (creal_internal_fn): New function.
3579         (cimag_internal_fn): New function.
3580         (_initialize_values): Register new internal functions.
3581
3582 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3583
3584         * infrun.c (stop_all_threads): If debug_infrun, always
3585         trace the wait status after wait_one, using
3586         target_waitstatus_to_string and target_pid_to_str.
3587         (handle_inferior_event): Replace various trace of
3588         wait status kind by a single trace.
3589         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3590         wait status kind image by target_waitstatus_to_string.
3591         * target/waitstatus.c (target_waitstatus_to_string): Fix
3592         obsolete comment.
3593
3594 2019-04-01  Tom Tromey  <tromey@adacore.com>
3595
3596         PR symtab/23331:
3597         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3598
3599 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3600             Pedro Alves  <palves@redhat.com>
3601
3602         * top.c (quit_force): Call 'finalize_values'.
3603         * value.c (finalize_values): New function.
3604         * value.h (finalize_values): Declare.
3605
3606 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3607
3608         * NEWS: Announce $_gdb_major and $_gdb_minor.
3609
3610         * top.c (init_gdb_version_vars): New function.
3611         (gdb_init): Call init_gdb_version_vars.
3612
3613 2019-03-29  Tom Tromey  <tromey@adacore.com>
3614
3615         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3616         help text.  Remove dead code.
3617
3618 2019-03-29  Keith Seitz  <keiths@redhat.com>
3619
3620         From Siddhesh Poyarekar:
3621         * f-lang.h (f77_get_upperbound): Return LONGEST.
3622         (f77_get_lowerbound): Likewise.
3623         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3624         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3625         print them.
3626         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3627         plongest to format print it.
3628         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3629         (f77_get_upperbound): Likewise.
3630         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3631         LOWER_BOUND to LONGEST.
3632         (f77_create_arrayprint_offset_tbl): Likewise.
3633
3634 2019-03-29  Keith Seitz  <keiths@redhat.com>
3635
3636         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3637         %s/pulongest for TYPE_LENGTH instead of %d in format
3638         strings.
3639         * ada-typerint.c (ada_print_type): Likewise.
3640         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3641         * compile/compile-c-support.c (generate_register_struct): Likewise.
3642         * gdbtypes.c (recursive_dump_type): Likewise.
3643         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3644         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3645         instead of %d in format strings.
3646         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3647         to std::min to ULONGEST.
3648         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3649         instead of %d in format strings.
3650         * tracepoint.c (info_scope_command): Likewise.
3651         * typeprint.c (print_offset_data::update)
3652         (print_offset_data::finish): Likewise.
3653         * xtensa-tdep.c (xtensa_store_return_value)
3654         (xtensa_push_dummy_call): Likewise.
3655
3656 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3657
3658         * windows-nat.c (display_selector): Fixed format specifications
3659         for 64-bit Cygwin.
3660
3661 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3662
3663         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3664
3665 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3666
3667         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3668         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3669         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3670         (nios2_linux_init_abi): Install it.
3671
3672 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3673
3674         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3675
3676 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3677
3678         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3679
3680 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3681             Tom Tromey  <tromey@adacore.com>
3682
3683         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3684
3685 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3686
3687         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3688         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3689         method to compute the bounds of range types. Also print "[evaluated]"
3690         if the bounds' values come from a dynamic evaluation.
3691
3692 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3693
3694         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3695         whitespace when pretty printing is on.
3696
3697 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3698
3699         * ppc-linux-nat.c: Add include.
3700
3701 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3702
3703         * NEWS: Mention AArch64 Pointer Authentication.
3704
3705 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3706
3707         * arm-linux-nat.c: Add include.
3708
3709 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3710
3711         * source-cache.c (source_cache::get_source_lines): Re-read
3712         fullname after calling open_source_file.
3713
3714 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3715
3716         * NEWS: Mention TLS support for FreeBSD.
3717
3718 2019-03-25  Tom Tromey  <tromey@adacore.com>
3719
3720         * minsyms.c (BUNCH_SIZE): Update comment.
3721         (~minimal_symbol_reader): Remove old comment.
3722         (compact_minimal_symbols): Update comment.
3723         (minimal_symbol_reader::install): Remove old comment.  Update
3724         other comments.
3725
3726 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3727
3728         * s390-linux-nat.c: Add include.
3729
3730 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3731
3732         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3733         Call linux_get_hwcap.
3734         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3735         Likewise.
3736         (aarch64_linux_get_hwcap): Remove function.
3737         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3738         declaration.
3739         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3740         linux_get_hwcap.
3741         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3742         * linux-tdep.c (linux_get_hwcap): Add function.
3743         (linux_get_hwcap2): Likewise.
3744         * linux-tdep.h (linux_get_hwcap): Add declaration.
3745         (linux_get_hwcap2): Likewise.
3746         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3747         (ppc_linux_get_hwcap2): Likewise.
3748         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3749         linux_get_hwcap.
3750         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3751         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3752         (ppc_linux_nat_target::read_description): Likewise.
3753         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3754         * s390-linux-nat.c: Likewise.
3755         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3756
3757 2019-03-24  Tom Tromey  <tom@tromey.com>
3758
3759         * ada-lang.c (standard_lookup): Simplify initialization.
3760         (ada_lookup_symbol_nonlocal): Simplify return.
3761         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3762         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3763         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3764         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3765         initialization.
3766         * solib.c (solib_global_lookup): Simplify.
3767         * symtab.c (null_block_symbol): Remove.
3768         (symbol_cache_lookup): Simplify returns.
3769         (lookup_language_this): Simplify returns.
3770         (lookup_symbol_aux): Simplify return.
3771         (lookup_local_symbol): Simplify returns.
3772         (lookup_global_symbol_from_objfile): Simplify return.
3773         (lookup_symbol_in_objfile_symtabs)
3774         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3775         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3776         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3777         * cp-namespace.c (cp_lookup_bare_symbol)
3778         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3779         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3780         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3781         (cp_lookup_symbol_via_imports): Simplify initialization.
3782         (find_symbol_in_baseclass): Likewise.
3783         * symtab.h (null_block_symbol): Remove.
3784         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3785         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3786         (d_lookup_symbol_module): Likewise.
3787         (find_symbol_in_baseclass): Simplify initialization.
3788
3789 2019-03-24  Tom Tromey  <tom@tromey.com>
3790
3791         * expression.h: Don't include symtab.h.
3792         (struct block): Forward declare.
3793
3794 2019-03-24  Tom Tromey  <tom@tromey.com>
3795
3796         * c-exp.y (typebase): Remove casts.
3797         * gdbtypes.c (lookup_unsigned_typename, )
3798         (lookup_signed_typename): Remove cast.
3799         * eval.c (parse_to_comma_and_eval): Remove cast.
3800         * parse.c (write_dollar_variable): Remove cast.
3801         * block.h (struct block) <superblock>: Now const.
3802         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3803         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3804         (map_block): Make "block" const.
3805         * symfile.h (struct quick_symbol_functions)
3806         <map_matching_symbols>: Constify block argument to "callback".
3807         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3808         const.
3809         (find_pc_sect_compunit_symtab): Make "b" const.
3810         (find_symbol_at_address): Likewise.
3811         (search_symbols): Likewise.
3812         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3813         (dw2_debug_names_lookup_symbol): Likewise.
3814         (dw2_map_matching_symbols): Update.
3815         * p-valprint.c (pascal_val_print): Remove "block".
3816         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3817         (aux_add_nonlocal_symbols): Make "block" const.
3818         (resolve_subexp): Remove cast.
3819         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3820         const.
3821         (iterate_over_file_blocks): Likewise.
3822         * f-exp.y (%union) <bval>: Remove.
3823         * coffread.c (patch_opaque_types): Make "b" const.
3824         * spu-tdep.c (spu_catch_start): Make "block" const.
3825         * c-valprint.c (print_unpacked_pointer): Remove "block".
3826         * symmisc.c (dump_symtab_1): Make "b" const.
3827         (block_depth): Make "block" const.
3828         * d-exp.y (%union) <bval>: Remove.
3829         * cp-support.h (cp_lookup_rtti_type): Update.
3830         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3831         * psymtab.c (psym_lookup_symbol): Make "block" const.
3832         (maintenance_check_psymtabs): Make "b" const.
3833         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3834         (enumerate_locals, enumerate_args): Update.
3835         * python/py-symtab.c (stpy_global_block): Make "block" const.
3836         (stpy_static_block): Likewise.
3837         * inline-frame.c (block_starting_point_at): Make "new_block"
3838         const.
3839         * block.c (find_block_in_blockvector): Make return type const.
3840         (blockvector_for_pc_sect): Make "b" const.
3841         (find_block_in_blockvector): Make "b" const.
3842
3843 2019-03-23  Tom Tromey  <tom@tromey.com>
3844
3845         * varobj.c (varobj_create): Update.
3846         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3847         * printcmd.c (display_command, do_one_display): Don't reset
3848         innermost_block.
3849         * parser-defs.h (enum innermost_block_tracker_type): Move to
3850         expression.h.
3851         (innermost_block): Update comment.
3852         * parse.c (parse_exp_1): Add tracker_types parameter.
3853         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3854         tracker_types parameter.  Reset innermost_block.
3855         (parse_exp_in_context): Remove.
3856         (parse_expression_for_completion): Update.
3857         * objfiles.c (~objfile): Don't reset expression_context_block or
3858         innermost_block.
3859         * expression.h (enum innermost_block_tracker_type): Move from
3860         parser-defs.h.
3861         (parse_exp_1): Add tracker_types parameter.
3862         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3863         reset innermost_block.
3864
3865 2019-03-23  Tom Tromey  <tom@tromey.com>
3866
3867         * objfiles.h: Include bcache.h.
3868
3869 2019-03-23  Tom Tromey  <tom@tromey.com>
3870
3871         * linespec.c (get_current_search_block): Use
3872         scoped_restore_current_language.
3873         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3874
3875 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3876             Jiong Wang  <jiong.wang@arm.com>
3877
3878         * aarch64-linux-tdep.c
3879         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3880         section.
3881         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3882
3883 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3884             Jiong Wang  <jiong.wang@arm.com>
3885
3886         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3887         instructions.
3888         (aarch64_analyze_prologue_test): Add PACIASP test.
3889         (aarch64_prologue_prev_register): Unmask PC value.
3890
3891 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3892             Jiong Wang  <jiong.wang@arm.com>
3893
3894         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3895         (aarch64_dwarf2_prev_register): Unmask PC value.
3896         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3897         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3898         DW_CFA_AARCH64_negate_ra_state.
3899         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3900
3901 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3902             Jiong Wang  <jiong.wang@arm.com>
3903
3904         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3905         registers.
3906         (aarch64_pseudo_register_name): Likewise.
3907         (aarch64_pseudo_register_type): Likewise.
3908         (aarch64_pseudo_register_reggroup_p): Likewise.
3909         (aarch64_gdbarch_init): Add pauth registers.
3910         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3911         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3912         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3913         (struct gdbarch_tdep): Add regnum for ra_state.
3914
3915 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3916             Jiong Wang  <jiong.wang@arm.com>
3917
3918         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3919
3920 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3921             Jiong Wang  <jiong.wang@arm.com>
3922
3923         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3924         function.
3925         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3926         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3927         (aarch64_gdbarch_init): Add puth registers.
3928         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3929         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3930         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3931
3932 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3933             Jiong Wang  <jiong.wang@arm.com>
3934
3935         * aarch64-linux-nat.c
3936         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3937         * aarch64-linux-tdep.c
3938         (aarch64_linux_core_read_description): Likewise.
3939         (aarch64_linux_get_hwcap): New function.
3940         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3941         (aarch64_linux_get_hwcap): New declaration.
3942
3943 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3944             Jiong Wang  <jiong.wang@arm.com>
3945
3946         * aarch64-linux-nat.c
3947         (aarch64_linux_nat_target::read_description): Add pauth param.
3948         * aarch64-linux-tdep.c
3949         (aarch64_linux_core_read_description): Likewise.
3950         * aarch64-tdep.c (struct target_desc): Add in pauth.
3951         (aarch64_read_description): Add pauth param.
3952         (aarch64_gdbarch_init): Likewise.
3953         * aarch64-tdep.h (aarch64_read_description): Likewise.
3954         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3955         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3956         * features/Makefile: Add new files.
3957         * features/aarch64-pauth.c: New file.
3958         * features/aarch64-pauth.xml: New file.
3959
3960 2019-03-20  Tom Tromey  <tromey@adacore.com>
3961
3962         * infrun.c (handle_inferior_event): Rename from
3963         handle_inferior_event_1.  Create a scoped_value_mark.
3964         (handle_inferior_event): Remove.
3965
3966 2019-03-19  Tom Tromey  <tromey@adacore.com>
3967
3968         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3969         * infrun.h (print_stop_event): Add "displays" parameter.
3970         * infrun.c (print_stop_event): Add "displays" parameter.
3971
3972 2019-03-19  Pedro Alves  <palves@redhat.com>
3973
3974         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3975         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3976         to -1.  Fix TABs vs spaces.
3977         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3978         * tui/tui-out.h (tui_ui_out) Add intro comments.
3979         <m_line, m_start_of_line>: In-class initialize, and add describing
3980         comment.
3981
3982 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3983
3984         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3985         variable names.
3986         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3987
3988 2019-03-18  Pedro Alves  <palves@redhat.com>
3989             Eli Zaretskii <eliz@gnu.org>
3990
3991         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3992         m_line and m_start_of_line.
3993
3994 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3995
3996         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3997         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3998         it returns a newline.  This fixes a regression in TU mode, whereby
3999         the next line is output on the same screen line as the user input.
4000
4001 2019-03-18  Tom Tromey  <tromey@adacore.com>
4002
4003         * minsyms.c (minimal_symbol_reader::install): Remove call to
4004         obstack_blank.
4005
4006 2019-03-18  Pedro Alves  <palves@redhat.com>
4007
4008         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4009         New globals.
4010         (apply_style): New, factored out from ...
4011         (apply_ansi_escape): ... this.  Handle reverse video mode.
4012         (tui_set_reverse_mode): New function.
4013         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4014         * tui/tui-winsource.c (tui_show_source_line): Use
4015         tui_set_reverse_mode instead of setting A_STANDOUT.
4016         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4017         New setter methods.
4018
4019 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4020
4021         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4022         Handle tabs.
4023
4024 2019-03-18  Tom Tromey  <tromey@adacore.com>
4025
4026         * ada-lang.c (empty_array): Add "high" parameter.
4027         (ada_evaluate_subexp): Update.
4028
4029 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4030
4031         * unittests/string_view-selftests.c: Define
4032         _initialize_string_view_selftests unconditionally.
4033
4034 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4035
4036         PR gdb/24350
4037         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4038
4039 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4040
4041         PR gdb/24351
4042         * windows-nat.c (display_selector): Fix format specifiers.
4043
4044 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4045
4046         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4047         tui_refill_source_window instead of tui_refresh_win, to update the
4048         current execution line.  This fixes redisplay of the current line
4049         when stepping through the code with "next" or "step".
4050
4051 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4052
4053         * source-cache.c (source_cache::get_source_lines): Call
4054         find_source_lines to initialize s->nlines.  This fixes vertical
4055         scrolling of TUI source window when the DOWN arrow is pressed.
4056
4057 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4058
4059         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4060         linux-thread-db.c (_initialize_thread_db): Likewise.
4061
4062 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4063
4064         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4065         wclrtoeol in tui_show_source_line".  This reverts changes made in
4066         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4067
4068 2019-03-15  Tom Tromey  <tom@tromey.com>
4069
4070         * symtab.h (struct minimal_symbol): Derive from
4071         general_symbol_info.
4072         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4073         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4074         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4075         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4076         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4077         (MSYMBOL_SEARCH_NAME): Update.
4078         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4079         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4080         * minsyms.c (minimal_symbol_reader::record_full): Update.
4081
4082 2019-03-15  Tom Tromey  <tom@tromey.com>
4083
4084         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4085
4086 2019-03-15  Tom Tromey  <tom@tromey.com>
4087
4088         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4089         unique_xmalloc_ptr.
4090         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4091         Update.
4092         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4093         (build_minimal_symbol_hash_tables)
4094         (minimal_symbol_reader::install): Update.
4095
4096 2019-03-15  Tom Tromey  <tom@tromey.com>
4097
4098         * symtab.c (create_demangled_names_hash): Update.
4099         (symbol_set_names): Update.
4100         * objfiles.h (struct objfile_per_bfd_storage)
4101         <demangled_names_hash>: Now an htab_up.
4102         * objfiles.c (objfile_per_bfd_storage): Simplify.
4103
4104 2019-03-15  Tom Tromey  <tom@tromey.com>
4105
4106         * objfiles.h (struct objfile_per_bfd_storage): Declare
4107         destructor.
4108         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4109         New.
4110         (get_objfile_bfd_data): Use new.  Don't initialize
4111         language_of_main.
4112         (free_objfile_per_bfd_storage): Remove.
4113         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4114
4115 2019-03-15  Tom Tromey  <tom@tromey.com>
4116
4117         * symfile.c (reread_symbols): Update.
4118         * objfiles.c (objfile::objfile): Update.
4119         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4120         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4121         comment.
4122         (minimal_symbol_reader::install): Update.
4123         (terminate_minimal_symbol_table): Remove.
4124         * jit.c (jit_object_close_impl): Update.
4125
4126 2019-03-15  Tom Tromey  <tom@tromey.com>
4127
4128         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4129         initializations.
4130
4131 2019-03-15  Tom Tromey  <tom@tromey.com>
4132
4133         * objfiles.h (struct objfile_per_bfd_storage)
4134         <demangled_hash_languages>: Now a bitset.
4135         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4136         (lookup_minimal_symbol): Update.
4137
4138 2019-03-15  Tom Tromey  <tom@tromey.com>
4139
4140         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4141         Don't return the symbol.
4142         * coffread.c (record_minimal_symbol): Use record_full.
4143
4144 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4145
4146         The MS-Windows port of ncurses fails to switch to a color pair if
4147         one or both of the colors are the implicit default colors.  This
4148         change records the default colors when TUI is initialized, and
4149         then specifies them explicitly when a color pair uses the default
4150         colors.  This allows color styling in TUI mode on MS-Windows.
4151
4152         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4153         ncurses_norm_attr.
4154         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4155         colors in ncurses_norm_attr.
4156         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4157         "none", replace it with the default color recorded in
4158         ncurses_norm_attr.
4159
4160 2019-03-14  Tom Tromey  <tromey@adacore.com>
4161
4162         * source-cache.h (class source_cache) <get_source_lines>: Return
4163         std::string.
4164         * source-cache.c (source_cache::extract_lines): Handle case where
4165         first_pos==npos.  Return std::string.
4166         (source_cache::get_source_lines): Update.
4167
4168 2019-03-14  Tom Tromey  <tromey@adacore.com>
4169
4170         * NEWS: Add item for "style sources" commands.
4171         * source-cache.c (source_cache::get_source_lines): Check
4172         source_styling.
4173         * cli/cli-style.c (source_styling): New global.
4174         (_initialize_cli_style): Add "style sources" commands.
4175         (show_style_sources): New function.
4176         * cli/cli-style.h (source_styling): Declare.
4177
4178 2019-03-14  Pedro Alves  <palves@redhat.com>
4179             Tom Tromey  <tromey@adacore.com>
4180
4181         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4182         * tui/tui-winsource.c (tui_refill_source_window): New function,
4183         from...
4184         (tui_horizontal_source_scroll): ... here.  Move some logic.
4185         * cli/cli-style.c (set_style_enabled): Notify new observable.
4186         * tui/tui-hooks.c (tui_redisplay_source): New function.
4187         (tui_attach_detach_observers): Attach or detach
4188         tui_redisplay_source.
4189         * observable.h (source_styling_changed): New observable.
4190         * observable.c: Define source_styling_changed observable.
4191
4192 2019-03-13  Tom Tromey  <tromey@adacore.com>
4193
4194         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4195         (i386_gnu_nat_target::store_registers): Update.
4196         * target-debug.h (target_debug_print_std_string): New macro.
4197         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4198         * windows-tdep.c (display_one_tib): Update.
4199         * tui/tui-stack.c (tui_make_status_line): Update.
4200         * top.c (print_inferior_quit_action): Update.
4201         * thread.c (thr_try_catch_cmd): Update.
4202         (add_thread_with_info): Update.
4203         (thread_target_id_str): Update.
4204         (thr_try_catch_cmd): Update.
4205         (thread_command): Update.
4206         (thread_find_command): Update.
4207         * record-btrace.c (record_btrace_target::info_record)
4208         (record_btrace_resume_thread, record_btrace_target::resume)
4209         (record_btrace_cancel_resume, record_btrace_step_thread)
4210         (record_btrace_target::wait, record_btrace_target::wait)
4211         (record_btrace_target::wait, record_btrace_target::stop): Update.
4212         * progspace.c (print_program_space): Update.
4213         * process-stratum-target.c
4214         (process_stratum_target::thread_address_space): Update.
4215         * linux-fork.c (linux_fork_mourn_inferior)
4216         (detach_checkpoint_command, info_checkpoints_command)
4217         (linux_fork_context): Update.
4218         (linux_fork_detach): Update.
4219         (class scoped_switch_fork_info): Update.
4220         (delete_checkpoint_command): Update.
4221         * infrun.c (follow_fork_inferior): Update.
4222         (follow_fork_inferior): Update.
4223         (proceed_after_vfork_done): Update.
4224         (handle_vfork_child_exec_or_exit): Update.
4225         (follow_exec): Update.
4226         (displaced_step_prepare_throw): Update.
4227         (displaced_step_restore): Update.
4228         (start_step_over): Update.
4229         (resume_1): Update.
4230         (clear_proceed_status_thread): Update.
4231         (proceed): Update.
4232         (print_target_wait_results): Update.
4233         (do_target_wait): Update.
4234         (context_switch): Update.
4235         (stop_all_threads): Update.
4236         (restart_threads): Update.
4237         (finish_step_over): Update.
4238         (handle_signal_stop): Update.
4239         (switch_back_to_stepped_thread): Update.
4240         (keep_going_pass_signal): Update.
4241         (print_exited_reason): Update.
4242         (normal_stop): Update.
4243         * inferior.c (inferior_pid_to_str): Change return type.
4244         (print_selected_inferior): Update.
4245         (add_inferior): Update.
4246         (detach_inferior): Update.
4247         * dummy-frame.c (fprint_dummy_frames): Update.
4248         * dcache.c (dcache_info_1): Update.
4249         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4250         (btrace_fetch, btrace_clear): Update.
4251         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4252         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4253         type.
4254         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4255         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4256         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4257         * gdbarch.c, gdbarch.h: Rebuild.
4258         * gdbarch.sh (core_pid_to_str): Change return type.
4259         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4260         return type.
4261         (windows_nat_target::pid_to_str): Change return type.
4262         (windows_delete_thread): Update.
4263         (windows_nat_target::attach): Update.
4264         (windows_nat_target::files_info): Update.
4265         * target-delegates.c: Rebuild.
4266         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4267         return type.
4268         (sol_thread_target::pid_to_str): Change return type.
4269         * remote.c (class remote_target) <pid_to_str>: Change return
4270         type.
4271         (remote_target::pid_to_str): Change return type.
4272         (extended_remote_target::attach, remote_target::remote_stop_ns)
4273         (remote_target::remote_notif_remove_queued_reply)
4274         (remote_target::push_stop_reply, remote_target::disable_btrace):
4275         Update.
4276         (extended_remote_target::attach): Update.
4277         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4278         type.
4279         (gdbsim_target::pid_to_str): Change return type.
4280         * ravenscar-thread.c (struct ravenscar_thread_target)
4281         <pid_to_str>: Change return type.
4282         (ravenscar_thread_target::pid_to_str): Change return type.
4283         * procfs.c (class procfs_target) <pid_to_str>: Change return
4284         type.
4285         (procfs_target::pid_to_str): Change return type.
4286         (procfs_target::attach): Update.
4287         (procfs_target::detach): Update.
4288         (procfs_target::fetch_registers): Update.
4289         (procfs_target::store_registers): Update.
4290         (procfs_target::wait): Update.
4291         (procfs_target::files_info): Update.
4292         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4293         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4294         return type.
4295         (nto_procfs_target::pid_to_str): Change return type.
4296         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4297         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4298         return type.
4299         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4300         (exit_lwp): Update.
4301         (attach_proc_task_lwp_callback, get_detach_signal)
4302         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4303         (linux_nat_target::resume, wait_lwp, stop_callback)
4304         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4305         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4306         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4307         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4308         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4309         type.
4310         (inf_ptrace_target::attach): Update.
4311         (inf_ptrace_target::files_info): Update.
4312         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4313         type.
4314         (go32_nat_target::pid_to_str): Change return type.
4315         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4316         (gnu_nat_target::wait): Update.
4317         (gnu_nat_target::wait): Update.
4318         (gnu_nat_target::resume): Update.
4319         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4320         (fbsd_nat_target::wait): Update.
4321         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4322         type.
4323         (darwin_nat_target::attach): Update.
4324         * corelow.c (class core_target) <pid_to_str>: Change return type.
4325         (core_target::pid_to_str): Change return type.
4326         * target.c (normal_pid_to_str): Change return type.
4327         (default_pid_to_str): Likewise.
4328         (target_pid_to_str): Change return type.
4329         (target_translate_tls_address): Update.
4330         (target_announce_detach): Update.
4331         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4332         return type.
4333         (bsd_uthread_target::pid_to_str): Change return type.
4334         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4335         type.
4336         (bsd_kvm_target::pid_to_str): Change return type.
4337         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4338         return type.
4339         (aix_thread_target::pid_to_str): Change return type.
4340         * target.h (struct target_ops) <pid_to_str>: Change return type.
4341         (target_pid_to_str, normal_pid_to_str): Likewise.
4342         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4343         type.
4344         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4345         type.
4346         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4347         return type.
4348         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4349         type.
4350         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4351         type.
4352         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4353         return type.
4354
4355 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4356
4357         * NEWS: Mention that the new default MI version is 3.  Mention
4358         changes to the output of commands and events that deal with
4359         multi-location breakpoints.
4360         * breakpoint.c: Include "mi/mi-out.h".
4361         (print_one_breakpoint): Change output syntax if using MI version
4362         >= 3.
4363         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4364         New.
4365         (mi_multi_location_breakpoint_output_fixed): New.
4366         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4367         (mi_cmd_fix_multi_location_breakpoint_output): New.
4368         (mi_multi_location_breakpoint_output_fixed): New.
4369         * mi/mi-cmds.c (mi_cmds): Register command
4370         -fix-multi-location-breakpoint-output.
4371         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4372         interpreter "mi".
4373
4374 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4375
4376         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4377         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4378         instantiate mi_ui_out based on interpreter name.
4379         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4380         * mi/mi-main.c (mi_load_progress): Likewise.
4381
4382 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4383
4384         * NEWS: Combine separate "New targets" sections for 8.3.
4385
4386 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4387
4388         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4389         (ppcfbsd_init_abi): Install gdbarch
4390         "fetch_tls_load_module_address" and "get_thread_local_address"
4391         methods.
4392
4393 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4394
4395         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4396         (riscv_fbsd_init_abi): Install gdbarch
4397         "fetch_tls_load_module_address" and "get_thread_local_address"
4398         methods.
4399
4400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4401
4402         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4403         (i386fbsd_init_abi): Install gdbarch
4404         "fetch_tls_load_module_address" and "get_thread_local_address"
4405         methods.
4406
4407 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4408
4409         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4410         (amd64fbsd_init_abi): Install gdbarch
4411         "fetch_tls_load_module_address" and "get_thread_local_address"
4412         methods.
4413
4414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4415
4416         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4417         (struct fbsd_pspace_data): New type.
4418         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4419         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4420         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4421         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4422         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4423
4424 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4425
4426         * gdbtypes.c (lookup_struct_elt): New function.
4427         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4428         * gdbtypes.h (struct struct_elt): New type.
4429         (lookup_struct_elt): New prototype.
4430
4431 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4432
4433         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4434         remove disabled code block.
4435
4436 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4437
4438         * gdbarch.sh (get_thread_local_address): New method.
4439         * gdbarch.h, gdbarch.c: Regenerate.
4440         * target.c (target_translate_tls_address): Use
4441         gdbarch_get_thread_local_address if present instead of
4442         target::get_thread_local_address.
4443
4444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4445
4446         * target.h (target::get_thread_local_address): Update comment.
4447
4448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4449
4450         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4451         objfile->separate_debug_objfile_backlink if not NULL.
4452
4453 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4454
4455         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4456         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4457         (amd64bsd_store_inferior_registers): Likewise.
4458         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4459         Enable segment base registers.
4460         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4461         PT_GETFSBASE and PT_GETGSBASE.
4462         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4463         PT_SETGSBASE.
4464         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4465         segment base registers.
4466         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4467
4468 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4469
4470         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4471         Update calls to i386_target_description to add 'segments'
4472         parameter.
4473         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4474         add segment base registers.
4475         * arch/i386.c (i386_create_target_description): Add 'segments'
4476         parameter to enable segment base registers.
4477         * arch/i386.h (i386_create_target_description): Likewise.
4478         * features/i386/32bit-segments.xml: New file.
4479         * features/i386/32bit-segments.c: Generate.
4480         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4481         call to i386_target_description to add 'segments' parameter.
4482         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4483         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4484         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4485         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4486         if feature is present.
4487         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4488         Add 'segments' parameter to call to i386_target_description.
4489         (i386_target_description): Add 'segments' parameter to enable
4490         segment base registers.
4491         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4492         to call to i386_target_description.
4493         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4494         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4495         Define I386_NUM_REGS.
4496         (i386_target_description): Add 'segments' parameter to enable
4497         segment base registers.
4498
4499 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4500
4501         PR/24325
4502         * source-cache.c: #undef open and close, to avoid unresolved
4503         externals during linking.
4504
4505 2019-03-12  Tom Tromey  <tromey@adacore.com>
4506
4507         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4508         const.  Add initializers.
4509         (_initialize_remote): Don't initialize ptid globals.
4510
4511 2019-03-12  Pedro Alves  <palves@redhat.com>
4512
4513         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4514
4515 2019-03-12  Pedro Alves  <palves@redhat.com>
4516
4517         * cp-name-parser.y (main): Remove unused 'len' variable.
4518
4519 2019-03-12  Tom Tromey  <tromey@adacore.com>
4520
4521         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4522         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4523
4524 2019-03-12  Tom Tromey  <tromey@adacore.com>
4525
4526         * linux-nat.c (iterate_over_lwps): Update.
4527         (stop_callback): Remove parameter.
4528         (stop_wait_callback, detach_callback, resume_set_callback)
4529         (select_singlestep_lwp_callback, set_ignore_sigint)
4530         (status_callback, resumed_callback, resume_clear_callback)
4531         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4532         data parameter.
4533         (linux_nat_target::detach, linux_nat_target::resume)
4534         (linux_stop_and_wait_all_lwps, select_event_lwp)
4535         (linux_nat_filter_event, linux_nat_wait_1)
4536         (linux_nat_target::kill, linux_nat_target::stop)
4537         (linux_nat_target::stop): Update.
4538         (linux_nat_resume_callback): Change type.
4539         (resume_stopped_resumed_lwps, count_events_callback)
4540         (select_event_lwp_callback): Likewise.
4541         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4542         * arm-linux-nat.c (struct update_registers_data): Remove.
4543         (update_registers_callback): Change type.
4544         (arm_linux_insert_hw_breakpoint1): Update.
4545         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4546         parameter.
4547         (x86_linux_dr_set_addr): Update.
4548         (x86_linux_dr_set_control): Update.
4549         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4550         (iterate_over_lwps): Use gdb::function_view.
4551         * nat/aarch64-linux-hw-point.c (struct
4552         aarch64_dr_update_callback_param): Remove.
4553         (debug_reg_change_callback): Change type.
4554         (aarch64_notify_debug_reg_change): Update.
4555         * s390-linux-nat.c (s390_refresh_per_info): Update.
4556
4557 2019-03-11  Tom Tromey  <tromey@adacore.com>
4558
4559         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4560         redundant assignment to "this_cu".
4561
4562 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4563
4564         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4565
4566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4567
4568         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4569         from...
4570         (rank_one_type): ... this.
4571
4572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4573
4574         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4575         from...
4576         (rank_one_type): ... this.
4577
4578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4579
4580         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4581         from...
4582         (rank_one_type): ... this.
4583
4584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4585
4586         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4587         from...
4588         (rank_one_type): ... this.
4589
4590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4591
4592         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4593         from...
4594         (rank_one_type): ... this.
4595
4596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4597
4598         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4599         from...
4600         (rank_one_type): ... this.
4601
4602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4603
4604         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4605         from...
4606         (rank_one_type): ... this.
4607
4608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4609
4610         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4611         from...
4612         (rank_one_type): ... this.
4613
4614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4615
4616         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4617         from...
4618         (rank_one_type): ... this.
4619
4620 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4621
4622         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4623         from...
4624         (rank_one_type): ... this.
4625
4626 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4627
4628         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4629         from...
4630         (rank_one_type): ... this.
4631
4632 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4633
4634         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4635         from...
4636         (rank_one_type): ... this.
4637
4638 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4639
4640         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4641         inferior-events' shows the example events.
4642
4643 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4644
4645         Support styling on native MS-Windows console
4646
4647         PR/24315
4648         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4649         on MS-Windows if $TERM is not defined.
4650
4651         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4652
4653         * posix-hdep.c (gdb_console_fputs):
4654         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4655         functions.
4656         * ui-file.h (gdb_console_fputs): Add prototype.
4657
4658         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4659         back to fputs only if the former returns zero.
4660
4661 2019-03-07  Tom Tromey  <tom@tromey.com>
4662
4663         * symmisc.c (print_symbol_bcache_statistics): Update.
4664         (print_objfile_statistics): Update.
4665         * symfile.c (allocate_symtab): Update.
4666         * stabsread.c: Don't include bcache.h.
4667         * psymtab.h (struct psymbol_bcache): Don't declare.
4668         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4669         (psymbol_bcache_init, psymbol_bcache_free)
4670         (psymbol_bcache_get_bcache): Don't declare.
4671         * psymtab.c (struct psymbol_bcache): Remove.
4672         (psymtab_storage::psymtab_storage): Update.
4673         (psymtab_storage::~psymtab_storage): Update.
4674         (psymbol_bcache_init, psymbol_bcache_free)
4675         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4676         (add_psymbol_to_bcache): Update.
4677         (allocate_psymtab): Update.
4678         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4679         macro_cache>: No longer pointers.
4680         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4681         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4682         * macrotab.c (macro_bcache): Update.
4683         * macroexp.c: Don't include bcache.h.
4684         * gdbtypes.c (check_types_worklist): Update.
4685         (types_deeply_equal): Remove TRY/CATCH.  Update.
4686         * elfread.c (elf_symtab_read): Update.
4687         * dwarf2read.c: Don't include bcache.h.
4688         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4689         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4690         (print_bcache_statistics, bcache_memory_used): Don't declare.
4691         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4692         methods.  Rename all data members.
4693         * bcache.c (struct bcache): Move to bcache.h.
4694         (bcache::expand_hash_table): Rename from expand_hash_table.
4695         (bcache): Remove.
4696         (bcache::insert): Rename from bcache_full.
4697         (bcache::compare): Rename from bcache_compare.
4698         (bcache_xmalloc): Remove.
4699         (bcache::~bcache): Rename from bcache_xfree.
4700         (bcache::print_statistics): Rename from print_bcache_statistics.
4701         (bcache::memory_used): Rename from bcache_memory_used.
4702
4703 2019-03-07  Pedro Alves  <palves@redhat.com>
4704
4705         * infrun.c (normal_stop): Also check for
4706         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4707
4708 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4709
4710         * f-lang.c (value_from_host_double): Moved to...
4711         * value.c (value_from_host_double): ...here.
4712         * value.h (value_from_host_double): Declare.
4713         * guile/scm-math.c (vlscm_convert_typed_number): Use
4714         value_from_host_double.
4715         (vlscm_convert_number): Likewise.
4716         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4717         * python/py-value.c (convert_value_from_python): Likewise.
4718
4719 2019-03-06  Tom Tromey  <tom@tromey.com>
4720
4721         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4722
4723 2019-03-06  Tom Tromey  <tom@tromey.com>
4724
4725         * utils.h (free_current_contents): Don't declare.
4726         * utils.c (free_current_contents): Remove.
4727
4728 2019-03-06  Tom Tromey  <tom@tromey.com>
4729
4730         * top.c (quit_force): Update.
4731         * main.c (captured_command_loop): Update.
4732         * common/new-op.c (operator new): Update.
4733         * common/common-exceptions.c (struct catcher)
4734         <save_cleanup_chain>: Remove member.
4735         (exceptions_state_mc_init): Update.
4736         (exception_try_scope_entry): Return nullptr.
4737         (exception_try_scope_exit, exception_rethrow)
4738         (throw_exception_sjlj, throw_exception_cxx): Update.
4739         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4740         (all_cleanups, do_cleanups, discard_cleanups)
4741         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4742         (restore_cleanups, restore_final_cleanups): Don't declare.
4743         (do_final_cleanups): Remove parameter.
4744         * common/cleanups.c (cleanup_chain, make_cleanup)
4745         (make_cleanup_dtor, all_cleanups, do_cleanups)
4746         (discard_my_cleanups, discard_cleanups)
4747         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4748         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4749         (null_cleanup): Remove.
4750         (do_final_cleanups): Remove parameter.
4751
4752 2019-03-06  Tom Tromey  <tom@tromey.com>
4753
4754         * remote.c (remote_target::remote_parse_stop_reply): Use
4755         unique_xmalloc_ptr.
4756
4757 2019-03-06  Tom Tromey  <tom@tromey.com>
4758
4759         * stabsread.c (struct stabs_field_info): Rename from field_info.
4760         <list, fnlist>: Add initializers.
4761         <obstack>: New member.
4762         (read_member_functions, read_struct_fields, read_baseclasses):
4763         Allocate on obstack.  Don't use cleanups.
4764         (read_one_struct_field, read_member_functions, read_struct_fields)
4765         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4766         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4767         (read_struct_type): Update.
4768
4769 2019-03-06  Tom Tromey  <tom@tromey.com>
4770
4771         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4772         * common/filestuff.h (make_cleanup_close): Don't declare.
4773         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4774         Remove.
4775
4776 2019-03-06  Tom Tromey  <tom@tromey.com>
4777
4778         * solib-aix.c: Use make_scope_exit.
4779
4780 2019-03-06  Tom Tromey  <tom@tromey.com>
4781
4782         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4783         Use make_scope_exit.
4784
4785 2019-03-06  Tom Tromey  <tom@tromey.com>
4786
4787         * solib-svr4.c (disable_probes_interface): Remove parameter.
4788         (svr4_handle_solib_event): Use make_scope_exit.
4789
4790 2019-03-06  Tom Tromey  <tom@tromey.com>
4791
4792         * remote.c (struct stop_reply_deleter): Remove.
4793         (stop_reply_up): Update.
4794         (struct stop_reply): Derive from notif_event.  Don't typedef.
4795         <regcache>: Now a std::vector.
4796         (stop_reply_xfree): Remove.
4797         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4798         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4799         (remote_target::discard_pending_stop_replies): Use delete.
4800         (remote_target::remote_parse_stop_reply): Update.
4801         (remote_target::process_stop_reply): Update.
4802         * remote-notif.h (struct notif_event): Add virtual destructor.
4803         Remove "dtr" member.
4804         (struct notif_client) <alloc_event>: Return a unique_ptr.
4805         (notif_event_xfree): Don't declare.
4806         (notif_event_up): New typedef.
4807         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4808         (notif_event_xfree, do_notif_event_xfree): Remove.
4809         (remote_notif_state_xfree): Update.
4810
4811 2019-03-06  Tom Tromey  <tom@tromey.com>
4812
4813         * infrun.c (displaced_step_clear_cleanup): Now a
4814         forward_scope_exit type.
4815         (displaced_step_prepare_throw): Update.
4816         (displaced_step_fixup): Update.
4817
4818 2019-03-06  Tom Tromey  <tom@tromey.com>
4819
4820         * inferior.h (class inferior): Update comment.
4821         * gdbthread.h (class thread_info): Update comment.
4822
4823 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4824             Tom Tromey  <tom@tromey.com>
4825
4826         * stabsread.h (struct stab_section_list): Remove.
4827         (coffstab_build_psymtabs): Update.
4828         * dbxread.c (symbuf_sections): Now a std::vector.
4829         (sect_idx): New global.
4830         (fill_symbuf): Update.
4831         (coffstab_build_psymtabs): Change type of stabsects parameter.
4832         Update.
4833         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4834         std::vector.
4835         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4836         (coff_locate_sections): Update.
4837         (coff_symfile_read): Remove cleanups.  Update.
4838         (init_stringtab): Add storage parameter.
4839         (free_stringtab, free_stringtab_cleanup): Remove.
4840         (init_lineno): Add storage parameter.
4841         (free_linetab, free_linetab_cleanup): Remove.
4842
4843 2019-03-06  Pedro Alves  <palves@redhat.com>
4844
4845         * linux-fork.c (fork_info::clobber_regs): Delete.
4846         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4847         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4848         comment.  Adjust.
4849         (scoped_switch_fork_info::scoped_switch_fork_info)
4850         (checkpoint_command, linux_fork_context): Adjust
4851         fork_save_infrun_state calls.
4852
4853 2019-03-06  Pedro Alves  <palves@redhat.com>
4854
4855         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4856         (inf_has_multiple_threads): Return 'bool' and rewrite using
4857         inferior_info::threads().
4858
4859 2019-03-06  Pedro Alves  <palves@redhat.com>
4860
4861         * linux-fork.c: Include <list>.
4862         (fork_list): Now a std::list instance.
4863         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4864         (forks_exist_p, find_last_fork): Adjust.
4865         (new_fork): Delete.
4866         (one_fork_p): New.
4867         (add_fork): Adjust.
4868         (free_fork): Delete, folded into fork_info::~fork_info().
4869         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4870         Adjust.
4871         (init_fork_list): Delete.
4872         (linux_fork_killall, linux_fork_mourn_inferior)
4873         (linux_fork_detach, info_checkpoints_command): Adjust.
4874         (_initialize_linux_fork): No longer call init_fork_list.
4875
4876 2019-03-06  Pedro Alves  <palves@redhat.com>
4877
4878         * linux-fork.c (new_fork): New, split out of ...
4879         (add_fork): ... this.  Return void.  Move "first fork" special
4880         case from here, to ...
4881         (checkpoint_command): ... here.
4882         * linux-linux.h (add_fork): Return void.
4883
4884 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4887
4888 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4889             Chris January  <chris.january@arm.com>
4890             David Lecomber  <david.lecomber@arm.com>
4891
4892         * f-exp.y: New token, UNOP_INTRINSIC.
4893         (exp): New pattern using UNOP_INTRINSIC token.
4894         (f77_keywords): Add 'abs' keyword.
4895         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4896         (value_from_host_double): New function.
4897         (evaluate_subexp_f): Support UNOP_ABS.
4898
4899 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4900
4901         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4902         types.
4903
4904 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4905
4906         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4907         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4908         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4909
4910 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4913
4914 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4915             Chris January  <chris.january@arm.com>
4916
4917         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4918         * f-exp.y: Define 'KIND' token.
4919         (exp): New pattern for KIND expressions.
4920         (ptype): Handle types with a kind extension.
4921         (direct_abs_decl): Extend to spot kind extensions.
4922         (f77_keywords): Add 'kind' to the list.
4923         (push_kind_type): New function.
4924         (convert_to_kind_type): New function.
4925         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4926         * parse.c (operator_length_standard): Likewise.
4927         * parser-defs.h (enum type_pieces): Add tp_kind.
4928         * std-operator.def: Add UNOP_KIND.
4929
4930 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4931
4932         * f-exp.y (f_parse): Set yydebug.
4933
4934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * f-lang.c (evaluate_subexp_f): New function.
4937         (exp_descriptor_f): New global.
4938         (f_language_defn): Use exp_descriptor_f instead of
4939         exp_descriptor_standard.
4940
4941 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4942
4943         * f-exp.y (struct token): Add comments.
4944         (dot_ops): Remove uppercase versions and the end marker.
4945         (f77_keywords): Likewise.
4946         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4947         entries in the dot_ops array are case insensitive, and use
4948         strncasecmp to compare strings.  Also some whitespace cleanup in
4949         this area.  Similar for the f77_keywords array, except entries in
4950         this list might be case sensitive.
4951
4952 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4953
4954         * f-exp.y (struct f77_boolean_val): Add comments.
4955         (boolean_values): Remove uppercase versions, and end marker.
4956         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4957         and use strncasecmp to achieve case insensitivity.  Additionally,
4958         perform whitespace cleanup around this code.
4959
4960 2019-03-06  Tom Tromey  <tromey@adacore.com>
4961
4962         * remote-sim.c (gdbsim_target_open): Use result of
4963         gdb_argv::release.
4964
4965 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4966         Dirk Schubert  <dirk.schubert@arm.com>
4967         Chris January  <chris.january@arm.com>
4968
4969         * eval.c (evaluate_subexp_standard): Call Fortran argument
4970         wrapping logic.
4971         * f-lang.c (struct value): A value which can be passed into a
4972         Fortran function call.
4973         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4974         where appropriate.
4975         (struct type): Value ready for a Fortran function call.
4976         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4977         is needed.
4978         * f-lang.h (fortran_argument_convert): Declaration.
4979         (fortran_preserve_arg_pointer): Declaration.
4980         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4981
4982 2019-03-05  Tom Tromey  <tromey@adacore.com>
4983
4984         * python/py-prettyprint.c (print_string_repr): Remove #if.
4985         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4986
4987 2019-03-05  Tom Tromey  <tromey@adacore.com>
4988
4989         * target.c (the_dummy_target): Move later.  Change type to
4990         "dummy_target".
4991         (initialize_targets): Don't initialize the_dummy_target.
4992
4993 2019-03-05  Tom Tromey  <tromey@adacore.com>
4994
4995         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4996         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4997
4998 2019-03-05  Tom Tromey  <tromey@adacore.com>
4999
5000         * windows-nat.c (windows_nat_target::attach)
5001         (windows_nat_target::detach): Don't call gdb_flush.
5002         * valprint.c (generic_val_print, val_print, val_print_string):
5003         Don't call gdb_flush.
5004         * utils.c (defaulted_query): Don't call gdb_flush.
5005         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5006         * target.c (target_announce_detach): Don't call gdb_flush.
5007         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5008         * remote.c (extended_remote_target::attach): Don't call
5009         gdb_flush.
5010         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5011         * printcmd.c (do_examine): Don't call gdb_flush.
5012         (info_display_command): Don't call gdb_flush.
5013         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5014         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5015         * memattr.c (info_mem_command): Don't call gdb_flush.
5016         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5017         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5018         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5019         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5020         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5021         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5022         (gnu_nat_target::detach): Don't call gdb_flush.
5023         * f-valprint.c (f_val_print): Don't call gdb_flush.
5024         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5025         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5026         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5027         gdb_flush.
5028         * c-valprint.c (c_val_print): Don't call gdb_flush.
5029         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5030
5031 2019-03-05  Tom Tromey  <tromey@adacore.com>
5032
5033         * varobj.c (update_dynamic_varobj_children): Update.
5034         (install_default_visualizer): Use reset, not release.
5035         * value.c (set_internalvar): Update.
5036         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5037         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5038         ATTRIBUTE_UNUSED_RESULT.
5039
5040 2019-03-05  Tom Tromey  <tromey@adacore.com>
5041
5042         * remote.c (class scoped_remote_fd) <release>: Add
5043         ATTRIBUTE_UNUSED_RESULT.
5044
5045 2019-03-05  Tom Tromey  <tromey@adacore.com>
5046
5047         * macroexp.c (struct macro_buffer) <release>: Add
5048         ATTRIBUTE_UNUSED_RESULT.
5049
5050 2019-03-05  Tom Tromey  <tromey@adacore.com>
5051
5052         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5053         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5054         ATTRIBUTE_UNUSED_RESULT.
5055
5056 2019-03-05  Tom Tromey  <tromey@adacore.com>
5057
5058         * common/scoped_fd.h (class scoped_fd) <release>: Add
5059         ATTRIBUTE_UNUSED_RESULT.
5060
5061 2019-03-05  Tom Tromey  <tromey@adacore.com>
5062
5063         * parser-defs.h (struct parser_state) <release>: Add
5064         ATTRIBUTE_UNUSED_RESULT.
5065
5066 2019-03-05  Tom Tromey  <tromey@adacore.com>
5067
5068         * utils.h (class gdb_argv) <release>: Add
5069         ATTRIBUTE_UNUSED_RESULT.
5070         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5071
5072 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5073
5074         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5075         for-loop range, to avoid compiler warnings.
5076
5077         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5078         avoid compiler warnings about unused variables.
5079
5080         * NEWS: Mention end of support for native debugging on MS-Windows
5081         before XP.
5082
5083         PR gdb/24292
5084         * common/netstuff.c:
5085         * gdbserver/gdbreplay.c
5086         * gdbserver/remote-utils.c:
5087         * ser-tcp.c:
5088         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5089         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5090         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5091         'getaddrinfo' and 'freeaddrinfo' were not available before
5092         Windows XP, and mingw.org's MinGW headers by default define
5093         _WIN32_WINNT to 0x500.
5094
5095 2019-03-01  Gary Benson <gbenson@redhat.com>
5096
5097         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5098
5099 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5100             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5101
5102         PR gdb/8527
5103         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5104         set_sigint_trap, clear_sigint_trap.
5105
5106 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5107
5108         * target.c (target_detach): Clear the regcache and the
5109         frame cache.
5110
5111 2019-02-27  Pedro Alves  <palves@redhat.com>
5112
5113         * utils.c (set_screen_size): When we cap the height/width sizes,
5114         tweak the corresponding command variable to show "unlimited":
5115
5116 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5117             Pedro Alves  <palves@redhat.com>
5118
5119         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5120         before calling rl_set_screen_size.
5121
5122 2019-02-27  Tom Tromey  <tromey@adacore.com>
5123
5124         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5125         define.
5126         * python/py-value.c: Remove Python 2.4 workaround.
5127         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5128         workaround.
5129         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5130         Python 2.4 workaround.
5131         * python/python-internal.h: Remove Python 2.4 comment.
5132         (Py_ssize_t): Don't define.
5133         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5134         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5135         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5136         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5137         * python/python.c (do_start_initialization): Remove Python 2.4
5138         workaround.
5139         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5140         (print_children): Remove Python 2.4 workaround.
5141         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5142         workaround.
5143         (CHARBUFFERPROC_NAME): Remove.
5144         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5145         Python 2.4 workaround.
5146
5147 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5148
5149         * NEWS: Note minimum Python version.
5150
5151 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5152
5153         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5154         code from these functions.  Remove corresponding ifdefs.  Use
5155         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5156         Remove gotos and target of gotos.
5157         (infpy_search_memory): Likewise.
5158
5159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5160
5161         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5162         (hppa_gdbarch_init): Don't register deleted functions with
5163         gdbarch.
5164
5165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5168         (h8300_unwind_sp): Delete.
5169         (h8300_dummy_id): Delete.
5170         (h8300_gdbarch_init): Don't register deleted functions with
5171         gdbarch.
5172
5173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5174
5175         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5176         (ft32_unwind_pc): Delete.
5177         (ft32_unwind_sp): Delete.
5178         (ft32_gdbarch_init): Don't register deleted functions with
5179         gdbarch.
5180
5181 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5182
5183         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5184         (frv_unwind_pc): Delete.
5185         (frv_unwind_sp): Delete.
5186         (frv_gdbarch_init): Don't register deleted functions with
5187         gdbarch.
5188
5189 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5190
5191         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5192         (riscv_unwind_pc): Delete.
5193         (riscv_unwind_sp): Delete.
5194         (riscv_gdbarch_init): Don't register deleted functions with
5195         gdbarch.
5196
5197 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5198
5199         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5200         (csky_unwind_pc): Delete.
5201         (csky_unwind_sp): Delete.
5202         (csky_gdbarch_init): Don't register deleted functions with
5203         gdbarch.
5204
5205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5206
5207         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5208         (cris_unwind_pc): Delete.
5209         (cris_unwind_sp): Delete.
5210         (cris_gdbarch_init): Don't register deleted functions with
5211         gdbarch.
5212
5213 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5214
5215         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5216         (bfin_unwind_pc): Delete.
5217         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5218
5219 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5220
5221         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5222         (arm_unwind_pc): Delete.
5223         (arm_unwind_sp): Delete.
5224         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5225
5226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5227
5228         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5229         (arc_unwind_pc): Delete.
5230         (arc_unwind_sp): Delete.
5231         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5232
5233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5234
5235         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5236         (alpha_unwind_pc): Delete.
5237         (alpha_gdbarch_init): Don't register deleted functions with
5238         gdbarch.
5239
5240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5241
5242         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5243         (aarch64_unwind_pc): Delete.
5244         (aarch64_unwind_sp): Delete.
5245         (aarch64_gdbarch_init): Don't register deleted functions with
5246         gdbarch.
5247
5248 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5249
5250         * gdbtypes.c (type_align): Don't consider static members when
5251         computing structure alignment.
5252
5253 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5254
5255         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5256         return 0 for other types.
5257         * arch-utils.c (default_type_align): Always return 0.
5258         * gdbarch.h: Regenerate.
5259         * gdbarch.sh (type_align): Extend comment.
5260         * gdbtypes.c (type_align): Add additional comments, always call
5261         gdbarch_type_align before applying the default rules.
5262         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5263         generic code will then apply a suitable default.
5264         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5265         types, return 0 for other types.
5266
5267 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5268
5269         * NEWS: Create a new section for the next release branch.
5270         Rename the section of the current branch, now that it has
5271         been cut.
5272
5273 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5274
5275         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5276         * version.in: Bump version to 8.3.50.DATE-git.
5277
5278 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5279
5280         * aix-thread.c (ptid_cmp): Remove unused variable.
5281         (get_signaled_thread): Likewise.
5282         (store_regs_user_thread): Likewise.
5283         (store_regs_kernel_thread): Likewise.
5284         (fetch_regs_kernel_thread): Remove shadowed variable.
5285
5286 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5287
5288         * features/riscv/32bit-cpu.xml: Add register numbers.
5289         * features/riscv/32bit-fpu.c: Regenerate.
5290         * features/riscv/32bit-fpu.xml: Add register numbers.
5291         * features/riscv/64bit-cpu.xml: Add register numbers.
5292         * features/riscv/64bit-fpu.c: Regenerate.
5293         * features/riscv/64bit-fpu.xml: Add register numbers.
5294
5295 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5296
5297         * NEWS: Mention two argument form of gdb.Value constructor.
5298         * python/py-value.c (convert_buffer_and_type_to_value): New
5299         function.
5300         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5301         Add support for handling an optional second argument.  Call
5302         convert_buffer_and_type_to_value as appropriate.
5303         * python/python-internal.h (Py_buffer_deleter): New struct.
5304         (Py_buffer_up): New typedef.
5305
5306 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5307
5308         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5309         instead of releasing ownership.
5310
5311 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5312
5313         * dwarf2read.c (open_and_init_dwp_file): Call
5314         elf_numsections instead of bfd_count_sections to initialize
5315         dwp_file->num_sections.
5316
5317 2019-02-25  Tom Tromey  <tromey@adacore.com>
5318
5319         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5320
5321 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5322
5323         * gcore.in: Add '--readnever' option when invoking GDB.
5324
5325 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5326
5327         * MAINTAINERS: Update my email address.
5328
5329 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5330
5331         * build-id.c (build_id_to_debug_bfd_1): New function.
5332         (build_id_to_debug_bfd): Look for separate debug file in
5333         sysroot.
5334
5335 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5336
5337         * gdbarch.sh: Update the copyright year range that is placed into
5338         generated files.
5339
5340 2019-02-22  Keith Seitz  <keiths@redhat.com>
5341
5342         PR symtab/23853
5343         * linespec.c (create_sals_line_offset): Search for the default
5344         symtab's filename instead of its fullname.
5345
5346 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5347
5348         * NEWS: Update style defaults.
5349
5350 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5351
5352         * main.c (captured_main_1): Disable styling in batch mode.
5353
5354 2019-02-20  Tom Tromey  <tom@tromey.com>
5355
5356         * symtab.c (symtab_symbol_info): Fix typos.
5357
5358 2019-02-20  Tom Tromey  <tromey@adacore.com>
5359
5360         * findcmd.c (_initialize_mem_search): Use upper case for
5361         metasyntactic variables.
5362
5363 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5364
5365         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5366         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5367
5368 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5369
5370         * top.h (source_file_name): Change to std::string.
5371         * top.c (source_file_name): Likewise.
5372         (command_line_input): Adjust.
5373         * cli/cli-script.c (script_from_file): Adjust.
5374
5375 2019-02-19  Tom Tromey  <tromey@adacore.com>
5376
5377         * ravenscar-thread.c
5378         (ravenscar_thread_target::update_thread_list): Don't call
5379         ada_build_task_list.
5380         * ada-lang.h (ada_build_task_list): Don't declare.
5381         * ada-tasks.c (struct ada_tasks_inferior_data)
5382         <task_list_valid_p>: Now bool.
5383         (read_known_tasks, ada_task_list_changed)
5384         (ada_tasks_invalidate_inferior_data): Update.
5385         (read_known_tasks_array): Return bool.
5386         (read_known_tasks_list): Likewise.
5387         (read_known_tasks): Return void.
5388         (ada_build_task_list): Now static.
5389
5390 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5391
5392         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5393         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5394
5395 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5396
5397         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5398         variant for ada_tasks_pspace_data_handle and
5399         ada_tasks_inferior_data_handle.
5400         (ada_tasks_pspace_data_cleanup): New function.
5401         (ada_tasks_inferior_data_cleanup): New function.
5402
5403 2019-02-17  Tom Tromey  <tom@tromey.com>
5404
5405         * macrotab.h (macro_source_fullname): Return a std::string.
5406         * macrotab.c (macro_include, check_for_redefinition)
5407         (macro_undef, macro_lookup_definition, foreach_macro)
5408         (foreach_macro_in_scope): Update.
5409         (macro_source_fullname): Return a std::string.
5410         * macrocmd.c (show_pp_source_pos): Update.
5411
5412 2019-02-17  Tom Tromey  <tom@tromey.com>
5413
5414         * macrocmd.c (show_pp_source_pos): Style the file names.
5415
5416 2019-02-17  Tom Tromey  <tom@tromey.com>
5417
5418         PR tui/24197:
5419         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5420
5421 2019-02-17  Tom Tromey  <tom@tromey.com>
5422
5423         * ada-lang.c (user_select_syms): Use filtered printing.
5424         * utils.c (wrap_style): New global.
5425         (desired_style): Remove.
5426         (emit_style_escape): Add stream parameter.
5427         (set_output_style, reset_terminal_style, prompt_for_continue):
5428         Update.
5429         (flush_wrap_buffer): Only flush gdb_stdout.
5430         (wrap_here): Set wrap_style.
5431         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5432         treat escape sequences as a character.  Change when wrap buffer is
5433         flushed.
5434         (fputs_styled): Do not set the output style when the default is
5435         requested.
5436         * ui-style.h (struct ui_file_style) <is_default>: New method.
5437         * source.c (print_source_lines_base): Emit escape sequences in one
5438         piece.
5439
5440 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5441
5442         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5443         integers and enumeration types.
5444
5445 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5446
5447         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5448         instead of lookup_symbol_in_language
5449         (do_exact_match): New function.
5450         (ada_get_symbol_name_matcher): Return do_exact_match when
5451         doing a verbatim match.
5452
5453 2019-02-15  Tom Tromey  <tromey@adacore.com>
5454
5455         * ravenscar-thread.c (ravenscar_thread_target::resume)
5456         (ravenscar_thread_target::wait): Special case wildcard requests.
5457
5458 2019-02-15  Tom Tromey  <tromey@adacore.com>
5459
5460         * ravenscar-thread.c (base_ptid): Remove.
5461         (struct ravenscar_thread_target) <close>: New method.
5462         <m_base_ptid>: New member.
5463         <update_inferior_ptid, active_task, task_is_currently_active,
5464         runtime_initialized>: Declare methods.
5465         <ravenscar_thread_target>: Add constructor.
5466         (ravenscar_thread_target::task_is_currently_active)
5467         (ravenscar_thread_target::update_inferior_ptid)
5468         (ravenscar_runtime_initialized): Rename.  Now methods.
5469         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5470         (ravenscar_thread_target::update_thread_list): Update.
5471         (ravenscar_thread_target::active_task): Now method.
5472         (ravenscar_thread_target::store_registers)
5473         (ravenscar_thread_target::prepare_to_store)
5474         (ravenscar_thread_target::prepare_to_store)
5475         (ravenscar_thread_target::mourn_inferior): Update.
5476         (ravenscar_inferior_created): Use "new" to create target.
5477         (ravenscar_thread_target::get_ada_task_ptid): Update.
5478         (_initialize_ravenscar): Don't initialize base_ptid.
5479         (ravenscar_ops): Remove global.
5480
5481 2019-02-15  Tom Tromey  <tromey@adacore.com>
5482
5483         * target.h (push_target): Declare new overload.
5484         * target.c (push_target): New overload, taking an rvalue reference.
5485         * remote.c (remote_target::open_1): Use push_target overload.
5486         * corelow.c (core_target_open): Use push_target overload.
5487
5488 2019-02-15  Tom Tromey  <tromey@adacore.com>
5489
5490         * ravenscar-thread.c (is_ravenscar_task)
5491         (ravenscar_task_is_currently_active): Return bool.
5492         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5493         (_initialize_ravenscar): Remove "(void)".
5494         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5495         Return bool.
5496
5497 2019-02-15  Tom Tromey  <tromey@adacore.com>
5498
5499         * ravenscar-thread.c (ravenscar_runtime_initializer)
5500         (has_ravenscar_runtime, get_running_thread_id)
5501         (ravenscar_thread_target::resume): Fix indentation.
5502
5503 2019-02-15  Tom Tromey  <tromey@adacore.com>
5504
5505         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5506         from ravenscar_arch_ops.
5507         (sparc_ravenscar_ops::fetch_registers)
5508         (sparc_ravenscar_ops::store_registers): Now methods.
5509         (sparc_ravenscar_prepare_to_store): Remove.
5510         (sparc_ravenscar_ops): Redefine.
5511         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5512         methods and destructor.  Remove members.
5513         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5514         (ravenscar_thread_target::store_registers)
5515         (ravenscar_thread_target::prepare_to_store): Update.
5516         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5517         Remove.
5518         (struct ppc_ravenscar_powerpc_ops): Derive from
5519         ravenscar_arch_ops.
5520         (ppc_ravenscar_powerpc_ops::fetch_registers)
5521         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5522         (ppc_ravenscar_powerpc_ops): Redefine.
5523         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5524         (ppc_ravenscar_e500_ops::fetch_registers)
5525         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5526         (ppc_ravenscar_e500_ops): Redefine.
5527         * aarch64-ravenscar-thread.c
5528         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5529         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5530         (aarch64_ravenscar_fetch_registers)
5531         (aarch64_ravenscar_store_registers): Now methods.
5532         (aarch64_ravenscar_ops): Redefine.
5533
5534 2019-02-15  Tom Tromey  <tromey@adacore.com>
5535
5536         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5537         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5538         (ravenscar_thread_target::stopped_by_watchpoint)
5539         (ravenscar_thread_target::stopped_data_address)
5540         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5541
5542 2019-02-15  Tom Tromey  <tromey@adacore.com>
5543
5544         * ravenscar-thread.c: Fix some typos.
5545
5546 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5547             Tom Tromey  <tromey@adacore.com>
5548
5549         * ada-lang.c (ada_exception_sal): Change addr_string to a
5550         std::string.
5551         (create_ada_exception_catchpoint): Update.
5552
5553 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5554             Tom Tromey  <tromey@adacore.com>
5555
5556         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5557         (bp_location_ops): Remove.
5558         (base_breakpoint_allocate_location): Update.
5559         (free_bp_location): Update.
5560         * ada-lang.c (class ada_catchpoint_location)
5561         <ada_catchpoint_location>: Remove ops parameter.
5562         (ada_catchpoint_location_dtor): Remove.
5563         (ada_catchpoint_location_ops): Remove.
5564         (allocate_location_exception): Update.
5565         * breakpoint.h (struct bp_location_ops): Remove.
5566         (class bp_location) <bp_location>: Remove bp_location_ops
5567         parameter.
5568         <~bp_location>: Add destructor.
5569         <ops>: Remove.
5570
5571 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5572             Pedro Alves  <palves@redhat.com>
5573
5574         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5575         'PATH_MAX'.
5576
5577 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5578             Samuel Thibault  <samuel.thibault@gnu.org>
5579             Thomas Schwinge  <thomas@codesourcery.com>
5580
5581         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5582         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5583
5584 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5585
5586         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5587         (check_empty): Use "const char *".
5588
5589         * gnu-nat.c (gnu_nat_target::detach): Instead of
5590         'detach_inferior (pid)' call
5591         'detach_inferior (find_inferior_pid (pid))'.
5592
5593         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5594         'nat/fork-inferior.o'.
5595         * gnu-nat.c: #include "nat/fork-inferior.h".
5596
5597         * gnu-nat.c (gnu_nat_target::detach): Instead of
5598         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5599         * gnu-nat.h: #include "inf-child.h".
5600         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5601         'i386_gnu_nat_target::fetch_registers'.
5602         (gnu_store_registers): Rename/move to
5603         'i386_gnu_nat_target::store_registers'.
5604
5605         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5606         * gnu-nat.h (mach_thread_info): New function.
5607         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5608
5609         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5610
5611 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5612
5613         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5614
5615 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5616
5617         * windows-nat.c (windows_add_thread): Add new parameter
5618         "main_thread_p" with default value set to false.  Update
5619         function documentation as well as all callers.
5620         (windows_delete_thread): Likewise.
5621         (fake_create_process): Update call to windows_add_thread.
5622         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5623         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5624         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5625         call to windows_delete_thread.
5626
5627 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5628
5629         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5630
5631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5632
5633         * symfile.c (find_separate_debug_file): Use canonical path of
5634         sysroot with child_path instead of gdb_sysroot if it is valid.
5635
5636 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5637
5638         * symfile.c (find_separate_debug_file): Use child_path to
5639         determine if an object file is under a sysroot.
5640
5641 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5642
5643         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5644         unittests/child-path-selftests.c.
5645         * common/pathstuff.c (child_path): New function.
5646         * common/pathstuff.h (child_path): New prototype.
5647         * unittests/child-path-selftests.c: New file.
5648
5649 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5650
5651         * symfile.c (find_separate_debug_file): Look for separate debug
5652         files in debug directories under the sysroot.
5653
5654 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5655
5656         * symtab.h (struct minimal_symbol data_p): New const method.
5657         (struct minimal_symbol text_p): Likewise.
5658         * symtab.c (output_source_filename): Use file name style
5659         to print file name.
5660         (print_symbol_info): Likewise.
5661         (print_msymbol_info): Use address style to print addresses.
5662         Use function name style to print executable text symbols.
5663         (expand_symtab_containing_pc): Use data_p.
5664         (find_pc_sect_compunit_symtab): Likewise.
5665
5666 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5667
5668         * breakpoint.c (describe_other_breakpoints): Use address style
5669         to print addresses.
5670         (say_where): Likewise.
5671
5672 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5673
5674         * ada-typeprint.c (print_func_type): Print function name
5675         style to print function name.
5676         * c-typeprint.c (c_print_type_1): Likewise.
5677
5678 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5679
5680         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5681         for execve.
5682
5683 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5684
5685         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5686         type_stack.
5687
5688 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5689
5690         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5691         TYPE_CODE_REF types.
5692
5693 2019-02-08  Jim Wilson  <jimw@sifive.com>
5694
5695         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5696         (riscv_linux_fregset): New.
5697         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5698
5699 2019-02-07  Tom Tromey  <tom@tromey.com>
5700
5701         * thread.c (thread_cancel_execution_command): Update.
5702         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5703         methods.
5704         (struct thread_fsm_ops): Remove.
5705         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5706         (thread_fsm_should_stop, thread_fsm_return_value)
5707         (thread_fsm_set_finished, thread_fsm_finished_p)
5708         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5709         Don't declare.
5710         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5711         * infrun.c (clear_proceed_status_thread)
5712         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5713         (print_stop_event): Update.
5714         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5715         Add constructor.
5716         (step_command_fsm_ops): Remove.
5717         (new_step_command_fsm): Remove.
5718         (step_1): Update.
5719         (step_command_fsm::should_stop): Rename from
5720         step_command_fsm_should_stop.
5721         (step_command_fsm::clean_up): Rename from
5722         step_command_fsm_clean_up.
5723         (step_command_fsm::do_async_reply_reason): Rename from
5724         step_command_fsm_async_reply_reason.
5725         (struct until_next_fsm): Inherit from thread_fsm.  Add
5726         constructor.
5727         (until_next_fsm_ops): Remove.
5728         (new_until_next_fsm): Remove.
5729         (until_next_fsm::should_stop): Rename from
5730         until_next_fsm_should_stop.
5731         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5732         (until_next_fsm::do_async_reply_reason): Rename from
5733         until_next_fsm_async_reply_reason.
5734         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5735         constructor.  Change type of breakpoint.
5736         (finish_command_fsm_ops): Remove.
5737         (new_finish_command_fsm): Remove.
5738         (finish_command_fsm::should_stop): Rename from
5739         finish_command_fsm_should_stop.
5740         (finish_command_fsm::clean_up): Rename from
5741         finish_command_fsm_clean_up.
5742         (finish_command_fsm::return_value): Rename from
5743         finish_command_fsm_return_value.
5744         (finish_command_fsm::do_async_reply_reason): Rename from
5745         finish_command_fsm_async_reply_reason.
5746         (finish_command): Update.
5747         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5748         Add constructor.
5749         (call_thread_fsm_ops): Remove.
5750         (call_thread_fsm::call_thread_fsm): Rename from
5751         new_call_thread_fsm.
5752         (call_thread_fsm::should_stop): Rename from
5753         call_thread_fsm_should_stop.
5754         (call_thread_fsm::should_notify_stop): Rename from
5755         call_thread_fsm_should_notify_stop.
5756         (run_inferior_call, call_function_by_hand_dummy): Update.
5757         * cli/cli-interp.c (should_print_stop_to_console): Update.
5758         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5759         Add constructor.  Change type of location_breakpoint,
5760         caller_breakpoint.
5761         (until_break_fsm_ops): Remove.
5762         (new_until_break_fsm): Remove.
5763         (until_break_fsm::should_stop): Rename from
5764         until_break_fsm_should_stop.
5765         (until_break_fsm::clean_up): Rename from
5766         until_break_fsm_clean_up.
5767         (until_break_fsm::do_async_reply_reason): Rename from
5768         until_break_fsm_async_reply_reason.
5769         (until_break_command): Update.
5770         * thread-fsm.c: Remove.
5771         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5772
5773 2019-02-07  Tom Tromey  <tom@tromey.com>
5774
5775         * yy-remap.h: Add include guard.
5776         * xtensa-tdep.h: Add include guard.
5777         * xcoffread.h: Rename include guard.
5778         * varobj-iter.h: Add include guard.
5779         * tui/tui.h: Rename include guard.
5780         * tui/tui-winsource.h: Rename include guard.
5781         * tui/tui-wingeneral.h: Rename include guard.
5782         * tui/tui-windata.h: Rename include guard.
5783         * tui/tui-win.h: Rename include guard.
5784         * tui/tui-stack.h: Rename include guard.
5785         * tui/tui-source.h: Rename include guard.
5786         * tui/tui-regs.h: Rename include guard.
5787         * tui/tui-out.h: Rename include guard.
5788         * tui/tui-layout.h: Rename include guard.
5789         * tui/tui-io.h: Rename include guard.
5790         * tui/tui-hooks.h: Rename include guard.
5791         * tui/tui-file.h: Rename include guard.
5792         * tui/tui-disasm.h: Rename include guard.
5793         * tui/tui-data.h: Rename include guard.
5794         * tui/tui-command.h: Rename include guard.
5795         * tic6x-tdep.h: Add include guard.
5796         * target/waitstatus.h: Rename include guard.
5797         * target/wait.h: Rename include guard.
5798         * target/target.h: Rename include guard.
5799         * target/resume.h: Rename include guard.
5800         * target-float.h: Rename include guard.
5801         * stabsread.h: Add include guard.
5802         * rs6000-tdep.h: Add include guard.
5803         * riscv-fbsd-tdep.h: Add include guard.
5804         * regformats/regdef.h: Rename include guard.
5805         * record.h: Rename include guard.
5806         * python/python.h: Rename include guard.
5807         * python/python-internal.h: Rename include guard.
5808         * python/py-stopevent.h: Rename include guard.
5809         * python/py-ref.h: Rename include guard.
5810         * python/py-record.h: Rename include guard.
5811         * python/py-record-full.h: Rename include guard.
5812         * python/py-record-btrace.h: Rename include guard.
5813         * python/py-instruction.h: Rename include guard.
5814         * python/py-events.h: Rename include guard.
5815         * python/py-event.h: Rename include guard.
5816         * procfs.h: Add include guard.
5817         * proc-utils.h: Add include guard.
5818         * p-lang.h: Add include guard.
5819         * or1k-tdep.h: Rename include guard.
5820         * observable.h: Rename include guard.
5821         * nto-tdep.h: Rename include guard.
5822         * nat/x86-linux.h: Rename include guard.
5823         * nat/x86-linux-dregs.h: Rename include guard.
5824         * nat/x86-gcc-cpuid.h: Add include guard.
5825         * nat/x86-dregs.h: Rename include guard.
5826         * nat/x86-cpuid.h: Rename include guard.
5827         * nat/ppc-linux.h: Rename include guard.
5828         * nat/mips-linux-watch.h: Rename include guard.
5829         * nat/linux-waitpid.h: Rename include guard.
5830         * nat/linux-ptrace.h: Rename include guard.
5831         * nat/linux-procfs.h: Rename include guard.
5832         * nat/linux-osdata.h: Rename include guard.
5833         * nat/linux-nat.h: Rename include guard.
5834         * nat/linux-namespaces.h: Rename include guard.
5835         * nat/linux-btrace.h: Rename include guard.
5836         * nat/glibc_thread_db.h: Rename include guard.
5837         * nat/gdb_thread_db.h: Rename include guard.
5838         * nat/gdb_ptrace.h: Rename include guard.
5839         * nat/fork-inferior.h: Rename include guard.
5840         * nat/amd64-linux-siginfo.h: Rename include guard.
5841         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5842         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5843         * nat/aarch64-linux.h: Rename include guard.
5844         * nat/aarch64-linux-hw-point.h: Rename include guard.
5845         * mn10300-tdep.h: Add include guard.
5846         * mips-linux-tdep.h: Add include guard.
5847         * mi/mi-parse.h: Rename include guard.
5848         * mi/mi-out.h: Rename include guard.
5849         * mi/mi-main.h: Rename include guard.
5850         * mi/mi-interp.h: Rename include guard.
5851         * mi/mi-getopt.h: Rename include guard.
5852         * mi/mi-console.h: Rename include guard.
5853         * mi/mi-common.h: Rename include guard.
5854         * mi/mi-cmds.h: Rename include guard.
5855         * mi/mi-cmd-break.h: Rename include guard.
5856         * m2-lang.h: Add include guard.
5857         * location.h: Rename include guard.
5858         * linux-record.h: Rename include guard.
5859         * linux-nat.h: Add include guard.
5860         * linux-fork.h: Add include guard.
5861         * i386-darwin-tdep.h: Rename include guard.
5862         * hppa-linux-offsets.h: Add include guard.
5863         * guile/guile.h: Rename include guard.
5864         * guile/guile-internal.h: Rename include guard.
5865         * gnu-nat.h: Rename include guard.
5866         * gdb-stabs.h: Rename include guard.
5867         * frv-tdep.h: Add include guard.
5868         * f-lang.h: Add include guard.
5869         * event-loop.h: Add include guard.
5870         * darwin-nat.h: Rename include guard.
5871         * cp-abi.h: Rename include guard.
5872         * config/sparc/nm-sol2.h: Rename include guard.
5873         * config/nm-nto.h: Rename include guard.
5874         * config/nm-linux.h: Add include guard.
5875         * config/i386/nm-i386gnu.h: Rename include guard.
5876         * config/djgpp/nl_types.h: Rename include guard.
5877         * config/djgpp/langinfo.h: Rename include guard.
5878         * compile/gcc-cp-plugin.h: Add include guard.
5879         * compile/gcc-c-plugin.h: Add include guard.
5880         * compile/compile.h: Rename include guard.
5881         * compile/compile-object-run.h: Rename include guard.
5882         * compile/compile-object-load.h: Rename include guard.
5883         * compile/compile-internal.h: Rename include guard.
5884         * compile/compile-cplus.h: Rename include guard.
5885         * compile/compile-c.h: Rename include guard.
5886         * common/xml-utils.h: Rename include guard.
5887         * common/x86-xstate.h: Rename include guard.
5888         * common/version.h: Rename include guard.
5889         * common/vec.h: Rename include guard.
5890         * common/tdesc.h: Rename include guard.
5891         * common/selftest.h: Rename include guard.
5892         * common/scoped_restore.h: Rename include guard.
5893         * common/scoped_mmap.h: Rename include guard.
5894         * common/scoped_fd.h: Rename include guard.
5895         * common/safe-iterator.h: Rename include guard.
5896         * common/run-time-clock.h: Rename include guard.
5897         * common/refcounted-object.h: Rename include guard.
5898         * common/queue.h: Rename include guard.
5899         * common/ptid.h: Rename include guard.
5900         * common/print-utils.h: Rename include guard.
5901         * common/preprocessor.h: Rename include guard.
5902         * common/pathstuff.h: Rename include guard.
5903         * common/observable.h: Rename include guard.
5904         * common/netstuff.h: Rename include guard.
5905         * common/job-control.h: Rename include guard.
5906         * common/host-defs.h: Rename include guard.
5907         * common/gdb_wait.h: Rename include guard.
5908         * common/gdb_vecs.h: Rename include guard.
5909         * common/gdb_unlinker.h: Rename include guard.
5910         * common/gdb_unique_ptr.h: Rename include guard.
5911         * common/gdb_tilde_expand.h: Rename include guard.
5912         * common/gdb_sys_time.h: Rename include guard.
5913         * common/gdb_string_view.h: Rename include guard.
5914         * common/gdb_splay_tree.h: Rename include guard.
5915         * common/gdb_setjmp.h: Rename include guard.
5916         * common/gdb_ref_ptr.h: Rename include guard.
5917         * common/gdb_optional.h: Rename include guard.
5918         * common/gdb_locale.h: Rename include guard.
5919         * common/gdb_assert.h: Rename include guard.
5920         * common/filtered-iterator.h: Rename include guard.
5921         * common/filestuff.h: Rename include guard.
5922         * common/fileio.h: Rename include guard.
5923         * common/environ.h: Rename include guard.
5924         * common/common-utils.h: Rename include guard.
5925         * common/common-types.h: Rename include guard.
5926         * common/common-regcache.h: Rename include guard.
5927         * common/common-inferior.h: Rename include guard.
5928         * common/common-gdbthread.h: Rename include guard.
5929         * common/common-exceptions.h: Rename include guard.
5930         * common/common-defs.h: Rename include guard.
5931         * common/common-debug.h: Rename include guard.
5932         * common/cleanups.h: Rename include guard.
5933         * common/buffer.h: Rename include guard.
5934         * common/btrace-common.h: Rename include guard.
5935         * common/break-common.h: Rename include guard.
5936         * cli/cli-utils.h: Rename include guard.
5937         * cli/cli-style.h: Rename include guard.
5938         * cli/cli-setshow.h: Rename include guard.
5939         * cli/cli-script.h: Rename include guard.
5940         * cli/cli-interp.h: Rename include guard.
5941         * cli/cli-decode.h: Rename include guard.
5942         * cli/cli-cmds.h: Rename include guard.
5943         * charset-list.h: Add include guard.
5944         * buildsym-legacy.h: Rename include guard.
5945         * bfin-tdep.h: Add include guard.
5946         * ax.h: Rename include guard.
5947         * arm-linux-tdep.h: Add include guard.
5948         * arm-fbsd-tdep.h: Add include guard.
5949         * arch/xtensa.h: Rename include guard.
5950         * arch/tic6x.h: Add include guard.
5951         * arch/i386.h: Add include guard.
5952         * arch/arm.h: Rename include guard.
5953         * arch/arm-linux.h: Rename include guard.
5954         * arch/arm-get-next-pcs.h: Rename include guard.
5955         * arch/amd64.h: Add include guard.
5956         * arch/aarch64-insn.h: Rename include guard.
5957         * arch-utils.h: Rename include guard.
5958         * annotate.h: Add include guard.
5959         * amd64-darwin-tdep.h: Rename include guard.
5960         * aarch64-linux-tdep.h: Add include guard.
5961         * aarch64-fbsd-tdep.h: Add include guard.
5962         * aarch32-linux-nat.h: Add include guard.
5963
5964 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5965
5966         * macrotab.c (macro_define_internal): New function that
5967         factorizes macro_define_object_internal and macro_define_function
5968         code.
5969         (macro_define_object_internal): Use macro_define_internal.
5970         (macro_define_function): Likewise.
5971
5972 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5973
5974         * macrocmd.c (extract_identifier): Return
5975         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5976         callers.
5977
5978 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5979
5980         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5981
5982 2019-02-05  Tom Tromey  <tom@tromey.com>
5983
5984         * target.c (target_stack::unpush): Move assertion earlier.
5985
5986 2019-01-30  Tom Tromey  <tom@tromey.com>
5987
5988         PR python/23615:
5989         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5990         (gdbpy_parse_and_eval): Likewise.
5991         * python/python-internal.h (gdbpy_allow_threads): New class.
5992
5993 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5994
5995         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5996         (aarch64_fbsd_fpregmap): Move earlier.
5997         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5998         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5999         instead of individual calls to trad_frame_set_reg_addr.
6000         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6001         earlier.
6002         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6003         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6004         instead of individual calls to trad_frame_set_reg_addr.
6005
6006 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6007
6008         * CONTRIBUTE: Replace contribution list with wiki link.
6009
6010 2019-01-25  Tom Tromey  <tom@tromey.com>
6011
6012         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6013
6014 2019-01-25  Tom Tromey  <tom@tromey.com>
6015
6016         * xtensa-linux-nat.c: Fix common/ includes.
6017         * xml-support.h: Fix common/ includes.
6018         * xml-support.c: Fix common/ includes.
6019         * x86-linux-nat.c: Fix common/ includes.
6020         * windows-nat.c: Fix common/ includes.
6021         * varobj.h: Fix common/ includes.
6022         * varobj.c: Fix common/ includes.
6023         * value.c: Fix common/ includes.
6024         * valops.c: Fix common/ includes.
6025         * utils.c: Fix common/ includes.
6026         * unittests/xml-utils-selftests.c: Fix common/ includes.
6027         * unittests/utils-selftests.c: Fix common/ includes.
6028         * unittests/unpack-selftests.c: Fix common/ includes.
6029         * unittests/tracepoint-selftests.c: Fix common/ includes.
6030         * unittests/style-selftests.c: Fix common/ includes.
6031         * unittests/string_view-selftests.c: Fix common/ includes.
6032         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6033         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6034         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6035         * unittests/rsp-low-selftests.c: Fix common/ includes.
6036         * unittests/parse-connection-spec-selftests.c: Fix common/
6037         includes.
6038         * unittests/optional-selftests.c: Fix common/ includes.
6039         * unittests/offset-type-selftests.c: Fix common/ includes.
6040         * unittests/observable-selftests.c: Fix common/ includes.
6041         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6042         * unittests/memrange-selftests.c: Fix common/ includes.
6043         * unittests/memory-map-selftests.c: Fix common/ includes.
6044         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6045         * unittests/function-view-selftests.c: Fix common/ includes.
6046         * unittests/environ-selftests.c: Fix common/ includes.
6047         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6048         * unittests/common-utils-selftests.c: Fix common/ includes.
6049         * unittests/cli-utils-selftests.c: Fix common/ includes.
6050         * unittests/array-view-selftests.c: Fix common/ includes.
6051         * ui-file.c: Fix common/ includes.
6052         * tui/tui-io.c: Fix common/ includes.
6053         * tracepoint.h: Fix common/ includes.
6054         * tracepoint.c: Fix common/ includes.
6055         * tracefile-tfile.c: Fix common/ includes.
6056         * top.h: Fix common/ includes.
6057         * top.c: Fix common/ includes.
6058         * thread.c: Fix common/ includes.
6059         * target/waitstatus.h: Fix common/ includes.
6060         * target/waitstatus.c: Fix common/ includes.
6061         * target.h: Fix common/ includes.
6062         * target.c: Fix common/ includes.
6063         * target-memory.c: Fix common/ includes.
6064         * target-descriptions.c: Fix common/ includes.
6065         * symtab.h: Fix common/ includes.
6066         * symfile.c: Fix common/ includes.
6067         * stap-probe.c: Fix common/ includes.
6068         * spu-linux-nat.c: Fix common/ includes.
6069         * sparc-nat.c: Fix common/ includes.
6070         * source.c: Fix common/ includes.
6071         * solib.c: Fix common/ includes.
6072         * solib-target.c: Fix common/ includes.
6073         * ser-unix.c: Fix common/ includes.
6074         * ser-tcp.c: Fix common/ includes.
6075         * ser-pipe.c: Fix common/ includes.
6076         * ser-base.c: Fix common/ includes.
6077         * selftest-arch.c: Fix common/ includes.
6078         * s12z-tdep.c: Fix common/ includes.
6079         * rust-exp.y: Fix common/ includes.
6080         * rs6000-aix-tdep.c: Fix common/ includes.
6081         * riscv-tdep.c: Fix common/ includes.
6082         * remote.c: Fix common/ includes.
6083         * remote-notif.h: Fix common/ includes.
6084         * remote-fileio.h: Fix common/ includes.
6085         * remote-fileio.c: Fix common/ includes.
6086         * regcache.h: Fix common/ includes.
6087         * regcache.c: Fix common/ includes.
6088         * record-btrace.c: Fix common/ includes.
6089         * python/python.c: Fix common/ includes.
6090         * python/py-type.c: Fix common/ includes.
6091         * python/py-inferior.c: Fix common/ includes.
6092         * progspace.h: Fix common/ includes.
6093         * producer.c: Fix common/ includes.
6094         * procfs.c: Fix common/ includes.
6095         * proc-api.c: Fix common/ includes.
6096         * printcmd.c: Fix common/ includes.
6097         * ppc-linux-nat.c: Fix common/ includes.
6098         * parser-defs.h: Fix common/ includes.
6099         * osdata.c: Fix common/ includes.
6100         * obsd-nat.c: Fix common/ includes.
6101         * nat/x86-linux.c: Fix common/ includes.
6102         * nat/x86-linux-dregs.c: Fix common/ includes.
6103         * nat/x86-dregs.h: Fix common/ includes.
6104         * nat/x86-dregs.c: Fix common/ includes.
6105         * nat/ppc-linux.c: Fix common/ includes.
6106         * nat/mips-linux-watch.h: Fix common/ includes.
6107         * nat/mips-linux-watch.c: Fix common/ includes.
6108         * nat/linux-waitpid.c: Fix common/ includes.
6109         * nat/linux-ptrace.h: Fix common/ includes.
6110         * nat/linux-ptrace.c: Fix common/ includes.
6111         * nat/linux-procfs.c: Fix common/ includes.
6112         * nat/linux-personality.c: Fix common/ includes.
6113         * nat/linux-osdata.c: Fix common/ includes.
6114         * nat/linux-namespaces.c: Fix common/ includes.
6115         * nat/linux-btrace.h: Fix common/ includes.
6116         * nat/linux-btrace.c: Fix common/ includes.
6117         * nat/fork-inferior.c: Fix common/ includes.
6118         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6119         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6120         * nat/aarch64-linux.c: Fix common/ includes.
6121         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6122         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6123         * namespace.h: Fix common/ includes.
6124         * mips-linux-tdep.c: Fix common/ includes.
6125         * minsyms.c: Fix common/ includes.
6126         * mi/mi-parse.h: Fix common/ includes.
6127         * mi/mi-main.c: Fix common/ includes.
6128         * mi/mi-cmd-env.c: Fix common/ includes.
6129         * memrange.h: Fix common/ includes.
6130         * memattr.c: Fix common/ includes.
6131         * maint.h: Fix common/ includes.
6132         * maint.c: Fix common/ includes.
6133         * main.c: Fix common/ includes.
6134         * machoread.c: Fix common/ includes.
6135         * location.c: Fix common/ includes.
6136         * linux-thread-db.c: Fix common/ includes.
6137         * linux-nat.c: Fix common/ includes.
6138         * linux-fork.c: Fix common/ includes.
6139         * inline-frame.c: Fix common/ includes.
6140         * infrun.c: Fix common/ includes.
6141         * inflow.c: Fix common/ includes.
6142         * inferior.h: Fix common/ includes.
6143         * inferior.c: Fix common/ includes.
6144         * infcmd.c: Fix common/ includes.
6145         * inf-ptrace.c: Fix common/ includes.
6146         * inf-child.c: Fix common/ includes.
6147         * ia64-linux-nat.c: Fix common/ includes.
6148         * i387-tdep.c: Fix common/ includes.
6149         * i386-tdep.c: Fix common/ includes.
6150         * i386-linux-tdep.c: Fix common/ includes.
6151         * i386-linux-nat.c: Fix common/ includes.
6152         * i386-go32-tdep.c: Fix common/ includes.
6153         * i386-fbsd-tdep.c: Fix common/ includes.
6154         * i386-fbsd-nat.c: Fix common/ includes.
6155         * guile/scm-type.c: Fix common/ includes.
6156         * guile/guile.c: Fix common/ includes.
6157         * go32-nat.c: Fix common/ includes.
6158         * gnu-nat.c: Fix common/ includes.
6159         * gdbthread.h: Fix common/ includes.
6160         * gdbarch-selftests.c: Fix common/ includes.
6161         * gdb_usleep.c: Fix common/ includes.
6162         * gdb_select.h: Fix common/ includes.
6163         * gdb_bfd.c: Fix common/ includes.
6164         * gcore.c: Fix common/ includes.
6165         * fork-child.c: Fix common/ includes.
6166         * findvar.c: Fix common/ includes.
6167         * fbsd-nat.c: Fix common/ includes.
6168         * event-top.c: Fix common/ includes.
6169         * event-loop.c: Fix common/ includes.
6170         * dwarf2read.c: Fix common/ includes.
6171         * dwarf2loc.c: Fix common/ includes.
6172         * dwarf2-frame.c: Fix common/ includes.
6173         * dwarf-index-cache.c: Fix common/ includes.
6174         * dtrace-probe.c: Fix common/ includes.
6175         * disasm-selftests.c: Fix common/ includes.
6176         * defs.h: Fix common/ includes.
6177         * csky-tdep.c: Fix common/ includes.
6178         * cp-valprint.c: Fix common/ includes.
6179         * cp-support.h: Fix common/ includes.
6180         * cp-support.c: Fix common/ includes.
6181         * corelow.c: Fix common/ includes.
6182         * completer.h: Fix common/ includes.
6183         * completer.c: Fix common/ includes.
6184         * compile/compile.c: Fix common/ includes.
6185         * compile/compile-loc2c.c: Fix common/ includes.
6186         * compile/compile-cplus-types.c: Fix common/ includes.
6187         * compile/compile-cplus-symbols.c: Fix common/ includes.
6188         * command.h: Fix common/ includes.
6189         * cli/cli-dump.c: Fix common/ includes.
6190         * cli/cli-cmds.c: Fix common/ includes.
6191         * charset.c: Fix common/ includes.
6192         * build-id.c: Fix common/ includes.
6193         * btrace.h: Fix common/ includes.
6194         * btrace.c: Fix common/ includes.
6195         * breakpoint.h: Fix common/ includes.
6196         * breakpoint.c: Fix common/ includes.
6197         * ax.h:
6198         (enum agent_op): Fix common/ includes.
6199         * ax-general.c (struct aop_map): Fix common/ includes.
6200         * ax-gdb.c: Fix common/ includes.
6201         * auxv.c: Fix common/ includes.
6202         * auto-load.c: Fix common/ includes.
6203         * arm-tdep.c: Fix common/ includes.
6204         * arch/riscv.c: Fix common/ includes.
6205         * arch/ppc-linux-common.c: Fix common/ includes.
6206         * arch/i386.c: Fix common/ includes.
6207         * arch/arm.c: Fix common/ includes.
6208         * arch/arm-linux.c: Fix common/ includes.
6209         * arch/arm-get-next-pcs.c: Fix common/ includes.
6210         * arch/amd64.c: Fix common/ includes.
6211         * arch/aarch64.c: Fix common/ includes.
6212         * arch/aarch64-insn.c: Fix common/ includes.
6213         * arch-utils.c: Fix common/ includes.
6214         * amd64-windows-tdep.c: Fix common/ includes.
6215         * amd64-tdep.c: Fix common/ includes.
6216         * amd64-sol2-tdep.c: Fix common/ includes.
6217         * amd64-obsd-tdep.c: Fix common/ includes.
6218         * amd64-nbsd-tdep.c: Fix common/ includes.
6219         * amd64-linux-tdep.c: Fix common/ includes.
6220         * amd64-linux-nat.c: Fix common/ includes.
6221         * amd64-fbsd-tdep.c: Fix common/ includes.
6222         * amd64-fbsd-nat.c: Fix common/ includes.
6223         * amd64-dicos-tdep.c: Fix common/ includes.
6224         * amd64-darwin-tdep.c: Fix common/ includes.
6225         * agent.c: Fix common/ includes.
6226         * ada-lang.h: Fix common/ includes.
6227         * ada-lang.c: Fix common/ includes.
6228         * aarch64-tdep.c: Fix common/ includes.
6229
6230 2019-01-25  Tom Tromey  <tom@tromey.com>
6231
6232         * common/create-version.sh: Use common/version.h.
6233
6234 2019-01-24  Pedro Alves  <palves@redhat.com>
6235
6236         * infrun.c (signal_stop, signal_print, signal_program)
6237         (signal_catch, signal_pass): Now arrays instead of pointers.
6238         (update_signals_program_target, do_target_resume)
6239         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6240         * linux-nat.c (linux_nat_target::pass_signals)
6241         (linux_nat_target::create_inferior, linux_nat_target::attach):
6242         Adjust.
6243         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6244         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6245         * procfs.c (procfs_target::pass_signals): Adjust.
6246         * record-full.c (record_full_target::resume): Adjust.
6247         * remote.c (remote_target::pass_signals)
6248         (remote_target::program_signals): Adjust.
6249         * target-debug.h (target_debug_print_signals): Now takes a
6250         gdb::array_view as parameter.  Adjust.
6251         * target.h (target_ops) <pass_signals, program_signals>: Replace
6252         pointer and length parameters with gdb::array_view.
6253         (target_pass_signals, target_program_signals): Likewise.
6254         * target-delegates.c: Regenerate.
6255
6256 2019-01-24  Pedro Alves  <palves@redhat.com>
6257
6258         * common/forward-scope-exit.h
6259         (forward_scope_exit::forward_scope_exit): Pass arguments to
6260         m_bind_function directly, instead of creating a std::bind and
6261         copying that.
6262
6263 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6264
6265         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6266         for static members.
6267         (pass_in_v_vfp_candidate): Likewise.
6268
6269 2019-01-23  Tom Tromey  <tom@tromey.com>
6270             Pedro Alves  <palves@redhat.com>
6271
6272         * regcache.c (class regcache_invalidator): Remove.
6273         (regcache::raw_write): Use make_scope_exit.
6274
6275 2019-01-23  Tom Tromey  <tom@tromey.com>
6276
6277         * ui-out.h (class ui_out_emit_type): Update comment.
6278
6279 2019-01-23  Tom Tromey  <tom@tromey.com>
6280
6281         * infrun.c (fetch_inferior_event): Update comment.
6282
6283 2019-01-23  Tom Tromey  <tom@tromey.com>
6284             Pedro Alves  <palves@redhat.com>
6285
6286         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6287         parameter.
6288         (fetch_inferior_event): Use SCOPE_EXIT.
6289
6290
6291 2019-01-23  Tom Tromey  <tom@tromey.com>
6292             Pedro Alves  <palves@redhat.com>
6293
6294         * infrun.c (disable_thread_events): Delete.
6295         (stop_all_threads): Use SCOPE_EXIT.
6296
6297 2019-01-23  Tom Tromey  <tom@tromey.com>
6298             Pedro Alves  <palves@redhat.com>
6299
6300         * symfile.c: Include forward-scope-exit.h.
6301         (clear_symtab_users_cleanup): Replace forward declaration with
6302         a FORWARD_SCOPE_EXIT.
6303         (syms_from_objfile_1): Use the forward_scope_exit and
6304         gdb::optional instead of cleanup_function.
6305         (reread_symbols): Use the forward_scope_exit instead of
6306         cleanup_function.
6307         (clear_symtab_users_cleanup): Remove function.
6308
6309 2019-01-23  Tom Tromey  <tom@tromey.com>
6310             Pedro Alves  <palves@redhat.com>
6311
6312         * linux-nat.c: Include scope-exit.h.
6313         (cleanup_target_stop): Remove.
6314         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6315         SCOPE_EXIT.
6316
6317 2019-01-23  Tom Tromey  <tom@tromey.com>
6318             Pedro Alves  <palves@redhat.com>
6319
6320         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6321         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6322
6323 2019-01-23  Tom Tromey  <tom@tromey.com>
6324             Andrew Burgess  <andrew.burgess@embecosm.com>
6325             Pedro Alves  <palves@redhat.com>
6326
6327         * infrun.c (fetch_inferior_event): Use scope_exit.
6328         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6329         * top.c (execute_command): Use scope_exit.
6330         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6331         * utils.c (do_bpstat_clear_actions_cleanup)
6332         (make_bpstat_clear_actions_cleanup): Remove.
6333
6334 2019-01-23  Tom Tromey  <tom@tromey.com>
6335             Pedro Alves  <palves@redhat.com>
6336
6337         * infrun.c: Include "common/scope-exit.h"
6338         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6339         (wait_for_inferior): Use SCOPE_EXIT.
6340         (fetch_inferior_event): Use scope_exit.
6341
6342 2019-01-23  Tom Tromey  <tom@tromey.com>
6343             Pedro Alves  <palves@redhat.com>
6344
6345         * breakpoint.c (create_breakpoint): Remove cleanup.
6346
6347 2019-01-23  Tom Tromey  <tom@tromey.com>
6348             Andrew Burgess  <andrew.burgess@embecosm.com>
6349             Pedro Alves  <palves@redhat.com>
6350
6351 2019-01-23  Pedro Alves  <palves@redhat.com>
6352
6353         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6354
6355 2019-01-23  Pedro Alves  <palves@redhat.com>
6356             Andrew Burgess  <andrew.burgess@embecosm.com>
6357
6358         * gdbthread.h: Include "common/forward-scope-exit.h".
6359         (scoped_finish_thread_state): Redefine custom class in terms of
6360         forward_scope_exit.
6361
6362 2019-01-23  Pedro Alves  <palves@redhat.com>
6363             Andrew Burgess  <andrew.burgess@embecosm.com>
6364
6365         * common/forward-scope-exit.h: New file.
6366
6367 2019-01-23  Pedro Alves  <palves@redhat.com>
6368             Andrew Burgess  <andrew.burgess@embecosm.com>
6369             Tom Tromey  <tom@tromey.com>
6370
6371         * common/scope-exit.h: New file.
6372
6373 2019-01-23  Pedro Alves  <palves@redhat.com>
6374
6375         * common/preprocessor.h (ESC): Rename to ...
6376         (ESC_PARENS): ... this.
6377         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6378         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6379
6380 2019-01-23  Tom Tromey  <tom@tromey.com>
6381
6382         * language.h (class scoped_switch_to_sym_language_if_auto):
6383         Initialize m_lang in both cases.
6384
6385 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6386
6387         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6388         with XCNEW.
6389
6390 2019-01-22  Tom Tromey  <tom@tromey.com>
6391
6392         * corelow.c: Do not include sys/file.h.
6393
6394 2019-01-22  Tom Tromey  <tom@tromey.com>
6395
6396         * tui/tui-wingeneral.h: Include gdb_curses.h.
6397
6398 2019-01-22  Tom Tromey  <tom@tromey.com>
6399
6400         * source-cache.h (class source_cache) <get_source_lines,
6401         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6402
6403 2019-01-22  Tom Tromey  <tom@tromey.com>
6404
6405         * remote-fileio.h (struct remote_target): Declare.
6406
6407 2019-01-22  Tom Tromey  <tom@tromey.com>
6408
6409         * python/py-arch.c: Do not include py-ref.h.
6410         * python/py-bpevent.c: Do not include py-ref.h.
6411         * python/py-cmd.c: Do not include py-ref.h.
6412         * python/py-continueevent.c: Do not include py-ref.h.
6413         * python/py-event.h: Do not include py-ref.h.
6414         * python/py-evtregistry.c: Do not include py-ref.h.
6415         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6416         * python/py-frame.c: Do not include py-ref.h.
6417         * python/py-framefilter.c: Do not include py-ref.h.
6418         * python/py-function.c: Do not include py-ref.h.
6419         * python/py-infevents.c: Do not include py-ref.h.
6420         * python/py-linetable.c: Do not include py-ref.h.
6421         * python/py-objfile.c: Do not include py-ref.h.
6422         * python/py-param.c: Do not include py-ref.h.
6423         * python/py-prettyprint.c: Do not include py-ref.h.
6424         * python/py-progspace.c: Do not include py-ref.h.
6425         * python/py-symbol.c: Do not include py-ref.h.
6426         * python/py-symtab.c: Do not include py-ref.h.
6427         * python/py-type.c: Do not include py-ref.h.
6428         * python/py-unwind.c: Do not include py-ref.h.
6429         * python/py-utils.c: Do not include py-ref.h.
6430         * python/py-value.c: Do not include py-ref.h.
6431         * python/py-varobj.c: Do not include py-ref.h.
6432         * python/py-xmethods.c: Do not include py-ref.h.
6433         * python/python.c: Do not include py-ref.h.
6434         * varobj.c: Do not include py-ref.h.
6435
6436 2019-01-22  Tom Tromey  <tom@tromey.com>
6437
6438         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6439         keyword for bcache.
6440
6441 2019-01-22  Tom Tromey  <tom@tromey.com>
6442
6443         * compile/compile-cplus-types.c: Remove a comment by #include.
6444
6445 2019-01-22  Tom Tromey  <tom@tromey.com>
6446
6447         * compile/gcc-c-plugin.h: Include compile-internal.h.
6448
6449 2019-01-22  Tom Tromey  <tom@tromey.com>
6450
6451         * stabsread.c (EXTERN): Do not define.
6452         (symnum, next_symbol_text_func, processing_gcc_compilation)
6453         (within_function, global_sym_chain, global_stabs)
6454         (previous_stab_code, this_object_header_files)
6455         (n_this_object_header_files)
6456         (n_allocated_this_object_header_files): Define.
6457         * stabsread.h (EXTERN): Never define.  Use "extern".
6458
6459 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6460
6461         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6462         history_value.
6463
6464 2019-01-21  Tom Tromey  <tom@tromey.com>
6465
6466         * ui-out.c: Fix includes.
6467         * tui/tui-source.c: Fix includes.
6468         * target.c: Fix includes.
6469         * remote.c: Fix includes.
6470         * regcache.c: Fix includes.
6471         * python/py-block.c: Fix includes.
6472         * printcmd.c: Fix includes.
6473         * or1k-tdep.c: Fix includes.
6474         * mi/mi-main.c: Fix includes.
6475         * m32r-tdep.c: Fix includes.
6476         * csky-tdep.c: Fix includes.
6477         * compile/compile-cplus-types.c: Fix includes.
6478         * cli/cli-interp.c: Fix includes.
6479
6480 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6481
6482         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6483         for padding.
6484
6485 2019-01-16  Tom Tromey  <tom@tromey.com>
6486
6487         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6488         earlier.
6489         (struct objfile) <msymbols_range>: Move from top level.
6490         <msymbols>: New method.
6491         (class objfile_msymbols): Remove.
6492         * symtab.c (default_collect_symbol_completion_matches_break_on):
6493         Update.
6494         * symmisc.c (dump_msymbols): Update.
6495         * stabsread.c (scan_file_globals): Update.
6496         * objc-lang.c (info_selectors_command, info_classes_command)
6497         (find_methods): Update.
6498         * minsyms.c (find_solib_trampoline_target): Update.
6499         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6500         * coffread.c (coff_symfile_read): Update.
6501         * ada-lang.c (ada_lookup_simple_minsym)
6502         (ada_collect_symbol_completion_matches): Update.
6503
6504 2019-01-16  Tom Tromey  <tom@tromey.com>
6505
6506         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6507         type.  Remove no-argument constructor.
6508         <iterator::operator++>: Simplify.
6509         <begin>: Update.
6510         <end>: Use minimal_symbol_count.
6511
6512 2019-01-16  Tom Tromey  <tom@tromey.com>
6513
6514         * objfiles.h (struct objfile) <psymtabs>: New method.
6515         (class objfile_psymtabs): Remove.
6516         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6517         typedef.
6518         <range>: New method.
6519         (require_partial_symbols): Change return type.
6520         * psymtab.c (require_partial_symbols)
6521         (psym_expand_symtabs_matching): Update.
6522         * mdebugread.c (parse_partial_symbols): Update.
6523         * dbxread.c (dbx_end_psymtab): Update.
6524
6525 2019-01-15  Tom Tromey  <tom@tromey.com>
6526
6527         * symtab.c (lookup_objfile_from_block)
6528         (lookup_symbol_in_objfile_symtabs)
6529         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6530         (find_line_symtab, info_sources_command)
6531         (default_collect_symbol_completion_matches_break_on)
6532         (make_source_files_completion_list): Update.
6533         * symmisc.c (print_objfile_statistics, dump_objfile)
6534         (maintenance_print_symbols, maintenance_info_symtabs)
6535         (maintenance_check_symtabs, maintenance_info_line_tables):
6536         Update.
6537         * source.c (select_source_symtab)
6538         (forget_cached_source_info_for_objfile): Update.
6539         * objfiles.h (class objfile_compunits): Remove.
6540         (struct objfile) <compunits_range>: New typedef.
6541         (compunits): New method.
6542         * objfiles.c (objfile_relocate1): Update.
6543         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6544         * maint.c (count_symtabs_and_blocks): Update.
6545         * linespec.c (iterate_over_all_matching_symtabs): Update.
6546         * cp-support.c (add_symbol_overload_list_qualified): Update.
6547         * coffread.c (coff_symtab_read): Update.
6548         * ada-lang.c (add_nonlocal_symbols)
6549         (ada_collect_symbol_completion_matches)
6550         (ada_add_global_exceptions): Update.
6551
6552 2019-01-15  Tom Tromey  <tom@tromey.com>
6553
6554         * progspace.h (program_space) <objfiles_safe_range>: New
6555         typedef.
6556         <objfiles_safe>: New method.
6557         * objfiles.h (class all_objfiles_safe): Remove.
6558         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6559         * jit.c (jit_inferior_exit_hook): Update.
6560
6561 2019-01-17  Tom Tromey  <tom@tromey.com>
6562
6563         * progspace.h (program_space) <objfiles_range>: New typedef.
6564         <objfiles>: New method.
6565         <objfiles_head>: Rename from objfiles.
6566         (object_files): Update.
6567         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6568         * guile/scm-pretty-print.c
6569         (ppscm_find_pretty_printer_from_objfiles): Update.
6570         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6571         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6572         Update.
6573         * python/py-progspace.c (pspy_get_objfiles): Update.
6574         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6575         Update.
6576         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6577         (objfpy_lookup_objfile_by_build_id): Update.
6578         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6579         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6580         Update.
6581         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6582         (expand_symtab_containing_pc, lookup_objfile_from_block)
6583         (lookup_static_symbol, basic_lookup_transparent_type)
6584         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6585         (find_line_symtab, info_sources_command)
6586         (default_collect_symbol_completion_matches_break_on)
6587         (make_source_files_completion_list, find_main_name): Update.
6588         * symmisc.c (print_symbol_bcache_statistics)
6589         (print_objfile_statistics, maintenance_print_symbols)
6590         (maintenance_print_msymbols, maintenance_print_objfiles)
6591         (maintenance_info_symtabs, maintenance_check_symtabs)
6592         (maintenance_expand_symtabs, maintenance_info_line_tables):
6593         Update.
6594         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6595         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6596         (map_overlay_command, unmap_overlay_command)
6597         (simple_overlay_update, expand_symtabs_matching)
6598         (map_symbol_filenames): Update.
6599         * symfile-debug.c (set_debug_symfile): Update.
6600         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6601         Update.
6602         * source.c (select_source_symtab, forget_cached_source_info):
6603         Update.
6604         * solib.c (solib_read_symbols): Update.
6605         * solib-spu.c (append_ocl_sos): Update.
6606         * psymtab.c (maintenance_print_psymbols)
6607         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6608         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6609         * printcmd.c (info_symbol_command): Update.
6610         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6611         Update.
6612         * objfiles.h (class all_objfiles): Remove.
6613         * objfiles.c (have_partial_symbols, have_full_symbols)
6614         (have_minimal_symbols, qsort_cmp, update_section_map)
6615         (shared_objfile_contains_address_p)
6616         (default_iterate_over_objfiles_in_search_order): Update.
6617         * objc-lang.c (info_selectors_command, info_classes_command)
6618         (find_methods): Update.
6619         * minsyms.c (find_solib_trampoline_target): Update.
6620         * maint.c (maintenance_info_sections)
6621         (maintenance_translate_address, count_symtabs_and_blocks):
6622         Update.
6623         * main.c (captured_main_1): Update.
6624         * linux-thread-db.c (try_thread_db_load_from_pdir)
6625         (has_libpthread): Update.
6626         * linespec.c (iterate_over_all_matching_symtabs)
6627         (search_minsyms_for_name): Update.
6628         * jit.c (jit_find_objf_with_entry_addr): Update.
6629         * hppa-tdep.c (find_unwind_entry)
6630         (hppa_lookup_stub_minimal_symbol): Update.
6631         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6632         Update.
6633         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6634         (elf_gnu_ifunc_resolve_by_got): Update.
6635         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6636         * dwarf-index-write.c (save_gdb_index_command): Update.
6637         * cp-support.c (add_symbol_overload_list_qualified): Update.
6638         * breakpoint.c (create_overlay_event_breakpoint)
6639         (create_longjmp_master_breakpoint)
6640         (create_std_terminate_master_breakpoint)
6641         (create_exception_master_breakpoint): Update.
6642         * blockframe.c (find_pc_partial_function): Update.
6643         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6644         (ada_collect_symbol_completion_matches)
6645         (ada_add_global_exceptions): Update.
6646
6647 2019-01-17  Tom Tromey  <tom@tromey.com>
6648
6649         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6650         declare VEC.
6651         (solib_target_parse_libraries): Change return type.
6652         (library_list_start_segment, library_list_start_section)
6653         (library_list_end_library, library_list_start_library); Update.
6654         (solib_target_free_library_list): Remove.
6655         (solib_target_parse_libraries): Remove cleanup.  Change return
6656         type.
6657         (solib_target_current_sos): Update.
6658
6659 2019-01-17  Tom Tromey  <tromey@bapiya>
6660
6661         * valprint.c: Replace "the the" with "the".
6662         * symtab.c: Replace "the the" with "the".
6663         * solib.c: Replace "the the" with "the".
6664         * solib-dsbt.c: Replace "the the" with "the".
6665         * linespec.c: Replace "the the" with "the".
6666         * dwarf2loc.h: Replace "the the" with "the".
6667         * amd64-windows-tdep.c: Replace "the the" with "the".
6668         * aarch64-tdep.c: Replace "the the" with "the".
6669
6670 2019-01-16  Keith Seitz  <keiths@redhat.com>
6671
6672         PR gdb/23773
6673         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6674         <builder>: Rename to ..
6675         <m_builder>: ... this and make private.
6676         (dwarf2_cu::get_builder): New method.  Change all users of
6677         `builder' to use this method.
6678         (dwarf2_start_symtab): Move to ...
6679         (dwarf2_cu::start_symtab): ... here.  Update all callers
6680         (setup_type_unit_groups): Move to ...
6681         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6682         callers.
6683         (dwarf2_cu::reset_builder): New method.
6684         (process_full_compunit, process_full_type_unit): Use
6685         dwarf2_cu::reset_builder.
6686         (follow_die_offset): Record the ancestor CU if it is different
6687         from the followed DIE's CU.
6688         (follow_die_sig_1): Likewise.
6689
6690 2019-01-15  Tom Tromey  <tom@tromey.com>
6691
6692         * remote.c (class remote_state) <buf>: Now a char_vector.
6693         <buf_size>: Remove.
6694         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6695         parameter.
6696         (remote_target::getpkt_or_notif_sane_1)
6697         (remote_target::getpkt_sane)
6698         (remote_target::getpkt_or_notif_sane): Likewise.
6699         (class remote_target) <putpkt>: New overload.
6700         (remote_target::read_frame): Change type of "buf_p".  Remove
6701         sizeof_p parameter.
6702         (packet_ok): New overload.
6703         (packet_check_result): New overload.
6704         Update all uses.
6705
6706 2019-01-14  Tom Tromey  <tom@tromey.com>
6707
6708         * remote-notif.c (handle_notification, remote_notif_ack)
6709         (remote_notif_parse): Make "buf" const.
6710         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6711         const.
6712         (remote_notif_parse, remote_notif_ack, handle_notification):
6713         Likewise.
6714         * remote.c (remote_notif_stop_parse): Make "buf" const.
6715         (remote_target::remote_parse_stop_reply): Make "buf" const.
6716         (remote_notif_stop_ack): Make "buf" const.
6717
6718 2019-01-14  Tom Tromey  <tom@tromey.com>
6719
6720         * remote.c (remote_console_output): Make parameter const.
6721
6722 2019-01-14  Tom Tromey  <tom@tromey.com>
6723
6724         * target-debug.h (target_debug_print_signals): Constify.
6725         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6726         * procfs.c (procfs_target::pass_signals): Update.
6727         * linux-nat.c (linux_nat_target::pass_signals): Update.
6728         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6729         * target-delegates.c: Rebuild.
6730         * remote.c (remote_target::program_signals): Update.
6731         (remote_target::pass_signals): Update.
6732         * target.c (target_pass_signals): Constify argument.
6733         (target_program_signals): Likewise.
6734         * target.h (struct target_ops) <pass_signals, program_signals>:
6735         Constify argument.
6736         (target_pass_signals, target_program_signals): Constify argument.
6737
6738 2019-01-14  Tom Tromey  <tom@tromey.com>
6739
6740         PR tui/28819:
6741         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6742
6743 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6744
6745         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6746         field.
6747         * rs6000-tdep.c: Include reggroups.h.
6748         (IS_V_ALIAS_PSEUDOREG): Define.
6749         (rs6000_register_name): Return names for the "vX" aliases.
6750         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6751         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6752         aliases.  Call default_register_reggroup_p for all other
6753         pseudo-registers.
6754         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6755         New functions.
6756         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6757         Handle "vX" aliases.
6758         (v_alias_pseudo_register_collect): New function.
6759         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6760         (rs6000_gdbarch_init): Initialize "vX" aliases as
6761         pseudo-registers.  Restore registration of
6762         rs6000_pseudo_register_reggroup_p with
6763         set_tdesc_pseudo_register_reggroup_p.
6764
6765 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6766
6767         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6768         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6769         set_gdbarch_num_pseudo_regs.
6770
6771 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6772
6773         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6774         Remove arg prefixname, add do_set and do_show.
6775         Add member functions set_list and show_list.
6776         * cli/cli-style.c (class cli_style_option): Update accordingly.
6777         (style_set_list): Move to file scope.
6778         (style_show_list): Likewise.
6779         (set_style): Call help_list.
6780         (show_style): Call cmd_show_list.
6781         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6782         Update to use the new macro.
6783
6784 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6785
6786         * ada-lang.c (_initialize_ada_language): Expand the help text
6787         for the "catch exception" command.
6788
6789 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6790
6791         * symtab.c (matching_obj_sections): Initialize obj,
6792         declare it closer to its usage.
6793
6794 2019-01-10  Tom Tromey  <tom@tromey.com>
6795
6796         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6797         (basic_inf_threads_range): Remove.
6798         (inf_threads_range, inf_non_exited_threads_range)
6799         (safe_inf_threads_range): Use next_adapter.
6800
6801 2019-01-10  Keith Seitz  <keiths@redhat.com>
6802
6803         PR gdb/23712
6804         PR symtab/23010
6805         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6806         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6807
6808 2019-01-10  Keith Seitz  <keiths@redhat.com>
6809
6810         PR gdb/23712
6811         PR symtab/23010
6812         * dictionary.c (pending_to_vector): Remove.
6813         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6814         Remove _1 suffix, replacing functions of the same name.  Update
6815         all callers.
6816         (dict_create_hashed, dict_create_hashed_expandable)
6817         (dict_create_linear, dict_create_linear_expandable, dict_free)
6818         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6819         Make functions static.
6820
6821 2019-01-10  Keith Seitz  <keiths@redhat.com>
6822
6823         PR gdb/23712
6824         PR symtab/23010
6825         * dictionary.h (struct dictionary): Replace declaration with
6826         multidictionary.
6827         (dict_create_hashed, dict_create_hashed_expandable)
6828         (dict_create_linear, dict_create_linear_expandable)
6829         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6830         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6831         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6832         taking multidictionary argument.
6833         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6834         * block.h (struct block) <dict>: Change to multidictionary
6835         and rename `multidict'.
6836         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6837         symmisc.c: Update all dictionary references to multidictionary.
6838
6839 2019-01-10  Keith Seitz  <keiths@redhat.com>
6840
6841         PR gdb/23712
6842         PR symtab/23010
6843         * dictionary.c: Include unordered_map.
6844         (pending_to_vector): New function.
6845         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6846         Rewrite the non-"_1" functions to take vector instead
6847         of linked list.
6848         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6849         "new" _1 versions of the same name.
6850         (multidictionary): Define.
6851         (std::hash<enum language): New definition.
6852         (collate_pending_symbols_by_language, mdict_create_hashed)
6853         (mdict_create_hashed_expandable, mdict_create_linear)
6854         (mdict_create_linear_expandable, mdict_free)
6855         (find_language_dictionary, create_new_language_dictionary)
6856         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6857         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6858         (mdict_size, mdict_empty): New functions.
6859         * dictionary.h (mdict_iterator): Define.
6860
6861 2019-01-10  Pedro Alves  <palves@redhat.com>
6862
6863         * breakpoint.c (read_uploaded_action)
6864         (create_tracepoint_from_upload): Adjust to use
6865         gdb::unique_xmalloc_ptr.
6866         * ctf.c (ctf_write_uploaded_tp):
6867         (SET_ARRAY_FIELD): Use emplace_back.
6868         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6869         * tracefile-tfile.c (tfile_write_uploaded_tp):
6870         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6871         gdb::unique_xmalloc_ptr.
6872         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6873         at_string, cond_string, cmd_strings>: Replace char pointers
6874         with gdb::unique_xmalloc_ptr.
6875
6876 2019-01-10  Pedro Alves  <palves@redhat.com>
6877
6878         * solib-target.c (library_list_start_library): Don't xstrdup name.
6879
6880 2019-01-10  Pedro Alves  <palves@redhat.com>
6881
6882         * mdebugread.c (parse_partial_symbols): Use
6883         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6884
6885 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6886
6887         * linux-fork.c (scoped_switch_fork_info)
6888         <~scoped_switch_fork_info>: Fix incorrect variable name.
6889
6890 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6891
6892         * linux-fork.c (scoped_switch_fork_info)
6893         <scoped_switch_fork_info>: Make explicit.
6894         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6895
6896 2019-01-10  Tom Tromey  <tom@tromey.com>
6897
6898         * objfiles.h (objfile::reset_psymtabs): Update.
6899         * objfiles.c (objfile::objfile): Update.
6900         * psymtab.h (psymtab_storage::obstack): Update.
6901         (psymtab_storage::m_obstack): Use gdb::optional.
6902         (class psymtab_storage): Update comment.  Remove objfile
6903         parameter.
6904         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6905
6906 2019-01-10  Tom Tromey  <tom@tromey.com>
6907
6908         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6909         <free_psymtabs>: Now private.
6910         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6911         (allocate_psymtab): Use new method.
6912
6913 2019-01-10  Tom Tromey  <tom@tromey.com>
6914
6915         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6916         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6917         * mdebugread.c (parse_partial_symbols): Use
6918         allocate_dependencies.
6919         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6920         allocate_dependencies.
6921         (process_psymtab_comp_unit_reader)
6922         (build_type_psymtab_dependencies): Likewise.
6923         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6924
6925 2019-01-10  Tom Tromey  <tom@tromey.com>
6926
6927         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6928         PSYMBOL_SET_LANGUAGE.
6929         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6930
6931 2019-01-10  Tom Tromey  <tom@tromey.com>
6932
6933         * psymtab.h (psymtab_storage::obstack): New method.
6934         <m_obstack>: Rename from obstack; now private.
6935         * psymtab.c (psymtab_storage): Update.
6936         * dwarf2read.c (create_addrmap_from_index)
6937         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6938         Update.
6939
6940 2019-01-10  Tom Tromey  <tom@tromey.com>
6941
6942         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6943         * objfiles.h (objfile::reset_psymtabs): New method.
6944
6945 2019-01-10  Tom Tromey  <tom@tromey.com>
6946
6947         * symmisc.c (print_symbol_bcache_statistics): Update.
6948         (print_objfile_statistics): Update.
6949         * symfile.c (reread_symbols): Update.
6950         * psymtab.h (class psymtab_storage): New.
6951         * psymtab.c (psymtab_storage): New constructor.
6952         (~psymtab_storage): New destructor.
6953         (require_partial_symbols): Update.
6954         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6955         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6956         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6957         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6958         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6959         (start_psymtab_common, end_psymtab_common)
6960         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6961         (allocate_psymtab): Update.
6962         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6963         Update.
6964         (dump_psymtab_addrmap, maintenance_print_psymbols)
6965         (maintenance_check_psymtabs): Update.
6966         (class objfile_psymtabs): Move to objfiles.h.
6967         * psympriv.h (discard_psymtab): Now inline.
6968         (psymtab_discarder::psymtab_discarder): Update.
6969         (psymtab_discarder::~psymtab_discarder): Update.
6970         (ALL_OBJFILE_PSYMTABS): Rewrite.
6971         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6972         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6973         Remove fields.
6974         <partial_symtabs>: New field.
6975         (class objfile_psymtabs): Move from psymtab.h.  Update.
6976         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6977         psymbol_cache.
6978         (objfile::~objfile): Don't destroy psymbol_cache.
6979         * mdebugread.c (parse_partial_symbols): Update.
6980         * dwarf2read.c (create_addrmap_from_index)
6981         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6982         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6983         (add_partial_subprogram, dwarf2_ranges_read): Update.
6984         * dwarf-index-write.c (write_address_map)
6985         (write_one_signatured_type, recursively_write_psymbols)
6986         (class debug_names, class debug_names, write_psymtabs_to_index):
6987         Update.
6988
6989 2019-01-10  Tom Tromey  <tom@tromey.com>
6990
6991         * symtab.h (SYMBOL_SET_NAMES): Update.
6992         (symbol_set_names): Update.
6993         (MSYMBOL_SET_NAMES): Update.
6994         * symtab.c (symbol_set_names): Change argument to be an
6995         objfile_per_bfd_storage.
6996         * psymtab.c (add_psymbol_to_bcache): Update.
6997         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6998
6999 2019-01-10  Tom Tromey  <tom@tromey.com>
7000
7001         * symtab.c (create_demangled_names_hash): Change argument to be an
7002         objfile_per_bfd_storage.
7003         (symbol_set_names): Update.
7004
7005 2019-01-10  Tom Tromey  <tom@tromey.com>
7006
7007         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7008         init_psymbol_list.
7009         * psymtab.c (init_psymbol_list): Do nothing if already called.
7010         * psympriv.h (init_psymbol_list): Add comment.
7011         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7012         init_psymbol_list.
7013         * dbxread.c (dbx_symfile_read): Unconditionally call
7014         init_psymbol_list.
7015
7016 2019-01-10  Tom Tromey  <tom@tromey.com>
7017
7018         * xcoffread.c (scan_xcoff_symtab): Update.
7019         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7020         "where".
7021         * mdebugread.c (parse_partial_symbols)
7022         (handle_psymbol_enumerators): Update.
7023         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7024         * dbxread.c (read_dbx_symtab): Update.
7025         * psympriv.h (psymbol_placement): New enum.
7026         (add_psymbol_to_list): Update.
7027
7028 2019-01-10  Tom Tromey  <tom@tromey.com>
7029
7030         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7031         static_psymbols parameters.
7032         (scan_xcoff_symtab): Update.
7033         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7034         static_psymbols parameters.
7035         * psympriv.h (start_psymtab_common): Update.
7036         * mdebugread.c (parse_partial_symbols): Update.
7037         * dwarf2read.c (create_partial_symtab): Update.
7038         * dbxread.c (read_dbx_symtab): Update.
7039         (start_psymtab): Remove global_psymbols and static_psymbols
7040         parameters.
7041
7042 2019-01-10  Tom Tromey  <tom@tromey.com>
7043
7044         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7045         * psymtab.c (allocate_psymtab): Add comment.
7046         * psympriv.h (allocate_psymtab): Add comment.
7047         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7048         initializations.
7049         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7050
7051 2019-01-10  Tom Tromey  <tom@tromey.com>
7052
7053         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7054         Don't declare.
7055         * mipsread.c: Include mdebugread.h.
7056         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7057         Declare.
7058         * elfread.c: Include mdebugread.h.
7059
7060 2019-01-09  Tom Tromey  <tom@tromey.com>
7061
7062         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7063         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7064         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7065         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7066         (psym_lookup_symbol, psym_find_last_source_symtab)
7067         (psym_forget_cached_source_info, psym_print_stats)
7068         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7069         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7070         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7071         (psym_find_compunit_symtab_by_address)
7072         (maintenance_print_psymbols, maintenance_info_psymtabs)
7073         (maintenance_check_psymtabs): Use ranged for.
7074         * psymtab.h (class objfile_psymtabs): New.
7075         (require_partial_symbols): Return objfile_psymtabs.
7076         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7077
7078 2019-01-09  Tom Tromey  <tom@tromey.com>
7079
7080         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7081         (find_pc_mapped_section, list_overlays_command)
7082         (map_overlay_command, unmap_overlay_command)
7083         (simple_overlay_update): Use all_objfiles.
7084         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7085         * printcmd.c (info_symbol_command): Use all_objfiles.
7086         * objfiles.h (ALL_OBJSECTIONS): Remove.
7087         * maint.c (maintenance_translate_address): Use all_objfiles.
7088         * gcore.c (gcore_create_callback): Use all_objfiles.
7089         (objfile_find_memory_regions): Likewise.
7090
7091 2019-01-09  Tom Tromey  <tom@tromey.com>
7092
7093         * symtab.c (find_line_symtab, info_sources_command)
7094         (make_source_files_completion_list): Use objfile_compunits.
7095         * source.c (select_source_symtab): Use objfile_compunits.
7096         * objfiles.h (struct objfile): Update comment.
7097         (ALL_OBJFILES): Remove.
7098         (ALL_FILETABS): Remove.
7099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7100         objfile_compunits.
7101
7102 2019-01-09  Tom Tromey  <tom@tromey.com>
7103
7104         * symmisc.c (print_objfile_statistics, dump_objfile)
7105         (maintenance_print_symbols): Use compunit_filetabs.
7106         * source.c (forget_cached_source_info_for_objfile): Use
7107         compunit_filetabs.
7108         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7109         (ALL_FILETABS): Use compunit_filetabs.
7110         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7111         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7112
7113 2019-01-09  Tom Tromey  <tom@tromey.com>
7114
7115         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7116         (compunit_filetabs): New.
7117         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7118         compunit_filetabs.
7119         (info_sources_command, make_source_files_completion_list): Remove
7120         declaration.
7121         * symmisc.c (print_objfile_statistics, dump_objfile)
7122         (maintenance_print_symbols): Remove declaration.
7123         (maintenance_info_symtabs): Use compunit_filetabs.
7124         (maintenance_info_line_tables): Likewise.
7125         * source.c (select_source_symtab): Change local variable name.
7126         (forget_cached_source_info_for_objfile): Remove declaration.
7127         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7128         * objfiles.c (objfile_relocate1): Remove declaration.
7129         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7130         declaration.
7131         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7132         * coffread.c (coff_symtab_read): Remove declaration.
7133         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7134         compunit_filetabs.
7135
7136 2019-01-09  Tom Tromey  <tom@tromey.com>
7137
7138         * symtab.c (lookup_objfile_from_block)
7139         (find_pc_sect_compunit_symtab, search_symbols)
7140         (default_collect_symbol_completion_matches_break_on): Use
7141         objfile_compunits.
7142         * objfiles.h (ALL_COMPUNITS): Remove.
7143         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7144         * cp-support.c (add_symbol_overload_list_qualified): Use
7145         objfile_compunits.
7146         * ada-lang.c (ada_collect_symbol_completion_matches)
7147         (ada_add_global_exceptions): Use objfile_compunits.
7148
7149 2019-01-09  Tom Tromey  <tom@tromey.com>
7150
7151         * source.c (select_source_symtab)
7152         (forget_cached_source_info_for_objfile): Remove declaration.
7153         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7154         declaration.
7155         * maint.c (count_symtabs_and_blocks): Remove declaration.
7156         * cp-support.c (add_symbol_overload_list_qualified): Remove
7157         declaration.
7158         * coffread.c (coff_symtab_read): Remove declaration.
7159         * symtab.c (lookup_symbol_in_objfile_symtabs)
7160         (basic_lookup_transparent_type_1): Use objfile_compunits.
7161         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7162         (info_sources_command, search_symbols)
7163         (default_collect_symbol_completion_matches_break_on)
7164         (make_source_files_completion_list): Remove declaration.
7165         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7166         (ada_collect_symbol_completion_matches)
7167         (ada_add_global_exceptions): Remove declaration.
7168         * linespec.c (iterate_over_all_matching_symtabs): Use
7169         objfile_compunits.
7170         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7171         (class objfile_compunits): New.
7172         (ALL_COMPUNITS): Use objfile_compunits.
7173         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7174         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7175         objfile_compunits.
7176         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7177
7178 2019-01-09  Tom Tromey  <tom@tromey.com>
7179
7180         * symtab.c (search_symbols)
7181         (default_collect_symbol_completion_matches_break_on): Use
7182         objfile_msymbols.
7183         * ada-lang.c (ada_lookup_simple_minsym)
7184         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7185         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7186         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7187         objfile_msymbols.
7188         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7189         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7190         * objc-lang.c (find_methods): Use objfile_msymbols.
7191         (info_selectors_command, info_classes_command): Likewise.
7192         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7193         * objfiles.h (class objfile_msymbols): New.
7194         (ALL_OBJFILE_MSYMBOLS): Remove.
7195         (ALL_MSYMBOLS): Remove.
7196
7197 2019-01-09  Tom Tromey  <tom@tromey.com>
7198
7199         * common/next-iterator.h (next_adapter): Add Iterator template
7200         parameter.
7201         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7202         (class all_objfiles_safe): New.
7203         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7204         * objfiles.c (put_objfile_before): Update comment.
7205         (add_separate_debug_objfile): Likewise.
7206         (free_all_objfiles): Use all_objfiles_safe.
7207         (objfile_purge_solibs): Likewise.
7208
7209 2019-01-09  Tom Tromey  <tom@tromey.com>
7210
7211         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7212         (expand_symtab_containing_pc, lookup_static_symbol)
7213         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7214         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7215         all_objfiles.
7216         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7217         * breakpoint.c (create_overlay_event_breakpoint)
7218         (create_longjmp_master_breakpoint)
7219         (create_std_terminate_master_breakpoint)
7220         (create_exception_master_breakpoint): Use all_objfiles.
7221         * linux-thread-db.c (try_thread_db_load_from_pdir)
7222         (has_libpthread): Use all_objfiles.
7223         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7224         * linespec.c (iterate_over_all_matching_symtabs)
7225         (search_minsyms_for_name): Use all_objfiles.
7226         * maint.c (maintenance_info_sections): Use all_objfiles.
7227         * main.c (captured_main_1): Use all_objfiles.
7228         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7229         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7230         * guile/scm-pretty-print.c
7231         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7232         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7233         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7234         (maintenance_print_msymbols): Use all_objfiles.
7235         * source.c (select_source_symtab): Use all_objfiles.
7236         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7237         * symfile.c (remove_symbol_file_command)
7238         (expand_symtabs_matching, map_symbol_filenames): Use
7239         all_objfiles.
7240         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7241         all_objfiles.
7242         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7243         * objc-lang.c (find_methods): Use all_objfiles.
7244         * objfiles.c (have_partial_symbols, have_full_symbols)
7245         (have_minimal_symbols, qsort_cmp)
7246         (default_iterate_over_objfiles_in_search_order): Use
7247         all_objfiles.
7248         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7249         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7250         (maintenance_check_psymtabs): Use all_objfiles.
7251         (ALL_PSYMTABS): Remove.
7252         * compile/compile-object-run.c (do_module_cleanup): Use
7253         all_objfiles.
7254         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7255         * cp-support.c (add_symbol_overload_list_qualified): Use
7256         all_objfiles.
7257         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7258         Use all_objfiles.
7259         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7260         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7261         all_objfiles.
7262         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7263         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7264         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7265         Uses all_objfiles.
7266         * solib.c (solib_read_symbols): Use all_objfiles
7267
7268 2019-01-09  Tom Tromey  <tom@tromey.com>
7269
7270         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7271         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7272         all_objfiles.
7273         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7274         * symmisc.c (print_symbol_bcache_statistics)
7275         (print_objfile_statistics, maintenance_print_objfiles)
7276         (maintenance_info_symtabs, maintenance_check_symtabs)
7277         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7278         all_objfiles.
7279         * source.c (forget_cached_source_info): Use all_objfiles.
7280         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7281         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7282         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7283         * objfiles.c (update_section_map): Use all_objfiles.
7284         (shared_objfile_contains_address_p): Likewise.
7285         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7286         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7287
7288 2019-01-09  Tom Tromey  <tom@tromey.com>
7289
7290         * common/next-iterator.h: New file.
7291         * objfiles.h (class all_objfiles): New.
7292         (struct objfile_iterator): New.
7293
7294 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7295
7296         * NEWS: Move the description of the changed "frame", "select-frame",
7297          and "info frame" commands to the Changed commands section.
7298
7299 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7300
7301         * gdbtypes.c (check_stub_method_group): Remove handling of old
7302         mangling schemes.
7303         * linespec.c (find_methods): Likewise.
7304         * stabsread.c (read_member_functions): Likewise.
7305         * valops.c (search_struct_method): Likewise.
7306         (value_struct_elt_for_reference): Likewise.
7307         * NEWS: Mention this change.
7308
7309 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7310
7311         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7312         print_source_lines.
7313         * source.c (print_source_lines_base): Update line number check.
7314         (print_source_lines): New function.
7315         (source_lines_range::source_lines_range): New function.
7316         * source.h (class source_lines_range): New class.
7317         (print_source_lines): New declaration.
7318
7319 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7320
7321         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7322
7323 2019-01-08  Tom Tromey  <tom@tromey.com>
7324             Simon Marchi  <simon.marchi@ericsson.com>
7325
7326         PR gdb/24060
7327         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7328         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7329         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7330         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7331         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7332         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7333
7334 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7335
7336         * source.c (select_source_symtab): Move header comment to
7337         declaration in source.h.
7338         (forget_cached_source_info_for_objfile): Likewise.
7339         (forget_cached_source_info): Likewise.
7340         (identify_source_line): Likewise.
7341         * source.h (identify_source_line): Move declaration from symtab.h
7342         and add comment from source.c
7343         (print_source_lines): Likewise.
7344         (forget_cached_source_info_for_objfile): Likewise.
7345         (forget_cached_source_info): Likewise.
7346         (select_source_symtab): Likewise.
7347         (enum print_source_lines_flag): Move definition from symtab.h.
7348         * symtab.h (identify_source_line): Move declaration to source.h.
7349         (print_source_lines): Likewise.
7350         (forget_cached_source_info_for_objfile): Likewise.
7351         (forget_cached_source_info): Likewise.
7352         (select_source_symtab): Likewise.
7353         (enum print_source_lines_flag): Move definition to source.h.
7354         * tui/tui-hooks.c: Add 'source.h' include.
7355
7356 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7357
7358         * source.c (print_source_lines_base): Handle requests to print
7359         reverse line number sequences, and guard against empty lines
7360         string.
7361
7362 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7363
7364         * source.c (print_source_lines_base): Fix skip of '\r' if next
7365         character is '\n'.
7366
7367 2019-01-06  Tom Tromey  <tom@tromey.com>
7368
7369         * c-exp.y (struct c_parse_state) <macro_original_text,
7370         expansion_obstack>: New member.
7371         (macro_original_text, expansion_obstack): Remove globals.
7372         (scan_macro_expansion, scanning_macro_expansion)
7373         (finished_macro_expansion): Update.
7374         (scan_macro_cleanup): Remove.
7375         (yylex, c_parse): Update.
7376
7377 2019-01-06  Tom Tromey  <tom@tromey.com>
7378
7379         * c-exp.y (struct c_parse_state) <strings>: New member.
7380         (operator_stoken): Update.
7381
7382 2019-01-06  Tom Tromey  <tom@tromey.com>
7383
7384         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7385         (union type_stack_elt) <typelist_val>: Now a pointer to
7386         std::vector.
7387         (type_stack_cleanup): Don't declare.
7388         (push_typelist): Update.
7389         * parse.c (pop_typelist): Return a std::vector.
7390         (push_typelist): Take a std::vector.
7391         (follow_types): Update.  Do not free args.
7392         (type_stack_cleanup): Remove.
7393         * c-exp.y (struct c_parse_state): New.
7394         (cpstate): New global.
7395         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7396         (nonempty_typelist): Update.
7397         (func_mod): Create a new vector.
7398         (c_parse): Create a c_parse_state.
7399         (check_parameter_typelist): Do not delete params.
7400         (function_method): Update.  Do not delete type_list.
7401
7402 2019-01-06  Tom Tromey  <tom@tromey.com>
7403
7404         PR gdb/28155:
7405         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7406         check_typedef.
7407         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7408         (print_return_value): Likewise.
7409
7410 2019-01-05  Tom Tromey  <tom@tromey.com>
7411
7412         * contrib/cleanup_check.py: Remove.
7413         * contrib/gcc-with-excheck: Remove.
7414         * contrib/exsummary.py: Remove.
7415         * contrib/excheck.py: Remove.
7416
7417 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7418
7419         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7420         NULL. Initialize tpprev to NULL instead of assigning it
7421         to NULL on the next statement.
7422         * windows-nat.c (windows_delete_thread): Remove check for
7423         main_thread_id before printing thread exit notifications.
7424         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7425         Remove thread ID check against main_thread_id.
7426         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7427         windows_delete_thread.
7428         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7429
7430 2019-01-04  Tom Tromey  <tom@tromey.com>
7431
7432         * compile/compile.c (_initialize_compile): Use upper case for
7433         metasyntactic variables.
7434         * symmisc.c (_initialize_symmisc): Use upper case for
7435         metasyntactic variables.
7436         * psymtab.c (_initialize_psymtab): Use upper case for
7437         metasyntactic variables.
7438         * demangle.c (demangle_command): Use upper case for metasyntactic
7439         variables.
7440         (_initialize_demangler): Likewise.
7441         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7442         variables.
7443
7444 2019-01-03  Tom Tromey  <tom@tromey.com>
7445
7446         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7447
7448 2019-01-03  Tom Tromey  <tom@tromey.com>
7449
7450         * python/py-symtab.c (salpy_str): Update.
7451         (struct salpy_sal_object) <symtab>: Now a PyObject.
7452         (salpy_dealloc): Update.
7453         (del_objfile_sal): Use gdbpy_ref.
7454
7455 2019-01-03  Tom Tromey  <tom@tromey.com>
7456
7457         * python/py-type.c (convert_field): Use new_reference.  Return
7458         gdbpy_ref.
7459         (make_fielditem): Return gdbpy_ref.
7460         (typy_fields): Update.
7461         (typy_getitem): Update.
7462         (field_name): Return gdbpy_ref.  Use new_reference.
7463         (typy_iterator_iternext): Update.
7464
7465 2019-01-03  Tom Tromey  <tom@tromey.com>
7466
7467         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7468
7469 2019-01-03  Tom Tromey  <tom@tromey.com>
7470
7471         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7472         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7473         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7474         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7475         (pspy_set_type_printers): Likewise.
7476         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7477         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7478         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7479         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7480         (objfpy_set_type_printers): Likewise.
7481
7482 2019-01-03  Tom Tromey  <tom@tromey.com>
7483
7484         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7485         (gdbpy_print_stack): Use gdbpy_err_fetch.
7486         * python/python-internal.h (class gdbpy_err_fetch): New class.
7487         (class gdbpy_enter) <m_error_type, m_error_value,
7488         m_error_traceback>: Remove.
7489         <m_error>: New member.
7490         (gdbpy_exception_to_string): Don't declare.
7491         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7492         * python/py-value.c (convert_value_from_python): Use
7493         gdbpy_err_fetch.
7494         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7495         gdbpy_exception_to_string.
7496         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7497         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7498         gdbpy_err_fetch.
7499
7500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7501
7502         * linux-nat.c (delete_lwp_cleanup): Delete.
7503         (struct lwp_deleter): New struct.
7504         (lwp_info_up): New typedef.
7505         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7506         lwp_info_up.
7507
7508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7509
7510         * linux-fork.c (class scoped_switch_fork_info): New class.
7511         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7512
7513 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7514
7515         * valops.c (find_overload_match): Remove use of null_cleanup, and
7516         calls to do_cleanups.
7517
7518 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7519
7520         * compile/compile-cplus-types.c
7521         (compile_cplus_instance::decl_name): Handle changes to
7522         cp_func_name.
7523         * cp-support.c (cp_func_name): Update header comment, update
7524         return type.
7525         * cp-support.h (cp_func_name): Update return type in declaration.
7526         * valops.c (find_overload_match): Move temp_func local to top
7527         level of function and change its type.  Use temp_func to hold and
7528         delete temporary string obtained from cp_func_name.
7529
7530 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7531
7532         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7533         gdb::char_vector, remove cleanup, and update uses of `msg`.
7534
7535 2019-01-03  Jim Wilson  <jimw@sifive.com>
7536
7537         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7538
7539 2019-01-02  Tom Tromey  <tom@tromey.com>
7540
7541         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7542         (tdesc_parse_xml): Remove cleanups.
7543         * target-descriptions.h (make_cleanup_free_target_description):
7544         Don't declare.
7545         (target_desc_deleter): New struct.
7546         (target_desc_up): New typedef.
7547         * target-descriptions.c (target_desc_deleter::operator()): Rename
7548         from free_target_description.
7549         (make_cleanup_free_target_description): Remove.
7550
7551 2019-01-02  Tom Tromey  <tom@tromey.com>
7552
7553         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7554         constructor, destructor.
7555         (linespec_parser): Remove typedef.
7556         (~linespec_parser): Rename from linespec_parser_delete.
7557         (linespec_lex_to_end, linespec_complete_label)
7558         (linespec_complete): Update.
7559         (decode_line_full): Remove cleanups.
7560         (decode_line_1): Update.
7561
7562 2019-01-02  Tom Tromey  <tom@tromey.com>
7563
7564         * python/python-internal.h (inferior_to_inferior_object): Change
7565         return type.
7566         * python/py-exitedevent.c (create_exited_event_object): Update.
7567         * python/py-inferior.c (inferior_to_inferior_object): Return
7568         gdbpy_ref.
7569         (python_new_inferior, python_inferior_deleted)
7570         (thread_to_thread_object, delete_thread_object)
7571         (build_inferior_list, gdbpy_selected_inferior): Update.
7572         * python/py-infthread.c (create_thread_object): Update.  Also fail
7573         if inferior_to_inferior_object fails.
7574
7575 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7576
7577         * inferior.h (class inferior) <displaced_step_state>: New field.
7578         * infrun.h (struct displaced_step_state): Move here from
7579         infrun.c.  Initialize fields, add constructor.
7580         <inf>: Remove field.
7581         <reset>: New method.
7582         * infrun.c (struct displaced_step_inferior_state): Move to
7583         infrun.h.
7584         (displaced_step_inferior_states): Remove.
7585         (get_displaced_stepping_state): Adust.
7586         (displaced_step_in_progress_any_inferior): Adjust.
7587         (displaced_step_in_progress_thread): Adjust.
7588         (displaced_step_in_progress): Adjust.
7589         (add_displaced_stepping_state): Remove.
7590         (get_displaced_step_closure_by_addr): Adjust.
7591         (remove_displaced_stepping_state): Remove.
7592         (infrun_inferior_exit): Call displaced_step_state.reset.
7593         (use_displaced_stepping): Don't check for NULL.
7594         (displaced_step_prepare_throw): Call
7595         get_displaced_stepping_state.
7596         (displaced_step_fixup): Don't check for NULL.
7597         (prepare_for_detach): Don't check for NULL.
7598
7599 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7600
7601         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7602          in case of call that did not complete.
7603
7604 2019-01-02  Andrey Utkin  <autkin@undo.io>
7605
7606         * symfile.c (find_separate_debug_file): Fix search of debug files for
7607         remote debuggee.
7608
7609 2019-01-02  Tom Tromey  <tom@tromey.com>
7610
7611         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7612         indentation.
7613         * python/py-frame.c (frapy_older): Remove cast.
7614         (frapy_newer): Likewise.
7615         * python/py-breakpoint.c (local_setattro): Remove cast.
7616         * python/py-arch.c (archpy_name): Remove local variable.
7617         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7618
7619 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7620
7621         * unittests/basic_string_view/element_access/char/empty.cc:
7622         Fix year range in copyright header.
7623
7624 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7625
7626         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7627         Delete.
7628         <operator==>: Update with for removed field.
7629         <hash>: Likewise.
7630         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7631         <isa_features>: ...this.
7632         <abi_features>: New field.
7633         (riscv_isa_flen): Update comment.
7634         (riscv_abi_xlen): New declaration.
7635         (riscv_abi_flen): New declaration.
7636         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7637         isa_features.
7638         (riscv_abi_xlen): New function.
7639         (riscv_isa_flen): Update to get answer from isa_features.
7640         (riscv_abi_flen): New function.
7641         (riscv_has_fp_abi): Update to get answer from abi_features.
7642         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7643         xlen and flen.
7644         (riscv_call_info) <xlen, flen>: Update comment.
7645         (riscv_call_arg_struct): Remove invalid assertions
7646         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7647         is removed.
7648         (riscv_gdbarch_init): Gather isa features and abi features
7649         separately, ensure both match on the gdbarch when reusing an old
7650         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7651         a target with 64-bit float hardware.
7652
7653 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7654
7655         * source.c (search_command_helper): Stop reverse search
7656         when line 1 has been searched.
7657
7658 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7659
7660         * record-full.c (record_full_base_target::close): Rewrite
7661         record_full_core_buf_list free logic.
7662
7663 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7664
7665         * break-catch-syscall.c (print_one_catch_syscall): xfree
7666         the last text.
7667
7668 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7669
7670         * top.c (print_gdb_version): Update Copyright year in version
7671         message.
7672
7673 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7674
7675         Update copyright year range in all GDB files.
7676
7677 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7678
7679         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7680
7681 For older changes see ChangeLog-2018.
7682 \f
7683 Local Variables:
7684 mode: change-log
7685 left-margin: 8
7686 fill-column: 74
7687 version-control: never
7688 coding: utf-8
7689 End:
7690