gdb/ChangeLog

   1 2019-05-29  Tom Tromey  <tromey@adacore.com>
   2
   3         PR c++/20020:
   4         * cp-valprint.c (cp_print_value_fields): Call
   5         cp_print_static_field inside "try".
   6
   7 2019-06-10  Tom de Vries  <tdevries@suse.de>
   8
   9         PR symtab/24545
  10         * symtab.c (struct demangled_name_entry): Add language field.
  11         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
  12         static minimal symbol".  Set and use language field.
  13
  14 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
  15
  16         PR gdb/24592
  17         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
  18         function.
  19         (fill_gregset): Call amd64_linux_collect_native_gregset instead
  20         of amd64_collect_native_gregset.
  21         (amd64_linux_nat_target::store_registers): Likewise.
  22
  23 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  24
  25         * version.in: Set GDB version number to 8.3.0.DATE-git.
  26
  27 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  28
  29         GDB 8.3 released.
  30
  31 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  32
  33         * version.in: Set GDB version number to 8.3.
  34
  35 2019-05-08  Tom Tromey  <tromey@adacore.com>
  36
  37         * utils.c (fputs_maybe_filtered): Reset style after paging, even
  38         when no wrap column is set.
  39
  40 2019-05-04  Tom Tromey  <tom@tromey.com>
  41
  42         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  43         (lookup_partial_symbol, print_partial_symbols)
  44         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  45         (psymbol_compare): Update.
  46         (add_psymbol_to_bcache): Clear the entire psymbol.
  47         (maintenance_check_psymtabs): Update.
  48         * psympriv.h (struct partial_symbol): Don't derive from
  49         general_symbol_info.
  50         <obj_section, unrelocated_address, address,
  51         set_unrelocated_address>: Update.
  52         <ginfo>: New member.
  53         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  54         (debug_names::write_psymbols): Update.
  55
  56 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  57
  58         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
  59         level, so that various Windows header files expose the necessary
  60         declarations and definitions.
  61
  62         * symfile.c (find_separate_debug_file): Remove colon from the
  63         drive spec of DOS/Windows file names of the target, so that the
  64         file name produced from DEBUGDIR and the target's directory will
  65         be valid on DOS/Windows systems.
  66
  67 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  68
  69         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  70         Use current_event.dwThreadId instead of main_thread_id.
  71
  72 2019-04-30  Tom Tromey  <tromey@adacore.com>
  73
  74         PR c++/24470:
  75         * dwarf2read.c (process_structure_scope): Handle case where type
  76         has template parameters but no symbol was created.
  77
  78 2019-04-19  Sergei Trofimovich <siarheit@google.com>
  79
  80         * configure.ac: add --enable-source-highlight switch.
  81         * configure: Regenerate.
  82         * top.c (print_gdb_version): plumb --enable-source-highlight
  83         status to "show configuration".
  84
  85 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
  86
  87         PR symtab/24423:
  88         * source.c (print_source_lines_base): Advance "iter" when a
  89         control character is seen.
  90
  91 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  92
  93         * inferior.h (struct infcall_suspend_state_deleter):
  94         Catch exception in destructor to avoid crash.
  95
  96 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
  97
  98         * utils.c (prompt_for_continue): Don't restore the styling at the
  99         end, as applied_style has the wrong value.  This fixes styling in
 100         long lists of file names that are interrupted by the "Continue?"
 101         prompt.
 102
 103 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 104
 105         * version.in: Set GDB version number to 8.2.91.DATE-git.
 106
 107 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 108
 109         GDB 8.2.91 released.
 110
 111 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 112
 113         * version.in: Set GDB version number to 8.2.91.
 114
 115 2019-03-20  Tom Tromey  <tromey@adacore.com>
 116
 117         PR gdb/24391
 118         * infrun.c (handle_inferior_event): Rename from
 119         handle_inferior_event_1.  Create a scoped_value_mark.
 120         (handle_inferior_event): Remove.
 121
 122 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 123
 124         * source-cache.c (source_cache::get_source_lines): Re-read
 125         fullname after calling open_source_file.
 126
 127 2019-03-18  Pedro Alves  <palves@redhat.com>
 128             Eli Zaretskii <eliz@gnu.org>
 129
 130         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 131         m_line and m_start_of_line.
 132
 133 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 134
 135         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 136         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 137         it returns a newline.  This fixes a regression in TU mode, whereby
 138         the next line is output on the same screen line as the user input.
 139
 140 2019-03-18  Pedro Alves  <palves@redhat.com>
 141
 142         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 143         New globals.
 144         (apply_style): New, factored out from ...
 145         (apply_ansi_escape): ... this.  Handle reverse video mode.
 146         (tui_set_reverse_mode): New function.
 147         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 148         * tui/tui-winsource.c (tui_show_source_line): Use
 149         tui_set_reverse_mode instead of setting A_STANDOUT.
 150         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 151         New setter methods.
 152
 153 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 154
 155         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 156         Handle tabs.
 157
 158 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 159
 160         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 161         tui_refill_source_window instead of tui_refresh_win, to update the
 162         current execution line.  This fixes redisplay of the current line
 163         when stepping through the code with "next" or "step".
 164
 165 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 166
 167         * source-cache.c (source_cache::get_source_lines): Call
 168         find_source_lines to initialize s->nlines.  This fixes vertical
 169         scrolling of TUI source window when the DOWN arrow is pressed.
 170
 171 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 172
 173         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 174         wclrtoeol in tui_show_source_line".  This reverts changes made in
 175         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 176
 177 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 178
 179         * NEWS: Combine separate "New targets" sections for 8.3.
 180
 181 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 182
 183         The MS-Windows port of ncurses fails to switch to a color pair if
 184         one or both of the colors are the implicit default colors.  This
 185         change records the default colors when TUI is initialized, and
 186         then specifies them explicitly when a color pair uses the default
 187         colors.  This allows color styling in TUI mode on MS-Windows.
 188
 189         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 190         ncurses_norm_attr.
 191         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 192         colors in ncurses_norm_attr.
 193         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 194         "none", replace it with the default color recorded in
 195         ncurses_norm_attr.
 196
 197 2019-03-14  Tom Tromey  <tromey@adacore.com>
 198
 199         * source-cache.h (class source_cache) <get_source_lines>: Return
 200         std::string.
 201         * source-cache.c (source_cache::extract_lines): Handle case where
 202         first_pos==npos.  Return std::string.
 203         (source_cache::get_source_lines): Update.
 204
 205 2019-03-14  Tom Tromey  <tromey@adacore.com>
 206
 207         * NEWS: Add item for "style sources" commands.
 208         * source-cache.c (source_cache::get_source_lines): Check
 209         source_styling.
 210         * cli/cli-style.c (source_styling): New global.
 211         (_initialize_cli_style): Add "style sources" commands.
 212         (show_style_sources): New function.
 213         * cli/cli-style.h (source_styling): Declare.
 214
 215 2019-03-14  Pedro Alves  <palves@redhat.com>
 216             Tom Tromey  <tromey@adacore.com>
 217
 218         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 219         * tui/tui-winsource.c (tui_refill_source_window): New function,
 220         from...
 221         (tui_horizontal_source_scroll): ... here.  Move some logic.
 222         * cli/cli-style.c (set_style_enabled): Notify new observable.
 223         * tui/tui-hooks.c (tui_redisplay_source): New function.
 224         (tui_attach_detach_observers): Attach or detach
 225         tui_redisplay_source.
 226         * observable.h (source_styling_changed): New observable.
 227         * observable.c: Define source_styling_changed observable.
 228
 229 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 230
 231         PR/24325
 232         * source-cache.c: #undef open and close, to avoid unresolved
 233         externals during linking.
 234
 235 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 236
 237         Support styling on native MS-Windows console
 238
 239         PR/24315
 240         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 241         on MS-Windows if $TERM is not defined.
 242
 243         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 244
 245         * posix-hdep.c (gdb_console_fputs):
 246         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 247         functions.
 248         * ui-file.h (gdb_console_fputs): Add prototype.
 249
 250         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 251         back to fputs only if the former returns zero.
 252
 253 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 254             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 255
 256         PR gdb/8527
 257         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 258         set_sigint_trap, clear_sigint_trap.
 259
 260 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 261
 262         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 263         for-loop range, to avoid compiler warnings.
 264
 265         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 266         avoid compiler warnings about unused variables.
 267
 268 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 269
 270         * NEWS: Mention end of support for native debugging on MS-Windows
 271         before XP.
 272
 273 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 274
 275         PR gdb/24292
 276         * common/netstuff.c:
 277         * gdbserver/gdbreplay.c
 278         * gdbserver/remote-utils.c:
 279         * ser-tcp.c:
 280         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 281         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 282         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 283         'getaddrinfo' and 'freeaddrinfo' were not available before
 284         Windows XP, and mingw.org's MinGW headers by default define
 285         _WIN32_WINNT to 0x500.
 286
 287 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 288
 289         * NEWS: Note minimum Python version.
 290
 291 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 292
 293         * version.in: Set GDB version number to 8.2.90.DATE-git.
 294
 295 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 296
 297         GDB 8.2.90 released.
 298
 299 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 300
 301         * version.in: Set GDB version number to 8.2.90.
 302
 303 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 304
 305         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 306
 307 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 308
 309         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 310         * version.in: Bump version to 8.2.90.DATE-git.
 311
 312 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 313
 314         * aix-thread.c (ptid_cmp): Remove unused variable.
 315         (get_signaled_thread): Likewise.
 316         (store_regs_user_thread): Likewise.
 317         (store_regs_kernel_thread): Likewise.
 318         (fetch_regs_kernel_thread): Remove shadowed variable.
 319
 320 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 321
 322         * features/riscv/32bit-cpu.xml: Add register numbers.
 323         * features/riscv/32bit-fpu.c: Regenerate.
 324         * features/riscv/32bit-fpu.xml: Add register numbers.
 325         * features/riscv/64bit-cpu.xml: Add register numbers.
 326         * features/riscv/64bit-fpu.c: Regenerate.
 327         * features/riscv/64bit-fpu.xml: Add register numbers.
 328
 329 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 330
 331         * NEWS: Mention two argument form of gdb.Value constructor.
 332         * python/py-value.c (convert_buffer_and_type_to_value): New
 333         function.
 334         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 335         Add support for handling an optional second argument.  Call
 336         convert_buffer_and_type_to_value as appropriate.
 337         * python/python-internal.h (Py_buffer_deleter): New struct.
 338         (Py_buffer_up): New typedef.
 339
 340 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 341
 342         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 343         instead of releasing ownership.
 344
 345 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 346
 347         * dwarf2read.c (open_and_init_dwp_file): Call
 348         elf_numsections instead of bfd_count_sections to initialize
 349         dwp_file->num_sections.
 350
 351 2019-02-25  Tom Tromey  <tromey@adacore.com>
 352
 353         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 354
 355 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 356
 357         * gcore.in: Add '--readnever' option when invoking GDB.
 358
 359 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 360
 361         * MAINTAINERS: Update my email address.
 362
 363 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 364
 365         * build-id.c (build_id_to_debug_bfd_1): New function.
 366         (build_id_to_debug_bfd): Look for separate debug file in
 367         sysroot.
 368
 369 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 370
 371         * gdbarch.sh: Update the copyright year range that is placed into
 372         generated files.
 373
 374 2019-02-22  Keith Seitz  <keiths@redhat.com>
 375
 376         PR symtab/23853
 377         * linespec.c (create_sals_line_offset): Search for the default
 378         symtab's filename instead of its fullname.
 379
 380 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 381
 382         * NEWS: Update style defaults.
 383
 384 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 385
 386         * main.c (captured_main_1): Disable styling in batch mode.
 387
 388 2019-02-20  Tom Tromey  <tom@tromey.com>
 389
 390         * symtab.c (symtab_symbol_info): Fix typos.
 391
 392 2019-02-20  Tom Tromey  <tromey@adacore.com>
 393
 394         * findcmd.c (_initialize_mem_search): Use upper case for
 395         metasyntactic variables.
 396
 397 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 398
 399         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 400         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 401
 402 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 403
 404         * top.h (source_file_name): Change to std::string.
 405         * top.c (source_file_name): Likewise.
 406         (command_line_input): Adjust.
 407         * cli/cli-script.c (script_from_file): Adjust.
 408
 409 2019-02-19  Tom Tromey  <tromey@adacore.com>
 410
 411         * ravenscar-thread.c
 412         (ravenscar_thread_target::update_thread_list): Don't call
 413         ada_build_task_list.
 414         * ada-lang.h (ada_build_task_list): Don't declare.
 415         * ada-tasks.c (struct ada_tasks_inferior_data)
 416         <task_list_valid_p>: Now bool.
 417         (read_known_tasks, ada_task_list_changed)
 418         (ada_tasks_invalidate_inferior_data): Update.
 419         (read_known_tasks_array): Return bool.
 420         (read_known_tasks_list): Likewise.
 421         (read_known_tasks): Return void.
 422         (ada_build_task_list): Now static.
 423
 424 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 425
 426         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 427         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 428
 429 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 430
 431         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 432         variant for ada_tasks_pspace_data_handle and
 433         ada_tasks_inferior_data_handle.
 434         (ada_tasks_pspace_data_cleanup): New function.
 435         (ada_tasks_inferior_data_cleanup): New function.
 436
 437 2019-02-17  Tom Tromey  <tom@tromey.com>
 438
 439         * macrotab.h (macro_source_fullname): Return a std::string.
 440         * macrotab.c (macro_include, check_for_redefinition)
 441         (macro_undef, macro_lookup_definition, foreach_macro)
 442         (foreach_macro_in_scope): Update.
 443         (macro_source_fullname): Return a std::string.
 444         * macrocmd.c (show_pp_source_pos): Update.
 445
 446 2019-02-17  Tom Tromey  <tom@tromey.com>
 447
 448         * macrocmd.c (show_pp_source_pos): Style the file names.
 449
 450 2019-02-17  Tom Tromey  <tom@tromey.com>
 451
 452         PR tui/24197:
 453         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 454
 455 2019-02-17  Tom Tromey  <tom@tromey.com>
 456
 457         * ada-lang.c (user_select_syms): Use filtered printing.
 458         * utils.c (wrap_style): New global.
 459         (desired_style): Remove.
 460         (emit_style_escape): Add stream parameter.
 461         (set_output_style, reset_terminal_style, prompt_for_continue):
 462         Update.
 463         (flush_wrap_buffer): Only flush gdb_stdout.
 464         (wrap_here): Set wrap_style.
 465         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 466         treat escape sequences as a character.  Change when wrap buffer is
 467         flushed.
 468         (fputs_styled): Do not set the output style when the default is
 469         requested.
 470         * ui-style.h (struct ui_file_style) <is_default>: New method.
 471         * source.c (print_source_lines_base): Emit escape sequences in one
 472         piece.
 473
 474 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 475
 476         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 477         integers and enumeration types.
 478
 479 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 480
 481         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 482         instead of lookup_symbol_in_language
 483         (do_exact_match): New function.
 484         (ada_get_symbol_name_matcher): Return do_exact_match when
 485         doing a verbatim match.
 486
 487 2019-02-15  Tom Tromey  <tromey@adacore.com>
 488
 489         * ravenscar-thread.c (ravenscar_thread_target::resume)
 490         (ravenscar_thread_target::wait): Special case wildcard requests.
 491
 492 2019-02-15  Tom Tromey  <tromey@adacore.com>
 493
 494         * ravenscar-thread.c (base_ptid): Remove.
 495         (struct ravenscar_thread_target) <close>: New method.
 496         <m_base_ptid>: New member.
 497         <update_inferior_ptid, active_task, task_is_currently_active,
 498         runtime_initialized>: Declare methods.
 499         <ravenscar_thread_target>: Add constructor.
 500         (ravenscar_thread_target::task_is_currently_active)
 501         (ravenscar_thread_target::update_inferior_ptid)
 502         (ravenscar_runtime_initialized): Rename.  Now methods.
 503         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 504         (ravenscar_thread_target::update_thread_list): Update.
 505         (ravenscar_thread_target::active_task): Now method.
 506         (ravenscar_thread_target::store_registers)
 507         (ravenscar_thread_target::prepare_to_store)
 508         (ravenscar_thread_target::prepare_to_store)
 509         (ravenscar_thread_target::mourn_inferior): Update.
 510         (ravenscar_inferior_created): Use "new" to create target.
 511         (ravenscar_thread_target::get_ada_task_ptid): Update.
 512         (_initialize_ravenscar): Don't initialize base_ptid.
 513         (ravenscar_ops): Remove global.
 514
 515 2019-02-15  Tom Tromey  <tromey@adacore.com>
 516
 517         * target.h (push_target): Declare new overload.
 518         * target.c (push_target): New overload, taking an rvalue reference.
 519         * remote.c (remote_target::open_1): Use push_target overload.
 520         * corelow.c (core_target_open): Use push_target overload.
 521
 522 2019-02-15  Tom Tromey  <tromey@adacore.com>
 523
 524         * ravenscar-thread.c (is_ravenscar_task)
 525         (ravenscar_task_is_currently_active): Return bool.
 526         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 527         (_initialize_ravenscar): Remove "(void)".
 528         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 529         Return bool.
 530
 531 2019-02-15  Tom Tromey  <tromey@adacore.com>
 532
 533         * ravenscar-thread.c (ravenscar_runtime_initializer)
 534         (has_ravenscar_runtime, get_running_thread_id)
 535         (ravenscar_thread_target::resume): Fix indentation.
 536
 537 2019-02-15  Tom Tromey  <tromey@adacore.com>
 538
 539         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 540         from ravenscar_arch_ops.
 541         (sparc_ravenscar_ops::fetch_registers)
 542         (sparc_ravenscar_ops::store_registers): Now methods.
 543         (sparc_ravenscar_prepare_to_store): Remove.
 544         (sparc_ravenscar_ops): Redefine.
 545         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 546         methods and destructor.  Remove members.
 547         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 548         (ravenscar_thread_target::store_registers)
 549         (ravenscar_thread_target::prepare_to_store): Update.
 550         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 551         Remove.
 552         (struct ppc_ravenscar_powerpc_ops): Derive from
 553         ravenscar_arch_ops.
 554         (ppc_ravenscar_powerpc_ops::fetch_registers)
 555         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 556         (ppc_ravenscar_powerpc_ops): Redefine.
 557         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 558         (ppc_ravenscar_e500_ops::fetch_registers)
 559         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 560         (ppc_ravenscar_e500_ops): Redefine.
 561         * aarch64-ravenscar-thread.c
 562         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 563         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 564         (aarch64_ravenscar_fetch_registers)
 565         (aarch64_ravenscar_store_registers): Now methods.
 566         (aarch64_ravenscar_ops): Redefine.
 567
 568 2019-02-15  Tom Tromey  <tromey@adacore.com>
 569
 570         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 571         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 572         (ravenscar_thread_target::stopped_by_watchpoint)
 573         (ravenscar_thread_target::stopped_data_address)
 574         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 575
 576 2019-02-15  Tom Tromey  <tromey@adacore.com>
 577
 578         * ravenscar-thread.c: Fix some typos.
 579
 580 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 581             Tom Tromey  <tromey@adacore.com>
 582
 583         * ada-lang.c (ada_exception_sal): Change addr_string to a
 584         std::string.
 585         (create_ada_exception_catchpoint): Update.
 586
 587 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 588             Tom Tromey  <tromey@adacore.com>
 589
 590         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 591         (bp_location_ops): Remove.
 592         (base_breakpoint_allocate_location): Update.
 593         (free_bp_location): Update.
 594         * ada-lang.c (class ada_catchpoint_location)
 595         <ada_catchpoint_location>: Remove ops parameter.
 596         (ada_catchpoint_location_dtor): Remove.
 597         (ada_catchpoint_location_ops): Remove.
 598         (allocate_location_exception): Update.
 599         * breakpoint.h (struct bp_location_ops): Remove.
 600         (class bp_location) <bp_location>: Remove bp_location_ops
 601         parameter.
 602         <~bp_location>: Add destructor.
 603         <ops>: Remove.
 604
 605 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 606             Pedro Alves  <palves@redhat.com>
 607
 608         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 609         'PATH_MAX'.
 610
 611 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 612             Samuel Thibault  <samuel.thibault@gnu.org>
 613             Thomas Schwinge  <thomas@codesourcery.com>
 614
 615         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 616         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 617
 618 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 619
 620         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 621         (check_empty): Use "const char *".
 622
 623         * gnu-nat.c (gnu_nat_target::detach): Instead of
 624         'detach_inferior (pid)' call
 625         'detach_inferior (find_inferior_pid (pid))'.
 626
 627         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 628         'nat/fork-inferior.o'.
 629         * gnu-nat.c: #include "nat/fork-inferior.h".
 630
 631         * gnu-nat.c (gnu_nat_target::detach): Instead of
 632         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 633         * gnu-nat.h: #include "inf-child.h".
 634         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 635         'i386_gnu_nat_target::fetch_registers'.
 636         (gnu_store_registers): Rename/move to
 637         'i386_gnu_nat_target::store_registers'.
 638
 639         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 640         * gnu-nat.h (mach_thread_info): New function.
 641         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 642
 643         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 644
 645 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 646
 647         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 648
 649 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 650
 651         * windows-nat.c (windows_add_thread): Add new parameter
 652         "main_thread_p" with default value set to false.  Update
 653         function documentation as well as all callers.
 654         (windows_delete_thread): Likewise.
 655         (fake_create_process): Update call to windows_add_thread.
 656         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 657         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 658         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 659         call to windows_delete_thread.
 660
 661 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 662
 663         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 664
 665 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 666
 667         * symfile.c (find_separate_debug_file): Use canonical path of
 668         sysroot with child_path instead of gdb_sysroot if it is valid.
 669
 670 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 671
 672         * symfile.c (find_separate_debug_file): Use child_path to
 673         determine if an object file is under a sysroot.
 674
 675 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 676
 677         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 678         unittests/child-path-selftests.c.
 679         * common/pathstuff.c (child_path): New function.
 680         * common/pathstuff.h (child_path): New prototype.
 681         * unittests/child-path-selftests.c: New file.
 682
 683 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 684
 685         * symfile.c (find_separate_debug_file): Look for separate debug
 686         files in debug directories under the sysroot.
 687
 688 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 689
 690         * symtab.h (struct minimal_symbol data_p): New const method.
 691         (struct minimal_symbol text_p): Likewise.
 692         * symtab.c (output_source_filename): Use file name style
 693         to print file name.
 694         (print_symbol_info): Likewise.
 695         (print_msymbol_info): Use address style to print addresses.
 696         Use function name style to print executable text symbols.
 697         (expand_symtab_containing_pc): Use data_p.
 698         (find_pc_sect_compunit_symtab): Likewise.
 699
 700 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 701
 702         * breakpoint.c (describe_other_breakpoints): Use address style
 703         to print addresses.
 704         (say_where): Likewise.
 705
 706 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 707
 708         * ada-typeprint.c (print_func_type): Print function name
 709         style to print function name.
 710         * c-typeprint.c (c_print_type_1): Likewise.
 711
 712 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 713
 714         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 715         for execve.
 716
 717 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 718
 719         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 720         type_stack.
 721
 722 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 723
 724         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 725         TYPE_CODE_REF types.
 726
 727 2019-02-08  Jim Wilson  <jimw@sifive.com>
 728
 729         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 730         (riscv_linux_fregset): New.
 731         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 732
 733 2019-02-07  Tom Tromey  <tom@tromey.com>
 734
 735         * thread.c (thread_cancel_execution_command): Update.
 736         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 737         methods.
 738         (struct thread_fsm_ops): Remove.
 739         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 740         (thread_fsm_should_stop, thread_fsm_return_value)
 741         (thread_fsm_set_finished, thread_fsm_finished_p)
 742         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 743         Don't declare.
 744         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 745         * infrun.c (clear_proceed_status_thread)
 746         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 747         (print_stop_event): Update.
 748         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 749         Add constructor.
 750         (step_command_fsm_ops): Remove.
 751         (new_step_command_fsm): Remove.
 752         (step_1): Update.
 753         (step_command_fsm::should_stop): Rename from
 754         step_command_fsm_should_stop.
 755         (step_command_fsm::clean_up): Rename from
 756         step_command_fsm_clean_up.
 757         (step_command_fsm::do_async_reply_reason): Rename from
 758         step_command_fsm_async_reply_reason.
 759         (struct until_next_fsm): Inherit from thread_fsm.  Add
 760         constructor.
 761         (until_next_fsm_ops): Remove.
 762         (new_until_next_fsm): Remove.
 763         (until_next_fsm::should_stop): Rename from
 764         until_next_fsm_should_stop.
 765         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 766         (until_next_fsm::do_async_reply_reason): Rename from
 767         until_next_fsm_async_reply_reason.
 768         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 769         constructor.  Change type of breakpoint.
 770         (finish_command_fsm_ops): Remove.
 771         (new_finish_command_fsm): Remove.
 772         (finish_command_fsm::should_stop): Rename from
 773         finish_command_fsm_should_stop.
 774         (finish_command_fsm::clean_up): Rename from
 775         finish_command_fsm_clean_up.
 776         (finish_command_fsm::return_value): Rename from
 777         finish_command_fsm_return_value.
 778         (finish_command_fsm::do_async_reply_reason): Rename from
 779         finish_command_fsm_async_reply_reason.
 780         (finish_command): Update.
 781         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 782         Add constructor.
 783         (call_thread_fsm_ops): Remove.
 784         (call_thread_fsm::call_thread_fsm): Rename from
 785         new_call_thread_fsm.
 786         (call_thread_fsm::should_stop): Rename from
 787         call_thread_fsm_should_stop.
 788         (call_thread_fsm::should_notify_stop): Rename from
 789         call_thread_fsm_should_notify_stop.
 790         (run_inferior_call, call_function_by_hand_dummy): Update.
 791         * cli/cli-interp.c (should_print_stop_to_console): Update.
 792         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 793         Add constructor.  Change type of location_breakpoint,
 794         caller_breakpoint.
 795         (until_break_fsm_ops): Remove.
 796         (new_until_break_fsm): Remove.
 797         (until_break_fsm::should_stop): Rename from
 798         until_break_fsm_should_stop.
 799         (until_break_fsm::clean_up): Rename from
 800         until_break_fsm_clean_up.
 801         (until_break_fsm::do_async_reply_reason): Rename from
 802         until_break_fsm_async_reply_reason.
 803         (until_break_command): Update.
 804         * thread-fsm.c: Remove.
 805         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 806
 807 2019-02-07  Tom Tromey  <tom@tromey.com>
 808
 809         * yy-remap.h: Add include guard.
 810         * xtensa-tdep.h: Add include guard.
 811         * xcoffread.h: Rename include guard.
 812         * varobj-iter.h: Add include guard.
 813         * tui/tui.h: Rename include guard.
 814         * tui/tui-winsource.h: Rename include guard.
 815         * tui/tui-wingeneral.h: Rename include guard.
 816         * tui/tui-windata.h: Rename include guard.
 817         * tui/tui-win.h: Rename include guard.
 818         * tui/tui-stack.h: Rename include guard.
 819         * tui/tui-source.h: Rename include guard.
 820         * tui/tui-regs.h: Rename include guard.
 821         * tui/tui-out.h: Rename include guard.
 822         * tui/tui-layout.h: Rename include guard.
 823         * tui/tui-io.h: Rename include guard.
 824         * tui/tui-hooks.h: Rename include guard.
 825         * tui/tui-file.h: Rename include guard.
 826         * tui/tui-disasm.h: Rename include guard.
 827         * tui/tui-data.h: Rename include guard.
 828         * tui/tui-command.h: Rename include guard.
 829         * tic6x-tdep.h: Add include guard.
 830         * target/waitstatus.h: Rename include guard.
 831         * target/wait.h: Rename include guard.
 832         * target/target.h: Rename include guard.
 833         * target/resume.h: Rename include guard.
 834         * target-float.h: Rename include guard.
 835         * stabsread.h: Add include guard.
 836         * rs6000-tdep.h: Add include guard.
 837         * riscv-fbsd-tdep.h: Add include guard.
 838         * regformats/regdef.h: Rename include guard.
 839         * record.h: Rename include guard.
 840         * python/python.h: Rename include guard.
 841         * python/python-internal.h: Rename include guard.
 842         * python/py-stopevent.h: Rename include guard.
 843         * python/py-ref.h: Rename include guard.
 844         * python/py-record.h: Rename include guard.
 845         * python/py-record-full.h: Rename include guard.
 846         * python/py-record-btrace.h: Rename include guard.
 847         * python/py-instruction.h: Rename include guard.
 848         * python/py-events.h: Rename include guard.
 849         * python/py-event.h: Rename include guard.
 850         * procfs.h: Add include guard.
 851         * proc-utils.h: Add include guard.
 852         * p-lang.h: Add include guard.
 853         * or1k-tdep.h: Rename include guard.
 854         * observable.h: Rename include guard.
 855         * nto-tdep.h: Rename include guard.
 856         * nat/x86-linux.h: Rename include guard.
 857         * nat/x86-linux-dregs.h: Rename include guard.
 858         * nat/x86-gcc-cpuid.h: Add include guard.
 859         * nat/x86-dregs.h: Rename include guard.
 860         * nat/x86-cpuid.h: Rename include guard.
 861         * nat/ppc-linux.h: Rename include guard.
 862         * nat/mips-linux-watch.h: Rename include guard.
 863         * nat/linux-waitpid.h: Rename include guard.
 864         * nat/linux-ptrace.h: Rename include guard.
 865         * nat/linux-procfs.h: Rename include guard.
 866         * nat/linux-osdata.h: Rename include guard.
 867         * nat/linux-nat.h: Rename include guard.
 868         * nat/linux-namespaces.h: Rename include guard.
 869         * nat/linux-btrace.h: Rename include guard.
 870         * nat/glibc_thread_db.h: Rename include guard.
 871         * nat/gdb_thread_db.h: Rename include guard.
 872         * nat/gdb_ptrace.h: Rename include guard.
 873         * nat/fork-inferior.h: Rename include guard.
 874         * nat/amd64-linux-siginfo.h: Rename include guard.
 875         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 876         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 877         * nat/aarch64-linux.h: Rename include guard.
 878         * nat/aarch64-linux-hw-point.h: Rename include guard.
 879         * mn10300-tdep.h: Add include guard.
 880         * mips-linux-tdep.h: Add include guard.
 881         * mi/mi-parse.h: Rename include guard.
 882         * mi/mi-out.h: Rename include guard.
 883         * mi/mi-main.h: Rename include guard.
 884         * mi/mi-interp.h: Rename include guard.
 885         * mi/mi-getopt.h: Rename include guard.
 886         * mi/mi-console.h: Rename include guard.
 887         * mi/mi-common.h: Rename include guard.
 888         * mi/mi-cmds.h: Rename include guard.
 889         * mi/mi-cmd-break.h: Rename include guard.
 890         * m2-lang.h: Add include guard.
 891         * location.h: Rename include guard.
 892         * linux-record.h: Rename include guard.
 893         * linux-nat.h: Add include guard.
 894         * linux-fork.h: Add include guard.
 895         * i386-darwin-tdep.h: Rename include guard.
 896         * hppa-linux-offsets.h: Add include guard.
 897         * guile/guile.h: Rename include guard.
 898         * guile/guile-internal.h: Rename include guard.
 899         * gnu-nat.h: Rename include guard.
 900         * gdb-stabs.h: Rename include guard.
 901         * frv-tdep.h: Add include guard.
 902         * f-lang.h: Add include guard.
 903         * event-loop.h: Add include guard.
 904         * darwin-nat.h: Rename include guard.
 905         * cp-abi.h: Rename include guard.
 906         * config/sparc/nm-sol2.h: Rename include guard.
 907         * config/nm-nto.h: Rename include guard.
 908         * config/nm-linux.h: Add include guard.
 909         * config/i386/nm-i386gnu.h: Rename include guard.
 910         * config/djgpp/nl_types.h: Rename include guard.
 911         * config/djgpp/langinfo.h: Rename include guard.
 912         * compile/gcc-cp-plugin.h: Add include guard.
 913         * compile/gcc-c-plugin.h: Add include guard.
 914         * compile/compile.h: Rename include guard.
 915         * compile/compile-object-run.h: Rename include guard.
 916         * compile/compile-object-load.h: Rename include guard.
 917         * compile/compile-internal.h: Rename include guard.
 918         * compile/compile-cplus.h: Rename include guard.
 919         * compile/compile-c.h: Rename include guard.
 920         * common/xml-utils.h: Rename include guard.
 921         * common/x86-xstate.h: Rename include guard.
 922         * common/version.h: Rename include guard.
 923         * common/vec.h: Rename include guard.
 924         * common/tdesc.h: Rename include guard.
 925         * common/selftest.h: Rename include guard.
 926         * common/scoped_restore.h: Rename include guard.
 927         * common/scoped_mmap.h: Rename include guard.
 928         * common/scoped_fd.h: Rename include guard.
 929         * common/safe-iterator.h: Rename include guard.
 930         * common/run-time-clock.h: Rename include guard.
 931         * common/refcounted-object.h: Rename include guard.
 932         * common/queue.h: Rename include guard.
 933         * common/ptid.h: Rename include guard.
 934         * common/print-utils.h: Rename include guard.
 935         * common/preprocessor.h: Rename include guard.
 936         * common/pathstuff.h: Rename include guard.
 937         * common/observable.h: Rename include guard.
 938         * common/netstuff.h: Rename include guard.
 939         * common/job-control.h: Rename include guard.
 940         * common/host-defs.h: Rename include guard.
 941         * common/gdb_wait.h: Rename include guard.
 942         * common/gdb_vecs.h: Rename include guard.
 943         * common/gdb_unlinker.h: Rename include guard.
 944         * common/gdb_unique_ptr.h: Rename include guard.
 945         * common/gdb_tilde_expand.h: Rename include guard.
 946         * common/gdb_sys_time.h: Rename include guard.
 947         * common/gdb_string_view.h: Rename include guard.
 948         * common/gdb_splay_tree.h: Rename include guard.
 949         * common/gdb_setjmp.h: Rename include guard.
 950         * common/gdb_ref_ptr.h: Rename include guard.
 951         * common/gdb_optional.h: Rename include guard.
 952         * common/gdb_locale.h: Rename include guard.
 953         * common/gdb_assert.h: Rename include guard.
 954         * common/filtered-iterator.h: Rename include guard.
 955         * common/filestuff.h: Rename include guard.
 956         * common/fileio.h: Rename include guard.
 957         * common/environ.h: Rename include guard.
 958         * common/common-utils.h: Rename include guard.
 959         * common/common-types.h: Rename include guard.
 960         * common/common-regcache.h: Rename include guard.
 961         * common/common-inferior.h: Rename include guard.
 962         * common/common-gdbthread.h: Rename include guard.
 963         * common/common-exceptions.h: Rename include guard.
 964         * common/common-defs.h: Rename include guard.
 965         * common/common-debug.h: Rename include guard.
 966         * common/cleanups.h: Rename include guard.
 967         * common/buffer.h: Rename include guard.
 968         * common/btrace-common.h: Rename include guard.
 969         * common/break-common.h: Rename include guard.
 970         * cli/cli-utils.h: Rename include guard.
 971         * cli/cli-style.h: Rename include guard.
 972         * cli/cli-setshow.h: Rename include guard.
 973         * cli/cli-script.h: Rename include guard.
 974         * cli/cli-interp.h: Rename include guard.
 975         * cli/cli-decode.h: Rename include guard.
 976         * cli/cli-cmds.h: Rename include guard.
 977         * charset-list.h: Add include guard.
 978         * buildsym-legacy.h: Rename include guard.
 979         * bfin-tdep.h: Add include guard.
 980         * ax.h: Rename include guard.
 981         * arm-linux-tdep.h: Add include guard.
 982         * arm-fbsd-tdep.h: Add include guard.
 983         * arch/xtensa.h: Rename include guard.
 984         * arch/tic6x.h: Add include guard.
 985         * arch/i386.h: Add include guard.
 986         * arch/arm.h: Rename include guard.
 987         * arch/arm-linux.h: Rename include guard.
 988         * arch/arm-get-next-pcs.h: Rename include guard.
 989         * arch/amd64.h: Add include guard.
 990         * arch/aarch64-insn.h: Rename include guard.
 991         * arch-utils.h: Rename include guard.
 992         * annotate.h: Add include guard.
 993         * amd64-darwin-tdep.h: Rename include guard.
 994         * aarch64-linux-tdep.h: Add include guard.
 995         * aarch64-fbsd-tdep.h: Add include guard.
 996         * aarch32-linux-nat.h: Add include guard.
 997
 998 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 999
1000         * macrotab.c (macro_define_internal): New function that
1001         factorizes macro_define_object_internal and macro_define_function
1002         code.
1003         (macro_define_object_internal): Use macro_define_internal.
1004         (macro_define_function): Likewise.
1005
1006 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1007
1008         * macrocmd.c (extract_identifier): Return
1009         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1010         callers.
1011
1012 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1013
1014         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1015
1016 2019-02-05  Tom Tromey  <tom@tromey.com>
1017
1018         * target.c (target_stack::unpush): Move assertion earlier.
1019
1020 2019-01-30  Tom Tromey  <tom@tromey.com>
1021
1022         PR python/23615:
1023         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1024         (gdbpy_parse_and_eval): Likewise.
1025         * python/python-internal.h (gdbpy_allow_threads): New class.
1026
1027 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1028
1029         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1030         (aarch64_fbsd_fpregmap): Move earlier.
1031         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1032         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1033         instead of individual calls to trad_frame_set_reg_addr.
1034         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1035         earlier.
1036         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1037         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1038         instead of individual calls to trad_frame_set_reg_addr.
1039
1040 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1041
1042         * CONTRIBUTE: Replace contribution list with wiki link.
1043
1044 2019-01-25  Tom Tromey  <tom@tromey.com>
1045
1046         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1047
1048 2019-01-25  Tom Tromey  <tom@tromey.com>
1049
1050         * xtensa-linux-nat.c: Fix common/ includes.
1051         * xml-support.h: Fix common/ includes.
1052         * xml-support.c: Fix common/ includes.
1053         * x86-linux-nat.c: Fix common/ includes.
1054         * windows-nat.c: Fix common/ includes.
1055         * varobj.h: Fix common/ includes.
1056         * varobj.c: Fix common/ includes.
1057         * value.c: Fix common/ includes.
1058         * valops.c: Fix common/ includes.
1059         * utils.c: Fix common/ includes.
1060         * unittests/xml-utils-selftests.c: Fix common/ includes.
1061         * unittests/utils-selftests.c: Fix common/ includes.
1062         * unittests/unpack-selftests.c: Fix common/ includes.
1063         * unittests/tracepoint-selftests.c: Fix common/ includes.
1064         * unittests/style-selftests.c: Fix common/ includes.
1065         * unittests/string_view-selftests.c: Fix common/ includes.
1066         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1067         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1068         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1069         * unittests/rsp-low-selftests.c: Fix common/ includes.
1070         * unittests/parse-connection-spec-selftests.c: Fix common/
1071         includes.
1072         * unittests/optional-selftests.c: Fix common/ includes.
1073         * unittests/offset-type-selftests.c: Fix common/ includes.
1074         * unittests/observable-selftests.c: Fix common/ includes.
1075         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1076         * unittests/memrange-selftests.c: Fix common/ includes.
1077         * unittests/memory-map-selftests.c: Fix common/ includes.
1078         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1079         * unittests/function-view-selftests.c: Fix common/ includes.
1080         * unittests/environ-selftests.c: Fix common/ includes.
1081         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1082         * unittests/common-utils-selftests.c: Fix common/ includes.
1083         * unittests/cli-utils-selftests.c: Fix common/ includes.
1084         * unittests/array-view-selftests.c: Fix common/ includes.
1085         * ui-file.c: Fix common/ includes.
1086         * tui/tui-io.c: Fix common/ includes.
1087         * tracepoint.h: Fix common/ includes.
1088         * tracepoint.c: Fix common/ includes.
1089         * tracefile-tfile.c: Fix common/ includes.
1090         * top.h: Fix common/ includes.
1091         * top.c: Fix common/ includes.
1092         * thread.c: Fix common/ includes.
1093         * target/waitstatus.h: Fix common/ includes.
1094         * target/waitstatus.c: Fix common/ includes.
1095         * target.h: Fix common/ includes.
1096         * target.c: Fix common/ includes.
1097         * target-memory.c: Fix common/ includes.
1098         * target-descriptions.c: Fix common/ includes.
1099         * symtab.h: Fix common/ includes.
1100         * symfile.c: Fix common/ includes.
1101         * stap-probe.c: Fix common/ includes.
1102         * spu-linux-nat.c: Fix common/ includes.
1103         * sparc-nat.c: Fix common/ includes.
1104         * source.c: Fix common/ includes.
1105         * solib.c: Fix common/ includes.
1106         * solib-target.c: Fix common/ includes.
1107         * ser-unix.c: Fix common/ includes.
1108         * ser-tcp.c: Fix common/ includes.
1109         * ser-pipe.c: Fix common/ includes.
1110         * ser-base.c: Fix common/ includes.
1111         * selftest-arch.c: Fix common/ includes.
1112         * s12z-tdep.c: Fix common/ includes.
1113         * rust-exp.y: Fix common/ includes.
1114         * rs6000-aix-tdep.c: Fix common/ includes.
1115         * riscv-tdep.c: Fix common/ includes.
1116         * remote.c: Fix common/ includes.
1117         * remote-notif.h: Fix common/ includes.
1118         * remote-fileio.h: Fix common/ includes.
1119         * remote-fileio.c: Fix common/ includes.
1120         * regcache.h: Fix common/ includes.
1121         * regcache.c: Fix common/ includes.
1122         * record-btrace.c: Fix common/ includes.
1123         * python/python.c: Fix common/ includes.
1124         * python/py-type.c: Fix common/ includes.
1125         * python/py-inferior.c: Fix common/ includes.
1126         * progspace.h: Fix common/ includes.
1127         * producer.c: Fix common/ includes.
1128         * procfs.c: Fix common/ includes.
1129         * proc-api.c: Fix common/ includes.
1130         * printcmd.c: Fix common/ includes.
1131         * ppc-linux-nat.c: Fix common/ includes.
1132         * parser-defs.h: Fix common/ includes.
1133         * osdata.c: Fix common/ includes.
1134         * obsd-nat.c: Fix common/ includes.
1135         * nat/x86-linux.c: Fix common/ includes.
1136         * nat/x86-linux-dregs.c: Fix common/ includes.
1137         * nat/x86-dregs.h: Fix common/ includes.
1138         * nat/x86-dregs.c: Fix common/ includes.
1139         * nat/ppc-linux.c: Fix common/ includes.
1140         * nat/mips-linux-watch.h: Fix common/ includes.
1141         * nat/mips-linux-watch.c: Fix common/ includes.
1142         * nat/linux-waitpid.c: Fix common/ includes.
1143         * nat/linux-ptrace.h: Fix common/ includes.
1144         * nat/linux-ptrace.c: Fix common/ includes.
1145         * nat/linux-procfs.c: Fix common/ includes.
1146         * nat/linux-personality.c: Fix common/ includes.
1147         * nat/linux-osdata.c: Fix common/ includes.
1148         * nat/linux-namespaces.c: Fix common/ includes.
1149         * nat/linux-btrace.h: Fix common/ includes.
1150         * nat/linux-btrace.c: Fix common/ includes.
1151         * nat/fork-inferior.c: Fix common/ includes.
1152         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1153         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1154         * nat/aarch64-linux.c: Fix common/ includes.
1155         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1156         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1157         * namespace.h: Fix common/ includes.
1158         * mips-linux-tdep.c: Fix common/ includes.
1159         * minsyms.c: Fix common/ includes.
1160         * mi/mi-parse.h: Fix common/ includes.
1161         * mi/mi-main.c: Fix common/ includes.
1162         * mi/mi-cmd-env.c: Fix common/ includes.
1163         * memrange.h: Fix common/ includes.
1164         * memattr.c: Fix common/ includes.
1165         * maint.h: Fix common/ includes.
1166         * maint.c: Fix common/ includes.
1167         * main.c: Fix common/ includes.
1168         * machoread.c: Fix common/ includes.
1169         * location.c: Fix common/ includes.
1170         * linux-thread-db.c: Fix common/ includes.
1171         * linux-nat.c: Fix common/ includes.
1172         * linux-fork.c: Fix common/ includes.
1173         * inline-frame.c: Fix common/ includes.
1174         * infrun.c: Fix common/ includes.
1175         * inflow.c: Fix common/ includes.
1176         * inferior.h: Fix common/ includes.
1177         * inferior.c: Fix common/ includes.
1178         * infcmd.c: Fix common/ includes.
1179         * inf-ptrace.c: Fix common/ includes.
1180         * inf-child.c: Fix common/ includes.
1181         * ia64-linux-nat.c: Fix common/ includes.
1182         * i387-tdep.c: Fix common/ includes.
1183         * i386-tdep.c: Fix common/ includes.
1184         * i386-linux-tdep.c: Fix common/ includes.
1185         * i386-linux-nat.c: Fix common/ includes.
1186         * i386-go32-tdep.c: Fix common/ includes.
1187         * i386-fbsd-tdep.c: Fix common/ includes.
1188         * i386-fbsd-nat.c: Fix common/ includes.
1189         * guile/scm-type.c: Fix common/ includes.
1190         * guile/guile.c: Fix common/ includes.
1191         * go32-nat.c: Fix common/ includes.
1192         * gnu-nat.c: Fix common/ includes.
1193         * gdbthread.h: Fix common/ includes.
1194         * gdbarch-selftests.c: Fix common/ includes.
1195         * gdb_usleep.c: Fix common/ includes.
1196         * gdb_select.h: Fix common/ includes.
1197         * gdb_bfd.c: Fix common/ includes.
1198         * gcore.c: Fix common/ includes.
1199         * fork-child.c: Fix common/ includes.
1200         * findvar.c: Fix common/ includes.
1201         * fbsd-nat.c: Fix common/ includes.
1202         * event-top.c: Fix common/ includes.
1203         * event-loop.c: Fix common/ includes.
1204         * dwarf2read.c: Fix common/ includes.
1205         * dwarf2loc.c: Fix common/ includes.
1206         * dwarf2-frame.c: Fix common/ includes.
1207         * dwarf-index-cache.c: Fix common/ includes.
1208         * dtrace-probe.c: Fix common/ includes.
1209         * disasm-selftests.c: Fix common/ includes.
1210         * defs.h: Fix common/ includes.
1211         * csky-tdep.c: Fix common/ includes.
1212         * cp-valprint.c: Fix common/ includes.
1213         * cp-support.h: Fix common/ includes.
1214         * cp-support.c: Fix common/ includes.
1215         * corelow.c: Fix common/ includes.
1216         * completer.h: Fix common/ includes.
1217         * completer.c: Fix common/ includes.
1218         * compile/compile.c: Fix common/ includes.
1219         * compile/compile-loc2c.c: Fix common/ includes.
1220         * compile/compile-cplus-types.c: Fix common/ includes.
1221         * compile/compile-cplus-symbols.c: Fix common/ includes.
1222         * command.h: Fix common/ includes.
1223         * cli/cli-dump.c: Fix common/ includes.
1224         * cli/cli-cmds.c: Fix common/ includes.
1225         * charset.c: Fix common/ includes.
1226         * build-id.c: Fix common/ includes.
1227         * btrace.h: Fix common/ includes.
1228         * btrace.c: Fix common/ includes.
1229         * breakpoint.h: Fix common/ includes.
1230         * breakpoint.c: Fix common/ includes.
1231         * ax.h:
1232         (enum agent_op): Fix common/ includes.
1233         * ax-general.c (struct aop_map): Fix common/ includes.
1234         * ax-gdb.c: Fix common/ includes.
1235         * auxv.c: Fix common/ includes.
1236         * auto-load.c: Fix common/ includes.
1237         * arm-tdep.c: Fix common/ includes.
1238         * arch/riscv.c: Fix common/ includes.
1239         * arch/ppc-linux-common.c: Fix common/ includes.
1240         * arch/i386.c: Fix common/ includes.
1241         * arch/arm.c: Fix common/ includes.
1242         * arch/arm-linux.c: Fix common/ includes.
1243         * arch/arm-get-next-pcs.c: Fix common/ includes.
1244         * arch/amd64.c: Fix common/ includes.
1245         * arch/aarch64.c: Fix common/ includes.
1246         * arch/aarch64-insn.c: Fix common/ includes.
1247         * arch-utils.c: Fix common/ includes.
1248         * amd64-windows-tdep.c: Fix common/ includes.
1249         * amd64-tdep.c: Fix common/ includes.
1250         * amd64-sol2-tdep.c: Fix common/ includes.
1251         * amd64-obsd-tdep.c: Fix common/ includes.
1252         * amd64-nbsd-tdep.c: Fix common/ includes.
1253         * amd64-linux-tdep.c: Fix common/ includes.
1254         * amd64-linux-nat.c: Fix common/ includes.
1255         * amd64-fbsd-tdep.c: Fix common/ includes.
1256         * amd64-fbsd-nat.c: Fix common/ includes.
1257         * amd64-dicos-tdep.c: Fix common/ includes.
1258         * amd64-darwin-tdep.c: Fix common/ includes.
1259         * agent.c: Fix common/ includes.
1260         * ada-lang.h: Fix common/ includes.
1261         * ada-lang.c: Fix common/ includes.
1262         * aarch64-tdep.c: Fix common/ includes.
1263
1264 2019-01-25  Tom Tromey  <tom@tromey.com>
1265
1266         * common/create-version.sh: Use common/version.h.
1267
1268 2019-01-24  Pedro Alves  <palves@redhat.com>
1269
1270         * infrun.c (signal_stop, signal_print, signal_program)
1271         (signal_catch, signal_pass): Now arrays instead of pointers.
1272         (update_signals_program_target, do_target_resume)
1273         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1274         * linux-nat.c (linux_nat_target::pass_signals)
1275         (linux_nat_target::create_inferior, linux_nat_target::attach):
1276         Adjust.
1277         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1278         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1279         * procfs.c (procfs_target::pass_signals): Adjust.
1280         * record-full.c (record_full_target::resume): Adjust.
1281         * remote.c (remote_target::pass_signals)
1282         (remote_target::program_signals): Adjust.
1283         * target-debug.h (target_debug_print_signals): Now takes a
1284         gdb::array_view as parameter.  Adjust.
1285         * target.h (target_ops) <pass_signals, program_signals>: Replace
1286         pointer and length parameters with gdb::array_view.
1287         (target_pass_signals, target_program_signals): Likewise.
1288         * target-delegates.c: Regenerate.
1289
1290 2019-01-24  Pedro Alves  <palves@redhat.com>
1291
1292         * common/forward-scope-exit.h
1293         (forward_scope_exit::forward_scope_exit): Pass arguments to
1294         m_bind_function directly, instead of creating a std::bind and
1295         copying that.
1296
1297 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1298
1299         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1300         for static members.
1301         (pass_in_v_vfp_candidate): Likewise.
1302
1303 2019-01-23  Tom Tromey  <tom@tromey.com>
1304             Pedro Alves  <palves@redhat.com>
1305
1306         * regcache.c (class regcache_invalidator): Remove.
1307         (regcache::raw_write): Use make_scope_exit.
1308
1309 2019-01-23  Tom Tromey  <tom@tromey.com>
1310
1311         * ui-out.h (class ui_out_emit_type): Update comment.
1312
1313 2019-01-23  Tom Tromey  <tom@tromey.com>
1314
1315         * infrun.c (fetch_inferior_event): Update comment.
1316
1317 2019-01-23  Tom Tromey  <tom@tromey.com>
1318             Pedro Alves  <palves@redhat.com>
1319
1320         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1321         parameter.
1322         (fetch_inferior_event): Use SCOPE_EXIT.
1323
1324
1325 2019-01-23  Tom Tromey  <tom@tromey.com>
1326             Pedro Alves  <palves@redhat.com>
1327
1328         * infrun.c (disable_thread_events): Delete.
1329         (stop_all_threads): Use SCOPE_EXIT.
1330
1331 2019-01-23  Tom Tromey  <tom@tromey.com>
1332             Pedro Alves  <palves@redhat.com>
1333
1334         * symfile.c: Include forward-scope-exit.h.
1335         (clear_symtab_users_cleanup): Replace forward declaration with
1336         a FORWARD_SCOPE_EXIT.
1337         (syms_from_objfile_1): Use the forward_scope_exit and
1338         gdb::optional instead of cleanup_function.
1339         (reread_symbols): Use the forward_scope_exit instead of
1340         cleanup_function.
1341         (clear_symtab_users_cleanup): Remove function.
1342
1343 2019-01-23  Tom Tromey  <tom@tromey.com>
1344             Pedro Alves  <palves@redhat.com>
1345
1346         * linux-nat.c: Include scope-exit.h.
1347         (cleanup_target_stop): Remove.
1348         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1349         SCOPE_EXIT.
1350
1351 2019-01-23  Tom Tromey  <tom@tromey.com>
1352             Pedro Alves  <palves@redhat.com>
1353
1354         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1355         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1356
1357 2019-01-23  Tom Tromey  <tom@tromey.com>
1358             Andrew Burgess  <andrew.burgess@embecosm.com>
1359             Pedro Alves  <palves@redhat.com>
1360
1361         * infrun.c (fetch_inferior_event): Use scope_exit.
1362         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1363         * top.c (execute_command): Use scope_exit.
1364         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1365         * utils.c (do_bpstat_clear_actions_cleanup)
1366         (make_bpstat_clear_actions_cleanup): Remove.
1367
1368 2019-01-23  Tom Tromey  <tom@tromey.com>
1369             Pedro Alves  <palves@redhat.com>
1370
1371         * infrun.c: Include "common/scope-exit.h"
1372         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1373         (wait_for_inferior): Use SCOPE_EXIT.
1374         (fetch_inferior_event): Use scope_exit.
1375
1376 2019-01-23  Tom Tromey  <tom@tromey.com>
1377             Pedro Alves  <palves@redhat.com>
1378
1379         * breakpoint.c (create_breakpoint): Remove cleanup.
1380
1381 2019-01-23  Tom Tromey  <tom@tromey.com>
1382             Andrew Burgess  <andrew.burgess@embecosm.com>
1383             Pedro Alves  <palves@redhat.com>
1384
1385 2019-01-23  Pedro Alves  <palves@redhat.com>
1386
1387         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1388
1389 2019-01-23  Pedro Alves  <palves@redhat.com>
1390             Andrew Burgess  <andrew.burgess@embecosm.com>
1391
1392         * gdbthread.h: Include "common/forward-scope-exit.h".
1393         (scoped_finish_thread_state): Redefine custom class in terms of
1394         forward_scope_exit.
1395
1396 2019-01-23  Pedro Alves  <palves@redhat.com>
1397             Andrew Burgess  <andrew.burgess@embecosm.com>
1398
1399         * common/forward-scope-exit.h: New file.
1400
1401 2019-01-23  Pedro Alves  <palves@redhat.com>
1402             Andrew Burgess  <andrew.burgess@embecosm.com>
1403             Tom Tromey  <tom@tromey.com>
1404
1405         * common/scope-exit.h: New file.
1406
1407 2019-01-23  Pedro Alves  <palves@redhat.com>
1408
1409         * common/preprocessor.h (ESC): Rename to ...
1410         (ESC_PARENS): ... this.
1411         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1412         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1413
1414 2019-01-23  Tom Tromey  <tom@tromey.com>
1415
1416         * language.h (class scoped_switch_to_sym_language_if_auto):
1417         Initialize m_lang in both cases.
1418
1419 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1420
1421         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1422         with XCNEW.
1423
1424 2019-01-22  Tom Tromey  <tom@tromey.com>
1425
1426         * corelow.c: Do not include sys/file.h.
1427
1428 2019-01-22  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-wingeneral.h: Include gdb_curses.h.
1431
1432 2019-01-22  Tom Tromey  <tom@tromey.com>
1433
1434         * source-cache.h (class source_cache) <get_source_lines,
1435         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1436
1437 2019-01-22  Tom Tromey  <tom@tromey.com>
1438
1439         * remote-fileio.h (struct remote_target): Declare.
1440
1441 2019-01-22  Tom Tromey  <tom@tromey.com>
1442
1443         * python/py-arch.c: Do not include py-ref.h.
1444         * python/py-bpevent.c: Do not include py-ref.h.
1445         * python/py-cmd.c: Do not include py-ref.h.
1446         * python/py-continueevent.c: Do not include py-ref.h.
1447         * python/py-event.h: Do not include py-ref.h.
1448         * python/py-evtregistry.c: Do not include py-ref.h.
1449         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1450         * python/py-frame.c: Do not include py-ref.h.
1451         * python/py-framefilter.c: Do not include py-ref.h.
1452         * python/py-function.c: Do not include py-ref.h.
1453         * python/py-infevents.c: Do not include py-ref.h.
1454         * python/py-linetable.c: Do not include py-ref.h.
1455         * python/py-objfile.c: Do not include py-ref.h.
1456         * python/py-param.c: Do not include py-ref.h.
1457         * python/py-prettyprint.c: Do not include py-ref.h.
1458         * python/py-progspace.c: Do not include py-ref.h.
1459         * python/py-symbol.c: Do not include py-ref.h.
1460         * python/py-symtab.c: Do not include py-ref.h.
1461         * python/py-type.c: Do not include py-ref.h.
1462         * python/py-unwind.c: Do not include py-ref.h.
1463         * python/py-utils.c: Do not include py-ref.h.
1464         * python/py-value.c: Do not include py-ref.h.
1465         * python/py-varobj.c: Do not include py-ref.h.
1466         * python/py-xmethods.c: Do not include py-ref.h.
1467         * python/python.c: Do not include py-ref.h.
1468         * varobj.c: Do not include py-ref.h.
1469
1470 2019-01-22  Tom Tromey  <tom@tromey.com>
1471
1472         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1473         keyword for bcache.
1474
1475 2019-01-22  Tom Tromey  <tom@tromey.com>
1476
1477         * compile/compile-cplus-types.c: Remove a comment by #include.
1478
1479 2019-01-22  Tom Tromey  <tom@tromey.com>
1480
1481         * compile/gcc-c-plugin.h: Include compile-internal.h.
1482
1483 2019-01-22  Tom Tromey  <tom@tromey.com>
1484
1485         * stabsread.c (EXTERN): Do not define.
1486         (symnum, next_symbol_text_func, processing_gcc_compilation)
1487         (within_function, global_sym_chain, global_stabs)
1488         (previous_stab_code, this_object_header_files)
1489         (n_this_object_header_files)
1490         (n_allocated_this_object_header_files): Define.
1491         * stabsread.h (EXTERN): Never define.  Use "extern".
1492
1493 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1494
1495         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1496         history_value.
1497
1498 2019-01-21  Tom Tromey  <tom@tromey.com>
1499
1500         * ui-out.c: Fix includes.
1501         * tui/tui-source.c: Fix includes.
1502         * target.c: Fix includes.
1503         * remote.c: Fix includes.
1504         * regcache.c: Fix includes.
1505         * python/py-block.c: Fix includes.
1506         * printcmd.c: Fix includes.
1507         * or1k-tdep.c: Fix includes.
1508         * mi/mi-main.c: Fix includes.
1509         * m32r-tdep.c: Fix includes.
1510         * csky-tdep.c: Fix includes.
1511         * compile/compile-cplus-types.c: Fix includes.
1512         * cli/cli-interp.c: Fix includes.
1513
1514 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1515
1516         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1517         for padding.
1518
1519 2019-01-16  Tom Tromey  <tom@tromey.com>
1520
1521         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1522         earlier.
1523         (struct objfile) <msymbols_range>: Move from top level.
1524         <msymbols>: New method.
1525         (class objfile_msymbols): Remove.
1526         * symtab.c (default_collect_symbol_completion_matches_break_on):
1527         Update.
1528         * symmisc.c (dump_msymbols): Update.
1529         * stabsread.c (scan_file_globals): Update.
1530         * objc-lang.c (info_selectors_command, info_classes_command)
1531         (find_methods): Update.
1532         * minsyms.c (find_solib_trampoline_target): Update.
1533         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1534         * coffread.c (coff_symfile_read): Update.
1535         * ada-lang.c (ada_lookup_simple_minsym)
1536         (ada_collect_symbol_completion_matches): Update.
1537
1538 2019-01-16  Tom Tromey  <tom@tromey.com>
1539
1540         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1541         type.  Remove no-argument constructor.
1542         <iterator::operator++>: Simplify.
1543         <begin>: Update.
1544         <end>: Use minimal_symbol_count.
1545
1546 2019-01-16  Tom Tromey  <tom@tromey.com>
1547
1548         * objfiles.h (struct objfile) <psymtabs>: New method.
1549         (class objfile_psymtabs): Remove.
1550         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1551         typedef.
1552         <range>: New method.
1553         (require_partial_symbols): Change return type.
1554         * psymtab.c (require_partial_symbols)
1555         (psym_expand_symtabs_matching): Update.
1556         * mdebugread.c (parse_partial_symbols): Update.
1557         * dbxread.c (dbx_end_psymtab): Update.
1558
1559 2019-01-15  Tom Tromey  <tom@tromey.com>
1560
1561         * symtab.c (lookup_objfile_from_block)
1562         (lookup_symbol_in_objfile_symtabs)
1563         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1564         (find_line_symtab, info_sources_command)
1565         (default_collect_symbol_completion_matches_break_on)
1566         (make_source_files_completion_list): Update.
1567         * symmisc.c (print_objfile_statistics, dump_objfile)
1568         (maintenance_print_symbols, maintenance_info_symtabs)
1569         (maintenance_check_symtabs, maintenance_info_line_tables):
1570         Update.
1571         * source.c (select_source_symtab)
1572         (forget_cached_source_info_for_objfile): Update.
1573         * objfiles.h (class objfile_compunits): Remove.
1574         (struct objfile) <compunits_range>: New typedef.
1575         (compunits): New method.
1576         * objfiles.c (objfile_relocate1): Update.
1577         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1578         * maint.c (count_symtabs_and_blocks): Update.
1579         * linespec.c (iterate_over_all_matching_symtabs): Update.
1580         * cp-support.c (add_symbol_overload_list_qualified): Update.
1581         * coffread.c (coff_symtab_read): Update.
1582         * ada-lang.c (add_nonlocal_symbols)
1583         (ada_collect_symbol_completion_matches)
1584         (ada_add_global_exceptions): Update.
1585
1586 2019-01-15  Tom Tromey  <tom@tromey.com>
1587
1588         * progspace.h (program_space) <objfiles_safe_range>: New
1589         typedef.
1590         <objfiles_safe>: New method.
1591         * objfiles.h (class all_objfiles_safe): Remove.
1592         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1593         * jit.c (jit_inferior_exit_hook): Update.
1594
1595 2019-01-17  Tom Tromey  <tom@tromey.com>
1596
1597         * progspace.h (program_space) <objfiles_range>: New typedef.
1598         <objfiles>: New method.
1599         <objfiles_head>: Rename from objfiles.
1600         (object_files): Update.
1601         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1602         * guile/scm-pretty-print.c
1603         (ppscm_find_pretty_printer_from_objfiles): Update.
1604         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1605         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1606         Update.
1607         * python/py-progspace.c (pspy_get_objfiles): Update.
1608         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1609         Update.
1610         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1611         (objfpy_lookup_objfile_by_build_id): Update.
1612         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1613         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1614         Update.
1615         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1616         (expand_symtab_containing_pc, lookup_objfile_from_block)
1617         (lookup_static_symbol, basic_lookup_transparent_type)
1618         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1619         (find_line_symtab, info_sources_command)
1620         (default_collect_symbol_completion_matches_break_on)
1621         (make_source_files_completion_list, find_main_name): Update.
1622         * symmisc.c (print_symbol_bcache_statistics)
1623         (print_objfile_statistics, maintenance_print_symbols)
1624         (maintenance_print_msymbols, maintenance_print_objfiles)
1625         (maintenance_info_symtabs, maintenance_check_symtabs)
1626         (maintenance_expand_symtabs, maintenance_info_line_tables):
1627         Update.
1628         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1629         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1630         (map_overlay_command, unmap_overlay_command)
1631         (simple_overlay_update, expand_symtabs_matching)
1632         (map_symbol_filenames): Update.
1633         * symfile-debug.c (set_debug_symfile): Update.
1634         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1635         Update.
1636         * source.c (select_source_symtab, forget_cached_source_info):
1637         Update.
1638         * solib.c (solib_read_symbols): Update.
1639         * solib-spu.c (append_ocl_sos): Update.
1640         * psymtab.c (maintenance_print_psymbols)
1641         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1642         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1643         * printcmd.c (info_symbol_command): Update.
1644         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1645         Update.
1646         * objfiles.h (class all_objfiles): Remove.
1647         * objfiles.c (have_partial_symbols, have_full_symbols)
1648         (have_minimal_symbols, qsort_cmp, update_section_map)
1649         (shared_objfile_contains_address_p)
1650         (default_iterate_over_objfiles_in_search_order): Update.
1651         * objc-lang.c (info_selectors_command, info_classes_command)
1652         (find_methods): Update.
1653         * minsyms.c (find_solib_trampoline_target): Update.
1654         * maint.c (maintenance_info_sections)
1655         (maintenance_translate_address, count_symtabs_and_blocks):
1656         Update.
1657         * main.c (captured_main_1): Update.
1658         * linux-thread-db.c (try_thread_db_load_from_pdir)
1659         (has_libpthread): Update.
1660         * linespec.c (iterate_over_all_matching_symtabs)
1661         (search_minsyms_for_name): Update.
1662         * jit.c (jit_find_objf_with_entry_addr): Update.
1663         * hppa-tdep.c (find_unwind_entry)
1664         (hppa_lookup_stub_minimal_symbol): Update.
1665         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1666         Update.
1667         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1668         (elf_gnu_ifunc_resolve_by_got): Update.
1669         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1670         * dwarf-index-write.c (save_gdb_index_command): Update.
1671         * cp-support.c (add_symbol_overload_list_qualified): Update.
1672         * breakpoint.c (create_overlay_event_breakpoint)
1673         (create_longjmp_master_breakpoint)
1674         (create_std_terminate_master_breakpoint)
1675         (create_exception_master_breakpoint): Update.
1676         * blockframe.c (find_pc_partial_function): Update.
1677         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1678         (ada_collect_symbol_completion_matches)
1679         (ada_add_global_exceptions): Update.
1680
1681 2019-01-17  Tom Tromey  <tom@tromey.com>
1682
1683         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1684         declare VEC.
1685         (solib_target_parse_libraries): Change return type.
1686         (library_list_start_segment, library_list_start_section)
1687         (library_list_end_library, library_list_start_library); Update.
1688         (solib_target_free_library_list): Remove.
1689         (solib_target_parse_libraries): Remove cleanup.  Change return
1690         type.
1691         (solib_target_current_sos): Update.
1692
1693 2019-01-17  Tom Tromey  <tromey@bapiya>
1694
1695         * valprint.c: Replace "the the" with "the".
1696         * symtab.c: Replace "the the" with "the".
1697         * solib.c: Replace "the the" with "the".
1698         * solib-dsbt.c: Replace "the the" with "the".
1699         * linespec.c: Replace "the the" with "the".
1700         * dwarf2loc.h: Replace "the the" with "the".
1701         * amd64-windows-tdep.c: Replace "the the" with "the".
1702         * aarch64-tdep.c: Replace "the the" with "the".
1703
1704 2019-01-16  Keith Seitz  <keiths@redhat.com>
1705
1706         PR gdb/23773
1707         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1708         <builder>: Rename to ..
1709         <m_builder>: ... this and make private.
1710         (dwarf2_cu::get_builder): New method.  Change all users of
1711         `builder' to use this method.
1712         (dwarf2_start_symtab): Move to ...
1713         (dwarf2_cu::start_symtab): ... here.  Update all callers
1714         (setup_type_unit_groups): Move to ...
1715         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1716         callers.
1717         (dwarf2_cu::reset_builder): New method.
1718         (process_full_compunit, process_full_type_unit): Use
1719         dwarf2_cu::reset_builder.
1720         (follow_die_offset): Record the ancestor CU if it is different
1721         from the followed DIE's CU.
1722         (follow_die_sig_1): Likewise.
1723
1724 2019-01-15  Tom Tromey  <tom@tromey.com>
1725
1726         * remote.c (class remote_state) <buf>: Now a char_vector.
1727         <buf_size>: Remove.
1728         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1729         parameter.
1730         (remote_target::getpkt_or_notif_sane_1)
1731         (remote_target::getpkt_sane)
1732         (remote_target::getpkt_or_notif_sane): Likewise.
1733         (class remote_target) <putpkt>: New overload.
1734         (remote_target::read_frame): Change type of "buf_p".  Remove
1735         sizeof_p parameter.
1736         (packet_ok): New overload.
1737         (packet_check_result): New overload.
1738         Update all uses.
1739
1740 2019-01-14  Tom Tromey  <tom@tromey.com>
1741
1742         * remote-notif.c (handle_notification, remote_notif_ack)
1743         (remote_notif_parse): Make "buf" const.
1744         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1745         const.
1746         (remote_notif_parse, remote_notif_ack, handle_notification):
1747         Likewise.
1748         * remote.c (remote_notif_stop_parse): Make "buf" const.
1749         (remote_target::remote_parse_stop_reply): Make "buf" const.
1750         (remote_notif_stop_ack): Make "buf" const.
1751
1752 2019-01-14  Tom Tromey  <tom@tromey.com>
1753
1754         * remote.c (remote_console_output): Make parameter const.
1755
1756 2019-01-14  Tom Tromey  <tom@tromey.com>
1757
1758         * target-debug.h (target_debug_print_signals): Constify.
1759         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1760         * procfs.c (procfs_target::pass_signals): Update.
1761         * linux-nat.c (linux_nat_target::pass_signals): Update.
1762         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1763         * target-delegates.c: Rebuild.
1764         * remote.c (remote_target::program_signals): Update.
1765         (remote_target::pass_signals): Update.
1766         * target.c (target_pass_signals): Constify argument.
1767         (target_program_signals): Likewise.
1768         * target.h (struct target_ops) <pass_signals, program_signals>:
1769         Constify argument.
1770         (target_pass_signals, target_program_signals): Constify argument.
1771
1772 2019-01-14  Tom Tromey  <tom@tromey.com>
1773
1774         PR tui/28819:
1775         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1776
1777 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1778
1779         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1780         field.
1781         * rs6000-tdep.c: Include reggroups.h.
1782         (IS_V_ALIAS_PSEUDOREG): Define.
1783         (rs6000_register_name): Return names for the "vX" aliases.
1784         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1785         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1786         aliases.  Call default_register_reggroup_p for all other
1787         pseudo-registers.
1788         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1789         New functions.
1790         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1791         Handle "vX" aliases.
1792         (v_alias_pseudo_register_collect): New function.
1793         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1794         (rs6000_gdbarch_init): Initialize "vX" aliases as
1795         pseudo-registers.  Restore registration of
1796         rs6000_pseudo_register_reggroup_p with
1797         set_tdesc_pseudo_register_reggroup_p.
1798
1799 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1800
1801         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1802         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1803         set_gdbarch_num_pseudo_regs.
1804
1805 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1806
1807         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1808         Remove arg prefixname, add do_set and do_show.
1809         Add member functions set_list and show_list.
1810         * cli/cli-style.c (class cli_style_option): Update accordingly.
1811         (style_set_list): Move to file scope.
1812         (style_show_list): Likewise.
1813         (set_style): Call help_list.
1814         (show_style): Call cmd_show_list.
1815         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1816         Update to use the new macro.
1817
1818 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1819
1820         * ada-lang.c (_initialize_ada_language): Expand the help text
1821         for the "catch exception" command.
1822
1823 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1824
1825         * symtab.c (matching_obj_sections): Initialize obj,
1826         declare it closer to its usage.
1827
1828 2019-01-10  Tom Tromey  <tom@tromey.com>
1829
1830         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1831         (basic_inf_threads_range): Remove.
1832         (inf_threads_range, inf_non_exited_threads_range)
1833         (safe_inf_threads_range): Use next_adapter.
1834
1835 2019-01-10  Keith Seitz  <keiths@redhat.com>
1836
1837         PR gdb/23712
1838         PR symtab/23010
1839         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1840         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1841
1842 2019-01-10  Keith Seitz  <keiths@redhat.com>
1843
1844         PR gdb/23712
1845         PR symtab/23010
1846         * dictionary.c (pending_to_vector): Remove.
1847         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1848         Remove _1 suffix, replacing functions of the same name.  Update
1849         all callers.
1850         (dict_create_hashed, dict_create_hashed_expandable)
1851         (dict_create_linear, dict_create_linear_expandable, dict_free)
1852         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1853         Make functions static.
1854
1855 2019-01-10  Keith Seitz  <keiths@redhat.com>
1856
1857         PR gdb/23712
1858         PR symtab/23010
1859         * dictionary.h (struct dictionary): Replace declaration with
1860         multidictionary.
1861         (dict_create_hashed, dict_create_hashed_expandable)
1862         (dict_create_linear, dict_create_linear_expandable)
1863         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1864         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1865         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1866         taking multidictionary argument.
1867         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1868         * block.h (struct block) <dict>: Change to multidictionary
1869         and rename `multidict'.
1870         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1871         symmisc.c: Update all dictionary references to multidictionary.
1872
1873 2019-01-10  Keith Seitz  <keiths@redhat.com>
1874
1875         PR gdb/23712
1876         PR symtab/23010
1877         * dictionary.c: Include unordered_map.
1878         (pending_to_vector): New function.
1879         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1880         Rewrite the non-"_1" functions to take vector instead
1881         of linked list.
1882         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1883         "new" _1 versions of the same name.
1884         (multidictionary): Define.
1885         (std::hash<enum language): New definition.
1886         (collate_pending_symbols_by_language, mdict_create_hashed)
1887         (mdict_create_hashed_expandable, mdict_create_linear)
1888         (mdict_create_linear_expandable, mdict_free)
1889         (find_language_dictionary, create_new_language_dictionary)
1890         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1891         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1892         (mdict_size, mdict_empty): New functions.
1893         * dictionary.h (mdict_iterator): Define.
1894
1895 2019-01-10  Pedro Alves  <palves@redhat.com>
1896
1897         * breakpoint.c (read_uploaded_action)
1898         (create_tracepoint_from_upload): Adjust to use
1899         gdb::unique_xmalloc_ptr.
1900         * ctf.c (ctf_write_uploaded_tp):
1901         (SET_ARRAY_FIELD): Use emplace_back.
1902         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1903         * tracefile-tfile.c (tfile_write_uploaded_tp):
1904         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1905         gdb::unique_xmalloc_ptr.
1906         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1907         at_string, cond_string, cmd_strings>: Replace char pointers
1908         with gdb::unique_xmalloc_ptr.
1909
1910 2019-01-10  Pedro Alves  <palves@redhat.com>
1911
1912         * solib-target.c (library_list_start_library): Don't xstrdup name.
1913
1914 2019-01-10  Pedro Alves  <palves@redhat.com>
1915
1916         * mdebugread.c (parse_partial_symbols): Use
1917         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1918
1919 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1920
1921         * linux-fork.c (scoped_switch_fork_info)
1922         <~scoped_switch_fork_info>: Fix incorrect variable name.
1923
1924 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1925
1926         * linux-fork.c (scoped_switch_fork_info)
1927         <scoped_switch_fork_info>: Make explicit.
1928         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1929
1930 2019-01-10  Tom Tromey  <tom@tromey.com>
1931
1932         * objfiles.h (objfile::reset_psymtabs): Update.
1933         * objfiles.c (objfile::objfile): Update.
1934         * psymtab.h (psymtab_storage::obstack): Update.
1935         (psymtab_storage::m_obstack): Use gdb::optional.
1936         (class psymtab_storage): Update comment.  Remove objfile
1937         parameter.
1938         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1939
1940 2019-01-10  Tom Tromey  <tom@tromey.com>
1941
1942         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1943         <free_psymtabs>: Now private.
1944         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1945         (allocate_psymtab): Use new method.
1946
1947 2019-01-10  Tom Tromey  <tom@tromey.com>
1948
1949         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1950         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1951         * mdebugread.c (parse_partial_symbols): Use
1952         allocate_dependencies.
1953         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1954         allocate_dependencies.
1955         (process_psymtab_comp_unit_reader)
1956         (build_type_psymtab_dependencies): Likewise.
1957         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1958
1959 2019-01-10  Tom Tromey  <tom@tromey.com>
1960
1961         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1962         PSYMBOL_SET_LANGUAGE.
1963         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1964
1965 2019-01-10  Tom Tromey  <tom@tromey.com>
1966
1967         * psymtab.h (psymtab_storage::obstack): New method.
1968         <m_obstack>: Rename from obstack; now private.
1969         * psymtab.c (psymtab_storage): Update.
1970         * dwarf2read.c (create_addrmap_from_index)
1971         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1972         Update.
1973
1974 2019-01-10  Tom Tromey  <tom@tromey.com>
1975
1976         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1977         * objfiles.h (objfile::reset_psymtabs): New method.
1978
1979 2019-01-10  Tom Tromey  <tom@tromey.com>
1980
1981         * symmisc.c (print_symbol_bcache_statistics): Update.
1982         (print_objfile_statistics): Update.
1983         * symfile.c (reread_symbols): Update.
1984         * psymtab.h (class psymtab_storage): New.
1985         * psymtab.c (psymtab_storage): New constructor.
1986         (~psymtab_storage): New destructor.
1987         (require_partial_symbols): Update.
1988         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1989         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1990         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1991         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1992         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1993         (start_psymtab_common, end_psymtab_common)
1994         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1995         (allocate_psymtab): Update.
1996         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1997         Update.
1998         (dump_psymtab_addrmap, maintenance_print_psymbols)
1999         (maintenance_check_psymtabs): Update.
2000         (class objfile_psymtabs): Move to objfiles.h.
2001         * psympriv.h (discard_psymtab): Now inline.
2002         (psymtab_discarder::psymtab_discarder): Update.
2003         (psymtab_discarder::~psymtab_discarder): Update.
2004         (ALL_OBJFILE_PSYMTABS): Rewrite.
2005         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2006         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2007         Remove fields.
2008         <partial_symtabs>: New field.
2009         (class objfile_psymtabs): Move from psymtab.h.  Update.
2010         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2011         psymbol_cache.
2012         (objfile::~objfile): Don't destroy psymbol_cache.
2013         * mdebugread.c (parse_partial_symbols): Update.
2014         * dwarf2read.c (create_addrmap_from_index)
2015         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2016         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2017         (add_partial_subprogram, dwarf2_ranges_read): Update.
2018         * dwarf-index-write.c (write_address_map)
2019         (write_one_signatured_type, recursively_write_psymbols)
2020         (class debug_names, class debug_names, write_psymtabs_to_index):
2021         Update.
2022
2023 2019-01-10  Tom Tromey  <tom@tromey.com>
2024
2025         * symtab.h (SYMBOL_SET_NAMES): Update.
2026         (symbol_set_names): Update.
2027         (MSYMBOL_SET_NAMES): Update.
2028         * symtab.c (symbol_set_names): Change argument to be an
2029         objfile_per_bfd_storage.
2030         * psymtab.c (add_psymbol_to_bcache): Update.
2031         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2032
2033 2019-01-10  Tom Tromey  <tom@tromey.com>
2034
2035         * symtab.c (create_demangled_names_hash): Change argument to be an
2036         objfile_per_bfd_storage.
2037         (symbol_set_names): Update.
2038
2039 2019-01-10  Tom Tromey  <tom@tromey.com>
2040
2041         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2042         init_psymbol_list.
2043         * psymtab.c (init_psymbol_list): Do nothing if already called.
2044         * psympriv.h (init_psymbol_list): Add comment.
2045         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2046         init_psymbol_list.
2047         * dbxread.c (dbx_symfile_read): Unconditionally call
2048         init_psymbol_list.
2049
2050 2019-01-10  Tom Tromey  <tom@tromey.com>
2051
2052         * xcoffread.c (scan_xcoff_symtab): Update.
2053         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2054         "where".
2055         * mdebugread.c (parse_partial_symbols)
2056         (handle_psymbol_enumerators): Update.
2057         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2058         * dbxread.c (read_dbx_symtab): Update.
2059         * psympriv.h (psymbol_placement): New enum.
2060         (add_psymbol_to_list): Update.
2061
2062 2019-01-10  Tom Tromey  <tom@tromey.com>
2063
2064         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2065         static_psymbols parameters.
2066         (scan_xcoff_symtab): Update.
2067         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2068         static_psymbols parameters.
2069         * psympriv.h (start_psymtab_common): Update.
2070         * mdebugread.c (parse_partial_symbols): Update.
2071         * dwarf2read.c (create_partial_symtab): Update.
2072         * dbxread.c (read_dbx_symtab): Update.
2073         (start_psymtab): Remove global_psymbols and static_psymbols
2074         parameters.
2075
2076 2019-01-10  Tom Tromey  <tom@tromey.com>
2077
2078         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2079         * psymtab.c (allocate_psymtab): Add comment.
2080         * psympriv.h (allocate_psymtab): Add comment.
2081         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2082         initializations.
2083         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2084
2085 2019-01-10  Tom Tromey  <tom@tromey.com>
2086
2087         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2088         Don't declare.
2089         * mipsread.c: Include mdebugread.h.
2090         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2091         Declare.
2092         * elfread.c: Include mdebugread.h.
2093
2094 2019-01-09  Tom Tromey  <tom@tromey.com>
2095
2096         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2097         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2098         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2099         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2100         (psym_lookup_symbol, psym_find_last_source_symtab)
2101         (psym_forget_cached_source_info, psym_print_stats)
2102         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2103         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2104         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2105         (psym_find_compunit_symtab_by_address)
2106         (maintenance_print_psymbols, maintenance_info_psymtabs)
2107         (maintenance_check_psymtabs): Use ranged for.
2108         * psymtab.h (class objfile_psymtabs): New.
2109         (require_partial_symbols): Return objfile_psymtabs.
2110         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2111
2112 2019-01-09  Tom Tromey  <tom@tromey.com>
2113
2114         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2115         (find_pc_mapped_section, list_overlays_command)
2116         (map_overlay_command, unmap_overlay_command)
2117         (simple_overlay_update): Use all_objfiles.
2118         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2119         * printcmd.c (info_symbol_command): Use all_objfiles.
2120         * objfiles.h (ALL_OBJSECTIONS): Remove.
2121         * maint.c (maintenance_translate_address): Use all_objfiles.
2122         * gcore.c (gcore_create_callback): Use all_objfiles.
2123         (objfile_find_memory_regions): Likewise.
2124
2125 2019-01-09  Tom Tromey  <tom@tromey.com>
2126
2127         * symtab.c (find_line_symtab, info_sources_command)
2128         (make_source_files_completion_list): Use objfile_compunits.
2129         * source.c (select_source_symtab): Use objfile_compunits.
2130         * objfiles.h (struct objfile): Update comment.
2131         (ALL_OBJFILES): Remove.
2132         (ALL_FILETABS): Remove.
2133         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2134         objfile_compunits.
2135
2136 2019-01-09  Tom Tromey  <tom@tromey.com>
2137
2138         * symmisc.c (print_objfile_statistics, dump_objfile)
2139         (maintenance_print_symbols): Use compunit_filetabs.
2140         * source.c (forget_cached_source_info_for_objfile): Use
2141         compunit_filetabs.
2142         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2143         (ALL_FILETABS): Use compunit_filetabs.
2144         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2145         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2146
2147 2019-01-09  Tom Tromey  <tom@tromey.com>
2148
2149         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2150         (compunit_filetabs): New.
2151         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2152         compunit_filetabs.
2153         (info_sources_command, make_source_files_completion_list): Remove
2154         declaration.
2155         * symmisc.c (print_objfile_statistics, dump_objfile)
2156         (maintenance_print_symbols): Remove declaration.
2157         (maintenance_info_symtabs): Use compunit_filetabs.
2158         (maintenance_info_line_tables): Likewise.
2159         * source.c (select_source_symtab): Change local variable name.
2160         (forget_cached_source_info_for_objfile): Remove declaration.
2161         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2162         * objfiles.c (objfile_relocate1): Remove declaration.
2163         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2164         declaration.
2165         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2166         * coffread.c (coff_symtab_read): Remove declaration.
2167         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2168         compunit_filetabs.
2169
2170 2019-01-09  Tom Tromey  <tom@tromey.com>
2171
2172         * symtab.c (lookup_objfile_from_block)
2173         (find_pc_sect_compunit_symtab, search_symbols)
2174         (default_collect_symbol_completion_matches_break_on): Use
2175         objfile_compunits.
2176         * objfiles.h (ALL_COMPUNITS): Remove.
2177         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2178         * cp-support.c (add_symbol_overload_list_qualified): Use
2179         objfile_compunits.
2180         * ada-lang.c (ada_collect_symbol_completion_matches)
2181         (ada_add_global_exceptions): Use objfile_compunits.
2182
2183 2019-01-09  Tom Tromey  <tom@tromey.com>
2184
2185         * source.c (select_source_symtab)
2186         (forget_cached_source_info_for_objfile): Remove declaration.
2187         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2188         declaration.
2189         * maint.c (count_symtabs_and_blocks): Remove declaration.
2190         * cp-support.c (add_symbol_overload_list_qualified): Remove
2191         declaration.
2192         * coffread.c (coff_symtab_read): Remove declaration.
2193         * symtab.c (lookup_symbol_in_objfile_symtabs)
2194         (basic_lookup_transparent_type_1): Use objfile_compunits.
2195         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2196         (info_sources_command, search_symbols)
2197         (default_collect_symbol_completion_matches_break_on)
2198         (make_source_files_completion_list): Remove declaration.
2199         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2200         (ada_collect_symbol_completion_matches)
2201         (ada_add_global_exceptions): Remove declaration.
2202         * linespec.c (iterate_over_all_matching_symtabs): Use
2203         objfile_compunits.
2204         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2205         (class objfile_compunits): New.
2206         (ALL_COMPUNITS): Use objfile_compunits.
2207         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2208         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2209         objfile_compunits.
2210         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2211
2212 2019-01-09  Tom Tromey  <tom@tromey.com>
2213
2214         * symtab.c (search_symbols)
2215         (default_collect_symbol_completion_matches_break_on): Use
2216         objfile_msymbols.
2217         * ada-lang.c (ada_lookup_simple_minsym)
2218         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2219         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2220         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2221         objfile_msymbols.
2222         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2223         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2224         * objc-lang.c (find_methods): Use objfile_msymbols.
2225         (info_selectors_command, info_classes_command): Likewise.
2226         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2227         * objfiles.h (class objfile_msymbols): New.
2228         (ALL_OBJFILE_MSYMBOLS): Remove.
2229         (ALL_MSYMBOLS): Remove.
2230
2231 2019-01-09  Tom Tromey  <tom@tromey.com>
2232
2233         * common/next-iterator.h (next_adapter): Add Iterator template
2234         parameter.
2235         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2236         (class all_objfiles_safe): New.
2237         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2238         * objfiles.c (put_objfile_before): Update comment.
2239         (add_separate_debug_objfile): Likewise.
2240         (free_all_objfiles): Use all_objfiles_safe.
2241         (objfile_purge_solibs): Likewise.
2242
2243 2019-01-09  Tom Tromey  <tom@tromey.com>
2244
2245         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2246         (expand_symtab_containing_pc, lookup_static_symbol)
2247         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2248         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2249         all_objfiles.
2250         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2251         * breakpoint.c (create_overlay_event_breakpoint)
2252         (create_longjmp_master_breakpoint)
2253         (create_std_terminate_master_breakpoint)
2254         (create_exception_master_breakpoint): Use all_objfiles.
2255         * linux-thread-db.c (try_thread_db_load_from_pdir)
2256         (has_libpthread): Use all_objfiles.
2257         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2258         * linespec.c (iterate_over_all_matching_symtabs)
2259         (search_minsyms_for_name): Use all_objfiles.
2260         * maint.c (maintenance_info_sections): Use all_objfiles.
2261         * main.c (captured_main_1): Use all_objfiles.
2262         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2263         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2264         * guile/scm-pretty-print.c
2265         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2266         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2267         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2268         (maintenance_print_msymbols): Use all_objfiles.
2269         * source.c (select_source_symtab): Use all_objfiles.
2270         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2271         * symfile.c (remove_symbol_file_command)
2272         (expand_symtabs_matching, map_symbol_filenames): Use
2273         all_objfiles.
2274         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2275         all_objfiles.
2276         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2277         * objc-lang.c (find_methods): Use all_objfiles.
2278         * objfiles.c (have_partial_symbols, have_full_symbols)
2279         (have_minimal_symbols, qsort_cmp)
2280         (default_iterate_over_objfiles_in_search_order): Use
2281         all_objfiles.
2282         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2283         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2284         (maintenance_check_psymtabs): Use all_objfiles.
2285         (ALL_PSYMTABS): Remove.
2286         * compile/compile-object-run.c (do_module_cleanup): Use
2287         all_objfiles.
2288         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2289         * cp-support.c (add_symbol_overload_list_qualified): Use
2290         all_objfiles.
2291         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2292         Use all_objfiles.
2293         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2294         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2295         all_objfiles.
2296         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2297         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2298         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2299         Uses all_objfiles.
2300         * solib.c (solib_read_symbols): Use all_objfiles
2301
2302 2019-01-09  Tom Tromey  <tom@tromey.com>
2303
2304         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2305         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2306         all_objfiles.
2307         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2308         * symmisc.c (print_symbol_bcache_statistics)
2309         (print_objfile_statistics, maintenance_print_objfiles)
2310         (maintenance_info_symtabs, maintenance_check_symtabs)
2311         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2312         all_objfiles.
2313         * source.c (forget_cached_source_info): Use all_objfiles.
2314         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2315         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2316         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2317         * objfiles.c (update_section_map): Use all_objfiles.
2318         (shared_objfile_contains_address_p): Likewise.
2319         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2320         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2321
2322 2019-01-09  Tom Tromey  <tom@tromey.com>
2323
2324         * common/next-iterator.h: New file.
2325         * objfiles.h (class all_objfiles): New.
2326         (struct objfile_iterator): New.
2327
2328 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2329
2330         * NEWS: Move the description of the changed "frame", "select-frame",
2331          and "info frame" commands to the Changed commands section.
2332
2333 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2334
2335         * gdbtypes.c (check_stub_method_group): Remove handling of old
2336         mangling schemes.
2337         * linespec.c (find_methods): Likewise.
2338         * stabsread.c (read_member_functions): Likewise.
2339         * valops.c (search_struct_method): Likewise.
2340         (value_struct_elt_for_reference): Likewise.
2341         * NEWS: Mention this change.
2342
2343 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2344
2345         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2346         print_source_lines.
2347         * source.c (print_source_lines_base): Update line number check.
2348         (print_source_lines): New function.
2349         (source_lines_range::source_lines_range): New function.
2350         * source.h (class source_lines_range): New class.
2351         (print_source_lines): New declaration.
2352
2353 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2354
2355         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2356
2357 2019-01-08  Tom Tromey  <tom@tromey.com>
2358             Simon Marchi  <simon.marchi@ericsson.com>
2359
2360         PR gdb/24060
2361         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2362         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2363         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2364         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2365         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2366         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2367
2368 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2369
2370         * source.c (select_source_symtab): Move header comment to
2371         declaration in source.h.
2372         (forget_cached_source_info_for_objfile): Likewise.
2373         (forget_cached_source_info): Likewise.
2374         (identify_source_line): Likewise.
2375         * source.h (identify_source_line): Move declaration from symtab.h
2376         and add comment from source.c
2377         (print_source_lines): Likewise.
2378         (forget_cached_source_info_for_objfile): Likewise.
2379         (forget_cached_source_info): Likewise.
2380         (select_source_symtab): Likewise.
2381         (enum print_source_lines_flag): Move definition from symtab.h.
2382         * symtab.h (identify_source_line): Move declaration to source.h.
2383         (print_source_lines): Likewise.
2384         (forget_cached_source_info_for_objfile): Likewise.
2385         (forget_cached_source_info): Likewise.
2386         (select_source_symtab): Likewise.
2387         (enum print_source_lines_flag): Move definition to source.h.
2388         * tui/tui-hooks.c: Add 'source.h' include.
2389
2390 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * source.c (print_source_lines_base): Handle requests to print
2393         reverse line number sequences, and guard against empty lines
2394         string.
2395
2396 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2397
2398         * source.c (print_source_lines_base): Fix skip of '\r' if next
2399         character is '\n'.
2400
2401 2019-01-06  Tom Tromey  <tom@tromey.com>
2402
2403         * c-exp.y (struct c_parse_state) <macro_original_text,
2404         expansion_obstack>: New member.
2405         (macro_original_text, expansion_obstack): Remove globals.
2406         (scan_macro_expansion, scanning_macro_expansion)
2407         (finished_macro_expansion): Update.
2408         (scan_macro_cleanup): Remove.
2409         (yylex, c_parse): Update.
2410
2411 2019-01-06  Tom Tromey  <tom@tromey.com>
2412
2413         * c-exp.y (struct c_parse_state) <strings>: New member.
2414         (operator_stoken): Update.
2415
2416 2019-01-06  Tom Tromey  <tom@tromey.com>
2417
2418         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2419         (union type_stack_elt) <typelist_val>: Now a pointer to
2420         std::vector.
2421         (type_stack_cleanup): Don't declare.
2422         (push_typelist): Update.
2423         * parse.c (pop_typelist): Return a std::vector.
2424         (push_typelist): Take a std::vector.
2425         (follow_types): Update.  Do not free args.
2426         (type_stack_cleanup): Remove.
2427         * c-exp.y (struct c_parse_state): New.
2428         (cpstate): New global.
2429         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2430         (nonempty_typelist): Update.
2431         (func_mod): Create a new vector.
2432         (c_parse): Create a c_parse_state.
2433         (check_parameter_typelist): Do not delete params.
2434         (function_method): Update.  Do not delete type_list.
2435
2436 2019-01-06  Tom Tromey  <tom@tromey.com>
2437
2438         PR gdb/28155:
2439         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2440         check_typedef.
2441         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2442         (print_return_value): Likewise.
2443
2444 2019-01-05  Tom Tromey  <tom@tromey.com>
2445
2446         * contrib/cleanup_check.py: Remove.
2447         * contrib/gcc-with-excheck: Remove.
2448         * contrib/exsummary.py: Remove.
2449         * contrib/excheck.py: Remove.
2450
2451 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2452
2453         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2454         NULL. Initialize tpprev to NULL instead of assigning it
2455         to NULL on the next statement.
2456         * windows-nat.c (windows_delete_thread): Remove check for
2457         main_thread_id before printing thread exit notifications.
2458         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2459         Remove thread ID check against main_thread_id.
2460         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2461         windows_delete_thread.
2462         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2463
2464 2019-01-04  Tom Tromey  <tom@tromey.com>
2465
2466         * compile/compile.c (_initialize_compile): Use upper case for
2467         metasyntactic variables.
2468         * symmisc.c (_initialize_symmisc): Use upper case for
2469         metasyntactic variables.
2470         * psymtab.c (_initialize_psymtab): Use upper case for
2471         metasyntactic variables.
2472         * demangle.c (demangle_command): Use upper case for metasyntactic
2473         variables.
2474         (_initialize_demangler): Likewise.
2475         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2476         variables.
2477
2478 2019-01-03  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2481
2482 2019-01-03  Tom Tromey  <tom@tromey.com>
2483
2484         * python/py-symtab.c (salpy_str): Update.
2485         (struct salpy_sal_object) <symtab>: Now a PyObject.
2486         (salpy_dealloc): Update.
2487         (del_objfile_sal): Use gdbpy_ref.
2488
2489 2019-01-03  Tom Tromey  <tom@tromey.com>
2490
2491         * python/py-type.c (convert_field): Use new_reference.  Return
2492         gdbpy_ref.
2493         (make_fielditem): Return gdbpy_ref.
2494         (typy_fields): Update.
2495         (typy_getitem): Update.
2496         (field_name): Return gdbpy_ref.  Use new_reference.
2497         (typy_iterator_iternext): Update.
2498
2499 2019-01-03  Tom Tromey  <tom@tromey.com>
2500
2501         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2502
2503 2019-01-03  Tom Tromey  <tom@tromey.com>
2504
2505         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2506         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2507         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2508         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2509         (pspy_set_type_printers): Likewise.
2510         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2511         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2512         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2513         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2514         (objfpy_set_type_printers): Likewise.
2515
2516 2019-01-03  Tom Tromey  <tom@tromey.com>
2517
2518         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2519         (gdbpy_print_stack): Use gdbpy_err_fetch.
2520         * python/python-internal.h (class gdbpy_err_fetch): New class.
2521         (class gdbpy_enter) <m_error_type, m_error_value,
2522         m_error_traceback>: Remove.
2523         <m_error>: New member.
2524         (gdbpy_exception_to_string): Don't declare.
2525         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2526         * python/py-value.c (convert_value_from_python): Use
2527         gdbpy_err_fetch.
2528         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2529         gdbpy_exception_to_string.
2530         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2531         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2532         gdbpy_err_fetch.
2533
2534 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2535
2536         * linux-nat.c (delete_lwp_cleanup): Delete.
2537         (struct lwp_deleter): New struct.
2538         (lwp_info_up): New typedef.
2539         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2540         lwp_info_up.
2541
2542 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2543
2544         * linux-fork.c (class scoped_switch_fork_info): New class.
2545         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2546
2547 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2548
2549         * valops.c (find_overload_match): Remove use of null_cleanup, and
2550         calls to do_cleanups.
2551
2552 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * compile/compile-cplus-types.c
2555         (compile_cplus_instance::decl_name): Handle changes to
2556         cp_func_name.
2557         * cp-support.c (cp_func_name): Update header comment, update
2558         return type.
2559         * cp-support.h (cp_func_name): Update return type in declaration.
2560         * valops.c (find_overload_match): Move temp_func local to top
2561         level of function and change its type.  Use temp_func to hold and
2562         delete temporary string obtained from cp_func_name.
2563
2564 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2567         gdb::char_vector, remove cleanup, and update uses of `msg`.
2568
2569 2019-01-03  Jim Wilson  <jimw@sifive.com>
2570
2571         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2572
2573 2019-01-02  Tom Tromey  <tom@tromey.com>
2574
2575         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2576         (tdesc_parse_xml): Remove cleanups.
2577         * target-descriptions.h (make_cleanup_free_target_description):
2578         Don't declare.
2579         (target_desc_deleter): New struct.
2580         (target_desc_up): New typedef.
2581         * target-descriptions.c (target_desc_deleter::operator()): Rename
2582         from free_target_description.
2583         (make_cleanup_free_target_description): Remove.
2584
2585 2019-01-02  Tom Tromey  <tom@tromey.com>
2586
2587         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2588         constructor, destructor.
2589         (linespec_parser): Remove typedef.
2590         (~linespec_parser): Rename from linespec_parser_delete.
2591         (linespec_lex_to_end, linespec_complete_label)
2592         (linespec_complete): Update.
2593         (decode_line_full): Remove cleanups.
2594         (decode_line_1): Update.
2595
2596 2019-01-02  Tom Tromey  <tom@tromey.com>
2597
2598         * python/python-internal.h (inferior_to_inferior_object): Change
2599         return type.
2600         * python/py-exitedevent.c (create_exited_event_object): Update.
2601         * python/py-inferior.c (inferior_to_inferior_object): Return
2602         gdbpy_ref.
2603         (python_new_inferior, python_inferior_deleted)
2604         (thread_to_thread_object, delete_thread_object)
2605         (build_inferior_list, gdbpy_selected_inferior): Update.
2606         * python/py-infthread.c (create_thread_object): Update.  Also fail
2607         if inferior_to_inferior_object fails.
2608
2609 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2610
2611         * inferior.h (class inferior) <displaced_step_state>: New field.
2612         * infrun.h (struct displaced_step_state): Move here from
2613         infrun.c.  Initialize fields, add constructor.
2614         <inf>: Remove field.
2615         <reset>: New method.
2616         * infrun.c (struct displaced_step_inferior_state): Move to
2617         infrun.h.
2618         (displaced_step_inferior_states): Remove.
2619         (get_displaced_stepping_state): Adust.
2620         (displaced_step_in_progress_any_inferior): Adjust.
2621         (displaced_step_in_progress_thread): Adjust.
2622         (displaced_step_in_progress): Adjust.
2623         (add_displaced_stepping_state): Remove.
2624         (get_displaced_step_closure_by_addr): Adjust.
2625         (remove_displaced_stepping_state): Remove.
2626         (infrun_inferior_exit): Call displaced_step_state.reset.
2627         (use_displaced_stepping): Don't check for NULL.
2628         (displaced_step_prepare_throw): Call
2629         get_displaced_stepping_state.
2630         (displaced_step_fixup): Don't check for NULL.
2631         (prepare_for_detach): Don't check for NULL.
2632
2633 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2634
2635         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2636          in case of call that did not complete.
2637
2638 2019-01-02  Andrey Utkin  <autkin@undo.io>
2639
2640         * symfile.c (find_separate_debug_file): Fix search of debug files for
2641         remote debuggee.
2642
2643 2019-01-02  Tom Tromey  <tom@tromey.com>
2644
2645         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2646         indentation.
2647         * python/py-frame.c (frapy_older): Remove cast.
2648         (frapy_newer): Likewise.
2649         * python/py-breakpoint.c (local_setattro): Remove cast.
2650         * python/py-arch.c (archpy_name): Remove local variable.
2651         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2652
2653 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2654
2655         * unittests/basic_string_view/element_access/char/empty.cc:
2656         Fix year range in copyright header.
2657
2658 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2659
2660         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2661         Delete.
2662         <operator==>: Update with for removed field.
2663         <hash>: Likewise.
2664         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2665         <isa_features>: ...this.
2666         <abi_features>: New field.
2667         (riscv_isa_flen): Update comment.
2668         (riscv_abi_xlen): New declaration.
2669         (riscv_abi_flen): New declaration.
2670         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2671         isa_features.
2672         (riscv_abi_xlen): New function.
2673         (riscv_isa_flen): Update to get answer from isa_features.
2674         (riscv_abi_flen): New function.
2675         (riscv_has_fp_abi): Update to get answer from abi_features.
2676         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2677         xlen and flen.
2678         (riscv_call_info) <xlen, flen>: Update comment.
2679         (riscv_call_arg_struct): Remove invalid assertions
2680         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2681         is removed.
2682         (riscv_gdbarch_init): Gather isa features and abi features
2683         separately, ensure both match on the gdbarch when reusing an old
2684         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2685         a target with 64-bit float hardware.
2686
2687 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2688
2689         * source.c (search_command_helper): Stop reverse search
2690         when line 1 has been searched.
2691
2692 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2693
2694         * record-full.c (record_full_base_target::close): Rewrite
2695         record_full_core_buf_list free logic.
2696
2697 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2698
2699         * break-catch-syscall.c (print_one_catch_syscall): xfree
2700         the last text.
2701
2702 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2703
2704         * top.c (print_gdb_version): Update Copyright year in version
2705         message.
2706
2707 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2708
2709         Update copyright year range in all GDB files.
2710
2711 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2712
2713         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2714
2715 For older changes see ChangeLog-2018.
2716 \f
2717 Local Variables:
2718 mode: change-log
2719 left-margin: 8
2720 fill-column: 74
2721 version-control: never
2722 coding: utf-8
2723 End:
2724