gdb/ChangeLog

   1 2019-08-04  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
   4
   5 2019-05-29  Tom Tromey  <tromey@adacore.com>
   6
   7         PR c++/20020:
   8         * cp-valprint.c (cp_print_value_fields): Call
   9         cp_print_static_field inside "try".
  10
  11 2019-06-10  Tom de Vries  <tdevries@suse.de>
  12
  13         PR symtab/24545
  14         * symtab.c (struct demangled_name_entry): Add language field.
  15         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
  16         static minimal symbol".  Set and use language field.
  17
  18 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
  19
  20         PR gdb/24592
  21         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
  22         function.
  23         (fill_gregset): Call amd64_linux_collect_native_gregset instead
  24         of amd64_collect_native_gregset.
  25         (amd64_linux_nat_target::store_registers): Likewise.
  26
  27 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  28
  29         * version.in: Set GDB version number to 8.3.0.DATE-git.
  30
  31 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  32
  33         GDB 8.3 released.
  34
  35 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  36
  37         * version.in: Set GDB version number to 8.3.
  38
  39 2019-05-08  Tom Tromey  <tromey@adacore.com>
  40
  41         * utils.c (fputs_maybe_filtered): Reset style after paging, even
  42         when no wrap column is set.
  43
  44 2019-05-04  Tom Tromey  <tom@tromey.com>
  45
  46         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  47         (lookup_partial_symbol, print_partial_symbols)
  48         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  49         (psymbol_compare): Update.
  50         (add_psymbol_to_bcache): Clear the entire psymbol.
  51         (maintenance_check_psymtabs): Update.
  52         * psympriv.h (struct partial_symbol): Don't derive from
  53         general_symbol_info.
  54         <obj_section, unrelocated_address, address,
  55         set_unrelocated_address>: Update.
  56         <ginfo>: New member.
  57         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  58         (debug_names::write_psymbols): Update.
  59
  60 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  61
  62         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
  63         level, so that various Windows header files expose the necessary
  64         declarations and definitions.
  65
  66         * symfile.c (find_separate_debug_file): Remove colon from the
  67         drive spec of DOS/Windows file names of the target, so that the
  68         file name produced from DEBUGDIR and the target's directory will
  69         be valid on DOS/Windows systems.
  70
  71 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  72
  73         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  74         Use current_event.dwThreadId instead of main_thread_id.
  75
  76 2019-04-30  Tom Tromey  <tromey@adacore.com>
  77
  78         PR c++/24470:
  79         * dwarf2read.c (process_structure_scope): Handle case where type
  80         has template parameters but no symbol was created.
  81
  82 2019-04-19  Sergei Trofimovich <siarheit@google.com>
  83
  84         * configure.ac: add --enable-source-highlight switch.
  85         * configure: Regenerate.
  86         * top.c (print_gdb_version): plumb --enable-source-highlight
  87         status to "show configuration".
  88
  89 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
  90
  91         PR symtab/24423:
  92         * source.c (print_source_lines_base): Advance "iter" when a
  93         control character is seen.
  94
  95 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  96
  97         * inferior.h (struct infcall_suspend_state_deleter):
  98         Catch exception in destructor to avoid crash.
  99
 100 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 101
 102         * utils.c (prompt_for_continue): Don't restore the styling at the
 103         end, as applied_style has the wrong value.  This fixes styling in
 104         long lists of file names that are interrupted by the "Continue?"
 105         prompt.
 106
 107 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 108
 109         * version.in: Set GDB version number to 8.2.91.DATE-git.
 110
 111 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 112
 113         GDB 8.2.91 released.
 114
 115 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 116
 117         * version.in: Set GDB version number to 8.2.91.
 118
 119 2019-03-20  Tom Tromey  <tromey@adacore.com>
 120
 121         PR gdb/24391
 122         * infrun.c (handle_inferior_event): Rename from
 123         handle_inferior_event_1.  Create a scoped_value_mark.
 124         (handle_inferior_event): Remove.
 125
 126 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 127
 128         * source-cache.c (source_cache::get_source_lines): Re-read
 129         fullname after calling open_source_file.
 130
 131 2019-03-18  Pedro Alves  <palves@redhat.com>
 132             Eli Zaretskii <eliz@gnu.org>
 133
 134         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 135         m_line and m_start_of_line.
 136
 137 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 138
 139         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 140         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 141         it returns a newline.  This fixes a regression in TU mode, whereby
 142         the next line is output on the same screen line as the user input.
 143
 144 2019-03-18  Pedro Alves  <palves@redhat.com>
 145
 146         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 147         New globals.
 148         (apply_style): New, factored out from ...
 149         (apply_ansi_escape): ... this.  Handle reverse video mode.
 150         (tui_set_reverse_mode): New function.
 151         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 152         * tui/tui-winsource.c (tui_show_source_line): Use
 153         tui_set_reverse_mode instead of setting A_STANDOUT.
 154         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 155         New setter methods.
 156
 157 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 158
 159         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 160         Handle tabs.
 161
 162 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 163
 164         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 165         tui_refill_source_window instead of tui_refresh_win, to update the
 166         current execution line.  This fixes redisplay of the current line
 167         when stepping through the code with "next" or "step".
 168
 169 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 170
 171         * source-cache.c (source_cache::get_source_lines): Call
 172         find_source_lines to initialize s->nlines.  This fixes vertical
 173         scrolling of TUI source window when the DOWN arrow is pressed.
 174
 175 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 176
 177         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 178         wclrtoeol in tui_show_source_line".  This reverts changes made in
 179         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 180
 181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 182
 183         * NEWS: Combine separate "New targets" sections for 8.3.
 184
 185 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 186
 187         The MS-Windows port of ncurses fails to switch to a color pair if
 188         one or both of the colors are the implicit default colors.  This
 189         change records the default colors when TUI is initialized, and
 190         then specifies them explicitly when a color pair uses the default
 191         colors.  This allows color styling in TUI mode on MS-Windows.
 192
 193         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 194         ncurses_norm_attr.
 195         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 196         colors in ncurses_norm_attr.
 197         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 198         "none", replace it with the default color recorded in
 199         ncurses_norm_attr.
 200
 201 2019-03-14  Tom Tromey  <tromey@adacore.com>
 202
 203         * source-cache.h (class source_cache) <get_source_lines>: Return
 204         std::string.
 205         * source-cache.c (source_cache::extract_lines): Handle case where
 206         first_pos==npos.  Return std::string.
 207         (source_cache::get_source_lines): Update.
 208
 209 2019-03-14  Tom Tromey  <tromey@adacore.com>
 210
 211         * NEWS: Add item for "style sources" commands.
 212         * source-cache.c (source_cache::get_source_lines): Check
 213         source_styling.
 214         * cli/cli-style.c (source_styling): New global.
 215         (_initialize_cli_style): Add "style sources" commands.
 216         (show_style_sources): New function.
 217         * cli/cli-style.h (source_styling): Declare.
 218
 219 2019-03-14  Pedro Alves  <palves@redhat.com>
 220             Tom Tromey  <tromey@adacore.com>
 221
 222         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 223         * tui/tui-winsource.c (tui_refill_source_window): New function,
 224         from...
 225         (tui_horizontal_source_scroll): ... here.  Move some logic.
 226         * cli/cli-style.c (set_style_enabled): Notify new observable.
 227         * tui/tui-hooks.c (tui_redisplay_source): New function.
 228         (tui_attach_detach_observers): Attach or detach
 229         tui_redisplay_source.
 230         * observable.h (source_styling_changed): New observable.
 231         * observable.c: Define source_styling_changed observable.
 232
 233 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 234
 235         PR/24325
 236         * source-cache.c: #undef open and close, to avoid unresolved
 237         externals during linking.
 238
 239 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 240
 241         Support styling on native MS-Windows console
 242
 243         PR/24315
 244         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 245         on MS-Windows if $TERM is not defined.
 246
 247         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 248
 249         * posix-hdep.c (gdb_console_fputs):
 250         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 251         functions.
 252         * ui-file.h (gdb_console_fputs): Add prototype.
 253
 254         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 255         back to fputs only if the former returns zero.
 256
 257 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 258             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 259
 260         PR gdb/8527
 261         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 262         set_sigint_trap, clear_sigint_trap.
 263
 264 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 265
 266         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 267         for-loop range, to avoid compiler warnings.
 268
 269         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 270         avoid compiler warnings about unused variables.
 271
 272 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 273
 274         * NEWS: Mention end of support for native debugging on MS-Windows
 275         before XP.
 276
 277 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 278
 279         PR gdb/24292
 280         * common/netstuff.c:
 281         * gdbserver/gdbreplay.c
 282         * gdbserver/remote-utils.c:
 283         * ser-tcp.c:
 284         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 285         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 286         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 287         'getaddrinfo' and 'freeaddrinfo' were not available before
 288         Windows XP, and mingw.org's MinGW headers by default define
 289         _WIN32_WINNT to 0x500.
 290
 291 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 292
 293         * NEWS: Note minimum Python version.
 294
 295 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 296
 297         * version.in: Set GDB version number to 8.2.90.DATE-git.
 298
 299 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 300
 301         GDB 8.2.90 released.
 302
 303 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 304
 305         * version.in: Set GDB version number to 8.2.90.
 306
 307 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 308
 309         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 310
 311 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 312
 313         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 314         * version.in: Bump version to 8.2.90.DATE-git.
 315
 316 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 317
 318         * aix-thread.c (ptid_cmp): Remove unused variable.
 319         (get_signaled_thread): Likewise.
 320         (store_regs_user_thread): Likewise.
 321         (store_regs_kernel_thread): Likewise.
 322         (fetch_regs_kernel_thread): Remove shadowed variable.
 323
 324 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 325
 326         * features/riscv/32bit-cpu.xml: Add register numbers.
 327         * features/riscv/32bit-fpu.c: Regenerate.
 328         * features/riscv/32bit-fpu.xml: Add register numbers.
 329         * features/riscv/64bit-cpu.xml: Add register numbers.
 330         * features/riscv/64bit-fpu.c: Regenerate.
 331         * features/riscv/64bit-fpu.xml: Add register numbers.
 332
 333 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 334
 335         * NEWS: Mention two argument form of gdb.Value constructor.
 336         * python/py-value.c (convert_buffer_and_type_to_value): New
 337         function.
 338         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 339         Add support for handling an optional second argument.  Call
 340         convert_buffer_and_type_to_value as appropriate.
 341         * python/python-internal.h (Py_buffer_deleter): New struct.
 342         (Py_buffer_up): New typedef.
 343
 344 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 345
 346         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 347         instead of releasing ownership.
 348
 349 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 350
 351         * dwarf2read.c (open_and_init_dwp_file): Call
 352         elf_numsections instead of bfd_count_sections to initialize
 353         dwp_file->num_sections.
 354
 355 2019-02-25  Tom Tromey  <tromey@adacore.com>
 356
 357         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 358
 359 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 360
 361         * gcore.in: Add '--readnever' option when invoking GDB.
 362
 363 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 364
 365         * MAINTAINERS: Update my email address.
 366
 367 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 368
 369         * build-id.c (build_id_to_debug_bfd_1): New function.
 370         (build_id_to_debug_bfd): Look for separate debug file in
 371         sysroot.
 372
 373 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 374
 375         * gdbarch.sh: Update the copyright year range that is placed into
 376         generated files.
 377
 378 2019-02-22  Keith Seitz  <keiths@redhat.com>
 379
 380         PR symtab/23853
 381         * linespec.c (create_sals_line_offset): Search for the default
 382         symtab's filename instead of its fullname.
 383
 384 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 385
 386         * NEWS: Update style defaults.
 387
 388 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 389
 390         * main.c (captured_main_1): Disable styling in batch mode.
 391
 392 2019-02-20  Tom Tromey  <tom@tromey.com>
 393
 394         * symtab.c (symtab_symbol_info): Fix typos.
 395
 396 2019-02-20  Tom Tromey  <tromey@adacore.com>
 397
 398         * findcmd.c (_initialize_mem_search): Use upper case for
 399         metasyntactic variables.
 400
 401 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 402
 403         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 404         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 405
 406 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 407
 408         * top.h (source_file_name): Change to std::string.
 409         * top.c (source_file_name): Likewise.
 410         (command_line_input): Adjust.
 411         * cli/cli-script.c (script_from_file): Adjust.
 412
 413 2019-02-19  Tom Tromey  <tromey@adacore.com>
 414
 415         * ravenscar-thread.c
 416         (ravenscar_thread_target::update_thread_list): Don't call
 417         ada_build_task_list.
 418         * ada-lang.h (ada_build_task_list): Don't declare.
 419         * ada-tasks.c (struct ada_tasks_inferior_data)
 420         <task_list_valid_p>: Now bool.
 421         (read_known_tasks, ada_task_list_changed)
 422         (ada_tasks_invalidate_inferior_data): Update.
 423         (read_known_tasks_array): Return bool.
 424         (read_known_tasks_list): Likewise.
 425         (read_known_tasks): Return void.
 426         (ada_build_task_list): Now static.
 427
 428 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 429
 430         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 431         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 432
 433 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 434
 435         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 436         variant for ada_tasks_pspace_data_handle and
 437         ada_tasks_inferior_data_handle.
 438         (ada_tasks_pspace_data_cleanup): New function.
 439         (ada_tasks_inferior_data_cleanup): New function.
 440
 441 2019-02-17  Tom Tromey  <tom@tromey.com>
 442
 443         * macrotab.h (macro_source_fullname): Return a std::string.
 444         * macrotab.c (macro_include, check_for_redefinition)
 445         (macro_undef, macro_lookup_definition, foreach_macro)
 446         (foreach_macro_in_scope): Update.
 447         (macro_source_fullname): Return a std::string.
 448         * macrocmd.c (show_pp_source_pos): Update.
 449
 450 2019-02-17  Tom Tromey  <tom@tromey.com>
 451
 452         * macrocmd.c (show_pp_source_pos): Style the file names.
 453
 454 2019-02-17  Tom Tromey  <tom@tromey.com>
 455
 456         PR tui/24197:
 457         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 458
 459 2019-02-17  Tom Tromey  <tom@tromey.com>
 460
 461         * ada-lang.c (user_select_syms): Use filtered printing.
 462         * utils.c (wrap_style): New global.
 463         (desired_style): Remove.
 464         (emit_style_escape): Add stream parameter.
 465         (set_output_style, reset_terminal_style, prompt_for_continue):
 466         Update.
 467         (flush_wrap_buffer): Only flush gdb_stdout.
 468         (wrap_here): Set wrap_style.
 469         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 470         treat escape sequences as a character.  Change when wrap buffer is
 471         flushed.
 472         (fputs_styled): Do not set the output style when the default is
 473         requested.
 474         * ui-style.h (struct ui_file_style) <is_default>: New method.
 475         * source.c (print_source_lines_base): Emit escape sequences in one
 476         piece.
 477
 478 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 479
 480         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 481         integers and enumeration types.
 482
 483 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 484
 485         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 486         instead of lookup_symbol_in_language
 487         (do_exact_match): New function.
 488         (ada_get_symbol_name_matcher): Return do_exact_match when
 489         doing a verbatim match.
 490
 491 2019-02-15  Tom Tromey  <tromey@adacore.com>
 492
 493         * ravenscar-thread.c (ravenscar_thread_target::resume)
 494         (ravenscar_thread_target::wait): Special case wildcard requests.
 495
 496 2019-02-15  Tom Tromey  <tromey@adacore.com>
 497
 498         * ravenscar-thread.c (base_ptid): Remove.
 499         (struct ravenscar_thread_target) <close>: New method.
 500         <m_base_ptid>: New member.
 501         <update_inferior_ptid, active_task, task_is_currently_active,
 502         runtime_initialized>: Declare methods.
 503         <ravenscar_thread_target>: Add constructor.
 504         (ravenscar_thread_target::task_is_currently_active)
 505         (ravenscar_thread_target::update_inferior_ptid)
 506         (ravenscar_runtime_initialized): Rename.  Now methods.
 507         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 508         (ravenscar_thread_target::update_thread_list): Update.
 509         (ravenscar_thread_target::active_task): Now method.
 510         (ravenscar_thread_target::store_registers)
 511         (ravenscar_thread_target::prepare_to_store)
 512         (ravenscar_thread_target::prepare_to_store)
 513         (ravenscar_thread_target::mourn_inferior): Update.
 514         (ravenscar_inferior_created): Use "new" to create target.
 515         (ravenscar_thread_target::get_ada_task_ptid): Update.
 516         (_initialize_ravenscar): Don't initialize base_ptid.
 517         (ravenscar_ops): Remove global.
 518
 519 2019-02-15  Tom Tromey  <tromey@adacore.com>
 520
 521         * target.h (push_target): Declare new overload.
 522         * target.c (push_target): New overload, taking an rvalue reference.
 523         * remote.c (remote_target::open_1): Use push_target overload.
 524         * corelow.c (core_target_open): Use push_target overload.
 525
 526 2019-02-15  Tom Tromey  <tromey@adacore.com>
 527
 528         * ravenscar-thread.c (is_ravenscar_task)
 529         (ravenscar_task_is_currently_active): Return bool.
 530         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 531         (_initialize_ravenscar): Remove "(void)".
 532         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 533         Return bool.
 534
 535 2019-02-15  Tom Tromey  <tromey@adacore.com>
 536
 537         * ravenscar-thread.c (ravenscar_runtime_initializer)
 538         (has_ravenscar_runtime, get_running_thread_id)
 539         (ravenscar_thread_target::resume): Fix indentation.
 540
 541 2019-02-15  Tom Tromey  <tromey@adacore.com>
 542
 543         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 544         from ravenscar_arch_ops.
 545         (sparc_ravenscar_ops::fetch_registers)
 546         (sparc_ravenscar_ops::store_registers): Now methods.
 547         (sparc_ravenscar_prepare_to_store): Remove.
 548         (sparc_ravenscar_ops): Redefine.
 549         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 550         methods and destructor.  Remove members.
 551         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 552         (ravenscar_thread_target::store_registers)
 553         (ravenscar_thread_target::prepare_to_store): Update.
 554         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 555         Remove.
 556         (struct ppc_ravenscar_powerpc_ops): Derive from
 557         ravenscar_arch_ops.
 558         (ppc_ravenscar_powerpc_ops::fetch_registers)
 559         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 560         (ppc_ravenscar_powerpc_ops): Redefine.
 561         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 562         (ppc_ravenscar_e500_ops::fetch_registers)
 563         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 564         (ppc_ravenscar_e500_ops): Redefine.
 565         * aarch64-ravenscar-thread.c
 566         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 567         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 568         (aarch64_ravenscar_fetch_registers)
 569         (aarch64_ravenscar_store_registers): Now methods.
 570         (aarch64_ravenscar_ops): Redefine.
 571
 572 2019-02-15  Tom Tromey  <tromey@adacore.com>
 573
 574         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 575         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 576         (ravenscar_thread_target::stopped_by_watchpoint)
 577         (ravenscar_thread_target::stopped_data_address)
 578         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 579
 580 2019-02-15  Tom Tromey  <tromey@adacore.com>
 581
 582         * ravenscar-thread.c: Fix some typos.
 583
 584 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 585             Tom Tromey  <tromey@adacore.com>
 586
 587         * ada-lang.c (ada_exception_sal): Change addr_string to a
 588         std::string.
 589         (create_ada_exception_catchpoint): Update.
 590
 591 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 592             Tom Tromey  <tromey@adacore.com>
 593
 594         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 595         (bp_location_ops): Remove.
 596         (base_breakpoint_allocate_location): Update.
 597         (free_bp_location): Update.
 598         * ada-lang.c (class ada_catchpoint_location)
 599         <ada_catchpoint_location>: Remove ops parameter.
 600         (ada_catchpoint_location_dtor): Remove.
 601         (ada_catchpoint_location_ops): Remove.
 602         (allocate_location_exception): Update.
 603         * breakpoint.h (struct bp_location_ops): Remove.
 604         (class bp_location) <bp_location>: Remove bp_location_ops
 605         parameter.
 606         <~bp_location>: Add destructor.
 607         <ops>: Remove.
 608
 609 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 610             Pedro Alves  <palves@redhat.com>
 611
 612         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 613         'PATH_MAX'.
 614
 615 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 616             Samuel Thibault  <samuel.thibault@gnu.org>
 617             Thomas Schwinge  <thomas@codesourcery.com>
 618
 619         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 620         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 621
 622 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 623
 624         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 625         (check_empty): Use "const char *".
 626
 627         * gnu-nat.c (gnu_nat_target::detach): Instead of
 628         'detach_inferior (pid)' call
 629         'detach_inferior (find_inferior_pid (pid))'.
 630
 631         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 632         'nat/fork-inferior.o'.
 633         * gnu-nat.c: #include "nat/fork-inferior.h".
 634
 635         * gnu-nat.c (gnu_nat_target::detach): Instead of
 636         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 637         * gnu-nat.h: #include "inf-child.h".
 638         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 639         'i386_gnu_nat_target::fetch_registers'.
 640         (gnu_store_registers): Rename/move to
 641         'i386_gnu_nat_target::store_registers'.
 642
 643         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 644         * gnu-nat.h (mach_thread_info): New function.
 645         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 646
 647         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 648
 649 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 650
 651         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 652
 653 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 654
 655         * windows-nat.c (windows_add_thread): Add new parameter
 656         "main_thread_p" with default value set to false.  Update
 657         function documentation as well as all callers.
 658         (windows_delete_thread): Likewise.
 659         (fake_create_process): Update call to windows_add_thread.
 660         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 661         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 662         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 663         call to windows_delete_thread.
 664
 665 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 666
 667         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 668
 669 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 670
 671         * symfile.c (find_separate_debug_file): Use canonical path of
 672         sysroot with child_path instead of gdb_sysroot if it is valid.
 673
 674 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 675
 676         * symfile.c (find_separate_debug_file): Use child_path to
 677         determine if an object file is under a sysroot.
 678
 679 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 680
 681         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 682         unittests/child-path-selftests.c.
 683         * common/pathstuff.c (child_path): New function.
 684         * common/pathstuff.h (child_path): New prototype.
 685         * unittests/child-path-selftests.c: New file.
 686
 687 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 688
 689         * symfile.c (find_separate_debug_file): Look for separate debug
 690         files in debug directories under the sysroot.
 691
 692 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 693
 694         * symtab.h (struct minimal_symbol data_p): New const method.
 695         (struct minimal_symbol text_p): Likewise.
 696         * symtab.c (output_source_filename): Use file name style
 697         to print file name.
 698         (print_symbol_info): Likewise.
 699         (print_msymbol_info): Use address style to print addresses.
 700         Use function name style to print executable text symbols.
 701         (expand_symtab_containing_pc): Use data_p.
 702         (find_pc_sect_compunit_symtab): Likewise.
 703
 704 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 705
 706         * breakpoint.c (describe_other_breakpoints): Use address style
 707         to print addresses.
 708         (say_where): Likewise.
 709
 710 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 711
 712         * ada-typeprint.c (print_func_type): Print function name
 713         style to print function name.
 714         * c-typeprint.c (c_print_type_1): Likewise.
 715
 716 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 717
 718         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 719         for execve.
 720
 721 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 722
 723         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 724         type_stack.
 725
 726 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 727
 728         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 729         TYPE_CODE_REF types.
 730
 731 2019-02-08  Jim Wilson  <jimw@sifive.com>
 732
 733         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 734         (riscv_linux_fregset): New.
 735         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 736
 737 2019-02-07  Tom Tromey  <tom@tromey.com>
 738
 739         * thread.c (thread_cancel_execution_command): Update.
 740         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 741         methods.
 742         (struct thread_fsm_ops): Remove.
 743         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 744         (thread_fsm_should_stop, thread_fsm_return_value)
 745         (thread_fsm_set_finished, thread_fsm_finished_p)
 746         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 747         Don't declare.
 748         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 749         * infrun.c (clear_proceed_status_thread)
 750         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 751         (print_stop_event): Update.
 752         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 753         Add constructor.
 754         (step_command_fsm_ops): Remove.
 755         (new_step_command_fsm): Remove.
 756         (step_1): Update.
 757         (step_command_fsm::should_stop): Rename from
 758         step_command_fsm_should_stop.
 759         (step_command_fsm::clean_up): Rename from
 760         step_command_fsm_clean_up.
 761         (step_command_fsm::do_async_reply_reason): Rename from
 762         step_command_fsm_async_reply_reason.
 763         (struct until_next_fsm): Inherit from thread_fsm.  Add
 764         constructor.
 765         (until_next_fsm_ops): Remove.
 766         (new_until_next_fsm): Remove.
 767         (until_next_fsm::should_stop): Rename from
 768         until_next_fsm_should_stop.
 769         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 770         (until_next_fsm::do_async_reply_reason): Rename from
 771         until_next_fsm_async_reply_reason.
 772         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 773         constructor.  Change type of breakpoint.
 774         (finish_command_fsm_ops): Remove.
 775         (new_finish_command_fsm): Remove.
 776         (finish_command_fsm::should_stop): Rename from
 777         finish_command_fsm_should_stop.
 778         (finish_command_fsm::clean_up): Rename from
 779         finish_command_fsm_clean_up.
 780         (finish_command_fsm::return_value): Rename from
 781         finish_command_fsm_return_value.
 782         (finish_command_fsm::do_async_reply_reason): Rename from
 783         finish_command_fsm_async_reply_reason.
 784         (finish_command): Update.
 785         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 786         Add constructor.
 787         (call_thread_fsm_ops): Remove.
 788         (call_thread_fsm::call_thread_fsm): Rename from
 789         new_call_thread_fsm.
 790         (call_thread_fsm::should_stop): Rename from
 791         call_thread_fsm_should_stop.
 792         (call_thread_fsm::should_notify_stop): Rename from
 793         call_thread_fsm_should_notify_stop.
 794         (run_inferior_call, call_function_by_hand_dummy): Update.
 795         * cli/cli-interp.c (should_print_stop_to_console): Update.
 796         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 797         Add constructor.  Change type of location_breakpoint,
 798         caller_breakpoint.
 799         (until_break_fsm_ops): Remove.
 800         (new_until_break_fsm): Remove.
 801         (until_break_fsm::should_stop): Rename from
 802         until_break_fsm_should_stop.
 803         (until_break_fsm::clean_up): Rename from
 804         until_break_fsm_clean_up.
 805         (until_break_fsm::do_async_reply_reason): Rename from
 806         until_break_fsm_async_reply_reason.
 807         (until_break_command): Update.
 808         * thread-fsm.c: Remove.
 809         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 810
 811 2019-02-07  Tom Tromey  <tom@tromey.com>
 812
 813         * yy-remap.h: Add include guard.
 814         * xtensa-tdep.h: Add include guard.
 815         * xcoffread.h: Rename include guard.
 816         * varobj-iter.h: Add include guard.
 817         * tui/tui.h: Rename include guard.
 818         * tui/tui-winsource.h: Rename include guard.
 819         * tui/tui-wingeneral.h: Rename include guard.
 820         * tui/tui-windata.h: Rename include guard.
 821         * tui/tui-win.h: Rename include guard.
 822         * tui/tui-stack.h: Rename include guard.
 823         * tui/tui-source.h: Rename include guard.
 824         * tui/tui-regs.h: Rename include guard.
 825         * tui/tui-out.h: Rename include guard.
 826         * tui/tui-layout.h: Rename include guard.
 827         * tui/tui-io.h: Rename include guard.
 828         * tui/tui-hooks.h: Rename include guard.
 829         * tui/tui-file.h: Rename include guard.
 830         * tui/tui-disasm.h: Rename include guard.
 831         * tui/tui-data.h: Rename include guard.
 832         * tui/tui-command.h: Rename include guard.
 833         * tic6x-tdep.h: Add include guard.
 834         * target/waitstatus.h: Rename include guard.
 835         * target/wait.h: Rename include guard.
 836         * target/target.h: Rename include guard.
 837         * target/resume.h: Rename include guard.
 838         * target-float.h: Rename include guard.
 839         * stabsread.h: Add include guard.
 840         * rs6000-tdep.h: Add include guard.
 841         * riscv-fbsd-tdep.h: Add include guard.
 842         * regformats/regdef.h: Rename include guard.
 843         * record.h: Rename include guard.
 844         * python/python.h: Rename include guard.
 845         * python/python-internal.h: Rename include guard.
 846         * python/py-stopevent.h: Rename include guard.
 847         * python/py-ref.h: Rename include guard.
 848         * python/py-record.h: Rename include guard.
 849         * python/py-record-full.h: Rename include guard.
 850         * python/py-record-btrace.h: Rename include guard.
 851         * python/py-instruction.h: Rename include guard.
 852         * python/py-events.h: Rename include guard.
 853         * python/py-event.h: Rename include guard.
 854         * procfs.h: Add include guard.
 855         * proc-utils.h: Add include guard.
 856         * p-lang.h: Add include guard.
 857         * or1k-tdep.h: Rename include guard.
 858         * observable.h: Rename include guard.
 859         * nto-tdep.h: Rename include guard.
 860         * nat/x86-linux.h: Rename include guard.
 861         * nat/x86-linux-dregs.h: Rename include guard.
 862         * nat/x86-gcc-cpuid.h: Add include guard.
 863         * nat/x86-dregs.h: Rename include guard.
 864         * nat/x86-cpuid.h: Rename include guard.
 865         * nat/ppc-linux.h: Rename include guard.
 866         * nat/mips-linux-watch.h: Rename include guard.
 867         * nat/linux-waitpid.h: Rename include guard.
 868         * nat/linux-ptrace.h: Rename include guard.
 869         * nat/linux-procfs.h: Rename include guard.
 870         * nat/linux-osdata.h: Rename include guard.
 871         * nat/linux-nat.h: Rename include guard.
 872         * nat/linux-namespaces.h: Rename include guard.
 873         * nat/linux-btrace.h: Rename include guard.
 874         * nat/glibc_thread_db.h: Rename include guard.
 875         * nat/gdb_thread_db.h: Rename include guard.
 876         * nat/gdb_ptrace.h: Rename include guard.
 877         * nat/fork-inferior.h: Rename include guard.
 878         * nat/amd64-linux-siginfo.h: Rename include guard.
 879         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 880         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 881         * nat/aarch64-linux.h: Rename include guard.
 882         * nat/aarch64-linux-hw-point.h: Rename include guard.
 883         * mn10300-tdep.h: Add include guard.
 884         * mips-linux-tdep.h: Add include guard.
 885         * mi/mi-parse.h: Rename include guard.
 886         * mi/mi-out.h: Rename include guard.
 887         * mi/mi-main.h: Rename include guard.
 888         * mi/mi-interp.h: Rename include guard.
 889         * mi/mi-getopt.h: Rename include guard.
 890         * mi/mi-console.h: Rename include guard.
 891         * mi/mi-common.h: Rename include guard.
 892         * mi/mi-cmds.h: Rename include guard.
 893         * mi/mi-cmd-break.h: Rename include guard.
 894         * m2-lang.h: Add include guard.
 895         * location.h: Rename include guard.
 896         * linux-record.h: Rename include guard.
 897         * linux-nat.h: Add include guard.
 898         * linux-fork.h: Add include guard.
 899         * i386-darwin-tdep.h: Rename include guard.
 900         * hppa-linux-offsets.h: Add include guard.
 901         * guile/guile.h: Rename include guard.
 902         * guile/guile-internal.h: Rename include guard.
 903         * gnu-nat.h: Rename include guard.
 904         * gdb-stabs.h: Rename include guard.
 905         * frv-tdep.h: Add include guard.
 906         * f-lang.h: Add include guard.
 907         * event-loop.h: Add include guard.
 908         * darwin-nat.h: Rename include guard.
 909         * cp-abi.h: Rename include guard.
 910         * config/sparc/nm-sol2.h: Rename include guard.
 911         * config/nm-nto.h: Rename include guard.
 912         * config/nm-linux.h: Add include guard.
 913         * config/i386/nm-i386gnu.h: Rename include guard.
 914         * config/djgpp/nl_types.h: Rename include guard.
 915         * config/djgpp/langinfo.h: Rename include guard.
 916         * compile/gcc-cp-plugin.h: Add include guard.
 917         * compile/gcc-c-plugin.h: Add include guard.
 918         * compile/compile.h: Rename include guard.
 919         * compile/compile-object-run.h: Rename include guard.
 920         * compile/compile-object-load.h: Rename include guard.
 921         * compile/compile-internal.h: Rename include guard.
 922         * compile/compile-cplus.h: Rename include guard.
 923         * compile/compile-c.h: Rename include guard.
 924         * common/xml-utils.h: Rename include guard.
 925         * common/x86-xstate.h: Rename include guard.
 926         * common/version.h: Rename include guard.
 927         * common/vec.h: Rename include guard.
 928         * common/tdesc.h: Rename include guard.
 929         * common/selftest.h: Rename include guard.
 930         * common/scoped_restore.h: Rename include guard.
 931         * common/scoped_mmap.h: Rename include guard.
 932         * common/scoped_fd.h: Rename include guard.
 933         * common/safe-iterator.h: Rename include guard.
 934         * common/run-time-clock.h: Rename include guard.
 935         * common/refcounted-object.h: Rename include guard.
 936         * common/queue.h: Rename include guard.
 937         * common/ptid.h: Rename include guard.
 938         * common/print-utils.h: Rename include guard.
 939         * common/preprocessor.h: Rename include guard.
 940         * common/pathstuff.h: Rename include guard.
 941         * common/observable.h: Rename include guard.
 942         * common/netstuff.h: Rename include guard.
 943         * common/job-control.h: Rename include guard.
 944         * common/host-defs.h: Rename include guard.
 945         * common/gdb_wait.h: Rename include guard.
 946         * common/gdb_vecs.h: Rename include guard.
 947         * common/gdb_unlinker.h: Rename include guard.
 948         * common/gdb_unique_ptr.h: Rename include guard.
 949         * common/gdb_tilde_expand.h: Rename include guard.
 950         * common/gdb_sys_time.h: Rename include guard.
 951         * common/gdb_string_view.h: Rename include guard.
 952         * common/gdb_splay_tree.h: Rename include guard.
 953         * common/gdb_setjmp.h: Rename include guard.
 954         * common/gdb_ref_ptr.h: Rename include guard.
 955         * common/gdb_optional.h: Rename include guard.
 956         * common/gdb_locale.h: Rename include guard.
 957         * common/gdb_assert.h: Rename include guard.
 958         * common/filtered-iterator.h: Rename include guard.
 959         * common/filestuff.h: Rename include guard.
 960         * common/fileio.h: Rename include guard.
 961         * common/environ.h: Rename include guard.
 962         * common/common-utils.h: Rename include guard.
 963         * common/common-types.h: Rename include guard.
 964         * common/common-regcache.h: Rename include guard.
 965         * common/common-inferior.h: Rename include guard.
 966         * common/common-gdbthread.h: Rename include guard.
 967         * common/common-exceptions.h: Rename include guard.
 968         * common/common-defs.h: Rename include guard.
 969         * common/common-debug.h: Rename include guard.
 970         * common/cleanups.h: Rename include guard.
 971         * common/buffer.h: Rename include guard.
 972         * common/btrace-common.h: Rename include guard.
 973         * common/break-common.h: Rename include guard.
 974         * cli/cli-utils.h: Rename include guard.
 975         * cli/cli-style.h: Rename include guard.
 976         * cli/cli-setshow.h: Rename include guard.
 977         * cli/cli-script.h: Rename include guard.
 978         * cli/cli-interp.h: Rename include guard.
 979         * cli/cli-decode.h: Rename include guard.
 980         * cli/cli-cmds.h: Rename include guard.
 981         * charset-list.h: Add include guard.
 982         * buildsym-legacy.h: Rename include guard.
 983         * bfin-tdep.h: Add include guard.
 984         * ax.h: Rename include guard.
 985         * arm-linux-tdep.h: Add include guard.
 986         * arm-fbsd-tdep.h: Add include guard.
 987         * arch/xtensa.h: Rename include guard.
 988         * arch/tic6x.h: Add include guard.
 989         * arch/i386.h: Add include guard.
 990         * arch/arm.h: Rename include guard.
 991         * arch/arm-linux.h: Rename include guard.
 992         * arch/arm-get-next-pcs.h: Rename include guard.
 993         * arch/amd64.h: Add include guard.
 994         * arch/aarch64-insn.h: Rename include guard.
 995         * arch-utils.h: Rename include guard.
 996         * annotate.h: Add include guard.
 997         * amd64-darwin-tdep.h: Rename include guard.
 998         * aarch64-linux-tdep.h: Add include guard.
 999         * aarch64-fbsd-tdep.h: Add include guard.
1000         * aarch32-linux-nat.h: Add include guard.
1001
1002 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1003
1004         * macrotab.c (macro_define_internal): New function that
1005         factorizes macro_define_object_internal and macro_define_function
1006         code.
1007         (macro_define_object_internal): Use macro_define_internal.
1008         (macro_define_function): Likewise.
1009
1010 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1011
1012         * macrocmd.c (extract_identifier): Return
1013         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1014         callers.
1015
1016 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1017
1018         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1019
1020 2019-02-05  Tom Tromey  <tom@tromey.com>
1021
1022         * target.c (target_stack::unpush): Move assertion earlier.
1023
1024 2019-01-30  Tom Tromey  <tom@tromey.com>
1025
1026         PR python/23615:
1027         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1028         (gdbpy_parse_and_eval): Likewise.
1029         * python/python-internal.h (gdbpy_allow_threads): New class.
1030
1031 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1032
1033         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1034         (aarch64_fbsd_fpregmap): Move earlier.
1035         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1036         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1037         instead of individual calls to trad_frame_set_reg_addr.
1038         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1039         earlier.
1040         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1041         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1042         instead of individual calls to trad_frame_set_reg_addr.
1043
1044 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1045
1046         * CONTRIBUTE: Replace contribution list with wiki link.
1047
1048 2019-01-25  Tom Tromey  <tom@tromey.com>
1049
1050         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1051
1052 2019-01-25  Tom Tromey  <tom@tromey.com>
1053
1054         * xtensa-linux-nat.c: Fix common/ includes.
1055         * xml-support.h: Fix common/ includes.
1056         * xml-support.c: Fix common/ includes.
1057         * x86-linux-nat.c: Fix common/ includes.
1058         * windows-nat.c: Fix common/ includes.
1059         * varobj.h: Fix common/ includes.
1060         * varobj.c: Fix common/ includes.
1061         * value.c: Fix common/ includes.
1062         * valops.c: Fix common/ includes.
1063         * utils.c: Fix common/ includes.
1064         * unittests/xml-utils-selftests.c: Fix common/ includes.
1065         * unittests/utils-selftests.c: Fix common/ includes.
1066         * unittests/unpack-selftests.c: Fix common/ includes.
1067         * unittests/tracepoint-selftests.c: Fix common/ includes.
1068         * unittests/style-selftests.c: Fix common/ includes.
1069         * unittests/string_view-selftests.c: Fix common/ includes.
1070         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1071         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1072         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1073         * unittests/rsp-low-selftests.c: Fix common/ includes.
1074         * unittests/parse-connection-spec-selftests.c: Fix common/
1075         includes.
1076         * unittests/optional-selftests.c: Fix common/ includes.
1077         * unittests/offset-type-selftests.c: Fix common/ includes.
1078         * unittests/observable-selftests.c: Fix common/ includes.
1079         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1080         * unittests/memrange-selftests.c: Fix common/ includes.
1081         * unittests/memory-map-selftests.c: Fix common/ includes.
1082         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1083         * unittests/function-view-selftests.c: Fix common/ includes.
1084         * unittests/environ-selftests.c: Fix common/ includes.
1085         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1086         * unittests/common-utils-selftests.c: Fix common/ includes.
1087         * unittests/cli-utils-selftests.c: Fix common/ includes.
1088         * unittests/array-view-selftests.c: Fix common/ includes.
1089         * ui-file.c: Fix common/ includes.
1090         * tui/tui-io.c: Fix common/ includes.
1091         * tracepoint.h: Fix common/ includes.
1092         * tracepoint.c: Fix common/ includes.
1093         * tracefile-tfile.c: Fix common/ includes.
1094         * top.h: Fix common/ includes.
1095         * top.c: Fix common/ includes.
1096         * thread.c: Fix common/ includes.
1097         * target/waitstatus.h: Fix common/ includes.
1098         * target/waitstatus.c: Fix common/ includes.
1099         * target.h: Fix common/ includes.
1100         * target.c: Fix common/ includes.
1101         * target-memory.c: Fix common/ includes.
1102         * target-descriptions.c: Fix common/ includes.
1103         * symtab.h: Fix common/ includes.
1104         * symfile.c: Fix common/ includes.
1105         * stap-probe.c: Fix common/ includes.
1106         * spu-linux-nat.c: Fix common/ includes.
1107         * sparc-nat.c: Fix common/ includes.
1108         * source.c: Fix common/ includes.
1109         * solib.c: Fix common/ includes.
1110         * solib-target.c: Fix common/ includes.
1111         * ser-unix.c: Fix common/ includes.
1112         * ser-tcp.c: Fix common/ includes.
1113         * ser-pipe.c: Fix common/ includes.
1114         * ser-base.c: Fix common/ includes.
1115         * selftest-arch.c: Fix common/ includes.
1116         * s12z-tdep.c: Fix common/ includes.
1117         * rust-exp.y: Fix common/ includes.
1118         * rs6000-aix-tdep.c: Fix common/ includes.
1119         * riscv-tdep.c: Fix common/ includes.
1120         * remote.c: Fix common/ includes.
1121         * remote-notif.h: Fix common/ includes.
1122         * remote-fileio.h: Fix common/ includes.
1123         * remote-fileio.c: Fix common/ includes.
1124         * regcache.h: Fix common/ includes.
1125         * regcache.c: Fix common/ includes.
1126         * record-btrace.c: Fix common/ includes.
1127         * python/python.c: Fix common/ includes.
1128         * python/py-type.c: Fix common/ includes.
1129         * python/py-inferior.c: Fix common/ includes.
1130         * progspace.h: Fix common/ includes.
1131         * producer.c: Fix common/ includes.
1132         * procfs.c: Fix common/ includes.
1133         * proc-api.c: Fix common/ includes.
1134         * printcmd.c: Fix common/ includes.
1135         * ppc-linux-nat.c: Fix common/ includes.
1136         * parser-defs.h: Fix common/ includes.
1137         * osdata.c: Fix common/ includes.
1138         * obsd-nat.c: Fix common/ includes.
1139         * nat/x86-linux.c: Fix common/ includes.
1140         * nat/x86-linux-dregs.c: Fix common/ includes.
1141         * nat/x86-dregs.h: Fix common/ includes.
1142         * nat/x86-dregs.c: Fix common/ includes.
1143         * nat/ppc-linux.c: Fix common/ includes.
1144         * nat/mips-linux-watch.h: Fix common/ includes.
1145         * nat/mips-linux-watch.c: Fix common/ includes.
1146         * nat/linux-waitpid.c: Fix common/ includes.
1147         * nat/linux-ptrace.h: Fix common/ includes.
1148         * nat/linux-ptrace.c: Fix common/ includes.
1149         * nat/linux-procfs.c: Fix common/ includes.
1150         * nat/linux-personality.c: Fix common/ includes.
1151         * nat/linux-osdata.c: Fix common/ includes.
1152         * nat/linux-namespaces.c: Fix common/ includes.
1153         * nat/linux-btrace.h: Fix common/ includes.
1154         * nat/linux-btrace.c: Fix common/ includes.
1155         * nat/fork-inferior.c: Fix common/ includes.
1156         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1157         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1158         * nat/aarch64-linux.c: Fix common/ includes.
1159         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1160         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1161         * namespace.h: Fix common/ includes.
1162         * mips-linux-tdep.c: Fix common/ includes.
1163         * minsyms.c: Fix common/ includes.
1164         * mi/mi-parse.h: Fix common/ includes.
1165         * mi/mi-main.c: Fix common/ includes.
1166         * mi/mi-cmd-env.c: Fix common/ includes.
1167         * memrange.h: Fix common/ includes.
1168         * memattr.c: Fix common/ includes.
1169         * maint.h: Fix common/ includes.
1170         * maint.c: Fix common/ includes.
1171         * main.c: Fix common/ includes.
1172         * machoread.c: Fix common/ includes.
1173         * location.c: Fix common/ includes.
1174         * linux-thread-db.c: Fix common/ includes.
1175         * linux-nat.c: Fix common/ includes.
1176         * linux-fork.c: Fix common/ includes.
1177         * inline-frame.c: Fix common/ includes.
1178         * infrun.c: Fix common/ includes.
1179         * inflow.c: Fix common/ includes.
1180         * inferior.h: Fix common/ includes.
1181         * inferior.c: Fix common/ includes.
1182         * infcmd.c: Fix common/ includes.
1183         * inf-ptrace.c: Fix common/ includes.
1184         * inf-child.c: Fix common/ includes.
1185         * ia64-linux-nat.c: Fix common/ includes.
1186         * i387-tdep.c: Fix common/ includes.
1187         * i386-tdep.c: Fix common/ includes.
1188         * i386-linux-tdep.c: Fix common/ includes.
1189         * i386-linux-nat.c: Fix common/ includes.
1190         * i386-go32-tdep.c: Fix common/ includes.
1191         * i386-fbsd-tdep.c: Fix common/ includes.
1192         * i386-fbsd-nat.c: Fix common/ includes.
1193         * guile/scm-type.c: Fix common/ includes.
1194         * guile/guile.c: Fix common/ includes.
1195         * go32-nat.c: Fix common/ includes.
1196         * gnu-nat.c: Fix common/ includes.
1197         * gdbthread.h: Fix common/ includes.
1198         * gdbarch-selftests.c: Fix common/ includes.
1199         * gdb_usleep.c: Fix common/ includes.
1200         * gdb_select.h: Fix common/ includes.
1201         * gdb_bfd.c: Fix common/ includes.
1202         * gcore.c: Fix common/ includes.
1203         * fork-child.c: Fix common/ includes.
1204         * findvar.c: Fix common/ includes.
1205         * fbsd-nat.c: Fix common/ includes.
1206         * event-top.c: Fix common/ includes.
1207         * event-loop.c: Fix common/ includes.
1208         * dwarf2read.c: Fix common/ includes.
1209         * dwarf2loc.c: Fix common/ includes.
1210         * dwarf2-frame.c: Fix common/ includes.
1211         * dwarf-index-cache.c: Fix common/ includes.
1212         * dtrace-probe.c: Fix common/ includes.
1213         * disasm-selftests.c: Fix common/ includes.
1214         * defs.h: Fix common/ includes.
1215         * csky-tdep.c: Fix common/ includes.
1216         * cp-valprint.c: Fix common/ includes.
1217         * cp-support.h: Fix common/ includes.
1218         * cp-support.c: Fix common/ includes.
1219         * corelow.c: Fix common/ includes.
1220         * completer.h: Fix common/ includes.
1221         * completer.c: Fix common/ includes.
1222         * compile/compile.c: Fix common/ includes.
1223         * compile/compile-loc2c.c: Fix common/ includes.
1224         * compile/compile-cplus-types.c: Fix common/ includes.
1225         * compile/compile-cplus-symbols.c: Fix common/ includes.
1226         * command.h: Fix common/ includes.
1227         * cli/cli-dump.c: Fix common/ includes.
1228         * cli/cli-cmds.c: Fix common/ includes.
1229         * charset.c: Fix common/ includes.
1230         * build-id.c: Fix common/ includes.
1231         * btrace.h: Fix common/ includes.
1232         * btrace.c: Fix common/ includes.
1233         * breakpoint.h: Fix common/ includes.
1234         * breakpoint.c: Fix common/ includes.
1235         * ax.h:
1236         (enum agent_op): Fix common/ includes.
1237         * ax-general.c (struct aop_map): Fix common/ includes.
1238         * ax-gdb.c: Fix common/ includes.
1239         * auxv.c: Fix common/ includes.
1240         * auto-load.c: Fix common/ includes.
1241         * arm-tdep.c: Fix common/ includes.
1242         * arch/riscv.c: Fix common/ includes.
1243         * arch/ppc-linux-common.c: Fix common/ includes.
1244         * arch/i386.c: Fix common/ includes.
1245         * arch/arm.c: Fix common/ includes.
1246         * arch/arm-linux.c: Fix common/ includes.
1247         * arch/arm-get-next-pcs.c: Fix common/ includes.
1248         * arch/amd64.c: Fix common/ includes.
1249         * arch/aarch64.c: Fix common/ includes.
1250         * arch/aarch64-insn.c: Fix common/ includes.
1251         * arch-utils.c: Fix common/ includes.
1252         * amd64-windows-tdep.c: Fix common/ includes.
1253         * amd64-tdep.c: Fix common/ includes.
1254         * amd64-sol2-tdep.c: Fix common/ includes.
1255         * amd64-obsd-tdep.c: Fix common/ includes.
1256         * amd64-nbsd-tdep.c: Fix common/ includes.
1257         * amd64-linux-tdep.c: Fix common/ includes.
1258         * amd64-linux-nat.c: Fix common/ includes.
1259         * amd64-fbsd-tdep.c: Fix common/ includes.
1260         * amd64-fbsd-nat.c: Fix common/ includes.
1261         * amd64-dicos-tdep.c: Fix common/ includes.
1262         * amd64-darwin-tdep.c: Fix common/ includes.
1263         * agent.c: Fix common/ includes.
1264         * ada-lang.h: Fix common/ includes.
1265         * ada-lang.c: Fix common/ includes.
1266         * aarch64-tdep.c: Fix common/ includes.
1267
1268 2019-01-25  Tom Tromey  <tom@tromey.com>
1269
1270         * common/create-version.sh: Use common/version.h.
1271
1272 2019-01-24  Pedro Alves  <palves@redhat.com>
1273
1274         * infrun.c (signal_stop, signal_print, signal_program)
1275         (signal_catch, signal_pass): Now arrays instead of pointers.
1276         (update_signals_program_target, do_target_resume)
1277         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1278         * linux-nat.c (linux_nat_target::pass_signals)
1279         (linux_nat_target::create_inferior, linux_nat_target::attach):
1280         Adjust.
1281         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1282         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1283         * procfs.c (procfs_target::pass_signals): Adjust.
1284         * record-full.c (record_full_target::resume): Adjust.
1285         * remote.c (remote_target::pass_signals)
1286         (remote_target::program_signals): Adjust.
1287         * target-debug.h (target_debug_print_signals): Now takes a
1288         gdb::array_view as parameter.  Adjust.
1289         * target.h (target_ops) <pass_signals, program_signals>: Replace
1290         pointer and length parameters with gdb::array_view.
1291         (target_pass_signals, target_program_signals): Likewise.
1292         * target-delegates.c: Regenerate.
1293
1294 2019-01-24  Pedro Alves  <palves@redhat.com>
1295
1296         * common/forward-scope-exit.h
1297         (forward_scope_exit::forward_scope_exit): Pass arguments to
1298         m_bind_function directly, instead of creating a std::bind and
1299         copying that.
1300
1301 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1302
1303         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1304         for static members.
1305         (pass_in_v_vfp_candidate): Likewise.
1306
1307 2019-01-23  Tom Tromey  <tom@tromey.com>
1308             Pedro Alves  <palves@redhat.com>
1309
1310         * regcache.c (class regcache_invalidator): Remove.
1311         (regcache::raw_write): Use make_scope_exit.
1312
1313 2019-01-23  Tom Tromey  <tom@tromey.com>
1314
1315         * ui-out.h (class ui_out_emit_type): Update comment.
1316
1317 2019-01-23  Tom Tromey  <tom@tromey.com>
1318
1319         * infrun.c (fetch_inferior_event): Update comment.
1320
1321 2019-01-23  Tom Tromey  <tom@tromey.com>
1322             Pedro Alves  <palves@redhat.com>
1323
1324         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1325         parameter.
1326         (fetch_inferior_event): Use SCOPE_EXIT.
1327
1328
1329 2019-01-23  Tom Tromey  <tom@tromey.com>
1330             Pedro Alves  <palves@redhat.com>
1331
1332         * infrun.c (disable_thread_events): Delete.
1333         (stop_all_threads): Use SCOPE_EXIT.
1334
1335 2019-01-23  Tom Tromey  <tom@tromey.com>
1336             Pedro Alves  <palves@redhat.com>
1337
1338         * symfile.c: Include forward-scope-exit.h.
1339         (clear_symtab_users_cleanup): Replace forward declaration with
1340         a FORWARD_SCOPE_EXIT.
1341         (syms_from_objfile_1): Use the forward_scope_exit and
1342         gdb::optional instead of cleanup_function.
1343         (reread_symbols): Use the forward_scope_exit instead of
1344         cleanup_function.
1345         (clear_symtab_users_cleanup): Remove function.
1346
1347 2019-01-23  Tom Tromey  <tom@tromey.com>
1348             Pedro Alves  <palves@redhat.com>
1349
1350         * linux-nat.c: Include scope-exit.h.
1351         (cleanup_target_stop): Remove.
1352         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1353         SCOPE_EXIT.
1354
1355 2019-01-23  Tom Tromey  <tom@tromey.com>
1356             Pedro Alves  <palves@redhat.com>
1357
1358         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1359         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1360
1361 2019-01-23  Tom Tromey  <tom@tromey.com>
1362             Andrew Burgess  <andrew.burgess@embecosm.com>
1363             Pedro Alves  <palves@redhat.com>
1364
1365         * infrun.c (fetch_inferior_event): Use scope_exit.
1366         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1367         * top.c (execute_command): Use scope_exit.
1368         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1369         * utils.c (do_bpstat_clear_actions_cleanup)
1370         (make_bpstat_clear_actions_cleanup): Remove.
1371
1372 2019-01-23  Tom Tromey  <tom@tromey.com>
1373             Pedro Alves  <palves@redhat.com>
1374
1375         * infrun.c: Include "common/scope-exit.h"
1376         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1377         (wait_for_inferior): Use SCOPE_EXIT.
1378         (fetch_inferior_event): Use scope_exit.
1379
1380 2019-01-23  Tom Tromey  <tom@tromey.com>
1381             Pedro Alves  <palves@redhat.com>
1382
1383         * breakpoint.c (create_breakpoint): Remove cleanup.
1384
1385 2019-01-23  Tom Tromey  <tom@tromey.com>
1386             Andrew Burgess  <andrew.burgess@embecosm.com>
1387             Pedro Alves  <palves@redhat.com>
1388
1389 2019-01-23  Pedro Alves  <palves@redhat.com>
1390
1391         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1392
1393 2019-01-23  Pedro Alves  <palves@redhat.com>
1394             Andrew Burgess  <andrew.burgess@embecosm.com>
1395
1396         * gdbthread.h: Include "common/forward-scope-exit.h".
1397         (scoped_finish_thread_state): Redefine custom class in terms of
1398         forward_scope_exit.
1399
1400 2019-01-23  Pedro Alves  <palves@redhat.com>
1401             Andrew Burgess  <andrew.burgess@embecosm.com>
1402
1403         * common/forward-scope-exit.h: New file.
1404
1405 2019-01-23  Pedro Alves  <palves@redhat.com>
1406             Andrew Burgess  <andrew.burgess@embecosm.com>
1407             Tom Tromey  <tom@tromey.com>
1408
1409         * common/scope-exit.h: New file.
1410
1411 2019-01-23  Pedro Alves  <palves@redhat.com>
1412
1413         * common/preprocessor.h (ESC): Rename to ...
1414         (ESC_PARENS): ... this.
1415         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1416         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1417
1418 2019-01-23  Tom Tromey  <tom@tromey.com>
1419
1420         * language.h (class scoped_switch_to_sym_language_if_auto):
1421         Initialize m_lang in both cases.
1422
1423 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1424
1425         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1426         with XCNEW.
1427
1428 2019-01-22  Tom Tromey  <tom@tromey.com>
1429
1430         * corelow.c: Do not include sys/file.h.
1431
1432 2019-01-22  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-wingeneral.h: Include gdb_curses.h.
1435
1436 2019-01-22  Tom Tromey  <tom@tromey.com>
1437
1438         * source-cache.h (class source_cache) <get_source_lines,
1439         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1440
1441 2019-01-22  Tom Tromey  <tom@tromey.com>
1442
1443         * remote-fileio.h (struct remote_target): Declare.
1444
1445 2019-01-22  Tom Tromey  <tom@tromey.com>
1446
1447         * python/py-arch.c: Do not include py-ref.h.
1448         * python/py-bpevent.c: Do not include py-ref.h.
1449         * python/py-cmd.c: Do not include py-ref.h.
1450         * python/py-continueevent.c: Do not include py-ref.h.
1451         * python/py-event.h: Do not include py-ref.h.
1452         * python/py-evtregistry.c: Do not include py-ref.h.
1453         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1454         * python/py-frame.c: Do not include py-ref.h.
1455         * python/py-framefilter.c: Do not include py-ref.h.
1456         * python/py-function.c: Do not include py-ref.h.
1457         * python/py-infevents.c: Do not include py-ref.h.
1458         * python/py-linetable.c: Do not include py-ref.h.
1459         * python/py-objfile.c: Do not include py-ref.h.
1460         * python/py-param.c: Do not include py-ref.h.
1461         * python/py-prettyprint.c: Do not include py-ref.h.
1462         * python/py-progspace.c: Do not include py-ref.h.
1463         * python/py-symbol.c: Do not include py-ref.h.
1464         * python/py-symtab.c: Do not include py-ref.h.
1465         * python/py-type.c: Do not include py-ref.h.
1466         * python/py-unwind.c: Do not include py-ref.h.
1467         * python/py-utils.c: Do not include py-ref.h.
1468         * python/py-value.c: Do not include py-ref.h.
1469         * python/py-varobj.c: Do not include py-ref.h.
1470         * python/py-xmethods.c: Do not include py-ref.h.
1471         * python/python.c: Do not include py-ref.h.
1472         * varobj.c: Do not include py-ref.h.
1473
1474 2019-01-22  Tom Tromey  <tom@tromey.com>
1475
1476         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1477         keyword for bcache.
1478
1479 2019-01-22  Tom Tromey  <tom@tromey.com>
1480
1481         * compile/compile-cplus-types.c: Remove a comment by #include.
1482
1483 2019-01-22  Tom Tromey  <tom@tromey.com>
1484
1485         * compile/gcc-c-plugin.h: Include compile-internal.h.
1486
1487 2019-01-22  Tom Tromey  <tom@tromey.com>
1488
1489         * stabsread.c (EXTERN): Do not define.
1490         (symnum, next_symbol_text_func, processing_gcc_compilation)
1491         (within_function, global_sym_chain, global_stabs)
1492         (previous_stab_code, this_object_header_files)
1493         (n_this_object_header_files)
1494         (n_allocated_this_object_header_files): Define.
1495         * stabsread.h (EXTERN): Never define.  Use "extern".
1496
1497 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1498
1499         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1500         history_value.
1501
1502 2019-01-21  Tom Tromey  <tom@tromey.com>
1503
1504         * ui-out.c: Fix includes.
1505         * tui/tui-source.c: Fix includes.
1506         * target.c: Fix includes.
1507         * remote.c: Fix includes.
1508         * regcache.c: Fix includes.
1509         * python/py-block.c: Fix includes.
1510         * printcmd.c: Fix includes.
1511         * or1k-tdep.c: Fix includes.
1512         * mi/mi-main.c: Fix includes.
1513         * m32r-tdep.c: Fix includes.
1514         * csky-tdep.c: Fix includes.
1515         * compile/compile-cplus-types.c: Fix includes.
1516         * cli/cli-interp.c: Fix includes.
1517
1518 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1519
1520         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1521         for padding.
1522
1523 2019-01-16  Tom Tromey  <tom@tromey.com>
1524
1525         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1526         earlier.
1527         (struct objfile) <msymbols_range>: Move from top level.
1528         <msymbols>: New method.
1529         (class objfile_msymbols): Remove.
1530         * symtab.c (default_collect_symbol_completion_matches_break_on):
1531         Update.
1532         * symmisc.c (dump_msymbols): Update.
1533         * stabsread.c (scan_file_globals): Update.
1534         * objc-lang.c (info_selectors_command, info_classes_command)
1535         (find_methods): Update.
1536         * minsyms.c (find_solib_trampoline_target): Update.
1537         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1538         * coffread.c (coff_symfile_read): Update.
1539         * ada-lang.c (ada_lookup_simple_minsym)
1540         (ada_collect_symbol_completion_matches): Update.
1541
1542 2019-01-16  Tom Tromey  <tom@tromey.com>
1543
1544         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1545         type.  Remove no-argument constructor.
1546         <iterator::operator++>: Simplify.
1547         <begin>: Update.
1548         <end>: Use minimal_symbol_count.
1549
1550 2019-01-16  Tom Tromey  <tom@tromey.com>
1551
1552         * objfiles.h (struct objfile) <psymtabs>: New method.
1553         (class objfile_psymtabs): Remove.
1554         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1555         typedef.
1556         <range>: New method.
1557         (require_partial_symbols): Change return type.
1558         * psymtab.c (require_partial_symbols)
1559         (psym_expand_symtabs_matching): Update.
1560         * mdebugread.c (parse_partial_symbols): Update.
1561         * dbxread.c (dbx_end_psymtab): Update.
1562
1563 2019-01-15  Tom Tromey  <tom@tromey.com>
1564
1565         * symtab.c (lookup_objfile_from_block)
1566         (lookup_symbol_in_objfile_symtabs)
1567         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1568         (find_line_symtab, info_sources_command)
1569         (default_collect_symbol_completion_matches_break_on)
1570         (make_source_files_completion_list): Update.
1571         * symmisc.c (print_objfile_statistics, dump_objfile)
1572         (maintenance_print_symbols, maintenance_info_symtabs)
1573         (maintenance_check_symtabs, maintenance_info_line_tables):
1574         Update.
1575         * source.c (select_source_symtab)
1576         (forget_cached_source_info_for_objfile): Update.
1577         * objfiles.h (class objfile_compunits): Remove.
1578         (struct objfile) <compunits_range>: New typedef.
1579         (compunits): New method.
1580         * objfiles.c (objfile_relocate1): Update.
1581         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1582         * maint.c (count_symtabs_and_blocks): Update.
1583         * linespec.c (iterate_over_all_matching_symtabs): Update.
1584         * cp-support.c (add_symbol_overload_list_qualified): Update.
1585         * coffread.c (coff_symtab_read): Update.
1586         * ada-lang.c (add_nonlocal_symbols)
1587         (ada_collect_symbol_completion_matches)
1588         (ada_add_global_exceptions): Update.
1589
1590 2019-01-15  Tom Tromey  <tom@tromey.com>
1591
1592         * progspace.h (program_space) <objfiles_safe_range>: New
1593         typedef.
1594         <objfiles_safe>: New method.
1595         * objfiles.h (class all_objfiles_safe): Remove.
1596         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1597         * jit.c (jit_inferior_exit_hook): Update.
1598
1599 2019-01-17  Tom Tromey  <tom@tromey.com>
1600
1601         * progspace.h (program_space) <objfiles_range>: New typedef.
1602         <objfiles>: New method.
1603         <objfiles_head>: Rename from objfiles.
1604         (object_files): Update.
1605         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1606         * guile/scm-pretty-print.c
1607         (ppscm_find_pretty_printer_from_objfiles): Update.
1608         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1609         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1610         Update.
1611         * python/py-progspace.c (pspy_get_objfiles): Update.
1612         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1613         Update.
1614         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1615         (objfpy_lookup_objfile_by_build_id): Update.
1616         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1617         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1618         Update.
1619         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1620         (expand_symtab_containing_pc, lookup_objfile_from_block)
1621         (lookup_static_symbol, basic_lookup_transparent_type)
1622         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1623         (find_line_symtab, info_sources_command)
1624         (default_collect_symbol_completion_matches_break_on)
1625         (make_source_files_completion_list, find_main_name): Update.
1626         * symmisc.c (print_symbol_bcache_statistics)
1627         (print_objfile_statistics, maintenance_print_symbols)
1628         (maintenance_print_msymbols, maintenance_print_objfiles)
1629         (maintenance_info_symtabs, maintenance_check_symtabs)
1630         (maintenance_expand_symtabs, maintenance_info_line_tables):
1631         Update.
1632         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1633         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1634         (map_overlay_command, unmap_overlay_command)
1635         (simple_overlay_update, expand_symtabs_matching)
1636         (map_symbol_filenames): Update.
1637         * symfile-debug.c (set_debug_symfile): Update.
1638         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1639         Update.
1640         * source.c (select_source_symtab, forget_cached_source_info):
1641         Update.
1642         * solib.c (solib_read_symbols): Update.
1643         * solib-spu.c (append_ocl_sos): Update.
1644         * psymtab.c (maintenance_print_psymbols)
1645         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1646         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1647         * printcmd.c (info_symbol_command): Update.
1648         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1649         Update.
1650         * objfiles.h (class all_objfiles): Remove.
1651         * objfiles.c (have_partial_symbols, have_full_symbols)
1652         (have_minimal_symbols, qsort_cmp, update_section_map)
1653         (shared_objfile_contains_address_p)
1654         (default_iterate_over_objfiles_in_search_order): Update.
1655         * objc-lang.c (info_selectors_command, info_classes_command)
1656         (find_methods): Update.
1657         * minsyms.c (find_solib_trampoline_target): Update.
1658         * maint.c (maintenance_info_sections)
1659         (maintenance_translate_address, count_symtabs_and_blocks):
1660         Update.
1661         * main.c (captured_main_1): Update.
1662         * linux-thread-db.c (try_thread_db_load_from_pdir)
1663         (has_libpthread): Update.
1664         * linespec.c (iterate_over_all_matching_symtabs)
1665         (search_minsyms_for_name): Update.
1666         * jit.c (jit_find_objf_with_entry_addr): Update.
1667         * hppa-tdep.c (find_unwind_entry)
1668         (hppa_lookup_stub_minimal_symbol): Update.
1669         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1670         Update.
1671         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1672         (elf_gnu_ifunc_resolve_by_got): Update.
1673         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1674         * dwarf-index-write.c (save_gdb_index_command): Update.
1675         * cp-support.c (add_symbol_overload_list_qualified): Update.
1676         * breakpoint.c (create_overlay_event_breakpoint)
1677         (create_longjmp_master_breakpoint)
1678         (create_std_terminate_master_breakpoint)
1679         (create_exception_master_breakpoint): Update.
1680         * blockframe.c (find_pc_partial_function): Update.
1681         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1682         (ada_collect_symbol_completion_matches)
1683         (ada_add_global_exceptions): Update.
1684
1685 2019-01-17  Tom Tromey  <tom@tromey.com>
1686
1687         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1688         declare VEC.
1689         (solib_target_parse_libraries): Change return type.
1690         (library_list_start_segment, library_list_start_section)
1691         (library_list_end_library, library_list_start_library); Update.
1692         (solib_target_free_library_list): Remove.
1693         (solib_target_parse_libraries): Remove cleanup.  Change return
1694         type.
1695         (solib_target_current_sos): Update.
1696
1697 2019-01-17  Tom Tromey  <tromey@bapiya>
1698
1699         * valprint.c: Replace "the the" with "the".
1700         * symtab.c: Replace "the the" with "the".
1701         * solib.c: Replace "the the" with "the".
1702         * solib-dsbt.c: Replace "the the" with "the".
1703         * linespec.c: Replace "the the" with "the".
1704         * dwarf2loc.h: Replace "the the" with "the".
1705         * amd64-windows-tdep.c: Replace "the the" with "the".
1706         * aarch64-tdep.c: Replace "the the" with "the".
1707
1708 2019-01-16  Keith Seitz  <keiths@redhat.com>
1709
1710         PR gdb/23773
1711         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1712         <builder>: Rename to ..
1713         <m_builder>: ... this and make private.
1714         (dwarf2_cu::get_builder): New method.  Change all users of
1715         `builder' to use this method.
1716         (dwarf2_start_symtab): Move to ...
1717         (dwarf2_cu::start_symtab): ... here.  Update all callers
1718         (setup_type_unit_groups): Move to ...
1719         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1720         callers.
1721         (dwarf2_cu::reset_builder): New method.
1722         (process_full_compunit, process_full_type_unit): Use
1723         dwarf2_cu::reset_builder.
1724         (follow_die_offset): Record the ancestor CU if it is different
1725         from the followed DIE's CU.
1726         (follow_die_sig_1): Likewise.
1727
1728 2019-01-15  Tom Tromey  <tom@tromey.com>
1729
1730         * remote.c (class remote_state) <buf>: Now a char_vector.
1731         <buf_size>: Remove.
1732         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1733         parameter.
1734         (remote_target::getpkt_or_notif_sane_1)
1735         (remote_target::getpkt_sane)
1736         (remote_target::getpkt_or_notif_sane): Likewise.
1737         (class remote_target) <putpkt>: New overload.
1738         (remote_target::read_frame): Change type of "buf_p".  Remove
1739         sizeof_p parameter.
1740         (packet_ok): New overload.
1741         (packet_check_result): New overload.
1742         Update all uses.
1743
1744 2019-01-14  Tom Tromey  <tom@tromey.com>
1745
1746         * remote-notif.c (handle_notification, remote_notif_ack)
1747         (remote_notif_parse): Make "buf" const.
1748         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1749         const.
1750         (remote_notif_parse, remote_notif_ack, handle_notification):
1751         Likewise.
1752         * remote.c (remote_notif_stop_parse): Make "buf" const.
1753         (remote_target::remote_parse_stop_reply): Make "buf" const.
1754         (remote_notif_stop_ack): Make "buf" const.
1755
1756 2019-01-14  Tom Tromey  <tom@tromey.com>
1757
1758         * remote.c (remote_console_output): Make parameter const.
1759
1760 2019-01-14  Tom Tromey  <tom@tromey.com>
1761
1762         * target-debug.h (target_debug_print_signals): Constify.
1763         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1764         * procfs.c (procfs_target::pass_signals): Update.
1765         * linux-nat.c (linux_nat_target::pass_signals): Update.
1766         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1767         * target-delegates.c: Rebuild.
1768         * remote.c (remote_target::program_signals): Update.
1769         (remote_target::pass_signals): Update.
1770         * target.c (target_pass_signals): Constify argument.
1771         (target_program_signals): Likewise.
1772         * target.h (struct target_ops) <pass_signals, program_signals>:
1773         Constify argument.
1774         (target_pass_signals, target_program_signals): Constify argument.
1775
1776 2019-01-14  Tom Tromey  <tom@tromey.com>
1777
1778         PR tui/28819:
1779         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1780
1781 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1782
1783         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1784         field.
1785         * rs6000-tdep.c: Include reggroups.h.
1786         (IS_V_ALIAS_PSEUDOREG): Define.
1787         (rs6000_register_name): Return names for the "vX" aliases.
1788         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1789         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1790         aliases.  Call default_register_reggroup_p for all other
1791         pseudo-registers.
1792         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1793         New functions.
1794         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1795         Handle "vX" aliases.
1796         (v_alias_pseudo_register_collect): New function.
1797         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1798         (rs6000_gdbarch_init): Initialize "vX" aliases as
1799         pseudo-registers.  Restore registration of
1800         rs6000_pseudo_register_reggroup_p with
1801         set_tdesc_pseudo_register_reggroup_p.
1802
1803 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1804
1805         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1806         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1807         set_gdbarch_num_pseudo_regs.
1808
1809 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1810
1811         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1812         Remove arg prefixname, add do_set and do_show.
1813         Add member functions set_list and show_list.
1814         * cli/cli-style.c (class cli_style_option): Update accordingly.
1815         (style_set_list): Move to file scope.
1816         (style_show_list): Likewise.
1817         (set_style): Call help_list.
1818         (show_style): Call cmd_show_list.
1819         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1820         Update to use the new macro.
1821
1822 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1823
1824         * ada-lang.c (_initialize_ada_language): Expand the help text
1825         for the "catch exception" command.
1826
1827 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1828
1829         * symtab.c (matching_obj_sections): Initialize obj,
1830         declare it closer to its usage.
1831
1832 2019-01-10  Tom Tromey  <tom@tromey.com>
1833
1834         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1835         (basic_inf_threads_range): Remove.
1836         (inf_threads_range, inf_non_exited_threads_range)
1837         (safe_inf_threads_range): Use next_adapter.
1838
1839 2019-01-10  Keith Seitz  <keiths@redhat.com>
1840
1841         PR gdb/23712
1842         PR symtab/23010
1843         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1844         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1845
1846 2019-01-10  Keith Seitz  <keiths@redhat.com>
1847
1848         PR gdb/23712
1849         PR symtab/23010
1850         * dictionary.c (pending_to_vector): Remove.
1851         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1852         Remove _1 suffix, replacing functions of the same name.  Update
1853         all callers.
1854         (dict_create_hashed, dict_create_hashed_expandable)
1855         (dict_create_linear, dict_create_linear_expandable, dict_free)
1856         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1857         Make functions static.
1858
1859 2019-01-10  Keith Seitz  <keiths@redhat.com>
1860
1861         PR gdb/23712
1862         PR symtab/23010
1863         * dictionary.h (struct dictionary): Replace declaration with
1864         multidictionary.
1865         (dict_create_hashed, dict_create_hashed_expandable)
1866         (dict_create_linear, dict_create_linear_expandable)
1867         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1868         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1869         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1870         taking multidictionary argument.
1871         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1872         * block.h (struct block) <dict>: Change to multidictionary
1873         and rename `multidict'.
1874         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1875         symmisc.c: Update all dictionary references to multidictionary.
1876
1877 2019-01-10  Keith Seitz  <keiths@redhat.com>
1878
1879         PR gdb/23712
1880         PR symtab/23010
1881         * dictionary.c: Include unordered_map.
1882         (pending_to_vector): New function.
1883         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1884         Rewrite the non-"_1" functions to take vector instead
1885         of linked list.
1886         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1887         "new" _1 versions of the same name.
1888         (multidictionary): Define.
1889         (std::hash<enum language): New definition.
1890         (collate_pending_symbols_by_language, mdict_create_hashed)
1891         (mdict_create_hashed_expandable, mdict_create_linear)
1892         (mdict_create_linear_expandable, mdict_free)
1893         (find_language_dictionary, create_new_language_dictionary)
1894         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1895         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1896         (mdict_size, mdict_empty): New functions.
1897         * dictionary.h (mdict_iterator): Define.
1898
1899 2019-01-10  Pedro Alves  <palves@redhat.com>
1900
1901         * breakpoint.c (read_uploaded_action)
1902         (create_tracepoint_from_upload): Adjust to use
1903         gdb::unique_xmalloc_ptr.
1904         * ctf.c (ctf_write_uploaded_tp):
1905         (SET_ARRAY_FIELD): Use emplace_back.
1906         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1907         * tracefile-tfile.c (tfile_write_uploaded_tp):
1908         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1909         gdb::unique_xmalloc_ptr.
1910         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1911         at_string, cond_string, cmd_strings>: Replace char pointers
1912         with gdb::unique_xmalloc_ptr.
1913
1914 2019-01-10  Pedro Alves  <palves@redhat.com>
1915
1916         * solib-target.c (library_list_start_library): Don't xstrdup name.
1917
1918 2019-01-10  Pedro Alves  <palves@redhat.com>
1919
1920         * mdebugread.c (parse_partial_symbols): Use
1921         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1922
1923 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * linux-fork.c (scoped_switch_fork_info)
1926         <~scoped_switch_fork_info>: Fix incorrect variable name.
1927
1928 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * linux-fork.c (scoped_switch_fork_info)
1931         <scoped_switch_fork_info>: Make explicit.
1932         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1933
1934 2019-01-10  Tom Tromey  <tom@tromey.com>
1935
1936         * objfiles.h (objfile::reset_psymtabs): Update.
1937         * objfiles.c (objfile::objfile): Update.
1938         * psymtab.h (psymtab_storage::obstack): Update.
1939         (psymtab_storage::m_obstack): Use gdb::optional.
1940         (class psymtab_storage): Update comment.  Remove objfile
1941         parameter.
1942         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1943
1944 2019-01-10  Tom Tromey  <tom@tromey.com>
1945
1946         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1947         <free_psymtabs>: Now private.
1948         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1949         (allocate_psymtab): Use new method.
1950
1951 2019-01-10  Tom Tromey  <tom@tromey.com>
1952
1953         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1954         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1955         * mdebugread.c (parse_partial_symbols): Use
1956         allocate_dependencies.
1957         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1958         allocate_dependencies.
1959         (process_psymtab_comp_unit_reader)
1960         (build_type_psymtab_dependencies): Likewise.
1961         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1962
1963 2019-01-10  Tom Tromey  <tom@tromey.com>
1964
1965         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1966         PSYMBOL_SET_LANGUAGE.
1967         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1968
1969 2019-01-10  Tom Tromey  <tom@tromey.com>
1970
1971         * psymtab.h (psymtab_storage::obstack): New method.
1972         <m_obstack>: Rename from obstack; now private.
1973         * psymtab.c (psymtab_storage): Update.
1974         * dwarf2read.c (create_addrmap_from_index)
1975         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1976         Update.
1977
1978 2019-01-10  Tom Tromey  <tom@tromey.com>
1979
1980         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1981         * objfiles.h (objfile::reset_psymtabs): New method.
1982
1983 2019-01-10  Tom Tromey  <tom@tromey.com>
1984
1985         * symmisc.c (print_symbol_bcache_statistics): Update.
1986         (print_objfile_statistics): Update.
1987         * symfile.c (reread_symbols): Update.
1988         * psymtab.h (class psymtab_storage): New.
1989         * psymtab.c (psymtab_storage): New constructor.
1990         (~psymtab_storage): New destructor.
1991         (require_partial_symbols): Update.
1992         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1993         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1994         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1995         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1996         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1997         (start_psymtab_common, end_psymtab_common)
1998         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1999         (allocate_psymtab): Update.
2000         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2001         Update.
2002         (dump_psymtab_addrmap, maintenance_print_psymbols)
2003         (maintenance_check_psymtabs): Update.
2004         (class objfile_psymtabs): Move to objfiles.h.
2005         * psympriv.h (discard_psymtab): Now inline.
2006         (psymtab_discarder::psymtab_discarder): Update.
2007         (psymtab_discarder::~psymtab_discarder): Update.
2008         (ALL_OBJFILE_PSYMTABS): Rewrite.
2009         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2010         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2011         Remove fields.
2012         <partial_symtabs>: New field.
2013         (class objfile_psymtabs): Move from psymtab.h.  Update.
2014         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2015         psymbol_cache.
2016         (objfile::~objfile): Don't destroy psymbol_cache.
2017         * mdebugread.c (parse_partial_symbols): Update.
2018         * dwarf2read.c (create_addrmap_from_index)
2019         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2020         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2021         (add_partial_subprogram, dwarf2_ranges_read): Update.
2022         * dwarf-index-write.c (write_address_map)
2023         (write_one_signatured_type, recursively_write_psymbols)
2024         (class debug_names, class debug_names, write_psymtabs_to_index):
2025         Update.
2026
2027 2019-01-10  Tom Tromey  <tom@tromey.com>
2028
2029         * symtab.h (SYMBOL_SET_NAMES): Update.
2030         (symbol_set_names): Update.
2031         (MSYMBOL_SET_NAMES): Update.
2032         * symtab.c (symbol_set_names): Change argument to be an
2033         objfile_per_bfd_storage.
2034         * psymtab.c (add_psymbol_to_bcache): Update.
2035         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2036
2037 2019-01-10  Tom Tromey  <tom@tromey.com>
2038
2039         * symtab.c (create_demangled_names_hash): Change argument to be an
2040         objfile_per_bfd_storage.
2041         (symbol_set_names): Update.
2042
2043 2019-01-10  Tom Tromey  <tom@tromey.com>
2044
2045         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2046         init_psymbol_list.
2047         * psymtab.c (init_psymbol_list): Do nothing if already called.
2048         * psympriv.h (init_psymbol_list): Add comment.
2049         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2050         init_psymbol_list.
2051         * dbxread.c (dbx_symfile_read): Unconditionally call
2052         init_psymbol_list.
2053
2054 2019-01-10  Tom Tromey  <tom@tromey.com>
2055
2056         * xcoffread.c (scan_xcoff_symtab): Update.
2057         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2058         "where".
2059         * mdebugread.c (parse_partial_symbols)
2060         (handle_psymbol_enumerators): Update.
2061         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2062         * dbxread.c (read_dbx_symtab): Update.
2063         * psympriv.h (psymbol_placement): New enum.
2064         (add_psymbol_to_list): Update.
2065
2066 2019-01-10  Tom Tromey  <tom@tromey.com>
2067
2068         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2069         static_psymbols parameters.
2070         (scan_xcoff_symtab): Update.
2071         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2072         static_psymbols parameters.
2073         * psympriv.h (start_psymtab_common): Update.
2074         * mdebugread.c (parse_partial_symbols): Update.
2075         * dwarf2read.c (create_partial_symtab): Update.
2076         * dbxread.c (read_dbx_symtab): Update.
2077         (start_psymtab): Remove global_psymbols and static_psymbols
2078         parameters.
2079
2080 2019-01-10  Tom Tromey  <tom@tromey.com>
2081
2082         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2083         * psymtab.c (allocate_psymtab): Add comment.
2084         * psympriv.h (allocate_psymtab): Add comment.
2085         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2086         initializations.
2087         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2088
2089 2019-01-10  Tom Tromey  <tom@tromey.com>
2090
2091         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2092         Don't declare.
2093         * mipsread.c: Include mdebugread.h.
2094         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2095         Declare.
2096         * elfread.c: Include mdebugread.h.
2097
2098 2019-01-09  Tom Tromey  <tom@tromey.com>
2099
2100         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2101         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2102         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2103         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2104         (psym_lookup_symbol, psym_find_last_source_symtab)
2105         (psym_forget_cached_source_info, psym_print_stats)
2106         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2107         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2108         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2109         (psym_find_compunit_symtab_by_address)
2110         (maintenance_print_psymbols, maintenance_info_psymtabs)
2111         (maintenance_check_psymtabs): Use ranged for.
2112         * psymtab.h (class objfile_psymtabs): New.
2113         (require_partial_symbols): Return objfile_psymtabs.
2114         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2115
2116 2019-01-09  Tom Tromey  <tom@tromey.com>
2117
2118         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2119         (find_pc_mapped_section, list_overlays_command)
2120         (map_overlay_command, unmap_overlay_command)
2121         (simple_overlay_update): Use all_objfiles.
2122         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2123         * printcmd.c (info_symbol_command): Use all_objfiles.
2124         * objfiles.h (ALL_OBJSECTIONS): Remove.
2125         * maint.c (maintenance_translate_address): Use all_objfiles.
2126         * gcore.c (gcore_create_callback): Use all_objfiles.
2127         (objfile_find_memory_regions): Likewise.
2128
2129 2019-01-09  Tom Tromey  <tom@tromey.com>
2130
2131         * symtab.c (find_line_symtab, info_sources_command)
2132         (make_source_files_completion_list): Use objfile_compunits.
2133         * source.c (select_source_symtab): Use objfile_compunits.
2134         * objfiles.h (struct objfile): Update comment.
2135         (ALL_OBJFILES): Remove.
2136         (ALL_FILETABS): Remove.
2137         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2138         objfile_compunits.
2139
2140 2019-01-09  Tom Tromey  <tom@tromey.com>
2141
2142         * symmisc.c (print_objfile_statistics, dump_objfile)
2143         (maintenance_print_symbols): Use compunit_filetabs.
2144         * source.c (forget_cached_source_info_for_objfile): Use
2145         compunit_filetabs.
2146         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2147         (ALL_FILETABS): Use compunit_filetabs.
2148         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2149         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2150
2151 2019-01-09  Tom Tromey  <tom@tromey.com>
2152
2153         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2154         (compunit_filetabs): New.
2155         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2156         compunit_filetabs.
2157         (info_sources_command, make_source_files_completion_list): Remove
2158         declaration.
2159         * symmisc.c (print_objfile_statistics, dump_objfile)
2160         (maintenance_print_symbols): Remove declaration.
2161         (maintenance_info_symtabs): Use compunit_filetabs.
2162         (maintenance_info_line_tables): Likewise.
2163         * source.c (select_source_symtab): Change local variable name.
2164         (forget_cached_source_info_for_objfile): Remove declaration.
2165         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2166         * objfiles.c (objfile_relocate1): Remove declaration.
2167         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2168         declaration.
2169         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2170         * coffread.c (coff_symtab_read): Remove declaration.
2171         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2172         compunit_filetabs.
2173
2174 2019-01-09  Tom Tromey  <tom@tromey.com>
2175
2176         * symtab.c (lookup_objfile_from_block)
2177         (find_pc_sect_compunit_symtab, search_symbols)
2178         (default_collect_symbol_completion_matches_break_on): Use
2179         objfile_compunits.
2180         * objfiles.h (ALL_COMPUNITS): Remove.
2181         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2182         * cp-support.c (add_symbol_overload_list_qualified): Use
2183         objfile_compunits.
2184         * ada-lang.c (ada_collect_symbol_completion_matches)
2185         (ada_add_global_exceptions): Use objfile_compunits.
2186
2187 2019-01-09  Tom Tromey  <tom@tromey.com>
2188
2189         * source.c (select_source_symtab)
2190         (forget_cached_source_info_for_objfile): Remove declaration.
2191         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2192         declaration.
2193         * maint.c (count_symtabs_and_blocks): Remove declaration.
2194         * cp-support.c (add_symbol_overload_list_qualified): Remove
2195         declaration.
2196         * coffread.c (coff_symtab_read): Remove declaration.
2197         * symtab.c (lookup_symbol_in_objfile_symtabs)
2198         (basic_lookup_transparent_type_1): Use objfile_compunits.
2199         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2200         (info_sources_command, search_symbols)
2201         (default_collect_symbol_completion_matches_break_on)
2202         (make_source_files_completion_list): Remove declaration.
2203         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2204         (ada_collect_symbol_completion_matches)
2205         (ada_add_global_exceptions): Remove declaration.
2206         * linespec.c (iterate_over_all_matching_symtabs): Use
2207         objfile_compunits.
2208         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2209         (class objfile_compunits): New.
2210         (ALL_COMPUNITS): Use objfile_compunits.
2211         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2212         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2213         objfile_compunits.
2214         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2215
2216 2019-01-09  Tom Tromey  <tom@tromey.com>
2217
2218         * symtab.c (search_symbols)
2219         (default_collect_symbol_completion_matches_break_on): Use
2220         objfile_msymbols.
2221         * ada-lang.c (ada_lookup_simple_minsym)
2222         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2223         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2224         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2225         objfile_msymbols.
2226         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2227         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2228         * objc-lang.c (find_methods): Use objfile_msymbols.
2229         (info_selectors_command, info_classes_command): Likewise.
2230         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2231         * objfiles.h (class objfile_msymbols): New.
2232         (ALL_OBJFILE_MSYMBOLS): Remove.
2233         (ALL_MSYMBOLS): Remove.
2234
2235 2019-01-09  Tom Tromey  <tom@tromey.com>
2236
2237         * common/next-iterator.h (next_adapter): Add Iterator template
2238         parameter.
2239         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2240         (class all_objfiles_safe): New.
2241         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2242         * objfiles.c (put_objfile_before): Update comment.
2243         (add_separate_debug_objfile): Likewise.
2244         (free_all_objfiles): Use all_objfiles_safe.
2245         (objfile_purge_solibs): Likewise.
2246
2247 2019-01-09  Tom Tromey  <tom@tromey.com>
2248
2249         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2250         (expand_symtab_containing_pc, lookup_static_symbol)
2251         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2252         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2253         all_objfiles.
2254         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2255         * breakpoint.c (create_overlay_event_breakpoint)
2256         (create_longjmp_master_breakpoint)
2257         (create_std_terminate_master_breakpoint)
2258         (create_exception_master_breakpoint): Use all_objfiles.
2259         * linux-thread-db.c (try_thread_db_load_from_pdir)
2260         (has_libpthread): Use all_objfiles.
2261         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2262         * linespec.c (iterate_over_all_matching_symtabs)
2263         (search_minsyms_for_name): Use all_objfiles.
2264         * maint.c (maintenance_info_sections): Use all_objfiles.
2265         * main.c (captured_main_1): Use all_objfiles.
2266         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2267         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2268         * guile/scm-pretty-print.c
2269         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2270         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2271         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2272         (maintenance_print_msymbols): Use all_objfiles.
2273         * source.c (select_source_symtab): Use all_objfiles.
2274         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2275         * symfile.c (remove_symbol_file_command)
2276         (expand_symtabs_matching, map_symbol_filenames): Use
2277         all_objfiles.
2278         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2279         all_objfiles.
2280         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2281         * objc-lang.c (find_methods): Use all_objfiles.
2282         * objfiles.c (have_partial_symbols, have_full_symbols)
2283         (have_minimal_symbols, qsort_cmp)
2284         (default_iterate_over_objfiles_in_search_order): Use
2285         all_objfiles.
2286         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2287         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2288         (maintenance_check_psymtabs): Use all_objfiles.
2289         (ALL_PSYMTABS): Remove.
2290         * compile/compile-object-run.c (do_module_cleanup): Use
2291         all_objfiles.
2292         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2293         * cp-support.c (add_symbol_overload_list_qualified): Use
2294         all_objfiles.
2295         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2296         Use all_objfiles.
2297         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2298         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2299         all_objfiles.
2300         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2301         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2302         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2303         Uses all_objfiles.
2304         * solib.c (solib_read_symbols): Use all_objfiles
2305
2306 2019-01-09  Tom Tromey  <tom@tromey.com>
2307
2308         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2309         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2310         all_objfiles.
2311         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2312         * symmisc.c (print_symbol_bcache_statistics)
2313         (print_objfile_statistics, maintenance_print_objfiles)
2314         (maintenance_info_symtabs, maintenance_check_symtabs)
2315         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2316         all_objfiles.
2317         * source.c (forget_cached_source_info): Use all_objfiles.
2318         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2319         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2320         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2321         * objfiles.c (update_section_map): Use all_objfiles.
2322         (shared_objfile_contains_address_p): Likewise.
2323         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2324         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2325
2326 2019-01-09  Tom Tromey  <tom@tromey.com>
2327
2328         * common/next-iterator.h: New file.
2329         * objfiles.h (class all_objfiles): New.
2330         (struct objfile_iterator): New.
2331
2332 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2333
2334         * NEWS: Move the description of the changed "frame", "select-frame",
2335          and "info frame" commands to the Changed commands section.
2336
2337 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2338
2339         * gdbtypes.c (check_stub_method_group): Remove handling of old
2340         mangling schemes.
2341         * linespec.c (find_methods): Likewise.
2342         * stabsread.c (read_member_functions): Likewise.
2343         * valops.c (search_struct_method): Likewise.
2344         (value_struct_elt_for_reference): Likewise.
2345         * NEWS: Mention this change.
2346
2347 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2350         print_source_lines.
2351         * source.c (print_source_lines_base): Update line number check.
2352         (print_source_lines): New function.
2353         (source_lines_range::source_lines_range): New function.
2354         * source.h (class source_lines_range): New class.
2355         (print_source_lines): New declaration.
2356
2357 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2358
2359         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2360
2361 2019-01-08  Tom Tromey  <tom@tromey.com>
2362             Simon Marchi  <simon.marchi@ericsson.com>
2363
2364         PR gdb/24060
2365         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2366         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2367         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2368         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2369         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2370         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2371
2372 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2373
2374         * source.c (select_source_symtab): Move header comment to
2375         declaration in source.h.
2376         (forget_cached_source_info_for_objfile): Likewise.
2377         (forget_cached_source_info): Likewise.
2378         (identify_source_line): Likewise.
2379         * source.h (identify_source_line): Move declaration from symtab.h
2380         and add comment from source.c
2381         (print_source_lines): Likewise.
2382         (forget_cached_source_info_for_objfile): Likewise.
2383         (forget_cached_source_info): Likewise.
2384         (select_source_symtab): Likewise.
2385         (enum print_source_lines_flag): Move definition from symtab.h.
2386         * symtab.h (identify_source_line): Move declaration to source.h.
2387         (print_source_lines): Likewise.
2388         (forget_cached_source_info_for_objfile): Likewise.
2389         (forget_cached_source_info): Likewise.
2390         (select_source_symtab): Likewise.
2391         (enum print_source_lines_flag): Move definition to source.h.
2392         * tui/tui-hooks.c: Add 'source.h' include.
2393
2394 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * source.c (print_source_lines_base): Handle requests to print
2397         reverse line number sequences, and guard against empty lines
2398         string.
2399
2400 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2401
2402         * source.c (print_source_lines_base): Fix skip of '\r' if next
2403         character is '\n'.
2404
2405 2019-01-06  Tom Tromey  <tom@tromey.com>
2406
2407         * c-exp.y (struct c_parse_state) <macro_original_text,
2408         expansion_obstack>: New member.
2409         (macro_original_text, expansion_obstack): Remove globals.
2410         (scan_macro_expansion, scanning_macro_expansion)
2411         (finished_macro_expansion): Update.
2412         (scan_macro_cleanup): Remove.
2413         (yylex, c_parse): Update.
2414
2415 2019-01-06  Tom Tromey  <tom@tromey.com>
2416
2417         * c-exp.y (struct c_parse_state) <strings>: New member.
2418         (operator_stoken): Update.
2419
2420 2019-01-06  Tom Tromey  <tom@tromey.com>
2421
2422         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2423         (union type_stack_elt) <typelist_val>: Now a pointer to
2424         std::vector.
2425         (type_stack_cleanup): Don't declare.
2426         (push_typelist): Update.
2427         * parse.c (pop_typelist): Return a std::vector.
2428         (push_typelist): Take a std::vector.
2429         (follow_types): Update.  Do not free args.
2430         (type_stack_cleanup): Remove.
2431         * c-exp.y (struct c_parse_state): New.
2432         (cpstate): New global.
2433         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2434         (nonempty_typelist): Update.
2435         (func_mod): Create a new vector.
2436         (c_parse): Create a c_parse_state.
2437         (check_parameter_typelist): Do not delete params.
2438         (function_method): Update.  Do not delete type_list.
2439
2440 2019-01-06  Tom Tromey  <tom@tromey.com>
2441
2442         PR gdb/28155:
2443         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2444         check_typedef.
2445         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2446         (print_return_value): Likewise.
2447
2448 2019-01-05  Tom Tromey  <tom@tromey.com>
2449
2450         * contrib/cleanup_check.py: Remove.
2451         * contrib/gcc-with-excheck: Remove.
2452         * contrib/exsummary.py: Remove.
2453         * contrib/excheck.py: Remove.
2454
2455 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2456
2457         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2458         NULL. Initialize tpprev to NULL instead of assigning it
2459         to NULL on the next statement.
2460         * windows-nat.c (windows_delete_thread): Remove check for
2461         main_thread_id before printing thread exit notifications.
2462         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2463         Remove thread ID check against main_thread_id.
2464         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2465         windows_delete_thread.
2466         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2467
2468 2019-01-04  Tom Tromey  <tom@tromey.com>
2469
2470         * compile/compile.c (_initialize_compile): Use upper case for
2471         metasyntactic variables.
2472         * symmisc.c (_initialize_symmisc): Use upper case for
2473         metasyntactic variables.
2474         * psymtab.c (_initialize_psymtab): Use upper case for
2475         metasyntactic variables.
2476         * demangle.c (demangle_command): Use upper case for metasyntactic
2477         variables.
2478         (_initialize_demangler): Likewise.
2479         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2480         variables.
2481
2482 2019-01-03  Tom Tromey  <tom@tromey.com>
2483
2484         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2485
2486 2019-01-03  Tom Tromey  <tom@tromey.com>
2487
2488         * python/py-symtab.c (salpy_str): Update.
2489         (struct salpy_sal_object) <symtab>: Now a PyObject.
2490         (salpy_dealloc): Update.
2491         (del_objfile_sal): Use gdbpy_ref.
2492
2493 2019-01-03  Tom Tromey  <tom@tromey.com>
2494
2495         * python/py-type.c (convert_field): Use new_reference.  Return
2496         gdbpy_ref.
2497         (make_fielditem): Return gdbpy_ref.
2498         (typy_fields): Update.
2499         (typy_getitem): Update.
2500         (field_name): Return gdbpy_ref.  Use new_reference.
2501         (typy_iterator_iternext): Update.
2502
2503 2019-01-03  Tom Tromey  <tom@tromey.com>
2504
2505         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2506
2507 2019-01-03  Tom Tromey  <tom@tromey.com>
2508
2509         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2510         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2511         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2512         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2513         (pspy_set_type_printers): Likewise.
2514         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2515         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2516         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2517         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2518         (objfpy_set_type_printers): Likewise.
2519
2520 2019-01-03  Tom Tromey  <tom@tromey.com>
2521
2522         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2523         (gdbpy_print_stack): Use gdbpy_err_fetch.
2524         * python/python-internal.h (class gdbpy_err_fetch): New class.
2525         (class gdbpy_enter) <m_error_type, m_error_value,
2526         m_error_traceback>: Remove.
2527         <m_error>: New member.
2528         (gdbpy_exception_to_string): Don't declare.
2529         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2530         * python/py-value.c (convert_value_from_python): Use
2531         gdbpy_err_fetch.
2532         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2533         gdbpy_exception_to_string.
2534         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2535         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2536         gdbpy_err_fetch.
2537
2538 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2539
2540         * linux-nat.c (delete_lwp_cleanup): Delete.
2541         (struct lwp_deleter): New struct.
2542         (lwp_info_up): New typedef.
2543         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2544         lwp_info_up.
2545
2546 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2547
2548         * linux-fork.c (class scoped_switch_fork_info): New class.
2549         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2550
2551 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2552
2553         * valops.c (find_overload_match): Remove use of null_cleanup, and
2554         calls to do_cleanups.
2555
2556 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2557
2558         * compile/compile-cplus-types.c
2559         (compile_cplus_instance::decl_name): Handle changes to
2560         cp_func_name.
2561         * cp-support.c (cp_func_name): Update header comment, update
2562         return type.
2563         * cp-support.h (cp_func_name): Update return type in declaration.
2564         * valops.c (find_overload_match): Move temp_func local to top
2565         level of function and change its type.  Use temp_func to hold and
2566         delete temporary string obtained from cp_func_name.
2567
2568 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2569
2570         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2571         gdb::char_vector, remove cleanup, and update uses of `msg`.
2572
2573 2019-01-03  Jim Wilson  <jimw@sifive.com>
2574
2575         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2576
2577 2019-01-02  Tom Tromey  <tom@tromey.com>
2578
2579         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2580         (tdesc_parse_xml): Remove cleanups.
2581         * target-descriptions.h (make_cleanup_free_target_description):
2582         Don't declare.
2583         (target_desc_deleter): New struct.
2584         (target_desc_up): New typedef.
2585         * target-descriptions.c (target_desc_deleter::operator()): Rename
2586         from free_target_description.
2587         (make_cleanup_free_target_description): Remove.
2588
2589 2019-01-02  Tom Tromey  <tom@tromey.com>
2590
2591         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2592         constructor, destructor.
2593         (linespec_parser): Remove typedef.
2594         (~linespec_parser): Rename from linespec_parser_delete.
2595         (linespec_lex_to_end, linespec_complete_label)
2596         (linespec_complete): Update.
2597         (decode_line_full): Remove cleanups.
2598         (decode_line_1): Update.
2599
2600 2019-01-02  Tom Tromey  <tom@tromey.com>
2601
2602         * python/python-internal.h (inferior_to_inferior_object): Change
2603         return type.
2604         * python/py-exitedevent.c (create_exited_event_object): Update.
2605         * python/py-inferior.c (inferior_to_inferior_object): Return
2606         gdbpy_ref.
2607         (python_new_inferior, python_inferior_deleted)
2608         (thread_to_thread_object, delete_thread_object)
2609         (build_inferior_list, gdbpy_selected_inferior): Update.
2610         * python/py-infthread.c (create_thread_object): Update.  Also fail
2611         if inferior_to_inferior_object fails.
2612
2613 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2614
2615         * inferior.h (class inferior) <displaced_step_state>: New field.
2616         * infrun.h (struct displaced_step_state): Move here from
2617         infrun.c.  Initialize fields, add constructor.
2618         <inf>: Remove field.
2619         <reset>: New method.
2620         * infrun.c (struct displaced_step_inferior_state): Move to
2621         infrun.h.
2622         (displaced_step_inferior_states): Remove.
2623         (get_displaced_stepping_state): Adust.
2624         (displaced_step_in_progress_any_inferior): Adjust.
2625         (displaced_step_in_progress_thread): Adjust.
2626         (displaced_step_in_progress): Adjust.
2627         (add_displaced_stepping_state): Remove.
2628         (get_displaced_step_closure_by_addr): Adjust.
2629         (remove_displaced_stepping_state): Remove.
2630         (infrun_inferior_exit): Call displaced_step_state.reset.
2631         (use_displaced_stepping): Don't check for NULL.
2632         (displaced_step_prepare_throw): Call
2633         get_displaced_stepping_state.
2634         (displaced_step_fixup): Don't check for NULL.
2635         (prepare_for_detach): Don't check for NULL.
2636
2637 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2638
2639         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2640          in case of call that did not complete.
2641
2642 2019-01-02  Andrey Utkin  <autkin@undo.io>
2643
2644         * symfile.c (find_separate_debug_file): Fix search of debug files for
2645         remote debuggee.
2646
2647 2019-01-02  Tom Tromey  <tom@tromey.com>
2648
2649         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2650         indentation.
2651         * python/py-frame.c (frapy_older): Remove cast.
2652         (frapy_newer): Likewise.
2653         * python/py-breakpoint.c (local_setattro): Remove cast.
2654         * python/py-arch.c (archpy_name): Remove local variable.
2655         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2656
2657 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2658
2659         * unittests/basic_string_view/element_access/char/empty.cc:
2660         Fix year range in copyright header.
2661
2662 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2663
2664         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2665         Delete.
2666         <operator==>: Update with for removed field.
2667         <hash>: Likewise.
2668         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2669         <isa_features>: ...this.
2670         <abi_features>: New field.
2671         (riscv_isa_flen): Update comment.
2672         (riscv_abi_xlen): New declaration.
2673         (riscv_abi_flen): New declaration.
2674         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2675         isa_features.
2676         (riscv_abi_xlen): New function.
2677         (riscv_isa_flen): Update to get answer from isa_features.
2678         (riscv_abi_flen): New function.
2679         (riscv_has_fp_abi): Update to get answer from abi_features.
2680         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2681         xlen and flen.
2682         (riscv_call_info) <xlen, flen>: Update comment.
2683         (riscv_call_arg_struct): Remove invalid assertions
2684         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2685         is removed.
2686         (riscv_gdbarch_init): Gather isa features and abi features
2687         separately, ensure both match on the gdbarch when reusing an old
2688         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2689         a target with 64-bit float hardware.
2690
2691 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2692
2693         * source.c (search_command_helper): Stop reverse search
2694         when line 1 has been searched.
2695
2696 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2697
2698         * record-full.c (record_full_base_target::close): Rewrite
2699         record_full_core_buf_list free logic.
2700
2701 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2702
2703         * break-catch-syscall.c (print_one_catch_syscall): xfree
2704         the last text.
2705
2706 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2707
2708         * top.c (print_gdb_version): Update Copyright year in version
2709         message.
2710
2711 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2712
2713         Update copyright year range in all GDB files.
2714
2715 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2716
2717         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2718
2719 For older changes see ChangeLog-2018.
2720 \f
2721 Local Variables:
2722 mode: change-log
2723 left-margin: 8
2724 fill-column: 74
2725 version-control: never
2726 coding: utf-8
2727 End:
2728