f0797b6012c8ba06c207f9ce352a6a8e116cf314
[external/binutils.git] / gdb / ChangeLog
1 2019-04-10  Tom Tromey  <tom@tromey.com>
2
3         * symtab.c (lookup_global_symbol_from_objfile)
4         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5         * objfiles.h (class separate_debug_iterator): New.
6         (class separate_debug_range): New.
7         (struct objfile) <separate_debug_objfiles>: New method.
8         (objfile_separate_debug_iterate): Don't declare.
9         * objfiles.c (separate_debug_iterator::operator++): Rename from
10         objfile_separate_debug_iterate.
11         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
12         iterator.
13         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
14         iterator.
15
16 2019-04-10  Tom Tromey  <tom@tromey.com>
17
18         * symfile.c (reread_symbols): Remove old comment.
19         * objfiles.c (free_all_objfiles): Fix a typo.
20
21 2019-04-10  Tom Tromey  <tom@tromey.com>
22
23         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
24         * minsyms.c (lookup_minimal_symbol): Use foreach.
25         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
26         (lookup_minimal_symbol_solib_trampoline): Likewise.
27         * symfile.c (reread_symbols): Use foreach.
28
29 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
30             Tom Tromey  <tromey@adacore.com>
31
32         PR rust/24414:
33         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
34         (rust_lex_int_test): Change "value" to be LONGEST.
35         (rust_lex_tests): Add test for long integer literal.
36
37 2019-04-09  Tom Tromey  <tromey@adacore.com>
38
39         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
40         to bool.
41         (extended_remote_target::attach): Update.
42         (remote_target::remote_notice_new_inferior): Update.
43         (remote_target::add_current_inferior_and_thread): Update.
44         * inferior.c (exit_inferior_1): Use "false".
45         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
46
47 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
48
49         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
50         the "start" command.
51
52 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
53
54         * python/py-inferior.c (infpy_thread_from_thread_handle):
55         Adjust comments to reflect renaming of thread_from_thread_handle
56         to thread_from_handle.  Adjust keywords.  Fix type error message.
57         (inferior_object_methods): Add thread_from_handle.  Retain
58         thread_from_thread_handle, but mark it as deprecated.
59
60 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
61
62         * gdbthread.h (find_thread_by_handle): Revise declaration.
63         * thread.c (find_thread_by_handle): Likewise.  Adjust
64         implementation too.
65         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
66         support for buffer objects as handles.
67
68 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
69
70         * python/py-infthread.c (thpy_thread_handle): New function.
71         (thread_object_methods): Register thpy_thread_handle.
72
73 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
74
75         * gdbthread.h (thread_to_thread_handle): Declare.
76         * thread.c (gdbtypes.h): Include.
77         (thread_to_thread_handle): New function.
78
79         * target.h (struct target_ops): Add thread_info_to_thread_handle.
80         (target_thread_info_to_thread_handle): Declare.
81         * target.c (target_thread_info_to_thread_handle): New function.
82         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
83         * target-delegates.c: Regenerate.
84
85         * linux-thread-db.c (class thread_db_target): Add method
86         thread_info_to_thread_handle.
87         (thread_db_target::thread_info_to_thread_handle): Define.
88         * remote.c (class remote_target): Add new method
89         thread_info_to_thread_handle.
90         (remote_target::thread_info_to_thread_handle): Define.
91
92 2019-04-08  Pedro Alves  <palves@redhat.com>
93
94         * common/common-exceptions.c (throw_exception): Don't create
95         named object to throw; throw directly.
96         (throw_it): Likewise.  Don't initialize gdb_exception::message
97         here, with new; pass FMT and AP to the ctor instead.
98         * common/common-exceptions.h: Include <string>.
99         (gdb_exception::gdb_exception(enum return_reason, enum errors,
100         const char *, va_list)): New ctor.  Use std::make_shared.
101         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
102         errors)): Delete.
103         (gdb_exception_error::gdb_exception_error(enum errors, const char
104         *, va_list)): New.
105         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
106         Add assertion.
107         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
108         errors)): Delete.
109         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
110         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
111         Add assertion.
112
113 2019-04-08  Tom Tromey  <tom@tromey.com>
114
115         * valops.c (value_rtti_indirect_type): Replace throw_exception
116         with throw.
117         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
118         with throw.
119         * thread.c (thr_try_catch_cmd): Replace throw_exception with
120         throw.
121         * target.c (target_translate_tls_address): Replace throw_exception
122         with throw.
123         * stack.c (frame_apply_command_count): Replace throw_exception
124         with throw.
125         * solib-spu.c (append_ocl_sos): Replace throw_exception with
126         throw.
127         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
128         with throw.
129         * rs6000-tdep.c (rs6000_frame_cache)
130         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
131         * remote.c: Replace throw_exception with throw.
132         * record-full.c (record_full_message, record_full_wait_1)
133         (record_full_restore): Replace throw_exception with throw.
134         * record-btrace.c:
135         (get_thread_current_frame_id, record_btrace_start_replaying)
136         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
137         (cmd_record_btrace_start): Replace throw_exception with throw.
138         * parse.c (parse_exp_in_context_1): Replace throw_exception with
139         throw.
140         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
141         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
142         * linespec.c:
143         (find_linespec_symbols): Replace throw_exception with throw.
144         * infrun.c (displaced_step_prepare, resume): Replace
145         throw_exception with throw.
146         * infcmd.c (post_create_inferior): Replace throw_exception with
147         throw.
148         * inf-loop.c (inferior_event_handler): Replace throw_exception
149         with throw.
150         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
151         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
152         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
153         (get_prev_frame_always, get_frame_pc_if_available)
154         (get_frame_address_in_block_if_available, get_frame_language):
155         Replace throw_exception with throw.
156         * frame-unwind.c (frame_unwind_try_unwinder): Replace
157         throw_exception with throw.
158         * eval.c (fetch_subexp_value, evaluate_var_value)
159         (evaluate_funcall, evaluate_subexp_standard): Replace
160         throw_exception with throw.
161         * dwarf2loc.c (call_site_find_chain)
162         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
163         Replace throw_exception with throw.
164         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
165         with throw.
166         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
167         throw.
168         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
169         * completer.c (complete_line_internal): Replace throw_exception
170         with throw.
171         * compile/compile-object-run.c (compile_object_run): Replace
172         throw_exception with throw.
173         * cli/cli-script.c (process_next_line): Replace throw_exception
174         with throw.
175         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
176         (btrace_enable, btrace_maint_update_pt_packets): Replace
177         throw_exception with throw.
178         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
179         throw_exception with throw.
180         * break-catch-throw.c (re_set_exception_catchpoint): Replace
181         throw_exception with throw.
182         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
183         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
184         * aarch64-tdep.c (aarch64_make_prologue_cache)
185         (aarch64_make_stub_cache): Replace throw_exception with throw.
186
187 2019-04-08  Tom Tromey  <tom@tromey.com>
188
189         * common/common-exceptions.c (throw_exception): Rename from
190         throw_exception_cxx.  Remove old copy.  Make argument const.
191         (throw_it): Create and throw exception objects directly.
192         * common/common-exceptions.h (throw_exception): Make argument
193         const.
194         (struct gdb_exception_error): Add constructor.
195         (struct gdb_exception_quit): Add constructor.
196
197 2019-04-08  Tom Tromey  <tom@tromey.com>
198
199         * common/common-exceptions.h (exception_rethrow): Don't declare.
200         (TRY_SJLJ): Update comment.
201         (TRY, CATCH, END_CATCH): Remove.
202         * common/common-exceptions.c (exception_rethrow): Remove.
203
204 2019-04-08  Tom Tromey  <tom@tromey.com>
205
206         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
207         Remove.
208         (gdb_exception_error): Rename from
209         gdb_exception_RETURN_MASK_ERROR.
210         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
211         (gdb_quit_bad_alloc): Update.
212         * aarch64-tdep.c: Update.
213         * ada-lang.c: Update.
214         * ada-typeprint.c: Update.
215         * ada-valprint.c: Update.
216         * amd64-tdep.c: Update.
217         * arch-utils.c: Update.
218         * break-catch-throw.c: Update.
219         * breakpoint.c: Update.
220         * btrace.c: Update.
221         * c-varobj.c: Update.
222         * cli/cli-cmds.c: Update.
223         * cli/cli-interp.c: Update.
224         * cli/cli-script.c: Update.
225         * common/common-exceptions.c: Update.
226         * common/new-op.c: Update.
227         * common/selftest.c: Update.
228         * compile/compile-c-symbols.c: Update.
229         * compile/compile-cplus-symbols.c: Update.
230         * compile/compile-object-load.c: Update.
231         * compile/compile-object-run.c: Update.
232         * completer.c: Update.
233         * corelow.c: Update.
234         * cp-abi.c: Update.
235         * cp-support.c: Update.
236         * cp-valprint.c: Update.
237         * darwin-nat.c: Update.
238         * disasm-selftests.c: Update.
239         * dtrace-probe.c: Update.
240         * dwarf-index-cache.c: Update.
241         * dwarf-index-write.c: Update.
242         * dwarf2-frame-tailcall.c: Update.
243         * dwarf2-frame.c: Update.
244         * dwarf2loc.c: Update.
245         * dwarf2read.c: Update.
246         * eval.c: Update.
247         * event-loop.c: Update.
248         * event-top.c: Update.
249         * exec.c: Update.
250         * f-valprint.c: Update.
251         * fbsd-tdep.c: Update.
252         * frame-unwind.c: Update.
253         * frame.c: Update.
254         * gdbtypes.c: Update.
255         * gnu-v3-abi.c: Update.
256         * guile/guile-internal.h: Update.
257         * guile/scm-block.c: Update.
258         * guile/scm-breakpoint.c: Update.
259         * guile/scm-cmd.c: Update.
260         * guile/scm-disasm.c: Update.
261         * guile/scm-frame.c: Update.
262         * guile/scm-lazy-string.c: Update.
263         * guile/scm-math.c: Update.
264         * guile/scm-param.c: Update.
265         * guile/scm-ports.c: Update.
266         * guile/scm-pretty-print.c: Update.
267         * guile/scm-symbol.c: Update.
268         * guile/scm-symtab.c: Update.
269         * guile/scm-type.c: Update.
270         * guile/scm-value.c: Update.
271         * i386-linux-tdep.c: Update.
272         * i386-tdep.c: Update.
273         * inf-loop.c: Update.
274         * infcall.c: Update.
275         * infcmd.c: Update.
276         * infrun.c: Update.
277         * jit.c: Update.
278         * language.c: Update.
279         * linespec.c: Update.
280         * linux-fork.c: Update.
281         * linux-nat.c: Update.
282         * linux-tdep.c: Update.
283         * linux-thread-db.c: Update.
284         * main.c: Update.
285         * mi/mi-cmd-break.c: Update.
286         * mi/mi-cmd-stack.c: Update.
287         * mi/mi-interp.c: Update.
288         * mi/mi-main.c: Update.
289         * objc-lang.c: Update.
290         * p-valprint.c: Update.
291         * parse.c: Update.
292         * ppc-linux-tdep.c: Update.
293         * printcmd.c: Update.
294         * python/py-arch.c: Update.
295         * python/py-breakpoint.c: Update.
296         * python/py-cmd.c: Update.
297         * python/py-finishbreakpoint.c: Update.
298         * python/py-frame.c: Update.
299         * python/py-framefilter.c: Update.
300         * python/py-gdb-readline.c: Update.
301         * python/py-inferior.c: Update.
302         * python/py-infthread.c: Update.
303         * python/py-lazy-string.c: Update.
304         * python/py-linetable.c: Update.
305         * python/py-objfile.c: Update.
306         * python/py-param.c: Update.
307         * python/py-prettyprint.c: Update.
308         * python/py-progspace.c: Update.
309         * python/py-record-btrace.c: Update.
310         * python/py-record.c: Update.
311         * python/py-symbol.c: Update.
312         * python/py-type.c: Update.
313         * python/py-unwind.c: Update.
314         * python/py-utils.c: Update.
315         * python/py-value.c: Update.
316         * python/python.c: Update.
317         * record-btrace.c: Update.
318         * record-full.c: Update.
319         * remote-fileio.c: Update.
320         * remote.c: Update.
321         * riscv-tdep.c: Update.
322         * rs6000-aix-tdep.c: Update.
323         * rs6000-tdep.c: Update.
324         * rust-exp.y: Update.
325         * rust-lang.c: Update.
326         * s390-tdep.c: Update.
327         * selftest-arch.c: Update.
328         * solib-dsbt.c: Update.
329         * solib-frv.c: Update.
330         * solib-spu.c: Update.
331         * solib-svr4.c: Update.
332         * solib.c: Update.
333         * sparc64-linux-tdep.c: Update.
334         * stack.c: Update.
335         * symfile-mem.c: Update.
336         * symmisc.c: Update.
337         * target.c: Update.
338         * thread.c: Update.
339         * top.c: Update.
340         * tracefile-tfile.c: Update.
341         * tui/tui.c: Update.
342         * typeprint.c: Update.
343         * unittests/cli-utils-selftests.c: Update.
344         * unittests/parse-connection-spec-selftests.c: Update.
345         * valops.c: Update.
346         * valprint.c: Update.
347         * value.c: Update.
348         * varobj.c: Update.
349         * windows-nat.c: Update.
350         * x86-linux-nat.c: Update.
351         * xml-support.c: Update.
352
353 2019-04-08  Tom Tromey  <tom@tromey.com>
354
355         * xml-support.c: Use C++ exception handling.
356         * x86-linux-nat.c: Use C++ exception handling.
357         * windows-nat.c: Use C++ exception handling.
358         * varobj.c: Use C++ exception handling.
359         * value.c: Use C++ exception handling.
360         * valprint.c: Use C++ exception handling.
361         * valops.c: Use C++ exception handling.
362         * unittests/parse-connection-spec-selftests.c: Use C++ exception
363         handling.
364         * unittests/cli-utils-selftests.c: Use C++ exception handling.
365         * typeprint.c: Use C++ exception handling.
366         * tui/tui.c: Use C++ exception handling.
367         * tracefile-tfile.c: Use C++ exception handling.
368         * top.c: Use C++ exception handling.
369         * thread.c: Use C++ exception handling.
370         * target.c: Use C++ exception handling.
371         * symmisc.c: Use C++ exception handling.
372         * symfile-mem.c: Use C++ exception handling.
373         * stack.c: Use C++ exception handling.
374         * sparc64-linux-tdep.c: Use C++ exception handling.
375         * solib.c: Use C++ exception handling.
376         * solib-svr4.c: Use C++ exception handling.
377         * solib-spu.c: Use C++ exception handling.
378         * solib-frv.c: Use C++ exception handling.
379         * solib-dsbt.c: Use C++ exception handling.
380         * selftest-arch.c: Use C++ exception handling.
381         * s390-tdep.c: Use C++ exception handling.
382         * rust-lang.c: Use C++ exception handling.
383         * rust-exp.y: Use C++ exception handling.
384         * rs6000-tdep.c: Use C++ exception handling.
385         * rs6000-aix-tdep.c: Use C++ exception handling.
386         * riscv-tdep.c: Use C++ exception handling.
387         * remote.c: Use C++ exception handling.
388         * remote-fileio.c: Use C++ exception handling.
389         * record-full.c: Use C++ exception handling.
390         * record-btrace.c: Use C++ exception handling.
391         * python/python.c: Use C++ exception handling.
392         * python/py-value.c: Use C++ exception handling.
393         * python/py-utils.c: Use C++ exception handling.
394         * python/py-unwind.c: Use C++ exception handling.
395         * python/py-type.c: Use C++ exception handling.
396         * python/py-symbol.c: Use C++ exception handling.
397         * python/py-record.c: Use C++ exception handling.
398         * python/py-record-btrace.c: Use C++ exception handling.
399         * python/py-progspace.c: Use C++ exception handling.
400         * python/py-prettyprint.c: Use C++ exception handling.
401         * python/py-param.c: Use C++ exception handling.
402         * python/py-objfile.c: Use C++ exception handling.
403         * python/py-linetable.c: Use C++ exception handling.
404         * python/py-lazy-string.c: Use C++ exception handling.
405         * python/py-infthread.c: Use C++ exception handling.
406         * python/py-inferior.c: Use C++ exception handling.
407         * python/py-gdb-readline.c: Use C++ exception handling.
408         * python/py-framefilter.c: Use C++ exception handling.
409         * python/py-frame.c: Use C++ exception handling.
410         * python/py-finishbreakpoint.c: Use C++ exception handling.
411         * python/py-cmd.c: Use C++ exception handling.
412         * python/py-breakpoint.c: Use C++ exception handling.
413         * python/py-arch.c: Use C++ exception handling.
414         * printcmd.c: Use C++ exception handling.
415         * ppc-linux-tdep.c: Use C++ exception handling.
416         * parse.c: Use C++ exception handling.
417         * p-valprint.c: Use C++ exception handling.
418         * objc-lang.c: Use C++ exception handling.
419         * mi/mi-main.c: Use C++ exception handling.
420         * mi/mi-interp.c: Use C++ exception handling.
421         * mi/mi-cmd-stack.c: Use C++ exception handling.
422         * mi/mi-cmd-break.c: Use C++ exception handling.
423         * main.c: Use C++ exception handling.
424         * linux-thread-db.c: Use C++ exception handling.
425         * linux-tdep.c: Use C++ exception handling.
426         * linux-nat.c: Use C++ exception handling.
427         * linux-fork.c: Use C++ exception handling.
428         * linespec.c: Use C++ exception handling.
429         * language.c: Use C++ exception handling.
430         * jit.c: Use C++ exception handling.
431         * infrun.c: Use C++ exception handling.
432         * infcmd.c: Use C++ exception handling.
433         * infcall.c: Use C++ exception handling.
434         * inf-loop.c: Use C++ exception handling.
435         * i386-tdep.c: Use C++ exception handling.
436         * i386-linux-tdep.c: Use C++ exception handling.
437         * guile/scm-value.c: Use C++ exception handling.
438         * guile/scm-type.c: Use C++ exception handling.
439         * guile/scm-symtab.c: Use C++ exception handling.
440         * guile/scm-symbol.c: Use C++ exception handling.
441         * guile/scm-pretty-print.c: Use C++ exception handling.
442         * guile/scm-ports.c: Use C++ exception handling.
443         * guile/scm-param.c: Use C++ exception handling.
444         * guile/scm-math.c: Use C++ exception handling.
445         * guile/scm-lazy-string.c: Use C++ exception handling.
446         * guile/scm-frame.c: Use C++ exception handling.
447         * guile/scm-disasm.c: Use C++ exception handling.
448         * guile/scm-cmd.c: Use C++ exception handling.
449         * guile/scm-breakpoint.c: Use C++ exception handling.
450         * guile/scm-block.c: Use C++ exception handling.
451         * guile/guile-internal.h: Use C++ exception handling.
452         * gnu-v3-abi.c: Use C++ exception handling.
453         * gdbtypes.c: Use C++ exception handling.
454         * frame.c: Use C++ exception handling.
455         * frame-unwind.c: Use C++ exception handling.
456         * fbsd-tdep.c: Use C++ exception handling.
457         * f-valprint.c: Use C++ exception handling.
458         * exec.c: Use C++ exception handling.
459         * event-top.c: Use C++ exception handling.
460         * event-loop.c: Use C++ exception handling.
461         * eval.c: Use C++ exception handling.
462         * dwarf2read.c: Use C++ exception handling.
463         * dwarf2loc.c: Use C++ exception handling.
464         * dwarf2-frame.c: Use C++ exception handling.
465         * dwarf2-frame-tailcall.c: Use C++ exception handling.
466         * dwarf-index-write.c: Use C++ exception handling.
467         * dwarf-index-cache.c: Use C++ exception handling.
468         * dtrace-probe.c: Use C++ exception handling.
469         * disasm-selftests.c: Use C++ exception handling.
470         * darwin-nat.c: Use C++ exception handling.
471         * cp-valprint.c: Use C++ exception handling.
472         * cp-support.c: Use C++ exception handling.
473         * cp-abi.c: Use C++ exception handling.
474         * corelow.c: Use C++ exception handling.
475         * completer.c: Use C++ exception handling.
476         * compile/compile-object-run.c: Use C++ exception handling.
477         * compile/compile-object-load.c: Use C++ exception handling.
478         * compile/compile-cplus-symbols.c: Use C++ exception handling.
479         * compile/compile-c-symbols.c: Use C++ exception handling.
480         * common/selftest.c: Use C++ exception handling.
481         * common/new-op.c: Use C++ exception handling.
482         * cli/cli-script.c: Use C++ exception handling.
483         * cli/cli-interp.c: Use C++ exception handling.
484         * cli/cli-cmds.c: Use C++ exception handling.
485         * c-varobj.c: Use C++ exception handling.
486         * btrace.c: Use C++ exception handling.
487         * breakpoint.c: Use C++ exception handling.
488         * break-catch-throw.c: Use C++ exception handling.
489         * arch-utils.c: Use C++ exception handling.
490         * amd64-tdep.c: Use C++ exception handling.
491         * ada-valprint.c: Use C++ exception handling.
492         * ada-typeprint.c: Use C++ exception handling.
493         * ada-lang.c: Use C++ exception handling.
494         * aarch64-tdep.c: Use C++ exception handling.
495
496 2019-04-08  Tom Tromey  <tom@tromey.com>
497
498         * xml-support.c (gdb_xml_parser::parse): Update.
499         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
500         * value.c (show_convenience): Update.
501         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
502         (test_parse_flags_qcs): Update.
503         * thread.c (thr_try_catch_cmd): Update.
504         * target.c (target_translate_tls_address): Update.
505         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
506         (info_frame_command_core, frame_apply_command_count): Update.
507         * rust-exp.y (rust_lex_exception_test): Update.
508         * riscv-tdep.c (riscv_print_one_register_info): Update.
509         * remote.c (remote_target::enable_btrace): Update.
510         * record-btrace.c (record_btrace_enable_warn): Update.
511         * python/py-utils.c (gdbpy_convert_exception): Update.
512         * printcmd.c (do_one_display, print_variable_and_value): Update.
513         * mi/mi-main.c (mi_print_exception): Update.
514         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
515         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
516         * linux-nat.c (linux_nat_target::attach): Update.
517         * linux-fork.c (class scoped_switch_fork_info): Update.
518         * infrun.c (displaced_step_prepare): Update.
519         * infcall.c (call_function_by_hand_dummy): Update.
520         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
521         * gnu-v3-abi.c (print_one_vtable): Update.
522         * frame.c (get_prev_frame_always): Update.
523         * f-valprint.c (info_common_command_for_block): Update.
524         * exec.c (try_open_exec_file): Update.
525         * exceptions.c (print_exception, exception_print)
526         (exception_fprintf, exception_print_same): Update.
527         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
528         * dwarf-index-cache.c (index_cache::store)
529         (index_cache::lookup_gdb_index): Update.
530         * darwin-nat.c (maybe_cache_shell): Update.
531         * cp-valprint.c (cp_print_value_fields): Update.
532         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
533         (gcc_cplus_symbol_address): Update.
534         * compile/compile-c-symbols.c (gcc_convert_symbol)
535         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
536         * common/selftest.c: Update.
537         * common/common-exceptions.h (struct gdb_exception) <message>: Now
538         a std::string.
539         (exception_try_scope_entry, exception_try_scope_exit): Don't
540         declare.
541         (struct exception_try_scope): Remove.
542         (TRY): Don't use exception_try_scope.
543         (struct gdb_exception): Add constructor, operator=.
544         <what>: New method.
545         (struct gdb_exception_RETURN_MASK_ALL)
546         (struct gdb_exception_RETURN_MASK_ERROR)
547         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
548         (struct gdb_quit_bad_alloc): Update.
549         * common/common-exceptions.c (exception_none): Change
550         initializer.
551         (struct catcher) <state, exception>: Initialize inline.
552         <prev>: Remove member.
553         (current_catcher): Remove.
554         (catchers): New global.
555         (exceptions_state_mc_init): Simplify.
556         (catcher_pop): Remove.
557         (exceptions_state_mc, exceptions_state_mc_catch): Update.
558         (try_scope_depth, exception_try_scope_entry)
559         (exception_try_scope_exit): Remove.
560         (throw_exception_sjlj): Update.
561         (exception_messages, exception_messages_size): Remove.
562         (throw_it): Simplify.
563         (gdb_exception_sliced_copy): Remove.
564         (throw_exception_cxx): Update.
565         * cli/cli-script.c (script_from_file): Update.
566         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
567         Update.
568         * ada-valprint.c (ada_val_print): Update.
569         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
570         (create_excep_cond_exprs): Update.
571
572 2019-04-08  Tom Tromey  <tom@tromey.com>
573
574         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
575         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
576         (TRY, CATCH, END_CATCH): Remove some definitions.
577         * common/common-exceptions.c: Don't use GDB_XCPT.
578         (catcher_list_size): Remove.
579         (throw_exception, throw_it): Simplify.
580
581 2019-04-05  Tom Tromey  <tom@tromey.com>
582
583         Revert the header-sorting patch.
584         * ft32-tdep.c: Revert.
585         * frv-tdep.c: Revert.
586         * frv-linux-tdep.c: Revert.
587         * frame.c: Revert.
588         * frame-unwind.c: Revert.
589         * frame-base.c: Revert.
590         * fork-child.c: Revert.
591         * findvar.c: Revert.
592         * findcmd.c: Revert.
593         * filesystem.c: Revert.
594         * filename-seen-cache.h: Revert.
595         * filename-seen-cache.c: Revert.
596         * fbsd-tdep.c: Revert.
597         * fbsd-nat.h: Revert.
598         * fbsd-nat.c: Revert.
599         * f-valprint.c: Revert.
600         * f-typeprint.c: Revert.
601         * f-lang.c: Revert.
602         * extension.h: Revert.
603         * extension.c: Revert.
604         * extension-priv.h: Revert.
605         * expprint.c: Revert.
606         * exec.h: Revert.
607         * exec.c: Revert.
608         * exceptions.c: Revert.
609         * event-top.c: Revert.
610         * event-loop.c: Revert.
611         * eval.c: Revert.
612         * elfread.c: Revert.
613         * dwarf2read.h: Revert.
614         * dwarf2read.c: Revert.
615         * dwarf2loc.c: Revert.
616         * dwarf2expr.h: Revert.
617         * dwarf2expr.c: Revert.
618         * dwarf2-frame.c: Revert.
619         * dwarf2-frame-tailcall.c: Revert.
620         * dwarf-index-write.h: Revert.
621         * dwarf-index-write.c: Revert.
622         * dwarf-index-common.c: Revert.
623         * dwarf-index-cache.h: Revert.
624         * dwarf-index-cache.c: Revert.
625         * dummy-frame.c: Revert.
626         * dtrace-probe.c: Revert.
627         * disasm.h: Revert.
628         * disasm.c: Revert.
629         * disasm-selftests.c: Revert.
630         * dictionary.c: Revert.
631         * dicos-tdep.c: Revert.
632         * demangle.c: Revert.
633         * dcache.h: Revert.
634         * dcache.c: Revert.
635         * darwin-nat.h: Revert.
636         * darwin-nat.c: Revert.
637         * darwin-nat-info.c: Revert.
638         * d-valprint.c: Revert.
639         * d-namespace.c: Revert.
640         * d-lang.c: Revert.
641         * ctf.c: Revert.
642         * csky-tdep.c: Revert.
643         * csky-linux-tdep.c: Revert.
644         * cris-tdep.c: Revert.
645         * cris-linux-tdep.c: Revert.
646         * cp-valprint.c: Revert.
647         * cp-support.c: Revert.
648         * cp-namespace.c: Revert.
649         * cp-abi.c: Revert.
650         * corelow.c: Revert.
651         * corefile.c: Revert.
652         * continuations.c: Revert.
653         * completer.h: Revert.
654         * completer.c: Revert.
655         * complaints.c: Revert.
656         * coffread.c: Revert.
657         * coff-pe-read.c: Revert.
658         * cli-out.h: Revert.
659         * cli-out.c: Revert.
660         * charset.c: Revert.
661         * c-varobj.c: Revert.
662         * c-valprint.c: Revert.
663         * c-typeprint.c: Revert.
664         * c-lang.c: Revert.
665         * buildsym.c: Revert.
666         * buildsym-legacy.c: Revert.
667         * build-id.h: Revert.
668         * build-id.c: Revert.
669         * btrace.c: Revert.
670         * bsd-uthread.c: Revert.
671         * breakpoint.h: Revert.
672         * breakpoint.c: Revert.
673         * break-catch-throw.c: Revert.
674         * break-catch-syscall.c: Revert.
675         * break-catch-sig.c: Revert.
676         * blockframe.c: Revert.
677         * block.c: Revert.
678         * bfin-tdep.c: Revert.
679         * bfin-linux-tdep.c: Revert.
680         * bfd-target.c: Revert.
681         * bcache.c: Revert.
682         * ax-general.c: Revert.
683         * ax-gdb.h: Revert.
684         * ax-gdb.c: Revert.
685         * avr-tdep.c: Revert.
686         * auxv.c: Revert.
687         * auto-load.c: Revert.
688         * arm-wince-tdep.c: Revert.
689         * arm-tdep.c: Revert.
690         * arm-symbian-tdep.c: Revert.
691         * arm-pikeos-tdep.c: Revert.
692         * arm-obsd-tdep.c: Revert.
693         * arm-nbsd-tdep.c: Revert.
694         * arm-nbsd-nat.c: Revert.
695         * arm-linux-tdep.c: Revert.
696         * arm-linux-nat.c: Revert.
697         * arm-fbsd-tdep.c: Revert.
698         * arm-fbsd-nat.c: Revert.
699         * arm-bsd-tdep.c: Revert.
700         * arch-utils.c: Revert.
701         * arc-tdep.c: Revert.
702         * arc-newlib-tdep.c: Revert.
703         * annotate.h: Revert.
704         * annotate.c: Revert.
705         * amd64-windows-tdep.c: Revert.
706         * amd64-windows-nat.c: Revert.
707         * amd64-tdep.c: Revert.
708         * amd64-sol2-tdep.c: Revert.
709         * amd64-obsd-tdep.c: Revert.
710         * amd64-obsd-nat.c: Revert.
711         * amd64-nbsd-tdep.c: Revert.
712         * amd64-nbsd-nat.c: Revert.
713         * amd64-nat.c: Revert.
714         * amd64-linux-tdep.c: Revert.
715         * amd64-linux-nat.c: Revert.
716         * amd64-fbsd-tdep.c: Revert.
717         * amd64-fbsd-nat.c: Revert.
718         * amd64-dicos-tdep.c: Revert.
719         * amd64-darwin-tdep.c: Revert.
720         * amd64-bsd-nat.c: Revert.
721         * alpha-tdep.c: Revert.
722         * alpha-obsd-tdep.c: Revert.
723         * alpha-nbsd-tdep.c: Revert.
724         * alpha-mdebug-tdep.c: Revert.
725         * alpha-linux-tdep.c: Revert.
726         * alpha-linux-nat.c: Revert.
727         * alpha-bsd-tdep.c: Revert.
728         * alpha-bsd-nat.c: Revert.
729         * aix-thread.c: Revert.
730         * agent.c: Revert.
731         * addrmap.c: Revert.
732         * ada-varobj.c: Revert.
733         * ada-valprint.c: Revert.
734         * ada-typeprint.c: Revert.
735         * ada-tasks.c: Revert.
736         * ada-lang.c: Revert.
737         * aarch64-tdep.c: Revert.
738         * aarch64-ravenscar-thread.c: Revert.
739         * aarch64-newlib-tdep.c: Revert.
740         * aarch64-linux-tdep.c: Revert.
741         * aarch64-linux-nat.c: Revert.
742         * aarch64-fbsd-tdep.c: Revert.
743         * aarch64-fbsd-nat.c: Revert.
744         * aarch32-linux-nat.c: Revert.
745
746 2019-04-05  Tom Tromey  <tom@tromey.com>
747
748         * ft32-tdep.c: Sort headers.
749         * frv-tdep.c: Sort headers.
750         * frv-linux-tdep.c: Sort headers.
751         * frame.c: Sort headers.
752         * frame-unwind.c: Sort headers.
753         * frame-base.c: Sort headers.
754         * fork-child.c: Sort headers.
755         * findvar.c: Sort headers.
756         * findcmd.c: Sort headers.
757         * filesystem.c: Sort headers.
758         * filename-seen-cache.h: Sort headers.
759         * filename-seen-cache.c: Sort headers.
760         * fbsd-tdep.c: Sort headers.
761         * fbsd-nat.h: Sort headers.
762         * fbsd-nat.c: Sort headers.
763         * f-valprint.c: Sort headers.
764         * f-typeprint.c: Sort headers.
765         * f-lang.c: Sort headers.
766         * extension.h: Sort headers.
767         * extension.c: Sort headers.
768         * extension-priv.h: Sort headers.
769         * expprint.c: Sort headers.
770         * exec.h: Sort headers.
771         * exec.c: Sort headers.
772         * exceptions.c: Sort headers.
773         * event-top.c: Sort headers.
774         * event-loop.c: Sort headers.
775         * eval.c: Sort headers.
776         * elfread.c: Sort headers.
777         * dwarf2read.h: Sort headers.
778         * dwarf2read.c: Sort headers.
779         * dwarf2loc.c: Sort headers.
780         * dwarf2expr.h: Sort headers.
781         * dwarf2expr.c: Sort headers.
782         * dwarf2-frame.c: Sort headers.
783         * dwarf2-frame-tailcall.c: Sort headers.
784         * dwarf-index-write.h: Sort headers.
785         * dwarf-index-write.c: Sort headers.
786         * dwarf-index-common.c: Sort headers.
787         * dwarf-index-cache.h: Sort headers.
788         * dwarf-index-cache.c: Sort headers.
789         * dummy-frame.c: Sort headers.
790         * dtrace-probe.c: Sort headers.
791         * disasm.h: Sort headers.
792         * disasm.c: Sort headers.
793         * disasm-selftests.c: Sort headers.
794         * dictionary.c: Sort headers.
795         * dicos-tdep.c: Sort headers.
796         * demangle.c: Sort headers.
797         * dcache.h: Sort headers.
798         * dcache.c: Sort headers.
799         * darwin-nat.h: Sort headers.
800         * darwin-nat.c: Sort headers.
801         * darwin-nat-info.c: Sort headers.
802         * d-valprint.c: Sort headers.
803         * d-namespace.c: Sort headers.
804         * d-lang.c: Sort headers.
805         * ctf.c: Sort headers.
806         * csky-tdep.c: Sort headers.
807         * csky-linux-tdep.c: Sort headers.
808         * cris-tdep.c: Sort headers.
809         * cris-linux-tdep.c: Sort headers.
810         * cp-valprint.c: Sort headers.
811         * cp-support.c: Sort headers.
812         * cp-namespace.c: Sort headers.
813         * cp-abi.c: Sort headers.
814         * corelow.c: Sort headers.
815         * corefile.c: Sort headers.
816         * continuations.c: Sort headers.
817         * completer.h: Sort headers.
818         * completer.c: Sort headers.
819         * complaints.c: Sort headers.
820         * coffread.c: Sort headers.
821         * coff-pe-read.c: Sort headers.
822         * cli-out.h: Sort headers.
823         * cli-out.c: Sort headers.
824         * charset.c: Sort headers.
825         * c-varobj.c: Sort headers.
826         * c-valprint.c: Sort headers.
827         * c-typeprint.c: Sort headers.
828         * c-lang.c: Sort headers.
829         * buildsym.c: Sort headers.
830         * buildsym-legacy.c: Sort headers.
831         * build-id.h: Sort headers.
832         * build-id.c: Sort headers.
833         * btrace.c: Sort headers.
834         * bsd-uthread.c: Sort headers.
835         * breakpoint.h: Sort headers.
836         * breakpoint.c: Sort headers.
837         * break-catch-throw.c: Sort headers.
838         * break-catch-syscall.c: Sort headers.
839         * break-catch-sig.c: Sort headers.
840         * blockframe.c: Sort headers.
841         * block.c: Sort headers.
842         * bfin-tdep.c: Sort headers.
843         * bfin-linux-tdep.c: Sort headers.
844         * bfd-target.c: Sort headers.
845         * bcache.c: Sort headers.
846         * ax-general.c: Sort headers.
847         * ax-gdb.h: Sort headers.
848         * ax-gdb.c: Sort headers.
849         * avr-tdep.c: Sort headers.
850         * auxv.c: Sort headers.
851         * auto-load.c: Sort headers.
852         * arm-wince-tdep.c: Sort headers.
853         * arm-tdep.c: Sort headers.
854         * arm-symbian-tdep.c: Sort headers.
855         * arm-pikeos-tdep.c: Sort headers.
856         * arm-obsd-tdep.c: Sort headers.
857         * arm-nbsd-tdep.c: Sort headers.
858         * arm-nbsd-nat.c: Sort headers.
859         * arm-linux-tdep.c: Sort headers.
860         * arm-linux-nat.c: Sort headers.
861         * arm-fbsd-tdep.c: Sort headers.
862         * arm-fbsd-nat.c: Sort headers.
863         * arm-bsd-tdep.c: Sort headers.
864         * arch-utils.c: Sort headers.
865         * arc-tdep.c: Sort headers.
866         * arc-newlib-tdep.c: Sort headers.
867         * annotate.h: Sort headers.
868         * annotate.c: Sort headers.
869         * amd64-windows-tdep.c: Sort headers.
870         * amd64-windows-nat.c: Sort headers.
871         * amd64-tdep.c: Sort headers.
872         * amd64-sol2-tdep.c: Sort headers.
873         * amd64-obsd-tdep.c: Sort headers.
874         * amd64-obsd-nat.c: Sort headers.
875         * amd64-nbsd-tdep.c: Sort headers.
876         * amd64-nbsd-nat.c: Sort headers.
877         * amd64-nat.c: Sort headers.
878         * amd64-linux-tdep.c: Sort headers.
879         * amd64-linux-nat.c: Sort headers.
880         * amd64-fbsd-tdep.c: Sort headers.
881         * amd64-fbsd-nat.c: Sort headers.
882         * amd64-dicos-tdep.c: Sort headers.
883         * amd64-darwin-tdep.c: Sort headers.
884         * amd64-bsd-nat.c: Sort headers.
885         * alpha-tdep.c: Sort headers.
886         * alpha-obsd-tdep.c: Sort headers.
887         * alpha-nbsd-tdep.c: Sort headers.
888         * alpha-mdebug-tdep.c: Sort headers.
889         * alpha-linux-tdep.c: Sort headers.
890         * alpha-linux-nat.c: Sort headers.
891         * alpha-bsd-tdep.c: Sort headers.
892         * alpha-bsd-nat.c: Sort headers.
893         * aix-thread.c: Sort headers.
894         * agent.c: Sort headers.
895         * addrmap.c: Sort headers.
896         * ada-varobj.c: Sort headers.
897         * ada-valprint.c: Sort headers.
898         * ada-typeprint.c: Sort headers.
899         * ada-tasks.c: Sort headers.
900         * ada-lang.c: Sort headers.
901         * aarch64-tdep.c: Sort headers.
902         * aarch64-ravenscar-thread.c: Sort headers.
903         * aarch64-newlib-tdep.c: Sort headers.
904         * aarch64-linux-tdep.c: Sort headers.
905         * aarch64-linux-nat.c: Sort headers.
906         * aarch64-fbsd-tdep.c: Sort headers.
907         * aarch64-fbsd-nat.c: Sort headers.
908         * aarch32-linux-nat.c: Sort headers.
909
910 2019-04-04  Tom Tromey  <tom@tromey.com>
911
912         * varobj.c (varobj_create): Update.
913         * rust-exp.y (struct rust_parser) <update_innermost_block,
914         lookup_symbol>: New methods.
915         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
916         Rename.
917         (rust_parser::rust_lookup_type)
918         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
919         * printcmd.c (display_command, do_one_display): Update.
920         * parser-defs.h (struct parser_state) <parser_state>: Add
921         "tracker" parameter.
922         (block_tracker): New member.
923         (class innermost_block_tracker) <innermost_block_tracker>: Add
924         "types" parameter.
925         <reset>: Remove method.
926         (innermost_block): Don't declare.
927         (null_post_parser): Update.
928         * parse.c (innermost_block): Remove global.
929         (write_dollar_variable): Update.
930         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
931         Remove "tracker_types" parameter.
932         (parse_expression): Add "tracker" parameter.
933         (parse_expression_for_completion): Update.
934         (null_post_parser): Add "tracker" parameter.
935         * p-exp.y: Update rules.
936         * m2-exp.y: Update rules.
937         * language.h (struct language_defn) <la_post_parser>: Add
938         "tracker" parameter.
939         * go-exp.y: Update rules.
940         * f-exp.y: Update rules.
941         * expression.h (parse_expression, parse_exp_1): Add "tracker"
942         parameter.
943         * d-exp.y: Update rules.
944         * c-exp.y: Update rules.
945         * breakpoint.c (set_breakpoint_condition): Create an
946         innermost_block_tracker.
947         (watch_command_1): Likewise.
948         * ada-lang.c (resolve): Add "tracker" parameter.
949         (resolve_subexp): Likewise.
950         * ada-exp.y (write_var_from_sym): Update.
951
952 2019-04-04  Tom Tromey  <tom@tromey.com>
953
954         * type-stack.h: New file.
955         * type-stack.c: New file.
956         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
957         type-stack.h.
958         (insert_into_type_stack, insert_type, push_type, push_type_int)
959         (insert_type_address_space, pop_type, pop_type_int)
960         (pop_typelist, pop_type_stack, append_type_stack)
961         (push_type_stack, get_type_stack, push_typelist)
962         (follow_type_instance_flags, follow_types): Don't declare.
963         * parse.c (type_stack): Remove global.
964         (parse_exp_in_context): Update.
965         (insert_into_type_stack, insert_type, push_type, push_type_int)
966         (insert_type_address_space, pop_type, pop_type_int)
967         (pop_typelist, pop_type_stack, append_type_stack)
968         (push_type_stack, get_type_stack, push_typelist)
969         (follow_type_instance_flags, follow_types): Remove (moved to
970         type-stack.c).
971         * f-exp.y (type_stack): New global.
972         Update rules.
973         (push_kind_type, f_parse): Update.
974         * d-exp.y (type_stack): New global.
975         Update rules.
976         (d_parse): Update.
977         * c-exp.y (struct c_parse_state) <type_stack>: New member.
978         Update rules.
979         * Makefile.in (COMMON_SFILES): Add type-stack.c.
980         (HFILES_NO_SRCDIR): Add type-stack.h.
981
982 2019-04-04  Tom Tromey  <tom@tromey.com>
983
984         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
985         (rust_parser::convert_ast_to_expression, rust_parse)
986         (rust_lex_test_completion, rust_lex_tests): Update.
987         * parser-defs.h (struct expr_completion_state): New.
988         (struct parser_state) <parser_state>: Add completion parameter.
989         <mark_struct_expression, mark_completion_tag>: New methods.
990         <parse_completion, m_completion_state>: New members.
991         (prefixify_expression, null_post_parser): Update.
992         (mark_struct_expression, mark_completion_tag): Don't declare.
993         * parse.c (parse_completion, expout_last_struct)
994         (expout_tag_completion_type, expout_completion_name): Remove
995         globals.
996         (parser_state::mark_struct_expression)
997         (parser_state::mark_completion_tag): Now methods.
998         (prefixify_expression): Add last_struct parameter.
999         (prefixify_subexp): Likewise.
1000         (parse_exp_1): Update.
1001         (parse_exp_in_context): Add cstate parameter.  Update.
1002         (parse_expression_for_completion): Create an
1003         expr_completion_state.
1004         (null_post_parser): Add "completion" parameter.
1005         * p-exp.y: Update rules.
1006         (yylex): Update.
1007         * language.h (struct language_defn) <la_post_parser>: Add
1008         "completing" parameter.
1009         * go-exp.y: Update rules.
1010         (lex_one_token): Update.
1011         * expression.h (parse_completion): Don't declare.
1012         * d-exp.y: Update rules.
1013         (lex_one_token): Update rules.
1014         * c-exp.y: Update rules.
1015         (lex_one_token): Update.
1016         * ada-lang.c (resolve): Add "parse_completion" parameter.
1017         (resolve_subexp): Likewise.
1018         (ada_resolve_function): Likewise.
1019
1020 2019-04-04  Tom Tromey  <tom@tromey.com>
1021
1022         * parser-defs.h (struct parser_state) <start_arglist,
1023         end_arglist>: New methods.
1024         <arglist_len, m_funcall_chain>: New members.
1025         (arglist_len, start_arglist, end_arglist): Don't declare.
1026         * parse.c (arglist_len, funcall_chain): Remove global.
1027         (start_arglist, end_arglist): Remove functions.
1028         (parse_exp_in_context): Update.
1029         * p-exp.y: Update rules.
1030         * m2-exp.y: Update rules.
1031         * go-exp.y: Update rules.
1032         * f-exp.y: Update rules.
1033         * d-exp.y: Update rules.
1034         * c-exp.y: Update rules.
1035
1036 2019-04-04  Tom Tromey  <tom@tromey.com>
1037
1038         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1039         lex_operator, push_back>: New methods.
1040         Update all rules.
1041         (rust_parser::lex_hex, lex_escape): Rename and update.
1042         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1043         (rust_parser::lex_operator): Rename and update.
1044         (rust_parser::lex_number, rustyylex, rustyyerror)
1045         (rust_lex_test_init, rust_lex_test_sequence)
1046         (rust_lex_test_push_back, rust_lex_tests): Update.
1047         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1048         parameter.
1049         <lexptr, prev_lexptr>: New members.
1050         (lexptr, prev_lexptr): Don't declare.
1051         * parse.c (lexptr, prev_lexptr): Remove globals.
1052         (parse_exp_in_context): Update.
1053         * p-exp.y (yylex, yyerror): Update.
1054         * m2-exp.y (parse_number, yylex, yyerror): Update.
1055         * go-exp.y (lex_one_token, yyerror): Update.
1056         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1057         * d-exp.y (lex_one_token, yyerror): Update.
1058         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1059         (lex_one_token, yyerror): Update.
1060         * ada-lex.l (YY_INPUT): Update.
1061         (rewind_to_char): Update.
1062         * ada-exp.y (yyerror): Update.
1063
1064 2019-04-04  Tom Tromey  <tom@tromey.com>
1065
1066         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1067         * parser-defs.h (struct parser_state) <parser_state>: Add new
1068         parameter.
1069         <comma_terminates>: New member.
1070         (comma_terminates): Don't declare global.
1071         * parse.c (comma_terminates): Remove global.
1072         (parse_exp_in_context): Update.
1073         * p-exp.y (yylex): Update.
1074         * m2-exp.y (yylex): Update.
1075         * go-exp.y (lex_one_token): Update.
1076         * f-exp.y (yylex): Update.
1077         * d-exp.y (lex_one_token): Update.
1078         * c-exp.y (lex_one_token): Update.
1079         * ada-lex.l: Update.
1080
1081 2019-04-04  Tom Tromey  <tom@tromey.com>
1082
1083         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1084         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1085         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1086         * parser-defs.h (paren_depth): Don't declare.
1087         * parse.c (paren_depth): Remove global.
1088         (parse_exp_in_context): Update.
1089         * p-exp.y (paren_depth): New global.
1090         (pascal_parse): Initialize it.
1091         * m2-exp.y (paren_depth): New global.
1092         (m2_parse): Initialize it.
1093         * go-exp.y (paren_depth): New global.
1094         (go_parse): Initialize it.
1095         * f-exp.y (paren_depth): New global.
1096         (f_parse): Initialize it.
1097         * d-exp.y (paren_depth): New global.
1098         (d_parse): Initialize it.
1099         * c-exp.y (paren_depth): New global.
1100         (c_parse): Initialize it.
1101         * ada-lex.l (paren_depth): New global.
1102         (lexer_init): Initialize it.
1103
1104 2019-04-04  Tom Tromey  <tom@tromey.com>
1105
1106         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1107         (rust_parser::convert_ast_to_type)
1108         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1109         * parser-defs.h (struct parser_state) <parser_state>: Add
1110         parameters.  Initialize new members.
1111         <expression_context_block, expression_context_pc>: New members.
1112         * parse.c (expression_context_block, expression_context_pc):
1113         Remove globals.
1114         (parse_exp_in_context): Update.
1115         * p-exp.y: Update all rules.
1116         (yylex): Update.
1117         * m2-exp.y: Update all rules.
1118         (yylex): Update.
1119         * go-exp.y (yylex): Update.
1120         * f-exp.y (yylex): Update.
1121         * d-exp.y: Update all rules.
1122         (yylex): Update.
1123         * c-exp.y: Update all rules.
1124         (lex_one_token, classify_name, yylex, c_parse): Update.
1125         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1126
1127 2019-04-04  Tom Tromey  <tom@tromey.com>
1128
1129         * gdbarch.h, gdbarch.c: Rebuild.
1130         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1131         * stap-probe.h: 
1132         (struct stap_parse_info): Replace "parser_state" with
1133         "expr_builder".
1134         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1135         (parser_state): New class.
1136         * parse.c (expr_builder): Rename.
1137         (expr_builder::release): Rename.
1138         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1139         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1140         (write_exp_elt_longcst, write_exp_elt_floatcst)
1141         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1142         (write_exp_string_vector, write_exp_bitstring)
1143         (write_exp_msymbol, mark_struct_expression)
1144         (write_dollar_variable)
1145         (insert_type_address_space, increase_expout_size): Replace
1146         "parser_state" with "expr_builder".
1147         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1148         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1149         "parser_state" with "expr_builder".
1150
1151 2019-04-04  Tom Tromey  <tom@tromey.com>
1152
1153         * rust-exp.y: Replace "parse_language" with method call.
1154         * p-exp.y: 
1155         (yylex): Replace "parse_language" with method call.
1156         * m2-exp.y: 
1157         (yylex): Replace "parse_language" with method call.
1158         * go-exp.y (classify_name): Replace "parse_language" with method
1159         call.
1160         * f-exp.y (yylex): Replace "parse_language" with method call.
1161         * d-exp.y (lex_one_token): Replace "parse_language" with method
1162         call.
1163         * c-exp.y: 
1164         (lex_one_token, classify_name, yylex): Replace "parse_language"
1165         with method call.
1166         * ada-exp.y (find_primitive_type, type_char)
1167         (type_system_address): Replace "parse_language" with method call.
1168
1169 2019-04-04  Tom Tromey  <tom@tromey.com>
1170
1171         * rust-exp.y: Replace "parse_gdbarch" with method call.
1172         * parse.c (write_dollar_variable, insert_type_address_space):
1173         Replace "parse_gdbarch" with method call.
1174         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1175         call.
1176         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1177         call.
1178         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1179         "parse_gdbarch" with method call.
1180         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1181         with method call.
1182         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1183         "parse_gdbarch" with method call.
1184         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1185         "parse_gdbarch" with method call.
1186         * c-exp.y (parse_type, parse_number, classify_name): Replace
1187         "parse_gdbarch" with method call.
1188         * ada-lex.l: Replace "parse_gdbarch" with method call.
1189         * ada-exp.y (parse_type, find_primitive_type, type_char)
1190         (type_system_address): Replace "parse_gdbarch" with method call.
1191
1192 2019-04-04  Tom Tromey  <tom@tromey.com>
1193
1194         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1195         * stap-probe.c (stap_parse_argument): Update.
1196         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1197         initial_size parameter.
1198         * rust-exp.y (rust_lex_tests): Update.
1199         * parse.c (parser_state): Update.
1200         (parse_exp_in_context): Update.
1201         * parser-defs.h (struct parser_state) <parser_state>: Remove
1202         "initial_size" parameter.
1203
1204 2019-04-04  Tom Tromey  <tom@tromey.com>
1205
1206         * parser-defs.h (increase_expout_size): Don't declare.
1207         * parse.c (increase_expout_size): Now static.
1208
1209 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1210
1211         * gnu-nat.c (gnu_nat_target::wait): Fix
1212         target_waitstatus_to_string call.
1213
1214 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1215
1216         * eval.c (evaluate_subexp_standard): Handle internal functions
1217         during Fortran function call handling.
1218
1219 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1220
1221         * NEWS: Mention new internal functions.
1222         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1223         (read_base_type): Use dwarf2_init_complex_target_type.
1224         * value.c (creal_internal_fn): New function.
1225         (cimag_internal_fn): New function.
1226         (_initialize_values): Register new internal functions.
1227
1228 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1229
1230         * infrun.c (stop_all_threads): If debug_infrun, always
1231         trace the wait status after wait_one, using
1232         target_waitstatus_to_string and target_pid_to_str.
1233         (handle_inferior_event): Replace various trace of
1234         wait status kind by a single trace.
1235         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1236         wait status kind image by target_waitstatus_to_string.
1237         * target/waitstatus.c (target_waitstatus_to_string): Fix
1238         obsolete comment.
1239
1240 2019-04-01  Tom Tromey  <tromey@adacore.com>
1241
1242         PR symtab/23331:
1243         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1244
1245 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1246             Pedro Alves  <palves@redhat.com>
1247
1248         * top.c (quit_force): Call 'finalize_values'.
1249         * value.c (finalize_values): New function.
1250         * value.h (finalize_values): Declare.
1251
1252 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1253
1254         * NEWS: Announce $_gdb_major and $_gdb_minor.
1255
1256         * top.c (init_gdb_version_vars): New function.
1257         (gdb_init): Call init_gdb_version_vars.
1258
1259 2019-03-29  Tom Tromey  <tromey@adacore.com>
1260
1261         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1262         help text.  Remove dead code.
1263
1264 2019-03-29  Keith Seitz  <keiths@redhat.com>
1265
1266         From Siddhesh Poyarekar:
1267         * f-lang.h (f77_get_upperbound): Return LONGEST.
1268         (f77_get_lowerbound): Likewise.
1269         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1270         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1271         print them.
1272         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1273         plongest to format print it.
1274         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1275         (f77_get_upperbound): Likewise.
1276         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1277         LOWER_BOUND to LONGEST.
1278         (f77_create_arrayprint_offset_tbl): Likewise.
1279
1280 2019-03-29  Keith Seitz  <keiths@redhat.com>
1281
1282         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1283         %s/pulongest for TYPE_LENGTH instead of %d in format
1284         strings.
1285         * ada-typerint.c (ada_print_type): Likewise.
1286         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1287         * compile/compile-c-support.c (generate_register_struct): Likewise.
1288         * gdbtypes.c (recursive_dump_type): Likewise.
1289         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1290         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1291         instead of %d in format strings.
1292         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1293         to std::min to ULONGEST.
1294         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1295         instead of %d in format strings.
1296         * tracepoint.c (info_scope_command): Likewise.
1297         * typeprint.c (print_offset_data::update)
1298         (print_offset_data::finish): Likewise.
1299         * xtensa-tdep.c (xtensa_store_return_value)
1300         (xtensa_push_dummy_call): Likewise.
1301
1302 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1303
1304         * windows-nat.c (display_selector): Fixed format specifications
1305         for 64-bit Cygwin.
1306
1307 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1308
1309         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1310
1311 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1312
1313         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1314         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1315         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1316         (nios2_linux_init_abi): Install it.
1317
1318 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1319
1320         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1321
1322 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1323
1324         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1325
1326 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1327             Tom Tromey  <tromey@adacore.com>
1328
1329         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1330
1331 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1332
1333         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1334         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1335         method to compute the bounds of range types. Also print "[evaluated]"
1336         if the bounds' values come from a dynamic evaluation.
1337
1338 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1341         whitespace when pretty printing is on.
1342
1343 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1344
1345         * ppc-linux-nat.c: Add include.
1346
1347 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1348
1349         * NEWS: Mention AArch64 Pointer Authentication.
1350
1351 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1352
1353         * arm-linux-nat.c: Add include.
1354
1355 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1356
1357         * source-cache.c (source_cache::get_source_lines): Re-read
1358         fullname after calling open_source_file.
1359
1360 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1361
1362         * NEWS: Mention TLS support for FreeBSD.
1363
1364 2019-03-25  Tom Tromey  <tromey@adacore.com>
1365
1366         * minsyms.c (BUNCH_SIZE): Update comment.
1367         (~minimal_symbol_reader): Remove old comment.
1368         (compact_minimal_symbols): Update comment.
1369         (minimal_symbol_reader::install): Remove old comment.  Update
1370         other comments.
1371
1372 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1373
1374         * s390-linux-nat.c: Add include.
1375
1376 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1377
1378         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1379         Call linux_get_hwcap.
1380         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1381         Likewise.
1382         (aarch64_linux_get_hwcap): Remove function.
1383         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1384         declaration.
1385         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1386         linux_get_hwcap.
1387         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1388         * linux-tdep.c (linux_get_hwcap): Add function.
1389         (linux_get_hwcap2): Likewise.
1390         * linux-tdep.h (linux_get_hwcap): Add declaration.
1391         (linux_get_hwcap2): Likewise.
1392         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1393         (ppc_linux_get_hwcap2): Likewise.
1394         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1395         linux_get_hwcap.
1396         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1397         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1398         (ppc_linux_nat_target::read_description): Likewise.
1399         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1400         * s390-linux-nat.c: Likewise.
1401         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1402
1403 2019-03-24  Tom Tromey  <tom@tromey.com>
1404
1405         * ada-lang.c (standard_lookup): Simplify initialization.
1406         (ada_lookup_symbol_nonlocal): Simplify return.
1407         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1408         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1409         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1410         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1411         initialization.
1412         * solib.c (solib_global_lookup): Simplify.
1413         * symtab.c (null_block_symbol): Remove.
1414         (symbol_cache_lookup): Simplify returns.
1415         (lookup_language_this): Simplify returns.
1416         (lookup_symbol_aux): Simplify return.
1417         (lookup_local_symbol): Simplify returns.
1418         (lookup_global_symbol_from_objfile): Simplify return.
1419         (lookup_symbol_in_objfile_symtabs)
1420         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1421         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1422         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1423         * cp-namespace.c (cp_lookup_bare_symbol)
1424         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1425         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1426         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1427         (cp_lookup_symbol_via_imports): Simplify initialization.
1428         (find_symbol_in_baseclass): Likewise.
1429         * symtab.h (null_block_symbol): Remove.
1430         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1431         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1432         (d_lookup_symbol_module): Likewise.
1433         (find_symbol_in_baseclass): Simplify initialization.
1434
1435 2019-03-24  Tom Tromey  <tom@tromey.com>
1436
1437         * expression.h: Don't include symtab.h.
1438         (struct block): Forward declare.
1439
1440 2019-03-24  Tom Tromey  <tom@tromey.com>
1441
1442         * c-exp.y (typebase): Remove casts.
1443         * gdbtypes.c (lookup_unsigned_typename, )
1444         (lookup_signed_typename): Remove cast.
1445         * eval.c (parse_to_comma_and_eval): Remove cast.
1446         * parse.c (write_dollar_variable): Remove cast.
1447         * block.h (struct block) <superblock>: Now const.
1448         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1449         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1450         (map_block): Make "block" const.
1451         * symfile.h (struct quick_symbol_functions)
1452         <map_matching_symbols>: Constify block argument to "callback".
1453         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1454         const.
1455         (find_pc_sect_compunit_symtab): Make "b" const.
1456         (find_symbol_at_address): Likewise.
1457         (search_symbols): Likewise.
1458         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1459         (dw2_debug_names_lookup_symbol): Likewise.
1460         (dw2_map_matching_symbols): Update.
1461         * p-valprint.c (pascal_val_print): Remove "block".
1462         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1463         (aux_add_nonlocal_symbols): Make "block" const.
1464         (resolve_subexp): Remove cast.
1465         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1466         const.
1467         (iterate_over_file_blocks): Likewise.
1468         * f-exp.y (%union) <bval>: Remove.
1469         * coffread.c (patch_opaque_types): Make "b" const.
1470         * spu-tdep.c (spu_catch_start): Make "block" const.
1471         * c-valprint.c (print_unpacked_pointer): Remove "block".
1472         * symmisc.c (dump_symtab_1): Make "b" const.
1473         (block_depth): Make "block" const.
1474         * d-exp.y (%union) <bval>: Remove.
1475         * cp-support.h (cp_lookup_rtti_type): Update.
1476         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1477         * psymtab.c (psym_lookup_symbol): Make "block" const.
1478         (maintenance_check_psymtabs): Make "b" const.
1479         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1480         (enumerate_locals, enumerate_args): Update.
1481         * python/py-symtab.c (stpy_global_block): Make "block" const.
1482         (stpy_static_block): Likewise.
1483         * inline-frame.c (block_starting_point_at): Make "new_block"
1484         const.
1485         * block.c (find_block_in_blockvector): Make return type const.
1486         (blockvector_for_pc_sect): Make "b" const.
1487         (find_block_in_blockvector): Make "b" const.
1488
1489 2019-03-23  Tom Tromey  <tom@tromey.com>
1490
1491         * varobj.c (varobj_create): Update.
1492         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1493         * printcmd.c (display_command, do_one_display): Don't reset
1494         innermost_block.
1495         * parser-defs.h (enum innermost_block_tracker_type): Move to
1496         expression.h.
1497         (innermost_block): Update comment.
1498         * parse.c (parse_exp_1): Add tracker_types parameter.
1499         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1500         tracker_types parameter.  Reset innermost_block.
1501         (parse_exp_in_context): Remove.
1502         (parse_expression_for_completion): Update.
1503         * objfiles.c (~objfile): Don't reset expression_context_block or
1504         innermost_block.
1505         * expression.h (enum innermost_block_tracker_type): Move from
1506         parser-defs.h.
1507         (parse_exp_1): Add tracker_types parameter.
1508         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1509         reset innermost_block.
1510
1511 2019-03-23  Tom Tromey  <tom@tromey.com>
1512
1513         * objfiles.h: Include bcache.h.
1514
1515 2019-03-23  Tom Tromey  <tom@tromey.com>
1516
1517         * linespec.c (get_current_search_block): Use
1518         scoped_restore_current_language.
1519         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1520
1521 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1522             Jiong Wang  <jiong.wang@arm.com>
1523
1524         * aarch64-linux-tdep.c
1525         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1526         section.
1527         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1528
1529 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1530             Jiong Wang  <jiong.wang@arm.com>
1531
1532         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1533         instructions.
1534         (aarch64_analyze_prologue_test): Add PACIASP test.
1535         (aarch64_prologue_prev_register): Unmask PC value.
1536
1537 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1538             Jiong Wang  <jiong.wang@arm.com>
1539
1540         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1541         (aarch64_dwarf2_prev_register): Unmask PC value.
1542         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1543         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1544         DW_CFA_AARCH64_negate_ra_state.
1545         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1546
1547 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1548             Jiong Wang  <jiong.wang@arm.com>
1549
1550         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1551         registers.
1552         (aarch64_pseudo_register_name): Likewise.
1553         (aarch64_pseudo_register_type): Likewise.
1554         (aarch64_pseudo_register_reggroup_p): Likewise.
1555         (aarch64_gdbarch_init): Add pauth registers.
1556         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1557         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1558         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1559         (struct gdbarch_tdep): Add regnum for ra_state.
1560
1561 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1562             Jiong Wang  <jiong.wang@arm.com>
1563
1564         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1565
1566 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1567             Jiong Wang  <jiong.wang@arm.com>
1568
1569         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1570         function.
1571         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1572         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1573         (aarch64_gdbarch_init): Add puth registers.
1574         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1575         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1576         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1577
1578 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1579             Jiong Wang  <jiong.wang@arm.com>
1580
1581         * aarch64-linux-nat.c
1582         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1583         * aarch64-linux-tdep.c
1584         (aarch64_linux_core_read_description): Likewise.
1585         (aarch64_linux_get_hwcap): New function.
1586         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1587         (aarch64_linux_get_hwcap): New declaration.
1588
1589 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1590             Jiong Wang  <jiong.wang@arm.com>
1591
1592         * aarch64-linux-nat.c
1593         (aarch64_linux_nat_target::read_description): Add pauth param.
1594         * aarch64-linux-tdep.c
1595         (aarch64_linux_core_read_description): Likewise.
1596         * aarch64-tdep.c (struct target_desc): Add in pauth.
1597         (aarch64_read_description): Add pauth param.
1598         (aarch64_gdbarch_init): Likewise.
1599         * aarch64-tdep.h (aarch64_read_description): Likewise.
1600         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1601         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1602         * features/Makefile: Add new files.
1603         * features/aarch64-pauth.c: New file.
1604         * features/aarch64-pauth.xml: New file.
1605
1606 2019-03-20  Tom Tromey  <tromey@adacore.com>
1607
1608         * infrun.c (handle_inferior_event): Rename from
1609         handle_inferior_event_1.  Create a scoped_value_mark.
1610         (handle_inferior_event): Remove.
1611
1612 2019-03-19  Tom Tromey  <tromey@adacore.com>
1613
1614         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1615         * infrun.h (print_stop_event): Add "displays" parameter.
1616         * infrun.c (print_stop_event): Add "displays" parameter.
1617
1618 2019-03-19  Pedro Alves  <palves@redhat.com>
1619
1620         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1621         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1622         to -1.  Fix TABs vs spaces.
1623         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1624         * tui/tui-out.h (tui_ui_out) Add intro comments.
1625         <m_line, m_start_of_line>: In-class initialize, and add describing
1626         comment.
1627
1628 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1629
1630         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1631         variable names.
1632         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1633
1634 2019-03-18  Pedro Alves  <palves@redhat.com>
1635             Eli Zaretskii <eliz@gnu.org>
1636
1637         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1638         m_line and m_start_of_line.
1639
1640 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1641
1642         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1643         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1644         it returns a newline.  This fixes a regression in TU mode, whereby
1645         the next line is output on the same screen line as the user input.
1646
1647 2019-03-18  Tom Tromey  <tromey@adacore.com>
1648
1649         * minsyms.c (minimal_symbol_reader::install): Remove call to
1650         obstack_blank.
1651
1652 2019-03-18  Pedro Alves  <palves@redhat.com>
1653
1654         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1655         New globals.
1656         (apply_style): New, factored out from ...
1657         (apply_ansi_escape): ... this.  Handle reverse video mode.
1658         (tui_set_reverse_mode): New function.
1659         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1660         * tui/tui-winsource.c (tui_show_source_line): Use
1661         tui_set_reverse_mode instead of setting A_STANDOUT.
1662         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1663         New setter methods.
1664
1665 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1666
1667         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1668         Handle tabs.
1669
1670 2019-03-18  Tom Tromey  <tromey@adacore.com>
1671
1672         * ada-lang.c (empty_array): Add "high" parameter.
1673         (ada_evaluate_subexp): Update.
1674
1675 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1676
1677         * unittests/string_view-selftests.c: Define
1678         _initialize_string_view_selftests unconditionally.
1679
1680 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1681
1682         PR gdb/24350
1683         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1684
1685 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1686
1687         PR gdb/24351
1688         * windows-nat.c (display_selector): Fix format specifiers.
1689
1690 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1691
1692         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1693         tui_refill_source_window instead of tui_refresh_win, to update the
1694         current execution line.  This fixes redisplay of the current line
1695         when stepping through the code with "next" or "step".
1696
1697 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1698
1699         * source-cache.c (source_cache::get_source_lines): Call
1700         find_source_lines to initialize s->nlines.  This fixes vertical
1701         scrolling of TUI source window when the DOWN arrow is pressed.
1702
1703 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1704
1705         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1706         linux-thread-db.c (_initialize_thread_db): Likewise.
1707
1708 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1709
1710         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1711         wclrtoeol in tui_show_source_line".  This reverts changes made in
1712         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1713
1714 2019-03-15  Tom Tromey  <tom@tromey.com>
1715
1716         * symtab.h (struct minimal_symbol): Derive from
1717         general_symbol_info.
1718         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1719         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1720         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1721         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1722         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1723         (MSYMBOL_SEARCH_NAME): Update.
1724         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1725         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1726         * minsyms.c (minimal_symbol_reader::record_full): Update.
1727
1728 2019-03-15  Tom Tromey  <tom@tromey.com>
1729
1730         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1731
1732 2019-03-15  Tom Tromey  <tom@tromey.com>
1733
1734         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1735         unique_xmalloc_ptr.
1736         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1737         Update.
1738         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1739         (build_minimal_symbol_hash_tables)
1740         (minimal_symbol_reader::install): Update.
1741
1742 2019-03-15  Tom Tromey  <tom@tromey.com>
1743
1744         * symtab.c (create_demangled_names_hash): Update.
1745         (symbol_set_names): Update.
1746         * objfiles.h (struct objfile_per_bfd_storage)
1747         <demangled_names_hash>: Now an htab_up.
1748         * objfiles.c (objfile_per_bfd_storage): Simplify.
1749
1750 2019-03-15  Tom Tromey  <tom@tromey.com>
1751
1752         * objfiles.h (struct objfile_per_bfd_storage): Declare
1753         destructor.
1754         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1755         New.
1756         (get_objfile_bfd_data): Use new.  Don't initialize
1757         language_of_main.
1758         (free_objfile_per_bfd_storage): Remove.
1759         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1760
1761 2019-03-15  Tom Tromey  <tom@tromey.com>
1762
1763         * symfile.c (reread_symbols): Update.
1764         * objfiles.c (objfile::objfile): Update.
1765         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1766         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1767         comment.
1768         (minimal_symbol_reader::install): Update.
1769         (terminate_minimal_symbol_table): Remove.
1770         * jit.c (jit_object_close_impl): Update.
1771
1772 2019-03-15  Tom Tromey  <tom@tromey.com>
1773
1774         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1775         initializations.
1776
1777 2019-03-15  Tom Tromey  <tom@tromey.com>
1778
1779         * objfiles.h (struct objfile_per_bfd_storage)
1780         <demangled_hash_languages>: Now a bitset.
1781         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1782         (lookup_minimal_symbol): Update.
1783
1784 2019-03-15  Tom Tromey  <tom@tromey.com>
1785
1786         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1787         Don't return the symbol.
1788         * coffread.c (record_minimal_symbol): Use record_full.
1789
1790 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1791
1792         The MS-Windows port of ncurses fails to switch to a color pair if
1793         one or both of the colors are the implicit default colors.  This
1794         change records the default colors when TUI is initialized, and
1795         then specifies them explicitly when a color pair uses the default
1796         colors.  This allows color styling in TUI mode on MS-Windows.
1797
1798         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1799         ncurses_norm_attr.
1800         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1801         colors in ncurses_norm_attr.
1802         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1803         "none", replace it with the default color recorded in
1804         ncurses_norm_attr.
1805
1806 2019-03-14  Tom Tromey  <tromey@adacore.com>
1807
1808         * source-cache.h (class source_cache) <get_source_lines>: Return
1809         std::string.
1810         * source-cache.c (source_cache::extract_lines): Handle case where
1811         first_pos==npos.  Return std::string.
1812         (source_cache::get_source_lines): Update.
1813
1814 2019-03-14  Tom Tromey  <tromey@adacore.com>
1815
1816         * NEWS: Add item for "style sources" commands.
1817         * source-cache.c (source_cache::get_source_lines): Check
1818         source_styling.
1819         * cli/cli-style.c (source_styling): New global.
1820         (_initialize_cli_style): Add "style sources" commands.
1821         (show_style_sources): New function.
1822         * cli/cli-style.h (source_styling): Declare.
1823
1824 2019-03-14  Pedro Alves  <palves@redhat.com>
1825             Tom Tromey  <tromey@adacore.com>
1826
1827         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1828         * tui/tui-winsource.c (tui_refill_source_window): New function,
1829         from...
1830         (tui_horizontal_source_scroll): ... here.  Move some logic.
1831         * cli/cli-style.c (set_style_enabled): Notify new observable.
1832         * tui/tui-hooks.c (tui_redisplay_source): New function.
1833         (tui_attach_detach_observers): Attach or detach
1834         tui_redisplay_source.
1835         * observable.h (source_styling_changed): New observable.
1836         * observable.c: Define source_styling_changed observable.
1837
1838 2019-03-13  Tom Tromey  <tromey@adacore.com>
1839
1840         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1841         (i386_gnu_nat_target::store_registers): Update.
1842         * target-debug.h (target_debug_print_std_string): New macro.
1843         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1844         * windows-tdep.c (display_one_tib): Update.
1845         * tui/tui-stack.c (tui_make_status_line): Update.
1846         * top.c (print_inferior_quit_action): Update.
1847         * thread.c (thr_try_catch_cmd): Update.
1848         (add_thread_with_info): Update.
1849         (thread_target_id_str): Update.
1850         (thr_try_catch_cmd): Update.
1851         (thread_command): Update.
1852         (thread_find_command): Update.
1853         * record-btrace.c (record_btrace_target::info_record)
1854         (record_btrace_resume_thread, record_btrace_target::resume)
1855         (record_btrace_cancel_resume, record_btrace_step_thread)
1856         (record_btrace_target::wait, record_btrace_target::wait)
1857         (record_btrace_target::wait, record_btrace_target::stop): Update.
1858         * progspace.c (print_program_space): Update.
1859         * process-stratum-target.c
1860         (process_stratum_target::thread_address_space): Update.
1861         * linux-fork.c (linux_fork_mourn_inferior)
1862         (detach_checkpoint_command, info_checkpoints_command)
1863         (linux_fork_context): Update.
1864         (linux_fork_detach): Update.
1865         (class scoped_switch_fork_info): Update.
1866         (delete_checkpoint_command): Update.
1867         * infrun.c (follow_fork_inferior): Update.
1868         (follow_fork_inferior): Update.
1869         (proceed_after_vfork_done): Update.
1870         (handle_vfork_child_exec_or_exit): Update.
1871         (follow_exec): Update.
1872         (displaced_step_prepare_throw): Update.
1873         (displaced_step_restore): Update.
1874         (start_step_over): Update.
1875         (resume_1): Update.
1876         (clear_proceed_status_thread): Update.
1877         (proceed): Update.
1878         (print_target_wait_results): Update.
1879         (do_target_wait): Update.
1880         (context_switch): Update.
1881         (stop_all_threads): Update.
1882         (restart_threads): Update.
1883         (finish_step_over): Update.
1884         (handle_signal_stop): Update.
1885         (switch_back_to_stepped_thread): Update.
1886         (keep_going_pass_signal): Update.
1887         (print_exited_reason): Update.
1888         (normal_stop): Update.
1889         * inferior.c (inferior_pid_to_str): Change return type.
1890         (print_selected_inferior): Update.
1891         (add_inferior): Update.
1892         (detach_inferior): Update.
1893         * dummy-frame.c (fprint_dummy_frames): Update.
1894         * dcache.c (dcache_info_1): Update.
1895         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1896         (btrace_fetch, btrace_clear): Update.
1897         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1898         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1899         type.
1900         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1901         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1902         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1903         * gdbarch.c, gdbarch.h: Rebuild.
1904         * gdbarch.sh (core_pid_to_str): Change return type.
1905         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1906         return type.
1907         (windows_nat_target::pid_to_str): Change return type.
1908         (windows_delete_thread): Update.
1909         (windows_nat_target::attach): Update.
1910         (windows_nat_target::files_info): Update.
1911         * target-delegates.c: Rebuild.
1912         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1913         return type.
1914         (sol_thread_target::pid_to_str): Change return type.
1915         * remote.c (class remote_target) <pid_to_str>: Change return
1916         type.
1917         (remote_target::pid_to_str): Change return type.
1918         (extended_remote_target::attach, remote_target::remote_stop_ns)
1919         (remote_target::remote_notif_remove_queued_reply)
1920         (remote_target::push_stop_reply, remote_target::disable_btrace):
1921         Update.
1922         (extended_remote_target::attach): Update.
1923         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1924         type.
1925         (gdbsim_target::pid_to_str): Change return type.
1926         * ravenscar-thread.c (struct ravenscar_thread_target)
1927         <pid_to_str>: Change return type.
1928         (ravenscar_thread_target::pid_to_str): Change return type.
1929         * procfs.c (class procfs_target) <pid_to_str>: Change return
1930         type.
1931         (procfs_target::pid_to_str): Change return type.
1932         (procfs_target::attach): Update.
1933         (procfs_target::detach): Update.
1934         (procfs_target::fetch_registers): Update.
1935         (procfs_target::store_registers): Update.
1936         (procfs_target::wait): Update.
1937         (procfs_target::files_info): Update.
1938         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1939         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1940         return type.
1941         (nto_procfs_target::pid_to_str): Change return type.
1942         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1943         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1944         return type.
1945         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1946         (exit_lwp): Update.
1947         (attach_proc_task_lwp_callback, get_detach_signal)
1948         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1949         (linux_nat_target::resume, wait_lwp, stop_callback)
1950         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1951         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1952         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1953         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1954         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1955         type.
1956         (inf_ptrace_target::attach): Update.
1957         (inf_ptrace_target::files_info): Update.
1958         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1959         type.
1960         (go32_nat_target::pid_to_str): Change return type.
1961         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1962         (gnu_nat_target::wait): Update.
1963         (gnu_nat_target::wait): Update.
1964         (gnu_nat_target::resume): Update.
1965         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1966         (fbsd_nat_target::wait): Update.
1967         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1968         type.
1969         (darwin_nat_target::attach): Update.
1970         * corelow.c (class core_target) <pid_to_str>: Change return type.
1971         (core_target::pid_to_str): Change return type.
1972         * target.c (normal_pid_to_str): Change return type.
1973         (default_pid_to_str): Likewise.
1974         (target_pid_to_str): Change return type.
1975         (target_translate_tls_address): Update.
1976         (target_announce_detach): Update.
1977         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1978         return type.
1979         (bsd_uthread_target::pid_to_str): Change return type.
1980         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1981         type.
1982         (bsd_kvm_target::pid_to_str): Change return type.
1983         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1984         return type.
1985         (aix_thread_target::pid_to_str): Change return type.
1986         * target.h (struct target_ops) <pid_to_str>: Change return type.
1987         (target_pid_to_str, normal_pid_to_str): Likewise.
1988         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1989         type.
1990         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1991         type.
1992         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1993         return type.
1994         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1995         type.
1996         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1997         type.
1998         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1999         return type.
2000
2001 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2002
2003         * NEWS: Mention that the new default MI version is 3.  Mention
2004         changes to the output of commands and events that deal with
2005         multi-location breakpoints.
2006         * breakpoint.c: Include "mi/mi-out.h".
2007         (print_one_breakpoint): Change output syntax if using MI version
2008         >= 3.
2009         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2010         New.
2011         (mi_multi_location_breakpoint_output_fixed): New.
2012         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2013         (mi_cmd_fix_multi_location_breakpoint_output): New.
2014         (mi_multi_location_breakpoint_output_fixed): New.
2015         * mi/mi-cmds.c (mi_cmds): Register command
2016         -fix-multi-location-breakpoint-output.
2017         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2018         interpreter "mi".
2019
2020 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2021
2022         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2023         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2024         instantiate mi_ui_out based on interpreter name.
2025         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2026         * mi/mi-main.c (mi_load_progress): Likewise.
2027
2028 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2029
2030         * NEWS: Combine separate "New targets" sections for 8.3.
2031
2032 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2033
2034         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2035         (ppcfbsd_init_abi): Install gdbarch
2036         "fetch_tls_load_module_address" and "get_thread_local_address"
2037         methods.
2038
2039 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2040
2041         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2042         (riscv_fbsd_init_abi): Install gdbarch
2043         "fetch_tls_load_module_address" and "get_thread_local_address"
2044         methods.
2045
2046 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2047
2048         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2049         (i386fbsd_init_abi): Install gdbarch
2050         "fetch_tls_load_module_address" and "get_thread_local_address"
2051         methods.
2052
2053 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2054
2055         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2056         (amd64fbsd_init_abi): Install gdbarch
2057         "fetch_tls_load_module_address" and "get_thread_local_address"
2058         methods.
2059
2060 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2061
2062         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2063         (struct fbsd_pspace_data): New type.
2064         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2065         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2066         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2067         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2068         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2069
2070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2071
2072         * gdbtypes.c (lookup_struct_elt): New function.
2073         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2074         * gdbtypes.h (struct struct_elt): New type.
2075         (lookup_struct_elt): New prototype.
2076
2077 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2078
2079         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2080         remove disabled code block.
2081
2082 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2083
2084         * gdbarch.sh (get_thread_local_address): New method.
2085         * gdbarch.h, gdbarch.c: Regenerate.
2086         * target.c (target_translate_tls_address): Use
2087         gdbarch_get_thread_local_address if present instead of
2088         target::get_thread_local_address.
2089
2090 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2091
2092         * target.h (target::get_thread_local_address): Update comment.
2093
2094 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2095
2096         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2097         objfile->separate_debug_objfile_backlink if not NULL.
2098
2099 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2100
2101         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2102         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2103         (amd64bsd_store_inferior_registers): Likewise.
2104         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2105         Enable segment base registers.
2106         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2107         PT_GETFSBASE and PT_GETGSBASE.
2108         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2109         PT_SETGSBASE.
2110         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2111         segment base registers.
2112         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2113
2114 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2115
2116         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2117         Update calls to i386_target_description to add 'segments'
2118         parameter.
2119         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2120         add segment base registers.
2121         * arch/i386.c (i386_create_target_description): Add 'segments'
2122         parameter to enable segment base registers.
2123         * arch/i386.h (i386_create_target_description): Likewise.
2124         * features/i386/32bit-segments.xml: New file.
2125         * features/i386/32bit-segments.c: Generate.
2126         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2127         call to i386_target_description to add 'segments' parameter.
2128         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2129         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2130         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2131         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2132         if feature is present.
2133         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2134         Add 'segments' parameter to call to i386_target_description.
2135         (i386_target_description): Add 'segments' parameter to enable
2136         segment base registers.
2137         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2138         to call to i386_target_description.
2139         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2140         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2141         Define I386_NUM_REGS.
2142         (i386_target_description): Add 'segments' parameter to enable
2143         segment base registers.
2144
2145 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2146
2147         PR/24325
2148         * source-cache.c: #undef open and close, to avoid unresolved
2149         externals during linking.
2150
2151 2019-03-12  Tom Tromey  <tromey@adacore.com>
2152
2153         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2154         const.  Add initializers.
2155         (_initialize_remote): Don't initialize ptid globals.
2156
2157 2019-03-12  Pedro Alves  <palves@redhat.com>
2158
2159         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2160
2161 2019-03-12  Pedro Alves  <palves@redhat.com>
2162
2163         * cp-name-parser.y (main): Remove unused 'len' variable.
2164
2165 2019-03-12  Tom Tromey  <tromey@adacore.com>
2166
2167         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2168         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2169
2170 2019-03-12  Tom Tromey  <tromey@adacore.com>
2171
2172         * linux-nat.c (iterate_over_lwps): Update.
2173         (stop_callback): Remove parameter.
2174         (stop_wait_callback, detach_callback, resume_set_callback)
2175         (select_singlestep_lwp_callback, set_ignore_sigint)
2176         (status_callback, resumed_callback, resume_clear_callback)
2177         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2178         data parameter.
2179         (linux_nat_target::detach, linux_nat_target::resume)
2180         (linux_stop_and_wait_all_lwps, select_event_lwp)
2181         (linux_nat_filter_event, linux_nat_wait_1)
2182         (linux_nat_target::kill, linux_nat_target::stop)
2183         (linux_nat_target::stop): Update.
2184         (linux_nat_resume_callback): Change type.
2185         (resume_stopped_resumed_lwps, count_events_callback)
2186         (select_event_lwp_callback): Likewise.
2187         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2188         * arm-linux-nat.c (struct update_registers_data): Remove.
2189         (update_registers_callback): Change type.
2190         (arm_linux_insert_hw_breakpoint1): Update.
2191         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2192         parameter.
2193         (x86_linux_dr_set_addr): Update.
2194         (x86_linux_dr_set_control): Update.
2195         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2196         (iterate_over_lwps): Use gdb::function_view.
2197         * nat/aarch64-linux-hw-point.c (struct
2198         aarch64_dr_update_callback_param): Remove.
2199         (debug_reg_change_callback): Change type.
2200         (aarch64_notify_debug_reg_change): Update.
2201         * s390-linux-nat.c (s390_refresh_per_info): Update.
2202
2203 2019-03-11  Tom Tromey  <tromey@adacore.com>
2204
2205         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2206         redundant assignment to "this_cu".
2207
2208 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2209
2210         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2211
2212 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2213
2214         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2215         from...
2216         (rank_one_type): ... this.
2217
2218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2219
2220         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2221         from...
2222         (rank_one_type): ... this.
2223
2224 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2225
2226         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2227         from...
2228         (rank_one_type): ... this.
2229
2230 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2231
2232         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2233         from...
2234         (rank_one_type): ... this.
2235
2236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2237
2238         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2239         from...
2240         (rank_one_type): ... this.
2241
2242 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2243
2244         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2245         from...
2246         (rank_one_type): ... this.
2247
2248 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2249
2250         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2251         from...
2252         (rank_one_type): ... this.
2253
2254 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2255
2256         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2257         from...
2258         (rank_one_type): ... this.
2259
2260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2261
2262         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2263         from...
2264         (rank_one_type): ... this.
2265
2266 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2267
2268         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2269         from...
2270         (rank_one_type): ... this.
2271
2272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2273
2274         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2275         from...
2276         (rank_one_type): ... this.
2277
2278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2279
2280         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2281         from...
2282         (rank_one_type): ... this.
2283
2284 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2285
2286         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2287         inferior-events' shows the example events.
2288
2289 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2290
2291         Support styling on native MS-Windows console
2292
2293         PR/24315
2294         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2295         on MS-Windows if $TERM is not defined.
2296
2297         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2298
2299         * posix-hdep.c (gdb_console_fputs):
2300         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2301         functions.
2302         * ui-file.h (gdb_console_fputs): Add prototype.
2303
2304         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2305         back to fputs only if the former returns zero.
2306
2307 2019-03-07  Tom Tromey  <tom@tromey.com>
2308
2309         * symmisc.c (print_symbol_bcache_statistics): Update.
2310         (print_objfile_statistics): Update.
2311         * symfile.c (allocate_symtab): Update.
2312         * stabsread.c: Don't include bcache.h.
2313         * psymtab.h (struct psymbol_bcache): Don't declare.
2314         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2315         (psymbol_bcache_init, psymbol_bcache_free)
2316         (psymbol_bcache_get_bcache): Don't declare.
2317         * psymtab.c (struct psymbol_bcache): Remove.
2318         (psymtab_storage::psymtab_storage): Update.
2319         (psymtab_storage::~psymtab_storage): Update.
2320         (psymbol_bcache_init, psymbol_bcache_free)
2321         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2322         (add_psymbol_to_bcache): Update.
2323         (allocate_psymtab): Update.
2324         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2325         macro_cache>: No longer pointers.
2326         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2327         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2328         * macrotab.c (macro_bcache): Update.
2329         * macroexp.c: Don't include bcache.h.
2330         * gdbtypes.c (check_types_worklist): Update.
2331         (types_deeply_equal): Remove TRY/CATCH.  Update.
2332         * elfread.c (elf_symtab_read): Update.
2333         * dwarf2read.c: Don't include bcache.h.
2334         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2335         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2336         (print_bcache_statistics, bcache_memory_used): Don't declare.
2337         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2338         methods.  Rename all data members.
2339         * bcache.c (struct bcache): Move to bcache.h.
2340         (bcache::expand_hash_table): Rename from expand_hash_table.
2341         (bcache): Remove.
2342         (bcache::insert): Rename from bcache_full.
2343         (bcache::compare): Rename from bcache_compare.
2344         (bcache_xmalloc): Remove.
2345         (bcache::~bcache): Rename from bcache_xfree.
2346         (bcache::print_statistics): Rename from print_bcache_statistics.
2347         (bcache::memory_used): Rename from bcache_memory_used.
2348
2349 2019-03-07  Pedro Alves  <palves@redhat.com>
2350
2351         * infrun.c (normal_stop): Also check for
2352         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2353
2354 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * f-lang.c (value_from_host_double): Moved to...
2357         * value.c (value_from_host_double): ...here.
2358         * value.h (value_from_host_double): Declare.
2359         * guile/scm-math.c (vlscm_convert_typed_number): Use
2360         value_from_host_double.
2361         (vlscm_convert_number): Likewise.
2362         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2363         * python/py-value.c (convert_value_from_python): Likewise.
2364
2365 2019-03-06  Tom Tromey  <tom@tromey.com>
2366
2367         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2368
2369 2019-03-06  Tom Tromey  <tom@tromey.com>
2370
2371         * utils.h (free_current_contents): Don't declare.
2372         * utils.c (free_current_contents): Remove.
2373
2374 2019-03-06  Tom Tromey  <tom@tromey.com>
2375
2376         * top.c (quit_force): Update.
2377         * main.c (captured_command_loop): Update.
2378         * common/new-op.c (operator new): Update.
2379         * common/common-exceptions.c (struct catcher)
2380         <save_cleanup_chain>: Remove member.
2381         (exceptions_state_mc_init): Update.
2382         (exception_try_scope_entry): Return nullptr.
2383         (exception_try_scope_exit, exception_rethrow)
2384         (throw_exception_sjlj, throw_exception_cxx): Update.
2385         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2386         (all_cleanups, do_cleanups, discard_cleanups)
2387         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2388         (restore_cleanups, restore_final_cleanups): Don't declare.
2389         (do_final_cleanups): Remove parameter.
2390         * common/cleanups.c (cleanup_chain, make_cleanup)
2391         (make_cleanup_dtor, all_cleanups, do_cleanups)
2392         (discard_my_cleanups, discard_cleanups)
2393         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2394         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2395         (null_cleanup): Remove.
2396         (do_final_cleanups): Remove parameter.
2397
2398 2019-03-06  Tom Tromey  <tom@tromey.com>
2399
2400         * remote.c (remote_target::remote_parse_stop_reply): Use
2401         unique_xmalloc_ptr.
2402
2403 2019-03-06  Tom Tromey  <tom@tromey.com>
2404
2405         * stabsread.c (struct stabs_field_info): Rename from field_info.
2406         <list, fnlist>: Add initializers.
2407         <obstack>: New member.
2408         (read_member_functions, read_struct_fields, read_baseclasses):
2409         Allocate on obstack.  Don't use cleanups.
2410         (read_one_struct_field, read_member_functions, read_struct_fields)
2411         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2412         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2413         (read_struct_type): Update.
2414
2415 2019-03-06  Tom Tromey  <tom@tromey.com>
2416
2417         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2418         * common/filestuff.h (make_cleanup_close): Don't declare.
2419         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2420         Remove.
2421
2422 2019-03-06  Tom Tromey  <tom@tromey.com>
2423
2424         * solib-aix.c: Use make_scope_exit.
2425
2426 2019-03-06  Tom Tromey  <tom@tromey.com>
2427
2428         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2429         Use make_scope_exit.
2430
2431 2019-03-06  Tom Tromey  <tom@tromey.com>
2432
2433         * solib-svr4.c (disable_probes_interface): Remove parameter.
2434         (svr4_handle_solib_event): Use make_scope_exit.
2435
2436 2019-03-06  Tom Tromey  <tom@tromey.com>
2437
2438         * remote.c (struct stop_reply_deleter): Remove.
2439         (stop_reply_up): Update.
2440         (struct stop_reply): Derive from notif_event.  Don't typedef.
2441         <regcache>: Now a std::vector.
2442         (stop_reply_xfree): Remove.
2443         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2444         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2445         (remote_target::discard_pending_stop_replies): Use delete.
2446         (remote_target::remote_parse_stop_reply): Update.
2447         (remote_target::process_stop_reply): Update.
2448         * remote-notif.h (struct notif_event): Add virtual destructor.
2449         Remove "dtr" member.
2450         (struct notif_client) <alloc_event>: Return a unique_ptr.
2451         (notif_event_xfree): Don't declare.
2452         (notif_event_up): New typedef.
2453         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2454         (notif_event_xfree, do_notif_event_xfree): Remove.
2455         (remote_notif_state_xfree): Update.
2456
2457 2019-03-06  Tom Tromey  <tom@tromey.com>
2458
2459         * infrun.c (displaced_step_clear_cleanup): Now a
2460         forward_scope_exit type.
2461         (displaced_step_prepare_throw): Update.
2462         (displaced_step_fixup): Update.
2463
2464 2019-03-06  Tom Tromey  <tom@tromey.com>
2465
2466         * inferior.h (class inferior): Update comment.
2467         * gdbthread.h (class thread_info): Update comment.
2468
2469 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2470             Tom Tromey  <tom@tromey.com>
2471
2472         * stabsread.h (struct stab_section_list): Remove.
2473         (coffstab_build_psymtabs): Update.
2474         * dbxread.c (symbuf_sections): Now a std::vector.
2475         (sect_idx): New global.
2476         (fill_symbuf): Update.
2477         (coffstab_build_psymtabs): Change type of stabsects parameter.
2478         Update.
2479         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2480         std::vector.
2481         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2482         (coff_locate_sections): Update.
2483         (coff_symfile_read): Remove cleanups.  Update.
2484         (init_stringtab): Add storage parameter.
2485         (free_stringtab, free_stringtab_cleanup): Remove.
2486         (init_lineno): Add storage parameter.
2487         (free_linetab, free_linetab_cleanup): Remove.
2488
2489 2019-03-06  Pedro Alves  <palves@redhat.com>
2490
2491         * linux-fork.c (fork_info::clobber_regs): Delete.
2492         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2493         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2494         comment.  Adjust.
2495         (scoped_switch_fork_info::scoped_switch_fork_info)
2496         (checkpoint_command, linux_fork_context): Adjust
2497         fork_save_infrun_state calls.
2498
2499 2019-03-06  Pedro Alves  <palves@redhat.com>
2500
2501         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2502         (inf_has_multiple_threads): Return 'bool' and rewrite using
2503         inferior_info::threads().
2504
2505 2019-03-06  Pedro Alves  <palves@redhat.com>
2506
2507         * linux-fork.c: Include <list>.
2508         (fork_list): Now a std::list instance.
2509         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2510         (forks_exist_p, find_last_fork): Adjust.
2511         (new_fork): Delete.
2512         (one_fork_p): New.
2513         (add_fork): Adjust.
2514         (free_fork): Delete, folded into fork_info::~fork_info().
2515         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2516         Adjust.
2517         (init_fork_list): Delete.
2518         (linux_fork_killall, linux_fork_mourn_inferior)
2519         (linux_fork_detach, info_checkpoints_command): Adjust.
2520         (_initialize_linux_fork): No longer call init_fork_list.
2521
2522 2019-03-06  Pedro Alves  <palves@redhat.com>
2523
2524         * linux-fork.c (new_fork): New, split out of ...
2525         (add_fork): ... this.  Return void.  Move "first fork" special
2526         case from here, to ...
2527         (checkpoint_command): ... here.
2528         * linux-linux.h (add_fork): Return void.
2529
2530 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2531
2532         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2533
2534 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2535             Chris January  <chris.january@arm.com>
2536             David Lecomber  <david.lecomber@arm.com>
2537
2538         * f-exp.y: New token, UNOP_INTRINSIC.
2539         (exp): New pattern using UNOP_INTRINSIC token.
2540         (f77_keywords): Add 'abs' keyword.
2541         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2542         (value_from_host_double): New function.
2543         (evaluate_subexp_f): Support UNOP_ABS.
2544
2545 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2548         types.
2549
2550 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2551
2552         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2553         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2554         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2555
2556 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2557
2558         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2559
2560 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2561             Chris January  <chris.january@arm.com>
2562
2563         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2564         * f-exp.y: Define 'KIND' token.
2565         (exp): New pattern for KIND expressions.
2566         (ptype): Handle types with a kind extension.
2567         (direct_abs_decl): Extend to spot kind extensions.
2568         (f77_keywords): Add 'kind' to the list.
2569         (push_kind_type): New function.
2570         (convert_to_kind_type): New function.
2571         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2572         * parse.c (operator_length_standard): Likewise.
2573         * parser-defs.h (enum type_pieces): Add tp_kind.
2574         * std-operator.def: Add UNOP_KIND.
2575
2576 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2577
2578         * f-exp.y (f_parse): Set yydebug.
2579
2580 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2581
2582         * f-lang.c (evaluate_subexp_f): New function.
2583         (exp_descriptor_f): New global.
2584         (f_language_defn): Use exp_descriptor_f instead of
2585         exp_descriptor_standard.
2586
2587 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2588
2589         * f-exp.y (struct token): Add comments.
2590         (dot_ops): Remove uppercase versions and the end marker.
2591         (f77_keywords): Likewise.
2592         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2593         entries in the dot_ops array are case insensitive, and use
2594         strncasecmp to compare strings.  Also some whitespace cleanup in
2595         this area.  Similar for the f77_keywords array, except entries in
2596         this list might be case sensitive.
2597
2598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2599
2600         * f-exp.y (struct f77_boolean_val): Add comments.
2601         (boolean_values): Remove uppercase versions, and end marker.
2602         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2603         and use strncasecmp to achieve case insensitivity.  Additionally,
2604         perform whitespace cleanup around this code.
2605
2606 2019-03-06  Tom Tromey  <tromey@adacore.com>
2607
2608         * remote-sim.c (gdbsim_target_open): Use result of
2609         gdb_argv::release.
2610
2611 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2612         Dirk Schubert  <dirk.schubert@arm.com>
2613         Chris January  <chris.january@arm.com>
2614
2615         * eval.c (evaluate_subexp_standard): Call Fortran argument
2616         wrapping logic.
2617         * f-lang.c (struct value): A value which can be passed into a
2618         Fortran function call.
2619         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2620         where appropriate.
2621         (struct type): Value ready for a Fortran function call.
2622         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2623         is needed.
2624         * f-lang.h (fortran_argument_convert): Declaration.
2625         (fortran_preserve_arg_pointer): Declaration.
2626         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2627
2628 2019-03-05  Tom Tromey  <tromey@adacore.com>
2629
2630         * python/py-prettyprint.c (print_string_repr): Remove #if.
2631         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2632
2633 2019-03-05  Tom Tromey  <tromey@adacore.com>
2634
2635         * target.c (the_dummy_target): Move later.  Change type to
2636         "dummy_target".
2637         (initialize_targets): Don't initialize the_dummy_target.
2638
2639 2019-03-05  Tom Tromey  <tromey@adacore.com>
2640
2641         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2642         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2643
2644 2019-03-05  Tom Tromey  <tromey@adacore.com>
2645
2646         * windows-nat.c (windows_nat_target::attach)
2647         (windows_nat_target::detach): Don't call gdb_flush.
2648         * valprint.c (generic_val_print, val_print, val_print_string):
2649         Don't call gdb_flush.
2650         * utils.c (defaulted_query): Don't call gdb_flush.
2651         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2652         * target.c (target_announce_detach): Don't call gdb_flush.
2653         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2654         * remote.c (extended_remote_target::attach): Don't call
2655         gdb_flush.
2656         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2657         * printcmd.c (do_examine): Don't call gdb_flush.
2658         (info_display_command): Don't call gdb_flush.
2659         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2660         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2661         * memattr.c (info_mem_command): Don't call gdb_flush.
2662         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2663         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2664         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2665         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2666         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2667         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2668         (gnu_nat_target::detach): Don't call gdb_flush.
2669         * f-valprint.c (f_val_print): Don't call gdb_flush.
2670         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2671         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2672         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2673         gdb_flush.
2674         * c-valprint.c (c_val_print): Don't call gdb_flush.
2675         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2676
2677 2019-03-05  Tom Tromey  <tromey@adacore.com>
2678
2679         * varobj.c (update_dynamic_varobj_children): Update.
2680         (install_default_visualizer): Use reset, not release.
2681         * value.c (set_internalvar): Update.
2682         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2683         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2684         ATTRIBUTE_UNUSED_RESULT.
2685
2686 2019-03-05  Tom Tromey  <tromey@adacore.com>
2687
2688         * remote.c (class scoped_remote_fd) <release>: Add
2689         ATTRIBUTE_UNUSED_RESULT.
2690
2691 2019-03-05  Tom Tromey  <tromey@adacore.com>
2692
2693         * macroexp.c (struct macro_buffer) <release>: Add
2694         ATTRIBUTE_UNUSED_RESULT.
2695
2696 2019-03-05  Tom Tromey  <tromey@adacore.com>
2697
2698         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2699         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2700         ATTRIBUTE_UNUSED_RESULT.
2701
2702 2019-03-05  Tom Tromey  <tromey@adacore.com>
2703
2704         * common/scoped_fd.h (class scoped_fd) <release>: Add
2705         ATTRIBUTE_UNUSED_RESULT.
2706
2707 2019-03-05  Tom Tromey  <tromey@adacore.com>
2708
2709         * parser-defs.h (struct parser_state) <release>: Add
2710         ATTRIBUTE_UNUSED_RESULT.
2711
2712 2019-03-05  Tom Tromey  <tromey@adacore.com>
2713
2714         * utils.h (class gdb_argv) <release>: Add
2715         ATTRIBUTE_UNUSED_RESULT.
2716         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2717
2718 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2719
2720         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2721         for-loop range, to avoid compiler warnings.
2722
2723         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2724         avoid compiler warnings about unused variables.
2725
2726         * NEWS: Mention end of support for native debugging on MS-Windows
2727         before XP.
2728
2729         PR gdb/24292
2730         * common/netstuff.c:
2731         * gdbserver/gdbreplay.c
2732         * gdbserver/remote-utils.c:
2733         * ser-tcp.c:
2734         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2735         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2736         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2737         'getaddrinfo' and 'freeaddrinfo' were not available before
2738         Windows XP, and mingw.org's MinGW headers by default define
2739         _WIN32_WINNT to 0x500.
2740
2741 2019-03-01  Gary Benson <gbenson@redhat.com>
2742
2743         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2744
2745 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2746             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2747
2748         PR gdb/8527
2749         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2750         set_sigint_trap, clear_sigint_trap.
2751
2752 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2753
2754         * target.c (target_detach): Clear the regcache and the
2755         frame cache.
2756
2757 2019-02-27  Pedro Alves  <palves@redhat.com>
2758
2759         * utils.c (set_screen_size): When we cap the height/width sizes,
2760         tweak the corresponding command variable to show "unlimited":
2761
2762 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2763             Pedro Alves  <palves@redhat.com>
2764
2765         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2766         before calling rl_set_screen_size.
2767
2768 2019-02-27  Tom Tromey  <tromey@adacore.com>
2769
2770         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2771         define.
2772         * python/py-value.c: Remove Python 2.4 workaround.
2773         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2774         workaround.
2775         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2776         Python 2.4 workaround.
2777         * python/python-internal.h: Remove Python 2.4 comment.
2778         (Py_ssize_t): Don't define.
2779         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2780         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2781         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2782         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2783         * python/python.c (do_start_initialization): Remove Python 2.4
2784         workaround.
2785         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2786         (print_children): Remove Python 2.4 workaround.
2787         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2788         workaround.
2789         (CHARBUFFERPROC_NAME): Remove.
2790         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2791         Python 2.4 workaround.
2792
2793 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2794
2795         * NEWS: Note minimum Python version.
2796
2797 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2798
2799         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2800         code from these functions.  Remove corresponding ifdefs.  Use
2801         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2802         Remove gotos and target of gotos.
2803         (infpy_search_memory): Likewise.
2804
2805 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2806
2807         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2808         (hppa_gdbarch_init): Don't register deleted functions with
2809         gdbarch.
2810
2811 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2812
2813         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2814         (h8300_unwind_sp): Delete.
2815         (h8300_dummy_id): Delete.
2816         (h8300_gdbarch_init): Don't register deleted functions with
2817         gdbarch.
2818
2819 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2820
2821         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2822         (ft32_unwind_pc): Delete.
2823         (ft32_unwind_sp): Delete.
2824         (ft32_gdbarch_init): Don't register deleted functions with
2825         gdbarch.
2826
2827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2828
2829         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2830         (frv_unwind_pc): Delete.
2831         (frv_unwind_sp): Delete.
2832         (frv_gdbarch_init): Don't register deleted functions with
2833         gdbarch.
2834
2835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2836
2837         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2838         (riscv_unwind_pc): Delete.
2839         (riscv_unwind_sp): Delete.
2840         (riscv_gdbarch_init): Don't register deleted functions with
2841         gdbarch.
2842
2843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2844
2845         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2846         (csky_unwind_pc): Delete.
2847         (csky_unwind_sp): Delete.
2848         (csky_gdbarch_init): Don't register deleted functions with
2849         gdbarch.
2850
2851 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2852
2853         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2854         (cris_unwind_pc): Delete.
2855         (cris_unwind_sp): Delete.
2856         (cris_gdbarch_init): Don't register deleted functions with
2857         gdbarch.
2858
2859 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2860
2861         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2862         (bfin_unwind_pc): Delete.
2863         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2864
2865 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2866
2867         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2868         (arm_unwind_pc): Delete.
2869         (arm_unwind_sp): Delete.
2870         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2871
2872 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2873
2874         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2875         (arc_unwind_pc): Delete.
2876         (arc_unwind_sp): Delete.
2877         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2878
2879 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2880
2881         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2882         (alpha_unwind_pc): Delete.
2883         (alpha_gdbarch_init): Don't register deleted functions with
2884         gdbarch.
2885
2886 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2887
2888         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2889         (aarch64_unwind_pc): Delete.
2890         (aarch64_unwind_sp): Delete.
2891         (aarch64_gdbarch_init): Don't register deleted functions with
2892         gdbarch.
2893
2894 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2895
2896         * gdbtypes.c (type_align): Don't consider static members when
2897         computing structure alignment.
2898
2899 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2900
2901         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2902         return 0 for other types.
2903         * arch-utils.c (default_type_align): Always return 0.
2904         * gdbarch.h: Regenerate.
2905         * gdbarch.sh (type_align): Extend comment.
2906         * gdbtypes.c (type_align): Add additional comments, always call
2907         gdbarch_type_align before applying the default rules.
2908         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2909         generic code will then apply a suitable default.
2910         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2911         types, return 0 for other types.
2912
2913 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2914
2915         * NEWS: Create a new section for the next release branch.
2916         Rename the section of the current branch, now that it has
2917         been cut.
2918
2919 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2920
2921         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2922         * version.in: Bump version to 8.3.50.DATE-git.
2923
2924 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2925
2926         * aix-thread.c (ptid_cmp): Remove unused variable.
2927         (get_signaled_thread): Likewise.
2928         (store_regs_user_thread): Likewise.
2929         (store_regs_kernel_thread): Likewise.
2930         (fetch_regs_kernel_thread): Remove shadowed variable.
2931
2932 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2933
2934         * features/riscv/32bit-cpu.xml: Add register numbers.
2935         * features/riscv/32bit-fpu.c: Regenerate.
2936         * features/riscv/32bit-fpu.xml: Add register numbers.
2937         * features/riscv/64bit-cpu.xml: Add register numbers.
2938         * features/riscv/64bit-fpu.c: Regenerate.
2939         * features/riscv/64bit-fpu.xml: Add register numbers.
2940
2941 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2942
2943         * NEWS: Mention two argument form of gdb.Value constructor.
2944         * python/py-value.c (convert_buffer_and_type_to_value): New
2945         function.
2946         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2947         Add support for handling an optional second argument.  Call
2948         convert_buffer_and_type_to_value as appropriate.
2949         * python/python-internal.h (Py_buffer_deleter): New struct.
2950         (Py_buffer_up): New typedef.
2951
2952 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2953
2954         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2955         instead of releasing ownership.
2956
2957 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2958
2959         * dwarf2read.c (open_and_init_dwp_file): Call
2960         elf_numsections instead of bfd_count_sections to initialize
2961         dwp_file->num_sections.
2962
2963 2019-02-25  Tom Tromey  <tromey@adacore.com>
2964
2965         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2966
2967 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2968
2969         * gcore.in: Add '--readnever' option when invoking GDB.
2970
2971 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2972
2973         * MAINTAINERS: Update my email address.
2974
2975 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2976
2977         * build-id.c (build_id_to_debug_bfd_1): New function.
2978         (build_id_to_debug_bfd): Look for separate debug file in
2979         sysroot.
2980
2981 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2982
2983         * gdbarch.sh: Update the copyright year range that is placed into
2984         generated files.
2985
2986 2019-02-22  Keith Seitz  <keiths@redhat.com>
2987
2988         PR symtab/23853
2989         * linespec.c (create_sals_line_offset): Search for the default
2990         symtab's filename instead of its fullname.
2991
2992 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2993
2994         * NEWS: Update style defaults.
2995
2996 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2997
2998         * main.c (captured_main_1): Disable styling in batch mode.
2999
3000 2019-02-20  Tom Tromey  <tom@tromey.com>
3001
3002         * symtab.c (symtab_symbol_info): Fix typos.
3003
3004 2019-02-20  Tom Tromey  <tromey@adacore.com>
3005
3006         * findcmd.c (_initialize_mem_search): Use upper case for
3007         metasyntactic variables.
3008
3009 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3010
3011         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3012         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3013
3014 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3015
3016         * top.h (source_file_name): Change to std::string.
3017         * top.c (source_file_name): Likewise.
3018         (command_line_input): Adjust.
3019         * cli/cli-script.c (script_from_file): Adjust.
3020
3021 2019-02-19  Tom Tromey  <tromey@adacore.com>
3022
3023         * ravenscar-thread.c
3024         (ravenscar_thread_target::update_thread_list): Don't call
3025         ada_build_task_list.
3026         * ada-lang.h (ada_build_task_list): Don't declare.
3027         * ada-tasks.c (struct ada_tasks_inferior_data)
3028         <task_list_valid_p>: Now bool.
3029         (read_known_tasks, ada_task_list_changed)
3030         (ada_tasks_invalidate_inferior_data): Update.
3031         (read_known_tasks_array): Return bool.
3032         (read_known_tasks_list): Likewise.
3033         (read_known_tasks): Return void.
3034         (ada_build_task_list): Now static.
3035
3036 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3037
3038         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3039         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3040
3041 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3042
3043         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3044         variant for ada_tasks_pspace_data_handle and
3045         ada_tasks_inferior_data_handle.
3046         (ada_tasks_pspace_data_cleanup): New function.
3047         (ada_tasks_inferior_data_cleanup): New function.
3048
3049 2019-02-17  Tom Tromey  <tom@tromey.com>
3050
3051         * macrotab.h (macro_source_fullname): Return a std::string.
3052         * macrotab.c (macro_include, check_for_redefinition)
3053         (macro_undef, macro_lookup_definition, foreach_macro)
3054         (foreach_macro_in_scope): Update.
3055         (macro_source_fullname): Return a std::string.
3056         * macrocmd.c (show_pp_source_pos): Update.
3057
3058 2019-02-17  Tom Tromey  <tom@tromey.com>
3059
3060         * macrocmd.c (show_pp_source_pos): Style the file names.
3061
3062 2019-02-17  Tom Tromey  <tom@tromey.com>
3063
3064         PR tui/24197:
3065         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3066
3067 2019-02-17  Tom Tromey  <tom@tromey.com>
3068
3069         * ada-lang.c (user_select_syms): Use filtered printing.
3070         * utils.c (wrap_style): New global.
3071         (desired_style): Remove.
3072         (emit_style_escape): Add stream parameter.
3073         (set_output_style, reset_terminal_style, prompt_for_continue):
3074         Update.
3075         (flush_wrap_buffer): Only flush gdb_stdout.
3076         (wrap_here): Set wrap_style.
3077         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3078         treat escape sequences as a character.  Change when wrap buffer is
3079         flushed.
3080         (fputs_styled): Do not set the output style when the default is
3081         requested.
3082         * ui-style.h (struct ui_file_style) <is_default>: New method.
3083         * source.c (print_source_lines_base): Emit escape sequences in one
3084         piece.
3085
3086 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3087
3088         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3089         integers and enumeration types.
3090
3091 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3092
3093         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3094         instead of lookup_symbol_in_language
3095         (do_exact_match): New function.
3096         (ada_get_symbol_name_matcher): Return do_exact_match when
3097         doing a verbatim match.
3098
3099 2019-02-15  Tom Tromey  <tromey@adacore.com>
3100
3101         * ravenscar-thread.c (ravenscar_thread_target::resume)
3102         (ravenscar_thread_target::wait): Special case wildcard requests.
3103
3104 2019-02-15  Tom Tromey  <tromey@adacore.com>
3105
3106         * ravenscar-thread.c (base_ptid): Remove.
3107         (struct ravenscar_thread_target) <close>: New method.
3108         <m_base_ptid>: New member.
3109         <update_inferior_ptid, active_task, task_is_currently_active,
3110         runtime_initialized>: Declare methods.
3111         <ravenscar_thread_target>: Add constructor.
3112         (ravenscar_thread_target::task_is_currently_active)
3113         (ravenscar_thread_target::update_inferior_ptid)
3114         (ravenscar_runtime_initialized): Rename.  Now methods.
3115         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3116         (ravenscar_thread_target::update_thread_list): Update.
3117         (ravenscar_thread_target::active_task): Now method.
3118         (ravenscar_thread_target::store_registers)
3119         (ravenscar_thread_target::prepare_to_store)
3120         (ravenscar_thread_target::prepare_to_store)
3121         (ravenscar_thread_target::mourn_inferior): Update.
3122         (ravenscar_inferior_created): Use "new" to create target.
3123         (ravenscar_thread_target::get_ada_task_ptid): Update.
3124         (_initialize_ravenscar): Don't initialize base_ptid.
3125         (ravenscar_ops): Remove global.
3126
3127 2019-02-15  Tom Tromey  <tromey@adacore.com>
3128
3129         * target.h (push_target): Declare new overload.
3130         * target.c (push_target): New overload, taking an rvalue reference.
3131         * remote.c (remote_target::open_1): Use push_target overload.
3132         * corelow.c (core_target_open): Use push_target overload.
3133
3134 2019-02-15  Tom Tromey  <tromey@adacore.com>
3135
3136         * ravenscar-thread.c (is_ravenscar_task)
3137         (ravenscar_task_is_currently_active): Return bool.
3138         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3139         (_initialize_ravenscar): Remove "(void)".
3140         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3141         Return bool.
3142
3143 2019-02-15  Tom Tromey  <tromey@adacore.com>
3144
3145         * ravenscar-thread.c (ravenscar_runtime_initializer)
3146         (has_ravenscar_runtime, get_running_thread_id)
3147         (ravenscar_thread_target::resume): Fix indentation.
3148
3149 2019-02-15  Tom Tromey  <tromey@adacore.com>
3150
3151         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3152         from ravenscar_arch_ops.
3153         (sparc_ravenscar_ops::fetch_registers)
3154         (sparc_ravenscar_ops::store_registers): Now methods.
3155         (sparc_ravenscar_prepare_to_store): Remove.
3156         (sparc_ravenscar_ops): Redefine.
3157         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3158         methods and destructor.  Remove members.
3159         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3160         (ravenscar_thread_target::store_registers)
3161         (ravenscar_thread_target::prepare_to_store): Update.
3162         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3163         Remove.
3164         (struct ppc_ravenscar_powerpc_ops): Derive from
3165         ravenscar_arch_ops.
3166         (ppc_ravenscar_powerpc_ops::fetch_registers)
3167         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3168         (ppc_ravenscar_powerpc_ops): Redefine.
3169         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3170         (ppc_ravenscar_e500_ops::fetch_registers)
3171         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3172         (ppc_ravenscar_e500_ops): Redefine.
3173         * aarch64-ravenscar-thread.c
3174         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3175         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3176         (aarch64_ravenscar_fetch_registers)
3177         (aarch64_ravenscar_store_registers): Now methods.
3178         (aarch64_ravenscar_ops): Redefine.
3179
3180 2019-02-15  Tom Tromey  <tromey@adacore.com>
3181
3182         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3183         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3184         (ravenscar_thread_target::stopped_by_watchpoint)
3185         (ravenscar_thread_target::stopped_data_address)
3186         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3187
3188 2019-02-15  Tom Tromey  <tromey@adacore.com>
3189
3190         * ravenscar-thread.c: Fix some typos.
3191
3192 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3193             Tom Tromey  <tromey@adacore.com>
3194
3195         * ada-lang.c (ada_exception_sal): Change addr_string to a
3196         std::string.
3197         (create_ada_exception_catchpoint): Update.
3198
3199 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3200             Tom Tromey  <tromey@adacore.com>
3201
3202         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3203         (bp_location_ops): Remove.
3204         (base_breakpoint_allocate_location): Update.
3205         (free_bp_location): Update.
3206         * ada-lang.c (class ada_catchpoint_location)
3207         <ada_catchpoint_location>: Remove ops parameter.
3208         (ada_catchpoint_location_dtor): Remove.
3209         (ada_catchpoint_location_ops): Remove.
3210         (allocate_location_exception): Update.
3211         * breakpoint.h (struct bp_location_ops): Remove.
3212         (class bp_location) <bp_location>: Remove bp_location_ops
3213         parameter.
3214         <~bp_location>: Add destructor.
3215         <ops>: Remove.
3216
3217 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3218             Pedro Alves  <palves@redhat.com>
3219
3220         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3221         'PATH_MAX'.
3222
3223 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3224             Samuel Thibault  <samuel.thibault@gnu.org>
3225             Thomas Schwinge  <thomas@codesourcery.com>
3226
3227         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3228         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3229
3230 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3231
3232         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3233         (check_empty): Use "const char *".
3234
3235         * gnu-nat.c (gnu_nat_target::detach): Instead of
3236         'detach_inferior (pid)' call
3237         'detach_inferior (find_inferior_pid (pid))'.
3238
3239         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3240         'nat/fork-inferior.o'.
3241         * gnu-nat.c: #include "nat/fork-inferior.h".
3242
3243         * gnu-nat.c (gnu_nat_target::detach): Instead of
3244         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3245         * gnu-nat.h: #include "inf-child.h".
3246         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3247         'i386_gnu_nat_target::fetch_registers'.
3248         (gnu_store_registers): Rename/move to
3249         'i386_gnu_nat_target::store_registers'.
3250
3251         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3252         * gnu-nat.h (mach_thread_info): New function.
3253         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3254
3255         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3256
3257 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3258
3259         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3260
3261 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3262
3263         * windows-nat.c (windows_add_thread): Add new parameter
3264         "main_thread_p" with default value set to false.  Update
3265         function documentation as well as all callers.
3266         (windows_delete_thread): Likewise.
3267         (fake_create_process): Update call to windows_add_thread.
3268         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3269         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3270         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3271         call to windows_delete_thread.
3272
3273 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3274
3275         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3276
3277 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3278
3279         * symfile.c (find_separate_debug_file): Use canonical path of
3280         sysroot with child_path instead of gdb_sysroot if it is valid.
3281
3282 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3283
3284         * symfile.c (find_separate_debug_file): Use child_path to
3285         determine if an object file is under a sysroot.
3286
3287 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3288
3289         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3290         unittests/child-path-selftests.c.
3291         * common/pathstuff.c (child_path): New function.
3292         * common/pathstuff.h (child_path): New prototype.
3293         * unittests/child-path-selftests.c: New file.
3294
3295 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3296
3297         * symfile.c (find_separate_debug_file): Look for separate debug
3298         files in debug directories under the sysroot.
3299
3300 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3301
3302         * symtab.h (struct minimal_symbol data_p): New const method.
3303         (struct minimal_symbol text_p): Likewise.
3304         * symtab.c (output_source_filename): Use file name style
3305         to print file name.
3306         (print_symbol_info): Likewise.
3307         (print_msymbol_info): Use address style to print addresses.
3308         Use function name style to print executable text symbols.
3309         (expand_symtab_containing_pc): Use data_p.
3310         (find_pc_sect_compunit_symtab): Likewise.
3311
3312 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3313
3314         * breakpoint.c (describe_other_breakpoints): Use address style
3315         to print addresses.
3316         (say_where): Likewise.
3317
3318 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3319
3320         * ada-typeprint.c (print_func_type): Print function name
3321         style to print function name.
3322         * c-typeprint.c (c_print_type_1): Likewise.
3323
3324 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3325
3326         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3327         for execve.
3328
3329 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3330
3331         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3332         type_stack.
3333
3334 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3335
3336         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3337         TYPE_CODE_REF types.
3338
3339 2019-02-08  Jim Wilson  <jimw@sifive.com>
3340
3341         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3342         (riscv_linux_fregset): New.
3343         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3344
3345 2019-02-07  Tom Tromey  <tom@tromey.com>
3346
3347         * thread.c (thread_cancel_execution_command): Update.
3348         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3349         methods.
3350         (struct thread_fsm_ops): Remove.
3351         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3352         (thread_fsm_should_stop, thread_fsm_return_value)
3353         (thread_fsm_set_finished, thread_fsm_finished_p)
3354         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3355         Don't declare.
3356         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3357         * infrun.c (clear_proceed_status_thread)
3358         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3359         (print_stop_event): Update.
3360         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3361         Add constructor.
3362         (step_command_fsm_ops): Remove.
3363         (new_step_command_fsm): Remove.
3364         (step_1): Update.
3365         (step_command_fsm::should_stop): Rename from
3366         step_command_fsm_should_stop.
3367         (step_command_fsm::clean_up): Rename from
3368         step_command_fsm_clean_up.
3369         (step_command_fsm::do_async_reply_reason): Rename from
3370         step_command_fsm_async_reply_reason.
3371         (struct until_next_fsm): Inherit from thread_fsm.  Add
3372         constructor.
3373         (until_next_fsm_ops): Remove.
3374         (new_until_next_fsm): Remove.
3375         (until_next_fsm::should_stop): Rename from
3376         until_next_fsm_should_stop.
3377         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3378         (until_next_fsm::do_async_reply_reason): Rename from
3379         until_next_fsm_async_reply_reason.
3380         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3381         constructor.  Change type of breakpoint.
3382         (finish_command_fsm_ops): Remove.
3383         (new_finish_command_fsm): Remove.
3384         (finish_command_fsm::should_stop): Rename from
3385         finish_command_fsm_should_stop.
3386         (finish_command_fsm::clean_up): Rename from
3387         finish_command_fsm_clean_up.
3388         (finish_command_fsm::return_value): Rename from
3389         finish_command_fsm_return_value.
3390         (finish_command_fsm::do_async_reply_reason): Rename from
3391         finish_command_fsm_async_reply_reason.
3392         (finish_command): Update.
3393         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3394         Add constructor.
3395         (call_thread_fsm_ops): Remove.
3396         (call_thread_fsm::call_thread_fsm): Rename from
3397         new_call_thread_fsm.
3398         (call_thread_fsm::should_stop): Rename from
3399         call_thread_fsm_should_stop.
3400         (call_thread_fsm::should_notify_stop): Rename from
3401         call_thread_fsm_should_notify_stop.
3402         (run_inferior_call, call_function_by_hand_dummy): Update.
3403         * cli/cli-interp.c (should_print_stop_to_console): Update.
3404         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3405         Add constructor.  Change type of location_breakpoint,
3406         caller_breakpoint.
3407         (until_break_fsm_ops): Remove.
3408         (new_until_break_fsm): Remove.
3409         (until_break_fsm::should_stop): Rename from
3410         until_break_fsm_should_stop.
3411         (until_break_fsm::clean_up): Rename from
3412         until_break_fsm_clean_up.
3413         (until_break_fsm::do_async_reply_reason): Rename from
3414         until_break_fsm_async_reply_reason.
3415         (until_break_command): Update.
3416         * thread-fsm.c: Remove.
3417         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3418
3419 2019-02-07  Tom Tromey  <tom@tromey.com>
3420
3421         * yy-remap.h: Add include guard.
3422         * xtensa-tdep.h: Add include guard.
3423         * xcoffread.h: Rename include guard.
3424         * varobj-iter.h: Add include guard.
3425         * tui/tui.h: Rename include guard.
3426         * tui/tui-winsource.h: Rename include guard.
3427         * tui/tui-wingeneral.h: Rename include guard.
3428         * tui/tui-windata.h: Rename include guard.
3429         * tui/tui-win.h: Rename include guard.
3430         * tui/tui-stack.h: Rename include guard.
3431         * tui/tui-source.h: Rename include guard.
3432         * tui/tui-regs.h: Rename include guard.
3433         * tui/tui-out.h: Rename include guard.
3434         * tui/tui-layout.h: Rename include guard.
3435         * tui/tui-io.h: Rename include guard.
3436         * tui/tui-hooks.h: Rename include guard.
3437         * tui/tui-file.h: Rename include guard.
3438         * tui/tui-disasm.h: Rename include guard.
3439         * tui/tui-data.h: Rename include guard.
3440         * tui/tui-command.h: Rename include guard.
3441         * tic6x-tdep.h: Add include guard.
3442         * target/waitstatus.h: Rename include guard.
3443         * target/wait.h: Rename include guard.
3444         * target/target.h: Rename include guard.
3445         * target/resume.h: Rename include guard.
3446         * target-float.h: Rename include guard.
3447         * stabsread.h: Add include guard.
3448         * rs6000-tdep.h: Add include guard.
3449         * riscv-fbsd-tdep.h: Add include guard.
3450         * regformats/regdef.h: Rename include guard.
3451         * record.h: Rename include guard.
3452         * python/python.h: Rename include guard.
3453         * python/python-internal.h: Rename include guard.
3454         * python/py-stopevent.h: Rename include guard.
3455         * python/py-ref.h: Rename include guard.
3456         * python/py-record.h: Rename include guard.
3457         * python/py-record-full.h: Rename include guard.
3458         * python/py-record-btrace.h: Rename include guard.
3459         * python/py-instruction.h: Rename include guard.
3460         * python/py-events.h: Rename include guard.
3461         * python/py-event.h: Rename include guard.
3462         * procfs.h: Add include guard.
3463         * proc-utils.h: Add include guard.
3464         * p-lang.h: Add include guard.
3465         * or1k-tdep.h: Rename include guard.
3466         * observable.h: Rename include guard.
3467         * nto-tdep.h: Rename include guard.
3468         * nat/x86-linux.h: Rename include guard.
3469         * nat/x86-linux-dregs.h: Rename include guard.
3470         * nat/x86-gcc-cpuid.h: Add include guard.
3471         * nat/x86-dregs.h: Rename include guard.
3472         * nat/x86-cpuid.h: Rename include guard.
3473         * nat/ppc-linux.h: Rename include guard.
3474         * nat/mips-linux-watch.h: Rename include guard.
3475         * nat/linux-waitpid.h: Rename include guard.
3476         * nat/linux-ptrace.h: Rename include guard.
3477         * nat/linux-procfs.h: Rename include guard.
3478         * nat/linux-osdata.h: Rename include guard.
3479         * nat/linux-nat.h: Rename include guard.
3480         * nat/linux-namespaces.h: Rename include guard.
3481         * nat/linux-btrace.h: Rename include guard.
3482         * nat/glibc_thread_db.h: Rename include guard.
3483         * nat/gdb_thread_db.h: Rename include guard.
3484         * nat/gdb_ptrace.h: Rename include guard.
3485         * nat/fork-inferior.h: Rename include guard.
3486         * nat/amd64-linux-siginfo.h: Rename include guard.
3487         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3488         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3489         * nat/aarch64-linux.h: Rename include guard.
3490         * nat/aarch64-linux-hw-point.h: Rename include guard.
3491         * mn10300-tdep.h: Add include guard.
3492         * mips-linux-tdep.h: Add include guard.
3493         * mi/mi-parse.h: Rename include guard.
3494         * mi/mi-out.h: Rename include guard.
3495         * mi/mi-main.h: Rename include guard.
3496         * mi/mi-interp.h: Rename include guard.
3497         * mi/mi-getopt.h: Rename include guard.
3498         * mi/mi-console.h: Rename include guard.
3499         * mi/mi-common.h: Rename include guard.
3500         * mi/mi-cmds.h: Rename include guard.
3501         * mi/mi-cmd-break.h: Rename include guard.
3502         * m2-lang.h: Add include guard.
3503         * location.h: Rename include guard.
3504         * linux-record.h: Rename include guard.
3505         * linux-nat.h: Add include guard.
3506         * linux-fork.h: Add include guard.
3507         * i386-darwin-tdep.h: Rename include guard.
3508         * hppa-linux-offsets.h: Add include guard.
3509         * guile/guile.h: Rename include guard.
3510         * guile/guile-internal.h: Rename include guard.
3511         * gnu-nat.h: Rename include guard.
3512         * gdb-stabs.h: Rename include guard.
3513         * frv-tdep.h: Add include guard.
3514         * f-lang.h: Add include guard.
3515         * event-loop.h: Add include guard.
3516         * darwin-nat.h: Rename include guard.
3517         * cp-abi.h: Rename include guard.
3518         * config/sparc/nm-sol2.h: Rename include guard.
3519         * config/nm-nto.h: Rename include guard.
3520         * config/nm-linux.h: Add include guard.
3521         * config/i386/nm-i386gnu.h: Rename include guard.
3522         * config/djgpp/nl_types.h: Rename include guard.
3523         * config/djgpp/langinfo.h: Rename include guard.
3524         * compile/gcc-cp-plugin.h: Add include guard.
3525         * compile/gcc-c-plugin.h: Add include guard.
3526         * compile/compile.h: Rename include guard.
3527         * compile/compile-object-run.h: Rename include guard.
3528         * compile/compile-object-load.h: Rename include guard.
3529         * compile/compile-internal.h: Rename include guard.
3530         * compile/compile-cplus.h: Rename include guard.
3531         * compile/compile-c.h: Rename include guard.
3532         * common/xml-utils.h: Rename include guard.
3533         * common/x86-xstate.h: Rename include guard.
3534         * common/version.h: Rename include guard.
3535         * common/vec.h: Rename include guard.
3536         * common/tdesc.h: Rename include guard.
3537         * common/selftest.h: Rename include guard.
3538         * common/scoped_restore.h: Rename include guard.
3539         * common/scoped_mmap.h: Rename include guard.
3540         * common/scoped_fd.h: Rename include guard.
3541         * common/safe-iterator.h: Rename include guard.
3542         * common/run-time-clock.h: Rename include guard.
3543         * common/refcounted-object.h: Rename include guard.
3544         * common/queue.h: Rename include guard.
3545         * common/ptid.h: Rename include guard.
3546         * common/print-utils.h: Rename include guard.
3547         * common/preprocessor.h: Rename include guard.
3548         * common/pathstuff.h: Rename include guard.
3549         * common/observable.h: Rename include guard.
3550         * common/netstuff.h: Rename include guard.
3551         * common/job-control.h: Rename include guard.
3552         * common/host-defs.h: Rename include guard.
3553         * common/gdb_wait.h: Rename include guard.
3554         * common/gdb_vecs.h: Rename include guard.
3555         * common/gdb_unlinker.h: Rename include guard.
3556         * common/gdb_unique_ptr.h: Rename include guard.
3557         * common/gdb_tilde_expand.h: Rename include guard.
3558         * common/gdb_sys_time.h: Rename include guard.
3559         * common/gdb_string_view.h: Rename include guard.
3560         * common/gdb_splay_tree.h: Rename include guard.
3561         * common/gdb_setjmp.h: Rename include guard.
3562         * common/gdb_ref_ptr.h: Rename include guard.
3563         * common/gdb_optional.h: Rename include guard.
3564         * common/gdb_locale.h: Rename include guard.
3565         * common/gdb_assert.h: Rename include guard.
3566         * common/filtered-iterator.h: Rename include guard.
3567         * common/filestuff.h: Rename include guard.
3568         * common/fileio.h: Rename include guard.
3569         * common/environ.h: Rename include guard.
3570         * common/common-utils.h: Rename include guard.
3571         * common/common-types.h: Rename include guard.
3572         * common/common-regcache.h: Rename include guard.
3573         * common/common-inferior.h: Rename include guard.
3574         * common/common-gdbthread.h: Rename include guard.
3575         * common/common-exceptions.h: Rename include guard.
3576         * common/common-defs.h: Rename include guard.
3577         * common/common-debug.h: Rename include guard.
3578         * common/cleanups.h: Rename include guard.
3579         * common/buffer.h: Rename include guard.
3580         * common/btrace-common.h: Rename include guard.
3581         * common/break-common.h: Rename include guard.
3582         * cli/cli-utils.h: Rename include guard.
3583         * cli/cli-style.h: Rename include guard.
3584         * cli/cli-setshow.h: Rename include guard.
3585         * cli/cli-script.h: Rename include guard.
3586         * cli/cli-interp.h: Rename include guard.
3587         * cli/cli-decode.h: Rename include guard.
3588         * cli/cli-cmds.h: Rename include guard.
3589         * charset-list.h: Add include guard.
3590         * buildsym-legacy.h: Rename include guard.
3591         * bfin-tdep.h: Add include guard.
3592         * ax.h: Rename include guard.
3593         * arm-linux-tdep.h: Add include guard.
3594         * arm-fbsd-tdep.h: Add include guard.
3595         * arch/xtensa.h: Rename include guard.
3596         * arch/tic6x.h: Add include guard.
3597         * arch/i386.h: Add include guard.
3598         * arch/arm.h: Rename include guard.
3599         * arch/arm-linux.h: Rename include guard.
3600         * arch/arm-get-next-pcs.h: Rename include guard.
3601         * arch/amd64.h: Add include guard.
3602         * arch/aarch64-insn.h: Rename include guard.
3603         * arch-utils.h: Rename include guard.
3604         * annotate.h: Add include guard.
3605         * amd64-darwin-tdep.h: Rename include guard.
3606         * aarch64-linux-tdep.h: Add include guard.
3607         * aarch64-fbsd-tdep.h: Add include guard.
3608         * aarch32-linux-nat.h: Add include guard.
3609
3610 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3611
3612         * macrotab.c (macro_define_internal): New function that
3613         factorizes macro_define_object_internal and macro_define_function
3614         code.
3615         (macro_define_object_internal): Use macro_define_internal.
3616         (macro_define_function): Likewise.
3617
3618 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3619
3620         * macrocmd.c (extract_identifier): Return
3621         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3622         callers.
3623
3624 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3625
3626         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3627
3628 2019-02-05  Tom Tromey  <tom@tromey.com>
3629
3630         * target.c (target_stack::unpush): Move assertion earlier.
3631
3632 2019-01-30  Tom Tromey  <tom@tromey.com>
3633
3634         PR python/23615:
3635         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3636         (gdbpy_parse_and_eval): Likewise.
3637         * python/python-internal.h (gdbpy_allow_threads): New class.
3638
3639 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3640
3641         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3642         (aarch64_fbsd_fpregmap): Move earlier.
3643         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3644         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3645         instead of individual calls to trad_frame_set_reg_addr.
3646         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3647         earlier.
3648         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3649         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3650         instead of individual calls to trad_frame_set_reg_addr.
3651
3652 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3653
3654         * CONTRIBUTE: Replace contribution list with wiki link.
3655
3656 2019-01-25  Tom Tromey  <tom@tromey.com>
3657
3658         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3659
3660 2019-01-25  Tom Tromey  <tom@tromey.com>
3661
3662         * xtensa-linux-nat.c: Fix common/ includes.
3663         * xml-support.h: Fix common/ includes.
3664         * xml-support.c: Fix common/ includes.
3665         * x86-linux-nat.c: Fix common/ includes.
3666         * windows-nat.c: Fix common/ includes.
3667         * varobj.h: Fix common/ includes.
3668         * varobj.c: Fix common/ includes.
3669         * value.c: Fix common/ includes.
3670         * valops.c: Fix common/ includes.
3671         * utils.c: Fix common/ includes.
3672         * unittests/xml-utils-selftests.c: Fix common/ includes.
3673         * unittests/utils-selftests.c: Fix common/ includes.
3674         * unittests/unpack-selftests.c: Fix common/ includes.
3675         * unittests/tracepoint-selftests.c: Fix common/ includes.
3676         * unittests/style-selftests.c: Fix common/ includes.
3677         * unittests/string_view-selftests.c: Fix common/ includes.
3678         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3679         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3680         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3681         * unittests/rsp-low-selftests.c: Fix common/ includes.
3682         * unittests/parse-connection-spec-selftests.c: Fix common/
3683         includes.
3684         * unittests/optional-selftests.c: Fix common/ includes.
3685         * unittests/offset-type-selftests.c: Fix common/ includes.
3686         * unittests/observable-selftests.c: Fix common/ includes.
3687         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3688         * unittests/memrange-selftests.c: Fix common/ includes.
3689         * unittests/memory-map-selftests.c: Fix common/ includes.
3690         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3691         * unittests/function-view-selftests.c: Fix common/ includes.
3692         * unittests/environ-selftests.c: Fix common/ includes.
3693         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3694         * unittests/common-utils-selftests.c: Fix common/ includes.
3695         * unittests/cli-utils-selftests.c: Fix common/ includes.
3696         * unittests/array-view-selftests.c: Fix common/ includes.
3697         * ui-file.c: Fix common/ includes.
3698         * tui/tui-io.c: Fix common/ includes.
3699         * tracepoint.h: Fix common/ includes.
3700         * tracepoint.c: Fix common/ includes.
3701         * tracefile-tfile.c: Fix common/ includes.
3702         * top.h: Fix common/ includes.
3703         * top.c: Fix common/ includes.
3704         * thread.c: Fix common/ includes.
3705         * target/waitstatus.h: Fix common/ includes.
3706         * target/waitstatus.c: Fix common/ includes.
3707         * target.h: Fix common/ includes.
3708         * target.c: Fix common/ includes.
3709         * target-memory.c: Fix common/ includes.
3710         * target-descriptions.c: Fix common/ includes.
3711         * symtab.h: Fix common/ includes.
3712         * symfile.c: Fix common/ includes.
3713         * stap-probe.c: Fix common/ includes.
3714         * spu-linux-nat.c: Fix common/ includes.
3715         * sparc-nat.c: Fix common/ includes.
3716         * source.c: Fix common/ includes.
3717         * solib.c: Fix common/ includes.
3718         * solib-target.c: Fix common/ includes.
3719         * ser-unix.c: Fix common/ includes.
3720         * ser-tcp.c: Fix common/ includes.
3721         * ser-pipe.c: Fix common/ includes.
3722         * ser-base.c: Fix common/ includes.
3723         * selftest-arch.c: Fix common/ includes.
3724         * s12z-tdep.c: Fix common/ includes.
3725         * rust-exp.y: Fix common/ includes.
3726         * rs6000-aix-tdep.c: Fix common/ includes.
3727         * riscv-tdep.c: Fix common/ includes.
3728         * remote.c: Fix common/ includes.
3729         * remote-notif.h: Fix common/ includes.
3730         * remote-fileio.h: Fix common/ includes.
3731         * remote-fileio.c: Fix common/ includes.
3732         * regcache.h: Fix common/ includes.
3733         * regcache.c: Fix common/ includes.
3734         * record-btrace.c: Fix common/ includes.
3735         * python/python.c: Fix common/ includes.
3736         * python/py-type.c: Fix common/ includes.
3737         * python/py-inferior.c: Fix common/ includes.
3738         * progspace.h: Fix common/ includes.
3739         * producer.c: Fix common/ includes.
3740         * procfs.c: Fix common/ includes.
3741         * proc-api.c: Fix common/ includes.
3742         * printcmd.c: Fix common/ includes.
3743         * ppc-linux-nat.c: Fix common/ includes.
3744         * parser-defs.h: Fix common/ includes.
3745         * osdata.c: Fix common/ includes.
3746         * obsd-nat.c: Fix common/ includes.
3747         * nat/x86-linux.c: Fix common/ includes.
3748         * nat/x86-linux-dregs.c: Fix common/ includes.
3749         * nat/x86-dregs.h: Fix common/ includes.
3750         * nat/x86-dregs.c: Fix common/ includes.
3751         * nat/ppc-linux.c: Fix common/ includes.
3752         * nat/mips-linux-watch.h: Fix common/ includes.
3753         * nat/mips-linux-watch.c: Fix common/ includes.
3754         * nat/linux-waitpid.c: Fix common/ includes.
3755         * nat/linux-ptrace.h: Fix common/ includes.
3756         * nat/linux-ptrace.c: Fix common/ includes.
3757         * nat/linux-procfs.c: Fix common/ includes.
3758         * nat/linux-personality.c: Fix common/ includes.
3759         * nat/linux-osdata.c: Fix common/ includes.
3760         * nat/linux-namespaces.c: Fix common/ includes.
3761         * nat/linux-btrace.h: Fix common/ includes.
3762         * nat/linux-btrace.c: Fix common/ includes.
3763         * nat/fork-inferior.c: Fix common/ includes.
3764         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3765         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3766         * nat/aarch64-linux.c: Fix common/ includes.
3767         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3768         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3769         * namespace.h: Fix common/ includes.
3770         * mips-linux-tdep.c: Fix common/ includes.
3771         * minsyms.c: Fix common/ includes.
3772         * mi/mi-parse.h: Fix common/ includes.
3773         * mi/mi-main.c: Fix common/ includes.
3774         * mi/mi-cmd-env.c: Fix common/ includes.
3775         * memrange.h: Fix common/ includes.
3776         * memattr.c: Fix common/ includes.
3777         * maint.h: Fix common/ includes.
3778         * maint.c: Fix common/ includes.
3779         * main.c: Fix common/ includes.
3780         * machoread.c: Fix common/ includes.
3781         * location.c: Fix common/ includes.
3782         * linux-thread-db.c: Fix common/ includes.
3783         * linux-nat.c: Fix common/ includes.
3784         * linux-fork.c: Fix common/ includes.
3785         * inline-frame.c: Fix common/ includes.
3786         * infrun.c: Fix common/ includes.
3787         * inflow.c: Fix common/ includes.
3788         * inferior.h: Fix common/ includes.
3789         * inferior.c: Fix common/ includes.
3790         * infcmd.c: Fix common/ includes.
3791         * inf-ptrace.c: Fix common/ includes.
3792         * inf-child.c: Fix common/ includes.
3793         * ia64-linux-nat.c: Fix common/ includes.
3794         * i387-tdep.c: Fix common/ includes.
3795         * i386-tdep.c: Fix common/ includes.
3796         * i386-linux-tdep.c: Fix common/ includes.
3797         * i386-linux-nat.c: Fix common/ includes.
3798         * i386-go32-tdep.c: Fix common/ includes.
3799         * i386-fbsd-tdep.c: Fix common/ includes.
3800         * i386-fbsd-nat.c: Fix common/ includes.
3801         * guile/scm-type.c: Fix common/ includes.
3802         * guile/guile.c: Fix common/ includes.
3803         * go32-nat.c: Fix common/ includes.
3804         * gnu-nat.c: Fix common/ includes.
3805         * gdbthread.h: Fix common/ includes.
3806         * gdbarch-selftests.c: Fix common/ includes.
3807         * gdb_usleep.c: Fix common/ includes.
3808         * gdb_select.h: Fix common/ includes.
3809         * gdb_bfd.c: Fix common/ includes.
3810         * gcore.c: Fix common/ includes.
3811         * fork-child.c: Fix common/ includes.
3812         * findvar.c: Fix common/ includes.
3813         * fbsd-nat.c: Fix common/ includes.
3814         * event-top.c: Fix common/ includes.
3815         * event-loop.c: Fix common/ includes.
3816         * dwarf2read.c: Fix common/ includes.
3817         * dwarf2loc.c: Fix common/ includes.
3818         * dwarf2-frame.c: Fix common/ includes.
3819         * dwarf-index-cache.c: Fix common/ includes.
3820         * dtrace-probe.c: Fix common/ includes.
3821         * disasm-selftests.c: Fix common/ includes.
3822         * defs.h: Fix common/ includes.
3823         * csky-tdep.c: Fix common/ includes.
3824         * cp-valprint.c: Fix common/ includes.
3825         * cp-support.h: Fix common/ includes.
3826         * cp-support.c: Fix common/ includes.
3827         * corelow.c: Fix common/ includes.
3828         * completer.h: Fix common/ includes.
3829         * completer.c: Fix common/ includes.
3830         * compile/compile.c: Fix common/ includes.
3831         * compile/compile-loc2c.c: Fix common/ includes.
3832         * compile/compile-cplus-types.c: Fix common/ includes.
3833         * compile/compile-cplus-symbols.c: Fix common/ includes.
3834         * command.h: Fix common/ includes.
3835         * cli/cli-dump.c: Fix common/ includes.
3836         * cli/cli-cmds.c: Fix common/ includes.
3837         * charset.c: Fix common/ includes.
3838         * build-id.c: Fix common/ includes.
3839         * btrace.h: Fix common/ includes.
3840         * btrace.c: Fix common/ includes.
3841         * breakpoint.h: Fix common/ includes.
3842         * breakpoint.c: Fix common/ includes.
3843         * ax.h: 
3844         (enum agent_op): Fix common/ includes.
3845         * ax-general.c (struct aop_map): Fix common/ includes.
3846         * ax-gdb.c: Fix common/ includes.
3847         * auxv.c: Fix common/ includes.
3848         * auto-load.c: Fix common/ includes.
3849         * arm-tdep.c: Fix common/ includes.
3850         * arch/riscv.c: Fix common/ includes.
3851         * arch/ppc-linux-common.c: Fix common/ includes.
3852         * arch/i386.c: Fix common/ includes.
3853         * arch/arm.c: Fix common/ includes.
3854         * arch/arm-linux.c: Fix common/ includes.
3855         * arch/arm-get-next-pcs.c: Fix common/ includes.
3856         * arch/amd64.c: Fix common/ includes.
3857         * arch/aarch64.c: Fix common/ includes.
3858         * arch/aarch64-insn.c: Fix common/ includes.
3859         * arch-utils.c: Fix common/ includes.
3860         * amd64-windows-tdep.c: Fix common/ includes.
3861         * amd64-tdep.c: Fix common/ includes.
3862         * amd64-sol2-tdep.c: Fix common/ includes.
3863         * amd64-obsd-tdep.c: Fix common/ includes.
3864         * amd64-nbsd-tdep.c: Fix common/ includes.
3865         * amd64-linux-tdep.c: Fix common/ includes.
3866         * amd64-linux-nat.c: Fix common/ includes.
3867         * amd64-fbsd-tdep.c: Fix common/ includes.
3868         * amd64-fbsd-nat.c: Fix common/ includes.
3869         * amd64-dicos-tdep.c: Fix common/ includes.
3870         * amd64-darwin-tdep.c: Fix common/ includes.
3871         * agent.c: Fix common/ includes.
3872         * ada-lang.h: Fix common/ includes.
3873         * ada-lang.c: Fix common/ includes.
3874         * aarch64-tdep.c: Fix common/ includes.
3875
3876 2019-01-25  Tom Tromey  <tom@tromey.com>
3877
3878         * common/create-version.sh: Use common/version.h.
3879
3880 2019-01-24  Pedro Alves  <palves@redhat.com>
3881
3882         * infrun.c (signal_stop, signal_print, signal_program)
3883         (signal_catch, signal_pass): Now arrays instead of pointers.
3884         (update_signals_program_target, do_target_resume)
3885         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3886         * linux-nat.c (linux_nat_target::pass_signals)
3887         (linux_nat_target::create_inferior, linux_nat_target::attach):
3888         Adjust.
3889         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3890         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3891         * procfs.c (procfs_target::pass_signals): Adjust.
3892         * record-full.c (record_full_target::resume): Adjust.
3893         * remote.c (remote_target::pass_signals)
3894         (remote_target::program_signals): Adjust.
3895         * target-debug.h (target_debug_print_signals): Now takes a
3896         gdb::array_view as parameter.  Adjust.
3897         * target.h (target_ops) <pass_signals, program_signals>: Replace
3898         pointer and length parameters with gdb::array_view.
3899         (target_pass_signals, target_program_signals): Likewise.
3900         * target-delegates.c: Regenerate.
3901
3902 2019-01-24  Pedro Alves  <palves@redhat.com>
3903
3904         * common/forward-scope-exit.h
3905         (forward_scope_exit::forward_scope_exit): Pass arguments to
3906         m_bind_function directly, instead of creating a std::bind and
3907         copying that.
3908
3909 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3910
3911         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3912         for static members.
3913         (pass_in_v_vfp_candidate): Likewise.
3914
3915 2019-01-23  Tom Tromey  <tom@tromey.com>
3916             Pedro Alves  <palves@redhat.com>
3917
3918         * regcache.c (class regcache_invalidator): Remove.
3919         (regcache::raw_write): Use make_scope_exit.
3920
3921 2019-01-23  Tom Tromey  <tom@tromey.com>
3922
3923         * ui-out.h (class ui_out_emit_type): Update comment.
3924
3925 2019-01-23  Tom Tromey  <tom@tromey.com>
3926
3927         * infrun.c (fetch_inferior_event): Update comment.
3928
3929 2019-01-23  Tom Tromey  <tom@tromey.com>
3930             Pedro Alves  <palves@redhat.com>
3931
3932         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3933         parameter.
3934         (fetch_inferior_event): Use SCOPE_EXIT.
3935
3936
3937 2019-01-23  Tom Tromey  <tom@tromey.com>
3938             Pedro Alves  <palves@redhat.com>
3939
3940         * infrun.c (disable_thread_events): Delete.
3941         (stop_all_threads): Use SCOPE_EXIT.
3942
3943 2019-01-23  Tom Tromey  <tom@tromey.com>
3944             Pedro Alves  <palves@redhat.com>
3945
3946         * symfile.c: Include forward-scope-exit.h.
3947         (clear_symtab_users_cleanup): Replace forward declaration with
3948         a FORWARD_SCOPE_EXIT.
3949         (syms_from_objfile_1): Use the forward_scope_exit and
3950         gdb::optional instead of cleanup_function.
3951         (reread_symbols): Use the forward_scope_exit instead of
3952         cleanup_function.
3953         (clear_symtab_users_cleanup): Remove function.
3954
3955 2019-01-23  Tom Tromey  <tom@tromey.com>
3956             Pedro Alves  <palves@redhat.com>
3957
3958         * linux-nat.c: Include scope-exit.h.
3959         (cleanup_target_stop): Remove.
3960         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3961         SCOPE_EXIT.
3962
3963 2019-01-23  Tom Tromey  <tom@tromey.com>
3964             Pedro Alves  <palves@redhat.com>
3965
3966         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3967         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3968
3969 2019-01-23  Tom Tromey  <tom@tromey.com>
3970             Andrew Burgess  <andrew.burgess@embecosm.com>
3971             Pedro Alves  <palves@redhat.com>
3972
3973         * infrun.c (fetch_inferior_event): Use scope_exit.
3974         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3975         * top.c (execute_command): Use scope_exit.
3976         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3977         * utils.c (do_bpstat_clear_actions_cleanup)
3978         (make_bpstat_clear_actions_cleanup): Remove.
3979
3980 2019-01-23  Tom Tromey  <tom@tromey.com>
3981             Pedro Alves  <palves@redhat.com>
3982
3983         * infrun.c: Include "common/scope-exit.h"
3984         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3985         (wait_for_inferior): Use SCOPE_EXIT.
3986         (fetch_inferior_event): Use scope_exit.
3987
3988 2019-01-23  Tom Tromey  <tom@tromey.com>
3989             Pedro Alves  <palves@redhat.com>
3990
3991         * breakpoint.c (create_breakpoint): Remove cleanup.
3992
3993 2019-01-23  Tom Tromey  <tom@tromey.com>
3994             Andrew Burgess  <andrew.burgess@embecosm.com>
3995             Pedro Alves  <palves@redhat.com>
3996
3997 2019-01-23  Pedro Alves  <palves@redhat.com>
3998
3999         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4000
4001 2019-01-23  Pedro Alves  <palves@redhat.com>
4002             Andrew Burgess  <andrew.burgess@embecosm.com>
4003
4004         * gdbthread.h: Include "common/forward-scope-exit.h".
4005         (scoped_finish_thread_state): Redefine custom class in terms of
4006         forward_scope_exit.
4007
4008 2019-01-23  Pedro Alves  <palves@redhat.com>
4009             Andrew Burgess  <andrew.burgess@embecosm.com>
4010
4011         * common/forward-scope-exit.h: New file.
4012
4013 2019-01-23  Pedro Alves  <palves@redhat.com>
4014             Andrew Burgess  <andrew.burgess@embecosm.com>
4015             Tom Tromey  <tom@tromey.com>
4016
4017         * common/scope-exit.h: New file.
4018
4019 2019-01-23  Pedro Alves  <palves@redhat.com>
4020
4021         * common/preprocessor.h (ESC): Rename to ...
4022         (ESC_PARENS): ... this.
4023         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4024         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4025
4026 2019-01-23  Tom Tromey  <tom@tromey.com>
4027
4028         * language.h (class scoped_switch_to_sym_language_if_auto):
4029         Initialize m_lang in both cases.
4030
4031 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4032
4033         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4034         with XCNEW.
4035
4036 2019-01-22  Tom Tromey  <tom@tromey.com>
4037
4038         * corelow.c: Do not include sys/file.h.
4039
4040 2019-01-22  Tom Tromey  <tom@tromey.com>
4041
4042         * tui/tui-wingeneral.h: Include gdb_curses.h.
4043
4044 2019-01-22  Tom Tromey  <tom@tromey.com>
4045
4046         * source-cache.h (class source_cache) <get_source_lines,
4047         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4048
4049 2019-01-22  Tom Tromey  <tom@tromey.com>
4050
4051         * remote-fileio.h (struct remote_target): Declare.
4052
4053 2019-01-22  Tom Tromey  <tom@tromey.com>
4054
4055         * python/py-arch.c: Do not include py-ref.h.
4056         * python/py-bpevent.c: Do not include py-ref.h.
4057         * python/py-cmd.c: Do not include py-ref.h.
4058         * python/py-continueevent.c: Do not include py-ref.h.
4059         * python/py-event.h: Do not include py-ref.h.
4060         * python/py-evtregistry.c: Do not include py-ref.h.
4061         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4062         * python/py-frame.c: Do not include py-ref.h.
4063         * python/py-framefilter.c: Do not include py-ref.h.
4064         * python/py-function.c: Do not include py-ref.h.
4065         * python/py-infevents.c: Do not include py-ref.h.
4066         * python/py-linetable.c: Do not include py-ref.h.
4067         * python/py-objfile.c: Do not include py-ref.h.
4068         * python/py-param.c: Do not include py-ref.h.
4069         * python/py-prettyprint.c: Do not include py-ref.h.
4070         * python/py-progspace.c: Do not include py-ref.h.
4071         * python/py-symbol.c: Do not include py-ref.h.
4072         * python/py-symtab.c: Do not include py-ref.h.
4073         * python/py-type.c: Do not include py-ref.h.
4074         * python/py-unwind.c: Do not include py-ref.h.
4075         * python/py-utils.c: Do not include py-ref.h.
4076         * python/py-value.c: Do not include py-ref.h.
4077         * python/py-varobj.c: Do not include py-ref.h.
4078         * python/py-xmethods.c: Do not include py-ref.h.
4079         * python/python.c: Do not include py-ref.h.
4080         * varobj.c: Do not include py-ref.h.
4081
4082 2019-01-22  Tom Tromey  <tom@tromey.com>
4083
4084         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4085         keyword for bcache.
4086
4087 2019-01-22  Tom Tromey  <tom@tromey.com>
4088
4089         * compile/compile-cplus-types.c: Remove a comment by #include.
4090
4091 2019-01-22  Tom Tromey  <tom@tromey.com>
4092
4093         * compile/gcc-c-plugin.h: Include compile-internal.h.
4094
4095 2019-01-22  Tom Tromey  <tom@tromey.com>
4096
4097         * stabsread.c (EXTERN): Do not define.
4098         (symnum, next_symbol_text_func, processing_gcc_compilation)
4099         (within_function, global_sym_chain, global_stabs)
4100         (previous_stab_code, this_object_header_files)
4101         (n_this_object_header_files)
4102         (n_allocated_this_object_header_files): Define.
4103         * stabsread.h (EXTERN): Never define.  Use "extern".
4104
4105 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4106
4107         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4108         history_value.
4109
4110 2019-01-21  Tom Tromey  <tom@tromey.com>
4111
4112         * ui-out.c: Fix includes.
4113         * tui/tui-source.c: Fix includes.
4114         * target.c: Fix includes.
4115         * remote.c: Fix includes.
4116         * regcache.c: Fix includes.
4117         * python/py-block.c: Fix includes.
4118         * printcmd.c: Fix includes.
4119         * or1k-tdep.c: Fix includes.
4120         * mi/mi-main.c: Fix includes.
4121         * m32r-tdep.c: Fix includes.
4122         * csky-tdep.c: Fix includes.
4123         * compile/compile-cplus-types.c: Fix includes.
4124         * cli/cli-interp.c: Fix includes.
4125
4126 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4127
4128         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4129         for padding.
4130
4131 2019-01-16  Tom Tromey  <tom@tromey.com>
4132
4133         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4134         earlier.
4135         (struct objfile) <msymbols_range>: Move from top level.
4136         <msymbols>: New method.
4137         (class objfile_msymbols): Remove.
4138         * symtab.c (default_collect_symbol_completion_matches_break_on):
4139         Update.
4140         * symmisc.c (dump_msymbols): Update.
4141         * stabsread.c (scan_file_globals): Update.
4142         * objc-lang.c (info_selectors_command, info_classes_command)
4143         (find_methods): Update.
4144         * minsyms.c (find_solib_trampoline_target): Update.
4145         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4146         * coffread.c (coff_symfile_read): Update.
4147         * ada-lang.c (ada_lookup_simple_minsym)
4148         (ada_collect_symbol_completion_matches): Update.
4149
4150 2019-01-16  Tom Tromey  <tom@tromey.com>
4151
4152         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4153         type.  Remove no-argument constructor.
4154         <iterator::operator++>: Simplify.
4155         <begin>: Update.
4156         <end>: Use minimal_symbol_count.
4157
4158 2019-01-16  Tom Tromey  <tom@tromey.com>
4159
4160         * objfiles.h (struct objfile) <psymtabs>: New method.
4161         (class objfile_psymtabs): Remove.
4162         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4163         typedef.
4164         <range>: New method.
4165         (require_partial_symbols): Change return type.
4166         * psymtab.c (require_partial_symbols)
4167         (psym_expand_symtabs_matching): Update.
4168         * mdebugread.c (parse_partial_symbols): Update.
4169         * dbxread.c (dbx_end_psymtab): Update.
4170
4171 2019-01-15  Tom Tromey  <tom@tromey.com>
4172
4173         * symtab.c (lookup_objfile_from_block)
4174         (lookup_symbol_in_objfile_symtabs)
4175         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4176         (find_line_symtab, info_sources_command)
4177         (default_collect_symbol_completion_matches_break_on)
4178         (make_source_files_completion_list): Update.
4179         * symmisc.c (print_objfile_statistics, dump_objfile)
4180         (maintenance_print_symbols, maintenance_info_symtabs)
4181         (maintenance_check_symtabs, maintenance_info_line_tables):
4182         Update.
4183         * source.c (select_source_symtab)
4184         (forget_cached_source_info_for_objfile): Update.
4185         * objfiles.h (class objfile_compunits): Remove.
4186         (struct objfile) <compunits_range>: New typedef.
4187         (compunits): New method.
4188         * objfiles.c (objfile_relocate1): Update.
4189         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4190         * maint.c (count_symtabs_and_blocks): Update.
4191         * linespec.c (iterate_over_all_matching_symtabs): Update.
4192         * cp-support.c (add_symbol_overload_list_qualified): Update.
4193         * coffread.c (coff_symtab_read): Update.
4194         * ada-lang.c (add_nonlocal_symbols)
4195         (ada_collect_symbol_completion_matches)
4196         (ada_add_global_exceptions): Update.
4197
4198 2019-01-15  Tom Tromey  <tom@tromey.com>
4199
4200         * progspace.h (program_space) <objfiles_safe_range>: New
4201         typedef.
4202         <objfiles_safe>: New method.
4203         * objfiles.h (class all_objfiles_safe): Remove.
4204         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4205         * jit.c (jit_inferior_exit_hook): Update.
4206
4207 2019-01-17  Tom Tromey  <tom@tromey.com>
4208
4209         * progspace.h (program_space) <objfiles_range>: New typedef.
4210         <objfiles>: New method.
4211         <objfiles_head>: Rename from objfiles.
4212         (object_files): Update.
4213         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4214         * guile/scm-pretty-print.c
4215         (ppscm_find_pretty_printer_from_objfiles): Update.
4216         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4217         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4218         Update.
4219         * python/py-progspace.c (pspy_get_objfiles): Update.
4220         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4221         Update.
4222         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4223         (objfpy_lookup_objfile_by_build_id): Update.
4224         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4225         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4226         Update.
4227         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4228         (expand_symtab_containing_pc, lookup_objfile_from_block)
4229         (lookup_static_symbol, basic_lookup_transparent_type)
4230         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4231         (find_line_symtab, info_sources_command)
4232         (default_collect_symbol_completion_matches_break_on)
4233         (make_source_files_completion_list, find_main_name): Update.
4234         * symmisc.c (print_symbol_bcache_statistics)
4235         (print_objfile_statistics, maintenance_print_symbols)
4236         (maintenance_print_msymbols, maintenance_print_objfiles)
4237         (maintenance_info_symtabs, maintenance_check_symtabs)
4238         (maintenance_expand_symtabs, maintenance_info_line_tables):
4239         Update.
4240         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4241         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4242         (map_overlay_command, unmap_overlay_command)
4243         (simple_overlay_update, expand_symtabs_matching)
4244         (map_symbol_filenames): Update.
4245         * symfile-debug.c (set_debug_symfile): Update.
4246         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4247         Update.
4248         * source.c (select_source_symtab, forget_cached_source_info):
4249         Update.
4250         * solib.c (solib_read_symbols): Update.
4251         * solib-spu.c (append_ocl_sos): Update.
4252         * psymtab.c (maintenance_print_psymbols)
4253         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4254         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4255         * printcmd.c (info_symbol_command): Update.
4256         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4257         Update.
4258         * objfiles.h (class all_objfiles): Remove.
4259         * objfiles.c (have_partial_symbols, have_full_symbols)
4260         (have_minimal_symbols, qsort_cmp, update_section_map)
4261         (shared_objfile_contains_address_p)
4262         (default_iterate_over_objfiles_in_search_order): Update.
4263         * objc-lang.c (info_selectors_command, info_classes_command)
4264         (find_methods): Update.
4265         * minsyms.c (find_solib_trampoline_target): Update.
4266         * maint.c (maintenance_info_sections)
4267         (maintenance_translate_address, count_symtabs_and_blocks):
4268         Update.
4269         * main.c (captured_main_1): Update.
4270         * linux-thread-db.c (try_thread_db_load_from_pdir)
4271         (has_libpthread): Update.
4272         * linespec.c (iterate_over_all_matching_symtabs)
4273         (search_minsyms_for_name): Update.
4274         * jit.c (jit_find_objf_with_entry_addr): Update.
4275         * hppa-tdep.c (find_unwind_entry)
4276         (hppa_lookup_stub_minimal_symbol): Update.
4277         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4278         Update.
4279         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4280         (elf_gnu_ifunc_resolve_by_got): Update.
4281         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4282         * dwarf-index-write.c (save_gdb_index_command): Update.
4283         * cp-support.c (add_symbol_overload_list_qualified): Update.
4284         * breakpoint.c (create_overlay_event_breakpoint)
4285         (create_longjmp_master_breakpoint)
4286         (create_std_terminate_master_breakpoint)
4287         (create_exception_master_breakpoint): Update.
4288         * blockframe.c (find_pc_partial_function): Update.
4289         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4290         (ada_collect_symbol_completion_matches)
4291         (ada_add_global_exceptions): Update.
4292
4293 2019-01-17  Tom Tromey  <tom@tromey.com>
4294
4295         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4296         declare VEC.
4297         (solib_target_parse_libraries): Change return type.
4298         (library_list_start_segment, library_list_start_section)
4299         (library_list_end_library, library_list_start_library); Update.
4300         (solib_target_free_library_list): Remove.
4301         (solib_target_parse_libraries): Remove cleanup.  Change return
4302         type.
4303         (solib_target_current_sos): Update.
4304
4305 2019-01-17  Tom Tromey  <tromey@bapiya>
4306
4307         * valprint.c: Replace "the the" with "the".
4308         * symtab.c: Replace "the the" with "the".
4309         * solib.c: Replace "the the" with "the".
4310         * solib-dsbt.c: Replace "the the" with "the".
4311         * linespec.c: Replace "the the" with "the".
4312         * dwarf2loc.h: Replace "the the" with "the".
4313         * amd64-windows-tdep.c: Replace "the the" with "the".
4314         * aarch64-tdep.c: Replace "the the" with "the".
4315
4316 2019-01-16  Keith Seitz  <keiths@redhat.com>
4317
4318         PR gdb/23773
4319         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4320         <builder>: Rename to ..
4321         <m_builder>: ... this and make private.
4322         (dwarf2_cu::get_builder): New method.  Change all users of
4323         `builder' to use this method.
4324         (dwarf2_start_symtab): Move to ...
4325         (dwarf2_cu::start_symtab): ... here.  Update all callers
4326         (setup_type_unit_groups): Move to ...
4327         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4328         callers.
4329         (dwarf2_cu::reset_builder): New method.
4330         (process_full_compunit, process_full_type_unit): Use
4331         dwarf2_cu::reset_builder.
4332         (follow_die_offset): Record the ancestor CU if it is different
4333         from the followed DIE's CU.
4334         (follow_die_sig_1): Likewise.
4335
4336 2019-01-15  Tom Tromey  <tom@tromey.com>
4337
4338         * remote.c (class remote_state) <buf>: Now a char_vector.
4339         <buf_size>: Remove.
4340         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4341         parameter.
4342         (remote_target::getpkt_or_notif_sane_1)
4343         (remote_target::getpkt_sane)
4344         (remote_target::getpkt_or_notif_sane): Likewise.
4345         (class remote_target) <putpkt>: New overload.
4346         (remote_target::read_frame): Change type of "buf_p".  Remove
4347         sizeof_p parameter.
4348         (packet_ok): New overload.
4349         (packet_check_result): New overload.
4350         Update all uses.
4351
4352 2019-01-14  Tom Tromey  <tom@tromey.com>
4353
4354         * remote-notif.c (handle_notification, remote_notif_ack)
4355         (remote_notif_parse): Make "buf" const.
4356         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4357         const.
4358         (remote_notif_parse, remote_notif_ack, handle_notification):
4359         Likewise.
4360         * remote.c (remote_notif_stop_parse): Make "buf" const.
4361         (remote_target::remote_parse_stop_reply): Make "buf" const.
4362         (remote_notif_stop_ack): Make "buf" const.
4363
4364 2019-01-14  Tom Tromey  <tom@tromey.com>
4365
4366         * remote.c (remote_console_output): Make parameter const.
4367
4368 2019-01-14  Tom Tromey  <tom@tromey.com>
4369
4370         * target-debug.h (target_debug_print_signals): Constify.
4371         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4372         * procfs.c (procfs_target::pass_signals): Update.
4373         * linux-nat.c (linux_nat_target::pass_signals): Update.
4374         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4375         * target-delegates.c: Rebuild.
4376         * remote.c (remote_target::program_signals): Update.
4377         (remote_target::pass_signals): Update.
4378         * target.c (target_pass_signals): Constify argument.
4379         (target_program_signals): Likewise.
4380         * target.h (struct target_ops) <pass_signals, program_signals>:
4381         Constify argument.
4382         (target_pass_signals, target_program_signals): Constify argument.
4383
4384 2019-01-14  Tom Tromey  <tom@tromey.com>
4385
4386         PR tui/28819:
4387         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4388
4389 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4390
4391         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4392         field.
4393         * rs6000-tdep.c: Include reggroups.h.
4394         (IS_V_ALIAS_PSEUDOREG): Define.
4395         (rs6000_register_name): Return names for the "vX" aliases.
4396         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4397         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4398         aliases.  Call default_register_reggroup_p for all other
4399         pseudo-registers.
4400         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4401         New functions.
4402         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4403         Handle "vX" aliases.
4404         (v_alias_pseudo_register_collect): New function.
4405         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4406         (rs6000_gdbarch_init): Initialize "vX" aliases as
4407         pseudo-registers.  Restore registration of
4408         rs6000_pseudo_register_reggroup_p with
4409         set_tdesc_pseudo_register_reggroup_p.
4410
4411 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4412
4413         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4414         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4415         set_gdbarch_num_pseudo_regs.
4416
4417 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4418
4419         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4420         Remove arg prefixname, add do_set and do_show.
4421         Add member functions set_list and show_list.
4422         * cli/cli-style.c (class cli_style_option): Update accordingly.
4423         (style_set_list): Move to file scope.
4424         (style_show_list): Likewise.
4425         (set_style): Call help_list.
4426         (show_style): Call cmd_show_list.
4427         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4428         Update to use the new macro.
4429
4430 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4431
4432         * ada-lang.c (_initialize_ada_language): Expand the help text
4433         for the "catch exception" command.
4434
4435 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4436
4437         * symtab.c (matching_obj_sections): Initialize obj,
4438         declare it closer to its usage.
4439
4440 2019-01-10  Tom Tromey  <tom@tromey.com>
4441
4442         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4443         (basic_inf_threads_range): Remove.
4444         (inf_threads_range, inf_non_exited_threads_range)
4445         (safe_inf_threads_range): Use next_adapter.
4446
4447 2019-01-10  Keith Seitz  <keiths@redhat.com>
4448
4449         PR gdb/23712
4450         PR symtab/23010
4451         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4452         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4453
4454 2019-01-10  Keith Seitz  <keiths@redhat.com>
4455
4456         PR gdb/23712
4457         PR symtab/23010
4458         * dictionary.c (pending_to_vector): Remove.
4459         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4460         Remove _1 suffix, replacing functions of the same name.  Update
4461         all callers.
4462         (dict_create_hashed, dict_create_hashed_expandable)
4463         (dict_create_linear, dict_create_linear_expandable, dict_free)
4464         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4465         Make functions static.
4466
4467 2019-01-10  Keith Seitz  <keiths@redhat.com>
4468
4469         PR gdb/23712
4470         PR symtab/23010
4471         * dictionary.h (struct dictionary): Replace declaration with
4472         multidictionary.
4473         (dict_create_hashed, dict_create_hashed_expandable)
4474         (dict_create_linear, dict_create_linear_expandable)
4475         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4476         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4477         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4478         taking multidictionary argument.
4479         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4480         * block.h (struct block) <dict>: Change to multidictionary
4481         and rename `multidict'.
4482         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4483         symmisc.c: Update all dictionary references to multidictionary.
4484
4485 2019-01-10  Keith Seitz  <keiths@redhat.com>
4486
4487         PR gdb/23712
4488         PR symtab/23010
4489         * dictionary.c: Include unordered_map.
4490         (pending_to_vector): New function.
4491         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4492         Rewrite the non-"_1" functions to take vector instead
4493         of linked list.
4494         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4495         "new" _1 versions of the same name.
4496         (multidictionary): Define.
4497         (std::hash<enum language): New definition.
4498         (collate_pending_symbols_by_language, mdict_create_hashed)
4499         (mdict_create_hashed_expandable, mdict_create_linear)
4500         (mdict_create_linear_expandable, mdict_free)
4501         (find_language_dictionary, create_new_language_dictionary)
4502         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4503         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4504         (mdict_size, mdict_empty): New functions.
4505         * dictionary.h (mdict_iterator): Define.
4506
4507 2019-01-10  Pedro Alves  <palves@redhat.com>
4508
4509         * breakpoint.c (read_uploaded_action)
4510         (create_tracepoint_from_upload): Adjust to use
4511         gdb::unique_xmalloc_ptr.
4512         * ctf.c (ctf_write_uploaded_tp):
4513         (SET_ARRAY_FIELD): Use emplace_back.
4514         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4515         * tracefile-tfile.c (tfile_write_uploaded_tp):
4516         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4517         gdb::unique_xmalloc_ptr.
4518         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4519         at_string, cond_string, cmd_strings>: Replace char pointers
4520         with gdb::unique_xmalloc_ptr.
4521
4522 2019-01-10  Pedro Alves  <palves@redhat.com>
4523
4524         * solib-target.c (library_list_start_library): Don't xstrdup name.
4525
4526 2019-01-10  Pedro Alves  <palves@redhat.com>
4527
4528         * mdebugread.c (parse_partial_symbols): Use
4529         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4530
4531 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4532
4533         * linux-fork.c (scoped_switch_fork_info)
4534         <~scoped_switch_fork_info>: Fix incorrect variable name.
4535
4536 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4537
4538         * linux-fork.c (scoped_switch_fork_info)
4539         <scoped_switch_fork_info>: Make explicit.
4540         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4541
4542 2019-01-10  Tom Tromey  <tom@tromey.com>
4543
4544         * objfiles.h (objfile::reset_psymtabs): Update.
4545         * objfiles.c (objfile::objfile): Update.
4546         * psymtab.h (psymtab_storage::obstack): Update.
4547         (psymtab_storage::m_obstack): Use gdb::optional.
4548         (class psymtab_storage): Update comment.  Remove objfile
4549         parameter.
4550         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4551
4552 2019-01-10  Tom Tromey  <tom@tromey.com>
4553
4554         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4555         <free_psymtabs>: Now private.
4556         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4557         (allocate_psymtab): Use new method.
4558
4559 2019-01-10  Tom Tromey  <tom@tromey.com>
4560
4561         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4562         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4563         * mdebugread.c (parse_partial_symbols): Use
4564         allocate_dependencies.
4565         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4566         allocate_dependencies.
4567         (process_psymtab_comp_unit_reader)
4568         (build_type_psymtab_dependencies): Likewise.
4569         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4570
4571 2019-01-10  Tom Tromey  <tom@tromey.com>
4572
4573         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4574         PSYMBOL_SET_LANGUAGE.
4575         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4576
4577 2019-01-10  Tom Tromey  <tom@tromey.com>
4578
4579         * psymtab.h (psymtab_storage::obstack): New method.
4580         <m_obstack>: Rename from obstack; now private.
4581         * psymtab.c (psymtab_storage): Update.
4582         * dwarf2read.c (create_addrmap_from_index)
4583         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4584         Update.
4585
4586 2019-01-10  Tom Tromey  <tom@tromey.com>
4587
4588         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4589         * objfiles.h (objfile::reset_psymtabs): New method.
4590
4591 2019-01-10  Tom Tromey  <tom@tromey.com>
4592
4593         * symmisc.c (print_symbol_bcache_statistics): Update.
4594         (print_objfile_statistics): Update.
4595         * symfile.c (reread_symbols): Update.
4596         * psymtab.h (class psymtab_storage): New.
4597         * psymtab.c (psymtab_storage): New constructor.
4598         (~psymtab_storage): New destructor.
4599         (require_partial_symbols): Update.
4600         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4601         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4602         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4603         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4604         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4605         (start_psymtab_common, end_psymtab_common)
4606         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4607         (allocate_psymtab): Update.
4608         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4609         Update.
4610         (dump_psymtab_addrmap, maintenance_print_psymbols)
4611         (maintenance_check_psymtabs): Update.
4612         (class objfile_psymtabs): Move to objfiles.h.
4613         * psympriv.h (discard_psymtab): Now inline.
4614         (psymtab_discarder::psymtab_discarder): Update.
4615         (psymtab_discarder::~psymtab_discarder): Update.
4616         (ALL_OBJFILE_PSYMTABS): Rewrite.
4617         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4618         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4619         Remove fields.
4620         <partial_symtabs>: New field.
4621         (class objfile_psymtabs): Move from psymtab.h.  Update.
4622         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4623         psymbol_cache.
4624         (objfile::~objfile): Don't destroy psymbol_cache.
4625         * mdebugread.c (parse_partial_symbols): Update.
4626         * dwarf2read.c (create_addrmap_from_index)
4627         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4628         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4629         (add_partial_subprogram, dwarf2_ranges_read): Update.
4630         * dwarf-index-write.c (write_address_map)
4631         (write_one_signatured_type, recursively_write_psymbols)
4632         (class debug_names, class debug_names, write_psymtabs_to_index):
4633         Update.
4634
4635 2019-01-10  Tom Tromey  <tom@tromey.com>
4636
4637         * symtab.h (SYMBOL_SET_NAMES): Update.
4638         (symbol_set_names): Update.
4639         (MSYMBOL_SET_NAMES): Update.
4640         * symtab.c (symbol_set_names): Change argument to be an
4641         objfile_per_bfd_storage.
4642         * psymtab.c (add_psymbol_to_bcache): Update.
4643         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4644
4645 2019-01-10  Tom Tromey  <tom@tromey.com>
4646
4647         * symtab.c (create_demangled_names_hash): Change argument to be an
4648         objfile_per_bfd_storage.
4649         (symbol_set_names): Update.
4650
4651 2019-01-10  Tom Tromey  <tom@tromey.com>
4652
4653         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4654         init_psymbol_list.
4655         * psymtab.c (init_psymbol_list): Do nothing if already called.
4656         * psympriv.h (init_psymbol_list): Add comment.
4657         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4658         init_psymbol_list.
4659         * dbxread.c (dbx_symfile_read): Unconditionally call
4660         init_psymbol_list.
4661
4662 2019-01-10  Tom Tromey  <tom@tromey.com>
4663
4664         * xcoffread.c (scan_xcoff_symtab): Update.
4665         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4666         "where".
4667         * mdebugread.c (parse_partial_symbols)
4668         (handle_psymbol_enumerators): Update.
4669         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4670         * dbxread.c (read_dbx_symtab): Update.
4671         * psympriv.h (psymbol_placement): New enum.
4672         (add_psymbol_to_list): Update.
4673
4674 2019-01-10  Tom Tromey  <tom@tromey.com>
4675
4676         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4677         static_psymbols parameters.
4678         (scan_xcoff_symtab): Update.
4679         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4680         static_psymbols parameters.
4681         * psympriv.h (start_psymtab_common): Update.
4682         * mdebugread.c (parse_partial_symbols): Update.
4683         * dwarf2read.c (create_partial_symtab): Update.
4684         * dbxread.c (read_dbx_symtab): Update.
4685         (start_psymtab): Remove global_psymbols and static_psymbols
4686         parameters.
4687
4688 2019-01-10  Tom Tromey  <tom@tromey.com>
4689
4690         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4691         * psymtab.c (allocate_psymtab): Add comment.
4692         * psympriv.h (allocate_psymtab): Add comment.
4693         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4694         initializations.
4695         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4696
4697 2019-01-10  Tom Tromey  <tom@tromey.com>
4698
4699         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4700         Don't declare.
4701         * mipsread.c: Include mdebugread.h.
4702         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4703         Declare.
4704         * elfread.c: Include mdebugread.h.
4705
4706 2019-01-09  Tom Tromey  <tom@tromey.com>
4707
4708         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4709         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4710         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4711         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4712         (psym_lookup_symbol, psym_find_last_source_symtab)
4713         (psym_forget_cached_source_info, psym_print_stats)
4714         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4715         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4716         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4717         (psym_find_compunit_symtab_by_address)
4718         (maintenance_print_psymbols, maintenance_info_psymtabs)
4719         (maintenance_check_psymtabs): Use ranged for.
4720         * psymtab.h (class objfile_psymtabs): New.
4721         (require_partial_symbols): Return objfile_psymtabs.
4722         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4723
4724 2019-01-09  Tom Tromey  <tom@tromey.com>
4725
4726         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4727         (find_pc_mapped_section, list_overlays_command)
4728         (map_overlay_command, unmap_overlay_command)
4729         (simple_overlay_update): Use all_objfiles.
4730         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4731         * printcmd.c (info_symbol_command): Use all_objfiles.
4732         * objfiles.h (ALL_OBJSECTIONS): Remove.
4733         * maint.c (maintenance_translate_address): Use all_objfiles.
4734         * gcore.c (gcore_create_callback): Use all_objfiles.
4735         (objfile_find_memory_regions): Likewise.
4736
4737 2019-01-09  Tom Tromey  <tom@tromey.com>
4738
4739         * symtab.c (find_line_symtab, info_sources_command)
4740         (make_source_files_completion_list): Use objfile_compunits.
4741         * source.c (select_source_symtab): Use objfile_compunits.
4742         * objfiles.h (struct objfile): Update comment.
4743         (ALL_OBJFILES): Remove.
4744         (ALL_FILETABS): Remove.
4745         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4746         objfile_compunits.
4747
4748 2019-01-09  Tom Tromey  <tom@tromey.com>
4749
4750         * symmisc.c (print_objfile_statistics, dump_objfile)
4751         (maintenance_print_symbols): Use compunit_filetabs.
4752         * source.c (forget_cached_source_info_for_objfile): Use
4753         compunit_filetabs.
4754         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4755         (ALL_FILETABS): Use compunit_filetabs.
4756         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4757         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4758
4759 2019-01-09  Tom Tromey  <tom@tromey.com>
4760
4761         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4762         (compunit_filetabs): New.
4763         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4764         compunit_filetabs.
4765         (info_sources_command, make_source_files_completion_list): Remove
4766         declaration.
4767         * symmisc.c (print_objfile_statistics, dump_objfile)
4768         (maintenance_print_symbols): Remove declaration.
4769         (maintenance_info_symtabs): Use compunit_filetabs.
4770         (maintenance_info_line_tables): Likewise.
4771         * source.c (select_source_symtab): Change local variable name.
4772         (forget_cached_source_info_for_objfile): Remove declaration.
4773         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4774         * objfiles.c (objfile_relocate1): Remove declaration.
4775         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4776         declaration.
4777         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4778         * coffread.c (coff_symtab_read): Remove declaration.
4779         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4780         compunit_filetabs.
4781
4782 2019-01-09  Tom Tromey  <tom@tromey.com>
4783
4784         * symtab.c (lookup_objfile_from_block)
4785         (find_pc_sect_compunit_symtab, search_symbols)
4786         (default_collect_symbol_completion_matches_break_on): Use
4787         objfile_compunits.
4788         * objfiles.h (ALL_COMPUNITS): Remove.
4789         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4790         * cp-support.c (add_symbol_overload_list_qualified): Use
4791         objfile_compunits.
4792         * ada-lang.c (ada_collect_symbol_completion_matches)
4793         (ada_add_global_exceptions): Use objfile_compunits.
4794
4795 2019-01-09  Tom Tromey  <tom@tromey.com>
4796
4797         * source.c (select_source_symtab)
4798         (forget_cached_source_info_for_objfile): Remove declaration.
4799         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4800         declaration.
4801         * maint.c (count_symtabs_and_blocks): Remove declaration.
4802         * cp-support.c (add_symbol_overload_list_qualified): Remove
4803         declaration.
4804         * coffread.c (coff_symtab_read): Remove declaration.
4805         * symtab.c (lookup_symbol_in_objfile_symtabs)
4806         (basic_lookup_transparent_type_1): Use objfile_compunits.
4807         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4808         (info_sources_command, search_symbols)
4809         (default_collect_symbol_completion_matches_break_on)
4810         (make_source_files_completion_list): Remove declaration.
4811         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4812         (ada_collect_symbol_completion_matches)
4813         (ada_add_global_exceptions): Remove declaration.
4814         * linespec.c (iterate_over_all_matching_symtabs): Use
4815         objfile_compunits.
4816         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4817         (class objfile_compunits): New.
4818         (ALL_COMPUNITS): Use objfile_compunits.
4819         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4820         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4821         objfile_compunits.
4822         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4823
4824 2019-01-09  Tom Tromey  <tom@tromey.com>
4825
4826         * symtab.c (search_symbols)
4827         (default_collect_symbol_completion_matches_break_on): Use
4828         objfile_msymbols.
4829         * ada-lang.c (ada_lookup_simple_minsym)
4830         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4831         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4832         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4833         objfile_msymbols.
4834         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4835         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4836         * objc-lang.c (find_methods): Use objfile_msymbols.
4837         (info_selectors_command, info_classes_command): Likewise.
4838         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4839         * objfiles.h (class objfile_msymbols): New.
4840         (ALL_OBJFILE_MSYMBOLS): Remove.
4841         (ALL_MSYMBOLS): Remove.
4842
4843 2019-01-09  Tom Tromey  <tom@tromey.com>
4844
4845         * common/next-iterator.h (next_adapter): Add Iterator template
4846         parameter.
4847         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4848         (class all_objfiles_safe): New.
4849         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4850         * objfiles.c (put_objfile_before): Update comment.
4851         (add_separate_debug_objfile): Likewise.
4852         (free_all_objfiles): Use all_objfiles_safe.
4853         (objfile_purge_solibs): Likewise.
4854
4855 2019-01-09  Tom Tromey  <tom@tromey.com>
4856
4857         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4858         (expand_symtab_containing_pc, lookup_static_symbol)
4859         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4860         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4861         all_objfiles.
4862         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4863         * breakpoint.c (create_overlay_event_breakpoint)
4864         (create_longjmp_master_breakpoint)
4865         (create_std_terminate_master_breakpoint)
4866         (create_exception_master_breakpoint): Use all_objfiles.
4867         * linux-thread-db.c (try_thread_db_load_from_pdir)
4868         (has_libpthread): Use all_objfiles.
4869         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4870         * linespec.c (iterate_over_all_matching_symtabs)
4871         (search_minsyms_for_name): Use all_objfiles.
4872         * maint.c (maintenance_info_sections): Use all_objfiles.
4873         * main.c (captured_main_1): Use all_objfiles.
4874         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4875         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4876         * guile/scm-pretty-print.c
4877         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4878         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4879         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4880         (maintenance_print_msymbols): Use all_objfiles.
4881         * source.c (select_source_symtab): Use all_objfiles.
4882         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4883         * symfile.c (remove_symbol_file_command)
4884         (expand_symtabs_matching, map_symbol_filenames): Use
4885         all_objfiles.
4886         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4887         all_objfiles.
4888         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4889         * objc-lang.c (find_methods): Use all_objfiles.
4890         * objfiles.c (have_partial_symbols, have_full_symbols)
4891         (have_minimal_symbols, qsort_cmp)
4892         (default_iterate_over_objfiles_in_search_order): Use
4893         all_objfiles.
4894         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4895         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4896         (maintenance_check_psymtabs): Use all_objfiles.
4897         (ALL_PSYMTABS): Remove.
4898         * compile/compile-object-run.c (do_module_cleanup): Use
4899         all_objfiles.
4900         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4901         * cp-support.c (add_symbol_overload_list_qualified): Use
4902         all_objfiles.
4903         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4904         Use all_objfiles.
4905         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4906         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4907         all_objfiles.
4908         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4909         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4910         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4911         Uses all_objfiles.
4912         * solib.c (solib_read_symbols): Use all_objfiles
4913
4914 2019-01-09  Tom Tromey  <tom@tromey.com>
4915
4916         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4917         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4918         all_objfiles.
4919         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4920         * symmisc.c (print_symbol_bcache_statistics)
4921         (print_objfile_statistics, maintenance_print_objfiles)
4922         (maintenance_info_symtabs, maintenance_check_symtabs)
4923         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4924         all_objfiles.
4925         * source.c (forget_cached_source_info): Use all_objfiles.
4926         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4927         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4928         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4929         * objfiles.c (update_section_map): Use all_objfiles.
4930         (shared_objfile_contains_address_p): Likewise.
4931         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4932         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4933
4934 2019-01-09  Tom Tromey  <tom@tromey.com>
4935
4936         * common/next-iterator.h: New file.
4937         * objfiles.h (class all_objfiles): New.
4938         (struct objfile_iterator): New.
4939
4940 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4941
4942         * NEWS: Move the description of the changed "frame", "select-frame",
4943          and "info frame" commands to the Changed commands section.
4944
4945 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4946
4947         * gdbtypes.c (check_stub_method_group): Remove handling of old
4948         mangling schemes.
4949         * linespec.c (find_methods): Likewise.
4950         * stabsread.c (read_member_functions): Likewise.
4951         * valops.c (search_struct_method): Likewise.
4952         (value_struct_elt_for_reference): Likewise.
4953         * NEWS: Mention this change.
4954
4955 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4958         print_source_lines.
4959         * source.c (print_source_lines_base): Update line number check.
4960         (print_source_lines): New function.
4961         (source_lines_range::source_lines_range): New function.
4962         * source.h (class source_lines_range): New class.
4963         (print_source_lines): New declaration.
4964
4965 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4966
4967         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4968
4969 2019-01-08  Tom Tromey  <tom@tromey.com>
4970             Simon Marchi  <simon.marchi@ericsson.com>
4971
4972         PR gdb/24060
4973         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4974         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4975         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4976         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4977         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4978         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4979
4980 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4981
4982         * source.c (select_source_symtab): Move header comment to
4983         declaration in source.h.
4984         (forget_cached_source_info_for_objfile): Likewise.
4985         (forget_cached_source_info): Likewise.
4986         (identify_source_line): Likewise.
4987         * source.h (identify_source_line): Move declaration from symtab.h
4988         and add comment from source.c
4989         (print_source_lines): Likewise.
4990         (forget_cached_source_info_for_objfile): Likewise.
4991         (forget_cached_source_info): Likewise.
4992         (select_source_symtab): Likewise.
4993         (enum print_source_lines_flag): Move definition from symtab.h.
4994         * symtab.h (identify_source_line): Move declaration to source.h.
4995         (print_source_lines): Likewise.
4996         (forget_cached_source_info_for_objfile): Likewise.
4997         (forget_cached_source_info): Likewise.
4998         (select_source_symtab): Likewise.
4999         (enum print_source_lines_flag): Move definition to source.h.
5000         * tui/tui-hooks.c: Add 'source.h' include.
5001
5002 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5003
5004         * source.c (print_source_lines_base): Handle requests to print
5005         reverse line number sequences, and guard against empty lines
5006         string.
5007
5008 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5009
5010         * source.c (print_source_lines_base): Fix skip of '\r' if next
5011         character is '\n'.
5012
5013 2019-01-06  Tom Tromey  <tom@tromey.com>
5014
5015         * c-exp.y (struct c_parse_state) <macro_original_text,
5016         expansion_obstack>: New member.
5017         (macro_original_text, expansion_obstack): Remove globals.
5018         (scan_macro_expansion, scanning_macro_expansion)
5019         (finished_macro_expansion): Update.
5020         (scan_macro_cleanup): Remove.
5021         (yylex, c_parse): Update.
5022
5023 2019-01-06  Tom Tromey  <tom@tromey.com>
5024
5025         * c-exp.y (struct c_parse_state) <strings>: New member.
5026         (operator_stoken): Update.
5027
5028 2019-01-06  Tom Tromey  <tom@tromey.com>
5029
5030         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5031         (union type_stack_elt) <typelist_val>: Now a pointer to
5032         std::vector.
5033         (type_stack_cleanup): Don't declare.
5034         (push_typelist): Update.
5035         * parse.c (pop_typelist): Return a std::vector.
5036         (push_typelist): Take a std::vector.
5037         (follow_types): Update.  Do not free args.
5038         (type_stack_cleanup): Remove.
5039         * c-exp.y (struct c_parse_state): New.
5040         (cpstate): New global.
5041         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5042         (nonempty_typelist): Update.
5043         (func_mod): Create a new vector.
5044         (c_parse): Create a c_parse_state.
5045         (check_parameter_typelist): Do not delete params.
5046         (function_method): Update.  Do not delete type_list.
5047
5048 2019-01-06  Tom Tromey  <tom@tromey.com>
5049
5050         PR gdb/28155:
5051         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5052         check_typedef.
5053         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5054         (print_return_value): Likewise.
5055
5056 2019-01-05  Tom Tromey  <tom@tromey.com>
5057
5058         * contrib/cleanup_check.py: Remove.
5059         * contrib/gcc-with-excheck: Remove.
5060         * contrib/exsummary.py: Remove.
5061         * contrib/excheck.py: Remove.
5062
5063 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5064
5065         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5066         NULL. Initialize tpprev to NULL instead of assigning it
5067         to NULL on the next statement.
5068         * windows-nat.c (windows_delete_thread): Remove check for
5069         main_thread_id before printing thread exit notifications.
5070         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5071         Remove thread ID check against main_thread_id.
5072         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5073         windows_delete_thread.
5074         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5075
5076 2019-01-04  Tom Tromey  <tom@tromey.com>
5077
5078         * compile/compile.c (_initialize_compile): Use upper case for
5079         metasyntactic variables.
5080         * symmisc.c (_initialize_symmisc): Use upper case for
5081         metasyntactic variables.
5082         * psymtab.c (_initialize_psymtab): Use upper case for
5083         metasyntactic variables.
5084         * demangle.c (demangle_command): Use upper case for metasyntactic
5085         variables.
5086         (_initialize_demangler): Likewise.
5087         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5088         variables.
5089
5090 2019-01-03  Tom Tromey  <tom@tromey.com>
5091
5092         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5093
5094 2019-01-03  Tom Tromey  <tom@tromey.com>
5095
5096         * python/py-symtab.c (salpy_str): Update.
5097         (struct salpy_sal_object) <symtab>: Now a PyObject.
5098         (salpy_dealloc): Update.
5099         (del_objfile_sal): Use gdbpy_ref.
5100
5101 2019-01-03  Tom Tromey  <tom@tromey.com>
5102
5103         * python/py-type.c (convert_field): Use new_reference.  Return
5104         gdbpy_ref.
5105         (make_fielditem): Return gdbpy_ref.
5106         (typy_fields): Update.
5107         (typy_getitem): Update.
5108         (field_name): Return gdbpy_ref.  Use new_reference.
5109         (typy_iterator_iternext): Update.
5110
5111 2019-01-03  Tom Tromey  <tom@tromey.com>
5112
5113         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5114
5115 2019-01-03  Tom Tromey  <tom@tromey.com>
5116
5117         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5118         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5119         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5120         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5121         (pspy_set_type_printers): Likewise.
5122         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5123         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5124         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5125         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5126         (objfpy_set_type_printers): Likewise.
5127
5128 2019-01-03  Tom Tromey  <tom@tromey.com>
5129
5130         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5131         (gdbpy_print_stack): Use gdbpy_err_fetch.
5132         * python/python-internal.h (class gdbpy_err_fetch): New class.
5133         (class gdbpy_enter) <m_error_type, m_error_value,
5134         m_error_traceback>: Remove.
5135         <m_error>: New member.
5136         (gdbpy_exception_to_string): Don't declare.
5137         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5138         * python/py-value.c (convert_value_from_python): Use
5139         gdbpy_err_fetch.
5140         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5141         gdbpy_exception_to_string.
5142         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5143         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5144         gdbpy_err_fetch.
5145
5146 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5147
5148         * linux-nat.c (delete_lwp_cleanup): Delete.
5149         (struct lwp_deleter): New struct.
5150         (lwp_info_up): New typedef.
5151         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5152         lwp_info_up.
5153
5154 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5155
5156         * linux-fork.c (class scoped_switch_fork_info): New class.
5157         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5158
5159 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5160
5161         * valops.c (find_overload_match): Remove use of null_cleanup, and
5162         calls to do_cleanups.
5163
5164 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         * compile/compile-cplus-types.c
5167         (compile_cplus_instance::decl_name): Handle changes to
5168         cp_func_name.
5169         * cp-support.c (cp_func_name): Update header comment, update
5170         return type.
5171         * cp-support.h (cp_func_name): Update return type in declaration.
5172         * valops.c (find_overload_match): Move temp_func local to top
5173         level of function and change its type.  Use temp_func to hold and
5174         delete temporary string obtained from cp_func_name.
5175
5176 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5177
5178         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5179         gdb::char_vector, remove cleanup, and update uses of `msg`.
5180
5181 2019-01-03  Jim Wilson  <jimw@sifive.com>
5182
5183         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5184
5185 2019-01-02  Tom Tromey  <tom@tromey.com>
5186
5187         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5188         (tdesc_parse_xml): Remove cleanups.
5189         * target-descriptions.h (make_cleanup_free_target_description):
5190         Don't declare.
5191         (target_desc_deleter): New struct.
5192         (target_desc_up): New typedef.
5193         * target-descriptions.c (target_desc_deleter::operator()): Rename
5194         from free_target_description.
5195         (make_cleanup_free_target_description): Remove.
5196
5197 2019-01-02  Tom Tromey  <tom@tromey.com>
5198
5199         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5200         constructor, destructor.
5201         (linespec_parser): Remove typedef.
5202         (~linespec_parser): Rename from linespec_parser_delete.
5203         (linespec_lex_to_end, linespec_complete_label)
5204         (linespec_complete): Update.
5205         (decode_line_full): Remove cleanups.
5206         (decode_line_1): Update.
5207
5208 2019-01-02  Tom Tromey  <tom@tromey.com>
5209
5210         * python/python-internal.h (inferior_to_inferior_object): Change
5211         return type.
5212         * python/py-exitedevent.c (create_exited_event_object): Update.
5213         * python/py-inferior.c (inferior_to_inferior_object): Return
5214         gdbpy_ref.
5215         (python_new_inferior, python_inferior_deleted)
5216         (thread_to_thread_object, delete_thread_object)
5217         (build_inferior_list, gdbpy_selected_inferior): Update.
5218         * python/py-infthread.c (create_thread_object): Update.  Also fail
5219         if inferior_to_inferior_object fails.
5220
5221 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5222
5223         * inferior.h (class inferior) <displaced_step_state>: New field.
5224         * infrun.h (struct displaced_step_state): Move here from
5225         infrun.c.  Initialize fields, add constructor.
5226         <inf>: Remove field.
5227         <reset>: New method.
5228         * infrun.c (struct displaced_step_inferior_state): Move to
5229         infrun.h.
5230         (displaced_step_inferior_states): Remove.
5231         (get_displaced_stepping_state): Adust.
5232         (displaced_step_in_progress_any_inferior): Adjust.
5233         (displaced_step_in_progress_thread): Adjust.
5234         (displaced_step_in_progress): Adjust.
5235         (add_displaced_stepping_state): Remove.
5236         (get_displaced_step_closure_by_addr): Adjust.
5237         (remove_displaced_stepping_state): Remove.
5238         (infrun_inferior_exit): Call displaced_step_state.reset.
5239         (use_displaced_stepping): Don't check for NULL.
5240         (displaced_step_prepare_throw): Call
5241         get_displaced_stepping_state.
5242         (displaced_step_fixup): Don't check for NULL.
5243         (prepare_for_detach): Don't check for NULL.
5244
5245 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5246
5247         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5248          in case of call that did not complete.
5249
5250 2019-01-02  Andrey Utkin  <autkin@undo.io>
5251
5252         * symfile.c (find_separate_debug_file): Fix search of debug files for
5253         remote debuggee.
5254
5255 2019-01-02  Tom Tromey  <tom@tromey.com>
5256
5257         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5258         indentation.
5259         * python/py-frame.c (frapy_older): Remove cast.
5260         (frapy_newer): Likewise.
5261         * python/py-breakpoint.c (local_setattro): Remove cast.
5262         * python/py-arch.c (archpy_name): Remove local variable.
5263         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5264
5265 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5266
5267         * unittests/basic_string_view/element_access/char/empty.cc:
5268         Fix year range in copyright header.
5269
5270 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5271
5272         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5273         Delete.
5274         <operator==>: Update with for removed field.
5275         <hash>: Likewise.
5276         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5277         <isa_features>: ...this.
5278         <abi_features>: New field.
5279         (riscv_isa_flen): Update comment.
5280         (riscv_abi_xlen): New declaration.
5281         (riscv_abi_flen): New declaration.
5282         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5283         isa_features.
5284         (riscv_abi_xlen): New function.
5285         (riscv_isa_flen): Update to get answer from isa_features.
5286         (riscv_abi_flen): New function.
5287         (riscv_has_fp_abi): Update to get answer from abi_features.
5288         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5289         xlen and flen.
5290         (riscv_call_info) <xlen, flen>: Update comment.
5291         (riscv_call_arg_struct): Remove invalid assertions
5292         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5293         is removed.
5294         (riscv_gdbarch_init): Gather isa features and abi features
5295         separately, ensure both match on the gdbarch when reusing an old
5296         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5297         a target with 64-bit float hardware.
5298
5299 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5300
5301         * source.c (search_command_helper): Stop reverse search
5302         when line 1 has been searched.
5303
5304 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5305
5306         * record-full.c (record_full_base_target::close): Rewrite
5307         record_full_core_buf_list free logic.
5308
5309 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5310
5311         * break-catch-syscall.c (print_one_catch_syscall): xfree
5312         the last text.
5313
5314 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5315
5316         * top.c (print_gdb_version): Update Copyright year in version
5317         message.
5318
5319 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5320
5321         Update copyright year range in all GDB files.
5322
5323 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5324
5325         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5326
5327 For older changes see ChangeLog-2018.
5328 \f
5329 Local Variables:
5330 mode: change-log
5331 left-margin: 8
5332 fill-column: 74
5333 version-control: never
5334 coding: utf-8
5335 End:
5336