ee958c3f6e939bcede915e900072c83e4a5c1770
[external/binutils.git] / gdb / ChangeLog
1 2019-06-10  Tom de Vries  <tdevries@suse.de>
2
3         PR symtab/24545
4         * symtab.c (struct demangled_name_entry): Add language field.
5         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6         static minimal symbol".  Set and use language field.
7
8 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9
10         PR gdb/24592
11         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
12         function.
13         (fill_gregset): Call amd64_linux_collect_native_gregset instead
14         of amd64_collect_native_gregset.
15         (amd64_linux_nat_target::store_registers): Likewise.
16
17 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
18
19         * version.in: Set GDB version number to 8.3.0.DATE-git.
20
21 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
22
23         GDB 8.3 released.
24
25 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
26
27         * version.in: Set GDB version number to 8.3.
28
29 2019-05-08  Tom Tromey  <tromey@adacore.com>
30
31         * utils.c (fputs_maybe_filtered): Reset style after paging, even
32         when no wrap column is set.
33
34 2019-05-04  Tom Tromey  <tom@tromey.com>
35
36         * psymtab.c (psymbol_name_matches, match_partial_symbol)
37         (lookup_partial_symbol, print_partial_symbols)
38         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
39         (psymbol_compare): Update.
40         (add_psymbol_to_bcache): Clear the entire psymbol.
41         (maintenance_check_psymtabs): Update.
42         * psympriv.h (struct partial_symbol): Don't derive from
43         general_symbol_info.
44         <obj_section, unrelocated_address, address,
45         set_unrelocated_address>: Update.
46         <ginfo>: New member.
47         * dwarf-index-write.c (write_psymbols, debug_names::insert)
48         (debug_names::write_psymbols): Update.
49
50 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
51
52         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
53         level, so that various Windows header files expose the necessary
54         declarations and definitions.
55
56         * symfile.c (find_separate_debug_file): Remove colon from the
57         drive spec of DOS/Windows file names of the target, so that the
58         file name produced from DEBUGDIR and the target's directory will
59         be valid on DOS/Windows systems.
60
61 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
62
63         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
64         Use current_event.dwThreadId instead of main_thread_id.
65
66 2019-04-30  Tom Tromey  <tromey@adacore.com>
67
68         PR c++/24470:
69         * dwarf2read.c (process_structure_scope): Handle case where type
70         has template parameters but no symbol was created.
71
72 2019-04-19  Sergei Trofimovich <siarheit@google.com>
73
74         * configure.ac: add --enable-source-highlight switch.
75         * configure: Regenerate.
76         * top.c (print_gdb_version): plumb --enable-source-highlight
77         status to "show configuration".
78
79 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
80
81         PR symtab/24423:
82         * source.c (print_source_lines_base): Advance "iter" when a
83         control character is seen.
84
85 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
86
87         * inferior.h (struct infcall_suspend_state_deleter):
88         Catch exception in destructor to avoid crash.
89
90 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
91
92         * utils.c (prompt_for_continue): Don't restore the styling at the
93         end, as applied_style has the wrong value.  This fixes styling in
94         long lists of file names that are interrupted by the "Continue?"
95         prompt.
96
97 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
98
99         * version.in: Set GDB version number to 8.2.91.DATE-git.
100
101 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
102
103         GDB 8.2.91 released.
104
105 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
106
107         * version.in: Set GDB version number to 8.2.91.
108
109 2019-03-20  Tom Tromey  <tromey@adacore.com>
110
111         PR gdb/24391
112         * infrun.c (handle_inferior_event): Rename from
113         handle_inferior_event_1.  Create a scoped_value_mark.
114         (handle_inferior_event): Remove.
115
116 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
117
118         * source-cache.c (source_cache::get_source_lines): Re-read
119         fullname after calling open_source_file.
120
121 2019-03-18  Pedro Alves  <palves@redhat.com>
122             Eli Zaretskii <eliz@gnu.org>
123
124         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
125         m_line and m_start_of_line.
126
127 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
128
129         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
130         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
131         it returns a newline.  This fixes a regression in TU mode, whereby
132         the next line is output on the same screen line as the user input.
133
134 2019-03-18  Pedro Alves  <palves@redhat.com>
135
136         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
137         New globals.
138         (apply_style): New, factored out from ...
139         (apply_ansi_escape): ... this.  Handle reverse video mode.
140         (tui_set_reverse_mode): New function.
141         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
142         * tui/tui-winsource.c (tui_show_source_line): Use
143         tui_set_reverse_mode instead of setting A_STANDOUT.
144         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
145         New setter methods.
146
147 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
148
149         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
150         Handle tabs.
151
152 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
153
154         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
155         tui_refill_source_window instead of tui_refresh_win, to update the
156         current execution line.  This fixes redisplay of the current line
157         when stepping through the code with "next" or "step".
158
159 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
160
161         * source-cache.c (source_cache::get_source_lines): Call
162         find_source_lines to initialize s->nlines.  This fixes vertical
163         scrolling of TUI source window when the DOWN arrow is pressed.
164
165 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
166
167         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
168         wclrtoeol in tui_show_source_line".  This reverts changes made in
169         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
170
171 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
172
173         * NEWS: Combine separate "New targets" sections for 8.3.
174
175 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
176
177         The MS-Windows port of ncurses fails to switch to a color pair if
178         one or both of the colors are the implicit default colors.  This
179         change records the default colors when TUI is initialized, and
180         then specifies them explicitly when a color pair uses the default
181         colors.  This allows color styling in TUI mode on MS-Windows.
182
183         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
184         ncurses_norm_attr.
185         (tui_initialize_io) [__MINGW32__]: Record the default terminal
186         colors in ncurses_norm_attr.
187         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
188         "none", replace it with the default color recorded in
189         ncurses_norm_attr.
190
191 2019-03-14  Tom Tromey  <tromey@adacore.com>
192
193         * source-cache.h (class source_cache) <get_source_lines>: Return
194         std::string.
195         * source-cache.c (source_cache::extract_lines): Handle case where
196         first_pos==npos.  Return std::string.
197         (source_cache::get_source_lines): Update.
198
199 2019-03-14  Tom Tromey  <tromey@adacore.com>
200
201         * NEWS: Add item for "style sources" commands.
202         * source-cache.c (source_cache::get_source_lines): Check
203         source_styling.
204         * cli/cli-style.c (source_styling): New global.
205         (_initialize_cli_style): Add "style sources" commands.
206         (show_style_sources): New function.
207         * cli/cli-style.h (source_styling): Declare.
208
209 2019-03-14  Pedro Alves  <palves@redhat.com>
210             Tom Tromey  <tromey@adacore.com>
211
212         * tui/tui-winsource.h (tui_refill_source_window): Declare.
213         * tui/tui-winsource.c (tui_refill_source_window): New function,
214         from...
215         (tui_horizontal_source_scroll): ... here.  Move some logic.
216         * cli/cli-style.c (set_style_enabled): Notify new observable.
217         * tui/tui-hooks.c (tui_redisplay_source): New function.
218         (tui_attach_detach_observers): Attach or detach
219         tui_redisplay_source.
220         * observable.h (source_styling_changed): New observable.
221         * observable.c: Define source_styling_changed observable.
222
223 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
224
225         PR/24325
226         * source-cache.c: #undef open and close, to avoid unresolved
227         externals during linking.
228
229 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
230
231         Support styling on native MS-Windows console
232
233         PR/24315
234         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
235         on MS-Windows if $TERM is not defined.
236
237         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
238
239         * posix-hdep.c (gdb_console_fputs):
240         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
241         functions.
242         * ui-file.h (gdb_console_fputs): Add prototype.
243
244         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
245         back to fputs only if the former returns zero.
246
247 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
248             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
249
250         PR gdb/8527
251         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
252         set_sigint_trap, clear_sigint_trap.
253
254 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
255
256         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
257         for-loop range, to avoid compiler warnings.
258
259         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
260         avoid compiler warnings about unused variables.
261
262 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
263
264         * NEWS: Mention end of support for native debugging on MS-Windows
265         before XP.
266
267 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
268
269         PR gdb/24292
270         * common/netstuff.c:
271         * gdbserver/gdbreplay.c
272         * gdbserver/remote-utils.c:
273         * ser-tcp.c:
274         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
275         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
276         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
277         'getaddrinfo' and 'freeaddrinfo' were not available before
278         Windows XP, and mingw.org's MinGW headers by default define
279         _WIN32_WINNT to 0x500.
280
281 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
282     
283         * NEWS: Note minimum Python version.
284
285 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
286
287         * version.in: Set GDB version number to 8.2.90.DATE-git.
288
289 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
290
291         GDB 8.2.90 released.
292
293 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
294
295         * version.in: Set GDB version number to 8.2.90.
296
297 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
298
299         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
300
301 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
302
303         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
304         * version.in: Bump version to 8.2.90.DATE-git.
305
306 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
307
308         * aix-thread.c (ptid_cmp): Remove unused variable.
309         (get_signaled_thread): Likewise.
310         (store_regs_user_thread): Likewise.
311         (store_regs_kernel_thread): Likewise.
312         (fetch_regs_kernel_thread): Remove shadowed variable.
313
314 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
315
316         * features/riscv/32bit-cpu.xml: Add register numbers.
317         * features/riscv/32bit-fpu.c: Regenerate.
318         * features/riscv/32bit-fpu.xml: Add register numbers.
319         * features/riscv/64bit-cpu.xml: Add register numbers.
320         * features/riscv/64bit-fpu.c: Regenerate.
321         * features/riscv/64bit-fpu.xml: Add register numbers.
322
323 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
324
325         * NEWS: Mention two argument form of gdb.Value constructor.
326         * python/py-value.c (convert_buffer_and_type_to_value): New
327         function.
328         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
329         Add support for handling an optional second argument.  Call
330         convert_buffer_and_type_to_value as appropriate.
331         * python/python-internal.h (Py_buffer_deleter): New struct.
332         (Py_buffer_up): New typedef.
333
334 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
335
336         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
337         instead of releasing ownership.
338
339 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
340
341         * dwarf2read.c (open_and_init_dwp_file): Call
342         elf_numsections instead of bfd_count_sections to initialize
343         dwp_file->num_sections.
344
345 2019-02-25  Tom Tromey  <tromey@adacore.com>
346
347         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
348
349 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
350
351         * gcore.in: Add '--readnever' option when invoking GDB.
352
353 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
354
355         * MAINTAINERS: Update my email address.
356
357 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
358
359         * build-id.c (build_id_to_debug_bfd_1): New function.
360         (build_id_to_debug_bfd): Look for separate debug file in
361         sysroot.
362
363 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
364
365         * gdbarch.sh: Update the copyright year range that is placed into
366         generated files.
367
368 2019-02-22  Keith Seitz  <keiths@redhat.com>
369
370         PR symtab/23853
371         * linespec.c (create_sals_line_offset): Search for the default
372         symtab's filename instead of its fullname.
373
374 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
375
376         * NEWS: Update style defaults.
377
378 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
379
380         * main.c (captured_main_1): Disable styling in batch mode.
381
382 2019-02-20  Tom Tromey  <tom@tromey.com>
383
384         * symtab.c (symtab_symbol_info): Fix typos.
385
386 2019-02-20  Tom Tromey  <tromey@adacore.com>
387
388         * findcmd.c (_initialize_mem_search): Use upper case for
389         metasyntactic variables.
390
391 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
392
393         * aarch64-tdep.c (aarch64_add_reggroups): New function.
394         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
395
396 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
397
398         * top.h (source_file_name): Change to std::string.
399         * top.c (source_file_name): Likewise.
400         (command_line_input): Adjust.
401         * cli/cli-script.c (script_from_file): Adjust.
402
403 2019-02-19  Tom Tromey  <tromey@adacore.com>
404
405         * ravenscar-thread.c
406         (ravenscar_thread_target::update_thread_list): Don't call
407         ada_build_task_list.
408         * ada-lang.h (ada_build_task_list): Don't declare.
409         * ada-tasks.c (struct ada_tasks_inferior_data)
410         <task_list_valid_p>: Now bool.
411         (read_known_tasks, ada_task_list_changed)
412         (ada_tasks_invalidate_inferior_data): Update.
413         (read_known_tasks_array): Return bool.
414         (read_known_tasks_list): Likewise.
415         (read_known_tasks): Return void.
416         (ada_build_task_list): Now static.
417
418 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
419
420         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
421         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
422
423 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
424
425         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
426         variant for ada_tasks_pspace_data_handle and
427         ada_tasks_inferior_data_handle.
428         (ada_tasks_pspace_data_cleanup): New function.
429         (ada_tasks_inferior_data_cleanup): New function.
430
431 2019-02-17  Tom Tromey  <tom@tromey.com>
432
433         * macrotab.h (macro_source_fullname): Return a std::string.
434         * macrotab.c (macro_include, check_for_redefinition)
435         (macro_undef, macro_lookup_definition, foreach_macro)
436         (foreach_macro_in_scope): Update.
437         (macro_source_fullname): Return a std::string.
438         * macrocmd.c (show_pp_source_pos): Update.
439
440 2019-02-17  Tom Tromey  <tom@tromey.com>
441
442         * macrocmd.c (show_pp_source_pos): Style the file names.
443
444 2019-02-17  Tom Tromey  <tom@tromey.com>
445
446         PR tui/24197:
447         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
448
449 2019-02-17  Tom Tromey  <tom@tromey.com>
450
451         * ada-lang.c (user_select_syms): Use filtered printing.
452         * utils.c (wrap_style): New global.
453         (desired_style): Remove.
454         (emit_style_escape): Add stream parameter.
455         (set_output_style, reset_terminal_style, prompt_for_continue):
456         Update.
457         (flush_wrap_buffer): Only flush gdb_stdout.
458         (wrap_here): Set wrap_style.
459         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
460         treat escape sequences as a character.  Change when wrap buffer is
461         flushed.
462         (fputs_styled): Do not set the output style when the default is
463         requested.
464         * ui-style.h (struct ui_file_style) <is_default>: New method.
465         * source.c (print_source_lines_base): Emit escape sequences in one
466         piece.
467
468 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
469
470         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
471         integers and enumeration types.
472
473 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
474
475         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
476         instead of lookup_symbol_in_language
477         (do_exact_match): New function.
478         (ada_get_symbol_name_matcher): Return do_exact_match when
479         doing a verbatim match.
480
481 2019-02-15  Tom Tromey  <tromey@adacore.com>
482
483         * ravenscar-thread.c (ravenscar_thread_target::resume)
484         (ravenscar_thread_target::wait): Special case wildcard requests.
485
486 2019-02-15  Tom Tromey  <tromey@adacore.com>
487
488         * ravenscar-thread.c (base_ptid): Remove.
489         (struct ravenscar_thread_target) <close>: New method.
490         <m_base_ptid>: New member.
491         <update_inferior_ptid, active_task, task_is_currently_active,
492         runtime_initialized>: Declare methods.
493         <ravenscar_thread_target>: Add constructor.
494         (ravenscar_thread_target::task_is_currently_active)
495         (ravenscar_thread_target::update_inferior_ptid)
496         (ravenscar_runtime_initialized): Rename.  Now methods.
497         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
498         (ravenscar_thread_target::update_thread_list): Update.
499         (ravenscar_thread_target::active_task): Now method.
500         (ravenscar_thread_target::store_registers)
501         (ravenscar_thread_target::prepare_to_store)
502         (ravenscar_thread_target::prepare_to_store)
503         (ravenscar_thread_target::mourn_inferior): Update.
504         (ravenscar_inferior_created): Use "new" to create target.
505         (ravenscar_thread_target::get_ada_task_ptid): Update.
506         (_initialize_ravenscar): Don't initialize base_ptid.
507         (ravenscar_ops): Remove global.
508
509 2019-02-15  Tom Tromey  <tromey@adacore.com>
510
511         * target.h (push_target): Declare new overload.
512         * target.c (push_target): New overload, taking an rvalue reference.
513         * remote.c (remote_target::open_1): Use push_target overload.
514         * corelow.c (core_target_open): Use push_target overload.
515
516 2019-02-15  Tom Tromey  <tromey@adacore.com>
517
518         * ravenscar-thread.c (is_ravenscar_task)
519         (ravenscar_task_is_currently_active): Return bool.
520         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
521         (_initialize_ravenscar): Remove "(void)".
522         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
523         Return bool.
524
525 2019-02-15  Tom Tromey  <tromey@adacore.com>
526
527         * ravenscar-thread.c (ravenscar_runtime_initializer)
528         (has_ravenscar_runtime, get_running_thread_id)
529         (ravenscar_thread_target::resume): Fix indentation.
530
531 2019-02-15  Tom Tromey  <tromey@adacore.com>
532
533         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
534         from ravenscar_arch_ops.
535         (sparc_ravenscar_ops::fetch_registers)
536         (sparc_ravenscar_ops::store_registers): Now methods.
537         (sparc_ravenscar_prepare_to_store): Remove.
538         (sparc_ravenscar_ops): Redefine.
539         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
540         methods and destructor.  Remove members.
541         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
542         (ravenscar_thread_target::store_registers)
543         (ravenscar_thread_target::prepare_to_store): Update.
544         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
545         Remove.
546         (struct ppc_ravenscar_powerpc_ops): Derive from
547         ravenscar_arch_ops.
548         (ppc_ravenscar_powerpc_ops::fetch_registers)
549         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
550         (ppc_ravenscar_powerpc_ops): Redefine.
551         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
552         (ppc_ravenscar_e500_ops::fetch_registers)
553         (ppc_ravenscar_e500_ops::store_registers): Now methods.
554         (ppc_ravenscar_e500_ops): Redefine.
555         * aarch64-ravenscar-thread.c
556         (aarch64_ravenscar_generic_prepare_to_store): Remove.
557         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
558         (aarch64_ravenscar_fetch_registers)
559         (aarch64_ravenscar_store_registers): Now methods.
560         (aarch64_ravenscar_ops): Redefine.
561
562 2019-02-15  Tom Tromey  <tromey@adacore.com>
563
564         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
565         (ravenscar_thread_target::stopped_by_hw_breakpoint)
566         (ravenscar_thread_target::stopped_by_watchpoint)
567         (ravenscar_thread_target::stopped_data_address)
568         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
569
570 2019-02-15  Tom Tromey  <tromey@adacore.com>
571
572         * ravenscar-thread.c: Fix some typos.
573
574 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
575             Tom Tromey  <tromey@adacore.com>
576
577         * ada-lang.c (ada_exception_sal): Change addr_string to a
578         std::string.
579         (create_ada_exception_catchpoint): Update.
580
581 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
582             Tom Tromey  <tromey@adacore.com>
583
584         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
585         (bp_location_ops): Remove.
586         (base_breakpoint_allocate_location): Update.
587         (free_bp_location): Update.
588         * ada-lang.c (class ada_catchpoint_location)
589         <ada_catchpoint_location>: Remove ops parameter.
590         (ada_catchpoint_location_dtor): Remove.
591         (ada_catchpoint_location_ops): Remove.
592         (allocate_location_exception): Update.
593         * breakpoint.h (struct bp_location_ops): Remove.
594         (class bp_location) <bp_location>: Remove bp_location_ops
595         parameter.
596         <~bp_location>: Add destructor.
597         <ops>: Remove.
598
599 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
600             Pedro Alves  <palves@redhat.com>
601
602         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
603         'PATH_MAX'.
604
605 2019-02-14  David Michael  <fedora.dm0@gmail.com>
606             Samuel Thibault  <samuel.thibault@gnu.org>
607             Thomas Schwinge  <thomas@codesourcery.com>
608
609         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
610         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
611
612 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
613
614         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
615         (check_empty): Use "const char *".
616
617         * gnu-nat.c (gnu_nat_target::detach): Instead of
618         'detach_inferior (pid)' call
619         'detach_inferior (find_inferior_pid (pid))'.
620
621         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
622         'nat/fork-inferior.o'.
623         * gnu-nat.c: #include "nat/fork-inferior.h".
624
625         * gnu-nat.c (gnu_nat_target::detach): Instead of
626         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
627         * gnu-nat.h: #include "inf-child.h".
628         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
629         'i386_gnu_nat_target::fetch_registers'.
630         (gnu_store_registers): Rename/move to
631         'i386_gnu_nat_target::store_registers'.
632
633         * config/i386/nm-i386gnu.h: Don't "#include" any files.
634         * gnu-nat.h (mach_thread_info): New function.
635         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
636
637         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
638
639 2019-02-14  Frederic Konrad  <konrad@adacore.com>
640
641         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
642
643 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
644
645         * windows-nat.c (windows_add_thread): Add new parameter
646         "main_thread_p" with default value set to false.  Update
647         function documentation as well as all callers.
648         (windows_delete_thread): Likewise.
649         (fake_create_process): Update call to windows_add_thread.
650         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
651         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
652         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
653         call to windows_delete_thread.
654
655 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
656
657         * MAINTAINERS: Add Andrew Burgess as global maintainer.
658
659 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
660
661         * symfile.c (find_separate_debug_file): Use canonical path of
662         sysroot with child_path instead of gdb_sysroot if it is valid.
663
664 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
665
666         * symfile.c (find_separate_debug_file): Use child_path to
667         determine if an object file is under a sysroot.
668
669 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
670
671         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
672         unittests/child-path-selftests.c.
673         * common/pathstuff.c (child_path): New function.
674         * common/pathstuff.h (child_path): New prototype.
675         * unittests/child-path-selftests.c: New file.
676
677 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
678
679         * symfile.c (find_separate_debug_file): Look for separate debug
680         files in debug directories under the sysroot.
681
682 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
683
684         * symtab.h (struct minimal_symbol data_p): New const method.
685         (struct minimal_symbol text_p): Likewise.
686         * symtab.c (output_source_filename): Use file name style
687         to print file name.
688         (print_symbol_info): Likewise.
689         (print_msymbol_info): Use address style to print addresses.
690         Use function name style to print executable text symbols.
691         (expand_symtab_containing_pc): Use data_p.
692         (find_pc_sect_compunit_symtab): Likewise.
693
694 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
695
696         * breakpoint.c (describe_other_breakpoints): Use address style
697         to print addresses.
698         (say_where): Likewise.
699
700 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
701
702         * ada-typeprint.c (print_func_type): Print function name
703         style to print function name.
704         * c-typeprint.c (c_print_type_1): Likewise.
705
706 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
707
708         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
709         for execve.
710
711 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
712
713         * c-exp.y (direct_abs_decl): Use emplace_back to record the
714         type_stack.
715
716 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
717
718         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
719         TYPE_CODE_REF types.
720
721 2019-02-08  Jim Wilson  <jimw@sifive.com>
722
723         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
724         (riscv_linux_fregset): New.
725         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
726
727 2019-02-07  Tom Tromey  <tom@tromey.com>
728
729         * thread.c (thread_cancel_execution_command): Update.
730         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
731         methods.
732         (struct thread_fsm_ops): Remove.
733         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
734         (thread_fsm_should_stop, thread_fsm_return_value)
735         (thread_fsm_set_finished, thread_fsm_finished_p)
736         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
737         Don't declare.
738         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
739         * infrun.c (clear_proceed_status_thread)
740         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
741         (print_stop_event): Update.
742         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
743         Add constructor.
744         (step_command_fsm_ops): Remove.
745         (new_step_command_fsm): Remove.
746         (step_1): Update.
747         (step_command_fsm::should_stop): Rename from
748         step_command_fsm_should_stop.
749         (step_command_fsm::clean_up): Rename from
750         step_command_fsm_clean_up.
751         (step_command_fsm::do_async_reply_reason): Rename from
752         step_command_fsm_async_reply_reason.
753         (struct until_next_fsm): Inherit from thread_fsm.  Add
754         constructor.
755         (until_next_fsm_ops): Remove.
756         (new_until_next_fsm): Remove.
757         (until_next_fsm::should_stop): Rename from
758         until_next_fsm_should_stop.
759         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
760         (until_next_fsm::do_async_reply_reason): Rename from
761         until_next_fsm_async_reply_reason.
762         (struct finish_command_fsm): Inherit from thread_fsm.  Add
763         constructor.  Change type of breakpoint.
764         (finish_command_fsm_ops): Remove.
765         (new_finish_command_fsm): Remove.
766         (finish_command_fsm::should_stop): Rename from
767         finish_command_fsm_should_stop.
768         (finish_command_fsm::clean_up): Rename from
769         finish_command_fsm_clean_up.
770         (finish_command_fsm::return_value): Rename from
771         finish_command_fsm_return_value.
772         (finish_command_fsm::do_async_reply_reason): Rename from
773         finish_command_fsm_async_reply_reason.
774         (finish_command): Update.
775         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
776         Add constructor.
777         (call_thread_fsm_ops): Remove.
778         (call_thread_fsm::call_thread_fsm): Rename from
779         new_call_thread_fsm.
780         (call_thread_fsm::should_stop): Rename from
781         call_thread_fsm_should_stop.
782         (call_thread_fsm::should_notify_stop): Rename from
783         call_thread_fsm_should_notify_stop.
784         (run_inferior_call, call_function_by_hand_dummy): Update.
785         * cli/cli-interp.c (should_print_stop_to_console): Update.
786         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
787         Add constructor.  Change type of location_breakpoint,
788         caller_breakpoint.
789         (until_break_fsm_ops): Remove.
790         (new_until_break_fsm): Remove.
791         (until_break_fsm::should_stop): Rename from
792         until_break_fsm_should_stop.
793         (until_break_fsm::clean_up): Rename from
794         until_break_fsm_clean_up.
795         (until_break_fsm::do_async_reply_reason): Rename from
796         until_break_fsm_async_reply_reason.
797         (until_break_command): Update.
798         * thread-fsm.c: Remove.
799         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
800
801 2019-02-07  Tom Tromey  <tom@tromey.com>
802
803         * yy-remap.h: Add include guard.
804         * xtensa-tdep.h: Add include guard.
805         * xcoffread.h: Rename include guard.
806         * varobj-iter.h: Add include guard.
807         * tui/tui.h: Rename include guard.
808         * tui/tui-winsource.h: Rename include guard.
809         * tui/tui-wingeneral.h: Rename include guard.
810         * tui/tui-windata.h: Rename include guard.
811         * tui/tui-win.h: Rename include guard.
812         * tui/tui-stack.h: Rename include guard.
813         * tui/tui-source.h: Rename include guard.
814         * tui/tui-regs.h: Rename include guard.
815         * tui/tui-out.h: Rename include guard.
816         * tui/tui-layout.h: Rename include guard.
817         * tui/tui-io.h: Rename include guard.
818         * tui/tui-hooks.h: Rename include guard.
819         * tui/tui-file.h: Rename include guard.
820         * tui/tui-disasm.h: Rename include guard.
821         * tui/tui-data.h: Rename include guard.
822         * tui/tui-command.h: Rename include guard.
823         * tic6x-tdep.h: Add include guard.
824         * target/waitstatus.h: Rename include guard.
825         * target/wait.h: Rename include guard.
826         * target/target.h: Rename include guard.
827         * target/resume.h: Rename include guard.
828         * target-float.h: Rename include guard.
829         * stabsread.h: Add include guard.
830         * rs6000-tdep.h: Add include guard.
831         * riscv-fbsd-tdep.h: Add include guard.
832         * regformats/regdef.h: Rename include guard.
833         * record.h: Rename include guard.
834         * python/python.h: Rename include guard.
835         * python/python-internal.h: Rename include guard.
836         * python/py-stopevent.h: Rename include guard.
837         * python/py-ref.h: Rename include guard.
838         * python/py-record.h: Rename include guard.
839         * python/py-record-full.h: Rename include guard.
840         * python/py-record-btrace.h: Rename include guard.
841         * python/py-instruction.h: Rename include guard.
842         * python/py-events.h: Rename include guard.
843         * python/py-event.h: Rename include guard.
844         * procfs.h: Add include guard.
845         * proc-utils.h: Add include guard.
846         * p-lang.h: Add include guard.
847         * or1k-tdep.h: Rename include guard.
848         * observable.h: Rename include guard.
849         * nto-tdep.h: Rename include guard.
850         * nat/x86-linux.h: Rename include guard.
851         * nat/x86-linux-dregs.h: Rename include guard.
852         * nat/x86-gcc-cpuid.h: Add include guard.
853         * nat/x86-dregs.h: Rename include guard.
854         * nat/x86-cpuid.h: Rename include guard.
855         * nat/ppc-linux.h: Rename include guard.
856         * nat/mips-linux-watch.h: Rename include guard.
857         * nat/linux-waitpid.h: Rename include guard.
858         * nat/linux-ptrace.h: Rename include guard.
859         * nat/linux-procfs.h: Rename include guard.
860         * nat/linux-osdata.h: Rename include guard.
861         * nat/linux-nat.h: Rename include guard.
862         * nat/linux-namespaces.h: Rename include guard.
863         * nat/linux-btrace.h: Rename include guard.
864         * nat/glibc_thread_db.h: Rename include guard.
865         * nat/gdb_thread_db.h: Rename include guard.
866         * nat/gdb_ptrace.h: Rename include guard.
867         * nat/fork-inferior.h: Rename include guard.
868         * nat/amd64-linux-siginfo.h: Rename include guard.
869         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
870         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
871         * nat/aarch64-linux.h: Rename include guard.
872         * nat/aarch64-linux-hw-point.h: Rename include guard.
873         * mn10300-tdep.h: Add include guard.
874         * mips-linux-tdep.h: Add include guard.
875         * mi/mi-parse.h: Rename include guard.
876         * mi/mi-out.h: Rename include guard.
877         * mi/mi-main.h: Rename include guard.
878         * mi/mi-interp.h: Rename include guard.
879         * mi/mi-getopt.h: Rename include guard.
880         * mi/mi-console.h: Rename include guard.
881         * mi/mi-common.h: Rename include guard.
882         * mi/mi-cmds.h: Rename include guard.
883         * mi/mi-cmd-break.h: Rename include guard.
884         * m2-lang.h: Add include guard.
885         * location.h: Rename include guard.
886         * linux-record.h: Rename include guard.
887         * linux-nat.h: Add include guard.
888         * linux-fork.h: Add include guard.
889         * i386-darwin-tdep.h: Rename include guard.
890         * hppa-linux-offsets.h: Add include guard.
891         * guile/guile.h: Rename include guard.
892         * guile/guile-internal.h: Rename include guard.
893         * gnu-nat.h: Rename include guard.
894         * gdb-stabs.h: Rename include guard.
895         * frv-tdep.h: Add include guard.
896         * f-lang.h: Add include guard.
897         * event-loop.h: Add include guard.
898         * darwin-nat.h: Rename include guard.
899         * cp-abi.h: Rename include guard.
900         * config/sparc/nm-sol2.h: Rename include guard.
901         * config/nm-nto.h: Rename include guard.
902         * config/nm-linux.h: Add include guard.
903         * config/i386/nm-i386gnu.h: Rename include guard.
904         * config/djgpp/nl_types.h: Rename include guard.
905         * config/djgpp/langinfo.h: Rename include guard.
906         * compile/gcc-cp-plugin.h: Add include guard.
907         * compile/gcc-c-plugin.h: Add include guard.
908         * compile/compile.h: Rename include guard.
909         * compile/compile-object-run.h: Rename include guard.
910         * compile/compile-object-load.h: Rename include guard.
911         * compile/compile-internal.h: Rename include guard.
912         * compile/compile-cplus.h: Rename include guard.
913         * compile/compile-c.h: Rename include guard.
914         * common/xml-utils.h: Rename include guard.
915         * common/x86-xstate.h: Rename include guard.
916         * common/version.h: Rename include guard.
917         * common/vec.h: Rename include guard.
918         * common/tdesc.h: Rename include guard.
919         * common/selftest.h: Rename include guard.
920         * common/scoped_restore.h: Rename include guard.
921         * common/scoped_mmap.h: Rename include guard.
922         * common/scoped_fd.h: Rename include guard.
923         * common/safe-iterator.h: Rename include guard.
924         * common/run-time-clock.h: Rename include guard.
925         * common/refcounted-object.h: Rename include guard.
926         * common/queue.h: Rename include guard.
927         * common/ptid.h: Rename include guard.
928         * common/print-utils.h: Rename include guard.
929         * common/preprocessor.h: Rename include guard.
930         * common/pathstuff.h: Rename include guard.
931         * common/observable.h: Rename include guard.
932         * common/netstuff.h: Rename include guard.
933         * common/job-control.h: Rename include guard.
934         * common/host-defs.h: Rename include guard.
935         * common/gdb_wait.h: Rename include guard.
936         * common/gdb_vecs.h: Rename include guard.
937         * common/gdb_unlinker.h: Rename include guard.
938         * common/gdb_unique_ptr.h: Rename include guard.
939         * common/gdb_tilde_expand.h: Rename include guard.
940         * common/gdb_sys_time.h: Rename include guard.
941         * common/gdb_string_view.h: Rename include guard.
942         * common/gdb_splay_tree.h: Rename include guard.
943         * common/gdb_setjmp.h: Rename include guard.
944         * common/gdb_ref_ptr.h: Rename include guard.
945         * common/gdb_optional.h: Rename include guard.
946         * common/gdb_locale.h: Rename include guard.
947         * common/gdb_assert.h: Rename include guard.
948         * common/filtered-iterator.h: Rename include guard.
949         * common/filestuff.h: Rename include guard.
950         * common/fileio.h: Rename include guard.
951         * common/environ.h: Rename include guard.
952         * common/common-utils.h: Rename include guard.
953         * common/common-types.h: Rename include guard.
954         * common/common-regcache.h: Rename include guard.
955         * common/common-inferior.h: Rename include guard.
956         * common/common-gdbthread.h: Rename include guard.
957         * common/common-exceptions.h: Rename include guard.
958         * common/common-defs.h: Rename include guard.
959         * common/common-debug.h: Rename include guard.
960         * common/cleanups.h: Rename include guard.
961         * common/buffer.h: Rename include guard.
962         * common/btrace-common.h: Rename include guard.
963         * common/break-common.h: Rename include guard.
964         * cli/cli-utils.h: Rename include guard.
965         * cli/cli-style.h: Rename include guard.
966         * cli/cli-setshow.h: Rename include guard.
967         * cli/cli-script.h: Rename include guard.
968         * cli/cli-interp.h: Rename include guard.
969         * cli/cli-decode.h: Rename include guard.
970         * cli/cli-cmds.h: Rename include guard.
971         * charset-list.h: Add include guard.
972         * buildsym-legacy.h: Rename include guard.
973         * bfin-tdep.h: Add include guard.
974         * ax.h: Rename include guard.
975         * arm-linux-tdep.h: Add include guard.
976         * arm-fbsd-tdep.h: Add include guard.
977         * arch/xtensa.h: Rename include guard.
978         * arch/tic6x.h: Add include guard.
979         * arch/i386.h: Add include guard.
980         * arch/arm.h: Rename include guard.
981         * arch/arm-linux.h: Rename include guard.
982         * arch/arm-get-next-pcs.h: Rename include guard.
983         * arch/amd64.h: Add include guard.
984         * arch/aarch64-insn.h: Rename include guard.
985         * arch-utils.h: Rename include guard.
986         * annotate.h: Add include guard.
987         * amd64-darwin-tdep.h: Rename include guard.
988         * aarch64-linux-tdep.h: Add include guard.
989         * aarch64-fbsd-tdep.h: Add include guard.
990         * aarch32-linux-nat.h: Add include guard.
991
992 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
993
994         * macrotab.c (macro_define_internal): New function that
995         factorizes macro_define_object_internal and macro_define_function
996         code.
997         (macro_define_object_internal): Use macro_define_internal.
998         (macro_define_function): Likewise.
999
1000 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1001
1002         * macrocmd.c (extract_identifier): Return
1003         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1004         callers.
1005
1006 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1007
1008         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1009
1010 2019-02-05  Tom Tromey  <tom@tromey.com>
1011
1012         * target.c (target_stack::unpush): Move assertion earlier.
1013
1014 2019-01-30  Tom Tromey  <tom@tromey.com>
1015
1016         PR python/23615:
1017         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1018         (gdbpy_parse_and_eval): Likewise.
1019         * python/python-internal.h (gdbpy_allow_threads): New class.
1020
1021 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1022
1023         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1024         (aarch64_fbsd_fpregmap): Move earlier.
1025         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1026         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1027         instead of individual calls to trad_frame_set_reg_addr.
1028         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1029         earlier.
1030         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1031         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1032         instead of individual calls to trad_frame_set_reg_addr.
1033
1034 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1035
1036         * CONTRIBUTE: Replace contribution list with wiki link.
1037
1038 2019-01-25  Tom Tromey  <tom@tromey.com>
1039
1040         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1041
1042 2019-01-25  Tom Tromey  <tom@tromey.com>
1043
1044         * xtensa-linux-nat.c: Fix common/ includes.
1045         * xml-support.h: Fix common/ includes.
1046         * xml-support.c: Fix common/ includes.
1047         * x86-linux-nat.c: Fix common/ includes.
1048         * windows-nat.c: Fix common/ includes.
1049         * varobj.h: Fix common/ includes.
1050         * varobj.c: Fix common/ includes.
1051         * value.c: Fix common/ includes.
1052         * valops.c: Fix common/ includes.
1053         * utils.c: Fix common/ includes.
1054         * unittests/xml-utils-selftests.c: Fix common/ includes.
1055         * unittests/utils-selftests.c: Fix common/ includes.
1056         * unittests/unpack-selftests.c: Fix common/ includes.
1057         * unittests/tracepoint-selftests.c: Fix common/ includes.
1058         * unittests/style-selftests.c: Fix common/ includes.
1059         * unittests/string_view-selftests.c: Fix common/ includes.
1060         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1061         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1062         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1063         * unittests/rsp-low-selftests.c: Fix common/ includes.
1064         * unittests/parse-connection-spec-selftests.c: Fix common/
1065         includes.
1066         * unittests/optional-selftests.c: Fix common/ includes.
1067         * unittests/offset-type-selftests.c: Fix common/ includes.
1068         * unittests/observable-selftests.c: Fix common/ includes.
1069         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1070         * unittests/memrange-selftests.c: Fix common/ includes.
1071         * unittests/memory-map-selftests.c: Fix common/ includes.
1072         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1073         * unittests/function-view-selftests.c: Fix common/ includes.
1074         * unittests/environ-selftests.c: Fix common/ includes.
1075         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1076         * unittests/common-utils-selftests.c: Fix common/ includes.
1077         * unittests/cli-utils-selftests.c: Fix common/ includes.
1078         * unittests/array-view-selftests.c: Fix common/ includes.
1079         * ui-file.c: Fix common/ includes.
1080         * tui/tui-io.c: Fix common/ includes.
1081         * tracepoint.h: Fix common/ includes.
1082         * tracepoint.c: Fix common/ includes.
1083         * tracefile-tfile.c: Fix common/ includes.
1084         * top.h: Fix common/ includes.
1085         * top.c: Fix common/ includes.
1086         * thread.c: Fix common/ includes.
1087         * target/waitstatus.h: Fix common/ includes.
1088         * target/waitstatus.c: Fix common/ includes.
1089         * target.h: Fix common/ includes.
1090         * target.c: Fix common/ includes.
1091         * target-memory.c: Fix common/ includes.
1092         * target-descriptions.c: Fix common/ includes.
1093         * symtab.h: Fix common/ includes.
1094         * symfile.c: Fix common/ includes.
1095         * stap-probe.c: Fix common/ includes.
1096         * spu-linux-nat.c: Fix common/ includes.
1097         * sparc-nat.c: Fix common/ includes.
1098         * source.c: Fix common/ includes.
1099         * solib.c: Fix common/ includes.
1100         * solib-target.c: Fix common/ includes.
1101         * ser-unix.c: Fix common/ includes.
1102         * ser-tcp.c: Fix common/ includes.
1103         * ser-pipe.c: Fix common/ includes.
1104         * ser-base.c: Fix common/ includes.
1105         * selftest-arch.c: Fix common/ includes.
1106         * s12z-tdep.c: Fix common/ includes.
1107         * rust-exp.y: Fix common/ includes.
1108         * rs6000-aix-tdep.c: Fix common/ includes.
1109         * riscv-tdep.c: Fix common/ includes.
1110         * remote.c: Fix common/ includes.
1111         * remote-notif.h: Fix common/ includes.
1112         * remote-fileio.h: Fix common/ includes.
1113         * remote-fileio.c: Fix common/ includes.
1114         * regcache.h: Fix common/ includes.
1115         * regcache.c: Fix common/ includes.
1116         * record-btrace.c: Fix common/ includes.
1117         * python/python.c: Fix common/ includes.
1118         * python/py-type.c: Fix common/ includes.
1119         * python/py-inferior.c: Fix common/ includes.
1120         * progspace.h: Fix common/ includes.
1121         * producer.c: Fix common/ includes.
1122         * procfs.c: Fix common/ includes.
1123         * proc-api.c: Fix common/ includes.
1124         * printcmd.c: Fix common/ includes.
1125         * ppc-linux-nat.c: Fix common/ includes.
1126         * parser-defs.h: Fix common/ includes.
1127         * osdata.c: Fix common/ includes.
1128         * obsd-nat.c: Fix common/ includes.
1129         * nat/x86-linux.c: Fix common/ includes.
1130         * nat/x86-linux-dregs.c: Fix common/ includes.
1131         * nat/x86-dregs.h: Fix common/ includes.
1132         * nat/x86-dregs.c: Fix common/ includes.
1133         * nat/ppc-linux.c: Fix common/ includes.
1134         * nat/mips-linux-watch.h: Fix common/ includes.
1135         * nat/mips-linux-watch.c: Fix common/ includes.
1136         * nat/linux-waitpid.c: Fix common/ includes.
1137         * nat/linux-ptrace.h: Fix common/ includes.
1138         * nat/linux-ptrace.c: Fix common/ includes.
1139         * nat/linux-procfs.c: Fix common/ includes.
1140         * nat/linux-personality.c: Fix common/ includes.
1141         * nat/linux-osdata.c: Fix common/ includes.
1142         * nat/linux-namespaces.c: Fix common/ includes.
1143         * nat/linux-btrace.h: Fix common/ includes.
1144         * nat/linux-btrace.c: Fix common/ includes.
1145         * nat/fork-inferior.c: Fix common/ includes.
1146         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1147         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1148         * nat/aarch64-linux.c: Fix common/ includes.
1149         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1150         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1151         * namespace.h: Fix common/ includes.
1152         * mips-linux-tdep.c: Fix common/ includes.
1153         * minsyms.c: Fix common/ includes.
1154         * mi/mi-parse.h: Fix common/ includes.
1155         * mi/mi-main.c: Fix common/ includes.
1156         * mi/mi-cmd-env.c: Fix common/ includes.
1157         * memrange.h: Fix common/ includes.
1158         * memattr.c: Fix common/ includes.
1159         * maint.h: Fix common/ includes.
1160         * maint.c: Fix common/ includes.
1161         * main.c: Fix common/ includes.
1162         * machoread.c: Fix common/ includes.
1163         * location.c: Fix common/ includes.
1164         * linux-thread-db.c: Fix common/ includes.
1165         * linux-nat.c: Fix common/ includes.
1166         * linux-fork.c: Fix common/ includes.
1167         * inline-frame.c: Fix common/ includes.
1168         * infrun.c: Fix common/ includes.
1169         * inflow.c: Fix common/ includes.
1170         * inferior.h: Fix common/ includes.
1171         * inferior.c: Fix common/ includes.
1172         * infcmd.c: Fix common/ includes.
1173         * inf-ptrace.c: Fix common/ includes.
1174         * inf-child.c: Fix common/ includes.
1175         * ia64-linux-nat.c: Fix common/ includes.
1176         * i387-tdep.c: Fix common/ includes.
1177         * i386-tdep.c: Fix common/ includes.
1178         * i386-linux-tdep.c: Fix common/ includes.
1179         * i386-linux-nat.c: Fix common/ includes.
1180         * i386-go32-tdep.c: Fix common/ includes.
1181         * i386-fbsd-tdep.c: Fix common/ includes.
1182         * i386-fbsd-nat.c: Fix common/ includes.
1183         * guile/scm-type.c: Fix common/ includes.
1184         * guile/guile.c: Fix common/ includes.
1185         * go32-nat.c: Fix common/ includes.
1186         * gnu-nat.c: Fix common/ includes.
1187         * gdbthread.h: Fix common/ includes.
1188         * gdbarch-selftests.c: Fix common/ includes.
1189         * gdb_usleep.c: Fix common/ includes.
1190         * gdb_select.h: Fix common/ includes.
1191         * gdb_bfd.c: Fix common/ includes.
1192         * gcore.c: Fix common/ includes.
1193         * fork-child.c: Fix common/ includes.
1194         * findvar.c: Fix common/ includes.
1195         * fbsd-nat.c: Fix common/ includes.
1196         * event-top.c: Fix common/ includes.
1197         * event-loop.c: Fix common/ includes.
1198         * dwarf2read.c: Fix common/ includes.
1199         * dwarf2loc.c: Fix common/ includes.
1200         * dwarf2-frame.c: Fix common/ includes.
1201         * dwarf-index-cache.c: Fix common/ includes.
1202         * dtrace-probe.c: Fix common/ includes.
1203         * disasm-selftests.c: Fix common/ includes.
1204         * defs.h: Fix common/ includes.
1205         * csky-tdep.c: Fix common/ includes.
1206         * cp-valprint.c: Fix common/ includes.
1207         * cp-support.h: Fix common/ includes.
1208         * cp-support.c: Fix common/ includes.
1209         * corelow.c: Fix common/ includes.
1210         * completer.h: Fix common/ includes.
1211         * completer.c: Fix common/ includes.
1212         * compile/compile.c: Fix common/ includes.
1213         * compile/compile-loc2c.c: Fix common/ includes.
1214         * compile/compile-cplus-types.c: Fix common/ includes.
1215         * compile/compile-cplus-symbols.c: Fix common/ includes.
1216         * command.h: Fix common/ includes.
1217         * cli/cli-dump.c: Fix common/ includes.
1218         * cli/cli-cmds.c: Fix common/ includes.
1219         * charset.c: Fix common/ includes.
1220         * build-id.c: Fix common/ includes.
1221         * btrace.h: Fix common/ includes.
1222         * btrace.c: Fix common/ includes.
1223         * breakpoint.h: Fix common/ includes.
1224         * breakpoint.c: Fix common/ includes.
1225         * ax.h: 
1226         (enum agent_op): Fix common/ includes.
1227         * ax-general.c (struct aop_map): Fix common/ includes.
1228         * ax-gdb.c: Fix common/ includes.
1229         * auxv.c: Fix common/ includes.
1230         * auto-load.c: Fix common/ includes.
1231         * arm-tdep.c: Fix common/ includes.
1232         * arch/riscv.c: Fix common/ includes.
1233         * arch/ppc-linux-common.c: Fix common/ includes.
1234         * arch/i386.c: Fix common/ includes.
1235         * arch/arm.c: Fix common/ includes.
1236         * arch/arm-linux.c: Fix common/ includes.
1237         * arch/arm-get-next-pcs.c: Fix common/ includes.
1238         * arch/amd64.c: Fix common/ includes.
1239         * arch/aarch64.c: Fix common/ includes.
1240         * arch/aarch64-insn.c: Fix common/ includes.
1241         * arch-utils.c: Fix common/ includes.
1242         * amd64-windows-tdep.c: Fix common/ includes.
1243         * amd64-tdep.c: Fix common/ includes.
1244         * amd64-sol2-tdep.c: Fix common/ includes.
1245         * amd64-obsd-tdep.c: Fix common/ includes.
1246         * amd64-nbsd-tdep.c: Fix common/ includes.
1247         * amd64-linux-tdep.c: Fix common/ includes.
1248         * amd64-linux-nat.c: Fix common/ includes.
1249         * amd64-fbsd-tdep.c: Fix common/ includes.
1250         * amd64-fbsd-nat.c: Fix common/ includes.
1251         * amd64-dicos-tdep.c: Fix common/ includes.
1252         * amd64-darwin-tdep.c: Fix common/ includes.
1253         * agent.c: Fix common/ includes.
1254         * ada-lang.h: Fix common/ includes.
1255         * ada-lang.c: Fix common/ includes.
1256         * aarch64-tdep.c: Fix common/ includes.
1257
1258 2019-01-25  Tom Tromey  <tom@tromey.com>
1259
1260         * common/create-version.sh: Use common/version.h.
1261
1262 2019-01-24  Pedro Alves  <palves@redhat.com>
1263
1264         * infrun.c (signal_stop, signal_print, signal_program)
1265         (signal_catch, signal_pass): Now arrays instead of pointers.
1266         (update_signals_program_target, do_target_resume)
1267         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1268         * linux-nat.c (linux_nat_target::pass_signals)
1269         (linux_nat_target::create_inferior, linux_nat_target::attach):
1270         Adjust.
1271         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1272         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1273         * procfs.c (procfs_target::pass_signals): Adjust.
1274         * record-full.c (record_full_target::resume): Adjust.
1275         * remote.c (remote_target::pass_signals)
1276         (remote_target::program_signals): Adjust.
1277         * target-debug.h (target_debug_print_signals): Now takes a
1278         gdb::array_view as parameter.  Adjust.
1279         * target.h (target_ops) <pass_signals, program_signals>: Replace
1280         pointer and length parameters with gdb::array_view.
1281         (target_pass_signals, target_program_signals): Likewise.
1282         * target-delegates.c: Regenerate.
1283
1284 2019-01-24  Pedro Alves  <palves@redhat.com>
1285
1286         * common/forward-scope-exit.h
1287         (forward_scope_exit::forward_scope_exit): Pass arguments to
1288         m_bind_function directly, instead of creating a std::bind and
1289         copying that.
1290
1291 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1292
1293         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1294         for static members.
1295         (pass_in_v_vfp_candidate): Likewise.
1296
1297 2019-01-23  Tom Tromey  <tom@tromey.com>
1298             Pedro Alves  <palves@redhat.com>
1299
1300         * regcache.c (class regcache_invalidator): Remove.
1301         (regcache::raw_write): Use make_scope_exit.
1302
1303 2019-01-23  Tom Tromey  <tom@tromey.com>
1304
1305         * ui-out.h (class ui_out_emit_type): Update comment.
1306
1307 2019-01-23  Tom Tromey  <tom@tromey.com>
1308
1309         * infrun.c (fetch_inferior_event): Update comment.
1310
1311 2019-01-23  Tom Tromey  <tom@tromey.com>
1312             Pedro Alves  <palves@redhat.com>
1313
1314         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1315         parameter.
1316         (fetch_inferior_event): Use SCOPE_EXIT.
1317
1318
1319 2019-01-23  Tom Tromey  <tom@tromey.com>
1320             Pedro Alves  <palves@redhat.com>
1321
1322         * infrun.c (disable_thread_events): Delete.
1323         (stop_all_threads): Use SCOPE_EXIT.
1324
1325 2019-01-23  Tom Tromey  <tom@tromey.com>
1326             Pedro Alves  <palves@redhat.com>
1327
1328         * symfile.c: Include forward-scope-exit.h.
1329         (clear_symtab_users_cleanup): Replace forward declaration with
1330         a FORWARD_SCOPE_EXIT.
1331         (syms_from_objfile_1): Use the forward_scope_exit and
1332         gdb::optional instead of cleanup_function.
1333         (reread_symbols): Use the forward_scope_exit instead of
1334         cleanup_function.
1335         (clear_symtab_users_cleanup): Remove function.
1336
1337 2019-01-23  Tom Tromey  <tom@tromey.com>
1338             Pedro Alves  <palves@redhat.com>
1339
1340         * linux-nat.c: Include scope-exit.h.
1341         (cleanup_target_stop): Remove.
1342         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1343         SCOPE_EXIT.
1344
1345 2019-01-23  Tom Tromey  <tom@tromey.com>
1346             Pedro Alves  <palves@redhat.com>
1347
1348         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1349         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1350
1351 2019-01-23  Tom Tromey  <tom@tromey.com>
1352             Andrew Burgess  <andrew.burgess@embecosm.com>
1353             Pedro Alves  <palves@redhat.com>
1354
1355         * infrun.c (fetch_inferior_event): Use scope_exit.
1356         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1357         * top.c (execute_command): Use scope_exit.
1358         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1359         * utils.c (do_bpstat_clear_actions_cleanup)
1360         (make_bpstat_clear_actions_cleanup): Remove.
1361
1362 2019-01-23  Tom Tromey  <tom@tromey.com>
1363             Pedro Alves  <palves@redhat.com>
1364
1365         * infrun.c: Include "common/scope-exit.h"
1366         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1367         (wait_for_inferior): Use SCOPE_EXIT.
1368         (fetch_inferior_event): Use scope_exit.
1369
1370 2019-01-23  Tom Tromey  <tom@tromey.com>
1371             Pedro Alves  <palves@redhat.com>
1372
1373         * breakpoint.c (create_breakpoint): Remove cleanup.
1374
1375 2019-01-23  Tom Tromey  <tom@tromey.com>
1376             Andrew Burgess  <andrew.burgess@embecosm.com>
1377             Pedro Alves  <palves@redhat.com>
1378
1379 2019-01-23  Pedro Alves  <palves@redhat.com>
1380
1381         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1382
1383 2019-01-23  Pedro Alves  <palves@redhat.com>
1384             Andrew Burgess  <andrew.burgess@embecosm.com>
1385
1386         * gdbthread.h: Include "common/forward-scope-exit.h".
1387         (scoped_finish_thread_state): Redefine custom class in terms of
1388         forward_scope_exit.
1389
1390 2019-01-23  Pedro Alves  <palves@redhat.com>
1391             Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * common/forward-scope-exit.h: New file.
1394
1395 2019-01-23  Pedro Alves  <palves@redhat.com>
1396             Andrew Burgess  <andrew.burgess@embecosm.com>
1397             Tom Tromey  <tom@tromey.com>
1398
1399         * common/scope-exit.h: New file.
1400
1401 2019-01-23  Pedro Alves  <palves@redhat.com>
1402
1403         * common/preprocessor.h (ESC): Rename to ...
1404         (ESC_PARENS): ... this.
1405         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1406         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1407
1408 2019-01-23  Tom Tromey  <tom@tromey.com>
1409
1410         * language.h (class scoped_switch_to_sym_language_if_auto):
1411         Initialize m_lang in both cases.
1412
1413 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1414
1415         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1416         with XCNEW.
1417
1418 2019-01-22  Tom Tromey  <tom@tromey.com>
1419
1420         * corelow.c: Do not include sys/file.h.
1421
1422 2019-01-22  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-wingeneral.h: Include gdb_curses.h.
1425
1426 2019-01-22  Tom Tromey  <tom@tromey.com>
1427
1428         * source-cache.h (class source_cache) <get_source_lines,
1429         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1430
1431 2019-01-22  Tom Tromey  <tom@tromey.com>
1432
1433         * remote-fileio.h (struct remote_target): Declare.
1434
1435 2019-01-22  Tom Tromey  <tom@tromey.com>
1436
1437         * python/py-arch.c: Do not include py-ref.h.
1438         * python/py-bpevent.c: Do not include py-ref.h.
1439         * python/py-cmd.c: Do not include py-ref.h.
1440         * python/py-continueevent.c: Do not include py-ref.h.
1441         * python/py-event.h: Do not include py-ref.h.
1442         * python/py-evtregistry.c: Do not include py-ref.h.
1443         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1444         * python/py-frame.c: Do not include py-ref.h.
1445         * python/py-framefilter.c: Do not include py-ref.h.
1446         * python/py-function.c: Do not include py-ref.h.
1447         * python/py-infevents.c: Do not include py-ref.h.
1448         * python/py-linetable.c: Do not include py-ref.h.
1449         * python/py-objfile.c: Do not include py-ref.h.
1450         * python/py-param.c: Do not include py-ref.h.
1451         * python/py-prettyprint.c: Do not include py-ref.h.
1452         * python/py-progspace.c: Do not include py-ref.h.
1453         * python/py-symbol.c: Do not include py-ref.h.
1454         * python/py-symtab.c: Do not include py-ref.h.
1455         * python/py-type.c: Do not include py-ref.h.
1456         * python/py-unwind.c: Do not include py-ref.h.
1457         * python/py-utils.c: Do not include py-ref.h.
1458         * python/py-value.c: Do not include py-ref.h.
1459         * python/py-varobj.c: Do not include py-ref.h.
1460         * python/py-xmethods.c: Do not include py-ref.h.
1461         * python/python.c: Do not include py-ref.h.
1462         * varobj.c: Do not include py-ref.h.
1463
1464 2019-01-22  Tom Tromey  <tom@tromey.com>
1465
1466         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1467         keyword for bcache.
1468
1469 2019-01-22  Tom Tromey  <tom@tromey.com>
1470
1471         * compile/compile-cplus-types.c: Remove a comment by #include.
1472
1473 2019-01-22  Tom Tromey  <tom@tromey.com>
1474
1475         * compile/gcc-c-plugin.h: Include compile-internal.h.
1476
1477 2019-01-22  Tom Tromey  <tom@tromey.com>
1478
1479         * stabsread.c (EXTERN): Do not define.
1480         (symnum, next_symbol_text_func, processing_gcc_compilation)
1481         (within_function, global_sym_chain, global_stabs)
1482         (previous_stab_code, this_object_header_files)
1483         (n_this_object_header_files)
1484         (n_allocated_this_object_header_files): Define.
1485         * stabsread.h (EXTERN): Never define.  Use "extern".
1486
1487 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1488
1489         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1490         history_value.
1491
1492 2019-01-21  Tom Tromey  <tom@tromey.com>
1493
1494         * ui-out.c: Fix includes.
1495         * tui/tui-source.c: Fix includes.
1496         * target.c: Fix includes.
1497         * remote.c: Fix includes.
1498         * regcache.c: Fix includes.
1499         * python/py-block.c: Fix includes.
1500         * printcmd.c: Fix includes.
1501         * or1k-tdep.c: Fix includes.
1502         * mi/mi-main.c: Fix includes.
1503         * m32r-tdep.c: Fix includes.
1504         * csky-tdep.c: Fix includes.
1505         * compile/compile-cplus-types.c: Fix includes.
1506         * cli/cli-interp.c: Fix includes.
1507
1508 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1509
1510         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1511         for padding.
1512
1513 2019-01-16  Tom Tromey  <tom@tromey.com>
1514
1515         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1516         earlier.
1517         (struct objfile) <msymbols_range>: Move from top level.
1518         <msymbols>: New method.
1519         (class objfile_msymbols): Remove.
1520         * symtab.c (default_collect_symbol_completion_matches_break_on):
1521         Update.
1522         * symmisc.c (dump_msymbols): Update.
1523         * stabsread.c (scan_file_globals): Update.
1524         * objc-lang.c (info_selectors_command, info_classes_command)
1525         (find_methods): Update.
1526         * minsyms.c (find_solib_trampoline_target): Update.
1527         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1528         * coffread.c (coff_symfile_read): Update.
1529         * ada-lang.c (ada_lookup_simple_minsym)
1530         (ada_collect_symbol_completion_matches): Update.
1531
1532 2019-01-16  Tom Tromey  <tom@tromey.com>
1533
1534         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1535         type.  Remove no-argument constructor.
1536         <iterator::operator++>: Simplify.
1537         <begin>: Update.
1538         <end>: Use minimal_symbol_count.
1539
1540 2019-01-16  Tom Tromey  <tom@tromey.com>
1541
1542         * objfiles.h (struct objfile) <psymtabs>: New method.
1543         (class objfile_psymtabs): Remove.
1544         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1545         typedef.
1546         <range>: New method.
1547         (require_partial_symbols): Change return type.
1548         * psymtab.c (require_partial_symbols)
1549         (psym_expand_symtabs_matching): Update.
1550         * mdebugread.c (parse_partial_symbols): Update.
1551         * dbxread.c (dbx_end_psymtab): Update.
1552
1553 2019-01-15  Tom Tromey  <tom@tromey.com>
1554
1555         * symtab.c (lookup_objfile_from_block)
1556         (lookup_symbol_in_objfile_symtabs)
1557         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1558         (find_line_symtab, info_sources_command)
1559         (default_collect_symbol_completion_matches_break_on)
1560         (make_source_files_completion_list): Update.
1561         * symmisc.c (print_objfile_statistics, dump_objfile)
1562         (maintenance_print_symbols, maintenance_info_symtabs)
1563         (maintenance_check_symtabs, maintenance_info_line_tables):
1564         Update.
1565         * source.c (select_source_symtab)
1566         (forget_cached_source_info_for_objfile): Update.
1567         * objfiles.h (class objfile_compunits): Remove.
1568         (struct objfile) <compunits_range>: New typedef.
1569         (compunits): New method.
1570         * objfiles.c (objfile_relocate1): Update.
1571         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1572         * maint.c (count_symtabs_and_blocks): Update.
1573         * linespec.c (iterate_over_all_matching_symtabs): Update.
1574         * cp-support.c (add_symbol_overload_list_qualified): Update.
1575         * coffread.c (coff_symtab_read): Update.
1576         * ada-lang.c (add_nonlocal_symbols)
1577         (ada_collect_symbol_completion_matches)
1578         (ada_add_global_exceptions): Update.
1579
1580 2019-01-15  Tom Tromey  <tom@tromey.com>
1581
1582         * progspace.h (program_space) <objfiles_safe_range>: New
1583         typedef.
1584         <objfiles_safe>: New method.
1585         * objfiles.h (class all_objfiles_safe): Remove.
1586         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1587         * jit.c (jit_inferior_exit_hook): Update.
1588
1589 2019-01-17  Tom Tromey  <tom@tromey.com>
1590
1591         * progspace.h (program_space) <objfiles_range>: New typedef.
1592         <objfiles>: New method.
1593         <objfiles_head>: Rename from objfiles.
1594         (object_files): Update.
1595         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1596         * guile/scm-pretty-print.c
1597         (ppscm_find_pretty_printer_from_objfiles): Update.
1598         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1599         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1600         Update.
1601         * python/py-progspace.c (pspy_get_objfiles): Update.
1602         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1603         Update.
1604         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1605         (objfpy_lookup_objfile_by_build_id): Update.
1606         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1607         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1608         Update.
1609         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1610         (expand_symtab_containing_pc, lookup_objfile_from_block)
1611         (lookup_static_symbol, basic_lookup_transparent_type)
1612         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1613         (find_line_symtab, info_sources_command)
1614         (default_collect_symbol_completion_matches_break_on)
1615         (make_source_files_completion_list, find_main_name): Update.
1616         * symmisc.c (print_symbol_bcache_statistics)
1617         (print_objfile_statistics, maintenance_print_symbols)
1618         (maintenance_print_msymbols, maintenance_print_objfiles)
1619         (maintenance_info_symtabs, maintenance_check_symtabs)
1620         (maintenance_expand_symtabs, maintenance_info_line_tables):
1621         Update.
1622         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1623         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1624         (map_overlay_command, unmap_overlay_command)
1625         (simple_overlay_update, expand_symtabs_matching)
1626         (map_symbol_filenames): Update.
1627         * symfile-debug.c (set_debug_symfile): Update.
1628         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1629         Update.
1630         * source.c (select_source_symtab, forget_cached_source_info):
1631         Update.
1632         * solib.c (solib_read_symbols): Update.
1633         * solib-spu.c (append_ocl_sos): Update.
1634         * psymtab.c (maintenance_print_psymbols)
1635         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1636         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1637         * printcmd.c (info_symbol_command): Update.
1638         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1639         Update.
1640         * objfiles.h (class all_objfiles): Remove.
1641         * objfiles.c (have_partial_symbols, have_full_symbols)
1642         (have_minimal_symbols, qsort_cmp, update_section_map)
1643         (shared_objfile_contains_address_p)
1644         (default_iterate_over_objfiles_in_search_order): Update.
1645         * objc-lang.c (info_selectors_command, info_classes_command)
1646         (find_methods): Update.
1647         * minsyms.c (find_solib_trampoline_target): Update.
1648         * maint.c (maintenance_info_sections)
1649         (maintenance_translate_address, count_symtabs_and_blocks):
1650         Update.
1651         * main.c (captured_main_1): Update.
1652         * linux-thread-db.c (try_thread_db_load_from_pdir)
1653         (has_libpthread): Update.
1654         * linespec.c (iterate_over_all_matching_symtabs)
1655         (search_minsyms_for_name): Update.
1656         * jit.c (jit_find_objf_with_entry_addr): Update.
1657         * hppa-tdep.c (find_unwind_entry)
1658         (hppa_lookup_stub_minimal_symbol): Update.
1659         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1660         Update.
1661         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1662         (elf_gnu_ifunc_resolve_by_got): Update.
1663         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1664         * dwarf-index-write.c (save_gdb_index_command): Update.
1665         * cp-support.c (add_symbol_overload_list_qualified): Update.
1666         * breakpoint.c (create_overlay_event_breakpoint)
1667         (create_longjmp_master_breakpoint)
1668         (create_std_terminate_master_breakpoint)
1669         (create_exception_master_breakpoint): Update.
1670         * blockframe.c (find_pc_partial_function): Update.
1671         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1672         (ada_collect_symbol_completion_matches)
1673         (ada_add_global_exceptions): Update.
1674
1675 2019-01-17  Tom Tromey  <tom@tromey.com>
1676
1677         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1678         declare VEC.
1679         (solib_target_parse_libraries): Change return type.
1680         (library_list_start_segment, library_list_start_section)
1681         (library_list_end_library, library_list_start_library); Update.
1682         (solib_target_free_library_list): Remove.
1683         (solib_target_parse_libraries): Remove cleanup.  Change return
1684         type.
1685         (solib_target_current_sos): Update.
1686
1687 2019-01-17  Tom Tromey  <tromey@bapiya>
1688
1689         * valprint.c: Replace "the the" with "the".
1690         * symtab.c: Replace "the the" with "the".
1691         * solib.c: Replace "the the" with "the".
1692         * solib-dsbt.c: Replace "the the" with "the".
1693         * linespec.c: Replace "the the" with "the".
1694         * dwarf2loc.h: Replace "the the" with "the".
1695         * amd64-windows-tdep.c: Replace "the the" with "the".
1696         * aarch64-tdep.c: Replace "the the" with "the".
1697
1698 2019-01-16  Keith Seitz  <keiths@redhat.com>
1699
1700         PR gdb/23773
1701         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1702         <builder>: Rename to ..
1703         <m_builder>: ... this and make private.
1704         (dwarf2_cu::get_builder): New method.  Change all users of
1705         `builder' to use this method.
1706         (dwarf2_start_symtab): Move to ...
1707         (dwarf2_cu::start_symtab): ... here.  Update all callers
1708         (setup_type_unit_groups): Move to ...
1709         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1710         callers.
1711         (dwarf2_cu::reset_builder): New method.
1712         (process_full_compunit, process_full_type_unit): Use
1713         dwarf2_cu::reset_builder.
1714         (follow_die_offset): Record the ancestor CU if it is different
1715         from the followed DIE's CU.
1716         (follow_die_sig_1): Likewise.
1717
1718 2019-01-15  Tom Tromey  <tom@tromey.com>
1719
1720         * remote.c (class remote_state) <buf>: Now a char_vector.
1721         <buf_size>: Remove.
1722         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1723         parameter.
1724         (remote_target::getpkt_or_notif_sane_1)
1725         (remote_target::getpkt_sane)
1726         (remote_target::getpkt_or_notif_sane): Likewise.
1727         (class remote_target) <putpkt>: New overload.
1728         (remote_target::read_frame): Change type of "buf_p".  Remove
1729         sizeof_p parameter.
1730         (packet_ok): New overload.
1731         (packet_check_result): New overload.
1732         Update all uses.
1733
1734 2019-01-14  Tom Tromey  <tom@tromey.com>
1735
1736         * remote-notif.c (handle_notification, remote_notif_ack)
1737         (remote_notif_parse): Make "buf" const.
1738         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1739         const.
1740         (remote_notif_parse, remote_notif_ack, handle_notification):
1741         Likewise.
1742         * remote.c (remote_notif_stop_parse): Make "buf" const.
1743         (remote_target::remote_parse_stop_reply): Make "buf" const.
1744         (remote_notif_stop_ack): Make "buf" const.
1745
1746 2019-01-14  Tom Tromey  <tom@tromey.com>
1747
1748         * remote.c (remote_console_output): Make parameter const.
1749
1750 2019-01-14  Tom Tromey  <tom@tromey.com>
1751
1752         * target-debug.h (target_debug_print_signals): Constify.
1753         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1754         * procfs.c (procfs_target::pass_signals): Update.
1755         * linux-nat.c (linux_nat_target::pass_signals): Update.
1756         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1757         * target-delegates.c: Rebuild.
1758         * remote.c (remote_target::program_signals): Update.
1759         (remote_target::pass_signals): Update.
1760         * target.c (target_pass_signals): Constify argument.
1761         (target_program_signals): Likewise.
1762         * target.h (struct target_ops) <pass_signals, program_signals>:
1763         Constify argument.
1764         (target_pass_signals, target_program_signals): Constify argument.
1765
1766 2019-01-14  Tom Tromey  <tom@tromey.com>
1767
1768         PR tui/28819:
1769         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1770
1771 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1772
1773         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1774         field.
1775         * rs6000-tdep.c: Include reggroups.h.
1776         (IS_V_ALIAS_PSEUDOREG): Define.
1777         (rs6000_register_name): Return names for the "vX" aliases.
1778         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1779         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1780         aliases.  Call default_register_reggroup_p for all other
1781         pseudo-registers.
1782         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1783         New functions.
1784         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1785         Handle "vX" aliases.
1786         (v_alias_pseudo_register_collect): New function.
1787         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1788         (rs6000_gdbarch_init): Initialize "vX" aliases as
1789         pseudo-registers.  Restore registration of
1790         rs6000_pseudo_register_reggroup_p with
1791         set_tdesc_pseudo_register_reggroup_p.
1792
1793 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1794
1795         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1796         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1797         set_gdbarch_num_pseudo_regs.
1798
1799 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1800
1801         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1802         Remove arg prefixname, add do_set and do_show.
1803         Add member functions set_list and show_list.
1804         * cli/cli-style.c (class cli_style_option): Update accordingly.
1805         (style_set_list): Move to file scope.
1806         (style_show_list): Likewise.
1807         (set_style): Call help_list.
1808         (show_style): Call cmd_show_list.
1809         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1810         Update to use the new macro.
1811
1812 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1813
1814         * ada-lang.c (_initialize_ada_language): Expand the help text
1815         for the "catch exception" command.
1816
1817 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1818
1819         * symtab.c (matching_obj_sections): Initialize obj,
1820         declare it closer to its usage.
1821
1822 2019-01-10  Tom Tromey  <tom@tromey.com>
1823
1824         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1825         (basic_inf_threads_range): Remove.
1826         (inf_threads_range, inf_non_exited_threads_range)
1827         (safe_inf_threads_range): Use next_adapter.
1828
1829 2019-01-10  Keith Seitz  <keiths@redhat.com>
1830
1831         PR gdb/23712
1832         PR symtab/23010
1833         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1834         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1835
1836 2019-01-10  Keith Seitz  <keiths@redhat.com>
1837
1838         PR gdb/23712
1839         PR symtab/23010
1840         * dictionary.c (pending_to_vector): Remove.
1841         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1842         Remove _1 suffix, replacing functions of the same name.  Update
1843         all callers.
1844         (dict_create_hashed, dict_create_hashed_expandable)
1845         (dict_create_linear, dict_create_linear_expandable, dict_free)
1846         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1847         Make functions static.
1848
1849 2019-01-10  Keith Seitz  <keiths@redhat.com>
1850
1851         PR gdb/23712
1852         PR symtab/23010
1853         * dictionary.h (struct dictionary): Replace declaration with
1854         multidictionary.
1855         (dict_create_hashed, dict_create_hashed_expandable)
1856         (dict_create_linear, dict_create_linear_expandable)
1857         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1858         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1859         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1860         taking multidictionary argument.
1861         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1862         * block.h (struct block) <dict>: Change to multidictionary
1863         and rename `multidict'.
1864         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1865         symmisc.c: Update all dictionary references to multidictionary.
1866
1867 2019-01-10  Keith Seitz  <keiths@redhat.com>
1868
1869         PR gdb/23712
1870         PR symtab/23010
1871         * dictionary.c: Include unordered_map.
1872         (pending_to_vector): New function.
1873         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1874         Rewrite the non-"_1" functions to take vector instead
1875         of linked list.
1876         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1877         "new" _1 versions of the same name.
1878         (multidictionary): Define.
1879         (std::hash<enum language): New definition.
1880         (collate_pending_symbols_by_language, mdict_create_hashed)
1881         (mdict_create_hashed_expandable, mdict_create_linear)
1882         (mdict_create_linear_expandable, mdict_free)
1883         (find_language_dictionary, create_new_language_dictionary)
1884         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1885         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1886         (mdict_size, mdict_empty): New functions.
1887         * dictionary.h (mdict_iterator): Define.
1888
1889 2019-01-10  Pedro Alves  <palves@redhat.com>
1890
1891         * breakpoint.c (read_uploaded_action)
1892         (create_tracepoint_from_upload): Adjust to use
1893         gdb::unique_xmalloc_ptr.
1894         * ctf.c (ctf_write_uploaded_tp):
1895         (SET_ARRAY_FIELD): Use emplace_back.
1896         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1897         * tracefile-tfile.c (tfile_write_uploaded_tp):
1898         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1899         gdb::unique_xmalloc_ptr.
1900         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1901         at_string, cond_string, cmd_strings>: Replace char pointers
1902         with gdb::unique_xmalloc_ptr.
1903
1904 2019-01-10  Pedro Alves  <palves@redhat.com>
1905
1906         * solib-target.c (library_list_start_library): Don't xstrdup name.
1907
1908 2019-01-10  Pedro Alves  <palves@redhat.com>
1909
1910         * mdebugread.c (parse_partial_symbols): Use
1911         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1912
1913 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1914
1915         * linux-fork.c (scoped_switch_fork_info)
1916         <~scoped_switch_fork_info>: Fix incorrect variable name.
1917
1918 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * linux-fork.c (scoped_switch_fork_info)
1921         <scoped_switch_fork_info>: Make explicit.
1922         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1923
1924 2019-01-10  Tom Tromey  <tom@tromey.com>
1925
1926         * objfiles.h (objfile::reset_psymtabs): Update.
1927         * objfiles.c (objfile::objfile): Update.
1928         * psymtab.h (psymtab_storage::obstack): Update.
1929         (psymtab_storage::m_obstack): Use gdb::optional.
1930         (class psymtab_storage): Update comment.  Remove objfile
1931         parameter.
1932         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1933
1934 2019-01-10  Tom Tromey  <tom@tromey.com>
1935
1936         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1937         <free_psymtabs>: Now private.
1938         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1939         (allocate_psymtab): Use new method.
1940
1941 2019-01-10  Tom Tromey  <tom@tromey.com>
1942
1943         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1944         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1945         * mdebugread.c (parse_partial_symbols): Use
1946         allocate_dependencies.
1947         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1948         allocate_dependencies.
1949         (process_psymtab_comp_unit_reader)
1950         (build_type_psymtab_dependencies): Likewise.
1951         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1952
1953 2019-01-10  Tom Tromey  <tom@tromey.com>
1954
1955         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1956         PSYMBOL_SET_LANGUAGE.
1957         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1958
1959 2019-01-10  Tom Tromey  <tom@tromey.com>
1960
1961         * psymtab.h (psymtab_storage::obstack): New method.
1962         <m_obstack>: Rename from obstack; now private.
1963         * psymtab.c (psymtab_storage): Update.
1964         * dwarf2read.c (create_addrmap_from_index)
1965         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1966         Update.
1967
1968 2019-01-10  Tom Tromey  <tom@tromey.com>
1969
1970         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1971         * objfiles.h (objfile::reset_psymtabs): New method.
1972
1973 2019-01-10  Tom Tromey  <tom@tromey.com>
1974
1975         * symmisc.c (print_symbol_bcache_statistics): Update.
1976         (print_objfile_statistics): Update.
1977         * symfile.c (reread_symbols): Update.
1978         * psymtab.h (class psymtab_storage): New.
1979         * psymtab.c (psymtab_storage): New constructor.
1980         (~psymtab_storage): New destructor.
1981         (require_partial_symbols): Update.
1982         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1983         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1984         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1985         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1986         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1987         (start_psymtab_common, end_psymtab_common)
1988         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1989         (allocate_psymtab): Update.
1990         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1991         Update.
1992         (dump_psymtab_addrmap, maintenance_print_psymbols)
1993         (maintenance_check_psymtabs): Update.
1994         (class objfile_psymtabs): Move to objfiles.h.
1995         * psympriv.h (discard_psymtab): Now inline.
1996         (psymtab_discarder::psymtab_discarder): Update.
1997         (psymtab_discarder::~psymtab_discarder): Update.
1998         (ALL_OBJFILE_PSYMTABS): Rewrite.
1999         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2000         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2001         Remove fields.
2002         <partial_symtabs>: New field.
2003         (class objfile_psymtabs): Move from psymtab.h.  Update.
2004         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2005         psymbol_cache.
2006         (objfile::~objfile): Don't destroy psymbol_cache.
2007         * mdebugread.c (parse_partial_symbols): Update.
2008         * dwarf2read.c (create_addrmap_from_index)
2009         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2010         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2011         (add_partial_subprogram, dwarf2_ranges_read): Update.
2012         * dwarf-index-write.c (write_address_map)
2013         (write_one_signatured_type, recursively_write_psymbols)
2014         (class debug_names, class debug_names, write_psymtabs_to_index):
2015         Update.
2016
2017 2019-01-10  Tom Tromey  <tom@tromey.com>
2018
2019         * symtab.h (SYMBOL_SET_NAMES): Update.
2020         (symbol_set_names): Update.
2021         (MSYMBOL_SET_NAMES): Update.
2022         * symtab.c (symbol_set_names): Change argument to be an
2023         objfile_per_bfd_storage.
2024         * psymtab.c (add_psymbol_to_bcache): Update.
2025         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2026
2027 2019-01-10  Tom Tromey  <tom@tromey.com>
2028
2029         * symtab.c (create_demangled_names_hash): Change argument to be an
2030         objfile_per_bfd_storage.
2031         (symbol_set_names): Update.
2032
2033 2019-01-10  Tom Tromey  <tom@tromey.com>
2034
2035         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2036         init_psymbol_list.
2037         * psymtab.c (init_psymbol_list): Do nothing if already called.
2038         * psympriv.h (init_psymbol_list): Add comment.
2039         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2040         init_psymbol_list.
2041         * dbxread.c (dbx_symfile_read): Unconditionally call
2042         init_psymbol_list.
2043
2044 2019-01-10  Tom Tromey  <tom@tromey.com>
2045
2046         * xcoffread.c (scan_xcoff_symtab): Update.
2047         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2048         "where".
2049         * mdebugread.c (parse_partial_symbols)
2050         (handle_psymbol_enumerators): Update.
2051         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2052         * dbxread.c (read_dbx_symtab): Update.
2053         * psympriv.h (psymbol_placement): New enum.
2054         (add_psymbol_to_list): Update.
2055
2056 2019-01-10  Tom Tromey  <tom@tromey.com>
2057
2058         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2059         static_psymbols parameters.
2060         (scan_xcoff_symtab): Update.
2061         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2062         static_psymbols parameters.
2063         * psympriv.h (start_psymtab_common): Update.
2064         * mdebugread.c (parse_partial_symbols): Update.
2065         * dwarf2read.c (create_partial_symtab): Update.
2066         * dbxread.c (read_dbx_symtab): Update.
2067         (start_psymtab): Remove global_psymbols and static_psymbols
2068         parameters.
2069
2070 2019-01-10  Tom Tromey  <tom@tromey.com>
2071
2072         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2073         * psymtab.c (allocate_psymtab): Add comment.
2074         * psympriv.h (allocate_psymtab): Add comment.
2075         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2076         initializations.
2077         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2078
2079 2019-01-10  Tom Tromey  <tom@tromey.com>
2080
2081         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2082         Don't declare.
2083         * mipsread.c: Include mdebugread.h.
2084         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2085         Declare.
2086         * elfread.c: Include mdebugread.h.
2087
2088 2019-01-09  Tom Tromey  <tom@tromey.com>
2089
2090         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2091         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2092         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2093         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2094         (psym_lookup_symbol, psym_find_last_source_symtab)
2095         (psym_forget_cached_source_info, psym_print_stats)
2096         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2097         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2098         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2099         (psym_find_compunit_symtab_by_address)
2100         (maintenance_print_psymbols, maintenance_info_psymtabs)
2101         (maintenance_check_psymtabs): Use ranged for.
2102         * psymtab.h (class objfile_psymtabs): New.
2103         (require_partial_symbols): Return objfile_psymtabs.
2104         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2105
2106 2019-01-09  Tom Tromey  <tom@tromey.com>
2107
2108         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2109         (find_pc_mapped_section, list_overlays_command)
2110         (map_overlay_command, unmap_overlay_command)
2111         (simple_overlay_update): Use all_objfiles.
2112         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2113         * printcmd.c (info_symbol_command): Use all_objfiles.
2114         * objfiles.h (ALL_OBJSECTIONS): Remove.
2115         * maint.c (maintenance_translate_address): Use all_objfiles.
2116         * gcore.c (gcore_create_callback): Use all_objfiles.
2117         (objfile_find_memory_regions): Likewise.
2118
2119 2019-01-09  Tom Tromey  <tom@tromey.com>
2120
2121         * symtab.c (find_line_symtab, info_sources_command)
2122         (make_source_files_completion_list): Use objfile_compunits.
2123         * source.c (select_source_symtab): Use objfile_compunits.
2124         * objfiles.h (struct objfile): Update comment.
2125         (ALL_OBJFILES): Remove.
2126         (ALL_FILETABS): Remove.
2127         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2128         objfile_compunits.
2129
2130 2019-01-09  Tom Tromey  <tom@tromey.com>
2131
2132         * symmisc.c (print_objfile_statistics, dump_objfile)
2133         (maintenance_print_symbols): Use compunit_filetabs.
2134         * source.c (forget_cached_source_info_for_objfile): Use
2135         compunit_filetabs.
2136         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2137         (ALL_FILETABS): Use compunit_filetabs.
2138         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2139         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2140
2141 2019-01-09  Tom Tromey  <tom@tromey.com>
2142
2143         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2144         (compunit_filetabs): New.
2145         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2146         compunit_filetabs.
2147         (info_sources_command, make_source_files_completion_list): Remove
2148         declaration.
2149         * symmisc.c (print_objfile_statistics, dump_objfile)
2150         (maintenance_print_symbols): Remove declaration.
2151         (maintenance_info_symtabs): Use compunit_filetabs.
2152         (maintenance_info_line_tables): Likewise.
2153         * source.c (select_source_symtab): Change local variable name.
2154         (forget_cached_source_info_for_objfile): Remove declaration.
2155         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2156         * objfiles.c (objfile_relocate1): Remove declaration.
2157         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2158         declaration.
2159         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2160         * coffread.c (coff_symtab_read): Remove declaration.
2161         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2162         compunit_filetabs.
2163
2164 2019-01-09  Tom Tromey  <tom@tromey.com>
2165
2166         * symtab.c (lookup_objfile_from_block)
2167         (find_pc_sect_compunit_symtab, search_symbols)
2168         (default_collect_symbol_completion_matches_break_on): Use
2169         objfile_compunits.
2170         * objfiles.h (ALL_COMPUNITS): Remove.
2171         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2172         * cp-support.c (add_symbol_overload_list_qualified): Use
2173         objfile_compunits.
2174         * ada-lang.c (ada_collect_symbol_completion_matches)
2175         (ada_add_global_exceptions): Use objfile_compunits.
2176
2177 2019-01-09  Tom Tromey  <tom@tromey.com>
2178
2179         * source.c (select_source_symtab)
2180         (forget_cached_source_info_for_objfile): Remove declaration.
2181         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2182         declaration.
2183         * maint.c (count_symtabs_and_blocks): Remove declaration.
2184         * cp-support.c (add_symbol_overload_list_qualified): Remove
2185         declaration.
2186         * coffread.c (coff_symtab_read): Remove declaration.
2187         * symtab.c (lookup_symbol_in_objfile_symtabs)
2188         (basic_lookup_transparent_type_1): Use objfile_compunits.
2189         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2190         (info_sources_command, search_symbols)
2191         (default_collect_symbol_completion_matches_break_on)
2192         (make_source_files_completion_list): Remove declaration.
2193         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2194         (ada_collect_symbol_completion_matches)
2195         (ada_add_global_exceptions): Remove declaration.
2196         * linespec.c (iterate_over_all_matching_symtabs): Use
2197         objfile_compunits.
2198         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2199         (class objfile_compunits): New.
2200         (ALL_COMPUNITS): Use objfile_compunits.
2201         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2202         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2203         objfile_compunits.
2204         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2205
2206 2019-01-09  Tom Tromey  <tom@tromey.com>
2207
2208         * symtab.c (search_symbols)
2209         (default_collect_symbol_completion_matches_break_on): Use
2210         objfile_msymbols.
2211         * ada-lang.c (ada_lookup_simple_minsym)
2212         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2213         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2214         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2215         objfile_msymbols.
2216         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2217         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2218         * objc-lang.c (find_methods): Use objfile_msymbols.
2219         (info_selectors_command, info_classes_command): Likewise.
2220         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2221         * objfiles.h (class objfile_msymbols): New.
2222         (ALL_OBJFILE_MSYMBOLS): Remove.
2223         (ALL_MSYMBOLS): Remove.
2224
2225 2019-01-09  Tom Tromey  <tom@tromey.com>
2226
2227         * common/next-iterator.h (next_adapter): Add Iterator template
2228         parameter.
2229         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2230         (class all_objfiles_safe): New.
2231         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2232         * objfiles.c (put_objfile_before): Update comment.
2233         (add_separate_debug_objfile): Likewise.
2234         (free_all_objfiles): Use all_objfiles_safe.
2235         (objfile_purge_solibs): Likewise.
2236
2237 2019-01-09  Tom Tromey  <tom@tromey.com>
2238
2239         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2240         (expand_symtab_containing_pc, lookup_static_symbol)
2241         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2242         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2243         all_objfiles.
2244         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2245         * breakpoint.c (create_overlay_event_breakpoint)
2246         (create_longjmp_master_breakpoint)
2247         (create_std_terminate_master_breakpoint)
2248         (create_exception_master_breakpoint): Use all_objfiles.
2249         * linux-thread-db.c (try_thread_db_load_from_pdir)
2250         (has_libpthread): Use all_objfiles.
2251         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2252         * linespec.c (iterate_over_all_matching_symtabs)
2253         (search_minsyms_for_name): Use all_objfiles.
2254         * maint.c (maintenance_info_sections): Use all_objfiles.
2255         * main.c (captured_main_1): Use all_objfiles.
2256         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2257         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2258         * guile/scm-pretty-print.c
2259         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2260         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2261         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2262         (maintenance_print_msymbols): Use all_objfiles.
2263         * source.c (select_source_symtab): Use all_objfiles.
2264         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2265         * symfile.c (remove_symbol_file_command)
2266         (expand_symtabs_matching, map_symbol_filenames): Use
2267         all_objfiles.
2268         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2269         all_objfiles.
2270         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2271         * objc-lang.c (find_methods): Use all_objfiles.
2272         * objfiles.c (have_partial_symbols, have_full_symbols)
2273         (have_minimal_symbols, qsort_cmp)
2274         (default_iterate_over_objfiles_in_search_order): Use
2275         all_objfiles.
2276         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2277         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2278         (maintenance_check_psymtabs): Use all_objfiles.
2279         (ALL_PSYMTABS): Remove.
2280         * compile/compile-object-run.c (do_module_cleanup): Use
2281         all_objfiles.
2282         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2283         * cp-support.c (add_symbol_overload_list_qualified): Use
2284         all_objfiles.
2285         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2286         Use all_objfiles.
2287         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2288         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2289         all_objfiles.
2290         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2291         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2292         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2293         Uses all_objfiles.
2294         * solib.c (solib_read_symbols): Use all_objfiles
2295
2296 2019-01-09  Tom Tromey  <tom@tromey.com>
2297
2298         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2299         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2300         all_objfiles.
2301         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2302         * symmisc.c (print_symbol_bcache_statistics)
2303         (print_objfile_statistics, maintenance_print_objfiles)
2304         (maintenance_info_symtabs, maintenance_check_symtabs)
2305         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2306         all_objfiles.
2307         * source.c (forget_cached_source_info): Use all_objfiles.
2308         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2309         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2310         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2311         * objfiles.c (update_section_map): Use all_objfiles.
2312         (shared_objfile_contains_address_p): Likewise.
2313         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2314         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2315
2316 2019-01-09  Tom Tromey  <tom@tromey.com>
2317
2318         * common/next-iterator.h: New file.
2319         * objfiles.h (class all_objfiles): New.
2320         (struct objfile_iterator): New.
2321
2322 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2323
2324         * NEWS: Move the description of the changed "frame", "select-frame",
2325          and "info frame" commands to the Changed commands section.
2326
2327 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2328
2329         * gdbtypes.c (check_stub_method_group): Remove handling of old
2330         mangling schemes.
2331         * linespec.c (find_methods): Likewise.
2332         * stabsread.c (read_member_functions): Likewise.
2333         * valops.c (search_struct_method): Likewise.
2334         (value_struct_elt_for_reference): Likewise.
2335         * NEWS: Mention this change.
2336
2337 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2338
2339         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2340         print_source_lines.
2341         * source.c (print_source_lines_base): Update line number check.
2342         (print_source_lines): New function.
2343         (source_lines_range::source_lines_range): New function.
2344         * source.h (class source_lines_range): New class.
2345         (print_source_lines): New declaration.
2346
2347 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2348
2349         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2350
2351 2019-01-08  Tom Tromey  <tom@tromey.com>
2352             Simon Marchi  <simon.marchi@ericsson.com>
2353
2354         PR gdb/24060
2355         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2356         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2357         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2358         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2359         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2360         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2361
2362 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * source.c (select_source_symtab): Move header comment to
2365         declaration in source.h.
2366         (forget_cached_source_info_for_objfile): Likewise.
2367         (forget_cached_source_info): Likewise.
2368         (identify_source_line): Likewise.
2369         * source.h (identify_source_line): Move declaration from symtab.h
2370         and add comment from source.c
2371         (print_source_lines): Likewise.
2372         (forget_cached_source_info_for_objfile): Likewise.
2373         (forget_cached_source_info): Likewise.
2374         (select_source_symtab): Likewise.
2375         (enum print_source_lines_flag): Move definition from symtab.h.
2376         * symtab.h (identify_source_line): Move declaration to source.h.
2377         (print_source_lines): Likewise.
2378         (forget_cached_source_info_for_objfile): Likewise.
2379         (forget_cached_source_info): Likewise.
2380         (select_source_symtab): Likewise.
2381         (enum print_source_lines_flag): Move definition to source.h.
2382         * tui/tui-hooks.c: Add 'source.h' include.
2383
2384 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         * source.c (print_source_lines_base): Handle requests to print
2387         reverse line number sequences, and guard against empty lines
2388         string.
2389
2390 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * source.c (print_source_lines_base): Fix skip of '\r' if next
2393         character is '\n'.
2394
2395 2019-01-06  Tom Tromey  <tom@tromey.com>
2396
2397         * c-exp.y (struct c_parse_state) <macro_original_text,
2398         expansion_obstack>: New member.
2399         (macro_original_text, expansion_obstack): Remove globals.
2400         (scan_macro_expansion, scanning_macro_expansion)
2401         (finished_macro_expansion): Update.
2402         (scan_macro_cleanup): Remove.
2403         (yylex, c_parse): Update.
2404
2405 2019-01-06  Tom Tromey  <tom@tromey.com>
2406
2407         * c-exp.y (struct c_parse_state) <strings>: New member.
2408         (operator_stoken): Update.
2409
2410 2019-01-06  Tom Tromey  <tom@tromey.com>
2411
2412         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2413         (union type_stack_elt) <typelist_val>: Now a pointer to
2414         std::vector.
2415         (type_stack_cleanup): Don't declare.
2416         (push_typelist): Update.
2417         * parse.c (pop_typelist): Return a std::vector.
2418         (push_typelist): Take a std::vector.
2419         (follow_types): Update.  Do not free args.
2420         (type_stack_cleanup): Remove.
2421         * c-exp.y (struct c_parse_state): New.
2422         (cpstate): New global.
2423         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2424         (nonempty_typelist): Update.
2425         (func_mod): Create a new vector.
2426         (c_parse): Create a c_parse_state.
2427         (check_parameter_typelist): Do not delete params.
2428         (function_method): Update.  Do not delete type_list.
2429
2430 2019-01-06  Tom Tromey  <tom@tromey.com>
2431
2432         PR gdb/28155:
2433         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2434         check_typedef.
2435         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2436         (print_return_value): Likewise.
2437
2438 2019-01-05  Tom Tromey  <tom@tromey.com>
2439
2440         * contrib/cleanup_check.py: Remove.
2441         * contrib/gcc-with-excheck: Remove.
2442         * contrib/exsummary.py: Remove.
2443         * contrib/excheck.py: Remove.
2444
2445 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2446
2447         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2448         NULL. Initialize tpprev to NULL instead of assigning it
2449         to NULL on the next statement.
2450         * windows-nat.c (windows_delete_thread): Remove check for
2451         main_thread_id before printing thread exit notifications.
2452         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2453         Remove thread ID check against main_thread_id.
2454         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2455         windows_delete_thread.
2456         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2457
2458 2019-01-04  Tom Tromey  <tom@tromey.com>
2459
2460         * compile/compile.c (_initialize_compile): Use upper case for
2461         metasyntactic variables.
2462         * symmisc.c (_initialize_symmisc): Use upper case for
2463         metasyntactic variables.
2464         * psymtab.c (_initialize_psymtab): Use upper case for
2465         metasyntactic variables.
2466         * demangle.c (demangle_command): Use upper case for metasyntactic
2467         variables.
2468         (_initialize_demangler): Likewise.
2469         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2470         variables.
2471
2472 2019-01-03  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2475
2476 2019-01-03  Tom Tromey  <tom@tromey.com>
2477
2478         * python/py-symtab.c (salpy_str): Update.
2479         (struct salpy_sal_object) <symtab>: Now a PyObject.
2480         (salpy_dealloc): Update.
2481         (del_objfile_sal): Use gdbpy_ref.
2482
2483 2019-01-03  Tom Tromey  <tom@tromey.com>
2484
2485         * python/py-type.c (convert_field): Use new_reference.  Return
2486         gdbpy_ref.
2487         (make_fielditem): Return gdbpy_ref.
2488         (typy_fields): Update.
2489         (typy_getitem): Update.
2490         (field_name): Return gdbpy_ref.  Use new_reference.
2491         (typy_iterator_iternext): Update.
2492
2493 2019-01-03  Tom Tromey  <tom@tromey.com>
2494
2495         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2496
2497 2019-01-03  Tom Tromey  <tom@tromey.com>
2498
2499         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2500         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2501         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2502         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2503         (pspy_set_type_printers): Likewise.
2504         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2505         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2506         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2507         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2508         (objfpy_set_type_printers): Likewise.
2509
2510 2019-01-03  Tom Tromey  <tom@tromey.com>
2511
2512         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2513         (gdbpy_print_stack): Use gdbpy_err_fetch.
2514         * python/python-internal.h (class gdbpy_err_fetch): New class.
2515         (class gdbpy_enter) <m_error_type, m_error_value,
2516         m_error_traceback>: Remove.
2517         <m_error>: New member.
2518         (gdbpy_exception_to_string): Don't declare.
2519         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2520         * python/py-value.c (convert_value_from_python): Use
2521         gdbpy_err_fetch.
2522         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2523         gdbpy_exception_to_string.
2524         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2525         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2526         gdbpy_err_fetch.
2527
2528 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2529
2530         * linux-nat.c (delete_lwp_cleanup): Delete.
2531         (struct lwp_deleter): New struct.
2532         (lwp_info_up): New typedef.
2533         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2534         lwp_info_up.
2535
2536 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2537
2538         * linux-fork.c (class scoped_switch_fork_info): New class.
2539         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2540
2541 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2542
2543         * valops.c (find_overload_match): Remove use of null_cleanup, and
2544         calls to do_cleanups.
2545
2546 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2547
2548         * compile/compile-cplus-types.c
2549         (compile_cplus_instance::decl_name): Handle changes to
2550         cp_func_name.
2551         * cp-support.c (cp_func_name): Update header comment, update
2552         return type.
2553         * cp-support.h (cp_func_name): Update return type in declaration.
2554         * valops.c (find_overload_match): Move temp_func local to top
2555         level of function and change its type.  Use temp_func to hold and
2556         delete temporary string obtained from cp_func_name.
2557
2558 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2559
2560         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2561         gdb::char_vector, remove cleanup, and update uses of `msg`.
2562
2563 2019-01-03  Jim Wilson  <jimw@sifive.com>
2564
2565         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2566
2567 2019-01-02  Tom Tromey  <tom@tromey.com>
2568
2569         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2570         (tdesc_parse_xml): Remove cleanups.
2571         * target-descriptions.h (make_cleanup_free_target_description):
2572         Don't declare.
2573         (target_desc_deleter): New struct.
2574         (target_desc_up): New typedef.
2575         * target-descriptions.c (target_desc_deleter::operator()): Rename
2576         from free_target_description.
2577         (make_cleanup_free_target_description): Remove.
2578
2579 2019-01-02  Tom Tromey  <tom@tromey.com>
2580
2581         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2582         constructor, destructor.
2583         (linespec_parser): Remove typedef.
2584         (~linespec_parser): Rename from linespec_parser_delete.
2585         (linespec_lex_to_end, linespec_complete_label)
2586         (linespec_complete): Update.
2587         (decode_line_full): Remove cleanups.
2588         (decode_line_1): Update.
2589
2590 2019-01-02  Tom Tromey  <tom@tromey.com>
2591
2592         * python/python-internal.h (inferior_to_inferior_object): Change
2593         return type.
2594         * python/py-exitedevent.c (create_exited_event_object): Update.
2595         * python/py-inferior.c (inferior_to_inferior_object): Return
2596         gdbpy_ref.
2597         (python_new_inferior, python_inferior_deleted)
2598         (thread_to_thread_object, delete_thread_object)
2599         (build_inferior_list, gdbpy_selected_inferior): Update.
2600         * python/py-infthread.c (create_thread_object): Update.  Also fail
2601         if inferior_to_inferior_object fails.
2602
2603 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2604
2605         * inferior.h (class inferior) <displaced_step_state>: New field.
2606         * infrun.h (struct displaced_step_state): Move here from
2607         infrun.c.  Initialize fields, add constructor.
2608         <inf>: Remove field.
2609         <reset>: New method.
2610         * infrun.c (struct displaced_step_inferior_state): Move to
2611         infrun.h.
2612         (displaced_step_inferior_states): Remove.
2613         (get_displaced_stepping_state): Adust.
2614         (displaced_step_in_progress_any_inferior): Adjust.
2615         (displaced_step_in_progress_thread): Adjust.
2616         (displaced_step_in_progress): Adjust.
2617         (add_displaced_stepping_state): Remove.
2618         (get_displaced_step_closure_by_addr): Adjust.
2619         (remove_displaced_stepping_state): Remove.
2620         (infrun_inferior_exit): Call displaced_step_state.reset.
2621         (use_displaced_stepping): Don't check for NULL.
2622         (displaced_step_prepare_throw): Call
2623         get_displaced_stepping_state.
2624         (displaced_step_fixup): Don't check for NULL.
2625         (prepare_for_detach): Don't check for NULL.
2626
2627 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2628
2629         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2630          in case of call that did not complete.
2631
2632 2019-01-02  Andrey Utkin  <autkin@undo.io>
2633
2634         * symfile.c (find_separate_debug_file): Fix search of debug files for
2635         remote debuggee.
2636
2637 2019-01-02  Tom Tromey  <tom@tromey.com>
2638
2639         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2640         indentation.
2641         * python/py-frame.c (frapy_older): Remove cast.
2642         (frapy_newer): Likewise.
2643         * python/py-breakpoint.c (local_setattro): Remove cast.
2644         * python/py-arch.c (archpy_name): Remove local variable.
2645         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2646
2647 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2648
2649         * unittests/basic_string_view/element_access/char/empty.cc:
2650         Fix year range in copyright header.
2651
2652 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2653
2654         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2655         Delete.
2656         <operator==>: Update with for removed field.
2657         <hash>: Likewise.
2658         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2659         <isa_features>: ...this.
2660         <abi_features>: New field.
2661         (riscv_isa_flen): Update comment.
2662         (riscv_abi_xlen): New declaration.
2663         (riscv_abi_flen): New declaration.
2664         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2665         isa_features.
2666         (riscv_abi_xlen): New function.
2667         (riscv_isa_flen): Update to get answer from isa_features.
2668         (riscv_abi_flen): New function.
2669         (riscv_has_fp_abi): Update to get answer from abi_features.
2670         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2671         xlen and flen.
2672         (riscv_call_info) <xlen, flen>: Update comment.
2673         (riscv_call_arg_struct): Remove invalid assertions
2674         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2675         is removed.
2676         (riscv_gdbarch_init): Gather isa features and abi features
2677         separately, ensure both match on the gdbarch when reusing an old
2678         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2679         a target with 64-bit float hardware.
2680
2681 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2682
2683         * source.c (search_command_helper): Stop reverse search
2684         when line 1 has been searched.
2685
2686 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2687
2688         * record-full.c (record_full_base_target::close): Rewrite
2689         record_full_core_buf_list free logic.
2690
2691 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2692
2693         * break-catch-syscall.c (print_one_catch_syscall): xfree
2694         the last text.
2695
2696 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2697
2698         * top.c (print_gdb_version): Update Copyright year in version
2699         message.
2700
2701 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2702
2703         Update copyright year range in all GDB files.
2704
2705 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2706
2707         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2708
2709 For older changes see ChangeLog-2018.
2710 \f
2711 Local Variables:
2712 mode: change-log
2713 left-margin: 8
2714 fill-column: 74
2715 version-control: never
2716 coding: utf-8
2717 End:
2718