gdb/ChangeLog

   1 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
   2
   3         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
   4         suffix from warning message.
   5
   6 2019-08-30  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-winsource.h (struct tui_source_window_base)
   9         <refresh_all>: Don't declare.
  10         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
  11         Remove.
  12         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
  13         tui_show_locator_content.
  14         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
  15         declare.
  16         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
  17         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
  18         declare.
  19
  20 2019-08-30  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
  23
  24 2019-08-30  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-stack.c (_initialize_tui_stack): Move later.
  27         Remove unnecessary forward declarations.
  28
  29 2019-08-30  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
  32         rerender.
  33         (tui_update_locator_fullname, tui_show_frame_info): Don't call
  34         tui_show_locator_content.
  35
  36 2019-08-30  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
  39         (tui_locator_window::rerender): Rewrite using body of previous
  40         tui_show_locator_content.
  41
  42 2019-08-30  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
  45         set_locator_fullname>: New methods.
  46         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  47         Rename from tui_set_locator_fullname.
  48         (tui_locator_window::set_locator_info): Rename from
  49         tui_set_locator_info.  Return bool.
  50         (tui_update_locator_fullname, tui_show_frame_info): Update.
  51
  52 2019-08-30  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
  55
  56 2019-08-30  Tom Tromey  <tom@tromey.com>
  57
  58         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
  59         call touchwin.
  60
  61 2019-08-30  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-wingeneral.c (box_win): Assume win_info and
  64         win_info->handle cannot be NULL.
  65
  66 2019-08-30  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
  69         refresh_window>: Declare.
  70         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
  71         resize.
  72         (tui_data_item_window::rerender): Rename from
  73         tui_display_register.
  74         (tui_data_item_window::refresh_window): New method.
  75         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  76         no-op.
  77
  78 2019-08-30  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-regs.h (struct tui_data_window) <regs_content,
  81         regs_column_count, current_group>: Move later.  Now private.
  82         <get_current_group>: New method.
  83         * tui/tui-regs.c (tui_reg_command): Update.
  84         * tui/tui-layout.c (tui_set_layout): Update.
  85
  86 2019-08-30  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  89         (tui_data_window::rerender): Don't call
  90         check_and_display_highlight_if_needed.
  91         (tui_data_window::refresh_all): Remove call to
  92         erase_data_content.
  93
  94 2019-08-30  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  97         (tui_data_window::display_registers_from)
  98         (tui_data_window::display_reg_element_at_line)
  99         (tui_data_window::display_registers_from_line): Remove checks of
 100         "empty".
 101
 102 2019-08-30  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 105         Don't declare.
 106         * tui/tui-regs.c (tui_data_window::show_registers): Call
 107         rerender.
 108         (tui_data_window::rerender): Rename from display_all_data.
 109         (tui_data_window::rerender): Remove old implementation.
 110
 111 2019-08-30  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 114         text.
 115         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 116
 117 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 118             Sergio Durigan Junior  <sergiodj@redhat.com>
 119
 120         PR win32/24284
 121         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 122
 123 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 124
 125         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 126         when searching for types.
 127
 128 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 129
 130         * f-lang.c (f_language_defn): Use f_print_typedef.
 131         * f-lang.h (f_print_typedef): Declare.
 132         * f-typeprint.c (f_print_typedef): Define.
 133
 134 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 135
 136         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 137
 138 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 139
 140         * cli/cli-utils.c (info_print_options_defs): Delete.
 141         (make_info_print_options_def_group): Delete.
 142         (extract_info_print_options): Delete.
 143         (info_print_command_completer): Delete.
 144         (info_print_args_help): Add extra parameter, and optionally
 145         include text about -n flag.
 146         * cli/cli-utils.h (struct info_print_options): Delete.
 147         (extract_info_print_options): Delete declaration.
 148         (info_print_command_completer): Delete declaration.
 149         (info_print_args_help): Add extra parameter, extend header
 150         comment.
 151         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 152         search_symbols.
 153         * stack.c (struct info_print_options): New type.
 154         (info_print_options_defs): New file scoped variable.
 155         (make_info_print_options_def_group): New static function.
 156         (info_print_command_completer): New static function.
 157         (info_locals_command): Update to use new local functions.
 158         (info_args_command): Likewise.
 159         (_initialize_stack): Add extra parameter to calls to
 160         info_print_args_help.
 161         * symtab.c (search_symbols): Add extra parameter, use this to
 162         possibly excluse non-debug symbols.
 163         (symtab_symbol_info): Add extra parameter, which is passed on to
 164         search_symbols.
 165         (struct info_print_options): New type.
 166         (info_print_options_defs): New file scoped variable.
 167         (make_info_print_options_def_group): New static function.
 168         (info_print_command_completer): New static function.
 169         (info_variables_command): Update to use local functions, and pass
 170         extra parameter through to symtab_symbol_info.
 171         (info_functions_command): Likewise.
 172         (info_types_command): Pass additional argument through to
 173         symtab_symbol_info.
 174         (rbreak_command): Pass extra argument to search_symbols.
 175         (_initialize_symtab): Add extra arguments for calls to
 176         info_print_args_help, and update help text for 'info variables',
 177         'whereis', and 'info functions' commands.
 178         * symtab.h (search_symbols): Add extra argument to declaration.
 179         * NEWS: Mention new flags.
 180
 181 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 182
 183         * symtab.c (lookup_static_symbol): Call the new function (and move
 184         it down to be next to lookup_global_symbol).
 185         (struct global_sym_lookup_data): Add block_enum member and rename to...
 186         (struct global_or_static_sym_lookup_data): ...this.
 187         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 188         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 189         (lookup_symbol_global_or_static_iterator_cb): ...this.
 190         (lookup_global_or_static_symbol): New function.
 191         (lookup_global_symbol): Call new function.
 192
 193 2019-08-26  Tom de Vries  <tdevries@suse.de>
 194
 195         PR c++/24852
 196         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 197         when pc_probe.prob == NULL.
 198
 199 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 200
 201         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 202         variable symbol_linkage to symbol_linkage_.
 203
 204 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 205
 206         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 207         represent whether the symbol is static, dynamic, or we don't
 208         know.
 209
 210 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 211
 212         * gdb/rx-tdep.c (rx_register_names): New.
 213         (rx_register_name): Delete.
 214         (rx_psw_type): Delete.
 215         (rx_fpsw_type): Delete.
 216         (rx_register_type): Delete.
 217         (rx_gdbarch_init): Convert target-descriptions.
 218         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 219         * gdb/features/Makefile: Add rx.xml.
 220         * gdb/features/rx.xml: New.
 221         * gdb/features/rx.c: Generated.
 222         * gdb/NEWS: Mention target description support.
 223
 224 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 225
 226         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 227         *slot_ptr.
 228
 229 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 230
 231         * configure.ac: Don't check for 'dlfcn.h' (moved to
 232         gdbsupport/common.m4).
 233         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 234         'gdbsupport/'.
 235         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 236         * compile/compile-c-support.c: Include
 237         'gdbsupport/gdb-dlfcn.h'.
 238         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 239         * gdb-dlfcn.c: Move to...
 240         * gdbsupport/gdb-dlfcn.c: ... here.
 241         * gdb-dlfcn.h: Move to...
 242         * gdbsupport/gdb-dlfcn.h: ... here.
 243
 244 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 245
 246         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 247         the offset field signed.
 248
 249 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 250
 251         * python/lib/gdb/__init__.py (_execute_file): New function.
 252         * python/python.c (python_run_simple_file): Call gdb._execute_file
 253         on Windows.
 254
 255 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 256
 257         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 258         all uses as this was never set to anything but a zero value.
 259
 260 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 261
 262         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 263
 264 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 265
 266         * tui/tui-data.h (tui_gen_win_info): Add an =default
 267         move constructor, required by some GCC versions.
 268
 269 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 270
 271         * go32-nat.c (go32_sysinfo): Add hygon_p.
 272
 273 2019-08-20  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 276         line_from_reg_element_no, first_reg_element_no_inline,
 277         display_all_data, delete_data_content_windows,
 278         erase_data_content>: Now private.
 279
 280 2019-08-20  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 283         (tui_unhighlight_win, tui_highlight_win)
 284         (tui_win_info::make_window): Update.
 285         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 286
 287 2019-08-20  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 290         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 291         (MAX_PID_WIDTH): Move to tui-stack.c.
 292         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 293         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 294         (MAX_PID_WIDTH): Move from tui-data.h.
 295
 296 2019-08-20  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 299         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 300         (box_win): Update.
 301         (tui_gen_win_info::make_window): Rename from tui_make_window.
 302         (tui_win_info::make_window): New method.
 303         (tui_gen_win_info::make_visible): Update.
 304         * tui/tui-source.c (tui_source_window::set_contents): Update.
 305         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 306         (tui_data_window::display_registers_from): Update.
 307         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 308         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 309         Declare.
 310         <can_box>: Remove.
 311         <title>: Remove.
 312         (struct tui_win_info) <make_window>: Declare.
 313         <can_box>: Now virtual.
 314         <title>: New member.
 315         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 316         * tui/tui-command.c (tui_cmd_window::resize): Update.
 317
 318 2019-08-20  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 321         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 322         (tui_data_window::check_register_values): Update.
 323
 324 2019-08-20  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-regs.h (struct tui_data_window): Use
 327         DISABLE_COPY_AND_ASSIGN.
 328         <regs_content>: Change type, removing unique_ptr.
 329         <tui_data_window>: Add move constructor.
 330         * tui/tui-regs.c (tui_data_window::show_registers)
 331         (tui_data_window::show_register_group)
 332         (tui_data_window::display_registers_from)
 333         (tui_data_window::display_registers_from)
 334         (tui_data_window::first_data_item_displayed)
 335         (tui_data_window::delete_data_content_windows)
 336         (tui_data_window::rerender, tui_data_window::refresh_window)
 337         (tui_data_window::check_register_values): Update.
 338
 339 2019-08-20  Tom Tromey  <tom@tromey.com>
 340
 341         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 342         show_register_group>: Declare.
 343         (tui_show_register_group): Don't declare.
 344         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 345         tui_show_registers.
 346         (tui_data_window::show_register_group): Rename from
 347         tui_show_register_group.
 348         (tui_data_window::check_register_values, tui_reg_command):
 349         Update.
 350         * tui/tui-layout.c (tui_set_layout): Update.
 351
 352 2019-08-20  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 355         Declare.
 356         (tui_check_register_values): Don't declare.
 357         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 358         from tui_check_register_values.
 359         * tui/tui-hooks.c (tui_register_changed): Update.
 360
 361 2019-08-20  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-regs.c (tui_reg_layout): Move later.
 364         (tui_show_registers): Don't enable TUI mode or change layout.
 365
 366 2019-08-20  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-regs.h (struct tui_data_item_window)
 369         <~tui_data_item_window>: Remove.
 370         <content>: Now a unique_xmalloc_ptr.
 371         * tui/tui-regs.c (tui_register_format): Return a
 372         unique_xmalloc_ptr.
 373         (tui_get_register): Update.
 374         (~tui_data_item_window): Remove.
 375         (tui_data_window::display_registers_from, tui_display_register):
 376         Update.
 377         * tui/tui-io.h (tui_expand_tabs): Update.
 378         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 379         Remove "col" parameter.
 380
 381 2019-08-20  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 384         field.
 385         * tui/tui-regs.c (~tui_data_item_window): Update.
 386
 387 2019-08-20  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 390         earlier.
 391
 392 2019-08-20  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 395
 396 2019-08-20  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-source.h (struct tui_source_window): Update.
 399         * tui/tui-regs.c (tui_show_registers): Update.
 400         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 401         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 402         (NO_REGS_STRING): Remove defines.
 403
 404 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 405
 406         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 407         unnecessary thread walk if remote doesn't support the packet.
 408
 409 2019-08-19  Tom Tromey  <tromey@adacore.com>
 410
 411         * python/py-value.c (value_has_field): Fix indentation.
 412
 413 2019-08-19  Tom Tromey  <tromey@adacore.com>
 414
 415         * printcmd.c (do_one_display, info_display_command): Update.
 416         * block.h (contained_in): Return bool.  Add allow_nested
 417         parameter.
 418         * block.c (contained_in): Return bool.  Add allow_nested
 419         parameter.
 420
 421 2019-08-19  Tom Tromey  <tom@tromey.com>
 422
 423         * configure: Rebuild.
 424         * configure.ac: Disallow the combination of -static-libstdc++ and
 425         source highlight.
 426         * source-cache.c (get_language_name): Handle rust.
 427         (source_cache::get_source_lines): Ignore highlighting exceptions.
 428
 429 2019-08-16  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 432         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 433         (struct tui_source_window_base) <make_visible, refresh_window,
 434         resize>: Remove methods.
 435         <execution_info>: Remove field.
 436         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 437         (tui_show_source_line, tui_source_window_base)
 438         (~tui_source_window_base): Update.
 439         (tui_source_window_base::resize)
 440         (tui_source_window_base::make_visible)
 441         (tui_source_window_base::refresh_window): Remove.
 442         (tui_source_window_base::update_exec_info): Update.
 443         * tui/tui-source.c (tui_source_window::set_contents): Update.
 444         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 445
 446 2019-08-16  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 449         deprecated_query_hook.
 450
 451 2019-08-16  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 454         (tui_update_source_windows_with_line): Update.
 455         * tui/tui-source.h (struct tui_source_window)
 456         <show_symtab_source>: Declare.
 457         (tui_show_symtab_source): Don't declare.
 458         * tui/tui-source.c (tui_show_symtab_source): Rename from
 459         tui_show_symtab_source.
 460
 461 2019-08-16  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-winsource.h (struct tui_source_window_base)
 464         <set_contents>: Declare.
 465         * tui/tui-winsource.c
 466         (tui_source_window_base::update_source_window_as_is): Update.
 467         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 468         Declare.
 469         (tui_set_source_content): Don't declare.
 470         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 471         tui_set_source_content.
 472         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 473         Declare.
 474         (tui_set_disassem_content): Don't declare.
 475         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 476         tui_set_disassem_content.
 477
 478 2019-08-16  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-winsource.h (struct tui_source_window_base)
 481         <update_breakpoint_info>: Declare.
 482         (tui_update_breakpoint_info): Don't declare.
 483         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 484         (tui_update_all_breakpoint_info): Update.
 485         (tui_source_window_base::update_breakpoint_info): Rename from
 486         tui_update_breakpoint_info.
 487         (tui_source_window_base::update_exec_info): Update.
 488
 489 2019-08-16  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui-winsource.h (struct tui_source_window_base)
 492         <update_source_window>: Declare.
 493         (tui_update_source_window): Don't declare.
 494         * tui/tui-winsource.c
 495         (tui_source_window_base::update_source_window): Rename from
 496         tui_update_source_window.
 497         (tui_source_window_base::rerender): Update.
 498         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 499         * tui/tui-disasm.c (tui_show_disassem)
 500         (tui_show_disassem_and_update_source)
 501         (tui_disasm_window::maybe_update): Update.
 502
 503 2019-08-16  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-winsource.h (struct tui_source_window_base)
 506         <update_source_window_as_is>: Declare.
 507         (tui_update_source_window_as_is): Don't declare.
 508         * tui/tui-winsource.c (tui_update_source_window): Update
 509         (tui_source_window_base::update_source_window_as_is): Rename from
 510         tui_update_source_window_as_is.
 511         (tui_source_window_base::refill): Update.
 512         * tui/tui-source.c (tui_show_symtab_source): Update.
 513         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 514         Update.
 515
 516 2019-08-16  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-winsource.h (tui_update_source_window)
 519         (tui_update_source_window_as_is): Remove "noerror" parameter.
 520         * tui/tui-winsource.c (tui_update_source_window)
 521         (tui_update_source_window_as_is): Remove "noerror" parameter.
 522         (tui_update_source_windows_with_addr)
 523         (tui_update_source_windows_with_line)
 524         (tui_source_window_base::rerender)
 525         (tui_source_window_base::refill): Update.
 526         * tui/tui-source.h (tui_set_source_content)
 527         (tui_show_symtab_source): Remove "noerror" parameter.
 528         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 529         parameter.
 530         (tui_show_symtab_source): Likewise.
 531         (tui_source_window::maybe_update): Update.
 532         * tui/tui-disasm.c (tui_show_disassem)
 533         (tui_show_disassem_and_update_source)
 534         (tui_disasm_window::do_scroll_vertical)
 535         (tui_disasm_window::maybe_update): Update.
 536
 537 2019-08-16  Tom Tromey  <tom@tromey.com>
 538
 539         * tui/tui.c (tui_is_window_visible): Update.
 540         * tui/tui-wingeneral.c (tui_make_window)
 541         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 542         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 543         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 544         (tui_set_win_height_command, parse_scrolling_args): Update.
 545         * tui/tui-source.c (tui_source_window::style_changed): Update.
 546         * tui/tui-regs.c (tui_show_registers)
 547         (tui_data_window::first_data_item_displayed)
 548         (tui_data_window::delete_data_content_windows)
 549         (tui_check_register_values, tui_reg_command): Update.
 550         * tui/tui-disasm.c (tui_show_disassem): Update.
 551         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 552         method.
 553         <is_visible>: Remove field.
 554         * tui/tui-data.c (tui_next_win, tui_prev_win)
 555         (tui_delete_invisible_windows): Update.
 556
 557 2019-08-16  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-winsource.h (struct tui_source_window_base)
 560         <m_has_locator>: Remove.
 561         * tui/tui-layout.c (show_source_disasm_command, show_data)
 562         (show_source_or_disasm_and_command): Update.
 563
 564 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 565
 566         * NEWS (Other MI changes): New subsection.
 567         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 568         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 569         * arch-utils.c (default_get_pc_address_flags): New function.
 570         * arch-utils.h (default_get_pc_address_flags): New declaration.
 571         * gdbarch.sh: Add get_pc_address_flags.
 572         * gdbarch.c: Regenerate.
 573         * gdbarch.h: Likewise.
 574         * stack.c (print_pc): New function.
 575         (print_frame_info) (print_frame): Call print_pc.
 576
 577 2019-08-16  Tom de Vries  <tdevries@suse.de>
 578
 579         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 580         print_objfile_section_info.
 581
 582 2019-08-15  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 585         calling update_cmdwin_start_line.
 586         * tui/tui-winsource.h (struct tui_source_window_base)
 587         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 588         <rerender>: Declare.
 589         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 590         Call rerender.
 591         (tui_source_window_base::set_new_height): Remove.
 592         (tui_source_window_base::rerender): Rename from
 593         do_make_visible_with_new_height.
 594         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 595         resize method.
 596         (tui_win_info::make_invisible_and_set_new_height)
 597         (tui_win_info::make_visible_with_new_height): Remove.
 598         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 599         Declare.
 600         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 601         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 602         do_make_visible_with_new_height>: Don't declare.
 603         <rerender>: Declare.
 604         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 605         set_new_height.
 606         (tui_data_window::do_make_visible_with_new_height): Remove.
 607         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 608         call tui_show_locator_content.
 609         (tui_gen_win_info::resize): Call rerender.
 610         (show_source_or_disasm_and_command): Don't call
 611         tui_show_locator_content.
 612         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 613         method.
 614         (struct tui_win_info) <rerender>: Declare.
 615         <set_new_height, make_invisible_and_set_new_height,
 616         make_visible_with_new_height>: Don't declare.
 617         * tui/tui-data.c (tui_win_list::rerender): New method.
 618         * tui/tui-command.h (struct tui_cmd_window)
 619         <do_make_visible_with_new_height>: Don't declare.
 620         * tui/tui-command.c
 621         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 622
 623 2019-08-15  Tom Tromey  <tromey@adacore.com>
 624
 625         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 626         * ada-lang.c (ada_enum_name): Likewise.
 627
 628 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 629
 630         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 631         leading underscore.
 632         (GdbOutputErrorFile): Likewise.
 633         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 634         accordingly.
 635         (execute_unwinders): Rename to have a leading underscore.
 636         (auto_load_packages): Likewise.
 637         (global scope): Adjust call to auto_load_packages accordingly.
 638         (GdbSetPythonDirectory): Likewise.
 639         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 640         instead of execute_unwinders.
 641
 642 2019-08-15  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 645         (show_data): Don't change window visibility.
 646         (tui_gen_win_info::resize): Remove special case for command
 647         window.  Use wresize, when available.
 648         (show_source_or_disasm_and_command): Don't change window
 649         visibility.
 650         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 651         <make_visible>: New method.
 652         * tui/tui-command.c (tui_cmd_window::resize): New method.
 653
 654 2019-08-15  Tom Tromey  <tom@tromey.com>
 655
 656         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 657         (struct tui_source_windows): New.
 658         * tui/tui-winsource.c (tui_display_main): Update.
 659         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 660         (new_height_ok, parse_scrolling_args): Update.
 661         * tui/tui-layout.c (show_layout, show_data): Update.
 662         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 663         (tui_add_to_source_windows): Don't declare.
 664         * tui/tui-data.c (source_windows, tui_source_windows)
 665         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 666
 667 2019-08-15  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 670         Rename from reset.
 671         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 672         * tui/tui-layout.c (show_source_disasm_command, show_data):
 673         Update.
 674         (tui_gen_win_info::resize): Rename.
 675         (show_source_or_disasm_and_command): Update.
 676         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 677         reset.
 678
 679 2019-08-15  Tom Tromey  <tom@tromey.com>
 680
 681         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 682         * tui/tui-interp.c (tui_interp::init): Don't call
 683         tui_initialize_static_data.
 684         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 685
 686 2019-08-15  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 689         examine tui_win_list.
 690
 691 2019-08-15  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 694         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 695         tui_clear_source_content.
 696         (tui_clear_source_content): Remove.
 697         (tui_source_window_base::do_erase_source_content): Hoist call to
 698         content.clear().
 699         * tui/tui-stack.c (tui_show_frame_info): Don't call
 700         tui_clear_source_content.
 701
 702 2019-08-15  Tom Tromey  <tom@tromey.com>
 703
 704         * tui/tui-winsource.h (struct tui_source_window_base)
 705         <do_erase_source_content>: New method.
 706         <erase_source_content>: New method.
 707         (tui_erase_source_content): Don't declare.
 708         * tui/tui-winsource.c (tui_clear_source_content): Update.
 709         (tui_source_window_base::do_erase_source_content): Rename from
 710         tui_erase_source_content.
 711         (tui_source_window_base::show_source_content): Update.
 712         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 713         * tui/tui-source.h (struct tui_source_window)
 714         <erase_source_content>: New method.
 715         * tui/tui-disasm.h (struct tui_disasm_window)
 716         <erase_source_content>: New method.
 717
 718 2019-08-15  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 721         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 722         constructor.
 723         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 724         * tui/tui-source.c (tui_set_source_content): Update.
 725         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 726
 727 2019-08-15  Tom Tromey  <tom@tromey.com>
 728
 729         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 730         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 731         tui-source.c.
 732         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 733         Declare.
 734         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 735         method.
 736         (tui_source_window::maybe_update): Update.
 737
 738 2019-08-15  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 741         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 742         tui-disasm.c.
 743         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 744         Declare.
 745         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 746         method.
 747         (tui_disasm_window::maybe_update): Update.
 748
 749 2019-08-15  Tom Tromey  <tom@tromey.com>
 750
 751         * tui/tui-winsource.h (struct tui_source_window_base)
 752         <maybe_update>: Declare.
 753         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 754         method.
 755         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 756         Declare.
 757         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 758         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 759         Declare.
 760         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 761
 762 2019-08-15  Tom Tromey  <tom@tromey.com>
 763
 764         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 765
 766 2019-08-15  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-wingeneral.c: Include tui-stack.h.
 769         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 770         (struct tui_locator_window): Move from tui-data.h.
 771         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 772         (tui_initialize_static_data): Move from tui-data.c.
 773         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 774         (struct tui_locator_window): Move to tui-stack.c.
 775         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 776         (tui_initialize_static_data): Move to tui-stack.c.
 777
 778 2019-08-15  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui-layout.c (show_source_disasm_command)
 781         (show_source_or_disasm_and_command): Use make_visible method, not
 782         tui_make_window.
 783         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 784         Remove.
 785
 786 2019-08-15  Tom Tromey  <tom@tromey.com>
 787
 788         * tui/tui-wingeneral.h (tui_make_window): Update.
 789         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 790         parameter.
 791         (tui_gen_win_info::make_visible): Update.
 792         * tui/tui-regs.c (tui_data_window::display_registers_from):
 793         Update.
 794         * tui/tui-layout.c (show_source_disasm_command)
 795         (show_source_or_disasm_and_command): Update.
 796         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 797         (enum tui_box): Remove.
 798         (struct tui_win_info) <can_box>: New method.
 799         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 800         method.
 801
 802 2019-08-15  Tom de Vries  <tdevries@suse.de>
 803
 804         * linux-nat-trad.c: Include gdbarch.h.
 805
 806 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 807
 808         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 809         register sizes.
 810
 811 2019-08-14  Tom Tromey  <tromey@adacore.com>
 812
 813         * darwin-nat.c: Include gdbarch.h.
 814         * darwin-nat-info.c: Include gdbarch.h.
 815
 816 2019-08-13  Tom Tromey  <tom@tromey.com>
 817
 818         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 819         Remove.
 820         * tui/tui-data.c (tui_initialize_static_data): Update.
 821
 822 2019-08-13  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-winsource.h (struct tui_exec_info_window)
 825         <~tui_exec_info_window, maybe_allocate_content, get_content,
 826         m_content>: Remove.
 827         (struct tui_source_window_base) <set_exec_info_content,
 828         show_exec_info_content>: Don't declare.
 829         * tui/tui-winsource.c
 830         (tui_exec_info_window::maybe_allocate_content): Remove.
 831         (tui_source_window_base::update_exec_info): Rename from
 832         set_exec_info_content.
 833         (tui_source_window_base::show_exec_info_content)
 834         (tui_source_window_base::update_exec_info): Remove.
 835
 836 2019-08-13  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 839         declare.
 840         * tui/tui-winsource.c (tui_update_source_window_as_is)
 841         (tui_update_source_windows_with_addr, tui_erase_source_content):
 842         Update.
 843         (tui_clear_exec_info_content): Remove.
 844
 845 2019-08-13  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 848         declare.
 849         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 850         call tui_erase_exec_info_content.
 851         (tui_clear_exec_info_content): Rename from
 852         tui_erase_exec_info_content.
 853         (tui_clear_exec_info_content): Delete.
 854
 855 2019-08-13  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-winsource.h (struct tui_source_window_base)
 858         <show_exec_info_content>: Declare.
 859         (tui_show_exec_info_content): Don't declare.
 860         * tui/tui-winsource.c
 861         (tui_source_window_base::show_exec_info_content): Rename from
 862         tui_show_exec_info_content.
 863         (tui_source_window_base::update_exec_info): Update.
 864
 865 2019-08-13  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 868         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 869         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 870         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 871         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 872         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 873         ... here.
 874
 875 2019-08-13  Tom Tromey  <tom@tromey.com>
 876
 877         * tui/tui-winsource.h (struct tui_source_window_base)
 878         <update_exec_info>: Declare.
 879         (tui_update_exec_info): Don't declare.
 880         * tui/tui-winsource.c (tui_update_source_window_as_is)
 881         (tui_source_window_base::refresh_all)
 882         (tui_update_all_breakpoint_info): Update.
 883         (tui_source_window_base::update_exec_info): Rename from
 884         tui_update_exec_info.
 885         * tui/tui-stack.c (tui_show_frame_info): Update.
 886
 887 2019-08-13  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-winsource.h (struct tui_source_window_base)
 890         <set_exec_info_content>: Declare.
 891         (tui_set_exec_info_content): Don't declare.
 892         * tui/tui-winsource.c
 893         (tui_source_window_base::set_exec_info_content): Rename from
 894         tui_set_exec_info_content.
 895         (tui_update_exec_info): Update.
 896
 897 2019-08-13  Tom Tromey  <tom@tromey.com>
 898
 899         * tui/tui-winsource.h (struct tui_source_window_base)
 900         <show_source_content>: Declare.
 901         (tui_show_source_content): Don't declare.
 902         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 903         (tui_source_window_base::show_source_content): Rename from
 904         tui_show_source_content.
 905         (tui_source_window_base::refresh_all): Update.
 906         * tui/tui-layout.c (show_source_disasm_command)
 907         (show_source_or_disasm_and_command): Update.
 908
 909 2019-08-13  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-winsource.c (tui_erase_source_content)
 912         (tui_show_source_content, tui_source_window_base::refresh_all):
 913         Update.
 914         * tui/tui-wingeneral.h
 915         (tui_check_and_display_highlight_if_needed): Don't declare.
 916         * tui/tui-wingeneral.c
 917         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 918         check_and_display_highlight_if_needed.
 919         * tui/tui-win.c (tui_rehighlight_all)
 920         (tui_win_info::make_visible_with_new_height): Update.
 921         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 922         (tui_data_window::erase_data_content)
 923         (tui_data_window::display_all_data): Update.
 924         * tui/tui-data.h (struct tui_win_info)
 925         <check_and_display_highlight_if_needed>: Declare.
 926
 927 2019-08-13  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-win.c (tui_resize_all): Call
 930         tui_delete_invisible_windows.
 931         * tui/tui-layout.c (show_layout): Call
 932         tui_delete_invisible_windows.
 933         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 934         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 935
 936 2019-08-13  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 939         tui_add_win_to_layout.
 940
 941 2019-08-13  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 944         * tui/tui-layout.c (tui_default_win_height): Now static.
 945
 946 2019-08-13  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 949         single switch.
 950         (show_source_disasm_command, show_source_or_disasm_and_command):
 951         Don't check current layout.
 952
 953 2019-08-13  Tom Tromey  <tom@tromey.com>
 954
 955         * tui/tui-wingeneral.c (make_all_visible): Remove.
 956         (tui_make_all_invisible): Simplify.
 957         * tui/tui-layout.c (tui_make_all_invisible): Move from
 958         tui-wingeneral.c; simplify.
 959         (show_layout): Hoist call to tui_make_all_invisible.
 960         (show_data): Don't call tui_make_all_invisible.
 961
 962 2019-08-13  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 965         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 966
 967 2019-08-13  Tom Tromey  <tom@tromey.com>
 968
 969         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 970         tui-data.c.
 971         (show_source_disasm_command, show_data)
 972         (show_source_or_disasm_and_command): Don't use
 973         tui_set_current_layout_to.
 974         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 975         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 976         tui-layout.c.
 977         (tui_set_current_layout_to): Remove.
 978
 979 2019-08-13  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-layout.c (tui_set_layout): Update.
 982         * tui/tui-data.h (struct tui_layout_def): Remove.
 983         (tui_layout_def): Don't declare.
 984         * tui/tui-data.c (layout_def): Remove.
 985         (tui_layout_def): Remove.
 986
 987 2019-08-13  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-winsource.h (struct tui_source_window_base)
 990         <clear_detail>: No longer "override".
 991         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 992         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 993         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 994         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 995         Remove.
 996         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 997
 998 2019-08-13  Tom Tromey  <tromey@adacore.com>
 999
1000         * tracepoint.c: Don't include readline.h or history.h.
1001
1002 2019-08-12  Tom Tromey  <tom@tromey.com>
1003
1004         * configure: Rebuild.
1005         * configure.ac: Check for readline 7.
1006         * NEWS: Mention readline 7 requirement.
1007         * README: Update.
1008
1009 2019-08-12  Tom Tromey  <tom@tromey.com>
1010
1011         * mingw-hdep.c (gdb_select): Remove readline hack.
1012
1013 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1014
1015         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1016         when the function fails.
1017
1018 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1019
1020         * s390-tdep.c (s390_type_align): New function.
1021         (s390_gdbarch_init): Set it as type_align gdbarch method.
1022
1023 2019-08-09  Tom de Vries  <tdevries@suse.de>
1024
1025         PR gdb/24591
1026         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1027         pc_low with relocation offset.
1028
1029 2019-08-07  Tom Tromey  <tromey@adacore.com>
1030
1031         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1032         (print_frame_args): Update.
1033         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1034         Update.
1035         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1036         * frame.h (struct frame_arg): Add initializers.
1037         <error>: Now a unique_xmalloc_ptr.
1038
1039 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1040
1041         * NEWS: Expand the Pointer Authentication entry.
1042         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1043         (aarch64_frame_unmask_lr): ... to this.
1044         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1045         Call aarch64_frame_unmask_lr.
1046         * frame.c (struct frame_info): Add "masked" variable.
1047         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1048         (fprint_frame): Check for masked pc.
1049         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1050         declarations.
1051         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1052         * stack.c (print_frame): Check for masked pc.
1053
1054 2019-08-06  Tom Tromey  <tom@tromey.com>
1055
1056         * stabsread.c (patch_block_stabs, read_one_struct_field)
1057         (read_enum_type): Use obstack_strndup.
1058         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1059         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1060         * dwarf2read.c (guess_full_die_structure_name)
1061         (anonymous_struct_prefix): Use obstack_strndup.
1062         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1063         * c-exp.y (yylex): Use obstack_strndup.
1064         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1065         (write_var_or_type): Use obstack_strndup.
1066
1067 2019-08-06  Tom Tromey  <tom@tromey.com>
1068
1069         * symfile.c (reread_symbols): Use obstack_strdup.
1070         * stabsread.c (read_type): Use obstack_strdup.
1071         * gdb_obstack.h (obstack_strdup): New overload.
1072         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1073         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1074         (dwarf2_canonicalize_name): Use obstack_strdup.
1075         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1076         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1077         Use obstack_strdup.
1078
1079 2019-08-06  Tom Tromey  <tom@tromey.com>
1080
1081         * gdb_obstack.h (obstack_strdup): Define.
1082         * gdb_obstack.c (obstack_strdup): Don't define.
1083
1084 2019-08-06  Tom Tromey  <tom@tromey.com>
1085
1086         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1087         obstack_strdup.
1088         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1089         obstack_strdup.
1090         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1091         * stabsread.c (common_block_start): Use obstack_strdup.
1092         * objfiles.c (set_objfile_main_name, objfile): Use
1093         obstack_strdup.
1094         * namespace.c (add_using_directive): Use obstack_strdup.
1095         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1096         * jit.c (finalize_symtab): Use obstack_strdup.
1097         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1098         (guess_partial_die_structure_name, partial_die_info::fixup)
1099         (dwarf2_name): Use obstack_strdup.
1100         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1101         obstack_strdup.
1102         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1103         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1104         obstack_strdup.
1105         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1106
1107 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1108
1109         * unittests/help-doc-selftests.c: New file.
1110         * Makefile.in: Add the new file.
1111
1112 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1113
1114         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1115         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1116         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1117         the trailing '.' is not output, and the first character is uppercased.
1118         (print_help_for_command): Update call to print_doc_line.
1119         (print_doc_of_command): Likewise.
1120         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1121         * cli/cli-option.c (append_indented_doc): Do not append newline.
1122         (build_help_option): Append newline after first appended_indented_doc
1123         only if a second call is done.
1124         (build_help): Append 2 new lines before each option, except the first
1125         one.
1126         * compile/compile.c (_initialize_compile): Add new lines after
1127         %OPTIONS%, when not at the end of the help.
1128         Change help doc or code
1129         producing the help doc to respect the invariants.
1130         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1131         Also removed the new line after 'Options:', as all other commands
1132         do not put an empty line between 'Options:' and the first option.
1133         * printcmd.c (_initialize_printcmd): Likewise.
1134         * stack.c (_initialize_stack): Likewise.
1135         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1136         incorrectly telling COMMAND is optional.
1137         * ada-lang.c (_initialize_ada_language): Change help doc or code
1138         producing the help doc to respect the invariants.
1139         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1140         * breakpoint.c (_initialize_breakpoint): Likewise.
1141         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1142         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1143         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1144         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1145         _initialize_cli_style): Likewise.
1146         * corelow.c (core_target_info): Likewise.
1147         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1148         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1149         * filesystem.c (_initialize_filesystem): Likewise.
1150         * frame.c (_initialize_frame): Likewise.
1151         * gnu-nat.c (add_task_commands): Likewise.
1152         * infcall.c (_initialize_infcall): Likewise.
1153         * infcmd.c (_initialize_infcmd): Likewise.
1154         * interps.c (_initialize_interpreter): Likewise.
1155         * language.c (_initialize_language): Likewise.
1156         * linux-fork.c (_initialize_linux_fork): Likewise.
1157         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1158         * maint.c (_initialize_maint_cmds): Likewise.
1159         * memattr.c (_initialize_mem): Likewise.
1160         * printcmd.c (_initialize_printcmd): Likewise.
1161         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1162         _RegEx): Likewise.
1163         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1164         * record-btrace.c (_initialize_record_btrace): Likewise.
1165         * record-full.c (_initialize_record_full): Likewise.
1166         * record.c (_initialize_record): Likewise.
1167         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1168         * regcache.c (_initialize_regcache): Likewise.
1169         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1170         _initialize_remote): Likewise.
1171         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1172         * serial.c (_initialize_serial): Likewise.
1173         * skip.c (_initialize_step_skip): Likewise.
1174         * source.c (_initialize_source): Likewise.
1175         * stack.c (_initialize_stack): Likewise.
1176         * symfile.c (_initialize_symfile): Likewise.
1177         * symtab.c (_initialize_symtab): Likewise.
1178         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1179         * top.c (init_main): Likewise.
1180         * tracefile-tfile.c (tfile_target_info): Likewise.
1181         * tracepoint.c (_initialize_tracepoint): Likewise.
1182         * tui/tui-win.c (_initialize_tui_win): Likewise.
1183         * utils.c (add_internal_problem_command): Likewise.
1184         * valprint.c (value_print_option_defs): Likewise.
1185
1186 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1187
1188         PR build/24886
1189         * configure.ac: Drop enable-libmcheck support.
1190         * configure, config.in: Rebuild.
1191         * libmcheck.m4: Remove.
1192         * acinclude.m4: Don't include it.
1193         * Makefile.in: Don't distribute it.
1194         * top.c (print_gdb_configuration): Don't mention it.
1195
1196 2019-08-06  Tom Tromey  <tom@tromey.com>
1197
1198         * utils.c (set_output_style): Sometimes pass stream to
1199         emit_style_escape.
1200         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1201         * record-btrace.c (btrace_insn_history): Update.
1202         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1203         method.
1204         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1205         Update initializers.
1206         <m_uiout>: New field.
1207         <m_di>: Move lower.
1208         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1209         Remove "uiout" parameter.
1210         (dump_insns): Update.
1211         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1212         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1213
1214 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1215
1216         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1217         (error_in_psymtab_expansion): Likewise.
1218         (lookup_symbol_via_quick_fns): Likewise.
1219         (basic_lookup_transparent_type_quick): Likewise.
1220         (basic_lookup_transparent_type_1): Likewise.
1221
1222 2019-08-06  Tom Tromey  <tromey@adacore.com>
1223
1224         * source.c (last_source_error): Now bool.
1225         (print_source_lines_base): Make "noprint" bool.  Only open
1226         source file when last_source_visited changes.
1227
1228 2019-08-06  Tom Tromey  <tromey@adacore.com>
1229
1230         * annotate.c (annotate_source_line): Use g_source_cache.
1231         * source-cache.c (source_cache::get_plain_source_lines): Change
1232         parameters.  Populate m_offset_cache.
1233         (source_cache::ensure): New method.
1234         (source_cache::get_line_charpos): New method.
1235         (extract_lines): Move lower.  Change parameters.
1236         (source_cache::get_source_lines): Move lower.
1237         * source-cache.h (class source_cache): Update comment.
1238         <get_line_charpos>: New method.
1239         <get_source_lines>: Update comment.
1240         <clear>: Clear m_offset_cache.
1241         <get_plain_source_lines>: Change parameters.
1242         <ensure>: New method
1243         <m_offset_cache>: New member.
1244         * source.c (forget_cached_source_info_for_objfile): Update.
1245         (info_source_command): Use g_source_cache.
1246         (find_source_lines, open_source_file_with_line_charpos): Remove.
1247         (print_source_lines_base, search_command_helper): Use g_source_cache.
1248         * source.h (open_source_file_with_line_charpos): Don't declare.
1249         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1250         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1251         Use g_source_cache.
1252
1253 2019-08-06  Tom Tromey  <tromey@adacore.com>
1254
1255         * source-cache.c (source_cache::get_plain_source_lines):
1256         Remove "first_line" and "last_line" parameters.
1257         (source_cache::get_source_lines): Cache plain text.
1258         * source-cache.h (class source_cache)
1259         <get_plain_source_lines>: Update.
1260
1261 2019-08-06  Tom Tromey  <tromey@adacore.com>
1262
1263         * source-cache.c (extract_lines): No longer a method.
1264         Changed type of parameter.  Include final newline.
1265         (selftests::extract_lines_test): New function.
1266         (_initialize_source_cache): Likewise.
1267         * source-cache.h (class source_cache)
1268         <extract_lines>: Don't declare.
1269
1270 2019-08-06  Tom Tromey  <tromey@adacore.com>
1271
1272         * breakpoint.c (init_breakpoint_sal): Update.
1273         (breakpoint): Update.
1274         * breakpoint.h (struct breakpoint) <filter>: Now a
1275         unique_xmalloc_ptr.
1276
1277 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1278
1279         * NEWS: Mention dictionary access on blocks.
1280         * python/py-block.c (blpy_getitem): New function.
1281         (block_object_as_mapping): New struct.
1282         (block_object_type): Use new struct for tp_as_mapping field.
1283
1284 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1285
1286         * objfiles.h (objfile): Add a comment describing partial symbols.
1287
1288 2019-08-05  Tom Tromey  <tromey@adacore.com>
1289
1290         * compile/compile.c (_initialize_compile): Use _(), not N_().
1291         * thread.c (_initialize_thread): Use _(), not N_().
1292         * stack.c (_initialize_stack): Use _(), not N_().
1293         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1294
1295 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1296
1297         * dwarf2read.c (struct dw2_symtab_iterator):
1298         <want_specific_block>: Remove.
1299         <block_index>: Change type to gdb::optional.
1300         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1301         change type of BLOCK_INDEX parameter to gdb::optional.
1302         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1303         (dw2_lookup_symbol): Don't pass argument for
1304         WANT_SPECIFIC_BLOCK.
1305         (dw2_expand_symtabs_for_function): Don't pass argument for
1306         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1307         (class dw2_debug_names_iterator)
1308         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1309         parameter, change BLOCK_INDEX type to gdb::optional.
1310         <m_want_specific_block>: Remove.
1311         <m_block_index>: Change type to gdb::optional.
1312         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1313         gdb::optional.  Re-write in function of gdb::optional.
1314         (dw2_debug_names_lookup_symbol): Don't pass argument for
1315         WANT_SPECIFIC_BLOCK.
1316         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1317         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1318         BLOCK_INDEX.
1319
1320 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1321
1322         * NEWS: Mention changes to "info sources" command.
1323
1324 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1325
1326         * symtab.c (filename_partial_match_opts): New struct type.
1327         (struct output_source_filename_data): New members
1328         regexp, c_regexp, partial_match.
1329         (output_source_filename): Use new members to decide to print file.
1330         (info_sources_option_defs): New variable.
1331         (make_info_sources_options_def_group, print_info_sources_header,
1332         info_sources_command_completer):
1333         New functions.
1334         (info_sources_command): Read new optional arguments.
1335         (_initialize_symtab): Update info sources help.
1336
1337 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1338
1339         * ada-lang.c (exception_support_info_v0): Renamed from...
1340         (default_exception_support_info): ... this.  Create new
1341         definition for v1.
1342         (ada_has_this_exception_support): Look up catch_handlers_sym.
1343         (ada_exception_support_info_sniffer): Try v0 after default.
1344
1345 2019-08-01  Tom Tromey  <tromey@adacore.com>
1346
1347         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1348         gdbarch.h.
1349
1350 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1351
1352         * s12z-tdep.c: Fix include path for s12z-opc.h.
1353
1354 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1355
1356         * NEWS: Require GNU make 3.82.
1357
1358 2019-07-16  Tom Tromey  <tom@tromey.com>
1359
1360         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1361         declare.
1362
1363 2019-07-30  Tom Tromey  <tromey@adacore.com>
1364
1365         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1366
1367 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1368
1369         * printcmd.c (print_address_symbolic): Print negative offsets.
1370         (build_address_symbolic): Force signed arithmetic when computing
1371         offset.
1372
1373 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1374
1375         PR/24474: Add a function to lookup static variables.
1376         * NEWS: Mention this new function.
1377         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1378         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1379         * python/python.c (python_GdbMethods): Add new function.
1380
1381 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1382
1383         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1384         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1385         (objfpy_lookup_static_symbol): New function.
1386         (objfile_object_methods): Add new functions.
1387
1388 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1389
1390         * NEWS: Mention 'set|show print frame-info'.  Mention new
1391         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1392         backtrace argument.  Mention that python frame filtering code
1393         is now consistent with what 'backtrace' command prints.
1394
1395 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1396
1397         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1398         comments.
1399         (print_frame_info_auto, print_frame_info_source_line,
1400         print_frame_info_location, print_frame_info_source_and_location,
1401         print_frame_info_location_and_address, print_frame_info_short_location):
1402         New declarations.
1403         (struct frame_print_options): New member print_frame_info.
1404         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1405         * stack.h (get_user_print_what_frame_info): New declaration.
1406         (frame_show_address): New declaration.
1407         * stack.c (print_frame_arguments_choices): New value 'presence'.
1408         (print_frame_info_auto, print_frame_info_source_line,
1409         print_frame_info_location, print_frame_info_source_and_location,
1410         print_frame_info_location_and_address, print_frame_info_short_location,
1411         print_frame_info_choices, print_frame_info_print_what): New definitions.
1412         (print_frame_args): Only print dots for args if print frame-arguments
1413         is 'presence'.
1414         (frame_print_option_defs): New element for "frame-info".
1415         (get_user_print_what_frame_info): New function.
1416         (frame_show_address): Make non static.  Move comment to stack.h.
1417         (print_frame_info_to_print_what): New function.
1418         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1419         to decide what to print.
1420         (backtrace_command_1): Handle the new print_frame_arguments_presence
1421         value.
1422         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1423         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1424         (py_print_frame): In non-mi mode, use LOCATION as default for
1425         print_what, similarly to frame information printed directly by
1426         backtrace command. Handle frame-info user option in non MI mode.
1427
1428 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1429
1430         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1431         Add case for debugging 32-bit target on 64-bit host.  Revise
1432         comment.
1433
1434 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1435
1436         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1437         instead of find_function_entry_range_from_pc.
1438
1439 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1440
1441         * stack.c (find_frame_funname): Remove code which preferred
1442         minsym over symtab sym in "certain pathological cases".
1443
1444         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1445         parameter.  Change type of "do_demangle" to bool.
1446         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1447         Pass suitable "prefer_sym_over_minsym" flag to
1448         build_address_symbolic().  Don't output "+" for negative offsets.
1449         * printcmd.c (print_address_symbolic): Update invocation of
1450         build_address_symbolic to include a "prefer_sym_over_minsym"
1451         flag.
1452         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1453         Restrict cases in which use of minimal symbol is preferred to that
1454         of a found symbol.  Update comments.
1455
1456         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1457         for entry pc when entry pc is out of range for that FDE.
1458
1459 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1460
1461         PR gdb/24839:
1462         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1463         type.
1464
1465 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1466
1467         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1468         this function's Python signature.
1469
1470
1471 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1472
1473         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1474         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1475         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1476         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1477         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1478
1479
1480 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1481
1482         * h8300-tdep.c (h8300_register_name_common): New.
1483         h8300_register_name): Use h8300_register_name_common.
1484         (h8300s_register_name): Likewise.
1485         (h8300sx_register_name): Likewise.
1486         (h8300h_register_nam): New.
1487         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1488
1489
1490 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1491
1492         * arm-tdep.c (arm_skip_cmse_entry): New function.
1493         (arm_is_sgstubs_section): New function.
1494         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1495
1496 2019-07-22  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1499         Don't self-assign.
1500
1501 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1504         type_print.
1505
1506 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1507
1508         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1509         so that GDB doesn't match any msymbols when searching in the
1510         TYPES_DOMAIN.
1511         (print_symbol_info): Print using typedef_print or type_print based
1512         on the type of the symbol.  Add updated FIXME comment moved from...
1513         (_initialize_symtab): ... move and update FIXME comment to above.
1514
1515 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1516
1517         * NEWS: Mention adding -q option to "info types".
1518         * symtab.c (struct info_types_options): New struct.
1519         (info_types_options_defs): New variable.
1520         (make_info_types_options_def_group): New function.
1521         (info_types_command): Use gdb::option framework to parse options.
1522         (info_types_command_completer): New function.
1523         (_initialize_symtab): Extend the help text on "info types" and
1524         register command completer.
1525
1526 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1527
1528         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1529         (lookup_symbol_in_objfile): Change int to block_enum and add a
1530         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1531
1532 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1533
1534         * MAINTAINERS (Write After Approval): Add self.
1535
1536 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1537
1538         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1539         instruction to the dummy code region.
1540
1541 2019-07-19  Tom Tromey  <tromey@adacore.com>
1542
1543         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1544         (ARGSUSED, PARAMS, __func__): Remove rules.
1545
1546 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1547
1548         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1549         * features/arm/arm-with-iwmmxt.c: Remove.
1550         * features/arm/arm-with-iwmmxt.xml: Remove.
1551         * features/arm/arm-with-m-fpa-layout.c: Remove.
1552         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1553         * features/arm/arm-with-m-vfp-d16.c: Remove.
1554         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1555         * features/arm/arm-with-m.c: Remove.
1556         * features/arm/arm-with-m.xml: Remove.
1557         * features/arm/arm-with-neon.c: Remove.
1558         * features/arm/arm-with-neon.xml: Remove.
1559         * features/arm/arm-with-vfpv2.c: Remove.
1560         * features/arm/arm-with-vfpv2.xml: Remove.
1561         * features/arm/arm-with-vfpv3.c: Remove.
1562         * features/arm/arm-with-vfpv3.xml: Remove.
1563
1564 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1565
1566         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1567
1568 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1569
1570         * arch/aarch32.c (aarch32_create_target_description): Create
1571         target descriptions using features.
1572         * arch/arm.c (arm_create_target_description)
1573         (arm_create_mprofile_target_description): Likewise.
1574         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1575
1576 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1577
1578         * Makefile.in: Add new files.
1579         * aarch32-tdep.c: New file.
1580         * aarch32-tdep.h: New file.
1581         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1582         Call aarch32_read_description.
1583         * arch/aarch32.c: New file.
1584         * arch/aarch32.h: New file.
1585         * arch/arm.c (arm_create_target_description)
1586         (arm_create_mprofile_target_description): New function.
1587         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1588         (arm_create_target_description)
1589         (arm_create_mprofile_target_description): New declaration.
1590         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1591         read_description functions.
1592         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1593         Likewise.
1594         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1595         * arm-tdep.c (tdesc_arm_list): New variable.
1596         (arm_register_g_packet_guesses): Call create description functions.
1597         (arm_read_description) (arm_read_mprofile_description): New
1598         function.
1599         * arm-tdep.h (arm_read_description)
1600         (arm_read_mprofile_description): Add declaration.
1601         * configure.tgt: Add new files.
1602
1603 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1604
1605         * top.c (new_ui_command): Open specified terminal just once.
1606
1607 2019-07-18  Tom Tromey  <tromey@adacore.com>
1608
1609         * symtab.c (main_name): Constify return type.
1610         * symfile.c (set_initial_language): Update.
1611         * symtab.h (main_name): Constify return type.
1612
1613 2019-07-17  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-winsource.c (tui_update_source_window)
1616         (tui_update_source_window_as_is)
1617         (tui_update_source_windows_with_line): Remove return.
1618         * tui/tui-disasm.c (tui_show_disassem)
1619         (tui_show_disassem_and_update_source): Remove return.
1620         * tui/tui.c (tui_reset): Remove return.
1621         * tui/tui-wingeneral.c
1622         (tui_check_and_display_highlight_if_needed): Remove return.
1623
1624 2019-07-17  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1627
1628 2019-07-17  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-winsource.h (struct tui_exec_info_window)
1631         (struct tui_source_window_base): Move from tui-data.h.
1632         * tui/tui-winsource.c: Move many method definitions from
1633         elsewhere.  Remove "structuring" comments.
1634         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1635         (tui_source_window_base::refresh_window): Move to
1636         tui-winsource.c.
1637         * tui/tui-win.c (tui_source_window_base::refresh_all)
1638         (tui_source_window_base::update_tab_width)
1639         (tui_source_window_base::set_new_height)
1640         (tui_source_window_base::do_make_visible_with_new_height): Move to
1641         tui-winsource.c.
1642         * tui/tui-source.h: Update.
1643         * tui/tui-source.c (tui_source_window_base::reset): Move to
1644         tui-winsource.c.
1645         * tui/tui-disasm.h: Update.
1646         * tui/tui-data.h (struct tui_exec_info_window): Move to
1647         tui-winsource.h.
1648         (struct tui_source_window_base): Likewise.
1649         * tui/tui-data.c (tui_source_window_base::clear_detail)
1650         (tui_source_window_base, ~tui_source_window_base): Move to
1651         tui-winsource.c.
1652
1653 2019-07-17  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui-win.c (tui_resize_all)
1656         (tui_source_window_base::update_tab_width)
1657         (tui_adjust_win_heights): Update.
1658         (tui_win_info::make_invisible_and_set_new_height): Rename from
1659         make_invisible_and_set_new_height.
1660         * tui/tui-data.h (struct tui_win_info)
1661         <make_invisible_and_set_new_height>: New method.
1662
1663 2019-07-17  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui.c: Update.
1666         * tui/tui-source.h (struct tui_source_window): Move from
1667         tui-data.h.
1668         * tui/tui-layout.c: Update.
1669         * tui/tui-disasm.c: Update.
1670         * tui/tui-data.h (struct tui_source_window): Move to
1671         tui-source.h.
1672
1673 2019-07-17  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1676         tui-data.h.
1677         * tui/tui-data.h (struct tui_disasm_window): Move to
1678         tui-disasm.h.
1679
1680 2019-07-17  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-regs.h (struct tui_data_item_window): Move from
1683         tui-data.h.
1684         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1685         * tui/tui-data.h (struct tui_data_item_window): Move to
1686         tui-regs.h.
1687         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1688
1689 2019-07-17  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui.c: Update.
1692         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1693         (tui_cmd_window::max_height): Move to tui-command.c.
1694         * tui/tui-layout.c: Update.
1695         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1696         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1697         tui-command.c.
1698         * tui/tui-command.h (struct tui_cmd_window): Move from
1699         tui-data.h.
1700         * tui/tui-command.c: Remove "structuring" comments.
1701         (tui_cmd_window::clear_detail)
1702         (tui_cmd_window::do_make_visible_with_new_height)
1703         (tui_cmd_window::max_height): Move from elsewhere.
1704
1705 2019-07-17  Tom Tromey  <tom@tromey.com>
1706
1707         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1708         Now static.
1709         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1710         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1711
1712 2019-07-17  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui.c: Update.
1715         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1716         tui-regs.c.
1717         * tui/tui-windata.h: Remove file.
1718         * tui/tui-windata.c: Remove file.
1719         * tui/tui-win.c (tui_data_window::set_new_height)
1720         (tui_data_window::do_make_visible_with_new_height): Move to
1721         tui-regs.c.
1722         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1723         * tui/tui-regs.c: Remove "structuring" comments.
1724         (tui_data_window::first_data_item_displayed)
1725         (tui_data_window::delete_data_content_windows)
1726         (tui_data_window::erase_data_content)
1727         (tui_data_window::display_all_data)
1728         (tui_data_window::refresh_all)
1729         (tui_data_window::do_scroll_vertical)
1730         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1731         (tui_data_window::do_make_visible_with_new_height)
1732         (tui_data_window::refresh_window): Move from elsewhere.
1733         (_initialize_tui_regs): Move to end of file.
1734         * tui/tui-layout.c: Update.
1735         * tui/tui-hooks.c: Update.
1736         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1737         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1738         tui-regs.c.
1739         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1740
1741 2019-07-17  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1744         seen.
1745
1746 2019-07-17  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-win.c (tui_source_window_base::set_new_height)
1749         (tui_source_window_base::do_make_visible_with_new_height): Use
1750         m_has_locator field directly.
1751         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1752         method.
1753         (struct tui_source_window_base) <has_locator>: Likewise.
1754
1755 2019-07-17  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1758         Don't declare.
1759         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1760         Remove.
1761         * tui/tui-win.c (tui_source_window_base::set_new_height)
1762         (tui_source_window_base::set_new_height)
1763         (make_invisible_and_set_new_height)
1764         (tui_source_window_base::do_make_visible_with_new_height)
1765         (tui_source_window_base::do_make_visible_with_new_height):
1766         Update.
1767         * tui/tui-layout.c (show_source_disasm_command, show_data)
1768         (show_source_or_disasm_and_command): Update.
1769         * tui/tui-layout.c (show_layout): Update.
1770
1771 2019-07-17  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-layout.c (make_data_window): Remove.
1774         (show_data): Unify creation and re-initialization cases.
1775
1776 2019-07-17  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-layout.c (make_source_window, make_disasm_window):
1779         Remove.
1780         (show_data): Unify creation and re-initialization cases.
1781
1782 2019-07-17  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-layout.c (make_command_window): Remove.
1785         (show_source_disasm_command, show_source_or_disasm_and_command):
1786         Unify creation and re-initialization cases.
1787
1788 2019-07-17  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1791         creation and re-initialization cases.
1792
1793 2019-07-17  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-regs.c (tui_get_register): Return void.
1796
1797 2019-07-17  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1800         Simplify.
1801
1802 2019-07-17  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1805         resetting.
1806
1807 2019-07-17  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1810         * tui/tui-regs.c (tui_reg_layout): New function.
1811         (tui_show_registers, tui_reg_command): Use it.
1812         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1813         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1814         parameters.
1815         (tui_layout_command): Remove.
1816
1817 2019-07-17  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-layout.h (tui/tui-layout): Return void.
1820         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1821
1822 2019-07-17  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-layout.c (show_source_disasm_command, show_data):
1825         Update.
1826         (reset_locator): Remove.
1827         (show_source_or_disasm_and_command): Update.
1828
1829 2019-07-17  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-source.c (tui_source_window_base::reset): Remove
1832         win_type parameter.
1833         * tui/tui-layout.c (make_command_window, make_source_window)
1834         (make_disasm_window, make_data_window)
1835         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1836         (reset_locator, show_source_or_disasm_and_command): Update.
1837         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1838         win_type parameter.
1839         (struct tui_source_window_base) <reset>: Likewise.
1840
1841 2019-07-17  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui-layout.c (show_source_disasm_command): Use
1844         reset_locator.
1845         (reset_locator): New function.
1846         (init_and_make_win): Remove.
1847         (show_source_or_disasm_and_command): Use reset_locator.
1848
1849 2019-07-17  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1852         condition.
1853         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1854         Remove condition.
1855         * tui/tui-source.c (tui_source_window_base::reset): New method.
1856         * tui/tui-layout.c (make_command_window): Don't call
1857         init_and_make_win.
1858         (make_source_window, make_disasm_window): Don't call
1859         make_source_or_disasm_window.
1860         (make_data_window): Don't call init_and_make_win.  Change calling
1861         convention.
1862         (show_source_disasm_command, show_data): Simplify.
1863         (make_source_or_disasm_window): Remove.
1864         (show_source_or_disasm_and_command): Simplify.
1865         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1866         (struct tui_source_window_base) <reset>: Likewise.
1867         <execution_info>: Remove initializer.
1868         * tui/tui-data.c (tui_source_window_base): Initialize
1869         execution_info.
1870
1871 2019-07-17  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1874         variable.
1875
1876 2019-07-17  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui.c (tui_rl_other_window): Update.
1879         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1880         superclass method first.  Always iterate over regs_content.
1881         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1882         method.
1883         * tui/tui-win.c (tui_set_focus_command): Update.
1884
1885 2019-07-17  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-win.c (tui_set_focus_command): Rename from
1888         tui_set_focus.  Call tui_enable.
1889         (tui_set_focus_command): Remove.
1890
1891 2019-07-17  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1894         refresh_window.
1895         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1896         touchwin.
1897         (tui_data_window::refresh_window): Call refresh_window on data
1898         items.  Always call superclass refresh_window.
1899         (tui_win_info::refresh): Remove.
1900         (tui_source_window_base::refresh_window): Update.
1901         (tui_refresh_all): Update.
1902         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1903         refresh_window.
1904         (show_source_or_disasm_and_command): Likewise.
1905         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1906         (struct tui_source_window_base) <refresh>: Likewise.
1907
1908 2019-07-17  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-winsource.c (tui_clear_source_content)
1911         (tui_show_source_content): Update.
1912         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1913         whether content is empty.
1914         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1915         Remove.
1916
1917 2019-07-17  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1920         window's contents.
1921         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1922         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1923
1924 2019-07-17  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1927         (struct tui_data_item_window): Update.
1928
1929 2019-07-17  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1932         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1933         defines.
1934
1935 2019-07-17  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-winsource.h (tui_erase_source_content)
1938         (tui_clear_source_content): Remove "display_prompt" parameter.
1939         * tui/tui-winsource.c (tui_update_source_window_as_is)
1940         (tui_update_source_windows_with_addr): Update.
1941         (tui_clear_source_content): Remove "display_prompt" parameter.
1942         (tui_erase_source_content): Likewise.  Simplify.
1943         (tui_show_source_content): Update.
1944         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1945         * tui/tui-stack.c (tui_show_frame_info): Update.
1946         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1947         Remove defines.
1948
1949 2019-07-17  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1952         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1953         parameter.
1954         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1955         parameter.
1956
1957 2019-07-17  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-winsource.c (tui_clear_source_content)
1960         (tui_show_source_content, tui_show_exec_info_content)
1961         (tui_clear_exec_info_content): Update.
1962         * tui/tui-stack.c (tui_show_locator_content): Update.
1963         (tui_show_frame_info): Update.
1964         * tui/tui-source.h (tui_source_window): Don't declare.
1965         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1966         from tui_source_is_displayed.
1967         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1968         Remove field.
1969         (struct tui_source_window_base) <content_in_use>: New field.  Now
1970         bool.
1971         (struct tui_source_window) <showing_source_p>: New method.
1972         (TUI_SRC_WIN): Change cast.
1973         * tui/tui-data.c (tui_initialize_static_data): Update.
1974
1975 2019-07-17  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1978         location_matches_p.
1979         * tui/tui-source.c (tui_source_window::location_matches_p): New
1980         method.
1981         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1982         method.
1983         * tui/tui-data.h (struct tui_source_window_base)
1984         <location_matches_p>: New method.
1985         (struct tui_source_window, struct tui_disasm_window)
1986         <location_matches_p>: Likewise.
1987
1988 2019-07-17  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-win.c (tui_set_win_height_command): Rename from
1991         tui_set_win_height.
1992         (tui_set_win_height_command): Remove.
1993
1994 2019-07-17  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui-source.c (tui_source_window): New constructor.  Add
1997         observer.
1998         (~tui_source_window): New destructor.
1999         (tui_source_window::style_changed): New method.
2000         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2001         (tui_attach_detach_observers): Update.
2002         * tui/tui-data.h (struct tui_source_window): Make constructor not
2003         inline.  Add destructor.
2004         (struct tui_source_window) <style_changed>: New method.
2005         <m_observable>: New member.
2006
2007 2019-07-17  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2010         * tui/tui-win.c (tui_resize_all): Fix typo.
2011
2012 2019-07-17  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2015         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2016         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2017         * tui/tui-win.c (window_name_completer): Use foreach.
2018         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2019         (update_tab_width): Likewise.
2020         * tui/tui-layout.c (show_layout): Update.
2021         * tui/tui-data.h (class tui_window_iterator): New.
2022         (struct all_tui_windows): New.
2023         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2024
2025 2019-07-17  Tom Tromey  <tom@tromey.com>
2026
2027         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2028         parameter.  Don't reference globals.
2029         (tui_reg_command): Update.
2030
2031 2019-07-17  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-regs.c (tui_show_registers): Simplify.
2034
2035 2019-07-17  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-regs.c (tui_show_registers): Update.
2038         (tui_show_register_group): Add win_info parameter.
2039
2040 2019-07-17  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2043         Rename from tui_display_reg_element_at_line.
2044         (tui_data_window::display_registers_from_line): Update.
2045         * tui/tui-data.h (struct tui_data_window)
2046         <display_reg_element_at_line>: New method.
2047
2048 2019-07-17  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-regs.h (tui_display_registers_from)
2051         (tui_display_registers_from_line): Don't declare.
2052         * tui/tui-windata.c (tui_data_window::display_all_data)
2053         (tui_data_window::refresh_all)
2054         (tui_data_window::do_scroll_vertical): Update.
2055         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2056         from tui_display_registers_from.
2057         (tui_display_reg_element_at_line): Update.
2058         (tui_data_window::display_registers_from_line): Rename from
2059         tui_display_registers_from_line.
2060         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2061         display_registers_from_line>: New methods.
2062
2063 2019-07-17  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2066         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2067         from tui_erase_data_content.
2068         (tui_data_window::display_all_data)
2069         (tui_data_window::refresh_all)
2070         (tui_data_window::do_scroll_vertical): Update.
2071         * tui/tui-regs.c (tui_show_registers): Update.
2072         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2073         New method.
2074
2075 2019-07-17  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2078         declare.
2079         * tui/tui-windata.c
2080         (tui_data_window::delete_data_content_windows): Rename from
2081         tui_delete_data_content_windows.
2082         (tui_data_window::display_all_data)
2083         (tui_data_window::do_scroll_vertical): Update.
2084         * tui/tui-data.h (struct tui_data_window)
2085         <delete_data_content_windows>: New method.
2086
2087 2019-07-17  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2090         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2091
2092 2019-07-17  Tom Tromey  <tom@tromey.com>
2093
2094         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2095         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2096         from tui_display_all_data.
2097         * tui/tui-win.c
2098         (tui_data_window::do_make_visible_with_new_height): Update.
2099         * tui/tui-regs.c (tui_show_registers): Update.
2100         * tui/tui-layout.c (tui_set_layout): Update.
2101         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2102         method.
2103
2104 2019-07-17  Tom Tromey  <tom@tromey.com>
2105
2106         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2107         * tui/tui-windata.c (tui_display_data_from): Remove.
2108         (tui_data_window::refresh_all): Update.
2109
2110 2019-07-17  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2113         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2114         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2115         tui_display_registers_from_line.
2116         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2117         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2118         "force_display" parameter.
2119
2120 2019-07-17  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2123         declare.
2124         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2125         Rename from tui_first_reg_element_no_inline.
2126         (tui_display_reg_element_at_line)
2127         (tui_display_registers_from_line): Update.
2128         * tui/tui-data.h (struct tui_data_window)
2129         <first_reg_element_no_inline>: New method.
2130
2131 2019-07-17  Tom Tromey  <tom@tromey.com>
2132
2133         * tui/tui-windata.c (tui_display_data_from)
2134         (tui_data_window::do_scroll_vertical): Update.
2135         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2136         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2137         Rename from tui_line_from_reg_element_no.
2138         (tui_display_registers_from_line): Update.
2139         * tui/tui-data.h (struct tui_data_window)
2140         <line_from_reg_element_no>: New method.
2141
2142 2019-07-17  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2145         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2146         tui_last_regs_line_no.
2147         (tui_display_reg_element_at_line)
2148         (tui_display_registers_from_line): Update.
2149         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2150         method.
2151
2152 2019-07-17  Tom Tromey  <tom@tromey.com>
2153
2154         PR tui/24722:
2155         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2156         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2157         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2158         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2159         (tui_update_breakpoint_info): Likewise.
2160         * tui/tui-hooks.c (tui_event_create_breakpoint)
2161         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2162         Update.
2163
2164 2019-07-17  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2167
2168 2019-07-17  Tom Tromey  <tom@tromey.com>
2169
2170         * tui/tui-winsource.c (tui_update_source_window_as_is)
2171         (tui_update_source_windows_with_addr): Update.
2172         * tui/tui-source.h (tui_set_source_content)
2173         (tui_show_symtab_source): Add "win_info" parameter.
2174         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2175         parameter.
2176         (tui_show_symtab_source): Likewise.
2177
2178 2019-07-17  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-wingeneral.c
2181         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2182
2183 2019-07-17  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2186         (struct tui_cmd_window) <can_scroll>: New method.
2187         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2188         method.
2189
2190 2019-07-17  Tom Tromey  <tromey@adacore.com>
2191
2192         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2193         do_field_signed>: Rename.  Change type of "value".
2194         * ui-out.c (ui_out::field_signed): Rename from field_int.
2195         Change type of "value".
2196         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2197         type of "value".
2198         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2199         do_field_int.  Change type of "value".
2200         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2201         do_field_int.  Change type of "value".
2202         * tracepoint.c (trace_status_mi, tfind_1)
2203         (print_one_static_tracepoint_marker): Update.
2204         * thread.c (print_thread_info_1, print_selected_thread_frame):
2205         Update.
2206         * stack.c (print_frame, print_frame_info): Update.
2207         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2208         Update.
2209         * source.c (print_source_lines_base): Update.
2210         * skip.c (info_skip_command): Update.
2211         * record-btrace.c (btrace_ui_out_decode_error)
2212         (btrace_call_history_src_line): Update.
2213         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2214         Update.
2215         * progspace.c (print_program_space): Update.
2216         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2217         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2218         do_field_int.  Change type of "value".
2219         * mi/mi-out.c (mi_ui_out::do_table_begin)
2220         (mi_ui_out::do_table_header): Update.
2221         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2222         type of "value".
2223         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2224         (mi_cmd_data_list_changed_registers, output_register)
2225         (mi_cmd_data_read_memory, mi_load_progress)
2226         (mi_cmd_trace_frame_collected): Update.
2227         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2228         Update.
2229         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2230         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2231         (mi_cmd_var_list_children, varobj_update_one): Update.
2232         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2233         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2234         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2235         * inferior.c (print_inferior): Update.
2236         * gdb_bfd.c (print_one_bfd): Update.
2237         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2238         Update.
2239         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2240         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2241         do_field_int.  Change type of "value".
2242         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2243         do_field_int.  Change type of "value".
2244         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2245         (print_one_breakpoint_location, print_it_catch_fork)
2246         (print_one_catch_fork, print_it_catch_vfork)
2247         (print_one_catch_vfork, print_it_catch_solib)
2248         (print_it_catch_exec, print_it_ranged_breakpoint)
2249         (print_mention_watchpoint, print_mention_masked_watchpoint)
2250         (bkpt_print_it, update_static_tracepoint): Update.
2251         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2252         * break-catch-syscall.c (print_it_catch_syscall): Update.
2253         * ada-tasks.c (print_ada_task_info): Update.
2254         * ada-lang.c (print_it_exception, print_mention_exception):
2255         Update.
2256
2257 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2258
2259         PR breakpoints/24541
2260         * gdbarch.c: Regenerate.
2261         * gdbarch.h: Regenerate.
2262         * gdbarch.sh: Adjust return type and parameter types for
2263         'stap_adjust_register'.
2264         (i386_stap_adjust_register): Adjust signature and return new
2265         register name.
2266         * stap-probe.c (stap_parse_register_operand): Adjust use of
2267         'gdbarch_stap_adjust_register'.
2268
2269 2019-07-17  Tom Tromey  <tromey@adacore.com>
2270
2271         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2272         declare VEC.
2273         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2274         std::vector.
2275         (struct s390_process_info): Add initializers.
2276         (s390_add_process): Use new.
2277         (s390_linux_nat_target::low_forget_process): Use delete.
2278         (s390_linux_nat_target::low_new_fork)
2279         (s390_linux_nat_target::stopped_by_watchpoint)
2280         (s390_linux_nat_target::low_prepare_to_resume)
2281         (s390_linux_nat_target::insert_watchpoint)
2282         (s390_linux_nat_target::insert_hw_breakpoint)
2283         (s390_linux_nat_target::remove_watchpoint)
2284         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2285
2286 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2287
2288         * aarch64-fbsd-nat.c: Include regcache.h.
2289         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2290         argument.
2291         (aarch64_fbsd_nat_target::fetch_registers)
2292         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2293         variable.
2294         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2295
2296 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2297
2298         * fbsd-nat.c: Include gdbarch.h.
2299
2300 2019-07-15  Tom Tromey  <tromey@adacore.com>
2301
2302         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2303
2304 2019-07-15  Tom Tromey  <tromey@adacore.com>
2305
2306         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2307         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2308         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2309         * cli-out.c (cli_ui_out::do_field_int): New method.
2310         * ui-out.c (ui_out::field_unsigned): New method.
2311         * symfile.c (generic_load): Use field_unsigned.
2312         (print_transfer_performance): Likewise.
2313         * record-btrace.c (ui_out_field_uint): Remove.
2314         (btrace_call_history_insn_range, btrace_call_history): Use
2315         field_unsigned.
2316         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2317         field_unsigned.
2318         * ui-out.h (class ui_out) <field_unsigned>: New method.
2319         <do_field_unsigned>: Likewise.
2320
2321 2019-07-15  Tom Tromey  <tromey@adacore.com>
2322
2323         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2324         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2325         * target.c (flash_erase_command): Use field_string.
2326         * infrun.c (print_signal_received_reason): Use field_string.
2327         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2328         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2329         field_string.
2330         * ada-tasks.c (print_ada_task_info): Use field_string.
2331
2332 2019-07-15  Tom Tromey  <tromey@adacore.com>
2333
2334         * target.c (flash_erase_command): Use field_core_addr.
2335         * symfile.c (generic_load): Use field_core_addr.
2336         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2337         Use field_core_addr.
2338         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2339         field_core_addr.
2340
2341 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2342
2343         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2344         value if its desired type is smaller than a CORE_ADDR and signed.
2345
2346 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2347
2348         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2349         of changes to field names, and use new is_reference field to
2350         decide if a property is a reference or not.
2351         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2352         field.
2353         (struct dwarf2_property_baton): Update header comment, rename
2354         'referenced_type' to 'property_type' and update comments.
2355         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2356         default property type, store in property baton, update to take
2357         accound of renamed field.
2358         (read_func_scope): Update call to attr_to_dynamic_prop.
2359         (read_array_type): Likewise.
2360         (dwarf2_per_cu_addr_sized_int_type): New function.
2361         (read_subrange_index_type): Move type finding code to
2362         dwarf2_per_cu_addr_sized_int_type.
2363         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2364         (dwarf2_per_cu_addr_type): New function.
2365         (set_die_type): Update calls to attr_to_dynamic_prop.
2366
2367 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2368
2369         * dwarf2read.c (read_subrange_index_type): New function.
2370         (read_subrange_type): Move code into new function and call it.
2371         * gdbtypes.c (create_range_type): Add some asserts.
2372
2373 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2374
2375         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2376         update return statements.
2377         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2378         declaration, and update comment to match.
2379         * gdbtypes.c (resolve_dynamic_array): Update call to
2380         dwarf2_evaluate_property to match new return type.
2381
2382 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2383
2384         * valarith.c (value_subscripted_rvalue): Change lowerbound
2385         parameter type from int to LONGEST.
2386         * value.h (value_subscripted_rvalue): Likewise in declaration.
2387
2388 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2389
2390         * cli/cli-utils.c (info_print_command_completer): New function.
2391         * cli/cli-utils.h: Add 'completer.h' include, and forward
2392         declaration for 'struct cmd_list_element'.
2393         (info_print_command_completer): Declare.
2394         * stack.c (_initialize_stack): Add completer for 'info locals' and
2395         'info args'.
2396         * symtab.c (_initialize_symtab): Add completer for 'info
2397         variables' and 'info functions'.
2398         * NEWS: Mention completion for additional info commands.
2399
2400 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2401
2402         * cli/cli-utils.c (extract_info_print_args): Delete.
2403         (extract_arg_maybe_quoted): Delete.
2404         (info_print_options_defs): New variable.
2405         (make_info_print_options_def_group): New function.
2406         (extract_info_print_options): Define new function.
2407         * cli/cli-utils.h (extract_info_print_args): Delete.
2408         (struct info_print_options): New structure.
2409         (extract_info_print_options): Declare new function.
2410         * stack.c (info_locals_command): Update to use new
2411         extract_info_print_options, also add a header comment.
2412         (info_args_command): Likewise.
2413         * symtab.c (info_variables_command): Likewise.
2414         (info_functions_command): Likewise.
2415
2416 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2417
2418         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2419         to extract string arguments.
2420         * common/common-utils.c (extract_string_maybe_quoted): New function.
2421         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2422
2423 2019-07-11  Tom Tromey  <tromey@adacore.com>
2424
2425         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2426         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2427         * top.h (gdbinit): Don't declare.
2428         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2429         into...
2430         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2431         * top.c (gdb_init): Don't call init_cli_cmds.
2432         (gdbinit): Remove.
2433         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2434
2435 2019-07-11  Tom Tromey  <tromey@adacore.com>
2436
2437         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2438         after it has been moved.
2439
2440 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2441
2442         * valops.c (value_must_coerce_to_target): Change return type to
2443         bool.
2444         * value.h (value_must_coerce_to_target): Likewise.
2445
2446 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2447
2448         * breakpoint.c (is_hardware_watchpoint): Remove
2449         forward-declaration.
2450         (is_masked_watchpoint): Change return type to bool.
2451         (is_tracepoint): Likewise.
2452         (is_breakpoint): Likewise.
2453         (is_hardware_watchpoint): Likewise.
2454         (is_watchpoint): Likewise.
2455         (is_no_memory_software_watchpoint): Likewise.
2456         (is_catchpoint): Likewise.
2457         (breakpoint_1): Make FILTER parameter's return type bool.
2458         is_masked_watchpoint): Change return type to bool.
2459         (save_breakpoints): Make FILTER parameter's return type bool.
2460         * breakpoint.h (is_breakpoint): Change return type to bool.
2461         (is_watchpoint): Likewise.
2462         (is_catchpoint): Likewise.
2463         (is_tracepoint): Likewise.
2464
2465 2019-07-10  Tom Tromey  <tom@tromey.com>
2466
2467         * defs.h: Don't include gdbarch.h.
2468         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2469         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2470         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2471         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2472         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2473         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2474         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2475         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2476         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2477         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2478         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2479         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2480         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2481         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2482         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2483         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2484         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2485         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2486         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2487         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2488         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2489         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2490         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2491         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2492         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2493         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2494         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2495
2496 2019-07-10  Tom Tromey  <tromey@adacore.com>
2497
2498         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2499         * breakpoint.c (init_ada_exception_breakpoint): Register as
2500         bp_catchpoint.
2501         (print_one_breakpoint_location, print_one_breakpoint): Use
2502         is_ada_exception_catchpoint.
2503         * ada-lang.c (class ada_catchpoint_location): Pass
2504         bp_loc_software_breakpoint to bp_location constructor.
2505         (is_ada_exception_catchpoint): New function.
2506
2507 2019-07-10  Tom Tromey  <tromey@adacore.com>
2508
2509         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2510         VEC.
2511         (struct arm_exidx_entry): New method operator<.
2512         (struct arm_exidx_data) <section_maps>: Change type.
2513         (arm_exidx_data_free): Remove.
2514         (arm_exidx_data_key): Change type.  Move lower.
2515         (arm_exidx_new_objfile): Update.
2516         (arm_compare_exidx_entries): Remove.
2517         (arm_find_exidx_entry, _initialize_arm_tdep)
2518
2519 2019-07-10  Tom Tromey  <tromey@adacore.com>
2520
2521         * solib-spu.c (ocl_program_data_key): Change type.
2522         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2523         Update.
2524
2525 2019-07-10  Tom Tromey  <tromey@adacore.com>
2526
2527         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2528         (struct solib_aix_inferior_data) <library_list>: Change type.
2529         (solib_aix_inferior_data_handle): Change type.
2530         (get_solib_aix_inferior_data): Update.
2531         (solib_aix_free_library_list): Remove.
2532         (library_list_start_library): Update.
2533         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2534         return type.
2535         (solib_aix_get_library_list)
2536         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2537         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2538
2539 2019-07-10  Tom Tromey  <tromey@adacore.com>
2540
2541         * solib-dsbt.c (struct dsbt_info): Add initializers.
2542         (solib_dsbt_pspace_data): Change type.
2543         (dsbt_pspace_data_cleanup): Remove.
2544         (get_dsbt_info, _initialize_dsbt_solib): Update.
2545
2546 2019-07-10  Tom Tromey  <tromey@adacore.com>
2547
2548         * spu-tdep.c (spu_overlay_data): Change type.
2549         (spu_get_overlay_table, spu_overlay_new_objfile)
2550         (_initialize_spu_tdep): Update.
2551
2552 2019-07-10  Tom Tromey  <tromey@adacore.com>
2553
2554         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2555         destructor.
2556         (dbx_objfile_data_key): Change type and declare later.
2557         (DBX_SYMFILE_INFO): Rewrite.
2558         * dbxread.c (dbx_objfile_data_key): Change type.
2559         (dbx_symfile_init): Update.
2560         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2561         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2562         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2563
2564 2019-07-10  Tom Tromey  <tromey@adacore.com>
2565
2566         * jit.c (jit_program_space_key): Change type.  Move lower.
2567         (get_jit_program_space_data): Update.
2568         (jit_program_space_data_cleanup): Remove.
2569         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2570         Update.
2571         (struct jit_program_space_data): Add initializers.
2572
2573 2019-07-10  Tom Tromey  <tromey@adacore.com>
2574
2575         * solib-darwin.c (struct darwin_info): Add initializers.
2576         (solib_darwin_pspace_data): Change type.
2577         (darwin_pspace_data_cleanup): Remove.
2578         (get_darwin_info, _initialize_darwin_solib): Update.
2579
2580 2019-07-10  Tom Tromey  <tromey@adacore.com>
2581
2582         * remote-sim.c (struct sim_inferior_data): Add initializers,
2583         constructor, and destructor.
2584         (sim_inferior_data_key): Change type.  Move lower.
2585         (check_for_duplicate_sim_descriptor): Update.
2586         (get_sim_inferior_data): Use new.  Update.
2587         (~sim_inferior_data_cleanup): Rename from
2588         sim_inferior_data_cleanup.  Simplify.
2589         (gdbsim_close_inferior, simulator_command)
2590         (sim_command_completer, _initialize_remote_sim): Update.
2591         (next_pid, INITIAL_PID): Move earlier.
2592
2593 2019-07-10  Tom Tromey  <tromey@adacore.com>
2594
2595         * python/python-internal.h (create_thread_object): Return
2596         gdbpy_ref.
2597         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2598         * python/py-inferior.c (struct threadlist_entry): Add
2599         constructor.
2600         <thread_obj>: Now a gdbpy_ref.
2601         (thread_to_thread_object): Update.
2602         (add_thread_object): Use new.
2603         (delete_thread_object): Use delete.
2604         (infpy_threads): Update.
2605         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2606         GIL.
2607
2608 2019-07-10  Tom Tromey  <tromey@adacore.com>
2609
2610         * valops.c (value_cast): Specialize error message for Ada.
2611
2612 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2613
2614         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2615
2616 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2617
2618         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2619         bpstat_should_step): Return bool, adjust comments.
2620         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2621         bpstat_should_step): Likewise.
2622
2623 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2624
2625         * features/Makefile: Use feature target descriptions for Arm.
2626         * features/arm/arm-core.c: Generate new file.
2627         * features/arm/arm-fpa.c: Likewise.
2628         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2629         * features/arm/arm-m-profile.c: Likewise.
2630         * features/arm/arm-vfpv2.c: Likewise.
2631         * features/arm/arm-vfpv3.c: Likewise.
2632         * features/arm/xscale-iwmmxt.c: Likewise.
2633         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2634
2635 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2636
2637         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2638         ptrace earlier.
2639
2640 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2641
2642         * features/aarch64-pauth.c: Regenerate.
2643
2644 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2645
2646         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2647         bool.
2648         (bpstat_what): Use false instead of 0.
2649
2650 2019-07-09  Pedro Alves  <palves@redhat.com>
2651
2652         * break-catch-throw.c (is_exception_catchpoint): New.
2653         * breakpoint.c (print_one_breakpoint_location): New parameter
2654         'raw_loc'.  Handle it.  Use
2655         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2656         looking at the breakpoint's type.
2657         (print_one_breakpoint): If handling "maint info breakpoints", also
2658         print locations of exception catchpoints.
2659         * breakpoint.h (is_exception_catchpoint): Declare.
2660
2661 2019-07-09  Pedro Alves  <palves@redhat.com>
2662
2663         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2664         "addr" field.
2665         (allocate_location_exception_catchpoint): New.
2666         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2667         (initialize_throw_catchpoint_ops): Install
2668         allocate_location_exception_catchpoint as allocate_location
2669         method.
2670         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2671         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2672         bp_loc_other.
2673         (breakpoint_address_is_meaningful): Delete.
2674         (bl_address_is_meaningful): New.
2675         (breakpoint_locations_match): Adjust comment.
2676         (bp_location_from_bp_type): New, factored out of...
2677         (bp_location::bp_location(breakpoint *)): ... this.
2678         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2679         factored out of...
2680         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2681         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2682         breakpoint_address_is_meaningful.
2683         (bp_locations_compare): Adjust comment.
2684         (update_global_location_list): Use bl_address_is_meaningful
2685         instead of breakpoint_address_is_meaningful.
2686         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2687         explicit.
2688         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2689         * python/py-breakpoint.c (bppy_get_location): No longer check
2690         whether location is null.
2691
2692 2019-07-09  Pedro Alves  <palves@redhat.com>
2693
2694         PR c++/15468
2695         * breakpoint.c (print_one_breakpoint_location): Remove
2696         single-location assert.
2697
2698 2019-07-09  Tom Tromey  <tom@tromey.com>
2699
2700         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2701         * configure: Rebuild.
2702         * configure.ac: Change common to gdbsupport.
2703         * gdbsupport: Rename from common.
2704         * acinclude.m4: Change common to gdbsupport.
2705         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2706         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2707         gdbsupport.
2708         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2709         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2710         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2711         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2712         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2713         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2714         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2715         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2716         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2717         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2718         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2719         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2720         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2721         coff-pe-read.c, command.h, compile/compile-c-support.c,
2722         compile/compile-c.h, compile/compile-cplus-symbols.c,
2723         compile/compile-cplus-types.c, compile/compile-cplus.h,
2724         compile/compile-loc2c.c, compile/compile.c, completer.c,
2725         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2726         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2727         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2728         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2729         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2730         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2731         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2732         features/aarch64-core.c, features/aarch64-fpu.c,
2733         features/aarch64-pauth.c, features/aarch64-sve.c,
2734         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2735         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2736         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2737         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2738         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2739         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2740         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2741         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2742         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2743         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2744         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2745         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2746         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2747         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2748         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2749         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2750         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2751         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2752         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2753         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2754         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2755         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2756         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2757         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2758         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2759         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2760         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2761         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2762         minsyms.c, mips-linux-tdep.c, namespace.h,
2763         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2764         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2765         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2766         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2767         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2768         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2769         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2770         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2771         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2772         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2773         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2774         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2775         procfs.c, producer.c, progspace.h, psymtab.h,
2776         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2777         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2778         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2779         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2780         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2781         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2782         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2783         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2784         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2785         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2786         target-memory.c, target.c, target.h, target/waitstatus.c,
2787         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2788         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2789         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2790         unittests/array-view-selftests.c,
2791         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2792         unittests/common-utils-selftests.c,
2793         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2794         unittests/format_pieces-selftests.c,
2795         unittests/function-view-selftests.c,
2796         unittests/lookup_name_info-selftests.c,
2797         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2798         unittests/mkdir-recursive-selftests.c,
2799         unittests/observable-selftests.c,
2800         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2801         unittests/parse-connection-spec-selftests.c,
2802         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2803         unittests/scoped_fd-selftests.c,
2804         unittests/scoped_mmap-selftests.c,
2805         unittests/scoped_restore-selftests.c,
2806         unittests/string_view-selftests.c, unittests/style-selftests.c,
2807         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2808         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2809         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2810         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2811         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2812         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2813
2814 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2815
2816         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2817         bool value.
2818         (decode_digits_ordinary): Set explicit_line field in sal.
2819         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2820         symtab_and_line that was set on an explicit line number in
2821         assembler code.  Do always update the recorded symtab and line if
2822         we do skip the prologue.
2823
2824 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         * breakpoint.c (set_breakpoint_location_function): Remove
2827         explicit_loc parameter.
2828         (momentary_breakpoint_from_master): Update call to
2829         set_breakpoint_location_function.
2830         (add_location_to_breakpoint): Likewise.
2831
2832 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2833
2834         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2835         required features based on default bfd type when no specific bfd
2836         is present.
2837
2838 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2839
2840         * NEWS: Mention that GDB printf and eval commands can now print
2841         C-style and Ada-style convenience var strings without
2842         calling the inferior.
2843         * printcmd.c (printf_c_string): Locally print GDB internal var
2844         instead of transiting via the inferior.
2845         (printf_wide_c_string): Likewise.
2846
2847 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2848
2849         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2850
2851 2019-07-04  Tom Tromey  <tom@tromey.com>
2852
2853         PR tui/24724:
2854         * tui/tui-winsource.c (tui_clear_source_content): Update.
2855         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2856         (tui_update_breakpoint_info): Update.
2857         (tui_set_exec_info_content): Update.
2858         * tui/tui-source.c (tui_set_source_content_nil): Update.
2859         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2860         has_break.
2861         * tui/tui-data.h (enum tui_bp_flag): New.
2862         (tui_bp_flags): New enum flags type.
2863         (struct tui_source_element) <break_mode>: Change type.  Rename
2864         from has_break.
2865         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2866         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2867         constants.
2868         * tui/tui-winsource.h: Fix comment.
2869
2870 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2871
2872         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2873         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2874         (store_fpregs_to_thread)
2875         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2876         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2877         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2878         (IWMMXT_REGS_SIZE): Add define.
2879         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2880         (fetch_vfp_regs, store_vfp_regs)
2881         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2882         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2883
2884 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2885
2886         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2887         defines.
2888         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2889         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2890         (ARM_INT_REGISTER_SIZE): ...to this.
2891         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2892         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2893         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2894         (arm_linux_collect_gregset, supply_nwfpe_register)
2895         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2896         defines.
2897         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2898         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2899         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2900         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2901         (arm_return_in_memory, arm_store_return_value)
2902         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2903         (arm_record_ld_st_multiple): Likewise.
2904         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2905         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2906
2907 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2908
2909         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2910         AARCH64_DISPLACED_MODIFIED_INSNS.
2911         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2912         (aarch64_displaced_step_copy_insn): Likewise.
2913         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2914         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2915         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2916         ARM_DISPLACED_MODIFIED_INSNS.
2917         * arm-tdep.c (arm_gdbarch_init): Likewise.
2918         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2919         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2920         (struct arm_displaced_step_closure): Use
2921         ARM_DISPLACED_MODIFIED_INSNS.
2922
2923 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2924
2925         * features/Makefile: Remove unused xml files.
2926         * features/aarch64.xml: Remove.
2927         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2928         * features/i386/amd64-avx-avx512.xml: Remove.
2929         * features/i386/amd64-avx-linux.xml: Remove.
2930         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2931         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2932         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2933         * features/i386/amd64-avx-mpx.xml: Remove.
2934         * features/i386/amd64-avx.xml: Remove.
2935         * features/i386/amd64-linux.xml: Remove.
2936         * features/i386/amd64-mpx-linux.xml: Remove.
2937         * features/i386/amd64-mpx.xml: Remove.
2938         * features/i386/amd64.xml: Remove.
2939         * features/i386/i386-avx-avx512-linux.xml: Remove.
2940         * features/i386/i386-avx-avx512.xml: Remove.
2941         * features/i386/i386-avx-linux.xml: Remove.
2942         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2943         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2944         * features/i386/i386-avx-mpx-linux.xml: Remove.
2945         * features/i386/i386-avx-mpx.xml: Remove.
2946         * features/i386/i386-avx.xml: Remove.
2947         * features/i386/i386-linux.xml: Remove.
2948         * features/i386/i386-mmx-linux.xml: Remove.
2949         * features/i386/i386-mmx.xml: Remove.
2950         * features/i386/i386-mpx-linux.xml: Remove.
2951         * features/i386/i386-mpx.xml: Remove.
2952         * features/i386/i386.xml: Remove.
2953         * features/i386/x32-avx-avx512-linux.xml: Remove.
2954         * features/i386/x32-avx-linux.xml: Remove.
2955         * features/i386/x32-linux.xml: Remove.
2956
2957 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2958
2959         * regformats/aarch64.dat: Remove.
2960         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2961         * regformats/i386/amd64-avx-linux.dat: Remove.
2962         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2963         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2964         * regformats/i386/amd64-linux.dat: Remove.
2965         * regformats/i386/amd64-mpx-linux.dat: Remove.
2966         * regformats/i386/amd64.dat: Remove.
2967         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2968         * regformats/i386/i386-avx-linux.dat: Remove.
2969         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2970         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2971         * regformats/i386/i386-linux.dat: Remove.
2972         * regformats/i386/i386-mmx-linux.dat: Remove.
2973         * regformats/i386/i386-mpx-linux.dat: Remove.
2974         * regformats/i386/i386.dat: Remove.
2975         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2976         * regformats/i386/x32-avx-linux.dat: Remove.
2977         * regformats/i386/x32-linux.dat: Remove.
2978
2979 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2980
2981         * aarch64-tdep.c: Remove xml self tests.
2982         * amd64-linux-tdep.c: Likewise.
2983         * amd64-tdep.c: Likewise.
2984         * i386-linux-tdep.c: Likewise.
2985         * i386-tdep.c: Likewise.
2986
2987 2019-07-03  Pedro Alves  <palves@redhat.com>
2988
2989         PR cli/24732
2990         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2991         (pipe_cmd_option_defs): New.
2992         (make_pipe_cmd_options_def_group): New.
2993         (pipe_command): Use gdb::option::process_options.
2994         (pipe_command_completer): New function.
2995         (_initialize_cli_cmds): Install completer for "pipe" command.
2996
2997 2019-07-03  Pedro Alves  <palves@redhat.com>
2998
2999         * cli/cli-option.c (union option_value) <string>: New field.
3000         (struct option_def_and_value): Add ctor, move ctor, dtor and
3001         use DISABLE_COPY_AND_ASSIGN.
3002         (option_def_and_value::clear_value): New.
3003         (parse_option, save_option_value_in_ctx, get_val_type_str)
3004         (add_setshow_cmds_for_options): Handle var_string.
3005         * cli-option.h (union option_def::var_address) <string>: New
3006         field.
3007         (struct string_option_def): New.
3008         * maint-test-options.c (struct test_options_opts): Add default
3009         ctor and use DISABLE_COPY_AND_ASSIGN.
3010         <string_opt>: New field.
3011         (test_options_opts::~test_options_opts): New.
3012         (test_options_opts::dump): Also dump "-string".
3013         (test_options_option_defs): Install "string.
3014
3015 2019-07-03  Pedro Alves  <palves@redhat.com>
3016
3017         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3018         option_value with a null enumeration.
3019         (complete_options): Save the option values in the context.
3020         (save_option_value_in_ctx): New, factored out from ...
3021         (process_options): ... here.
3022         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3023         of the function.
3024         * maint-test-options.c (test_options_opts::dump): New, factored
3025         out from ...
3026         (maintenance_test_options_command_mode): ... here.
3027         (maintenance_test_options_command_completion_result): Delete.
3028         (maintenance_test_options_command_completion_text): Update
3029         comment.
3030         (maintenance_show_test_options_completion_result): Change
3031         prototype.  Just print
3032         maintenance_test_options_command_completion_text.
3033         (save_completion_result): New.
3034         (maintenance_test_options_completer_mode): Pass options context to
3035         complete_options, and then save a dump.
3036         (_initialize_maint_test_options): Use add_cmd to install "maint
3037         show test-options-completion-result".
3038
3039 2019-07-03  Pedro Alves  <palves@redhat.com>
3040
3041         * NEWS (New commands): Mention "with" and "maint with".
3042         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3043         (with_command, with_command_completer): New.
3044         (pipe_command): Adjust to new repeat_previous
3045         interface.
3046         (_initialize_cli_cmds): Install the "with" command and its "w"
3047         alias.
3048         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3049         declarations.
3050         * cli/cli-setshow.c (parse_cli_var_uinteger)
3051         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3052         argument strings for all var_types.
3053         (get_setshow_command_value_string): New, factored out from ...
3054         (do_show_command): ... this.
3055         * cli/cli-setshow.h: Include <string>.
3056         (get_setshow_command_value_string): Declare.
3057         * command.h (repeat_previous): Now returns const char *.  Adjust
3058         comment.
3059         * maint.c: Include "cli/cli-cmds.h".
3060         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3061         (_initialize_maint_cmds): Register the "maintenance with" command.
3062         * top.c (repeat_previous): Move bits from pipe_command here:
3063         Return the saved command line, if any; error out if there's no
3064         command to relaunch.
3065
3066 2019-07-03  Pedro Alves  <palves@redhat.com>
3067
3068         * NEWS (New commands): Mention "maint set/show test-settings"
3069         instead of "maint test-settings".
3070         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3071         (maintenance_test_settings_set_list): Rename to ...
3072         (maintenance_set_test_settings_list): ... this.
3073         (maintenance_test_settings_show_list): Rename to  ...
3074         (maintenance_show_test_settings_list): ... this.
3075         (maintenance_test_settings_cmd): Delete.
3076         (maintenance_test_settings_set_cmd): ...
3077         (maintenance_set_test_settings_cmd): ... this.
3078         (maintenance_test_settings_show_cmd): ...
3079         (maintenance_show_test_settings_cmd): ... this.
3080         (maintenance_test_settings_show_value_cmd):
3081         (maintenance_show_test_settings_value_cmd): ... this.
3082         (_initialize_maint_test_settings): No longer install the "maint
3083         test-settings" prefix command.  Rename "maint test-settings set"
3084         to "maint set test-settings", and "maint test-settings show" to
3085         "maint show test-settings".  Adjust all subcommands.
3086
3087 2019-07-03  Pedro Alves  <palves@redhat.com>
3088
3089         * maint-test-settings.c: Fix file's intro comment.  Replace all
3090         references to "test-options" with references to "test-settings",
3091         in comments.
3092
3093 2019-07-03  Pedro Alves  <palves@redhat.com>
3094
3095         * maint-test-settings.c (maintenance_test_settings_xxx)
3096         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3097         New.
3098         (maintenance_test_settings_enums): Use them.
3099         (maintenance_test_settings_enum): Default to
3100         maintenance_test_settings_xxx.
3101         (_initialize_maint_test_settings): Initialize
3102         MAINTENANCE_TEST_SETTINGS_FILENAME.
3103
3104 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3105
3106         * breakpoint.h (remove_breakpoints_inf): Change return type to
3107         void, move function documentation here.
3108         * breakpoint.c (remove_breakpoints_inf): Change return type to
3109         void, move function documentation to header.
3110
3111 2019-07-02  Pedro Alves  <palves@redhat.com>
3112
3113         * NEWS (Completion improvements): Mention "info threads".
3114         * thread.c (struct info_threads_opts, info_threads_option_defs)
3115         (make_info_threads_options_def_group): New.
3116         (info_threads_command): Use gdb::option::process_options.
3117         (info_threads_command_completer): New.
3118         (_initialize_thread): Use gdb::option::build_help to build the
3119         help text for "info threads".
3120
3121 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3122
3123         * defs.h (generic_load): Move from here...
3124         * symfile.h (generic_load): ... to here.  Rename name parameter
3125         to args.
3126         * symfile.c (generic_load): Add comment.
3127
3128 2019-07-01  Tom Tromey  <tromey@adacore.com>
3129
3130         * dwarf2read.c
3131         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3132         declaration of without_params.  Fix formatting.
3133
3134 2019-07-01  Tom Tromey  <tromey@adacore.com>
3135
3136         * ada-exp.y (find_primitive_type): Update.
3137         * ada-lang.h (ada_lookup_symbol): Update.
3138         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3139         parameter.
3140         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3141
3142 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3143
3144         PR breakpoints/24541
3145         * gdbarch.c: Regenerate.
3146         * gdbarch.h: Regenerate.
3147         * gdbarch.sh: Add 'stap_adjust_register'.
3148         * i386-tdep.c: Include '<unordered_set>'.
3149         (i386_stap_adjust_register): New function.
3150         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3151         * stap-probe.c (stap_parse_register_operand): Call
3152         'gdbarch_stap_adjust_register'.
3153
3154 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3155
3156         PR python/24742
3157         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3158         * python/python.c (do_start_initialization): Use 'xmalloc'
3159         instead of 'PyMem_Malloc'.
3160
3161 2019-06-28  Tom Tromey  <tromey@adacore.com>
3162
3163         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3164         for Ada.
3165
3166 2019-06-27  Tom Tromey  <tromey@adacore.com>
3167
3168         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3169         objfile_key.
3170         (arm_find_mapping_symbol, arm_record_special_symbol)
3171         (_initialize_arm_tdep): Update.
3172         (arm_objfile_data_free): Remove.
3173
3174 2019-06-27  Tom Tromey  <tromey@adacore.com>
3175
3176         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3177         to cp_print_static_field.
3178
3179 2019-06-26  Tom Tromey  <tromey@adacore.com>
3180
3181         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3182         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3183         declare.
3184
3185 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3186
3187         * features/aarch64-core.c (create_feature_aarch64_core):
3188         Regenerate.
3189         * features/aarch64-core.xml: Add cpsr flags.
3190
3191 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3192
3193         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3194         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3195
3196 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3197
3198         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3199         field.
3200         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3201         use.
3202         (arm_record_special_symbol): Don't insert new symbol in sorted
3203         position, push it at the end.
3204
3205 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3206
3207         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3208         (arm_mapping_symbol_s): Remove.
3209         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3210         (arm_mapping_symbol_vec): New typedef.
3211         (struct arm_per_objfile): Add constructor.
3212         <section_maps>: Change type to
3213         std::unique_ptr<arm_mapping_symbol_vec[]>.
3214         (arm_compare_mapping_symbols): Remove.
3215         (arm_find_mapping_symbol): Adjust to section_maps type change.
3216         (arm_objfile_data_free): Call delete on arm_per_objfile.
3217         (arm_record_special_symbol): Adjust to section_maps type change.
3218         Allocate arm_per_objfile with new.
3219
3220 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3221
3222         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3223         with the command prefix.
3224
3225 2019-06-25  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3228         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3229
3230 2019-06-25  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3233         type.
3234         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3235         protected.
3236
3237 2019-06-25  Tom Tromey  <tom@tromey.com>
3238
3239         * tui/tui-winsource.c
3240         (tui_source_window_base::set_is_exec_point_at): Add check against
3241         LOA_ADDRESS.
3242
3243 2019-06-25  Tom Tromey  <tom@tromey.com>
3244
3245         * tui/tui-source.c (tui_set_source_content): Don't check before
3246         xfree.
3247         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3248
3249 2019-06-25  Tom Tromey  <tom@tromey.com>
3250
3251         * tui/tui-winsource.h (tui_update_source_window_as_is)
3252         (tui_alloc_source_buffer, tui_line_is_displayed)
3253         (tui_addr_is_displayed): Change type of win_info.
3254         * tui/tui-winsource.c (tui_update_source_window_as_is)
3255         (tui_clear_source_content, tui_show_source_line)
3256         (tui_show_source_content, tui_source_window_base::refill)
3257         (tui_source_window_base::set_is_exec_point_at)
3258         (tui_source_window_base::set_is_exec_point_at)
3259         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3260         (tui_alloc_source_buffer, tui_line_is_displayed)
3261         (tui_addr_is_displayed): Change type of win_info.  Update.
3262         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3263         (tui_source_window_base::do_make_visible_with_new_height):
3264         Update.
3265         * tui/tui-source.c (tui_set_source_content)
3266         (tui_set_source_content_nil)
3267         (tui_source_window::do_scroll_vertical): Update.
3268         * tui/tui-layout.c (show_layout): Update.
3269         * tui/tui-disasm.c (tui_set_disassem_content)
3270         (tui_disasm_window::do_scroll_vertical): Update.
3271         * tui/tui-data.h (tui_win_content): Remove.
3272         (struct tui_gen_win_info) <content, content_size>: Remove.
3273         (struct tui_source_element): Add initializers and destructor.
3274         (union tui_which_element, struct tui_win_element): Remove.
3275         (struct tui_source_window_base) <content>: New field.
3276         (struct tui_data_window): Remove destructor.
3277         (tui_alloc_content, tui_free_win_content)
3278         (tui_free_all_source_wins_content): Don't declare.
3279         * tui/tui-data.c (tui_initialize_static_data): Update.
3280         (init_content_element, tui_alloc_content): Remove.
3281         (~tui_gen_win_info): Update.
3282         (~tui_data_window, tui_free_all_source_wins_content)
3283         (tui_free_win_content, free_content, free_content_elements):
3284         Remove.
3285
3286 2019-06-25  Tom Tromey  <tom@tromey.com>
3287
3288         * tui/tui-winsource.h (tui_clear_source_content)
3289         (tui_erase_source_content, tui_show_source_content): Change type
3290         of win_info.
3291         * tui/tui-winsource.c (tui_clear_source_content)
3292         (tui_erase_source_content, tui_show_source_content): Change type
3293         of win_info.
3294         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3295         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3296         win_info.
3297         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3298         win_info.
3299         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3300
3301 2019-06-25  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui-winsource.c (tui_clear_source_content)
3304         (tui_source_window_base::set_is_exec_point_at): Update.
3305         * tui/tui-source.c (tui_set_source_content_nil): Update.
3306         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3307         a bool.
3308         * tui/tui-data.c (init_content_element): Update.
3309
3310 2019-06-25  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3313         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3314         * tui/tui-layout.c (init_and_make_win): Update.
3315         * tui/tui.h (enum tui_win_type): Update.
3316         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3317         tui_win_is_auxillary.
3318         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3319         tui_win_is_auxillary.
3320
3321 2019-06-25  Tom Tromey  <tom@tromey.com>
3322
3323         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3324         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3325         (tui_delete_data_content_windows, tui_display_all_data)
3326         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3327         Update.
3328         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3329         * tui/tui-regs.c (tui_last_regs_line_no)
3330         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3331         (tui_show_registers): Update.
3332         (tui_show_register_group): Return void.  Update.
3333         (tui_display_registers_from, tui_display_reg_element_at_line)
3334         (tui_display_registers_from_line, tui_check_register_values):
3335         Update.
3336         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3337         member.
3338         (struct tui_data_window) <regs_content>: Now a std::vector.
3339         <regs_content_count>: Remove.
3340         (tui_add_content_elements, tui_free_data_content): Don't declare.
3341         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3342         (init_content_element): Remove DATA_WIN case.  Add assert.
3343         (tui_add_content_elements): Remove.
3344         (tui_data_window): Update.
3345         (tui_free_data_content): Remove.
3346         (free_content_elements): Remove DATA_WIN case.
3347
3348 2019-06-25  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-data.c (tui_data_item_window): Update.
3351         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3352         * tui/tui-windata.c (tui_display_all_data)
3353         (tui_display_data_from_line): Update.
3354         (tui_check_data_values): Remove.
3355         * tui/tui-regs.c (tui_show_register_group)
3356         (tui_display_reg_element_at_line): Update.
3357         * tui/tui-hooks.c (tui_register_changed)
3358         (tui_refresh_frame_and_register_information): Call
3359         tui_check_register_values.
3360         * tui/tui-data.h (struct tui_data_window) <data_content,
3361         data_content_count, data_type>: Remove.
3362         (enum tui_data_type): Remove.
3363
3364         * tui/tui-data.c (tui_data_window::clear_detail)
3365         (~tui_data_window): Update.
3366
3367 2019-06-25  Tom Tromey  <tom@tromey.com>
3368
3369         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3370         declare.
3371         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3372         Rename from tui_first_data_item_displayed.  Update.
3373         (tui_data_window::refresh_all)
3374         (tui_data_window::do_scroll_vertical): Update.
3375         * tui/tui-data.h (struct tui_data_window)
3376         <first_data_item_displayed>: Declare new method.
3377
3378 2019-06-25  Tom Tromey  <tom@tromey.com>
3379
3380         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3381         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3382         contents...
3383         (tui_initialize_static_data): ...here.
3384
3385 2019-06-25  Tom Tromey  <tom@tromey.com>
3386
3387         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3388         (tui_display_registers_from, tui_check_register_values): Update.
3389         (tui_display_register): Remove win_info parameter; update.
3390         (tui_get_register): Change type of parameters.
3391         * tui/tui-data.h (struct tui_data_element): Remove.
3392         (union tui_which_element) <data>: Remove.
3393         <data_window>: Change type.
3394         (struct tui_data_item_window): New.
3395         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3396         case.  Add assert.
3397         (~tui_data_item_window): New destructor.
3398         (free_content_elements): Remove DATA_ITEM_WIN case.
3399
3400 2019-06-25  Tom Tromey  <tom@tromey.com>
3401
3402         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3403         Remove.
3404
3405 2019-06-25  Tom Tromey  <tom@tromey.com>
3406
3407         * tui/tui-data.h (struct tui_command_element): Remove.
3408         (union tui_which_element) <command>: Remove.
3409         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3410         assert.
3411         (free_content_elements): Remove CMD_WIN case.
3412
3413 2019-06-25  Tom Tromey  <tom@tromey.com>
3414
3415         * tui/tui-layout.c (tui_set_layout): Update.
3416         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3417         * tui/tui-data.c (layout_def): Update.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3422         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3423         (tui_source_window_base::set_new_height): Update.
3424         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3425         Update.
3426         (tui_set_locator_fullname, tui_set_locator_info)
3427         (tui_show_frame_info): Update.
3428         * tui/tui-source.c (tui_set_source_content)
3429         (tui_source_is_displayed): Update.
3430         * tui/tui-layout.c (show_source_disasm_command, show_data)
3431         (show_source_or_disasm_and_command): Update.
3432         * tui/tui-disasm.c (tui_set_disassem_content)
3433         (tui_get_begin_asm_address): Update.
3434         * tui/tui-data.h (struct tui_locator_element): Remove.
3435         (union tui_which_element) <locator>: Remove.
3436         (struct tui_locator_window): New.
3437         (tui_locator_win_info_ptr): Change return type.
3438         * tui/tui-data.c (_locator): Change type.
3439         (tui_locator_win_info_ptr): Change return type.
3440         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3441         (tui_alloc_content): Add assert.
3442
3443 2019-06-25  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui-winsource.c
3446         (tui_exec_info_window::maybe_allocate_content): New method.
3447         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3448         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3449         (make_source_or_disasm_window): Add cast.
3450         * tui/tui-data.h (union tui_which_element) <simple_string>:
3451         Remove.
3452         (struct tui_source_info): New.
3453         (struct tui_source_window_base) <execution_info>: Change type.
3454         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3455         case, and add assert.
3456         (tui_alloc_content): Add assert.
3457
3458 2019-06-25  Tom Tromey  <tom@tromey.com>
3459
3460         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3461         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3462         * tui/tui-data.c (tui_alloc_win_info): Remove.
3463
3464 2019-06-25  Tom Tromey  <tom@tromey.com>
3465
3466         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3467         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3468         can_highlight.
3469
3470 2019-06-25  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3473         make_visible_with_new_height method.
3474         (tui_win_info::make_visible_with_new_height): New method.
3475         (tui_source_window_base::do_make_visible_with_new_height)
3476         (tui_data_window::do_make_visible_with_new_height)
3477         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3478         (make_visible_with_new_height): Remove.
3479         (tui_resize_all, tui_adjust_win_heights): Use
3480         make_visible_with_new_height method.
3481         * tui/tui-data.h (struct tui_win_info)
3482         <do_make_visible_with_new_height, make_visible_with_new_height>:
3483         New methods.
3484         (struct tui_source_window_base, struct tui_data_window)
3485         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3486         methods.
3487
3488 2019-06-25  Tom Tromey  <tom@tromey.com>
3489
3490         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3491         method.
3492         (update_tab_width): Call update_tab_width method.
3493         * tui/tui-data.h (struct tui_win_info)
3494         (struct tui_source_window_base) <update_tab_width>: New methods.
3495
3496 2019-06-25  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3499         parameter.
3500         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3501         parameter.
3502         (tui_gen_win_info::make_visible): Update.
3503         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3504         parameter.
3505         * tui/tui-data.h (enum tui_box): New enum.
3506         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3507
3508 2019-06-25  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3511         init_and_make_win for EXEC_INFO_WIN.
3512         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3513         longer inline.
3514         (struct tui_win_info) <~tui_win_info>: Inline.
3515         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3516         Don't declare.
3517         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3518         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3519         Remove.
3520         (tui_initialize_static_data): Update.
3521         (~tui_gen_win_info): Handle more cleanup here.
3522         (~tui_source_window_base): Delete "execution_info".
3523         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3524
3525 2019-06-25  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-layout.c (make_command_window): Don't set
3528         can_highlight.
3529         (show_source_disasm_command): Call the reset method.
3530         (show_data): Don't set can_highlight.  Call the reset method.
3531         (tui_gen_win_info::reset): Rename from init_gen_win_info
3532         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3533         (show_source_or_disasm_and_command): Call the reset method.
3534         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3535         (struct tui_cmd_window): Set can_highlight.
3536
3537 2019-06-25  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3540         from make_visible.
3541         (tui_make_visible, tui_make_invisible): Rewrite.
3542         (tui_win_info::make_visible): Remove.
3543         (tui_source_window_base::make_visible): Update.
3544         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3545         method.  Moved from...
3546         (struct tui_win_info) <make_visible>: ...here.
3547
3548 2019-06-25  Tom Tromey  <tom@tromey.com>
3549
3550         * tui/tui-winsource.c
3551         (tui_source_window_base::do_scroll_horizontal): Remove direction
3552         parameter.
3553         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3554         direction parameter.
3555         * tui/tui-win.c (tui_win_info::forward_scroll)
3556         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3557         (tui_win_info::right_scroll): Update.
3558         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3559         direction parameter.
3560         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3561         direction parameter.
3562         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3563         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3564         Remove direction parameter.
3565         (struct tui_source_window_base, struct tui_source_window)
3566         (struct tui_disasm_window, struct tui_data_window)
3567         (struct tui_cmd_window): Update.
3568
3569 2019-06-25  Tom Tromey  <tom@tromey.com>
3570
3571         * tui/tui-winsource.h (tui_set_exec_info_content)
3572         (tui_show_exec_info_content, tui_erase_exec_info_content)
3573         (tui_clear_exec_info_content, tui_update_exec_info): Change
3574         argument to tui_source_window_base.
3575         * tui/tui-winsource.c (tui_set_exec_info_content)
3576         (tui_show_exec_info_content, tui_erase_exec_info_content)
3577         (tui_clear_exec_info_content, tui_update_exec_info): Change
3578         argument to tui_source_window_base.
3579
3580 2019-06-25  Tom Tromey  <tom@tromey.com>
3581
3582         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3583         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3584
3585 2019-06-25  Tom Tromey  <tom@tromey.com>
3586
3587         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3588         check.
3589
3590 2019-06-25  Tom Tromey  <tom@tromey.com>
3591
3592         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3593         type to void.
3594         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3595         type to void.
3596         * tui/tui-source.c (tui_set_source_content): Update.
3597         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3598
3599 2019-06-25  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-win.c (window_name_completer, tui_set_focus)
3602         (tui_all_windows_info): Use name method.
3603         * tui/tui-data.h (struct tui_gen_win_info)
3604         (struct tui_source_window, struct tui_disasm_window)
3605         (struct tui_data_window, struct tui_cmd_window) <name>: New
3606         method.
3607         (tui_win_name): Don't declare.
3608         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3609         (tui_win_name): Remove.
3610
3611 2019-06-25  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-winsource.h (tui_update_source_window)
3614         (tui_update_source_window_as_is): Change parameter type.
3615         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3616         to be a tui_source_window_base.
3617         (tui_update_source_window_as_is): Likewise.
3618         * tui/tui-win.c (make_visible_with_new_height): Update.
3619
3620 2019-06-25  Tom Tromey  <tom@tromey.com>
3621
3622         * tui/tui-winsource.c (tui_erase_source_content)
3623         (tui_show_source_content, tui_show_exec_info_content)
3624         (tui_erase_exec_info_content): Use refresh_window method.
3625         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3626         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3627         from tui_refresh_win.
3628         (tui_data_window::refresh_window): New method.
3629         (tui_win_info::refresh, tui_source_window_base::refresh)
3630         (tui_refresh_all): Use refresh_window method.
3631         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3632         method.
3633         * tui/tui-regs.c (tui_display_register): Call refresh_window
3634         method.
3635         * tui/tui-layout.c (show_source_disasm_command)
3636         (show_source_or_disasm_and_command): Call refresh_window method.
3637         * tui/tui-data.h (struct tui_gen_win_info)
3638         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3639         New method.
3640
3641 2019-06-25  Tom Tromey  <tom@tromey.com>
3642
3643         * tui/tui.c (tui_rl_other_window, tui_enable)
3644         (tui_is_window_visible, tui_get_command_dimension): Update.
3645         * tui/tui-winsource.c (tui_update_source_window_as_is)
3646         (tui_clear_source_content, tui_erase_source_content)
3647         (tui_show_source_line, tui_source_window_base::refill)
3648         (tui_source_window_base::do_scroll_horizontal)
3649         (tui_source_window_base::set_is_exec_point_at)
3650         (tui_update_breakpoint_info, tui_set_exec_info_content)
3651         (tui_alloc_source_buffer, tui_line_is_displayed)
3652         (tui_addr_is_displayed): Update.
3653         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3654         (tui_check_and_display_highlight_if_needed)
3655         (tui_win_info::make_visible, tui_win_info::refresh)
3656         (tui_refresh_all): Update.
3657         * tui/tui-windata.c (tui_first_data_item_displayed)
3658         (tui_delete_data_content_windows, tui_erase_data_content)
3659         (tui_display_all_data, tui_data_window::refresh_all)
3660         (tui_check_data_values): Update.
3661         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3662         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3663         (tui_win_info::backward_scroll, tui_refresh_all_win)
3664         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3665         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3666         (tui_source_window_base::set_new_height)
3667         (tui_data_window::set_new_height)
3668         (make_invisible_and_set_new_height)
3669         (make_visible_with_new_height, new_height_ok)
3670         (parse_scrolling_args): Update.
3671         * tui/tui-stack.c (tui_show_frame_info): Update.
3672         * tui/tui-source.c (tui_set_source_content)
3673         (tui_set_source_content_nil, tui_source_is_displayed)
3674         (tui_source_window::do_scroll_vertical): Update.
3675         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3676         (tui_display_registers_from, tui_display_reg_element_at_line)
3677         (tui_check_register_values, tui_reg_command): Update.
3678         * tui/tui-layout.c (tui_default_win_height)
3679         (show_source_disasm_command, show_data, init_and_make_win)
3680         (show_source_or_disasm_and_command): Update.
3681         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3682         (tui_redisplay_readline, tui_mld_flush)
3683         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3684         (tui_getc): Update.
3685         * tui/tui-disasm.c (tui_set_disassem_content)
3686         (tui_disasm_window::do_scroll_vertical): Update.
3687         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3688         Now virtual.
3689         (struct tui_win_info): Derive from tui_gen_win_info.
3690         <~tui_win_info>: Mark as override.
3691         <generic>: Remove member.
3692         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3693         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3694         (~tui_data_window, ~tui_win_info)
3695         (tui_free_all_source_wins_content): Update.
3696         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3697
3698 2019-06-25  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui-layout.c (init_and_make_win): Use new.
3701         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3702         destructor, initializers.
3703         (tui_alloc_generic_win_info): Don't declare.
3704         * tui/tui-data.c (_locator): Add argument to constructor.
3705         (source_win, disasm_win): New globals.
3706         (exec_info): Remove.
3707         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3708         Update.
3709         (tui_alloc_generic_win_info): Remove.
3710         (init_content_element): Use new.
3711         (tui_win_info::tui_win_info): Update.
3712         (free_content_elements) <case DATA_WIN>: Use delete.
3713
3714 2019-06-25  Tom Tromey  <tom@tromey.com>
3715
3716         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3717         * tui/tui-windata.c (tui_first_data_item_displayed)
3718         (tui_delete_data_content_windows): Update.
3719         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3720         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3721         (tui_display_registers_from, tui_check_register_values): Update.
3722         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3723         pointer.
3724         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3725         window.
3726         (tui_free_data_content): Update.
3727         (free_content_elements) <case DATA_WIN>: Free the window.
3728
3729 2019-06-25  Tom Tromey  <tom@tromey.com>
3730
3731         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3732         Update.
3733         * tui/tui-layout.c (make_command_window)
3734         (show_source_disasm_command, show_data, init_and_make_win)
3735         (show_source_or_disasm_and_command): Update.
3736         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3737         method.
3738         <can_highight, is_highlighted>: Now bool.
3739         (tui_set_win_highlight): Don't declare.
3740         * tui/tui-data.c (tui_set_win_highlight): Remove.
3741
3742 2019-06-25  Tom Tromey  <tom@tromey.com>
3743
3744         * tui/tui-wingeneral.c (make_visible): Remove check of window
3745         type.
3746
3747 2019-06-25  Tom Tromey  <tom@tromey.com>
3748
3749         * tui/tui-win.c (tui_win_info::max_height)
3750         (tui_cmd_window::max_height): New methods.
3751         (new_height_ok): Call max_height.
3752         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3753         <max_height>: New method.
3754
3755 2019-06-25  Tom Tromey  <tom@tromey.com>
3756
3757         * tui/tui-win.c (tui_source_window_base::set_new_height)
3758         (tui_data_window::set_new_height): New methods.
3759         (make_invisible_and_set_new_height): Call set_new_height method.
3760         * tui/tui-data.h (struct tui_win_info)
3761         (struct tui_source_window_base, struct tui_data_window)
3762         <set_new_height>: New method.
3763
3764 2019-06-25  Tom Tromey  <tom@tromey.com>
3765
3766         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3767         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3768         tui_refresh_data_win.
3769         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3770         method.
3771         (tui_refresh_all_win): Call the refresh_all method.
3772         (tui_set_focus): Likewise.
3773         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3774         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3775         Likewise.
3776
3777 2019-06-25  Tom Tromey  <tom@tromey.com>
3778
3779         * tui/tui-winsource.h (tui_refill_source_window)
3780         (tui_set_is_exec_point_at): Don't declare.
3781         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3782         (tui_source_window_base::refill): Rename from
3783         tui_refill_source_window.
3784         (tui_source_window_base::do_scroll_horizontal): Update.
3785         (tui_source_window_base::set_is_exec_point_at): Rename from
3786         tui_set_is_exec_point_at.
3787         (tui_update_all_breakpoint_info): Update.
3788         * tui/tui-stack.c (tui_show_frame_info): Update.
3789         * tui/tui-layout.c (show_data): Add cast.
3790         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3791         * tui/tui-data.h (struct tui_source_window_base) <refill,
3792         set_is_exec_point_at>: New methods.
3793         (tui_source_windows, tui_add_to_source_windows): Update types.
3794         (tui_add_to_source_windows): Remove redundant declaration.
3795         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3796         (tui_source_windows): Change return type.
3797         (tui_clear_source_windows_detail): Update.
3798         (tui_add_to_source_windows): Change type of parameter.
3799         (tui_free_all_source_wins_content): Update.
3800
3801 2019-06-25  Tom Tromey  <tom@tromey.com>
3802
3803         * tui/tui-wingeneral.c (tui_win_info::refresh)
3804         (tui_source_window_base::refresh): New methods.
3805         (tui_refresh_all): Call the refresh method.
3806         * tui/tui-data.h (struct tui_win_info)
3807         (struct tui_source_window_base) <refresh>: New method.
3808
3809 2019-06-25  Tom Tromey  <tom@tromey.com>
3810
3811         * tui/tui.h (tui_is_window_visible): Return bool.
3812         * tui/tui.c (tui_is_window_visible): Return bool.
3813         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3814         (tui_make_visible, tui_make_invisible)
3815         (tui_win_info::make_visible)
3816         (tui_source_window_base::make_visible, make_all_visible)
3817         (tui_make_all_visible, tui_make_all_invisible): Update.
3818         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3819         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3820         bool.
3821         (struct tui_win_info, struct tui_source_window_base)
3822         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3823         * tui/tui-data.c (tui_init_generic_part): Update.
3824
3825 2019-06-25  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3828         (tui_source_window_base::make_visible): New methods.
3829         (make_all_visible): Make method call.
3830         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3831         (struct tui_source_window_base, struct tui_cmd_window): Override
3832         make_visible.
3833         (tui_win_is_source_type): Don't declare.
3834         * tui/tui-data.c (tui_win_is_source_type): Remove.
3835
3836 2019-06-25  Tom Tromey  <tom@tromey.com>
3837
3838         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3839         NULL check.
3840
3841 2019-06-25  Tom Tromey  <tom@tromey.com>
3842
3843         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3844         Inline constructor.  Add initializers for members.
3845         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3846         constructors; now inline in class.
3847
3848 2019-06-25  Tom Tromey  <tom@tromey.com>
3849
3850         * tui/tui-regs.c (tui_show_registers): Update.
3851         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3852         bool.
3853         * tui/tui-data.c (tui_data_window::clear_detail)
3854         (tui_data_window): Update.
3855
3856 2019-06-25  Tom Tromey  <tom@tromey.com>
3857
3858         * tui/tui-windata.c (tui_display_all_data)
3859         (tui_display_data_from_line, tui_display_data_from)
3860         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3861         Update.
3862         * tui/tui-regs.c (tui_last_regs_line_no)
3863         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3864         (tui_show_registers, tui_show_register_group)
3865         (tui_display_registers_from, tui_display_reg_element_at_line)
3866         (tui_display_registers_from_line, tui_check_register_values)
3867         (tui_reg_next, tui_reg_prev): Update.
3868         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3869         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3870         tui_data_window.
3871         (struct tui_win_info) <detail>: Remove.  Add new fields from
3872         tui_data_info.
3873         (TUI_DATA_WIN): Add cast.
3874         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3875         (~tui_data_window): Simplify.
3876
3877 2019-06-25  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-layout.c (show_source_disasm_command)
3880         (show_source_or_disasm_and_command): Update.
3881         * tui/tui-io.c (update_cmdwin_start_line)
3882         (tui_redisplay_readline): Update.
3883         * tui/tui-data.h (struct tui_command_info): Remove.
3884         (struct tui_win_info) <detail>: Remove command_info member.
3885         (struct tui_data_window) <start_line>: New member, from
3886         tui_command_info.
3887         (TUI_CMD_WIN): Add casts.
3888
3889 2019-06-25  Tom Tromey  <tom@tromey.com>
3890
3891         * tui/tui-winsource.c (tui_update_source_window)
3892         (tui_refill_source_window)
3893         (tui_source_window_base::do_scroll_horizontal)
3894         (tui_update_breakpoint_info, tui_set_exec_info_content)
3895         (tui_show_exec_info_content, tui_erase_exec_info_content)
3896         (tui_clear_exec_info_content): Update.
3897         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3898         Update.
3899         * tui/tui-win.c (make_invisible_and_set_new_height)
3900         (make_visible_with_new_height): Update.
3901         * tui/tui-source.c (tui_set_source_content)
3902         (tui_show_symtab_source): Update.
3903         * tui/tui-layout.c (extract_display_start_addr)
3904         (show_source_disasm_command, show_data)
3905         (make_source_or_disasm_window)
3906         (show_source_or_disasm_and_command): Update.
3907         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3908         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3909         "gdbarch".
3910         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3911         to tui_source_window_base.
3912         (struct tui_win_info) <detail>: Remove source_info member.
3913         (struct tui_source_window_base) <has_locator>: Inline.
3914         Move contents from tui_source_info; rename has_locator member to
3915         m_has_locator.
3916         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3917         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3918         header file.
3919         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3920         Simplify.
3921         (tui_free_all_source_wins_content): Cast to
3922         tui_source_window_base.
3923
3924 2019-06-25  Tom Tromey  <tom@tromey.com>
3925
3926         * tui/tui-win.c (make_invisible_and_set_new_height)
3927         (make_visible_with_new_height): Call has_locator method.
3928         * tui/tui-layout.c (show_source_disasm_command, show_data)
3929         (show_source_or_disasm_and_command): Update for bool change.
3930         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3931         (tui_win_info) <has_locator>: New method.
3932         (struct tui_source_window_base) <has_locator>: New method.
3933         (tui_win_has_locator): Don't declare.
3934         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3935         from tui_win_has_locator.
3936         (tui_source_window_base): Use false, not FALSE.
3937
3938 2019-06-25  Tom Tromey  <tom@tromey.com>
3939
3940         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3941         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3942         clear_detail method directly.
3943         (tui_clear_win_detail): Remove.
3944
3945 2019-06-25  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3948         "this", not TUI_DISASM_WIN.
3949
3950 2019-06-25  Tom Tromey  <tom@tromey.com>
3951
3952         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3953         declare.
3954         * tui/tui-winsource.c
3955         (tui_source_window_base::do_scroll_horizontal): Rename from
3956         tui_horizontal_source_scroll.
3957         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3958         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3959         from tui_vertical_data_scroll.
3960         * tui/tui-win.h (tui_scroll): Don't declare.
3961         * tui/tui-win.c (tui_win_info::forward_scroll)
3962         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3963         (tui_win_info::right_scroll): Rename and update.
3964         (tui_scroll_forward_command, tui_scroll_backward_command)
3965         (tui_scroll_left_command, tui_scroll_right_command): Update.
3966         (tui_scroll): Remove.
3967         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3968         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3969         from tui_vertical_source_scroll.
3970         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3971         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3972         from tui_vertical_disassem_scroll.
3973         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3974         do_scroll_horizontal>: New methods.
3975         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3976         Likewise.
3977         (struct tui_source_window_base): Add do_scroll_horizontal.
3978         (struct tui_source_window, struct tui_disasm_window): Add
3979         do_scroll_vertical.
3980         (struct tui_data_window, struct tui_cmd_window): Add
3981         do_scroll_horizontal and do_scroll_vertical.
3982         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3983
3984 2019-06-25  Tom Tromey  <tom@tromey.com>
3985
3986         * tui/tui-data.h (struct tui_source_window_base): New struct.
3987         (struct tui_source_window): Derive from tui_source_window_base.
3988         (struct tui_disasm_window): New struct.
3989         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3990         from tui_source_window::clear_detail.
3991         (tui_source_window_base): Rename from tui_source_window.
3992         (~tui_source_window_base): Rename from ~tui_source_window.
3993         (tui_alloc_win_info): Create a tui_disasm_window.
3994
3995 2019-06-25  Tom Tromey  <tom@tromey.com>
3996
3997         * tui/tui-data.h (struct tui_source_window)
3998         (struct tui_data_window): Declare destructors.
3999         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4000         destructors.
4001         (tui_win_info): Simplify.
4002
4003 2019-06-25  Tom Tromey  <tom@tromey.com>
4004
4005         * tui/tui-winsource.c (tui_display_main)
4006         (tui_update_source_windows_with_addr)
4007         (tui_update_all_breakpoint_info): Update.
4008         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4009         (new_height_ok, parse_scrolling_args): Update.
4010         * tui/tui-stack.c (tui_show_frame_info): Update.
4011         * tui/tui-data.h (struct tui_list): Remove.
4012         (tui_source_windows): Return a reference to a std::vector.
4013         * tui/tui-data.c (source_windows): Now a std::vector.
4014         (tui_source_windows): Change return type.
4015         (tui_clear_source_windows): Rewrite.
4016         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4017         (tui_free_all_source_wins_content): Rewrite.
4018
4019 2019-06-25  Tom Tromey  <tom@tromey.com>
4020
4021         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4022         (struct tui_data_window, struct tui_cmd_window): Declare
4023         clear_detail method.
4024         * tui/tui-data.c (tui_source_window::clear_detail)
4025         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4026         methods.
4027         (tui_clear_win_detail): Simplify.
4028
4029 2019-06-25  Tom Tromey  <tom@tromey.com>
4030
4031         * tui/tui-layout.c (make_source_window, make_disasm_window)
4032         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4033         Return the new window.
4034         (show_source_disasm_command, show_data)
4035         (show_source_or_disasm_and_command): Update.
4036
4037 2019-06-25  Tom Tromey  <tom@tromey.com>
4038
4039         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4040         parameter.  Return the new window.
4041         (show_source_disasm_command): Update and remove NULL check.
4042         (show_source_or_disasm_and_command): Update.
4043
4044 2019-06-25  Tom Tromey  <tom@tromey.com>
4045
4046         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4047
4048 2019-06-25  Tom Tromey  <tom@tromey.com>
4049
4050         * tui/tui-data.h (struct tui_win_info): Make constructor
4051         protected.  Make destructor virtual.  Add initializers.
4052         (tui_source_window, tui_data_window, tui_cmd_window): New
4053         classes.
4054         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4055         constructor.  Add "type" parameter.
4056         (tui_source_window, tui_data_window, tui_cmd_window): New
4057         constructors.
4058         (tui_alloc_win_info): Instantiate the appropriate subclass.
4059
4060 2019-06-25  Tom Tromey  <tom@tromey.com>
4061
4062         * tui/tui-win.c (tui_resize_all): Use delete.
4063         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4064         destructor.
4065         (tui_free_window): Don't declare.
4066         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4067         Update.
4068
4069 2019-06-25  Tom Tromey  <tom@tromey.com>
4070
4071         * tui/tui-data.h (struct tui_win_info): Add constructor.
4072         * tui/tui-data.c (tui_alloc_win_info): Use new.
4073         (tui_free_window): Use delete.
4074
4075 2019-06-22  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4078         declare.
4079         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4080
4081 2019-06-22  Tom Tromey  <tom@tromey.com>
4082
4083         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4084         declare.
4085         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4086
4087 2019-06-22  Tom de Vries  <tdevries@suse.de>
4088
4089         * dwarf2read.c (create_addrmap_from_aranges)
4090         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4091         instead of '%zu'.
4092
4093 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4094
4095         * dwarf2read.h (dwarf2_section_info_def): Remove.
4096         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4097         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4098         std::vector<dwarf2_section_info>.
4099         (struct dwo_file) <~dwo_file>: Remove.
4100         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4101         types field.
4102         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4103         (dwarf2_read_debug_names): Likewise.
4104         (create_debug_types_hash_table): Change parameter type to
4105         array_view, adjust code accordingly.
4106         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4107         (partial_die_info::fixup): Likewise.
4108         (determine_prefix): Likewise.
4109         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4110
4111 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4112
4113         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4114         gdb_bfd_ref_ptr.
4115         <~dwo_file>: Remove call to gdb_bfd_unref.
4116         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4117         gdb_bfd_ref_ptr::get.
4118
4119 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4120
4121         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4122         type to htab_up.
4123         * dwarf2read.c (struct dwo_file): Initialize fields.
4124         <~dwo_file>: New.
4125         (free_dwo_file): Remove, move content to ~dwo_file.
4126         (struct dwo_file_deleter): Remove.
4127         (dwo_file_up>: Remove custom deleter.
4128         (free_dwo_files): Remove.
4129         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4130         dwo_files.
4131         (process_skeletonless_type_units): Call unique_ptr::get.
4132         (allocate_dwo_file_hash_table): Add deleter to created hash
4133         table.  Change return type to htab_up.
4134         (lookup_dwo_file_slot): Don't memset dwo_file, call
4135         unique_ptr::get.
4136         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4137         (create_dwo_unit_in_dwp_v2): Likewise.
4138         (open_and_init_dwo_file): Likewise.
4139         (free_dwo_file_from_slot): Remove.
4140
4141 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4142
4143         * dwarf2read.h (struct dwarf2_section_info) <readin,
4144         is_virtual>: Change type to bool.
4145         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4146         true instead of 1.
4147
4148 2019-06-19  Tom Tromey  <tom@tromey.com>
4149
4150         * tui/tui-data.h (tui_init_content_element): Don't declare.
4151
4152 2019-06-19  Tom Tromey  <tom@tromey.com>
4153
4154         * tui/tui-data.h (tui_init_win_info): Don't declare.
4155
4156 2019-06-19  Tom de Vries  <tdevries@suse.de>
4157
4158         * dwarf2read.h (abstract_to_concrete): Change type to
4159         std::unordered_map<sect_offset, std::vector<sect_offset>,
4160         gdb::hash_enum<sect_offset>>.
4161
4162 2019-06-19  Tom Tromey  <tromey@adacore.com>
4163
4164         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4165         EVAL_AVOID_SIDE_EFFECTS specially.
4166
4167 2019-06-19  Tom Tromey  <tromey@adacore.com>
4168
4169         * source-cache.c (highlighter): New global.
4170         (source_cache::get_source_lines): Create a highlighter on demand.
4171
4172 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4173
4174         * defs.h (deprecated_interactive_hook): Delete declaration.
4175         * interps.c (clear_interpreter_hooks): Remove use of
4176         deprecated_interactive_hook.
4177         * top.c (deprecated_interactive_hook): Delete definition.
4178         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4179
4180 2019-06-18  Tom de Vries  <tdevries@suse.de>
4181
4182         PR gdb/24515
4183         * dwarf2read.h (abstract_to_concrete): Change type from
4184         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4185         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4186         * dwarf2read.c (read_variable): Update.
4187         (dwarf2_fetch_die_loc_sect_off): Update.
4188
4189 2019-06-17  Tom de Vries  <tdevries@suse.de>
4190
4191         PR gdb/24617
4192         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4193         accessing parent[parent_len - 1].
4194
4195 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4196
4197         PR gdb/24364
4198         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4199         call dtrace_process_dof with NULL dof.
4200
4201 2019-06-16  Tom de Vries  <tdevries@suse.de>
4202
4203         PR gdb/24445
4204         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4205
4206 2019-06-16  Tom Tromey  <tom@tromey.com>
4207
4208         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4209         (make_all_visible): Use address of member.
4210
4211 2019-06-16  Tom Tromey  <tom@tromey.com>
4212
4213         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4214         (tui_free_window, free_content, free_content_elements): Remove
4215         unnecessary cast.
4216         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4217         cast.
4218         * tui/tui-regs.c (tui_show_register_group)
4219         (tui_display_registers_from, tui_display_reg_element_at_line):
4220         Remove unnecessary cast.
4221
4222 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * linux-nat.c (normal_mask): Delete.
4225         (_initialize_linux_nat): Don't initialise normal_mask.
4226
4227 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4228
4229         PR gdb/24445
4230         * dwarf-index-write.h (write_psymtabs_to_index): Add
4231         dwz_basename parameter.
4232         * dwarf-index-write.c (write_gdbindex): Move file writing to
4233         write_gdbindex_1.  Change return type void.
4234         (assert_file_size): Move up, remove filename parameter.
4235         (write_gdbindex_1): New function.
4236         (write_debug_names): Change return type to void, call
4237         assert_file_size.
4238         (struct index_wip_file): New struct.
4239         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4240         file logic to index_wip_file.  Write index for dwz file if
4241         needed.
4242         (save_gdb_index_command): Pass basename of dwz file, if present.
4243         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4244         build-id of dwz file, if present.
4245         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4246         (dwarf2_get_dwz_file): Likewise.
4247         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4248         (dwarf2_get_dwz_file): Likewise.
4249
4250 2019-06-16  Tom Tromey  <tom@tromey.com>
4251
4252         * coffread.c (process_coff_symbol): Use xstrdup.
4253         * value.c (create_internalvar): Use xstrdup.
4254
4255 2019-06-16  Tom Tromey  <tom@tromey.com>
4256
4257         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4258         * breakpoint.c (stopin_command, stopat_command)
4259         (until_break_command, decode_location_default): Remove unnecessary
4260         cast.
4261         * utils.c (subset_compare): Remove unnecessary cast.
4262         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4263         cast.
4264         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4265         cast.
4266         * infcmd.c (path_command): Remove unnecessary cast.
4267         * coffread.c (decode_type): Remove unnecessary cast.
4268         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4269         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4270         * tui/tui-stack.c (tui_show_locator_content)
4271         (tui_show_frame_info): Remove unnecessary cast.
4272         * tui/tui-win.c (tui_scroll_forward_command)
4273         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4274         (parse_scrolling_args): Remove unnecessary cast.
4275         * tui/tui-data.c (init_win_info, tui_del_window)
4276         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4277         (free_content_elements): Remove unnecessary cast.
4278         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4279         unnecessary cast.
4280         * tui/tui-source.c (tui_set_source_content)
4281         (tui_vertical_source_scroll): Remove unnecessary cast.
4282         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4283         cast.
4284         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4285         * tui/tui-regs.c (tui_display_registers_from)
4286         (tui_display_register): Remove unnecessary cast.
4287         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4288         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4289         (make_visible): Remove unnecessary cast.
4290         * tui/tui-winsource.c (tui_erase_source_content)
4291         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4292         unnecessary cast.
4293         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4294         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4295         * stabsread.c (read_type, read_array_type, read_range_type):
4296         Remove unnecessary cast.
4297         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4298         (parse_symbol, parse_type, upgrade_type, parse_external)
4299         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4300         unnecessary cast.
4301         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4302
4303 2019-06-16  Tom Tromey  <tom@tromey.com>
4304
4305         * tui/tui-data.c (tui_alloc_generic_win_info)
4306         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4307         checks.
4308
4309 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4310             Andrew Burgess  <andrew.burgess@embecosm.com>
4311
4312         * f-typeprint.c (f_print_type): Don't return early for not
4313         associated or not allocated types.
4314         (f_type_print_varspec_suffix): Add print_rank parameter and print
4315         ranks of array types in case they dangling.
4316         (f_type_print_base): Add print_rank parameter.
4317
4318 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4319
4320         * NEWS: Mention new MI commands.
4321         * break-catch-throw.c (enum exception_event_kind): Move to
4322         breakpoint.h.
4323         (print_mention_exception_catchpoint): Output text as a single
4324         message.
4325         (catch_exception_command_1): Rename to...
4326         (catch_exception_event): ...this, make non-static, update header
4327         command, and change some parameter types.
4328         (catch_catch_command): Update for changes to
4329         catch_exception_command_1.
4330         (catch_throw_command): Likewise.
4331         (catch_rethrow_command): Likewise.
4332         * breakpoint.c (enum exception_event_kind): Delete.
4333         * breakpoint.h (enum exception_event_kind): Moved here from
4334         break-catch-throw.c.
4335         (catch_exception_event): Declare.
4336         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4337         (mi_cmd_catch_throw): New function.
4338         (mi_cmd_catch_rethrow): New function.
4339         (mi_cmd_catch_catch): New function.
4340         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4341         'catch-catch' entries.
4342         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4343         (mi_cmd_catch_rethrow): Declare.
4344         (mi_cmd_catch_catch): Declare.
4345
4346 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4347
4348         * annotate.c (annotate_source_line): Change return type to void,
4349         update implementation to match.
4350         * annotate.h (annotate_source_line): Change return type to void,
4351         update header comment.
4352         * stack.c (print_frame_info): Don't change what frame information
4353         is printed based on whether annotations are on or not.
4354
4355 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4358         (annotate_source): Make static.
4359         (annotate_source_line): Moved from source.c and renamed from
4360         identify_source_line.  Update the return type.
4361         * annotate.h (annotate_source): Delete declaration.
4362         (annotate_source_line): Declaration moved from source.h, and
4363         renamed from identify_source_line.  Return type updated.
4364         * source.c (identify_source_line): Moved to annotate.c and renamed
4365         to annotate_source_line.
4366         (info_line_command): Remove check of annotation_level.
4367         * source.h (identify_source_line): Move declaration to annotate.h
4368         and rename to annotate_source_line.
4369         * stack.c: Add 'annotate.h' include.
4370         (print_frame_info): Remove check of annotation_level before
4371         calling annotate_source_line.
4372
4373 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         * source-cache.c (source_cache::get_plain_source_lines): Use
4376         open_source_file_with_line_charpos instead of just
4377         open_source_file, remove call to find_source_lines.
4378         (source_cache::get_source_lines): Likewise.
4379         * source.c (find_source_lines): Make static.
4380         (get_filename_and_charpos): Renamed into...
4381         (open_source_file_with_line_charpos): ..this along with changes to
4382         return a scoped_fd, and some other minor clean ups.
4383         (identify_source_line): Use open_source_file_with_line_charpos.
4384         (search_command_helper): Use open_source_file_with_line_charpos
4385         instead of just open_source_file, remove call to
4386         find_source_lines.
4387         * source.h (open_source_file_with_line_charpos): Declare new
4388         function.
4389         (find_source_lines): Delete declaration.
4390
4391 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * source.c (get_filename_and_charpos): Remove fullname
4394         parameter.
4395         (identify_source_line): Update call to get_filename_and_charpos.
4396
4397 2019-06-14  Tom Tromey  <tromey@adacore.com>
4398
4399         PR gdb/24502:
4400         * ui-style.h (skip_ansi_escape): Update comment.
4401         * ui-file.h (class no_terminal_escape_file): New class.
4402         * ui-file.c (no_terminal_escape_file::write)
4403         (no_terminal_escape_file::puts): New methods.
4404         * cli/cli-logging.c (handle_redirections): Use
4405         no_terminal_escape_file.
4406
4407 2019-06-14  Tom Tromey  <tromey@adacore.com>
4408
4409         * NEWS: Move convenience variable news above Python news.
4410
4411 2019-06-14  Tom Tromey  <tom@tromey.com>
4412
4413         * gnulib: Move directory to top-level.
4414         * configure.ac: Don't configure gnulib.
4415         * configure: Rebuild.
4416         * common/common-defs.h: Use new path to gnulib.
4417         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4418         (GNULIB_H): Remove.
4419         (INCGNU): Look in new gnulib location.
4420         (HFILES_NO_SRCDIR): Remove gnulib files.
4421         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4422         (generated_files): Remove GNULIB_H.
4423         ($(LIBGNU), all-lib): Remove targets.
4424         (distclean): Don't mention GNULIB_BUILDDIR.
4425         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4426
4427 2019-06-14  Tom Tromey  <tromey@adacore.com>
4428
4429         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4430         Warn if symbol file does not provide any symbols.
4431
4432 2019-06-14  Tom Tromey  <tromey@adacore.com>
4433
4434         * source.c (find_and_open_source): Respect basenames_may_differ.
4435
4436 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4437
4438         * annotate.c (annotate_breakpoints_invalid): Make use of
4439         scoped_restore_terminal_state.
4440         (annotate_frames_invalid): Likewise.
4441
4442 2019-06-14  Tom Tromey  <tromey@adacore.com>
4443
4444         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4445         allow assignment to an internalvar.
4446
4447 2019-06-14  Tom Tromey  <tromey@adacore.com>
4448
4449         * ada-lex.l: Allow "_" in attribute names.
4450
4451 2019-06-14  Tom Tromey  <tromey@adacore.com>
4452
4453         PR gdb/24653:
4454         * regcache.c (registers_changed): Don't call alloca.
4455         * top.c (execute_command): Don't call alloca.
4456
4457 2019-06-13  Pedro Alves  <palves@redhat.com>
4458
4459         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4460         'expression'.  When parsing an expression, error out if there's
4461         junk after "unlimited".
4462         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4463         (do_set_command): Adjust calls to is_unlimited_literal.
4464
4465 2019-06-13  Pedro Alves  <palves@redhat.com>
4466
4467         * compile/compile.c (make_compile_options_def_group): Add braces
4468         around array_view initializer.
4469         * thread.c (make_thread_apply_all_options_def_group)
4470         (make_thread_apply_all_options_def_group): Likewise.
4471
4472 2019-06-13  Pedro Alves  <palves@redhat.com>
4473
4474         * NEWS (New commands): Mention "maint test-options
4475         require-delimiter", "maint test-options unknown-is-error", "maint
4476         test-options unknown-is-operand" and "maint show
4477         test-options-completion-result".
4478         (New command options, command completion): New section.
4479         (Completion improvements): New section.
4480         Mention that you can abbreviate "unlimited".
4481
4482 2019-06-13  Pedro Alves  <palves@redhat.com>
4483
4484         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4485         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4486         * unittests/cli-utils-selftests.c (test_parse_flags)
4487         (test_parse_flags_qcs): Delete.
4488         (test_cli_utils): Don't call deleted functions.
4489
4490 2019-06-13  Pedro Alves  <palves@redhat.com>
4491
4492         * thread.c: Include "cli/cli-option.h".
4493         (tp_array_compar_ascending): Global.
4494         (tp_array_compar): Delete function.
4495         (tp_array_compar_ascending, tp_array_compar_descending): New
4496         functions.
4497         (ascending_option_def, qcs_flag_option_def)
4498         (thr_qcs_flags_option_defs)
4499         (make_thread_apply_all_options_def_group)
4500         (make_thread_apply_options_def_group): New.
4501         (thread_apply_all_command): Use gdb::option::process_options.
4502         (thread_apply_command_completer)
4503         (thread_apply_all_command_completer): New.
4504         (thread_apply_command): Use gdb::option::process_options.
4505         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4506         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4507         to generate help text of "thread apply".  Adjust "taas"'s help.
4508         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4509         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4510
4511 2019-06-13  Pedro Alves  <palves@redhat.com>
4512
4513         * thread.c (thread_apply_command): Check for invalid TID with
4514         isdigit instead of !isalpha.
4515
4516 2019-06-13  Pedro Alves  <palves@redhat.com>
4517
4518         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4519         (validate_flags_qcs): New.
4520         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4521         (validate_flags_qcs): Declare.
4522         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4523         (make_frame_apply_options_def_group): New.
4524         (frame_apply_command_count): Process options with
4525         gdb::option::process_options.
4526         (frame_apply_completer): New.
4527         (frame_apply_level_completer, frame_apply_all_completer)
4528         (frame_apply_completer): New.
4529         (_initialize_stack): Update help of "frame apply", "frame apply
4530         level", "frame apply all" and "faas" to mention supported options
4531         and install command completers.
4532         * stack.h (frame_apply_all_completer): Declare.
4533         * thread.c: Include "stack.h".
4534         (tfaas_command): Add "--".
4535         (_initialize_thread): Update help "tfaas" to mention supported
4536         options and install command completer.
4537
4538 2019-06-13  Pedro Alves  <palves@redhat.com>
4539
4540         * completer.c (complete_nested_command_line): New.
4541         (gdb_completion_word_break_characters_throw): Add assertion.
4542         * completer.h (complete_nested_command_line): Declare.
4543
4544 2019-06-13  Pedro Alves  <palves@redhat.com>
4545
4546         * stack.c (parse_backtrace_qualifiers): New.
4547         (backtrace_command): Use it.
4548         (backtrace_command_completer): Complete on qualifiers.
4549
4550 2019-06-13  Pedro Alves  <palves@redhat.com>
4551
4552         * frame.c: Include "cli/cli-option.h.
4553         (user_set_backtrace_options): New.
4554         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4555         Delete.
4556         (get_prev_frame): Adjust.
4557         (boolean_option_def, uinteger_option_def)
4558         (set_backtrace_option_defs): New.
4559         (_initialize_frame): Adjust and use
4560         gdb::option::add_setshow_cmds_for_options to install "set
4561         backtrace past-main" and "set backtrace past-entry".
4562         * frame.h: Include "cli/cli-option.h".
4563         (struct frame_print_options): Forward declare.
4564         (print_frame_arguments_all, print_frame_arguments_scalars)
4565         (print_frame_arguments_none): Declare.
4566         (print_entry_values): Delete declaration.
4567         (struct frame_print_options, user_frame_print_options): New.
4568         (struct set_backtrace_options): New.
4569         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4570         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4571         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4572         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4573         (list_args_or_locals): Add frame_print_options parameter.
4574         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4575         * python/py-framefilter.c (enumerate_args): Pass down
4576         USER_FRAME_PRINT_OPTIONS.
4577         * stack.c: Include "cli/cli-option.h".
4578         (print_frame_arguments_all, print_frame_arguments_scalars)
4579         (print_frame_arguments_none): Declare.
4580         (print_raw_frame_arguments, print_entry_values): Delete.
4581         (user_frame_print_options): New.
4582         (boolean_option_def, enum_option_def, frame_print_option_defs):
4583         New.
4584         (struct backtrace_cmd_options): New.
4585         (bt_flag_option_def): New.
4586         (backtrace_command_option_defs): New.
4587         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4588         (print_frame_arg, read_frame_arg, print_frame_args)
4589         (print_frame_info, print_frame): Add frame_print_options parameter
4590         and use it.
4591         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4592         (backtrace_command_1): Add frame_print_options and
4593         backtrace_cmd_options parameters and use them.
4594         (make_backtrace_options_def_group): New.
4595         (backtrace_command): Process command options with
4596         gdb::option::process_options.
4597         (backtrace_command_completer): New.
4598         (_initialize_stack): Extend "backtrace"'s help to mention
4599         supported options.  Install completer for "backtrace".
4600         Install some settings commands with add_setshow_cmds_for_options.
4601
4602 2019-06-13  Pedro Alves  <palves@redhat.com>
4603
4604         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4605         and that "set/show print raw frame-arguments" are now deprecated.
4606
4607         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4608         command.
4609         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4610         * stack.c (_initialize_stack): Install "set/show print
4611         raw-frame-arguments", and deprecate "set/show print raw
4612         frame-arguments".
4613         * valprint.c (_initialize_valprint): Deprecate "set/show print
4614         raw".
4615
4616 2019-06-13  Pedro Alves  <palves@redhat.com>
4617
4618         * compile/compile.c (struct compile_options): New.
4619         (compile_flag_option_def, compile_command_option_defs)
4620         (make_compile_options_def_group): New.
4621         (compile_file_command): Handle options with
4622         gdb::option::process_options.
4623         (compile_file_command_completer): New function.
4624         (compile_code_command): Handle options with
4625         gdb::option::process_options.
4626         (compile_code_command_completer): New function.
4627         (_initialize_compiler): Install completers for "compile code" and
4628         "compile file".  Mention available options in "compile code" and
4629         "compile code"'s help.
4630         * completer.c (advance_to_completion_word): New, factored out from
4631         ...
4632         (advance_to_expression_complete_word_point): ... this.
4633         (advance_to_filename_complete_word_point): New.
4634         * completer.h (advance_to_filename_complete_word_point): New
4635         declaration.
4636
4637 2019-06-13  Pedro Alves  <palves@redhat.com>
4638
4639         * compile/compile.c: Include "cli/cli-option.h".
4640         (compile_print_value): Scope data pointer is now a
4641         value_print_options pointer; adjust.
4642         (compile_print_command): Process options.  Scope data pointer is
4643         now a value_print_options pointer; adjust.
4644         (_initialize_compile): Update "compile print"'s help to include
4645         supported options.  Install a completer for "compile print".
4646         * cp-valprint.c (show_vtblprint, show_objectprint)
4647         (show_static_field_print): Delete.
4648         (_initialize_cp_valprint): Don't install "set print
4649         static-members", "set print vtbl", "set print object" here.
4650         * printcmd.c: Include "cli/cli-option.h" and
4651         "common/gdb_optional.h".
4652         (print_command_parse_format): Rework to fill in a
4653         value_print_options instead of a format_data.
4654         (print_value): Change parameter type from format_data pointer to
4655         value_print_options reference.  Adjust.
4656         (print_command_1): Process options.  Adjust to pass down a
4657         value_print_options.
4658         (print_command_completer): New.
4659         (_initialize_printcmd): Install print_command_completer as
4660         handle_brkchars completer for the "print" command.  Update
4661         "print"'s help to include supported options.
4662         * valprint.c: Include "cli/cli-option.h".
4663         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4664         here from cp-valprint.c.
4665         (boolean_option_def, uinteger_option_def)
4666         (value_print_option_defs, make_value_print_options_def_group):
4667         New.  Use gdb::option::add_setshow_cmds_for_options to install
4668         "set print elements", "set print null-stop", "set print repeats",
4669         "set print pretty", "set print union", "set print array", "set
4670         print address", "set print symbol", "set print array-indexes".
4671         * valprint.h: Include <string> and "cli/cli-option.h".
4672         (make_value_print_options_def_group): Declare.
4673         (print_value): Change parameter type from format_data pointer to
4674         value_print_options reference.
4675         (print_command_completer): Declare.
4676
4677 2019-06-13  Pedro Alves  <palves@redhat.com>
4678
4679         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4680         (COMMON_SFILES): Add maint-test-settings.c.
4681         * cli/cli-decode.c (boolean_enums): New global, factored out from
4682         ...
4683         (add_setshow_boolean_cmd): ... here.
4684         * cli/cli-decode.h (boolean_enums): Declare.
4685         * cli/cli-option.c: New file.
4686         * cli/cli-option.h: New file.
4687         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4688         factored out from ...
4689         (parse_cli_boolean_value(const char *)): ... this.
4690         (is_unlimited_literal): Change parameter type to pointer to
4691         pointer.  Adjust and advance ARG pointer.
4692         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4693         (parse_cli_var_enum): New, factored out from ...
4694         (do_set_command): ... this.  Adjust.
4695         * cli/cli-setshow.h (parse_cli_boolean_value)
4696         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4697         (parse_cli_var_enum): Declare.
4698         * cli/cli-utils.c: Include "cli/cli-option.h".
4699         (get_ulongest): New.
4700         * cli/cli-utils.h (get_ulongest): Declare.
4701         (check_for_argument): New overloads.
4702         * maint-test-options.c: New file.
4703
4704 2019-06-13  Pedro Alves  <palves@redhat.com>
4705
4706         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4707         parse a range if "-" is at the end of the string.
4708
4709 2019-06-13  Pedro Alves  <palves@redhat.com>
4710
4711         * cli/cli-setshow.c (parse_auto_binary_operation)
4712         (parse_cli_boolean_value): Don't allow "o".
4713
4714 2019-06-13  Pedro Alves  <palves@redhat.com>
4715
4716         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4717         * NEWS: Mention maint test-settings KIND.
4718         * maint-test-settings.c: New file.
4719
4720 2019-06-13  Pedro Alves  <palves@redhat.com>
4721
4722         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4723         completer.
4724         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4725         "set" completers.
4726
4727 2019-06-13  Pedro Alves  <palves@redhat.com>
4728
4729         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4730         after item.
4731
4732 2019-06-13  Pedro Alves  <palves@redhat.com>
4733
4734         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4735
4736 2019-06-13  Pedro Alves <palves@redhat.com>
4737
4738         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4739         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4740         call.
4741         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4742         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4743         calls.
4744         (check_for_argument): Skip spaces after argument.
4745
4746 2019-06-13  Pedro Alves  <palves@redhat.com>
4747
4748         * thread.c (thread_apply_command): Adjust TID parsing.
4749         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4750         detected before end of string.
4751         (tid_is_in_list): Error out if LIST is invalid.
4752
4753 2019-06-13  Pedro Alves  <palves@redhat.com>
4754
4755         * completer.c (complete_line_internal_1): Rewind completion word
4756         point.
4757         (completion_tracker::advance_custom_word_point_by): Change
4758         parameter type to int.
4759         * completer.h (completion_tracker::advance_custom_word_point_by):
4760         Likewise.
4761
4762 2019-06-13  Pedro Alves  <palves@redhat.com>
4763
4764         * completer.c (advance_to_completion_word): Handle delimiters.
4765
4766 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4767
4768         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4769
4770 2019-06-11  Tom Tromey  <tom@tromey.com>
4771
4772         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4773         (xmalloc_failed): Move to alloc.c.
4774         * alloc.c: New file.
4775         * Makefile.in (COMMON_SFILES): Add alloc.c.
4776
4777 2019-06-11  Tom Tromey  <tom@tromey.com>
4778
4779         * nat/linux-waitpid.c: Don't include server.h.
4780         (linux_debug): Remove.
4781         (my_waitpid): Update.
4782
4783 2019-06-11  Tom Tromey  <tromey@adacore.com>
4784
4785         * infcall.c (_initialize_infcall): Remove trailing newline from
4786         help.
4787         * user-regs.c (_initialize_user_regs): Remove trailing newline
4788         from help.
4789         * typeprint.c (_initialize_typeprint): Remove trailing newline
4790         from help.
4791         * reverse.c (_initialize_reverse): Remove trailing newlines from
4792         help.
4793         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4794         from help.
4795         * language.c (add_set_language_command): Remove trailing newline
4796         from help.
4797         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4798         help.
4799         * disasm.c (_initialize_disasm): Remove trailing newline from
4800         help.
4801         * top.c (init_main): Remove trailing newline from help.
4802         * interps.c (_initialize_interpreter): Remove trailing newline
4803         from help.
4804         * btrace.c (_initialize_btrace): Remove trailing newlines from
4805         help.
4806         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4807         from help.
4808         * python/python.c (_initialize_python): Remove trailing newline
4809         from help.
4810         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4811         help.
4812         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4813         from help.  Reformat some text.
4814         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4815         from help.
4816         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4817         newline from help.
4818
4819 2019-06-11  Tom Tromey  <tromey@adacore.com>
4820
4821         * darwin-nat.c (darwin_decode_exception_message)
4822         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4823
4824 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4825
4826         * valops.c (value_slice): Check for not allocated or not
4827         associated values.
4828
4829 2019-06-10  Tom de Vries  <tdevries@suse.de>
4830
4831         PR gdb/24618
4832         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4833         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4834         invalid.
4835
4836 2019-06-10  Tom de Vries  <tdevries@suse.de>
4837
4838         PR gdb/24611
4839         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4840         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4841
4842 2019-06-10  Tom de Vries  <tdevries@suse.de>
4843
4844         PR symtab/24545
4845         * symtab.c (struct demangled_name_entry): Add language field.
4846         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4847         static minimal symbol".  Set and use language field.
4848
4849 2019-06-10  Tom Tromey  <tromey@adacore.com>
4850
4851         * ada-lang.c (_initialize_ada_language): Update help text.
4852
4853 2019-06-10  Tom Tromey  <tromey@adacore.com>
4854
4855         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4856         with a newline.
4857         * guile/guile.c (handle_boot_error): Don't end warning with a
4858         newline.
4859         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4860         warning with a newline.
4861         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4862         newline.
4863         (s12z_frame_cache): Likewise.
4864         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4865         a newline.
4866         * solib-svr4.c (disable_probes_interface): Don't end warning with
4867         a newline.
4868         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4869         newline.
4870         * python/python.c (do_finish_initialization): Don't end warning
4871         with a newline.
4872
4873 2019-06-10  Tom Tromey  <tom@tromey.com>
4874
4875         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4876         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4877         gdbpy_enter.
4878
4879 2019-06-10  Tom Tromey  <tromey@adacore.com>
4880
4881         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4882         data.
4883         (elf_new_init): Don't call stabsread_new_init.
4884         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4885         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4886         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4887
4888 2019-06-10  Tom de Vries  <tdevries@suse.de>
4889
4890         PR symtab/16264
4891         PR symtab/24517
4892         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4893
4894 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4895
4896         * source.c (find_and_open_source): Also rewrite relative file
4897         names.
4898
4899 2019-04-26  Amos Bird  <amosbird@gmail.com>
4900
4901         * annotate.c (annotate_thread_exited): Add "thread-exited"
4902         annotation.
4903
4904 2019-06-06  Tom Tromey  <tromey@adacore.com>
4905
4906         * maint.h (class scoped_command_stats): Use
4907         DISABLE_COPY_AND_ASSIGN.
4908         <print_time>: New method.
4909         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4910         print_time.
4911         (scoped_command_stats::print_time): New method.
4912
4913 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4916         instructions of lengths 6 or 8 bytes.
4917
4918 2019-06-04  Pedro Alves  <palves@redhat.com>
4919
4920         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4921
4922         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4923         * breakpoint.c (condition_completer): Likewise.
4924         * cli/cli-dump.c (scan_expression): Likewise.
4925         * common/filestuff.c (mkdir_recursive): Likewise.
4926         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4927         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4928         (gdb_abspath): Likewise.
4929         * compile/compile-cplus-types.c
4930         (compile_cplus_instance::decl_name): Likewise.
4931         * completer.c (complete_explicit_location):
4932         (signal_completer, reg_or_group_completer_1): Likewise.
4933         * cp-support.c (cp_remove_params_if_any): Likewise.
4934         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4935         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4936         * infcmd.c (strip_bg_char): Likewise.
4937         * linespec.c (copy_token_string): Likewise.
4938         * mi/mi-main.c (output_cores): Likewise.
4939         * psymtab.c (psymtab_search_name):
4940         * symfile.c (test_set_ext_lang_command): Likewise.
4941         * target.c (target_fileio_read_stralloc): Likewise.
4942         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4943         * value.c (complete_internalvar): Likewise.
4944
4945 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4946
4947         Add objfile property to gdb.Type.
4948         * NEWS: Mention Python API addition.
4949         * python/py-type.c (typy_get_objfile): New method.
4950
4951 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4952
4953         * NEWS: Mention the new set|show style [title|highlight].
4954         Mention changes to "show style", "help" and "apropos".
4955
4956 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4957
4958         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4959         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4960         instead of print_help_for_command.
4961         (print_doc_of_command): New function.
4962         (help_list): Add 'apropos -v word' suggestion.
4963         (print_help_for_command): Style the command name using title style.
4964         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4965         (_initialize_cli_cmds): Describe -v in apropos_command help.
4966
4967 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4968
4969         * cli/cli-style.h (cli_style_option): Add name in constructor,
4970         add m_name class member, add constructor with intensity,
4971         add name class function.
4972         (cli_style_option::add_setshow_commands): Remove name argument.
4973         (highlight_style, title_style): New styles.
4974         * cli/cli-style.c (do_show): New function that shows a style
4975         characteristic styling the style name with itself.
4976         (set_style_name): New function.
4977         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4978         Update all callers according to the changes in cli/cli-style.h.
4979         * utils.h (fputs_highlighted): New function.
4980         * utils.c (fputs_highlighted): Likewise.
4981
4982 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4983
4984         * NEWS: Mention new pipe command and new convenience variables.
4985
4986 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4987
4988         * cli/cli-cmds.c (pipe_command): New function.
4989         (_initialize_cli_cmds): Call add_com for pipe_command.
4990         Define | as an alias for pipe.
4991         (exit_status_set_internal_vars): New function.
4992         (shell_escape): Call exit_status_set_internal_vars.
4993         cli/cli-decode.c (find_command_name_length): Recognize | as
4994         a single character command.
4995
4996 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4997
4998         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4999         top.c (execute_command_to_ui_file): New function, mostly a copy
5000         of execute_command_to_string.
5001         (execute_command_to_string): Implement by calling
5002         execute_command_to_ui_file.
5003
5004 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5005
5006         * top.h (saved_command_line): Remove declaration.
5007         * top.c (previous_saved_command_line, previous_repeat_arguments):
5008         New variables.
5009         (saved_command_line): Make static, define together with other
5010         'repeat variables'.
5011         (dont_repeat): Clear repeat_arguments.
5012         (repeat_previous, get_saved_command_line, save_command_line):
5013         New functions.
5014         (gdb_init): Initialize saved_command_line
5015         and previous_saved_command_line.
5016         * main.c (captured_main_1): Remove saved_command_line initialization.
5017         * event-top.c (handle_line_of_input): Update to use
5018         the new 'repeat' related functions instead of direct access to
5019         saved_command_line.
5020         * command.h (repeat_previous, get_saved_command_line,
5021         save_command_line): New declarations.
5022         (dont_repeat): Add comment.
5023
5024 2019-05-30  Tom Tromey  <tromey@adacore.com>
5025
5026         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5027         Fix comment.
5028         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5029
5030 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5031
5032         PR cli/24587
5033         * completer.c (complete): Initialize variable word.
5034
5035 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5036
5037         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5038         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5039         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5040         'body' is NULL to the outter 'if', protecting the '!is_define'
5041         situation as well.
5042
5043 2019-05-29  Tom Tromey  <tromey@adacore.com>
5044
5045         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5046         (dwarf_unknown): New function.
5047         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5048         (dwarf_type_encoding_name): Use dwarf_unknown.
5049
5050 2019-05-29  Tom Tromey  <tromey@adacore.com>
5051
5052         PR c++/20020:
5053         * cp-valprint.c (cp_print_value_fields): Call
5054         cp_print_static_field inside "try".
5055
5056 2019-05-29  Tom Tromey  <tromey@adacore.com>
5057
5058         * inflow.c (struct terminal_info): Add default operator=.
5059         * configure: Rebuild.
5060         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5061         -Wdeprecated-copy-dtor, -Wredundant-move.
5062
5063 2019-05-29  Tom Tromey  <tromey@adacore.com>
5064
5065         * NEWS: Add entry.
5066         * infcmd.c (print_return_value_1): Handle finish_print
5067         option.
5068         (show_print_finish): New function.
5069         (_initialize_infcmd): Add "set/show print finish" commands.
5070         * valprint.c (user_print_options): Initialize new member.
5071         * valprint.h (struct value_print_options) <finish_print>: New
5072         member.
5073
5074 2019-05-28  Tom Tromey  <tromey@adacore.com>
5075
5076         * ada-lang.c (ada_remove_Xbn_suffix)
5077         (find_old_style_renaming_symbol)
5078         (parse_old_style_renaming): Remove.
5079         (ada_find_renaming_symbol): Don't call
5080         find_old_style_renaming_symbol.
5081         (ada_is_renaming_symbol): Rename from
5082         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5083         bool.  Now static.
5084         (ada_read_var_value): Update and simplify.
5085         * ada-exp.y (write_var_or_type): Remove old code.
5086
5087 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5088
5089         * event-top.c: Remove include comment.
5090         * inflow.c (class scoped_ignore_sigttou): Move from here...
5091         * inflow.h (class scoped_ignore_sigttou): ...to here.
5092         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5093         * top.c:  Remove include comment.
5094
5095 2019-05-27  Tom Tromey  <tom@tromey.com>
5096
5097         * NEWS: Fix typo.
5098
5099 2019-05-22  Tom Tromey  <tromey@adacore.com>
5100
5101         * target.c (target_follow_exec): Constify parameter.
5102         * target-delegates.c: Rebuild.
5103         * remote.c (remote_target::follow_exec): Constify parameter.
5104         * infrun.c (follow_exec): Constify parameter.
5105         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5106         (target_follow_exec): Likewise.
5107
5108 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5109
5110         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5111         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5112
5113 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5114
5115         * NEWS: Add debugredirect and testsuite sections.
5116
5117 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5118
5119         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5120         target descriptions using exclusively floating point register name
5121         aliases.
5122
5123 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5124
5125         PR gdb/18644:
5126         * f-lang.c (build_fortran_types): Handle the case where
5127         gdbarch_floatformat_for_type returns a nullptr.
5128
5129 2019-05-21  Tom de Vries  <tdevries@suse.de>
5130
5131         PR cli/24587
5132         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5133
5134 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         PR gdb/18644:
5137         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5138         16-byte floats.
5139         * i386-tdep.c (i386_floatformat_for_type): Use
5140         floatformats_ia64_quad for the 16-byte floating point component
5141         within a fortran 32-byte complex number.
5142
5143 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5144
5145         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5146         delete default constructor.
5147         (find_partial_die): Update to return const struct.
5148         (partial_die_parent_scope): Move variable declaration into scope
5149         of its use and change its type to auto.
5150         (guess_partial_die_structure_name): Likewise.
5151         (partial_die_info::fixup): Likewise.
5152
5153 2019-05-17  Tom Tromey  <tromey@adacore.com>
5154
5155         * source.c (find_and_open_source): Remove cast.
5156
5157 2019-05-17  Tom Tromey  <tromey@adacore.com>
5158
5159         * annotate.c (annotate_source): Make "filename" const.
5160         * annotate.h (annotate_source): Use const.
5161
5162 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5163
5164         * disasm.c (set_disassembler_options): Send errors to stderr.
5165
5166 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5167
5168         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5169         (cli_interp_base::set_logging): Check debug_redirect.
5170         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5171         * cli/cli-logging.c (debug_redirect): Add static variable.
5172         (pop_output_files): Add default param.
5173         (handle_redirections): Print debug setting.
5174         (show_logging_command): Likewise.
5175         (_initialize_cli_logging): Add debugredirect command.
5176         * interps.c (current_interp_set_logging): Add debug_redirect
5177         parameter.
5178         * interps.h (set_logging): Add debug_redirect parameter.
5179         (current_interp_set_logging): Likewise.
5180         * mi/mi-common.h: Likewise.
5181         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5182
5183 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5184             Tom Tromey  <tromey@adacore.com>
5185
5186         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5187         directly.
5188         * cli/cli-interp.h (make_logging_output): Remove declaration.
5189         * cli/cli-logging.c (make_logging_output): Remove function.
5190         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5191         directly.
5192         * ui-file.c (tee_file::tee_file): Remove bools.
5193         (tee_file::~tee_file): Remove deletes.
5194         * ui-file.h (tee_file): Remove bools.
5195
5196 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5197
5198         * mi/mi-cmds.h (mi_cmd_complete): New function.
5199         * mi/mi-main.c (mi_cmd_complete): Likewise.
5200         * mi/mi-cmds.c: Define new MI command -complete.
5201         * NEWS: Mention new -complete command.
5202
5203 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5204
5205         * completer.h (complete): New function.
5206         * completer.c (complete): Likewise.
5207         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5208         function defined in completer.h.
5209
5210 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5211
5212         * MAINTAINERS (Write After Approval): Add myself.
5213
5214 2019-05-17  Tom de Vries  <tdevries@suse.de>
5215
5216         PR gdb/24094
5217         * dwarf2read.c (struct cu_partial_die_info): New struct.
5218         (find_partial_die): Return cu_partial_die_info.
5219         (partial_die_parent_scope, guess_partial_die_structure_name)
5220         (partial_die_info::fixup): Handle new return type of find_partial_die.
5221
5222 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5223
5224         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5225         "std::string", simplifying the algorithm.
5226
5227 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5228
5229         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5230         (stap_static_probe_ops::get_probes): Likewise.
5231
5232 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5233
5234         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5235         '-')" and "else if".
5236         (stap_parse_single_operand): Join checks for
5237         "gdbarch_stap_parse_special_token_p" and
5238         "gdbarch_stap_parse_special_token" in the same "if" statement.
5239         Invert check when verifying for operation on register
5240         displacement.
5241
5242 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5243
5244         * stap-probe.c (stap_get_opcode): Update comment.
5245         (stap_get_expected_argument_type): Likewise.
5246         (handle_stap_probe): Likewise.
5247
5248 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5249
5250         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5251         return type to 'bool'.  Adjust comment.  Use 'bool' when
5252         appropriate.
5253         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5254         * stap-probe.c (stap_parse_argument_1): Likewise.
5255         (stap_is_operator): Likewise.
5256         (stap_is_generic_prefix): Likewise.
5257         (stap_is_register_prefix): Likewise.
5258         (stap_is_register_indirection_prefix): Likewise.
5259         (stap_is_integer_prefix): Likewise.
5260         (stap_generic_check_suffix): Likewise.
5261         (stap_check_integer_suffix): Likewise.
5262         (stap_check_register_suffix): Likewise.
5263         (stap_check_register_indirection_suffix): Likewise.
5264         (stap_parse_register_operand): Likewise.
5265         (stap_parse_single_operand): Likewise.
5266         (stap_parse_argument_1): Likewise.
5267         (stap_probe::get_argument_count): Likewise.
5268         (stap_is_operator): Likewise.
5269
5270 2019-05-16  Tom Tromey  <tromey@adacore.com>
5271
5272         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5273         keyword to foreach.
5274
5275 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5276
5277         * linux-thread-db.c (try_thread_db_load_1): Change return type
5278         to bool.
5279         (try_thread_db_load): Likewise.
5280         (try_thread_db_load_from_pdir_1): Likewise.
5281         (try_thread_db_load_from_pdir): Likewise.
5282         (try_thread_db_load_from_sdir): Likewise.
5283         (try_thread_db_load_from_dir): Likewise.
5284         (thread_db_load_search): Likewise.
5285         (has_libpthread): Likewise.
5286         (thread_db_load): Likewise.
5287
5288 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5289
5290         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5291         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5292         NULL, and complain/return if that's the case.
5293
5294 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5295
5296         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5297         (advance, posn, abstract_read_memory): New functions.
5298         [struct mem_read_abstraction]: New struct.
5299         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5300
5301 2019-05-14  Tom Tromey  <tromey@adacore.com>
5302
5303         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5304         value is not lval_memory.
5305
5306 2019-05-14  Tom Tromey  <tromey@adacore.com>
5307
5308         * solib.c (info_sharedlibrary_command): Style the file name.
5309
5310 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5311
5312         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5313         (aarch64_vnv_type): Likewise.
5314         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5315         * common/tdesc.c: Likewise.
5316         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5317         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5318         * features/aarch64-fpu.xml: Add ieee half view.
5319         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5320         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5321         * gdbtypes.h (struct builtin_type): Likewise.
5322         (struct objfile_type): Likewise.
5323
5324 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5325
5326         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5327         typo.
5328         * location.h (string_to_event_location): Likewise.
5329
5330 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5331
5332         GDB 8.3 released.
5333
5334 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5335
5336         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5337         New variable declaration.
5338         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5339         New variable.
5340         (print_one_breakpoint): Use ui_out::test_flags and new global
5341         variable to compute use_fixed_output.
5342         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5343         Remove.
5344         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5345         (mi_multi_location_breakpoint_output_fixed): Remove.
5346         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5347         new variable.
5348         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5349         fix_multi_location_breakpoint_output flag if version >= 3.
5350         * ui-out.h (enum ui_out_flag)
5351         <fix_multi_location_breakpoint_output>: New enumerator.
5352
5353 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5354
5355         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5356
5357 2019-05-10  Tom Tromey  <tromey@adacore.com>
5358
5359         * ada-lang.c (catch_ada_completer): New function.
5360         (_initialize_ada_language): Use it.
5361
5362 2019-05-10  Tom Tromey  <tromey@adacore.com>
5363
5364         * thread.c (print_thread_info): Make "requested_threads" const.
5365         * gdbthread.h (print_thread_info): Make "requested_threads"
5366         const.
5367         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5368         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5369
5370 2019-05-08  Tom Tromey  <tom@tromey.com>
5371
5372         * gdbtypes.c (objfile_type_data): Change type.
5373         (objfile_type, _initialize_gdbtypes): Update.
5374
5375 2019-05-08  Tom Tromey  <tom@tromey.com>
5376
5377         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5378         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5379         (_initialize_dwarf2_frame): Update.
5380
5381 2019-05-08  Tom Tromey  <tom@tromey.com>
5382
5383         * objc-lang.c (objc_objfile_data): Change type.
5384         (find_methods): Update.
5385         (_initialize_objc_lang): Remove.
5386
5387 2019-05-08  Tom Tromey  <tom@tromey.com>
5388
5389         * stabsread.c (rs6000_builtin_type_data): Change type.
5390         (rs6000_builtin_type, _initialize_stabsread): Update.
5391
5392 2019-05-08  Tom Tromey  <tom@tromey.com>
5393
5394         * mips-tdep.c (mips_pdr_data): Remove.
5395         (_initialize_mips_tdep): Update.
5396
5397 2019-05-08  Tom Tromey  <tom@tromey.com>
5398
5399         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5400         (hppa_init_objfile_priv_data, read_unwind_info)
5401         (find_unwind_entry, _initialize_hppa_tdep): Update.
5402
5403 2019-05-08  Tom Tromey  <tom@tromey.com>
5404
5405         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5406         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5407         on obstack.
5408         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5409
5410 2019-05-08  Tom Tromey  <tom@tromey.com>
5411
5412         * mdebugread.c (basic_type_data): Change type.
5413         (basic_type, _initialize_mdebugread): Update.
5414
5415 2019-05-08  Tom Tromey  <tom@tromey.com>
5416
5417         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5418
5419 2019-05-08  Tom Tromey  <tom@tromey.com>
5420
5421         * nto-tdep.c (nto_inferior_data_reg): Change type.
5422         (nto_inferior_data): Update.
5423         (nto_inferior_data_cleanup, nto_new_inferior_data)
5424         (_initialize_nto_tdep): Remove.
5425         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5426
5427 2019-05-08  Tom Tromey  <tom@tromey.com>
5428
5429         * ada-lang.c (struct ada_inferior_data): Add initializers.
5430         (ada_inferior_data): Change type.
5431         (ada_inferior_data_cleanup): Remove.
5432         (get_ada_inferior_data, ada_inferior_exit)
5433         (struct ada_pspace_data): Add initializers, destructor.
5434         (ada_pspace_data_handle): Change type.
5435         (get_ada_pspace_data): Update.
5436         (ada_pspace_data_cleanup): Remove.
5437
5438 2019-05-08  Tom Tromey  <tom@tromey.com>
5439
5440         * coffread.c (struct coff_symfile_info): Add initializers.
5441         (coff_objfile_data_key): Move lower.  Change type.
5442         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5443         Update.
5444         (coff_free_info): Remove.
5445
5446 2019-05-08  Tom Tromey  <tom@tromey.com>
5447
5448         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5449         (fbsd_pspace_data_handle): Move lower.  Change type.
5450         (get_fbsd_pspace_data): Update.
5451         (fbsd_pspace_data_cleanup): Remove.
5452         (_initialize_fbsd_tdep): Update.
5453
5454 2019-05-08  Tom Tromey  <tom@tromey.com>
5455
5456         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5457         (get_ada_tasks_pspace_data): Update.
5458         (ada_tasks_pspace_data_cleanup): Remove.
5459         (_initialize_tasks): Update.
5460         (ada_tasks_inferior_data_handle): Change type.
5461         (get_ada_tasks_inferior_data): Update.
5462         (ada_tasks_inferior_data_cleanup): Remove.
5463         (struct ada_tasks_pspace_data): Add initializers.
5464
5465 2019-05-08  Tom Tromey  <tom@tromey.com>
5466
5467         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5468         * symfile-debug.c (debug_sym_get_probes): Change type.
5469         * stap-probe.c (handle_stap_probe):
5470         (stap_static_probe_ops::get_probes): Change type.
5471         * probe.h (class static_probe_ops) <get_probes>: Change type.
5472         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5473         (parse_probes_in_pspace): Update.
5474         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5475         Update.
5476         (any_static_probe_ops::get_probes): Change type.
5477         * elfread.c (elfread_data): New typedef.
5478         (probe_key): Change type.
5479         (elf_get_probes): Likewise.  Update.
5480         (probe_key_free): Remove.
5481         (_initialize_elfread): Update.
5482         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5483         Change type.
5484         (dtrace_process_dof_probe, dtrace_process_dof)
5485         (dtrace_static_probe_ops::get_probe): Change type.
5486
5487 2019-05-08  Tom Tromey  <tom@tromey.com>
5488
5489         * xcoffread.c (struct xcoff_symfile_info): Rename from
5490         coff_symfile_info.  Add initializers.
5491         (xcoff_objfile_data_key): Move lower.  Change type.
5492         (XCOFF_DATA): Rewrite.
5493         (xcoff_free_info): Remove.
5494         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5495         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5496         (xcoff_initial_scan): Update.
5497
5498 2019-05-08  Tom Tromey  <tom@tromey.com>
5499
5500         * solib-svr4.c (struct svr4_info): Add initializers and
5501         destructor.
5502         <probes_table>: Now an htab_up.
5503         (solib_svr4_pspace_data): Change type.
5504         (free_probes_table): Simplify.
5505         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5506         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5507         (probes_table_remove_objfile_probes, register_solib_event_probe)
5508         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5509         (_initialize_svr4_solib): Update.
5510
5511 2019-05-08  Tom Tromey  <tom@tromey.com>
5512
5513         * remote.c (remote_pspace_data): Change type.
5514         (remote_pspace_data_cleanup): Remove.
5515         (get_remote_exec_file, set_pspace_remote_exec_file)
5516         (_initialize_remote): Update.
5517
5518 2019-05-08  Tom Tromey  <tom@tromey.com>
5519
5520         * breakpoint.c (breakpoint_objfile_key): Change type.
5521         (get_breakpoint_objfile_data): Update.
5522         (free_breakpoint_objfile_data): Remove.
5523         (_initialize_breakpoint): Update.
5524
5525 2019-05-08  Tom Tromey  <tom@tromey.com>
5526
5527         * linux-tdep.c (struct linux_info): Add initializers.
5528         (linux_inferior_data): Move.  Change type.
5529         (invalidate_linux_cache_inf): Update.
5530         (linux_inferior_data_cleanup): Remove.
5531         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5532
5533 2019-05-08  Tom Tromey  <tom@tromey.com>
5534
5535         * auxv.c (auxv_inferior_data): Move.  Change type.
5536         (auxv_inferior_data_cleanup): Remove.
5537         (invalidate_auxv_cache_inf): Rewrite.
5538         (get_auxv_inferior_data, _initialize_auxv): Update.
5539
5540 2019-05-08  Tom Tromey  <tom@tromey.com>
5541
5542         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5543         (symfile_debug_objfile_data_key): Change type.
5544         (symfile_debug_installed, debug_qf_has_symbols)
5545         (debug_qf_find_last_source_symtab)
5546         (debug_qf_forget_cached_source_info)
5547         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5548         (debug_qf_print_stats, debug_qf_dump)
5549         (debug_qf_expand_symtabs_for_function)
5550         (debug_qf_expand_all_symtabs)
5551         (debug_qf_expand_symtabs_with_fullname)
5552         (debug_qf_map_matching_symbols)
5553         (debug_qf_expand_symtabs_matching)
5554         (debug_qf_find_pc_sect_compunit_symtab)
5555         (debug_qf_map_symbol_filenames)
5556         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5557         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5558         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5559         (debug_sym_read_linetable, debug_sym_relocate): Update.
5560         (symfile_debug_free_objfile): Remove.
5561         (install_symfile_debug_logging, _initialize_symfile_debug):
5562         Update.
5563
5564 2019-05-08  Tom Tromey  <tom@tromey.com>
5565
5566         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5567         allocate_on_obstack.
5568         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5569         (get_dwarf2_per_objfile): Update.
5570         (set_dwarf2_per_objfile): Remove.
5571         (dwarf2_has_info, dwarf2_get_section_info): Update.
5572         (dwarf2_free_objfile): Remove.
5573         (_initialize_dwarf2_read): Update.
5574
5575 2019-05-08  Tom Tromey  <tom@tromey.com>
5576
5577         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5578         initializers.
5579         <unsupported_script_warning_printed,
5580         script_not_found_warning_printed>: Now bool.
5581         (auto_load_pspace_data): Change type.
5582         (~auto_load_pspace_info): Rename from
5583         auto_load_pspace_data_cleanup.
5584         (get_auto_load_pspace_data, init_loaded_scripts_info)
5585         (clear_section_scripts, maybe_print_unsupported_script_warning)
5586         (maybe_print_script_not_found_warning, _initialize_auto_load):
5587         Update.
5588
5589 2019-05-08  Tom Tromey  <tom@tromey.com>
5590
5591         * objfiles.c (objfile_pspace_info): Add destructor and
5592         initializers.
5593         (objfiles_pspace_data): Change type.
5594         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5595         (get_objfile_pspace_data): Update.
5596         (objfiles_bfd_data): Change type.
5597         (get_objfile_bfd_data): Update.
5598         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5599
5600 2019-05-08  Tom Tromey  <tom@tromey.com>
5601
5602         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5603         Change type.
5604         (get_catch_syscall_inferior_data): Update.
5605         (catch_syscall_inferior_data_cleanup): Remove.
5606         (_initialize_break_catch_syscall): Update.
5607
5608 2019-05-08  Tom Tromey  <tom@tromey.com>
5609
5610         * inflow.c (struct terminal_info): Add destructor and
5611         initializers.
5612         (inflow_inferior_data): Change type.
5613         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5614         (get_inflow_inferior_data, inflow_inferior_exit)
5615         (swap_terminal_info, _initialize_inflow): Update.
5616
5617 2019-05-08  Tom Tromey  <tom@tromey.com>
5618
5619         * target-dcache.c (target_dcache_cleanup): Remove.
5620         (target_dcache_aspace_key): Change type.
5621         (target_dcache_init_p, target_dcache_invalidate)
5622         (target_dcache_get, target_dcache_get_or_init)
5623         (_initialize_target_dcache): Update.
5624         * dcache.h (struct dcache_deleter): New.
5625
5626 2019-05-08  Tom Tromey  <tom@tromey.com>
5627
5628         * symtab.c (struct symbol_cache): Add destructor and
5629         initializers.
5630         (symbol_cache_key): Move.  Change type.
5631         (make_symbol_cache, free_symbol_cache): Remove.
5632         (get_symbol_cache): Update.
5633         (symbol_cache_cleanup): Remove.
5634         (ALL_PSPACES, symbol_cache_flush)
5635         (maintenance_print_symbol_cache)
5636         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5637         Update.
5638
5639 2019-05-08  Tom Tromey  <tom@tromey.com>
5640
5641         * symtab.c (struct main_info): Add destructor and initializers.
5642         (main_progspace_key): Move.  Change type.
5643         (get_main_info): Update.
5644         (main_info_cleanup): Remove.
5645         (_initialize_symtab): Update.
5646
5647 2019-05-08  Tom Tromey  <tom@tromey.com>
5648
5649         * registry.h (DECLARE_REGISTRY): Define the _key class.
5650
5651 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5652
5653         * NEWS: Merge two 'New commands' sections.
5654
5655 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5656
5657         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5658         parameter and use Ada language definition instead.
5659         (ada_val_print_ptr): Remove unused language parameter.
5660         (ada_val_print_num): Remove language parameter and use Ada language
5661         definition instead.
5662         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5663         parameter.
5664         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5665         parameter and use Ada language definition instead.
5666         (ada_val_print_1): Update all ada_val_print_xxx calls.
5667         Remove language parameter.
5668         (ada_val_print): Update ada_val_print_1 call.
5669
5670 2019-05-08  Tom Tromey  <tromey@adacore.com>
5671
5672         * remote.c (remote_hw_watchpoint_limit)
5673         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5674         Now static.
5675
5676 2019-05-08  Tom Tromey  <tromey@adacore.com>
5677
5678         * maint.c (_initialize_maint_cmds): Move initialization code to
5679         remote.c.
5680         (watchdog, show_watchdog): Move to remote.c.
5681         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5682         "watchdog" static.
5683         (_initialize_remote): Move initialization code from maint.c.
5684         * defs.h (watchdog): Don't declare.
5685
5686 2019-05-08  Tom Tromey  <tromey@adacore.com>
5687
5688         * tui/tui-interp.c: Include main.h.
5689         * interps.c: Include main.h.
5690         * main.h (interpreter_p): Declare.
5691         * defs.h (interpreter_p): Don't declare.
5692
5693 2019-05-08  Tom Tromey  <tromey@adacore.com>
5694
5695         * dwarf2loc.c: Include dwarf2read.h.
5696         * defs.h (read_unsigned_leb128): Don't declare.
5697         * dwarf2read.h (read_unsigned_leb128): Declare.
5698
5699 2019-05-08  Tom Tromey  <tromey@adacore.com>
5700
5701         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5702         method.
5703
5704 2019-05-08  Tom Tromey  <tromey@adacore.com>
5705
5706         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5707         when no wrap column is set.
5708
5709 2019-05-08  Tom Tromey  <tromey@adacore.com>
5710
5711         * c-lang.c (c_get_string): Handle non-C-style arrays.
5712
5713 2019-05-08  Tom Tromey  <tromey@adacore.com>
5714
5715         * typeprint.c (print_offset_data::update): Print the bit offset,
5716         not the number of bits remaining.
5717
5718 2019-05-08  Tom Tromey  <tromey@adacore.com>
5719
5720         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5721         padding at end of comment.
5722
5723 2019-05-08  Tom Tromey  <tromey@adacore.com>
5724
5725         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5726         Compare main types.
5727
5728 2019-05-06  Tom Tromey  <tom@tromey.com>
5729
5730         * common/scoped_mmap.c: Include common-defs.h.
5731         * common/scoped_mmap.h: Don't include config.h.
5732
5733 2019-05-04  Tom Tromey  <tom@tromey.com>
5734
5735         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5736         (struct aarch64_call_info): Add initializers.
5737         <si>: Now a std::vector.
5738         (pass_on_stack, aarch64_push_dummy_call): Update.
5739
5740 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5741             Tom Tromey  <tom@tromey.com>
5742
5743         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5744         (ppc_threads): Now a std::vector.  Now static.
5745         (hwdebug_find_thread_points_by_tid)
5746         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5747         Update.
5748
5749 2019-05-04  Tom Tromey  <tom@tromey.com>
5750
5751         * arc-tdep.c (arc_tdesc_init): Return bool.
5752
5753 2019-05-04  Tom Tromey  <tom@tromey.com>
5754
5755         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5756         Use gdb_assert_not_reached.
5757
5758 2019-05-04  Tom Tromey  <tom@tromey.com>
5759
5760         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5761         "false".
5762
5763 2019-05-04  Tom Tromey  <tom@tromey.com>
5764
5765         * arc-tdep.c (arc_tdesc_init): Use bool.
5766
5767 2019-05-04  Tom Tromey  <tom@tromey.com>
5768
5769         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5770
5771 2019-05-04  Tom Tromey  <tom@tromey.com>
5772
5773         * cli/cli-cmds.c (valid_command_p): Return bool.
5774
5775 2019-05-04  Tom Tromey  <tom@tromey.com>
5776
5777         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5778         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5779
5780 2019-05-04  Raul Tambre  <raul@tambre.ee>
5781
5782         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5783         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5784         operator for comparison.
5785
5786 2019-05-04  Tom Tromey  <tom@tromey.com>
5787
5788         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5789         (lookup_partial_symbol, print_partial_symbols)
5790         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5791         (psymbol_compare): Update.
5792         (add_psymbol_to_bcache): Clear the entire psymbol.
5793         (maintenance_check_psymtabs): Update.
5794         * psympriv.h (struct partial_symbol): Don't derive from
5795         general_symbol_info.
5796         <obj_section, unrelocated_address, address,
5797         set_unrelocated_address>: Update.
5798         <ginfo>: New member.
5799         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5800         (debug_names::write_psymbols): Update.
5801
5802 2019-05-04  Tom de Vries  <tdevries@suse.de>
5803
5804         * contrib/cc-with-tweaks.sh: Support -n arg.
5805
5806 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5807
5808         * corelow.c (core_target::detach): Ensure frame cache and
5809         register caches are cleared.
5810         inferior.c (exit_inferior_1): Likewise.
5811
5812 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5813             Tom Tromey  <tom@tromey.com>
5814
5815         * dictionary.c (collate_pending_symbols_by_language): Remove
5816         "struct" from foreach.
5817         * symtab.c (lookup_global_symbol_from_objfile)
5818         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5819         foreach.
5820         * ser-tcp.c (net_open): Remove "struct" from foreach.
5821         * objfiles.c (objfile_relocate, objfile_rebase)
5822         (objfile_has_symbols): Remove "struct" from foreach.
5823         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5824         from foreach.
5825         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5826         foreach.
5827         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5828         "struct" from foreach.
5829         * ada-lang.c (create_excep_cond_exprs)
5830         (ada_exception_catchpoint_cond_string): Remove "struct" from
5831         foreach.
5832
5833 2019-05-03  Tom Tromey  <tromey@adacore.com>
5834
5835         * ada-exp.y (convert_char_literal): Check suffix of each
5836         enumerator.
5837
5838 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5839
5840         PR ada/21406:
5841         * ada-exp.y (yywrap): Don't define.
5842         * ada-lex.l (%option): Add noyywrap
5843         (yywrap): Remove.
5844
5845 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5846
5847         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5848         _WIN32_WINNT to the XP level, unless already defined to a higher
5849         level.
5850
5851         * unittests/parse-connection-spec-selftests.c:
5852         * ser-tcp.c:
5853         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5854         override.
5855
5856         * symfile.c (find_separate_debug_file): Remove colon from the
5857         drive spec of DOS/Windows file names of the target, so that the
5858         file name produced from DEBUGDIR and the target's directory will
5859         be valid on DOS/Windows systems.
5860
5861 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5862
5863         * rust-lang.c (val_print_struct): Handle printing structures
5864         containing strings.
5865
5866 2019-05-02  Tom Tromey  <tromey@adacore.com>
5867
5868         * valarith.c (_initialize_valarith): Remove.
5869
5870 2019-05-01  Tom Tromey  <tromey@adacore.com>
5871
5872         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5873         bitfields.
5874
5875 2019-05-01  Tom Tromey  <tromey@adacore.com>
5876
5877         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5878         for big-endian copies.
5879
5880 2019-04-30  Ali Tamur  <tamur@google.com>
5881         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5882         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5883         (read_3_bytes): New function.
5884
5885 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5886
5887         * windows-nat.c (main_thread_id): Delete.
5888         (handle_output_debug_string): Replace main_thread_id by
5889         current_event.dwThreadId.
5890         (fake_create_process): Likewise.
5891         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5892         Do not set main_thread_id.
5893         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5894         current_event.dwThreadId.
5895         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5896
5897 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5898
5899         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5900         Use current_event.dwThreadId instead of main_thread_id.
5901
5902 2019-04-30  Tom Tromey  <tromey@adacore.com>
5903
5904         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5905         (create_excep_cond_exprs): Iterate over program spaces.
5906         (ada_exception_catchpoint_cond_string): Examine all minimal
5907         symbols for exception types.
5908
5909 2019-04-30  Tom Tromey  <tromey@adacore.com>
5910
5911         PR c++/24470:
5912         * dwarf2read.c (process_structure_scope): Handle case where type
5913         has template parameters but no symbol was created.
5914
5915 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5916             Chris January  <chris.january@arm.com>
5917
5918         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5919         qualifier.
5920         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5921
5922 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5923
5924         * f-typeprint.c (f_print_type): Update rules for printing
5925         whitespace.
5926         (f_type_print_varspec_suffix): Likewise.
5927
5928 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5929             Chris January  <chris.january@arm.com>
5930
5931         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5932         function arguments.
5933
5934 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5935
5936         * f-lang.c (build_fortran_types): Change name of void type to
5937         lower case.
5938         * f-typeprint.c (f_type_print_base): Print the name of the void
5939         type, rather than a fixed string.
5940         * f-valprint.c (f_decorations): Use lower case void string.
5941
5942 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5943             Chris January  <chris.january@arm.com>
5944
5945         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5946         types for Fortran.
5947
5948 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5949             Chris January  <chris.january@arm.com>
5950             David Lecomber  <david.lecomber@arm.com>
5951
5952         * f-exp.y (BINOP_INTRINSIC): New token.
5953         (exp): New parser rule handling BINOP_INTRINSIC.
5954         (f77_keywords): Add new builtin procedures.
5955         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5956         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5957         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5958         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5959         (print_unop_subexp_f): New function.
5960         (print_binop_subexp_f): New function.
5961         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5962         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5963         (dump_subexp_body_f): Likewise.
5964         (operator_check_f): Likewise.
5965         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5966         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5967
5968 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5969
5970         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5971         UNOP_KIND.
5972         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5973         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5974         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5975         (operator_length_f): New fuction.
5976         (print_subexp_f): New function.
5977         (op_name_f): New function.
5978         (dump_subexp_body_f): New function.
5979         (operator_check_f): New function.
5980         (exp_descriptor_f): Replace standard expression handling functions
5981         with new functions.
5982         * gdb/fortran-operator.def: New file.
5983         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5984         * gdb/std-operator.def: Remove UNOP_KIND.
5985
5986 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5987
5988         * std-operator.def: Remove unbalanced, stray double quote
5989         character.
5990
5991 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5992             Chris January  <chris.january@arm.com>
5993             Daniel Everett  <daniel.everett@arm.com>
5994             Nick Forrington  <nick.forrington@arm.com>
5995             Richard Bunt  <richard.bunt@arm.com>
5996
5997         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5998         of depth when printing anonymous structs or unions.
5999         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6000         Don't print either the top-level value, or the children if the
6001         max-depth is exceeded.
6002         (ppscm_print_children): When printing the key of a map, allow one
6003         extra level of depth.
6004         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6005         print either the top-level value, or the children if the max-depth
6006         is exceeded.
6007         (print_children): When printing the key of a map, allow one extra
6008         level of depth.
6009         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6010         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6011         (user_print_options): Initialise max_depth field.
6012         (val_print_scalar_or_string_type_p): New function.
6013         (val_print): Check to see if the max depth has been reached.
6014         (val_print_check_max_depth): Define new function.
6015         (show_print_max_depth): New function.
6016         (_initialize_valprint): Add 'print max-depth' option.
6017         * valprint.h (struct value_print_options) <max_depth>: New field.
6018         (val_print_check_max_depth): Declare new function.
6019         * NEWS: Document new feature.
6020
6021 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6022
6023         * ada-lang.c (ada_language_defn): Initialise new field.
6024         * c-lang.c (c_is_string_type_p): New function.
6025         (c_language_defn): Initialise new field.
6026         (cplus_language_defn): Initialise new field.
6027         (asm_language_defn): Initialise new field.
6028         (minimal_language_defn): Initialise new field.
6029         * c-lang.h (c_is_string_type_p): Declare new function.
6030         * d-lang.c (d_language_defn): Initialise new field.
6031         * f-lang.c (f_is_string_type_p): New function.
6032         (f_language_defn): Initialise new field.
6033         * go-lang.c (go_is_string_type_p): New function.
6034         (go_language_defn): Initialise new field.
6035         * language.c (default_is_string_type_p): New function.
6036         (unknown_language_defn): Initialise new field.
6037         (auto_language_defn): Initialise new field.
6038         * language.h (struct language_defn) <la_is_string_type_p>: New
6039         member variable.
6040         (default_is_string_type_p): Declare new function.
6041         * m2-lang.c (m2_language_defn): Initialise new field.
6042         * objc-lang.c (objc_language_defn): Initialise new field.
6043         * opencl-lang.c (opencl_language_defn): Initialise new field.
6044         * p-lang.c (pascal_is_string_type_p): New function.
6045         (pascal_language_defn): Initialise new field.
6046         * rust-lang.c (rust_is_string_type_p): New function.
6047         (rust_language_defn): Initialise new field.
6048
6049 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6050
6051         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6052         New field.
6053         * ada-lang.c (ada_language_defn): Initialise new field.
6054         * c-lang.c (c_language_defn): Likewise.
6055         (cplus_language_defn): Likewise.
6056         (asm_language_defn): Likewise.
6057         (minimal_language_defn): Likewise.
6058         * d-lang.c (d_language_defn): Likewise.
6059         * f-lang.c (f_language_defn): Likewise.
6060         * go-lang.c (go_language_defn): Likewise.
6061         * language.c (unknown_language_defn): Likewise.
6062         (auto_language_defn): Likewise.
6063         * m2-lang.c (m2_language_defn): Likewise.
6064         * objc-lang.c (objc_language_defn): Likewise.
6065         * opencl-lang.c (opencl_language_defn): Likewise.
6066         * p-lang.c (pascal_language_defn): Likewise.
6067         * rust-lang.c (rust_language_defn): Likewise.
6068
6069 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6070
6071         * ada-lang.c (ada_is_character_type): Change return type to bool.
6072         (ada_is_string_type): Likewise.
6073         * ada-lang.h (ada_is_character_type): Update declaration
6074         (ada_is_string_type): Likewise.
6075
6076 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6077
6078         Support style in 'frame|thread apply'
6079
6080         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6081         * record.c (record_start, record_stop): Update callers of
6082         execute_command_to_string with false.
6083         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6084         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6085         methods.
6086         (class string_file): New constructor with term_out parameter.
6087         Override methods term_out and can_emit_style_escape.  New member
6088         term_out.
6089         (class stdio_file): Override can_emit_style_escape.
6090         (class tee_file): Override term_out and can_emit_style_escape.
6091         * utils.h (can_emit_style_escape): Remove.
6092         * utils.c (can_emit_style_escape): Likewise.
6093         Update all callers of can_emit_style_escape (SOMESTREAM) to
6094         SOMESTREAM->can_emit_style_escape.
6095         * source-cache.c (source_cache::get_source_lines): Likewise.
6096         * stack.c (frame_apply_command_count): Call execute_command_to_string
6097         passing the term_out characteristic of the current gdb_stdout.
6098         * thread.c (thr_try_catch_cmd): Likewise.
6099         * top.c (execute_command_to_string): pass term_out parameter
6100         to construct the string_file for the command output.
6101         * ui-file.c (term_cli_styling): New function (most code moved
6102         from utils.c can_emit_style_escape).
6103         (string_file::string_file, string_file::can_emit_style_escape,
6104         stdio_file::can_emit_style_escape, tee_file::term_out,
6105         tee_file::can_emit_style_escape): New functions.
6106
6107 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6108
6109         * NEWS: Mention the new set|show may-call-functions.
6110         * infcall.c (may_call_functions_p): New variable.
6111         (show_may_call_functions_p): New function.
6112         (call_function_by_hand_dummy): Throws an error if not
6113         may-call-functions.
6114         (_initialize_infcall): Call add_setshow_boolean_cmd for
6115         may-call-functions.
6116
6117 2019-04-25  Keith Seitz  <keiths@redhat.com>
6118
6119         PR c++/24367
6120         * cp-support.c (inspect_type): Don't attempt substitutions
6121         of symbol with the same name.
6122
6123 2019-04-25  Tom Tromey  <tromey@adacore.com>
6124
6125         PR gdb/24475:
6126         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6127         static.
6128
6129 2019-04-25  Tom Tromey  <tromey@adacore.com>
6130
6131         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6132         rvalue reference.
6133         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6134         (gdb_xml_parser::parse): Use std::move.
6135         * python/python-internal.h (gdbpy_convert_exception): Take a const
6136         reference.
6137         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6138         std::move.
6139         * python/py-utils.c (gdbpy_convert_exception): Take a const
6140         reference.
6141         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6142         Use std::move.
6143         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6144         Use std::move.
6145         * mi/mi-main.c (mi_print_exception): Take a const reference.
6146         * main.c (handle_command_errors): Take a const reference.
6147         * linespec.c (parse_linespec): Use std::move.
6148         * infcall.c (run_inferior_call): Use std::move.
6149         (call_function_by_hand_dummy): Use std::move.
6150         * exec.c (try_open_exec_file): Use std::move.
6151         * exceptions.h (exception_print, exception_fprintf)
6152         (exception_print_same): Update.
6153         * exceptions.c (print_exception, exception_print)
6154         (exception_fprintf, exception_print_same): Change parameters to
6155         const reference.
6156         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6157         * common/new-op.c: Use std::move.
6158         * common/common-exceptions.h (struct gdb_exception): Add move
6159         constructor.
6160         (struct gdb_exception_error, struct gdb_exception_quit, struct
6161         gdb_quit_bad_alloc): Change constructor to move constructor.
6162         (throw_exception): Change parameter to rvalue reference.
6163         * common/common-exceptions.c (throw_exception): Take rvalue
6164         reference.
6165         * cli/cli-interp.c (safe_execute_command): Use std::move.
6166         * breakpoint.c (insert_bp_location, location_to_sals): Use
6167         std::move.
6168
6169 2019-04-25  Tom Tromey  <tromey@adacore.com>
6170
6171         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6172         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6173         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6174         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6175         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6176         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6177         guile/scm-value.c: Use unpack.
6178         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6179         gdbscm_gdb_exception.
6180         (gdbscm_throw_gdb_exception): Likewise.
6181         (struct gdbscm_gdb_exception): New.
6182         (unpack): New function.
6183         (gdbscm_wrap): Use unpack.
6184
6185 2019-04-25  Tom Tromey  <tromey@adacore.com>
6186
6187         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6188         (gdb_rl_callback_handler): Use std::move.
6189         * common/common-exceptions.h (struct gdb_exception): Add move
6190         assignment operator.
6191         (throw_exception_sjlj): Change "exception" to const reference.
6192         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6193         (throw_exception_sjlj): Change "exception" to const reference.
6194
6195 2019-04-25  Tom Tromey  <tromey@adacore.com>
6196
6197         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6198         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6199         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6200         Update.
6201         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6202         Update.
6203         * mi/mi-interp.c (mi_interp::exec): Update.
6204         * linespec.c (parse_linespec): Update.
6205         * infcall.c (run_inferior_call): Update.
6206         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6207         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6208         (gdbscm_lookup_global_symbol): Update.
6209         * guile/scm-param.c (gdbscm_parameter_value): Update.
6210         * guile/scm-frame.c (gdbscm_frame_read_register)
6211         (gdbscm_frame_read_var): Update.
6212         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6213         * exec.c (try_open_exec_file): Update.
6214         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6215         (gdb_rl_callback_handler): Update.
6216         * common/common-exceptions.h (exception_none): Don't declare.
6217         * common/common-exceptions.c (exception_none): Don't define.
6218         (struct catcher) <exception>: Update.
6219         * cli/cli-interp.c (safe_execute_command): Update.
6220         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6221
6222 2019-04-25  Ali Tamur  <tamur@google.com>
6223
6224         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6225         (read_attribute_value): Likewise.
6226         (dwarf2_read_addr_index): Update comment.
6227         (read_str_index): Add DW_FORM_strx.
6228         (dwarf2_string_attr): Likewise.
6229         (dwarf2_const_value_attr): Likewise.
6230         (dump_die_shallow): Likewise.
6231         (dwarf2_fetch_constant_bytes): Likewise.
6232         (skip_form_bytes): Likewise.
6233         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6234
6235 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6236
6237         PR corefiles/11608
6238         PR corefiles/18187
6239         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6240         OFFSET.  Verify if current mapping contains an ELF header.
6241         (linux_find_memory_regions_full): Adjust call to
6242         dump_mapping_p.
6243
6244 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6245             Kang Li <kanglictf@gmail.com>
6246
6247         PR gdb/21600
6248
6249         * dwarf2-frame.c (read_initial_length): Be consistent about using
6250         unsigned representation of length.
6251         (decode_frame_entry_1): Likewise.  Check for wraparound of
6252         end pointer as well as buffer overflow.
6253
6254 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6255
6256         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6257         "vq".
6258
6259 2019-04-24  Tom Tromey  <tromey@adacore.com>
6260
6261         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6262
6263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6264
6265         * s12z-tdep.c (s12z_unwind_pc): Delete.
6266         (s12z_unwind_sp): Delete.
6267         (s12z_gdbarch_init): Don't register deleted functions with
6268         gdbarch.
6269
6270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6271
6272         * rl78-tdep.c (rl78_unwind_sp): Delete.
6273         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6274
6275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6276
6277         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6278         (xstormy16_unwind_pc): Delete.
6279         (xstormy16_dummy_id): Delete.
6280         (xstormy16_gdbarch_init): Don't register deleted functions with
6281         gdbarch.
6282
6283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6284
6285         * vax-tdep.c (vax_unwind_pc): Delete.
6286         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6287
6288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6289
6290         * v850-tdep.c (v850_unwind_sp): Delete.
6291         (v850_unwind_pc): Delete.
6292         (v850_dummy_id): Delete.
6293         (v850_gdbarch_init): Don't register deleted functions with
6294         gdbarch.
6295
6296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6297
6298         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6299         (tilegx_unwind_pc): Delete.
6300         (tilegx_unwind_dummy_id): Delete.
6301         (tilegx_gdbarch_init): Don't register deleted functions with
6302         gdbarch.
6303
6304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6305
6306         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6307         (tic6x_dummy_id): Delete.
6308         (tic6x_gdbarch_init): Don't register deleted functions with
6309         gdbarch.
6310
6311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6312
6313         * sparc-tdep.c (sparc_unwind_pc): Delete.
6314         (sparc32_gdbarch_init): Don't register deleted function with
6315         gdbarch.
6316
6317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6318
6319         * sh-tdep.c (sh_unwind_sp): Delete.
6320         (sh_unwind_pc): Delete.
6321         (sh_dummy_id): Delete.
6322         (sh_gdbarch_init): Don't register deleted functions with
6323         gdbarch.
6324
6325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6326
6327         * score-tdep.c (score_unwind_sp): Delete.
6328         (score_unwind_pc): Delete.
6329         (score_dummy_id): Delete.
6330         (score_gdbarch_init): Don't register deleted functions with
6331         gdbarch.
6332
6333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6334
6335         * rx-tdep.c (rx_unwind_pc): Delete.
6336         (rx_unwind_sp): Delete.
6337         (rx_dummy_id): Delete.
6338         (rx_gdbarch_init): Don't register deleted functions with
6339         gdbarch.  Update comment.
6340
6341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6342
6343         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6344         (rs6000_dummy_id): Delete.
6345         (rs6000_gdbarch_init): Don't register deleted functions with
6346         gdbarch.
6347
6348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * or1k-tdep.c (or1k_dummy_id): Delete.
6351         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6352
6353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6354
6355         * nios2-tdep.c (nios2_dummy_id): Delete.
6356         (nios2_unwind_sp): Delete.
6357         (nios2_gdbarch_init): Don't register deleted functions with
6358         gdbarch.
6359
6360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6361
6362         * nds32-tdep.c (nds32_dummy_id): Delete.
6363         (nds32_unwind_pc): Delete.
6364         (nds32_unwind_sp): Delete.
6365         (nds32_gdbarch_init): Don't register deleted functions with
6366         gdbarch.
6367
6368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6369
6370         * msp430-tdep.c (msp430_unwind_pc): Delete.
6371         (msp430_unwind_sp): Delete.
6372         (msp430_dummy_id): Delete.
6373         (msp430_gdbarch_init): Don't register deleted functions with
6374         gdbarch.
6375
6376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6377
6378         * moxie-tdep.c (moxie_unwind_sp): Delete.
6379         (moxie_unwind_pc): Delete.
6380         (moxie_dummy_id): Delete.
6381         (moxie_gdbarch_init): Don't register deleted functions with
6382         gdbarch.
6383
6384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6385
6386         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6387         (mn10300_unwind_pc): Delete.
6388         (mn10300_unwind_sp): Delete.
6389         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6390         mn10300_unwind_sp.
6391         (mn10300_frame_unwind_init): Don't register deleted functions with
6392         gdbarch.
6393
6394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6395
6396         * mep-tdep.c (mep_unwind_pc): Delete.
6397         (mep_unwind_sp): Delete.
6398         (mep_dummy_id): Delete.
6399         (mep_gdbarch_init): Don't register deleted functions with
6400         gdbarch.
6401
6402 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6403
6404         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6405         (m68hc11_unwind_sp): Delete.
6406         (m68hc11_gdbarch_init): Don't register deleted functions with
6407         gdbarch.
6408
6409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6410
6411         * m32r-tdep.c (m32r_unwind_sp): Delete.
6412         (m32r_unwind_pc): Delete.
6413         (m32r_dummy_id): Delete.
6414         (m32r_gdbarch_init): Don't register deleted functions with
6415         gdbarch.
6416
6417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6418
6419         * m32c-tdep.c (m32c_unwind_pc): Delete.
6420         (m32c_unwind_sp): Delete.
6421         (m32c_dummy_id): Delete.
6422         (m32c_gdbarch_init): Don't register deleted functions with
6423         gdbarch.
6424
6425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6426
6427         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6428         (lm32_unwind_pc): Delete.
6429         (lm32_dummy_id): Delete.
6430         (lm32_gdbarch_init): Don't register deleted functions with
6431         gdbarch.
6432
6433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6434
6435         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6436         (iq2000_unwind_pc): Delete.
6437         (iq2000_dummy_id): Delete.
6438         (iq2000_gdbarch_init): Don't register deleted functions with
6439         gdbarch.
6440
6441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6442
6443         * nds32-tdep.c (nds32_type_align): Delete.
6444         (nds32_push_dummy_call): Use type_align instead.
6445
6446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6447
6448         * arm-tdep.c (arm_type_align): Only handle vector override case.
6449         (arm_push_dummy_call): Use type_align.
6450         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6451
6452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6453
6454         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6455         case.
6456         (pass_on_stack): Use type_align.
6457         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6458         function.
6459
6460 2019-04-23  Tom Tromey  <tromey@adacore.com>
6461
6462         * dwarf2read.c (line_header::file_name_at): Remove unused
6463         overload.
6464
6465 2019-04-23  Tom de Vries  <tdevries@suse.de>
6466
6467         PR gdb/24438
6468         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6469         invocation.
6470
6471
6472 2019-03-27  Ali Tamur  <tamur@google.com>
6473
6474         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6475         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6476         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6477         (dwarf_expr_context::get_addr_index): Likewise
6478         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6479         (symbol_needs_eval_context::get_addr_index): Likewise
6480         (disassemble_dwarf_expression): Add DW_OP_addrx
6481         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6482         (read_cutu_die_from_dwo): Update comment
6483         (skip_one_die): Add DW_FORM_addrx
6484         (read_attribute_value): Likewise
6485         (var_decode_location): Add DW_OP_addrx
6486         (dwarf2_const_value_attr): Add DW_FORM_addrx
6487         (dump_die_shallow): Likewise
6488         (dwarf2_fetch_constant_bytes): Likewise
6489         (decode_locdesc): Add DW_OP_addrx
6490         (skip_form_bytes): Add DW_FORM_addrx
6491
6492 2019-04-22  Ali Tamur  <tamur@google.com>
6493
6494         * MAINTAINERS (Write After Approval): Add self.
6495
6496 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6497
6498         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6499         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6500         (open_symbol_file_object): Likewise.
6501         (svr4_default_sos): Add info parameter.
6502         (svr4_read_so_list): Likewise.
6503         (svr4_current_sos_direct): Adjust functions calls to pass down
6504         info.
6505         (svr4_current_sos_1): Add info parameter.
6506         (svr4_current_sos): Call get_svr4_info, pass info down to
6507         svr4_current_sos_1.
6508         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6509         get_svr4_info.
6510         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6511         get_svr4_info.
6512         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6513         to get_svr4_info.
6514         (probes_table_remove_objfile_probes): Likewise.
6515         (register_solib_event_probe): Add info parameter.
6516         (solist_update_incremental): Pass info parameter down to
6517         svr4_read_so_list.
6518         (disable_probes_interface): Add info parameter.
6519         (svr4_handle_solib_event): Pass current_program_space to
6520         get_svr4_info.  Adjust disable_probes_interface cleanup.
6521         (svr4_create_probe_breakpoints): Add info parameter, pass it
6522         down to register_solib_event_probe.
6523         (svr4_create_solib_event_breakpoints): Add info parameter,
6524         pass it down to svr4_create_probe_breakpoints.
6525         (enable_break): Pass info down to
6526         svr4_create_solib_event_breakpoints.
6527         (svr4_solib_create_inferior_hook): Pass current_program_space to
6528         get_svr4_info.
6529         (svr4_clear_solib): Likewise.
6530
6531 2019-04-22  Pedro Alves  <palves@redhat.com>
6532
6533         * solib-svr4.c (svr4_free_objfile_observer): New.
6534         (probe_and_action::objfile): New field.
6535         (probes_table_htab_remove_objfile_probes)
6536         (probes_table_remove_objfile_probes): New functions.
6537         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6538         in the new probe_and_action.  Don't store the probe in 'lookup'.
6539         (svr4_create_probe_breakpoints): Pass objfile to
6540         register_solib_event_probe.
6541         (_initialize_svr4_solib): Register a free_objfile observer.
6542
6543 2019-04-19  Tom Tromey  <tom@tromey.com>
6544
6545         * common/queue.h: Remove.
6546
6547 2019-04-19  Tom Tromey  <tom@tromey.com>
6548
6549         * event-loop.c: Don't include "common/queue.h".
6550
6551 2019-04-19  Tom Tromey  <tom@tromey.com>
6552
6553         * remote.c (remote_target): Use delete.
6554         * remote-notif.h: Include <list>, not "common/queue.h".
6555         (notif_client_p): Remove typedef.
6556         (remote_notif_state): Add constructor, destructor, initializer.
6557         <notif_queue>: Now a std::list.
6558         (remote_notif_state_xfree): Don't declare.
6559         * remote-notif.c (remote_notif_process, handle_notification)
6560         (remote_notif_state_allocate): Update.
6561         (~remote_notif_state): Rename from remote_notif_state_xfree.
6562
6563 2019-04-19  Tom Tromey  <tom@tromey.com>
6564
6565         * symfile.c (reread_symbols): Update.
6566         * objfiles.c (objfile_register_static_link)
6567         (objfile_lookup_static_link): Update
6568         (~objfile) Don't delete static_links.
6569         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6570
6571 2019-04-19  Tom Tromey  <tom@tromey.com>
6572
6573         * type-stack.h (struct type_stack) <insert>: Constify string.
6574         * type-stack.c (type_stack::insert): Constify string.
6575         * gdbtypes.h (lookup_template_type): Update.
6576         (address_space_name_to_int): Update.
6577         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6578         const.
6579         (lookup_template_type): Make name const.
6580         * c-exp.y: Update rules.
6581         (lex_one_token, classify_name, classify_inner_name)
6582         (c_print_token): Update.
6583         * p-exp.y: Update rules.
6584         (yylex): Update.
6585         * f-exp.y: Update rules.
6586         (yylex): Update.
6587         * d-exp.y: Update rules.
6588         (lex_one_token, classify_name, classify_inner_name): Update.
6589         * parse.c (write_dollar_variable, copy_name): Return std::string.
6590         * parser-defs.h (copy_name): Change return type.
6591         * m2-exp.y: Update rules.
6592         (yylex): Update.
6593         * go-exp.y (lex_one_token): Update.
6594         Update rules.
6595         (classify_unsafe_function, classify_packaged_name)
6596         (classify_name, yylex): Update.
6597
6598 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6599
6600         * configure.ac: add --enable-source-highlight switch.
6601         * configure: Regenerate.
6602         * top.c (print_gdb_version): plumb --enable-source-highlight
6603         status to "show configuration".
6604
6605 2019-04-19  Tom Tromey  <tromey@adacore.com>
6606
6607         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6608         Check ADA_TYPE_P.
6609         (empty_record, ada_template_to_fixed_record_type_1)
6610         (template_to_static_fixed_type)
6611         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6612         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6613         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6614         macros.
6615
6616 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6617
6618         PR symtab/24423:
6619         * source.c (print_source_lines_base): Advance "iter" when a
6620         control character is seen.
6621
6622 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6623
6624         * inferior.h (struct infcall_suspend_state_deleter):
6625         Catch exception in destructor to avoid crash.
6626
6627 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6628
6629         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6630         close to the add_com "shell".
6631
6632 2019-04-18  Tom Tromey  <tromey@adacore.com>
6633
6634         * process-stratum-target.h (class process_stratum_target)
6635         <stratum>: Add "final".
6636
6637 2019-04-17  Tom Tromey  <tromey@adacore.com>
6638
6639         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6640         against nullptr before use.
6641
6642 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6643
6644         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6645
6646 2019-04-17  Jim Wilson  <jimw@sifive.com>
6647             Andrew Burgess  <andrew.burgess@embecosm.com>
6648
6649         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6650         code read might fail, assume 4-byte breakpoint in that case.
6651
6652 2019-04-15  Leszek Swirski  <leszeks@google.com>
6653
6654         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6655         rather than a hand-rolled POD check when checking for forced MEMORY
6656         classification.
6657
6658 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6659
6660         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6661         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6662         function.
6663         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6664         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6665         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6666         declaration.
6667
6668 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6669
6670         * aarch64-linux-nat.c
6671         (aarch64_linux_nat_target::thread_architecture): Add override.
6672         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6673         each VQ.
6674
6675 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6676
6677         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6678
6679 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6680
6681         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6682         target types of size 96-bits, add some additional comments, and
6683         check that the builtin type we found was the correct size.
6684
6685 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6686
6687         * utils.c (prompt_for_continue): Don't restore the styling at the
6688         end, as applied_style has the wrong value.  This fixes styling in
6689         long lists of file names that are interrupted by the "Continue?"
6690         prompt.
6691
6692 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6693
6694         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6695         * c-lang.c (c_language_defn): Likewise.
6696         (cplus_language_defn): Likewise.
6697         (asm_language_defn): Likewise.
6698         (minimal_language_defn): Likewise.
6699         * d-lang.c (d_language_defn): Likewise.
6700         * f-lang.c (f_language_defn): Likewise.
6701         * go-lang.c (go_language_defn): Likewise.
6702         * language.c (unknown_language_defn): Likewise.
6703         (auto_language_defn): Likewise.
6704         * language.h (struct language_defn): Remove la_magic field.
6705         (LANG_MAGIC): Delete.
6706         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6707         * objc-lang.c (objc_language_defn): Likewise.
6708         * opencl-lang.c (opencl_language_defn): Likewise.
6709         * p-lang.c (pascal_language_defn): Likewise.
6710         * rust-lang.c (rust_language_defn): Likewise.
6711
6712 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6713
6714         * riscv-tdep.c (riscv_type_align): New function.
6715         (riscv_type_alignment): Delete.
6716         (riscv_arg_location): Use 'type_align'.
6717         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6718
6719 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6720
6721         * gdbtypes.c (type_align): A struct with no non-static fields also
6722         has alignment of 1.
6723
6724 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6725
6726         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6727         component to 0.
6728         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6729         member.
6730         (riscv_struct_info::analyse): New implementation using new
6731         analyse_inner member function.
6732         (riscv_struct_info::field_offset): New member function.
6733         (riscv_struct_info::m_offsets): New member variable.
6734         (riscv_struct_info::analyse_inner): New private member function,
6735         takes the old implementation of riscv_struct_info::analyse but
6736         extended to track field offsets.
6737         (riscv_call_arg_struct): Update the struct folding special cases
6738         to handle cases where empty C++ structs, which are non-zero
6739         length, are found.
6740         (riscv_arg_location): Initialise the length of each location, a
6741         non-zero length now indicates the location is in use.
6742         (riscv_push_dummy_call): Allow for the first location having a
6743         non-zero offset when setting up arguments.
6744         (riscv_return_value): Likewise, but for return values.
6745
6746 2019-04-11  Tom Tromey  <tromey@adacore.com>
6747
6748         * utils.c (internal_vproblem): Make "msg" const.
6749
6750 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6751
6752         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6753         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6754         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6755         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6756
6757 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6758
6759         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6760         function.
6761         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6762         of amd64_collect_native_gregset.
6763         (amd64_linux_nat_target::store_registers): Likewise.
6764
6765 2019-04-10  Tom Tromey  <tom@tromey.com>
6766
6767         * symtab.c (lookup_global_symbol_from_objfile)
6768         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6769         * objfiles.h (class separate_debug_iterator): New.
6770         (class separate_debug_range): New.
6771         (struct objfile) <separate_debug_objfiles>: New method.
6772         (objfile_separate_debug_iterate): Don't declare.
6773         * objfiles.c (separate_debug_iterator::operator++): Rename from
6774         objfile_separate_debug_iterate.
6775         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6776         iterator.
6777         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6778         iterator.
6779
6780 2019-04-10  Tom Tromey  <tom@tromey.com>
6781
6782         * symfile.c (reread_symbols): Remove old comment.
6783         * objfiles.c (free_all_objfiles): Fix a typo.
6784
6785 2019-04-10  Tom Tromey  <tom@tromey.com>
6786
6787         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6788         * minsyms.c (lookup_minimal_symbol): Use foreach.
6789         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6790         (lookup_minimal_symbol_solib_trampoline): Likewise.
6791         * symfile.c (reread_symbols): Use foreach.
6792
6793 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6794             Tom Tromey  <tromey@adacore.com>
6795
6796         PR rust/24414:
6797         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6798         (rust_lex_int_test): Change "value" to be LONGEST.
6799         (rust_lex_tests): Add test for long integer literal.
6800
6801 2019-04-09  Tom Tromey  <tromey@adacore.com>
6802
6803         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6804         to bool.
6805         (extended_remote_target::attach): Update.
6806         (remote_target::remote_notice_new_inferior): Update.
6807         (remote_target::add_current_inferior_and_thread): Update.
6808         * inferior.c (exit_inferior_1): Use "false".
6809         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6810
6811 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6812
6813         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6814         the "start" command.
6815
6816 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6817
6818         * python/py-inferior.c (infpy_thread_from_thread_handle):
6819         Adjust comments to reflect renaming of thread_from_thread_handle
6820         to thread_from_handle.  Adjust keywords.  Fix type error message.
6821         (inferior_object_methods): Add thread_from_handle.  Retain
6822         thread_from_thread_handle, but mark it as deprecated.
6823
6824 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6825
6826         * gdbthread.h (find_thread_by_handle): Revise declaration.
6827         * thread.c (find_thread_by_handle): Likewise.  Adjust
6828         implementation too.
6829         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6830         support for buffer objects as handles.
6831
6832 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6833
6834         * python/py-infthread.c (thpy_thread_handle): New function.
6835         (thread_object_methods): Register thpy_thread_handle.
6836
6837 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6838
6839         * gdbthread.h (thread_to_thread_handle): Declare.
6840         * thread.c (gdbtypes.h): Include.
6841         (thread_to_thread_handle): New function.
6842
6843         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6844         (target_thread_info_to_thread_handle): Declare.
6845         * target.c (target_thread_info_to_thread_handle): New function.
6846         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6847         * target-delegates.c: Regenerate.
6848
6849         * linux-thread-db.c (class thread_db_target): Add method
6850         thread_info_to_thread_handle.
6851         (thread_db_target::thread_info_to_thread_handle): Define.
6852         * remote.c (class remote_target): Add new method
6853         thread_info_to_thread_handle.
6854         (remote_target::thread_info_to_thread_handle): Define.
6855
6856 2019-04-08  Pedro Alves  <palves@redhat.com>
6857
6858         * common/common-exceptions.c (throw_exception): Don't create
6859         named object to throw; throw directly.
6860         (throw_it): Likewise.  Don't initialize gdb_exception::message
6861         here, with new; pass FMT and AP to the ctor instead.
6862         * common/common-exceptions.h: Include <string>.
6863         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6864         const char *, va_list)): New ctor.  Use std::make_shared.
6865         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6866         errors)): Delete.
6867         (gdb_exception_error::gdb_exception_error(enum errors, const char
6868         *, va_list)): New.
6869         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6870         Add assertion.
6871         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6872         errors)): Delete.
6873         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6874         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6875         Add assertion.
6876
6877 2019-04-08  Tom Tromey  <tom@tromey.com>
6878
6879         * valops.c (value_rtti_indirect_type): Replace throw_exception
6880         with throw.
6881         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6882         with throw.
6883         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6884         throw.
6885         * target.c (target_translate_tls_address): Replace throw_exception
6886         with throw.
6887         * stack.c (frame_apply_command_count): Replace throw_exception
6888         with throw.
6889         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6890         throw.
6891         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6892         with throw.
6893         * rs6000-tdep.c (rs6000_frame_cache)
6894         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6895         * remote.c: Replace throw_exception with throw.
6896         * record-full.c (record_full_message, record_full_wait_1)
6897         (record_full_restore): Replace throw_exception with throw.
6898         * record-btrace.c:
6899         (get_thread_current_frame_id, record_btrace_start_replaying)
6900         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6901         (cmd_record_btrace_start): Replace throw_exception with throw.
6902         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6903         throw.
6904         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6905         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6906         * linespec.c:
6907         (find_linespec_symbols): Replace throw_exception with throw.
6908         * infrun.c (displaced_step_prepare, resume): Replace
6909         throw_exception with throw.
6910         * infcmd.c (post_create_inferior): Replace throw_exception with
6911         throw.
6912         * inf-loop.c (inferior_event_handler): Replace throw_exception
6913         with throw.
6914         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6915         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6916         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6917         (get_prev_frame_always, get_frame_pc_if_available)
6918         (get_frame_address_in_block_if_available, get_frame_language):
6919         Replace throw_exception with throw.
6920         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6921         throw_exception with throw.
6922         * eval.c (fetch_subexp_value, evaluate_var_value)
6923         (evaluate_funcall, evaluate_subexp_standard): Replace
6924         throw_exception with throw.
6925         * dwarf2loc.c (call_site_find_chain)
6926         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6927         Replace throw_exception with throw.
6928         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6929         with throw.
6930         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6931         throw.
6932         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6933         * completer.c (complete_line_internal): Replace throw_exception
6934         with throw.
6935         * compile/compile-object-run.c (compile_object_run): Replace
6936         throw_exception with throw.
6937         * cli/cli-script.c (process_next_line): Replace throw_exception
6938         with throw.
6939         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6940         (btrace_enable, btrace_maint_update_pt_packets): Replace
6941         throw_exception with throw.
6942         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6943         throw_exception with throw.
6944         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6945         throw_exception with throw.
6946         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6947         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6948         * aarch64-tdep.c (aarch64_make_prologue_cache)
6949         (aarch64_make_stub_cache): Replace throw_exception with throw.
6950
6951 2019-04-08  Tom Tromey  <tom@tromey.com>
6952
6953         * common/common-exceptions.c (throw_exception): Rename from
6954         throw_exception_cxx.  Remove old copy.  Make argument const.
6955         (throw_it): Create and throw exception objects directly.
6956         * common/common-exceptions.h (throw_exception): Make argument
6957         const.
6958         (struct gdb_exception_error): Add constructor.
6959         (struct gdb_exception_quit): Add constructor.
6960
6961 2019-04-08  Tom Tromey  <tom@tromey.com>
6962
6963         * common/common-exceptions.h (exception_rethrow): Don't declare.
6964         (TRY_SJLJ): Update comment.
6965         (TRY, CATCH, END_CATCH): Remove.
6966         * common/common-exceptions.c (exception_rethrow): Remove.
6967
6968 2019-04-08  Tom Tromey  <tom@tromey.com>
6969
6970         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6971         Remove.
6972         (gdb_exception_error): Rename from
6973         gdb_exception_RETURN_MASK_ERROR.
6974         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6975         (gdb_quit_bad_alloc): Update.
6976         * aarch64-tdep.c: Update.
6977         * ada-lang.c: Update.
6978         * ada-typeprint.c: Update.
6979         * ada-valprint.c: Update.
6980         * amd64-tdep.c: Update.
6981         * arch-utils.c: Update.
6982         * break-catch-throw.c: Update.
6983         * breakpoint.c: Update.
6984         * btrace.c: Update.
6985         * c-varobj.c: Update.
6986         * cli/cli-cmds.c: Update.
6987         * cli/cli-interp.c: Update.
6988         * cli/cli-script.c: Update.
6989         * common/common-exceptions.c: Update.
6990         * common/new-op.c: Update.
6991         * common/selftest.c: Update.
6992         * compile/compile-c-symbols.c: Update.
6993         * compile/compile-cplus-symbols.c: Update.
6994         * compile/compile-object-load.c: Update.
6995         * compile/compile-object-run.c: Update.
6996         * completer.c: Update.
6997         * corelow.c: Update.
6998         * cp-abi.c: Update.
6999         * cp-support.c: Update.
7000         * cp-valprint.c: Update.
7001         * darwin-nat.c: Update.
7002         * disasm-selftests.c: Update.
7003         * dtrace-probe.c: Update.
7004         * dwarf-index-cache.c: Update.
7005         * dwarf-index-write.c: Update.
7006         * dwarf2-frame-tailcall.c: Update.
7007         * dwarf2-frame.c: Update.
7008         * dwarf2loc.c: Update.
7009         * dwarf2read.c: Update.
7010         * eval.c: Update.
7011         * event-loop.c: Update.
7012         * event-top.c: Update.
7013         * exec.c: Update.
7014         * f-valprint.c: Update.
7015         * fbsd-tdep.c: Update.
7016         * frame-unwind.c: Update.
7017         * frame.c: Update.
7018         * gdbtypes.c: Update.
7019         * gnu-v3-abi.c: Update.
7020         * guile/guile-internal.h: Update.
7021         * guile/scm-block.c: Update.
7022         * guile/scm-breakpoint.c: Update.
7023         * guile/scm-cmd.c: Update.
7024         * guile/scm-disasm.c: Update.
7025         * guile/scm-frame.c: Update.
7026         * guile/scm-lazy-string.c: Update.
7027         * guile/scm-math.c: Update.
7028         * guile/scm-param.c: Update.
7029         * guile/scm-ports.c: Update.
7030         * guile/scm-pretty-print.c: Update.
7031         * guile/scm-symbol.c: Update.
7032         * guile/scm-symtab.c: Update.
7033         * guile/scm-type.c: Update.
7034         * guile/scm-value.c: Update.
7035         * i386-linux-tdep.c: Update.
7036         * i386-tdep.c: Update.
7037         * inf-loop.c: Update.
7038         * infcall.c: Update.
7039         * infcmd.c: Update.
7040         * infrun.c: Update.
7041         * jit.c: Update.
7042         * language.c: Update.
7043         * linespec.c: Update.
7044         * linux-fork.c: Update.
7045         * linux-nat.c: Update.
7046         * linux-tdep.c: Update.
7047         * linux-thread-db.c: Update.
7048         * main.c: Update.
7049         * mi/mi-cmd-break.c: Update.
7050         * mi/mi-cmd-stack.c: Update.
7051         * mi/mi-interp.c: Update.
7052         * mi/mi-main.c: Update.
7053         * objc-lang.c: Update.
7054         * p-valprint.c: Update.
7055         * parse.c: Update.
7056         * ppc-linux-tdep.c: Update.
7057         * printcmd.c: Update.
7058         * python/py-arch.c: Update.
7059         * python/py-breakpoint.c: Update.
7060         * python/py-cmd.c: Update.
7061         * python/py-finishbreakpoint.c: Update.
7062         * python/py-frame.c: Update.
7063         * python/py-framefilter.c: Update.
7064         * python/py-gdb-readline.c: Update.
7065         * python/py-inferior.c: Update.
7066         * python/py-infthread.c: Update.
7067         * python/py-lazy-string.c: Update.
7068         * python/py-linetable.c: Update.
7069         * python/py-objfile.c: Update.
7070         * python/py-param.c: Update.
7071         * python/py-prettyprint.c: Update.
7072         * python/py-progspace.c: Update.
7073         * python/py-record-btrace.c: Update.
7074         * python/py-record.c: Update.
7075         * python/py-symbol.c: Update.
7076         * python/py-type.c: Update.
7077         * python/py-unwind.c: Update.
7078         * python/py-utils.c: Update.
7079         * python/py-value.c: Update.
7080         * python/python.c: Update.
7081         * record-btrace.c: Update.
7082         * record-full.c: Update.
7083         * remote-fileio.c: Update.
7084         * remote.c: Update.
7085         * riscv-tdep.c: Update.
7086         * rs6000-aix-tdep.c: Update.
7087         * rs6000-tdep.c: Update.
7088         * rust-exp.y: Update.
7089         * rust-lang.c: Update.
7090         * s390-tdep.c: Update.
7091         * selftest-arch.c: Update.
7092         * solib-dsbt.c: Update.
7093         * solib-frv.c: Update.
7094         * solib-spu.c: Update.
7095         * solib-svr4.c: Update.
7096         * solib.c: Update.
7097         * sparc64-linux-tdep.c: Update.
7098         * stack.c: Update.
7099         * symfile-mem.c: Update.
7100         * symmisc.c: Update.
7101         * target.c: Update.
7102         * thread.c: Update.
7103         * top.c: Update.
7104         * tracefile-tfile.c: Update.
7105         * tui/tui.c: Update.
7106         * typeprint.c: Update.
7107         * unittests/cli-utils-selftests.c: Update.
7108         * unittests/parse-connection-spec-selftests.c: Update.
7109         * valops.c: Update.
7110         * valprint.c: Update.
7111         * value.c: Update.
7112         * varobj.c: Update.
7113         * windows-nat.c: Update.
7114         * x86-linux-nat.c: Update.
7115         * xml-support.c: Update.
7116
7117 2019-04-08  Tom Tromey  <tom@tromey.com>
7118
7119         * xml-support.c: Use C++ exception handling.
7120         * x86-linux-nat.c: Use C++ exception handling.
7121         * windows-nat.c: Use C++ exception handling.
7122         * varobj.c: Use C++ exception handling.
7123         * value.c: Use C++ exception handling.
7124         * valprint.c: Use C++ exception handling.
7125         * valops.c: Use C++ exception handling.
7126         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7127         handling.
7128         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7129         * typeprint.c: Use C++ exception handling.
7130         * tui/tui.c: Use C++ exception handling.
7131         * tracefile-tfile.c: Use C++ exception handling.
7132         * top.c: Use C++ exception handling.
7133         * thread.c: Use C++ exception handling.
7134         * target.c: Use C++ exception handling.
7135         * symmisc.c: Use C++ exception handling.
7136         * symfile-mem.c: Use C++ exception handling.
7137         * stack.c: Use C++ exception handling.
7138         * sparc64-linux-tdep.c: Use C++ exception handling.
7139         * solib.c: Use C++ exception handling.
7140         * solib-svr4.c: Use C++ exception handling.
7141         * solib-spu.c: Use C++ exception handling.
7142         * solib-frv.c: Use C++ exception handling.
7143         * solib-dsbt.c: Use C++ exception handling.
7144         * selftest-arch.c: Use C++ exception handling.
7145         * s390-tdep.c: Use C++ exception handling.
7146         * rust-lang.c: Use C++ exception handling.
7147         * rust-exp.y: Use C++ exception handling.
7148         * rs6000-tdep.c: Use C++ exception handling.
7149         * rs6000-aix-tdep.c: Use C++ exception handling.
7150         * riscv-tdep.c: Use C++ exception handling.
7151         * remote.c: Use C++ exception handling.
7152         * remote-fileio.c: Use C++ exception handling.
7153         * record-full.c: Use C++ exception handling.
7154         * record-btrace.c: Use C++ exception handling.
7155         * python/python.c: Use C++ exception handling.
7156         * python/py-value.c: Use C++ exception handling.
7157         * python/py-utils.c: Use C++ exception handling.
7158         * python/py-unwind.c: Use C++ exception handling.
7159         * python/py-type.c: Use C++ exception handling.
7160         * python/py-symbol.c: Use C++ exception handling.
7161         * python/py-record.c: Use C++ exception handling.
7162         * python/py-record-btrace.c: Use C++ exception handling.
7163         * python/py-progspace.c: Use C++ exception handling.
7164         * python/py-prettyprint.c: Use C++ exception handling.
7165         * python/py-param.c: Use C++ exception handling.
7166         * python/py-objfile.c: Use C++ exception handling.
7167         * python/py-linetable.c: Use C++ exception handling.
7168         * python/py-lazy-string.c: Use C++ exception handling.
7169         * python/py-infthread.c: Use C++ exception handling.
7170         * python/py-inferior.c: Use C++ exception handling.
7171         * python/py-gdb-readline.c: Use C++ exception handling.
7172         * python/py-framefilter.c: Use C++ exception handling.
7173         * python/py-frame.c: Use C++ exception handling.
7174         * python/py-finishbreakpoint.c: Use C++ exception handling.
7175         * python/py-cmd.c: Use C++ exception handling.
7176         * python/py-breakpoint.c: Use C++ exception handling.
7177         * python/py-arch.c: Use C++ exception handling.
7178         * printcmd.c: Use C++ exception handling.
7179         * ppc-linux-tdep.c: Use C++ exception handling.
7180         * parse.c: Use C++ exception handling.
7181         * p-valprint.c: Use C++ exception handling.
7182         * objc-lang.c: Use C++ exception handling.
7183         * mi/mi-main.c: Use C++ exception handling.
7184         * mi/mi-interp.c: Use C++ exception handling.
7185         * mi/mi-cmd-stack.c: Use C++ exception handling.
7186         * mi/mi-cmd-break.c: Use C++ exception handling.
7187         * main.c: Use C++ exception handling.
7188         * linux-thread-db.c: Use C++ exception handling.
7189         * linux-tdep.c: Use C++ exception handling.
7190         * linux-nat.c: Use C++ exception handling.
7191         * linux-fork.c: Use C++ exception handling.
7192         * linespec.c: Use C++ exception handling.
7193         * language.c: Use C++ exception handling.
7194         * jit.c: Use C++ exception handling.
7195         * infrun.c: Use C++ exception handling.
7196         * infcmd.c: Use C++ exception handling.
7197         * infcall.c: Use C++ exception handling.
7198         * inf-loop.c: Use C++ exception handling.
7199         * i386-tdep.c: Use C++ exception handling.
7200         * i386-linux-tdep.c: Use C++ exception handling.
7201         * guile/scm-value.c: Use C++ exception handling.
7202         * guile/scm-type.c: Use C++ exception handling.
7203         * guile/scm-symtab.c: Use C++ exception handling.
7204         * guile/scm-symbol.c: Use C++ exception handling.
7205         * guile/scm-pretty-print.c: Use C++ exception handling.
7206         * guile/scm-ports.c: Use C++ exception handling.
7207         * guile/scm-param.c: Use C++ exception handling.
7208         * guile/scm-math.c: Use C++ exception handling.
7209         * guile/scm-lazy-string.c: Use C++ exception handling.
7210         * guile/scm-frame.c: Use C++ exception handling.
7211         * guile/scm-disasm.c: Use C++ exception handling.
7212         * guile/scm-cmd.c: Use C++ exception handling.
7213         * guile/scm-breakpoint.c: Use C++ exception handling.
7214         * guile/scm-block.c: Use C++ exception handling.
7215         * guile/guile-internal.h: Use C++ exception handling.
7216         * gnu-v3-abi.c: Use C++ exception handling.
7217         * gdbtypes.c: Use C++ exception handling.
7218         * frame.c: Use C++ exception handling.
7219         * frame-unwind.c: Use C++ exception handling.
7220         * fbsd-tdep.c: Use C++ exception handling.
7221         * f-valprint.c: Use C++ exception handling.
7222         * exec.c: Use C++ exception handling.
7223         * event-top.c: Use C++ exception handling.
7224         * event-loop.c: Use C++ exception handling.
7225         * eval.c: Use C++ exception handling.
7226         * dwarf2read.c: Use C++ exception handling.
7227         * dwarf2loc.c: Use C++ exception handling.
7228         * dwarf2-frame.c: Use C++ exception handling.
7229         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7230         * dwarf-index-write.c: Use C++ exception handling.
7231         * dwarf-index-cache.c: Use C++ exception handling.
7232         * dtrace-probe.c: Use C++ exception handling.
7233         * disasm-selftests.c: Use C++ exception handling.
7234         * darwin-nat.c: Use C++ exception handling.
7235         * cp-valprint.c: Use C++ exception handling.
7236         * cp-support.c: Use C++ exception handling.
7237         * cp-abi.c: Use C++ exception handling.
7238         * corelow.c: Use C++ exception handling.
7239         * completer.c: Use C++ exception handling.
7240         * compile/compile-object-run.c: Use C++ exception handling.
7241         * compile/compile-object-load.c: Use C++ exception handling.
7242         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7243         * compile/compile-c-symbols.c: Use C++ exception handling.
7244         * common/selftest.c: Use C++ exception handling.
7245         * common/new-op.c: Use C++ exception handling.
7246         * cli/cli-script.c: Use C++ exception handling.
7247         * cli/cli-interp.c: Use C++ exception handling.
7248         * cli/cli-cmds.c: Use C++ exception handling.
7249         * c-varobj.c: Use C++ exception handling.
7250         * btrace.c: Use C++ exception handling.
7251         * breakpoint.c: Use C++ exception handling.
7252         * break-catch-throw.c: Use C++ exception handling.
7253         * arch-utils.c: Use C++ exception handling.
7254         * amd64-tdep.c: Use C++ exception handling.
7255         * ada-valprint.c: Use C++ exception handling.
7256         * ada-typeprint.c: Use C++ exception handling.
7257         * ada-lang.c: Use C++ exception handling.
7258         * aarch64-tdep.c: Use C++ exception handling.
7259
7260 2019-04-08  Tom Tromey  <tom@tromey.com>
7261
7262         * xml-support.c (gdb_xml_parser::parse): Update.
7263         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7264         * value.c (show_convenience): Update.
7265         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7266         (test_parse_flags_qcs): Update.
7267         * thread.c (thr_try_catch_cmd): Update.
7268         * target.c (target_translate_tls_address): Update.
7269         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7270         (info_frame_command_core, frame_apply_command_count): Update.
7271         * rust-exp.y (rust_lex_exception_test): Update.
7272         * riscv-tdep.c (riscv_print_one_register_info): Update.
7273         * remote.c (remote_target::enable_btrace): Update.
7274         * record-btrace.c (record_btrace_enable_warn): Update.
7275         * python/py-utils.c (gdbpy_convert_exception): Update.
7276         * printcmd.c (do_one_display, print_variable_and_value): Update.
7277         * mi/mi-main.c (mi_print_exception): Update.
7278         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7279         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7280         * linux-nat.c (linux_nat_target::attach): Update.
7281         * linux-fork.c (class scoped_switch_fork_info): Update.
7282         * infrun.c (displaced_step_prepare): Update.
7283         * infcall.c (call_function_by_hand_dummy): Update.
7284         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7285         * gnu-v3-abi.c (print_one_vtable): Update.
7286         * frame.c (get_prev_frame_always): Update.
7287         * f-valprint.c (info_common_command_for_block): Update.
7288         * exec.c (try_open_exec_file): Update.
7289         * exceptions.c (print_exception, exception_print)
7290         (exception_fprintf, exception_print_same): Update.
7291         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7292         * dwarf-index-cache.c (index_cache::store)
7293         (index_cache::lookup_gdb_index): Update.
7294         * darwin-nat.c (maybe_cache_shell): Update.
7295         * cp-valprint.c (cp_print_value_fields): Update.
7296         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7297         (gcc_cplus_symbol_address): Update.
7298         * compile/compile-c-symbols.c (gcc_convert_symbol)
7299         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7300         * common/selftest.c: Update.
7301         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7302         a std::string.
7303         (exception_try_scope_entry, exception_try_scope_exit): Don't
7304         declare.
7305         (struct exception_try_scope): Remove.
7306         (TRY): Don't use exception_try_scope.
7307         (struct gdb_exception): Add constructor, operator=.
7308         <what>: New method.
7309         (struct gdb_exception_RETURN_MASK_ALL)
7310         (struct gdb_exception_RETURN_MASK_ERROR)
7311         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7312         (struct gdb_quit_bad_alloc): Update.
7313         * common/common-exceptions.c (exception_none): Change
7314         initializer.
7315         (struct catcher) <state, exception>: Initialize inline.
7316         <prev>: Remove member.
7317         (current_catcher): Remove.
7318         (catchers): New global.
7319         (exceptions_state_mc_init): Simplify.
7320         (catcher_pop): Remove.
7321         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7322         (try_scope_depth, exception_try_scope_entry)
7323         (exception_try_scope_exit): Remove.
7324         (throw_exception_sjlj): Update.
7325         (exception_messages, exception_messages_size): Remove.
7326         (throw_it): Simplify.
7327         (gdb_exception_sliced_copy): Remove.
7328         (throw_exception_cxx): Update.
7329         * cli/cli-script.c (script_from_file): Update.
7330         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7331         Update.
7332         * ada-valprint.c (ada_val_print): Update.
7333         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7334         (create_excep_cond_exprs): Update.
7335
7336 2019-04-08  Tom Tromey  <tom@tromey.com>
7337
7338         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7339         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7340         (TRY, CATCH, END_CATCH): Remove some definitions.
7341         * common/common-exceptions.c: Don't use GDB_XCPT.
7342         (catcher_list_size): Remove.
7343         (throw_exception, throw_it): Simplify.
7344
7345 2019-04-05  Tom Tromey  <tom@tromey.com>
7346
7347         Revert the header-sorting patch.
7348         * ft32-tdep.c: Revert.
7349         * frv-tdep.c: Revert.
7350         * frv-linux-tdep.c: Revert.
7351         * frame.c: Revert.
7352         * frame-unwind.c: Revert.
7353         * frame-base.c: Revert.
7354         * fork-child.c: Revert.
7355         * findvar.c: Revert.
7356         * findcmd.c: Revert.
7357         * filesystem.c: Revert.
7358         * filename-seen-cache.h: Revert.
7359         * filename-seen-cache.c: Revert.
7360         * fbsd-tdep.c: Revert.
7361         * fbsd-nat.h: Revert.
7362         * fbsd-nat.c: Revert.
7363         * f-valprint.c: Revert.
7364         * f-typeprint.c: Revert.
7365         * f-lang.c: Revert.
7366         * extension.h: Revert.
7367         * extension.c: Revert.
7368         * extension-priv.h: Revert.
7369         * expprint.c: Revert.
7370         * exec.h: Revert.
7371         * exec.c: Revert.
7372         * exceptions.c: Revert.
7373         * event-top.c: Revert.
7374         * event-loop.c: Revert.
7375         * eval.c: Revert.
7376         * elfread.c: Revert.
7377         * dwarf2read.h: Revert.
7378         * dwarf2read.c: Revert.
7379         * dwarf2loc.c: Revert.
7380         * dwarf2expr.h: Revert.
7381         * dwarf2expr.c: Revert.
7382         * dwarf2-frame.c: Revert.
7383         * dwarf2-frame-tailcall.c: Revert.
7384         * dwarf-index-write.h: Revert.
7385         * dwarf-index-write.c: Revert.
7386         * dwarf-index-common.c: Revert.
7387         * dwarf-index-cache.h: Revert.
7388         * dwarf-index-cache.c: Revert.
7389         * dummy-frame.c: Revert.
7390         * dtrace-probe.c: Revert.
7391         * disasm.h: Revert.
7392         * disasm.c: Revert.
7393         * disasm-selftests.c: Revert.
7394         * dictionary.c: Revert.
7395         * dicos-tdep.c: Revert.
7396         * demangle.c: Revert.
7397         * dcache.h: Revert.
7398         * dcache.c: Revert.
7399         * darwin-nat.h: Revert.
7400         * darwin-nat.c: Revert.
7401         * darwin-nat-info.c: Revert.
7402         * d-valprint.c: Revert.
7403         * d-namespace.c: Revert.
7404         * d-lang.c: Revert.
7405         * ctf.c: Revert.
7406         * csky-tdep.c: Revert.
7407         * csky-linux-tdep.c: Revert.
7408         * cris-tdep.c: Revert.
7409         * cris-linux-tdep.c: Revert.
7410         * cp-valprint.c: Revert.
7411         * cp-support.c: Revert.
7412         * cp-namespace.c: Revert.
7413         * cp-abi.c: Revert.
7414         * corelow.c: Revert.
7415         * corefile.c: Revert.
7416         * continuations.c: Revert.
7417         * completer.h: Revert.
7418         * completer.c: Revert.
7419         * complaints.c: Revert.
7420         * coffread.c: Revert.
7421         * coff-pe-read.c: Revert.
7422         * cli-out.h: Revert.
7423         * cli-out.c: Revert.
7424         * charset.c: Revert.
7425         * c-varobj.c: Revert.
7426         * c-valprint.c: Revert.
7427         * c-typeprint.c: Revert.
7428         * c-lang.c: Revert.
7429         * buildsym.c: Revert.
7430         * buildsym-legacy.c: Revert.
7431         * build-id.h: Revert.
7432         * build-id.c: Revert.
7433         * btrace.c: Revert.
7434         * bsd-uthread.c: Revert.
7435         * breakpoint.h: Revert.
7436         * breakpoint.c: Revert.
7437         * break-catch-throw.c: Revert.
7438         * break-catch-syscall.c: Revert.
7439         * break-catch-sig.c: Revert.
7440         * blockframe.c: Revert.
7441         * block.c: Revert.
7442         * bfin-tdep.c: Revert.
7443         * bfin-linux-tdep.c: Revert.
7444         * bfd-target.c: Revert.
7445         * bcache.c: Revert.
7446         * ax-general.c: Revert.
7447         * ax-gdb.h: Revert.
7448         * ax-gdb.c: Revert.
7449         * avr-tdep.c: Revert.
7450         * auxv.c: Revert.
7451         * auto-load.c: Revert.
7452         * arm-wince-tdep.c: Revert.
7453         * arm-tdep.c: Revert.
7454         * arm-symbian-tdep.c: Revert.
7455         * arm-pikeos-tdep.c: Revert.
7456         * arm-obsd-tdep.c: Revert.
7457         * arm-nbsd-tdep.c: Revert.
7458         * arm-nbsd-nat.c: Revert.
7459         * arm-linux-tdep.c: Revert.
7460         * arm-linux-nat.c: Revert.
7461         * arm-fbsd-tdep.c: Revert.
7462         * arm-fbsd-nat.c: Revert.
7463         * arm-bsd-tdep.c: Revert.
7464         * arch-utils.c: Revert.
7465         * arc-tdep.c: Revert.
7466         * arc-newlib-tdep.c: Revert.
7467         * annotate.h: Revert.
7468         * annotate.c: Revert.
7469         * amd64-windows-tdep.c: Revert.
7470         * amd64-windows-nat.c: Revert.
7471         * amd64-tdep.c: Revert.
7472         * amd64-sol2-tdep.c: Revert.
7473         * amd64-obsd-tdep.c: Revert.
7474         * amd64-obsd-nat.c: Revert.
7475         * amd64-nbsd-tdep.c: Revert.
7476         * amd64-nbsd-nat.c: Revert.
7477         * amd64-nat.c: Revert.
7478         * amd64-linux-tdep.c: Revert.
7479         * amd64-linux-nat.c: Revert.
7480         * amd64-fbsd-tdep.c: Revert.
7481         * amd64-fbsd-nat.c: Revert.
7482         * amd64-dicos-tdep.c: Revert.
7483         * amd64-darwin-tdep.c: Revert.
7484         * amd64-bsd-nat.c: Revert.
7485         * alpha-tdep.c: Revert.
7486         * alpha-obsd-tdep.c: Revert.
7487         * alpha-nbsd-tdep.c: Revert.
7488         * alpha-mdebug-tdep.c: Revert.
7489         * alpha-linux-tdep.c: Revert.
7490         * alpha-linux-nat.c: Revert.
7491         * alpha-bsd-tdep.c: Revert.
7492         * alpha-bsd-nat.c: Revert.
7493         * aix-thread.c: Revert.
7494         * agent.c: Revert.
7495         * addrmap.c: Revert.
7496         * ada-varobj.c: Revert.
7497         * ada-valprint.c: Revert.
7498         * ada-typeprint.c: Revert.
7499         * ada-tasks.c: Revert.
7500         * ada-lang.c: Revert.
7501         * aarch64-tdep.c: Revert.
7502         * aarch64-ravenscar-thread.c: Revert.
7503         * aarch64-newlib-tdep.c: Revert.
7504         * aarch64-linux-tdep.c: Revert.
7505         * aarch64-linux-nat.c: Revert.
7506         * aarch64-fbsd-tdep.c: Revert.
7507         * aarch64-fbsd-nat.c: Revert.
7508         * aarch32-linux-nat.c: Revert.
7509
7510 2019-04-05  Tom Tromey  <tom@tromey.com>
7511
7512         * ft32-tdep.c: Sort headers.
7513         * frv-tdep.c: Sort headers.
7514         * frv-linux-tdep.c: Sort headers.
7515         * frame.c: Sort headers.
7516         * frame-unwind.c: Sort headers.
7517         * frame-base.c: Sort headers.
7518         * fork-child.c: Sort headers.
7519         * findvar.c: Sort headers.
7520         * findcmd.c: Sort headers.
7521         * filesystem.c: Sort headers.
7522         * filename-seen-cache.h: Sort headers.
7523         * filename-seen-cache.c: Sort headers.
7524         * fbsd-tdep.c: Sort headers.
7525         * fbsd-nat.h: Sort headers.
7526         * fbsd-nat.c: Sort headers.
7527         * f-valprint.c: Sort headers.
7528         * f-typeprint.c: Sort headers.
7529         * f-lang.c: Sort headers.
7530         * extension.h: Sort headers.
7531         * extension.c: Sort headers.
7532         * extension-priv.h: Sort headers.
7533         * expprint.c: Sort headers.
7534         * exec.h: Sort headers.
7535         * exec.c: Sort headers.
7536         * exceptions.c: Sort headers.
7537         * event-top.c: Sort headers.
7538         * event-loop.c: Sort headers.
7539         * eval.c: Sort headers.
7540         * elfread.c: Sort headers.
7541         * dwarf2read.h: Sort headers.
7542         * dwarf2read.c: Sort headers.
7543         * dwarf2loc.c: Sort headers.
7544         * dwarf2expr.h: Sort headers.
7545         * dwarf2expr.c: Sort headers.
7546         * dwarf2-frame.c: Sort headers.
7547         * dwarf2-frame-tailcall.c: Sort headers.
7548         * dwarf-index-write.h: Sort headers.
7549         * dwarf-index-write.c: Sort headers.
7550         * dwarf-index-common.c: Sort headers.
7551         * dwarf-index-cache.h: Sort headers.
7552         * dwarf-index-cache.c: Sort headers.
7553         * dummy-frame.c: Sort headers.
7554         * dtrace-probe.c: Sort headers.
7555         * disasm.h: Sort headers.
7556         * disasm.c: Sort headers.
7557         * disasm-selftests.c: Sort headers.
7558         * dictionary.c: Sort headers.
7559         * dicos-tdep.c: Sort headers.
7560         * demangle.c: Sort headers.
7561         * dcache.h: Sort headers.
7562         * dcache.c: Sort headers.
7563         * darwin-nat.h: Sort headers.
7564         * darwin-nat.c: Sort headers.
7565         * darwin-nat-info.c: Sort headers.
7566         * d-valprint.c: Sort headers.
7567         * d-namespace.c: Sort headers.
7568         * d-lang.c: Sort headers.
7569         * ctf.c: Sort headers.
7570         * csky-tdep.c: Sort headers.
7571         * csky-linux-tdep.c: Sort headers.
7572         * cris-tdep.c: Sort headers.
7573         * cris-linux-tdep.c: Sort headers.
7574         * cp-valprint.c: Sort headers.
7575         * cp-support.c: Sort headers.
7576         * cp-namespace.c: Sort headers.
7577         * cp-abi.c: Sort headers.
7578         * corelow.c: Sort headers.
7579         * corefile.c: Sort headers.
7580         * continuations.c: Sort headers.
7581         * completer.h: Sort headers.
7582         * completer.c: Sort headers.
7583         * complaints.c: Sort headers.
7584         * coffread.c: Sort headers.
7585         * coff-pe-read.c: Sort headers.
7586         * cli-out.h: Sort headers.
7587         * cli-out.c: Sort headers.
7588         * charset.c: Sort headers.
7589         * c-varobj.c: Sort headers.
7590         * c-valprint.c: Sort headers.
7591         * c-typeprint.c: Sort headers.
7592         * c-lang.c: Sort headers.
7593         * buildsym.c: Sort headers.
7594         * buildsym-legacy.c: Sort headers.
7595         * build-id.h: Sort headers.
7596         * build-id.c: Sort headers.
7597         * btrace.c: Sort headers.
7598         * bsd-uthread.c: Sort headers.
7599         * breakpoint.h: Sort headers.
7600         * breakpoint.c: Sort headers.
7601         * break-catch-throw.c: Sort headers.
7602         * break-catch-syscall.c: Sort headers.
7603         * break-catch-sig.c: Sort headers.
7604         * blockframe.c: Sort headers.
7605         * block.c: Sort headers.
7606         * bfin-tdep.c: Sort headers.
7607         * bfin-linux-tdep.c: Sort headers.
7608         * bfd-target.c: Sort headers.
7609         * bcache.c: Sort headers.
7610         * ax-general.c: Sort headers.
7611         * ax-gdb.h: Sort headers.
7612         * ax-gdb.c: Sort headers.
7613         * avr-tdep.c: Sort headers.
7614         * auxv.c: Sort headers.
7615         * auto-load.c: Sort headers.
7616         * arm-wince-tdep.c: Sort headers.
7617         * arm-tdep.c: Sort headers.
7618         * arm-symbian-tdep.c: Sort headers.
7619         * arm-pikeos-tdep.c: Sort headers.
7620         * arm-obsd-tdep.c: Sort headers.
7621         * arm-nbsd-tdep.c: Sort headers.
7622         * arm-nbsd-nat.c: Sort headers.
7623         * arm-linux-tdep.c: Sort headers.
7624         * arm-linux-nat.c: Sort headers.
7625         * arm-fbsd-tdep.c: Sort headers.
7626         * arm-fbsd-nat.c: Sort headers.
7627         * arm-bsd-tdep.c: Sort headers.
7628         * arch-utils.c: Sort headers.
7629         * arc-tdep.c: Sort headers.
7630         * arc-newlib-tdep.c: Sort headers.
7631         * annotate.h: Sort headers.
7632         * annotate.c: Sort headers.
7633         * amd64-windows-tdep.c: Sort headers.
7634         * amd64-windows-nat.c: Sort headers.
7635         * amd64-tdep.c: Sort headers.
7636         * amd64-sol2-tdep.c: Sort headers.
7637         * amd64-obsd-tdep.c: Sort headers.
7638         * amd64-obsd-nat.c: Sort headers.
7639         * amd64-nbsd-tdep.c: Sort headers.
7640         * amd64-nbsd-nat.c: Sort headers.
7641         * amd64-nat.c: Sort headers.
7642         * amd64-linux-tdep.c: Sort headers.
7643         * amd64-linux-nat.c: Sort headers.
7644         * amd64-fbsd-tdep.c: Sort headers.
7645         * amd64-fbsd-nat.c: Sort headers.
7646         * amd64-dicos-tdep.c: Sort headers.
7647         * amd64-darwin-tdep.c: Sort headers.
7648         * amd64-bsd-nat.c: Sort headers.
7649         * alpha-tdep.c: Sort headers.
7650         * alpha-obsd-tdep.c: Sort headers.
7651         * alpha-nbsd-tdep.c: Sort headers.
7652         * alpha-mdebug-tdep.c: Sort headers.
7653         * alpha-linux-tdep.c: Sort headers.
7654         * alpha-linux-nat.c: Sort headers.
7655         * alpha-bsd-tdep.c: Sort headers.
7656         * alpha-bsd-nat.c: Sort headers.
7657         * aix-thread.c: Sort headers.
7658         * agent.c: Sort headers.
7659         * addrmap.c: Sort headers.
7660         * ada-varobj.c: Sort headers.
7661         * ada-valprint.c: Sort headers.
7662         * ada-typeprint.c: Sort headers.
7663         * ada-tasks.c: Sort headers.
7664         * ada-lang.c: Sort headers.
7665         * aarch64-tdep.c: Sort headers.
7666         * aarch64-ravenscar-thread.c: Sort headers.
7667         * aarch64-newlib-tdep.c: Sort headers.
7668         * aarch64-linux-tdep.c: Sort headers.
7669         * aarch64-linux-nat.c: Sort headers.
7670         * aarch64-fbsd-tdep.c: Sort headers.
7671         * aarch64-fbsd-nat.c: Sort headers.
7672         * aarch32-linux-nat.c: Sort headers.
7673
7674 2019-04-04  Tom Tromey  <tom@tromey.com>
7675
7676         * varobj.c (varobj_create): Update.
7677         * rust-exp.y (struct rust_parser) <update_innermost_block,
7678         lookup_symbol>: New methods.
7679         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7680         Rename.
7681         (rust_parser::rust_lookup_type)
7682         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7683         * printcmd.c (display_command, do_one_display): Update.
7684         * parser-defs.h (struct parser_state) <parser_state>: Add
7685         "tracker" parameter.
7686         (block_tracker): New member.
7687         (class innermost_block_tracker) <innermost_block_tracker>: Add
7688         "types" parameter.
7689         <reset>: Remove method.
7690         (innermost_block): Don't declare.
7691         (null_post_parser): Update.
7692         * parse.c (innermost_block): Remove global.
7693         (write_dollar_variable): Update.
7694         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7695         Remove "tracker_types" parameter.
7696         (parse_expression): Add "tracker" parameter.
7697         (parse_expression_for_completion): Update.
7698         (null_post_parser): Add "tracker" parameter.
7699         * p-exp.y: Update rules.
7700         * m2-exp.y: Update rules.
7701         * language.h (struct language_defn) <la_post_parser>: Add
7702         "tracker" parameter.
7703         * go-exp.y: Update rules.
7704         * f-exp.y: Update rules.
7705         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7706         parameter.
7707         * d-exp.y: Update rules.
7708         * c-exp.y: Update rules.
7709         * breakpoint.c (set_breakpoint_condition): Create an
7710         innermost_block_tracker.
7711         (watch_command_1): Likewise.
7712         * ada-lang.c (resolve): Add "tracker" parameter.
7713         (resolve_subexp): Likewise.
7714         * ada-exp.y (write_var_from_sym): Update.
7715
7716 2019-04-04  Tom Tromey  <tom@tromey.com>
7717
7718         * type-stack.h: New file.
7719         * type-stack.c: New file.
7720         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7721         type-stack.h.
7722         (insert_into_type_stack, insert_type, push_type, push_type_int)
7723         (insert_type_address_space, pop_type, pop_type_int)
7724         (pop_typelist, pop_type_stack, append_type_stack)
7725         (push_type_stack, get_type_stack, push_typelist)
7726         (follow_type_instance_flags, follow_types): Don't declare.
7727         * parse.c (type_stack): Remove global.
7728         (parse_exp_in_context): Update.
7729         (insert_into_type_stack, insert_type, push_type, push_type_int)
7730         (insert_type_address_space, pop_type, pop_type_int)
7731         (pop_typelist, pop_type_stack, append_type_stack)
7732         (push_type_stack, get_type_stack, push_typelist)
7733         (follow_type_instance_flags, follow_types): Remove (moved to
7734         type-stack.c).
7735         * f-exp.y (type_stack): New global.
7736         Update rules.
7737         (push_kind_type, f_parse): Update.
7738         * d-exp.y (type_stack): New global.
7739         Update rules.
7740         (d_parse): Update.
7741         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7742         Update rules.
7743         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7744         (HFILES_NO_SRCDIR): Add type-stack.h.
7745
7746 2019-04-04  Tom Tromey  <tom@tromey.com>
7747
7748         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7749         (rust_parser::convert_ast_to_expression, rust_parse)
7750         (rust_lex_test_completion, rust_lex_tests): Update.
7751         * parser-defs.h (struct expr_completion_state): New.
7752         (struct parser_state) <parser_state>: Add completion parameter.
7753         <mark_struct_expression, mark_completion_tag>: New methods.
7754         <parse_completion, m_completion_state>: New members.
7755         (prefixify_expression, null_post_parser): Update.
7756         (mark_struct_expression, mark_completion_tag): Don't declare.
7757         * parse.c (parse_completion, expout_last_struct)
7758         (expout_tag_completion_type, expout_completion_name): Remove
7759         globals.
7760         (parser_state::mark_struct_expression)
7761         (parser_state::mark_completion_tag): Now methods.
7762         (prefixify_expression): Add last_struct parameter.
7763         (prefixify_subexp): Likewise.
7764         (parse_exp_1): Update.
7765         (parse_exp_in_context): Add cstate parameter.  Update.
7766         (parse_expression_for_completion): Create an
7767         expr_completion_state.
7768         (null_post_parser): Add "completion" parameter.
7769         * p-exp.y: Update rules.
7770         (yylex): Update.
7771         * language.h (struct language_defn) <la_post_parser>: Add
7772         "completing" parameter.
7773         * go-exp.y: Update rules.
7774         (lex_one_token): Update.
7775         * expression.h (parse_completion): Don't declare.
7776         * d-exp.y: Update rules.
7777         (lex_one_token): Update rules.
7778         * c-exp.y: Update rules.
7779         (lex_one_token): Update.
7780         * ada-lang.c (resolve): Add "parse_completion" parameter.
7781         (resolve_subexp): Likewise.
7782         (ada_resolve_function): Likewise.
7783
7784 2019-04-04  Tom Tromey  <tom@tromey.com>
7785
7786         * parser-defs.h (struct parser_state) <start_arglist,
7787         end_arglist>: New methods.
7788         <arglist_len, m_funcall_chain>: New members.
7789         (arglist_len, start_arglist, end_arglist): Don't declare.
7790         * parse.c (arglist_len, funcall_chain): Remove global.
7791         (start_arglist, end_arglist): Remove functions.
7792         (parse_exp_in_context): Update.
7793         * p-exp.y: Update rules.
7794         * m2-exp.y: Update rules.
7795         * go-exp.y: Update rules.
7796         * f-exp.y: Update rules.
7797         * d-exp.y: Update rules.
7798         * c-exp.y: Update rules.
7799
7800 2019-04-04  Tom Tromey  <tom@tromey.com>
7801
7802         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7803         lex_operator, push_back>: New methods.
7804         Update all rules.
7805         (rust_parser::lex_hex, lex_escape): Rename and update.
7806         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7807         (rust_parser::lex_operator): Rename and update.
7808         (rust_parser::lex_number, rustyylex, rustyyerror)
7809         (rust_lex_test_init, rust_lex_test_sequence)
7810         (rust_lex_test_push_back, rust_lex_tests): Update.
7811         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7812         parameter.
7813         <lexptr, prev_lexptr>: New members.
7814         (lexptr, prev_lexptr): Don't declare.
7815         * parse.c (lexptr, prev_lexptr): Remove globals.
7816         (parse_exp_in_context): Update.
7817         * p-exp.y (yylex, yyerror): Update.
7818         * m2-exp.y (parse_number, yylex, yyerror): Update.
7819         * go-exp.y (lex_one_token, yyerror): Update.
7820         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7821         * d-exp.y (lex_one_token, yyerror): Update.
7822         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7823         (lex_one_token, yyerror): Update.
7824         * ada-lex.l (YY_INPUT): Update.
7825         (rewind_to_char): Update.
7826         * ada-exp.y (yyerror): Update.
7827
7828 2019-04-04  Tom Tromey  <tom@tromey.com>
7829
7830         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7831         * parser-defs.h (struct parser_state) <parser_state>: Add new
7832         parameter.
7833         <comma_terminates>: New member.
7834         (comma_terminates): Don't declare global.
7835         * parse.c (comma_terminates): Remove global.
7836         (parse_exp_in_context): Update.
7837         * p-exp.y (yylex): Update.
7838         * m2-exp.y (yylex): Update.
7839         * go-exp.y (lex_one_token): Update.
7840         * f-exp.y (yylex): Update.
7841         * d-exp.y (lex_one_token): Update.
7842         * c-exp.y (lex_one_token): Update.
7843         * ada-lex.l: Update.
7844
7845 2019-04-04  Tom Tromey  <tom@tromey.com>
7846
7847         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7848         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7849         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7850         * parser-defs.h (paren_depth): Don't declare.
7851         * parse.c (paren_depth): Remove global.
7852         (parse_exp_in_context): Update.
7853         * p-exp.y (paren_depth): New global.
7854         (pascal_parse): Initialize it.
7855         * m2-exp.y (paren_depth): New global.
7856         (m2_parse): Initialize it.
7857         * go-exp.y (paren_depth): New global.
7858         (go_parse): Initialize it.
7859         * f-exp.y (paren_depth): New global.
7860         (f_parse): Initialize it.
7861         * d-exp.y (paren_depth): New global.
7862         (d_parse): Initialize it.
7863         * c-exp.y (paren_depth): New global.
7864         (c_parse): Initialize it.
7865         * ada-lex.l (paren_depth): New global.
7866         (lexer_init): Initialize it.
7867
7868 2019-04-04  Tom Tromey  <tom@tromey.com>
7869
7870         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7871         (rust_parser::convert_ast_to_type)
7872         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7873         * parser-defs.h (struct parser_state) <parser_state>: Add
7874         parameters.  Initialize new members.
7875         <expression_context_block, expression_context_pc>: New members.
7876         * parse.c (expression_context_block, expression_context_pc):
7877         Remove globals.
7878         (parse_exp_in_context): Update.
7879         * p-exp.y: Update all rules.
7880         (yylex): Update.
7881         * m2-exp.y: Update all rules.
7882         (yylex): Update.
7883         * go-exp.y (yylex): Update.
7884         * f-exp.y (yylex): Update.
7885         * d-exp.y: Update all rules.
7886         (yylex): Update.
7887         * c-exp.y: Update all rules.
7888         (lex_one_token, classify_name, yylex, c_parse): Update.
7889         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7890
7891 2019-04-04  Tom Tromey  <tom@tromey.com>
7892
7893         * gdbarch.h, gdbarch.c: Rebuild.
7894         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7895         * stap-probe.h:
7896         (struct stap_parse_info): Replace "parser_state" with
7897         "expr_builder".
7898         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7899         (parser_state): New class.
7900         * parse.c (expr_builder): Rename.
7901         (expr_builder::release): Rename.
7902         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7903         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7904         (write_exp_elt_longcst, write_exp_elt_floatcst)
7905         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7906         (write_exp_string_vector, write_exp_bitstring)
7907         (write_exp_msymbol, mark_struct_expression)
7908         (write_dollar_variable)
7909         (insert_type_address_space, increase_expout_size): Replace
7910         "parser_state" with "expr_builder".
7911         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7912         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7913         "parser_state" with "expr_builder".
7914
7915 2019-04-04  Tom Tromey  <tom@tromey.com>
7916
7917         * rust-exp.y: Replace "parse_language" with method call.
7918         * p-exp.y:
7919         (yylex): Replace "parse_language" with method call.
7920         * m2-exp.y:
7921         (yylex): Replace "parse_language" with method call.
7922         * go-exp.y (classify_name): Replace "parse_language" with method
7923         call.
7924         * f-exp.y (yylex): Replace "parse_language" with method call.
7925         * d-exp.y (lex_one_token): Replace "parse_language" with method
7926         call.
7927         * c-exp.y:
7928         (lex_one_token, classify_name, yylex): Replace "parse_language"
7929         with method call.
7930         * ada-exp.y (find_primitive_type, type_char)
7931         (type_system_address): Replace "parse_language" with method call.
7932
7933 2019-04-04  Tom Tromey  <tom@tromey.com>
7934
7935         * rust-exp.y: Replace "parse_gdbarch" with method call.
7936         * parse.c (write_dollar_variable, insert_type_address_space):
7937         Replace "parse_gdbarch" with method call.
7938         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7939         call.
7940         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7941         call.
7942         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7943         "parse_gdbarch" with method call.
7944         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7945         with method call.
7946         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7947         "parse_gdbarch" with method call.
7948         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7949         "parse_gdbarch" with method call.
7950         * c-exp.y (parse_type, parse_number, classify_name): Replace
7951         "parse_gdbarch" with method call.
7952         * ada-lex.l: Replace "parse_gdbarch" with method call.
7953         * ada-exp.y (parse_type, find_primitive_type, type_char)
7954         (type_system_address): Replace "parse_gdbarch" with method call.
7955
7956 2019-04-04  Tom Tromey  <tom@tromey.com>
7957
7958         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7959         * stap-probe.c (stap_parse_argument): Update.
7960         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7961         initial_size parameter.
7962         * rust-exp.y (rust_lex_tests): Update.
7963         * parse.c (parser_state): Update.
7964         (parse_exp_in_context): Update.
7965         * parser-defs.h (struct parser_state) <parser_state>: Remove
7966         "initial_size" parameter.
7967
7968 2019-04-04  Tom Tromey  <tom@tromey.com>
7969
7970         * parser-defs.h (increase_expout_size): Don't declare.
7971         * parse.c (increase_expout_size): Now static.
7972
7973 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7974
7975         * gnu-nat.c (gnu_nat_target::wait): Fix
7976         target_waitstatus_to_string call.
7977
7978 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7979
7980         * eval.c (evaluate_subexp_standard): Handle internal functions
7981         during Fortran function call handling.
7982
7983 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7984
7985         * NEWS: Mention new internal functions.
7986         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7987         (read_base_type): Use dwarf2_init_complex_target_type.
7988         * value.c (creal_internal_fn): New function.
7989         (cimag_internal_fn): New function.
7990         (_initialize_values): Register new internal functions.
7991
7992 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7993
7994         * infrun.c (stop_all_threads): If debug_infrun, always
7995         trace the wait status after wait_one, using
7996         target_waitstatus_to_string and target_pid_to_str.
7997         (handle_inferior_event): Replace various trace of
7998         wait status kind by a single trace.
7999         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8000         wait status kind image by target_waitstatus_to_string.
8001         * target/waitstatus.c (target_waitstatus_to_string): Fix
8002         obsolete comment.
8003
8004 2019-04-01  Tom Tromey  <tromey@adacore.com>
8005
8006         PR symtab/23331:
8007         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8008
8009 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8010             Pedro Alves  <palves@redhat.com>
8011
8012         * top.c (quit_force): Call 'finalize_values'.
8013         * value.c (finalize_values): New function.
8014         * value.h (finalize_values): Declare.
8015
8016 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8017
8018         * NEWS: Announce $_gdb_major and $_gdb_minor.
8019
8020         * top.c (init_gdb_version_vars): New function.
8021         (gdb_init): Call init_gdb_version_vars.
8022
8023 2019-03-29  Tom Tromey  <tromey@adacore.com>
8024
8025         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8026         help text.  Remove dead code.
8027
8028 2019-03-29  Keith Seitz  <keiths@redhat.com>
8029
8030         From Siddhesh Poyarekar:
8031         * f-lang.h (f77_get_upperbound): Return LONGEST.
8032         (f77_get_lowerbound): Likewise.
8033         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8034         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8035         print them.
8036         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8037         plongest to format print it.
8038         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8039         (f77_get_upperbound): Likewise.
8040         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8041         LOWER_BOUND to LONGEST.
8042         (f77_create_arrayprint_offset_tbl): Likewise.
8043
8044 2019-03-29  Keith Seitz  <keiths@redhat.com>
8045
8046         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8047         %s/pulongest for TYPE_LENGTH instead of %d in format
8048         strings.
8049         * ada-typerint.c (ada_print_type): Likewise.
8050         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8051         * compile/compile-c-support.c (generate_register_struct): Likewise.
8052         * gdbtypes.c (recursive_dump_type): Likewise.
8053         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8054         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8055         instead of %d in format strings.
8056         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8057         to std::min to ULONGEST.
8058         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8059         instead of %d in format strings.
8060         * tracepoint.c (info_scope_command): Likewise.
8061         * typeprint.c (print_offset_data::update)
8062         (print_offset_data::finish): Likewise.
8063         * xtensa-tdep.c (xtensa_store_return_value)
8064         (xtensa_push_dummy_call): Likewise.
8065
8066 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8067
8068         * windows-nat.c (display_selector): Fixed format specifications
8069         for 64-bit Cygwin.
8070
8071 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8072
8073         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8074
8075 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8076
8077         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8078         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8079         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8080         (nios2_linux_init_abi): Install it.
8081
8082 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8083
8084         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8085
8086 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8087
8088         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8089
8090 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8091             Tom Tromey  <tromey@adacore.com>
8092
8093         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8094
8095 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8096
8097         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8098         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8099         method to compute the bounds of range types. Also print "[evaluated]"
8100         if the bounds' values come from a dynamic evaluation.
8101
8102 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8103
8104         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8105         whitespace when pretty printing is on.
8106
8107 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8108
8109         * ppc-linux-nat.c: Add include.
8110
8111 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8112
8113         * NEWS: Mention AArch64 Pointer Authentication.
8114
8115 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8116
8117         * arm-linux-nat.c: Add include.
8118
8119 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8120
8121         * source-cache.c (source_cache::get_source_lines): Re-read
8122         fullname after calling open_source_file.
8123
8124 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8125
8126         * NEWS: Mention TLS support for FreeBSD.
8127
8128 2019-03-25  Tom Tromey  <tromey@adacore.com>
8129
8130         * minsyms.c (BUNCH_SIZE): Update comment.
8131         (~minimal_symbol_reader): Remove old comment.
8132         (compact_minimal_symbols): Update comment.
8133         (minimal_symbol_reader::install): Remove old comment.  Update
8134         other comments.
8135
8136 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8137
8138         * s390-linux-nat.c: Add include.
8139
8140 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8141
8142         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8143         Call linux_get_hwcap.
8144         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8145         Likewise.
8146         (aarch64_linux_get_hwcap): Remove function.
8147         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8148         declaration.
8149         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8150         linux_get_hwcap.
8151         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8152         * linux-tdep.c (linux_get_hwcap): Add function.
8153         (linux_get_hwcap2): Likewise.
8154         * linux-tdep.h (linux_get_hwcap): Add declaration.
8155         (linux_get_hwcap2): Likewise.
8156         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8157         (ppc_linux_get_hwcap2): Likewise.
8158         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8159         linux_get_hwcap.
8160         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8161         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8162         (ppc_linux_nat_target::read_description): Likewise.
8163         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8164         * s390-linux-nat.c: Likewise.
8165         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8166
8167 2019-03-24  Tom Tromey  <tom@tromey.com>
8168
8169         * ada-lang.c (standard_lookup): Simplify initialization.
8170         (ada_lookup_symbol_nonlocal): Simplify return.
8171         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8172         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8173         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8174         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8175         initialization.
8176         * solib.c (solib_global_lookup): Simplify.
8177         * symtab.c (null_block_symbol): Remove.
8178         (symbol_cache_lookup): Simplify returns.
8179         (lookup_language_this): Simplify returns.
8180         (lookup_symbol_aux): Simplify return.
8181         (lookup_local_symbol): Simplify returns.
8182         (lookup_global_symbol_from_objfile): Simplify return.
8183         (lookup_symbol_in_objfile_symtabs)
8184         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8185         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8186         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8187         * cp-namespace.c (cp_lookup_bare_symbol)
8188         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8189         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8190         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8191         (cp_lookup_symbol_via_imports): Simplify initialization.
8192         (find_symbol_in_baseclass): Likewise.
8193         * symtab.h (null_block_symbol): Remove.
8194         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8195         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8196         (d_lookup_symbol_module): Likewise.
8197         (find_symbol_in_baseclass): Simplify initialization.
8198
8199 2019-03-24  Tom Tromey  <tom@tromey.com>
8200
8201         * expression.h: Don't include symtab.h.
8202         (struct block): Forward declare.
8203
8204 2019-03-24  Tom Tromey  <tom@tromey.com>
8205
8206         * c-exp.y (typebase): Remove casts.
8207         * gdbtypes.c (lookup_unsigned_typename, )
8208         (lookup_signed_typename): Remove cast.
8209         * eval.c (parse_to_comma_and_eval): Remove cast.
8210         * parse.c (write_dollar_variable): Remove cast.
8211         * block.h (struct block) <superblock>: Now const.
8212         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8213         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8214         (map_block): Make "block" const.
8215         * symfile.h (struct quick_symbol_functions)
8216         <map_matching_symbols>: Constify block argument to "callback".
8217         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8218         const.
8219         (find_pc_sect_compunit_symtab): Make "b" const.
8220         (find_symbol_at_address): Likewise.
8221         (search_symbols): Likewise.
8222         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8223         (dw2_debug_names_lookup_symbol): Likewise.
8224         (dw2_map_matching_symbols): Update.
8225         * p-valprint.c (pascal_val_print): Remove "block".
8226         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8227         (aux_add_nonlocal_symbols): Make "block" const.
8228         (resolve_subexp): Remove cast.
8229         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8230         const.
8231         (iterate_over_file_blocks): Likewise.
8232         * f-exp.y (%union) <bval>: Remove.
8233         * coffread.c (patch_opaque_types): Make "b" const.
8234         * spu-tdep.c (spu_catch_start): Make "block" const.
8235         * c-valprint.c (print_unpacked_pointer): Remove "block".
8236         * symmisc.c (dump_symtab_1): Make "b" const.
8237         (block_depth): Make "block" const.
8238         * d-exp.y (%union) <bval>: Remove.
8239         * cp-support.h (cp_lookup_rtti_type): Update.
8240         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8241         * psymtab.c (psym_lookup_symbol): Make "block" const.
8242         (maintenance_check_psymtabs): Make "b" const.
8243         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8244         (enumerate_locals, enumerate_args): Update.
8245         * python/py-symtab.c (stpy_global_block): Make "block" const.
8246         (stpy_static_block): Likewise.
8247         * inline-frame.c (block_starting_point_at): Make "new_block"
8248         const.
8249         * block.c (find_block_in_blockvector): Make return type const.
8250         (blockvector_for_pc_sect): Make "b" const.
8251         (find_block_in_blockvector): Make "b" const.
8252
8253 2019-03-23  Tom Tromey  <tom@tromey.com>
8254
8255         * varobj.c (varobj_create): Update.
8256         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8257         * printcmd.c (display_command, do_one_display): Don't reset
8258         innermost_block.
8259         * parser-defs.h (enum innermost_block_tracker_type): Move to
8260         expression.h.
8261         (innermost_block): Update comment.
8262         * parse.c (parse_exp_1): Add tracker_types parameter.
8263         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8264         tracker_types parameter.  Reset innermost_block.
8265         (parse_exp_in_context): Remove.
8266         (parse_expression_for_completion): Update.
8267         * objfiles.c (~objfile): Don't reset expression_context_block or
8268         innermost_block.
8269         * expression.h (enum innermost_block_tracker_type): Move from
8270         parser-defs.h.
8271         (parse_exp_1): Add tracker_types parameter.
8272         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8273         reset innermost_block.
8274
8275 2019-03-23  Tom Tromey  <tom@tromey.com>
8276
8277         * objfiles.h: Include bcache.h.
8278
8279 2019-03-23  Tom Tromey  <tom@tromey.com>
8280
8281         * linespec.c (get_current_search_block): Use
8282         scoped_restore_current_language.
8283         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8284
8285 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8286             Jiong Wang  <jiong.wang@arm.com>
8287
8288         * aarch64-linux-tdep.c
8289         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8290         section.
8291         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8292
8293 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8294             Jiong Wang  <jiong.wang@arm.com>
8295
8296         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8297         instructions.
8298         (aarch64_analyze_prologue_test): Add PACIASP test.
8299         (aarch64_prologue_prev_register): Unmask PC value.
8300
8301 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8302             Jiong Wang  <jiong.wang@arm.com>
8303
8304         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8305         (aarch64_dwarf2_prev_register): Unmask PC value.
8306         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8307         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8308         DW_CFA_AARCH64_negate_ra_state.
8309         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8310
8311 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8312             Jiong Wang  <jiong.wang@arm.com>
8313
8314         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8315         registers.
8316         (aarch64_pseudo_register_name): Likewise.
8317         (aarch64_pseudo_register_type): Likewise.
8318         (aarch64_pseudo_register_reggroup_p): Likewise.
8319         (aarch64_gdbarch_init): Add pauth registers.
8320         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8321         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8322         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8323         (struct gdbarch_tdep): Add regnum for ra_state.
8324
8325 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8326             Jiong Wang  <jiong.wang@arm.com>
8327
8328         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8329
8330 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8331             Jiong Wang  <jiong.wang@arm.com>
8332
8333         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8334         function.
8335         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8336         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8337         (aarch64_gdbarch_init): Add puth registers.
8338         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8339         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8340         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8341
8342 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8343             Jiong Wang  <jiong.wang@arm.com>
8344
8345         * aarch64-linux-nat.c
8346         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8347         * aarch64-linux-tdep.c
8348         (aarch64_linux_core_read_description): Likewise.
8349         (aarch64_linux_get_hwcap): New function.
8350         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8351         (aarch64_linux_get_hwcap): New declaration.
8352
8353 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8354             Jiong Wang  <jiong.wang@arm.com>
8355
8356         * aarch64-linux-nat.c
8357         (aarch64_linux_nat_target::read_description): Add pauth param.
8358         * aarch64-linux-tdep.c
8359         (aarch64_linux_core_read_description): Likewise.
8360         * aarch64-tdep.c (struct target_desc): Add in pauth.
8361         (aarch64_read_description): Add pauth param.
8362         (aarch64_gdbarch_init): Likewise.
8363         * aarch64-tdep.h (aarch64_read_description): Likewise.
8364         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8365         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8366         * features/Makefile: Add new files.
8367         * features/aarch64-pauth.c: New file.
8368         * features/aarch64-pauth.xml: New file.
8369
8370 2019-03-20  Tom Tromey  <tromey@adacore.com>
8371
8372         * infrun.c (handle_inferior_event): Rename from
8373         handle_inferior_event_1.  Create a scoped_value_mark.
8374         (handle_inferior_event): Remove.
8375
8376 2019-03-19  Tom Tromey  <tromey@adacore.com>
8377
8378         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8379         * infrun.h (print_stop_event): Add "displays" parameter.
8380         * infrun.c (print_stop_event): Add "displays" parameter.
8381
8382 2019-03-19  Pedro Alves  <palves@redhat.com>
8383
8384         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8385         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8386         to -1.  Fix TABs vs spaces.
8387         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8388         * tui/tui-out.h (tui_ui_out) Add intro comments.
8389         <m_line, m_start_of_line>: In-class initialize, and add describing
8390         comment.
8391
8392 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8393
8394         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8395         variable names.
8396         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8397
8398 2019-03-18  Pedro Alves  <palves@redhat.com>
8399             Eli Zaretskii <eliz@gnu.org>
8400
8401         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8402         m_line and m_start_of_line.
8403
8404 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8405
8406         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8407         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8408         it returns a newline.  This fixes a regression in TU mode, whereby
8409         the next line is output on the same screen line as the user input.
8410
8411 2019-03-18  Tom Tromey  <tromey@adacore.com>
8412
8413         * minsyms.c (minimal_symbol_reader::install): Remove call to
8414         obstack_blank.
8415
8416 2019-03-18  Pedro Alves  <palves@redhat.com>
8417
8418         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8419         New globals.
8420         (apply_style): New, factored out from ...
8421         (apply_ansi_escape): ... this.  Handle reverse video mode.
8422         (tui_set_reverse_mode): New function.
8423         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8424         * tui/tui-winsource.c (tui_show_source_line): Use
8425         tui_set_reverse_mode instead of setting A_STANDOUT.
8426         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8427         New setter methods.
8428
8429 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8430
8431         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8432         Handle tabs.
8433
8434 2019-03-18  Tom Tromey  <tromey@adacore.com>
8435
8436         * ada-lang.c (empty_array): Add "high" parameter.
8437         (ada_evaluate_subexp): Update.
8438
8439 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8440
8441         * unittests/string_view-selftests.c: Define
8442         _initialize_string_view_selftests unconditionally.
8443
8444 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8445
8446         PR gdb/24350
8447         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8448
8449 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8450
8451         PR gdb/24351
8452         * windows-nat.c (display_selector): Fix format specifiers.
8453
8454 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8455
8456         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8457         tui_refill_source_window instead of tui_refresh_win, to update the
8458         current execution line.  This fixes redisplay of the current line
8459         when stepping through the code with "next" or "step".
8460
8461 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8462
8463         * source-cache.c (source_cache::get_source_lines): Call
8464         find_source_lines to initialize s->nlines.  This fixes vertical
8465         scrolling of TUI source window when the DOWN arrow is pressed.
8466
8467 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8468
8469         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8470         linux-thread-db.c (_initialize_thread_db): Likewise.
8471
8472 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8473
8474         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8475         wclrtoeol in tui_show_source_line".  This reverts changes made in
8476         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8477
8478 2019-03-15  Tom Tromey  <tom@tromey.com>
8479
8480         * symtab.h (struct minimal_symbol): Derive from
8481         general_symbol_info.
8482         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8483         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8484         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8485         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8486         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8487         (MSYMBOL_SEARCH_NAME): Update.
8488         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8489         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8490         * minsyms.c (minimal_symbol_reader::record_full): Update.
8491
8492 2019-03-15  Tom Tromey  <tom@tromey.com>
8493
8494         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8495
8496 2019-03-15  Tom Tromey  <tom@tromey.com>
8497
8498         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8499         unique_xmalloc_ptr.
8500         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8501         Update.
8502         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8503         (build_minimal_symbol_hash_tables)
8504         (minimal_symbol_reader::install): Update.
8505
8506 2019-03-15  Tom Tromey  <tom@tromey.com>
8507
8508         * symtab.c (create_demangled_names_hash): Update.
8509         (symbol_set_names): Update.
8510         * objfiles.h (struct objfile_per_bfd_storage)
8511         <demangled_names_hash>: Now an htab_up.
8512         * objfiles.c (objfile_per_bfd_storage): Simplify.
8513
8514 2019-03-15  Tom Tromey  <tom@tromey.com>
8515
8516         * objfiles.h (struct objfile_per_bfd_storage): Declare
8517         destructor.
8518         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8519         New.
8520         (get_objfile_bfd_data): Use new.  Don't initialize
8521         language_of_main.
8522         (free_objfile_per_bfd_storage): Remove.
8523         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8524
8525 2019-03-15  Tom Tromey  <tom@tromey.com>
8526
8527         * symfile.c (reread_symbols): Update.
8528         * objfiles.c (objfile::objfile): Update.
8529         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8530         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8531         comment.
8532         (minimal_symbol_reader::install): Update.
8533         (terminate_minimal_symbol_table): Remove.
8534         * jit.c (jit_object_close_impl): Update.
8535
8536 2019-03-15  Tom Tromey  <tom@tromey.com>
8537
8538         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8539         initializations.
8540
8541 2019-03-15  Tom Tromey  <tom@tromey.com>
8542
8543         * objfiles.h (struct objfile_per_bfd_storage)
8544         <demangled_hash_languages>: Now a bitset.
8545         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8546         (lookup_minimal_symbol): Update.
8547
8548 2019-03-15  Tom Tromey  <tom@tromey.com>
8549
8550         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8551         Don't return the symbol.
8552         * coffread.c (record_minimal_symbol): Use record_full.
8553
8554 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8555
8556         The MS-Windows port of ncurses fails to switch to a color pair if
8557         one or both of the colors are the implicit default colors.  This
8558         change records the default colors when TUI is initialized, and
8559         then specifies them explicitly when a color pair uses the default
8560         colors.  This allows color styling in TUI mode on MS-Windows.
8561
8562         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8563         ncurses_norm_attr.
8564         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8565         colors in ncurses_norm_attr.
8566         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8567         "none", replace it with the default color recorded in
8568         ncurses_norm_attr.
8569
8570 2019-03-14  Tom Tromey  <tromey@adacore.com>
8571
8572         * source-cache.h (class source_cache) <get_source_lines>: Return
8573         std::string.
8574         * source-cache.c (source_cache::extract_lines): Handle case where
8575         first_pos==npos.  Return std::string.
8576         (source_cache::get_source_lines): Update.
8577
8578 2019-03-14  Tom Tromey  <tromey@adacore.com>
8579
8580         * NEWS: Add item for "style sources" commands.
8581         * source-cache.c (source_cache::get_source_lines): Check
8582         source_styling.
8583         * cli/cli-style.c (source_styling): New global.
8584         (_initialize_cli_style): Add "style sources" commands.
8585         (show_style_sources): New function.
8586         * cli/cli-style.h (source_styling): Declare.
8587
8588 2019-03-14  Pedro Alves  <palves@redhat.com>
8589             Tom Tromey  <tromey@adacore.com>
8590
8591         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8592         * tui/tui-winsource.c (tui_refill_source_window): New function,
8593         from...
8594         (tui_horizontal_source_scroll): ... here.  Move some logic.
8595         * cli/cli-style.c (set_style_enabled): Notify new observable.
8596         * tui/tui-hooks.c (tui_redisplay_source): New function.
8597         (tui_attach_detach_observers): Attach or detach
8598         tui_redisplay_source.
8599         * observable.h (source_styling_changed): New observable.
8600         * observable.c: Define source_styling_changed observable.
8601
8602 2019-03-13  Tom Tromey  <tromey@adacore.com>
8603
8604         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8605         (i386_gnu_nat_target::store_registers): Update.
8606         * target-debug.h (target_debug_print_std_string): New macro.
8607         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8608         * windows-tdep.c (display_one_tib): Update.
8609         * tui/tui-stack.c (tui_make_status_line): Update.
8610         * top.c (print_inferior_quit_action): Update.
8611         * thread.c (thr_try_catch_cmd): Update.
8612         (add_thread_with_info): Update.
8613         (thread_target_id_str): Update.
8614         (thr_try_catch_cmd): Update.
8615         (thread_command): Update.
8616         (thread_find_command): Update.
8617         * record-btrace.c (record_btrace_target::info_record)
8618         (record_btrace_resume_thread, record_btrace_target::resume)
8619         (record_btrace_cancel_resume, record_btrace_step_thread)
8620         (record_btrace_target::wait, record_btrace_target::wait)
8621         (record_btrace_target::wait, record_btrace_target::stop): Update.
8622         * progspace.c (print_program_space): Update.
8623         * process-stratum-target.c
8624         (process_stratum_target::thread_address_space): Update.
8625         * linux-fork.c (linux_fork_mourn_inferior)
8626         (detach_checkpoint_command, info_checkpoints_command)
8627         (linux_fork_context): Update.
8628         (linux_fork_detach): Update.
8629         (class scoped_switch_fork_info): Update.
8630         (delete_checkpoint_command): Update.
8631         * infrun.c (follow_fork_inferior): Update.
8632         (follow_fork_inferior): Update.
8633         (proceed_after_vfork_done): Update.
8634         (handle_vfork_child_exec_or_exit): Update.
8635         (follow_exec): Update.
8636         (displaced_step_prepare_throw): Update.
8637         (displaced_step_restore): Update.
8638         (start_step_over): Update.
8639         (resume_1): Update.
8640         (clear_proceed_status_thread): Update.
8641         (proceed): Update.
8642         (print_target_wait_results): Update.
8643         (do_target_wait): Update.
8644         (context_switch): Update.
8645         (stop_all_threads): Update.
8646         (restart_threads): Update.
8647         (finish_step_over): Update.
8648         (handle_signal_stop): Update.
8649         (switch_back_to_stepped_thread): Update.
8650         (keep_going_pass_signal): Update.
8651         (print_exited_reason): Update.
8652         (normal_stop): Update.
8653         * inferior.c (inferior_pid_to_str): Change return type.
8654         (print_selected_inferior): Update.
8655         (add_inferior): Update.
8656         (detach_inferior): Update.
8657         * dummy-frame.c (fprint_dummy_frames): Update.
8658         * dcache.c (dcache_info_1): Update.
8659         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8660         (btrace_fetch, btrace_clear): Update.
8661         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8662         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8663         type.
8664         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8665         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8666         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8667         * gdbarch.c, gdbarch.h: Rebuild.
8668         * gdbarch.sh (core_pid_to_str): Change return type.
8669         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8670         return type.
8671         (windows_nat_target::pid_to_str): Change return type.
8672         (windows_delete_thread): Update.
8673         (windows_nat_target::attach): Update.
8674         (windows_nat_target::files_info): Update.
8675         * target-delegates.c: Rebuild.
8676         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8677         return type.
8678         (sol_thread_target::pid_to_str): Change return type.
8679         * remote.c (class remote_target) <pid_to_str>: Change return
8680         type.
8681         (remote_target::pid_to_str): Change return type.
8682         (extended_remote_target::attach, remote_target::remote_stop_ns)
8683         (remote_target::remote_notif_remove_queued_reply)
8684         (remote_target::push_stop_reply, remote_target::disable_btrace):
8685         Update.
8686         (extended_remote_target::attach): Update.
8687         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8688         type.
8689         (gdbsim_target::pid_to_str): Change return type.
8690         * ravenscar-thread.c (struct ravenscar_thread_target)
8691         <pid_to_str>: Change return type.
8692         (ravenscar_thread_target::pid_to_str): Change return type.
8693         * procfs.c (class procfs_target) <pid_to_str>: Change return
8694         type.
8695         (procfs_target::pid_to_str): Change return type.
8696         (procfs_target::attach): Update.
8697         (procfs_target::detach): Update.
8698         (procfs_target::fetch_registers): Update.
8699         (procfs_target::store_registers): Update.
8700         (procfs_target::wait): Update.
8701         (procfs_target::files_info): Update.
8702         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8703         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8704         return type.
8705         (nto_procfs_target::pid_to_str): Change return type.
8706         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8707         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8708         return type.
8709         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8710         (exit_lwp): Update.
8711         (attach_proc_task_lwp_callback, get_detach_signal)
8712         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8713         (linux_nat_target::resume, wait_lwp, stop_callback)
8714         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8715         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8716         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8717         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8718         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8719         type.
8720         (inf_ptrace_target::attach): Update.
8721         (inf_ptrace_target::files_info): Update.
8722         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8723         type.
8724         (go32_nat_target::pid_to_str): Change return type.
8725         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8726         (gnu_nat_target::wait): Update.
8727         (gnu_nat_target::wait): Update.
8728         (gnu_nat_target::resume): Update.
8729         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8730         (fbsd_nat_target::wait): Update.
8731         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8732         type.
8733         (darwin_nat_target::attach): Update.
8734         * corelow.c (class core_target) <pid_to_str>: Change return type.
8735         (core_target::pid_to_str): Change return type.
8736         * target.c (normal_pid_to_str): Change return type.
8737         (default_pid_to_str): Likewise.
8738         (target_pid_to_str): Change return type.
8739         (target_translate_tls_address): Update.
8740         (target_announce_detach): Update.
8741         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8742         return type.
8743         (bsd_uthread_target::pid_to_str): Change return type.
8744         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8745         type.
8746         (bsd_kvm_target::pid_to_str): Change return type.
8747         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8748         return type.
8749         (aix_thread_target::pid_to_str): Change return type.
8750         * target.h (struct target_ops) <pid_to_str>: Change return type.
8751         (target_pid_to_str, normal_pid_to_str): Likewise.
8752         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8753         type.
8754         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8755         type.
8756         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8757         return type.
8758         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8759         type.
8760         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8761         type.
8762         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8763         return type.
8764
8765 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8766
8767         * NEWS: Mention that the new default MI version is 3.  Mention
8768         changes to the output of commands and events that deal with
8769         multi-location breakpoints.
8770         * breakpoint.c: Include "mi/mi-out.h".
8771         (print_one_breakpoint): Change output syntax if using MI version
8772         >= 3.
8773         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8774         New.
8775         (mi_multi_location_breakpoint_output_fixed): New.
8776         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8777         (mi_cmd_fix_multi_location_breakpoint_output): New.
8778         (mi_multi_location_breakpoint_output_fixed): New.
8779         * mi/mi-cmds.c (mi_cmds): Register command
8780         -fix-multi-location-breakpoint-output.
8781         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8782         interpreter "mi".
8783
8784 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8785
8786         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8787         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8788         instantiate mi_ui_out based on interpreter name.
8789         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8790         * mi/mi-main.c (mi_load_progress): Likewise.
8791
8792 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8793
8794         * NEWS: Combine separate "New targets" sections for 8.3.
8795
8796 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8797
8798         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8799         (ppcfbsd_init_abi): Install gdbarch
8800         "fetch_tls_load_module_address" and "get_thread_local_address"
8801         methods.
8802
8803 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8804
8805         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8806         (riscv_fbsd_init_abi): Install gdbarch
8807         "fetch_tls_load_module_address" and "get_thread_local_address"
8808         methods.
8809
8810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8811
8812         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8813         (i386fbsd_init_abi): Install gdbarch
8814         "fetch_tls_load_module_address" and "get_thread_local_address"
8815         methods.
8816
8817 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8818
8819         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8820         (amd64fbsd_init_abi): Install gdbarch
8821         "fetch_tls_load_module_address" and "get_thread_local_address"
8822         methods.
8823
8824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8825
8826         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8827         (struct fbsd_pspace_data): New type.
8828         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8829         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8830         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8831         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8832         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8833
8834 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8835
8836         * gdbtypes.c (lookup_struct_elt): New function.
8837         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8838         * gdbtypes.h (struct struct_elt): New type.
8839         (lookup_struct_elt): New prototype.
8840
8841 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8842
8843         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8844         remove disabled code block.
8845
8846 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8847
8848         * gdbarch.sh (get_thread_local_address): New method.
8849         * gdbarch.h, gdbarch.c: Regenerate.
8850         * target.c (target_translate_tls_address): Use
8851         gdbarch_get_thread_local_address if present instead of
8852         target::get_thread_local_address.
8853
8854 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8855
8856         * target.h (target::get_thread_local_address): Update comment.
8857
8858 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8859
8860         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8861         objfile->separate_debug_objfile_backlink if not NULL.
8862
8863 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8864
8865         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8866         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8867         (amd64bsd_store_inferior_registers): Likewise.
8868         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8869         Enable segment base registers.
8870         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8871         PT_GETFSBASE and PT_GETGSBASE.
8872         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8873         PT_SETGSBASE.
8874         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8875         segment base registers.
8876         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8877
8878 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8879
8880         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8881         Update calls to i386_target_description to add 'segments'
8882         parameter.
8883         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8884         add segment base registers.
8885         * arch/i386.c (i386_create_target_description): Add 'segments'
8886         parameter to enable segment base registers.
8887         * arch/i386.h (i386_create_target_description): Likewise.
8888         * features/i386/32bit-segments.xml: New file.
8889         * features/i386/32bit-segments.c: Generate.
8890         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8891         call to i386_target_description to add 'segments' parameter.
8892         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8893         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8894         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8895         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8896         if feature is present.
8897         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8898         Add 'segments' parameter to call to i386_target_description.
8899         (i386_target_description): Add 'segments' parameter to enable
8900         segment base registers.
8901         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8902         to call to i386_target_description.
8903         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8904         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8905         Define I386_NUM_REGS.
8906         (i386_target_description): Add 'segments' parameter to enable
8907         segment base registers.
8908
8909 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8910
8911         PR/24325
8912         * source-cache.c: #undef open and close, to avoid unresolved
8913         externals during linking.
8914
8915 2019-03-12  Tom Tromey  <tromey@adacore.com>
8916
8917         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8918         const.  Add initializers.
8919         (_initialize_remote): Don't initialize ptid globals.
8920
8921 2019-03-12  Pedro Alves  <palves@redhat.com>
8922
8923         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8924
8925 2019-03-12  Pedro Alves  <palves@redhat.com>
8926
8927         * cp-name-parser.y (main): Remove unused 'len' variable.
8928
8929 2019-03-12  Tom Tromey  <tromey@adacore.com>
8930
8931         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8932         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8933
8934 2019-03-12  Tom Tromey  <tromey@adacore.com>
8935
8936         * linux-nat.c (iterate_over_lwps): Update.
8937         (stop_callback): Remove parameter.
8938         (stop_wait_callback, detach_callback, resume_set_callback)
8939         (select_singlestep_lwp_callback, set_ignore_sigint)
8940         (status_callback, resumed_callback, resume_clear_callback)
8941         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8942         data parameter.
8943         (linux_nat_target::detach, linux_nat_target::resume)
8944         (linux_stop_and_wait_all_lwps, select_event_lwp)
8945         (linux_nat_filter_event, linux_nat_wait_1)
8946         (linux_nat_target::kill, linux_nat_target::stop)
8947         (linux_nat_target::stop): Update.
8948         (linux_nat_resume_callback): Change type.
8949         (resume_stopped_resumed_lwps, count_events_callback)
8950         (select_event_lwp_callback): Likewise.
8951         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8952         * arm-linux-nat.c (struct update_registers_data): Remove.
8953         (update_registers_callback): Change type.
8954         (arm_linux_insert_hw_breakpoint1): Update.
8955         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8956         parameter.
8957         (x86_linux_dr_set_addr): Update.
8958         (x86_linux_dr_set_control): Update.
8959         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8960         (iterate_over_lwps): Use gdb::function_view.
8961         * nat/aarch64-linux-hw-point.c (struct
8962         aarch64_dr_update_callback_param): Remove.
8963         (debug_reg_change_callback): Change type.
8964         (aarch64_notify_debug_reg_change): Update.
8965         * s390-linux-nat.c (s390_refresh_per_info): Update.
8966
8967 2019-03-11  Tom Tromey  <tromey@adacore.com>
8968
8969         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8970         redundant assignment to "this_cu".
8971
8972 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8973
8974         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8975
8976 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8977
8978         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8979         from...
8980         (rank_one_type): ... this.
8981
8982 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8983
8984         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8985         from...
8986         (rank_one_type): ... this.
8987
8988 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8989
8990         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8991         from...
8992         (rank_one_type): ... this.
8993
8994 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8995
8996         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8997         from...
8998         (rank_one_type): ... this.
8999
9000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9001
9002         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9003         from...
9004         (rank_one_type): ... this.
9005
9006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9007
9008         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9009         from...
9010         (rank_one_type): ... this.
9011
9012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9013
9014         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9015         from...
9016         (rank_one_type): ... this.
9017
9018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9019
9020         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9021         from...
9022         (rank_one_type): ... this.
9023
9024 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9025
9026         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9027         from...
9028         (rank_one_type): ... this.
9029
9030 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9031
9032         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9033         from...
9034         (rank_one_type): ... this.
9035
9036 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9037
9038         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9039         from...
9040         (rank_one_type): ... this.
9041
9042 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9043
9044         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9045         from...
9046         (rank_one_type): ... this.
9047
9048 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9049
9050         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9051         inferior-events' shows the example events.
9052
9053 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9054
9055         Support styling on native MS-Windows console
9056
9057         PR/24315
9058         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9059         on MS-Windows if $TERM is not defined.
9060
9061         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9062
9063         * posix-hdep.c (gdb_console_fputs):
9064         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9065         functions.
9066         * ui-file.h (gdb_console_fputs): Add prototype.
9067
9068         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9069         back to fputs only if the former returns zero.
9070
9071 2019-03-07  Tom Tromey  <tom@tromey.com>
9072
9073         * symmisc.c (print_symbol_bcache_statistics): Update.
9074         (print_objfile_statistics): Update.
9075         * symfile.c (allocate_symtab): Update.
9076         * stabsread.c: Don't include bcache.h.
9077         * psymtab.h (struct psymbol_bcache): Don't declare.
9078         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9079         (psymbol_bcache_init, psymbol_bcache_free)
9080         (psymbol_bcache_get_bcache): Don't declare.
9081         * psymtab.c (struct psymbol_bcache): Remove.
9082         (psymtab_storage::psymtab_storage): Update.
9083         (psymtab_storage::~psymtab_storage): Update.
9084         (psymbol_bcache_init, psymbol_bcache_free)
9085         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9086         (add_psymbol_to_bcache): Update.
9087         (allocate_psymtab): Update.
9088         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9089         macro_cache>: No longer pointers.
9090         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9091         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9092         * macrotab.c (macro_bcache): Update.
9093         * macroexp.c: Don't include bcache.h.
9094         * gdbtypes.c (check_types_worklist): Update.
9095         (types_deeply_equal): Remove TRY/CATCH.  Update.
9096         * elfread.c (elf_symtab_read): Update.
9097         * dwarf2read.c: Don't include bcache.h.
9098         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9099         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9100         (print_bcache_statistics, bcache_memory_used): Don't declare.
9101         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9102         methods.  Rename all data members.
9103         * bcache.c (struct bcache): Move to bcache.h.
9104         (bcache::expand_hash_table): Rename from expand_hash_table.
9105         (bcache): Remove.
9106         (bcache::insert): Rename from bcache_full.
9107         (bcache::compare): Rename from bcache_compare.
9108         (bcache_xmalloc): Remove.
9109         (bcache::~bcache): Rename from bcache_xfree.
9110         (bcache::print_statistics): Rename from print_bcache_statistics.
9111         (bcache::memory_used): Rename from bcache_memory_used.
9112
9113 2019-03-07  Pedro Alves  <palves@redhat.com>
9114
9115         * infrun.c (normal_stop): Also check for
9116         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9117
9118 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9119
9120         * f-lang.c (value_from_host_double): Moved to...
9121         * value.c (value_from_host_double): ...here.
9122         * value.h (value_from_host_double): Declare.
9123         * guile/scm-math.c (vlscm_convert_typed_number): Use
9124         value_from_host_double.
9125         (vlscm_convert_number): Likewise.
9126         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9127         * python/py-value.c (convert_value_from_python): Likewise.
9128
9129 2019-03-06  Tom Tromey  <tom@tromey.com>
9130
9131         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9132
9133 2019-03-06  Tom Tromey  <tom@tromey.com>
9134
9135         * utils.h (free_current_contents): Don't declare.
9136         * utils.c (free_current_contents): Remove.
9137
9138 2019-03-06  Tom Tromey  <tom@tromey.com>
9139
9140         * top.c (quit_force): Update.
9141         * main.c (captured_command_loop): Update.
9142         * common/new-op.c (operator new): Update.
9143         * common/common-exceptions.c (struct catcher)
9144         <save_cleanup_chain>: Remove member.
9145         (exceptions_state_mc_init): Update.
9146         (exception_try_scope_entry): Return nullptr.
9147         (exception_try_scope_exit, exception_rethrow)
9148         (throw_exception_sjlj, throw_exception_cxx): Update.
9149         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9150         (all_cleanups, do_cleanups, discard_cleanups)
9151         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9152         (restore_cleanups, restore_final_cleanups): Don't declare.
9153         (do_final_cleanups): Remove parameter.
9154         * common/cleanups.c (cleanup_chain, make_cleanup)
9155         (make_cleanup_dtor, all_cleanups, do_cleanups)
9156         (discard_my_cleanups, discard_cleanups)
9157         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9158         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9159         (null_cleanup): Remove.
9160         (do_final_cleanups): Remove parameter.
9161
9162 2019-03-06  Tom Tromey  <tom@tromey.com>
9163
9164         * remote.c (remote_target::remote_parse_stop_reply): Use
9165         unique_xmalloc_ptr.
9166
9167 2019-03-06  Tom Tromey  <tom@tromey.com>
9168
9169         * stabsread.c (struct stabs_field_info): Rename from field_info.
9170         <list, fnlist>: Add initializers.
9171         <obstack>: New member.
9172         (read_member_functions, read_struct_fields, read_baseclasses):
9173         Allocate on obstack.  Don't use cleanups.
9174         (read_one_struct_field, read_member_functions, read_struct_fields)
9175         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9176         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9177         (read_struct_type): Update.
9178
9179 2019-03-06  Tom Tromey  <tom@tromey.com>
9180
9181         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9182         * common/filestuff.h (make_cleanup_close): Don't declare.
9183         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9184         Remove.
9185
9186 2019-03-06  Tom Tromey  <tom@tromey.com>
9187
9188         * solib-aix.c: Use make_scope_exit.
9189
9190 2019-03-06  Tom Tromey  <tom@tromey.com>
9191
9192         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9193         Use make_scope_exit.
9194
9195 2019-03-06  Tom Tromey  <tom@tromey.com>
9196
9197         * solib-svr4.c (disable_probes_interface): Remove parameter.
9198         (svr4_handle_solib_event): Use make_scope_exit.
9199
9200 2019-03-06  Tom Tromey  <tom@tromey.com>
9201
9202         * remote.c (struct stop_reply_deleter): Remove.
9203         (stop_reply_up): Update.
9204         (struct stop_reply): Derive from notif_event.  Don't typedef.
9205         <regcache>: Now a std::vector.
9206         (stop_reply_xfree): Remove.
9207         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9208         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9209         (remote_target::discard_pending_stop_replies): Use delete.
9210         (remote_target::remote_parse_stop_reply): Update.
9211         (remote_target::process_stop_reply): Update.
9212         * remote-notif.h (struct notif_event): Add virtual destructor.
9213         Remove "dtr" member.
9214         (struct notif_client) <alloc_event>: Return a unique_ptr.
9215         (notif_event_xfree): Don't declare.
9216         (notif_event_up): New typedef.
9217         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9218         (notif_event_xfree, do_notif_event_xfree): Remove.
9219         (remote_notif_state_xfree): Update.
9220
9221 2019-03-06  Tom Tromey  <tom@tromey.com>
9222
9223         * infrun.c (displaced_step_clear_cleanup): Now a
9224         forward_scope_exit type.
9225         (displaced_step_prepare_throw): Update.
9226         (displaced_step_fixup): Update.
9227
9228 2019-03-06  Tom Tromey  <tom@tromey.com>
9229
9230         * inferior.h (class inferior): Update comment.
9231         * gdbthread.h (class thread_info): Update comment.
9232
9233 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9234             Tom Tromey  <tom@tromey.com>
9235
9236         * stabsread.h (struct stab_section_list): Remove.
9237         (coffstab_build_psymtabs): Update.
9238         * dbxread.c (symbuf_sections): Now a std::vector.
9239         (sect_idx): New global.
9240         (fill_symbuf): Update.
9241         (coffstab_build_psymtabs): Change type of stabsects parameter.
9242         Update.
9243         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9244         std::vector.
9245         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9246         (coff_locate_sections): Update.
9247         (coff_symfile_read): Remove cleanups.  Update.
9248         (init_stringtab): Add storage parameter.
9249         (free_stringtab, free_stringtab_cleanup): Remove.
9250         (init_lineno): Add storage parameter.
9251         (free_linetab, free_linetab_cleanup): Remove.
9252
9253 2019-03-06  Pedro Alves  <palves@redhat.com>
9254
9255         * linux-fork.c (fork_info::clobber_regs): Delete.
9256         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9257         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9258         comment.  Adjust.
9259         (scoped_switch_fork_info::scoped_switch_fork_info)
9260         (checkpoint_command, linux_fork_context): Adjust
9261         fork_save_infrun_state calls.
9262
9263 2019-03-06  Pedro Alves  <palves@redhat.com>
9264
9265         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9266         (inf_has_multiple_threads): Return 'bool' and rewrite using
9267         inferior_info::threads().
9268
9269 2019-03-06  Pedro Alves  <palves@redhat.com>
9270
9271         * linux-fork.c: Include <list>.
9272         (fork_list): Now a std::list instance.
9273         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9274         (forks_exist_p, find_last_fork): Adjust.
9275         (new_fork): Delete.
9276         (one_fork_p): New.
9277         (add_fork): Adjust.
9278         (free_fork): Delete, folded into fork_info::~fork_info().
9279         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9280         Adjust.
9281         (init_fork_list): Delete.
9282         (linux_fork_killall, linux_fork_mourn_inferior)
9283         (linux_fork_detach, info_checkpoints_command): Adjust.
9284         (_initialize_linux_fork): No longer call init_fork_list.
9285
9286 2019-03-06  Pedro Alves  <palves@redhat.com>
9287
9288         * linux-fork.c (new_fork): New, split out of ...
9289         (add_fork): ... this.  Return void.  Move "first fork" special
9290         case from here, to ...
9291         (checkpoint_command): ... here.
9292         * linux-linux.h (add_fork): Return void.
9293
9294 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9295
9296         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9297
9298 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9299             Chris January  <chris.january@arm.com>
9300             David Lecomber  <david.lecomber@arm.com>
9301
9302         * f-exp.y: New token, UNOP_INTRINSIC.
9303         (exp): New pattern using UNOP_INTRINSIC token.
9304         (f77_keywords): Add 'abs' keyword.
9305         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9306         (value_from_host_double): New function.
9307         (evaluate_subexp_f): Support UNOP_ABS.
9308
9309 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9310
9311         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9312         types.
9313
9314 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9315
9316         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9317         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9318         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9319
9320 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9323
9324 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9325             Chris January  <chris.january@arm.com>
9326
9327         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9328         * f-exp.y: Define 'KIND' token.
9329         (exp): New pattern for KIND expressions.
9330         (ptype): Handle types with a kind extension.
9331         (direct_abs_decl): Extend to spot kind extensions.
9332         (f77_keywords): Add 'kind' to the list.
9333         (push_kind_type): New function.
9334         (convert_to_kind_type): New function.
9335         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9336         * parse.c (operator_length_standard): Likewise.
9337         * parser-defs.h (enum type_pieces): Add tp_kind.
9338         * std-operator.def: Add UNOP_KIND.
9339
9340 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9341
9342         * f-exp.y (f_parse): Set yydebug.
9343
9344 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9345
9346         * f-lang.c (evaluate_subexp_f): New function.
9347         (exp_descriptor_f): New global.
9348         (f_language_defn): Use exp_descriptor_f instead of
9349         exp_descriptor_standard.
9350
9351 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9352
9353         * f-exp.y (struct token): Add comments.
9354         (dot_ops): Remove uppercase versions and the end marker.
9355         (f77_keywords): Likewise.
9356         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9357         entries in the dot_ops array are case insensitive, and use
9358         strncasecmp to compare strings.  Also some whitespace cleanup in
9359         this area.  Similar for the f77_keywords array, except entries in
9360         this list might be case sensitive.
9361
9362 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9363
9364         * f-exp.y (struct f77_boolean_val): Add comments.
9365         (boolean_values): Remove uppercase versions, and end marker.
9366         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9367         and use strncasecmp to achieve case insensitivity.  Additionally,
9368         perform whitespace cleanup around this code.
9369
9370 2019-03-06  Tom Tromey  <tromey@adacore.com>
9371
9372         * remote-sim.c (gdbsim_target_open): Use result of
9373         gdb_argv::release.
9374
9375 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9376         Dirk Schubert  <dirk.schubert@arm.com>
9377         Chris January  <chris.january@arm.com>
9378
9379         * eval.c (evaluate_subexp_standard): Call Fortran argument
9380         wrapping logic.
9381         * f-lang.c (struct value): A value which can be passed into a
9382         Fortran function call.
9383         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9384         where appropriate.
9385         (struct type): Value ready for a Fortran function call.
9386         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9387         is needed.
9388         * f-lang.h (fortran_argument_convert): Declaration.
9389         (fortran_preserve_arg_pointer): Declaration.
9390         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9391
9392 2019-03-05  Tom Tromey  <tromey@adacore.com>
9393
9394         * python/py-prettyprint.c (print_string_repr): Remove #if.
9395         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9396
9397 2019-03-05  Tom Tromey  <tromey@adacore.com>
9398
9399         * target.c (the_dummy_target): Move later.  Change type to
9400         "dummy_target".
9401         (initialize_targets): Don't initialize the_dummy_target.
9402
9403 2019-03-05  Tom Tromey  <tromey@adacore.com>
9404
9405         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9406         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9407
9408 2019-03-05  Tom Tromey  <tromey@adacore.com>
9409
9410         * windows-nat.c (windows_nat_target::attach)
9411         (windows_nat_target::detach): Don't call gdb_flush.
9412         * valprint.c (generic_val_print, val_print, val_print_string):
9413         Don't call gdb_flush.
9414         * utils.c (defaulted_query): Don't call gdb_flush.
9415         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9416         * target.c (target_announce_detach): Don't call gdb_flush.
9417         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9418         * remote.c (extended_remote_target::attach): Don't call
9419         gdb_flush.
9420         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9421         * printcmd.c (do_examine): Don't call gdb_flush.
9422         (info_display_command): Don't call gdb_flush.
9423         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9424         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9425         * memattr.c (info_mem_command): Don't call gdb_flush.
9426         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9427         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9428         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9429         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9430         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9431         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9432         (gnu_nat_target::detach): Don't call gdb_flush.
9433         * f-valprint.c (f_val_print): Don't call gdb_flush.
9434         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9435         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9436         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9437         gdb_flush.
9438         * c-valprint.c (c_val_print): Don't call gdb_flush.
9439         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9440
9441 2019-03-05  Tom Tromey  <tromey@adacore.com>
9442
9443         * varobj.c (update_dynamic_varobj_children): Update.
9444         (install_default_visualizer): Use reset, not release.
9445         * value.c (set_internalvar): Update.
9446         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9447         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9448         ATTRIBUTE_UNUSED_RESULT.
9449
9450 2019-03-05  Tom Tromey  <tromey@adacore.com>
9451
9452         * remote.c (class scoped_remote_fd) <release>: Add
9453         ATTRIBUTE_UNUSED_RESULT.
9454
9455 2019-03-05  Tom Tromey  <tromey@adacore.com>
9456
9457         * macroexp.c (struct macro_buffer) <release>: Add
9458         ATTRIBUTE_UNUSED_RESULT.
9459
9460 2019-03-05  Tom Tromey  <tromey@adacore.com>
9461
9462         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9463         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9464         ATTRIBUTE_UNUSED_RESULT.
9465
9466 2019-03-05  Tom Tromey  <tromey@adacore.com>
9467
9468         * common/scoped_fd.h (class scoped_fd) <release>: Add
9469         ATTRIBUTE_UNUSED_RESULT.
9470
9471 2019-03-05  Tom Tromey  <tromey@adacore.com>
9472
9473         * parser-defs.h (struct parser_state) <release>: Add
9474         ATTRIBUTE_UNUSED_RESULT.
9475
9476 2019-03-05  Tom Tromey  <tromey@adacore.com>
9477
9478         * utils.h (class gdb_argv) <release>: Add
9479         ATTRIBUTE_UNUSED_RESULT.
9480         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9481
9482 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9483
9484         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9485         for-loop range, to avoid compiler warnings.
9486
9487         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9488         avoid compiler warnings about unused variables.
9489
9490         * NEWS: Mention end of support for native debugging on MS-Windows
9491         before XP.
9492
9493         PR gdb/24292
9494         * common/netstuff.c:
9495         * gdbserver/gdbreplay.c
9496         * gdbserver/remote-utils.c:
9497         * ser-tcp.c:
9498         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9499         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9500         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9501         'getaddrinfo' and 'freeaddrinfo' were not available before
9502         Windows XP, and mingw.org's MinGW headers by default define
9503         _WIN32_WINNT to 0x500.
9504
9505 2019-03-01  Gary Benson <gbenson@redhat.com>
9506
9507         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9508
9509 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9510             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9511
9512         PR gdb/8527
9513         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9514         set_sigint_trap, clear_sigint_trap.
9515
9516 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9517
9518         * target.c (target_detach): Clear the regcache and the
9519         frame cache.
9520
9521 2019-02-27  Pedro Alves  <palves@redhat.com>
9522
9523         * utils.c (set_screen_size): When we cap the height/width sizes,
9524         tweak the corresponding command variable to show "unlimited":
9525
9526 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9527             Pedro Alves  <palves@redhat.com>
9528
9529         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9530         before calling rl_set_screen_size.
9531
9532 2019-02-27  Tom Tromey  <tromey@adacore.com>
9533
9534         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9535         define.
9536         * python/py-value.c: Remove Python 2.4 workaround.
9537         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9538         workaround.
9539         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9540         Python 2.4 workaround.
9541         * python/python-internal.h: Remove Python 2.4 comment.
9542         (Py_ssize_t): Don't define.
9543         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9544         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9545         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9546         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9547         * python/python.c (do_start_initialization): Remove Python 2.4
9548         workaround.
9549         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9550         (print_children): Remove Python 2.4 workaround.
9551         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9552         workaround.
9553         (CHARBUFFERPROC_NAME): Remove.
9554         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9555         Python 2.4 workaround.
9556
9557 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9558
9559         * NEWS: Note minimum Python version.
9560
9561 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9562
9563         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9564         code from these functions.  Remove corresponding ifdefs.  Use
9565         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9566         Remove gotos and target of gotos.
9567         (infpy_search_memory): Likewise.
9568
9569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9570
9571         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9572         (hppa_gdbarch_init): Don't register deleted functions with
9573         gdbarch.
9574
9575 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9576
9577         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9578         (h8300_unwind_sp): Delete.
9579         (h8300_dummy_id): Delete.
9580         (h8300_gdbarch_init): Don't register deleted functions with
9581         gdbarch.
9582
9583 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9584
9585         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9586         (ft32_unwind_pc): Delete.
9587         (ft32_unwind_sp): Delete.
9588         (ft32_gdbarch_init): Don't register deleted functions with
9589         gdbarch.
9590
9591 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9592
9593         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9594         (frv_unwind_pc): Delete.
9595         (frv_unwind_sp): Delete.
9596         (frv_gdbarch_init): Don't register deleted functions with
9597         gdbarch.
9598
9599 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9600
9601         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9602         (riscv_unwind_pc): Delete.
9603         (riscv_unwind_sp): Delete.
9604         (riscv_gdbarch_init): Don't register deleted functions with
9605         gdbarch.
9606
9607 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9608
9609         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9610         (csky_unwind_pc): Delete.
9611         (csky_unwind_sp): Delete.
9612         (csky_gdbarch_init): Don't register deleted functions with
9613         gdbarch.
9614
9615 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9616
9617         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9618         (cris_unwind_pc): Delete.
9619         (cris_unwind_sp): Delete.
9620         (cris_gdbarch_init): Don't register deleted functions with
9621         gdbarch.
9622
9623 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9624
9625         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9626         (bfin_unwind_pc): Delete.
9627         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9628
9629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9630
9631         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9632         (arm_unwind_pc): Delete.
9633         (arm_unwind_sp): Delete.
9634         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9635
9636 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9637
9638         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9639         (arc_unwind_pc): Delete.
9640         (arc_unwind_sp): Delete.
9641         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9642
9643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9644
9645         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9646         (alpha_unwind_pc): Delete.
9647         (alpha_gdbarch_init): Don't register deleted functions with
9648         gdbarch.
9649
9650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9651
9652         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9653         (aarch64_unwind_pc): Delete.
9654         (aarch64_unwind_sp): Delete.
9655         (aarch64_gdbarch_init): Don't register deleted functions with
9656         gdbarch.
9657
9658 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9659
9660         * gdbtypes.c (type_align): Don't consider static members when
9661         computing structure alignment.
9662
9663 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9664
9665         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9666         return 0 for other types.
9667         * arch-utils.c (default_type_align): Always return 0.
9668         * gdbarch.h: Regenerate.
9669         * gdbarch.sh (type_align): Extend comment.
9670         * gdbtypes.c (type_align): Add additional comments, always call
9671         gdbarch_type_align before applying the default rules.
9672         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9673         generic code will then apply a suitable default.
9674         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9675         types, return 0 for other types.
9676
9677 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9678
9679         * NEWS: Create a new section for the next release branch.
9680         Rename the section of the current branch, now that it has
9681         been cut.
9682
9683 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9684
9685         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9686         * version.in: Bump version to 8.3.50.DATE-git.
9687
9688 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9689
9690         * aix-thread.c (ptid_cmp): Remove unused variable.
9691         (get_signaled_thread): Likewise.
9692         (store_regs_user_thread): Likewise.
9693         (store_regs_kernel_thread): Likewise.
9694         (fetch_regs_kernel_thread): Remove shadowed variable.
9695
9696 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9697
9698         * features/riscv/32bit-cpu.xml: Add register numbers.
9699         * features/riscv/32bit-fpu.c: Regenerate.
9700         * features/riscv/32bit-fpu.xml: Add register numbers.
9701         * features/riscv/64bit-cpu.xml: Add register numbers.
9702         * features/riscv/64bit-fpu.c: Regenerate.
9703         * features/riscv/64bit-fpu.xml: Add register numbers.
9704
9705 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9706
9707         * NEWS: Mention two argument form of gdb.Value constructor.
9708         * python/py-value.c (convert_buffer_and_type_to_value): New
9709         function.
9710         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9711         Add support for handling an optional second argument.  Call
9712         convert_buffer_and_type_to_value as appropriate.
9713         * python/python-internal.h (Py_buffer_deleter): New struct.
9714         (Py_buffer_up): New typedef.
9715
9716 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9717
9718         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9719         instead of releasing ownership.
9720
9721 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9722
9723         * dwarf2read.c (open_and_init_dwp_file): Call
9724         elf_numsections instead of bfd_count_sections to initialize
9725         dwp_file->num_sections.
9726
9727 2019-02-25  Tom Tromey  <tromey@adacore.com>
9728
9729         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9730
9731 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9732
9733         * gcore.in: Add '--readnever' option when invoking GDB.
9734
9735 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9736
9737         * MAINTAINERS: Update my email address.
9738
9739 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9740
9741         * build-id.c (build_id_to_debug_bfd_1): New function.
9742         (build_id_to_debug_bfd): Look for separate debug file in
9743         sysroot.
9744
9745 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9746
9747         * gdbarch.sh: Update the copyright year range that is placed into
9748         generated files.
9749
9750 2019-02-22  Keith Seitz  <keiths@redhat.com>
9751
9752         PR symtab/23853
9753         * linespec.c (create_sals_line_offset): Search for the default
9754         symtab's filename instead of its fullname.
9755
9756 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9757
9758         * NEWS: Update style defaults.
9759
9760 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9761
9762         * main.c (captured_main_1): Disable styling in batch mode.
9763
9764 2019-02-20  Tom Tromey  <tom@tromey.com>
9765
9766         * symtab.c (symtab_symbol_info): Fix typos.
9767
9768 2019-02-20  Tom Tromey  <tromey@adacore.com>
9769
9770         * findcmd.c (_initialize_mem_search): Use upper case for
9771         metasyntactic variables.
9772
9773 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9774
9775         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9776         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9777
9778 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9779
9780         * top.h (source_file_name): Change to std::string.
9781         * top.c (source_file_name): Likewise.
9782         (command_line_input): Adjust.
9783         * cli/cli-script.c (script_from_file): Adjust.
9784
9785 2019-02-19  Tom Tromey  <tromey@adacore.com>
9786
9787         * ravenscar-thread.c
9788         (ravenscar_thread_target::update_thread_list): Don't call
9789         ada_build_task_list.
9790         * ada-lang.h (ada_build_task_list): Don't declare.
9791         * ada-tasks.c (struct ada_tasks_inferior_data)
9792         <task_list_valid_p>: Now bool.
9793         (read_known_tasks, ada_task_list_changed)
9794         (ada_tasks_invalidate_inferior_data): Update.
9795         (read_known_tasks_array): Return bool.
9796         (read_known_tasks_list): Likewise.
9797         (read_known_tasks): Return void.
9798         (ada_build_task_list): Now static.
9799
9800 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9801
9802         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9803         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9804
9805 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9806
9807         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9808         variant for ada_tasks_pspace_data_handle and
9809         ada_tasks_inferior_data_handle.
9810         (ada_tasks_pspace_data_cleanup): New function.
9811         (ada_tasks_inferior_data_cleanup): New function.
9812
9813 2019-02-17  Tom Tromey  <tom@tromey.com>
9814
9815         * macrotab.h (macro_source_fullname): Return a std::string.
9816         * macrotab.c (macro_include, check_for_redefinition)
9817         (macro_undef, macro_lookup_definition, foreach_macro)
9818         (foreach_macro_in_scope): Update.
9819         (macro_source_fullname): Return a std::string.
9820         * macrocmd.c (show_pp_source_pos): Update.
9821
9822 2019-02-17  Tom Tromey  <tom@tromey.com>
9823
9824         * macrocmd.c (show_pp_source_pos): Style the file names.
9825
9826 2019-02-17  Tom Tromey  <tom@tromey.com>
9827
9828         PR tui/24197:
9829         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9830
9831 2019-02-17  Tom Tromey  <tom@tromey.com>
9832
9833         * ada-lang.c (user_select_syms): Use filtered printing.
9834         * utils.c (wrap_style): New global.
9835         (desired_style): Remove.
9836         (emit_style_escape): Add stream parameter.
9837         (set_output_style, reset_terminal_style, prompt_for_continue):
9838         Update.
9839         (flush_wrap_buffer): Only flush gdb_stdout.
9840         (wrap_here): Set wrap_style.
9841         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9842         treat escape sequences as a character.  Change when wrap buffer is
9843         flushed.
9844         (fputs_styled): Do not set the output style when the default is
9845         requested.
9846         * ui-style.h (struct ui_file_style) <is_default>: New method.
9847         * source.c (print_source_lines_base): Emit escape sequences in one
9848         piece.
9849
9850 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9851
9852         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9853         integers and enumeration types.
9854
9855 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9856
9857         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9858         instead of lookup_symbol_in_language
9859         (do_exact_match): New function.
9860         (ada_get_symbol_name_matcher): Return do_exact_match when
9861         doing a verbatim match.
9862
9863 2019-02-15  Tom Tromey  <tromey@adacore.com>
9864
9865         * ravenscar-thread.c (ravenscar_thread_target::resume)
9866         (ravenscar_thread_target::wait): Special case wildcard requests.
9867
9868 2019-02-15  Tom Tromey  <tromey@adacore.com>
9869
9870         * ravenscar-thread.c (base_ptid): Remove.
9871         (struct ravenscar_thread_target) <close>: New method.
9872         <m_base_ptid>: New member.
9873         <update_inferior_ptid, active_task, task_is_currently_active,
9874         runtime_initialized>: Declare methods.
9875         <ravenscar_thread_target>: Add constructor.
9876         (ravenscar_thread_target::task_is_currently_active)
9877         (ravenscar_thread_target::update_inferior_ptid)
9878         (ravenscar_runtime_initialized): Rename.  Now methods.
9879         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9880         (ravenscar_thread_target::update_thread_list): Update.
9881         (ravenscar_thread_target::active_task): Now method.
9882         (ravenscar_thread_target::store_registers)
9883         (ravenscar_thread_target::prepare_to_store)
9884         (ravenscar_thread_target::prepare_to_store)
9885         (ravenscar_thread_target::mourn_inferior): Update.
9886         (ravenscar_inferior_created): Use "new" to create target.
9887         (ravenscar_thread_target::get_ada_task_ptid): Update.
9888         (_initialize_ravenscar): Don't initialize base_ptid.
9889         (ravenscar_ops): Remove global.
9890
9891 2019-02-15  Tom Tromey  <tromey@adacore.com>
9892
9893         * target.h (push_target): Declare new overload.
9894         * target.c (push_target): New overload, taking an rvalue reference.
9895         * remote.c (remote_target::open_1): Use push_target overload.
9896         * corelow.c (core_target_open): Use push_target overload.
9897
9898 2019-02-15  Tom Tromey  <tromey@adacore.com>
9899
9900         * ravenscar-thread.c (is_ravenscar_task)
9901         (ravenscar_task_is_currently_active): Return bool.
9902         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9903         (_initialize_ravenscar): Remove "(void)".
9904         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9905         Return bool.
9906
9907 2019-02-15  Tom Tromey  <tromey@adacore.com>
9908
9909         * ravenscar-thread.c (ravenscar_runtime_initializer)
9910         (has_ravenscar_runtime, get_running_thread_id)
9911         (ravenscar_thread_target::resume): Fix indentation.
9912
9913 2019-02-15  Tom Tromey  <tromey@adacore.com>
9914
9915         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9916         from ravenscar_arch_ops.
9917         (sparc_ravenscar_ops::fetch_registers)
9918         (sparc_ravenscar_ops::store_registers): Now methods.
9919         (sparc_ravenscar_prepare_to_store): Remove.
9920         (sparc_ravenscar_ops): Redefine.
9921         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9922         methods and destructor.  Remove members.
9923         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9924         (ravenscar_thread_target::store_registers)
9925         (ravenscar_thread_target::prepare_to_store): Update.
9926         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9927         Remove.
9928         (struct ppc_ravenscar_powerpc_ops): Derive from
9929         ravenscar_arch_ops.
9930         (ppc_ravenscar_powerpc_ops::fetch_registers)
9931         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9932         (ppc_ravenscar_powerpc_ops): Redefine.
9933         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9934         (ppc_ravenscar_e500_ops::fetch_registers)
9935         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9936         (ppc_ravenscar_e500_ops): Redefine.
9937         * aarch64-ravenscar-thread.c
9938         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9939         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9940         (aarch64_ravenscar_fetch_registers)
9941         (aarch64_ravenscar_store_registers): Now methods.
9942         (aarch64_ravenscar_ops): Redefine.
9943
9944 2019-02-15  Tom Tromey  <tromey@adacore.com>
9945
9946         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9947         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9948         (ravenscar_thread_target::stopped_by_watchpoint)
9949         (ravenscar_thread_target::stopped_data_address)
9950         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9951
9952 2019-02-15  Tom Tromey  <tromey@adacore.com>
9953
9954         * ravenscar-thread.c: Fix some typos.
9955
9956 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9957             Tom Tromey  <tromey@adacore.com>
9958
9959         * ada-lang.c (ada_exception_sal): Change addr_string to a
9960         std::string.
9961         (create_ada_exception_catchpoint): Update.
9962
9963 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9964             Tom Tromey  <tromey@adacore.com>
9965
9966         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9967         (bp_location_ops): Remove.
9968         (base_breakpoint_allocate_location): Update.
9969         (free_bp_location): Update.
9970         * ada-lang.c (class ada_catchpoint_location)
9971         <ada_catchpoint_location>: Remove ops parameter.
9972         (ada_catchpoint_location_dtor): Remove.
9973         (ada_catchpoint_location_ops): Remove.
9974         (allocate_location_exception): Update.
9975         * breakpoint.h (struct bp_location_ops): Remove.
9976         (class bp_location) <bp_location>: Remove bp_location_ops
9977         parameter.
9978         <~bp_location>: Add destructor.
9979         <ops>: Remove.
9980
9981 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9982             Pedro Alves  <palves@redhat.com>
9983
9984         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9985         'PATH_MAX'.
9986
9987 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9988             Samuel Thibault  <samuel.thibault@gnu.org>
9989             Thomas Schwinge  <thomas@codesourcery.com>
9990
9991         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9992         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9993
9994 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9995
9996         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9997         (check_empty): Use "const char *".
9998
9999         * gnu-nat.c (gnu_nat_target::detach): Instead of
10000         'detach_inferior (pid)' call
10001         'detach_inferior (find_inferior_pid (pid))'.
10002
10003         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10004         'nat/fork-inferior.o'.
10005         * gnu-nat.c: #include "nat/fork-inferior.h".
10006
10007         * gnu-nat.c (gnu_nat_target::detach): Instead of
10008         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10009         * gnu-nat.h: #include "inf-child.h".
10010         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10011         'i386_gnu_nat_target::fetch_registers'.
10012         (gnu_store_registers): Rename/move to
10013         'i386_gnu_nat_target::store_registers'.
10014
10015         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10016         * gnu-nat.h (mach_thread_info): New function.
10017         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10018
10019         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10020
10021 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10022
10023         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10024
10025 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10026
10027         * windows-nat.c (windows_add_thread): Add new parameter
10028         "main_thread_p" with default value set to false.  Update
10029         function documentation as well as all callers.
10030         (windows_delete_thread): Likewise.
10031         (fake_create_process): Update call to windows_add_thread.
10032         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10033         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10034         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10035         call to windows_delete_thread.
10036
10037 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10038
10039         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10040
10041 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10042
10043         * symfile.c (find_separate_debug_file): Use canonical path of
10044         sysroot with child_path instead of gdb_sysroot if it is valid.
10045
10046 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10047
10048         * symfile.c (find_separate_debug_file): Use child_path to
10049         determine if an object file is under a sysroot.
10050
10051 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10052
10053         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10054         unittests/child-path-selftests.c.
10055         * common/pathstuff.c (child_path): New function.
10056         * common/pathstuff.h (child_path): New prototype.
10057         * unittests/child-path-selftests.c: New file.
10058
10059 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10060
10061         * symfile.c (find_separate_debug_file): Look for separate debug
10062         files in debug directories under the sysroot.
10063
10064 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10065
10066         * symtab.h (struct minimal_symbol data_p): New const method.
10067         (struct minimal_symbol text_p): Likewise.
10068         * symtab.c (output_source_filename): Use file name style
10069         to print file name.
10070         (print_symbol_info): Likewise.
10071         (print_msymbol_info): Use address style to print addresses.
10072         Use function name style to print executable text symbols.
10073         (expand_symtab_containing_pc): Use data_p.
10074         (find_pc_sect_compunit_symtab): Likewise.
10075
10076 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10077
10078         * breakpoint.c (describe_other_breakpoints): Use address style
10079         to print addresses.
10080         (say_where): Likewise.
10081
10082 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10083
10084         * ada-typeprint.c (print_func_type): Print function name
10085         style to print function name.
10086         * c-typeprint.c (c_print_type_1): Likewise.
10087
10088 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10089
10090         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10091         for execve.
10092
10093 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10094
10095         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10096         type_stack.
10097
10098 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10099
10100         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10101         TYPE_CODE_REF types.
10102
10103 2019-02-08  Jim Wilson  <jimw@sifive.com>
10104
10105         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10106         (riscv_linux_fregset): New.
10107         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10108
10109 2019-02-07  Tom Tromey  <tom@tromey.com>
10110
10111         * thread.c (thread_cancel_execution_command): Update.
10112         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10113         methods.
10114         (struct thread_fsm_ops): Remove.
10115         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10116         (thread_fsm_should_stop, thread_fsm_return_value)
10117         (thread_fsm_set_finished, thread_fsm_finished_p)
10118         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10119         Don't declare.
10120         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10121         * infrun.c (clear_proceed_status_thread)
10122         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10123         (print_stop_event): Update.
10124         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10125         Add constructor.
10126         (step_command_fsm_ops): Remove.
10127         (new_step_command_fsm): Remove.
10128         (step_1): Update.
10129         (step_command_fsm::should_stop): Rename from
10130         step_command_fsm_should_stop.
10131         (step_command_fsm::clean_up): Rename from
10132         step_command_fsm_clean_up.
10133         (step_command_fsm::do_async_reply_reason): Rename from
10134         step_command_fsm_async_reply_reason.
10135         (struct until_next_fsm): Inherit from thread_fsm.  Add
10136         constructor.
10137         (until_next_fsm_ops): Remove.
10138         (new_until_next_fsm): Remove.
10139         (until_next_fsm::should_stop): Rename from
10140         until_next_fsm_should_stop.
10141         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10142         (until_next_fsm::do_async_reply_reason): Rename from
10143         until_next_fsm_async_reply_reason.
10144         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10145         constructor.  Change type of breakpoint.
10146         (finish_command_fsm_ops): Remove.
10147         (new_finish_command_fsm): Remove.
10148         (finish_command_fsm::should_stop): Rename from
10149         finish_command_fsm_should_stop.
10150         (finish_command_fsm::clean_up): Rename from
10151         finish_command_fsm_clean_up.
10152         (finish_command_fsm::return_value): Rename from
10153         finish_command_fsm_return_value.
10154         (finish_command_fsm::do_async_reply_reason): Rename from
10155         finish_command_fsm_async_reply_reason.
10156         (finish_command): Update.
10157         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10158         Add constructor.
10159         (call_thread_fsm_ops): Remove.
10160         (call_thread_fsm::call_thread_fsm): Rename from
10161         new_call_thread_fsm.
10162         (call_thread_fsm::should_stop): Rename from
10163         call_thread_fsm_should_stop.
10164         (call_thread_fsm::should_notify_stop): Rename from
10165         call_thread_fsm_should_notify_stop.
10166         (run_inferior_call, call_function_by_hand_dummy): Update.
10167         * cli/cli-interp.c (should_print_stop_to_console): Update.
10168         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10169         Add constructor.  Change type of location_breakpoint,
10170         caller_breakpoint.
10171         (until_break_fsm_ops): Remove.
10172         (new_until_break_fsm): Remove.
10173         (until_break_fsm::should_stop): Rename from
10174         until_break_fsm_should_stop.
10175         (until_break_fsm::clean_up): Rename from
10176         until_break_fsm_clean_up.
10177         (until_break_fsm::do_async_reply_reason): Rename from
10178         until_break_fsm_async_reply_reason.
10179         (until_break_command): Update.
10180         * thread-fsm.c: Remove.
10181         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10182
10183 2019-02-07  Tom Tromey  <tom@tromey.com>
10184
10185         * yy-remap.h: Add include guard.
10186         * xtensa-tdep.h: Add include guard.
10187         * xcoffread.h: Rename include guard.
10188         * varobj-iter.h: Add include guard.
10189         * tui/tui.h: Rename include guard.
10190         * tui/tui-winsource.h: Rename include guard.
10191         * tui/tui-wingeneral.h: Rename include guard.
10192         * tui/tui-windata.h: Rename include guard.
10193         * tui/tui-win.h: Rename include guard.
10194         * tui/tui-stack.h: Rename include guard.
10195         * tui/tui-source.h: Rename include guard.
10196         * tui/tui-regs.h: Rename include guard.
10197         * tui/tui-out.h: Rename include guard.
10198         * tui/tui-layout.h: Rename include guard.
10199         * tui/tui-io.h: Rename include guard.
10200         * tui/tui-hooks.h: Rename include guard.
10201         * tui/tui-file.h: Rename include guard.
10202         * tui/tui-disasm.h: Rename include guard.
10203         * tui/tui-data.h: Rename include guard.
10204         * tui/tui-command.h: Rename include guard.
10205         * tic6x-tdep.h: Add include guard.
10206         * target/waitstatus.h: Rename include guard.
10207         * target/wait.h: Rename include guard.
10208         * target/target.h: Rename include guard.
10209         * target/resume.h: Rename include guard.
10210         * target-float.h: Rename include guard.
10211         * stabsread.h: Add include guard.
10212         * rs6000-tdep.h: Add include guard.
10213         * riscv-fbsd-tdep.h: Add include guard.
10214         * regformats/regdef.h: Rename include guard.
10215         * record.h: Rename include guard.
10216         * python/python.h: Rename include guard.
10217         * python/python-internal.h: Rename include guard.
10218         * python/py-stopevent.h: Rename include guard.
10219         * python/py-ref.h: Rename include guard.
10220         * python/py-record.h: Rename include guard.
10221         * python/py-record-full.h: Rename include guard.
10222         * python/py-record-btrace.h: Rename include guard.
10223         * python/py-instruction.h: Rename include guard.
10224         * python/py-events.h: Rename include guard.
10225         * python/py-event.h: Rename include guard.
10226         * procfs.h: Add include guard.
10227         * proc-utils.h: Add include guard.
10228         * p-lang.h: Add include guard.
10229         * or1k-tdep.h: Rename include guard.
10230         * observable.h: Rename include guard.
10231         * nto-tdep.h: Rename include guard.
10232         * nat/x86-linux.h: Rename include guard.
10233         * nat/x86-linux-dregs.h: Rename include guard.
10234         * nat/x86-gcc-cpuid.h: Add include guard.
10235         * nat/x86-dregs.h: Rename include guard.
10236         * nat/x86-cpuid.h: Rename include guard.
10237         * nat/ppc-linux.h: Rename include guard.
10238         * nat/mips-linux-watch.h: Rename include guard.
10239         * nat/linux-waitpid.h: Rename include guard.
10240         * nat/linux-ptrace.h: Rename include guard.
10241         * nat/linux-procfs.h: Rename include guard.
10242         * nat/linux-osdata.h: Rename include guard.
10243         * nat/linux-nat.h: Rename include guard.
10244         * nat/linux-namespaces.h: Rename include guard.
10245         * nat/linux-btrace.h: Rename include guard.
10246         * nat/glibc_thread_db.h: Rename include guard.
10247         * nat/gdb_thread_db.h: Rename include guard.
10248         * nat/gdb_ptrace.h: Rename include guard.
10249         * nat/fork-inferior.h: Rename include guard.
10250         * nat/amd64-linux-siginfo.h: Rename include guard.
10251         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10252         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10253         * nat/aarch64-linux.h: Rename include guard.
10254         * nat/aarch64-linux-hw-point.h: Rename include guard.
10255         * mn10300-tdep.h: Add include guard.
10256         * mips-linux-tdep.h: Add include guard.
10257         * mi/mi-parse.h: Rename include guard.
10258         * mi/mi-out.h: Rename include guard.
10259         * mi/mi-main.h: Rename include guard.
10260         * mi/mi-interp.h: Rename include guard.
10261         * mi/mi-getopt.h: Rename include guard.
10262         * mi/mi-console.h: Rename include guard.
10263         * mi/mi-common.h: Rename include guard.
10264         * mi/mi-cmds.h: Rename include guard.
10265         * mi/mi-cmd-break.h: Rename include guard.
10266         * m2-lang.h: Add include guard.
10267         * location.h: Rename include guard.
10268         * linux-record.h: Rename include guard.
10269         * linux-nat.h: Add include guard.
10270         * linux-fork.h: Add include guard.
10271         * i386-darwin-tdep.h: Rename include guard.
10272         * hppa-linux-offsets.h: Add include guard.
10273         * guile/guile.h: Rename include guard.
10274         * guile/guile-internal.h: Rename include guard.
10275         * gnu-nat.h: Rename include guard.
10276         * gdb-stabs.h: Rename include guard.
10277         * frv-tdep.h: Add include guard.
10278         * f-lang.h: Add include guard.
10279         * event-loop.h: Add include guard.
10280         * darwin-nat.h: Rename include guard.
10281         * cp-abi.h: Rename include guard.
10282         * config/sparc/nm-sol2.h: Rename include guard.
10283         * config/nm-nto.h: Rename include guard.
10284         * config/nm-linux.h: Add include guard.
10285         * config/i386/nm-i386gnu.h: Rename include guard.
10286         * config/djgpp/nl_types.h: Rename include guard.
10287         * config/djgpp/langinfo.h: Rename include guard.
10288         * compile/gcc-cp-plugin.h: Add include guard.
10289         * compile/gcc-c-plugin.h: Add include guard.
10290         * compile/compile.h: Rename include guard.
10291         * compile/compile-object-run.h: Rename include guard.
10292         * compile/compile-object-load.h: Rename include guard.
10293         * compile/compile-internal.h: Rename include guard.
10294         * compile/compile-cplus.h: Rename include guard.
10295         * compile/compile-c.h: Rename include guard.
10296         * common/xml-utils.h: Rename include guard.
10297         * common/x86-xstate.h: Rename include guard.
10298         * common/version.h: Rename include guard.
10299         * common/vec.h: Rename include guard.
10300         * common/tdesc.h: Rename include guard.
10301         * common/selftest.h: Rename include guard.
10302         * common/scoped_restore.h: Rename include guard.
10303         * common/scoped_mmap.h: Rename include guard.
10304         * common/scoped_fd.h: Rename include guard.
10305         * common/safe-iterator.h: Rename include guard.
10306         * common/run-time-clock.h: Rename include guard.
10307         * common/refcounted-object.h: Rename include guard.
10308         * common/queue.h: Rename include guard.
10309         * common/ptid.h: Rename include guard.
10310         * common/print-utils.h: Rename include guard.
10311         * common/preprocessor.h: Rename include guard.
10312         * common/pathstuff.h: Rename include guard.
10313         * common/observable.h: Rename include guard.
10314         * common/netstuff.h: Rename include guard.
10315         * common/job-control.h: Rename include guard.
10316         * common/host-defs.h: Rename include guard.
10317         * common/gdb_wait.h: Rename include guard.
10318         * common/gdb_vecs.h: Rename include guard.
10319         * common/gdb_unlinker.h: Rename include guard.
10320         * common/gdb_unique_ptr.h: Rename include guard.
10321         * common/gdb_tilde_expand.h: Rename include guard.
10322         * common/gdb_sys_time.h: Rename include guard.
10323         * common/gdb_string_view.h: Rename include guard.
10324         * common/gdb_splay_tree.h: Rename include guard.
10325         * common/gdb_setjmp.h: Rename include guard.
10326         * common/gdb_ref_ptr.h: Rename include guard.
10327         * common/gdb_optional.h: Rename include guard.
10328         * common/gdb_locale.h: Rename include guard.
10329         * common/gdb_assert.h: Rename include guard.
10330         * common/filtered-iterator.h: Rename include guard.
10331         * common/filestuff.h: Rename include guard.
10332         * common/fileio.h: Rename include guard.
10333         * common/environ.h: Rename include guard.
10334         * common/common-utils.h: Rename include guard.
10335         * common/common-types.h: Rename include guard.
10336         * common/common-regcache.h: Rename include guard.
10337         * common/common-inferior.h: Rename include guard.
10338         * common/common-gdbthread.h: Rename include guard.
10339         * common/common-exceptions.h: Rename include guard.
10340         * common/common-defs.h: Rename include guard.
10341         * common/common-debug.h: Rename include guard.
10342         * common/cleanups.h: Rename include guard.
10343         * common/buffer.h: Rename include guard.
10344         * common/btrace-common.h: Rename include guard.
10345         * common/break-common.h: Rename include guard.
10346         * cli/cli-utils.h: Rename include guard.
10347         * cli/cli-style.h: Rename include guard.
10348         * cli/cli-setshow.h: Rename include guard.
10349         * cli/cli-script.h: Rename include guard.
10350         * cli/cli-interp.h: Rename include guard.
10351         * cli/cli-decode.h: Rename include guard.
10352         * cli/cli-cmds.h: Rename include guard.
10353         * charset-list.h: Add include guard.
10354         * buildsym-legacy.h: Rename include guard.
10355         * bfin-tdep.h: Add include guard.
10356         * ax.h: Rename include guard.
10357         * arm-linux-tdep.h: Add include guard.
10358         * arm-fbsd-tdep.h: Add include guard.
10359         * arch/xtensa.h: Rename include guard.
10360         * arch/tic6x.h: Add include guard.
10361         * arch/i386.h: Add include guard.
10362         * arch/arm.h: Rename include guard.
10363         * arch/arm-linux.h: Rename include guard.
10364         * arch/arm-get-next-pcs.h: Rename include guard.
10365         * arch/amd64.h: Add include guard.
10366         * arch/aarch64-insn.h: Rename include guard.
10367         * arch-utils.h: Rename include guard.
10368         * annotate.h: Add include guard.
10369         * amd64-darwin-tdep.h: Rename include guard.
10370         * aarch64-linux-tdep.h: Add include guard.
10371         * aarch64-fbsd-tdep.h: Add include guard.
10372         * aarch32-linux-nat.h: Add include guard.
10373
10374 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10375
10376         * macrotab.c (macro_define_internal): New function that
10377         factorizes macro_define_object_internal and macro_define_function
10378         code.
10379         (macro_define_object_internal): Use macro_define_internal.
10380         (macro_define_function): Likewise.
10381
10382 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10383
10384         * macrocmd.c (extract_identifier): Return
10385         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10386         callers.
10387
10388 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10389
10390         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10391
10392 2019-02-05  Tom Tromey  <tom@tromey.com>
10393
10394         * target.c (target_stack::unpush): Move assertion earlier.
10395
10396 2019-01-30  Tom Tromey  <tom@tromey.com>
10397
10398         PR python/23615:
10399         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10400         (gdbpy_parse_and_eval): Likewise.
10401         * python/python-internal.h (gdbpy_allow_threads): New class.
10402
10403 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10404
10405         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10406         (aarch64_fbsd_fpregmap): Move earlier.
10407         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10408         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10409         instead of individual calls to trad_frame_set_reg_addr.
10410         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10411         earlier.
10412         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10413         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10414         instead of individual calls to trad_frame_set_reg_addr.
10415
10416 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10417
10418         * CONTRIBUTE: Replace contribution list with wiki link.
10419
10420 2019-01-25  Tom Tromey  <tom@tromey.com>
10421
10422         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10423
10424 2019-01-25  Tom Tromey  <tom@tromey.com>
10425
10426         * xtensa-linux-nat.c: Fix common/ includes.
10427         * xml-support.h: Fix common/ includes.
10428         * xml-support.c: Fix common/ includes.
10429         * x86-linux-nat.c: Fix common/ includes.
10430         * windows-nat.c: Fix common/ includes.
10431         * varobj.h: Fix common/ includes.
10432         * varobj.c: Fix common/ includes.
10433         * value.c: Fix common/ includes.
10434         * valops.c: Fix common/ includes.
10435         * utils.c: Fix common/ includes.
10436         * unittests/xml-utils-selftests.c: Fix common/ includes.
10437         * unittests/utils-selftests.c: Fix common/ includes.
10438         * unittests/unpack-selftests.c: Fix common/ includes.
10439         * unittests/tracepoint-selftests.c: Fix common/ includes.
10440         * unittests/style-selftests.c: Fix common/ includes.
10441         * unittests/string_view-selftests.c: Fix common/ includes.
10442         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10443         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10444         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10445         * unittests/rsp-low-selftests.c: Fix common/ includes.
10446         * unittests/parse-connection-spec-selftests.c: Fix common/
10447         includes.
10448         * unittests/optional-selftests.c: Fix common/ includes.
10449         * unittests/offset-type-selftests.c: Fix common/ includes.
10450         * unittests/observable-selftests.c: Fix common/ includes.
10451         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10452         * unittests/memrange-selftests.c: Fix common/ includes.
10453         * unittests/memory-map-selftests.c: Fix common/ includes.
10454         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10455         * unittests/function-view-selftests.c: Fix common/ includes.
10456         * unittests/environ-selftests.c: Fix common/ includes.
10457         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10458         * unittests/common-utils-selftests.c: Fix common/ includes.
10459         * unittests/cli-utils-selftests.c: Fix common/ includes.
10460         * unittests/array-view-selftests.c: Fix common/ includes.
10461         * ui-file.c: Fix common/ includes.
10462         * tui/tui-io.c: Fix common/ includes.
10463         * tracepoint.h: Fix common/ includes.
10464         * tracepoint.c: Fix common/ includes.
10465         * tracefile-tfile.c: Fix common/ includes.
10466         * top.h: Fix common/ includes.
10467         * top.c: Fix common/ includes.
10468         * thread.c: Fix common/ includes.
10469         * target/waitstatus.h: Fix common/ includes.
10470         * target/waitstatus.c: Fix common/ includes.
10471         * target.h: Fix common/ includes.
10472         * target.c: Fix common/ includes.
10473         * target-memory.c: Fix common/ includes.
10474         * target-descriptions.c: Fix common/ includes.
10475         * symtab.h: Fix common/ includes.
10476         * symfile.c: Fix common/ includes.
10477         * stap-probe.c: Fix common/ includes.
10478         * spu-linux-nat.c: Fix common/ includes.
10479         * sparc-nat.c: Fix common/ includes.
10480         * source.c: Fix common/ includes.
10481         * solib.c: Fix common/ includes.
10482         * solib-target.c: Fix common/ includes.
10483         * ser-unix.c: Fix common/ includes.
10484         * ser-tcp.c: Fix common/ includes.
10485         * ser-pipe.c: Fix common/ includes.
10486         * ser-base.c: Fix common/ includes.
10487         * selftest-arch.c: Fix common/ includes.
10488         * s12z-tdep.c: Fix common/ includes.
10489         * rust-exp.y: Fix common/ includes.
10490         * rs6000-aix-tdep.c: Fix common/ includes.
10491         * riscv-tdep.c: Fix common/ includes.
10492         * remote.c: Fix common/ includes.
10493         * remote-notif.h: Fix common/ includes.
10494         * remote-fileio.h: Fix common/ includes.
10495         * remote-fileio.c: Fix common/ includes.
10496         * regcache.h: Fix common/ includes.
10497         * regcache.c: Fix common/ includes.
10498         * record-btrace.c: Fix common/ includes.
10499         * python/python.c: Fix common/ includes.
10500         * python/py-type.c: Fix common/ includes.
10501         * python/py-inferior.c: Fix common/ includes.
10502         * progspace.h: Fix common/ includes.
10503         * producer.c: Fix common/ includes.
10504         * procfs.c: Fix common/ includes.
10505         * proc-api.c: Fix common/ includes.
10506         * printcmd.c: Fix common/ includes.
10507         * ppc-linux-nat.c: Fix common/ includes.
10508         * parser-defs.h: Fix common/ includes.
10509         * osdata.c: Fix common/ includes.
10510         * obsd-nat.c: Fix common/ includes.
10511         * nat/x86-linux.c: Fix common/ includes.
10512         * nat/x86-linux-dregs.c: Fix common/ includes.
10513         * nat/x86-dregs.h: Fix common/ includes.
10514         * nat/x86-dregs.c: Fix common/ includes.
10515         * nat/ppc-linux.c: Fix common/ includes.
10516         * nat/mips-linux-watch.h: Fix common/ includes.
10517         * nat/mips-linux-watch.c: Fix common/ includes.
10518         * nat/linux-waitpid.c: Fix common/ includes.
10519         * nat/linux-ptrace.h: Fix common/ includes.
10520         * nat/linux-ptrace.c: Fix common/ includes.
10521         * nat/linux-procfs.c: Fix common/ includes.
10522         * nat/linux-personality.c: Fix common/ includes.
10523         * nat/linux-osdata.c: Fix common/ includes.
10524         * nat/linux-namespaces.c: Fix common/ includes.
10525         * nat/linux-btrace.h: Fix common/ includes.
10526         * nat/linux-btrace.c: Fix common/ includes.
10527         * nat/fork-inferior.c: Fix common/ includes.
10528         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10529         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10530         * nat/aarch64-linux.c: Fix common/ includes.
10531         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10532         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10533         * namespace.h: Fix common/ includes.
10534         * mips-linux-tdep.c: Fix common/ includes.
10535         * minsyms.c: Fix common/ includes.
10536         * mi/mi-parse.h: Fix common/ includes.
10537         * mi/mi-main.c: Fix common/ includes.
10538         * mi/mi-cmd-env.c: Fix common/ includes.
10539         * memrange.h: Fix common/ includes.
10540         * memattr.c: Fix common/ includes.
10541         * maint.h: Fix common/ includes.
10542         * maint.c: Fix common/ includes.
10543         * main.c: Fix common/ includes.
10544         * machoread.c: Fix common/ includes.
10545         * location.c: Fix common/ includes.
10546         * linux-thread-db.c: Fix common/ includes.
10547         * linux-nat.c: Fix common/ includes.
10548         * linux-fork.c: Fix common/ includes.
10549         * inline-frame.c: Fix common/ includes.
10550         * infrun.c: Fix common/ includes.
10551         * inflow.c: Fix common/ includes.
10552         * inferior.h: Fix common/ includes.
10553         * inferior.c: Fix common/ includes.
10554         * infcmd.c: Fix common/ includes.
10555         * inf-ptrace.c: Fix common/ includes.
10556         * inf-child.c: Fix common/ includes.
10557         * ia64-linux-nat.c: Fix common/ includes.
10558         * i387-tdep.c: Fix common/ includes.
10559         * i386-tdep.c: Fix common/ includes.
10560         * i386-linux-tdep.c: Fix common/ includes.
10561         * i386-linux-nat.c: Fix common/ includes.
10562         * i386-go32-tdep.c: Fix common/ includes.
10563         * i386-fbsd-tdep.c: Fix common/ includes.
10564         * i386-fbsd-nat.c: Fix common/ includes.
10565         * guile/scm-type.c: Fix common/ includes.
10566         * guile/guile.c: Fix common/ includes.
10567         * go32-nat.c: Fix common/ includes.
10568         * gnu-nat.c: Fix common/ includes.
10569         * gdbthread.h: Fix common/ includes.
10570         * gdbarch-selftests.c: Fix common/ includes.
10571         * gdb_usleep.c: Fix common/ includes.
10572         * gdb_select.h: Fix common/ includes.
10573         * gdb_bfd.c: Fix common/ includes.
10574         * gcore.c: Fix common/ includes.
10575         * fork-child.c: Fix common/ includes.
10576         * findvar.c: Fix common/ includes.
10577         * fbsd-nat.c: Fix common/ includes.
10578         * event-top.c: Fix common/ includes.
10579         * event-loop.c: Fix common/ includes.
10580         * dwarf2read.c: Fix common/ includes.
10581         * dwarf2loc.c: Fix common/ includes.
10582         * dwarf2-frame.c: Fix common/ includes.
10583         * dwarf-index-cache.c: Fix common/ includes.
10584         * dtrace-probe.c: Fix common/ includes.
10585         * disasm-selftests.c: Fix common/ includes.
10586         * defs.h: Fix common/ includes.
10587         * csky-tdep.c: Fix common/ includes.
10588         * cp-valprint.c: Fix common/ includes.
10589         * cp-support.h: Fix common/ includes.
10590         * cp-support.c: Fix common/ includes.
10591         * corelow.c: Fix common/ includes.
10592         * completer.h: Fix common/ includes.
10593         * completer.c: Fix common/ includes.
10594         * compile/compile.c: Fix common/ includes.
10595         * compile/compile-loc2c.c: Fix common/ includes.
10596         * compile/compile-cplus-types.c: Fix common/ includes.
10597         * compile/compile-cplus-symbols.c: Fix common/ includes.
10598         * command.h: Fix common/ includes.
10599         * cli/cli-dump.c: Fix common/ includes.
10600         * cli/cli-cmds.c: Fix common/ includes.
10601         * charset.c: Fix common/ includes.
10602         * build-id.c: Fix common/ includes.
10603         * btrace.h: Fix common/ includes.
10604         * btrace.c: Fix common/ includes.
10605         * breakpoint.h: Fix common/ includes.
10606         * breakpoint.c: Fix common/ includes.
10607         * ax.h:
10608         (enum agent_op): Fix common/ includes.
10609         * ax-general.c (struct aop_map): Fix common/ includes.
10610         * ax-gdb.c: Fix common/ includes.
10611         * auxv.c: Fix common/ includes.
10612         * auto-load.c: Fix common/ includes.
10613         * arm-tdep.c: Fix common/ includes.
10614         * arch/riscv.c: Fix common/ includes.
10615         * arch/ppc-linux-common.c: Fix common/ includes.
10616         * arch/i386.c: Fix common/ includes.
10617         * arch/arm.c: Fix common/ includes.
10618         * arch/arm-linux.c: Fix common/ includes.
10619         * arch/arm-get-next-pcs.c: Fix common/ includes.
10620         * arch/amd64.c: Fix common/ includes.
10621         * arch/aarch64.c: Fix common/ includes.
10622         * arch/aarch64-insn.c: Fix common/ includes.
10623         * arch-utils.c: Fix common/ includes.
10624         * amd64-windows-tdep.c: Fix common/ includes.
10625         * amd64-tdep.c: Fix common/ includes.
10626         * amd64-sol2-tdep.c: Fix common/ includes.
10627         * amd64-obsd-tdep.c: Fix common/ includes.
10628         * amd64-nbsd-tdep.c: Fix common/ includes.
10629         * amd64-linux-tdep.c: Fix common/ includes.
10630         * amd64-linux-nat.c: Fix common/ includes.
10631         * amd64-fbsd-tdep.c: Fix common/ includes.
10632         * amd64-fbsd-nat.c: Fix common/ includes.
10633         * amd64-dicos-tdep.c: Fix common/ includes.
10634         * amd64-darwin-tdep.c: Fix common/ includes.
10635         * agent.c: Fix common/ includes.
10636         * ada-lang.h: Fix common/ includes.
10637         * ada-lang.c: Fix common/ includes.
10638         * aarch64-tdep.c: Fix common/ includes.
10639
10640 2019-01-25  Tom Tromey  <tom@tromey.com>
10641
10642         * common/create-version.sh: Use common/version.h.
10643
10644 2019-01-24  Pedro Alves  <palves@redhat.com>
10645
10646         * infrun.c (signal_stop, signal_print, signal_program)
10647         (signal_catch, signal_pass): Now arrays instead of pointers.
10648         (update_signals_program_target, do_target_resume)
10649         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10650         * linux-nat.c (linux_nat_target::pass_signals)
10651         (linux_nat_target::create_inferior, linux_nat_target::attach):
10652         Adjust.
10653         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10654         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10655         * procfs.c (procfs_target::pass_signals): Adjust.
10656         * record-full.c (record_full_target::resume): Adjust.
10657         * remote.c (remote_target::pass_signals)
10658         (remote_target::program_signals): Adjust.
10659         * target-debug.h (target_debug_print_signals): Now takes a
10660         gdb::array_view as parameter.  Adjust.
10661         * target.h (target_ops) <pass_signals, program_signals>: Replace
10662         pointer and length parameters with gdb::array_view.
10663         (target_pass_signals, target_program_signals): Likewise.
10664         * target-delegates.c: Regenerate.
10665
10666 2019-01-24  Pedro Alves  <palves@redhat.com>
10667
10668         * common/forward-scope-exit.h
10669         (forward_scope_exit::forward_scope_exit): Pass arguments to
10670         m_bind_function directly, instead of creating a std::bind and
10671         copying that.
10672
10673 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10674
10675         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10676         for static members.
10677         (pass_in_v_vfp_candidate): Likewise.
10678
10679 2019-01-23  Tom Tromey  <tom@tromey.com>
10680             Pedro Alves  <palves@redhat.com>
10681
10682         * regcache.c (class regcache_invalidator): Remove.
10683         (regcache::raw_write): Use make_scope_exit.
10684
10685 2019-01-23  Tom Tromey  <tom@tromey.com>
10686
10687         * ui-out.h (class ui_out_emit_type): Update comment.
10688
10689 2019-01-23  Tom Tromey  <tom@tromey.com>
10690
10691         * infrun.c (fetch_inferior_event): Update comment.
10692
10693 2019-01-23  Tom Tromey  <tom@tromey.com>
10694             Pedro Alves  <palves@redhat.com>
10695
10696         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10697         parameter.
10698         (fetch_inferior_event): Use SCOPE_EXIT.
10699
10700
10701 2019-01-23  Tom Tromey  <tom@tromey.com>
10702             Pedro Alves  <palves@redhat.com>
10703
10704         * infrun.c (disable_thread_events): Delete.
10705         (stop_all_threads): Use SCOPE_EXIT.
10706
10707 2019-01-23  Tom Tromey  <tom@tromey.com>
10708             Pedro Alves  <palves@redhat.com>
10709
10710         * symfile.c: Include forward-scope-exit.h.
10711         (clear_symtab_users_cleanup): Replace forward declaration with
10712         a FORWARD_SCOPE_EXIT.
10713         (syms_from_objfile_1): Use the forward_scope_exit and
10714         gdb::optional instead of cleanup_function.
10715         (reread_symbols): Use the forward_scope_exit instead of
10716         cleanup_function.
10717         (clear_symtab_users_cleanup): Remove function.
10718
10719 2019-01-23  Tom Tromey  <tom@tromey.com>
10720             Pedro Alves  <palves@redhat.com>
10721
10722         * linux-nat.c: Include scope-exit.h.
10723         (cleanup_target_stop): Remove.
10724         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10725         SCOPE_EXIT.
10726
10727 2019-01-23  Tom Tromey  <tom@tromey.com>
10728             Pedro Alves  <palves@redhat.com>
10729
10730         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10731         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10732
10733 2019-01-23  Tom Tromey  <tom@tromey.com>
10734             Andrew Burgess  <andrew.burgess@embecosm.com>
10735             Pedro Alves  <palves@redhat.com>
10736
10737         * infrun.c (fetch_inferior_event): Use scope_exit.
10738         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10739         * top.c (execute_command): Use scope_exit.
10740         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10741         * utils.c (do_bpstat_clear_actions_cleanup)
10742         (make_bpstat_clear_actions_cleanup): Remove.
10743
10744 2019-01-23  Tom Tromey  <tom@tromey.com>
10745             Pedro Alves  <palves@redhat.com>
10746
10747         * infrun.c: Include "common/scope-exit.h"
10748         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10749         (wait_for_inferior): Use SCOPE_EXIT.
10750         (fetch_inferior_event): Use scope_exit.
10751
10752 2019-01-23  Tom Tromey  <tom@tromey.com>
10753             Pedro Alves  <palves@redhat.com>
10754
10755         * breakpoint.c (create_breakpoint): Remove cleanup.
10756
10757 2019-01-23  Tom Tromey  <tom@tromey.com>
10758             Andrew Burgess  <andrew.burgess@embecosm.com>
10759             Pedro Alves  <palves@redhat.com>
10760
10761 2019-01-23  Pedro Alves  <palves@redhat.com>
10762
10763         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10764
10765 2019-01-23  Pedro Alves  <palves@redhat.com>
10766             Andrew Burgess  <andrew.burgess@embecosm.com>
10767
10768         * gdbthread.h: Include "common/forward-scope-exit.h".
10769         (scoped_finish_thread_state): Redefine custom class in terms of
10770         forward_scope_exit.
10771
10772 2019-01-23  Pedro Alves  <palves@redhat.com>
10773             Andrew Burgess  <andrew.burgess@embecosm.com>
10774
10775         * common/forward-scope-exit.h: New file.
10776
10777 2019-01-23  Pedro Alves  <palves@redhat.com>
10778             Andrew Burgess  <andrew.burgess@embecosm.com>
10779             Tom Tromey  <tom@tromey.com>
10780
10781         * common/scope-exit.h: New file.
10782
10783 2019-01-23  Pedro Alves  <palves@redhat.com>
10784
10785         * common/preprocessor.h (ESC): Rename to ...
10786         (ESC_PARENS): ... this.
10787         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10788         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10789
10790 2019-01-23  Tom Tromey  <tom@tromey.com>
10791
10792         * language.h (class scoped_switch_to_sym_language_if_auto):
10793         Initialize m_lang in both cases.
10794
10795 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10796
10797         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10798         with XCNEW.
10799
10800 2019-01-22  Tom Tromey  <tom@tromey.com>
10801
10802         * corelow.c: Do not include sys/file.h.
10803
10804 2019-01-22  Tom Tromey  <tom@tromey.com>
10805
10806         * tui/tui-wingeneral.h: Include gdb_curses.h.
10807
10808 2019-01-22  Tom Tromey  <tom@tromey.com>
10809
10810         * source-cache.h (class source_cache) <get_source_lines,
10811         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10812
10813 2019-01-22  Tom Tromey  <tom@tromey.com>
10814
10815         * remote-fileio.h (struct remote_target): Declare.
10816
10817 2019-01-22  Tom Tromey  <tom@tromey.com>
10818
10819         * python/py-arch.c: Do not include py-ref.h.
10820         * python/py-bpevent.c: Do not include py-ref.h.
10821         * python/py-cmd.c: Do not include py-ref.h.
10822         * python/py-continueevent.c: Do not include py-ref.h.
10823         * python/py-event.h: Do not include py-ref.h.
10824         * python/py-evtregistry.c: Do not include py-ref.h.
10825         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10826         * python/py-frame.c: Do not include py-ref.h.
10827         * python/py-framefilter.c: Do not include py-ref.h.
10828         * python/py-function.c: Do not include py-ref.h.
10829         * python/py-infevents.c: Do not include py-ref.h.
10830         * python/py-linetable.c: Do not include py-ref.h.
10831         * python/py-objfile.c: Do not include py-ref.h.
10832         * python/py-param.c: Do not include py-ref.h.
10833         * python/py-prettyprint.c: Do not include py-ref.h.
10834         * python/py-progspace.c: Do not include py-ref.h.
10835         * python/py-symbol.c: Do not include py-ref.h.
10836         * python/py-symtab.c: Do not include py-ref.h.
10837         * python/py-type.c: Do not include py-ref.h.
10838         * python/py-unwind.c: Do not include py-ref.h.
10839         * python/py-utils.c: Do not include py-ref.h.
10840         * python/py-value.c: Do not include py-ref.h.
10841         * python/py-varobj.c: Do not include py-ref.h.
10842         * python/py-xmethods.c: Do not include py-ref.h.
10843         * python/python.c: Do not include py-ref.h.
10844         * varobj.c: Do not include py-ref.h.
10845
10846 2019-01-22  Tom Tromey  <tom@tromey.com>
10847
10848         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10849         keyword for bcache.
10850
10851 2019-01-22  Tom Tromey  <tom@tromey.com>
10852
10853         * compile/compile-cplus-types.c: Remove a comment by #include.
10854
10855 2019-01-22  Tom Tromey  <tom@tromey.com>
10856
10857         * compile/gcc-c-plugin.h: Include compile-internal.h.
10858
10859 2019-01-22  Tom Tromey  <tom@tromey.com>
10860
10861         * stabsread.c (EXTERN): Do not define.
10862         (symnum, next_symbol_text_func, processing_gcc_compilation)
10863         (within_function, global_sym_chain, global_stabs)
10864         (previous_stab_code, this_object_header_files)
10865         (n_this_object_header_files)
10866         (n_allocated_this_object_header_files): Define.
10867         * stabsread.h (EXTERN): Never define.  Use "extern".
10868
10869 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10870
10871         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10872         history_value.
10873
10874 2019-01-21  Tom Tromey  <tom@tromey.com>
10875
10876         * ui-out.c: Fix includes.
10877         * tui/tui-source.c: Fix includes.
10878         * target.c: Fix includes.
10879         * remote.c: Fix includes.
10880         * regcache.c: Fix includes.
10881         * python/py-block.c: Fix includes.
10882         * printcmd.c: Fix includes.
10883         * or1k-tdep.c: Fix includes.
10884         * mi/mi-main.c: Fix includes.
10885         * m32r-tdep.c: Fix includes.
10886         * csky-tdep.c: Fix includes.
10887         * compile/compile-cplus-types.c: Fix includes.
10888         * cli/cli-interp.c: Fix includes.
10889
10890 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10891
10892         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10893         for padding.
10894
10895 2019-01-16  Tom Tromey  <tom@tromey.com>
10896
10897         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10898         earlier.
10899         (struct objfile) <msymbols_range>: Move from top level.
10900         <msymbols>: New method.
10901         (class objfile_msymbols): Remove.
10902         * symtab.c (default_collect_symbol_completion_matches_break_on):
10903         Update.
10904         * symmisc.c (dump_msymbols): Update.
10905         * stabsread.c (scan_file_globals): Update.
10906         * objc-lang.c (info_selectors_command, info_classes_command)
10907         (find_methods): Update.
10908         * minsyms.c (find_solib_trampoline_target): Update.
10909         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10910         * coffread.c (coff_symfile_read): Update.
10911         * ada-lang.c (ada_lookup_simple_minsym)
10912         (ada_collect_symbol_completion_matches): Update.
10913
10914 2019-01-16  Tom Tromey  <tom@tromey.com>
10915
10916         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10917         type.  Remove no-argument constructor.
10918         <iterator::operator++>: Simplify.
10919         <begin>: Update.
10920         <end>: Use minimal_symbol_count.
10921
10922 2019-01-16  Tom Tromey  <tom@tromey.com>
10923
10924         * objfiles.h (struct objfile) <psymtabs>: New method.
10925         (class objfile_psymtabs): Remove.
10926         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10927         typedef.
10928         <range>: New method.
10929         (require_partial_symbols): Change return type.
10930         * psymtab.c (require_partial_symbols)
10931         (psym_expand_symtabs_matching): Update.
10932         * mdebugread.c (parse_partial_symbols): Update.
10933         * dbxread.c (dbx_end_psymtab): Update.
10934
10935 2019-01-15  Tom Tromey  <tom@tromey.com>
10936
10937         * symtab.c (lookup_objfile_from_block)
10938         (lookup_symbol_in_objfile_symtabs)
10939         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10940         (find_line_symtab, info_sources_command)
10941         (default_collect_symbol_completion_matches_break_on)
10942         (make_source_files_completion_list): Update.
10943         * symmisc.c (print_objfile_statistics, dump_objfile)
10944         (maintenance_print_symbols, maintenance_info_symtabs)
10945         (maintenance_check_symtabs, maintenance_info_line_tables):
10946         Update.
10947         * source.c (select_source_symtab)
10948         (forget_cached_source_info_for_objfile): Update.
10949         * objfiles.h (class objfile_compunits): Remove.
10950         (struct objfile) <compunits_range>: New typedef.
10951         (compunits): New method.
10952         * objfiles.c (objfile_relocate1): Update.
10953         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10954         * maint.c (count_symtabs_and_blocks): Update.
10955         * linespec.c (iterate_over_all_matching_symtabs): Update.
10956         * cp-support.c (add_symbol_overload_list_qualified): Update.
10957         * coffread.c (coff_symtab_read): Update.
10958         * ada-lang.c (add_nonlocal_symbols)
10959         (ada_collect_symbol_completion_matches)
10960         (ada_add_global_exceptions): Update.
10961
10962 2019-01-15  Tom Tromey  <tom@tromey.com>
10963
10964         * progspace.h (program_space) <objfiles_safe_range>: New
10965         typedef.
10966         <objfiles_safe>: New method.
10967         * objfiles.h (class all_objfiles_safe): Remove.
10968         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10969         * jit.c (jit_inferior_exit_hook): Update.
10970
10971 2019-01-17  Tom Tromey  <tom@tromey.com>
10972
10973         * progspace.h (program_space) <objfiles_range>: New typedef.
10974         <objfiles>: New method.
10975         <objfiles_head>: Rename from objfiles.
10976         (object_files): Update.
10977         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10978         * guile/scm-pretty-print.c
10979         (ppscm_find_pretty_printer_from_objfiles): Update.
10980         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10981         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10982         Update.
10983         * python/py-progspace.c (pspy_get_objfiles): Update.
10984         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10985         Update.
10986         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10987         (objfpy_lookup_objfile_by_build_id): Update.
10988         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10989         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10990         Update.
10991         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10992         (expand_symtab_containing_pc, lookup_objfile_from_block)
10993         (lookup_static_symbol, basic_lookup_transparent_type)
10994         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10995         (find_line_symtab, info_sources_command)
10996         (default_collect_symbol_completion_matches_break_on)
10997         (make_source_files_completion_list, find_main_name): Update.
10998         * symmisc.c (print_symbol_bcache_statistics)
10999         (print_objfile_statistics, maintenance_print_symbols)
11000         (maintenance_print_msymbols, maintenance_print_objfiles)
11001         (maintenance_info_symtabs, maintenance_check_symtabs)
11002         (maintenance_expand_symtabs, maintenance_info_line_tables):
11003         Update.
11004         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11005         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11006         (map_overlay_command, unmap_overlay_command)
11007         (simple_overlay_update, expand_symtabs_matching)
11008         (map_symbol_filenames): Update.
11009         * symfile-debug.c (set_debug_symfile): Update.
11010         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11011         Update.
11012         * source.c (select_source_symtab, forget_cached_source_info):
11013         Update.
11014         * solib.c (solib_read_symbols): Update.
11015         * solib-spu.c (append_ocl_sos): Update.
11016         * psymtab.c (maintenance_print_psymbols)
11017         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11018         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11019         * printcmd.c (info_symbol_command): Update.
11020         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11021         Update.
11022         * objfiles.h (class all_objfiles): Remove.
11023         * objfiles.c (have_partial_symbols, have_full_symbols)
11024         (have_minimal_symbols, qsort_cmp, update_section_map)
11025         (shared_objfile_contains_address_p)
11026         (default_iterate_over_objfiles_in_search_order): Update.
11027         * objc-lang.c (info_selectors_command, info_classes_command)
11028         (find_methods): Update.
11029         * minsyms.c (find_solib_trampoline_target): Update.
11030         * maint.c (maintenance_info_sections)
11031         (maintenance_translate_address, count_symtabs_and_blocks):
11032         Update.
11033         * main.c (captured_main_1): Update.
11034         * linux-thread-db.c (try_thread_db_load_from_pdir)
11035         (has_libpthread): Update.
11036         * linespec.c (iterate_over_all_matching_symtabs)
11037         (search_minsyms_for_name): Update.
11038         * jit.c (jit_find_objf_with_entry_addr): Update.
11039         * hppa-tdep.c (find_unwind_entry)
11040         (hppa_lookup_stub_minimal_symbol): Update.
11041         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11042         Update.
11043         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11044         (elf_gnu_ifunc_resolve_by_got): Update.
11045         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11046         * dwarf-index-write.c (save_gdb_index_command): Update.
11047         * cp-support.c (add_symbol_overload_list_qualified): Update.
11048         * breakpoint.c (create_overlay_event_breakpoint)
11049         (create_longjmp_master_breakpoint)
11050         (create_std_terminate_master_breakpoint)
11051         (create_exception_master_breakpoint): Update.
11052         * blockframe.c (find_pc_partial_function): Update.
11053         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11054         (ada_collect_symbol_completion_matches)
11055         (ada_add_global_exceptions): Update.
11056
11057 2019-01-17  Tom Tromey  <tom@tromey.com>
11058
11059         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11060         declare VEC.
11061         (solib_target_parse_libraries): Change return type.
11062         (library_list_start_segment, library_list_start_section)
11063         (library_list_end_library, library_list_start_library); Update.
11064         (solib_target_free_library_list): Remove.
11065         (solib_target_parse_libraries): Remove cleanup.  Change return
11066         type.
11067         (solib_target_current_sos): Update.
11068
11069 2019-01-17  Tom Tromey  <tromey@bapiya>
11070
11071         * valprint.c: Replace "the the" with "the".
11072         * symtab.c: Replace "the the" with "the".
11073         * solib.c: Replace "the the" with "the".
11074         * solib-dsbt.c: Replace "the the" with "the".
11075         * linespec.c: Replace "the the" with "the".
11076         * dwarf2loc.h: Replace "the the" with "the".
11077         * amd64-windows-tdep.c: Replace "the the" with "the".
11078         * aarch64-tdep.c: Replace "the the" with "the".
11079
11080 2019-01-16  Keith Seitz  <keiths@redhat.com>
11081
11082         PR gdb/23773
11083         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11084         <builder>: Rename to ..
11085         <m_builder>: ... this and make private.
11086         (dwarf2_cu::get_builder): New method.  Change all users of
11087         `builder' to use this method.
11088         (dwarf2_start_symtab): Move to ...
11089         (dwarf2_cu::start_symtab): ... here.  Update all callers
11090         (setup_type_unit_groups): Move to ...
11091         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11092         callers.
11093         (dwarf2_cu::reset_builder): New method.
11094         (process_full_compunit, process_full_type_unit): Use
11095         dwarf2_cu::reset_builder.
11096         (follow_die_offset): Record the ancestor CU if it is different
11097         from the followed DIE's CU.
11098         (follow_die_sig_1): Likewise.
11099
11100 2019-01-15  Tom Tromey  <tom@tromey.com>
11101
11102         * remote.c (class remote_state) <buf>: Now a char_vector.
11103         <buf_size>: Remove.
11104         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11105         parameter.
11106         (remote_target::getpkt_or_notif_sane_1)
11107         (remote_target::getpkt_sane)
11108         (remote_target::getpkt_or_notif_sane): Likewise.
11109         (class remote_target) <putpkt>: New overload.
11110         (remote_target::read_frame): Change type of "buf_p".  Remove
11111         sizeof_p parameter.
11112         (packet_ok): New overload.
11113         (packet_check_result): New overload.
11114         Update all uses.
11115
11116 2019-01-14  Tom Tromey  <tom@tromey.com>
11117
11118         * remote-notif.c (handle_notification, remote_notif_ack)
11119         (remote_notif_parse): Make "buf" const.
11120         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11121         const.
11122         (remote_notif_parse, remote_notif_ack, handle_notification):
11123         Likewise.
11124         * remote.c (remote_notif_stop_parse): Make "buf" const.
11125         (remote_target::remote_parse_stop_reply): Make "buf" const.
11126         (remote_notif_stop_ack): Make "buf" const.
11127
11128 2019-01-14  Tom Tromey  <tom@tromey.com>
11129
11130         * remote.c (remote_console_output): Make parameter const.
11131
11132 2019-01-14  Tom Tromey  <tom@tromey.com>
11133
11134         * target-debug.h (target_debug_print_signals): Constify.
11135         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11136         * procfs.c (procfs_target::pass_signals): Update.
11137         * linux-nat.c (linux_nat_target::pass_signals): Update.
11138         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11139         * target-delegates.c: Rebuild.
11140         * remote.c (remote_target::program_signals): Update.
11141         (remote_target::pass_signals): Update.
11142         * target.c (target_pass_signals): Constify argument.
11143         (target_program_signals): Likewise.
11144         * target.h (struct target_ops) <pass_signals, program_signals>:
11145         Constify argument.
11146         (target_pass_signals, target_program_signals): Constify argument.
11147
11148 2019-01-14  Tom Tromey  <tom@tromey.com>
11149
11150         PR tui/28819:
11151         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11152
11153 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11154
11155         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11156         field.
11157         * rs6000-tdep.c: Include reggroups.h.
11158         (IS_V_ALIAS_PSEUDOREG): Define.
11159         (rs6000_register_name): Return names for the "vX" aliases.
11160         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11161         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11162         aliases.  Call default_register_reggroup_p for all other
11163         pseudo-registers.
11164         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11165         New functions.
11166         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11167         Handle "vX" aliases.
11168         (v_alias_pseudo_register_collect): New function.
11169         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11170         (rs6000_gdbarch_init): Initialize "vX" aliases as
11171         pseudo-registers.  Restore registration of
11172         rs6000_pseudo_register_reggroup_p with
11173         set_tdesc_pseudo_register_reggroup_p.
11174
11175 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11176
11177         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11178         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11179         set_gdbarch_num_pseudo_regs.
11180
11181 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11182
11183         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11184         Remove arg prefixname, add do_set and do_show.
11185         Add member functions set_list and show_list.
11186         * cli/cli-style.c (class cli_style_option): Update accordingly.
11187         (style_set_list): Move to file scope.
11188         (style_show_list): Likewise.
11189         (set_style): Call help_list.
11190         (show_style): Call cmd_show_list.
11191         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11192         Update to use the new macro.
11193
11194 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11195
11196         * ada-lang.c (_initialize_ada_language): Expand the help text
11197         for the "catch exception" command.
11198
11199 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11200
11201         * symtab.c (matching_obj_sections): Initialize obj,
11202         declare it closer to its usage.
11203
11204 2019-01-10  Tom Tromey  <tom@tromey.com>
11205
11206         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11207         (basic_inf_threads_range): Remove.
11208         (inf_threads_range, inf_non_exited_threads_range)
11209         (safe_inf_threads_range): Use next_adapter.
11210
11211 2019-01-10  Keith Seitz  <keiths@redhat.com>
11212
11213         PR gdb/23712
11214         PR symtab/23010
11215         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11216         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11217
11218 2019-01-10  Keith Seitz  <keiths@redhat.com>
11219
11220         PR gdb/23712
11221         PR symtab/23010
11222         * dictionary.c (pending_to_vector): Remove.
11223         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11224         Remove _1 suffix, replacing functions of the same name.  Update
11225         all callers.
11226         (dict_create_hashed, dict_create_hashed_expandable)
11227         (dict_create_linear, dict_create_linear_expandable, dict_free)
11228         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11229         Make functions static.
11230
11231 2019-01-10  Keith Seitz  <keiths@redhat.com>
11232
11233         PR gdb/23712
11234         PR symtab/23010
11235         * dictionary.h (struct dictionary): Replace declaration with
11236         multidictionary.
11237         (dict_create_hashed, dict_create_hashed_expandable)
11238         (dict_create_linear, dict_create_linear_expandable)
11239         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11240         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11241         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11242         taking multidictionary argument.
11243         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11244         * block.h (struct block) <dict>: Change to multidictionary
11245         and rename `multidict'.
11246         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11247         symmisc.c: Update all dictionary references to multidictionary.
11248
11249 2019-01-10  Keith Seitz  <keiths@redhat.com>
11250
11251         PR gdb/23712
11252         PR symtab/23010
11253         * dictionary.c: Include unordered_map.
11254         (pending_to_vector): New function.
11255         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11256         Rewrite the non-"_1" functions to take vector instead
11257         of linked list.
11258         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11259         "new" _1 versions of the same name.
11260         (multidictionary): Define.
11261         (std::hash<enum language): New definition.
11262         (collate_pending_symbols_by_language, mdict_create_hashed)
11263         (mdict_create_hashed_expandable, mdict_create_linear)
11264         (mdict_create_linear_expandable, mdict_free)
11265         (find_language_dictionary, create_new_language_dictionary)
11266         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11267         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11268         (mdict_size, mdict_empty): New functions.
11269         * dictionary.h (mdict_iterator): Define.
11270
11271 2019-01-10  Pedro Alves  <palves@redhat.com>
11272
11273         * breakpoint.c (read_uploaded_action)
11274         (create_tracepoint_from_upload): Adjust to use
11275         gdb::unique_xmalloc_ptr.
11276         * ctf.c (ctf_write_uploaded_tp):
11277         (SET_ARRAY_FIELD): Use emplace_back.
11278         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11279         * tracefile-tfile.c (tfile_write_uploaded_tp):
11280         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11281         gdb::unique_xmalloc_ptr.
11282         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11283         at_string, cond_string, cmd_strings>: Replace char pointers
11284         with gdb::unique_xmalloc_ptr.
11285
11286 2019-01-10  Pedro Alves  <palves@redhat.com>
11287
11288         * solib-target.c (library_list_start_library): Don't xstrdup name.
11289
11290 2019-01-10  Pedro Alves  <palves@redhat.com>
11291
11292         * mdebugread.c (parse_partial_symbols): Use
11293         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11294
11295 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11296
11297         * linux-fork.c (scoped_switch_fork_info)
11298         <~scoped_switch_fork_info>: Fix incorrect variable name.
11299
11300 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11301
11302         * linux-fork.c (scoped_switch_fork_info)
11303         <scoped_switch_fork_info>: Make explicit.
11304         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11305
11306 2019-01-10  Tom Tromey  <tom@tromey.com>
11307
11308         * objfiles.h (objfile::reset_psymtabs): Update.
11309         * objfiles.c (objfile::objfile): Update.
11310         * psymtab.h (psymtab_storage::obstack): Update.
11311         (psymtab_storage::m_obstack): Use gdb::optional.
11312         (class psymtab_storage): Update comment.  Remove objfile
11313         parameter.
11314         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11315
11316 2019-01-10  Tom Tromey  <tom@tromey.com>
11317
11318         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11319         <free_psymtabs>: Now private.
11320         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11321         (allocate_psymtab): Use new method.
11322
11323 2019-01-10  Tom Tromey  <tom@tromey.com>
11324
11325         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11326         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11327         * mdebugread.c (parse_partial_symbols): Use
11328         allocate_dependencies.
11329         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11330         allocate_dependencies.
11331         (process_psymtab_comp_unit_reader)
11332         (build_type_psymtab_dependencies): Likewise.
11333         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11334
11335 2019-01-10  Tom Tromey  <tom@tromey.com>
11336
11337         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11338         PSYMBOL_SET_LANGUAGE.
11339         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11340
11341 2019-01-10  Tom Tromey  <tom@tromey.com>
11342
11343         * psymtab.h (psymtab_storage::obstack): New method.
11344         <m_obstack>: Rename from obstack; now private.
11345         * psymtab.c (psymtab_storage): Update.
11346         * dwarf2read.c (create_addrmap_from_index)
11347         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11348         Update.
11349
11350 2019-01-10  Tom Tromey  <tom@tromey.com>
11351
11352         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11353         * objfiles.h (objfile::reset_psymtabs): New method.
11354
11355 2019-01-10  Tom Tromey  <tom@tromey.com>
11356
11357         * symmisc.c (print_symbol_bcache_statistics): Update.
11358         (print_objfile_statistics): Update.
11359         * symfile.c (reread_symbols): Update.
11360         * psymtab.h (class psymtab_storage): New.
11361         * psymtab.c (psymtab_storage): New constructor.
11362         (~psymtab_storage): New destructor.
11363         (require_partial_symbols): Update.
11364         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11365         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11366         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11367         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11368         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11369         (start_psymtab_common, end_psymtab_common)
11370         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11371         (allocate_psymtab): Update.
11372         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11373         Update.
11374         (dump_psymtab_addrmap, maintenance_print_psymbols)
11375         (maintenance_check_psymtabs): Update.
11376         (class objfile_psymtabs): Move to objfiles.h.
11377         * psympriv.h (discard_psymtab): Now inline.
11378         (psymtab_discarder::psymtab_discarder): Update.
11379         (psymtab_discarder::~psymtab_discarder): Update.
11380         (ALL_OBJFILE_PSYMTABS): Rewrite.
11381         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11382         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11383         Remove fields.
11384         <partial_symtabs>: New field.
11385         (class objfile_psymtabs): Move from psymtab.h.  Update.
11386         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11387         psymbol_cache.
11388         (objfile::~objfile): Don't destroy psymbol_cache.
11389         * mdebugread.c (parse_partial_symbols): Update.
11390         * dwarf2read.c (create_addrmap_from_index)
11391         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11392         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11393         (add_partial_subprogram, dwarf2_ranges_read): Update.
11394         * dwarf-index-write.c (write_address_map)
11395         (write_one_signatured_type, recursively_write_psymbols)
11396         (class debug_names, class debug_names, write_psymtabs_to_index):
11397         Update.
11398
11399 2019-01-10  Tom Tromey  <tom@tromey.com>
11400
11401         * symtab.h (SYMBOL_SET_NAMES): Update.
11402         (symbol_set_names): Update.
11403         (MSYMBOL_SET_NAMES): Update.
11404         * symtab.c (symbol_set_names): Change argument to be an
11405         objfile_per_bfd_storage.
11406         * psymtab.c (add_psymbol_to_bcache): Update.
11407         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11408
11409 2019-01-10  Tom Tromey  <tom@tromey.com>
11410
11411         * symtab.c (create_demangled_names_hash): Change argument to be an
11412         objfile_per_bfd_storage.
11413         (symbol_set_names): Update.
11414
11415 2019-01-10  Tom Tromey  <tom@tromey.com>
11416
11417         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11418         init_psymbol_list.
11419         * psymtab.c (init_psymbol_list): Do nothing if already called.
11420         * psympriv.h (init_psymbol_list): Add comment.
11421         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11422         init_psymbol_list.
11423         * dbxread.c (dbx_symfile_read): Unconditionally call
11424         init_psymbol_list.
11425
11426 2019-01-10  Tom Tromey  <tom@tromey.com>
11427
11428         * xcoffread.c (scan_xcoff_symtab): Update.
11429         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11430         "where".
11431         * mdebugread.c (parse_partial_symbols)
11432         (handle_psymbol_enumerators): Update.
11433         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11434         * dbxread.c (read_dbx_symtab): Update.
11435         * psympriv.h (psymbol_placement): New enum.
11436         (add_psymbol_to_list): Update.
11437
11438 2019-01-10  Tom Tromey  <tom@tromey.com>
11439
11440         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11441         static_psymbols parameters.
11442         (scan_xcoff_symtab): Update.
11443         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11444         static_psymbols parameters.
11445         * psympriv.h (start_psymtab_common): Update.
11446         * mdebugread.c (parse_partial_symbols): Update.
11447         * dwarf2read.c (create_partial_symtab): Update.
11448         * dbxread.c (read_dbx_symtab): Update.
11449         (start_psymtab): Remove global_psymbols and static_psymbols
11450         parameters.
11451
11452 2019-01-10  Tom Tromey  <tom@tromey.com>
11453
11454         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11455         * psymtab.c (allocate_psymtab): Add comment.
11456         * psympriv.h (allocate_psymtab): Add comment.
11457         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11458         initializations.
11459         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11460
11461 2019-01-10  Tom Tromey  <tom@tromey.com>
11462
11463         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11464         Don't declare.
11465         * mipsread.c: Include mdebugread.h.
11466         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11467         Declare.
11468         * elfread.c: Include mdebugread.h.
11469
11470 2019-01-09  Tom Tromey  <tom@tromey.com>
11471
11472         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11473         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11474         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11475         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11476         (psym_lookup_symbol, psym_find_last_source_symtab)
11477         (psym_forget_cached_source_info, psym_print_stats)
11478         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11479         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11480         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11481         (psym_find_compunit_symtab_by_address)
11482         (maintenance_print_psymbols, maintenance_info_psymtabs)
11483         (maintenance_check_psymtabs): Use ranged for.
11484         * psymtab.h (class objfile_psymtabs): New.
11485         (require_partial_symbols): Return objfile_psymtabs.
11486         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11487
11488 2019-01-09  Tom Tromey  <tom@tromey.com>
11489
11490         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11491         (find_pc_mapped_section, list_overlays_command)
11492         (map_overlay_command, unmap_overlay_command)
11493         (simple_overlay_update): Use all_objfiles.
11494         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11495         * printcmd.c (info_symbol_command): Use all_objfiles.
11496         * objfiles.h (ALL_OBJSECTIONS): Remove.
11497         * maint.c (maintenance_translate_address): Use all_objfiles.
11498         * gcore.c (gcore_create_callback): Use all_objfiles.
11499         (objfile_find_memory_regions): Likewise.
11500
11501 2019-01-09  Tom Tromey  <tom@tromey.com>
11502
11503         * symtab.c (find_line_symtab, info_sources_command)
11504         (make_source_files_completion_list): Use objfile_compunits.
11505         * source.c (select_source_symtab): Use objfile_compunits.
11506         * objfiles.h (struct objfile): Update comment.
11507         (ALL_OBJFILES): Remove.
11508         (ALL_FILETABS): Remove.
11509         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11510         objfile_compunits.
11511
11512 2019-01-09  Tom Tromey  <tom@tromey.com>
11513
11514         * symmisc.c (print_objfile_statistics, dump_objfile)
11515         (maintenance_print_symbols): Use compunit_filetabs.
11516         * source.c (forget_cached_source_info_for_objfile): Use
11517         compunit_filetabs.
11518         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11519         (ALL_FILETABS): Use compunit_filetabs.
11520         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11521         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11522
11523 2019-01-09  Tom Tromey  <tom@tromey.com>
11524
11525         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11526         (compunit_filetabs): New.
11527         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11528         compunit_filetabs.
11529         (info_sources_command, make_source_files_completion_list): Remove
11530         declaration.
11531         * symmisc.c (print_objfile_statistics, dump_objfile)
11532         (maintenance_print_symbols): Remove declaration.
11533         (maintenance_info_symtabs): Use compunit_filetabs.
11534         (maintenance_info_line_tables): Likewise.
11535         * source.c (select_source_symtab): Change local variable name.
11536         (forget_cached_source_info_for_objfile): Remove declaration.
11537         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11538         * objfiles.c (objfile_relocate1): Remove declaration.
11539         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11540         declaration.
11541         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11542         * coffread.c (coff_symtab_read): Remove declaration.
11543         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11544         compunit_filetabs.
11545
11546 2019-01-09  Tom Tromey  <tom@tromey.com>
11547
11548         * symtab.c (lookup_objfile_from_block)
11549         (find_pc_sect_compunit_symtab, search_symbols)
11550         (default_collect_symbol_completion_matches_break_on): Use
11551         objfile_compunits.
11552         * objfiles.h (ALL_COMPUNITS): Remove.
11553         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11554         * cp-support.c (add_symbol_overload_list_qualified): Use
11555         objfile_compunits.
11556         * ada-lang.c (ada_collect_symbol_completion_matches)
11557         (ada_add_global_exceptions): Use objfile_compunits.
11558
11559 2019-01-09  Tom Tromey  <tom@tromey.com>
11560
11561         * source.c (select_source_symtab)
11562         (forget_cached_source_info_for_objfile): Remove declaration.
11563         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11564         declaration.
11565         * maint.c (count_symtabs_and_blocks): Remove declaration.
11566         * cp-support.c (add_symbol_overload_list_qualified): Remove
11567         declaration.
11568         * coffread.c (coff_symtab_read): Remove declaration.
11569         * symtab.c (lookup_symbol_in_objfile_symtabs)
11570         (basic_lookup_transparent_type_1): Use objfile_compunits.
11571         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11572         (info_sources_command, search_symbols)
11573         (default_collect_symbol_completion_matches_break_on)
11574         (make_source_files_completion_list): Remove declaration.
11575         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11576         (ada_collect_symbol_completion_matches)
11577         (ada_add_global_exceptions): Remove declaration.
11578         * linespec.c (iterate_over_all_matching_symtabs): Use
11579         objfile_compunits.
11580         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11581         (class objfile_compunits): New.
11582         (ALL_COMPUNITS): Use objfile_compunits.
11583         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11584         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11585         objfile_compunits.
11586         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11587
11588 2019-01-09  Tom Tromey  <tom@tromey.com>
11589
11590         * symtab.c (search_symbols)
11591         (default_collect_symbol_completion_matches_break_on): Use
11592         objfile_msymbols.
11593         * ada-lang.c (ada_lookup_simple_minsym)
11594         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11595         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11596         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11597         objfile_msymbols.
11598         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11599         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11600         * objc-lang.c (find_methods): Use objfile_msymbols.
11601         (info_selectors_command, info_classes_command): Likewise.
11602         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11603         * objfiles.h (class objfile_msymbols): New.
11604         (ALL_OBJFILE_MSYMBOLS): Remove.
11605         (ALL_MSYMBOLS): Remove.
11606
11607 2019-01-09  Tom Tromey  <tom@tromey.com>
11608
11609         * common/next-iterator.h (next_adapter): Add Iterator template
11610         parameter.
11611         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11612         (class all_objfiles_safe): New.
11613         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11614         * objfiles.c (put_objfile_before): Update comment.
11615         (add_separate_debug_objfile): Likewise.
11616         (free_all_objfiles): Use all_objfiles_safe.
11617         (objfile_purge_solibs): Likewise.
11618
11619 2019-01-09  Tom Tromey  <tom@tromey.com>
11620
11621         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11622         (expand_symtab_containing_pc, lookup_static_symbol)
11623         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11624         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11625         all_objfiles.
11626         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11627         * breakpoint.c (create_overlay_event_breakpoint)
11628         (create_longjmp_master_breakpoint)
11629         (create_std_terminate_master_breakpoint)
11630         (create_exception_master_breakpoint): Use all_objfiles.
11631         * linux-thread-db.c (try_thread_db_load_from_pdir)
11632         (has_libpthread): Use all_objfiles.
11633         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11634         * linespec.c (iterate_over_all_matching_symtabs)
11635         (search_minsyms_for_name): Use all_objfiles.
11636         * maint.c (maintenance_info_sections): Use all_objfiles.
11637         * main.c (captured_main_1): Use all_objfiles.
11638         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11639         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11640         * guile/scm-pretty-print.c
11641         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11642         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11643         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11644         (maintenance_print_msymbols): Use all_objfiles.
11645         * source.c (select_source_symtab): Use all_objfiles.
11646         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11647         * symfile.c (remove_symbol_file_command)
11648         (expand_symtabs_matching, map_symbol_filenames): Use
11649         all_objfiles.
11650         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11651         all_objfiles.
11652         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11653         * objc-lang.c (find_methods): Use all_objfiles.
11654         * objfiles.c (have_partial_symbols, have_full_symbols)
11655         (have_minimal_symbols, qsort_cmp)
11656         (default_iterate_over_objfiles_in_search_order): Use
11657         all_objfiles.
11658         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11659         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11660         (maintenance_check_psymtabs): Use all_objfiles.
11661         (ALL_PSYMTABS): Remove.
11662         * compile/compile-object-run.c (do_module_cleanup): Use
11663         all_objfiles.
11664         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11665         * cp-support.c (add_symbol_overload_list_qualified): Use
11666         all_objfiles.
11667         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11668         Use all_objfiles.
11669         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11670         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11671         all_objfiles.
11672         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11673         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11674         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11675         Uses all_objfiles.
11676         * solib.c (solib_read_symbols): Use all_objfiles
11677
11678 2019-01-09  Tom Tromey  <tom@tromey.com>
11679
11680         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11681         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11682         all_objfiles.
11683         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11684         * symmisc.c (print_symbol_bcache_statistics)
11685         (print_objfile_statistics, maintenance_print_objfiles)
11686         (maintenance_info_symtabs, maintenance_check_symtabs)
11687         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11688         all_objfiles.
11689         * source.c (forget_cached_source_info): Use all_objfiles.
11690         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11691         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11692         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11693         * objfiles.c (update_section_map): Use all_objfiles.
11694         (shared_objfile_contains_address_p): Likewise.
11695         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11696         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11697
11698 2019-01-09  Tom Tromey  <tom@tromey.com>
11699
11700         * common/next-iterator.h: New file.
11701         * objfiles.h (class all_objfiles): New.
11702         (struct objfile_iterator): New.
11703
11704 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11705
11706         * NEWS: Move the description of the changed "frame", "select-frame",
11707          and "info frame" commands to the Changed commands section.
11708
11709 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11710
11711         * gdbtypes.c (check_stub_method_group): Remove handling of old
11712         mangling schemes.
11713         * linespec.c (find_methods): Likewise.
11714         * stabsread.c (read_member_functions): Likewise.
11715         * valops.c (search_struct_method): Likewise.
11716         (value_struct_elt_for_reference): Likewise.
11717         * NEWS: Mention this change.
11718
11719 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11720
11721         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11722         print_source_lines.
11723         * source.c (print_source_lines_base): Update line number check.
11724         (print_source_lines): New function.
11725         (source_lines_range::source_lines_range): New function.
11726         * source.h (class source_lines_range): New class.
11727         (print_source_lines): New declaration.
11728
11729 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11730
11731         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11732
11733 2019-01-08  Tom Tromey  <tom@tromey.com>
11734             Simon Marchi  <simon.marchi@ericsson.com>
11735
11736         PR gdb/24060
11737         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11738         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11739         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11740         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11741         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11742         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11743
11744 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11745
11746         * source.c (select_source_symtab): Move header comment to
11747         declaration in source.h.
11748         (forget_cached_source_info_for_objfile): Likewise.
11749         (forget_cached_source_info): Likewise.
11750         (identify_source_line): Likewise.
11751         * source.h (identify_source_line): Move declaration from symtab.h
11752         and add comment from source.c
11753         (print_source_lines): Likewise.
11754         (forget_cached_source_info_for_objfile): Likewise.
11755         (forget_cached_source_info): Likewise.
11756         (select_source_symtab): Likewise.
11757         (enum print_source_lines_flag): Move definition from symtab.h.
11758         * symtab.h (identify_source_line): Move declaration to source.h.
11759         (print_source_lines): Likewise.
11760         (forget_cached_source_info_for_objfile): Likewise.
11761         (forget_cached_source_info): Likewise.
11762         (select_source_symtab): Likewise.
11763         (enum print_source_lines_flag): Move definition to source.h.
11764         * tui/tui-hooks.c: Add 'source.h' include.
11765
11766 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11767
11768         * source.c (print_source_lines_base): Handle requests to print
11769         reverse line number sequences, and guard against empty lines
11770         string.
11771
11772 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11773
11774         * source.c (print_source_lines_base): Fix skip of '\r' if next
11775         character is '\n'.
11776
11777 2019-01-06  Tom Tromey  <tom@tromey.com>
11778
11779         * c-exp.y (struct c_parse_state) <macro_original_text,
11780         expansion_obstack>: New member.
11781         (macro_original_text, expansion_obstack): Remove globals.
11782         (scan_macro_expansion, scanning_macro_expansion)
11783         (finished_macro_expansion): Update.
11784         (scan_macro_cleanup): Remove.
11785         (yylex, c_parse): Update.
11786
11787 2019-01-06  Tom Tromey  <tom@tromey.com>
11788
11789         * c-exp.y (struct c_parse_state) <strings>: New member.
11790         (operator_stoken): Update.
11791
11792 2019-01-06  Tom Tromey  <tom@tromey.com>
11793
11794         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11795         (union type_stack_elt) <typelist_val>: Now a pointer to
11796         std::vector.
11797         (type_stack_cleanup): Don't declare.
11798         (push_typelist): Update.
11799         * parse.c (pop_typelist): Return a std::vector.
11800         (push_typelist): Take a std::vector.
11801         (follow_types): Update.  Do not free args.
11802         (type_stack_cleanup): Remove.
11803         * c-exp.y (struct c_parse_state): New.
11804         (cpstate): New global.
11805         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11806         (nonempty_typelist): Update.
11807         (func_mod): Create a new vector.
11808         (c_parse): Create a c_parse_state.
11809         (check_parameter_typelist): Do not delete params.
11810         (function_method): Update.  Do not delete type_list.
11811
11812 2019-01-06  Tom Tromey  <tom@tromey.com>
11813
11814         PR gdb/28155:
11815         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11816         check_typedef.
11817         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11818         (print_return_value): Likewise.
11819
11820 2019-01-05  Tom Tromey  <tom@tromey.com>
11821
11822         * contrib/cleanup_check.py: Remove.
11823         * contrib/gcc-with-excheck: Remove.
11824         * contrib/exsummary.py: Remove.
11825         * contrib/excheck.py: Remove.
11826
11827 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11828
11829         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11830         NULL. Initialize tpprev to NULL instead of assigning it
11831         to NULL on the next statement.
11832         * windows-nat.c (windows_delete_thread): Remove check for
11833         main_thread_id before printing thread exit notifications.
11834         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11835         Remove thread ID check against main_thread_id.
11836         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11837         windows_delete_thread.
11838         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11839
11840 2019-01-04  Tom Tromey  <tom@tromey.com>
11841
11842         * compile/compile.c (_initialize_compile): Use upper case for
11843         metasyntactic variables.
11844         * symmisc.c (_initialize_symmisc): Use upper case for
11845         metasyntactic variables.
11846         * psymtab.c (_initialize_psymtab): Use upper case for
11847         metasyntactic variables.
11848         * demangle.c (demangle_command): Use upper case for metasyntactic
11849         variables.
11850         (_initialize_demangler): Likewise.
11851         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11852         variables.
11853
11854 2019-01-03  Tom Tromey  <tom@tromey.com>
11855
11856         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11857
11858 2019-01-03  Tom Tromey  <tom@tromey.com>
11859
11860         * python/py-symtab.c (salpy_str): Update.
11861         (struct salpy_sal_object) <symtab>: Now a PyObject.
11862         (salpy_dealloc): Update.
11863         (del_objfile_sal): Use gdbpy_ref.
11864
11865 2019-01-03  Tom Tromey  <tom@tromey.com>
11866
11867         * python/py-type.c (convert_field): Use new_reference.  Return
11868         gdbpy_ref.
11869         (make_fielditem): Return gdbpy_ref.
11870         (typy_fields): Update.
11871         (typy_getitem): Update.
11872         (field_name): Return gdbpy_ref.  Use new_reference.
11873         (typy_iterator_iternext): Update.
11874
11875 2019-01-03  Tom Tromey  <tom@tromey.com>
11876
11877         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11878
11879 2019-01-03  Tom Tromey  <tom@tromey.com>
11880
11881         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11882         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11883         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11884         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11885         (pspy_set_type_printers): Likewise.
11886         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11887         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11888         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11889         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11890         (objfpy_set_type_printers): Likewise.
11891
11892 2019-01-03  Tom Tromey  <tom@tromey.com>
11893
11894         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11895         (gdbpy_print_stack): Use gdbpy_err_fetch.
11896         * python/python-internal.h (class gdbpy_err_fetch): New class.
11897         (class gdbpy_enter) <m_error_type, m_error_value,
11898         m_error_traceback>: Remove.
11899         <m_error>: New member.
11900         (gdbpy_exception_to_string): Don't declare.
11901         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11902         * python/py-value.c (convert_value_from_python): Use
11903         gdbpy_err_fetch.
11904         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11905         gdbpy_exception_to_string.
11906         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11907         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11908         gdbpy_err_fetch.
11909
11910 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11911
11912         * linux-nat.c (delete_lwp_cleanup): Delete.
11913         (struct lwp_deleter): New struct.
11914         (lwp_info_up): New typedef.
11915         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11916         lwp_info_up.
11917
11918 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11919
11920         * linux-fork.c (class scoped_switch_fork_info): New class.
11921         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11922
11923 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11924
11925         * valops.c (find_overload_match): Remove use of null_cleanup, and
11926         calls to do_cleanups.
11927
11928 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11929
11930         * compile/compile-cplus-types.c
11931         (compile_cplus_instance::decl_name): Handle changes to
11932         cp_func_name.
11933         * cp-support.c (cp_func_name): Update header comment, update
11934         return type.
11935         * cp-support.h (cp_func_name): Update return type in declaration.
11936         * valops.c (find_overload_match): Move temp_func local to top
11937         level of function and change its type.  Use temp_func to hold and
11938         delete temporary string obtained from cp_func_name.
11939
11940 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11941
11942         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11943         gdb::char_vector, remove cleanup, and update uses of `msg`.
11944
11945 2019-01-03  Jim Wilson  <jimw@sifive.com>
11946
11947         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11948
11949 2019-01-02  Tom Tromey  <tom@tromey.com>
11950
11951         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11952         (tdesc_parse_xml): Remove cleanups.
11953         * target-descriptions.h (make_cleanup_free_target_description):
11954         Don't declare.
11955         (target_desc_deleter): New struct.
11956         (target_desc_up): New typedef.
11957         * target-descriptions.c (target_desc_deleter::operator()): Rename
11958         from free_target_description.
11959         (make_cleanup_free_target_description): Remove.
11960
11961 2019-01-02  Tom Tromey  <tom@tromey.com>
11962
11963         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11964         constructor, destructor.
11965         (linespec_parser): Remove typedef.
11966         (~linespec_parser): Rename from linespec_parser_delete.
11967         (linespec_lex_to_end, linespec_complete_label)
11968         (linespec_complete): Update.
11969         (decode_line_full): Remove cleanups.
11970         (decode_line_1): Update.
11971
11972 2019-01-02  Tom Tromey  <tom@tromey.com>
11973
11974         * python/python-internal.h (inferior_to_inferior_object): Change
11975         return type.
11976         * python/py-exitedevent.c (create_exited_event_object): Update.
11977         * python/py-inferior.c (inferior_to_inferior_object): Return
11978         gdbpy_ref.
11979         (python_new_inferior, python_inferior_deleted)
11980         (thread_to_thread_object, delete_thread_object)
11981         (build_inferior_list, gdbpy_selected_inferior): Update.
11982         * python/py-infthread.c (create_thread_object): Update.  Also fail
11983         if inferior_to_inferior_object fails.
11984
11985 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11986
11987         * inferior.h (class inferior) <displaced_step_state>: New field.
11988         * infrun.h (struct displaced_step_state): Move here from
11989         infrun.c.  Initialize fields, add constructor.
11990         <inf>: Remove field.
11991         <reset>: New method.
11992         * infrun.c (struct displaced_step_inferior_state): Move to
11993         infrun.h.
11994         (displaced_step_inferior_states): Remove.
11995         (get_displaced_stepping_state): Adust.
11996         (displaced_step_in_progress_any_inferior): Adjust.
11997         (displaced_step_in_progress_thread): Adjust.
11998         (displaced_step_in_progress): Adjust.
11999         (add_displaced_stepping_state): Remove.
12000         (get_displaced_step_closure_by_addr): Adjust.
12001         (remove_displaced_stepping_state): Remove.
12002         (infrun_inferior_exit): Call displaced_step_state.reset.
12003         (use_displaced_stepping): Don't check for NULL.
12004         (displaced_step_prepare_throw): Call
12005         get_displaced_stepping_state.
12006         (displaced_step_fixup): Don't check for NULL.
12007         (prepare_for_detach): Don't check for NULL.
12008
12009 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12010
12011         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12012          in case of call that did not complete.
12013
12014 2019-01-02  Andrey Utkin  <autkin@undo.io>
12015
12016         * symfile.c (find_separate_debug_file): Fix search of debug files for
12017         remote debuggee.
12018
12019 2019-01-02  Tom Tromey  <tom@tromey.com>
12020
12021         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12022         indentation.
12023         * python/py-frame.c (frapy_older): Remove cast.
12024         (frapy_newer): Likewise.
12025         * python/py-breakpoint.c (local_setattro): Remove cast.
12026         * python/py-arch.c (archpy_name): Remove local variable.
12027         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12028
12029 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12030
12031         * unittests/basic_string_view/element_access/char/empty.cc:
12032         Fix year range in copyright header.
12033
12034 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12035
12036         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12037         Delete.
12038         <operator==>: Update with for removed field.
12039         <hash>: Likewise.
12040         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12041         <isa_features>: ...this.
12042         <abi_features>: New field.
12043         (riscv_isa_flen): Update comment.
12044         (riscv_abi_xlen): New declaration.
12045         (riscv_abi_flen): New declaration.
12046         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12047         isa_features.
12048         (riscv_abi_xlen): New function.
12049         (riscv_isa_flen): Update to get answer from isa_features.
12050         (riscv_abi_flen): New function.
12051         (riscv_has_fp_abi): Update to get answer from abi_features.
12052         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12053         xlen and flen.
12054         (riscv_call_info) <xlen, flen>: Update comment.
12055         (riscv_call_arg_struct): Remove invalid assertions
12056         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12057         is removed.
12058         (riscv_gdbarch_init): Gather isa features and abi features
12059         separately, ensure both match on the gdbarch when reusing an old
12060         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12061         a target with 64-bit float hardware.
12062
12063 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12064
12065         * source.c (search_command_helper): Stop reverse search
12066         when line 1 has been searched.
12067
12068 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12069
12070         * record-full.c (record_full_base_target::close): Rewrite
12071         record_full_core_buf_list free logic.
12072
12073 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12074
12075         * break-catch-syscall.c (print_one_catch_syscall): xfree
12076         the last text.
12077
12078 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12079
12080         * top.c (print_gdb_version): Update Copyright year in version
12081         message.
12082
12083 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12084
12085         Update copyright year range in all GDB files.
12086
12087 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12088
12089         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12090
12091 For older changes see ChangeLog-2018.
12092 \f
12093 Local Variables:
12094 mode: change-log
12095 left-margin: 8
12096 fill-column: 74
12097 version-control: never
12098 coding: utf-8
12099 End:
12100