gdb/ChangeLog

   1 2019-04-19  Sergei Trofimovich <siarheit@google.com>
   2
   3         * configure.ac: add --enable-source-highlight switch.
   4         * configure: Regenerate.
   5         * top.c (print_gdb_version): plumb --enable-source-highlight
   6         status to "show configuration".
   7
   8 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
   9
  10         PR symtab/24423:
  11         * source.c (print_source_lines_base): Advance "iter" when a
  12         control character is seen.
  13
  14 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  15
  16         * inferior.h (struct infcall_suspend_state_deleter):
  17         Catch exception in destructor to avoid crash.
  18
  19 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
  20
  21         * utils.c (prompt_for_continue): Don't restore the styling at the
  22         end, as applied_style has the wrong value.  This fixes styling in
  23         long lists of file names that are interrupted by the "Continue?"
  24         prompt.
  25
  26 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  27
  28         * version.in: Set GDB version number to 8.2.91.DATE-git.
  29
  30 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  31
  32         GDB 8.2.91 released.
  33
  34 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  35
  36         * version.in: Set GDB version number to 8.2.91.
  37
  38 2019-03-20  Tom Tromey  <tromey@adacore.com>
  39
  40         PR gdb/24391
  41         * infrun.c (handle_inferior_event): Rename from
  42         handle_inferior_event_1.  Create a scoped_value_mark.
  43         (handle_inferior_event): Remove.
  44
  45 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  46
  47         * source-cache.c (source_cache::get_source_lines): Re-read
  48         fullname after calling open_source_file.
  49
  50 2019-03-18  Pedro Alves  <palves@redhat.com>
  51             Eli Zaretskii <eliz@gnu.org>
  52
  53         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
  54         m_line and m_start_of_line.
  55
  56 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
  57
  58         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
  59         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
  60         it returns a newline.  This fixes a regression in TU mode, whereby
  61         the next line is output on the same screen line as the user input.
  62
  63 2019-03-18  Pedro Alves  <palves@redhat.com>
  64
  65         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
  66         New globals.
  67         (apply_style): New, factored out from ...
  68         (apply_ansi_escape): ... this.  Handle reverse video mode.
  69         (tui_set_reverse_mode): New function.
  70         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
  71         * tui/tui-winsource.c (tui_show_source_line): Use
  72         tui_set_reverse_mode instead of setting A_STANDOUT.
  73         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  74         New setter methods.
  75
  76 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  77
  78         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  79         Handle tabs.
  80
  81 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  82
  83         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  84         tui_refill_source_window instead of tui_refresh_win, to update the
  85         current execution line.  This fixes redisplay of the current line
  86         when stepping through the code with "next" or "step".
  87
  88 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  89
  90         * source-cache.c (source_cache::get_source_lines): Call
  91         find_source_lines to initialize s->nlines.  This fixes vertical
  92         scrolling of TUI source window when the DOWN arrow is pressed.
  93
  94 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  95
  96         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  97         wclrtoeol in tui_show_source_line".  This reverts changes made in
  98         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  99
 100 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 101
 102         * NEWS: Combine separate "New targets" sections for 8.3.
 103
 104 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 105
 106         The MS-Windows port of ncurses fails to switch to a color pair if
 107         one or both of the colors are the implicit default colors.  This
 108         change records the default colors when TUI is initialized, and
 109         then specifies them explicitly when a color pair uses the default
 110         colors.  This allows color styling in TUI mode on MS-Windows.
 111
 112         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 113         ncurses_norm_attr.
 114         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 115         colors in ncurses_norm_attr.
 116         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 117         "none", replace it with the default color recorded in
 118         ncurses_norm_attr.
 119
 120 2019-03-14  Tom Tromey  <tromey@adacore.com>
 121
 122         * source-cache.h (class source_cache) <get_source_lines>: Return
 123         std::string.
 124         * source-cache.c (source_cache::extract_lines): Handle case where
 125         first_pos==npos.  Return std::string.
 126         (source_cache::get_source_lines): Update.
 127
 128 2019-03-14  Tom Tromey  <tromey@adacore.com>
 129
 130         * NEWS: Add item for "style sources" commands.
 131         * source-cache.c (source_cache::get_source_lines): Check
 132         source_styling.
 133         * cli/cli-style.c (source_styling): New global.
 134         (_initialize_cli_style): Add "style sources" commands.
 135         (show_style_sources): New function.
 136         * cli/cli-style.h (source_styling): Declare.
 137
 138 2019-03-14  Pedro Alves  <palves@redhat.com>
 139             Tom Tromey  <tromey@adacore.com>
 140
 141         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 142         * tui/tui-winsource.c (tui_refill_source_window): New function,
 143         from...
 144         (tui_horizontal_source_scroll): ... here.  Move some logic.
 145         * cli/cli-style.c (set_style_enabled): Notify new observable.
 146         * tui/tui-hooks.c (tui_redisplay_source): New function.
 147         (tui_attach_detach_observers): Attach or detach
 148         tui_redisplay_source.
 149         * observable.h (source_styling_changed): New observable.
 150         * observable.c: Define source_styling_changed observable.
 151
 152 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 153
 154         PR/24325
 155         * source-cache.c: #undef open and close, to avoid unresolved
 156         externals during linking.
 157
 158 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 159
 160         Support styling on native MS-Windows console
 161
 162         PR/24315
 163         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 164         on MS-Windows if $TERM is not defined.
 165
 166         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 167
 168         * posix-hdep.c (gdb_console_fputs):
 169         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 170         functions.
 171         * ui-file.h (gdb_console_fputs): Add prototype.
 172
 173         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 174         back to fputs only if the former returns zero.
 175
 176 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 177             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 178
 179         PR gdb/8527
 180         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 181         set_sigint_trap, clear_sigint_trap.
 182
 183 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 184
 185         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 186         for-loop range, to avoid compiler warnings.
 187
 188         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 189         avoid compiler warnings about unused variables.
 190
 191 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 192
 193         * NEWS: Mention end of support for native debugging on MS-Windows
 194         before XP.
 195
 196 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 197
 198         PR gdb/24292
 199         * common/netstuff.c:
 200         * gdbserver/gdbreplay.c
 201         * gdbserver/remote-utils.c:
 202         * ser-tcp.c:
 203         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 204         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 205         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 206         'getaddrinfo' and 'freeaddrinfo' were not available before
 207         Windows XP, and mingw.org's MinGW headers by default define
 208         _WIN32_WINNT to 0x500.
 209
 210 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 211
 212         * NEWS: Note minimum Python version.
 213
 214 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 215
 216         * version.in: Set GDB version number to 8.2.90.DATE-git.
 217
 218 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 219
 220         GDB 8.2.90 released.
 221
 222 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 223
 224         * version.in: Set GDB version number to 8.2.90.
 225
 226 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 227
 228         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 229
 230 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 231
 232         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 233         * version.in: Bump version to 8.2.90.DATE-git.
 234
 235 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 236
 237         * aix-thread.c (ptid_cmp): Remove unused variable.
 238         (get_signaled_thread): Likewise.
 239         (store_regs_user_thread): Likewise.
 240         (store_regs_kernel_thread): Likewise.
 241         (fetch_regs_kernel_thread): Remove shadowed variable.
 242
 243 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 244
 245         * features/riscv/32bit-cpu.xml: Add register numbers.
 246         * features/riscv/32bit-fpu.c: Regenerate.
 247         * features/riscv/32bit-fpu.xml: Add register numbers.
 248         * features/riscv/64bit-cpu.xml: Add register numbers.
 249         * features/riscv/64bit-fpu.c: Regenerate.
 250         * features/riscv/64bit-fpu.xml: Add register numbers.
 251
 252 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 253
 254         * NEWS: Mention two argument form of gdb.Value constructor.
 255         * python/py-value.c (convert_buffer_and_type_to_value): New
 256         function.
 257         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 258         Add support for handling an optional second argument.  Call
 259         convert_buffer_and_type_to_value as appropriate.
 260         * python/python-internal.h (Py_buffer_deleter): New struct.
 261         (Py_buffer_up): New typedef.
 262
 263 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 264
 265         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 266         instead of releasing ownership.
 267
 268 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 269
 270         * dwarf2read.c (open_and_init_dwp_file): Call
 271         elf_numsections instead of bfd_count_sections to initialize
 272         dwp_file->num_sections.
 273
 274 2019-02-25  Tom Tromey  <tromey@adacore.com>
 275
 276         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 277
 278 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 279
 280         * gcore.in: Add '--readnever' option when invoking GDB.
 281
 282 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 283
 284         * MAINTAINERS: Update my email address.
 285
 286 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 287
 288         * build-id.c (build_id_to_debug_bfd_1): New function.
 289         (build_id_to_debug_bfd): Look for separate debug file in
 290         sysroot.
 291
 292 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 293
 294         * gdbarch.sh: Update the copyright year range that is placed into
 295         generated files.
 296
 297 2019-02-22  Keith Seitz  <keiths@redhat.com>
 298
 299         PR symtab/23853
 300         * linespec.c (create_sals_line_offset): Search for the default
 301         symtab's filename instead of its fullname.
 302
 303 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 304
 305         * NEWS: Update style defaults.
 306
 307 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 308
 309         * main.c (captured_main_1): Disable styling in batch mode.
 310
 311 2019-02-20  Tom Tromey  <tom@tromey.com>
 312
 313         * symtab.c (symtab_symbol_info): Fix typos.
 314
 315 2019-02-20  Tom Tromey  <tromey@adacore.com>
 316
 317         * findcmd.c (_initialize_mem_search): Use upper case for
 318         metasyntactic variables.
 319
 320 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 321
 322         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 323         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 324
 325 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 326
 327         * top.h (source_file_name): Change to std::string.
 328         * top.c (source_file_name): Likewise.
 329         (command_line_input): Adjust.
 330         * cli/cli-script.c (script_from_file): Adjust.
 331
 332 2019-02-19  Tom Tromey  <tromey@adacore.com>
 333
 334         * ravenscar-thread.c
 335         (ravenscar_thread_target::update_thread_list): Don't call
 336         ada_build_task_list.
 337         * ada-lang.h (ada_build_task_list): Don't declare.
 338         * ada-tasks.c (struct ada_tasks_inferior_data)
 339         <task_list_valid_p>: Now bool.
 340         (read_known_tasks, ada_task_list_changed)
 341         (ada_tasks_invalidate_inferior_data): Update.
 342         (read_known_tasks_array): Return bool.
 343         (read_known_tasks_list): Likewise.
 344         (read_known_tasks): Return void.
 345         (ada_build_task_list): Now static.
 346
 347 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 348
 349         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 350         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 351
 352 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 353
 354         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 355         variant for ada_tasks_pspace_data_handle and
 356         ada_tasks_inferior_data_handle.
 357         (ada_tasks_pspace_data_cleanup): New function.
 358         (ada_tasks_inferior_data_cleanup): New function.
 359
 360 2019-02-17  Tom Tromey  <tom@tromey.com>
 361
 362         * macrotab.h (macro_source_fullname): Return a std::string.
 363         * macrotab.c (macro_include, check_for_redefinition)
 364         (macro_undef, macro_lookup_definition, foreach_macro)
 365         (foreach_macro_in_scope): Update.
 366         (macro_source_fullname): Return a std::string.
 367         * macrocmd.c (show_pp_source_pos): Update.
 368
 369 2019-02-17  Tom Tromey  <tom@tromey.com>
 370
 371         * macrocmd.c (show_pp_source_pos): Style the file names.
 372
 373 2019-02-17  Tom Tromey  <tom@tromey.com>
 374
 375         PR tui/24197:
 376         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 377
 378 2019-02-17  Tom Tromey  <tom@tromey.com>
 379
 380         * ada-lang.c (user_select_syms): Use filtered printing.
 381         * utils.c (wrap_style): New global.
 382         (desired_style): Remove.
 383         (emit_style_escape): Add stream parameter.
 384         (set_output_style, reset_terminal_style, prompt_for_continue):
 385         Update.
 386         (flush_wrap_buffer): Only flush gdb_stdout.
 387         (wrap_here): Set wrap_style.
 388         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 389         treat escape sequences as a character.  Change when wrap buffer is
 390         flushed.
 391         (fputs_styled): Do not set the output style when the default is
 392         requested.
 393         * ui-style.h (struct ui_file_style) <is_default>: New method.
 394         * source.c (print_source_lines_base): Emit escape sequences in one
 395         piece.
 396
 397 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 398
 399         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 400         integers and enumeration types.
 401
 402 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 403
 404         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 405         instead of lookup_symbol_in_language
 406         (do_exact_match): New function.
 407         (ada_get_symbol_name_matcher): Return do_exact_match when
 408         doing a verbatim match.
 409
 410 2019-02-15  Tom Tromey  <tromey@adacore.com>
 411
 412         * ravenscar-thread.c (ravenscar_thread_target::resume)
 413         (ravenscar_thread_target::wait): Special case wildcard requests.
 414
 415 2019-02-15  Tom Tromey  <tromey@adacore.com>
 416
 417         * ravenscar-thread.c (base_ptid): Remove.
 418         (struct ravenscar_thread_target) <close>: New method.
 419         <m_base_ptid>: New member.
 420         <update_inferior_ptid, active_task, task_is_currently_active,
 421         runtime_initialized>: Declare methods.
 422         <ravenscar_thread_target>: Add constructor.
 423         (ravenscar_thread_target::task_is_currently_active)
 424         (ravenscar_thread_target::update_inferior_ptid)
 425         (ravenscar_runtime_initialized): Rename.  Now methods.
 426         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 427         (ravenscar_thread_target::update_thread_list): Update.
 428         (ravenscar_thread_target::active_task): Now method.
 429         (ravenscar_thread_target::store_registers)
 430         (ravenscar_thread_target::prepare_to_store)
 431         (ravenscar_thread_target::prepare_to_store)
 432         (ravenscar_thread_target::mourn_inferior): Update.
 433         (ravenscar_inferior_created): Use "new" to create target.
 434         (ravenscar_thread_target::get_ada_task_ptid): Update.
 435         (_initialize_ravenscar): Don't initialize base_ptid.
 436         (ravenscar_ops): Remove global.
 437
 438 2019-02-15  Tom Tromey  <tromey@adacore.com>
 439
 440         * target.h (push_target): Declare new overload.
 441         * target.c (push_target): New overload, taking an rvalue reference.
 442         * remote.c (remote_target::open_1): Use push_target overload.
 443         * corelow.c (core_target_open): Use push_target overload.
 444
 445 2019-02-15  Tom Tromey  <tromey@adacore.com>
 446
 447         * ravenscar-thread.c (is_ravenscar_task)
 448         (ravenscar_task_is_currently_active): Return bool.
 449         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 450         (_initialize_ravenscar): Remove "(void)".
 451         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 452         Return bool.
 453
 454 2019-02-15  Tom Tromey  <tromey@adacore.com>
 455
 456         * ravenscar-thread.c (ravenscar_runtime_initializer)
 457         (has_ravenscar_runtime, get_running_thread_id)
 458         (ravenscar_thread_target::resume): Fix indentation.
 459
 460 2019-02-15  Tom Tromey  <tromey@adacore.com>
 461
 462         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 463         from ravenscar_arch_ops.
 464         (sparc_ravenscar_ops::fetch_registers)
 465         (sparc_ravenscar_ops::store_registers): Now methods.
 466         (sparc_ravenscar_prepare_to_store): Remove.
 467         (sparc_ravenscar_ops): Redefine.
 468         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 469         methods and destructor.  Remove members.
 470         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 471         (ravenscar_thread_target::store_registers)
 472         (ravenscar_thread_target::prepare_to_store): Update.
 473         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 474         Remove.
 475         (struct ppc_ravenscar_powerpc_ops): Derive from
 476         ravenscar_arch_ops.
 477         (ppc_ravenscar_powerpc_ops::fetch_registers)
 478         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 479         (ppc_ravenscar_powerpc_ops): Redefine.
 480         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 481         (ppc_ravenscar_e500_ops::fetch_registers)
 482         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 483         (ppc_ravenscar_e500_ops): Redefine.
 484         * aarch64-ravenscar-thread.c
 485         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 486         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 487         (aarch64_ravenscar_fetch_registers)
 488         (aarch64_ravenscar_store_registers): Now methods.
 489         (aarch64_ravenscar_ops): Redefine.
 490
 491 2019-02-15  Tom Tromey  <tromey@adacore.com>
 492
 493         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 494         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 495         (ravenscar_thread_target::stopped_by_watchpoint)
 496         (ravenscar_thread_target::stopped_data_address)
 497         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 498
 499 2019-02-15  Tom Tromey  <tromey@adacore.com>
 500
 501         * ravenscar-thread.c: Fix some typos.
 502
 503 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 504             Tom Tromey  <tromey@adacore.com>
 505
 506         * ada-lang.c (ada_exception_sal): Change addr_string to a
 507         std::string.
 508         (create_ada_exception_catchpoint): Update.
 509
 510 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 511             Tom Tromey  <tromey@adacore.com>
 512
 513         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 514         (bp_location_ops): Remove.
 515         (base_breakpoint_allocate_location): Update.
 516         (free_bp_location): Update.
 517         * ada-lang.c (class ada_catchpoint_location)
 518         <ada_catchpoint_location>: Remove ops parameter.
 519         (ada_catchpoint_location_dtor): Remove.
 520         (ada_catchpoint_location_ops): Remove.
 521         (allocate_location_exception): Update.
 522         * breakpoint.h (struct bp_location_ops): Remove.
 523         (class bp_location) <bp_location>: Remove bp_location_ops
 524         parameter.
 525         <~bp_location>: Add destructor.
 526         <ops>: Remove.
 527
 528 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 529             Pedro Alves  <palves@redhat.com>
 530
 531         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 532         'PATH_MAX'.
 533
 534 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 535             Samuel Thibault  <samuel.thibault@gnu.org>
 536             Thomas Schwinge  <thomas@codesourcery.com>
 537
 538         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 539         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 540
 541 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 542
 543         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 544         (check_empty): Use "const char *".
 545
 546         * gnu-nat.c (gnu_nat_target::detach): Instead of
 547         'detach_inferior (pid)' call
 548         'detach_inferior (find_inferior_pid (pid))'.
 549
 550         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 551         'nat/fork-inferior.o'.
 552         * gnu-nat.c: #include "nat/fork-inferior.h".
 553
 554         * gnu-nat.c (gnu_nat_target::detach): Instead of
 555         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 556         * gnu-nat.h: #include "inf-child.h".
 557         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 558         'i386_gnu_nat_target::fetch_registers'.
 559         (gnu_store_registers): Rename/move to
 560         'i386_gnu_nat_target::store_registers'.
 561
 562         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 563         * gnu-nat.h (mach_thread_info): New function.
 564         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 565
 566         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 567
 568 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 569
 570         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 571
 572 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 573
 574         * windows-nat.c (windows_add_thread): Add new parameter
 575         "main_thread_p" with default value set to false.  Update
 576         function documentation as well as all callers.
 577         (windows_delete_thread): Likewise.
 578         (fake_create_process): Update call to windows_add_thread.
 579         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 580         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 581         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 582         call to windows_delete_thread.
 583
 584 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 585
 586         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 587
 588 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 589
 590         * symfile.c (find_separate_debug_file): Use canonical path of
 591         sysroot with child_path instead of gdb_sysroot if it is valid.
 592
 593 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 594
 595         * symfile.c (find_separate_debug_file): Use child_path to
 596         determine if an object file is under a sysroot.
 597
 598 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 599
 600         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 601         unittests/child-path-selftests.c.
 602         * common/pathstuff.c (child_path): New function.
 603         * common/pathstuff.h (child_path): New prototype.
 604         * unittests/child-path-selftests.c: New file.
 605
 606 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 607
 608         * symfile.c (find_separate_debug_file): Look for separate debug
 609         files in debug directories under the sysroot.
 610
 611 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 612
 613         * symtab.h (struct minimal_symbol data_p): New const method.
 614         (struct minimal_symbol text_p): Likewise.
 615         * symtab.c (output_source_filename): Use file name style
 616         to print file name.
 617         (print_symbol_info): Likewise.
 618         (print_msymbol_info): Use address style to print addresses.
 619         Use function name style to print executable text symbols.
 620         (expand_symtab_containing_pc): Use data_p.
 621         (find_pc_sect_compunit_symtab): Likewise.
 622
 623 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 624
 625         * breakpoint.c (describe_other_breakpoints): Use address style
 626         to print addresses.
 627         (say_where): Likewise.
 628
 629 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 630
 631         * ada-typeprint.c (print_func_type): Print function name
 632         style to print function name.
 633         * c-typeprint.c (c_print_type_1): Likewise.
 634
 635 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 636
 637         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 638         for execve.
 639
 640 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 641
 642         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 643         type_stack.
 644
 645 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 646
 647         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 648         TYPE_CODE_REF types.
 649
 650 2019-02-08  Jim Wilson  <jimw@sifive.com>
 651
 652         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 653         (riscv_linux_fregset): New.
 654         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 655
 656 2019-02-07  Tom Tromey  <tom@tromey.com>
 657
 658         * thread.c (thread_cancel_execution_command): Update.
 659         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 660         methods.
 661         (struct thread_fsm_ops): Remove.
 662         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 663         (thread_fsm_should_stop, thread_fsm_return_value)
 664         (thread_fsm_set_finished, thread_fsm_finished_p)
 665         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 666         Don't declare.
 667         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 668         * infrun.c (clear_proceed_status_thread)
 669         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 670         (print_stop_event): Update.
 671         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 672         Add constructor.
 673         (step_command_fsm_ops): Remove.
 674         (new_step_command_fsm): Remove.
 675         (step_1): Update.
 676         (step_command_fsm::should_stop): Rename from
 677         step_command_fsm_should_stop.
 678         (step_command_fsm::clean_up): Rename from
 679         step_command_fsm_clean_up.
 680         (step_command_fsm::do_async_reply_reason): Rename from
 681         step_command_fsm_async_reply_reason.
 682         (struct until_next_fsm): Inherit from thread_fsm.  Add
 683         constructor.
 684         (until_next_fsm_ops): Remove.
 685         (new_until_next_fsm): Remove.
 686         (until_next_fsm::should_stop): Rename from
 687         until_next_fsm_should_stop.
 688         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 689         (until_next_fsm::do_async_reply_reason): Rename from
 690         until_next_fsm_async_reply_reason.
 691         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 692         constructor.  Change type of breakpoint.
 693         (finish_command_fsm_ops): Remove.
 694         (new_finish_command_fsm): Remove.
 695         (finish_command_fsm::should_stop): Rename from
 696         finish_command_fsm_should_stop.
 697         (finish_command_fsm::clean_up): Rename from
 698         finish_command_fsm_clean_up.
 699         (finish_command_fsm::return_value): Rename from
 700         finish_command_fsm_return_value.
 701         (finish_command_fsm::do_async_reply_reason): Rename from
 702         finish_command_fsm_async_reply_reason.
 703         (finish_command): Update.
 704         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 705         Add constructor.
 706         (call_thread_fsm_ops): Remove.
 707         (call_thread_fsm::call_thread_fsm): Rename from
 708         new_call_thread_fsm.
 709         (call_thread_fsm::should_stop): Rename from
 710         call_thread_fsm_should_stop.
 711         (call_thread_fsm::should_notify_stop): Rename from
 712         call_thread_fsm_should_notify_stop.
 713         (run_inferior_call, call_function_by_hand_dummy): Update.
 714         * cli/cli-interp.c (should_print_stop_to_console): Update.
 715         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 716         Add constructor.  Change type of location_breakpoint,
 717         caller_breakpoint.
 718         (until_break_fsm_ops): Remove.
 719         (new_until_break_fsm): Remove.
 720         (until_break_fsm::should_stop): Rename from
 721         until_break_fsm_should_stop.
 722         (until_break_fsm::clean_up): Rename from
 723         until_break_fsm_clean_up.
 724         (until_break_fsm::do_async_reply_reason): Rename from
 725         until_break_fsm_async_reply_reason.
 726         (until_break_command): Update.
 727         * thread-fsm.c: Remove.
 728         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 729
 730 2019-02-07  Tom Tromey  <tom@tromey.com>
 731
 732         * yy-remap.h: Add include guard.
 733         * xtensa-tdep.h: Add include guard.
 734         * xcoffread.h: Rename include guard.
 735         * varobj-iter.h: Add include guard.
 736         * tui/tui.h: Rename include guard.
 737         * tui/tui-winsource.h: Rename include guard.
 738         * tui/tui-wingeneral.h: Rename include guard.
 739         * tui/tui-windata.h: Rename include guard.
 740         * tui/tui-win.h: Rename include guard.
 741         * tui/tui-stack.h: Rename include guard.
 742         * tui/tui-source.h: Rename include guard.
 743         * tui/tui-regs.h: Rename include guard.
 744         * tui/tui-out.h: Rename include guard.
 745         * tui/tui-layout.h: Rename include guard.
 746         * tui/tui-io.h: Rename include guard.
 747         * tui/tui-hooks.h: Rename include guard.
 748         * tui/tui-file.h: Rename include guard.
 749         * tui/tui-disasm.h: Rename include guard.
 750         * tui/tui-data.h: Rename include guard.
 751         * tui/tui-command.h: Rename include guard.
 752         * tic6x-tdep.h: Add include guard.
 753         * target/waitstatus.h: Rename include guard.
 754         * target/wait.h: Rename include guard.
 755         * target/target.h: Rename include guard.
 756         * target/resume.h: Rename include guard.
 757         * target-float.h: Rename include guard.
 758         * stabsread.h: Add include guard.
 759         * rs6000-tdep.h: Add include guard.
 760         * riscv-fbsd-tdep.h: Add include guard.
 761         * regformats/regdef.h: Rename include guard.
 762         * record.h: Rename include guard.
 763         * python/python.h: Rename include guard.
 764         * python/python-internal.h: Rename include guard.
 765         * python/py-stopevent.h: Rename include guard.
 766         * python/py-ref.h: Rename include guard.
 767         * python/py-record.h: Rename include guard.
 768         * python/py-record-full.h: Rename include guard.
 769         * python/py-record-btrace.h: Rename include guard.
 770         * python/py-instruction.h: Rename include guard.
 771         * python/py-events.h: Rename include guard.
 772         * python/py-event.h: Rename include guard.
 773         * procfs.h: Add include guard.
 774         * proc-utils.h: Add include guard.
 775         * p-lang.h: Add include guard.
 776         * or1k-tdep.h: Rename include guard.
 777         * observable.h: Rename include guard.
 778         * nto-tdep.h: Rename include guard.
 779         * nat/x86-linux.h: Rename include guard.
 780         * nat/x86-linux-dregs.h: Rename include guard.
 781         * nat/x86-gcc-cpuid.h: Add include guard.
 782         * nat/x86-dregs.h: Rename include guard.
 783         * nat/x86-cpuid.h: Rename include guard.
 784         * nat/ppc-linux.h: Rename include guard.
 785         * nat/mips-linux-watch.h: Rename include guard.
 786         * nat/linux-waitpid.h: Rename include guard.
 787         * nat/linux-ptrace.h: Rename include guard.
 788         * nat/linux-procfs.h: Rename include guard.
 789         * nat/linux-osdata.h: Rename include guard.
 790         * nat/linux-nat.h: Rename include guard.
 791         * nat/linux-namespaces.h: Rename include guard.
 792         * nat/linux-btrace.h: Rename include guard.
 793         * nat/glibc_thread_db.h: Rename include guard.
 794         * nat/gdb_thread_db.h: Rename include guard.
 795         * nat/gdb_ptrace.h: Rename include guard.
 796         * nat/fork-inferior.h: Rename include guard.
 797         * nat/amd64-linux-siginfo.h: Rename include guard.
 798         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 799         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 800         * nat/aarch64-linux.h: Rename include guard.
 801         * nat/aarch64-linux-hw-point.h: Rename include guard.
 802         * mn10300-tdep.h: Add include guard.
 803         * mips-linux-tdep.h: Add include guard.
 804         * mi/mi-parse.h: Rename include guard.
 805         * mi/mi-out.h: Rename include guard.
 806         * mi/mi-main.h: Rename include guard.
 807         * mi/mi-interp.h: Rename include guard.
 808         * mi/mi-getopt.h: Rename include guard.
 809         * mi/mi-console.h: Rename include guard.
 810         * mi/mi-common.h: Rename include guard.
 811         * mi/mi-cmds.h: Rename include guard.
 812         * mi/mi-cmd-break.h: Rename include guard.
 813         * m2-lang.h: Add include guard.
 814         * location.h: Rename include guard.
 815         * linux-record.h: Rename include guard.
 816         * linux-nat.h: Add include guard.
 817         * linux-fork.h: Add include guard.
 818         * i386-darwin-tdep.h: Rename include guard.
 819         * hppa-linux-offsets.h: Add include guard.
 820         * guile/guile.h: Rename include guard.
 821         * guile/guile-internal.h: Rename include guard.
 822         * gnu-nat.h: Rename include guard.
 823         * gdb-stabs.h: Rename include guard.
 824         * frv-tdep.h: Add include guard.
 825         * f-lang.h: Add include guard.
 826         * event-loop.h: Add include guard.
 827         * darwin-nat.h: Rename include guard.
 828         * cp-abi.h: Rename include guard.
 829         * config/sparc/nm-sol2.h: Rename include guard.
 830         * config/nm-nto.h: Rename include guard.
 831         * config/nm-linux.h: Add include guard.
 832         * config/i386/nm-i386gnu.h: Rename include guard.
 833         * config/djgpp/nl_types.h: Rename include guard.
 834         * config/djgpp/langinfo.h: Rename include guard.
 835         * compile/gcc-cp-plugin.h: Add include guard.
 836         * compile/gcc-c-plugin.h: Add include guard.
 837         * compile/compile.h: Rename include guard.
 838         * compile/compile-object-run.h: Rename include guard.
 839         * compile/compile-object-load.h: Rename include guard.
 840         * compile/compile-internal.h: Rename include guard.
 841         * compile/compile-cplus.h: Rename include guard.
 842         * compile/compile-c.h: Rename include guard.
 843         * common/xml-utils.h: Rename include guard.
 844         * common/x86-xstate.h: Rename include guard.
 845         * common/version.h: Rename include guard.
 846         * common/vec.h: Rename include guard.
 847         * common/tdesc.h: Rename include guard.
 848         * common/selftest.h: Rename include guard.
 849         * common/scoped_restore.h: Rename include guard.
 850         * common/scoped_mmap.h: Rename include guard.
 851         * common/scoped_fd.h: Rename include guard.
 852         * common/safe-iterator.h: Rename include guard.
 853         * common/run-time-clock.h: Rename include guard.
 854         * common/refcounted-object.h: Rename include guard.
 855         * common/queue.h: Rename include guard.
 856         * common/ptid.h: Rename include guard.
 857         * common/print-utils.h: Rename include guard.
 858         * common/preprocessor.h: Rename include guard.
 859         * common/pathstuff.h: Rename include guard.
 860         * common/observable.h: Rename include guard.
 861         * common/netstuff.h: Rename include guard.
 862         * common/job-control.h: Rename include guard.
 863         * common/host-defs.h: Rename include guard.
 864         * common/gdb_wait.h: Rename include guard.
 865         * common/gdb_vecs.h: Rename include guard.
 866         * common/gdb_unlinker.h: Rename include guard.
 867         * common/gdb_unique_ptr.h: Rename include guard.
 868         * common/gdb_tilde_expand.h: Rename include guard.
 869         * common/gdb_sys_time.h: Rename include guard.
 870         * common/gdb_string_view.h: Rename include guard.
 871         * common/gdb_splay_tree.h: Rename include guard.
 872         * common/gdb_setjmp.h: Rename include guard.
 873         * common/gdb_ref_ptr.h: Rename include guard.
 874         * common/gdb_optional.h: Rename include guard.
 875         * common/gdb_locale.h: Rename include guard.
 876         * common/gdb_assert.h: Rename include guard.
 877         * common/filtered-iterator.h: Rename include guard.
 878         * common/filestuff.h: Rename include guard.
 879         * common/fileio.h: Rename include guard.
 880         * common/environ.h: Rename include guard.
 881         * common/common-utils.h: Rename include guard.
 882         * common/common-types.h: Rename include guard.
 883         * common/common-regcache.h: Rename include guard.
 884         * common/common-inferior.h: Rename include guard.
 885         * common/common-gdbthread.h: Rename include guard.
 886         * common/common-exceptions.h: Rename include guard.
 887         * common/common-defs.h: Rename include guard.
 888         * common/common-debug.h: Rename include guard.
 889         * common/cleanups.h: Rename include guard.
 890         * common/buffer.h: Rename include guard.
 891         * common/btrace-common.h: Rename include guard.
 892         * common/break-common.h: Rename include guard.
 893         * cli/cli-utils.h: Rename include guard.
 894         * cli/cli-style.h: Rename include guard.
 895         * cli/cli-setshow.h: Rename include guard.
 896         * cli/cli-script.h: Rename include guard.
 897         * cli/cli-interp.h: Rename include guard.
 898         * cli/cli-decode.h: Rename include guard.
 899         * cli/cli-cmds.h: Rename include guard.
 900         * charset-list.h: Add include guard.
 901         * buildsym-legacy.h: Rename include guard.
 902         * bfin-tdep.h: Add include guard.
 903         * ax.h: Rename include guard.
 904         * arm-linux-tdep.h: Add include guard.
 905         * arm-fbsd-tdep.h: Add include guard.
 906         * arch/xtensa.h: Rename include guard.
 907         * arch/tic6x.h: Add include guard.
 908         * arch/i386.h: Add include guard.
 909         * arch/arm.h: Rename include guard.
 910         * arch/arm-linux.h: Rename include guard.
 911         * arch/arm-get-next-pcs.h: Rename include guard.
 912         * arch/amd64.h: Add include guard.
 913         * arch/aarch64-insn.h: Rename include guard.
 914         * arch-utils.h: Rename include guard.
 915         * annotate.h: Add include guard.
 916         * amd64-darwin-tdep.h: Rename include guard.
 917         * aarch64-linux-tdep.h: Add include guard.
 918         * aarch64-fbsd-tdep.h: Add include guard.
 919         * aarch32-linux-nat.h: Add include guard.
 920
 921 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 922
 923         * macrotab.c (macro_define_internal): New function that
 924         factorizes macro_define_object_internal and macro_define_function
 925         code.
 926         (macro_define_object_internal): Use macro_define_internal.
 927         (macro_define_function): Likewise.
 928
 929 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 930
 931         * macrocmd.c (extract_identifier): Return
 932         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 933         callers.
 934
 935 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 936
 937         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 938
 939 2019-02-05  Tom Tromey  <tom@tromey.com>
 940
 941         * target.c (target_stack::unpush): Move assertion earlier.
 942
 943 2019-01-30  Tom Tromey  <tom@tromey.com>
 944
 945         PR python/23615:
 946         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 947         (gdbpy_parse_and_eval): Likewise.
 948         * python/python-internal.h (gdbpy_allow_threads): New class.
 949
 950 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 951
 952         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 953         (aarch64_fbsd_fpregmap): Move earlier.
 954         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 955         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 956         instead of individual calls to trad_frame_set_reg_addr.
 957         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 958         earlier.
 959         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 960         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 961         instead of individual calls to trad_frame_set_reg_addr.
 962
 963 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 964
 965         * CONTRIBUTE: Replace contribution list with wiki link.
 966
 967 2019-01-25  Tom Tromey  <tom@tromey.com>
 968
 969         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 970
 971 2019-01-25  Tom Tromey  <tom@tromey.com>
 972
 973         * xtensa-linux-nat.c: Fix common/ includes.
 974         * xml-support.h: Fix common/ includes.
 975         * xml-support.c: Fix common/ includes.
 976         * x86-linux-nat.c: Fix common/ includes.
 977         * windows-nat.c: Fix common/ includes.
 978         * varobj.h: Fix common/ includes.
 979         * varobj.c: Fix common/ includes.
 980         * value.c: Fix common/ includes.
 981         * valops.c: Fix common/ includes.
 982         * utils.c: Fix common/ includes.
 983         * unittests/xml-utils-selftests.c: Fix common/ includes.
 984         * unittests/utils-selftests.c: Fix common/ includes.
 985         * unittests/unpack-selftests.c: Fix common/ includes.
 986         * unittests/tracepoint-selftests.c: Fix common/ includes.
 987         * unittests/style-selftests.c: Fix common/ includes.
 988         * unittests/string_view-selftests.c: Fix common/ includes.
 989         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 990         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 991         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 992         * unittests/rsp-low-selftests.c: Fix common/ includes.
 993         * unittests/parse-connection-spec-selftests.c: Fix common/
 994         includes.
 995         * unittests/optional-selftests.c: Fix common/ includes.
 996         * unittests/offset-type-selftests.c: Fix common/ includes.
 997         * unittests/observable-selftests.c: Fix common/ includes.
 998         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 999         * unittests/memrange-selftests.c: Fix common/ includes.
1000         * unittests/memory-map-selftests.c: Fix common/ includes.
1001         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1002         * unittests/function-view-selftests.c: Fix common/ includes.
1003         * unittests/environ-selftests.c: Fix common/ includes.
1004         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1005         * unittests/common-utils-selftests.c: Fix common/ includes.
1006         * unittests/cli-utils-selftests.c: Fix common/ includes.
1007         * unittests/array-view-selftests.c: Fix common/ includes.
1008         * ui-file.c: Fix common/ includes.
1009         * tui/tui-io.c: Fix common/ includes.
1010         * tracepoint.h: Fix common/ includes.
1011         * tracepoint.c: Fix common/ includes.
1012         * tracefile-tfile.c: Fix common/ includes.
1013         * top.h: Fix common/ includes.
1014         * top.c: Fix common/ includes.
1015         * thread.c: Fix common/ includes.
1016         * target/waitstatus.h: Fix common/ includes.
1017         * target/waitstatus.c: Fix common/ includes.
1018         * target.h: Fix common/ includes.
1019         * target.c: Fix common/ includes.
1020         * target-memory.c: Fix common/ includes.
1021         * target-descriptions.c: Fix common/ includes.
1022         * symtab.h: Fix common/ includes.
1023         * symfile.c: Fix common/ includes.
1024         * stap-probe.c: Fix common/ includes.
1025         * spu-linux-nat.c: Fix common/ includes.
1026         * sparc-nat.c: Fix common/ includes.
1027         * source.c: Fix common/ includes.
1028         * solib.c: Fix common/ includes.
1029         * solib-target.c: Fix common/ includes.
1030         * ser-unix.c: Fix common/ includes.
1031         * ser-tcp.c: Fix common/ includes.
1032         * ser-pipe.c: Fix common/ includes.
1033         * ser-base.c: Fix common/ includes.
1034         * selftest-arch.c: Fix common/ includes.
1035         * s12z-tdep.c: Fix common/ includes.
1036         * rust-exp.y: Fix common/ includes.
1037         * rs6000-aix-tdep.c: Fix common/ includes.
1038         * riscv-tdep.c: Fix common/ includes.
1039         * remote.c: Fix common/ includes.
1040         * remote-notif.h: Fix common/ includes.
1041         * remote-fileio.h: Fix common/ includes.
1042         * remote-fileio.c: Fix common/ includes.
1043         * regcache.h: Fix common/ includes.
1044         * regcache.c: Fix common/ includes.
1045         * record-btrace.c: Fix common/ includes.
1046         * python/python.c: Fix common/ includes.
1047         * python/py-type.c: Fix common/ includes.
1048         * python/py-inferior.c: Fix common/ includes.
1049         * progspace.h: Fix common/ includes.
1050         * producer.c: Fix common/ includes.
1051         * procfs.c: Fix common/ includes.
1052         * proc-api.c: Fix common/ includes.
1053         * printcmd.c: Fix common/ includes.
1054         * ppc-linux-nat.c: Fix common/ includes.
1055         * parser-defs.h: Fix common/ includes.
1056         * osdata.c: Fix common/ includes.
1057         * obsd-nat.c: Fix common/ includes.
1058         * nat/x86-linux.c: Fix common/ includes.
1059         * nat/x86-linux-dregs.c: Fix common/ includes.
1060         * nat/x86-dregs.h: Fix common/ includes.
1061         * nat/x86-dregs.c: Fix common/ includes.
1062         * nat/ppc-linux.c: Fix common/ includes.
1063         * nat/mips-linux-watch.h: Fix common/ includes.
1064         * nat/mips-linux-watch.c: Fix common/ includes.
1065         * nat/linux-waitpid.c: Fix common/ includes.
1066         * nat/linux-ptrace.h: Fix common/ includes.
1067         * nat/linux-ptrace.c: Fix common/ includes.
1068         * nat/linux-procfs.c: Fix common/ includes.
1069         * nat/linux-personality.c: Fix common/ includes.
1070         * nat/linux-osdata.c: Fix common/ includes.
1071         * nat/linux-namespaces.c: Fix common/ includes.
1072         * nat/linux-btrace.h: Fix common/ includes.
1073         * nat/linux-btrace.c: Fix common/ includes.
1074         * nat/fork-inferior.c: Fix common/ includes.
1075         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1076         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1077         * nat/aarch64-linux.c: Fix common/ includes.
1078         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1079         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1080         * namespace.h: Fix common/ includes.
1081         * mips-linux-tdep.c: Fix common/ includes.
1082         * minsyms.c: Fix common/ includes.
1083         * mi/mi-parse.h: Fix common/ includes.
1084         * mi/mi-main.c: Fix common/ includes.
1085         * mi/mi-cmd-env.c: Fix common/ includes.
1086         * memrange.h: Fix common/ includes.
1087         * memattr.c: Fix common/ includes.
1088         * maint.h: Fix common/ includes.
1089         * maint.c: Fix common/ includes.
1090         * main.c: Fix common/ includes.
1091         * machoread.c: Fix common/ includes.
1092         * location.c: Fix common/ includes.
1093         * linux-thread-db.c: Fix common/ includes.
1094         * linux-nat.c: Fix common/ includes.
1095         * linux-fork.c: Fix common/ includes.
1096         * inline-frame.c: Fix common/ includes.
1097         * infrun.c: Fix common/ includes.
1098         * inflow.c: Fix common/ includes.
1099         * inferior.h: Fix common/ includes.
1100         * inferior.c: Fix common/ includes.
1101         * infcmd.c: Fix common/ includes.
1102         * inf-ptrace.c: Fix common/ includes.
1103         * inf-child.c: Fix common/ includes.
1104         * ia64-linux-nat.c: Fix common/ includes.
1105         * i387-tdep.c: Fix common/ includes.
1106         * i386-tdep.c: Fix common/ includes.
1107         * i386-linux-tdep.c: Fix common/ includes.
1108         * i386-linux-nat.c: Fix common/ includes.
1109         * i386-go32-tdep.c: Fix common/ includes.
1110         * i386-fbsd-tdep.c: Fix common/ includes.
1111         * i386-fbsd-nat.c: Fix common/ includes.
1112         * guile/scm-type.c: Fix common/ includes.
1113         * guile/guile.c: Fix common/ includes.
1114         * go32-nat.c: Fix common/ includes.
1115         * gnu-nat.c: Fix common/ includes.
1116         * gdbthread.h: Fix common/ includes.
1117         * gdbarch-selftests.c: Fix common/ includes.
1118         * gdb_usleep.c: Fix common/ includes.
1119         * gdb_select.h: Fix common/ includes.
1120         * gdb_bfd.c: Fix common/ includes.
1121         * gcore.c: Fix common/ includes.
1122         * fork-child.c: Fix common/ includes.
1123         * findvar.c: Fix common/ includes.
1124         * fbsd-nat.c: Fix common/ includes.
1125         * event-top.c: Fix common/ includes.
1126         * event-loop.c: Fix common/ includes.
1127         * dwarf2read.c: Fix common/ includes.
1128         * dwarf2loc.c: Fix common/ includes.
1129         * dwarf2-frame.c: Fix common/ includes.
1130         * dwarf-index-cache.c: Fix common/ includes.
1131         * dtrace-probe.c: Fix common/ includes.
1132         * disasm-selftests.c: Fix common/ includes.
1133         * defs.h: Fix common/ includes.
1134         * csky-tdep.c: Fix common/ includes.
1135         * cp-valprint.c: Fix common/ includes.
1136         * cp-support.h: Fix common/ includes.
1137         * cp-support.c: Fix common/ includes.
1138         * corelow.c: Fix common/ includes.
1139         * completer.h: Fix common/ includes.
1140         * completer.c: Fix common/ includes.
1141         * compile/compile.c: Fix common/ includes.
1142         * compile/compile-loc2c.c: Fix common/ includes.
1143         * compile/compile-cplus-types.c: Fix common/ includes.
1144         * compile/compile-cplus-symbols.c: Fix common/ includes.
1145         * command.h: Fix common/ includes.
1146         * cli/cli-dump.c: Fix common/ includes.
1147         * cli/cli-cmds.c: Fix common/ includes.
1148         * charset.c: Fix common/ includes.
1149         * build-id.c: Fix common/ includes.
1150         * btrace.h: Fix common/ includes.
1151         * btrace.c: Fix common/ includes.
1152         * breakpoint.h: Fix common/ includes.
1153         * breakpoint.c: Fix common/ includes.
1154         * ax.h:
1155         (enum agent_op): Fix common/ includes.
1156         * ax-general.c (struct aop_map): Fix common/ includes.
1157         * ax-gdb.c: Fix common/ includes.
1158         * auxv.c: Fix common/ includes.
1159         * auto-load.c: Fix common/ includes.
1160         * arm-tdep.c: Fix common/ includes.
1161         * arch/riscv.c: Fix common/ includes.
1162         * arch/ppc-linux-common.c: Fix common/ includes.
1163         * arch/i386.c: Fix common/ includes.
1164         * arch/arm.c: Fix common/ includes.
1165         * arch/arm-linux.c: Fix common/ includes.
1166         * arch/arm-get-next-pcs.c: Fix common/ includes.
1167         * arch/amd64.c: Fix common/ includes.
1168         * arch/aarch64.c: Fix common/ includes.
1169         * arch/aarch64-insn.c: Fix common/ includes.
1170         * arch-utils.c: Fix common/ includes.
1171         * amd64-windows-tdep.c: Fix common/ includes.
1172         * amd64-tdep.c: Fix common/ includes.
1173         * amd64-sol2-tdep.c: Fix common/ includes.
1174         * amd64-obsd-tdep.c: Fix common/ includes.
1175         * amd64-nbsd-tdep.c: Fix common/ includes.
1176         * amd64-linux-tdep.c: Fix common/ includes.
1177         * amd64-linux-nat.c: Fix common/ includes.
1178         * amd64-fbsd-tdep.c: Fix common/ includes.
1179         * amd64-fbsd-nat.c: Fix common/ includes.
1180         * amd64-dicos-tdep.c: Fix common/ includes.
1181         * amd64-darwin-tdep.c: Fix common/ includes.
1182         * agent.c: Fix common/ includes.
1183         * ada-lang.h: Fix common/ includes.
1184         * ada-lang.c: Fix common/ includes.
1185         * aarch64-tdep.c: Fix common/ includes.
1186
1187 2019-01-25  Tom Tromey  <tom@tromey.com>
1188
1189         * common/create-version.sh: Use common/version.h.
1190
1191 2019-01-24  Pedro Alves  <palves@redhat.com>
1192
1193         * infrun.c (signal_stop, signal_print, signal_program)
1194         (signal_catch, signal_pass): Now arrays instead of pointers.
1195         (update_signals_program_target, do_target_resume)
1196         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1197         * linux-nat.c (linux_nat_target::pass_signals)
1198         (linux_nat_target::create_inferior, linux_nat_target::attach):
1199         Adjust.
1200         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1201         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1202         * procfs.c (procfs_target::pass_signals): Adjust.
1203         * record-full.c (record_full_target::resume): Adjust.
1204         * remote.c (remote_target::pass_signals)
1205         (remote_target::program_signals): Adjust.
1206         * target-debug.h (target_debug_print_signals): Now takes a
1207         gdb::array_view as parameter.  Adjust.
1208         * target.h (target_ops) <pass_signals, program_signals>: Replace
1209         pointer and length parameters with gdb::array_view.
1210         (target_pass_signals, target_program_signals): Likewise.
1211         * target-delegates.c: Regenerate.
1212
1213 2019-01-24  Pedro Alves  <palves@redhat.com>
1214
1215         * common/forward-scope-exit.h
1216         (forward_scope_exit::forward_scope_exit): Pass arguments to
1217         m_bind_function directly, instead of creating a std::bind and
1218         copying that.
1219
1220 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1221
1222         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1223         for static members.
1224         (pass_in_v_vfp_candidate): Likewise.
1225
1226 2019-01-23  Tom Tromey  <tom@tromey.com>
1227             Pedro Alves  <palves@redhat.com>
1228
1229         * regcache.c (class regcache_invalidator): Remove.
1230         (regcache::raw_write): Use make_scope_exit.
1231
1232 2019-01-23  Tom Tromey  <tom@tromey.com>
1233
1234         * ui-out.h (class ui_out_emit_type): Update comment.
1235
1236 2019-01-23  Tom Tromey  <tom@tromey.com>
1237
1238         * infrun.c (fetch_inferior_event): Update comment.
1239
1240 2019-01-23  Tom Tromey  <tom@tromey.com>
1241             Pedro Alves  <palves@redhat.com>
1242
1243         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1244         parameter.
1245         (fetch_inferior_event): Use SCOPE_EXIT.
1246
1247
1248 2019-01-23  Tom Tromey  <tom@tromey.com>
1249             Pedro Alves  <palves@redhat.com>
1250
1251         * infrun.c (disable_thread_events): Delete.
1252         (stop_all_threads): Use SCOPE_EXIT.
1253
1254 2019-01-23  Tom Tromey  <tom@tromey.com>
1255             Pedro Alves  <palves@redhat.com>
1256
1257         * symfile.c: Include forward-scope-exit.h.
1258         (clear_symtab_users_cleanup): Replace forward declaration with
1259         a FORWARD_SCOPE_EXIT.
1260         (syms_from_objfile_1): Use the forward_scope_exit and
1261         gdb::optional instead of cleanup_function.
1262         (reread_symbols): Use the forward_scope_exit instead of
1263         cleanup_function.
1264         (clear_symtab_users_cleanup): Remove function.
1265
1266 2019-01-23  Tom Tromey  <tom@tromey.com>
1267             Pedro Alves  <palves@redhat.com>
1268
1269         * linux-nat.c: Include scope-exit.h.
1270         (cleanup_target_stop): Remove.
1271         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1272         SCOPE_EXIT.
1273
1274 2019-01-23  Tom Tromey  <tom@tromey.com>
1275             Pedro Alves  <palves@redhat.com>
1276
1277         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1278         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1279
1280 2019-01-23  Tom Tromey  <tom@tromey.com>
1281             Andrew Burgess  <andrew.burgess@embecosm.com>
1282             Pedro Alves  <palves@redhat.com>
1283
1284         * infrun.c (fetch_inferior_event): Use scope_exit.
1285         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1286         * top.c (execute_command): Use scope_exit.
1287         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1288         * utils.c (do_bpstat_clear_actions_cleanup)
1289         (make_bpstat_clear_actions_cleanup): Remove.
1290
1291 2019-01-23  Tom Tromey  <tom@tromey.com>
1292             Pedro Alves  <palves@redhat.com>
1293
1294         * infrun.c: Include "common/scope-exit.h"
1295         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1296         (wait_for_inferior): Use SCOPE_EXIT.
1297         (fetch_inferior_event): Use scope_exit.
1298
1299 2019-01-23  Tom Tromey  <tom@tromey.com>
1300             Pedro Alves  <palves@redhat.com>
1301
1302         * breakpoint.c (create_breakpoint): Remove cleanup.
1303
1304 2019-01-23  Tom Tromey  <tom@tromey.com>
1305             Andrew Burgess  <andrew.burgess@embecosm.com>
1306             Pedro Alves  <palves@redhat.com>
1307
1308 2019-01-23  Pedro Alves  <palves@redhat.com>
1309
1310         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1311
1312 2019-01-23  Pedro Alves  <palves@redhat.com>
1313             Andrew Burgess  <andrew.burgess@embecosm.com>
1314
1315         * gdbthread.h: Include "common/forward-scope-exit.h".
1316         (scoped_finish_thread_state): Redefine custom class in terms of
1317         forward_scope_exit.
1318
1319 2019-01-23  Pedro Alves  <palves@redhat.com>
1320             Andrew Burgess  <andrew.burgess@embecosm.com>
1321
1322         * common/forward-scope-exit.h: New file.
1323
1324 2019-01-23  Pedro Alves  <palves@redhat.com>
1325             Andrew Burgess  <andrew.burgess@embecosm.com>
1326             Tom Tromey  <tom@tromey.com>
1327
1328         * common/scope-exit.h: New file.
1329
1330 2019-01-23  Pedro Alves  <palves@redhat.com>
1331
1332         * common/preprocessor.h (ESC): Rename to ...
1333         (ESC_PARENS): ... this.
1334         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1335         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1336
1337 2019-01-23  Tom Tromey  <tom@tromey.com>
1338
1339         * language.h (class scoped_switch_to_sym_language_if_auto):
1340         Initialize m_lang in both cases.
1341
1342 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1343
1344         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1345         with XCNEW.
1346
1347 2019-01-22  Tom Tromey  <tom@tromey.com>
1348
1349         * corelow.c: Do not include sys/file.h.
1350
1351 2019-01-22  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-wingeneral.h: Include gdb_curses.h.
1354
1355 2019-01-22  Tom Tromey  <tom@tromey.com>
1356
1357         * source-cache.h (class source_cache) <get_source_lines,
1358         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1359
1360 2019-01-22  Tom Tromey  <tom@tromey.com>
1361
1362         * remote-fileio.h (struct remote_target): Declare.
1363
1364 2019-01-22  Tom Tromey  <tom@tromey.com>
1365
1366         * python/py-arch.c: Do not include py-ref.h.
1367         * python/py-bpevent.c: Do not include py-ref.h.
1368         * python/py-cmd.c: Do not include py-ref.h.
1369         * python/py-continueevent.c: Do not include py-ref.h.
1370         * python/py-event.h: Do not include py-ref.h.
1371         * python/py-evtregistry.c: Do not include py-ref.h.
1372         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1373         * python/py-frame.c: Do not include py-ref.h.
1374         * python/py-framefilter.c: Do not include py-ref.h.
1375         * python/py-function.c: Do not include py-ref.h.
1376         * python/py-infevents.c: Do not include py-ref.h.
1377         * python/py-linetable.c: Do not include py-ref.h.
1378         * python/py-objfile.c: Do not include py-ref.h.
1379         * python/py-param.c: Do not include py-ref.h.
1380         * python/py-prettyprint.c: Do not include py-ref.h.
1381         * python/py-progspace.c: Do not include py-ref.h.
1382         * python/py-symbol.c: Do not include py-ref.h.
1383         * python/py-symtab.c: Do not include py-ref.h.
1384         * python/py-type.c: Do not include py-ref.h.
1385         * python/py-unwind.c: Do not include py-ref.h.
1386         * python/py-utils.c: Do not include py-ref.h.
1387         * python/py-value.c: Do not include py-ref.h.
1388         * python/py-varobj.c: Do not include py-ref.h.
1389         * python/py-xmethods.c: Do not include py-ref.h.
1390         * python/python.c: Do not include py-ref.h.
1391         * varobj.c: Do not include py-ref.h.
1392
1393 2019-01-22  Tom Tromey  <tom@tromey.com>
1394
1395         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1396         keyword for bcache.
1397
1398 2019-01-22  Tom Tromey  <tom@tromey.com>
1399
1400         * compile/compile-cplus-types.c: Remove a comment by #include.
1401
1402 2019-01-22  Tom Tromey  <tom@tromey.com>
1403
1404         * compile/gcc-c-plugin.h: Include compile-internal.h.
1405
1406 2019-01-22  Tom Tromey  <tom@tromey.com>
1407
1408         * stabsread.c (EXTERN): Do not define.
1409         (symnum, next_symbol_text_func, processing_gcc_compilation)
1410         (within_function, global_sym_chain, global_stabs)
1411         (previous_stab_code, this_object_header_files)
1412         (n_this_object_header_files)
1413         (n_allocated_this_object_header_files): Define.
1414         * stabsread.h (EXTERN): Never define.  Use "extern".
1415
1416 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1417
1418         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1419         history_value.
1420
1421 2019-01-21  Tom Tromey  <tom@tromey.com>
1422
1423         * ui-out.c: Fix includes.
1424         * tui/tui-source.c: Fix includes.
1425         * target.c: Fix includes.
1426         * remote.c: Fix includes.
1427         * regcache.c: Fix includes.
1428         * python/py-block.c: Fix includes.
1429         * printcmd.c: Fix includes.
1430         * or1k-tdep.c: Fix includes.
1431         * mi/mi-main.c: Fix includes.
1432         * m32r-tdep.c: Fix includes.
1433         * csky-tdep.c: Fix includes.
1434         * compile/compile-cplus-types.c: Fix includes.
1435         * cli/cli-interp.c: Fix includes.
1436
1437 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1438
1439         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1440         for padding.
1441
1442 2019-01-16  Tom Tromey  <tom@tromey.com>
1443
1444         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1445         earlier.
1446         (struct objfile) <msymbols_range>: Move from top level.
1447         <msymbols>: New method.
1448         (class objfile_msymbols): Remove.
1449         * symtab.c (default_collect_symbol_completion_matches_break_on):
1450         Update.
1451         * symmisc.c (dump_msymbols): Update.
1452         * stabsread.c (scan_file_globals): Update.
1453         * objc-lang.c (info_selectors_command, info_classes_command)
1454         (find_methods): Update.
1455         * minsyms.c (find_solib_trampoline_target): Update.
1456         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1457         * coffread.c (coff_symfile_read): Update.
1458         * ada-lang.c (ada_lookup_simple_minsym)
1459         (ada_collect_symbol_completion_matches): Update.
1460
1461 2019-01-16  Tom Tromey  <tom@tromey.com>
1462
1463         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1464         type.  Remove no-argument constructor.
1465         <iterator::operator++>: Simplify.
1466         <begin>: Update.
1467         <end>: Use minimal_symbol_count.
1468
1469 2019-01-16  Tom Tromey  <tom@tromey.com>
1470
1471         * objfiles.h (struct objfile) <psymtabs>: New method.
1472         (class objfile_psymtabs): Remove.
1473         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1474         typedef.
1475         <range>: New method.
1476         (require_partial_symbols): Change return type.
1477         * psymtab.c (require_partial_symbols)
1478         (psym_expand_symtabs_matching): Update.
1479         * mdebugread.c (parse_partial_symbols): Update.
1480         * dbxread.c (dbx_end_psymtab): Update.
1481
1482 2019-01-15  Tom Tromey  <tom@tromey.com>
1483
1484         * symtab.c (lookup_objfile_from_block)
1485         (lookup_symbol_in_objfile_symtabs)
1486         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1487         (find_line_symtab, info_sources_command)
1488         (default_collect_symbol_completion_matches_break_on)
1489         (make_source_files_completion_list): Update.
1490         * symmisc.c (print_objfile_statistics, dump_objfile)
1491         (maintenance_print_symbols, maintenance_info_symtabs)
1492         (maintenance_check_symtabs, maintenance_info_line_tables):
1493         Update.
1494         * source.c (select_source_symtab)
1495         (forget_cached_source_info_for_objfile): Update.
1496         * objfiles.h (class objfile_compunits): Remove.
1497         (struct objfile) <compunits_range>: New typedef.
1498         (compunits): New method.
1499         * objfiles.c (objfile_relocate1): Update.
1500         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1501         * maint.c (count_symtabs_and_blocks): Update.
1502         * linespec.c (iterate_over_all_matching_symtabs): Update.
1503         * cp-support.c (add_symbol_overload_list_qualified): Update.
1504         * coffread.c (coff_symtab_read): Update.
1505         * ada-lang.c (add_nonlocal_symbols)
1506         (ada_collect_symbol_completion_matches)
1507         (ada_add_global_exceptions): Update.
1508
1509 2019-01-15  Tom Tromey  <tom@tromey.com>
1510
1511         * progspace.h (program_space) <objfiles_safe_range>: New
1512         typedef.
1513         <objfiles_safe>: New method.
1514         * objfiles.h (class all_objfiles_safe): Remove.
1515         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1516         * jit.c (jit_inferior_exit_hook): Update.
1517
1518 2019-01-17  Tom Tromey  <tom@tromey.com>
1519
1520         * progspace.h (program_space) <objfiles_range>: New typedef.
1521         <objfiles>: New method.
1522         <objfiles_head>: Rename from objfiles.
1523         (object_files): Update.
1524         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1525         * guile/scm-pretty-print.c
1526         (ppscm_find_pretty_printer_from_objfiles): Update.
1527         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1528         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1529         Update.
1530         * python/py-progspace.c (pspy_get_objfiles): Update.
1531         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1532         Update.
1533         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1534         (objfpy_lookup_objfile_by_build_id): Update.
1535         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1536         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1537         Update.
1538         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1539         (expand_symtab_containing_pc, lookup_objfile_from_block)
1540         (lookup_static_symbol, basic_lookup_transparent_type)
1541         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1542         (find_line_symtab, info_sources_command)
1543         (default_collect_symbol_completion_matches_break_on)
1544         (make_source_files_completion_list, find_main_name): Update.
1545         * symmisc.c (print_symbol_bcache_statistics)
1546         (print_objfile_statistics, maintenance_print_symbols)
1547         (maintenance_print_msymbols, maintenance_print_objfiles)
1548         (maintenance_info_symtabs, maintenance_check_symtabs)
1549         (maintenance_expand_symtabs, maintenance_info_line_tables):
1550         Update.
1551         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1552         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1553         (map_overlay_command, unmap_overlay_command)
1554         (simple_overlay_update, expand_symtabs_matching)
1555         (map_symbol_filenames): Update.
1556         * symfile-debug.c (set_debug_symfile): Update.
1557         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1558         Update.
1559         * source.c (select_source_symtab, forget_cached_source_info):
1560         Update.
1561         * solib.c (solib_read_symbols): Update.
1562         * solib-spu.c (append_ocl_sos): Update.
1563         * psymtab.c (maintenance_print_psymbols)
1564         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1565         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1566         * printcmd.c (info_symbol_command): Update.
1567         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1568         Update.
1569         * objfiles.h (class all_objfiles): Remove.
1570         * objfiles.c (have_partial_symbols, have_full_symbols)
1571         (have_minimal_symbols, qsort_cmp, update_section_map)
1572         (shared_objfile_contains_address_p)
1573         (default_iterate_over_objfiles_in_search_order): Update.
1574         * objc-lang.c (info_selectors_command, info_classes_command)
1575         (find_methods): Update.
1576         * minsyms.c (find_solib_trampoline_target): Update.
1577         * maint.c (maintenance_info_sections)
1578         (maintenance_translate_address, count_symtabs_and_blocks):
1579         Update.
1580         * main.c (captured_main_1): Update.
1581         * linux-thread-db.c (try_thread_db_load_from_pdir)
1582         (has_libpthread): Update.
1583         * linespec.c (iterate_over_all_matching_symtabs)
1584         (search_minsyms_for_name): Update.
1585         * jit.c (jit_find_objf_with_entry_addr): Update.
1586         * hppa-tdep.c (find_unwind_entry)
1587         (hppa_lookup_stub_minimal_symbol): Update.
1588         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1589         Update.
1590         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1591         (elf_gnu_ifunc_resolve_by_got): Update.
1592         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1593         * dwarf-index-write.c (save_gdb_index_command): Update.
1594         * cp-support.c (add_symbol_overload_list_qualified): Update.
1595         * breakpoint.c (create_overlay_event_breakpoint)
1596         (create_longjmp_master_breakpoint)
1597         (create_std_terminate_master_breakpoint)
1598         (create_exception_master_breakpoint): Update.
1599         * blockframe.c (find_pc_partial_function): Update.
1600         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1601         (ada_collect_symbol_completion_matches)
1602         (ada_add_global_exceptions): Update.
1603
1604 2019-01-17  Tom Tromey  <tom@tromey.com>
1605
1606         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1607         declare VEC.
1608         (solib_target_parse_libraries): Change return type.
1609         (library_list_start_segment, library_list_start_section)
1610         (library_list_end_library, library_list_start_library); Update.
1611         (solib_target_free_library_list): Remove.
1612         (solib_target_parse_libraries): Remove cleanup.  Change return
1613         type.
1614         (solib_target_current_sos): Update.
1615
1616 2019-01-17  Tom Tromey  <tromey@bapiya>
1617
1618         * valprint.c: Replace "the the" with "the".
1619         * symtab.c: Replace "the the" with "the".
1620         * solib.c: Replace "the the" with "the".
1621         * solib-dsbt.c: Replace "the the" with "the".
1622         * linespec.c: Replace "the the" with "the".
1623         * dwarf2loc.h: Replace "the the" with "the".
1624         * amd64-windows-tdep.c: Replace "the the" with "the".
1625         * aarch64-tdep.c: Replace "the the" with "the".
1626
1627 2019-01-16  Keith Seitz  <keiths@redhat.com>
1628
1629         PR gdb/23773
1630         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1631         <builder>: Rename to ..
1632         <m_builder>: ... this and make private.
1633         (dwarf2_cu::get_builder): New method.  Change all users of
1634         `builder' to use this method.
1635         (dwarf2_start_symtab): Move to ...
1636         (dwarf2_cu::start_symtab): ... here.  Update all callers
1637         (setup_type_unit_groups): Move to ...
1638         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1639         callers.
1640         (dwarf2_cu::reset_builder): New method.
1641         (process_full_compunit, process_full_type_unit): Use
1642         dwarf2_cu::reset_builder.
1643         (follow_die_offset): Record the ancestor CU if it is different
1644         from the followed DIE's CU.
1645         (follow_die_sig_1): Likewise.
1646
1647 2019-01-15  Tom Tromey  <tom@tromey.com>
1648
1649         * remote.c (class remote_state) <buf>: Now a char_vector.
1650         <buf_size>: Remove.
1651         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1652         parameter.
1653         (remote_target::getpkt_or_notif_sane_1)
1654         (remote_target::getpkt_sane)
1655         (remote_target::getpkt_or_notif_sane): Likewise.
1656         (class remote_target) <putpkt>: New overload.
1657         (remote_target::read_frame): Change type of "buf_p".  Remove
1658         sizeof_p parameter.
1659         (packet_ok): New overload.
1660         (packet_check_result): New overload.
1661         Update all uses.
1662
1663 2019-01-14  Tom Tromey  <tom@tromey.com>
1664
1665         * remote-notif.c (handle_notification, remote_notif_ack)
1666         (remote_notif_parse): Make "buf" const.
1667         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1668         const.
1669         (remote_notif_parse, remote_notif_ack, handle_notification):
1670         Likewise.
1671         * remote.c (remote_notif_stop_parse): Make "buf" const.
1672         (remote_target::remote_parse_stop_reply): Make "buf" const.
1673         (remote_notif_stop_ack): Make "buf" const.
1674
1675 2019-01-14  Tom Tromey  <tom@tromey.com>
1676
1677         * remote.c (remote_console_output): Make parameter const.
1678
1679 2019-01-14  Tom Tromey  <tom@tromey.com>
1680
1681         * target-debug.h (target_debug_print_signals): Constify.
1682         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1683         * procfs.c (procfs_target::pass_signals): Update.
1684         * linux-nat.c (linux_nat_target::pass_signals): Update.
1685         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1686         * target-delegates.c: Rebuild.
1687         * remote.c (remote_target::program_signals): Update.
1688         (remote_target::pass_signals): Update.
1689         * target.c (target_pass_signals): Constify argument.
1690         (target_program_signals): Likewise.
1691         * target.h (struct target_ops) <pass_signals, program_signals>:
1692         Constify argument.
1693         (target_pass_signals, target_program_signals): Constify argument.
1694
1695 2019-01-14  Tom Tromey  <tom@tromey.com>
1696
1697         PR tui/28819:
1698         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1699
1700 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1701
1702         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1703         field.
1704         * rs6000-tdep.c: Include reggroups.h.
1705         (IS_V_ALIAS_PSEUDOREG): Define.
1706         (rs6000_register_name): Return names for the "vX" aliases.
1707         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1708         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1709         aliases.  Call default_register_reggroup_p for all other
1710         pseudo-registers.
1711         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1712         New functions.
1713         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1714         Handle "vX" aliases.
1715         (v_alias_pseudo_register_collect): New function.
1716         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1717         (rs6000_gdbarch_init): Initialize "vX" aliases as
1718         pseudo-registers.  Restore registration of
1719         rs6000_pseudo_register_reggroup_p with
1720         set_tdesc_pseudo_register_reggroup_p.
1721
1722 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1723
1724         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1725         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1726         set_gdbarch_num_pseudo_regs.
1727
1728 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1729
1730         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1731         Remove arg prefixname, add do_set and do_show.
1732         Add member functions set_list and show_list.
1733         * cli/cli-style.c (class cli_style_option): Update accordingly.
1734         (style_set_list): Move to file scope.
1735         (style_show_list): Likewise.
1736         (set_style): Call help_list.
1737         (show_style): Call cmd_show_list.
1738         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1739         Update to use the new macro.
1740
1741 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1742
1743         * ada-lang.c (_initialize_ada_language): Expand the help text
1744         for the "catch exception" command.
1745
1746 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1747
1748         * symtab.c (matching_obj_sections): Initialize obj,
1749         declare it closer to its usage.
1750
1751 2019-01-10  Tom Tromey  <tom@tromey.com>
1752
1753         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1754         (basic_inf_threads_range): Remove.
1755         (inf_threads_range, inf_non_exited_threads_range)
1756         (safe_inf_threads_range): Use next_adapter.
1757
1758 2019-01-10  Keith Seitz  <keiths@redhat.com>
1759
1760         PR gdb/23712
1761         PR symtab/23010
1762         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1763         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1764
1765 2019-01-10  Keith Seitz  <keiths@redhat.com>
1766
1767         PR gdb/23712
1768         PR symtab/23010
1769         * dictionary.c (pending_to_vector): Remove.
1770         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1771         Remove _1 suffix, replacing functions of the same name.  Update
1772         all callers.
1773         (dict_create_hashed, dict_create_hashed_expandable)
1774         (dict_create_linear, dict_create_linear_expandable, dict_free)
1775         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1776         Make functions static.
1777
1778 2019-01-10  Keith Seitz  <keiths@redhat.com>
1779
1780         PR gdb/23712
1781         PR symtab/23010
1782         * dictionary.h (struct dictionary): Replace declaration with
1783         multidictionary.
1784         (dict_create_hashed, dict_create_hashed_expandable)
1785         (dict_create_linear, dict_create_linear_expandable)
1786         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1787         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1788         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1789         taking multidictionary argument.
1790         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1791         * block.h (struct block) <dict>: Change to multidictionary
1792         and rename `multidict'.
1793         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1794         symmisc.c: Update all dictionary references to multidictionary.
1795
1796 2019-01-10  Keith Seitz  <keiths@redhat.com>
1797
1798         PR gdb/23712
1799         PR symtab/23010
1800         * dictionary.c: Include unordered_map.
1801         (pending_to_vector): New function.
1802         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1803         Rewrite the non-"_1" functions to take vector instead
1804         of linked list.
1805         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1806         "new" _1 versions of the same name.
1807         (multidictionary): Define.
1808         (std::hash<enum language): New definition.
1809         (collate_pending_symbols_by_language, mdict_create_hashed)
1810         (mdict_create_hashed_expandable, mdict_create_linear)
1811         (mdict_create_linear_expandable, mdict_free)
1812         (find_language_dictionary, create_new_language_dictionary)
1813         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1814         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1815         (mdict_size, mdict_empty): New functions.
1816         * dictionary.h (mdict_iterator): Define.
1817
1818 2019-01-10  Pedro Alves  <palves@redhat.com>
1819
1820         * breakpoint.c (read_uploaded_action)
1821         (create_tracepoint_from_upload): Adjust to use
1822         gdb::unique_xmalloc_ptr.
1823         * ctf.c (ctf_write_uploaded_tp):
1824         (SET_ARRAY_FIELD): Use emplace_back.
1825         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1826         * tracefile-tfile.c (tfile_write_uploaded_tp):
1827         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1828         gdb::unique_xmalloc_ptr.
1829         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1830         at_string, cond_string, cmd_strings>: Replace char pointers
1831         with gdb::unique_xmalloc_ptr.
1832
1833 2019-01-10  Pedro Alves  <palves@redhat.com>
1834
1835         * solib-target.c (library_list_start_library): Don't xstrdup name.
1836
1837 2019-01-10  Pedro Alves  <palves@redhat.com>
1838
1839         * mdebugread.c (parse_partial_symbols): Use
1840         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1841
1842 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1843
1844         * linux-fork.c (scoped_switch_fork_info)
1845         <~scoped_switch_fork_info>: Fix incorrect variable name.
1846
1847 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1848
1849         * linux-fork.c (scoped_switch_fork_info)
1850         <scoped_switch_fork_info>: Make explicit.
1851         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1852
1853 2019-01-10  Tom Tromey  <tom@tromey.com>
1854
1855         * objfiles.h (objfile::reset_psymtabs): Update.
1856         * objfiles.c (objfile::objfile): Update.
1857         * psymtab.h (psymtab_storage::obstack): Update.
1858         (psymtab_storage::m_obstack): Use gdb::optional.
1859         (class psymtab_storage): Update comment.  Remove objfile
1860         parameter.
1861         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1862
1863 2019-01-10  Tom Tromey  <tom@tromey.com>
1864
1865         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1866         <free_psymtabs>: Now private.
1867         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1868         (allocate_psymtab): Use new method.
1869
1870 2019-01-10  Tom Tromey  <tom@tromey.com>
1871
1872         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1873         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1874         * mdebugread.c (parse_partial_symbols): Use
1875         allocate_dependencies.
1876         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1877         allocate_dependencies.
1878         (process_psymtab_comp_unit_reader)
1879         (build_type_psymtab_dependencies): Likewise.
1880         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1881
1882 2019-01-10  Tom Tromey  <tom@tromey.com>
1883
1884         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1885         PSYMBOL_SET_LANGUAGE.
1886         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1887
1888 2019-01-10  Tom Tromey  <tom@tromey.com>
1889
1890         * psymtab.h (psymtab_storage::obstack): New method.
1891         <m_obstack>: Rename from obstack; now private.
1892         * psymtab.c (psymtab_storage): Update.
1893         * dwarf2read.c (create_addrmap_from_index)
1894         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1895         Update.
1896
1897 2019-01-10  Tom Tromey  <tom@tromey.com>
1898
1899         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1900         * objfiles.h (objfile::reset_psymtabs): New method.
1901
1902 2019-01-10  Tom Tromey  <tom@tromey.com>
1903
1904         * symmisc.c (print_symbol_bcache_statistics): Update.
1905         (print_objfile_statistics): Update.
1906         * symfile.c (reread_symbols): Update.
1907         * psymtab.h (class psymtab_storage): New.
1908         * psymtab.c (psymtab_storage): New constructor.
1909         (~psymtab_storage): New destructor.
1910         (require_partial_symbols): Update.
1911         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1912         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1913         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1914         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1915         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1916         (start_psymtab_common, end_psymtab_common)
1917         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1918         (allocate_psymtab): Update.
1919         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1920         Update.
1921         (dump_psymtab_addrmap, maintenance_print_psymbols)
1922         (maintenance_check_psymtabs): Update.
1923         (class objfile_psymtabs): Move to objfiles.h.
1924         * psympriv.h (discard_psymtab): Now inline.
1925         (psymtab_discarder::psymtab_discarder): Update.
1926         (psymtab_discarder::~psymtab_discarder): Update.
1927         (ALL_OBJFILE_PSYMTABS): Rewrite.
1928         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1929         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1930         Remove fields.
1931         <partial_symtabs>: New field.
1932         (class objfile_psymtabs): Move from psymtab.h.  Update.
1933         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1934         psymbol_cache.
1935         (objfile::~objfile): Don't destroy psymbol_cache.
1936         * mdebugread.c (parse_partial_symbols): Update.
1937         * dwarf2read.c (create_addrmap_from_index)
1938         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1939         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1940         (add_partial_subprogram, dwarf2_ranges_read): Update.
1941         * dwarf-index-write.c (write_address_map)
1942         (write_one_signatured_type, recursively_write_psymbols)
1943         (class debug_names, class debug_names, write_psymtabs_to_index):
1944         Update.
1945
1946 2019-01-10  Tom Tromey  <tom@tromey.com>
1947
1948         * symtab.h (SYMBOL_SET_NAMES): Update.
1949         (symbol_set_names): Update.
1950         (MSYMBOL_SET_NAMES): Update.
1951         * symtab.c (symbol_set_names): Change argument to be an
1952         objfile_per_bfd_storage.
1953         * psymtab.c (add_psymbol_to_bcache): Update.
1954         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1955
1956 2019-01-10  Tom Tromey  <tom@tromey.com>
1957
1958         * symtab.c (create_demangled_names_hash): Change argument to be an
1959         objfile_per_bfd_storage.
1960         (symbol_set_names): Update.
1961
1962 2019-01-10  Tom Tromey  <tom@tromey.com>
1963
1964         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1965         init_psymbol_list.
1966         * psymtab.c (init_psymbol_list): Do nothing if already called.
1967         * psympriv.h (init_psymbol_list): Add comment.
1968         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1969         init_psymbol_list.
1970         * dbxread.c (dbx_symfile_read): Unconditionally call
1971         init_psymbol_list.
1972
1973 2019-01-10  Tom Tromey  <tom@tromey.com>
1974
1975         * xcoffread.c (scan_xcoff_symtab): Update.
1976         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1977         "where".
1978         * mdebugread.c (parse_partial_symbols)
1979         (handle_psymbol_enumerators): Update.
1980         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1981         * dbxread.c (read_dbx_symtab): Update.
1982         * psympriv.h (psymbol_placement): New enum.
1983         (add_psymbol_to_list): Update.
1984
1985 2019-01-10  Tom Tromey  <tom@tromey.com>
1986
1987         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1988         static_psymbols parameters.
1989         (scan_xcoff_symtab): Update.
1990         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1991         static_psymbols parameters.
1992         * psympriv.h (start_psymtab_common): Update.
1993         * mdebugread.c (parse_partial_symbols): Update.
1994         * dwarf2read.c (create_partial_symtab): Update.
1995         * dbxread.c (read_dbx_symtab): Update.
1996         (start_psymtab): Remove global_psymbols and static_psymbols
1997         parameters.
1998
1999 2019-01-10  Tom Tromey  <tom@tromey.com>
2000
2001         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2002         * psymtab.c (allocate_psymtab): Add comment.
2003         * psympriv.h (allocate_psymtab): Add comment.
2004         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2005         initializations.
2006         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2007
2008 2019-01-10  Tom Tromey  <tom@tromey.com>
2009
2010         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2011         Don't declare.
2012         * mipsread.c: Include mdebugread.h.
2013         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2014         Declare.
2015         * elfread.c: Include mdebugread.h.
2016
2017 2019-01-09  Tom Tromey  <tom@tromey.com>
2018
2019         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2020         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2021         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2022         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2023         (psym_lookup_symbol, psym_find_last_source_symtab)
2024         (psym_forget_cached_source_info, psym_print_stats)
2025         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2026         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2027         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2028         (psym_find_compunit_symtab_by_address)
2029         (maintenance_print_psymbols, maintenance_info_psymtabs)
2030         (maintenance_check_psymtabs): Use ranged for.
2031         * psymtab.h (class objfile_psymtabs): New.
2032         (require_partial_symbols): Return objfile_psymtabs.
2033         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2034
2035 2019-01-09  Tom Tromey  <tom@tromey.com>
2036
2037         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2038         (find_pc_mapped_section, list_overlays_command)
2039         (map_overlay_command, unmap_overlay_command)
2040         (simple_overlay_update): Use all_objfiles.
2041         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2042         * printcmd.c (info_symbol_command): Use all_objfiles.
2043         * objfiles.h (ALL_OBJSECTIONS): Remove.
2044         * maint.c (maintenance_translate_address): Use all_objfiles.
2045         * gcore.c (gcore_create_callback): Use all_objfiles.
2046         (objfile_find_memory_regions): Likewise.
2047
2048 2019-01-09  Tom Tromey  <tom@tromey.com>
2049
2050         * symtab.c (find_line_symtab, info_sources_command)
2051         (make_source_files_completion_list): Use objfile_compunits.
2052         * source.c (select_source_symtab): Use objfile_compunits.
2053         * objfiles.h (struct objfile): Update comment.
2054         (ALL_OBJFILES): Remove.
2055         (ALL_FILETABS): Remove.
2056         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2057         objfile_compunits.
2058
2059 2019-01-09  Tom Tromey  <tom@tromey.com>
2060
2061         * symmisc.c (print_objfile_statistics, dump_objfile)
2062         (maintenance_print_symbols): Use compunit_filetabs.
2063         * source.c (forget_cached_source_info_for_objfile): Use
2064         compunit_filetabs.
2065         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2066         (ALL_FILETABS): Use compunit_filetabs.
2067         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2068         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2069
2070 2019-01-09  Tom Tromey  <tom@tromey.com>
2071
2072         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2073         (compunit_filetabs): New.
2074         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2075         compunit_filetabs.
2076         (info_sources_command, make_source_files_completion_list): Remove
2077         declaration.
2078         * symmisc.c (print_objfile_statistics, dump_objfile)
2079         (maintenance_print_symbols): Remove declaration.
2080         (maintenance_info_symtabs): Use compunit_filetabs.
2081         (maintenance_info_line_tables): Likewise.
2082         * source.c (select_source_symtab): Change local variable name.
2083         (forget_cached_source_info_for_objfile): Remove declaration.
2084         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2085         * objfiles.c (objfile_relocate1): Remove declaration.
2086         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2087         declaration.
2088         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2089         * coffread.c (coff_symtab_read): Remove declaration.
2090         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2091         compunit_filetabs.
2092
2093 2019-01-09  Tom Tromey  <tom@tromey.com>
2094
2095         * symtab.c (lookup_objfile_from_block)
2096         (find_pc_sect_compunit_symtab, search_symbols)
2097         (default_collect_symbol_completion_matches_break_on): Use
2098         objfile_compunits.
2099         * objfiles.h (ALL_COMPUNITS): Remove.
2100         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2101         * cp-support.c (add_symbol_overload_list_qualified): Use
2102         objfile_compunits.
2103         * ada-lang.c (ada_collect_symbol_completion_matches)
2104         (ada_add_global_exceptions): Use objfile_compunits.
2105
2106 2019-01-09  Tom Tromey  <tom@tromey.com>
2107
2108         * source.c (select_source_symtab)
2109         (forget_cached_source_info_for_objfile): Remove declaration.
2110         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2111         declaration.
2112         * maint.c (count_symtabs_and_blocks): Remove declaration.
2113         * cp-support.c (add_symbol_overload_list_qualified): Remove
2114         declaration.
2115         * coffread.c (coff_symtab_read): Remove declaration.
2116         * symtab.c (lookup_symbol_in_objfile_symtabs)
2117         (basic_lookup_transparent_type_1): Use objfile_compunits.
2118         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2119         (info_sources_command, search_symbols)
2120         (default_collect_symbol_completion_matches_break_on)
2121         (make_source_files_completion_list): Remove declaration.
2122         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2123         (ada_collect_symbol_completion_matches)
2124         (ada_add_global_exceptions): Remove declaration.
2125         * linespec.c (iterate_over_all_matching_symtabs): Use
2126         objfile_compunits.
2127         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2128         (class objfile_compunits): New.
2129         (ALL_COMPUNITS): Use objfile_compunits.
2130         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2131         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2132         objfile_compunits.
2133         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2134
2135 2019-01-09  Tom Tromey  <tom@tromey.com>
2136
2137         * symtab.c (search_symbols)
2138         (default_collect_symbol_completion_matches_break_on): Use
2139         objfile_msymbols.
2140         * ada-lang.c (ada_lookup_simple_minsym)
2141         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2142         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2143         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2144         objfile_msymbols.
2145         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2146         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2147         * objc-lang.c (find_methods): Use objfile_msymbols.
2148         (info_selectors_command, info_classes_command): Likewise.
2149         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2150         * objfiles.h (class objfile_msymbols): New.
2151         (ALL_OBJFILE_MSYMBOLS): Remove.
2152         (ALL_MSYMBOLS): Remove.
2153
2154 2019-01-09  Tom Tromey  <tom@tromey.com>
2155
2156         * common/next-iterator.h (next_adapter): Add Iterator template
2157         parameter.
2158         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2159         (class all_objfiles_safe): New.
2160         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2161         * objfiles.c (put_objfile_before): Update comment.
2162         (add_separate_debug_objfile): Likewise.
2163         (free_all_objfiles): Use all_objfiles_safe.
2164         (objfile_purge_solibs): Likewise.
2165
2166 2019-01-09  Tom Tromey  <tom@tromey.com>
2167
2168         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2169         (expand_symtab_containing_pc, lookup_static_symbol)
2170         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2171         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2172         all_objfiles.
2173         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2174         * breakpoint.c (create_overlay_event_breakpoint)
2175         (create_longjmp_master_breakpoint)
2176         (create_std_terminate_master_breakpoint)
2177         (create_exception_master_breakpoint): Use all_objfiles.
2178         * linux-thread-db.c (try_thread_db_load_from_pdir)
2179         (has_libpthread): Use all_objfiles.
2180         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2181         * linespec.c (iterate_over_all_matching_symtabs)
2182         (search_minsyms_for_name): Use all_objfiles.
2183         * maint.c (maintenance_info_sections): Use all_objfiles.
2184         * main.c (captured_main_1): Use all_objfiles.
2185         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2186         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2187         * guile/scm-pretty-print.c
2188         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2189         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2190         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2191         (maintenance_print_msymbols): Use all_objfiles.
2192         * source.c (select_source_symtab): Use all_objfiles.
2193         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2194         * symfile.c (remove_symbol_file_command)
2195         (expand_symtabs_matching, map_symbol_filenames): Use
2196         all_objfiles.
2197         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2198         all_objfiles.
2199         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2200         * objc-lang.c (find_methods): Use all_objfiles.
2201         * objfiles.c (have_partial_symbols, have_full_symbols)
2202         (have_minimal_symbols, qsort_cmp)
2203         (default_iterate_over_objfiles_in_search_order): Use
2204         all_objfiles.
2205         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2206         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2207         (maintenance_check_psymtabs): Use all_objfiles.
2208         (ALL_PSYMTABS): Remove.
2209         * compile/compile-object-run.c (do_module_cleanup): Use
2210         all_objfiles.
2211         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2212         * cp-support.c (add_symbol_overload_list_qualified): Use
2213         all_objfiles.
2214         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2215         Use all_objfiles.
2216         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2217         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2218         all_objfiles.
2219         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2220         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2221         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2222         Uses all_objfiles.
2223         * solib.c (solib_read_symbols): Use all_objfiles
2224
2225 2019-01-09  Tom Tromey  <tom@tromey.com>
2226
2227         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2228         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2229         all_objfiles.
2230         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2231         * symmisc.c (print_symbol_bcache_statistics)
2232         (print_objfile_statistics, maintenance_print_objfiles)
2233         (maintenance_info_symtabs, maintenance_check_symtabs)
2234         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2235         all_objfiles.
2236         * source.c (forget_cached_source_info): Use all_objfiles.
2237         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2238         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2239         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2240         * objfiles.c (update_section_map): Use all_objfiles.
2241         (shared_objfile_contains_address_p): Likewise.
2242         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2243         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2244
2245 2019-01-09  Tom Tromey  <tom@tromey.com>
2246
2247         * common/next-iterator.h: New file.
2248         * objfiles.h (class all_objfiles): New.
2249         (struct objfile_iterator): New.
2250
2251 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2252
2253         * NEWS: Move the description of the changed "frame", "select-frame",
2254          and "info frame" commands to the Changed commands section.
2255
2256 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2257
2258         * gdbtypes.c (check_stub_method_group): Remove handling of old
2259         mangling schemes.
2260         * linespec.c (find_methods): Likewise.
2261         * stabsread.c (read_member_functions): Likewise.
2262         * valops.c (search_struct_method): Likewise.
2263         (value_struct_elt_for_reference): Likewise.
2264         * NEWS: Mention this change.
2265
2266 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2269         print_source_lines.
2270         * source.c (print_source_lines_base): Update line number check.
2271         (print_source_lines): New function.
2272         (source_lines_range::source_lines_range): New function.
2273         * source.h (class source_lines_range): New class.
2274         (print_source_lines): New declaration.
2275
2276 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2277
2278         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2279
2280 2019-01-08  Tom Tromey  <tom@tromey.com>
2281             Simon Marchi  <simon.marchi@ericsson.com>
2282
2283         PR gdb/24060
2284         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2285         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2286         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2287         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2288         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2289         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2290
2291 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2292
2293         * source.c (select_source_symtab): Move header comment to
2294         declaration in source.h.
2295         (forget_cached_source_info_for_objfile): Likewise.
2296         (forget_cached_source_info): Likewise.
2297         (identify_source_line): Likewise.
2298         * source.h (identify_source_line): Move declaration from symtab.h
2299         and add comment from source.c
2300         (print_source_lines): Likewise.
2301         (forget_cached_source_info_for_objfile): Likewise.
2302         (forget_cached_source_info): Likewise.
2303         (select_source_symtab): Likewise.
2304         (enum print_source_lines_flag): Move definition from symtab.h.
2305         * symtab.h (identify_source_line): Move declaration to source.h.
2306         (print_source_lines): Likewise.
2307         (forget_cached_source_info_for_objfile): Likewise.
2308         (forget_cached_source_info): Likewise.
2309         (select_source_symtab): Likewise.
2310         (enum print_source_lines_flag): Move definition to source.h.
2311         * tui/tui-hooks.c: Add 'source.h' include.
2312
2313 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2314
2315         * source.c (print_source_lines_base): Handle requests to print
2316         reverse line number sequences, and guard against empty lines
2317         string.
2318
2319 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2320
2321         * source.c (print_source_lines_base): Fix skip of '\r' if next
2322         character is '\n'.
2323
2324 2019-01-06  Tom Tromey  <tom@tromey.com>
2325
2326         * c-exp.y (struct c_parse_state) <macro_original_text,
2327         expansion_obstack>: New member.
2328         (macro_original_text, expansion_obstack): Remove globals.
2329         (scan_macro_expansion, scanning_macro_expansion)
2330         (finished_macro_expansion): Update.
2331         (scan_macro_cleanup): Remove.
2332         (yylex, c_parse): Update.
2333
2334 2019-01-06  Tom Tromey  <tom@tromey.com>
2335
2336         * c-exp.y (struct c_parse_state) <strings>: New member.
2337         (operator_stoken): Update.
2338
2339 2019-01-06  Tom Tromey  <tom@tromey.com>
2340
2341         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2342         (union type_stack_elt) <typelist_val>: Now a pointer to
2343         std::vector.
2344         (type_stack_cleanup): Don't declare.
2345         (push_typelist): Update.
2346         * parse.c (pop_typelist): Return a std::vector.
2347         (push_typelist): Take a std::vector.
2348         (follow_types): Update.  Do not free args.
2349         (type_stack_cleanup): Remove.
2350         * c-exp.y (struct c_parse_state): New.
2351         (cpstate): New global.
2352         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2353         (nonempty_typelist): Update.
2354         (func_mod): Create a new vector.
2355         (c_parse): Create a c_parse_state.
2356         (check_parameter_typelist): Do not delete params.
2357         (function_method): Update.  Do not delete type_list.
2358
2359 2019-01-06  Tom Tromey  <tom@tromey.com>
2360
2361         PR gdb/28155:
2362         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2363         check_typedef.
2364         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2365         (print_return_value): Likewise.
2366
2367 2019-01-05  Tom Tromey  <tom@tromey.com>
2368
2369         * contrib/cleanup_check.py: Remove.
2370         * contrib/gcc-with-excheck: Remove.
2371         * contrib/exsummary.py: Remove.
2372         * contrib/excheck.py: Remove.
2373
2374 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2375
2376         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2377         NULL. Initialize tpprev to NULL instead of assigning it
2378         to NULL on the next statement.
2379         * windows-nat.c (windows_delete_thread): Remove check for
2380         main_thread_id before printing thread exit notifications.
2381         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2382         Remove thread ID check against main_thread_id.
2383         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2384         windows_delete_thread.
2385         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2386
2387 2019-01-04  Tom Tromey  <tom@tromey.com>
2388
2389         * compile/compile.c (_initialize_compile): Use upper case for
2390         metasyntactic variables.
2391         * symmisc.c (_initialize_symmisc): Use upper case for
2392         metasyntactic variables.
2393         * psymtab.c (_initialize_psymtab): Use upper case for
2394         metasyntactic variables.
2395         * demangle.c (demangle_command): Use upper case for metasyntactic
2396         variables.
2397         (_initialize_demangler): Likewise.
2398         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2399         variables.
2400
2401 2019-01-03  Tom Tromey  <tom@tromey.com>
2402
2403         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2404
2405 2019-01-03  Tom Tromey  <tom@tromey.com>
2406
2407         * python/py-symtab.c (salpy_str): Update.
2408         (struct salpy_sal_object) <symtab>: Now a PyObject.
2409         (salpy_dealloc): Update.
2410         (del_objfile_sal): Use gdbpy_ref.
2411
2412 2019-01-03  Tom Tromey  <tom@tromey.com>
2413
2414         * python/py-type.c (convert_field): Use new_reference.  Return
2415         gdbpy_ref.
2416         (make_fielditem): Return gdbpy_ref.
2417         (typy_fields): Update.
2418         (typy_getitem): Update.
2419         (field_name): Return gdbpy_ref.  Use new_reference.
2420         (typy_iterator_iternext): Update.
2421
2422 2019-01-03  Tom Tromey  <tom@tromey.com>
2423
2424         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2425
2426 2019-01-03  Tom Tromey  <tom@tromey.com>
2427
2428         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2429         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2430         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2431         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2432         (pspy_set_type_printers): Likewise.
2433         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2434         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2435         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2436         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2437         (objfpy_set_type_printers): Likewise.
2438
2439 2019-01-03  Tom Tromey  <tom@tromey.com>
2440
2441         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2442         (gdbpy_print_stack): Use gdbpy_err_fetch.
2443         * python/python-internal.h (class gdbpy_err_fetch): New class.
2444         (class gdbpy_enter) <m_error_type, m_error_value,
2445         m_error_traceback>: Remove.
2446         <m_error>: New member.
2447         (gdbpy_exception_to_string): Don't declare.
2448         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2449         * python/py-value.c (convert_value_from_python): Use
2450         gdbpy_err_fetch.
2451         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2452         gdbpy_exception_to_string.
2453         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2454         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2455         gdbpy_err_fetch.
2456
2457 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2458
2459         * linux-nat.c (delete_lwp_cleanup): Delete.
2460         (struct lwp_deleter): New struct.
2461         (lwp_info_up): New typedef.
2462         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2463         lwp_info_up.
2464
2465 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * linux-fork.c (class scoped_switch_fork_info): New class.
2468         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2469
2470 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2471
2472         * valops.c (find_overload_match): Remove use of null_cleanup, and
2473         calls to do_cleanups.
2474
2475 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2476
2477         * compile/compile-cplus-types.c
2478         (compile_cplus_instance::decl_name): Handle changes to
2479         cp_func_name.
2480         * cp-support.c (cp_func_name): Update header comment, update
2481         return type.
2482         * cp-support.h (cp_func_name): Update return type in declaration.
2483         * valops.c (find_overload_match): Move temp_func local to top
2484         level of function and change its type.  Use temp_func to hold and
2485         delete temporary string obtained from cp_func_name.
2486
2487 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2488
2489         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2490         gdb::char_vector, remove cleanup, and update uses of `msg`.
2491
2492 2019-01-03  Jim Wilson  <jimw@sifive.com>
2493
2494         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2495
2496 2019-01-02  Tom Tromey  <tom@tromey.com>
2497
2498         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2499         (tdesc_parse_xml): Remove cleanups.
2500         * target-descriptions.h (make_cleanup_free_target_description):
2501         Don't declare.
2502         (target_desc_deleter): New struct.
2503         (target_desc_up): New typedef.
2504         * target-descriptions.c (target_desc_deleter::operator()): Rename
2505         from free_target_description.
2506         (make_cleanup_free_target_description): Remove.
2507
2508 2019-01-02  Tom Tromey  <tom@tromey.com>
2509
2510         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2511         constructor, destructor.
2512         (linespec_parser): Remove typedef.
2513         (~linespec_parser): Rename from linespec_parser_delete.
2514         (linespec_lex_to_end, linespec_complete_label)
2515         (linespec_complete): Update.
2516         (decode_line_full): Remove cleanups.
2517         (decode_line_1): Update.
2518
2519 2019-01-02  Tom Tromey  <tom@tromey.com>
2520
2521         * python/python-internal.h (inferior_to_inferior_object): Change
2522         return type.
2523         * python/py-exitedevent.c (create_exited_event_object): Update.
2524         * python/py-inferior.c (inferior_to_inferior_object): Return
2525         gdbpy_ref.
2526         (python_new_inferior, python_inferior_deleted)
2527         (thread_to_thread_object, delete_thread_object)
2528         (build_inferior_list, gdbpy_selected_inferior): Update.
2529         * python/py-infthread.c (create_thread_object): Update.  Also fail
2530         if inferior_to_inferior_object fails.
2531
2532 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2533
2534         * inferior.h (class inferior) <displaced_step_state>: New field.
2535         * infrun.h (struct displaced_step_state): Move here from
2536         infrun.c.  Initialize fields, add constructor.
2537         <inf>: Remove field.
2538         <reset>: New method.
2539         * infrun.c (struct displaced_step_inferior_state): Move to
2540         infrun.h.
2541         (displaced_step_inferior_states): Remove.
2542         (get_displaced_stepping_state): Adust.
2543         (displaced_step_in_progress_any_inferior): Adjust.
2544         (displaced_step_in_progress_thread): Adjust.
2545         (displaced_step_in_progress): Adjust.
2546         (add_displaced_stepping_state): Remove.
2547         (get_displaced_step_closure_by_addr): Adjust.
2548         (remove_displaced_stepping_state): Remove.
2549         (infrun_inferior_exit): Call displaced_step_state.reset.
2550         (use_displaced_stepping): Don't check for NULL.
2551         (displaced_step_prepare_throw): Call
2552         get_displaced_stepping_state.
2553         (displaced_step_fixup): Don't check for NULL.
2554         (prepare_for_detach): Don't check for NULL.
2555
2556 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2557
2558         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2559          in case of call that did not complete.
2560
2561 2019-01-02  Andrey Utkin  <autkin@undo.io>
2562
2563         * symfile.c (find_separate_debug_file): Fix search of debug files for
2564         remote debuggee.
2565
2566 2019-01-02  Tom Tromey  <tom@tromey.com>
2567
2568         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2569         indentation.
2570         * python/py-frame.c (frapy_older): Remove cast.
2571         (frapy_newer): Likewise.
2572         * python/py-breakpoint.c (local_setattro): Remove cast.
2573         * python/py-arch.c (archpy_name): Remove local variable.
2574         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2575
2576 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2577
2578         * unittests/basic_string_view/element_access/char/empty.cc:
2579         Fix year range in copyright header.
2580
2581 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2582
2583         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2584         Delete.
2585         <operator==>: Update with for removed field.
2586         <hash>: Likewise.
2587         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2588         <isa_features>: ...this.
2589         <abi_features>: New field.
2590         (riscv_isa_flen): Update comment.
2591         (riscv_abi_xlen): New declaration.
2592         (riscv_abi_flen): New declaration.
2593         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2594         isa_features.
2595         (riscv_abi_xlen): New function.
2596         (riscv_isa_flen): Update to get answer from isa_features.
2597         (riscv_abi_flen): New function.
2598         (riscv_has_fp_abi): Update to get answer from abi_features.
2599         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2600         xlen and flen.
2601         (riscv_call_info) <xlen, flen>: Update comment.
2602         (riscv_call_arg_struct): Remove invalid assertions
2603         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2604         is removed.
2605         (riscv_gdbarch_init): Gather isa features and abi features
2606         separately, ensure both match on the gdbarch when reusing an old
2607         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2608         a target with 64-bit float hardware.
2609
2610 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2611
2612         * source.c (search_command_helper): Stop reverse search
2613         when line 1 has been searched.
2614
2615 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2616
2617         * record-full.c (record_full_base_target::close): Rewrite
2618         record_full_core_buf_list free logic.
2619
2620 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2621
2622         * break-catch-syscall.c (print_one_catch_syscall): xfree
2623         the last text.
2624
2625 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2626
2627         * top.c (print_gdb_version): Update Copyright year in version
2628         message.
2629
2630 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2631
2632         Update copyright year range in all GDB files.
2633
2634 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2635
2636         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2637
2638 For older changes see ChangeLog-2018.
2639 \f
2640 Local Variables:
2641 mode: change-log
2642 left-margin: 8
2643 fill-column: 74
2644 version-control: never
2645 coding: utf-8
2646 End:
2647