gdb/ChangeLog

   1 2019-08-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_window) <show_registers,
   4         show_register_group>: Declare.
   5         (tui_show_register_group): Don't declare.
   6         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
   7         tui_show_registers.
   8         (tui_data_window::show_register_group): Rename from
   9         tui_show_register_group.
  10         (tui_data_window::check_register_values, tui_reg_command):
  11         Update.
  12         * tui/tui-layout.c (tui_set_layout): Update.
  13
  14 2019-08-20  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
  17         Declare.
  18         (tui_check_register_values): Don't declare.
  19         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
  20         from tui_check_register_values.
  21         * tui/tui-hooks.c (tui_register_changed): Update.
  22
  23 2019-08-20  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-regs.c (tui_reg_layout): Move later.
  26         (tui_show_registers): Don't enable TUI mode or change layout.
  27
  28 2019-08-20  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-regs.h (struct tui_data_item_window)
  31         <~tui_data_item_window>: Remove.
  32         <content>: Now a unique_xmalloc_ptr.
  33         * tui/tui-regs.c (tui_register_format): Return a
  34         unique_xmalloc_ptr.
  35         (tui_get_register): Update.
  36         (~tui_data_item_window): Remove.
  37         (tui_data_window::display_registers_from, tui_display_register):
  38         Update.
  39         * tui/tui-io.h (tui_expand_tabs): Update.
  40         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
  41         Remove "col" parameter.
  42
  43 2019-08-20  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
  46         field.
  47         * tui/tui-regs.c (~tui_data_item_window): Update.
  48
  49 2019-08-20  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
  52         earlier.
  53
  54 2019-08-20  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
  57
  58 2019-08-20  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-source.h (struct tui_source_window): Update.
  61         * tui/tui-regs.c (tui_show_registers): Update.
  62         * tui/tui-disasm.h (struct tui_disasm_window): Update.
  63         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
  64         (NO_REGS_STRING): Remove defines.
  65
  66 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
  67
  68         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
  69         unnecessary thread walk if remote doesn't support the packet.
  70
  71 2019-08-19  Tom Tromey  <tromey@adacore.com>
  72
  73         * python/py-value.c (value_has_field): Fix indentation.
  74
  75 2019-08-19  Tom Tromey  <tromey@adacore.com>
  76
  77         * printcmd.c (do_one_display, info_display_command): Update.
  78         * block.h (contained_in): Return bool.  Add allow_nested
  79         parameter.
  80         * block.c (contained_in): Return bool.  Add allow_nested
  81         parameter.
  82
  83 2019-08-19  Tom Tromey  <tom@tromey.com>
  84
  85         * configure: Rebuild.
  86         * configure.ac: Disallow the combination of -static-libstdc++ and
  87         source highlight.
  88         * source-cache.c (get_language_name): Handle rust.
  89         (source_cache::get_source_lines): Ignore highlighting exceptions.
  90
  91 2019-08-16  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
  94         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
  95         (struct tui_source_window_base) <make_visible, refresh_window,
  96         resize>: Remove methods.
  97         <execution_info>: Remove field.
  98         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
  99         (tui_show_source_line, tui_source_window_base)
 100         (~tui_source_window_base): Update.
 101         (tui_source_window_base::resize)
 102         (tui_source_window_base::make_visible)
 103         (tui_source_window_base::refresh_window): Remove.
 104         (tui_source_window_base::update_exec_info): Update.
 105         * tui/tui-source.c (tui_source_window::set_contents): Update.
 106         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 107
 108 2019-08-16  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 111         deprecated_query_hook.
 112
 113 2019-08-16  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 116         (tui_update_source_windows_with_line): Update.
 117         * tui/tui-source.h (struct tui_source_window)
 118         <show_symtab_source>: Declare.
 119         (tui_show_symtab_source): Don't declare.
 120         * tui/tui-source.c (tui_show_symtab_source): Rename from
 121         tui_show_symtab_source.
 122
 123 2019-08-16  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-winsource.h (struct tui_source_window_base)
 126         <set_contents>: Declare.
 127         * tui/tui-winsource.c
 128         (tui_source_window_base::update_source_window_as_is): Update.
 129         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 130         Declare.
 131         (tui_set_source_content): Don't declare.
 132         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 133         tui_set_source_content.
 134         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 135         Declare.
 136         (tui_set_disassem_content): Don't declare.
 137         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 138         tui_set_disassem_content.
 139
 140 2019-08-16  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-winsource.h (struct tui_source_window_base)
 143         <update_breakpoint_info>: Declare.
 144         (tui_update_breakpoint_info): Don't declare.
 145         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 146         (tui_update_all_breakpoint_info): Update.
 147         (tui_source_window_base::update_breakpoint_info): Rename from
 148         tui_update_breakpoint_info.
 149         (tui_source_window_base::update_exec_info): Update.
 150
 151 2019-08-16  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-winsource.h (struct tui_source_window_base)
 154         <update_source_window>: Declare.
 155         (tui_update_source_window): Don't declare.
 156         * tui/tui-winsource.c
 157         (tui_source_window_base::update_source_window): Rename from
 158         tui_update_source_window.
 159         (tui_source_window_base::rerender): Update.
 160         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 161         * tui/tui-disasm.c (tui_show_disassem)
 162         (tui_show_disassem_and_update_source)
 163         (tui_disasm_window::maybe_update): Update.
 164
 165 2019-08-16  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-winsource.h (struct tui_source_window_base)
 168         <update_source_window_as_is>: Declare.
 169         (tui_update_source_window_as_is): Don't declare.
 170         * tui/tui-winsource.c (tui_update_source_window): Update
 171         (tui_source_window_base::update_source_window_as_is): Rename from
 172         tui_update_source_window_as_is.
 173         (tui_source_window_base::refill): Update.
 174         * tui/tui-source.c (tui_show_symtab_source): Update.
 175         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 176         Update.
 177
 178 2019-08-16  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-winsource.h (tui_update_source_window)
 181         (tui_update_source_window_as_is): Remove "noerror" parameter.
 182         * tui/tui-winsource.c (tui_update_source_window)
 183         (tui_update_source_window_as_is): Remove "noerror" parameter.
 184         (tui_update_source_windows_with_addr)
 185         (tui_update_source_windows_with_line)
 186         (tui_source_window_base::rerender)
 187         (tui_source_window_base::refill): Update.
 188         * tui/tui-source.h (tui_set_source_content)
 189         (tui_show_symtab_source): Remove "noerror" parameter.
 190         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 191         parameter.
 192         (tui_show_symtab_source): Likewise.
 193         (tui_source_window::maybe_update): Update.
 194         * tui/tui-disasm.c (tui_show_disassem)
 195         (tui_show_disassem_and_update_source)
 196         (tui_disasm_window::do_scroll_vertical)
 197         (tui_disasm_window::maybe_update): Update.
 198
 199 2019-08-16  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui.c (tui_is_window_visible): Update.
 202         * tui/tui-wingeneral.c (tui_make_window)
 203         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 204         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 205         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 206         (tui_set_win_height_command, parse_scrolling_args): Update.
 207         * tui/tui-source.c (tui_source_window::style_changed): Update.
 208         * tui/tui-regs.c (tui_show_registers)
 209         (tui_data_window::first_data_item_displayed)
 210         (tui_data_window::delete_data_content_windows)
 211         (tui_check_register_values, tui_reg_command): Update.
 212         * tui/tui-disasm.c (tui_show_disassem): Update.
 213         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 214         method.
 215         <is_visible>: Remove field.
 216         * tui/tui-data.c (tui_next_win, tui_prev_win)
 217         (tui_delete_invisible_windows): Update.
 218
 219 2019-08-16  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-winsource.h (struct tui_source_window_base)
 222         <m_has_locator>: Remove.
 223         * tui/tui-layout.c (show_source_disasm_command, show_data)
 224         (show_source_or_disasm_and_command): Update.
 225
 226 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 227
 228         * NEWS (Other MI changes): New subsection.
 229         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 230         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 231         * arch-utils.c (default_get_pc_address_flags): New function.
 232         * arch-utils.h (default_get_pc_address_flags): New declaration.
 233         * gdbarch.sh: Add get_pc_address_flags.
 234         * gdbarch.c: Regenerate.
 235         * gdbarch.h: Likewise.
 236         * stack.c (print_pc): New function.
 237         (print_frame_info) (print_frame): Call print_pc.
 238
 239 2019-08-16  Tom de Vries  <tdevries@suse.de>
 240
 241         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 242         print_objfile_section_info.
 243
 244 2019-08-15  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 247         calling update_cmdwin_start_line.
 248         * tui/tui-winsource.h (struct tui_source_window_base)
 249         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 250         <rerender>: Declare.
 251         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 252         Call rerender.
 253         (tui_source_window_base::set_new_height): Remove.
 254         (tui_source_window_base::rerender): Rename from
 255         do_make_visible_with_new_height.
 256         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 257         resize method.
 258         (tui_win_info::make_invisible_and_set_new_height)
 259         (tui_win_info::make_visible_with_new_height): Remove.
 260         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 261         Declare.
 262         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 263         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 264         do_make_visible_with_new_height>: Don't declare.
 265         <rerender>: Declare.
 266         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 267         set_new_height.
 268         (tui_data_window::do_make_visible_with_new_height): Remove.
 269         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 270         call tui_show_locator_content.
 271         (tui_gen_win_info::resize): Call rerender.
 272         (show_source_or_disasm_and_command): Don't call
 273         tui_show_locator_content.
 274         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 275         method.
 276         (struct tui_win_info) <rerender>: Declare.
 277         <set_new_height, make_invisible_and_set_new_height,
 278         make_visible_with_new_height>: Don't declare.
 279         * tui/tui-data.c (tui_win_list::rerender): New method.
 280         * tui/tui-command.h (struct tui_cmd_window)
 281         <do_make_visible_with_new_height>: Don't declare.
 282         * tui/tui-command.c
 283         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 284
 285 2019-08-15  Tom Tromey  <tromey@adacore.com>
 286
 287         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 288         * ada-lang.c (ada_enum_name): Likewise.
 289
 290 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 291
 292         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 293         leading underscore.
 294         (GdbOutputErrorFile): Likewise.
 295         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 296         accordingly.
 297         (execute_unwinders): Rename to have a leading underscore.
 298         (auto_load_packages): Likewise.
 299         (global scope): Adjust call to auto_load_packages accordingly.
 300         (GdbSetPythonDirectory): Likewise.
 301         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 302         instead of execute_unwinders.
 303
 304 2019-08-15  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 307         (show_data): Don't change window visibility.
 308         (tui_gen_win_info::resize): Remove special case for command
 309         window.  Use wresize, when available.
 310         (show_source_or_disasm_and_command): Don't change window
 311         visibility.
 312         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 313         <make_visible>: New method.
 314         * tui/tui-command.c (tui_cmd_window::resize): New method.
 315
 316 2019-08-15  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 319         (struct tui_source_windows): New.
 320         * tui/tui-winsource.c (tui_display_main): Update.
 321         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 322         (new_height_ok, parse_scrolling_args): Update.
 323         * tui/tui-layout.c (show_layout, show_data): Update.
 324         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 325         (tui_add_to_source_windows): Don't declare.
 326         * tui/tui-data.c (source_windows, tui_source_windows)
 327         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 328
 329 2019-08-15  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 332         Rename from reset.
 333         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 334         * tui/tui-layout.c (show_source_disasm_command, show_data):
 335         Update.
 336         (tui_gen_win_info::resize): Rename.
 337         (show_source_or_disasm_and_command): Update.
 338         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 339         reset.
 340
 341 2019-08-15  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 344         * tui/tui-interp.c (tui_interp::init): Don't call
 345         tui_initialize_static_data.
 346         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 347
 348 2019-08-15  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 351         examine tui_win_list.
 352
 353 2019-08-15  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 356         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 357         tui_clear_source_content.
 358         (tui_clear_source_content): Remove.
 359         (tui_source_window_base::do_erase_source_content): Hoist call to
 360         content.clear().
 361         * tui/tui-stack.c (tui_show_frame_info): Don't call
 362         tui_clear_source_content.
 363
 364 2019-08-15  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-winsource.h (struct tui_source_window_base)
 367         <do_erase_source_content>: New method.
 368         <erase_source_content>: New method.
 369         (tui_erase_source_content): Don't declare.
 370         * tui/tui-winsource.c (tui_clear_source_content): Update.
 371         (tui_source_window_base::do_erase_source_content): Rename from
 372         tui_erase_source_content.
 373         (tui_source_window_base::show_source_content): Update.
 374         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 375         * tui/tui-source.h (struct tui_source_window)
 376         <erase_source_content>: New method.
 377         * tui/tui-disasm.h (struct tui_disasm_window)
 378         <erase_source_content>: New method.
 379
 380 2019-08-15  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 383         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 384         constructor.
 385         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 386         * tui/tui-source.c (tui_set_source_content): Update.
 387         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 388
 389 2019-08-15  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 392         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 393         tui-source.c.
 394         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 395         Declare.
 396         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 397         method.
 398         (tui_source_window::maybe_update): Update.
 399
 400 2019-08-15  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 403         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 404         tui-disasm.c.
 405         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 406         Declare.
 407         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 408         method.
 409         (tui_disasm_window::maybe_update): Update.
 410
 411 2019-08-15  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-winsource.h (struct tui_source_window_base)
 414         <maybe_update>: Declare.
 415         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 416         method.
 417         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 418         Declare.
 419         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 420         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 421         Declare.
 422         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 423
 424 2019-08-15  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 427
 428 2019-08-15  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-wingeneral.c: Include tui-stack.h.
 431         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 432         (struct tui_locator_window): Move from tui-data.h.
 433         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 434         (tui_initialize_static_data): Move from tui-data.c.
 435         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 436         (struct tui_locator_window): Move to tui-stack.c.
 437         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 438         (tui_initialize_static_data): Move to tui-stack.c.
 439
 440 2019-08-15  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-layout.c (show_source_disasm_command)
 443         (show_source_or_disasm_and_command): Use make_visible method, not
 444         tui_make_window.
 445         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 446         Remove.
 447
 448 2019-08-15  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-wingeneral.h (tui_make_window): Update.
 451         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 452         parameter.
 453         (tui_gen_win_info::make_visible): Update.
 454         * tui/tui-regs.c (tui_data_window::display_registers_from):
 455         Update.
 456         * tui/tui-layout.c (show_source_disasm_command)
 457         (show_source_or_disasm_and_command): Update.
 458         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 459         (enum tui_box): Remove.
 460         (struct tui_win_info) <can_box>: New method.
 461         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 462         method.
 463
 464 2019-08-15  Tom de Vries  <tdevries@suse.de>
 465
 466         * linux-nat-trad.c: Include gdbarch.h.
 467
 468 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 469
 470         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 471         register sizes.
 472
 473 2019-08-14  Tom Tromey  <tromey@adacore.com>
 474
 475         * darwin-nat.c: Include gdbarch.h.
 476         * darwin-nat-info.c: Include gdbarch.h.
 477
 478 2019-08-13  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 481         Remove.
 482         * tui/tui-data.c (tui_initialize_static_data): Update.
 483
 484 2019-08-13  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-winsource.h (struct tui_exec_info_window)
 487         <~tui_exec_info_window, maybe_allocate_content, get_content,
 488         m_content>: Remove.
 489         (struct tui_source_window_base) <set_exec_info_content,
 490         show_exec_info_content>: Don't declare.
 491         * tui/tui-winsource.c
 492         (tui_exec_info_window::maybe_allocate_content): Remove.
 493         (tui_source_window_base::update_exec_info): Rename from
 494         set_exec_info_content.
 495         (tui_source_window_base::show_exec_info_content)
 496         (tui_source_window_base::update_exec_info): Remove.
 497
 498 2019-08-13  Tom Tromey  <tom@tromey.com>
 499
 500         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 501         declare.
 502         * tui/tui-winsource.c (tui_update_source_window_as_is)
 503         (tui_update_source_windows_with_addr, tui_erase_source_content):
 504         Update.
 505         (tui_clear_exec_info_content): Remove.
 506
 507 2019-08-13  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 510         declare.
 511         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 512         call tui_erase_exec_info_content.
 513         (tui_clear_exec_info_content): Rename from
 514         tui_erase_exec_info_content.
 515         (tui_clear_exec_info_content): Delete.
 516
 517 2019-08-13  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-winsource.h (struct tui_source_window_base)
 520         <show_exec_info_content>: Declare.
 521         (tui_show_exec_info_content): Don't declare.
 522         * tui/tui-winsource.c
 523         (tui_source_window_base::show_exec_info_content): Rename from
 524         tui_show_exec_info_content.
 525         (tui_source_window_base::update_exec_info): Update.
 526
 527 2019-08-13  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 530         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 531         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 532         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 533         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 534         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 535         ... here.
 536
 537 2019-08-13  Tom Tromey  <tom@tromey.com>
 538
 539         * tui/tui-winsource.h (struct tui_source_window_base)
 540         <update_exec_info>: Declare.
 541         (tui_update_exec_info): Don't declare.
 542         * tui/tui-winsource.c (tui_update_source_window_as_is)
 543         (tui_source_window_base::refresh_all)
 544         (tui_update_all_breakpoint_info): Update.
 545         (tui_source_window_base::update_exec_info): Rename from
 546         tui_update_exec_info.
 547         * tui/tui-stack.c (tui_show_frame_info): Update.
 548
 549 2019-08-13  Tom Tromey  <tom@tromey.com>
 550
 551         * tui/tui-winsource.h (struct tui_source_window_base)
 552         <set_exec_info_content>: Declare.
 553         (tui_set_exec_info_content): Don't declare.
 554         * tui/tui-winsource.c
 555         (tui_source_window_base::set_exec_info_content): Rename from
 556         tui_set_exec_info_content.
 557         (tui_update_exec_info): Update.
 558
 559 2019-08-13  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-winsource.h (struct tui_source_window_base)
 562         <show_source_content>: Declare.
 563         (tui_show_source_content): Don't declare.
 564         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 565         (tui_source_window_base::show_source_content): Rename from
 566         tui_show_source_content.
 567         (tui_source_window_base::refresh_all): Update.
 568         * tui/tui-layout.c (show_source_disasm_command)
 569         (show_source_or_disasm_and_command): Update.
 570
 571 2019-08-13  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-winsource.c (tui_erase_source_content)
 574         (tui_show_source_content, tui_source_window_base::refresh_all):
 575         Update.
 576         * tui/tui-wingeneral.h
 577         (tui_check_and_display_highlight_if_needed): Don't declare.
 578         * tui/tui-wingeneral.c
 579         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 580         check_and_display_highlight_if_needed.
 581         * tui/tui-win.c (tui_rehighlight_all)
 582         (tui_win_info::make_visible_with_new_height): Update.
 583         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 584         (tui_data_window::erase_data_content)
 585         (tui_data_window::display_all_data): Update.
 586         * tui/tui-data.h (struct tui_win_info)
 587         <check_and_display_highlight_if_needed>: Declare.
 588
 589 2019-08-13  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-win.c (tui_resize_all): Call
 592         tui_delete_invisible_windows.
 593         * tui/tui-layout.c (show_layout): Call
 594         tui_delete_invisible_windows.
 595         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 596         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 597
 598 2019-08-13  Tom Tromey  <tom@tromey.com>
 599
 600         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 601         tui_add_win_to_layout.
 602
 603 2019-08-13  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 606         * tui/tui-layout.c (tui_default_win_height): Now static.
 607
 608 2019-08-13  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 611         single switch.
 612         (show_source_disasm_command, show_source_or_disasm_and_command):
 613         Don't check current layout.
 614
 615 2019-08-13  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-wingeneral.c (make_all_visible): Remove.
 618         (tui_make_all_invisible): Simplify.
 619         * tui/tui-layout.c (tui_make_all_invisible): Move from
 620         tui-wingeneral.c; simplify.
 621         (show_layout): Hoist call to tui_make_all_invisible.
 622         (show_data): Don't call tui_make_all_invisible.
 623
 624 2019-08-13  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 627         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 628
 629 2019-08-13  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 632         tui-data.c.
 633         (show_source_disasm_command, show_data)
 634         (show_source_or_disasm_and_command): Don't use
 635         tui_set_current_layout_to.
 636         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 637         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 638         tui-layout.c.
 639         (tui_set_current_layout_to): Remove.
 640
 641 2019-08-13  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-layout.c (tui_set_layout): Update.
 644         * tui/tui-data.h (struct tui_layout_def): Remove.
 645         (tui_layout_def): Don't declare.
 646         * tui/tui-data.c (layout_def): Remove.
 647         (tui_layout_def): Remove.
 648
 649 2019-08-13  Tom Tromey  <tom@tromey.com>
 650
 651         * tui/tui-winsource.h (struct tui_source_window_base)
 652         <clear_detail>: No longer "override".
 653         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 654         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 655         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 656         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 657         Remove.
 658         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 659
 660 2019-08-13  Tom Tromey  <tromey@adacore.com>
 661
 662         * tracepoint.c: Don't include readline.h or history.h.
 663
 664 2019-08-12  Tom Tromey  <tom@tromey.com>
 665
 666         * configure: Rebuild.
 667         * configure.ac: Check for readline 7.
 668         * NEWS: Mention readline 7 requirement.
 669         * README: Update.
 670
 671 2019-08-12  Tom Tromey  <tom@tromey.com>
 672
 673         * mingw-hdep.c (gdb_select): Remove readline hack.
 674
 675 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 676
 677         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 678         when the function fails.
 679
 680 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 681
 682         * s390-tdep.c (s390_type_align): New function.
 683         (s390_gdbarch_init): Set it as type_align gdbarch method.
 684
 685 2019-08-09  Tom de Vries  <tdevries@suse.de>
 686
 687         PR gdb/24591
 688         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 689         pc_low with relocation offset.
 690
 691 2019-08-07  Tom Tromey  <tromey@adacore.com>
 692
 693         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 694         (print_frame_args): Update.
 695         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 696         Update.
 697         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 698         * frame.h (struct frame_arg): Add initializers.
 699         <error>: Now a unique_xmalloc_ptr.
 700
 701 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 702
 703         * NEWS: Expand the Pointer Authentication entry.
 704         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 705         (aarch64_frame_unmask_lr): ... to this.
 706         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 707         Call aarch64_frame_unmask_lr.
 708         * frame.c (struct frame_info): Add "masked" variable.
 709         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 710         (fprint_frame): Check for masked pc.
 711         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 712         declarations.
 713         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 714         * stack.c (print_frame): Check for masked pc.
 715
 716 2019-08-06  Tom Tromey  <tom@tromey.com>
 717
 718         * stabsread.c (patch_block_stabs, read_one_struct_field)
 719         (read_enum_type): Use obstack_strndup.
 720         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 721         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 722         * dwarf2read.c (guess_full_die_structure_name)
 723         (anonymous_struct_prefix): Use obstack_strndup.
 724         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 725         * c-exp.y (yylex): Use obstack_strndup.
 726         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 727         (write_var_or_type): Use obstack_strndup.
 728
 729 2019-08-06  Tom Tromey  <tom@tromey.com>
 730
 731         * symfile.c (reread_symbols): Use obstack_strdup.
 732         * stabsread.c (read_type): Use obstack_strdup.
 733         * gdb_obstack.h (obstack_strdup): New overload.
 734         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 735         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 736         (dwarf2_canonicalize_name): Use obstack_strdup.
 737         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 738         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 739         Use obstack_strdup.
 740
 741 2019-08-06  Tom Tromey  <tom@tromey.com>
 742
 743         * gdb_obstack.h (obstack_strdup): Define.
 744         * gdb_obstack.c (obstack_strdup): Don't define.
 745
 746 2019-08-06  Tom Tromey  <tom@tromey.com>
 747
 748         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 749         obstack_strdup.
 750         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 751         obstack_strdup.
 752         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 753         * stabsread.c (common_block_start): Use obstack_strdup.
 754         * objfiles.c (set_objfile_main_name, objfile): Use
 755         obstack_strdup.
 756         * namespace.c (add_using_directive): Use obstack_strdup.
 757         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 758         * jit.c (finalize_symtab): Use obstack_strdup.
 759         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 760         (guess_partial_die_structure_name, partial_die_info::fixup)
 761         (dwarf2_name): Use obstack_strdup.
 762         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 763         obstack_strdup.
 764         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 765         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 766         obstack_strdup.
 767         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 768
 769 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 770
 771         * unittests/help-doc-selftests.c: New file.
 772         * Makefile.in: Add the new file.
 773
 774 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 775
 776         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 777         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 778         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 779         the trailing '.' is not output, and the first character is uppercased.
 780         (print_help_for_command): Update call to print_doc_line.
 781         (print_doc_of_command): Likewise.
 782         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 783         * cli/cli-option.c (append_indented_doc): Do not append newline.
 784         (build_help_option): Append newline after first appended_indented_doc
 785         only if a second call is done.
 786         (build_help): Append 2 new lines before each option, except the first
 787         one.
 788         * compile/compile.c (_initialize_compile): Add new lines after
 789         %OPTIONS%, when not at the end of the help.
 790         Change help doc or code
 791         producing the help doc to respect the invariants.
 792         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 793         Also removed the new line after 'Options:', as all other commands
 794         do not put an empty line between 'Options:' and the first option.
 795         * printcmd.c (_initialize_printcmd): Likewise.
 796         * stack.c (_initialize_stack): Likewise.
 797         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 798         incorrectly telling COMMAND is optional.
 799         * ada-lang.c (_initialize_ada_language): Change help doc or code
 800         producing the help doc to respect the invariants.
 801         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 802         * breakpoint.c (_initialize_breakpoint): Likewise.
 803         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 804         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 805         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 806         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 807         _initialize_cli_style): Likewise.
 808         * corelow.c (core_target_info): Likewise.
 809         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 810         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 811         * filesystem.c (_initialize_filesystem): Likewise.
 812         * frame.c (_initialize_frame): Likewise.
 813         * gnu-nat.c (add_task_commands): Likewise.
 814         * infcall.c (_initialize_infcall): Likewise.
 815         * infcmd.c (_initialize_infcmd): Likewise.
 816         * interps.c (_initialize_interpreter): Likewise.
 817         * language.c (_initialize_language): Likewise.
 818         * linux-fork.c (_initialize_linux_fork): Likewise.
 819         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 820         * maint.c (_initialize_maint_cmds): Likewise.
 821         * memattr.c (_initialize_mem): Likewise.
 822         * printcmd.c (_initialize_printcmd): Likewise.
 823         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 824         _RegEx): Likewise.
 825         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 826         * record-btrace.c (_initialize_record_btrace): Likewise.
 827         * record-full.c (_initialize_record_full): Likewise.
 828         * record.c (_initialize_record): Likewise.
 829         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 830         * regcache.c (_initialize_regcache): Likewise.
 831         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 832         _initialize_remote): Likewise.
 833         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 834         * serial.c (_initialize_serial): Likewise.
 835         * skip.c (_initialize_step_skip): Likewise.
 836         * source.c (_initialize_source): Likewise.
 837         * stack.c (_initialize_stack): Likewise.
 838         * symfile.c (_initialize_symfile): Likewise.
 839         * symtab.c (_initialize_symtab): Likewise.
 840         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 841         * top.c (init_main): Likewise.
 842         * tracefile-tfile.c (tfile_target_info): Likewise.
 843         * tracepoint.c (_initialize_tracepoint): Likewise.
 844         * tui/tui-win.c (_initialize_tui_win): Likewise.
 845         * utils.c (add_internal_problem_command): Likewise.
 846         * valprint.c (value_print_option_defs): Likewise.
 847
 848 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 849
 850         PR build/24886
 851         * configure.ac: Drop enable-libmcheck support.
 852         * configure, config.in: Rebuild.
 853         * libmcheck.m4: Remove.
 854         * acinclude.m4: Don't include it.
 855         * Makefile.in: Don't distribute it.
 856         * top.c (print_gdb_configuration): Don't mention it.
 857
 858 2019-08-06  Tom Tromey  <tom@tromey.com>
 859
 860         * utils.c (set_output_style): Sometimes pass stream to
 861         emit_style_escape.
 862         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 863         * record-btrace.c (btrace_insn_history): Update.
 864         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 865         method.
 866         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 867         Update initializers.
 868         <m_uiout>: New field.
 869         <m_di>: Move lower.
 870         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 871         Remove "uiout" parameter.
 872         (dump_insns): Update.
 873         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 874         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 875
 876 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 877
 878         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 879         (error_in_psymtab_expansion): Likewise.
 880         (lookup_symbol_via_quick_fns): Likewise.
 881         (basic_lookup_transparent_type_quick): Likewise.
 882         (basic_lookup_transparent_type_1): Likewise.
 883
 884 2019-08-06  Tom Tromey  <tromey@adacore.com>
 885
 886         * source.c (last_source_error): Now bool.
 887         (print_source_lines_base): Make "noprint" bool.  Only open
 888         source file when last_source_visited changes.
 889
 890 2019-08-06  Tom Tromey  <tromey@adacore.com>
 891
 892         * annotate.c (annotate_source_line): Use g_source_cache.
 893         * source-cache.c (source_cache::get_plain_source_lines): Change
 894         parameters.  Populate m_offset_cache.
 895         (source_cache::ensure): New method.
 896         (source_cache::get_line_charpos): New method.
 897         (extract_lines): Move lower.  Change parameters.
 898         (source_cache::get_source_lines): Move lower.
 899         * source-cache.h (class source_cache): Update comment.
 900         <get_line_charpos>: New method.
 901         <get_source_lines>: Update comment.
 902         <clear>: Clear m_offset_cache.
 903         <get_plain_source_lines>: Change parameters.
 904         <ensure>: New method
 905         <m_offset_cache>: New member.
 906         * source.c (forget_cached_source_info_for_objfile): Update.
 907         (info_source_command): Use g_source_cache.
 908         (find_source_lines, open_source_file_with_line_charpos): Remove.
 909         (print_source_lines_base, search_command_helper): Use g_source_cache.
 910         * source.h (open_source_file_with_line_charpos): Don't declare.
 911         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 912         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 913         Use g_source_cache.
 914
 915 2019-08-06  Tom Tromey  <tromey@adacore.com>
 916
 917         * source-cache.c (source_cache::get_plain_source_lines):
 918         Remove "first_line" and "last_line" parameters.
 919         (source_cache::get_source_lines): Cache plain text.
 920         * source-cache.h (class source_cache)
 921         <get_plain_source_lines>: Update.
 922
 923 2019-08-06  Tom Tromey  <tromey@adacore.com>
 924
 925         * source-cache.c (extract_lines): No longer a method.
 926         Changed type of parameter.  Include final newline.
 927         (selftests::extract_lines_test): New function.
 928         (_initialize_source_cache): Likewise.
 929         * source-cache.h (class source_cache)
 930         <extract_lines>: Don't declare.
 931
 932 2019-08-06  Tom Tromey  <tromey@adacore.com>
 933
 934         * breakpoint.c (init_breakpoint_sal): Update.
 935         (breakpoint): Update.
 936         * breakpoint.h (struct breakpoint) <filter>: Now a
 937         unique_xmalloc_ptr.
 938
 939 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 940
 941         * NEWS: Mention dictionary access on blocks.
 942         * python/py-block.c (blpy_getitem): New function.
 943         (block_object_as_mapping): New struct.
 944         (block_object_type): Use new struct for tp_as_mapping field.
 945
 946 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 947
 948         * objfiles.h (objfile): Add a comment describing partial symbols.
 949
 950 2019-08-05  Tom Tromey  <tromey@adacore.com>
 951
 952         * compile/compile.c (_initialize_compile): Use _(), not N_().
 953         * thread.c (_initialize_thread): Use _(), not N_().
 954         * stack.c (_initialize_stack): Use _(), not N_().
 955         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 956
 957 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 958
 959         * dwarf2read.c (struct dw2_symtab_iterator):
 960         <want_specific_block>: Remove.
 961         <block_index>: Change type to gdb::optional.
 962         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 963         change type of BLOCK_INDEX parameter to gdb::optional.
 964         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 965         (dw2_lookup_symbol): Don't pass argument for
 966         WANT_SPECIFIC_BLOCK.
 967         (dw2_expand_symtabs_for_function): Don't pass argument for
 968         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 969         (class dw2_debug_names_iterator)
 970         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 971         parameter, change BLOCK_INDEX type to gdb::optional.
 972         <m_want_specific_block>: Remove.
 973         <m_block_index>: Change type to gdb::optional.
 974         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 975         gdb::optional.  Re-write in function of gdb::optional.
 976         (dw2_debug_names_lookup_symbol): Don't pass argument for
 977         WANT_SPECIFIC_BLOCK.
 978         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 979         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 980         BLOCK_INDEX.
 981
 982 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 983
 984         * NEWS: Mention changes to "info sources" command.
 985
 986 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 987
 988         * symtab.c (filename_partial_match_opts): New struct type.
 989         (struct output_source_filename_data): New members
 990         regexp, c_regexp, partial_match.
 991         (output_source_filename): Use new members to decide to print file.
 992         (info_sources_option_defs): New variable.
 993         (make_info_sources_options_def_group, print_info_sources_header,
 994         info_sources_command_completer):
 995         New functions.
 996         (info_sources_command): Read new optional arguments.
 997         (_initialize_symtab): Update info sources help.
 998
 999 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1000
1001         * ada-lang.c (exception_support_info_v0): Renamed from...
1002         (default_exception_support_info): ... this.  Create new
1003         definition for v1.
1004         (ada_has_this_exception_support): Look up catch_handlers_sym.
1005         (ada_exception_support_info_sniffer): Try v0 after default.
1006
1007 2019-08-01  Tom Tromey  <tromey@adacore.com>
1008
1009         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1010         gdbarch.h.
1011
1012 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1013
1014         * s12z-tdep.c: Fix include path for s12z-opc.h.
1015
1016 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1017
1018         * NEWS: Require GNU make 3.82.
1019
1020 2019-07-16  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1023         declare.
1024
1025 2019-07-30  Tom Tromey  <tromey@adacore.com>
1026
1027         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1028
1029 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1030
1031         * printcmd.c (print_address_symbolic): Print negative offsets.
1032         (build_address_symbolic): Force signed arithmetic when computing
1033         offset.
1034
1035 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1036
1037         PR/24474: Add a function to lookup static variables.
1038         * NEWS: Mention this new function.
1039         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1040         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1041         * python/python.c (python_GdbMethods): Add new function.
1042
1043 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1044
1045         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1046         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1047         (objfpy_lookup_static_symbol): New function.
1048         (objfile_object_methods): Add new functions.
1049
1050 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1051
1052         * NEWS: Mention 'set|show print frame-info'.  Mention new
1053         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1054         backtrace argument.  Mention that python frame filtering code
1055         is now consistent with what 'backtrace' command prints.
1056
1057 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1058
1059         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1060         comments.
1061         (print_frame_info_auto, print_frame_info_source_line,
1062         print_frame_info_location, print_frame_info_source_and_location,
1063         print_frame_info_location_and_address, print_frame_info_short_location):
1064         New declarations.
1065         (struct frame_print_options): New member print_frame_info.
1066         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1067         * stack.h (get_user_print_what_frame_info): New declaration.
1068         (frame_show_address): New declaration.
1069         * stack.c (print_frame_arguments_choices): New value 'presence'.
1070         (print_frame_info_auto, print_frame_info_source_line,
1071         print_frame_info_location, print_frame_info_source_and_location,
1072         print_frame_info_location_and_address, print_frame_info_short_location,
1073         print_frame_info_choices, print_frame_info_print_what): New definitions.
1074         (print_frame_args): Only print dots for args if print frame-arguments
1075         is 'presence'.
1076         (frame_print_option_defs): New element for "frame-info".
1077         (get_user_print_what_frame_info): New function.
1078         (frame_show_address): Make non static.  Move comment to stack.h.
1079         (print_frame_info_to_print_what): New function.
1080         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1081         to decide what to print.
1082         (backtrace_command_1): Handle the new print_frame_arguments_presence
1083         value.
1084         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1085         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1086         (py_print_frame): In non-mi mode, use LOCATION as default for
1087         print_what, similarly to frame information printed directly by
1088         backtrace command. Handle frame-info user option in non MI mode.
1089
1090 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1091
1092         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1093         Add case for debugging 32-bit target on 64-bit host.  Revise
1094         comment.
1095
1096 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1097
1098         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1099         instead of find_function_entry_range_from_pc.
1100
1101 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1102
1103         * stack.c (find_frame_funname): Remove code which preferred
1104         minsym over symtab sym in "certain pathological cases".
1105
1106         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1107         parameter.  Change type of "do_demangle" to bool.
1108         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1109         Pass suitable "prefer_sym_over_minsym" flag to
1110         build_address_symbolic().  Don't output "+" for negative offsets.
1111         * printcmd.c (print_address_symbolic): Update invocation of
1112         build_address_symbolic to include a "prefer_sym_over_minsym"
1113         flag.
1114         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1115         Restrict cases in which use of minimal symbol is preferred to that
1116         of a found symbol.  Update comments.
1117
1118         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1119         for entry pc when entry pc is out of range for that FDE.
1120
1121 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1122
1123         PR gdb/24839:
1124         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1125         type.
1126
1127 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1128
1129         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1130         this function's Python signature.
1131
1132
1133 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1134
1135         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1136         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1137         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1138         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1139         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1140
1141
1142 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1143
1144         * h8300-tdep.c (h8300_register_name_common): New.
1145         h8300_register_name): Use h8300_register_name_common.
1146         (h8300s_register_name): Likewise.
1147         (h8300sx_register_name): Likewise.
1148         (h8300h_register_nam): New.
1149         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1150
1151
1152 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1153
1154         * arm-tdep.c (arm_skip_cmse_entry): New function.
1155         (arm_is_sgstubs_section): New function.
1156         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1157
1158 2019-07-22  Tom Tromey  <tom@tromey.com>
1159
1160         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1161         Don't self-assign.
1162
1163 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1166         type_print.
1167
1168 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1169
1170         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1171         so that GDB doesn't match any msymbols when searching in the
1172         TYPES_DOMAIN.
1173         (print_symbol_info): Print using typedef_print or type_print based
1174         on the type of the symbol.  Add updated FIXME comment moved from...
1175         (_initialize_symtab): ... move and update FIXME comment to above.
1176
1177 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1178
1179         * NEWS: Mention adding -q option to "info types".
1180         * symtab.c (struct info_types_options): New struct.
1181         (info_types_options_defs): New variable.
1182         (make_info_types_options_def_group): New function.
1183         (info_types_command): Use gdb::option framework to parse options.
1184         (info_types_command_completer): New function.
1185         (_initialize_symtab): Extend the help text on "info types" and
1186         register command completer.
1187
1188 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1189
1190         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1191         (lookup_symbol_in_objfile): Change int to block_enum and add a
1192         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1193
1194 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1195
1196         * MAINTAINERS (Write After Approval): Add self.
1197
1198 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1199
1200         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1201         instruction to the dummy code region.
1202
1203 2019-07-19  Tom Tromey  <tromey@adacore.com>
1204
1205         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1206         (ARGSUSED, PARAMS, __func__): Remove rules.
1207
1208 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1209
1210         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1211         * features/arm/arm-with-iwmmxt.c: Remove.
1212         * features/arm/arm-with-iwmmxt.xml: Remove.
1213         * features/arm/arm-with-m-fpa-layout.c: Remove.
1214         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1215         * features/arm/arm-with-m-vfp-d16.c: Remove.
1216         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1217         * features/arm/arm-with-m.c: Remove.
1218         * features/arm/arm-with-m.xml: Remove.
1219         * features/arm/arm-with-neon.c: Remove.
1220         * features/arm/arm-with-neon.xml: Remove.
1221         * features/arm/arm-with-vfpv2.c: Remove.
1222         * features/arm/arm-with-vfpv2.xml: Remove.
1223         * features/arm/arm-with-vfpv3.c: Remove.
1224         * features/arm/arm-with-vfpv3.xml: Remove.
1225
1226 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1227
1228         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1229
1230 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1231
1232         * arch/aarch32.c (aarch32_create_target_description): Create
1233         target descriptions using features.
1234         * arch/arm.c (arm_create_target_description)
1235         (arm_create_mprofile_target_description): Likewise.
1236         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1237
1238 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1239
1240         * Makefile.in: Add new files.
1241         * aarch32-tdep.c: New file.
1242         * aarch32-tdep.h: New file.
1243         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1244         Call aarch32_read_description.
1245         * arch/aarch32.c: New file.
1246         * arch/aarch32.h: New file.
1247         * arch/arm.c (arm_create_target_description)
1248         (arm_create_mprofile_target_description): New function.
1249         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1250         (arm_create_target_description)
1251         (arm_create_mprofile_target_description): New declaration.
1252         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1253         read_description functions.
1254         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1255         Likewise.
1256         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1257         * arm-tdep.c (tdesc_arm_list): New variable.
1258         (arm_register_g_packet_guesses): Call create description functions.
1259         (arm_read_description) (arm_read_mprofile_description): New
1260         function.
1261         * arm-tdep.h (arm_read_description)
1262         (arm_read_mprofile_description): Add declaration.
1263         * configure.tgt: Add new files.
1264
1265 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1266
1267         * top.c (new_ui_command): Open specified terminal just once.
1268
1269 2019-07-18  Tom Tromey  <tromey@adacore.com>
1270
1271         * symtab.c (main_name): Constify return type.
1272         * symfile.c (set_initial_language): Update.
1273         * symtab.h (main_name): Constify return type.
1274
1275 2019-07-17  Tom Tromey  <tom@tromey.com>
1276
1277         * tui/tui-winsource.c (tui_update_source_window)
1278         (tui_update_source_window_as_is)
1279         (tui_update_source_windows_with_line): Remove return.
1280         * tui/tui-disasm.c (tui_show_disassem)
1281         (tui_show_disassem_and_update_source): Remove return.
1282         * tui/tui.c (tui_reset): Remove return.
1283         * tui/tui-wingeneral.c
1284         (tui_check_and_display_highlight_if_needed): Remove return.
1285
1286 2019-07-17  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1289
1290 2019-07-17  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-winsource.h (struct tui_exec_info_window)
1293         (struct tui_source_window_base): Move from tui-data.h.
1294         * tui/tui-winsource.c: Move many method definitions from
1295         elsewhere.  Remove "structuring" comments.
1296         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1297         (tui_source_window_base::refresh_window): Move to
1298         tui-winsource.c.
1299         * tui/tui-win.c (tui_source_window_base::refresh_all)
1300         (tui_source_window_base::update_tab_width)
1301         (tui_source_window_base::set_new_height)
1302         (tui_source_window_base::do_make_visible_with_new_height): Move to
1303         tui-winsource.c.
1304         * tui/tui-source.h: Update.
1305         * tui/tui-source.c (tui_source_window_base::reset): Move to
1306         tui-winsource.c.
1307         * tui/tui-disasm.h: Update.
1308         * tui/tui-data.h (struct tui_exec_info_window): Move to
1309         tui-winsource.h.
1310         (struct tui_source_window_base): Likewise.
1311         * tui/tui-data.c (tui_source_window_base::clear_detail)
1312         (tui_source_window_base, ~tui_source_window_base): Move to
1313         tui-winsource.c.
1314
1315 2019-07-17  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-win.c (tui_resize_all)
1318         (tui_source_window_base::update_tab_width)
1319         (tui_adjust_win_heights): Update.
1320         (tui_win_info::make_invisible_and_set_new_height): Rename from
1321         make_invisible_and_set_new_height.
1322         * tui/tui-data.h (struct tui_win_info)
1323         <make_invisible_and_set_new_height>: New method.
1324
1325 2019-07-17  Tom Tromey  <tom@tromey.com>
1326
1327         * tui/tui.c: Update.
1328         * tui/tui-source.h (struct tui_source_window): Move from
1329         tui-data.h.
1330         * tui/tui-layout.c: Update.
1331         * tui/tui-disasm.c: Update.
1332         * tui/tui-data.h (struct tui_source_window): Move to
1333         tui-source.h.
1334
1335 2019-07-17  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1338         tui-data.h.
1339         * tui/tui-data.h (struct tui_disasm_window): Move to
1340         tui-disasm.h.
1341
1342 2019-07-17  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-regs.h (struct tui_data_item_window): Move from
1345         tui-data.h.
1346         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1347         * tui/tui-data.h (struct tui_data_item_window): Move to
1348         tui-regs.h.
1349         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1350
1351 2019-07-17  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui.c: Update.
1354         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1355         (tui_cmd_window::max_height): Move to tui-command.c.
1356         * tui/tui-layout.c: Update.
1357         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1358         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1359         tui-command.c.
1360         * tui/tui-command.h (struct tui_cmd_window): Move from
1361         tui-data.h.
1362         * tui/tui-command.c: Remove "structuring" comments.
1363         (tui_cmd_window::clear_detail)
1364         (tui_cmd_window::do_make_visible_with_new_height)
1365         (tui_cmd_window::max_height): Move from elsewhere.
1366
1367 2019-07-17  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1370         Now static.
1371         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1372         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1373
1374 2019-07-17  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui.c: Update.
1377         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1378         tui-regs.c.
1379         * tui/tui-windata.h: Remove file.
1380         * tui/tui-windata.c: Remove file.
1381         * tui/tui-win.c (tui_data_window::set_new_height)
1382         (tui_data_window::do_make_visible_with_new_height): Move to
1383         tui-regs.c.
1384         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1385         * tui/tui-regs.c: Remove "structuring" comments.
1386         (tui_data_window::first_data_item_displayed)
1387         (tui_data_window::delete_data_content_windows)
1388         (tui_data_window::erase_data_content)
1389         (tui_data_window::display_all_data)
1390         (tui_data_window::refresh_all)
1391         (tui_data_window::do_scroll_vertical)
1392         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1393         (tui_data_window::do_make_visible_with_new_height)
1394         (tui_data_window::refresh_window): Move from elsewhere.
1395         (_initialize_tui_regs): Move to end of file.
1396         * tui/tui-layout.c: Update.
1397         * tui/tui-hooks.c: Update.
1398         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1399         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1400         tui-regs.c.
1401         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1402
1403 2019-07-17  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1406         seen.
1407
1408 2019-07-17  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-win.c (tui_source_window_base::set_new_height)
1411         (tui_source_window_base::do_make_visible_with_new_height): Use
1412         m_has_locator field directly.
1413         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1414         method.
1415         (struct tui_source_window_base) <has_locator>: Likewise.
1416
1417 2019-07-17  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1420         Don't declare.
1421         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1422         Remove.
1423         * tui/tui-win.c (tui_source_window_base::set_new_height)
1424         (tui_source_window_base::set_new_height)
1425         (make_invisible_and_set_new_height)
1426         (tui_source_window_base::do_make_visible_with_new_height)
1427         (tui_source_window_base::do_make_visible_with_new_height):
1428         Update.
1429         * tui/tui-layout.c (show_source_disasm_command, show_data)
1430         (show_source_or_disasm_and_command): Update.
1431         * tui/tui-layout.c (show_layout): Update.
1432
1433 2019-07-17  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-layout.c (make_data_window): Remove.
1436         (show_data): Unify creation and re-initialization cases.
1437
1438 2019-07-17  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-layout.c (make_source_window, make_disasm_window):
1441         Remove.
1442         (show_data): Unify creation and re-initialization cases.
1443
1444 2019-07-17  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-layout.c (make_command_window): Remove.
1447         (show_source_disasm_command, show_source_or_disasm_and_command):
1448         Unify creation and re-initialization cases.
1449
1450 2019-07-17  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1453         creation and re-initialization cases.
1454
1455 2019-07-17  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-regs.c (tui_get_register): Return void.
1458
1459 2019-07-17  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1462         Simplify.
1463
1464 2019-07-17  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1467         resetting.
1468
1469 2019-07-17  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1472         * tui/tui-regs.c (tui_reg_layout): New function.
1473         (tui_show_registers, tui_reg_command): Use it.
1474         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1475         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1476         parameters.
1477         (tui_layout_command): Remove.
1478
1479 2019-07-17  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-layout.h (tui/tui-layout): Return void.
1482         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1483
1484 2019-07-17  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-layout.c (show_source_disasm_command, show_data):
1487         Update.
1488         (reset_locator): Remove.
1489         (show_source_or_disasm_and_command): Update.
1490
1491 2019-07-17  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-source.c (tui_source_window_base::reset): Remove
1494         win_type parameter.
1495         * tui/tui-layout.c (make_command_window, make_source_window)
1496         (make_disasm_window, make_data_window)
1497         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1498         (reset_locator, show_source_or_disasm_and_command): Update.
1499         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1500         win_type parameter.
1501         (struct tui_source_window_base) <reset>: Likewise.
1502
1503 2019-07-17  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-layout.c (show_source_disasm_command): Use
1506         reset_locator.
1507         (reset_locator): New function.
1508         (init_and_make_win): Remove.
1509         (show_source_or_disasm_and_command): Use reset_locator.
1510
1511 2019-07-17  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1514         condition.
1515         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1516         Remove condition.
1517         * tui/tui-source.c (tui_source_window_base::reset): New method.
1518         * tui/tui-layout.c (make_command_window): Don't call
1519         init_and_make_win.
1520         (make_source_window, make_disasm_window): Don't call
1521         make_source_or_disasm_window.
1522         (make_data_window): Don't call init_and_make_win.  Change calling
1523         convention.
1524         (show_source_disasm_command, show_data): Simplify.
1525         (make_source_or_disasm_window): Remove.
1526         (show_source_or_disasm_and_command): Simplify.
1527         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1528         (struct tui_source_window_base) <reset>: Likewise.
1529         <execution_info>: Remove initializer.
1530         * tui/tui-data.c (tui_source_window_base): Initialize
1531         execution_info.
1532
1533 2019-07-17  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1536         variable.
1537
1538 2019-07-17  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui.c (tui_rl_other_window): Update.
1541         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1542         superclass method first.  Always iterate over regs_content.
1543         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1544         method.
1545         * tui/tui-win.c (tui_set_focus_command): Update.
1546
1547 2019-07-17  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-win.c (tui_set_focus_command): Rename from
1550         tui_set_focus.  Call tui_enable.
1551         (tui_set_focus_command): Remove.
1552
1553 2019-07-17  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1556         refresh_window.
1557         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1558         touchwin.
1559         (tui_data_window::refresh_window): Call refresh_window on data
1560         items.  Always call superclass refresh_window.
1561         (tui_win_info::refresh): Remove.
1562         (tui_source_window_base::refresh_window): Update.
1563         (tui_refresh_all): Update.
1564         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1565         refresh_window.
1566         (show_source_or_disasm_and_command): Likewise.
1567         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1568         (struct tui_source_window_base) <refresh>: Likewise.
1569
1570 2019-07-17  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-winsource.c (tui_clear_source_content)
1573         (tui_show_source_content): Update.
1574         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1575         whether content is empty.
1576         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1577         Remove.
1578
1579 2019-07-17  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1582         window's contents.
1583         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1584         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1585
1586 2019-07-17  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1589         (struct tui_data_item_window): Update.
1590
1591 2019-07-17  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1594         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1595         defines.
1596
1597 2019-07-17  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-winsource.h (tui_erase_source_content)
1600         (tui_clear_source_content): Remove "display_prompt" parameter.
1601         * tui/tui-winsource.c (tui_update_source_window_as_is)
1602         (tui_update_source_windows_with_addr): Update.
1603         (tui_clear_source_content): Remove "display_prompt" parameter.
1604         (tui_erase_source_content): Likewise.  Simplify.
1605         (tui_show_source_content): Update.
1606         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1607         * tui/tui-stack.c (tui_show_frame_info): Update.
1608         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1609         Remove defines.
1610
1611 2019-07-17  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1614         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1615         parameter.
1616         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1617         parameter.
1618
1619 2019-07-17  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-winsource.c (tui_clear_source_content)
1622         (tui_show_source_content, tui_show_exec_info_content)
1623         (tui_clear_exec_info_content): Update.
1624         * tui/tui-stack.c (tui_show_locator_content): Update.
1625         (tui_show_frame_info): Update.
1626         * tui/tui-source.h (tui_source_window): Don't declare.
1627         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1628         from tui_source_is_displayed.
1629         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1630         Remove field.
1631         (struct tui_source_window_base) <content_in_use>: New field.  Now
1632         bool.
1633         (struct tui_source_window) <showing_source_p>: New method.
1634         (TUI_SRC_WIN): Change cast.
1635         * tui/tui-data.c (tui_initialize_static_data): Update.
1636
1637 2019-07-17  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1640         location_matches_p.
1641         * tui/tui-source.c (tui_source_window::location_matches_p): New
1642         method.
1643         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1644         method.
1645         * tui/tui-data.h (struct tui_source_window_base)
1646         <location_matches_p>: New method.
1647         (struct tui_source_window, struct tui_disasm_window)
1648         <location_matches_p>: Likewise.
1649
1650 2019-07-17  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-win.c (tui_set_win_height_command): Rename from
1653         tui_set_win_height.
1654         (tui_set_win_height_command): Remove.
1655
1656 2019-07-17  Tom Tromey  <tom@tromey.com>
1657
1658         * tui/tui-source.c (tui_source_window): New constructor.  Add
1659         observer.
1660         (~tui_source_window): New destructor.
1661         (tui_source_window::style_changed): New method.
1662         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1663         (tui_attach_detach_observers): Update.
1664         * tui/tui-data.h (struct tui_source_window): Make constructor not
1665         inline.  Add destructor.
1666         (struct tui_source_window) <style_changed>: New method.
1667         <m_observable>: New member.
1668
1669 2019-07-17  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1672         * tui/tui-win.c (tui_resize_all): Fix typo.
1673
1674 2019-07-17  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1677         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1678         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1679         * tui/tui-win.c (window_name_completer): Use foreach.
1680         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1681         (update_tab_width): Likewise.
1682         * tui/tui-layout.c (show_layout): Update.
1683         * tui/tui-data.h (class tui_window_iterator): New.
1684         (struct all_tui_windows): New.
1685         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1686
1687 2019-07-17  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1690         parameter.  Don't reference globals.
1691         (tui_reg_command): Update.
1692
1693 2019-07-17  Tom Tromey  <tom@tromey.com>
1694
1695         * tui/tui-regs.c (tui_show_registers): Simplify.
1696
1697 2019-07-17  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-regs.c (tui_show_registers): Update.
1700         (tui_show_register_group): Add win_info parameter.
1701
1702 2019-07-17  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1705         Rename from tui_display_reg_element_at_line.
1706         (tui_data_window::display_registers_from_line): Update.
1707         * tui/tui-data.h (struct tui_data_window)
1708         <display_reg_element_at_line>: New method.
1709
1710 2019-07-17  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui-regs.h (tui_display_registers_from)
1713         (tui_display_registers_from_line): Don't declare.
1714         * tui/tui-windata.c (tui_data_window::display_all_data)
1715         (tui_data_window::refresh_all)
1716         (tui_data_window::do_scroll_vertical): Update.
1717         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1718         from tui_display_registers_from.
1719         (tui_display_reg_element_at_line): Update.
1720         (tui_data_window::display_registers_from_line): Rename from
1721         tui_display_registers_from_line.
1722         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1723         display_registers_from_line>: New methods.
1724
1725 2019-07-17  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1728         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1729         from tui_erase_data_content.
1730         (tui_data_window::display_all_data)
1731         (tui_data_window::refresh_all)
1732         (tui_data_window::do_scroll_vertical): Update.
1733         * tui/tui-regs.c (tui_show_registers): Update.
1734         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1735         New method.
1736
1737 2019-07-17  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1740         declare.
1741         * tui/tui-windata.c
1742         (tui_data_window::delete_data_content_windows): Rename from
1743         tui_delete_data_content_windows.
1744         (tui_data_window::display_all_data)
1745         (tui_data_window::do_scroll_vertical): Update.
1746         * tui/tui-data.h (struct tui_data_window)
1747         <delete_data_content_windows>: New method.
1748
1749 2019-07-17  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1752         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1753
1754 2019-07-17  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1757         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1758         from tui_display_all_data.
1759         * tui/tui-win.c
1760         (tui_data_window::do_make_visible_with_new_height): Update.
1761         * tui/tui-regs.c (tui_show_registers): Update.
1762         * tui/tui-layout.c (tui_set_layout): Update.
1763         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1764         method.
1765
1766 2019-07-17  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1769         * tui/tui-windata.c (tui_display_data_from): Remove.
1770         (tui_data_window::refresh_all): Update.
1771
1772 2019-07-17  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1775         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1776         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1777         tui_display_registers_from_line.
1778         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1779         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1780         "force_display" parameter.
1781
1782 2019-07-17  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1785         declare.
1786         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1787         Rename from tui_first_reg_element_no_inline.
1788         (tui_display_reg_element_at_line)
1789         (tui_display_registers_from_line): Update.
1790         * tui/tui-data.h (struct tui_data_window)
1791         <first_reg_element_no_inline>: New method.
1792
1793 2019-07-17  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-windata.c (tui_display_data_from)
1796         (tui_data_window::do_scroll_vertical): Update.
1797         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1798         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1799         Rename from tui_line_from_reg_element_no.
1800         (tui_display_registers_from_line): Update.
1801         * tui/tui-data.h (struct tui_data_window)
1802         <line_from_reg_element_no>: New method.
1803
1804 2019-07-17  Tom Tromey  <tom@tromey.com>
1805
1806         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1807         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1808         tui_last_regs_line_no.
1809         (tui_display_reg_element_at_line)
1810         (tui_display_registers_from_line): Update.
1811         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1812         method.
1813
1814 2019-07-17  Tom Tromey  <tom@tromey.com>
1815
1816         PR tui/24722:
1817         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1818         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1819         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1820         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1821         (tui_update_breakpoint_info): Likewise.
1822         * tui/tui-hooks.c (tui_event_create_breakpoint)
1823         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1824         Update.
1825
1826 2019-07-17  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1829
1830 2019-07-17  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-winsource.c (tui_update_source_window_as_is)
1833         (tui_update_source_windows_with_addr): Update.
1834         * tui/tui-source.h (tui_set_source_content)
1835         (tui_show_symtab_source): Add "win_info" parameter.
1836         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1837         parameter.
1838         (tui_show_symtab_source): Likewise.
1839
1840 2019-07-17  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-wingeneral.c
1843         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1844
1845 2019-07-17  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1848         (struct tui_cmd_window) <can_scroll>: New method.
1849         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1850         method.
1851
1852 2019-07-17  Tom Tromey  <tromey@adacore.com>
1853
1854         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1855         do_field_signed>: Rename.  Change type of "value".
1856         * ui-out.c (ui_out::field_signed): Rename from field_int.
1857         Change type of "value".
1858         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1859         type of "value".
1860         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1861         do_field_int.  Change type of "value".
1862         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1863         do_field_int.  Change type of "value".
1864         * tracepoint.c (trace_status_mi, tfind_1)
1865         (print_one_static_tracepoint_marker): Update.
1866         * thread.c (print_thread_info_1, print_selected_thread_frame):
1867         Update.
1868         * stack.c (print_frame, print_frame_info): Update.
1869         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1870         Update.
1871         * source.c (print_source_lines_base): Update.
1872         * skip.c (info_skip_command): Update.
1873         * record-btrace.c (btrace_ui_out_decode_error)
1874         (btrace_call_history_src_line): Update.
1875         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1876         Update.
1877         * progspace.c (print_program_space): Update.
1878         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1879         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1880         do_field_int.  Change type of "value".
1881         * mi/mi-out.c (mi_ui_out::do_table_begin)
1882         (mi_ui_out::do_table_header): Update.
1883         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1884         type of "value".
1885         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1886         (mi_cmd_data_list_changed_registers, output_register)
1887         (mi_cmd_data_read_memory, mi_load_progress)
1888         (mi_cmd_trace_frame_collected): Update.
1889         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1890         Update.
1891         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1892         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1893         (mi_cmd_var_list_children, varobj_update_one): Update.
1894         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1895         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1896         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1897         * inferior.c (print_inferior): Update.
1898         * gdb_bfd.c (print_one_bfd): Update.
1899         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1900         Update.
1901         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1902         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1903         do_field_int.  Change type of "value".
1904         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1905         do_field_int.  Change type of "value".
1906         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1907         (print_one_breakpoint_location, print_it_catch_fork)
1908         (print_one_catch_fork, print_it_catch_vfork)
1909         (print_one_catch_vfork, print_it_catch_solib)
1910         (print_it_catch_exec, print_it_ranged_breakpoint)
1911         (print_mention_watchpoint, print_mention_masked_watchpoint)
1912         (bkpt_print_it, update_static_tracepoint): Update.
1913         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1914         * break-catch-syscall.c (print_it_catch_syscall): Update.
1915         * ada-tasks.c (print_ada_task_info): Update.
1916         * ada-lang.c (print_it_exception, print_mention_exception):
1917         Update.
1918
1919 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1920
1921         PR breakpoints/24541
1922         * gdbarch.c: Regenerate.
1923         * gdbarch.h: Regenerate.
1924         * gdbarch.sh: Adjust return type and parameter types for
1925         'stap_adjust_register'.
1926         (i386_stap_adjust_register): Adjust signature and return new
1927         register name.
1928         * stap-probe.c (stap_parse_register_operand): Adjust use of
1929         'gdbarch_stap_adjust_register'.
1930
1931 2019-07-17  Tom Tromey  <tromey@adacore.com>
1932
1933         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1934         declare VEC.
1935         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1936         std::vector.
1937         (struct s390_process_info): Add initializers.
1938         (s390_add_process): Use new.
1939         (s390_linux_nat_target::low_forget_process): Use delete.
1940         (s390_linux_nat_target::low_new_fork)
1941         (s390_linux_nat_target::stopped_by_watchpoint)
1942         (s390_linux_nat_target::low_prepare_to_resume)
1943         (s390_linux_nat_target::insert_watchpoint)
1944         (s390_linux_nat_target::insert_hw_breakpoint)
1945         (s390_linux_nat_target::remove_watchpoint)
1946         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1947
1948 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1949
1950         * aarch64-fbsd-nat.c: Include regcache.h.
1951         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1952         argument.
1953         (aarch64_fbsd_nat_target::fetch_registers)
1954         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1955         variable.
1956         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1957
1958 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1959
1960         * fbsd-nat.c: Include gdbarch.h.
1961
1962 2019-07-15  Tom Tromey  <tromey@adacore.com>
1963
1964         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1965
1966 2019-07-15  Tom Tromey  <tromey@adacore.com>
1967
1968         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1969         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1970         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1971         * cli-out.c (cli_ui_out::do_field_int): New method.
1972         * ui-out.c (ui_out::field_unsigned): New method.
1973         * symfile.c (generic_load): Use field_unsigned.
1974         (print_transfer_performance): Likewise.
1975         * record-btrace.c (ui_out_field_uint): Remove.
1976         (btrace_call_history_insn_range, btrace_call_history): Use
1977         field_unsigned.
1978         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1979         field_unsigned.
1980         * ui-out.h (class ui_out) <field_unsigned>: New method.
1981         <do_field_unsigned>: Likewise.
1982
1983 2019-07-15  Tom Tromey  <tromey@adacore.com>
1984
1985         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1986         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1987         * target.c (flash_erase_command): Use field_string.
1988         * infrun.c (print_signal_received_reason): Use field_string.
1989         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1990         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1991         field_string.
1992         * ada-tasks.c (print_ada_task_info): Use field_string.
1993
1994 2019-07-15  Tom Tromey  <tromey@adacore.com>
1995
1996         * target.c (flash_erase_command): Use field_core_addr.
1997         * symfile.c (generic_load): Use field_core_addr.
1998         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1999         Use field_core_addr.
2000         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2001         field_core_addr.
2002
2003 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2004
2005         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2006         value if its desired type is smaller than a CORE_ADDR and signed.
2007
2008 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2009
2010         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2011         of changes to field names, and use new is_reference field to
2012         decide if a property is a reference or not.
2013         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2014         field.
2015         (struct dwarf2_property_baton): Update header comment, rename
2016         'referenced_type' to 'property_type' and update comments.
2017         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2018         default property type, store in property baton, update to take
2019         accound of renamed field.
2020         (read_func_scope): Update call to attr_to_dynamic_prop.
2021         (read_array_type): Likewise.
2022         (dwarf2_per_cu_addr_sized_int_type): New function.
2023         (read_subrange_index_type): Move type finding code to
2024         dwarf2_per_cu_addr_sized_int_type.
2025         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2026         (dwarf2_per_cu_addr_type): New function.
2027         (set_die_type): Update calls to attr_to_dynamic_prop.
2028
2029 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2030
2031         * dwarf2read.c (read_subrange_index_type): New function.
2032         (read_subrange_type): Move code into new function and call it.
2033         * gdbtypes.c (create_range_type): Add some asserts.
2034
2035 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2036
2037         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2038         update return statements.
2039         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2040         declaration, and update comment to match.
2041         * gdbtypes.c (resolve_dynamic_array): Update call to
2042         dwarf2_evaluate_property to match new return type.
2043
2044 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2045
2046         * valarith.c (value_subscripted_rvalue): Change lowerbound
2047         parameter type from int to LONGEST.
2048         * value.h (value_subscripted_rvalue): Likewise in declaration.
2049
2050 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2051
2052         * cli/cli-utils.c (info_print_command_completer): New function.
2053         * cli/cli-utils.h: Add 'completer.h' include, and forward
2054         declaration for 'struct cmd_list_element'.
2055         (info_print_command_completer): Declare.
2056         * stack.c (_initialize_stack): Add completer for 'info locals' and
2057         'info args'.
2058         * symtab.c (_initialize_symtab): Add completer for 'info
2059         variables' and 'info functions'.
2060         * NEWS: Mention completion for additional info commands.
2061
2062 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2063
2064         * cli/cli-utils.c (extract_info_print_args): Delete.
2065         (extract_arg_maybe_quoted): Delete.
2066         (info_print_options_defs): New variable.
2067         (make_info_print_options_def_group): New function.
2068         (extract_info_print_options): Define new function.
2069         * cli/cli-utils.h (extract_info_print_args): Delete.
2070         (struct info_print_options): New structure.
2071         (extract_info_print_options): Declare new function.
2072         * stack.c (info_locals_command): Update to use new
2073         extract_info_print_options, also add a header comment.
2074         (info_args_command): Likewise.
2075         * symtab.c (info_variables_command): Likewise.
2076         (info_functions_command): Likewise.
2077
2078 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2079
2080         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2081         to extract string arguments.
2082         * common/common-utils.c (extract_string_maybe_quoted): New function.
2083         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2084
2085 2019-07-11  Tom Tromey  <tromey@adacore.com>
2086
2087         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2088         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2089         * top.h (gdbinit): Don't declare.
2090         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2091         into...
2092         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2093         * top.c (gdb_init): Don't call init_cli_cmds.
2094         (gdbinit): Remove.
2095         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2096
2097 2019-07-11  Tom Tromey  <tromey@adacore.com>
2098
2099         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2100         after it has been moved.
2101
2102 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2103
2104         * valops.c (value_must_coerce_to_target): Change return type to
2105         bool.
2106         * value.h (value_must_coerce_to_target): Likewise.
2107
2108 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2109
2110         * breakpoint.c (is_hardware_watchpoint): Remove
2111         forward-declaration.
2112         (is_masked_watchpoint): Change return type to bool.
2113         (is_tracepoint): Likewise.
2114         (is_breakpoint): Likewise.
2115         (is_hardware_watchpoint): Likewise.
2116         (is_watchpoint): Likewise.
2117         (is_no_memory_software_watchpoint): Likewise.
2118         (is_catchpoint): Likewise.
2119         (breakpoint_1): Make FILTER parameter's return type bool.
2120         is_masked_watchpoint): Change return type to bool.
2121         (save_breakpoints): Make FILTER parameter's return type bool.
2122         * breakpoint.h (is_breakpoint): Change return type to bool.
2123         (is_watchpoint): Likewise.
2124         (is_catchpoint): Likewise.
2125         (is_tracepoint): Likewise.
2126
2127 2019-07-10  Tom Tromey  <tom@tromey.com>
2128
2129         * defs.h: Don't include gdbarch.h.
2130         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2131         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2132         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2133         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2134         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2135         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2136         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2137         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2138         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2139         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2140         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2141         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2142         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2143         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2144         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2145         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2146         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2147         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2148         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2149         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2150         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2151         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2152         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2153         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2154         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2155         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2156         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2157
2158 2019-07-10  Tom Tromey  <tromey@adacore.com>
2159
2160         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2161         * breakpoint.c (init_ada_exception_breakpoint): Register as
2162         bp_catchpoint.
2163         (print_one_breakpoint_location, print_one_breakpoint): Use
2164         is_ada_exception_catchpoint.
2165         * ada-lang.c (class ada_catchpoint_location): Pass
2166         bp_loc_software_breakpoint to bp_location constructor.
2167         (is_ada_exception_catchpoint): New function.
2168
2169 2019-07-10  Tom Tromey  <tromey@adacore.com>
2170
2171         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2172         VEC.
2173         (struct arm_exidx_entry): New method operator<.
2174         (struct arm_exidx_data) <section_maps>: Change type.
2175         (arm_exidx_data_free): Remove.
2176         (arm_exidx_data_key): Change type.  Move lower.
2177         (arm_exidx_new_objfile): Update.
2178         (arm_compare_exidx_entries): Remove.
2179         (arm_find_exidx_entry, _initialize_arm_tdep)
2180
2181 2019-07-10  Tom Tromey  <tromey@adacore.com>
2182
2183         * solib-spu.c (ocl_program_data_key): Change type.
2184         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2185         Update.
2186
2187 2019-07-10  Tom Tromey  <tromey@adacore.com>
2188
2189         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2190         (struct solib_aix_inferior_data) <library_list>: Change type.
2191         (solib_aix_inferior_data_handle): Change type.
2192         (get_solib_aix_inferior_data): Update.
2193         (solib_aix_free_library_list): Remove.
2194         (library_list_start_library): Update.
2195         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2196         return type.
2197         (solib_aix_get_library_list)
2198         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2199         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2200
2201 2019-07-10  Tom Tromey  <tromey@adacore.com>
2202
2203         * solib-dsbt.c (struct dsbt_info): Add initializers.
2204         (solib_dsbt_pspace_data): Change type.
2205         (dsbt_pspace_data_cleanup): Remove.
2206         (get_dsbt_info, _initialize_dsbt_solib): Update.
2207
2208 2019-07-10  Tom Tromey  <tromey@adacore.com>
2209
2210         * spu-tdep.c (spu_overlay_data): Change type.
2211         (spu_get_overlay_table, spu_overlay_new_objfile)
2212         (_initialize_spu_tdep): Update.
2213
2214 2019-07-10  Tom Tromey  <tromey@adacore.com>
2215
2216         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2217         destructor.
2218         (dbx_objfile_data_key): Change type and declare later.
2219         (DBX_SYMFILE_INFO): Rewrite.
2220         * dbxread.c (dbx_objfile_data_key): Change type.
2221         (dbx_symfile_init): Update.
2222         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2223         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2224         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2225
2226 2019-07-10  Tom Tromey  <tromey@adacore.com>
2227
2228         * jit.c (jit_program_space_key): Change type.  Move lower.
2229         (get_jit_program_space_data): Update.
2230         (jit_program_space_data_cleanup): Remove.
2231         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2232         Update.
2233         (struct jit_program_space_data): Add initializers.
2234
2235 2019-07-10  Tom Tromey  <tromey@adacore.com>
2236
2237         * solib-darwin.c (struct darwin_info): Add initializers.
2238         (solib_darwin_pspace_data): Change type.
2239         (darwin_pspace_data_cleanup): Remove.
2240         (get_darwin_info, _initialize_darwin_solib): Update.
2241
2242 2019-07-10  Tom Tromey  <tromey@adacore.com>
2243
2244         * remote-sim.c (struct sim_inferior_data): Add initializers,
2245         constructor, and destructor.
2246         (sim_inferior_data_key): Change type.  Move lower.
2247         (check_for_duplicate_sim_descriptor): Update.
2248         (get_sim_inferior_data): Use new.  Update.
2249         (~sim_inferior_data_cleanup): Rename from
2250         sim_inferior_data_cleanup.  Simplify.
2251         (gdbsim_close_inferior, simulator_command)
2252         (sim_command_completer, _initialize_remote_sim): Update.
2253         (next_pid, INITIAL_PID): Move earlier.
2254
2255 2019-07-10  Tom Tromey  <tromey@adacore.com>
2256
2257         * python/python-internal.h (create_thread_object): Return
2258         gdbpy_ref.
2259         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2260         * python/py-inferior.c (struct threadlist_entry): Add
2261         constructor.
2262         <thread_obj>: Now a gdbpy_ref.
2263         (thread_to_thread_object): Update.
2264         (add_thread_object): Use new.
2265         (delete_thread_object): Use delete.
2266         (infpy_threads): Update.
2267         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2268         GIL.
2269
2270 2019-07-10  Tom Tromey  <tromey@adacore.com>
2271
2272         * valops.c (value_cast): Specialize error message for Ada.
2273
2274 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2275
2276         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2277
2278 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2279
2280         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2281         bpstat_should_step): Return bool, adjust comments.
2282         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2283         bpstat_should_step): Likewise.
2284
2285 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2286
2287         * features/Makefile: Use feature target descriptions for Arm.
2288         * features/arm/arm-core.c: Generate new file.
2289         * features/arm/arm-fpa.c: Likewise.
2290         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2291         * features/arm/arm-m-profile.c: Likewise.
2292         * features/arm/arm-vfpv2.c: Likewise.
2293         * features/arm/arm-vfpv3.c: Likewise.
2294         * features/arm/xscale-iwmmxt.c: Likewise.
2295         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2296
2297 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2298
2299         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2300         ptrace earlier.
2301
2302 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2303
2304         * features/aarch64-pauth.c: Regenerate.
2305
2306 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2307
2308         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2309         bool.
2310         (bpstat_what): Use false instead of 0.
2311
2312 2019-07-09  Pedro Alves  <palves@redhat.com>
2313
2314         * break-catch-throw.c (is_exception_catchpoint): New.
2315         * breakpoint.c (print_one_breakpoint_location): New parameter
2316         'raw_loc'.  Handle it.  Use
2317         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2318         looking at the breakpoint's type.
2319         (print_one_breakpoint): If handling "maint info breakpoints", also
2320         print locations of exception catchpoints.
2321         * breakpoint.h (is_exception_catchpoint): Declare.
2322
2323 2019-07-09  Pedro Alves  <palves@redhat.com>
2324
2325         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2326         "addr" field.
2327         (allocate_location_exception_catchpoint): New.
2328         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2329         (initialize_throw_catchpoint_ops): Install
2330         allocate_location_exception_catchpoint as allocate_location
2331         method.
2332         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2333         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2334         bp_loc_other.
2335         (breakpoint_address_is_meaningful): Delete.
2336         (bl_address_is_meaningful): New.
2337         (breakpoint_locations_match): Adjust comment.
2338         (bp_location_from_bp_type): New, factored out of...
2339         (bp_location::bp_location(breakpoint *)): ... this.
2340         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2341         factored out of...
2342         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2343         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2344         breakpoint_address_is_meaningful.
2345         (bp_locations_compare): Adjust comment.
2346         (update_global_location_list): Use bl_address_is_meaningful
2347         instead of breakpoint_address_is_meaningful.
2348         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2349         explicit.
2350         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2351         * python/py-breakpoint.c (bppy_get_location): No longer check
2352         whether location is null.
2353
2354 2019-07-09  Pedro Alves  <palves@redhat.com>
2355
2356         PR c++/15468
2357         * breakpoint.c (print_one_breakpoint_location): Remove
2358         single-location assert.
2359
2360 2019-07-09  Tom Tromey  <tom@tromey.com>
2361
2362         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2363         * configure: Rebuild.
2364         * configure.ac: Change common to gdbsupport.
2365         * gdbsupport: Rename from common.
2366         * acinclude.m4: Change common to gdbsupport.
2367         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2368         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2369         gdbsupport.
2370         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2371         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2372         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2373         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2374         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2375         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2376         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2377         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2378         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2379         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2380         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2381         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2382         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2383         coff-pe-read.c, command.h, compile/compile-c-support.c,
2384         compile/compile-c.h, compile/compile-cplus-symbols.c,
2385         compile/compile-cplus-types.c, compile/compile-cplus.h,
2386         compile/compile-loc2c.c, compile/compile.c, completer.c,
2387         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2388         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2389         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2390         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2391         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2392         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2393         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2394         features/aarch64-core.c, features/aarch64-fpu.c,
2395         features/aarch64-pauth.c, features/aarch64-sve.c,
2396         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2397         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2398         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2399         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2400         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2401         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2402         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2403         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2404         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2405         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2406         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2407         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2408         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2409         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2410         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2411         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2412         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2413         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2414         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2415         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2416         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2417         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2418         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2419         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2420         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2421         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2422         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2423         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2424         minsyms.c, mips-linux-tdep.c, namespace.h,
2425         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2426         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2427         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2428         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2429         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2430         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2431         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2432         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2433         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2434         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2435         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2436         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2437         procfs.c, producer.c, progspace.h, psymtab.h,
2438         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2439         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2440         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2441         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2442         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2443         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2444         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2445         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2446         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2447         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2448         target-memory.c, target.c, target.h, target/waitstatus.c,
2449         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2450         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2451         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2452         unittests/array-view-selftests.c,
2453         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2454         unittests/common-utils-selftests.c,
2455         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2456         unittests/format_pieces-selftests.c,
2457         unittests/function-view-selftests.c,
2458         unittests/lookup_name_info-selftests.c,
2459         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2460         unittests/mkdir-recursive-selftests.c,
2461         unittests/observable-selftests.c,
2462         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2463         unittests/parse-connection-spec-selftests.c,
2464         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2465         unittests/scoped_fd-selftests.c,
2466         unittests/scoped_mmap-selftests.c,
2467         unittests/scoped_restore-selftests.c,
2468         unittests/string_view-selftests.c, unittests/style-selftests.c,
2469         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2470         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2471         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2472         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2473         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2474         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2475
2476 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2477
2478         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2479         bool value.
2480         (decode_digits_ordinary): Set explicit_line field in sal.
2481         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2482         symtab_and_line that was set on an explicit line number in
2483         assembler code.  Do always update the recorded symtab and line if
2484         we do skip the prologue.
2485
2486 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * breakpoint.c (set_breakpoint_location_function): Remove
2489         explicit_loc parameter.
2490         (momentary_breakpoint_from_master): Update call to
2491         set_breakpoint_location_function.
2492         (add_location_to_breakpoint): Likewise.
2493
2494 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2495
2496         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2497         required features based on default bfd type when no specific bfd
2498         is present.
2499
2500 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2501
2502         * NEWS: Mention that GDB printf and eval commands can now print
2503         C-style and Ada-style convenience var strings without
2504         calling the inferior.
2505         * printcmd.c (printf_c_string): Locally print GDB internal var
2506         instead of transiting via the inferior.
2507         (printf_wide_c_string): Likewise.
2508
2509 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2510
2511         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2512
2513 2019-07-04  Tom Tromey  <tom@tromey.com>
2514
2515         PR tui/24724:
2516         * tui/tui-winsource.c (tui_clear_source_content): Update.
2517         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2518         (tui_update_breakpoint_info): Update.
2519         (tui_set_exec_info_content): Update.
2520         * tui/tui-source.c (tui_set_source_content_nil): Update.
2521         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2522         has_break.
2523         * tui/tui-data.h (enum tui_bp_flag): New.
2524         (tui_bp_flags): New enum flags type.
2525         (struct tui_source_element) <break_mode>: Change type.  Rename
2526         from has_break.
2527         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2528         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2529         constants.
2530         * tui/tui-winsource.h: Fix comment.
2531
2532 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2533
2534         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2535         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2536         (store_fpregs_to_thread)
2537         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2538         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2539         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2540         (IWMMXT_REGS_SIZE): Add define.
2541         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2542         (fetch_vfp_regs, store_vfp_regs)
2543         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2544         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2545
2546 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2547
2548         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2549         defines.
2550         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2551         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2552         (ARM_INT_REGISTER_SIZE): ...to this.
2553         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2554         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2555         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2556         (arm_linux_collect_gregset, supply_nwfpe_register)
2557         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2558         defines.
2559         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2560         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2561         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2562         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2563         (arm_return_in_memory, arm_store_return_value)
2564         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2565         (arm_record_ld_st_multiple): Likewise.
2566         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2567         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2568
2569 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2570
2571         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2572         AARCH64_DISPLACED_MODIFIED_INSNS.
2573         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2574         (aarch64_displaced_step_copy_insn): Likewise.
2575         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2576         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2577         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2578         ARM_DISPLACED_MODIFIED_INSNS.
2579         * arm-tdep.c (arm_gdbarch_init): Likewise.
2580         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2581         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2582         (struct arm_displaced_step_closure): Use
2583         ARM_DISPLACED_MODIFIED_INSNS.
2584
2585 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2586
2587         * features/Makefile: Remove unused xml files.
2588         * features/aarch64.xml: Remove.
2589         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2590         * features/i386/amd64-avx-avx512.xml: Remove.
2591         * features/i386/amd64-avx-linux.xml: Remove.
2592         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2593         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2594         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2595         * features/i386/amd64-avx-mpx.xml: Remove.
2596         * features/i386/amd64-avx.xml: Remove.
2597         * features/i386/amd64-linux.xml: Remove.
2598         * features/i386/amd64-mpx-linux.xml: Remove.
2599         * features/i386/amd64-mpx.xml: Remove.
2600         * features/i386/amd64.xml: Remove.
2601         * features/i386/i386-avx-avx512-linux.xml: Remove.
2602         * features/i386/i386-avx-avx512.xml: Remove.
2603         * features/i386/i386-avx-linux.xml: Remove.
2604         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2605         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2606         * features/i386/i386-avx-mpx-linux.xml: Remove.
2607         * features/i386/i386-avx-mpx.xml: Remove.
2608         * features/i386/i386-avx.xml: Remove.
2609         * features/i386/i386-linux.xml: Remove.
2610         * features/i386/i386-mmx-linux.xml: Remove.
2611         * features/i386/i386-mmx.xml: Remove.
2612         * features/i386/i386-mpx-linux.xml: Remove.
2613         * features/i386/i386-mpx.xml: Remove.
2614         * features/i386/i386.xml: Remove.
2615         * features/i386/x32-avx-avx512-linux.xml: Remove.
2616         * features/i386/x32-avx-linux.xml: Remove.
2617         * features/i386/x32-linux.xml: Remove.
2618
2619 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2620
2621         * regformats/aarch64.dat: Remove.
2622         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2623         * regformats/i386/amd64-avx-linux.dat: Remove.
2624         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2625         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2626         * regformats/i386/amd64-linux.dat: Remove.
2627         * regformats/i386/amd64-mpx-linux.dat: Remove.
2628         * regformats/i386/amd64.dat: Remove.
2629         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2630         * regformats/i386/i386-avx-linux.dat: Remove.
2631         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2632         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2633         * regformats/i386/i386-linux.dat: Remove.
2634         * regformats/i386/i386-mmx-linux.dat: Remove.
2635         * regformats/i386/i386-mpx-linux.dat: Remove.
2636         * regformats/i386/i386.dat: Remove.
2637         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2638         * regformats/i386/x32-avx-linux.dat: Remove.
2639         * regformats/i386/x32-linux.dat: Remove.
2640
2641 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2642
2643         * aarch64-tdep.c: Remove xml self tests.
2644         * amd64-linux-tdep.c: Likewise.
2645         * amd64-tdep.c: Likewise.
2646         * i386-linux-tdep.c: Likewise.
2647         * i386-tdep.c: Likewise.
2648
2649 2019-07-03  Pedro Alves  <palves@redhat.com>
2650
2651         PR cli/24732
2652         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2653         (pipe_cmd_option_defs): New.
2654         (make_pipe_cmd_options_def_group): New.
2655         (pipe_command): Use gdb::option::process_options.
2656         (pipe_command_completer): New function.
2657         (_initialize_cli_cmds): Install completer for "pipe" command.
2658
2659 2019-07-03  Pedro Alves  <palves@redhat.com>
2660
2661         * cli/cli-option.c (union option_value) <string>: New field.
2662         (struct option_def_and_value): Add ctor, move ctor, dtor and
2663         use DISABLE_COPY_AND_ASSIGN.
2664         (option_def_and_value::clear_value): New.
2665         (parse_option, save_option_value_in_ctx, get_val_type_str)
2666         (add_setshow_cmds_for_options): Handle var_string.
2667         * cli-option.h (union option_def::var_address) <string>: New
2668         field.
2669         (struct string_option_def): New.
2670         * maint-test-options.c (struct test_options_opts): Add default
2671         ctor and use DISABLE_COPY_AND_ASSIGN.
2672         <string_opt>: New field.
2673         (test_options_opts::~test_options_opts): New.
2674         (test_options_opts::dump): Also dump "-string".
2675         (test_options_option_defs): Install "string.
2676
2677 2019-07-03  Pedro Alves  <palves@redhat.com>
2678
2679         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2680         option_value with a null enumeration.
2681         (complete_options): Save the option values in the context.
2682         (save_option_value_in_ctx): New, factored out from ...
2683         (process_options): ... here.
2684         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2685         of the function.
2686         * maint-test-options.c (test_options_opts::dump): New, factored
2687         out from ...
2688         (maintenance_test_options_command_mode): ... here.
2689         (maintenance_test_options_command_completion_result): Delete.
2690         (maintenance_test_options_command_completion_text): Update
2691         comment.
2692         (maintenance_show_test_options_completion_result): Change
2693         prototype.  Just print
2694         maintenance_test_options_command_completion_text.
2695         (save_completion_result): New.
2696         (maintenance_test_options_completer_mode): Pass options context to
2697         complete_options, and then save a dump.
2698         (_initialize_maint_test_options): Use add_cmd to install "maint
2699         show test-options-completion-result".
2700
2701 2019-07-03  Pedro Alves  <palves@redhat.com>
2702
2703         * NEWS (New commands): Mention "with" and "maint with".
2704         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2705         (with_command, with_command_completer): New.
2706         (pipe_command): Adjust to new repeat_previous
2707         interface.
2708         (_initialize_cli_cmds): Install the "with" command and its "w"
2709         alias.
2710         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2711         declarations.
2712         * cli/cli-setshow.c (parse_cli_var_uinteger)
2713         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2714         argument strings for all var_types.
2715         (get_setshow_command_value_string): New, factored out from ...
2716         (do_show_command): ... this.
2717         * cli/cli-setshow.h: Include <string>.
2718         (get_setshow_command_value_string): Declare.
2719         * command.h (repeat_previous): Now returns const char *.  Adjust
2720         comment.
2721         * maint.c: Include "cli/cli-cmds.h".
2722         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2723         (_initialize_maint_cmds): Register the "maintenance with" command.
2724         * top.c (repeat_previous): Move bits from pipe_command here:
2725         Return the saved command line, if any; error out if there's no
2726         command to relaunch.
2727
2728 2019-07-03  Pedro Alves  <palves@redhat.com>
2729
2730         * NEWS (New commands): Mention "maint set/show test-settings"
2731         instead of "maint test-settings".
2732         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2733         (maintenance_test_settings_set_list): Rename to ...
2734         (maintenance_set_test_settings_list): ... this.
2735         (maintenance_test_settings_show_list): Rename to  ...
2736         (maintenance_show_test_settings_list): ... this.
2737         (maintenance_test_settings_cmd): Delete.
2738         (maintenance_test_settings_set_cmd): ...
2739         (maintenance_set_test_settings_cmd): ... this.
2740         (maintenance_test_settings_show_cmd): ...
2741         (maintenance_show_test_settings_cmd): ... this.
2742         (maintenance_test_settings_show_value_cmd):
2743         (maintenance_show_test_settings_value_cmd): ... this.
2744         (_initialize_maint_test_settings): No longer install the "maint
2745         test-settings" prefix command.  Rename "maint test-settings set"
2746         to "maint set test-settings", and "maint test-settings show" to
2747         "maint show test-settings".  Adjust all subcommands.
2748
2749 2019-07-03  Pedro Alves  <palves@redhat.com>
2750
2751         * maint-test-settings.c: Fix file's intro comment.  Replace all
2752         references to "test-options" with references to "test-settings",
2753         in comments.
2754
2755 2019-07-03  Pedro Alves  <palves@redhat.com>
2756
2757         * maint-test-settings.c (maintenance_test_settings_xxx)
2758         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2759         New.
2760         (maintenance_test_settings_enums): Use them.
2761         (maintenance_test_settings_enum): Default to
2762         maintenance_test_settings_xxx.
2763         (_initialize_maint_test_settings): Initialize
2764         MAINTENANCE_TEST_SETTINGS_FILENAME.
2765
2766 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2767
2768         * breakpoint.h (remove_breakpoints_inf): Change return type to
2769         void, move function documentation here.
2770         * breakpoint.c (remove_breakpoints_inf): Change return type to
2771         void, move function documentation to header.
2772
2773 2019-07-02  Pedro Alves  <palves@redhat.com>
2774
2775         * NEWS (Completion improvements): Mention "info threads".
2776         * thread.c (struct info_threads_opts, info_threads_option_defs)
2777         (make_info_threads_options_def_group): New.
2778         (info_threads_command): Use gdb::option::process_options.
2779         (info_threads_command_completer): New.
2780         (_initialize_thread): Use gdb::option::build_help to build the
2781         help text for "info threads".
2782
2783 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2784
2785         * defs.h (generic_load): Move from here...
2786         * symfile.h (generic_load): ... to here.  Rename name parameter
2787         to args.
2788         * symfile.c (generic_load): Add comment.
2789
2790 2019-07-01  Tom Tromey  <tromey@adacore.com>
2791
2792         * dwarf2read.c
2793         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2794         declaration of without_params.  Fix formatting.
2795
2796 2019-07-01  Tom Tromey  <tromey@adacore.com>
2797
2798         * ada-exp.y (find_primitive_type): Update.
2799         * ada-lang.h (ada_lookup_symbol): Update.
2800         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2801         parameter.
2802         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2803
2804 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2805
2806         PR breakpoints/24541
2807         * gdbarch.c: Regenerate.
2808         * gdbarch.h: Regenerate.
2809         * gdbarch.sh: Add 'stap_adjust_register'.
2810         * i386-tdep.c: Include '<unordered_set>'.
2811         (i386_stap_adjust_register): New function.
2812         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2813         * stap-probe.c (stap_parse_register_operand): Call
2814         'gdbarch_stap_adjust_register'.
2815
2816 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2817
2818         PR python/24742
2819         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2820         * python/python.c (do_start_initialization): Use 'xmalloc'
2821         instead of 'PyMem_Malloc'.
2822
2823 2019-06-28  Tom Tromey  <tromey@adacore.com>
2824
2825         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2826         for Ada.
2827
2828 2019-06-27  Tom Tromey  <tromey@adacore.com>
2829
2830         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2831         objfile_key.
2832         (arm_find_mapping_symbol, arm_record_special_symbol)
2833         (_initialize_arm_tdep): Update.
2834         (arm_objfile_data_free): Remove.
2835
2836 2019-06-27  Tom Tromey  <tromey@adacore.com>
2837
2838         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2839         to cp_print_static_field.
2840
2841 2019-06-26  Tom Tromey  <tromey@adacore.com>
2842
2843         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2844         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2845         declare.
2846
2847 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2848
2849         * features/aarch64-core.c (create_feature_aarch64_core):
2850         Regenerate.
2851         * features/aarch64-core.xml: Add cpsr flags.
2852
2853 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2854
2855         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2856         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2857
2858 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2859
2860         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2861         field.
2862         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2863         use.
2864         (arm_record_special_symbol): Don't insert new symbol in sorted
2865         position, push it at the end.
2866
2867 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2868
2869         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2870         (arm_mapping_symbol_s): Remove.
2871         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2872         (arm_mapping_symbol_vec): New typedef.
2873         (struct arm_per_objfile): Add constructor.
2874         <section_maps>: Change type to
2875         std::unique_ptr<arm_mapping_symbol_vec[]>.
2876         (arm_compare_mapping_symbols): Remove.
2877         (arm_find_mapping_symbol): Adjust to section_maps type change.
2878         (arm_objfile_data_free): Call delete on arm_per_objfile.
2879         (arm_record_special_symbol): Adjust to section_maps type change.
2880         Allocate arm_per_objfile with new.
2881
2882 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2883
2884         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2885         with the command prefix.
2886
2887 2019-06-25  Tom Tromey  <tom@tromey.com>
2888
2889         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2890         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2891
2892 2019-06-25  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2895         type.
2896         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2897         protected.
2898
2899 2019-06-25  Tom Tromey  <tom@tromey.com>
2900
2901         * tui/tui-winsource.c
2902         (tui_source_window_base::set_is_exec_point_at): Add check against
2903         LOA_ADDRESS.
2904
2905 2019-06-25  Tom Tromey  <tom@tromey.com>
2906
2907         * tui/tui-source.c (tui_set_source_content): Don't check before
2908         xfree.
2909         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2910
2911 2019-06-25  Tom Tromey  <tom@tromey.com>
2912
2913         * tui/tui-winsource.h (tui_update_source_window_as_is)
2914         (tui_alloc_source_buffer, tui_line_is_displayed)
2915         (tui_addr_is_displayed): Change type of win_info.
2916         * tui/tui-winsource.c (tui_update_source_window_as_is)
2917         (tui_clear_source_content, tui_show_source_line)
2918         (tui_show_source_content, tui_source_window_base::refill)
2919         (tui_source_window_base::set_is_exec_point_at)
2920         (tui_source_window_base::set_is_exec_point_at)
2921         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2922         (tui_alloc_source_buffer, tui_line_is_displayed)
2923         (tui_addr_is_displayed): Change type of win_info.  Update.
2924         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2925         (tui_source_window_base::do_make_visible_with_new_height):
2926         Update.
2927         * tui/tui-source.c (tui_set_source_content)
2928         (tui_set_source_content_nil)
2929         (tui_source_window::do_scroll_vertical): Update.
2930         * tui/tui-layout.c (show_layout): Update.
2931         * tui/tui-disasm.c (tui_set_disassem_content)
2932         (tui_disasm_window::do_scroll_vertical): Update.
2933         * tui/tui-data.h (tui_win_content): Remove.
2934         (struct tui_gen_win_info) <content, content_size>: Remove.
2935         (struct tui_source_element): Add initializers and destructor.
2936         (union tui_which_element, struct tui_win_element): Remove.
2937         (struct tui_source_window_base) <content>: New field.
2938         (struct tui_data_window): Remove destructor.
2939         (tui_alloc_content, tui_free_win_content)
2940         (tui_free_all_source_wins_content): Don't declare.
2941         * tui/tui-data.c (tui_initialize_static_data): Update.
2942         (init_content_element, tui_alloc_content): Remove.
2943         (~tui_gen_win_info): Update.
2944         (~tui_data_window, tui_free_all_source_wins_content)
2945         (tui_free_win_content, free_content, free_content_elements):
2946         Remove.
2947
2948 2019-06-25  Tom Tromey  <tom@tromey.com>
2949
2950         * tui/tui-winsource.h (tui_clear_source_content)
2951         (tui_erase_source_content, tui_show_source_content): Change type
2952         of win_info.
2953         * tui/tui-winsource.c (tui_clear_source_content)
2954         (tui_erase_source_content, tui_show_source_content): Change type
2955         of win_info.
2956         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2957         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2958         win_info.
2959         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2960         win_info.
2961         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2962
2963 2019-06-25  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-winsource.c (tui_clear_source_content)
2966         (tui_source_window_base::set_is_exec_point_at): Update.
2967         * tui/tui-source.c (tui_set_source_content_nil): Update.
2968         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2969         a bool.
2970         * tui/tui-data.c (init_content_element): Update.
2971
2972 2019-06-25  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2975         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2976         * tui/tui-layout.c (init_and_make_win): Update.
2977         * tui/tui.h (enum tui_win_type): Update.
2978         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2979         tui_win_is_auxillary.
2980         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2981         tui_win_is_auxillary.
2982
2983 2019-06-25  Tom Tromey  <tom@tromey.com>
2984
2985         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2986         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2987         (tui_delete_data_content_windows, tui_display_all_data)
2988         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2989         Update.
2990         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2991         * tui/tui-regs.c (tui_last_regs_line_no)
2992         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2993         (tui_show_registers): Update.
2994         (tui_show_register_group): Return void.  Update.
2995         (tui_display_registers_from, tui_display_reg_element_at_line)
2996         (tui_display_registers_from_line, tui_check_register_values):
2997         Update.
2998         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2999         member.
3000         (struct tui_data_window) <regs_content>: Now a std::vector.
3001         <regs_content_count>: Remove.
3002         (tui_add_content_elements, tui_free_data_content): Don't declare.
3003         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3004         (init_content_element): Remove DATA_WIN case.  Add assert.
3005         (tui_add_content_elements): Remove.
3006         (tui_data_window): Update.
3007         (tui_free_data_content): Remove.
3008         (free_content_elements): Remove DATA_WIN case.
3009
3010 2019-06-25  Tom Tromey  <tom@tromey.com>
3011
3012         * tui/tui-data.c (tui_data_item_window): Update.
3013         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3014         * tui/tui-windata.c (tui_display_all_data)
3015         (tui_display_data_from_line): Update.
3016         (tui_check_data_values): Remove.
3017         * tui/tui-regs.c (tui_show_register_group)
3018         (tui_display_reg_element_at_line): Update.
3019         * tui/tui-hooks.c (tui_register_changed)
3020         (tui_refresh_frame_and_register_information): Call
3021         tui_check_register_values.
3022         * tui/tui-data.h (struct tui_data_window) <data_content,
3023         data_content_count, data_type>: Remove.
3024         (enum tui_data_type): Remove.
3025
3026         * tui/tui-data.c (tui_data_window::clear_detail)
3027         (~tui_data_window): Update.
3028
3029 2019-06-25  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3032         declare.
3033         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3034         Rename from tui_first_data_item_displayed.  Update.
3035         (tui_data_window::refresh_all)
3036         (tui_data_window::do_scroll_vertical): Update.
3037         * tui/tui-data.h (struct tui_data_window)
3038         <first_data_item_displayed>: Declare new method.
3039
3040 2019-06-25  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3043         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3044         contents...
3045         (tui_initialize_static_data): ...here.
3046
3047 2019-06-25  Tom Tromey  <tom@tromey.com>
3048
3049         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3050         (tui_display_registers_from, tui_check_register_values): Update.
3051         (tui_display_register): Remove win_info parameter; update.
3052         (tui_get_register): Change type of parameters.
3053         * tui/tui-data.h (struct tui_data_element): Remove.
3054         (union tui_which_element) <data>: Remove.
3055         <data_window>: Change type.
3056         (struct tui_data_item_window): New.
3057         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3058         case.  Add assert.
3059         (~tui_data_item_window): New destructor.
3060         (free_content_elements): Remove DATA_ITEM_WIN case.
3061
3062 2019-06-25  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3065         Remove.
3066
3067 2019-06-25  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-data.h (struct tui_command_element): Remove.
3070         (union tui_which_element) <command>: Remove.
3071         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3072         assert.
3073         (free_content_elements): Remove CMD_WIN case.
3074
3075 2019-06-25  Tom Tromey  <tom@tromey.com>
3076
3077         * tui/tui-layout.c (tui_set_layout): Update.
3078         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3079         * tui/tui-data.c (layout_def): Update.
3080
3081 2019-06-25  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3084         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3085         (tui_source_window_base::set_new_height): Update.
3086         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3087         Update.
3088         (tui_set_locator_fullname, tui_set_locator_info)
3089         (tui_show_frame_info): Update.
3090         * tui/tui-source.c (tui_set_source_content)
3091         (tui_source_is_displayed): Update.
3092         * tui/tui-layout.c (show_source_disasm_command, show_data)
3093         (show_source_or_disasm_and_command): Update.
3094         * tui/tui-disasm.c (tui_set_disassem_content)
3095         (tui_get_begin_asm_address): Update.
3096         * tui/tui-data.h (struct tui_locator_element): Remove.
3097         (union tui_which_element) <locator>: Remove.
3098         (struct tui_locator_window): New.
3099         (tui_locator_win_info_ptr): Change return type.
3100         * tui/tui-data.c (_locator): Change type.
3101         (tui_locator_win_info_ptr): Change return type.
3102         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3103         (tui_alloc_content): Add assert.
3104
3105 2019-06-25  Tom Tromey  <tom@tromey.com>
3106
3107         * tui/tui-winsource.c
3108         (tui_exec_info_window::maybe_allocate_content): New method.
3109         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3110         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3111         (make_source_or_disasm_window): Add cast.
3112         * tui/tui-data.h (union tui_which_element) <simple_string>:
3113         Remove.
3114         (struct tui_source_info): New.
3115         (struct tui_source_window_base) <execution_info>: Change type.
3116         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3117         case, and add assert.
3118         (tui_alloc_content): Add assert.
3119
3120 2019-06-25  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3123         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3124         * tui/tui-data.c (tui_alloc_win_info): Remove.
3125
3126 2019-06-25  Tom Tromey  <tom@tromey.com>
3127
3128         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3129         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3130         can_highlight.
3131
3132 2019-06-25  Tom Tromey  <tom@tromey.com>
3133
3134         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3135         make_visible_with_new_height method.
3136         (tui_win_info::make_visible_with_new_height): New method.
3137         (tui_source_window_base::do_make_visible_with_new_height)
3138         (tui_data_window::do_make_visible_with_new_height)
3139         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3140         (make_visible_with_new_height): Remove.
3141         (tui_resize_all, tui_adjust_win_heights): Use
3142         make_visible_with_new_height method.
3143         * tui/tui-data.h (struct tui_win_info)
3144         <do_make_visible_with_new_height, make_visible_with_new_height>:
3145         New methods.
3146         (struct tui_source_window_base, struct tui_data_window)
3147         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3148         methods.
3149
3150 2019-06-25  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3153         method.
3154         (update_tab_width): Call update_tab_width method.
3155         * tui/tui-data.h (struct tui_win_info)
3156         (struct tui_source_window_base) <update_tab_width>: New methods.
3157
3158 2019-06-25  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3161         parameter.
3162         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3163         parameter.
3164         (tui_gen_win_info::make_visible): Update.
3165         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3166         parameter.
3167         * tui/tui-data.h (enum tui_box): New enum.
3168         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3169
3170 2019-06-25  Tom Tromey  <tom@tromey.com>
3171
3172         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3173         init_and_make_win for EXEC_INFO_WIN.
3174         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3175         longer inline.
3176         (struct tui_win_info) <~tui_win_info>: Inline.
3177         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3178         Don't declare.
3179         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3180         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3181         Remove.
3182         (tui_initialize_static_data): Update.
3183         (~tui_gen_win_info): Handle more cleanup here.
3184         (~tui_source_window_base): Delete "execution_info".
3185         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3186
3187 2019-06-25  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui-layout.c (make_command_window): Don't set
3190         can_highlight.
3191         (show_source_disasm_command): Call the reset method.
3192         (show_data): Don't set can_highlight.  Call the reset method.
3193         (tui_gen_win_info::reset): Rename from init_gen_win_info
3194         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3195         (show_source_or_disasm_and_command): Call the reset method.
3196         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3197         (struct tui_cmd_window): Set can_highlight.
3198
3199 2019-06-25  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3202         from make_visible.
3203         (tui_make_visible, tui_make_invisible): Rewrite.
3204         (tui_win_info::make_visible): Remove.
3205         (tui_source_window_base::make_visible): Update.
3206         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3207         method.  Moved from...
3208         (struct tui_win_info) <make_visible>: ...here.
3209
3210 2019-06-25  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-winsource.c
3213         (tui_source_window_base::do_scroll_horizontal): Remove direction
3214         parameter.
3215         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3216         direction parameter.
3217         * tui/tui-win.c (tui_win_info::forward_scroll)
3218         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3219         (tui_win_info::right_scroll): Update.
3220         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3221         direction parameter.
3222         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3223         direction parameter.
3224         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3225         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3226         Remove direction parameter.
3227         (struct tui_source_window_base, struct tui_source_window)
3228         (struct tui_disasm_window, struct tui_data_window)
3229         (struct tui_cmd_window): Update.
3230
3231 2019-06-25  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-winsource.h (tui_set_exec_info_content)
3234         (tui_show_exec_info_content, tui_erase_exec_info_content)
3235         (tui_clear_exec_info_content, tui_update_exec_info): Change
3236         argument to tui_source_window_base.
3237         * tui/tui-winsource.c (tui_set_exec_info_content)
3238         (tui_show_exec_info_content, tui_erase_exec_info_content)
3239         (tui_clear_exec_info_content, tui_update_exec_info): Change
3240         argument to tui_source_window_base.
3241
3242 2019-06-25  Tom Tromey  <tom@tromey.com>
3243
3244         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3245         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3246
3247 2019-06-25  Tom Tromey  <tom@tromey.com>
3248
3249         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3250         check.
3251
3252 2019-06-25  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3255         type to void.
3256         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3257         type to void.
3258         * tui/tui-source.c (tui_set_source_content): Update.
3259         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3260
3261 2019-06-25  Tom Tromey  <tom@tromey.com>
3262
3263         * tui/tui-win.c (window_name_completer, tui_set_focus)
3264         (tui_all_windows_info): Use name method.
3265         * tui/tui-data.h (struct tui_gen_win_info)
3266         (struct tui_source_window, struct tui_disasm_window)
3267         (struct tui_data_window, struct tui_cmd_window) <name>: New
3268         method.
3269         (tui_win_name): Don't declare.
3270         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3271         (tui_win_name): Remove.
3272
3273 2019-06-25  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-winsource.h (tui_update_source_window)
3276         (tui_update_source_window_as_is): Change parameter type.
3277         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3278         to be a tui_source_window_base.
3279         (tui_update_source_window_as_is): Likewise.
3280         * tui/tui-win.c (make_visible_with_new_height): Update.
3281
3282 2019-06-25  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-winsource.c (tui_erase_source_content)
3285         (tui_show_source_content, tui_show_exec_info_content)
3286         (tui_erase_exec_info_content): Use refresh_window method.
3287         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3288         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3289         from tui_refresh_win.
3290         (tui_data_window::refresh_window): New method.
3291         (tui_win_info::refresh, tui_source_window_base::refresh)
3292         (tui_refresh_all): Use refresh_window method.
3293         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3294         method.
3295         * tui/tui-regs.c (tui_display_register): Call refresh_window
3296         method.
3297         * tui/tui-layout.c (show_source_disasm_command)
3298         (show_source_or_disasm_and_command): Call refresh_window method.
3299         * tui/tui-data.h (struct tui_gen_win_info)
3300         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3301         New method.
3302
3303 2019-06-25  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui.c (tui_rl_other_window, tui_enable)
3306         (tui_is_window_visible, tui_get_command_dimension): Update.
3307         * tui/tui-winsource.c (tui_update_source_window_as_is)
3308         (tui_clear_source_content, tui_erase_source_content)
3309         (tui_show_source_line, tui_source_window_base::refill)
3310         (tui_source_window_base::do_scroll_horizontal)
3311         (tui_source_window_base::set_is_exec_point_at)
3312         (tui_update_breakpoint_info, tui_set_exec_info_content)
3313         (tui_alloc_source_buffer, tui_line_is_displayed)
3314         (tui_addr_is_displayed): Update.
3315         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3316         (tui_check_and_display_highlight_if_needed)
3317         (tui_win_info::make_visible, tui_win_info::refresh)
3318         (tui_refresh_all): Update.
3319         * tui/tui-windata.c (tui_first_data_item_displayed)
3320         (tui_delete_data_content_windows, tui_erase_data_content)
3321         (tui_display_all_data, tui_data_window::refresh_all)
3322         (tui_check_data_values): Update.
3323         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3324         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3325         (tui_win_info::backward_scroll, tui_refresh_all_win)
3326         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3327         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3328         (tui_source_window_base::set_new_height)
3329         (tui_data_window::set_new_height)
3330         (make_invisible_and_set_new_height)
3331         (make_visible_with_new_height, new_height_ok)
3332         (parse_scrolling_args): Update.
3333         * tui/tui-stack.c (tui_show_frame_info): Update.
3334         * tui/tui-source.c (tui_set_source_content)
3335         (tui_set_source_content_nil, tui_source_is_displayed)
3336         (tui_source_window::do_scroll_vertical): Update.
3337         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3338         (tui_display_registers_from, tui_display_reg_element_at_line)
3339         (tui_check_register_values, tui_reg_command): Update.
3340         * tui/tui-layout.c (tui_default_win_height)
3341         (show_source_disasm_command, show_data, init_and_make_win)
3342         (show_source_or_disasm_and_command): Update.
3343         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3344         (tui_redisplay_readline, tui_mld_flush)
3345         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3346         (tui_getc): Update.
3347         * tui/tui-disasm.c (tui_set_disassem_content)
3348         (tui_disasm_window::do_scroll_vertical): Update.
3349         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3350         Now virtual.
3351         (struct tui_win_info): Derive from tui_gen_win_info.
3352         <~tui_win_info>: Mark as override.
3353         <generic>: Remove member.
3354         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3355         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3356         (~tui_data_window, ~tui_win_info)
3357         (tui_free_all_source_wins_content): Update.
3358         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3359
3360 2019-06-25  Tom Tromey  <tom@tromey.com>
3361
3362         * tui/tui-layout.c (init_and_make_win): Use new.
3363         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3364         destructor, initializers.
3365         (tui_alloc_generic_win_info): Don't declare.
3366         * tui/tui-data.c (_locator): Add argument to constructor.
3367         (source_win, disasm_win): New globals.
3368         (exec_info): Remove.
3369         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3370         Update.
3371         (tui_alloc_generic_win_info): Remove.
3372         (init_content_element): Use new.
3373         (tui_win_info::tui_win_info): Update.
3374         (free_content_elements) <case DATA_WIN>: Use delete.
3375
3376 2019-06-25  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3379         * tui/tui-windata.c (tui_first_data_item_displayed)
3380         (tui_delete_data_content_windows): Update.
3381         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3382         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3383         (tui_display_registers_from, tui_check_register_values): Update.
3384         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3385         pointer.
3386         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3387         window.
3388         (tui_free_data_content): Update.
3389         (free_content_elements) <case DATA_WIN>: Free the window.
3390
3391 2019-06-25  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3394         Update.
3395         * tui/tui-layout.c (make_command_window)
3396         (show_source_disasm_command, show_data, init_and_make_win)
3397         (show_source_or_disasm_and_command): Update.
3398         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3399         method.
3400         <can_highight, is_highlighted>: Now bool.
3401         (tui_set_win_highlight): Don't declare.
3402         * tui/tui-data.c (tui_set_win_highlight): Remove.
3403
3404 2019-06-25  Tom Tromey  <tom@tromey.com>
3405
3406         * tui/tui-wingeneral.c (make_visible): Remove check of window
3407         type.
3408
3409 2019-06-25  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui-win.c (tui_win_info::max_height)
3412         (tui_cmd_window::max_height): New methods.
3413         (new_height_ok): Call max_height.
3414         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3415         <max_height>: New method.
3416
3417 2019-06-25  Tom Tromey  <tom@tromey.com>
3418
3419         * tui/tui-win.c (tui_source_window_base::set_new_height)
3420         (tui_data_window::set_new_height): New methods.
3421         (make_invisible_and_set_new_height): Call set_new_height method.
3422         * tui/tui-data.h (struct tui_win_info)
3423         (struct tui_source_window_base, struct tui_data_window)
3424         <set_new_height>: New method.
3425
3426 2019-06-25  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3429         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3430         tui_refresh_data_win.
3431         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3432         method.
3433         (tui_refresh_all_win): Call the refresh_all method.
3434         (tui_set_focus): Likewise.
3435         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3436         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3437         Likewise.
3438
3439 2019-06-25  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-winsource.h (tui_refill_source_window)
3442         (tui_set_is_exec_point_at): Don't declare.
3443         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3444         (tui_source_window_base::refill): Rename from
3445         tui_refill_source_window.
3446         (tui_source_window_base::do_scroll_horizontal): Update.
3447         (tui_source_window_base::set_is_exec_point_at): Rename from
3448         tui_set_is_exec_point_at.
3449         (tui_update_all_breakpoint_info): Update.
3450         * tui/tui-stack.c (tui_show_frame_info): Update.
3451         * tui/tui-layout.c (show_data): Add cast.
3452         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3453         * tui/tui-data.h (struct tui_source_window_base) <refill,
3454         set_is_exec_point_at>: New methods.
3455         (tui_source_windows, tui_add_to_source_windows): Update types.
3456         (tui_add_to_source_windows): Remove redundant declaration.
3457         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3458         (tui_source_windows): Change return type.
3459         (tui_clear_source_windows_detail): Update.
3460         (tui_add_to_source_windows): Change type of parameter.
3461         (tui_free_all_source_wins_content): Update.
3462
3463 2019-06-25  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-wingeneral.c (tui_win_info::refresh)
3466         (tui_source_window_base::refresh): New methods.
3467         (tui_refresh_all): Call the refresh method.
3468         * tui/tui-data.h (struct tui_win_info)
3469         (struct tui_source_window_base) <refresh>: New method.
3470
3471 2019-06-25  Tom Tromey  <tom@tromey.com>
3472
3473         * tui/tui.h (tui_is_window_visible): Return bool.
3474         * tui/tui.c (tui_is_window_visible): Return bool.
3475         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3476         (tui_make_visible, tui_make_invisible)
3477         (tui_win_info::make_visible)
3478         (tui_source_window_base::make_visible, make_all_visible)
3479         (tui_make_all_visible, tui_make_all_invisible): Update.
3480         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3481         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3482         bool.
3483         (struct tui_win_info, struct tui_source_window_base)
3484         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3485         * tui/tui-data.c (tui_init_generic_part): Update.
3486
3487 2019-06-25  Tom Tromey  <tom@tromey.com>
3488
3489         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3490         (tui_source_window_base::make_visible): New methods.
3491         (make_all_visible): Make method call.
3492         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3493         (struct tui_source_window_base, struct tui_cmd_window): Override
3494         make_visible.
3495         (tui_win_is_source_type): Don't declare.
3496         * tui/tui-data.c (tui_win_is_source_type): Remove.
3497
3498 2019-06-25  Tom Tromey  <tom@tromey.com>
3499
3500         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3501         NULL check.
3502
3503 2019-06-25  Tom Tromey  <tom@tromey.com>
3504
3505         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3506         Inline constructor.  Add initializers for members.
3507         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3508         constructors; now inline in class.
3509
3510 2019-06-25  Tom Tromey  <tom@tromey.com>
3511
3512         * tui/tui-regs.c (tui_show_registers): Update.
3513         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3514         bool.
3515         * tui/tui-data.c (tui_data_window::clear_detail)
3516         (tui_data_window): Update.
3517
3518 2019-06-25  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-windata.c (tui_display_all_data)
3521         (tui_display_data_from_line, tui_display_data_from)
3522         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3523         Update.
3524         * tui/tui-regs.c (tui_last_regs_line_no)
3525         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3526         (tui_show_registers, tui_show_register_group)
3527         (tui_display_registers_from, tui_display_reg_element_at_line)
3528         (tui_display_registers_from_line, tui_check_register_values)
3529         (tui_reg_next, tui_reg_prev): Update.
3530         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3531         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3532         tui_data_window.
3533         (struct tui_win_info) <detail>: Remove.  Add new fields from
3534         tui_data_info.
3535         (TUI_DATA_WIN): Add cast.
3536         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3537         (~tui_data_window): Simplify.
3538
3539 2019-06-25  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-layout.c (show_source_disasm_command)
3542         (show_source_or_disasm_and_command): Update.
3543         * tui/tui-io.c (update_cmdwin_start_line)
3544         (tui_redisplay_readline): Update.
3545         * tui/tui-data.h (struct tui_command_info): Remove.
3546         (struct tui_win_info) <detail>: Remove command_info member.
3547         (struct tui_data_window) <start_line>: New member, from
3548         tui_command_info.
3549         (TUI_CMD_WIN): Add casts.
3550
3551 2019-06-25  Tom Tromey  <tom@tromey.com>
3552
3553         * tui/tui-winsource.c (tui_update_source_window)
3554         (tui_refill_source_window)
3555         (tui_source_window_base::do_scroll_horizontal)
3556         (tui_update_breakpoint_info, tui_set_exec_info_content)
3557         (tui_show_exec_info_content, tui_erase_exec_info_content)
3558         (tui_clear_exec_info_content): Update.
3559         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3560         Update.
3561         * tui/tui-win.c (make_invisible_and_set_new_height)
3562         (make_visible_with_new_height): Update.
3563         * tui/tui-source.c (tui_set_source_content)
3564         (tui_show_symtab_source): Update.
3565         * tui/tui-layout.c (extract_display_start_addr)
3566         (show_source_disasm_command, show_data)
3567         (make_source_or_disasm_window)
3568         (show_source_or_disasm_and_command): Update.
3569         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3570         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3571         "gdbarch".
3572         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3573         to tui_source_window_base.
3574         (struct tui_win_info) <detail>: Remove source_info member.
3575         (struct tui_source_window_base) <has_locator>: Inline.
3576         Move contents from tui_source_info; rename has_locator member to
3577         m_has_locator.
3578         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3579         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3580         header file.
3581         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3582         Simplify.
3583         (tui_free_all_source_wins_content): Cast to
3584         tui_source_window_base.
3585
3586 2019-06-25  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui-win.c (make_invisible_and_set_new_height)
3589         (make_visible_with_new_height): Call has_locator method.
3590         * tui/tui-layout.c (show_source_disasm_command, show_data)
3591         (show_source_or_disasm_and_command): Update for bool change.
3592         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3593         (tui_win_info) <has_locator>: New method.
3594         (struct tui_source_window_base) <has_locator>: New method.
3595         (tui_win_has_locator): Don't declare.
3596         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3597         from tui_win_has_locator.
3598         (tui_source_window_base): Use false, not FALSE.
3599
3600 2019-06-25  Tom Tromey  <tom@tromey.com>
3601
3602         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3603         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3604         clear_detail method directly.
3605         (tui_clear_win_detail): Remove.
3606
3607 2019-06-25  Tom Tromey  <tom@tromey.com>
3608
3609         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3610         "this", not TUI_DISASM_WIN.
3611
3612 2019-06-25  Tom Tromey  <tom@tromey.com>
3613
3614         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3615         declare.
3616         * tui/tui-winsource.c
3617         (tui_source_window_base::do_scroll_horizontal): Rename from
3618         tui_horizontal_source_scroll.
3619         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3620         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3621         from tui_vertical_data_scroll.
3622         * tui/tui-win.h (tui_scroll): Don't declare.
3623         * tui/tui-win.c (tui_win_info::forward_scroll)
3624         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3625         (tui_win_info::right_scroll): Rename and update.
3626         (tui_scroll_forward_command, tui_scroll_backward_command)
3627         (tui_scroll_left_command, tui_scroll_right_command): Update.
3628         (tui_scroll): Remove.
3629         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3630         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3631         from tui_vertical_source_scroll.
3632         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3633         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3634         from tui_vertical_disassem_scroll.
3635         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3636         do_scroll_horizontal>: New methods.
3637         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3638         Likewise.
3639         (struct tui_source_window_base): Add do_scroll_horizontal.
3640         (struct tui_source_window, struct tui_disasm_window): Add
3641         do_scroll_vertical.
3642         (struct tui_data_window, struct tui_cmd_window): Add
3643         do_scroll_horizontal and do_scroll_vertical.
3644         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3645
3646 2019-06-25  Tom Tromey  <tom@tromey.com>
3647
3648         * tui/tui-data.h (struct tui_source_window_base): New struct.
3649         (struct tui_source_window): Derive from tui_source_window_base.
3650         (struct tui_disasm_window): New struct.
3651         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3652         from tui_source_window::clear_detail.
3653         (tui_source_window_base): Rename from tui_source_window.
3654         (~tui_source_window_base): Rename from ~tui_source_window.
3655         (tui_alloc_win_info): Create a tui_disasm_window.
3656
3657 2019-06-25  Tom Tromey  <tom@tromey.com>
3658
3659         * tui/tui-data.h (struct tui_source_window)
3660         (struct tui_data_window): Declare destructors.
3661         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3662         destructors.
3663         (tui_win_info): Simplify.
3664
3665 2019-06-25  Tom Tromey  <tom@tromey.com>
3666
3667         * tui/tui-winsource.c (tui_display_main)
3668         (tui_update_source_windows_with_addr)
3669         (tui_update_all_breakpoint_info): Update.
3670         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3671         (new_height_ok, parse_scrolling_args): Update.
3672         * tui/tui-stack.c (tui_show_frame_info): Update.
3673         * tui/tui-data.h (struct tui_list): Remove.
3674         (tui_source_windows): Return a reference to a std::vector.
3675         * tui/tui-data.c (source_windows): Now a std::vector.
3676         (tui_source_windows): Change return type.
3677         (tui_clear_source_windows): Rewrite.
3678         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3679         (tui_free_all_source_wins_content): Rewrite.
3680
3681 2019-06-25  Tom Tromey  <tom@tromey.com>
3682
3683         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3684         (struct tui_data_window, struct tui_cmd_window): Declare
3685         clear_detail method.
3686         * tui/tui-data.c (tui_source_window::clear_detail)
3687         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3688         methods.
3689         (tui_clear_win_detail): Simplify.
3690
3691 2019-06-25  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-layout.c (make_source_window, make_disasm_window)
3694         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3695         Return the new window.
3696         (show_source_disasm_command, show_data)
3697         (show_source_or_disasm_and_command): Update.
3698
3699 2019-06-25  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3702         parameter.  Return the new window.
3703         (show_source_disasm_command): Update and remove NULL check.
3704         (show_source_or_disasm_and_command): Update.
3705
3706 2019-06-25  Tom Tromey  <tom@tromey.com>
3707
3708         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3709
3710 2019-06-25  Tom Tromey  <tom@tromey.com>
3711
3712         * tui/tui-data.h (struct tui_win_info): Make constructor
3713         protected.  Make destructor virtual.  Add initializers.
3714         (tui_source_window, tui_data_window, tui_cmd_window): New
3715         classes.
3716         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3717         constructor.  Add "type" parameter.
3718         (tui_source_window, tui_data_window, tui_cmd_window): New
3719         constructors.
3720         (tui_alloc_win_info): Instantiate the appropriate subclass.
3721
3722 2019-06-25  Tom Tromey  <tom@tromey.com>
3723
3724         * tui/tui-win.c (tui_resize_all): Use delete.
3725         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3726         destructor.
3727         (tui_free_window): Don't declare.
3728         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3729         Update.
3730
3731 2019-06-25  Tom Tromey  <tom@tromey.com>
3732
3733         * tui/tui-data.h (struct tui_win_info): Add constructor.
3734         * tui/tui-data.c (tui_alloc_win_info): Use new.
3735         (tui_free_window): Use delete.
3736
3737 2019-06-22  Tom Tromey  <tom@tromey.com>
3738
3739         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3740         declare.
3741         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3742
3743 2019-06-22  Tom Tromey  <tom@tromey.com>
3744
3745         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3746         declare.
3747         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3748
3749 2019-06-22  Tom de Vries  <tdevries@suse.de>
3750
3751         * dwarf2read.c (create_addrmap_from_aranges)
3752         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3753         instead of '%zu'.
3754
3755 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3756
3757         * dwarf2read.h (dwarf2_section_info_def): Remove.
3758         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3759         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3760         std::vector<dwarf2_section_info>.
3761         (struct dwo_file) <~dwo_file>: Remove.
3762         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3763         types field.
3764         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3765         (dwarf2_read_debug_names): Likewise.
3766         (create_debug_types_hash_table): Change parameter type to
3767         array_view, adjust code accordingly.
3768         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3769         (partial_die_info::fixup): Likewise.
3770         (determine_prefix): Likewise.
3771         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3772
3773 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3774
3775         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3776         gdb_bfd_ref_ptr.
3777         <~dwo_file>: Remove call to gdb_bfd_unref.
3778         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3779         gdb_bfd_ref_ptr::get.
3780
3781 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3782
3783         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3784         type to htab_up.
3785         * dwarf2read.c (struct dwo_file): Initialize fields.
3786         <~dwo_file>: New.
3787         (free_dwo_file): Remove, move content to ~dwo_file.
3788         (struct dwo_file_deleter): Remove.
3789         (dwo_file_up>: Remove custom deleter.
3790         (free_dwo_files): Remove.
3791         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3792         dwo_files.
3793         (process_skeletonless_type_units): Call unique_ptr::get.
3794         (allocate_dwo_file_hash_table): Add deleter to created hash
3795         table.  Change return type to htab_up.
3796         (lookup_dwo_file_slot): Don't memset dwo_file, call
3797         unique_ptr::get.
3798         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3799         (create_dwo_unit_in_dwp_v2): Likewise.
3800         (open_and_init_dwo_file): Likewise.
3801         (free_dwo_file_from_slot): Remove.
3802
3803 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3804
3805         * dwarf2read.h (struct dwarf2_section_info) <readin,
3806         is_virtual>: Change type to bool.
3807         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3808         true instead of 1.
3809
3810 2019-06-19  Tom Tromey  <tom@tromey.com>
3811
3812         * tui/tui-data.h (tui_init_content_element): Don't declare.
3813
3814 2019-06-19  Tom Tromey  <tom@tromey.com>
3815
3816         * tui/tui-data.h (tui_init_win_info): Don't declare.
3817
3818 2019-06-19  Tom de Vries  <tdevries@suse.de>
3819
3820         * dwarf2read.h (abstract_to_concrete): Change type to
3821         std::unordered_map<sect_offset, std::vector<sect_offset>,
3822         gdb::hash_enum<sect_offset>>.
3823
3824 2019-06-19  Tom Tromey  <tromey@adacore.com>
3825
3826         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3827         EVAL_AVOID_SIDE_EFFECTS specially.
3828
3829 2019-06-19  Tom Tromey  <tromey@adacore.com>
3830
3831         * source-cache.c (highlighter): New global.
3832         (source_cache::get_source_lines): Create a highlighter on demand.
3833
3834 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * defs.h (deprecated_interactive_hook): Delete declaration.
3837         * interps.c (clear_interpreter_hooks): Remove use of
3838         deprecated_interactive_hook.
3839         * top.c (deprecated_interactive_hook): Delete definition.
3840         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3841
3842 2019-06-18  Tom de Vries  <tdevries@suse.de>
3843
3844         PR gdb/24515
3845         * dwarf2read.h (abstract_to_concrete): Change type from
3846         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3847         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3848         * dwarf2read.c (read_variable): Update.
3849         (dwarf2_fetch_die_loc_sect_off): Update.
3850
3851 2019-06-17  Tom de Vries  <tdevries@suse.de>
3852
3853         PR gdb/24617
3854         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3855         accessing parent[parent_len - 1].
3856
3857 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3858
3859         PR gdb/24364
3860         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3861         call dtrace_process_dof with NULL dof.
3862
3863 2019-06-16  Tom de Vries  <tdevries@suse.de>
3864
3865         PR gdb/24445
3866         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3867
3868 2019-06-16  Tom Tromey  <tom@tromey.com>
3869
3870         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3871         (make_all_visible): Use address of member.
3872
3873 2019-06-16  Tom Tromey  <tom@tromey.com>
3874
3875         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3876         (tui_free_window, free_content, free_content_elements): Remove
3877         unnecessary cast.
3878         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3879         cast.
3880         * tui/tui-regs.c (tui_show_register_group)
3881         (tui_display_registers_from, tui_display_reg_element_at_line):
3882         Remove unnecessary cast.
3883
3884 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3885
3886         * linux-nat.c (normal_mask): Delete.
3887         (_initialize_linux_nat): Don't initialise normal_mask.
3888
3889 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3890
3891         PR gdb/24445
3892         * dwarf-index-write.h (write_psymtabs_to_index): Add
3893         dwz_basename parameter.
3894         * dwarf-index-write.c (write_gdbindex): Move file writing to
3895         write_gdbindex_1.  Change return type void.
3896         (assert_file_size): Move up, remove filename parameter.
3897         (write_gdbindex_1): New function.
3898         (write_debug_names): Change return type to void, call
3899         assert_file_size.
3900         (struct index_wip_file): New struct.
3901         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3902         file logic to index_wip_file.  Write index for dwz file if
3903         needed.
3904         (save_gdb_index_command): Pass basename of dwz file, if present.
3905         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3906         build-id of dwz file, if present.
3907         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3908         (dwarf2_get_dwz_file): Likewise.
3909         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3910         (dwarf2_get_dwz_file): Likewise.
3911
3912 2019-06-16  Tom Tromey  <tom@tromey.com>
3913
3914         * coffread.c (process_coff_symbol): Use xstrdup.
3915         * value.c (create_internalvar): Use xstrdup.
3916
3917 2019-06-16  Tom Tromey  <tom@tromey.com>
3918
3919         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3920         * breakpoint.c (stopin_command, stopat_command)
3921         (until_break_command, decode_location_default): Remove unnecessary
3922         cast.
3923         * utils.c (subset_compare): Remove unnecessary cast.
3924         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3925         cast.
3926         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3927         cast.
3928         * infcmd.c (path_command): Remove unnecessary cast.
3929         * coffread.c (decode_type): Remove unnecessary cast.
3930         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3931         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3932         * tui/tui-stack.c (tui_show_locator_content)
3933         (tui_show_frame_info): Remove unnecessary cast.
3934         * tui/tui-win.c (tui_scroll_forward_command)
3935         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3936         (parse_scrolling_args): Remove unnecessary cast.
3937         * tui/tui-data.c (init_win_info, tui_del_window)
3938         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3939         (free_content_elements): Remove unnecessary cast.
3940         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3941         unnecessary cast.
3942         * tui/tui-source.c (tui_set_source_content)
3943         (tui_vertical_source_scroll): Remove unnecessary cast.
3944         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3945         cast.
3946         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3947         * tui/tui-regs.c (tui_display_registers_from)
3948         (tui_display_register): Remove unnecessary cast.
3949         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3950         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3951         (make_visible): Remove unnecessary cast.
3952         * tui/tui-winsource.c (tui_erase_source_content)
3953         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3954         unnecessary cast.
3955         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3956         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3957         * stabsread.c (read_type, read_array_type, read_range_type):
3958         Remove unnecessary cast.
3959         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3960         (parse_symbol, parse_type, upgrade_type, parse_external)
3961         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3962         unnecessary cast.
3963         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3964
3965 2019-06-16  Tom Tromey  <tom@tromey.com>
3966
3967         * tui/tui-data.c (tui_alloc_generic_win_info)
3968         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3969         checks.
3970
3971 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3972             Andrew Burgess  <andrew.burgess@embecosm.com>
3973
3974         * f-typeprint.c (f_print_type): Don't return early for not
3975         associated or not allocated types.
3976         (f_type_print_varspec_suffix): Add print_rank parameter and print
3977         ranks of array types in case they dangling.
3978         (f_type_print_base): Add print_rank parameter.
3979
3980 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3981
3982         * NEWS: Mention new MI commands.
3983         * break-catch-throw.c (enum exception_event_kind): Move to
3984         breakpoint.h.
3985         (print_mention_exception_catchpoint): Output text as a single
3986         message.
3987         (catch_exception_command_1): Rename to...
3988         (catch_exception_event): ...this, make non-static, update header
3989         command, and change some parameter types.
3990         (catch_catch_command): Update for changes to
3991         catch_exception_command_1.
3992         (catch_throw_command): Likewise.
3993         (catch_rethrow_command): Likewise.
3994         * breakpoint.c (enum exception_event_kind): Delete.
3995         * breakpoint.h (enum exception_event_kind): Moved here from
3996         break-catch-throw.c.
3997         (catch_exception_event): Declare.
3998         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3999         (mi_cmd_catch_throw): New function.
4000         (mi_cmd_catch_rethrow): New function.
4001         (mi_cmd_catch_catch): New function.
4002         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4003         'catch-catch' entries.
4004         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4005         (mi_cmd_catch_rethrow): Declare.
4006         (mi_cmd_catch_catch): Declare.
4007
4008 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4009
4010         * annotate.c (annotate_source_line): Change return type to void,
4011         update implementation to match.
4012         * annotate.h (annotate_source_line): Change return type to void,
4013         update header comment.
4014         * stack.c (print_frame_info): Don't change what frame information
4015         is printed based on whether annotations are on or not.
4016
4017 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4018
4019         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4020         (annotate_source): Make static.
4021         (annotate_source_line): Moved from source.c and renamed from
4022         identify_source_line.  Update the return type.
4023         * annotate.h (annotate_source): Delete declaration.
4024         (annotate_source_line): Declaration moved from source.h, and
4025         renamed from identify_source_line.  Return type updated.
4026         * source.c (identify_source_line): Moved to annotate.c and renamed
4027         to annotate_source_line.
4028         (info_line_command): Remove check of annotation_level.
4029         * source.h (identify_source_line): Move declaration to annotate.h
4030         and rename to annotate_source_line.
4031         * stack.c: Add 'annotate.h' include.
4032         (print_frame_info): Remove check of annotation_level before
4033         calling annotate_source_line.
4034
4035 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4036
4037         * source-cache.c (source_cache::get_plain_source_lines): Use
4038         open_source_file_with_line_charpos instead of just
4039         open_source_file, remove call to find_source_lines.
4040         (source_cache::get_source_lines): Likewise.
4041         * source.c (find_source_lines): Make static.
4042         (get_filename_and_charpos): Renamed into...
4043         (open_source_file_with_line_charpos): ..this along with changes to
4044         return a scoped_fd, and some other minor clean ups.
4045         (identify_source_line): Use open_source_file_with_line_charpos.
4046         (search_command_helper): Use open_source_file_with_line_charpos
4047         instead of just open_source_file, remove call to
4048         find_source_lines.
4049         * source.h (open_source_file_with_line_charpos): Declare new
4050         function.
4051         (find_source_lines): Delete declaration.
4052
4053 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4054
4055         * source.c (get_filename_and_charpos): Remove fullname
4056         parameter.
4057         (identify_source_line): Update call to get_filename_and_charpos.
4058
4059 2019-06-14  Tom Tromey  <tromey@adacore.com>
4060
4061         PR gdb/24502:
4062         * ui-style.h (skip_ansi_escape): Update comment.
4063         * ui-file.h (class no_terminal_escape_file): New class.
4064         * ui-file.c (no_terminal_escape_file::write)
4065         (no_terminal_escape_file::puts): New methods.
4066         * cli/cli-logging.c (handle_redirections): Use
4067         no_terminal_escape_file.
4068
4069 2019-06-14  Tom Tromey  <tromey@adacore.com>
4070
4071         * NEWS: Move convenience variable news above Python news.
4072
4073 2019-06-14  Tom Tromey  <tom@tromey.com>
4074
4075         * gnulib: Move directory to top-level.
4076         * configure.ac: Don't configure gnulib.
4077         * configure: Rebuild.
4078         * common/common-defs.h: Use new path to gnulib.
4079         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4080         (GNULIB_H): Remove.
4081         (INCGNU): Look in new gnulib location.
4082         (HFILES_NO_SRCDIR): Remove gnulib files.
4083         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4084         (generated_files): Remove GNULIB_H.
4085         ($(LIBGNU), all-lib): Remove targets.
4086         (distclean): Don't mention GNULIB_BUILDDIR.
4087         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4088
4089 2019-06-14  Tom Tromey  <tromey@adacore.com>
4090
4091         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4092         Warn if symbol file does not provide any symbols.
4093
4094 2019-06-14  Tom Tromey  <tromey@adacore.com>
4095
4096         * source.c (find_and_open_source): Respect basenames_may_differ.
4097
4098 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4099
4100         * annotate.c (annotate_breakpoints_invalid): Make use of
4101         scoped_restore_terminal_state.
4102         (annotate_frames_invalid): Likewise.
4103
4104 2019-06-14  Tom Tromey  <tromey@adacore.com>
4105
4106         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4107         allow assignment to an internalvar.
4108
4109 2019-06-14  Tom Tromey  <tromey@adacore.com>
4110
4111         * ada-lex.l: Allow "_" in attribute names.
4112
4113 2019-06-14  Tom Tromey  <tromey@adacore.com>
4114
4115         PR gdb/24653:
4116         * regcache.c (registers_changed): Don't call alloca.
4117         * top.c (execute_command): Don't call alloca.
4118
4119 2019-06-13  Pedro Alves  <palves@redhat.com>
4120
4121         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4122         'expression'.  When parsing an expression, error out if there's
4123         junk after "unlimited".
4124         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4125         (do_set_command): Adjust calls to is_unlimited_literal.
4126
4127 2019-06-13  Pedro Alves  <palves@redhat.com>
4128
4129         * compile/compile.c (make_compile_options_def_group): Add braces
4130         around array_view initializer.
4131         * thread.c (make_thread_apply_all_options_def_group)
4132         (make_thread_apply_all_options_def_group): Likewise.
4133
4134 2019-06-13  Pedro Alves  <palves@redhat.com>
4135
4136         * NEWS (New commands): Mention "maint test-options
4137         require-delimiter", "maint test-options unknown-is-error", "maint
4138         test-options unknown-is-operand" and "maint show
4139         test-options-completion-result".
4140         (New command options, command completion): New section.
4141         (Completion improvements): New section.
4142         Mention that you can abbreviate "unlimited".
4143
4144 2019-06-13  Pedro Alves  <palves@redhat.com>
4145
4146         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4147         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4148         * unittests/cli-utils-selftests.c (test_parse_flags)
4149         (test_parse_flags_qcs): Delete.
4150         (test_cli_utils): Don't call deleted functions.
4151
4152 2019-06-13  Pedro Alves  <palves@redhat.com>
4153
4154         * thread.c: Include "cli/cli-option.h".
4155         (tp_array_compar_ascending): Global.
4156         (tp_array_compar): Delete function.
4157         (tp_array_compar_ascending, tp_array_compar_descending): New
4158         functions.
4159         (ascending_option_def, qcs_flag_option_def)
4160         (thr_qcs_flags_option_defs)
4161         (make_thread_apply_all_options_def_group)
4162         (make_thread_apply_options_def_group): New.
4163         (thread_apply_all_command): Use gdb::option::process_options.
4164         (thread_apply_command_completer)
4165         (thread_apply_all_command_completer): New.
4166         (thread_apply_command): Use gdb::option::process_options.
4167         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4168         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4169         to generate help text of "thread apply".  Adjust "taas"'s help.
4170         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4171         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4172
4173 2019-06-13  Pedro Alves  <palves@redhat.com>
4174
4175         * thread.c (thread_apply_command): Check for invalid TID with
4176         isdigit instead of !isalpha.
4177
4178 2019-06-13  Pedro Alves  <palves@redhat.com>
4179
4180         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4181         (validate_flags_qcs): New.
4182         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4183         (validate_flags_qcs): Declare.
4184         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4185         (make_frame_apply_options_def_group): New.
4186         (frame_apply_command_count): Process options with
4187         gdb::option::process_options.
4188         (frame_apply_completer): New.
4189         (frame_apply_level_completer, frame_apply_all_completer)
4190         (frame_apply_completer): New.
4191         (_initialize_stack): Update help of "frame apply", "frame apply
4192         level", "frame apply all" and "faas" to mention supported options
4193         and install command completers.
4194         * stack.h (frame_apply_all_completer): Declare.
4195         * thread.c: Include "stack.h".
4196         (tfaas_command): Add "--".
4197         (_initialize_thread): Update help "tfaas" to mention supported
4198         options and install command completer.
4199
4200 2019-06-13  Pedro Alves  <palves@redhat.com>
4201
4202         * completer.c (complete_nested_command_line): New.
4203         (gdb_completion_word_break_characters_throw): Add assertion.
4204         * completer.h (complete_nested_command_line): Declare.
4205
4206 2019-06-13  Pedro Alves  <palves@redhat.com>
4207
4208         * stack.c (parse_backtrace_qualifiers): New.
4209         (backtrace_command): Use it.
4210         (backtrace_command_completer): Complete on qualifiers.
4211
4212 2019-06-13  Pedro Alves  <palves@redhat.com>
4213
4214         * frame.c: Include "cli/cli-option.h.
4215         (user_set_backtrace_options): New.
4216         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4217         Delete.
4218         (get_prev_frame): Adjust.
4219         (boolean_option_def, uinteger_option_def)
4220         (set_backtrace_option_defs): New.
4221         (_initialize_frame): Adjust and use
4222         gdb::option::add_setshow_cmds_for_options to install "set
4223         backtrace past-main" and "set backtrace past-entry".
4224         * frame.h: Include "cli/cli-option.h".
4225         (struct frame_print_options): Forward declare.
4226         (print_frame_arguments_all, print_frame_arguments_scalars)
4227         (print_frame_arguments_none): Declare.
4228         (print_entry_values): Delete declaration.
4229         (struct frame_print_options, user_frame_print_options): New.
4230         (struct set_backtrace_options): New.
4231         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4232         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4233         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4234         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4235         (list_args_or_locals): Add frame_print_options parameter.
4236         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4237         * python/py-framefilter.c (enumerate_args): Pass down
4238         USER_FRAME_PRINT_OPTIONS.
4239         * stack.c: Include "cli/cli-option.h".
4240         (print_frame_arguments_all, print_frame_arguments_scalars)
4241         (print_frame_arguments_none): Declare.
4242         (print_raw_frame_arguments, print_entry_values): Delete.
4243         (user_frame_print_options): New.
4244         (boolean_option_def, enum_option_def, frame_print_option_defs):
4245         New.
4246         (struct backtrace_cmd_options): New.
4247         (bt_flag_option_def): New.
4248         (backtrace_command_option_defs): New.
4249         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4250         (print_frame_arg, read_frame_arg, print_frame_args)
4251         (print_frame_info, print_frame): Add frame_print_options parameter
4252         and use it.
4253         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4254         (backtrace_command_1): Add frame_print_options and
4255         backtrace_cmd_options parameters and use them.
4256         (make_backtrace_options_def_group): New.
4257         (backtrace_command): Process command options with
4258         gdb::option::process_options.
4259         (backtrace_command_completer): New.
4260         (_initialize_stack): Extend "backtrace"'s help to mention
4261         supported options.  Install completer for "backtrace".
4262         Install some settings commands with add_setshow_cmds_for_options.
4263
4264 2019-06-13  Pedro Alves  <palves@redhat.com>
4265
4266         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4267         and that "set/show print raw frame-arguments" are now deprecated.
4268
4269         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4270         command.
4271         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4272         * stack.c (_initialize_stack): Install "set/show print
4273         raw-frame-arguments", and deprecate "set/show print raw
4274         frame-arguments".
4275         * valprint.c (_initialize_valprint): Deprecate "set/show print
4276         raw".
4277
4278 2019-06-13  Pedro Alves  <palves@redhat.com>
4279
4280         * compile/compile.c (struct compile_options): New.
4281         (compile_flag_option_def, compile_command_option_defs)
4282         (make_compile_options_def_group): New.
4283         (compile_file_command): Handle options with
4284         gdb::option::process_options.
4285         (compile_file_command_completer): New function.
4286         (compile_code_command): Handle options with
4287         gdb::option::process_options.
4288         (compile_code_command_completer): New function.
4289         (_initialize_compiler): Install completers for "compile code" and
4290         "compile file".  Mention available options in "compile code" and
4291         "compile code"'s help.
4292         * completer.c (advance_to_completion_word): New, factored out from
4293         ...
4294         (advance_to_expression_complete_word_point): ... this.
4295         (advance_to_filename_complete_word_point): New.
4296         * completer.h (advance_to_filename_complete_word_point): New
4297         declaration.
4298
4299 2019-06-13  Pedro Alves  <palves@redhat.com>
4300
4301         * compile/compile.c: Include "cli/cli-option.h".
4302         (compile_print_value): Scope data pointer is now a
4303         value_print_options pointer; adjust.
4304         (compile_print_command): Process options.  Scope data pointer is
4305         now a value_print_options pointer; adjust.
4306         (_initialize_compile): Update "compile print"'s help to include
4307         supported options.  Install a completer for "compile print".
4308         * cp-valprint.c (show_vtblprint, show_objectprint)
4309         (show_static_field_print): Delete.
4310         (_initialize_cp_valprint): Don't install "set print
4311         static-members", "set print vtbl", "set print object" here.
4312         * printcmd.c: Include "cli/cli-option.h" and
4313         "common/gdb_optional.h".
4314         (print_command_parse_format): Rework to fill in a
4315         value_print_options instead of a format_data.
4316         (print_value): Change parameter type from format_data pointer to
4317         value_print_options reference.  Adjust.
4318         (print_command_1): Process options.  Adjust to pass down a
4319         value_print_options.
4320         (print_command_completer): New.
4321         (_initialize_printcmd): Install print_command_completer as
4322         handle_brkchars completer for the "print" command.  Update
4323         "print"'s help to include supported options.
4324         * valprint.c: Include "cli/cli-option.h".
4325         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4326         here from cp-valprint.c.
4327         (boolean_option_def, uinteger_option_def)
4328         (value_print_option_defs, make_value_print_options_def_group):
4329         New.  Use gdb::option::add_setshow_cmds_for_options to install
4330         "set print elements", "set print null-stop", "set print repeats",
4331         "set print pretty", "set print union", "set print array", "set
4332         print address", "set print symbol", "set print array-indexes".
4333         * valprint.h: Include <string> and "cli/cli-option.h".
4334         (make_value_print_options_def_group): Declare.
4335         (print_value): Change parameter type from format_data pointer to
4336         value_print_options reference.
4337         (print_command_completer): Declare.
4338
4339 2019-06-13  Pedro Alves  <palves@redhat.com>
4340
4341         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4342         (COMMON_SFILES): Add maint-test-settings.c.
4343         * cli/cli-decode.c (boolean_enums): New global, factored out from
4344         ...
4345         (add_setshow_boolean_cmd): ... here.
4346         * cli/cli-decode.h (boolean_enums): Declare.
4347         * cli/cli-option.c: New file.
4348         * cli/cli-option.h: New file.
4349         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4350         factored out from ...
4351         (parse_cli_boolean_value(const char *)): ... this.
4352         (is_unlimited_literal): Change parameter type to pointer to
4353         pointer.  Adjust and advance ARG pointer.
4354         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4355         (parse_cli_var_enum): New, factored out from ...
4356         (do_set_command): ... this.  Adjust.
4357         * cli/cli-setshow.h (parse_cli_boolean_value)
4358         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4359         (parse_cli_var_enum): Declare.
4360         * cli/cli-utils.c: Include "cli/cli-option.h".
4361         (get_ulongest): New.
4362         * cli/cli-utils.h (get_ulongest): Declare.
4363         (check_for_argument): New overloads.
4364         * maint-test-options.c: New file.
4365
4366 2019-06-13  Pedro Alves  <palves@redhat.com>
4367
4368         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4369         parse a range if "-" is at the end of the string.
4370
4371 2019-06-13  Pedro Alves  <palves@redhat.com>
4372
4373         * cli/cli-setshow.c (parse_auto_binary_operation)
4374         (parse_cli_boolean_value): Don't allow "o".
4375
4376 2019-06-13  Pedro Alves  <palves@redhat.com>
4377
4378         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4379         * NEWS: Mention maint test-settings KIND.
4380         * maint-test-settings.c: New file.
4381
4382 2019-06-13  Pedro Alves  <palves@redhat.com>
4383
4384         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4385         completer.
4386         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4387         "set" completers.
4388
4389 2019-06-13  Pedro Alves  <palves@redhat.com>
4390
4391         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4392         after item.
4393
4394 2019-06-13  Pedro Alves  <palves@redhat.com>
4395
4396         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4397
4398 2019-06-13  Pedro Alves <palves@redhat.com>
4399
4400         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4401         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4402         call.
4403         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4404         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4405         calls.
4406         (check_for_argument): Skip spaces after argument.
4407
4408 2019-06-13  Pedro Alves  <palves@redhat.com>
4409
4410         * thread.c (thread_apply_command): Adjust TID parsing.
4411         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4412         detected before end of string.
4413         (tid_is_in_list): Error out if LIST is invalid.
4414
4415 2019-06-13  Pedro Alves  <palves@redhat.com>
4416
4417         * completer.c (complete_line_internal_1): Rewind completion word
4418         point.
4419         (completion_tracker::advance_custom_word_point_by): Change
4420         parameter type to int.
4421         * completer.h (completion_tracker::advance_custom_word_point_by):
4422         Likewise.
4423
4424 2019-06-13  Pedro Alves  <palves@redhat.com>
4425
4426         * completer.c (advance_to_completion_word): Handle delimiters.
4427
4428 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4429
4430         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4431
4432 2019-06-11  Tom Tromey  <tom@tromey.com>
4433
4434         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4435         (xmalloc_failed): Move to alloc.c.
4436         * alloc.c: New file.
4437         * Makefile.in (COMMON_SFILES): Add alloc.c.
4438
4439 2019-06-11  Tom Tromey  <tom@tromey.com>
4440
4441         * nat/linux-waitpid.c: Don't include server.h.
4442         (linux_debug): Remove.
4443         (my_waitpid): Update.
4444
4445 2019-06-11  Tom Tromey  <tromey@adacore.com>
4446
4447         * infcall.c (_initialize_infcall): Remove trailing newline from
4448         help.
4449         * user-regs.c (_initialize_user_regs): Remove trailing newline
4450         from help.
4451         * typeprint.c (_initialize_typeprint): Remove trailing newline
4452         from help.
4453         * reverse.c (_initialize_reverse): Remove trailing newlines from
4454         help.
4455         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4456         from help.
4457         * language.c (add_set_language_command): Remove trailing newline
4458         from help.
4459         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4460         help.
4461         * disasm.c (_initialize_disasm): Remove trailing newline from
4462         help.
4463         * top.c (init_main): Remove trailing newline from help.
4464         * interps.c (_initialize_interpreter): Remove trailing newline
4465         from help.
4466         * btrace.c (_initialize_btrace): Remove trailing newlines from
4467         help.
4468         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4469         from help.
4470         * python/python.c (_initialize_python): Remove trailing newline
4471         from help.
4472         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4473         help.
4474         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4475         from help.  Reformat some text.
4476         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4477         from help.
4478         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4479         newline from help.
4480
4481 2019-06-11  Tom Tromey  <tromey@adacore.com>
4482
4483         * darwin-nat.c (darwin_decode_exception_message)
4484         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4485
4486 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4487
4488         * valops.c (value_slice): Check for not allocated or not
4489         associated values.
4490
4491 2019-06-10  Tom de Vries  <tdevries@suse.de>
4492
4493         PR gdb/24618
4494         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4495         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4496         invalid.
4497
4498 2019-06-10  Tom de Vries  <tdevries@suse.de>
4499
4500         PR gdb/24611
4501         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4502         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4503
4504 2019-06-10  Tom de Vries  <tdevries@suse.de>
4505
4506         PR symtab/24545
4507         * symtab.c (struct demangled_name_entry): Add language field.
4508         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4509         static minimal symbol".  Set and use language field.
4510
4511 2019-06-10  Tom Tromey  <tromey@adacore.com>
4512
4513         * ada-lang.c (_initialize_ada_language): Update help text.
4514
4515 2019-06-10  Tom Tromey  <tromey@adacore.com>
4516
4517         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4518         with a newline.
4519         * guile/guile.c (handle_boot_error): Don't end warning with a
4520         newline.
4521         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4522         warning with a newline.
4523         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4524         newline.
4525         (s12z_frame_cache): Likewise.
4526         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4527         a newline.
4528         * solib-svr4.c (disable_probes_interface): Don't end warning with
4529         a newline.
4530         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4531         newline.
4532         * python/python.c (do_finish_initialization): Don't end warning
4533         with a newline.
4534
4535 2019-06-10  Tom Tromey  <tom@tromey.com>
4536
4537         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4538         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4539         gdbpy_enter.
4540
4541 2019-06-10  Tom Tromey  <tromey@adacore.com>
4542
4543         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4544         data.
4545         (elf_new_init): Don't call stabsread_new_init.
4546         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4547         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4548         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4549
4550 2019-06-10  Tom de Vries  <tdevries@suse.de>
4551
4552         PR symtab/16264
4553         PR symtab/24517
4554         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4555
4556 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4557
4558         * source.c (find_and_open_source): Also rewrite relative file
4559         names.
4560
4561 2019-04-26  Amos Bird  <amosbird@gmail.com>
4562
4563         * annotate.c (annotate_thread_exited): Add "thread-exited"
4564         annotation.
4565
4566 2019-06-06  Tom Tromey  <tromey@adacore.com>
4567
4568         * maint.h (class scoped_command_stats): Use
4569         DISABLE_COPY_AND_ASSIGN.
4570         <print_time>: New method.
4571         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4572         print_time.
4573         (scoped_command_stats::print_time): New method.
4574
4575 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4576
4577         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4578         instructions of lengths 6 or 8 bytes.
4579
4580 2019-06-04  Pedro Alves  <palves@redhat.com>
4581
4582         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4583
4584         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4585         * breakpoint.c (condition_completer): Likewise.
4586         * cli/cli-dump.c (scan_expression): Likewise.
4587         * common/filestuff.c (mkdir_recursive): Likewise.
4588         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4589         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4590         (gdb_abspath): Likewise.
4591         * compile/compile-cplus-types.c
4592         (compile_cplus_instance::decl_name): Likewise.
4593         * completer.c (complete_explicit_location):
4594         (signal_completer, reg_or_group_completer_1): Likewise.
4595         * cp-support.c (cp_remove_params_if_any): Likewise.
4596         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4597         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4598         * infcmd.c (strip_bg_char): Likewise.
4599         * linespec.c (copy_token_string): Likewise.
4600         * mi/mi-main.c (output_cores): Likewise.
4601         * psymtab.c (psymtab_search_name):
4602         * symfile.c (test_set_ext_lang_command): Likewise.
4603         * target.c (target_fileio_read_stralloc): Likewise.
4604         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4605         * value.c (complete_internalvar): Likewise.
4606
4607 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4608
4609         Add objfile property to gdb.Type.
4610         * NEWS: Mention Python API addition.
4611         * python/py-type.c (typy_get_objfile): New method.
4612
4613 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4614
4615         * NEWS: Mention the new set|show style [title|highlight].
4616         Mention changes to "show style", "help" and "apropos".
4617
4618 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4619
4620         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4621         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4622         instead of print_help_for_command.
4623         (print_doc_of_command): New function.
4624         (help_list): Add 'apropos -v word' suggestion.
4625         (print_help_for_command): Style the command name using title style.
4626         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4627         (_initialize_cli_cmds): Describe -v in apropos_command help.
4628
4629 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4630
4631         * cli/cli-style.h (cli_style_option): Add name in constructor,
4632         add m_name class member, add constructor with intensity,
4633         add name class function.
4634         (cli_style_option::add_setshow_commands): Remove name argument.
4635         (highlight_style, title_style): New styles.
4636         * cli/cli-style.c (do_show): New function that shows a style
4637         characteristic styling the style name with itself.
4638         (set_style_name): New function.
4639         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4640         Update all callers according to the changes in cli/cli-style.h.
4641         * utils.h (fputs_highlighted): New function.
4642         * utils.c (fputs_highlighted): Likewise.
4643
4644 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4645
4646         * NEWS: Mention new pipe command and new convenience variables.
4647
4648 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4649
4650         * cli/cli-cmds.c (pipe_command): New function.
4651         (_initialize_cli_cmds): Call add_com for pipe_command.
4652         Define | as an alias for pipe.
4653         (exit_status_set_internal_vars): New function.
4654         (shell_escape): Call exit_status_set_internal_vars.
4655         cli/cli-decode.c (find_command_name_length): Recognize | as
4656         a single character command.
4657
4658 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4659
4660         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4661         top.c (execute_command_to_ui_file): New function, mostly a copy
4662         of execute_command_to_string.
4663         (execute_command_to_string): Implement by calling
4664         execute_command_to_ui_file.
4665
4666 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4667
4668         * top.h (saved_command_line): Remove declaration.
4669         * top.c (previous_saved_command_line, previous_repeat_arguments):
4670         New variables.
4671         (saved_command_line): Make static, define together with other
4672         'repeat variables'.
4673         (dont_repeat): Clear repeat_arguments.
4674         (repeat_previous, get_saved_command_line, save_command_line):
4675         New functions.
4676         (gdb_init): Initialize saved_command_line
4677         and previous_saved_command_line.
4678         * main.c (captured_main_1): Remove saved_command_line initialization.
4679         * event-top.c (handle_line_of_input): Update to use
4680         the new 'repeat' related functions instead of direct access to
4681         saved_command_line.
4682         * command.h (repeat_previous, get_saved_command_line,
4683         save_command_line): New declarations.
4684         (dont_repeat): Add comment.
4685
4686 2019-05-30  Tom Tromey  <tromey@adacore.com>
4687
4688         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4689         Fix comment.
4690         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4691
4692 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4693
4694         PR cli/24587
4695         * completer.c (complete): Initialize variable word.
4696
4697 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4698
4699         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4700         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4701         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4702         'body' is NULL to the outter 'if', protecting the '!is_define'
4703         situation as well.
4704
4705 2019-05-29  Tom Tromey  <tromey@adacore.com>
4706
4707         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4708         (dwarf_unknown): New function.
4709         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4710         (dwarf_type_encoding_name): Use dwarf_unknown.
4711
4712 2019-05-29  Tom Tromey  <tromey@adacore.com>
4713
4714         PR c++/20020:
4715         * cp-valprint.c (cp_print_value_fields): Call
4716         cp_print_static_field inside "try".
4717
4718 2019-05-29  Tom Tromey  <tromey@adacore.com>
4719
4720         * inflow.c (struct terminal_info): Add default operator=.
4721         * configure: Rebuild.
4722         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4723         -Wdeprecated-copy-dtor, -Wredundant-move.
4724
4725 2019-05-29  Tom Tromey  <tromey@adacore.com>
4726
4727         * NEWS: Add entry.
4728         * infcmd.c (print_return_value_1): Handle finish_print
4729         option.
4730         (show_print_finish): New function.
4731         (_initialize_infcmd): Add "set/show print finish" commands.
4732         * valprint.c (user_print_options): Initialize new member.
4733         * valprint.h (struct value_print_options) <finish_print>: New
4734         member.
4735
4736 2019-05-28  Tom Tromey  <tromey@adacore.com>
4737
4738         * ada-lang.c (ada_remove_Xbn_suffix)
4739         (find_old_style_renaming_symbol)
4740         (parse_old_style_renaming): Remove.
4741         (ada_find_renaming_symbol): Don't call
4742         find_old_style_renaming_symbol.
4743         (ada_is_renaming_symbol): Rename from
4744         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4745         bool.  Now static.
4746         (ada_read_var_value): Update and simplify.
4747         * ada-exp.y (write_var_or_type): Remove old code.
4748
4749 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4750
4751         * event-top.c: Remove include comment.
4752         * inflow.c (class scoped_ignore_sigttou): Move from here...
4753         * inflow.h (class scoped_ignore_sigttou): ...to here.
4754         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4755         * top.c:  Remove include comment.
4756
4757 2019-05-27  Tom Tromey  <tom@tromey.com>
4758
4759         * NEWS: Fix typo.
4760
4761 2019-05-22  Tom Tromey  <tromey@adacore.com>
4762
4763         * target.c (target_follow_exec): Constify parameter.
4764         * target-delegates.c: Rebuild.
4765         * remote.c (remote_target::follow_exec): Constify parameter.
4766         * infrun.c (follow_exec): Constify parameter.
4767         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4768         (target_follow_exec): Likewise.
4769
4770 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4771
4772         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4773         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4774
4775 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4776
4777         * NEWS: Add debugredirect and testsuite sections.
4778
4779 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4780
4781         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4782         target descriptions using exclusively floating point register name
4783         aliases.
4784
4785 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4786
4787         PR gdb/18644:
4788         * f-lang.c (build_fortran_types): Handle the case where
4789         gdbarch_floatformat_for_type returns a nullptr.
4790
4791 2019-05-21  Tom de Vries  <tdevries@suse.de>
4792
4793         PR cli/24587
4794         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4795
4796 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4797
4798         PR gdb/18644:
4799         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4800         16-byte floats.
4801         * i386-tdep.c (i386_floatformat_for_type): Use
4802         floatformats_ia64_quad for the 16-byte floating point component
4803         within a fortran 32-byte complex number.
4804
4805 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4806
4807         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4808         delete default constructor.
4809         (find_partial_die): Update to return const struct.
4810         (partial_die_parent_scope): Move variable declaration into scope
4811         of its use and change its type to auto.
4812         (guess_partial_die_structure_name): Likewise.
4813         (partial_die_info::fixup): Likewise.
4814
4815 2019-05-17  Tom Tromey  <tromey@adacore.com>
4816
4817         * source.c (find_and_open_source): Remove cast.
4818
4819 2019-05-17  Tom Tromey  <tromey@adacore.com>
4820
4821         * annotate.c (annotate_source): Make "filename" const.
4822         * annotate.h (annotate_source): Use const.
4823
4824 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4825
4826         * disasm.c (set_disassembler_options): Send errors to stderr.
4827
4828 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4829
4830         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4831         (cli_interp_base::set_logging): Check debug_redirect.
4832         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4833         * cli/cli-logging.c (debug_redirect): Add static variable.
4834         (pop_output_files): Add default param.
4835         (handle_redirections): Print debug setting.
4836         (show_logging_command): Likewise.
4837         (_initialize_cli_logging): Add debugredirect command.
4838         * interps.c (current_interp_set_logging): Add debug_redirect
4839         parameter.
4840         * interps.h (set_logging): Add debug_redirect parameter.
4841         (current_interp_set_logging): Likewise.
4842         * mi/mi-common.h: Likewise.
4843         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4844
4845 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4846             Tom Tromey  <tromey@adacore.com>
4847
4848         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4849         directly.
4850         * cli/cli-interp.h (make_logging_output): Remove declaration.
4851         * cli/cli-logging.c (make_logging_output): Remove function.
4852         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4853         directly.
4854         * ui-file.c (tee_file::tee_file): Remove bools.
4855         (tee_file::~tee_file): Remove deletes.
4856         * ui-file.h (tee_file): Remove bools.
4857
4858 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4859
4860         * mi/mi-cmds.h (mi_cmd_complete): New function.
4861         * mi/mi-main.c (mi_cmd_complete): Likewise.
4862         * mi/mi-cmds.c: Define new MI command -complete.
4863         * NEWS: Mention new -complete command.
4864
4865 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4866
4867         * completer.h (complete): New function.
4868         * completer.c (complete): Likewise.
4869         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4870         function defined in completer.h.
4871
4872 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4873
4874         * MAINTAINERS (Write After Approval): Add myself.
4875
4876 2019-05-17  Tom de Vries  <tdevries@suse.de>
4877
4878         PR gdb/24094
4879         * dwarf2read.c (struct cu_partial_die_info): New struct.
4880         (find_partial_die): Return cu_partial_die_info.
4881         (partial_die_parent_scope, guess_partial_die_structure_name)
4882         (partial_die_info::fixup): Handle new return type of find_partial_die.
4883
4884 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4885
4886         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4887         "std::string", simplifying the algorithm.
4888
4889 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4890
4891         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4892         (stap_static_probe_ops::get_probes): Likewise.
4893
4894 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4895
4896         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4897         '-')" and "else if".
4898         (stap_parse_single_operand): Join checks for
4899         "gdbarch_stap_parse_special_token_p" and
4900         "gdbarch_stap_parse_special_token" in the same "if" statement.
4901         Invert check when verifying for operation on register
4902         displacement.
4903
4904 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4905
4906         * stap-probe.c (stap_get_opcode): Update comment.
4907         (stap_get_expected_argument_type): Likewise.
4908         (handle_stap_probe): Likewise.
4909
4910 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4911
4912         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4913         return type to 'bool'.  Adjust comment.  Use 'bool' when
4914         appropriate.
4915         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4916         * stap-probe.c (stap_parse_argument_1): Likewise.
4917         (stap_is_operator): Likewise.
4918         (stap_is_generic_prefix): Likewise.
4919         (stap_is_register_prefix): Likewise.
4920         (stap_is_register_indirection_prefix): Likewise.
4921         (stap_is_integer_prefix): Likewise.
4922         (stap_generic_check_suffix): Likewise.
4923         (stap_check_integer_suffix): Likewise.
4924         (stap_check_register_suffix): Likewise.
4925         (stap_check_register_indirection_suffix): Likewise.
4926         (stap_parse_register_operand): Likewise.
4927         (stap_parse_single_operand): Likewise.
4928         (stap_parse_argument_1): Likewise.
4929         (stap_probe::get_argument_count): Likewise.
4930         (stap_is_operator): Likewise.
4931
4932 2019-05-16  Tom Tromey  <tromey@adacore.com>
4933
4934         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4935         keyword to foreach.
4936
4937 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4938
4939         * linux-thread-db.c (try_thread_db_load_1): Change return type
4940         to bool.
4941         (try_thread_db_load): Likewise.
4942         (try_thread_db_load_from_pdir_1): Likewise.
4943         (try_thread_db_load_from_pdir): Likewise.
4944         (try_thread_db_load_from_sdir): Likewise.
4945         (try_thread_db_load_from_dir): Likewise.
4946         (thread_db_load_search): Likewise.
4947         (has_libpthread): Likewise.
4948         (thread_db_load): Likewise.
4949
4950 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4951
4952         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4953         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4954         NULL, and complain/return if that's the case.
4955
4956 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4957
4958         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4959         (advance, posn, abstract_read_memory): New functions.
4960         [struct mem_read_abstraction]: New struct.
4961         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4962
4963 2019-05-14  Tom Tromey  <tromey@adacore.com>
4964
4965         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4966         value is not lval_memory.
4967
4968 2019-05-14  Tom Tromey  <tromey@adacore.com>
4969
4970         * solib.c (info_sharedlibrary_command): Style the file name.
4971
4972 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4973
4974         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4975         (aarch64_vnv_type): Likewise.
4976         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4977         * common/tdesc.c: Likewise.
4978         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4979         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4980         * features/aarch64-fpu.xml: Add ieee half view.
4981         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4982         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4983         * gdbtypes.h (struct builtin_type): Likewise.
4984         (struct objfile_type): Likewise.
4985
4986 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4987
4988         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4989         typo.
4990         * location.h (string_to_event_location): Likewise.
4991
4992 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4993
4994         GDB 8.3 released.
4995
4996 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4997
4998         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4999         New variable declaration.
5000         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5001         New variable.
5002         (print_one_breakpoint): Use ui_out::test_flags and new global
5003         variable to compute use_fixed_output.
5004         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5005         Remove.
5006         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5007         (mi_multi_location_breakpoint_output_fixed): Remove.
5008         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5009         new variable.
5010         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5011         fix_multi_location_breakpoint_output flag if version >= 3.
5012         * ui-out.h (enum ui_out_flag)
5013         <fix_multi_location_breakpoint_output>: New enumerator.
5014
5015 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5016
5017         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5018
5019 2019-05-10  Tom Tromey  <tromey@adacore.com>
5020
5021         * ada-lang.c (catch_ada_completer): New function.
5022         (_initialize_ada_language): Use it.
5023
5024 2019-05-10  Tom Tromey  <tromey@adacore.com>
5025
5026         * thread.c (print_thread_info): Make "requested_threads" const.
5027         * gdbthread.h (print_thread_info): Make "requested_threads"
5028         const.
5029         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5030         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5031
5032 2019-05-08  Tom Tromey  <tom@tromey.com>
5033
5034         * gdbtypes.c (objfile_type_data): Change type.
5035         (objfile_type, _initialize_gdbtypes): Update.
5036
5037 2019-05-08  Tom Tromey  <tom@tromey.com>
5038
5039         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5040         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5041         (_initialize_dwarf2_frame): Update.
5042
5043 2019-05-08  Tom Tromey  <tom@tromey.com>
5044
5045         * objc-lang.c (objc_objfile_data): Change type.
5046         (find_methods): Update.
5047         (_initialize_objc_lang): Remove.
5048
5049 2019-05-08  Tom Tromey  <tom@tromey.com>
5050
5051         * stabsread.c (rs6000_builtin_type_data): Change type.
5052         (rs6000_builtin_type, _initialize_stabsread): Update.
5053
5054 2019-05-08  Tom Tromey  <tom@tromey.com>
5055
5056         * mips-tdep.c (mips_pdr_data): Remove.
5057         (_initialize_mips_tdep): Update.
5058
5059 2019-05-08  Tom Tromey  <tom@tromey.com>
5060
5061         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5062         (hppa_init_objfile_priv_data, read_unwind_info)
5063         (find_unwind_entry, _initialize_hppa_tdep): Update.
5064
5065 2019-05-08  Tom Tromey  <tom@tromey.com>
5066
5067         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5068         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5069         on obstack.
5070         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5071
5072 2019-05-08  Tom Tromey  <tom@tromey.com>
5073
5074         * mdebugread.c (basic_type_data): Change type.
5075         (basic_type, _initialize_mdebugread): Update.
5076
5077 2019-05-08  Tom Tromey  <tom@tromey.com>
5078
5079         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5080
5081 2019-05-08  Tom Tromey  <tom@tromey.com>
5082
5083         * nto-tdep.c (nto_inferior_data_reg): Change type.
5084         (nto_inferior_data): Update.
5085         (nto_inferior_data_cleanup, nto_new_inferior_data)
5086         (_initialize_nto_tdep): Remove.
5087         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5088
5089 2019-05-08  Tom Tromey  <tom@tromey.com>
5090
5091         * ada-lang.c (struct ada_inferior_data): Add initializers.
5092         (ada_inferior_data): Change type.
5093         (ada_inferior_data_cleanup): Remove.
5094         (get_ada_inferior_data, ada_inferior_exit)
5095         (struct ada_pspace_data): Add initializers, destructor.
5096         (ada_pspace_data_handle): Change type.
5097         (get_ada_pspace_data): Update.
5098         (ada_pspace_data_cleanup): Remove.
5099
5100 2019-05-08  Tom Tromey  <tom@tromey.com>
5101
5102         * coffread.c (struct coff_symfile_info): Add initializers.
5103         (coff_objfile_data_key): Move lower.  Change type.
5104         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5105         Update.
5106         (coff_free_info): Remove.
5107
5108 2019-05-08  Tom Tromey  <tom@tromey.com>
5109
5110         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5111         (fbsd_pspace_data_handle): Move lower.  Change type.
5112         (get_fbsd_pspace_data): Update.
5113         (fbsd_pspace_data_cleanup): Remove.
5114         (_initialize_fbsd_tdep): Update.
5115
5116 2019-05-08  Tom Tromey  <tom@tromey.com>
5117
5118         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5119         (get_ada_tasks_pspace_data): Update.
5120         (ada_tasks_pspace_data_cleanup): Remove.
5121         (_initialize_tasks): Update.
5122         (ada_tasks_inferior_data_handle): Change type.
5123         (get_ada_tasks_inferior_data): Update.
5124         (ada_tasks_inferior_data_cleanup): Remove.
5125         (struct ada_tasks_pspace_data): Add initializers.
5126
5127 2019-05-08  Tom Tromey  <tom@tromey.com>
5128
5129         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5130         * symfile-debug.c (debug_sym_get_probes): Change type.
5131         * stap-probe.c (handle_stap_probe):
5132         (stap_static_probe_ops::get_probes): Change type.
5133         * probe.h (class static_probe_ops) <get_probes>: Change type.
5134         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5135         (parse_probes_in_pspace): Update.
5136         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5137         Update.
5138         (any_static_probe_ops::get_probes): Change type.
5139         * elfread.c (elfread_data): New typedef.
5140         (probe_key): Change type.
5141         (elf_get_probes): Likewise.  Update.
5142         (probe_key_free): Remove.
5143         (_initialize_elfread): Update.
5144         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5145         Change type.
5146         (dtrace_process_dof_probe, dtrace_process_dof)
5147         (dtrace_static_probe_ops::get_probe): Change type.
5148
5149 2019-05-08  Tom Tromey  <tom@tromey.com>
5150
5151         * xcoffread.c (struct xcoff_symfile_info): Rename from
5152         coff_symfile_info.  Add initializers.
5153         (xcoff_objfile_data_key): Move lower.  Change type.
5154         (XCOFF_DATA): Rewrite.
5155         (xcoff_free_info): Remove.
5156         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5157         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5158         (xcoff_initial_scan): Update.
5159
5160 2019-05-08  Tom Tromey  <tom@tromey.com>
5161
5162         * solib-svr4.c (struct svr4_info): Add initializers and
5163         destructor.
5164         <probes_table>: Now an htab_up.
5165         (solib_svr4_pspace_data): Change type.
5166         (free_probes_table): Simplify.
5167         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5168         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5169         (probes_table_remove_objfile_probes, register_solib_event_probe)
5170         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5171         (_initialize_svr4_solib): Update.
5172
5173 2019-05-08  Tom Tromey  <tom@tromey.com>
5174
5175         * remote.c (remote_pspace_data): Change type.
5176         (remote_pspace_data_cleanup): Remove.
5177         (get_remote_exec_file, set_pspace_remote_exec_file)
5178         (_initialize_remote): Update.
5179
5180 2019-05-08  Tom Tromey  <tom@tromey.com>
5181
5182         * breakpoint.c (breakpoint_objfile_key): Change type.
5183         (get_breakpoint_objfile_data): Update.
5184         (free_breakpoint_objfile_data): Remove.
5185         (_initialize_breakpoint): Update.
5186
5187 2019-05-08  Tom Tromey  <tom@tromey.com>
5188
5189         * linux-tdep.c (struct linux_info): Add initializers.
5190         (linux_inferior_data): Move.  Change type.
5191         (invalidate_linux_cache_inf): Update.
5192         (linux_inferior_data_cleanup): Remove.
5193         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5194
5195 2019-05-08  Tom Tromey  <tom@tromey.com>
5196
5197         * auxv.c (auxv_inferior_data): Move.  Change type.
5198         (auxv_inferior_data_cleanup): Remove.
5199         (invalidate_auxv_cache_inf): Rewrite.
5200         (get_auxv_inferior_data, _initialize_auxv): Update.
5201
5202 2019-05-08  Tom Tromey  <tom@tromey.com>
5203
5204         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5205         (symfile_debug_objfile_data_key): Change type.
5206         (symfile_debug_installed, debug_qf_has_symbols)
5207         (debug_qf_find_last_source_symtab)
5208         (debug_qf_forget_cached_source_info)
5209         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5210         (debug_qf_print_stats, debug_qf_dump)
5211         (debug_qf_expand_symtabs_for_function)
5212         (debug_qf_expand_all_symtabs)
5213         (debug_qf_expand_symtabs_with_fullname)
5214         (debug_qf_map_matching_symbols)
5215         (debug_qf_expand_symtabs_matching)
5216         (debug_qf_find_pc_sect_compunit_symtab)
5217         (debug_qf_map_symbol_filenames)
5218         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5219         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5220         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5221         (debug_sym_read_linetable, debug_sym_relocate): Update.
5222         (symfile_debug_free_objfile): Remove.
5223         (install_symfile_debug_logging, _initialize_symfile_debug):
5224         Update.
5225
5226 2019-05-08  Tom Tromey  <tom@tromey.com>
5227
5228         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5229         allocate_on_obstack.
5230         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5231         (get_dwarf2_per_objfile): Update.
5232         (set_dwarf2_per_objfile): Remove.
5233         (dwarf2_has_info, dwarf2_get_section_info): Update.
5234         (dwarf2_free_objfile): Remove.
5235         (_initialize_dwarf2_read): Update.
5236
5237 2019-05-08  Tom Tromey  <tom@tromey.com>
5238
5239         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5240         initializers.
5241         <unsupported_script_warning_printed,
5242         script_not_found_warning_printed>: Now bool.
5243         (auto_load_pspace_data): Change type.
5244         (~auto_load_pspace_info): Rename from
5245         auto_load_pspace_data_cleanup.
5246         (get_auto_load_pspace_data, init_loaded_scripts_info)
5247         (clear_section_scripts, maybe_print_unsupported_script_warning)
5248         (maybe_print_script_not_found_warning, _initialize_auto_load):
5249         Update.
5250
5251 2019-05-08  Tom Tromey  <tom@tromey.com>
5252
5253         * objfiles.c (objfile_pspace_info): Add destructor and
5254         initializers.
5255         (objfiles_pspace_data): Change type.
5256         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5257         (get_objfile_pspace_data): Update.
5258         (objfiles_bfd_data): Change type.
5259         (get_objfile_bfd_data): Update.
5260         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5261
5262 2019-05-08  Tom Tromey  <tom@tromey.com>
5263
5264         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5265         Change type.
5266         (get_catch_syscall_inferior_data): Update.
5267         (catch_syscall_inferior_data_cleanup): Remove.
5268         (_initialize_break_catch_syscall): Update.
5269
5270 2019-05-08  Tom Tromey  <tom@tromey.com>
5271
5272         * inflow.c (struct terminal_info): Add destructor and
5273         initializers.
5274         (inflow_inferior_data): Change type.
5275         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5276         (get_inflow_inferior_data, inflow_inferior_exit)
5277         (swap_terminal_info, _initialize_inflow): Update.
5278
5279 2019-05-08  Tom Tromey  <tom@tromey.com>
5280
5281         * target-dcache.c (target_dcache_cleanup): Remove.
5282         (target_dcache_aspace_key): Change type.
5283         (target_dcache_init_p, target_dcache_invalidate)
5284         (target_dcache_get, target_dcache_get_or_init)
5285         (_initialize_target_dcache): Update.
5286         * dcache.h (struct dcache_deleter): New.
5287
5288 2019-05-08  Tom Tromey  <tom@tromey.com>
5289
5290         * symtab.c (struct symbol_cache): Add destructor and
5291         initializers.
5292         (symbol_cache_key): Move.  Change type.
5293         (make_symbol_cache, free_symbol_cache): Remove.
5294         (get_symbol_cache): Update.
5295         (symbol_cache_cleanup): Remove.
5296         (ALL_PSPACES, symbol_cache_flush)
5297         (maintenance_print_symbol_cache)
5298         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5299         Update.
5300
5301 2019-05-08  Tom Tromey  <tom@tromey.com>
5302
5303         * symtab.c (struct main_info): Add destructor and initializers.
5304         (main_progspace_key): Move.  Change type.
5305         (get_main_info): Update.
5306         (main_info_cleanup): Remove.
5307         (_initialize_symtab): Update.
5308
5309 2019-05-08  Tom Tromey  <tom@tromey.com>
5310
5311         * registry.h (DECLARE_REGISTRY): Define the _key class.
5312
5313 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5314
5315         * NEWS: Merge two 'New commands' sections.
5316
5317 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5318
5319         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5320         parameter and use Ada language definition instead.
5321         (ada_val_print_ptr): Remove unused language parameter.
5322         (ada_val_print_num): Remove language parameter and use Ada language
5323         definition instead.
5324         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5325         parameter.
5326         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5327         parameter and use Ada language definition instead.
5328         (ada_val_print_1): Update all ada_val_print_xxx calls.
5329         Remove language parameter.
5330         (ada_val_print): Update ada_val_print_1 call.
5331
5332 2019-05-08  Tom Tromey  <tromey@adacore.com>
5333
5334         * remote.c (remote_hw_watchpoint_limit)
5335         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5336         Now static.
5337
5338 2019-05-08  Tom Tromey  <tromey@adacore.com>
5339
5340         * maint.c (_initialize_maint_cmds): Move initialization code to
5341         remote.c.
5342         (watchdog, show_watchdog): Move to remote.c.
5343         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5344         "watchdog" static.
5345         (_initialize_remote): Move initialization code from maint.c.
5346         * defs.h (watchdog): Don't declare.
5347
5348 2019-05-08  Tom Tromey  <tromey@adacore.com>
5349
5350         * tui/tui-interp.c: Include main.h.
5351         * interps.c: Include main.h.
5352         * main.h (interpreter_p): Declare.
5353         * defs.h (interpreter_p): Don't declare.
5354
5355 2019-05-08  Tom Tromey  <tromey@adacore.com>
5356
5357         * dwarf2loc.c: Include dwarf2read.h.
5358         * defs.h (read_unsigned_leb128): Don't declare.
5359         * dwarf2read.h (read_unsigned_leb128): Declare.
5360
5361 2019-05-08  Tom Tromey  <tromey@adacore.com>
5362
5363         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5364         method.
5365
5366 2019-05-08  Tom Tromey  <tromey@adacore.com>
5367
5368         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5369         when no wrap column is set.
5370
5371 2019-05-08  Tom Tromey  <tromey@adacore.com>
5372
5373         * c-lang.c (c_get_string): Handle non-C-style arrays.
5374
5375 2019-05-08  Tom Tromey  <tromey@adacore.com>
5376
5377         * typeprint.c (print_offset_data::update): Print the bit offset,
5378         not the number of bits remaining.
5379
5380 2019-05-08  Tom Tromey  <tromey@adacore.com>
5381
5382         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5383         padding at end of comment.
5384
5385 2019-05-08  Tom Tromey  <tromey@adacore.com>
5386
5387         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5388         Compare main types.
5389
5390 2019-05-06  Tom Tromey  <tom@tromey.com>
5391
5392         * common/scoped_mmap.c: Include common-defs.h.
5393         * common/scoped_mmap.h: Don't include config.h.
5394
5395 2019-05-04  Tom Tromey  <tom@tromey.com>
5396
5397         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5398         (struct aarch64_call_info): Add initializers.
5399         <si>: Now a std::vector.
5400         (pass_on_stack, aarch64_push_dummy_call): Update.
5401
5402 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5403             Tom Tromey  <tom@tromey.com>
5404
5405         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5406         (ppc_threads): Now a std::vector.  Now static.
5407         (hwdebug_find_thread_points_by_tid)
5408         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5409         Update.
5410
5411 2019-05-04  Tom Tromey  <tom@tromey.com>
5412
5413         * arc-tdep.c (arc_tdesc_init): Return bool.
5414
5415 2019-05-04  Tom Tromey  <tom@tromey.com>
5416
5417         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5418         Use gdb_assert_not_reached.
5419
5420 2019-05-04  Tom Tromey  <tom@tromey.com>
5421
5422         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5423         "false".
5424
5425 2019-05-04  Tom Tromey  <tom@tromey.com>
5426
5427         * arc-tdep.c (arc_tdesc_init): Use bool.
5428
5429 2019-05-04  Tom Tromey  <tom@tromey.com>
5430
5431         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5432
5433 2019-05-04  Tom Tromey  <tom@tromey.com>
5434
5435         * cli/cli-cmds.c (valid_command_p): Return bool.
5436
5437 2019-05-04  Tom Tromey  <tom@tromey.com>
5438
5439         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5440         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5441
5442 2019-05-04  Raul Tambre  <raul@tambre.ee>
5443
5444         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5445         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5446         operator for comparison.
5447
5448 2019-05-04  Tom Tromey  <tom@tromey.com>
5449
5450         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5451         (lookup_partial_symbol, print_partial_symbols)
5452         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5453         (psymbol_compare): Update.
5454         (add_psymbol_to_bcache): Clear the entire psymbol.
5455         (maintenance_check_psymtabs): Update.
5456         * psympriv.h (struct partial_symbol): Don't derive from
5457         general_symbol_info.
5458         <obj_section, unrelocated_address, address,
5459         set_unrelocated_address>: Update.
5460         <ginfo>: New member.
5461         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5462         (debug_names::write_psymbols): Update.
5463
5464 2019-05-04  Tom de Vries  <tdevries@suse.de>
5465
5466         * contrib/cc-with-tweaks.sh: Support -n arg.
5467
5468 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5469
5470         * corelow.c (core_target::detach): Ensure frame cache and
5471         register caches are cleared.
5472         inferior.c (exit_inferior_1): Likewise.
5473
5474 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5475             Tom Tromey  <tom@tromey.com>
5476
5477         * dictionary.c (collate_pending_symbols_by_language): Remove
5478         "struct" from foreach.
5479         * symtab.c (lookup_global_symbol_from_objfile)
5480         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5481         foreach.
5482         * ser-tcp.c (net_open): Remove "struct" from foreach.
5483         * objfiles.c (objfile_relocate, objfile_rebase)
5484         (objfile_has_symbols): Remove "struct" from foreach.
5485         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5486         from foreach.
5487         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5488         foreach.
5489         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5490         "struct" from foreach.
5491         * ada-lang.c (create_excep_cond_exprs)
5492         (ada_exception_catchpoint_cond_string): Remove "struct" from
5493         foreach.
5494
5495 2019-05-03  Tom Tromey  <tromey@adacore.com>
5496
5497         * ada-exp.y (convert_char_literal): Check suffix of each
5498         enumerator.
5499
5500 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5501
5502         PR ada/21406:
5503         * ada-exp.y (yywrap): Don't define.
5504         * ada-lex.l (%option): Add noyywrap
5505         (yywrap): Remove.
5506
5507 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5508
5509         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5510         _WIN32_WINNT to the XP level, unless already defined to a higher
5511         level.
5512
5513         * unittests/parse-connection-spec-selftests.c:
5514         * ser-tcp.c:
5515         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5516         override.
5517
5518         * symfile.c (find_separate_debug_file): Remove colon from the
5519         drive spec of DOS/Windows file names of the target, so that the
5520         file name produced from DEBUGDIR and the target's directory will
5521         be valid on DOS/Windows systems.
5522
5523 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5524
5525         * rust-lang.c (val_print_struct): Handle printing structures
5526         containing strings.
5527
5528 2019-05-02  Tom Tromey  <tromey@adacore.com>
5529
5530         * valarith.c (_initialize_valarith): Remove.
5531
5532 2019-05-01  Tom Tromey  <tromey@adacore.com>
5533
5534         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5535         bitfields.
5536
5537 2019-05-01  Tom Tromey  <tromey@adacore.com>
5538
5539         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5540         for big-endian copies.
5541
5542 2019-04-30  Ali Tamur  <tamur@google.com>
5543         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5544         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5545         (read_3_bytes): New function.
5546
5547 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5548
5549         * windows-nat.c (main_thread_id): Delete.
5550         (handle_output_debug_string): Replace main_thread_id by
5551         current_event.dwThreadId.
5552         (fake_create_process): Likewise.
5553         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5554         Do not set main_thread_id.
5555         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5556         current_event.dwThreadId.
5557         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5558
5559 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5560
5561         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5562         Use current_event.dwThreadId instead of main_thread_id.
5563
5564 2019-04-30  Tom Tromey  <tromey@adacore.com>
5565
5566         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5567         (create_excep_cond_exprs): Iterate over program spaces.
5568         (ada_exception_catchpoint_cond_string): Examine all minimal
5569         symbols for exception types.
5570
5571 2019-04-30  Tom Tromey  <tromey@adacore.com>
5572
5573         PR c++/24470:
5574         * dwarf2read.c (process_structure_scope): Handle case where type
5575         has template parameters but no symbol was created.
5576
5577 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5578             Chris January  <chris.january@arm.com>
5579
5580         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5581         qualifier.
5582         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5583
5584 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5585
5586         * f-typeprint.c (f_print_type): Update rules for printing
5587         whitespace.
5588         (f_type_print_varspec_suffix): Likewise.
5589
5590 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5591             Chris January  <chris.january@arm.com>
5592
5593         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5594         function arguments.
5595
5596 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5597
5598         * f-lang.c (build_fortran_types): Change name of void type to
5599         lower case.
5600         * f-typeprint.c (f_type_print_base): Print the name of the void
5601         type, rather than a fixed string.
5602         * f-valprint.c (f_decorations): Use lower case void string.
5603
5604 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5605             Chris January  <chris.january@arm.com>
5606
5607         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5608         types for Fortran.
5609
5610 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5611             Chris January  <chris.january@arm.com>
5612             David Lecomber  <david.lecomber@arm.com>
5613
5614         * f-exp.y (BINOP_INTRINSIC): New token.
5615         (exp): New parser rule handling BINOP_INTRINSIC.
5616         (f77_keywords): Add new builtin procedures.
5617         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5618         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5619         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5620         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5621         (print_unop_subexp_f): New function.
5622         (print_binop_subexp_f): New function.
5623         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5624         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5625         (dump_subexp_body_f): Likewise.
5626         (operator_check_f): Likewise.
5627         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5628         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5629
5630 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5631
5632         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5633         UNOP_KIND.
5634         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5635         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5636         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5637         (operator_length_f): New fuction.
5638         (print_subexp_f): New function.
5639         (op_name_f): New function.
5640         (dump_subexp_body_f): New function.
5641         (operator_check_f): New function.
5642         (exp_descriptor_f): Replace standard expression handling functions
5643         with new functions.
5644         * gdb/fortran-operator.def: New file.
5645         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5646         * gdb/std-operator.def: Remove UNOP_KIND.
5647
5648 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5649
5650         * std-operator.def: Remove unbalanced, stray double quote
5651         character.
5652
5653 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5654             Chris January  <chris.january@arm.com>
5655             Daniel Everett  <daniel.everett@arm.com>
5656             Nick Forrington  <nick.forrington@arm.com>
5657             Richard Bunt  <richard.bunt@arm.com>
5658
5659         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5660         of depth when printing anonymous structs or unions.
5661         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5662         Don't print either the top-level value, or the children if the
5663         max-depth is exceeded.
5664         (ppscm_print_children): When printing the key of a map, allow one
5665         extra level of depth.
5666         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5667         print either the top-level value, or the children if the max-depth
5668         is exceeded.
5669         (print_children): When printing the key of a map, allow one extra
5670         level of depth.
5671         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5672         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5673         (user_print_options): Initialise max_depth field.
5674         (val_print_scalar_or_string_type_p): New function.
5675         (val_print): Check to see if the max depth has been reached.
5676         (val_print_check_max_depth): Define new function.
5677         (show_print_max_depth): New function.
5678         (_initialize_valprint): Add 'print max-depth' option.
5679         * valprint.h (struct value_print_options) <max_depth>: New field.
5680         (val_print_check_max_depth): Declare new function.
5681         * NEWS: Document new feature.
5682
5683 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5684
5685         * ada-lang.c (ada_language_defn): Initialise new field.
5686         * c-lang.c (c_is_string_type_p): New function.
5687         (c_language_defn): Initialise new field.
5688         (cplus_language_defn): Initialise new field.
5689         (asm_language_defn): Initialise new field.
5690         (minimal_language_defn): Initialise new field.
5691         * c-lang.h (c_is_string_type_p): Declare new function.
5692         * d-lang.c (d_language_defn): Initialise new field.
5693         * f-lang.c (f_is_string_type_p): New function.
5694         (f_language_defn): Initialise new field.
5695         * go-lang.c (go_is_string_type_p): New function.
5696         (go_language_defn): Initialise new field.
5697         * language.c (default_is_string_type_p): New function.
5698         (unknown_language_defn): Initialise new field.
5699         (auto_language_defn): Initialise new field.
5700         * language.h (struct language_defn) <la_is_string_type_p>: New
5701         member variable.
5702         (default_is_string_type_p): Declare new function.
5703         * m2-lang.c (m2_language_defn): Initialise new field.
5704         * objc-lang.c (objc_language_defn): Initialise new field.
5705         * opencl-lang.c (opencl_language_defn): Initialise new field.
5706         * p-lang.c (pascal_is_string_type_p): New function.
5707         (pascal_language_defn): Initialise new field.
5708         * rust-lang.c (rust_is_string_type_p): New function.
5709         (rust_language_defn): Initialise new field.
5710
5711 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5712
5713         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5714         New field.
5715         * ada-lang.c (ada_language_defn): Initialise new field.
5716         * c-lang.c (c_language_defn): Likewise.
5717         (cplus_language_defn): Likewise.
5718         (asm_language_defn): Likewise.
5719         (minimal_language_defn): Likewise.
5720         * d-lang.c (d_language_defn): Likewise.
5721         * f-lang.c (f_language_defn): Likewise.
5722         * go-lang.c (go_language_defn): Likewise.
5723         * language.c (unknown_language_defn): Likewise.
5724         (auto_language_defn): Likewise.
5725         * m2-lang.c (m2_language_defn): Likewise.
5726         * objc-lang.c (objc_language_defn): Likewise.
5727         * opencl-lang.c (opencl_language_defn): Likewise.
5728         * p-lang.c (pascal_language_defn): Likewise.
5729         * rust-lang.c (rust_language_defn): Likewise.
5730
5731 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5732
5733         * ada-lang.c (ada_is_character_type): Change return type to bool.
5734         (ada_is_string_type): Likewise.
5735         * ada-lang.h (ada_is_character_type): Update declaration
5736         (ada_is_string_type): Likewise.
5737
5738 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5739
5740         Support style in 'frame|thread apply'
5741
5742         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5743         * record.c (record_start, record_stop): Update callers of
5744         execute_command_to_string with false.
5745         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5746         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5747         methods.
5748         (class string_file): New constructor with term_out parameter.
5749         Override methods term_out and can_emit_style_escape.  New member
5750         term_out.
5751         (class stdio_file): Override can_emit_style_escape.
5752         (class tee_file): Override term_out and can_emit_style_escape.
5753         * utils.h (can_emit_style_escape): Remove.
5754         * utils.c (can_emit_style_escape): Likewise.
5755         Update all callers of can_emit_style_escape (SOMESTREAM) to
5756         SOMESTREAM->can_emit_style_escape.
5757         * source-cache.c (source_cache::get_source_lines): Likewise.
5758         * stack.c (frame_apply_command_count): Call execute_command_to_string
5759         passing the term_out characteristic of the current gdb_stdout.
5760         * thread.c (thr_try_catch_cmd): Likewise.
5761         * top.c (execute_command_to_string): pass term_out parameter
5762         to construct the string_file for the command output.
5763         * ui-file.c (term_cli_styling): New function (most code moved
5764         from utils.c can_emit_style_escape).
5765         (string_file::string_file, string_file::can_emit_style_escape,
5766         stdio_file::can_emit_style_escape, tee_file::term_out,
5767         tee_file::can_emit_style_escape): New functions.
5768
5769 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5770
5771         * NEWS: Mention the new set|show may-call-functions.
5772         * infcall.c (may_call_functions_p): New variable.
5773         (show_may_call_functions_p): New function.
5774         (call_function_by_hand_dummy): Throws an error if not
5775         may-call-functions.
5776         (_initialize_infcall): Call add_setshow_boolean_cmd for
5777         may-call-functions.
5778
5779 2019-04-25  Keith Seitz  <keiths@redhat.com>
5780
5781         PR c++/24367
5782         * cp-support.c (inspect_type): Don't attempt substitutions
5783         of symbol with the same name.
5784
5785 2019-04-25  Tom Tromey  <tromey@adacore.com>
5786
5787         PR gdb/24475:
5788         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5789         static.
5790
5791 2019-04-25  Tom Tromey  <tromey@adacore.com>
5792
5793         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5794         rvalue reference.
5795         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5796         (gdb_xml_parser::parse): Use std::move.
5797         * python/python-internal.h (gdbpy_convert_exception): Take a const
5798         reference.
5799         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5800         std::move.
5801         * python/py-utils.c (gdbpy_convert_exception): Take a const
5802         reference.
5803         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5804         Use std::move.
5805         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5806         Use std::move.
5807         * mi/mi-main.c (mi_print_exception): Take a const reference.
5808         * main.c (handle_command_errors): Take a const reference.
5809         * linespec.c (parse_linespec): Use std::move.
5810         * infcall.c (run_inferior_call): Use std::move.
5811         (call_function_by_hand_dummy): Use std::move.
5812         * exec.c (try_open_exec_file): Use std::move.
5813         * exceptions.h (exception_print, exception_fprintf)
5814         (exception_print_same): Update.
5815         * exceptions.c (print_exception, exception_print)
5816         (exception_fprintf, exception_print_same): Change parameters to
5817         const reference.
5818         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5819         * common/new-op.c: Use std::move.
5820         * common/common-exceptions.h (struct gdb_exception): Add move
5821         constructor.
5822         (struct gdb_exception_error, struct gdb_exception_quit, struct
5823         gdb_quit_bad_alloc): Change constructor to move constructor.
5824         (throw_exception): Change parameter to rvalue reference.
5825         * common/common-exceptions.c (throw_exception): Take rvalue
5826         reference.
5827         * cli/cli-interp.c (safe_execute_command): Use std::move.
5828         * breakpoint.c (insert_bp_location, location_to_sals): Use
5829         std::move.
5830
5831 2019-04-25  Tom Tromey  <tromey@adacore.com>
5832
5833         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5834         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5835         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5836         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5837         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5838         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5839         guile/scm-value.c: Use unpack.
5840         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5841         gdbscm_gdb_exception.
5842         (gdbscm_throw_gdb_exception): Likewise.
5843         (struct gdbscm_gdb_exception): New.
5844         (unpack): New function.
5845         (gdbscm_wrap): Use unpack.
5846
5847 2019-04-25  Tom Tromey  <tromey@adacore.com>
5848
5849         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5850         (gdb_rl_callback_handler): Use std::move.
5851         * common/common-exceptions.h (struct gdb_exception): Add move
5852         assignment operator.
5853         (throw_exception_sjlj): Change "exception" to const reference.
5854         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5855         (throw_exception_sjlj): Change "exception" to const reference.
5856
5857 2019-04-25  Tom Tromey  <tromey@adacore.com>
5858
5859         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5860         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5861         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5862         Update.
5863         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5864         Update.
5865         * mi/mi-interp.c (mi_interp::exec): Update.
5866         * linespec.c (parse_linespec): Update.
5867         * infcall.c (run_inferior_call): Update.
5868         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5869         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5870         (gdbscm_lookup_global_symbol): Update.
5871         * guile/scm-param.c (gdbscm_parameter_value): Update.
5872         * guile/scm-frame.c (gdbscm_frame_read_register)
5873         (gdbscm_frame_read_var): Update.
5874         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5875         * exec.c (try_open_exec_file): Update.
5876         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5877         (gdb_rl_callback_handler): Update.
5878         * common/common-exceptions.h (exception_none): Don't declare.
5879         * common/common-exceptions.c (exception_none): Don't define.
5880         (struct catcher) <exception>: Update.
5881         * cli/cli-interp.c (safe_execute_command): Update.
5882         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5883
5884 2019-04-25  Ali Tamur  <tamur@google.com>
5885
5886         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5887         (read_attribute_value): Likewise.
5888         (dwarf2_read_addr_index): Update comment.
5889         (read_str_index): Add DW_FORM_strx.
5890         (dwarf2_string_attr): Likewise.
5891         (dwarf2_const_value_attr): Likewise.
5892         (dump_die_shallow): Likewise.
5893         (dwarf2_fetch_constant_bytes): Likewise.
5894         (skip_form_bytes): Likewise.
5895         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5896
5897 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5898
5899         PR corefiles/11608
5900         PR corefiles/18187
5901         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5902         OFFSET.  Verify if current mapping contains an ELF header.
5903         (linux_find_memory_regions_full): Adjust call to
5904         dump_mapping_p.
5905
5906 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5907             Kang Li <kanglictf@gmail.com>
5908
5909         PR gdb/21600
5910
5911         * dwarf2-frame.c (read_initial_length): Be consistent about using
5912         unsigned representation of length.
5913         (decode_frame_entry_1): Likewise.  Check for wraparound of
5914         end pointer as well as buffer overflow.
5915
5916 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5917
5918         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5919         "vq".
5920
5921 2019-04-24  Tom Tromey  <tromey@adacore.com>
5922
5923         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5924
5925 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5926
5927         * s12z-tdep.c (s12z_unwind_pc): Delete.
5928         (s12z_unwind_sp): Delete.
5929         (s12z_gdbarch_init): Don't register deleted functions with
5930         gdbarch.
5931
5932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5933
5934         * rl78-tdep.c (rl78_unwind_sp): Delete.
5935         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5936
5937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5938
5939         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5940         (xstormy16_unwind_pc): Delete.
5941         (xstormy16_dummy_id): Delete.
5942         (xstormy16_gdbarch_init): Don't register deleted functions with
5943         gdbarch.
5944
5945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5946
5947         * vax-tdep.c (vax_unwind_pc): Delete.
5948         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5949
5950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5951
5952         * v850-tdep.c (v850_unwind_sp): Delete.
5953         (v850_unwind_pc): Delete.
5954         (v850_dummy_id): Delete.
5955         (v850_gdbarch_init): Don't register deleted functions with
5956         gdbarch.
5957
5958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5959
5960         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5961         (tilegx_unwind_pc): Delete.
5962         (tilegx_unwind_dummy_id): Delete.
5963         (tilegx_gdbarch_init): Don't register deleted functions with
5964         gdbarch.
5965
5966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5967
5968         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5969         (tic6x_dummy_id): Delete.
5970         (tic6x_gdbarch_init): Don't register deleted functions with
5971         gdbarch.
5972
5973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5974
5975         * sparc-tdep.c (sparc_unwind_pc): Delete.
5976         (sparc32_gdbarch_init): Don't register deleted function with
5977         gdbarch.
5978
5979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5980
5981         * sh-tdep.c (sh_unwind_sp): Delete.
5982         (sh_unwind_pc): Delete.
5983         (sh_dummy_id): Delete.
5984         (sh_gdbarch_init): Don't register deleted functions with
5985         gdbarch.
5986
5987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5988
5989         * score-tdep.c (score_unwind_sp): Delete.
5990         (score_unwind_pc): Delete.
5991         (score_dummy_id): Delete.
5992         (score_gdbarch_init): Don't register deleted functions with
5993         gdbarch.
5994
5995 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5996
5997         * rx-tdep.c (rx_unwind_pc): Delete.
5998         (rx_unwind_sp): Delete.
5999         (rx_dummy_id): Delete.
6000         (rx_gdbarch_init): Don't register deleted functions with
6001         gdbarch.  Update comment.
6002
6003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6004
6005         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6006         (rs6000_dummy_id): Delete.
6007         (rs6000_gdbarch_init): Don't register deleted functions with
6008         gdbarch.
6009
6010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6011
6012         * or1k-tdep.c (or1k_dummy_id): Delete.
6013         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6014
6015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6016
6017         * nios2-tdep.c (nios2_dummy_id): Delete.
6018         (nios2_unwind_sp): Delete.
6019         (nios2_gdbarch_init): Don't register deleted functions with
6020         gdbarch.
6021
6022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6023
6024         * nds32-tdep.c (nds32_dummy_id): Delete.
6025         (nds32_unwind_pc): Delete.
6026         (nds32_unwind_sp): Delete.
6027         (nds32_gdbarch_init): Don't register deleted functions with
6028         gdbarch.
6029
6030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6031
6032         * msp430-tdep.c (msp430_unwind_pc): Delete.
6033         (msp430_unwind_sp): Delete.
6034         (msp430_dummy_id): Delete.
6035         (msp430_gdbarch_init): Don't register deleted functions with
6036         gdbarch.
6037
6038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6039
6040         * moxie-tdep.c (moxie_unwind_sp): Delete.
6041         (moxie_unwind_pc): Delete.
6042         (moxie_dummy_id): Delete.
6043         (moxie_gdbarch_init): Don't register deleted functions with
6044         gdbarch.
6045
6046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6047
6048         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6049         (mn10300_unwind_pc): Delete.
6050         (mn10300_unwind_sp): Delete.
6051         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6052         mn10300_unwind_sp.
6053         (mn10300_frame_unwind_init): Don't register deleted functions with
6054         gdbarch.
6055
6056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6057
6058         * mep-tdep.c (mep_unwind_pc): Delete.
6059         (mep_unwind_sp): Delete.
6060         (mep_dummy_id): Delete.
6061         (mep_gdbarch_init): Don't register deleted functions with
6062         gdbarch.
6063
6064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6065
6066         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6067         (m68hc11_unwind_sp): Delete.
6068         (m68hc11_gdbarch_init): Don't register deleted functions with
6069         gdbarch.
6070
6071 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6072
6073         * m32r-tdep.c (m32r_unwind_sp): Delete.
6074         (m32r_unwind_pc): Delete.
6075         (m32r_dummy_id): Delete.
6076         (m32r_gdbarch_init): Don't register deleted functions with
6077         gdbarch.
6078
6079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6080
6081         * m32c-tdep.c (m32c_unwind_pc): Delete.
6082         (m32c_unwind_sp): Delete.
6083         (m32c_dummy_id): Delete.
6084         (m32c_gdbarch_init): Don't register deleted functions with
6085         gdbarch.
6086
6087 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6088
6089         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6090         (lm32_unwind_pc): Delete.
6091         (lm32_dummy_id): Delete.
6092         (lm32_gdbarch_init): Don't register deleted functions with
6093         gdbarch.
6094
6095 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6096
6097         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6098         (iq2000_unwind_pc): Delete.
6099         (iq2000_dummy_id): Delete.
6100         (iq2000_gdbarch_init): Don't register deleted functions with
6101         gdbarch.
6102
6103 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6104
6105         * nds32-tdep.c (nds32_type_align): Delete.
6106         (nds32_push_dummy_call): Use type_align instead.
6107
6108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * arm-tdep.c (arm_type_align): Only handle vector override case.
6111         (arm_push_dummy_call): Use type_align.
6112         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6113
6114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6115
6116         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6117         case.
6118         (pass_on_stack): Use type_align.
6119         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6120         function.
6121
6122 2019-04-23  Tom Tromey  <tromey@adacore.com>
6123
6124         * dwarf2read.c (line_header::file_name_at): Remove unused
6125         overload.
6126
6127 2019-04-23  Tom de Vries  <tdevries@suse.de>
6128
6129         PR gdb/24438
6130         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6131         invocation.
6132
6133
6134 2019-03-27  Ali Tamur  <tamur@google.com>
6135
6136         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6137         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6138         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6139         (dwarf_expr_context::get_addr_index): Likewise
6140         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6141         (symbol_needs_eval_context::get_addr_index): Likewise
6142         (disassemble_dwarf_expression): Add DW_OP_addrx
6143         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6144         (read_cutu_die_from_dwo): Update comment
6145         (skip_one_die): Add DW_FORM_addrx
6146         (read_attribute_value): Likewise
6147         (var_decode_location): Add DW_OP_addrx
6148         (dwarf2_const_value_attr): Add DW_FORM_addrx
6149         (dump_die_shallow): Likewise
6150         (dwarf2_fetch_constant_bytes): Likewise
6151         (decode_locdesc): Add DW_OP_addrx
6152         (skip_form_bytes): Add DW_FORM_addrx
6153
6154 2019-04-22  Ali Tamur  <tamur@google.com>
6155
6156         * MAINTAINERS (Write After Approval): Add self.
6157
6158 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6159
6160         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6161         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6162         (open_symbol_file_object): Likewise.
6163         (svr4_default_sos): Add info parameter.
6164         (svr4_read_so_list): Likewise.
6165         (svr4_current_sos_direct): Adjust functions calls to pass down
6166         info.
6167         (svr4_current_sos_1): Add info parameter.
6168         (svr4_current_sos): Call get_svr4_info, pass info down to
6169         svr4_current_sos_1.
6170         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6171         get_svr4_info.
6172         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6173         get_svr4_info.
6174         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6175         to get_svr4_info.
6176         (probes_table_remove_objfile_probes): Likewise.
6177         (register_solib_event_probe): Add info parameter.
6178         (solist_update_incremental): Pass info parameter down to
6179         svr4_read_so_list.
6180         (disable_probes_interface): Add info parameter.
6181         (svr4_handle_solib_event): Pass current_program_space to
6182         get_svr4_info.  Adjust disable_probes_interface cleanup.
6183         (svr4_create_probe_breakpoints): Add info parameter, pass it
6184         down to register_solib_event_probe.
6185         (svr4_create_solib_event_breakpoints): Add info parameter,
6186         pass it down to svr4_create_probe_breakpoints.
6187         (enable_break): Pass info down to
6188         svr4_create_solib_event_breakpoints.
6189         (svr4_solib_create_inferior_hook): Pass current_program_space to
6190         get_svr4_info.
6191         (svr4_clear_solib): Likewise.
6192
6193 2019-04-22  Pedro Alves  <palves@redhat.com>
6194
6195         * solib-svr4.c (svr4_free_objfile_observer): New.
6196         (probe_and_action::objfile): New field.
6197         (probes_table_htab_remove_objfile_probes)
6198         (probes_table_remove_objfile_probes): New functions.
6199         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6200         in the new probe_and_action.  Don't store the probe in 'lookup'.
6201         (svr4_create_probe_breakpoints): Pass objfile to
6202         register_solib_event_probe.
6203         (_initialize_svr4_solib): Register a free_objfile observer.
6204
6205 2019-04-19  Tom Tromey  <tom@tromey.com>
6206
6207         * common/queue.h: Remove.
6208
6209 2019-04-19  Tom Tromey  <tom@tromey.com>
6210
6211         * event-loop.c: Don't include "common/queue.h".
6212
6213 2019-04-19  Tom Tromey  <tom@tromey.com>
6214
6215         * remote.c (remote_target): Use delete.
6216         * remote-notif.h: Include <list>, not "common/queue.h".
6217         (notif_client_p): Remove typedef.
6218         (remote_notif_state): Add constructor, destructor, initializer.
6219         <notif_queue>: Now a std::list.
6220         (remote_notif_state_xfree): Don't declare.
6221         * remote-notif.c (remote_notif_process, handle_notification)
6222         (remote_notif_state_allocate): Update.
6223         (~remote_notif_state): Rename from remote_notif_state_xfree.
6224
6225 2019-04-19  Tom Tromey  <tom@tromey.com>
6226
6227         * symfile.c (reread_symbols): Update.
6228         * objfiles.c (objfile_register_static_link)
6229         (objfile_lookup_static_link): Update
6230         (~objfile) Don't delete static_links.
6231         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6232
6233 2019-04-19  Tom Tromey  <tom@tromey.com>
6234
6235         * type-stack.h (struct type_stack) <insert>: Constify string.
6236         * type-stack.c (type_stack::insert): Constify string.
6237         * gdbtypes.h (lookup_template_type): Update.
6238         (address_space_name_to_int): Update.
6239         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6240         const.
6241         (lookup_template_type): Make name const.
6242         * c-exp.y: Update rules.
6243         (lex_one_token, classify_name, classify_inner_name)
6244         (c_print_token): Update.
6245         * p-exp.y: Update rules.
6246         (yylex): Update.
6247         * f-exp.y: Update rules.
6248         (yylex): Update.
6249         * d-exp.y: Update rules.
6250         (lex_one_token, classify_name, classify_inner_name): Update.
6251         * parse.c (write_dollar_variable, copy_name): Return std::string.
6252         * parser-defs.h (copy_name): Change return type.
6253         * m2-exp.y: Update rules.
6254         (yylex): Update.
6255         * go-exp.y (lex_one_token): Update.
6256         Update rules.
6257         (classify_unsafe_function, classify_packaged_name)
6258         (classify_name, yylex): Update.
6259
6260 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6261
6262         * configure.ac: add --enable-source-highlight switch.
6263         * configure: Regenerate.
6264         * top.c (print_gdb_version): plumb --enable-source-highlight
6265         status to "show configuration".
6266
6267 2019-04-19  Tom Tromey  <tromey@adacore.com>
6268
6269         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6270         Check ADA_TYPE_P.
6271         (empty_record, ada_template_to_fixed_record_type_1)
6272         (template_to_static_fixed_type)
6273         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6274         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6275         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6276         macros.
6277
6278 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6279
6280         PR symtab/24423:
6281         * source.c (print_source_lines_base): Advance "iter" when a
6282         control character is seen.
6283
6284 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6285
6286         * inferior.h (struct infcall_suspend_state_deleter):
6287         Catch exception in destructor to avoid crash.
6288
6289 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6290
6291         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6292         close to the add_com "shell".
6293
6294 2019-04-18  Tom Tromey  <tromey@adacore.com>
6295
6296         * process-stratum-target.h (class process_stratum_target)
6297         <stratum>: Add "final".
6298
6299 2019-04-17  Tom Tromey  <tromey@adacore.com>
6300
6301         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6302         against nullptr before use.
6303
6304 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6305
6306         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6307
6308 2019-04-17  Jim Wilson  <jimw@sifive.com>
6309             Andrew Burgess  <andrew.burgess@embecosm.com>
6310
6311         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6312         code read might fail, assume 4-byte breakpoint in that case.
6313
6314 2019-04-15  Leszek Swirski  <leszeks@google.com>
6315
6316         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6317         rather than a hand-rolled POD check when checking for forced MEMORY
6318         classification.
6319
6320 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6321
6322         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6323         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6324         function.
6325         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6326         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6327         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6328         declaration.
6329
6330 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6331
6332         * aarch64-linux-nat.c
6333         (aarch64_linux_nat_target::thread_architecture): Add override.
6334         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6335         each VQ.
6336
6337 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6338
6339         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6340
6341 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6342
6343         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6344         target types of size 96-bits, add some additional comments, and
6345         check that the builtin type we found was the correct size.
6346
6347 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6348
6349         * utils.c (prompt_for_continue): Don't restore the styling at the
6350         end, as applied_style has the wrong value.  This fixes styling in
6351         long lists of file names that are interrupted by the "Continue?"
6352         prompt.
6353
6354 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6355
6356         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6357         * c-lang.c (c_language_defn): Likewise.
6358         (cplus_language_defn): Likewise.
6359         (asm_language_defn): Likewise.
6360         (minimal_language_defn): Likewise.
6361         * d-lang.c (d_language_defn): Likewise.
6362         * f-lang.c (f_language_defn): Likewise.
6363         * go-lang.c (go_language_defn): Likewise.
6364         * language.c (unknown_language_defn): Likewise.
6365         (auto_language_defn): Likewise.
6366         * language.h (struct language_defn): Remove la_magic field.
6367         (LANG_MAGIC): Delete.
6368         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6369         * objc-lang.c (objc_language_defn): Likewise.
6370         * opencl-lang.c (opencl_language_defn): Likewise.
6371         * p-lang.c (pascal_language_defn): Likewise.
6372         * rust-lang.c (rust_language_defn): Likewise.
6373
6374 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6375
6376         * riscv-tdep.c (riscv_type_align): New function.
6377         (riscv_type_alignment): Delete.
6378         (riscv_arg_location): Use 'type_align'.
6379         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6380
6381 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6382
6383         * gdbtypes.c (type_align): A struct with no non-static fields also
6384         has alignment of 1.
6385
6386 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6387
6388         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6389         component to 0.
6390         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6391         member.
6392         (riscv_struct_info::analyse): New implementation using new
6393         analyse_inner member function.
6394         (riscv_struct_info::field_offset): New member function.
6395         (riscv_struct_info::m_offsets): New member variable.
6396         (riscv_struct_info::analyse_inner): New private member function,
6397         takes the old implementation of riscv_struct_info::analyse but
6398         extended to track field offsets.
6399         (riscv_call_arg_struct): Update the struct folding special cases
6400         to handle cases where empty C++ structs, which are non-zero
6401         length, are found.
6402         (riscv_arg_location): Initialise the length of each location, a
6403         non-zero length now indicates the location is in use.
6404         (riscv_push_dummy_call): Allow for the first location having a
6405         non-zero offset when setting up arguments.
6406         (riscv_return_value): Likewise, but for return values.
6407
6408 2019-04-11  Tom Tromey  <tromey@adacore.com>
6409
6410         * utils.c (internal_vproblem): Make "msg" const.
6411
6412 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6413
6414         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6415         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6416         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6417         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6418
6419 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6420
6421         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6422         function.
6423         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6424         of amd64_collect_native_gregset.
6425         (amd64_linux_nat_target::store_registers): Likewise.
6426
6427 2019-04-10  Tom Tromey  <tom@tromey.com>
6428
6429         * symtab.c (lookup_global_symbol_from_objfile)
6430         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6431         * objfiles.h (class separate_debug_iterator): New.
6432         (class separate_debug_range): New.
6433         (struct objfile) <separate_debug_objfiles>: New method.
6434         (objfile_separate_debug_iterate): Don't declare.
6435         * objfiles.c (separate_debug_iterator::operator++): Rename from
6436         objfile_separate_debug_iterate.
6437         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6438         iterator.
6439         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6440         iterator.
6441
6442 2019-04-10  Tom Tromey  <tom@tromey.com>
6443
6444         * symfile.c (reread_symbols): Remove old comment.
6445         * objfiles.c (free_all_objfiles): Fix a typo.
6446
6447 2019-04-10  Tom Tromey  <tom@tromey.com>
6448
6449         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6450         * minsyms.c (lookup_minimal_symbol): Use foreach.
6451         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6452         (lookup_minimal_symbol_solib_trampoline): Likewise.
6453         * symfile.c (reread_symbols): Use foreach.
6454
6455 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6456             Tom Tromey  <tromey@adacore.com>
6457
6458         PR rust/24414:
6459         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6460         (rust_lex_int_test): Change "value" to be LONGEST.
6461         (rust_lex_tests): Add test for long integer literal.
6462
6463 2019-04-09  Tom Tromey  <tromey@adacore.com>
6464
6465         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6466         to bool.
6467         (extended_remote_target::attach): Update.
6468         (remote_target::remote_notice_new_inferior): Update.
6469         (remote_target::add_current_inferior_and_thread): Update.
6470         * inferior.c (exit_inferior_1): Use "false".
6471         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6472
6473 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6474
6475         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6476         the "start" command.
6477
6478 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6479
6480         * python/py-inferior.c (infpy_thread_from_thread_handle):
6481         Adjust comments to reflect renaming of thread_from_thread_handle
6482         to thread_from_handle.  Adjust keywords.  Fix type error message.
6483         (inferior_object_methods): Add thread_from_handle.  Retain
6484         thread_from_thread_handle, but mark it as deprecated.
6485
6486 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6487
6488         * gdbthread.h (find_thread_by_handle): Revise declaration.
6489         * thread.c (find_thread_by_handle): Likewise.  Adjust
6490         implementation too.
6491         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6492         support for buffer objects as handles.
6493
6494 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6495
6496         * python/py-infthread.c (thpy_thread_handle): New function.
6497         (thread_object_methods): Register thpy_thread_handle.
6498
6499 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6500
6501         * gdbthread.h (thread_to_thread_handle): Declare.
6502         * thread.c (gdbtypes.h): Include.
6503         (thread_to_thread_handle): New function.
6504
6505         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6506         (target_thread_info_to_thread_handle): Declare.
6507         * target.c (target_thread_info_to_thread_handle): New function.
6508         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6509         * target-delegates.c: Regenerate.
6510
6511         * linux-thread-db.c (class thread_db_target): Add method
6512         thread_info_to_thread_handle.
6513         (thread_db_target::thread_info_to_thread_handle): Define.
6514         * remote.c (class remote_target): Add new method
6515         thread_info_to_thread_handle.
6516         (remote_target::thread_info_to_thread_handle): Define.
6517
6518 2019-04-08  Pedro Alves  <palves@redhat.com>
6519
6520         * common/common-exceptions.c (throw_exception): Don't create
6521         named object to throw; throw directly.
6522         (throw_it): Likewise.  Don't initialize gdb_exception::message
6523         here, with new; pass FMT and AP to the ctor instead.
6524         * common/common-exceptions.h: Include <string>.
6525         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6526         const char *, va_list)): New ctor.  Use std::make_shared.
6527         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6528         errors)): Delete.
6529         (gdb_exception_error::gdb_exception_error(enum errors, const char
6530         *, va_list)): New.
6531         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6532         Add assertion.
6533         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6534         errors)): Delete.
6535         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6536         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6537         Add assertion.
6538
6539 2019-04-08  Tom Tromey  <tom@tromey.com>
6540
6541         * valops.c (value_rtti_indirect_type): Replace throw_exception
6542         with throw.
6543         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6544         with throw.
6545         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6546         throw.
6547         * target.c (target_translate_tls_address): Replace throw_exception
6548         with throw.
6549         * stack.c (frame_apply_command_count): Replace throw_exception
6550         with throw.
6551         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6552         throw.
6553         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6554         with throw.
6555         * rs6000-tdep.c (rs6000_frame_cache)
6556         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6557         * remote.c: Replace throw_exception with throw.
6558         * record-full.c (record_full_message, record_full_wait_1)
6559         (record_full_restore): Replace throw_exception with throw.
6560         * record-btrace.c:
6561         (get_thread_current_frame_id, record_btrace_start_replaying)
6562         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6563         (cmd_record_btrace_start): Replace throw_exception with throw.
6564         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6565         throw.
6566         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6567         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6568         * linespec.c:
6569         (find_linespec_symbols): Replace throw_exception with throw.
6570         * infrun.c (displaced_step_prepare, resume): Replace
6571         throw_exception with throw.
6572         * infcmd.c (post_create_inferior): Replace throw_exception with
6573         throw.
6574         * inf-loop.c (inferior_event_handler): Replace throw_exception
6575         with throw.
6576         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6577         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6578         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6579         (get_prev_frame_always, get_frame_pc_if_available)
6580         (get_frame_address_in_block_if_available, get_frame_language):
6581         Replace throw_exception with throw.
6582         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6583         throw_exception with throw.
6584         * eval.c (fetch_subexp_value, evaluate_var_value)
6585         (evaluate_funcall, evaluate_subexp_standard): Replace
6586         throw_exception with throw.
6587         * dwarf2loc.c (call_site_find_chain)
6588         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6589         Replace throw_exception with throw.
6590         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6591         with throw.
6592         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6593         throw.
6594         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6595         * completer.c (complete_line_internal): Replace throw_exception
6596         with throw.
6597         * compile/compile-object-run.c (compile_object_run): Replace
6598         throw_exception with throw.
6599         * cli/cli-script.c (process_next_line): Replace throw_exception
6600         with throw.
6601         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6602         (btrace_enable, btrace_maint_update_pt_packets): Replace
6603         throw_exception with throw.
6604         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6605         throw_exception with throw.
6606         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6607         throw_exception with throw.
6608         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6609         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6610         * aarch64-tdep.c (aarch64_make_prologue_cache)
6611         (aarch64_make_stub_cache): Replace throw_exception with throw.
6612
6613 2019-04-08  Tom Tromey  <tom@tromey.com>
6614
6615         * common/common-exceptions.c (throw_exception): Rename from
6616         throw_exception_cxx.  Remove old copy.  Make argument const.
6617         (throw_it): Create and throw exception objects directly.
6618         * common/common-exceptions.h (throw_exception): Make argument
6619         const.
6620         (struct gdb_exception_error): Add constructor.
6621         (struct gdb_exception_quit): Add constructor.
6622
6623 2019-04-08  Tom Tromey  <tom@tromey.com>
6624
6625         * common/common-exceptions.h (exception_rethrow): Don't declare.
6626         (TRY_SJLJ): Update comment.
6627         (TRY, CATCH, END_CATCH): Remove.
6628         * common/common-exceptions.c (exception_rethrow): Remove.
6629
6630 2019-04-08  Tom Tromey  <tom@tromey.com>
6631
6632         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6633         Remove.
6634         (gdb_exception_error): Rename from
6635         gdb_exception_RETURN_MASK_ERROR.
6636         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6637         (gdb_quit_bad_alloc): Update.
6638         * aarch64-tdep.c: Update.
6639         * ada-lang.c: Update.
6640         * ada-typeprint.c: Update.
6641         * ada-valprint.c: Update.
6642         * amd64-tdep.c: Update.
6643         * arch-utils.c: Update.
6644         * break-catch-throw.c: Update.
6645         * breakpoint.c: Update.
6646         * btrace.c: Update.
6647         * c-varobj.c: Update.
6648         * cli/cli-cmds.c: Update.
6649         * cli/cli-interp.c: Update.
6650         * cli/cli-script.c: Update.
6651         * common/common-exceptions.c: Update.
6652         * common/new-op.c: Update.
6653         * common/selftest.c: Update.
6654         * compile/compile-c-symbols.c: Update.
6655         * compile/compile-cplus-symbols.c: Update.
6656         * compile/compile-object-load.c: Update.
6657         * compile/compile-object-run.c: Update.
6658         * completer.c: Update.
6659         * corelow.c: Update.
6660         * cp-abi.c: Update.
6661         * cp-support.c: Update.
6662         * cp-valprint.c: Update.
6663         * darwin-nat.c: Update.
6664         * disasm-selftests.c: Update.
6665         * dtrace-probe.c: Update.
6666         * dwarf-index-cache.c: Update.
6667         * dwarf-index-write.c: Update.
6668         * dwarf2-frame-tailcall.c: Update.
6669         * dwarf2-frame.c: Update.
6670         * dwarf2loc.c: Update.
6671         * dwarf2read.c: Update.
6672         * eval.c: Update.
6673         * event-loop.c: Update.
6674         * event-top.c: Update.
6675         * exec.c: Update.
6676         * f-valprint.c: Update.
6677         * fbsd-tdep.c: Update.
6678         * frame-unwind.c: Update.
6679         * frame.c: Update.
6680         * gdbtypes.c: Update.
6681         * gnu-v3-abi.c: Update.
6682         * guile/guile-internal.h: Update.
6683         * guile/scm-block.c: Update.
6684         * guile/scm-breakpoint.c: Update.
6685         * guile/scm-cmd.c: Update.
6686         * guile/scm-disasm.c: Update.
6687         * guile/scm-frame.c: Update.
6688         * guile/scm-lazy-string.c: Update.
6689         * guile/scm-math.c: Update.
6690         * guile/scm-param.c: Update.
6691         * guile/scm-ports.c: Update.
6692         * guile/scm-pretty-print.c: Update.
6693         * guile/scm-symbol.c: Update.
6694         * guile/scm-symtab.c: Update.
6695         * guile/scm-type.c: Update.
6696         * guile/scm-value.c: Update.
6697         * i386-linux-tdep.c: Update.
6698         * i386-tdep.c: Update.
6699         * inf-loop.c: Update.
6700         * infcall.c: Update.
6701         * infcmd.c: Update.
6702         * infrun.c: Update.
6703         * jit.c: Update.
6704         * language.c: Update.
6705         * linespec.c: Update.
6706         * linux-fork.c: Update.
6707         * linux-nat.c: Update.
6708         * linux-tdep.c: Update.
6709         * linux-thread-db.c: Update.
6710         * main.c: Update.
6711         * mi/mi-cmd-break.c: Update.
6712         * mi/mi-cmd-stack.c: Update.
6713         * mi/mi-interp.c: Update.
6714         * mi/mi-main.c: Update.
6715         * objc-lang.c: Update.
6716         * p-valprint.c: Update.
6717         * parse.c: Update.
6718         * ppc-linux-tdep.c: Update.
6719         * printcmd.c: Update.
6720         * python/py-arch.c: Update.
6721         * python/py-breakpoint.c: Update.
6722         * python/py-cmd.c: Update.
6723         * python/py-finishbreakpoint.c: Update.
6724         * python/py-frame.c: Update.
6725         * python/py-framefilter.c: Update.
6726         * python/py-gdb-readline.c: Update.
6727         * python/py-inferior.c: Update.
6728         * python/py-infthread.c: Update.
6729         * python/py-lazy-string.c: Update.
6730         * python/py-linetable.c: Update.
6731         * python/py-objfile.c: Update.
6732         * python/py-param.c: Update.
6733         * python/py-prettyprint.c: Update.
6734         * python/py-progspace.c: Update.
6735         * python/py-record-btrace.c: Update.
6736         * python/py-record.c: Update.
6737         * python/py-symbol.c: Update.
6738         * python/py-type.c: Update.
6739         * python/py-unwind.c: Update.
6740         * python/py-utils.c: Update.
6741         * python/py-value.c: Update.
6742         * python/python.c: Update.
6743         * record-btrace.c: Update.
6744         * record-full.c: Update.
6745         * remote-fileio.c: Update.
6746         * remote.c: Update.
6747         * riscv-tdep.c: Update.
6748         * rs6000-aix-tdep.c: Update.
6749         * rs6000-tdep.c: Update.
6750         * rust-exp.y: Update.
6751         * rust-lang.c: Update.
6752         * s390-tdep.c: Update.
6753         * selftest-arch.c: Update.
6754         * solib-dsbt.c: Update.
6755         * solib-frv.c: Update.
6756         * solib-spu.c: Update.
6757         * solib-svr4.c: Update.
6758         * solib.c: Update.
6759         * sparc64-linux-tdep.c: Update.
6760         * stack.c: Update.
6761         * symfile-mem.c: Update.
6762         * symmisc.c: Update.
6763         * target.c: Update.
6764         * thread.c: Update.
6765         * top.c: Update.
6766         * tracefile-tfile.c: Update.
6767         * tui/tui.c: Update.
6768         * typeprint.c: Update.
6769         * unittests/cli-utils-selftests.c: Update.
6770         * unittests/parse-connection-spec-selftests.c: Update.
6771         * valops.c: Update.
6772         * valprint.c: Update.
6773         * value.c: Update.
6774         * varobj.c: Update.
6775         * windows-nat.c: Update.
6776         * x86-linux-nat.c: Update.
6777         * xml-support.c: Update.
6778
6779 2019-04-08  Tom Tromey  <tom@tromey.com>
6780
6781         * xml-support.c: Use C++ exception handling.
6782         * x86-linux-nat.c: Use C++ exception handling.
6783         * windows-nat.c: Use C++ exception handling.
6784         * varobj.c: Use C++ exception handling.
6785         * value.c: Use C++ exception handling.
6786         * valprint.c: Use C++ exception handling.
6787         * valops.c: Use C++ exception handling.
6788         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6789         handling.
6790         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6791         * typeprint.c: Use C++ exception handling.
6792         * tui/tui.c: Use C++ exception handling.
6793         * tracefile-tfile.c: Use C++ exception handling.
6794         * top.c: Use C++ exception handling.
6795         * thread.c: Use C++ exception handling.
6796         * target.c: Use C++ exception handling.
6797         * symmisc.c: Use C++ exception handling.
6798         * symfile-mem.c: Use C++ exception handling.
6799         * stack.c: Use C++ exception handling.
6800         * sparc64-linux-tdep.c: Use C++ exception handling.
6801         * solib.c: Use C++ exception handling.
6802         * solib-svr4.c: Use C++ exception handling.
6803         * solib-spu.c: Use C++ exception handling.
6804         * solib-frv.c: Use C++ exception handling.
6805         * solib-dsbt.c: Use C++ exception handling.
6806         * selftest-arch.c: Use C++ exception handling.
6807         * s390-tdep.c: Use C++ exception handling.
6808         * rust-lang.c: Use C++ exception handling.
6809         * rust-exp.y: Use C++ exception handling.
6810         * rs6000-tdep.c: Use C++ exception handling.
6811         * rs6000-aix-tdep.c: Use C++ exception handling.
6812         * riscv-tdep.c: Use C++ exception handling.
6813         * remote.c: Use C++ exception handling.
6814         * remote-fileio.c: Use C++ exception handling.
6815         * record-full.c: Use C++ exception handling.
6816         * record-btrace.c: Use C++ exception handling.
6817         * python/python.c: Use C++ exception handling.
6818         * python/py-value.c: Use C++ exception handling.
6819         * python/py-utils.c: Use C++ exception handling.
6820         * python/py-unwind.c: Use C++ exception handling.
6821         * python/py-type.c: Use C++ exception handling.
6822         * python/py-symbol.c: Use C++ exception handling.
6823         * python/py-record.c: Use C++ exception handling.
6824         * python/py-record-btrace.c: Use C++ exception handling.
6825         * python/py-progspace.c: Use C++ exception handling.
6826         * python/py-prettyprint.c: Use C++ exception handling.
6827         * python/py-param.c: Use C++ exception handling.
6828         * python/py-objfile.c: Use C++ exception handling.
6829         * python/py-linetable.c: Use C++ exception handling.
6830         * python/py-lazy-string.c: Use C++ exception handling.
6831         * python/py-infthread.c: Use C++ exception handling.
6832         * python/py-inferior.c: Use C++ exception handling.
6833         * python/py-gdb-readline.c: Use C++ exception handling.
6834         * python/py-framefilter.c: Use C++ exception handling.
6835         * python/py-frame.c: Use C++ exception handling.
6836         * python/py-finishbreakpoint.c: Use C++ exception handling.
6837         * python/py-cmd.c: Use C++ exception handling.
6838         * python/py-breakpoint.c: Use C++ exception handling.
6839         * python/py-arch.c: Use C++ exception handling.
6840         * printcmd.c: Use C++ exception handling.
6841         * ppc-linux-tdep.c: Use C++ exception handling.
6842         * parse.c: Use C++ exception handling.
6843         * p-valprint.c: Use C++ exception handling.
6844         * objc-lang.c: Use C++ exception handling.
6845         * mi/mi-main.c: Use C++ exception handling.
6846         * mi/mi-interp.c: Use C++ exception handling.
6847         * mi/mi-cmd-stack.c: Use C++ exception handling.
6848         * mi/mi-cmd-break.c: Use C++ exception handling.
6849         * main.c: Use C++ exception handling.
6850         * linux-thread-db.c: Use C++ exception handling.
6851         * linux-tdep.c: Use C++ exception handling.
6852         * linux-nat.c: Use C++ exception handling.
6853         * linux-fork.c: Use C++ exception handling.
6854         * linespec.c: Use C++ exception handling.
6855         * language.c: Use C++ exception handling.
6856         * jit.c: Use C++ exception handling.
6857         * infrun.c: Use C++ exception handling.
6858         * infcmd.c: Use C++ exception handling.
6859         * infcall.c: Use C++ exception handling.
6860         * inf-loop.c: Use C++ exception handling.
6861         * i386-tdep.c: Use C++ exception handling.
6862         * i386-linux-tdep.c: Use C++ exception handling.
6863         * guile/scm-value.c: Use C++ exception handling.
6864         * guile/scm-type.c: Use C++ exception handling.
6865         * guile/scm-symtab.c: Use C++ exception handling.
6866         * guile/scm-symbol.c: Use C++ exception handling.
6867         * guile/scm-pretty-print.c: Use C++ exception handling.
6868         * guile/scm-ports.c: Use C++ exception handling.
6869         * guile/scm-param.c: Use C++ exception handling.
6870         * guile/scm-math.c: Use C++ exception handling.
6871         * guile/scm-lazy-string.c: Use C++ exception handling.
6872         * guile/scm-frame.c: Use C++ exception handling.
6873         * guile/scm-disasm.c: Use C++ exception handling.
6874         * guile/scm-cmd.c: Use C++ exception handling.
6875         * guile/scm-breakpoint.c: Use C++ exception handling.
6876         * guile/scm-block.c: Use C++ exception handling.
6877         * guile/guile-internal.h: Use C++ exception handling.
6878         * gnu-v3-abi.c: Use C++ exception handling.
6879         * gdbtypes.c: Use C++ exception handling.
6880         * frame.c: Use C++ exception handling.
6881         * frame-unwind.c: Use C++ exception handling.
6882         * fbsd-tdep.c: Use C++ exception handling.
6883         * f-valprint.c: Use C++ exception handling.
6884         * exec.c: Use C++ exception handling.
6885         * event-top.c: Use C++ exception handling.
6886         * event-loop.c: Use C++ exception handling.
6887         * eval.c: Use C++ exception handling.
6888         * dwarf2read.c: Use C++ exception handling.
6889         * dwarf2loc.c: Use C++ exception handling.
6890         * dwarf2-frame.c: Use C++ exception handling.
6891         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6892         * dwarf-index-write.c: Use C++ exception handling.
6893         * dwarf-index-cache.c: Use C++ exception handling.
6894         * dtrace-probe.c: Use C++ exception handling.
6895         * disasm-selftests.c: Use C++ exception handling.
6896         * darwin-nat.c: Use C++ exception handling.
6897         * cp-valprint.c: Use C++ exception handling.
6898         * cp-support.c: Use C++ exception handling.
6899         * cp-abi.c: Use C++ exception handling.
6900         * corelow.c: Use C++ exception handling.
6901         * completer.c: Use C++ exception handling.
6902         * compile/compile-object-run.c: Use C++ exception handling.
6903         * compile/compile-object-load.c: Use C++ exception handling.
6904         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6905         * compile/compile-c-symbols.c: Use C++ exception handling.
6906         * common/selftest.c: Use C++ exception handling.
6907         * common/new-op.c: Use C++ exception handling.
6908         * cli/cli-script.c: Use C++ exception handling.
6909         * cli/cli-interp.c: Use C++ exception handling.
6910         * cli/cli-cmds.c: Use C++ exception handling.
6911         * c-varobj.c: Use C++ exception handling.
6912         * btrace.c: Use C++ exception handling.
6913         * breakpoint.c: Use C++ exception handling.
6914         * break-catch-throw.c: Use C++ exception handling.
6915         * arch-utils.c: Use C++ exception handling.
6916         * amd64-tdep.c: Use C++ exception handling.
6917         * ada-valprint.c: Use C++ exception handling.
6918         * ada-typeprint.c: Use C++ exception handling.
6919         * ada-lang.c: Use C++ exception handling.
6920         * aarch64-tdep.c: Use C++ exception handling.
6921
6922 2019-04-08  Tom Tromey  <tom@tromey.com>
6923
6924         * xml-support.c (gdb_xml_parser::parse): Update.
6925         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6926         * value.c (show_convenience): Update.
6927         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6928         (test_parse_flags_qcs): Update.
6929         * thread.c (thr_try_catch_cmd): Update.
6930         * target.c (target_translate_tls_address): Update.
6931         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6932         (info_frame_command_core, frame_apply_command_count): Update.
6933         * rust-exp.y (rust_lex_exception_test): Update.
6934         * riscv-tdep.c (riscv_print_one_register_info): Update.
6935         * remote.c (remote_target::enable_btrace): Update.
6936         * record-btrace.c (record_btrace_enable_warn): Update.
6937         * python/py-utils.c (gdbpy_convert_exception): Update.
6938         * printcmd.c (do_one_display, print_variable_and_value): Update.
6939         * mi/mi-main.c (mi_print_exception): Update.
6940         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6941         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6942         * linux-nat.c (linux_nat_target::attach): Update.
6943         * linux-fork.c (class scoped_switch_fork_info): Update.
6944         * infrun.c (displaced_step_prepare): Update.
6945         * infcall.c (call_function_by_hand_dummy): Update.
6946         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6947         * gnu-v3-abi.c (print_one_vtable): Update.
6948         * frame.c (get_prev_frame_always): Update.
6949         * f-valprint.c (info_common_command_for_block): Update.
6950         * exec.c (try_open_exec_file): Update.
6951         * exceptions.c (print_exception, exception_print)
6952         (exception_fprintf, exception_print_same): Update.
6953         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6954         * dwarf-index-cache.c (index_cache::store)
6955         (index_cache::lookup_gdb_index): Update.
6956         * darwin-nat.c (maybe_cache_shell): Update.
6957         * cp-valprint.c (cp_print_value_fields): Update.
6958         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6959         (gcc_cplus_symbol_address): Update.
6960         * compile/compile-c-symbols.c (gcc_convert_symbol)
6961         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6962         * common/selftest.c: Update.
6963         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6964         a std::string.
6965         (exception_try_scope_entry, exception_try_scope_exit): Don't
6966         declare.
6967         (struct exception_try_scope): Remove.
6968         (TRY): Don't use exception_try_scope.
6969         (struct gdb_exception): Add constructor, operator=.
6970         <what>: New method.
6971         (struct gdb_exception_RETURN_MASK_ALL)
6972         (struct gdb_exception_RETURN_MASK_ERROR)
6973         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6974         (struct gdb_quit_bad_alloc): Update.
6975         * common/common-exceptions.c (exception_none): Change
6976         initializer.
6977         (struct catcher) <state, exception>: Initialize inline.
6978         <prev>: Remove member.
6979         (current_catcher): Remove.
6980         (catchers): New global.
6981         (exceptions_state_mc_init): Simplify.
6982         (catcher_pop): Remove.
6983         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6984         (try_scope_depth, exception_try_scope_entry)
6985         (exception_try_scope_exit): Remove.
6986         (throw_exception_sjlj): Update.
6987         (exception_messages, exception_messages_size): Remove.
6988         (throw_it): Simplify.
6989         (gdb_exception_sliced_copy): Remove.
6990         (throw_exception_cxx): Update.
6991         * cli/cli-script.c (script_from_file): Update.
6992         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6993         Update.
6994         * ada-valprint.c (ada_val_print): Update.
6995         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6996         (create_excep_cond_exprs): Update.
6997
6998 2019-04-08  Tom Tromey  <tom@tromey.com>
6999
7000         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7001         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7002         (TRY, CATCH, END_CATCH): Remove some definitions.
7003         * common/common-exceptions.c: Don't use GDB_XCPT.
7004         (catcher_list_size): Remove.
7005         (throw_exception, throw_it): Simplify.
7006
7007 2019-04-05  Tom Tromey  <tom@tromey.com>
7008
7009         Revert the header-sorting patch.
7010         * ft32-tdep.c: Revert.
7011         * frv-tdep.c: Revert.
7012         * frv-linux-tdep.c: Revert.
7013         * frame.c: Revert.
7014         * frame-unwind.c: Revert.
7015         * frame-base.c: Revert.
7016         * fork-child.c: Revert.
7017         * findvar.c: Revert.
7018         * findcmd.c: Revert.
7019         * filesystem.c: Revert.
7020         * filename-seen-cache.h: Revert.
7021         * filename-seen-cache.c: Revert.
7022         * fbsd-tdep.c: Revert.
7023         * fbsd-nat.h: Revert.
7024         * fbsd-nat.c: Revert.
7025         * f-valprint.c: Revert.
7026         * f-typeprint.c: Revert.
7027         * f-lang.c: Revert.
7028         * extension.h: Revert.
7029         * extension.c: Revert.
7030         * extension-priv.h: Revert.
7031         * expprint.c: Revert.
7032         * exec.h: Revert.
7033         * exec.c: Revert.
7034         * exceptions.c: Revert.
7035         * event-top.c: Revert.
7036         * event-loop.c: Revert.
7037         * eval.c: Revert.
7038         * elfread.c: Revert.
7039         * dwarf2read.h: Revert.
7040         * dwarf2read.c: Revert.
7041         * dwarf2loc.c: Revert.
7042         * dwarf2expr.h: Revert.
7043         * dwarf2expr.c: Revert.
7044         * dwarf2-frame.c: Revert.
7045         * dwarf2-frame-tailcall.c: Revert.
7046         * dwarf-index-write.h: Revert.
7047         * dwarf-index-write.c: Revert.
7048         * dwarf-index-common.c: Revert.
7049         * dwarf-index-cache.h: Revert.
7050         * dwarf-index-cache.c: Revert.
7051         * dummy-frame.c: Revert.
7052         * dtrace-probe.c: Revert.
7053         * disasm.h: Revert.
7054         * disasm.c: Revert.
7055         * disasm-selftests.c: Revert.
7056         * dictionary.c: Revert.
7057         * dicos-tdep.c: Revert.
7058         * demangle.c: Revert.
7059         * dcache.h: Revert.
7060         * dcache.c: Revert.
7061         * darwin-nat.h: Revert.
7062         * darwin-nat.c: Revert.
7063         * darwin-nat-info.c: Revert.
7064         * d-valprint.c: Revert.
7065         * d-namespace.c: Revert.
7066         * d-lang.c: Revert.
7067         * ctf.c: Revert.
7068         * csky-tdep.c: Revert.
7069         * csky-linux-tdep.c: Revert.
7070         * cris-tdep.c: Revert.
7071         * cris-linux-tdep.c: Revert.
7072         * cp-valprint.c: Revert.
7073         * cp-support.c: Revert.
7074         * cp-namespace.c: Revert.
7075         * cp-abi.c: Revert.
7076         * corelow.c: Revert.
7077         * corefile.c: Revert.
7078         * continuations.c: Revert.
7079         * completer.h: Revert.
7080         * completer.c: Revert.
7081         * complaints.c: Revert.
7082         * coffread.c: Revert.
7083         * coff-pe-read.c: Revert.
7084         * cli-out.h: Revert.
7085         * cli-out.c: Revert.
7086         * charset.c: Revert.
7087         * c-varobj.c: Revert.
7088         * c-valprint.c: Revert.
7089         * c-typeprint.c: Revert.
7090         * c-lang.c: Revert.
7091         * buildsym.c: Revert.
7092         * buildsym-legacy.c: Revert.
7093         * build-id.h: Revert.
7094         * build-id.c: Revert.
7095         * btrace.c: Revert.
7096         * bsd-uthread.c: Revert.
7097         * breakpoint.h: Revert.
7098         * breakpoint.c: Revert.
7099         * break-catch-throw.c: Revert.
7100         * break-catch-syscall.c: Revert.
7101         * break-catch-sig.c: Revert.
7102         * blockframe.c: Revert.
7103         * block.c: Revert.
7104         * bfin-tdep.c: Revert.
7105         * bfin-linux-tdep.c: Revert.
7106         * bfd-target.c: Revert.
7107         * bcache.c: Revert.
7108         * ax-general.c: Revert.
7109         * ax-gdb.h: Revert.
7110         * ax-gdb.c: Revert.
7111         * avr-tdep.c: Revert.
7112         * auxv.c: Revert.
7113         * auto-load.c: Revert.
7114         * arm-wince-tdep.c: Revert.
7115         * arm-tdep.c: Revert.
7116         * arm-symbian-tdep.c: Revert.
7117         * arm-pikeos-tdep.c: Revert.
7118         * arm-obsd-tdep.c: Revert.
7119         * arm-nbsd-tdep.c: Revert.
7120         * arm-nbsd-nat.c: Revert.
7121         * arm-linux-tdep.c: Revert.
7122         * arm-linux-nat.c: Revert.
7123         * arm-fbsd-tdep.c: Revert.
7124         * arm-fbsd-nat.c: Revert.
7125         * arm-bsd-tdep.c: Revert.
7126         * arch-utils.c: Revert.
7127         * arc-tdep.c: Revert.
7128         * arc-newlib-tdep.c: Revert.
7129         * annotate.h: Revert.
7130         * annotate.c: Revert.
7131         * amd64-windows-tdep.c: Revert.
7132         * amd64-windows-nat.c: Revert.
7133         * amd64-tdep.c: Revert.
7134         * amd64-sol2-tdep.c: Revert.
7135         * amd64-obsd-tdep.c: Revert.
7136         * amd64-obsd-nat.c: Revert.
7137         * amd64-nbsd-tdep.c: Revert.
7138         * amd64-nbsd-nat.c: Revert.
7139         * amd64-nat.c: Revert.
7140         * amd64-linux-tdep.c: Revert.
7141         * amd64-linux-nat.c: Revert.
7142         * amd64-fbsd-tdep.c: Revert.
7143         * amd64-fbsd-nat.c: Revert.
7144         * amd64-dicos-tdep.c: Revert.
7145         * amd64-darwin-tdep.c: Revert.
7146         * amd64-bsd-nat.c: Revert.
7147         * alpha-tdep.c: Revert.
7148         * alpha-obsd-tdep.c: Revert.
7149         * alpha-nbsd-tdep.c: Revert.
7150         * alpha-mdebug-tdep.c: Revert.
7151         * alpha-linux-tdep.c: Revert.
7152         * alpha-linux-nat.c: Revert.
7153         * alpha-bsd-tdep.c: Revert.
7154         * alpha-bsd-nat.c: Revert.
7155         * aix-thread.c: Revert.
7156         * agent.c: Revert.
7157         * addrmap.c: Revert.
7158         * ada-varobj.c: Revert.
7159         * ada-valprint.c: Revert.
7160         * ada-typeprint.c: Revert.
7161         * ada-tasks.c: Revert.
7162         * ada-lang.c: Revert.
7163         * aarch64-tdep.c: Revert.
7164         * aarch64-ravenscar-thread.c: Revert.
7165         * aarch64-newlib-tdep.c: Revert.
7166         * aarch64-linux-tdep.c: Revert.
7167         * aarch64-linux-nat.c: Revert.
7168         * aarch64-fbsd-tdep.c: Revert.
7169         * aarch64-fbsd-nat.c: Revert.
7170         * aarch32-linux-nat.c: Revert.
7171
7172 2019-04-05  Tom Tromey  <tom@tromey.com>
7173
7174         * ft32-tdep.c: Sort headers.
7175         * frv-tdep.c: Sort headers.
7176         * frv-linux-tdep.c: Sort headers.
7177         * frame.c: Sort headers.
7178         * frame-unwind.c: Sort headers.
7179         * frame-base.c: Sort headers.
7180         * fork-child.c: Sort headers.
7181         * findvar.c: Sort headers.
7182         * findcmd.c: Sort headers.
7183         * filesystem.c: Sort headers.
7184         * filename-seen-cache.h: Sort headers.
7185         * filename-seen-cache.c: Sort headers.
7186         * fbsd-tdep.c: Sort headers.
7187         * fbsd-nat.h: Sort headers.
7188         * fbsd-nat.c: Sort headers.
7189         * f-valprint.c: Sort headers.
7190         * f-typeprint.c: Sort headers.
7191         * f-lang.c: Sort headers.
7192         * extension.h: Sort headers.
7193         * extension.c: Sort headers.
7194         * extension-priv.h: Sort headers.
7195         * expprint.c: Sort headers.
7196         * exec.h: Sort headers.
7197         * exec.c: Sort headers.
7198         * exceptions.c: Sort headers.
7199         * event-top.c: Sort headers.
7200         * event-loop.c: Sort headers.
7201         * eval.c: Sort headers.
7202         * elfread.c: Sort headers.
7203         * dwarf2read.h: Sort headers.
7204         * dwarf2read.c: Sort headers.
7205         * dwarf2loc.c: Sort headers.
7206         * dwarf2expr.h: Sort headers.
7207         * dwarf2expr.c: Sort headers.
7208         * dwarf2-frame.c: Sort headers.
7209         * dwarf2-frame-tailcall.c: Sort headers.
7210         * dwarf-index-write.h: Sort headers.
7211         * dwarf-index-write.c: Sort headers.
7212         * dwarf-index-common.c: Sort headers.
7213         * dwarf-index-cache.h: Sort headers.
7214         * dwarf-index-cache.c: Sort headers.
7215         * dummy-frame.c: Sort headers.
7216         * dtrace-probe.c: Sort headers.
7217         * disasm.h: Sort headers.
7218         * disasm.c: Sort headers.
7219         * disasm-selftests.c: Sort headers.
7220         * dictionary.c: Sort headers.
7221         * dicos-tdep.c: Sort headers.
7222         * demangle.c: Sort headers.
7223         * dcache.h: Sort headers.
7224         * dcache.c: Sort headers.
7225         * darwin-nat.h: Sort headers.
7226         * darwin-nat.c: Sort headers.
7227         * darwin-nat-info.c: Sort headers.
7228         * d-valprint.c: Sort headers.
7229         * d-namespace.c: Sort headers.
7230         * d-lang.c: Sort headers.
7231         * ctf.c: Sort headers.
7232         * csky-tdep.c: Sort headers.
7233         * csky-linux-tdep.c: Sort headers.
7234         * cris-tdep.c: Sort headers.
7235         * cris-linux-tdep.c: Sort headers.
7236         * cp-valprint.c: Sort headers.
7237         * cp-support.c: Sort headers.
7238         * cp-namespace.c: Sort headers.
7239         * cp-abi.c: Sort headers.
7240         * corelow.c: Sort headers.
7241         * corefile.c: Sort headers.
7242         * continuations.c: Sort headers.
7243         * completer.h: Sort headers.
7244         * completer.c: Sort headers.
7245         * complaints.c: Sort headers.
7246         * coffread.c: Sort headers.
7247         * coff-pe-read.c: Sort headers.
7248         * cli-out.h: Sort headers.
7249         * cli-out.c: Sort headers.
7250         * charset.c: Sort headers.
7251         * c-varobj.c: Sort headers.
7252         * c-valprint.c: Sort headers.
7253         * c-typeprint.c: Sort headers.
7254         * c-lang.c: Sort headers.
7255         * buildsym.c: Sort headers.
7256         * buildsym-legacy.c: Sort headers.
7257         * build-id.h: Sort headers.
7258         * build-id.c: Sort headers.
7259         * btrace.c: Sort headers.
7260         * bsd-uthread.c: Sort headers.
7261         * breakpoint.h: Sort headers.
7262         * breakpoint.c: Sort headers.
7263         * break-catch-throw.c: Sort headers.
7264         * break-catch-syscall.c: Sort headers.
7265         * break-catch-sig.c: Sort headers.
7266         * blockframe.c: Sort headers.
7267         * block.c: Sort headers.
7268         * bfin-tdep.c: Sort headers.
7269         * bfin-linux-tdep.c: Sort headers.
7270         * bfd-target.c: Sort headers.
7271         * bcache.c: Sort headers.
7272         * ax-general.c: Sort headers.
7273         * ax-gdb.h: Sort headers.
7274         * ax-gdb.c: Sort headers.
7275         * avr-tdep.c: Sort headers.
7276         * auxv.c: Sort headers.
7277         * auto-load.c: Sort headers.
7278         * arm-wince-tdep.c: Sort headers.
7279         * arm-tdep.c: Sort headers.
7280         * arm-symbian-tdep.c: Sort headers.
7281         * arm-pikeos-tdep.c: Sort headers.
7282         * arm-obsd-tdep.c: Sort headers.
7283         * arm-nbsd-tdep.c: Sort headers.
7284         * arm-nbsd-nat.c: Sort headers.
7285         * arm-linux-tdep.c: Sort headers.
7286         * arm-linux-nat.c: Sort headers.
7287         * arm-fbsd-tdep.c: Sort headers.
7288         * arm-fbsd-nat.c: Sort headers.
7289         * arm-bsd-tdep.c: Sort headers.
7290         * arch-utils.c: Sort headers.
7291         * arc-tdep.c: Sort headers.
7292         * arc-newlib-tdep.c: Sort headers.
7293         * annotate.h: Sort headers.
7294         * annotate.c: Sort headers.
7295         * amd64-windows-tdep.c: Sort headers.
7296         * amd64-windows-nat.c: Sort headers.
7297         * amd64-tdep.c: Sort headers.
7298         * amd64-sol2-tdep.c: Sort headers.
7299         * amd64-obsd-tdep.c: Sort headers.
7300         * amd64-obsd-nat.c: Sort headers.
7301         * amd64-nbsd-tdep.c: Sort headers.
7302         * amd64-nbsd-nat.c: Sort headers.
7303         * amd64-nat.c: Sort headers.
7304         * amd64-linux-tdep.c: Sort headers.
7305         * amd64-linux-nat.c: Sort headers.
7306         * amd64-fbsd-tdep.c: Sort headers.
7307         * amd64-fbsd-nat.c: Sort headers.
7308         * amd64-dicos-tdep.c: Sort headers.
7309         * amd64-darwin-tdep.c: Sort headers.
7310         * amd64-bsd-nat.c: Sort headers.
7311         * alpha-tdep.c: Sort headers.
7312         * alpha-obsd-tdep.c: Sort headers.
7313         * alpha-nbsd-tdep.c: Sort headers.
7314         * alpha-mdebug-tdep.c: Sort headers.
7315         * alpha-linux-tdep.c: Sort headers.
7316         * alpha-linux-nat.c: Sort headers.
7317         * alpha-bsd-tdep.c: Sort headers.
7318         * alpha-bsd-nat.c: Sort headers.
7319         * aix-thread.c: Sort headers.
7320         * agent.c: Sort headers.
7321         * addrmap.c: Sort headers.
7322         * ada-varobj.c: Sort headers.
7323         * ada-valprint.c: Sort headers.
7324         * ada-typeprint.c: Sort headers.
7325         * ada-tasks.c: Sort headers.
7326         * ada-lang.c: Sort headers.
7327         * aarch64-tdep.c: Sort headers.
7328         * aarch64-ravenscar-thread.c: Sort headers.
7329         * aarch64-newlib-tdep.c: Sort headers.
7330         * aarch64-linux-tdep.c: Sort headers.
7331         * aarch64-linux-nat.c: Sort headers.
7332         * aarch64-fbsd-tdep.c: Sort headers.
7333         * aarch64-fbsd-nat.c: Sort headers.
7334         * aarch32-linux-nat.c: Sort headers.
7335
7336 2019-04-04  Tom Tromey  <tom@tromey.com>
7337
7338         * varobj.c (varobj_create): Update.
7339         * rust-exp.y (struct rust_parser) <update_innermost_block,
7340         lookup_symbol>: New methods.
7341         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7342         Rename.
7343         (rust_parser::rust_lookup_type)
7344         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7345         * printcmd.c (display_command, do_one_display): Update.
7346         * parser-defs.h (struct parser_state) <parser_state>: Add
7347         "tracker" parameter.
7348         (block_tracker): New member.
7349         (class innermost_block_tracker) <innermost_block_tracker>: Add
7350         "types" parameter.
7351         <reset>: Remove method.
7352         (innermost_block): Don't declare.
7353         (null_post_parser): Update.
7354         * parse.c (innermost_block): Remove global.
7355         (write_dollar_variable): Update.
7356         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7357         Remove "tracker_types" parameter.
7358         (parse_expression): Add "tracker" parameter.
7359         (parse_expression_for_completion): Update.
7360         (null_post_parser): Add "tracker" parameter.
7361         * p-exp.y: Update rules.
7362         * m2-exp.y: Update rules.
7363         * language.h (struct language_defn) <la_post_parser>: Add
7364         "tracker" parameter.
7365         * go-exp.y: Update rules.
7366         * f-exp.y: Update rules.
7367         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7368         parameter.
7369         * d-exp.y: Update rules.
7370         * c-exp.y: Update rules.
7371         * breakpoint.c (set_breakpoint_condition): Create an
7372         innermost_block_tracker.
7373         (watch_command_1): Likewise.
7374         * ada-lang.c (resolve): Add "tracker" parameter.
7375         (resolve_subexp): Likewise.
7376         * ada-exp.y (write_var_from_sym): Update.
7377
7378 2019-04-04  Tom Tromey  <tom@tromey.com>
7379
7380         * type-stack.h: New file.
7381         * type-stack.c: New file.
7382         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7383         type-stack.h.
7384         (insert_into_type_stack, insert_type, push_type, push_type_int)
7385         (insert_type_address_space, pop_type, pop_type_int)
7386         (pop_typelist, pop_type_stack, append_type_stack)
7387         (push_type_stack, get_type_stack, push_typelist)
7388         (follow_type_instance_flags, follow_types): Don't declare.
7389         * parse.c (type_stack): Remove global.
7390         (parse_exp_in_context): Update.
7391         (insert_into_type_stack, insert_type, push_type, push_type_int)
7392         (insert_type_address_space, pop_type, pop_type_int)
7393         (pop_typelist, pop_type_stack, append_type_stack)
7394         (push_type_stack, get_type_stack, push_typelist)
7395         (follow_type_instance_flags, follow_types): Remove (moved to
7396         type-stack.c).
7397         * f-exp.y (type_stack): New global.
7398         Update rules.
7399         (push_kind_type, f_parse): Update.
7400         * d-exp.y (type_stack): New global.
7401         Update rules.
7402         (d_parse): Update.
7403         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7404         Update rules.
7405         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7406         (HFILES_NO_SRCDIR): Add type-stack.h.
7407
7408 2019-04-04  Tom Tromey  <tom@tromey.com>
7409
7410         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7411         (rust_parser::convert_ast_to_expression, rust_parse)
7412         (rust_lex_test_completion, rust_lex_tests): Update.
7413         * parser-defs.h (struct expr_completion_state): New.
7414         (struct parser_state) <parser_state>: Add completion parameter.
7415         <mark_struct_expression, mark_completion_tag>: New methods.
7416         <parse_completion, m_completion_state>: New members.
7417         (prefixify_expression, null_post_parser): Update.
7418         (mark_struct_expression, mark_completion_tag): Don't declare.
7419         * parse.c (parse_completion, expout_last_struct)
7420         (expout_tag_completion_type, expout_completion_name): Remove
7421         globals.
7422         (parser_state::mark_struct_expression)
7423         (parser_state::mark_completion_tag): Now methods.
7424         (prefixify_expression): Add last_struct parameter.
7425         (prefixify_subexp): Likewise.
7426         (parse_exp_1): Update.
7427         (parse_exp_in_context): Add cstate parameter.  Update.
7428         (parse_expression_for_completion): Create an
7429         expr_completion_state.
7430         (null_post_parser): Add "completion" parameter.
7431         * p-exp.y: Update rules.
7432         (yylex): Update.
7433         * language.h (struct language_defn) <la_post_parser>: Add
7434         "completing" parameter.
7435         * go-exp.y: Update rules.
7436         (lex_one_token): Update.
7437         * expression.h (parse_completion): Don't declare.
7438         * d-exp.y: Update rules.
7439         (lex_one_token): Update rules.
7440         * c-exp.y: Update rules.
7441         (lex_one_token): Update.
7442         * ada-lang.c (resolve): Add "parse_completion" parameter.
7443         (resolve_subexp): Likewise.
7444         (ada_resolve_function): Likewise.
7445
7446 2019-04-04  Tom Tromey  <tom@tromey.com>
7447
7448         * parser-defs.h (struct parser_state) <start_arglist,
7449         end_arglist>: New methods.
7450         <arglist_len, m_funcall_chain>: New members.
7451         (arglist_len, start_arglist, end_arglist): Don't declare.
7452         * parse.c (arglist_len, funcall_chain): Remove global.
7453         (start_arglist, end_arglist): Remove functions.
7454         (parse_exp_in_context): Update.
7455         * p-exp.y: Update rules.
7456         * m2-exp.y: Update rules.
7457         * go-exp.y: Update rules.
7458         * f-exp.y: Update rules.
7459         * d-exp.y: Update rules.
7460         * c-exp.y: Update rules.
7461
7462 2019-04-04  Tom Tromey  <tom@tromey.com>
7463
7464         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7465         lex_operator, push_back>: New methods.
7466         Update all rules.
7467         (rust_parser::lex_hex, lex_escape): Rename and update.
7468         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7469         (rust_parser::lex_operator): Rename and update.
7470         (rust_parser::lex_number, rustyylex, rustyyerror)
7471         (rust_lex_test_init, rust_lex_test_sequence)
7472         (rust_lex_test_push_back, rust_lex_tests): Update.
7473         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7474         parameter.
7475         <lexptr, prev_lexptr>: New members.
7476         (lexptr, prev_lexptr): Don't declare.
7477         * parse.c (lexptr, prev_lexptr): Remove globals.
7478         (parse_exp_in_context): Update.
7479         * p-exp.y (yylex, yyerror): Update.
7480         * m2-exp.y (parse_number, yylex, yyerror): Update.
7481         * go-exp.y (lex_one_token, yyerror): Update.
7482         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7483         * d-exp.y (lex_one_token, yyerror): Update.
7484         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7485         (lex_one_token, yyerror): Update.
7486         * ada-lex.l (YY_INPUT): Update.
7487         (rewind_to_char): Update.
7488         * ada-exp.y (yyerror): Update.
7489
7490 2019-04-04  Tom Tromey  <tom@tromey.com>
7491
7492         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7493         * parser-defs.h (struct parser_state) <parser_state>: Add new
7494         parameter.
7495         <comma_terminates>: New member.
7496         (comma_terminates): Don't declare global.
7497         * parse.c (comma_terminates): Remove global.
7498         (parse_exp_in_context): Update.
7499         * p-exp.y (yylex): Update.
7500         * m2-exp.y (yylex): Update.
7501         * go-exp.y (lex_one_token): Update.
7502         * f-exp.y (yylex): Update.
7503         * d-exp.y (lex_one_token): Update.
7504         * c-exp.y (lex_one_token): Update.
7505         * ada-lex.l: Update.
7506
7507 2019-04-04  Tom Tromey  <tom@tromey.com>
7508
7509         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7510         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7511         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7512         * parser-defs.h (paren_depth): Don't declare.
7513         * parse.c (paren_depth): Remove global.
7514         (parse_exp_in_context): Update.
7515         * p-exp.y (paren_depth): New global.
7516         (pascal_parse): Initialize it.
7517         * m2-exp.y (paren_depth): New global.
7518         (m2_parse): Initialize it.
7519         * go-exp.y (paren_depth): New global.
7520         (go_parse): Initialize it.
7521         * f-exp.y (paren_depth): New global.
7522         (f_parse): Initialize it.
7523         * d-exp.y (paren_depth): New global.
7524         (d_parse): Initialize it.
7525         * c-exp.y (paren_depth): New global.
7526         (c_parse): Initialize it.
7527         * ada-lex.l (paren_depth): New global.
7528         (lexer_init): Initialize it.
7529
7530 2019-04-04  Tom Tromey  <tom@tromey.com>
7531
7532         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7533         (rust_parser::convert_ast_to_type)
7534         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7535         * parser-defs.h (struct parser_state) <parser_state>: Add
7536         parameters.  Initialize new members.
7537         <expression_context_block, expression_context_pc>: New members.
7538         * parse.c (expression_context_block, expression_context_pc):
7539         Remove globals.
7540         (parse_exp_in_context): Update.
7541         * p-exp.y: Update all rules.
7542         (yylex): Update.
7543         * m2-exp.y: Update all rules.
7544         (yylex): Update.
7545         * go-exp.y (yylex): Update.
7546         * f-exp.y (yylex): Update.
7547         * d-exp.y: Update all rules.
7548         (yylex): Update.
7549         * c-exp.y: Update all rules.
7550         (lex_one_token, classify_name, yylex, c_parse): Update.
7551         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7552
7553 2019-04-04  Tom Tromey  <tom@tromey.com>
7554
7555         * gdbarch.h, gdbarch.c: Rebuild.
7556         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7557         * stap-probe.h:
7558         (struct stap_parse_info): Replace "parser_state" with
7559         "expr_builder".
7560         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7561         (parser_state): New class.
7562         * parse.c (expr_builder): Rename.
7563         (expr_builder::release): Rename.
7564         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7565         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7566         (write_exp_elt_longcst, write_exp_elt_floatcst)
7567         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7568         (write_exp_string_vector, write_exp_bitstring)
7569         (write_exp_msymbol, mark_struct_expression)
7570         (write_dollar_variable)
7571         (insert_type_address_space, increase_expout_size): Replace
7572         "parser_state" with "expr_builder".
7573         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7574         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7575         "parser_state" with "expr_builder".
7576
7577 2019-04-04  Tom Tromey  <tom@tromey.com>
7578
7579         * rust-exp.y: Replace "parse_language" with method call.
7580         * p-exp.y:
7581         (yylex): Replace "parse_language" with method call.
7582         * m2-exp.y:
7583         (yylex): Replace "parse_language" with method call.
7584         * go-exp.y (classify_name): Replace "parse_language" with method
7585         call.
7586         * f-exp.y (yylex): Replace "parse_language" with method call.
7587         * d-exp.y (lex_one_token): Replace "parse_language" with method
7588         call.
7589         * c-exp.y:
7590         (lex_one_token, classify_name, yylex): Replace "parse_language"
7591         with method call.
7592         * ada-exp.y (find_primitive_type, type_char)
7593         (type_system_address): Replace "parse_language" with method call.
7594
7595 2019-04-04  Tom Tromey  <tom@tromey.com>
7596
7597         * rust-exp.y: Replace "parse_gdbarch" with method call.
7598         * parse.c (write_dollar_variable, insert_type_address_space):
7599         Replace "parse_gdbarch" with method call.
7600         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7601         call.
7602         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7603         call.
7604         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7605         "parse_gdbarch" with method call.
7606         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7607         with method call.
7608         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7609         "parse_gdbarch" with method call.
7610         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7611         "parse_gdbarch" with method call.
7612         * c-exp.y (parse_type, parse_number, classify_name): Replace
7613         "parse_gdbarch" with method call.
7614         * ada-lex.l: Replace "parse_gdbarch" with method call.
7615         * ada-exp.y (parse_type, find_primitive_type, type_char)
7616         (type_system_address): Replace "parse_gdbarch" with method call.
7617
7618 2019-04-04  Tom Tromey  <tom@tromey.com>
7619
7620         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7621         * stap-probe.c (stap_parse_argument): Update.
7622         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7623         initial_size parameter.
7624         * rust-exp.y (rust_lex_tests): Update.
7625         * parse.c (parser_state): Update.
7626         (parse_exp_in_context): Update.
7627         * parser-defs.h (struct parser_state) <parser_state>: Remove
7628         "initial_size" parameter.
7629
7630 2019-04-04  Tom Tromey  <tom@tromey.com>
7631
7632         * parser-defs.h (increase_expout_size): Don't declare.
7633         * parse.c (increase_expout_size): Now static.
7634
7635 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7636
7637         * gnu-nat.c (gnu_nat_target::wait): Fix
7638         target_waitstatus_to_string call.
7639
7640 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7641
7642         * eval.c (evaluate_subexp_standard): Handle internal functions
7643         during Fortran function call handling.
7644
7645 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7646
7647         * NEWS: Mention new internal functions.
7648         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7649         (read_base_type): Use dwarf2_init_complex_target_type.
7650         * value.c (creal_internal_fn): New function.
7651         (cimag_internal_fn): New function.
7652         (_initialize_values): Register new internal functions.
7653
7654 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7655
7656         * infrun.c (stop_all_threads): If debug_infrun, always
7657         trace the wait status after wait_one, using
7658         target_waitstatus_to_string and target_pid_to_str.
7659         (handle_inferior_event): Replace various trace of
7660         wait status kind by a single trace.
7661         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7662         wait status kind image by target_waitstatus_to_string.
7663         * target/waitstatus.c (target_waitstatus_to_string): Fix
7664         obsolete comment.
7665
7666 2019-04-01  Tom Tromey  <tromey@adacore.com>
7667
7668         PR symtab/23331:
7669         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7670
7671 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7672             Pedro Alves  <palves@redhat.com>
7673
7674         * top.c (quit_force): Call 'finalize_values'.
7675         * value.c (finalize_values): New function.
7676         * value.h (finalize_values): Declare.
7677
7678 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7679
7680         * NEWS: Announce $_gdb_major and $_gdb_minor.
7681
7682         * top.c (init_gdb_version_vars): New function.
7683         (gdb_init): Call init_gdb_version_vars.
7684
7685 2019-03-29  Tom Tromey  <tromey@adacore.com>
7686
7687         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7688         help text.  Remove dead code.
7689
7690 2019-03-29  Keith Seitz  <keiths@redhat.com>
7691
7692         From Siddhesh Poyarekar:
7693         * f-lang.h (f77_get_upperbound): Return LONGEST.
7694         (f77_get_lowerbound): Likewise.
7695         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7696         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7697         print them.
7698         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7699         plongest to format print it.
7700         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7701         (f77_get_upperbound): Likewise.
7702         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7703         LOWER_BOUND to LONGEST.
7704         (f77_create_arrayprint_offset_tbl): Likewise.
7705
7706 2019-03-29  Keith Seitz  <keiths@redhat.com>
7707
7708         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7709         %s/pulongest for TYPE_LENGTH instead of %d in format
7710         strings.
7711         * ada-typerint.c (ada_print_type): Likewise.
7712         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7713         * compile/compile-c-support.c (generate_register_struct): Likewise.
7714         * gdbtypes.c (recursive_dump_type): Likewise.
7715         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7716         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7717         instead of %d in format strings.
7718         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7719         to std::min to ULONGEST.
7720         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7721         instead of %d in format strings.
7722         * tracepoint.c (info_scope_command): Likewise.
7723         * typeprint.c (print_offset_data::update)
7724         (print_offset_data::finish): Likewise.
7725         * xtensa-tdep.c (xtensa_store_return_value)
7726         (xtensa_push_dummy_call): Likewise.
7727
7728 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7729
7730         * windows-nat.c (display_selector): Fixed format specifications
7731         for 64-bit Cygwin.
7732
7733 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7734
7735         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7736
7737 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7738
7739         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7740         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7741         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7742         (nios2_linux_init_abi): Install it.
7743
7744 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7745
7746         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7747
7748 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7749
7750         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7751
7752 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7753             Tom Tromey  <tromey@adacore.com>
7754
7755         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7756
7757 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7758
7759         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7760         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7761         method to compute the bounds of range types. Also print "[evaluated]"
7762         if the bounds' values come from a dynamic evaluation.
7763
7764 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7765
7766         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7767         whitespace when pretty printing is on.
7768
7769 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7770
7771         * ppc-linux-nat.c: Add include.
7772
7773 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7774
7775         * NEWS: Mention AArch64 Pointer Authentication.
7776
7777 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7778
7779         * arm-linux-nat.c: Add include.
7780
7781 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7782
7783         * source-cache.c (source_cache::get_source_lines): Re-read
7784         fullname after calling open_source_file.
7785
7786 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7787
7788         * NEWS: Mention TLS support for FreeBSD.
7789
7790 2019-03-25  Tom Tromey  <tromey@adacore.com>
7791
7792         * minsyms.c (BUNCH_SIZE): Update comment.
7793         (~minimal_symbol_reader): Remove old comment.
7794         (compact_minimal_symbols): Update comment.
7795         (minimal_symbol_reader::install): Remove old comment.  Update
7796         other comments.
7797
7798 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7799
7800         * s390-linux-nat.c: Add include.
7801
7802 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7803
7804         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7805         Call linux_get_hwcap.
7806         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7807         Likewise.
7808         (aarch64_linux_get_hwcap): Remove function.
7809         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7810         declaration.
7811         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7812         linux_get_hwcap.
7813         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7814         * linux-tdep.c (linux_get_hwcap): Add function.
7815         (linux_get_hwcap2): Likewise.
7816         * linux-tdep.h (linux_get_hwcap): Add declaration.
7817         (linux_get_hwcap2): Likewise.
7818         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7819         (ppc_linux_get_hwcap2): Likewise.
7820         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7821         linux_get_hwcap.
7822         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7823         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7824         (ppc_linux_nat_target::read_description): Likewise.
7825         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7826         * s390-linux-nat.c: Likewise.
7827         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7828
7829 2019-03-24  Tom Tromey  <tom@tromey.com>
7830
7831         * ada-lang.c (standard_lookup): Simplify initialization.
7832         (ada_lookup_symbol_nonlocal): Simplify return.
7833         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7834         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7835         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7836         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7837         initialization.
7838         * solib.c (solib_global_lookup): Simplify.
7839         * symtab.c (null_block_symbol): Remove.
7840         (symbol_cache_lookup): Simplify returns.
7841         (lookup_language_this): Simplify returns.
7842         (lookup_symbol_aux): Simplify return.
7843         (lookup_local_symbol): Simplify returns.
7844         (lookup_global_symbol_from_objfile): Simplify return.
7845         (lookup_symbol_in_objfile_symtabs)
7846         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7847         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7848         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7849         * cp-namespace.c (cp_lookup_bare_symbol)
7850         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7851         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7852         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7853         (cp_lookup_symbol_via_imports): Simplify initialization.
7854         (find_symbol_in_baseclass): Likewise.
7855         * symtab.h (null_block_symbol): Remove.
7856         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7857         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7858         (d_lookup_symbol_module): Likewise.
7859         (find_symbol_in_baseclass): Simplify initialization.
7860
7861 2019-03-24  Tom Tromey  <tom@tromey.com>
7862
7863         * expression.h: Don't include symtab.h.
7864         (struct block): Forward declare.
7865
7866 2019-03-24  Tom Tromey  <tom@tromey.com>
7867
7868         * c-exp.y (typebase): Remove casts.
7869         * gdbtypes.c (lookup_unsigned_typename, )
7870         (lookup_signed_typename): Remove cast.
7871         * eval.c (parse_to_comma_and_eval): Remove cast.
7872         * parse.c (write_dollar_variable): Remove cast.
7873         * block.h (struct block) <superblock>: Now const.
7874         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7875         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7876         (map_block): Make "block" const.
7877         * symfile.h (struct quick_symbol_functions)
7878         <map_matching_symbols>: Constify block argument to "callback".
7879         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7880         const.
7881         (find_pc_sect_compunit_symtab): Make "b" const.
7882         (find_symbol_at_address): Likewise.
7883         (search_symbols): Likewise.
7884         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7885         (dw2_debug_names_lookup_symbol): Likewise.
7886         (dw2_map_matching_symbols): Update.
7887         * p-valprint.c (pascal_val_print): Remove "block".
7888         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7889         (aux_add_nonlocal_symbols): Make "block" const.
7890         (resolve_subexp): Remove cast.
7891         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7892         const.
7893         (iterate_over_file_blocks): Likewise.
7894         * f-exp.y (%union) <bval>: Remove.
7895         * coffread.c (patch_opaque_types): Make "b" const.
7896         * spu-tdep.c (spu_catch_start): Make "block" const.
7897         * c-valprint.c (print_unpacked_pointer): Remove "block".
7898         * symmisc.c (dump_symtab_1): Make "b" const.
7899         (block_depth): Make "block" const.
7900         * d-exp.y (%union) <bval>: Remove.
7901         * cp-support.h (cp_lookup_rtti_type): Update.
7902         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7903         * psymtab.c (psym_lookup_symbol): Make "block" const.
7904         (maintenance_check_psymtabs): Make "b" const.
7905         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7906         (enumerate_locals, enumerate_args): Update.
7907         * python/py-symtab.c (stpy_global_block): Make "block" const.
7908         (stpy_static_block): Likewise.
7909         * inline-frame.c (block_starting_point_at): Make "new_block"
7910         const.
7911         * block.c (find_block_in_blockvector): Make return type const.
7912         (blockvector_for_pc_sect): Make "b" const.
7913         (find_block_in_blockvector): Make "b" const.
7914
7915 2019-03-23  Tom Tromey  <tom@tromey.com>
7916
7917         * varobj.c (varobj_create): Update.
7918         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7919         * printcmd.c (display_command, do_one_display): Don't reset
7920         innermost_block.
7921         * parser-defs.h (enum innermost_block_tracker_type): Move to
7922         expression.h.
7923         (innermost_block): Update comment.
7924         * parse.c (parse_exp_1): Add tracker_types parameter.
7925         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7926         tracker_types parameter.  Reset innermost_block.
7927         (parse_exp_in_context): Remove.
7928         (parse_expression_for_completion): Update.
7929         * objfiles.c (~objfile): Don't reset expression_context_block or
7930         innermost_block.
7931         * expression.h (enum innermost_block_tracker_type): Move from
7932         parser-defs.h.
7933         (parse_exp_1): Add tracker_types parameter.
7934         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7935         reset innermost_block.
7936
7937 2019-03-23  Tom Tromey  <tom@tromey.com>
7938
7939         * objfiles.h: Include bcache.h.
7940
7941 2019-03-23  Tom Tromey  <tom@tromey.com>
7942
7943         * linespec.c (get_current_search_block): Use
7944         scoped_restore_current_language.
7945         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7946
7947 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7948             Jiong Wang  <jiong.wang@arm.com>
7949
7950         * aarch64-linux-tdep.c
7951         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7952         section.
7953         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7954
7955 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7956             Jiong Wang  <jiong.wang@arm.com>
7957
7958         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7959         instructions.
7960         (aarch64_analyze_prologue_test): Add PACIASP test.
7961         (aarch64_prologue_prev_register): Unmask PC value.
7962
7963 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7964             Jiong Wang  <jiong.wang@arm.com>
7965
7966         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7967         (aarch64_dwarf2_prev_register): Unmask PC value.
7968         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7969         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7970         DW_CFA_AARCH64_negate_ra_state.
7971         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7972
7973 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7974             Jiong Wang  <jiong.wang@arm.com>
7975
7976         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7977         registers.
7978         (aarch64_pseudo_register_name): Likewise.
7979         (aarch64_pseudo_register_type): Likewise.
7980         (aarch64_pseudo_register_reggroup_p): Likewise.
7981         (aarch64_gdbarch_init): Add pauth registers.
7982         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7983         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7984         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7985         (struct gdbarch_tdep): Add regnum for ra_state.
7986
7987 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7988             Jiong Wang  <jiong.wang@arm.com>
7989
7990         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7991
7992 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7993             Jiong Wang  <jiong.wang@arm.com>
7994
7995         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7996         function.
7997         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7998         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7999         (aarch64_gdbarch_init): Add puth registers.
8000         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8001         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8002         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8003
8004 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8005             Jiong Wang  <jiong.wang@arm.com>
8006
8007         * aarch64-linux-nat.c
8008         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8009         * aarch64-linux-tdep.c
8010         (aarch64_linux_core_read_description): Likewise.
8011         (aarch64_linux_get_hwcap): New function.
8012         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8013         (aarch64_linux_get_hwcap): New declaration.
8014
8015 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8016             Jiong Wang  <jiong.wang@arm.com>
8017
8018         * aarch64-linux-nat.c
8019         (aarch64_linux_nat_target::read_description): Add pauth param.
8020         * aarch64-linux-tdep.c
8021         (aarch64_linux_core_read_description): Likewise.
8022         * aarch64-tdep.c (struct target_desc): Add in pauth.
8023         (aarch64_read_description): Add pauth param.
8024         (aarch64_gdbarch_init): Likewise.
8025         * aarch64-tdep.h (aarch64_read_description): Likewise.
8026         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8027         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8028         * features/Makefile: Add new files.
8029         * features/aarch64-pauth.c: New file.
8030         * features/aarch64-pauth.xml: New file.
8031
8032 2019-03-20  Tom Tromey  <tromey@adacore.com>
8033
8034         * infrun.c (handle_inferior_event): Rename from
8035         handle_inferior_event_1.  Create a scoped_value_mark.
8036         (handle_inferior_event): Remove.
8037
8038 2019-03-19  Tom Tromey  <tromey@adacore.com>
8039
8040         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8041         * infrun.h (print_stop_event): Add "displays" parameter.
8042         * infrun.c (print_stop_event): Add "displays" parameter.
8043
8044 2019-03-19  Pedro Alves  <palves@redhat.com>
8045
8046         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8047         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8048         to -1.  Fix TABs vs spaces.
8049         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8050         * tui/tui-out.h (tui_ui_out) Add intro comments.
8051         <m_line, m_start_of_line>: In-class initialize, and add describing
8052         comment.
8053
8054 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8055
8056         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8057         variable names.
8058         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8059
8060 2019-03-18  Pedro Alves  <palves@redhat.com>
8061             Eli Zaretskii <eliz@gnu.org>
8062
8063         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8064         m_line and m_start_of_line.
8065
8066 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8067
8068         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8069         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8070         it returns a newline.  This fixes a regression in TU mode, whereby
8071         the next line is output on the same screen line as the user input.
8072
8073 2019-03-18  Tom Tromey  <tromey@adacore.com>
8074
8075         * minsyms.c (minimal_symbol_reader::install): Remove call to
8076         obstack_blank.
8077
8078 2019-03-18  Pedro Alves  <palves@redhat.com>
8079
8080         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8081         New globals.
8082         (apply_style): New, factored out from ...
8083         (apply_ansi_escape): ... this.  Handle reverse video mode.
8084         (tui_set_reverse_mode): New function.
8085         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8086         * tui/tui-winsource.c (tui_show_source_line): Use
8087         tui_set_reverse_mode instead of setting A_STANDOUT.
8088         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8089         New setter methods.
8090
8091 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8092
8093         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8094         Handle tabs.
8095
8096 2019-03-18  Tom Tromey  <tromey@adacore.com>
8097
8098         * ada-lang.c (empty_array): Add "high" parameter.
8099         (ada_evaluate_subexp): Update.
8100
8101 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8102
8103         * unittests/string_view-selftests.c: Define
8104         _initialize_string_view_selftests unconditionally.
8105
8106 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8107
8108         PR gdb/24350
8109         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8110
8111 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8112
8113         PR gdb/24351
8114         * windows-nat.c (display_selector): Fix format specifiers.
8115
8116 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8117
8118         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8119         tui_refill_source_window instead of tui_refresh_win, to update the
8120         current execution line.  This fixes redisplay of the current line
8121         when stepping through the code with "next" or "step".
8122
8123 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8124
8125         * source-cache.c (source_cache::get_source_lines): Call
8126         find_source_lines to initialize s->nlines.  This fixes vertical
8127         scrolling of TUI source window when the DOWN arrow is pressed.
8128
8129 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8130
8131         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8132         linux-thread-db.c (_initialize_thread_db): Likewise.
8133
8134 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8135
8136         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8137         wclrtoeol in tui_show_source_line".  This reverts changes made in
8138         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8139
8140 2019-03-15  Tom Tromey  <tom@tromey.com>
8141
8142         * symtab.h (struct minimal_symbol): Derive from
8143         general_symbol_info.
8144         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8145         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8146         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8147         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8148         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8149         (MSYMBOL_SEARCH_NAME): Update.
8150         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8151         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8152         * minsyms.c (minimal_symbol_reader::record_full): Update.
8153
8154 2019-03-15  Tom Tromey  <tom@tromey.com>
8155
8156         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8157
8158 2019-03-15  Tom Tromey  <tom@tromey.com>
8159
8160         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8161         unique_xmalloc_ptr.
8162         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8163         Update.
8164         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8165         (build_minimal_symbol_hash_tables)
8166         (minimal_symbol_reader::install): Update.
8167
8168 2019-03-15  Tom Tromey  <tom@tromey.com>
8169
8170         * symtab.c (create_demangled_names_hash): Update.
8171         (symbol_set_names): Update.
8172         * objfiles.h (struct objfile_per_bfd_storage)
8173         <demangled_names_hash>: Now an htab_up.
8174         * objfiles.c (objfile_per_bfd_storage): Simplify.
8175
8176 2019-03-15  Tom Tromey  <tom@tromey.com>
8177
8178         * objfiles.h (struct objfile_per_bfd_storage): Declare
8179         destructor.
8180         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8181         New.
8182         (get_objfile_bfd_data): Use new.  Don't initialize
8183         language_of_main.
8184         (free_objfile_per_bfd_storage): Remove.
8185         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8186
8187 2019-03-15  Tom Tromey  <tom@tromey.com>
8188
8189         * symfile.c (reread_symbols): Update.
8190         * objfiles.c (objfile::objfile): Update.
8191         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8192         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8193         comment.
8194         (minimal_symbol_reader::install): Update.
8195         (terminate_minimal_symbol_table): Remove.
8196         * jit.c (jit_object_close_impl): Update.
8197
8198 2019-03-15  Tom Tromey  <tom@tromey.com>
8199
8200         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8201         initializations.
8202
8203 2019-03-15  Tom Tromey  <tom@tromey.com>
8204
8205         * objfiles.h (struct objfile_per_bfd_storage)
8206         <demangled_hash_languages>: Now a bitset.
8207         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8208         (lookup_minimal_symbol): Update.
8209
8210 2019-03-15  Tom Tromey  <tom@tromey.com>
8211
8212         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8213         Don't return the symbol.
8214         * coffread.c (record_minimal_symbol): Use record_full.
8215
8216 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8217
8218         The MS-Windows port of ncurses fails to switch to a color pair if
8219         one or both of the colors are the implicit default colors.  This
8220         change records the default colors when TUI is initialized, and
8221         then specifies them explicitly when a color pair uses the default
8222         colors.  This allows color styling in TUI mode on MS-Windows.
8223
8224         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8225         ncurses_norm_attr.
8226         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8227         colors in ncurses_norm_attr.
8228         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8229         "none", replace it with the default color recorded in
8230         ncurses_norm_attr.
8231
8232 2019-03-14  Tom Tromey  <tromey@adacore.com>
8233
8234         * source-cache.h (class source_cache) <get_source_lines>: Return
8235         std::string.
8236         * source-cache.c (source_cache::extract_lines): Handle case where
8237         first_pos==npos.  Return std::string.
8238         (source_cache::get_source_lines): Update.
8239
8240 2019-03-14  Tom Tromey  <tromey@adacore.com>
8241
8242         * NEWS: Add item for "style sources" commands.
8243         * source-cache.c (source_cache::get_source_lines): Check
8244         source_styling.
8245         * cli/cli-style.c (source_styling): New global.
8246         (_initialize_cli_style): Add "style sources" commands.
8247         (show_style_sources): New function.
8248         * cli/cli-style.h (source_styling): Declare.
8249
8250 2019-03-14  Pedro Alves  <palves@redhat.com>
8251             Tom Tromey  <tromey@adacore.com>
8252
8253         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8254         * tui/tui-winsource.c (tui_refill_source_window): New function,
8255         from...
8256         (tui_horizontal_source_scroll): ... here.  Move some logic.
8257         * cli/cli-style.c (set_style_enabled): Notify new observable.
8258         * tui/tui-hooks.c (tui_redisplay_source): New function.
8259         (tui_attach_detach_observers): Attach or detach
8260         tui_redisplay_source.
8261         * observable.h (source_styling_changed): New observable.
8262         * observable.c: Define source_styling_changed observable.
8263
8264 2019-03-13  Tom Tromey  <tromey@adacore.com>
8265
8266         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8267         (i386_gnu_nat_target::store_registers): Update.
8268         * target-debug.h (target_debug_print_std_string): New macro.
8269         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8270         * windows-tdep.c (display_one_tib): Update.
8271         * tui/tui-stack.c (tui_make_status_line): Update.
8272         * top.c (print_inferior_quit_action): Update.
8273         * thread.c (thr_try_catch_cmd): Update.
8274         (add_thread_with_info): Update.
8275         (thread_target_id_str): Update.
8276         (thr_try_catch_cmd): Update.
8277         (thread_command): Update.
8278         (thread_find_command): Update.
8279         * record-btrace.c (record_btrace_target::info_record)
8280         (record_btrace_resume_thread, record_btrace_target::resume)
8281         (record_btrace_cancel_resume, record_btrace_step_thread)
8282         (record_btrace_target::wait, record_btrace_target::wait)
8283         (record_btrace_target::wait, record_btrace_target::stop): Update.
8284         * progspace.c (print_program_space): Update.
8285         * process-stratum-target.c
8286         (process_stratum_target::thread_address_space): Update.
8287         * linux-fork.c (linux_fork_mourn_inferior)
8288         (detach_checkpoint_command, info_checkpoints_command)
8289         (linux_fork_context): Update.
8290         (linux_fork_detach): Update.
8291         (class scoped_switch_fork_info): Update.
8292         (delete_checkpoint_command): Update.
8293         * infrun.c (follow_fork_inferior): Update.
8294         (follow_fork_inferior): Update.
8295         (proceed_after_vfork_done): Update.
8296         (handle_vfork_child_exec_or_exit): Update.
8297         (follow_exec): Update.
8298         (displaced_step_prepare_throw): Update.
8299         (displaced_step_restore): Update.
8300         (start_step_over): Update.
8301         (resume_1): Update.
8302         (clear_proceed_status_thread): Update.
8303         (proceed): Update.
8304         (print_target_wait_results): Update.
8305         (do_target_wait): Update.
8306         (context_switch): Update.
8307         (stop_all_threads): Update.
8308         (restart_threads): Update.
8309         (finish_step_over): Update.
8310         (handle_signal_stop): Update.
8311         (switch_back_to_stepped_thread): Update.
8312         (keep_going_pass_signal): Update.
8313         (print_exited_reason): Update.
8314         (normal_stop): Update.
8315         * inferior.c (inferior_pid_to_str): Change return type.
8316         (print_selected_inferior): Update.
8317         (add_inferior): Update.
8318         (detach_inferior): Update.
8319         * dummy-frame.c (fprint_dummy_frames): Update.
8320         * dcache.c (dcache_info_1): Update.
8321         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8322         (btrace_fetch, btrace_clear): Update.
8323         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8324         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8325         type.
8326         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8327         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8328         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8329         * gdbarch.c, gdbarch.h: Rebuild.
8330         * gdbarch.sh (core_pid_to_str): Change return type.
8331         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8332         return type.
8333         (windows_nat_target::pid_to_str): Change return type.
8334         (windows_delete_thread): Update.
8335         (windows_nat_target::attach): Update.
8336         (windows_nat_target::files_info): Update.
8337         * target-delegates.c: Rebuild.
8338         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8339         return type.
8340         (sol_thread_target::pid_to_str): Change return type.
8341         * remote.c (class remote_target) <pid_to_str>: Change return
8342         type.
8343         (remote_target::pid_to_str): Change return type.
8344         (extended_remote_target::attach, remote_target::remote_stop_ns)
8345         (remote_target::remote_notif_remove_queued_reply)
8346         (remote_target::push_stop_reply, remote_target::disable_btrace):
8347         Update.
8348         (extended_remote_target::attach): Update.
8349         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8350         type.
8351         (gdbsim_target::pid_to_str): Change return type.
8352         * ravenscar-thread.c (struct ravenscar_thread_target)
8353         <pid_to_str>: Change return type.
8354         (ravenscar_thread_target::pid_to_str): Change return type.
8355         * procfs.c (class procfs_target) <pid_to_str>: Change return
8356         type.
8357         (procfs_target::pid_to_str): Change return type.
8358         (procfs_target::attach): Update.
8359         (procfs_target::detach): Update.
8360         (procfs_target::fetch_registers): Update.
8361         (procfs_target::store_registers): Update.
8362         (procfs_target::wait): Update.
8363         (procfs_target::files_info): Update.
8364         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8365         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8366         return type.
8367         (nto_procfs_target::pid_to_str): Change return type.
8368         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8369         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8370         return type.
8371         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8372         (exit_lwp): Update.
8373         (attach_proc_task_lwp_callback, get_detach_signal)
8374         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8375         (linux_nat_target::resume, wait_lwp, stop_callback)
8376         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8377         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8378         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8379         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8380         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8381         type.
8382         (inf_ptrace_target::attach): Update.
8383         (inf_ptrace_target::files_info): Update.
8384         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8385         type.
8386         (go32_nat_target::pid_to_str): Change return type.
8387         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8388         (gnu_nat_target::wait): Update.
8389         (gnu_nat_target::wait): Update.
8390         (gnu_nat_target::resume): Update.
8391         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8392         (fbsd_nat_target::wait): Update.
8393         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8394         type.
8395         (darwin_nat_target::attach): Update.
8396         * corelow.c (class core_target) <pid_to_str>: Change return type.
8397         (core_target::pid_to_str): Change return type.
8398         * target.c (normal_pid_to_str): Change return type.
8399         (default_pid_to_str): Likewise.
8400         (target_pid_to_str): Change return type.
8401         (target_translate_tls_address): Update.
8402         (target_announce_detach): Update.
8403         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8404         return type.
8405         (bsd_uthread_target::pid_to_str): Change return type.
8406         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8407         type.
8408         (bsd_kvm_target::pid_to_str): Change return type.
8409         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8410         return type.
8411         (aix_thread_target::pid_to_str): Change return type.
8412         * target.h (struct target_ops) <pid_to_str>: Change return type.
8413         (target_pid_to_str, normal_pid_to_str): Likewise.
8414         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8415         type.
8416         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8417         type.
8418         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8419         return type.
8420         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8421         type.
8422         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8423         type.
8424         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8425         return type.
8426
8427 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8428
8429         * NEWS: Mention that the new default MI version is 3.  Mention
8430         changes to the output of commands and events that deal with
8431         multi-location breakpoints.
8432         * breakpoint.c: Include "mi/mi-out.h".
8433         (print_one_breakpoint): Change output syntax if using MI version
8434         >= 3.
8435         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8436         New.
8437         (mi_multi_location_breakpoint_output_fixed): New.
8438         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8439         (mi_cmd_fix_multi_location_breakpoint_output): New.
8440         (mi_multi_location_breakpoint_output_fixed): New.
8441         * mi/mi-cmds.c (mi_cmds): Register command
8442         -fix-multi-location-breakpoint-output.
8443         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8444         interpreter "mi".
8445
8446 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8447
8448         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8449         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8450         instantiate mi_ui_out based on interpreter name.
8451         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8452         * mi/mi-main.c (mi_load_progress): Likewise.
8453
8454 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8455
8456         * NEWS: Combine separate "New targets" sections for 8.3.
8457
8458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8459
8460         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8461         (ppcfbsd_init_abi): Install gdbarch
8462         "fetch_tls_load_module_address" and "get_thread_local_address"
8463         methods.
8464
8465 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8466
8467         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8468         (riscv_fbsd_init_abi): Install gdbarch
8469         "fetch_tls_load_module_address" and "get_thread_local_address"
8470         methods.
8471
8472 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8473
8474         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8475         (i386fbsd_init_abi): Install gdbarch
8476         "fetch_tls_load_module_address" and "get_thread_local_address"
8477         methods.
8478
8479 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8480
8481         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8482         (amd64fbsd_init_abi): Install gdbarch
8483         "fetch_tls_load_module_address" and "get_thread_local_address"
8484         methods.
8485
8486 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8487
8488         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8489         (struct fbsd_pspace_data): New type.
8490         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8491         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8492         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8493         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8494         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8495
8496 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8497
8498         * gdbtypes.c (lookup_struct_elt): New function.
8499         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8500         * gdbtypes.h (struct struct_elt): New type.
8501         (lookup_struct_elt): New prototype.
8502
8503 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8504
8505         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8506         remove disabled code block.
8507
8508 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8509
8510         * gdbarch.sh (get_thread_local_address): New method.
8511         * gdbarch.h, gdbarch.c: Regenerate.
8512         * target.c (target_translate_tls_address): Use
8513         gdbarch_get_thread_local_address if present instead of
8514         target::get_thread_local_address.
8515
8516 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8517
8518         * target.h (target::get_thread_local_address): Update comment.
8519
8520 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8521
8522         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8523         objfile->separate_debug_objfile_backlink if not NULL.
8524
8525 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8526
8527         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8528         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8529         (amd64bsd_store_inferior_registers): Likewise.
8530         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8531         Enable segment base registers.
8532         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8533         PT_GETFSBASE and PT_GETGSBASE.
8534         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8535         PT_SETGSBASE.
8536         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8537         segment base registers.
8538         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8539
8540 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8541
8542         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8543         Update calls to i386_target_description to add 'segments'
8544         parameter.
8545         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8546         add segment base registers.
8547         * arch/i386.c (i386_create_target_description): Add 'segments'
8548         parameter to enable segment base registers.
8549         * arch/i386.h (i386_create_target_description): Likewise.
8550         * features/i386/32bit-segments.xml: New file.
8551         * features/i386/32bit-segments.c: Generate.
8552         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8553         call to i386_target_description to add 'segments' parameter.
8554         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8555         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8556         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8557         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8558         if feature is present.
8559         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8560         Add 'segments' parameter to call to i386_target_description.
8561         (i386_target_description): Add 'segments' parameter to enable
8562         segment base registers.
8563         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8564         to call to i386_target_description.
8565         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8566         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8567         Define I386_NUM_REGS.
8568         (i386_target_description): Add 'segments' parameter to enable
8569         segment base registers.
8570
8571 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8572
8573         PR/24325
8574         * source-cache.c: #undef open and close, to avoid unresolved
8575         externals during linking.
8576
8577 2019-03-12  Tom Tromey  <tromey@adacore.com>
8578
8579         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8580         const.  Add initializers.
8581         (_initialize_remote): Don't initialize ptid globals.
8582
8583 2019-03-12  Pedro Alves  <palves@redhat.com>
8584
8585         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8586
8587 2019-03-12  Pedro Alves  <palves@redhat.com>
8588
8589         * cp-name-parser.y (main): Remove unused 'len' variable.
8590
8591 2019-03-12  Tom Tromey  <tromey@adacore.com>
8592
8593         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8594         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8595
8596 2019-03-12  Tom Tromey  <tromey@adacore.com>
8597
8598         * linux-nat.c (iterate_over_lwps): Update.
8599         (stop_callback): Remove parameter.
8600         (stop_wait_callback, detach_callback, resume_set_callback)
8601         (select_singlestep_lwp_callback, set_ignore_sigint)
8602         (status_callback, resumed_callback, resume_clear_callback)
8603         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8604         data parameter.
8605         (linux_nat_target::detach, linux_nat_target::resume)
8606         (linux_stop_and_wait_all_lwps, select_event_lwp)
8607         (linux_nat_filter_event, linux_nat_wait_1)
8608         (linux_nat_target::kill, linux_nat_target::stop)
8609         (linux_nat_target::stop): Update.
8610         (linux_nat_resume_callback): Change type.
8611         (resume_stopped_resumed_lwps, count_events_callback)
8612         (select_event_lwp_callback): Likewise.
8613         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8614         * arm-linux-nat.c (struct update_registers_data): Remove.
8615         (update_registers_callback): Change type.
8616         (arm_linux_insert_hw_breakpoint1): Update.
8617         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8618         parameter.
8619         (x86_linux_dr_set_addr): Update.
8620         (x86_linux_dr_set_control): Update.
8621         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8622         (iterate_over_lwps): Use gdb::function_view.
8623         * nat/aarch64-linux-hw-point.c (struct
8624         aarch64_dr_update_callback_param): Remove.
8625         (debug_reg_change_callback): Change type.
8626         (aarch64_notify_debug_reg_change): Update.
8627         * s390-linux-nat.c (s390_refresh_per_info): Update.
8628
8629 2019-03-11  Tom Tromey  <tromey@adacore.com>
8630
8631         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8632         redundant assignment to "this_cu".
8633
8634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8635
8636         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8637
8638 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8639
8640         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8641         from...
8642         (rank_one_type): ... this.
8643
8644 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8645
8646         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8647         from...
8648         (rank_one_type): ... this.
8649
8650 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8651
8652         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8653         from...
8654         (rank_one_type): ... this.
8655
8656 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8657
8658         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8659         from...
8660         (rank_one_type): ... this.
8661
8662 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8663
8664         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8665         from...
8666         (rank_one_type): ... this.
8667
8668 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8669
8670         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8671         from...
8672         (rank_one_type): ... this.
8673
8674 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8675
8676         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8677         from...
8678         (rank_one_type): ... this.
8679
8680 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8681
8682         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8683         from...
8684         (rank_one_type): ... this.
8685
8686 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8687
8688         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8689         from...
8690         (rank_one_type): ... this.
8691
8692 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8693
8694         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8695         from...
8696         (rank_one_type): ... this.
8697
8698 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8699
8700         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8701         from...
8702         (rank_one_type): ... this.
8703
8704 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8705
8706         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8707         from...
8708         (rank_one_type): ... this.
8709
8710 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8711
8712         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8713         inferior-events' shows the example events.
8714
8715 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8716
8717         Support styling on native MS-Windows console
8718
8719         PR/24315
8720         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8721         on MS-Windows if $TERM is not defined.
8722
8723         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8724
8725         * posix-hdep.c (gdb_console_fputs):
8726         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8727         functions.
8728         * ui-file.h (gdb_console_fputs): Add prototype.
8729
8730         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8731         back to fputs only if the former returns zero.
8732
8733 2019-03-07  Tom Tromey  <tom@tromey.com>
8734
8735         * symmisc.c (print_symbol_bcache_statistics): Update.
8736         (print_objfile_statistics): Update.
8737         * symfile.c (allocate_symtab): Update.
8738         * stabsread.c: Don't include bcache.h.
8739         * psymtab.h (struct psymbol_bcache): Don't declare.
8740         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8741         (psymbol_bcache_init, psymbol_bcache_free)
8742         (psymbol_bcache_get_bcache): Don't declare.
8743         * psymtab.c (struct psymbol_bcache): Remove.
8744         (psymtab_storage::psymtab_storage): Update.
8745         (psymtab_storage::~psymtab_storage): Update.
8746         (psymbol_bcache_init, psymbol_bcache_free)
8747         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8748         (add_psymbol_to_bcache): Update.
8749         (allocate_psymtab): Update.
8750         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8751         macro_cache>: No longer pointers.
8752         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8753         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8754         * macrotab.c (macro_bcache): Update.
8755         * macroexp.c: Don't include bcache.h.
8756         * gdbtypes.c (check_types_worklist): Update.
8757         (types_deeply_equal): Remove TRY/CATCH.  Update.
8758         * elfread.c (elf_symtab_read): Update.
8759         * dwarf2read.c: Don't include bcache.h.
8760         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8761         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8762         (print_bcache_statistics, bcache_memory_used): Don't declare.
8763         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8764         methods.  Rename all data members.
8765         * bcache.c (struct bcache): Move to bcache.h.
8766         (bcache::expand_hash_table): Rename from expand_hash_table.
8767         (bcache): Remove.
8768         (bcache::insert): Rename from bcache_full.
8769         (bcache::compare): Rename from bcache_compare.
8770         (bcache_xmalloc): Remove.
8771         (bcache::~bcache): Rename from bcache_xfree.
8772         (bcache::print_statistics): Rename from print_bcache_statistics.
8773         (bcache::memory_used): Rename from bcache_memory_used.
8774
8775 2019-03-07  Pedro Alves  <palves@redhat.com>
8776
8777         * infrun.c (normal_stop): Also check for
8778         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8779
8780 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8781
8782         * f-lang.c (value_from_host_double): Moved to...
8783         * value.c (value_from_host_double): ...here.
8784         * value.h (value_from_host_double): Declare.
8785         * guile/scm-math.c (vlscm_convert_typed_number): Use
8786         value_from_host_double.
8787         (vlscm_convert_number): Likewise.
8788         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8789         * python/py-value.c (convert_value_from_python): Likewise.
8790
8791 2019-03-06  Tom Tromey  <tom@tromey.com>
8792
8793         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8794
8795 2019-03-06  Tom Tromey  <tom@tromey.com>
8796
8797         * utils.h (free_current_contents): Don't declare.
8798         * utils.c (free_current_contents): Remove.
8799
8800 2019-03-06  Tom Tromey  <tom@tromey.com>
8801
8802         * top.c (quit_force): Update.
8803         * main.c (captured_command_loop): Update.
8804         * common/new-op.c (operator new): Update.
8805         * common/common-exceptions.c (struct catcher)
8806         <save_cleanup_chain>: Remove member.
8807         (exceptions_state_mc_init): Update.
8808         (exception_try_scope_entry): Return nullptr.
8809         (exception_try_scope_exit, exception_rethrow)
8810         (throw_exception_sjlj, throw_exception_cxx): Update.
8811         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8812         (all_cleanups, do_cleanups, discard_cleanups)
8813         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8814         (restore_cleanups, restore_final_cleanups): Don't declare.
8815         (do_final_cleanups): Remove parameter.
8816         * common/cleanups.c (cleanup_chain, make_cleanup)
8817         (make_cleanup_dtor, all_cleanups, do_cleanups)
8818         (discard_my_cleanups, discard_cleanups)
8819         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8820         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8821         (null_cleanup): Remove.
8822         (do_final_cleanups): Remove parameter.
8823
8824 2019-03-06  Tom Tromey  <tom@tromey.com>
8825
8826         * remote.c (remote_target::remote_parse_stop_reply): Use
8827         unique_xmalloc_ptr.
8828
8829 2019-03-06  Tom Tromey  <tom@tromey.com>
8830
8831         * stabsread.c (struct stabs_field_info): Rename from field_info.
8832         <list, fnlist>: Add initializers.
8833         <obstack>: New member.
8834         (read_member_functions, read_struct_fields, read_baseclasses):
8835         Allocate on obstack.  Don't use cleanups.
8836         (read_one_struct_field, read_member_functions, read_struct_fields)
8837         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8838         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8839         (read_struct_type): Update.
8840
8841 2019-03-06  Tom Tromey  <tom@tromey.com>
8842
8843         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8844         * common/filestuff.h (make_cleanup_close): Don't declare.
8845         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8846         Remove.
8847
8848 2019-03-06  Tom Tromey  <tom@tromey.com>
8849
8850         * solib-aix.c: Use make_scope_exit.
8851
8852 2019-03-06  Tom Tromey  <tom@tromey.com>
8853
8854         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8855         Use make_scope_exit.
8856
8857 2019-03-06  Tom Tromey  <tom@tromey.com>
8858
8859         * solib-svr4.c (disable_probes_interface): Remove parameter.
8860         (svr4_handle_solib_event): Use make_scope_exit.
8861
8862 2019-03-06  Tom Tromey  <tom@tromey.com>
8863
8864         * remote.c (struct stop_reply_deleter): Remove.
8865         (stop_reply_up): Update.
8866         (struct stop_reply): Derive from notif_event.  Don't typedef.
8867         <regcache>: Now a std::vector.
8868         (stop_reply_xfree): Remove.
8869         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8870         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8871         (remote_target::discard_pending_stop_replies): Use delete.
8872         (remote_target::remote_parse_stop_reply): Update.
8873         (remote_target::process_stop_reply): Update.
8874         * remote-notif.h (struct notif_event): Add virtual destructor.
8875         Remove "dtr" member.
8876         (struct notif_client) <alloc_event>: Return a unique_ptr.
8877         (notif_event_xfree): Don't declare.
8878         (notif_event_up): New typedef.
8879         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8880         (notif_event_xfree, do_notif_event_xfree): Remove.
8881         (remote_notif_state_xfree): Update.
8882
8883 2019-03-06  Tom Tromey  <tom@tromey.com>
8884
8885         * infrun.c (displaced_step_clear_cleanup): Now a
8886         forward_scope_exit type.
8887         (displaced_step_prepare_throw): Update.
8888         (displaced_step_fixup): Update.
8889
8890 2019-03-06  Tom Tromey  <tom@tromey.com>
8891
8892         * inferior.h (class inferior): Update comment.
8893         * gdbthread.h (class thread_info): Update comment.
8894
8895 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8896             Tom Tromey  <tom@tromey.com>
8897
8898         * stabsread.h (struct stab_section_list): Remove.
8899         (coffstab_build_psymtabs): Update.
8900         * dbxread.c (symbuf_sections): Now a std::vector.
8901         (sect_idx): New global.
8902         (fill_symbuf): Update.
8903         (coffstab_build_psymtabs): Change type of stabsects parameter.
8904         Update.
8905         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8906         std::vector.
8907         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8908         (coff_locate_sections): Update.
8909         (coff_symfile_read): Remove cleanups.  Update.
8910         (init_stringtab): Add storage parameter.
8911         (free_stringtab, free_stringtab_cleanup): Remove.
8912         (init_lineno): Add storage parameter.
8913         (free_linetab, free_linetab_cleanup): Remove.
8914
8915 2019-03-06  Pedro Alves  <palves@redhat.com>
8916
8917         * linux-fork.c (fork_info::clobber_regs): Delete.
8918         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8919         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8920         comment.  Adjust.
8921         (scoped_switch_fork_info::scoped_switch_fork_info)
8922         (checkpoint_command, linux_fork_context): Adjust
8923         fork_save_infrun_state calls.
8924
8925 2019-03-06  Pedro Alves  <palves@redhat.com>
8926
8927         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8928         (inf_has_multiple_threads): Return 'bool' and rewrite using
8929         inferior_info::threads().
8930
8931 2019-03-06  Pedro Alves  <palves@redhat.com>
8932
8933         * linux-fork.c: Include <list>.
8934         (fork_list): Now a std::list instance.
8935         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8936         (forks_exist_p, find_last_fork): Adjust.
8937         (new_fork): Delete.
8938         (one_fork_p): New.
8939         (add_fork): Adjust.
8940         (free_fork): Delete, folded into fork_info::~fork_info().
8941         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8942         Adjust.
8943         (init_fork_list): Delete.
8944         (linux_fork_killall, linux_fork_mourn_inferior)
8945         (linux_fork_detach, info_checkpoints_command): Adjust.
8946         (_initialize_linux_fork): No longer call init_fork_list.
8947
8948 2019-03-06  Pedro Alves  <palves@redhat.com>
8949
8950         * linux-fork.c (new_fork): New, split out of ...
8951         (add_fork): ... this.  Return void.  Move "first fork" special
8952         case from here, to ...
8953         (checkpoint_command): ... here.
8954         * linux-linux.h (add_fork): Return void.
8955
8956 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8957
8958         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8959
8960 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8961             Chris January  <chris.january@arm.com>
8962             David Lecomber  <david.lecomber@arm.com>
8963
8964         * f-exp.y: New token, UNOP_INTRINSIC.
8965         (exp): New pattern using UNOP_INTRINSIC token.
8966         (f77_keywords): Add 'abs' keyword.
8967         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8968         (value_from_host_double): New function.
8969         (evaluate_subexp_f): Support UNOP_ABS.
8970
8971 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8972
8973         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8974         types.
8975
8976 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8977
8978         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8979         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8980         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8981
8982 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8983
8984         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8985
8986 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8987             Chris January  <chris.january@arm.com>
8988
8989         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8990         * f-exp.y: Define 'KIND' token.
8991         (exp): New pattern for KIND expressions.
8992         (ptype): Handle types with a kind extension.
8993         (direct_abs_decl): Extend to spot kind extensions.
8994         (f77_keywords): Add 'kind' to the list.
8995         (push_kind_type): New function.
8996         (convert_to_kind_type): New function.
8997         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8998         * parse.c (operator_length_standard): Likewise.
8999         * parser-defs.h (enum type_pieces): Add tp_kind.
9000         * std-operator.def: Add UNOP_KIND.
9001
9002 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9003
9004         * f-exp.y (f_parse): Set yydebug.
9005
9006 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9007
9008         * f-lang.c (evaluate_subexp_f): New function.
9009         (exp_descriptor_f): New global.
9010         (f_language_defn): Use exp_descriptor_f instead of
9011         exp_descriptor_standard.
9012
9013 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9014
9015         * f-exp.y (struct token): Add comments.
9016         (dot_ops): Remove uppercase versions and the end marker.
9017         (f77_keywords): Likewise.
9018         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9019         entries in the dot_ops array are case insensitive, and use
9020         strncasecmp to compare strings.  Also some whitespace cleanup in
9021         this area.  Similar for the f77_keywords array, except entries in
9022         this list might be case sensitive.
9023
9024 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9025
9026         * f-exp.y (struct f77_boolean_val): Add comments.
9027         (boolean_values): Remove uppercase versions, and end marker.
9028         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9029         and use strncasecmp to achieve case insensitivity.  Additionally,
9030         perform whitespace cleanup around this code.
9031
9032 2019-03-06  Tom Tromey  <tromey@adacore.com>
9033
9034         * remote-sim.c (gdbsim_target_open): Use result of
9035         gdb_argv::release.
9036
9037 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9038         Dirk Schubert  <dirk.schubert@arm.com>
9039         Chris January  <chris.january@arm.com>
9040
9041         * eval.c (evaluate_subexp_standard): Call Fortran argument
9042         wrapping logic.
9043         * f-lang.c (struct value): A value which can be passed into a
9044         Fortran function call.
9045         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9046         where appropriate.
9047         (struct type): Value ready for a Fortran function call.
9048         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9049         is needed.
9050         * f-lang.h (fortran_argument_convert): Declaration.
9051         (fortran_preserve_arg_pointer): Declaration.
9052         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9053
9054 2019-03-05  Tom Tromey  <tromey@adacore.com>
9055
9056         * python/py-prettyprint.c (print_string_repr): Remove #if.
9057         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9058
9059 2019-03-05  Tom Tromey  <tromey@adacore.com>
9060
9061         * target.c (the_dummy_target): Move later.  Change type to
9062         "dummy_target".
9063         (initialize_targets): Don't initialize the_dummy_target.
9064
9065 2019-03-05  Tom Tromey  <tromey@adacore.com>
9066
9067         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9068         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9069
9070 2019-03-05  Tom Tromey  <tromey@adacore.com>
9071
9072         * windows-nat.c (windows_nat_target::attach)
9073         (windows_nat_target::detach): Don't call gdb_flush.
9074         * valprint.c (generic_val_print, val_print, val_print_string):
9075         Don't call gdb_flush.
9076         * utils.c (defaulted_query): Don't call gdb_flush.
9077         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9078         * target.c (target_announce_detach): Don't call gdb_flush.
9079         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9080         * remote.c (extended_remote_target::attach): Don't call
9081         gdb_flush.
9082         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9083         * printcmd.c (do_examine): Don't call gdb_flush.
9084         (info_display_command): Don't call gdb_flush.
9085         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9086         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9087         * memattr.c (info_mem_command): Don't call gdb_flush.
9088         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9089         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9090         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9091         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9092         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9093         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9094         (gnu_nat_target::detach): Don't call gdb_flush.
9095         * f-valprint.c (f_val_print): Don't call gdb_flush.
9096         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9097         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9098         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9099         gdb_flush.
9100         * c-valprint.c (c_val_print): Don't call gdb_flush.
9101         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9102
9103 2019-03-05  Tom Tromey  <tromey@adacore.com>
9104
9105         * varobj.c (update_dynamic_varobj_children): Update.
9106         (install_default_visualizer): Use reset, not release.
9107         * value.c (set_internalvar): Update.
9108         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9109         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9110         ATTRIBUTE_UNUSED_RESULT.
9111
9112 2019-03-05  Tom Tromey  <tromey@adacore.com>
9113
9114         * remote.c (class scoped_remote_fd) <release>: Add
9115         ATTRIBUTE_UNUSED_RESULT.
9116
9117 2019-03-05  Tom Tromey  <tromey@adacore.com>
9118
9119         * macroexp.c (struct macro_buffer) <release>: Add
9120         ATTRIBUTE_UNUSED_RESULT.
9121
9122 2019-03-05  Tom Tromey  <tromey@adacore.com>
9123
9124         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9125         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9126         ATTRIBUTE_UNUSED_RESULT.
9127
9128 2019-03-05  Tom Tromey  <tromey@adacore.com>
9129
9130         * common/scoped_fd.h (class scoped_fd) <release>: Add
9131         ATTRIBUTE_UNUSED_RESULT.
9132
9133 2019-03-05  Tom Tromey  <tromey@adacore.com>
9134
9135         * parser-defs.h (struct parser_state) <release>: Add
9136         ATTRIBUTE_UNUSED_RESULT.
9137
9138 2019-03-05  Tom Tromey  <tromey@adacore.com>
9139
9140         * utils.h (class gdb_argv) <release>: Add
9141         ATTRIBUTE_UNUSED_RESULT.
9142         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9143
9144 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9145
9146         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9147         for-loop range, to avoid compiler warnings.
9148
9149         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9150         avoid compiler warnings about unused variables.
9151
9152         * NEWS: Mention end of support for native debugging on MS-Windows
9153         before XP.
9154
9155         PR gdb/24292
9156         * common/netstuff.c:
9157         * gdbserver/gdbreplay.c
9158         * gdbserver/remote-utils.c:
9159         * ser-tcp.c:
9160         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9161         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9162         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9163         'getaddrinfo' and 'freeaddrinfo' were not available before
9164         Windows XP, and mingw.org's MinGW headers by default define
9165         _WIN32_WINNT to 0x500.
9166
9167 2019-03-01  Gary Benson <gbenson@redhat.com>
9168
9169         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9170
9171 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9172             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9173
9174         PR gdb/8527
9175         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9176         set_sigint_trap, clear_sigint_trap.
9177
9178 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9179
9180         * target.c (target_detach): Clear the regcache and the
9181         frame cache.
9182
9183 2019-02-27  Pedro Alves  <palves@redhat.com>
9184
9185         * utils.c (set_screen_size): When we cap the height/width sizes,
9186         tweak the corresponding command variable to show "unlimited":
9187
9188 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9189             Pedro Alves  <palves@redhat.com>
9190
9191         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9192         before calling rl_set_screen_size.
9193
9194 2019-02-27  Tom Tromey  <tromey@adacore.com>
9195
9196         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9197         define.
9198         * python/py-value.c: Remove Python 2.4 workaround.
9199         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9200         workaround.
9201         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9202         Python 2.4 workaround.
9203         * python/python-internal.h: Remove Python 2.4 comment.
9204         (Py_ssize_t): Don't define.
9205         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9206         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9207         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9208         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9209         * python/python.c (do_start_initialization): Remove Python 2.4
9210         workaround.
9211         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9212         (print_children): Remove Python 2.4 workaround.
9213         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9214         workaround.
9215         (CHARBUFFERPROC_NAME): Remove.
9216         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9217         Python 2.4 workaround.
9218
9219 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9220
9221         * NEWS: Note minimum Python version.
9222
9223 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9224
9225         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9226         code from these functions.  Remove corresponding ifdefs.  Use
9227         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9228         Remove gotos and target of gotos.
9229         (infpy_search_memory): Likewise.
9230
9231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9232
9233         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9234         (hppa_gdbarch_init): Don't register deleted functions with
9235         gdbarch.
9236
9237 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9238
9239         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9240         (h8300_unwind_sp): Delete.
9241         (h8300_dummy_id): Delete.
9242         (h8300_gdbarch_init): Don't register deleted functions with
9243         gdbarch.
9244
9245 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9246
9247         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9248         (ft32_unwind_pc): Delete.
9249         (ft32_unwind_sp): Delete.
9250         (ft32_gdbarch_init): Don't register deleted functions with
9251         gdbarch.
9252
9253 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9254
9255         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9256         (frv_unwind_pc): Delete.
9257         (frv_unwind_sp): Delete.
9258         (frv_gdbarch_init): Don't register deleted functions with
9259         gdbarch.
9260
9261 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9262
9263         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9264         (riscv_unwind_pc): Delete.
9265         (riscv_unwind_sp): Delete.
9266         (riscv_gdbarch_init): Don't register deleted functions with
9267         gdbarch.
9268
9269 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9270
9271         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9272         (csky_unwind_pc): Delete.
9273         (csky_unwind_sp): Delete.
9274         (csky_gdbarch_init): Don't register deleted functions with
9275         gdbarch.
9276
9277 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9278
9279         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9280         (cris_unwind_pc): Delete.
9281         (cris_unwind_sp): Delete.
9282         (cris_gdbarch_init): Don't register deleted functions with
9283         gdbarch.
9284
9285 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9286
9287         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9288         (bfin_unwind_pc): Delete.
9289         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9290
9291 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9292
9293         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9294         (arm_unwind_pc): Delete.
9295         (arm_unwind_sp): Delete.
9296         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9297
9298 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9299
9300         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9301         (arc_unwind_pc): Delete.
9302         (arc_unwind_sp): Delete.
9303         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9304
9305 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9306
9307         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9308         (alpha_unwind_pc): Delete.
9309         (alpha_gdbarch_init): Don't register deleted functions with
9310         gdbarch.
9311
9312 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9315         (aarch64_unwind_pc): Delete.
9316         (aarch64_unwind_sp): Delete.
9317         (aarch64_gdbarch_init): Don't register deleted functions with
9318         gdbarch.
9319
9320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * gdbtypes.c (type_align): Don't consider static members when
9323         computing structure alignment.
9324
9325 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9326
9327         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9328         return 0 for other types.
9329         * arch-utils.c (default_type_align): Always return 0.
9330         * gdbarch.h: Regenerate.
9331         * gdbarch.sh (type_align): Extend comment.
9332         * gdbtypes.c (type_align): Add additional comments, always call
9333         gdbarch_type_align before applying the default rules.
9334         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9335         generic code will then apply a suitable default.
9336         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9337         types, return 0 for other types.
9338
9339 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9340
9341         * NEWS: Create a new section for the next release branch.
9342         Rename the section of the current branch, now that it has
9343         been cut.
9344
9345 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9346
9347         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9348         * version.in: Bump version to 8.3.50.DATE-git.
9349
9350 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9351
9352         * aix-thread.c (ptid_cmp): Remove unused variable.
9353         (get_signaled_thread): Likewise.
9354         (store_regs_user_thread): Likewise.
9355         (store_regs_kernel_thread): Likewise.
9356         (fetch_regs_kernel_thread): Remove shadowed variable.
9357
9358 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9359
9360         * features/riscv/32bit-cpu.xml: Add register numbers.
9361         * features/riscv/32bit-fpu.c: Regenerate.
9362         * features/riscv/32bit-fpu.xml: Add register numbers.
9363         * features/riscv/64bit-cpu.xml: Add register numbers.
9364         * features/riscv/64bit-fpu.c: Regenerate.
9365         * features/riscv/64bit-fpu.xml: Add register numbers.
9366
9367 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9368
9369         * NEWS: Mention two argument form of gdb.Value constructor.
9370         * python/py-value.c (convert_buffer_and_type_to_value): New
9371         function.
9372         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9373         Add support for handling an optional second argument.  Call
9374         convert_buffer_and_type_to_value as appropriate.
9375         * python/python-internal.h (Py_buffer_deleter): New struct.
9376         (Py_buffer_up): New typedef.
9377
9378 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9379
9380         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9381         instead of releasing ownership.
9382
9383 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9384
9385         * dwarf2read.c (open_and_init_dwp_file): Call
9386         elf_numsections instead of bfd_count_sections to initialize
9387         dwp_file->num_sections.
9388
9389 2019-02-25  Tom Tromey  <tromey@adacore.com>
9390
9391         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9392
9393 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9394
9395         * gcore.in: Add '--readnever' option when invoking GDB.
9396
9397 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9398
9399         * MAINTAINERS: Update my email address.
9400
9401 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9402
9403         * build-id.c (build_id_to_debug_bfd_1): New function.
9404         (build_id_to_debug_bfd): Look for separate debug file in
9405         sysroot.
9406
9407 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9408
9409         * gdbarch.sh: Update the copyright year range that is placed into
9410         generated files.
9411
9412 2019-02-22  Keith Seitz  <keiths@redhat.com>
9413
9414         PR symtab/23853
9415         * linespec.c (create_sals_line_offset): Search for the default
9416         symtab's filename instead of its fullname.
9417
9418 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9419
9420         * NEWS: Update style defaults.
9421
9422 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9423
9424         * main.c (captured_main_1): Disable styling in batch mode.
9425
9426 2019-02-20  Tom Tromey  <tom@tromey.com>
9427
9428         * symtab.c (symtab_symbol_info): Fix typos.
9429
9430 2019-02-20  Tom Tromey  <tromey@adacore.com>
9431
9432         * findcmd.c (_initialize_mem_search): Use upper case for
9433         metasyntactic variables.
9434
9435 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9436
9437         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9438         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9439
9440 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9441
9442         * top.h (source_file_name): Change to std::string.
9443         * top.c (source_file_name): Likewise.
9444         (command_line_input): Adjust.
9445         * cli/cli-script.c (script_from_file): Adjust.
9446
9447 2019-02-19  Tom Tromey  <tromey@adacore.com>
9448
9449         * ravenscar-thread.c
9450         (ravenscar_thread_target::update_thread_list): Don't call
9451         ada_build_task_list.
9452         * ada-lang.h (ada_build_task_list): Don't declare.
9453         * ada-tasks.c (struct ada_tasks_inferior_data)
9454         <task_list_valid_p>: Now bool.
9455         (read_known_tasks, ada_task_list_changed)
9456         (ada_tasks_invalidate_inferior_data): Update.
9457         (read_known_tasks_array): Return bool.
9458         (read_known_tasks_list): Likewise.
9459         (read_known_tasks): Return void.
9460         (ada_build_task_list): Now static.
9461
9462 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9463
9464         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9465         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9466
9467 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9468
9469         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9470         variant for ada_tasks_pspace_data_handle and
9471         ada_tasks_inferior_data_handle.
9472         (ada_tasks_pspace_data_cleanup): New function.
9473         (ada_tasks_inferior_data_cleanup): New function.
9474
9475 2019-02-17  Tom Tromey  <tom@tromey.com>
9476
9477         * macrotab.h (macro_source_fullname): Return a std::string.
9478         * macrotab.c (macro_include, check_for_redefinition)
9479         (macro_undef, macro_lookup_definition, foreach_macro)
9480         (foreach_macro_in_scope): Update.
9481         (macro_source_fullname): Return a std::string.
9482         * macrocmd.c (show_pp_source_pos): Update.
9483
9484 2019-02-17  Tom Tromey  <tom@tromey.com>
9485
9486         * macrocmd.c (show_pp_source_pos): Style the file names.
9487
9488 2019-02-17  Tom Tromey  <tom@tromey.com>
9489
9490         PR tui/24197:
9491         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9492
9493 2019-02-17  Tom Tromey  <tom@tromey.com>
9494
9495         * ada-lang.c (user_select_syms): Use filtered printing.
9496         * utils.c (wrap_style): New global.
9497         (desired_style): Remove.
9498         (emit_style_escape): Add stream parameter.
9499         (set_output_style, reset_terminal_style, prompt_for_continue):
9500         Update.
9501         (flush_wrap_buffer): Only flush gdb_stdout.
9502         (wrap_here): Set wrap_style.
9503         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9504         treat escape sequences as a character.  Change when wrap buffer is
9505         flushed.
9506         (fputs_styled): Do not set the output style when the default is
9507         requested.
9508         * ui-style.h (struct ui_file_style) <is_default>: New method.
9509         * source.c (print_source_lines_base): Emit escape sequences in one
9510         piece.
9511
9512 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9513
9514         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9515         integers and enumeration types.
9516
9517 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9518
9519         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9520         instead of lookup_symbol_in_language
9521         (do_exact_match): New function.
9522         (ada_get_symbol_name_matcher): Return do_exact_match when
9523         doing a verbatim match.
9524
9525 2019-02-15  Tom Tromey  <tromey@adacore.com>
9526
9527         * ravenscar-thread.c (ravenscar_thread_target::resume)
9528         (ravenscar_thread_target::wait): Special case wildcard requests.
9529
9530 2019-02-15  Tom Tromey  <tromey@adacore.com>
9531
9532         * ravenscar-thread.c (base_ptid): Remove.
9533         (struct ravenscar_thread_target) <close>: New method.
9534         <m_base_ptid>: New member.
9535         <update_inferior_ptid, active_task, task_is_currently_active,
9536         runtime_initialized>: Declare methods.
9537         <ravenscar_thread_target>: Add constructor.
9538         (ravenscar_thread_target::task_is_currently_active)
9539         (ravenscar_thread_target::update_inferior_ptid)
9540         (ravenscar_runtime_initialized): Rename.  Now methods.
9541         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9542         (ravenscar_thread_target::update_thread_list): Update.
9543         (ravenscar_thread_target::active_task): Now method.
9544         (ravenscar_thread_target::store_registers)
9545         (ravenscar_thread_target::prepare_to_store)
9546         (ravenscar_thread_target::prepare_to_store)
9547         (ravenscar_thread_target::mourn_inferior): Update.
9548         (ravenscar_inferior_created): Use "new" to create target.
9549         (ravenscar_thread_target::get_ada_task_ptid): Update.
9550         (_initialize_ravenscar): Don't initialize base_ptid.
9551         (ravenscar_ops): Remove global.
9552
9553 2019-02-15  Tom Tromey  <tromey@adacore.com>
9554
9555         * target.h (push_target): Declare new overload.
9556         * target.c (push_target): New overload, taking an rvalue reference.
9557         * remote.c (remote_target::open_1): Use push_target overload.
9558         * corelow.c (core_target_open): Use push_target overload.
9559
9560 2019-02-15  Tom Tromey  <tromey@adacore.com>
9561
9562         * ravenscar-thread.c (is_ravenscar_task)
9563         (ravenscar_task_is_currently_active): Return bool.
9564         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9565         (_initialize_ravenscar): Remove "(void)".
9566         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9567         Return bool.
9568
9569 2019-02-15  Tom Tromey  <tromey@adacore.com>
9570
9571         * ravenscar-thread.c (ravenscar_runtime_initializer)
9572         (has_ravenscar_runtime, get_running_thread_id)
9573         (ravenscar_thread_target::resume): Fix indentation.
9574
9575 2019-02-15  Tom Tromey  <tromey@adacore.com>
9576
9577         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9578         from ravenscar_arch_ops.
9579         (sparc_ravenscar_ops::fetch_registers)
9580         (sparc_ravenscar_ops::store_registers): Now methods.
9581         (sparc_ravenscar_prepare_to_store): Remove.
9582         (sparc_ravenscar_ops): Redefine.
9583         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9584         methods and destructor.  Remove members.
9585         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9586         (ravenscar_thread_target::store_registers)
9587         (ravenscar_thread_target::prepare_to_store): Update.
9588         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9589         Remove.
9590         (struct ppc_ravenscar_powerpc_ops): Derive from
9591         ravenscar_arch_ops.
9592         (ppc_ravenscar_powerpc_ops::fetch_registers)
9593         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9594         (ppc_ravenscar_powerpc_ops): Redefine.
9595         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9596         (ppc_ravenscar_e500_ops::fetch_registers)
9597         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9598         (ppc_ravenscar_e500_ops): Redefine.
9599         * aarch64-ravenscar-thread.c
9600         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9601         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9602         (aarch64_ravenscar_fetch_registers)
9603         (aarch64_ravenscar_store_registers): Now methods.
9604         (aarch64_ravenscar_ops): Redefine.
9605
9606 2019-02-15  Tom Tromey  <tromey@adacore.com>
9607
9608         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9609         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9610         (ravenscar_thread_target::stopped_by_watchpoint)
9611         (ravenscar_thread_target::stopped_data_address)
9612         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9613
9614 2019-02-15  Tom Tromey  <tromey@adacore.com>
9615
9616         * ravenscar-thread.c: Fix some typos.
9617
9618 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9619             Tom Tromey  <tromey@adacore.com>
9620
9621         * ada-lang.c (ada_exception_sal): Change addr_string to a
9622         std::string.
9623         (create_ada_exception_catchpoint): Update.
9624
9625 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9626             Tom Tromey  <tromey@adacore.com>
9627
9628         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9629         (bp_location_ops): Remove.
9630         (base_breakpoint_allocate_location): Update.
9631         (free_bp_location): Update.
9632         * ada-lang.c (class ada_catchpoint_location)
9633         <ada_catchpoint_location>: Remove ops parameter.
9634         (ada_catchpoint_location_dtor): Remove.
9635         (ada_catchpoint_location_ops): Remove.
9636         (allocate_location_exception): Update.
9637         * breakpoint.h (struct bp_location_ops): Remove.
9638         (class bp_location) <bp_location>: Remove bp_location_ops
9639         parameter.
9640         <~bp_location>: Add destructor.
9641         <ops>: Remove.
9642
9643 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9644             Pedro Alves  <palves@redhat.com>
9645
9646         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9647         'PATH_MAX'.
9648
9649 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9650             Samuel Thibault  <samuel.thibault@gnu.org>
9651             Thomas Schwinge  <thomas@codesourcery.com>
9652
9653         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9654         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9655
9656 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9657
9658         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9659         (check_empty): Use "const char *".
9660
9661         * gnu-nat.c (gnu_nat_target::detach): Instead of
9662         'detach_inferior (pid)' call
9663         'detach_inferior (find_inferior_pid (pid))'.
9664
9665         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9666         'nat/fork-inferior.o'.
9667         * gnu-nat.c: #include "nat/fork-inferior.h".
9668
9669         * gnu-nat.c (gnu_nat_target::detach): Instead of
9670         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9671         * gnu-nat.h: #include "inf-child.h".
9672         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9673         'i386_gnu_nat_target::fetch_registers'.
9674         (gnu_store_registers): Rename/move to
9675         'i386_gnu_nat_target::store_registers'.
9676
9677         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9678         * gnu-nat.h (mach_thread_info): New function.
9679         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9680
9681         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9682
9683 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9684
9685         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9686
9687 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9688
9689         * windows-nat.c (windows_add_thread): Add new parameter
9690         "main_thread_p" with default value set to false.  Update
9691         function documentation as well as all callers.
9692         (windows_delete_thread): Likewise.
9693         (fake_create_process): Update call to windows_add_thread.
9694         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9695         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9696         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9697         call to windows_delete_thread.
9698
9699 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9700
9701         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9702
9703 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9704
9705         * symfile.c (find_separate_debug_file): Use canonical path of
9706         sysroot with child_path instead of gdb_sysroot if it is valid.
9707
9708 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9709
9710         * symfile.c (find_separate_debug_file): Use child_path to
9711         determine if an object file is under a sysroot.
9712
9713 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9714
9715         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9716         unittests/child-path-selftests.c.
9717         * common/pathstuff.c (child_path): New function.
9718         * common/pathstuff.h (child_path): New prototype.
9719         * unittests/child-path-selftests.c: New file.
9720
9721 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9722
9723         * symfile.c (find_separate_debug_file): Look for separate debug
9724         files in debug directories under the sysroot.
9725
9726 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9727
9728         * symtab.h (struct minimal_symbol data_p): New const method.
9729         (struct minimal_symbol text_p): Likewise.
9730         * symtab.c (output_source_filename): Use file name style
9731         to print file name.
9732         (print_symbol_info): Likewise.
9733         (print_msymbol_info): Use address style to print addresses.
9734         Use function name style to print executable text symbols.
9735         (expand_symtab_containing_pc): Use data_p.
9736         (find_pc_sect_compunit_symtab): Likewise.
9737
9738 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9739
9740         * breakpoint.c (describe_other_breakpoints): Use address style
9741         to print addresses.
9742         (say_where): Likewise.
9743
9744 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9745
9746         * ada-typeprint.c (print_func_type): Print function name
9747         style to print function name.
9748         * c-typeprint.c (c_print_type_1): Likewise.
9749
9750 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9751
9752         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9753         for execve.
9754
9755 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9756
9757         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9758         type_stack.
9759
9760 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9761
9762         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9763         TYPE_CODE_REF types.
9764
9765 2019-02-08  Jim Wilson  <jimw@sifive.com>
9766
9767         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9768         (riscv_linux_fregset): New.
9769         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9770
9771 2019-02-07  Tom Tromey  <tom@tromey.com>
9772
9773         * thread.c (thread_cancel_execution_command): Update.
9774         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9775         methods.
9776         (struct thread_fsm_ops): Remove.
9777         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9778         (thread_fsm_should_stop, thread_fsm_return_value)
9779         (thread_fsm_set_finished, thread_fsm_finished_p)
9780         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9781         Don't declare.
9782         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9783         * infrun.c (clear_proceed_status_thread)
9784         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9785         (print_stop_event): Update.
9786         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9787         Add constructor.
9788         (step_command_fsm_ops): Remove.
9789         (new_step_command_fsm): Remove.
9790         (step_1): Update.
9791         (step_command_fsm::should_stop): Rename from
9792         step_command_fsm_should_stop.
9793         (step_command_fsm::clean_up): Rename from
9794         step_command_fsm_clean_up.
9795         (step_command_fsm::do_async_reply_reason): Rename from
9796         step_command_fsm_async_reply_reason.
9797         (struct until_next_fsm): Inherit from thread_fsm.  Add
9798         constructor.
9799         (until_next_fsm_ops): Remove.
9800         (new_until_next_fsm): Remove.
9801         (until_next_fsm::should_stop): Rename from
9802         until_next_fsm_should_stop.
9803         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9804         (until_next_fsm::do_async_reply_reason): Rename from
9805         until_next_fsm_async_reply_reason.
9806         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9807         constructor.  Change type of breakpoint.
9808         (finish_command_fsm_ops): Remove.
9809         (new_finish_command_fsm): Remove.
9810         (finish_command_fsm::should_stop): Rename from
9811         finish_command_fsm_should_stop.
9812         (finish_command_fsm::clean_up): Rename from
9813         finish_command_fsm_clean_up.
9814         (finish_command_fsm::return_value): Rename from
9815         finish_command_fsm_return_value.
9816         (finish_command_fsm::do_async_reply_reason): Rename from
9817         finish_command_fsm_async_reply_reason.
9818         (finish_command): Update.
9819         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9820         Add constructor.
9821         (call_thread_fsm_ops): Remove.
9822         (call_thread_fsm::call_thread_fsm): Rename from
9823         new_call_thread_fsm.
9824         (call_thread_fsm::should_stop): Rename from
9825         call_thread_fsm_should_stop.
9826         (call_thread_fsm::should_notify_stop): Rename from
9827         call_thread_fsm_should_notify_stop.
9828         (run_inferior_call, call_function_by_hand_dummy): Update.
9829         * cli/cli-interp.c (should_print_stop_to_console): Update.
9830         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9831         Add constructor.  Change type of location_breakpoint,
9832         caller_breakpoint.
9833         (until_break_fsm_ops): Remove.
9834         (new_until_break_fsm): Remove.
9835         (until_break_fsm::should_stop): Rename from
9836         until_break_fsm_should_stop.
9837         (until_break_fsm::clean_up): Rename from
9838         until_break_fsm_clean_up.
9839         (until_break_fsm::do_async_reply_reason): Rename from
9840         until_break_fsm_async_reply_reason.
9841         (until_break_command): Update.
9842         * thread-fsm.c: Remove.
9843         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9844
9845 2019-02-07  Tom Tromey  <tom@tromey.com>
9846
9847         * yy-remap.h: Add include guard.
9848         * xtensa-tdep.h: Add include guard.
9849         * xcoffread.h: Rename include guard.
9850         * varobj-iter.h: Add include guard.
9851         * tui/tui.h: Rename include guard.
9852         * tui/tui-winsource.h: Rename include guard.
9853         * tui/tui-wingeneral.h: Rename include guard.
9854         * tui/tui-windata.h: Rename include guard.
9855         * tui/tui-win.h: Rename include guard.
9856         * tui/tui-stack.h: Rename include guard.
9857         * tui/tui-source.h: Rename include guard.
9858         * tui/tui-regs.h: Rename include guard.
9859         * tui/tui-out.h: Rename include guard.
9860         * tui/tui-layout.h: Rename include guard.
9861         * tui/tui-io.h: Rename include guard.
9862         * tui/tui-hooks.h: Rename include guard.
9863         * tui/tui-file.h: Rename include guard.
9864         * tui/tui-disasm.h: Rename include guard.
9865         * tui/tui-data.h: Rename include guard.
9866         * tui/tui-command.h: Rename include guard.
9867         * tic6x-tdep.h: Add include guard.
9868         * target/waitstatus.h: Rename include guard.
9869         * target/wait.h: Rename include guard.
9870         * target/target.h: Rename include guard.
9871         * target/resume.h: Rename include guard.
9872         * target-float.h: Rename include guard.
9873         * stabsread.h: Add include guard.
9874         * rs6000-tdep.h: Add include guard.
9875         * riscv-fbsd-tdep.h: Add include guard.
9876         * regformats/regdef.h: Rename include guard.
9877         * record.h: Rename include guard.
9878         * python/python.h: Rename include guard.
9879         * python/python-internal.h: Rename include guard.
9880         * python/py-stopevent.h: Rename include guard.
9881         * python/py-ref.h: Rename include guard.
9882         * python/py-record.h: Rename include guard.
9883         * python/py-record-full.h: Rename include guard.
9884         * python/py-record-btrace.h: Rename include guard.
9885         * python/py-instruction.h: Rename include guard.
9886         * python/py-events.h: Rename include guard.
9887         * python/py-event.h: Rename include guard.
9888         * procfs.h: Add include guard.
9889         * proc-utils.h: Add include guard.
9890         * p-lang.h: Add include guard.
9891         * or1k-tdep.h: Rename include guard.
9892         * observable.h: Rename include guard.
9893         * nto-tdep.h: Rename include guard.
9894         * nat/x86-linux.h: Rename include guard.
9895         * nat/x86-linux-dregs.h: Rename include guard.
9896         * nat/x86-gcc-cpuid.h: Add include guard.
9897         * nat/x86-dregs.h: Rename include guard.
9898         * nat/x86-cpuid.h: Rename include guard.
9899         * nat/ppc-linux.h: Rename include guard.
9900         * nat/mips-linux-watch.h: Rename include guard.
9901         * nat/linux-waitpid.h: Rename include guard.
9902         * nat/linux-ptrace.h: Rename include guard.
9903         * nat/linux-procfs.h: Rename include guard.
9904         * nat/linux-osdata.h: Rename include guard.
9905         * nat/linux-nat.h: Rename include guard.
9906         * nat/linux-namespaces.h: Rename include guard.
9907         * nat/linux-btrace.h: Rename include guard.
9908         * nat/glibc_thread_db.h: Rename include guard.
9909         * nat/gdb_thread_db.h: Rename include guard.
9910         * nat/gdb_ptrace.h: Rename include guard.
9911         * nat/fork-inferior.h: Rename include guard.
9912         * nat/amd64-linux-siginfo.h: Rename include guard.
9913         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9914         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9915         * nat/aarch64-linux.h: Rename include guard.
9916         * nat/aarch64-linux-hw-point.h: Rename include guard.
9917         * mn10300-tdep.h: Add include guard.
9918         * mips-linux-tdep.h: Add include guard.
9919         * mi/mi-parse.h: Rename include guard.
9920         * mi/mi-out.h: Rename include guard.
9921         * mi/mi-main.h: Rename include guard.
9922         * mi/mi-interp.h: Rename include guard.
9923         * mi/mi-getopt.h: Rename include guard.
9924         * mi/mi-console.h: Rename include guard.
9925         * mi/mi-common.h: Rename include guard.
9926         * mi/mi-cmds.h: Rename include guard.
9927         * mi/mi-cmd-break.h: Rename include guard.
9928         * m2-lang.h: Add include guard.
9929         * location.h: Rename include guard.
9930         * linux-record.h: Rename include guard.
9931         * linux-nat.h: Add include guard.
9932         * linux-fork.h: Add include guard.
9933         * i386-darwin-tdep.h: Rename include guard.
9934         * hppa-linux-offsets.h: Add include guard.
9935         * guile/guile.h: Rename include guard.
9936         * guile/guile-internal.h: Rename include guard.
9937         * gnu-nat.h: Rename include guard.
9938         * gdb-stabs.h: Rename include guard.
9939         * frv-tdep.h: Add include guard.
9940         * f-lang.h: Add include guard.
9941         * event-loop.h: Add include guard.
9942         * darwin-nat.h: Rename include guard.
9943         * cp-abi.h: Rename include guard.
9944         * config/sparc/nm-sol2.h: Rename include guard.
9945         * config/nm-nto.h: Rename include guard.
9946         * config/nm-linux.h: Add include guard.
9947         * config/i386/nm-i386gnu.h: Rename include guard.
9948         * config/djgpp/nl_types.h: Rename include guard.
9949         * config/djgpp/langinfo.h: Rename include guard.
9950         * compile/gcc-cp-plugin.h: Add include guard.
9951         * compile/gcc-c-plugin.h: Add include guard.
9952         * compile/compile.h: Rename include guard.
9953         * compile/compile-object-run.h: Rename include guard.
9954         * compile/compile-object-load.h: Rename include guard.
9955         * compile/compile-internal.h: Rename include guard.
9956         * compile/compile-cplus.h: Rename include guard.
9957         * compile/compile-c.h: Rename include guard.
9958         * common/xml-utils.h: Rename include guard.
9959         * common/x86-xstate.h: Rename include guard.
9960         * common/version.h: Rename include guard.
9961         * common/vec.h: Rename include guard.
9962         * common/tdesc.h: Rename include guard.
9963         * common/selftest.h: Rename include guard.
9964         * common/scoped_restore.h: Rename include guard.
9965         * common/scoped_mmap.h: Rename include guard.
9966         * common/scoped_fd.h: Rename include guard.
9967         * common/safe-iterator.h: Rename include guard.
9968         * common/run-time-clock.h: Rename include guard.
9969         * common/refcounted-object.h: Rename include guard.
9970         * common/queue.h: Rename include guard.
9971         * common/ptid.h: Rename include guard.
9972         * common/print-utils.h: Rename include guard.
9973         * common/preprocessor.h: Rename include guard.
9974         * common/pathstuff.h: Rename include guard.
9975         * common/observable.h: Rename include guard.
9976         * common/netstuff.h: Rename include guard.
9977         * common/job-control.h: Rename include guard.
9978         * common/host-defs.h: Rename include guard.
9979         * common/gdb_wait.h: Rename include guard.
9980         * common/gdb_vecs.h: Rename include guard.
9981         * common/gdb_unlinker.h: Rename include guard.
9982         * common/gdb_unique_ptr.h: Rename include guard.
9983         * common/gdb_tilde_expand.h: Rename include guard.
9984         * common/gdb_sys_time.h: Rename include guard.
9985         * common/gdb_string_view.h: Rename include guard.
9986         * common/gdb_splay_tree.h: Rename include guard.
9987         * common/gdb_setjmp.h: Rename include guard.
9988         * common/gdb_ref_ptr.h: Rename include guard.
9989         * common/gdb_optional.h: Rename include guard.
9990         * common/gdb_locale.h: Rename include guard.
9991         * common/gdb_assert.h: Rename include guard.
9992         * common/filtered-iterator.h: Rename include guard.
9993         * common/filestuff.h: Rename include guard.
9994         * common/fileio.h: Rename include guard.
9995         * common/environ.h: Rename include guard.
9996         * common/common-utils.h: Rename include guard.
9997         * common/common-types.h: Rename include guard.
9998         * common/common-regcache.h: Rename include guard.
9999         * common/common-inferior.h: Rename include guard.
10000         * common/common-gdbthread.h: Rename include guard.
10001         * common/common-exceptions.h: Rename include guard.
10002         * common/common-defs.h: Rename include guard.
10003         * common/common-debug.h: Rename include guard.
10004         * common/cleanups.h: Rename include guard.
10005         * common/buffer.h: Rename include guard.
10006         * common/btrace-common.h: Rename include guard.
10007         * common/break-common.h: Rename include guard.
10008         * cli/cli-utils.h: Rename include guard.
10009         * cli/cli-style.h: Rename include guard.
10010         * cli/cli-setshow.h: Rename include guard.
10011         * cli/cli-script.h: Rename include guard.
10012         * cli/cli-interp.h: Rename include guard.
10013         * cli/cli-decode.h: Rename include guard.
10014         * cli/cli-cmds.h: Rename include guard.
10015         * charset-list.h: Add include guard.
10016         * buildsym-legacy.h: Rename include guard.
10017         * bfin-tdep.h: Add include guard.
10018         * ax.h: Rename include guard.
10019         * arm-linux-tdep.h: Add include guard.
10020         * arm-fbsd-tdep.h: Add include guard.
10021         * arch/xtensa.h: Rename include guard.
10022         * arch/tic6x.h: Add include guard.
10023         * arch/i386.h: Add include guard.
10024         * arch/arm.h: Rename include guard.
10025         * arch/arm-linux.h: Rename include guard.
10026         * arch/arm-get-next-pcs.h: Rename include guard.
10027         * arch/amd64.h: Add include guard.
10028         * arch/aarch64-insn.h: Rename include guard.
10029         * arch-utils.h: Rename include guard.
10030         * annotate.h: Add include guard.
10031         * amd64-darwin-tdep.h: Rename include guard.
10032         * aarch64-linux-tdep.h: Add include guard.
10033         * aarch64-fbsd-tdep.h: Add include guard.
10034         * aarch32-linux-nat.h: Add include guard.
10035
10036 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10037
10038         * macrotab.c (macro_define_internal): New function that
10039         factorizes macro_define_object_internal and macro_define_function
10040         code.
10041         (macro_define_object_internal): Use macro_define_internal.
10042         (macro_define_function): Likewise.
10043
10044 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10045
10046         * macrocmd.c (extract_identifier): Return
10047         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10048         callers.
10049
10050 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10051
10052         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10053
10054 2019-02-05  Tom Tromey  <tom@tromey.com>
10055
10056         * target.c (target_stack::unpush): Move assertion earlier.
10057
10058 2019-01-30  Tom Tromey  <tom@tromey.com>
10059
10060         PR python/23615:
10061         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10062         (gdbpy_parse_and_eval): Likewise.
10063         * python/python-internal.h (gdbpy_allow_threads): New class.
10064
10065 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10066
10067         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10068         (aarch64_fbsd_fpregmap): Move earlier.
10069         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10070         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10071         instead of individual calls to trad_frame_set_reg_addr.
10072         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10073         earlier.
10074         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10075         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10076         instead of individual calls to trad_frame_set_reg_addr.
10077
10078 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10079
10080         * CONTRIBUTE: Replace contribution list with wiki link.
10081
10082 2019-01-25  Tom Tromey  <tom@tromey.com>
10083
10084         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10085
10086 2019-01-25  Tom Tromey  <tom@tromey.com>
10087
10088         * xtensa-linux-nat.c: Fix common/ includes.
10089         * xml-support.h: Fix common/ includes.
10090         * xml-support.c: Fix common/ includes.
10091         * x86-linux-nat.c: Fix common/ includes.
10092         * windows-nat.c: Fix common/ includes.
10093         * varobj.h: Fix common/ includes.
10094         * varobj.c: Fix common/ includes.
10095         * value.c: Fix common/ includes.
10096         * valops.c: Fix common/ includes.
10097         * utils.c: Fix common/ includes.
10098         * unittests/xml-utils-selftests.c: Fix common/ includes.
10099         * unittests/utils-selftests.c: Fix common/ includes.
10100         * unittests/unpack-selftests.c: Fix common/ includes.
10101         * unittests/tracepoint-selftests.c: Fix common/ includes.
10102         * unittests/style-selftests.c: Fix common/ includes.
10103         * unittests/string_view-selftests.c: Fix common/ includes.
10104         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10105         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10106         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10107         * unittests/rsp-low-selftests.c: Fix common/ includes.
10108         * unittests/parse-connection-spec-selftests.c: Fix common/
10109         includes.
10110         * unittests/optional-selftests.c: Fix common/ includes.
10111         * unittests/offset-type-selftests.c: Fix common/ includes.
10112         * unittests/observable-selftests.c: Fix common/ includes.
10113         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10114         * unittests/memrange-selftests.c: Fix common/ includes.
10115         * unittests/memory-map-selftests.c: Fix common/ includes.
10116         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10117         * unittests/function-view-selftests.c: Fix common/ includes.
10118         * unittests/environ-selftests.c: Fix common/ includes.
10119         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10120         * unittests/common-utils-selftests.c: Fix common/ includes.
10121         * unittests/cli-utils-selftests.c: Fix common/ includes.
10122         * unittests/array-view-selftests.c: Fix common/ includes.
10123         * ui-file.c: Fix common/ includes.
10124         * tui/tui-io.c: Fix common/ includes.
10125         * tracepoint.h: Fix common/ includes.
10126         * tracepoint.c: Fix common/ includes.
10127         * tracefile-tfile.c: Fix common/ includes.
10128         * top.h: Fix common/ includes.
10129         * top.c: Fix common/ includes.
10130         * thread.c: Fix common/ includes.
10131         * target/waitstatus.h: Fix common/ includes.
10132         * target/waitstatus.c: Fix common/ includes.
10133         * target.h: Fix common/ includes.
10134         * target.c: Fix common/ includes.
10135         * target-memory.c: Fix common/ includes.
10136         * target-descriptions.c: Fix common/ includes.
10137         * symtab.h: Fix common/ includes.
10138         * symfile.c: Fix common/ includes.
10139         * stap-probe.c: Fix common/ includes.
10140         * spu-linux-nat.c: Fix common/ includes.
10141         * sparc-nat.c: Fix common/ includes.
10142         * source.c: Fix common/ includes.
10143         * solib.c: Fix common/ includes.
10144         * solib-target.c: Fix common/ includes.
10145         * ser-unix.c: Fix common/ includes.
10146         * ser-tcp.c: Fix common/ includes.
10147         * ser-pipe.c: Fix common/ includes.
10148         * ser-base.c: Fix common/ includes.
10149         * selftest-arch.c: Fix common/ includes.
10150         * s12z-tdep.c: Fix common/ includes.
10151         * rust-exp.y: Fix common/ includes.
10152         * rs6000-aix-tdep.c: Fix common/ includes.
10153         * riscv-tdep.c: Fix common/ includes.
10154         * remote.c: Fix common/ includes.
10155         * remote-notif.h: Fix common/ includes.
10156         * remote-fileio.h: Fix common/ includes.
10157         * remote-fileio.c: Fix common/ includes.
10158         * regcache.h: Fix common/ includes.
10159         * regcache.c: Fix common/ includes.
10160         * record-btrace.c: Fix common/ includes.
10161         * python/python.c: Fix common/ includes.
10162         * python/py-type.c: Fix common/ includes.
10163         * python/py-inferior.c: Fix common/ includes.
10164         * progspace.h: Fix common/ includes.
10165         * producer.c: Fix common/ includes.
10166         * procfs.c: Fix common/ includes.
10167         * proc-api.c: Fix common/ includes.
10168         * printcmd.c: Fix common/ includes.
10169         * ppc-linux-nat.c: Fix common/ includes.
10170         * parser-defs.h: Fix common/ includes.
10171         * osdata.c: Fix common/ includes.
10172         * obsd-nat.c: Fix common/ includes.
10173         * nat/x86-linux.c: Fix common/ includes.
10174         * nat/x86-linux-dregs.c: Fix common/ includes.
10175         * nat/x86-dregs.h: Fix common/ includes.
10176         * nat/x86-dregs.c: Fix common/ includes.
10177         * nat/ppc-linux.c: Fix common/ includes.
10178         * nat/mips-linux-watch.h: Fix common/ includes.
10179         * nat/mips-linux-watch.c: Fix common/ includes.
10180         * nat/linux-waitpid.c: Fix common/ includes.
10181         * nat/linux-ptrace.h: Fix common/ includes.
10182         * nat/linux-ptrace.c: Fix common/ includes.
10183         * nat/linux-procfs.c: Fix common/ includes.
10184         * nat/linux-personality.c: Fix common/ includes.
10185         * nat/linux-osdata.c: Fix common/ includes.
10186         * nat/linux-namespaces.c: Fix common/ includes.
10187         * nat/linux-btrace.h: Fix common/ includes.
10188         * nat/linux-btrace.c: Fix common/ includes.
10189         * nat/fork-inferior.c: Fix common/ includes.
10190         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10191         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10192         * nat/aarch64-linux.c: Fix common/ includes.
10193         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10194         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10195         * namespace.h: Fix common/ includes.
10196         * mips-linux-tdep.c: Fix common/ includes.
10197         * minsyms.c: Fix common/ includes.
10198         * mi/mi-parse.h: Fix common/ includes.
10199         * mi/mi-main.c: Fix common/ includes.
10200         * mi/mi-cmd-env.c: Fix common/ includes.
10201         * memrange.h: Fix common/ includes.
10202         * memattr.c: Fix common/ includes.
10203         * maint.h: Fix common/ includes.
10204         * maint.c: Fix common/ includes.
10205         * main.c: Fix common/ includes.
10206         * machoread.c: Fix common/ includes.
10207         * location.c: Fix common/ includes.
10208         * linux-thread-db.c: Fix common/ includes.
10209         * linux-nat.c: Fix common/ includes.
10210         * linux-fork.c: Fix common/ includes.
10211         * inline-frame.c: Fix common/ includes.
10212         * infrun.c: Fix common/ includes.
10213         * inflow.c: Fix common/ includes.
10214         * inferior.h: Fix common/ includes.
10215         * inferior.c: Fix common/ includes.
10216         * infcmd.c: Fix common/ includes.
10217         * inf-ptrace.c: Fix common/ includes.
10218         * inf-child.c: Fix common/ includes.
10219         * ia64-linux-nat.c: Fix common/ includes.
10220         * i387-tdep.c: Fix common/ includes.
10221         * i386-tdep.c: Fix common/ includes.
10222         * i386-linux-tdep.c: Fix common/ includes.
10223         * i386-linux-nat.c: Fix common/ includes.
10224         * i386-go32-tdep.c: Fix common/ includes.
10225         * i386-fbsd-tdep.c: Fix common/ includes.
10226         * i386-fbsd-nat.c: Fix common/ includes.
10227         * guile/scm-type.c: Fix common/ includes.
10228         * guile/guile.c: Fix common/ includes.
10229         * go32-nat.c: Fix common/ includes.
10230         * gnu-nat.c: Fix common/ includes.
10231         * gdbthread.h: Fix common/ includes.
10232         * gdbarch-selftests.c: Fix common/ includes.
10233         * gdb_usleep.c: Fix common/ includes.
10234         * gdb_select.h: Fix common/ includes.
10235         * gdb_bfd.c: Fix common/ includes.
10236         * gcore.c: Fix common/ includes.
10237         * fork-child.c: Fix common/ includes.
10238         * findvar.c: Fix common/ includes.
10239         * fbsd-nat.c: Fix common/ includes.
10240         * event-top.c: Fix common/ includes.
10241         * event-loop.c: Fix common/ includes.
10242         * dwarf2read.c: Fix common/ includes.
10243         * dwarf2loc.c: Fix common/ includes.
10244         * dwarf2-frame.c: Fix common/ includes.
10245         * dwarf-index-cache.c: Fix common/ includes.
10246         * dtrace-probe.c: Fix common/ includes.
10247         * disasm-selftests.c: Fix common/ includes.
10248         * defs.h: Fix common/ includes.
10249         * csky-tdep.c: Fix common/ includes.
10250         * cp-valprint.c: Fix common/ includes.
10251         * cp-support.h: Fix common/ includes.
10252         * cp-support.c: Fix common/ includes.
10253         * corelow.c: Fix common/ includes.
10254         * completer.h: Fix common/ includes.
10255         * completer.c: Fix common/ includes.
10256         * compile/compile.c: Fix common/ includes.
10257         * compile/compile-loc2c.c: Fix common/ includes.
10258         * compile/compile-cplus-types.c: Fix common/ includes.
10259         * compile/compile-cplus-symbols.c: Fix common/ includes.
10260         * command.h: Fix common/ includes.
10261         * cli/cli-dump.c: Fix common/ includes.
10262         * cli/cli-cmds.c: Fix common/ includes.
10263         * charset.c: Fix common/ includes.
10264         * build-id.c: Fix common/ includes.
10265         * btrace.h: Fix common/ includes.
10266         * btrace.c: Fix common/ includes.
10267         * breakpoint.h: Fix common/ includes.
10268         * breakpoint.c: Fix common/ includes.
10269         * ax.h:
10270         (enum agent_op): Fix common/ includes.
10271         * ax-general.c (struct aop_map): Fix common/ includes.
10272         * ax-gdb.c: Fix common/ includes.
10273         * auxv.c: Fix common/ includes.
10274         * auto-load.c: Fix common/ includes.
10275         * arm-tdep.c: Fix common/ includes.
10276         * arch/riscv.c: Fix common/ includes.
10277         * arch/ppc-linux-common.c: Fix common/ includes.
10278         * arch/i386.c: Fix common/ includes.
10279         * arch/arm.c: Fix common/ includes.
10280         * arch/arm-linux.c: Fix common/ includes.
10281         * arch/arm-get-next-pcs.c: Fix common/ includes.
10282         * arch/amd64.c: Fix common/ includes.
10283         * arch/aarch64.c: Fix common/ includes.
10284         * arch/aarch64-insn.c: Fix common/ includes.
10285         * arch-utils.c: Fix common/ includes.
10286         * amd64-windows-tdep.c: Fix common/ includes.
10287         * amd64-tdep.c: Fix common/ includes.
10288         * amd64-sol2-tdep.c: Fix common/ includes.
10289         * amd64-obsd-tdep.c: Fix common/ includes.
10290         * amd64-nbsd-tdep.c: Fix common/ includes.
10291         * amd64-linux-tdep.c: Fix common/ includes.
10292         * amd64-linux-nat.c: Fix common/ includes.
10293         * amd64-fbsd-tdep.c: Fix common/ includes.
10294         * amd64-fbsd-nat.c: Fix common/ includes.
10295         * amd64-dicos-tdep.c: Fix common/ includes.
10296         * amd64-darwin-tdep.c: Fix common/ includes.
10297         * agent.c: Fix common/ includes.
10298         * ada-lang.h: Fix common/ includes.
10299         * ada-lang.c: Fix common/ includes.
10300         * aarch64-tdep.c: Fix common/ includes.
10301
10302 2019-01-25  Tom Tromey  <tom@tromey.com>
10303
10304         * common/create-version.sh: Use common/version.h.
10305
10306 2019-01-24  Pedro Alves  <palves@redhat.com>
10307
10308         * infrun.c (signal_stop, signal_print, signal_program)
10309         (signal_catch, signal_pass): Now arrays instead of pointers.
10310         (update_signals_program_target, do_target_resume)
10311         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10312         * linux-nat.c (linux_nat_target::pass_signals)
10313         (linux_nat_target::create_inferior, linux_nat_target::attach):
10314         Adjust.
10315         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10316         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10317         * procfs.c (procfs_target::pass_signals): Adjust.
10318         * record-full.c (record_full_target::resume): Adjust.
10319         * remote.c (remote_target::pass_signals)
10320         (remote_target::program_signals): Adjust.
10321         * target-debug.h (target_debug_print_signals): Now takes a
10322         gdb::array_view as parameter.  Adjust.
10323         * target.h (target_ops) <pass_signals, program_signals>: Replace
10324         pointer and length parameters with gdb::array_view.
10325         (target_pass_signals, target_program_signals): Likewise.
10326         * target-delegates.c: Regenerate.
10327
10328 2019-01-24  Pedro Alves  <palves@redhat.com>
10329
10330         * common/forward-scope-exit.h
10331         (forward_scope_exit::forward_scope_exit): Pass arguments to
10332         m_bind_function directly, instead of creating a std::bind and
10333         copying that.
10334
10335 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10336
10337         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10338         for static members.
10339         (pass_in_v_vfp_candidate): Likewise.
10340
10341 2019-01-23  Tom Tromey  <tom@tromey.com>
10342             Pedro Alves  <palves@redhat.com>
10343
10344         * regcache.c (class regcache_invalidator): Remove.
10345         (regcache::raw_write): Use make_scope_exit.
10346
10347 2019-01-23  Tom Tromey  <tom@tromey.com>
10348
10349         * ui-out.h (class ui_out_emit_type): Update comment.
10350
10351 2019-01-23  Tom Tromey  <tom@tromey.com>
10352
10353         * infrun.c (fetch_inferior_event): Update comment.
10354
10355 2019-01-23  Tom Tromey  <tom@tromey.com>
10356             Pedro Alves  <palves@redhat.com>
10357
10358         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10359         parameter.
10360         (fetch_inferior_event): Use SCOPE_EXIT.
10361
10362
10363 2019-01-23  Tom Tromey  <tom@tromey.com>
10364             Pedro Alves  <palves@redhat.com>
10365
10366         * infrun.c (disable_thread_events): Delete.
10367         (stop_all_threads): Use SCOPE_EXIT.
10368
10369 2019-01-23  Tom Tromey  <tom@tromey.com>
10370             Pedro Alves  <palves@redhat.com>
10371
10372         * symfile.c: Include forward-scope-exit.h.
10373         (clear_symtab_users_cleanup): Replace forward declaration with
10374         a FORWARD_SCOPE_EXIT.
10375         (syms_from_objfile_1): Use the forward_scope_exit and
10376         gdb::optional instead of cleanup_function.
10377         (reread_symbols): Use the forward_scope_exit instead of
10378         cleanup_function.
10379         (clear_symtab_users_cleanup): Remove function.
10380
10381 2019-01-23  Tom Tromey  <tom@tromey.com>
10382             Pedro Alves  <palves@redhat.com>
10383
10384         * linux-nat.c: Include scope-exit.h.
10385         (cleanup_target_stop): Remove.
10386         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10387         SCOPE_EXIT.
10388
10389 2019-01-23  Tom Tromey  <tom@tromey.com>
10390             Pedro Alves  <palves@redhat.com>
10391
10392         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10393         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10394
10395 2019-01-23  Tom Tromey  <tom@tromey.com>
10396             Andrew Burgess  <andrew.burgess@embecosm.com>
10397             Pedro Alves  <palves@redhat.com>
10398
10399         * infrun.c (fetch_inferior_event): Use scope_exit.
10400         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10401         * top.c (execute_command): Use scope_exit.
10402         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10403         * utils.c (do_bpstat_clear_actions_cleanup)
10404         (make_bpstat_clear_actions_cleanup): Remove.
10405
10406 2019-01-23  Tom Tromey  <tom@tromey.com>
10407             Pedro Alves  <palves@redhat.com>
10408
10409         * infrun.c: Include "common/scope-exit.h"
10410         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10411         (wait_for_inferior): Use SCOPE_EXIT.
10412         (fetch_inferior_event): Use scope_exit.
10413
10414 2019-01-23  Tom Tromey  <tom@tromey.com>
10415             Pedro Alves  <palves@redhat.com>
10416
10417         * breakpoint.c (create_breakpoint): Remove cleanup.
10418
10419 2019-01-23  Tom Tromey  <tom@tromey.com>
10420             Andrew Burgess  <andrew.burgess@embecosm.com>
10421             Pedro Alves  <palves@redhat.com>
10422
10423 2019-01-23  Pedro Alves  <palves@redhat.com>
10424
10425         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10426
10427 2019-01-23  Pedro Alves  <palves@redhat.com>
10428             Andrew Burgess  <andrew.burgess@embecosm.com>
10429
10430         * gdbthread.h: Include "common/forward-scope-exit.h".
10431         (scoped_finish_thread_state): Redefine custom class in terms of
10432         forward_scope_exit.
10433
10434 2019-01-23  Pedro Alves  <palves@redhat.com>
10435             Andrew Burgess  <andrew.burgess@embecosm.com>
10436
10437         * common/forward-scope-exit.h: New file.
10438
10439 2019-01-23  Pedro Alves  <palves@redhat.com>
10440             Andrew Burgess  <andrew.burgess@embecosm.com>
10441             Tom Tromey  <tom@tromey.com>
10442
10443         * common/scope-exit.h: New file.
10444
10445 2019-01-23  Pedro Alves  <palves@redhat.com>
10446
10447         * common/preprocessor.h (ESC): Rename to ...
10448         (ESC_PARENS): ... this.
10449         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10450         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10451
10452 2019-01-23  Tom Tromey  <tom@tromey.com>
10453
10454         * language.h (class scoped_switch_to_sym_language_if_auto):
10455         Initialize m_lang in both cases.
10456
10457 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10458
10459         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10460         with XCNEW.
10461
10462 2019-01-22  Tom Tromey  <tom@tromey.com>
10463
10464         * corelow.c: Do not include sys/file.h.
10465
10466 2019-01-22  Tom Tromey  <tom@tromey.com>
10467
10468         * tui/tui-wingeneral.h: Include gdb_curses.h.
10469
10470 2019-01-22  Tom Tromey  <tom@tromey.com>
10471
10472         * source-cache.h (class source_cache) <get_source_lines,
10473         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10474
10475 2019-01-22  Tom Tromey  <tom@tromey.com>
10476
10477         * remote-fileio.h (struct remote_target): Declare.
10478
10479 2019-01-22  Tom Tromey  <tom@tromey.com>
10480
10481         * python/py-arch.c: Do not include py-ref.h.
10482         * python/py-bpevent.c: Do not include py-ref.h.
10483         * python/py-cmd.c: Do not include py-ref.h.
10484         * python/py-continueevent.c: Do not include py-ref.h.
10485         * python/py-event.h: Do not include py-ref.h.
10486         * python/py-evtregistry.c: Do not include py-ref.h.
10487         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10488         * python/py-frame.c: Do not include py-ref.h.
10489         * python/py-framefilter.c: Do not include py-ref.h.
10490         * python/py-function.c: Do not include py-ref.h.
10491         * python/py-infevents.c: Do not include py-ref.h.
10492         * python/py-linetable.c: Do not include py-ref.h.
10493         * python/py-objfile.c: Do not include py-ref.h.
10494         * python/py-param.c: Do not include py-ref.h.
10495         * python/py-prettyprint.c: Do not include py-ref.h.
10496         * python/py-progspace.c: Do not include py-ref.h.
10497         * python/py-symbol.c: Do not include py-ref.h.
10498         * python/py-symtab.c: Do not include py-ref.h.
10499         * python/py-type.c: Do not include py-ref.h.
10500         * python/py-unwind.c: Do not include py-ref.h.
10501         * python/py-utils.c: Do not include py-ref.h.
10502         * python/py-value.c: Do not include py-ref.h.
10503         * python/py-varobj.c: Do not include py-ref.h.
10504         * python/py-xmethods.c: Do not include py-ref.h.
10505         * python/python.c: Do not include py-ref.h.
10506         * varobj.c: Do not include py-ref.h.
10507
10508 2019-01-22  Tom Tromey  <tom@tromey.com>
10509
10510         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10511         keyword for bcache.
10512
10513 2019-01-22  Tom Tromey  <tom@tromey.com>
10514
10515         * compile/compile-cplus-types.c: Remove a comment by #include.
10516
10517 2019-01-22  Tom Tromey  <tom@tromey.com>
10518
10519         * compile/gcc-c-plugin.h: Include compile-internal.h.
10520
10521 2019-01-22  Tom Tromey  <tom@tromey.com>
10522
10523         * stabsread.c (EXTERN): Do not define.
10524         (symnum, next_symbol_text_func, processing_gcc_compilation)
10525         (within_function, global_sym_chain, global_stabs)
10526         (previous_stab_code, this_object_header_files)
10527         (n_this_object_header_files)
10528         (n_allocated_this_object_header_files): Define.
10529         * stabsread.h (EXTERN): Never define.  Use "extern".
10530
10531 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10532
10533         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10534         history_value.
10535
10536 2019-01-21  Tom Tromey  <tom@tromey.com>
10537
10538         * ui-out.c: Fix includes.
10539         * tui/tui-source.c: Fix includes.
10540         * target.c: Fix includes.
10541         * remote.c: Fix includes.
10542         * regcache.c: Fix includes.
10543         * python/py-block.c: Fix includes.
10544         * printcmd.c: Fix includes.
10545         * or1k-tdep.c: Fix includes.
10546         * mi/mi-main.c: Fix includes.
10547         * m32r-tdep.c: Fix includes.
10548         * csky-tdep.c: Fix includes.
10549         * compile/compile-cplus-types.c: Fix includes.
10550         * cli/cli-interp.c: Fix includes.
10551
10552 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10553
10554         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10555         for padding.
10556
10557 2019-01-16  Tom Tromey  <tom@tromey.com>
10558
10559         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10560         earlier.
10561         (struct objfile) <msymbols_range>: Move from top level.
10562         <msymbols>: New method.
10563         (class objfile_msymbols): Remove.
10564         * symtab.c (default_collect_symbol_completion_matches_break_on):
10565         Update.
10566         * symmisc.c (dump_msymbols): Update.
10567         * stabsread.c (scan_file_globals): Update.
10568         * objc-lang.c (info_selectors_command, info_classes_command)
10569         (find_methods): Update.
10570         * minsyms.c (find_solib_trampoline_target): Update.
10571         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10572         * coffread.c (coff_symfile_read): Update.
10573         * ada-lang.c (ada_lookup_simple_minsym)
10574         (ada_collect_symbol_completion_matches): Update.
10575
10576 2019-01-16  Tom Tromey  <tom@tromey.com>
10577
10578         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10579         type.  Remove no-argument constructor.
10580         <iterator::operator++>: Simplify.
10581         <begin>: Update.
10582         <end>: Use minimal_symbol_count.
10583
10584 2019-01-16  Tom Tromey  <tom@tromey.com>
10585
10586         * objfiles.h (struct objfile) <psymtabs>: New method.
10587         (class objfile_psymtabs): Remove.
10588         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10589         typedef.
10590         <range>: New method.
10591         (require_partial_symbols): Change return type.
10592         * psymtab.c (require_partial_symbols)
10593         (psym_expand_symtabs_matching): Update.
10594         * mdebugread.c (parse_partial_symbols): Update.
10595         * dbxread.c (dbx_end_psymtab): Update.
10596
10597 2019-01-15  Tom Tromey  <tom@tromey.com>
10598
10599         * symtab.c (lookup_objfile_from_block)
10600         (lookup_symbol_in_objfile_symtabs)
10601         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10602         (find_line_symtab, info_sources_command)
10603         (default_collect_symbol_completion_matches_break_on)
10604         (make_source_files_completion_list): Update.
10605         * symmisc.c (print_objfile_statistics, dump_objfile)
10606         (maintenance_print_symbols, maintenance_info_symtabs)
10607         (maintenance_check_symtabs, maintenance_info_line_tables):
10608         Update.
10609         * source.c (select_source_symtab)
10610         (forget_cached_source_info_for_objfile): Update.
10611         * objfiles.h (class objfile_compunits): Remove.
10612         (struct objfile) <compunits_range>: New typedef.
10613         (compunits): New method.
10614         * objfiles.c (objfile_relocate1): Update.
10615         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10616         * maint.c (count_symtabs_and_blocks): Update.
10617         * linespec.c (iterate_over_all_matching_symtabs): Update.
10618         * cp-support.c (add_symbol_overload_list_qualified): Update.
10619         * coffread.c (coff_symtab_read): Update.
10620         * ada-lang.c (add_nonlocal_symbols)
10621         (ada_collect_symbol_completion_matches)
10622         (ada_add_global_exceptions): Update.
10623
10624 2019-01-15  Tom Tromey  <tom@tromey.com>
10625
10626         * progspace.h (program_space) <objfiles_safe_range>: New
10627         typedef.
10628         <objfiles_safe>: New method.
10629         * objfiles.h (class all_objfiles_safe): Remove.
10630         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10631         * jit.c (jit_inferior_exit_hook): Update.
10632
10633 2019-01-17  Tom Tromey  <tom@tromey.com>
10634
10635         * progspace.h (program_space) <objfiles_range>: New typedef.
10636         <objfiles>: New method.
10637         <objfiles_head>: Rename from objfiles.
10638         (object_files): Update.
10639         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10640         * guile/scm-pretty-print.c
10641         (ppscm_find_pretty_printer_from_objfiles): Update.
10642         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10643         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10644         Update.
10645         * python/py-progspace.c (pspy_get_objfiles): Update.
10646         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10647         Update.
10648         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10649         (objfpy_lookup_objfile_by_build_id): Update.
10650         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10651         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10652         Update.
10653         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10654         (expand_symtab_containing_pc, lookup_objfile_from_block)
10655         (lookup_static_symbol, basic_lookup_transparent_type)
10656         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10657         (find_line_symtab, info_sources_command)
10658         (default_collect_symbol_completion_matches_break_on)
10659         (make_source_files_completion_list, find_main_name): Update.
10660         * symmisc.c (print_symbol_bcache_statistics)
10661         (print_objfile_statistics, maintenance_print_symbols)
10662         (maintenance_print_msymbols, maintenance_print_objfiles)
10663         (maintenance_info_symtabs, maintenance_check_symtabs)
10664         (maintenance_expand_symtabs, maintenance_info_line_tables):
10665         Update.
10666         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10667         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10668         (map_overlay_command, unmap_overlay_command)
10669         (simple_overlay_update, expand_symtabs_matching)
10670         (map_symbol_filenames): Update.
10671         * symfile-debug.c (set_debug_symfile): Update.
10672         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10673         Update.
10674         * source.c (select_source_symtab, forget_cached_source_info):
10675         Update.
10676         * solib.c (solib_read_symbols): Update.
10677         * solib-spu.c (append_ocl_sos): Update.
10678         * psymtab.c (maintenance_print_psymbols)
10679         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10680         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10681         * printcmd.c (info_symbol_command): Update.
10682         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10683         Update.
10684         * objfiles.h (class all_objfiles): Remove.
10685         * objfiles.c (have_partial_symbols, have_full_symbols)
10686         (have_minimal_symbols, qsort_cmp, update_section_map)
10687         (shared_objfile_contains_address_p)
10688         (default_iterate_over_objfiles_in_search_order): Update.
10689         * objc-lang.c (info_selectors_command, info_classes_command)
10690         (find_methods): Update.
10691         * minsyms.c (find_solib_trampoline_target): Update.
10692         * maint.c (maintenance_info_sections)
10693         (maintenance_translate_address, count_symtabs_and_blocks):
10694         Update.
10695         * main.c (captured_main_1): Update.
10696         * linux-thread-db.c (try_thread_db_load_from_pdir)
10697         (has_libpthread): Update.
10698         * linespec.c (iterate_over_all_matching_symtabs)
10699         (search_minsyms_for_name): Update.
10700         * jit.c (jit_find_objf_with_entry_addr): Update.
10701         * hppa-tdep.c (find_unwind_entry)
10702         (hppa_lookup_stub_minimal_symbol): Update.
10703         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10704         Update.
10705         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10706         (elf_gnu_ifunc_resolve_by_got): Update.
10707         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10708         * dwarf-index-write.c (save_gdb_index_command): Update.
10709         * cp-support.c (add_symbol_overload_list_qualified): Update.
10710         * breakpoint.c (create_overlay_event_breakpoint)
10711         (create_longjmp_master_breakpoint)
10712         (create_std_terminate_master_breakpoint)
10713         (create_exception_master_breakpoint): Update.
10714         * blockframe.c (find_pc_partial_function): Update.
10715         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10716         (ada_collect_symbol_completion_matches)
10717         (ada_add_global_exceptions): Update.
10718
10719 2019-01-17  Tom Tromey  <tom@tromey.com>
10720
10721         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10722         declare VEC.
10723         (solib_target_parse_libraries): Change return type.
10724         (library_list_start_segment, library_list_start_section)
10725         (library_list_end_library, library_list_start_library); Update.
10726         (solib_target_free_library_list): Remove.
10727         (solib_target_parse_libraries): Remove cleanup.  Change return
10728         type.
10729         (solib_target_current_sos): Update.
10730
10731 2019-01-17  Tom Tromey  <tromey@bapiya>
10732
10733         * valprint.c: Replace "the the" with "the".
10734         * symtab.c: Replace "the the" with "the".
10735         * solib.c: Replace "the the" with "the".
10736         * solib-dsbt.c: Replace "the the" with "the".
10737         * linespec.c: Replace "the the" with "the".
10738         * dwarf2loc.h: Replace "the the" with "the".
10739         * amd64-windows-tdep.c: Replace "the the" with "the".
10740         * aarch64-tdep.c: Replace "the the" with "the".
10741
10742 2019-01-16  Keith Seitz  <keiths@redhat.com>
10743
10744         PR gdb/23773
10745         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10746         <builder>: Rename to ..
10747         <m_builder>: ... this and make private.
10748         (dwarf2_cu::get_builder): New method.  Change all users of
10749         `builder' to use this method.
10750         (dwarf2_start_symtab): Move to ...
10751         (dwarf2_cu::start_symtab): ... here.  Update all callers
10752         (setup_type_unit_groups): Move to ...
10753         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10754         callers.
10755         (dwarf2_cu::reset_builder): New method.
10756         (process_full_compunit, process_full_type_unit): Use
10757         dwarf2_cu::reset_builder.
10758         (follow_die_offset): Record the ancestor CU if it is different
10759         from the followed DIE's CU.
10760         (follow_die_sig_1): Likewise.
10761
10762 2019-01-15  Tom Tromey  <tom@tromey.com>
10763
10764         * remote.c (class remote_state) <buf>: Now a char_vector.
10765         <buf_size>: Remove.
10766         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10767         parameter.
10768         (remote_target::getpkt_or_notif_sane_1)
10769         (remote_target::getpkt_sane)
10770         (remote_target::getpkt_or_notif_sane): Likewise.
10771         (class remote_target) <putpkt>: New overload.
10772         (remote_target::read_frame): Change type of "buf_p".  Remove
10773         sizeof_p parameter.
10774         (packet_ok): New overload.
10775         (packet_check_result): New overload.
10776         Update all uses.
10777
10778 2019-01-14  Tom Tromey  <tom@tromey.com>
10779
10780         * remote-notif.c (handle_notification, remote_notif_ack)
10781         (remote_notif_parse): Make "buf" const.
10782         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10783         const.
10784         (remote_notif_parse, remote_notif_ack, handle_notification):
10785         Likewise.
10786         * remote.c (remote_notif_stop_parse): Make "buf" const.
10787         (remote_target::remote_parse_stop_reply): Make "buf" const.
10788         (remote_notif_stop_ack): Make "buf" const.
10789
10790 2019-01-14  Tom Tromey  <tom@tromey.com>
10791
10792         * remote.c (remote_console_output): Make parameter const.
10793
10794 2019-01-14  Tom Tromey  <tom@tromey.com>
10795
10796         * target-debug.h (target_debug_print_signals): Constify.
10797         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10798         * procfs.c (procfs_target::pass_signals): Update.
10799         * linux-nat.c (linux_nat_target::pass_signals): Update.
10800         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10801         * target-delegates.c: Rebuild.
10802         * remote.c (remote_target::program_signals): Update.
10803         (remote_target::pass_signals): Update.
10804         * target.c (target_pass_signals): Constify argument.
10805         (target_program_signals): Likewise.
10806         * target.h (struct target_ops) <pass_signals, program_signals>:
10807         Constify argument.
10808         (target_pass_signals, target_program_signals): Constify argument.
10809
10810 2019-01-14  Tom Tromey  <tom@tromey.com>
10811
10812         PR tui/28819:
10813         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10814
10815 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10816
10817         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10818         field.
10819         * rs6000-tdep.c: Include reggroups.h.
10820         (IS_V_ALIAS_PSEUDOREG): Define.
10821         (rs6000_register_name): Return names for the "vX" aliases.
10822         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10823         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10824         aliases.  Call default_register_reggroup_p for all other
10825         pseudo-registers.
10826         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10827         New functions.
10828         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10829         Handle "vX" aliases.
10830         (v_alias_pseudo_register_collect): New function.
10831         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10832         (rs6000_gdbarch_init): Initialize "vX" aliases as
10833         pseudo-registers.  Restore registration of
10834         rs6000_pseudo_register_reggroup_p with
10835         set_tdesc_pseudo_register_reggroup_p.
10836
10837 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10838
10839         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10840         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10841         set_gdbarch_num_pseudo_regs.
10842
10843 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10844
10845         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10846         Remove arg prefixname, add do_set and do_show.
10847         Add member functions set_list and show_list.
10848         * cli/cli-style.c (class cli_style_option): Update accordingly.
10849         (style_set_list): Move to file scope.
10850         (style_show_list): Likewise.
10851         (set_style): Call help_list.
10852         (show_style): Call cmd_show_list.
10853         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10854         Update to use the new macro.
10855
10856 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10857
10858         * ada-lang.c (_initialize_ada_language): Expand the help text
10859         for the "catch exception" command.
10860
10861 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10862
10863         * symtab.c (matching_obj_sections): Initialize obj,
10864         declare it closer to its usage.
10865
10866 2019-01-10  Tom Tromey  <tom@tromey.com>
10867
10868         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10869         (basic_inf_threads_range): Remove.
10870         (inf_threads_range, inf_non_exited_threads_range)
10871         (safe_inf_threads_range): Use next_adapter.
10872
10873 2019-01-10  Keith Seitz  <keiths@redhat.com>
10874
10875         PR gdb/23712
10876         PR symtab/23010
10877         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10878         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10879
10880 2019-01-10  Keith Seitz  <keiths@redhat.com>
10881
10882         PR gdb/23712
10883         PR symtab/23010
10884         * dictionary.c (pending_to_vector): Remove.
10885         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10886         Remove _1 suffix, replacing functions of the same name.  Update
10887         all callers.
10888         (dict_create_hashed, dict_create_hashed_expandable)
10889         (dict_create_linear, dict_create_linear_expandable, dict_free)
10890         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10891         Make functions static.
10892
10893 2019-01-10  Keith Seitz  <keiths@redhat.com>
10894
10895         PR gdb/23712
10896         PR symtab/23010
10897         * dictionary.h (struct dictionary): Replace declaration with
10898         multidictionary.
10899         (dict_create_hashed, dict_create_hashed_expandable)
10900         (dict_create_linear, dict_create_linear_expandable)
10901         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10902         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10903         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10904         taking multidictionary argument.
10905         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10906         * block.h (struct block) <dict>: Change to multidictionary
10907         and rename `multidict'.
10908         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10909         symmisc.c: Update all dictionary references to multidictionary.
10910
10911 2019-01-10  Keith Seitz  <keiths@redhat.com>
10912
10913         PR gdb/23712
10914         PR symtab/23010
10915         * dictionary.c: Include unordered_map.
10916         (pending_to_vector): New function.
10917         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10918         Rewrite the non-"_1" functions to take vector instead
10919         of linked list.
10920         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10921         "new" _1 versions of the same name.
10922         (multidictionary): Define.
10923         (std::hash<enum language): New definition.
10924         (collate_pending_symbols_by_language, mdict_create_hashed)
10925         (mdict_create_hashed_expandable, mdict_create_linear)
10926         (mdict_create_linear_expandable, mdict_free)
10927         (find_language_dictionary, create_new_language_dictionary)
10928         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10929         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10930         (mdict_size, mdict_empty): New functions.
10931         * dictionary.h (mdict_iterator): Define.
10932
10933 2019-01-10  Pedro Alves  <palves@redhat.com>
10934
10935         * breakpoint.c (read_uploaded_action)
10936         (create_tracepoint_from_upload): Adjust to use
10937         gdb::unique_xmalloc_ptr.
10938         * ctf.c (ctf_write_uploaded_tp):
10939         (SET_ARRAY_FIELD): Use emplace_back.
10940         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10941         * tracefile-tfile.c (tfile_write_uploaded_tp):
10942         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10943         gdb::unique_xmalloc_ptr.
10944         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10945         at_string, cond_string, cmd_strings>: Replace char pointers
10946         with gdb::unique_xmalloc_ptr.
10947
10948 2019-01-10  Pedro Alves  <palves@redhat.com>
10949
10950         * solib-target.c (library_list_start_library): Don't xstrdup name.
10951
10952 2019-01-10  Pedro Alves  <palves@redhat.com>
10953
10954         * mdebugread.c (parse_partial_symbols): Use
10955         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10956
10957 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10958
10959         * linux-fork.c (scoped_switch_fork_info)
10960         <~scoped_switch_fork_info>: Fix incorrect variable name.
10961
10962 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10963
10964         * linux-fork.c (scoped_switch_fork_info)
10965         <scoped_switch_fork_info>: Make explicit.
10966         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10967
10968 2019-01-10  Tom Tromey  <tom@tromey.com>
10969
10970         * objfiles.h (objfile::reset_psymtabs): Update.
10971         * objfiles.c (objfile::objfile): Update.
10972         * psymtab.h (psymtab_storage::obstack): Update.
10973         (psymtab_storage::m_obstack): Use gdb::optional.
10974         (class psymtab_storage): Update comment.  Remove objfile
10975         parameter.
10976         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10977
10978 2019-01-10  Tom Tromey  <tom@tromey.com>
10979
10980         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10981         <free_psymtabs>: Now private.
10982         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10983         (allocate_psymtab): Use new method.
10984
10985 2019-01-10  Tom Tromey  <tom@tromey.com>
10986
10987         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10988         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10989         * mdebugread.c (parse_partial_symbols): Use
10990         allocate_dependencies.
10991         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10992         allocate_dependencies.
10993         (process_psymtab_comp_unit_reader)
10994         (build_type_psymtab_dependencies): Likewise.
10995         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10996
10997 2019-01-10  Tom Tromey  <tom@tromey.com>
10998
10999         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11000         PSYMBOL_SET_LANGUAGE.
11001         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11002
11003 2019-01-10  Tom Tromey  <tom@tromey.com>
11004
11005         * psymtab.h (psymtab_storage::obstack): New method.
11006         <m_obstack>: Rename from obstack; now private.
11007         * psymtab.c (psymtab_storage): Update.
11008         * dwarf2read.c (create_addrmap_from_index)
11009         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11010         Update.
11011
11012 2019-01-10  Tom Tromey  <tom@tromey.com>
11013
11014         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11015         * objfiles.h (objfile::reset_psymtabs): New method.
11016
11017 2019-01-10  Tom Tromey  <tom@tromey.com>
11018
11019         * symmisc.c (print_symbol_bcache_statistics): Update.
11020         (print_objfile_statistics): Update.
11021         * symfile.c (reread_symbols): Update.
11022         * psymtab.h (class psymtab_storage): New.
11023         * psymtab.c (psymtab_storage): New constructor.
11024         (~psymtab_storage): New destructor.
11025         (require_partial_symbols): Update.
11026         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11027         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11028         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11029         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11030         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11031         (start_psymtab_common, end_psymtab_common)
11032         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11033         (allocate_psymtab): Update.
11034         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11035         Update.
11036         (dump_psymtab_addrmap, maintenance_print_psymbols)
11037         (maintenance_check_psymtabs): Update.
11038         (class objfile_psymtabs): Move to objfiles.h.
11039         * psympriv.h (discard_psymtab): Now inline.
11040         (psymtab_discarder::psymtab_discarder): Update.
11041         (psymtab_discarder::~psymtab_discarder): Update.
11042         (ALL_OBJFILE_PSYMTABS): Rewrite.
11043         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11044         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11045         Remove fields.
11046         <partial_symtabs>: New field.
11047         (class objfile_psymtabs): Move from psymtab.h.  Update.
11048         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11049         psymbol_cache.
11050         (objfile::~objfile): Don't destroy psymbol_cache.
11051         * mdebugread.c (parse_partial_symbols): Update.
11052         * dwarf2read.c (create_addrmap_from_index)
11053         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11054         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11055         (add_partial_subprogram, dwarf2_ranges_read): Update.
11056         * dwarf-index-write.c (write_address_map)
11057         (write_one_signatured_type, recursively_write_psymbols)
11058         (class debug_names, class debug_names, write_psymtabs_to_index):
11059         Update.
11060
11061 2019-01-10  Tom Tromey  <tom@tromey.com>
11062
11063         * symtab.h (SYMBOL_SET_NAMES): Update.
11064         (symbol_set_names): Update.
11065         (MSYMBOL_SET_NAMES): Update.
11066         * symtab.c (symbol_set_names): Change argument to be an
11067         objfile_per_bfd_storage.
11068         * psymtab.c (add_psymbol_to_bcache): Update.
11069         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11070
11071 2019-01-10  Tom Tromey  <tom@tromey.com>
11072
11073         * symtab.c (create_demangled_names_hash): Change argument to be an
11074         objfile_per_bfd_storage.
11075         (symbol_set_names): Update.
11076
11077 2019-01-10  Tom Tromey  <tom@tromey.com>
11078
11079         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11080         init_psymbol_list.
11081         * psymtab.c (init_psymbol_list): Do nothing if already called.
11082         * psympriv.h (init_psymbol_list): Add comment.
11083         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11084         init_psymbol_list.
11085         * dbxread.c (dbx_symfile_read): Unconditionally call
11086         init_psymbol_list.
11087
11088 2019-01-10  Tom Tromey  <tom@tromey.com>
11089
11090         * xcoffread.c (scan_xcoff_symtab): Update.
11091         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11092         "where".
11093         * mdebugread.c (parse_partial_symbols)
11094         (handle_psymbol_enumerators): Update.
11095         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11096         * dbxread.c (read_dbx_symtab): Update.
11097         * psympriv.h (psymbol_placement): New enum.
11098         (add_psymbol_to_list): Update.
11099
11100 2019-01-10  Tom Tromey  <tom@tromey.com>
11101
11102         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11103         static_psymbols parameters.
11104         (scan_xcoff_symtab): Update.
11105         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11106         static_psymbols parameters.
11107         * psympriv.h (start_psymtab_common): Update.
11108         * mdebugread.c (parse_partial_symbols): Update.
11109         * dwarf2read.c (create_partial_symtab): Update.
11110         * dbxread.c (read_dbx_symtab): Update.
11111         (start_psymtab): Remove global_psymbols and static_psymbols
11112         parameters.
11113
11114 2019-01-10  Tom Tromey  <tom@tromey.com>
11115
11116         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11117         * psymtab.c (allocate_psymtab): Add comment.
11118         * psympriv.h (allocate_psymtab): Add comment.
11119         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11120         initializations.
11121         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11122
11123 2019-01-10  Tom Tromey  <tom@tromey.com>
11124
11125         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11126         Don't declare.
11127         * mipsread.c: Include mdebugread.h.
11128         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11129         Declare.
11130         * elfread.c: Include mdebugread.h.
11131
11132 2019-01-09  Tom Tromey  <tom@tromey.com>
11133
11134         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11135         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11136         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11137         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11138         (psym_lookup_symbol, psym_find_last_source_symtab)
11139         (psym_forget_cached_source_info, psym_print_stats)
11140         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11141         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11142         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11143         (psym_find_compunit_symtab_by_address)
11144         (maintenance_print_psymbols, maintenance_info_psymtabs)
11145         (maintenance_check_psymtabs): Use ranged for.
11146         * psymtab.h (class objfile_psymtabs): New.
11147         (require_partial_symbols): Return objfile_psymtabs.
11148         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11149
11150 2019-01-09  Tom Tromey  <tom@tromey.com>
11151
11152         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11153         (find_pc_mapped_section, list_overlays_command)
11154         (map_overlay_command, unmap_overlay_command)
11155         (simple_overlay_update): Use all_objfiles.
11156         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11157         * printcmd.c (info_symbol_command): Use all_objfiles.
11158         * objfiles.h (ALL_OBJSECTIONS): Remove.
11159         * maint.c (maintenance_translate_address): Use all_objfiles.
11160         * gcore.c (gcore_create_callback): Use all_objfiles.
11161         (objfile_find_memory_regions): Likewise.
11162
11163 2019-01-09  Tom Tromey  <tom@tromey.com>
11164
11165         * symtab.c (find_line_symtab, info_sources_command)
11166         (make_source_files_completion_list): Use objfile_compunits.
11167         * source.c (select_source_symtab): Use objfile_compunits.
11168         * objfiles.h (struct objfile): Update comment.
11169         (ALL_OBJFILES): Remove.
11170         (ALL_FILETABS): Remove.
11171         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11172         objfile_compunits.
11173
11174 2019-01-09  Tom Tromey  <tom@tromey.com>
11175
11176         * symmisc.c (print_objfile_statistics, dump_objfile)
11177         (maintenance_print_symbols): Use compunit_filetabs.
11178         * source.c (forget_cached_source_info_for_objfile): Use
11179         compunit_filetabs.
11180         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11181         (ALL_FILETABS): Use compunit_filetabs.
11182         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11183         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11184
11185 2019-01-09  Tom Tromey  <tom@tromey.com>
11186
11187         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11188         (compunit_filetabs): New.
11189         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11190         compunit_filetabs.
11191         (info_sources_command, make_source_files_completion_list): Remove
11192         declaration.
11193         * symmisc.c (print_objfile_statistics, dump_objfile)
11194         (maintenance_print_symbols): Remove declaration.
11195         (maintenance_info_symtabs): Use compunit_filetabs.
11196         (maintenance_info_line_tables): Likewise.
11197         * source.c (select_source_symtab): Change local variable name.
11198         (forget_cached_source_info_for_objfile): Remove declaration.
11199         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11200         * objfiles.c (objfile_relocate1): Remove declaration.
11201         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11202         declaration.
11203         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11204         * coffread.c (coff_symtab_read): Remove declaration.
11205         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11206         compunit_filetabs.
11207
11208 2019-01-09  Tom Tromey  <tom@tromey.com>
11209
11210         * symtab.c (lookup_objfile_from_block)
11211         (find_pc_sect_compunit_symtab, search_symbols)
11212         (default_collect_symbol_completion_matches_break_on): Use
11213         objfile_compunits.
11214         * objfiles.h (ALL_COMPUNITS): Remove.
11215         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11216         * cp-support.c (add_symbol_overload_list_qualified): Use
11217         objfile_compunits.
11218         * ada-lang.c (ada_collect_symbol_completion_matches)
11219         (ada_add_global_exceptions): Use objfile_compunits.
11220
11221 2019-01-09  Tom Tromey  <tom@tromey.com>
11222
11223         * source.c (select_source_symtab)
11224         (forget_cached_source_info_for_objfile): Remove declaration.
11225         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11226         declaration.
11227         * maint.c (count_symtabs_and_blocks): Remove declaration.
11228         * cp-support.c (add_symbol_overload_list_qualified): Remove
11229         declaration.
11230         * coffread.c (coff_symtab_read): Remove declaration.
11231         * symtab.c (lookup_symbol_in_objfile_symtabs)
11232         (basic_lookup_transparent_type_1): Use objfile_compunits.
11233         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11234         (info_sources_command, search_symbols)
11235         (default_collect_symbol_completion_matches_break_on)
11236         (make_source_files_completion_list): Remove declaration.
11237         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11238         (ada_collect_symbol_completion_matches)
11239         (ada_add_global_exceptions): Remove declaration.
11240         * linespec.c (iterate_over_all_matching_symtabs): Use
11241         objfile_compunits.
11242         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11243         (class objfile_compunits): New.
11244         (ALL_COMPUNITS): Use objfile_compunits.
11245         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11246         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11247         objfile_compunits.
11248         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11249
11250 2019-01-09  Tom Tromey  <tom@tromey.com>
11251
11252         * symtab.c (search_symbols)
11253         (default_collect_symbol_completion_matches_break_on): Use
11254         objfile_msymbols.
11255         * ada-lang.c (ada_lookup_simple_minsym)
11256         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11257         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11258         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11259         objfile_msymbols.
11260         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11261         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11262         * objc-lang.c (find_methods): Use objfile_msymbols.
11263         (info_selectors_command, info_classes_command): Likewise.
11264         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11265         * objfiles.h (class objfile_msymbols): New.
11266         (ALL_OBJFILE_MSYMBOLS): Remove.
11267         (ALL_MSYMBOLS): Remove.
11268
11269 2019-01-09  Tom Tromey  <tom@tromey.com>
11270
11271         * common/next-iterator.h (next_adapter): Add Iterator template
11272         parameter.
11273         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11274         (class all_objfiles_safe): New.
11275         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11276         * objfiles.c (put_objfile_before): Update comment.
11277         (add_separate_debug_objfile): Likewise.
11278         (free_all_objfiles): Use all_objfiles_safe.
11279         (objfile_purge_solibs): Likewise.
11280
11281 2019-01-09  Tom Tromey  <tom@tromey.com>
11282
11283         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11284         (expand_symtab_containing_pc, lookup_static_symbol)
11285         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11286         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11287         all_objfiles.
11288         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11289         * breakpoint.c (create_overlay_event_breakpoint)
11290         (create_longjmp_master_breakpoint)
11291         (create_std_terminate_master_breakpoint)
11292         (create_exception_master_breakpoint): Use all_objfiles.
11293         * linux-thread-db.c (try_thread_db_load_from_pdir)
11294         (has_libpthread): Use all_objfiles.
11295         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11296         * linespec.c (iterate_over_all_matching_symtabs)
11297         (search_minsyms_for_name): Use all_objfiles.
11298         * maint.c (maintenance_info_sections): Use all_objfiles.
11299         * main.c (captured_main_1): Use all_objfiles.
11300         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11301         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11302         * guile/scm-pretty-print.c
11303         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11304         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11305         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11306         (maintenance_print_msymbols): Use all_objfiles.
11307         * source.c (select_source_symtab): Use all_objfiles.
11308         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11309         * symfile.c (remove_symbol_file_command)
11310         (expand_symtabs_matching, map_symbol_filenames): Use
11311         all_objfiles.
11312         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11313         all_objfiles.
11314         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11315         * objc-lang.c (find_methods): Use all_objfiles.
11316         * objfiles.c (have_partial_symbols, have_full_symbols)
11317         (have_minimal_symbols, qsort_cmp)
11318         (default_iterate_over_objfiles_in_search_order): Use
11319         all_objfiles.
11320         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11321         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11322         (maintenance_check_psymtabs): Use all_objfiles.
11323         (ALL_PSYMTABS): Remove.
11324         * compile/compile-object-run.c (do_module_cleanup): Use
11325         all_objfiles.
11326         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11327         * cp-support.c (add_symbol_overload_list_qualified): Use
11328         all_objfiles.
11329         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11330         Use all_objfiles.
11331         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11332         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11333         all_objfiles.
11334         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11335         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11336         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11337         Uses all_objfiles.
11338         * solib.c (solib_read_symbols): Use all_objfiles
11339
11340 2019-01-09  Tom Tromey  <tom@tromey.com>
11341
11342         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11343         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11344         all_objfiles.
11345         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11346         * symmisc.c (print_symbol_bcache_statistics)
11347         (print_objfile_statistics, maintenance_print_objfiles)
11348         (maintenance_info_symtabs, maintenance_check_symtabs)
11349         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11350         all_objfiles.
11351         * source.c (forget_cached_source_info): Use all_objfiles.
11352         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11353         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11354         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11355         * objfiles.c (update_section_map): Use all_objfiles.
11356         (shared_objfile_contains_address_p): Likewise.
11357         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11358         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11359
11360 2019-01-09  Tom Tromey  <tom@tromey.com>
11361
11362         * common/next-iterator.h: New file.
11363         * objfiles.h (class all_objfiles): New.
11364         (struct objfile_iterator): New.
11365
11366 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11367
11368         * NEWS: Move the description of the changed "frame", "select-frame",
11369          and "info frame" commands to the Changed commands section.
11370
11371 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11372
11373         * gdbtypes.c (check_stub_method_group): Remove handling of old
11374         mangling schemes.
11375         * linespec.c (find_methods): Likewise.
11376         * stabsread.c (read_member_functions): Likewise.
11377         * valops.c (search_struct_method): Likewise.
11378         (value_struct_elt_for_reference): Likewise.
11379         * NEWS: Mention this change.
11380
11381 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11382
11383         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11384         print_source_lines.
11385         * source.c (print_source_lines_base): Update line number check.
11386         (print_source_lines): New function.
11387         (source_lines_range::source_lines_range): New function.
11388         * source.h (class source_lines_range): New class.
11389         (print_source_lines): New declaration.
11390
11391 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11392
11393         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11394
11395 2019-01-08  Tom Tromey  <tom@tromey.com>
11396             Simon Marchi  <simon.marchi@ericsson.com>
11397
11398         PR gdb/24060
11399         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11400         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11401         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11402         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11403         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11404         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11405
11406 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11407
11408         * source.c (select_source_symtab): Move header comment to
11409         declaration in source.h.
11410         (forget_cached_source_info_for_objfile): Likewise.
11411         (forget_cached_source_info): Likewise.
11412         (identify_source_line): Likewise.
11413         * source.h (identify_source_line): Move declaration from symtab.h
11414         and add comment from source.c
11415         (print_source_lines): Likewise.
11416         (forget_cached_source_info_for_objfile): Likewise.
11417         (forget_cached_source_info): Likewise.
11418         (select_source_symtab): Likewise.
11419         (enum print_source_lines_flag): Move definition from symtab.h.
11420         * symtab.h (identify_source_line): Move declaration to source.h.
11421         (print_source_lines): Likewise.
11422         (forget_cached_source_info_for_objfile): Likewise.
11423         (forget_cached_source_info): Likewise.
11424         (select_source_symtab): Likewise.
11425         (enum print_source_lines_flag): Move definition to source.h.
11426         * tui/tui-hooks.c: Add 'source.h' include.
11427
11428 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11429
11430         * source.c (print_source_lines_base): Handle requests to print
11431         reverse line number sequences, and guard against empty lines
11432         string.
11433
11434 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11435
11436         * source.c (print_source_lines_base): Fix skip of '\r' if next
11437         character is '\n'.
11438
11439 2019-01-06  Tom Tromey  <tom@tromey.com>
11440
11441         * c-exp.y (struct c_parse_state) <macro_original_text,
11442         expansion_obstack>: New member.
11443         (macro_original_text, expansion_obstack): Remove globals.
11444         (scan_macro_expansion, scanning_macro_expansion)
11445         (finished_macro_expansion): Update.
11446         (scan_macro_cleanup): Remove.
11447         (yylex, c_parse): Update.
11448
11449 2019-01-06  Tom Tromey  <tom@tromey.com>
11450
11451         * c-exp.y (struct c_parse_state) <strings>: New member.
11452         (operator_stoken): Update.
11453
11454 2019-01-06  Tom Tromey  <tom@tromey.com>
11455
11456         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11457         (union type_stack_elt) <typelist_val>: Now a pointer to
11458         std::vector.
11459         (type_stack_cleanup): Don't declare.
11460         (push_typelist): Update.
11461         * parse.c (pop_typelist): Return a std::vector.
11462         (push_typelist): Take a std::vector.
11463         (follow_types): Update.  Do not free args.
11464         (type_stack_cleanup): Remove.
11465         * c-exp.y (struct c_parse_state): New.
11466         (cpstate): New global.
11467         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11468         (nonempty_typelist): Update.
11469         (func_mod): Create a new vector.
11470         (c_parse): Create a c_parse_state.
11471         (check_parameter_typelist): Do not delete params.
11472         (function_method): Update.  Do not delete type_list.
11473
11474 2019-01-06  Tom Tromey  <tom@tromey.com>
11475
11476         PR gdb/28155:
11477         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11478         check_typedef.
11479         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11480         (print_return_value): Likewise.
11481
11482 2019-01-05  Tom Tromey  <tom@tromey.com>
11483
11484         * contrib/cleanup_check.py: Remove.
11485         * contrib/gcc-with-excheck: Remove.
11486         * contrib/exsummary.py: Remove.
11487         * contrib/excheck.py: Remove.
11488
11489 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11490
11491         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11492         NULL. Initialize tpprev to NULL instead of assigning it
11493         to NULL on the next statement.
11494         * windows-nat.c (windows_delete_thread): Remove check for
11495         main_thread_id before printing thread exit notifications.
11496         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11497         Remove thread ID check against main_thread_id.
11498         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11499         windows_delete_thread.
11500         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11501
11502 2019-01-04  Tom Tromey  <tom@tromey.com>
11503
11504         * compile/compile.c (_initialize_compile): Use upper case for
11505         metasyntactic variables.
11506         * symmisc.c (_initialize_symmisc): Use upper case for
11507         metasyntactic variables.
11508         * psymtab.c (_initialize_psymtab): Use upper case for
11509         metasyntactic variables.
11510         * demangle.c (demangle_command): Use upper case for metasyntactic
11511         variables.
11512         (_initialize_demangler): Likewise.
11513         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11514         variables.
11515
11516 2019-01-03  Tom Tromey  <tom@tromey.com>
11517
11518         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11519
11520 2019-01-03  Tom Tromey  <tom@tromey.com>
11521
11522         * python/py-symtab.c (salpy_str): Update.
11523         (struct salpy_sal_object) <symtab>: Now a PyObject.
11524         (salpy_dealloc): Update.
11525         (del_objfile_sal): Use gdbpy_ref.
11526
11527 2019-01-03  Tom Tromey  <tom@tromey.com>
11528
11529         * python/py-type.c (convert_field): Use new_reference.  Return
11530         gdbpy_ref.
11531         (make_fielditem): Return gdbpy_ref.
11532         (typy_fields): Update.
11533         (typy_getitem): Update.
11534         (field_name): Return gdbpy_ref.  Use new_reference.
11535         (typy_iterator_iternext): Update.
11536
11537 2019-01-03  Tom Tromey  <tom@tromey.com>
11538
11539         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11540
11541 2019-01-03  Tom Tromey  <tom@tromey.com>
11542
11543         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11544         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11545         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11546         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11547         (pspy_set_type_printers): Likewise.
11548         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11549         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11550         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11551         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11552         (objfpy_set_type_printers): Likewise.
11553
11554 2019-01-03  Tom Tromey  <tom@tromey.com>
11555
11556         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11557         (gdbpy_print_stack): Use gdbpy_err_fetch.
11558         * python/python-internal.h (class gdbpy_err_fetch): New class.
11559         (class gdbpy_enter) <m_error_type, m_error_value,
11560         m_error_traceback>: Remove.
11561         <m_error>: New member.
11562         (gdbpy_exception_to_string): Don't declare.
11563         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11564         * python/py-value.c (convert_value_from_python): Use
11565         gdbpy_err_fetch.
11566         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11567         gdbpy_exception_to_string.
11568         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11569         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11570         gdbpy_err_fetch.
11571
11572 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11573
11574         * linux-nat.c (delete_lwp_cleanup): Delete.
11575         (struct lwp_deleter): New struct.
11576         (lwp_info_up): New typedef.
11577         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11578         lwp_info_up.
11579
11580 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11581
11582         * linux-fork.c (class scoped_switch_fork_info): New class.
11583         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11584
11585 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11586
11587         * valops.c (find_overload_match): Remove use of null_cleanup, and
11588         calls to do_cleanups.
11589
11590 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11591
11592         * compile/compile-cplus-types.c
11593         (compile_cplus_instance::decl_name): Handle changes to
11594         cp_func_name.
11595         * cp-support.c (cp_func_name): Update header comment, update
11596         return type.
11597         * cp-support.h (cp_func_name): Update return type in declaration.
11598         * valops.c (find_overload_match): Move temp_func local to top
11599         level of function and change its type.  Use temp_func to hold and
11600         delete temporary string obtained from cp_func_name.
11601
11602 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11603
11604         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11605         gdb::char_vector, remove cleanup, and update uses of `msg`.
11606
11607 2019-01-03  Jim Wilson  <jimw@sifive.com>
11608
11609         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11610
11611 2019-01-02  Tom Tromey  <tom@tromey.com>
11612
11613         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11614         (tdesc_parse_xml): Remove cleanups.
11615         * target-descriptions.h (make_cleanup_free_target_description):
11616         Don't declare.
11617         (target_desc_deleter): New struct.
11618         (target_desc_up): New typedef.
11619         * target-descriptions.c (target_desc_deleter::operator()): Rename
11620         from free_target_description.
11621         (make_cleanup_free_target_description): Remove.
11622
11623 2019-01-02  Tom Tromey  <tom@tromey.com>
11624
11625         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11626         constructor, destructor.
11627         (linespec_parser): Remove typedef.
11628         (~linespec_parser): Rename from linespec_parser_delete.
11629         (linespec_lex_to_end, linespec_complete_label)
11630         (linespec_complete): Update.
11631         (decode_line_full): Remove cleanups.
11632         (decode_line_1): Update.
11633
11634 2019-01-02  Tom Tromey  <tom@tromey.com>
11635
11636         * python/python-internal.h (inferior_to_inferior_object): Change
11637         return type.
11638         * python/py-exitedevent.c (create_exited_event_object): Update.
11639         * python/py-inferior.c (inferior_to_inferior_object): Return
11640         gdbpy_ref.
11641         (python_new_inferior, python_inferior_deleted)
11642         (thread_to_thread_object, delete_thread_object)
11643         (build_inferior_list, gdbpy_selected_inferior): Update.
11644         * python/py-infthread.c (create_thread_object): Update.  Also fail
11645         if inferior_to_inferior_object fails.
11646
11647 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11648
11649         * inferior.h (class inferior) <displaced_step_state>: New field.
11650         * infrun.h (struct displaced_step_state): Move here from
11651         infrun.c.  Initialize fields, add constructor.
11652         <inf>: Remove field.
11653         <reset>: New method.
11654         * infrun.c (struct displaced_step_inferior_state): Move to
11655         infrun.h.
11656         (displaced_step_inferior_states): Remove.
11657         (get_displaced_stepping_state): Adust.
11658         (displaced_step_in_progress_any_inferior): Adjust.
11659         (displaced_step_in_progress_thread): Adjust.
11660         (displaced_step_in_progress): Adjust.
11661         (add_displaced_stepping_state): Remove.
11662         (get_displaced_step_closure_by_addr): Adjust.
11663         (remove_displaced_stepping_state): Remove.
11664         (infrun_inferior_exit): Call displaced_step_state.reset.
11665         (use_displaced_stepping): Don't check for NULL.
11666         (displaced_step_prepare_throw): Call
11667         get_displaced_stepping_state.
11668         (displaced_step_fixup): Don't check for NULL.
11669         (prepare_for_detach): Don't check for NULL.
11670
11671 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11672
11673         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11674          in case of call that did not complete.
11675
11676 2019-01-02  Andrey Utkin  <autkin@undo.io>
11677
11678         * symfile.c (find_separate_debug_file): Fix search of debug files for
11679         remote debuggee.
11680
11681 2019-01-02  Tom Tromey  <tom@tromey.com>
11682
11683         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11684         indentation.
11685         * python/py-frame.c (frapy_older): Remove cast.
11686         (frapy_newer): Likewise.
11687         * python/py-breakpoint.c (local_setattro): Remove cast.
11688         * python/py-arch.c (archpy_name): Remove local variable.
11689         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11690
11691 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11692
11693         * unittests/basic_string_view/element_access/char/empty.cc:
11694         Fix year range in copyright header.
11695
11696 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11697
11698         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11699         Delete.
11700         <operator==>: Update with for removed field.
11701         <hash>: Likewise.
11702         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11703         <isa_features>: ...this.
11704         <abi_features>: New field.
11705         (riscv_isa_flen): Update comment.
11706         (riscv_abi_xlen): New declaration.
11707         (riscv_abi_flen): New declaration.
11708         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11709         isa_features.
11710         (riscv_abi_xlen): New function.
11711         (riscv_isa_flen): Update to get answer from isa_features.
11712         (riscv_abi_flen): New function.
11713         (riscv_has_fp_abi): Update to get answer from abi_features.
11714         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11715         xlen and flen.
11716         (riscv_call_info) <xlen, flen>: Update comment.
11717         (riscv_call_arg_struct): Remove invalid assertions
11718         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11719         is removed.
11720         (riscv_gdbarch_init): Gather isa features and abi features
11721         separately, ensure both match on the gdbarch when reusing an old
11722         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11723         a target with 64-bit float hardware.
11724
11725 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11726
11727         * source.c (search_command_helper): Stop reverse search
11728         when line 1 has been searched.
11729
11730 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11731
11732         * record-full.c (record_full_base_target::close): Rewrite
11733         record_full_core_buf_list free logic.
11734
11735 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11736
11737         * break-catch-syscall.c (print_one_catch_syscall): xfree
11738         the last text.
11739
11740 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11741
11742         * top.c (print_gdb_version): Update Copyright year in version
11743         message.
11744
11745 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11746
11747         Update copyright year range in all GDB files.
11748
11749 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11750
11751         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11752
11753 For older changes see ChangeLog-2018.
11754 \f
11755 Local Variables:
11756 mode: change-log
11757 left-margin: 8
11758 fill-column: 74
11759 version-control: never
11760 coding: utf-8
11761 End:
11762