Fix TUI use of "has_break" field
[external/binutils.git] / gdb / ChangeLog
1 2019-07-04  Tom Tromey  <tom@tromey.com>
2
3         PR tui/24724:
4         * tui/tui-winsource.c (tui_clear_source_content): Update.
5         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6         (tui_update_breakpoint_info): Update.
7         (tui_set_exec_info_content): Update.
8         * tui/tui-source.c (tui_set_source_content_nil): Update.
9         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
10         has_break.
11         * tui/tui-data.h (enum tui_bp_flag): New.
12         (tui_bp_flags): New enum flags type.
13         (struct tui_source_element) <break_mode>: Change type.  Rename
14         from has_break.
15         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
16         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
17         constants.
18         * tui/tui-winsource.h: Fix comment.
19
20 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
21
22         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
23         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
24         (store_fpregs_to_thread)
25         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
26         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
27         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
28         (IWMMXT_REGS_SIZE): Add define.
29         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
30         (fetch_vfp_regs, store_vfp_regs)
31         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
32         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
33
34 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
35
36         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
37         defines.
38         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
39         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
40         (ARM_INT_REGISTER_SIZE): ...to this.
41         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
42         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
43         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
44         (arm_linux_collect_gregset, supply_nwfpe_register)
45         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
46         defines.
47         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
48         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
49         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
50         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
51         (arm_return_in_memory, arm_store_return_value)
52         (arm_get_longjmp_target, arm_register_g_packet_guesses)
53         (arm_record_ld_st_multiple): Likewise.
54         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
55         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
56
57 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
58
59         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
60         AARCH64_DISPLACED_MODIFIED_INSNS.
61         * aarch64-tdep.c (struct aarch64_displaced_step_data)
62         (aarch64_displaced_step_copy_insn): Likewise.
63         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
64         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
65         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
66         ARM_DISPLACED_MODIFIED_INSNS.
67         * arm-tdep.c (arm_gdbarch_init): Likewise.
68         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
69         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
70         (struct arm_displaced_step_closure): Use
71         ARM_DISPLACED_MODIFIED_INSNS.
72
73 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
74
75         * features/Makefile: Remove unused xml files.
76         * features/aarch64.xml: Remove.
77         * features/i386/amd64-avx-avx512-linux.xml: Remove.
78         * features/i386/amd64-avx-avx512.xml: Remove.
79         * features/i386/amd64-avx-linux.xml: Remove.
80         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
81         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
82         * features/i386/amd64-avx-mpx-linux.xml: Remove.
83         * features/i386/amd64-avx-mpx.xml: Remove.
84         * features/i386/amd64-avx.xml: Remove.
85         * features/i386/amd64-linux.xml: Remove.
86         * features/i386/amd64-mpx-linux.xml: Remove.
87         * features/i386/amd64-mpx.xml: Remove.
88         * features/i386/amd64.xml: Remove.
89         * features/i386/i386-avx-avx512-linux.xml: Remove.
90         * features/i386/i386-avx-avx512.xml: Remove.
91         * features/i386/i386-avx-linux.xml: Remove.
92         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
93         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
94         * features/i386/i386-avx-mpx-linux.xml: Remove.
95         * features/i386/i386-avx-mpx.xml: Remove.
96         * features/i386/i386-avx.xml: Remove.
97         * features/i386/i386-linux.xml: Remove.
98         * features/i386/i386-mmx-linux.xml: Remove.
99         * features/i386/i386-mmx.xml: Remove.
100         * features/i386/i386-mpx-linux.xml: Remove.
101         * features/i386/i386-mpx.xml: Remove.
102         * features/i386/i386.xml: Remove.
103         * features/i386/x32-avx-avx512-linux.xml: Remove.
104         * features/i386/x32-avx-linux.xml: Remove.
105         * features/i386/x32-linux.xml: Remove.
106
107 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
108
109         * regformats/aarch64.dat: Remove.
110         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
111         * regformats/i386/amd64-avx-linux.dat: Remove.
112         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
113         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
114         * regformats/i386/amd64-linux.dat: Remove.
115         * regformats/i386/amd64-mpx-linux.dat: Remove.
116         * regformats/i386/amd64.dat: Remove.
117         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
118         * regformats/i386/i386-avx-linux.dat: Remove.
119         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
120         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
121         * regformats/i386/i386-linux.dat: Remove.
122         * regformats/i386/i386-mmx-linux.dat: Remove.
123         * regformats/i386/i386-mpx-linux.dat: Remove.
124         * regformats/i386/i386.dat: Remove.
125         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
126         * regformats/i386/x32-avx-linux.dat: Remove.
127         * regformats/i386/x32-linux.dat: Remove.
128
129 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
130
131         * aarch64-tdep.c: Remove xml self tests.
132         * amd64-linux-tdep.c: Likewise.
133         * amd64-tdep.c: Likewise.
134         * i386-linux-tdep.c: Likewise.
135         * i386-tdep.c: Likewise.
136
137 2019-07-03  Pedro Alves  <palves@redhat.com>
138
139         PR cli/24732
140         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
141         (pipe_cmd_option_defs): New.
142         (make_pipe_cmd_options_def_group): New.
143         (pipe_command): Use gdb::option::process_options.
144         (pipe_command_completer): New function.
145         (_initialize_cli_cmds): Install completer for "pipe" command.
146
147 2019-07-03  Pedro Alves  <palves@redhat.com>
148
149         * cli/cli-option.c (union option_value) <string>: New field.
150         (struct option_def_and_value): Add ctor, move ctor, dtor and
151         use DISABLE_COPY_AND_ASSIGN.
152         (option_def_and_value::clear_value): New.
153         (parse_option, save_option_value_in_ctx, get_val_type_str)
154         (add_setshow_cmds_for_options): Handle var_string.
155         * cli-option.h (union option_def::var_address) <string>: New
156         field.
157         (struct string_option_def): New.
158         * maint-test-options.c (struct test_options_opts): Add default
159         ctor and use DISABLE_COPY_AND_ASSIGN.
160         <string_opt>: New field.
161         (test_options_opts::~test_options_opts): New.
162         (test_options_opts::dump): Also dump "-string".
163         (test_options_option_defs): Install "string.
164
165 2019-07-03  Pedro Alves  <palves@redhat.com>
166
167         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
168         option_value with a null enumeration.
169         (complete_options): Save the option values in the context.
170         (save_option_value_in_ctx): New, factored out from ...
171         (process_options): ... here.
172         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
173         of the function.
174         * maint-test-options.c (test_options_opts::dump): New, factored
175         out from ...
176         (maintenance_test_options_command_mode): ... here.
177         (maintenance_test_options_command_completion_result): Delete.
178         (maintenance_test_options_command_completion_text): Update
179         comment.
180         (maintenance_show_test_options_completion_result): Change
181         prototype.  Just print
182         maintenance_test_options_command_completion_text.
183         (save_completion_result): New.
184         (maintenance_test_options_completer_mode): Pass options context to
185         complete_options, and then save a dump.
186         (_initialize_maint_test_options): Use add_cmd to install "maint
187         show test-options-completion-result".
188
189 2019-07-03  Pedro Alves  <palves@redhat.com>
190
191         * NEWS (New commands): Mention "with" and "maint with".
192         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
193         (with_command, with_command_completer): New.
194         (pipe_command): Adjust to new repeat_previous
195         interface.
196         (_initialize_cli_cmds): Install the "with" command and its "w"
197         alias.
198         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
199         declarations.
200         * cli/cli-setshow.c (parse_cli_var_uinteger)
201         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
202         argument strings for all var_types.
203         (get_setshow_command_value_string): New, factored out from ...
204         (do_show_command): ... this.
205         * cli/cli-setshow.h: Include <string>.
206         (get_setshow_command_value_string): Declare.
207         * command.h (repeat_previous): Now returns const char *.  Adjust
208         comment.
209         * maint.c: Include "cli/cli-cmds.h".
210         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
211         (_initialize_maint_cmds): Register the "maintenance with" command.
212         * top.c (repeat_previous): Move bits from pipe_command here:
213         Return the saved command line, if any; error out if there's no
214         command to relaunch.
215
216 2019-07-03  Pedro Alves  <palves@redhat.com>
217
218         * NEWS (New commands): Mention "maint set/show test-settings"
219         instead of "maint test-settings".
220         * maint-test-settings.c (maintenance_test_settings_list): Delete.
221         (maintenance_test_settings_set_list): Rename to ...
222         (maintenance_set_test_settings_list): ... this.
223         (maintenance_test_settings_show_list): Rename to  ...
224         (maintenance_show_test_settings_list): ... this.
225         (maintenance_test_settings_cmd): Delete.
226         (maintenance_test_settings_set_cmd): ...
227         (maintenance_set_test_settings_cmd): ... this.
228         (maintenance_test_settings_show_cmd): ...
229         (maintenance_show_test_settings_cmd): ... this.
230         (maintenance_test_settings_show_value_cmd):
231         (maintenance_show_test_settings_value_cmd): ... this.
232         (_initialize_maint_test_settings): No longer install the "maint
233         test-settings" prefix command.  Rename "maint test-settings set"
234         to "maint set test-settings", and "maint test-settings show" to
235         "maint show test-settings".  Adjust all subcommands.
236
237 2019-07-03  Pedro Alves  <palves@redhat.com>
238
239         * maint-test-settings.c: Fix file's intro comment.  Replace all
240         references to "test-options" with references to "test-settings",
241         in comments.
242
243 2019-07-03  Pedro Alves  <palves@redhat.com>
244
245         * maint-test-settings.c (maintenance_test_settings_xxx)
246         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
247         New.
248         (maintenance_test_settings_enums): Use them.
249         (maintenance_test_settings_enum): Default to
250         maintenance_test_settings_xxx.
251         (_initialize_maint_test_settings): Initialize
252         MAINTENANCE_TEST_SETTINGS_FILENAME.
253
254 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
255
256         * breakpoint.h (remove_breakpoints_inf): Change return type to
257         void, move function documentation here.
258         * breakpoint.c (remove_breakpoints_inf): Change return type to
259         void, move function documentation to header.
260
261 2019-07-02  Pedro Alves  <palves@redhat.com>
262
263         * NEWS (Completion improvements): Mention "info threads".
264         * thread.c (struct info_threads_opts, info_threads_option_defs)
265         (make_info_threads_options_def_group): New.
266         (info_threads_command): Use gdb::option::process_options.
267         (info_threads_command_completer): New.
268         (_initialize_thread): Use gdb::option::build_help to build the
269         help text for "info threads".
270
271 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
272
273         * defs.h (generic_load): Move from here...
274         * symfile.h (generic_load): ... to here.  Rename name parameter
275         to args.
276         * symfile.c (generic_load): Add comment.
277
278 2019-07-01  Tom Tromey  <tromey@adacore.com>
279
280         * dwarf2read.c
281         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
282         declaration of without_params.  Fix formatting.
283
284 2019-07-01  Tom Tromey  <tromey@adacore.com>
285
286         * ada-exp.y (find_primitive_type): Update.
287         * ada-lang.h (ada_lookup_symbol): Update.
288         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
289         parameter.
290         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
291
292 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
293
294         PR breakpoints/24541
295         * gdbarch.c: Regenerate.
296         * gdbarch.h: Regenerate.
297         * gdbarch.sh: Add 'stap_adjust_register'.
298         * i386-tdep.c: Include '<unordered_set>'.
299         (i386_stap_adjust_register): New function.
300         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
301         * stap-probe.c (stap_parse_register_operand): Call
302         'gdbarch_stap_adjust_register'.
303
304 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
305
306         PR python/24742
307         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
308         * python/python.c (do_start_initialization): Use 'xmalloc'
309         instead of 'PyMem_Malloc'.
310
311 2019-06-28  Tom Tromey  <tromey@adacore.com>
312
313         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
314         for Ada.
315
316 2019-06-27  Tom Tromey  <tromey@adacore.com>
317
318         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
319         objfile_key.
320         (arm_find_mapping_symbol, arm_record_special_symbol)
321         (_initialize_arm_tdep): Update.
322         (arm_objfile_data_free): Remove.
323
324 2019-06-27  Tom Tromey  <tromey@adacore.com>
325
326         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
327         to cp_print_static_field.
328
329 2019-06-26  Tom Tromey  <tromey@adacore.com>
330
331         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
332         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
333         declare.
334
335 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
336
337         * features/aarch64-core.c (create_feature_aarch64_core):
338         Regenerate.
339         * features/aarch64-core.xml: Add cpsr flags.
340
341 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
342
343         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
344         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
345
346 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
347
348         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
349         field.
350         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
351         use.
352         (arm_record_special_symbol): Don't insert new symbol in sorted
353         position, push it at the end.
354
355 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
356
357         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
358         (arm_mapping_symbol_s): Remove.
359         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
360         (arm_mapping_symbol_vec): New typedef.
361         (struct arm_per_objfile): Add constructor.
362         <section_maps>: Change type to
363         std::unique_ptr<arm_mapping_symbol_vec[]>.
364         (arm_compare_mapping_symbols): Remove.
365         (arm_find_mapping_symbol): Adjust to section_maps type change.
366         (arm_objfile_data_free): Call delete on arm_per_objfile.
367         (arm_record_special_symbol): Adjust to section_maps type change.
368         Allocate arm_per_objfile with new.
369
370 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
371
372         * cli/cli-cmds.c (alias_command): Compare the alias prefix
373         with the command prefix.
374
375 2019-06-25  Tom Tromey  <tom@tromey.com>
376
377         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
378         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
379
380 2019-06-25  Tom Tromey  <tom@tromey.com>
381
382         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
383         type.
384         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
385         protected.
386
387 2019-06-25  Tom Tromey  <tom@tromey.com>
388
389         * tui/tui-winsource.c
390         (tui_source_window_base::set_is_exec_point_at): Add check against
391         LOA_ADDRESS.
392
393 2019-06-25  Tom Tromey  <tom@tromey.com>
394
395         * tui/tui-source.c (tui_set_source_content): Don't check before
396         xfree.
397         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
398
399 2019-06-25  Tom Tromey  <tom@tromey.com>
400
401         * tui/tui-winsource.h (tui_update_source_window_as_is)
402         (tui_alloc_source_buffer, tui_line_is_displayed)
403         (tui_addr_is_displayed): Change type of win_info.
404         * tui/tui-winsource.c (tui_update_source_window_as_is)
405         (tui_clear_source_content, tui_show_source_line)
406         (tui_show_source_content, tui_source_window_base::refill)
407         (tui_source_window_base::set_is_exec_point_at)
408         (tui_source_window_base::set_is_exec_point_at)
409         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
410         (tui_alloc_source_buffer, tui_line_is_displayed)
411         (tui_addr_is_displayed): Change type of win_info.  Update.
412         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
413         (tui_source_window_base::do_make_visible_with_new_height):
414         Update.
415         * tui/tui-source.c (tui_set_source_content)
416         (tui_set_source_content_nil)
417         (tui_source_window::do_scroll_vertical): Update.
418         * tui/tui-layout.c (show_layout): Update.
419         * tui/tui-disasm.c (tui_set_disassem_content)
420         (tui_disasm_window::do_scroll_vertical): Update.
421         * tui/tui-data.h (tui_win_content): Remove.
422         (struct tui_gen_win_info) <content, content_size>: Remove.
423         (struct tui_source_element): Add initializers and destructor.
424         (union tui_which_element, struct tui_win_element): Remove.
425         (struct tui_source_window_base) <content>: New field.
426         (struct tui_data_window): Remove destructor.
427         (tui_alloc_content, tui_free_win_content)
428         (tui_free_all_source_wins_content): Don't declare.
429         * tui/tui-data.c (tui_initialize_static_data): Update.
430         (init_content_element, tui_alloc_content): Remove.
431         (~tui_gen_win_info): Update.
432         (~tui_data_window, tui_free_all_source_wins_content)
433         (tui_free_win_content, free_content, free_content_elements):
434         Remove.
435
436 2019-06-25  Tom Tromey  <tom@tromey.com>
437
438         * tui/tui-winsource.h (tui_clear_source_content)
439         (tui_erase_source_content, tui_show_source_content): Change type
440         of win_info.
441         * tui/tui-winsource.c (tui_clear_source_content)
442         (tui_erase_source_content, tui_show_source_content): Change type
443         of win_info.
444         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
445         * tui/tui-source.h (tui_set_source_content_nil): Change type of
446         win_info.
447         * tui/tui-source.c (tui_set_source_content_nil): Change type of
448         win_info.
449         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
450
451 2019-06-25  Tom Tromey  <tom@tromey.com>
452
453         * tui/tui-winsource.c (tui_clear_source_content)
454         (tui_source_window_base::set_is_exec_point_at): Update.
455         * tui/tui-source.c (tui_set_source_content_nil): Update.
456         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
457         a bool.
458         * tui/tui-data.c (init_content_element): Update.
459
460 2019-06-25  Tom Tromey  <tom@tromey.com>
461
462         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
463         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
464         * tui/tui-layout.c (init_and_make_win): Update.
465         * tui/tui.h (enum tui_win_type): Update.
466         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
467         tui_win_is_auxillary.
468         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
469         tui_win_is_auxillary.
470
471 2019-06-25  Tom Tromey  <tom@tromey.com>
472
473         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
474         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
475         (tui_delete_data_content_windows, tui_display_all_data)
476         (tui_data_window::do_scroll_vertical, tui_display_data_from):
477         Update.
478         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
479         * tui/tui-regs.c (tui_last_regs_line_no)
480         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
481         (tui_show_registers): Update.
482         (tui_show_register_group): Return void.  Update.
483         (tui_display_registers_from, tui_display_reg_element_at_line)
484         (tui_display_registers_from_line, tui_check_register_values):
485         Update.
486         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
487         member.
488         (struct tui_data_window) <regs_content>: Now a std::vector.
489         <regs_content_count>: Remove.
490         (tui_add_content_elements, tui_free_data_content): Don't declare.
491         * tui/tui-data.c (tui_data_window::clear_detail): Update.
492         (init_content_element): Remove DATA_WIN case.  Add assert.
493         (tui_add_content_elements): Remove.
494         (tui_data_window): Update.
495         (tui_free_data_content): Remove.
496         (free_content_elements): Remove DATA_WIN case.
497
498 2019-06-25  Tom Tromey  <tom@tromey.com>
499
500         * tui/tui-data.c (tui_data_item_window): Update.
501         * tui/tui-windata.h (tui_check_data_values): Don't declare.
502         * tui/tui-windata.c (tui_display_all_data)
503         (tui_display_data_from_line): Update.
504         (tui_check_data_values): Remove.
505         * tui/tui-regs.c (tui_show_register_group)
506         (tui_display_reg_element_at_line): Update.
507         * tui/tui-hooks.c (tui_register_changed)
508         (tui_refresh_frame_and_register_information): Call
509         tui_check_register_values.
510         * tui/tui-data.h (struct tui_data_window) <data_content,
511         data_content_count, data_type>: Remove.
512         (enum tui_data_type): Remove.
513
514         * tui/tui-data.c (tui_data_window::clear_detail)
515         (~tui_data_window): Update.
516
517 2019-06-25  Tom Tromey  <tom@tromey.com>
518
519         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
520         declare.
521         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
522         Rename from tui_first_data_item_displayed.  Update.
523         (tui_data_window::refresh_all)
524         (tui_data_window::do_scroll_vertical): Update.
525         * tui/tui-data.h (struct tui_data_window)
526         <first_data_item_displayed>: Declare new method.
527
528 2019-06-25  Tom Tromey  <tom@tromey.com>
529
530         * tui/tui-data.h (tui_init_generic_part): Don't declare.
531         * tui/tui-data.c (tui_init_generic_part): Remove, moving
532         contents...
533         (tui_initialize_static_data): ...here.
534
535 2019-06-25  Tom Tromey  <tom@tromey.com>
536
537         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
538         (tui_display_registers_from, tui_check_register_values): Update.
539         (tui_display_register): Remove win_info parameter; update.
540         (tui_get_register): Change type of parameters.
541         * tui/tui-data.h (struct tui_data_element): Remove.
542         (union tui_which_element) <data>: Remove.
543         <data_window>: Change type.
544         (struct tui_data_item_window): New.
545         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
546         case.  Add assert.
547         (~tui_data_item_window): New destructor.
548         (free_content_elements): Remove DATA_ITEM_WIN case.
549
550 2019-06-25  Tom Tromey  <tom@tromey.com>
551
552         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
553         Remove.
554
555 2019-06-25  Tom Tromey  <tom@tromey.com>
556
557         * tui/tui-data.h (struct tui_command_element): Remove.
558         (union tui_which_element) <command>: Remove.
559         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
560         assert.
561         (free_content_elements): Remove CMD_WIN case.
562
563 2019-06-25  Tom Tromey  <tom@tromey.com>
564
565         * tui/tui-layout.c (tui_set_layout): Update.
566         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
567         * tui/tui-data.c (layout_def): Update.
568
569 2019-06-25  Tom Tromey  <tom@tromey.com>
570
571         * tui/tui-wingeneral.c (tui_refresh_all): Update.
572         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
573         (tui_source_window_base::set_new_height): Update.
574         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
575         Update.
576         (tui_set_locator_fullname, tui_set_locator_info)
577         (tui_show_frame_info): Update.
578         * tui/tui-source.c (tui_set_source_content)
579         (tui_source_is_displayed): Update.
580         * tui/tui-layout.c (show_source_disasm_command, show_data)
581         (show_source_or_disasm_and_command): Update.
582         * tui/tui-disasm.c (tui_set_disassem_content)
583         (tui_get_begin_asm_address): Update.
584         * tui/tui-data.h (struct tui_locator_element): Remove.
585         (union tui_which_element) <locator>: Remove.
586         (struct tui_locator_window): New.
587         (tui_locator_win_info_ptr): Change return type.
588         * tui/tui-data.c (_locator): Change type.
589         (tui_locator_win_info_ptr): Change return type.
590         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
591         (tui_alloc_content): Add assert.
592
593 2019-06-25  Tom Tromey  <tom@tromey.com>
594
595         * tui/tui-winsource.c
596         (tui_exec_info_window::maybe_allocate_content): New method.
597         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
598         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
599         (make_source_or_disasm_window): Add cast.
600         * tui/tui-data.h (union tui_which_element) <simple_string>:
601         Remove.
602         (struct tui_source_info): New.
603         (struct tui_source_window_base) <execution_info>: Change type.
604         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
605         case, and add assert.
606         (tui_alloc_content): Add assert.
607
608 2019-06-25  Tom Tromey  <tom@tromey.com>
609
610         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
611         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
612         * tui/tui-data.c (tui_alloc_win_info): Remove.
613
614 2019-06-25  Tom Tromey  <tom@tromey.com>
615
616         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
617         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
618         can_highlight.
619
620 2019-06-25  Tom Tromey  <tom@tromey.com>
621
622         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
623         make_visible_with_new_height method.
624         (tui_win_info::make_visible_with_new_height): New method.
625         (tui_source_window_base::do_make_visible_with_new_height)
626         (tui_data_window::do_make_visible_with_new_height)
627         (tui_cmd_window::do_make_visible_with_new_height): New methods.
628         (make_visible_with_new_height): Remove.
629         (tui_resize_all, tui_adjust_win_heights): Use
630         make_visible_with_new_height method.
631         * tui/tui-data.h (struct tui_win_info)
632         <do_make_visible_with_new_height, make_visible_with_new_height>:
633         New methods.
634         (struct tui_source_window_base, struct tui_data_window)
635         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
636         methods.
637
638 2019-06-25  Tom Tromey  <tom@tromey.com>
639
640         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
641         method.
642         (update_tab_width): Call update_tab_width method.
643         * tui/tui-data.h (struct tui_win_info)
644         (struct tui_source_window_base) <update_tab_width>: New methods.
645
646 2019-06-25  Tom Tromey  <tom@tromey.com>
647
648         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
649         parameter.
650         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
651         parameter.
652         (tui_gen_win_info::make_visible): Update.
653         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
654         parameter.
655         * tui/tui-data.h (enum tui_box): New enum.
656         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
657
658 2019-06-25  Tom Tromey  <tom@tromey.com>
659
660         * tui/tui-layout.c (make_source_or_disasm_window): Always use
661         init_and_make_win for EXEC_INFO_WIN.
662         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
663         longer inline.
664         (struct tui_win_info) <~tui_win_info>: Inline.
665         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
666         Don't declare.
667         * tui/tui-data.c (source_win, disasm_win): Remove globals.
668         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
669         Remove.
670         (tui_initialize_static_data): Update.
671         (~tui_gen_win_info): Handle more cleanup here.
672         (~tui_source_window_base): Delete "execution_info".
673         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
674
675 2019-06-25  Tom Tromey  <tom@tromey.com>
676
677         * tui/tui-layout.c (make_command_window): Don't set
678         can_highlight.
679         (show_source_disasm_command): Call the reset method.
680         (show_data): Don't set can_highlight.  Call the reset method.
681         (tui_gen_win_info::reset): Rename from init_gen_win_info
682         (init_and_make_win): Simplify.  Return tui_gen_win_info.
683         (show_source_or_disasm_and_command): Call the reset method.
684         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
685         (struct tui_cmd_window): Set can_highlight.
686
687 2019-06-25  Tom Tromey  <tom@tromey.com>
688
689         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
690         from make_visible.
691         (tui_make_visible, tui_make_invisible): Rewrite.
692         (tui_win_info::make_visible): Remove.
693         (tui_source_window_base::make_visible): Update.
694         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
695         method.  Moved from...
696         (struct tui_win_info) <make_visible>: ...here.
697
698 2019-06-25  Tom Tromey  <tom@tromey.com>
699
700         * tui/tui-winsource.c
701         (tui_source_window_base::do_scroll_horizontal): Remove direction
702         parameter.
703         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
704         direction parameter.
705         * tui/tui-win.c (tui_win_info::forward_scroll)
706         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
707         (tui_win_info::right_scroll): Update.
708         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
709         direction parameter.
710         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
711         direction parameter.
712         * tui/tui-data.h (enum tui_scroll_direction): Remove.
713         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
714         Remove direction parameter.
715         (struct tui_source_window_base, struct tui_source_window)
716         (struct tui_disasm_window, struct tui_data_window)
717         (struct tui_cmd_window): Update.
718
719 2019-06-25  Tom Tromey  <tom@tromey.com>
720
721         * tui/tui-winsource.h (tui_set_exec_info_content)
722         (tui_show_exec_info_content, tui_erase_exec_info_content)
723         (tui_clear_exec_info_content, tui_update_exec_info): Change
724         argument to tui_source_window_base.
725         * tui/tui-winsource.c (tui_set_exec_info_content)
726         (tui_show_exec_info_content, tui_erase_exec_info_content)
727         (tui_clear_exec_info_content, tui_update_exec_info): Change
728         argument to tui_source_window_base.
729
730 2019-06-25  Tom Tromey  <tom@tromey.com>
731
732         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
733         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
734
735 2019-06-25  Tom Tromey  <tom@tromey.com>
736
737         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
738         check.
739
740 2019-06-25  Tom Tromey  <tom@tromey.com>
741
742         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
743         type to void.
744         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
745         type to void.
746         * tui/tui-source.c (tui_set_source_content): Update.
747         * tui/tui-disasm.c (tui_set_disassem_content): Update.
748
749 2019-06-25  Tom Tromey  <tom@tromey.com>
750
751         * tui/tui-win.c (window_name_completer, tui_set_focus)
752         (tui_all_windows_info): Use name method.
753         * tui/tui-data.h (struct tui_gen_win_info)
754         (struct tui_source_window, struct tui_disasm_window)
755         (struct tui_data_window, struct tui_cmd_window) <name>: New
756         method.
757         (tui_win_name): Don't declare.
758         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
759         (tui_win_name): Remove.
760
761 2019-06-25  Tom Tromey  <tom@tromey.com>
762
763         * tui/tui-winsource.h (tui_update_source_window)
764         (tui_update_source_window_as_is): Change parameter type.
765         * tui/tui-winsource.c (tui_update_source_window): Change win_info
766         to be a tui_source_window_base.
767         (tui_update_source_window_as_is): Likewise.
768         * tui/tui-win.c (make_visible_with_new_height): Update.
769
770 2019-06-25  Tom Tromey  <tom@tromey.com>
771
772         * tui/tui-winsource.c (tui_erase_source_content)
773         (tui_show_source_content, tui_show_exec_info_content)
774         (tui_erase_exec_info_content): Use refresh_window method.
775         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
776         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
777         from tui_refresh_win.
778         (tui_data_window::refresh_window): New method.
779         (tui_win_info::refresh, tui_source_window_base::refresh)
780         (tui_refresh_all): Use refresh_window method.
781         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
782         method.
783         * tui/tui-regs.c (tui_display_register): Call refresh_window
784         method.
785         * tui/tui-layout.c (show_source_disasm_command)
786         (show_source_or_disasm_and_command): Call refresh_window method.
787         * tui/tui-data.h (struct tui_gen_win_info)
788         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
789         New method.
790
791 2019-06-25  Tom Tromey  <tom@tromey.com>
792
793         * tui/tui.c (tui_rl_other_window, tui_enable)
794         (tui_is_window_visible, tui_get_command_dimension): Update.
795         * tui/tui-winsource.c (tui_update_source_window_as_is)
796         (tui_clear_source_content, tui_erase_source_content)
797         (tui_show_source_line, tui_source_window_base::refill)
798         (tui_source_window_base::do_scroll_horizontal)
799         (tui_source_window_base::set_is_exec_point_at)
800         (tui_update_breakpoint_info, tui_set_exec_info_content)
801         (tui_alloc_source_buffer, tui_line_is_displayed)
802         (tui_addr_is_displayed): Update.
803         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
804         (tui_check_and_display_highlight_if_needed)
805         (tui_win_info::make_visible, tui_win_info::refresh)
806         (tui_refresh_all): Update.
807         * tui/tui-windata.c (tui_first_data_item_displayed)
808         (tui_delete_data_content_windows, tui_erase_data_content)
809         (tui_display_all_data, tui_data_window::refresh_all)
810         (tui_check_data_values): Update.
811         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
812         (tui_set_win_focus_to, tui_win_info::forward_scroll)
813         (tui_win_info::backward_scroll, tui_refresh_all_win)
814         (tui_resize_all, tui_set_focus, tui_all_windows_info)
815         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
816         (tui_source_window_base::set_new_height)
817         (tui_data_window::set_new_height)
818         (make_invisible_and_set_new_height)
819         (make_visible_with_new_height, new_height_ok)
820         (parse_scrolling_args): Update.
821         * tui/tui-stack.c (tui_show_frame_info): Update.
822         * tui/tui-source.c (tui_set_source_content)
823         (tui_set_source_content_nil, tui_source_is_displayed)
824         (tui_source_window::do_scroll_vertical): Update.
825         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
826         (tui_display_registers_from, tui_display_reg_element_at_line)
827         (tui_check_register_values, tui_reg_command): Update.
828         * tui/tui-layout.c (tui_default_win_height)
829         (show_source_disasm_command, show_data, init_and_make_win)
830         (show_source_or_disasm_and_command): Update.
831         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
832         (tui_redisplay_readline, tui_mld_flush)
833         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
834         (tui_getc): Update.
835         * tui/tui-disasm.c (tui_set_disassem_content)
836         (tui_disasm_window::do_scroll_vertical): Update.
837         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
838         Now virtual.
839         (struct tui_win_info): Derive from tui_gen_win_info.
840         <~tui_win_info>: Mark as override.
841         <generic>: Remove member.
842         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
843         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
844         (~tui_data_window, ~tui_win_info)
845         (tui_free_all_source_wins_content): Update.
846         * tui/tui-command.c (tui_refresh_cmd_win): Update.
847
848 2019-06-25  Tom Tromey  <tom@tromey.com>
849
850         * tui/tui-layout.c (init_and_make_win): Use new.
851         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
852         destructor, initializers.
853         (tui_alloc_generic_win_info): Don't declare.
854         * tui/tui-data.c (_locator): Add argument to constructor.
855         (source_win, disasm_win): New globals.
856         (exec_info): Remove.
857         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
858         Update.
859         (tui_alloc_generic_win_info): Remove.
860         (init_content_element): Use new.
861         (tui_win_info::tui_win_info): Update.
862         (free_content_elements) <case DATA_WIN>: Use delete.
863
864 2019-06-25  Tom Tromey  <tom@tromey.com>
865
866         * tui/tui-wingeneral.c (tui_refresh_win): Update.
867         * tui/tui-windata.c (tui_first_data_item_displayed)
868         (tui_delete_data_content_windows): Update.
869         * tui/tui-win.c (tui_data_window::set_new_height): Update.
870         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
871         (tui_display_registers_from, tui_check_register_values): Update.
872         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
873         pointer.
874         * tui/tui-data.c (init_content_element): Update.  Allocate the new
875         window.
876         (tui_free_data_content): Update.
877         (free_content_elements) <case DATA_WIN>: Free the window.
878
879 2019-06-25  Tom Tromey  <tom@tromey.com>
880
881         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
882         Update.
883         * tui/tui-layout.c (make_command_window)
884         (show_source_disasm_command, show_data, init_and_make_win)
885         (show_source_or_disasm_and_command): Update.
886         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
887         method.
888         <can_highight, is_highlighted>: Now bool.
889         (tui_set_win_highlight): Don't declare.
890         * tui/tui-data.c (tui_set_win_highlight): Remove.
891
892 2019-06-25  Tom Tromey  <tom@tromey.com>
893
894         * tui/tui-wingeneral.c (make_visible): Remove check of window
895         type.
896
897 2019-06-25  Tom Tromey  <tom@tromey.com>
898
899         * tui/tui-win.c (tui_win_info::max_height)
900         (tui_cmd_window::max_height): New methods.
901         (new_height_ok): Call max_height.
902         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
903         <max_height>: New method.
904
905 2019-06-25  Tom Tromey  <tom@tromey.com>
906
907         * tui/tui-win.c (tui_source_window_base::set_new_height)
908         (tui_data_window::set_new_height): New methods.
909         (make_invisible_and_set_new_height): Call set_new_height method.
910         * tui/tui-data.h (struct tui_win_info)
911         (struct tui_source_window_base, struct tui_data_window)
912         <set_new_height>: New method.
913
914 2019-06-25  Tom Tromey  <tom@tromey.com>
915
916         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
917         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
918         tui_refresh_data_win.
919         * tui/tui-win.c (tui_source_window_base::refresh_all): New
920         method.
921         (tui_refresh_all_win): Call the refresh_all method.
922         (tui_set_focus): Likewise.
923         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
924         (struct tui_source_window_base, struct tui_data_window) <refresh>:
925         Likewise.
926
927 2019-06-25  Tom Tromey  <tom@tromey.com>
928
929         * tui/tui-winsource.h (tui_refill_source_window)
930         (tui_set_is_exec_point_at): Don't declare.
931         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
932         (tui_source_window_base::refill): Rename from
933         tui_refill_source_window.
934         (tui_source_window_base::do_scroll_horizontal): Update.
935         (tui_source_window_base::set_is_exec_point_at): Rename from
936         tui_set_is_exec_point_at.
937         (tui_update_all_breakpoint_info): Update.
938         * tui/tui-stack.c (tui_show_frame_info): Update.
939         * tui/tui-layout.c (show_data): Add cast.
940         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
941         * tui/tui-data.h (struct tui_source_window_base) <refill,
942         set_is_exec_point_at>: New methods.
943         (tui_source_windows, tui_add_to_source_windows): Update types.
944         (tui_add_to_source_windows): Remove redundant declaration.
945         * tui/tui-data.c (source_windows): Store tui_source_window_base.
946         (tui_source_windows): Change return type.
947         (tui_clear_source_windows_detail): Update.
948         (tui_add_to_source_windows): Change type of parameter.
949         (tui_free_all_source_wins_content): Update.
950
951 2019-06-25  Tom Tromey  <tom@tromey.com>
952
953         * tui/tui-wingeneral.c (tui_win_info::refresh)
954         (tui_source_window_base::refresh): New methods.
955         (tui_refresh_all): Call the refresh method.
956         * tui/tui-data.h (struct tui_win_info)
957         (struct tui_source_window_base) <refresh>: New method.
958
959 2019-06-25  Tom Tromey  <tom@tromey.com>
960
961         * tui/tui.h (tui_is_window_visible): Return bool.
962         * tui/tui.c (tui_is_window_visible): Return bool.
963         * tui/tui-wingeneral.c (tui_make_window, make_visible)
964         (tui_make_visible, tui_make_invisible)
965         (tui_win_info::make_visible)
966         (tui_source_window_base::make_visible, make_all_visible)
967         (tui_make_all_visible, tui_make_all_invisible): Update.
968         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
969         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
970         bool.
971         (struct tui_win_info, struct tui_source_window_base)
972         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
973         * tui/tui-data.c (tui_init_generic_part): Update.
974
975 2019-06-25  Tom Tromey  <tom@tromey.com>
976
977         * tui/tui-wingeneral.c (tui_win_info::make_visible)
978         (tui_source_window_base::make_visible): New methods.
979         (make_all_visible): Make method call.
980         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
981         (struct tui_source_window_base, struct tui_cmd_window): Override
982         make_visible.
983         (tui_win_is_source_type): Don't declare.
984         * tui/tui-data.c (tui_win_is_source_type): Remove.
985
986 2019-06-25  Tom Tromey  <tom@tromey.com>
987
988         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
989         NULL check.
990
991 2019-06-25  Tom Tromey  <tom@tromey.com>
992
993         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
994         Inline constructor.  Add initializers for members.
995         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
996         constructors; now inline in class.
997
998 2019-06-25  Tom Tromey  <tom@tromey.com>
999
1000         * tui/tui-regs.c (tui_show_registers): Update.
1001         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1002         bool.
1003         * tui/tui-data.c (tui_data_window::clear_detail)
1004         (tui_data_window): Update.
1005
1006 2019-06-25  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui-windata.c (tui_display_all_data)
1009         (tui_display_data_from_line, tui_display_data_from)
1010         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1011         Update.
1012         * tui/tui-regs.c (tui_last_regs_line_no)
1013         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1014         (tui_show_registers, tui_show_register_group)
1015         (tui_display_registers_from, tui_display_reg_element_at_line)
1016         (tui_display_registers_from_line, tui_check_register_values)
1017         (tui_reg_next, tui_reg_prev): Update.
1018         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1019         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1020         tui_data_window.
1021         (struct tui_win_info) <detail>: Remove.  Add new fields from
1022         tui_data_info.
1023         (TUI_DATA_WIN): Add cast.
1024         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1025         (~tui_data_window): Simplify.
1026
1027 2019-06-25  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-layout.c (show_source_disasm_command)
1030         (show_source_or_disasm_and_command): Update.
1031         * tui/tui-io.c (update_cmdwin_start_line)
1032         (tui_redisplay_readline): Update.
1033         * tui/tui-data.h (struct tui_command_info): Remove.
1034         (struct tui_win_info) <detail>: Remove command_info member.
1035         (struct tui_data_window) <start_line>: New member, from
1036         tui_command_info.
1037         (TUI_CMD_WIN): Add casts.
1038
1039 2019-06-25  Tom Tromey  <tom@tromey.com>
1040
1041         * tui/tui-winsource.c (tui_update_source_window)
1042         (tui_refill_source_window)
1043         (tui_source_window_base::do_scroll_horizontal)
1044         (tui_update_breakpoint_info, tui_set_exec_info_content)
1045         (tui_show_exec_info_content, tui_erase_exec_info_content)
1046         (tui_clear_exec_info_content): Update.
1047         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1048         Update.
1049         * tui/tui-win.c (make_invisible_and_set_new_height)
1050         (make_visible_with_new_height): Update.
1051         * tui/tui-source.c (tui_set_source_content)
1052         (tui_show_symtab_source): Update.
1053         * tui/tui-layout.c (extract_display_start_addr)
1054         (show_source_disasm_command, show_data)
1055         (make_source_or_disasm_window)
1056         (show_source_or_disasm_and_command): Update.
1057         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1058         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1059         "gdbarch".
1060         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1061         to tui_source_window_base.
1062         (struct tui_win_info) <detail>: Remove source_info member.
1063         (struct tui_source_window_base) <has_locator>: Inline.
1064         Move contents from tui_source_info; rename has_locator member to
1065         m_has_locator.
1066         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1067         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1068         header file.
1069         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1070         Simplify.
1071         (tui_free_all_source_wins_content): Cast to
1072         tui_source_window_base.
1073
1074 2019-06-25  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-win.c (make_invisible_and_set_new_height)
1077         (make_visible_with_new_height): Call has_locator method.
1078         * tui/tui-layout.c (show_source_disasm_command, show_data)
1079         (show_source_or_disasm_and_command): Update for bool change.
1080         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1081         (tui_win_info) <has_locator>: New method.
1082         (struct tui_source_window_base) <has_locator>: New method.
1083         (tui_win_has_locator): Don't declare.
1084         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1085         from tui_win_has_locator.
1086         (tui_source_window_base): Use false, not FALSE.
1087
1088 2019-06-25  Tom Tromey  <tom@tromey.com>
1089
1090         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1091         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1092         clear_detail method directly.
1093         (tui_clear_win_detail): Remove.
1094
1095 2019-06-25  Tom Tromey  <tom@tromey.com>
1096
1097         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1098         "this", not TUI_DISASM_WIN.
1099
1100 2019-06-25  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1103         declare.
1104         * tui/tui-winsource.c
1105         (tui_source_window_base::do_scroll_horizontal): Rename from
1106         tui_horizontal_source_scroll.
1107         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1108         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1109         from tui_vertical_data_scroll.
1110         * tui/tui-win.h (tui_scroll): Don't declare.
1111         * tui/tui-win.c (tui_win_info::forward_scroll)
1112         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1113         (tui_win_info::right_scroll): Rename and update.
1114         (tui_scroll_forward_command, tui_scroll_backward_command)
1115         (tui_scroll_left_command, tui_scroll_right_command): Update.
1116         (tui_scroll): Remove.
1117         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1118         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1119         from tui_vertical_source_scroll.
1120         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1121         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1122         from tui_vertical_disassem_scroll.
1123         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1124         do_scroll_horizontal>: New methods.
1125         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1126         Likewise.
1127         (struct tui_source_window_base): Add do_scroll_horizontal.
1128         (struct tui_source_window, struct tui_disasm_window): Add
1129         do_scroll_vertical.
1130         (struct tui_data_window, struct tui_cmd_window): Add
1131         do_scroll_horizontal and do_scroll_vertical.
1132         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1133
1134 2019-06-25  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-data.h (struct tui_source_window_base): New struct.
1137         (struct tui_source_window): Derive from tui_source_window_base.
1138         (struct tui_disasm_window): New struct.
1139         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1140         from tui_source_window::clear_detail.
1141         (tui_source_window_base): Rename from tui_source_window.
1142         (~tui_source_window_base): Rename from ~tui_source_window.
1143         (tui_alloc_win_info): Create a tui_disasm_window.
1144
1145 2019-06-25  Tom Tromey  <tom@tromey.com>
1146
1147         * tui/tui-data.h (struct tui_source_window)
1148         (struct tui_data_window): Declare destructors.
1149         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1150         destructors.
1151         (tui_win_info): Simplify.
1152
1153 2019-06-25  Tom Tromey  <tom@tromey.com>
1154
1155         * tui/tui-winsource.c (tui_display_main)
1156         (tui_update_source_windows_with_addr)
1157         (tui_update_all_breakpoint_info): Update.
1158         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1159         (new_height_ok, parse_scrolling_args): Update.
1160         * tui/tui-stack.c (tui_show_frame_info): Update.
1161         * tui/tui-data.h (struct tui_list): Remove.
1162         (tui_source_windows): Return a reference to a std::vector.
1163         * tui/tui-data.c (source_windows): Now a std::vector.
1164         (tui_source_windows): Change return type.
1165         (tui_clear_source_windows): Rewrite.
1166         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1167         (tui_free_all_source_wins_content): Rewrite.
1168
1169 2019-06-25  Tom Tromey  <tom@tromey.com>
1170
1171         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1172         (struct tui_data_window, struct tui_cmd_window): Declare
1173         clear_detail method.
1174         * tui/tui-data.c (tui_source_window::clear_detail)
1175         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1176         methods.
1177         (tui_clear_win_detail): Simplify.
1178
1179 2019-06-25  Tom Tromey  <tom@tromey.com>
1180
1181         * tui/tui-layout.c (make_source_window, make_disasm_window)
1182         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1183         Return the new window.
1184         (show_source_disasm_command, show_data)
1185         (show_source_or_disasm_and_command): Update.
1186
1187 2019-06-25  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1190         parameter.  Return the new window.
1191         (show_source_disasm_command): Update and remove NULL check.
1192         (show_source_or_disasm_and_command): Update.
1193
1194 2019-06-25  Tom Tromey  <tom@tromey.com>
1195
1196         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1197
1198 2019-06-25  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-data.h (struct tui_win_info): Make constructor
1201         protected.  Make destructor virtual.  Add initializers.
1202         (tui_source_window, tui_data_window, tui_cmd_window): New
1203         classes.
1204         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1205         constructor.  Add "type" parameter.
1206         (tui_source_window, tui_data_window, tui_cmd_window): New
1207         constructors.
1208         (tui_alloc_win_info): Instantiate the appropriate subclass.
1209
1210 2019-06-25  Tom Tromey  <tom@tromey.com>
1211
1212         * tui/tui-win.c (tui_resize_all): Use delete.
1213         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1214         destructor.
1215         (tui_free_window): Don't declare.
1216         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1217         Update.
1218
1219 2019-06-25  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-data.h (struct tui_win_info): Add constructor.
1222         * tui/tui-data.c (tui_alloc_win_info): Use new.
1223         (tui_free_window): Use delete.
1224
1225 2019-06-22  Tom Tromey  <tom@tromey.com>
1226
1227         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1228         declare.
1229         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1230
1231 2019-06-22  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1234         declare.
1235         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1236
1237 2019-06-22  Tom de Vries  <tdevries@suse.de>
1238
1239         * dwarf2read.c (create_addrmap_from_aranges)
1240         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1241         instead of '%zu'.
1242
1243 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1244
1245         * dwarf2read.h (dwarf2_section_info_def): Remove.
1246         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1247         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1248         std::vector<dwarf2_section_info>.
1249         (struct dwo_file) <~dwo_file>: Remove.
1250         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1251         types field.
1252         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1253         (dwarf2_read_debug_names): Likewise.
1254         (create_debug_types_hash_table): Change parameter type to
1255         array_view, adjust code accordingly.
1256         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1257         (partial_die_info::fixup): Likewise.
1258         (determine_prefix): Likewise.
1259         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1260
1261 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1262
1263         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1264         gdb_bfd_ref_ptr.
1265         <~dwo_file>: Remove call to gdb_bfd_unref.
1266         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1267         gdb_bfd_ref_ptr::get.
1268
1269 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1270
1271         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1272         type to htab_up.
1273         * dwarf2read.c (struct dwo_file): Initialize fields.
1274         <~dwo_file>: New.
1275         (free_dwo_file): Remove, move content to ~dwo_file.
1276         (struct dwo_file_deleter): Remove.
1277         (dwo_file_up>: Remove custom deleter.
1278         (free_dwo_files): Remove.
1279         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1280         dwo_files.
1281         (process_skeletonless_type_units): Call unique_ptr::get.
1282         (allocate_dwo_file_hash_table): Add deleter to created hash
1283         table.  Change return type to htab_up.
1284         (lookup_dwo_file_slot): Don't memset dwo_file, call
1285         unique_ptr::get.
1286         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1287         (create_dwo_unit_in_dwp_v2): Likewise.
1288         (open_and_init_dwo_file): Likewise.
1289         (free_dwo_file_from_slot): Remove.
1290
1291 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1292
1293         * dwarf2read.h (struct dwarf2_section_info) <readin,
1294         is_virtual>: Change type to bool.
1295         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1296         true instead of 1.
1297
1298 2019-06-19  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui-data.h (tui_init_content_element): Don't declare.
1301
1302 2019-06-19  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-data.h (tui_init_win_info): Don't declare.
1305
1306 2019-06-19  Tom de Vries  <tdevries@suse.de>
1307
1308         * dwarf2read.h (abstract_to_concrete): Change type to
1309         std::unordered_map<sect_offset, std::vector<sect_offset>,
1310         gdb::hash_enum<sect_offset>>.
1311
1312 2019-06-19  Tom Tromey  <tromey@adacore.com>
1313
1314         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1315         EVAL_AVOID_SIDE_EFFECTS specially.
1316
1317 2019-06-19  Tom Tromey  <tromey@adacore.com>
1318
1319         * source-cache.c (highlighter): New global.
1320         (source_cache::get_source_lines): Create a highlighter on demand.
1321
1322 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * defs.h (deprecated_interactive_hook): Delete declaration.
1325         * interps.c (clear_interpreter_hooks): Remove use of
1326         deprecated_interactive_hook.
1327         * top.c (deprecated_interactive_hook): Delete definition.
1328         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1329
1330 2019-06-18  Tom de Vries  <tdevries@suse.de>
1331
1332         PR gdb/24515
1333         * dwarf2read.h (abstract_to_concrete): Change type from
1334         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1335         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1336         * dwarf2read.c (read_variable): Update.
1337         (dwarf2_fetch_die_loc_sect_off): Update.
1338
1339 2019-06-17  Tom de Vries  <tdevries@suse.de>
1340
1341         PR gdb/24617
1342         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1343         accessing parent[parent_len - 1].
1344
1345 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1346
1347         PR gdb/24364
1348         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1349         call dtrace_process_dof with NULL dof.
1350
1351 2019-06-16  Tom de Vries  <tdevries@suse.de>
1352
1353         PR gdb/24445
1354         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1355
1356 2019-06-16  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1359         (make_all_visible): Use address of member.
1360
1361 2019-06-16  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1364         (tui_free_window, free_content, free_content_elements): Remove
1365         unnecessary cast.
1366         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1367         cast.
1368         * tui/tui-regs.c (tui_show_register_group)
1369         (tui_display_registers_from, tui_display_reg_element_at_line):
1370         Remove unnecessary cast.
1371
1372 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1373
1374         * linux-nat.c (normal_mask): Delete.
1375         (_initialize_linux_nat): Don't initialise normal_mask.
1376
1377 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1378
1379         PR gdb/24445
1380         * dwarf-index-write.h (write_psymtabs_to_index): Add
1381         dwz_basename parameter.
1382         * dwarf-index-write.c (write_gdbindex): Move file writing to
1383         write_gdbindex_1.  Change return type void.
1384         (assert_file_size): Move up, remove filename parameter.
1385         (write_gdbindex_1): New function.
1386         (write_debug_names): Change return type to void, call
1387         assert_file_size.
1388         (struct index_wip_file): New struct.
1389         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1390         file logic to index_wip_file.  Write index for dwz file if
1391         needed.
1392         (save_gdb_index_command): Pass basename of dwz file, if present.
1393         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1394         build-id of dwz file, if present.
1395         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1396         (dwarf2_get_dwz_file): Likewise.
1397         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1398         (dwarf2_get_dwz_file): Likewise.
1399
1400 2019-06-16  Tom Tromey  <tom@tromey.com>
1401
1402         * coffread.c (process_coff_symbol): Use xstrdup.
1403         * value.c (create_internalvar): Use xstrdup.
1404
1405 2019-06-16  Tom Tromey  <tom@tromey.com>
1406
1407         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1408         * breakpoint.c (stopin_command, stopat_command)
1409         (until_break_command, decode_location_default): Remove unnecessary
1410         cast.
1411         * utils.c (subset_compare): Remove unnecessary cast.
1412         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1413         cast.
1414         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1415         cast.
1416         * infcmd.c (path_command): Remove unnecessary cast.
1417         * coffread.c (decode_type): Remove unnecessary cast.
1418         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1419         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1420         * tui/tui-stack.c (tui_show_locator_content)
1421         (tui_show_frame_info): Remove unnecessary cast.
1422         * tui/tui-win.c (tui_scroll_forward_command)
1423         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1424         (parse_scrolling_args): Remove unnecessary cast.
1425         * tui/tui-data.c (init_win_info, tui_del_window)
1426         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1427         (free_content_elements): Remove unnecessary cast.
1428         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1429         unnecessary cast.
1430         * tui/tui-source.c (tui_set_source_content)
1431         (tui_vertical_source_scroll): Remove unnecessary cast.
1432         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1433         cast.
1434         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1435         * tui/tui-regs.c (tui_display_registers_from)
1436         (tui_display_register): Remove unnecessary cast.
1437         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1438         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1439         (make_visible): Remove unnecessary cast.
1440         * tui/tui-winsource.c (tui_erase_source_content)
1441         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1442         unnecessary cast.
1443         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1444         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1445         * stabsread.c (read_type, read_array_type, read_range_type):
1446         Remove unnecessary cast.
1447         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1448         (parse_symbol, parse_type, upgrade_type, parse_external)
1449         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1450         unnecessary cast.
1451         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1452
1453 2019-06-16  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-data.c (tui_alloc_generic_win_info)
1456         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1457         checks.
1458
1459 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1460             Andrew Burgess  <andrew.burgess@embecosm.com>
1461
1462         * f-typeprint.c (f_print_type): Don't return early for not
1463         associated or not allocated types.
1464         (f_type_print_varspec_suffix): Add print_rank parameter and print
1465         ranks of array types in case they dangling.
1466         (f_type_print_base): Add print_rank parameter.
1467
1468 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1469
1470         * NEWS: Mention new MI commands.
1471         * break-catch-throw.c (enum exception_event_kind): Move to
1472         breakpoint.h.
1473         (print_mention_exception_catchpoint): Output text as a single
1474         message.
1475         (catch_exception_command_1): Rename to...
1476         (catch_exception_event): ...this, make non-static, update header
1477         command, and change some parameter types.
1478         (catch_catch_command): Update for changes to
1479         catch_exception_command_1.
1480         (catch_throw_command): Likewise.
1481         (catch_rethrow_command): Likewise.
1482         * breakpoint.c (enum exception_event_kind): Delete.
1483         * breakpoint.h (enum exception_event_kind): Moved here from
1484         break-catch-throw.c.
1485         (catch_exception_event): Declare.
1486         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1487         (mi_cmd_catch_throw): New function.
1488         (mi_cmd_catch_rethrow): New function.
1489         (mi_cmd_catch_catch): New function.
1490         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1491         'catch-catch' entries.
1492         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1493         (mi_cmd_catch_rethrow): Declare.
1494         (mi_cmd_catch_catch): Declare.
1495
1496 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         * annotate.c (annotate_source_line): Change return type to void,
1499         update implementation to match.
1500         * annotate.h (annotate_source_line): Change return type to void,
1501         update header comment.
1502         * stack.c (print_frame_info): Don't change what frame information
1503         is printed based on whether annotations are on or not.
1504
1505 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1506
1507         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1508         (annotate_source): Make static.
1509         (annotate_source_line): Moved from source.c and renamed from
1510         identify_source_line.  Update the return type.
1511         * annotate.h (annotate_source): Delete declaration.
1512         (annotate_source_line): Declaration moved from source.h, and
1513         renamed from identify_source_line.  Return type updated.
1514         * source.c (identify_source_line): Moved to annotate.c and renamed
1515         to annotate_source_line.
1516         (info_line_command): Remove check of annotation_level.
1517         * source.h (identify_source_line): Move declaration to annotate.h
1518         and rename to annotate_source_line.
1519         * stack.c: Add 'annotate.h' include.
1520         (print_frame_info): Remove check of annotation_level before
1521         calling annotate_source_line.
1522
1523 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * source-cache.c (source_cache::get_plain_source_lines): Use
1526         open_source_file_with_line_charpos instead of just
1527         open_source_file, remove call to find_source_lines.
1528         (source_cache::get_source_lines): Likewise.
1529         * source.c (find_source_lines): Make static.
1530         (get_filename_and_charpos): Renamed into...
1531         (open_source_file_with_line_charpos): ..this along with changes to
1532         return a scoped_fd, and some other minor clean ups.
1533         (identify_source_line): Use open_source_file_with_line_charpos.
1534         (search_command_helper): Use open_source_file_with_line_charpos
1535         instead of just open_source_file, remove call to
1536         find_source_lines.
1537         * source.h (open_source_file_with_line_charpos): Declare new
1538         function.
1539         (find_source_lines): Delete declaration.
1540
1541 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1542
1543         * source.c (get_filename_and_charpos): Remove fullname
1544         parameter.
1545         (identify_source_line): Update call to get_filename_and_charpos.
1546
1547 2019-06-14  Tom Tromey  <tromey@adacore.com>
1548
1549         PR gdb/24502:
1550         * ui-style.h (skip_ansi_escape): Update comment.
1551         * ui-file.h (class no_terminal_escape_file): New class.
1552         * ui-file.c (no_terminal_escape_file::write)
1553         (no_terminal_escape_file::puts): New methods.
1554         * cli/cli-logging.c (handle_redirections): Use
1555         no_terminal_escape_file.
1556
1557 2019-06-14  Tom Tromey  <tromey@adacore.com>
1558
1559         * NEWS: Move convenience variable news above Python news.
1560
1561 2019-06-14  Tom Tromey  <tom@tromey.com>
1562
1563         * gnulib: Move directory to top-level.
1564         * configure.ac: Don't configure gnulib.
1565         * configure: Rebuild.
1566         * common/common-defs.h: Use new path to gnulib.
1567         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1568         (GNULIB_H): Remove.
1569         (INCGNU): Look in new gnulib location.
1570         (HFILES_NO_SRCDIR): Remove gnulib files.
1571         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1572         (generated_files): Remove GNULIB_H.
1573         ($(LIBGNU), all-lib): Remove targets.
1574         (distclean): Don't mention GNULIB_BUILDDIR.
1575         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1576
1577 2019-06-14  Tom Tromey  <tromey@adacore.com>
1578
1579         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1580         Warn if symbol file does not provide any symbols.
1581
1582 2019-06-14  Tom Tromey  <tromey@adacore.com>
1583
1584         * source.c (find_and_open_source): Respect basenames_may_differ.
1585
1586 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1587
1588         * annotate.c (annotate_breakpoints_invalid): Make use of
1589         scoped_restore_terminal_state.
1590         (annotate_frames_invalid): Likewise.
1591
1592 2019-06-14  Tom Tromey  <tromey@adacore.com>
1593
1594         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1595         allow assignment to an internalvar.
1596
1597 2019-06-14  Tom Tromey  <tromey@adacore.com>
1598
1599         * ada-lex.l: Allow "_" in attribute names.
1600
1601 2019-06-14  Tom Tromey  <tromey@adacore.com>
1602
1603         PR gdb/24653:
1604         * regcache.c (registers_changed): Don't call alloca.
1605         * top.c (execute_command): Don't call alloca.
1606
1607 2019-06-13  Pedro Alves  <palves@redhat.com>
1608
1609         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1610         'expression'.  When parsing an expression, error out if there's
1611         junk after "unlimited".
1612         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1613         (do_set_command): Adjust calls to is_unlimited_literal.
1614
1615 2019-06-13  Pedro Alves  <palves@redhat.com>
1616
1617         * compile/compile.c (make_compile_options_def_group): Add braces
1618         around array_view initializer.
1619         * thread.c (make_thread_apply_all_options_def_group)
1620         (make_thread_apply_all_options_def_group): Likewise.
1621
1622 2019-06-13  Pedro Alves  <palves@redhat.com>
1623
1624         * NEWS (New commands): Mention "maint test-options
1625         require-delimiter", "maint test-options unknown-is-error", "maint
1626         test-options unknown-is-operand" and "maint show
1627         test-options-completion-result".
1628         (New command options, command completion): New section.
1629         (Completion improvements): New section.
1630         Mention that you can abbreviate "unlimited".
1631
1632 2019-06-13  Pedro Alves  <palves@redhat.com>
1633
1634         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1635         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1636         * unittests/cli-utils-selftests.c (test_parse_flags)
1637         (test_parse_flags_qcs): Delete.
1638         (test_cli_utils): Don't call deleted functions.
1639
1640 2019-06-13  Pedro Alves  <palves@redhat.com>
1641
1642         * thread.c: Include "cli/cli-option.h".
1643         (tp_array_compar_ascending): Global.
1644         (tp_array_compar): Delete function.
1645         (tp_array_compar_ascending, tp_array_compar_descending): New
1646         functions.
1647         (ascending_option_def, qcs_flag_option_def)
1648         (thr_qcs_flags_option_defs)
1649         (make_thread_apply_all_options_def_group)
1650         (make_thread_apply_options_def_group): New.
1651         (thread_apply_all_command): Use gdb::option::process_options.
1652         (thread_apply_command_completer)
1653         (thread_apply_all_command_completer): New.
1654         (thread_apply_command): Use gdb::option::process_options.
1655         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1656         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1657         to generate help text of "thread apply".  Adjust "taas"'s help.
1658         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1659         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1660
1661 2019-06-13  Pedro Alves  <palves@redhat.com>
1662
1663         * thread.c (thread_apply_command): Check for invalid TID with
1664         isdigit instead of !isalpha.
1665
1666 2019-06-13  Pedro Alves  <palves@redhat.com>
1667
1668         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1669         (validate_flags_qcs): New.
1670         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1671         (validate_flags_qcs): Declare.
1672         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1673         (make_frame_apply_options_def_group): New.
1674         (frame_apply_command_count): Process options with
1675         gdb::option::process_options.
1676         (frame_apply_completer): New.
1677         (frame_apply_level_completer, frame_apply_all_completer)
1678         (frame_apply_completer): New.
1679         (_initialize_stack): Update help of "frame apply", "frame apply
1680         level", "frame apply all" and "faas" to mention supported options
1681         and install command completers.
1682         * stack.h (frame_apply_all_completer): Declare.
1683         * thread.c: Include "stack.h".
1684         (tfaas_command): Add "--".
1685         (_initialize_thread): Update help "tfaas" to mention supported
1686         options and install command completer.
1687
1688 2019-06-13  Pedro Alves  <palves@redhat.com>
1689
1690         * completer.c (complete_nested_command_line): New.
1691         (gdb_completion_word_break_characters_throw): Add assertion.
1692         * completer.h (complete_nested_command_line): Declare.
1693
1694 2019-06-13  Pedro Alves  <palves@redhat.com>
1695
1696         * stack.c (parse_backtrace_qualifiers): New.
1697         (backtrace_command): Use it.
1698         (backtrace_command_completer): Complete on qualifiers.
1699
1700 2019-06-13  Pedro Alves  <palves@redhat.com>
1701
1702         * frame.c: Include "cli/cli-option.h.
1703         (user_set_backtrace_options): New.
1704         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1705         Delete.
1706         (get_prev_frame): Adjust.
1707         (boolean_option_def, uinteger_option_def)
1708         (set_backtrace_option_defs): New.
1709         (_initialize_frame): Adjust and use
1710         gdb::option::add_setshow_cmds_for_options to install "set
1711         backtrace past-main" and "set backtrace past-entry".
1712         * frame.h: Include "cli/cli-option.h".
1713         (struct frame_print_options): Forward declare.
1714         (print_frame_arguments_all, print_frame_arguments_scalars)
1715         (print_frame_arguments_none): Declare.
1716         (print_entry_values): Delete declaration.
1717         (struct frame_print_options, user_frame_print_options): New.
1718         (struct set_backtrace_options): New.
1719         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1720         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1721         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1722         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1723         (list_args_or_locals): Add frame_print_options parameter.
1724         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1725         * python/py-framefilter.c (enumerate_args): Pass down
1726         USER_FRAME_PRINT_OPTIONS.
1727         * stack.c: Include "cli/cli-option.h".
1728         (print_frame_arguments_all, print_frame_arguments_scalars)
1729         (print_frame_arguments_none): Declare.
1730         (print_raw_frame_arguments, print_entry_values): Delete.
1731         (user_frame_print_options): New.
1732         (boolean_option_def, enum_option_def, frame_print_option_defs):
1733         New.
1734         (struct backtrace_cmd_options): New.
1735         (bt_flag_option_def): New.
1736         (backtrace_command_option_defs): New.
1737         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1738         (print_frame_arg, read_frame_arg, print_frame_args)
1739         (print_frame_info, print_frame): Add frame_print_options parameter
1740         and use it.
1741         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1742         (backtrace_command_1): Add frame_print_options and
1743         backtrace_cmd_options parameters and use them.
1744         (make_backtrace_options_def_group): New.
1745         (backtrace_command): Process command options with
1746         gdb::option::process_options.
1747         (backtrace_command_completer): New.
1748         (_initialize_stack): Extend "backtrace"'s help to mention
1749         supported options.  Install completer for "backtrace".
1750         Install some settings commands with add_setshow_cmds_for_options.
1751
1752 2019-06-13  Pedro Alves  <palves@redhat.com>
1753
1754         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1755         and that "set/show print raw frame-arguments" are now deprecated.
1756
1757         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1758         command.
1759         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1760         * stack.c (_initialize_stack): Install "set/show print
1761         raw-frame-arguments", and deprecate "set/show print raw
1762         frame-arguments".
1763         * valprint.c (_initialize_valprint): Deprecate "set/show print
1764         raw".
1765
1766 2019-06-13  Pedro Alves  <palves@redhat.com>
1767
1768         * compile/compile.c (struct compile_options): New.
1769         (compile_flag_option_def, compile_command_option_defs)
1770         (make_compile_options_def_group): New.
1771         (compile_file_command): Handle options with
1772         gdb::option::process_options.
1773         (compile_file_command_completer): New function.
1774         (compile_code_command): Handle options with
1775         gdb::option::process_options.
1776         (compile_code_command_completer): New function.
1777         (_initialize_compiler): Install completers for "compile code" and
1778         "compile file".  Mention available options in "compile code" and
1779         "compile code"'s help.
1780         * completer.c (advance_to_completion_word): New, factored out from
1781         ...
1782         (advance_to_expression_complete_word_point): ... this.
1783         (advance_to_filename_complete_word_point): New.
1784         * completer.h (advance_to_filename_complete_word_point): New
1785         declaration.
1786
1787 2019-06-13  Pedro Alves  <palves@redhat.com>
1788
1789         * compile/compile.c: Include "cli/cli-option.h".
1790         (compile_print_value): Scope data pointer is now a
1791         value_print_options pointer; adjust.
1792         (compile_print_command): Process options.  Scope data pointer is
1793         now a value_print_options pointer; adjust.
1794         (_initialize_compile): Update "compile print"'s help to include
1795         supported options.  Install a completer for "compile print".
1796         * cp-valprint.c (show_vtblprint, show_objectprint)
1797         (show_static_field_print): Delete.
1798         (_initialize_cp_valprint): Don't install "set print
1799         static-members", "set print vtbl", "set print object" here.
1800         * printcmd.c: Include "cli/cli-option.h" and
1801         "common/gdb_optional.h".
1802         (print_command_parse_format): Rework to fill in a
1803         value_print_options instead of a format_data.
1804         (print_value): Change parameter type from format_data pointer to
1805         value_print_options reference.  Adjust.
1806         (print_command_1): Process options.  Adjust to pass down a
1807         value_print_options.
1808         (print_command_completer): New.
1809         (_initialize_printcmd): Install print_command_completer as
1810         handle_brkchars completer for the "print" command.  Update
1811         "print"'s help to include supported options.
1812         * valprint.c: Include "cli/cli-option.h".
1813         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1814         here from cp-valprint.c.
1815         (boolean_option_def, uinteger_option_def)
1816         (value_print_option_defs, make_value_print_options_def_group):
1817         New.  Use gdb::option::add_setshow_cmds_for_options to install
1818         "set print elements", "set print null-stop", "set print repeats",
1819         "set print pretty", "set print union", "set print array", "set
1820         print address", "set print symbol", "set print array-indexes".
1821         * valprint.h: Include <string> and "cli/cli-option.h".
1822         (make_value_print_options_def_group): Declare.
1823         (print_value): Change parameter type from format_data pointer to
1824         value_print_options reference.
1825         (print_command_completer): Declare.
1826
1827 2019-06-13  Pedro Alves  <palves@redhat.com>
1828
1829         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1830         (COMMON_SFILES): Add maint-test-settings.c.
1831         * cli/cli-decode.c (boolean_enums): New global, factored out from
1832         ...
1833         (add_setshow_boolean_cmd): ... here.
1834         * cli/cli-decode.h (boolean_enums): Declare.
1835         * cli/cli-option.c: New file.
1836         * cli/cli-option.h: New file.
1837         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1838         factored out from ...
1839         (parse_cli_boolean_value(const char *)): ... this.
1840         (is_unlimited_literal): Change parameter type to pointer to
1841         pointer.  Adjust and advance ARG pointer.
1842         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1843         (parse_cli_var_enum): New, factored out from ...
1844         (do_set_command): ... this.  Adjust.
1845         * cli/cli-setshow.h (parse_cli_boolean_value)
1846         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1847         (parse_cli_var_enum): Declare.
1848         * cli/cli-utils.c: Include "cli/cli-option.h".
1849         (get_ulongest): New.
1850         * cli/cli-utils.h (get_ulongest): Declare.
1851         (check_for_argument): New overloads.
1852         * maint-test-options.c: New file.
1853
1854 2019-06-13  Pedro Alves  <palves@redhat.com>
1855
1856         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1857         parse a range if "-" is at the end of the string.
1858
1859 2019-06-13  Pedro Alves  <palves@redhat.com>
1860
1861         * cli/cli-setshow.c (parse_auto_binary_operation)
1862         (parse_cli_boolean_value): Don't allow "o".
1863
1864 2019-06-13  Pedro Alves  <palves@redhat.com>
1865
1866         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1867         * NEWS: Mention maint test-settings KIND.
1868         * maint-test-settings.c: New file.
1869
1870 2019-06-13  Pedro Alves  <palves@redhat.com>
1871
1872         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1873         completer.
1874         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1875         "set" completers.
1876
1877 2019-06-13  Pedro Alves  <palves@redhat.com>
1878
1879         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1880         after item.
1881
1882 2019-06-13  Pedro Alves  <palves@redhat.com>
1883
1884         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1885
1886 2019-06-13  Pedro Alves <palves@redhat.com>
1887
1888         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1889         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1890         call.
1891         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1892         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1893         calls.
1894         (check_for_argument): Skip spaces after argument.
1895
1896 2019-06-13  Pedro Alves  <palves@redhat.com>
1897
1898         * thread.c (thread_apply_command): Adjust TID parsing.
1899         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1900         detected before end of string.
1901         (tid_is_in_list): Error out if LIST is invalid.
1902
1903 2019-06-13  Pedro Alves  <palves@redhat.com>
1904
1905         * completer.c (complete_line_internal_1): Rewind completion word
1906         point.
1907         (completion_tracker::advance_custom_word_point_by): Change
1908         parameter type to int.
1909         * completer.h (completion_tracker::advance_custom_word_point_by):
1910         Likewise.
1911
1912 2019-06-13  Pedro Alves  <palves@redhat.com>
1913
1914         * completer.c (advance_to_completion_word): Handle delimiters.
1915
1916 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1917
1918         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1919
1920 2019-06-11  Tom Tromey  <tom@tromey.com>
1921
1922         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1923         (xmalloc_failed): Move to alloc.c.
1924         * alloc.c: New file.
1925         * Makefile.in (COMMON_SFILES): Add alloc.c.
1926
1927 2019-06-11  Tom Tromey  <tom@tromey.com>
1928
1929         * nat/linux-waitpid.c: Don't include server.h.
1930         (linux_debug): Remove.
1931         (my_waitpid): Update.
1932
1933 2019-06-11  Tom Tromey  <tromey@adacore.com>
1934
1935         * infcall.c (_initialize_infcall): Remove trailing newline from
1936         help.
1937         * user-regs.c (_initialize_user_regs): Remove trailing newline
1938         from help.
1939         * typeprint.c (_initialize_typeprint): Remove trailing newline
1940         from help.
1941         * reverse.c (_initialize_reverse): Remove trailing newlines from
1942         help.
1943         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1944         from help.
1945         * language.c (add_set_language_command): Remove trailing newline
1946         from help.
1947         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1948         help.
1949         * disasm.c (_initialize_disasm): Remove trailing newline from
1950         help.
1951         * top.c (init_main): Remove trailing newline from help.
1952         * interps.c (_initialize_interpreter): Remove trailing newline
1953         from help.
1954         * btrace.c (_initialize_btrace): Remove trailing newlines from
1955         help.
1956         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1957         from help.
1958         * python/python.c (_initialize_python): Remove trailing newline
1959         from help.
1960         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1961         help.
1962         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1963         from help.  Reformat some text.
1964         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1965         from help.
1966         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1967         newline from help.
1968
1969 2019-06-11  Tom Tromey  <tromey@adacore.com>
1970
1971         * darwin-nat.c (darwin_decode_exception_message)
1972         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1973
1974 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1975
1976         * valops.c (value_slice): Check for not allocated or not
1977         associated values.
1978
1979 2019-06-10  Tom de Vries  <tdevries@suse.de>
1980
1981         PR gdb/24618
1982         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1983         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1984         invalid.
1985
1986 2019-06-10  Tom de Vries  <tdevries@suse.de>
1987
1988         PR gdb/24611
1989         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1990         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1991
1992 2019-06-10  Tom de Vries  <tdevries@suse.de>
1993
1994         PR symtab/24545
1995         * symtab.c (struct demangled_name_entry): Add language field.
1996         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1997         static minimal symbol".  Set and use language field.
1998
1999 2019-06-10  Tom Tromey  <tromey@adacore.com>
2000
2001         * ada-lang.c (_initialize_ada_language): Update help text.
2002
2003 2019-06-10  Tom Tromey  <tromey@adacore.com>
2004
2005         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2006         with a newline.
2007         * guile/guile.c (handle_boot_error): Don't end warning with a
2008         newline.
2009         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2010         warning with a newline.
2011         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2012         newline.
2013         (s12z_frame_cache): Likewise.
2014         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2015         a newline.
2016         * solib-svr4.c (disable_probes_interface): Don't end warning with
2017         a newline.
2018         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2019         newline.
2020         * python/python.c (do_finish_initialization): Don't end warning
2021         with a newline.
2022
2023 2019-06-10  Tom Tromey  <tom@tromey.com>
2024
2025         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2026         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2027         gdbpy_enter.
2028
2029 2019-06-10  Tom Tromey  <tromey@adacore.com>
2030
2031         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2032         data.
2033         (elf_new_init): Don't call stabsread_new_init.
2034         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2035         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2036         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2037
2038 2019-06-10  Tom de Vries  <tdevries@suse.de>
2039
2040         PR symtab/16264
2041         PR symtab/24517
2042         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2043
2044 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2045
2046         * source.c (find_and_open_source): Also rewrite relative file
2047         names.
2048
2049 2019-04-26  Amos Bird  <amosbird@gmail.com>
2050
2051         * annotate.c (annotate_thread_exited): Add "thread-exited"
2052         annotation.
2053
2054 2019-06-06  Tom Tromey  <tromey@adacore.com>
2055
2056         * maint.h (class scoped_command_stats): Use
2057         DISABLE_COPY_AND_ASSIGN.
2058         <print_time>: New method.
2059         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2060         print_time.
2061         (scoped_command_stats::print_time): New method.
2062
2063 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2064
2065         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2066         instructions of lengths 6 or 8 bytes.
2067
2068 2019-06-04  Pedro Alves  <palves@redhat.com>
2069
2070         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2071
2072         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2073         * breakpoint.c (condition_completer): Likewise.
2074         * cli/cli-dump.c (scan_expression): Likewise.
2075         * common/filestuff.c (mkdir_recursive): Likewise.
2076         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2077         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2078         (gdb_abspath): Likewise.
2079         * compile/compile-cplus-types.c
2080         (compile_cplus_instance::decl_name): Likewise.
2081         * completer.c (complete_explicit_location):
2082         (signal_completer, reg_or_group_completer_1): Likewise.
2083         * cp-support.c (cp_remove_params_if_any): Likewise.
2084         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2085         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2086         * infcmd.c (strip_bg_char): Likewise.
2087         * linespec.c (copy_token_string): Likewise.
2088         * mi/mi-main.c (output_cores): Likewise.
2089         * psymtab.c (psymtab_search_name):
2090         * symfile.c (test_set_ext_lang_command): Likewise.
2091         * target.c (target_fileio_read_stralloc): Likewise.
2092         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2093         * value.c (complete_internalvar): Likewise.
2094
2095 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2096
2097         Add objfile property to gdb.Type.
2098         * NEWS: Mention Python API addition.
2099         * python/py-type.c (typy_get_objfile): New method.
2100
2101 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2102
2103         * NEWS: Mention the new set|show style [title|highlight].
2104         Mention changes to "show style", "help" and "apropos".
2105
2106 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2107
2108         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2109         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2110         instead of print_help_for_command.
2111         (print_doc_of_command): New function.
2112         (help_list): Add 'apropos -v word' suggestion.
2113         (print_help_for_command): Style the command name using title style.
2114         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2115         (_initialize_cli_cmds): Describe -v in apropos_command help.
2116
2117 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2118
2119         * cli/cli-style.h (cli_style_option): Add name in constructor,
2120         add m_name class member, add constructor with intensity,
2121         add name class function.
2122         (cli_style_option::add_setshow_commands): Remove name argument.
2123         (highlight_style, title_style): New styles.
2124         * cli/cli-style.c (do_show): New function that shows a style
2125         characteristic styling the style name with itself.
2126         (set_style_name): New function.
2127         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2128         Update all callers according to the changes in cli/cli-style.h.
2129         * utils.h (fputs_highlighted): New function.
2130         * utils.c (fputs_highlighted): Likewise.
2131
2132 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2133
2134         * NEWS: Mention new pipe command and new convenience variables.
2135
2136 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2137
2138         * cli/cli-cmds.c (pipe_command): New function.
2139         (_initialize_cli_cmds): Call add_com for pipe_command.
2140         Define | as an alias for pipe.
2141         (exit_status_set_internal_vars): New function.
2142         (shell_escape): Call exit_status_set_internal_vars.
2143         cli/cli-decode.c (find_command_name_length): Recognize | as
2144         a single character command.
2145
2146 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2147
2148         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2149         top.c (execute_command_to_ui_file): New function, mostly a copy
2150         of execute_command_to_string.
2151         (execute_command_to_string): Implement by calling
2152         execute_command_to_ui_file.
2153
2154 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2155
2156         * top.h (saved_command_line): Remove declaration.
2157         * top.c (previous_saved_command_line, previous_repeat_arguments):
2158         New variables.
2159         (saved_command_line): Make static, define together with other
2160         'repeat variables'.
2161         (dont_repeat): Clear repeat_arguments.
2162         (repeat_previous, get_saved_command_line, save_command_line):
2163         New functions.
2164         (gdb_init): Initialize saved_command_line
2165         and previous_saved_command_line.
2166         * main.c (captured_main_1): Remove saved_command_line initialization.
2167         * event-top.c (handle_line_of_input): Update to use
2168         the new 'repeat' related functions instead of direct access to
2169         saved_command_line.
2170         * command.h (repeat_previous, get_saved_command_line,
2171         save_command_line): New declarations.
2172         (dont_repeat): Add comment.
2173
2174 2019-05-30  Tom Tromey  <tromey@adacore.com>
2175
2176         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2177         Fix comment.
2178         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2179
2180 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2181
2182         PR cli/24587
2183         * completer.c (complete): Initialize variable word.
2184
2185 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2186
2187         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2188         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2189         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2190         'body' is NULL to the outter 'if', protecting the '!is_define'
2191         situation as well.
2192
2193 2019-05-29  Tom Tromey  <tromey@adacore.com>
2194
2195         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2196         (dwarf_unknown): New function.
2197         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2198         (dwarf_type_encoding_name): Use dwarf_unknown.
2199
2200 2019-05-29  Tom Tromey  <tromey@adacore.com>
2201
2202         PR c++/20020:
2203         * cp-valprint.c (cp_print_value_fields): Call
2204         cp_print_static_field inside "try".
2205
2206 2019-05-29  Tom Tromey  <tromey@adacore.com>
2207
2208         * inflow.c (struct terminal_info): Add default operator=.
2209         * configure: Rebuild.
2210         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2211         -Wdeprecated-copy-dtor, -Wredundant-move.
2212
2213 2019-05-29  Tom Tromey  <tromey@adacore.com>
2214
2215         * NEWS: Add entry.
2216         * infcmd.c (print_return_value_1): Handle finish_print
2217         option.
2218         (show_print_finish): New function.
2219         (_initialize_infcmd): Add "set/show print finish" commands.
2220         * valprint.c (user_print_options): Initialize new member.
2221         * valprint.h (struct value_print_options) <finish_print>: New
2222         member.
2223
2224 2019-05-28  Tom Tromey  <tromey@adacore.com>
2225
2226         * ada-lang.c (ada_remove_Xbn_suffix)
2227         (find_old_style_renaming_symbol)
2228         (parse_old_style_renaming): Remove.
2229         (ada_find_renaming_symbol): Don't call
2230         find_old_style_renaming_symbol.
2231         (ada_is_renaming_symbol): Rename from
2232         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2233         bool.  Now static.
2234         (ada_read_var_value): Update and simplify.
2235         * ada-exp.y (write_var_or_type): Remove old code.
2236
2237 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2238
2239         * event-top.c: Remove include comment.
2240         * inflow.c (class scoped_ignore_sigttou): Move from here...
2241         * inflow.h (class scoped_ignore_sigttou): ...to here.
2242         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2243         * top.c:  Remove include comment.
2244
2245 2019-05-27  Tom Tromey  <tom@tromey.com>
2246
2247         * NEWS: Fix typo.
2248
2249 2019-05-22  Tom Tromey  <tromey@adacore.com>
2250
2251         * target.c (target_follow_exec): Constify parameter.
2252         * target-delegates.c: Rebuild.
2253         * remote.c (remote_target::follow_exec): Constify parameter.
2254         * infrun.c (follow_exec): Constify parameter.
2255         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2256         (target_follow_exec): Likewise.
2257
2258 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2259
2260         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2261         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2262
2263 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2264
2265         * NEWS: Add debugredirect and testsuite sections.
2266
2267 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2268
2269         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2270         target descriptions using exclusively floating point register name
2271         aliases.
2272
2273 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         PR gdb/18644:
2276         * f-lang.c (build_fortran_types): Handle the case where
2277         gdbarch_floatformat_for_type returns a nullptr.
2278
2279 2019-05-21  Tom de Vries  <tdevries@suse.de>
2280
2281         PR cli/24587
2282         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2283
2284 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         PR gdb/18644:
2287         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2288         16-byte floats.
2289         * i386-tdep.c (i386_floatformat_for_type): Use
2290         floatformats_ia64_quad for the 16-byte floating point component
2291         within a fortran 32-byte complex number.
2292
2293 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2296         delete default constructor.
2297         (find_partial_die): Update to return const struct.
2298         (partial_die_parent_scope): Move variable declaration into scope
2299         of its use and change its type to auto.
2300         (guess_partial_die_structure_name): Likewise.
2301         (partial_die_info::fixup): Likewise.
2302
2303 2019-05-17  Tom Tromey  <tromey@adacore.com>
2304
2305         * source.c (find_and_open_source): Remove cast.
2306
2307 2019-05-17  Tom Tromey  <tromey@adacore.com>
2308
2309         * annotate.c (annotate_source): Make "filename" const.
2310         * annotate.h (annotate_source): Use const.
2311
2312 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2313
2314         * disasm.c (set_disassembler_options): Send errors to stderr.
2315
2316 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2317
2318         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2319         (cli_interp_base::set_logging): Check debug_redirect.
2320         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2321         * cli/cli-logging.c (debug_redirect): Add static variable.
2322         (pop_output_files): Add default param.
2323         (handle_redirections): Print debug setting.
2324         (show_logging_command): Likewise.
2325         (_initialize_cli_logging): Add debugredirect command.
2326         * interps.c (current_interp_set_logging): Add debug_redirect
2327         parameter.
2328         * interps.h (set_logging): Add debug_redirect parameter.
2329         (current_interp_set_logging): Likewise.
2330         * mi/mi-common.h: Likewise.
2331         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2332
2333 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2334             Tom Tromey  <tromey@adacore.com>
2335
2336         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2337         directly.
2338         * cli/cli-interp.h (make_logging_output): Remove declaration.
2339         * cli/cli-logging.c (make_logging_output): Remove function.
2340         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2341         directly.
2342         * ui-file.c (tee_file::tee_file): Remove bools.
2343         (tee_file::~tee_file): Remove deletes.
2344         * ui-file.h (tee_file): Remove bools.
2345
2346 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2347
2348         * mi/mi-cmds.h (mi_cmd_complete): New function.
2349         * mi/mi-main.c (mi_cmd_complete): Likewise.
2350         * mi/mi-cmds.c: Define new MI command -complete.
2351         * NEWS: Mention new -complete command.
2352
2353 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2354
2355         * completer.h (complete): New function.
2356         * completer.c (complete): Likewise.
2357         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2358         function defined in completer.h.
2359
2360 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2361
2362         * MAINTAINERS (Write After Approval): Add myself.
2363
2364 2019-05-17  Tom de Vries  <tdevries@suse.de>
2365
2366         PR gdb/24094
2367         * dwarf2read.c (struct cu_partial_die_info): New struct.
2368         (find_partial_die): Return cu_partial_die_info.
2369         (partial_die_parent_scope, guess_partial_die_structure_name)
2370         (partial_die_info::fixup): Handle new return type of find_partial_die.
2371
2372 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2373
2374         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2375         "std::string", simplifying the algorithm.
2376
2377 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2378
2379         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2380         (stap_static_probe_ops::get_probes): Likewise.
2381
2382 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2383
2384         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2385         '-')" and "else if".
2386         (stap_parse_single_operand): Join checks for
2387         "gdbarch_stap_parse_special_token_p" and
2388         "gdbarch_stap_parse_special_token" in the same "if" statement.
2389         Invert check when verifying for operation on register
2390         displacement.
2391
2392 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2393
2394         * stap-probe.c (stap_get_opcode): Update comment.
2395         (stap_get_expected_argument_type): Likewise.
2396         (handle_stap_probe): Likewise.
2397
2398 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2399
2400         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2401         return type to 'bool'.  Adjust comment.  Use 'bool' when
2402         appropriate.
2403         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2404         * stap-probe.c (stap_parse_argument_1): Likewise.
2405         (stap_is_operator): Likewise.
2406         (stap_is_generic_prefix): Likewise.
2407         (stap_is_register_prefix): Likewise.
2408         (stap_is_register_indirection_prefix): Likewise.
2409         (stap_is_integer_prefix): Likewise.
2410         (stap_generic_check_suffix): Likewise.
2411         (stap_check_integer_suffix): Likewise.
2412         (stap_check_register_suffix): Likewise.
2413         (stap_check_register_indirection_suffix): Likewise.
2414         (stap_parse_register_operand): Likewise.
2415         (stap_parse_single_operand): Likewise.
2416         (stap_parse_argument_1): Likewise.
2417         (stap_probe::get_argument_count): Likewise.
2418         (stap_is_operator): Likewise.
2419
2420 2019-05-16  Tom Tromey  <tromey@adacore.com>
2421
2422         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2423         keyword to foreach.
2424
2425 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2426
2427         * linux-thread-db.c (try_thread_db_load_1): Change return type
2428         to bool.
2429         (try_thread_db_load): Likewise.
2430         (try_thread_db_load_from_pdir_1): Likewise.
2431         (try_thread_db_load_from_pdir): Likewise.
2432         (try_thread_db_load_from_sdir): Likewise.
2433         (try_thread_db_load_from_dir): Likewise.
2434         (thread_db_load_search): Likewise.
2435         (has_libpthread): Likewise.
2436         (thread_db_load): Likewise.
2437
2438 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2439
2440         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2441         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2442         NULL, and complain/return if that's the case.
2443
2444 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2445
2446         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2447         (advance, posn, abstract_read_memory): New functions.
2448         [struct mem_read_abstraction]: New struct.
2449         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2450
2451 2019-05-14  Tom Tromey  <tromey@adacore.com>
2452
2453         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2454         value is not lval_memory.
2455
2456 2019-05-14  Tom Tromey  <tromey@adacore.com>
2457
2458         * solib.c (info_sharedlibrary_command): Style the file name.
2459
2460 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2461
2462         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2463         (aarch64_vnv_type): Likewise.
2464         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2465         * common/tdesc.c: Likewise.
2466         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2467         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2468         * features/aarch64-fpu.xml: Add ieee half view.
2469         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2470         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2471         * gdbtypes.h (struct builtin_type): Likewise.
2472         (struct objfile_type): Likewise.
2473
2474 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2475
2476         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2477         typo.
2478         * location.h (string_to_event_location): Likewise.
2479
2480 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2481
2482         GDB 8.3 released.
2483
2484 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2485
2486         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2487         New variable declaration.
2488         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2489         New variable.
2490         (print_one_breakpoint): Use ui_out::test_flags and new global
2491         variable to compute use_fixed_output.
2492         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2493         Remove.
2494         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2495         (mi_multi_location_breakpoint_output_fixed): Remove.
2496         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2497         new variable.
2498         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2499         fix_multi_location_breakpoint_output flag if version >= 3.
2500         * ui-out.h (enum ui_out_flag)
2501         <fix_multi_location_breakpoint_output>: New enumerator.
2502
2503 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2504
2505         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2506
2507 2019-05-10  Tom Tromey  <tromey@adacore.com>
2508
2509         * ada-lang.c (catch_ada_completer): New function.
2510         (_initialize_ada_language): Use it.
2511
2512 2019-05-10  Tom Tromey  <tromey@adacore.com>
2513
2514         * thread.c (print_thread_info): Make "requested_threads" const.
2515         * gdbthread.h (print_thread_info): Make "requested_threads"
2516         const.
2517         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2518         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2519
2520 2019-05-08  Tom Tromey  <tom@tromey.com>
2521
2522         * gdbtypes.c (objfile_type_data): Change type.
2523         (objfile_type, _initialize_gdbtypes): Update.
2524
2525 2019-05-08  Tom Tromey  <tom@tromey.com>
2526
2527         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2528         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2529         (_initialize_dwarf2_frame): Update.
2530
2531 2019-05-08  Tom Tromey  <tom@tromey.com>
2532
2533         * objc-lang.c (objc_objfile_data): Change type.
2534         (find_methods): Update.
2535         (_initialize_objc_lang): Remove.
2536
2537 2019-05-08  Tom Tromey  <tom@tromey.com>
2538
2539         * stabsread.c (rs6000_builtin_type_data): Change type.
2540         (rs6000_builtin_type, _initialize_stabsread): Update.
2541
2542 2019-05-08  Tom Tromey  <tom@tromey.com>
2543
2544         * mips-tdep.c (mips_pdr_data): Remove.
2545         (_initialize_mips_tdep): Update.
2546
2547 2019-05-08  Tom Tromey  <tom@tromey.com>
2548
2549         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2550         (hppa_init_objfile_priv_data, read_unwind_info)
2551         (find_unwind_entry, _initialize_hppa_tdep): Update.
2552
2553 2019-05-08  Tom Tromey  <tom@tromey.com>
2554
2555         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2556         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2557         on obstack.
2558         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2559
2560 2019-05-08  Tom Tromey  <tom@tromey.com>
2561
2562         * mdebugread.c (basic_type_data): Change type.
2563         (basic_type, _initialize_mdebugread): Update.
2564
2565 2019-05-08  Tom Tromey  <tom@tromey.com>
2566
2567         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2568
2569 2019-05-08  Tom Tromey  <tom@tromey.com>
2570
2571         * nto-tdep.c (nto_inferior_data_reg): Change type.
2572         (nto_inferior_data): Update.
2573         (nto_inferior_data_cleanup, nto_new_inferior_data)
2574         (_initialize_nto_tdep): Remove.
2575         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2576
2577 2019-05-08  Tom Tromey  <tom@tromey.com>
2578
2579         * ada-lang.c (struct ada_inferior_data): Add initializers.
2580         (ada_inferior_data): Change type.
2581         (ada_inferior_data_cleanup): Remove.
2582         (get_ada_inferior_data, ada_inferior_exit)
2583         (struct ada_pspace_data): Add initializers, destructor.
2584         (ada_pspace_data_handle): Change type.
2585         (get_ada_pspace_data): Update.
2586         (ada_pspace_data_cleanup): Remove.
2587
2588 2019-05-08  Tom Tromey  <tom@tromey.com>
2589
2590         * coffread.c (struct coff_symfile_info): Add initializers.
2591         (coff_objfile_data_key): Move lower.  Change type.
2592         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2593         Update.
2594         (coff_free_info): Remove.
2595
2596 2019-05-08  Tom Tromey  <tom@tromey.com>
2597
2598         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2599         (fbsd_pspace_data_handle): Move lower.  Change type.
2600         (get_fbsd_pspace_data): Update.
2601         (fbsd_pspace_data_cleanup): Remove.
2602         (_initialize_fbsd_tdep): Update.
2603
2604 2019-05-08  Tom Tromey  <tom@tromey.com>
2605
2606         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2607         (get_ada_tasks_pspace_data): Update.
2608         (ada_tasks_pspace_data_cleanup): Remove.
2609         (_initialize_tasks): Update.
2610         (ada_tasks_inferior_data_handle): Change type.
2611         (get_ada_tasks_inferior_data): Update.
2612         (ada_tasks_inferior_data_cleanup): Remove.
2613         (struct ada_tasks_pspace_data): Add initializers.
2614
2615 2019-05-08  Tom Tromey  <tom@tromey.com>
2616
2617         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2618         * symfile-debug.c (debug_sym_get_probes): Change type.
2619         * stap-probe.c (handle_stap_probe):
2620         (stap_static_probe_ops::get_probes): Change type.
2621         * probe.h (class static_probe_ops) <get_probes>: Change type.
2622         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2623         (parse_probes_in_pspace): Update.
2624         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2625         Update.
2626         (any_static_probe_ops::get_probes): Change type.
2627         * elfread.c (elfread_data): New typedef.
2628         (probe_key): Change type.
2629         (elf_get_probes): Likewise.  Update.
2630         (probe_key_free): Remove.
2631         (_initialize_elfread): Update.
2632         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2633         Change type.
2634         (dtrace_process_dof_probe, dtrace_process_dof)
2635         (dtrace_static_probe_ops::get_probe): Change type.
2636
2637 2019-05-08  Tom Tromey  <tom@tromey.com>
2638
2639         * xcoffread.c (struct xcoff_symfile_info): Rename from
2640         coff_symfile_info.  Add initializers.
2641         (xcoff_objfile_data_key): Move lower.  Change type.
2642         (XCOFF_DATA): Rewrite.
2643         (xcoff_free_info): Remove.
2644         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2645         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2646         (xcoff_initial_scan): Update.
2647
2648 2019-05-08  Tom Tromey  <tom@tromey.com>
2649
2650         * solib-svr4.c (struct svr4_info): Add initializers and
2651         destructor.
2652         <probes_table>: Now an htab_up.
2653         (solib_svr4_pspace_data): Change type.
2654         (free_probes_table): Simplify.
2655         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2656         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2657         (probes_table_remove_objfile_probes, register_solib_event_probe)
2658         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2659         (_initialize_svr4_solib): Update.
2660
2661 2019-05-08  Tom Tromey  <tom@tromey.com>
2662
2663         * remote.c (remote_pspace_data): Change type.
2664         (remote_pspace_data_cleanup): Remove.
2665         (get_remote_exec_file, set_pspace_remote_exec_file)
2666         (_initialize_remote): Update.
2667
2668 2019-05-08  Tom Tromey  <tom@tromey.com>
2669
2670         * breakpoint.c (breakpoint_objfile_key): Change type.
2671         (get_breakpoint_objfile_data): Update.
2672         (free_breakpoint_objfile_data): Remove.
2673         (_initialize_breakpoint): Update.
2674
2675 2019-05-08  Tom Tromey  <tom@tromey.com>
2676
2677         * linux-tdep.c (struct linux_info): Add initializers.
2678         (linux_inferior_data): Move.  Change type.
2679         (invalidate_linux_cache_inf): Update.
2680         (linux_inferior_data_cleanup): Remove.
2681         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2682
2683 2019-05-08  Tom Tromey  <tom@tromey.com>
2684
2685         * auxv.c (auxv_inferior_data): Move.  Change type.
2686         (auxv_inferior_data_cleanup): Remove.
2687         (invalidate_auxv_cache_inf): Rewrite.
2688         (get_auxv_inferior_data, _initialize_auxv): Update.
2689
2690 2019-05-08  Tom Tromey  <tom@tromey.com>
2691
2692         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2693         (symfile_debug_objfile_data_key): Change type.
2694         (symfile_debug_installed, debug_qf_has_symbols)
2695         (debug_qf_find_last_source_symtab)
2696         (debug_qf_forget_cached_source_info)
2697         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2698         (debug_qf_print_stats, debug_qf_dump)
2699         (debug_qf_expand_symtabs_for_function)
2700         (debug_qf_expand_all_symtabs)
2701         (debug_qf_expand_symtabs_with_fullname)
2702         (debug_qf_map_matching_symbols)
2703         (debug_qf_expand_symtabs_matching)
2704         (debug_qf_find_pc_sect_compunit_symtab)
2705         (debug_qf_map_symbol_filenames)
2706         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2707         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2708         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2709         (debug_sym_read_linetable, debug_sym_relocate): Update.
2710         (symfile_debug_free_objfile): Remove.
2711         (install_symfile_debug_logging, _initialize_symfile_debug):
2712         Update.
2713
2714 2019-05-08  Tom Tromey  <tom@tromey.com>
2715
2716         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2717         allocate_on_obstack.
2718         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2719         (get_dwarf2_per_objfile): Update.
2720         (set_dwarf2_per_objfile): Remove.
2721         (dwarf2_has_info, dwarf2_get_section_info): Update.
2722         (dwarf2_free_objfile): Remove.
2723         (_initialize_dwarf2_read): Update.
2724
2725 2019-05-08  Tom Tromey  <tom@tromey.com>
2726
2727         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2728         initializers.
2729         <unsupported_script_warning_printed,
2730         script_not_found_warning_printed>: Now bool.
2731         (auto_load_pspace_data): Change type.
2732         (~auto_load_pspace_info): Rename from
2733         auto_load_pspace_data_cleanup.
2734         (get_auto_load_pspace_data, init_loaded_scripts_info)
2735         (clear_section_scripts, maybe_print_unsupported_script_warning)
2736         (maybe_print_script_not_found_warning, _initialize_auto_load):
2737         Update.
2738
2739 2019-05-08  Tom Tromey  <tom@tromey.com>
2740
2741         * objfiles.c (objfile_pspace_info): Add destructor and
2742         initializers.
2743         (objfiles_pspace_data): Change type.
2744         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2745         (get_objfile_pspace_data): Update.
2746         (objfiles_bfd_data): Change type.
2747         (get_objfile_bfd_data): Update.
2748         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2749
2750 2019-05-08  Tom Tromey  <tom@tromey.com>
2751
2752         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2753         Change type.
2754         (get_catch_syscall_inferior_data): Update.
2755         (catch_syscall_inferior_data_cleanup): Remove.
2756         (_initialize_break_catch_syscall): Update.
2757
2758 2019-05-08  Tom Tromey  <tom@tromey.com>
2759
2760         * inflow.c (struct terminal_info): Add destructor and
2761         initializers.
2762         (inflow_inferior_data): Change type.
2763         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2764         (get_inflow_inferior_data, inflow_inferior_exit)
2765         (swap_terminal_info, _initialize_inflow): Update.
2766
2767 2019-05-08  Tom Tromey  <tom@tromey.com>
2768
2769         * target-dcache.c (target_dcache_cleanup): Remove.
2770         (target_dcache_aspace_key): Change type.
2771         (target_dcache_init_p, target_dcache_invalidate)
2772         (target_dcache_get, target_dcache_get_or_init)
2773         (_initialize_target_dcache): Update.
2774         * dcache.h (struct dcache_deleter): New.
2775
2776 2019-05-08  Tom Tromey  <tom@tromey.com>
2777
2778         * symtab.c (struct symbol_cache): Add destructor and
2779         initializers.
2780         (symbol_cache_key): Move.  Change type.
2781         (make_symbol_cache, free_symbol_cache): Remove.
2782         (get_symbol_cache): Update.
2783         (symbol_cache_cleanup): Remove.
2784         (ALL_PSPACES, symbol_cache_flush)
2785         (maintenance_print_symbol_cache)
2786         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2787         Update.
2788
2789 2019-05-08  Tom Tromey  <tom@tromey.com>
2790
2791         * symtab.c (struct main_info): Add destructor and initializers.
2792         (main_progspace_key): Move.  Change type.
2793         (get_main_info): Update.
2794         (main_info_cleanup): Remove.
2795         (_initialize_symtab): Update.
2796
2797 2019-05-08  Tom Tromey  <tom@tromey.com>
2798
2799         * registry.h (DECLARE_REGISTRY): Define the _key class.
2800
2801 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2802
2803         * NEWS: Merge two 'New commands' sections.
2804
2805 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2806
2807         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2808         parameter and use Ada language definition instead.
2809         (ada_val_print_ptr): Remove unused language parameter.
2810         (ada_val_print_num): Remove language parameter and use Ada language
2811         definition instead.
2812         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2813         parameter.
2814         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2815         parameter and use Ada language definition instead.
2816         (ada_val_print_1): Update all ada_val_print_xxx calls.
2817         Remove language parameter.
2818         (ada_val_print): Update ada_val_print_1 call.
2819
2820 2019-05-08  Tom Tromey  <tromey@adacore.com>
2821
2822         * remote.c (remote_hw_watchpoint_limit)
2823         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2824         Now static.
2825
2826 2019-05-08  Tom Tromey  <tromey@adacore.com>
2827
2828         * maint.c (_initialize_maint_cmds): Move initialization code to
2829         remote.c.
2830         (watchdog, show_watchdog): Move to remote.c.
2831         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2832         "watchdog" static.
2833         (_initialize_remote): Move initialization code from maint.c.
2834         * defs.h (watchdog): Don't declare.
2835
2836 2019-05-08  Tom Tromey  <tromey@adacore.com>
2837
2838         * tui/tui-interp.c: Include main.h.
2839         * interps.c: Include main.h.
2840         * main.h (interpreter_p): Declare.
2841         * defs.h (interpreter_p): Don't declare.
2842
2843 2019-05-08  Tom Tromey  <tromey@adacore.com>
2844
2845         * dwarf2loc.c: Include dwarf2read.h.
2846         * defs.h (read_unsigned_leb128): Don't declare.
2847         * dwarf2read.h (read_unsigned_leb128): Declare.
2848
2849 2019-05-08  Tom Tromey  <tromey@adacore.com>
2850
2851         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2852         method.
2853
2854 2019-05-08  Tom Tromey  <tromey@adacore.com>
2855
2856         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2857         when no wrap column is set.
2858
2859 2019-05-08  Tom Tromey  <tromey@adacore.com>
2860
2861         * c-lang.c (c_get_string): Handle non-C-style arrays.
2862
2863 2019-05-08  Tom Tromey  <tromey@adacore.com>
2864
2865         * typeprint.c (print_offset_data::update): Print the bit offset,
2866         not the number of bits remaining.
2867
2868 2019-05-08  Tom Tromey  <tromey@adacore.com>
2869
2870         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2871         padding at end of comment.
2872
2873 2019-05-08  Tom Tromey  <tromey@adacore.com>
2874
2875         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2876         Compare main types.
2877
2878 2019-05-06  Tom Tromey  <tom@tromey.com>
2879
2880         * common/scoped_mmap.c: Include common-defs.h.
2881         * common/scoped_mmap.h: Don't include config.h.
2882
2883 2019-05-04  Tom Tromey  <tom@tromey.com>
2884
2885         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2886         (struct aarch64_call_info): Add initializers.
2887         <si>: Now a std::vector.
2888         (pass_on_stack, aarch64_push_dummy_call): Update.
2889
2890 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2891             Tom Tromey  <tom@tromey.com>
2892
2893         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2894         (ppc_threads): Now a std::vector.  Now static.
2895         (hwdebug_find_thread_points_by_tid)
2896         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2897         Update.
2898
2899 2019-05-04  Tom Tromey  <tom@tromey.com>
2900
2901         * arc-tdep.c (arc_tdesc_init): Return bool.
2902
2903 2019-05-04  Tom Tromey  <tom@tromey.com>
2904
2905         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2906         Use gdb_assert_not_reached.
2907
2908 2019-05-04  Tom Tromey  <tom@tromey.com>
2909
2910         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2911         "false".
2912
2913 2019-05-04  Tom Tromey  <tom@tromey.com>
2914
2915         * arc-tdep.c (arc_tdesc_init): Use bool.
2916
2917 2019-05-04  Tom Tromey  <tom@tromey.com>
2918
2919         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2920
2921 2019-05-04  Tom Tromey  <tom@tromey.com>
2922
2923         * cli/cli-cmds.c (valid_command_p): Return bool.
2924
2925 2019-05-04  Tom Tromey  <tom@tromey.com>
2926
2927         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2928         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2929
2930 2019-05-04  Raul Tambre  <raul@tambre.ee>
2931
2932         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2933         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2934         operator for comparison.
2935
2936 2019-05-04  Tom Tromey  <tom@tromey.com>
2937
2938         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2939         (lookup_partial_symbol, print_partial_symbols)
2940         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2941         (psymbol_compare): Update.
2942         (add_psymbol_to_bcache): Clear the entire psymbol.
2943         (maintenance_check_psymtabs): Update.
2944         * psympriv.h (struct partial_symbol): Don't derive from
2945         general_symbol_info.
2946         <obj_section, unrelocated_address, address,
2947         set_unrelocated_address>: Update.
2948         <ginfo>: New member.
2949         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2950         (debug_names::write_psymbols): Update.
2951
2952 2019-05-04  Tom de Vries  <tdevries@suse.de>
2953
2954         * contrib/cc-with-tweaks.sh: Support -n arg.
2955
2956 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2957
2958         * corelow.c (core_target::detach): Ensure frame cache and
2959         register caches are cleared.
2960         inferior.c (exit_inferior_1): Likewise.
2961
2962 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2963             Tom Tromey  <tom@tromey.com>
2964
2965         * dictionary.c (collate_pending_symbols_by_language): Remove
2966         "struct" from foreach.
2967         * symtab.c (lookup_global_symbol_from_objfile)
2968         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2969         foreach.
2970         * ser-tcp.c (net_open): Remove "struct" from foreach.
2971         * objfiles.c (objfile_relocate, objfile_rebase)
2972         (objfile_has_symbols): Remove "struct" from foreach.
2973         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2974         from foreach.
2975         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2976         foreach.
2977         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2978         "struct" from foreach.
2979         * ada-lang.c (create_excep_cond_exprs)
2980         (ada_exception_catchpoint_cond_string): Remove "struct" from
2981         foreach.
2982
2983 2019-05-03  Tom Tromey  <tromey@adacore.com>
2984
2985         * ada-exp.y (convert_char_literal): Check suffix of each
2986         enumerator.
2987
2988 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2989
2990         PR ada/21406:
2991         * ada-exp.y (yywrap): Don't define.
2992         * ada-lex.l (%option): Add noyywrap
2993         (yywrap): Remove.
2994
2995 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2996
2997         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2998         _WIN32_WINNT to the XP level, unless already defined to a higher
2999         level.
3000
3001         * unittests/parse-connection-spec-selftests.c:
3002         * ser-tcp.c:
3003         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3004         override.
3005
3006         * symfile.c (find_separate_debug_file): Remove colon from the
3007         drive spec of DOS/Windows file names of the target, so that the
3008         file name produced from DEBUGDIR and the target's directory will
3009         be valid on DOS/Windows systems.
3010
3011 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3012
3013         * rust-lang.c (val_print_struct): Handle printing structures
3014         containing strings.
3015
3016 2019-05-02  Tom Tromey  <tromey@adacore.com>
3017
3018         * valarith.c (_initialize_valarith): Remove.
3019
3020 2019-05-01  Tom Tromey  <tromey@adacore.com>
3021
3022         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3023         bitfields.
3024
3025 2019-05-01  Tom Tromey  <tromey@adacore.com>
3026
3027         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3028         for big-endian copies.
3029
3030 2019-04-30  Ali Tamur  <tamur@google.com>
3031         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3032         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3033         (read_3_bytes): New function.
3034
3035 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3036
3037         * windows-nat.c (main_thread_id): Delete.
3038         (handle_output_debug_string): Replace main_thread_id by
3039         current_event.dwThreadId.
3040         (fake_create_process): Likewise.
3041         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3042         Do not set main_thread_id.
3043         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3044         current_event.dwThreadId.
3045         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3046
3047 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3048
3049         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3050         Use current_event.dwThreadId instead of main_thread_id.
3051
3052 2019-04-30  Tom Tromey  <tromey@adacore.com>
3053
3054         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3055         (create_excep_cond_exprs): Iterate over program spaces.
3056         (ada_exception_catchpoint_cond_string): Examine all minimal
3057         symbols for exception types.
3058
3059 2019-04-30  Tom Tromey  <tromey@adacore.com>
3060
3061         PR c++/24470:
3062         * dwarf2read.c (process_structure_scope): Handle case where type
3063         has template parameters but no symbol was created.
3064
3065 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3066             Chris January  <chris.january@arm.com>
3067
3068         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3069         qualifier.
3070         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3071
3072 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3073
3074         * f-typeprint.c (f_print_type): Update rules for printing
3075         whitespace.
3076         (f_type_print_varspec_suffix): Likewise.
3077
3078 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3079             Chris January  <chris.january@arm.com>
3080
3081         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3082         function arguments.
3083
3084 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3085
3086         * f-lang.c (build_fortran_types): Change name of void type to
3087         lower case.
3088         * f-typeprint.c (f_type_print_base): Print the name of the void
3089         type, rather than a fixed string.
3090         * f-valprint.c (f_decorations): Use lower case void string.
3091
3092 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3093             Chris January  <chris.january@arm.com>
3094
3095         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3096         types for Fortran.
3097
3098 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3099             Chris January  <chris.january@arm.com>
3100             David Lecomber  <david.lecomber@arm.com>
3101
3102         * f-exp.y (BINOP_INTRINSIC): New token.
3103         (exp): New parser rule handling BINOP_INTRINSIC.
3104         (f77_keywords): Add new builtin procedures.
3105         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3106         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3107         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3108         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3109         (print_unop_subexp_f): New function.
3110         (print_binop_subexp_f): New function.
3111         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3112         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3113         (dump_subexp_body_f): Likewise.
3114         (operator_check_f): Likewise.
3115         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3116         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3117
3118 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3119
3120         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3121         UNOP_KIND.
3122         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3123         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3124         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3125         (operator_length_f): New fuction.
3126         (print_subexp_f): New function.
3127         (op_name_f): New function.
3128         (dump_subexp_body_f): New function.
3129         (operator_check_f): New function.
3130         (exp_descriptor_f): Replace standard expression handling functions
3131         with new functions.
3132         * gdb/fortran-operator.def: New file.
3133         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3134         * gdb/std-operator.def: Remove UNOP_KIND.
3135
3136 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3137
3138         * std-operator.def: Remove unbalanced, stray double quote
3139         character.
3140
3141 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3142             Chris January  <chris.january@arm.com>
3143             Daniel Everett  <daniel.everett@arm.com>
3144             Nick Forrington  <nick.forrington@arm.com>
3145             Richard Bunt  <richard.bunt@arm.com>
3146
3147         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3148         of depth when printing anonymous structs or unions.
3149         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3150         Don't print either the top-level value, or the children if the
3151         max-depth is exceeded.
3152         (ppscm_print_children): When printing the key of a map, allow one
3153         extra level of depth.
3154         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3155         print either the top-level value, or the children if the max-depth
3156         is exceeded.
3157         (print_children): When printing the key of a map, allow one extra
3158         level of depth.
3159         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3160         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3161         (user_print_options): Initialise max_depth field.
3162         (val_print_scalar_or_string_type_p): New function.
3163         (val_print): Check to see if the max depth has been reached.
3164         (val_print_check_max_depth): Define new function.
3165         (show_print_max_depth): New function.
3166         (_initialize_valprint): Add 'print max-depth' option.
3167         * valprint.h (struct value_print_options) <max_depth>: New field.
3168         (val_print_check_max_depth): Declare new function.
3169         * NEWS: Document new feature.
3170
3171 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3172
3173         * ada-lang.c (ada_language_defn): Initialise new field.
3174         * c-lang.c (c_is_string_type_p): New function.
3175         (c_language_defn): Initialise new field.
3176         (cplus_language_defn): Initialise new field.
3177         (asm_language_defn): Initialise new field.
3178         (minimal_language_defn): Initialise new field.
3179         * c-lang.h (c_is_string_type_p): Declare new function.
3180         * d-lang.c (d_language_defn): Initialise new field.
3181         * f-lang.c (f_is_string_type_p): New function.
3182         (f_language_defn): Initialise new field.
3183         * go-lang.c (go_is_string_type_p): New function.
3184         (go_language_defn): Initialise new field.
3185         * language.c (default_is_string_type_p): New function.
3186         (unknown_language_defn): Initialise new field.
3187         (auto_language_defn): Initialise new field.
3188         * language.h (struct language_defn) <la_is_string_type_p>: New
3189         member variable.
3190         (default_is_string_type_p): Declare new function.
3191         * m2-lang.c (m2_language_defn): Initialise new field.
3192         * objc-lang.c (objc_language_defn): Initialise new field.
3193         * opencl-lang.c (opencl_language_defn): Initialise new field.
3194         * p-lang.c (pascal_is_string_type_p): New function.
3195         (pascal_language_defn): Initialise new field.
3196         * rust-lang.c (rust_is_string_type_p): New function.
3197         (rust_language_defn): Initialise new field.
3198
3199 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3200
3201         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3202         New field.
3203         * ada-lang.c (ada_language_defn): Initialise new field.
3204         * c-lang.c (c_language_defn): Likewise.
3205         (cplus_language_defn): Likewise.
3206         (asm_language_defn): Likewise.
3207         (minimal_language_defn): Likewise.
3208         * d-lang.c (d_language_defn): Likewise.
3209         * f-lang.c (f_language_defn): Likewise.
3210         * go-lang.c (go_language_defn): Likewise.
3211         * language.c (unknown_language_defn): Likewise.
3212         (auto_language_defn): Likewise.
3213         * m2-lang.c (m2_language_defn): Likewise.
3214         * objc-lang.c (objc_language_defn): Likewise.
3215         * opencl-lang.c (opencl_language_defn): Likewise.
3216         * p-lang.c (pascal_language_defn): Likewise.
3217         * rust-lang.c (rust_language_defn): Likewise.
3218
3219 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3220
3221         * ada-lang.c (ada_is_character_type): Change return type to bool.
3222         (ada_is_string_type): Likewise.
3223         * ada-lang.h (ada_is_character_type): Update declaration
3224         (ada_is_string_type): Likewise.
3225
3226 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3227
3228         Support style in 'frame|thread apply'
3229
3230         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3231         * record.c (record_start, record_stop): Update callers of
3232         execute_command_to_string with false.
3233         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3234         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3235         methods.
3236         (class string_file): New constructor with term_out parameter.
3237         Override methods term_out and can_emit_style_escape.  New member
3238         term_out.
3239         (class stdio_file): Override can_emit_style_escape.
3240         (class tee_file): Override term_out and can_emit_style_escape.
3241         * utils.h (can_emit_style_escape): Remove.
3242         * utils.c (can_emit_style_escape): Likewise.
3243         Update all callers of can_emit_style_escape (SOMESTREAM) to
3244         SOMESTREAM->can_emit_style_escape.
3245         * source-cache.c (source_cache::get_source_lines): Likewise.
3246         * stack.c (frame_apply_command_count): Call execute_command_to_string
3247         passing the term_out characteristic of the current gdb_stdout.
3248         * thread.c (thr_try_catch_cmd): Likewise.
3249         * top.c (execute_command_to_string): pass term_out parameter
3250         to construct the string_file for the command output.
3251         * ui-file.c (term_cli_styling): New function (most code moved
3252         from utils.c can_emit_style_escape).
3253         (string_file::string_file, string_file::can_emit_style_escape,
3254         stdio_file::can_emit_style_escape, tee_file::term_out,
3255         tee_file::can_emit_style_escape): New functions.
3256
3257 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3258
3259         * NEWS: Mention the new set|show may-call-functions.
3260         * infcall.c (may_call_functions_p): New variable.
3261         (show_may_call_functions_p): New function.
3262         (call_function_by_hand_dummy): Throws an error if not
3263         may-call-functions.
3264         (_initialize_infcall): Call add_setshow_boolean_cmd for
3265         may-call-functions.
3266
3267 2019-04-25  Keith Seitz  <keiths@redhat.com>
3268
3269         PR c++/24367
3270         * cp-support.c (inspect_type): Don't attempt substitutions
3271         of symbol with the same name.
3272
3273 2019-04-25  Tom Tromey  <tromey@adacore.com>
3274
3275         PR gdb/24475:
3276         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3277         static.
3278
3279 2019-04-25  Tom Tromey  <tromey@adacore.com>
3280
3281         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3282         rvalue reference.
3283         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3284         (gdb_xml_parser::parse): Use std::move.
3285         * python/python-internal.h (gdbpy_convert_exception): Take a const
3286         reference.
3287         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3288         std::move.
3289         * python/py-utils.c (gdbpy_convert_exception): Take a const
3290         reference.
3291         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3292         Use std::move.
3293         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3294         Use std::move.
3295         * mi/mi-main.c (mi_print_exception): Take a const reference.
3296         * main.c (handle_command_errors): Take a const reference.
3297         * linespec.c (parse_linespec): Use std::move.
3298         * infcall.c (run_inferior_call): Use std::move.
3299         (call_function_by_hand_dummy): Use std::move.
3300         * exec.c (try_open_exec_file): Use std::move.
3301         * exceptions.h (exception_print, exception_fprintf)
3302         (exception_print_same): Update.
3303         * exceptions.c (print_exception, exception_print)
3304         (exception_fprintf, exception_print_same): Change parameters to
3305         const reference.
3306         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3307         * common/new-op.c: Use std::move.
3308         * common/common-exceptions.h (struct gdb_exception): Add move
3309         constructor.
3310         (struct gdb_exception_error, struct gdb_exception_quit, struct
3311         gdb_quit_bad_alloc): Change constructor to move constructor.
3312         (throw_exception): Change parameter to rvalue reference.
3313         * common/common-exceptions.c (throw_exception): Take rvalue
3314         reference.
3315         * cli/cli-interp.c (safe_execute_command): Use std::move.
3316         * breakpoint.c (insert_bp_location, location_to_sals): Use
3317         std::move.
3318
3319 2019-04-25  Tom Tromey  <tromey@adacore.com>
3320
3321         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3322         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3323         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3324         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3325         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3326         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3327         guile/scm-value.c: Use unpack.
3328         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3329         gdbscm_gdb_exception.
3330         (gdbscm_throw_gdb_exception): Likewise.
3331         (struct gdbscm_gdb_exception): New.
3332         (unpack): New function.
3333         (gdbscm_wrap): Use unpack.
3334
3335 2019-04-25  Tom Tromey  <tromey@adacore.com>
3336
3337         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3338         (gdb_rl_callback_handler): Use std::move.
3339         * common/common-exceptions.h (struct gdb_exception): Add move
3340         assignment operator.
3341         (throw_exception_sjlj): Change "exception" to const reference.
3342         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3343         (throw_exception_sjlj): Change "exception" to const reference.
3344
3345 2019-04-25  Tom Tromey  <tromey@adacore.com>
3346
3347         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3348         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3349         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3350         Update.
3351         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3352         Update.
3353         * mi/mi-interp.c (mi_interp::exec): Update.
3354         * linespec.c (parse_linespec): Update.
3355         * infcall.c (run_inferior_call): Update.
3356         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3357         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3358         (gdbscm_lookup_global_symbol): Update.
3359         * guile/scm-param.c (gdbscm_parameter_value): Update.
3360         * guile/scm-frame.c (gdbscm_frame_read_register)
3361         (gdbscm_frame_read_var): Update.
3362         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3363         * exec.c (try_open_exec_file): Update.
3364         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3365         (gdb_rl_callback_handler): Update.
3366         * common/common-exceptions.h (exception_none): Don't declare.
3367         * common/common-exceptions.c (exception_none): Don't define.
3368         (struct catcher) <exception>: Update.
3369         * cli/cli-interp.c (safe_execute_command): Update.
3370         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3371
3372 2019-04-25  Ali Tamur  <tamur@google.com>
3373
3374         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3375         (read_attribute_value): Likewise.
3376         (dwarf2_read_addr_index): Update comment.
3377         (read_str_index): Add DW_FORM_strx.
3378         (dwarf2_string_attr): Likewise.
3379         (dwarf2_const_value_attr): Likewise.
3380         (dump_die_shallow): Likewise.
3381         (dwarf2_fetch_constant_bytes): Likewise.
3382         (skip_form_bytes): Likewise.
3383         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3384
3385 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3386
3387         PR corefiles/11608
3388         PR corefiles/18187
3389         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3390         OFFSET.  Verify if current mapping contains an ELF header.
3391         (linux_find_memory_regions_full): Adjust call to
3392         dump_mapping_p.
3393
3394 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3395             Kang Li <kanglictf@gmail.com>
3396
3397         PR gdb/21600
3398
3399         * dwarf2-frame.c (read_initial_length): Be consistent about using
3400         unsigned representation of length.
3401         (decode_frame_entry_1): Likewise.  Check for wraparound of
3402         end pointer as well as buffer overflow.
3403
3404 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3405
3406         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3407         "vq".
3408
3409 2019-04-24  Tom Tromey  <tromey@adacore.com>
3410
3411         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3412
3413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3414
3415         * s12z-tdep.c (s12z_unwind_pc): Delete.
3416         (s12z_unwind_sp): Delete.
3417         (s12z_gdbarch_init): Don't register deleted functions with
3418         gdbarch.
3419
3420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3421
3422         * rl78-tdep.c (rl78_unwind_sp): Delete.
3423         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3424
3425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3426
3427         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3428         (xstormy16_unwind_pc): Delete.
3429         (xstormy16_dummy_id): Delete.
3430         (xstormy16_gdbarch_init): Don't register deleted functions with
3431         gdbarch.
3432
3433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3434
3435         * vax-tdep.c (vax_unwind_pc): Delete.
3436         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3437
3438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3439
3440         * v850-tdep.c (v850_unwind_sp): Delete.
3441         (v850_unwind_pc): Delete.
3442         (v850_dummy_id): Delete.
3443         (v850_gdbarch_init): Don't register deleted functions with
3444         gdbarch.
3445
3446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3447
3448         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3449         (tilegx_unwind_pc): Delete.
3450         (tilegx_unwind_dummy_id): Delete.
3451         (tilegx_gdbarch_init): Don't register deleted functions with
3452         gdbarch.
3453
3454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3455
3456         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3457         (tic6x_dummy_id): Delete.
3458         (tic6x_gdbarch_init): Don't register deleted functions with
3459         gdbarch.
3460
3461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3462
3463         * sparc-tdep.c (sparc_unwind_pc): Delete.
3464         (sparc32_gdbarch_init): Don't register deleted function with
3465         gdbarch.
3466
3467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3468
3469         * sh-tdep.c (sh_unwind_sp): Delete.
3470         (sh_unwind_pc): Delete.
3471         (sh_dummy_id): Delete.
3472         (sh_gdbarch_init): Don't register deleted functions with
3473         gdbarch.
3474
3475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3476
3477         * score-tdep.c (score_unwind_sp): Delete.
3478         (score_unwind_pc): Delete.
3479         (score_dummy_id): Delete.
3480         (score_gdbarch_init): Don't register deleted functions with
3481         gdbarch.
3482
3483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3484
3485         * rx-tdep.c (rx_unwind_pc): Delete.
3486         (rx_unwind_sp): Delete.
3487         (rx_dummy_id): Delete.
3488         (rx_gdbarch_init): Don't register deleted functions with
3489         gdbarch.  Update comment.
3490
3491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3492
3493         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3494         (rs6000_dummy_id): Delete.
3495         (rs6000_gdbarch_init): Don't register deleted functions with
3496         gdbarch.
3497
3498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3499
3500         * or1k-tdep.c (or1k_dummy_id): Delete.
3501         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3502
3503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3504
3505         * nios2-tdep.c (nios2_dummy_id): Delete.
3506         (nios2_unwind_sp): Delete.
3507         (nios2_gdbarch_init): Don't register deleted functions with
3508         gdbarch.
3509
3510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3511
3512         * nds32-tdep.c (nds32_dummy_id): Delete.
3513         (nds32_unwind_pc): Delete.
3514         (nds32_unwind_sp): Delete.
3515         (nds32_gdbarch_init): Don't register deleted functions with
3516         gdbarch.
3517
3518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3519
3520         * msp430-tdep.c (msp430_unwind_pc): Delete.
3521         (msp430_unwind_sp): Delete.
3522         (msp430_dummy_id): Delete.
3523         (msp430_gdbarch_init): Don't register deleted functions with
3524         gdbarch.
3525
3526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3527
3528         * moxie-tdep.c (moxie_unwind_sp): Delete.
3529         (moxie_unwind_pc): Delete.
3530         (moxie_dummy_id): Delete.
3531         (moxie_gdbarch_init): Don't register deleted functions with
3532         gdbarch.
3533
3534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3535
3536         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3537         (mn10300_unwind_pc): Delete.
3538         (mn10300_unwind_sp): Delete.
3539         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3540         mn10300_unwind_sp.
3541         (mn10300_frame_unwind_init): Don't register deleted functions with
3542         gdbarch.
3543
3544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3545
3546         * mep-tdep.c (mep_unwind_pc): Delete.
3547         (mep_unwind_sp): Delete.
3548         (mep_dummy_id): Delete.
3549         (mep_gdbarch_init): Don't register deleted functions with
3550         gdbarch.
3551
3552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3553
3554         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3555         (m68hc11_unwind_sp): Delete.
3556         (m68hc11_gdbarch_init): Don't register deleted functions with
3557         gdbarch.
3558
3559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3560
3561         * m32r-tdep.c (m32r_unwind_sp): Delete.
3562         (m32r_unwind_pc): Delete.
3563         (m32r_dummy_id): Delete.
3564         (m32r_gdbarch_init): Don't register deleted functions with
3565         gdbarch.
3566
3567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3568
3569         * m32c-tdep.c (m32c_unwind_pc): Delete.
3570         (m32c_unwind_sp): Delete.
3571         (m32c_dummy_id): Delete.
3572         (m32c_gdbarch_init): Don't register deleted functions with
3573         gdbarch.
3574
3575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3576
3577         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3578         (lm32_unwind_pc): Delete.
3579         (lm32_dummy_id): Delete.
3580         (lm32_gdbarch_init): Don't register deleted functions with
3581         gdbarch.
3582
3583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3584
3585         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3586         (iq2000_unwind_pc): Delete.
3587         (iq2000_dummy_id): Delete.
3588         (iq2000_gdbarch_init): Don't register deleted functions with
3589         gdbarch.
3590
3591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3592
3593         * nds32-tdep.c (nds32_type_align): Delete.
3594         (nds32_push_dummy_call): Use type_align instead.
3595
3596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3597
3598         * arm-tdep.c (arm_type_align): Only handle vector override case.
3599         (arm_push_dummy_call): Use type_align.
3600         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3601
3602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3603
3604         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3605         case.
3606         (pass_on_stack): Use type_align.
3607         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3608         function.
3609
3610 2019-04-23  Tom Tromey  <tromey@adacore.com>
3611
3612         * dwarf2read.c (line_header::file_name_at): Remove unused
3613         overload.
3614
3615 2019-04-23  Tom de Vries  <tdevries@suse.de>
3616
3617         PR gdb/24438
3618         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3619         invocation.
3620
3621
3622 2019-03-27  Ali Tamur  <tamur@google.com>
3623
3624         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3625         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3626         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3627         (dwarf_expr_context::get_addr_index): Likewise
3628         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3629         (symbol_needs_eval_context::get_addr_index): Likewise
3630         (disassemble_dwarf_expression): Add DW_OP_addrx
3631         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3632         (read_cutu_die_from_dwo): Update comment
3633         (skip_one_die): Add DW_FORM_addrx
3634         (read_attribute_value): Likewise
3635         (var_decode_location): Add DW_OP_addrx
3636         (dwarf2_const_value_attr): Add DW_FORM_addrx
3637         (dump_die_shallow): Likewise
3638         (dwarf2_fetch_constant_bytes): Likewise
3639         (decode_locdesc): Add DW_OP_addrx
3640         (skip_form_bytes): Add DW_FORM_addrx
3641
3642 2019-04-22  Ali Tamur  <tamur@google.com>
3643
3644         * MAINTAINERS (Write After Approval): Add self.
3645
3646 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3647
3648         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3649         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3650         (open_symbol_file_object): Likewise.
3651         (svr4_default_sos): Add info parameter.
3652         (svr4_read_so_list): Likewise.
3653         (svr4_current_sos_direct): Adjust functions calls to pass down
3654         info.
3655         (svr4_current_sos_1): Add info parameter.
3656         (svr4_current_sos): Call get_svr4_info, pass info down to
3657         svr4_current_sos_1.
3658         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3659         get_svr4_info.
3660         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3661         get_svr4_info.
3662         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3663         to get_svr4_info.
3664         (probes_table_remove_objfile_probes): Likewise.
3665         (register_solib_event_probe): Add info parameter.
3666         (solist_update_incremental): Pass info parameter down to
3667         svr4_read_so_list.
3668         (disable_probes_interface): Add info parameter.
3669         (svr4_handle_solib_event): Pass current_program_space to
3670         get_svr4_info.  Adjust disable_probes_interface cleanup.
3671         (svr4_create_probe_breakpoints): Add info parameter, pass it
3672         down to register_solib_event_probe.
3673         (svr4_create_solib_event_breakpoints): Add info parameter,
3674         pass it down to svr4_create_probe_breakpoints.
3675         (enable_break): Pass info down to
3676         svr4_create_solib_event_breakpoints.
3677         (svr4_solib_create_inferior_hook): Pass current_program_space to
3678         get_svr4_info.
3679         (svr4_clear_solib): Likewise.
3680
3681 2019-04-22  Pedro Alves  <palves@redhat.com>
3682
3683         * solib-svr4.c (svr4_free_objfile_observer): New.
3684         (probe_and_action::objfile): New field.
3685         (probes_table_htab_remove_objfile_probes)
3686         (probes_table_remove_objfile_probes): New functions.
3687         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3688         in the new probe_and_action.  Don't store the probe in 'lookup'.
3689         (svr4_create_probe_breakpoints): Pass objfile to
3690         register_solib_event_probe.
3691         (_initialize_svr4_solib): Register a free_objfile observer.
3692
3693 2019-04-19  Tom Tromey  <tom@tromey.com>
3694
3695         * common/queue.h: Remove.
3696
3697 2019-04-19  Tom Tromey  <tom@tromey.com>
3698
3699         * event-loop.c: Don't include "common/queue.h".
3700
3701 2019-04-19  Tom Tromey  <tom@tromey.com>
3702
3703         * remote.c (remote_target): Use delete.
3704         * remote-notif.h: Include <list>, not "common/queue.h".
3705         (notif_client_p): Remove typedef.
3706         (remote_notif_state): Add constructor, destructor, initializer.
3707         <notif_queue>: Now a std::list.
3708         (remote_notif_state_xfree): Don't declare.
3709         * remote-notif.c (remote_notif_process, handle_notification)
3710         (remote_notif_state_allocate): Update.
3711         (~remote_notif_state): Rename from remote_notif_state_xfree.
3712
3713 2019-04-19  Tom Tromey  <tom@tromey.com>
3714
3715         * symfile.c (reread_symbols): Update.
3716         * objfiles.c (objfile_register_static_link)
3717         (objfile_lookup_static_link): Update
3718         (~objfile) Don't delete static_links.
3719         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3720
3721 2019-04-19  Tom Tromey  <tom@tromey.com>
3722
3723         * type-stack.h (struct type_stack) <insert>: Constify string.
3724         * type-stack.c (type_stack::insert): Constify string.
3725         * gdbtypes.h (lookup_template_type): Update.
3726         (address_space_name_to_int): Update.
3727         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3728         const.
3729         (lookup_template_type): Make name const.
3730         * c-exp.y: Update rules.
3731         (lex_one_token, classify_name, classify_inner_name)
3732         (c_print_token): Update.
3733         * p-exp.y: Update rules.
3734         (yylex): Update.
3735         * f-exp.y: Update rules.
3736         (yylex): Update.
3737         * d-exp.y: Update rules.
3738         (lex_one_token, classify_name, classify_inner_name): Update.
3739         * parse.c (write_dollar_variable, copy_name): Return std::string.
3740         * parser-defs.h (copy_name): Change return type.
3741         * m2-exp.y: Update rules.
3742         (yylex): Update.
3743         * go-exp.y (lex_one_token): Update.
3744         Update rules.
3745         (classify_unsafe_function, classify_packaged_name)
3746         (classify_name, yylex): Update.
3747
3748 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3749
3750         * configure.ac: add --enable-source-highlight switch.
3751         * configure: Regenerate.
3752         * top.c (print_gdb_version): plumb --enable-source-highlight
3753         status to "show configuration".
3754
3755 2019-04-19  Tom Tromey  <tromey@adacore.com>
3756
3757         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3758         Check ADA_TYPE_P.
3759         (empty_record, ada_template_to_fixed_record_type_1)
3760         (template_to_static_fixed_type)
3761         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3762         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3763         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3764         macros.
3765
3766 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3767
3768         PR symtab/24423:
3769         * source.c (print_source_lines_base): Advance "iter" when a
3770         control character is seen.
3771
3772 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3773
3774         * inferior.h (struct infcall_suspend_state_deleter):
3775         Catch exception in destructor to avoid crash.
3776
3777 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3778
3779         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3780         close to the add_com "shell".
3781
3782 2019-04-18  Tom Tromey  <tromey@adacore.com>
3783
3784         * process-stratum-target.h (class process_stratum_target)
3785         <stratum>: Add "final".
3786
3787 2019-04-17  Tom Tromey  <tromey@adacore.com>
3788
3789         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3790         against nullptr before use.
3791
3792 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3793
3794         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3795
3796 2019-04-17  Jim Wilson  <jimw@sifive.com>
3797             Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3800         code read might fail, assume 4-byte breakpoint in that case.
3801
3802 2019-04-15  Leszek Swirski  <leszeks@google.com>
3803
3804         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3805         rather than a hand-rolled POD check when checking for forced MEMORY
3806         classification.
3807
3808 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3809
3810         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3811         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3812         function.
3813         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3814         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3815         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3816         declaration.
3817
3818 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3819
3820         * aarch64-linux-nat.c
3821         (aarch64_linux_nat_target::thread_architecture): Add override.
3822         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3823         each VQ.
3824
3825 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3826
3827         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3828
3829 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3830
3831         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3832         target types of size 96-bits, add some additional comments, and
3833         check that the builtin type we found was the correct size.
3834
3835 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3836
3837         * utils.c (prompt_for_continue): Don't restore the styling at the
3838         end, as applied_style has the wrong value.  This fixes styling in
3839         long lists of file names that are interrupted by the "Continue?"
3840         prompt.
3841
3842 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3843
3844         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3845         * c-lang.c (c_language_defn): Likewise.
3846         (cplus_language_defn): Likewise.
3847         (asm_language_defn): Likewise.
3848         (minimal_language_defn): Likewise.
3849         * d-lang.c (d_language_defn): Likewise.
3850         * f-lang.c (f_language_defn): Likewise.
3851         * go-lang.c (go_language_defn): Likewise.
3852         * language.c (unknown_language_defn): Likewise.
3853         (auto_language_defn): Likewise.
3854         * language.h (struct language_defn): Remove la_magic field.
3855         (LANG_MAGIC): Delete.
3856         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3857         * objc-lang.c (objc_language_defn): Likewise.
3858         * opencl-lang.c (opencl_language_defn): Likewise.
3859         * p-lang.c (pascal_language_defn): Likewise.
3860         * rust-lang.c (rust_language_defn): Likewise.
3861
3862 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3863
3864         * riscv-tdep.c (riscv_type_align): New function.
3865         (riscv_type_alignment): Delete.
3866         (riscv_arg_location): Use 'type_align'.
3867         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3868
3869 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3870
3871         * gdbtypes.c (type_align): A struct with no non-static fields also
3872         has alignment of 1.
3873
3874 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3877         component to 0.
3878         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3879         member.
3880         (riscv_struct_info::analyse): New implementation using new
3881         analyse_inner member function.
3882         (riscv_struct_info::field_offset): New member function.
3883         (riscv_struct_info::m_offsets): New member variable.
3884         (riscv_struct_info::analyse_inner): New private member function,
3885         takes the old implementation of riscv_struct_info::analyse but
3886         extended to track field offsets.
3887         (riscv_call_arg_struct): Update the struct folding special cases
3888         to handle cases where empty C++ structs, which are non-zero
3889         length, are found.
3890         (riscv_arg_location): Initialise the length of each location, a
3891         non-zero length now indicates the location is in use.
3892         (riscv_push_dummy_call): Allow for the first location having a
3893         non-zero offset when setting up arguments.
3894         (riscv_return_value): Likewise, but for return values.
3895
3896 2019-04-11  Tom Tromey  <tromey@adacore.com>
3897
3898         * utils.c (internal_vproblem): Make "msg" const.
3899
3900 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3901
3902         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3903         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3904         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3905         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3906
3907 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3908
3909         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3910         function.
3911         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3912         of amd64_collect_native_gregset.
3913         (amd64_linux_nat_target::store_registers): Likewise.
3914
3915 2019-04-10  Tom Tromey  <tom@tromey.com>
3916
3917         * symtab.c (lookup_global_symbol_from_objfile)
3918         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3919         * objfiles.h (class separate_debug_iterator): New.
3920         (class separate_debug_range): New.
3921         (struct objfile) <separate_debug_objfiles>: New method.
3922         (objfile_separate_debug_iterate): Don't declare.
3923         * objfiles.c (separate_debug_iterator::operator++): Rename from
3924         objfile_separate_debug_iterate.
3925         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3926         iterator.
3927         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3928         iterator.
3929
3930 2019-04-10  Tom Tromey  <tom@tromey.com>
3931
3932         * symfile.c (reread_symbols): Remove old comment.
3933         * objfiles.c (free_all_objfiles): Fix a typo.
3934
3935 2019-04-10  Tom Tromey  <tom@tromey.com>
3936
3937         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3938         * minsyms.c (lookup_minimal_symbol): Use foreach.
3939         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3940         (lookup_minimal_symbol_solib_trampoline): Likewise.
3941         * symfile.c (reread_symbols): Use foreach.
3942
3943 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3944             Tom Tromey  <tromey@adacore.com>
3945
3946         PR rust/24414:
3947         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3948         (rust_lex_int_test): Change "value" to be LONGEST.
3949         (rust_lex_tests): Add test for long integer literal.
3950
3951 2019-04-09  Tom Tromey  <tromey@adacore.com>
3952
3953         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3954         to bool.
3955         (extended_remote_target::attach): Update.
3956         (remote_target::remote_notice_new_inferior): Update.
3957         (remote_target::add_current_inferior_and_thread): Update.
3958         * inferior.c (exit_inferior_1): Use "false".
3959         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3960
3961 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3962
3963         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3964         the "start" command.
3965
3966 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3967
3968         * python/py-inferior.c (infpy_thread_from_thread_handle):
3969         Adjust comments to reflect renaming of thread_from_thread_handle
3970         to thread_from_handle.  Adjust keywords.  Fix type error message.
3971         (inferior_object_methods): Add thread_from_handle.  Retain
3972         thread_from_thread_handle, but mark it as deprecated.
3973
3974 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3975
3976         * gdbthread.h (find_thread_by_handle): Revise declaration.
3977         * thread.c (find_thread_by_handle): Likewise.  Adjust
3978         implementation too.
3979         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3980         support for buffer objects as handles.
3981
3982 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3983
3984         * python/py-infthread.c (thpy_thread_handle): New function.
3985         (thread_object_methods): Register thpy_thread_handle.
3986
3987 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3988
3989         * gdbthread.h (thread_to_thread_handle): Declare.
3990         * thread.c (gdbtypes.h): Include.
3991         (thread_to_thread_handle): New function.
3992
3993         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3994         (target_thread_info_to_thread_handle): Declare.
3995         * target.c (target_thread_info_to_thread_handle): New function.
3996         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3997         * target-delegates.c: Regenerate.
3998
3999         * linux-thread-db.c (class thread_db_target): Add method
4000         thread_info_to_thread_handle.
4001         (thread_db_target::thread_info_to_thread_handle): Define.
4002         * remote.c (class remote_target): Add new method
4003         thread_info_to_thread_handle.
4004         (remote_target::thread_info_to_thread_handle): Define.
4005
4006 2019-04-08  Pedro Alves  <palves@redhat.com>
4007
4008         * common/common-exceptions.c (throw_exception): Don't create
4009         named object to throw; throw directly.
4010         (throw_it): Likewise.  Don't initialize gdb_exception::message
4011         here, with new; pass FMT and AP to the ctor instead.
4012         * common/common-exceptions.h: Include <string>.
4013         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4014         const char *, va_list)): New ctor.  Use std::make_shared.
4015         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4016         errors)): Delete.
4017         (gdb_exception_error::gdb_exception_error(enum errors, const char
4018         *, va_list)): New.
4019         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4020         Add assertion.
4021         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4022         errors)): Delete.
4023         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4024         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4025         Add assertion.
4026
4027 2019-04-08  Tom Tromey  <tom@tromey.com>
4028
4029         * valops.c (value_rtti_indirect_type): Replace throw_exception
4030         with throw.
4031         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4032         with throw.
4033         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4034         throw.
4035         * target.c (target_translate_tls_address): Replace throw_exception
4036         with throw.
4037         * stack.c (frame_apply_command_count): Replace throw_exception
4038         with throw.
4039         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4040         throw.
4041         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4042         with throw.
4043         * rs6000-tdep.c (rs6000_frame_cache)
4044         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4045         * remote.c: Replace throw_exception with throw.
4046         * record-full.c (record_full_message, record_full_wait_1)
4047         (record_full_restore): Replace throw_exception with throw.
4048         * record-btrace.c:
4049         (get_thread_current_frame_id, record_btrace_start_replaying)
4050         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4051         (cmd_record_btrace_start): Replace throw_exception with throw.
4052         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4053         throw.
4054         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4055         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4056         * linespec.c:
4057         (find_linespec_symbols): Replace throw_exception with throw.
4058         * infrun.c (displaced_step_prepare, resume): Replace
4059         throw_exception with throw.
4060         * infcmd.c (post_create_inferior): Replace throw_exception with
4061         throw.
4062         * inf-loop.c (inferior_event_handler): Replace throw_exception
4063         with throw.
4064         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4065         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4066         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4067         (get_prev_frame_always, get_frame_pc_if_available)
4068         (get_frame_address_in_block_if_available, get_frame_language):
4069         Replace throw_exception with throw.
4070         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4071         throw_exception with throw.
4072         * eval.c (fetch_subexp_value, evaluate_var_value)
4073         (evaluate_funcall, evaluate_subexp_standard): Replace
4074         throw_exception with throw.
4075         * dwarf2loc.c (call_site_find_chain)
4076         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4077         Replace throw_exception with throw.
4078         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4079         with throw.
4080         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4081         throw.
4082         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4083         * completer.c (complete_line_internal): Replace throw_exception
4084         with throw.
4085         * compile/compile-object-run.c (compile_object_run): Replace
4086         throw_exception with throw.
4087         * cli/cli-script.c (process_next_line): Replace throw_exception
4088         with throw.
4089         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4090         (btrace_enable, btrace_maint_update_pt_packets): Replace
4091         throw_exception with throw.
4092         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4093         throw_exception with throw.
4094         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4095         throw_exception with throw.
4096         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4097         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4098         * aarch64-tdep.c (aarch64_make_prologue_cache)
4099         (aarch64_make_stub_cache): Replace throw_exception with throw.
4100
4101 2019-04-08  Tom Tromey  <tom@tromey.com>
4102
4103         * common/common-exceptions.c (throw_exception): Rename from
4104         throw_exception_cxx.  Remove old copy.  Make argument const.
4105         (throw_it): Create and throw exception objects directly.
4106         * common/common-exceptions.h (throw_exception): Make argument
4107         const.
4108         (struct gdb_exception_error): Add constructor.
4109         (struct gdb_exception_quit): Add constructor.
4110
4111 2019-04-08  Tom Tromey  <tom@tromey.com>
4112
4113         * common/common-exceptions.h (exception_rethrow): Don't declare.
4114         (TRY_SJLJ): Update comment.
4115         (TRY, CATCH, END_CATCH): Remove.
4116         * common/common-exceptions.c (exception_rethrow): Remove.
4117
4118 2019-04-08  Tom Tromey  <tom@tromey.com>
4119
4120         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4121         Remove.
4122         (gdb_exception_error): Rename from
4123         gdb_exception_RETURN_MASK_ERROR.
4124         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4125         (gdb_quit_bad_alloc): Update.
4126         * aarch64-tdep.c: Update.
4127         * ada-lang.c: Update.
4128         * ada-typeprint.c: Update.
4129         * ada-valprint.c: Update.
4130         * amd64-tdep.c: Update.
4131         * arch-utils.c: Update.
4132         * break-catch-throw.c: Update.
4133         * breakpoint.c: Update.
4134         * btrace.c: Update.
4135         * c-varobj.c: Update.
4136         * cli/cli-cmds.c: Update.
4137         * cli/cli-interp.c: Update.
4138         * cli/cli-script.c: Update.
4139         * common/common-exceptions.c: Update.
4140         * common/new-op.c: Update.
4141         * common/selftest.c: Update.
4142         * compile/compile-c-symbols.c: Update.
4143         * compile/compile-cplus-symbols.c: Update.
4144         * compile/compile-object-load.c: Update.
4145         * compile/compile-object-run.c: Update.
4146         * completer.c: Update.
4147         * corelow.c: Update.
4148         * cp-abi.c: Update.
4149         * cp-support.c: Update.
4150         * cp-valprint.c: Update.
4151         * darwin-nat.c: Update.
4152         * disasm-selftests.c: Update.
4153         * dtrace-probe.c: Update.
4154         * dwarf-index-cache.c: Update.
4155         * dwarf-index-write.c: Update.
4156         * dwarf2-frame-tailcall.c: Update.
4157         * dwarf2-frame.c: Update.
4158         * dwarf2loc.c: Update.
4159         * dwarf2read.c: Update.
4160         * eval.c: Update.
4161         * event-loop.c: Update.
4162         * event-top.c: Update.
4163         * exec.c: Update.
4164         * f-valprint.c: Update.
4165         * fbsd-tdep.c: Update.
4166         * frame-unwind.c: Update.
4167         * frame.c: Update.
4168         * gdbtypes.c: Update.
4169         * gnu-v3-abi.c: Update.
4170         * guile/guile-internal.h: Update.
4171         * guile/scm-block.c: Update.
4172         * guile/scm-breakpoint.c: Update.
4173         * guile/scm-cmd.c: Update.
4174         * guile/scm-disasm.c: Update.
4175         * guile/scm-frame.c: Update.
4176         * guile/scm-lazy-string.c: Update.
4177         * guile/scm-math.c: Update.
4178         * guile/scm-param.c: Update.
4179         * guile/scm-ports.c: Update.
4180         * guile/scm-pretty-print.c: Update.
4181         * guile/scm-symbol.c: Update.
4182         * guile/scm-symtab.c: Update.
4183         * guile/scm-type.c: Update.
4184         * guile/scm-value.c: Update.
4185         * i386-linux-tdep.c: Update.
4186         * i386-tdep.c: Update.
4187         * inf-loop.c: Update.
4188         * infcall.c: Update.
4189         * infcmd.c: Update.
4190         * infrun.c: Update.
4191         * jit.c: Update.
4192         * language.c: Update.
4193         * linespec.c: Update.
4194         * linux-fork.c: Update.
4195         * linux-nat.c: Update.
4196         * linux-tdep.c: Update.
4197         * linux-thread-db.c: Update.
4198         * main.c: Update.
4199         * mi/mi-cmd-break.c: Update.
4200         * mi/mi-cmd-stack.c: Update.
4201         * mi/mi-interp.c: Update.
4202         * mi/mi-main.c: Update.
4203         * objc-lang.c: Update.
4204         * p-valprint.c: Update.
4205         * parse.c: Update.
4206         * ppc-linux-tdep.c: Update.
4207         * printcmd.c: Update.
4208         * python/py-arch.c: Update.
4209         * python/py-breakpoint.c: Update.
4210         * python/py-cmd.c: Update.
4211         * python/py-finishbreakpoint.c: Update.
4212         * python/py-frame.c: Update.
4213         * python/py-framefilter.c: Update.
4214         * python/py-gdb-readline.c: Update.
4215         * python/py-inferior.c: Update.
4216         * python/py-infthread.c: Update.
4217         * python/py-lazy-string.c: Update.
4218         * python/py-linetable.c: Update.
4219         * python/py-objfile.c: Update.
4220         * python/py-param.c: Update.
4221         * python/py-prettyprint.c: Update.
4222         * python/py-progspace.c: Update.
4223         * python/py-record-btrace.c: Update.
4224         * python/py-record.c: Update.
4225         * python/py-symbol.c: Update.
4226         * python/py-type.c: Update.
4227         * python/py-unwind.c: Update.
4228         * python/py-utils.c: Update.
4229         * python/py-value.c: Update.
4230         * python/python.c: Update.
4231         * record-btrace.c: Update.
4232         * record-full.c: Update.
4233         * remote-fileio.c: Update.
4234         * remote.c: Update.
4235         * riscv-tdep.c: Update.
4236         * rs6000-aix-tdep.c: Update.
4237         * rs6000-tdep.c: Update.
4238         * rust-exp.y: Update.
4239         * rust-lang.c: Update.
4240         * s390-tdep.c: Update.
4241         * selftest-arch.c: Update.
4242         * solib-dsbt.c: Update.
4243         * solib-frv.c: Update.
4244         * solib-spu.c: Update.
4245         * solib-svr4.c: Update.
4246         * solib.c: Update.
4247         * sparc64-linux-tdep.c: Update.
4248         * stack.c: Update.
4249         * symfile-mem.c: Update.
4250         * symmisc.c: Update.
4251         * target.c: Update.
4252         * thread.c: Update.
4253         * top.c: Update.
4254         * tracefile-tfile.c: Update.
4255         * tui/tui.c: Update.
4256         * typeprint.c: Update.
4257         * unittests/cli-utils-selftests.c: Update.
4258         * unittests/parse-connection-spec-selftests.c: Update.
4259         * valops.c: Update.
4260         * valprint.c: Update.
4261         * value.c: Update.
4262         * varobj.c: Update.
4263         * windows-nat.c: Update.
4264         * x86-linux-nat.c: Update.
4265         * xml-support.c: Update.
4266
4267 2019-04-08  Tom Tromey  <tom@tromey.com>
4268
4269         * xml-support.c: Use C++ exception handling.
4270         * x86-linux-nat.c: Use C++ exception handling.
4271         * windows-nat.c: Use C++ exception handling.
4272         * varobj.c: Use C++ exception handling.
4273         * value.c: Use C++ exception handling.
4274         * valprint.c: Use C++ exception handling.
4275         * valops.c: Use C++ exception handling.
4276         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4277         handling.
4278         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4279         * typeprint.c: Use C++ exception handling.
4280         * tui/tui.c: Use C++ exception handling.
4281         * tracefile-tfile.c: Use C++ exception handling.
4282         * top.c: Use C++ exception handling.
4283         * thread.c: Use C++ exception handling.
4284         * target.c: Use C++ exception handling.
4285         * symmisc.c: Use C++ exception handling.
4286         * symfile-mem.c: Use C++ exception handling.
4287         * stack.c: Use C++ exception handling.
4288         * sparc64-linux-tdep.c: Use C++ exception handling.
4289         * solib.c: Use C++ exception handling.
4290         * solib-svr4.c: Use C++ exception handling.
4291         * solib-spu.c: Use C++ exception handling.
4292         * solib-frv.c: Use C++ exception handling.
4293         * solib-dsbt.c: Use C++ exception handling.
4294         * selftest-arch.c: Use C++ exception handling.
4295         * s390-tdep.c: Use C++ exception handling.
4296         * rust-lang.c: Use C++ exception handling.
4297         * rust-exp.y: Use C++ exception handling.
4298         * rs6000-tdep.c: Use C++ exception handling.
4299         * rs6000-aix-tdep.c: Use C++ exception handling.
4300         * riscv-tdep.c: Use C++ exception handling.
4301         * remote.c: Use C++ exception handling.
4302         * remote-fileio.c: Use C++ exception handling.
4303         * record-full.c: Use C++ exception handling.
4304         * record-btrace.c: Use C++ exception handling.
4305         * python/python.c: Use C++ exception handling.
4306         * python/py-value.c: Use C++ exception handling.
4307         * python/py-utils.c: Use C++ exception handling.
4308         * python/py-unwind.c: Use C++ exception handling.
4309         * python/py-type.c: Use C++ exception handling.
4310         * python/py-symbol.c: Use C++ exception handling.
4311         * python/py-record.c: Use C++ exception handling.
4312         * python/py-record-btrace.c: Use C++ exception handling.
4313         * python/py-progspace.c: Use C++ exception handling.
4314         * python/py-prettyprint.c: Use C++ exception handling.
4315         * python/py-param.c: Use C++ exception handling.
4316         * python/py-objfile.c: Use C++ exception handling.
4317         * python/py-linetable.c: Use C++ exception handling.
4318         * python/py-lazy-string.c: Use C++ exception handling.
4319         * python/py-infthread.c: Use C++ exception handling.
4320         * python/py-inferior.c: Use C++ exception handling.
4321         * python/py-gdb-readline.c: Use C++ exception handling.
4322         * python/py-framefilter.c: Use C++ exception handling.
4323         * python/py-frame.c: Use C++ exception handling.
4324         * python/py-finishbreakpoint.c: Use C++ exception handling.
4325         * python/py-cmd.c: Use C++ exception handling.
4326         * python/py-breakpoint.c: Use C++ exception handling.
4327         * python/py-arch.c: Use C++ exception handling.
4328         * printcmd.c: Use C++ exception handling.
4329         * ppc-linux-tdep.c: Use C++ exception handling.
4330         * parse.c: Use C++ exception handling.
4331         * p-valprint.c: Use C++ exception handling.
4332         * objc-lang.c: Use C++ exception handling.
4333         * mi/mi-main.c: Use C++ exception handling.
4334         * mi/mi-interp.c: Use C++ exception handling.
4335         * mi/mi-cmd-stack.c: Use C++ exception handling.
4336         * mi/mi-cmd-break.c: Use C++ exception handling.
4337         * main.c: Use C++ exception handling.
4338         * linux-thread-db.c: Use C++ exception handling.
4339         * linux-tdep.c: Use C++ exception handling.
4340         * linux-nat.c: Use C++ exception handling.
4341         * linux-fork.c: Use C++ exception handling.
4342         * linespec.c: Use C++ exception handling.
4343         * language.c: Use C++ exception handling.
4344         * jit.c: Use C++ exception handling.
4345         * infrun.c: Use C++ exception handling.
4346         * infcmd.c: Use C++ exception handling.
4347         * infcall.c: Use C++ exception handling.
4348         * inf-loop.c: Use C++ exception handling.
4349         * i386-tdep.c: Use C++ exception handling.
4350         * i386-linux-tdep.c: Use C++ exception handling.
4351         * guile/scm-value.c: Use C++ exception handling.
4352         * guile/scm-type.c: Use C++ exception handling.
4353         * guile/scm-symtab.c: Use C++ exception handling.
4354         * guile/scm-symbol.c: Use C++ exception handling.
4355         * guile/scm-pretty-print.c: Use C++ exception handling.
4356         * guile/scm-ports.c: Use C++ exception handling.
4357         * guile/scm-param.c: Use C++ exception handling.
4358         * guile/scm-math.c: Use C++ exception handling.
4359         * guile/scm-lazy-string.c: Use C++ exception handling.
4360         * guile/scm-frame.c: Use C++ exception handling.
4361         * guile/scm-disasm.c: Use C++ exception handling.
4362         * guile/scm-cmd.c: Use C++ exception handling.
4363         * guile/scm-breakpoint.c: Use C++ exception handling.
4364         * guile/scm-block.c: Use C++ exception handling.
4365         * guile/guile-internal.h: Use C++ exception handling.
4366         * gnu-v3-abi.c: Use C++ exception handling.
4367         * gdbtypes.c: Use C++ exception handling.
4368         * frame.c: Use C++ exception handling.
4369         * frame-unwind.c: Use C++ exception handling.
4370         * fbsd-tdep.c: Use C++ exception handling.
4371         * f-valprint.c: Use C++ exception handling.
4372         * exec.c: Use C++ exception handling.
4373         * event-top.c: Use C++ exception handling.
4374         * event-loop.c: Use C++ exception handling.
4375         * eval.c: Use C++ exception handling.
4376         * dwarf2read.c: Use C++ exception handling.
4377         * dwarf2loc.c: Use C++ exception handling.
4378         * dwarf2-frame.c: Use C++ exception handling.
4379         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4380         * dwarf-index-write.c: Use C++ exception handling.
4381         * dwarf-index-cache.c: Use C++ exception handling.
4382         * dtrace-probe.c: Use C++ exception handling.
4383         * disasm-selftests.c: Use C++ exception handling.
4384         * darwin-nat.c: Use C++ exception handling.
4385         * cp-valprint.c: Use C++ exception handling.
4386         * cp-support.c: Use C++ exception handling.
4387         * cp-abi.c: Use C++ exception handling.
4388         * corelow.c: Use C++ exception handling.
4389         * completer.c: Use C++ exception handling.
4390         * compile/compile-object-run.c: Use C++ exception handling.
4391         * compile/compile-object-load.c: Use C++ exception handling.
4392         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4393         * compile/compile-c-symbols.c: Use C++ exception handling.
4394         * common/selftest.c: Use C++ exception handling.
4395         * common/new-op.c: Use C++ exception handling.
4396         * cli/cli-script.c: Use C++ exception handling.
4397         * cli/cli-interp.c: Use C++ exception handling.
4398         * cli/cli-cmds.c: Use C++ exception handling.
4399         * c-varobj.c: Use C++ exception handling.
4400         * btrace.c: Use C++ exception handling.
4401         * breakpoint.c: Use C++ exception handling.
4402         * break-catch-throw.c: Use C++ exception handling.
4403         * arch-utils.c: Use C++ exception handling.
4404         * amd64-tdep.c: Use C++ exception handling.
4405         * ada-valprint.c: Use C++ exception handling.
4406         * ada-typeprint.c: Use C++ exception handling.
4407         * ada-lang.c: Use C++ exception handling.
4408         * aarch64-tdep.c: Use C++ exception handling.
4409
4410 2019-04-08  Tom Tromey  <tom@tromey.com>
4411
4412         * xml-support.c (gdb_xml_parser::parse): Update.
4413         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4414         * value.c (show_convenience): Update.
4415         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4416         (test_parse_flags_qcs): Update.
4417         * thread.c (thr_try_catch_cmd): Update.
4418         * target.c (target_translate_tls_address): Update.
4419         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4420         (info_frame_command_core, frame_apply_command_count): Update.
4421         * rust-exp.y (rust_lex_exception_test): Update.
4422         * riscv-tdep.c (riscv_print_one_register_info): Update.
4423         * remote.c (remote_target::enable_btrace): Update.
4424         * record-btrace.c (record_btrace_enable_warn): Update.
4425         * python/py-utils.c (gdbpy_convert_exception): Update.
4426         * printcmd.c (do_one_display, print_variable_and_value): Update.
4427         * mi/mi-main.c (mi_print_exception): Update.
4428         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4429         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4430         * linux-nat.c (linux_nat_target::attach): Update.
4431         * linux-fork.c (class scoped_switch_fork_info): Update.
4432         * infrun.c (displaced_step_prepare): Update.
4433         * infcall.c (call_function_by_hand_dummy): Update.
4434         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4435         * gnu-v3-abi.c (print_one_vtable): Update.
4436         * frame.c (get_prev_frame_always): Update.
4437         * f-valprint.c (info_common_command_for_block): Update.
4438         * exec.c (try_open_exec_file): Update.
4439         * exceptions.c (print_exception, exception_print)
4440         (exception_fprintf, exception_print_same): Update.
4441         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4442         * dwarf-index-cache.c (index_cache::store)
4443         (index_cache::lookup_gdb_index): Update.
4444         * darwin-nat.c (maybe_cache_shell): Update.
4445         * cp-valprint.c (cp_print_value_fields): Update.
4446         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4447         (gcc_cplus_symbol_address): Update.
4448         * compile/compile-c-symbols.c (gcc_convert_symbol)
4449         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4450         * common/selftest.c: Update.
4451         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4452         a std::string.
4453         (exception_try_scope_entry, exception_try_scope_exit): Don't
4454         declare.
4455         (struct exception_try_scope): Remove.
4456         (TRY): Don't use exception_try_scope.
4457         (struct gdb_exception): Add constructor, operator=.
4458         <what>: New method.
4459         (struct gdb_exception_RETURN_MASK_ALL)
4460         (struct gdb_exception_RETURN_MASK_ERROR)
4461         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4462         (struct gdb_quit_bad_alloc): Update.
4463         * common/common-exceptions.c (exception_none): Change
4464         initializer.
4465         (struct catcher) <state, exception>: Initialize inline.
4466         <prev>: Remove member.
4467         (current_catcher): Remove.
4468         (catchers): New global.
4469         (exceptions_state_mc_init): Simplify.
4470         (catcher_pop): Remove.
4471         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4472         (try_scope_depth, exception_try_scope_entry)
4473         (exception_try_scope_exit): Remove.
4474         (throw_exception_sjlj): Update.
4475         (exception_messages, exception_messages_size): Remove.
4476         (throw_it): Simplify.
4477         (gdb_exception_sliced_copy): Remove.
4478         (throw_exception_cxx): Update.
4479         * cli/cli-script.c (script_from_file): Update.
4480         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4481         Update.
4482         * ada-valprint.c (ada_val_print): Update.
4483         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4484         (create_excep_cond_exprs): Update.
4485
4486 2019-04-08  Tom Tromey  <tom@tromey.com>
4487
4488         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4489         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4490         (TRY, CATCH, END_CATCH): Remove some definitions.
4491         * common/common-exceptions.c: Don't use GDB_XCPT.
4492         (catcher_list_size): Remove.
4493         (throw_exception, throw_it): Simplify.
4494
4495 2019-04-05  Tom Tromey  <tom@tromey.com>
4496
4497         Revert the header-sorting patch.
4498         * ft32-tdep.c: Revert.
4499         * frv-tdep.c: Revert.
4500         * frv-linux-tdep.c: Revert.
4501         * frame.c: Revert.
4502         * frame-unwind.c: Revert.
4503         * frame-base.c: Revert.
4504         * fork-child.c: Revert.
4505         * findvar.c: Revert.
4506         * findcmd.c: Revert.
4507         * filesystem.c: Revert.
4508         * filename-seen-cache.h: Revert.
4509         * filename-seen-cache.c: Revert.
4510         * fbsd-tdep.c: Revert.
4511         * fbsd-nat.h: Revert.
4512         * fbsd-nat.c: Revert.
4513         * f-valprint.c: Revert.
4514         * f-typeprint.c: Revert.
4515         * f-lang.c: Revert.
4516         * extension.h: Revert.
4517         * extension.c: Revert.
4518         * extension-priv.h: Revert.
4519         * expprint.c: Revert.
4520         * exec.h: Revert.
4521         * exec.c: Revert.
4522         * exceptions.c: Revert.
4523         * event-top.c: Revert.
4524         * event-loop.c: Revert.
4525         * eval.c: Revert.
4526         * elfread.c: Revert.
4527         * dwarf2read.h: Revert.
4528         * dwarf2read.c: Revert.
4529         * dwarf2loc.c: Revert.
4530         * dwarf2expr.h: Revert.
4531         * dwarf2expr.c: Revert.
4532         * dwarf2-frame.c: Revert.
4533         * dwarf2-frame-tailcall.c: Revert.
4534         * dwarf-index-write.h: Revert.
4535         * dwarf-index-write.c: Revert.
4536         * dwarf-index-common.c: Revert.
4537         * dwarf-index-cache.h: Revert.
4538         * dwarf-index-cache.c: Revert.
4539         * dummy-frame.c: Revert.
4540         * dtrace-probe.c: Revert.
4541         * disasm.h: Revert.
4542         * disasm.c: Revert.
4543         * disasm-selftests.c: Revert.
4544         * dictionary.c: Revert.
4545         * dicos-tdep.c: Revert.
4546         * demangle.c: Revert.
4547         * dcache.h: Revert.
4548         * dcache.c: Revert.
4549         * darwin-nat.h: Revert.
4550         * darwin-nat.c: Revert.
4551         * darwin-nat-info.c: Revert.
4552         * d-valprint.c: Revert.
4553         * d-namespace.c: Revert.
4554         * d-lang.c: Revert.
4555         * ctf.c: Revert.
4556         * csky-tdep.c: Revert.
4557         * csky-linux-tdep.c: Revert.
4558         * cris-tdep.c: Revert.
4559         * cris-linux-tdep.c: Revert.
4560         * cp-valprint.c: Revert.
4561         * cp-support.c: Revert.
4562         * cp-namespace.c: Revert.
4563         * cp-abi.c: Revert.
4564         * corelow.c: Revert.
4565         * corefile.c: Revert.
4566         * continuations.c: Revert.
4567         * completer.h: Revert.
4568         * completer.c: Revert.
4569         * complaints.c: Revert.
4570         * coffread.c: Revert.
4571         * coff-pe-read.c: Revert.
4572         * cli-out.h: Revert.
4573         * cli-out.c: Revert.
4574         * charset.c: Revert.
4575         * c-varobj.c: Revert.
4576         * c-valprint.c: Revert.
4577         * c-typeprint.c: Revert.
4578         * c-lang.c: Revert.
4579         * buildsym.c: Revert.
4580         * buildsym-legacy.c: Revert.
4581         * build-id.h: Revert.
4582         * build-id.c: Revert.
4583         * btrace.c: Revert.
4584         * bsd-uthread.c: Revert.
4585         * breakpoint.h: Revert.
4586         * breakpoint.c: Revert.
4587         * break-catch-throw.c: Revert.
4588         * break-catch-syscall.c: Revert.
4589         * break-catch-sig.c: Revert.
4590         * blockframe.c: Revert.
4591         * block.c: Revert.
4592         * bfin-tdep.c: Revert.
4593         * bfin-linux-tdep.c: Revert.
4594         * bfd-target.c: Revert.
4595         * bcache.c: Revert.
4596         * ax-general.c: Revert.
4597         * ax-gdb.h: Revert.
4598         * ax-gdb.c: Revert.
4599         * avr-tdep.c: Revert.
4600         * auxv.c: Revert.
4601         * auto-load.c: Revert.
4602         * arm-wince-tdep.c: Revert.
4603         * arm-tdep.c: Revert.
4604         * arm-symbian-tdep.c: Revert.
4605         * arm-pikeos-tdep.c: Revert.
4606         * arm-obsd-tdep.c: Revert.
4607         * arm-nbsd-tdep.c: Revert.
4608         * arm-nbsd-nat.c: Revert.
4609         * arm-linux-tdep.c: Revert.
4610         * arm-linux-nat.c: Revert.
4611         * arm-fbsd-tdep.c: Revert.
4612         * arm-fbsd-nat.c: Revert.
4613         * arm-bsd-tdep.c: Revert.
4614         * arch-utils.c: Revert.
4615         * arc-tdep.c: Revert.
4616         * arc-newlib-tdep.c: Revert.
4617         * annotate.h: Revert.
4618         * annotate.c: Revert.
4619         * amd64-windows-tdep.c: Revert.
4620         * amd64-windows-nat.c: Revert.
4621         * amd64-tdep.c: Revert.
4622         * amd64-sol2-tdep.c: Revert.
4623         * amd64-obsd-tdep.c: Revert.
4624         * amd64-obsd-nat.c: Revert.
4625         * amd64-nbsd-tdep.c: Revert.
4626         * amd64-nbsd-nat.c: Revert.
4627         * amd64-nat.c: Revert.
4628         * amd64-linux-tdep.c: Revert.
4629         * amd64-linux-nat.c: Revert.
4630         * amd64-fbsd-tdep.c: Revert.
4631         * amd64-fbsd-nat.c: Revert.
4632         * amd64-dicos-tdep.c: Revert.
4633         * amd64-darwin-tdep.c: Revert.
4634         * amd64-bsd-nat.c: Revert.
4635         * alpha-tdep.c: Revert.
4636         * alpha-obsd-tdep.c: Revert.
4637         * alpha-nbsd-tdep.c: Revert.
4638         * alpha-mdebug-tdep.c: Revert.
4639         * alpha-linux-tdep.c: Revert.
4640         * alpha-linux-nat.c: Revert.
4641         * alpha-bsd-tdep.c: Revert.
4642         * alpha-bsd-nat.c: Revert.
4643         * aix-thread.c: Revert.
4644         * agent.c: Revert.
4645         * addrmap.c: Revert.
4646         * ada-varobj.c: Revert.
4647         * ada-valprint.c: Revert.
4648         * ada-typeprint.c: Revert.
4649         * ada-tasks.c: Revert.
4650         * ada-lang.c: Revert.
4651         * aarch64-tdep.c: Revert.
4652         * aarch64-ravenscar-thread.c: Revert.
4653         * aarch64-newlib-tdep.c: Revert.
4654         * aarch64-linux-tdep.c: Revert.
4655         * aarch64-linux-nat.c: Revert.
4656         * aarch64-fbsd-tdep.c: Revert.
4657         * aarch64-fbsd-nat.c: Revert.
4658         * aarch32-linux-nat.c: Revert.
4659
4660 2019-04-05  Tom Tromey  <tom@tromey.com>
4661
4662         * ft32-tdep.c: Sort headers.
4663         * frv-tdep.c: Sort headers.
4664         * frv-linux-tdep.c: Sort headers.
4665         * frame.c: Sort headers.
4666         * frame-unwind.c: Sort headers.
4667         * frame-base.c: Sort headers.
4668         * fork-child.c: Sort headers.
4669         * findvar.c: Sort headers.
4670         * findcmd.c: Sort headers.
4671         * filesystem.c: Sort headers.
4672         * filename-seen-cache.h: Sort headers.
4673         * filename-seen-cache.c: Sort headers.
4674         * fbsd-tdep.c: Sort headers.
4675         * fbsd-nat.h: Sort headers.
4676         * fbsd-nat.c: Sort headers.
4677         * f-valprint.c: Sort headers.
4678         * f-typeprint.c: Sort headers.
4679         * f-lang.c: Sort headers.
4680         * extension.h: Sort headers.
4681         * extension.c: Sort headers.
4682         * extension-priv.h: Sort headers.
4683         * expprint.c: Sort headers.
4684         * exec.h: Sort headers.
4685         * exec.c: Sort headers.
4686         * exceptions.c: Sort headers.
4687         * event-top.c: Sort headers.
4688         * event-loop.c: Sort headers.
4689         * eval.c: Sort headers.
4690         * elfread.c: Sort headers.
4691         * dwarf2read.h: Sort headers.
4692         * dwarf2read.c: Sort headers.
4693         * dwarf2loc.c: Sort headers.
4694         * dwarf2expr.h: Sort headers.
4695         * dwarf2expr.c: Sort headers.
4696         * dwarf2-frame.c: Sort headers.
4697         * dwarf2-frame-tailcall.c: Sort headers.
4698         * dwarf-index-write.h: Sort headers.
4699         * dwarf-index-write.c: Sort headers.
4700         * dwarf-index-common.c: Sort headers.
4701         * dwarf-index-cache.h: Sort headers.
4702         * dwarf-index-cache.c: Sort headers.
4703         * dummy-frame.c: Sort headers.
4704         * dtrace-probe.c: Sort headers.
4705         * disasm.h: Sort headers.
4706         * disasm.c: Sort headers.
4707         * disasm-selftests.c: Sort headers.
4708         * dictionary.c: Sort headers.
4709         * dicos-tdep.c: Sort headers.
4710         * demangle.c: Sort headers.
4711         * dcache.h: Sort headers.
4712         * dcache.c: Sort headers.
4713         * darwin-nat.h: Sort headers.
4714         * darwin-nat.c: Sort headers.
4715         * darwin-nat-info.c: Sort headers.
4716         * d-valprint.c: Sort headers.
4717         * d-namespace.c: Sort headers.
4718         * d-lang.c: Sort headers.
4719         * ctf.c: Sort headers.
4720         * csky-tdep.c: Sort headers.
4721         * csky-linux-tdep.c: Sort headers.
4722         * cris-tdep.c: Sort headers.
4723         * cris-linux-tdep.c: Sort headers.
4724         * cp-valprint.c: Sort headers.
4725         * cp-support.c: Sort headers.
4726         * cp-namespace.c: Sort headers.
4727         * cp-abi.c: Sort headers.
4728         * corelow.c: Sort headers.
4729         * corefile.c: Sort headers.
4730         * continuations.c: Sort headers.
4731         * completer.h: Sort headers.
4732         * completer.c: Sort headers.
4733         * complaints.c: Sort headers.
4734         * coffread.c: Sort headers.
4735         * coff-pe-read.c: Sort headers.
4736         * cli-out.h: Sort headers.
4737         * cli-out.c: Sort headers.
4738         * charset.c: Sort headers.
4739         * c-varobj.c: Sort headers.
4740         * c-valprint.c: Sort headers.
4741         * c-typeprint.c: Sort headers.
4742         * c-lang.c: Sort headers.
4743         * buildsym.c: Sort headers.
4744         * buildsym-legacy.c: Sort headers.
4745         * build-id.h: Sort headers.
4746         * build-id.c: Sort headers.
4747         * btrace.c: Sort headers.
4748         * bsd-uthread.c: Sort headers.
4749         * breakpoint.h: Sort headers.
4750         * breakpoint.c: Sort headers.
4751         * break-catch-throw.c: Sort headers.
4752         * break-catch-syscall.c: Sort headers.
4753         * break-catch-sig.c: Sort headers.
4754         * blockframe.c: Sort headers.
4755         * block.c: Sort headers.
4756         * bfin-tdep.c: Sort headers.
4757         * bfin-linux-tdep.c: Sort headers.
4758         * bfd-target.c: Sort headers.
4759         * bcache.c: Sort headers.
4760         * ax-general.c: Sort headers.
4761         * ax-gdb.h: Sort headers.
4762         * ax-gdb.c: Sort headers.
4763         * avr-tdep.c: Sort headers.
4764         * auxv.c: Sort headers.
4765         * auto-load.c: Sort headers.
4766         * arm-wince-tdep.c: Sort headers.
4767         * arm-tdep.c: Sort headers.
4768         * arm-symbian-tdep.c: Sort headers.
4769         * arm-pikeos-tdep.c: Sort headers.
4770         * arm-obsd-tdep.c: Sort headers.
4771         * arm-nbsd-tdep.c: Sort headers.
4772         * arm-nbsd-nat.c: Sort headers.
4773         * arm-linux-tdep.c: Sort headers.
4774         * arm-linux-nat.c: Sort headers.
4775         * arm-fbsd-tdep.c: Sort headers.
4776         * arm-fbsd-nat.c: Sort headers.
4777         * arm-bsd-tdep.c: Sort headers.
4778         * arch-utils.c: Sort headers.
4779         * arc-tdep.c: Sort headers.
4780         * arc-newlib-tdep.c: Sort headers.
4781         * annotate.h: Sort headers.
4782         * annotate.c: Sort headers.
4783         * amd64-windows-tdep.c: Sort headers.
4784         * amd64-windows-nat.c: Sort headers.
4785         * amd64-tdep.c: Sort headers.
4786         * amd64-sol2-tdep.c: Sort headers.
4787         * amd64-obsd-tdep.c: Sort headers.
4788         * amd64-obsd-nat.c: Sort headers.
4789         * amd64-nbsd-tdep.c: Sort headers.
4790         * amd64-nbsd-nat.c: Sort headers.
4791         * amd64-nat.c: Sort headers.
4792         * amd64-linux-tdep.c: Sort headers.
4793         * amd64-linux-nat.c: Sort headers.
4794         * amd64-fbsd-tdep.c: Sort headers.
4795         * amd64-fbsd-nat.c: Sort headers.
4796         * amd64-dicos-tdep.c: Sort headers.
4797         * amd64-darwin-tdep.c: Sort headers.
4798         * amd64-bsd-nat.c: Sort headers.
4799         * alpha-tdep.c: Sort headers.
4800         * alpha-obsd-tdep.c: Sort headers.
4801         * alpha-nbsd-tdep.c: Sort headers.
4802         * alpha-mdebug-tdep.c: Sort headers.
4803         * alpha-linux-tdep.c: Sort headers.
4804         * alpha-linux-nat.c: Sort headers.
4805         * alpha-bsd-tdep.c: Sort headers.
4806         * alpha-bsd-nat.c: Sort headers.
4807         * aix-thread.c: Sort headers.
4808         * agent.c: Sort headers.
4809         * addrmap.c: Sort headers.
4810         * ada-varobj.c: Sort headers.
4811         * ada-valprint.c: Sort headers.
4812         * ada-typeprint.c: Sort headers.
4813         * ada-tasks.c: Sort headers.
4814         * ada-lang.c: Sort headers.
4815         * aarch64-tdep.c: Sort headers.
4816         * aarch64-ravenscar-thread.c: Sort headers.
4817         * aarch64-newlib-tdep.c: Sort headers.
4818         * aarch64-linux-tdep.c: Sort headers.
4819         * aarch64-linux-nat.c: Sort headers.
4820         * aarch64-fbsd-tdep.c: Sort headers.
4821         * aarch64-fbsd-nat.c: Sort headers.
4822         * aarch32-linux-nat.c: Sort headers.
4823
4824 2019-04-04  Tom Tromey  <tom@tromey.com>
4825
4826         * varobj.c (varobj_create): Update.
4827         * rust-exp.y (struct rust_parser) <update_innermost_block,
4828         lookup_symbol>: New methods.
4829         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4830         Rename.
4831         (rust_parser::rust_lookup_type)
4832         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4833         * printcmd.c (display_command, do_one_display): Update.
4834         * parser-defs.h (struct parser_state) <parser_state>: Add
4835         "tracker" parameter.
4836         (block_tracker): New member.
4837         (class innermost_block_tracker) <innermost_block_tracker>: Add
4838         "types" parameter.
4839         <reset>: Remove method.
4840         (innermost_block): Don't declare.
4841         (null_post_parser): Update.
4842         * parse.c (innermost_block): Remove global.
4843         (write_dollar_variable): Update.
4844         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4845         Remove "tracker_types" parameter.
4846         (parse_expression): Add "tracker" parameter.
4847         (parse_expression_for_completion): Update.
4848         (null_post_parser): Add "tracker" parameter.
4849         * p-exp.y: Update rules.
4850         * m2-exp.y: Update rules.
4851         * language.h (struct language_defn) <la_post_parser>: Add
4852         "tracker" parameter.
4853         * go-exp.y: Update rules.
4854         * f-exp.y: Update rules.
4855         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4856         parameter.
4857         * d-exp.y: Update rules.
4858         * c-exp.y: Update rules.
4859         * breakpoint.c (set_breakpoint_condition): Create an
4860         innermost_block_tracker.
4861         (watch_command_1): Likewise.
4862         * ada-lang.c (resolve): Add "tracker" parameter.
4863         (resolve_subexp): Likewise.
4864         * ada-exp.y (write_var_from_sym): Update.
4865
4866 2019-04-04  Tom Tromey  <tom@tromey.com>
4867
4868         * type-stack.h: New file.
4869         * type-stack.c: New file.
4870         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4871         type-stack.h.
4872         (insert_into_type_stack, insert_type, push_type, push_type_int)
4873         (insert_type_address_space, pop_type, pop_type_int)
4874         (pop_typelist, pop_type_stack, append_type_stack)
4875         (push_type_stack, get_type_stack, push_typelist)
4876         (follow_type_instance_flags, follow_types): Don't declare.
4877         * parse.c (type_stack): Remove global.
4878         (parse_exp_in_context): Update.
4879         (insert_into_type_stack, insert_type, push_type, push_type_int)
4880         (insert_type_address_space, pop_type, pop_type_int)
4881         (pop_typelist, pop_type_stack, append_type_stack)
4882         (push_type_stack, get_type_stack, push_typelist)
4883         (follow_type_instance_flags, follow_types): Remove (moved to
4884         type-stack.c).
4885         * f-exp.y (type_stack): New global.
4886         Update rules.
4887         (push_kind_type, f_parse): Update.
4888         * d-exp.y (type_stack): New global.
4889         Update rules.
4890         (d_parse): Update.
4891         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4892         Update rules.
4893         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4894         (HFILES_NO_SRCDIR): Add type-stack.h.
4895
4896 2019-04-04  Tom Tromey  <tom@tromey.com>
4897
4898         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4899         (rust_parser::convert_ast_to_expression, rust_parse)
4900         (rust_lex_test_completion, rust_lex_tests): Update.
4901         * parser-defs.h (struct expr_completion_state): New.
4902         (struct parser_state) <parser_state>: Add completion parameter.
4903         <mark_struct_expression, mark_completion_tag>: New methods.
4904         <parse_completion, m_completion_state>: New members.
4905         (prefixify_expression, null_post_parser): Update.
4906         (mark_struct_expression, mark_completion_tag): Don't declare.
4907         * parse.c (parse_completion, expout_last_struct)
4908         (expout_tag_completion_type, expout_completion_name): Remove
4909         globals.
4910         (parser_state::mark_struct_expression)
4911         (parser_state::mark_completion_tag): Now methods.
4912         (prefixify_expression): Add last_struct parameter.
4913         (prefixify_subexp): Likewise.
4914         (parse_exp_1): Update.
4915         (parse_exp_in_context): Add cstate parameter.  Update.
4916         (parse_expression_for_completion): Create an
4917         expr_completion_state.
4918         (null_post_parser): Add "completion" parameter.
4919         * p-exp.y: Update rules.
4920         (yylex): Update.
4921         * language.h (struct language_defn) <la_post_parser>: Add
4922         "completing" parameter.
4923         * go-exp.y: Update rules.
4924         (lex_one_token): Update.
4925         * expression.h (parse_completion): Don't declare.
4926         * d-exp.y: Update rules.
4927         (lex_one_token): Update rules.
4928         * c-exp.y: Update rules.
4929         (lex_one_token): Update.
4930         * ada-lang.c (resolve): Add "parse_completion" parameter.
4931         (resolve_subexp): Likewise.
4932         (ada_resolve_function): Likewise.
4933
4934 2019-04-04  Tom Tromey  <tom@tromey.com>
4935
4936         * parser-defs.h (struct parser_state) <start_arglist,
4937         end_arglist>: New methods.
4938         <arglist_len, m_funcall_chain>: New members.
4939         (arglist_len, start_arglist, end_arglist): Don't declare.
4940         * parse.c (arglist_len, funcall_chain): Remove global.
4941         (start_arglist, end_arglist): Remove functions.
4942         (parse_exp_in_context): Update.
4943         * p-exp.y: Update rules.
4944         * m2-exp.y: Update rules.
4945         * go-exp.y: Update rules.
4946         * f-exp.y: Update rules.
4947         * d-exp.y: Update rules.
4948         * c-exp.y: Update rules.
4949
4950 2019-04-04  Tom Tromey  <tom@tromey.com>
4951
4952         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4953         lex_operator, push_back>: New methods.
4954         Update all rules.
4955         (rust_parser::lex_hex, lex_escape): Rename and update.
4956         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4957         (rust_parser::lex_operator): Rename and update.
4958         (rust_parser::lex_number, rustyylex, rustyyerror)
4959         (rust_lex_test_init, rust_lex_test_sequence)
4960         (rust_lex_test_push_back, rust_lex_tests): Update.
4961         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4962         parameter.
4963         <lexptr, prev_lexptr>: New members.
4964         (lexptr, prev_lexptr): Don't declare.
4965         * parse.c (lexptr, prev_lexptr): Remove globals.
4966         (parse_exp_in_context): Update.
4967         * p-exp.y (yylex, yyerror): Update.
4968         * m2-exp.y (parse_number, yylex, yyerror): Update.
4969         * go-exp.y (lex_one_token, yyerror): Update.
4970         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4971         * d-exp.y (lex_one_token, yyerror): Update.
4972         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4973         (lex_one_token, yyerror): Update.
4974         * ada-lex.l (YY_INPUT): Update.
4975         (rewind_to_char): Update.
4976         * ada-exp.y (yyerror): Update.
4977
4978 2019-04-04  Tom Tromey  <tom@tromey.com>
4979
4980         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4981         * parser-defs.h (struct parser_state) <parser_state>: Add new
4982         parameter.
4983         <comma_terminates>: New member.
4984         (comma_terminates): Don't declare global.
4985         * parse.c (comma_terminates): Remove global.
4986         (parse_exp_in_context): Update.
4987         * p-exp.y (yylex): Update.
4988         * m2-exp.y (yylex): Update.
4989         * go-exp.y (lex_one_token): Update.
4990         * f-exp.y (yylex): Update.
4991         * d-exp.y (lex_one_token): Update.
4992         * c-exp.y (lex_one_token): Update.
4993         * ada-lex.l: Update.
4994
4995 2019-04-04  Tom Tromey  <tom@tromey.com>
4996
4997         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4998         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4999         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5000         * parser-defs.h (paren_depth): Don't declare.
5001         * parse.c (paren_depth): Remove global.
5002         (parse_exp_in_context): Update.
5003         * p-exp.y (paren_depth): New global.
5004         (pascal_parse): Initialize it.
5005         * m2-exp.y (paren_depth): New global.
5006         (m2_parse): Initialize it.
5007         * go-exp.y (paren_depth): New global.
5008         (go_parse): Initialize it.
5009         * f-exp.y (paren_depth): New global.
5010         (f_parse): Initialize it.
5011         * d-exp.y (paren_depth): New global.
5012         (d_parse): Initialize it.
5013         * c-exp.y (paren_depth): New global.
5014         (c_parse): Initialize it.
5015         * ada-lex.l (paren_depth): New global.
5016         (lexer_init): Initialize it.
5017
5018 2019-04-04  Tom Tromey  <tom@tromey.com>
5019
5020         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5021         (rust_parser::convert_ast_to_type)
5022         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5023         * parser-defs.h (struct parser_state) <parser_state>: Add
5024         parameters.  Initialize new members.
5025         <expression_context_block, expression_context_pc>: New members.
5026         * parse.c (expression_context_block, expression_context_pc):
5027         Remove globals.
5028         (parse_exp_in_context): Update.
5029         * p-exp.y: Update all rules.
5030         (yylex): Update.
5031         * m2-exp.y: Update all rules.
5032         (yylex): Update.
5033         * go-exp.y (yylex): Update.
5034         * f-exp.y (yylex): Update.
5035         * d-exp.y: Update all rules.
5036         (yylex): Update.
5037         * c-exp.y: Update all rules.
5038         (lex_one_token, classify_name, yylex, c_parse): Update.
5039         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5040
5041 2019-04-04  Tom Tromey  <tom@tromey.com>
5042
5043         * gdbarch.h, gdbarch.c: Rebuild.
5044         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5045         * stap-probe.h: 
5046         (struct stap_parse_info): Replace "parser_state" with
5047         "expr_builder".
5048         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5049         (parser_state): New class.
5050         * parse.c (expr_builder): Rename.
5051         (expr_builder::release): Rename.
5052         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5053         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5054         (write_exp_elt_longcst, write_exp_elt_floatcst)
5055         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5056         (write_exp_string_vector, write_exp_bitstring)
5057         (write_exp_msymbol, mark_struct_expression)
5058         (write_dollar_variable)
5059         (insert_type_address_space, increase_expout_size): Replace
5060         "parser_state" with "expr_builder".
5061         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5062         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5063         "parser_state" with "expr_builder".
5064
5065 2019-04-04  Tom Tromey  <tom@tromey.com>
5066
5067         * rust-exp.y: Replace "parse_language" with method call.
5068         * p-exp.y: 
5069         (yylex): Replace "parse_language" with method call.
5070         * m2-exp.y: 
5071         (yylex): Replace "parse_language" with method call.
5072         * go-exp.y (classify_name): Replace "parse_language" with method
5073         call.
5074         * f-exp.y (yylex): Replace "parse_language" with method call.
5075         * d-exp.y (lex_one_token): Replace "parse_language" with method
5076         call.
5077         * c-exp.y: 
5078         (lex_one_token, classify_name, yylex): Replace "parse_language"
5079         with method call.
5080         * ada-exp.y (find_primitive_type, type_char)
5081         (type_system_address): Replace "parse_language" with method call.
5082
5083 2019-04-04  Tom Tromey  <tom@tromey.com>
5084
5085         * rust-exp.y: Replace "parse_gdbarch" with method call.
5086         * parse.c (write_dollar_variable, insert_type_address_space):
5087         Replace "parse_gdbarch" with method call.
5088         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5089         call.
5090         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5091         call.
5092         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5093         "parse_gdbarch" with method call.
5094         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5095         with method call.
5096         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5097         "parse_gdbarch" with method call.
5098         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5099         "parse_gdbarch" with method call.
5100         * c-exp.y (parse_type, parse_number, classify_name): Replace
5101         "parse_gdbarch" with method call.
5102         * ada-lex.l: Replace "parse_gdbarch" with method call.
5103         * ada-exp.y (parse_type, find_primitive_type, type_char)
5104         (type_system_address): Replace "parse_gdbarch" with method call.
5105
5106 2019-04-04  Tom Tromey  <tom@tromey.com>
5107
5108         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5109         * stap-probe.c (stap_parse_argument): Update.
5110         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5111         initial_size parameter.
5112         * rust-exp.y (rust_lex_tests): Update.
5113         * parse.c (parser_state): Update.
5114         (parse_exp_in_context): Update.
5115         * parser-defs.h (struct parser_state) <parser_state>: Remove
5116         "initial_size" parameter.
5117
5118 2019-04-04  Tom Tromey  <tom@tromey.com>
5119
5120         * parser-defs.h (increase_expout_size): Don't declare.
5121         * parse.c (increase_expout_size): Now static.
5122
5123 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5124
5125         * gnu-nat.c (gnu_nat_target::wait): Fix
5126         target_waitstatus_to_string call.
5127
5128 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5129
5130         * eval.c (evaluate_subexp_standard): Handle internal functions
5131         during Fortran function call handling.
5132
5133 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5134
5135         * NEWS: Mention new internal functions.
5136         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5137         (read_base_type): Use dwarf2_init_complex_target_type.
5138         * value.c (creal_internal_fn): New function.
5139         (cimag_internal_fn): New function.
5140         (_initialize_values): Register new internal functions.
5141
5142 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5143
5144         * infrun.c (stop_all_threads): If debug_infrun, always
5145         trace the wait status after wait_one, using
5146         target_waitstatus_to_string and target_pid_to_str.
5147         (handle_inferior_event): Replace various trace of
5148         wait status kind by a single trace.
5149         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5150         wait status kind image by target_waitstatus_to_string.
5151         * target/waitstatus.c (target_waitstatus_to_string): Fix
5152         obsolete comment.
5153
5154 2019-04-01  Tom Tromey  <tromey@adacore.com>
5155
5156         PR symtab/23331:
5157         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5158
5159 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5160             Pedro Alves  <palves@redhat.com>
5161
5162         * top.c (quit_force): Call 'finalize_values'.
5163         * value.c (finalize_values): New function.
5164         * value.h (finalize_values): Declare.
5165
5166 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5167
5168         * NEWS: Announce $_gdb_major and $_gdb_minor.
5169
5170         * top.c (init_gdb_version_vars): New function.
5171         (gdb_init): Call init_gdb_version_vars.
5172
5173 2019-03-29  Tom Tromey  <tromey@adacore.com>
5174
5175         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5176         help text.  Remove dead code.
5177
5178 2019-03-29  Keith Seitz  <keiths@redhat.com>
5179
5180         From Siddhesh Poyarekar:
5181         * f-lang.h (f77_get_upperbound): Return LONGEST.
5182         (f77_get_lowerbound): Likewise.
5183         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5184         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5185         print them.
5186         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5187         plongest to format print it.
5188         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5189         (f77_get_upperbound): Likewise.
5190         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5191         LOWER_BOUND to LONGEST.
5192         (f77_create_arrayprint_offset_tbl): Likewise.
5193
5194 2019-03-29  Keith Seitz  <keiths@redhat.com>
5195
5196         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5197         %s/pulongest for TYPE_LENGTH instead of %d in format
5198         strings.
5199         * ada-typerint.c (ada_print_type): Likewise.
5200         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5201         * compile/compile-c-support.c (generate_register_struct): Likewise.
5202         * gdbtypes.c (recursive_dump_type): Likewise.
5203         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5204         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5205         instead of %d in format strings.
5206         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5207         to std::min to ULONGEST.
5208         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5209         instead of %d in format strings.
5210         * tracepoint.c (info_scope_command): Likewise.
5211         * typeprint.c (print_offset_data::update)
5212         (print_offset_data::finish): Likewise.
5213         * xtensa-tdep.c (xtensa_store_return_value)
5214         (xtensa_push_dummy_call): Likewise.
5215
5216 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5217
5218         * windows-nat.c (display_selector): Fixed format specifications
5219         for 64-bit Cygwin.
5220
5221 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5222
5223         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5224
5225 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5226
5227         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5228         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5229         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5230         (nios2_linux_init_abi): Install it.
5231
5232 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5233
5234         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5235
5236 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5237
5238         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5239
5240 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5241             Tom Tromey  <tromey@adacore.com>
5242
5243         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5244
5245 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5246
5247         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5248         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5249         method to compute the bounds of range types. Also print "[evaluated]"
5250         if the bounds' values come from a dynamic evaluation.
5251
5252 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5253
5254         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5255         whitespace when pretty printing is on.
5256
5257 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5258
5259         * ppc-linux-nat.c: Add include.
5260
5261 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5262
5263         * NEWS: Mention AArch64 Pointer Authentication.
5264
5265 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5266
5267         * arm-linux-nat.c: Add include.
5268
5269 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5270
5271         * source-cache.c (source_cache::get_source_lines): Re-read
5272         fullname after calling open_source_file.
5273
5274 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5275
5276         * NEWS: Mention TLS support for FreeBSD.
5277
5278 2019-03-25  Tom Tromey  <tromey@adacore.com>
5279
5280         * minsyms.c (BUNCH_SIZE): Update comment.
5281         (~minimal_symbol_reader): Remove old comment.
5282         (compact_minimal_symbols): Update comment.
5283         (minimal_symbol_reader::install): Remove old comment.  Update
5284         other comments.
5285
5286 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5287
5288         * s390-linux-nat.c: Add include.
5289
5290 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5291
5292         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5293         Call linux_get_hwcap.
5294         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5295         Likewise.
5296         (aarch64_linux_get_hwcap): Remove function.
5297         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5298         declaration.
5299         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5300         linux_get_hwcap.
5301         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5302         * linux-tdep.c (linux_get_hwcap): Add function.
5303         (linux_get_hwcap2): Likewise.
5304         * linux-tdep.h (linux_get_hwcap): Add declaration.
5305         (linux_get_hwcap2): Likewise.
5306         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5307         (ppc_linux_get_hwcap2): Likewise.
5308         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5309         linux_get_hwcap.
5310         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5311         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5312         (ppc_linux_nat_target::read_description): Likewise.
5313         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5314         * s390-linux-nat.c: Likewise.
5315         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5316
5317 2019-03-24  Tom Tromey  <tom@tromey.com>
5318
5319         * ada-lang.c (standard_lookup): Simplify initialization.
5320         (ada_lookup_symbol_nonlocal): Simplify return.
5321         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5322         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5323         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5324         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5325         initialization.
5326         * solib.c (solib_global_lookup): Simplify.
5327         * symtab.c (null_block_symbol): Remove.
5328         (symbol_cache_lookup): Simplify returns.
5329         (lookup_language_this): Simplify returns.
5330         (lookup_symbol_aux): Simplify return.
5331         (lookup_local_symbol): Simplify returns.
5332         (lookup_global_symbol_from_objfile): Simplify return.
5333         (lookup_symbol_in_objfile_symtabs)
5334         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5335         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5336         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5337         * cp-namespace.c (cp_lookup_bare_symbol)
5338         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5339         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5340         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5341         (cp_lookup_symbol_via_imports): Simplify initialization.
5342         (find_symbol_in_baseclass): Likewise.
5343         * symtab.h (null_block_symbol): Remove.
5344         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5345         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5346         (d_lookup_symbol_module): Likewise.
5347         (find_symbol_in_baseclass): Simplify initialization.
5348
5349 2019-03-24  Tom Tromey  <tom@tromey.com>
5350
5351         * expression.h: Don't include symtab.h.
5352         (struct block): Forward declare.
5353
5354 2019-03-24  Tom Tromey  <tom@tromey.com>
5355
5356         * c-exp.y (typebase): Remove casts.
5357         * gdbtypes.c (lookup_unsigned_typename, )
5358         (lookup_signed_typename): Remove cast.
5359         * eval.c (parse_to_comma_and_eval): Remove cast.
5360         * parse.c (write_dollar_variable): Remove cast.
5361         * block.h (struct block) <superblock>: Now const.
5362         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5363         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5364         (map_block): Make "block" const.
5365         * symfile.h (struct quick_symbol_functions)
5366         <map_matching_symbols>: Constify block argument to "callback".
5367         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5368         const.
5369         (find_pc_sect_compunit_symtab): Make "b" const.
5370         (find_symbol_at_address): Likewise.
5371         (search_symbols): Likewise.
5372         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5373         (dw2_debug_names_lookup_symbol): Likewise.
5374         (dw2_map_matching_symbols): Update.
5375         * p-valprint.c (pascal_val_print): Remove "block".
5376         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5377         (aux_add_nonlocal_symbols): Make "block" const.
5378         (resolve_subexp): Remove cast.
5379         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5380         const.
5381         (iterate_over_file_blocks): Likewise.
5382         * f-exp.y (%union) <bval>: Remove.
5383         * coffread.c (patch_opaque_types): Make "b" const.
5384         * spu-tdep.c (spu_catch_start): Make "block" const.
5385         * c-valprint.c (print_unpacked_pointer): Remove "block".
5386         * symmisc.c (dump_symtab_1): Make "b" const.
5387         (block_depth): Make "block" const.
5388         * d-exp.y (%union) <bval>: Remove.
5389         * cp-support.h (cp_lookup_rtti_type): Update.
5390         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5391         * psymtab.c (psym_lookup_symbol): Make "block" const.
5392         (maintenance_check_psymtabs): Make "b" const.
5393         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5394         (enumerate_locals, enumerate_args): Update.
5395         * python/py-symtab.c (stpy_global_block): Make "block" const.
5396         (stpy_static_block): Likewise.
5397         * inline-frame.c (block_starting_point_at): Make "new_block"
5398         const.
5399         * block.c (find_block_in_blockvector): Make return type const.
5400         (blockvector_for_pc_sect): Make "b" const.
5401         (find_block_in_blockvector): Make "b" const.
5402
5403 2019-03-23  Tom Tromey  <tom@tromey.com>
5404
5405         * varobj.c (varobj_create): Update.
5406         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5407         * printcmd.c (display_command, do_one_display): Don't reset
5408         innermost_block.
5409         * parser-defs.h (enum innermost_block_tracker_type): Move to
5410         expression.h.
5411         (innermost_block): Update comment.
5412         * parse.c (parse_exp_1): Add tracker_types parameter.
5413         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5414         tracker_types parameter.  Reset innermost_block.
5415         (parse_exp_in_context): Remove.
5416         (parse_expression_for_completion): Update.
5417         * objfiles.c (~objfile): Don't reset expression_context_block or
5418         innermost_block.
5419         * expression.h (enum innermost_block_tracker_type): Move from
5420         parser-defs.h.
5421         (parse_exp_1): Add tracker_types parameter.
5422         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5423         reset innermost_block.
5424
5425 2019-03-23  Tom Tromey  <tom@tromey.com>
5426
5427         * objfiles.h: Include bcache.h.
5428
5429 2019-03-23  Tom Tromey  <tom@tromey.com>
5430
5431         * linespec.c (get_current_search_block): Use
5432         scoped_restore_current_language.
5433         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5434
5435 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5436             Jiong Wang  <jiong.wang@arm.com>
5437
5438         * aarch64-linux-tdep.c
5439         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5440         section.
5441         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5442
5443 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5444             Jiong Wang  <jiong.wang@arm.com>
5445
5446         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5447         instructions.
5448         (aarch64_analyze_prologue_test): Add PACIASP test.
5449         (aarch64_prologue_prev_register): Unmask PC value.
5450
5451 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5452             Jiong Wang  <jiong.wang@arm.com>
5453
5454         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5455         (aarch64_dwarf2_prev_register): Unmask PC value.
5456         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5457         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5458         DW_CFA_AARCH64_negate_ra_state.
5459         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5460
5461 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5462             Jiong Wang  <jiong.wang@arm.com>
5463
5464         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5465         registers.
5466         (aarch64_pseudo_register_name): Likewise.
5467         (aarch64_pseudo_register_type): Likewise.
5468         (aarch64_pseudo_register_reggroup_p): Likewise.
5469         (aarch64_gdbarch_init): Add pauth registers.
5470         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5471         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5472         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5473         (struct gdbarch_tdep): Add regnum for ra_state.
5474
5475 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5476             Jiong Wang  <jiong.wang@arm.com>
5477
5478         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5479
5480 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5481             Jiong Wang  <jiong.wang@arm.com>
5482
5483         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5484         function.
5485         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5486         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5487         (aarch64_gdbarch_init): Add puth registers.
5488         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5489         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5490         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5491
5492 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5493             Jiong Wang  <jiong.wang@arm.com>
5494
5495         * aarch64-linux-nat.c
5496         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5497         * aarch64-linux-tdep.c
5498         (aarch64_linux_core_read_description): Likewise.
5499         (aarch64_linux_get_hwcap): New function.
5500         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5501         (aarch64_linux_get_hwcap): New declaration.
5502
5503 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5504             Jiong Wang  <jiong.wang@arm.com>
5505
5506         * aarch64-linux-nat.c
5507         (aarch64_linux_nat_target::read_description): Add pauth param.
5508         * aarch64-linux-tdep.c
5509         (aarch64_linux_core_read_description): Likewise.
5510         * aarch64-tdep.c (struct target_desc): Add in pauth.
5511         (aarch64_read_description): Add pauth param.
5512         (aarch64_gdbarch_init): Likewise.
5513         * aarch64-tdep.h (aarch64_read_description): Likewise.
5514         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5515         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5516         * features/Makefile: Add new files.
5517         * features/aarch64-pauth.c: New file.
5518         * features/aarch64-pauth.xml: New file.
5519
5520 2019-03-20  Tom Tromey  <tromey@adacore.com>
5521
5522         * infrun.c (handle_inferior_event): Rename from
5523         handle_inferior_event_1.  Create a scoped_value_mark.
5524         (handle_inferior_event): Remove.
5525
5526 2019-03-19  Tom Tromey  <tromey@adacore.com>
5527
5528         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5529         * infrun.h (print_stop_event): Add "displays" parameter.
5530         * infrun.c (print_stop_event): Add "displays" parameter.
5531
5532 2019-03-19  Pedro Alves  <palves@redhat.com>
5533
5534         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5535         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5536         to -1.  Fix TABs vs spaces.
5537         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5538         * tui/tui-out.h (tui_ui_out) Add intro comments.
5539         <m_line, m_start_of_line>: In-class initialize, and add describing
5540         comment.
5541
5542 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5543
5544         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5545         variable names.
5546         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5547
5548 2019-03-18  Pedro Alves  <palves@redhat.com>
5549             Eli Zaretskii <eliz@gnu.org>
5550
5551         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5552         m_line and m_start_of_line.
5553
5554 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5555
5556         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5557         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5558         it returns a newline.  This fixes a regression in TU mode, whereby
5559         the next line is output on the same screen line as the user input.
5560
5561 2019-03-18  Tom Tromey  <tromey@adacore.com>
5562
5563         * minsyms.c (minimal_symbol_reader::install): Remove call to
5564         obstack_blank.
5565
5566 2019-03-18  Pedro Alves  <palves@redhat.com>
5567
5568         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5569         New globals.
5570         (apply_style): New, factored out from ...
5571         (apply_ansi_escape): ... this.  Handle reverse video mode.
5572         (tui_set_reverse_mode): New function.
5573         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5574         * tui/tui-winsource.c (tui_show_source_line): Use
5575         tui_set_reverse_mode instead of setting A_STANDOUT.
5576         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5577         New setter methods.
5578
5579 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5580
5581         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5582         Handle tabs.
5583
5584 2019-03-18  Tom Tromey  <tromey@adacore.com>
5585
5586         * ada-lang.c (empty_array): Add "high" parameter.
5587         (ada_evaluate_subexp): Update.
5588
5589 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5590
5591         * unittests/string_view-selftests.c: Define
5592         _initialize_string_view_selftests unconditionally.
5593
5594 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5595
5596         PR gdb/24350
5597         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5598
5599 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5600
5601         PR gdb/24351
5602         * windows-nat.c (display_selector): Fix format specifiers.
5603
5604 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5605
5606         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5607         tui_refill_source_window instead of tui_refresh_win, to update the
5608         current execution line.  This fixes redisplay of the current line
5609         when stepping through the code with "next" or "step".
5610
5611 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5612
5613         * source-cache.c (source_cache::get_source_lines): Call
5614         find_source_lines to initialize s->nlines.  This fixes vertical
5615         scrolling of TUI source window when the DOWN arrow is pressed.
5616
5617 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5618
5619         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5620         linux-thread-db.c (_initialize_thread_db): Likewise.
5621
5622 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5623
5624         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5625         wclrtoeol in tui_show_source_line".  This reverts changes made in
5626         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5627
5628 2019-03-15  Tom Tromey  <tom@tromey.com>
5629
5630         * symtab.h (struct minimal_symbol): Derive from
5631         general_symbol_info.
5632         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5633         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5634         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5635         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5636         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5637         (MSYMBOL_SEARCH_NAME): Update.
5638         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5639         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5640         * minsyms.c (minimal_symbol_reader::record_full): Update.
5641
5642 2019-03-15  Tom Tromey  <tom@tromey.com>
5643
5644         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5645
5646 2019-03-15  Tom Tromey  <tom@tromey.com>
5647
5648         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5649         unique_xmalloc_ptr.
5650         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5651         Update.
5652         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5653         (build_minimal_symbol_hash_tables)
5654         (minimal_symbol_reader::install): Update.
5655
5656 2019-03-15  Tom Tromey  <tom@tromey.com>
5657
5658         * symtab.c (create_demangled_names_hash): Update.
5659         (symbol_set_names): Update.
5660         * objfiles.h (struct objfile_per_bfd_storage)
5661         <demangled_names_hash>: Now an htab_up.
5662         * objfiles.c (objfile_per_bfd_storage): Simplify.
5663
5664 2019-03-15  Tom Tromey  <tom@tromey.com>
5665
5666         * objfiles.h (struct objfile_per_bfd_storage): Declare
5667         destructor.
5668         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5669         New.
5670         (get_objfile_bfd_data): Use new.  Don't initialize
5671         language_of_main.
5672         (free_objfile_per_bfd_storage): Remove.
5673         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5674
5675 2019-03-15  Tom Tromey  <tom@tromey.com>
5676
5677         * symfile.c (reread_symbols): Update.
5678         * objfiles.c (objfile::objfile): Update.
5679         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5680         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5681         comment.
5682         (minimal_symbol_reader::install): Update.
5683         (terminate_minimal_symbol_table): Remove.
5684         * jit.c (jit_object_close_impl): Update.
5685
5686 2019-03-15  Tom Tromey  <tom@tromey.com>
5687
5688         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5689         initializations.
5690
5691 2019-03-15  Tom Tromey  <tom@tromey.com>
5692
5693         * objfiles.h (struct objfile_per_bfd_storage)
5694         <demangled_hash_languages>: Now a bitset.
5695         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5696         (lookup_minimal_symbol): Update.
5697
5698 2019-03-15  Tom Tromey  <tom@tromey.com>
5699
5700         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5701         Don't return the symbol.
5702         * coffread.c (record_minimal_symbol): Use record_full.
5703
5704 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5705
5706         The MS-Windows port of ncurses fails to switch to a color pair if
5707         one or both of the colors are the implicit default colors.  This
5708         change records the default colors when TUI is initialized, and
5709         then specifies them explicitly when a color pair uses the default
5710         colors.  This allows color styling in TUI mode on MS-Windows.
5711
5712         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5713         ncurses_norm_attr.
5714         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5715         colors in ncurses_norm_attr.
5716         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5717         "none", replace it with the default color recorded in
5718         ncurses_norm_attr.
5719
5720 2019-03-14  Tom Tromey  <tromey@adacore.com>
5721
5722         * source-cache.h (class source_cache) <get_source_lines>: Return
5723         std::string.
5724         * source-cache.c (source_cache::extract_lines): Handle case where
5725         first_pos==npos.  Return std::string.
5726         (source_cache::get_source_lines): Update.
5727
5728 2019-03-14  Tom Tromey  <tromey@adacore.com>
5729
5730         * NEWS: Add item for "style sources" commands.
5731         * source-cache.c (source_cache::get_source_lines): Check
5732         source_styling.
5733         * cli/cli-style.c (source_styling): New global.
5734         (_initialize_cli_style): Add "style sources" commands.
5735         (show_style_sources): New function.
5736         * cli/cli-style.h (source_styling): Declare.
5737
5738 2019-03-14  Pedro Alves  <palves@redhat.com>
5739             Tom Tromey  <tromey@adacore.com>
5740
5741         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5742         * tui/tui-winsource.c (tui_refill_source_window): New function,
5743         from...
5744         (tui_horizontal_source_scroll): ... here.  Move some logic.
5745         * cli/cli-style.c (set_style_enabled): Notify new observable.
5746         * tui/tui-hooks.c (tui_redisplay_source): New function.
5747         (tui_attach_detach_observers): Attach or detach
5748         tui_redisplay_source.
5749         * observable.h (source_styling_changed): New observable.
5750         * observable.c: Define source_styling_changed observable.
5751
5752 2019-03-13  Tom Tromey  <tromey@adacore.com>
5753
5754         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5755         (i386_gnu_nat_target::store_registers): Update.
5756         * target-debug.h (target_debug_print_std_string): New macro.
5757         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5758         * windows-tdep.c (display_one_tib): Update.
5759         * tui/tui-stack.c (tui_make_status_line): Update.
5760         * top.c (print_inferior_quit_action): Update.
5761         * thread.c (thr_try_catch_cmd): Update.
5762         (add_thread_with_info): Update.
5763         (thread_target_id_str): Update.
5764         (thr_try_catch_cmd): Update.
5765         (thread_command): Update.
5766         (thread_find_command): Update.
5767         * record-btrace.c (record_btrace_target::info_record)
5768         (record_btrace_resume_thread, record_btrace_target::resume)
5769         (record_btrace_cancel_resume, record_btrace_step_thread)
5770         (record_btrace_target::wait, record_btrace_target::wait)
5771         (record_btrace_target::wait, record_btrace_target::stop): Update.
5772         * progspace.c (print_program_space): Update.
5773         * process-stratum-target.c
5774         (process_stratum_target::thread_address_space): Update.
5775         * linux-fork.c (linux_fork_mourn_inferior)
5776         (detach_checkpoint_command, info_checkpoints_command)
5777         (linux_fork_context): Update.
5778         (linux_fork_detach): Update.
5779         (class scoped_switch_fork_info): Update.
5780         (delete_checkpoint_command): Update.
5781         * infrun.c (follow_fork_inferior): Update.
5782         (follow_fork_inferior): Update.
5783         (proceed_after_vfork_done): Update.
5784         (handle_vfork_child_exec_or_exit): Update.
5785         (follow_exec): Update.
5786         (displaced_step_prepare_throw): Update.
5787         (displaced_step_restore): Update.
5788         (start_step_over): Update.
5789         (resume_1): Update.
5790         (clear_proceed_status_thread): Update.
5791         (proceed): Update.
5792         (print_target_wait_results): Update.
5793         (do_target_wait): Update.
5794         (context_switch): Update.
5795         (stop_all_threads): Update.
5796         (restart_threads): Update.
5797         (finish_step_over): Update.
5798         (handle_signal_stop): Update.
5799         (switch_back_to_stepped_thread): Update.
5800         (keep_going_pass_signal): Update.
5801         (print_exited_reason): Update.
5802         (normal_stop): Update.
5803         * inferior.c (inferior_pid_to_str): Change return type.
5804         (print_selected_inferior): Update.
5805         (add_inferior): Update.
5806         (detach_inferior): Update.
5807         * dummy-frame.c (fprint_dummy_frames): Update.
5808         * dcache.c (dcache_info_1): Update.
5809         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5810         (btrace_fetch, btrace_clear): Update.
5811         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5812         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5813         type.
5814         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5815         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5816         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5817         * gdbarch.c, gdbarch.h: Rebuild.
5818         * gdbarch.sh (core_pid_to_str): Change return type.
5819         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5820         return type.
5821         (windows_nat_target::pid_to_str): Change return type.
5822         (windows_delete_thread): Update.
5823         (windows_nat_target::attach): Update.
5824         (windows_nat_target::files_info): Update.
5825         * target-delegates.c: Rebuild.
5826         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5827         return type.
5828         (sol_thread_target::pid_to_str): Change return type.
5829         * remote.c (class remote_target) <pid_to_str>: Change return
5830         type.
5831         (remote_target::pid_to_str): Change return type.
5832         (extended_remote_target::attach, remote_target::remote_stop_ns)
5833         (remote_target::remote_notif_remove_queued_reply)
5834         (remote_target::push_stop_reply, remote_target::disable_btrace):
5835         Update.
5836         (extended_remote_target::attach): Update.
5837         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5838         type.
5839         (gdbsim_target::pid_to_str): Change return type.
5840         * ravenscar-thread.c (struct ravenscar_thread_target)
5841         <pid_to_str>: Change return type.
5842         (ravenscar_thread_target::pid_to_str): Change return type.
5843         * procfs.c (class procfs_target) <pid_to_str>: Change return
5844         type.
5845         (procfs_target::pid_to_str): Change return type.
5846         (procfs_target::attach): Update.
5847         (procfs_target::detach): Update.
5848         (procfs_target::fetch_registers): Update.
5849         (procfs_target::store_registers): Update.
5850         (procfs_target::wait): Update.
5851         (procfs_target::files_info): Update.
5852         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5853         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5854         return type.
5855         (nto_procfs_target::pid_to_str): Change return type.
5856         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5857         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5858         return type.
5859         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5860         (exit_lwp): Update.
5861         (attach_proc_task_lwp_callback, get_detach_signal)
5862         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5863         (linux_nat_target::resume, wait_lwp, stop_callback)
5864         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5865         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5866         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5867         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5868         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5869         type.
5870         (inf_ptrace_target::attach): Update.
5871         (inf_ptrace_target::files_info): Update.
5872         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5873         type.
5874         (go32_nat_target::pid_to_str): Change return type.
5875         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5876         (gnu_nat_target::wait): Update.
5877         (gnu_nat_target::wait): Update.
5878         (gnu_nat_target::resume): Update.
5879         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5880         (fbsd_nat_target::wait): Update.
5881         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5882         type.
5883         (darwin_nat_target::attach): Update.
5884         * corelow.c (class core_target) <pid_to_str>: Change return type.
5885         (core_target::pid_to_str): Change return type.
5886         * target.c (normal_pid_to_str): Change return type.
5887         (default_pid_to_str): Likewise.
5888         (target_pid_to_str): Change return type.
5889         (target_translate_tls_address): Update.
5890         (target_announce_detach): Update.
5891         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5892         return type.
5893         (bsd_uthread_target::pid_to_str): Change return type.
5894         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5895         type.
5896         (bsd_kvm_target::pid_to_str): Change return type.
5897         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5898         return type.
5899         (aix_thread_target::pid_to_str): Change return type.
5900         * target.h (struct target_ops) <pid_to_str>: Change return type.
5901         (target_pid_to_str, normal_pid_to_str): Likewise.
5902         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5903         type.
5904         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5905         type.
5906         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5907         return type.
5908         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5909         type.
5910         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5911         type.
5912         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5913         return type.
5914
5915 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5916
5917         * NEWS: Mention that the new default MI version is 3.  Mention
5918         changes to the output of commands and events that deal with
5919         multi-location breakpoints.
5920         * breakpoint.c: Include "mi/mi-out.h".
5921         (print_one_breakpoint): Change output syntax if using MI version
5922         >= 3.
5923         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5924         New.
5925         (mi_multi_location_breakpoint_output_fixed): New.
5926         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5927         (mi_cmd_fix_multi_location_breakpoint_output): New.
5928         (mi_multi_location_breakpoint_output_fixed): New.
5929         * mi/mi-cmds.c (mi_cmds): Register command
5930         -fix-multi-location-breakpoint-output.
5931         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5932         interpreter "mi".
5933
5934 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5935
5936         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5937         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5938         instantiate mi_ui_out based on interpreter name.
5939         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5940         * mi/mi-main.c (mi_load_progress): Likewise.
5941
5942 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5943
5944         * NEWS: Combine separate "New targets" sections for 8.3.
5945
5946 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5947
5948         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5949         (ppcfbsd_init_abi): Install gdbarch
5950         "fetch_tls_load_module_address" and "get_thread_local_address"
5951         methods.
5952
5953 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5954
5955         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5956         (riscv_fbsd_init_abi): Install gdbarch
5957         "fetch_tls_load_module_address" and "get_thread_local_address"
5958         methods.
5959
5960 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5961
5962         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5963         (i386fbsd_init_abi): Install gdbarch
5964         "fetch_tls_load_module_address" and "get_thread_local_address"
5965         methods.
5966
5967 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5968
5969         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5970         (amd64fbsd_init_abi): Install gdbarch
5971         "fetch_tls_load_module_address" and "get_thread_local_address"
5972         methods.
5973
5974 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5975
5976         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5977         (struct fbsd_pspace_data): New type.
5978         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5979         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5980         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5981         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5982         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5983
5984 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5985
5986         * gdbtypes.c (lookup_struct_elt): New function.
5987         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5988         * gdbtypes.h (struct struct_elt): New type.
5989         (lookup_struct_elt): New prototype.
5990
5991 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5992
5993         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5994         remove disabled code block.
5995
5996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5997
5998         * gdbarch.sh (get_thread_local_address): New method.
5999         * gdbarch.h, gdbarch.c: Regenerate.
6000         * target.c (target_translate_tls_address): Use
6001         gdbarch_get_thread_local_address if present instead of
6002         target::get_thread_local_address.
6003
6004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6005
6006         * target.h (target::get_thread_local_address): Update comment.
6007
6008 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6009
6010         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6011         objfile->separate_debug_objfile_backlink if not NULL.
6012
6013 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6014
6015         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6016         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6017         (amd64bsd_store_inferior_registers): Likewise.
6018         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6019         Enable segment base registers.
6020         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6021         PT_GETFSBASE and PT_GETGSBASE.
6022         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6023         PT_SETGSBASE.
6024         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6025         segment base registers.
6026         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6027
6028 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6029
6030         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6031         Update calls to i386_target_description to add 'segments'
6032         parameter.
6033         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6034         add segment base registers.
6035         * arch/i386.c (i386_create_target_description): Add 'segments'
6036         parameter to enable segment base registers.
6037         * arch/i386.h (i386_create_target_description): Likewise.
6038         * features/i386/32bit-segments.xml: New file.
6039         * features/i386/32bit-segments.c: Generate.
6040         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6041         call to i386_target_description to add 'segments' parameter.
6042         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6043         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6044         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6045         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6046         if feature is present.
6047         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6048         Add 'segments' parameter to call to i386_target_description.
6049         (i386_target_description): Add 'segments' parameter to enable
6050         segment base registers.
6051         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6052         to call to i386_target_description.
6053         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6054         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6055         Define I386_NUM_REGS.
6056         (i386_target_description): Add 'segments' parameter to enable
6057         segment base registers.
6058
6059 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6060
6061         PR/24325
6062         * source-cache.c: #undef open and close, to avoid unresolved
6063         externals during linking.
6064
6065 2019-03-12  Tom Tromey  <tromey@adacore.com>
6066
6067         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6068         const.  Add initializers.
6069         (_initialize_remote): Don't initialize ptid globals.
6070
6071 2019-03-12  Pedro Alves  <palves@redhat.com>
6072
6073         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6074
6075 2019-03-12  Pedro Alves  <palves@redhat.com>
6076
6077         * cp-name-parser.y (main): Remove unused 'len' variable.
6078
6079 2019-03-12  Tom Tromey  <tromey@adacore.com>
6080
6081         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6082         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6083
6084 2019-03-12  Tom Tromey  <tromey@adacore.com>
6085
6086         * linux-nat.c (iterate_over_lwps): Update.
6087         (stop_callback): Remove parameter.
6088         (stop_wait_callback, detach_callback, resume_set_callback)
6089         (select_singlestep_lwp_callback, set_ignore_sigint)
6090         (status_callback, resumed_callback, resume_clear_callback)
6091         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6092         data parameter.
6093         (linux_nat_target::detach, linux_nat_target::resume)
6094         (linux_stop_and_wait_all_lwps, select_event_lwp)
6095         (linux_nat_filter_event, linux_nat_wait_1)
6096         (linux_nat_target::kill, linux_nat_target::stop)
6097         (linux_nat_target::stop): Update.
6098         (linux_nat_resume_callback): Change type.
6099         (resume_stopped_resumed_lwps, count_events_callback)
6100         (select_event_lwp_callback): Likewise.
6101         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6102         * arm-linux-nat.c (struct update_registers_data): Remove.
6103         (update_registers_callback): Change type.
6104         (arm_linux_insert_hw_breakpoint1): Update.
6105         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6106         parameter.
6107         (x86_linux_dr_set_addr): Update.
6108         (x86_linux_dr_set_control): Update.
6109         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6110         (iterate_over_lwps): Use gdb::function_view.
6111         * nat/aarch64-linux-hw-point.c (struct
6112         aarch64_dr_update_callback_param): Remove.
6113         (debug_reg_change_callback): Change type.
6114         (aarch64_notify_debug_reg_change): Update.
6115         * s390-linux-nat.c (s390_refresh_per_info): Update.
6116
6117 2019-03-11  Tom Tromey  <tromey@adacore.com>
6118
6119         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6120         redundant assignment to "this_cu".
6121
6122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6123
6124         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6125
6126 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6127
6128         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6129         from...
6130         (rank_one_type): ... this.
6131
6132 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6133
6134         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6135         from...
6136         (rank_one_type): ... this.
6137
6138 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6139
6140         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6141         from...
6142         (rank_one_type): ... this.
6143
6144 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6145
6146         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6147         from...
6148         (rank_one_type): ... this.
6149
6150 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6151
6152         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6153         from...
6154         (rank_one_type): ... this.
6155
6156 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6157
6158         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6159         from...
6160         (rank_one_type): ... this.
6161
6162 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6163
6164         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6165         from...
6166         (rank_one_type): ... this.
6167
6168 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6169
6170         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6171         from...
6172         (rank_one_type): ... this.
6173
6174 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6175
6176         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6177         from...
6178         (rank_one_type): ... this.
6179
6180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6181
6182         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6183         from...
6184         (rank_one_type): ... this.
6185
6186 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6187
6188         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6189         from...
6190         (rank_one_type): ... this.
6191
6192 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6193
6194         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6195         from...
6196         (rank_one_type): ... this.
6197
6198 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6199
6200         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6201         inferior-events' shows the example events.
6202
6203 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6204
6205         Support styling on native MS-Windows console
6206
6207         PR/24315
6208         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6209         on MS-Windows if $TERM is not defined.
6210
6211         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6212
6213         * posix-hdep.c (gdb_console_fputs):
6214         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6215         functions.
6216         * ui-file.h (gdb_console_fputs): Add prototype.
6217
6218         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6219         back to fputs only if the former returns zero.
6220
6221 2019-03-07  Tom Tromey  <tom@tromey.com>
6222
6223         * symmisc.c (print_symbol_bcache_statistics): Update.
6224         (print_objfile_statistics): Update.
6225         * symfile.c (allocate_symtab): Update.
6226         * stabsread.c: Don't include bcache.h.
6227         * psymtab.h (struct psymbol_bcache): Don't declare.
6228         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6229         (psymbol_bcache_init, psymbol_bcache_free)
6230         (psymbol_bcache_get_bcache): Don't declare.
6231         * psymtab.c (struct psymbol_bcache): Remove.
6232         (psymtab_storage::psymtab_storage): Update.
6233         (psymtab_storage::~psymtab_storage): Update.
6234         (psymbol_bcache_init, psymbol_bcache_free)
6235         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6236         (add_psymbol_to_bcache): Update.
6237         (allocate_psymtab): Update.
6238         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6239         macro_cache>: No longer pointers.
6240         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6241         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6242         * macrotab.c (macro_bcache): Update.
6243         * macroexp.c: Don't include bcache.h.
6244         * gdbtypes.c (check_types_worklist): Update.
6245         (types_deeply_equal): Remove TRY/CATCH.  Update.
6246         * elfread.c (elf_symtab_read): Update.
6247         * dwarf2read.c: Don't include bcache.h.
6248         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6249         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6250         (print_bcache_statistics, bcache_memory_used): Don't declare.
6251         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6252         methods.  Rename all data members.
6253         * bcache.c (struct bcache): Move to bcache.h.
6254         (bcache::expand_hash_table): Rename from expand_hash_table.
6255         (bcache): Remove.
6256         (bcache::insert): Rename from bcache_full.
6257         (bcache::compare): Rename from bcache_compare.
6258         (bcache_xmalloc): Remove.
6259         (bcache::~bcache): Rename from bcache_xfree.
6260         (bcache::print_statistics): Rename from print_bcache_statistics.
6261         (bcache::memory_used): Rename from bcache_memory_used.
6262
6263 2019-03-07  Pedro Alves  <palves@redhat.com>
6264
6265         * infrun.c (normal_stop): Also check for
6266         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6267
6268 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6269
6270         * f-lang.c (value_from_host_double): Moved to...
6271         * value.c (value_from_host_double): ...here.
6272         * value.h (value_from_host_double): Declare.
6273         * guile/scm-math.c (vlscm_convert_typed_number): Use
6274         value_from_host_double.
6275         (vlscm_convert_number): Likewise.
6276         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6277         * python/py-value.c (convert_value_from_python): Likewise.
6278
6279 2019-03-06  Tom Tromey  <tom@tromey.com>
6280
6281         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6282
6283 2019-03-06  Tom Tromey  <tom@tromey.com>
6284
6285         * utils.h (free_current_contents): Don't declare.
6286         * utils.c (free_current_contents): Remove.
6287
6288 2019-03-06  Tom Tromey  <tom@tromey.com>
6289
6290         * top.c (quit_force): Update.
6291         * main.c (captured_command_loop): Update.
6292         * common/new-op.c (operator new): Update.
6293         * common/common-exceptions.c (struct catcher)
6294         <save_cleanup_chain>: Remove member.
6295         (exceptions_state_mc_init): Update.
6296         (exception_try_scope_entry): Return nullptr.
6297         (exception_try_scope_exit, exception_rethrow)
6298         (throw_exception_sjlj, throw_exception_cxx): Update.
6299         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6300         (all_cleanups, do_cleanups, discard_cleanups)
6301         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6302         (restore_cleanups, restore_final_cleanups): Don't declare.
6303         (do_final_cleanups): Remove parameter.
6304         * common/cleanups.c (cleanup_chain, make_cleanup)
6305         (make_cleanup_dtor, all_cleanups, do_cleanups)
6306         (discard_my_cleanups, discard_cleanups)
6307         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6308         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6309         (null_cleanup): Remove.
6310         (do_final_cleanups): Remove parameter.
6311
6312 2019-03-06  Tom Tromey  <tom@tromey.com>
6313
6314         * remote.c (remote_target::remote_parse_stop_reply): Use
6315         unique_xmalloc_ptr.
6316
6317 2019-03-06  Tom Tromey  <tom@tromey.com>
6318
6319         * stabsread.c (struct stabs_field_info): Rename from field_info.
6320         <list, fnlist>: Add initializers.
6321         <obstack>: New member.
6322         (read_member_functions, read_struct_fields, read_baseclasses):
6323         Allocate on obstack.  Don't use cleanups.
6324         (read_one_struct_field, read_member_functions, read_struct_fields)
6325         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6326         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6327         (read_struct_type): Update.
6328
6329 2019-03-06  Tom Tromey  <tom@tromey.com>
6330
6331         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6332         * common/filestuff.h (make_cleanup_close): Don't declare.
6333         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6334         Remove.
6335
6336 2019-03-06  Tom Tromey  <tom@tromey.com>
6337
6338         * solib-aix.c: Use make_scope_exit.
6339
6340 2019-03-06  Tom Tromey  <tom@tromey.com>
6341
6342         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6343         Use make_scope_exit.
6344
6345 2019-03-06  Tom Tromey  <tom@tromey.com>
6346
6347         * solib-svr4.c (disable_probes_interface): Remove parameter.
6348         (svr4_handle_solib_event): Use make_scope_exit.
6349
6350 2019-03-06  Tom Tromey  <tom@tromey.com>
6351
6352         * remote.c (struct stop_reply_deleter): Remove.
6353         (stop_reply_up): Update.
6354         (struct stop_reply): Derive from notif_event.  Don't typedef.
6355         <regcache>: Now a std::vector.
6356         (stop_reply_xfree): Remove.
6357         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6358         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6359         (remote_target::discard_pending_stop_replies): Use delete.
6360         (remote_target::remote_parse_stop_reply): Update.
6361         (remote_target::process_stop_reply): Update.
6362         * remote-notif.h (struct notif_event): Add virtual destructor.
6363         Remove "dtr" member.
6364         (struct notif_client) <alloc_event>: Return a unique_ptr.
6365         (notif_event_xfree): Don't declare.
6366         (notif_event_up): New typedef.
6367         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6368         (notif_event_xfree, do_notif_event_xfree): Remove.
6369         (remote_notif_state_xfree): Update.
6370
6371 2019-03-06  Tom Tromey  <tom@tromey.com>
6372
6373         * infrun.c (displaced_step_clear_cleanup): Now a
6374         forward_scope_exit type.
6375         (displaced_step_prepare_throw): Update.
6376         (displaced_step_fixup): Update.
6377
6378 2019-03-06  Tom Tromey  <tom@tromey.com>
6379
6380         * inferior.h (class inferior): Update comment.
6381         * gdbthread.h (class thread_info): Update comment.
6382
6383 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6384             Tom Tromey  <tom@tromey.com>
6385
6386         * stabsread.h (struct stab_section_list): Remove.
6387         (coffstab_build_psymtabs): Update.
6388         * dbxread.c (symbuf_sections): Now a std::vector.
6389         (sect_idx): New global.
6390         (fill_symbuf): Update.
6391         (coffstab_build_psymtabs): Change type of stabsects parameter.
6392         Update.
6393         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6394         std::vector.
6395         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6396         (coff_locate_sections): Update.
6397         (coff_symfile_read): Remove cleanups.  Update.
6398         (init_stringtab): Add storage parameter.
6399         (free_stringtab, free_stringtab_cleanup): Remove.
6400         (init_lineno): Add storage parameter.
6401         (free_linetab, free_linetab_cleanup): Remove.
6402
6403 2019-03-06  Pedro Alves  <palves@redhat.com>
6404
6405         * linux-fork.c (fork_info::clobber_regs): Delete.
6406         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6407         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6408         comment.  Adjust.
6409         (scoped_switch_fork_info::scoped_switch_fork_info)
6410         (checkpoint_command, linux_fork_context): Adjust
6411         fork_save_infrun_state calls.
6412
6413 2019-03-06  Pedro Alves  <palves@redhat.com>
6414
6415         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6416         (inf_has_multiple_threads): Return 'bool' and rewrite using
6417         inferior_info::threads().
6418
6419 2019-03-06  Pedro Alves  <palves@redhat.com>
6420
6421         * linux-fork.c: Include <list>.
6422         (fork_list): Now a std::list instance.
6423         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6424         (forks_exist_p, find_last_fork): Adjust.
6425         (new_fork): Delete.
6426         (one_fork_p): New.
6427         (add_fork): Adjust.
6428         (free_fork): Delete, folded into fork_info::~fork_info().
6429         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6430         Adjust.
6431         (init_fork_list): Delete.
6432         (linux_fork_killall, linux_fork_mourn_inferior)
6433         (linux_fork_detach, info_checkpoints_command): Adjust.
6434         (_initialize_linux_fork): No longer call init_fork_list.
6435
6436 2019-03-06  Pedro Alves  <palves@redhat.com>
6437
6438         * linux-fork.c (new_fork): New, split out of ...
6439         (add_fork): ... this.  Return void.  Move "first fork" special
6440         case from here, to ...
6441         (checkpoint_command): ... here.
6442         * linux-linux.h (add_fork): Return void.
6443
6444 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6445
6446         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6447
6448 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6449             Chris January  <chris.january@arm.com>
6450             David Lecomber  <david.lecomber@arm.com>
6451
6452         * f-exp.y: New token, UNOP_INTRINSIC.
6453         (exp): New pattern using UNOP_INTRINSIC token.
6454         (f77_keywords): Add 'abs' keyword.
6455         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6456         (value_from_host_double): New function.
6457         (evaluate_subexp_f): Support UNOP_ABS.
6458
6459 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6460
6461         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6462         types.
6463
6464 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6465
6466         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6467         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6468         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6469
6470 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6471
6472         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6473
6474 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6475             Chris January  <chris.january@arm.com>
6476
6477         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6478         * f-exp.y: Define 'KIND' token.
6479         (exp): New pattern for KIND expressions.
6480         (ptype): Handle types with a kind extension.
6481         (direct_abs_decl): Extend to spot kind extensions.
6482         (f77_keywords): Add 'kind' to the list.
6483         (push_kind_type): New function.
6484         (convert_to_kind_type): New function.
6485         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6486         * parse.c (operator_length_standard): Likewise.
6487         * parser-defs.h (enum type_pieces): Add tp_kind.
6488         * std-operator.def: Add UNOP_KIND.
6489
6490 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6491
6492         * f-exp.y (f_parse): Set yydebug.
6493
6494 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6495
6496         * f-lang.c (evaluate_subexp_f): New function.
6497         (exp_descriptor_f): New global.
6498         (f_language_defn): Use exp_descriptor_f instead of
6499         exp_descriptor_standard.
6500
6501 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6502
6503         * f-exp.y (struct token): Add comments.
6504         (dot_ops): Remove uppercase versions and the end marker.
6505         (f77_keywords): Likewise.
6506         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6507         entries in the dot_ops array are case insensitive, and use
6508         strncasecmp to compare strings.  Also some whitespace cleanup in
6509         this area.  Similar for the f77_keywords array, except entries in
6510         this list might be case sensitive.
6511
6512 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6513
6514         * f-exp.y (struct f77_boolean_val): Add comments.
6515         (boolean_values): Remove uppercase versions, and end marker.
6516         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6517         and use strncasecmp to achieve case insensitivity.  Additionally,
6518         perform whitespace cleanup around this code.
6519
6520 2019-03-06  Tom Tromey  <tromey@adacore.com>
6521
6522         * remote-sim.c (gdbsim_target_open): Use result of
6523         gdb_argv::release.
6524
6525 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6526         Dirk Schubert  <dirk.schubert@arm.com>
6527         Chris January  <chris.january@arm.com>
6528
6529         * eval.c (evaluate_subexp_standard): Call Fortran argument
6530         wrapping logic.
6531         * f-lang.c (struct value): A value which can be passed into a
6532         Fortran function call.
6533         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6534         where appropriate.
6535         (struct type): Value ready for a Fortran function call.
6536         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6537         is needed.
6538         * f-lang.h (fortran_argument_convert): Declaration.
6539         (fortran_preserve_arg_pointer): Declaration.
6540         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6541
6542 2019-03-05  Tom Tromey  <tromey@adacore.com>
6543
6544         * python/py-prettyprint.c (print_string_repr): Remove #if.
6545         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6546
6547 2019-03-05  Tom Tromey  <tromey@adacore.com>
6548
6549         * target.c (the_dummy_target): Move later.  Change type to
6550         "dummy_target".
6551         (initialize_targets): Don't initialize the_dummy_target.
6552
6553 2019-03-05  Tom Tromey  <tromey@adacore.com>
6554
6555         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6556         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6557
6558 2019-03-05  Tom Tromey  <tromey@adacore.com>
6559
6560         * windows-nat.c (windows_nat_target::attach)
6561         (windows_nat_target::detach): Don't call gdb_flush.
6562         * valprint.c (generic_val_print, val_print, val_print_string):
6563         Don't call gdb_flush.
6564         * utils.c (defaulted_query): Don't call gdb_flush.
6565         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6566         * target.c (target_announce_detach): Don't call gdb_flush.
6567         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6568         * remote.c (extended_remote_target::attach): Don't call
6569         gdb_flush.
6570         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6571         * printcmd.c (do_examine): Don't call gdb_flush.
6572         (info_display_command): Don't call gdb_flush.
6573         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6574         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6575         * memattr.c (info_mem_command): Don't call gdb_flush.
6576         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6577         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6578         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6579         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6580         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6581         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6582         (gnu_nat_target::detach): Don't call gdb_flush.
6583         * f-valprint.c (f_val_print): Don't call gdb_flush.
6584         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6585         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6586         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6587         gdb_flush.
6588         * c-valprint.c (c_val_print): Don't call gdb_flush.
6589         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6590
6591 2019-03-05  Tom Tromey  <tromey@adacore.com>
6592
6593         * varobj.c (update_dynamic_varobj_children): Update.
6594         (install_default_visualizer): Use reset, not release.
6595         * value.c (set_internalvar): Update.
6596         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6597         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6598         ATTRIBUTE_UNUSED_RESULT.
6599
6600 2019-03-05  Tom Tromey  <tromey@adacore.com>
6601
6602         * remote.c (class scoped_remote_fd) <release>: Add
6603         ATTRIBUTE_UNUSED_RESULT.
6604
6605 2019-03-05  Tom Tromey  <tromey@adacore.com>
6606
6607         * macroexp.c (struct macro_buffer) <release>: Add
6608         ATTRIBUTE_UNUSED_RESULT.
6609
6610 2019-03-05  Tom Tromey  <tromey@adacore.com>
6611
6612         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6613         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6614         ATTRIBUTE_UNUSED_RESULT.
6615
6616 2019-03-05  Tom Tromey  <tromey@adacore.com>
6617
6618         * common/scoped_fd.h (class scoped_fd) <release>: Add
6619         ATTRIBUTE_UNUSED_RESULT.
6620
6621 2019-03-05  Tom Tromey  <tromey@adacore.com>
6622
6623         * parser-defs.h (struct parser_state) <release>: Add
6624         ATTRIBUTE_UNUSED_RESULT.
6625
6626 2019-03-05  Tom Tromey  <tromey@adacore.com>
6627
6628         * utils.h (class gdb_argv) <release>: Add
6629         ATTRIBUTE_UNUSED_RESULT.
6630         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6631
6632 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6633
6634         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6635         for-loop range, to avoid compiler warnings.
6636
6637         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6638         avoid compiler warnings about unused variables.
6639
6640         * NEWS: Mention end of support for native debugging on MS-Windows
6641         before XP.
6642
6643         PR gdb/24292
6644         * common/netstuff.c:
6645         * gdbserver/gdbreplay.c
6646         * gdbserver/remote-utils.c:
6647         * ser-tcp.c:
6648         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6649         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6650         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6651         'getaddrinfo' and 'freeaddrinfo' were not available before
6652         Windows XP, and mingw.org's MinGW headers by default define
6653         _WIN32_WINNT to 0x500.
6654
6655 2019-03-01  Gary Benson <gbenson@redhat.com>
6656
6657         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6658
6659 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6660             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6661
6662         PR gdb/8527
6663         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6664         set_sigint_trap, clear_sigint_trap.
6665
6666 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6667
6668         * target.c (target_detach): Clear the regcache and the
6669         frame cache.
6670
6671 2019-02-27  Pedro Alves  <palves@redhat.com>
6672
6673         * utils.c (set_screen_size): When we cap the height/width sizes,
6674         tweak the corresponding command variable to show "unlimited":
6675
6676 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6677             Pedro Alves  <palves@redhat.com>
6678
6679         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6680         before calling rl_set_screen_size.
6681
6682 2019-02-27  Tom Tromey  <tromey@adacore.com>
6683
6684         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6685         define.
6686         * python/py-value.c: Remove Python 2.4 workaround.
6687         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6688         workaround.
6689         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6690         Python 2.4 workaround.
6691         * python/python-internal.h: Remove Python 2.4 comment.
6692         (Py_ssize_t): Don't define.
6693         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6694         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6695         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6696         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6697         * python/python.c (do_start_initialization): Remove Python 2.4
6698         workaround.
6699         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6700         (print_children): Remove Python 2.4 workaround.
6701         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6702         workaround.
6703         (CHARBUFFERPROC_NAME): Remove.
6704         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6705         Python 2.4 workaround.
6706
6707 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6708
6709         * NEWS: Note minimum Python version.
6710
6711 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6712
6713         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6714         code from these functions.  Remove corresponding ifdefs.  Use
6715         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6716         Remove gotos and target of gotos.
6717         (infpy_search_memory): Likewise.
6718
6719 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6720
6721         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6722         (hppa_gdbarch_init): Don't register deleted functions with
6723         gdbarch.
6724
6725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6726
6727         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6728         (h8300_unwind_sp): Delete.
6729         (h8300_dummy_id): Delete.
6730         (h8300_gdbarch_init): Don't register deleted functions with
6731         gdbarch.
6732
6733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6734
6735         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6736         (ft32_unwind_pc): Delete.
6737         (ft32_unwind_sp): Delete.
6738         (ft32_gdbarch_init): Don't register deleted functions with
6739         gdbarch.
6740
6741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6742
6743         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6744         (frv_unwind_pc): Delete.
6745         (frv_unwind_sp): Delete.
6746         (frv_gdbarch_init): Don't register deleted functions with
6747         gdbarch.
6748
6749 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6750
6751         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6752         (riscv_unwind_pc): Delete.
6753         (riscv_unwind_sp): Delete.
6754         (riscv_gdbarch_init): Don't register deleted functions with
6755         gdbarch.
6756
6757 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6758
6759         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6760         (csky_unwind_pc): Delete.
6761         (csky_unwind_sp): Delete.
6762         (csky_gdbarch_init): Don't register deleted functions with
6763         gdbarch.
6764
6765 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6766
6767         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6768         (cris_unwind_pc): Delete.
6769         (cris_unwind_sp): Delete.
6770         (cris_gdbarch_init): Don't register deleted functions with
6771         gdbarch.
6772
6773 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6774
6775         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6776         (bfin_unwind_pc): Delete.
6777         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6778
6779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6780
6781         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6782         (arm_unwind_pc): Delete.
6783         (arm_unwind_sp): Delete.
6784         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6785
6786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6787
6788         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6789         (arc_unwind_pc): Delete.
6790         (arc_unwind_sp): Delete.
6791         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6792
6793 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6794
6795         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6796         (alpha_unwind_pc): Delete.
6797         (alpha_gdbarch_init): Don't register deleted functions with
6798         gdbarch.
6799
6800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6801
6802         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6803         (aarch64_unwind_pc): Delete.
6804         (aarch64_unwind_sp): Delete.
6805         (aarch64_gdbarch_init): Don't register deleted functions with
6806         gdbarch.
6807
6808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6809
6810         * gdbtypes.c (type_align): Don't consider static members when
6811         computing structure alignment.
6812
6813 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6814
6815         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6816         return 0 for other types.
6817         * arch-utils.c (default_type_align): Always return 0.
6818         * gdbarch.h: Regenerate.
6819         * gdbarch.sh (type_align): Extend comment.
6820         * gdbtypes.c (type_align): Add additional comments, always call
6821         gdbarch_type_align before applying the default rules.
6822         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6823         generic code will then apply a suitable default.
6824         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6825         types, return 0 for other types.
6826
6827 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6828
6829         * NEWS: Create a new section for the next release branch.
6830         Rename the section of the current branch, now that it has
6831         been cut.
6832
6833 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6834
6835         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6836         * version.in: Bump version to 8.3.50.DATE-git.
6837
6838 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6839
6840         * aix-thread.c (ptid_cmp): Remove unused variable.
6841         (get_signaled_thread): Likewise.
6842         (store_regs_user_thread): Likewise.
6843         (store_regs_kernel_thread): Likewise.
6844         (fetch_regs_kernel_thread): Remove shadowed variable.
6845
6846 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6847
6848         * features/riscv/32bit-cpu.xml: Add register numbers.
6849         * features/riscv/32bit-fpu.c: Regenerate.
6850         * features/riscv/32bit-fpu.xml: Add register numbers.
6851         * features/riscv/64bit-cpu.xml: Add register numbers.
6852         * features/riscv/64bit-fpu.c: Regenerate.
6853         * features/riscv/64bit-fpu.xml: Add register numbers.
6854
6855 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6856
6857         * NEWS: Mention two argument form of gdb.Value constructor.
6858         * python/py-value.c (convert_buffer_and_type_to_value): New
6859         function.
6860         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6861         Add support for handling an optional second argument.  Call
6862         convert_buffer_and_type_to_value as appropriate.
6863         * python/python-internal.h (Py_buffer_deleter): New struct.
6864         (Py_buffer_up): New typedef.
6865
6866 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6867
6868         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6869         instead of releasing ownership.
6870
6871 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6872
6873         * dwarf2read.c (open_and_init_dwp_file): Call
6874         elf_numsections instead of bfd_count_sections to initialize
6875         dwp_file->num_sections.
6876
6877 2019-02-25  Tom Tromey  <tromey@adacore.com>
6878
6879         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6880
6881 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6882
6883         * gcore.in: Add '--readnever' option when invoking GDB.
6884
6885 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6886
6887         * MAINTAINERS: Update my email address.
6888
6889 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6890
6891         * build-id.c (build_id_to_debug_bfd_1): New function.
6892         (build_id_to_debug_bfd): Look for separate debug file in
6893         sysroot.
6894
6895 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6896
6897         * gdbarch.sh: Update the copyright year range that is placed into
6898         generated files.
6899
6900 2019-02-22  Keith Seitz  <keiths@redhat.com>
6901
6902         PR symtab/23853
6903         * linespec.c (create_sals_line_offset): Search for the default
6904         symtab's filename instead of its fullname.
6905
6906 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6907
6908         * NEWS: Update style defaults.
6909
6910 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6911
6912         * main.c (captured_main_1): Disable styling in batch mode.
6913
6914 2019-02-20  Tom Tromey  <tom@tromey.com>
6915
6916         * symtab.c (symtab_symbol_info): Fix typos.
6917
6918 2019-02-20  Tom Tromey  <tromey@adacore.com>
6919
6920         * findcmd.c (_initialize_mem_search): Use upper case for
6921         metasyntactic variables.
6922
6923 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6924
6925         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6926         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6927
6928 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6929
6930         * top.h (source_file_name): Change to std::string.
6931         * top.c (source_file_name): Likewise.
6932         (command_line_input): Adjust.
6933         * cli/cli-script.c (script_from_file): Adjust.
6934
6935 2019-02-19  Tom Tromey  <tromey@adacore.com>
6936
6937         * ravenscar-thread.c
6938         (ravenscar_thread_target::update_thread_list): Don't call
6939         ada_build_task_list.
6940         * ada-lang.h (ada_build_task_list): Don't declare.
6941         * ada-tasks.c (struct ada_tasks_inferior_data)
6942         <task_list_valid_p>: Now bool.
6943         (read_known_tasks, ada_task_list_changed)
6944         (ada_tasks_invalidate_inferior_data): Update.
6945         (read_known_tasks_array): Return bool.
6946         (read_known_tasks_list): Likewise.
6947         (read_known_tasks): Return void.
6948         (ada_build_task_list): Now static.
6949
6950 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6951
6952         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6953         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6954
6955 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6956
6957         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6958         variant for ada_tasks_pspace_data_handle and
6959         ada_tasks_inferior_data_handle.
6960         (ada_tasks_pspace_data_cleanup): New function.
6961         (ada_tasks_inferior_data_cleanup): New function.
6962
6963 2019-02-17  Tom Tromey  <tom@tromey.com>
6964
6965         * macrotab.h (macro_source_fullname): Return a std::string.
6966         * macrotab.c (macro_include, check_for_redefinition)
6967         (macro_undef, macro_lookup_definition, foreach_macro)
6968         (foreach_macro_in_scope): Update.
6969         (macro_source_fullname): Return a std::string.
6970         * macrocmd.c (show_pp_source_pos): Update.
6971
6972 2019-02-17  Tom Tromey  <tom@tromey.com>
6973
6974         * macrocmd.c (show_pp_source_pos): Style the file names.
6975
6976 2019-02-17  Tom Tromey  <tom@tromey.com>
6977
6978         PR tui/24197:
6979         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6980
6981 2019-02-17  Tom Tromey  <tom@tromey.com>
6982
6983         * ada-lang.c (user_select_syms): Use filtered printing.
6984         * utils.c (wrap_style): New global.
6985         (desired_style): Remove.
6986         (emit_style_escape): Add stream parameter.
6987         (set_output_style, reset_terminal_style, prompt_for_continue):
6988         Update.
6989         (flush_wrap_buffer): Only flush gdb_stdout.
6990         (wrap_here): Set wrap_style.
6991         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6992         treat escape sequences as a character.  Change when wrap buffer is
6993         flushed.
6994         (fputs_styled): Do not set the output style when the default is
6995         requested.
6996         * ui-style.h (struct ui_file_style) <is_default>: New method.
6997         * source.c (print_source_lines_base): Emit escape sequences in one
6998         piece.
6999
7000 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7001
7002         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7003         integers and enumeration types.
7004
7005 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7006
7007         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7008         instead of lookup_symbol_in_language
7009         (do_exact_match): New function.
7010         (ada_get_symbol_name_matcher): Return do_exact_match when
7011         doing a verbatim match.
7012
7013 2019-02-15  Tom Tromey  <tromey@adacore.com>
7014
7015         * ravenscar-thread.c (ravenscar_thread_target::resume)
7016         (ravenscar_thread_target::wait): Special case wildcard requests.
7017
7018 2019-02-15  Tom Tromey  <tromey@adacore.com>
7019
7020         * ravenscar-thread.c (base_ptid): Remove.
7021         (struct ravenscar_thread_target) <close>: New method.
7022         <m_base_ptid>: New member.
7023         <update_inferior_ptid, active_task, task_is_currently_active,
7024         runtime_initialized>: Declare methods.
7025         <ravenscar_thread_target>: Add constructor.
7026         (ravenscar_thread_target::task_is_currently_active)
7027         (ravenscar_thread_target::update_inferior_ptid)
7028         (ravenscar_runtime_initialized): Rename.  Now methods.
7029         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7030         (ravenscar_thread_target::update_thread_list): Update.
7031         (ravenscar_thread_target::active_task): Now method.
7032         (ravenscar_thread_target::store_registers)
7033         (ravenscar_thread_target::prepare_to_store)
7034         (ravenscar_thread_target::prepare_to_store)
7035         (ravenscar_thread_target::mourn_inferior): Update.
7036         (ravenscar_inferior_created): Use "new" to create target.
7037         (ravenscar_thread_target::get_ada_task_ptid): Update.
7038         (_initialize_ravenscar): Don't initialize base_ptid.
7039         (ravenscar_ops): Remove global.
7040
7041 2019-02-15  Tom Tromey  <tromey@adacore.com>
7042
7043         * target.h (push_target): Declare new overload.
7044         * target.c (push_target): New overload, taking an rvalue reference.
7045         * remote.c (remote_target::open_1): Use push_target overload.
7046         * corelow.c (core_target_open): Use push_target overload.
7047
7048 2019-02-15  Tom Tromey  <tromey@adacore.com>
7049
7050         * ravenscar-thread.c (is_ravenscar_task)
7051         (ravenscar_task_is_currently_active): Return bool.
7052         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7053         (_initialize_ravenscar): Remove "(void)".
7054         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7055         Return bool.
7056
7057 2019-02-15  Tom Tromey  <tromey@adacore.com>
7058
7059         * ravenscar-thread.c (ravenscar_runtime_initializer)
7060         (has_ravenscar_runtime, get_running_thread_id)
7061         (ravenscar_thread_target::resume): Fix indentation.
7062
7063 2019-02-15  Tom Tromey  <tromey@adacore.com>
7064
7065         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7066         from ravenscar_arch_ops.
7067         (sparc_ravenscar_ops::fetch_registers)
7068         (sparc_ravenscar_ops::store_registers): Now methods.
7069         (sparc_ravenscar_prepare_to_store): Remove.
7070         (sparc_ravenscar_ops): Redefine.
7071         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7072         methods and destructor.  Remove members.
7073         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7074         (ravenscar_thread_target::store_registers)
7075         (ravenscar_thread_target::prepare_to_store): Update.
7076         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7077         Remove.
7078         (struct ppc_ravenscar_powerpc_ops): Derive from
7079         ravenscar_arch_ops.
7080         (ppc_ravenscar_powerpc_ops::fetch_registers)
7081         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7082         (ppc_ravenscar_powerpc_ops): Redefine.
7083         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7084         (ppc_ravenscar_e500_ops::fetch_registers)
7085         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7086         (ppc_ravenscar_e500_ops): Redefine.
7087         * aarch64-ravenscar-thread.c
7088         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7089         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7090         (aarch64_ravenscar_fetch_registers)
7091         (aarch64_ravenscar_store_registers): Now methods.
7092         (aarch64_ravenscar_ops): Redefine.
7093
7094 2019-02-15  Tom Tromey  <tromey@adacore.com>
7095
7096         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7097         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7098         (ravenscar_thread_target::stopped_by_watchpoint)
7099         (ravenscar_thread_target::stopped_data_address)
7100         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7101
7102 2019-02-15  Tom Tromey  <tromey@adacore.com>
7103
7104         * ravenscar-thread.c: Fix some typos.
7105
7106 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7107             Tom Tromey  <tromey@adacore.com>
7108
7109         * ada-lang.c (ada_exception_sal): Change addr_string to a
7110         std::string.
7111         (create_ada_exception_catchpoint): Update.
7112
7113 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7114             Tom Tromey  <tromey@adacore.com>
7115
7116         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7117         (bp_location_ops): Remove.
7118         (base_breakpoint_allocate_location): Update.
7119         (free_bp_location): Update.
7120         * ada-lang.c (class ada_catchpoint_location)
7121         <ada_catchpoint_location>: Remove ops parameter.
7122         (ada_catchpoint_location_dtor): Remove.
7123         (ada_catchpoint_location_ops): Remove.
7124         (allocate_location_exception): Update.
7125         * breakpoint.h (struct bp_location_ops): Remove.
7126         (class bp_location) <bp_location>: Remove bp_location_ops
7127         parameter.
7128         <~bp_location>: Add destructor.
7129         <ops>: Remove.
7130
7131 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7132             Pedro Alves  <palves@redhat.com>
7133
7134         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7135         'PATH_MAX'.
7136
7137 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7138             Samuel Thibault  <samuel.thibault@gnu.org>
7139             Thomas Schwinge  <thomas@codesourcery.com>
7140
7141         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7142         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7143
7144 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7145
7146         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7147         (check_empty): Use "const char *".
7148
7149         * gnu-nat.c (gnu_nat_target::detach): Instead of
7150         'detach_inferior (pid)' call
7151         'detach_inferior (find_inferior_pid (pid))'.
7152
7153         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7154         'nat/fork-inferior.o'.
7155         * gnu-nat.c: #include "nat/fork-inferior.h".
7156
7157         * gnu-nat.c (gnu_nat_target::detach): Instead of
7158         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7159         * gnu-nat.h: #include "inf-child.h".
7160         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7161         'i386_gnu_nat_target::fetch_registers'.
7162         (gnu_store_registers): Rename/move to
7163         'i386_gnu_nat_target::store_registers'.
7164
7165         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7166         * gnu-nat.h (mach_thread_info): New function.
7167         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7168
7169         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7170
7171 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7172
7173         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7174
7175 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7176
7177         * windows-nat.c (windows_add_thread): Add new parameter
7178         "main_thread_p" with default value set to false.  Update
7179         function documentation as well as all callers.
7180         (windows_delete_thread): Likewise.
7181         (fake_create_process): Update call to windows_add_thread.
7182         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7183         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7184         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7185         call to windows_delete_thread.
7186
7187 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7188
7189         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7190
7191 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7192
7193         * symfile.c (find_separate_debug_file): Use canonical path of
7194         sysroot with child_path instead of gdb_sysroot if it is valid.
7195
7196 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7197
7198         * symfile.c (find_separate_debug_file): Use child_path to
7199         determine if an object file is under a sysroot.
7200
7201 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7202
7203         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7204         unittests/child-path-selftests.c.
7205         * common/pathstuff.c (child_path): New function.
7206         * common/pathstuff.h (child_path): New prototype.
7207         * unittests/child-path-selftests.c: New file.
7208
7209 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7210
7211         * symfile.c (find_separate_debug_file): Look for separate debug
7212         files in debug directories under the sysroot.
7213
7214 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7215
7216         * symtab.h (struct minimal_symbol data_p): New const method.
7217         (struct minimal_symbol text_p): Likewise.
7218         * symtab.c (output_source_filename): Use file name style
7219         to print file name.
7220         (print_symbol_info): Likewise.
7221         (print_msymbol_info): Use address style to print addresses.
7222         Use function name style to print executable text symbols.
7223         (expand_symtab_containing_pc): Use data_p.
7224         (find_pc_sect_compunit_symtab): Likewise.
7225
7226 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7227
7228         * breakpoint.c (describe_other_breakpoints): Use address style
7229         to print addresses.
7230         (say_where): Likewise.
7231
7232 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7233
7234         * ada-typeprint.c (print_func_type): Print function name
7235         style to print function name.
7236         * c-typeprint.c (c_print_type_1): Likewise.
7237
7238 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7239
7240         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7241         for execve.
7242
7243 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7244
7245         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7246         type_stack.
7247
7248 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7249
7250         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7251         TYPE_CODE_REF types.
7252
7253 2019-02-08  Jim Wilson  <jimw@sifive.com>
7254
7255         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7256         (riscv_linux_fregset): New.
7257         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7258
7259 2019-02-07  Tom Tromey  <tom@tromey.com>
7260
7261         * thread.c (thread_cancel_execution_command): Update.
7262         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7263         methods.
7264         (struct thread_fsm_ops): Remove.
7265         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7266         (thread_fsm_should_stop, thread_fsm_return_value)
7267         (thread_fsm_set_finished, thread_fsm_finished_p)
7268         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7269         Don't declare.
7270         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7271         * infrun.c (clear_proceed_status_thread)
7272         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7273         (print_stop_event): Update.
7274         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7275         Add constructor.
7276         (step_command_fsm_ops): Remove.
7277         (new_step_command_fsm): Remove.
7278         (step_1): Update.
7279         (step_command_fsm::should_stop): Rename from
7280         step_command_fsm_should_stop.
7281         (step_command_fsm::clean_up): Rename from
7282         step_command_fsm_clean_up.
7283         (step_command_fsm::do_async_reply_reason): Rename from
7284         step_command_fsm_async_reply_reason.
7285         (struct until_next_fsm): Inherit from thread_fsm.  Add
7286         constructor.
7287         (until_next_fsm_ops): Remove.
7288         (new_until_next_fsm): Remove.
7289         (until_next_fsm::should_stop): Rename from
7290         until_next_fsm_should_stop.
7291         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7292         (until_next_fsm::do_async_reply_reason): Rename from
7293         until_next_fsm_async_reply_reason.
7294         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7295         constructor.  Change type of breakpoint.
7296         (finish_command_fsm_ops): Remove.
7297         (new_finish_command_fsm): Remove.
7298         (finish_command_fsm::should_stop): Rename from
7299         finish_command_fsm_should_stop.
7300         (finish_command_fsm::clean_up): Rename from
7301         finish_command_fsm_clean_up.
7302         (finish_command_fsm::return_value): Rename from
7303         finish_command_fsm_return_value.
7304         (finish_command_fsm::do_async_reply_reason): Rename from
7305         finish_command_fsm_async_reply_reason.
7306         (finish_command): Update.
7307         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7308         Add constructor.
7309         (call_thread_fsm_ops): Remove.
7310         (call_thread_fsm::call_thread_fsm): Rename from
7311         new_call_thread_fsm.
7312         (call_thread_fsm::should_stop): Rename from
7313         call_thread_fsm_should_stop.
7314         (call_thread_fsm::should_notify_stop): Rename from
7315         call_thread_fsm_should_notify_stop.
7316         (run_inferior_call, call_function_by_hand_dummy): Update.
7317         * cli/cli-interp.c (should_print_stop_to_console): Update.
7318         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7319         Add constructor.  Change type of location_breakpoint,
7320         caller_breakpoint.
7321         (until_break_fsm_ops): Remove.
7322         (new_until_break_fsm): Remove.
7323         (until_break_fsm::should_stop): Rename from
7324         until_break_fsm_should_stop.
7325         (until_break_fsm::clean_up): Rename from
7326         until_break_fsm_clean_up.
7327         (until_break_fsm::do_async_reply_reason): Rename from
7328         until_break_fsm_async_reply_reason.
7329         (until_break_command): Update.
7330         * thread-fsm.c: Remove.
7331         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7332
7333 2019-02-07  Tom Tromey  <tom@tromey.com>
7334
7335         * yy-remap.h: Add include guard.
7336         * xtensa-tdep.h: Add include guard.
7337         * xcoffread.h: Rename include guard.
7338         * varobj-iter.h: Add include guard.
7339         * tui/tui.h: Rename include guard.
7340         * tui/tui-winsource.h: Rename include guard.
7341         * tui/tui-wingeneral.h: Rename include guard.
7342         * tui/tui-windata.h: Rename include guard.
7343         * tui/tui-win.h: Rename include guard.
7344         * tui/tui-stack.h: Rename include guard.
7345         * tui/tui-source.h: Rename include guard.
7346         * tui/tui-regs.h: Rename include guard.
7347         * tui/tui-out.h: Rename include guard.
7348         * tui/tui-layout.h: Rename include guard.
7349         * tui/tui-io.h: Rename include guard.
7350         * tui/tui-hooks.h: Rename include guard.
7351         * tui/tui-file.h: Rename include guard.
7352         * tui/tui-disasm.h: Rename include guard.
7353         * tui/tui-data.h: Rename include guard.
7354         * tui/tui-command.h: Rename include guard.
7355         * tic6x-tdep.h: Add include guard.
7356         * target/waitstatus.h: Rename include guard.
7357         * target/wait.h: Rename include guard.
7358         * target/target.h: Rename include guard.
7359         * target/resume.h: Rename include guard.
7360         * target-float.h: Rename include guard.
7361         * stabsread.h: Add include guard.
7362         * rs6000-tdep.h: Add include guard.
7363         * riscv-fbsd-tdep.h: Add include guard.
7364         * regformats/regdef.h: Rename include guard.
7365         * record.h: Rename include guard.
7366         * python/python.h: Rename include guard.
7367         * python/python-internal.h: Rename include guard.
7368         * python/py-stopevent.h: Rename include guard.
7369         * python/py-ref.h: Rename include guard.
7370         * python/py-record.h: Rename include guard.
7371         * python/py-record-full.h: Rename include guard.
7372         * python/py-record-btrace.h: Rename include guard.
7373         * python/py-instruction.h: Rename include guard.
7374         * python/py-events.h: Rename include guard.
7375         * python/py-event.h: Rename include guard.
7376         * procfs.h: Add include guard.
7377         * proc-utils.h: Add include guard.
7378         * p-lang.h: Add include guard.
7379         * or1k-tdep.h: Rename include guard.
7380         * observable.h: Rename include guard.
7381         * nto-tdep.h: Rename include guard.
7382         * nat/x86-linux.h: Rename include guard.
7383         * nat/x86-linux-dregs.h: Rename include guard.
7384         * nat/x86-gcc-cpuid.h: Add include guard.
7385         * nat/x86-dregs.h: Rename include guard.
7386         * nat/x86-cpuid.h: Rename include guard.
7387         * nat/ppc-linux.h: Rename include guard.
7388         * nat/mips-linux-watch.h: Rename include guard.
7389         * nat/linux-waitpid.h: Rename include guard.
7390         * nat/linux-ptrace.h: Rename include guard.
7391         * nat/linux-procfs.h: Rename include guard.
7392         * nat/linux-osdata.h: Rename include guard.
7393         * nat/linux-nat.h: Rename include guard.
7394         * nat/linux-namespaces.h: Rename include guard.
7395         * nat/linux-btrace.h: Rename include guard.
7396         * nat/glibc_thread_db.h: Rename include guard.
7397         * nat/gdb_thread_db.h: Rename include guard.
7398         * nat/gdb_ptrace.h: Rename include guard.
7399         * nat/fork-inferior.h: Rename include guard.
7400         * nat/amd64-linux-siginfo.h: Rename include guard.
7401         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7402         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7403         * nat/aarch64-linux.h: Rename include guard.
7404         * nat/aarch64-linux-hw-point.h: Rename include guard.
7405         * mn10300-tdep.h: Add include guard.
7406         * mips-linux-tdep.h: Add include guard.
7407         * mi/mi-parse.h: Rename include guard.
7408         * mi/mi-out.h: Rename include guard.
7409         * mi/mi-main.h: Rename include guard.
7410         * mi/mi-interp.h: Rename include guard.
7411         * mi/mi-getopt.h: Rename include guard.
7412         * mi/mi-console.h: Rename include guard.
7413         * mi/mi-common.h: Rename include guard.
7414         * mi/mi-cmds.h: Rename include guard.
7415         * mi/mi-cmd-break.h: Rename include guard.
7416         * m2-lang.h: Add include guard.
7417         * location.h: Rename include guard.
7418         * linux-record.h: Rename include guard.
7419         * linux-nat.h: Add include guard.
7420         * linux-fork.h: Add include guard.
7421         * i386-darwin-tdep.h: Rename include guard.
7422         * hppa-linux-offsets.h: Add include guard.
7423         * guile/guile.h: Rename include guard.
7424         * guile/guile-internal.h: Rename include guard.
7425         * gnu-nat.h: Rename include guard.
7426         * gdb-stabs.h: Rename include guard.
7427         * frv-tdep.h: Add include guard.
7428         * f-lang.h: Add include guard.
7429         * event-loop.h: Add include guard.
7430         * darwin-nat.h: Rename include guard.
7431         * cp-abi.h: Rename include guard.
7432         * config/sparc/nm-sol2.h: Rename include guard.
7433         * config/nm-nto.h: Rename include guard.
7434         * config/nm-linux.h: Add include guard.
7435         * config/i386/nm-i386gnu.h: Rename include guard.
7436         * config/djgpp/nl_types.h: Rename include guard.
7437         * config/djgpp/langinfo.h: Rename include guard.
7438         * compile/gcc-cp-plugin.h: Add include guard.
7439         * compile/gcc-c-plugin.h: Add include guard.
7440         * compile/compile.h: Rename include guard.
7441         * compile/compile-object-run.h: Rename include guard.
7442         * compile/compile-object-load.h: Rename include guard.
7443         * compile/compile-internal.h: Rename include guard.
7444         * compile/compile-cplus.h: Rename include guard.
7445         * compile/compile-c.h: Rename include guard.
7446         * common/xml-utils.h: Rename include guard.
7447         * common/x86-xstate.h: Rename include guard.
7448         * common/version.h: Rename include guard.
7449         * common/vec.h: Rename include guard.
7450         * common/tdesc.h: Rename include guard.
7451         * common/selftest.h: Rename include guard.
7452         * common/scoped_restore.h: Rename include guard.
7453         * common/scoped_mmap.h: Rename include guard.
7454         * common/scoped_fd.h: Rename include guard.
7455         * common/safe-iterator.h: Rename include guard.
7456         * common/run-time-clock.h: Rename include guard.
7457         * common/refcounted-object.h: Rename include guard.
7458         * common/queue.h: Rename include guard.
7459         * common/ptid.h: Rename include guard.
7460         * common/print-utils.h: Rename include guard.
7461         * common/preprocessor.h: Rename include guard.
7462         * common/pathstuff.h: Rename include guard.
7463         * common/observable.h: Rename include guard.
7464         * common/netstuff.h: Rename include guard.
7465         * common/job-control.h: Rename include guard.
7466         * common/host-defs.h: Rename include guard.
7467         * common/gdb_wait.h: Rename include guard.
7468         * common/gdb_vecs.h: Rename include guard.
7469         * common/gdb_unlinker.h: Rename include guard.
7470         * common/gdb_unique_ptr.h: Rename include guard.
7471         * common/gdb_tilde_expand.h: Rename include guard.
7472         * common/gdb_sys_time.h: Rename include guard.
7473         * common/gdb_string_view.h: Rename include guard.
7474         * common/gdb_splay_tree.h: Rename include guard.
7475         * common/gdb_setjmp.h: Rename include guard.
7476         * common/gdb_ref_ptr.h: Rename include guard.
7477         * common/gdb_optional.h: Rename include guard.
7478         * common/gdb_locale.h: Rename include guard.
7479         * common/gdb_assert.h: Rename include guard.
7480         * common/filtered-iterator.h: Rename include guard.
7481         * common/filestuff.h: Rename include guard.
7482         * common/fileio.h: Rename include guard.
7483         * common/environ.h: Rename include guard.
7484         * common/common-utils.h: Rename include guard.
7485         * common/common-types.h: Rename include guard.
7486         * common/common-regcache.h: Rename include guard.
7487         * common/common-inferior.h: Rename include guard.
7488         * common/common-gdbthread.h: Rename include guard.
7489         * common/common-exceptions.h: Rename include guard.
7490         * common/common-defs.h: Rename include guard.
7491         * common/common-debug.h: Rename include guard.
7492         * common/cleanups.h: Rename include guard.
7493         * common/buffer.h: Rename include guard.
7494         * common/btrace-common.h: Rename include guard.
7495         * common/break-common.h: Rename include guard.
7496         * cli/cli-utils.h: Rename include guard.
7497         * cli/cli-style.h: Rename include guard.
7498         * cli/cli-setshow.h: Rename include guard.
7499         * cli/cli-script.h: Rename include guard.
7500         * cli/cli-interp.h: Rename include guard.
7501         * cli/cli-decode.h: Rename include guard.
7502         * cli/cli-cmds.h: Rename include guard.
7503         * charset-list.h: Add include guard.
7504         * buildsym-legacy.h: Rename include guard.
7505         * bfin-tdep.h: Add include guard.
7506         * ax.h: Rename include guard.
7507         * arm-linux-tdep.h: Add include guard.
7508         * arm-fbsd-tdep.h: Add include guard.
7509         * arch/xtensa.h: Rename include guard.
7510         * arch/tic6x.h: Add include guard.
7511         * arch/i386.h: Add include guard.
7512         * arch/arm.h: Rename include guard.
7513         * arch/arm-linux.h: Rename include guard.
7514         * arch/arm-get-next-pcs.h: Rename include guard.
7515         * arch/amd64.h: Add include guard.
7516         * arch/aarch64-insn.h: Rename include guard.
7517         * arch-utils.h: Rename include guard.
7518         * annotate.h: Add include guard.
7519         * amd64-darwin-tdep.h: Rename include guard.
7520         * aarch64-linux-tdep.h: Add include guard.
7521         * aarch64-fbsd-tdep.h: Add include guard.
7522         * aarch32-linux-nat.h: Add include guard.
7523
7524 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7525
7526         * macrotab.c (macro_define_internal): New function that
7527         factorizes macro_define_object_internal and macro_define_function
7528         code.
7529         (macro_define_object_internal): Use macro_define_internal.
7530         (macro_define_function): Likewise.
7531
7532 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7533
7534         * macrocmd.c (extract_identifier): Return
7535         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7536         callers.
7537
7538 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7539
7540         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7541
7542 2019-02-05  Tom Tromey  <tom@tromey.com>
7543
7544         * target.c (target_stack::unpush): Move assertion earlier.
7545
7546 2019-01-30  Tom Tromey  <tom@tromey.com>
7547
7548         PR python/23615:
7549         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7550         (gdbpy_parse_and_eval): Likewise.
7551         * python/python-internal.h (gdbpy_allow_threads): New class.
7552
7553 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7554
7555         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7556         (aarch64_fbsd_fpregmap): Move earlier.
7557         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7558         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7559         instead of individual calls to trad_frame_set_reg_addr.
7560         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7561         earlier.
7562         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7563         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7564         instead of individual calls to trad_frame_set_reg_addr.
7565
7566 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7567
7568         * CONTRIBUTE: Replace contribution list with wiki link.
7569
7570 2019-01-25  Tom Tromey  <tom@tromey.com>
7571
7572         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7573
7574 2019-01-25  Tom Tromey  <tom@tromey.com>
7575
7576         * xtensa-linux-nat.c: Fix common/ includes.
7577         * xml-support.h: Fix common/ includes.
7578         * xml-support.c: Fix common/ includes.
7579         * x86-linux-nat.c: Fix common/ includes.
7580         * windows-nat.c: Fix common/ includes.
7581         * varobj.h: Fix common/ includes.
7582         * varobj.c: Fix common/ includes.
7583         * value.c: Fix common/ includes.
7584         * valops.c: Fix common/ includes.
7585         * utils.c: Fix common/ includes.
7586         * unittests/xml-utils-selftests.c: Fix common/ includes.
7587         * unittests/utils-selftests.c: Fix common/ includes.
7588         * unittests/unpack-selftests.c: Fix common/ includes.
7589         * unittests/tracepoint-selftests.c: Fix common/ includes.
7590         * unittests/style-selftests.c: Fix common/ includes.
7591         * unittests/string_view-selftests.c: Fix common/ includes.
7592         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7593         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7594         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7595         * unittests/rsp-low-selftests.c: Fix common/ includes.
7596         * unittests/parse-connection-spec-selftests.c: Fix common/
7597         includes.
7598         * unittests/optional-selftests.c: Fix common/ includes.
7599         * unittests/offset-type-selftests.c: Fix common/ includes.
7600         * unittests/observable-selftests.c: Fix common/ includes.
7601         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7602         * unittests/memrange-selftests.c: Fix common/ includes.
7603         * unittests/memory-map-selftests.c: Fix common/ includes.
7604         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7605         * unittests/function-view-selftests.c: Fix common/ includes.
7606         * unittests/environ-selftests.c: Fix common/ includes.
7607         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7608         * unittests/common-utils-selftests.c: Fix common/ includes.
7609         * unittests/cli-utils-selftests.c: Fix common/ includes.
7610         * unittests/array-view-selftests.c: Fix common/ includes.
7611         * ui-file.c: Fix common/ includes.
7612         * tui/tui-io.c: Fix common/ includes.
7613         * tracepoint.h: Fix common/ includes.
7614         * tracepoint.c: Fix common/ includes.
7615         * tracefile-tfile.c: Fix common/ includes.
7616         * top.h: Fix common/ includes.
7617         * top.c: Fix common/ includes.
7618         * thread.c: Fix common/ includes.
7619         * target/waitstatus.h: Fix common/ includes.
7620         * target/waitstatus.c: Fix common/ includes.
7621         * target.h: Fix common/ includes.
7622         * target.c: Fix common/ includes.
7623         * target-memory.c: Fix common/ includes.
7624         * target-descriptions.c: Fix common/ includes.
7625         * symtab.h: Fix common/ includes.
7626         * symfile.c: Fix common/ includes.
7627         * stap-probe.c: Fix common/ includes.
7628         * spu-linux-nat.c: Fix common/ includes.
7629         * sparc-nat.c: Fix common/ includes.
7630         * source.c: Fix common/ includes.
7631         * solib.c: Fix common/ includes.
7632         * solib-target.c: Fix common/ includes.
7633         * ser-unix.c: Fix common/ includes.
7634         * ser-tcp.c: Fix common/ includes.
7635         * ser-pipe.c: Fix common/ includes.
7636         * ser-base.c: Fix common/ includes.
7637         * selftest-arch.c: Fix common/ includes.
7638         * s12z-tdep.c: Fix common/ includes.
7639         * rust-exp.y: Fix common/ includes.
7640         * rs6000-aix-tdep.c: Fix common/ includes.
7641         * riscv-tdep.c: Fix common/ includes.
7642         * remote.c: Fix common/ includes.
7643         * remote-notif.h: Fix common/ includes.
7644         * remote-fileio.h: Fix common/ includes.
7645         * remote-fileio.c: Fix common/ includes.
7646         * regcache.h: Fix common/ includes.
7647         * regcache.c: Fix common/ includes.
7648         * record-btrace.c: Fix common/ includes.
7649         * python/python.c: Fix common/ includes.
7650         * python/py-type.c: Fix common/ includes.
7651         * python/py-inferior.c: Fix common/ includes.
7652         * progspace.h: Fix common/ includes.
7653         * producer.c: Fix common/ includes.
7654         * procfs.c: Fix common/ includes.
7655         * proc-api.c: Fix common/ includes.
7656         * printcmd.c: Fix common/ includes.
7657         * ppc-linux-nat.c: Fix common/ includes.
7658         * parser-defs.h: Fix common/ includes.
7659         * osdata.c: Fix common/ includes.
7660         * obsd-nat.c: Fix common/ includes.
7661         * nat/x86-linux.c: Fix common/ includes.
7662         * nat/x86-linux-dregs.c: Fix common/ includes.
7663         * nat/x86-dregs.h: Fix common/ includes.
7664         * nat/x86-dregs.c: Fix common/ includes.
7665         * nat/ppc-linux.c: Fix common/ includes.
7666         * nat/mips-linux-watch.h: Fix common/ includes.
7667         * nat/mips-linux-watch.c: Fix common/ includes.
7668         * nat/linux-waitpid.c: Fix common/ includes.
7669         * nat/linux-ptrace.h: Fix common/ includes.
7670         * nat/linux-ptrace.c: Fix common/ includes.
7671         * nat/linux-procfs.c: Fix common/ includes.
7672         * nat/linux-personality.c: Fix common/ includes.
7673         * nat/linux-osdata.c: Fix common/ includes.
7674         * nat/linux-namespaces.c: Fix common/ includes.
7675         * nat/linux-btrace.h: Fix common/ includes.
7676         * nat/linux-btrace.c: Fix common/ includes.
7677         * nat/fork-inferior.c: Fix common/ includes.
7678         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7679         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7680         * nat/aarch64-linux.c: Fix common/ includes.
7681         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7682         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7683         * namespace.h: Fix common/ includes.
7684         * mips-linux-tdep.c: Fix common/ includes.
7685         * minsyms.c: Fix common/ includes.
7686         * mi/mi-parse.h: Fix common/ includes.
7687         * mi/mi-main.c: Fix common/ includes.
7688         * mi/mi-cmd-env.c: Fix common/ includes.
7689         * memrange.h: Fix common/ includes.
7690         * memattr.c: Fix common/ includes.
7691         * maint.h: Fix common/ includes.
7692         * maint.c: Fix common/ includes.
7693         * main.c: Fix common/ includes.
7694         * machoread.c: Fix common/ includes.
7695         * location.c: Fix common/ includes.
7696         * linux-thread-db.c: Fix common/ includes.
7697         * linux-nat.c: Fix common/ includes.
7698         * linux-fork.c: Fix common/ includes.
7699         * inline-frame.c: Fix common/ includes.
7700         * infrun.c: Fix common/ includes.
7701         * inflow.c: Fix common/ includes.
7702         * inferior.h: Fix common/ includes.
7703         * inferior.c: Fix common/ includes.
7704         * infcmd.c: Fix common/ includes.
7705         * inf-ptrace.c: Fix common/ includes.
7706         * inf-child.c: Fix common/ includes.
7707         * ia64-linux-nat.c: Fix common/ includes.
7708         * i387-tdep.c: Fix common/ includes.
7709         * i386-tdep.c: Fix common/ includes.
7710         * i386-linux-tdep.c: Fix common/ includes.
7711         * i386-linux-nat.c: Fix common/ includes.
7712         * i386-go32-tdep.c: Fix common/ includes.
7713         * i386-fbsd-tdep.c: Fix common/ includes.
7714         * i386-fbsd-nat.c: Fix common/ includes.
7715         * guile/scm-type.c: Fix common/ includes.
7716         * guile/guile.c: Fix common/ includes.
7717         * go32-nat.c: Fix common/ includes.
7718         * gnu-nat.c: Fix common/ includes.
7719         * gdbthread.h: Fix common/ includes.
7720         * gdbarch-selftests.c: Fix common/ includes.
7721         * gdb_usleep.c: Fix common/ includes.
7722         * gdb_select.h: Fix common/ includes.
7723         * gdb_bfd.c: Fix common/ includes.
7724         * gcore.c: Fix common/ includes.
7725         * fork-child.c: Fix common/ includes.
7726         * findvar.c: Fix common/ includes.
7727         * fbsd-nat.c: Fix common/ includes.
7728         * event-top.c: Fix common/ includes.
7729         * event-loop.c: Fix common/ includes.
7730         * dwarf2read.c: Fix common/ includes.
7731         * dwarf2loc.c: Fix common/ includes.
7732         * dwarf2-frame.c: Fix common/ includes.
7733         * dwarf-index-cache.c: Fix common/ includes.
7734         * dtrace-probe.c: Fix common/ includes.
7735         * disasm-selftests.c: Fix common/ includes.
7736         * defs.h: Fix common/ includes.
7737         * csky-tdep.c: Fix common/ includes.
7738         * cp-valprint.c: Fix common/ includes.
7739         * cp-support.h: Fix common/ includes.
7740         * cp-support.c: Fix common/ includes.
7741         * corelow.c: Fix common/ includes.
7742         * completer.h: Fix common/ includes.
7743         * completer.c: Fix common/ includes.
7744         * compile/compile.c: Fix common/ includes.
7745         * compile/compile-loc2c.c: Fix common/ includes.
7746         * compile/compile-cplus-types.c: Fix common/ includes.
7747         * compile/compile-cplus-symbols.c: Fix common/ includes.
7748         * command.h: Fix common/ includes.
7749         * cli/cli-dump.c: Fix common/ includes.
7750         * cli/cli-cmds.c: Fix common/ includes.
7751         * charset.c: Fix common/ includes.
7752         * build-id.c: Fix common/ includes.
7753         * btrace.h: Fix common/ includes.
7754         * btrace.c: Fix common/ includes.
7755         * breakpoint.h: Fix common/ includes.
7756         * breakpoint.c: Fix common/ includes.
7757         * ax.h: 
7758         (enum agent_op): Fix common/ includes.
7759         * ax-general.c (struct aop_map): Fix common/ includes.
7760         * ax-gdb.c: Fix common/ includes.
7761         * auxv.c: Fix common/ includes.
7762         * auto-load.c: Fix common/ includes.
7763         * arm-tdep.c: Fix common/ includes.
7764         * arch/riscv.c: Fix common/ includes.
7765         * arch/ppc-linux-common.c: Fix common/ includes.
7766         * arch/i386.c: Fix common/ includes.
7767         * arch/arm.c: Fix common/ includes.
7768         * arch/arm-linux.c: Fix common/ includes.
7769         * arch/arm-get-next-pcs.c: Fix common/ includes.
7770         * arch/amd64.c: Fix common/ includes.
7771         * arch/aarch64.c: Fix common/ includes.
7772         * arch/aarch64-insn.c: Fix common/ includes.
7773         * arch-utils.c: Fix common/ includes.
7774         * amd64-windows-tdep.c: Fix common/ includes.
7775         * amd64-tdep.c: Fix common/ includes.
7776         * amd64-sol2-tdep.c: Fix common/ includes.
7777         * amd64-obsd-tdep.c: Fix common/ includes.
7778         * amd64-nbsd-tdep.c: Fix common/ includes.
7779         * amd64-linux-tdep.c: Fix common/ includes.
7780         * amd64-linux-nat.c: Fix common/ includes.
7781         * amd64-fbsd-tdep.c: Fix common/ includes.
7782         * amd64-fbsd-nat.c: Fix common/ includes.
7783         * amd64-dicos-tdep.c: Fix common/ includes.
7784         * amd64-darwin-tdep.c: Fix common/ includes.
7785         * agent.c: Fix common/ includes.
7786         * ada-lang.h: Fix common/ includes.
7787         * ada-lang.c: Fix common/ includes.
7788         * aarch64-tdep.c: Fix common/ includes.
7789
7790 2019-01-25  Tom Tromey  <tom@tromey.com>
7791
7792         * common/create-version.sh: Use common/version.h.
7793
7794 2019-01-24  Pedro Alves  <palves@redhat.com>
7795
7796         * infrun.c (signal_stop, signal_print, signal_program)
7797         (signal_catch, signal_pass): Now arrays instead of pointers.
7798         (update_signals_program_target, do_target_resume)
7799         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7800         * linux-nat.c (linux_nat_target::pass_signals)
7801         (linux_nat_target::create_inferior, linux_nat_target::attach):
7802         Adjust.
7803         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7804         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7805         * procfs.c (procfs_target::pass_signals): Adjust.
7806         * record-full.c (record_full_target::resume): Adjust.
7807         * remote.c (remote_target::pass_signals)
7808         (remote_target::program_signals): Adjust.
7809         * target-debug.h (target_debug_print_signals): Now takes a
7810         gdb::array_view as parameter.  Adjust.
7811         * target.h (target_ops) <pass_signals, program_signals>: Replace
7812         pointer and length parameters with gdb::array_view.
7813         (target_pass_signals, target_program_signals): Likewise.
7814         * target-delegates.c: Regenerate.
7815
7816 2019-01-24  Pedro Alves  <palves@redhat.com>
7817
7818         * common/forward-scope-exit.h
7819         (forward_scope_exit::forward_scope_exit): Pass arguments to
7820         m_bind_function directly, instead of creating a std::bind and
7821         copying that.
7822
7823 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7824
7825         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7826         for static members.
7827         (pass_in_v_vfp_candidate): Likewise.
7828
7829 2019-01-23  Tom Tromey  <tom@tromey.com>
7830             Pedro Alves  <palves@redhat.com>
7831
7832         * regcache.c (class regcache_invalidator): Remove.
7833         (regcache::raw_write): Use make_scope_exit.
7834
7835 2019-01-23  Tom Tromey  <tom@tromey.com>
7836
7837         * ui-out.h (class ui_out_emit_type): Update comment.
7838
7839 2019-01-23  Tom Tromey  <tom@tromey.com>
7840
7841         * infrun.c (fetch_inferior_event): Update comment.
7842
7843 2019-01-23  Tom Tromey  <tom@tromey.com>
7844             Pedro Alves  <palves@redhat.com>
7845
7846         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7847         parameter.
7848         (fetch_inferior_event): Use SCOPE_EXIT.
7849
7850
7851 2019-01-23  Tom Tromey  <tom@tromey.com>
7852             Pedro Alves  <palves@redhat.com>
7853
7854         * infrun.c (disable_thread_events): Delete.
7855         (stop_all_threads): Use SCOPE_EXIT.
7856
7857 2019-01-23  Tom Tromey  <tom@tromey.com>
7858             Pedro Alves  <palves@redhat.com>
7859
7860         * symfile.c: Include forward-scope-exit.h.
7861         (clear_symtab_users_cleanup): Replace forward declaration with
7862         a FORWARD_SCOPE_EXIT.
7863         (syms_from_objfile_1): Use the forward_scope_exit and
7864         gdb::optional instead of cleanup_function.
7865         (reread_symbols): Use the forward_scope_exit instead of
7866         cleanup_function.
7867         (clear_symtab_users_cleanup): Remove function.
7868
7869 2019-01-23  Tom Tromey  <tom@tromey.com>
7870             Pedro Alves  <palves@redhat.com>
7871
7872         * linux-nat.c: Include scope-exit.h.
7873         (cleanup_target_stop): Remove.
7874         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7875         SCOPE_EXIT.
7876
7877 2019-01-23  Tom Tromey  <tom@tromey.com>
7878             Pedro Alves  <palves@redhat.com>
7879
7880         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7881         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7882
7883 2019-01-23  Tom Tromey  <tom@tromey.com>
7884             Andrew Burgess  <andrew.burgess@embecosm.com>
7885             Pedro Alves  <palves@redhat.com>
7886
7887         * infrun.c (fetch_inferior_event): Use scope_exit.
7888         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7889         * top.c (execute_command): Use scope_exit.
7890         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7891         * utils.c (do_bpstat_clear_actions_cleanup)
7892         (make_bpstat_clear_actions_cleanup): Remove.
7893
7894 2019-01-23  Tom Tromey  <tom@tromey.com>
7895             Pedro Alves  <palves@redhat.com>
7896
7897         * infrun.c: Include "common/scope-exit.h"
7898         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7899         (wait_for_inferior): Use SCOPE_EXIT.
7900         (fetch_inferior_event): Use scope_exit.
7901
7902 2019-01-23  Tom Tromey  <tom@tromey.com>
7903             Pedro Alves  <palves@redhat.com>
7904
7905         * breakpoint.c (create_breakpoint): Remove cleanup.
7906
7907 2019-01-23  Tom Tromey  <tom@tromey.com>
7908             Andrew Burgess  <andrew.burgess@embecosm.com>
7909             Pedro Alves  <palves@redhat.com>
7910
7911 2019-01-23  Pedro Alves  <palves@redhat.com>
7912
7913         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7914
7915 2019-01-23  Pedro Alves  <palves@redhat.com>
7916             Andrew Burgess  <andrew.burgess@embecosm.com>
7917
7918         * gdbthread.h: Include "common/forward-scope-exit.h".
7919         (scoped_finish_thread_state): Redefine custom class in terms of
7920         forward_scope_exit.
7921
7922 2019-01-23  Pedro Alves  <palves@redhat.com>
7923             Andrew Burgess  <andrew.burgess@embecosm.com>
7924
7925         * common/forward-scope-exit.h: New file.
7926
7927 2019-01-23  Pedro Alves  <palves@redhat.com>
7928             Andrew Burgess  <andrew.burgess@embecosm.com>
7929             Tom Tromey  <tom@tromey.com>
7930
7931         * common/scope-exit.h: New file.
7932
7933 2019-01-23  Pedro Alves  <palves@redhat.com>
7934
7935         * common/preprocessor.h (ESC): Rename to ...
7936         (ESC_PARENS): ... this.
7937         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7938         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7939
7940 2019-01-23  Tom Tromey  <tom@tromey.com>
7941
7942         * language.h (class scoped_switch_to_sym_language_if_auto):
7943         Initialize m_lang in both cases.
7944
7945 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7946
7947         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7948         with XCNEW.
7949
7950 2019-01-22  Tom Tromey  <tom@tromey.com>
7951
7952         * corelow.c: Do not include sys/file.h.
7953
7954 2019-01-22  Tom Tromey  <tom@tromey.com>
7955
7956         * tui/tui-wingeneral.h: Include gdb_curses.h.
7957
7958 2019-01-22  Tom Tromey  <tom@tromey.com>
7959
7960         * source-cache.h (class source_cache) <get_source_lines,
7961         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7962
7963 2019-01-22  Tom Tromey  <tom@tromey.com>
7964
7965         * remote-fileio.h (struct remote_target): Declare.
7966
7967 2019-01-22  Tom Tromey  <tom@tromey.com>
7968
7969         * python/py-arch.c: Do not include py-ref.h.
7970         * python/py-bpevent.c: Do not include py-ref.h.
7971         * python/py-cmd.c: Do not include py-ref.h.
7972         * python/py-continueevent.c: Do not include py-ref.h.
7973         * python/py-event.h: Do not include py-ref.h.
7974         * python/py-evtregistry.c: Do not include py-ref.h.
7975         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7976         * python/py-frame.c: Do not include py-ref.h.
7977         * python/py-framefilter.c: Do not include py-ref.h.
7978         * python/py-function.c: Do not include py-ref.h.
7979         * python/py-infevents.c: Do not include py-ref.h.
7980         * python/py-linetable.c: Do not include py-ref.h.
7981         * python/py-objfile.c: Do not include py-ref.h.
7982         * python/py-param.c: Do not include py-ref.h.
7983         * python/py-prettyprint.c: Do not include py-ref.h.
7984         * python/py-progspace.c: Do not include py-ref.h.
7985         * python/py-symbol.c: Do not include py-ref.h.
7986         * python/py-symtab.c: Do not include py-ref.h.
7987         * python/py-type.c: Do not include py-ref.h.
7988         * python/py-unwind.c: Do not include py-ref.h.
7989         * python/py-utils.c: Do not include py-ref.h.
7990         * python/py-value.c: Do not include py-ref.h.
7991         * python/py-varobj.c: Do not include py-ref.h.
7992         * python/py-xmethods.c: Do not include py-ref.h.
7993         * python/python.c: Do not include py-ref.h.
7994         * varobj.c: Do not include py-ref.h.
7995
7996 2019-01-22  Tom Tromey  <tom@tromey.com>
7997
7998         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7999         keyword for bcache.
8000
8001 2019-01-22  Tom Tromey  <tom@tromey.com>
8002
8003         * compile/compile-cplus-types.c: Remove a comment by #include.
8004
8005 2019-01-22  Tom Tromey  <tom@tromey.com>
8006
8007         * compile/gcc-c-plugin.h: Include compile-internal.h.
8008
8009 2019-01-22  Tom Tromey  <tom@tromey.com>
8010
8011         * stabsread.c (EXTERN): Do not define.
8012         (symnum, next_symbol_text_func, processing_gcc_compilation)
8013         (within_function, global_sym_chain, global_stabs)
8014         (previous_stab_code, this_object_header_files)
8015         (n_this_object_header_files)
8016         (n_allocated_this_object_header_files): Define.
8017         * stabsread.h (EXTERN): Never define.  Use "extern".
8018
8019 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8020
8021         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8022         history_value.
8023
8024 2019-01-21  Tom Tromey  <tom@tromey.com>
8025
8026         * ui-out.c: Fix includes.
8027         * tui/tui-source.c: Fix includes.
8028         * target.c: Fix includes.
8029         * remote.c: Fix includes.
8030         * regcache.c: Fix includes.
8031         * python/py-block.c: Fix includes.
8032         * printcmd.c: Fix includes.
8033         * or1k-tdep.c: Fix includes.
8034         * mi/mi-main.c: Fix includes.
8035         * m32r-tdep.c: Fix includes.
8036         * csky-tdep.c: Fix includes.
8037         * compile/compile-cplus-types.c: Fix includes.
8038         * cli/cli-interp.c: Fix includes.
8039
8040 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8041
8042         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8043         for padding.
8044
8045 2019-01-16  Tom Tromey  <tom@tromey.com>
8046
8047         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8048         earlier.
8049         (struct objfile) <msymbols_range>: Move from top level.
8050         <msymbols>: New method.
8051         (class objfile_msymbols): Remove.
8052         * symtab.c (default_collect_symbol_completion_matches_break_on):
8053         Update.
8054         * symmisc.c (dump_msymbols): Update.
8055         * stabsread.c (scan_file_globals): Update.
8056         * objc-lang.c (info_selectors_command, info_classes_command)
8057         (find_methods): Update.
8058         * minsyms.c (find_solib_trampoline_target): Update.
8059         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8060         * coffread.c (coff_symfile_read): Update.
8061         * ada-lang.c (ada_lookup_simple_minsym)
8062         (ada_collect_symbol_completion_matches): Update.
8063
8064 2019-01-16  Tom Tromey  <tom@tromey.com>
8065
8066         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8067         type.  Remove no-argument constructor.
8068         <iterator::operator++>: Simplify.
8069         <begin>: Update.
8070         <end>: Use minimal_symbol_count.
8071
8072 2019-01-16  Tom Tromey  <tom@tromey.com>
8073
8074         * objfiles.h (struct objfile) <psymtabs>: New method.
8075         (class objfile_psymtabs): Remove.
8076         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8077         typedef.
8078         <range>: New method.
8079         (require_partial_symbols): Change return type.
8080         * psymtab.c (require_partial_symbols)
8081         (psym_expand_symtabs_matching): Update.
8082         * mdebugread.c (parse_partial_symbols): Update.
8083         * dbxread.c (dbx_end_psymtab): Update.
8084
8085 2019-01-15  Tom Tromey  <tom@tromey.com>
8086
8087         * symtab.c (lookup_objfile_from_block)
8088         (lookup_symbol_in_objfile_symtabs)
8089         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8090         (find_line_symtab, info_sources_command)
8091         (default_collect_symbol_completion_matches_break_on)
8092         (make_source_files_completion_list): Update.
8093         * symmisc.c (print_objfile_statistics, dump_objfile)
8094         (maintenance_print_symbols, maintenance_info_symtabs)
8095         (maintenance_check_symtabs, maintenance_info_line_tables):
8096         Update.
8097         * source.c (select_source_symtab)
8098         (forget_cached_source_info_for_objfile): Update.
8099         * objfiles.h (class objfile_compunits): Remove.
8100         (struct objfile) <compunits_range>: New typedef.
8101         (compunits): New method.
8102         * objfiles.c (objfile_relocate1): Update.
8103         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8104         * maint.c (count_symtabs_and_blocks): Update.
8105         * linespec.c (iterate_over_all_matching_symtabs): Update.
8106         * cp-support.c (add_symbol_overload_list_qualified): Update.
8107         * coffread.c (coff_symtab_read): Update.
8108         * ada-lang.c (add_nonlocal_symbols)
8109         (ada_collect_symbol_completion_matches)
8110         (ada_add_global_exceptions): Update.
8111
8112 2019-01-15  Tom Tromey  <tom@tromey.com>
8113
8114         * progspace.h (program_space) <objfiles_safe_range>: New
8115         typedef.
8116         <objfiles_safe>: New method.
8117         * objfiles.h (class all_objfiles_safe): Remove.
8118         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8119         * jit.c (jit_inferior_exit_hook): Update.
8120
8121 2019-01-17  Tom Tromey  <tom@tromey.com>
8122
8123         * progspace.h (program_space) <objfiles_range>: New typedef.
8124         <objfiles>: New method.
8125         <objfiles_head>: Rename from objfiles.
8126         (object_files): Update.
8127         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8128         * guile/scm-pretty-print.c
8129         (ppscm_find_pretty_printer_from_objfiles): Update.
8130         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8131         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8132         Update.
8133         * python/py-progspace.c (pspy_get_objfiles): Update.
8134         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8135         Update.
8136         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8137         (objfpy_lookup_objfile_by_build_id): Update.
8138         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8139         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8140         Update.
8141         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8142         (expand_symtab_containing_pc, lookup_objfile_from_block)
8143         (lookup_static_symbol, basic_lookup_transparent_type)
8144         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8145         (find_line_symtab, info_sources_command)
8146         (default_collect_symbol_completion_matches_break_on)
8147         (make_source_files_completion_list, find_main_name): Update.
8148         * symmisc.c (print_symbol_bcache_statistics)
8149         (print_objfile_statistics, maintenance_print_symbols)
8150         (maintenance_print_msymbols, maintenance_print_objfiles)
8151         (maintenance_info_symtabs, maintenance_check_symtabs)
8152         (maintenance_expand_symtabs, maintenance_info_line_tables):
8153         Update.
8154         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8155         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8156         (map_overlay_command, unmap_overlay_command)
8157         (simple_overlay_update, expand_symtabs_matching)
8158         (map_symbol_filenames): Update.
8159         * symfile-debug.c (set_debug_symfile): Update.
8160         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8161         Update.
8162         * source.c (select_source_symtab, forget_cached_source_info):
8163         Update.
8164         * solib.c (solib_read_symbols): Update.
8165         * solib-spu.c (append_ocl_sos): Update.
8166         * psymtab.c (maintenance_print_psymbols)
8167         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8168         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8169         * printcmd.c (info_symbol_command): Update.
8170         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8171         Update.
8172         * objfiles.h (class all_objfiles): Remove.
8173         * objfiles.c (have_partial_symbols, have_full_symbols)
8174         (have_minimal_symbols, qsort_cmp, update_section_map)
8175         (shared_objfile_contains_address_p)
8176         (default_iterate_over_objfiles_in_search_order): Update.
8177         * objc-lang.c (info_selectors_command, info_classes_command)
8178         (find_methods): Update.
8179         * minsyms.c (find_solib_trampoline_target): Update.
8180         * maint.c (maintenance_info_sections)
8181         (maintenance_translate_address, count_symtabs_and_blocks):
8182         Update.
8183         * main.c (captured_main_1): Update.
8184         * linux-thread-db.c (try_thread_db_load_from_pdir)
8185         (has_libpthread): Update.
8186         * linespec.c (iterate_over_all_matching_symtabs)
8187         (search_minsyms_for_name): Update.
8188         * jit.c (jit_find_objf_with_entry_addr): Update.
8189         * hppa-tdep.c (find_unwind_entry)
8190         (hppa_lookup_stub_minimal_symbol): Update.
8191         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8192         Update.
8193         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8194         (elf_gnu_ifunc_resolve_by_got): Update.
8195         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8196         * dwarf-index-write.c (save_gdb_index_command): Update.
8197         * cp-support.c (add_symbol_overload_list_qualified): Update.
8198         * breakpoint.c (create_overlay_event_breakpoint)
8199         (create_longjmp_master_breakpoint)
8200         (create_std_terminate_master_breakpoint)
8201         (create_exception_master_breakpoint): Update.
8202         * blockframe.c (find_pc_partial_function): Update.
8203         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8204         (ada_collect_symbol_completion_matches)
8205         (ada_add_global_exceptions): Update.
8206
8207 2019-01-17  Tom Tromey  <tom@tromey.com>
8208
8209         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8210         declare VEC.
8211         (solib_target_parse_libraries): Change return type.
8212         (library_list_start_segment, library_list_start_section)
8213         (library_list_end_library, library_list_start_library); Update.
8214         (solib_target_free_library_list): Remove.
8215         (solib_target_parse_libraries): Remove cleanup.  Change return
8216         type.
8217         (solib_target_current_sos): Update.
8218
8219 2019-01-17  Tom Tromey  <tromey@bapiya>
8220
8221         * valprint.c: Replace "the the" with "the".
8222         * symtab.c: Replace "the the" with "the".
8223         * solib.c: Replace "the the" with "the".
8224         * solib-dsbt.c: Replace "the the" with "the".
8225         * linespec.c: Replace "the the" with "the".
8226         * dwarf2loc.h: Replace "the the" with "the".
8227         * amd64-windows-tdep.c: Replace "the the" with "the".
8228         * aarch64-tdep.c: Replace "the the" with "the".
8229
8230 2019-01-16  Keith Seitz  <keiths@redhat.com>
8231
8232         PR gdb/23773
8233         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8234         <builder>: Rename to ..
8235         <m_builder>: ... this and make private.
8236         (dwarf2_cu::get_builder): New method.  Change all users of
8237         `builder' to use this method.
8238         (dwarf2_start_symtab): Move to ...
8239         (dwarf2_cu::start_symtab): ... here.  Update all callers
8240         (setup_type_unit_groups): Move to ...
8241         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8242         callers.
8243         (dwarf2_cu::reset_builder): New method.
8244         (process_full_compunit, process_full_type_unit): Use
8245         dwarf2_cu::reset_builder.
8246         (follow_die_offset): Record the ancestor CU if it is different
8247         from the followed DIE's CU.
8248         (follow_die_sig_1): Likewise.
8249
8250 2019-01-15  Tom Tromey  <tom@tromey.com>
8251
8252         * remote.c (class remote_state) <buf>: Now a char_vector.
8253         <buf_size>: Remove.
8254         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8255         parameter.
8256         (remote_target::getpkt_or_notif_sane_1)
8257         (remote_target::getpkt_sane)
8258         (remote_target::getpkt_or_notif_sane): Likewise.
8259         (class remote_target) <putpkt>: New overload.
8260         (remote_target::read_frame): Change type of "buf_p".  Remove
8261         sizeof_p parameter.
8262         (packet_ok): New overload.
8263         (packet_check_result): New overload.
8264         Update all uses.
8265
8266 2019-01-14  Tom Tromey  <tom@tromey.com>
8267
8268         * remote-notif.c (handle_notification, remote_notif_ack)
8269         (remote_notif_parse): Make "buf" const.
8270         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8271         const.
8272         (remote_notif_parse, remote_notif_ack, handle_notification):
8273         Likewise.
8274         * remote.c (remote_notif_stop_parse): Make "buf" const.
8275         (remote_target::remote_parse_stop_reply): Make "buf" const.
8276         (remote_notif_stop_ack): Make "buf" const.
8277
8278 2019-01-14  Tom Tromey  <tom@tromey.com>
8279
8280         * remote.c (remote_console_output): Make parameter const.
8281
8282 2019-01-14  Tom Tromey  <tom@tromey.com>
8283
8284         * target-debug.h (target_debug_print_signals): Constify.
8285         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8286         * procfs.c (procfs_target::pass_signals): Update.
8287         * linux-nat.c (linux_nat_target::pass_signals): Update.
8288         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8289         * target-delegates.c: Rebuild.
8290         * remote.c (remote_target::program_signals): Update.
8291         (remote_target::pass_signals): Update.
8292         * target.c (target_pass_signals): Constify argument.
8293         (target_program_signals): Likewise.
8294         * target.h (struct target_ops) <pass_signals, program_signals>:
8295         Constify argument.
8296         (target_pass_signals, target_program_signals): Constify argument.
8297
8298 2019-01-14  Tom Tromey  <tom@tromey.com>
8299
8300         PR tui/28819:
8301         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8302
8303 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8304
8305         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8306         field.
8307         * rs6000-tdep.c: Include reggroups.h.
8308         (IS_V_ALIAS_PSEUDOREG): Define.
8309         (rs6000_register_name): Return names for the "vX" aliases.
8310         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8311         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8312         aliases.  Call default_register_reggroup_p for all other
8313         pseudo-registers.
8314         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8315         New functions.
8316         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8317         Handle "vX" aliases.
8318         (v_alias_pseudo_register_collect): New function.
8319         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8320         (rs6000_gdbarch_init): Initialize "vX" aliases as
8321         pseudo-registers.  Restore registration of
8322         rs6000_pseudo_register_reggroup_p with
8323         set_tdesc_pseudo_register_reggroup_p.
8324
8325 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8326
8327         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8328         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8329         set_gdbarch_num_pseudo_regs.
8330
8331 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8332
8333         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8334         Remove arg prefixname, add do_set and do_show.
8335         Add member functions set_list and show_list.
8336         * cli/cli-style.c (class cli_style_option): Update accordingly.
8337         (style_set_list): Move to file scope.
8338         (style_show_list): Likewise.
8339         (set_style): Call help_list.
8340         (show_style): Call cmd_show_list.
8341         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8342         Update to use the new macro.
8343
8344 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8345
8346         * ada-lang.c (_initialize_ada_language): Expand the help text
8347         for the "catch exception" command.
8348
8349 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8350
8351         * symtab.c (matching_obj_sections): Initialize obj,
8352         declare it closer to its usage.
8353
8354 2019-01-10  Tom Tromey  <tom@tromey.com>
8355
8356         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8357         (basic_inf_threads_range): Remove.
8358         (inf_threads_range, inf_non_exited_threads_range)
8359         (safe_inf_threads_range): Use next_adapter.
8360
8361 2019-01-10  Keith Seitz  <keiths@redhat.com>
8362
8363         PR gdb/23712
8364         PR symtab/23010
8365         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8366         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8367
8368 2019-01-10  Keith Seitz  <keiths@redhat.com>
8369
8370         PR gdb/23712
8371         PR symtab/23010
8372         * dictionary.c (pending_to_vector): Remove.
8373         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8374         Remove _1 suffix, replacing functions of the same name.  Update
8375         all callers.
8376         (dict_create_hashed, dict_create_hashed_expandable)
8377         (dict_create_linear, dict_create_linear_expandable, dict_free)
8378         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8379         Make functions static.
8380
8381 2019-01-10  Keith Seitz  <keiths@redhat.com>
8382
8383         PR gdb/23712
8384         PR symtab/23010
8385         * dictionary.h (struct dictionary): Replace declaration with
8386         multidictionary.
8387         (dict_create_hashed, dict_create_hashed_expandable)
8388         (dict_create_linear, dict_create_linear_expandable)
8389         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8390         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8391         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8392         taking multidictionary argument.
8393         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8394         * block.h (struct block) <dict>: Change to multidictionary
8395         and rename `multidict'.
8396         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8397         symmisc.c: Update all dictionary references to multidictionary.
8398
8399 2019-01-10  Keith Seitz  <keiths@redhat.com>
8400
8401         PR gdb/23712
8402         PR symtab/23010
8403         * dictionary.c: Include unordered_map.
8404         (pending_to_vector): New function.
8405         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8406         Rewrite the non-"_1" functions to take vector instead
8407         of linked list.
8408         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8409         "new" _1 versions of the same name.
8410         (multidictionary): Define.
8411         (std::hash<enum language): New definition.
8412         (collate_pending_symbols_by_language, mdict_create_hashed)
8413         (mdict_create_hashed_expandable, mdict_create_linear)
8414         (mdict_create_linear_expandable, mdict_free)
8415         (find_language_dictionary, create_new_language_dictionary)
8416         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8417         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8418         (mdict_size, mdict_empty): New functions.
8419         * dictionary.h (mdict_iterator): Define.
8420
8421 2019-01-10  Pedro Alves  <palves@redhat.com>
8422
8423         * breakpoint.c (read_uploaded_action)
8424         (create_tracepoint_from_upload): Adjust to use
8425         gdb::unique_xmalloc_ptr.
8426         * ctf.c (ctf_write_uploaded_tp):
8427         (SET_ARRAY_FIELD): Use emplace_back.
8428         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8429         * tracefile-tfile.c (tfile_write_uploaded_tp):
8430         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8431         gdb::unique_xmalloc_ptr.
8432         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8433         at_string, cond_string, cmd_strings>: Replace char pointers
8434         with gdb::unique_xmalloc_ptr.
8435
8436 2019-01-10  Pedro Alves  <palves@redhat.com>
8437
8438         * solib-target.c (library_list_start_library): Don't xstrdup name.
8439
8440 2019-01-10  Pedro Alves  <palves@redhat.com>
8441
8442         * mdebugread.c (parse_partial_symbols): Use
8443         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8444
8445 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8446
8447         * linux-fork.c (scoped_switch_fork_info)
8448         <~scoped_switch_fork_info>: Fix incorrect variable name.
8449
8450 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8451
8452         * linux-fork.c (scoped_switch_fork_info)
8453         <scoped_switch_fork_info>: Make explicit.
8454         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8455
8456 2019-01-10  Tom Tromey  <tom@tromey.com>
8457
8458         * objfiles.h (objfile::reset_psymtabs): Update.
8459         * objfiles.c (objfile::objfile): Update.
8460         * psymtab.h (psymtab_storage::obstack): Update.
8461         (psymtab_storage::m_obstack): Use gdb::optional.
8462         (class psymtab_storage): Update comment.  Remove objfile
8463         parameter.
8464         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8465
8466 2019-01-10  Tom Tromey  <tom@tromey.com>
8467
8468         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8469         <free_psymtabs>: Now private.
8470         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8471         (allocate_psymtab): Use new method.
8472
8473 2019-01-10  Tom Tromey  <tom@tromey.com>
8474
8475         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8476         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8477         * mdebugread.c (parse_partial_symbols): Use
8478         allocate_dependencies.
8479         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8480         allocate_dependencies.
8481         (process_psymtab_comp_unit_reader)
8482         (build_type_psymtab_dependencies): Likewise.
8483         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8484
8485 2019-01-10  Tom Tromey  <tom@tromey.com>
8486
8487         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8488         PSYMBOL_SET_LANGUAGE.
8489         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8490
8491 2019-01-10  Tom Tromey  <tom@tromey.com>
8492
8493         * psymtab.h (psymtab_storage::obstack): New method.
8494         <m_obstack>: Rename from obstack; now private.
8495         * psymtab.c (psymtab_storage): Update.
8496         * dwarf2read.c (create_addrmap_from_index)
8497         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8498         Update.
8499
8500 2019-01-10  Tom Tromey  <tom@tromey.com>
8501
8502         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8503         * objfiles.h (objfile::reset_psymtabs): New method.
8504
8505 2019-01-10  Tom Tromey  <tom@tromey.com>
8506
8507         * symmisc.c (print_symbol_bcache_statistics): Update.
8508         (print_objfile_statistics): Update.
8509         * symfile.c (reread_symbols): Update.
8510         * psymtab.h (class psymtab_storage): New.
8511         * psymtab.c (psymtab_storage): New constructor.
8512         (~psymtab_storage): New destructor.
8513         (require_partial_symbols): Update.
8514         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8515         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8516         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8517         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8518         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8519         (start_psymtab_common, end_psymtab_common)
8520         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8521         (allocate_psymtab): Update.
8522         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8523         Update.
8524         (dump_psymtab_addrmap, maintenance_print_psymbols)
8525         (maintenance_check_psymtabs): Update.
8526         (class objfile_psymtabs): Move to objfiles.h.
8527         * psympriv.h (discard_psymtab): Now inline.
8528         (psymtab_discarder::psymtab_discarder): Update.
8529         (psymtab_discarder::~psymtab_discarder): Update.
8530         (ALL_OBJFILE_PSYMTABS): Rewrite.
8531         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8532         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8533         Remove fields.
8534         <partial_symtabs>: New field.
8535         (class objfile_psymtabs): Move from psymtab.h.  Update.
8536         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8537         psymbol_cache.
8538         (objfile::~objfile): Don't destroy psymbol_cache.
8539         * mdebugread.c (parse_partial_symbols): Update.
8540         * dwarf2read.c (create_addrmap_from_index)
8541         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8542         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8543         (add_partial_subprogram, dwarf2_ranges_read): Update.
8544         * dwarf-index-write.c (write_address_map)
8545         (write_one_signatured_type, recursively_write_psymbols)
8546         (class debug_names, class debug_names, write_psymtabs_to_index):
8547         Update.
8548
8549 2019-01-10  Tom Tromey  <tom@tromey.com>
8550
8551         * symtab.h (SYMBOL_SET_NAMES): Update.
8552         (symbol_set_names): Update.
8553         (MSYMBOL_SET_NAMES): Update.
8554         * symtab.c (symbol_set_names): Change argument to be an
8555         objfile_per_bfd_storage.
8556         * psymtab.c (add_psymbol_to_bcache): Update.
8557         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8558
8559 2019-01-10  Tom Tromey  <tom@tromey.com>
8560
8561         * symtab.c (create_demangled_names_hash): Change argument to be an
8562         objfile_per_bfd_storage.
8563         (symbol_set_names): Update.
8564
8565 2019-01-10  Tom Tromey  <tom@tromey.com>
8566
8567         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8568         init_psymbol_list.
8569         * psymtab.c (init_psymbol_list): Do nothing if already called.
8570         * psympriv.h (init_psymbol_list): Add comment.
8571         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8572         init_psymbol_list.
8573         * dbxread.c (dbx_symfile_read): Unconditionally call
8574         init_psymbol_list.
8575
8576 2019-01-10  Tom Tromey  <tom@tromey.com>
8577
8578         * xcoffread.c (scan_xcoff_symtab): Update.
8579         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8580         "where".
8581         * mdebugread.c (parse_partial_symbols)
8582         (handle_psymbol_enumerators): Update.
8583         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8584         * dbxread.c (read_dbx_symtab): Update.
8585         * psympriv.h (psymbol_placement): New enum.
8586         (add_psymbol_to_list): Update.
8587
8588 2019-01-10  Tom Tromey  <tom@tromey.com>
8589
8590         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8591         static_psymbols parameters.
8592         (scan_xcoff_symtab): Update.
8593         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8594         static_psymbols parameters.
8595         * psympriv.h (start_psymtab_common): Update.
8596         * mdebugread.c (parse_partial_symbols): Update.
8597         * dwarf2read.c (create_partial_symtab): Update.
8598         * dbxread.c (read_dbx_symtab): Update.
8599         (start_psymtab): Remove global_psymbols and static_psymbols
8600         parameters.
8601
8602 2019-01-10  Tom Tromey  <tom@tromey.com>
8603
8604         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8605         * psymtab.c (allocate_psymtab): Add comment.
8606         * psympriv.h (allocate_psymtab): Add comment.
8607         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8608         initializations.
8609         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8610
8611 2019-01-10  Tom Tromey  <tom@tromey.com>
8612
8613         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8614         Don't declare.
8615         * mipsread.c: Include mdebugread.h.
8616         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8617         Declare.
8618         * elfread.c: Include mdebugread.h.
8619
8620 2019-01-09  Tom Tromey  <tom@tromey.com>
8621
8622         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8623         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8624         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8625         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8626         (psym_lookup_symbol, psym_find_last_source_symtab)
8627         (psym_forget_cached_source_info, psym_print_stats)
8628         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8629         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8630         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8631         (psym_find_compunit_symtab_by_address)
8632         (maintenance_print_psymbols, maintenance_info_psymtabs)
8633         (maintenance_check_psymtabs): Use ranged for.
8634         * psymtab.h (class objfile_psymtabs): New.
8635         (require_partial_symbols): Return objfile_psymtabs.
8636         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8637
8638 2019-01-09  Tom Tromey  <tom@tromey.com>
8639
8640         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8641         (find_pc_mapped_section, list_overlays_command)
8642         (map_overlay_command, unmap_overlay_command)
8643         (simple_overlay_update): Use all_objfiles.
8644         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8645         * printcmd.c (info_symbol_command): Use all_objfiles.
8646         * objfiles.h (ALL_OBJSECTIONS): Remove.
8647         * maint.c (maintenance_translate_address): Use all_objfiles.
8648         * gcore.c (gcore_create_callback): Use all_objfiles.
8649         (objfile_find_memory_regions): Likewise.
8650
8651 2019-01-09  Tom Tromey  <tom@tromey.com>
8652
8653         * symtab.c (find_line_symtab, info_sources_command)
8654         (make_source_files_completion_list): Use objfile_compunits.
8655         * source.c (select_source_symtab): Use objfile_compunits.
8656         * objfiles.h (struct objfile): Update comment.
8657         (ALL_OBJFILES): Remove.
8658         (ALL_FILETABS): Remove.
8659         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8660         objfile_compunits.
8661
8662 2019-01-09  Tom Tromey  <tom@tromey.com>
8663
8664         * symmisc.c (print_objfile_statistics, dump_objfile)
8665         (maintenance_print_symbols): Use compunit_filetabs.
8666         * source.c (forget_cached_source_info_for_objfile): Use
8667         compunit_filetabs.
8668         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8669         (ALL_FILETABS): Use compunit_filetabs.
8670         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8671         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8672
8673 2019-01-09  Tom Tromey  <tom@tromey.com>
8674
8675         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8676         (compunit_filetabs): New.
8677         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8678         compunit_filetabs.
8679         (info_sources_command, make_source_files_completion_list): Remove
8680         declaration.
8681         * symmisc.c (print_objfile_statistics, dump_objfile)
8682         (maintenance_print_symbols): Remove declaration.
8683         (maintenance_info_symtabs): Use compunit_filetabs.
8684         (maintenance_info_line_tables): Likewise.
8685         * source.c (select_source_symtab): Change local variable name.
8686         (forget_cached_source_info_for_objfile): Remove declaration.
8687         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8688         * objfiles.c (objfile_relocate1): Remove declaration.
8689         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8690         declaration.
8691         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8692         * coffread.c (coff_symtab_read): Remove declaration.
8693         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8694         compunit_filetabs.
8695
8696 2019-01-09  Tom Tromey  <tom@tromey.com>
8697
8698         * symtab.c (lookup_objfile_from_block)
8699         (find_pc_sect_compunit_symtab, search_symbols)
8700         (default_collect_symbol_completion_matches_break_on): Use
8701         objfile_compunits.
8702         * objfiles.h (ALL_COMPUNITS): Remove.
8703         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8704         * cp-support.c (add_symbol_overload_list_qualified): Use
8705         objfile_compunits.
8706         * ada-lang.c (ada_collect_symbol_completion_matches)
8707         (ada_add_global_exceptions): Use objfile_compunits.
8708
8709 2019-01-09  Tom Tromey  <tom@tromey.com>
8710
8711         * source.c (select_source_symtab)
8712         (forget_cached_source_info_for_objfile): Remove declaration.
8713         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8714         declaration.
8715         * maint.c (count_symtabs_and_blocks): Remove declaration.
8716         * cp-support.c (add_symbol_overload_list_qualified): Remove
8717         declaration.
8718         * coffread.c (coff_symtab_read): Remove declaration.
8719         * symtab.c (lookup_symbol_in_objfile_symtabs)
8720         (basic_lookup_transparent_type_1): Use objfile_compunits.
8721         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8722         (info_sources_command, search_symbols)
8723         (default_collect_symbol_completion_matches_break_on)
8724         (make_source_files_completion_list): Remove declaration.
8725         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8726         (ada_collect_symbol_completion_matches)
8727         (ada_add_global_exceptions): Remove declaration.
8728         * linespec.c (iterate_over_all_matching_symtabs): Use
8729         objfile_compunits.
8730         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8731         (class objfile_compunits): New.
8732         (ALL_COMPUNITS): Use objfile_compunits.
8733         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8734         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8735         objfile_compunits.
8736         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8737
8738 2019-01-09  Tom Tromey  <tom@tromey.com>
8739
8740         * symtab.c (search_symbols)
8741         (default_collect_symbol_completion_matches_break_on): Use
8742         objfile_msymbols.
8743         * ada-lang.c (ada_lookup_simple_minsym)
8744         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8745         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8746         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8747         objfile_msymbols.
8748         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8749         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8750         * objc-lang.c (find_methods): Use objfile_msymbols.
8751         (info_selectors_command, info_classes_command): Likewise.
8752         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8753         * objfiles.h (class objfile_msymbols): New.
8754         (ALL_OBJFILE_MSYMBOLS): Remove.
8755         (ALL_MSYMBOLS): Remove.
8756
8757 2019-01-09  Tom Tromey  <tom@tromey.com>
8758
8759         * common/next-iterator.h (next_adapter): Add Iterator template
8760         parameter.
8761         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8762         (class all_objfiles_safe): New.
8763         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8764         * objfiles.c (put_objfile_before): Update comment.
8765         (add_separate_debug_objfile): Likewise.
8766         (free_all_objfiles): Use all_objfiles_safe.
8767         (objfile_purge_solibs): Likewise.
8768
8769 2019-01-09  Tom Tromey  <tom@tromey.com>
8770
8771         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8772         (expand_symtab_containing_pc, lookup_static_symbol)
8773         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8774         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8775         all_objfiles.
8776         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8777         * breakpoint.c (create_overlay_event_breakpoint)
8778         (create_longjmp_master_breakpoint)
8779         (create_std_terminate_master_breakpoint)
8780         (create_exception_master_breakpoint): Use all_objfiles.
8781         * linux-thread-db.c (try_thread_db_load_from_pdir)
8782         (has_libpthread): Use all_objfiles.
8783         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8784         * linespec.c (iterate_over_all_matching_symtabs)
8785         (search_minsyms_for_name): Use all_objfiles.
8786         * maint.c (maintenance_info_sections): Use all_objfiles.
8787         * main.c (captured_main_1): Use all_objfiles.
8788         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8789         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8790         * guile/scm-pretty-print.c
8791         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8792         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8793         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8794         (maintenance_print_msymbols): Use all_objfiles.
8795         * source.c (select_source_symtab): Use all_objfiles.
8796         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8797         * symfile.c (remove_symbol_file_command)
8798         (expand_symtabs_matching, map_symbol_filenames): Use
8799         all_objfiles.
8800         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8801         all_objfiles.
8802         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8803         * objc-lang.c (find_methods): Use all_objfiles.
8804         * objfiles.c (have_partial_symbols, have_full_symbols)
8805         (have_minimal_symbols, qsort_cmp)
8806         (default_iterate_over_objfiles_in_search_order): Use
8807         all_objfiles.
8808         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8809         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8810         (maintenance_check_psymtabs): Use all_objfiles.
8811         (ALL_PSYMTABS): Remove.
8812         * compile/compile-object-run.c (do_module_cleanup): Use
8813         all_objfiles.
8814         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8815         * cp-support.c (add_symbol_overload_list_qualified): Use
8816         all_objfiles.
8817         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8818         Use all_objfiles.
8819         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8820         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8821         all_objfiles.
8822         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8823         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8824         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8825         Uses all_objfiles.
8826         * solib.c (solib_read_symbols): Use all_objfiles
8827
8828 2019-01-09  Tom Tromey  <tom@tromey.com>
8829
8830         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8831         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8832         all_objfiles.
8833         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8834         * symmisc.c (print_symbol_bcache_statistics)
8835         (print_objfile_statistics, maintenance_print_objfiles)
8836         (maintenance_info_symtabs, maintenance_check_symtabs)
8837         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8838         all_objfiles.
8839         * source.c (forget_cached_source_info): Use all_objfiles.
8840         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8841         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8842         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8843         * objfiles.c (update_section_map): Use all_objfiles.
8844         (shared_objfile_contains_address_p): Likewise.
8845         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8846         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8847
8848 2019-01-09  Tom Tromey  <tom@tromey.com>
8849
8850         * common/next-iterator.h: New file.
8851         * objfiles.h (class all_objfiles): New.
8852         (struct objfile_iterator): New.
8853
8854 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8855
8856         * NEWS: Move the description of the changed "frame", "select-frame",
8857          and "info frame" commands to the Changed commands section.
8858
8859 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8860
8861         * gdbtypes.c (check_stub_method_group): Remove handling of old
8862         mangling schemes.
8863         * linespec.c (find_methods): Likewise.
8864         * stabsread.c (read_member_functions): Likewise.
8865         * valops.c (search_struct_method): Likewise.
8866         (value_struct_elt_for_reference): Likewise.
8867         * NEWS: Mention this change.
8868
8869 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8870
8871         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8872         print_source_lines.
8873         * source.c (print_source_lines_base): Update line number check.
8874         (print_source_lines): New function.
8875         (source_lines_range::source_lines_range): New function.
8876         * source.h (class source_lines_range): New class.
8877         (print_source_lines): New declaration.
8878
8879 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8880
8881         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8882
8883 2019-01-08  Tom Tromey  <tom@tromey.com>
8884             Simon Marchi  <simon.marchi@ericsson.com>
8885
8886         PR gdb/24060
8887         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8888         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8889         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8890         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8891         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8892         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8893
8894 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8895
8896         * source.c (select_source_symtab): Move header comment to
8897         declaration in source.h.
8898         (forget_cached_source_info_for_objfile): Likewise.
8899         (forget_cached_source_info): Likewise.
8900         (identify_source_line): Likewise.
8901         * source.h (identify_source_line): Move declaration from symtab.h
8902         and add comment from source.c
8903         (print_source_lines): Likewise.
8904         (forget_cached_source_info_for_objfile): Likewise.
8905         (forget_cached_source_info): Likewise.
8906         (select_source_symtab): Likewise.
8907         (enum print_source_lines_flag): Move definition from symtab.h.
8908         * symtab.h (identify_source_line): Move declaration to source.h.
8909         (print_source_lines): Likewise.
8910         (forget_cached_source_info_for_objfile): Likewise.
8911         (forget_cached_source_info): Likewise.
8912         (select_source_symtab): Likewise.
8913         (enum print_source_lines_flag): Move definition to source.h.
8914         * tui/tui-hooks.c: Add 'source.h' include.
8915
8916 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8917
8918         * source.c (print_source_lines_base): Handle requests to print
8919         reverse line number sequences, and guard against empty lines
8920         string.
8921
8922 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8923
8924         * source.c (print_source_lines_base): Fix skip of '\r' if next
8925         character is '\n'.
8926
8927 2019-01-06  Tom Tromey  <tom@tromey.com>
8928
8929         * c-exp.y (struct c_parse_state) <macro_original_text,
8930         expansion_obstack>: New member.
8931         (macro_original_text, expansion_obstack): Remove globals.
8932         (scan_macro_expansion, scanning_macro_expansion)
8933         (finished_macro_expansion): Update.
8934         (scan_macro_cleanup): Remove.
8935         (yylex, c_parse): Update.
8936
8937 2019-01-06  Tom Tromey  <tom@tromey.com>
8938
8939         * c-exp.y (struct c_parse_state) <strings>: New member.
8940         (operator_stoken): Update.
8941
8942 2019-01-06  Tom Tromey  <tom@tromey.com>
8943
8944         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8945         (union type_stack_elt) <typelist_val>: Now a pointer to
8946         std::vector.
8947         (type_stack_cleanup): Don't declare.
8948         (push_typelist): Update.
8949         * parse.c (pop_typelist): Return a std::vector.
8950         (push_typelist): Take a std::vector.
8951         (follow_types): Update.  Do not free args.
8952         (type_stack_cleanup): Remove.
8953         * c-exp.y (struct c_parse_state): New.
8954         (cpstate): New global.
8955         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8956         (nonempty_typelist): Update.
8957         (func_mod): Create a new vector.
8958         (c_parse): Create a c_parse_state.
8959         (check_parameter_typelist): Do not delete params.
8960         (function_method): Update.  Do not delete type_list.
8961
8962 2019-01-06  Tom Tromey  <tom@tromey.com>
8963
8964         PR gdb/28155:
8965         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8966         check_typedef.
8967         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8968         (print_return_value): Likewise.
8969
8970 2019-01-05  Tom Tromey  <tom@tromey.com>
8971
8972         * contrib/cleanup_check.py: Remove.
8973         * contrib/gcc-with-excheck: Remove.
8974         * contrib/exsummary.py: Remove.
8975         * contrib/excheck.py: Remove.
8976
8977 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8978
8979         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8980         NULL. Initialize tpprev to NULL instead of assigning it
8981         to NULL on the next statement.
8982         * windows-nat.c (windows_delete_thread): Remove check for
8983         main_thread_id before printing thread exit notifications.
8984         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8985         Remove thread ID check against main_thread_id.
8986         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8987         windows_delete_thread.
8988         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8989
8990 2019-01-04  Tom Tromey  <tom@tromey.com>
8991
8992         * compile/compile.c (_initialize_compile): Use upper case for
8993         metasyntactic variables.
8994         * symmisc.c (_initialize_symmisc): Use upper case for
8995         metasyntactic variables.
8996         * psymtab.c (_initialize_psymtab): Use upper case for
8997         metasyntactic variables.
8998         * demangle.c (demangle_command): Use upper case for metasyntactic
8999         variables.
9000         (_initialize_demangler): Likewise.
9001         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9002         variables.
9003
9004 2019-01-03  Tom Tromey  <tom@tromey.com>
9005
9006         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9007
9008 2019-01-03  Tom Tromey  <tom@tromey.com>
9009
9010         * python/py-symtab.c (salpy_str): Update.
9011         (struct salpy_sal_object) <symtab>: Now a PyObject.
9012         (salpy_dealloc): Update.
9013         (del_objfile_sal): Use gdbpy_ref.
9014
9015 2019-01-03  Tom Tromey  <tom@tromey.com>
9016
9017         * python/py-type.c (convert_field): Use new_reference.  Return
9018         gdbpy_ref.
9019         (make_fielditem): Return gdbpy_ref.
9020         (typy_fields): Update.
9021         (typy_getitem): Update.
9022         (field_name): Return gdbpy_ref.  Use new_reference.
9023         (typy_iterator_iternext): Update.
9024
9025 2019-01-03  Tom Tromey  <tom@tromey.com>
9026
9027         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9028
9029 2019-01-03  Tom Tromey  <tom@tromey.com>
9030
9031         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9032         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9033         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9034         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9035         (pspy_set_type_printers): Likewise.
9036         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9037         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9038         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9039         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9040         (objfpy_set_type_printers): Likewise.
9041
9042 2019-01-03  Tom Tromey  <tom@tromey.com>
9043
9044         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9045         (gdbpy_print_stack): Use gdbpy_err_fetch.
9046         * python/python-internal.h (class gdbpy_err_fetch): New class.
9047         (class gdbpy_enter) <m_error_type, m_error_value,
9048         m_error_traceback>: Remove.
9049         <m_error>: New member.
9050         (gdbpy_exception_to_string): Don't declare.
9051         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9052         * python/py-value.c (convert_value_from_python): Use
9053         gdbpy_err_fetch.
9054         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9055         gdbpy_exception_to_string.
9056         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9057         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9058         gdbpy_err_fetch.
9059
9060 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9061
9062         * linux-nat.c (delete_lwp_cleanup): Delete.
9063         (struct lwp_deleter): New struct.
9064         (lwp_info_up): New typedef.
9065         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9066         lwp_info_up.
9067
9068 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9069
9070         * linux-fork.c (class scoped_switch_fork_info): New class.
9071         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9072
9073 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9074
9075         * valops.c (find_overload_match): Remove use of null_cleanup, and
9076         calls to do_cleanups.
9077
9078 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9079
9080         * compile/compile-cplus-types.c
9081         (compile_cplus_instance::decl_name): Handle changes to
9082         cp_func_name.
9083         * cp-support.c (cp_func_name): Update header comment, update
9084         return type.
9085         * cp-support.h (cp_func_name): Update return type in declaration.
9086         * valops.c (find_overload_match): Move temp_func local to top
9087         level of function and change its type.  Use temp_func to hold and
9088         delete temporary string obtained from cp_func_name.
9089
9090 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9091
9092         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9093         gdb::char_vector, remove cleanup, and update uses of `msg`.
9094
9095 2019-01-03  Jim Wilson  <jimw@sifive.com>
9096
9097         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9098
9099 2019-01-02  Tom Tromey  <tom@tromey.com>
9100
9101         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9102         (tdesc_parse_xml): Remove cleanups.
9103         * target-descriptions.h (make_cleanup_free_target_description):
9104         Don't declare.
9105         (target_desc_deleter): New struct.
9106         (target_desc_up): New typedef.
9107         * target-descriptions.c (target_desc_deleter::operator()): Rename
9108         from free_target_description.
9109         (make_cleanup_free_target_description): Remove.
9110
9111 2019-01-02  Tom Tromey  <tom@tromey.com>
9112
9113         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9114         constructor, destructor.
9115         (linespec_parser): Remove typedef.
9116         (~linespec_parser): Rename from linespec_parser_delete.
9117         (linespec_lex_to_end, linespec_complete_label)
9118         (linespec_complete): Update.
9119         (decode_line_full): Remove cleanups.
9120         (decode_line_1): Update.
9121
9122 2019-01-02  Tom Tromey  <tom@tromey.com>
9123
9124         * python/python-internal.h (inferior_to_inferior_object): Change
9125         return type.
9126         * python/py-exitedevent.c (create_exited_event_object): Update.
9127         * python/py-inferior.c (inferior_to_inferior_object): Return
9128         gdbpy_ref.
9129         (python_new_inferior, python_inferior_deleted)
9130         (thread_to_thread_object, delete_thread_object)
9131         (build_inferior_list, gdbpy_selected_inferior): Update.
9132         * python/py-infthread.c (create_thread_object): Update.  Also fail
9133         if inferior_to_inferior_object fails.
9134
9135 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9136
9137         * inferior.h (class inferior) <displaced_step_state>: New field.
9138         * infrun.h (struct displaced_step_state): Move here from
9139         infrun.c.  Initialize fields, add constructor.
9140         <inf>: Remove field.
9141         <reset>: New method.
9142         * infrun.c (struct displaced_step_inferior_state): Move to
9143         infrun.h.
9144         (displaced_step_inferior_states): Remove.
9145         (get_displaced_stepping_state): Adust.
9146         (displaced_step_in_progress_any_inferior): Adjust.
9147         (displaced_step_in_progress_thread): Adjust.
9148         (displaced_step_in_progress): Adjust.
9149         (add_displaced_stepping_state): Remove.
9150         (get_displaced_step_closure_by_addr): Adjust.
9151         (remove_displaced_stepping_state): Remove.
9152         (infrun_inferior_exit): Call displaced_step_state.reset.
9153         (use_displaced_stepping): Don't check for NULL.
9154         (displaced_step_prepare_throw): Call
9155         get_displaced_stepping_state.
9156         (displaced_step_fixup): Don't check for NULL.
9157         (prepare_for_detach): Don't check for NULL.
9158
9159 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9160
9161         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9162          in case of call that did not complete.
9163
9164 2019-01-02  Andrey Utkin  <autkin@undo.io>
9165
9166         * symfile.c (find_separate_debug_file): Fix search of debug files for
9167         remote debuggee.
9168
9169 2019-01-02  Tom Tromey  <tom@tromey.com>
9170
9171         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9172         indentation.
9173         * python/py-frame.c (frapy_older): Remove cast.
9174         (frapy_newer): Likewise.
9175         * python/py-breakpoint.c (local_setattro): Remove cast.
9176         * python/py-arch.c (archpy_name): Remove local variable.
9177         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9178
9179 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9180
9181         * unittests/basic_string_view/element_access/char/empty.cc:
9182         Fix year range in copyright header.
9183
9184 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9185
9186         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9187         Delete.
9188         <operator==>: Update with for removed field.
9189         <hash>: Likewise.
9190         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9191         <isa_features>: ...this.
9192         <abi_features>: New field.
9193         (riscv_isa_flen): Update comment.
9194         (riscv_abi_xlen): New declaration.
9195         (riscv_abi_flen): New declaration.
9196         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9197         isa_features.
9198         (riscv_abi_xlen): New function.
9199         (riscv_isa_flen): Update to get answer from isa_features.
9200         (riscv_abi_flen): New function.
9201         (riscv_has_fp_abi): Update to get answer from abi_features.
9202         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9203         xlen and flen.
9204         (riscv_call_info) <xlen, flen>: Update comment.
9205         (riscv_call_arg_struct): Remove invalid assertions
9206         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9207         is removed.
9208         (riscv_gdbarch_init): Gather isa features and abi features
9209         separately, ensure both match on the gdbarch when reusing an old
9210         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9211         a target with 64-bit float hardware.
9212
9213 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9214
9215         * source.c (search_command_helper): Stop reverse search
9216         when line 1 has been searched.
9217
9218 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9219
9220         * record-full.c (record_full_base_target::close): Rewrite
9221         record_full_core_buf_list free logic.
9222
9223 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9224
9225         * break-catch-syscall.c (print_one_catch_syscall): xfree
9226         the last text.
9227
9228 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9229
9230         * top.c (print_gdb_version): Update Copyright year in version
9231         message.
9232
9233 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9234
9235         Update copyright year range in all GDB files.
9236
9237 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9238
9239         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9240
9241 For older changes see ChangeLog-2018.
9242 \f
9243 Local Variables:
9244 mode: change-log
9245 left-margin: 8
9246 fill-column: 74
9247 version-control: never
9248 coding: utf-8
9249 End:
9250