gdb/ChangeLog

   1 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * symtab.c (lookup_static_symbol): Call the new function (and move
   4         it down to be next to lookup_global_symbol).
   5         (struct global_sym_lookup_data): Add block_enum member and rename to...
   6         (struct global_or_static_sym_lookup_data): ...this.
   7         (lookup_symbol_global_iterator_cb): Pass block_index instead of
   8         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
   9         (lookup_symbol_global_or_static_iterator_cb): ...this.
  10         (lookup_global_or_static_symbol): New function.
  11         (lookup_global_symbol): Call new function.
  12
  13 2019-08-26  Tom de Vries  <tdevries@suse.de>
  14
  15         PR c++/24852
  16         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
  17         when pc_probe.prob == NULL.
  18
  19 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
  20
  21         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
  22         variable symbol_linkage to symbol_linkage_.
  23
  24 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
  25
  26         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
  27         represent whether the symbol is static, dynamic, or we don't
  28         know.
  29
  30 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
  31
  32         * gdb/rx-tdep.c (rx_register_names): New.
  33         (rx_register_name): Delete.
  34         (rx_psw_type): Delete.
  35         (rx_fpsw_type): Delete.
  36         (rx_register_type): Delete.
  37         (rx_gdbarch_init): Convert target-descriptions.
  38         (_initialize_rx_tdep): Add initialize_tdesc_rx.
  39         * gdb/features/Makefile: Add rx.xml.
  40         * gdb/features/rx.xml: New.
  41         * gdb/features/rx.c: Generated.
  42         * gdb/NEWS: Mention target description support.
  43
  44 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
  45
  46         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
  47         *slot_ptr.
  48
  49 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  50
  51         * configure.ac: Don't check for 'dlfcn.h' (moved to
  52         gdbsupport/common.m4).
  53         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
  54         'gdbsupport/'.
  55         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
  56         * compile/compile-c-support.c: Include
  57         'gdbsupport/gdb-dlfcn.h'.
  58         * gdbsupport/common.m4: Check for 'dlfcn.h'.
  59         * gdb-dlfcn.c: Move to...
  60         * gdbsupport/gdb-dlfcn.c: ... here.
  61         * gdb-dlfcn.h: Move to...
  62         * gdbsupport/gdb-dlfcn.h: ... here.
  63
  64 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
  65
  66         * nios2-tdep.c (struct reg_value): Improve comments.  Make
  67         the offset field signed.
  68
  69 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
  70
  71         * python/lib/gdb/__init__.py (_execute_file): New function.
  72         * python/python.c (python_run_simple_file): Call gdb._execute_file
  73         on Windows.
  74
  75 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  76
  77         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
  78         all uses as this was never set to anything but a zero value.
  79
  80 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
  81
  82         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
  83
  84 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
  85
  86         * tui/tui-data.h (tui_gen_win_info): Add an =default
  87         move constructor, required by some GCC versions.
  88
  89 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
  90
  91         * go32-nat.c (go32_sysinfo): Add hygon_p.
  92
  93 2019-08-20  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
  96         line_from_reg_element_no, first_reg_element_no_inline,
  97         display_all_data, delete_data_content_windows,
  98         erase_data_content>: Now private.
  99
 100 2019-08-20  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 103         (tui_unhighlight_win, tui_highlight_win)
 104         (tui_win_info::make_window): Update.
 105         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 106
 107 2019-08-20  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 110         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 111         (MAX_PID_WIDTH): Move to tui-stack.c.
 112         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 113         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 114         (MAX_PID_WIDTH): Move from tui-data.h.
 115
 116 2019-08-20  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 119         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 120         (box_win): Update.
 121         (tui_gen_win_info::make_window): Rename from tui_make_window.
 122         (tui_win_info::make_window): New method.
 123         (tui_gen_win_info::make_visible): Update.
 124         * tui/tui-source.c (tui_source_window::set_contents): Update.
 125         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 126         (tui_data_window::display_registers_from): Update.
 127         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 128         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 129         Declare.
 130         <can_box>: Remove.
 131         <title>: Remove.
 132         (struct tui_win_info) <make_window>: Declare.
 133         <can_box>: Now virtual.
 134         <title>: New member.
 135         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 136         * tui/tui-command.c (tui_cmd_window::resize): Update.
 137
 138 2019-08-20  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 141         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 142         (tui_data_window::check_register_values): Update.
 143
 144 2019-08-20  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-regs.h (struct tui_data_window): Use
 147         DISABLE_COPY_AND_ASSIGN.
 148         <regs_content>: Change type, removing unique_ptr.
 149         <tui_data_window>: Add move constructor.
 150         * tui/tui-regs.c (tui_data_window::show_registers)
 151         (tui_data_window::show_register_group)
 152         (tui_data_window::display_registers_from)
 153         (tui_data_window::display_registers_from)
 154         (tui_data_window::first_data_item_displayed)
 155         (tui_data_window::delete_data_content_windows)
 156         (tui_data_window::rerender, tui_data_window::refresh_window)
 157         (tui_data_window::check_register_values): Update.
 158
 159 2019-08-20  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 162         show_register_group>: Declare.
 163         (tui_show_register_group): Don't declare.
 164         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 165         tui_show_registers.
 166         (tui_data_window::show_register_group): Rename from
 167         tui_show_register_group.
 168         (tui_data_window::check_register_values, tui_reg_command):
 169         Update.
 170         * tui/tui-layout.c (tui_set_layout): Update.
 171
 172 2019-08-20  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 175         Declare.
 176         (tui_check_register_values): Don't declare.
 177         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 178         from tui_check_register_values.
 179         * tui/tui-hooks.c (tui_register_changed): Update.
 180
 181 2019-08-20  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-regs.c (tui_reg_layout): Move later.
 184         (tui_show_registers): Don't enable TUI mode or change layout.
 185
 186 2019-08-20  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-regs.h (struct tui_data_item_window)
 189         <~tui_data_item_window>: Remove.
 190         <content>: Now a unique_xmalloc_ptr.
 191         * tui/tui-regs.c (tui_register_format): Return a
 192         unique_xmalloc_ptr.
 193         (tui_get_register): Update.
 194         (~tui_data_item_window): Remove.
 195         (tui_data_window::display_registers_from, tui_display_register):
 196         Update.
 197         * tui/tui-io.h (tui_expand_tabs): Update.
 198         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 199         Remove "col" parameter.
 200
 201 2019-08-20  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 204         field.
 205         * tui/tui-regs.c (~tui_data_item_window): Update.
 206
 207 2019-08-20  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 210         earlier.
 211
 212 2019-08-20  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 215
 216 2019-08-20  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui-source.h (struct tui_source_window): Update.
 219         * tui/tui-regs.c (tui_show_registers): Update.
 220         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 221         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 222         (NO_REGS_STRING): Remove defines.
 223
 224 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 225
 226         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 227         unnecessary thread walk if remote doesn't support the packet.
 228
 229 2019-08-19  Tom Tromey  <tromey@adacore.com>
 230
 231         * python/py-value.c (value_has_field): Fix indentation.
 232
 233 2019-08-19  Tom Tromey  <tromey@adacore.com>
 234
 235         * printcmd.c (do_one_display, info_display_command): Update.
 236         * block.h (contained_in): Return bool.  Add allow_nested
 237         parameter.
 238         * block.c (contained_in): Return bool.  Add allow_nested
 239         parameter.
 240
 241 2019-08-19  Tom Tromey  <tom@tromey.com>
 242
 243         * configure: Rebuild.
 244         * configure.ac: Disallow the combination of -static-libstdc++ and
 245         source highlight.
 246         * source-cache.c (get_language_name): Handle rust.
 247         (source_cache::get_source_lines): Ignore highlighting exceptions.
 248
 249 2019-08-16  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 252         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 253         (struct tui_source_window_base) <make_visible, refresh_window,
 254         resize>: Remove methods.
 255         <execution_info>: Remove field.
 256         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 257         (tui_show_source_line, tui_source_window_base)
 258         (~tui_source_window_base): Update.
 259         (tui_source_window_base::resize)
 260         (tui_source_window_base::make_visible)
 261         (tui_source_window_base::refresh_window): Remove.
 262         (tui_source_window_base::update_exec_info): Update.
 263         * tui/tui-source.c (tui_source_window::set_contents): Update.
 264         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 265
 266 2019-08-16  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 269         deprecated_query_hook.
 270
 271 2019-08-16  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 274         (tui_update_source_windows_with_line): Update.
 275         * tui/tui-source.h (struct tui_source_window)
 276         <show_symtab_source>: Declare.
 277         (tui_show_symtab_source): Don't declare.
 278         * tui/tui-source.c (tui_show_symtab_source): Rename from
 279         tui_show_symtab_source.
 280
 281 2019-08-16  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-winsource.h (struct tui_source_window_base)
 284         <set_contents>: Declare.
 285         * tui/tui-winsource.c
 286         (tui_source_window_base::update_source_window_as_is): Update.
 287         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 288         Declare.
 289         (tui_set_source_content): Don't declare.
 290         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 291         tui_set_source_content.
 292         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 293         Declare.
 294         (tui_set_disassem_content): Don't declare.
 295         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 296         tui_set_disassem_content.
 297
 298 2019-08-16  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-winsource.h (struct tui_source_window_base)
 301         <update_breakpoint_info>: Declare.
 302         (tui_update_breakpoint_info): Don't declare.
 303         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 304         (tui_update_all_breakpoint_info): Update.
 305         (tui_source_window_base::update_breakpoint_info): Rename from
 306         tui_update_breakpoint_info.
 307         (tui_source_window_base::update_exec_info): Update.
 308
 309 2019-08-16  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-winsource.h (struct tui_source_window_base)
 312         <update_source_window>: Declare.
 313         (tui_update_source_window): Don't declare.
 314         * tui/tui-winsource.c
 315         (tui_source_window_base::update_source_window): Rename from
 316         tui_update_source_window.
 317         (tui_source_window_base::rerender): Update.
 318         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 319         * tui/tui-disasm.c (tui_show_disassem)
 320         (tui_show_disassem_and_update_source)
 321         (tui_disasm_window::maybe_update): Update.
 322
 323 2019-08-16  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-winsource.h (struct tui_source_window_base)
 326         <update_source_window_as_is>: Declare.
 327         (tui_update_source_window_as_is): Don't declare.
 328         * tui/tui-winsource.c (tui_update_source_window): Update
 329         (tui_source_window_base::update_source_window_as_is): Rename from
 330         tui_update_source_window_as_is.
 331         (tui_source_window_base::refill): Update.
 332         * tui/tui-source.c (tui_show_symtab_source): Update.
 333         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 334         Update.
 335
 336 2019-08-16  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-winsource.h (tui_update_source_window)
 339         (tui_update_source_window_as_is): Remove "noerror" parameter.
 340         * tui/tui-winsource.c (tui_update_source_window)
 341         (tui_update_source_window_as_is): Remove "noerror" parameter.
 342         (tui_update_source_windows_with_addr)
 343         (tui_update_source_windows_with_line)
 344         (tui_source_window_base::rerender)
 345         (tui_source_window_base::refill): Update.
 346         * tui/tui-source.h (tui_set_source_content)
 347         (tui_show_symtab_source): Remove "noerror" parameter.
 348         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 349         parameter.
 350         (tui_show_symtab_source): Likewise.
 351         (tui_source_window::maybe_update): Update.
 352         * tui/tui-disasm.c (tui_show_disassem)
 353         (tui_show_disassem_and_update_source)
 354         (tui_disasm_window::do_scroll_vertical)
 355         (tui_disasm_window::maybe_update): Update.
 356
 357 2019-08-16  Tom Tromey  <tom@tromey.com>
 358
 359         * tui/tui.c (tui_is_window_visible): Update.
 360         * tui/tui-wingeneral.c (tui_make_window)
 361         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 362         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 363         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 364         (tui_set_win_height_command, parse_scrolling_args): Update.
 365         * tui/tui-source.c (tui_source_window::style_changed): Update.
 366         * tui/tui-regs.c (tui_show_registers)
 367         (tui_data_window::first_data_item_displayed)
 368         (tui_data_window::delete_data_content_windows)
 369         (tui_check_register_values, tui_reg_command): Update.
 370         * tui/tui-disasm.c (tui_show_disassem): Update.
 371         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 372         method.
 373         <is_visible>: Remove field.
 374         * tui/tui-data.c (tui_next_win, tui_prev_win)
 375         (tui_delete_invisible_windows): Update.
 376
 377 2019-08-16  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-winsource.h (struct tui_source_window_base)
 380         <m_has_locator>: Remove.
 381         * tui/tui-layout.c (show_source_disasm_command, show_data)
 382         (show_source_or_disasm_and_command): Update.
 383
 384 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 385
 386         * NEWS (Other MI changes): New subsection.
 387         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 388         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 389         * arch-utils.c (default_get_pc_address_flags): New function.
 390         * arch-utils.h (default_get_pc_address_flags): New declaration.
 391         * gdbarch.sh: Add get_pc_address_flags.
 392         * gdbarch.c: Regenerate.
 393         * gdbarch.h: Likewise.
 394         * stack.c (print_pc): New function.
 395         (print_frame_info) (print_frame): Call print_pc.
 396
 397 2019-08-16  Tom de Vries  <tdevries@suse.de>
 398
 399         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 400         print_objfile_section_info.
 401
 402 2019-08-15  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 405         calling update_cmdwin_start_line.
 406         * tui/tui-winsource.h (struct tui_source_window_base)
 407         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 408         <rerender>: Declare.
 409         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 410         Call rerender.
 411         (tui_source_window_base::set_new_height): Remove.
 412         (tui_source_window_base::rerender): Rename from
 413         do_make_visible_with_new_height.
 414         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 415         resize method.
 416         (tui_win_info::make_invisible_and_set_new_height)
 417         (tui_win_info::make_visible_with_new_height): Remove.
 418         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 419         Declare.
 420         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 421         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 422         do_make_visible_with_new_height>: Don't declare.
 423         <rerender>: Declare.
 424         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 425         set_new_height.
 426         (tui_data_window::do_make_visible_with_new_height): Remove.
 427         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 428         call tui_show_locator_content.
 429         (tui_gen_win_info::resize): Call rerender.
 430         (show_source_or_disasm_and_command): Don't call
 431         tui_show_locator_content.
 432         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 433         method.
 434         (struct tui_win_info) <rerender>: Declare.
 435         <set_new_height, make_invisible_and_set_new_height,
 436         make_visible_with_new_height>: Don't declare.
 437         * tui/tui-data.c (tui_win_list::rerender): New method.
 438         * tui/tui-command.h (struct tui_cmd_window)
 439         <do_make_visible_with_new_height>: Don't declare.
 440         * tui/tui-command.c
 441         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 442
 443 2019-08-15  Tom Tromey  <tromey@adacore.com>
 444
 445         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 446         * ada-lang.c (ada_enum_name): Likewise.
 447
 448 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 449
 450         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 451         leading underscore.
 452         (GdbOutputErrorFile): Likewise.
 453         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 454         accordingly.
 455         (execute_unwinders): Rename to have a leading underscore.
 456         (auto_load_packages): Likewise.
 457         (global scope): Adjust call to auto_load_packages accordingly.
 458         (GdbSetPythonDirectory): Likewise.
 459         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 460         instead of execute_unwinders.
 461
 462 2019-08-15  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 465         (show_data): Don't change window visibility.
 466         (tui_gen_win_info::resize): Remove special case for command
 467         window.  Use wresize, when available.
 468         (show_source_or_disasm_and_command): Don't change window
 469         visibility.
 470         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 471         <make_visible>: New method.
 472         * tui/tui-command.c (tui_cmd_window::resize): New method.
 473
 474 2019-08-15  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 477         (struct tui_source_windows): New.
 478         * tui/tui-winsource.c (tui_display_main): Update.
 479         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 480         (new_height_ok, parse_scrolling_args): Update.
 481         * tui/tui-layout.c (show_layout, show_data): Update.
 482         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 483         (tui_add_to_source_windows): Don't declare.
 484         * tui/tui-data.c (source_windows, tui_source_windows)
 485         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 486
 487 2019-08-15  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 490         Rename from reset.
 491         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 492         * tui/tui-layout.c (show_source_disasm_command, show_data):
 493         Update.
 494         (tui_gen_win_info::resize): Rename.
 495         (show_source_or_disasm_and_command): Update.
 496         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 497         reset.
 498
 499 2019-08-15  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 502         * tui/tui-interp.c (tui_interp::init): Don't call
 503         tui_initialize_static_data.
 504         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 505
 506 2019-08-15  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 509         examine tui_win_list.
 510
 511 2019-08-15  Tom Tromey  <tom@tromey.com>
 512
 513         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 514         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 515         tui_clear_source_content.
 516         (tui_clear_source_content): Remove.
 517         (tui_source_window_base::do_erase_source_content): Hoist call to
 518         content.clear().
 519         * tui/tui-stack.c (tui_show_frame_info): Don't call
 520         tui_clear_source_content.
 521
 522 2019-08-15  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-winsource.h (struct tui_source_window_base)
 525         <do_erase_source_content>: New method.
 526         <erase_source_content>: New method.
 527         (tui_erase_source_content): Don't declare.
 528         * tui/tui-winsource.c (tui_clear_source_content): Update.
 529         (tui_source_window_base::do_erase_source_content): Rename from
 530         tui_erase_source_content.
 531         (tui_source_window_base::show_source_content): Update.
 532         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 533         * tui/tui-source.h (struct tui_source_window)
 534         <erase_source_content>: New method.
 535         * tui/tui-disasm.h (struct tui_disasm_window)
 536         <erase_source_content>: New method.
 537
 538 2019-08-15  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 541         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 542         constructor.
 543         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 544         * tui/tui-source.c (tui_set_source_content): Update.
 545         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 546
 547 2019-08-15  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 550         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 551         tui-source.c.
 552         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 553         Declare.
 554         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 555         method.
 556         (tui_source_window::maybe_update): Update.
 557
 558 2019-08-15  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 561         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 562         tui-disasm.c.
 563         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 564         Declare.
 565         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 566         method.
 567         (tui_disasm_window::maybe_update): Update.
 568
 569 2019-08-15  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-winsource.h (struct tui_source_window_base)
 572         <maybe_update>: Declare.
 573         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 574         method.
 575         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 576         Declare.
 577         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 578         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 579         Declare.
 580         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 581
 582 2019-08-15  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 585
 586 2019-08-15  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-wingeneral.c: Include tui-stack.h.
 589         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 590         (struct tui_locator_window): Move from tui-data.h.
 591         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 592         (tui_initialize_static_data): Move from tui-data.c.
 593         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 594         (struct tui_locator_window): Move to tui-stack.c.
 595         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 596         (tui_initialize_static_data): Move to tui-stack.c.
 597
 598 2019-08-15  Tom Tromey  <tom@tromey.com>
 599
 600         * tui/tui-layout.c (show_source_disasm_command)
 601         (show_source_or_disasm_and_command): Use make_visible method, not
 602         tui_make_window.
 603         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 604         Remove.
 605
 606 2019-08-15  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-wingeneral.h (tui_make_window): Update.
 609         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 610         parameter.
 611         (tui_gen_win_info::make_visible): Update.
 612         * tui/tui-regs.c (tui_data_window::display_registers_from):
 613         Update.
 614         * tui/tui-layout.c (show_source_disasm_command)
 615         (show_source_or_disasm_and_command): Update.
 616         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 617         (enum tui_box): Remove.
 618         (struct tui_win_info) <can_box>: New method.
 619         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 620         method.
 621
 622 2019-08-15  Tom de Vries  <tdevries@suse.de>
 623
 624         * linux-nat-trad.c: Include gdbarch.h.
 625
 626 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 627
 628         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 629         register sizes.
 630
 631 2019-08-14  Tom Tromey  <tromey@adacore.com>
 632
 633         * darwin-nat.c: Include gdbarch.h.
 634         * darwin-nat-info.c: Include gdbarch.h.
 635
 636 2019-08-13  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 639         Remove.
 640         * tui/tui-data.c (tui_initialize_static_data): Update.
 641
 642 2019-08-13  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-winsource.h (struct tui_exec_info_window)
 645         <~tui_exec_info_window, maybe_allocate_content, get_content,
 646         m_content>: Remove.
 647         (struct tui_source_window_base) <set_exec_info_content,
 648         show_exec_info_content>: Don't declare.
 649         * tui/tui-winsource.c
 650         (tui_exec_info_window::maybe_allocate_content): Remove.
 651         (tui_source_window_base::update_exec_info): Rename from
 652         set_exec_info_content.
 653         (tui_source_window_base::show_exec_info_content)
 654         (tui_source_window_base::update_exec_info): Remove.
 655
 656 2019-08-13  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 659         declare.
 660         * tui/tui-winsource.c (tui_update_source_window_as_is)
 661         (tui_update_source_windows_with_addr, tui_erase_source_content):
 662         Update.
 663         (tui_clear_exec_info_content): Remove.
 664
 665 2019-08-13  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 668         declare.
 669         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 670         call tui_erase_exec_info_content.
 671         (tui_clear_exec_info_content): Rename from
 672         tui_erase_exec_info_content.
 673         (tui_clear_exec_info_content): Delete.
 674
 675 2019-08-13  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-winsource.h (struct tui_source_window_base)
 678         <show_exec_info_content>: Declare.
 679         (tui_show_exec_info_content): Don't declare.
 680         * tui/tui-winsource.c
 681         (tui_source_window_base::show_exec_info_content): Rename from
 682         tui_show_exec_info_content.
 683         (tui_source_window_base::update_exec_info): Update.
 684
 685 2019-08-13  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 688         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 689         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 690         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 691         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 692         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 693         ... here.
 694
 695 2019-08-13  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-winsource.h (struct tui_source_window_base)
 698         <update_exec_info>: Declare.
 699         (tui_update_exec_info): Don't declare.
 700         * tui/tui-winsource.c (tui_update_source_window_as_is)
 701         (tui_source_window_base::refresh_all)
 702         (tui_update_all_breakpoint_info): Update.
 703         (tui_source_window_base::update_exec_info): Rename from
 704         tui_update_exec_info.
 705         * tui/tui-stack.c (tui_show_frame_info): Update.
 706
 707 2019-08-13  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-winsource.h (struct tui_source_window_base)
 710         <set_exec_info_content>: Declare.
 711         (tui_set_exec_info_content): Don't declare.
 712         * tui/tui-winsource.c
 713         (tui_source_window_base::set_exec_info_content): Rename from
 714         tui_set_exec_info_content.
 715         (tui_update_exec_info): Update.
 716
 717 2019-08-13  Tom Tromey  <tom@tromey.com>
 718
 719         * tui/tui-winsource.h (struct tui_source_window_base)
 720         <show_source_content>: Declare.
 721         (tui_show_source_content): Don't declare.
 722         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 723         (tui_source_window_base::show_source_content): Rename from
 724         tui_show_source_content.
 725         (tui_source_window_base::refresh_all): Update.
 726         * tui/tui-layout.c (show_source_disasm_command)
 727         (show_source_or_disasm_and_command): Update.
 728
 729 2019-08-13  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-winsource.c (tui_erase_source_content)
 732         (tui_show_source_content, tui_source_window_base::refresh_all):
 733         Update.
 734         * tui/tui-wingeneral.h
 735         (tui_check_and_display_highlight_if_needed): Don't declare.
 736         * tui/tui-wingeneral.c
 737         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 738         check_and_display_highlight_if_needed.
 739         * tui/tui-win.c (tui_rehighlight_all)
 740         (tui_win_info::make_visible_with_new_height): Update.
 741         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 742         (tui_data_window::erase_data_content)
 743         (tui_data_window::display_all_data): Update.
 744         * tui/tui-data.h (struct tui_win_info)
 745         <check_and_display_highlight_if_needed>: Declare.
 746
 747 2019-08-13  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-win.c (tui_resize_all): Call
 750         tui_delete_invisible_windows.
 751         * tui/tui-layout.c (show_layout): Call
 752         tui_delete_invisible_windows.
 753         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 754         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 755
 756 2019-08-13  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 759         tui_add_win_to_layout.
 760
 761 2019-08-13  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 764         * tui/tui-layout.c (tui_default_win_height): Now static.
 765
 766 2019-08-13  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 769         single switch.
 770         (show_source_disasm_command, show_source_or_disasm_and_command):
 771         Don't check current layout.
 772
 773 2019-08-13  Tom Tromey  <tom@tromey.com>
 774
 775         * tui/tui-wingeneral.c (make_all_visible): Remove.
 776         (tui_make_all_invisible): Simplify.
 777         * tui/tui-layout.c (tui_make_all_invisible): Move from
 778         tui-wingeneral.c; simplify.
 779         (show_layout): Hoist call to tui_make_all_invisible.
 780         (show_data): Don't call tui_make_all_invisible.
 781
 782 2019-08-13  Tom Tromey  <tom@tromey.com>
 783
 784         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 785         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 786
 787 2019-08-13  Tom Tromey  <tom@tromey.com>
 788
 789         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 790         tui-data.c.
 791         (show_source_disasm_command, show_data)
 792         (show_source_or_disasm_and_command): Don't use
 793         tui_set_current_layout_to.
 794         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 795         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 796         tui-layout.c.
 797         (tui_set_current_layout_to): Remove.
 798
 799 2019-08-13  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-layout.c (tui_set_layout): Update.
 802         * tui/tui-data.h (struct tui_layout_def): Remove.
 803         (tui_layout_def): Don't declare.
 804         * tui/tui-data.c (layout_def): Remove.
 805         (tui_layout_def): Remove.
 806
 807 2019-08-13  Tom Tromey  <tom@tromey.com>
 808
 809         * tui/tui-winsource.h (struct tui_source_window_base)
 810         <clear_detail>: No longer "override".
 811         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 812         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 813         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 814         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 815         Remove.
 816         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 817
 818 2019-08-13  Tom Tromey  <tromey@adacore.com>
 819
 820         * tracepoint.c: Don't include readline.h or history.h.
 821
 822 2019-08-12  Tom Tromey  <tom@tromey.com>
 823
 824         * configure: Rebuild.
 825         * configure.ac: Check for readline 7.
 826         * NEWS: Mention readline 7 requirement.
 827         * README: Update.
 828
 829 2019-08-12  Tom Tromey  <tom@tromey.com>
 830
 831         * mingw-hdep.c (gdb_select): Remove readline hack.
 832
 833 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 834
 835         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 836         when the function fails.
 837
 838 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 839
 840         * s390-tdep.c (s390_type_align): New function.
 841         (s390_gdbarch_init): Set it as type_align gdbarch method.
 842
 843 2019-08-09  Tom de Vries  <tdevries@suse.de>
 844
 845         PR gdb/24591
 846         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 847         pc_low with relocation offset.
 848
 849 2019-08-07  Tom Tromey  <tromey@adacore.com>
 850
 851         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 852         (print_frame_args): Update.
 853         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 854         Update.
 855         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 856         * frame.h (struct frame_arg): Add initializers.
 857         <error>: Now a unique_xmalloc_ptr.
 858
 859 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 860
 861         * NEWS: Expand the Pointer Authentication entry.
 862         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 863         (aarch64_frame_unmask_lr): ... to this.
 864         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 865         Call aarch64_frame_unmask_lr.
 866         * frame.c (struct frame_info): Add "masked" variable.
 867         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 868         (fprint_frame): Check for masked pc.
 869         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 870         declarations.
 871         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 872         * stack.c (print_frame): Check for masked pc.
 873
 874 2019-08-06  Tom Tromey  <tom@tromey.com>
 875
 876         * stabsread.c (patch_block_stabs, read_one_struct_field)
 877         (read_enum_type): Use obstack_strndup.
 878         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 879         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 880         * dwarf2read.c (guess_full_die_structure_name)
 881         (anonymous_struct_prefix): Use obstack_strndup.
 882         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 883         * c-exp.y (yylex): Use obstack_strndup.
 884         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 885         (write_var_or_type): Use obstack_strndup.
 886
 887 2019-08-06  Tom Tromey  <tom@tromey.com>
 888
 889         * symfile.c (reread_symbols): Use obstack_strdup.
 890         * stabsread.c (read_type): Use obstack_strdup.
 891         * gdb_obstack.h (obstack_strdup): New overload.
 892         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 893         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 894         (dwarf2_canonicalize_name): Use obstack_strdup.
 895         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 896         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 897         Use obstack_strdup.
 898
 899 2019-08-06  Tom Tromey  <tom@tromey.com>
 900
 901         * gdb_obstack.h (obstack_strdup): Define.
 902         * gdb_obstack.c (obstack_strdup): Don't define.
 903
 904 2019-08-06  Tom Tromey  <tom@tromey.com>
 905
 906         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 907         obstack_strdup.
 908         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 909         obstack_strdup.
 910         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 911         * stabsread.c (common_block_start): Use obstack_strdup.
 912         * objfiles.c (set_objfile_main_name, objfile): Use
 913         obstack_strdup.
 914         * namespace.c (add_using_directive): Use obstack_strdup.
 915         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 916         * jit.c (finalize_symtab): Use obstack_strdup.
 917         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 918         (guess_partial_die_structure_name, partial_die_info::fixup)
 919         (dwarf2_name): Use obstack_strdup.
 920         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 921         obstack_strdup.
 922         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 923         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 924         obstack_strdup.
 925         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 926
 927 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 928
 929         * unittests/help-doc-selftests.c: New file.
 930         * Makefile.in: Add the new file.
 931
 932 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 933
 934         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 935         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 936         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 937         the trailing '.' is not output, and the first character is uppercased.
 938         (print_help_for_command): Update call to print_doc_line.
 939         (print_doc_of_command): Likewise.
 940         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 941         * cli/cli-option.c (append_indented_doc): Do not append newline.
 942         (build_help_option): Append newline after first appended_indented_doc
 943         only if a second call is done.
 944         (build_help): Append 2 new lines before each option, except the first
 945         one.
 946         * compile/compile.c (_initialize_compile): Add new lines after
 947         %OPTIONS%, when not at the end of the help.
 948         Change help doc or code
 949         producing the help doc to respect the invariants.
 950         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 951         Also removed the new line after 'Options:', as all other commands
 952         do not put an empty line between 'Options:' and the first option.
 953         * printcmd.c (_initialize_printcmd): Likewise.
 954         * stack.c (_initialize_stack): Likewise.
 955         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 956         incorrectly telling COMMAND is optional.
 957         * ada-lang.c (_initialize_ada_language): Change help doc or code
 958         producing the help doc to respect the invariants.
 959         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 960         * breakpoint.c (_initialize_breakpoint): Likewise.
 961         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 962         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 963         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 964         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 965         _initialize_cli_style): Likewise.
 966         * corelow.c (core_target_info): Likewise.
 967         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 968         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 969         * filesystem.c (_initialize_filesystem): Likewise.
 970         * frame.c (_initialize_frame): Likewise.
 971         * gnu-nat.c (add_task_commands): Likewise.
 972         * infcall.c (_initialize_infcall): Likewise.
 973         * infcmd.c (_initialize_infcmd): Likewise.
 974         * interps.c (_initialize_interpreter): Likewise.
 975         * language.c (_initialize_language): Likewise.
 976         * linux-fork.c (_initialize_linux_fork): Likewise.
 977         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 978         * maint.c (_initialize_maint_cmds): Likewise.
 979         * memattr.c (_initialize_mem): Likewise.
 980         * printcmd.c (_initialize_printcmd): Likewise.
 981         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 982         _RegEx): Likewise.
 983         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 984         * record-btrace.c (_initialize_record_btrace): Likewise.
 985         * record-full.c (_initialize_record_full): Likewise.
 986         * record.c (_initialize_record): Likewise.
 987         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 988         * regcache.c (_initialize_regcache): Likewise.
 989         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 990         _initialize_remote): Likewise.
 991         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 992         * serial.c (_initialize_serial): Likewise.
 993         * skip.c (_initialize_step_skip): Likewise.
 994         * source.c (_initialize_source): Likewise.
 995         * stack.c (_initialize_stack): Likewise.
 996         * symfile.c (_initialize_symfile): Likewise.
 997         * symtab.c (_initialize_symtab): Likewise.
 998         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 999         * top.c (init_main): Likewise.
1000         * tracefile-tfile.c (tfile_target_info): Likewise.
1001         * tracepoint.c (_initialize_tracepoint): Likewise.
1002         * tui/tui-win.c (_initialize_tui_win): Likewise.
1003         * utils.c (add_internal_problem_command): Likewise.
1004         * valprint.c (value_print_option_defs): Likewise.
1005
1006 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1007
1008         PR build/24886
1009         * configure.ac: Drop enable-libmcheck support.
1010         * configure, config.in: Rebuild.
1011         * libmcheck.m4: Remove.
1012         * acinclude.m4: Don't include it.
1013         * Makefile.in: Don't distribute it.
1014         * top.c (print_gdb_configuration): Don't mention it.
1015
1016 2019-08-06  Tom Tromey  <tom@tromey.com>
1017
1018         * utils.c (set_output_style): Sometimes pass stream to
1019         emit_style_escape.
1020         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1021         * record-btrace.c (btrace_insn_history): Update.
1022         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1023         method.
1024         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1025         Update initializers.
1026         <m_uiout>: New field.
1027         <m_di>: Move lower.
1028         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1029         Remove "uiout" parameter.
1030         (dump_insns): Update.
1031         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1032         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1033
1034 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1035
1036         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1037         (error_in_psymtab_expansion): Likewise.
1038         (lookup_symbol_via_quick_fns): Likewise.
1039         (basic_lookup_transparent_type_quick): Likewise.
1040         (basic_lookup_transparent_type_1): Likewise.
1041
1042 2019-08-06  Tom Tromey  <tromey@adacore.com>
1043
1044         * source.c (last_source_error): Now bool.
1045         (print_source_lines_base): Make "noprint" bool.  Only open
1046         source file when last_source_visited changes.
1047
1048 2019-08-06  Tom Tromey  <tromey@adacore.com>
1049
1050         * annotate.c (annotate_source_line): Use g_source_cache.
1051         * source-cache.c (source_cache::get_plain_source_lines): Change
1052         parameters.  Populate m_offset_cache.
1053         (source_cache::ensure): New method.
1054         (source_cache::get_line_charpos): New method.
1055         (extract_lines): Move lower.  Change parameters.
1056         (source_cache::get_source_lines): Move lower.
1057         * source-cache.h (class source_cache): Update comment.
1058         <get_line_charpos>: New method.
1059         <get_source_lines>: Update comment.
1060         <clear>: Clear m_offset_cache.
1061         <get_plain_source_lines>: Change parameters.
1062         <ensure>: New method
1063         <m_offset_cache>: New member.
1064         * source.c (forget_cached_source_info_for_objfile): Update.
1065         (info_source_command): Use g_source_cache.
1066         (find_source_lines, open_source_file_with_line_charpos): Remove.
1067         (print_source_lines_base, search_command_helper): Use g_source_cache.
1068         * source.h (open_source_file_with_line_charpos): Don't declare.
1069         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1070         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1071         Use g_source_cache.
1072
1073 2019-08-06  Tom Tromey  <tromey@adacore.com>
1074
1075         * source-cache.c (source_cache::get_plain_source_lines):
1076         Remove "first_line" and "last_line" parameters.
1077         (source_cache::get_source_lines): Cache plain text.
1078         * source-cache.h (class source_cache)
1079         <get_plain_source_lines>: Update.
1080
1081 2019-08-06  Tom Tromey  <tromey@adacore.com>
1082
1083         * source-cache.c (extract_lines): No longer a method.
1084         Changed type of parameter.  Include final newline.
1085         (selftests::extract_lines_test): New function.
1086         (_initialize_source_cache): Likewise.
1087         * source-cache.h (class source_cache)
1088         <extract_lines>: Don't declare.
1089
1090 2019-08-06  Tom Tromey  <tromey@adacore.com>
1091
1092         * breakpoint.c (init_breakpoint_sal): Update.
1093         (breakpoint): Update.
1094         * breakpoint.h (struct breakpoint) <filter>: Now a
1095         unique_xmalloc_ptr.
1096
1097 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1098
1099         * NEWS: Mention dictionary access on blocks.
1100         * python/py-block.c (blpy_getitem): New function.
1101         (block_object_as_mapping): New struct.
1102         (block_object_type): Use new struct for tp_as_mapping field.
1103
1104 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1105
1106         * objfiles.h (objfile): Add a comment describing partial symbols.
1107
1108 2019-08-05  Tom Tromey  <tromey@adacore.com>
1109
1110         * compile/compile.c (_initialize_compile): Use _(), not N_().
1111         * thread.c (_initialize_thread): Use _(), not N_().
1112         * stack.c (_initialize_stack): Use _(), not N_().
1113         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1114
1115 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1116
1117         * dwarf2read.c (struct dw2_symtab_iterator):
1118         <want_specific_block>: Remove.
1119         <block_index>: Change type to gdb::optional.
1120         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1121         change type of BLOCK_INDEX parameter to gdb::optional.
1122         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1123         (dw2_lookup_symbol): Don't pass argument for
1124         WANT_SPECIFIC_BLOCK.
1125         (dw2_expand_symtabs_for_function): Don't pass argument for
1126         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1127         (class dw2_debug_names_iterator)
1128         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1129         parameter, change BLOCK_INDEX type to gdb::optional.
1130         <m_want_specific_block>: Remove.
1131         <m_block_index>: Change type to gdb::optional.
1132         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1133         gdb::optional.  Re-write in function of gdb::optional.
1134         (dw2_debug_names_lookup_symbol): Don't pass argument for
1135         WANT_SPECIFIC_BLOCK.
1136         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1137         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1138         BLOCK_INDEX.
1139
1140 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1141
1142         * NEWS: Mention changes to "info sources" command.
1143
1144 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1145
1146         * symtab.c (filename_partial_match_opts): New struct type.
1147         (struct output_source_filename_data): New members
1148         regexp, c_regexp, partial_match.
1149         (output_source_filename): Use new members to decide to print file.
1150         (info_sources_option_defs): New variable.
1151         (make_info_sources_options_def_group, print_info_sources_header,
1152         info_sources_command_completer):
1153         New functions.
1154         (info_sources_command): Read new optional arguments.
1155         (_initialize_symtab): Update info sources help.
1156
1157 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1158
1159         * ada-lang.c (exception_support_info_v0): Renamed from...
1160         (default_exception_support_info): ... this.  Create new
1161         definition for v1.
1162         (ada_has_this_exception_support): Look up catch_handlers_sym.
1163         (ada_exception_support_info_sniffer): Try v0 after default.
1164
1165 2019-08-01  Tom Tromey  <tromey@adacore.com>
1166
1167         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1168         gdbarch.h.
1169
1170 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1171
1172         * s12z-tdep.c: Fix include path for s12z-opc.h.
1173
1174 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1175
1176         * NEWS: Require GNU make 3.82.
1177
1178 2019-07-16  Tom Tromey  <tom@tromey.com>
1179
1180         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1181         declare.
1182
1183 2019-07-30  Tom Tromey  <tromey@adacore.com>
1184
1185         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1186
1187 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1188
1189         * printcmd.c (print_address_symbolic): Print negative offsets.
1190         (build_address_symbolic): Force signed arithmetic when computing
1191         offset.
1192
1193 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1194
1195         PR/24474: Add a function to lookup static variables.
1196         * NEWS: Mention this new function.
1197         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1198         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1199         * python/python.c (python_GdbMethods): Add new function.
1200
1201 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1202
1203         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1204         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1205         (objfpy_lookup_static_symbol): New function.
1206         (objfile_object_methods): Add new functions.
1207
1208 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1209
1210         * NEWS: Mention 'set|show print frame-info'.  Mention new
1211         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1212         backtrace argument.  Mention that python frame filtering code
1213         is now consistent with what 'backtrace' command prints.
1214
1215 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1216
1217         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1218         comments.
1219         (print_frame_info_auto, print_frame_info_source_line,
1220         print_frame_info_location, print_frame_info_source_and_location,
1221         print_frame_info_location_and_address, print_frame_info_short_location):
1222         New declarations.
1223         (struct frame_print_options): New member print_frame_info.
1224         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1225         * stack.h (get_user_print_what_frame_info): New declaration.
1226         (frame_show_address): New declaration.
1227         * stack.c (print_frame_arguments_choices): New value 'presence'.
1228         (print_frame_info_auto, print_frame_info_source_line,
1229         print_frame_info_location, print_frame_info_source_and_location,
1230         print_frame_info_location_and_address, print_frame_info_short_location,
1231         print_frame_info_choices, print_frame_info_print_what): New definitions.
1232         (print_frame_args): Only print dots for args if print frame-arguments
1233         is 'presence'.
1234         (frame_print_option_defs): New element for "frame-info".
1235         (get_user_print_what_frame_info): New function.
1236         (frame_show_address): Make non static.  Move comment to stack.h.
1237         (print_frame_info_to_print_what): New function.
1238         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1239         to decide what to print.
1240         (backtrace_command_1): Handle the new print_frame_arguments_presence
1241         value.
1242         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1243         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1244         (py_print_frame): In non-mi mode, use LOCATION as default for
1245         print_what, similarly to frame information printed directly by
1246         backtrace command. Handle frame-info user option in non MI mode.
1247
1248 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1249
1250         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1251         Add case for debugging 32-bit target on 64-bit host.  Revise
1252         comment.
1253
1254 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1255
1256         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1257         instead of find_function_entry_range_from_pc.
1258
1259 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1260
1261         * stack.c (find_frame_funname): Remove code which preferred
1262         minsym over symtab sym in "certain pathological cases".
1263
1264         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1265         parameter.  Change type of "do_demangle" to bool.
1266         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1267         Pass suitable "prefer_sym_over_minsym" flag to
1268         build_address_symbolic().  Don't output "+" for negative offsets.
1269         * printcmd.c (print_address_symbolic): Update invocation of
1270         build_address_symbolic to include a "prefer_sym_over_minsym"
1271         flag.
1272         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1273         Restrict cases in which use of minimal symbol is preferred to that
1274         of a found symbol.  Update comments.
1275
1276         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1277         for entry pc when entry pc is out of range for that FDE.
1278
1279 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1280
1281         PR gdb/24839:
1282         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1283         type.
1284
1285 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1286
1287         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1288         this function's Python signature.
1289
1290
1291 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1292
1293         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1294         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1295         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1296         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1297         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1298
1299
1300 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1301
1302         * h8300-tdep.c (h8300_register_name_common): New.
1303         h8300_register_name): Use h8300_register_name_common.
1304         (h8300s_register_name): Likewise.
1305         (h8300sx_register_name): Likewise.
1306         (h8300h_register_nam): New.
1307         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1308
1309
1310 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1311
1312         * arm-tdep.c (arm_skip_cmse_entry): New function.
1313         (arm_is_sgstubs_section): New function.
1314         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1315
1316 2019-07-22  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1319         Don't self-assign.
1320
1321 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1322
1323         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1324         type_print.
1325
1326 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1327
1328         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1329         so that GDB doesn't match any msymbols when searching in the
1330         TYPES_DOMAIN.
1331         (print_symbol_info): Print using typedef_print or type_print based
1332         on the type of the symbol.  Add updated FIXME comment moved from...
1333         (_initialize_symtab): ... move and update FIXME comment to above.
1334
1335 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * NEWS: Mention adding -q option to "info types".
1338         * symtab.c (struct info_types_options): New struct.
1339         (info_types_options_defs): New variable.
1340         (make_info_types_options_def_group): New function.
1341         (info_types_command): Use gdb::option framework to parse options.
1342         (info_types_command_completer): New function.
1343         (_initialize_symtab): Extend the help text on "info types" and
1344         register command completer.
1345
1346 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1347
1348         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1349         (lookup_symbol_in_objfile): Change int to block_enum and add a
1350         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1351
1352 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1353
1354         * MAINTAINERS (Write After Approval): Add self.
1355
1356 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1357
1358         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1359         instruction to the dummy code region.
1360
1361 2019-07-19  Tom Tromey  <tromey@adacore.com>
1362
1363         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1364         (ARGSUSED, PARAMS, __func__): Remove rules.
1365
1366 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1367
1368         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1369         * features/arm/arm-with-iwmmxt.c: Remove.
1370         * features/arm/arm-with-iwmmxt.xml: Remove.
1371         * features/arm/arm-with-m-fpa-layout.c: Remove.
1372         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1373         * features/arm/arm-with-m-vfp-d16.c: Remove.
1374         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1375         * features/arm/arm-with-m.c: Remove.
1376         * features/arm/arm-with-m.xml: Remove.
1377         * features/arm/arm-with-neon.c: Remove.
1378         * features/arm/arm-with-neon.xml: Remove.
1379         * features/arm/arm-with-vfpv2.c: Remove.
1380         * features/arm/arm-with-vfpv2.xml: Remove.
1381         * features/arm/arm-with-vfpv3.c: Remove.
1382         * features/arm/arm-with-vfpv3.xml: Remove.
1383
1384 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1385
1386         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1387
1388 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1389
1390         * arch/aarch32.c (aarch32_create_target_description): Create
1391         target descriptions using features.
1392         * arch/arm.c (arm_create_target_description)
1393         (arm_create_mprofile_target_description): Likewise.
1394         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1395
1396 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1397
1398         * Makefile.in: Add new files.
1399         * aarch32-tdep.c: New file.
1400         * aarch32-tdep.h: New file.
1401         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1402         Call aarch32_read_description.
1403         * arch/aarch32.c: New file.
1404         * arch/aarch32.h: New file.
1405         * arch/arm.c (arm_create_target_description)
1406         (arm_create_mprofile_target_description): New function.
1407         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1408         (arm_create_target_description)
1409         (arm_create_mprofile_target_description): New declaration.
1410         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1411         read_description functions.
1412         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1413         Likewise.
1414         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1415         * arm-tdep.c (tdesc_arm_list): New variable.
1416         (arm_register_g_packet_guesses): Call create description functions.
1417         (arm_read_description) (arm_read_mprofile_description): New
1418         function.
1419         * arm-tdep.h (arm_read_description)
1420         (arm_read_mprofile_description): Add declaration.
1421         * configure.tgt: Add new files.
1422
1423 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1424
1425         * top.c (new_ui_command): Open specified terminal just once.
1426
1427 2019-07-18  Tom Tromey  <tromey@adacore.com>
1428
1429         * symtab.c (main_name): Constify return type.
1430         * symfile.c (set_initial_language): Update.
1431         * symtab.h (main_name): Constify return type.
1432
1433 2019-07-17  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-winsource.c (tui_update_source_window)
1436         (tui_update_source_window_as_is)
1437         (tui_update_source_windows_with_line): Remove return.
1438         * tui/tui-disasm.c (tui_show_disassem)
1439         (tui_show_disassem_and_update_source): Remove return.
1440         * tui/tui.c (tui_reset): Remove return.
1441         * tui/tui-wingeneral.c
1442         (tui_check_and_display_highlight_if_needed): Remove return.
1443
1444 2019-07-17  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1447
1448 2019-07-17  Tom Tromey  <tom@tromey.com>
1449
1450         * tui/tui-winsource.h (struct tui_exec_info_window)
1451         (struct tui_source_window_base): Move from tui-data.h.
1452         * tui/tui-winsource.c: Move many method definitions from
1453         elsewhere.  Remove "structuring" comments.
1454         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1455         (tui_source_window_base::refresh_window): Move to
1456         tui-winsource.c.
1457         * tui/tui-win.c (tui_source_window_base::refresh_all)
1458         (tui_source_window_base::update_tab_width)
1459         (tui_source_window_base::set_new_height)
1460         (tui_source_window_base::do_make_visible_with_new_height): Move to
1461         tui-winsource.c.
1462         * tui/tui-source.h: Update.
1463         * tui/tui-source.c (tui_source_window_base::reset): Move to
1464         tui-winsource.c.
1465         * tui/tui-disasm.h: Update.
1466         * tui/tui-data.h (struct tui_exec_info_window): Move to
1467         tui-winsource.h.
1468         (struct tui_source_window_base): Likewise.
1469         * tui/tui-data.c (tui_source_window_base::clear_detail)
1470         (tui_source_window_base, ~tui_source_window_base): Move to
1471         tui-winsource.c.
1472
1473 2019-07-17  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-win.c (tui_resize_all)
1476         (tui_source_window_base::update_tab_width)
1477         (tui_adjust_win_heights): Update.
1478         (tui_win_info::make_invisible_and_set_new_height): Rename from
1479         make_invisible_and_set_new_height.
1480         * tui/tui-data.h (struct tui_win_info)
1481         <make_invisible_and_set_new_height>: New method.
1482
1483 2019-07-17  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui.c: Update.
1486         * tui/tui-source.h (struct tui_source_window): Move from
1487         tui-data.h.
1488         * tui/tui-layout.c: Update.
1489         * tui/tui-disasm.c: Update.
1490         * tui/tui-data.h (struct tui_source_window): Move to
1491         tui-source.h.
1492
1493 2019-07-17  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1496         tui-data.h.
1497         * tui/tui-data.h (struct tui_disasm_window): Move to
1498         tui-disasm.h.
1499
1500 2019-07-17  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-regs.h (struct tui_data_item_window): Move from
1503         tui-data.h.
1504         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1505         * tui/tui-data.h (struct tui_data_item_window): Move to
1506         tui-regs.h.
1507         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1508
1509 2019-07-17  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui.c: Update.
1512         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1513         (tui_cmd_window::max_height): Move to tui-command.c.
1514         * tui/tui-layout.c: Update.
1515         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1516         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1517         tui-command.c.
1518         * tui/tui-command.h (struct tui_cmd_window): Move from
1519         tui-data.h.
1520         * tui/tui-command.c: Remove "structuring" comments.
1521         (tui_cmd_window::clear_detail)
1522         (tui_cmd_window::do_make_visible_with_new_height)
1523         (tui_cmd_window::max_height): Move from elsewhere.
1524
1525 2019-07-17  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1528         Now static.
1529         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1530         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1531
1532 2019-07-17  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui.c: Update.
1535         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1536         tui-regs.c.
1537         * tui/tui-windata.h: Remove file.
1538         * tui/tui-windata.c: Remove file.
1539         * tui/tui-win.c (tui_data_window::set_new_height)
1540         (tui_data_window::do_make_visible_with_new_height): Move to
1541         tui-regs.c.
1542         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1543         * tui/tui-regs.c: Remove "structuring" comments.
1544         (tui_data_window::first_data_item_displayed)
1545         (tui_data_window::delete_data_content_windows)
1546         (tui_data_window::erase_data_content)
1547         (tui_data_window::display_all_data)
1548         (tui_data_window::refresh_all)
1549         (tui_data_window::do_scroll_vertical)
1550         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1551         (tui_data_window::do_make_visible_with_new_height)
1552         (tui_data_window::refresh_window): Move from elsewhere.
1553         (_initialize_tui_regs): Move to end of file.
1554         * tui/tui-layout.c: Update.
1555         * tui/tui-hooks.c: Update.
1556         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1557         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1558         tui-regs.c.
1559         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1560
1561 2019-07-17  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1564         seen.
1565
1566 2019-07-17  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-win.c (tui_source_window_base::set_new_height)
1569         (tui_source_window_base::do_make_visible_with_new_height): Use
1570         m_has_locator field directly.
1571         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1572         method.
1573         (struct tui_source_window_base) <has_locator>: Likewise.
1574
1575 2019-07-17  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1578         Don't declare.
1579         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1580         Remove.
1581         * tui/tui-win.c (tui_source_window_base::set_new_height)
1582         (tui_source_window_base::set_new_height)
1583         (make_invisible_and_set_new_height)
1584         (tui_source_window_base::do_make_visible_with_new_height)
1585         (tui_source_window_base::do_make_visible_with_new_height):
1586         Update.
1587         * tui/tui-layout.c (show_source_disasm_command, show_data)
1588         (show_source_or_disasm_and_command): Update.
1589         * tui/tui-layout.c (show_layout): Update.
1590
1591 2019-07-17  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-layout.c (make_data_window): Remove.
1594         (show_data): Unify creation and re-initialization cases.
1595
1596 2019-07-17  Tom Tromey  <tom@tromey.com>
1597
1598         * tui/tui-layout.c (make_source_window, make_disasm_window):
1599         Remove.
1600         (show_data): Unify creation and re-initialization cases.
1601
1602 2019-07-17  Tom Tromey  <tom@tromey.com>
1603
1604         * tui/tui-layout.c (make_command_window): Remove.
1605         (show_source_disasm_command, show_source_or_disasm_and_command):
1606         Unify creation and re-initialization cases.
1607
1608 2019-07-17  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1611         creation and re-initialization cases.
1612
1613 2019-07-17  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-regs.c (tui_get_register): Return void.
1616
1617 2019-07-17  Tom Tromey  <tom@tromey.com>
1618
1619         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1620         Simplify.
1621
1622 2019-07-17  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1625         resetting.
1626
1627 2019-07-17  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1630         * tui/tui-regs.c (tui_reg_layout): New function.
1631         (tui_show_registers, tui_reg_command): Use it.
1632         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1633         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1634         parameters.
1635         (tui_layout_command): Remove.
1636
1637 2019-07-17  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-layout.h (tui/tui-layout): Return void.
1640         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1641
1642 2019-07-17  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-layout.c (show_source_disasm_command, show_data):
1645         Update.
1646         (reset_locator): Remove.
1647         (show_source_or_disasm_and_command): Update.
1648
1649 2019-07-17  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-source.c (tui_source_window_base::reset): Remove
1652         win_type parameter.
1653         * tui/tui-layout.c (make_command_window, make_source_window)
1654         (make_disasm_window, make_data_window)
1655         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1656         (reset_locator, show_source_or_disasm_and_command): Update.
1657         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1658         win_type parameter.
1659         (struct tui_source_window_base) <reset>: Likewise.
1660
1661 2019-07-17  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-layout.c (show_source_disasm_command): Use
1664         reset_locator.
1665         (reset_locator): New function.
1666         (init_and_make_win): Remove.
1667         (show_source_or_disasm_and_command): Use reset_locator.
1668
1669 2019-07-17  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1672         condition.
1673         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1674         Remove condition.
1675         * tui/tui-source.c (tui_source_window_base::reset): New method.
1676         * tui/tui-layout.c (make_command_window): Don't call
1677         init_and_make_win.
1678         (make_source_window, make_disasm_window): Don't call
1679         make_source_or_disasm_window.
1680         (make_data_window): Don't call init_and_make_win.  Change calling
1681         convention.
1682         (show_source_disasm_command, show_data): Simplify.
1683         (make_source_or_disasm_window): Remove.
1684         (show_source_or_disasm_and_command): Simplify.
1685         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1686         (struct tui_source_window_base) <reset>: Likewise.
1687         <execution_info>: Remove initializer.
1688         * tui/tui-data.c (tui_source_window_base): Initialize
1689         execution_info.
1690
1691 2019-07-17  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1694         variable.
1695
1696 2019-07-17  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui.c (tui_rl_other_window): Update.
1699         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1700         superclass method first.  Always iterate over regs_content.
1701         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1702         method.
1703         * tui/tui-win.c (tui_set_focus_command): Update.
1704
1705 2019-07-17  Tom Tromey  <tom@tromey.com>
1706
1707         * tui/tui-win.c (tui_set_focus_command): Rename from
1708         tui_set_focus.  Call tui_enable.
1709         (tui_set_focus_command): Remove.
1710
1711 2019-07-17  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1714         refresh_window.
1715         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1716         touchwin.
1717         (tui_data_window::refresh_window): Call refresh_window on data
1718         items.  Always call superclass refresh_window.
1719         (tui_win_info::refresh): Remove.
1720         (tui_source_window_base::refresh_window): Update.
1721         (tui_refresh_all): Update.
1722         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1723         refresh_window.
1724         (show_source_or_disasm_and_command): Likewise.
1725         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1726         (struct tui_source_window_base) <refresh>: Likewise.
1727
1728 2019-07-17  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-winsource.c (tui_clear_source_content)
1731         (tui_show_source_content): Update.
1732         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1733         whether content is empty.
1734         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1735         Remove.
1736
1737 2019-07-17  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1740         window's contents.
1741         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1742         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1743
1744 2019-07-17  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1747         (struct tui_data_item_window): Update.
1748
1749 2019-07-17  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1752         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1753         defines.
1754
1755 2019-07-17  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-winsource.h (tui_erase_source_content)
1758         (tui_clear_source_content): Remove "display_prompt" parameter.
1759         * tui/tui-winsource.c (tui_update_source_window_as_is)
1760         (tui_update_source_windows_with_addr): Update.
1761         (tui_clear_source_content): Remove "display_prompt" parameter.
1762         (tui_erase_source_content): Likewise.  Simplify.
1763         (tui_show_source_content): Update.
1764         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1765         * tui/tui-stack.c (tui_show_frame_info): Update.
1766         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1767         Remove defines.
1768
1769 2019-07-17  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1772         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1773         parameter.
1774         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1775         parameter.
1776
1777 2019-07-17  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-winsource.c (tui_clear_source_content)
1780         (tui_show_source_content, tui_show_exec_info_content)
1781         (tui_clear_exec_info_content): Update.
1782         * tui/tui-stack.c (tui_show_locator_content): Update.
1783         (tui_show_frame_info): Update.
1784         * tui/tui-source.h (tui_source_window): Don't declare.
1785         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1786         from tui_source_is_displayed.
1787         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1788         Remove field.
1789         (struct tui_source_window_base) <content_in_use>: New field.  Now
1790         bool.
1791         (struct tui_source_window) <showing_source_p>: New method.
1792         (TUI_SRC_WIN): Change cast.
1793         * tui/tui-data.c (tui_initialize_static_data): Update.
1794
1795 2019-07-17  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1798         location_matches_p.
1799         * tui/tui-source.c (tui_source_window::location_matches_p): New
1800         method.
1801         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1802         method.
1803         * tui/tui-data.h (struct tui_source_window_base)
1804         <location_matches_p>: New method.
1805         (struct tui_source_window, struct tui_disasm_window)
1806         <location_matches_p>: Likewise.
1807
1808 2019-07-17  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-win.c (tui_set_win_height_command): Rename from
1811         tui_set_win_height.
1812         (tui_set_win_height_command): Remove.
1813
1814 2019-07-17  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-source.c (tui_source_window): New constructor.  Add
1817         observer.
1818         (~tui_source_window): New destructor.
1819         (tui_source_window::style_changed): New method.
1820         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1821         (tui_attach_detach_observers): Update.
1822         * tui/tui-data.h (struct tui_source_window): Make constructor not
1823         inline.  Add destructor.
1824         (struct tui_source_window) <style_changed>: New method.
1825         <m_observable>: New member.
1826
1827 2019-07-17  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1830         * tui/tui-win.c (tui_resize_all): Fix typo.
1831
1832 2019-07-17  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1835         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1836         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1837         * tui/tui-win.c (window_name_completer): Use foreach.
1838         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1839         (update_tab_width): Likewise.
1840         * tui/tui-layout.c (show_layout): Update.
1841         * tui/tui-data.h (class tui_window_iterator): New.
1842         (struct all_tui_windows): New.
1843         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1844
1845 2019-07-17  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1848         parameter.  Don't reference globals.
1849         (tui_reg_command): Update.
1850
1851 2019-07-17  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-regs.c (tui_show_registers): Simplify.
1854
1855 2019-07-17  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-regs.c (tui_show_registers): Update.
1858         (tui_show_register_group): Add win_info parameter.
1859
1860 2019-07-17  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1863         Rename from tui_display_reg_element_at_line.
1864         (tui_data_window::display_registers_from_line): Update.
1865         * tui/tui-data.h (struct tui_data_window)
1866         <display_reg_element_at_line>: New method.
1867
1868 2019-07-17  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-regs.h (tui_display_registers_from)
1871         (tui_display_registers_from_line): Don't declare.
1872         * tui/tui-windata.c (tui_data_window::display_all_data)
1873         (tui_data_window::refresh_all)
1874         (tui_data_window::do_scroll_vertical): Update.
1875         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1876         from tui_display_registers_from.
1877         (tui_display_reg_element_at_line): Update.
1878         (tui_data_window::display_registers_from_line): Rename from
1879         tui_display_registers_from_line.
1880         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1881         display_registers_from_line>: New methods.
1882
1883 2019-07-17  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1886         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1887         from tui_erase_data_content.
1888         (tui_data_window::display_all_data)
1889         (tui_data_window::refresh_all)
1890         (tui_data_window::do_scroll_vertical): Update.
1891         * tui/tui-regs.c (tui_show_registers): Update.
1892         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1893         New method.
1894
1895 2019-07-17  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1898         declare.
1899         * tui/tui-windata.c
1900         (tui_data_window::delete_data_content_windows): Rename from
1901         tui_delete_data_content_windows.
1902         (tui_data_window::display_all_data)
1903         (tui_data_window::do_scroll_vertical): Update.
1904         * tui/tui-data.h (struct tui_data_window)
1905         <delete_data_content_windows>: New method.
1906
1907 2019-07-17  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1910         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1911
1912 2019-07-17  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1915         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1916         from tui_display_all_data.
1917         * tui/tui-win.c
1918         (tui_data_window::do_make_visible_with_new_height): Update.
1919         * tui/tui-regs.c (tui_show_registers): Update.
1920         * tui/tui-layout.c (tui_set_layout): Update.
1921         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1922         method.
1923
1924 2019-07-17  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1927         * tui/tui-windata.c (tui_display_data_from): Remove.
1928         (tui_data_window::refresh_all): Update.
1929
1930 2019-07-17  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1933         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1934         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1935         tui_display_registers_from_line.
1936         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1937         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1938         "force_display" parameter.
1939
1940 2019-07-17  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1943         declare.
1944         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1945         Rename from tui_first_reg_element_no_inline.
1946         (tui_display_reg_element_at_line)
1947         (tui_display_registers_from_line): Update.
1948         * tui/tui-data.h (struct tui_data_window)
1949         <first_reg_element_no_inline>: New method.
1950
1951 2019-07-17  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-windata.c (tui_display_data_from)
1954         (tui_data_window::do_scroll_vertical): Update.
1955         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1956         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1957         Rename from tui_line_from_reg_element_no.
1958         (tui_display_registers_from_line): Update.
1959         * tui/tui-data.h (struct tui_data_window)
1960         <line_from_reg_element_no>: New method.
1961
1962 2019-07-17  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1965         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1966         tui_last_regs_line_no.
1967         (tui_display_reg_element_at_line)
1968         (tui_display_registers_from_line): Update.
1969         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1970         method.
1971
1972 2019-07-17  Tom Tromey  <tom@tromey.com>
1973
1974         PR tui/24722:
1975         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1976         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1977         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1978         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1979         (tui_update_breakpoint_info): Likewise.
1980         * tui/tui-hooks.c (tui_event_create_breakpoint)
1981         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1982         Update.
1983
1984 2019-07-17  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1987
1988 2019-07-17  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-winsource.c (tui_update_source_window_as_is)
1991         (tui_update_source_windows_with_addr): Update.
1992         * tui/tui-source.h (tui_set_source_content)
1993         (tui_show_symtab_source): Add "win_info" parameter.
1994         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1995         parameter.
1996         (tui_show_symtab_source): Likewise.
1997
1998 2019-07-17  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-wingeneral.c
2001         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2002
2003 2019-07-17  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2006         (struct tui_cmd_window) <can_scroll>: New method.
2007         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2008         method.
2009
2010 2019-07-17  Tom Tromey  <tromey@adacore.com>
2011
2012         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2013         do_field_signed>: Rename.  Change type of "value".
2014         * ui-out.c (ui_out::field_signed): Rename from field_int.
2015         Change type of "value".
2016         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2017         type of "value".
2018         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2019         do_field_int.  Change type of "value".
2020         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2021         do_field_int.  Change type of "value".
2022         * tracepoint.c (trace_status_mi, tfind_1)
2023         (print_one_static_tracepoint_marker): Update.
2024         * thread.c (print_thread_info_1, print_selected_thread_frame):
2025         Update.
2026         * stack.c (print_frame, print_frame_info): Update.
2027         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2028         Update.
2029         * source.c (print_source_lines_base): Update.
2030         * skip.c (info_skip_command): Update.
2031         * record-btrace.c (btrace_ui_out_decode_error)
2032         (btrace_call_history_src_line): Update.
2033         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2034         Update.
2035         * progspace.c (print_program_space): Update.
2036         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2037         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2038         do_field_int.  Change type of "value".
2039         * mi/mi-out.c (mi_ui_out::do_table_begin)
2040         (mi_ui_out::do_table_header): Update.
2041         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2042         type of "value".
2043         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2044         (mi_cmd_data_list_changed_registers, output_register)
2045         (mi_cmd_data_read_memory, mi_load_progress)
2046         (mi_cmd_trace_frame_collected): Update.
2047         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2048         Update.
2049         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2050         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2051         (mi_cmd_var_list_children, varobj_update_one): Update.
2052         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2053         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2054         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2055         * inferior.c (print_inferior): Update.
2056         * gdb_bfd.c (print_one_bfd): Update.
2057         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2058         Update.
2059         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2060         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2061         do_field_int.  Change type of "value".
2062         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2063         do_field_int.  Change type of "value".
2064         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2065         (print_one_breakpoint_location, print_it_catch_fork)
2066         (print_one_catch_fork, print_it_catch_vfork)
2067         (print_one_catch_vfork, print_it_catch_solib)
2068         (print_it_catch_exec, print_it_ranged_breakpoint)
2069         (print_mention_watchpoint, print_mention_masked_watchpoint)
2070         (bkpt_print_it, update_static_tracepoint): Update.
2071         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2072         * break-catch-syscall.c (print_it_catch_syscall): Update.
2073         * ada-tasks.c (print_ada_task_info): Update.
2074         * ada-lang.c (print_it_exception, print_mention_exception):
2075         Update.
2076
2077 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2078
2079         PR breakpoints/24541
2080         * gdbarch.c: Regenerate.
2081         * gdbarch.h: Regenerate.
2082         * gdbarch.sh: Adjust return type and parameter types for
2083         'stap_adjust_register'.
2084         (i386_stap_adjust_register): Adjust signature and return new
2085         register name.
2086         * stap-probe.c (stap_parse_register_operand): Adjust use of
2087         'gdbarch_stap_adjust_register'.
2088
2089 2019-07-17  Tom Tromey  <tromey@adacore.com>
2090
2091         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2092         declare VEC.
2093         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2094         std::vector.
2095         (struct s390_process_info): Add initializers.
2096         (s390_add_process): Use new.
2097         (s390_linux_nat_target::low_forget_process): Use delete.
2098         (s390_linux_nat_target::low_new_fork)
2099         (s390_linux_nat_target::stopped_by_watchpoint)
2100         (s390_linux_nat_target::low_prepare_to_resume)
2101         (s390_linux_nat_target::insert_watchpoint)
2102         (s390_linux_nat_target::insert_hw_breakpoint)
2103         (s390_linux_nat_target::remove_watchpoint)
2104         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2105
2106 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2107
2108         * aarch64-fbsd-nat.c: Include regcache.h.
2109         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2110         argument.
2111         (aarch64_fbsd_nat_target::fetch_registers)
2112         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2113         variable.
2114         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2115
2116 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2117
2118         * fbsd-nat.c: Include gdbarch.h.
2119
2120 2019-07-15  Tom Tromey  <tromey@adacore.com>
2121
2122         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2123
2124 2019-07-15  Tom Tromey  <tromey@adacore.com>
2125
2126         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2127         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2128         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2129         * cli-out.c (cli_ui_out::do_field_int): New method.
2130         * ui-out.c (ui_out::field_unsigned): New method.
2131         * symfile.c (generic_load): Use field_unsigned.
2132         (print_transfer_performance): Likewise.
2133         * record-btrace.c (ui_out_field_uint): Remove.
2134         (btrace_call_history_insn_range, btrace_call_history): Use
2135         field_unsigned.
2136         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2137         field_unsigned.
2138         * ui-out.h (class ui_out) <field_unsigned>: New method.
2139         <do_field_unsigned>: Likewise.
2140
2141 2019-07-15  Tom Tromey  <tromey@adacore.com>
2142
2143         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2144         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2145         * target.c (flash_erase_command): Use field_string.
2146         * infrun.c (print_signal_received_reason): Use field_string.
2147         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2148         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2149         field_string.
2150         * ada-tasks.c (print_ada_task_info): Use field_string.
2151
2152 2019-07-15  Tom Tromey  <tromey@adacore.com>
2153
2154         * target.c (flash_erase_command): Use field_core_addr.
2155         * symfile.c (generic_load): Use field_core_addr.
2156         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2157         Use field_core_addr.
2158         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2159         field_core_addr.
2160
2161 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2162
2163         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2164         value if its desired type is smaller than a CORE_ADDR and signed.
2165
2166 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2169         of changes to field names, and use new is_reference field to
2170         decide if a property is a reference or not.
2171         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2172         field.
2173         (struct dwarf2_property_baton): Update header comment, rename
2174         'referenced_type' to 'property_type' and update comments.
2175         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2176         default property type, store in property baton, update to take
2177         accound of renamed field.
2178         (read_func_scope): Update call to attr_to_dynamic_prop.
2179         (read_array_type): Likewise.
2180         (dwarf2_per_cu_addr_sized_int_type): New function.
2181         (read_subrange_index_type): Move type finding code to
2182         dwarf2_per_cu_addr_sized_int_type.
2183         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2184         (dwarf2_per_cu_addr_type): New function.
2185         (set_die_type): Update calls to attr_to_dynamic_prop.
2186
2187 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2188
2189         * dwarf2read.c (read_subrange_index_type): New function.
2190         (read_subrange_type): Move code into new function and call it.
2191         * gdbtypes.c (create_range_type): Add some asserts.
2192
2193 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2194
2195         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2196         update return statements.
2197         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2198         declaration, and update comment to match.
2199         * gdbtypes.c (resolve_dynamic_array): Update call to
2200         dwarf2_evaluate_property to match new return type.
2201
2202 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * valarith.c (value_subscripted_rvalue): Change lowerbound
2205         parameter type from int to LONGEST.
2206         * value.h (value_subscripted_rvalue): Likewise in declaration.
2207
2208 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2209
2210         * cli/cli-utils.c (info_print_command_completer): New function.
2211         * cli/cli-utils.h: Add 'completer.h' include, and forward
2212         declaration for 'struct cmd_list_element'.
2213         (info_print_command_completer): Declare.
2214         * stack.c (_initialize_stack): Add completer for 'info locals' and
2215         'info args'.
2216         * symtab.c (_initialize_symtab): Add completer for 'info
2217         variables' and 'info functions'.
2218         * NEWS: Mention completion for additional info commands.
2219
2220 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2221
2222         * cli/cli-utils.c (extract_info_print_args): Delete.
2223         (extract_arg_maybe_quoted): Delete.
2224         (info_print_options_defs): New variable.
2225         (make_info_print_options_def_group): New function.
2226         (extract_info_print_options): Define new function.
2227         * cli/cli-utils.h (extract_info_print_args): Delete.
2228         (struct info_print_options): New structure.
2229         (extract_info_print_options): Declare new function.
2230         * stack.c (info_locals_command): Update to use new
2231         extract_info_print_options, also add a header comment.
2232         (info_args_command): Likewise.
2233         * symtab.c (info_variables_command): Likewise.
2234         (info_functions_command): Likewise.
2235
2236 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2239         to extract string arguments.
2240         * common/common-utils.c (extract_string_maybe_quoted): New function.
2241         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2242
2243 2019-07-11  Tom Tromey  <tromey@adacore.com>
2244
2245         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2246         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2247         * top.h (gdbinit): Don't declare.
2248         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2249         into...
2250         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2251         * top.c (gdb_init): Don't call init_cli_cmds.
2252         (gdbinit): Remove.
2253         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2254
2255 2019-07-11  Tom Tromey  <tromey@adacore.com>
2256
2257         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2258         after it has been moved.
2259
2260 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2261
2262         * valops.c (value_must_coerce_to_target): Change return type to
2263         bool.
2264         * value.h (value_must_coerce_to_target): Likewise.
2265
2266 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2267
2268         * breakpoint.c (is_hardware_watchpoint): Remove
2269         forward-declaration.
2270         (is_masked_watchpoint): Change return type to bool.
2271         (is_tracepoint): Likewise.
2272         (is_breakpoint): Likewise.
2273         (is_hardware_watchpoint): Likewise.
2274         (is_watchpoint): Likewise.
2275         (is_no_memory_software_watchpoint): Likewise.
2276         (is_catchpoint): Likewise.
2277         (breakpoint_1): Make FILTER parameter's return type bool.
2278         is_masked_watchpoint): Change return type to bool.
2279         (save_breakpoints): Make FILTER parameter's return type bool.
2280         * breakpoint.h (is_breakpoint): Change return type to bool.
2281         (is_watchpoint): Likewise.
2282         (is_catchpoint): Likewise.
2283         (is_tracepoint): Likewise.
2284
2285 2019-07-10  Tom Tromey  <tom@tromey.com>
2286
2287         * defs.h: Don't include gdbarch.h.
2288         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2289         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2290         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2291         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2292         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2293         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2294         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2295         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2296         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2297         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2298         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2299         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2300         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2301         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2302         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2303         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2304         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2305         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2306         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2307         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2308         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2309         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2310         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2311         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2312         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2313         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2314         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2315
2316 2019-07-10  Tom Tromey  <tromey@adacore.com>
2317
2318         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2319         * breakpoint.c (init_ada_exception_breakpoint): Register as
2320         bp_catchpoint.
2321         (print_one_breakpoint_location, print_one_breakpoint): Use
2322         is_ada_exception_catchpoint.
2323         * ada-lang.c (class ada_catchpoint_location): Pass
2324         bp_loc_software_breakpoint to bp_location constructor.
2325         (is_ada_exception_catchpoint): New function.
2326
2327 2019-07-10  Tom Tromey  <tromey@adacore.com>
2328
2329         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2330         VEC.
2331         (struct arm_exidx_entry): New method operator<.
2332         (struct arm_exidx_data) <section_maps>: Change type.
2333         (arm_exidx_data_free): Remove.
2334         (arm_exidx_data_key): Change type.  Move lower.
2335         (arm_exidx_new_objfile): Update.
2336         (arm_compare_exidx_entries): Remove.
2337         (arm_find_exidx_entry, _initialize_arm_tdep)
2338
2339 2019-07-10  Tom Tromey  <tromey@adacore.com>
2340
2341         * solib-spu.c (ocl_program_data_key): Change type.
2342         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2343         Update.
2344
2345 2019-07-10  Tom Tromey  <tromey@adacore.com>
2346
2347         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2348         (struct solib_aix_inferior_data) <library_list>: Change type.
2349         (solib_aix_inferior_data_handle): Change type.
2350         (get_solib_aix_inferior_data): Update.
2351         (solib_aix_free_library_list): Remove.
2352         (library_list_start_library): Update.
2353         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2354         return type.
2355         (solib_aix_get_library_list)
2356         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2357         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2358
2359 2019-07-10  Tom Tromey  <tromey@adacore.com>
2360
2361         * solib-dsbt.c (struct dsbt_info): Add initializers.
2362         (solib_dsbt_pspace_data): Change type.
2363         (dsbt_pspace_data_cleanup): Remove.
2364         (get_dsbt_info, _initialize_dsbt_solib): Update.
2365
2366 2019-07-10  Tom Tromey  <tromey@adacore.com>
2367
2368         * spu-tdep.c (spu_overlay_data): Change type.
2369         (spu_get_overlay_table, spu_overlay_new_objfile)
2370         (_initialize_spu_tdep): Update.
2371
2372 2019-07-10  Tom Tromey  <tromey@adacore.com>
2373
2374         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2375         destructor.
2376         (dbx_objfile_data_key): Change type and declare later.
2377         (DBX_SYMFILE_INFO): Rewrite.
2378         * dbxread.c (dbx_objfile_data_key): Change type.
2379         (dbx_symfile_init): Update.
2380         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2381         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2382         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2383
2384 2019-07-10  Tom Tromey  <tromey@adacore.com>
2385
2386         * jit.c (jit_program_space_key): Change type.  Move lower.
2387         (get_jit_program_space_data): Update.
2388         (jit_program_space_data_cleanup): Remove.
2389         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2390         Update.
2391         (struct jit_program_space_data): Add initializers.
2392
2393 2019-07-10  Tom Tromey  <tromey@adacore.com>
2394
2395         * solib-darwin.c (struct darwin_info): Add initializers.
2396         (solib_darwin_pspace_data): Change type.
2397         (darwin_pspace_data_cleanup): Remove.
2398         (get_darwin_info, _initialize_darwin_solib): Update.
2399
2400 2019-07-10  Tom Tromey  <tromey@adacore.com>
2401
2402         * remote-sim.c (struct sim_inferior_data): Add initializers,
2403         constructor, and destructor.
2404         (sim_inferior_data_key): Change type.  Move lower.
2405         (check_for_duplicate_sim_descriptor): Update.
2406         (get_sim_inferior_data): Use new.  Update.
2407         (~sim_inferior_data_cleanup): Rename from
2408         sim_inferior_data_cleanup.  Simplify.
2409         (gdbsim_close_inferior, simulator_command)
2410         (sim_command_completer, _initialize_remote_sim): Update.
2411         (next_pid, INITIAL_PID): Move earlier.
2412
2413 2019-07-10  Tom Tromey  <tromey@adacore.com>
2414
2415         * python/python-internal.h (create_thread_object): Return
2416         gdbpy_ref.
2417         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2418         * python/py-inferior.c (struct threadlist_entry): Add
2419         constructor.
2420         <thread_obj>: Now a gdbpy_ref.
2421         (thread_to_thread_object): Update.
2422         (add_thread_object): Use new.
2423         (delete_thread_object): Use delete.
2424         (infpy_threads): Update.
2425         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2426         GIL.
2427
2428 2019-07-10  Tom Tromey  <tromey@adacore.com>
2429
2430         * valops.c (value_cast): Specialize error message for Ada.
2431
2432 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2433
2434         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2435
2436 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2437
2438         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2439         bpstat_should_step): Return bool, adjust comments.
2440         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2441         bpstat_should_step): Likewise.
2442
2443 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2444
2445         * features/Makefile: Use feature target descriptions for Arm.
2446         * features/arm/arm-core.c: Generate new file.
2447         * features/arm/arm-fpa.c: Likewise.
2448         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2449         * features/arm/arm-m-profile.c: Likewise.
2450         * features/arm/arm-vfpv2.c: Likewise.
2451         * features/arm/arm-vfpv3.c: Likewise.
2452         * features/arm/xscale-iwmmxt.c: Likewise.
2453         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2454
2455 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2456
2457         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2458         ptrace earlier.
2459
2460 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2461
2462         * features/aarch64-pauth.c: Regenerate.
2463
2464 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2465
2466         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2467         bool.
2468         (bpstat_what): Use false instead of 0.
2469
2470 2019-07-09  Pedro Alves  <palves@redhat.com>
2471
2472         * break-catch-throw.c (is_exception_catchpoint): New.
2473         * breakpoint.c (print_one_breakpoint_location): New parameter
2474         'raw_loc'.  Handle it.  Use
2475         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2476         looking at the breakpoint's type.
2477         (print_one_breakpoint): If handling "maint info breakpoints", also
2478         print locations of exception catchpoints.
2479         * breakpoint.h (is_exception_catchpoint): Declare.
2480
2481 2019-07-09  Pedro Alves  <palves@redhat.com>
2482
2483         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2484         "addr" field.
2485         (allocate_location_exception_catchpoint): New.
2486         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2487         (initialize_throw_catchpoint_ops): Install
2488         allocate_location_exception_catchpoint as allocate_location
2489         method.
2490         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2491         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2492         bp_loc_other.
2493         (breakpoint_address_is_meaningful): Delete.
2494         (bl_address_is_meaningful): New.
2495         (breakpoint_locations_match): Adjust comment.
2496         (bp_location_from_bp_type): New, factored out of...
2497         (bp_location::bp_location(breakpoint *)): ... this.
2498         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2499         factored out of...
2500         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2501         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2502         breakpoint_address_is_meaningful.
2503         (bp_locations_compare): Adjust comment.
2504         (update_global_location_list): Use bl_address_is_meaningful
2505         instead of breakpoint_address_is_meaningful.
2506         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2507         explicit.
2508         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2509         * python/py-breakpoint.c (bppy_get_location): No longer check
2510         whether location is null.
2511
2512 2019-07-09  Pedro Alves  <palves@redhat.com>
2513
2514         PR c++/15468
2515         * breakpoint.c (print_one_breakpoint_location): Remove
2516         single-location assert.
2517
2518 2019-07-09  Tom Tromey  <tom@tromey.com>
2519
2520         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2521         * configure: Rebuild.
2522         * configure.ac: Change common to gdbsupport.
2523         * gdbsupport: Rename from common.
2524         * acinclude.m4: Change common to gdbsupport.
2525         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2526         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2527         gdbsupport.
2528         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2529         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2530         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2531         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2532         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2533         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2534         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2535         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2536         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2537         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2538         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2539         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2540         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2541         coff-pe-read.c, command.h, compile/compile-c-support.c,
2542         compile/compile-c.h, compile/compile-cplus-symbols.c,
2543         compile/compile-cplus-types.c, compile/compile-cplus.h,
2544         compile/compile-loc2c.c, compile/compile.c, completer.c,
2545         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2546         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2547         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2548         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2549         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2550         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2551         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2552         features/aarch64-core.c, features/aarch64-fpu.c,
2553         features/aarch64-pauth.c, features/aarch64-sve.c,
2554         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2555         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2556         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2557         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2558         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2559         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2560         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2561         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2562         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2563         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2564         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2565         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2566         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2567         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2568         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2569         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2570         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2571         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2572         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2573         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2574         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2575         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2576         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2577         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2578         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2579         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2580         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2581         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2582         minsyms.c, mips-linux-tdep.c, namespace.h,
2583         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2584         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2585         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2586         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2587         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2588         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2589         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2590         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2591         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2592         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2593         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2594         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2595         procfs.c, producer.c, progspace.h, psymtab.h,
2596         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2597         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2598         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2599         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2600         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2601         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2602         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2603         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2604         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2605         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2606         target-memory.c, target.c, target.h, target/waitstatus.c,
2607         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2608         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2609         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2610         unittests/array-view-selftests.c,
2611         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2612         unittests/common-utils-selftests.c,
2613         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2614         unittests/format_pieces-selftests.c,
2615         unittests/function-view-selftests.c,
2616         unittests/lookup_name_info-selftests.c,
2617         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2618         unittests/mkdir-recursive-selftests.c,
2619         unittests/observable-selftests.c,
2620         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2621         unittests/parse-connection-spec-selftests.c,
2622         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2623         unittests/scoped_fd-selftests.c,
2624         unittests/scoped_mmap-selftests.c,
2625         unittests/scoped_restore-selftests.c,
2626         unittests/string_view-selftests.c, unittests/style-selftests.c,
2627         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2628         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2629         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2630         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2631         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2632         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2633
2634 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2635
2636         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2637         bool value.
2638         (decode_digits_ordinary): Set explicit_line field in sal.
2639         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2640         symtab_and_line that was set on an explicit line number in
2641         assembler code.  Do always update the recorded symtab and line if
2642         we do skip the prologue.
2643
2644 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2645
2646         * breakpoint.c (set_breakpoint_location_function): Remove
2647         explicit_loc parameter.
2648         (momentary_breakpoint_from_master): Update call to
2649         set_breakpoint_location_function.
2650         (add_location_to_breakpoint): Likewise.
2651
2652 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2653
2654         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2655         required features based on default bfd type when no specific bfd
2656         is present.
2657
2658 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2659
2660         * NEWS: Mention that GDB printf and eval commands can now print
2661         C-style and Ada-style convenience var strings without
2662         calling the inferior.
2663         * printcmd.c (printf_c_string): Locally print GDB internal var
2664         instead of transiting via the inferior.
2665         (printf_wide_c_string): Likewise.
2666
2667 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2668
2669         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2670
2671 2019-07-04  Tom Tromey  <tom@tromey.com>
2672
2673         PR tui/24724:
2674         * tui/tui-winsource.c (tui_clear_source_content): Update.
2675         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2676         (tui_update_breakpoint_info): Update.
2677         (tui_set_exec_info_content): Update.
2678         * tui/tui-source.c (tui_set_source_content_nil): Update.
2679         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2680         has_break.
2681         * tui/tui-data.h (enum tui_bp_flag): New.
2682         (tui_bp_flags): New enum flags type.
2683         (struct tui_source_element) <break_mode>: Change type.  Rename
2684         from has_break.
2685         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2686         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2687         constants.
2688         * tui/tui-winsource.h: Fix comment.
2689
2690 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2691
2692         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2693         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2694         (store_fpregs_to_thread)
2695         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2696         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2697         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2698         (IWMMXT_REGS_SIZE): Add define.
2699         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2700         (fetch_vfp_regs, store_vfp_regs)
2701         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2702         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2703
2704 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2705
2706         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2707         defines.
2708         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2709         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2710         (ARM_INT_REGISTER_SIZE): ...to this.
2711         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2712         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2713         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2714         (arm_linux_collect_gregset, supply_nwfpe_register)
2715         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2716         defines.
2717         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2718         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2719         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2720         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2721         (arm_return_in_memory, arm_store_return_value)
2722         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2723         (arm_record_ld_st_multiple): Likewise.
2724         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2725         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2726
2727 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2728
2729         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2730         AARCH64_DISPLACED_MODIFIED_INSNS.
2731         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2732         (aarch64_displaced_step_copy_insn): Likewise.
2733         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2734         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2735         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2736         ARM_DISPLACED_MODIFIED_INSNS.
2737         * arm-tdep.c (arm_gdbarch_init): Likewise.
2738         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2739         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2740         (struct arm_displaced_step_closure): Use
2741         ARM_DISPLACED_MODIFIED_INSNS.
2742
2743 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2744
2745         * features/Makefile: Remove unused xml files.
2746         * features/aarch64.xml: Remove.
2747         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2748         * features/i386/amd64-avx-avx512.xml: Remove.
2749         * features/i386/amd64-avx-linux.xml: Remove.
2750         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2751         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2752         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2753         * features/i386/amd64-avx-mpx.xml: Remove.
2754         * features/i386/amd64-avx.xml: Remove.
2755         * features/i386/amd64-linux.xml: Remove.
2756         * features/i386/amd64-mpx-linux.xml: Remove.
2757         * features/i386/amd64-mpx.xml: Remove.
2758         * features/i386/amd64.xml: Remove.
2759         * features/i386/i386-avx-avx512-linux.xml: Remove.
2760         * features/i386/i386-avx-avx512.xml: Remove.
2761         * features/i386/i386-avx-linux.xml: Remove.
2762         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2763         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2764         * features/i386/i386-avx-mpx-linux.xml: Remove.
2765         * features/i386/i386-avx-mpx.xml: Remove.
2766         * features/i386/i386-avx.xml: Remove.
2767         * features/i386/i386-linux.xml: Remove.
2768         * features/i386/i386-mmx-linux.xml: Remove.
2769         * features/i386/i386-mmx.xml: Remove.
2770         * features/i386/i386-mpx-linux.xml: Remove.
2771         * features/i386/i386-mpx.xml: Remove.
2772         * features/i386/i386.xml: Remove.
2773         * features/i386/x32-avx-avx512-linux.xml: Remove.
2774         * features/i386/x32-avx-linux.xml: Remove.
2775         * features/i386/x32-linux.xml: Remove.
2776
2777 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2778
2779         * regformats/aarch64.dat: Remove.
2780         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2781         * regformats/i386/amd64-avx-linux.dat: Remove.
2782         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2783         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2784         * regformats/i386/amd64-linux.dat: Remove.
2785         * regformats/i386/amd64-mpx-linux.dat: Remove.
2786         * regformats/i386/amd64.dat: Remove.
2787         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2788         * regformats/i386/i386-avx-linux.dat: Remove.
2789         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2790         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2791         * regformats/i386/i386-linux.dat: Remove.
2792         * regformats/i386/i386-mmx-linux.dat: Remove.
2793         * regformats/i386/i386-mpx-linux.dat: Remove.
2794         * regformats/i386/i386.dat: Remove.
2795         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2796         * regformats/i386/x32-avx-linux.dat: Remove.
2797         * regformats/i386/x32-linux.dat: Remove.
2798
2799 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2800
2801         * aarch64-tdep.c: Remove xml self tests.
2802         * amd64-linux-tdep.c: Likewise.
2803         * amd64-tdep.c: Likewise.
2804         * i386-linux-tdep.c: Likewise.
2805         * i386-tdep.c: Likewise.
2806
2807 2019-07-03  Pedro Alves  <palves@redhat.com>
2808
2809         PR cli/24732
2810         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2811         (pipe_cmd_option_defs): New.
2812         (make_pipe_cmd_options_def_group): New.
2813         (pipe_command): Use gdb::option::process_options.
2814         (pipe_command_completer): New function.
2815         (_initialize_cli_cmds): Install completer for "pipe" command.
2816
2817 2019-07-03  Pedro Alves  <palves@redhat.com>
2818
2819         * cli/cli-option.c (union option_value) <string>: New field.
2820         (struct option_def_and_value): Add ctor, move ctor, dtor and
2821         use DISABLE_COPY_AND_ASSIGN.
2822         (option_def_and_value::clear_value): New.
2823         (parse_option, save_option_value_in_ctx, get_val_type_str)
2824         (add_setshow_cmds_for_options): Handle var_string.
2825         * cli-option.h (union option_def::var_address) <string>: New
2826         field.
2827         (struct string_option_def): New.
2828         * maint-test-options.c (struct test_options_opts): Add default
2829         ctor and use DISABLE_COPY_AND_ASSIGN.
2830         <string_opt>: New field.
2831         (test_options_opts::~test_options_opts): New.
2832         (test_options_opts::dump): Also dump "-string".
2833         (test_options_option_defs): Install "string.
2834
2835 2019-07-03  Pedro Alves  <palves@redhat.com>
2836
2837         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2838         option_value with a null enumeration.
2839         (complete_options): Save the option values in the context.
2840         (save_option_value_in_ctx): New, factored out from ...
2841         (process_options): ... here.
2842         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2843         of the function.
2844         * maint-test-options.c (test_options_opts::dump): New, factored
2845         out from ...
2846         (maintenance_test_options_command_mode): ... here.
2847         (maintenance_test_options_command_completion_result): Delete.
2848         (maintenance_test_options_command_completion_text): Update
2849         comment.
2850         (maintenance_show_test_options_completion_result): Change
2851         prototype.  Just print
2852         maintenance_test_options_command_completion_text.
2853         (save_completion_result): New.
2854         (maintenance_test_options_completer_mode): Pass options context to
2855         complete_options, and then save a dump.
2856         (_initialize_maint_test_options): Use add_cmd to install "maint
2857         show test-options-completion-result".
2858
2859 2019-07-03  Pedro Alves  <palves@redhat.com>
2860
2861         * NEWS (New commands): Mention "with" and "maint with".
2862         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2863         (with_command, with_command_completer): New.
2864         (pipe_command): Adjust to new repeat_previous
2865         interface.
2866         (_initialize_cli_cmds): Install the "with" command and its "w"
2867         alias.
2868         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2869         declarations.
2870         * cli/cli-setshow.c (parse_cli_var_uinteger)
2871         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2872         argument strings for all var_types.
2873         (get_setshow_command_value_string): New, factored out from ...
2874         (do_show_command): ... this.
2875         * cli/cli-setshow.h: Include <string>.
2876         (get_setshow_command_value_string): Declare.
2877         * command.h (repeat_previous): Now returns const char *.  Adjust
2878         comment.
2879         * maint.c: Include "cli/cli-cmds.h".
2880         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2881         (_initialize_maint_cmds): Register the "maintenance with" command.
2882         * top.c (repeat_previous): Move bits from pipe_command here:
2883         Return the saved command line, if any; error out if there's no
2884         command to relaunch.
2885
2886 2019-07-03  Pedro Alves  <palves@redhat.com>
2887
2888         * NEWS (New commands): Mention "maint set/show test-settings"
2889         instead of "maint test-settings".
2890         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2891         (maintenance_test_settings_set_list): Rename to ...
2892         (maintenance_set_test_settings_list): ... this.
2893         (maintenance_test_settings_show_list): Rename to  ...
2894         (maintenance_show_test_settings_list): ... this.
2895         (maintenance_test_settings_cmd): Delete.
2896         (maintenance_test_settings_set_cmd): ...
2897         (maintenance_set_test_settings_cmd): ... this.
2898         (maintenance_test_settings_show_cmd): ...
2899         (maintenance_show_test_settings_cmd): ... this.
2900         (maintenance_test_settings_show_value_cmd):
2901         (maintenance_show_test_settings_value_cmd): ... this.
2902         (_initialize_maint_test_settings): No longer install the "maint
2903         test-settings" prefix command.  Rename "maint test-settings set"
2904         to "maint set test-settings", and "maint test-settings show" to
2905         "maint show test-settings".  Adjust all subcommands.
2906
2907 2019-07-03  Pedro Alves  <palves@redhat.com>
2908
2909         * maint-test-settings.c: Fix file's intro comment.  Replace all
2910         references to "test-options" with references to "test-settings",
2911         in comments.
2912
2913 2019-07-03  Pedro Alves  <palves@redhat.com>
2914
2915         * maint-test-settings.c (maintenance_test_settings_xxx)
2916         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2917         New.
2918         (maintenance_test_settings_enums): Use them.
2919         (maintenance_test_settings_enum): Default to
2920         maintenance_test_settings_xxx.
2921         (_initialize_maint_test_settings): Initialize
2922         MAINTENANCE_TEST_SETTINGS_FILENAME.
2923
2924 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2925
2926         * breakpoint.h (remove_breakpoints_inf): Change return type to
2927         void, move function documentation here.
2928         * breakpoint.c (remove_breakpoints_inf): Change return type to
2929         void, move function documentation to header.
2930
2931 2019-07-02  Pedro Alves  <palves@redhat.com>
2932
2933         * NEWS (Completion improvements): Mention "info threads".
2934         * thread.c (struct info_threads_opts, info_threads_option_defs)
2935         (make_info_threads_options_def_group): New.
2936         (info_threads_command): Use gdb::option::process_options.
2937         (info_threads_command_completer): New.
2938         (_initialize_thread): Use gdb::option::build_help to build the
2939         help text for "info threads".
2940
2941 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2942
2943         * defs.h (generic_load): Move from here...
2944         * symfile.h (generic_load): ... to here.  Rename name parameter
2945         to args.
2946         * symfile.c (generic_load): Add comment.
2947
2948 2019-07-01  Tom Tromey  <tromey@adacore.com>
2949
2950         * dwarf2read.c
2951         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2952         declaration of without_params.  Fix formatting.
2953
2954 2019-07-01  Tom Tromey  <tromey@adacore.com>
2955
2956         * ada-exp.y (find_primitive_type): Update.
2957         * ada-lang.h (ada_lookup_symbol): Update.
2958         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2959         parameter.
2960         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2961
2962 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2963
2964         PR breakpoints/24541
2965         * gdbarch.c: Regenerate.
2966         * gdbarch.h: Regenerate.
2967         * gdbarch.sh: Add 'stap_adjust_register'.
2968         * i386-tdep.c: Include '<unordered_set>'.
2969         (i386_stap_adjust_register): New function.
2970         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2971         * stap-probe.c (stap_parse_register_operand): Call
2972         'gdbarch_stap_adjust_register'.
2973
2974 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2975
2976         PR python/24742
2977         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2978         * python/python.c (do_start_initialization): Use 'xmalloc'
2979         instead of 'PyMem_Malloc'.
2980
2981 2019-06-28  Tom Tromey  <tromey@adacore.com>
2982
2983         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2984         for Ada.
2985
2986 2019-06-27  Tom Tromey  <tromey@adacore.com>
2987
2988         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2989         objfile_key.
2990         (arm_find_mapping_symbol, arm_record_special_symbol)
2991         (_initialize_arm_tdep): Update.
2992         (arm_objfile_data_free): Remove.
2993
2994 2019-06-27  Tom Tromey  <tromey@adacore.com>
2995
2996         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2997         to cp_print_static_field.
2998
2999 2019-06-26  Tom Tromey  <tromey@adacore.com>
3000
3001         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3002         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3003         declare.
3004
3005 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3006
3007         * features/aarch64-core.c (create_feature_aarch64_core):
3008         Regenerate.
3009         * features/aarch64-core.xml: Add cpsr flags.
3010
3011 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3012
3013         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3014         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3015
3016 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3017
3018         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3019         field.
3020         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3021         use.
3022         (arm_record_special_symbol): Don't insert new symbol in sorted
3023         position, push it at the end.
3024
3025 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3026
3027         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3028         (arm_mapping_symbol_s): Remove.
3029         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3030         (arm_mapping_symbol_vec): New typedef.
3031         (struct arm_per_objfile): Add constructor.
3032         <section_maps>: Change type to
3033         std::unique_ptr<arm_mapping_symbol_vec[]>.
3034         (arm_compare_mapping_symbols): Remove.
3035         (arm_find_mapping_symbol): Adjust to section_maps type change.
3036         (arm_objfile_data_free): Call delete on arm_per_objfile.
3037         (arm_record_special_symbol): Adjust to section_maps type change.
3038         Allocate arm_per_objfile with new.
3039
3040 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3041
3042         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3043         with the command prefix.
3044
3045 2019-06-25  Tom Tromey  <tom@tromey.com>
3046
3047         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3048         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3049
3050 2019-06-25  Tom Tromey  <tom@tromey.com>
3051
3052         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3053         type.
3054         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3055         protected.
3056
3057 2019-06-25  Tom Tromey  <tom@tromey.com>
3058
3059         * tui/tui-winsource.c
3060         (tui_source_window_base::set_is_exec_point_at): Add check against
3061         LOA_ADDRESS.
3062
3063 2019-06-25  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-source.c (tui_set_source_content): Don't check before
3066         xfree.
3067         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3068
3069 2019-06-25  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-winsource.h (tui_update_source_window_as_is)
3072         (tui_alloc_source_buffer, tui_line_is_displayed)
3073         (tui_addr_is_displayed): Change type of win_info.
3074         * tui/tui-winsource.c (tui_update_source_window_as_is)
3075         (tui_clear_source_content, tui_show_source_line)
3076         (tui_show_source_content, tui_source_window_base::refill)
3077         (tui_source_window_base::set_is_exec_point_at)
3078         (tui_source_window_base::set_is_exec_point_at)
3079         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3080         (tui_alloc_source_buffer, tui_line_is_displayed)
3081         (tui_addr_is_displayed): Change type of win_info.  Update.
3082         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3083         (tui_source_window_base::do_make_visible_with_new_height):
3084         Update.
3085         * tui/tui-source.c (tui_set_source_content)
3086         (tui_set_source_content_nil)
3087         (tui_source_window::do_scroll_vertical): Update.
3088         * tui/tui-layout.c (show_layout): Update.
3089         * tui/tui-disasm.c (tui_set_disassem_content)
3090         (tui_disasm_window::do_scroll_vertical): Update.
3091         * tui/tui-data.h (tui_win_content): Remove.
3092         (struct tui_gen_win_info) <content, content_size>: Remove.
3093         (struct tui_source_element): Add initializers and destructor.
3094         (union tui_which_element, struct tui_win_element): Remove.
3095         (struct tui_source_window_base) <content>: New field.
3096         (struct tui_data_window): Remove destructor.
3097         (tui_alloc_content, tui_free_win_content)
3098         (tui_free_all_source_wins_content): Don't declare.
3099         * tui/tui-data.c (tui_initialize_static_data): Update.
3100         (init_content_element, tui_alloc_content): Remove.
3101         (~tui_gen_win_info): Update.
3102         (~tui_data_window, tui_free_all_source_wins_content)
3103         (tui_free_win_content, free_content, free_content_elements):
3104         Remove.
3105
3106 2019-06-25  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui-winsource.h (tui_clear_source_content)
3109         (tui_erase_source_content, tui_show_source_content): Change type
3110         of win_info.
3111         * tui/tui-winsource.c (tui_clear_source_content)
3112         (tui_erase_source_content, tui_show_source_content): Change type
3113         of win_info.
3114         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3115         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3116         win_info.
3117         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3118         win_info.
3119         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3120
3121 2019-06-25  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-winsource.c (tui_clear_source_content)
3124         (tui_source_window_base::set_is_exec_point_at): Update.
3125         * tui/tui-source.c (tui_set_source_content_nil): Update.
3126         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3127         a bool.
3128         * tui/tui-data.c (init_content_element): Update.
3129
3130 2019-06-25  Tom Tromey  <tom@tromey.com>
3131
3132         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3133         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3134         * tui/tui-layout.c (init_and_make_win): Update.
3135         * tui/tui.h (enum tui_win_type): Update.
3136         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3137         tui_win_is_auxillary.
3138         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3139         tui_win_is_auxillary.
3140
3141 2019-06-25  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3144         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3145         (tui_delete_data_content_windows, tui_display_all_data)
3146         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3147         Update.
3148         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3149         * tui/tui-regs.c (tui_last_regs_line_no)
3150         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3151         (tui_show_registers): Update.
3152         (tui_show_register_group): Return void.  Update.
3153         (tui_display_registers_from, tui_display_reg_element_at_line)
3154         (tui_display_registers_from_line, tui_check_register_values):
3155         Update.
3156         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3157         member.
3158         (struct tui_data_window) <regs_content>: Now a std::vector.
3159         <regs_content_count>: Remove.
3160         (tui_add_content_elements, tui_free_data_content): Don't declare.
3161         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3162         (init_content_element): Remove DATA_WIN case.  Add assert.
3163         (tui_add_content_elements): Remove.
3164         (tui_data_window): Update.
3165         (tui_free_data_content): Remove.
3166         (free_content_elements): Remove DATA_WIN case.
3167
3168 2019-06-25  Tom Tromey  <tom@tromey.com>
3169
3170         * tui/tui-data.c (tui_data_item_window): Update.
3171         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3172         * tui/tui-windata.c (tui_display_all_data)
3173         (tui_display_data_from_line): Update.
3174         (tui_check_data_values): Remove.
3175         * tui/tui-regs.c (tui_show_register_group)
3176         (tui_display_reg_element_at_line): Update.
3177         * tui/tui-hooks.c (tui_register_changed)
3178         (tui_refresh_frame_and_register_information): Call
3179         tui_check_register_values.
3180         * tui/tui-data.h (struct tui_data_window) <data_content,
3181         data_content_count, data_type>: Remove.
3182         (enum tui_data_type): Remove.
3183
3184         * tui/tui-data.c (tui_data_window::clear_detail)
3185         (~tui_data_window): Update.
3186
3187 2019-06-25  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3190         declare.
3191         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3192         Rename from tui_first_data_item_displayed.  Update.
3193         (tui_data_window::refresh_all)
3194         (tui_data_window::do_scroll_vertical): Update.
3195         * tui/tui-data.h (struct tui_data_window)
3196         <first_data_item_displayed>: Declare new method.
3197
3198 2019-06-25  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3201         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3202         contents...
3203         (tui_initialize_static_data): ...here.
3204
3205 2019-06-25  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3208         (tui_display_registers_from, tui_check_register_values): Update.
3209         (tui_display_register): Remove win_info parameter; update.
3210         (tui_get_register): Change type of parameters.
3211         * tui/tui-data.h (struct tui_data_element): Remove.
3212         (union tui_which_element) <data>: Remove.
3213         <data_window>: Change type.
3214         (struct tui_data_item_window): New.
3215         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3216         case.  Add assert.
3217         (~tui_data_item_window): New destructor.
3218         (free_content_elements): Remove DATA_ITEM_WIN case.
3219
3220 2019-06-25  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3223         Remove.
3224
3225 2019-06-25  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-data.h (struct tui_command_element): Remove.
3228         (union tui_which_element) <command>: Remove.
3229         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3230         assert.
3231         (free_content_elements): Remove CMD_WIN case.
3232
3233 2019-06-25  Tom Tromey  <tom@tromey.com>
3234
3235         * tui/tui-layout.c (tui_set_layout): Update.
3236         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3237         * tui/tui-data.c (layout_def): Update.
3238
3239 2019-06-25  Tom Tromey  <tom@tromey.com>
3240
3241         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3242         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3243         (tui_source_window_base::set_new_height): Update.
3244         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3245         Update.
3246         (tui_set_locator_fullname, tui_set_locator_info)
3247         (tui_show_frame_info): Update.
3248         * tui/tui-source.c (tui_set_source_content)
3249         (tui_source_is_displayed): Update.
3250         * tui/tui-layout.c (show_source_disasm_command, show_data)
3251         (show_source_or_disasm_and_command): Update.
3252         * tui/tui-disasm.c (tui_set_disassem_content)
3253         (tui_get_begin_asm_address): Update.
3254         * tui/tui-data.h (struct tui_locator_element): Remove.
3255         (union tui_which_element) <locator>: Remove.
3256         (struct tui_locator_window): New.
3257         (tui_locator_win_info_ptr): Change return type.
3258         * tui/tui-data.c (_locator): Change type.
3259         (tui_locator_win_info_ptr): Change return type.
3260         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3261         (tui_alloc_content): Add assert.
3262
3263 2019-06-25  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-winsource.c
3266         (tui_exec_info_window::maybe_allocate_content): New method.
3267         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3268         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3269         (make_source_or_disasm_window): Add cast.
3270         * tui/tui-data.h (union tui_which_element) <simple_string>:
3271         Remove.
3272         (struct tui_source_info): New.
3273         (struct tui_source_window_base) <execution_info>: Change type.
3274         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3275         case, and add assert.
3276         (tui_alloc_content): Add assert.
3277
3278 2019-06-25  Tom Tromey  <tom@tromey.com>
3279
3280         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3281         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3282         * tui/tui-data.c (tui_alloc_win_info): Remove.
3283
3284 2019-06-25  Tom Tromey  <tom@tromey.com>
3285
3286         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3287         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3288         can_highlight.
3289
3290 2019-06-25  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3293         make_visible_with_new_height method.
3294         (tui_win_info::make_visible_with_new_height): New method.
3295         (tui_source_window_base::do_make_visible_with_new_height)
3296         (tui_data_window::do_make_visible_with_new_height)
3297         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3298         (make_visible_with_new_height): Remove.
3299         (tui_resize_all, tui_adjust_win_heights): Use
3300         make_visible_with_new_height method.
3301         * tui/tui-data.h (struct tui_win_info)
3302         <do_make_visible_with_new_height, make_visible_with_new_height>:
3303         New methods.
3304         (struct tui_source_window_base, struct tui_data_window)
3305         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3306         methods.
3307
3308 2019-06-25  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3311         method.
3312         (update_tab_width): Call update_tab_width method.
3313         * tui/tui-data.h (struct tui_win_info)
3314         (struct tui_source_window_base) <update_tab_width>: New methods.
3315
3316 2019-06-25  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3319         parameter.
3320         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3321         parameter.
3322         (tui_gen_win_info::make_visible): Update.
3323         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3324         parameter.
3325         * tui/tui-data.h (enum tui_box): New enum.
3326         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3327
3328 2019-06-25  Tom Tromey  <tom@tromey.com>
3329
3330         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3331         init_and_make_win for EXEC_INFO_WIN.
3332         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3333         longer inline.
3334         (struct tui_win_info) <~tui_win_info>: Inline.
3335         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3336         Don't declare.
3337         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3338         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3339         Remove.
3340         (tui_initialize_static_data): Update.
3341         (~tui_gen_win_info): Handle more cleanup here.
3342         (~tui_source_window_base): Delete "execution_info".
3343         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3344
3345 2019-06-25  Tom Tromey  <tom@tromey.com>
3346
3347         * tui/tui-layout.c (make_command_window): Don't set
3348         can_highlight.
3349         (show_source_disasm_command): Call the reset method.
3350         (show_data): Don't set can_highlight.  Call the reset method.
3351         (tui_gen_win_info::reset): Rename from init_gen_win_info
3352         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3353         (show_source_or_disasm_and_command): Call the reset method.
3354         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3355         (struct tui_cmd_window): Set can_highlight.
3356
3357 2019-06-25  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3360         from make_visible.
3361         (tui_make_visible, tui_make_invisible): Rewrite.
3362         (tui_win_info::make_visible): Remove.
3363         (tui_source_window_base::make_visible): Update.
3364         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3365         method.  Moved from...
3366         (struct tui_win_info) <make_visible>: ...here.
3367
3368 2019-06-25  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-winsource.c
3371         (tui_source_window_base::do_scroll_horizontal): Remove direction
3372         parameter.
3373         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3374         direction parameter.
3375         * tui/tui-win.c (tui_win_info::forward_scroll)
3376         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3377         (tui_win_info::right_scroll): Update.
3378         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3379         direction parameter.
3380         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3381         direction parameter.
3382         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3383         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3384         Remove direction parameter.
3385         (struct tui_source_window_base, struct tui_source_window)
3386         (struct tui_disasm_window, struct tui_data_window)
3387         (struct tui_cmd_window): Update.
3388
3389 2019-06-25  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-winsource.h (tui_set_exec_info_content)
3392         (tui_show_exec_info_content, tui_erase_exec_info_content)
3393         (tui_clear_exec_info_content, tui_update_exec_info): Change
3394         argument to tui_source_window_base.
3395         * tui/tui-winsource.c (tui_set_exec_info_content)
3396         (tui_show_exec_info_content, tui_erase_exec_info_content)
3397         (tui_clear_exec_info_content, tui_update_exec_info): Change
3398         argument to tui_source_window_base.
3399
3400 2019-06-25  Tom Tromey  <tom@tromey.com>
3401
3402         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3403         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3404
3405 2019-06-25  Tom Tromey  <tom@tromey.com>
3406
3407         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3408         check.
3409
3410 2019-06-25  Tom Tromey  <tom@tromey.com>
3411
3412         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3413         type to void.
3414         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3415         type to void.
3416         * tui/tui-source.c (tui_set_source_content): Update.
3417         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-win.c (window_name_completer, tui_set_focus)
3422         (tui_all_windows_info): Use name method.
3423         * tui/tui-data.h (struct tui_gen_win_info)
3424         (struct tui_source_window, struct tui_disasm_window)
3425         (struct tui_data_window, struct tui_cmd_window) <name>: New
3426         method.
3427         (tui_win_name): Don't declare.
3428         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3429         (tui_win_name): Remove.
3430
3431 2019-06-25  Tom Tromey  <tom@tromey.com>
3432
3433         * tui/tui-winsource.h (tui_update_source_window)
3434         (tui_update_source_window_as_is): Change parameter type.
3435         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3436         to be a tui_source_window_base.
3437         (tui_update_source_window_as_is): Likewise.
3438         * tui/tui-win.c (make_visible_with_new_height): Update.
3439
3440 2019-06-25  Tom Tromey  <tom@tromey.com>
3441
3442         * tui/tui-winsource.c (tui_erase_source_content)
3443         (tui_show_source_content, tui_show_exec_info_content)
3444         (tui_erase_exec_info_content): Use refresh_window method.
3445         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3446         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3447         from tui_refresh_win.
3448         (tui_data_window::refresh_window): New method.
3449         (tui_win_info::refresh, tui_source_window_base::refresh)
3450         (tui_refresh_all): Use refresh_window method.
3451         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3452         method.
3453         * tui/tui-regs.c (tui_display_register): Call refresh_window
3454         method.
3455         * tui/tui-layout.c (show_source_disasm_command)
3456         (show_source_or_disasm_and_command): Call refresh_window method.
3457         * tui/tui-data.h (struct tui_gen_win_info)
3458         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3459         New method.
3460
3461 2019-06-25  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui.c (tui_rl_other_window, tui_enable)
3464         (tui_is_window_visible, tui_get_command_dimension): Update.
3465         * tui/tui-winsource.c (tui_update_source_window_as_is)
3466         (tui_clear_source_content, tui_erase_source_content)
3467         (tui_show_source_line, tui_source_window_base::refill)
3468         (tui_source_window_base::do_scroll_horizontal)
3469         (tui_source_window_base::set_is_exec_point_at)
3470         (tui_update_breakpoint_info, tui_set_exec_info_content)
3471         (tui_alloc_source_buffer, tui_line_is_displayed)
3472         (tui_addr_is_displayed): Update.
3473         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3474         (tui_check_and_display_highlight_if_needed)
3475         (tui_win_info::make_visible, tui_win_info::refresh)
3476         (tui_refresh_all): Update.
3477         * tui/tui-windata.c (tui_first_data_item_displayed)
3478         (tui_delete_data_content_windows, tui_erase_data_content)
3479         (tui_display_all_data, tui_data_window::refresh_all)
3480         (tui_check_data_values): Update.
3481         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3482         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3483         (tui_win_info::backward_scroll, tui_refresh_all_win)
3484         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3485         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3486         (tui_source_window_base::set_new_height)
3487         (tui_data_window::set_new_height)
3488         (make_invisible_and_set_new_height)
3489         (make_visible_with_new_height, new_height_ok)
3490         (parse_scrolling_args): Update.
3491         * tui/tui-stack.c (tui_show_frame_info): Update.
3492         * tui/tui-source.c (tui_set_source_content)
3493         (tui_set_source_content_nil, tui_source_is_displayed)
3494         (tui_source_window::do_scroll_vertical): Update.
3495         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3496         (tui_display_registers_from, tui_display_reg_element_at_line)
3497         (tui_check_register_values, tui_reg_command): Update.
3498         * tui/tui-layout.c (tui_default_win_height)
3499         (show_source_disasm_command, show_data, init_and_make_win)
3500         (show_source_or_disasm_and_command): Update.
3501         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3502         (tui_redisplay_readline, tui_mld_flush)
3503         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3504         (tui_getc): Update.
3505         * tui/tui-disasm.c (tui_set_disassem_content)
3506         (tui_disasm_window::do_scroll_vertical): Update.
3507         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3508         Now virtual.
3509         (struct tui_win_info): Derive from tui_gen_win_info.
3510         <~tui_win_info>: Mark as override.
3511         <generic>: Remove member.
3512         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3513         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3514         (~tui_data_window, ~tui_win_info)
3515         (tui_free_all_source_wins_content): Update.
3516         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3517
3518 2019-06-25  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-layout.c (init_and_make_win): Use new.
3521         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3522         destructor, initializers.
3523         (tui_alloc_generic_win_info): Don't declare.
3524         * tui/tui-data.c (_locator): Add argument to constructor.
3525         (source_win, disasm_win): New globals.
3526         (exec_info): Remove.
3527         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3528         Update.
3529         (tui_alloc_generic_win_info): Remove.
3530         (init_content_element): Use new.
3531         (tui_win_info::tui_win_info): Update.
3532         (free_content_elements) <case DATA_WIN>: Use delete.
3533
3534 2019-06-25  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3537         * tui/tui-windata.c (tui_first_data_item_displayed)
3538         (tui_delete_data_content_windows): Update.
3539         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3540         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3541         (tui_display_registers_from, tui_check_register_values): Update.
3542         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3543         pointer.
3544         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3545         window.
3546         (tui_free_data_content): Update.
3547         (free_content_elements) <case DATA_WIN>: Free the window.
3548
3549 2019-06-25  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3552         Update.
3553         * tui/tui-layout.c (make_command_window)
3554         (show_source_disasm_command, show_data, init_and_make_win)
3555         (show_source_or_disasm_and_command): Update.
3556         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3557         method.
3558         <can_highight, is_highlighted>: Now bool.
3559         (tui_set_win_highlight): Don't declare.
3560         * tui/tui-data.c (tui_set_win_highlight): Remove.
3561
3562 2019-06-25  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-wingeneral.c (make_visible): Remove check of window
3565         type.
3566
3567 2019-06-25  Tom Tromey  <tom@tromey.com>
3568
3569         * tui/tui-win.c (tui_win_info::max_height)
3570         (tui_cmd_window::max_height): New methods.
3571         (new_height_ok): Call max_height.
3572         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3573         <max_height>: New method.
3574
3575 2019-06-25  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-win.c (tui_source_window_base::set_new_height)
3578         (tui_data_window::set_new_height): New methods.
3579         (make_invisible_and_set_new_height): Call set_new_height method.
3580         * tui/tui-data.h (struct tui_win_info)
3581         (struct tui_source_window_base, struct tui_data_window)
3582         <set_new_height>: New method.
3583
3584 2019-06-25  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3587         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3588         tui_refresh_data_win.
3589         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3590         method.
3591         (tui_refresh_all_win): Call the refresh_all method.
3592         (tui_set_focus): Likewise.
3593         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3594         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3595         Likewise.
3596
3597 2019-06-25  Tom Tromey  <tom@tromey.com>
3598
3599         * tui/tui-winsource.h (tui_refill_source_window)
3600         (tui_set_is_exec_point_at): Don't declare.
3601         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3602         (tui_source_window_base::refill): Rename from
3603         tui_refill_source_window.
3604         (tui_source_window_base::do_scroll_horizontal): Update.
3605         (tui_source_window_base::set_is_exec_point_at): Rename from
3606         tui_set_is_exec_point_at.
3607         (tui_update_all_breakpoint_info): Update.
3608         * tui/tui-stack.c (tui_show_frame_info): Update.
3609         * tui/tui-layout.c (show_data): Add cast.
3610         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3611         * tui/tui-data.h (struct tui_source_window_base) <refill,
3612         set_is_exec_point_at>: New methods.
3613         (tui_source_windows, tui_add_to_source_windows): Update types.
3614         (tui_add_to_source_windows): Remove redundant declaration.
3615         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3616         (tui_source_windows): Change return type.
3617         (tui_clear_source_windows_detail): Update.
3618         (tui_add_to_source_windows): Change type of parameter.
3619         (tui_free_all_source_wins_content): Update.
3620
3621 2019-06-25  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-wingeneral.c (tui_win_info::refresh)
3624         (tui_source_window_base::refresh): New methods.
3625         (tui_refresh_all): Call the refresh method.
3626         * tui/tui-data.h (struct tui_win_info)
3627         (struct tui_source_window_base) <refresh>: New method.
3628
3629 2019-06-25  Tom Tromey  <tom@tromey.com>
3630
3631         * tui/tui.h (tui_is_window_visible): Return bool.
3632         * tui/tui.c (tui_is_window_visible): Return bool.
3633         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3634         (tui_make_visible, tui_make_invisible)
3635         (tui_win_info::make_visible)
3636         (tui_source_window_base::make_visible, make_all_visible)
3637         (tui_make_all_visible, tui_make_all_invisible): Update.
3638         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3639         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3640         bool.
3641         (struct tui_win_info, struct tui_source_window_base)
3642         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3643         * tui/tui-data.c (tui_init_generic_part): Update.
3644
3645 2019-06-25  Tom Tromey  <tom@tromey.com>
3646
3647         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3648         (tui_source_window_base::make_visible): New methods.
3649         (make_all_visible): Make method call.
3650         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3651         (struct tui_source_window_base, struct tui_cmd_window): Override
3652         make_visible.
3653         (tui_win_is_source_type): Don't declare.
3654         * tui/tui-data.c (tui_win_is_source_type): Remove.
3655
3656 2019-06-25  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3659         NULL check.
3660
3661 2019-06-25  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3664         Inline constructor.  Add initializers for members.
3665         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3666         constructors; now inline in class.
3667
3668 2019-06-25  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-regs.c (tui_show_registers): Update.
3671         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3672         bool.
3673         * tui/tui-data.c (tui_data_window::clear_detail)
3674         (tui_data_window): Update.
3675
3676 2019-06-25  Tom Tromey  <tom@tromey.com>
3677
3678         * tui/tui-windata.c (tui_display_all_data)
3679         (tui_display_data_from_line, tui_display_data_from)
3680         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3681         Update.
3682         * tui/tui-regs.c (tui_last_regs_line_no)
3683         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3684         (tui_show_registers, tui_show_register_group)
3685         (tui_display_registers_from, tui_display_reg_element_at_line)
3686         (tui_display_registers_from_line, tui_check_register_values)
3687         (tui_reg_next, tui_reg_prev): Update.
3688         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3689         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3690         tui_data_window.
3691         (struct tui_win_info) <detail>: Remove.  Add new fields from
3692         tui_data_info.
3693         (TUI_DATA_WIN): Add cast.
3694         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3695         (~tui_data_window): Simplify.
3696
3697 2019-06-25  Tom Tromey  <tom@tromey.com>
3698
3699         * tui/tui-layout.c (show_source_disasm_command)
3700         (show_source_or_disasm_and_command): Update.
3701         * tui/tui-io.c (update_cmdwin_start_line)
3702         (tui_redisplay_readline): Update.
3703         * tui/tui-data.h (struct tui_command_info): Remove.
3704         (struct tui_win_info) <detail>: Remove command_info member.
3705         (struct tui_data_window) <start_line>: New member, from
3706         tui_command_info.
3707         (TUI_CMD_WIN): Add casts.
3708
3709 2019-06-25  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-winsource.c (tui_update_source_window)
3712         (tui_refill_source_window)
3713         (tui_source_window_base::do_scroll_horizontal)
3714         (tui_update_breakpoint_info, tui_set_exec_info_content)
3715         (tui_show_exec_info_content, tui_erase_exec_info_content)
3716         (tui_clear_exec_info_content): Update.
3717         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3718         Update.
3719         * tui/tui-win.c (make_invisible_and_set_new_height)
3720         (make_visible_with_new_height): Update.
3721         * tui/tui-source.c (tui_set_source_content)
3722         (tui_show_symtab_source): Update.
3723         * tui/tui-layout.c (extract_display_start_addr)
3724         (show_source_disasm_command, show_data)
3725         (make_source_or_disasm_window)
3726         (show_source_or_disasm_and_command): Update.
3727         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3728         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3729         "gdbarch".
3730         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3731         to tui_source_window_base.
3732         (struct tui_win_info) <detail>: Remove source_info member.
3733         (struct tui_source_window_base) <has_locator>: Inline.
3734         Move contents from tui_source_info; rename has_locator member to
3735         m_has_locator.
3736         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3737         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3738         header file.
3739         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3740         Simplify.
3741         (tui_free_all_source_wins_content): Cast to
3742         tui_source_window_base.
3743
3744 2019-06-25  Tom Tromey  <tom@tromey.com>
3745
3746         * tui/tui-win.c (make_invisible_and_set_new_height)
3747         (make_visible_with_new_height): Call has_locator method.
3748         * tui/tui-layout.c (show_source_disasm_command, show_data)
3749         (show_source_or_disasm_and_command): Update for bool change.
3750         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3751         (tui_win_info) <has_locator>: New method.
3752         (struct tui_source_window_base) <has_locator>: New method.
3753         (tui_win_has_locator): Don't declare.
3754         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3755         from tui_win_has_locator.
3756         (tui_source_window_base): Use false, not FALSE.
3757
3758 2019-06-25  Tom Tromey  <tom@tromey.com>
3759
3760         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3761         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3762         clear_detail method directly.
3763         (tui_clear_win_detail): Remove.
3764
3765 2019-06-25  Tom Tromey  <tom@tromey.com>
3766
3767         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3768         "this", not TUI_DISASM_WIN.
3769
3770 2019-06-25  Tom Tromey  <tom@tromey.com>
3771
3772         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3773         declare.
3774         * tui/tui-winsource.c
3775         (tui_source_window_base::do_scroll_horizontal): Rename from
3776         tui_horizontal_source_scroll.
3777         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3778         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3779         from tui_vertical_data_scroll.
3780         * tui/tui-win.h (tui_scroll): Don't declare.
3781         * tui/tui-win.c (tui_win_info::forward_scroll)
3782         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3783         (tui_win_info::right_scroll): Rename and update.
3784         (tui_scroll_forward_command, tui_scroll_backward_command)
3785         (tui_scroll_left_command, tui_scroll_right_command): Update.
3786         (tui_scroll): Remove.
3787         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3788         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3789         from tui_vertical_source_scroll.
3790         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3791         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3792         from tui_vertical_disassem_scroll.
3793         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3794         do_scroll_horizontal>: New methods.
3795         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3796         Likewise.
3797         (struct tui_source_window_base): Add do_scroll_horizontal.
3798         (struct tui_source_window, struct tui_disasm_window): Add
3799         do_scroll_vertical.
3800         (struct tui_data_window, struct tui_cmd_window): Add
3801         do_scroll_horizontal and do_scroll_vertical.
3802         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3803
3804 2019-06-25  Tom Tromey  <tom@tromey.com>
3805
3806         * tui/tui-data.h (struct tui_source_window_base): New struct.
3807         (struct tui_source_window): Derive from tui_source_window_base.
3808         (struct tui_disasm_window): New struct.
3809         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3810         from tui_source_window::clear_detail.
3811         (tui_source_window_base): Rename from tui_source_window.
3812         (~tui_source_window_base): Rename from ~tui_source_window.
3813         (tui_alloc_win_info): Create a tui_disasm_window.
3814
3815 2019-06-25  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-data.h (struct tui_source_window)
3818         (struct tui_data_window): Declare destructors.
3819         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3820         destructors.
3821         (tui_win_info): Simplify.
3822
3823 2019-06-25  Tom Tromey  <tom@tromey.com>
3824
3825         * tui/tui-winsource.c (tui_display_main)
3826         (tui_update_source_windows_with_addr)
3827         (tui_update_all_breakpoint_info): Update.
3828         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3829         (new_height_ok, parse_scrolling_args): Update.
3830         * tui/tui-stack.c (tui_show_frame_info): Update.
3831         * tui/tui-data.h (struct tui_list): Remove.
3832         (tui_source_windows): Return a reference to a std::vector.
3833         * tui/tui-data.c (source_windows): Now a std::vector.
3834         (tui_source_windows): Change return type.
3835         (tui_clear_source_windows): Rewrite.
3836         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3837         (tui_free_all_source_wins_content): Rewrite.
3838
3839 2019-06-25  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3842         (struct tui_data_window, struct tui_cmd_window): Declare
3843         clear_detail method.
3844         * tui/tui-data.c (tui_source_window::clear_detail)
3845         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3846         methods.
3847         (tui_clear_win_detail): Simplify.
3848
3849 2019-06-25  Tom Tromey  <tom@tromey.com>
3850
3851         * tui/tui-layout.c (make_source_window, make_disasm_window)
3852         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3853         Return the new window.
3854         (show_source_disasm_command, show_data)
3855         (show_source_or_disasm_and_command): Update.
3856
3857 2019-06-25  Tom Tromey  <tom@tromey.com>
3858
3859         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3860         parameter.  Return the new window.
3861         (show_source_disasm_command): Update and remove NULL check.
3862         (show_source_or_disasm_and_command): Update.
3863
3864 2019-06-25  Tom Tromey  <tom@tromey.com>
3865
3866         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3867
3868 2019-06-25  Tom Tromey  <tom@tromey.com>
3869
3870         * tui/tui-data.h (struct tui_win_info): Make constructor
3871         protected.  Make destructor virtual.  Add initializers.
3872         (tui_source_window, tui_data_window, tui_cmd_window): New
3873         classes.
3874         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3875         constructor.  Add "type" parameter.
3876         (tui_source_window, tui_data_window, tui_cmd_window): New
3877         constructors.
3878         (tui_alloc_win_info): Instantiate the appropriate subclass.
3879
3880 2019-06-25  Tom Tromey  <tom@tromey.com>
3881
3882         * tui/tui-win.c (tui_resize_all): Use delete.
3883         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3884         destructor.
3885         (tui_free_window): Don't declare.
3886         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3887         Update.
3888
3889 2019-06-25  Tom Tromey  <tom@tromey.com>
3890
3891         * tui/tui-data.h (struct tui_win_info): Add constructor.
3892         * tui/tui-data.c (tui_alloc_win_info): Use new.
3893         (tui_free_window): Use delete.
3894
3895 2019-06-22  Tom Tromey  <tom@tromey.com>
3896
3897         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3898         declare.
3899         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3900
3901 2019-06-22  Tom Tromey  <tom@tromey.com>
3902
3903         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3904         declare.
3905         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3906
3907 2019-06-22  Tom de Vries  <tdevries@suse.de>
3908
3909         * dwarf2read.c (create_addrmap_from_aranges)
3910         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3911         instead of '%zu'.
3912
3913 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3914
3915         * dwarf2read.h (dwarf2_section_info_def): Remove.
3916         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3917         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3918         std::vector<dwarf2_section_info>.
3919         (struct dwo_file) <~dwo_file>: Remove.
3920         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3921         types field.
3922         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3923         (dwarf2_read_debug_names): Likewise.
3924         (create_debug_types_hash_table): Change parameter type to
3925         array_view, adjust code accordingly.
3926         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3927         (partial_die_info::fixup): Likewise.
3928         (determine_prefix): Likewise.
3929         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3930
3931 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3932
3933         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3934         gdb_bfd_ref_ptr.
3935         <~dwo_file>: Remove call to gdb_bfd_unref.
3936         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3937         gdb_bfd_ref_ptr::get.
3938
3939 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3940
3941         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3942         type to htab_up.
3943         * dwarf2read.c (struct dwo_file): Initialize fields.
3944         <~dwo_file>: New.
3945         (free_dwo_file): Remove, move content to ~dwo_file.
3946         (struct dwo_file_deleter): Remove.
3947         (dwo_file_up>: Remove custom deleter.
3948         (free_dwo_files): Remove.
3949         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3950         dwo_files.
3951         (process_skeletonless_type_units): Call unique_ptr::get.
3952         (allocate_dwo_file_hash_table): Add deleter to created hash
3953         table.  Change return type to htab_up.
3954         (lookup_dwo_file_slot): Don't memset dwo_file, call
3955         unique_ptr::get.
3956         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3957         (create_dwo_unit_in_dwp_v2): Likewise.
3958         (open_and_init_dwo_file): Likewise.
3959         (free_dwo_file_from_slot): Remove.
3960
3961 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3962
3963         * dwarf2read.h (struct dwarf2_section_info) <readin,
3964         is_virtual>: Change type to bool.
3965         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3966         true instead of 1.
3967
3968 2019-06-19  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-data.h (tui_init_content_element): Don't declare.
3971
3972 2019-06-19  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-data.h (tui_init_win_info): Don't declare.
3975
3976 2019-06-19  Tom de Vries  <tdevries@suse.de>
3977
3978         * dwarf2read.h (abstract_to_concrete): Change type to
3979         std::unordered_map<sect_offset, std::vector<sect_offset>,
3980         gdb::hash_enum<sect_offset>>.
3981
3982 2019-06-19  Tom Tromey  <tromey@adacore.com>
3983
3984         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3985         EVAL_AVOID_SIDE_EFFECTS specially.
3986
3987 2019-06-19  Tom Tromey  <tromey@adacore.com>
3988
3989         * source-cache.c (highlighter): New global.
3990         (source_cache::get_source_lines): Create a highlighter on demand.
3991
3992 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3993
3994         * defs.h (deprecated_interactive_hook): Delete declaration.
3995         * interps.c (clear_interpreter_hooks): Remove use of
3996         deprecated_interactive_hook.
3997         * top.c (deprecated_interactive_hook): Delete definition.
3998         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3999
4000 2019-06-18  Tom de Vries  <tdevries@suse.de>
4001
4002         PR gdb/24515
4003         * dwarf2read.h (abstract_to_concrete): Change type from
4004         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4005         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4006         * dwarf2read.c (read_variable): Update.
4007         (dwarf2_fetch_die_loc_sect_off): Update.
4008
4009 2019-06-17  Tom de Vries  <tdevries@suse.de>
4010
4011         PR gdb/24617
4012         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4013         accessing parent[parent_len - 1].
4014
4015 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4016
4017         PR gdb/24364
4018         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4019         call dtrace_process_dof with NULL dof.
4020
4021 2019-06-16  Tom de Vries  <tdevries@suse.de>
4022
4023         PR gdb/24445
4024         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4025
4026 2019-06-16  Tom Tromey  <tom@tromey.com>
4027
4028         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4029         (make_all_visible): Use address of member.
4030
4031 2019-06-16  Tom Tromey  <tom@tromey.com>
4032
4033         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4034         (tui_free_window, free_content, free_content_elements): Remove
4035         unnecessary cast.
4036         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4037         cast.
4038         * tui/tui-regs.c (tui_show_register_group)
4039         (tui_display_registers_from, tui_display_reg_element_at_line):
4040         Remove unnecessary cast.
4041
4042 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4043
4044         * linux-nat.c (normal_mask): Delete.
4045         (_initialize_linux_nat): Don't initialise normal_mask.
4046
4047 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4048
4049         PR gdb/24445
4050         * dwarf-index-write.h (write_psymtabs_to_index): Add
4051         dwz_basename parameter.
4052         * dwarf-index-write.c (write_gdbindex): Move file writing to
4053         write_gdbindex_1.  Change return type void.
4054         (assert_file_size): Move up, remove filename parameter.
4055         (write_gdbindex_1): New function.
4056         (write_debug_names): Change return type to void, call
4057         assert_file_size.
4058         (struct index_wip_file): New struct.
4059         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4060         file logic to index_wip_file.  Write index for dwz file if
4061         needed.
4062         (save_gdb_index_command): Pass basename of dwz file, if present.
4063         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4064         build-id of dwz file, if present.
4065         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4066         (dwarf2_get_dwz_file): Likewise.
4067         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4068         (dwarf2_get_dwz_file): Likewise.
4069
4070 2019-06-16  Tom Tromey  <tom@tromey.com>
4071
4072         * coffread.c (process_coff_symbol): Use xstrdup.
4073         * value.c (create_internalvar): Use xstrdup.
4074
4075 2019-06-16  Tom Tromey  <tom@tromey.com>
4076
4077         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4078         * breakpoint.c (stopin_command, stopat_command)
4079         (until_break_command, decode_location_default): Remove unnecessary
4080         cast.
4081         * utils.c (subset_compare): Remove unnecessary cast.
4082         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4083         cast.
4084         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4085         cast.
4086         * infcmd.c (path_command): Remove unnecessary cast.
4087         * coffread.c (decode_type): Remove unnecessary cast.
4088         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4089         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4090         * tui/tui-stack.c (tui_show_locator_content)
4091         (tui_show_frame_info): Remove unnecessary cast.
4092         * tui/tui-win.c (tui_scroll_forward_command)
4093         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4094         (parse_scrolling_args): Remove unnecessary cast.
4095         * tui/tui-data.c (init_win_info, tui_del_window)
4096         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4097         (free_content_elements): Remove unnecessary cast.
4098         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4099         unnecessary cast.
4100         * tui/tui-source.c (tui_set_source_content)
4101         (tui_vertical_source_scroll): Remove unnecessary cast.
4102         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4103         cast.
4104         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4105         * tui/tui-regs.c (tui_display_registers_from)
4106         (tui_display_register): Remove unnecessary cast.
4107         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4108         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4109         (make_visible): Remove unnecessary cast.
4110         * tui/tui-winsource.c (tui_erase_source_content)
4111         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4112         unnecessary cast.
4113         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4114         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4115         * stabsread.c (read_type, read_array_type, read_range_type):
4116         Remove unnecessary cast.
4117         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4118         (parse_symbol, parse_type, upgrade_type, parse_external)
4119         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4120         unnecessary cast.
4121         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4122
4123 2019-06-16  Tom Tromey  <tom@tromey.com>
4124
4125         * tui/tui-data.c (tui_alloc_generic_win_info)
4126         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4127         checks.
4128
4129 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4130             Andrew Burgess  <andrew.burgess@embecosm.com>
4131
4132         * f-typeprint.c (f_print_type): Don't return early for not
4133         associated or not allocated types.
4134         (f_type_print_varspec_suffix): Add print_rank parameter and print
4135         ranks of array types in case they dangling.
4136         (f_type_print_base): Add print_rank parameter.
4137
4138 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * NEWS: Mention new MI commands.
4141         * break-catch-throw.c (enum exception_event_kind): Move to
4142         breakpoint.h.
4143         (print_mention_exception_catchpoint): Output text as a single
4144         message.
4145         (catch_exception_command_1): Rename to...
4146         (catch_exception_event): ...this, make non-static, update header
4147         command, and change some parameter types.
4148         (catch_catch_command): Update for changes to
4149         catch_exception_command_1.
4150         (catch_throw_command): Likewise.
4151         (catch_rethrow_command): Likewise.
4152         * breakpoint.c (enum exception_event_kind): Delete.
4153         * breakpoint.h (enum exception_event_kind): Moved here from
4154         break-catch-throw.c.
4155         (catch_exception_event): Declare.
4156         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4157         (mi_cmd_catch_throw): New function.
4158         (mi_cmd_catch_rethrow): New function.
4159         (mi_cmd_catch_catch): New function.
4160         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4161         'catch-catch' entries.
4162         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4163         (mi_cmd_catch_rethrow): Declare.
4164         (mi_cmd_catch_catch): Declare.
4165
4166 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4167
4168         * annotate.c (annotate_source_line): Change return type to void,
4169         update implementation to match.
4170         * annotate.h (annotate_source_line): Change return type to void,
4171         update header comment.
4172         * stack.c (print_frame_info): Don't change what frame information
4173         is printed based on whether annotations are on or not.
4174
4175 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4176
4177         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4178         (annotate_source): Make static.
4179         (annotate_source_line): Moved from source.c and renamed from
4180         identify_source_line.  Update the return type.
4181         * annotate.h (annotate_source): Delete declaration.
4182         (annotate_source_line): Declaration moved from source.h, and
4183         renamed from identify_source_line.  Return type updated.
4184         * source.c (identify_source_line): Moved to annotate.c and renamed
4185         to annotate_source_line.
4186         (info_line_command): Remove check of annotation_level.
4187         * source.h (identify_source_line): Move declaration to annotate.h
4188         and rename to annotate_source_line.
4189         * stack.c: Add 'annotate.h' include.
4190         (print_frame_info): Remove check of annotation_level before
4191         calling annotate_source_line.
4192
4193 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * source-cache.c (source_cache::get_plain_source_lines): Use
4196         open_source_file_with_line_charpos instead of just
4197         open_source_file, remove call to find_source_lines.
4198         (source_cache::get_source_lines): Likewise.
4199         * source.c (find_source_lines): Make static.
4200         (get_filename_and_charpos): Renamed into...
4201         (open_source_file_with_line_charpos): ..this along with changes to
4202         return a scoped_fd, and some other minor clean ups.
4203         (identify_source_line): Use open_source_file_with_line_charpos.
4204         (search_command_helper): Use open_source_file_with_line_charpos
4205         instead of just open_source_file, remove call to
4206         find_source_lines.
4207         * source.h (open_source_file_with_line_charpos): Declare new
4208         function.
4209         (find_source_lines): Delete declaration.
4210
4211 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4212
4213         * source.c (get_filename_and_charpos): Remove fullname
4214         parameter.
4215         (identify_source_line): Update call to get_filename_and_charpos.
4216
4217 2019-06-14  Tom Tromey  <tromey@adacore.com>
4218
4219         PR gdb/24502:
4220         * ui-style.h (skip_ansi_escape): Update comment.
4221         * ui-file.h (class no_terminal_escape_file): New class.
4222         * ui-file.c (no_terminal_escape_file::write)
4223         (no_terminal_escape_file::puts): New methods.
4224         * cli/cli-logging.c (handle_redirections): Use
4225         no_terminal_escape_file.
4226
4227 2019-06-14  Tom Tromey  <tromey@adacore.com>
4228
4229         * NEWS: Move convenience variable news above Python news.
4230
4231 2019-06-14  Tom Tromey  <tom@tromey.com>
4232
4233         * gnulib: Move directory to top-level.
4234         * configure.ac: Don't configure gnulib.
4235         * configure: Rebuild.
4236         * common/common-defs.h: Use new path to gnulib.
4237         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4238         (GNULIB_H): Remove.
4239         (INCGNU): Look in new gnulib location.
4240         (HFILES_NO_SRCDIR): Remove gnulib files.
4241         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4242         (generated_files): Remove GNULIB_H.
4243         ($(LIBGNU), all-lib): Remove targets.
4244         (distclean): Don't mention GNULIB_BUILDDIR.
4245         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4246
4247 2019-06-14  Tom Tromey  <tromey@adacore.com>
4248
4249         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4250         Warn if symbol file does not provide any symbols.
4251
4252 2019-06-14  Tom Tromey  <tromey@adacore.com>
4253
4254         * source.c (find_and_open_source): Respect basenames_may_differ.
4255
4256 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4257
4258         * annotate.c (annotate_breakpoints_invalid): Make use of
4259         scoped_restore_terminal_state.
4260         (annotate_frames_invalid): Likewise.
4261
4262 2019-06-14  Tom Tromey  <tromey@adacore.com>
4263
4264         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4265         allow assignment to an internalvar.
4266
4267 2019-06-14  Tom Tromey  <tromey@adacore.com>
4268
4269         * ada-lex.l: Allow "_" in attribute names.
4270
4271 2019-06-14  Tom Tromey  <tromey@adacore.com>
4272
4273         PR gdb/24653:
4274         * regcache.c (registers_changed): Don't call alloca.
4275         * top.c (execute_command): Don't call alloca.
4276
4277 2019-06-13  Pedro Alves  <palves@redhat.com>
4278
4279         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4280         'expression'.  When parsing an expression, error out if there's
4281         junk after "unlimited".
4282         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4283         (do_set_command): Adjust calls to is_unlimited_literal.
4284
4285 2019-06-13  Pedro Alves  <palves@redhat.com>
4286
4287         * compile/compile.c (make_compile_options_def_group): Add braces
4288         around array_view initializer.
4289         * thread.c (make_thread_apply_all_options_def_group)
4290         (make_thread_apply_all_options_def_group): Likewise.
4291
4292 2019-06-13  Pedro Alves  <palves@redhat.com>
4293
4294         * NEWS (New commands): Mention "maint test-options
4295         require-delimiter", "maint test-options unknown-is-error", "maint
4296         test-options unknown-is-operand" and "maint show
4297         test-options-completion-result".
4298         (New command options, command completion): New section.
4299         (Completion improvements): New section.
4300         Mention that you can abbreviate "unlimited".
4301
4302 2019-06-13  Pedro Alves  <palves@redhat.com>
4303
4304         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4305         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4306         * unittests/cli-utils-selftests.c (test_parse_flags)
4307         (test_parse_flags_qcs): Delete.
4308         (test_cli_utils): Don't call deleted functions.
4309
4310 2019-06-13  Pedro Alves  <palves@redhat.com>
4311
4312         * thread.c: Include "cli/cli-option.h".
4313         (tp_array_compar_ascending): Global.
4314         (tp_array_compar): Delete function.
4315         (tp_array_compar_ascending, tp_array_compar_descending): New
4316         functions.
4317         (ascending_option_def, qcs_flag_option_def)
4318         (thr_qcs_flags_option_defs)
4319         (make_thread_apply_all_options_def_group)
4320         (make_thread_apply_options_def_group): New.
4321         (thread_apply_all_command): Use gdb::option::process_options.
4322         (thread_apply_command_completer)
4323         (thread_apply_all_command_completer): New.
4324         (thread_apply_command): Use gdb::option::process_options.
4325         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4326         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4327         to generate help text of "thread apply".  Adjust "taas"'s help.
4328         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4329         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4330
4331 2019-06-13  Pedro Alves  <palves@redhat.com>
4332
4333         * thread.c (thread_apply_command): Check for invalid TID with
4334         isdigit instead of !isalpha.
4335
4336 2019-06-13  Pedro Alves  <palves@redhat.com>
4337
4338         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4339         (validate_flags_qcs): New.
4340         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4341         (validate_flags_qcs): Declare.
4342         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4343         (make_frame_apply_options_def_group): New.
4344         (frame_apply_command_count): Process options with
4345         gdb::option::process_options.
4346         (frame_apply_completer): New.
4347         (frame_apply_level_completer, frame_apply_all_completer)
4348         (frame_apply_completer): New.
4349         (_initialize_stack): Update help of "frame apply", "frame apply
4350         level", "frame apply all" and "faas" to mention supported options
4351         and install command completers.
4352         * stack.h (frame_apply_all_completer): Declare.
4353         * thread.c: Include "stack.h".
4354         (tfaas_command): Add "--".
4355         (_initialize_thread): Update help "tfaas" to mention supported
4356         options and install command completer.
4357
4358 2019-06-13  Pedro Alves  <palves@redhat.com>
4359
4360         * completer.c (complete_nested_command_line): New.
4361         (gdb_completion_word_break_characters_throw): Add assertion.
4362         * completer.h (complete_nested_command_line): Declare.
4363
4364 2019-06-13  Pedro Alves  <palves@redhat.com>
4365
4366         * stack.c (parse_backtrace_qualifiers): New.
4367         (backtrace_command): Use it.
4368         (backtrace_command_completer): Complete on qualifiers.
4369
4370 2019-06-13  Pedro Alves  <palves@redhat.com>
4371
4372         * frame.c: Include "cli/cli-option.h.
4373         (user_set_backtrace_options): New.
4374         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4375         Delete.
4376         (get_prev_frame): Adjust.
4377         (boolean_option_def, uinteger_option_def)
4378         (set_backtrace_option_defs): New.
4379         (_initialize_frame): Adjust and use
4380         gdb::option::add_setshow_cmds_for_options to install "set
4381         backtrace past-main" and "set backtrace past-entry".
4382         * frame.h: Include "cli/cli-option.h".
4383         (struct frame_print_options): Forward declare.
4384         (print_frame_arguments_all, print_frame_arguments_scalars)
4385         (print_frame_arguments_none): Declare.
4386         (print_entry_values): Delete declaration.
4387         (struct frame_print_options, user_frame_print_options): New.
4388         (struct set_backtrace_options): New.
4389         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4390         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4391         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4392         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4393         (list_args_or_locals): Add frame_print_options parameter.
4394         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4395         * python/py-framefilter.c (enumerate_args): Pass down
4396         USER_FRAME_PRINT_OPTIONS.
4397         * stack.c: Include "cli/cli-option.h".
4398         (print_frame_arguments_all, print_frame_arguments_scalars)
4399         (print_frame_arguments_none): Declare.
4400         (print_raw_frame_arguments, print_entry_values): Delete.
4401         (user_frame_print_options): New.
4402         (boolean_option_def, enum_option_def, frame_print_option_defs):
4403         New.
4404         (struct backtrace_cmd_options): New.
4405         (bt_flag_option_def): New.
4406         (backtrace_command_option_defs): New.
4407         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4408         (print_frame_arg, read_frame_arg, print_frame_args)
4409         (print_frame_info, print_frame): Add frame_print_options parameter
4410         and use it.
4411         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4412         (backtrace_command_1): Add frame_print_options and
4413         backtrace_cmd_options parameters and use them.
4414         (make_backtrace_options_def_group): New.
4415         (backtrace_command): Process command options with
4416         gdb::option::process_options.
4417         (backtrace_command_completer): New.
4418         (_initialize_stack): Extend "backtrace"'s help to mention
4419         supported options.  Install completer for "backtrace".
4420         Install some settings commands with add_setshow_cmds_for_options.
4421
4422 2019-06-13  Pedro Alves  <palves@redhat.com>
4423
4424         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4425         and that "set/show print raw frame-arguments" are now deprecated.
4426
4427         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4428         command.
4429         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4430         * stack.c (_initialize_stack): Install "set/show print
4431         raw-frame-arguments", and deprecate "set/show print raw
4432         frame-arguments".
4433         * valprint.c (_initialize_valprint): Deprecate "set/show print
4434         raw".
4435
4436 2019-06-13  Pedro Alves  <palves@redhat.com>
4437
4438         * compile/compile.c (struct compile_options): New.
4439         (compile_flag_option_def, compile_command_option_defs)
4440         (make_compile_options_def_group): New.
4441         (compile_file_command): Handle options with
4442         gdb::option::process_options.
4443         (compile_file_command_completer): New function.
4444         (compile_code_command): Handle options with
4445         gdb::option::process_options.
4446         (compile_code_command_completer): New function.
4447         (_initialize_compiler): Install completers for "compile code" and
4448         "compile file".  Mention available options in "compile code" and
4449         "compile code"'s help.
4450         * completer.c (advance_to_completion_word): New, factored out from
4451         ...
4452         (advance_to_expression_complete_word_point): ... this.
4453         (advance_to_filename_complete_word_point): New.
4454         * completer.h (advance_to_filename_complete_word_point): New
4455         declaration.
4456
4457 2019-06-13  Pedro Alves  <palves@redhat.com>
4458
4459         * compile/compile.c: Include "cli/cli-option.h".
4460         (compile_print_value): Scope data pointer is now a
4461         value_print_options pointer; adjust.
4462         (compile_print_command): Process options.  Scope data pointer is
4463         now a value_print_options pointer; adjust.
4464         (_initialize_compile): Update "compile print"'s help to include
4465         supported options.  Install a completer for "compile print".
4466         * cp-valprint.c (show_vtblprint, show_objectprint)
4467         (show_static_field_print): Delete.
4468         (_initialize_cp_valprint): Don't install "set print
4469         static-members", "set print vtbl", "set print object" here.
4470         * printcmd.c: Include "cli/cli-option.h" and
4471         "common/gdb_optional.h".
4472         (print_command_parse_format): Rework to fill in a
4473         value_print_options instead of a format_data.
4474         (print_value): Change parameter type from format_data pointer to
4475         value_print_options reference.  Adjust.
4476         (print_command_1): Process options.  Adjust to pass down a
4477         value_print_options.
4478         (print_command_completer): New.
4479         (_initialize_printcmd): Install print_command_completer as
4480         handle_brkchars completer for the "print" command.  Update
4481         "print"'s help to include supported options.
4482         * valprint.c: Include "cli/cli-option.h".
4483         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4484         here from cp-valprint.c.
4485         (boolean_option_def, uinteger_option_def)
4486         (value_print_option_defs, make_value_print_options_def_group):
4487         New.  Use gdb::option::add_setshow_cmds_for_options to install
4488         "set print elements", "set print null-stop", "set print repeats",
4489         "set print pretty", "set print union", "set print array", "set
4490         print address", "set print symbol", "set print array-indexes".
4491         * valprint.h: Include <string> and "cli/cli-option.h".
4492         (make_value_print_options_def_group): Declare.
4493         (print_value): Change parameter type from format_data pointer to
4494         value_print_options reference.
4495         (print_command_completer): Declare.
4496
4497 2019-06-13  Pedro Alves  <palves@redhat.com>
4498
4499         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4500         (COMMON_SFILES): Add maint-test-settings.c.
4501         * cli/cli-decode.c (boolean_enums): New global, factored out from
4502         ...
4503         (add_setshow_boolean_cmd): ... here.
4504         * cli/cli-decode.h (boolean_enums): Declare.
4505         * cli/cli-option.c: New file.
4506         * cli/cli-option.h: New file.
4507         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4508         factored out from ...
4509         (parse_cli_boolean_value(const char *)): ... this.
4510         (is_unlimited_literal): Change parameter type to pointer to
4511         pointer.  Adjust and advance ARG pointer.
4512         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4513         (parse_cli_var_enum): New, factored out from ...
4514         (do_set_command): ... this.  Adjust.
4515         * cli/cli-setshow.h (parse_cli_boolean_value)
4516         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4517         (parse_cli_var_enum): Declare.
4518         * cli/cli-utils.c: Include "cli/cli-option.h".
4519         (get_ulongest): New.
4520         * cli/cli-utils.h (get_ulongest): Declare.
4521         (check_for_argument): New overloads.
4522         * maint-test-options.c: New file.
4523
4524 2019-06-13  Pedro Alves  <palves@redhat.com>
4525
4526         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4527         parse a range if "-" is at the end of the string.
4528
4529 2019-06-13  Pedro Alves  <palves@redhat.com>
4530
4531         * cli/cli-setshow.c (parse_auto_binary_operation)
4532         (parse_cli_boolean_value): Don't allow "o".
4533
4534 2019-06-13  Pedro Alves  <palves@redhat.com>
4535
4536         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4537         * NEWS: Mention maint test-settings KIND.
4538         * maint-test-settings.c: New file.
4539
4540 2019-06-13  Pedro Alves  <palves@redhat.com>
4541
4542         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4543         completer.
4544         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4545         "set" completers.
4546
4547 2019-06-13  Pedro Alves  <palves@redhat.com>
4548
4549         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4550         after item.
4551
4552 2019-06-13  Pedro Alves  <palves@redhat.com>
4553
4554         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4555
4556 2019-06-13  Pedro Alves <palves@redhat.com>
4557
4558         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4559         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4560         call.
4561         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4562         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4563         calls.
4564         (check_for_argument): Skip spaces after argument.
4565
4566 2019-06-13  Pedro Alves  <palves@redhat.com>
4567
4568         * thread.c (thread_apply_command): Adjust TID parsing.
4569         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4570         detected before end of string.
4571         (tid_is_in_list): Error out if LIST is invalid.
4572
4573 2019-06-13  Pedro Alves  <palves@redhat.com>
4574
4575         * completer.c (complete_line_internal_1): Rewind completion word
4576         point.
4577         (completion_tracker::advance_custom_word_point_by): Change
4578         parameter type to int.
4579         * completer.h (completion_tracker::advance_custom_word_point_by):
4580         Likewise.
4581
4582 2019-06-13  Pedro Alves  <palves@redhat.com>
4583
4584         * completer.c (advance_to_completion_word): Handle delimiters.
4585
4586 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4587
4588         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4589
4590 2019-06-11  Tom Tromey  <tom@tromey.com>
4591
4592         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4593         (xmalloc_failed): Move to alloc.c.
4594         * alloc.c: New file.
4595         * Makefile.in (COMMON_SFILES): Add alloc.c.
4596
4597 2019-06-11  Tom Tromey  <tom@tromey.com>
4598
4599         * nat/linux-waitpid.c: Don't include server.h.
4600         (linux_debug): Remove.
4601         (my_waitpid): Update.
4602
4603 2019-06-11  Tom Tromey  <tromey@adacore.com>
4604
4605         * infcall.c (_initialize_infcall): Remove trailing newline from
4606         help.
4607         * user-regs.c (_initialize_user_regs): Remove trailing newline
4608         from help.
4609         * typeprint.c (_initialize_typeprint): Remove trailing newline
4610         from help.
4611         * reverse.c (_initialize_reverse): Remove trailing newlines from
4612         help.
4613         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4614         from help.
4615         * language.c (add_set_language_command): Remove trailing newline
4616         from help.
4617         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4618         help.
4619         * disasm.c (_initialize_disasm): Remove trailing newline from
4620         help.
4621         * top.c (init_main): Remove trailing newline from help.
4622         * interps.c (_initialize_interpreter): Remove trailing newline
4623         from help.
4624         * btrace.c (_initialize_btrace): Remove trailing newlines from
4625         help.
4626         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4627         from help.
4628         * python/python.c (_initialize_python): Remove trailing newline
4629         from help.
4630         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4631         help.
4632         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4633         from help.  Reformat some text.
4634         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4635         from help.
4636         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4637         newline from help.
4638
4639 2019-06-11  Tom Tromey  <tromey@adacore.com>
4640
4641         * darwin-nat.c (darwin_decode_exception_message)
4642         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4643
4644 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4645
4646         * valops.c (value_slice): Check for not allocated or not
4647         associated values.
4648
4649 2019-06-10  Tom de Vries  <tdevries@suse.de>
4650
4651         PR gdb/24618
4652         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4653         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4654         invalid.
4655
4656 2019-06-10  Tom de Vries  <tdevries@suse.de>
4657
4658         PR gdb/24611
4659         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4660         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4661
4662 2019-06-10  Tom de Vries  <tdevries@suse.de>
4663
4664         PR symtab/24545
4665         * symtab.c (struct demangled_name_entry): Add language field.
4666         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4667         static minimal symbol".  Set and use language field.
4668
4669 2019-06-10  Tom Tromey  <tromey@adacore.com>
4670
4671         * ada-lang.c (_initialize_ada_language): Update help text.
4672
4673 2019-06-10  Tom Tromey  <tromey@adacore.com>
4674
4675         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4676         with a newline.
4677         * guile/guile.c (handle_boot_error): Don't end warning with a
4678         newline.
4679         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4680         warning with a newline.
4681         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4682         newline.
4683         (s12z_frame_cache): Likewise.
4684         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4685         a newline.
4686         * solib-svr4.c (disable_probes_interface): Don't end warning with
4687         a newline.
4688         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4689         newline.
4690         * python/python.c (do_finish_initialization): Don't end warning
4691         with a newline.
4692
4693 2019-06-10  Tom Tromey  <tom@tromey.com>
4694
4695         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4696         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4697         gdbpy_enter.
4698
4699 2019-06-10  Tom Tromey  <tromey@adacore.com>
4700
4701         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4702         data.
4703         (elf_new_init): Don't call stabsread_new_init.
4704         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4705         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4706         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4707
4708 2019-06-10  Tom de Vries  <tdevries@suse.de>
4709
4710         PR symtab/16264
4711         PR symtab/24517
4712         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4713
4714 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4715
4716         * source.c (find_and_open_source): Also rewrite relative file
4717         names.
4718
4719 2019-04-26  Amos Bird  <amosbird@gmail.com>
4720
4721         * annotate.c (annotate_thread_exited): Add "thread-exited"
4722         annotation.
4723
4724 2019-06-06  Tom Tromey  <tromey@adacore.com>
4725
4726         * maint.h (class scoped_command_stats): Use
4727         DISABLE_COPY_AND_ASSIGN.
4728         <print_time>: New method.
4729         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4730         print_time.
4731         (scoped_command_stats::print_time): New method.
4732
4733 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4734
4735         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4736         instructions of lengths 6 or 8 bytes.
4737
4738 2019-06-04  Pedro Alves  <palves@redhat.com>
4739
4740         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4741
4742         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4743         * breakpoint.c (condition_completer): Likewise.
4744         * cli/cli-dump.c (scan_expression): Likewise.
4745         * common/filestuff.c (mkdir_recursive): Likewise.
4746         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4747         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4748         (gdb_abspath): Likewise.
4749         * compile/compile-cplus-types.c
4750         (compile_cplus_instance::decl_name): Likewise.
4751         * completer.c (complete_explicit_location):
4752         (signal_completer, reg_or_group_completer_1): Likewise.
4753         * cp-support.c (cp_remove_params_if_any): Likewise.
4754         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4755         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4756         * infcmd.c (strip_bg_char): Likewise.
4757         * linespec.c (copy_token_string): Likewise.
4758         * mi/mi-main.c (output_cores): Likewise.
4759         * psymtab.c (psymtab_search_name):
4760         * symfile.c (test_set_ext_lang_command): Likewise.
4761         * target.c (target_fileio_read_stralloc): Likewise.
4762         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4763         * value.c (complete_internalvar): Likewise.
4764
4765 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4766
4767         Add objfile property to gdb.Type.
4768         * NEWS: Mention Python API addition.
4769         * python/py-type.c (typy_get_objfile): New method.
4770
4771 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4772
4773         * NEWS: Mention the new set|show style [title|highlight].
4774         Mention changes to "show style", "help" and "apropos".
4775
4776 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4777
4778         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4779         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4780         instead of print_help_for_command.
4781         (print_doc_of_command): New function.
4782         (help_list): Add 'apropos -v word' suggestion.
4783         (print_help_for_command): Style the command name using title style.
4784         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4785         (_initialize_cli_cmds): Describe -v in apropos_command help.
4786
4787 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4788
4789         * cli/cli-style.h (cli_style_option): Add name in constructor,
4790         add m_name class member, add constructor with intensity,
4791         add name class function.
4792         (cli_style_option::add_setshow_commands): Remove name argument.
4793         (highlight_style, title_style): New styles.
4794         * cli/cli-style.c (do_show): New function that shows a style
4795         characteristic styling the style name with itself.
4796         (set_style_name): New function.
4797         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4798         Update all callers according to the changes in cli/cli-style.h.
4799         * utils.h (fputs_highlighted): New function.
4800         * utils.c (fputs_highlighted): Likewise.
4801
4802 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4803
4804         * NEWS: Mention new pipe command and new convenience variables.
4805
4806 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4807
4808         * cli/cli-cmds.c (pipe_command): New function.
4809         (_initialize_cli_cmds): Call add_com for pipe_command.
4810         Define | as an alias for pipe.
4811         (exit_status_set_internal_vars): New function.
4812         (shell_escape): Call exit_status_set_internal_vars.
4813         cli/cli-decode.c (find_command_name_length): Recognize | as
4814         a single character command.
4815
4816 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4817
4818         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4819         top.c (execute_command_to_ui_file): New function, mostly a copy
4820         of execute_command_to_string.
4821         (execute_command_to_string): Implement by calling
4822         execute_command_to_ui_file.
4823
4824 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4825
4826         * top.h (saved_command_line): Remove declaration.
4827         * top.c (previous_saved_command_line, previous_repeat_arguments):
4828         New variables.
4829         (saved_command_line): Make static, define together with other
4830         'repeat variables'.
4831         (dont_repeat): Clear repeat_arguments.
4832         (repeat_previous, get_saved_command_line, save_command_line):
4833         New functions.
4834         (gdb_init): Initialize saved_command_line
4835         and previous_saved_command_line.
4836         * main.c (captured_main_1): Remove saved_command_line initialization.
4837         * event-top.c (handle_line_of_input): Update to use
4838         the new 'repeat' related functions instead of direct access to
4839         saved_command_line.
4840         * command.h (repeat_previous, get_saved_command_line,
4841         save_command_line): New declarations.
4842         (dont_repeat): Add comment.
4843
4844 2019-05-30  Tom Tromey  <tromey@adacore.com>
4845
4846         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4847         Fix comment.
4848         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4849
4850 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4851
4852         PR cli/24587
4853         * completer.c (complete): Initialize variable word.
4854
4855 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4856
4857         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4858         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4859         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4860         'body' is NULL to the outter 'if', protecting the '!is_define'
4861         situation as well.
4862
4863 2019-05-29  Tom Tromey  <tromey@adacore.com>
4864
4865         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4866         (dwarf_unknown): New function.
4867         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4868         (dwarf_type_encoding_name): Use dwarf_unknown.
4869
4870 2019-05-29  Tom Tromey  <tromey@adacore.com>
4871
4872         PR c++/20020:
4873         * cp-valprint.c (cp_print_value_fields): Call
4874         cp_print_static_field inside "try".
4875
4876 2019-05-29  Tom Tromey  <tromey@adacore.com>
4877
4878         * inflow.c (struct terminal_info): Add default operator=.
4879         * configure: Rebuild.
4880         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4881         -Wdeprecated-copy-dtor, -Wredundant-move.
4882
4883 2019-05-29  Tom Tromey  <tromey@adacore.com>
4884
4885         * NEWS: Add entry.
4886         * infcmd.c (print_return_value_1): Handle finish_print
4887         option.
4888         (show_print_finish): New function.
4889         (_initialize_infcmd): Add "set/show print finish" commands.
4890         * valprint.c (user_print_options): Initialize new member.
4891         * valprint.h (struct value_print_options) <finish_print>: New
4892         member.
4893
4894 2019-05-28  Tom Tromey  <tromey@adacore.com>
4895
4896         * ada-lang.c (ada_remove_Xbn_suffix)
4897         (find_old_style_renaming_symbol)
4898         (parse_old_style_renaming): Remove.
4899         (ada_find_renaming_symbol): Don't call
4900         find_old_style_renaming_symbol.
4901         (ada_is_renaming_symbol): Rename from
4902         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4903         bool.  Now static.
4904         (ada_read_var_value): Update and simplify.
4905         * ada-exp.y (write_var_or_type): Remove old code.
4906
4907 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4908
4909         * event-top.c: Remove include comment.
4910         * inflow.c (class scoped_ignore_sigttou): Move from here...
4911         * inflow.h (class scoped_ignore_sigttou): ...to here.
4912         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4913         * top.c:  Remove include comment.
4914
4915 2019-05-27  Tom Tromey  <tom@tromey.com>
4916
4917         * NEWS: Fix typo.
4918
4919 2019-05-22  Tom Tromey  <tromey@adacore.com>
4920
4921         * target.c (target_follow_exec): Constify parameter.
4922         * target-delegates.c: Rebuild.
4923         * remote.c (remote_target::follow_exec): Constify parameter.
4924         * infrun.c (follow_exec): Constify parameter.
4925         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4926         (target_follow_exec): Likewise.
4927
4928 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4929
4930         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4931         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4932
4933 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4934
4935         * NEWS: Add debugredirect and testsuite sections.
4936
4937 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4938
4939         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4940         target descriptions using exclusively floating point register name
4941         aliases.
4942
4943 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4944
4945         PR gdb/18644:
4946         * f-lang.c (build_fortran_types): Handle the case where
4947         gdbarch_floatformat_for_type returns a nullptr.
4948
4949 2019-05-21  Tom de Vries  <tdevries@suse.de>
4950
4951         PR cli/24587
4952         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4953
4954 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4955
4956         PR gdb/18644:
4957         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4958         16-byte floats.
4959         * i386-tdep.c (i386_floatformat_for_type): Use
4960         floatformats_ia64_quad for the 16-byte floating point component
4961         within a fortran 32-byte complex number.
4962
4963 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4964
4965         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4966         delete default constructor.
4967         (find_partial_die): Update to return const struct.
4968         (partial_die_parent_scope): Move variable declaration into scope
4969         of its use and change its type to auto.
4970         (guess_partial_die_structure_name): Likewise.
4971         (partial_die_info::fixup): Likewise.
4972
4973 2019-05-17  Tom Tromey  <tromey@adacore.com>
4974
4975         * source.c (find_and_open_source): Remove cast.
4976
4977 2019-05-17  Tom Tromey  <tromey@adacore.com>
4978
4979         * annotate.c (annotate_source): Make "filename" const.
4980         * annotate.h (annotate_source): Use const.
4981
4982 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4983
4984         * disasm.c (set_disassembler_options): Send errors to stderr.
4985
4986 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4987
4988         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4989         (cli_interp_base::set_logging): Check debug_redirect.
4990         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4991         * cli/cli-logging.c (debug_redirect): Add static variable.
4992         (pop_output_files): Add default param.
4993         (handle_redirections): Print debug setting.
4994         (show_logging_command): Likewise.
4995         (_initialize_cli_logging): Add debugredirect command.
4996         * interps.c (current_interp_set_logging): Add debug_redirect
4997         parameter.
4998         * interps.h (set_logging): Add debug_redirect parameter.
4999         (current_interp_set_logging): Likewise.
5000         * mi/mi-common.h: Likewise.
5001         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5002
5003 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5004             Tom Tromey  <tromey@adacore.com>
5005
5006         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5007         directly.
5008         * cli/cli-interp.h (make_logging_output): Remove declaration.
5009         * cli/cli-logging.c (make_logging_output): Remove function.
5010         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5011         directly.
5012         * ui-file.c (tee_file::tee_file): Remove bools.
5013         (tee_file::~tee_file): Remove deletes.
5014         * ui-file.h (tee_file): Remove bools.
5015
5016 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5017
5018         * mi/mi-cmds.h (mi_cmd_complete): New function.
5019         * mi/mi-main.c (mi_cmd_complete): Likewise.
5020         * mi/mi-cmds.c: Define new MI command -complete.
5021         * NEWS: Mention new -complete command.
5022
5023 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5024
5025         * completer.h (complete): New function.
5026         * completer.c (complete): Likewise.
5027         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5028         function defined in completer.h.
5029
5030 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5031
5032         * MAINTAINERS (Write After Approval): Add myself.
5033
5034 2019-05-17  Tom de Vries  <tdevries@suse.de>
5035
5036         PR gdb/24094
5037         * dwarf2read.c (struct cu_partial_die_info): New struct.
5038         (find_partial_die): Return cu_partial_die_info.
5039         (partial_die_parent_scope, guess_partial_die_structure_name)
5040         (partial_die_info::fixup): Handle new return type of find_partial_die.
5041
5042 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5043
5044         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5045         "std::string", simplifying the algorithm.
5046
5047 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5048
5049         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5050         (stap_static_probe_ops::get_probes): Likewise.
5051
5052 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5053
5054         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5055         '-')" and "else if".
5056         (stap_parse_single_operand): Join checks for
5057         "gdbarch_stap_parse_special_token_p" and
5058         "gdbarch_stap_parse_special_token" in the same "if" statement.
5059         Invert check when verifying for operation on register
5060         displacement.
5061
5062 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5063
5064         * stap-probe.c (stap_get_opcode): Update comment.
5065         (stap_get_expected_argument_type): Likewise.
5066         (handle_stap_probe): Likewise.
5067
5068 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5069
5070         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5071         return type to 'bool'.  Adjust comment.  Use 'bool' when
5072         appropriate.
5073         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5074         * stap-probe.c (stap_parse_argument_1): Likewise.
5075         (stap_is_operator): Likewise.
5076         (stap_is_generic_prefix): Likewise.
5077         (stap_is_register_prefix): Likewise.
5078         (stap_is_register_indirection_prefix): Likewise.
5079         (stap_is_integer_prefix): Likewise.
5080         (stap_generic_check_suffix): Likewise.
5081         (stap_check_integer_suffix): Likewise.
5082         (stap_check_register_suffix): Likewise.
5083         (stap_check_register_indirection_suffix): Likewise.
5084         (stap_parse_register_operand): Likewise.
5085         (stap_parse_single_operand): Likewise.
5086         (stap_parse_argument_1): Likewise.
5087         (stap_probe::get_argument_count): Likewise.
5088         (stap_is_operator): Likewise.
5089
5090 2019-05-16  Tom Tromey  <tromey@adacore.com>
5091
5092         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5093         keyword to foreach.
5094
5095 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5096
5097         * linux-thread-db.c (try_thread_db_load_1): Change return type
5098         to bool.
5099         (try_thread_db_load): Likewise.
5100         (try_thread_db_load_from_pdir_1): Likewise.
5101         (try_thread_db_load_from_pdir): Likewise.
5102         (try_thread_db_load_from_sdir): Likewise.
5103         (try_thread_db_load_from_dir): Likewise.
5104         (thread_db_load_search): Likewise.
5105         (has_libpthread): Likewise.
5106         (thread_db_load): Likewise.
5107
5108 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5109
5110         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5111         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5112         NULL, and complain/return if that's the case.
5113
5114 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5115
5116         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5117         (advance, posn, abstract_read_memory): New functions.
5118         [struct mem_read_abstraction]: New struct.
5119         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5120
5121 2019-05-14  Tom Tromey  <tromey@adacore.com>
5122
5123         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5124         value is not lval_memory.
5125
5126 2019-05-14  Tom Tromey  <tromey@adacore.com>
5127
5128         * solib.c (info_sharedlibrary_command): Style the file name.
5129
5130 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5131
5132         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5133         (aarch64_vnv_type): Likewise.
5134         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5135         * common/tdesc.c: Likewise.
5136         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5137         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5138         * features/aarch64-fpu.xml: Add ieee half view.
5139         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5140         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5141         * gdbtypes.h (struct builtin_type): Likewise.
5142         (struct objfile_type): Likewise.
5143
5144 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5145
5146         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5147         typo.
5148         * location.h (string_to_event_location): Likewise.
5149
5150 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5151
5152         GDB 8.3 released.
5153
5154 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5155
5156         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5157         New variable declaration.
5158         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5159         New variable.
5160         (print_one_breakpoint): Use ui_out::test_flags and new global
5161         variable to compute use_fixed_output.
5162         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5163         Remove.
5164         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5165         (mi_multi_location_breakpoint_output_fixed): Remove.
5166         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5167         new variable.
5168         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5169         fix_multi_location_breakpoint_output flag if version >= 3.
5170         * ui-out.h (enum ui_out_flag)
5171         <fix_multi_location_breakpoint_output>: New enumerator.
5172
5173 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5174
5175         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5176
5177 2019-05-10  Tom Tromey  <tromey@adacore.com>
5178
5179         * ada-lang.c (catch_ada_completer): New function.
5180         (_initialize_ada_language): Use it.
5181
5182 2019-05-10  Tom Tromey  <tromey@adacore.com>
5183
5184         * thread.c (print_thread_info): Make "requested_threads" const.
5185         * gdbthread.h (print_thread_info): Make "requested_threads"
5186         const.
5187         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5188         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5189
5190 2019-05-08  Tom Tromey  <tom@tromey.com>
5191
5192         * gdbtypes.c (objfile_type_data): Change type.
5193         (objfile_type, _initialize_gdbtypes): Update.
5194
5195 2019-05-08  Tom Tromey  <tom@tromey.com>
5196
5197         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5198         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5199         (_initialize_dwarf2_frame): Update.
5200
5201 2019-05-08  Tom Tromey  <tom@tromey.com>
5202
5203         * objc-lang.c (objc_objfile_data): Change type.
5204         (find_methods): Update.
5205         (_initialize_objc_lang): Remove.
5206
5207 2019-05-08  Tom Tromey  <tom@tromey.com>
5208
5209         * stabsread.c (rs6000_builtin_type_data): Change type.
5210         (rs6000_builtin_type, _initialize_stabsread): Update.
5211
5212 2019-05-08  Tom Tromey  <tom@tromey.com>
5213
5214         * mips-tdep.c (mips_pdr_data): Remove.
5215         (_initialize_mips_tdep): Update.
5216
5217 2019-05-08  Tom Tromey  <tom@tromey.com>
5218
5219         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5220         (hppa_init_objfile_priv_data, read_unwind_info)
5221         (find_unwind_entry, _initialize_hppa_tdep): Update.
5222
5223 2019-05-08  Tom Tromey  <tom@tromey.com>
5224
5225         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5226         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5227         on obstack.
5228         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5229
5230 2019-05-08  Tom Tromey  <tom@tromey.com>
5231
5232         * mdebugread.c (basic_type_data): Change type.
5233         (basic_type, _initialize_mdebugread): Update.
5234
5235 2019-05-08  Tom Tromey  <tom@tromey.com>
5236
5237         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5238
5239 2019-05-08  Tom Tromey  <tom@tromey.com>
5240
5241         * nto-tdep.c (nto_inferior_data_reg): Change type.
5242         (nto_inferior_data): Update.
5243         (nto_inferior_data_cleanup, nto_new_inferior_data)
5244         (_initialize_nto_tdep): Remove.
5245         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5246
5247 2019-05-08  Tom Tromey  <tom@tromey.com>
5248
5249         * ada-lang.c (struct ada_inferior_data): Add initializers.
5250         (ada_inferior_data): Change type.
5251         (ada_inferior_data_cleanup): Remove.
5252         (get_ada_inferior_data, ada_inferior_exit)
5253         (struct ada_pspace_data): Add initializers, destructor.
5254         (ada_pspace_data_handle): Change type.
5255         (get_ada_pspace_data): Update.
5256         (ada_pspace_data_cleanup): Remove.
5257
5258 2019-05-08  Tom Tromey  <tom@tromey.com>
5259
5260         * coffread.c (struct coff_symfile_info): Add initializers.
5261         (coff_objfile_data_key): Move lower.  Change type.
5262         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5263         Update.
5264         (coff_free_info): Remove.
5265
5266 2019-05-08  Tom Tromey  <tom@tromey.com>
5267
5268         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5269         (fbsd_pspace_data_handle): Move lower.  Change type.
5270         (get_fbsd_pspace_data): Update.
5271         (fbsd_pspace_data_cleanup): Remove.
5272         (_initialize_fbsd_tdep): Update.
5273
5274 2019-05-08  Tom Tromey  <tom@tromey.com>
5275
5276         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5277         (get_ada_tasks_pspace_data): Update.
5278         (ada_tasks_pspace_data_cleanup): Remove.
5279         (_initialize_tasks): Update.
5280         (ada_tasks_inferior_data_handle): Change type.
5281         (get_ada_tasks_inferior_data): Update.
5282         (ada_tasks_inferior_data_cleanup): Remove.
5283         (struct ada_tasks_pspace_data): Add initializers.
5284
5285 2019-05-08  Tom Tromey  <tom@tromey.com>
5286
5287         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5288         * symfile-debug.c (debug_sym_get_probes): Change type.
5289         * stap-probe.c (handle_stap_probe):
5290         (stap_static_probe_ops::get_probes): Change type.
5291         * probe.h (class static_probe_ops) <get_probes>: Change type.
5292         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5293         (parse_probes_in_pspace): Update.
5294         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5295         Update.
5296         (any_static_probe_ops::get_probes): Change type.
5297         * elfread.c (elfread_data): New typedef.
5298         (probe_key): Change type.
5299         (elf_get_probes): Likewise.  Update.
5300         (probe_key_free): Remove.
5301         (_initialize_elfread): Update.
5302         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5303         Change type.
5304         (dtrace_process_dof_probe, dtrace_process_dof)
5305         (dtrace_static_probe_ops::get_probe): Change type.
5306
5307 2019-05-08  Tom Tromey  <tom@tromey.com>
5308
5309         * xcoffread.c (struct xcoff_symfile_info): Rename from
5310         coff_symfile_info.  Add initializers.
5311         (xcoff_objfile_data_key): Move lower.  Change type.
5312         (XCOFF_DATA): Rewrite.
5313         (xcoff_free_info): Remove.
5314         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5315         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5316         (xcoff_initial_scan): Update.
5317
5318 2019-05-08  Tom Tromey  <tom@tromey.com>
5319
5320         * solib-svr4.c (struct svr4_info): Add initializers and
5321         destructor.
5322         <probes_table>: Now an htab_up.
5323         (solib_svr4_pspace_data): Change type.
5324         (free_probes_table): Simplify.
5325         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5326         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5327         (probes_table_remove_objfile_probes, register_solib_event_probe)
5328         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5329         (_initialize_svr4_solib): Update.
5330
5331 2019-05-08  Tom Tromey  <tom@tromey.com>
5332
5333         * remote.c (remote_pspace_data): Change type.
5334         (remote_pspace_data_cleanup): Remove.
5335         (get_remote_exec_file, set_pspace_remote_exec_file)
5336         (_initialize_remote): Update.
5337
5338 2019-05-08  Tom Tromey  <tom@tromey.com>
5339
5340         * breakpoint.c (breakpoint_objfile_key): Change type.
5341         (get_breakpoint_objfile_data): Update.
5342         (free_breakpoint_objfile_data): Remove.
5343         (_initialize_breakpoint): Update.
5344
5345 2019-05-08  Tom Tromey  <tom@tromey.com>
5346
5347         * linux-tdep.c (struct linux_info): Add initializers.
5348         (linux_inferior_data): Move.  Change type.
5349         (invalidate_linux_cache_inf): Update.
5350         (linux_inferior_data_cleanup): Remove.
5351         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5352
5353 2019-05-08  Tom Tromey  <tom@tromey.com>
5354
5355         * auxv.c (auxv_inferior_data): Move.  Change type.
5356         (auxv_inferior_data_cleanup): Remove.
5357         (invalidate_auxv_cache_inf): Rewrite.
5358         (get_auxv_inferior_data, _initialize_auxv): Update.
5359
5360 2019-05-08  Tom Tromey  <tom@tromey.com>
5361
5362         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5363         (symfile_debug_objfile_data_key): Change type.
5364         (symfile_debug_installed, debug_qf_has_symbols)
5365         (debug_qf_find_last_source_symtab)
5366         (debug_qf_forget_cached_source_info)
5367         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5368         (debug_qf_print_stats, debug_qf_dump)
5369         (debug_qf_expand_symtabs_for_function)
5370         (debug_qf_expand_all_symtabs)
5371         (debug_qf_expand_symtabs_with_fullname)
5372         (debug_qf_map_matching_symbols)
5373         (debug_qf_expand_symtabs_matching)
5374         (debug_qf_find_pc_sect_compunit_symtab)
5375         (debug_qf_map_symbol_filenames)
5376         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5377         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5378         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5379         (debug_sym_read_linetable, debug_sym_relocate): Update.
5380         (symfile_debug_free_objfile): Remove.
5381         (install_symfile_debug_logging, _initialize_symfile_debug):
5382         Update.
5383
5384 2019-05-08  Tom Tromey  <tom@tromey.com>
5385
5386         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5387         allocate_on_obstack.
5388         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5389         (get_dwarf2_per_objfile): Update.
5390         (set_dwarf2_per_objfile): Remove.
5391         (dwarf2_has_info, dwarf2_get_section_info): Update.
5392         (dwarf2_free_objfile): Remove.
5393         (_initialize_dwarf2_read): Update.
5394
5395 2019-05-08  Tom Tromey  <tom@tromey.com>
5396
5397         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5398         initializers.
5399         <unsupported_script_warning_printed,
5400         script_not_found_warning_printed>: Now bool.
5401         (auto_load_pspace_data): Change type.
5402         (~auto_load_pspace_info): Rename from
5403         auto_load_pspace_data_cleanup.
5404         (get_auto_load_pspace_data, init_loaded_scripts_info)
5405         (clear_section_scripts, maybe_print_unsupported_script_warning)
5406         (maybe_print_script_not_found_warning, _initialize_auto_load):
5407         Update.
5408
5409 2019-05-08  Tom Tromey  <tom@tromey.com>
5410
5411         * objfiles.c (objfile_pspace_info): Add destructor and
5412         initializers.
5413         (objfiles_pspace_data): Change type.
5414         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5415         (get_objfile_pspace_data): Update.
5416         (objfiles_bfd_data): Change type.
5417         (get_objfile_bfd_data): Update.
5418         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5419
5420 2019-05-08  Tom Tromey  <tom@tromey.com>
5421
5422         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5423         Change type.
5424         (get_catch_syscall_inferior_data): Update.
5425         (catch_syscall_inferior_data_cleanup): Remove.
5426         (_initialize_break_catch_syscall): Update.
5427
5428 2019-05-08  Tom Tromey  <tom@tromey.com>
5429
5430         * inflow.c (struct terminal_info): Add destructor and
5431         initializers.
5432         (inflow_inferior_data): Change type.
5433         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5434         (get_inflow_inferior_data, inflow_inferior_exit)
5435         (swap_terminal_info, _initialize_inflow): Update.
5436
5437 2019-05-08  Tom Tromey  <tom@tromey.com>
5438
5439         * target-dcache.c (target_dcache_cleanup): Remove.
5440         (target_dcache_aspace_key): Change type.
5441         (target_dcache_init_p, target_dcache_invalidate)
5442         (target_dcache_get, target_dcache_get_or_init)
5443         (_initialize_target_dcache): Update.
5444         * dcache.h (struct dcache_deleter): New.
5445
5446 2019-05-08  Tom Tromey  <tom@tromey.com>
5447
5448         * symtab.c (struct symbol_cache): Add destructor and
5449         initializers.
5450         (symbol_cache_key): Move.  Change type.
5451         (make_symbol_cache, free_symbol_cache): Remove.
5452         (get_symbol_cache): Update.
5453         (symbol_cache_cleanup): Remove.
5454         (ALL_PSPACES, symbol_cache_flush)
5455         (maintenance_print_symbol_cache)
5456         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5457         Update.
5458
5459 2019-05-08  Tom Tromey  <tom@tromey.com>
5460
5461         * symtab.c (struct main_info): Add destructor and initializers.
5462         (main_progspace_key): Move.  Change type.
5463         (get_main_info): Update.
5464         (main_info_cleanup): Remove.
5465         (_initialize_symtab): Update.
5466
5467 2019-05-08  Tom Tromey  <tom@tromey.com>
5468
5469         * registry.h (DECLARE_REGISTRY): Define the _key class.
5470
5471 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5472
5473         * NEWS: Merge two 'New commands' sections.
5474
5475 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5476
5477         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5478         parameter and use Ada language definition instead.
5479         (ada_val_print_ptr): Remove unused language parameter.
5480         (ada_val_print_num): Remove language parameter and use Ada language
5481         definition instead.
5482         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5483         parameter.
5484         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5485         parameter and use Ada language definition instead.
5486         (ada_val_print_1): Update all ada_val_print_xxx calls.
5487         Remove language parameter.
5488         (ada_val_print): Update ada_val_print_1 call.
5489
5490 2019-05-08  Tom Tromey  <tromey@adacore.com>
5491
5492         * remote.c (remote_hw_watchpoint_limit)
5493         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5494         Now static.
5495
5496 2019-05-08  Tom Tromey  <tromey@adacore.com>
5497
5498         * maint.c (_initialize_maint_cmds): Move initialization code to
5499         remote.c.
5500         (watchdog, show_watchdog): Move to remote.c.
5501         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5502         "watchdog" static.
5503         (_initialize_remote): Move initialization code from maint.c.
5504         * defs.h (watchdog): Don't declare.
5505
5506 2019-05-08  Tom Tromey  <tromey@adacore.com>
5507
5508         * tui/tui-interp.c: Include main.h.
5509         * interps.c: Include main.h.
5510         * main.h (interpreter_p): Declare.
5511         * defs.h (interpreter_p): Don't declare.
5512
5513 2019-05-08  Tom Tromey  <tromey@adacore.com>
5514
5515         * dwarf2loc.c: Include dwarf2read.h.
5516         * defs.h (read_unsigned_leb128): Don't declare.
5517         * dwarf2read.h (read_unsigned_leb128): Declare.
5518
5519 2019-05-08  Tom Tromey  <tromey@adacore.com>
5520
5521         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5522         method.
5523
5524 2019-05-08  Tom Tromey  <tromey@adacore.com>
5525
5526         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5527         when no wrap column is set.
5528
5529 2019-05-08  Tom Tromey  <tromey@adacore.com>
5530
5531         * c-lang.c (c_get_string): Handle non-C-style arrays.
5532
5533 2019-05-08  Tom Tromey  <tromey@adacore.com>
5534
5535         * typeprint.c (print_offset_data::update): Print the bit offset,
5536         not the number of bits remaining.
5537
5538 2019-05-08  Tom Tromey  <tromey@adacore.com>
5539
5540         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5541         padding at end of comment.
5542
5543 2019-05-08  Tom Tromey  <tromey@adacore.com>
5544
5545         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5546         Compare main types.
5547
5548 2019-05-06  Tom Tromey  <tom@tromey.com>
5549
5550         * common/scoped_mmap.c: Include common-defs.h.
5551         * common/scoped_mmap.h: Don't include config.h.
5552
5553 2019-05-04  Tom Tromey  <tom@tromey.com>
5554
5555         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5556         (struct aarch64_call_info): Add initializers.
5557         <si>: Now a std::vector.
5558         (pass_on_stack, aarch64_push_dummy_call): Update.
5559
5560 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5561             Tom Tromey  <tom@tromey.com>
5562
5563         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5564         (ppc_threads): Now a std::vector.  Now static.
5565         (hwdebug_find_thread_points_by_tid)
5566         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5567         Update.
5568
5569 2019-05-04  Tom Tromey  <tom@tromey.com>
5570
5571         * arc-tdep.c (arc_tdesc_init): Return bool.
5572
5573 2019-05-04  Tom Tromey  <tom@tromey.com>
5574
5575         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5576         Use gdb_assert_not_reached.
5577
5578 2019-05-04  Tom Tromey  <tom@tromey.com>
5579
5580         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5581         "false".
5582
5583 2019-05-04  Tom Tromey  <tom@tromey.com>
5584
5585         * arc-tdep.c (arc_tdesc_init): Use bool.
5586
5587 2019-05-04  Tom Tromey  <tom@tromey.com>
5588
5589         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5590
5591 2019-05-04  Tom Tromey  <tom@tromey.com>
5592
5593         * cli/cli-cmds.c (valid_command_p): Return bool.
5594
5595 2019-05-04  Tom Tromey  <tom@tromey.com>
5596
5597         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5598         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5599
5600 2019-05-04  Raul Tambre  <raul@tambre.ee>
5601
5602         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5603         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5604         operator for comparison.
5605
5606 2019-05-04  Tom Tromey  <tom@tromey.com>
5607
5608         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5609         (lookup_partial_symbol, print_partial_symbols)
5610         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5611         (psymbol_compare): Update.
5612         (add_psymbol_to_bcache): Clear the entire psymbol.
5613         (maintenance_check_psymtabs): Update.
5614         * psympriv.h (struct partial_symbol): Don't derive from
5615         general_symbol_info.
5616         <obj_section, unrelocated_address, address,
5617         set_unrelocated_address>: Update.
5618         <ginfo>: New member.
5619         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5620         (debug_names::write_psymbols): Update.
5621
5622 2019-05-04  Tom de Vries  <tdevries@suse.de>
5623
5624         * contrib/cc-with-tweaks.sh: Support -n arg.
5625
5626 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5627
5628         * corelow.c (core_target::detach): Ensure frame cache and
5629         register caches are cleared.
5630         inferior.c (exit_inferior_1): Likewise.
5631
5632 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5633             Tom Tromey  <tom@tromey.com>
5634
5635         * dictionary.c (collate_pending_symbols_by_language): Remove
5636         "struct" from foreach.
5637         * symtab.c (lookup_global_symbol_from_objfile)
5638         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5639         foreach.
5640         * ser-tcp.c (net_open): Remove "struct" from foreach.
5641         * objfiles.c (objfile_relocate, objfile_rebase)
5642         (objfile_has_symbols): Remove "struct" from foreach.
5643         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5644         from foreach.
5645         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5646         foreach.
5647         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5648         "struct" from foreach.
5649         * ada-lang.c (create_excep_cond_exprs)
5650         (ada_exception_catchpoint_cond_string): Remove "struct" from
5651         foreach.
5652
5653 2019-05-03  Tom Tromey  <tromey@adacore.com>
5654
5655         * ada-exp.y (convert_char_literal): Check suffix of each
5656         enumerator.
5657
5658 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5659
5660         PR ada/21406:
5661         * ada-exp.y (yywrap): Don't define.
5662         * ada-lex.l (%option): Add noyywrap
5663         (yywrap): Remove.
5664
5665 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5666
5667         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5668         _WIN32_WINNT to the XP level, unless already defined to a higher
5669         level.
5670
5671         * unittests/parse-connection-spec-selftests.c:
5672         * ser-tcp.c:
5673         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5674         override.
5675
5676         * symfile.c (find_separate_debug_file): Remove colon from the
5677         drive spec of DOS/Windows file names of the target, so that the
5678         file name produced from DEBUGDIR and the target's directory will
5679         be valid on DOS/Windows systems.
5680
5681 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5682
5683         * rust-lang.c (val_print_struct): Handle printing structures
5684         containing strings.
5685
5686 2019-05-02  Tom Tromey  <tromey@adacore.com>
5687
5688         * valarith.c (_initialize_valarith): Remove.
5689
5690 2019-05-01  Tom Tromey  <tromey@adacore.com>
5691
5692         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5693         bitfields.
5694
5695 2019-05-01  Tom Tromey  <tromey@adacore.com>
5696
5697         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5698         for big-endian copies.
5699
5700 2019-04-30  Ali Tamur  <tamur@google.com>
5701         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5702         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5703         (read_3_bytes): New function.
5704
5705 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5706
5707         * windows-nat.c (main_thread_id): Delete.
5708         (handle_output_debug_string): Replace main_thread_id by
5709         current_event.dwThreadId.
5710         (fake_create_process): Likewise.
5711         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5712         Do not set main_thread_id.
5713         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5714         current_event.dwThreadId.
5715         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5716
5717 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5718
5719         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5720         Use current_event.dwThreadId instead of main_thread_id.
5721
5722 2019-04-30  Tom Tromey  <tromey@adacore.com>
5723
5724         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5725         (create_excep_cond_exprs): Iterate over program spaces.
5726         (ada_exception_catchpoint_cond_string): Examine all minimal
5727         symbols for exception types.
5728
5729 2019-04-30  Tom Tromey  <tromey@adacore.com>
5730
5731         PR c++/24470:
5732         * dwarf2read.c (process_structure_scope): Handle case where type
5733         has template parameters but no symbol was created.
5734
5735 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5736             Chris January  <chris.january@arm.com>
5737
5738         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5739         qualifier.
5740         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5741
5742 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5743
5744         * f-typeprint.c (f_print_type): Update rules for printing
5745         whitespace.
5746         (f_type_print_varspec_suffix): Likewise.
5747
5748 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5749             Chris January  <chris.january@arm.com>
5750
5751         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5752         function arguments.
5753
5754 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5755
5756         * f-lang.c (build_fortran_types): Change name of void type to
5757         lower case.
5758         * f-typeprint.c (f_type_print_base): Print the name of the void
5759         type, rather than a fixed string.
5760         * f-valprint.c (f_decorations): Use lower case void string.
5761
5762 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5763             Chris January  <chris.january@arm.com>
5764
5765         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5766         types for Fortran.
5767
5768 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5769             Chris January  <chris.january@arm.com>
5770             David Lecomber  <david.lecomber@arm.com>
5771
5772         * f-exp.y (BINOP_INTRINSIC): New token.
5773         (exp): New parser rule handling BINOP_INTRINSIC.
5774         (f77_keywords): Add new builtin procedures.
5775         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5776         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5777         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5778         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5779         (print_unop_subexp_f): New function.
5780         (print_binop_subexp_f): New function.
5781         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5782         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5783         (dump_subexp_body_f): Likewise.
5784         (operator_check_f): Likewise.
5785         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5786         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5787
5788 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5789
5790         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5791         UNOP_KIND.
5792         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5793         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5794         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5795         (operator_length_f): New fuction.
5796         (print_subexp_f): New function.
5797         (op_name_f): New function.
5798         (dump_subexp_body_f): New function.
5799         (operator_check_f): New function.
5800         (exp_descriptor_f): Replace standard expression handling functions
5801         with new functions.
5802         * gdb/fortran-operator.def: New file.
5803         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5804         * gdb/std-operator.def: Remove UNOP_KIND.
5805
5806 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * std-operator.def: Remove unbalanced, stray double quote
5809         character.
5810
5811 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5812             Chris January  <chris.january@arm.com>
5813             Daniel Everett  <daniel.everett@arm.com>
5814             Nick Forrington  <nick.forrington@arm.com>
5815             Richard Bunt  <richard.bunt@arm.com>
5816
5817         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5818         of depth when printing anonymous structs or unions.
5819         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5820         Don't print either the top-level value, or the children if the
5821         max-depth is exceeded.
5822         (ppscm_print_children): When printing the key of a map, allow one
5823         extra level of depth.
5824         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5825         print either the top-level value, or the children if the max-depth
5826         is exceeded.
5827         (print_children): When printing the key of a map, allow one extra
5828         level of depth.
5829         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5830         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5831         (user_print_options): Initialise max_depth field.
5832         (val_print_scalar_or_string_type_p): New function.
5833         (val_print): Check to see if the max depth has been reached.
5834         (val_print_check_max_depth): Define new function.
5835         (show_print_max_depth): New function.
5836         (_initialize_valprint): Add 'print max-depth' option.
5837         * valprint.h (struct value_print_options) <max_depth>: New field.
5838         (val_print_check_max_depth): Declare new function.
5839         * NEWS: Document new feature.
5840
5841 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5842
5843         * ada-lang.c (ada_language_defn): Initialise new field.
5844         * c-lang.c (c_is_string_type_p): New function.
5845         (c_language_defn): Initialise new field.
5846         (cplus_language_defn): Initialise new field.
5847         (asm_language_defn): Initialise new field.
5848         (minimal_language_defn): Initialise new field.
5849         * c-lang.h (c_is_string_type_p): Declare new function.
5850         * d-lang.c (d_language_defn): Initialise new field.
5851         * f-lang.c (f_is_string_type_p): New function.
5852         (f_language_defn): Initialise new field.
5853         * go-lang.c (go_is_string_type_p): New function.
5854         (go_language_defn): Initialise new field.
5855         * language.c (default_is_string_type_p): New function.
5856         (unknown_language_defn): Initialise new field.
5857         (auto_language_defn): Initialise new field.
5858         * language.h (struct language_defn) <la_is_string_type_p>: New
5859         member variable.
5860         (default_is_string_type_p): Declare new function.
5861         * m2-lang.c (m2_language_defn): Initialise new field.
5862         * objc-lang.c (objc_language_defn): Initialise new field.
5863         * opencl-lang.c (opencl_language_defn): Initialise new field.
5864         * p-lang.c (pascal_is_string_type_p): New function.
5865         (pascal_language_defn): Initialise new field.
5866         * rust-lang.c (rust_is_string_type_p): New function.
5867         (rust_language_defn): Initialise new field.
5868
5869 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5870
5871         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5872         New field.
5873         * ada-lang.c (ada_language_defn): Initialise new field.
5874         * c-lang.c (c_language_defn): Likewise.
5875         (cplus_language_defn): Likewise.
5876         (asm_language_defn): Likewise.
5877         (minimal_language_defn): Likewise.
5878         * d-lang.c (d_language_defn): Likewise.
5879         * f-lang.c (f_language_defn): Likewise.
5880         * go-lang.c (go_language_defn): Likewise.
5881         * language.c (unknown_language_defn): Likewise.
5882         (auto_language_defn): Likewise.
5883         * m2-lang.c (m2_language_defn): Likewise.
5884         * objc-lang.c (objc_language_defn): Likewise.
5885         * opencl-lang.c (opencl_language_defn): Likewise.
5886         * p-lang.c (pascal_language_defn): Likewise.
5887         * rust-lang.c (rust_language_defn): Likewise.
5888
5889 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5890
5891         * ada-lang.c (ada_is_character_type): Change return type to bool.
5892         (ada_is_string_type): Likewise.
5893         * ada-lang.h (ada_is_character_type): Update declaration
5894         (ada_is_string_type): Likewise.
5895
5896 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5897
5898         Support style in 'frame|thread apply'
5899
5900         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5901         * record.c (record_start, record_stop): Update callers of
5902         execute_command_to_string with false.
5903         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5904         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5905         methods.
5906         (class string_file): New constructor with term_out parameter.
5907         Override methods term_out and can_emit_style_escape.  New member
5908         term_out.
5909         (class stdio_file): Override can_emit_style_escape.
5910         (class tee_file): Override term_out and can_emit_style_escape.
5911         * utils.h (can_emit_style_escape): Remove.
5912         * utils.c (can_emit_style_escape): Likewise.
5913         Update all callers of can_emit_style_escape (SOMESTREAM) to
5914         SOMESTREAM->can_emit_style_escape.
5915         * source-cache.c (source_cache::get_source_lines): Likewise.
5916         * stack.c (frame_apply_command_count): Call execute_command_to_string
5917         passing the term_out characteristic of the current gdb_stdout.
5918         * thread.c (thr_try_catch_cmd): Likewise.
5919         * top.c (execute_command_to_string): pass term_out parameter
5920         to construct the string_file for the command output.
5921         * ui-file.c (term_cli_styling): New function (most code moved
5922         from utils.c can_emit_style_escape).
5923         (string_file::string_file, string_file::can_emit_style_escape,
5924         stdio_file::can_emit_style_escape, tee_file::term_out,
5925         tee_file::can_emit_style_escape): New functions.
5926
5927 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5928
5929         * NEWS: Mention the new set|show may-call-functions.
5930         * infcall.c (may_call_functions_p): New variable.
5931         (show_may_call_functions_p): New function.
5932         (call_function_by_hand_dummy): Throws an error if not
5933         may-call-functions.
5934         (_initialize_infcall): Call add_setshow_boolean_cmd for
5935         may-call-functions.
5936
5937 2019-04-25  Keith Seitz  <keiths@redhat.com>
5938
5939         PR c++/24367
5940         * cp-support.c (inspect_type): Don't attempt substitutions
5941         of symbol with the same name.
5942
5943 2019-04-25  Tom Tromey  <tromey@adacore.com>
5944
5945         PR gdb/24475:
5946         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5947         static.
5948
5949 2019-04-25  Tom Tromey  <tromey@adacore.com>
5950
5951         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5952         rvalue reference.
5953         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5954         (gdb_xml_parser::parse): Use std::move.
5955         * python/python-internal.h (gdbpy_convert_exception): Take a const
5956         reference.
5957         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5958         std::move.
5959         * python/py-utils.c (gdbpy_convert_exception): Take a const
5960         reference.
5961         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5962         Use std::move.
5963         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5964         Use std::move.
5965         * mi/mi-main.c (mi_print_exception): Take a const reference.
5966         * main.c (handle_command_errors): Take a const reference.
5967         * linespec.c (parse_linespec): Use std::move.
5968         * infcall.c (run_inferior_call): Use std::move.
5969         (call_function_by_hand_dummy): Use std::move.
5970         * exec.c (try_open_exec_file): Use std::move.
5971         * exceptions.h (exception_print, exception_fprintf)
5972         (exception_print_same): Update.
5973         * exceptions.c (print_exception, exception_print)
5974         (exception_fprintf, exception_print_same): Change parameters to
5975         const reference.
5976         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5977         * common/new-op.c: Use std::move.
5978         * common/common-exceptions.h (struct gdb_exception): Add move
5979         constructor.
5980         (struct gdb_exception_error, struct gdb_exception_quit, struct
5981         gdb_quit_bad_alloc): Change constructor to move constructor.
5982         (throw_exception): Change parameter to rvalue reference.
5983         * common/common-exceptions.c (throw_exception): Take rvalue
5984         reference.
5985         * cli/cli-interp.c (safe_execute_command): Use std::move.
5986         * breakpoint.c (insert_bp_location, location_to_sals): Use
5987         std::move.
5988
5989 2019-04-25  Tom Tromey  <tromey@adacore.com>
5990
5991         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5992         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5993         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5994         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5995         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5996         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5997         guile/scm-value.c: Use unpack.
5998         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5999         gdbscm_gdb_exception.
6000         (gdbscm_throw_gdb_exception): Likewise.
6001         (struct gdbscm_gdb_exception): New.
6002         (unpack): New function.
6003         (gdbscm_wrap): Use unpack.
6004
6005 2019-04-25  Tom Tromey  <tromey@adacore.com>
6006
6007         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6008         (gdb_rl_callback_handler): Use std::move.
6009         * common/common-exceptions.h (struct gdb_exception): Add move
6010         assignment operator.
6011         (throw_exception_sjlj): Change "exception" to const reference.
6012         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6013         (throw_exception_sjlj): Change "exception" to const reference.
6014
6015 2019-04-25  Tom Tromey  <tromey@adacore.com>
6016
6017         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6018         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6019         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6020         Update.
6021         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6022         Update.
6023         * mi/mi-interp.c (mi_interp::exec): Update.
6024         * linespec.c (parse_linespec): Update.
6025         * infcall.c (run_inferior_call): Update.
6026         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6027         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6028         (gdbscm_lookup_global_symbol): Update.
6029         * guile/scm-param.c (gdbscm_parameter_value): Update.
6030         * guile/scm-frame.c (gdbscm_frame_read_register)
6031         (gdbscm_frame_read_var): Update.
6032         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6033         * exec.c (try_open_exec_file): Update.
6034         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6035         (gdb_rl_callback_handler): Update.
6036         * common/common-exceptions.h (exception_none): Don't declare.
6037         * common/common-exceptions.c (exception_none): Don't define.
6038         (struct catcher) <exception>: Update.
6039         * cli/cli-interp.c (safe_execute_command): Update.
6040         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6041
6042 2019-04-25  Ali Tamur  <tamur@google.com>
6043
6044         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6045         (read_attribute_value): Likewise.
6046         (dwarf2_read_addr_index): Update comment.
6047         (read_str_index): Add DW_FORM_strx.
6048         (dwarf2_string_attr): Likewise.
6049         (dwarf2_const_value_attr): Likewise.
6050         (dump_die_shallow): Likewise.
6051         (dwarf2_fetch_constant_bytes): Likewise.
6052         (skip_form_bytes): Likewise.
6053         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6054
6055 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6056
6057         PR corefiles/11608
6058         PR corefiles/18187
6059         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6060         OFFSET.  Verify if current mapping contains an ELF header.
6061         (linux_find_memory_regions_full): Adjust call to
6062         dump_mapping_p.
6063
6064 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6065             Kang Li <kanglictf@gmail.com>
6066
6067         PR gdb/21600
6068
6069         * dwarf2-frame.c (read_initial_length): Be consistent about using
6070         unsigned representation of length.
6071         (decode_frame_entry_1): Likewise.  Check for wraparound of
6072         end pointer as well as buffer overflow.
6073
6074 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6075
6076         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6077         "vq".
6078
6079 2019-04-24  Tom Tromey  <tromey@adacore.com>
6080
6081         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6082
6083 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6084
6085         * s12z-tdep.c (s12z_unwind_pc): Delete.
6086         (s12z_unwind_sp): Delete.
6087         (s12z_gdbarch_init): Don't register deleted functions with
6088         gdbarch.
6089
6090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * rl78-tdep.c (rl78_unwind_sp): Delete.
6093         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6094
6095 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6096
6097         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6098         (xstormy16_unwind_pc): Delete.
6099         (xstormy16_dummy_id): Delete.
6100         (xstormy16_gdbarch_init): Don't register deleted functions with
6101         gdbarch.
6102
6103 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6104
6105         * vax-tdep.c (vax_unwind_pc): Delete.
6106         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6107
6108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * v850-tdep.c (v850_unwind_sp): Delete.
6111         (v850_unwind_pc): Delete.
6112         (v850_dummy_id): Delete.
6113         (v850_gdbarch_init): Don't register deleted functions with
6114         gdbarch.
6115
6116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6117
6118         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6119         (tilegx_unwind_pc): Delete.
6120         (tilegx_unwind_dummy_id): Delete.
6121         (tilegx_gdbarch_init): Don't register deleted functions with
6122         gdbarch.
6123
6124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6125
6126         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6127         (tic6x_dummy_id): Delete.
6128         (tic6x_gdbarch_init): Don't register deleted functions with
6129         gdbarch.
6130
6131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6132
6133         * sparc-tdep.c (sparc_unwind_pc): Delete.
6134         (sparc32_gdbarch_init): Don't register deleted function with
6135         gdbarch.
6136
6137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6138
6139         * sh-tdep.c (sh_unwind_sp): Delete.
6140         (sh_unwind_pc): Delete.
6141         (sh_dummy_id): Delete.
6142         (sh_gdbarch_init): Don't register deleted functions with
6143         gdbarch.
6144
6145 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6146
6147         * score-tdep.c (score_unwind_sp): Delete.
6148         (score_unwind_pc): Delete.
6149         (score_dummy_id): Delete.
6150         (score_gdbarch_init): Don't register deleted functions with
6151         gdbarch.
6152
6153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6154
6155         * rx-tdep.c (rx_unwind_pc): Delete.
6156         (rx_unwind_sp): Delete.
6157         (rx_dummy_id): Delete.
6158         (rx_gdbarch_init): Don't register deleted functions with
6159         gdbarch.  Update comment.
6160
6161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6164         (rs6000_dummy_id): Delete.
6165         (rs6000_gdbarch_init): Don't register deleted functions with
6166         gdbarch.
6167
6168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6169
6170         * or1k-tdep.c (or1k_dummy_id): Delete.
6171         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6172
6173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6174
6175         * nios2-tdep.c (nios2_dummy_id): Delete.
6176         (nios2_unwind_sp): Delete.
6177         (nios2_gdbarch_init): Don't register deleted functions with
6178         gdbarch.
6179
6180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6181
6182         * nds32-tdep.c (nds32_dummy_id): Delete.
6183         (nds32_unwind_pc): Delete.
6184         (nds32_unwind_sp): Delete.
6185         (nds32_gdbarch_init): Don't register deleted functions with
6186         gdbarch.
6187
6188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6189
6190         * msp430-tdep.c (msp430_unwind_pc): Delete.
6191         (msp430_unwind_sp): Delete.
6192         (msp430_dummy_id): Delete.
6193         (msp430_gdbarch_init): Don't register deleted functions with
6194         gdbarch.
6195
6196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6197
6198         * moxie-tdep.c (moxie_unwind_sp): Delete.
6199         (moxie_unwind_pc): Delete.
6200         (moxie_dummy_id): Delete.
6201         (moxie_gdbarch_init): Don't register deleted functions with
6202         gdbarch.
6203
6204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6205
6206         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6207         (mn10300_unwind_pc): Delete.
6208         (mn10300_unwind_sp): Delete.
6209         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6210         mn10300_unwind_sp.
6211         (mn10300_frame_unwind_init): Don't register deleted functions with
6212         gdbarch.
6213
6214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6215
6216         * mep-tdep.c (mep_unwind_pc): Delete.
6217         (mep_unwind_sp): Delete.
6218         (mep_dummy_id): Delete.
6219         (mep_gdbarch_init): Don't register deleted functions with
6220         gdbarch.
6221
6222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6223
6224         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6225         (m68hc11_unwind_sp): Delete.
6226         (m68hc11_gdbarch_init): Don't register deleted functions with
6227         gdbarch.
6228
6229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6230
6231         * m32r-tdep.c (m32r_unwind_sp): Delete.
6232         (m32r_unwind_pc): Delete.
6233         (m32r_dummy_id): Delete.
6234         (m32r_gdbarch_init): Don't register deleted functions with
6235         gdbarch.
6236
6237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6238
6239         * m32c-tdep.c (m32c_unwind_pc): Delete.
6240         (m32c_unwind_sp): Delete.
6241         (m32c_dummy_id): Delete.
6242         (m32c_gdbarch_init): Don't register deleted functions with
6243         gdbarch.
6244
6245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6246
6247         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6248         (lm32_unwind_pc): Delete.
6249         (lm32_dummy_id): Delete.
6250         (lm32_gdbarch_init): Don't register deleted functions with
6251         gdbarch.
6252
6253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6254
6255         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6256         (iq2000_unwind_pc): Delete.
6257         (iq2000_dummy_id): Delete.
6258         (iq2000_gdbarch_init): Don't register deleted functions with
6259         gdbarch.
6260
6261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6262
6263         * nds32-tdep.c (nds32_type_align): Delete.
6264         (nds32_push_dummy_call): Use type_align instead.
6265
6266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6267
6268         * arm-tdep.c (arm_type_align): Only handle vector override case.
6269         (arm_push_dummy_call): Use type_align.
6270         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6271
6272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6273
6274         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6275         case.
6276         (pass_on_stack): Use type_align.
6277         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6278         function.
6279
6280 2019-04-23  Tom Tromey  <tromey@adacore.com>
6281
6282         * dwarf2read.c (line_header::file_name_at): Remove unused
6283         overload.
6284
6285 2019-04-23  Tom de Vries  <tdevries@suse.de>
6286
6287         PR gdb/24438
6288         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6289         invocation.
6290
6291
6292 2019-03-27  Ali Tamur  <tamur@google.com>
6293
6294         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6295         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6296         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6297         (dwarf_expr_context::get_addr_index): Likewise
6298         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6299         (symbol_needs_eval_context::get_addr_index): Likewise
6300         (disassemble_dwarf_expression): Add DW_OP_addrx
6301         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6302         (read_cutu_die_from_dwo): Update comment
6303         (skip_one_die): Add DW_FORM_addrx
6304         (read_attribute_value): Likewise
6305         (var_decode_location): Add DW_OP_addrx
6306         (dwarf2_const_value_attr): Add DW_FORM_addrx
6307         (dump_die_shallow): Likewise
6308         (dwarf2_fetch_constant_bytes): Likewise
6309         (decode_locdesc): Add DW_OP_addrx
6310         (skip_form_bytes): Add DW_FORM_addrx
6311
6312 2019-04-22  Ali Tamur  <tamur@google.com>
6313
6314         * MAINTAINERS (Write After Approval): Add self.
6315
6316 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6317
6318         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6319         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6320         (open_symbol_file_object): Likewise.
6321         (svr4_default_sos): Add info parameter.
6322         (svr4_read_so_list): Likewise.
6323         (svr4_current_sos_direct): Adjust functions calls to pass down
6324         info.
6325         (svr4_current_sos_1): Add info parameter.
6326         (svr4_current_sos): Call get_svr4_info, pass info down to
6327         svr4_current_sos_1.
6328         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6329         get_svr4_info.
6330         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6331         get_svr4_info.
6332         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6333         to get_svr4_info.
6334         (probes_table_remove_objfile_probes): Likewise.
6335         (register_solib_event_probe): Add info parameter.
6336         (solist_update_incremental): Pass info parameter down to
6337         svr4_read_so_list.
6338         (disable_probes_interface): Add info parameter.
6339         (svr4_handle_solib_event): Pass current_program_space to
6340         get_svr4_info.  Adjust disable_probes_interface cleanup.
6341         (svr4_create_probe_breakpoints): Add info parameter, pass it
6342         down to register_solib_event_probe.
6343         (svr4_create_solib_event_breakpoints): Add info parameter,
6344         pass it down to svr4_create_probe_breakpoints.
6345         (enable_break): Pass info down to
6346         svr4_create_solib_event_breakpoints.
6347         (svr4_solib_create_inferior_hook): Pass current_program_space to
6348         get_svr4_info.
6349         (svr4_clear_solib): Likewise.
6350
6351 2019-04-22  Pedro Alves  <palves@redhat.com>
6352
6353         * solib-svr4.c (svr4_free_objfile_observer): New.
6354         (probe_and_action::objfile): New field.
6355         (probes_table_htab_remove_objfile_probes)
6356         (probes_table_remove_objfile_probes): New functions.
6357         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6358         in the new probe_and_action.  Don't store the probe in 'lookup'.
6359         (svr4_create_probe_breakpoints): Pass objfile to
6360         register_solib_event_probe.
6361         (_initialize_svr4_solib): Register a free_objfile observer.
6362
6363 2019-04-19  Tom Tromey  <tom@tromey.com>
6364
6365         * common/queue.h: Remove.
6366
6367 2019-04-19  Tom Tromey  <tom@tromey.com>
6368
6369         * event-loop.c: Don't include "common/queue.h".
6370
6371 2019-04-19  Tom Tromey  <tom@tromey.com>
6372
6373         * remote.c (remote_target): Use delete.
6374         * remote-notif.h: Include <list>, not "common/queue.h".
6375         (notif_client_p): Remove typedef.
6376         (remote_notif_state): Add constructor, destructor, initializer.
6377         <notif_queue>: Now a std::list.
6378         (remote_notif_state_xfree): Don't declare.
6379         * remote-notif.c (remote_notif_process, handle_notification)
6380         (remote_notif_state_allocate): Update.
6381         (~remote_notif_state): Rename from remote_notif_state_xfree.
6382
6383 2019-04-19  Tom Tromey  <tom@tromey.com>
6384
6385         * symfile.c (reread_symbols): Update.
6386         * objfiles.c (objfile_register_static_link)
6387         (objfile_lookup_static_link): Update
6388         (~objfile) Don't delete static_links.
6389         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6390
6391 2019-04-19  Tom Tromey  <tom@tromey.com>
6392
6393         * type-stack.h (struct type_stack) <insert>: Constify string.
6394         * type-stack.c (type_stack::insert): Constify string.
6395         * gdbtypes.h (lookup_template_type): Update.
6396         (address_space_name_to_int): Update.
6397         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6398         const.
6399         (lookup_template_type): Make name const.
6400         * c-exp.y: Update rules.
6401         (lex_one_token, classify_name, classify_inner_name)
6402         (c_print_token): Update.
6403         * p-exp.y: Update rules.
6404         (yylex): Update.
6405         * f-exp.y: Update rules.
6406         (yylex): Update.
6407         * d-exp.y: Update rules.
6408         (lex_one_token, classify_name, classify_inner_name): Update.
6409         * parse.c (write_dollar_variable, copy_name): Return std::string.
6410         * parser-defs.h (copy_name): Change return type.
6411         * m2-exp.y: Update rules.
6412         (yylex): Update.
6413         * go-exp.y (lex_one_token): Update.
6414         Update rules.
6415         (classify_unsafe_function, classify_packaged_name)
6416         (classify_name, yylex): Update.
6417
6418 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6419
6420         * configure.ac: add --enable-source-highlight switch.
6421         * configure: Regenerate.
6422         * top.c (print_gdb_version): plumb --enable-source-highlight
6423         status to "show configuration".
6424
6425 2019-04-19  Tom Tromey  <tromey@adacore.com>
6426
6427         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6428         Check ADA_TYPE_P.
6429         (empty_record, ada_template_to_fixed_record_type_1)
6430         (template_to_static_fixed_type)
6431         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6432         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6433         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6434         macros.
6435
6436 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6437
6438         PR symtab/24423:
6439         * source.c (print_source_lines_base): Advance "iter" when a
6440         control character is seen.
6441
6442 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6443
6444         * inferior.h (struct infcall_suspend_state_deleter):
6445         Catch exception in destructor to avoid crash.
6446
6447 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6448
6449         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6450         close to the add_com "shell".
6451
6452 2019-04-18  Tom Tromey  <tromey@adacore.com>
6453
6454         * process-stratum-target.h (class process_stratum_target)
6455         <stratum>: Add "final".
6456
6457 2019-04-17  Tom Tromey  <tromey@adacore.com>
6458
6459         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6460         against nullptr before use.
6461
6462 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6463
6464         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6465
6466 2019-04-17  Jim Wilson  <jimw@sifive.com>
6467             Andrew Burgess  <andrew.burgess@embecosm.com>
6468
6469         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6470         code read might fail, assume 4-byte breakpoint in that case.
6471
6472 2019-04-15  Leszek Swirski  <leszeks@google.com>
6473
6474         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6475         rather than a hand-rolled POD check when checking for forced MEMORY
6476         classification.
6477
6478 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6479
6480         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6481         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6482         function.
6483         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6484         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6485         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6486         declaration.
6487
6488 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6489
6490         * aarch64-linux-nat.c
6491         (aarch64_linux_nat_target::thread_architecture): Add override.
6492         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6493         each VQ.
6494
6495 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6496
6497         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6498
6499 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6500
6501         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6502         target types of size 96-bits, add some additional comments, and
6503         check that the builtin type we found was the correct size.
6504
6505 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6506
6507         * utils.c (prompt_for_continue): Don't restore the styling at the
6508         end, as applied_style has the wrong value.  This fixes styling in
6509         long lists of file names that are interrupted by the "Continue?"
6510         prompt.
6511
6512 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6513
6514         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6515         * c-lang.c (c_language_defn): Likewise.
6516         (cplus_language_defn): Likewise.
6517         (asm_language_defn): Likewise.
6518         (minimal_language_defn): Likewise.
6519         * d-lang.c (d_language_defn): Likewise.
6520         * f-lang.c (f_language_defn): Likewise.
6521         * go-lang.c (go_language_defn): Likewise.
6522         * language.c (unknown_language_defn): Likewise.
6523         (auto_language_defn): Likewise.
6524         * language.h (struct language_defn): Remove la_magic field.
6525         (LANG_MAGIC): Delete.
6526         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6527         * objc-lang.c (objc_language_defn): Likewise.
6528         * opencl-lang.c (opencl_language_defn): Likewise.
6529         * p-lang.c (pascal_language_defn): Likewise.
6530         * rust-lang.c (rust_language_defn): Likewise.
6531
6532 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6533
6534         * riscv-tdep.c (riscv_type_align): New function.
6535         (riscv_type_alignment): Delete.
6536         (riscv_arg_location): Use 'type_align'.
6537         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6538
6539 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6540
6541         * gdbtypes.c (type_align): A struct with no non-static fields also
6542         has alignment of 1.
6543
6544 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6545
6546         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6547         component to 0.
6548         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6549         member.
6550         (riscv_struct_info::analyse): New implementation using new
6551         analyse_inner member function.
6552         (riscv_struct_info::field_offset): New member function.
6553         (riscv_struct_info::m_offsets): New member variable.
6554         (riscv_struct_info::analyse_inner): New private member function,
6555         takes the old implementation of riscv_struct_info::analyse but
6556         extended to track field offsets.
6557         (riscv_call_arg_struct): Update the struct folding special cases
6558         to handle cases where empty C++ structs, which are non-zero
6559         length, are found.
6560         (riscv_arg_location): Initialise the length of each location, a
6561         non-zero length now indicates the location is in use.
6562         (riscv_push_dummy_call): Allow for the first location having a
6563         non-zero offset when setting up arguments.
6564         (riscv_return_value): Likewise, but for return values.
6565
6566 2019-04-11  Tom Tromey  <tromey@adacore.com>
6567
6568         * utils.c (internal_vproblem): Make "msg" const.
6569
6570 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6571
6572         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6573         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6574         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6575         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6576
6577 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6578
6579         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6580         function.
6581         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6582         of amd64_collect_native_gregset.
6583         (amd64_linux_nat_target::store_registers): Likewise.
6584
6585 2019-04-10  Tom Tromey  <tom@tromey.com>
6586
6587         * symtab.c (lookup_global_symbol_from_objfile)
6588         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6589         * objfiles.h (class separate_debug_iterator): New.
6590         (class separate_debug_range): New.
6591         (struct objfile) <separate_debug_objfiles>: New method.
6592         (objfile_separate_debug_iterate): Don't declare.
6593         * objfiles.c (separate_debug_iterator::operator++): Rename from
6594         objfile_separate_debug_iterate.
6595         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6596         iterator.
6597         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6598         iterator.
6599
6600 2019-04-10  Tom Tromey  <tom@tromey.com>
6601
6602         * symfile.c (reread_symbols): Remove old comment.
6603         * objfiles.c (free_all_objfiles): Fix a typo.
6604
6605 2019-04-10  Tom Tromey  <tom@tromey.com>
6606
6607         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6608         * minsyms.c (lookup_minimal_symbol): Use foreach.
6609         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6610         (lookup_minimal_symbol_solib_trampoline): Likewise.
6611         * symfile.c (reread_symbols): Use foreach.
6612
6613 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6614             Tom Tromey  <tromey@adacore.com>
6615
6616         PR rust/24414:
6617         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6618         (rust_lex_int_test): Change "value" to be LONGEST.
6619         (rust_lex_tests): Add test for long integer literal.
6620
6621 2019-04-09  Tom Tromey  <tromey@adacore.com>
6622
6623         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6624         to bool.
6625         (extended_remote_target::attach): Update.
6626         (remote_target::remote_notice_new_inferior): Update.
6627         (remote_target::add_current_inferior_and_thread): Update.
6628         * inferior.c (exit_inferior_1): Use "false".
6629         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6630
6631 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6632
6633         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6634         the "start" command.
6635
6636 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6637
6638         * python/py-inferior.c (infpy_thread_from_thread_handle):
6639         Adjust comments to reflect renaming of thread_from_thread_handle
6640         to thread_from_handle.  Adjust keywords.  Fix type error message.
6641         (inferior_object_methods): Add thread_from_handle.  Retain
6642         thread_from_thread_handle, but mark it as deprecated.
6643
6644 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6645
6646         * gdbthread.h (find_thread_by_handle): Revise declaration.
6647         * thread.c (find_thread_by_handle): Likewise.  Adjust
6648         implementation too.
6649         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6650         support for buffer objects as handles.
6651
6652 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6653
6654         * python/py-infthread.c (thpy_thread_handle): New function.
6655         (thread_object_methods): Register thpy_thread_handle.
6656
6657 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6658
6659         * gdbthread.h (thread_to_thread_handle): Declare.
6660         * thread.c (gdbtypes.h): Include.
6661         (thread_to_thread_handle): New function.
6662
6663         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6664         (target_thread_info_to_thread_handle): Declare.
6665         * target.c (target_thread_info_to_thread_handle): New function.
6666         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6667         * target-delegates.c: Regenerate.
6668
6669         * linux-thread-db.c (class thread_db_target): Add method
6670         thread_info_to_thread_handle.
6671         (thread_db_target::thread_info_to_thread_handle): Define.
6672         * remote.c (class remote_target): Add new method
6673         thread_info_to_thread_handle.
6674         (remote_target::thread_info_to_thread_handle): Define.
6675
6676 2019-04-08  Pedro Alves  <palves@redhat.com>
6677
6678         * common/common-exceptions.c (throw_exception): Don't create
6679         named object to throw; throw directly.
6680         (throw_it): Likewise.  Don't initialize gdb_exception::message
6681         here, with new; pass FMT and AP to the ctor instead.
6682         * common/common-exceptions.h: Include <string>.
6683         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6684         const char *, va_list)): New ctor.  Use std::make_shared.
6685         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6686         errors)): Delete.
6687         (gdb_exception_error::gdb_exception_error(enum errors, const char
6688         *, va_list)): New.
6689         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6690         Add assertion.
6691         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6692         errors)): Delete.
6693         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6694         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6695         Add assertion.
6696
6697 2019-04-08  Tom Tromey  <tom@tromey.com>
6698
6699         * valops.c (value_rtti_indirect_type): Replace throw_exception
6700         with throw.
6701         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6702         with throw.
6703         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6704         throw.
6705         * target.c (target_translate_tls_address): Replace throw_exception
6706         with throw.
6707         * stack.c (frame_apply_command_count): Replace throw_exception
6708         with throw.
6709         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6710         throw.
6711         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6712         with throw.
6713         * rs6000-tdep.c (rs6000_frame_cache)
6714         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6715         * remote.c: Replace throw_exception with throw.
6716         * record-full.c (record_full_message, record_full_wait_1)
6717         (record_full_restore): Replace throw_exception with throw.
6718         * record-btrace.c:
6719         (get_thread_current_frame_id, record_btrace_start_replaying)
6720         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6721         (cmd_record_btrace_start): Replace throw_exception with throw.
6722         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6723         throw.
6724         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6725         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6726         * linespec.c:
6727         (find_linespec_symbols): Replace throw_exception with throw.
6728         * infrun.c (displaced_step_prepare, resume): Replace
6729         throw_exception with throw.
6730         * infcmd.c (post_create_inferior): Replace throw_exception with
6731         throw.
6732         * inf-loop.c (inferior_event_handler): Replace throw_exception
6733         with throw.
6734         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6735         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6736         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6737         (get_prev_frame_always, get_frame_pc_if_available)
6738         (get_frame_address_in_block_if_available, get_frame_language):
6739         Replace throw_exception with throw.
6740         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6741         throw_exception with throw.
6742         * eval.c (fetch_subexp_value, evaluate_var_value)
6743         (evaluate_funcall, evaluate_subexp_standard): Replace
6744         throw_exception with throw.
6745         * dwarf2loc.c (call_site_find_chain)
6746         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6747         Replace throw_exception with throw.
6748         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6749         with throw.
6750         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6751         throw.
6752         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6753         * completer.c (complete_line_internal): Replace throw_exception
6754         with throw.
6755         * compile/compile-object-run.c (compile_object_run): Replace
6756         throw_exception with throw.
6757         * cli/cli-script.c (process_next_line): Replace throw_exception
6758         with throw.
6759         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6760         (btrace_enable, btrace_maint_update_pt_packets): Replace
6761         throw_exception with throw.
6762         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6763         throw_exception with throw.
6764         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6765         throw_exception with throw.
6766         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6767         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6768         * aarch64-tdep.c (aarch64_make_prologue_cache)
6769         (aarch64_make_stub_cache): Replace throw_exception with throw.
6770
6771 2019-04-08  Tom Tromey  <tom@tromey.com>
6772
6773         * common/common-exceptions.c (throw_exception): Rename from
6774         throw_exception_cxx.  Remove old copy.  Make argument const.
6775         (throw_it): Create and throw exception objects directly.
6776         * common/common-exceptions.h (throw_exception): Make argument
6777         const.
6778         (struct gdb_exception_error): Add constructor.
6779         (struct gdb_exception_quit): Add constructor.
6780
6781 2019-04-08  Tom Tromey  <tom@tromey.com>
6782
6783         * common/common-exceptions.h (exception_rethrow): Don't declare.
6784         (TRY_SJLJ): Update comment.
6785         (TRY, CATCH, END_CATCH): Remove.
6786         * common/common-exceptions.c (exception_rethrow): Remove.
6787
6788 2019-04-08  Tom Tromey  <tom@tromey.com>
6789
6790         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6791         Remove.
6792         (gdb_exception_error): Rename from
6793         gdb_exception_RETURN_MASK_ERROR.
6794         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6795         (gdb_quit_bad_alloc): Update.
6796         * aarch64-tdep.c: Update.
6797         * ada-lang.c: Update.
6798         * ada-typeprint.c: Update.
6799         * ada-valprint.c: Update.
6800         * amd64-tdep.c: Update.
6801         * arch-utils.c: Update.
6802         * break-catch-throw.c: Update.
6803         * breakpoint.c: Update.
6804         * btrace.c: Update.
6805         * c-varobj.c: Update.
6806         * cli/cli-cmds.c: Update.
6807         * cli/cli-interp.c: Update.
6808         * cli/cli-script.c: Update.
6809         * common/common-exceptions.c: Update.
6810         * common/new-op.c: Update.
6811         * common/selftest.c: Update.
6812         * compile/compile-c-symbols.c: Update.
6813         * compile/compile-cplus-symbols.c: Update.
6814         * compile/compile-object-load.c: Update.
6815         * compile/compile-object-run.c: Update.
6816         * completer.c: Update.
6817         * corelow.c: Update.
6818         * cp-abi.c: Update.
6819         * cp-support.c: Update.
6820         * cp-valprint.c: Update.
6821         * darwin-nat.c: Update.
6822         * disasm-selftests.c: Update.
6823         * dtrace-probe.c: Update.
6824         * dwarf-index-cache.c: Update.
6825         * dwarf-index-write.c: Update.
6826         * dwarf2-frame-tailcall.c: Update.
6827         * dwarf2-frame.c: Update.
6828         * dwarf2loc.c: Update.
6829         * dwarf2read.c: Update.
6830         * eval.c: Update.
6831         * event-loop.c: Update.
6832         * event-top.c: Update.
6833         * exec.c: Update.
6834         * f-valprint.c: Update.
6835         * fbsd-tdep.c: Update.
6836         * frame-unwind.c: Update.
6837         * frame.c: Update.
6838         * gdbtypes.c: Update.
6839         * gnu-v3-abi.c: Update.
6840         * guile/guile-internal.h: Update.
6841         * guile/scm-block.c: Update.
6842         * guile/scm-breakpoint.c: Update.
6843         * guile/scm-cmd.c: Update.
6844         * guile/scm-disasm.c: Update.
6845         * guile/scm-frame.c: Update.
6846         * guile/scm-lazy-string.c: Update.
6847         * guile/scm-math.c: Update.
6848         * guile/scm-param.c: Update.
6849         * guile/scm-ports.c: Update.
6850         * guile/scm-pretty-print.c: Update.
6851         * guile/scm-symbol.c: Update.
6852         * guile/scm-symtab.c: Update.
6853         * guile/scm-type.c: Update.
6854         * guile/scm-value.c: Update.
6855         * i386-linux-tdep.c: Update.
6856         * i386-tdep.c: Update.
6857         * inf-loop.c: Update.
6858         * infcall.c: Update.
6859         * infcmd.c: Update.
6860         * infrun.c: Update.
6861         * jit.c: Update.
6862         * language.c: Update.
6863         * linespec.c: Update.
6864         * linux-fork.c: Update.
6865         * linux-nat.c: Update.
6866         * linux-tdep.c: Update.
6867         * linux-thread-db.c: Update.
6868         * main.c: Update.
6869         * mi/mi-cmd-break.c: Update.
6870         * mi/mi-cmd-stack.c: Update.
6871         * mi/mi-interp.c: Update.
6872         * mi/mi-main.c: Update.
6873         * objc-lang.c: Update.
6874         * p-valprint.c: Update.
6875         * parse.c: Update.
6876         * ppc-linux-tdep.c: Update.
6877         * printcmd.c: Update.
6878         * python/py-arch.c: Update.
6879         * python/py-breakpoint.c: Update.
6880         * python/py-cmd.c: Update.
6881         * python/py-finishbreakpoint.c: Update.
6882         * python/py-frame.c: Update.
6883         * python/py-framefilter.c: Update.
6884         * python/py-gdb-readline.c: Update.
6885         * python/py-inferior.c: Update.
6886         * python/py-infthread.c: Update.
6887         * python/py-lazy-string.c: Update.
6888         * python/py-linetable.c: Update.
6889         * python/py-objfile.c: Update.
6890         * python/py-param.c: Update.
6891         * python/py-prettyprint.c: Update.
6892         * python/py-progspace.c: Update.
6893         * python/py-record-btrace.c: Update.
6894         * python/py-record.c: Update.
6895         * python/py-symbol.c: Update.
6896         * python/py-type.c: Update.
6897         * python/py-unwind.c: Update.
6898         * python/py-utils.c: Update.
6899         * python/py-value.c: Update.
6900         * python/python.c: Update.
6901         * record-btrace.c: Update.
6902         * record-full.c: Update.
6903         * remote-fileio.c: Update.
6904         * remote.c: Update.
6905         * riscv-tdep.c: Update.
6906         * rs6000-aix-tdep.c: Update.
6907         * rs6000-tdep.c: Update.
6908         * rust-exp.y: Update.
6909         * rust-lang.c: Update.
6910         * s390-tdep.c: Update.
6911         * selftest-arch.c: Update.
6912         * solib-dsbt.c: Update.
6913         * solib-frv.c: Update.
6914         * solib-spu.c: Update.
6915         * solib-svr4.c: Update.
6916         * solib.c: Update.
6917         * sparc64-linux-tdep.c: Update.
6918         * stack.c: Update.
6919         * symfile-mem.c: Update.
6920         * symmisc.c: Update.
6921         * target.c: Update.
6922         * thread.c: Update.
6923         * top.c: Update.
6924         * tracefile-tfile.c: Update.
6925         * tui/tui.c: Update.
6926         * typeprint.c: Update.
6927         * unittests/cli-utils-selftests.c: Update.
6928         * unittests/parse-connection-spec-selftests.c: Update.
6929         * valops.c: Update.
6930         * valprint.c: Update.
6931         * value.c: Update.
6932         * varobj.c: Update.
6933         * windows-nat.c: Update.
6934         * x86-linux-nat.c: Update.
6935         * xml-support.c: Update.
6936
6937 2019-04-08  Tom Tromey  <tom@tromey.com>
6938
6939         * xml-support.c: Use C++ exception handling.
6940         * x86-linux-nat.c: Use C++ exception handling.
6941         * windows-nat.c: Use C++ exception handling.
6942         * varobj.c: Use C++ exception handling.
6943         * value.c: Use C++ exception handling.
6944         * valprint.c: Use C++ exception handling.
6945         * valops.c: Use C++ exception handling.
6946         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6947         handling.
6948         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6949         * typeprint.c: Use C++ exception handling.
6950         * tui/tui.c: Use C++ exception handling.
6951         * tracefile-tfile.c: Use C++ exception handling.
6952         * top.c: Use C++ exception handling.
6953         * thread.c: Use C++ exception handling.
6954         * target.c: Use C++ exception handling.
6955         * symmisc.c: Use C++ exception handling.
6956         * symfile-mem.c: Use C++ exception handling.
6957         * stack.c: Use C++ exception handling.
6958         * sparc64-linux-tdep.c: Use C++ exception handling.
6959         * solib.c: Use C++ exception handling.
6960         * solib-svr4.c: Use C++ exception handling.
6961         * solib-spu.c: Use C++ exception handling.
6962         * solib-frv.c: Use C++ exception handling.
6963         * solib-dsbt.c: Use C++ exception handling.
6964         * selftest-arch.c: Use C++ exception handling.
6965         * s390-tdep.c: Use C++ exception handling.
6966         * rust-lang.c: Use C++ exception handling.
6967         * rust-exp.y: Use C++ exception handling.
6968         * rs6000-tdep.c: Use C++ exception handling.
6969         * rs6000-aix-tdep.c: Use C++ exception handling.
6970         * riscv-tdep.c: Use C++ exception handling.
6971         * remote.c: Use C++ exception handling.
6972         * remote-fileio.c: Use C++ exception handling.
6973         * record-full.c: Use C++ exception handling.
6974         * record-btrace.c: Use C++ exception handling.
6975         * python/python.c: Use C++ exception handling.
6976         * python/py-value.c: Use C++ exception handling.
6977         * python/py-utils.c: Use C++ exception handling.
6978         * python/py-unwind.c: Use C++ exception handling.
6979         * python/py-type.c: Use C++ exception handling.
6980         * python/py-symbol.c: Use C++ exception handling.
6981         * python/py-record.c: Use C++ exception handling.
6982         * python/py-record-btrace.c: Use C++ exception handling.
6983         * python/py-progspace.c: Use C++ exception handling.
6984         * python/py-prettyprint.c: Use C++ exception handling.
6985         * python/py-param.c: Use C++ exception handling.
6986         * python/py-objfile.c: Use C++ exception handling.
6987         * python/py-linetable.c: Use C++ exception handling.
6988         * python/py-lazy-string.c: Use C++ exception handling.
6989         * python/py-infthread.c: Use C++ exception handling.
6990         * python/py-inferior.c: Use C++ exception handling.
6991         * python/py-gdb-readline.c: Use C++ exception handling.
6992         * python/py-framefilter.c: Use C++ exception handling.
6993         * python/py-frame.c: Use C++ exception handling.
6994         * python/py-finishbreakpoint.c: Use C++ exception handling.
6995         * python/py-cmd.c: Use C++ exception handling.
6996         * python/py-breakpoint.c: Use C++ exception handling.
6997         * python/py-arch.c: Use C++ exception handling.
6998         * printcmd.c: Use C++ exception handling.
6999         * ppc-linux-tdep.c: Use C++ exception handling.
7000         * parse.c: Use C++ exception handling.
7001         * p-valprint.c: Use C++ exception handling.
7002         * objc-lang.c: Use C++ exception handling.
7003         * mi/mi-main.c: Use C++ exception handling.
7004         * mi/mi-interp.c: Use C++ exception handling.
7005         * mi/mi-cmd-stack.c: Use C++ exception handling.
7006         * mi/mi-cmd-break.c: Use C++ exception handling.
7007         * main.c: Use C++ exception handling.
7008         * linux-thread-db.c: Use C++ exception handling.
7009         * linux-tdep.c: Use C++ exception handling.
7010         * linux-nat.c: Use C++ exception handling.
7011         * linux-fork.c: Use C++ exception handling.
7012         * linespec.c: Use C++ exception handling.
7013         * language.c: Use C++ exception handling.
7014         * jit.c: Use C++ exception handling.
7015         * infrun.c: Use C++ exception handling.
7016         * infcmd.c: Use C++ exception handling.
7017         * infcall.c: Use C++ exception handling.
7018         * inf-loop.c: Use C++ exception handling.
7019         * i386-tdep.c: Use C++ exception handling.
7020         * i386-linux-tdep.c: Use C++ exception handling.
7021         * guile/scm-value.c: Use C++ exception handling.
7022         * guile/scm-type.c: Use C++ exception handling.
7023         * guile/scm-symtab.c: Use C++ exception handling.
7024         * guile/scm-symbol.c: Use C++ exception handling.
7025         * guile/scm-pretty-print.c: Use C++ exception handling.
7026         * guile/scm-ports.c: Use C++ exception handling.
7027         * guile/scm-param.c: Use C++ exception handling.
7028         * guile/scm-math.c: Use C++ exception handling.
7029         * guile/scm-lazy-string.c: Use C++ exception handling.
7030         * guile/scm-frame.c: Use C++ exception handling.
7031         * guile/scm-disasm.c: Use C++ exception handling.
7032         * guile/scm-cmd.c: Use C++ exception handling.
7033         * guile/scm-breakpoint.c: Use C++ exception handling.
7034         * guile/scm-block.c: Use C++ exception handling.
7035         * guile/guile-internal.h: Use C++ exception handling.
7036         * gnu-v3-abi.c: Use C++ exception handling.
7037         * gdbtypes.c: Use C++ exception handling.
7038         * frame.c: Use C++ exception handling.
7039         * frame-unwind.c: Use C++ exception handling.
7040         * fbsd-tdep.c: Use C++ exception handling.
7041         * f-valprint.c: Use C++ exception handling.
7042         * exec.c: Use C++ exception handling.
7043         * event-top.c: Use C++ exception handling.
7044         * event-loop.c: Use C++ exception handling.
7045         * eval.c: Use C++ exception handling.
7046         * dwarf2read.c: Use C++ exception handling.
7047         * dwarf2loc.c: Use C++ exception handling.
7048         * dwarf2-frame.c: Use C++ exception handling.
7049         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7050         * dwarf-index-write.c: Use C++ exception handling.
7051         * dwarf-index-cache.c: Use C++ exception handling.
7052         * dtrace-probe.c: Use C++ exception handling.
7053         * disasm-selftests.c: Use C++ exception handling.
7054         * darwin-nat.c: Use C++ exception handling.
7055         * cp-valprint.c: Use C++ exception handling.
7056         * cp-support.c: Use C++ exception handling.
7057         * cp-abi.c: Use C++ exception handling.
7058         * corelow.c: Use C++ exception handling.
7059         * completer.c: Use C++ exception handling.
7060         * compile/compile-object-run.c: Use C++ exception handling.
7061         * compile/compile-object-load.c: Use C++ exception handling.
7062         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7063         * compile/compile-c-symbols.c: Use C++ exception handling.
7064         * common/selftest.c: Use C++ exception handling.
7065         * common/new-op.c: Use C++ exception handling.
7066         * cli/cli-script.c: Use C++ exception handling.
7067         * cli/cli-interp.c: Use C++ exception handling.
7068         * cli/cli-cmds.c: Use C++ exception handling.
7069         * c-varobj.c: Use C++ exception handling.
7070         * btrace.c: Use C++ exception handling.
7071         * breakpoint.c: Use C++ exception handling.
7072         * break-catch-throw.c: Use C++ exception handling.
7073         * arch-utils.c: Use C++ exception handling.
7074         * amd64-tdep.c: Use C++ exception handling.
7075         * ada-valprint.c: Use C++ exception handling.
7076         * ada-typeprint.c: Use C++ exception handling.
7077         * ada-lang.c: Use C++ exception handling.
7078         * aarch64-tdep.c: Use C++ exception handling.
7079
7080 2019-04-08  Tom Tromey  <tom@tromey.com>
7081
7082         * xml-support.c (gdb_xml_parser::parse): Update.
7083         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7084         * value.c (show_convenience): Update.
7085         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7086         (test_parse_flags_qcs): Update.
7087         * thread.c (thr_try_catch_cmd): Update.
7088         * target.c (target_translate_tls_address): Update.
7089         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7090         (info_frame_command_core, frame_apply_command_count): Update.
7091         * rust-exp.y (rust_lex_exception_test): Update.
7092         * riscv-tdep.c (riscv_print_one_register_info): Update.
7093         * remote.c (remote_target::enable_btrace): Update.
7094         * record-btrace.c (record_btrace_enable_warn): Update.
7095         * python/py-utils.c (gdbpy_convert_exception): Update.
7096         * printcmd.c (do_one_display, print_variable_and_value): Update.
7097         * mi/mi-main.c (mi_print_exception): Update.
7098         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7099         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7100         * linux-nat.c (linux_nat_target::attach): Update.
7101         * linux-fork.c (class scoped_switch_fork_info): Update.
7102         * infrun.c (displaced_step_prepare): Update.
7103         * infcall.c (call_function_by_hand_dummy): Update.
7104         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7105         * gnu-v3-abi.c (print_one_vtable): Update.
7106         * frame.c (get_prev_frame_always): Update.
7107         * f-valprint.c (info_common_command_for_block): Update.
7108         * exec.c (try_open_exec_file): Update.
7109         * exceptions.c (print_exception, exception_print)
7110         (exception_fprintf, exception_print_same): Update.
7111         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7112         * dwarf-index-cache.c (index_cache::store)
7113         (index_cache::lookup_gdb_index): Update.
7114         * darwin-nat.c (maybe_cache_shell): Update.
7115         * cp-valprint.c (cp_print_value_fields): Update.
7116         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7117         (gcc_cplus_symbol_address): Update.
7118         * compile/compile-c-symbols.c (gcc_convert_symbol)
7119         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7120         * common/selftest.c: Update.
7121         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7122         a std::string.
7123         (exception_try_scope_entry, exception_try_scope_exit): Don't
7124         declare.
7125         (struct exception_try_scope): Remove.
7126         (TRY): Don't use exception_try_scope.
7127         (struct gdb_exception): Add constructor, operator=.
7128         <what>: New method.
7129         (struct gdb_exception_RETURN_MASK_ALL)
7130         (struct gdb_exception_RETURN_MASK_ERROR)
7131         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7132         (struct gdb_quit_bad_alloc): Update.
7133         * common/common-exceptions.c (exception_none): Change
7134         initializer.
7135         (struct catcher) <state, exception>: Initialize inline.
7136         <prev>: Remove member.
7137         (current_catcher): Remove.
7138         (catchers): New global.
7139         (exceptions_state_mc_init): Simplify.
7140         (catcher_pop): Remove.
7141         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7142         (try_scope_depth, exception_try_scope_entry)
7143         (exception_try_scope_exit): Remove.
7144         (throw_exception_sjlj): Update.
7145         (exception_messages, exception_messages_size): Remove.
7146         (throw_it): Simplify.
7147         (gdb_exception_sliced_copy): Remove.
7148         (throw_exception_cxx): Update.
7149         * cli/cli-script.c (script_from_file): Update.
7150         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7151         Update.
7152         * ada-valprint.c (ada_val_print): Update.
7153         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7154         (create_excep_cond_exprs): Update.
7155
7156 2019-04-08  Tom Tromey  <tom@tromey.com>
7157
7158         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7159         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7160         (TRY, CATCH, END_CATCH): Remove some definitions.
7161         * common/common-exceptions.c: Don't use GDB_XCPT.
7162         (catcher_list_size): Remove.
7163         (throw_exception, throw_it): Simplify.
7164
7165 2019-04-05  Tom Tromey  <tom@tromey.com>
7166
7167         Revert the header-sorting patch.
7168         * ft32-tdep.c: Revert.
7169         * frv-tdep.c: Revert.
7170         * frv-linux-tdep.c: Revert.
7171         * frame.c: Revert.
7172         * frame-unwind.c: Revert.
7173         * frame-base.c: Revert.
7174         * fork-child.c: Revert.
7175         * findvar.c: Revert.
7176         * findcmd.c: Revert.
7177         * filesystem.c: Revert.
7178         * filename-seen-cache.h: Revert.
7179         * filename-seen-cache.c: Revert.
7180         * fbsd-tdep.c: Revert.
7181         * fbsd-nat.h: Revert.
7182         * fbsd-nat.c: Revert.
7183         * f-valprint.c: Revert.
7184         * f-typeprint.c: Revert.
7185         * f-lang.c: Revert.
7186         * extension.h: Revert.
7187         * extension.c: Revert.
7188         * extension-priv.h: Revert.
7189         * expprint.c: Revert.
7190         * exec.h: Revert.
7191         * exec.c: Revert.
7192         * exceptions.c: Revert.
7193         * event-top.c: Revert.
7194         * event-loop.c: Revert.
7195         * eval.c: Revert.
7196         * elfread.c: Revert.
7197         * dwarf2read.h: Revert.
7198         * dwarf2read.c: Revert.
7199         * dwarf2loc.c: Revert.
7200         * dwarf2expr.h: Revert.
7201         * dwarf2expr.c: Revert.
7202         * dwarf2-frame.c: Revert.
7203         * dwarf2-frame-tailcall.c: Revert.
7204         * dwarf-index-write.h: Revert.
7205         * dwarf-index-write.c: Revert.
7206         * dwarf-index-common.c: Revert.
7207         * dwarf-index-cache.h: Revert.
7208         * dwarf-index-cache.c: Revert.
7209         * dummy-frame.c: Revert.
7210         * dtrace-probe.c: Revert.
7211         * disasm.h: Revert.
7212         * disasm.c: Revert.
7213         * disasm-selftests.c: Revert.
7214         * dictionary.c: Revert.
7215         * dicos-tdep.c: Revert.
7216         * demangle.c: Revert.
7217         * dcache.h: Revert.
7218         * dcache.c: Revert.
7219         * darwin-nat.h: Revert.
7220         * darwin-nat.c: Revert.
7221         * darwin-nat-info.c: Revert.
7222         * d-valprint.c: Revert.
7223         * d-namespace.c: Revert.
7224         * d-lang.c: Revert.
7225         * ctf.c: Revert.
7226         * csky-tdep.c: Revert.
7227         * csky-linux-tdep.c: Revert.
7228         * cris-tdep.c: Revert.
7229         * cris-linux-tdep.c: Revert.
7230         * cp-valprint.c: Revert.
7231         * cp-support.c: Revert.
7232         * cp-namespace.c: Revert.
7233         * cp-abi.c: Revert.
7234         * corelow.c: Revert.
7235         * corefile.c: Revert.
7236         * continuations.c: Revert.
7237         * completer.h: Revert.
7238         * completer.c: Revert.
7239         * complaints.c: Revert.
7240         * coffread.c: Revert.
7241         * coff-pe-read.c: Revert.
7242         * cli-out.h: Revert.
7243         * cli-out.c: Revert.
7244         * charset.c: Revert.
7245         * c-varobj.c: Revert.
7246         * c-valprint.c: Revert.
7247         * c-typeprint.c: Revert.
7248         * c-lang.c: Revert.
7249         * buildsym.c: Revert.
7250         * buildsym-legacy.c: Revert.
7251         * build-id.h: Revert.
7252         * build-id.c: Revert.
7253         * btrace.c: Revert.
7254         * bsd-uthread.c: Revert.
7255         * breakpoint.h: Revert.
7256         * breakpoint.c: Revert.
7257         * break-catch-throw.c: Revert.
7258         * break-catch-syscall.c: Revert.
7259         * break-catch-sig.c: Revert.
7260         * blockframe.c: Revert.
7261         * block.c: Revert.
7262         * bfin-tdep.c: Revert.
7263         * bfin-linux-tdep.c: Revert.
7264         * bfd-target.c: Revert.
7265         * bcache.c: Revert.
7266         * ax-general.c: Revert.
7267         * ax-gdb.h: Revert.
7268         * ax-gdb.c: Revert.
7269         * avr-tdep.c: Revert.
7270         * auxv.c: Revert.
7271         * auto-load.c: Revert.
7272         * arm-wince-tdep.c: Revert.
7273         * arm-tdep.c: Revert.
7274         * arm-symbian-tdep.c: Revert.
7275         * arm-pikeos-tdep.c: Revert.
7276         * arm-obsd-tdep.c: Revert.
7277         * arm-nbsd-tdep.c: Revert.
7278         * arm-nbsd-nat.c: Revert.
7279         * arm-linux-tdep.c: Revert.
7280         * arm-linux-nat.c: Revert.
7281         * arm-fbsd-tdep.c: Revert.
7282         * arm-fbsd-nat.c: Revert.
7283         * arm-bsd-tdep.c: Revert.
7284         * arch-utils.c: Revert.
7285         * arc-tdep.c: Revert.
7286         * arc-newlib-tdep.c: Revert.
7287         * annotate.h: Revert.
7288         * annotate.c: Revert.
7289         * amd64-windows-tdep.c: Revert.
7290         * amd64-windows-nat.c: Revert.
7291         * amd64-tdep.c: Revert.
7292         * amd64-sol2-tdep.c: Revert.
7293         * amd64-obsd-tdep.c: Revert.
7294         * amd64-obsd-nat.c: Revert.
7295         * amd64-nbsd-tdep.c: Revert.
7296         * amd64-nbsd-nat.c: Revert.
7297         * amd64-nat.c: Revert.
7298         * amd64-linux-tdep.c: Revert.
7299         * amd64-linux-nat.c: Revert.
7300         * amd64-fbsd-tdep.c: Revert.
7301         * amd64-fbsd-nat.c: Revert.
7302         * amd64-dicos-tdep.c: Revert.
7303         * amd64-darwin-tdep.c: Revert.
7304         * amd64-bsd-nat.c: Revert.
7305         * alpha-tdep.c: Revert.
7306         * alpha-obsd-tdep.c: Revert.
7307         * alpha-nbsd-tdep.c: Revert.
7308         * alpha-mdebug-tdep.c: Revert.
7309         * alpha-linux-tdep.c: Revert.
7310         * alpha-linux-nat.c: Revert.
7311         * alpha-bsd-tdep.c: Revert.
7312         * alpha-bsd-nat.c: Revert.
7313         * aix-thread.c: Revert.
7314         * agent.c: Revert.
7315         * addrmap.c: Revert.
7316         * ada-varobj.c: Revert.
7317         * ada-valprint.c: Revert.
7318         * ada-typeprint.c: Revert.
7319         * ada-tasks.c: Revert.
7320         * ada-lang.c: Revert.
7321         * aarch64-tdep.c: Revert.
7322         * aarch64-ravenscar-thread.c: Revert.
7323         * aarch64-newlib-tdep.c: Revert.
7324         * aarch64-linux-tdep.c: Revert.
7325         * aarch64-linux-nat.c: Revert.
7326         * aarch64-fbsd-tdep.c: Revert.
7327         * aarch64-fbsd-nat.c: Revert.
7328         * aarch32-linux-nat.c: Revert.
7329
7330 2019-04-05  Tom Tromey  <tom@tromey.com>
7331
7332         * ft32-tdep.c: Sort headers.
7333         * frv-tdep.c: Sort headers.
7334         * frv-linux-tdep.c: Sort headers.
7335         * frame.c: Sort headers.
7336         * frame-unwind.c: Sort headers.
7337         * frame-base.c: Sort headers.
7338         * fork-child.c: Sort headers.
7339         * findvar.c: Sort headers.
7340         * findcmd.c: Sort headers.
7341         * filesystem.c: Sort headers.
7342         * filename-seen-cache.h: Sort headers.
7343         * filename-seen-cache.c: Sort headers.
7344         * fbsd-tdep.c: Sort headers.
7345         * fbsd-nat.h: Sort headers.
7346         * fbsd-nat.c: Sort headers.
7347         * f-valprint.c: Sort headers.
7348         * f-typeprint.c: Sort headers.
7349         * f-lang.c: Sort headers.
7350         * extension.h: Sort headers.
7351         * extension.c: Sort headers.
7352         * extension-priv.h: Sort headers.
7353         * expprint.c: Sort headers.
7354         * exec.h: Sort headers.
7355         * exec.c: Sort headers.
7356         * exceptions.c: Sort headers.
7357         * event-top.c: Sort headers.
7358         * event-loop.c: Sort headers.
7359         * eval.c: Sort headers.
7360         * elfread.c: Sort headers.
7361         * dwarf2read.h: Sort headers.
7362         * dwarf2read.c: Sort headers.
7363         * dwarf2loc.c: Sort headers.
7364         * dwarf2expr.h: Sort headers.
7365         * dwarf2expr.c: Sort headers.
7366         * dwarf2-frame.c: Sort headers.
7367         * dwarf2-frame-tailcall.c: Sort headers.
7368         * dwarf-index-write.h: Sort headers.
7369         * dwarf-index-write.c: Sort headers.
7370         * dwarf-index-common.c: Sort headers.
7371         * dwarf-index-cache.h: Sort headers.
7372         * dwarf-index-cache.c: Sort headers.
7373         * dummy-frame.c: Sort headers.
7374         * dtrace-probe.c: Sort headers.
7375         * disasm.h: Sort headers.
7376         * disasm.c: Sort headers.
7377         * disasm-selftests.c: Sort headers.
7378         * dictionary.c: Sort headers.
7379         * dicos-tdep.c: Sort headers.
7380         * demangle.c: Sort headers.
7381         * dcache.h: Sort headers.
7382         * dcache.c: Sort headers.
7383         * darwin-nat.h: Sort headers.
7384         * darwin-nat.c: Sort headers.
7385         * darwin-nat-info.c: Sort headers.
7386         * d-valprint.c: Sort headers.
7387         * d-namespace.c: Sort headers.
7388         * d-lang.c: Sort headers.
7389         * ctf.c: Sort headers.
7390         * csky-tdep.c: Sort headers.
7391         * csky-linux-tdep.c: Sort headers.
7392         * cris-tdep.c: Sort headers.
7393         * cris-linux-tdep.c: Sort headers.
7394         * cp-valprint.c: Sort headers.
7395         * cp-support.c: Sort headers.
7396         * cp-namespace.c: Sort headers.
7397         * cp-abi.c: Sort headers.
7398         * corelow.c: Sort headers.
7399         * corefile.c: Sort headers.
7400         * continuations.c: Sort headers.
7401         * completer.h: Sort headers.
7402         * completer.c: Sort headers.
7403         * complaints.c: Sort headers.
7404         * coffread.c: Sort headers.
7405         * coff-pe-read.c: Sort headers.
7406         * cli-out.h: Sort headers.
7407         * cli-out.c: Sort headers.
7408         * charset.c: Sort headers.
7409         * c-varobj.c: Sort headers.
7410         * c-valprint.c: Sort headers.
7411         * c-typeprint.c: Sort headers.
7412         * c-lang.c: Sort headers.
7413         * buildsym.c: Sort headers.
7414         * buildsym-legacy.c: Sort headers.
7415         * build-id.h: Sort headers.
7416         * build-id.c: Sort headers.
7417         * btrace.c: Sort headers.
7418         * bsd-uthread.c: Sort headers.
7419         * breakpoint.h: Sort headers.
7420         * breakpoint.c: Sort headers.
7421         * break-catch-throw.c: Sort headers.
7422         * break-catch-syscall.c: Sort headers.
7423         * break-catch-sig.c: Sort headers.
7424         * blockframe.c: Sort headers.
7425         * block.c: Sort headers.
7426         * bfin-tdep.c: Sort headers.
7427         * bfin-linux-tdep.c: Sort headers.
7428         * bfd-target.c: Sort headers.
7429         * bcache.c: Sort headers.
7430         * ax-general.c: Sort headers.
7431         * ax-gdb.h: Sort headers.
7432         * ax-gdb.c: Sort headers.
7433         * avr-tdep.c: Sort headers.
7434         * auxv.c: Sort headers.
7435         * auto-load.c: Sort headers.
7436         * arm-wince-tdep.c: Sort headers.
7437         * arm-tdep.c: Sort headers.
7438         * arm-symbian-tdep.c: Sort headers.
7439         * arm-pikeos-tdep.c: Sort headers.
7440         * arm-obsd-tdep.c: Sort headers.
7441         * arm-nbsd-tdep.c: Sort headers.
7442         * arm-nbsd-nat.c: Sort headers.
7443         * arm-linux-tdep.c: Sort headers.
7444         * arm-linux-nat.c: Sort headers.
7445         * arm-fbsd-tdep.c: Sort headers.
7446         * arm-fbsd-nat.c: Sort headers.
7447         * arm-bsd-tdep.c: Sort headers.
7448         * arch-utils.c: Sort headers.
7449         * arc-tdep.c: Sort headers.
7450         * arc-newlib-tdep.c: Sort headers.
7451         * annotate.h: Sort headers.
7452         * annotate.c: Sort headers.
7453         * amd64-windows-tdep.c: Sort headers.
7454         * amd64-windows-nat.c: Sort headers.
7455         * amd64-tdep.c: Sort headers.
7456         * amd64-sol2-tdep.c: Sort headers.
7457         * amd64-obsd-tdep.c: Sort headers.
7458         * amd64-obsd-nat.c: Sort headers.
7459         * amd64-nbsd-tdep.c: Sort headers.
7460         * amd64-nbsd-nat.c: Sort headers.
7461         * amd64-nat.c: Sort headers.
7462         * amd64-linux-tdep.c: Sort headers.
7463         * amd64-linux-nat.c: Sort headers.
7464         * amd64-fbsd-tdep.c: Sort headers.
7465         * amd64-fbsd-nat.c: Sort headers.
7466         * amd64-dicos-tdep.c: Sort headers.
7467         * amd64-darwin-tdep.c: Sort headers.
7468         * amd64-bsd-nat.c: Sort headers.
7469         * alpha-tdep.c: Sort headers.
7470         * alpha-obsd-tdep.c: Sort headers.
7471         * alpha-nbsd-tdep.c: Sort headers.
7472         * alpha-mdebug-tdep.c: Sort headers.
7473         * alpha-linux-tdep.c: Sort headers.
7474         * alpha-linux-nat.c: Sort headers.
7475         * alpha-bsd-tdep.c: Sort headers.
7476         * alpha-bsd-nat.c: Sort headers.
7477         * aix-thread.c: Sort headers.
7478         * agent.c: Sort headers.
7479         * addrmap.c: Sort headers.
7480         * ada-varobj.c: Sort headers.
7481         * ada-valprint.c: Sort headers.
7482         * ada-typeprint.c: Sort headers.
7483         * ada-tasks.c: Sort headers.
7484         * ada-lang.c: Sort headers.
7485         * aarch64-tdep.c: Sort headers.
7486         * aarch64-ravenscar-thread.c: Sort headers.
7487         * aarch64-newlib-tdep.c: Sort headers.
7488         * aarch64-linux-tdep.c: Sort headers.
7489         * aarch64-linux-nat.c: Sort headers.
7490         * aarch64-fbsd-tdep.c: Sort headers.
7491         * aarch64-fbsd-nat.c: Sort headers.
7492         * aarch32-linux-nat.c: Sort headers.
7493
7494 2019-04-04  Tom Tromey  <tom@tromey.com>
7495
7496         * varobj.c (varobj_create): Update.
7497         * rust-exp.y (struct rust_parser) <update_innermost_block,
7498         lookup_symbol>: New methods.
7499         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7500         Rename.
7501         (rust_parser::rust_lookup_type)
7502         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7503         * printcmd.c (display_command, do_one_display): Update.
7504         * parser-defs.h (struct parser_state) <parser_state>: Add
7505         "tracker" parameter.
7506         (block_tracker): New member.
7507         (class innermost_block_tracker) <innermost_block_tracker>: Add
7508         "types" parameter.
7509         <reset>: Remove method.
7510         (innermost_block): Don't declare.
7511         (null_post_parser): Update.
7512         * parse.c (innermost_block): Remove global.
7513         (write_dollar_variable): Update.
7514         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7515         Remove "tracker_types" parameter.
7516         (parse_expression): Add "tracker" parameter.
7517         (parse_expression_for_completion): Update.
7518         (null_post_parser): Add "tracker" parameter.
7519         * p-exp.y: Update rules.
7520         * m2-exp.y: Update rules.
7521         * language.h (struct language_defn) <la_post_parser>: Add
7522         "tracker" parameter.
7523         * go-exp.y: Update rules.
7524         * f-exp.y: Update rules.
7525         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7526         parameter.
7527         * d-exp.y: Update rules.
7528         * c-exp.y: Update rules.
7529         * breakpoint.c (set_breakpoint_condition): Create an
7530         innermost_block_tracker.
7531         (watch_command_1): Likewise.
7532         * ada-lang.c (resolve): Add "tracker" parameter.
7533         (resolve_subexp): Likewise.
7534         * ada-exp.y (write_var_from_sym): Update.
7535
7536 2019-04-04  Tom Tromey  <tom@tromey.com>
7537
7538         * type-stack.h: New file.
7539         * type-stack.c: New file.
7540         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7541         type-stack.h.
7542         (insert_into_type_stack, insert_type, push_type, push_type_int)
7543         (insert_type_address_space, pop_type, pop_type_int)
7544         (pop_typelist, pop_type_stack, append_type_stack)
7545         (push_type_stack, get_type_stack, push_typelist)
7546         (follow_type_instance_flags, follow_types): Don't declare.
7547         * parse.c (type_stack): Remove global.
7548         (parse_exp_in_context): Update.
7549         (insert_into_type_stack, insert_type, push_type, push_type_int)
7550         (insert_type_address_space, pop_type, pop_type_int)
7551         (pop_typelist, pop_type_stack, append_type_stack)
7552         (push_type_stack, get_type_stack, push_typelist)
7553         (follow_type_instance_flags, follow_types): Remove (moved to
7554         type-stack.c).
7555         * f-exp.y (type_stack): New global.
7556         Update rules.
7557         (push_kind_type, f_parse): Update.
7558         * d-exp.y (type_stack): New global.
7559         Update rules.
7560         (d_parse): Update.
7561         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7562         Update rules.
7563         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7564         (HFILES_NO_SRCDIR): Add type-stack.h.
7565
7566 2019-04-04  Tom Tromey  <tom@tromey.com>
7567
7568         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7569         (rust_parser::convert_ast_to_expression, rust_parse)
7570         (rust_lex_test_completion, rust_lex_tests): Update.
7571         * parser-defs.h (struct expr_completion_state): New.
7572         (struct parser_state) <parser_state>: Add completion parameter.
7573         <mark_struct_expression, mark_completion_tag>: New methods.
7574         <parse_completion, m_completion_state>: New members.
7575         (prefixify_expression, null_post_parser): Update.
7576         (mark_struct_expression, mark_completion_tag): Don't declare.
7577         * parse.c (parse_completion, expout_last_struct)
7578         (expout_tag_completion_type, expout_completion_name): Remove
7579         globals.
7580         (parser_state::mark_struct_expression)
7581         (parser_state::mark_completion_tag): Now methods.
7582         (prefixify_expression): Add last_struct parameter.
7583         (prefixify_subexp): Likewise.
7584         (parse_exp_1): Update.
7585         (parse_exp_in_context): Add cstate parameter.  Update.
7586         (parse_expression_for_completion): Create an
7587         expr_completion_state.
7588         (null_post_parser): Add "completion" parameter.
7589         * p-exp.y: Update rules.
7590         (yylex): Update.
7591         * language.h (struct language_defn) <la_post_parser>: Add
7592         "completing" parameter.
7593         * go-exp.y: Update rules.
7594         (lex_one_token): Update.
7595         * expression.h (parse_completion): Don't declare.
7596         * d-exp.y: Update rules.
7597         (lex_one_token): Update rules.
7598         * c-exp.y: Update rules.
7599         (lex_one_token): Update.
7600         * ada-lang.c (resolve): Add "parse_completion" parameter.
7601         (resolve_subexp): Likewise.
7602         (ada_resolve_function): Likewise.
7603
7604 2019-04-04  Tom Tromey  <tom@tromey.com>
7605
7606         * parser-defs.h (struct parser_state) <start_arglist,
7607         end_arglist>: New methods.
7608         <arglist_len, m_funcall_chain>: New members.
7609         (arglist_len, start_arglist, end_arglist): Don't declare.
7610         * parse.c (arglist_len, funcall_chain): Remove global.
7611         (start_arglist, end_arglist): Remove functions.
7612         (parse_exp_in_context): Update.
7613         * p-exp.y: Update rules.
7614         * m2-exp.y: Update rules.
7615         * go-exp.y: Update rules.
7616         * f-exp.y: Update rules.
7617         * d-exp.y: Update rules.
7618         * c-exp.y: Update rules.
7619
7620 2019-04-04  Tom Tromey  <tom@tromey.com>
7621
7622         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7623         lex_operator, push_back>: New methods.
7624         Update all rules.
7625         (rust_parser::lex_hex, lex_escape): Rename and update.
7626         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7627         (rust_parser::lex_operator): Rename and update.
7628         (rust_parser::lex_number, rustyylex, rustyyerror)
7629         (rust_lex_test_init, rust_lex_test_sequence)
7630         (rust_lex_test_push_back, rust_lex_tests): Update.
7631         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7632         parameter.
7633         <lexptr, prev_lexptr>: New members.
7634         (lexptr, prev_lexptr): Don't declare.
7635         * parse.c (lexptr, prev_lexptr): Remove globals.
7636         (parse_exp_in_context): Update.
7637         * p-exp.y (yylex, yyerror): Update.
7638         * m2-exp.y (parse_number, yylex, yyerror): Update.
7639         * go-exp.y (lex_one_token, yyerror): Update.
7640         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7641         * d-exp.y (lex_one_token, yyerror): Update.
7642         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7643         (lex_one_token, yyerror): Update.
7644         * ada-lex.l (YY_INPUT): Update.
7645         (rewind_to_char): Update.
7646         * ada-exp.y (yyerror): Update.
7647
7648 2019-04-04  Tom Tromey  <tom@tromey.com>
7649
7650         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7651         * parser-defs.h (struct parser_state) <parser_state>: Add new
7652         parameter.
7653         <comma_terminates>: New member.
7654         (comma_terminates): Don't declare global.
7655         * parse.c (comma_terminates): Remove global.
7656         (parse_exp_in_context): Update.
7657         * p-exp.y (yylex): Update.
7658         * m2-exp.y (yylex): Update.
7659         * go-exp.y (lex_one_token): Update.
7660         * f-exp.y (yylex): Update.
7661         * d-exp.y (lex_one_token): Update.
7662         * c-exp.y (lex_one_token): Update.
7663         * ada-lex.l: Update.
7664
7665 2019-04-04  Tom Tromey  <tom@tromey.com>
7666
7667         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7668         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7669         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7670         * parser-defs.h (paren_depth): Don't declare.
7671         * parse.c (paren_depth): Remove global.
7672         (parse_exp_in_context): Update.
7673         * p-exp.y (paren_depth): New global.
7674         (pascal_parse): Initialize it.
7675         * m2-exp.y (paren_depth): New global.
7676         (m2_parse): Initialize it.
7677         * go-exp.y (paren_depth): New global.
7678         (go_parse): Initialize it.
7679         * f-exp.y (paren_depth): New global.
7680         (f_parse): Initialize it.
7681         * d-exp.y (paren_depth): New global.
7682         (d_parse): Initialize it.
7683         * c-exp.y (paren_depth): New global.
7684         (c_parse): Initialize it.
7685         * ada-lex.l (paren_depth): New global.
7686         (lexer_init): Initialize it.
7687
7688 2019-04-04  Tom Tromey  <tom@tromey.com>
7689
7690         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7691         (rust_parser::convert_ast_to_type)
7692         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7693         * parser-defs.h (struct parser_state) <parser_state>: Add
7694         parameters.  Initialize new members.
7695         <expression_context_block, expression_context_pc>: New members.
7696         * parse.c (expression_context_block, expression_context_pc):
7697         Remove globals.
7698         (parse_exp_in_context): Update.
7699         * p-exp.y: Update all rules.
7700         (yylex): Update.
7701         * m2-exp.y: Update all rules.
7702         (yylex): Update.
7703         * go-exp.y (yylex): Update.
7704         * f-exp.y (yylex): Update.
7705         * d-exp.y: Update all rules.
7706         (yylex): Update.
7707         * c-exp.y: Update all rules.
7708         (lex_one_token, classify_name, yylex, c_parse): Update.
7709         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7710
7711 2019-04-04  Tom Tromey  <tom@tromey.com>
7712
7713         * gdbarch.h, gdbarch.c: Rebuild.
7714         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7715         * stap-probe.h:
7716         (struct stap_parse_info): Replace "parser_state" with
7717         "expr_builder".
7718         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7719         (parser_state): New class.
7720         * parse.c (expr_builder): Rename.
7721         (expr_builder::release): Rename.
7722         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7723         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7724         (write_exp_elt_longcst, write_exp_elt_floatcst)
7725         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7726         (write_exp_string_vector, write_exp_bitstring)
7727         (write_exp_msymbol, mark_struct_expression)
7728         (write_dollar_variable)
7729         (insert_type_address_space, increase_expout_size): Replace
7730         "parser_state" with "expr_builder".
7731         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7732         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7733         "parser_state" with "expr_builder".
7734
7735 2019-04-04  Tom Tromey  <tom@tromey.com>
7736
7737         * rust-exp.y: Replace "parse_language" with method call.
7738         * p-exp.y:
7739         (yylex): Replace "parse_language" with method call.
7740         * m2-exp.y:
7741         (yylex): Replace "parse_language" with method call.
7742         * go-exp.y (classify_name): Replace "parse_language" with method
7743         call.
7744         * f-exp.y (yylex): Replace "parse_language" with method call.
7745         * d-exp.y (lex_one_token): Replace "parse_language" with method
7746         call.
7747         * c-exp.y:
7748         (lex_one_token, classify_name, yylex): Replace "parse_language"
7749         with method call.
7750         * ada-exp.y (find_primitive_type, type_char)
7751         (type_system_address): Replace "parse_language" with method call.
7752
7753 2019-04-04  Tom Tromey  <tom@tromey.com>
7754
7755         * rust-exp.y: Replace "parse_gdbarch" with method call.
7756         * parse.c (write_dollar_variable, insert_type_address_space):
7757         Replace "parse_gdbarch" with method call.
7758         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7759         call.
7760         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7761         call.
7762         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7763         "parse_gdbarch" with method call.
7764         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7765         with method call.
7766         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7767         "parse_gdbarch" with method call.
7768         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7769         "parse_gdbarch" with method call.
7770         * c-exp.y (parse_type, parse_number, classify_name): Replace
7771         "parse_gdbarch" with method call.
7772         * ada-lex.l: Replace "parse_gdbarch" with method call.
7773         * ada-exp.y (parse_type, find_primitive_type, type_char)
7774         (type_system_address): Replace "parse_gdbarch" with method call.
7775
7776 2019-04-04  Tom Tromey  <tom@tromey.com>
7777
7778         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7779         * stap-probe.c (stap_parse_argument): Update.
7780         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7781         initial_size parameter.
7782         * rust-exp.y (rust_lex_tests): Update.
7783         * parse.c (parser_state): Update.
7784         (parse_exp_in_context): Update.
7785         * parser-defs.h (struct parser_state) <parser_state>: Remove
7786         "initial_size" parameter.
7787
7788 2019-04-04  Tom Tromey  <tom@tromey.com>
7789
7790         * parser-defs.h (increase_expout_size): Don't declare.
7791         * parse.c (increase_expout_size): Now static.
7792
7793 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7794
7795         * gnu-nat.c (gnu_nat_target::wait): Fix
7796         target_waitstatus_to_string call.
7797
7798 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7799
7800         * eval.c (evaluate_subexp_standard): Handle internal functions
7801         during Fortran function call handling.
7802
7803 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7804
7805         * NEWS: Mention new internal functions.
7806         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7807         (read_base_type): Use dwarf2_init_complex_target_type.
7808         * value.c (creal_internal_fn): New function.
7809         (cimag_internal_fn): New function.
7810         (_initialize_values): Register new internal functions.
7811
7812 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7813
7814         * infrun.c (stop_all_threads): If debug_infrun, always
7815         trace the wait status after wait_one, using
7816         target_waitstatus_to_string and target_pid_to_str.
7817         (handle_inferior_event): Replace various trace of
7818         wait status kind by a single trace.
7819         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7820         wait status kind image by target_waitstatus_to_string.
7821         * target/waitstatus.c (target_waitstatus_to_string): Fix
7822         obsolete comment.
7823
7824 2019-04-01  Tom Tromey  <tromey@adacore.com>
7825
7826         PR symtab/23331:
7827         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7828
7829 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7830             Pedro Alves  <palves@redhat.com>
7831
7832         * top.c (quit_force): Call 'finalize_values'.
7833         * value.c (finalize_values): New function.
7834         * value.h (finalize_values): Declare.
7835
7836 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7837
7838         * NEWS: Announce $_gdb_major and $_gdb_minor.
7839
7840         * top.c (init_gdb_version_vars): New function.
7841         (gdb_init): Call init_gdb_version_vars.
7842
7843 2019-03-29  Tom Tromey  <tromey@adacore.com>
7844
7845         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7846         help text.  Remove dead code.
7847
7848 2019-03-29  Keith Seitz  <keiths@redhat.com>
7849
7850         From Siddhesh Poyarekar:
7851         * f-lang.h (f77_get_upperbound): Return LONGEST.
7852         (f77_get_lowerbound): Likewise.
7853         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7854         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7855         print them.
7856         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7857         plongest to format print it.
7858         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7859         (f77_get_upperbound): Likewise.
7860         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7861         LOWER_BOUND to LONGEST.
7862         (f77_create_arrayprint_offset_tbl): Likewise.
7863
7864 2019-03-29  Keith Seitz  <keiths@redhat.com>
7865
7866         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7867         %s/pulongest for TYPE_LENGTH instead of %d in format
7868         strings.
7869         * ada-typerint.c (ada_print_type): Likewise.
7870         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7871         * compile/compile-c-support.c (generate_register_struct): Likewise.
7872         * gdbtypes.c (recursive_dump_type): Likewise.
7873         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7874         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7875         instead of %d in format strings.
7876         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7877         to std::min to ULONGEST.
7878         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7879         instead of %d in format strings.
7880         * tracepoint.c (info_scope_command): Likewise.
7881         * typeprint.c (print_offset_data::update)
7882         (print_offset_data::finish): Likewise.
7883         * xtensa-tdep.c (xtensa_store_return_value)
7884         (xtensa_push_dummy_call): Likewise.
7885
7886 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7887
7888         * windows-nat.c (display_selector): Fixed format specifications
7889         for 64-bit Cygwin.
7890
7891 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7892
7893         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7894
7895 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7896
7897         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7898         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7899         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7900         (nios2_linux_init_abi): Install it.
7901
7902 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7903
7904         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7905
7906 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7907
7908         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7909
7910 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7911             Tom Tromey  <tromey@adacore.com>
7912
7913         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7914
7915 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7916
7917         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7918         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7919         method to compute the bounds of range types. Also print "[evaluated]"
7920         if the bounds' values come from a dynamic evaluation.
7921
7922 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7923
7924         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7925         whitespace when pretty printing is on.
7926
7927 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7928
7929         * ppc-linux-nat.c: Add include.
7930
7931 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7932
7933         * NEWS: Mention AArch64 Pointer Authentication.
7934
7935 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7936
7937         * arm-linux-nat.c: Add include.
7938
7939 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7940
7941         * source-cache.c (source_cache::get_source_lines): Re-read
7942         fullname after calling open_source_file.
7943
7944 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7945
7946         * NEWS: Mention TLS support for FreeBSD.
7947
7948 2019-03-25  Tom Tromey  <tromey@adacore.com>
7949
7950         * minsyms.c (BUNCH_SIZE): Update comment.
7951         (~minimal_symbol_reader): Remove old comment.
7952         (compact_minimal_symbols): Update comment.
7953         (minimal_symbol_reader::install): Remove old comment.  Update
7954         other comments.
7955
7956 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7957
7958         * s390-linux-nat.c: Add include.
7959
7960 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7961
7962         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7963         Call linux_get_hwcap.
7964         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7965         Likewise.
7966         (aarch64_linux_get_hwcap): Remove function.
7967         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7968         declaration.
7969         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7970         linux_get_hwcap.
7971         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7972         * linux-tdep.c (linux_get_hwcap): Add function.
7973         (linux_get_hwcap2): Likewise.
7974         * linux-tdep.h (linux_get_hwcap): Add declaration.
7975         (linux_get_hwcap2): Likewise.
7976         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7977         (ppc_linux_get_hwcap2): Likewise.
7978         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7979         linux_get_hwcap.
7980         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7981         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7982         (ppc_linux_nat_target::read_description): Likewise.
7983         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7984         * s390-linux-nat.c: Likewise.
7985         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7986
7987 2019-03-24  Tom Tromey  <tom@tromey.com>
7988
7989         * ada-lang.c (standard_lookup): Simplify initialization.
7990         (ada_lookup_symbol_nonlocal): Simplify return.
7991         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7992         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7993         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7994         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7995         initialization.
7996         * solib.c (solib_global_lookup): Simplify.
7997         * symtab.c (null_block_symbol): Remove.
7998         (symbol_cache_lookup): Simplify returns.
7999         (lookup_language_this): Simplify returns.
8000         (lookup_symbol_aux): Simplify return.
8001         (lookup_local_symbol): Simplify returns.
8002         (lookup_global_symbol_from_objfile): Simplify return.
8003         (lookup_symbol_in_objfile_symtabs)
8004         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8005         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8006         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8007         * cp-namespace.c (cp_lookup_bare_symbol)
8008         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8009         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8010         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8011         (cp_lookup_symbol_via_imports): Simplify initialization.
8012         (find_symbol_in_baseclass): Likewise.
8013         * symtab.h (null_block_symbol): Remove.
8014         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8015         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8016         (d_lookup_symbol_module): Likewise.
8017         (find_symbol_in_baseclass): Simplify initialization.
8018
8019 2019-03-24  Tom Tromey  <tom@tromey.com>
8020
8021         * expression.h: Don't include symtab.h.
8022         (struct block): Forward declare.
8023
8024 2019-03-24  Tom Tromey  <tom@tromey.com>
8025
8026         * c-exp.y (typebase): Remove casts.
8027         * gdbtypes.c (lookup_unsigned_typename, )
8028         (lookup_signed_typename): Remove cast.
8029         * eval.c (parse_to_comma_and_eval): Remove cast.
8030         * parse.c (write_dollar_variable): Remove cast.
8031         * block.h (struct block) <superblock>: Now const.
8032         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8033         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8034         (map_block): Make "block" const.
8035         * symfile.h (struct quick_symbol_functions)
8036         <map_matching_symbols>: Constify block argument to "callback".
8037         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8038         const.
8039         (find_pc_sect_compunit_symtab): Make "b" const.
8040         (find_symbol_at_address): Likewise.
8041         (search_symbols): Likewise.
8042         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8043         (dw2_debug_names_lookup_symbol): Likewise.
8044         (dw2_map_matching_symbols): Update.
8045         * p-valprint.c (pascal_val_print): Remove "block".
8046         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8047         (aux_add_nonlocal_symbols): Make "block" const.
8048         (resolve_subexp): Remove cast.
8049         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8050         const.
8051         (iterate_over_file_blocks): Likewise.
8052         * f-exp.y (%union) <bval>: Remove.
8053         * coffread.c (patch_opaque_types): Make "b" const.
8054         * spu-tdep.c (spu_catch_start): Make "block" const.
8055         * c-valprint.c (print_unpacked_pointer): Remove "block".
8056         * symmisc.c (dump_symtab_1): Make "b" const.
8057         (block_depth): Make "block" const.
8058         * d-exp.y (%union) <bval>: Remove.
8059         * cp-support.h (cp_lookup_rtti_type): Update.
8060         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8061         * psymtab.c (psym_lookup_symbol): Make "block" const.
8062         (maintenance_check_psymtabs): Make "b" const.
8063         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8064         (enumerate_locals, enumerate_args): Update.
8065         * python/py-symtab.c (stpy_global_block): Make "block" const.
8066         (stpy_static_block): Likewise.
8067         * inline-frame.c (block_starting_point_at): Make "new_block"
8068         const.
8069         * block.c (find_block_in_blockvector): Make return type const.
8070         (blockvector_for_pc_sect): Make "b" const.
8071         (find_block_in_blockvector): Make "b" const.
8072
8073 2019-03-23  Tom Tromey  <tom@tromey.com>
8074
8075         * varobj.c (varobj_create): Update.
8076         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8077         * printcmd.c (display_command, do_one_display): Don't reset
8078         innermost_block.
8079         * parser-defs.h (enum innermost_block_tracker_type): Move to
8080         expression.h.
8081         (innermost_block): Update comment.
8082         * parse.c (parse_exp_1): Add tracker_types parameter.
8083         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8084         tracker_types parameter.  Reset innermost_block.
8085         (parse_exp_in_context): Remove.
8086         (parse_expression_for_completion): Update.
8087         * objfiles.c (~objfile): Don't reset expression_context_block or
8088         innermost_block.
8089         * expression.h (enum innermost_block_tracker_type): Move from
8090         parser-defs.h.
8091         (parse_exp_1): Add tracker_types parameter.
8092         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8093         reset innermost_block.
8094
8095 2019-03-23  Tom Tromey  <tom@tromey.com>
8096
8097         * objfiles.h: Include bcache.h.
8098
8099 2019-03-23  Tom Tromey  <tom@tromey.com>
8100
8101         * linespec.c (get_current_search_block): Use
8102         scoped_restore_current_language.
8103         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8104
8105 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8106             Jiong Wang  <jiong.wang@arm.com>
8107
8108         * aarch64-linux-tdep.c
8109         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8110         section.
8111         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8112
8113 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8114             Jiong Wang  <jiong.wang@arm.com>
8115
8116         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8117         instructions.
8118         (aarch64_analyze_prologue_test): Add PACIASP test.
8119         (aarch64_prologue_prev_register): Unmask PC value.
8120
8121 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8122             Jiong Wang  <jiong.wang@arm.com>
8123
8124         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8125         (aarch64_dwarf2_prev_register): Unmask PC value.
8126         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8127         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8128         DW_CFA_AARCH64_negate_ra_state.
8129         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8130
8131 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8132             Jiong Wang  <jiong.wang@arm.com>
8133
8134         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8135         registers.
8136         (aarch64_pseudo_register_name): Likewise.
8137         (aarch64_pseudo_register_type): Likewise.
8138         (aarch64_pseudo_register_reggroup_p): Likewise.
8139         (aarch64_gdbarch_init): Add pauth registers.
8140         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8141         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8142         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8143         (struct gdbarch_tdep): Add regnum for ra_state.
8144
8145 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8146             Jiong Wang  <jiong.wang@arm.com>
8147
8148         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8149
8150 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8151             Jiong Wang  <jiong.wang@arm.com>
8152
8153         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8154         function.
8155         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8156         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8157         (aarch64_gdbarch_init): Add puth registers.
8158         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8159         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8160         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8161
8162 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8163             Jiong Wang  <jiong.wang@arm.com>
8164
8165         * aarch64-linux-nat.c
8166         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8167         * aarch64-linux-tdep.c
8168         (aarch64_linux_core_read_description): Likewise.
8169         (aarch64_linux_get_hwcap): New function.
8170         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8171         (aarch64_linux_get_hwcap): New declaration.
8172
8173 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8174             Jiong Wang  <jiong.wang@arm.com>
8175
8176         * aarch64-linux-nat.c
8177         (aarch64_linux_nat_target::read_description): Add pauth param.
8178         * aarch64-linux-tdep.c
8179         (aarch64_linux_core_read_description): Likewise.
8180         * aarch64-tdep.c (struct target_desc): Add in pauth.
8181         (aarch64_read_description): Add pauth param.
8182         (aarch64_gdbarch_init): Likewise.
8183         * aarch64-tdep.h (aarch64_read_description): Likewise.
8184         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8185         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8186         * features/Makefile: Add new files.
8187         * features/aarch64-pauth.c: New file.
8188         * features/aarch64-pauth.xml: New file.
8189
8190 2019-03-20  Tom Tromey  <tromey@adacore.com>
8191
8192         * infrun.c (handle_inferior_event): Rename from
8193         handle_inferior_event_1.  Create a scoped_value_mark.
8194         (handle_inferior_event): Remove.
8195
8196 2019-03-19  Tom Tromey  <tromey@adacore.com>
8197
8198         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8199         * infrun.h (print_stop_event): Add "displays" parameter.
8200         * infrun.c (print_stop_event): Add "displays" parameter.
8201
8202 2019-03-19  Pedro Alves  <palves@redhat.com>
8203
8204         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8205         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8206         to -1.  Fix TABs vs spaces.
8207         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8208         * tui/tui-out.h (tui_ui_out) Add intro comments.
8209         <m_line, m_start_of_line>: In-class initialize, and add describing
8210         comment.
8211
8212 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8213
8214         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8215         variable names.
8216         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8217
8218 2019-03-18  Pedro Alves  <palves@redhat.com>
8219             Eli Zaretskii <eliz@gnu.org>
8220
8221         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8222         m_line and m_start_of_line.
8223
8224 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8225
8226         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8227         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8228         it returns a newline.  This fixes a regression in TU mode, whereby
8229         the next line is output on the same screen line as the user input.
8230
8231 2019-03-18  Tom Tromey  <tromey@adacore.com>
8232
8233         * minsyms.c (minimal_symbol_reader::install): Remove call to
8234         obstack_blank.
8235
8236 2019-03-18  Pedro Alves  <palves@redhat.com>
8237
8238         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8239         New globals.
8240         (apply_style): New, factored out from ...
8241         (apply_ansi_escape): ... this.  Handle reverse video mode.
8242         (tui_set_reverse_mode): New function.
8243         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8244         * tui/tui-winsource.c (tui_show_source_line): Use
8245         tui_set_reverse_mode instead of setting A_STANDOUT.
8246         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8247         New setter methods.
8248
8249 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8250
8251         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8252         Handle tabs.
8253
8254 2019-03-18  Tom Tromey  <tromey@adacore.com>
8255
8256         * ada-lang.c (empty_array): Add "high" parameter.
8257         (ada_evaluate_subexp): Update.
8258
8259 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8260
8261         * unittests/string_view-selftests.c: Define
8262         _initialize_string_view_selftests unconditionally.
8263
8264 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8265
8266         PR gdb/24350
8267         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8268
8269 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8270
8271         PR gdb/24351
8272         * windows-nat.c (display_selector): Fix format specifiers.
8273
8274 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8275
8276         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8277         tui_refill_source_window instead of tui_refresh_win, to update the
8278         current execution line.  This fixes redisplay of the current line
8279         when stepping through the code with "next" or "step".
8280
8281 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8282
8283         * source-cache.c (source_cache::get_source_lines): Call
8284         find_source_lines to initialize s->nlines.  This fixes vertical
8285         scrolling of TUI source window when the DOWN arrow is pressed.
8286
8287 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8288
8289         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8290         linux-thread-db.c (_initialize_thread_db): Likewise.
8291
8292 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8293
8294         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8295         wclrtoeol in tui_show_source_line".  This reverts changes made in
8296         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8297
8298 2019-03-15  Tom Tromey  <tom@tromey.com>
8299
8300         * symtab.h (struct minimal_symbol): Derive from
8301         general_symbol_info.
8302         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8303         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8304         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8305         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8306         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8307         (MSYMBOL_SEARCH_NAME): Update.
8308         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8309         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8310         * minsyms.c (minimal_symbol_reader::record_full): Update.
8311
8312 2019-03-15  Tom Tromey  <tom@tromey.com>
8313
8314         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8315
8316 2019-03-15  Tom Tromey  <tom@tromey.com>
8317
8318         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8319         unique_xmalloc_ptr.
8320         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8321         Update.
8322         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8323         (build_minimal_symbol_hash_tables)
8324         (minimal_symbol_reader::install): Update.
8325
8326 2019-03-15  Tom Tromey  <tom@tromey.com>
8327
8328         * symtab.c (create_demangled_names_hash): Update.
8329         (symbol_set_names): Update.
8330         * objfiles.h (struct objfile_per_bfd_storage)
8331         <demangled_names_hash>: Now an htab_up.
8332         * objfiles.c (objfile_per_bfd_storage): Simplify.
8333
8334 2019-03-15  Tom Tromey  <tom@tromey.com>
8335
8336         * objfiles.h (struct objfile_per_bfd_storage): Declare
8337         destructor.
8338         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8339         New.
8340         (get_objfile_bfd_data): Use new.  Don't initialize
8341         language_of_main.
8342         (free_objfile_per_bfd_storage): Remove.
8343         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8344
8345 2019-03-15  Tom Tromey  <tom@tromey.com>
8346
8347         * symfile.c (reread_symbols): Update.
8348         * objfiles.c (objfile::objfile): Update.
8349         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8350         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8351         comment.
8352         (minimal_symbol_reader::install): Update.
8353         (terminate_minimal_symbol_table): Remove.
8354         * jit.c (jit_object_close_impl): Update.
8355
8356 2019-03-15  Tom Tromey  <tom@tromey.com>
8357
8358         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8359         initializations.
8360
8361 2019-03-15  Tom Tromey  <tom@tromey.com>
8362
8363         * objfiles.h (struct objfile_per_bfd_storage)
8364         <demangled_hash_languages>: Now a bitset.
8365         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8366         (lookup_minimal_symbol): Update.
8367
8368 2019-03-15  Tom Tromey  <tom@tromey.com>
8369
8370         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8371         Don't return the symbol.
8372         * coffread.c (record_minimal_symbol): Use record_full.
8373
8374 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8375
8376         The MS-Windows port of ncurses fails to switch to a color pair if
8377         one or both of the colors are the implicit default colors.  This
8378         change records the default colors when TUI is initialized, and
8379         then specifies them explicitly when a color pair uses the default
8380         colors.  This allows color styling in TUI mode on MS-Windows.
8381
8382         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8383         ncurses_norm_attr.
8384         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8385         colors in ncurses_norm_attr.
8386         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8387         "none", replace it with the default color recorded in
8388         ncurses_norm_attr.
8389
8390 2019-03-14  Tom Tromey  <tromey@adacore.com>
8391
8392         * source-cache.h (class source_cache) <get_source_lines>: Return
8393         std::string.
8394         * source-cache.c (source_cache::extract_lines): Handle case where
8395         first_pos==npos.  Return std::string.
8396         (source_cache::get_source_lines): Update.
8397
8398 2019-03-14  Tom Tromey  <tromey@adacore.com>
8399
8400         * NEWS: Add item for "style sources" commands.
8401         * source-cache.c (source_cache::get_source_lines): Check
8402         source_styling.
8403         * cli/cli-style.c (source_styling): New global.
8404         (_initialize_cli_style): Add "style sources" commands.
8405         (show_style_sources): New function.
8406         * cli/cli-style.h (source_styling): Declare.
8407
8408 2019-03-14  Pedro Alves  <palves@redhat.com>
8409             Tom Tromey  <tromey@adacore.com>
8410
8411         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8412         * tui/tui-winsource.c (tui_refill_source_window): New function,
8413         from...
8414         (tui_horizontal_source_scroll): ... here.  Move some logic.
8415         * cli/cli-style.c (set_style_enabled): Notify new observable.
8416         * tui/tui-hooks.c (tui_redisplay_source): New function.
8417         (tui_attach_detach_observers): Attach or detach
8418         tui_redisplay_source.
8419         * observable.h (source_styling_changed): New observable.
8420         * observable.c: Define source_styling_changed observable.
8421
8422 2019-03-13  Tom Tromey  <tromey@adacore.com>
8423
8424         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8425         (i386_gnu_nat_target::store_registers): Update.
8426         * target-debug.h (target_debug_print_std_string): New macro.
8427         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8428         * windows-tdep.c (display_one_tib): Update.
8429         * tui/tui-stack.c (tui_make_status_line): Update.
8430         * top.c (print_inferior_quit_action): Update.
8431         * thread.c (thr_try_catch_cmd): Update.
8432         (add_thread_with_info): Update.
8433         (thread_target_id_str): Update.
8434         (thr_try_catch_cmd): Update.
8435         (thread_command): Update.
8436         (thread_find_command): Update.
8437         * record-btrace.c (record_btrace_target::info_record)
8438         (record_btrace_resume_thread, record_btrace_target::resume)
8439         (record_btrace_cancel_resume, record_btrace_step_thread)
8440         (record_btrace_target::wait, record_btrace_target::wait)
8441         (record_btrace_target::wait, record_btrace_target::stop): Update.
8442         * progspace.c (print_program_space): Update.
8443         * process-stratum-target.c
8444         (process_stratum_target::thread_address_space): Update.
8445         * linux-fork.c (linux_fork_mourn_inferior)
8446         (detach_checkpoint_command, info_checkpoints_command)
8447         (linux_fork_context): Update.
8448         (linux_fork_detach): Update.
8449         (class scoped_switch_fork_info): Update.
8450         (delete_checkpoint_command): Update.
8451         * infrun.c (follow_fork_inferior): Update.
8452         (follow_fork_inferior): Update.
8453         (proceed_after_vfork_done): Update.
8454         (handle_vfork_child_exec_or_exit): Update.
8455         (follow_exec): Update.
8456         (displaced_step_prepare_throw): Update.
8457         (displaced_step_restore): Update.
8458         (start_step_over): Update.
8459         (resume_1): Update.
8460         (clear_proceed_status_thread): Update.
8461         (proceed): Update.
8462         (print_target_wait_results): Update.
8463         (do_target_wait): Update.
8464         (context_switch): Update.
8465         (stop_all_threads): Update.
8466         (restart_threads): Update.
8467         (finish_step_over): Update.
8468         (handle_signal_stop): Update.
8469         (switch_back_to_stepped_thread): Update.
8470         (keep_going_pass_signal): Update.
8471         (print_exited_reason): Update.
8472         (normal_stop): Update.
8473         * inferior.c (inferior_pid_to_str): Change return type.
8474         (print_selected_inferior): Update.
8475         (add_inferior): Update.
8476         (detach_inferior): Update.
8477         * dummy-frame.c (fprint_dummy_frames): Update.
8478         * dcache.c (dcache_info_1): Update.
8479         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8480         (btrace_fetch, btrace_clear): Update.
8481         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8482         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8483         type.
8484         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8485         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8486         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8487         * gdbarch.c, gdbarch.h: Rebuild.
8488         * gdbarch.sh (core_pid_to_str): Change return type.
8489         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8490         return type.
8491         (windows_nat_target::pid_to_str): Change return type.
8492         (windows_delete_thread): Update.
8493         (windows_nat_target::attach): Update.
8494         (windows_nat_target::files_info): Update.
8495         * target-delegates.c: Rebuild.
8496         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8497         return type.
8498         (sol_thread_target::pid_to_str): Change return type.
8499         * remote.c (class remote_target) <pid_to_str>: Change return
8500         type.
8501         (remote_target::pid_to_str): Change return type.
8502         (extended_remote_target::attach, remote_target::remote_stop_ns)
8503         (remote_target::remote_notif_remove_queued_reply)
8504         (remote_target::push_stop_reply, remote_target::disable_btrace):
8505         Update.
8506         (extended_remote_target::attach): Update.
8507         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8508         type.
8509         (gdbsim_target::pid_to_str): Change return type.
8510         * ravenscar-thread.c (struct ravenscar_thread_target)
8511         <pid_to_str>: Change return type.
8512         (ravenscar_thread_target::pid_to_str): Change return type.
8513         * procfs.c (class procfs_target) <pid_to_str>: Change return
8514         type.
8515         (procfs_target::pid_to_str): Change return type.
8516         (procfs_target::attach): Update.
8517         (procfs_target::detach): Update.
8518         (procfs_target::fetch_registers): Update.
8519         (procfs_target::store_registers): Update.
8520         (procfs_target::wait): Update.
8521         (procfs_target::files_info): Update.
8522         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8523         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8524         return type.
8525         (nto_procfs_target::pid_to_str): Change return type.
8526         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8527         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8528         return type.
8529         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8530         (exit_lwp): Update.
8531         (attach_proc_task_lwp_callback, get_detach_signal)
8532         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8533         (linux_nat_target::resume, wait_lwp, stop_callback)
8534         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8535         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8536         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8537         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8538         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8539         type.
8540         (inf_ptrace_target::attach): Update.
8541         (inf_ptrace_target::files_info): Update.
8542         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8543         type.
8544         (go32_nat_target::pid_to_str): Change return type.
8545         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8546         (gnu_nat_target::wait): Update.
8547         (gnu_nat_target::wait): Update.
8548         (gnu_nat_target::resume): Update.
8549         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8550         (fbsd_nat_target::wait): Update.
8551         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8552         type.
8553         (darwin_nat_target::attach): Update.
8554         * corelow.c (class core_target) <pid_to_str>: Change return type.
8555         (core_target::pid_to_str): Change return type.
8556         * target.c (normal_pid_to_str): Change return type.
8557         (default_pid_to_str): Likewise.
8558         (target_pid_to_str): Change return type.
8559         (target_translate_tls_address): Update.
8560         (target_announce_detach): Update.
8561         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8562         return type.
8563         (bsd_uthread_target::pid_to_str): Change return type.
8564         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8565         type.
8566         (bsd_kvm_target::pid_to_str): Change return type.
8567         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8568         return type.
8569         (aix_thread_target::pid_to_str): Change return type.
8570         * target.h (struct target_ops) <pid_to_str>: Change return type.
8571         (target_pid_to_str, normal_pid_to_str): Likewise.
8572         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8573         type.
8574         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8575         type.
8576         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8577         return type.
8578         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8579         type.
8580         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8581         type.
8582         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8583         return type.
8584
8585 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8586
8587         * NEWS: Mention that the new default MI version is 3.  Mention
8588         changes to the output of commands and events that deal with
8589         multi-location breakpoints.
8590         * breakpoint.c: Include "mi/mi-out.h".
8591         (print_one_breakpoint): Change output syntax if using MI version
8592         >= 3.
8593         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8594         New.
8595         (mi_multi_location_breakpoint_output_fixed): New.
8596         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8597         (mi_cmd_fix_multi_location_breakpoint_output): New.
8598         (mi_multi_location_breakpoint_output_fixed): New.
8599         * mi/mi-cmds.c (mi_cmds): Register command
8600         -fix-multi-location-breakpoint-output.
8601         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8602         interpreter "mi".
8603
8604 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8605
8606         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8607         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8608         instantiate mi_ui_out based on interpreter name.
8609         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8610         * mi/mi-main.c (mi_load_progress): Likewise.
8611
8612 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8613
8614         * NEWS: Combine separate "New targets" sections for 8.3.
8615
8616 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8617
8618         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8619         (ppcfbsd_init_abi): Install gdbarch
8620         "fetch_tls_load_module_address" and "get_thread_local_address"
8621         methods.
8622
8623 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8624
8625         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8626         (riscv_fbsd_init_abi): Install gdbarch
8627         "fetch_tls_load_module_address" and "get_thread_local_address"
8628         methods.
8629
8630 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8631
8632         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8633         (i386fbsd_init_abi): Install gdbarch
8634         "fetch_tls_load_module_address" and "get_thread_local_address"
8635         methods.
8636
8637 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8638
8639         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8640         (amd64fbsd_init_abi): Install gdbarch
8641         "fetch_tls_load_module_address" and "get_thread_local_address"
8642         methods.
8643
8644 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8645
8646         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8647         (struct fbsd_pspace_data): New type.
8648         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8649         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8650         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8651         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8652         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8653
8654 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8655
8656         * gdbtypes.c (lookup_struct_elt): New function.
8657         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8658         * gdbtypes.h (struct struct_elt): New type.
8659         (lookup_struct_elt): New prototype.
8660
8661 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8662
8663         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8664         remove disabled code block.
8665
8666 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8667
8668         * gdbarch.sh (get_thread_local_address): New method.
8669         * gdbarch.h, gdbarch.c: Regenerate.
8670         * target.c (target_translate_tls_address): Use
8671         gdbarch_get_thread_local_address if present instead of
8672         target::get_thread_local_address.
8673
8674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8675
8676         * target.h (target::get_thread_local_address): Update comment.
8677
8678 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8679
8680         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8681         objfile->separate_debug_objfile_backlink if not NULL.
8682
8683 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8684
8685         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8686         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8687         (amd64bsd_store_inferior_registers): Likewise.
8688         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8689         Enable segment base registers.
8690         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8691         PT_GETFSBASE and PT_GETGSBASE.
8692         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8693         PT_SETGSBASE.
8694         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8695         segment base registers.
8696         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8697
8698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8699
8700         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8701         Update calls to i386_target_description to add 'segments'
8702         parameter.
8703         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8704         add segment base registers.
8705         * arch/i386.c (i386_create_target_description): Add 'segments'
8706         parameter to enable segment base registers.
8707         * arch/i386.h (i386_create_target_description): Likewise.
8708         * features/i386/32bit-segments.xml: New file.
8709         * features/i386/32bit-segments.c: Generate.
8710         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8711         call to i386_target_description to add 'segments' parameter.
8712         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8713         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8714         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8715         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8716         if feature is present.
8717         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8718         Add 'segments' parameter to call to i386_target_description.
8719         (i386_target_description): Add 'segments' parameter to enable
8720         segment base registers.
8721         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8722         to call to i386_target_description.
8723         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8724         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8725         Define I386_NUM_REGS.
8726         (i386_target_description): Add 'segments' parameter to enable
8727         segment base registers.
8728
8729 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8730
8731         PR/24325
8732         * source-cache.c: #undef open and close, to avoid unresolved
8733         externals during linking.
8734
8735 2019-03-12  Tom Tromey  <tromey@adacore.com>
8736
8737         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8738         const.  Add initializers.
8739         (_initialize_remote): Don't initialize ptid globals.
8740
8741 2019-03-12  Pedro Alves  <palves@redhat.com>
8742
8743         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8744
8745 2019-03-12  Pedro Alves  <palves@redhat.com>
8746
8747         * cp-name-parser.y (main): Remove unused 'len' variable.
8748
8749 2019-03-12  Tom Tromey  <tromey@adacore.com>
8750
8751         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8752         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8753
8754 2019-03-12  Tom Tromey  <tromey@adacore.com>
8755
8756         * linux-nat.c (iterate_over_lwps): Update.
8757         (stop_callback): Remove parameter.
8758         (stop_wait_callback, detach_callback, resume_set_callback)
8759         (select_singlestep_lwp_callback, set_ignore_sigint)
8760         (status_callback, resumed_callback, resume_clear_callback)
8761         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8762         data parameter.
8763         (linux_nat_target::detach, linux_nat_target::resume)
8764         (linux_stop_and_wait_all_lwps, select_event_lwp)
8765         (linux_nat_filter_event, linux_nat_wait_1)
8766         (linux_nat_target::kill, linux_nat_target::stop)
8767         (linux_nat_target::stop): Update.
8768         (linux_nat_resume_callback): Change type.
8769         (resume_stopped_resumed_lwps, count_events_callback)
8770         (select_event_lwp_callback): Likewise.
8771         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8772         * arm-linux-nat.c (struct update_registers_data): Remove.
8773         (update_registers_callback): Change type.
8774         (arm_linux_insert_hw_breakpoint1): Update.
8775         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8776         parameter.
8777         (x86_linux_dr_set_addr): Update.
8778         (x86_linux_dr_set_control): Update.
8779         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8780         (iterate_over_lwps): Use gdb::function_view.
8781         * nat/aarch64-linux-hw-point.c (struct
8782         aarch64_dr_update_callback_param): Remove.
8783         (debug_reg_change_callback): Change type.
8784         (aarch64_notify_debug_reg_change): Update.
8785         * s390-linux-nat.c (s390_refresh_per_info): Update.
8786
8787 2019-03-11  Tom Tromey  <tromey@adacore.com>
8788
8789         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8790         redundant assignment to "this_cu".
8791
8792 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8793
8794         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8795
8796 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8797
8798         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8799         from...
8800         (rank_one_type): ... this.
8801
8802 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8803
8804         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8805         from...
8806         (rank_one_type): ... this.
8807
8808 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8809
8810         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8811         from...
8812         (rank_one_type): ... this.
8813
8814 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8815
8816         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8817         from...
8818         (rank_one_type): ... this.
8819
8820 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8821
8822         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8823         from...
8824         (rank_one_type): ... this.
8825
8826 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8827
8828         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8829         from...
8830         (rank_one_type): ... this.
8831
8832 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8833
8834         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8835         from...
8836         (rank_one_type): ... this.
8837
8838 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8839
8840         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8841         from...
8842         (rank_one_type): ... this.
8843
8844 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8845
8846         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8847         from...
8848         (rank_one_type): ... this.
8849
8850 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8851
8852         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8853         from...
8854         (rank_one_type): ... this.
8855
8856 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8857
8858         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8859         from...
8860         (rank_one_type): ... this.
8861
8862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8863
8864         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8865         from...
8866         (rank_one_type): ... this.
8867
8868 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8869
8870         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8871         inferior-events' shows the example events.
8872
8873 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8874
8875         Support styling on native MS-Windows console
8876
8877         PR/24315
8878         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8879         on MS-Windows if $TERM is not defined.
8880
8881         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8882
8883         * posix-hdep.c (gdb_console_fputs):
8884         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8885         functions.
8886         * ui-file.h (gdb_console_fputs): Add prototype.
8887
8888         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8889         back to fputs only if the former returns zero.
8890
8891 2019-03-07  Tom Tromey  <tom@tromey.com>
8892
8893         * symmisc.c (print_symbol_bcache_statistics): Update.
8894         (print_objfile_statistics): Update.
8895         * symfile.c (allocate_symtab): Update.
8896         * stabsread.c: Don't include bcache.h.
8897         * psymtab.h (struct psymbol_bcache): Don't declare.
8898         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8899         (psymbol_bcache_init, psymbol_bcache_free)
8900         (psymbol_bcache_get_bcache): Don't declare.
8901         * psymtab.c (struct psymbol_bcache): Remove.
8902         (psymtab_storage::psymtab_storage): Update.
8903         (psymtab_storage::~psymtab_storage): Update.
8904         (psymbol_bcache_init, psymbol_bcache_free)
8905         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8906         (add_psymbol_to_bcache): Update.
8907         (allocate_psymtab): Update.
8908         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8909         macro_cache>: No longer pointers.
8910         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8911         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8912         * macrotab.c (macro_bcache): Update.
8913         * macroexp.c: Don't include bcache.h.
8914         * gdbtypes.c (check_types_worklist): Update.
8915         (types_deeply_equal): Remove TRY/CATCH.  Update.
8916         * elfread.c (elf_symtab_read): Update.
8917         * dwarf2read.c: Don't include bcache.h.
8918         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8919         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8920         (print_bcache_statistics, bcache_memory_used): Don't declare.
8921         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8922         methods.  Rename all data members.
8923         * bcache.c (struct bcache): Move to bcache.h.
8924         (bcache::expand_hash_table): Rename from expand_hash_table.
8925         (bcache): Remove.
8926         (bcache::insert): Rename from bcache_full.
8927         (bcache::compare): Rename from bcache_compare.
8928         (bcache_xmalloc): Remove.
8929         (bcache::~bcache): Rename from bcache_xfree.
8930         (bcache::print_statistics): Rename from print_bcache_statistics.
8931         (bcache::memory_used): Rename from bcache_memory_used.
8932
8933 2019-03-07  Pedro Alves  <palves@redhat.com>
8934
8935         * infrun.c (normal_stop): Also check for
8936         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8937
8938 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8939
8940         * f-lang.c (value_from_host_double): Moved to...
8941         * value.c (value_from_host_double): ...here.
8942         * value.h (value_from_host_double): Declare.
8943         * guile/scm-math.c (vlscm_convert_typed_number): Use
8944         value_from_host_double.
8945         (vlscm_convert_number): Likewise.
8946         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8947         * python/py-value.c (convert_value_from_python): Likewise.
8948
8949 2019-03-06  Tom Tromey  <tom@tromey.com>
8950
8951         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8952
8953 2019-03-06  Tom Tromey  <tom@tromey.com>
8954
8955         * utils.h (free_current_contents): Don't declare.
8956         * utils.c (free_current_contents): Remove.
8957
8958 2019-03-06  Tom Tromey  <tom@tromey.com>
8959
8960         * top.c (quit_force): Update.
8961         * main.c (captured_command_loop): Update.
8962         * common/new-op.c (operator new): Update.
8963         * common/common-exceptions.c (struct catcher)
8964         <save_cleanup_chain>: Remove member.
8965         (exceptions_state_mc_init): Update.
8966         (exception_try_scope_entry): Return nullptr.
8967         (exception_try_scope_exit, exception_rethrow)
8968         (throw_exception_sjlj, throw_exception_cxx): Update.
8969         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8970         (all_cleanups, do_cleanups, discard_cleanups)
8971         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8972         (restore_cleanups, restore_final_cleanups): Don't declare.
8973         (do_final_cleanups): Remove parameter.
8974         * common/cleanups.c (cleanup_chain, make_cleanup)
8975         (make_cleanup_dtor, all_cleanups, do_cleanups)
8976         (discard_my_cleanups, discard_cleanups)
8977         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8978         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8979         (null_cleanup): Remove.
8980         (do_final_cleanups): Remove parameter.
8981
8982 2019-03-06  Tom Tromey  <tom@tromey.com>
8983
8984         * remote.c (remote_target::remote_parse_stop_reply): Use
8985         unique_xmalloc_ptr.
8986
8987 2019-03-06  Tom Tromey  <tom@tromey.com>
8988
8989         * stabsread.c (struct stabs_field_info): Rename from field_info.
8990         <list, fnlist>: Add initializers.
8991         <obstack>: New member.
8992         (read_member_functions, read_struct_fields, read_baseclasses):
8993         Allocate on obstack.  Don't use cleanups.
8994         (read_one_struct_field, read_member_functions, read_struct_fields)
8995         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8996         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8997         (read_struct_type): Update.
8998
8999 2019-03-06  Tom Tromey  <tom@tromey.com>
9000
9001         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9002         * common/filestuff.h (make_cleanup_close): Don't declare.
9003         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9004         Remove.
9005
9006 2019-03-06  Tom Tromey  <tom@tromey.com>
9007
9008         * solib-aix.c: Use make_scope_exit.
9009
9010 2019-03-06  Tom Tromey  <tom@tromey.com>
9011
9012         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9013         Use make_scope_exit.
9014
9015 2019-03-06  Tom Tromey  <tom@tromey.com>
9016
9017         * solib-svr4.c (disable_probes_interface): Remove parameter.
9018         (svr4_handle_solib_event): Use make_scope_exit.
9019
9020 2019-03-06  Tom Tromey  <tom@tromey.com>
9021
9022         * remote.c (struct stop_reply_deleter): Remove.
9023         (stop_reply_up): Update.
9024         (struct stop_reply): Derive from notif_event.  Don't typedef.
9025         <regcache>: Now a std::vector.
9026         (stop_reply_xfree): Remove.
9027         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9028         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9029         (remote_target::discard_pending_stop_replies): Use delete.
9030         (remote_target::remote_parse_stop_reply): Update.
9031         (remote_target::process_stop_reply): Update.
9032         * remote-notif.h (struct notif_event): Add virtual destructor.
9033         Remove "dtr" member.
9034         (struct notif_client) <alloc_event>: Return a unique_ptr.
9035         (notif_event_xfree): Don't declare.
9036         (notif_event_up): New typedef.
9037         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9038         (notif_event_xfree, do_notif_event_xfree): Remove.
9039         (remote_notif_state_xfree): Update.
9040
9041 2019-03-06  Tom Tromey  <tom@tromey.com>
9042
9043         * infrun.c (displaced_step_clear_cleanup): Now a
9044         forward_scope_exit type.
9045         (displaced_step_prepare_throw): Update.
9046         (displaced_step_fixup): Update.
9047
9048 2019-03-06  Tom Tromey  <tom@tromey.com>
9049
9050         * inferior.h (class inferior): Update comment.
9051         * gdbthread.h (class thread_info): Update comment.
9052
9053 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9054             Tom Tromey  <tom@tromey.com>
9055
9056         * stabsread.h (struct stab_section_list): Remove.
9057         (coffstab_build_psymtabs): Update.
9058         * dbxread.c (symbuf_sections): Now a std::vector.
9059         (sect_idx): New global.
9060         (fill_symbuf): Update.
9061         (coffstab_build_psymtabs): Change type of stabsects parameter.
9062         Update.
9063         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9064         std::vector.
9065         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9066         (coff_locate_sections): Update.
9067         (coff_symfile_read): Remove cleanups.  Update.
9068         (init_stringtab): Add storage parameter.
9069         (free_stringtab, free_stringtab_cleanup): Remove.
9070         (init_lineno): Add storage parameter.
9071         (free_linetab, free_linetab_cleanup): Remove.
9072
9073 2019-03-06  Pedro Alves  <palves@redhat.com>
9074
9075         * linux-fork.c (fork_info::clobber_regs): Delete.
9076         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9077         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9078         comment.  Adjust.
9079         (scoped_switch_fork_info::scoped_switch_fork_info)
9080         (checkpoint_command, linux_fork_context): Adjust
9081         fork_save_infrun_state calls.
9082
9083 2019-03-06  Pedro Alves  <palves@redhat.com>
9084
9085         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9086         (inf_has_multiple_threads): Return 'bool' and rewrite using
9087         inferior_info::threads().
9088
9089 2019-03-06  Pedro Alves  <palves@redhat.com>
9090
9091         * linux-fork.c: Include <list>.
9092         (fork_list): Now a std::list instance.
9093         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9094         (forks_exist_p, find_last_fork): Adjust.
9095         (new_fork): Delete.
9096         (one_fork_p): New.
9097         (add_fork): Adjust.
9098         (free_fork): Delete, folded into fork_info::~fork_info().
9099         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9100         Adjust.
9101         (init_fork_list): Delete.
9102         (linux_fork_killall, linux_fork_mourn_inferior)
9103         (linux_fork_detach, info_checkpoints_command): Adjust.
9104         (_initialize_linux_fork): No longer call init_fork_list.
9105
9106 2019-03-06  Pedro Alves  <palves@redhat.com>
9107
9108         * linux-fork.c (new_fork): New, split out of ...
9109         (add_fork): ... this.  Return void.  Move "first fork" special
9110         case from here, to ...
9111         (checkpoint_command): ... here.
9112         * linux-linux.h (add_fork): Return void.
9113
9114 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9115
9116         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9117
9118 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9119             Chris January  <chris.january@arm.com>
9120             David Lecomber  <david.lecomber@arm.com>
9121
9122         * f-exp.y: New token, UNOP_INTRINSIC.
9123         (exp): New pattern using UNOP_INTRINSIC token.
9124         (f77_keywords): Add 'abs' keyword.
9125         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9126         (value_from_host_double): New function.
9127         (evaluate_subexp_f): Support UNOP_ABS.
9128
9129 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9130
9131         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9132         types.
9133
9134 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9135
9136         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9137         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9138         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9139
9140 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9141
9142         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9143
9144 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9145             Chris January  <chris.january@arm.com>
9146
9147         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9148         * f-exp.y: Define 'KIND' token.
9149         (exp): New pattern for KIND expressions.
9150         (ptype): Handle types with a kind extension.
9151         (direct_abs_decl): Extend to spot kind extensions.
9152         (f77_keywords): Add 'kind' to the list.
9153         (push_kind_type): New function.
9154         (convert_to_kind_type): New function.
9155         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9156         * parse.c (operator_length_standard): Likewise.
9157         * parser-defs.h (enum type_pieces): Add tp_kind.
9158         * std-operator.def: Add UNOP_KIND.
9159
9160 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9161
9162         * f-exp.y (f_parse): Set yydebug.
9163
9164 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9165
9166         * f-lang.c (evaluate_subexp_f): New function.
9167         (exp_descriptor_f): New global.
9168         (f_language_defn): Use exp_descriptor_f instead of
9169         exp_descriptor_standard.
9170
9171 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9172
9173         * f-exp.y (struct token): Add comments.
9174         (dot_ops): Remove uppercase versions and the end marker.
9175         (f77_keywords): Likewise.
9176         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9177         entries in the dot_ops array are case insensitive, and use
9178         strncasecmp to compare strings.  Also some whitespace cleanup in
9179         this area.  Similar for the f77_keywords array, except entries in
9180         this list might be case sensitive.
9181
9182 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9183
9184         * f-exp.y (struct f77_boolean_val): Add comments.
9185         (boolean_values): Remove uppercase versions, and end marker.
9186         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9187         and use strncasecmp to achieve case insensitivity.  Additionally,
9188         perform whitespace cleanup around this code.
9189
9190 2019-03-06  Tom Tromey  <tromey@adacore.com>
9191
9192         * remote-sim.c (gdbsim_target_open): Use result of
9193         gdb_argv::release.
9194
9195 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9196         Dirk Schubert  <dirk.schubert@arm.com>
9197         Chris January  <chris.january@arm.com>
9198
9199         * eval.c (evaluate_subexp_standard): Call Fortran argument
9200         wrapping logic.
9201         * f-lang.c (struct value): A value which can be passed into a
9202         Fortran function call.
9203         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9204         where appropriate.
9205         (struct type): Value ready for a Fortran function call.
9206         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9207         is needed.
9208         * f-lang.h (fortran_argument_convert): Declaration.
9209         (fortran_preserve_arg_pointer): Declaration.
9210         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9211
9212 2019-03-05  Tom Tromey  <tromey@adacore.com>
9213
9214         * python/py-prettyprint.c (print_string_repr): Remove #if.
9215         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9216
9217 2019-03-05  Tom Tromey  <tromey@adacore.com>
9218
9219         * target.c (the_dummy_target): Move later.  Change type to
9220         "dummy_target".
9221         (initialize_targets): Don't initialize the_dummy_target.
9222
9223 2019-03-05  Tom Tromey  <tromey@adacore.com>
9224
9225         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9226         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9227
9228 2019-03-05  Tom Tromey  <tromey@adacore.com>
9229
9230         * windows-nat.c (windows_nat_target::attach)
9231         (windows_nat_target::detach): Don't call gdb_flush.
9232         * valprint.c (generic_val_print, val_print, val_print_string):
9233         Don't call gdb_flush.
9234         * utils.c (defaulted_query): Don't call gdb_flush.
9235         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9236         * target.c (target_announce_detach): Don't call gdb_flush.
9237         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9238         * remote.c (extended_remote_target::attach): Don't call
9239         gdb_flush.
9240         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9241         * printcmd.c (do_examine): Don't call gdb_flush.
9242         (info_display_command): Don't call gdb_flush.
9243         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9244         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9245         * memattr.c (info_mem_command): Don't call gdb_flush.
9246         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9247         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9248         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9249         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9250         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9251         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9252         (gnu_nat_target::detach): Don't call gdb_flush.
9253         * f-valprint.c (f_val_print): Don't call gdb_flush.
9254         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9255         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9256         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9257         gdb_flush.
9258         * c-valprint.c (c_val_print): Don't call gdb_flush.
9259         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9260
9261 2019-03-05  Tom Tromey  <tromey@adacore.com>
9262
9263         * varobj.c (update_dynamic_varobj_children): Update.
9264         (install_default_visualizer): Use reset, not release.
9265         * value.c (set_internalvar): Update.
9266         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9267         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9268         ATTRIBUTE_UNUSED_RESULT.
9269
9270 2019-03-05  Tom Tromey  <tromey@adacore.com>
9271
9272         * remote.c (class scoped_remote_fd) <release>: Add
9273         ATTRIBUTE_UNUSED_RESULT.
9274
9275 2019-03-05  Tom Tromey  <tromey@adacore.com>
9276
9277         * macroexp.c (struct macro_buffer) <release>: Add
9278         ATTRIBUTE_UNUSED_RESULT.
9279
9280 2019-03-05  Tom Tromey  <tromey@adacore.com>
9281
9282         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9283         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9284         ATTRIBUTE_UNUSED_RESULT.
9285
9286 2019-03-05  Tom Tromey  <tromey@adacore.com>
9287
9288         * common/scoped_fd.h (class scoped_fd) <release>: Add
9289         ATTRIBUTE_UNUSED_RESULT.
9290
9291 2019-03-05  Tom Tromey  <tromey@adacore.com>
9292
9293         * parser-defs.h (struct parser_state) <release>: Add
9294         ATTRIBUTE_UNUSED_RESULT.
9295
9296 2019-03-05  Tom Tromey  <tromey@adacore.com>
9297
9298         * utils.h (class gdb_argv) <release>: Add
9299         ATTRIBUTE_UNUSED_RESULT.
9300         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9301
9302 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9303
9304         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9305         for-loop range, to avoid compiler warnings.
9306
9307         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9308         avoid compiler warnings about unused variables.
9309
9310         * NEWS: Mention end of support for native debugging on MS-Windows
9311         before XP.
9312
9313         PR gdb/24292
9314         * common/netstuff.c:
9315         * gdbserver/gdbreplay.c
9316         * gdbserver/remote-utils.c:
9317         * ser-tcp.c:
9318         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9319         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9320         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9321         'getaddrinfo' and 'freeaddrinfo' were not available before
9322         Windows XP, and mingw.org's MinGW headers by default define
9323         _WIN32_WINNT to 0x500.
9324
9325 2019-03-01  Gary Benson <gbenson@redhat.com>
9326
9327         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9328
9329 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9330             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9331
9332         PR gdb/8527
9333         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9334         set_sigint_trap, clear_sigint_trap.
9335
9336 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9337
9338         * target.c (target_detach): Clear the regcache and the
9339         frame cache.
9340
9341 2019-02-27  Pedro Alves  <palves@redhat.com>
9342
9343         * utils.c (set_screen_size): When we cap the height/width sizes,
9344         tweak the corresponding command variable to show "unlimited":
9345
9346 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9347             Pedro Alves  <palves@redhat.com>
9348
9349         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9350         before calling rl_set_screen_size.
9351
9352 2019-02-27  Tom Tromey  <tromey@adacore.com>
9353
9354         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9355         define.
9356         * python/py-value.c: Remove Python 2.4 workaround.
9357         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9358         workaround.
9359         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9360         Python 2.4 workaround.
9361         * python/python-internal.h: Remove Python 2.4 comment.
9362         (Py_ssize_t): Don't define.
9363         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9364         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9365         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9366         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9367         * python/python.c (do_start_initialization): Remove Python 2.4
9368         workaround.
9369         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9370         (print_children): Remove Python 2.4 workaround.
9371         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9372         workaround.
9373         (CHARBUFFERPROC_NAME): Remove.
9374         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9375         Python 2.4 workaround.
9376
9377 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9378
9379         * NEWS: Note minimum Python version.
9380
9381 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9382
9383         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9384         code from these functions.  Remove corresponding ifdefs.  Use
9385         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9386         Remove gotos and target of gotos.
9387         (infpy_search_memory): Likewise.
9388
9389 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9390
9391         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9392         (hppa_gdbarch_init): Don't register deleted functions with
9393         gdbarch.
9394
9395 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9396
9397         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9398         (h8300_unwind_sp): Delete.
9399         (h8300_dummy_id): Delete.
9400         (h8300_gdbarch_init): Don't register deleted functions with
9401         gdbarch.
9402
9403 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9404
9405         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9406         (ft32_unwind_pc): Delete.
9407         (ft32_unwind_sp): Delete.
9408         (ft32_gdbarch_init): Don't register deleted functions with
9409         gdbarch.
9410
9411 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9412
9413         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9414         (frv_unwind_pc): Delete.
9415         (frv_unwind_sp): Delete.
9416         (frv_gdbarch_init): Don't register deleted functions with
9417         gdbarch.
9418
9419 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9420
9421         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9422         (riscv_unwind_pc): Delete.
9423         (riscv_unwind_sp): Delete.
9424         (riscv_gdbarch_init): Don't register deleted functions with
9425         gdbarch.
9426
9427 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9430         (csky_unwind_pc): Delete.
9431         (csky_unwind_sp): Delete.
9432         (csky_gdbarch_init): Don't register deleted functions with
9433         gdbarch.
9434
9435 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9436
9437         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9438         (cris_unwind_pc): Delete.
9439         (cris_unwind_sp): Delete.
9440         (cris_gdbarch_init): Don't register deleted functions with
9441         gdbarch.
9442
9443 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9444
9445         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9446         (bfin_unwind_pc): Delete.
9447         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9448
9449 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9450
9451         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9452         (arm_unwind_pc): Delete.
9453         (arm_unwind_sp): Delete.
9454         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9455
9456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9457
9458         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9459         (arc_unwind_pc): Delete.
9460         (arc_unwind_sp): Delete.
9461         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9462
9463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9464
9465         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9466         (alpha_unwind_pc): Delete.
9467         (alpha_gdbarch_init): Don't register deleted functions with
9468         gdbarch.
9469
9470 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9471
9472         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9473         (aarch64_unwind_pc): Delete.
9474         (aarch64_unwind_sp): Delete.
9475         (aarch64_gdbarch_init): Don't register deleted functions with
9476         gdbarch.
9477
9478 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9479
9480         * gdbtypes.c (type_align): Don't consider static members when
9481         computing structure alignment.
9482
9483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9484
9485         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9486         return 0 for other types.
9487         * arch-utils.c (default_type_align): Always return 0.
9488         * gdbarch.h: Regenerate.
9489         * gdbarch.sh (type_align): Extend comment.
9490         * gdbtypes.c (type_align): Add additional comments, always call
9491         gdbarch_type_align before applying the default rules.
9492         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9493         generic code will then apply a suitable default.
9494         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9495         types, return 0 for other types.
9496
9497 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9498
9499         * NEWS: Create a new section for the next release branch.
9500         Rename the section of the current branch, now that it has
9501         been cut.
9502
9503 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9504
9505         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9506         * version.in: Bump version to 8.3.50.DATE-git.
9507
9508 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9509
9510         * aix-thread.c (ptid_cmp): Remove unused variable.
9511         (get_signaled_thread): Likewise.
9512         (store_regs_user_thread): Likewise.
9513         (store_regs_kernel_thread): Likewise.
9514         (fetch_regs_kernel_thread): Remove shadowed variable.
9515
9516 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9517
9518         * features/riscv/32bit-cpu.xml: Add register numbers.
9519         * features/riscv/32bit-fpu.c: Regenerate.
9520         * features/riscv/32bit-fpu.xml: Add register numbers.
9521         * features/riscv/64bit-cpu.xml: Add register numbers.
9522         * features/riscv/64bit-fpu.c: Regenerate.
9523         * features/riscv/64bit-fpu.xml: Add register numbers.
9524
9525 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9526
9527         * NEWS: Mention two argument form of gdb.Value constructor.
9528         * python/py-value.c (convert_buffer_and_type_to_value): New
9529         function.
9530         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9531         Add support for handling an optional second argument.  Call
9532         convert_buffer_and_type_to_value as appropriate.
9533         * python/python-internal.h (Py_buffer_deleter): New struct.
9534         (Py_buffer_up): New typedef.
9535
9536 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9537
9538         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9539         instead of releasing ownership.
9540
9541 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9542
9543         * dwarf2read.c (open_and_init_dwp_file): Call
9544         elf_numsections instead of bfd_count_sections to initialize
9545         dwp_file->num_sections.
9546
9547 2019-02-25  Tom Tromey  <tromey@adacore.com>
9548
9549         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9550
9551 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9552
9553         * gcore.in: Add '--readnever' option when invoking GDB.
9554
9555 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9556
9557         * MAINTAINERS: Update my email address.
9558
9559 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9560
9561         * build-id.c (build_id_to_debug_bfd_1): New function.
9562         (build_id_to_debug_bfd): Look for separate debug file in
9563         sysroot.
9564
9565 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9566
9567         * gdbarch.sh: Update the copyright year range that is placed into
9568         generated files.
9569
9570 2019-02-22  Keith Seitz  <keiths@redhat.com>
9571
9572         PR symtab/23853
9573         * linespec.c (create_sals_line_offset): Search for the default
9574         symtab's filename instead of its fullname.
9575
9576 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9577
9578         * NEWS: Update style defaults.
9579
9580 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9581
9582         * main.c (captured_main_1): Disable styling in batch mode.
9583
9584 2019-02-20  Tom Tromey  <tom@tromey.com>
9585
9586         * symtab.c (symtab_symbol_info): Fix typos.
9587
9588 2019-02-20  Tom Tromey  <tromey@adacore.com>
9589
9590         * findcmd.c (_initialize_mem_search): Use upper case for
9591         metasyntactic variables.
9592
9593 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9594
9595         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9596         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9597
9598 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9599
9600         * top.h (source_file_name): Change to std::string.
9601         * top.c (source_file_name): Likewise.
9602         (command_line_input): Adjust.
9603         * cli/cli-script.c (script_from_file): Adjust.
9604
9605 2019-02-19  Tom Tromey  <tromey@adacore.com>
9606
9607         * ravenscar-thread.c
9608         (ravenscar_thread_target::update_thread_list): Don't call
9609         ada_build_task_list.
9610         * ada-lang.h (ada_build_task_list): Don't declare.
9611         * ada-tasks.c (struct ada_tasks_inferior_data)
9612         <task_list_valid_p>: Now bool.
9613         (read_known_tasks, ada_task_list_changed)
9614         (ada_tasks_invalidate_inferior_data): Update.
9615         (read_known_tasks_array): Return bool.
9616         (read_known_tasks_list): Likewise.
9617         (read_known_tasks): Return void.
9618         (ada_build_task_list): Now static.
9619
9620 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9621
9622         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9623         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9624
9625 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9626
9627         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9628         variant for ada_tasks_pspace_data_handle and
9629         ada_tasks_inferior_data_handle.
9630         (ada_tasks_pspace_data_cleanup): New function.
9631         (ada_tasks_inferior_data_cleanup): New function.
9632
9633 2019-02-17  Tom Tromey  <tom@tromey.com>
9634
9635         * macrotab.h (macro_source_fullname): Return a std::string.
9636         * macrotab.c (macro_include, check_for_redefinition)
9637         (macro_undef, macro_lookup_definition, foreach_macro)
9638         (foreach_macro_in_scope): Update.
9639         (macro_source_fullname): Return a std::string.
9640         * macrocmd.c (show_pp_source_pos): Update.
9641
9642 2019-02-17  Tom Tromey  <tom@tromey.com>
9643
9644         * macrocmd.c (show_pp_source_pos): Style the file names.
9645
9646 2019-02-17  Tom Tromey  <tom@tromey.com>
9647
9648         PR tui/24197:
9649         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9650
9651 2019-02-17  Tom Tromey  <tom@tromey.com>
9652
9653         * ada-lang.c (user_select_syms): Use filtered printing.
9654         * utils.c (wrap_style): New global.
9655         (desired_style): Remove.
9656         (emit_style_escape): Add stream parameter.
9657         (set_output_style, reset_terminal_style, prompt_for_continue):
9658         Update.
9659         (flush_wrap_buffer): Only flush gdb_stdout.
9660         (wrap_here): Set wrap_style.
9661         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9662         treat escape sequences as a character.  Change when wrap buffer is
9663         flushed.
9664         (fputs_styled): Do not set the output style when the default is
9665         requested.
9666         * ui-style.h (struct ui_file_style) <is_default>: New method.
9667         * source.c (print_source_lines_base): Emit escape sequences in one
9668         piece.
9669
9670 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9671
9672         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9673         integers and enumeration types.
9674
9675 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9676
9677         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9678         instead of lookup_symbol_in_language
9679         (do_exact_match): New function.
9680         (ada_get_symbol_name_matcher): Return do_exact_match when
9681         doing a verbatim match.
9682
9683 2019-02-15  Tom Tromey  <tromey@adacore.com>
9684
9685         * ravenscar-thread.c (ravenscar_thread_target::resume)
9686         (ravenscar_thread_target::wait): Special case wildcard requests.
9687
9688 2019-02-15  Tom Tromey  <tromey@adacore.com>
9689
9690         * ravenscar-thread.c (base_ptid): Remove.
9691         (struct ravenscar_thread_target) <close>: New method.
9692         <m_base_ptid>: New member.
9693         <update_inferior_ptid, active_task, task_is_currently_active,
9694         runtime_initialized>: Declare methods.
9695         <ravenscar_thread_target>: Add constructor.
9696         (ravenscar_thread_target::task_is_currently_active)
9697         (ravenscar_thread_target::update_inferior_ptid)
9698         (ravenscar_runtime_initialized): Rename.  Now methods.
9699         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9700         (ravenscar_thread_target::update_thread_list): Update.
9701         (ravenscar_thread_target::active_task): Now method.
9702         (ravenscar_thread_target::store_registers)
9703         (ravenscar_thread_target::prepare_to_store)
9704         (ravenscar_thread_target::prepare_to_store)
9705         (ravenscar_thread_target::mourn_inferior): Update.
9706         (ravenscar_inferior_created): Use "new" to create target.
9707         (ravenscar_thread_target::get_ada_task_ptid): Update.
9708         (_initialize_ravenscar): Don't initialize base_ptid.
9709         (ravenscar_ops): Remove global.
9710
9711 2019-02-15  Tom Tromey  <tromey@adacore.com>
9712
9713         * target.h (push_target): Declare new overload.
9714         * target.c (push_target): New overload, taking an rvalue reference.
9715         * remote.c (remote_target::open_1): Use push_target overload.
9716         * corelow.c (core_target_open): Use push_target overload.
9717
9718 2019-02-15  Tom Tromey  <tromey@adacore.com>
9719
9720         * ravenscar-thread.c (is_ravenscar_task)
9721         (ravenscar_task_is_currently_active): Return bool.
9722         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9723         (_initialize_ravenscar): Remove "(void)".
9724         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9725         Return bool.
9726
9727 2019-02-15  Tom Tromey  <tromey@adacore.com>
9728
9729         * ravenscar-thread.c (ravenscar_runtime_initializer)
9730         (has_ravenscar_runtime, get_running_thread_id)
9731         (ravenscar_thread_target::resume): Fix indentation.
9732
9733 2019-02-15  Tom Tromey  <tromey@adacore.com>
9734
9735         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9736         from ravenscar_arch_ops.
9737         (sparc_ravenscar_ops::fetch_registers)
9738         (sparc_ravenscar_ops::store_registers): Now methods.
9739         (sparc_ravenscar_prepare_to_store): Remove.
9740         (sparc_ravenscar_ops): Redefine.
9741         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9742         methods and destructor.  Remove members.
9743         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9744         (ravenscar_thread_target::store_registers)
9745         (ravenscar_thread_target::prepare_to_store): Update.
9746         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9747         Remove.
9748         (struct ppc_ravenscar_powerpc_ops): Derive from
9749         ravenscar_arch_ops.
9750         (ppc_ravenscar_powerpc_ops::fetch_registers)
9751         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9752         (ppc_ravenscar_powerpc_ops): Redefine.
9753         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9754         (ppc_ravenscar_e500_ops::fetch_registers)
9755         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9756         (ppc_ravenscar_e500_ops): Redefine.
9757         * aarch64-ravenscar-thread.c
9758         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9759         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9760         (aarch64_ravenscar_fetch_registers)
9761         (aarch64_ravenscar_store_registers): Now methods.
9762         (aarch64_ravenscar_ops): Redefine.
9763
9764 2019-02-15  Tom Tromey  <tromey@adacore.com>
9765
9766         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9767         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9768         (ravenscar_thread_target::stopped_by_watchpoint)
9769         (ravenscar_thread_target::stopped_data_address)
9770         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9771
9772 2019-02-15  Tom Tromey  <tromey@adacore.com>
9773
9774         * ravenscar-thread.c: Fix some typos.
9775
9776 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9777             Tom Tromey  <tromey@adacore.com>
9778
9779         * ada-lang.c (ada_exception_sal): Change addr_string to a
9780         std::string.
9781         (create_ada_exception_catchpoint): Update.
9782
9783 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9784             Tom Tromey  <tromey@adacore.com>
9785
9786         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9787         (bp_location_ops): Remove.
9788         (base_breakpoint_allocate_location): Update.
9789         (free_bp_location): Update.
9790         * ada-lang.c (class ada_catchpoint_location)
9791         <ada_catchpoint_location>: Remove ops parameter.
9792         (ada_catchpoint_location_dtor): Remove.
9793         (ada_catchpoint_location_ops): Remove.
9794         (allocate_location_exception): Update.
9795         * breakpoint.h (struct bp_location_ops): Remove.
9796         (class bp_location) <bp_location>: Remove bp_location_ops
9797         parameter.
9798         <~bp_location>: Add destructor.
9799         <ops>: Remove.
9800
9801 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9802             Pedro Alves  <palves@redhat.com>
9803
9804         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9805         'PATH_MAX'.
9806
9807 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9808             Samuel Thibault  <samuel.thibault@gnu.org>
9809             Thomas Schwinge  <thomas@codesourcery.com>
9810
9811         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9812         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9813
9814 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9815
9816         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9817         (check_empty): Use "const char *".
9818
9819         * gnu-nat.c (gnu_nat_target::detach): Instead of
9820         'detach_inferior (pid)' call
9821         'detach_inferior (find_inferior_pid (pid))'.
9822
9823         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9824         'nat/fork-inferior.o'.
9825         * gnu-nat.c: #include "nat/fork-inferior.h".
9826
9827         * gnu-nat.c (gnu_nat_target::detach): Instead of
9828         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9829         * gnu-nat.h: #include "inf-child.h".
9830         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9831         'i386_gnu_nat_target::fetch_registers'.
9832         (gnu_store_registers): Rename/move to
9833         'i386_gnu_nat_target::store_registers'.
9834
9835         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9836         * gnu-nat.h (mach_thread_info): New function.
9837         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9838
9839         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9840
9841 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9842
9843         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9844
9845 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9846
9847         * windows-nat.c (windows_add_thread): Add new parameter
9848         "main_thread_p" with default value set to false.  Update
9849         function documentation as well as all callers.
9850         (windows_delete_thread): Likewise.
9851         (fake_create_process): Update call to windows_add_thread.
9852         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9853         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9854         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9855         call to windows_delete_thread.
9856
9857 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9858
9859         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9860
9861 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9862
9863         * symfile.c (find_separate_debug_file): Use canonical path of
9864         sysroot with child_path instead of gdb_sysroot if it is valid.
9865
9866 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9867
9868         * symfile.c (find_separate_debug_file): Use child_path to
9869         determine if an object file is under a sysroot.
9870
9871 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9872
9873         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9874         unittests/child-path-selftests.c.
9875         * common/pathstuff.c (child_path): New function.
9876         * common/pathstuff.h (child_path): New prototype.
9877         * unittests/child-path-selftests.c: New file.
9878
9879 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9880
9881         * symfile.c (find_separate_debug_file): Look for separate debug
9882         files in debug directories under the sysroot.
9883
9884 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9885
9886         * symtab.h (struct minimal_symbol data_p): New const method.
9887         (struct minimal_symbol text_p): Likewise.
9888         * symtab.c (output_source_filename): Use file name style
9889         to print file name.
9890         (print_symbol_info): Likewise.
9891         (print_msymbol_info): Use address style to print addresses.
9892         Use function name style to print executable text symbols.
9893         (expand_symtab_containing_pc): Use data_p.
9894         (find_pc_sect_compunit_symtab): Likewise.
9895
9896 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9897
9898         * breakpoint.c (describe_other_breakpoints): Use address style
9899         to print addresses.
9900         (say_where): Likewise.
9901
9902 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9903
9904         * ada-typeprint.c (print_func_type): Print function name
9905         style to print function name.
9906         * c-typeprint.c (c_print_type_1): Likewise.
9907
9908 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9909
9910         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9911         for execve.
9912
9913 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9914
9915         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9916         type_stack.
9917
9918 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9919
9920         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9921         TYPE_CODE_REF types.
9922
9923 2019-02-08  Jim Wilson  <jimw@sifive.com>
9924
9925         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9926         (riscv_linux_fregset): New.
9927         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9928
9929 2019-02-07  Tom Tromey  <tom@tromey.com>
9930
9931         * thread.c (thread_cancel_execution_command): Update.
9932         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9933         methods.
9934         (struct thread_fsm_ops): Remove.
9935         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9936         (thread_fsm_should_stop, thread_fsm_return_value)
9937         (thread_fsm_set_finished, thread_fsm_finished_p)
9938         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9939         Don't declare.
9940         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9941         * infrun.c (clear_proceed_status_thread)
9942         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9943         (print_stop_event): Update.
9944         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9945         Add constructor.
9946         (step_command_fsm_ops): Remove.
9947         (new_step_command_fsm): Remove.
9948         (step_1): Update.
9949         (step_command_fsm::should_stop): Rename from
9950         step_command_fsm_should_stop.
9951         (step_command_fsm::clean_up): Rename from
9952         step_command_fsm_clean_up.
9953         (step_command_fsm::do_async_reply_reason): Rename from
9954         step_command_fsm_async_reply_reason.
9955         (struct until_next_fsm): Inherit from thread_fsm.  Add
9956         constructor.
9957         (until_next_fsm_ops): Remove.
9958         (new_until_next_fsm): Remove.
9959         (until_next_fsm::should_stop): Rename from
9960         until_next_fsm_should_stop.
9961         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9962         (until_next_fsm::do_async_reply_reason): Rename from
9963         until_next_fsm_async_reply_reason.
9964         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9965         constructor.  Change type of breakpoint.
9966         (finish_command_fsm_ops): Remove.
9967         (new_finish_command_fsm): Remove.
9968         (finish_command_fsm::should_stop): Rename from
9969         finish_command_fsm_should_stop.
9970         (finish_command_fsm::clean_up): Rename from
9971         finish_command_fsm_clean_up.
9972         (finish_command_fsm::return_value): Rename from
9973         finish_command_fsm_return_value.
9974         (finish_command_fsm::do_async_reply_reason): Rename from
9975         finish_command_fsm_async_reply_reason.
9976         (finish_command): Update.
9977         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9978         Add constructor.
9979         (call_thread_fsm_ops): Remove.
9980         (call_thread_fsm::call_thread_fsm): Rename from
9981         new_call_thread_fsm.
9982         (call_thread_fsm::should_stop): Rename from
9983         call_thread_fsm_should_stop.
9984         (call_thread_fsm::should_notify_stop): Rename from
9985         call_thread_fsm_should_notify_stop.
9986         (run_inferior_call, call_function_by_hand_dummy): Update.
9987         * cli/cli-interp.c (should_print_stop_to_console): Update.
9988         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9989         Add constructor.  Change type of location_breakpoint,
9990         caller_breakpoint.
9991         (until_break_fsm_ops): Remove.
9992         (new_until_break_fsm): Remove.
9993         (until_break_fsm::should_stop): Rename from
9994         until_break_fsm_should_stop.
9995         (until_break_fsm::clean_up): Rename from
9996         until_break_fsm_clean_up.
9997         (until_break_fsm::do_async_reply_reason): Rename from
9998         until_break_fsm_async_reply_reason.
9999         (until_break_command): Update.
10000         * thread-fsm.c: Remove.
10001         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10002
10003 2019-02-07  Tom Tromey  <tom@tromey.com>
10004
10005         * yy-remap.h: Add include guard.
10006         * xtensa-tdep.h: Add include guard.
10007         * xcoffread.h: Rename include guard.
10008         * varobj-iter.h: Add include guard.
10009         * tui/tui.h: Rename include guard.
10010         * tui/tui-winsource.h: Rename include guard.
10011         * tui/tui-wingeneral.h: Rename include guard.
10012         * tui/tui-windata.h: Rename include guard.
10013         * tui/tui-win.h: Rename include guard.
10014         * tui/tui-stack.h: Rename include guard.
10015         * tui/tui-source.h: Rename include guard.
10016         * tui/tui-regs.h: Rename include guard.
10017         * tui/tui-out.h: Rename include guard.
10018         * tui/tui-layout.h: Rename include guard.
10019         * tui/tui-io.h: Rename include guard.
10020         * tui/tui-hooks.h: Rename include guard.
10021         * tui/tui-file.h: Rename include guard.
10022         * tui/tui-disasm.h: Rename include guard.
10023         * tui/tui-data.h: Rename include guard.
10024         * tui/tui-command.h: Rename include guard.
10025         * tic6x-tdep.h: Add include guard.
10026         * target/waitstatus.h: Rename include guard.
10027         * target/wait.h: Rename include guard.
10028         * target/target.h: Rename include guard.
10029         * target/resume.h: Rename include guard.
10030         * target-float.h: Rename include guard.
10031         * stabsread.h: Add include guard.
10032         * rs6000-tdep.h: Add include guard.
10033         * riscv-fbsd-tdep.h: Add include guard.
10034         * regformats/regdef.h: Rename include guard.
10035         * record.h: Rename include guard.
10036         * python/python.h: Rename include guard.
10037         * python/python-internal.h: Rename include guard.
10038         * python/py-stopevent.h: Rename include guard.
10039         * python/py-ref.h: Rename include guard.
10040         * python/py-record.h: Rename include guard.
10041         * python/py-record-full.h: Rename include guard.
10042         * python/py-record-btrace.h: Rename include guard.
10043         * python/py-instruction.h: Rename include guard.
10044         * python/py-events.h: Rename include guard.
10045         * python/py-event.h: Rename include guard.
10046         * procfs.h: Add include guard.
10047         * proc-utils.h: Add include guard.
10048         * p-lang.h: Add include guard.
10049         * or1k-tdep.h: Rename include guard.
10050         * observable.h: Rename include guard.
10051         * nto-tdep.h: Rename include guard.
10052         * nat/x86-linux.h: Rename include guard.
10053         * nat/x86-linux-dregs.h: Rename include guard.
10054         * nat/x86-gcc-cpuid.h: Add include guard.
10055         * nat/x86-dregs.h: Rename include guard.
10056         * nat/x86-cpuid.h: Rename include guard.
10057         * nat/ppc-linux.h: Rename include guard.
10058         * nat/mips-linux-watch.h: Rename include guard.
10059         * nat/linux-waitpid.h: Rename include guard.
10060         * nat/linux-ptrace.h: Rename include guard.
10061         * nat/linux-procfs.h: Rename include guard.
10062         * nat/linux-osdata.h: Rename include guard.
10063         * nat/linux-nat.h: Rename include guard.
10064         * nat/linux-namespaces.h: Rename include guard.
10065         * nat/linux-btrace.h: Rename include guard.
10066         * nat/glibc_thread_db.h: Rename include guard.
10067         * nat/gdb_thread_db.h: Rename include guard.
10068         * nat/gdb_ptrace.h: Rename include guard.
10069         * nat/fork-inferior.h: Rename include guard.
10070         * nat/amd64-linux-siginfo.h: Rename include guard.
10071         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10072         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10073         * nat/aarch64-linux.h: Rename include guard.
10074         * nat/aarch64-linux-hw-point.h: Rename include guard.
10075         * mn10300-tdep.h: Add include guard.
10076         * mips-linux-tdep.h: Add include guard.
10077         * mi/mi-parse.h: Rename include guard.
10078         * mi/mi-out.h: Rename include guard.
10079         * mi/mi-main.h: Rename include guard.
10080         * mi/mi-interp.h: Rename include guard.
10081         * mi/mi-getopt.h: Rename include guard.
10082         * mi/mi-console.h: Rename include guard.
10083         * mi/mi-common.h: Rename include guard.
10084         * mi/mi-cmds.h: Rename include guard.
10085         * mi/mi-cmd-break.h: Rename include guard.
10086         * m2-lang.h: Add include guard.
10087         * location.h: Rename include guard.
10088         * linux-record.h: Rename include guard.
10089         * linux-nat.h: Add include guard.
10090         * linux-fork.h: Add include guard.
10091         * i386-darwin-tdep.h: Rename include guard.
10092         * hppa-linux-offsets.h: Add include guard.
10093         * guile/guile.h: Rename include guard.
10094         * guile/guile-internal.h: Rename include guard.
10095         * gnu-nat.h: Rename include guard.
10096         * gdb-stabs.h: Rename include guard.
10097         * frv-tdep.h: Add include guard.
10098         * f-lang.h: Add include guard.
10099         * event-loop.h: Add include guard.
10100         * darwin-nat.h: Rename include guard.
10101         * cp-abi.h: Rename include guard.
10102         * config/sparc/nm-sol2.h: Rename include guard.
10103         * config/nm-nto.h: Rename include guard.
10104         * config/nm-linux.h: Add include guard.
10105         * config/i386/nm-i386gnu.h: Rename include guard.
10106         * config/djgpp/nl_types.h: Rename include guard.
10107         * config/djgpp/langinfo.h: Rename include guard.
10108         * compile/gcc-cp-plugin.h: Add include guard.
10109         * compile/gcc-c-plugin.h: Add include guard.
10110         * compile/compile.h: Rename include guard.
10111         * compile/compile-object-run.h: Rename include guard.
10112         * compile/compile-object-load.h: Rename include guard.
10113         * compile/compile-internal.h: Rename include guard.
10114         * compile/compile-cplus.h: Rename include guard.
10115         * compile/compile-c.h: Rename include guard.
10116         * common/xml-utils.h: Rename include guard.
10117         * common/x86-xstate.h: Rename include guard.
10118         * common/version.h: Rename include guard.
10119         * common/vec.h: Rename include guard.
10120         * common/tdesc.h: Rename include guard.
10121         * common/selftest.h: Rename include guard.
10122         * common/scoped_restore.h: Rename include guard.
10123         * common/scoped_mmap.h: Rename include guard.
10124         * common/scoped_fd.h: Rename include guard.
10125         * common/safe-iterator.h: Rename include guard.
10126         * common/run-time-clock.h: Rename include guard.
10127         * common/refcounted-object.h: Rename include guard.
10128         * common/queue.h: Rename include guard.
10129         * common/ptid.h: Rename include guard.
10130         * common/print-utils.h: Rename include guard.
10131         * common/preprocessor.h: Rename include guard.
10132         * common/pathstuff.h: Rename include guard.
10133         * common/observable.h: Rename include guard.
10134         * common/netstuff.h: Rename include guard.
10135         * common/job-control.h: Rename include guard.
10136         * common/host-defs.h: Rename include guard.
10137         * common/gdb_wait.h: Rename include guard.
10138         * common/gdb_vecs.h: Rename include guard.
10139         * common/gdb_unlinker.h: Rename include guard.
10140         * common/gdb_unique_ptr.h: Rename include guard.
10141         * common/gdb_tilde_expand.h: Rename include guard.
10142         * common/gdb_sys_time.h: Rename include guard.
10143         * common/gdb_string_view.h: Rename include guard.
10144         * common/gdb_splay_tree.h: Rename include guard.
10145         * common/gdb_setjmp.h: Rename include guard.
10146         * common/gdb_ref_ptr.h: Rename include guard.
10147         * common/gdb_optional.h: Rename include guard.
10148         * common/gdb_locale.h: Rename include guard.
10149         * common/gdb_assert.h: Rename include guard.
10150         * common/filtered-iterator.h: Rename include guard.
10151         * common/filestuff.h: Rename include guard.
10152         * common/fileio.h: Rename include guard.
10153         * common/environ.h: Rename include guard.
10154         * common/common-utils.h: Rename include guard.
10155         * common/common-types.h: Rename include guard.
10156         * common/common-regcache.h: Rename include guard.
10157         * common/common-inferior.h: Rename include guard.
10158         * common/common-gdbthread.h: Rename include guard.
10159         * common/common-exceptions.h: Rename include guard.
10160         * common/common-defs.h: Rename include guard.
10161         * common/common-debug.h: Rename include guard.
10162         * common/cleanups.h: Rename include guard.
10163         * common/buffer.h: Rename include guard.
10164         * common/btrace-common.h: Rename include guard.
10165         * common/break-common.h: Rename include guard.
10166         * cli/cli-utils.h: Rename include guard.
10167         * cli/cli-style.h: Rename include guard.
10168         * cli/cli-setshow.h: Rename include guard.
10169         * cli/cli-script.h: Rename include guard.
10170         * cli/cli-interp.h: Rename include guard.
10171         * cli/cli-decode.h: Rename include guard.
10172         * cli/cli-cmds.h: Rename include guard.
10173         * charset-list.h: Add include guard.
10174         * buildsym-legacy.h: Rename include guard.
10175         * bfin-tdep.h: Add include guard.
10176         * ax.h: Rename include guard.
10177         * arm-linux-tdep.h: Add include guard.
10178         * arm-fbsd-tdep.h: Add include guard.
10179         * arch/xtensa.h: Rename include guard.
10180         * arch/tic6x.h: Add include guard.
10181         * arch/i386.h: Add include guard.
10182         * arch/arm.h: Rename include guard.
10183         * arch/arm-linux.h: Rename include guard.
10184         * arch/arm-get-next-pcs.h: Rename include guard.
10185         * arch/amd64.h: Add include guard.
10186         * arch/aarch64-insn.h: Rename include guard.
10187         * arch-utils.h: Rename include guard.
10188         * annotate.h: Add include guard.
10189         * amd64-darwin-tdep.h: Rename include guard.
10190         * aarch64-linux-tdep.h: Add include guard.
10191         * aarch64-fbsd-tdep.h: Add include guard.
10192         * aarch32-linux-nat.h: Add include guard.
10193
10194 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10195
10196         * macrotab.c (macro_define_internal): New function that
10197         factorizes macro_define_object_internal and macro_define_function
10198         code.
10199         (macro_define_object_internal): Use macro_define_internal.
10200         (macro_define_function): Likewise.
10201
10202 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10203
10204         * macrocmd.c (extract_identifier): Return
10205         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10206         callers.
10207
10208 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10209
10210         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10211
10212 2019-02-05  Tom Tromey  <tom@tromey.com>
10213
10214         * target.c (target_stack::unpush): Move assertion earlier.
10215
10216 2019-01-30  Tom Tromey  <tom@tromey.com>
10217
10218         PR python/23615:
10219         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10220         (gdbpy_parse_and_eval): Likewise.
10221         * python/python-internal.h (gdbpy_allow_threads): New class.
10222
10223 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10224
10225         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10226         (aarch64_fbsd_fpregmap): Move earlier.
10227         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10228         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10229         instead of individual calls to trad_frame_set_reg_addr.
10230         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10231         earlier.
10232         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10233         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10234         instead of individual calls to trad_frame_set_reg_addr.
10235
10236 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10237
10238         * CONTRIBUTE: Replace contribution list with wiki link.
10239
10240 2019-01-25  Tom Tromey  <tom@tromey.com>
10241
10242         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10243
10244 2019-01-25  Tom Tromey  <tom@tromey.com>
10245
10246         * xtensa-linux-nat.c: Fix common/ includes.
10247         * xml-support.h: Fix common/ includes.
10248         * xml-support.c: Fix common/ includes.
10249         * x86-linux-nat.c: Fix common/ includes.
10250         * windows-nat.c: Fix common/ includes.
10251         * varobj.h: Fix common/ includes.
10252         * varobj.c: Fix common/ includes.
10253         * value.c: Fix common/ includes.
10254         * valops.c: Fix common/ includes.
10255         * utils.c: Fix common/ includes.
10256         * unittests/xml-utils-selftests.c: Fix common/ includes.
10257         * unittests/utils-selftests.c: Fix common/ includes.
10258         * unittests/unpack-selftests.c: Fix common/ includes.
10259         * unittests/tracepoint-selftests.c: Fix common/ includes.
10260         * unittests/style-selftests.c: Fix common/ includes.
10261         * unittests/string_view-selftests.c: Fix common/ includes.
10262         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10263         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10264         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10265         * unittests/rsp-low-selftests.c: Fix common/ includes.
10266         * unittests/parse-connection-spec-selftests.c: Fix common/
10267         includes.
10268         * unittests/optional-selftests.c: Fix common/ includes.
10269         * unittests/offset-type-selftests.c: Fix common/ includes.
10270         * unittests/observable-selftests.c: Fix common/ includes.
10271         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10272         * unittests/memrange-selftests.c: Fix common/ includes.
10273         * unittests/memory-map-selftests.c: Fix common/ includes.
10274         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10275         * unittests/function-view-selftests.c: Fix common/ includes.
10276         * unittests/environ-selftests.c: Fix common/ includes.
10277         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10278         * unittests/common-utils-selftests.c: Fix common/ includes.
10279         * unittests/cli-utils-selftests.c: Fix common/ includes.
10280         * unittests/array-view-selftests.c: Fix common/ includes.
10281         * ui-file.c: Fix common/ includes.
10282         * tui/tui-io.c: Fix common/ includes.
10283         * tracepoint.h: Fix common/ includes.
10284         * tracepoint.c: Fix common/ includes.
10285         * tracefile-tfile.c: Fix common/ includes.
10286         * top.h: Fix common/ includes.
10287         * top.c: Fix common/ includes.
10288         * thread.c: Fix common/ includes.
10289         * target/waitstatus.h: Fix common/ includes.
10290         * target/waitstatus.c: Fix common/ includes.
10291         * target.h: Fix common/ includes.
10292         * target.c: Fix common/ includes.
10293         * target-memory.c: Fix common/ includes.
10294         * target-descriptions.c: Fix common/ includes.
10295         * symtab.h: Fix common/ includes.
10296         * symfile.c: Fix common/ includes.
10297         * stap-probe.c: Fix common/ includes.
10298         * spu-linux-nat.c: Fix common/ includes.
10299         * sparc-nat.c: Fix common/ includes.
10300         * source.c: Fix common/ includes.
10301         * solib.c: Fix common/ includes.
10302         * solib-target.c: Fix common/ includes.
10303         * ser-unix.c: Fix common/ includes.
10304         * ser-tcp.c: Fix common/ includes.
10305         * ser-pipe.c: Fix common/ includes.
10306         * ser-base.c: Fix common/ includes.
10307         * selftest-arch.c: Fix common/ includes.
10308         * s12z-tdep.c: Fix common/ includes.
10309         * rust-exp.y: Fix common/ includes.
10310         * rs6000-aix-tdep.c: Fix common/ includes.
10311         * riscv-tdep.c: Fix common/ includes.
10312         * remote.c: Fix common/ includes.
10313         * remote-notif.h: Fix common/ includes.
10314         * remote-fileio.h: Fix common/ includes.
10315         * remote-fileio.c: Fix common/ includes.
10316         * regcache.h: Fix common/ includes.
10317         * regcache.c: Fix common/ includes.
10318         * record-btrace.c: Fix common/ includes.
10319         * python/python.c: Fix common/ includes.
10320         * python/py-type.c: Fix common/ includes.
10321         * python/py-inferior.c: Fix common/ includes.
10322         * progspace.h: Fix common/ includes.
10323         * producer.c: Fix common/ includes.
10324         * procfs.c: Fix common/ includes.
10325         * proc-api.c: Fix common/ includes.
10326         * printcmd.c: Fix common/ includes.
10327         * ppc-linux-nat.c: Fix common/ includes.
10328         * parser-defs.h: Fix common/ includes.
10329         * osdata.c: Fix common/ includes.
10330         * obsd-nat.c: Fix common/ includes.
10331         * nat/x86-linux.c: Fix common/ includes.
10332         * nat/x86-linux-dregs.c: Fix common/ includes.
10333         * nat/x86-dregs.h: Fix common/ includes.
10334         * nat/x86-dregs.c: Fix common/ includes.
10335         * nat/ppc-linux.c: Fix common/ includes.
10336         * nat/mips-linux-watch.h: Fix common/ includes.
10337         * nat/mips-linux-watch.c: Fix common/ includes.
10338         * nat/linux-waitpid.c: Fix common/ includes.
10339         * nat/linux-ptrace.h: Fix common/ includes.
10340         * nat/linux-ptrace.c: Fix common/ includes.
10341         * nat/linux-procfs.c: Fix common/ includes.
10342         * nat/linux-personality.c: Fix common/ includes.
10343         * nat/linux-osdata.c: Fix common/ includes.
10344         * nat/linux-namespaces.c: Fix common/ includes.
10345         * nat/linux-btrace.h: Fix common/ includes.
10346         * nat/linux-btrace.c: Fix common/ includes.
10347         * nat/fork-inferior.c: Fix common/ includes.
10348         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10349         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10350         * nat/aarch64-linux.c: Fix common/ includes.
10351         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10352         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10353         * namespace.h: Fix common/ includes.
10354         * mips-linux-tdep.c: Fix common/ includes.
10355         * minsyms.c: Fix common/ includes.
10356         * mi/mi-parse.h: Fix common/ includes.
10357         * mi/mi-main.c: Fix common/ includes.
10358         * mi/mi-cmd-env.c: Fix common/ includes.
10359         * memrange.h: Fix common/ includes.
10360         * memattr.c: Fix common/ includes.
10361         * maint.h: Fix common/ includes.
10362         * maint.c: Fix common/ includes.
10363         * main.c: Fix common/ includes.
10364         * machoread.c: Fix common/ includes.
10365         * location.c: Fix common/ includes.
10366         * linux-thread-db.c: Fix common/ includes.
10367         * linux-nat.c: Fix common/ includes.
10368         * linux-fork.c: Fix common/ includes.
10369         * inline-frame.c: Fix common/ includes.
10370         * infrun.c: Fix common/ includes.
10371         * inflow.c: Fix common/ includes.
10372         * inferior.h: Fix common/ includes.
10373         * inferior.c: Fix common/ includes.
10374         * infcmd.c: Fix common/ includes.
10375         * inf-ptrace.c: Fix common/ includes.
10376         * inf-child.c: Fix common/ includes.
10377         * ia64-linux-nat.c: Fix common/ includes.
10378         * i387-tdep.c: Fix common/ includes.
10379         * i386-tdep.c: Fix common/ includes.
10380         * i386-linux-tdep.c: Fix common/ includes.
10381         * i386-linux-nat.c: Fix common/ includes.
10382         * i386-go32-tdep.c: Fix common/ includes.
10383         * i386-fbsd-tdep.c: Fix common/ includes.
10384         * i386-fbsd-nat.c: Fix common/ includes.
10385         * guile/scm-type.c: Fix common/ includes.
10386         * guile/guile.c: Fix common/ includes.
10387         * go32-nat.c: Fix common/ includes.
10388         * gnu-nat.c: Fix common/ includes.
10389         * gdbthread.h: Fix common/ includes.
10390         * gdbarch-selftests.c: Fix common/ includes.
10391         * gdb_usleep.c: Fix common/ includes.
10392         * gdb_select.h: Fix common/ includes.
10393         * gdb_bfd.c: Fix common/ includes.
10394         * gcore.c: Fix common/ includes.
10395         * fork-child.c: Fix common/ includes.
10396         * findvar.c: Fix common/ includes.
10397         * fbsd-nat.c: Fix common/ includes.
10398         * event-top.c: Fix common/ includes.
10399         * event-loop.c: Fix common/ includes.
10400         * dwarf2read.c: Fix common/ includes.
10401         * dwarf2loc.c: Fix common/ includes.
10402         * dwarf2-frame.c: Fix common/ includes.
10403         * dwarf-index-cache.c: Fix common/ includes.
10404         * dtrace-probe.c: Fix common/ includes.
10405         * disasm-selftests.c: Fix common/ includes.
10406         * defs.h: Fix common/ includes.
10407         * csky-tdep.c: Fix common/ includes.
10408         * cp-valprint.c: Fix common/ includes.
10409         * cp-support.h: Fix common/ includes.
10410         * cp-support.c: Fix common/ includes.
10411         * corelow.c: Fix common/ includes.
10412         * completer.h: Fix common/ includes.
10413         * completer.c: Fix common/ includes.
10414         * compile/compile.c: Fix common/ includes.
10415         * compile/compile-loc2c.c: Fix common/ includes.
10416         * compile/compile-cplus-types.c: Fix common/ includes.
10417         * compile/compile-cplus-symbols.c: Fix common/ includes.
10418         * command.h: Fix common/ includes.
10419         * cli/cli-dump.c: Fix common/ includes.
10420         * cli/cli-cmds.c: Fix common/ includes.
10421         * charset.c: Fix common/ includes.
10422         * build-id.c: Fix common/ includes.
10423         * btrace.h: Fix common/ includes.
10424         * btrace.c: Fix common/ includes.
10425         * breakpoint.h: Fix common/ includes.
10426         * breakpoint.c: Fix common/ includes.
10427         * ax.h:
10428         (enum agent_op): Fix common/ includes.
10429         * ax-general.c (struct aop_map): Fix common/ includes.
10430         * ax-gdb.c: Fix common/ includes.
10431         * auxv.c: Fix common/ includes.
10432         * auto-load.c: Fix common/ includes.
10433         * arm-tdep.c: Fix common/ includes.
10434         * arch/riscv.c: Fix common/ includes.
10435         * arch/ppc-linux-common.c: Fix common/ includes.
10436         * arch/i386.c: Fix common/ includes.
10437         * arch/arm.c: Fix common/ includes.
10438         * arch/arm-linux.c: Fix common/ includes.
10439         * arch/arm-get-next-pcs.c: Fix common/ includes.
10440         * arch/amd64.c: Fix common/ includes.
10441         * arch/aarch64.c: Fix common/ includes.
10442         * arch/aarch64-insn.c: Fix common/ includes.
10443         * arch-utils.c: Fix common/ includes.
10444         * amd64-windows-tdep.c: Fix common/ includes.
10445         * amd64-tdep.c: Fix common/ includes.
10446         * amd64-sol2-tdep.c: Fix common/ includes.
10447         * amd64-obsd-tdep.c: Fix common/ includes.
10448         * amd64-nbsd-tdep.c: Fix common/ includes.
10449         * amd64-linux-tdep.c: Fix common/ includes.
10450         * amd64-linux-nat.c: Fix common/ includes.
10451         * amd64-fbsd-tdep.c: Fix common/ includes.
10452         * amd64-fbsd-nat.c: Fix common/ includes.
10453         * amd64-dicos-tdep.c: Fix common/ includes.
10454         * amd64-darwin-tdep.c: Fix common/ includes.
10455         * agent.c: Fix common/ includes.
10456         * ada-lang.h: Fix common/ includes.
10457         * ada-lang.c: Fix common/ includes.
10458         * aarch64-tdep.c: Fix common/ includes.
10459
10460 2019-01-25  Tom Tromey  <tom@tromey.com>
10461
10462         * common/create-version.sh: Use common/version.h.
10463
10464 2019-01-24  Pedro Alves  <palves@redhat.com>
10465
10466         * infrun.c (signal_stop, signal_print, signal_program)
10467         (signal_catch, signal_pass): Now arrays instead of pointers.
10468         (update_signals_program_target, do_target_resume)
10469         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10470         * linux-nat.c (linux_nat_target::pass_signals)
10471         (linux_nat_target::create_inferior, linux_nat_target::attach):
10472         Adjust.
10473         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10474         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10475         * procfs.c (procfs_target::pass_signals): Adjust.
10476         * record-full.c (record_full_target::resume): Adjust.
10477         * remote.c (remote_target::pass_signals)
10478         (remote_target::program_signals): Adjust.
10479         * target-debug.h (target_debug_print_signals): Now takes a
10480         gdb::array_view as parameter.  Adjust.
10481         * target.h (target_ops) <pass_signals, program_signals>: Replace
10482         pointer and length parameters with gdb::array_view.
10483         (target_pass_signals, target_program_signals): Likewise.
10484         * target-delegates.c: Regenerate.
10485
10486 2019-01-24  Pedro Alves  <palves@redhat.com>
10487
10488         * common/forward-scope-exit.h
10489         (forward_scope_exit::forward_scope_exit): Pass arguments to
10490         m_bind_function directly, instead of creating a std::bind and
10491         copying that.
10492
10493 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10494
10495         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10496         for static members.
10497         (pass_in_v_vfp_candidate): Likewise.
10498
10499 2019-01-23  Tom Tromey  <tom@tromey.com>
10500             Pedro Alves  <palves@redhat.com>
10501
10502         * regcache.c (class regcache_invalidator): Remove.
10503         (regcache::raw_write): Use make_scope_exit.
10504
10505 2019-01-23  Tom Tromey  <tom@tromey.com>
10506
10507         * ui-out.h (class ui_out_emit_type): Update comment.
10508
10509 2019-01-23  Tom Tromey  <tom@tromey.com>
10510
10511         * infrun.c (fetch_inferior_event): Update comment.
10512
10513 2019-01-23  Tom Tromey  <tom@tromey.com>
10514             Pedro Alves  <palves@redhat.com>
10515
10516         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10517         parameter.
10518         (fetch_inferior_event): Use SCOPE_EXIT.
10519
10520
10521 2019-01-23  Tom Tromey  <tom@tromey.com>
10522             Pedro Alves  <palves@redhat.com>
10523
10524         * infrun.c (disable_thread_events): Delete.
10525         (stop_all_threads): Use SCOPE_EXIT.
10526
10527 2019-01-23  Tom Tromey  <tom@tromey.com>
10528             Pedro Alves  <palves@redhat.com>
10529
10530         * symfile.c: Include forward-scope-exit.h.
10531         (clear_symtab_users_cleanup): Replace forward declaration with
10532         a FORWARD_SCOPE_EXIT.
10533         (syms_from_objfile_1): Use the forward_scope_exit and
10534         gdb::optional instead of cleanup_function.
10535         (reread_symbols): Use the forward_scope_exit instead of
10536         cleanup_function.
10537         (clear_symtab_users_cleanup): Remove function.
10538
10539 2019-01-23  Tom Tromey  <tom@tromey.com>
10540             Pedro Alves  <palves@redhat.com>
10541
10542         * linux-nat.c: Include scope-exit.h.
10543         (cleanup_target_stop): Remove.
10544         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10545         SCOPE_EXIT.
10546
10547 2019-01-23  Tom Tromey  <tom@tromey.com>
10548             Pedro Alves  <palves@redhat.com>
10549
10550         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10551         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10552
10553 2019-01-23  Tom Tromey  <tom@tromey.com>
10554             Andrew Burgess  <andrew.burgess@embecosm.com>
10555             Pedro Alves  <palves@redhat.com>
10556
10557         * infrun.c (fetch_inferior_event): Use scope_exit.
10558         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10559         * top.c (execute_command): Use scope_exit.
10560         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10561         * utils.c (do_bpstat_clear_actions_cleanup)
10562         (make_bpstat_clear_actions_cleanup): Remove.
10563
10564 2019-01-23  Tom Tromey  <tom@tromey.com>
10565             Pedro Alves  <palves@redhat.com>
10566
10567         * infrun.c: Include "common/scope-exit.h"
10568         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10569         (wait_for_inferior): Use SCOPE_EXIT.
10570         (fetch_inferior_event): Use scope_exit.
10571
10572 2019-01-23  Tom Tromey  <tom@tromey.com>
10573             Pedro Alves  <palves@redhat.com>
10574
10575         * breakpoint.c (create_breakpoint): Remove cleanup.
10576
10577 2019-01-23  Tom Tromey  <tom@tromey.com>
10578             Andrew Burgess  <andrew.burgess@embecosm.com>
10579             Pedro Alves  <palves@redhat.com>
10580
10581 2019-01-23  Pedro Alves  <palves@redhat.com>
10582
10583         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10584
10585 2019-01-23  Pedro Alves  <palves@redhat.com>
10586             Andrew Burgess  <andrew.burgess@embecosm.com>
10587
10588         * gdbthread.h: Include "common/forward-scope-exit.h".
10589         (scoped_finish_thread_state): Redefine custom class in terms of
10590         forward_scope_exit.
10591
10592 2019-01-23  Pedro Alves  <palves@redhat.com>
10593             Andrew Burgess  <andrew.burgess@embecosm.com>
10594
10595         * common/forward-scope-exit.h: New file.
10596
10597 2019-01-23  Pedro Alves  <palves@redhat.com>
10598             Andrew Burgess  <andrew.burgess@embecosm.com>
10599             Tom Tromey  <tom@tromey.com>
10600
10601         * common/scope-exit.h: New file.
10602
10603 2019-01-23  Pedro Alves  <palves@redhat.com>
10604
10605         * common/preprocessor.h (ESC): Rename to ...
10606         (ESC_PARENS): ... this.
10607         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10608         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10609
10610 2019-01-23  Tom Tromey  <tom@tromey.com>
10611
10612         * language.h (class scoped_switch_to_sym_language_if_auto):
10613         Initialize m_lang in both cases.
10614
10615 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10616
10617         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10618         with XCNEW.
10619
10620 2019-01-22  Tom Tromey  <tom@tromey.com>
10621
10622         * corelow.c: Do not include sys/file.h.
10623
10624 2019-01-22  Tom Tromey  <tom@tromey.com>
10625
10626         * tui/tui-wingeneral.h: Include gdb_curses.h.
10627
10628 2019-01-22  Tom Tromey  <tom@tromey.com>
10629
10630         * source-cache.h (class source_cache) <get_source_lines,
10631         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10632
10633 2019-01-22  Tom Tromey  <tom@tromey.com>
10634
10635         * remote-fileio.h (struct remote_target): Declare.
10636
10637 2019-01-22  Tom Tromey  <tom@tromey.com>
10638
10639         * python/py-arch.c: Do not include py-ref.h.
10640         * python/py-bpevent.c: Do not include py-ref.h.
10641         * python/py-cmd.c: Do not include py-ref.h.
10642         * python/py-continueevent.c: Do not include py-ref.h.
10643         * python/py-event.h: Do not include py-ref.h.
10644         * python/py-evtregistry.c: Do not include py-ref.h.
10645         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10646         * python/py-frame.c: Do not include py-ref.h.
10647         * python/py-framefilter.c: Do not include py-ref.h.
10648         * python/py-function.c: Do not include py-ref.h.
10649         * python/py-infevents.c: Do not include py-ref.h.
10650         * python/py-linetable.c: Do not include py-ref.h.
10651         * python/py-objfile.c: Do not include py-ref.h.
10652         * python/py-param.c: Do not include py-ref.h.
10653         * python/py-prettyprint.c: Do not include py-ref.h.
10654         * python/py-progspace.c: Do not include py-ref.h.
10655         * python/py-symbol.c: Do not include py-ref.h.
10656         * python/py-symtab.c: Do not include py-ref.h.
10657         * python/py-type.c: Do not include py-ref.h.
10658         * python/py-unwind.c: Do not include py-ref.h.
10659         * python/py-utils.c: Do not include py-ref.h.
10660         * python/py-value.c: Do not include py-ref.h.
10661         * python/py-varobj.c: Do not include py-ref.h.
10662         * python/py-xmethods.c: Do not include py-ref.h.
10663         * python/python.c: Do not include py-ref.h.
10664         * varobj.c: Do not include py-ref.h.
10665
10666 2019-01-22  Tom Tromey  <tom@tromey.com>
10667
10668         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10669         keyword for bcache.
10670
10671 2019-01-22  Tom Tromey  <tom@tromey.com>
10672
10673         * compile/compile-cplus-types.c: Remove a comment by #include.
10674
10675 2019-01-22  Tom Tromey  <tom@tromey.com>
10676
10677         * compile/gcc-c-plugin.h: Include compile-internal.h.
10678
10679 2019-01-22  Tom Tromey  <tom@tromey.com>
10680
10681         * stabsread.c (EXTERN): Do not define.
10682         (symnum, next_symbol_text_func, processing_gcc_compilation)
10683         (within_function, global_sym_chain, global_stabs)
10684         (previous_stab_code, this_object_header_files)
10685         (n_this_object_header_files)
10686         (n_allocated_this_object_header_files): Define.
10687         * stabsread.h (EXTERN): Never define.  Use "extern".
10688
10689 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10690
10691         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10692         history_value.
10693
10694 2019-01-21  Tom Tromey  <tom@tromey.com>
10695
10696         * ui-out.c: Fix includes.
10697         * tui/tui-source.c: Fix includes.
10698         * target.c: Fix includes.
10699         * remote.c: Fix includes.
10700         * regcache.c: Fix includes.
10701         * python/py-block.c: Fix includes.
10702         * printcmd.c: Fix includes.
10703         * or1k-tdep.c: Fix includes.
10704         * mi/mi-main.c: Fix includes.
10705         * m32r-tdep.c: Fix includes.
10706         * csky-tdep.c: Fix includes.
10707         * compile/compile-cplus-types.c: Fix includes.
10708         * cli/cli-interp.c: Fix includes.
10709
10710 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10711
10712         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10713         for padding.
10714
10715 2019-01-16  Tom Tromey  <tom@tromey.com>
10716
10717         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10718         earlier.
10719         (struct objfile) <msymbols_range>: Move from top level.
10720         <msymbols>: New method.
10721         (class objfile_msymbols): Remove.
10722         * symtab.c (default_collect_symbol_completion_matches_break_on):
10723         Update.
10724         * symmisc.c (dump_msymbols): Update.
10725         * stabsread.c (scan_file_globals): Update.
10726         * objc-lang.c (info_selectors_command, info_classes_command)
10727         (find_methods): Update.
10728         * minsyms.c (find_solib_trampoline_target): Update.
10729         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10730         * coffread.c (coff_symfile_read): Update.
10731         * ada-lang.c (ada_lookup_simple_minsym)
10732         (ada_collect_symbol_completion_matches): Update.
10733
10734 2019-01-16  Tom Tromey  <tom@tromey.com>
10735
10736         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10737         type.  Remove no-argument constructor.
10738         <iterator::operator++>: Simplify.
10739         <begin>: Update.
10740         <end>: Use minimal_symbol_count.
10741
10742 2019-01-16  Tom Tromey  <tom@tromey.com>
10743
10744         * objfiles.h (struct objfile) <psymtabs>: New method.
10745         (class objfile_psymtabs): Remove.
10746         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10747         typedef.
10748         <range>: New method.
10749         (require_partial_symbols): Change return type.
10750         * psymtab.c (require_partial_symbols)
10751         (psym_expand_symtabs_matching): Update.
10752         * mdebugread.c (parse_partial_symbols): Update.
10753         * dbxread.c (dbx_end_psymtab): Update.
10754
10755 2019-01-15  Tom Tromey  <tom@tromey.com>
10756
10757         * symtab.c (lookup_objfile_from_block)
10758         (lookup_symbol_in_objfile_symtabs)
10759         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10760         (find_line_symtab, info_sources_command)
10761         (default_collect_symbol_completion_matches_break_on)
10762         (make_source_files_completion_list): Update.
10763         * symmisc.c (print_objfile_statistics, dump_objfile)
10764         (maintenance_print_symbols, maintenance_info_symtabs)
10765         (maintenance_check_symtabs, maintenance_info_line_tables):
10766         Update.
10767         * source.c (select_source_symtab)
10768         (forget_cached_source_info_for_objfile): Update.
10769         * objfiles.h (class objfile_compunits): Remove.
10770         (struct objfile) <compunits_range>: New typedef.
10771         (compunits): New method.
10772         * objfiles.c (objfile_relocate1): Update.
10773         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10774         * maint.c (count_symtabs_and_blocks): Update.
10775         * linespec.c (iterate_over_all_matching_symtabs): Update.
10776         * cp-support.c (add_symbol_overload_list_qualified): Update.
10777         * coffread.c (coff_symtab_read): Update.
10778         * ada-lang.c (add_nonlocal_symbols)
10779         (ada_collect_symbol_completion_matches)
10780         (ada_add_global_exceptions): Update.
10781
10782 2019-01-15  Tom Tromey  <tom@tromey.com>
10783
10784         * progspace.h (program_space) <objfiles_safe_range>: New
10785         typedef.
10786         <objfiles_safe>: New method.
10787         * objfiles.h (class all_objfiles_safe): Remove.
10788         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10789         * jit.c (jit_inferior_exit_hook): Update.
10790
10791 2019-01-17  Tom Tromey  <tom@tromey.com>
10792
10793         * progspace.h (program_space) <objfiles_range>: New typedef.
10794         <objfiles>: New method.
10795         <objfiles_head>: Rename from objfiles.
10796         (object_files): Update.
10797         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10798         * guile/scm-pretty-print.c
10799         (ppscm_find_pretty_printer_from_objfiles): Update.
10800         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10801         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10802         Update.
10803         * python/py-progspace.c (pspy_get_objfiles): Update.
10804         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10805         Update.
10806         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10807         (objfpy_lookup_objfile_by_build_id): Update.
10808         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10809         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10810         Update.
10811         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10812         (expand_symtab_containing_pc, lookup_objfile_from_block)
10813         (lookup_static_symbol, basic_lookup_transparent_type)
10814         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10815         (find_line_symtab, info_sources_command)
10816         (default_collect_symbol_completion_matches_break_on)
10817         (make_source_files_completion_list, find_main_name): Update.
10818         * symmisc.c (print_symbol_bcache_statistics)
10819         (print_objfile_statistics, maintenance_print_symbols)
10820         (maintenance_print_msymbols, maintenance_print_objfiles)
10821         (maintenance_info_symtabs, maintenance_check_symtabs)
10822         (maintenance_expand_symtabs, maintenance_info_line_tables):
10823         Update.
10824         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10825         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10826         (map_overlay_command, unmap_overlay_command)
10827         (simple_overlay_update, expand_symtabs_matching)
10828         (map_symbol_filenames): Update.
10829         * symfile-debug.c (set_debug_symfile): Update.
10830         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10831         Update.
10832         * source.c (select_source_symtab, forget_cached_source_info):
10833         Update.
10834         * solib.c (solib_read_symbols): Update.
10835         * solib-spu.c (append_ocl_sos): Update.
10836         * psymtab.c (maintenance_print_psymbols)
10837         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10838         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10839         * printcmd.c (info_symbol_command): Update.
10840         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10841         Update.
10842         * objfiles.h (class all_objfiles): Remove.
10843         * objfiles.c (have_partial_symbols, have_full_symbols)
10844         (have_minimal_symbols, qsort_cmp, update_section_map)
10845         (shared_objfile_contains_address_p)
10846         (default_iterate_over_objfiles_in_search_order): Update.
10847         * objc-lang.c (info_selectors_command, info_classes_command)
10848         (find_methods): Update.
10849         * minsyms.c (find_solib_trampoline_target): Update.
10850         * maint.c (maintenance_info_sections)
10851         (maintenance_translate_address, count_symtabs_and_blocks):
10852         Update.
10853         * main.c (captured_main_1): Update.
10854         * linux-thread-db.c (try_thread_db_load_from_pdir)
10855         (has_libpthread): Update.
10856         * linespec.c (iterate_over_all_matching_symtabs)
10857         (search_minsyms_for_name): Update.
10858         * jit.c (jit_find_objf_with_entry_addr): Update.
10859         * hppa-tdep.c (find_unwind_entry)
10860         (hppa_lookup_stub_minimal_symbol): Update.
10861         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10862         Update.
10863         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10864         (elf_gnu_ifunc_resolve_by_got): Update.
10865         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10866         * dwarf-index-write.c (save_gdb_index_command): Update.
10867         * cp-support.c (add_symbol_overload_list_qualified): Update.
10868         * breakpoint.c (create_overlay_event_breakpoint)
10869         (create_longjmp_master_breakpoint)
10870         (create_std_terminate_master_breakpoint)
10871         (create_exception_master_breakpoint): Update.
10872         * blockframe.c (find_pc_partial_function): Update.
10873         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10874         (ada_collect_symbol_completion_matches)
10875         (ada_add_global_exceptions): Update.
10876
10877 2019-01-17  Tom Tromey  <tom@tromey.com>
10878
10879         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10880         declare VEC.
10881         (solib_target_parse_libraries): Change return type.
10882         (library_list_start_segment, library_list_start_section)
10883         (library_list_end_library, library_list_start_library); Update.
10884         (solib_target_free_library_list): Remove.
10885         (solib_target_parse_libraries): Remove cleanup.  Change return
10886         type.
10887         (solib_target_current_sos): Update.
10888
10889 2019-01-17  Tom Tromey  <tromey@bapiya>
10890
10891         * valprint.c: Replace "the the" with "the".
10892         * symtab.c: Replace "the the" with "the".
10893         * solib.c: Replace "the the" with "the".
10894         * solib-dsbt.c: Replace "the the" with "the".
10895         * linespec.c: Replace "the the" with "the".
10896         * dwarf2loc.h: Replace "the the" with "the".
10897         * amd64-windows-tdep.c: Replace "the the" with "the".
10898         * aarch64-tdep.c: Replace "the the" with "the".
10899
10900 2019-01-16  Keith Seitz  <keiths@redhat.com>
10901
10902         PR gdb/23773
10903         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10904         <builder>: Rename to ..
10905         <m_builder>: ... this and make private.
10906         (dwarf2_cu::get_builder): New method.  Change all users of
10907         `builder' to use this method.
10908         (dwarf2_start_symtab): Move to ...
10909         (dwarf2_cu::start_symtab): ... here.  Update all callers
10910         (setup_type_unit_groups): Move to ...
10911         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10912         callers.
10913         (dwarf2_cu::reset_builder): New method.
10914         (process_full_compunit, process_full_type_unit): Use
10915         dwarf2_cu::reset_builder.
10916         (follow_die_offset): Record the ancestor CU if it is different
10917         from the followed DIE's CU.
10918         (follow_die_sig_1): Likewise.
10919
10920 2019-01-15  Tom Tromey  <tom@tromey.com>
10921
10922         * remote.c (class remote_state) <buf>: Now a char_vector.
10923         <buf_size>: Remove.
10924         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10925         parameter.
10926         (remote_target::getpkt_or_notif_sane_1)
10927         (remote_target::getpkt_sane)
10928         (remote_target::getpkt_or_notif_sane): Likewise.
10929         (class remote_target) <putpkt>: New overload.
10930         (remote_target::read_frame): Change type of "buf_p".  Remove
10931         sizeof_p parameter.
10932         (packet_ok): New overload.
10933         (packet_check_result): New overload.
10934         Update all uses.
10935
10936 2019-01-14  Tom Tromey  <tom@tromey.com>
10937
10938         * remote-notif.c (handle_notification, remote_notif_ack)
10939         (remote_notif_parse): Make "buf" const.
10940         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10941         const.
10942         (remote_notif_parse, remote_notif_ack, handle_notification):
10943         Likewise.
10944         * remote.c (remote_notif_stop_parse): Make "buf" const.
10945         (remote_target::remote_parse_stop_reply): Make "buf" const.
10946         (remote_notif_stop_ack): Make "buf" const.
10947
10948 2019-01-14  Tom Tromey  <tom@tromey.com>
10949
10950         * remote.c (remote_console_output): Make parameter const.
10951
10952 2019-01-14  Tom Tromey  <tom@tromey.com>
10953
10954         * target-debug.h (target_debug_print_signals): Constify.
10955         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10956         * procfs.c (procfs_target::pass_signals): Update.
10957         * linux-nat.c (linux_nat_target::pass_signals): Update.
10958         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10959         * target-delegates.c: Rebuild.
10960         * remote.c (remote_target::program_signals): Update.
10961         (remote_target::pass_signals): Update.
10962         * target.c (target_pass_signals): Constify argument.
10963         (target_program_signals): Likewise.
10964         * target.h (struct target_ops) <pass_signals, program_signals>:
10965         Constify argument.
10966         (target_pass_signals, target_program_signals): Constify argument.
10967
10968 2019-01-14  Tom Tromey  <tom@tromey.com>
10969
10970         PR tui/28819:
10971         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10972
10973 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10974
10975         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10976         field.
10977         * rs6000-tdep.c: Include reggroups.h.
10978         (IS_V_ALIAS_PSEUDOREG): Define.
10979         (rs6000_register_name): Return names for the "vX" aliases.
10980         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10981         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10982         aliases.  Call default_register_reggroup_p for all other
10983         pseudo-registers.
10984         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10985         New functions.
10986         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10987         Handle "vX" aliases.
10988         (v_alias_pseudo_register_collect): New function.
10989         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10990         (rs6000_gdbarch_init): Initialize "vX" aliases as
10991         pseudo-registers.  Restore registration of
10992         rs6000_pseudo_register_reggroup_p with
10993         set_tdesc_pseudo_register_reggroup_p.
10994
10995 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10996
10997         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10998         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10999         set_gdbarch_num_pseudo_regs.
11000
11001 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11002
11003         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11004         Remove arg prefixname, add do_set and do_show.
11005         Add member functions set_list and show_list.
11006         * cli/cli-style.c (class cli_style_option): Update accordingly.
11007         (style_set_list): Move to file scope.
11008         (style_show_list): Likewise.
11009         (set_style): Call help_list.
11010         (show_style): Call cmd_show_list.
11011         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11012         Update to use the new macro.
11013
11014 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11015
11016         * ada-lang.c (_initialize_ada_language): Expand the help text
11017         for the "catch exception" command.
11018
11019 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11020
11021         * symtab.c (matching_obj_sections): Initialize obj,
11022         declare it closer to its usage.
11023
11024 2019-01-10  Tom Tromey  <tom@tromey.com>
11025
11026         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11027         (basic_inf_threads_range): Remove.
11028         (inf_threads_range, inf_non_exited_threads_range)
11029         (safe_inf_threads_range): Use next_adapter.
11030
11031 2019-01-10  Keith Seitz  <keiths@redhat.com>
11032
11033         PR gdb/23712
11034         PR symtab/23010
11035         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11036         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11037
11038 2019-01-10  Keith Seitz  <keiths@redhat.com>
11039
11040         PR gdb/23712
11041         PR symtab/23010
11042         * dictionary.c (pending_to_vector): Remove.
11043         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11044         Remove _1 suffix, replacing functions of the same name.  Update
11045         all callers.
11046         (dict_create_hashed, dict_create_hashed_expandable)
11047         (dict_create_linear, dict_create_linear_expandable, dict_free)
11048         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11049         Make functions static.
11050
11051 2019-01-10  Keith Seitz  <keiths@redhat.com>
11052
11053         PR gdb/23712
11054         PR symtab/23010
11055         * dictionary.h (struct dictionary): Replace declaration with
11056         multidictionary.
11057         (dict_create_hashed, dict_create_hashed_expandable)
11058         (dict_create_linear, dict_create_linear_expandable)
11059         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11060         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11061         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11062         taking multidictionary argument.
11063         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11064         * block.h (struct block) <dict>: Change to multidictionary
11065         and rename `multidict'.
11066         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11067         symmisc.c: Update all dictionary references to multidictionary.
11068
11069 2019-01-10  Keith Seitz  <keiths@redhat.com>
11070
11071         PR gdb/23712
11072         PR symtab/23010
11073         * dictionary.c: Include unordered_map.
11074         (pending_to_vector): New function.
11075         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11076         Rewrite the non-"_1" functions to take vector instead
11077         of linked list.
11078         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11079         "new" _1 versions of the same name.
11080         (multidictionary): Define.
11081         (std::hash<enum language): New definition.
11082         (collate_pending_symbols_by_language, mdict_create_hashed)
11083         (mdict_create_hashed_expandable, mdict_create_linear)
11084         (mdict_create_linear_expandable, mdict_free)
11085         (find_language_dictionary, create_new_language_dictionary)
11086         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11087         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11088         (mdict_size, mdict_empty): New functions.
11089         * dictionary.h (mdict_iterator): Define.
11090
11091 2019-01-10  Pedro Alves  <palves@redhat.com>
11092
11093         * breakpoint.c (read_uploaded_action)
11094         (create_tracepoint_from_upload): Adjust to use
11095         gdb::unique_xmalloc_ptr.
11096         * ctf.c (ctf_write_uploaded_tp):
11097         (SET_ARRAY_FIELD): Use emplace_back.
11098         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11099         * tracefile-tfile.c (tfile_write_uploaded_tp):
11100         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11101         gdb::unique_xmalloc_ptr.
11102         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11103         at_string, cond_string, cmd_strings>: Replace char pointers
11104         with gdb::unique_xmalloc_ptr.
11105
11106 2019-01-10  Pedro Alves  <palves@redhat.com>
11107
11108         * solib-target.c (library_list_start_library): Don't xstrdup name.
11109
11110 2019-01-10  Pedro Alves  <palves@redhat.com>
11111
11112         * mdebugread.c (parse_partial_symbols): Use
11113         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11114
11115 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11116
11117         * linux-fork.c (scoped_switch_fork_info)
11118         <~scoped_switch_fork_info>: Fix incorrect variable name.
11119
11120 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11121
11122         * linux-fork.c (scoped_switch_fork_info)
11123         <scoped_switch_fork_info>: Make explicit.
11124         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11125
11126 2019-01-10  Tom Tromey  <tom@tromey.com>
11127
11128         * objfiles.h (objfile::reset_psymtabs): Update.
11129         * objfiles.c (objfile::objfile): Update.
11130         * psymtab.h (psymtab_storage::obstack): Update.
11131         (psymtab_storage::m_obstack): Use gdb::optional.
11132         (class psymtab_storage): Update comment.  Remove objfile
11133         parameter.
11134         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11135
11136 2019-01-10  Tom Tromey  <tom@tromey.com>
11137
11138         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11139         <free_psymtabs>: Now private.
11140         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11141         (allocate_psymtab): Use new method.
11142
11143 2019-01-10  Tom Tromey  <tom@tromey.com>
11144
11145         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11146         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11147         * mdebugread.c (parse_partial_symbols): Use
11148         allocate_dependencies.
11149         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11150         allocate_dependencies.
11151         (process_psymtab_comp_unit_reader)
11152         (build_type_psymtab_dependencies): Likewise.
11153         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11154
11155 2019-01-10  Tom Tromey  <tom@tromey.com>
11156
11157         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11158         PSYMBOL_SET_LANGUAGE.
11159         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11160
11161 2019-01-10  Tom Tromey  <tom@tromey.com>
11162
11163         * psymtab.h (psymtab_storage::obstack): New method.
11164         <m_obstack>: Rename from obstack; now private.
11165         * psymtab.c (psymtab_storage): Update.
11166         * dwarf2read.c (create_addrmap_from_index)
11167         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11168         Update.
11169
11170 2019-01-10  Tom Tromey  <tom@tromey.com>
11171
11172         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11173         * objfiles.h (objfile::reset_psymtabs): New method.
11174
11175 2019-01-10  Tom Tromey  <tom@tromey.com>
11176
11177         * symmisc.c (print_symbol_bcache_statistics): Update.
11178         (print_objfile_statistics): Update.
11179         * symfile.c (reread_symbols): Update.
11180         * psymtab.h (class psymtab_storage): New.
11181         * psymtab.c (psymtab_storage): New constructor.
11182         (~psymtab_storage): New destructor.
11183         (require_partial_symbols): Update.
11184         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11185         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11186         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11187         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11188         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11189         (start_psymtab_common, end_psymtab_common)
11190         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11191         (allocate_psymtab): Update.
11192         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11193         Update.
11194         (dump_psymtab_addrmap, maintenance_print_psymbols)
11195         (maintenance_check_psymtabs): Update.
11196         (class objfile_psymtabs): Move to objfiles.h.
11197         * psympriv.h (discard_psymtab): Now inline.
11198         (psymtab_discarder::psymtab_discarder): Update.
11199         (psymtab_discarder::~psymtab_discarder): Update.
11200         (ALL_OBJFILE_PSYMTABS): Rewrite.
11201         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11202         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11203         Remove fields.
11204         <partial_symtabs>: New field.
11205         (class objfile_psymtabs): Move from psymtab.h.  Update.
11206         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11207         psymbol_cache.
11208         (objfile::~objfile): Don't destroy psymbol_cache.
11209         * mdebugread.c (parse_partial_symbols): Update.
11210         * dwarf2read.c (create_addrmap_from_index)
11211         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11212         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11213         (add_partial_subprogram, dwarf2_ranges_read): Update.
11214         * dwarf-index-write.c (write_address_map)
11215         (write_one_signatured_type, recursively_write_psymbols)
11216         (class debug_names, class debug_names, write_psymtabs_to_index):
11217         Update.
11218
11219 2019-01-10  Tom Tromey  <tom@tromey.com>
11220
11221         * symtab.h (SYMBOL_SET_NAMES): Update.
11222         (symbol_set_names): Update.
11223         (MSYMBOL_SET_NAMES): Update.
11224         * symtab.c (symbol_set_names): Change argument to be an
11225         objfile_per_bfd_storage.
11226         * psymtab.c (add_psymbol_to_bcache): Update.
11227         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11228
11229 2019-01-10  Tom Tromey  <tom@tromey.com>
11230
11231         * symtab.c (create_demangled_names_hash): Change argument to be an
11232         objfile_per_bfd_storage.
11233         (symbol_set_names): Update.
11234
11235 2019-01-10  Tom Tromey  <tom@tromey.com>
11236
11237         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11238         init_psymbol_list.
11239         * psymtab.c (init_psymbol_list): Do nothing if already called.
11240         * psympriv.h (init_psymbol_list): Add comment.
11241         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11242         init_psymbol_list.
11243         * dbxread.c (dbx_symfile_read): Unconditionally call
11244         init_psymbol_list.
11245
11246 2019-01-10  Tom Tromey  <tom@tromey.com>
11247
11248         * xcoffread.c (scan_xcoff_symtab): Update.
11249         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11250         "where".
11251         * mdebugread.c (parse_partial_symbols)
11252         (handle_psymbol_enumerators): Update.
11253         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11254         * dbxread.c (read_dbx_symtab): Update.
11255         * psympriv.h (psymbol_placement): New enum.
11256         (add_psymbol_to_list): Update.
11257
11258 2019-01-10  Tom Tromey  <tom@tromey.com>
11259
11260         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11261         static_psymbols parameters.
11262         (scan_xcoff_symtab): Update.
11263         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11264         static_psymbols parameters.
11265         * psympriv.h (start_psymtab_common): Update.
11266         * mdebugread.c (parse_partial_symbols): Update.
11267         * dwarf2read.c (create_partial_symtab): Update.
11268         * dbxread.c (read_dbx_symtab): Update.
11269         (start_psymtab): Remove global_psymbols and static_psymbols
11270         parameters.
11271
11272 2019-01-10  Tom Tromey  <tom@tromey.com>
11273
11274         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11275         * psymtab.c (allocate_psymtab): Add comment.
11276         * psympriv.h (allocate_psymtab): Add comment.
11277         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11278         initializations.
11279         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11280
11281 2019-01-10  Tom Tromey  <tom@tromey.com>
11282
11283         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11284         Don't declare.
11285         * mipsread.c: Include mdebugread.h.
11286         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11287         Declare.
11288         * elfread.c: Include mdebugread.h.
11289
11290 2019-01-09  Tom Tromey  <tom@tromey.com>
11291
11292         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11293         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11294         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11295         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11296         (psym_lookup_symbol, psym_find_last_source_symtab)
11297         (psym_forget_cached_source_info, psym_print_stats)
11298         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11299         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11300         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11301         (psym_find_compunit_symtab_by_address)
11302         (maintenance_print_psymbols, maintenance_info_psymtabs)
11303         (maintenance_check_psymtabs): Use ranged for.
11304         * psymtab.h (class objfile_psymtabs): New.
11305         (require_partial_symbols): Return objfile_psymtabs.
11306         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11307
11308 2019-01-09  Tom Tromey  <tom@tromey.com>
11309
11310         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11311         (find_pc_mapped_section, list_overlays_command)
11312         (map_overlay_command, unmap_overlay_command)
11313         (simple_overlay_update): Use all_objfiles.
11314         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11315         * printcmd.c (info_symbol_command): Use all_objfiles.
11316         * objfiles.h (ALL_OBJSECTIONS): Remove.
11317         * maint.c (maintenance_translate_address): Use all_objfiles.
11318         * gcore.c (gcore_create_callback): Use all_objfiles.
11319         (objfile_find_memory_regions): Likewise.
11320
11321 2019-01-09  Tom Tromey  <tom@tromey.com>
11322
11323         * symtab.c (find_line_symtab, info_sources_command)
11324         (make_source_files_completion_list): Use objfile_compunits.
11325         * source.c (select_source_symtab): Use objfile_compunits.
11326         * objfiles.h (struct objfile): Update comment.
11327         (ALL_OBJFILES): Remove.
11328         (ALL_FILETABS): Remove.
11329         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11330         objfile_compunits.
11331
11332 2019-01-09  Tom Tromey  <tom@tromey.com>
11333
11334         * symmisc.c (print_objfile_statistics, dump_objfile)
11335         (maintenance_print_symbols): Use compunit_filetabs.
11336         * source.c (forget_cached_source_info_for_objfile): Use
11337         compunit_filetabs.
11338         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11339         (ALL_FILETABS): Use compunit_filetabs.
11340         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11341         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11342
11343 2019-01-09  Tom Tromey  <tom@tromey.com>
11344
11345         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11346         (compunit_filetabs): New.
11347         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11348         compunit_filetabs.
11349         (info_sources_command, make_source_files_completion_list): Remove
11350         declaration.
11351         * symmisc.c (print_objfile_statistics, dump_objfile)
11352         (maintenance_print_symbols): Remove declaration.
11353         (maintenance_info_symtabs): Use compunit_filetabs.
11354         (maintenance_info_line_tables): Likewise.
11355         * source.c (select_source_symtab): Change local variable name.
11356         (forget_cached_source_info_for_objfile): Remove declaration.
11357         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11358         * objfiles.c (objfile_relocate1): Remove declaration.
11359         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11360         declaration.
11361         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11362         * coffread.c (coff_symtab_read): Remove declaration.
11363         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11364         compunit_filetabs.
11365
11366 2019-01-09  Tom Tromey  <tom@tromey.com>
11367
11368         * symtab.c (lookup_objfile_from_block)
11369         (find_pc_sect_compunit_symtab, search_symbols)
11370         (default_collect_symbol_completion_matches_break_on): Use
11371         objfile_compunits.
11372         * objfiles.h (ALL_COMPUNITS): Remove.
11373         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11374         * cp-support.c (add_symbol_overload_list_qualified): Use
11375         objfile_compunits.
11376         * ada-lang.c (ada_collect_symbol_completion_matches)
11377         (ada_add_global_exceptions): Use objfile_compunits.
11378
11379 2019-01-09  Tom Tromey  <tom@tromey.com>
11380
11381         * source.c (select_source_symtab)
11382         (forget_cached_source_info_for_objfile): Remove declaration.
11383         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11384         declaration.
11385         * maint.c (count_symtabs_and_blocks): Remove declaration.
11386         * cp-support.c (add_symbol_overload_list_qualified): Remove
11387         declaration.
11388         * coffread.c (coff_symtab_read): Remove declaration.
11389         * symtab.c (lookup_symbol_in_objfile_symtabs)
11390         (basic_lookup_transparent_type_1): Use objfile_compunits.
11391         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11392         (info_sources_command, search_symbols)
11393         (default_collect_symbol_completion_matches_break_on)
11394         (make_source_files_completion_list): Remove declaration.
11395         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11396         (ada_collect_symbol_completion_matches)
11397         (ada_add_global_exceptions): Remove declaration.
11398         * linespec.c (iterate_over_all_matching_symtabs): Use
11399         objfile_compunits.
11400         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11401         (class objfile_compunits): New.
11402         (ALL_COMPUNITS): Use objfile_compunits.
11403         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11404         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11405         objfile_compunits.
11406         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11407
11408 2019-01-09  Tom Tromey  <tom@tromey.com>
11409
11410         * symtab.c (search_symbols)
11411         (default_collect_symbol_completion_matches_break_on): Use
11412         objfile_msymbols.
11413         * ada-lang.c (ada_lookup_simple_minsym)
11414         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11415         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11416         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11417         objfile_msymbols.
11418         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11419         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11420         * objc-lang.c (find_methods): Use objfile_msymbols.
11421         (info_selectors_command, info_classes_command): Likewise.
11422         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11423         * objfiles.h (class objfile_msymbols): New.
11424         (ALL_OBJFILE_MSYMBOLS): Remove.
11425         (ALL_MSYMBOLS): Remove.
11426
11427 2019-01-09  Tom Tromey  <tom@tromey.com>
11428
11429         * common/next-iterator.h (next_adapter): Add Iterator template
11430         parameter.
11431         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11432         (class all_objfiles_safe): New.
11433         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11434         * objfiles.c (put_objfile_before): Update comment.
11435         (add_separate_debug_objfile): Likewise.
11436         (free_all_objfiles): Use all_objfiles_safe.
11437         (objfile_purge_solibs): Likewise.
11438
11439 2019-01-09  Tom Tromey  <tom@tromey.com>
11440
11441         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11442         (expand_symtab_containing_pc, lookup_static_symbol)
11443         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11444         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11445         all_objfiles.
11446         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11447         * breakpoint.c (create_overlay_event_breakpoint)
11448         (create_longjmp_master_breakpoint)
11449         (create_std_terminate_master_breakpoint)
11450         (create_exception_master_breakpoint): Use all_objfiles.
11451         * linux-thread-db.c (try_thread_db_load_from_pdir)
11452         (has_libpthread): Use all_objfiles.
11453         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11454         * linespec.c (iterate_over_all_matching_symtabs)
11455         (search_minsyms_for_name): Use all_objfiles.
11456         * maint.c (maintenance_info_sections): Use all_objfiles.
11457         * main.c (captured_main_1): Use all_objfiles.
11458         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11459         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11460         * guile/scm-pretty-print.c
11461         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11462         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11463         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11464         (maintenance_print_msymbols): Use all_objfiles.
11465         * source.c (select_source_symtab): Use all_objfiles.
11466         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11467         * symfile.c (remove_symbol_file_command)
11468         (expand_symtabs_matching, map_symbol_filenames): Use
11469         all_objfiles.
11470         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11471         all_objfiles.
11472         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11473         * objc-lang.c (find_methods): Use all_objfiles.
11474         * objfiles.c (have_partial_symbols, have_full_symbols)
11475         (have_minimal_symbols, qsort_cmp)
11476         (default_iterate_over_objfiles_in_search_order): Use
11477         all_objfiles.
11478         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11479         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11480         (maintenance_check_psymtabs): Use all_objfiles.
11481         (ALL_PSYMTABS): Remove.
11482         * compile/compile-object-run.c (do_module_cleanup): Use
11483         all_objfiles.
11484         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11485         * cp-support.c (add_symbol_overload_list_qualified): Use
11486         all_objfiles.
11487         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11488         Use all_objfiles.
11489         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11490         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11491         all_objfiles.
11492         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11493         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11494         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11495         Uses all_objfiles.
11496         * solib.c (solib_read_symbols): Use all_objfiles
11497
11498 2019-01-09  Tom Tromey  <tom@tromey.com>
11499
11500         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11501         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11502         all_objfiles.
11503         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11504         * symmisc.c (print_symbol_bcache_statistics)
11505         (print_objfile_statistics, maintenance_print_objfiles)
11506         (maintenance_info_symtabs, maintenance_check_symtabs)
11507         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11508         all_objfiles.
11509         * source.c (forget_cached_source_info): Use all_objfiles.
11510         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11511         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11512         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11513         * objfiles.c (update_section_map): Use all_objfiles.
11514         (shared_objfile_contains_address_p): Likewise.
11515         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11516         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11517
11518 2019-01-09  Tom Tromey  <tom@tromey.com>
11519
11520         * common/next-iterator.h: New file.
11521         * objfiles.h (class all_objfiles): New.
11522         (struct objfile_iterator): New.
11523
11524 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11525
11526         * NEWS: Move the description of the changed "frame", "select-frame",
11527          and "info frame" commands to the Changed commands section.
11528
11529 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11530
11531         * gdbtypes.c (check_stub_method_group): Remove handling of old
11532         mangling schemes.
11533         * linespec.c (find_methods): Likewise.
11534         * stabsread.c (read_member_functions): Likewise.
11535         * valops.c (search_struct_method): Likewise.
11536         (value_struct_elt_for_reference): Likewise.
11537         * NEWS: Mention this change.
11538
11539 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11540
11541         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11542         print_source_lines.
11543         * source.c (print_source_lines_base): Update line number check.
11544         (print_source_lines): New function.
11545         (source_lines_range::source_lines_range): New function.
11546         * source.h (class source_lines_range): New class.
11547         (print_source_lines): New declaration.
11548
11549 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11550
11551         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11552
11553 2019-01-08  Tom Tromey  <tom@tromey.com>
11554             Simon Marchi  <simon.marchi@ericsson.com>
11555
11556         PR gdb/24060
11557         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11558         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11559         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11560         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11561         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11562         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11563
11564 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11565
11566         * source.c (select_source_symtab): Move header comment to
11567         declaration in source.h.
11568         (forget_cached_source_info_for_objfile): Likewise.
11569         (forget_cached_source_info): Likewise.
11570         (identify_source_line): Likewise.
11571         * source.h (identify_source_line): Move declaration from symtab.h
11572         and add comment from source.c
11573         (print_source_lines): Likewise.
11574         (forget_cached_source_info_for_objfile): Likewise.
11575         (forget_cached_source_info): Likewise.
11576         (select_source_symtab): Likewise.
11577         (enum print_source_lines_flag): Move definition from symtab.h.
11578         * symtab.h (identify_source_line): Move declaration to source.h.
11579         (print_source_lines): Likewise.
11580         (forget_cached_source_info_for_objfile): Likewise.
11581         (forget_cached_source_info): Likewise.
11582         (select_source_symtab): Likewise.
11583         (enum print_source_lines_flag): Move definition to source.h.
11584         * tui/tui-hooks.c: Add 'source.h' include.
11585
11586 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11587
11588         * source.c (print_source_lines_base): Handle requests to print
11589         reverse line number sequences, and guard against empty lines
11590         string.
11591
11592 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11593
11594         * source.c (print_source_lines_base): Fix skip of '\r' if next
11595         character is '\n'.
11596
11597 2019-01-06  Tom Tromey  <tom@tromey.com>
11598
11599         * c-exp.y (struct c_parse_state) <macro_original_text,
11600         expansion_obstack>: New member.
11601         (macro_original_text, expansion_obstack): Remove globals.
11602         (scan_macro_expansion, scanning_macro_expansion)
11603         (finished_macro_expansion): Update.
11604         (scan_macro_cleanup): Remove.
11605         (yylex, c_parse): Update.
11606
11607 2019-01-06  Tom Tromey  <tom@tromey.com>
11608
11609         * c-exp.y (struct c_parse_state) <strings>: New member.
11610         (operator_stoken): Update.
11611
11612 2019-01-06  Tom Tromey  <tom@tromey.com>
11613
11614         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11615         (union type_stack_elt) <typelist_val>: Now a pointer to
11616         std::vector.
11617         (type_stack_cleanup): Don't declare.
11618         (push_typelist): Update.
11619         * parse.c (pop_typelist): Return a std::vector.
11620         (push_typelist): Take a std::vector.
11621         (follow_types): Update.  Do not free args.
11622         (type_stack_cleanup): Remove.
11623         * c-exp.y (struct c_parse_state): New.
11624         (cpstate): New global.
11625         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11626         (nonempty_typelist): Update.
11627         (func_mod): Create a new vector.
11628         (c_parse): Create a c_parse_state.
11629         (check_parameter_typelist): Do not delete params.
11630         (function_method): Update.  Do not delete type_list.
11631
11632 2019-01-06  Tom Tromey  <tom@tromey.com>
11633
11634         PR gdb/28155:
11635         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11636         check_typedef.
11637         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11638         (print_return_value): Likewise.
11639
11640 2019-01-05  Tom Tromey  <tom@tromey.com>
11641
11642         * contrib/cleanup_check.py: Remove.
11643         * contrib/gcc-with-excheck: Remove.
11644         * contrib/exsummary.py: Remove.
11645         * contrib/excheck.py: Remove.
11646
11647 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11648
11649         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11650         NULL. Initialize tpprev to NULL instead of assigning it
11651         to NULL on the next statement.
11652         * windows-nat.c (windows_delete_thread): Remove check for
11653         main_thread_id before printing thread exit notifications.
11654         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11655         Remove thread ID check against main_thread_id.
11656         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11657         windows_delete_thread.
11658         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11659
11660 2019-01-04  Tom Tromey  <tom@tromey.com>
11661
11662         * compile/compile.c (_initialize_compile): Use upper case for
11663         metasyntactic variables.
11664         * symmisc.c (_initialize_symmisc): Use upper case for
11665         metasyntactic variables.
11666         * psymtab.c (_initialize_psymtab): Use upper case for
11667         metasyntactic variables.
11668         * demangle.c (demangle_command): Use upper case for metasyntactic
11669         variables.
11670         (_initialize_demangler): Likewise.
11671         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11672         variables.
11673
11674 2019-01-03  Tom Tromey  <tom@tromey.com>
11675
11676         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11677
11678 2019-01-03  Tom Tromey  <tom@tromey.com>
11679
11680         * python/py-symtab.c (salpy_str): Update.
11681         (struct salpy_sal_object) <symtab>: Now a PyObject.
11682         (salpy_dealloc): Update.
11683         (del_objfile_sal): Use gdbpy_ref.
11684
11685 2019-01-03  Tom Tromey  <tom@tromey.com>
11686
11687         * python/py-type.c (convert_field): Use new_reference.  Return
11688         gdbpy_ref.
11689         (make_fielditem): Return gdbpy_ref.
11690         (typy_fields): Update.
11691         (typy_getitem): Update.
11692         (field_name): Return gdbpy_ref.  Use new_reference.
11693         (typy_iterator_iternext): Update.
11694
11695 2019-01-03  Tom Tromey  <tom@tromey.com>
11696
11697         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11698
11699 2019-01-03  Tom Tromey  <tom@tromey.com>
11700
11701         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11702         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11703         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11704         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11705         (pspy_set_type_printers): Likewise.
11706         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11707         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11708         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11709         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11710         (objfpy_set_type_printers): Likewise.
11711
11712 2019-01-03  Tom Tromey  <tom@tromey.com>
11713
11714         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11715         (gdbpy_print_stack): Use gdbpy_err_fetch.
11716         * python/python-internal.h (class gdbpy_err_fetch): New class.
11717         (class gdbpy_enter) <m_error_type, m_error_value,
11718         m_error_traceback>: Remove.
11719         <m_error>: New member.
11720         (gdbpy_exception_to_string): Don't declare.
11721         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11722         * python/py-value.c (convert_value_from_python): Use
11723         gdbpy_err_fetch.
11724         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11725         gdbpy_exception_to_string.
11726         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11727         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11728         gdbpy_err_fetch.
11729
11730 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11731
11732         * linux-nat.c (delete_lwp_cleanup): Delete.
11733         (struct lwp_deleter): New struct.
11734         (lwp_info_up): New typedef.
11735         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11736         lwp_info_up.
11737
11738 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11739
11740         * linux-fork.c (class scoped_switch_fork_info): New class.
11741         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11742
11743 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11744
11745         * valops.c (find_overload_match): Remove use of null_cleanup, and
11746         calls to do_cleanups.
11747
11748 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11749
11750         * compile/compile-cplus-types.c
11751         (compile_cplus_instance::decl_name): Handle changes to
11752         cp_func_name.
11753         * cp-support.c (cp_func_name): Update header comment, update
11754         return type.
11755         * cp-support.h (cp_func_name): Update return type in declaration.
11756         * valops.c (find_overload_match): Move temp_func local to top
11757         level of function and change its type.  Use temp_func to hold and
11758         delete temporary string obtained from cp_func_name.
11759
11760 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11761
11762         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11763         gdb::char_vector, remove cleanup, and update uses of `msg`.
11764
11765 2019-01-03  Jim Wilson  <jimw@sifive.com>
11766
11767         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11768
11769 2019-01-02  Tom Tromey  <tom@tromey.com>
11770
11771         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11772         (tdesc_parse_xml): Remove cleanups.
11773         * target-descriptions.h (make_cleanup_free_target_description):
11774         Don't declare.
11775         (target_desc_deleter): New struct.
11776         (target_desc_up): New typedef.
11777         * target-descriptions.c (target_desc_deleter::operator()): Rename
11778         from free_target_description.
11779         (make_cleanup_free_target_description): Remove.
11780
11781 2019-01-02  Tom Tromey  <tom@tromey.com>
11782
11783         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11784         constructor, destructor.
11785         (linespec_parser): Remove typedef.
11786         (~linespec_parser): Rename from linespec_parser_delete.
11787         (linespec_lex_to_end, linespec_complete_label)
11788         (linespec_complete): Update.
11789         (decode_line_full): Remove cleanups.
11790         (decode_line_1): Update.
11791
11792 2019-01-02  Tom Tromey  <tom@tromey.com>
11793
11794         * python/python-internal.h (inferior_to_inferior_object): Change
11795         return type.
11796         * python/py-exitedevent.c (create_exited_event_object): Update.
11797         * python/py-inferior.c (inferior_to_inferior_object): Return
11798         gdbpy_ref.
11799         (python_new_inferior, python_inferior_deleted)
11800         (thread_to_thread_object, delete_thread_object)
11801         (build_inferior_list, gdbpy_selected_inferior): Update.
11802         * python/py-infthread.c (create_thread_object): Update.  Also fail
11803         if inferior_to_inferior_object fails.
11804
11805 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11806
11807         * inferior.h (class inferior) <displaced_step_state>: New field.
11808         * infrun.h (struct displaced_step_state): Move here from
11809         infrun.c.  Initialize fields, add constructor.
11810         <inf>: Remove field.
11811         <reset>: New method.
11812         * infrun.c (struct displaced_step_inferior_state): Move to
11813         infrun.h.
11814         (displaced_step_inferior_states): Remove.
11815         (get_displaced_stepping_state): Adust.
11816         (displaced_step_in_progress_any_inferior): Adjust.
11817         (displaced_step_in_progress_thread): Adjust.
11818         (displaced_step_in_progress): Adjust.
11819         (add_displaced_stepping_state): Remove.
11820         (get_displaced_step_closure_by_addr): Adjust.
11821         (remove_displaced_stepping_state): Remove.
11822         (infrun_inferior_exit): Call displaced_step_state.reset.
11823         (use_displaced_stepping): Don't check for NULL.
11824         (displaced_step_prepare_throw): Call
11825         get_displaced_stepping_state.
11826         (displaced_step_fixup): Don't check for NULL.
11827         (prepare_for_detach): Don't check for NULL.
11828
11829 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11830
11831         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11832          in case of call that did not complete.
11833
11834 2019-01-02  Andrey Utkin  <autkin@undo.io>
11835
11836         * symfile.c (find_separate_debug_file): Fix search of debug files for
11837         remote debuggee.
11838
11839 2019-01-02  Tom Tromey  <tom@tromey.com>
11840
11841         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11842         indentation.
11843         * python/py-frame.c (frapy_older): Remove cast.
11844         (frapy_newer): Likewise.
11845         * python/py-breakpoint.c (local_setattro): Remove cast.
11846         * python/py-arch.c (archpy_name): Remove local variable.
11847         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11848
11849 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11850
11851         * unittests/basic_string_view/element_access/char/empty.cc:
11852         Fix year range in copyright header.
11853
11854 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11855
11856         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11857         Delete.
11858         <operator==>: Update with for removed field.
11859         <hash>: Likewise.
11860         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11861         <isa_features>: ...this.
11862         <abi_features>: New field.
11863         (riscv_isa_flen): Update comment.
11864         (riscv_abi_xlen): New declaration.
11865         (riscv_abi_flen): New declaration.
11866         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11867         isa_features.
11868         (riscv_abi_xlen): New function.
11869         (riscv_isa_flen): Update to get answer from isa_features.
11870         (riscv_abi_flen): New function.
11871         (riscv_has_fp_abi): Update to get answer from abi_features.
11872         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11873         xlen and flen.
11874         (riscv_call_info) <xlen, flen>: Update comment.
11875         (riscv_call_arg_struct): Remove invalid assertions
11876         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11877         is removed.
11878         (riscv_gdbarch_init): Gather isa features and abi features
11879         separately, ensure both match on the gdbarch when reusing an old
11880         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11881         a target with 64-bit float hardware.
11882
11883 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11884
11885         * source.c (search_command_helper): Stop reverse search
11886         when line 1 has been searched.
11887
11888 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11889
11890         * record-full.c (record_full_base_target::close): Rewrite
11891         record_full_core_buf_list free logic.
11892
11893 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11894
11895         * break-catch-syscall.c (print_one_catch_syscall): xfree
11896         the last text.
11897
11898 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11899
11900         * top.c (print_gdb_version): Update Copyright year in version
11901         message.
11902
11903 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11904
11905         Update copyright year range in all GDB files.
11906
11907 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11908
11909         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11910
11911 For older changes see ChangeLog-2018.
11912 \f
11913 Local Variables:
11914 mode: change-log
11915 left-margin: 8
11916 fill-column: 74
11917 version-control: never
11918 coding: utf-8
11919 End:
11920