gdb/ChangeLog

   1 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
   4         Change type to gdb::optional<block_enum>.
   5         (dw2_symtab_iter_init): Change block_index parameter type
   6         to gdb::optional<block_enum>.
   7         (dw2_lookup_symbol): Change block_index parameter
   8         type to block_enum.c
   9         (dw2_debug_names_lookup_symbol): Likewise.
  10         * psymtab.c (psym_lookup_symbol): Likewise.
  11         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
  12         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
  13         Likewise.
  14
  15 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
  16
  17         * defs.h (relocate_gdb_directory): Change int to bool in
  18         signature and rename flag to relocatable.
  19         * main.c (relocate_path): Likewise.
  20         (relocate_gdb_directory): Likewise.
  21
  22 2019-09-06  Alan Modra  <amodra@gmail.com>
  23
  24         * coffread.c (coff_symfile_read): Constify filename variable.
  25         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
  26         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
  27         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
  28         * solib.c (reload_shared_libraries_1): Likewise.
  29         * symfile.c (reread_symbols): Likewise.
  30         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
  31         * solib-darwin.c (darwin_bfd_open): Likewise.
  32         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
  33
  34 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  35
  36         * psymtab.c (print_partial_symbols): Handle missing domain_enum
  37         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
  38
  39 2019-09-03  Tom Tromey  <tromey@adacore.com>
  40
  41         * ada-valprint.c (ada_val_print_num): Don't recurse for range
  42         types.
  43         (has_negatives): Unbias a range type bound.
  44         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
  45         * gdbtypes.c (operator==): Handle new field.
  46         (create_range_type): Add "bias" parameter.
  47         (create_static_range_type, resolve_dynamic_range): Update.
  48         * gdbtypes.h (struct range_bounds) <bias>: New member.
  49         (create_range_type): Add bias parameter.
  50         * printcmd.c (print_scalar_formatted): Unbias range types.
  51         * value.c (unpack_long): Unbias range types.
  52         (pack_long): Bias range types.
  53
  54 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  55
  56         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
  57         probe arguments.
  58
  59 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  60
  61         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
  62         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
  63         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
  64         (compile_probe_arg): Likewise.
  65         * probe.h (get_argument_count): Likewise.
  66         * solib-svr4.c (solib_event_probe_action): Likewise.
  67         * stap-probe.c (stap_probe::get_argument_count): Likewise.
  68
  69 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  70
  71         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
  72         code to here...
  73         (svr4_create_solib_event_breakpoints): ...from here.
  74
  75 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
  76
  77         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
  78         suffix from warning message.
  79
  80 2019-08-30  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-winsource.h (struct tui_source_window_base)
  83         <refresh_all>: Don't declare.
  84         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
  85         Remove.
  86         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
  87         tui_show_locator_content.
  88         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
  89         declare.
  90         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
  91         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
  92         declare.
  93
  94 2019-08-30  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
  97
  98 2019-08-30  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 101         Remove unnecessary forward declarations.
 102
 103 2019-08-30  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 106         rerender.
 107         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 108         tui_show_locator_content.
 109
 110 2019-08-30  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 113         (tui_locator_window::rerender): Rewrite using body of previous
 114         tui_show_locator_content.
 115
 116 2019-08-30  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 119         set_locator_fullname>: New methods.
 120         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 121         Rename from tui_set_locator_fullname.
 122         (tui_locator_window::set_locator_info): Rename from
 123         tui_set_locator_info.  Return bool.
 124         (tui_update_locator_fullname, tui_show_frame_info): Update.
 125
 126 2019-08-30  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 129
 130 2019-08-30  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 133         call touchwin.
 134
 135 2019-08-30  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-wingeneral.c (box_win): Assume win_info and
 138         win_info->handle cannot be NULL.
 139
 140 2019-08-30  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 143         refresh_window>: Declare.
 144         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 145         resize.
 146         (tui_data_item_window::rerender): Rename from
 147         tui_display_register.
 148         (tui_data_item_window::refresh_window): New method.
 149         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 150         no-op.
 151
 152 2019-08-30  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 155         regs_column_count, current_group>: Move later.  Now private.
 156         <get_current_group>: New method.
 157         * tui/tui-regs.c (tui_reg_command): Update.
 158         * tui/tui-layout.c (tui_set_layout): Update.
 159
 160 2019-08-30  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 163         (tui_data_window::rerender): Don't call
 164         check_and_display_highlight_if_needed.
 165         (tui_data_window::refresh_all): Remove call to
 166         erase_data_content.
 167
 168 2019-08-30  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 171         (tui_data_window::display_registers_from)
 172         (tui_data_window::display_reg_element_at_line)
 173         (tui_data_window::display_registers_from_line): Remove checks of
 174         "empty".
 175
 176 2019-08-30  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 179         Don't declare.
 180         * tui/tui-regs.c (tui_data_window::show_registers): Call
 181         rerender.
 182         (tui_data_window::rerender): Rename from display_all_data.
 183         (tui_data_window::rerender): Remove old implementation.
 184
 185 2019-08-30  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 188         text.
 189         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 190
 191 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 192             Sergio Durigan Junior  <sergiodj@redhat.com>
 193
 194         PR win32/24284
 195         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 196
 197 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 198
 199         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 200         when searching for types.
 201
 202 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 203
 204         * f-lang.c (f_language_defn): Use f_print_typedef.
 205         * f-lang.h (f_print_typedef): Declare.
 206         * f-typeprint.c (f_print_typedef): Define.
 207
 208 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 209
 210         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 211
 212 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 213
 214         * cli/cli-utils.c (info_print_options_defs): Delete.
 215         (make_info_print_options_def_group): Delete.
 216         (extract_info_print_options): Delete.
 217         (info_print_command_completer): Delete.
 218         (info_print_args_help): Add extra parameter, and optionally
 219         include text about -n flag.
 220         * cli/cli-utils.h (struct info_print_options): Delete.
 221         (extract_info_print_options): Delete declaration.
 222         (info_print_command_completer): Delete declaration.
 223         (info_print_args_help): Add extra parameter, extend header
 224         comment.
 225         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 226         search_symbols.
 227         * stack.c (struct info_print_options): New type.
 228         (info_print_options_defs): New file scoped variable.
 229         (make_info_print_options_def_group): New static function.
 230         (info_print_command_completer): New static function.
 231         (info_locals_command): Update to use new local functions.
 232         (info_args_command): Likewise.
 233         (_initialize_stack): Add extra parameter to calls to
 234         info_print_args_help.
 235         * symtab.c (search_symbols): Add extra parameter, use this to
 236         possibly excluse non-debug symbols.
 237         (symtab_symbol_info): Add extra parameter, which is passed on to
 238         search_symbols.
 239         (struct info_print_options): New type.
 240         (info_print_options_defs): New file scoped variable.
 241         (make_info_print_options_def_group): New static function.
 242         (info_print_command_completer): New static function.
 243         (info_variables_command): Update to use local functions, and pass
 244         extra parameter through to symtab_symbol_info.
 245         (info_functions_command): Likewise.
 246         (info_types_command): Pass additional argument through to
 247         symtab_symbol_info.
 248         (rbreak_command): Pass extra argument to search_symbols.
 249         (_initialize_symtab): Add extra arguments for calls to
 250         info_print_args_help, and update help text for 'info variables',
 251         'whereis', and 'info functions' commands.
 252         * symtab.h (search_symbols): Add extra argument to declaration.
 253         * NEWS: Mention new flags.
 254
 255 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 256
 257         * symtab.c (lookup_static_symbol): Call the new function (and move
 258         it down to be next to lookup_global_symbol).
 259         (struct global_sym_lookup_data): Add block_enum member and rename to...
 260         (struct global_or_static_sym_lookup_data): ...this.
 261         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 262         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 263         (lookup_symbol_global_or_static_iterator_cb): ...this.
 264         (lookup_global_or_static_symbol): New function.
 265         (lookup_global_symbol): Call new function.
 266
 267 2019-08-26  Tom de Vries  <tdevries@suse.de>
 268
 269         PR c++/24852
 270         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 271         when pc_probe.prob == NULL.
 272
 273 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 274
 275         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 276         variable symbol_linkage to symbol_linkage_.
 277
 278 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 279
 280         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 281         represent whether the symbol is static, dynamic, or we don't
 282         know.
 283
 284 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 285
 286         * gdb/rx-tdep.c (rx_register_names): New.
 287         (rx_register_name): Delete.
 288         (rx_psw_type): Delete.
 289         (rx_fpsw_type): Delete.
 290         (rx_register_type): Delete.
 291         (rx_gdbarch_init): Convert target-descriptions.
 292         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 293         * gdb/features/Makefile: Add rx.xml.
 294         * gdb/features/rx.xml: New.
 295         * gdb/features/rx.c: Generated.
 296         * gdb/NEWS: Mention target description support.
 297
 298 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 299
 300         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 301         *slot_ptr.
 302
 303 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 304
 305         * configure.ac: Don't check for 'dlfcn.h' (moved to
 306         gdbsupport/common.m4).
 307         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 308         'gdbsupport/'.
 309         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 310         * compile/compile-c-support.c: Include
 311         'gdbsupport/gdb-dlfcn.h'.
 312         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 313         * gdb-dlfcn.c: Move to...
 314         * gdbsupport/gdb-dlfcn.c: ... here.
 315         * gdb-dlfcn.h: Move to...
 316         * gdbsupport/gdb-dlfcn.h: ... here.
 317
 318 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 319
 320         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 321         the offset field signed.
 322
 323 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 324
 325         * python/lib/gdb/__init__.py (_execute_file): New function.
 326         * python/python.c (python_run_simple_file): Call gdb._execute_file
 327         on Windows.
 328
 329 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 330
 331         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 332         all uses as this was never set to anything but a zero value.
 333
 334 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 335
 336         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 337
 338 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 339
 340         * tui/tui-data.h (tui_gen_win_info): Add an =default
 341         move constructor, required by some GCC versions.
 342
 343 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 344
 345         * go32-nat.c (go32_sysinfo): Add hygon_p.
 346
 347 2019-08-20  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 350         line_from_reg_element_no, first_reg_element_no_inline,
 351         display_all_data, delete_data_content_windows,
 352         erase_data_content>: Now private.
 353
 354 2019-08-20  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 357         (tui_unhighlight_win, tui_highlight_win)
 358         (tui_win_info::make_window): Update.
 359         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 360
 361 2019-08-20  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 364         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 365         (MAX_PID_WIDTH): Move to tui-stack.c.
 366         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 367         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 368         (MAX_PID_WIDTH): Move from tui-data.h.
 369
 370 2019-08-20  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 373         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 374         (box_win): Update.
 375         (tui_gen_win_info::make_window): Rename from tui_make_window.
 376         (tui_win_info::make_window): New method.
 377         (tui_gen_win_info::make_visible): Update.
 378         * tui/tui-source.c (tui_source_window::set_contents): Update.
 379         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 380         (tui_data_window::display_registers_from): Update.
 381         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 382         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 383         Declare.
 384         <can_box>: Remove.
 385         <title>: Remove.
 386         (struct tui_win_info) <make_window>: Declare.
 387         <can_box>: Now virtual.
 388         <title>: New member.
 389         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 390         * tui/tui-command.c (tui_cmd_window::resize): Update.
 391
 392 2019-08-20  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 395         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 396         (tui_data_window::check_register_values): Update.
 397
 398 2019-08-20  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-regs.h (struct tui_data_window): Use
 401         DISABLE_COPY_AND_ASSIGN.
 402         <regs_content>: Change type, removing unique_ptr.
 403         <tui_data_window>: Add move constructor.
 404         * tui/tui-regs.c (tui_data_window::show_registers)
 405         (tui_data_window::show_register_group)
 406         (tui_data_window::display_registers_from)
 407         (tui_data_window::display_registers_from)
 408         (tui_data_window::first_data_item_displayed)
 409         (tui_data_window::delete_data_content_windows)
 410         (tui_data_window::rerender, tui_data_window::refresh_window)
 411         (tui_data_window::check_register_values): Update.
 412
 413 2019-08-20  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 416         show_register_group>: Declare.
 417         (tui_show_register_group): Don't declare.
 418         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 419         tui_show_registers.
 420         (tui_data_window::show_register_group): Rename from
 421         tui_show_register_group.
 422         (tui_data_window::check_register_values, tui_reg_command):
 423         Update.
 424         * tui/tui-layout.c (tui_set_layout): Update.
 425
 426 2019-08-20  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 429         Declare.
 430         (tui_check_register_values): Don't declare.
 431         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 432         from tui_check_register_values.
 433         * tui/tui-hooks.c (tui_register_changed): Update.
 434
 435 2019-08-20  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-regs.c (tui_reg_layout): Move later.
 438         (tui_show_registers): Don't enable TUI mode or change layout.
 439
 440 2019-08-20  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-regs.h (struct tui_data_item_window)
 443         <~tui_data_item_window>: Remove.
 444         <content>: Now a unique_xmalloc_ptr.
 445         * tui/tui-regs.c (tui_register_format): Return a
 446         unique_xmalloc_ptr.
 447         (tui_get_register): Update.
 448         (~tui_data_item_window): Remove.
 449         (tui_data_window::display_registers_from, tui_display_register):
 450         Update.
 451         * tui/tui-io.h (tui_expand_tabs): Update.
 452         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 453         Remove "col" parameter.
 454
 455 2019-08-20  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 458         field.
 459         * tui/tui-regs.c (~tui_data_item_window): Update.
 460
 461 2019-08-20  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 464         earlier.
 465
 466 2019-08-20  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 469
 470 2019-08-20  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-source.h (struct tui_source_window): Update.
 473         * tui/tui-regs.c (tui_show_registers): Update.
 474         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 475         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 476         (NO_REGS_STRING): Remove defines.
 477
 478 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 479
 480         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 481         unnecessary thread walk if remote doesn't support the packet.
 482
 483 2019-08-19  Tom Tromey  <tromey@adacore.com>
 484
 485         * python/py-value.c (value_has_field): Fix indentation.
 486
 487 2019-08-19  Tom Tromey  <tromey@adacore.com>
 488
 489         * printcmd.c (do_one_display, info_display_command): Update.
 490         * block.h (contained_in): Return bool.  Add allow_nested
 491         parameter.
 492         * block.c (contained_in): Return bool.  Add allow_nested
 493         parameter.
 494
 495 2019-08-19  Tom Tromey  <tom@tromey.com>
 496
 497         * configure: Rebuild.
 498         * configure.ac: Disallow the combination of -static-libstdc++ and
 499         source highlight.
 500         * source-cache.c (get_language_name): Handle rust.
 501         (source_cache::get_source_lines): Ignore highlighting exceptions.
 502
 503 2019-08-16  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 506         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 507         (struct tui_source_window_base) <make_visible, refresh_window,
 508         resize>: Remove methods.
 509         <execution_info>: Remove field.
 510         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 511         (tui_show_source_line, tui_source_window_base)
 512         (~tui_source_window_base): Update.
 513         (tui_source_window_base::resize)
 514         (tui_source_window_base::make_visible)
 515         (tui_source_window_base::refresh_window): Remove.
 516         (tui_source_window_base::update_exec_info): Update.
 517         * tui/tui-source.c (tui_source_window::set_contents): Update.
 518         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 519
 520 2019-08-16  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 523         deprecated_query_hook.
 524
 525 2019-08-16  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 528         (tui_update_source_windows_with_line): Update.
 529         * tui/tui-source.h (struct tui_source_window)
 530         <show_symtab_source>: Declare.
 531         (tui_show_symtab_source): Don't declare.
 532         * tui/tui-source.c (tui_show_symtab_source): Rename from
 533         tui_show_symtab_source.
 534
 535 2019-08-16  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui-winsource.h (struct tui_source_window_base)
 538         <set_contents>: Declare.
 539         * tui/tui-winsource.c
 540         (tui_source_window_base::update_source_window_as_is): Update.
 541         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 542         Declare.
 543         (tui_set_source_content): Don't declare.
 544         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 545         tui_set_source_content.
 546         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 547         Declare.
 548         (tui_set_disassem_content): Don't declare.
 549         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 550         tui_set_disassem_content.
 551
 552 2019-08-16  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-winsource.h (struct tui_source_window_base)
 555         <update_breakpoint_info>: Declare.
 556         (tui_update_breakpoint_info): Don't declare.
 557         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 558         (tui_update_all_breakpoint_info): Update.
 559         (tui_source_window_base::update_breakpoint_info): Rename from
 560         tui_update_breakpoint_info.
 561         (tui_source_window_base::update_exec_info): Update.
 562
 563 2019-08-16  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-winsource.h (struct tui_source_window_base)
 566         <update_source_window>: Declare.
 567         (tui_update_source_window): Don't declare.
 568         * tui/tui-winsource.c
 569         (tui_source_window_base::update_source_window): Rename from
 570         tui_update_source_window.
 571         (tui_source_window_base::rerender): Update.
 572         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 573         * tui/tui-disasm.c (tui_show_disassem)
 574         (tui_show_disassem_and_update_source)
 575         (tui_disasm_window::maybe_update): Update.
 576
 577 2019-08-16  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-winsource.h (struct tui_source_window_base)
 580         <update_source_window_as_is>: Declare.
 581         (tui_update_source_window_as_is): Don't declare.
 582         * tui/tui-winsource.c (tui_update_source_window): Update
 583         (tui_source_window_base::update_source_window_as_is): Rename from
 584         tui_update_source_window_as_is.
 585         (tui_source_window_base::refill): Update.
 586         * tui/tui-source.c (tui_show_symtab_source): Update.
 587         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 588         Update.
 589
 590 2019-08-16  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-winsource.h (tui_update_source_window)
 593         (tui_update_source_window_as_is): Remove "noerror" parameter.
 594         * tui/tui-winsource.c (tui_update_source_window)
 595         (tui_update_source_window_as_is): Remove "noerror" parameter.
 596         (tui_update_source_windows_with_addr)
 597         (tui_update_source_windows_with_line)
 598         (tui_source_window_base::rerender)
 599         (tui_source_window_base::refill): Update.
 600         * tui/tui-source.h (tui_set_source_content)
 601         (tui_show_symtab_source): Remove "noerror" parameter.
 602         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 603         parameter.
 604         (tui_show_symtab_source): Likewise.
 605         (tui_source_window::maybe_update): Update.
 606         * tui/tui-disasm.c (tui_show_disassem)
 607         (tui_show_disassem_and_update_source)
 608         (tui_disasm_window::do_scroll_vertical)
 609         (tui_disasm_window::maybe_update): Update.
 610
 611 2019-08-16  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui.c (tui_is_window_visible): Update.
 614         * tui/tui-wingeneral.c (tui_make_window)
 615         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 616         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 617         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 618         (tui_set_win_height_command, parse_scrolling_args): Update.
 619         * tui/tui-source.c (tui_source_window::style_changed): Update.
 620         * tui/tui-regs.c (tui_show_registers)
 621         (tui_data_window::first_data_item_displayed)
 622         (tui_data_window::delete_data_content_windows)
 623         (tui_check_register_values, tui_reg_command): Update.
 624         * tui/tui-disasm.c (tui_show_disassem): Update.
 625         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 626         method.
 627         <is_visible>: Remove field.
 628         * tui/tui-data.c (tui_next_win, tui_prev_win)
 629         (tui_delete_invisible_windows): Update.
 630
 631 2019-08-16  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-winsource.h (struct tui_source_window_base)
 634         <m_has_locator>: Remove.
 635         * tui/tui-layout.c (show_source_disasm_command, show_data)
 636         (show_source_or_disasm_and_command): Update.
 637
 638 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 639
 640         * NEWS (Other MI changes): New subsection.
 641         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 642         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 643         * arch-utils.c (default_get_pc_address_flags): New function.
 644         * arch-utils.h (default_get_pc_address_flags): New declaration.
 645         * gdbarch.sh: Add get_pc_address_flags.
 646         * gdbarch.c: Regenerate.
 647         * gdbarch.h: Likewise.
 648         * stack.c (print_pc): New function.
 649         (print_frame_info) (print_frame): Call print_pc.
 650
 651 2019-08-16  Tom de Vries  <tdevries@suse.de>
 652
 653         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 654         print_objfile_section_info.
 655
 656 2019-08-15  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 659         calling update_cmdwin_start_line.
 660         * tui/tui-winsource.h (struct tui_source_window_base)
 661         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 662         <rerender>: Declare.
 663         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 664         Call rerender.
 665         (tui_source_window_base::set_new_height): Remove.
 666         (tui_source_window_base::rerender): Rename from
 667         do_make_visible_with_new_height.
 668         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 669         resize method.
 670         (tui_win_info::make_invisible_and_set_new_height)
 671         (tui_win_info::make_visible_with_new_height): Remove.
 672         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 673         Declare.
 674         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 675         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 676         do_make_visible_with_new_height>: Don't declare.
 677         <rerender>: Declare.
 678         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 679         set_new_height.
 680         (tui_data_window::do_make_visible_with_new_height): Remove.
 681         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 682         call tui_show_locator_content.
 683         (tui_gen_win_info::resize): Call rerender.
 684         (show_source_or_disasm_and_command): Don't call
 685         tui_show_locator_content.
 686         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 687         method.
 688         (struct tui_win_info) <rerender>: Declare.
 689         <set_new_height, make_invisible_and_set_new_height,
 690         make_visible_with_new_height>: Don't declare.
 691         * tui/tui-data.c (tui_win_list::rerender): New method.
 692         * tui/tui-command.h (struct tui_cmd_window)
 693         <do_make_visible_with_new_height>: Don't declare.
 694         * tui/tui-command.c
 695         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 696
 697 2019-08-15  Tom Tromey  <tromey@adacore.com>
 698
 699         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 700         * ada-lang.c (ada_enum_name): Likewise.
 701
 702 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 703
 704         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 705         leading underscore.
 706         (GdbOutputErrorFile): Likewise.
 707         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 708         accordingly.
 709         (execute_unwinders): Rename to have a leading underscore.
 710         (auto_load_packages): Likewise.
 711         (global scope): Adjust call to auto_load_packages accordingly.
 712         (GdbSetPythonDirectory): Likewise.
 713         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 714         instead of execute_unwinders.
 715
 716 2019-08-15  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 719         (show_data): Don't change window visibility.
 720         (tui_gen_win_info::resize): Remove special case for command
 721         window.  Use wresize, when available.
 722         (show_source_or_disasm_and_command): Don't change window
 723         visibility.
 724         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 725         <make_visible>: New method.
 726         * tui/tui-command.c (tui_cmd_window::resize): New method.
 727
 728 2019-08-15  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 731         (struct tui_source_windows): New.
 732         * tui/tui-winsource.c (tui_display_main): Update.
 733         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 734         (new_height_ok, parse_scrolling_args): Update.
 735         * tui/tui-layout.c (show_layout, show_data): Update.
 736         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 737         (tui_add_to_source_windows): Don't declare.
 738         * tui/tui-data.c (source_windows, tui_source_windows)
 739         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 740
 741 2019-08-15  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 744         Rename from reset.
 745         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 746         * tui/tui-layout.c (show_source_disasm_command, show_data):
 747         Update.
 748         (tui_gen_win_info::resize): Rename.
 749         (show_source_or_disasm_and_command): Update.
 750         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 751         reset.
 752
 753 2019-08-15  Tom Tromey  <tom@tromey.com>
 754
 755         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 756         * tui/tui-interp.c (tui_interp::init): Don't call
 757         tui_initialize_static_data.
 758         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 759
 760 2019-08-15  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 763         examine tui_win_list.
 764
 765 2019-08-15  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 768         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 769         tui_clear_source_content.
 770         (tui_clear_source_content): Remove.
 771         (tui_source_window_base::do_erase_source_content): Hoist call to
 772         content.clear().
 773         * tui/tui-stack.c (tui_show_frame_info): Don't call
 774         tui_clear_source_content.
 775
 776 2019-08-15  Tom Tromey  <tom@tromey.com>
 777
 778         * tui/tui-winsource.h (struct tui_source_window_base)
 779         <do_erase_source_content>: New method.
 780         <erase_source_content>: New method.
 781         (tui_erase_source_content): Don't declare.
 782         * tui/tui-winsource.c (tui_clear_source_content): Update.
 783         (tui_source_window_base::do_erase_source_content): Rename from
 784         tui_erase_source_content.
 785         (tui_source_window_base::show_source_content): Update.
 786         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 787         * tui/tui-source.h (struct tui_source_window)
 788         <erase_source_content>: New method.
 789         * tui/tui-disasm.h (struct tui_disasm_window)
 790         <erase_source_content>: New method.
 791
 792 2019-08-15  Tom Tromey  <tom@tromey.com>
 793
 794         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 795         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 796         constructor.
 797         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 798         * tui/tui-source.c (tui_set_source_content): Update.
 799         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 800
 801 2019-08-15  Tom Tromey  <tom@tromey.com>
 802
 803         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 804         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 805         tui-source.c.
 806         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 807         Declare.
 808         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 809         method.
 810         (tui_source_window::maybe_update): Update.
 811
 812 2019-08-15  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 815         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 816         tui-disasm.c.
 817         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 818         Declare.
 819         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 820         method.
 821         (tui_disasm_window::maybe_update): Update.
 822
 823 2019-08-15  Tom Tromey  <tom@tromey.com>
 824
 825         * tui/tui-winsource.h (struct tui_source_window_base)
 826         <maybe_update>: Declare.
 827         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 828         method.
 829         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 830         Declare.
 831         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 832         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 833         Declare.
 834         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 835
 836 2019-08-15  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 839
 840 2019-08-15  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-wingeneral.c: Include tui-stack.h.
 843         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 844         (struct tui_locator_window): Move from tui-data.h.
 845         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 846         (tui_initialize_static_data): Move from tui-data.c.
 847         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 848         (struct tui_locator_window): Move to tui-stack.c.
 849         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 850         (tui_initialize_static_data): Move to tui-stack.c.
 851
 852 2019-08-15  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-layout.c (show_source_disasm_command)
 855         (show_source_or_disasm_and_command): Use make_visible method, not
 856         tui_make_window.
 857         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 858         Remove.
 859
 860 2019-08-15  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-wingeneral.h (tui_make_window): Update.
 863         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 864         parameter.
 865         (tui_gen_win_info::make_visible): Update.
 866         * tui/tui-regs.c (tui_data_window::display_registers_from):
 867         Update.
 868         * tui/tui-layout.c (show_source_disasm_command)
 869         (show_source_or_disasm_and_command): Update.
 870         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 871         (enum tui_box): Remove.
 872         (struct tui_win_info) <can_box>: New method.
 873         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 874         method.
 875
 876 2019-08-15  Tom de Vries  <tdevries@suse.de>
 877
 878         * linux-nat-trad.c: Include gdbarch.h.
 879
 880 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 881
 882         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 883         register sizes.
 884
 885 2019-08-14  Tom Tromey  <tromey@adacore.com>
 886
 887         * darwin-nat.c: Include gdbarch.h.
 888         * darwin-nat-info.c: Include gdbarch.h.
 889
 890 2019-08-13  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 893         Remove.
 894         * tui/tui-data.c (tui_initialize_static_data): Update.
 895
 896 2019-08-13  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-winsource.h (struct tui_exec_info_window)
 899         <~tui_exec_info_window, maybe_allocate_content, get_content,
 900         m_content>: Remove.
 901         (struct tui_source_window_base) <set_exec_info_content,
 902         show_exec_info_content>: Don't declare.
 903         * tui/tui-winsource.c
 904         (tui_exec_info_window::maybe_allocate_content): Remove.
 905         (tui_source_window_base::update_exec_info): Rename from
 906         set_exec_info_content.
 907         (tui_source_window_base::show_exec_info_content)
 908         (tui_source_window_base::update_exec_info): Remove.
 909
 910 2019-08-13  Tom Tromey  <tom@tromey.com>
 911
 912         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 913         declare.
 914         * tui/tui-winsource.c (tui_update_source_window_as_is)
 915         (tui_update_source_windows_with_addr, tui_erase_source_content):
 916         Update.
 917         (tui_clear_exec_info_content): Remove.
 918
 919 2019-08-13  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 922         declare.
 923         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 924         call tui_erase_exec_info_content.
 925         (tui_clear_exec_info_content): Rename from
 926         tui_erase_exec_info_content.
 927         (tui_clear_exec_info_content): Delete.
 928
 929 2019-08-13  Tom Tromey  <tom@tromey.com>
 930
 931         * tui/tui-winsource.h (struct tui_source_window_base)
 932         <show_exec_info_content>: Declare.
 933         (tui_show_exec_info_content): Don't declare.
 934         * tui/tui-winsource.c
 935         (tui_source_window_base::show_exec_info_content): Rename from
 936         tui_show_exec_info_content.
 937         (tui_source_window_base::update_exec_info): Update.
 938
 939 2019-08-13  Tom Tromey  <tom@tromey.com>
 940
 941         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 942         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 943         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 944         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 945         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 946         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 947         ... here.
 948
 949 2019-08-13  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui-winsource.h (struct tui_source_window_base)
 952         <update_exec_info>: Declare.
 953         (tui_update_exec_info): Don't declare.
 954         * tui/tui-winsource.c (tui_update_source_window_as_is)
 955         (tui_source_window_base::refresh_all)
 956         (tui_update_all_breakpoint_info): Update.
 957         (tui_source_window_base::update_exec_info): Rename from
 958         tui_update_exec_info.
 959         * tui/tui-stack.c (tui_show_frame_info): Update.
 960
 961 2019-08-13  Tom Tromey  <tom@tromey.com>
 962
 963         * tui/tui-winsource.h (struct tui_source_window_base)
 964         <set_exec_info_content>: Declare.
 965         (tui_set_exec_info_content): Don't declare.
 966         * tui/tui-winsource.c
 967         (tui_source_window_base::set_exec_info_content): Rename from
 968         tui_set_exec_info_content.
 969         (tui_update_exec_info): Update.
 970
 971 2019-08-13  Tom Tromey  <tom@tromey.com>
 972
 973         * tui/tui-winsource.h (struct tui_source_window_base)
 974         <show_source_content>: Declare.
 975         (tui_show_source_content): Don't declare.
 976         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 977         (tui_source_window_base::show_source_content): Rename from
 978         tui_show_source_content.
 979         (tui_source_window_base::refresh_all): Update.
 980         * tui/tui-layout.c (show_source_disasm_command)
 981         (show_source_or_disasm_and_command): Update.
 982
 983 2019-08-13  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-winsource.c (tui_erase_source_content)
 986         (tui_show_source_content, tui_source_window_base::refresh_all):
 987         Update.
 988         * tui/tui-wingeneral.h
 989         (tui_check_and_display_highlight_if_needed): Don't declare.
 990         * tui/tui-wingeneral.c
 991         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 992         check_and_display_highlight_if_needed.
 993         * tui/tui-win.c (tui_rehighlight_all)
 994         (tui_win_info::make_visible_with_new_height): Update.
 995         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 996         (tui_data_window::erase_data_content)
 997         (tui_data_window::display_all_data): Update.
 998         * tui/tui-data.h (struct tui_win_info)
 999         <check_and_display_highlight_if_needed>: Declare.
1000
1001 2019-08-13  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-win.c (tui_resize_all): Call
1004         tui_delete_invisible_windows.
1005         * tui/tui-layout.c (show_layout): Call
1006         tui_delete_invisible_windows.
1007         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1008         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1009
1010 2019-08-13  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1013         tui_add_win_to_layout.
1014
1015 2019-08-13  Tom Tromey  <tom@tromey.com>
1016
1017         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1018         * tui/tui-layout.c (tui_default_win_height): Now static.
1019
1020 2019-08-13  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1023         single switch.
1024         (show_source_disasm_command, show_source_or_disasm_and_command):
1025         Don't check current layout.
1026
1027 2019-08-13  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-wingeneral.c (make_all_visible): Remove.
1030         (tui_make_all_invisible): Simplify.
1031         * tui/tui-layout.c (tui_make_all_invisible): Move from
1032         tui-wingeneral.c; simplify.
1033         (show_layout): Hoist call to tui_make_all_invisible.
1034         (show_data): Don't call tui_make_all_invisible.
1035
1036 2019-08-13  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1039         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1040
1041 2019-08-13  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1044         tui-data.c.
1045         (show_source_disasm_command, show_data)
1046         (show_source_or_disasm_and_command): Don't use
1047         tui_set_current_layout_to.
1048         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1049         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1050         tui-layout.c.
1051         (tui_set_current_layout_to): Remove.
1052
1053 2019-08-13  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-layout.c (tui_set_layout): Update.
1056         * tui/tui-data.h (struct tui_layout_def): Remove.
1057         (tui_layout_def): Don't declare.
1058         * tui/tui-data.c (layout_def): Remove.
1059         (tui_layout_def): Remove.
1060
1061 2019-08-13  Tom Tromey  <tom@tromey.com>
1062
1063         * tui/tui-winsource.h (struct tui_source_window_base)
1064         <clear_detail>: No longer "override".
1065         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1066         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1067         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1068         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1069         Remove.
1070         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1071
1072 2019-08-13  Tom Tromey  <tromey@adacore.com>
1073
1074         * tracepoint.c: Don't include readline.h or history.h.
1075
1076 2019-08-12  Tom Tromey  <tom@tromey.com>
1077
1078         * configure: Rebuild.
1079         * configure.ac: Check for readline 7.
1080         * NEWS: Mention readline 7 requirement.
1081         * README: Update.
1082
1083 2019-08-12  Tom Tromey  <tom@tromey.com>
1084
1085         * mingw-hdep.c (gdb_select): Remove readline hack.
1086
1087 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1088
1089         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1090         when the function fails.
1091
1092 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1093
1094         * s390-tdep.c (s390_type_align): New function.
1095         (s390_gdbarch_init): Set it as type_align gdbarch method.
1096
1097 2019-08-09  Tom de Vries  <tdevries@suse.de>
1098
1099         PR gdb/24591
1100         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1101         pc_low with relocation offset.
1102
1103 2019-08-07  Tom Tromey  <tromey@adacore.com>
1104
1105         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1106         (print_frame_args): Update.
1107         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1108         Update.
1109         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1110         * frame.h (struct frame_arg): Add initializers.
1111         <error>: Now a unique_xmalloc_ptr.
1112
1113 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1114
1115         * NEWS: Expand the Pointer Authentication entry.
1116         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1117         (aarch64_frame_unmask_lr): ... to this.
1118         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1119         Call aarch64_frame_unmask_lr.
1120         * frame.c (struct frame_info): Add "masked" variable.
1121         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1122         (fprint_frame): Check for masked pc.
1123         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1124         declarations.
1125         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1126         * stack.c (print_frame): Check for masked pc.
1127
1128 2019-08-06  Tom Tromey  <tom@tromey.com>
1129
1130         * stabsread.c (patch_block_stabs, read_one_struct_field)
1131         (read_enum_type): Use obstack_strndup.
1132         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1133         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1134         * dwarf2read.c (guess_full_die_structure_name)
1135         (anonymous_struct_prefix): Use obstack_strndup.
1136         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1137         * c-exp.y (yylex): Use obstack_strndup.
1138         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1139         (write_var_or_type): Use obstack_strndup.
1140
1141 2019-08-06  Tom Tromey  <tom@tromey.com>
1142
1143         * symfile.c (reread_symbols): Use obstack_strdup.
1144         * stabsread.c (read_type): Use obstack_strdup.
1145         * gdb_obstack.h (obstack_strdup): New overload.
1146         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1147         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1148         (dwarf2_canonicalize_name): Use obstack_strdup.
1149         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1150         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1151         Use obstack_strdup.
1152
1153 2019-08-06  Tom Tromey  <tom@tromey.com>
1154
1155         * gdb_obstack.h (obstack_strdup): Define.
1156         * gdb_obstack.c (obstack_strdup): Don't define.
1157
1158 2019-08-06  Tom Tromey  <tom@tromey.com>
1159
1160         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1161         obstack_strdup.
1162         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1163         obstack_strdup.
1164         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1165         * stabsread.c (common_block_start): Use obstack_strdup.
1166         * objfiles.c (set_objfile_main_name, objfile): Use
1167         obstack_strdup.
1168         * namespace.c (add_using_directive): Use obstack_strdup.
1169         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1170         * jit.c (finalize_symtab): Use obstack_strdup.
1171         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1172         (guess_partial_die_structure_name, partial_die_info::fixup)
1173         (dwarf2_name): Use obstack_strdup.
1174         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1175         obstack_strdup.
1176         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1177         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1178         obstack_strdup.
1179         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1180
1181 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1182
1183         * unittests/help-doc-selftests.c: New file.
1184         * Makefile.in: Add the new file.
1185
1186 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1187
1188         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1189         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1190         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1191         the trailing '.' is not output, and the first character is uppercased.
1192         (print_help_for_command): Update call to print_doc_line.
1193         (print_doc_of_command): Likewise.
1194         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1195         * cli/cli-option.c (append_indented_doc): Do not append newline.
1196         (build_help_option): Append newline after first appended_indented_doc
1197         only if a second call is done.
1198         (build_help): Append 2 new lines before each option, except the first
1199         one.
1200         * compile/compile.c (_initialize_compile): Add new lines after
1201         %OPTIONS%, when not at the end of the help.
1202         Change help doc or code
1203         producing the help doc to respect the invariants.
1204         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1205         Also removed the new line after 'Options:', as all other commands
1206         do not put an empty line between 'Options:' and the first option.
1207         * printcmd.c (_initialize_printcmd): Likewise.
1208         * stack.c (_initialize_stack): Likewise.
1209         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1210         incorrectly telling COMMAND is optional.
1211         * ada-lang.c (_initialize_ada_language): Change help doc or code
1212         producing the help doc to respect the invariants.
1213         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1214         * breakpoint.c (_initialize_breakpoint): Likewise.
1215         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1216         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1217         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1218         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1219         _initialize_cli_style): Likewise.
1220         * corelow.c (core_target_info): Likewise.
1221         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1222         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1223         * filesystem.c (_initialize_filesystem): Likewise.
1224         * frame.c (_initialize_frame): Likewise.
1225         * gnu-nat.c (add_task_commands): Likewise.
1226         * infcall.c (_initialize_infcall): Likewise.
1227         * infcmd.c (_initialize_infcmd): Likewise.
1228         * interps.c (_initialize_interpreter): Likewise.
1229         * language.c (_initialize_language): Likewise.
1230         * linux-fork.c (_initialize_linux_fork): Likewise.
1231         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1232         * maint.c (_initialize_maint_cmds): Likewise.
1233         * memattr.c (_initialize_mem): Likewise.
1234         * printcmd.c (_initialize_printcmd): Likewise.
1235         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1236         _RegEx): Likewise.
1237         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1238         * record-btrace.c (_initialize_record_btrace): Likewise.
1239         * record-full.c (_initialize_record_full): Likewise.
1240         * record.c (_initialize_record): Likewise.
1241         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1242         * regcache.c (_initialize_regcache): Likewise.
1243         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1244         _initialize_remote): Likewise.
1245         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1246         * serial.c (_initialize_serial): Likewise.
1247         * skip.c (_initialize_step_skip): Likewise.
1248         * source.c (_initialize_source): Likewise.
1249         * stack.c (_initialize_stack): Likewise.
1250         * symfile.c (_initialize_symfile): Likewise.
1251         * symtab.c (_initialize_symtab): Likewise.
1252         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1253         * top.c (init_main): Likewise.
1254         * tracefile-tfile.c (tfile_target_info): Likewise.
1255         * tracepoint.c (_initialize_tracepoint): Likewise.
1256         * tui/tui-win.c (_initialize_tui_win): Likewise.
1257         * utils.c (add_internal_problem_command): Likewise.
1258         * valprint.c (value_print_option_defs): Likewise.
1259
1260 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1261
1262         PR build/24886
1263         * configure.ac: Drop enable-libmcheck support.
1264         * configure, config.in: Rebuild.
1265         * libmcheck.m4: Remove.
1266         * acinclude.m4: Don't include it.
1267         * Makefile.in: Don't distribute it.
1268         * top.c (print_gdb_configuration): Don't mention it.
1269
1270 2019-08-06  Tom Tromey  <tom@tromey.com>
1271
1272         * utils.c (set_output_style): Sometimes pass stream to
1273         emit_style_escape.
1274         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1275         * record-btrace.c (btrace_insn_history): Update.
1276         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1277         method.
1278         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1279         Update initializers.
1280         <m_uiout>: New field.
1281         <m_di>: Move lower.
1282         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1283         Remove "uiout" parameter.
1284         (dump_insns): Update.
1285         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1286         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1287
1288 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1289
1290         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1291         (error_in_psymtab_expansion): Likewise.
1292         (lookup_symbol_via_quick_fns): Likewise.
1293         (basic_lookup_transparent_type_quick): Likewise.
1294         (basic_lookup_transparent_type_1): Likewise.
1295
1296 2019-08-06  Tom Tromey  <tromey@adacore.com>
1297
1298         * source.c (last_source_error): Now bool.
1299         (print_source_lines_base): Make "noprint" bool.  Only open
1300         source file when last_source_visited changes.
1301
1302 2019-08-06  Tom Tromey  <tromey@adacore.com>
1303
1304         * annotate.c (annotate_source_line): Use g_source_cache.
1305         * source-cache.c (source_cache::get_plain_source_lines): Change
1306         parameters.  Populate m_offset_cache.
1307         (source_cache::ensure): New method.
1308         (source_cache::get_line_charpos): New method.
1309         (extract_lines): Move lower.  Change parameters.
1310         (source_cache::get_source_lines): Move lower.
1311         * source-cache.h (class source_cache): Update comment.
1312         <get_line_charpos>: New method.
1313         <get_source_lines>: Update comment.
1314         <clear>: Clear m_offset_cache.
1315         <get_plain_source_lines>: Change parameters.
1316         <ensure>: New method
1317         <m_offset_cache>: New member.
1318         * source.c (forget_cached_source_info_for_objfile): Update.
1319         (info_source_command): Use g_source_cache.
1320         (find_source_lines, open_source_file_with_line_charpos): Remove.
1321         (print_source_lines_base, search_command_helper): Use g_source_cache.
1322         * source.h (open_source_file_with_line_charpos): Don't declare.
1323         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1324         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1325         Use g_source_cache.
1326
1327 2019-08-06  Tom Tromey  <tromey@adacore.com>
1328
1329         * source-cache.c (source_cache::get_plain_source_lines):
1330         Remove "first_line" and "last_line" parameters.
1331         (source_cache::get_source_lines): Cache plain text.
1332         * source-cache.h (class source_cache)
1333         <get_plain_source_lines>: Update.
1334
1335 2019-08-06  Tom Tromey  <tromey@adacore.com>
1336
1337         * source-cache.c (extract_lines): No longer a method.
1338         Changed type of parameter.  Include final newline.
1339         (selftests::extract_lines_test): New function.
1340         (_initialize_source_cache): Likewise.
1341         * source-cache.h (class source_cache)
1342         <extract_lines>: Don't declare.
1343
1344 2019-08-06  Tom Tromey  <tromey@adacore.com>
1345
1346         * breakpoint.c (init_breakpoint_sal): Update.
1347         (breakpoint): Update.
1348         * breakpoint.h (struct breakpoint) <filter>: Now a
1349         unique_xmalloc_ptr.
1350
1351 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1352
1353         * NEWS: Mention dictionary access on blocks.
1354         * python/py-block.c (blpy_getitem): New function.
1355         (block_object_as_mapping): New struct.
1356         (block_object_type): Use new struct for tp_as_mapping field.
1357
1358 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1359
1360         * objfiles.h (objfile): Add a comment describing partial symbols.
1361
1362 2019-08-05  Tom Tromey  <tromey@adacore.com>
1363
1364         * compile/compile.c (_initialize_compile): Use _(), not N_().
1365         * thread.c (_initialize_thread): Use _(), not N_().
1366         * stack.c (_initialize_stack): Use _(), not N_().
1367         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1368
1369 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1370
1371         * dwarf2read.c (struct dw2_symtab_iterator):
1372         <want_specific_block>: Remove.
1373         <block_index>: Change type to gdb::optional.
1374         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1375         change type of BLOCK_INDEX parameter to gdb::optional.
1376         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1377         (dw2_lookup_symbol): Don't pass argument for
1378         WANT_SPECIFIC_BLOCK.
1379         (dw2_expand_symtabs_for_function): Don't pass argument for
1380         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1381         (class dw2_debug_names_iterator)
1382         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1383         parameter, change BLOCK_INDEX type to gdb::optional.
1384         <m_want_specific_block>: Remove.
1385         <m_block_index>: Change type to gdb::optional.
1386         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1387         gdb::optional.  Re-write in function of gdb::optional.
1388         (dw2_debug_names_lookup_symbol): Don't pass argument for
1389         WANT_SPECIFIC_BLOCK.
1390         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1391         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1392         BLOCK_INDEX.
1393
1394 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1395
1396         * NEWS: Mention changes to "info sources" command.
1397
1398 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1399
1400         * symtab.c (filename_partial_match_opts): New struct type.
1401         (struct output_source_filename_data): New members
1402         regexp, c_regexp, partial_match.
1403         (output_source_filename): Use new members to decide to print file.
1404         (info_sources_option_defs): New variable.
1405         (make_info_sources_options_def_group, print_info_sources_header,
1406         info_sources_command_completer):
1407         New functions.
1408         (info_sources_command): Read new optional arguments.
1409         (_initialize_symtab): Update info sources help.
1410
1411 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1412
1413         * ada-lang.c (exception_support_info_v0): Renamed from...
1414         (default_exception_support_info): ... this.  Create new
1415         definition for v1.
1416         (ada_has_this_exception_support): Look up catch_handlers_sym.
1417         (ada_exception_support_info_sniffer): Try v0 after default.
1418
1419 2019-08-01  Tom Tromey  <tromey@adacore.com>
1420
1421         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1422         gdbarch.h.
1423
1424 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1425
1426         * s12z-tdep.c: Fix include path for s12z-opc.h.
1427
1428 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1429
1430         * NEWS: Require GNU make 3.82.
1431
1432 2019-07-16  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1435         declare.
1436
1437 2019-07-30  Tom Tromey  <tromey@adacore.com>
1438
1439         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1440
1441 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1442
1443         * printcmd.c (print_address_symbolic): Print negative offsets.
1444         (build_address_symbolic): Force signed arithmetic when computing
1445         offset.
1446
1447 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1448
1449         PR/24474: Add a function to lookup static variables.
1450         * NEWS: Mention this new function.
1451         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1452         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1453         * python/python.c (python_GdbMethods): Add new function.
1454
1455 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1456
1457         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1458         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1459         (objfpy_lookup_static_symbol): New function.
1460         (objfile_object_methods): Add new functions.
1461
1462 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1463
1464         * NEWS: Mention 'set|show print frame-info'.  Mention new
1465         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1466         backtrace argument.  Mention that python frame filtering code
1467         is now consistent with what 'backtrace' command prints.
1468
1469 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1470
1471         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1472         comments.
1473         (print_frame_info_auto, print_frame_info_source_line,
1474         print_frame_info_location, print_frame_info_source_and_location,
1475         print_frame_info_location_and_address, print_frame_info_short_location):
1476         New declarations.
1477         (struct frame_print_options): New member print_frame_info.
1478         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1479         * stack.h (get_user_print_what_frame_info): New declaration.
1480         (frame_show_address): New declaration.
1481         * stack.c (print_frame_arguments_choices): New value 'presence'.
1482         (print_frame_info_auto, print_frame_info_source_line,
1483         print_frame_info_location, print_frame_info_source_and_location,
1484         print_frame_info_location_and_address, print_frame_info_short_location,
1485         print_frame_info_choices, print_frame_info_print_what): New definitions.
1486         (print_frame_args): Only print dots for args if print frame-arguments
1487         is 'presence'.
1488         (frame_print_option_defs): New element for "frame-info".
1489         (get_user_print_what_frame_info): New function.
1490         (frame_show_address): Make non static.  Move comment to stack.h.
1491         (print_frame_info_to_print_what): New function.
1492         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1493         to decide what to print.
1494         (backtrace_command_1): Handle the new print_frame_arguments_presence
1495         value.
1496         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1497         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1498         (py_print_frame): In non-mi mode, use LOCATION as default for
1499         print_what, similarly to frame information printed directly by
1500         backtrace command. Handle frame-info user option in non MI mode.
1501
1502 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1503
1504         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1505         Add case for debugging 32-bit target on 64-bit host.  Revise
1506         comment.
1507
1508 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1509
1510         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1511         instead of find_function_entry_range_from_pc.
1512
1513 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1514
1515         * stack.c (find_frame_funname): Remove code which preferred
1516         minsym over symtab sym in "certain pathological cases".
1517
1518         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1519         parameter.  Change type of "do_demangle" to bool.
1520         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1521         Pass suitable "prefer_sym_over_minsym" flag to
1522         build_address_symbolic().  Don't output "+" for negative offsets.
1523         * printcmd.c (print_address_symbolic): Update invocation of
1524         build_address_symbolic to include a "prefer_sym_over_minsym"
1525         flag.
1526         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1527         Restrict cases in which use of minimal symbol is preferred to that
1528         of a found symbol.  Update comments.
1529
1530         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1531         for entry pc when entry pc is out of range for that FDE.
1532
1533 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1534
1535         PR gdb/24839:
1536         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1537         type.
1538
1539 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1540
1541         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1542         this function's Python signature.
1543
1544
1545 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1546
1547         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1548         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1549         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1550         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1551         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1552
1553
1554 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1555
1556         * h8300-tdep.c (h8300_register_name_common): New.
1557         h8300_register_name): Use h8300_register_name_common.
1558         (h8300s_register_name): Likewise.
1559         (h8300sx_register_name): Likewise.
1560         (h8300h_register_nam): New.
1561         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1562
1563
1564 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1565
1566         * arm-tdep.c (arm_skip_cmse_entry): New function.
1567         (arm_is_sgstubs_section): New function.
1568         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1569
1570 2019-07-22  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1573         Don't self-assign.
1574
1575 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1576
1577         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1578         type_print.
1579
1580 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1583         so that GDB doesn't match any msymbols when searching in the
1584         TYPES_DOMAIN.
1585         (print_symbol_info): Print using typedef_print or type_print based
1586         on the type of the symbol.  Add updated FIXME comment moved from...
1587         (_initialize_symtab): ... move and update FIXME comment to above.
1588
1589 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1590
1591         * NEWS: Mention adding -q option to "info types".
1592         * symtab.c (struct info_types_options): New struct.
1593         (info_types_options_defs): New variable.
1594         (make_info_types_options_def_group): New function.
1595         (info_types_command): Use gdb::option framework to parse options.
1596         (info_types_command_completer): New function.
1597         (_initialize_symtab): Extend the help text on "info types" and
1598         register command completer.
1599
1600 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1601
1602         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1603         (lookup_symbol_in_objfile): Change int to block_enum and add a
1604         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1605
1606 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1607
1608         * MAINTAINERS (Write After Approval): Add self.
1609
1610 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1611
1612         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1613         instruction to the dummy code region.
1614
1615 2019-07-19  Tom Tromey  <tromey@adacore.com>
1616
1617         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1618         (ARGSUSED, PARAMS, __func__): Remove rules.
1619
1620 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1621
1622         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1623         * features/arm/arm-with-iwmmxt.c: Remove.
1624         * features/arm/arm-with-iwmmxt.xml: Remove.
1625         * features/arm/arm-with-m-fpa-layout.c: Remove.
1626         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1627         * features/arm/arm-with-m-vfp-d16.c: Remove.
1628         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1629         * features/arm/arm-with-m.c: Remove.
1630         * features/arm/arm-with-m.xml: Remove.
1631         * features/arm/arm-with-neon.c: Remove.
1632         * features/arm/arm-with-neon.xml: Remove.
1633         * features/arm/arm-with-vfpv2.c: Remove.
1634         * features/arm/arm-with-vfpv2.xml: Remove.
1635         * features/arm/arm-with-vfpv3.c: Remove.
1636         * features/arm/arm-with-vfpv3.xml: Remove.
1637
1638 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1639
1640         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1641
1642 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1643
1644         * arch/aarch32.c (aarch32_create_target_description): Create
1645         target descriptions using features.
1646         * arch/arm.c (arm_create_target_description)
1647         (arm_create_mprofile_target_description): Likewise.
1648         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1649
1650 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1651
1652         * Makefile.in: Add new files.
1653         * aarch32-tdep.c: New file.
1654         * aarch32-tdep.h: New file.
1655         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1656         Call aarch32_read_description.
1657         * arch/aarch32.c: New file.
1658         * arch/aarch32.h: New file.
1659         * arch/arm.c (arm_create_target_description)
1660         (arm_create_mprofile_target_description): New function.
1661         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1662         (arm_create_target_description)
1663         (arm_create_mprofile_target_description): New declaration.
1664         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1665         read_description functions.
1666         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1667         Likewise.
1668         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1669         * arm-tdep.c (tdesc_arm_list): New variable.
1670         (arm_register_g_packet_guesses): Call create description functions.
1671         (arm_read_description) (arm_read_mprofile_description): New
1672         function.
1673         * arm-tdep.h (arm_read_description)
1674         (arm_read_mprofile_description): Add declaration.
1675         * configure.tgt: Add new files.
1676
1677 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1678
1679         * top.c (new_ui_command): Open specified terminal just once.
1680
1681 2019-07-18  Tom Tromey  <tromey@adacore.com>
1682
1683         * symtab.c (main_name): Constify return type.
1684         * symfile.c (set_initial_language): Update.
1685         * symtab.h (main_name): Constify return type.
1686
1687 2019-07-17  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-winsource.c (tui_update_source_window)
1690         (tui_update_source_window_as_is)
1691         (tui_update_source_windows_with_line): Remove return.
1692         * tui/tui-disasm.c (tui_show_disassem)
1693         (tui_show_disassem_and_update_source): Remove return.
1694         * tui/tui.c (tui_reset): Remove return.
1695         * tui/tui-wingeneral.c
1696         (tui_check_and_display_highlight_if_needed): Remove return.
1697
1698 2019-07-17  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1701
1702 2019-07-17  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-winsource.h (struct tui_exec_info_window)
1705         (struct tui_source_window_base): Move from tui-data.h.
1706         * tui/tui-winsource.c: Move many method definitions from
1707         elsewhere.  Remove "structuring" comments.
1708         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1709         (tui_source_window_base::refresh_window): Move to
1710         tui-winsource.c.
1711         * tui/tui-win.c (tui_source_window_base::refresh_all)
1712         (tui_source_window_base::update_tab_width)
1713         (tui_source_window_base::set_new_height)
1714         (tui_source_window_base::do_make_visible_with_new_height): Move to
1715         tui-winsource.c.
1716         * tui/tui-source.h: Update.
1717         * tui/tui-source.c (tui_source_window_base::reset): Move to
1718         tui-winsource.c.
1719         * tui/tui-disasm.h: Update.
1720         * tui/tui-data.h (struct tui_exec_info_window): Move to
1721         tui-winsource.h.
1722         (struct tui_source_window_base): Likewise.
1723         * tui/tui-data.c (tui_source_window_base::clear_detail)
1724         (tui_source_window_base, ~tui_source_window_base): Move to
1725         tui-winsource.c.
1726
1727 2019-07-17  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-win.c (tui_resize_all)
1730         (tui_source_window_base::update_tab_width)
1731         (tui_adjust_win_heights): Update.
1732         (tui_win_info::make_invisible_and_set_new_height): Rename from
1733         make_invisible_and_set_new_height.
1734         * tui/tui-data.h (struct tui_win_info)
1735         <make_invisible_and_set_new_height>: New method.
1736
1737 2019-07-17  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui.c: Update.
1740         * tui/tui-source.h (struct tui_source_window): Move from
1741         tui-data.h.
1742         * tui/tui-layout.c: Update.
1743         * tui/tui-disasm.c: Update.
1744         * tui/tui-data.h (struct tui_source_window): Move to
1745         tui-source.h.
1746
1747 2019-07-17  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1750         tui-data.h.
1751         * tui/tui-data.h (struct tui_disasm_window): Move to
1752         tui-disasm.h.
1753
1754 2019-07-17  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-regs.h (struct tui_data_item_window): Move from
1757         tui-data.h.
1758         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1759         * tui/tui-data.h (struct tui_data_item_window): Move to
1760         tui-regs.h.
1761         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1762
1763 2019-07-17  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui.c: Update.
1766         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1767         (tui_cmd_window::max_height): Move to tui-command.c.
1768         * tui/tui-layout.c: Update.
1769         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1770         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1771         tui-command.c.
1772         * tui/tui-command.h (struct tui_cmd_window): Move from
1773         tui-data.h.
1774         * tui/tui-command.c: Remove "structuring" comments.
1775         (tui_cmd_window::clear_detail)
1776         (tui_cmd_window::do_make_visible_with_new_height)
1777         (tui_cmd_window::max_height): Move from elsewhere.
1778
1779 2019-07-17  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1782         Now static.
1783         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1784         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1785
1786 2019-07-17  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui.c: Update.
1789         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1790         tui-regs.c.
1791         * tui/tui-windata.h: Remove file.
1792         * tui/tui-windata.c: Remove file.
1793         * tui/tui-win.c (tui_data_window::set_new_height)
1794         (tui_data_window::do_make_visible_with_new_height): Move to
1795         tui-regs.c.
1796         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1797         * tui/tui-regs.c: Remove "structuring" comments.
1798         (tui_data_window::first_data_item_displayed)
1799         (tui_data_window::delete_data_content_windows)
1800         (tui_data_window::erase_data_content)
1801         (tui_data_window::display_all_data)
1802         (tui_data_window::refresh_all)
1803         (tui_data_window::do_scroll_vertical)
1804         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1805         (tui_data_window::do_make_visible_with_new_height)
1806         (tui_data_window::refresh_window): Move from elsewhere.
1807         (_initialize_tui_regs): Move to end of file.
1808         * tui/tui-layout.c: Update.
1809         * tui/tui-hooks.c: Update.
1810         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1811         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1812         tui-regs.c.
1813         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1814
1815 2019-07-17  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1818         seen.
1819
1820 2019-07-17  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-win.c (tui_source_window_base::set_new_height)
1823         (tui_source_window_base::do_make_visible_with_new_height): Use
1824         m_has_locator field directly.
1825         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1826         method.
1827         (struct tui_source_window_base) <has_locator>: Likewise.
1828
1829 2019-07-17  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1832         Don't declare.
1833         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1834         Remove.
1835         * tui/tui-win.c (tui_source_window_base::set_new_height)
1836         (tui_source_window_base::set_new_height)
1837         (make_invisible_and_set_new_height)
1838         (tui_source_window_base::do_make_visible_with_new_height)
1839         (tui_source_window_base::do_make_visible_with_new_height):
1840         Update.
1841         * tui/tui-layout.c (show_source_disasm_command, show_data)
1842         (show_source_or_disasm_and_command): Update.
1843         * tui/tui-layout.c (show_layout): Update.
1844
1845 2019-07-17  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-layout.c (make_data_window): Remove.
1848         (show_data): Unify creation and re-initialization cases.
1849
1850 2019-07-17  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-layout.c (make_source_window, make_disasm_window):
1853         Remove.
1854         (show_data): Unify creation and re-initialization cases.
1855
1856 2019-07-17  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui-layout.c (make_command_window): Remove.
1859         (show_source_disasm_command, show_source_or_disasm_and_command):
1860         Unify creation and re-initialization cases.
1861
1862 2019-07-17  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1865         creation and re-initialization cases.
1866
1867 2019-07-17  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-regs.c (tui_get_register): Return void.
1870
1871 2019-07-17  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1874         Simplify.
1875
1876 2019-07-17  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1879         resetting.
1880
1881 2019-07-17  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1884         * tui/tui-regs.c (tui_reg_layout): New function.
1885         (tui_show_registers, tui_reg_command): Use it.
1886         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1887         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1888         parameters.
1889         (tui_layout_command): Remove.
1890
1891 2019-07-17  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-layout.h (tui/tui-layout): Return void.
1894         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1895
1896 2019-07-17  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-layout.c (show_source_disasm_command, show_data):
1899         Update.
1900         (reset_locator): Remove.
1901         (show_source_or_disasm_and_command): Update.
1902
1903 2019-07-17  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-source.c (tui_source_window_base::reset): Remove
1906         win_type parameter.
1907         * tui/tui-layout.c (make_command_window, make_source_window)
1908         (make_disasm_window, make_data_window)
1909         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1910         (reset_locator, show_source_or_disasm_and_command): Update.
1911         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1912         win_type parameter.
1913         (struct tui_source_window_base) <reset>: Likewise.
1914
1915 2019-07-17  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-layout.c (show_source_disasm_command): Use
1918         reset_locator.
1919         (reset_locator): New function.
1920         (init_and_make_win): Remove.
1921         (show_source_or_disasm_and_command): Use reset_locator.
1922
1923 2019-07-17  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1926         condition.
1927         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1928         Remove condition.
1929         * tui/tui-source.c (tui_source_window_base::reset): New method.
1930         * tui/tui-layout.c (make_command_window): Don't call
1931         init_and_make_win.
1932         (make_source_window, make_disasm_window): Don't call
1933         make_source_or_disasm_window.
1934         (make_data_window): Don't call init_and_make_win.  Change calling
1935         convention.
1936         (show_source_disasm_command, show_data): Simplify.
1937         (make_source_or_disasm_window): Remove.
1938         (show_source_or_disasm_and_command): Simplify.
1939         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1940         (struct tui_source_window_base) <reset>: Likewise.
1941         <execution_info>: Remove initializer.
1942         * tui/tui-data.c (tui_source_window_base): Initialize
1943         execution_info.
1944
1945 2019-07-17  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1948         variable.
1949
1950 2019-07-17  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui.c (tui_rl_other_window): Update.
1953         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1954         superclass method first.  Always iterate over regs_content.
1955         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1956         method.
1957         * tui/tui-win.c (tui_set_focus_command): Update.
1958
1959 2019-07-17  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-win.c (tui_set_focus_command): Rename from
1962         tui_set_focus.  Call tui_enable.
1963         (tui_set_focus_command): Remove.
1964
1965 2019-07-17  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1968         refresh_window.
1969         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1970         touchwin.
1971         (tui_data_window::refresh_window): Call refresh_window on data
1972         items.  Always call superclass refresh_window.
1973         (tui_win_info::refresh): Remove.
1974         (tui_source_window_base::refresh_window): Update.
1975         (tui_refresh_all): Update.
1976         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1977         refresh_window.
1978         (show_source_or_disasm_and_command): Likewise.
1979         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1980         (struct tui_source_window_base) <refresh>: Likewise.
1981
1982 2019-07-17  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-winsource.c (tui_clear_source_content)
1985         (tui_show_source_content): Update.
1986         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1987         whether content is empty.
1988         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1989         Remove.
1990
1991 2019-07-17  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1994         window's contents.
1995         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1996         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1997
1998 2019-07-17  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2001         (struct tui_data_item_window): Update.
2002
2003 2019-07-17  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2006         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2007         defines.
2008
2009 2019-07-17  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-winsource.h (tui_erase_source_content)
2012         (tui_clear_source_content): Remove "display_prompt" parameter.
2013         * tui/tui-winsource.c (tui_update_source_window_as_is)
2014         (tui_update_source_windows_with_addr): Update.
2015         (tui_clear_source_content): Remove "display_prompt" parameter.
2016         (tui_erase_source_content): Likewise.  Simplify.
2017         (tui_show_source_content): Update.
2018         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2019         * tui/tui-stack.c (tui_show_frame_info): Update.
2020         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2021         Remove defines.
2022
2023 2019-07-17  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2026         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2027         parameter.
2028         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2029         parameter.
2030
2031 2019-07-17  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-winsource.c (tui_clear_source_content)
2034         (tui_show_source_content, tui_show_exec_info_content)
2035         (tui_clear_exec_info_content): Update.
2036         * tui/tui-stack.c (tui_show_locator_content): Update.
2037         (tui_show_frame_info): Update.
2038         * tui/tui-source.h (tui_source_window): Don't declare.
2039         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2040         from tui_source_is_displayed.
2041         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2042         Remove field.
2043         (struct tui_source_window_base) <content_in_use>: New field.  Now
2044         bool.
2045         (struct tui_source_window) <showing_source_p>: New method.
2046         (TUI_SRC_WIN): Change cast.
2047         * tui/tui-data.c (tui_initialize_static_data): Update.
2048
2049 2019-07-17  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2052         location_matches_p.
2053         * tui/tui-source.c (tui_source_window::location_matches_p): New
2054         method.
2055         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2056         method.
2057         * tui/tui-data.h (struct tui_source_window_base)
2058         <location_matches_p>: New method.
2059         (struct tui_source_window, struct tui_disasm_window)
2060         <location_matches_p>: Likewise.
2061
2062 2019-07-17  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-win.c (tui_set_win_height_command): Rename from
2065         tui_set_win_height.
2066         (tui_set_win_height_command): Remove.
2067
2068 2019-07-17  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-source.c (tui_source_window): New constructor.  Add
2071         observer.
2072         (~tui_source_window): New destructor.
2073         (tui_source_window::style_changed): New method.
2074         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2075         (tui_attach_detach_observers): Update.
2076         * tui/tui-data.h (struct tui_source_window): Make constructor not
2077         inline.  Add destructor.
2078         (struct tui_source_window) <style_changed>: New method.
2079         <m_observable>: New member.
2080
2081 2019-07-17  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2084         * tui/tui-win.c (tui_resize_all): Fix typo.
2085
2086 2019-07-17  Tom Tromey  <tom@tromey.com>
2087
2088         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2089         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2090         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2091         * tui/tui-win.c (window_name_completer): Use foreach.
2092         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2093         (update_tab_width): Likewise.
2094         * tui/tui-layout.c (show_layout): Update.
2095         * tui/tui-data.h (class tui_window_iterator): New.
2096         (struct all_tui_windows): New.
2097         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2098
2099 2019-07-17  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2102         parameter.  Don't reference globals.
2103         (tui_reg_command): Update.
2104
2105 2019-07-17  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui-regs.c (tui_show_registers): Simplify.
2108
2109 2019-07-17  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-regs.c (tui_show_registers): Update.
2112         (tui_show_register_group): Add win_info parameter.
2113
2114 2019-07-17  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2117         Rename from tui_display_reg_element_at_line.
2118         (tui_data_window::display_registers_from_line): Update.
2119         * tui/tui-data.h (struct tui_data_window)
2120         <display_reg_element_at_line>: New method.
2121
2122 2019-07-17  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-regs.h (tui_display_registers_from)
2125         (tui_display_registers_from_line): Don't declare.
2126         * tui/tui-windata.c (tui_data_window::display_all_data)
2127         (tui_data_window::refresh_all)
2128         (tui_data_window::do_scroll_vertical): Update.
2129         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2130         from tui_display_registers_from.
2131         (tui_display_reg_element_at_line): Update.
2132         (tui_data_window::display_registers_from_line): Rename from
2133         tui_display_registers_from_line.
2134         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2135         display_registers_from_line>: New methods.
2136
2137 2019-07-17  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2140         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2141         from tui_erase_data_content.
2142         (tui_data_window::display_all_data)
2143         (tui_data_window::refresh_all)
2144         (tui_data_window::do_scroll_vertical): Update.
2145         * tui/tui-regs.c (tui_show_registers): Update.
2146         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2147         New method.
2148
2149 2019-07-17  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2152         declare.
2153         * tui/tui-windata.c
2154         (tui_data_window::delete_data_content_windows): Rename from
2155         tui_delete_data_content_windows.
2156         (tui_data_window::display_all_data)
2157         (tui_data_window::do_scroll_vertical): Update.
2158         * tui/tui-data.h (struct tui_data_window)
2159         <delete_data_content_windows>: New method.
2160
2161 2019-07-17  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2164         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2165
2166 2019-07-17  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2169         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2170         from tui_display_all_data.
2171         * tui/tui-win.c
2172         (tui_data_window::do_make_visible_with_new_height): Update.
2173         * tui/tui-regs.c (tui_show_registers): Update.
2174         * tui/tui-layout.c (tui_set_layout): Update.
2175         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2176         method.
2177
2178 2019-07-17  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2181         * tui/tui-windata.c (tui_display_data_from): Remove.
2182         (tui_data_window::refresh_all): Update.
2183
2184 2019-07-17  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2187         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2188         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2189         tui_display_registers_from_line.
2190         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2191         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2192         "force_display" parameter.
2193
2194 2019-07-17  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2197         declare.
2198         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2199         Rename from tui_first_reg_element_no_inline.
2200         (tui_display_reg_element_at_line)
2201         (tui_display_registers_from_line): Update.
2202         * tui/tui-data.h (struct tui_data_window)
2203         <first_reg_element_no_inline>: New method.
2204
2205 2019-07-17  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-windata.c (tui_display_data_from)
2208         (tui_data_window::do_scroll_vertical): Update.
2209         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2210         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2211         Rename from tui_line_from_reg_element_no.
2212         (tui_display_registers_from_line): Update.
2213         * tui/tui-data.h (struct tui_data_window)
2214         <line_from_reg_element_no>: New method.
2215
2216 2019-07-17  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2219         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2220         tui_last_regs_line_no.
2221         (tui_display_reg_element_at_line)
2222         (tui_display_registers_from_line): Update.
2223         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2224         method.
2225
2226 2019-07-17  Tom Tromey  <tom@tromey.com>
2227
2228         PR tui/24722:
2229         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2230         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2231         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2232         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2233         (tui_update_breakpoint_info): Likewise.
2234         * tui/tui-hooks.c (tui_event_create_breakpoint)
2235         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2236         Update.
2237
2238 2019-07-17  Tom Tromey  <tom@tromey.com>
2239
2240         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2241
2242 2019-07-17  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-winsource.c (tui_update_source_window_as_is)
2245         (tui_update_source_windows_with_addr): Update.
2246         * tui/tui-source.h (tui_set_source_content)
2247         (tui_show_symtab_source): Add "win_info" parameter.
2248         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2249         parameter.
2250         (tui_show_symtab_source): Likewise.
2251
2252 2019-07-17  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-wingeneral.c
2255         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2256
2257 2019-07-17  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2260         (struct tui_cmd_window) <can_scroll>: New method.
2261         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2262         method.
2263
2264 2019-07-17  Tom Tromey  <tromey@adacore.com>
2265
2266         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2267         do_field_signed>: Rename.  Change type of "value".
2268         * ui-out.c (ui_out::field_signed): Rename from field_int.
2269         Change type of "value".
2270         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2271         type of "value".
2272         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2273         do_field_int.  Change type of "value".
2274         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2275         do_field_int.  Change type of "value".
2276         * tracepoint.c (trace_status_mi, tfind_1)
2277         (print_one_static_tracepoint_marker): Update.
2278         * thread.c (print_thread_info_1, print_selected_thread_frame):
2279         Update.
2280         * stack.c (print_frame, print_frame_info): Update.
2281         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2282         Update.
2283         * source.c (print_source_lines_base): Update.
2284         * skip.c (info_skip_command): Update.
2285         * record-btrace.c (btrace_ui_out_decode_error)
2286         (btrace_call_history_src_line): Update.
2287         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2288         Update.
2289         * progspace.c (print_program_space): Update.
2290         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2291         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2292         do_field_int.  Change type of "value".
2293         * mi/mi-out.c (mi_ui_out::do_table_begin)
2294         (mi_ui_out::do_table_header): Update.
2295         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2296         type of "value".
2297         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2298         (mi_cmd_data_list_changed_registers, output_register)
2299         (mi_cmd_data_read_memory, mi_load_progress)
2300         (mi_cmd_trace_frame_collected): Update.
2301         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2302         Update.
2303         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2304         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2305         (mi_cmd_var_list_children, varobj_update_one): Update.
2306         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2307         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2308         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2309         * inferior.c (print_inferior): Update.
2310         * gdb_bfd.c (print_one_bfd): Update.
2311         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2312         Update.
2313         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2314         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2315         do_field_int.  Change type of "value".
2316         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2317         do_field_int.  Change type of "value".
2318         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2319         (print_one_breakpoint_location, print_it_catch_fork)
2320         (print_one_catch_fork, print_it_catch_vfork)
2321         (print_one_catch_vfork, print_it_catch_solib)
2322         (print_it_catch_exec, print_it_ranged_breakpoint)
2323         (print_mention_watchpoint, print_mention_masked_watchpoint)
2324         (bkpt_print_it, update_static_tracepoint): Update.
2325         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2326         * break-catch-syscall.c (print_it_catch_syscall): Update.
2327         * ada-tasks.c (print_ada_task_info): Update.
2328         * ada-lang.c (print_it_exception, print_mention_exception):
2329         Update.
2330
2331 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2332
2333         PR breakpoints/24541
2334         * gdbarch.c: Regenerate.
2335         * gdbarch.h: Regenerate.
2336         * gdbarch.sh: Adjust return type and parameter types for
2337         'stap_adjust_register'.
2338         (i386_stap_adjust_register): Adjust signature and return new
2339         register name.
2340         * stap-probe.c (stap_parse_register_operand): Adjust use of
2341         'gdbarch_stap_adjust_register'.
2342
2343 2019-07-17  Tom Tromey  <tromey@adacore.com>
2344
2345         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2346         declare VEC.
2347         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2348         std::vector.
2349         (struct s390_process_info): Add initializers.
2350         (s390_add_process): Use new.
2351         (s390_linux_nat_target::low_forget_process): Use delete.
2352         (s390_linux_nat_target::low_new_fork)
2353         (s390_linux_nat_target::stopped_by_watchpoint)
2354         (s390_linux_nat_target::low_prepare_to_resume)
2355         (s390_linux_nat_target::insert_watchpoint)
2356         (s390_linux_nat_target::insert_hw_breakpoint)
2357         (s390_linux_nat_target::remove_watchpoint)
2358         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2359
2360 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2361
2362         * aarch64-fbsd-nat.c: Include regcache.h.
2363         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2364         argument.
2365         (aarch64_fbsd_nat_target::fetch_registers)
2366         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2367         variable.
2368         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2369
2370 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2371
2372         * fbsd-nat.c: Include gdbarch.h.
2373
2374 2019-07-15  Tom Tromey  <tromey@adacore.com>
2375
2376         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2377
2378 2019-07-15  Tom Tromey  <tromey@adacore.com>
2379
2380         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2381         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2382         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2383         * cli-out.c (cli_ui_out::do_field_int): New method.
2384         * ui-out.c (ui_out::field_unsigned): New method.
2385         * symfile.c (generic_load): Use field_unsigned.
2386         (print_transfer_performance): Likewise.
2387         * record-btrace.c (ui_out_field_uint): Remove.
2388         (btrace_call_history_insn_range, btrace_call_history): Use
2389         field_unsigned.
2390         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2391         field_unsigned.
2392         * ui-out.h (class ui_out) <field_unsigned>: New method.
2393         <do_field_unsigned>: Likewise.
2394
2395 2019-07-15  Tom Tromey  <tromey@adacore.com>
2396
2397         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2398         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2399         * target.c (flash_erase_command): Use field_string.
2400         * infrun.c (print_signal_received_reason): Use field_string.
2401         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2402         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2403         field_string.
2404         * ada-tasks.c (print_ada_task_info): Use field_string.
2405
2406 2019-07-15  Tom Tromey  <tromey@adacore.com>
2407
2408         * target.c (flash_erase_command): Use field_core_addr.
2409         * symfile.c (generic_load): Use field_core_addr.
2410         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2411         Use field_core_addr.
2412         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2413         field_core_addr.
2414
2415 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2416
2417         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2418         value if its desired type is smaller than a CORE_ADDR and signed.
2419
2420 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2421
2422         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2423         of changes to field names, and use new is_reference field to
2424         decide if a property is a reference or not.
2425         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2426         field.
2427         (struct dwarf2_property_baton): Update header comment, rename
2428         'referenced_type' to 'property_type' and update comments.
2429         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2430         default property type, store in property baton, update to take
2431         accound of renamed field.
2432         (read_func_scope): Update call to attr_to_dynamic_prop.
2433         (read_array_type): Likewise.
2434         (dwarf2_per_cu_addr_sized_int_type): New function.
2435         (read_subrange_index_type): Move type finding code to
2436         dwarf2_per_cu_addr_sized_int_type.
2437         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2438         (dwarf2_per_cu_addr_type): New function.
2439         (set_die_type): Update calls to attr_to_dynamic_prop.
2440
2441 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2442
2443         * dwarf2read.c (read_subrange_index_type): New function.
2444         (read_subrange_type): Move code into new function and call it.
2445         * gdbtypes.c (create_range_type): Add some asserts.
2446
2447 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2448
2449         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2450         update return statements.
2451         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2452         declaration, and update comment to match.
2453         * gdbtypes.c (resolve_dynamic_array): Update call to
2454         dwarf2_evaluate_property to match new return type.
2455
2456 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2457
2458         * valarith.c (value_subscripted_rvalue): Change lowerbound
2459         parameter type from int to LONGEST.
2460         * value.h (value_subscripted_rvalue): Likewise in declaration.
2461
2462 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2463
2464         * cli/cli-utils.c (info_print_command_completer): New function.
2465         * cli/cli-utils.h: Add 'completer.h' include, and forward
2466         declaration for 'struct cmd_list_element'.
2467         (info_print_command_completer): Declare.
2468         * stack.c (_initialize_stack): Add completer for 'info locals' and
2469         'info args'.
2470         * symtab.c (_initialize_symtab): Add completer for 'info
2471         variables' and 'info functions'.
2472         * NEWS: Mention completion for additional info commands.
2473
2474 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2475
2476         * cli/cli-utils.c (extract_info_print_args): Delete.
2477         (extract_arg_maybe_quoted): Delete.
2478         (info_print_options_defs): New variable.
2479         (make_info_print_options_def_group): New function.
2480         (extract_info_print_options): Define new function.
2481         * cli/cli-utils.h (extract_info_print_args): Delete.
2482         (struct info_print_options): New structure.
2483         (extract_info_print_options): Declare new function.
2484         * stack.c (info_locals_command): Update to use new
2485         extract_info_print_options, also add a header comment.
2486         (info_args_command): Likewise.
2487         * symtab.c (info_variables_command): Likewise.
2488         (info_functions_command): Likewise.
2489
2490 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2491
2492         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2493         to extract string arguments.
2494         * common/common-utils.c (extract_string_maybe_quoted): New function.
2495         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2496
2497 2019-07-11  Tom Tromey  <tromey@adacore.com>
2498
2499         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2500         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2501         * top.h (gdbinit): Don't declare.
2502         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2503         into...
2504         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2505         * top.c (gdb_init): Don't call init_cli_cmds.
2506         (gdbinit): Remove.
2507         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2508
2509 2019-07-11  Tom Tromey  <tromey@adacore.com>
2510
2511         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2512         after it has been moved.
2513
2514 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2515
2516         * valops.c (value_must_coerce_to_target): Change return type to
2517         bool.
2518         * value.h (value_must_coerce_to_target): Likewise.
2519
2520 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2521
2522         * breakpoint.c (is_hardware_watchpoint): Remove
2523         forward-declaration.
2524         (is_masked_watchpoint): Change return type to bool.
2525         (is_tracepoint): Likewise.
2526         (is_breakpoint): Likewise.
2527         (is_hardware_watchpoint): Likewise.
2528         (is_watchpoint): Likewise.
2529         (is_no_memory_software_watchpoint): Likewise.
2530         (is_catchpoint): Likewise.
2531         (breakpoint_1): Make FILTER parameter's return type bool.
2532         is_masked_watchpoint): Change return type to bool.
2533         (save_breakpoints): Make FILTER parameter's return type bool.
2534         * breakpoint.h (is_breakpoint): Change return type to bool.
2535         (is_watchpoint): Likewise.
2536         (is_catchpoint): Likewise.
2537         (is_tracepoint): Likewise.
2538
2539 2019-07-10  Tom Tromey  <tom@tromey.com>
2540
2541         * defs.h: Don't include gdbarch.h.
2542         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2543         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2544         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2545         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2546         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2547         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2548         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2549         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2550         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2551         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2552         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2553         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2554         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2555         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2556         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2557         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2558         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2559         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2560         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2561         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2562         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2563         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2564         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2565         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2566         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2567         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2568         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2569
2570 2019-07-10  Tom Tromey  <tromey@adacore.com>
2571
2572         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2573         * breakpoint.c (init_ada_exception_breakpoint): Register as
2574         bp_catchpoint.
2575         (print_one_breakpoint_location, print_one_breakpoint): Use
2576         is_ada_exception_catchpoint.
2577         * ada-lang.c (class ada_catchpoint_location): Pass
2578         bp_loc_software_breakpoint to bp_location constructor.
2579         (is_ada_exception_catchpoint): New function.
2580
2581 2019-07-10  Tom Tromey  <tromey@adacore.com>
2582
2583         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2584         VEC.
2585         (struct arm_exidx_entry): New method operator<.
2586         (struct arm_exidx_data) <section_maps>: Change type.
2587         (arm_exidx_data_free): Remove.
2588         (arm_exidx_data_key): Change type.  Move lower.
2589         (arm_exidx_new_objfile): Update.
2590         (arm_compare_exidx_entries): Remove.
2591         (arm_find_exidx_entry, _initialize_arm_tdep)
2592
2593 2019-07-10  Tom Tromey  <tromey@adacore.com>
2594
2595         * solib-spu.c (ocl_program_data_key): Change type.
2596         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2597         Update.
2598
2599 2019-07-10  Tom Tromey  <tromey@adacore.com>
2600
2601         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2602         (struct solib_aix_inferior_data) <library_list>: Change type.
2603         (solib_aix_inferior_data_handle): Change type.
2604         (get_solib_aix_inferior_data): Update.
2605         (solib_aix_free_library_list): Remove.
2606         (library_list_start_library): Update.
2607         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2608         return type.
2609         (solib_aix_get_library_list)
2610         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2611         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2612
2613 2019-07-10  Tom Tromey  <tromey@adacore.com>
2614
2615         * solib-dsbt.c (struct dsbt_info): Add initializers.
2616         (solib_dsbt_pspace_data): Change type.
2617         (dsbt_pspace_data_cleanup): Remove.
2618         (get_dsbt_info, _initialize_dsbt_solib): Update.
2619
2620 2019-07-10  Tom Tromey  <tromey@adacore.com>
2621
2622         * spu-tdep.c (spu_overlay_data): Change type.
2623         (spu_get_overlay_table, spu_overlay_new_objfile)
2624         (_initialize_spu_tdep): Update.
2625
2626 2019-07-10  Tom Tromey  <tromey@adacore.com>
2627
2628         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2629         destructor.
2630         (dbx_objfile_data_key): Change type and declare later.
2631         (DBX_SYMFILE_INFO): Rewrite.
2632         * dbxread.c (dbx_objfile_data_key): Change type.
2633         (dbx_symfile_init): Update.
2634         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2635         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2636         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2637
2638 2019-07-10  Tom Tromey  <tromey@adacore.com>
2639
2640         * jit.c (jit_program_space_key): Change type.  Move lower.
2641         (get_jit_program_space_data): Update.
2642         (jit_program_space_data_cleanup): Remove.
2643         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2644         Update.
2645         (struct jit_program_space_data): Add initializers.
2646
2647 2019-07-10  Tom Tromey  <tromey@adacore.com>
2648
2649         * solib-darwin.c (struct darwin_info): Add initializers.
2650         (solib_darwin_pspace_data): Change type.
2651         (darwin_pspace_data_cleanup): Remove.
2652         (get_darwin_info, _initialize_darwin_solib): Update.
2653
2654 2019-07-10  Tom Tromey  <tromey@adacore.com>
2655
2656         * remote-sim.c (struct sim_inferior_data): Add initializers,
2657         constructor, and destructor.
2658         (sim_inferior_data_key): Change type.  Move lower.
2659         (check_for_duplicate_sim_descriptor): Update.
2660         (get_sim_inferior_data): Use new.  Update.
2661         (~sim_inferior_data_cleanup): Rename from
2662         sim_inferior_data_cleanup.  Simplify.
2663         (gdbsim_close_inferior, simulator_command)
2664         (sim_command_completer, _initialize_remote_sim): Update.
2665         (next_pid, INITIAL_PID): Move earlier.
2666
2667 2019-07-10  Tom Tromey  <tromey@adacore.com>
2668
2669         * python/python-internal.h (create_thread_object): Return
2670         gdbpy_ref.
2671         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2672         * python/py-inferior.c (struct threadlist_entry): Add
2673         constructor.
2674         <thread_obj>: Now a gdbpy_ref.
2675         (thread_to_thread_object): Update.
2676         (add_thread_object): Use new.
2677         (delete_thread_object): Use delete.
2678         (infpy_threads): Update.
2679         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2680         GIL.
2681
2682 2019-07-10  Tom Tromey  <tromey@adacore.com>
2683
2684         * valops.c (value_cast): Specialize error message for Ada.
2685
2686 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2687
2688         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2689
2690 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2691
2692         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2693         bpstat_should_step): Return bool, adjust comments.
2694         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2695         bpstat_should_step): Likewise.
2696
2697 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2698
2699         * features/Makefile: Use feature target descriptions for Arm.
2700         * features/arm/arm-core.c: Generate new file.
2701         * features/arm/arm-fpa.c: Likewise.
2702         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2703         * features/arm/arm-m-profile.c: Likewise.
2704         * features/arm/arm-vfpv2.c: Likewise.
2705         * features/arm/arm-vfpv3.c: Likewise.
2706         * features/arm/xscale-iwmmxt.c: Likewise.
2707         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2708
2709 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2710
2711         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2712         ptrace earlier.
2713
2714 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2715
2716         * features/aarch64-pauth.c: Regenerate.
2717
2718 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2719
2720         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2721         bool.
2722         (bpstat_what): Use false instead of 0.
2723
2724 2019-07-09  Pedro Alves  <palves@redhat.com>
2725
2726         * break-catch-throw.c (is_exception_catchpoint): New.
2727         * breakpoint.c (print_one_breakpoint_location): New parameter
2728         'raw_loc'.  Handle it.  Use
2729         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2730         looking at the breakpoint's type.
2731         (print_one_breakpoint): If handling "maint info breakpoints", also
2732         print locations of exception catchpoints.
2733         * breakpoint.h (is_exception_catchpoint): Declare.
2734
2735 2019-07-09  Pedro Alves  <palves@redhat.com>
2736
2737         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2738         "addr" field.
2739         (allocate_location_exception_catchpoint): New.
2740         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2741         (initialize_throw_catchpoint_ops): Install
2742         allocate_location_exception_catchpoint as allocate_location
2743         method.
2744         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2745         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2746         bp_loc_other.
2747         (breakpoint_address_is_meaningful): Delete.
2748         (bl_address_is_meaningful): New.
2749         (breakpoint_locations_match): Adjust comment.
2750         (bp_location_from_bp_type): New, factored out of...
2751         (bp_location::bp_location(breakpoint *)): ... this.
2752         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2753         factored out of...
2754         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2755         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2756         breakpoint_address_is_meaningful.
2757         (bp_locations_compare): Adjust comment.
2758         (update_global_location_list): Use bl_address_is_meaningful
2759         instead of breakpoint_address_is_meaningful.
2760         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2761         explicit.
2762         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2763         * python/py-breakpoint.c (bppy_get_location): No longer check
2764         whether location is null.
2765
2766 2019-07-09  Pedro Alves  <palves@redhat.com>
2767
2768         PR c++/15468
2769         * breakpoint.c (print_one_breakpoint_location): Remove
2770         single-location assert.
2771
2772 2019-07-09  Tom Tromey  <tom@tromey.com>
2773
2774         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2775         * configure: Rebuild.
2776         * configure.ac: Change common to gdbsupport.
2777         * gdbsupport: Rename from common.
2778         * acinclude.m4: Change common to gdbsupport.
2779         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2780         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2781         gdbsupport.
2782         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2783         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2784         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2785         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2786         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2787         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2788         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2789         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2790         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2791         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2792         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2793         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2794         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2795         coff-pe-read.c, command.h, compile/compile-c-support.c,
2796         compile/compile-c.h, compile/compile-cplus-symbols.c,
2797         compile/compile-cplus-types.c, compile/compile-cplus.h,
2798         compile/compile-loc2c.c, compile/compile.c, completer.c,
2799         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2800         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2801         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2802         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2803         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2804         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2805         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2806         features/aarch64-core.c, features/aarch64-fpu.c,
2807         features/aarch64-pauth.c, features/aarch64-sve.c,
2808         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2809         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2810         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2811         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2812         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2813         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2814         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2815         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2816         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2817         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2818         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2819         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2820         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2821         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2822         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2823         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2824         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2825         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2826         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2827         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2828         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2829         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2830         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2831         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2832         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2833         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2834         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2835         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2836         minsyms.c, mips-linux-tdep.c, namespace.h,
2837         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2838         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2839         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2840         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2841         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2842         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2843         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2844         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2845         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2846         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2847         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2848         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2849         procfs.c, producer.c, progspace.h, psymtab.h,
2850         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2851         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2852         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2853         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2854         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2855         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2856         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2857         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2858         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2859         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2860         target-memory.c, target.c, target.h, target/waitstatus.c,
2861         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2862         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2863         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2864         unittests/array-view-selftests.c,
2865         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2866         unittests/common-utils-selftests.c,
2867         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2868         unittests/format_pieces-selftests.c,
2869         unittests/function-view-selftests.c,
2870         unittests/lookup_name_info-selftests.c,
2871         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2872         unittests/mkdir-recursive-selftests.c,
2873         unittests/observable-selftests.c,
2874         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2875         unittests/parse-connection-spec-selftests.c,
2876         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2877         unittests/scoped_fd-selftests.c,
2878         unittests/scoped_mmap-selftests.c,
2879         unittests/scoped_restore-selftests.c,
2880         unittests/string_view-selftests.c, unittests/style-selftests.c,
2881         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2882         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2883         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2884         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2885         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2886         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2887
2888 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2889
2890         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2891         bool value.
2892         (decode_digits_ordinary): Set explicit_line field in sal.
2893         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2894         symtab_and_line that was set on an explicit line number in
2895         assembler code.  Do always update the recorded symtab and line if
2896         we do skip the prologue.
2897
2898 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2899
2900         * breakpoint.c (set_breakpoint_location_function): Remove
2901         explicit_loc parameter.
2902         (momentary_breakpoint_from_master): Update call to
2903         set_breakpoint_location_function.
2904         (add_location_to_breakpoint): Likewise.
2905
2906 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2907
2908         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2909         required features based on default bfd type when no specific bfd
2910         is present.
2911
2912 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2913
2914         * NEWS: Mention that GDB printf and eval commands can now print
2915         C-style and Ada-style convenience var strings without
2916         calling the inferior.
2917         * printcmd.c (printf_c_string): Locally print GDB internal var
2918         instead of transiting via the inferior.
2919         (printf_wide_c_string): Likewise.
2920
2921 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2922
2923         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2924
2925 2019-07-04  Tom Tromey  <tom@tromey.com>
2926
2927         PR tui/24724:
2928         * tui/tui-winsource.c (tui_clear_source_content): Update.
2929         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2930         (tui_update_breakpoint_info): Update.
2931         (tui_set_exec_info_content): Update.
2932         * tui/tui-source.c (tui_set_source_content_nil): Update.
2933         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2934         has_break.
2935         * tui/tui-data.h (enum tui_bp_flag): New.
2936         (tui_bp_flags): New enum flags type.
2937         (struct tui_source_element) <break_mode>: Change type.  Rename
2938         from has_break.
2939         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2940         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2941         constants.
2942         * tui/tui-winsource.h: Fix comment.
2943
2944 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2945
2946         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2947         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2948         (store_fpregs_to_thread)
2949         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2950         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2951         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2952         (IWMMXT_REGS_SIZE): Add define.
2953         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2954         (fetch_vfp_regs, store_vfp_regs)
2955         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2956         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2957
2958 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2959
2960         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2961         defines.
2962         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2963         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2964         (ARM_INT_REGISTER_SIZE): ...to this.
2965         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2966         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2967         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2968         (arm_linux_collect_gregset, supply_nwfpe_register)
2969         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2970         defines.
2971         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2972         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2973         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2974         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2975         (arm_return_in_memory, arm_store_return_value)
2976         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2977         (arm_record_ld_st_multiple): Likewise.
2978         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2979         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2980
2981 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2982
2983         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2984         AARCH64_DISPLACED_MODIFIED_INSNS.
2985         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2986         (aarch64_displaced_step_copy_insn): Likewise.
2987         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2988         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2989         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2990         ARM_DISPLACED_MODIFIED_INSNS.
2991         * arm-tdep.c (arm_gdbarch_init): Likewise.
2992         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2993         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2994         (struct arm_displaced_step_closure): Use
2995         ARM_DISPLACED_MODIFIED_INSNS.
2996
2997 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2998
2999         * features/Makefile: Remove unused xml files.
3000         * features/aarch64.xml: Remove.
3001         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3002         * features/i386/amd64-avx-avx512.xml: Remove.
3003         * features/i386/amd64-avx-linux.xml: Remove.
3004         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3005         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3006         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3007         * features/i386/amd64-avx-mpx.xml: Remove.
3008         * features/i386/amd64-avx.xml: Remove.
3009         * features/i386/amd64-linux.xml: Remove.
3010         * features/i386/amd64-mpx-linux.xml: Remove.
3011         * features/i386/amd64-mpx.xml: Remove.
3012         * features/i386/amd64.xml: Remove.
3013         * features/i386/i386-avx-avx512-linux.xml: Remove.
3014         * features/i386/i386-avx-avx512.xml: Remove.
3015         * features/i386/i386-avx-linux.xml: Remove.
3016         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3017         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3018         * features/i386/i386-avx-mpx-linux.xml: Remove.
3019         * features/i386/i386-avx-mpx.xml: Remove.
3020         * features/i386/i386-avx.xml: Remove.
3021         * features/i386/i386-linux.xml: Remove.
3022         * features/i386/i386-mmx-linux.xml: Remove.
3023         * features/i386/i386-mmx.xml: Remove.
3024         * features/i386/i386-mpx-linux.xml: Remove.
3025         * features/i386/i386-mpx.xml: Remove.
3026         * features/i386/i386.xml: Remove.
3027         * features/i386/x32-avx-avx512-linux.xml: Remove.
3028         * features/i386/x32-avx-linux.xml: Remove.
3029         * features/i386/x32-linux.xml: Remove.
3030
3031 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3032
3033         * regformats/aarch64.dat: Remove.
3034         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3035         * regformats/i386/amd64-avx-linux.dat: Remove.
3036         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3037         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3038         * regformats/i386/amd64-linux.dat: Remove.
3039         * regformats/i386/amd64-mpx-linux.dat: Remove.
3040         * regformats/i386/amd64.dat: Remove.
3041         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3042         * regformats/i386/i386-avx-linux.dat: Remove.
3043         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3044         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3045         * regformats/i386/i386-linux.dat: Remove.
3046         * regformats/i386/i386-mmx-linux.dat: Remove.
3047         * regformats/i386/i386-mpx-linux.dat: Remove.
3048         * regformats/i386/i386.dat: Remove.
3049         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3050         * regformats/i386/x32-avx-linux.dat: Remove.
3051         * regformats/i386/x32-linux.dat: Remove.
3052
3053 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3054
3055         * aarch64-tdep.c: Remove xml self tests.
3056         * amd64-linux-tdep.c: Likewise.
3057         * amd64-tdep.c: Likewise.
3058         * i386-linux-tdep.c: Likewise.
3059         * i386-tdep.c: Likewise.
3060
3061 2019-07-03  Pedro Alves  <palves@redhat.com>
3062
3063         PR cli/24732
3064         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3065         (pipe_cmd_option_defs): New.
3066         (make_pipe_cmd_options_def_group): New.
3067         (pipe_command): Use gdb::option::process_options.
3068         (pipe_command_completer): New function.
3069         (_initialize_cli_cmds): Install completer for "pipe" command.
3070
3071 2019-07-03  Pedro Alves  <palves@redhat.com>
3072
3073         * cli/cli-option.c (union option_value) <string>: New field.
3074         (struct option_def_and_value): Add ctor, move ctor, dtor and
3075         use DISABLE_COPY_AND_ASSIGN.
3076         (option_def_and_value::clear_value): New.
3077         (parse_option, save_option_value_in_ctx, get_val_type_str)
3078         (add_setshow_cmds_for_options): Handle var_string.
3079         * cli-option.h (union option_def::var_address) <string>: New
3080         field.
3081         (struct string_option_def): New.
3082         * maint-test-options.c (struct test_options_opts): Add default
3083         ctor and use DISABLE_COPY_AND_ASSIGN.
3084         <string_opt>: New field.
3085         (test_options_opts::~test_options_opts): New.
3086         (test_options_opts::dump): Also dump "-string".
3087         (test_options_option_defs): Install "string.
3088
3089 2019-07-03  Pedro Alves  <palves@redhat.com>
3090
3091         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3092         option_value with a null enumeration.
3093         (complete_options): Save the option values in the context.
3094         (save_option_value_in_ctx): New, factored out from ...
3095         (process_options): ... here.
3096         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3097         of the function.
3098         * maint-test-options.c (test_options_opts::dump): New, factored
3099         out from ...
3100         (maintenance_test_options_command_mode): ... here.
3101         (maintenance_test_options_command_completion_result): Delete.
3102         (maintenance_test_options_command_completion_text): Update
3103         comment.
3104         (maintenance_show_test_options_completion_result): Change
3105         prototype.  Just print
3106         maintenance_test_options_command_completion_text.
3107         (save_completion_result): New.
3108         (maintenance_test_options_completer_mode): Pass options context to
3109         complete_options, and then save a dump.
3110         (_initialize_maint_test_options): Use add_cmd to install "maint
3111         show test-options-completion-result".
3112
3113 2019-07-03  Pedro Alves  <palves@redhat.com>
3114
3115         * NEWS (New commands): Mention "with" and "maint with".
3116         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3117         (with_command, with_command_completer): New.
3118         (pipe_command): Adjust to new repeat_previous
3119         interface.
3120         (_initialize_cli_cmds): Install the "with" command and its "w"
3121         alias.
3122         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3123         declarations.
3124         * cli/cli-setshow.c (parse_cli_var_uinteger)
3125         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3126         argument strings for all var_types.
3127         (get_setshow_command_value_string): New, factored out from ...
3128         (do_show_command): ... this.
3129         * cli/cli-setshow.h: Include <string>.
3130         (get_setshow_command_value_string): Declare.
3131         * command.h (repeat_previous): Now returns const char *.  Adjust
3132         comment.
3133         * maint.c: Include "cli/cli-cmds.h".
3134         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3135         (_initialize_maint_cmds): Register the "maintenance with" command.
3136         * top.c (repeat_previous): Move bits from pipe_command here:
3137         Return the saved command line, if any; error out if there's no
3138         command to relaunch.
3139
3140 2019-07-03  Pedro Alves  <palves@redhat.com>
3141
3142         * NEWS (New commands): Mention "maint set/show test-settings"
3143         instead of "maint test-settings".
3144         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3145         (maintenance_test_settings_set_list): Rename to ...
3146         (maintenance_set_test_settings_list): ... this.
3147         (maintenance_test_settings_show_list): Rename to  ...
3148         (maintenance_show_test_settings_list): ... this.
3149         (maintenance_test_settings_cmd): Delete.
3150         (maintenance_test_settings_set_cmd): ...
3151         (maintenance_set_test_settings_cmd): ... this.
3152         (maintenance_test_settings_show_cmd): ...
3153         (maintenance_show_test_settings_cmd): ... this.
3154         (maintenance_test_settings_show_value_cmd):
3155         (maintenance_show_test_settings_value_cmd): ... this.
3156         (_initialize_maint_test_settings): No longer install the "maint
3157         test-settings" prefix command.  Rename "maint test-settings set"
3158         to "maint set test-settings", and "maint test-settings show" to
3159         "maint show test-settings".  Adjust all subcommands.
3160
3161 2019-07-03  Pedro Alves  <palves@redhat.com>
3162
3163         * maint-test-settings.c: Fix file's intro comment.  Replace all
3164         references to "test-options" with references to "test-settings",
3165         in comments.
3166
3167 2019-07-03  Pedro Alves  <palves@redhat.com>
3168
3169         * maint-test-settings.c (maintenance_test_settings_xxx)
3170         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3171         New.
3172         (maintenance_test_settings_enums): Use them.
3173         (maintenance_test_settings_enum): Default to
3174         maintenance_test_settings_xxx.
3175         (_initialize_maint_test_settings): Initialize
3176         MAINTENANCE_TEST_SETTINGS_FILENAME.
3177
3178 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3179
3180         * breakpoint.h (remove_breakpoints_inf): Change return type to
3181         void, move function documentation here.
3182         * breakpoint.c (remove_breakpoints_inf): Change return type to
3183         void, move function documentation to header.
3184
3185 2019-07-02  Pedro Alves  <palves@redhat.com>
3186
3187         * NEWS (Completion improvements): Mention "info threads".
3188         * thread.c (struct info_threads_opts, info_threads_option_defs)
3189         (make_info_threads_options_def_group): New.
3190         (info_threads_command): Use gdb::option::process_options.
3191         (info_threads_command_completer): New.
3192         (_initialize_thread): Use gdb::option::build_help to build the
3193         help text for "info threads".
3194
3195 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3196
3197         * defs.h (generic_load): Move from here...
3198         * symfile.h (generic_load): ... to here.  Rename name parameter
3199         to args.
3200         * symfile.c (generic_load): Add comment.
3201
3202 2019-07-01  Tom Tromey  <tromey@adacore.com>
3203
3204         * dwarf2read.c
3205         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3206         declaration of without_params.  Fix formatting.
3207
3208 2019-07-01  Tom Tromey  <tromey@adacore.com>
3209
3210         * ada-exp.y (find_primitive_type): Update.
3211         * ada-lang.h (ada_lookup_symbol): Update.
3212         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3213         parameter.
3214         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3215
3216 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3217
3218         PR breakpoints/24541
3219         * gdbarch.c: Regenerate.
3220         * gdbarch.h: Regenerate.
3221         * gdbarch.sh: Add 'stap_adjust_register'.
3222         * i386-tdep.c: Include '<unordered_set>'.
3223         (i386_stap_adjust_register): New function.
3224         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3225         * stap-probe.c (stap_parse_register_operand): Call
3226         'gdbarch_stap_adjust_register'.
3227
3228 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3229
3230         PR python/24742
3231         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3232         * python/python.c (do_start_initialization): Use 'xmalloc'
3233         instead of 'PyMem_Malloc'.
3234
3235 2019-06-28  Tom Tromey  <tromey@adacore.com>
3236
3237         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3238         for Ada.
3239
3240 2019-06-27  Tom Tromey  <tromey@adacore.com>
3241
3242         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3243         objfile_key.
3244         (arm_find_mapping_symbol, arm_record_special_symbol)
3245         (_initialize_arm_tdep): Update.
3246         (arm_objfile_data_free): Remove.
3247
3248 2019-06-27  Tom Tromey  <tromey@adacore.com>
3249
3250         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3251         to cp_print_static_field.
3252
3253 2019-06-26  Tom Tromey  <tromey@adacore.com>
3254
3255         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3256         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3257         declare.
3258
3259 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3260
3261         * features/aarch64-core.c (create_feature_aarch64_core):
3262         Regenerate.
3263         * features/aarch64-core.xml: Add cpsr flags.
3264
3265 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3266
3267         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3268         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3269
3270 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3271
3272         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3273         field.
3274         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3275         use.
3276         (arm_record_special_symbol): Don't insert new symbol in sorted
3277         position, push it at the end.
3278
3279 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3280
3281         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3282         (arm_mapping_symbol_s): Remove.
3283         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3284         (arm_mapping_symbol_vec): New typedef.
3285         (struct arm_per_objfile): Add constructor.
3286         <section_maps>: Change type to
3287         std::unique_ptr<arm_mapping_symbol_vec[]>.
3288         (arm_compare_mapping_symbols): Remove.
3289         (arm_find_mapping_symbol): Adjust to section_maps type change.
3290         (arm_objfile_data_free): Call delete on arm_per_objfile.
3291         (arm_record_special_symbol): Adjust to section_maps type change.
3292         Allocate arm_per_objfile with new.
3293
3294 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3295
3296         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3297         with the command prefix.
3298
3299 2019-06-25  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3302         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3303
3304 2019-06-25  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3307         type.
3308         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3309         protected.
3310
3311 2019-06-25  Tom Tromey  <tom@tromey.com>
3312
3313         * tui/tui-winsource.c
3314         (tui_source_window_base::set_is_exec_point_at): Add check against
3315         LOA_ADDRESS.
3316
3317 2019-06-25  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-source.c (tui_set_source_content): Don't check before
3320         xfree.
3321         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3322
3323 2019-06-25  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-winsource.h (tui_update_source_window_as_is)
3326         (tui_alloc_source_buffer, tui_line_is_displayed)
3327         (tui_addr_is_displayed): Change type of win_info.
3328         * tui/tui-winsource.c (tui_update_source_window_as_is)
3329         (tui_clear_source_content, tui_show_source_line)
3330         (tui_show_source_content, tui_source_window_base::refill)
3331         (tui_source_window_base::set_is_exec_point_at)
3332         (tui_source_window_base::set_is_exec_point_at)
3333         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3334         (tui_alloc_source_buffer, tui_line_is_displayed)
3335         (tui_addr_is_displayed): Change type of win_info.  Update.
3336         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3337         (tui_source_window_base::do_make_visible_with_new_height):
3338         Update.
3339         * tui/tui-source.c (tui_set_source_content)
3340         (tui_set_source_content_nil)
3341         (tui_source_window::do_scroll_vertical): Update.
3342         * tui/tui-layout.c (show_layout): Update.
3343         * tui/tui-disasm.c (tui_set_disassem_content)
3344         (tui_disasm_window::do_scroll_vertical): Update.
3345         * tui/tui-data.h (tui_win_content): Remove.
3346         (struct tui_gen_win_info) <content, content_size>: Remove.
3347         (struct tui_source_element): Add initializers and destructor.
3348         (union tui_which_element, struct tui_win_element): Remove.
3349         (struct tui_source_window_base) <content>: New field.
3350         (struct tui_data_window): Remove destructor.
3351         (tui_alloc_content, tui_free_win_content)
3352         (tui_free_all_source_wins_content): Don't declare.
3353         * tui/tui-data.c (tui_initialize_static_data): Update.
3354         (init_content_element, tui_alloc_content): Remove.
3355         (~tui_gen_win_info): Update.
3356         (~tui_data_window, tui_free_all_source_wins_content)
3357         (tui_free_win_content, free_content, free_content_elements):
3358         Remove.
3359
3360 2019-06-25  Tom Tromey  <tom@tromey.com>
3361
3362         * tui/tui-winsource.h (tui_clear_source_content)
3363         (tui_erase_source_content, tui_show_source_content): Change type
3364         of win_info.
3365         * tui/tui-winsource.c (tui_clear_source_content)
3366         (tui_erase_source_content, tui_show_source_content): Change type
3367         of win_info.
3368         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3369         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3370         win_info.
3371         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3372         win_info.
3373         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3374
3375 2019-06-25  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-winsource.c (tui_clear_source_content)
3378         (tui_source_window_base::set_is_exec_point_at): Update.
3379         * tui/tui-source.c (tui_set_source_content_nil): Update.
3380         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3381         a bool.
3382         * tui/tui-data.c (init_content_element): Update.
3383
3384 2019-06-25  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3387         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3388         * tui/tui-layout.c (init_and_make_win): Update.
3389         * tui/tui.h (enum tui_win_type): Update.
3390         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3391         tui_win_is_auxillary.
3392         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3393         tui_win_is_auxillary.
3394
3395 2019-06-25  Tom Tromey  <tom@tromey.com>
3396
3397         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3398         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3399         (tui_delete_data_content_windows, tui_display_all_data)
3400         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3401         Update.
3402         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3403         * tui/tui-regs.c (tui_last_regs_line_no)
3404         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3405         (tui_show_registers): Update.
3406         (tui_show_register_group): Return void.  Update.
3407         (tui_display_registers_from, tui_display_reg_element_at_line)
3408         (tui_display_registers_from_line, tui_check_register_values):
3409         Update.
3410         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3411         member.
3412         (struct tui_data_window) <regs_content>: Now a std::vector.
3413         <regs_content_count>: Remove.
3414         (tui_add_content_elements, tui_free_data_content): Don't declare.
3415         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3416         (init_content_element): Remove DATA_WIN case.  Add assert.
3417         (tui_add_content_elements): Remove.
3418         (tui_data_window): Update.
3419         (tui_free_data_content): Remove.
3420         (free_content_elements): Remove DATA_WIN case.
3421
3422 2019-06-25  Tom Tromey  <tom@tromey.com>
3423
3424         * tui/tui-data.c (tui_data_item_window): Update.
3425         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3426         * tui/tui-windata.c (tui_display_all_data)
3427         (tui_display_data_from_line): Update.
3428         (tui_check_data_values): Remove.
3429         * tui/tui-regs.c (tui_show_register_group)
3430         (tui_display_reg_element_at_line): Update.
3431         * tui/tui-hooks.c (tui_register_changed)
3432         (tui_refresh_frame_and_register_information): Call
3433         tui_check_register_values.
3434         * tui/tui-data.h (struct tui_data_window) <data_content,
3435         data_content_count, data_type>: Remove.
3436         (enum tui_data_type): Remove.
3437
3438         * tui/tui-data.c (tui_data_window::clear_detail)
3439         (~tui_data_window): Update.
3440
3441 2019-06-25  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3444         declare.
3445         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3446         Rename from tui_first_data_item_displayed.  Update.
3447         (tui_data_window::refresh_all)
3448         (tui_data_window::do_scroll_vertical): Update.
3449         * tui/tui-data.h (struct tui_data_window)
3450         <first_data_item_displayed>: Declare new method.
3451
3452 2019-06-25  Tom Tromey  <tom@tromey.com>
3453
3454         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3455         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3456         contents...
3457         (tui_initialize_static_data): ...here.
3458
3459 2019-06-25  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3462         (tui_display_registers_from, tui_check_register_values): Update.
3463         (tui_display_register): Remove win_info parameter; update.
3464         (tui_get_register): Change type of parameters.
3465         * tui/tui-data.h (struct tui_data_element): Remove.
3466         (union tui_which_element) <data>: Remove.
3467         <data_window>: Change type.
3468         (struct tui_data_item_window): New.
3469         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3470         case.  Add assert.
3471         (~tui_data_item_window): New destructor.
3472         (free_content_elements): Remove DATA_ITEM_WIN case.
3473
3474 2019-06-25  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3477         Remove.
3478
3479 2019-06-25  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui-data.h (struct tui_command_element): Remove.
3482         (union tui_which_element) <command>: Remove.
3483         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3484         assert.
3485         (free_content_elements): Remove CMD_WIN case.
3486
3487 2019-06-25  Tom Tromey  <tom@tromey.com>
3488
3489         * tui/tui-layout.c (tui_set_layout): Update.
3490         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3491         * tui/tui-data.c (layout_def): Update.
3492
3493 2019-06-25  Tom Tromey  <tom@tromey.com>
3494
3495         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3496         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3497         (tui_source_window_base::set_new_height): Update.
3498         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3499         Update.
3500         (tui_set_locator_fullname, tui_set_locator_info)
3501         (tui_show_frame_info): Update.
3502         * tui/tui-source.c (tui_set_source_content)
3503         (tui_source_is_displayed): Update.
3504         * tui/tui-layout.c (show_source_disasm_command, show_data)
3505         (show_source_or_disasm_and_command): Update.
3506         * tui/tui-disasm.c (tui_set_disassem_content)
3507         (tui_get_begin_asm_address): Update.
3508         * tui/tui-data.h (struct tui_locator_element): Remove.
3509         (union tui_which_element) <locator>: Remove.
3510         (struct tui_locator_window): New.
3511         (tui_locator_win_info_ptr): Change return type.
3512         * tui/tui-data.c (_locator): Change type.
3513         (tui_locator_win_info_ptr): Change return type.
3514         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3515         (tui_alloc_content): Add assert.
3516
3517 2019-06-25  Tom Tromey  <tom@tromey.com>
3518
3519         * tui/tui-winsource.c
3520         (tui_exec_info_window::maybe_allocate_content): New method.
3521         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3522         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3523         (make_source_or_disasm_window): Add cast.
3524         * tui/tui-data.h (union tui_which_element) <simple_string>:
3525         Remove.
3526         (struct tui_source_info): New.
3527         (struct tui_source_window_base) <execution_info>: Change type.
3528         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3529         case, and add assert.
3530         (tui_alloc_content): Add assert.
3531
3532 2019-06-25  Tom Tromey  <tom@tromey.com>
3533
3534         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3535         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3536         * tui/tui-data.c (tui_alloc_win_info): Remove.
3537
3538 2019-06-25  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3541         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3542         can_highlight.
3543
3544 2019-06-25  Tom Tromey  <tom@tromey.com>
3545
3546         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3547         make_visible_with_new_height method.
3548         (tui_win_info::make_visible_with_new_height): New method.
3549         (tui_source_window_base::do_make_visible_with_new_height)
3550         (tui_data_window::do_make_visible_with_new_height)
3551         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3552         (make_visible_with_new_height): Remove.
3553         (tui_resize_all, tui_adjust_win_heights): Use
3554         make_visible_with_new_height method.
3555         * tui/tui-data.h (struct tui_win_info)
3556         <do_make_visible_with_new_height, make_visible_with_new_height>:
3557         New methods.
3558         (struct tui_source_window_base, struct tui_data_window)
3559         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3560         methods.
3561
3562 2019-06-25  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3565         method.
3566         (update_tab_width): Call update_tab_width method.
3567         * tui/tui-data.h (struct tui_win_info)
3568         (struct tui_source_window_base) <update_tab_width>: New methods.
3569
3570 2019-06-25  Tom Tromey  <tom@tromey.com>
3571
3572         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3573         parameter.
3574         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3575         parameter.
3576         (tui_gen_win_info::make_visible): Update.
3577         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3578         parameter.
3579         * tui/tui-data.h (enum tui_box): New enum.
3580         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3581
3582 2019-06-25  Tom Tromey  <tom@tromey.com>
3583
3584         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3585         init_and_make_win for EXEC_INFO_WIN.
3586         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3587         longer inline.
3588         (struct tui_win_info) <~tui_win_info>: Inline.
3589         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3590         Don't declare.
3591         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3592         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3593         Remove.
3594         (tui_initialize_static_data): Update.
3595         (~tui_gen_win_info): Handle more cleanup here.
3596         (~tui_source_window_base): Delete "execution_info".
3597         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3598
3599 2019-06-25  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-layout.c (make_command_window): Don't set
3602         can_highlight.
3603         (show_source_disasm_command): Call the reset method.
3604         (show_data): Don't set can_highlight.  Call the reset method.
3605         (tui_gen_win_info::reset): Rename from init_gen_win_info
3606         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3607         (show_source_or_disasm_and_command): Call the reset method.
3608         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3609         (struct tui_cmd_window): Set can_highlight.
3610
3611 2019-06-25  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3614         from make_visible.
3615         (tui_make_visible, tui_make_invisible): Rewrite.
3616         (tui_win_info::make_visible): Remove.
3617         (tui_source_window_base::make_visible): Update.
3618         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3619         method.  Moved from...
3620         (struct tui_win_info) <make_visible>: ...here.
3621
3622 2019-06-25  Tom Tromey  <tom@tromey.com>
3623
3624         * tui/tui-winsource.c
3625         (tui_source_window_base::do_scroll_horizontal): Remove direction
3626         parameter.
3627         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3628         direction parameter.
3629         * tui/tui-win.c (tui_win_info::forward_scroll)
3630         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3631         (tui_win_info::right_scroll): Update.
3632         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3633         direction parameter.
3634         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3635         direction parameter.
3636         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3637         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3638         Remove direction parameter.
3639         (struct tui_source_window_base, struct tui_source_window)
3640         (struct tui_disasm_window, struct tui_data_window)
3641         (struct tui_cmd_window): Update.
3642
3643 2019-06-25  Tom Tromey  <tom@tromey.com>
3644
3645         * tui/tui-winsource.h (tui_set_exec_info_content)
3646         (tui_show_exec_info_content, tui_erase_exec_info_content)
3647         (tui_clear_exec_info_content, tui_update_exec_info): Change
3648         argument to tui_source_window_base.
3649         * tui/tui-winsource.c (tui_set_exec_info_content)
3650         (tui_show_exec_info_content, tui_erase_exec_info_content)
3651         (tui_clear_exec_info_content, tui_update_exec_info): Change
3652         argument to tui_source_window_base.
3653
3654 2019-06-25  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3657         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3658
3659 2019-06-25  Tom Tromey  <tom@tromey.com>
3660
3661         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3662         check.
3663
3664 2019-06-25  Tom Tromey  <tom@tromey.com>
3665
3666         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3667         type to void.
3668         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3669         type to void.
3670         * tui/tui-source.c (tui_set_source_content): Update.
3671         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3672
3673 2019-06-25  Tom Tromey  <tom@tromey.com>
3674
3675         * tui/tui-win.c (window_name_completer, tui_set_focus)
3676         (tui_all_windows_info): Use name method.
3677         * tui/tui-data.h (struct tui_gen_win_info)
3678         (struct tui_source_window, struct tui_disasm_window)
3679         (struct tui_data_window, struct tui_cmd_window) <name>: New
3680         method.
3681         (tui_win_name): Don't declare.
3682         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3683         (tui_win_name): Remove.
3684
3685 2019-06-25  Tom Tromey  <tom@tromey.com>
3686
3687         * tui/tui-winsource.h (tui_update_source_window)
3688         (tui_update_source_window_as_is): Change parameter type.
3689         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3690         to be a tui_source_window_base.
3691         (tui_update_source_window_as_is): Likewise.
3692         * tui/tui-win.c (make_visible_with_new_height): Update.
3693
3694 2019-06-25  Tom Tromey  <tom@tromey.com>
3695
3696         * tui/tui-winsource.c (tui_erase_source_content)
3697         (tui_show_source_content, tui_show_exec_info_content)
3698         (tui_erase_exec_info_content): Use refresh_window method.
3699         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3700         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3701         from tui_refresh_win.
3702         (tui_data_window::refresh_window): New method.
3703         (tui_win_info::refresh, tui_source_window_base::refresh)
3704         (tui_refresh_all): Use refresh_window method.
3705         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3706         method.
3707         * tui/tui-regs.c (tui_display_register): Call refresh_window
3708         method.
3709         * tui/tui-layout.c (show_source_disasm_command)
3710         (show_source_or_disasm_and_command): Call refresh_window method.
3711         * tui/tui-data.h (struct tui_gen_win_info)
3712         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3713         New method.
3714
3715 2019-06-25  Tom Tromey  <tom@tromey.com>
3716
3717         * tui/tui.c (tui_rl_other_window, tui_enable)
3718         (tui_is_window_visible, tui_get_command_dimension): Update.
3719         * tui/tui-winsource.c (tui_update_source_window_as_is)
3720         (tui_clear_source_content, tui_erase_source_content)
3721         (tui_show_source_line, tui_source_window_base::refill)
3722         (tui_source_window_base::do_scroll_horizontal)
3723         (tui_source_window_base::set_is_exec_point_at)
3724         (tui_update_breakpoint_info, tui_set_exec_info_content)
3725         (tui_alloc_source_buffer, tui_line_is_displayed)
3726         (tui_addr_is_displayed): Update.
3727         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3728         (tui_check_and_display_highlight_if_needed)
3729         (tui_win_info::make_visible, tui_win_info::refresh)
3730         (tui_refresh_all): Update.
3731         * tui/tui-windata.c (tui_first_data_item_displayed)
3732         (tui_delete_data_content_windows, tui_erase_data_content)
3733         (tui_display_all_data, tui_data_window::refresh_all)
3734         (tui_check_data_values): Update.
3735         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3736         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3737         (tui_win_info::backward_scroll, tui_refresh_all_win)
3738         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3739         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3740         (tui_source_window_base::set_new_height)
3741         (tui_data_window::set_new_height)
3742         (make_invisible_and_set_new_height)
3743         (make_visible_with_new_height, new_height_ok)
3744         (parse_scrolling_args): Update.
3745         * tui/tui-stack.c (tui_show_frame_info): Update.
3746         * tui/tui-source.c (tui_set_source_content)
3747         (tui_set_source_content_nil, tui_source_is_displayed)
3748         (tui_source_window::do_scroll_vertical): Update.
3749         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3750         (tui_display_registers_from, tui_display_reg_element_at_line)
3751         (tui_check_register_values, tui_reg_command): Update.
3752         * tui/tui-layout.c (tui_default_win_height)
3753         (show_source_disasm_command, show_data, init_and_make_win)
3754         (show_source_or_disasm_and_command): Update.
3755         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3756         (tui_redisplay_readline, tui_mld_flush)
3757         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3758         (tui_getc): Update.
3759         * tui/tui-disasm.c (tui_set_disassem_content)
3760         (tui_disasm_window::do_scroll_vertical): Update.
3761         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3762         Now virtual.
3763         (struct tui_win_info): Derive from tui_gen_win_info.
3764         <~tui_win_info>: Mark as override.
3765         <generic>: Remove member.
3766         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3767         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3768         (~tui_data_window, ~tui_win_info)
3769         (tui_free_all_source_wins_content): Update.
3770         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3771
3772 2019-06-25  Tom Tromey  <tom@tromey.com>
3773
3774         * tui/tui-layout.c (init_and_make_win): Use new.
3775         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3776         destructor, initializers.
3777         (tui_alloc_generic_win_info): Don't declare.
3778         * tui/tui-data.c (_locator): Add argument to constructor.
3779         (source_win, disasm_win): New globals.
3780         (exec_info): Remove.
3781         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3782         Update.
3783         (tui_alloc_generic_win_info): Remove.
3784         (init_content_element): Use new.
3785         (tui_win_info::tui_win_info): Update.
3786         (free_content_elements) <case DATA_WIN>: Use delete.
3787
3788 2019-06-25  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3791         * tui/tui-windata.c (tui_first_data_item_displayed)
3792         (tui_delete_data_content_windows): Update.
3793         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3794         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3795         (tui_display_registers_from, tui_check_register_values): Update.
3796         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3797         pointer.
3798         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3799         window.
3800         (tui_free_data_content): Update.
3801         (free_content_elements) <case DATA_WIN>: Free the window.
3802
3803 2019-06-25  Tom Tromey  <tom@tromey.com>
3804
3805         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3806         Update.
3807         * tui/tui-layout.c (make_command_window)
3808         (show_source_disasm_command, show_data, init_and_make_win)
3809         (show_source_or_disasm_and_command): Update.
3810         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3811         method.
3812         <can_highight, is_highlighted>: Now bool.
3813         (tui_set_win_highlight): Don't declare.
3814         * tui/tui-data.c (tui_set_win_highlight): Remove.
3815
3816 2019-06-25  Tom Tromey  <tom@tromey.com>
3817
3818         * tui/tui-wingeneral.c (make_visible): Remove check of window
3819         type.
3820
3821 2019-06-25  Tom Tromey  <tom@tromey.com>
3822
3823         * tui/tui-win.c (tui_win_info::max_height)
3824         (tui_cmd_window::max_height): New methods.
3825         (new_height_ok): Call max_height.
3826         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3827         <max_height>: New method.
3828
3829 2019-06-25  Tom Tromey  <tom@tromey.com>
3830
3831         * tui/tui-win.c (tui_source_window_base::set_new_height)
3832         (tui_data_window::set_new_height): New methods.
3833         (make_invisible_and_set_new_height): Call set_new_height method.
3834         * tui/tui-data.h (struct tui_win_info)
3835         (struct tui_source_window_base, struct tui_data_window)
3836         <set_new_height>: New method.
3837
3838 2019-06-25  Tom Tromey  <tom@tromey.com>
3839
3840         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3841         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3842         tui_refresh_data_win.
3843         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3844         method.
3845         (tui_refresh_all_win): Call the refresh_all method.
3846         (tui_set_focus): Likewise.
3847         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3848         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3849         Likewise.
3850
3851 2019-06-25  Tom Tromey  <tom@tromey.com>
3852
3853         * tui/tui-winsource.h (tui_refill_source_window)
3854         (tui_set_is_exec_point_at): Don't declare.
3855         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3856         (tui_source_window_base::refill): Rename from
3857         tui_refill_source_window.
3858         (tui_source_window_base::do_scroll_horizontal): Update.
3859         (tui_source_window_base::set_is_exec_point_at): Rename from
3860         tui_set_is_exec_point_at.
3861         (tui_update_all_breakpoint_info): Update.
3862         * tui/tui-stack.c (tui_show_frame_info): Update.
3863         * tui/tui-layout.c (show_data): Add cast.
3864         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3865         * tui/tui-data.h (struct tui_source_window_base) <refill,
3866         set_is_exec_point_at>: New methods.
3867         (tui_source_windows, tui_add_to_source_windows): Update types.
3868         (tui_add_to_source_windows): Remove redundant declaration.
3869         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3870         (tui_source_windows): Change return type.
3871         (tui_clear_source_windows_detail): Update.
3872         (tui_add_to_source_windows): Change type of parameter.
3873         (tui_free_all_source_wins_content): Update.
3874
3875 2019-06-25  Tom Tromey  <tom@tromey.com>
3876
3877         * tui/tui-wingeneral.c (tui_win_info::refresh)
3878         (tui_source_window_base::refresh): New methods.
3879         (tui_refresh_all): Call the refresh method.
3880         * tui/tui-data.h (struct tui_win_info)
3881         (struct tui_source_window_base) <refresh>: New method.
3882
3883 2019-06-25  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui.h (tui_is_window_visible): Return bool.
3886         * tui/tui.c (tui_is_window_visible): Return bool.
3887         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3888         (tui_make_visible, tui_make_invisible)
3889         (tui_win_info::make_visible)
3890         (tui_source_window_base::make_visible, make_all_visible)
3891         (tui_make_all_visible, tui_make_all_invisible): Update.
3892         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3893         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3894         bool.
3895         (struct tui_win_info, struct tui_source_window_base)
3896         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3897         * tui/tui-data.c (tui_init_generic_part): Update.
3898
3899 2019-06-25  Tom Tromey  <tom@tromey.com>
3900
3901         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3902         (tui_source_window_base::make_visible): New methods.
3903         (make_all_visible): Make method call.
3904         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3905         (struct tui_source_window_base, struct tui_cmd_window): Override
3906         make_visible.
3907         (tui_win_is_source_type): Don't declare.
3908         * tui/tui-data.c (tui_win_is_source_type): Remove.
3909
3910 2019-06-25  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3913         NULL check.
3914
3915 2019-06-25  Tom Tromey  <tom@tromey.com>
3916
3917         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3918         Inline constructor.  Add initializers for members.
3919         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3920         constructors; now inline in class.
3921
3922 2019-06-25  Tom Tromey  <tom@tromey.com>
3923
3924         * tui/tui-regs.c (tui_show_registers): Update.
3925         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3926         bool.
3927         * tui/tui-data.c (tui_data_window::clear_detail)
3928         (tui_data_window): Update.
3929
3930 2019-06-25  Tom Tromey  <tom@tromey.com>
3931
3932         * tui/tui-windata.c (tui_display_all_data)
3933         (tui_display_data_from_line, tui_display_data_from)
3934         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3935         Update.
3936         * tui/tui-regs.c (tui_last_regs_line_no)
3937         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3938         (tui_show_registers, tui_show_register_group)
3939         (tui_display_registers_from, tui_display_reg_element_at_line)
3940         (tui_display_registers_from_line, tui_check_register_values)
3941         (tui_reg_next, tui_reg_prev): Update.
3942         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3943         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3944         tui_data_window.
3945         (struct tui_win_info) <detail>: Remove.  Add new fields from
3946         tui_data_info.
3947         (TUI_DATA_WIN): Add cast.
3948         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3949         (~tui_data_window): Simplify.
3950
3951 2019-06-25  Tom Tromey  <tom@tromey.com>
3952
3953         * tui/tui-layout.c (show_source_disasm_command)
3954         (show_source_or_disasm_and_command): Update.
3955         * tui/tui-io.c (update_cmdwin_start_line)
3956         (tui_redisplay_readline): Update.
3957         * tui/tui-data.h (struct tui_command_info): Remove.
3958         (struct tui_win_info) <detail>: Remove command_info member.
3959         (struct tui_data_window) <start_line>: New member, from
3960         tui_command_info.
3961         (TUI_CMD_WIN): Add casts.
3962
3963 2019-06-25  Tom Tromey  <tom@tromey.com>
3964
3965         * tui/tui-winsource.c (tui_update_source_window)
3966         (tui_refill_source_window)
3967         (tui_source_window_base::do_scroll_horizontal)
3968         (tui_update_breakpoint_info, tui_set_exec_info_content)
3969         (tui_show_exec_info_content, tui_erase_exec_info_content)
3970         (tui_clear_exec_info_content): Update.
3971         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3972         Update.
3973         * tui/tui-win.c (make_invisible_and_set_new_height)
3974         (make_visible_with_new_height): Update.
3975         * tui/tui-source.c (tui_set_source_content)
3976         (tui_show_symtab_source): Update.
3977         * tui/tui-layout.c (extract_display_start_addr)
3978         (show_source_disasm_command, show_data)
3979         (make_source_or_disasm_window)
3980         (show_source_or_disasm_and_command): Update.
3981         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3982         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3983         "gdbarch".
3984         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3985         to tui_source_window_base.
3986         (struct tui_win_info) <detail>: Remove source_info member.
3987         (struct tui_source_window_base) <has_locator>: Inline.
3988         Move contents from tui_source_info; rename has_locator member to
3989         m_has_locator.
3990         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3991         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3992         header file.
3993         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3994         Simplify.
3995         (tui_free_all_source_wins_content): Cast to
3996         tui_source_window_base.
3997
3998 2019-06-25  Tom Tromey  <tom@tromey.com>
3999
4000         * tui/tui-win.c (make_invisible_and_set_new_height)
4001         (make_visible_with_new_height): Call has_locator method.
4002         * tui/tui-layout.c (show_source_disasm_command, show_data)
4003         (show_source_or_disasm_and_command): Update for bool change.
4004         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4005         (tui_win_info) <has_locator>: New method.
4006         (struct tui_source_window_base) <has_locator>: New method.
4007         (tui_win_has_locator): Don't declare.
4008         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4009         from tui_win_has_locator.
4010         (tui_source_window_base): Use false, not FALSE.
4011
4012 2019-06-25  Tom Tromey  <tom@tromey.com>
4013
4014         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4015         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4016         clear_detail method directly.
4017         (tui_clear_win_detail): Remove.
4018
4019 2019-06-25  Tom Tromey  <tom@tromey.com>
4020
4021         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4022         "this", not TUI_DISASM_WIN.
4023
4024 2019-06-25  Tom Tromey  <tom@tromey.com>
4025
4026         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4027         declare.
4028         * tui/tui-winsource.c
4029         (tui_source_window_base::do_scroll_horizontal): Rename from
4030         tui_horizontal_source_scroll.
4031         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4032         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4033         from tui_vertical_data_scroll.
4034         * tui/tui-win.h (tui_scroll): Don't declare.
4035         * tui/tui-win.c (tui_win_info::forward_scroll)
4036         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4037         (tui_win_info::right_scroll): Rename and update.
4038         (tui_scroll_forward_command, tui_scroll_backward_command)
4039         (tui_scroll_left_command, tui_scroll_right_command): Update.
4040         (tui_scroll): Remove.
4041         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4042         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4043         from tui_vertical_source_scroll.
4044         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4045         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4046         from tui_vertical_disassem_scroll.
4047         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4048         do_scroll_horizontal>: New methods.
4049         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4050         Likewise.
4051         (struct tui_source_window_base): Add do_scroll_horizontal.
4052         (struct tui_source_window, struct tui_disasm_window): Add
4053         do_scroll_vertical.
4054         (struct tui_data_window, struct tui_cmd_window): Add
4055         do_scroll_horizontal and do_scroll_vertical.
4056         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4057
4058 2019-06-25  Tom Tromey  <tom@tromey.com>
4059
4060         * tui/tui-data.h (struct tui_source_window_base): New struct.
4061         (struct tui_source_window): Derive from tui_source_window_base.
4062         (struct tui_disasm_window): New struct.
4063         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4064         from tui_source_window::clear_detail.
4065         (tui_source_window_base): Rename from tui_source_window.
4066         (~tui_source_window_base): Rename from ~tui_source_window.
4067         (tui_alloc_win_info): Create a tui_disasm_window.
4068
4069 2019-06-25  Tom Tromey  <tom@tromey.com>
4070
4071         * tui/tui-data.h (struct tui_source_window)
4072         (struct tui_data_window): Declare destructors.
4073         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4074         destructors.
4075         (tui_win_info): Simplify.
4076
4077 2019-06-25  Tom Tromey  <tom@tromey.com>
4078
4079         * tui/tui-winsource.c (tui_display_main)
4080         (tui_update_source_windows_with_addr)
4081         (tui_update_all_breakpoint_info): Update.
4082         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4083         (new_height_ok, parse_scrolling_args): Update.
4084         * tui/tui-stack.c (tui_show_frame_info): Update.
4085         * tui/tui-data.h (struct tui_list): Remove.
4086         (tui_source_windows): Return a reference to a std::vector.
4087         * tui/tui-data.c (source_windows): Now a std::vector.
4088         (tui_source_windows): Change return type.
4089         (tui_clear_source_windows): Rewrite.
4090         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4091         (tui_free_all_source_wins_content): Rewrite.
4092
4093 2019-06-25  Tom Tromey  <tom@tromey.com>
4094
4095         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4096         (struct tui_data_window, struct tui_cmd_window): Declare
4097         clear_detail method.
4098         * tui/tui-data.c (tui_source_window::clear_detail)
4099         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4100         methods.
4101         (tui_clear_win_detail): Simplify.
4102
4103 2019-06-25  Tom Tromey  <tom@tromey.com>
4104
4105         * tui/tui-layout.c (make_source_window, make_disasm_window)
4106         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4107         Return the new window.
4108         (show_source_disasm_command, show_data)
4109         (show_source_or_disasm_and_command): Update.
4110
4111 2019-06-25  Tom Tromey  <tom@tromey.com>
4112
4113         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4114         parameter.  Return the new window.
4115         (show_source_disasm_command): Update and remove NULL check.
4116         (show_source_or_disasm_and_command): Update.
4117
4118 2019-06-25  Tom Tromey  <tom@tromey.com>
4119
4120         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4121
4122 2019-06-25  Tom Tromey  <tom@tromey.com>
4123
4124         * tui/tui-data.h (struct tui_win_info): Make constructor
4125         protected.  Make destructor virtual.  Add initializers.
4126         (tui_source_window, tui_data_window, tui_cmd_window): New
4127         classes.
4128         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4129         constructor.  Add "type" parameter.
4130         (tui_source_window, tui_data_window, tui_cmd_window): New
4131         constructors.
4132         (tui_alloc_win_info): Instantiate the appropriate subclass.
4133
4134 2019-06-25  Tom Tromey  <tom@tromey.com>
4135
4136         * tui/tui-win.c (tui_resize_all): Use delete.
4137         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4138         destructor.
4139         (tui_free_window): Don't declare.
4140         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4141         Update.
4142
4143 2019-06-25  Tom Tromey  <tom@tromey.com>
4144
4145         * tui/tui-data.h (struct tui_win_info): Add constructor.
4146         * tui/tui-data.c (tui_alloc_win_info): Use new.
4147         (tui_free_window): Use delete.
4148
4149 2019-06-22  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4152         declare.
4153         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4154
4155 2019-06-22  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4158         declare.
4159         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4160
4161 2019-06-22  Tom de Vries  <tdevries@suse.de>
4162
4163         * dwarf2read.c (create_addrmap_from_aranges)
4164         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4165         instead of '%zu'.
4166
4167 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4168
4169         * dwarf2read.h (dwarf2_section_info_def): Remove.
4170         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4171         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4172         std::vector<dwarf2_section_info>.
4173         (struct dwo_file) <~dwo_file>: Remove.
4174         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4175         types field.
4176         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4177         (dwarf2_read_debug_names): Likewise.
4178         (create_debug_types_hash_table): Change parameter type to
4179         array_view, adjust code accordingly.
4180         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4181         (partial_die_info::fixup): Likewise.
4182         (determine_prefix): Likewise.
4183         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4184
4185 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4186
4187         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4188         gdb_bfd_ref_ptr.
4189         <~dwo_file>: Remove call to gdb_bfd_unref.
4190         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4191         gdb_bfd_ref_ptr::get.
4192
4193 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4194
4195         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4196         type to htab_up.
4197         * dwarf2read.c (struct dwo_file): Initialize fields.
4198         <~dwo_file>: New.
4199         (free_dwo_file): Remove, move content to ~dwo_file.
4200         (struct dwo_file_deleter): Remove.
4201         (dwo_file_up>: Remove custom deleter.
4202         (free_dwo_files): Remove.
4203         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4204         dwo_files.
4205         (process_skeletonless_type_units): Call unique_ptr::get.
4206         (allocate_dwo_file_hash_table): Add deleter to created hash
4207         table.  Change return type to htab_up.
4208         (lookup_dwo_file_slot): Don't memset dwo_file, call
4209         unique_ptr::get.
4210         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4211         (create_dwo_unit_in_dwp_v2): Likewise.
4212         (open_and_init_dwo_file): Likewise.
4213         (free_dwo_file_from_slot): Remove.
4214
4215 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4216
4217         * dwarf2read.h (struct dwarf2_section_info) <readin,
4218         is_virtual>: Change type to bool.
4219         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4220         true instead of 1.
4221
4222 2019-06-19  Tom Tromey  <tom@tromey.com>
4223
4224         * tui/tui-data.h (tui_init_content_element): Don't declare.
4225
4226 2019-06-19  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-data.h (tui_init_win_info): Don't declare.
4229
4230 2019-06-19  Tom de Vries  <tdevries@suse.de>
4231
4232         * dwarf2read.h (abstract_to_concrete): Change type to
4233         std::unordered_map<sect_offset, std::vector<sect_offset>,
4234         gdb::hash_enum<sect_offset>>.
4235
4236 2019-06-19  Tom Tromey  <tromey@adacore.com>
4237
4238         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4239         EVAL_AVOID_SIDE_EFFECTS specially.
4240
4241 2019-06-19  Tom Tromey  <tromey@adacore.com>
4242
4243         * source-cache.c (highlighter): New global.
4244         (source_cache::get_source_lines): Create a highlighter on demand.
4245
4246 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * defs.h (deprecated_interactive_hook): Delete declaration.
4249         * interps.c (clear_interpreter_hooks): Remove use of
4250         deprecated_interactive_hook.
4251         * top.c (deprecated_interactive_hook): Delete definition.
4252         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4253
4254 2019-06-18  Tom de Vries  <tdevries@suse.de>
4255
4256         PR gdb/24515
4257         * dwarf2read.h (abstract_to_concrete): Change type from
4258         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4259         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4260         * dwarf2read.c (read_variable): Update.
4261         (dwarf2_fetch_die_loc_sect_off): Update.
4262
4263 2019-06-17  Tom de Vries  <tdevries@suse.de>
4264
4265         PR gdb/24617
4266         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4267         accessing parent[parent_len - 1].
4268
4269 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4270
4271         PR gdb/24364
4272         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4273         call dtrace_process_dof with NULL dof.
4274
4275 2019-06-16  Tom de Vries  <tdevries@suse.de>
4276
4277         PR gdb/24445
4278         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4279
4280 2019-06-16  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4283         (make_all_visible): Use address of member.
4284
4285 2019-06-16  Tom Tromey  <tom@tromey.com>
4286
4287         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4288         (tui_free_window, free_content, free_content_elements): Remove
4289         unnecessary cast.
4290         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4291         cast.
4292         * tui/tui-regs.c (tui_show_register_group)
4293         (tui_display_registers_from, tui_display_reg_element_at_line):
4294         Remove unnecessary cast.
4295
4296 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4297
4298         * linux-nat.c (normal_mask): Delete.
4299         (_initialize_linux_nat): Don't initialise normal_mask.
4300
4301 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4302
4303         PR gdb/24445
4304         * dwarf-index-write.h (write_psymtabs_to_index): Add
4305         dwz_basename parameter.
4306         * dwarf-index-write.c (write_gdbindex): Move file writing to
4307         write_gdbindex_1.  Change return type void.
4308         (assert_file_size): Move up, remove filename parameter.
4309         (write_gdbindex_1): New function.
4310         (write_debug_names): Change return type to void, call
4311         assert_file_size.
4312         (struct index_wip_file): New struct.
4313         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4314         file logic to index_wip_file.  Write index for dwz file if
4315         needed.
4316         (save_gdb_index_command): Pass basename of dwz file, if present.
4317         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4318         build-id of dwz file, if present.
4319         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4320         (dwarf2_get_dwz_file): Likewise.
4321         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4322         (dwarf2_get_dwz_file): Likewise.
4323
4324 2019-06-16  Tom Tromey  <tom@tromey.com>
4325
4326         * coffread.c (process_coff_symbol): Use xstrdup.
4327         * value.c (create_internalvar): Use xstrdup.
4328
4329 2019-06-16  Tom Tromey  <tom@tromey.com>
4330
4331         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4332         * breakpoint.c (stopin_command, stopat_command)
4333         (until_break_command, decode_location_default): Remove unnecessary
4334         cast.
4335         * utils.c (subset_compare): Remove unnecessary cast.
4336         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4337         cast.
4338         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4339         cast.
4340         * infcmd.c (path_command): Remove unnecessary cast.
4341         * coffread.c (decode_type): Remove unnecessary cast.
4342         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4343         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4344         * tui/tui-stack.c (tui_show_locator_content)
4345         (tui_show_frame_info): Remove unnecessary cast.
4346         * tui/tui-win.c (tui_scroll_forward_command)
4347         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4348         (parse_scrolling_args): Remove unnecessary cast.
4349         * tui/tui-data.c (init_win_info, tui_del_window)
4350         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4351         (free_content_elements): Remove unnecessary cast.
4352         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4353         unnecessary cast.
4354         * tui/tui-source.c (tui_set_source_content)
4355         (tui_vertical_source_scroll): Remove unnecessary cast.
4356         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4357         cast.
4358         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4359         * tui/tui-regs.c (tui_display_registers_from)
4360         (tui_display_register): Remove unnecessary cast.
4361         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4362         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4363         (make_visible): Remove unnecessary cast.
4364         * tui/tui-winsource.c (tui_erase_source_content)
4365         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4366         unnecessary cast.
4367         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4368         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4369         * stabsread.c (read_type, read_array_type, read_range_type):
4370         Remove unnecessary cast.
4371         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4372         (parse_symbol, parse_type, upgrade_type, parse_external)
4373         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4374         unnecessary cast.
4375         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4376
4377 2019-06-16  Tom Tromey  <tom@tromey.com>
4378
4379         * tui/tui-data.c (tui_alloc_generic_win_info)
4380         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4381         checks.
4382
4383 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4384             Andrew Burgess  <andrew.burgess@embecosm.com>
4385
4386         * f-typeprint.c (f_print_type): Don't return early for not
4387         associated or not allocated types.
4388         (f_type_print_varspec_suffix): Add print_rank parameter and print
4389         ranks of array types in case they dangling.
4390         (f_type_print_base): Add print_rank parameter.
4391
4392 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4393
4394         * NEWS: Mention new MI commands.
4395         * break-catch-throw.c (enum exception_event_kind): Move to
4396         breakpoint.h.
4397         (print_mention_exception_catchpoint): Output text as a single
4398         message.
4399         (catch_exception_command_1): Rename to...
4400         (catch_exception_event): ...this, make non-static, update header
4401         command, and change some parameter types.
4402         (catch_catch_command): Update for changes to
4403         catch_exception_command_1.
4404         (catch_throw_command): Likewise.
4405         (catch_rethrow_command): Likewise.
4406         * breakpoint.c (enum exception_event_kind): Delete.
4407         * breakpoint.h (enum exception_event_kind): Moved here from
4408         break-catch-throw.c.
4409         (catch_exception_event): Declare.
4410         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4411         (mi_cmd_catch_throw): New function.
4412         (mi_cmd_catch_rethrow): New function.
4413         (mi_cmd_catch_catch): New function.
4414         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4415         'catch-catch' entries.
4416         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4417         (mi_cmd_catch_rethrow): Declare.
4418         (mi_cmd_catch_catch): Declare.
4419
4420 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * annotate.c (annotate_source_line): Change return type to void,
4423         update implementation to match.
4424         * annotate.h (annotate_source_line): Change return type to void,
4425         update header comment.
4426         * stack.c (print_frame_info): Don't change what frame information
4427         is printed based on whether annotations are on or not.
4428
4429 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4430
4431         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4432         (annotate_source): Make static.
4433         (annotate_source_line): Moved from source.c and renamed from
4434         identify_source_line.  Update the return type.
4435         * annotate.h (annotate_source): Delete declaration.
4436         (annotate_source_line): Declaration moved from source.h, and
4437         renamed from identify_source_line.  Return type updated.
4438         * source.c (identify_source_line): Moved to annotate.c and renamed
4439         to annotate_source_line.
4440         (info_line_command): Remove check of annotation_level.
4441         * source.h (identify_source_line): Move declaration to annotate.h
4442         and rename to annotate_source_line.
4443         * stack.c: Add 'annotate.h' include.
4444         (print_frame_info): Remove check of annotation_level before
4445         calling annotate_source_line.
4446
4447 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4448
4449         * source-cache.c (source_cache::get_plain_source_lines): Use
4450         open_source_file_with_line_charpos instead of just
4451         open_source_file, remove call to find_source_lines.
4452         (source_cache::get_source_lines): Likewise.
4453         * source.c (find_source_lines): Make static.
4454         (get_filename_and_charpos): Renamed into...
4455         (open_source_file_with_line_charpos): ..this along with changes to
4456         return a scoped_fd, and some other minor clean ups.
4457         (identify_source_line): Use open_source_file_with_line_charpos.
4458         (search_command_helper): Use open_source_file_with_line_charpos
4459         instead of just open_source_file, remove call to
4460         find_source_lines.
4461         * source.h (open_source_file_with_line_charpos): Declare new
4462         function.
4463         (find_source_lines): Delete declaration.
4464
4465 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4466
4467         * source.c (get_filename_and_charpos): Remove fullname
4468         parameter.
4469         (identify_source_line): Update call to get_filename_and_charpos.
4470
4471 2019-06-14  Tom Tromey  <tromey@adacore.com>
4472
4473         PR gdb/24502:
4474         * ui-style.h (skip_ansi_escape): Update comment.
4475         * ui-file.h (class no_terminal_escape_file): New class.
4476         * ui-file.c (no_terminal_escape_file::write)
4477         (no_terminal_escape_file::puts): New methods.
4478         * cli/cli-logging.c (handle_redirections): Use
4479         no_terminal_escape_file.
4480
4481 2019-06-14  Tom Tromey  <tromey@adacore.com>
4482
4483         * NEWS: Move convenience variable news above Python news.
4484
4485 2019-06-14  Tom Tromey  <tom@tromey.com>
4486
4487         * gnulib: Move directory to top-level.
4488         * configure.ac: Don't configure gnulib.
4489         * configure: Rebuild.
4490         * common/common-defs.h: Use new path to gnulib.
4491         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4492         (GNULIB_H): Remove.
4493         (INCGNU): Look in new gnulib location.
4494         (HFILES_NO_SRCDIR): Remove gnulib files.
4495         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4496         (generated_files): Remove GNULIB_H.
4497         ($(LIBGNU), all-lib): Remove targets.
4498         (distclean): Don't mention GNULIB_BUILDDIR.
4499         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4500
4501 2019-06-14  Tom Tromey  <tromey@adacore.com>
4502
4503         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4504         Warn if symbol file does not provide any symbols.
4505
4506 2019-06-14  Tom Tromey  <tromey@adacore.com>
4507
4508         * source.c (find_and_open_source): Respect basenames_may_differ.
4509
4510 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4511
4512         * annotate.c (annotate_breakpoints_invalid): Make use of
4513         scoped_restore_terminal_state.
4514         (annotate_frames_invalid): Likewise.
4515
4516 2019-06-14  Tom Tromey  <tromey@adacore.com>
4517
4518         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4519         allow assignment to an internalvar.
4520
4521 2019-06-14  Tom Tromey  <tromey@adacore.com>
4522
4523         * ada-lex.l: Allow "_" in attribute names.
4524
4525 2019-06-14  Tom Tromey  <tromey@adacore.com>
4526
4527         PR gdb/24653:
4528         * regcache.c (registers_changed): Don't call alloca.
4529         * top.c (execute_command): Don't call alloca.
4530
4531 2019-06-13  Pedro Alves  <palves@redhat.com>
4532
4533         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4534         'expression'.  When parsing an expression, error out if there's
4535         junk after "unlimited".
4536         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4537         (do_set_command): Adjust calls to is_unlimited_literal.
4538
4539 2019-06-13  Pedro Alves  <palves@redhat.com>
4540
4541         * compile/compile.c (make_compile_options_def_group): Add braces
4542         around array_view initializer.
4543         * thread.c (make_thread_apply_all_options_def_group)
4544         (make_thread_apply_all_options_def_group): Likewise.
4545
4546 2019-06-13  Pedro Alves  <palves@redhat.com>
4547
4548         * NEWS (New commands): Mention "maint test-options
4549         require-delimiter", "maint test-options unknown-is-error", "maint
4550         test-options unknown-is-operand" and "maint show
4551         test-options-completion-result".
4552         (New command options, command completion): New section.
4553         (Completion improvements): New section.
4554         Mention that you can abbreviate "unlimited".
4555
4556 2019-06-13  Pedro Alves  <palves@redhat.com>
4557
4558         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4559         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4560         * unittests/cli-utils-selftests.c (test_parse_flags)
4561         (test_parse_flags_qcs): Delete.
4562         (test_cli_utils): Don't call deleted functions.
4563
4564 2019-06-13  Pedro Alves  <palves@redhat.com>
4565
4566         * thread.c: Include "cli/cli-option.h".
4567         (tp_array_compar_ascending): Global.
4568         (tp_array_compar): Delete function.
4569         (tp_array_compar_ascending, tp_array_compar_descending): New
4570         functions.
4571         (ascending_option_def, qcs_flag_option_def)
4572         (thr_qcs_flags_option_defs)
4573         (make_thread_apply_all_options_def_group)
4574         (make_thread_apply_options_def_group): New.
4575         (thread_apply_all_command): Use gdb::option::process_options.
4576         (thread_apply_command_completer)
4577         (thread_apply_all_command_completer): New.
4578         (thread_apply_command): Use gdb::option::process_options.
4579         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4580         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4581         to generate help text of "thread apply".  Adjust "taas"'s help.
4582         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4583         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4584
4585 2019-06-13  Pedro Alves  <palves@redhat.com>
4586
4587         * thread.c (thread_apply_command): Check for invalid TID with
4588         isdigit instead of !isalpha.
4589
4590 2019-06-13  Pedro Alves  <palves@redhat.com>
4591
4592         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4593         (validate_flags_qcs): New.
4594         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4595         (validate_flags_qcs): Declare.
4596         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4597         (make_frame_apply_options_def_group): New.
4598         (frame_apply_command_count): Process options with
4599         gdb::option::process_options.
4600         (frame_apply_completer): New.
4601         (frame_apply_level_completer, frame_apply_all_completer)
4602         (frame_apply_completer): New.
4603         (_initialize_stack): Update help of "frame apply", "frame apply
4604         level", "frame apply all" and "faas" to mention supported options
4605         and install command completers.
4606         * stack.h (frame_apply_all_completer): Declare.
4607         * thread.c: Include "stack.h".
4608         (tfaas_command): Add "--".
4609         (_initialize_thread): Update help "tfaas" to mention supported
4610         options and install command completer.
4611
4612 2019-06-13  Pedro Alves  <palves@redhat.com>
4613
4614         * completer.c (complete_nested_command_line): New.
4615         (gdb_completion_word_break_characters_throw): Add assertion.
4616         * completer.h (complete_nested_command_line): Declare.
4617
4618 2019-06-13  Pedro Alves  <palves@redhat.com>
4619
4620         * stack.c (parse_backtrace_qualifiers): New.
4621         (backtrace_command): Use it.
4622         (backtrace_command_completer): Complete on qualifiers.
4623
4624 2019-06-13  Pedro Alves  <palves@redhat.com>
4625
4626         * frame.c: Include "cli/cli-option.h.
4627         (user_set_backtrace_options): New.
4628         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4629         Delete.
4630         (get_prev_frame): Adjust.
4631         (boolean_option_def, uinteger_option_def)
4632         (set_backtrace_option_defs): New.
4633         (_initialize_frame): Adjust and use
4634         gdb::option::add_setshow_cmds_for_options to install "set
4635         backtrace past-main" and "set backtrace past-entry".
4636         * frame.h: Include "cli/cli-option.h".
4637         (struct frame_print_options): Forward declare.
4638         (print_frame_arguments_all, print_frame_arguments_scalars)
4639         (print_frame_arguments_none): Declare.
4640         (print_entry_values): Delete declaration.
4641         (struct frame_print_options, user_frame_print_options): New.
4642         (struct set_backtrace_options): New.
4643         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4644         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4645         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4646         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4647         (list_args_or_locals): Add frame_print_options parameter.
4648         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4649         * python/py-framefilter.c (enumerate_args): Pass down
4650         USER_FRAME_PRINT_OPTIONS.
4651         * stack.c: Include "cli/cli-option.h".
4652         (print_frame_arguments_all, print_frame_arguments_scalars)
4653         (print_frame_arguments_none): Declare.
4654         (print_raw_frame_arguments, print_entry_values): Delete.
4655         (user_frame_print_options): New.
4656         (boolean_option_def, enum_option_def, frame_print_option_defs):
4657         New.
4658         (struct backtrace_cmd_options): New.
4659         (bt_flag_option_def): New.
4660         (backtrace_command_option_defs): New.
4661         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4662         (print_frame_arg, read_frame_arg, print_frame_args)
4663         (print_frame_info, print_frame): Add frame_print_options parameter
4664         and use it.
4665         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4666         (backtrace_command_1): Add frame_print_options and
4667         backtrace_cmd_options parameters and use them.
4668         (make_backtrace_options_def_group): New.
4669         (backtrace_command): Process command options with
4670         gdb::option::process_options.
4671         (backtrace_command_completer): New.
4672         (_initialize_stack): Extend "backtrace"'s help to mention
4673         supported options.  Install completer for "backtrace".
4674         Install some settings commands with add_setshow_cmds_for_options.
4675
4676 2019-06-13  Pedro Alves  <palves@redhat.com>
4677
4678         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4679         and that "set/show print raw frame-arguments" are now deprecated.
4680
4681         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4682         command.
4683         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4684         * stack.c (_initialize_stack): Install "set/show print
4685         raw-frame-arguments", and deprecate "set/show print raw
4686         frame-arguments".
4687         * valprint.c (_initialize_valprint): Deprecate "set/show print
4688         raw".
4689
4690 2019-06-13  Pedro Alves  <palves@redhat.com>
4691
4692         * compile/compile.c (struct compile_options): New.
4693         (compile_flag_option_def, compile_command_option_defs)
4694         (make_compile_options_def_group): New.
4695         (compile_file_command): Handle options with
4696         gdb::option::process_options.
4697         (compile_file_command_completer): New function.
4698         (compile_code_command): Handle options with
4699         gdb::option::process_options.
4700         (compile_code_command_completer): New function.
4701         (_initialize_compiler): Install completers for "compile code" and
4702         "compile file".  Mention available options in "compile code" and
4703         "compile code"'s help.
4704         * completer.c (advance_to_completion_word): New, factored out from
4705         ...
4706         (advance_to_expression_complete_word_point): ... this.
4707         (advance_to_filename_complete_word_point): New.
4708         * completer.h (advance_to_filename_complete_word_point): New
4709         declaration.
4710
4711 2019-06-13  Pedro Alves  <palves@redhat.com>
4712
4713         * compile/compile.c: Include "cli/cli-option.h".
4714         (compile_print_value): Scope data pointer is now a
4715         value_print_options pointer; adjust.
4716         (compile_print_command): Process options.  Scope data pointer is
4717         now a value_print_options pointer; adjust.
4718         (_initialize_compile): Update "compile print"'s help to include
4719         supported options.  Install a completer for "compile print".
4720         * cp-valprint.c (show_vtblprint, show_objectprint)
4721         (show_static_field_print): Delete.
4722         (_initialize_cp_valprint): Don't install "set print
4723         static-members", "set print vtbl", "set print object" here.
4724         * printcmd.c: Include "cli/cli-option.h" and
4725         "common/gdb_optional.h".
4726         (print_command_parse_format): Rework to fill in a
4727         value_print_options instead of a format_data.
4728         (print_value): Change parameter type from format_data pointer to
4729         value_print_options reference.  Adjust.
4730         (print_command_1): Process options.  Adjust to pass down a
4731         value_print_options.
4732         (print_command_completer): New.
4733         (_initialize_printcmd): Install print_command_completer as
4734         handle_brkchars completer for the "print" command.  Update
4735         "print"'s help to include supported options.
4736         * valprint.c: Include "cli/cli-option.h".
4737         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4738         here from cp-valprint.c.
4739         (boolean_option_def, uinteger_option_def)
4740         (value_print_option_defs, make_value_print_options_def_group):
4741         New.  Use gdb::option::add_setshow_cmds_for_options to install
4742         "set print elements", "set print null-stop", "set print repeats",
4743         "set print pretty", "set print union", "set print array", "set
4744         print address", "set print symbol", "set print array-indexes".
4745         * valprint.h: Include <string> and "cli/cli-option.h".
4746         (make_value_print_options_def_group): Declare.
4747         (print_value): Change parameter type from format_data pointer to
4748         value_print_options reference.
4749         (print_command_completer): Declare.
4750
4751 2019-06-13  Pedro Alves  <palves@redhat.com>
4752
4753         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4754         (COMMON_SFILES): Add maint-test-settings.c.
4755         * cli/cli-decode.c (boolean_enums): New global, factored out from
4756         ...
4757         (add_setshow_boolean_cmd): ... here.
4758         * cli/cli-decode.h (boolean_enums): Declare.
4759         * cli/cli-option.c: New file.
4760         * cli/cli-option.h: New file.
4761         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4762         factored out from ...
4763         (parse_cli_boolean_value(const char *)): ... this.
4764         (is_unlimited_literal): Change parameter type to pointer to
4765         pointer.  Adjust and advance ARG pointer.
4766         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4767         (parse_cli_var_enum): New, factored out from ...
4768         (do_set_command): ... this.  Adjust.
4769         * cli/cli-setshow.h (parse_cli_boolean_value)
4770         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4771         (parse_cli_var_enum): Declare.
4772         * cli/cli-utils.c: Include "cli/cli-option.h".
4773         (get_ulongest): New.
4774         * cli/cli-utils.h (get_ulongest): Declare.
4775         (check_for_argument): New overloads.
4776         * maint-test-options.c: New file.
4777
4778 2019-06-13  Pedro Alves  <palves@redhat.com>
4779
4780         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4781         parse a range if "-" is at the end of the string.
4782
4783 2019-06-13  Pedro Alves  <palves@redhat.com>
4784
4785         * cli/cli-setshow.c (parse_auto_binary_operation)
4786         (parse_cli_boolean_value): Don't allow "o".
4787
4788 2019-06-13  Pedro Alves  <palves@redhat.com>
4789
4790         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4791         * NEWS: Mention maint test-settings KIND.
4792         * maint-test-settings.c: New file.
4793
4794 2019-06-13  Pedro Alves  <palves@redhat.com>
4795
4796         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4797         completer.
4798         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4799         "set" completers.
4800
4801 2019-06-13  Pedro Alves  <palves@redhat.com>
4802
4803         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4804         after item.
4805
4806 2019-06-13  Pedro Alves  <palves@redhat.com>
4807
4808         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4809
4810 2019-06-13  Pedro Alves <palves@redhat.com>
4811
4812         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4813         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4814         call.
4815         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4816         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4817         calls.
4818         (check_for_argument): Skip spaces after argument.
4819
4820 2019-06-13  Pedro Alves  <palves@redhat.com>
4821
4822         * thread.c (thread_apply_command): Adjust TID parsing.
4823         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4824         detected before end of string.
4825         (tid_is_in_list): Error out if LIST is invalid.
4826
4827 2019-06-13  Pedro Alves  <palves@redhat.com>
4828
4829         * completer.c (complete_line_internal_1): Rewind completion word
4830         point.
4831         (completion_tracker::advance_custom_word_point_by): Change
4832         parameter type to int.
4833         * completer.h (completion_tracker::advance_custom_word_point_by):
4834         Likewise.
4835
4836 2019-06-13  Pedro Alves  <palves@redhat.com>
4837
4838         * completer.c (advance_to_completion_word): Handle delimiters.
4839
4840 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4841
4842         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4843
4844 2019-06-11  Tom Tromey  <tom@tromey.com>
4845
4846         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4847         (xmalloc_failed): Move to alloc.c.
4848         * alloc.c: New file.
4849         * Makefile.in (COMMON_SFILES): Add alloc.c.
4850
4851 2019-06-11  Tom Tromey  <tom@tromey.com>
4852
4853         * nat/linux-waitpid.c: Don't include server.h.
4854         (linux_debug): Remove.
4855         (my_waitpid): Update.
4856
4857 2019-06-11  Tom Tromey  <tromey@adacore.com>
4858
4859         * infcall.c (_initialize_infcall): Remove trailing newline from
4860         help.
4861         * user-regs.c (_initialize_user_regs): Remove trailing newline
4862         from help.
4863         * typeprint.c (_initialize_typeprint): Remove trailing newline
4864         from help.
4865         * reverse.c (_initialize_reverse): Remove trailing newlines from
4866         help.
4867         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4868         from help.
4869         * language.c (add_set_language_command): Remove trailing newline
4870         from help.
4871         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4872         help.
4873         * disasm.c (_initialize_disasm): Remove trailing newline from
4874         help.
4875         * top.c (init_main): Remove trailing newline from help.
4876         * interps.c (_initialize_interpreter): Remove trailing newline
4877         from help.
4878         * btrace.c (_initialize_btrace): Remove trailing newlines from
4879         help.
4880         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4881         from help.
4882         * python/python.c (_initialize_python): Remove trailing newline
4883         from help.
4884         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4885         help.
4886         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4887         from help.  Reformat some text.
4888         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4889         from help.
4890         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4891         newline from help.
4892
4893 2019-06-11  Tom Tromey  <tromey@adacore.com>
4894
4895         * darwin-nat.c (darwin_decode_exception_message)
4896         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4897
4898 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4899
4900         * valops.c (value_slice): Check for not allocated or not
4901         associated values.
4902
4903 2019-06-10  Tom de Vries  <tdevries@suse.de>
4904
4905         PR gdb/24618
4906         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4907         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4908         invalid.
4909
4910 2019-06-10  Tom de Vries  <tdevries@suse.de>
4911
4912         PR gdb/24611
4913         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4914         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4915
4916 2019-06-10  Tom de Vries  <tdevries@suse.de>
4917
4918         PR symtab/24545
4919         * symtab.c (struct demangled_name_entry): Add language field.
4920         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4921         static minimal symbol".  Set and use language field.
4922
4923 2019-06-10  Tom Tromey  <tromey@adacore.com>
4924
4925         * ada-lang.c (_initialize_ada_language): Update help text.
4926
4927 2019-06-10  Tom Tromey  <tromey@adacore.com>
4928
4929         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4930         with a newline.
4931         * guile/guile.c (handle_boot_error): Don't end warning with a
4932         newline.
4933         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4934         warning with a newline.
4935         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4936         newline.
4937         (s12z_frame_cache): Likewise.
4938         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4939         a newline.
4940         * solib-svr4.c (disable_probes_interface): Don't end warning with
4941         a newline.
4942         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4943         newline.
4944         * python/python.c (do_finish_initialization): Don't end warning
4945         with a newline.
4946
4947 2019-06-10  Tom Tromey  <tom@tromey.com>
4948
4949         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4950         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4951         gdbpy_enter.
4952
4953 2019-06-10  Tom Tromey  <tromey@adacore.com>
4954
4955         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4956         data.
4957         (elf_new_init): Don't call stabsread_new_init.
4958         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4959         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4960         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4961
4962 2019-06-10  Tom de Vries  <tdevries@suse.de>
4963
4964         PR symtab/16264
4965         PR symtab/24517
4966         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4967
4968 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4969
4970         * source.c (find_and_open_source): Also rewrite relative file
4971         names.
4972
4973 2019-04-26  Amos Bird  <amosbird@gmail.com>
4974
4975         * annotate.c (annotate_thread_exited): Add "thread-exited"
4976         annotation.
4977
4978 2019-06-06  Tom Tromey  <tromey@adacore.com>
4979
4980         * maint.h (class scoped_command_stats): Use
4981         DISABLE_COPY_AND_ASSIGN.
4982         <print_time>: New method.
4983         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4984         print_time.
4985         (scoped_command_stats::print_time): New method.
4986
4987 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4990         instructions of lengths 6 or 8 bytes.
4991
4992 2019-06-04  Pedro Alves  <palves@redhat.com>
4993
4994         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4995
4996         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4997         * breakpoint.c (condition_completer): Likewise.
4998         * cli/cli-dump.c (scan_expression): Likewise.
4999         * common/filestuff.c (mkdir_recursive): Likewise.
5000         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5001         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5002         (gdb_abspath): Likewise.
5003         * compile/compile-cplus-types.c
5004         (compile_cplus_instance::decl_name): Likewise.
5005         * completer.c (complete_explicit_location):
5006         (signal_completer, reg_or_group_completer_1): Likewise.
5007         * cp-support.c (cp_remove_params_if_any): Likewise.
5008         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5009         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5010         * infcmd.c (strip_bg_char): Likewise.
5011         * linespec.c (copy_token_string): Likewise.
5012         * mi/mi-main.c (output_cores): Likewise.
5013         * psymtab.c (psymtab_search_name):
5014         * symfile.c (test_set_ext_lang_command): Likewise.
5015         * target.c (target_fileio_read_stralloc): Likewise.
5016         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5017         * value.c (complete_internalvar): Likewise.
5018
5019 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5020
5021         Add objfile property to gdb.Type.
5022         * NEWS: Mention Python API addition.
5023         * python/py-type.c (typy_get_objfile): New method.
5024
5025 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5026
5027         * NEWS: Mention the new set|show style [title|highlight].
5028         Mention changes to "show style", "help" and "apropos".
5029
5030 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5031
5032         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5033         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5034         instead of print_help_for_command.
5035         (print_doc_of_command): New function.
5036         (help_list): Add 'apropos -v word' suggestion.
5037         (print_help_for_command): Style the command name using title style.
5038         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5039         (_initialize_cli_cmds): Describe -v in apropos_command help.
5040
5041 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5042
5043         * cli/cli-style.h (cli_style_option): Add name in constructor,
5044         add m_name class member, add constructor with intensity,
5045         add name class function.
5046         (cli_style_option::add_setshow_commands): Remove name argument.
5047         (highlight_style, title_style): New styles.
5048         * cli/cli-style.c (do_show): New function that shows a style
5049         characteristic styling the style name with itself.
5050         (set_style_name): New function.
5051         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5052         Update all callers according to the changes in cli/cli-style.h.
5053         * utils.h (fputs_highlighted): New function.
5054         * utils.c (fputs_highlighted): Likewise.
5055
5056 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5057
5058         * NEWS: Mention new pipe command and new convenience variables.
5059
5060 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5061
5062         * cli/cli-cmds.c (pipe_command): New function.
5063         (_initialize_cli_cmds): Call add_com for pipe_command.
5064         Define | as an alias for pipe.
5065         (exit_status_set_internal_vars): New function.
5066         (shell_escape): Call exit_status_set_internal_vars.
5067         cli/cli-decode.c (find_command_name_length): Recognize | as
5068         a single character command.
5069
5070 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5071
5072         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5073         top.c (execute_command_to_ui_file): New function, mostly a copy
5074         of execute_command_to_string.
5075         (execute_command_to_string): Implement by calling
5076         execute_command_to_ui_file.
5077
5078 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5079
5080         * top.h (saved_command_line): Remove declaration.
5081         * top.c (previous_saved_command_line, previous_repeat_arguments):
5082         New variables.
5083         (saved_command_line): Make static, define together with other
5084         'repeat variables'.
5085         (dont_repeat): Clear repeat_arguments.
5086         (repeat_previous, get_saved_command_line, save_command_line):
5087         New functions.
5088         (gdb_init): Initialize saved_command_line
5089         and previous_saved_command_line.
5090         * main.c (captured_main_1): Remove saved_command_line initialization.
5091         * event-top.c (handle_line_of_input): Update to use
5092         the new 'repeat' related functions instead of direct access to
5093         saved_command_line.
5094         * command.h (repeat_previous, get_saved_command_line,
5095         save_command_line): New declarations.
5096         (dont_repeat): Add comment.
5097
5098 2019-05-30  Tom Tromey  <tromey@adacore.com>
5099
5100         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5101         Fix comment.
5102         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5103
5104 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5105
5106         PR cli/24587
5107         * completer.c (complete): Initialize variable word.
5108
5109 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5110
5111         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5112         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5113         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5114         'body' is NULL to the outter 'if', protecting the '!is_define'
5115         situation as well.
5116
5117 2019-05-29  Tom Tromey  <tromey@adacore.com>
5118
5119         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5120         (dwarf_unknown): New function.
5121         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5122         (dwarf_type_encoding_name): Use dwarf_unknown.
5123
5124 2019-05-29  Tom Tromey  <tromey@adacore.com>
5125
5126         PR c++/20020:
5127         * cp-valprint.c (cp_print_value_fields): Call
5128         cp_print_static_field inside "try".
5129
5130 2019-05-29  Tom Tromey  <tromey@adacore.com>
5131
5132         * inflow.c (struct terminal_info): Add default operator=.
5133         * configure: Rebuild.
5134         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5135         -Wdeprecated-copy-dtor, -Wredundant-move.
5136
5137 2019-05-29  Tom Tromey  <tromey@adacore.com>
5138
5139         * NEWS: Add entry.
5140         * infcmd.c (print_return_value_1): Handle finish_print
5141         option.
5142         (show_print_finish): New function.
5143         (_initialize_infcmd): Add "set/show print finish" commands.
5144         * valprint.c (user_print_options): Initialize new member.
5145         * valprint.h (struct value_print_options) <finish_print>: New
5146         member.
5147
5148 2019-05-28  Tom Tromey  <tromey@adacore.com>
5149
5150         * ada-lang.c (ada_remove_Xbn_suffix)
5151         (find_old_style_renaming_symbol)
5152         (parse_old_style_renaming): Remove.
5153         (ada_find_renaming_symbol): Don't call
5154         find_old_style_renaming_symbol.
5155         (ada_is_renaming_symbol): Rename from
5156         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5157         bool.  Now static.
5158         (ada_read_var_value): Update and simplify.
5159         * ada-exp.y (write_var_or_type): Remove old code.
5160
5161 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5162
5163         * event-top.c: Remove include comment.
5164         * inflow.c (class scoped_ignore_sigttou): Move from here...
5165         * inflow.h (class scoped_ignore_sigttou): ...to here.
5166         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5167         * top.c:  Remove include comment.
5168
5169 2019-05-27  Tom Tromey  <tom@tromey.com>
5170
5171         * NEWS: Fix typo.
5172
5173 2019-05-22  Tom Tromey  <tromey@adacore.com>
5174
5175         * target.c (target_follow_exec): Constify parameter.
5176         * target-delegates.c: Rebuild.
5177         * remote.c (remote_target::follow_exec): Constify parameter.
5178         * infrun.c (follow_exec): Constify parameter.
5179         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5180         (target_follow_exec): Likewise.
5181
5182 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5183
5184         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5185         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5186
5187 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5188
5189         * NEWS: Add debugredirect and testsuite sections.
5190
5191 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5192
5193         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5194         target descriptions using exclusively floating point register name
5195         aliases.
5196
5197 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5198
5199         PR gdb/18644:
5200         * f-lang.c (build_fortran_types): Handle the case where
5201         gdbarch_floatformat_for_type returns a nullptr.
5202
5203 2019-05-21  Tom de Vries  <tdevries@suse.de>
5204
5205         PR cli/24587
5206         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5207
5208 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5209
5210         PR gdb/18644:
5211         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5212         16-byte floats.
5213         * i386-tdep.c (i386_floatformat_for_type): Use
5214         floatformats_ia64_quad for the 16-byte floating point component
5215         within a fortran 32-byte complex number.
5216
5217 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5220         delete default constructor.
5221         (find_partial_die): Update to return const struct.
5222         (partial_die_parent_scope): Move variable declaration into scope
5223         of its use and change its type to auto.
5224         (guess_partial_die_structure_name): Likewise.
5225         (partial_die_info::fixup): Likewise.
5226
5227 2019-05-17  Tom Tromey  <tromey@adacore.com>
5228
5229         * source.c (find_and_open_source): Remove cast.
5230
5231 2019-05-17  Tom Tromey  <tromey@adacore.com>
5232
5233         * annotate.c (annotate_source): Make "filename" const.
5234         * annotate.h (annotate_source): Use const.
5235
5236 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5237
5238         * disasm.c (set_disassembler_options): Send errors to stderr.
5239
5240 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5241
5242         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5243         (cli_interp_base::set_logging): Check debug_redirect.
5244         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5245         * cli/cli-logging.c (debug_redirect): Add static variable.
5246         (pop_output_files): Add default param.
5247         (handle_redirections): Print debug setting.
5248         (show_logging_command): Likewise.
5249         (_initialize_cli_logging): Add debugredirect command.
5250         * interps.c (current_interp_set_logging): Add debug_redirect
5251         parameter.
5252         * interps.h (set_logging): Add debug_redirect parameter.
5253         (current_interp_set_logging): Likewise.
5254         * mi/mi-common.h: Likewise.
5255         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5256
5257 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5258             Tom Tromey  <tromey@adacore.com>
5259
5260         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5261         directly.
5262         * cli/cli-interp.h (make_logging_output): Remove declaration.
5263         * cli/cli-logging.c (make_logging_output): Remove function.
5264         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5265         directly.
5266         * ui-file.c (tee_file::tee_file): Remove bools.
5267         (tee_file::~tee_file): Remove deletes.
5268         * ui-file.h (tee_file): Remove bools.
5269
5270 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5271
5272         * mi/mi-cmds.h (mi_cmd_complete): New function.
5273         * mi/mi-main.c (mi_cmd_complete): Likewise.
5274         * mi/mi-cmds.c: Define new MI command -complete.
5275         * NEWS: Mention new -complete command.
5276
5277 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5278
5279         * completer.h (complete): New function.
5280         * completer.c (complete): Likewise.
5281         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5282         function defined in completer.h.
5283
5284 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5285
5286         * MAINTAINERS (Write After Approval): Add myself.
5287
5288 2019-05-17  Tom de Vries  <tdevries@suse.de>
5289
5290         PR gdb/24094
5291         * dwarf2read.c (struct cu_partial_die_info): New struct.
5292         (find_partial_die): Return cu_partial_die_info.
5293         (partial_die_parent_scope, guess_partial_die_structure_name)
5294         (partial_die_info::fixup): Handle new return type of find_partial_die.
5295
5296 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5297
5298         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5299         "std::string", simplifying the algorithm.
5300
5301 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5302
5303         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5304         (stap_static_probe_ops::get_probes): Likewise.
5305
5306 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5307
5308         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5309         '-')" and "else if".
5310         (stap_parse_single_operand): Join checks for
5311         "gdbarch_stap_parse_special_token_p" and
5312         "gdbarch_stap_parse_special_token" in the same "if" statement.
5313         Invert check when verifying for operation on register
5314         displacement.
5315
5316 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5317
5318         * stap-probe.c (stap_get_opcode): Update comment.
5319         (stap_get_expected_argument_type): Likewise.
5320         (handle_stap_probe): Likewise.
5321
5322 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5323
5324         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5325         return type to 'bool'.  Adjust comment.  Use 'bool' when
5326         appropriate.
5327         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5328         * stap-probe.c (stap_parse_argument_1): Likewise.
5329         (stap_is_operator): Likewise.
5330         (stap_is_generic_prefix): Likewise.
5331         (stap_is_register_prefix): Likewise.
5332         (stap_is_register_indirection_prefix): Likewise.
5333         (stap_is_integer_prefix): Likewise.
5334         (stap_generic_check_suffix): Likewise.
5335         (stap_check_integer_suffix): Likewise.
5336         (stap_check_register_suffix): Likewise.
5337         (stap_check_register_indirection_suffix): Likewise.
5338         (stap_parse_register_operand): Likewise.
5339         (stap_parse_single_operand): Likewise.
5340         (stap_parse_argument_1): Likewise.
5341         (stap_probe::get_argument_count): Likewise.
5342         (stap_is_operator): Likewise.
5343
5344 2019-05-16  Tom Tromey  <tromey@adacore.com>
5345
5346         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5347         keyword to foreach.
5348
5349 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5350
5351         * linux-thread-db.c (try_thread_db_load_1): Change return type
5352         to bool.
5353         (try_thread_db_load): Likewise.
5354         (try_thread_db_load_from_pdir_1): Likewise.
5355         (try_thread_db_load_from_pdir): Likewise.
5356         (try_thread_db_load_from_sdir): Likewise.
5357         (try_thread_db_load_from_dir): Likewise.
5358         (thread_db_load_search): Likewise.
5359         (has_libpthread): Likewise.
5360         (thread_db_load): Likewise.
5361
5362 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5363
5364         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5365         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5366         NULL, and complain/return if that's the case.
5367
5368 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5369
5370         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5371         (advance, posn, abstract_read_memory): New functions.
5372         [struct mem_read_abstraction]: New struct.
5373         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5374
5375 2019-05-14  Tom Tromey  <tromey@adacore.com>
5376
5377         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5378         value is not lval_memory.
5379
5380 2019-05-14  Tom Tromey  <tromey@adacore.com>
5381
5382         * solib.c (info_sharedlibrary_command): Style the file name.
5383
5384 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5385
5386         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5387         (aarch64_vnv_type): Likewise.
5388         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5389         * common/tdesc.c: Likewise.
5390         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5391         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5392         * features/aarch64-fpu.xml: Add ieee half view.
5393         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5394         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5395         * gdbtypes.h (struct builtin_type): Likewise.
5396         (struct objfile_type): Likewise.
5397
5398 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5399
5400         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5401         typo.
5402         * location.h (string_to_event_location): Likewise.
5403
5404 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5405
5406         GDB 8.3 released.
5407
5408 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5409
5410         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5411         New variable declaration.
5412         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5413         New variable.
5414         (print_one_breakpoint): Use ui_out::test_flags and new global
5415         variable to compute use_fixed_output.
5416         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5417         Remove.
5418         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5419         (mi_multi_location_breakpoint_output_fixed): Remove.
5420         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5421         new variable.
5422         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5423         fix_multi_location_breakpoint_output flag if version >= 3.
5424         * ui-out.h (enum ui_out_flag)
5425         <fix_multi_location_breakpoint_output>: New enumerator.
5426
5427 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5428
5429         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5430
5431 2019-05-10  Tom Tromey  <tromey@adacore.com>
5432
5433         * ada-lang.c (catch_ada_completer): New function.
5434         (_initialize_ada_language): Use it.
5435
5436 2019-05-10  Tom Tromey  <tromey@adacore.com>
5437
5438         * thread.c (print_thread_info): Make "requested_threads" const.
5439         * gdbthread.h (print_thread_info): Make "requested_threads"
5440         const.
5441         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5442         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5443
5444 2019-05-08  Tom Tromey  <tom@tromey.com>
5445
5446         * gdbtypes.c (objfile_type_data): Change type.
5447         (objfile_type, _initialize_gdbtypes): Update.
5448
5449 2019-05-08  Tom Tromey  <tom@tromey.com>
5450
5451         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5452         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5453         (_initialize_dwarf2_frame): Update.
5454
5455 2019-05-08  Tom Tromey  <tom@tromey.com>
5456
5457         * objc-lang.c (objc_objfile_data): Change type.
5458         (find_methods): Update.
5459         (_initialize_objc_lang): Remove.
5460
5461 2019-05-08  Tom Tromey  <tom@tromey.com>
5462
5463         * stabsread.c (rs6000_builtin_type_data): Change type.
5464         (rs6000_builtin_type, _initialize_stabsread): Update.
5465
5466 2019-05-08  Tom Tromey  <tom@tromey.com>
5467
5468         * mips-tdep.c (mips_pdr_data): Remove.
5469         (_initialize_mips_tdep): Update.
5470
5471 2019-05-08  Tom Tromey  <tom@tromey.com>
5472
5473         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5474         (hppa_init_objfile_priv_data, read_unwind_info)
5475         (find_unwind_entry, _initialize_hppa_tdep): Update.
5476
5477 2019-05-08  Tom Tromey  <tom@tromey.com>
5478
5479         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5480         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5481         on obstack.
5482         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5483
5484 2019-05-08  Tom Tromey  <tom@tromey.com>
5485
5486         * mdebugread.c (basic_type_data): Change type.
5487         (basic_type, _initialize_mdebugread): Update.
5488
5489 2019-05-08  Tom Tromey  <tom@tromey.com>
5490
5491         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5492
5493 2019-05-08  Tom Tromey  <tom@tromey.com>
5494
5495         * nto-tdep.c (nto_inferior_data_reg): Change type.
5496         (nto_inferior_data): Update.
5497         (nto_inferior_data_cleanup, nto_new_inferior_data)
5498         (_initialize_nto_tdep): Remove.
5499         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5500
5501 2019-05-08  Tom Tromey  <tom@tromey.com>
5502
5503         * ada-lang.c (struct ada_inferior_data): Add initializers.
5504         (ada_inferior_data): Change type.
5505         (ada_inferior_data_cleanup): Remove.
5506         (get_ada_inferior_data, ada_inferior_exit)
5507         (struct ada_pspace_data): Add initializers, destructor.
5508         (ada_pspace_data_handle): Change type.
5509         (get_ada_pspace_data): Update.
5510         (ada_pspace_data_cleanup): Remove.
5511
5512 2019-05-08  Tom Tromey  <tom@tromey.com>
5513
5514         * coffread.c (struct coff_symfile_info): Add initializers.
5515         (coff_objfile_data_key): Move lower.  Change type.
5516         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5517         Update.
5518         (coff_free_info): Remove.
5519
5520 2019-05-08  Tom Tromey  <tom@tromey.com>
5521
5522         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5523         (fbsd_pspace_data_handle): Move lower.  Change type.
5524         (get_fbsd_pspace_data): Update.
5525         (fbsd_pspace_data_cleanup): Remove.
5526         (_initialize_fbsd_tdep): Update.
5527
5528 2019-05-08  Tom Tromey  <tom@tromey.com>
5529
5530         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5531         (get_ada_tasks_pspace_data): Update.
5532         (ada_tasks_pspace_data_cleanup): Remove.
5533         (_initialize_tasks): Update.
5534         (ada_tasks_inferior_data_handle): Change type.
5535         (get_ada_tasks_inferior_data): Update.
5536         (ada_tasks_inferior_data_cleanup): Remove.
5537         (struct ada_tasks_pspace_data): Add initializers.
5538
5539 2019-05-08  Tom Tromey  <tom@tromey.com>
5540
5541         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5542         * symfile-debug.c (debug_sym_get_probes): Change type.
5543         * stap-probe.c (handle_stap_probe):
5544         (stap_static_probe_ops::get_probes): Change type.
5545         * probe.h (class static_probe_ops) <get_probes>: Change type.
5546         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5547         (parse_probes_in_pspace): Update.
5548         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5549         Update.
5550         (any_static_probe_ops::get_probes): Change type.
5551         * elfread.c (elfread_data): New typedef.
5552         (probe_key): Change type.
5553         (elf_get_probes): Likewise.  Update.
5554         (probe_key_free): Remove.
5555         (_initialize_elfread): Update.
5556         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5557         Change type.
5558         (dtrace_process_dof_probe, dtrace_process_dof)
5559         (dtrace_static_probe_ops::get_probe): Change type.
5560
5561 2019-05-08  Tom Tromey  <tom@tromey.com>
5562
5563         * xcoffread.c (struct xcoff_symfile_info): Rename from
5564         coff_symfile_info.  Add initializers.
5565         (xcoff_objfile_data_key): Move lower.  Change type.
5566         (XCOFF_DATA): Rewrite.
5567         (xcoff_free_info): Remove.
5568         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5569         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5570         (xcoff_initial_scan): Update.
5571
5572 2019-05-08  Tom Tromey  <tom@tromey.com>
5573
5574         * solib-svr4.c (struct svr4_info): Add initializers and
5575         destructor.
5576         <probes_table>: Now an htab_up.
5577         (solib_svr4_pspace_data): Change type.
5578         (free_probes_table): Simplify.
5579         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5580         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5581         (probes_table_remove_objfile_probes, register_solib_event_probe)
5582         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5583         (_initialize_svr4_solib): Update.
5584
5585 2019-05-08  Tom Tromey  <tom@tromey.com>
5586
5587         * remote.c (remote_pspace_data): Change type.
5588         (remote_pspace_data_cleanup): Remove.
5589         (get_remote_exec_file, set_pspace_remote_exec_file)
5590         (_initialize_remote): Update.
5591
5592 2019-05-08  Tom Tromey  <tom@tromey.com>
5593
5594         * breakpoint.c (breakpoint_objfile_key): Change type.
5595         (get_breakpoint_objfile_data): Update.
5596         (free_breakpoint_objfile_data): Remove.
5597         (_initialize_breakpoint): Update.
5598
5599 2019-05-08  Tom Tromey  <tom@tromey.com>
5600
5601         * linux-tdep.c (struct linux_info): Add initializers.
5602         (linux_inferior_data): Move.  Change type.
5603         (invalidate_linux_cache_inf): Update.
5604         (linux_inferior_data_cleanup): Remove.
5605         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5606
5607 2019-05-08  Tom Tromey  <tom@tromey.com>
5608
5609         * auxv.c (auxv_inferior_data): Move.  Change type.
5610         (auxv_inferior_data_cleanup): Remove.
5611         (invalidate_auxv_cache_inf): Rewrite.
5612         (get_auxv_inferior_data, _initialize_auxv): Update.
5613
5614 2019-05-08  Tom Tromey  <tom@tromey.com>
5615
5616         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5617         (symfile_debug_objfile_data_key): Change type.
5618         (symfile_debug_installed, debug_qf_has_symbols)
5619         (debug_qf_find_last_source_symtab)
5620         (debug_qf_forget_cached_source_info)
5621         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5622         (debug_qf_print_stats, debug_qf_dump)
5623         (debug_qf_expand_symtabs_for_function)
5624         (debug_qf_expand_all_symtabs)
5625         (debug_qf_expand_symtabs_with_fullname)
5626         (debug_qf_map_matching_symbols)
5627         (debug_qf_expand_symtabs_matching)
5628         (debug_qf_find_pc_sect_compunit_symtab)
5629         (debug_qf_map_symbol_filenames)
5630         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5631         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5632         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5633         (debug_sym_read_linetable, debug_sym_relocate): Update.
5634         (symfile_debug_free_objfile): Remove.
5635         (install_symfile_debug_logging, _initialize_symfile_debug):
5636         Update.
5637
5638 2019-05-08  Tom Tromey  <tom@tromey.com>
5639
5640         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5641         allocate_on_obstack.
5642         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5643         (get_dwarf2_per_objfile): Update.
5644         (set_dwarf2_per_objfile): Remove.
5645         (dwarf2_has_info, dwarf2_get_section_info): Update.
5646         (dwarf2_free_objfile): Remove.
5647         (_initialize_dwarf2_read): Update.
5648
5649 2019-05-08  Tom Tromey  <tom@tromey.com>
5650
5651         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5652         initializers.
5653         <unsupported_script_warning_printed,
5654         script_not_found_warning_printed>: Now bool.
5655         (auto_load_pspace_data): Change type.
5656         (~auto_load_pspace_info): Rename from
5657         auto_load_pspace_data_cleanup.
5658         (get_auto_load_pspace_data, init_loaded_scripts_info)
5659         (clear_section_scripts, maybe_print_unsupported_script_warning)
5660         (maybe_print_script_not_found_warning, _initialize_auto_load):
5661         Update.
5662
5663 2019-05-08  Tom Tromey  <tom@tromey.com>
5664
5665         * objfiles.c (objfile_pspace_info): Add destructor and
5666         initializers.
5667         (objfiles_pspace_data): Change type.
5668         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5669         (get_objfile_pspace_data): Update.
5670         (objfiles_bfd_data): Change type.
5671         (get_objfile_bfd_data): Update.
5672         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5673
5674 2019-05-08  Tom Tromey  <tom@tromey.com>
5675
5676         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5677         Change type.
5678         (get_catch_syscall_inferior_data): Update.
5679         (catch_syscall_inferior_data_cleanup): Remove.
5680         (_initialize_break_catch_syscall): Update.
5681
5682 2019-05-08  Tom Tromey  <tom@tromey.com>
5683
5684         * inflow.c (struct terminal_info): Add destructor and
5685         initializers.
5686         (inflow_inferior_data): Change type.
5687         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5688         (get_inflow_inferior_data, inflow_inferior_exit)
5689         (swap_terminal_info, _initialize_inflow): Update.
5690
5691 2019-05-08  Tom Tromey  <tom@tromey.com>
5692
5693         * target-dcache.c (target_dcache_cleanup): Remove.
5694         (target_dcache_aspace_key): Change type.
5695         (target_dcache_init_p, target_dcache_invalidate)
5696         (target_dcache_get, target_dcache_get_or_init)
5697         (_initialize_target_dcache): Update.
5698         * dcache.h (struct dcache_deleter): New.
5699
5700 2019-05-08  Tom Tromey  <tom@tromey.com>
5701
5702         * symtab.c (struct symbol_cache): Add destructor and
5703         initializers.
5704         (symbol_cache_key): Move.  Change type.
5705         (make_symbol_cache, free_symbol_cache): Remove.
5706         (get_symbol_cache): Update.
5707         (symbol_cache_cleanup): Remove.
5708         (ALL_PSPACES, symbol_cache_flush)
5709         (maintenance_print_symbol_cache)
5710         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5711         Update.
5712
5713 2019-05-08  Tom Tromey  <tom@tromey.com>
5714
5715         * symtab.c (struct main_info): Add destructor and initializers.
5716         (main_progspace_key): Move.  Change type.
5717         (get_main_info): Update.
5718         (main_info_cleanup): Remove.
5719         (_initialize_symtab): Update.
5720
5721 2019-05-08  Tom Tromey  <tom@tromey.com>
5722
5723         * registry.h (DECLARE_REGISTRY): Define the _key class.
5724
5725 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5726
5727         * NEWS: Merge two 'New commands' sections.
5728
5729 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5730
5731         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5732         parameter and use Ada language definition instead.
5733         (ada_val_print_ptr): Remove unused language parameter.
5734         (ada_val_print_num): Remove language parameter and use Ada language
5735         definition instead.
5736         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5737         parameter.
5738         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5739         parameter and use Ada language definition instead.
5740         (ada_val_print_1): Update all ada_val_print_xxx calls.
5741         Remove language parameter.
5742         (ada_val_print): Update ada_val_print_1 call.
5743
5744 2019-05-08  Tom Tromey  <tromey@adacore.com>
5745
5746         * remote.c (remote_hw_watchpoint_limit)
5747         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5748         Now static.
5749
5750 2019-05-08  Tom Tromey  <tromey@adacore.com>
5751
5752         * maint.c (_initialize_maint_cmds): Move initialization code to
5753         remote.c.
5754         (watchdog, show_watchdog): Move to remote.c.
5755         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5756         "watchdog" static.
5757         (_initialize_remote): Move initialization code from maint.c.
5758         * defs.h (watchdog): Don't declare.
5759
5760 2019-05-08  Tom Tromey  <tromey@adacore.com>
5761
5762         * tui/tui-interp.c: Include main.h.
5763         * interps.c: Include main.h.
5764         * main.h (interpreter_p): Declare.
5765         * defs.h (interpreter_p): Don't declare.
5766
5767 2019-05-08  Tom Tromey  <tromey@adacore.com>
5768
5769         * dwarf2loc.c: Include dwarf2read.h.
5770         * defs.h (read_unsigned_leb128): Don't declare.
5771         * dwarf2read.h (read_unsigned_leb128): Declare.
5772
5773 2019-05-08  Tom Tromey  <tromey@adacore.com>
5774
5775         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5776         method.
5777
5778 2019-05-08  Tom Tromey  <tromey@adacore.com>
5779
5780         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5781         when no wrap column is set.
5782
5783 2019-05-08  Tom Tromey  <tromey@adacore.com>
5784
5785         * c-lang.c (c_get_string): Handle non-C-style arrays.
5786
5787 2019-05-08  Tom Tromey  <tromey@adacore.com>
5788
5789         * typeprint.c (print_offset_data::update): Print the bit offset,
5790         not the number of bits remaining.
5791
5792 2019-05-08  Tom Tromey  <tromey@adacore.com>
5793
5794         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5795         padding at end of comment.
5796
5797 2019-05-08  Tom Tromey  <tromey@adacore.com>
5798
5799         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5800         Compare main types.
5801
5802 2019-05-06  Tom Tromey  <tom@tromey.com>
5803
5804         * common/scoped_mmap.c: Include common-defs.h.
5805         * common/scoped_mmap.h: Don't include config.h.
5806
5807 2019-05-04  Tom Tromey  <tom@tromey.com>
5808
5809         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5810         (struct aarch64_call_info): Add initializers.
5811         <si>: Now a std::vector.
5812         (pass_on_stack, aarch64_push_dummy_call): Update.
5813
5814 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5815             Tom Tromey  <tom@tromey.com>
5816
5817         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5818         (ppc_threads): Now a std::vector.  Now static.
5819         (hwdebug_find_thread_points_by_tid)
5820         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5821         Update.
5822
5823 2019-05-04  Tom Tromey  <tom@tromey.com>
5824
5825         * arc-tdep.c (arc_tdesc_init): Return bool.
5826
5827 2019-05-04  Tom Tromey  <tom@tromey.com>
5828
5829         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5830         Use gdb_assert_not_reached.
5831
5832 2019-05-04  Tom Tromey  <tom@tromey.com>
5833
5834         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5835         "false".
5836
5837 2019-05-04  Tom Tromey  <tom@tromey.com>
5838
5839         * arc-tdep.c (arc_tdesc_init): Use bool.
5840
5841 2019-05-04  Tom Tromey  <tom@tromey.com>
5842
5843         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5844
5845 2019-05-04  Tom Tromey  <tom@tromey.com>
5846
5847         * cli/cli-cmds.c (valid_command_p): Return bool.
5848
5849 2019-05-04  Tom Tromey  <tom@tromey.com>
5850
5851         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5852         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5853
5854 2019-05-04  Raul Tambre  <raul@tambre.ee>
5855
5856         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5857         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5858         operator for comparison.
5859
5860 2019-05-04  Tom Tromey  <tom@tromey.com>
5861
5862         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5863         (lookup_partial_symbol, print_partial_symbols)
5864         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5865         (psymbol_compare): Update.
5866         (add_psymbol_to_bcache): Clear the entire psymbol.
5867         (maintenance_check_psymtabs): Update.
5868         * psympriv.h (struct partial_symbol): Don't derive from
5869         general_symbol_info.
5870         <obj_section, unrelocated_address, address,
5871         set_unrelocated_address>: Update.
5872         <ginfo>: New member.
5873         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5874         (debug_names::write_psymbols): Update.
5875
5876 2019-05-04  Tom de Vries  <tdevries@suse.de>
5877
5878         * contrib/cc-with-tweaks.sh: Support -n arg.
5879
5880 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5881
5882         * corelow.c (core_target::detach): Ensure frame cache and
5883         register caches are cleared.
5884         inferior.c (exit_inferior_1): Likewise.
5885
5886 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5887             Tom Tromey  <tom@tromey.com>
5888
5889         * dictionary.c (collate_pending_symbols_by_language): Remove
5890         "struct" from foreach.
5891         * symtab.c (lookup_global_symbol_from_objfile)
5892         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5893         foreach.
5894         * ser-tcp.c (net_open): Remove "struct" from foreach.
5895         * objfiles.c (objfile_relocate, objfile_rebase)
5896         (objfile_has_symbols): Remove "struct" from foreach.
5897         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5898         from foreach.
5899         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5900         foreach.
5901         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5902         "struct" from foreach.
5903         * ada-lang.c (create_excep_cond_exprs)
5904         (ada_exception_catchpoint_cond_string): Remove "struct" from
5905         foreach.
5906
5907 2019-05-03  Tom Tromey  <tromey@adacore.com>
5908
5909         * ada-exp.y (convert_char_literal): Check suffix of each
5910         enumerator.
5911
5912 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5913
5914         PR ada/21406:
5915         * ada-exp.y (yywrap): Don't define.
5916         * ada-lex.l (%option): Add noyywrap
5917         (yywrap): Remove.
5918
5919 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5920
5921         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5922         _WIN32_WINNT to the XP level, unless already defined to a higher
5923         level.
5924
5925         * unittests/parse-connection-spec-selftests.c:
5926         * ser-tcp.c:
5927         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5928         override.
5929
5930         * symfile.c (find_separate_debug_file): Remove colon from the
5931         drive spec of DOS/Windows file names of the target, so that the
5932         file name produced from DEBUGDIR and the target's directory will
5933         be valid on DOS/Windows systems.
5934
5935 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5936
5937         * rust-lang.c (val_print_struct): Handle printing structures
5938         containing strings.
5939
5940 2019-05-02  Tom Tromey  <tromey@adacore.com>
5941
5942         * valarith.c (_initialize_valarith): Remove.
5943
5944 2019-05-01  Tom Tromey  <tromey@adacore.com>
5945
5946         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5947         bitfields.
5948
5949 2019-05-01  Tom Tromey  <tromey@adacore.com>
5950
5951         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5952         for big-endian copies.
5953
5954 2019-04-30  Ali Tamur  <tamur@google.com>
5955         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5956         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5957         (read_3_bytes): New function.
5958
5959 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5960
5961         * windows-nat.c (main_thread_id): Delete.
5962         (handle_output_debug_string): Replace main_thread_id by
5963         current_event.dwThreadId.
5964         (fake_create_process): Likewise.
5965         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5966         Do not set main_thread_id.
5967         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5968         current_event.dwThreadId.
5969         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5970
5971 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5972
5973         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5974         Use current_event.dwThreadId instead of main_thread_id.
5975
5976 2019-04-30  Tom Tromey  <tromey@adacore.com>
5977
5978         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5979         (create_excep_cond_exprs): Iterate over program spaces.
5980         (ada_exception_catchpoint_cond_string): Examine all minimal
5981         symbols for exception types.
5982
5983 2019-04-30  Tom Tromey  <tromey@adacore.com>
5984
5985         PR c++/24470:
5986         * dwarf2read.c (process_structure_scope): Handle case where type
5987         has template parameters but no symbol was created.
5988
5989 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5990             Chris January  <chris.january@arm.com>
5991
5992         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5993         qualifier.
5994         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5995
5996 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5997
5998         * f-typeprint.c (f_print_type): Update rules for printing
5999         whitespace.
6000         (f_type_print_varspec_suffix): Likewise.
6001
6002 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6003             Chris January  <chris.january@arm.com>
6004
6005         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6006         function arguments.
6007
6008 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6009
6010         * f-lang.c (build_fortran_types): Change name of void type to
6011         lower case.
6012         * f-typeprint.c (f_type_print_base): Print the name of the void
6013         type, rather than a fixed string.
6014         * f-valprint.c (f_decorations): Use lower case void string.
6015
6016 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6017             Chris January  <chris.january@arm.com>
6018
6019         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6020         types for Fortran.
6021
6022 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6023             Chris January  <chris.january@arm.com>
6024             David Lecomber  <david.lecomber@arm.com>
6025
6026         * f-exp.y (BINOP_INTRINSIC): New token.
6027         (exp): New parser rule handling BINOP_INTRINSIC.
6028         (f77_keywords): Add new builtin procedures.
6029         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6030         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6031         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6032         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6033         (print_unop_subexp_f): New function.
6034         (print_binop_subexp_f): New function.
6035         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6036         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6037         (dump_subexp_body_f): Likewise.
6038         (operator_check_f): Likewise.
6039         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6040         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6041
6042 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6043
6044         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6045         UNOP_KIND.
6046         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6047         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6048         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6049         (operator_length_f): New fuction.
6050         (print_subexp_f): New function.
6051         (op_name_f): New function.
6052         (dump_subexp_body_f): New function.
6053         (operator_check_f): New function.
6054         (exp_descriptor_f): Replace standard expression handling functions
6055         with new functions.
6056         * gdb/fortran-operator.def: New file.
6057         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6058         * gdb/std-operator.def: Remove UNOP_KIND.
6059
6060 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6061
6062         * std-operator.def: Remove unbalanced, stray double quote
6063         character.
6064
6065 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6066             Chris January  <chris.january@arm.com>
6067             Daniel Everett  <daniel.everett@arm.com>
6068             Nick Forrington  <nick.forrington@arm.com>
6069             Richard Bunt  <richard.bunt@arm.com>
6070
6071         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6072         of depth when printing anonymous structs or unions.
6073         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6074         Don't print either the top-level value, or the children if the
6075         max-depth is exceeded.
6076         (ppscm_print_children): When printing the key of a map, allow one
6077         extra level of depth.
6078         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6079         print either the top-level value, or the children if the max-depth
6080         is exceeded.
6081         (print_children): When printing the key of a map, allow one extra
6082         level of depth.
6083         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6084         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6085         (user_print_options): Initialise max_depth field.
6086         (val_print_scalar_or_string_type_p): New function.
6087         (val_print): Check to see if the max depth has been reached.
6088         (val_print_check_max_depth): Define new function.
6089         (show_print_max_depth): New function.
6090         (_initialize_valprint): Add 'print max-depth' option.
6091         * valprint.h (struct value_print_options) <max_depth>: New field.
6092         (val_print_check_max_depth): Declare new function.
6093         * NEWS: Document new feature.
6094
6095 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6096
6097         * ada-lang.c (ada_language_defn): Initialise new field.
6098         * c-lang.c (c_is_string_type_p): New function.
6099         (c_language_defn): Initialise new field.
6100         (cplus_language_defn): Initialise new field.
6101         (asm_language_defn): Initialise new field.
6102         (minimal_language_defn): Initialise new field.
6103         * c-lang.h (c_is_string_type_p): Declare new function.
6104         * d-lang.c (d_language_defn): Initialise new field.
6105         * f-lang.c (f_is_string_type_p): New function.
6106         (f_language_defn): Initialise new field.
6107         * go-lang.c (go_is_string_type_p): New function.
6108         (go_language_defn): Initialise new field.
6109         * language.c (default_is_string_type_p): New function.
6110         (unknown_language_defn): Initialise new field.
6111         (auto_language_defn): Initialise new field.
6112         * language.h (struct language_defn) <la_is_string_type_p>: New
6113         member variable.
6114         (default_is_string_type_p): Declare new function.
6115         * m2-lang.c (m2_language_defn): Initialise new field.
6116         * objc-lang.c (objc_language_defn): Initialise new field.
6117         * opencl-lang.c (opencl_language_defn): Initialise new field.
6118         * p-lang.c (pascal_is_string_type_p): New function.
6119         (pascal_language_defn): Initialise new field.
6120         * rust-lang.c (rust_is_string_type_p): New function.
6121         (rust_language_defn): Initialise new field.
6122
6123 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6124
6125         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6126         New field.
6127         * ada-lang.c (ada_language_defn): Initialise new field.
6128         * c-lang.c (c_language_defn): Likewise.
6129         (cplus_language_defn): Likewise.
6130         (asm_language_defn): Likewise.
6131         (minimal_language_defn): Likewise.
6132         * d-lang.c (d_language_defn): Likewise.
6133         * f-lang.c (f_language_defn): Likewise.
6134         * go-lang.c (go_language_defn): Likewise.
6135         * language.c (unknown_language_defn): Likewise.
6136         (auto_language_defn): Likewise.
6137         * m2-lang.c (m2_language_defn): Likewise.
6138         * objc-lang.c (objc_language_defn): Likewise.
6139         * opencl-lang.c (opencl_language_defn): Likewise.
6140         * p-lang.c (pascal_language_defn): Likewise.
6141         * rust-lang.c (rust_language_defn): Likewise.
6142
6143 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6144
6145         * ada-lang.c (ada_is_character_type): Change return type to bool.
6146         (ada_is_string_type): Likewise.
6147         * ada-lang.h (ada_is_character_type): Update declaration
6148         (ada_is_string_type): Likewise.
6149
6150 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6151
6152         Support style in 'frame|thread apply'
6153
6154         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6155         * record.c (record_start, record_stop): Update callers of
6156         execute_command_to_string with false.
6157         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6158         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6159         methods.
6160         (class string_file): New constructor with term_out parameter.
6161         Override methods term_out and can_emit_style_escape.  New member
6162         term_out.
6163         (class stdio_file): Override can_emit_style_escape.
6164         (class tee_file): Override term_out and can_emit_style_escape.
6165         * utils.h (can_emit_style_escape): Remove.
6166         * utils.c (can_emit_style_escape): Likewise.
6167         Update all callers of can_emit_style_escape (SOMESTREAM) to
6168         SOMESTREAM->can_emit_style_escape.
6169         * source-cache.c (source_cache::get_source_lines): Likewise.
6170         * stack.c (frame_apply_command_count): Call execute_command_to_string
6171         passing the term_out characteristic of the current gdb_stdout.
6172         * thread.c (thr_try_catch_cmd): Likewise.
6173         * top.c (execute_command_to_string): pass term_out parameter
6174         to construct the string_file for the command output.
6175         * ui-file.c (term_cli_styling): New function (most code moved
6176         from utils.c can_emit_style_escape).
6177         (string_file::string_file, string_file::can_emit_style_escape,
6178         stdio_file::can_emit_style_escape, tee_file::term_out,
6179         tee_file::can_emit_style_escape): New functions.
6180
6181 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6182
6183         * NEWS: Mention the new set|show may-call-functions.
6184         * infcall.c (may_call_functions_p): New variable.
6185         (show_may_call_functions_p): New function.
6186         (call_function_by_hand_dummy): Throws an error if not
6187         may-call-functions.
6188         (_initialize_infcall): Call add_setshow_boolean_cmd for
6189         may-call-functions.
6190
6191 2019-04-25  Keith Seitz  <keiths@redhat.com>
6192
6193         PR c++/24367
6194         * cp-support.c (inspect_type): Don't attempt substitutions
6195         of symbol with the same name.
6196
6197 2019-04-25  Tom Tromey  <tromey@adacore.com>
6198
6199         PR gdb/24475:
6200         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6201         static.
6202
6203 2019-04-25  Tom Tromey  <tromey@adacore.com>
6204
6205         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6206         rvalue reference.
6207         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6208         (gdb_xml_parser::parse): Use std::move.
6209         * python/python-internal.h (gdbpy_convert_exception): Take a const
6210         reference.
6211         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6212         std::move.
6213         * python/py-utils.c (gdbpy_convert_exception): Take a const
6214         reference.
6215         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6216         Use std::move.
6217         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6218         Use std::move.
6219         * mi/mi-main.c (mi_print_exception): Take a const reference.
6220         * main.c (handle_command_errors): Take a const reference.
6221         * linespec.c (parse_linespec): Use std::move.
6222         * infcall.c (run_inferior_call): Use std::move.
6223         (call_function_by_hand_dummy): Use std::move.
6224         * exec.c (try_open_exec_file): Use std::move.
6225         * exceptions.h (exception_print, exception_fprintf)
6226         (exception_print_same): Update.
6227         * exceptions.c (print_exception, exception_print)
6228         (exception_fprintf, exception_print_same): Change parameters to
6229         const reference.
6230         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6231         * common/new-op.c: Use std::move.
6232         * common/common-exceptions.h (struct gdb_exception): Add move
6233         constructor.
6234         (struct gdb_exception_error, struct gdb_exception_quit, struct
6235         gdb_quit_bad_alloc): Change constructor to move constructor.
6236         (throw_exception): Change parameter to rvalue reference.
6237         * common/common-exceptions.c (throw_exception): Take rvalue
6238         reference.
6239         * cli/cli-interp.c (safe_execute_command): Use std::move.
6240         * breakpoint.c (insert_bp_location, location_to_sals): Use
6241         std::move.
6242
6243 2019-04-25  Tom Tromey  <tromey@adacore.com>
6244
6245         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6246         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6247         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6248         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6249         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6250         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6251         guile/scm-value.c: Use unpack.
6252         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6253         gdbscm_gdb_exception.
6254         (gdbscm_throw_gdb_exception): Likewise.
6255         (struct gdbscm_gdb_exception): New.
6256         (unpack): New function.
6257         (gdbscm_wrap): Use unpack.
6258
6259 2019-04-25  Tom Tromey  <tromey@adacore.com>
6260
6261         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6262         (gdb_rl_callback_handler): Use std::move.
6263         * common/common-exceptions.h (struct gdb_exception): Add move
6264         assignment operator.
6265         (throw_exception_sjlj): Change "exception" to const reference.
6266         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6267         (throw_exception_sjlj): Change "exception" to const reference.
6268
6269 2019-04-25  Tom Tromey  <tromey@adacore.com>
6270
6271         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6272         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6273         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6274         Update.
6275         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6276         Update.
6277         * mi/mi-interp.c (mi_interp::exec): Update.
6278         * linespec.c (parse_linespec): Update.
6279         * infcall.c (run_inferior_call): Update.
6280         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6281         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6282         (gdbscm_lookup_global_symbol): Update.
6283         * guile/scm-param.c (gdbscm_parameter_value): Update.
6284         * guile/scm-frame.c (gdbscm_frame_read_register)
6285         (gdbscm_frame_read_var): Update.
6286         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6287         * exec.c (try_open_exec_file): Update.
6288         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6289         (gdb_rl_callback_handler): Update.
6290         * common/common-exceptions.h (exception_none): Don't declare.
6291         * common/common-exceptions.c (exception_none): Don't define.
6292         (struct catcher) <exception>: Update.
6293         * cli/cli-interp.c (safe_execute_command): Update.
6294         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6295
6296 2019-04-25  Ali Tamur  <tamur@google.com>
6297
6298         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6299         (read_attribute_value): Likewise.
6300         (dwarf2_read_addr_index): Update comment.
6301         (read_str_index): Add DW_FORM_strx.
6302         (dwarf2_string_attr): Likewise.
6303         (dwarf2_const_value_attr): Likewise.
6304         (dump_die_shallow): Likewise.
6305         (dwarf2_fetch_constant_bytes): Likewise.
6306         (skip_form_bytes): Likewise.
6307         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6308
6309 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6310
6311         PR corefiles/11608
6312         PR corefiles/18187
6313         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6314         OFFSET.  Verify if current mapping contains an ELF header.
6315         (linux_find_memory_regions_full): Adjust call to
6316         dump_mapping_p.
6317
6318 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6319             Kang Li <kanglictf@gmail.com>
6320
6321         PR gdb/21600
6322
6323         * dwarf2-frame.c (read_initial_length): Be consistent about using
6324         unsigned representation of length.
6325         (decode_frame_entry_1): Likewise.  Check for wraparound of
6326         end pointer as well as buffer overflow.
6327
6328 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6329
6330         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6331         "vq".
6332
6333 2019-04-24  Tom Tromey  <tromey@adacore.com>
6334
6335         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6336
6337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6338
6339         * s12z-tdep.c (s12z_unwind_pc): Delete.
6340         (s12z_unwind_sp): Delete.
6341         (s12z_gdbarch_init): Don't register deleted functions with
6342         gdbarch.
6343
6344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6345
6346         * rl78-tdep.c (rl78_unwind_sp): Delete.
6347         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6348
6349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6350
6351         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6352         (xstormy16_unwind_pc): Delete.
6353         (xstormy16_dummy_id): Delete.
6354         (xstormy16_gdbarch_init): Don't register deleted functions with
6355         gdbarch.
6356
6357 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6358
6359         * vax-tdep.c (vax_unwind_pc): Delete.
6360         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6361
6362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6363
6364         * v850-tdep.c (v850_unwind_sp): Delete.
6365         (v850_unwind_pc): Delete.
6366         (v850_dummy_id): Delete.
6367         (v850_gdbarch_init): Don't register deleted functions with
6368         gdbarch.
6369
6370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6371
6372         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6373         (tilegx_unwind_pc): Delete.
6374         (tilegx_unwind_dummy_id): Delete.
6375         (tilegx_gdbarch_init): Don't register deleted functions with
6376         gdbarch.
6377
6378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6379
6380         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6381         (tic6x_dummy_id): Delete.
6382         (tic6x_gdbarch_init): Don't register deleted functions with
6383         gdbarch.
6384
6385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6386
6387         * sparc-tdep.c (sparc_unwind_pc): Delete.
6388         (sparc32_gdbarch_init): Don't register deleted function with
6389         gdbarch.
6390
6391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6392
6393         * sh-tdep.c (sh_unwind_sp): Delete.
6394         (sh_unwind_pc): Delete.
6395         (sh_dummy_id): Delete.
6396         (sh_gdbarch_init): Don't register deleted functions with
6397         gdbarch.
6398
6399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6400
6401         * score-tdep.c (score_unwind_sp): Delete.
6402         (score_unwind_pc): Delete.
6403         (score_dummy_id): Delete.
6404         (score_gdbarch_init): Don't register deleted functions with
6405         gdbarch.
6406
6407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6408
6409         * rx-tdep.c (rx_unwind_pc): Delete.
6410         (rx_unwind_sp): Delete.
6411         (rx_dummy_id): Delete.
6412         (rx_gdbarch_init): Don't register deleted functions with
6413         gdbarch.  Update comment.
6414
6415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6416
6417         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6418         (rs6000_dummy_id): Delete.
6419         (rs6000_gdbarch_init): Don't register deleted functions with
6420         gdbarch.
6421
6422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6423
6424         * or1k-tdep.c (or1k_dummy_id): Delete.
6425         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6426
6427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6428
6429         * nios2-tdep.c (nios2_dummy_id): Delete.
6430         (nios2_unwind_sp): Delete.
6431         (nios2_gdbarch_init): Don't register deleted functions with
6432         gdbarch.
6433
6434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * nds32-tdep.c (nds32_dummy_id): Delete.
6437         (nds32_unwind_pc): Delete.
6438         (nds32_unwind_sp): Delete.
6439         (nds32_gdbarch_init): Don't register deleted functions with
6440         gdbarch.
6441
6442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6443
6444         * msp430-tdep.c (msp430_unwind_pc): Delete.
6445         (msp430_unwind_sp): Delete.
6446         (msp430_dummy_id): Delete.
6447         (msp430_gdbarch_init): Don't register deleted functions with
6448         gdbarch.
6449
6450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6451
6452         * moxie-tdep.c (moxie_unwind_sp): Delete.
6453         (moxie_unwind_pc): Delete.
6454         (moxie_dummy_id): Delete.
6455         (moxie_gdbarch_init): Don't register deleted functions with
6456         gdbarch.
6457
6458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6459
6460         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6461         (mn10300_unwind_pc): Delete.
6462         (mn10300_unwind_sp): Delete.
6463         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6464         mn10300_unwind_sp.
6465         (mn10300_frame_unwind_init): Don't register deleted functions with
6466         gdbarch.
6467
6468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6469
6470         * mep-tdep.c (mep_unwind_pc): Delete.
6471         (mep_unwind_sp): Delete.
6472         (mep_dummy_id): Delete.
6473         (mep_gdbarch_init): Don't register deleted functions with
6474         gdbarch.
6475
6476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6477
6478         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6479         (m68hc11_unwind_sp): Delete.
6480         (m68hc11_gdbarch_init): Don't register deleted functions with
6481         gdbarch.
6482
6483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6484
6485         * m32r-tdep.c (m32r_unwind_sp): Delete.
6486         (m32r_unwind_pc): Delete.
6487         (m32r_dummy_id): Delete.
6488         (m32r_gdbarch_init): Don't register deleted functions with
6489         gdbarch.
6490
6491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6492
6493         * m32c-tdep.c (m32c_unwind_pc): Delete.
6494         (m32c_unwind_sp): Delete.
6495         (m32c_dummy_id): Delete.
6496         (m32c_gdbarch_init): Don't register deleted functions with
6497         gdbarch.
6498
6499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6500
6501         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6502         (lm32_unwind_pc): Delete.
6503         (lm32_dummy_id): Delete.
6504         (lm32_gdbarch_init): Don't register deleted functions with
6505         gdbarch.
6506
6507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6508
6509         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6510         (iq2000_unwind_pc): Delete.
6511         (iq2000_dummy_id): Delete.
6512         (iq2000_gdbarch_init): Don't register deleted functions with
6513         gdbarch.
6514
6515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6516
6517         * nds32-tdep.c (nds32_type_align): Delete.
6518         (nds32_push_dummy_call): Use type_align instead.
6519
6520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6521
6522         * arm-tdep.c (arm_type_align): Only handle vector override case.
6523         (arm_push_dummy_call): Use type_align.
6524         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6525
6526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6529         case.
6530         (pass_on_stack): Use type_align.
6531         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6532         function.
6533
6534 2019-04-23  Tom Tromey  <tromey@adacore.com>
6535
6536         * dwarf2read.c (line_header::file_name_at): Remove unused
6537         overload.
6538
6539 2019-04-23  Tom de Vries  <tdevries@suse.de>
6540
6541         PR gdb/24438
6542         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6543         invocation.
6544
6545
6546 2019-03-27  Ali Tamur  <tamur@google.com>
6547
6548         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6549         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6550         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6551         (dwarf_expr_context::get_addr_index): Likewise
6552         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6553         (symbol_needs_eval_context::get_addr_index): Likewise
6554         (disassemble_dwarf_expression): Add DW_OP_addrx
6555         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6556         (read_cutu_die_from_dwo): Update comment
6557         (skip_one_die): Add DW_FORM_addrx
6558         (read_attribute_value): Likewise
6559         (var_decode_location): Add DW_OP_addrx
6560         (dwarf2_const_value_attr): Add DW_FORM_addrx
6561         (dump_die_shallow): Likewise
6562         (dwarf2_fetch_constant_bytes): Likewise
6563         (decode_locdesc): Add DW_OP_addrx
6564         (skip_form_bytes): Add DW_FORM_addrx
6565
6566 2019-04-22  Ali Tamur  <tamur@google.com>
6567
6568         * MAINTAINERS (Write After Approval): Add self.
6569
6570 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6571
6572         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6573         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6574         (open_symbol_file_object): Likewise.
6575         (svr4_default_sos): Add info parameter.
6576         (svr4_read_so_list): Likewise.
6577         (svr4_current_sos_direct): Adjust functions calls to pass down
6578         info.
6579         (svr4_current_sos_1): Add info parameter.
6580         (svr4_current_sos): Call get_svr4_info, pass info down to
6581         svr4_current_sos_1.
6582         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6583         get_svr4_info.
6584         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6585         get_svr4_info.
6586         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6587         to get_svr4_info.
6588         (probes_table_remove_objfile_probes): Likewise.
6589         (register_solib_event_probe): Add info parameter.
6590         (solist_update_incremental): Pass info parameter down to
6591         svr4_read_so_list.
6592         (disable_probes_interface): Add info parameter.
6593         (svr4_handle_solib_event): Pass current_program_space to
6594         get_svr4_info.  Adjust disable_probes_interface cleanup.
6595         (svr4_create_probe_breakpoints): Add info parameter, pass it
6596         down to register_solib_event_probe.
6597         (svr4_create_solib_event_breakpoints): Add info parameter,
6598         pass it down to svr4_create_probe_breakpoints.
6599         (enable_break): Pass info down to
6600         svr4_create_solib_event_breakpoints.
6601         (svr4_solib_create_inferior_hook): Pass current_program_space to
6602         get_svr4_info.
6603         (svr4_clear_solib): Likewise.
6604
6605 2019-04-22  Pedro Alves  <palves@redhat.com>
6606
6607         * solib-svr4.c (svr4_free_objfile_observer): New.
6608         (probe_and_action::objfile): New field.
6609         (probes_table_htab_remove_objfile_probes)
6610         (probes_table_remove_objfile_probes): New functions.
6611         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6612         in the new probe_and_action.  Don't store the probe in 'lookup'.
6613         (svr4_create_probe_breakpoints): Pass objfile to
6614         register_solib_event_probe.
6615         (_initialize_svr4_solib): Register a free_objfile observer.
6616
6617 2019-04-19  Tom Tromey  <tom@tromey.com>
6618
6619         * common/queue.h: Remove.
6620
6621 2019-04-19  Tom Tromey  <tom@tromey.com>
6622
6623         * event-loop.c: Don't include "common/queue.h".
6624
6625 2019-04-19  Tom Tromey  <tom@tromey.com>
6626
6627         * remote.c (remote_target): Use delete.
6628         * remote-notif.h: Include <list>, not "common/queue.h".
6629         (notif_client_p): Remove typedef.
6630         (remote_notif_state): Add constructor, destructor, initializer.
6631         <notif_queue>: Now a std::list.
6632         (remote_notif_state_xfree): Don't declare.
6633         * remote-notif.c (remote_notif_process, handle_notification)
6634         (remote_notif_state_allocate): Update.
6635         (~remote_notif_state): Rename from remote_notif_state_xfree.
6636
6637 2019-04-19  Tom Tromey  <tom@tromey.com>
6638
6639         * symfile.c (reread_symbols): Update.
6640         * objfiles.c (objfile_register_static_link)
6641         (objfile_lookup_static_link): Update
6642         (~objfile) Don't delete static_links.
6643         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6644
6645 2019-04-19  Tom Tromey  <tom@tromey.com>
6646
6647         * type-stack.h (struct type_stack) <insert>: Constify string.
6648         * type-stack.c (type_stack::insert): Constify string.
6649         * gdbtypes.h (lookup_template_type): Update.
6650         (address_space_name_to_int): Update.
6651         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6652         const.
6653         (lookup_template_type): Make name const.
6654         * c-exp.y: Update rules.
6655         (lex_one_token, classify_name, classify_inner_name)
6656         (c_print_token): Update.
6657         * p-exp.y: Update rules.
6658         (yylex): Update.
6659         * f-exp.y: Update rules.
6660         (yylex): Update.
6661         * d-exp.y: Update rules.
6662         (lex_one_token, classify_name, classify_inner_name): Update.
6663         * parse.c (write_dollar_variable, copy_name): Return std::string.
6664         * parser-defs.h (copy_name): Change return type.
6665         * m2-exp.y: Update rules.
6666         (yylex): Update.
6667         * go-exp.y (lex_one_token): Update.
6668         Update rules.
6669         (classify_unsafe_function, classify_packaged_name)
6670         (classify_name, yylex): Update.
6671
6672 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6673
6674         * configure.ac: add --enable-source-highlight switch.
6675         * configure: Regenerate.
6676         * top.c (print_gdb_version): plumb --enable-source-highlight
6677         status to "show configuration".
6678
6679 2019-04-19  Tom Tromey  <tromey@adacore.com>
6680
6681         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6682         Check ADA_TYPE_P.
6683         (empty_record, ada_template_to_fixed_record_type_1)
6684         (template_to_static_fixed_type)
6685         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6686         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6687         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6688         macros.
6689
6690 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6691
6692         PR symtab/24423:
6693         * source.c (print_source_lines_base): Advance "iter" when a
6694         control character is seen.
6695
6696 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6697
6698         * inferior.h (struct infcall_suspend_state_deleter):
6699         Catch exception in destructor to avoid crash.
6700
6701 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6702
6703         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6704         close to the add_com "shell".
6705
6706 2019-04-18  Tom Tromey  <tromey@adacore.com>
6707
6708         * process-stratum-target.h (class process_stratum_target)
6709         <stratum>: Add "final".
6710
6711 2019-04-17  Tom Tromey  <tromey@adacore.com>
6712
6713         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6714         against nullptr before use.
6715
6716 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6717
6718         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6719
6720 2019-04-17  Jim Wilson  <jimw@sifive.com>
6721             Andrew Burgess  <andrew.burgess@embecosm.com>
6722
6723         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6724         code read might fail, assume 4-byte breakpoint in that case.
6725
6726 2019-04-15  Leszek Swirski  <leszeks@google.com>
6727
6728         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6729         rather than a hand-rolled POD check when checking for forced MEMORY
6730         classification.
6731
6732 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6733
6734         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6735         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6736         function.
6737         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6738         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6739         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6740         declaration.
6741
6742 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6743
6744         * aarch64-linux-nat.c
6745         (aarch64_linux_nat_target::thread_architecture): Add override.
6746         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6747         each VQ.
6748
6749 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6750
6751         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6752
6753 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6754
6755         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6756         target types of size 96-bits, add some additional comments, and
6757         check that the builtin type we found was the correct size.
6758
6759 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6760
6761         * utils.c (prompt_for_continue): Don't restore the styling at the
6762         end, as applied_style has the wrong value.  This fixes styling in
6763         long lists of file names that are interrupted by the "Continue?"
6764         prompt.
6765
6766 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6767
6768         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6769         * c-lang.c (c_language_defn): Likewise.
6770         (cplus_language_defn): Likewise.
6771         (asm_language_defn): Likewise.
6772         (minimal_language_defn): Likewise.
6773         * d-lang.c (d_language_defn): Likewise.
6774         * f-lang.c (f_language_defn): Likewise.
6775         * go-lang.c (go_language_defn): Likewise.
6776         * language.c (unknown_language_defn): Likewise.
6777         (auto_language_defn): Likewise.
6778         * language.h (struct language_defn): Remove la_magic field.
6779         (LANG_MAGIC): Delete.
6780         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6781         * objc-lang.c (objc_language_defn): Likewise.
6782         * opencl-lang.c (opencl_language_defn): Likewise.
6783         * p-lang.c (pascal_language_defn): Likewise.
6784         * rust-lang.c (rust_language_defn): Likewise.
6785
6786 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6787
6788         * riscv-tdep.c (riscv_type_align): New function.
6789         (riscv_type_alignment): Delete.
6790         (riscv_arg_location): Use 'type_align'.
6791         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6792
6793 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6794
6795         * gdbtypes.c (type_align): A struct with no non-static fields also
6796         has alignment of 1.
6797
6798 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6799
6800         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6801         component to 0.
6802         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6803         member.
6804         (riscv_struct_info::analyse): New implementation using new
6805         analyse_inner member function.
6806         (riscv_struct_info::field_offset): New member function.
6807         (riscv_struct_info::m_offsets): New member variable.
6808         (riscv_struct_info::analyse_inner): New private member function,
6809         takes the old implementation of riscv_struct_info::analyse but
6810         extended to track field offsets.
6811         (riscv_call_arg_struct): Update the struct folding special cases
6812         to handle cases where empty C++ structs, which are non-zero
6813         length, are found.
6814         (riscv_arg_location): Initialise the length of each location, a
6815         non-zero length now indicates the location is in use.
6816         (riscv_push_dummy_call): Allow for the first location having a
6817         non-zero offset when setting up arguments.
6818         (riscv_return_value): Likewise, but for return values.
6819
6820 2019-04-11  Tom Tromey  <tromey@adacore.com>
6821
6822         * utils.c (internal_vproblem): Make "msg" const.
6823
6824 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6825
6826         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6827         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6828         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6829         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6830
6831 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6832
6833         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6834         function.
6835         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6836         of amd64_collect_native_gregset.
6837         (amd64_linux_nat_target::store_registers): Likewise.
6838
6839 2019-04-10  Tom Tromey  <tom@tromey.com>
6840
6841         * symtab.c (lookup_global_symbol_from_objfile)
6842         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6843         * objfiles.h (class separate_debug_iterator): New.
6844         (class separate_debug_range): New.
6845         (struct objfile) <separate_debug_objfiles>: New method.
6846         (objfile_separate_debug_iterate): Don't declare.
6847         * objfiles.c (separate_debug_iterator::operator++): Rename from
6848         objfile_separate_debug_iterate.
6849         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6850         iterator.
6851         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6852         iterator.
6853
6854 2019-04-10  Tom Tromey  <tom@tromey.com>
6855
6856         * symfile.c (reread_symbols): Remove old comment.
6857         * objfiles.c (free_all_objfiles): Fix a typo.
6858
6859 2019-04-10  Tom Tromey  <tom@tromey.com>
6860
6861         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6862         * minsyms.c (lookup_minimal_symbol): Use foreach.
6863         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6864         (lookup_minimal_symbol_solib_trampoline): Likewise.
6865         * symfile.c (reread_symbols): Use foreach.
6866
6867 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6868             Tom Tromey  <tromey@adacore.com>
6869
6870         PR rust/24414:
6871         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6872         (rust_lex_int_test): Change "value" to be LONGEST.
6873         (rust_lex_tests): Add test for long integer literal.
6874
6875 2019-04-09  Tom Tromey  <tromey@adacore.com>
6876
6877         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6878         to bool.
6879         (extended_remote_target::attach): Update.
6880         (remote_target::remote_notice_new_inferior): Update.
6881         (remote_target::add_current_inferior_and_thread): Update.
6882         * inferior.c (exit_inferior_1): Use "false".
6883         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6884
6885 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6886
6887         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6888         the "start" command.
6889
6890 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6891
6892         * python/py-inferior.c (infpy_thread_from_thread_handle):
6893         Adjust comments to reflect renaming of thread_from_thread_handle
6894         to thread_from_handle.  Adjust keywords.  Fix type error message.
6895         (inferior_object_methods): Add thread_from_handle.  Retain
6896         thread_from_thread_handle, but mark it as deprecated.
6897
6898 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6899
6900         * gdbthread.h (find_thread_by_handle): Revise declaration.
6901         * thread.c (find_thread_by_handle): Likewise.  Adjust
6902         implementation too.
6903         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6904         support for buffer objects as handles.
6905
6906 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6907
6908         * python/py-infthread.c (thpy_thread_handle): New function.
6909         (thread_object_methods): Register thpy_thread_handle.
6910
6911 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6912
6913         * gdbthread.h (thread_to_thread_handle): Declare.
6914         * thread.c (gdbtypes.h): Include.
6915         (thread_to_thread_handle): New function.
6916
6917         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6918         (target_thread_info_to_thread_handle): Declare.
6919         * target.c (target_thread_info_to_thread_handle): New function.
6920         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6921         * target-delegates.c: Regenerate.
6922
6923         * linux-thread-db.c (class thread_db_target): Add method
6924         thread_info_to_thread_handle.
6925         (thread_db_target::thread_info_to_thread_handle): Define.
6926         * remote.c (class remote_target): Add new method
6927         thread_info_to_thread_handle.
6928         (remote_target::thread_info_to_thread_handle): Define.
6929
6930 2019-04-08  Pedro Alves  <palves@redhat.com>
6931
6932         * common/common-exceptions.c (throw_exception): Don't create
6933         named object to throw; throw directly.
6934         (throw_it): Likewise.  Don't initialize gdb_exception::message
6935         here, with new; pass FMT and AP to the ctor instead.
6936         * common/common-exceptions.h: Include <string>.
6937         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6938         const char *, va_list)): New ctor.  Use std::make_shared.
6939         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6940         errors)): Delete.
6941         (gdb_exception_error::gdb_exception_error(enum errors, const char
6942         *, va_list)): New.
6943         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6944         Add assertion.
6945         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6946         errors)): Delete.
6947         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6948         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6949         Add assertion.
6950
6951 2019-04-08  Tom Tromey  <tom@tromey.com>
6952
6953         * valops.c (value_rtti_indirect_type): Replace throw_exception
6954         with throw.
6955         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6956         with throw.
6957         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6958         throw.
6959         * target.c (target_translate_tls_address): Replace throw_exception
6960         with throw.
6961         * stack.c (frame_apply_command_count): Replace throw_exception
6962         with throw.
6963         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6964         throw.
6965         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6966         with throw.
6967         * rs6000-tdep.c (rs6000_frame_cache)
6968         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6969         * remote.c: Replace throw_exception with throw.
6970         * record-full.c (record_full_message, record_full_wait_1)
6971         (record_full_restore): Replace throw_exception with throw.
6972         * record-btrace.c:
6973         (get_thread_current_frame_id, record_btrace_start_replaying)
6974         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6975         (cmd_record_btrace_start): Replace throw_exception with throw.
6976         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6977         throw.
6978         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6979         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6980         * linespec.c:
6981         (find_linespec_symbols): Replace throw_exception with throw.
6982         * infrun.c (displaced_step_prepare, resume): Replace
6983         throw_exception with throw.
6984         * infcmd.c (post_create_inferior): Replace throw_exception with
6985         throw.
6986         * inf-loop.c (inferior_event_handler): Replace throw_exception
6987         with throw.
6988         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6989         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6990         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6991         (get_prev_frame_always, get_frame_pc_if_available)
6992         (get_frame_address_in_block_if_available, get_frame_language):
6993         Replace throw_exception with throw.
6994         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6995         throw_exception with throw.
6996         * eval.c (fetch_subexp_value, evaluate_var_value)
6997         (evaluate_funcall, evaluate_subexp_standard): Replace
6998         throw_exception with throw.
6999         * dwarf2loc.c (call_site_find_chain)
7000         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7001         Replace throw_exception with throw.
7002         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7003         with throw.
7004         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7005         throw.
7006         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7007         * completer.c (complete_line_internal): Replace throw_exception
7008         with throw.
7009         * compile/compile-object-run.c (compile_object_run): Replace
7010         throw_exception with throw.
7011         * cli/cli-script.c (process_next_line): Replace throw_exception
7012         with throw.
7013         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7014         (btrace_enable, btrace_maint_update_pt_packets): Replace
7015         throw_exception with throw.
7016         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7017         throw_exception with throw.
7018         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7019         throw_exception with throw.
7020         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7021         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7022         * aarch64-tdep.c (aarch64_make_prologue_cache)
7023         (aarch64_make_stub_cache): Replace throw_exception with throw.
7024
7025 2019-04-08  Tom Tromey  <tom@tromey.com>
7026
7027         * common/common-exceptions.c (throw_exception): Rename from
7028         throw_exception_cxx.  Remove old copy.  Make argument const.
7029         (throw_it): Create and throw exception objects directly.
7030         * common/common-exceptions.h (throw_exception): Make argument
7031         const.
7032         (struct gdb_exception_error): Add constructor.
7033         (struct gdb_exception_quit): Add constructor.
7034
7035 2019-04-08  Tom Tromey  <tom@tromey.com>
7036
7037         * common/common-exceptions.h (exception_rethrow): Don't declare.
7038         (TRY_SJLJ): Update comment.
7039         (TRY, CATCH, END_CATCH): Remove.
7040         * common/common-exceptions.c (exception_rethrow): Remove.
7041
7042 2019-04-08  Tom Tromey  <tom@tromey.com>
7043
7044         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7045         Remove.
7046         (gdb_exception_error): Rename from
7047         gdb_exception_RETURN_MASK_ERROR.
7048         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7049         (gdb_quit_bad_alloc): Update.
7050         * aarch64-tdep.c: Update.
7051         * ada-lang.c: Update.
7052         * ada-typeprint.c: Update.
7053         * ada-valprint.c: Update.
7054         * amd64-tdep.c: Update.
7055         * arch-utils.c: Update.
7056         * break-catch-throw.c: Update.
7057         * breakpoint.c: Update.
7058         * btrace.c: Update.
7059         * c-varobj.c: Update.
7060         * cli/cli-cmds.c: Update.
7061         * cli/cli-interp.c: Update.
7062         * cli/cli-script.c: Update.
7063         * common/common-exceptions.c: Update.
7064         * common/new-op.c: Update.
7065         * common/selftest.c: Update.
7066         * compile/compile-c-symbols.c: Update.
7067         * compile/compile-cplus-symbols.c: Update.
7068         * compile/compile-object-load.c: Update.
7069         * compile/compile-object-run.c: Update.
7070         * completer.c: Update.
7071         * corelow.c: Update.
7072         * cp-abi.c: Update.
7073         * cp-support.c: Update.
7074         * cp-valprint.c: Update.
7075         * darwin-nat.c: Update.
7076         * disasm-selftests.c: Update.
7077         * dtrace-probe.c: Update.
7078         * dwarf-index-cache.c: Update.
7079         * dwarf-index-write.c: Update.
7080         * dwarf2-frame-tailcall.c: Update.
7081         * dwarf2-frame.c: Update.
7082         * dwarf2loc.c: Update.
7083         * dwarf2read.c: Update.
7084         * eval.c: Update.
7085         * event-loop.c: Update.
7086         * event-top.c: Update.
7087         * exec.c: Update.
7088         * f-valprint.c: Update.
7089         * fbsd-tdep.c: Update.
7090         * frame-unwind.c: Update.
7091         * frame.c: Update.
7092         * gdbtypes.c: Update.
7093         * gnu-v3-abi.c: Update.
7094         * guile/guile-internal.h: Update.
7095         * guile/scm-block.c: Update.
7096         * guile/scm-breakpoint.c: Update.
7097         * guile/scm-cmd.c: Update.
7098         * guile/scm-disasm.c: Update.
7099         * guile/scm-frame.c: Update.
7100         * guile/scm-lazy-string.c: Update.
7101         * guile/scm-math.c: Update.
7102         * guile/scm-param.c: Update.
7103         * guile/scm-ports.c: Update.
7104         * guile/scm-pretty-print.c: Update.
7105         * guile/scm-symbol.c: Update.
7106         * guile/scm-symtab.c: Update.
7107         * guile/scm-type.c: Update.
7108         * guile/scm-value.c: Update.
7109         * i386-linux-tdep.c: Update.
7110         * i386-tdep.c: Update.
7111         * inf-loop.c: Update.
7112         * infcall.c: Update.
7113         * infcmd.c: Update.
7114         * infrun.c: Update.
7115         * jit.c: Update.
7116         * language.c: Update.
7117         * linespec.c: Update.
7118         * linux-fork.c: Update.
7119         * linux-nat.c: Update.
7120         * linux-tdep.c: Update.
7121         * linux-thread-db.c: Update.
7122         * main.c: Update.
7123         * mi/mi-cmd-break.c: Update.
7124         * mi/mi-cmd-stack.c: Update.
7125         * mi/mi-interp.c: Update.
7126         * mi/mi-main.c: Update.
7127         * objc-lang.c: Update.
7128         * p-valprint.c: Update.
7129         * parse.c: Update.
7130         * ppc-linux-tdep.c: Update.
7131         * printcmd.c: Update.
7132         * python/py-arch.c: Update.
7133         * python/py-breakpoint.c: Update.
7134         * python/py-cmd.c: Update.
7135         * python/py-finishbreakpoint.c: Update.
7136         * python/py-frame.c: Update.
7137         * python/py-framefilter.c: Update.
7138         * python/py-gdb-readline.c: Update.
7139         * python/py-inferior.c: Update.
7140         * python/py-infthread.c: Update.
7141         * python/py-lazy-string.c: Update.
7142         * python/py-linetable.c: Update.
7143         * python/py-objfile.c: Update.
7144         * python/py-param.c: Update.
7145         * python/py-prettyprint.c: Update.
7146         * python/py-progspace.c: Update.
7147         * python/py-record-btrace.c: Update.
7148         * python/py-record.c: Update.
7149         * python/py-symbol.c: Update.
7150         * python/py-type.c: Update.
7151         * python/py-unwind.c: Update.
7152         * python/py-utils.c: Update.
7153         * python/py-value.c: Update.
7154         * python/python.c: Update.
7155         * record-btrace.c: Update.
7156         * record-full.c: Update.
7157         * remote-fileio.c: Update.
7158         * remote.c: Update.
7159         * riscv-tdep.c: Update.
7160         * rs6000-aix-tdep.c: Update.
7161         * rs6000-tdep.c: Update.
7162         * rust-exp.y: Update.
7163         * rust-lang.c: Update.
7164         * s390-tdep.c: Update.
7165         * selftest-arch.c: Update.
7166         * solib-dsbt.c: Update.
7167         * solib-frv.c: Update.
7168         * solib-spu.c: Update.
7169         * solib-svr4.c: Update.
7170         * solib.c: Update.
7171         * sparc64-linux-tdep.c: Update.
7172         * stack.c: Update.
7173         * symfile-mem.c: Update.
7174         * symmisc.c: Update.
7175         * target.c: Update.
7176         * thread.c: Update.
7177         * top.c: Update.
7178         * tracefile-tfile.c: Update.
7179         * tui/tui.c: Update.
7180         * typeprint.c: Update.
7181         * unittests/cli-utils-selftests.c: Update.
7182         * unittests/parse-connection-spec-selftests.c: Update.
7183         * valops.c: Update.
7184         * valprint.c: Update.
7185         * value.c: Update.
7186         * varobj.c: Update.
7187         * windows-nat.c: Update.
7188         * x86-linux-nat.c: Update.
7189         * xml-support.c: Update.
7190
7191 2019-04-08  Tom Tromey  <tom@tromey.com>
7192
7193         * xml-support.c: Use C++ exception handling.
7194         * x86-linux-nat.c: Use C++ exception handling.
7195         * windows-nat.c: Use C++ exception handling.
7196         * varobj.c: Use C++ exception handling.
7197         * value.c: Use C++ exception handling.
7198         * valprint.c: Use C++ exception handling.
7199         * valops.c: Use C++ exception handling.
7200         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7201         handling.
7202         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7203         * typeprint.c: Use C++ exception handling.
7204         * tui/tui.c: Use C++ exception handling.
7205         * tracefile-tfile.c: Use C++ exception handling.
7206         * top.c: Use C++ exception handling.
7207         * thread.c: Use C++ exception handling.
7208         * target.c: Use C++ exception handling.
7209         * symmisc.c: Use C++ exception handling.
7210         * symfile-mem.c: Use C++ exception handling.
7211         * stack.c: Use C++ exception handling.
7212         * sparc64-linux-tdep.c: Use C++ exception handling.
7213         * solib.c: Use C++ exception handling.
7214         * solib-svr4.c: Use C++ exception handling.
7215         * solib-spu.c: Use C++ exception handling.
7216         * solib-frv.c: Use C++ exception handling.
7217         * solib-dsbt.c: Use C++ exception handling.
7218         * selftest-arch.c: Use C++ exception handling.
7219         * s390-tdep.c: Use C++ exception handling.
7220         * rust-lang.c: Use C++ exception handling.
7221         * rust-exp.y: Use C++ exception handling.
7222         * rs6000-tdep.c: Use C++ exception handling.
7223         * rs6000-aix-tdep.c: Use C++ exception handling.
7224         * riscv-tdep.c: Use C++ exception handling.
7225         * remote.c: Use C++ exception handling.
7226         * remote-fileio.c: Use C++ exception handling.
7227         * record-full.c: Use C++ exception handling.
7228         * record-btrace.c: Use C++ exception handling.
7229         * python/python.c: Use C++ exception handling.
7230         * python/py-value.c: Use C++ exception handling.
7231         * python/py-utils.c: Use C++ exception handling.
7232         * python/py-unwind.c: Use C++ exception handling.
7233         * python/py-type.c: Use C++ exception handling.
7234         * python/py-symbol.c: Use C++ exception handling.
7235         * python/py-record.c: Use C++ exception handling.
7236         * python/py-record-btrace.c: Use C++ exception handling.
7237         * python/py-progspace.c: Use C++ exception handling.
7238         * python/py-prettyprint.c: Use C++ exception handling.
7239         * python/py-param.c: Use C++ exception handling.
7240         * python/py-objfile.c: Use C++ exception handling.
7241         * python/py-linetable.c: Use C++ exception handling.
7242         * python/py-lazy-string.c: Use C++ exception handling.
7243         * python/py-infthread.c: Use C++ exception handling.
7244         * python/py-inferior.c: Use C++ exception handling.
7245         * python/py-gdb-readline.c: Use C++ exception handling.
7246         * python/py-framefilter.c: Use C++ exception handling.
7247         * python/py-frame.c: Use C++ exception handling.
7248         * python/py-finishbreakpoint.c: Use C++ exception handling.
7249         * python/py-cmd.c: Use C++ exception handling.
7250         * python/py-breakpoint.c: Use C++ exception handling.
7251         * python/py-arch.c: Use C++ exception handling.
7252         * printcmd.c: Use C++ exception handling.
7253         * ppc-linux-tdep.c: Use C++ exception handling.
7254         * parse.c: Use C++ exception handling.
7255         * p-valprint.c: Use C++ exception handling.
7256         * objc-lang.c: Use C++ exception handling.
7257         * mi/mi-main.c: Use C++ exception handling.
7258         * mi/mi-interp.c: Use C++ exception handling.
7259         * mi/mi-cmd-stack.c: Use C++ exception handling.
7260         * mi/mi-cmd-break.c: Use C++ exception handling.
7261         * main.c: Use C++ exception handling.
7262         * linux-thread-db.c: Use C++ exception handling.
7263         * linux-tdep.c: Use C++ exception handling.
7264         * linux-nat.c: Use C++ exception handling.
7265         * linux-fork.c: Use C++ exception handling.
7266         * linespec.c: Use C++ exception handling.
7267         * language.c: Use C++ exception handling.
7268         * jit.c: Use C++ exception handling.
7269         * infrun.c: Use C++ exception handling.
7270         * infcmd.c: Use C++ exception handling.
7271         * infcall.c: Use C++ exception handling.
7272         * inf-loop.c: Use C++ exception handling.
7273         * i386-tdep.c: Use C++ exception handling.
7274         * i386-linux-tdep.c: Use C++ exception handling.
7275         * guile/scm-value.c: Use C++ exception handling.
7276         * guile/scm-type.c: Use C++ exception handling.
7277         * guile/scm-symtab.c: Use C++ exception handling.
7278         * guile/scm-symbol.c: Use C++ exception handling.
7279         * guile/scm-pretty-print.c: Use C++ exception handling.
7280         * guile/scm-ports.c: Use C++ exception handling.
7281         * guile/scm-param.c: Use C++ exception handling.
7282         * guile/scm-math.c: Use C++ exception handling.
7283         * guile/scm-lazy-string.c: Use C++ exception handling.
7284         * guile/scm-frame.c: Use C++ exception handling.
7285         * guile/scm-disasm.c: Use C++ exception handling.
7286         * guile/scm-cmd.c: Use C++ exception handling.
7287         * guile/scm-breakpoint.c: Use C++ exception handling.
7288         * guile/scm-block.c: Use C++ exception handling.
7289         * guile/guile-internal.h: Use C++ exception handling.
7290         * gnu-v3-abi.c: Use C++ exception handling.
7291         * gdbtypes.c: Use C++ exception handling.
7292         * frame.c: Use C++ exception handling.
7293         * frame-unwind.c: Use C++ exception handling.
7294         * fbsd-tdep.c: Use C++ exception handling.
7295         * f-valprint.c: Use C++ exception handling.
7296         * exec.c: Use C++ exception handling.
7297         * event-top.c: Use C++ exception handling.
7298         * event-loop.c: Use C++ exception handling.
7299         * eval.c: Use C++ exception handling.
7300         * dwarf2read.c: Use C++ exception handling.
7301         * dwarf2loc.c: Use C++ exception handling.
7302         * dwarf2-frame.c: Use C++ exception handling.
7303         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7304         * dwarf-index-write.c: Use C++ exception handling.
7305         * dwarf-index-cache.c: Use C++ exception handling.
7306         * dtrace-probe.c: Use C++ exception handling.
7307         * disasm-selftests.c: Use C++ exception handling.
7308         * darwin-nat.c: Use C++ exception handling.
7309         * cp-valprint.c: Use C++ exception handling.
7310         * cp-support.c: Use C++ exception handling.
7311         * cp-abi.c: Use C++ exception handling.
7312         * corelow.c: Use C++ exception handling.
7313         * completer.c: Use C++ exception handling.
7314         * compile/compile-object-run.c: Use C++ exception handling.
7315         * compile/compile-object-load.c: Use C++ exception handling.
7316         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7317         * compile/compile-c-symbols.c: Use C++ exception handling.
7318         * common/selftest.c: Use C++ exception handling.
7319         * common/new-op.c: Use C++ exception handling.
7320         * cli/cli-script.c: Use C++ exception handling.
7321         * cli/cli-interp.c: Use C++ exception handling.
7322         * cli/cli-cmds.c: Use C++ exception handling.
7323         * c-varobj.c: Use C++ exception handling.
7324         * btrace.c: Use C++ exception handling.
7325         * breakpoint.c: Use C++ exception handling.
7326         * break-catch-throw.c: Use C++ exception handling.
7327         * arch-utils.c: Use C++ exception handling.
7328         * amd64-tdep.c: Use C++ exception handling.
7329         * ada-valprint.c: Use C++ exception handling.
7330         * ada-typeprint.c: Use C++ exception handling.
7331         * ada-lang.c: Use C++ exception handling.
7332         * aarch64-tdep.c: Use C++ exception handling.
7333
7334 2019-04-08  Tom Tromey  <tom@tromey.com>
7335
7336         * xml-support.c (gdb_xml_parser::parse): Update.
7337         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7338         * value.c (show_convenience): Update.
7339         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7340         (test_parse_flags_qcs): Update.
7341         * thread.c (thr_try_catch_cmd): Update.
7342         * target.c (target_translate_tls_address): Update.
7343         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7344         (info_frame_command_core, frame_apply_command_count): Update.
7345         * rust-exp.y (rust_lex_exception_test): Update.
7346         * riscv-tdep.c (riscv_print_one_register_info): Update.
7347         * remote.c (remote_target::enable_btrace): Update.
7348         * record-btrace.c (record_btrace_enable_warn): Update.
7349         * python/py-utils.c (gdbpy_convert_exception): Update.
7350         * printcmd.c (do_one_display, print_variable_and_value): Update.
7351         * mi/mi-main.c (mi_print_exception): Update.
7352         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7353         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7354         * linux-nat.c (linux_nat_target::attach): Update.
7355         * linux-fork.c (class scoped_switch_fork_info): Update.
7356         * infrun.c (displaced_step_prepare): Update.
7357         * infcall.c (call_function_by_hand_dummy): Update.
7358         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7359         * gnu-v3-abi.c (print_one_vtable): Update.
7360         * frame.c (get_prev_frame_always): Update.
7361         * f-valprint.c (info_common_command_for_block): Update.
7362         * exec.c (try_open_exec_file): Update.
7363         * exceptions.c (print_exception, exception_print)
7364         (exception_fprintf, exception_print_same): Update.
7365         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7366         * dwarf-index-cache.c (index_cache::store)
7367         (index_cache::lookup_gdb_index): Update.
7368         * darwin-nat.c (maybe_cache_shell): Update.
7369         * cp-valprint.c (cp_print_value_fields): Update.
7370         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7371         (gcc_cplus_symbol_address): Update.
7372         * compile/compile-c-symbols.c (gcc_convert_symbol)
7373         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7374         * common/selftest.c: Update.
7375         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7376         a std::string.
7377         (exception_try_scope_entry, exception_try_scope_exit): Don't
7378         declare.
7379         (struct exception_try_scope): Remove.
7380         (TRY): Don't use exception_try_scope.
7381         (struct gdb_exception): Add constructor, operator=.
7382         <what>: New method.
7383         (struct gdb_exception_RETURN_MASK_ALL)
7384         (struct gdb_exception_RETURN_MASK_ERROR)
7385         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7386         (struct gdb_quit_bad_alloc): Update.
7387         * common/common-exceptions.c (exception_none): Change
7388         initializer.
7389         (struct catcher) <state, exception>: Initialize inline.
7390         <prev>: Remove member.
7391         (current_catcher): Remove.
7392         (catchers): New global.
7393         (exceptions_state_mc_init): Simplify.
7394         (catcher_pop): Remove.
7395         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7396         (try_scope_depth, exception_try_scope_entry)
7397         (exception_try_scope_exit): Remove.
7398         (throw_exception_sjlj): Update.
7399         (exception_messages, exception_messages_size): Remove.
7400         (throw_it): Simplify.
7401         (gdb_exception_sliced_copy): Remove.
7402         (throw_exception_cxx): Update.
7403         * cli/cli-script.c (script_from_file): Update.
7404         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7405         Update.
7406         * ada-valprint.c (ada_val_print): Update.
7407         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7408         (create_excep_cond_exprs): Update.
7409
7410 2019-04-08  Tom Tromey  <tom@tromey.com>
7411
7412         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7413         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7414         (TRY, CATCH, END_CATCH): Remove some definitions.
7415         * common/common-exceptions.c: Don't use GDB_XCPT.
7416         (catcher_list_size): Remove.
7417         (throw_exception, throw_it): Simplify.
7418
7419 2019-04-05  Tom Tromey  <tom@tromey.com>
7420
7421         Revert the header-sorting patch.
7422         * ft32-tdep.c: Revert.
7423         * frv-tdep.c: Revert.
7424         * frv-linux-tdep.c: Revert.
7425         * frame.c: Revert.
7426         * frame-unwind.c: Revert.
7427         * frame-base.c: Revert.
7428         * fork-child.c: Revert.
7429         * findvar.c: Revert.
7430         * findcmd.c: Revert.
7431         * filesystem.c: Revert.
7432         * filename-seen-cache.h: Revert.
7433         * filename-seen-cache.c: Revert.
7434         * fbsd-tdep.c: Revert.
7435         * fbsd-nat.h: Revert.
7436         * fbsd-nat.c: Revert.
7437         * f-valprint.c: Revert.
7438         * f-typeprint.c: Revert.
7439         * f-lang.c: Revert.
7440         * extension.h: Revert.
7441         * extension.c: Revert.
7442         * extension-priv.h: Revert.
7443         * expprint.c: Revert.
7444         * exec.h: Revert.
7445         * exec.c: Revert.
7446         * exceptions.c: Revert.
7447         * event-top.c: Revert.
7448         * event-loop.c: Revert.
7449         * eval.c: Revert.
7450         * elfread.c: Revert.
7451         * dwarf2read.h: Revert.
7452         * dwarf2read.c: Revert.
7453         * dwarf2loc.c: Revert.
7454         * dwarf2expr.h: Revert.
7455         * dwarf2expr.c: Revert.
7456         * dwarf2-frame.c: Revert.
7457         * dwarf2-frame-tailcall.c: Revert.
7458         * dwarf-index-write.h: Revert.
7459         * dwarf-index-write.c: Revert.
7460         * dwarf-index-common.c: Revert.
7461         * dwarf-index-cache.h: Revert.
7462         * dwarf-index-cache.c: Revert.
7463         * dummy-frame.c: Revert.
7464         * dtrace-probe.c: Revert.
7465         * disasm.h: Revert.
7466         * disasm.c: Revert.
7467         * disasm-selftests.c: Revert.
7468         * dictionary.c: Revert.
7469         * dicos-tdep.c: Revert.
7470         * demangle.c: Revert.
7471         * dcache.h: Revert.
7472         * dcache.c: Revert.
7473         * darwin-nat.h: Revert.
7474         * darwin-nat.c: Revert.
7475         * darwin-nat-info.c: Revert.
7476         * d-valprint.c: Revert.
7477         * d-namespace.c: Revert.
7478         * d-lang.c: Revert.
7479         * ctf.c: Revert.
7480         * csky-tdep.c: Revert.
7481         * csky-linux-tdep.c: Revert.
7482         * cris-tdep.c: Revert.
7483         * cris-linux-tdep.c: Revert.
7484         * cp-valprint.c: Revert.
7485         * cp-support.c: Revert.
7486         * cp-namespace.c: Revert.
7487         * cp-abi.c: Revert.
7488         * corelow.c: Revert.
7489         * corefile.c: Revert.
7490         * continuations.c: Revert.
7491         * completer.h: Revert.
7492         * completer.c: Revert.
7493         * complaints.c: Revert.
7494         * coffread.c: Revert.
7495         * coff-pe-read.c: Revert.
7496         * cli-out.h: Revert.
7497         * cli-out.c: Revert.
7498         * charset.c: Revert.
7499         * c-varobj.c: Revert.
7500         * c-valprint.c: Revert.
7501         * c-typeprint.c: Revert.
7502         * c-lang.c: Revert.
7503         * buildsym.c: Revert.
7504         * buildsym-legacy.c: Revert.
7505         * build-id.h: Revert.
7506         * build-id.c: Revert.
7507         * btrace.c: Revert.
7508         * bsd-uthread.c: Revert.
7509         * breakpoint.h: Revert.
7510         * breakpoint.c: Revert.
7511         * break-catch-throw.c: Revert.
7512         * break-catch-syscall.c: Revert.
7513         * break-catch-sig.c: Revert.
7514         * blockframe.c: Revert.
7515         * block.c: Revert.
7516         * bfin-tdep.c: Revert.
7517         * bfin-linux-tdep.c: Revert.
7518         * bfd-target.c: Revert.
7519         * bcache.c: Revert.
7520         * ax-general.c: Revert.
7521         * ax-gdb.h: Revert.
7522         * ax-gdb.c: Revert.
7523         * avr-tdep.c: Revert.
7524         * auxv.c: Revert.
7525         * auto-load.c: Revert.
7526         * arm-wince-tdep.c: Revert.
7527         * arm-tdep.c: Revert.
7528         * arm-symbian-tdep.c: Revert.
7529         * arm-pikeos-tdep.c: Revert.
7530         * arm-obsd-tdep.c: Revert.
7531         * arm-nbsd-tdep.c: Revert.
7532         * arm-nbsd-nat.c: Revert.
7533         * arm-linux-tdep.c: Revert.
7534         * arm-linux-nat.c: Revert.
7535         * arm-fbsd-tdep.c: Revert.
7536         * arm-fbsd-nat.c: Revert.
7537         * arm-bsd-tdep.c: Revert.
7538         * arch-utils.c: Revert.
7539         * arc-tdep.c: Revert.
7540         * arc-newlib-tdep.c: Revert.
7541         * annotate.h: Revert.
7542         * annotate.c: Revert.
7543         * amd64-windows-tdep.c: Revert.
7544         * amd64-windows-nat.c: Revert.
7545         * amd64-tdep.c: Revert.
7546         * amd64-sol2-tdep.c: Revert.
7547         * amd64-obsd-tdep.c: Revert.
7548         * amd64-obsd-nat.c: Revert.
7549         * amd64-nbsd-tdep.c: Revert.
7550         * amd64-nbsd-nat.c: Revert.
7551         * amd64-nat.c: Revert.
7552         * amd64-linux-tdep.c: Revert.
7553         * amd64-linux-nat.c: Revert.
7554         * amd64-fbsd-tdep.c: Revert.
7555         * amd64-fbsd-nat.c: Revert.
7556         * amd64-dicos-tdep.c: Revert.
7557         * amd64-darwin-tdep.c: Revert.
7558         * amd64-bsd-nat.c: Revert.
7559         * alpha-tdep.c: Revert.
7560         * alpha-obsd-tdep.c: Revert.
7561         * alpha-nbsd-tdep.c: Revert.
7562         * alpha-mdebug-tdep.c: Revert.
7563         * alpha-linux-tdep.c: Revert.
7564         * alpha-linux-nat.c: Revert.
7565         * alpha-bsd-tdep.c: Revert.
7566         * alpha-bsd-nat.c: Revert.
7567         * aix-thread.c: Revert.
7568         * agent.c: Revert.
7569         * addrmap.c: Revert.
7570         * ada-varobj.c: Revert.
7571         * ada-valprint.c: Revert.
7572         * ada-typeprint.c: Revert.
7573         * ada-tasks.c: Revert.
7574         * ada-lang.c: Revert.
7575         * aarch64-tdep.c: Revert.
7576         * aarch64-ravenscar-thread.c: Revert.
7577         * aarch64-newlib-tdep.c: Revert.
7578         * aarch64-linux-tdep.c: Revert.
7579         * aarch64-linux-nat.c: Revert.
7580         * aarch64-fbsd-tdep.c: Revert.
7581         * aarch64-fbsd-nat.c: Revert.
7582         * aarch32-linux-nat.c: Revert.
7583
7584 2019-04-05  Tom Tromey  <tom@tromey.com>
7585
7586         * ft32-tdep.c: Sort headers.
7587         * frv-tdep.c: Sort headers.
7588         * frv-linux-tdep.c: Sort headers.
7589         * frame.c: Sort headers.
7590         * frame-unwind.c: Sort headers.
7591         * frame-base.c: Sort headers.
7592         * fork-child.c: Sort headers.
7593         * findvar.c: Sort headers.
7594         * findcmd.c: Sort headers.
7595         * filesystem.c: Sort headers.
7596         * filename-seen-cache.h: Sort headers.
7597         * filename-seen-cache.c: Sort headers.
7598         * fbsd-tdep.c: Sort headers.
7599         * fbsd-nat.h: Sort headers.
7600         * fbsd-nat.c: Sort headers.
7601         * f-valprint.c: Sort headers.
7602         * f-typeprint.c: Sort headers.
7603         * f-lang.c: Sort headers.
7604         * extension.h: Sort headers.
7605         * extension.c: Sort headers.
7606         * extension-priv.h: Sort headers.
7607         * expprint.c: Sort headers.
7608         * exec.h: Sort headers.
7609         * exec.c: Sort headers.
7610         * exceptions.c: Sort headers.
7611         * event-top.c: Sort headers.
7612         * event-loop.c: Sort headers.
7613         * eval.c: Sort headers.
7614         * elfread.c: Sort headers.
7615         * dwarf2read.h: Sort headers.
7616         * dwarf2read.c: Sort headers.
7617         * dwarf2loc.c: Sort headers.
7618         * dwarf2expr.h: Sort headers.
7619         * dwarf2expr.c: Sort headers.
7620         * dwarf2-frame.c: Sort headers.
7621         * dwarf2-frame-tailcall.c: Sort headers.
7622         * dwarf-index-write.h: Sort headers.
7623         * dwarf-index-write.c: Sort headers.
7624         * dwarf-index-common.c: Sort headers.
7625         * dwarf-index-cache.h: Sort headers.
7626         * dwarf-index-cache.c: Sort headers.
7627         * dummy-frame.c: Sort headers.
7628         * dtrace-probe.c: Sort headers.
7629         * disasm.h: Sort headers.
7630         * disasm.c: Sort headers.
7631         * disasm-selftests.c: Sort headers.
7632         * dictionary.c: Sort headers.
7633         * dicos-tdep.c: Sort headers.
7634         * demangle.c: Sort headers.
7635         * dcache.h: Sort headers.
7636         * dcache.c: Sort headers.
7637         * darwin-nat.h: Sort headers.
7638         * darwin-nat.c: Sort headers.
7639         * darwin-nat-info.c: Sort headers.
7640         * d-valprint.c: Sort headers.
7641         * d-namespace.c: Sort headers.
7642         * d-lang.c: Sort headers.
7643         * ctf.c: Sort headers.
7644         * csky-tdep.c: Sort headers.
7645         * csky-linux-tdep.c: Sort headers.
7646         * cris-tdep.c: Sort headers.
7647         * cris-linux-tdep.c: Sort headers.
7648         * cp-valprint.c: Sort headers.
7649         * cp-support.c: Sort headers.
7650         * cp-namespace.c: Sort headers.
7651         * cp-abi.c: Sort headers.
7652         * corelow.c: Sort headers.
7653         * corefile.c: Sort headers.
7654         * continuations.c: Sort headers.
7655         * completer.h: Sort headers.
7656         * completer.c: Sort headers.
7657         * complaints.c: Sort headers.
7658         * coffread.c: Sort headers.
7659         * coff-pe-read.c: Sort headers.
7660         * cli-out.h: Sort headers.
7661         * cli-out.c: Sort headers.
7662         * charset.c: Sort headers.
7663         * c-varobj.c: Sort headers.
7664         * c-valprint.c: Sort headers.
7665         * c-typeprint.c: Sort headers.
7666         * c-lang.c: Sort headers.
7667         * buildsym.c: Sort headers.
7668         * buildsym-legacy.c: Sort headers.
7669         * build-id.h: Sort headers.
7670         * build-id.c: Sort headers.
7671         * btrace.c: Sort headers.
7672         * bsd-uthread.c: Sort headers.
7673         * breakpoint.h: Sort headers.
7674         * breakpoint.c: Sort headers.
7675         * break-catch-throw.c: Sort headers.
7676         * break-catch-syscall.c: Sort headers.
7677         * break-catch-sig.c: Sort headers.
7678         * blockframe.c: Sort headers.
7679         * block.c: Sort headers.
7680         * bfin-tdep.c: Sort headers.
7681         * bfin-linux-tdep.c: Sort headers.
7682         * bfd-target.c: Sort headers.
7683         * bcache.c: Sort headers.
7684         * ax-general.c: Sort headers.
7685         * ax-gdb.h: Sort headers.
7686         * ax-gdb.c: Sort headers.
7687         * avr-tdep.c: Sort headers.
7688         * auxv.c: Sort headers.
7689         * auto-load.c: Sort headers.
7690         * arm-wince-tdep.c: Sort headers.
7691         * arm-tdep.c: Sort headers.
7692         * arm-symbian-tdep.c: Sort headers.
7693         * arm-pikeos-tdep.c: Sort headers.
7694         * arm-obsd-tdep.c: Sort headers.
7695         * arm-nbsd-tdep.c: Sort headers.
7696         * arm-nbsd-nat.c: Sort headers.
7697         * arm-linux-tdep.c: Sort headers.
7698         * arm-linux-nat.c: Sort headers.
7699         * arm-fbsd-tdep.c: Sort headers.
7700         * arm-fbsd-nat.c: Sort headers.
7701         * arm-bsd-tdep.c: Sort headers.
7702         * arch-utils.c: Sort headers.
7703         * arc-tdep.c: Sort headers.
7704         * arc-newlib-tdep.c: Sort headers.
7705         * annotate.h: Sort headers.
7706         * annotate.c: Sort headers.
7707         * amd64-windows-tdep.c: Sort headers.
7708         * amd64-windows-nat.c: Sort headers.
7709         * amd64-tdep.c: Sort headers.
7710         * amd64-sol2-tdep.c: Sort headers.
7711         * amd64-obsd-tdep.c: Sort headers.
7712         * amd64-obsd-nat.c: Sort headers.
7713         * amd64-nbsd-tdep.c: Sort headers.
7714         * amd64-nbsd-nat.c: Sort headers.
7715         * amd64-nat.c: Sort headers.
7716         * amd64-linux-tdep.c: Sort headers.
7717         * amd64-linux-nat.c: Sort headers.
7718         * amd64-fbsd-tdep.c: Sort headers.
7719         * amd64-fbsd-nat.c: Sort headers.
7720         * amd64-dicos-tdep.c: Sort headers.
7721         * amd64-darwin-tdep.c: Sort headers.
7722         * amd64-bsd-nat.c: Sort headers.
7723         * alpha-tdep.c: Sort headers.
7724         * alpha-obsd-tdep.c: Sort headers.
7725         * alpha-nbsd-tdep.c: Sort headers.
7726         * alpha-mdebug-tdep.c: Sort headers.
7727         * alpha-linux-tdep.c: Sort headers.
7728         * alpha-linux-nat.c: Sort headers.
7729         * alpha-bsd-tdep.c: Sort headers.
7730         * alpha-bsd-nat.c: Sort headers.
7731         * aix-thread.c: Sort headers.
7732         * agent.c: Sort headers.
7733         * addrmap.c: Sort headers.
7734         * ada-varobj.c: Sort headers.
7735         * ada-valprint.c: Sort headers.
7736         * ada-typeprint.c: Sort headers.
7737         * ada-tasks.c: Sort headers.
7738         * ada-lang.c: Sort headers.
7739         * aarch64-tdep.c: Sort headers.
7740         * aarch64-ravenscar-thread.c: Sort headers.
7741         * aarch64-newlib-tdep.c: Sort headers.
7742         * aarch64-linux-tdep.c: Sort headers.
7743         * aarch64-linux-nat.c: Sort headers.
7744         * aarch64-fbsd-tdep.c: Sort headers.
7745         * aarch64-fbsd-nat.c: Sort headers.
7746         * aarch32-linux-nat.c: Sort headers.
7747
7748 2019-04-04  Tom Tromey  <tom@tromey.com>
7749
7750         * varobj.c (varobj_create): Update.
7751         * rust-exp.y (struct rust_parser) <update_innermost_block,
7752         lookup_symbol>: New methods.
7753         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7754         Rename.
7755         (rust_parser::rust_lookup_type)
7756         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7757         * printcmd.c (display_command, do_one_display): Update.
7758         * parser-defs.h (struct parser_state) <parser_state>: Add
7759         "tracker" parameter.
7760         (block_tracker): New member.
7761         (class innermost_block_tracker) <innermost_block_tracker>: Add
7762         "types" parameter.
7763         <reset>: Remove method.
7764         (innermost_block): Don't declare.
7765         (null_post_parser): Update.
7766         * parse.c (innermost_block): Remove global.
7767         (write_dollar_variable): Update.
7768         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7769         Remove "tracker_types" parameter.
7770         (parse_expression): Add "tracker" parameter.
7771         (parse_expression_for_completion): Update.
7772         (null_post_parser): Add "tracker" parameter.
7773         * p-exp.y: Update rules.
7774         * m2-exp.y: Update rules.
7775         * language.h (struct language_defn) <la_post_parser>: Add
7776         "tracker" parameter.
7777         * go-exp.y: Update rules.
7778         * f-exp.y: Update rules.
7779         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7780         parameter.
7781         * d-exp.y: Update rules.
7782         * c-exp.y: Update rules.
7783         * breakpoint.c (set_breakpoint_condition): Create an
7784         innermost_block_tracker.
7785         (watch_command_1): Likewise.
7786         * ada-lang.c (resolve): Add "tracker" parameter.
7787         (resolve_subexp): Likewise.
7788         * ada-exp.y (write_var_from_sym): Update.
7789
7790 2019-04-04  Tom Tromey  <tom@tromey.com>
7791
7792         * type-stack.h: New file.
7793         * type-stack.c: New file.
7794         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7795         type-stack.h.
7796         (insert_into_type_stack, insert_type, push_type, push_type_int)
7797         (insert_type_address_space, pop_type, pop_type_int)
7798         (pop_typelist, pop_type_stack, append_type_stack)
7799         (push_type_stack, get_type_stack, push_typelist)
7800         (follow_type_instance_flags, follow_types): Don't declare.
7801         * parse.c (type_stack): Remove global.
7802         (parse_exp_in_context): Update.
7803         (insert_into_type_stack, insert_type, push_type, push_type_int)
7804         (insert_type_address_space, pop_type, pop_type_int)
7805         (pop_typelist, pop_type_stack, append_type_stack)
7806         (push_type_stack, get_type_stack, push_typelist)
7807         (follow_type_instance_flags, follow_types): Remove (moved to
7808         type-stack.c).
7809         * f-exp.y (type_stack): New global.
7810         Update rules.
7811         (push_kind_type, f_parse): Update.
7812         * d-exp.y (type_stack): New global.
7813         Update rules.
7814         (d_parse): Update.
7815         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7816         Update rules.
7817         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7818         (HFILES_NO_SRCDIR): Add type-stack.h.
7819
7820 2019-04-04  Tom Tromey  <tom@tromey.com>
7821
7822         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7823         (rust_parser::convert_ast_to_expression, rust_parse)
7824         (rust_lex_test_completion, rust_lex_tests): Update.
7825         * parser-defs.h (struct expr_completion_state): New.
7826         (struct parser_state) <parser_state>: Add completion parameter.
7827         <mark_struct_expression, mark_completion_tag>: New methods.
7828         <parse_completion, m_completion_state>: New members.
7829         (prefixify_expression, null_post_parser): Update.
7830         (mark_struct_expression, mark_completion_tag): Don't declare.
7831         * parse.c (parse_completion, expout_last_struct)
7832         (expout_tag_completion_type, expout_completion_name): Remove
7833         globals.
7834         (parser_state::mark_struct_expression)
7835         (parser_state::mark_completion_tag): Now methods.
7836         (prefixify_expression): Add last_struct parameter.
7837         (prefixify_subexp): Likewise.
7838         (parse_exp_1): Update.
7839         (parse_exp_in_context): Add cstate parameter.  Update.
7840         (parse_expression_for_completion): Create an
7841         expr_completion_state.
7842         (null_post_parser): Add "completion" parameter.
7843         * p-exp.y: Update rules.
7844         (yylex): Update.
7845         * language.h (struct language_defn) <la_post_parser>: Add
7846         "completing" parameter.
7847         * go-exp.y: Update rules.
7848         (lex_one_token): Update.
7849         * expression.h (parse_completion): Don't declare.
7850         * d-exp.y: Update rules.
7851         (lex_one_token): Update rules.
7852         * c-exp.y: Update rules.
7853         (lex_one_token): Update.
7854         * ada-lang.c (resolve): Add "parse_completion" parameter.
7855         (resolve_subexp): Likewise.
7856         (ada_resolve_function): Likewise.
7857
7858 2019-04-04  Tom Tromey  <tom@tromey.com>
7859
7860         * parser-defs.h (struct parser_state) <start_arglist,
7861         end_arglist>: New methods.
7862         <arglist_len, m_funcall_chain>: New members.
7863         (arglist_len, start_arglist, end_arglist): Don't declare.
7864         * parse.c (arglist_len, funcall_chain): Remove global.
7865         (start_arglist, end_arglist): Remove functions.
7866         (parse_exp_in_context): Update.
7867         * p-exp.y: Update rules.
7868         * m2-exp.y: Update rules.
7869         * go-exp.y: Update rules.
7870         * f-exp.y: Update rules.
7871         * d-exp.y: Update rules.
7872         * c-exp.y: Update rules.
7873
7874 2019-04-04  Tom Tromey  <tom@tromey.com>
7875
7876         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7877         lex_operator, push_back>: New methods.
7878         Update all rules.
7879         (rust_parser::lex_hex, lex_escape): Rename and update.
7880         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7881         (rust_parser::lex_operator): Rename and update.
7882         (rust_parser::lex_number, rustyylex, rustyyerror)
7883         (rust_lex_test_init, rust_lex_test_sequence)
7884         (rust_lex_test_push_back, rust_lex_tests): Update.
7885         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7886         parameter.
7887         <lexptr, prev_lexptr>: New members.
7888         (lexptr, prev_lexptr): Don't declare.
7889         * parse.c (lexptr, prev_lexptr): Remove globals.
7890         (parse_exp_in_context): Update.
7891         * p-exp.y (yylex, yyerror): Update.
7892         * m2-exp.y (parse_number, yylex, yyerror): Update.
7893         * go-exp.y (lex_one_token, yyerror): Update.
7894         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7895         * d-exp.y (lex_one_token, yyerror): Update.
7896         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7897         (lex_one_token, yyerror): Update.
7898         * ada-lex.l (YY_INPUT): Update.
7899         (rewind_to_char): Update.
7900         * ada-exp.y (yyerror): Update.
7901
7902 2019-04-04  Tom Tromey  <tom@tromey.com>
7903
7904         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7905         * parser-defs.h (struct parser_state) <parser_state>: Add new
7906         parameter.
7907         <comma_terminates>: New member.
7908         (comma_terminates): Don't declare global.
7909         * parse.c (comma_terminates): Remove global.
7910         (parse_exp_in_context): Update.
7911         * p-exp.y (yylex): Update.
7912         * m2-exp.y (yylex): Update.
7913         * go-exp.y (lex_one_token): Update.
7914         * f-exp.y (yylex): Update.
7915         * d-exp.y (lex_one_token): Update.
7916         * c-exp.y (lex_one_token): Update.
7917         * ada-lex.l: Update.
7918
7919 2019-04-04  Tom Tromey  <tom@tromey.com>
7920
7921         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7922         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7923         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7924         * parser-defs.h (paren_depth): Don't declare.
7925         * parse.c (paren_depth): Remove global.
7926         (parse_exp_in_context): Update.
7927         * p-exp.y (paren_depth): New global.
7928         (pascal_parse): Initialize it.
7929         * m2-exp.y (paren_depth): New global.
7930         (m2_parse): Initialize it.
7931         * go-exp.y (paren_depth): New global.
7932         (go_parse): Initialize it.
7933         * f-exp.y (paren_depth): New global.
7934         (f_parse): Initialize it.
7935         * d-exp.y (paren_depth): New global.
7936         (d_parse): Initialize it.
7937         * c-exp.y (paren_depth): New global.
7938         (c_parse): Initialize it.
7939         * ada-lex.l (paren_depth): New global.
7940         (lexer_init): Initialize it.
7941
7942 2019-04-04  Tom Tromey  <tom@tromey.com>
7943
7944         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7945         (rust_parser::convert_ast_to_type)
7946         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7947         * parser-defs.h (struct parser_state) <parser_state>: Add
7948         parameters.  Initialize new members.
7949         <expression_context_block, expression_context_pc>: New members.
7950         * parse.c (expression_context_block, expression_context_pc):
7951         Remove globals.
7952         (parse_exp_in_context): Update.
7953         * p-exp.y: Update all rules.
7954         (yylex): Update.
7955         * m2-exp.y: Update all rules.
7956         (yylex): Update.
7957         * go-exp.y (yylex): Update.
7958         * f-exp.y (yylex): Update.
7959         * d-exp.y: Update all rules.
7960         (yylex): Update.
7961         * c-exp.y: Update all rules.
7962         (lex_one_token, classify_name, yylex, c_parse): Update.
7963         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7964
7965 2019-04-04  Tom Tromey  <tom@tromey.com>
7966
7967         * gdbarch.h, gdbarch.c: Rebuild.
7968         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7969         * stap-probe.h:
7970         (struct stap_parse_info): Replace "parser_state" with
7971         "expr_builder".
7972         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7973         (parser_state): New class.
7974         * parse.c (expr_builder): Rename.
7975         (expr_builder::release): Rename.
7976         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7977         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7978         (write_exp_elt_longcst, write_exp_elt_floatcst)
7979         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7980         (write_exp_string_vector, write_exp_bitstring)
7981         (write_exp_msymbol, mark_struct_expression)
7982         (write_dollar_variable)
7983         (insert_type_address_space, increase_expout_size): Replace
7984         "parser_state" with "expr_builder".
7985         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7986         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7987         "parser_state" with "expr_builder".
7988
7989 2019-04-04  Tom Tromey  <tom@tromey.com>
7990
7991         * rust-exp.y: Replace "parse_language" with method call.
7992         * p-exp.y:
7993         (yylex): Replace "parse_language" with method call.
7994         * m2-exp.y:
7995         (yylex): Replace "parse_language" with method call.
7996         * go-exp.y (classify_name): Replace "parse_language" with method
7997         call.
7998         * f-exp.y (yylex): Replace "parse_language" with method call.
7999         * d-exp.y (lex_one_token): Replace "parse_language" with method
8000         call.
8001         * c-exp.y:
8002         (lex_one_token, classify_name, yylex): Replace "parse_language"
8003         with method call.
8004         * ada-exp.y (find_primitive_type, type_char)
8005         (type_system_address): Replace "parse_language" with method call.
8006
8007 2019-04-04  Tom Tromey  <tom@tromey.com>
8008
8009         * rust-exp.y: Replace "parse_gdbarch" with method call.
8010         * parse.c (write_dollar_variable, insert_type_address_space):
8011         Replace "parse_gdbarch" with method call.
8012         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8013         call.
8014         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8015         call.
8016         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8017         "parse_gdbarch" with method call.
8018         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8019         with method call.
8020         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8021         "parse_gdbarch" with method call.
8022         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8023         "parse_gdbarch" with method call.
8024         * c-exp.y (parse_type, parse_number, classify_name): Replace
8025         "parse_gdbarch" with method call.
8026         * ada-lex.l: Replace "parse_gdbarch" with method call.
8027         * ada-exp.y (parse_type, find_primitive_type, type_char)
8028         (type_system_address): Replace "parse_gdbarch" with method call.
8029
8030 2019-04-04  Tom Tromey  <tom@tromey.com>
8031
8032         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8033         * stap-probe.c (stap_parse_argument): Update.
8034         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8035         initial_size parameter.
8036         * rust-exp.y (rust_lex_tests): Update.
8037         * parse.c (parser_state): Update.
8038         (parse_exp_in_context): Update.
8039         * parser-defs.h (struct parser_state) <parser_state>: Remove
8040         "initial_size" parameter.
8041
8042 2019-04-04  Tom Tromey  <tom@tromey.com>
8043
8044         * parser-defs.h (increase_expout_size): Don't declare.
8045         * parse.c (increase_expout_size): Now static.
8046
8047 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8048
8049         * gnu-nat.c (gnu_nat_target::wait): Fix
8050         target_waitstatus_to_string call.
8051
8052 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8053
8054         * eval.c (evaluate_subexp_standard): Handle internal functions
8055         during Fortran function call handling.
8056
8057 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8058
8059         * NEWS: Mention new internal functions.
8060         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8061         (read_base_type): Use dwarf2_init_complex_target_type.
8062         * value.c (creal_internal_fn): New function.
8063         (cimag_internal_fn): New function.
8064         (_initialize_values): Register new internal functions.
8065
8066 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8067
8068         * infrun.c (stop_all_threads): If debug_infrun, always
8069         trace the wait status after wait_one, using
8070         target_waitstatus_to_string and target_pid_to_str.
8071         (handle_inferior_event): Replace various trace of
8072         wait status kind by a single trace.
8073         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8074         wait status kind image by target_waitstatus_to_string.
8075         * target/waitstatus.c (target_waitstatus_to_string): Fix
8076         obsolete comment.
8077
8078 2019-04-01  Tom Tromey  <tromey@adacore.com>
8079
8080         PR symtab/23331:
8081         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8082
8083 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8084             Pedro Alves  <palves@redhat.com>
8085
8086         * top.c (quit_force): Call 'finalize_values'.
8087         * value.c (finalize_values): New function.
8088         * value.h (finalize_values): Declare.
8089
8090 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8091
8092         * NEWS: Announce $_gdb_major and $_gdb_minor.
8093
8094         * top.c (init_gdb_version_vars): New function.
8095         (gdb_init): Call init_gdb_version_vars.
8096
8097 2019-03-29  Tom Tromey  <tromey@adacore.com>
8098
8099         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8100         help text.  Remove dead code.
8101
8102 2019-03-29  Keith Seitz  <keiths@redhat.com>
8103
8104         From Siddhesh Poyarekar:
8105         * f-lang.h (f77_get_upperbound): Return LONGEST.
8106         (f77_get_lowerbound): Likewise.
8107         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8108         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8109         print them.
8110         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8111         plongest to format print it.
8112         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8113         (f77_get_upperbound): Likewise.
8114         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8115         LOWER_BOUND to LONGEST.
8116         (f77_create_arrayprint_offset_tbl): Likewise.
8117
8118 2019-03-29  Keith Seitz  <keiths@redhat.com>
8119
8120         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8121         %s/pulongest for TYPE_LENGTH instead of %d in format
8122         strings.
8123         * ada-typerint.c (ada_print_type): Likewise.
8124         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8125         * compile/compile-c-support.c (generate_register_struct): Likewise.
8126         * gdbtypes.c (recursive_dump_type): Likewise.
8127         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8128         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8129         instead of %d in format strings.
8130         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8131         to std::min to ULONGEST.
8132         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8133         instead of %d in format strings.
8134         * tracepoint.c (info_scope_command): Likewise.
8135         * typeprint.c (print_offset_data::update)
8136         (print_offset_data::finish): Likewise.
8137         * xtensa-tdep.c (xtensa_store_return_value)
8138         (xtensa_push_dummy_call): Likewise.
8139
8140 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8141
8142         * windows-nat.c (display_selector): Fixed format specifications
8143         for 64-bit Cygwin.
8144
8145 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8146
8147         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8148
8149 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8150
8151         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8152         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8153         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8154         (nios2_linux_init_abi): Install it.
8155
8156 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8157
8158         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8159
8160 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8161
8162         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8163
8164 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8165             Tom Tromey  <tromey@adacore.com>
8166
8167         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8168
8169 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8170
8171         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8172         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8173         method to compute the bounds of range types. Also print "[evaluated]"
8174         if the bounds' values come from a dynamic evaluation.
8175
8176 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8177
8178         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8179         whitespace when pretty printing is on.
8180
8181 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8182
8183         * ppc-linux-nat.c: Add include.
8184
8185 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8186
8187         * NEWS: Mention AArch64 Pointer Authentication.
8188
8189 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8190
8191         * arm-linux-nat.c: Add include.
8192
8193 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8194
8195         * source-cache.c (source_cache::get_source_lines): Re-read
8196         fullname after calling open_source_file.
8197
8198 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8199
8200         * NEWS: Mention TLS support for FreeBSD.
8201
8202 2019-03-25  Tom Tromey  <tromey@adacore.com>
8203
8204         * minsyms.c (BUNCH_SIZE): Update comment.
8205         (~minimal_symbol_reader): Remove old comment.
8206         (compact_minimal_symbols): Update comment.
8207         (minimal_symbol_reader::install): Remove old comment.  Update
8208         other comments.
8209
8210 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8211
8212         * s390-linux-nat.c: Add include.
8213
8214 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8215
8216         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8217         Call linux_get_hwcap.
8218         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8219         Likewise.
8220         (aarch64_linux_get_hwcap): Remove function.
8221         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8222         declaration.
8223         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8224         linux_get_hwcap.
8225         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8226         * linux-tdep.c (linux_get_hwcap): Add function.
8227         (linux_get_hwcap2): Likewise.
8228         * linux-tdep.h (linux_get_hwcap): Add declaration.
8229         (linux_get_hwcap2): Likewise.
8230         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8231         (ppc_linux_get_hwcap2): Likewise.
8232         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8233         linux_get_hwcap.
8234         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8235         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8236         (ppc_linux_nat_target::read_description): Likewise.
8237         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8238         * s390-linux-nat.c: Likewise.
8239         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8240
8241 2019-03-24  Tom Tromey  <tom@tromey.com>
8242
8243         * ada-lang.c (standard_lookup): Simplify initialization.
8244         (ada_lookup_symbol_nonlocal): Simplify return.
8245         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8246         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8247         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8248         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8249         initialization.
8250         * solib.c (solib_global_lookup): Simplify.
8251         * symtab.c (null_block_symbol): Remove.
8252         (symbol_cache_lookup): Simplify returns.
8253         (lookup_language_this): Simplify returns.
8254         (lookup_symbol_aux): Simplify return.
8255         (lookup_local_symbol): Simplify returns.
8256         (lookup_global_symbol_from_objfile): Simplify return.
8257         (lookup_symbol_in_objfile_symtabs)
8258         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8259         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8260         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8261         * cp-namespace.c (cp_lookup_bare_symbol)
8262         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8263         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8264         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8265         (cp_lookup_symbol_via_imports): Simplify initialization.
8266         (find_symbol_in_baseclass): Likewise.
8267         * symtab.h (null_block_symbol): Remove.
8268         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8269         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8270         (d_lookup_symbol_module): Likewise.
8271         (find_symbol_in_baseclass): Simplify initialization.
8272
8273 2019-03-24  Tom Tromey  <tom@tromey.com>
8274
8275         * expression.h: Don't include symtab.h.
8276         (struct block): Forward declare.
8277
8278 2019-03-24  Tom Tromey  <tom@tromey.com>
8279
8280         * c-exp.y (typebase): Remove casts.
8281         * gdbtypes.c (lookup_unsigned_typename, )
8282         (lookup_signed_typename): Remove cast.
8283         * eval.c (parse_to_comma_and_eval): Remove cast.
8284         * parse.c (write_dollar_variable): Remove cast.
8285         * block.h (struct block) <superblock>: Now const.
8286         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8287         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8288         (map_block): Make "block" const.
8289         * symfile.h (struct quick_symbol_functions)
8290         <map_matching_symbols>: Constify block argument to "callback".
8291         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8292         const.
8293         (find_pc_sect_compunit_symtab): Make "b" const.
8294         (find_symbol_at_address): Likewise.
8295         (search_symbols): Likewise.
8296         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8297         (dw2_debug_names_lookup_symbol): Likewise.
8298         (dw2_map_matching_symbols): Update.
8299         * p-valprint.c (pascal_val_print): Remove "block".
8300         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8301         (aux_add_nonlocal_symbols): Make "block" const.
8302         (resolve_subexp): Remove cast.
8303         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8304         const.
8305         (iterate_over_file_blocks): Likewise.
8306         * f-exp.y (%union) <bval>: Remove.
8307         * coffread.c (patch_opaque_types): Make "b" const.
8308         * spu-tdep.c (spu_catch_start): Make "block" const.
8309         * c-valprint.c (print_unpacked_pointer): Remove "block".
8310         * symmisc.c (dump_symtab_1): Make "b" const.
8311         (block_depth): Make "block" const.
8312         * d-exp.y (%union) <bval>: Remove.
8313         * cp-support.h (cp_lookup_rtti_type): Update.
8314         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8315         * psymtab.c (psym_lookup_symbol): Make "block" const.
8316         (maintenance_check_psymtabs): Make "b" const.
8317         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8318         (enumerate_locals, enumerate_args): Update.
8319         * python/py-symtab.c (stpy_global_block): Make "block" const.
8320         (stpy_static_block): Likewise.
8321         * inline-frame.c (block_starting_point_at): Make "new_block"
8322         const.
8323         * block.c (find_block_in_blockvector): Make return type const.
8324         (blockvector_for_pc_sect): Make "b" const.
8325         (find_block_in_blockvector): Make "b" const.
8326
8327 2019-03-23  Tom Tromey  <tom@tromey.com>
8328
8329         * varobj.c (varobj_create): Update.
8330         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8331         * printcmd.c (display_command, do_one_display): Don't reset
8332         innermost_block.
8333         * parser-defs.h (enum innermost_block_tracker_type): Move to
8334         expression.h.
8335         (innermost_block): Update comment.
8336         * parse.c (parse_exp_1): Add tracker_types parameter.
8337         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8338         tracker_types parameter.  Reset innermost_block.
8339         (parse_exp_in_context): Remove.
8340         (parse_expression_for_completion): Update.
8341         * objfiles.c (~objfile): Don't reset expression_context_block or
8342         innermost_block.
8343         * expression.h (enum innermost_block_tracker_type): Move from
8344         parser-defs.h.
8345         (parse_exp_1): Add tracker_types parameter.
8346         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8347         reset innermost_block.
8348
8349 2019-03-23  Tom Tromey  <tom@tromey.com>
8350
8351         * objfiles.h: Include bcache.h.
8352
8353 2019-03-23  Tom Tromey  <tom@tromey.com>
8354
8355         * linespec.c (get_current_search_block): Use
8356         scoped_restore_current_language.
8357         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8358
8359 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8360             Jiong Wang  <jiong.wang@arm.com>
8361
8362         * aarch64-linux-tdep.c
8363         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8364         section.
8365         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8366
8367 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8368             Jiong Wang  <jiong.wang@arm.com>
8369
8370         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8371         instructions.
8372         (aarch64_analyze_prologue_test): Add PACIASP test.
8373         (aarch64_prologue_prev_register): Unmask PC value.
8374
8375 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8376             Jiong Wang  <jiong.wang@arm.com>
8377
8378         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8379         (aarch64_dwarf2_prev_register): Unmask PC value.
8380         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8381         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8382         DW_CFA_AARCH64_negate_ra_state.
8383         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8384
8385 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8386             Jiong Wang  <jiong.wang@arm.com>
8387
8388         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8389         registers.
8390         (aarch64_pseudo_register_name): Likewise.
8391         (aarch64_pseudo_register_type): Likewise.
8392         (aarch64_pseudo_register_reggroup_p): Likewise.
8393         (aarch64_gdbarch_init): Add pauth registers.
8394         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8395         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8396         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8397         (struct gdbarch_tdep): Add regnum for ra_state.
8398
8399 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8400             Jiong Wang  <jiong.wang@arm.com>
8401
8402         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8403
8404 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8405             Jiong Wang  <jiong.wang@arm.com>
8406
8407         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8408         function.
8409         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8410         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8411         (aarch64_gdbarch_init): Add puth registers.
8412         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8413         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8414         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8415
8416 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8417             Jiong Wang  <jiong.wang@arm.com>
8418
8419         * aarch64-linux-nat.c
8420         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8421         * aarch64-linux-tdep.c
8422         (aarch64_linux_core_read_description): Likewise.
8423         (aarch64_linux_get_hwcap): New function.
8424         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8425         (aarch64_linux_get_hwcap): New declaration.
8426
8427 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8428             Jiong Wang  <jiong.wang@arm.com>
8429
8430         * aarch64-linux-nat.c
8431         (aarch64_linux_nat_target::read_description): Add pauth param.
8432         * aarch64-linux-tdep.c
8433         (aarch64_linux_core_read_description): Likewise.
8434         * aarch64-tdep.c (struct target_desc): Add in pauth.
8435         (aarch64_read_description): Add pauth param.
8436         (aarch64_gdbarch_init): Likewise.
8437         * aarch64-tdep.h (aarch64_read_description): Likewise.
8438         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8439         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8440         * features/Makefile: Add new files.
8441         * features/aarch64-pauth.c: New file.
8442         * features/aarch64-pauth.xml: New file.
8443
8444 2019-03-20  Tom Tromey  <tromey@adacore.com>
8445
8446         * infrun.c (handle_inferior_event): Rename from
8447         handle_inferior_event_1.  Create a scoped_value_mark.
8448         (handle_inferior_event): Remove.
8449
8450 2019-03-19  Tom Tromey  <tromey@adacore.com>
8451
8452         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8453         * infrun.h (print_stop_event): Add "displays" parameter.
8454         * infrun.c (print_stop_event): Add "displays" parameter.
8455
8456 2019-03-19  Pedro Alves  <palves@redhat.com>
8457
8458         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8459         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8460         to -1.  Fix TABs vs spaces.
8461         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8462         * tui/tui-out.h (tui_ui_out) Add intro comments.
8463         <m_line, m_start_of_line>: In-class initialize, and add describing
8464         comment.
8465
8466 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8467
8468         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8469         variable names.
8470         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8471
8472 2019-03-18  Pedro Alves  <palves@redhat.com>
8473             Eli Zaretskii <eliz@gnu.org>
8474
8475         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8476         m_line and m_start_of_line.
8477
8478 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8479
8480         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8481         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8482         it returns a newline.  This fixes a regression in TU mode, whereby
8483         the next line is output on the same screen line as the user input.
8484
8485 2019-03-18  Tom Tromey  <tromey@adacore.com>
8486
8487         * minsyms.c (minimal_symbol_reader::install): Remove call to
8488         obstack_blank.
8489
8490 2019-03-18  Pedro Alves  <palves@redhat.com>
8491
8492         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8493         New globals.
8494         (apply_style): New, factored out from ...
8495         (apply_ansi_escape): ... this.  Handle reverse video mode.
8496         (tui_set_reverse_mode): New function.
8497         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8498         * tui/tui-winsource.c (tui_show_source_line): Use
8499         tui_set_reverse_mode instead of setting A_STANDOUT.
8500         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8501         New setter methods.
8502
8503 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8504
8505         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8506         Handle tabs.
8507
8508 2019-03-18  Tom Tromey  <tromey@adacore.com>
8509
8510         * ada-lang.c (empty_array): Add "high" parameter.
8511         (ada_evaluate_subexp): Update.
8512
8513 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8514
8515         * unittests/string_view-selftests.c: Define
8516         _initialize_string_view_selftests unconditionally.
8517
8518 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8519
8520         PR gdb/24350
8521         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8522
8523 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8524
8525         PR gdb/24351
8526         * windows-nat.c (display_selector): Fix format specifiers.
8527
8528 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8529
8530         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8531         tui_refill_source_window instead of tui_refresh_win, to update the
8532         current execution line.  This fixes redisplay of the current line
8533         when stepping through the code with "next" or "step".
8534
8535 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8536
8537         * source-cache.c (source_cache::get_source_lines): Call
8538         find_source_lines to initialize s->nlines.  This fixes vertical
8539         scrolling of TUI source window when the DOWN arrow is pressed.
8540
8541 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8542
8543         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8544         linux-thread-db.c (_initialize_thread_db): Likewise.
8545
8546 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8547
8548         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8549         wclrtoeol in tui_show_source_line".  This reverts changes made in
8550         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8551
8552 2019-03-15  Tom Tromey  <tom@tromey.com>
8553
8554         * symtab.h (struct minimal_symbol): Derive from
8555         general_symbol_info.
8556         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8557         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8558         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8559         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8560         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8561         (MSYMBOL_SEARCH_NAME): Update.
8562         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8563         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8564         * minsyms.c (minimal_symbol_reader::record_full): Update.
8565
8566 2019-03-15  Tom Tromey  <tom@tromey.com>
8567
8568         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8569
8570 2019-03-15  Tom Tromey  <tom@tromey.com>
8571
8572         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8573         unique_xmalloc_ptr.
8574         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8575         Update.
8576         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8577         (build_minimal_symbol_hash_tables)
8578         (minimal_symbol_reader::install): Update.
8579
8580 2019-03-15  Tom Tromey  <tom@tromey.com>
8581
8582         * symtab.c (create_demangled_names_hash): Update.
8583         (symbol_set_names): Update.
8584         * objfiles.h (struct objfile_per_bfd_storage)
8585         <demangled_names_hash>: Now an htab_up.
8586         * objfiles.c (objfile_per_bfd_storage): Simplify.
8587
8588 2019-03-15  Tom Tromey  <tom@tromey.com>
8589
8590         * objfiles.h (struct objfile_per_bfd_storage): Declare
8591         destructor.
8592         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8593         New.
8594         (get_objfile_bfd_data): Use new.  Don't initialize
8595         language_of_main.
8596         (free_objfile_per_bfd_storage): Remove.
8597         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8598
8599 2019-03-15  Tom Tromey  <tom@tromey.com>
8600
8601         * symfile.c (reread_symbols): Update.
8602         * objfiles.c (objfile::objfile): Update.
8603         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8604         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8605         comment.
8606         (minimal_symbol_reader::install): Update.
8607         (terminate_minimal_symbol_table): Remove.
8608         * jit.c (jit_object_close_impl): Update.
8609
8610 2019-03-15  Tom Tromey  <tom@tromey.com>
8611
8612         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8613         initializations.
8614
8615 2019-03-15  Tom Tromey  <tom@tromey.com>
8616
8617         * objfiles.h (struct objfile_per_bfd_storage)
8618         <demangled_hash_languages>: Now a bitset.
8619         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8620         (lookup_minimal_symbol): Update.
8621
8622 2019-03-15  Tom Tromey  <tom@tromey.com>
8623
8624         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8625         Don't return the symbol.
8626         * coffread.c (record_minimal_symbol): Use record_full.
8627
8628 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8629
8630         The MS-Windows port of ncurses fails to switch to a color pair if
8631         one or both of the colors are the implicit default colors.  This
8632         change records the default colors when TUI is initialized, and
8633         then specifies them explicitly when a color pair uses the default
8634         colors.  This allows color styling in TUI mode on MS-Windows.
8635
8636         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8637         ncurses_norm_attr.
8638         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8639         colors in ncurses_norm_attr.
8640         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8641         "none", replace it with the default color recorded in
8642         ncurses_norm_attr.
8643
8644 2019-03-14  Tom Tromey  <tromey@adacore.com>
8645
8646         * source-cache.h (class source_cache) <get_source_lines>: Return
8647         std::string.
8648         * source-cache.c (source_cache::extract_lines): Handle case where
8649         first_pos==npos.  Return std::string.
8650         (source_cache::get_source_lines): Update.
8651
8652 2019-03-14  Tom Tromey  <tromey@adacore.com>
8653
8654         * NEWS: Add item for "style sources" commands.
8655         * source-cache.c (source_cache::get_source_lines): Check
8656         source_styling.
8657         * cli/cli-style.c (source_styling): New global.
8658         (_initialize_cli_style): Add "style sources" commands.
8659         (show_style_sources): New function.
8660         * cli/cli-style.h (source_styling): Declare.
8661
8662 2019-03-14  Pedro Alves  <palves@redhat.com>
8663             Tom Tromey  <tromey@adacore.com>
8664
8665         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8666         * tui/tui-winsource.c (tui_refill_source_window): New function,
8667         from...
8668         (tui_horizontal_source_scroll): ... here.  Move some logic.
8669         * cli/cli-style.c (set_style_enabled): Notify new observable.
8670         * tui/tui-hooks.c (tui_redisplay_source): New function.
8671         (tui_attach_detach_observers): Attach or detach
8672         tui_redisplay_source.
8673         * observable.h (source_styling_changed): New observable.
8674         * observable.c: Define source_styling_changed observable.
8675
8676 2019-03-13  Tom Tromey  <tromey@adacore.com>
8677
8678         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8679         (i386_gnu_nat_target::store_registers): Update.
8680         * target-debug.h (target_debug_print_std_string): New macro.
8681         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8682         * windows-tdep.c (display_one_tib): Update.
8683         * tui/tui-stack.c (tui_make_status_line): Update.
8684         * top.c (print_inferior_quit_action): Update.
8685         * thread.c (thr_try_catch_cmd): Update.
8686         (add_thread_with_info): Update.
8687         (thread_target_id_str): Update.
8688         (thr_try_catch_cmd): Update.
8689         (thread_command): Update.
8690         (thread_find_command): Update.
8691         * record-btrace.c (record_btrace_target::info_record)
8692         (record_btrace_resume_thread, record_btrace_target::resume)
8693         (record_btrace_cancel_resume, record_btrace_step_thread)
8694         (record_btrace_target::wait, record_btrace_target::wait)
8695         (record_btrace_target::wait, record_btrace_target::stop): Update.
8696         * progspace.c (print_program_space): Update.
8697         * process-stratum-target.c
8698         (process_stratum_target::thread_address_space): Update.
8699         * linux-fork.c (linux_fork_mourn_inferior)
8700         (detach_checkpoint_command, info_checkpoints_command)
8701         (linux_fork_context): Update.
8702         (linux_fork_detach): Update.
8703         (class scoped_switch_fork_info): Update.
8704         (delete_checkpoint_command): Update.
8705         * infrun.c (follow_fork_inferior): Update.
8706         (follow_fork_inferior): Update.
8707         (proceed_after_vfork_done): Update.
8708         (handle_vfork_child_exec_or_exit): Update.
8709         (follow_exec): Update.
8710         (displaced_step_prepare_throw): Update.
8711         (displaced_step_restore): Update.
8712         (start_step_over): Update.
8713         (resume_1): Update.
8714         (clear_proceed_status_thread): Update.
8715         (proceed): Update.
8716         (print_target_wait_results): Update.
8717         (do_target_wait): Update.
8718         (context_switch): Update.
8719         (stop_all_threads): Update.
8720         (restart_threads): Update.
8721         (finish_step_over): Update.
8722         (handle_signal_stop): Update.
8723         (switch_back_to_stepped_thread): Update.
8724         (keep_going_pass_signal): Update.
8725         (print_exited_reason): Update.
8726         (normal_stop): Update.
8727         * inferior.c (inferior_pid_to_str): Change return type.
8728         (print_selected_inferior): Update.
8729         (add_inferior): Update.
8730         (detach_inferior): Update.
8731         * dummy-frame.c (fprint_dummy_frames): Update.
8732         * dcache.c (dcache_info_1): Update.
8733         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8734         (btrace_fetch, btrace_clear): Update.
8735         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8736         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8737         type.
8738         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8739         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8740         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8741         * gdbarch.c, gdbarch.h: Rebuild.
8742         * gdbarch.sh (core_pid_to_str): Change return type.
8743         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8744         return type.
8745         (windows_nat_target::pid_to_str): Change return type.
8746         (windows_delete_thread): Update.
8747         (windows_nat_target::attach): Update.
8748         (windows_nat_target::files_info): Update.
8749         * target-delegates.c: Rebuild.
8750         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8751         return type.
8752         (sol_thread_target::pid_to_str): Change return type.
8753         * remote.c (class remote_target) <pid_to_str>: Change return
8754         type.
8755         (remote_target::pid_to_str): Change return type.
8756         (extended_remote_target::attach, remote_target::remote_stop_ns)
8757         (remote_target::remote_notif_remove_queued_reply)
8758         (remote_target::push_stop_reply, remote_target::disable_btrace):
8759         Update.
8760         (extended_remote_target::attach): Update.
8761         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8762         type.
8763         (gdbsim_target::pid_to_str): Change return type.
8764         * ravenscar-thread.c (struct ravenscar_thread_target)
8765         <pid_to_str>: Change return type.
8766         (ravenscar_thread_target::pid_to_str): Change return type.
8767         * procfs.c (class procfs_target) <pid_to_str>: Change return
8768         type.
8769         (procfs_target::pid_to_str): Change return type.
8770         (procfs_target::attach): Update.
8771         (procfs_target::detach): Update.
8772         (procfs_target::fetch_registers): Update.
8773         (procfs_target::store_registers): Update.
8774         (procfs_target::wait): Update.
8775         (procfs_target::files_info): Update.
8776         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8777         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8778         return type.
8779         (nto_procfs_target::pid_to_str): Change return type.
8780         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8781         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8782         return type.
8783         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8784         (exit_lwp): Update.
8785         (attach_proc_task_lwp_callback, get_detach_signal)
8786         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8787         (linux_nat_target::resume, wait_lwp, stop_callback)
8788         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8789         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8790         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8791         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8792         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8793         type.
8794         (inf_ptrace_target::attach): Update.
8795         (inf_ptrace_target::files_info): Update.
8796         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8797         type.
8798         (go32_nat_target::pid_to_str): Change return type.
8799         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8800         (gnu_nat_target::wait): Update.
8801         (gnu_nat_target::wait): Update.
8802         (gnu_nat_target::resume): Update.
8803         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8804         (fbsd_nat_target::wait): Update.
8805         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8806         type.
8807         (darwin_nat_target::attach): Update.
8808         * corelow.c (class core_target) <pid_to_str>: Change return type.
8809         (core_target::pid_to_str): Change return type.
8810         * target.c (normal_pid_to_str): Change return type.
8811         (default_pid_to_str): Likewise.
8812         (target_pid_to_str): Change return type.
8813         (target_translate_tls_address): Update.
8814         (target_announce_detach): Update.
8815         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8816         return type.
8817         (bsd_uthread_target::pid_to_str): Change return type.
8818         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8819         type.
8820         (bsd_kvm_target::pid_to_str): Change return type.
8821         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8822         return type.
8823         (aix_thread_target::pid_to_str): Change return type.
8824         * target.h (struct target_ops) <pid_to_str>: Change return type.
8825         (target_pid_to_str, normal_pid_to_str): Likewise.
8826         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8827         type.
8828         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8829         type.
8830         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8831         return type.
8832         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8833         type.
8834         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8835         type.
8836         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8837         return type.
8838
8839 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8840
8841         * NEWS: Mention that the new default MI version is 3.  Mention
8842         changes to the output of commands and events that deal with
8843         multi-location breakpoints.
8844         * breakpoint.c: Include "mi/mi-out.h".
8845         (print_one_breakpoint): Change output syntax if using MI version
8846         >= 3.
8847         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8848         New.
8849         (mi_multi_location_breakpoint_output_fixed): New.
8850         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8851         (mi_cmd_fix_multi_location_breakpoint_output): New.
8852         (mi_multi_location_breakpoint_output_fixed): New.
8853         * mi/mi-cmds.c (mi_cmds): Register command
8854         -fix-multi-location-breakpoint-output.
8855         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8856         interpreter "mi".
8857
8858 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8859
8860         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8861         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8862         instantiate mi_ui_out based on interpreter name.
8863         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8864         * mi/mi-main.c (mi_load_progress): Likewise.
8865
8866 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8867
8868         * NEWS: Combine separate "New targets" sections for 8.3.
8869
8870 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8871
8872         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8873         (ppcfbsd_init_abi): Install gdbarch
8874         "fetch_tls_load_module_address" and "get_thread_local_address"
8875         methods.
8876
8877 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8878
8879         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8880         (riscv_fbsd_init_abi): Install gdbarch
8881         "fetch_tls_load_module_address" and "get_thread_local_address"
8882         methods.
8883
8884 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8885
8886         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8887         (i386fbsd_init_abi): Install gdbarch
8888         "fetch_tls_load_module_address" and "get_thread_local_address"
8889         methods.
8890
8891 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8892
8893         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8894         (amd64fbsd_init_abi): Install gdbarch
8895         "fetch_tls_load_module_address" and "get_thread_local_address"
8896         methods.
8897
8898 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8899
8900         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8901         (struct fbsd_pspace_data): New type.
8902         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8903         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8904         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8905         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8906         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8907
8908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8909
8910         * gdbtypes.c (lookup_struct_elt): New function.
8911         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8912         * gdbtypes.h (struct struct_elt): New type.
8913         (lookup_struct_elt): New prototype.
8914
8915 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8916
8917         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8918         remove disabled code block.
8919
8920 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8921
8922         * gdbarch.sh (get_thread_local_address): New method.
8923         * gdbarch.h, gdbarch.c: Regenerate.
8924         * target.c (target_translate_tls_address): Use
8925         gdbarch_get_thread_local_address if present instead of
8926         target::get_thread_local_address.
8927
8928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8929
8930         * target.h (target::get_thread_local_address): Update comment.
8931
8932 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8933
8934         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8935         objfile->separate_debug_objfile_backlink if not NULL.
8936
8937 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8938
8939         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8940         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8941         (amd64bsd_store_inferior_registers): Likewise.
8942         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8943         Enable segment base registers.
8944         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8945         PT_GETFSBASE and PT_GETGSBASE.
8946         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8947         PT_SETGSBASE.
8948         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8949         segment base registers.
8950         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8951
8952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8953
8954         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8955         Update calls to i386_target_description to add 'segments'
8956         parameter.
8957         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8958         add segment base registers.
8959         * arch/i386.c (i386_create_target_description): Add 'segments'
8960         parameter to enable segment base registers.
8961         * arch/i386.h (i386_create_target_description): Likewise.
8962         * features/i386/32bit-segments.xml: New file.
8963         * features/i386/32bit-segments.c: Generate.
8964         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8965         call to i386_target_description to add 'segments' parameter.
8966         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8967         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8968         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8969         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8970         if feature is present.
8971         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8972         Add 'segments' parameter to call to i386_target_description.
8973         (i386_target_description): Add 'segments' parameter to enable
8974         segment base registers.
8975         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8976         to call to i386_target_description.
8977         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8978         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8979         Define I386_NUM_REGS.
8980         (i386_target_description): Add 'segments' parameter to enable
8981         segment base registers.
8982
8983 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8984
8985         PR/24325
8986         * source-cache.c: #undef open and close, to avoid unresolved
8987         externals during linking.
8988
8989 2019-03-12  Tom Tromey  <tromey@adacore.com>
8990
8991         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8992         const.  Add initializers.
8993         (_initialize_remote): Don't initialize ptid globals.
8994
8995 2019-03-12  Pedro Alves  <palves@redhat.com>
8996
8997         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8998
8999 2019-03-12  Pedro Alves  <palves@redhat.com>
9000
9001         * cp-name-parser.y (main): Remove unused 'len' variable.
9002
9003 2019-03-12  Tom Tromey  <tromey@adacore.com>
9004
9005         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9006         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9007
9008 2019-03-12  Tom Tromey  <tromey@adacore.com>
9009
9010         * linux-nat.c (iterate_over_lwps): Update.
9011         (stop_callback): Remove parameter.
9012         (stop_wait_callback, detach_callback, resume_set_callback)
9013         (select_singlestep_lwp_callback, set_ignore_sigint)
9014         (status_callback, resumed_callback, resume_clear_callback)
9015         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9016         data parameter.
9017         (linux_nat_target::detach, linux_nat_target::resume)
9018         (linux_stop_and_wait_all_lwps, select_event_lwp)
9019         (linux_nat_filter_event, linux_nat_wait_1)
9020         (linux_nat_target::kill, linux_nat_target::stop)
9021         (linux_nat_target::stop): Update.
9022         (linux_nat_resume_callback): Change type.
9023         (resume_stopped_resumed_lwps, count_events_callback)
9024         (select_event_lwp_callback): Likewise.
9025         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9026         * arm-linux-nat.c (struct update_registers_data): Remove.
9027         (update_registers_callback): Change type.
9028         (arm_linux_insert_hw_breakpoint1): Update.
9029         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9030         parameter.
9031         (x86_linux_dr_set_addr): Update.
9032         (x86_linux_dr_set_control): Update.
9033         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9034         (iterate_over_lwps): Use gdb::function_view.
9035         * nat/aarch64-linux-hw-point.c (struct
9036         aarch64_dr_update_callback_param): Remove.
9037         (debug_reg_change_callback): Change type.
9038         (aarch64_notify_debug_reg_change): Update.
9039         * s390-linux-nat.c (s390_refresh_per_info): Update.
9040
9041 2019-03-11  Tom Tromey  <tromey@adacore.com>
9042
9043         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9044         redundant assignment to "this_cu".
9045
9046 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9047
9048         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9049
9050 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9051
9052         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9053         from...
9054         (rank_one_type): ... this.
9055
9056 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9057
9058         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9059         from...
9060         (rank_one_type): ... this.
9061
9062 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9063
9064         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9065         from...
9066         (rank_one_type): ... this.
9067
9068 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9069
9070         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9071         from...
9072         (rank_one_type): ... this.
9073
9074 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9075
9076         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9077         from...
9078         (rank_one_type): ... this.
9079
9080 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9081
9082         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9083         from...
9084         (rank_one_type): ... this.
9085
9086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9087
9088         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9089         from...
9090         (rank_one_type): ... this.
9091
9092 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9093
9094         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9095         from...
9096         (rank_one_type): ... this.
9097
9098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9099
9100         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9101         from...
9102         (rank_one_type): ... this.
9103
9104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9105
9106         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9107         from...
9108         (rank_one_type): ... this.
9109
9110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9111
9112         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9113         from...
9114         (rank_one_type): ... this.
9115
9116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9117
9118         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9119         from...
9120         (rank_one_type): ... this.
9121
9122 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9123
9124         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9125         inferior-events' shows the example events.
9126
9127 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9128
9129         Support styling on native MS-Windows console
9130
9131         PR/24315
9132         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9133         on MS-Windows if $TERM is not defined.
9134
9135         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9136
9137         * posix-hdep.c (gdb_console_fputs):
9138         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9139         functions.
9140         * ui-file.h (gdb_console_fputs): Add prototype.
9141
9142         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9143         back to fputs only if the former returns zero.
9144
9145 2019-03-07  Tom Tromey  <tom@tromey.com>
9146
9147         * symmisc.c (print_symbol_bcache_statistics): Update.
9148         (print_objfile_statistics): Update.
9149         * symfile.c (allocate_symtab): Update.
9150         * stabsread.c: Don't include bcache.h.
9151         * psymtab.h (struct psymbol_bcache): Don't declare.
9152         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9153         (psymbol_bcache_init, psymbol_bcache_free)
9154         (psymbol_bcache_get_bcache): Don't declare.
9155         * psymtab.c (struct psymbol_bcache): Remove.
9156         (psymtab_storage::psymtab_storage): Update.
9157         (psymtab_storage::~psymtab_storage): Update.
9158         (psymbol_bcache_init, psymbol_bcache_free)
9159         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9160         (add_psymbol_to_bcache): Update.
9161         (allocate_psymtab): Update.
9162         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9163         macro_cache>: No longer pointers.
9164         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9165         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9166         * macrotab.c (macro_bcache): Update.
9167         * macroexp.c: Don't include bcache.h.
9168         * gdbtypes.c (check_types_worklist): Update.
9169         (types_deeply_equal): Remove TRY/CATCH.  Update.
9170         * elfread.c (elf_symtab_read): Update.
9171         * dwarf2read.c: Don't include bcache.h.
9172         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9173         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9174         (print_bcache_statistics, bcache_memory_used): Don't declare.
9175         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9176         methods.  Rename all data members.
9177         * bcache.c (struct bcache): Move to bcache.h.
9178         (bcache::expand_hash_table): Rename from expand_hash_table.
9179         (bcache): Remove.
9180         (bcache::insert): Rename from bcache_full.
9181         (bcache::compare): Rename from bcache_compare.
9182         (bcache_xmalloc): Remove.
9183         (bcache::~bcache): Rename from bcache_xfree.
9184         (bcache::print_statistics): Rename from print_bcache_statistics.
9185         (bcache::memory_used): Rename from bcache_memory_used.
9186
9187 2019-03-07  Pedro Alves  <palves@redhat.com>
9188
9189         * infrun.c (normal_stop): Also check for
9190         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9191
9192 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9193
9194         * f-lang.c (value_from_host_double): Moved to...
9195         * value.c (value_from_host_double): ...here.
9196         * value.h (value_from_host_double): Declare.
9197         * guile/scm-math.c (vlscm_convert_typed_number): Use
9198         value_from_host_double.
9199         (vlscm_convert_number): Likewise.
9200         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9201         * python/py-value.c (convert_value_from_python): Likewise.
9202
9203 2019-03-06  Tom Tromey  <tom@tromey.com>
9204
9205         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9206
9207 2019-03-06  Tom Tromey  <tom@tromey.com>
9208
9209         * utils.h (free_current_contents): Don't declare.
9210         * utils.c (free_current_contents): Remove.
9211
9212 2019-03-06  Tom Tromey  <tom@tromey.com>
9213
9214         * top.c (quit_force): Update.
9215         * main.c (captured_command_loop): Update.
9216         * common/new-op.c (operator new): Update.
9217         * common/common-exceptions.c (struct catcher)
9218         <save_cleanup_chain>: Remove member.
9219         (exceptions_state_mc_init): Update.
9220         (exception_try_scope_entry): Return nullptr.
9221         (exception_try_scope_exit, exception_rethrow)
9222         (throw_exception_sjlj, throw_exception_cxx): Update.
9223         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9224         (all_cleanups, do_cleanups, discard_cleanups)
9225         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9226         (restore_cleanups, restore_final_cleanups): Don't declare.
9227         (do_final_cleanups): Remove parameter.
9228         * common/cleanups.c (cleanup_chain, make_cleanup)
9229         (make_cleanup_dtor, all_cleanups, do_cleanups)
9230         (discard_my_cleanups, discard_cleanups)
9231         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9232         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9233         (null_cleanup): Remove.
9234         (do_final_cleanups): Remove parameter.
9235
9236 2019-03-06  Tom Tromey  <tom@tromey.com>
9237
9238         * remote.c (remote_target::remote_parse_stop_reply): Use
9239         unique_xmalloc_ptr.
9240
9241 2019-03-06  Tom Tromey  <tom@tromey.com>
9242
9243         * stabsread.c (struct stabs_field_info): Rename from field_info.
9244         <list, fnlist>: Add initializers.
9245         <obstack>: New member.
9246         (read_member_functions, read_struct_fields, read_baseclasses):
9247         Allocate on obstack.  Don't use cleanups.
9248         (read_one_struct_field, read_member_functions, read_struct_fields)
9249         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9250         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9251         (read_struct_type): Update.
9252
9253 2019-03-06  Tom Tromey  <tom@tromey.com>
9254
9255         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9256         * common/filestuff.h (make_cleanup_close): Don't declare.
9257         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9258         Remove.
9259
9260 2019-03-06  Tom Tromey  <tom@tromey.com>
9261
9262         * solib-aix.c: Use make_scope_exit.
9263
9264 2019-03-06  Tom Tromey  <tom@tromey.com>
9265
9266         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9267         Use make_scope_exit.
9268
9269 2019-03-06  Tom Tromey  <tom@tromey.com>
9270
9271         * solib-svr4.c (disable_probes_interface): Remove parameter.
9272         (svr4_handle_solib_event): Use make_scope_exit.
9273
9274 2019-03-06  Tom Tromey  <tom@tromey.com>
9275
9276         * remote.c (struct stop_reply_deleter): Remove.
9277         (stop_reply_up): Update.
9278         (struct stop_reply): Derive from notif_event.  Don't typedef.
9279         <regcache>: Now a std::vector.
9280         (stop_reply_xfree): Remove.
9281         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9282         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9283         (remote_target::discard_pending_stop_replies): Use delete.
9284         (remote_target::remote_parse_stop_reply): Update.
9285         (remote_target::process_stop_reply): Update.
9286         * remote-notif.h (struct notif_event): Add virtual destructor.
9287         Remove "dtr" member.
9288         (struct notif_client) <alloc_event>: Return a unique_ptr.
9289         (notif_event_xfree): Don't declare.
9290         (notif_event_up): New typedef.
9291         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9292         (notif_event_xfree, do_notif_event_xfree): Remove.
9293         (remote_notif_state_xfree): Update.
9294
9295 2019-03-06  Tom Tromey  <tom@tromey.com>
9296
9297         * infrun.c (displaced_step_clear_cleanup): Now a
9298         forward_scope_exit type.
9299         (displaced_step_prepare_throw): Update.
9300         (displaced_step_fixup): Update.
9301
9302 2019-03-06  Tom Tromey  <tom@tromey.com>
9303
9304         * inferior.h (class inferior): Update comment.
9305         * gdbthread.h (class thread_info): Update comment.
9306
9307 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9308             Tom Tromey  <tom@tromey.com>
9309
9310         * stabsread.h (struct stab_section_list): Remove.
9311         (coffstab_build_psymtabs): Update.
9312         * dbxread.c (symbuf_sections): Now a std::vector.
9313         (sect_idx): New global.
9314         (fill_symbuf): Update.
9315         (coffstab_build_psymtabs): Change type of stabsects parameter.
9316         Update.
9317         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9318         std::vector.
9319         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9320         (coff_locate_sections): Update.
9321         (coff_symfile_read): Remove cleanups.  Update.
9322         (init_stringtab): Add storage parameter.
9323         (free_stringtab, free_stringtab_cleanup): Remove.
9324         (init_lineno): Add storage parameter.
9325         (free_linetab, free_linetab_cleanup): Remove.
9326
9327 2019-03-06  Pedro Alves  <palves@redhat.com>
9328
9329         * linux-fork.c (fork_info::clobber_regs): Delete.
9330         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9331         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9332         comment.  Adjust.
9333         (scoped_switch_fork_info::scoped_switch_fork_info)
9334         (checkpoint_command, linux_fork_context): Adjust
9335         fork_save_infrun_state calls.
9336
9337 2019-03-06  Pedro Alves  <palves@redhat.com>
9338
9339         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9340         (inf_has_multiple_threads): Return 'bool' and rewrite using
9341         inferior_info::threads().
9342
9343 2019-03-06  Pedro Alves  <palves@redhat.com>
9344
9345         * linux-fork.c: Include <list>.
9346         (fork_list): Now a std::list instance.
9347         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9348         (forks_exist_p, find_last_fork): Adjust.
9349         (new_fork): Delete.
9350         (one_fork_p): New.
9351         (add_fork): Adjust.
9352         (free_fork): Delete, folded into fork_info::~fork_info().
9353         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9354         Adjust.
9355         (init_fork_list): Delete.
9356         (linux_fork_killall, linux_fork_mourn_inferior)
9357         (linux_fork_detach, info_checkpoints_command): Adjust.
9358         (_initialize_linux_fork): No longer call init_fork_list.
9359
9360 2019-03-06  Pedro Alves  <palves@redhat.com>
9361
9362         * linux-fork.c (new_fork): New, split out of ...
9363         (add_fork): ... this.  Return void.  Move "first fork" special
9364         case from here, to ...
9365         (checkpoint_command): ... here.
9366         * linux-linux.h (add_fork): Return void.
9367
9368 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9369
9370         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9371
9372 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9373             Chris January  <chris.january@arm.com>
9374             David Lecomber  <david.lecomber@arm.com>
9375
9376         * f-exp.y: New token, UNOP_INTRINSIC.
9377         (exp): New pattern using UNOP_INTRINSIC token.
9378         (f77_keywords): Add 'abs' keyword.
9379         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9380         (value_from_host_double): New function.
9381         (evaluate_subexp_f): Support UNOP_ABS.
9382
9383 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9384
9385         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9386         types.
9387
9388 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9389
9390         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9391         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9392         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9393
9394 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9395
9396         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9397
9398 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9399             Chris January  <chris.january@arm.com>
9400
9401         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9402         * f-exp.y: Define 'KIND' token.
9403         (exp): New pattern for KIND expressions.
9404         (ptype): Handle types with a kind extension.
9405         (direct_abs_decl): Extend to spot kind extensions.
9406         (f77_keywords): Add 'kind' to the list.
9407         (push_kind_type): New function.
9408         (convert_to_kind_type): New function.
9409         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9410         * parse.c (operator_length_standard): Likewise.
9411         * parser-defs.h (enum type_pieces): Add tp_kind.
9412         * std-operator.def: Add UNOP_KIND.
9413
9414 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9415
9416         * f-exp.y (f_parse): Set yydebug.
9417
9418 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9419
9420         * f-lang.c (evaluate_subexp_f): New function.
9421         (exp_descriptor_f): New global.
9422         (f_language_defn): Use exp_descriptor_f instead of
9423         exp_descriptor_standard.
9424
9425 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9426
9427         * f-exp.y (struct token): Add comments.
9428         (dot_ops): Remove uppercase versions and the end marker.
9429         (f77_keywords): Likewise.
9430         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9431         entries in the dot_ops array are case insensitive, and use
9432         strncasecmp to compare strings.  Also some whitespace cleanup in
9433         this area.  Similar for the f77_keywords array, except entries in
9434         this list might be case sensitive.
9435
9436 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9437
9438         * f-exp.y (struct f77_boolean_val): Add comments.
9439         (boolean_values): Remove uppercase versions, and end marker.
9440         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9441         and use strncasecmp to achieve case insensitivity.  Additionally,
9442         perform whitespace cleanup around this code.
9443
9444 2019-03-06  Tom Tromey  <tromey@adacore.com>
9445
9446         * remote-sim.c (gdbsim_target_open): Use result of
9447         gdb_argv::release.
9448
9449 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9450         Dirk Schubert  <dirk.schubert@arm.com>
9451         Chris January  <chris.january@arm.com>
9452
9453         * eval.c (evaluate_subexp_standard): Call Fortran argument
9454         wrapping logic.
9455         * f-lang.c (struct value): A value which can be passed into a
9456         Fortran function call.
9457         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9458         where appropriate.
9459         (struct type): Value ready for a Fortran function call.
9460         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9461         is needed.
9462         * f-lang.h (fortran_argument_convert): Declaration.
9463         (fortran_preserve_arg_pointer): Declaration.
9464         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9465
9466 2019-03-05  Tom Tromey  <tromey@adacore.com>
9467
9468         * python/py-prettyprint.c (print_string_repr): Remove #if.
9469         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9470
9471 2019-03-05  Tom Tromey  <tromey@adacore.com>
9472
9473         * target.c (the_dummy_target): Move later.  Change type to
9474         "dummy_target".
9475         (initialize_targets): Don't initialize the_dummy_target.
9476
9477 2019-03-05  Tom Tromey  <tromey@adacore.com>
9478
9479         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9480         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9481
9482 2019-03-05  Tom Tromey  <tromey@adacore.com>
9483
9484         * windows-nat.c (windows_nat_target::attach)
9485         (windows_nat_target::detach): Don't call gdb_flush.
9486         * valprint.c (generic_val_print, val_print, val_print_string):
9487         Don't call gdb_flush.
9488         * utils.c (defaulted_query): Don't call gdb_flush.
9489         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9490         * target.c (target_announce_detach): Don't call gdb_flush.
9491         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9492         * remote.c (extended_remote_target::attach): Don't call
9493         gdb_flush.
9494         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9495         * printcmd.c (do_examine): Don't call gdb_flush.
9496         (info_display_command): Don't call gdb_flush.
9497         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9498         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9499         * memattr.c (info_mem_command): Don't call gdb_flush.
9500         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9501         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9502         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9503         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9504         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9505         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9506         (gnu_nat_target::detach): Don't call gdb_flush.
9507         * f-valprint.c (f_val_print): Don't call gdb_flush.
9508         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9509         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9510         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9511         gdb_flush.
9512         * c-valprint.c (c_val_print): Don't call gdb_flush.
9513         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9514
9515 2019-03-05  Tom Tromey  <tromey@adacore.com>
9516
9517         * varobj.c (update_dynamic_varobj_children): Update.
9518         (install_default_visualizer): Use reset, not release.
9519         * value.c (set_internalvar): Update.
9520         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9521         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9522         ATTRIBUTE_UNUSED_RESULT.
9523
9524 2019-03-05  Tom Tromey  <tromey@adacore.com>
9525
9526         * remote.c (class scoped_remote_fd) <release>: Add
9527         ATTRIBUTE_UNUSED_RESULT.
9528
9529 2019-03-05  Tom Tromey  <tromey@adacore.com>
9530
9531         * macroexp.c (struct macro_buffer) <release>: Add
9532         ATTRIBUTE_UNUSED_RESULT.
9533
9534 2019-03-05  Tom Tromey  <tromey@adacore.com>
9535
9536         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9537         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9538         ATTRIBUTE_UNUSED_RESULT.
9539
9540 2019-03-05  Tom Tromey  <tromey@adacore.com>
9541
9542         * common/scoped_fd.h (class scoped_fd) <release>: Add
9543         ATTRIBUTE_UNUSED_RESULT.
9544
9545 2019-03-05  Tom Tromey  <tromey@adacore.com>
9546
9547         * parser-defs.h (struct parser_state) <release>: Add
9548         ATTRIBUTE_UNUSED_RESULT.
9549
9550 2019-03-05  Tom Tromey  <tromey@adacore.com>
9551
9552         * utils.h (class gdb_argv) <release>: Add
9553         ATTRIBUTE_UNUSED_RESULT.
9554         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9555
9556 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9557
9558         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9559         for-loop range, to avoid compiler warnings.
9560
9561         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9562         avoid compiler warnings about unused variables.
9563
9564         * NEWS: Mention end of support for native debugging on MS-Windows
9565         before XP.
9566
9567         PR gdb/24292
9568         * common/netstuff.c:
9569         * gdbserver/gdbreplay.c
9570         * gdbserver/remote-utils.c:
9571         * ser-tcp.c:
9572         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9573         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9574         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9575         'getaddrinfo' and 'freeaddrinfo' were not available before
9576         Windows XP, and mingw.org's MinGW headers by default define
9577         _WIN32_WINNT to 0x500.
9578
9579 2019-03-01  Gary Benson <gbenson@redhat.com>
9580
9581         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9582
9583 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9584             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9585
9586         PR gdb/8527
9587         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9588         set_sigint_trap, clear_sigint_trap.
9589
9590 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9591
9592         * target.c (target_detach): Clear the regcache and the
9593         frame cache.
9594
9595 2019-02-27  Pedro Alves  <palves@redhat.com>
9596
9597         * utils.c (set_screen_size): When we cap the height/width sizes,
9598         tweak the corresponding command variable to show "unlimited":
9599
9600 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9601             Pedro Alves  <palves@redhat.com>
9602
9603         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9604         before calling rl_set_screen_size.
9605
9606 2019-02-27  Tom Tromey  <tromey@adacore.com>
9607
9608         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9609         define.
9610         * python/py-value.c: Remove Python 2.4 workaround.
9611         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9612         workaround.
9613         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9614         Python 2.4 workaround.
9615         * python/python-internal.h: Remove Python 2.4 comment.
9616         (Py_ssize_t): Don't define.
9617         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9618         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9619         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9620         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9621         * python/python.c (do_start_initialization): Remove Python 2.4
9622         workaround.
9623         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9624         (print_children): Remove Python 2.4 workaround.
9625         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9626         workaround.
9627         (CHARBUFFERPROC_NAME): Remove.
9628         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9629         Python 2.4 workaround.
9630
9631 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9632
9633         * NEWS: Note minimum Python version.
9634
9635 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9636
9637         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9638         code from these functions.  Remove corresponding ifdefs.  Use
9639         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9640         Remove gotos and target of gotos.
9641         (infpy_search_memory): Likewise.
9642
9643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9644
9645         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9646         (hppa_gdbarch_init): Don't register deleted functions with
9647         gdbarch.
9648
9649 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9650
9651         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9652         (h8300_unwind_sp): Delete.
9653         (h8300_dummy_id): Delete.
9654         (h8300_gdbarch_init): Don't register deleted functions with
9655         gdbarch.
9656
9657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9658
9659         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9660         (ft32_unwind_pc): Delete.
9661         (ft32_unwind_sp): Delete.
9662         (ft32_gdbarch_init): Don't register deleted functions with
9663         gdbarch.
9664
9665 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9666
9667         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9668         (frv_unwind_pc): Delete.
9669         (frv_unwind_sp): Delete.
9670         (frv_gdbarch_init): Don't register deleted functions with
9671         gdbarch.
9672
9673 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9674
9675         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9676         (riscv_unwind_pc): Delete.
9677         (riscv_unwind_sp): Delete.
9678         (riscv_gdbarch_init): Don't register deleted functions with
9679         gdbarch.
9680
9681 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9682
9683         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9684         (csky_unwind_pc): Delete.
9685         (csky_unwind_sp): Delete.
9686         (csky_gdbarch_init): Don't register deleted functions with
9687         gdbarch.
9688
9689 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9690
9691         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9692         (cris_unwind_pc): Delete.
9693         (cris_unwind_sp): Delete.
9694         (cris_gdbarch_init): Don't register deleted functions with
9695         gdbarch.
9696
9697 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9698
9699         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9700         (bfin_unwind_pc): Delete.
9701         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9702
9703 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9704
9705         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9706         (arm_unwind_pc): Delete.
9707         (arm_unwind_sp): Delete.
9708         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9709
9710 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9711
9712         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9713         (arc_unwind_pc): Delete.
9714         (arc_unwind_sp): Delete.
9715         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9716
9717 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9718
9719         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9720         (alpha_unwind_pc): Delete.
9721         (alpha_gdbarch_init): Don't register deleted functions with
9722         gdbarch.
9723
9724 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9725
9726         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9727         (aarch64_unwind_pc): Delete.
9728         (aarch64_unwind_sp): Delete.
9729         (aarch64_gdbarch_init): Don't register deleted functions with
9730         gdbarch.
9731
9732 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9733
9734         * gdbtypes.c (type_align): Don't consider static members when
9735         computing structure alignment.
9736
9737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9738
9739         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9740         return 0 for other types.
9741         * arch-utils.c (default_type_align): Always return 0.
9742         * gdbarch.h: Regenerate.
9743         * gdbarch.sh (type_align): Extend comment.
9744         * gdbtypes.c (type_align): Add additional comments, always call
9745         gdbarch_type_align before applying the default rules.
9746         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9747         generic code will then apply a suitable default.
9748         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9749         types, return 0 for other types.
9750
9751 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9752
9753         * NEWS: Create a new section for the next release branch.
9754         Rename the section of the current branch, now that it has
9755         been cut.
9756
9757 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9758
9759         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9760         * version.in: Bump version to 8.3.50.DATE-git.
9761
9762 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9763
9764         * aix-thread.c (ptid_cmp): Remove unused variable.
9765         (get_signaled_thread): Likewise.
9766         (store_regs_user_thread): Likewise.
9767         (store_regs_kernel_thread): Likewise.
9768         (fetch_regs_kernel_thread): Remove shadowed variable.
9769
9770 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9771
9772         * features/riscv/32bit-cpu.xml: Add register numbers.
9773         * features/riscv/32bit-fpu.c: Regenerate.
9774         * features/riscv/32bit-fpu.xml: Add register numbers.
9775         * features/riscv/64bit-cpu.xml: Add register numbers.
9776         * features/riscv/64bit-fpu.c: Regenerate.
9777         * features/riscv/64bit-fpu.xml: Add register numbers.
9778
9779 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9780
9781         * NEWS: Mention two argument form of gdb.Value constructor.
9782         * python/py-value.c (convert_buffer_and_type_to_value): New
9783         function.
9784         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9785         Add support for handling an optional second argument.  Call
9786         convert_buffer_and_type_to_value as appropriate.
9787         * python/python-internal.h (Py_buffer_deleter): New struct.
9788         (Py_buffer_up): New typedef.
9789
9790 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9791
9792         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9793         instead of releasing ownership.
9794
9795 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9796
9797         * dwarf2read.c (open_and_init_dwp_file): Call
9798         elf_numsections instead of bfd_count_sections to initialize
9799         dwp_file->num_sections.
9800
9801 2019-02-25  Tom Tromey  <tromey@adacore.com>
9802
9803         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9804
9805 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9806
9807         * gcore.in: Add '--readnever' option when invoking GDB.
9808
9809 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9810
9811         * MAINTAINERS: Update my email address.
9812
9813 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9814
9815         * build-id.c (build_id_to_debug_bfd_1): New function.
9816         (build_id_to_debug_bfd): Look for separate debug file in
9817         sysroot.
9818
9819 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9820
9821         * gdbarch.sh: Update the copyright year range that is placed into
9822         generated files.
9823
9824 2019-02-22  Keith Seitz  <keiths@redhat.com>
9825
9826         PR symtab/23853
9827         * linespec.c (create_sals_line_offset): Search for the default
9828         symtab's filename instead of its fullname.
9829
9830 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9831
9832         * NEWS: Update style defaults.
9833
9834 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9835
9836         * main.c (captured_main_1): Disable styling in batch mode.
9837
9838 2019-02-20  Tom Tromey  <tom@tromey.com>
9839
9840         * symtab.c (symtab_symbol_info): Fix typos.
9841
9842 2019-02-20  Tom Tromey  <tromey@adacore.com>
9843
9844         * findcmd.c (_initialize_mem_search): Use upper case for
9845         metasyntactic variables.
9846
9847 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9848
9849         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9850         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9851
9852 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9853
9854         * top.h (source_file_name): Change to std::string.
9855         * top.c (source_file_name): Likewise.
9856         (command_line_input): Adjust.
9857         * cli/cli-script.c (script_from_file): Adjust.
9858
9859 2019-02-19  Tom Tromey  <tromey@adacore.com>
9860
9861         * ravenscar-thread.c
9862         (ravenscar_thread_target::update_thread_list): Don't call
9863         ada_build_task_list.
9864         * ada-lang.h (ada_build_task_list): Don't declare.
9865         * ada-tasks.c (struct ada_tasks_inferior_data)
9866         <task_list_valid_p>: Now bool.
9867         (read_known_tasks, ada_task_list_changed)
9868         (ada_tasks_invalidate_inferior_data): Update.
9869         (read_known_tasks_array): Return bool.
9870         (read_known_tasks_list): Likewise.
9871         (read_known_tasks): Return void.
9872         (ada_build_task_list): Now static.
9873
9874 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9875
9876         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9877         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9878
9879 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9880
9881         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9882         variant for ada_tasks_pspace_data_handle and
9883         ada_tasks_inferior_data_handle.
9884         (ada_tasks_pspace_data_cleanup): New function.
9885         (ada_tasks_inferior_data_cleanup): New function.
9886
9887 2019-02-17  Tom Tromey  <tom@tromey.com>
9888
9889         * macrotab.h (macro_source_fullname): Return a std::string.
9890         * macrotab.c (macro_include, check_for_redefinition)
9891         (macro_undef, macro_lookup_definition, foreach_macro)
9892         (foreach_macro_in_scope): Update.
9893         (macro_source_fullname): Return a std::string.
9894         * macrocmd.c (show_pp_source_pos): Update.
9895
9896 2019-02-17  Tom Tromey  <tom@tromey.com>
9897
9898         * macrocmd.c (show_pp_source_pos): Style the file names.
9899
9900 2019-02-17  Tom Tromey  <tom@tromey.com>
9901
9902         PR tui/24197:
9903         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9904
9905 2019-02-17  Tom Tromey  <tom@tromey.com>
9906
9907         * ada-lang.c (user_select_syms): Use filtered printing.
9908         * utils.c (wrap_style): New global.
9909         (desired_style): Remove.
9910         (emit_style_escape): Add stream parameter.
9911         (set_output_style, reset_terminal_style, prompt_for_continue):
9912         Update.
9913         (flush_wrap_buffer): Only flush gdb_stdout.
9914         (wrap_here): Set wrap_style.
9915         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9916         treat escape sequences as a character.  Change when wrap buffer is
9917         flushed.
9918         (fputs_styled): Do not set the output style when the default is
9919         requested.
9920         * ui-style.h (struct ui_file_style) <is_default>: New method.
9921         * source.c (print_source_lines_base): Emit escape sequences in one
9922         piece.
9923
9924 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9925
9926         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9927         integers and enumeration types.
9928
9929 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9930
9931         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9932         instead of lookup_symbol_in_language
9933         (do_exact_match): New function.
9934         (ada_get_symbol_name_matcher): Return do_exact_match when
9935         doing a verbatim match.
9936
9937 2019-02-15  Tom Tromey  <tromey@adacore.com>
9938
9939         * ravenscar-thread.c (ravenscar_thread_target::resume)
9940         (ravenscar_thread_target::wait): Special case wildcard requests.
9941
9942 2019-02-15  Tom Tromey  <tromey@adacore.com>
9943
9944         * ravenscar-thread.c (base_ptid): Remove.
9945         (struct ravenscar_thread_target) <close>: New method.
9946         <m_base_ptid>: New member.
9947         <update_inferior_ptid, active_task, task_is_currently_active,
9948         runtime_initialized>: Declare methods.
9949         <ravenscar_thread_target>: Add constructor.
9950         (ravenscar_thread_target::task_is_currently_active)
9951         (ravenscar_thread_target::update_inferior_ptid)
9952         (ravenscar_runtime_initialized): Rename.  Now methods.
9953         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9954         (ravenscar_thread_target::update_thread_list): Update.
9955         (ravenscar_thread_target::active_task): Now method.
9956         (ravenscar_thread_target::store_registers)
9957         (ravenscar_thread_target::prepare_to_store)
9958         (ravenscar_thread_target::prepare_to_store)
9959         (ravenscar_thread_target::mourn_inferior): Update.
9960         (ravenscar_inferior_created): Use "new" to create target.
9961         (ravenscar_thread_target::get_ada_task_ptid): Update.
9962         (_initialize_ravenscar): Don't initialize base_ptid.
9963         (ravenscar_ops): Remove global.
9964
9965 2019-02-15  Tom Tromey  <tromey@adacore.com>
9966
9967         * target.h (push_target): Declare new overload.
9968         * target.c (push_target): New overload, taking an rvalue reference.
9969         * remote.c (remote_target::open_1): Use push_target overload.
9970         * corelow.c (core_target_open): Use push_target overload.
9971
9972 2019-02-15  Tom Tromey  <tromey@adacore.com>
9973
9974         * ravenscar-thread.c (is_ravenscar_task)
9975         (ravenscar_task_is_currently_active): Return bool.
9976         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9977         (_initialize_ravenscar): Remove "(void)".
9978         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9979         Return bool.
9980
9981 2019-02-15  Tom Tromey  <tromey@adacore.com>
9982
9983         * ravenscar-thread.c (ravenscar_runtime_initializer)
9984         (has_ravenscar_runtime, get_running_thread_id)
9985         (ravenscar_thread_target::resume): Fix indentation.
9986
9987 2019-02-15  Tom Tromey  <tromey@adacore.com>
9988
9989         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9990         from ravenscar_arch_ops.
9991         (sparc_ravenscar_ops::fetch_registers)
9992         (sparc_ravenscar_ops::store_registers): Now methods.
9993         (sparc_ravenscar_prepare_to_store): Remove.
9994         (sparc_ravenscar_ops): Redefine.
9995         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9996         methods and destructor.  Remove members.
9997         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9998         (ravenscar_thread_target::store_registers)
9999         (ravenscar_thread_target::prepare_to_store): Update.
10000         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10001         Remove.
10002         (struct ppc_ravenscar_powerpc_ops): Derive from
10003         ravenscar_arch_ops.
10004         (ppc_ravenscar_powerpc_ops::fetch_registers)
10005         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10006         (ppc_ravenscar_powerpc_ops): Redefine.
10007         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10008         (ppc_ravenscar_e500_ops::fetch_registers)
10009         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10010         (ppc_ravenscar_e500_ops): Redefine.
10011         * aarch64-ravenscar-thread.c
10012         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10013         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10014         (aarch64_ravenscar_fetch_registers)
10015         (aarch64_ravenscar_store_registers): Now methods.
10016         (aarch64_ravenscar_ops): Redefine.
10017
10018 2019-02-15  Tom Tromey  <tromey@adacore.com>
10019
10020         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10021         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10022         (ravenscar_thread_target::stopped_by_watchpoint)
10023         (ravenscar_thread_target::stopped_data_address)
10024         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10025
10026 2019-02-15  Tom Tromey  <tromey@adacore.com>
10027
10028         * ravenscar-thread.c: Fix some typos.
10029
10030 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10031             Tom Tromey  <tromey@adacore.com>
10032
10033         * ada-lang.c (ada_exception_sal): Change addr_string to a
10034         std::string.
10035         (create_ada_exception_catchpoint): Update.
10036
10037 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10038             Tom Tromey  <tromey@adacore.com>
10039
10040         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10041         (bp_location_ops): Remove.
10042         (base_breakpoint_allocate_location): Update.
10043         (free_bp_location): Update.
10044         * ada-lang.c (class ada_catchpoint_location)
10045         <ada_catchpoint_location>: Remove ops parameter.
10046         (ada_catchpoint_location_dtor): Remove.
10047         (ada_catchpoint_location_ops): Remove.
10048         (allocate_location_exception): Update.
10049         * breakpoint.h (struct bp_location_ops): Remove.
10050         (class bp_location) <bp_location>: Remove bp_location_ops
10051         parameter.
10052         <~bp_location>: Add destructor.
10053         <ops>: Remove.
10054
10055 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10056             Pedro Alves  <palves@redhat.com>
10057
10058         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10059         'PATH_MAX'.
10060
10061 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10062             Samuel Thibault  <samuel.thibault@gnu.org>
10063             Thomas Schwinge  <thomas@codesourcery.com>
10064
10065         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10066         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10067
10068 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10069
10070         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10071         (check_empty): Use "const char *".
10072
10073         * gnu-nat.c (gnu_nat_target::detach): Instead of
10074         'detach_inferior (pid)' call
10075         'detach_inferior (find_inferior_pid (pid))'.
10076
10077         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10078         'nat/fork-inferior.o'.
10079         * gnu-nat.c: #include "nat/fork-inferior.h".
10080
10081         * gnu-nat.c (gnu_nat_target::detach): Instead of
10082         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10083         * gnu-nat.h: #include "inf-child.h".
10084         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10085         'i386_gnu_nat_target::fetch_registers'.
10086         (gnu_store_registers): Rename/move to
10087         'i386_gnu_nat_target::store_registers'.
10088
10089         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10090         * gnu-nat.h (mach_thread_info): New function.
10091         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10092
10093         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10094
10095 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10096
10097         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10098
10099 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10100
10101         * windows-nat.c (windows_add_thread): Add new parameter
10102         "main_thread_p" with default value set to false.  Update
10103         function documentation as well as all callers.
10104         (windows_delete_thread): Likewise.
10105         (fake_create_process): Update call to windows_add_thread.
10106         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10107         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10108         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10109         call to windows_delete_thread.
10110
10111 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10112
10113         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10114
10115 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10116
10117         * symfile.c (find_separate_debug_file): Use canonical path of
10118         sysroot with child_path instead of gdb_sysroot if it is valid.
10119
10120 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10121
10122         * symfile.c (find_separate_debug_file): Use child_path to
10123         determine if an object file is under a sysroot.
10124
10125 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10126
10127         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10128         unittests/child-path-selftests.c.
10129         * common/pathstuff.c (child_path): New function.
10130         * common/pathstuff.h (child_path): New prototype.
10131         * unittests/child-path-selftests.c: New file.
10132
10133 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10134
10135         * symfile.c (find_separate_debug_file): Look for separate debug
10136         files in debug directories under the sysroot.
10137
10138 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10139
10140         * symtab.h (struct minimal_symbol data_p): New const method.
10141         (struct minimal_symbol text_p): Likewise.
10142         * symtab.c (output_source_filename): Use file name style
10143         to print file name.
10144         (print_symbol_info): Likewise.
10145         (print_msymbol_info): Use address style to print addresses.
10146         Use function name style to print executable text symbols.
10147         (expand_symtab_containing_pc): Use data_p.
10148         (find_pc_sect_compunit_symtab): Likewise.
10149
10150 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10151
10152         * breakpoint.c (describe_other_breakpoints): Use address style
10153         to print addresses.
10154         (say_where): Likewise.
10155
10156 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10157
10158         * ada-typeprint.c (print_func_type): Print function name
10159         style to print function name.
10160         * c-typeprint.c (c_print_type_1): Likewise.
10161
10162 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10163
10164         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10165         for execve.
10166
10167 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10168
10169         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10170         type_stack.
10171
10172 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10173
10174         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10175         TYPE_CODE_REF types.
10176
10177 2019-02-08  Jim Wilson  <jimw@sifive.com>
10178
10179         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10180         (riscv_linux_fregset): New.
10181         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10182
10183 2019-02-07  Tom Tromey  <tom@tromey.com>
10184
10185         * thread.c (thread_cancel_execution_command): Update.
10186         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10187         methods.
10188         (struct thread_fsm_ops): Remove.
10189         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10190         (thread_fsm_should_stop, thread_fsm_return_value)
10191         (thread_fsm_set_finished, thread_fsm_finished_p)
10192         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10193         Don't declare.
10194         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10195         * infrun.c (clear_proceed_status_thread)
10196         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10197         (print_stop_event): Update.
10198         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10199         Add constructor.
10200         (step_command_fsm_ops): Remove.
10201         (new_step_command_fsm): Remove.
10202         (step_1): Update.
10203         (step_command_fsm::should_stop): Rename from
10204         step_command_fsm_should_stop.
10205         (step_command_fsm::clean_up): Rename from
10206         step_command_fsm_clean_up.
10207         (step_command_fsm::do_async_reply_reason): Rename from
10208         step_command_fsm_async_reply_reason.
10209         (struct until_next_fsm): Inherit from thread_fsm.  Add
10210         constructor.
10211         (until_next_fsm_ops): Remove.
10212         (new_until_next_fsm): Remove.
10213         (until_next_fsm::should_stop): Rename from
10214         until_next_fsm_should_stop.
10215         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10216         (until_next_fsm::do_async_reply_reason): Rename from
10217         until_next_fsm_async_reply_reason.
10218         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10219         constructor.  Change type of breakpoint.
10220         (finish_command_fsm_ops): Remove.
10221         (new_finish_command_fsm): Remove.
10222         (finish_command_fsm::should_stop): Rename from
10223         finish_command_fsm_should_stop.
10224         (finish_command_fsm::clean_up): Rename from
10225         finish_command_fsm_clean_up.
10226         (finish_command_fsm::return_value): Rename from
10227         finish_command_fsm_return_value.
10228         (finish_command_fsm::do_async_reply_reason): Rename from
10229         finish_command_fsm_async_reply_reason.
10230         (finish_command): Update.
10231         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10232         Add constructor.
10233         (call_thread_fsm_ops): Remove.
10234         (call_thread_fsm::call_thread_fsm): Rename from
10235         new_call_thread_fsm.
10236         (call_thread_fsm::should_stop): Rename from
10237         call_thread_fsm_should_stop.
10238         (call_thread_fsm::should_notify_stop): Rename from
10239         call_thread_fsm_should_notify_stop.
10240         (run_inferior_call, call_function_by_hand_dummy): Update.
10241         * cli/cli-interp.c (should_print_stop_to_console): Update.
10242         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10243         Add constructor.  Change type of location_breakpoint,
10244         caller_breakpoint.
10245         (until_break_fsm_ops): Remove.
10246         (new_until_break_fsm): Remove.
10247         (until_break_fsm::should_stop): Rename from
10248         until_break_fsm_should_stop.
10249         (until_break_fsm::clean_up): Rename from
10250         until_break_fsm_clean_up.
10251         (until_break_fsm::do_async_reply_reason): Rename from
10252         until_break_fsm_async_reply_reason.
10253         (until_break_command): Update.
10254         * thread-fsm.c: Remove.
10255         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10256
10257 2019-02-07  Tom Tromey  <tom@tromey.com>
10258
10259         * yy-remap.h: Add include guard.
10260         * xtensa-tdep.h: Add include guard.
10261         * xcoffread.h: Rename include guard.
10262         * varobj-iter.h: Add include guard.
10263         * tui/tui.h: Rename include guard.
10264         * tui/tui-winsource.h: Rename include guard.
10265         * tui/tui-wingeneral.h: Rename include guard.
10266         * tui/tui-windata.h: Rename include guard.
10267         * tui/tui-win.h: Rename include guard.
10268         * tui/tui-stack.h: Rename include guard.
10269         * tui/tui-source.h: Rename include guard.
10270         * tui/tui-regs.h: Rename include guard.
10271         * tui/tui-out.h: Rename include guard.
10272         * tui/tui-layout.h: Rename include guard.
10273         * tui/tui-io.h: Rename include guard.
10274         * tui/tui-hooks.h: Rename include guard.
10275         * tui/tui-file.h: Rename include guard.
10276         * tui/tui-disasm.h: Rename include guard.
10277         * tui/tui-data.h: Rename include guard.
10278         * tui/tui-command.h: Rename include guard.
10279         * tic6x-tdep.h: Add include guard.
10280         * target/waitstatus.h: Rename include guard.
10281         * target/wait.h: Rename include guard.
10282         * target/target.h: Rename include guard.
10283         * target/resume.h: Rename include guard.
10284         * target-float.h: Rename include guard.
10285         * stabsread.h: Add include guard.
10286         * rs6000-tdep.h: Add include guard.
10287         * riscv-fbsd-tdep.h: Add include guard.
10288         * regformats/regdef.h: Rename include guard.
10289         * record.h: Rename include guard.
10290         * python/python.h: Rename include guard.
10291         * python/python-internal.h: Rename include guard.
10292         * python/py-stopevent.h: Rename include guard.
10293         * python/py-ref.h: Rename include guard.
10294         * python/py-record.h: Rename include guard.
10295         * python/py-record-full.h: Rename include guard.
10296         * python/py-record-btrace.h: Rename include guard.
10297         * python/py-instruction.h: Rename include guard.
10298         * python/py-events.h: Rename include guard.
10299         * python/py-event.h: Rename include guard.
10300         * procfs.h: Add include guard.
10301         * proc-utils.h: Add include guard.
10302         * p-lang.h: Add include guard.
10303         * or1k-tdep.h: Rename include guard.
10304         * observable.h: Rename include guard.
10305         * nto-tdep.h: Rename include guard.
10306         * nat/x86-linux.h: Rename include guard.
10307         * nat/x86-linux-dregs.h: Rename include guard.
10308         * nat/x86-gcc-cpuid.h: Add include guard.
10309         * nat/x86-dregs.h: Rename include guard.
10310         * nat/x86-cpuid.h: Rename include guard.
10311         * nat/ppc-linux.h: Rename include guard.
10312         * nat/mips-linux-watch.h: Rename include guard.
10313         * nat/linux-waitpid.h: Rename include guard.
10314         * nat/linux-ptrace.h: Rename include guard.
10315         * nat/linux-procfs.h: Rename include guard.
10316         * nat/linux-osdata.h: Rename include guard.
10317         * nat/linux-nat.h: Rename include guard.
10318         * nat/linux-namespaces.h: Rename include guard.
10319         * nat/linux-btrace.h: Rename include guard.
10320         * nat/glibc_thread_db.h: Rename include guard.
10321         * nat/gdb_thread_db.h: Rename include guard.
10322         * nat/gdb_ptrace.h: Rename include guard.
10323         * nat/fork-inferior.h: Rename include guard.
10324         * nat/amd64-linux-siginfo.h: Rename include guard.
10325         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10326         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10327         * nat/aarch64-linux.h: Rename include guard.
10328         * nat/aarch64-linux-hw-point.h: Rename include guard.
10329         * mn10300-tdep.h: Add include guard.
10330         * mips-linux-tdep.h: Add include guard.
10331         * mi/mi-parse.h: Rename include guard.
10332         * mi/mi-out.h: Rename include guard.
10333         * mi/mi-main.h: Rename include guard.
10334         * mi/mi-interp.h: Rename include guard.
10335         * mi/mi-getopt.h: Rename include guard.
10336         * mi/mi-console.h: Rename include guard.
10337         * mi/mi-common.h: Rename include guard.
10338         * mi/mi-cmds.h: Rename include guard.
10339         * mi/mi-cmd-break.h: Rename include guard.
10340         * m2-lang.h: Add include guard.
10341         * location.h: Rename include guard.
10342         * linux-record.h: Rename include guard.
10343         * linux-nat.h: Add include guard.
10344         * linux-fork.h: Add include guard.
10345         * i386-darwin-tdep.h: Rename include guard.
10346         * hppa-linux-offsets.h: Add include guard.
10347         * guile/guile.h: Rename include guard.
10348         * guile/guile-internal.h: Rename include guard.
10349         * gnu-nat.h: Rename include guard.
10350         * gdb-stabs.h: Rename include guard.
10351         * frv-tdep.h: Add include guard.
10352         * f-lang.h: Add include guard.
10353         * event-loop.h: Add include guard.
10354         * darwin-nat.h: Rename include guard.
10355         * cp-abi.h: Rename include guard.
10356         * config/sparc/nm-sol2.h: Rename include guard.
10357         * config/nm-nto.h: Rename include guard.
10358         * config/nm-linux.h: Add include guard.
10359         * config/i386/nm-i386gnu.h: Rename include guard.
10360         * config/djgpp/nl_types.h: Rename include guard.
10361         * config/djgpp/langinfo.h: Rename include guard.
10362         * compile/gcc-cp-plugin.h: Add include guard.
10363         * compile/gcc-c-plugin.h: Add include guard.
10364         * compile/compile.h: Rename include guard.
10365         * compile/compile-object-run.h: Rename include guard.
10366         * compile/compile-object-load.h: Rename include guard.
10367         * compile/compile-internal.h: Rename include guard.
10368         * compile/compile-cplus.h: Rename include guard.
10369         * compile/compile-c.h: Rename include guard.
10370         * common/xml-utils.h: Rename include guard.
10371         * common/x86-xstate.h: Rename include guard.
10372         * common/version.h: Rename include guard.
10373         * common/vec.h: Rename include guard.
10374         * common/tdesc.h: Rename include guard.
10375         * common/selftest.h: Rename include guard.
10376         * common/scoped_restore.h: Rename include guard.
10377         * common/scoped_mmap.h: Rename include guard.
10378         * common/scoped_fd.h: Rename include guard.
10379         * common/safe-iterator.h: Rename include guard.
10380         * common/run-time-clock.h: Rename include guard.
10381         * common/refcounted-object.h: Rename include guard.
10382         * common/queue.h: Rename include guard.
10383         * common/ptid.h: Rename include guard.
10384         * common/print-utils.h: Rename include guard.
10385         * common/preprocessor.h: Rename include guard.
10386         * common/pathstuff.h: Rename include guard.
10387         * common/observable.h: Rename include guard.
10388         * common/netstuff.h: Rename include guard.
10389         * common/job-control.h: Rename include guard.
10390         * common/host-defs.h: Rename include guard.
10391         * common/gdb_wait.h: Rename include guard.
10392         * common/gdb_vecs.h: Rename include guard.
10393         * common/gdb_unlinker.h: Rename include guard.
10394         * common/gdb_unique_ptr.h: Rename include guard.
10395         * common/gdb_tilde_expand.h: Rename include guard.
10396         * common/gdb_sys_time.h: Rename include guard.
10397         * common/gdb_string_view.h: Rename include guard.
10398         * common/gdb_splay_tree.h: Rename include guard.
10399         * common/gdb_setjmp.h: Rename include guard.
10400         * common/gdb_ref_ptr.h: Rename include guard.
10401         * common/gdb_optional.h: Rename include guard.
10402         * common/gdb_locale.h: Rename include guard.
10403         * common/gdb_assert.h: Rename include guard.
10404         * common/filtered-iterator.h: Rename include guard.
10405         * common/filestuff.h: Rename include guard.
10406         * common/fileio.h: Rename include guard.
10407         * common/environ.h: Rename include guard.
10408         * common/common-utils.h: Rename include guard.
10409         * common/common-types.h: Rename include guard.
10410         * common/common-regcache.h: Rename include guard.
10411         * common/common-inferior.h: Rename include guard.
10412         * common/common-gdbthread.h: Rename include guard.
10413         * common/common-exceptions.h: Rename include guard.
10414         * common/common-defs.h: Rename include guard.
10415         * common/common-debug.h: Rename include guard.
10416         * common/cleanups.h: Rename include guard.
10417         * common/buffer.h: Rename include guard.
10418         * common/btrace-common.h: Rename include guard.
10419         * common/break-common.h: Rename include guard.
10420         * cli/cli-utils.h: Rename include guard.
10421         * cli/cli-style.h: Rename include guard.
10422         * cli/cli-setshow.h: Rename include guard.
10423         * cli/cli-script.h: Rename include guard.
10424         * cli/cli-interp.h: Rename include guard.
10425         * cli/cli-decode.h: Rename include guard.
10426         * cli/cli-cmds.h: Rename include guard.
10427         * charset-list.h: Add include guard.
10428         * buildsym-legacy.h: Rename include guard.
10429         * bfin-tdep.h: Add include guard.
10430         * ax.h: Rename include guard.
10431         * arm-linux-tdep.h: Add include guard.
10432         * arm-fbsd-tdep.h: Add include guard.
10433         * arch/xtensa.h: Rename include guard.
10434         * arch/tic6x.h: Add include guard.
10435         * arch/i386.h: Add include guard.
10436         * arch/arm.h: Rename include guard.
10437         * arch/arm-linux.h: Rename include guard.
10438         * arch/arm-get-next-pcs.h: Rename include guard.
10439         * arch/amd64.h: Add include guard.
10440         * arch/aarch64-insn.h: Rename include guard.
10441         * arch-utils.h: Rename include guard.
10442         * annotate.h: Add include guard.
10443         * amd64-darwin-tdep.h: Rename include guard.
10444         * aarch64-linux-tdep.h: Add include guard.
10445         * aarch64-fbsd-tdep.h: Add include guard.
10446         * aarch32-linux-nat.h: Add include guard.
10447
10448 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10449
10450         * macrotab.c (macro_define_internal): New function that
10451         factorizes macro_define_object_internal and macro_define_function
10452         code.
10453         (macro_define_object_internal): Use macro_define_internal.
10454         (macro_define_function): Likewise.
10455
10456 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10457
10458         * macrocmd.c (extract_identifier): Return
10459         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10460         callers.
10461
10462 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10463
10464         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10465
10466 2019-02-05  Tom Tromey  <tom@tromey.com>
10467
10468         * target.c (target_stack::unpush): Move assertion earlier.
10469
10470 2019-01-30  Tom Tromey  <tom@tromey.com>
10471
10472         PR python/23615:
10473         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10474         (gdbpy_parse_and_eval): Likewise.
10475         * python/python-internal.h (gdbpy_allow_threads): New class.
10476
10477 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10478
10479         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10480         (aarch64_fbsd_fpregmap): Move earlier.
10481         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10482         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10483         instead of individual calls to trad_frame_set_reg_addr.
10484         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10485         earlier.
10486         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10487         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10488         instead of individual calls to trad_frame_set_reg_addr.
10489
10490 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10491
10492         * CONTRIBUTE: Replace contribution list with wiki link.
10493
10494 2019-01-25  Tom Tromey  <tom@tromey.com>
10495
10496         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10497
10498 2019-01-25  Tom Tromey  <tom@tromey.com>
10499
10500         * xtensa-linux-nat.c: Fix common/ includes.
10501         * xml-support.h: Fix common/ includes.
10502         * xml-support.c: Fix common/ includes.
10503         * x86-linux-nat.c: Fix common/ includes.
10504         * windows-nat.c: Fix common/ includes.
10505         * varobj.h: Fix common/ includes.
10506         * varobj.c: Fix common/ includes.
10507         * value.c: Fix common/ includes.
10508         * valops.c: Fix common/ includes.
10509         * utils.c: Fix common/ includes.
10510         * unittests/xml-utils-selftests.c: Fix common/ includes.
10511         * unittests/utils-selftests.c: Fix common/ includes.
10512         * unittests/unpack-selftests.c: Fix common/ includes.
10513         * unittests/tracepoint-selftests.c: Fix common/ includes.
10514         * unittests/style-selftests.c: Fix common/ includes.
10515         * unittests/string_view-selftests.c: Fix common/ includes.
10516         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10517         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10518         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10519         * unittests/rsp-low-selftests.c: Fix common/ includes.
10520         * unittests/parse-connection-spec-selftests.c: Fix common/
10521         includes.
10522         * unittests/optional-selftests.c: Fix common/ includes.
10523         * unittests/offset-type-selftests.c: Fix common/ includes.
10524         * unittests/observable-selftests.c: Fix common/ includes.
10525         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10526         * unittests/memrange-selftests.c: Fix common/ includes.
10527         * unittests/memory-map-selftests.c: Fix common/ includes.
10528         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10529         * unittests/function-view-selftests.c: Fix common/ includes.
10530         * unittests/environ-selftests.c: Fix common/ includes.
10531         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10532         * unittests/common-utils-selftests.c: Fix common/ includes.
10533         * unittests/cli-utils-selftests.c: Fix common/ includes.
10534         * unittests/array-view-selftests.c: Fix common/ includes.
10535         * ui-file.c: Fix common/ includes.
10536         * tui/tui-io.c: Fix common/ includes.
10537         * tracepoint.h: Fix common/ includes.
10538         * tracepoint.c: Fix common/ includes.
10539         * tracefile-tfile.c: Fix common/ includes.
10540         * top.h: Fix common/ includes.
10541         * top.c: Fix common/ includes.
10542         * thread.c: Fix common/ includes.
10543         * target/waitstatus.h: Fix common/ includes.
10544         * target/waitstatus.c: Fix common/ includes.
10545         * target.h: Fix common/ includes.
10546         * target.c: Fix common/ includes.
10547         * target-memory.c: Fix common/ includes.
10548         * target-descriptions.c: Fix common/ includes.
10549         * symtab.h: Fix common/ includes.
10550         * symfile.c: Fix common/ includes.
10551         * stap-probe.c: Fix common/ includes.
10552         * spu-linux-nat.c: Fix common/ includes.
10553         * sparc-nat.c: Fix common/ includes.
10554         * source.c: Fix common/ includes.
10555         * solib.c: Fix common/ includes.
10556         * solib-target.c: Fix common/ includes.
10557         * ser-unix.c: Fix common/ includes.
10558         * ser-tcp.c: Fix common/ includes.
10559         * ser-pipe.c: Fix common/ includes.
10560         * ser-base.c: Fix common/ includes.
10561         * selftest-arch.c: Fix common/ includes.
10562         * s12z-tdep.c: Fix common/ includes.
10563         * rust-exp.y: Fix common/ includes.
10564         * rs6000-aix-tdep.c: Fix common/ includes.
10565         * riscv-tdep.c: Fix common/ includes.
10566         * remote.c: Fix common/ includes.
10567         * remote-notif.h: Fix common/ includes.
10568         * remote-fileio.h: Fix common/ includes.
10569         * remote-fileio.c: Fix common/ includes.
10570         * regcache.h: Fix common/ includes.
10571         * regcache.c: Fix common/ includes.
10572         * record-btrace.c: Fix common/ includes.
10573         * python/python.c: Fix common/ includes.
10574         * python/py-type.c: Fix common/ includes.
10575         * python/py-inferior.c: Fix common/ includes.
10576         * progspace.h: Fix common/ includes.
10577         * producer.c: Fix common/ includes.
10578         * procfs.c: Fix common/ includes.
10579         * proc-api.c: Fix common/ includes.
10580         * printcmd.c: Fix common/ includes.
10581         * ppc-linux-nat.c: Fix common/ includes.
10582         * parser-defs.h: Fix common/ includes.
10583         * osdata.c: Fix common/ includes.
10584         * obsd-nat.c: Fix common/ includes.
10585         * nat/x86-linux.c: Fix common/ includes.
10586         * nat/x86-linux-dregs.c: Fix common/ includes.
10587         * nat/x86-dregs.h: Fix common/ includes.
10588         * nat/x86-dregs.c: Fix common/ includes.
10589         * nat/ppc-linux.c: Fix common/ includes.
10590         * nat/mips-linux-watch.h: Fix common/ includes.
10591         * nat/mips-linux-watch.c: Fix common/ includes.
10592         * nat/linux-waitpid.c: Fix common/ includes.
10593         * nat/linux-ptrace.h: Fix common/ includes.
10594         * nat/linux-ptrace.c: Fix common/ includes.
10595         * nat/linux-procfs.c: Fix common/ includes.
10596         * nat/linux-personality.c: Fix common/ includes.
10597         * nat/linux-osdata.c: Fix common/ includes.
10598         * nat/linux-namespaces.c: Fix common/ includes.
10599         * nat/linux-btrace.h: Fix common/ includes.
10600         * nat/linux-btrace.c: Fix common/ includes.
10601         * nat/fork-inferior.c: Fix common/ includes.
10602         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10603         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10604         * nat/aarch64-linux.c: Fix common/ includes.
10605         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10606         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10607         * namespace.h: Fix common/ includes.
10608         * mips-linux-tdep.c: Fix common/ includes.
10609         * minsyms.c: Fix common/ includes.
10610         * mi/mi-parse.h: Fix common/ includes.
10611         * mi/mi-main.c: Fix common/ includes.
10612         * mi/mi-cmd-env.c: Fix common/ includes.
10613         * memrange.h: Fix common/ includes.
10614         * memattr.c: Fix common/ includes.
10615         * maint.h: Fix common/ includes.
10616         * maint.c: Fix common/ includes.
10617         * main.c: Fix common/ includes.
10618         * machoread.c: Fix common/ includes.
10619         * location.c: Fix common/ includes.
10620         * linux-thread-db.c: Fix common/ includes.
10621         * linux-nat.c: Fix common/ includes.
10622         * linux-fork.c: Fix common/ includes.
10623         * inline-frame.c: Fix common/ includes.
10624         * infrun.c: Fix common/ includes.
10625         * inflow.c: Fix common/ includes.
10626         * inferior.h: Fix common/ includes.
10627         * inferior.c: Fix common/ includes.
10628         * infcmd.c: Fix common/ includes.
10629         * inf-ptrace.c: Fix common/ includes.
10630         * inf-child.c: Fix common/ includes.
10631         * ia64-linux-nat.c: Fix common/ includes.
10632         * i387-tdep.c: Fix common/ includes.
10633         * i386-tdep.c: Fix common/ includes.
10634         * i386-linux-tdep.c: Fix common/ includes.
10635         * i386-linux-nat.c: Fix common/ includes.
10636         * i386-go32-tdep.c: Fix common/ includes.
10637         * i386-fbsd-tdep.c: Fix common/ includes.
10638         * i386-fbsd-nat.c: Fix common/ includes.
10639         * guile/scm-type.c: Fix common/ includes.
10640         * guile/guile.c: Fix common/ includes.
10641         * go32-nat.c: Fix common/ includes.
10642         * gnu-nat.c: Fix common/ includes.
10643         * gdbthread.h: Fix common/ includes.
10644         * gdbarch-selftests.c: Fix common/ includes.
10645         * gdb_usleep.c: Fix common/ includes.
10646         * gdb_select.h: Fix common/ includes.
10647         * gdb_bfd.c: Fix common/ includes.
10648         * gcore.c: Fix common/ includes.
10649         * fork-child.c: Fix common/ includes.
10650         * findvar.c: Fix common/ includes.
10651         * fbsd-nat.c: Fix common/ includes.
10652         * event-top.c: Fix common/ includes.
10653         * event-loop.c: Fix common/ includes.
10654         * dwarf2read.c: Fix common/ includes.
10655         * dwarf2loc.c: Fix common/ includes.
10656         * dwarf2-frame.c: Fix common/ includes.
10657         * dwarf-index-cache.c: Fix common/ includes.
10658         * dtrace-probe.c: Fix common/ includes.
10659         * disasm-selftests.c: Fix common/ includes.
10660         * defs.h: Fix common/ includes.
10661         * csky-tdep.c: Fix common/ includes.
10662         * cp-valprint.c: Fix common/ includes.
10663         * cp-support.h: Fix common/ includes.
10664         * cp-support.c: Fix common/ includes.
10665         * corelow.c: Fix common/ includes.
10666         * completer.h: Fix common/ includes.
10667         * completer.c: Fix common/ includes.
10668         * compile/compile.c: Fix common/ includes.
10669         * compile/compile-loc2c.c: Fix common/ includes.
10670         * compile/compile-cplus-types.c: Fix common/ includes.
10671         * compile/compile-cplus-symbols.c: Fix common/ includes.
10672         * command.h: Fix common/ includes.
10673         * cli/cli-dump.c: Fix common/ includes.
10674         * cli/cli-cmds.c: Fix common/ includes.
10675         * charset.c: Fix common/ includes.
10676         * build-id.c: Fix common/ includes.
10677         * btrace.h: Fix common/ includes.
10678         * btrace.c: Fix common/ includes.
10679         * breakpoint.h: Fix common/ includes.
10680         * breakpoint.c: Fix common/ includes.
10681         * ax.h:
10682         (enum agent_op): Fix common/ includes.
10683         * ax-general.c (struct aop_map): Fix common/ includes.
10684         * ax-gdb.c: Fix common/ includes.
10685         * auxv.c: Fix common/ includes.
10686         * auto-load.c: Fix common/ includes.
10687         * arm-tdep.c: Fix common/ includes.
10688         * arch/riscv.c: Fix common/ includes.
10689         * arch/ppc-linux-common.c: Fix common/ includes.
10690         * arch/i386.c: Fix common/ includes.
10691         * arch/arm.c: Fix common/ includes.
10692         * arch/arm-linux.c: Fix common/ includes.
10693         * arch/arm-get-next-pcs.c: Fix common/ includes.
10694         * arch/amd64.c: Fix common/ includes.
10695         * arch/aarch64.c: Fix common/ includes.
10696         * arch/aarch64-insn.c: Fix common/ includes.
10697         * arch-utils.c: Fix common/ includes.
10698         * amd64-windows-tdep.c: Fix common/ includes.
10699         * amd64-tdep.c: Fix common/ includes.
10700         * amd64-sol2-tdep.c: Fix common/ includes.
10701         * amd64-obsd-tdep.c: Fix common/ includes.
10702         * amd64-nbsd-tdep.c: Fix common/ includes.
10703         * amd64-linux-tdep.c: Fix common/ includes.
10704         * amd64-linux-nat.c: Fix common/ includes.
10705         * amd64-fbsd-tdep.c: Fix common/ includes.
10706         * amd64-fbsd-nat.c: Fix common/ includes.
10707         * amd64-dicos-tdep.c: Fix common/ includes.
10708         * amd64-darwin-tdep.c: Fix common/ includes.
10709         * agent.c: Fix common/ includes.
10710         * ada-lang.h: Fix common/ includes.
10711         * ada-lang.c: Fix common/ includes.
10712         * aarch64-tdep.c: Fix common/ includes.
10713
10714 2019-01-25  Tom Tromey  <tom@tromey.com>
10715
10716         * common/create-version.sh: Use common/version.h.
10717
10718 2019-01-24  Pedro Alves  <palves@redhat.com>
10719
10720         * infrun.c (signal_stop, signal_print, signal_program)
10721         (signal_catch, signal_pass): Now arrays instead of pointers.
10722         (update_signals_program_target, do_target_resume)
10723         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10724         * linux-nat.c (linux_nat_target::pass_signals)
10725         (linux_nat_target::create_inferior, linux_nat_target::attach):
10726         Adjust.
10727         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10728         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10729         * procfs.c (procfs_target::pass_signals): Adjust.
10730         * record-full.c (record_full_target::resume): Adjust.
10731         * remote.c (remote_target::pass_signals)
10732         (remote_target::program_signals): Adjust.
10733         * target-debug.h (target_debug_print_signals): Now takes a
10734         gdb::array_view as parameter.  Adjust.
10735         * target.h (target_ops) <pass_signals, program_signals>: Replace
10736         pointer and length parameters with gdb::array_view.
10737         (target_pass_signals, target_program_signals): Likewise.
10738         * target-delegates.c: Regenerate.
10739
10740 2019-01-24  Pedro Alves  <palves@redhat.com>
10741
10742         * common/forward-scope-exit.h
10743         (forward_scope_exit::forward_scope_exit): Pass arguments to
10744         m_bind_function directly, instead of creating a std::bind and
10745         copying that.
10746
10747 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10748
10749         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10750         for static members.
10751         (pass_in_v_vfp_candidate): Likewise.
10752
10753 2019-01-23  Tom Tromey  <tom@tromey.com>
10754             Pedro Alves  <palves@redhat.com>
10755
10756         * regcache.c (class regcache_invalidator): Remove.
10757         (regcache::raw_write): Use make_scope_exit.
10758
10759 2019-01-23  Tom Tromey  <tom@tromey.com>
10760
10761         * ui-out.h (class ui_out_emit_type): Update comment.
10762
10763 2019-01-23  Tom Tromey  <tom@tromey.com>
10764
10765         * infrun.c (fetch_inferior_event): Update comment.
10766
10767 2019-01-23  Tom Tromey  <tom@tromey.com>
10768             Pedro Alves  <palves@redhat.com>
10769
10770         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10771         parameter.
10772         (fetch_inferior_event): Use SCOPE_EXIT.
10773
10774
10775 2019-01-23  Tom Tromey  <tom@tromey.com>
10776             Pedro Alves  <palves@redhat.com>
10777
10778         * infrun.c (disable_thread_events): Delete.
10779         (stop_all_threads): Use SCOPE_EXIT.
10780
10781 2019-01-23  Tom Tromey  <tom@tromey.com>
10782             Pedro Alves  <palves@redhat.com>
10783
10784         * symfile.c: Include forward-scope-exit.h.
10785         (clear_symtab_users_cleanup): Replace forward declaration with
10786         a FORWARD_SCOPE_EXIT.
10787         (syms_from_objfile_1): Use the forward_scope_exit and
10788         gdb::optional instead of cleanup_function.
10789         (reread_symbols): Use the forward_scope_exit instead of
10790         cleanup_function.
10791         (clear_symtab_users_cleanup): Remove function.
10792
10793 2019-01-23  Tom Tromey  <tom@tromey.com>
10794             Pedro Alves  <palves@redhat.com>
10795
10796         * linux-nat.c: Include scope-exit.h.
10797         (cleanup_target_stop): Remove.
10798         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10799         SCOPE_EXIT.
10800
10801 2019-01-23  Tom Tromey  <tom@tromey.com>
10802             Pedro Alves  <palves@redhat.com>
10803
10804         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10805         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10806
10807 2019-01-23  Tom Tromey  <tom@tromey.com>
10808             Andrew Burgess  <andrew.burgess@embecosm.com>
10809             Pedro Alves  <palves@redhat.com>
10810
10811         * infrun.c (fetch_inferior_event): Use scope_exit.
10812         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10813         * top.c (execute_command): Use scope_exit.
10814         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10815         * utils.c (do_bpstat_clear_actions_cleanup)
10816         (make_bpstat_clear_actions_cleanup): Remove.
10817
10818 2019-01-23  Tom Tromey  <tom@tromey.com>
10819             Pedro Alves  <palves@redhat.com>
10820
10821         * infrun.c: Include "common/scope-exit.h"
10822         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10823         (wait_for_inferior): Use SCOPE_EXIT.
10824         (fetch_inferior_event): Use scope_exit.
10825
10826 2019-01-23  Tom Tromey  <tom@tromey.com>
10827             Pedro Alves  <palves@redhat.com>
10828
10829         * breakpoint.c (create_breakpoint): Remove cleanup.
10830
10831 2019-01-23  Tom Tromey  <tom@tromey.com>
10832             Andrew Burgess  <andrew.burgess@embecosm.com>
10833             Pedro Alves  <palves@redhat.com>
10834
10835 2019-01-23  Pedro Alves  <palves@redhat.com>
10836
10837         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10838
10839 2019-01-23  Pedro Alves  <palves@redhat.com>
10840             Andrew Burgess  <andrew.burgess@embecosm.com>
10841
10842         * gdbthread.h: Include "common/forward-scope-exit.h".
10843         (scoped_finish_thread_state): Redefine custom class in terms of
10844         forward_scope_exit.
10845
10846 2019-01-23  Pedro Alves  <palves@redhat.com>
10847             Andrew Burgess  <andrew.burgess@embecosm.com>
10848
10849         * common/forward-scope-exit.h: New file.
10850
10851 2019-01-23  Pedro Alves  <palves@redhat.com>
10852             Andrew Burgess  <andrew.burgess@embecosm.com>
10853             Tom Tromey  <tom@tromey.com>
10854
10855         * common/scope-exit.h: New file.
10856
10857 2019-01-23  Pedro Alves  <palves@redhat.com>
10858
10859         * common/preprocessor.h (ESC): Rename to ...
10860         (ESC_PARENS): ... this.
10861         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10862         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10863
10864 2019-01-23  Tom Tromey  <tom@tromey.com>
10865
10866         * language.h (class scoped_switch_to_sym_language_if_auto):
10867         Initialize m_lang in both cases.
10868
10869 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10870
10871         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10872         with XCNEW.
10873
10874 2019-01-22  Tom Tromey  <tom@tromey.com>
10875
10876         * corelow.c: Do not include sys/file.h.
10877
10878 2019-01-22  Tom Tromey  <tom@tromey.com>
10879
10880         * tui/tui-wingeneral.h: Include gdb_curses.h.
10881
10882 2019-01-22  Tom Tromey  <tom@tromey.com>
10883
10884         * source-cache.h (class source_cache) <get_source_lines,
10885         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10886
10887 2019-01-22  Tom Tromey  <tom@tromey.com>
10888
10889         * remote-fileio.h (struct remote_target): Declare.
10890
10891 2019-01-22  Tom Tromey  <tom@tromey.com>
10892
10893         * python/py-arch.c: Do not include py-ref.h.
10894         * python/py-bpevent.c: Do not include py-ref.h.
10895         * python/py-cmd.c: Do not include py-ref.h.
10896         * python/py-continueevent.c: Do not include py-ref.h.
10897         * python/py-event.h: Do not include py-ref.h.
10898         * python/py-evtregistry.c: Do not include py-ref.h.
10899         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10900         * python/py-frame.c: Do not include py-ref.h.
10901         * python/py-framefilter.c: Do not include py-ref.h.
10902         * python/py-function.c: Do not include py-ref.h.
10903         * python/py-infevents.c: Do not include py-ref.h.
10904         * python/py-linetable.c: Do not include py-ref.h.
10905         * python/py-objfile.c: Do not include py-ref.h.
10906         * python/py-param.c: Do not include py-ref.h.
10907         * python/py-prettyprint.c: Do not include py-ref.h.
10908         * python/py-progspace.c: Do not include py-ref.h.
10909         * python/py-symbol.c: Do not include py-ref.h.
10910         * python/py-symtab.c: Do not include py-ref.h.
10911         * python/py-type.c: Do not include py-ref.h.
10912         * python/py-unwind.c: Do not include py-ref.h.
10913         * python/py-utils.c: Do not include py-ref.h.
10914         * python/py-value.c: Do not include py-ref.h.
10915         * python/py-varobj.c: Do not include py-ref.h.
10916         * python/py-xmethods.c: Do not include py-ref.h.
10917         * python/python.c: Do not include py-ref.h.
10918         * varobj.c: Do not include py-ref.h.
10919
10920 2019-01-22  Tom Tromey  <tom@tromey.com>
10921
10922         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10923         keyword for bcache.
10924
10925 2019-01-22  Tom Tromey  <tom@tromey.com>
10926
10927         * compile/compile-cplus-types.c: Remove a comment by #include.
10928
10929 2019-01-22  Tom Tromey  <tom@tromey.com>
10930
10931         * compile/gcc-c-plugin.h: Include compile-internal.h.
10932
10933 2019-01-22  Tom Tromey  <tom@tromey.com>
10934
10935         * stabsread.c (EXTERN): Do not define.
10936         (symnum, next_symbol_text_func, processing_gcc_compilation)
10937         (within_function, global_sym_chain, global_stabs)
10938         (previous_stab_code, this_object_header_files)
10939         (n_this_object_header_files)
10940         (n_allocated_this_object_header_files): Define.
10941         * stabsread.h (EXTERN): Never define.  Use "extern".
10942
10943 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10944
10945         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10946         history_value.
10947
10948 2019-01-21  Tom Tromey  <tom@tromey.com>
10949
10950         * ui-out.c: Fix includes.
10951         * tui/tui-source.c: Fix includes.
10952         * target.c: Fix includes.
10953         * remote.c: Fix includes.
10954         * regcache.c: Fix includes.
10955         * python/py-block.c: Fix includes.
10956         * printcmd.c: Fix includes.
10957         * or1k-tdep.c: Fix includes.
10958         * mi/mi-main.c: Fix includes.
10959         * m32r-tdep.c: Fix includes.
10960         * csky-tdep.c: Fix includes.
10961         * compile/compile-cplus-types.c: Fix includes.
10962         * cli/cli-interp.c: Fix includes.
10963
10964 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10965
10966         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10967         for padding.
10968
10969 2019-01-16  Tom Tromey  <tom@tromey.com>
10970
10971         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10972         earlier.
10973         (struct objfile) <msymbols_range>: Move from top level.
10974         <msymbols>: New method.
10975         (class objfile_msymbols): Remove.
10976         * symtab.c (default_collect_symbol_completion_matches_break_on):
10977         Update.
10978         * symmisc.c (dump_msymbols): Update.
10979         * stabsread.c (scan_file_globals): Update.
10980         * objc-lang.c (info_selectors_command, info_classes_command)
10981         (find_methods): Update.
10982         * minsyms.c (find_solib_trampoline_target): Update.
10983         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10984         * coffread.c (coff_symfile_read): Update.
10985         * ada-lang.c (ada_lookup_simple_minsym)
10986         (ada_collect_symbol_completion_matches): Update.
10987
10988 2019-01-16  Tom Tromey  <tom@tromey.com>
10989
10990         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10991         type.  Remove no-argument constructor.
10992         <iterator::operator++>: Simplify.
10993         <begin>: Update.
10994         <end>: Use minimal_symbol_count.
10995
10996 2019-01-16  Tom Tromey  <tom@tromey.com>
10997
10998         * objfiles.h (struct objfile) <psymtabs>: New method.
10999         (class objfile_psymtabs): Remove.
11000         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11001         typedef.
11002         <range>: New method.
11003         (require_partial_symbols): Change return type.
11004         * psymtab.c (require_partial_symbols)
11005         (psym_expand_symtabs_matching): Update.
11006         * mdebugread.c (parse_partial_symbols): Update.
11007         * dbxread.c (dbx_end_psymtab): Update.
11008
11009 2019-01-15  Tom Tromey  <tom@tromey.com>
11010
11011         * symtab.c (lookup_objfile_from_block)
11012         (lookup_symbol_in_objfile_symtabs)
11013         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11014         (find_line_symtab, info_sources_command)
11015         (default_collect_symbol_completion_matches_break_on)
11016         (make_source_files_completion_list): Update.
11017         * symmisc.c (print_objfile_statistics, dump_objfile)
11018         (maintenance_print_symbols, maintenance_info_symtabs)
11019         (maintenance_check_symtabs, maintenance_info_line_tables):
11020         Update.
11021         * source.c (select_source_symtab)
11022         (forget_cached_source_info_for_objfile): Update.
11023         * objfiles.h (class objfile_compunits): Remove.
11024         (struct objfile) <compunits_range>: New typedef.
11025         (compunits): New method.
11026         * objfiles.c (objfile_relocate1): Update.
11027         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11028         * maint.c (count_symtabs_and_blocks): Update.
11029         * linespec.c (iterate_over_all_matching_symtabs): Update.
11030         * cp-support.c (add_symbol_overload_list_qualified): Update.
11031         * coffread.c (coff_symtab_read): Update.
11032         * ada-lang.c (add_nonlocal_symbols)
11033         (ada_collect_symbol_completion_matches)
11034         (ada_add_global_exceptions): Update.
11035
11036 2019-01-15  Tom Tromey  <tom@tromey.com>
11037
11038         * progspace.h (program_space) <objfiles_safe_range>: New
11039         typedef.
11040         <objfiles_safe>: New method.
11041         * objfiles.h (class all_objfiles_safe): Remove.
11042         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11043         * jit.c (jit_inferior_exit_hook): Update.
11044
11045 2019-01-17  Tom Tromey  <tom@tromey.com>
11046
11047         * progspace.h (program_space) <objfiles_range>: New typedef.
11048         <objfiles>: New method.
11049         <objfiles_head>: Rename from objfiles.
11050         (object_files): Update.
11051         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11052         * guile/scm-pretty-print.c
11053         (ppscm_find_pretty_printer_from_objfiles): Update.
11054         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11055         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11056         Update.
11057         * python/py-progspace.c (pspy_get_objfiles): Update.
11058         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11059         Update.
11060         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11061         (objfpy_lookup_objfile_by_build_id): Update.
11062         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11063         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11064         Update.
11065         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11066         (expand_symtab_containing_pc, lookup_objfile_from_block)
11067         (lookup_static_symbol, basic_lookup_transparent_type)
11068         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11069         (find_line_symtab, info_sources_command)
11070         (default_collect_symbol_completion_matches_break_on)
11071         (make_source_files_completion_list, find_main_name): Update.
11072         * symmisc.c (print_symbol_bcache_statistics)
11073         (print_objfile_statistics, maintenance_print_symbols)
11074         (maintenance_print_msymbols, maintenance_print_objfiles)
11075         (maintenance_info_symtabs, maintenance_check_symtabs)
11076         (maintenance_expand_symtabs, maintenance_info_line_tables):
11077         Update.
11078         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11079         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11080         (map_overlay_command, unmap_overlay_command)
11081         (simple_overlay_update, expand_symtabs_matching)
11082         (map_symbol_filenames): Update.
11083         * symfile-debug.c (set_debug_symfile): Update.
11084         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11085         Update.
11086         * source.c (select_source_symtab, forget_cached_source_info):
11087         Update.
11088         * solib.c (solib_read_symbols): Update.
11089         * solib-spu.c (append_ocl_sos): Update.
11090         * psymtab.c (maintenance_print_psymbols)
11091         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11092         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11093         * printcmd.c (info_symbol_command): Update.
11094         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11095         Update.
11096         * objfiles.h (class all_objfiles): Remove.
11097         * objfiles.c (have_partial_symbols, have_full_symbols)
11098         (have_minimal_symbols, qsort_cmp, update_section_map)
11099         (shared_objfile_contains_address_p)
11100         (default_iterate_over_objfiles_in_search_order): Update.
11101         * objc-lang.c (info_selectors_command, info_classes_command)
11102         (find_methods): Update.
11103         * minsyms.c (find_solib_trampoline_target): Update.
11104         * maint.c (maintenance_info_sections)
11105         (maintenance_translate_address, count_symtabs_and_blocks):
11106         Update.
11107         * main.c (captured_main_1): Update.
11108         * linux-thread-db.c (try_thread_db_load_from_pdir)
11109         (has_libpthread): Update.
11110         * linespec.c (iterate_over_all_matching_symtabs)
11111         (search_minsyms_for_name): Update.
11112         * jit.c (jit_find_objf_with_entry_addr): Update.
11113         * hppa-tdep.c (find_unwind_entry)
11114         (hppa_lookup_stub_minimal_symbol): Update.
11115         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11116         Update.
11117         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11118         (elf_gnu_ifunc_resolve_by_got): Update.
11119         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11120         * dwarf-index-write.c (save_gdb_index_command): Update.
11121         * cp-support.c (add_symbol_overload_list_qualified): Update.
11122         * breakpoint.c (create_overlay_event_breakpoint)
11123         (create_longjmp_master_breakpoint)
11124         (create_std_terminate_master_breakpoint)
11125         (create_exception_master_breakpoint): Update.
11126         * blockframe.c (find_pc_partial_function): Update.
11127         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11128         (ada_collect_symbol_completion_matches)
11129         (ada_add_global_exceptions): Update.
11130
11131 2019-01-17  Tom Tromey  <tom@tromey.com>
11132
11133         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11134         declare VEC.
11135         (solib_target_parse_libraries): Change return type.
11136         (library_list_start_segment, library_list_start_section)
11137         (library_list_end_library, library_list_start_library); Update.
11138         (solib_target_free_library_list): Remove.
11139         (solib_target_parse_libraries): Remove cleanup.  Change return
11140         type.
11141         (solib_target_current_sos): Update.
11142
11143 2019-01-17  Tom Tromey  <tromey@bapiya>
11144
11145         * valprint.c: Replace "the the" with "the".
11146         * symtab.c: Replace "the the" with "the".
11147         * solib.c: Replace "the the" with "the".
11148         * solib-dsbt.c: Replace "the the" with "the".
11149         * linespec.c: Replace "the the" with "the".
11150         * dwarf2loc.h: Replace "the the" with "the".
11151         * amd64-windows-tdep.c: Replace "the the" with "the".
11152         * aarch64-tdep.c: Replace "the the" with "the".
11153
11154 2019-01-16  Keith Seitz  <keiths@redhat.com>
11155
11156         PR gdb/23773
11157         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11158         <builder>: Rename to ..
11159         <m_builder>: ... this and make private.
11160         (dwarf2_cu::get_builder): New method.  Change all users of
11161         `builder' to use this method.
11162         (dwarf2_start_symtab): Move to ...
11163         (dwarf2_cu::start_symtab): ... here.  Update all callers
11164         (setup_type_unit_groups): Move to ...
11165         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11166         callers.
11167         (dwarf2_cu::reset_builder): New method.
11168         (process_full_compunit, process_full_type_unit): Use
11169         dwarf2_cu::reset_builder.
11170         (follow_die_offset): Record the ancestor CU if it is different
11171         from the followed DIE's CU.
11172         (follow_die_sig_1): Likewise.
11173
11174 2019-01-15  Tom Tromey  <tom@tromey.com>
11175
11176         * remote.c (class remote_state) <buf>: Now a char_vector.
11177         <buf_size>: Remove.
11178         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11179         parameter.
11180         (remote_target::getpkt_or_notif_sane_1)
11181         (remote_target::getpkt_sane)
11182         (remote_target::getpkt_or_notif_sane): Likewise.
11183         (class remote_target) <putpkt>: New overload.
11184         (remote_target::read_frame): Change type of "buf_p".  Remove
11185         sizeof_p parameter.
11186         (packet_ok): New overload.
11187         (packet_check_result): New overload.
11188         Update all uses.
11189
11190 2019-01-14  Tom Tromey  <tom@tromey.com>
11191
11192         * remote-notif.c (handle_notification, remote_notif_ack)
11193         (remote_notif_parse): Make "buf" const.
11194         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11195         const.
11196         (remote_notif_parse, remote_notif_ack, handle_notification):
11197         Likewise.
11198         * remote.c (remote_notif_stop_parse): Make "buf" const.
11199         (remote_target::remote_parse_stop_reply): Make "buf" const.
11200         (remote_notif_stop_ack): Make "buf" const.
11201
11202 2019-01-14  Tom Tromey  <tom@tromey.com>
11203
11204         * remote.c (remote_console_output): Make parameter const.
11205
11206 2019-01-14  Tom Tromey  <tom@tromey.com>
11207
11208         * target-debug.h (target_debug_print_signals): Constify.
11209         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11210         * procfs.c (procfs_target::pass_signals): Update.
11211         * linux-nat.c (linux_nat_target::pass_signals): Update.
11212         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11213         * target-delegates.c: Rebuild.
11214         * remote.c (remote_target::program_signals): Update.
11215         (remote_target::pass_signals): Update.
11216         * target.c (target_pass_signals): Constify argument.
11217         (target_program_signals): Likewise.
11218         * target.h (struct target_ops) <pass_signals, program_signals>:
11219         Constify argument.
11220         (target_pass_signals, target_program_signals): Constify argument.
11221
11222 2019-01-14  Tom Tromey  <tom@tromey.com>
11223
11224         PR tui/28819:
11225         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11226
11227 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11228
11229         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11230         field.
11231         * rs6000-tdep.c: Include reggroups.h.
11232         (IS_V_ALIAS_PSEUDOREG): Define.
11233         (rs6000_register_name): Return names for the "vX" aliases.
11234         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11235         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11236         aliases.  Call default_register_reggroup_p for all other
11237         pseudo-registers.
11238         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11239         New functions.
11240         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11241         Handle "vX" aliases.
11242         (v_alias_pseudo_register_collect): New function.
11243         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11244         (rs6000_gdbarch_init): Initialize "vX" aliases as
11245         pseudo-registers.  Restore registration of
11246         rs6000_pseudo_register_reggroup_p with
11247         set_tdesc_pseudo_register_reggroup_p.
11248
11249 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11250
11251         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11252         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11253         set_gdbarch_num_pseudo_regs.
11254
11255 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11256
11257         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11258         Remove arg prefixname, add do_set and do_show.
11259         Add member functions set_list and show_list.
11260         * cli/cli-style.c (class cli_style_option): Update accordingly.
11261         (style_set_list): Move to file scope.
11262         (style_show_list): Likewise.
11263         (set_style): Call help_list.
11264         (show_style): Call cmd_show_list.
11265         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11266         Update to use the new macro.
11267
11268 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11269
11270         * ada-lang.c (_initialize_ada_language): Expand the help text
11271         for the "catch exception" command.
11272
11273 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11274
11275         * symtab.c (matching_obj_sections): Initialize obj,
11276         declare it closer to its usage.
11277
11278 2019-01-10  Tom Tromey  <tom@tromey.com>
11279
11280         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11281         (basic_inf_threads_range): Remove.
11282         (inf_threads_range, inf_non_exited_threads_range)
11283         (safe_inf_threads_range): Use next_adapter.
11284
11285 2019-01-10  Keith Seitz  <keiths@redhat.com>
11286
11287         PR gdb/23712
11288         PR symtab/23010
11289         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11290         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11291
11292 2019-01-10  Keith Seitz  <keiths@redhat.com>
11293
11294         PR gdb/23712
11295         PR symtab/23010
11296         * dictionary.c (pending_to_vector): Remove.
11297         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11298         Remove _1 suffix, replacing functions of the same name.  Update
11299         all callers.
11300         (dict_create_hashed, dict_create_hashed_expandable)
11301         (dict_create_linear, dict_create_linear_expandable, dict_free)
11302         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11303         Make functions static.
11304
11305 2019-01-10  Keith Seitz  <keiths@redhat.com>
11306
11307         PR gdb/23712
11308         PR symtab/23010
11309         * dictionary.h (struct dictionary): Replace declaration with
11310         multidictionary.
11311         (dict_create_hashed, dict_create_hashed_expandable)
11312         (dict_create_linear, dict_create_linear_expandable)
11313         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11314         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11315         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11316         taking multidictionary argument.
11317         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11318         * block.h (struct block) <dict>: Change to multidictionary
11319         and rename `multidict'.
11320         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11321         symmisc.c: Update all dictionary references to multidictionary.
11322
11323 2019-01-10  Keith Seitz  <keiths@redhat.com>
11324
11325         PR gdb/23712
11326         PR symtab/23010
11327         * dictionary.c: Include unordered_map.
11328         (pending_to_vector): New function.
11329         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11330         Rewrite the non-"_1" functions to take vector instead
11331         of linked list.
11332         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11333         "new" _1 versions of the same name.
11334         (multidictionary): Define.
11335         (std::hash<enum language): New definition.
11336         (collate_pending_symbols_by_language, mdict_create_hashed)
11337         (mdict_create_hashed_expandable, mdict_create_linear)
11338         (mdict_create_linear_expandable, mdict_free)
11339         (find_language_dictionary, create_new_language_dictionary)
11340         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11341         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11342         (mdict_size, mdict_empty): New functions.
11343         * dictionary.h (mdict_iterator): Define.
11344
11345 2019-01-10  Pedro Alves  <palves@redhat.com>
11346
11347         * breakpoint.c (read_uploaded_action)
11348         (create_tracepoint_from_upload): Adjust to use
11349         gdb::unique_xmalloc_ptr.
11350         * ctf.c (ctf_write_uploaded_tp):
11351         (SET_ARRAY_FIELD): Use emplace_back.
11352         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11353         * tracefile-tfile.c (tfile_write_uploaded_tp):
11354         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11355         gdb::unique_xmalloc_ptr.
11356         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11357         at_string, cond_string, cmd_strings>: Replace char pointers
11358         with gdb::unique_xmalloc_ptr.
11359
11360 2019-01-10  Pedro Alves  <palves@redhat.com>
11361
11362         * solib-target.c (library_list_start_library): Don't xstrdup name.
11363
11364 2019-01-10  Pedro Alves  <palves@redhat.com>
11365
11366         * mdebugread.c (parse_partial_symbols): Use
11367         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11368
11369 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11370
11371         * linux-fork.c (scoped_switch_fork_info)
11372         <~scoped_switch_fork_info>: Fix incorrect variable name.
11373
11374 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11375
11376         * linux-fork.c (scoped_switch_fork_info)
11377         <scoped_switch_fork_info>: Make explicit.
11378         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11379
11380 2019-01-10  Tom Tromey  <tom@tromey.com>
11381
11382         * objfiles.h (objfile::reset_psymtabs): Update.
11383         * objfiles.c (objfile::objfile): Update.
11384         * psymtab.h (psymtab_storage::obstack): Update.
11385         (psymtab_storage::m_obstack): Use gdb::optional.
11386         (class psymtab_storage): Update comment.  Remove objfile
11387         parameter.
11388         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11389
11390 2019-01-10  Tom Tromey  <tom@tromey.com>
11391
11392         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11393         <free_psymtabs>: Now private.
11394         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11395         (allocate_psymtab): Use new method.
11396
11397 2019-01-10  Tom Tromey  <tom@tromey.com>
11398
11399         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11400         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11401         * mdebugread.c (parse_partial_symbols): Use
11402         allocate_dependencies.
11403         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11404         allocate_dependencies.
11405         (process_psymtab_comp_unit_reader)
11406         (build_type_psymtab_dependencies): Likewise.
11407         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11408
11409 2019-01-10  Tom Tromey  <tom@tromey.com>
11410
11411         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11412         PSYMBOL_SET_LANGUAGE.
11413         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11414
11415 2019-01-10  Tom Tromey  <tom@tromey.com>
11416
11417         * psymtab.h (psymtab_storage::obstack): New method.
11418         <m_obstack>: Rename from obstack; now private.
11419         * psymtab.c (psymtab_storage): Update.
11420         * dwarf2read.c (create_addrmap_from_index)
11421         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11422         Update.
11423
11424 2019-01-10  Tom Tromey  <tom@tromey.com>
11425
11426         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11427         * objfiles.h (objfile::reset_psymtabs): New method.
11428
11429 2019-01-10  Tom Tromey  <tom@tromey.com>
11430
11431         * symmisc.c (print_symbol_bcache_statistics): Update.
11432         (print_objfile_statistics): Update.
11433         * symfile.c (reread_symbols): Update.
11434         * psymtab.h (class psymtab_storage): New.
11435         * psymtab.c (psymtab_storage): New constructor.
11436         (~psymtab_storage): New destructor.
11437         (require_partial_symbols): Update.
11438         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11439         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11440         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11441         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11442         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11443         (start_psymtab_common, end_psymtab_common)
11444         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11445         (allocate_psymtab): Update.
11446         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11447         Update.
11448         (dump_psymtab_addrmap, maintenance_print_psymbols)
11449         (maintenance_check_psymtabs): Update.
11450         (class objfile_psymtabs): Move to objfiles.h.
11451         * psympriv.h (discard_psymtab): Now inline.
11452         (psymtab_discarder::psymtab_discarder): Update.
11453         (psymtab_discarder::~psymtab_discarder): Update.
11454         (ALL_OBJFILE_PSYMTABS): Rewrite.
11455         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11456         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11457         Remove fields.
11458         <partial_symtabs>: New field.
11459         (class objfile_psymtabs): Move from psymtab.h.  Update.
11460         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11461         psymbol_cache.
11462         (objfile::~objfile): Don't destroy psymbol_cache.
11463         * mdebugread.c (parse_partial_symbols): Update.
11464         * dwarf2read.c (create_addrmap_from_index)
11465         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11466         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11467         (add_partial_subprogram, dwarf2_ranges_read): Update.
11468         * dwarf-index-write.c (write_address_map)
11469         (write_one_signatured_type, recursively_write_psymbols)
11470         (class debug_names, class debug_names, write_psymtabs_to_index):
11471         Update.
11472
11473 2019-01-10  Tom Tromey  <tom@tromey.com>
11474
11475         * symtab.h (SYMBOL_SET_NAMES): Update.
11476         (symbol_set_names): Update.
11477         (MSYMBOL_SET_NAMES): Update.
11478         * symtab.c (symbol_set_names): Change argument to be an
11479         objfile_per_bfd_storage.
11480         * psymtab.c (add_psymbol_to_bcache): Update.
11481         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11482
11483 2019-01-10  Tom Tromey  <tom@tromey.com>
11484
11485         * symtab.c (create_demangled_names_hash): Change argument to be an
11486         objfile_per_bfd_storage.
11487         (symbol_set_names): Update.
11488
11489 2019-01-10  Tom Tromey  <tom@tromey.com>
11490
11491         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11492         init_psymbol_list.
11493         * psymtab.c (init_psymbol_list): Do nothing if already called.
11494         * psympriv.h (init_psymbol_list): Add comment.
11495         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11496         init_psymbol_list.
11497         * dbxread.c (dbx_symfile_read): Unconditionally call
11498         init_psymbol_list.
11499
11500 2019-01-10  Tom Tromey  <tom@tromey.com>
11501
11502         * xcoffread.c (scan_xcoff_symtab): Update.
11503         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11504         "where".
11505         * mdebugread.c (parse_partial_symbols)
11506         (handle_psymbol_enumerators): Update.
11507         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11508         * dbxread.c (read_dbx_symtab): Update.
11509         * psympriv.h (psymbol_placement): New enum.
11510         (add_psymbol_to_list): Update.
11511
11512 2019-01-10  Tom Tromey  <tom@tromey.com>
11513
11514         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11515         static_psymbols parameters.
11516         (scan_xcoff_symtab): Update.
11517         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11518         static_psymbols parameters.
11519         * psympriv.h (start_psymtab_common): Update.
11520         * mdebugread.c (parse_partial_symbols): Update.
11521         * dwarf2read.c (create_partial_symtab): Update.
11522         * dbxread.c (read_dbx_symtab): Update.
11523         (start_psymtab): Remove global_psymbols and static_psymbols
11524         parameters.
11525
11526 2019-01-10  Tom Tromey  <tom@tromey.com>
11527
11528         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11529         * psymtab.c (allocate_psymtab): Add comment.
11530         * psympriv.h (allocate_psymtab): Add comment.
11531         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11532         initializations.
11533         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11534
11535 2019-01-10  Tom Tromey  <tom@tromey.com>
11536
11537         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11538         Don't declare.
11539         * mipsread.c: Include mdebugread.h.
11540         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11541         Declare.
11542         * elfread.c: Include mdebugread.h.
11543
11544 2019-01-09  Tom Tromey  <tom@tromey.com>
11545
11546         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11547         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11548         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11549         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11550         (psym_lookup_symbol, psym_find_last_source_symtab)
11551         (psym_forget_cached_source_info, psym_print_stats)
11552         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11553         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11554         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11555         (psym_find_compunit_symtab_by_address)
11556         (maintenance_print_psymbols, maintenance_info_psymtabs)
11557         (maintenance_check_psymtabs): Use ranged for.
11558         * psymtab.h (class objfile_psymtabs): New.
11559         (require_partial_symbols): Return objfile_psymtabs.
11560         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11561
11562 2019-01-09  Tom Tromey  <tom@tromey.com>
11563
11564         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11565         (find_pc_mapped_section, list_overlays_command)
11566         (map_overlay_command, unmap_overlay_command)
11567         (simple_overlay_update): Use all_objfiles.
11568         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11569         * printcmd.c (info_symbol_command): Use all_objfiles.
11570         * objfiles.h (ALL_OBJSECTIONS): Remove.
11571         * maint.c (maintenance_translate_address): Use all_objfiles.
11572         * gcore.c (gcore_create_callback): Use all_objfiles.
11573         (objfile_find_memory_regions): Likewise.
11574
11575 2019-01-09  Tom Tromey  <tom@tromey.com>
11576
11577         * symtab.c (find_line_symtab, info_sources_command)
11578         (make_source_files_completion_list): Use objfile_compunits.
11579         * source.c (select_source_symtab): Use objfile_compunits.
11580         * objfiles.h (struct objfile): Update comment.
11581         (ALL_OBJFILES): Remove.
11582         (ALL_FILETABS): Remove.
11583         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11584         objfile_compunits.
11585
11586 2019-01-09  Tom Tromey  <tom@tromey.com>
11587
11588         * symmisc.c (print_objfile_statistics, dump_objfile)
11589         (maintenance_print_symbols): Use compunit_filetabs.
11590         * source.c (forget_cached_source_info_for_objfile): Use
11591         compunit_filetabs.
11592         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11593         (ALL_FILETABS): Use compunit_filetabs.
11594         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11595         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11596
11597 2019-01-09  Tom Tromey  <tom@tromey.com>
11598
11599         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11600         (compunit_filetabs): New.
11601         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11602         compunit_filetabs.
11603         (info_sources_command, make_source_files_completion_list): Remove
11604         declaration.
11605         * symmisc.c (print_objfile_statistics, dump_objfile)
11606         (maintenance_print_symbols): Remove declaration.
11607         (maintenance_info_symtabs): Use compunit_filetabs.
11608         (maintenance_info_line_tables): Likewise.
11609         * source.c (select_source_symtab): Change local variable name.
11610         (forget_cached_source_info_for_objfile): Remove declaration.
11611         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11612         * objfiles.c (objfile_relocate1): Remove declaration.
11613         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11614         declaration.
11615         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11616         * coffread.c (coff_symtab_read): Remove declaration.
11617         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11618         compunit_filetabs.
11619
11620 2019-01-09  Tom Tromey  <tom@tromey.com>
11621
11622         * symtab.c (lookup_objfile_from_block)
11623         (find_pc_sect_compunit_symtab, search_symbols)
11624         (default_collect_symbol_completion_matches_break_on): Use
11625         objfile_compunits.
11626         * objfiles.h (ALL_COMPUNITS): Remove.
11627         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11628         * cp-support.c (add_symbol_overload_list_qualified): Use
11629         objfile_compunits.
11630         * ada-lang.c (ada_collect_symbol_completion_matches)
11631         (ada_add_global_exceptions): Use objfile_compunits.
11632
11633 2019-01-09  Tom Tromey  <tom@tromey.com>
11634
11635         * source.c (select_source_symtab)
11636         (forget_cached_source_info_for_objfile): Remove declaration.
11637         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11638         declaration.
11639         * maint.c (count_symtabs_and_blocks): Remove declaration.
11640         * cp-support.c (add_symbol_overload_list_qualified): Remove
11641         declaration.
11642         * coffread.c (coff_symtab_read): Remove declaration.
11643         * symtab.c (lookup_symbol_in_objfile_symtabs)
11644         (basic_lookup_transparent_type_1): Use objfile_compunits.
11645         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11646         (info_sources_command, search_symbols)
11647         (default_collect_symbol_completion_matches_break_on)
11648         (make_source_files_completion_list): Remove declaration.
11649         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11650         (ada_collect_symbol_completion_matches)
11651         (ada_add_global_exceptions): Remove declaration.
11652         * linespec.c (iterate_over_all_matching_symtabs): Use
11653         objfile_compunits.
11654         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11655         (class objfile_compunits): New.
11656         (ALL_COMPUNITS): Use objfile_compunits.
11657         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11658         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11659         objfile_compunits.
11660         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11661
11662 2019-01-09  Tom Tromey  <tom@tromey.com>
11663
11664         * symtab.c (search_symbols)
11665         (default_collect_symbol_completion_matches_break_on): Use
11666         objfile_msymbols.
11667         * ada-lang.c (ada_lookup_simple_minsym)
11668         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11669         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11670         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11671         objfile_msymbols.
11672         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11673         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11674         * objc-lang.c (find_methods): Use objfile_msymbols.
11675         (info_selectors_command, info_classes_command): Likewise.
11676         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11677         * objfiles.h (class objfile_msymbols): New.
11678         (ALL_OBJFILE_MSYMBOLS): Remove.
11679         (ALL_MSYMBOLS): Remove.
11680
11681 2019-01-09  Tom Tromey  <tom@tromey.com>
11682
11683         * common/next-iterator.h (next_adapter): Add Iterator template
11684         parameter.
11685         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11686         (class all_objfiles_safe): New.
11687         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11688         * objfiles.c (put_objfile_before): Update comment.
11689         (add_separate_debug_objfile): Likewise.
11690         (free_all_objfiles): Use all_objfiles_safe.
11691         (objfile_purge_solibs): Likewise.
11692
11693 2019-01-09  Tom Tromey  <tom@tromey.com>
11694
11695         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11696         (expand_symtab_containing_pc, lookup_static_symbol)
11697         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11698         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11699         all_objfiles.
11700         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11701         * breakpoint.c (create_overlay_event_breakpoint)
11702         (create_longjmp_master_breakpoint)
11703         (create_std_terminate_master_breakpoint)
11704         (create_exception_master_breakpoint): Use all_objfiles.
11705         * linux-thread-db.c (try_thread_db_load_from_pdir)
11706         (has_libpthread): Use all_objfiles.
11707         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11708         * linespec.c (iterate_over_all_matching_symtabs)
11709         (search_minsyms_for_name): Use all_objfiles.
11710         * maint.c (maintenance_info_sections): Use all_objfiles.
11711         * main.c (captured_main_1): Use all_objfiles.
11712         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11713         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11714         * guile/scm-pretty-print.c
11715         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11716         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11717         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11718         (maintenance_print_msymbols): Use all_objfiles.
11719         * source.c (select_source_symtab): Use all_objfiles.
11720         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11721         * symfile.c (remove_symbol_file_command)
11722         (expand_symtabs_matching, map_symbol_filenames): Use
11723         all_objfiles.
11724         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11725         all_objfiles.
11726         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11727         * objc-lang.c (find_methods): Use all_objfiles.
11728         * objfiles.c (have_partial_symbols, have_full_symbols)
11729         (have_minimal_symbols, qsort_cmp)
11730         (default_iterate_over_objfiles_in_search_order): Use
11731         all_objfiles.
11732         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11733         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11734         (maintenance_check_psymtabs): Use all_objfiles.
11735         (ALL_PSYMTABS): Remove.
11736         * compile/compile-object-run.c (do_module_cleanup): Use
11737         all_objfiles.
11738         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11739         * cp-support.c (add_symbol_overload_list_qualified): Use
11740         all_objfiles.
11741         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11742         Use all_objfiles.
11743         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11744         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11745         all_objfiles.
11746         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11747         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11748         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11749         Uses all_objfiles.
11750         * solib.c (solib_read_symbols): Use all_objfiles
11751
11752 2019-01-09  Tom Tromey  <tom@tromey.com>
11753
11754         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11755         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11756         all_objfiles.
11757         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11758         * symmisc.c (print_symbol_bcache_statistics)
11759         (print_objfile_statistics, maintenance_print_objfiles)
11760         (maintenance_info_symtabs, maintenance_check_symtabs)
11761         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11762         all_objfiles.
11763         * source.c (forget_cached_source_info): Use all_objfiles.
11764         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11765         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11766         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11767         * objfiles.c (update_section_map): Use all_objfiles.
11768         (shared_objfile_contains_address_p): Likewise.
11769         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11770         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11771
11772 2019-01-09  Tom Tromey  <tom@tromey.com>
11773
11774         * common/next-iterator.h: New file.
11775         * objfiles.h (class all_objfiles): New.
11776         (struct objfile_iterator): New.
11777
11778 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11779
11780         * NEWS: Move the description of the changed "frame", "select-frame",
11781          and "info frame" commands to the Changed commands section.
11782
11783 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11784
11785         * gdbtypes.c (check_stub_method_group): Remove handling of old
11786         mangling schemes.
11787         * linespec.c (find_methods): Likewise.
11788         * stabsread.c (read_member_functions): Likewise.
11789         * valops.c (search_struct_method): Likewise.
11790         (value_struct_elt_for_reference): Likewise.
11791         * NEWS: Mention this change.
11792
11793 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11794
11795         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11796         print_source_lines.
11797         * source.c (print_source_lines_base): Update line number check.
11798         (print_source_lines): New function.
11799         (source_lines_range::source_lines_range): New function.
11800         * source.h (class source_lines_range): New class.
11801         (print_source_lines): New declaration.
11802
11803 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11804
11805         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11806
11807 2019-01-08  Tom Tromey  <tom@tromey.com>
11808             Simon Marchi  <simon.marchi@ericsson.com>
11809
11810         PR gdb/24060
11811         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11812         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11813         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11814         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11815         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11816         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11817
11818 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11819
11820         * source.c (select_source_symtab): Move header comment to
11821         declaration in source.h.
11822         (forget_cached_source_info_for_objfile): Likewise.
11823         (forget_cached_source_info): Likewise.
11824         (identify_source_line): Likewise.
11825         * source.h (identify_source_line): Move declaration from symtab.h
11826         and add comment from source.c
11827         (print_source_lines): Likewise.
11828         (forget_cached_source_info_for_objfile): Likewise.
11829         (forget_cached_source_info): Likewise.
11830         (select_source_symtab): Likewise.
11831         (enum print_source_lines_flag): Move definition from symtab.h.
11832         * symtab.h (identify_source_line): Move declaration to source.h.
11833         (print_source_lines): Likewise.
11834         (forget_cached_source_info_for_objfile): Likewise.
11835         (forget_cached_source_info): Likewise.
11836         (select_source_symtab): Likewise.
11837         (enum print_source_lines_flag): Move definition to source.h.
11838         * tui/tui-hooks.c: Add 'source.h' include.
11839
11840 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11841
11842         * source.c (print_source_lines_base): Handle requests to print
11843         reverse line number sequences, and guard against empty lines
11844         string.
11845
11846 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11847
11848         * source.c (print_source_lines_base): Fix skip of '\r' if next
11849         character is '\n'.
11850
11851 2019-01-06  Tom Tromey  <tom@tromey.com>
11852
11853         * c-exp.y (struct c_parse_state) <macro_original_text,
11854         expansion_obstack>: New member.
11855         (macro_original_text, expansion_obstack): Remove globals.
11856         (scan_macro_expansion, scanning_macro_expansion)
11857         (finished_macro_expansion): Update.
11858         (scan_macro_cleanup): Remove.
11859         (yylex, c_parse): Update.
11860
11861 2019-01-06  Tom Tromey  <tom@tromey.com>
11862
11863         * c-exp.y (struct c_parse_state) <strings>: New member.
11864         (operator_stoken): Update.
11865
11866 2019-01-06  Tom Tromey  <tom@tromey.com>
11867
11868         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11869         (union type_stack_elt) <typelist_val>: Now a pointer to
11870         std::vector.
11871         (type_stack_cleanup): Don't declare.
11872         (push_typelist): Update.
11873         * parse.c (pop_typelist): Return a std::vector.
11874         (push_typelist): Take a std::vector.
11875         (follow_types): Update.  Do not free args.
11876         (type_stack_cleanup): Remove.
11877         * c-exp.y (struct c_parse_state): New.
11878         (cpstate): New global.
11879         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11880         (nonempty_typelist): Update.
11881         (func_mod): Create a new vector.
11882         (c_parse): Create a c_parse_state.
11883         (check_parameter_typelist): Do not delete params.
11884         (function_method): Update.  Do not delete type_list.
11885
11886 2019-01-06  Tom Tromey  <tom@tromey.com>
11887
11888         PR gdb/28155:
11889         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11890         check_typedef.
11891         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11892         (print_return_value): Likewise.
11893
11894 2019-01-05  Tom Tromey  <tom@tromey.com>
11895
11896         * contrib/cleanup_check.py: Remove.
11897         * contrib/gcc-with-excheck: Remove.
11898         * contrib/exsummary.py: Remove.
11899         * contrib/excheck.py: Remove.
11900
11901 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11902
11903         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11904         NULL. Initialize tpprev to NULL instead of assigning it
11905         to NULL on the next statement.
11906         * windows-nat.c (windows_delete_thread): Remove check for
11907         main_thread_id before printing thread exit notifications.
11908         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11909         Remove thread ID check against main_thread_id.
11910         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11911         windows_delete_thread.
11912         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11913
11914 2019-01-04  Tom Tromey  <tom@tromey.com>
11915
11916         * compile/compile.c (_initialize_compile): Use upper case for
11917         metasyntactic variables.
11918         * symmisc.c (_initialize_symmisc): Use upper case for
11919         metasyntactic variables.
11920         * psymtab.c (_initialize_psymtab): Use upper case for
11921         metasyntactic variables.
11922         * demangle.c (demangle_command): Use upper case for metasyntactic
11923         variables.
11924         (_initialize_demangler): Likewise.
11925         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11926         variables.
11927
11928 2019-01-03  Tom Tromey  <tom@tromey.com>
11929
11930         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11931
11932 2019-01-03  Tom Tromey  <tom@tromey.com>
11933
11934         * python/py-symtab.c (salpy_str): Update.
11935         (struct salpy_sal_object) <symtab>: Now a PyObject.
11936         (salpy_dealloc): Update.
11937         (del_objfile_sal): Use gdbpy_ref.
11938
11939 2019-01-03  Tom Tromey  <tom@tromey.com>
11940
11941         * python/py-type.c (convert_field): Use new_reference.  Return
11942         gdbpy_ref.
11943         (make_fielditem): Return gdbpy_ref.
11944         (typy_fields): Update.
11945         (typy_getitem): Update.
11946         (field_name): Return gdbpy_ref.  Use new_reference.
11947         (typy_iterator_iternext): Update.
11948
11949 2019-01-03  Tom Tromey  <tom@tromey.com>
11950
11951         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11952
11953 2019-01-03  Tom Tromey  <tom@tromey.com>
11954
11955         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11956         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11957         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11958         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11959         (pspy_set_type_printers): Likewise.
11960         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11961         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11962         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11963         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11964         (objfpy_set_type_printers): Likewise.
11965
11966 2019-01-03  Tom Tromey  <tom@tromey.com>
11967
11968         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11969         (gdbpy_print_stack): Use gdbpy_err_fetch.
11970         * python/python-internal.h (class gdbpy_err_fetch): New class.
11971         (class gdbpy_enter) <m_error_type, m_error_value,
11972         m_error_traceback>: Remove.
11973         <m_error>: New member.
11974         (gdbpy_exception_to_string): Don't declare.
11975         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11976         * python/py-value.c (convert_value_from_python): Use
11977         gdbpy_err_fetch.
11978         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11979         gdbpy_exception_to_string.
11980         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11981         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11982         gdbpy_err_fetch.
11983
11984 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11985
11986         * linux-nat.c (delete_lwp_cleanup): Delete.
11987         (struct lwp_deleter): New struct.
11988         (lwp_info_up): New typedef.
11989         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11990         lwp_info_up.
11991
11992 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11993
11994         * linux-fork.c (class scoped_switch_fork_info): New class.
11995         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11996
11997 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11998
11999         * valops.c (find_overload_match): Remove use of null_cleanup, and
12000         calls to do_cleanups.
12001
12002 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12003
12004         * compile/compile-cplus-types.c
12005         (compile_cplus_instance::decl_name): Handle changes to
12006         cp_func_name.
12007         * cp-support.c (cp_func_name): Update header comment, update
12008         return type.
12009         * cp-support.h (cp_func_name): Update return type in declaration.
12010         * valops.c (find_overload_match): Move temp_func local to top
12011         level of function and change its type.  Use temp_func to hold and
12012         delete temporary string obtained from cp_func_name.
12013
12014 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12015
12016         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12017         gdb::char_vector, remove cleanup, and update uses of `msg`.
12018
12019 2019-01-03  Jim Wilson  <jimw@sifive.com>
12020
12021         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12022
12023 2019-01-02  Tom Tromey  <tom@tromey.com>
12024
12025         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12026         (tdesc_parse_xml): Remove cleanups.
12027         * target-descriptions.h (make_cleanup_free_target_description):
12028         Don't declare.
12029         (target_desc_deleter): New struct.
12030         (target_desc_up): New typedef.
12031         * target-descriptions.c (target_desc_deleter::operator()): Rename
12032         from free_target_description.
12033         (make_cleanup_free_target_description): Remove.
12034
12035 2019-01-02  Tom Tromey  <tom@tromey.com>
12036
12037         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12038         constructor, destructor.
12039         (linespec_parser): Remove typedef.
12040         (~linespec_parser): Rename from linespec_parser_delete.
12041         (linespec_lex_to_end, linespec_complete_label)
12042         (linespec_complete): Update.
12043         (decode_line_full): Remove cleanups.
12044         (decode_line_1): Update.
12045
12046 2019-01-02  Tom Tromey  <tom@tromey.com>
12047
12048         * python/python-internal.h (inferior_to_inferior_object): Change
12049         return type.
12050         * python/py-exitedevent.c (create_exited_event_object): Update.
12051         * python/py-inferior.c (inferior_to_inferior_object): Return
12052         gdbpy_ref.
12053         (python_new_inferior, python_inferior_deleted)
12054         (thread_to_thread_object, delete_thread_object)
12055         (build_inferior_list, gdbpy_selected_inferior): Update.
12056         * python/py-infthread.c (create_thread_object): Update.  Also fail
12057         if inferior_to_inferior_object fails.
12058
12059 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12060
12061         * inferior.h (class inferior) <displaced_step_state>: New field.
12062         * infrun.h (struct displaced_step_state): Move here from
12063         infrun.c.  Initialize fields, add constructor.
12064         <inf>: Remove field.
12065         <reset>: New method.
12066         * infrun.c (struct displaced_step_inferior_state): Move to
12067         infrun.h.
12068         (displaced_step_inferior_states): Remove.
12069         (get_displaced_stepping_state): Adust.
12070         (displaced_step_in_progress_any_inferior): Adjust.
12071         (displaced_step_in_progress_thread): Adjust.
12072         (displaced_step_in_progress): Adjust.
12073         (add_displaced_stepping_state): Remove.
12074         (get_displaced_step_closure_by_addr): Adjust.
12075         (remove_displaced_stepping_state): Remove.
12076         (infrun_inferior_exit): Call displaced_step_state.reset.
12077         (use_displaced_stepping): Don't check for NULL.
12078         (displaced_step_prepare_throw): Call
12079         get_displaced_stepping_state.
12080         (displaced_step_fixup): Don't check for NULL.
12081         (prepare_for_detach): Don't check for NULL.
12082
12083 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12084
12085         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12086          in case of call that did not complete.
12087
12088 2019-01-02  Andrey Utkin  <autkin@undo.io>
12089
12090         * symfile.c (find_separate_debug_file): Fix search of debug files for
12091         remote debuggee.
12092
12093 2019-01-02  Tom Tromey  <tom@tromey.com>
12094
12095         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12096         indentation.
12097         * python/py-frame.c (frapy_older): Remove cast.
12098         (frapy_newer): Likewise.
12099         * python/py-breakpoint.c (local_setattro): Remove cast.
12100         * python/py-arch.c (archpy_name): Remove local variable.
12101         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12102
12103 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12104
12105         * unittests/basic_string_view/element_access/char/empty.cc:
12106         Fix year range in copyright header.
12107
12108 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12109
12110         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12111         Delete.
12112         <operator==>: Update with for removed field.
12113         <hash>: Likewise.
12114         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12115         <isa_features>: ...this.
12116         <abi_features>: New field.
12117         (riscv_isa_flen): Update comment.
12118         (riscv_abi_xlen): New declaration.
12119         (riscv_abi_flen): New declaration.
12120         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12121         isa_features.
12122         (riscv_abi_xlen): New function.
12123         (riscv_isa_flen): Update to get answer from isa_features.
12124         (riscv_abi_flen): New function.
12125         (riscv_has_fp_abi): Update to get answer from abi_features.
12126         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12127         xlen and flen.
12128         (riscv_call_info) <xlen, flen>: Update comment.
12129         (riscv_call_arg_struct): Remove invalid assertions
12130         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12131         is removed.
12132         (riscv_gdbarch_init): Gather isa features and abi features
12133         separately, ensure both match on the gdbarch when reusing an old
12134         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12135         a target with 64-bit float hardware.
12136
12137 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12138
12139         * source.c (search_command_helper): Stop reverse search
12140         when line 1 has been searched.
12141
12142 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12143
12144         * record-full.c (record_full_base_target::close): Rewrite
12145         record_full_core_buf_list free logic.
12146
12147 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12148
12149         * break-catch-syscall.c (print_one_catch_syscall): xfree
12150         the last text.
12151
12152 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12153
12154         * top.c (print_gdb_version): Update Copyright year in version
12155         message.
12156
12157 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12158
12159         Update copyright year range in all GDB files.
12160
12161 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12162
12163         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12164
12165 For older changes see ChangeLog-2018.
12166 \f
12167 Local Variables:
12168 mode: change-log
12169 left-margin: 8
12170 fill-column: 74
12171 version-control: never
12172 coding: utf-8
12173 End:
12174