gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
   4         allocate_on_obstack.
   5         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
   6         (get_dwarf2_per_objfile): Update.
   7         (set_dwarf2_per_objfile): Remove.
   8         (dwarf2_has_info, dwarf2_get_section_info): Update.
   9         (dwarf2_free_objfile): Remove.
  10         (_initialize_dwarf2_read): Update.
  11
  12 2019-05-08  Tom Tromey  <tom@tromey.com>
  13
  14         * auto-load.c (struct auto_load_pspace_info): Add destructor and
  15         initializers.
  16         <unsupported_script_warning_printed,
  17         script_not_found_warning_printed>: Now bool.
  18         (auto_load_pspace_data): Change type.
  19         (~auto_load_pspace_info): Rename from
  20         auto_load_pspace_data_cleanup.
  21         (get_auto_load_pspace_data, init_loaded_scripts_info)
  22         (clear_section_scripts, maybe_print_unsupported_script_warning)
  23         (maybe_print_script_not_found_warning, _initialize_auto_load):
  24         Update.
  25
  26 2019-05-08  Tom Tromey  <tom@tromey.com>
  27
  28         * objfiles.c (objfile_pspace_info): Add destructor and
  29         initializers.
  30         (objfiles_pspace_data): Change type.
  31         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
  32         (get_objfile_pspace_data): Update.
  33         (objfiles_bfd_data): Change type.
  34         (get_objfile_bfd_data): Update.
  35         (objfile_bfd_data_free, _initialize_objfiles): Remove.
  36
  37 2019-05-08  Tom Tromey  <tom@tromey.com>
  38
  39         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
  40         Change type.
  41         (get_catch_syscall_inferior_data): Update.
  42         (catch_syscall_inferior_data_cleanup): Remove.
  43         (_initialize_break_catch_syscall): Update.
  44
  45 2019-05-08  Tom Tromey  <tom@tromey.com>
  46
  47         * inflow.c (struct terminal_info): Add destructor and
  48         initializers.
  49         (inflow_inferior_data): Change type.
  50         (~terminal_info): Rename from inflow_inferior_data_cleanup.
  51         (get_inflow_inferior_data, inflow_inferior_exit)
  52         (swap_terminal_info, _initialize_inflow): Update.
  53
  54 2019-05-08  Tom Tromey  <tom@tromey.com>
  55
  56         * target-dcache.c (target_dcache_cleanup): Remove.
  57         (target_dcache_aspace_key): Change type.
  58         (target_dcache_init_p, target_dcache_invalidate)
  59         (target_dcache_get, target_dcache_get_or_init)
  60         (_initialize_target_dcache): Update.
  61         * dcache.h (struct dcache_deleter): New.
  62
  63 2019-05-08  Tom Tromey  <tom@tromey.com>
  64
  65         * symtab.c (struct symbol_cache): Add destructor and
  66         initializers.
  67         (symbol_cache_key): Move.  Change type.
  68         (make_symbol_cache, free_symbol_cache): Remove.
  69         (get_symbol_cache): Update.
  70         (symbol_cache_cleanup): Remove.
  71         (ALL_PSPACES, symbol_cache_flush)
  72         (maintenance_print_symbol_cache)
  73         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
  74         Update.
  75
  76 2019-05-08  Tom Tromey  <tom@tromey.com>
  77
  78         * symtab.c (struct main_info): Add destructor and initializers.
  79         (main_progspace_key): Move.  Change type.
  80         (get_main_info): Update.
  81         (main_info_cleanup): Remove.
  82         (_initialize_symtab): Update.
  83
  84 2019-05-08  Tom Tromey  <tom@tromey.com>
  85
  86         * registry.h (DECLARE_REGISTRY): Define the _key class.
  87
  88 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
  89
  90         * NEWS: Merge two 'New commands' sections.
  91
  92 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
  93
  94         * ada-valprint.c (ada_val_print_gnat_array): Remove language
  95         parameter and use Ada language definition instead.
  96         (ada_val_print_ptr): Remove unused language parameter.
  97         (ada_val_print_num): Remove language parameter and use Ada language
  98         definition instead.
  99         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 100         parameter.
 101         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 102         parameter and use Ada language definition instead.
 103         (ada_val_print_1): Update all ada_val_print_xxx calls.
 104         Remove language parameter.
 105         (ada_val_print): Update ada_val_print_1 call.
 106
 107 2019-05-08  Tom Tromey  <tromey@adacore.com>
 108
 109         * remote.c (remote_hw_watchpoint_limit)
 110         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 111         Now static.
 112
 113 2019-05-08  Tom Tromey  <tromey@adacore.com>
 114
 115         * maint.c (_initialize_maint_cmds): Move initialization code to
 116         remote.c.
 117         (watchdog, show_watchdog): Move to remote.c.
 118         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 119         "watchdog" static.
 120         (_initialize_remote): Move initialization code from maint.c.
 121         * defs.h (watchdog): Don't declare.
 122
 123 2019-05-08  Tom Tromey  <tromey@adacore.com>
 124
 125         * tui/tui-interp.c: Include main.h.
 126         * interps.c: Include main.h.
 127         * main.h (interpreter_p): Declare.
 128         * defs.h (interpreter_p): Don't declare.
 129
 130 2019-05-08  Tom Tromey  <tromey@adacore.com>
 131
 132         * dwarf2loc.c: Include dwarf2read.h.
 133         * defs.h (read_unsigned_leb128): Don't declare.
 134         * dwarf2read.h (read_unsigned_leb128): Declare.
 135
 136 2019-05-08  Tom Tromey  <tromey@adacore.com>
 137
 138         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 139         method.
 140
 141 2019-05-08  Tom Tromey  <tromey@adacore.com>
 142
 143         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 144         when no wrap column is set.
 145
 146 2019-05-08  Tom Tromey  <tromey@adacore.com>
 147
 148         * c-lang.c (c_get_string): Handle non-C-style arrays.
 149
 150 2019-05-08  Tom Tromey  <tromey@adacore.com>
 151
 152         * typeprint.c (print_offset_data::update): Print the bit offset,
 153         not the number of bits remaining.
 154
 155 2019-05-08  Tom Tromey  <tromey@adacore.com>
 156
 157         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 158         padding at end of comment.
 159
 160 2019-05-08  Tom Tromey  <tromey@adacore.com>
 161
 162         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 163         Compare main types.
 164
 165 2019-05-06  Tom Tromey  <tom@tromey.com>
 166
 167         * common/scoped_mmap.c: Include common-defs.h.
 168         * common/scoped_mmap.h: Don't include config.h.
 169
 170 2019-05-04  Tom Tromey  <tom@tromey.com>
 171
 172         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 173         (struct aarch64_call_info): Add initializers.
 174         <si>: Now a std::vector.
 175         (pass_on_stack, aarch64_push_dummy_call): Update.
 176
 177 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 178             Tom Tromey  <tom@tromey.com>
 179
 180         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 181         (ppc_threads): Now a std::vector.  Now static.
 182         (hwdebug_find_thread_points_by_tid)
 183         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 184         Update.
 185
 186 2019-05-04  Tom Tromey  <tom@tromey.com>
 187
 188         * arc-tdep.c (arc_tdesc_init): Return bool.
 189
 190 2019-05-04  Tom Tromey  <tom@tromey.com>
 191
 192         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 193         Use gdb_assert_not_reached.
 194
 195 2019-05-04  Tom Tromey  <tom@tromey.com>
 196
 197         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 198         "false".
 199
 200 2019-05-04  Tom Tromey  <tom@tromey.com>
 201
 202         * arc-tdep.c (arc_tdesc_init): Use bool.
 203
 204 2019-05-04  Tom Tromey  <tom@tromey.com>
 205
 206         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 207
 208 2019-05-04  Tom Tromey  <tom@tromey.com>
 209
 210         * cli/cli-cmds.c (valid_command_p): Return bool.
 211
 212 2019-05-04  Tom Tromey  <tom@tromey.com>
 213
 214         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 215         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 216
 217 2019-05-04  Raul Tambre  <raul@tambre.ee>
 218
 219         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 220         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 221         operator for comparison.
 222
 223 2019-05-04  Tom Tromey  <tom@tromey.com>
 224
 225         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 226         (lookup_partial_symbol, print_partial_symbols)
 227         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 228         (psymbol_compare): Update.
 229         (add_psymbol_to_bcache): Clear the entire psymbol.
 230         (maintenance_check_psymtabs): Update.
 231         * psympriv.h (struct partial_symbol): Don't derive from
 232         general_symbol_info.
 233         <obj_section, unrelocated_address, address,
 234         set_unrelocated_address>: Update.
 235         <ginfo>: New member.
 236         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 237         (debug_names::write_psymbols): Update.
 238
 239 2019-05-04  Tom de Vries  <tdevries@suse.de>
 240
 241         * contrib/cc-with-tweaks.sh: Support -n arg.
 242
 243 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 244
 245         * corelow.c (core_target::detach): Ensure frame cache and
 246         register caches are cleared.
 247         inferior.c (exit_inferior_1): Likewise.
 248
 249 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 250             Tom Tromey  <tom@tromey.com>
 251
 252         * dictionary.c (collate_pending_symbols_by_language): Remove
 253         "struct" from foreach.
 254         * symtab.c (lookup_global_symbol_from_objfile)
 255         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 256         foreach.
 257         * ser-tcp.c (net_open): Remove "struct" from foreach.
 258         * objfiles.c (objfile_relocate, objfile_rebase)
 259         (objfile_has_symbols): Remove "struct" from foreach.
 260         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 261         from foreach.
 262         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 263         foreach.
 264         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 265         "struct" from foreach.
 266         * ada-lang.c (create_excep_cond_exprs)
 267         (ada_exception_catchpoint_cond_string): Remove "struct" from
 268         foreach.
 269
 270 2019-05-03  Tom Tromey  <tromey@adacore.com>
 271
 272         * ada-exp.y (convert_char_literal): Check suffix of each
 273         enumerator.
 274
 275 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 276
 277         PR ada/21406:
 278         * ada-exp.y (yywrap): Don't define.
 279         * ada-lex.l (%option): Add noyywrap
 280         (yywrap): Remove.
 281
 282 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 283
 284         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 285         _WIN32_WINNT to the XP level, unless already defined to a higher
 286         level.
 287
 288         * unittests/parse-connection-spec-selftests.c:
 289         * ser-tcp.c:
 290         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 291         override.
 292
 293         * symfile.c (find_separate_debug_file): Remove colon from the
 294         drive spec of DOS/Windows file names of the target, so that the
 295         file name produced from DEBUGDIR and the target's directory will
 296         be valid on DOS/Windows systems.
 297
 298 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 299
 300         * rust-lang.c (val_print_struct): Handle printing structures
 301         containing strings.
 302
 303 2019-05-02  Tom Tromey  <tromey@adacore.com>
 304
 305         * valarith.c (_initialize_valarith): Remove.
 306
 307 2019-05-01  Tom Tromey  <tromey@adacore.com>
 308
 309         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 310         bitfields.
 311
 312 2019-05-01  Tom Tromey  <tromey@adacore.com>
 313
 314         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 315         for big-endian copies.
 316
 317 2019-04-30  Ali Tamur  <tamur@google.com>
 318         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 319         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 320         (read_3_bytes): New function.
 321
 322 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 323
 324         * windows-nat.c (main_thread_id): Delete.
 325         (handle_output_debug_string): Replace main_thread_id by
 326         current_event.dwThreadId.
 327         (fake_create_process): Likewise.
 328         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 329         Do not set main_thread_id.
 330         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 331         current_event.dwThreadId.
 332         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 333
 334 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 335
 336         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 337         Use current_event.dwThreadId instead of main_thread_id.
 338
 339 2019-04-30  Tom Tromey  <tromey@adacore.com>
 340
 341         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 342         (create_excep_cond_exprs): Iterate over program spaces.
 343         (ada_exception_catchpoint_cond_string): Examine all minimal
 344         symbols for exception types.
 345
 346 2019-04-30  Tom Tromey  <tromey@adacore.com>
 347
 348         PR c++/24470:
 349         * dwarf2read.c (process_structure_scope): Handle case where type
 350         has template parameters but no symbol was created.
 351
 352 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 353             Chris January  <chris.january@arm.com>
 354
 355         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 356         qualifier.
 357         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 358
 359 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 360
 361         * f-typeprint.c (f_print_type): Update rules for printing
 362         whitespace.
 363         (f_type_print_varspec_suffix): Likewise.
 364
 365 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 366             Chris January  <chris.january@arm.com>
 367
 368         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 369         function arguments.
 370
 371 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 372
 373         * f-lang.c (build_fortran_types): Change name of void type to
 374         lower case.
 375         * f-typeprint.c (f_type_print_base): Print the name of the void
 376         type, rather than a fixed string.
 377         * f-valprint.c (f_decorations): Use lower case void string.
 378
 379 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 380             Chris January  <chris.january@arm.com>
 381
 382         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 383         types for Fortran.
 384
 385 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 386             Chris January  <chris.january@arm.com>
 387             David Lecomber  <david.lecomber@arm.com>
 388
 389         * f-exp.y (BINOP_INTRINSIC): New token.
 390         (exp): New parser rule handling BINOP_INTRINSIC.
 391         (f77_keywords): Add new builtin procedures.
 392         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 393         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 394         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 395         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 396         (print_unop_subexp_f): New function.
 397         (print_binop_subexp_f): New function.
 398         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 399         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 400         (dump_subexp_body_f): Likewise.
 401         (operator_check_f): Likewise.
 402         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 403         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 404
 405 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 406
 407         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 408         UNOP_KIND.
 409         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 410         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 411         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 412         (operator_length_f): New fuction.
 413         (print_subexp_f): New function.
 414         (op_name_f): New function.
 415         (dump_subexp_body_f): New function.
 416         (operator_check_f): New function.
 417         (exp_descriptor_f): Replace standard expression handling functions
 418         with new functions.
 419         * gdb/fortran-operator.def: New file.
 420         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 421         * gdb/std-operator.def: Remove UNOP_KIND.
 422
 423 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 424
 425         * std-operator.def: Remove unbalanced, stray double quote
 426         character.
 427
 428 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 429             Chris January  <chris.january@arm.com>
 430             Daniel Everett  <daniel.everett@arm.com>
 431             Nick Forrington  <nick.forrington@arm.com>
 432             Richard Bunt  <richard.bunt@arm.com>
 433
 434         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 435         of depth when printing anonymous structs or unions.
 436         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 437         Don't print either the top-level value, or the children if the
 438         max-depth is exceeded.
 439         (ppscm_print_children): When printing the key of a map, allow one
 440         extra level of depth.
 441         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 442         print either the top-level value, or the children if the max-depth
 443         is exceeded.
 444         (print_children): When printing the key of a map, allow one extra
 445         level of depth.
 446         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 447         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 448         (user_print_options): Initialise max_depth field.
 449         (val_print_scalar_or_string_type_p): New function.
 450         (val_print): Check to see if the max depth has been reached.
 451         (val_print_check_max_depth): Define new function.
 452         (show_print_max_depth): New function.
 453         (_initialize_valprint): Add 'print max-depth' option.
 454         * valprint.h (struct value_print_options) <max_depth>: New field.
 455         (val_print_check_max_depth): Declare new function.
 456         * NEWS: Document new feature.
 457
 458 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 459
 460         * ada-lang.c (ada_language_defn): Initialise new field.
 461         * c-lang.c (c_is_string_type_p): New function.
 462         (c_language_defn): Initialise new field.
 463         (cplus_language_defn): Initialise new field.
 464         (asm_language_defn): Initialise new field.
 465         (minimal_language_defn): Initialise new field.
 466         * c-lang.h (c_is_string_type_p): Declare new function.
 467         * d-lang.c (d_language_defn): Initialise new field.
 468         * f-lang.c (f_is_string_type_p): New function.
 469         (f_language_defn): Initialise new field.
 470         * go-lang.c (go_is_string_type_p): New function.
 471         (go_language_defn): Initialise new field.
 472         * language.c (default_is_string_type_p): New function.
 473         (unknown_language_defn): Initialise new field.
 474         (auto_language_defn): Initialise new field.
 475         * language.h (struct language_defn) <la_is_string_type_p>: New
 476         member variable.
 477         (default_is_string_type_p): Declare new function.
 478         * m2-lang.c (m2_language_defn): Initialise new field.
 479         * objc-lang.c (objc_language_defn): Initialise new field.
 480         * opencl-lang.c (opencl_language_defn): Initialise new field.
 481         * p-lang.c (pascal_is_string_type_p): New function.
 482         (pascal_language_defn): Initialise new field.
 483         * rust-lang.c (rust_is_string_type_p): New function.
 484         (rust_language_defn): Initialise new field.
 485
 486 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 487
 488         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 489         New field.
 490         * ada-lang.c (ada_language_defn): Initialise new field.
 491         * c-lang.c (c_language_defn): Likewise.
 492         (cplus_language_defn): Likewise.
 493         (asm_language_defn): Likewise.
 494         (minimal_language_defn): Likewise.
 495         * d-lang.c (d_language_defn): Likewise.
 496         * f-lang.c (f_language_defn): Likewise.
 497         * go-lang.c (go_language_defn): Likewise.
 498         * language.c (unknown_language_defn): Likewise.
 499         (auto_language_defn): Likewise.
 500         * m2-lang.c (m2_language_defn): Likewise.
 501         * objc-lang.c (objc_language_defn): Likewise.
 502         * opencl-lang.c (opencl_language_defn): Likewise.
 503         * p-lang.c (pascal_language_defn): Likewise.
 504         * rust-lang.c (rust_language_defn): Likewise.
 505
 506 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 507
 508         * ada-lang.c (ada_is_character_type): Change return type to bool.
 509         (ada_is_string_type): Likewise.
 510         * ada-lang.h (ada_is_character_type): Update declaration
 511         (ada_is_string_type): Likewise.
 512
 513 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 514
 515         Support style in 'frame|thread apply'
 516
 517         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 518         * record.c (record_start, record_stop): Update callers of
 519         execute_command_to_string with false.
 520         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 521         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 522         methods.
 523         (class string_file): New constructor with term_out parameter.
 524         Override methods term_out and can_emit_style_escape.  New member
 525         term_out.
 526         (class stdio_file): Override can_emit_style_escape.
 527         (class tee_file): Override term_out and can_emit_style_escape.
 528         * utils.h (can_emit_style_escape): Remove.
 529         * utils.c (can_emit_style_escape): Likewise.
 530         Update all callers of can_emit_style_escape (SOMESTREAM) to
 531         SOMESTREAM->can_emit_style_escape.
 532         * source-cache.c (source_cache::get_source_lines): Likewise.
 533         * stack.c (frame_apply_command_count): Call execute_command_to_string
 534         passing the term_out characteristic of the current gdb_stdout.
 535         * thread.c (thr_try_catch_cmd): Likewise.
 536         * top.c (execute_command_to_string): pass term_out parameter
 537         to construct the string_file for the command output.
 538         * ui-file.c (term_cli_styling): New function (most code moved
 539         from utils.c can_emit_style_escape).
 540         (string_file::string_file, string_file::can_emit_style_escape,
 541         stdio_file::can_emit_style_escape, tee_file::term_out,
 542         tee_file::can_emit_style_escape): New functions.
 543
 544 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 545
 546         * NEWS: Mention the new set|show may-call-functions.
 547         * infcall.c (may_call_functions_p): New variable.
 548         (show_may_call_functions_p): New function.
 549         (call_function_by_hand_dummy): Throws an error if not
 550         may-call-functions.
 551         (_initialize_infcall): Call add_setshow_boolean_cmd for
 552         may-call-functions.
 553
 554 2019-04-25  Keith Seitz  <keiths@redhat.com>
 555
 556         PR c++/24367
 557         * cp-support.c (inspect_type): Don't attempt substitutions
 558         of symbol with the same name.
 559
 560 2019-04-25  Tom Tromey  <tromey@adacore.com>
 561
 562         PR gdb/24475:
 563         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 564         static.
 565
 566 2019-04-25  Tom Tromey  <tromey@adacore.com>
 567
 568         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 569         rvalue reference.
 570         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 571         (gdb_xml_parser::parse): Use std::move.
 572         * python/python-internal.h (gdbpy_convert_exception): Take a const
 573         reference.
 574         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 575         std::move.
 576         * python/py-utils.c (gdbpy_convert_exception): Take a const
 577         reference.
 578         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 579         Use std::move.
 580         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 581         Use std::move.
 582         * mi/mi-main.c (mi_print_exception): Take a const reference.
 583         * main.c (handle_command_errors): Take a const reference.
 584         * linespec.c (parse_linespec): Use std::move.
 585         * infcall.c (run_inferior_call): Use std::move.
 586         (call_function_by_hand_dummy): Use std::move.
 587         * exec.c (try_open_exec_file): Use std::move.
 588         * exceptions.h (exception_print, exception_fprintf)
 589         (exception_print_same): Update.
 590         * exceptions.c (print_exception, exception_print)
 591         (exception_fprintf, exception_print_same): Change parameters to
 592         const reference.
 593         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 594         * common/new-op.c: Use std::move.
 595         * common/common-exceptions.h (struct gdb_exception): Add move
 596         constructor.
 597         (struct gdb_exception_error, struct gdb_exception_quit, struct
 598         gdb_quit_bad_alloc): Change constructor to move constructor.
 599         (throw_exception): Change parameter to rvalue reference.
 600         * common/common-exceptions.c (throw_exception): Take rvalue
 601         reference.
 602         * cli/cli-interp.c (safe_execute_command): Use std::move.
 603         * breakpoint.c (insert_bp_location, location_to_sals): Use
 604         std::move.
 605
 606 2019-04-25  Tom Tromey  <tromey@adacore.com>
 607
 608         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 609         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 610         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 611         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 612         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 613         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 614         guile/scm-value.c: Use unpack.
 615         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 616         gdbscm_gdb_exception.
 617         (gdbscm_throw_gdb_exception): Likewise.
 618         (struct gdbscm_gdb_exception): New.
 619         (unpack): New function.
 620         (gdbscm_wrap): Use unpack.
 621
 622 2019-04-25  Tom Tromey  <tromey@adacore.com>
 623
 624         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 625         (gdb_rl_callback_handler): Use std::move.
 626         * common/common-exceptions.h (struct gdb_exception): Add move
 627         assignment operator.
 628         (throw_exception_sjlj): Change "exception" to const reference.
 629         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 630         (throw_exception_sjlj): Change "exception" to const reference.
 631
 632 2019-04-25  Tom Tromey  <tromey@adacore.com>
 633
 634         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 635         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 636         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 637         Update.
 638         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 639         Update.
 640         * mi/mi-interp.c (mi_interp::exec): Update.
 641         * linespec.c (parse_linespec): Update.
 642         * infcall.c (run_inferior_call): Update.
 643         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 644         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 645         (gdbscm_lookup_global_symbol): Update.
 646         * guile/scm-param.c (gdbscm_parameter_value): Update.
 647         * guile/scm-frame.c (gdbscm_frame_read_register)
 648         (gdbscm_frame_read_var): Update.
 649         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 650         * exec.c (try_open_exec_file): Update.
 651         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 652         (gdb_rl_callback_handler): Update.
 653         * common/common-exceptions.h (exception_none): Don't declare.
 654         * common/common-exceptions.c (exception_none): Don't define.
 655         (struct catcher) <exception>: Update.
 656         * cli/cli-interp.c (safe_execute_command): Update.
 657         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 658
 659 2019-04-25  Ali Tamur  <tamur@google.com>
 660
 661         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 662         (read_attribute_value): Likewise.
 663         (dwarf2_read_addr_index): Update comment.
 664         (read_str_index): Add DW_FORM_strx.
 665         (dwarf2_string_attr): Likewise.
 666         (dwarf2_const_value_attr): Likewise.
 667         (dump_die_shallow): Likewise.
 668         (dwarf2_fetch_constant_bytes): Likewise.
 669         (skip_form_bytes): Likewise.
 670         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 671
 672 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 673
 674         PR corefiles/11608
 675         PR corefiles/18187
 676         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 677         OFFSET.  Verify if current mapping contains an ELF header.
 678         (linux_find_memory_regions_full): Adjust call to
 679         dump_mapping_p.
 680
 681 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 682             Kang Li <kanglictf@gmail.com>
 683
 684         PR gdb/21600
 685
 686         * dwarf2-frame.c (read_initial_length): Be consistent about using
 687         unsigned representation of length.
 688         (decode_frame_entry_1): Likewise.  Check for wraparound of
 689         end pointer as well as buffer overflow.
 690
 691 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 692
 693         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 694         "vq".
 695
 696 2019-04-24  Tom Tromey  <tromey@adacore.com>
 697
 698         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 699
 700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 701
 702         * s12z-tdep.c (s12z_unwind_pc): Delete.
 703         (s12z_unwind_sp): Delete.
 704         (s12z_gdbarch_init): Don't register deleted functions with
 705         gdbarch.
 706
 707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 708
 709         * rl78-tdep.c (rl78_unwind_sp): Delete.
 710         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 711
 712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 713
 714         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 715         (xstormy16_unwind_pc): Delete.
 716         (xstormy16_dummy_id): Delete.
 717         (xstormy16_gdbarch_init): Don't register deleted functions with
 718         gdbarch.
 719
 720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 721
 722         * vax-tdep.c (vax_unwind_pc): Delete.
 723         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 724
 725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 726
 727         * v850-tdep.c (v850_unwind_sp): Delete.
 728         (v850_unwind_pc): Delete.
 729         (v850_dummy_id): Delete.
 730         (v850_gdbarch_init): Don't register deleted functions with
 731         gdbarch.
 732
 733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 736         (tilegx_unwind_pc): Delete.
 737         (tilegx_unwind_dummy_id): Delete.
 738         (tilegx_gdbarch_init): Don't register deleted functions with
 739         gdbarch.
 740
 741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 742
 743         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 744         (tic6x_dummy_id): Delete.
 745         (tic6x_gdbarch_init): Don't register deleted functions with
 746         gdbarch.
 747
 748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 749
 750         * sparc-tdep.c (sparc_unwind_pc): Delete.
 751         (sparc32_gdbarch_init): Don't register deleted function with
 752         gdbarch.
 753
 754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 755
 756         * sh-tdep.c (sh_unwind_sp): Delete.
 757         (sh_unwind_pc): Delete.
 758         (sh_dummy_id): Delete.
 759         (sh_gdbarch_init): Don't register deleted functions with
 760         gdbarch.
 761
 762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         * score-tdep.c (score_unwind_sp): Delete.
 765         (score_unwind_pc): Delete.
 766         (score_dummy_id): Delete.
 767         (score_gdbarch_init): Don't register deleted functions with
 768         gdbarch.
 769
 770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 771
 772         * rx-tdep.c (rx_unwind_pc): Delete.
 773         (rx_unwind_sp): Delete.
 774         (rx_dummy_id): Delete.
 775         (rx_gdbarch_init): Don't register deleted functions with
 776         gdbarch.  Update comment.
 777
 778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 781         (rs6000_dummy_id): Delete.
 782         (rs6000_gdbarch_init): Don't register deleted functions with
 783         gdbarch.
 784
 785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 786
 787         * or1k-tdep.c (or1k_dummy_id): Delete.
 788         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 789
 790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 791
 792         * nios2-tdep.c (nios2_dummy_id): Delete.
 793         (nios2_unwind_sp): Delete.
 794         (nios2_gdbarch_init): Don't register deleted functions with
 795         gdbarch.
 796
 797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 798
 799         * nds32-tdep.c (nds32_dummy_id): Delete.
 800         (nds32_unwind_pc): Delete.
 801         (nds32_unwind_sp): Delete.
 802         (nds32_gdbarch_init): Don't register deleted functions with
 803         gdbarch.
 804
 805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 806
 807         * msp430-tdep.c (msp430_unwind_pc): Delete.
 808         (msp430_unwind_sp): Delete.
 809         (msp430_dummy_id): Delete.
 810         (msp430_gdbarch_init): Don't register deleted functions with
 811         gdbarch.
 812
 813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 814
 815         * moxie-tdep.c (moxie_unwind_sp): Delete.
 816         (moxie_unwind_pc): Delete.
 817         (moxie_dummy_id): Delete.
 818         (moxie_gdbarch_init): Don't register deleted functions with
 819         gdbarch.
 820
 821 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 824         (mn10300_unwind_pc): Delete.
 825         (mn10300_unwind_sp): Delete.
 826         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 827         mn10300_unwind_sp.
 828         (mn10300_frame_unwind_init): Don't register deleted functions with
 829         gdbarch.
 830
 831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 832
 833         * mep-tdep.c (mep_unwind_pc): Delete.
 834         (mep_unwind_sp): Delete.
 835         (mep_dummy_id): Delete.
 836         (mep_gdbarch_init): Don't register deleted functions with
 837         gdbarch.
 838
 839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 840
 841         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 842         (m68hc11_unwind_sp): Delete.
 843         (m68hc11_gdbarch_init): Don't register deleted functions with
 844         gdbarch.
 845
 846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 847
 848         * m32r-tdep.c (m32r_unwind_sp): Delete.
 849         (m32r_unwind_pc): Delete.
 850         (m32r_dummy_id): Delete.
 851         (m32r_gdbarch_init): Don't register deleted functions with
 852         gdbarch.
 853
 854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 855
 856         * m32c-tdep.c (m32c_unwind_pc): Delete.
 857         (m32c_unwind_sp): Delete.
 858         (m32c_dummy_id): Delete.
 859         (m32c_gdbarch_init): Don't register deleted functions with
 860         gdbarch.
 861
 862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 863
 864         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 865         (lm32_unwind_pc): Delete.
 866         (lm32_dummy_id): Delete.
 867         (lm32_gdbarch_init): Don't register deleted functions with
 868         gdbarch.
 869
 870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 871
 872         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 873         (iq2000_unwind_pc): Delete.
 874         (iq2000_dummy_id): Delete.
 875         (iq2000_gdbarch_init): Don't register deleted functions with
 876         gdbarch.
 877
 878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 879
 880         * nds32-tdep.c (nds32_type_align): Delete.
 881         (nds32_push_dummy_call): Use type_align instead.
 882
 883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 884
 885         * arm-tdep.c (arm_type_align): Only handle vector override case.
 886         (arm_push_dummy_call): Use type_align.
 887         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 888
 889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 890
 891         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 892         case.
 893         (pass_on_stack): Use type_align.
 894         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 895         function.
 896
 897 2019-04-23  Tom Tromey  <tromey@adacore.com>
 898
 899         * dwarf2read.c (line_header::file_name_at): Remove unused
 900         overload.
 901
 902 2019-04-23  Tom de Vries  <tdevries@suse.de>
 903
 904         PR gdb/24438
 905         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 906         invocation.
 907
 908
 909 2019-03-27  Ali Tamur  <tamur@google.com>
 910
 911         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 912         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 913         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 914         (dwarf_expr_context::get_addr_index): Likewise
 915         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 916         (symbol_needs_eval_context::get_addr_index): Likewise
 917         (disassemble_dwarf_expression): Add DW_OP_addrx
 918         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 919         (read_cutu_die_from_dwo): Update comment
 920         (skip_one_die): Add DW_FORM_addrx
 921         (read_attribute_value): Likewise
 922         (var_decode_location): Add DW_OP_addrx
 923         (dwarf2_const_value_attr): Add DW_FORM_addrx
 924         (dump_die_shallow): Likewise
 925         (dwarf2_fetch_constant_bytes): Likewise
 926         (decode_locdesc): Add DW_OP_addrx
 927         (skip_form_bytes): Add DW_FORM_addrx
 928
 929 2019-04-22  Ali Tamur  <tamur@google.com>
 930
 931         * MAINTAINERS (Write After Approval): Add self.
 932
 933 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 934
 935         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 936         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 937         (open_symbol_file_object): Likewise.
 938         (svr4_default_sos): Add info parameter.
 939         (svr4_read_so_list): Likewise.
 940         (svr4_current_sos_direct): Adjust functions calls to pass down
 941         info.
 942         (svr4_current_sos_1): Add info parameter.
 943         (svr4_current_sos): Call get_svr4_info, pass info down to
 944         svr4_current_sos_1.
 945         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 946         get_svr4_info.
 947         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 948         get_svr4_info.
 949         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 950         to get_svr4_info.
 951         (probes_table_remove_objfile_probes): Likewise.
 952         (register_solib_event_probe): Add info parameter.
 953         (solist_update_incremental): Pass info parameter down to
 954         svr4_read_so_list.
 955         (disable_probes_interface): Add info parameter.
 956         (svr4_handle_solib_event): Pass current_program_space to
 957         get_svr4_info.  Adjust disable_probes_interface cleanup.
 958         (svr4_create_probe_breakpoints): Add info parameter, pass it
 959         down to register_solib_event_probe.
 960         (svr4_create_solib_event_breakpoints): Add info parameter,
 961         pass it down to svr4_create_probe_breakpoints.
 962         (enable_break): Pass info down to
 963         svr4_create_solib_event_breakpoints.
 964         (svr4_solib_create_inferior_hook): Pass current_program_space to
 965         get_svr4_info.
 966         (svr4_clear_solib): Likewise.
 967
 968 2019-04-22  Pedro Alves  <palves@redhat.com>
 969
 970         * solib-svr4.c (svr4_free_objfile_observer): New.
 971         (probe_and_action::objfile): New field.
 972         (probes_table_htab_remove_objfile_probes)
 973         (probes_table_remove_objfile_probes): New functions.
 974         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 975         in the new probe_and_action.  Don't store the probe in 'lookup'.
 976         (svr4_create_probe_breakpoints): Pass objfile to
 977         register_solib_event_probe.
 978         (_initialize_svr4_solib): Register a free_objfile observer.
 979
 980 2019-04-19  Tom Tromey  <tom@tromey.com>
 981
 982         * common/queue.h: Remove.
 983
 984 2019-04-19  Tom Tromey  <tom@tromey.com>
 985
 986         * event-loop.c: Don't include "common/queue.h".
 987
 988 2019-04-19  Tom Tromey  <tom@tromey.com>
 989
 990         * remote.c (remote_target): Use delete.
 991         * remote-notif.h: Include <list>, not "common/queue.h".
 992         (notif_client_p): Remove typedef.
 993         (remote_notif_state): Add constructor, destructor, initializer.
 994         <notif_queue>: Now a std::list.
 995         (remote_notif_state_xfree): Don't declare.
 996         * remote-notif.c (remote_notif_process, handle_notification)
 997         (remote_notif_state_allocate): Update.
 998         (~remote_notif_state): Rename from remote_notif_state_xfree.
 999
1000 2019-04-19  Tom Tromey  <tom@tromey.com>
1001
1002         * symfile.c (reread_symbols): Update.
1003         * objfiles.c (objfile_register_static_link)
1004         (objfile_lookup_static_link): Update
1005         (~objfile) Don't delete static_links.
1006         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1007
1008 2019-04-19  Tom Tromey  <tom@tromey.com>
1009
1010         * type-stack.h (struct type_stack) <insert>: Constify string.
1011         * type-stack.c (type_stack::insert): Constify string.
1012         * gdbtypes.h (lookup_template_type): Update.
1013         (address_space_name_to_int): Update.
1014         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1015         const.
1016         (lookup_template_type): Make name const.
1017         * c-exp.y: Update rules.
1018         (lex_one_token, classify_name, classify_inner_name)
1019         (c_print_token): Update.
1020         * p-exp.y: Update rules.
1021         (yylex): Update.
1022         * f-exp.y: Update rules.
1023         (yylex): Update.
1024         * d-exp.y: Update rules.
1025         (lex_one_token, classify_name, classify_inner_name): Update.
1026         * parse.c (write_dollar_variable, copy_name): Return std::string.
1027         * parser-defs.h (copy_name): Change return type.
1028         * m2-exp.y: Update rules.
1029         (yylex): Update.
1030         * go-exp.y (lex_one_token): Update.
1031         Update rules.
1032         (classify_unsafe_function, classify_packaged_name)
1033         (classify_name, yylex): Update.
1034
1035 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1036
1037         * configure.ac: add --enable-source-highlight switch.
1038         * configure: Regenerate.
1039         * top.c (print_gdb_version): plumb --enable-source-highlight
1040         status to "show configuration".
1041
1042 2019-04-19  Tom Tromey  <tromey@adacore.com>
1043
1044         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1045         Check ADA_TYPE_P.
1046         (empty_record, ada_template_to_fixed_record_type_1)
1047         (template_to_static_fixed_type)
1048         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1049         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1050         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1051         macros.
1052
1053 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1054
1055         PR symtab/24423:
1056         * source.c (print_source_lines_base): Advance "iter" when a
1057         control character is seen.
1058
1059 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1060
1061         * inferior.h (struct infcall_suspend_state_deleter):
1062         Catch exception in destructor to avoid crash.
1063
1064 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1065
1066         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1067         close to the add_com "shell".
1068
1069 2019-04-18  Tom Tromey  <tromey@adacore.com>
1070
1071         * process-stratum-target.h (class process_stratum_target)
1072         <stratum>: Add "final".
1073
1074 2019-04-17  Tom Tromey  <tromey@adacore.com>
1075
1076         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1077         against nullptr before use.
1078
1079 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1080
1081         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1082
1083 2019-04-17  Jim Wilson  <jimw@sifive.com>
1084             Andrew Burgess  <andrew.burgess@embecosm.com>
1085
1086         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1087         code read might fail, assume 4-byte breakpoint in that case.
1088
1089 2019-04-15  Leszek Swirski  <leszeks@google.com>
1090
1091         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1092         rather than a hand-rolled POD check when checking for forced MEMORY
1093         classification.
1094
1095 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1096
1097         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1098         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1099         function.
1100         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1101         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1102         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1103         declaration.
1104
1105 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1106
1107         * aarch64-linux-nat.c
1108         (aarch64_linux_nat_target::thread_architecture): Add override.
1109         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1110         each VQ.
1111
1112 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1113
1114         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1115
1116 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1119         target types of size 96-bits, add some additional comments, and
1120         check that the builtin type we found was the correct size.
1121
1122 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1123
1124         * utils.c (prompt_for_continue): Don't restore the styling at the
1125         end, as applied_style has the wrong value.  This fixes styling in
1126         long lists of file names that are interrupted by the "Continue?"
1127         prompt.
1128
1129 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1130
1131         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1132         * c-lang.c (c_language_defn): Likewise.
1133         (cplus_language_defn): Likewise.
1134         (asm_language_defn): Likewise.
1135         (minimal_language_defn): Likewise.
1136         * d-lang.c (d_language_defn): Likewise.
1137         * f-lang.c (f_language_defn): Likewise.
1138         * go-lang.c (go_language_defn): Likewise.
1139         * language.c (unknown_language_defn): Likewise.
1140         (auto_language_defn): Likewise.
1141         * language.h (struct language_defn): Remove la_magic field.
1142         (LANG_MAGIC): Delete.
1143         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1144         * objc-lang.c (objc_language_defn): Likewise.
1145         * opencl-lang.c (opencl_language_defn): Likewise.
1146         * p-lang.c (pascal_language_defn): Likewise.
1147         * rust-lang.c (rust_language_defn): Likewise.
1148
1149 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1150
1151         * riscv-tdep.c (riscv_type_align): New function.
1152         (riscv_type_alignment): Delete.
1153         (riscv_arg_location): Use 'type_align'.
1154         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1155
1156 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1157
1158         * gdbtypes.c (type_align): A struct with no non-static fields also
1159         has alignment of 1.
1160
1161 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1164         component to 0.
1165         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1166         member.
1167         (riscv_struct_info::analyse): New implementation using new
1168         analyse_inner member function.
1169         (riscv_struct_info::field_offset): New member function.
1170         (riscv_struct_info::m_offsets): New member variable.
1171         (riscv_struct_info::analyse_inner): New private member function,
1172         takes the old implementation of riscv_struct_info::analyse but
1173         extended to track field offsets.
1174         (riscv_call_arg_struct): Update the struct folding special cases
1175         to handle cases where empty C++ structs, which are non-zero
1176         length, are found.
1177         (riscv_arg_location): Initialise the length of each location, a
1178         non-zero length now indicates the location is in use.
1179         (riscv_push_dummy_call): Allow for the first location having a
1180         non-zero offset when setting up arguments.
1181         (riscv_return_value): Likewise, but for return values.
1182
1183 2019-04-11  Tom Tromey  <tromey@adacore.com>
1184
1185         * utils.c (internal_vproblem): Make "msg" const.
1186
1187 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1188
1189         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1190         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1191         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1192         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1193
1194 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1195
1196         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1197         function.
1198         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1199         of amd64_collect_native_gregset.
1200         (amd64_linux_nat_target::store_registers): Likewise.
1201
1202 2019-04-10  Tom Tromey  <tom@tromey.com>
1203
1204         * symtab.c (lookup_global_symbol_from_objfile)
1205         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1206         * objfiles.h (class separate_debug_iterator): New.
1207         (class separate_debug_range): New.
1208         (struct objfile) <separate_debug_objfiles>: New method.
1209         (objfile_separate_debug_iterate): Don't declare.
1210         * objfiles.c (separate_debug_iterator::operator++): Rename from
1211         objfile_separate_debug_iterate.
1212         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1213         iterator.
1214         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1215         iterator.
1216
1217 2019-04-10  Tom Tromey  <tom@tromey.com>
1218
1219         * symfile.c (reread_symbols): Remove old comment.
1220         * objfiles.c (free_all_objfiles): Fix a typo.
1221
1222 2019-04-10  Tom Tromey  <tom@tromey.com>
1223
1224         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1225         * minsyms.c (lookup_minimal_symbol): Use foreach.
1226         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1227         (lookup_minimal_symbol_solib_trampoline): Likewise.
1228         * symfile.c (reread_symbols): Use foreach.
1229
1230 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1231             Tom Tromey  <tromey@adacore.com>
1232
1233         PR rust/24414:
1234         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1235         (rust_lex_int_test): Change "value" to be LONGEST.
1236         (rust_lex_tests): Add test for long integer literal.
1237
1238 2019-04-09  Tom Tromey  <tromey@adacore.com>
1239
1240         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1241         to bool.
1242         (extended_remote_target::attach): Update.
1243         (remote_target::remote_notice_new_inferior): Update.
1244         (remote_target::add_current_inferior_and_thread): Update.
1245         * inferior.c (exit_inferior_1): Use "false".
1246         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1247
1248 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1249
1250         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1251         the "start" command.
1252
1253 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1254
1255         * python/py-inferior.c (infpy_thread_from_thread_handle):
1256         Adjust comments to reflect renaming of thread_from_thread_handle
1257         to thread_from_handle.  Adjust keywords.  Fix type error message.
1258         (inferior_object_methods): Add thread_from_handle.  Retain
1259         thread_from_thread_handle, but mark it as deprecated.
1260
1261 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1262
1263         * gdbthread.h (find_thread_by_handle): Revise declaration.
1264         * thread.c (find_thread_by_handle): Likewise.  Adjust
1265         implementation too.
1266         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1267         support for buffer objects as handles.
1268
1269 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1270
1271         * python/py-infthread.c (thpy_thread_handle): New function.
1272         (thread_object_methods): Register thpy_thread_handle.
1273
1274 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1275
1276         * gdbthread.h (thread_to_thread_handle): Declare.
1277         * thread.c (gdbtypes.h): Include.
1278         (thread_to_thread_handle): New function.
1279
1280         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1281         (target_thread_info_to_thread_handle): Declare.
1282         * target.c (target_thread_info_to_thread_handle): New function.
1283         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1284         * target-delegates.c: Regenerate.
1285
1286         * linux-thread-db.c (class thread_db_target): Add method
1287         thread_info_to_thread_handle.
1288         (thread_db_target::thread_info_to_thread_handle): Define.
1289         * remote.c (class remote_target): Add new method
1290         thread_info_to_thread_handle.
1291         (remote_target::thread_info_to_thread_handle): Define.
1292
1293 2019-04-08  Pedro Alves  <palves@redhat.com>
1294
1295         * common/common-exceptions.c (throw_exception): Don't create
1296         named object to throw; throw directly.
1297         (throw_it): Likewise.  Don't initialize gdb_exception::message
1298         here, with new; pass FMT and AP to the ctor instead.
1299         * common/common-exceptions.h: Include <string>.
1300         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1301         const char *, va_list)): New ctor.  Use std::make_shared.
1302         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1303         errors)): Delete.
1304         (gdb_exception_error::gdb_exception_error(enum errors, const char
1305         *, va_list)): New.
1306         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1307         Add assertion.
1308         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1309         errors)): Delete.
1310         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1311         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1312         Add assertion.
1313
1314 2019-04-08  Tom Tromey  <tom@tromey.com>
1315
1316         * valops.c (value_rtti_indirect_type): Replace throw_exception
1317         with throw.
1318         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1319         with throw.
1320         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1321         throw.
1322         * target.c (target_translate_tls_address): Replace throw_exception
1323         with throw.
1324         * stack.c (frame_apply_command_count): Replace throw_exception
1325         with throw.
1326         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1327         throw.
1328         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1329         with throw.
1330         * rs6000-tdep.c (rs6000_frame_cache)
1331         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1332         * remote.c: Replace throw_exception with throw.
1333         * record-full.c (record_full_message, record_full_wait_1)
1334         (record_full_restore): Replace throw_exception with throw.
1335         * record-btrace.c:
1336         (get_thread_current_frame_id, record_btrace_start_replaying)
1337         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1338         (cmd_record_btrace_start): Replace throw_exception with throw.
1339         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1340         throw.
1341         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1342         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1343         * linespec.c:
1344         (find_linespec_symbols): Replace throw_exception with throw.
1345         * infrun.c (displaced_step_prepare, resume): Replace
1346         throw_exception with throw.
1347         * infcmd.c (post_create_inferior): Replace throw_exception with
1348         throw.
1349         * inf-loop.c (inferior_event_handler): Replace throw_exception
1350         with throw.
1351         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1352         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1353         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1354         (get_prev_frame_always, get_frame_pc_if_available)
1355         (get_frame_address_in_block_if_available, get_frame_language):
1356         Replace throw_exception with throw.
1357         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1358         throw_exception with throw.
1359         * eval.c (fetch_subexp_value, evaluate_var_value)
1360         (evaluate_funcall, evaluate_subexp_standard): Replace
1361         throw_exception with throw.
1362         * dwarf2loc.c (call_site_find_chain)
1363         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1364         Replace throw_exception with throw.
1365         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1366         with throw.
1367         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1368         throw.
1369         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1370         * completer.c (complete_line_internal): Replace throw_exception
1371         with throw.
1372         * compile/compile-object-run.c (compile_object_run): Replace
1373         throw_exception with throw.
1374         * cli/cli-script.c (process_next_line): Replace throw_exception
1375         with throw.
1376         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1377         (btrace_enable, btrace_maint_update_pt_packets): Replace
1378         throw_exception with throw.
1379         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1380         throw_exception with throw.
1381         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1382         throw_exception with throw.
1383         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1384         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1385         * aarch64-tdep.c (aarch64_make_prologue_cache)
1386         (aarch64_make_stub_cache): Replace throw_exception with throw.
1387
1388 2019-04-08  Tom Tromey  <tom@tromey.com>
1389
1390         * common/common-exceptions.c (throw_exception): Rename from
1391         throw_exception_cxx.  Remove old copy.  Make argument const.
1392         (throw_it): Create and throw exception objects directly.
1393         * common/common-exceptions.h (throw_exception): Make argument
1394         const.
1395         (struct gdb_exception_error): Add constructor.
1396         (struct gdb_exception_quit): Add constructor.
1397
1398 2019-04-08  Tom Tromey  <tom@tromey.com>
1399
1400         * common/common-exceptions.h (exception_rethrow): Don't declare.
1401         (TRY_SJLJ): Update comment.
1402         (TRY, CATCH, END_CATCH): Remove.
1403         * common/common-exceptions.c (exception_rethrow): Remove.
1404
1405 2019-04-08  Tom Tromey  <tom@tromey.com>
1406
1407         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1408         Remove.
1409         (gdb_exception_error): Rename from
1410         gdb_exception_RETURN_MASK_ERROR.
1411         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1412         (gdb_quit_bad_alloc): Update.
1413         * aarch64-tdep.c: Update.
1414         * ada-lang.c: Update.
1415         * ada-typeprint.c: Update.
1416         * ada-valprint.c: Update.
1417         * amd64-tdep.c: Update.
1418         * arch-utils.c: Update.
1419         * break-catch-throw.c: Update.
1420         * breakpoint.c: Update.
1421         * btrace.c: Update.
1422         * c-varobj.c: Update.
1423         * cli/cli-cmds.c: Update.
1424         * cli/cli-interp.c: Update.
1425         * cli/cli-script.c: Update.
1426         * common/common-exceptions.c: Update.
1427         * common/new-op.c: Update.
1428         * common/selftest.c: Update.
1429         * compile/compile-c-symbols.c: Update.
1430         * compile/compile-cplus-symbols.c: Update.
1431         * compile/compile-object-load.c: Update.
1432         * compile/compile-object-run.c: Update.
1433         * completer.c: Update.
1434         * corelow.c: Update.
1435         * cp-abi.c: Update.
1436         * cp-support.c: Update.
1437         * cp-valprint.c: Update.
1438         * darwin-nat.c: Update.
1439         * disasm-selftests.c: Update.
1440         * dtrace-probe.c: Update.
1441         * dwarf-index-cache.c: Update.
1442         * dwarf-index-write.c: Update.
1443         * dwarf2-frame-tailcall.c: Update.
1444         * dwarf2-frame.c: Update.
1445         * dwarf2loc.c: Update.
1446         * dwarf2read.c: Update.
1447         * eval.c: Update.
1448         * event-loop.c: Update.
1449         * event-top.c: Update.
1450         * exec.c: Update.
1451         * f-valprint.c: Update.
1452         * fbsd-tdep.c: Update.
1453         * frame-unwind.c: Update.
1454         * frame.c: Update.
1455         * gdbtypes.c: Update.
1456         * gnu-v3-abi.c: Update.
1457         * guile/guile-internal.h: Update.
1458         * guile/scm-block.c: Update.
1459         * guile/scm-breakpoint.c: Update.
1460         * guile/scm-cmd.c: Update.
1461         * guile/scm-disasm.c: Update.
1462         * guile/scm-frame.c: Update.
1463         * guile/scm-lazy-string.c: Update.
1464         * guile/scm-math.c: Update.
1465         * guile/scm-param.c: Update.
1466         * guile/scm-ports.c: Update.
1467         * guile/scm-pretty-print.c: Update.
1468         * guile/scm-symbol.c: Update.
1469         * guile/scm-symtab.c: Update.
1470         * guile/scm-type.c: Update.
1471         * guile/scm-value.c: Update.
1472         * i386-linux-tdep.c: Update.
1473         * i386-tdep.c: Update.
1474         * inf-loop.c: Update.
1475         * infcall.c: Update.
1476         * infcmd.c: Update.
1477         * infrun.c: Update.
1478         * jit.c: Update.
1479         * language.c: Update.
1480         * linespec.c: Update.
1481         * linux-fork.c: Update.
1482         * linux-nat.c: Update.
1483         * linux-tdep.c: Update.
1484         * linux-thread-db.c: Update.
1485         * main.c: Update.
1486         * mi/mi-cmd-break.c: Update.
1487         * mi/mi-cmd-stack.c: Update.
1488         * mi/mi-interp.c: Update.
1489         * mi/mi-main.c: Update.
1490         * objc-lang.c: Update.
1491         * p-valprint.c: Update.
1492         * parse.c: Update.
1493         * ppc-linux-tdep.c: Update.
1494         * printcmd.c: Update.
1495         * python/py-arch.c: Update.
1496         * python/py-breakpoint.c: Update.
1497         * python/py-cmd.c: Update.
1498         * python/py-finishbreakpoint.c: Update.
1499         * python/py-frame.c: Update.
1500         * python/py-framefilter.c: Update.
1501         * python/py-gdb-readline.c: Update.
1502         * python/py-inferior.c: Update.
1503         * python/py-infthread.c: Update.
1504         * python/py-lazy-string.c: Update.
1505         * python/py-linetable.c: Update.
1506         * python/py-objfile.c: Update.
1507         * python/py-param.c: Update.
1508         * python/py-prettyprint.c: Update.
1509         * python/py-progspace.c: Update.
1510         * python/py-record-btrace.c: Update.
1511         * python/py-record.c: Update.
1512         * python/py-symbol.c: Update.
1513         * python/py-type.c: Update.
1514         * python/py-unwind.c: Update.
1515         * python/py-utils.c: Update.
1516         * python/py-value.c: Update.
1517         * python/python.c: Update.
1518         * record-btrace.c: Update.
1519         * record-full.c: Update.
1520         * remote-fileio.c: Update.
1521         * remote.c: Update.
1522         * riscv-tdep.c: Update.
1523         * rs6000-aix-tdep.c: Update.
1524         * rs6000-tdep.c: Update.
1525         * rust-exp.y: Update.
1526         * rust-lang.c: Update.
1527         * s390-tdep.c: Update.
1528         * selftest-arch.c: Update.
1529         * solib-dsbt.c: Update.
1530         * solib-frv.c: Update.
1531         * solib-spu.c: Update.
1532         * solib-svr4.c: Update.
1533         * solib.c: Update.
1534         * sparc64-linux-tdep.c: Update.
1535         * stack.c: Update.
1536         * symfile-mem.c: Update.
1537         * symmisc.c: Update.
1538         * target.c: Update.
1539         * thread.c: Update.
1540         * top.c: Update.
1541         * tracefile-tfile.c: Update.
1542         * tui/tui.c: Update.
1543         * typeprint.c: Update.
1544         * unittests/cli-utils-selftests.c: Update.
1545         * unittests/parse-connection-spec-selftests.c: Update.
1546         * valops.c: Update.
1547         * valprint.c: Update.
1548         * value.c: Update.
1549         * varobj.c: Update.
1550         * windows-nat.c: Update.
1551         * x86-linux-nat.c: Update.
1552         * xml-support.c: Update.
1553
1554 2019-04-08  Tom Tromey  <tom@tromey.com>
1555
1556         * xml-support.c: Use C++ exception handling.
1557         * x86-linux-nat.c: Use C++ exception handling.
1558         * windows-nat.c: Use C++ exception handling.
1559         * varobj.c: Use C++ exception handling.
1560         * value.c: Use C++ exception handling.
1561         * valprint.c: Use C++ exception handling.
1562         * valops.c: Use C++ exception handling.
1563         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1564         handling.
1565         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1566         * typeprint.c: Use C++ exception handling.
1567         * tui/tui.c: Use C++ exception handling.
1568         * tracefile-tfile.c: Use C++ exception handling.
1569         * top.c: Use C++ exception handling.
1570         * thread.c: Use C++ exception handling.
1571         * target.c: Use C++ exception handling.
1572         * symmisc.c: Use C++ exception handling.
1573         * symfile-mem.c: Use C++ exception handling.
1574         * stack.c: Use C++ exception handling.
1575         * sparc64-linux-tdep.c: Use C++ exception handling.
1576         * solib.c: Use C++ exception handling.
1577         * solib-svr4.c: Use C++ exception handling.
1578         * solib-spu.c: Use C++ exception handling.
1579         * solib-frv.c: Use C++ exception handling.
1580         * solib-dsbt.c: Use C++ exception handling.
1581         * selftest-arch.c: Use C++ exception handling.
1582         * s390-tdep.c: Use C++ exception handling.
1583         * rust-lang.c: Use C++ exception handling.
1584         * rust-exp.y: Use C++ exception handling.
1585         * rs6000-tdep.c: Use C++ exception handling.
1586         * rs6000-aix-tdep.c: Use C++ exception handling.
1587         * riscv-tdep.c: Use C++ exception handling.
1588         * remote.c: Use C++ exception handling.
1589         * remote-fileio.c: Use C++ exception handling.
1590         * record-full.c: Use C++ exception handling.
1591         * record-btrace.c: Use C++ exception handling.
1592         * python/python.c: Use C++ exception handling.
1593         * python/py-value.c: Use C++ exception handling.
1594         * python/py-utils.c: Use C++ exception handling.
1595         * python/py-unwind.c: Use C++ exception handling.
1596         * python/py-type.c: Use C++ exception handling.
1597         * python/py-symbol.c: Use C++ exception handling.
1598         * python/py-record.c: Use C++ exception handling.
1599         * python/py-record-btrace.c: Use C++ exception handling.
1600         * python/py-progspace.c: Use C++ exception handling.
1601         * python/py-prettyprint.c: Use C++ exception handling.
1602         * python/py-param.c: Use C++ exception handling.
1603         * python/py-objfile.c: Use C++ exception handling.
1604         * python/py-linetable.c: Use C++ exception handling.
1605         * python/py-lazy-string.c: Use C++ exception handling.
1606         * python/py-infthread.c: Use C++ exception handling.
1607         * python/py-inferior.c: Use C++ exception handling.
1608         * python/py-gdb-readline.c: Use C++ exception handling.
1609         * python/py-framefilter.c: Use C++ exception handling.
1610         * python/py-frame.c: Use C++ exception handling.
1611         * python/py-finishbreakpoint.c: Use C++ exception handling.
1612         * python/py-cmd.c: Use C++ exception handling.
1613         * python/py-breakpoint.c: Use C++ exception handling.
1614         * python/py-arch.c: Use C++ exception handling.
1615         * printcmd.c: Use C++ exception handling.
1616         * ppc-linux-tdep.c: Use C++ exception handling.
1617         * parse.c: Use C++ exception handling.
1618         * p-valprint.c: Use C++ exception handling.
1619         * objc-lang.c: Use C++ exception handling.
1620         * mi/mi-main.c: Use C++ exception handling.
1621         * mi/mi-interp.c: Use C++ exception handling.
1622         * mi/mi-cmd-stack.c: Use C++ exception handling.
1623         * mi/mi-cmd-break.c: Use C++ exception handling.
1624         * main.c: Use C++ exception handling.
1625         * linux-thread-db.c: Use C++ exception handling.
1626         * linux-tdep.c: Use C++ exception handling.
1627         * linux-nat.c: Use C++ exception handling.
1628         * linux-fork.c: Use C++ exception handling.
1629         * linespec.c: Use C++ exception handling.
1630         * language.c: Use C++ exception handling.
1631         * jit.c: Use C++ exception handling.
1632         * infrun.c: Use C++ exception handling.
1633         * infcmd.c: Use C++ exception handling.
1634         * infcall.c: Use C++ exception handling.
1635         * inf-loop.c: Use C++ exception handling.
1636         * i386-tdep.c: Use C++ exception handling.
1637         * i386-linux-tdep.c: Use C++ exception handling.
1638         * guile/scm-value.c: Use C++ exception handling.
1639         * guile/scm-type.c: Use C++ exception handling.
1640         * guile/scm-symtab.c: Use C++ exception handling.
1641         * guile/scm-symbol.c: Use C++ exception handling.
1642         * guile/scm-pretty-print.c: Use C++ exception handling.
1643         * guile/scm-ports.c: Use C++ exception handling.
1644         * guile/scm-param.c: Use C++ exception handling.
1645         * guile/scm-math.c: Use C++ exception handling.
1646         * guile/scm-lazy-string.c: Use C++ exception handling.
1647         * guile/scm-frame.c: Use C++ exception handling.
1648         * guile/scm-disasm.c: Use C++ exception handling.
1649         * guile/scm-cmd.c: Use C++ exception handling.
1650         * guile/scm-breakpoint.c: Use C++ exception handling.
1651         * guile/scm-block.c: Use C++ exception handling.
1652         * guile/guile-internal.h: Use C++ exception handling.
1653         * gnu-v3-abi.c: Use C++ exception handling.
1654         * gdbtypes.c: Use C++ exception handling.
1655         * frame.c: Use C++ exception handling.
1656         * frame-unwind.c: Use C++ exception handling.
1657         * fbsd-tdep.c: Use C++ exception handling.
1658         * f-valprint.c: Use C++ exception handling.
1659         * exec.c: Use C++ exception handling.
1660         * event-top.c: Use C++ exception handling.
1661         * event-loop.c: Use C++ exception handling.
1662         * eval.c: Use C++ exception handling.
1663         * dwarf2read.c: Use C++ exception handling.
1664         * dwarf2loc.c: Use C++ exception handling.
1665         * dwarf2-frame.c: Use C++ exception handling.
1666         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1667         * dwarf-index-write.c: Use C++ exception handling.
1668         * dwarf-index-cache.c: Use C++ exception handling.
1669         * dtrace-probe.c: Use C++ exception handling.
1670         * disasm-selftests.c: Use C++ exception handling.
1671         * darwin-nat.c: Use C++ exception handling.
1672         * cp-valprint.c: Use C++ exception handling.
1673         * cp-support.c: Use C++ exception handling.
1674         * cp-abi.c: Use C++ exception handling.
1675         * corelow.c: Use C++ exception handling.
1676         * completer.c: Use C++ exception handling.
1677         * compile/compile-object-run.c: Use C++ exception handling.
1678         * compile/compile-object-load.c: Use C++ exception handling.
1679         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1680         * compile/compile-c-symbols.c: Use C++ exception handling.
1681         * common/selftest.c: Use C++ exception handling.
1682         * common/new-op.c: Use C++ exception handling.
1683         * cli/cli-script.c: Use C++ exception handling.
1684         * cli/cli-interp.c: Use C++ exception handling.
1685         * cli/cli-cmds.c: Use C++ exception handling.
1686         * c-varobj.c: Use C++ exception handling.
1687         * btrace.c: Use C++ exception handling.
1688         * breakpoint.c: Use C++ exception handling.
1689         * break-catch-throw.c: Use C++ exception handling.
1690         * arch-utils.c: Use C++ exception handling.
1691         * amd64-tdep.c: Use C++ exception handling.
1692         * ada-valprint.c: Use C++ exception handling.
1693         * ada-typeprint.c: Use C++ exception handling.
1694         * ada-lang.c: Use C++ exception handling.
1695         * aarch64-tdep.c: Use C++ exception handling.
1696
1697 2019-04-08  Tom Tromey  <tom@tromey.com>
1698
1699         * xml-support.c (gdb_xml_parser::parse): Update.
1700         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1701         * value.c (show_convenience): Update.
1702         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1703         (test_parse_flags_qcs): Update.
1704         * thread.c (thr_try_catch_cmd): Update.
1705         * target.c (target_translate_tls_address): Update.
1706         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1707         (info_frame_command_core, frame_apply_command_count): Update.
1708         * rust-exp.y (rust_lex_exception_test): Update.
1709         * riscv-tdep.c (riscv_print_one_register_info): Update.
1710         * remote.c (remote_target::enable_btrace): Update.
1711         * record-btrace.c (record_btrace_enable_warn): Update.
1712         * python/py-utils.c (gdbpy_convert_exception): Update.
1713         * printcmd.c (do_one_display, print_variable_and_value): Update.
1714         * mi/mi-main.c (mi_print_exception): Update.
1715         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1716         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1717         * linux-nat.c (linux_nat_target::attach): Update.
1718         * linux-fork.c (class scoped_switch_fork_info): Update.
1719         * infrun.c (displaced_step_prepare): Update.
1720         * infcall.c (call_function_by_hand_dummy): Update.
1721         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1722         * gnu-v3-abi.c (print_one_vtable): Update.
1723         * frame.c (get_prev_frame_always): Update.
1724         * f-valprint.c (info_common_command_for_block): Update.
1725         * exec.c (try_open_exec_file): Update.
1726         * exceptions.c (print_exception, exception_print)
1727         (exception_fprintf, exception_print_same): Update.
1728         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1729         * dwarf-index-cache.c (index_cache::store)
1730         (index_cache::lookup_gdb_index): Update.
1731         * darwin-nat.c (maybe_cache_shell): Update.
1732         * cp-valprint.c (cp_print_value_fields): Update.
1733         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1734         (gcc_cplus_symbol_address): Update.
1735         * compile/compile-c-symbols.c (gcc_convert_symbol)
1736         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1737         * common/selftest.c: Update.
1738         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1739         a std::string.
1740         (exception_try_scope_entry, exception_try_scope_exit): Don't
1741         declare.
1742         (struct exception_try_scope): Remove.
1743         (TRY): Don't use exception_try_scope.
1744         (struct gdb_exception): Add constructor, operator=.
1745         <what>: New method.
1746         (struct gdb_exception_RETURN_MASK_ALL)
1747         (struct gdb_exception_RETURN_MASK_ERROR)
1748         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1749         (struct gdb_quit_bad_alloc): Update.
1750         * common/common-exceptions.c (exception_none): Change
1751         initializer.
1752         (struct catcher) <state, exception>: Initialize inline.
1753         <prev>: Remove member.
1754         (current_catcher): Remove.
1755         (catchers): New global.
1756         (exceptions_state_mc_init): Simplify.
1757         (catcher_pop): Remove.
1758         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1759         (try_scope_depth, exception_try_scope_entry)
1760         (exception_try_scope_exit): Remove.
1761         (throw_exception_sjlj): Update.
1762         (exception_messages, exception_messages_size): Remove.
1763         (throw_it): Simplify.
1764         (gdb_exception_sliced_copy): Remove.
1765         (throw_exception_cxx): Update.
1766         * cli/cli-script.c (script_from_file): Update.
1767         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1768         Update.
1769         * ada-valprint.c (ada_val_print): Update.
1770         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1771         (create_excep_cond_exprs): Update.
1772
1773 2019-04-08  Tom Tromey  <tom@tromey.com>
1774
1775         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1776         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1777         (TRY, CATCH, END_CATCH): Remove some definitions.
1778         * common/common-exceptions.c: Don't use GDB_XCPT.
1779         (catcher_list_size): Remove.
1780         (throw_exception, throw_it): Simplify.
1781
1782 2019-04-05  Tom Tromey  <tom@tromey.com>
1783
1784         Revert the header-sorting patch.
1785         * ft32-tdep.c: Revert.
1786         * frv-tdep.c: Revert.
1787         * frv-linux-tdep.c: Revert.
1788         * frame.c: Revert.
1789         * frame-unwind.c: Revert.
1790         * frame-base.c: Revert.
1791         * fork-child.c: Revert.
1792         * findvar.c: Revert.
1793         * findcmd.c: Revert.
1794         * filesystem.c: Revert.
1795         * filename-seen-cache.h: Revert.
1796         * filename-seen-cache.c: Revert.
1797         * fbsd-tdep.c: Revert.
1798         * fbsd-nat.h: Revert.
1799         * fbsd-nat.c: Revert.
1800         * f-valprint.c: Revert.
1801         * f-typeprint.c: Revert.
1802         * f-lang.c: Revert.
1803         * extension.h: Revert.
1804         * extension.c: Revert.
1805         * extension-priv.h: Revert.
1806         * expprint.c: Revert.
1807         * exec.h: Revert.
1808         * exec.c: Revert.
1809         * exceptions.c: Revert.
1810         * event-top.c: Revert.
1811         * event-loop.c: Revert.
1812         * eval.c: Revert.
1813         * elfread.c: Revert.
1814         * dwarf2read.h: Revert.
1815         * dwarf2read.c: Revert.
1816         * dwarf2loc.c: Revert.
1817         * dwarf2expr.h: Revert.
1818         * dwarf2expr.c: Revert.
1819         * dwarf2-frame.c: Revert.
1820         * dwarf2-frame-tailcall.c: Revert.
1821         * dwarf-index-write.h: Revert.
1822         * dwarf-index-write.c: Revert.
1823         * dwarf-index-common.c: Revert.
1824         * dwarf-index-cache.h: Revert.
1825         * dwarf-index-cache.c: Revert.
1826         * dummy-frame.c: Revert.
1827         * dtrace-probe.c: Revert.
1828         * disasm.h: Revert.
1829         * disasm.c: Revert.
1830         * disasm-selftests.c: Revert.
1831         * dictionary.c: Revert.
1832         * dicos-tdep.c: Revert.
1833         * demangle.c: Revert.
1834         * dcache.h: Revert.
1835         * dcache.c: Revert.
1836         * darwin-nat.h: Revert.
1837         * darwin-nat.c: Revert.
1838         * darwin-nat-info.c: Revert.
1839         * d-valprint.c: Revert.
1840         * d-namespace.c: Revert.
1841         * d-lang.c: Revert.
1842         * ctf.c: Revert.
1843         * csky-tdep.c: Revert.
1844         * csky-linux-tdep.c: Revert.
1845         * cris-tdep.c: Revert.
1846         * cris-linux-tdep.c: Revert.
1847         * cp-valprint.c: Revert.
1848         * cp-support.c: Revert.
1849         * cp-namespace.c: Revert.
1850         * cp-abi.c: Revert.
1851         * corelow.c: Revert.
1852         * corefile.c: Revert.
1853         * continuations.c: Revert.
1854         * completer.h: Revert.
1855         * completer.c: Revert.
1856         * complaints.c: Revert.
1857         * coffread.c: Revert.
1858         * coff-pe-read.c: Revert.
1859         * cli-out.h: Revert.
1860         * cli-out.c: Revert.
1861         * charset.c: Revert.
1862         * c-varobj.c: Revert.
1863         * c-valprint.c: Revert.
1864         * c-typeprint.c: Revert.
1865         * c-lang.c: Revert.
1866         * buildsym.c: Revert.
1867         * buildsym-legacy.c: Revert.
1868         * build-id.h: Revert.
1869         * build-id.c: Revert.
1870         * btrace.c: Revert.
1871         * bsd-uthread.c: Revert.
1872         * breakpoint.h: Revert.
1873         * breakpoint.c: Revert.
1874         * break-catch-throw.c: Revert.
1875         * break-catch-syscall.c: Revert.
1876         * break-catch-sig.c: Revert.
1877         * blockframe.c: Revert.
1878         * block.c: Revert.
1879         * bfin-tdep.c: Revert.
1880         * bfin-linux-tdep.c: Revert.
1881         * bfd-target.c: Revert.
1882         * bcache.c: Revert.
1883         * ax-general.c: Revert.
1884         * ax-gdb.h: Revert.
1885         * ax-gdb.c: Revert.
1886         * avr-tdep.c: Revert.
1887         * auxv.c: Revert.
1888         * auto-load.c: Revert.
1889         * arm-wince-tdep.c: Revert.
1890         * arm-tdep.c: Revert.
1891         * arm-symbian-tdep.c: Revert.
1892         * arm-pikeos-tdep.c: Revert.
1893         * arm-obsd-tdep.c: Revert.
1894         * arm-nbsd-tdep.c: Revert.
1895         * arm-nbsd-nat.c: Revert.
1896         * arm-linux-tdep.c: Revert.
1897         * arm-linux-nat.c: Revert.
1898         * arm-fbsd-tdep.c: Revert.
1899         * arm-fbsd-nat.c: Revert.
1900         * arm-bsd-tdep.c: Revert.
1901         * arch-utils.c: Revert.
1902         * arc-tdep.c: Revert.
1903         * arc-newlib-tdep.c: Revert.
1904         * annotate.h: Revert.
1905         * annotate.c: Revert.
1906         * amd64-windows-tdep.c: Revert.
1907         * amd64-windows-nat.c: Revert.
1908         * amd64-tdep.c: Revert.
1909         * amd64-sol2-tdep.c: Revert.
1910         * amd64-obsd-tdep.c: Revert.
1911         * amd64-obsd-nat.c: Revert.
1912         * amd64-nbsd-tdep.c: Revert.
1913         * amd64-nbsd-nat.c: Revert.
1914         * amd64-nat.c: Revert.
1915         * amd64-linux-tdep.c: Revert.
1916         * amd64-linux-nat.c: Revert.
1917         * amd64-fbsd-tdep.c: Revert.
1918         * amd64-fbsd-nat.c: Revert.
1919         * amd64-dicos-tdep.c: Revert.
1920         * amd64-darwin-tdep.c: Revert.
1921         * amd64-bsd-nat.c: Revert.
1922         * alpha-tdep.c: Revert.
1923         * alpha-obsd-tdep.c: Revert.
1924         * alpha-nbsd-tdep.c: Revert.
1925         * alpha-mdebug-tdep.c: Revert.
1926         * alpha-linux-tdep.c: Revert.
1927         * alpha-linux-nat.c: Revert.
1928         * alpha-bsd-tdep.c: Revert.
1929         * alpha-bsd-nat.c: Revert.
1930         * aix-thread.c: Revert.
1931         * agent.c: Revert.
1932         * addrmap.c: Revert.
1933         * ada-varobj.c: Revert.
1934         * ada-valprint.c: Revert.
1935         * ada-typeprint.c: Revert.
1936         * ada-tasks.c: Revert.
1937         * ada-lang.c: Revert.
1938         * aarch64-tdep.c: Revert.
1939         * aarch64-ravenscar-thread.c: Revert.
1940         * aarch64-newlib-tdep.c: Revert.
1941         * aarch64-linux-tdep.c: Revert.
1942         * aarch64-linux-nat.c: Revert.
1943         * aarch64-fbsd-tdep.c: Revert.
1944         * aarch64-fbsd-nat.c: Revert.
1945         * aarch32-linux-nat.c: Revert.
1946
1947 2019-04-05  Tom Tromey  <tom@tromey.com>
1948
1949         * ft32-tdep.c: Sort headers.
1950         * frv-tdep.c: Sort headers.
1951         * frv-linux-tdep.c: Sort headers.
1952         * frame.c: Sort headers.
1953         * frame-unwind.c: Sort headers.
1954         * frame-base.c: Sort headers.
1955         * fork-child.c: Sort headers.
1956         * findvar.c: Sort headers.
1957         * findcmd.c: Sort headers.
1958         * filesystem.c: Sort headers.
1959         * filename-seen-cache.h: Sort headers.
1960         * filename-seen-cache.c: Sort headers.
1961         * fbsd-tdep.c: Sort headers.
1962         * fbsd-nat.h: Sort headers.
1963         * fbsd-nat.c: Sort headers.
1964         * f-valprint.c: Sort headers.
1965         * f-typeprint.c: Sort headers.
1966         * f-lang.c: Sort headers.
1967         * extension.h: Sort headers.
1968         * extension.c: Sort headers.
1969         * extension-priv.h: Sort headers.
1970         * expprint.c: Sort headers.
1971         * exec.h: Sort headers.
1972         * exec.c: Sort headers.
1973         * exceptions.c: Sort headers.
1974         * event-top.c: Sort headers.
1975         * event-loop.c: Sort headers.
1976         * eval.c: Sort headers.
1977         * elfread.c: Sort headers.
1978         * dwarf2read.h: Sort headers.
1979         * dwarf2read.c: Sort headers.
1980         * dwarf2loc.c: Sort headers.
1981         * dwarf2expr.h: Sort headers.
1982         * dwarf2expr.c: Sort headers.
1983         * dwarf2-frame.c: Sort headers.
1984         * dwarf2-frame-tailcall.c: Sort headers.
1985         * dwarf-index-write.h: Sort headers.
1986         * dwarf-index-write.c: Sort headers.
1987         * dwarf-index-common.c: Sort headers.
1988         * dwarf-index-cache.h: Sort headers.
1989         * dwarf-index-cache.c: Sort headers.
1990         * dummy-frame.c: Sort headers.
1991         * dtrace-probe.c: Sort headers.
1992         * disasm.h: Sort headers.
1993         * disasm.c: Sort headers.
1994         * disasm-selftests.c: Sort headers.
1995         * dictionary.c: Sort headers.
1996         * dicos-tdep.c: Sort headers.
1997         * demangle.c: Sort headers.
1998         * dcache.h: Sort headers.
1999         * dcache.c: Sort headers.
2000         * darwin-nat.h: Sort headers.
2001         * darwin-nat.c: Sort headers.
2002         * darwin-nat-info.c: Sort headers.
2003         * d-valprint.c: Sort headers.
2004         * d-namespace.c: Sort headers.
2005         * d-lang.c: Sort headers.
2006         * ctf.c: Sort headers.
2007         * csky-tdep.c: Sort headers.
2008         * csky-linux-tdep.c: Sort headers.
2009         * cris-tdep.c: Sort headers.
2010         * cris-linux-tdep.c: Sort headers.
2011         * cp-valprint.c: Sort headers.
2012         * cp-support.c: Sort headers.
2013         * cp-namespace.c: Sort headers.
2014         * cp-abi.c: Sort headers.
2015         * corelow.c: Sort headers.
2016         * corefile.c: Sort headers.
2017         * continuations.c: Sort headers.
2018         * completer.h: Sort headers.
2019         * completer.c: Sort headers.
2020         * complaints.c: Sort headers.
2021         * coffread.c: Sort headers.
2022         * coff-pe-read.c: Sort headers.
2023         * cli-out.h: Sort headers.
2024         * cli-out.c: Sort headers.
2025         * charset.c: Sort headers.
2026         * c-varobj.c: Sort headers.
2027         * c-valprint.c: Sort headers.
2028         * c-typeprint.c: Sort headers.
2029         * c-lang.c: Sort headers.
2030         * buildsym.c: Sort headers.
2031         * buildsym-legacy.c: Sort headers.
2032         * build-id.h: Sort headers.
2033         * build-id.c: Sort headers.
2034         * btrace.c: Sort headers.
2035         * bsd-uthread.c: Sort headers.
2036         * breakpoint.h: Sort headers.
2037         * breakpoint.c: Sort headers.
2038         * break-catch-throw.c: Sort headers.
2039         * break-catch-syscall.c: Sort headers.
2040         * break-catch-sig.c: Sort headers.
2041         * blockframe.c: Sort headers.
2042         * block.c: Sort headers.
2043         * bfin-tdep.c: Sort headers.
2044         * bfin-linux-tdep.c: Sort headers.
2045         * bfd-target.c: Sort headers.
2046         * bcache.c: Sort headers.
2047         * ax-general.c: Sort headers.
2048         * ax-gdb.h: Sort headers.
2049         * ax-gdb.c: Sort headers.
2050         * avr-tdep.c: Sort headers.
2051         * auxv.c: Sort headers.
2052         * auto-load.c: Sort headers.
2053         * arm-wince-tdep.c: Sort headers.
2054         * arm-tdep.c: Sort headers.
2055         * arm-symbian-tdep.c: Sort headers.
2056         * arm-pikeos-tdep.c: Sort headers.
2057         * arm-obsd-tdep.c: Sort headers.
2058         * arm-nbsd-tdep.c: Sort headers.
2059         * arm-nbsd-nat.c: Sort headers.
2060         * arm-linux-tdep.c: Sort headers.
2061         * arm-linux-nat.c: Sort headers.
2062         * arm-fbsd-tdep.c: Sort headers.
2063         * arm-fbsd-nat.c: Sort headers.
2064         * arm-bsd-tdep.c: Sort headers.
2065         * arch-utils.c: Sort headers.
2066         * arc-tdep.c: Sort headers.
2067         * arc-newlib-tdep.c: Sort headers.
2068         * annotate.h: Sort headers.
2069         * annotate.c: Sort headers.
2070         * amd64-windows-tdep.c: Sort headers.
2071         * amd64-windows-nat.c: Sort headers.
2072         * amd64-tdep.c: Sort headers.
2073         * amd64-sol2-tdep.c: Sort headers.
2074         * amd64-obsd-tdep.c: Sort headers.
2075         * amd64-obsd-nat.c: Sort headers.
2076         * amd64-nbsd-tdep.c: Sort headers.
2077         * amd64-nbsd-nat.c: Sort headers.
2078         * amd64-nat.c: Sort headers.
2079         * amd64-linux-tdep.c: Sort headers.
2080         * amd64-linux-nat.c: Sort headers.
2081         * amd64-fbsd-tdep.c: Sort headers.
2082         * amd64-fbsd-nat.c: Sort headers.
2083         * amd64-dicos-tdep.c: Sort headers.
2084         * amd64-darwin-tdep.c: Sort headers.
2085         * amd64-bsd-nat.c: Sort headers.
2086         * alpha-tdep.c: Sort headers.
2087         * alpha-obsd-tdep.c: Sort headers.
2088         * alpha-nbsd-tdep.c: Sort headers.
2089         * alpha-mdebug-tdep.c: Sort headers.
2090         * alpha-linux-tdep.c: Sort headers.
2091         * alpha-linux-nat.c: Sort headers.
2092         * alpha-bsd-tdep.c: Sort headers.
2093         * alpha-bsd-nat.c: Sort headers.
2094         * aix-thread.c: Sort headers.
2095         * agent.c: Sort headers.
2096         * addrmap.c: Sort headers.
2097         * ada-varobj.c: Sort headers.
2098         * ada-valprint.c: Sort headers.
2099         * ada-typeprint.c: Sort headers.
2100         * ada-tasks.c: Sort headers.
2101         * ada-lang.c: Sort headers.
2102         * aarch64-tdep.c: Sort headers.
2103         * aarch64-ravenscar-thread.c: Sort headers.
2104         * aarch64-newlib-tdep.c: Sort headers.
2105         * aarch64-linux-tdep.c: Sort headers.
2106         * aarch64-linux-nat.c: Sort headers.
2107         * aarch64-fbsd-tdep.c: Sort headers.
2108         * aarch64-fbsd-nat.c: Sort headers.
2109         * aarch32-linux-nat.c: Sort headers.
2110
2111 2019-04-04  Tom Tromey  <tom@tromey.com>
2112
2113         * varobj.c (varobj_create): Update.
2114         * rust-exp.y (struct rust_parser) <update_innermost_block,
2115         lookup_symbol>: New methods.
2116         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2117         Rename.
2118         (rust_parser::rust_lookup_type)
2119         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2120         * printcmd.c (display_command, do_one_display): Update.
2121         * parser-defs.h (struct parser_state) <parser_state>: Add
2122         "tracker" parameter.
2123         (block_tracker): New member.
2124         (class innermost_block_tracker) <innermost_block_tracker>: Add
2125         "types" parameter.
2126         <reset>: Remove method.
2127         (innermost_block): Don't declare.
2128         (null_post_parser): Update.
2129         * parse.c (innermost_block): Remove global.
2130         (write_dollar_variable): Update.
2131         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2132         Remove "tracker_types" parameter.
2133         (parse_expression): Add "tracker" parameter.
2134         (parse_expression_for_completion): Update.
2135         (null_post_parser): Add "tracker" parameter.
2136         * p-exp.y: Update rules.
2137         * m2-exp.y: Update rules.
2138         * language.h (struct language_defn) <la_post_parser>: Add
2139         "tracker" parameter.
2140         * go-exp.y: Update rules.
2141         * f-exp.y: Update rules.
2142         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2143         parameter.
2144         * d-exp.y: Update rules.
2145         * c-exp.y: Update rules.
2146         * breakpoint.c (set_breakpoint_condition): Create an
2147         innermost_block_tracker.
2148         (watch_command_1): Likewise.
2149         * ada-lang.c (resolve): Add "tracker" parameter.
2150         (resolve_subexp): Likewise.
2151         * ada-exp.y (write_var_from_sym): Update.
2152
2153 2019-04-04  Tom Tromey  <tom@tromey.com>
2154
2155         * type-stack.h: New file.
2156         * type-stack.c: New file.
2157         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2158         type-stack.h.
2159         (insert_into_type_stack, insert_type, push_type, push_type_int)
2160         (insert_type_address_space, pop_type, pop_type_int)
2161         (pop_typelist, pop_type_stack, append_type_stack)
2162         (push_type_stack, get_type_stack, push_typelist)
2163         (follow_type_instance_flags, follow_types): Don't declare.
2164         * parse.c (type_stack): Remove global.
2165         (parse_exp_in_context): Update.
2166         (insert_into_type_stack, insert_type, push_type, push_type_int)
2167         (insert_type_address_space, pop_type, pop_type_int)
2168         (pop_typelist, pop_type_stack, append_type_stack)
2169         (push_type_stack, get_type_stack, push_typelist)
2170         (follow_type_instance_flags, follow_types): Remove (moved to
2171         type-stack.c).
2172         * f-exp.y (type_stack): New global.
2173         Update rules.
2174         (push_kind_type, f_parse): Update.
2175         * d-exp.y (type_stack): New global.
2176         Update rules.
2177         (d_parse): Update.
2178         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2179         Update rules.
2180         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2181         (HFILES_NO_SRCDIR): Add type-stack.h.
2182
2183 2019-04-04  Tom Tromey  <tom@tromey.com>
2184
2185         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2186         (rust_parser::convert_ast_to_expression, rust_parse)
2187         (rust_lex_test_completion, rust_lex_tests): Update.
2188         * parser-defs.h (struct expr_completion_state): New.
2189         (struct parser_state) <parser_state>: Add completion parameter.
2190         <mark_struct_expression, mark_completion_tag>: New methods.
2191         <parse_completion, m_completion_state>: New members.
2192         (prefixify_expression, null_post_parser): Update.
2193         (mark_struct_expression, mark_completion_tag): Don't declare.
2194         * parse.c (parse_completion, expout_last_struct)
2195         (expout_tag_completion_type, expout_completion_name): Remove
2196         globals.
2197         (parser_state::mark_struct_expression)
2198         (parser_state::mark_completion_tag): Now methods.
2199         (prefixify_expression): Add last_struct parameter.
2200         (prefixify_subexp): Likewise.
2201         (parse_exp_1): Update.
2202         (parse_exp_in_context): Add cstate parameter.  Update.
2203         (parse_expression_for_completion): Create an
2204         expr_completion_state.
2205         (null_post_parser): Add "completion" parameter.
2206         * p-exp.y: Update rules.
2207         (yylex): Update.
2208         * language.h (struct language_defn) <la_post_parser>: Add
2209         "completing" parameter.
2210         * go-exp.y: Update rules.
2211         (lex_one_token): Update.
2212         * expression.h (parse_completion): Don't declare.
2213         * d-exp.y: Update rules.
2214         (lex_one_token): Update rules.
2215         * c-exp.y: Update rules.
2216         (lex_one_token): Update.
2217         * ada-lang.c (resolve): Add "parse_completion" parameter.
2218         (resolve_subexp): Likewise.
2219         (ada_resolve_function): Likewise.
2220
2221 2019-04-04  Tom Tromey  <tom@tromey.com>
2222
2223         * parser-defs.h (struct parser_state) <start_arglist,
2224         end_arglist>: New methods.
2225         <arglist_len, m_funcall_chain>: New members.
2226         (arglist_len, start_arglist, end_arglist): Don't declare.
2227         * parse.c (arglist_len, funcall_chain): Remove global.
2228         (start_arglist, end_arglist): Remove functions.
2229         (parse_exp_in_context): Update.
2230         * p-exp.y: Update rules.
2231         * m2-exp.y: Update rules.
2232         * go-exp.y: Update rules.
2233         * f-exp.y: Update rules.
2234         * d-exp.y: Update rules.
2235         * c-exp.y: Update rules.
2236
2237 2019-04-04  Tom Tromey  <tom@tromey.com>
2238
2239         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2240         lex_operator, push_back>: New methods.
2241         Update all rules.
2242         (rust_parser::lex_hex, lex_escape): Rename and update.
2243         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2244         (rust_parser::lex_operator): Rename and update.
2245         (rust_parser::lex_number, rustyylex, rustyyerror)
2246         (rust_lex_test_init, rust_lex_test_sequence)
2247         (rust_lex_test_push_back, rust_lex_tests): Update.
2248         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2249         parameter.
2250         <lexptr, prev_lexptr>: New members.
2251         (lexptr, prev_lexptr): Don't declare.
2252         * parse.c (lexptr, prev_lexptr): Remove globals.
2253         (parse_exp_in_context): Update.
2254         * p-exp.y (yylex, yyerror): Update.
2255         * m2-exp.y (parse_number, yylex, yyerror): Update.
2256         * go-exp.y (lex_one_token, yyerror): Update.
2257         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2258         * d-exp.y (lex_one_token, yyerror): Update.
2259         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2260         (lex_one_token, yyerror): Update.
2261         * ada-lex.l (YY_INPUT): Update.
2262         (rewind_to_char): Update.
2263         * ada-exp.y (yyerror): Update.
2264
2265 2019-04-04  Tom Tromey  <tom@tromey.com>
2266
2267         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2268         * parser-defs.h (struct parser_state) <parser_state>: Add new
2269         parameter.
2270         <comma_terminates>: New member.
2271         (comma_terminates): Don't declare global.
2272         * parse.c (comma_terminates): Remove global.
2273         (parse_exp_in_context): Update.
2274         * p-exp.y (yylex): Update.
2275         * m2-exp.y (yylex): Update.
2276         * go-exp.y (lex_one_token): Update.
2277         * f-exp.y (yylex): Update.
2278         * d-exp.y (lex_one_token): Update.
2279         * c-exp.y (lex_one_token): Update.
2280         * ada-lex.l: Update.
2281
2282 2019-04-04  Tom Tromey  <tom@tromey.com>
2283
2284         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2285         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2286         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2287         * parser-defs.h (paren_depth): Don't declare.
2288         * parse.c (paren_depth): Remove global.
2289         (parse_exp_in_context): Update.
2290         * p-exp.y (paren_depth): New global.
2291         (pascal_parse): Initialize it.
2292         * m2-exp.y (paren_depth): New global.
2293         (m2_parse): Initialize it.
2294         * go-exp.y (paren_depth): New global.
2295         (go_parse): Initialize it.
2296         * f-exp.y (paren_depth): New global.
2297         (f_parse): Initialize it.
2298         * d-exp.y (paren_depth): New global.
2299         (d_parse): Initialize it.
2300         * c-exp.y (paren_depth): New global.
2301         (c_parse): Initialize it.
2302         * ada-lex.l (paren_depth): New global.
2303         (lexer_init): Initialize it.
2304
2305 2019-04-04  Tom Tromey  <tom@tromey.com>
2306
2307         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2308         (rust_parser::convert_ast_to_type)
2309         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2310         * parser-defs.h (struct parser_state) <parser_state>: Add
2311         parameters.  Initialize new members.
2312         <expression_context_block, expression_context_pc>: New members.
2313         * parse.c (expression_context_block, expression_context_pc):
2314         Remove globals.
2315         (parse_exp_in_context): Update.
2316         * p-exp.y: Update all rules.
2317         (yylex): Update.
2318         * m2-exp.y: Update all rules.
2319         (yylex): Update.
2320         * go-exp.y (yylex): Update.
2321         * f-exp.y (yylex): Update.
2322         * d-exp.y: Update all rules.
2323         (yylex): Update.
2324         * c-exp.y: Update all rules.
2325         (lex_one_token, classify_name, yylex, c_parse): Update.
2326         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2327
2328 2019-04-04  Tom Tromey  <tom@tromey.com>
2329
2330         * gdbarch.h, gdbarch.c: Rebuild.
2331         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2332         * stap-probe.h:
2333         (struct stap_parse_info): Replace "parser_state" with
2334         "expr_builder".
2335         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2336         (parser_state): New class.
2337         * parse.c (expr_builder): Rename.
2338         (expr_builder::release): Rename.
2339         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2340         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2341         (write_exp_elt_longcst, write_exp_elt_floatcst)
2342         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2343         (write_exp_string_vector, write_exp_bitstring)
2344         (write_exp_msymbol, mark_struct_expression)
2345         (write_dollar_variable)
2346         (insert_type_address_space, increase_expout_size): Replace
2347         "parser_state" with "expr_builder".
2348         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2349         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2350         "parser_state" with "expr_builder".
2351
2352 2019-04-04  Tom Tromey  <tom@tromey.com>
2353
2354         * rust-exp.y: Replace "parse_language" with method call.
2355         * p-exp.y:
2356         (yylex): Replace "parse_language" with method call.
2357         * m2-exp.y:
2358         (yylex): Replace "parse_language" with method call.
2359         * go-exp.y (classify_name): Replace "parse_language" with method
2360         call.
2361         * f-exp.y (yylex): Replace "parse_language" with method call.
2362         * d-exp.y (lex_one_token): Replace "parse_language" with method
2363         call.
2364         * c-exp.y:
2365         (lex_one_token, classify_name, yylex): Replace "parse_language"
2366         with method call.
2367         * ada-exp.y (find_primitive_type, type_char)
2368         (type_system_address): Replace "parse_language" with method call.
2369
2370 2019-04-04  Tom Tromey  <tom@tromey.com>
2371
2372         * rust-exp.y: Replace "parse_gdbarch" with method call.
2373         * parse.c (write_dollar_variable, insert_type_address_space):
2374         Replace "parse_gdbarch" with method call.
2375         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2376         call.
2377         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2378         call.
2379         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2380         "parse_gdbarch" with method call.
2381         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2382         with method call.
2383         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2384         "parse_gdbarch" with method call.
2385         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2386         "parse_gdbarch" with method call.
2387         * c-exp.y (parse_type, parse_number, classify_name): Replace
2388         "parse_gdbarch" with method call.
2389         * ada-lex.l: Replace "parse_gdbarch" with method call.
2390         * ada-exp.y (parse_type, find_primitive_type, type_char)
2391         (type_system_address): Replace "parse_gdbarch" with method call.
2392
2393 2019-04-04  Tom Tromey  <tom@tromey.com>
2394
2395         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2396         * stap-probe.c (stap_parse_argument): Update.
2397         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2398         initial_size parameter.
2399         * rust-exp.y (rust_lex_tests): Update.
2400         * parse.c (parser_state): Update.
2401         (parse_exp_in_context): Update.
2402         * parser-defs.h (struct parser_state) <parser_state>: Remove
2403         "initial_size" parameter.
2404
2405 2019-04-04  Tom Tromey  <tom@tromey.com>
2406
2407         * parser-defs.h (increase_expout_size): Don't declare.
2408         * parse.c (increase_expout_size): Now static.
2409
2410 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2411
2412         * gnu-nat.c (gnu_nat_target::wait): Fix
2413         target_waitstatus_to_string call.
2414
2415 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2416
2417         * eval.c (evaluate_subexp_standard): Handle internal functions
2418         during Fortran function call handling.
2419
2420 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2421
2422         * NEWS: Mention new internal functions.
2423         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2424         (read_base_type): Use dwarf2_init_complex_target_type.
2425         * value.c (creal_internal_fn): New function.
2426         (cimag_internal_fn): New function.
2427         (_initialize_values): Register new internal functions.
2428
2429 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2430
2431         * infrun.c (stop_all_threads): If debug_infrun, always
2432         trace the wait status after wait_one, using
2433         target_waitstatus_to_string and target_pid_to_str.
2434         (handle_inferior_event): Replace various trace of
2435         wait status kind by a single trace.
2436         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2437         wait status kind image by target_waitstatus_to_string.
2438         * target/waitstatus.c (target_waitstatus_to_string): Fix
2439         obsolete comment.
2440
2441 2019-04-01  Tom Tromey  <tromey@adacore.com>
2442
2443         PR symtab/23331:
2444         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2445
2446 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2447             Pedro Alves  <palves@redhat.com>
2448
2449         * top.c (quit_force): Call 'finalize_values'.
2450         * value.c (finalize_values): New function.
2451         * value.h (finalize_values): Declare.
2452
2453 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2454
2455         * NEWS: Announce $_gdb_major and $_gdb_minor.
2456
2457         * top.c (init_gdb_version_vars): New function.
2458         (gdb_init): Call init_gdb_version_vars.
2459
2460 2019-03-29  Tom Tromey  <tromey@adacore.com>
2461
2462         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2463         help text.  Remove dead code.
2464
2465 2019-03-29  Keith Seitz  <keiths@redhat.com>
2466
2467         From Siddhesh Poyarekar:
2468         * f-lang.h (f77_get_upperbound): Return LONGEST.
2469         (f77_get_lowerbound): Likewise.
2470         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2471         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2472         print them.
2473         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2474         plongest to format print it.
2475         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2476         (f77_get_upperbound): Likewise.
2477         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2478         LOWER_BOUND to LONGEST.
2479         (f77_create_arrayprint_offset_tbl): Likewise.
2480
2481 2019-03-29  Keith Seitz  <keiths@redhat.com>
2482
2483         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2484         %s/pulongest for TYPE_LENGTH instead of %d in format
2485         strings.
2486         * ada-typerint.c (ada_print_type): Likewise.
2487         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2488         * compile/compile-c-support.c (generate_register_struct): Likewise.
2489         * gdbtypes.c (recursive_dump_type): Likewise.
2490         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2491         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2492         instead of %d in format strings.
2493         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2494         to std::min to ULONGEST.
2495         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2496         instead of %d in format strings.
2497         * tracepoint.c (info_scope_command): Likewise.
2498         * typeprint.c (print_offset_data::update)
2499         (print_offset_data::finish): Likewise.
2500         * xtensa-tdep.c (xtensa_store_return_value)
2501         (xtensa_push_dummy_call): Likewise.
2502
2503 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2504
2505         * windows-nat.c (display_selector): Fixed format specifications
2506         for 64-bit Cygwin.
2507
2508 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2509
2510         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2511
2512 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2513
2514         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2515         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2516         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2517         (nios2_linux_init_abi): Install it.
2518
2519 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2520
2521         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2522
2523 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2524
2525         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2526
2527 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2528             Tom Tromey  <tromey@adacore.com>
2529
2530         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2531
2532 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2533
2534         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2535         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2536         method to compute the bounds of range types. Also print "[evaluated]"
2537         if the bounds' values come from a dynamic evaluation.
2538
2539 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2540
2541         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2542         whitespace when pretty printing is on.
2543
2544 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2545
2546         * ppc-linux-nat.c: Add include.
2547
2548 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2549
2550         * NEWS: Mention AArch64 Pointer Authentication.
2551
2552 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2553
2554         * arm-linux-nat.c: Add include.
2555
2556 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2557
2558         * source-cache.c (source_cache::get_source_lines): Re-read
2559         fullname after calling open_source_file.
2560
2561 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2562
2563         * NEWS: Mention TLS support for FreeBSD.
2564
2565 2019-03-25  Tom Tromey  <tromey@adacore.com>
2566
2567         * minsyms.c (BUNCH_SIZE): Update comment.
2568         (~minimal_symbol_reader): Remove old comment.
2569         (compact_minimal_symbols): Update comment.
2570         (minimal_symbol_reader::install): Remove old comment.  Update
2571         other comments.
2572
2573 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2574
2575         * s390-linux-nat.c: Add include.
2576
2577 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2578
2579         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2580         Call linux_get_hwcap.
2581         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2582         Likewise.
2583         (aarch64_linux_get_hwcap): Remove function.
2584         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2585         declaration.
2586         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2587         linux_get_hwcap.
2588         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2589         * linux-tdep.c (linux_get_hwcap): Add function.
2590         (linux_get_hwcap2): Likewise.
2591         * linux-tdep.h (linux_get_hwcap): Add declaration.
2592         (linux_get_hwcap2): Likewise.
2593         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2594         (ppc_linux_get_hwcap2): Likewise.
2595         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2596         linux_get_hwcap.
2597         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2598         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2599         (ppc_linux_nat_target::read_description): Likewise.
2600         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2601         * s390-linux-nat.c: Likewise.
2602         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2603
2604 2019-03-24  Tom Tromey  <tom@tromey.com>
2605
2606         * ada-lang.c (standard_lookup): Simplify initialization.
2607         (ada_lookup_symbol_nonlocal): Simplify return.
2608         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2609         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2610         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2611         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2612         initialization.
2613         * solib.c (solib_global_lookup): Simplify.
2614         * symtab.c (null_block_symbol): Remove.
2615         (symbol_cache_lookup): Simplify returns.
2616         (lookup_language_this): Simplify returns.
2617         (lookup_symbol_aux): Simplify return.
2618         (lookup_local_symbol): Simplify returns.
2619         (lookup_global_symbol_from_objfile): Simplify return.
2620         (lookup_symbol_in_objfile_symtabs)
2621         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2622         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2623         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2624         * cp-namespace.c (cp_lookup_bare_symbol)
2625         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2626         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2627         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2628         (cp_lookup_symbol_via_imports): Simplify initialization.
2629         (find_symbol_in_baseclass): Likewise.
2630         * symtab.h (null_block_symbol): Remove.
2631         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2632         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2633         (d_lookup_symbol_module): Likewise.
2634         (find_symbol_in_baseclass): Simplify initialization.
2635
2636 2019-03-24  Tom Tromey  <tom@tromey.com>
2637
2638         * expression.h: Don't include symtab.h.
2639         (struct block): Forward declare.
2640
2641 2019-03-24  Tom Tromey  <tom@tromey.com>
2642
2643         * c-exp.y (typebase): Remove casts.
2644         * gdbtypes.c (lookup_unsigned_typename, )
2645         (lookup_signed_typename): Remove cast.
2646         * eval.c (parse_to_comma_and_eval): Remove cast.
2647         * parse.c (write_dollar_variable): Remove cast.
2648         * block.h (struct block) <superblock>: Now const.
2649         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2650         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2651         (map_block): Make "block" const.
2652         * symfile.h (struct quick_symbol_functions)
2653         <map_matching_symbols>: Constify block argument to "callback".
2654         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2655         const.
2656         (find_pc_sect_compunit_symtab): Make "b" const.
2657         (find_symbol_at_address): Likewise.
2658         (search_symbols): Likewise.
2659         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2660         (dw2_debug_names_lookup_symbol): Likewise.
2661         (dw2_map_matching_symbols): Update.
2662         * p-valprint.c (pascal_val_print): Remove "block".
2663         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2664         (aux_add_nonlocal_symbols): Make "block" const.
2665         (resolve_subexp): Remove cast.
2666         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2667         const.
2668         (iterate_over_file_blocks): Likewise.
2669         * f-exp.y (%union) <bval>: Remove.
2670         * coffread.c (patch_opaque_types): Make "b" const.
2671         * spu-tdep.c (spu_catch_start): Make "block" const.
2672         * c-valprint.c (print_unpacked_pointer): Remove "block".
2673         * symmisc.c (dump_symtab_1): Make "b" const.
2674         (block_depth): Make "block" const.
2675         * d-exp.y (%union) <bval>: Remove.
2676         * cp-support.h (cp_lookup_rtti_type): Update.
2677         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2678         * psymtab.c (psym_lookup_symbol): Make "block" const.
2679         (maintenance_check_psymtabs): Make "b" const.
2680         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2681         (enumerate_locals, enumerate_args): Update.
2682         * python/py-symtab.c (stpy_global_block): Make "block" const.
2683         (stpy_static_block): Likewise.
2684         * inline-frame.c (block_starting_point_at): Make "new_block"
2685         const.
2686         * block.c (find_block_in_blockvector): Make return type const.
2687         (blockvector_for_pc_sect): Make "b" const.
2688         (find_block_in_blockvector): Make "b" const.
2689
2690 2019-03-23  Tom Tromey  <tom@tromey.com>
2691
2692         * varobj.c (varobj_create): Update.
2693         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2694         * printcmd.c (display_command, do_one_display): Don't reset
2695         innermost_block.
2696         * parser-defs.h (enum innermost_block_tracker_type): Move to
2697         expression.h.
2698         (innermost_block): Update comment.
2699         * parse.c (parse_exp_1): Add tracker_types parameter.
2700         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2701         tracker_types parameter.  Reset innermost_block.
2702         (parse_exp_in_context): Remove.
2703         (parse_expression_for_completion): Update.
2704         * objfiles.c (~objfile): Don't reset expression_context_block or
2705         innermost_block.
2706         * expression.h (enum innermost_block_tracker_type): Move from
2707         parser-defs.h.
2708         (parse_exp_1): Add tracker_types parameter.
2709         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2710         reset innermost_block.
2711
2712 2019-03-23  Tom Tromey  <tom@tromey.com>
2713
2714         * objfiles.h: Include bcache.h.
2715
2716 2019-03-23  Tom Tromey  <tom@tromey.com>
2717
2718         * linespec.c (get_current_search_block): Use
2719         scoped_restore_current_language.
2720         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2721
2722 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2723             Jiong Wang  <jiong.wang@arm.com>
2724
2725         * aarch64-linux-tdep.c
2726         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2727         section.
2728         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2729
2730 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2731             Jiong Wang  <jiong.wang@arm.com>
2732
2733         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2734         instructions.
2735         (aarch64_analyze_prologue_test): Add PACIASP test.
2736         (aarch64_prologue_prev_register): Unmask PC value.
2737
2738 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2739             Jiong Wang  <jiong.wang@arm.com>
2740
2741         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2742         (aarch64_dwarf2_prev_register): Unmask PC value.
2743         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2744         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2745         DW_CFA_AARCH64_negate_ra_state.
2746         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2747
2748 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2749             Jiong Wang  <jiong.wang@arm.com>
2750
2751         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2752         registers.
2753         (aarch64_pseudo_register_name): Likewise.
2754         (aarch64_pseudo_register_type): Likewise.
2755         (aarch64_pseudo_register_reggroup_p): Likewise.
2756         (aarch64_gdbarch_init): Add pauth registers.
2757         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2758         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2759         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2760         (struct gdbarch_tdep): Add regnum for ra_state.
2761
2762 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2763             Jiong Wang  <jiong.wang@arm.com>
2764
2765         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2766
2767 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2768             Jiong Wang  <jiong.wang@arm.com>
2769
2770         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2771         function.
2772         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2773         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2774         (aarch64_gdbarch_init): Add puth registers.
2775         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2776         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2777         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2778
2779 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2780             Jiong Wang  <jiong.wang@arm.com>
2781
2782         * aarch64-linux-nat.c
2783         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2784         * aarch64-linux-tdep.c
2785         (aarch64_linux_core_read_description): Likewise.
2786         (aarch64_linux_get_hwcap): New function.
2787         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2788         (aarch64_linux_get_hwcap): New declaration.
2789
2790 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2791             Jiong Wang  <jiong.wang@arm.com>
2792
2793         * aarch64-linux-nat.c
2794         (aarch64_linux_nat_target::read_description): Add pauth param.
2795         * aarch64-linux-tdep.c
2796         (aarch64_linux_core_read_description): Likewise.
2797         * aarch64-tdep.c (struct target_desc): Add in pauth.
2798         (aarch64_read_description): Add pauth param.
2799         (aarch64_gdbarch_init): Likewise.
2800         * aarch64-tdep.h (aarch64_read_description): Likewise.
2801         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2802         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2803         * features/Makefile: Add new files.
2804         * features/aarch64-pauth.c: New file.
2805         * features/aarch64-pauth.xml: New file.
2806
2807 2019-03-20  Tom Tromey  <tromey@adacore.com>
2808
2809         * infrun.c (handle_inferior_event): Rename from
2810         handle_inferior_event_1.  Create a scoped_value_mark.
2811         (handle_inferior_event): Remove.
2812
2813 2019-03-19  Tom Tromey  <tromey@adacore.com>
2814
2815         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2816         * infrun.h (print_stop_event): Add "displays" parameter.
2817         * infrun.c (print_stop_event): Add "displays" parameter.
2818
2819 2019-03-19  Pedro Alves  <palves@redhat.com>
2820
2821         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2822         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2823         to -1.  Fix TABs vs spaces.
2824         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2825         * tui/tui-out.h (tui_ui_out) Add intro comments.
2826         <m_line, m_start_of_line>: In-class initialize, and add describing
2827         comment.
2828
2829 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2830
2831         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2832         variable names.
2833         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2834
2835 2019-03-18  Pedro Alves  <palves@redhat.com>
2836             Eli Zaretskii <eliz@gnu.org>
2837
2838         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2839         m_line and m_start_of_line.
2840
2841 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2842
2843         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2844         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2845         it returns a newline.  This fixes a regression in TU mode, whereby
2846         the next line is output on the same screen line as the user input.
2847
2848 2019-03-18  Tom Tromey  <tromey@adacore.com>
2849
2850         * minsyms.c (minimal_symbol_reader::install): Remove call to
2851         obstack_blank.
2852
2853 2019-03-18  Pedro Alves  <palves@redhat.com>
2854
2855         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2856         New globals.
2857         (apply_style): New, factored out from ...
2858         (apply_ansi_escape): ... this.  Handle reverse video mode.
2859         (tui_set_reverse_mode): New function.
2860         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2861         * tui/tui-winsource.c (tui_show_source_line): Use
2862         tui_set_reverse_mode instead of setting A_STANDOUT.
2863         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2864         New setter methods.
2865
2866 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2867
2868         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2869         Handle tabs.
2870
2871 2019-03-18  Tom Tromey  <tromey@adacore.com>
2872
2873         * ada-lang.c (empty_array): Add "high" parameter.
2874         (ada_evaluate_subexp): Update.
2875
2876 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2877
2878         * unittests/string_view-selftests.c: Define
2879         _initialize_string_view_selftests unconditionally.
2880
2881 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2882
2883         PR gdb/24350
2884         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2885
2886 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2887
2888         PR gdb/24351
2889         * windows-nat.c (display_selector): Fix format specifiers.
2890
2891 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2892
2893         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2894         tui_refill_source_window instead of tui_refresh_win, to update the
2895         current execution line.  This fixes redisplay of the current line
2896         when stepping through the code with "next" or "step".
2897
2898 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2899
2900         * source-cache.c (source_cache::get_source_lines): Call
2901         find_source_lines to initialize s->nlines.  This fixes vertical
2902         scrolling of TUI source window when the DOWN arrow is pressed.
2903
2904 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2905
2906         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2907         linux-thread-db.c (_initialize_thread_db): Likewise.
2908
2909 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2910
2911         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2912         wclrtoeol in tui_show_source_line".  This reverts changes made in
2913         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2914
2915 2019-03-15  Tom Tromey  <tom@tromey.com>
2916
2917         * symtab.h (struct minimal_symbol): Derive from
2918         general_symbol_info.
2919         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2920         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2921         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2922         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2923         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2924         (MSYMBOL_SEARCH_NAME): Update.
2925         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2926         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2927         * minsyms.c (minimal_symbol_reader::record_full): Update.
2928
2929 2019-03-15  Tom Tromey  <tom@tromey.com>
2930
2931         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2932
2933 2019-03-15  Tom Tromey  <tom@tromey.com>
2934
2935         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2936         unique_xmalloc_ptr.
2937         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2938         Update.
2939         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2940         (build_minimal_symbol_hash_tables)
2941         (minimal_symbol_reader::install): Update.
2942
2943 2019-03-15  Tom Tromey  <tom@tromey.com>
2944
2945         * symtab.c (create_demangled_names_hash): Update.
2946         (symbol_set_names): Update.
2947         * objfiles.h (struct objfile_per_bfd_storage)
2948         <demangled_names_hash>: Now an htab_up.
2949         * objfiles.c (objfile_per_bfd_storage): Simplify.
2950
2951 2019-03-15  Tom Tromey  <tom@tromey.com>
2952
2953         * objfiles.h (struct objfile_per_bfd_storage): Declare
2954         destructor.
2955         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2956         New.
2957         (get_objfile_bfd_data): Use new.  Don't initialize
2958         language_of_main.
2959         (free_objfile_per_bfd_storage): Remove.
2960         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2961
2962 2019-03-15  Tom Tromey  <tom@tromey.com>
2963
2964         * symfile.c (reread_symbols): Update.
2965         * objfiles.c (objfile::objfile): Update.
2966         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2967         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2968         comment.
2969         (minimal_symbol_reader::install): Update.
2970         (terminate_minimal_symbol_table): Remove.
2971         * jit.c (jit_object_close_impl): Update.
2972
2973 2019-03-15  Tom Tromey  <tom@tromey.com>
2974
2975         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2976         initializations.
2977
2978 2019-03-15  Tom Tromey  <tom@tromey.com>
2979
2980         * objfiles.h (struct objfile_per_bfd_storage)
2981         <demangled_hash_languages>: Now a bitset.
2982         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2983         (lookup_minimal_symbol): Update.
2984
2985 2019-03-15  Tom Tromey  <tom@tromey.com>
2986
2987         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2988         Don't return the symbol.
2989         * coffread.c (record_minimal_symbol): Use record_full.
2990
2991 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2992
2993         The MS-Windows port of ncurses fails to switch to a color pair if
2994         one or both of the colors are the implicit default colors.  This
2995         change records the default colors when TUI is initialized, and
2996         then specifies them explicitly when a color pair uses the default
2997         colors.  This allows color styling in TUI mode on MS-Windows.
2998
2999         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3000         ncurses_norm_attr.
3001         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3002         colors in ncurses_norm_attr.
3003         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3004         "none", replace it with the default color recorded in
3005         ncurses_norm_attr.
3006
3007 2019-03-14  Tom Tromey  <tromey@adacore.com>
3008
3009         * source-cache.h (class source_cache) <get_source_lines>: Return
3010         std::string.
3011         * source-cache.c (source_cache::extract_lines): Handle case where
3012         first_pos==npos.  Return std::string.
3013         (source_cache::get_source_lines): Update.
3014
3015 2019-03-14  Tom Tromey  <tromey@adacore.com>
3016
3017         * NEWS: Add item for "style sources" commands.
3018         * source-cache.c (source_cache::get_source_lines): Check
3019         source_styling.
3020         * cli/cli-style.c (source_styling): New global.
3021         (_initialize_cli_style): Add "style sources" commands.
3022         (show_style_sources): New function.
3023         * cli/cli-style.h (source_styling): Declare.
3024
3025 2019-03-14  Pedro Alves  <palves@redhat.com>
3026             Tom Tromey  <tromey@adacore.com>
3027
3028         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3029         * tui/tui-winsource.c (tui_refill_source_window): New function,
3030         from...
3031         (tui_horizontal_source_scroll): ... here.  Move some logic.
3032         * cli/cli-style.c (set_style_enabled): Notify new observable.
3033         * tui/tui-hooks.c (tui_redisplay_source): New function.
3034         (tui_attach_detach_observers): Attach or detach
3035         tui_redisplay_source.
3036         * observable.h (source_styling_changed): New observable.
3037         * observable.c: Define source_styling_changed observable.
3038
3039 2019-03-13  Tom Tromey  <tromey@adacore.com>
3040
3041         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3042         (i386_gnu_nat_target::store_registers): Update.
3043         * target-debug.h (target_debug_print_std_string): New macro.
3044         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3045         * windows-tdep.c (display_one_tib): Update.
3046         * tui/tui-stack.c (tui_make_status_line): Update.
3047         * top.c (print_inferior_quit_action): Update.
3048         * thread.c (thr_try_catch_cmd): Update.
3049         (add_thread_with_info): Update.
3050         (thread_target_id_str): Update.
3051         (thr_try_catch_cmd): Update.
3052         (thread_command): Update.
3053         (thread_find_command): Update.
3054         * record-btrace.c (record_btrace_target::info_record)
3055         (record_btrace_resume_thread, record_btrace_target::resume)
3056         (record_btrace_cancel_resume, record_btrace_step_thread)
3057         (record_btrace_target::wait, record_btrace_target::wait)
3058         (record_btrace_target::wait, record_btrace_target::stop): Update.
3059         * progspace.c (print_program_space): Update.
3060         * process-stratum-target.c
3061         (process_stratum_target::thread_address_space): Update.
3062         * linux-fork.c (linux_fork_mourn_inferior)
3063         (detach_checkpoint_command, info_checkpoints_command)
3064         (linux_fork_context): Update.
3065         (linux_fork_detach): Update.
3066         (class scoped_switch_fork_info): Update.
3067         (delete_checkpoint_command): Update.
3068         * infrun.c (follow_fork_inferior): Update.
3069         (follow_fork_inferior): Update.
3070         (proceed_after_vfork_done): Update.
3071         (handle_vfork_child_exec_or_exit): Update.
3072         (follow_exec): Update.
3073         (displaced_step_prepare_throw): Update.
3074         (displaced_step_restore): Update.
3075         (start_step_over): Update.
3076         (resume_1): Update.
3077         (clear_proceed_status_thread): Update.
3078         (proceed): Update.
3079         (print_target_wait_results): Update.
3080         (do_target_wait): Update.
3081         (context_switch): Update.
3082         (stop_all_threads): Update.
3083         (restart_threads): Update.
3084         (finish_step_over): Update.
3085         (handle_signal_stop): Update.
3086         (switch_back_to_stepped_thread): Update.
3087         (keep_going_pass_signal): Update.
3088         (print_exited_reason): Update.
3089         (normal_stop): Update.
3090         * inferior.c (inferior_pid_to_str): Change return type.
3091         (print_selected_inferior): Update.
3092         (add_inferior): Update.
3093         (detach_inferior): Update.
3094         * dummy-frame.c (fprint_dummy_frames): Update.
3095         * dcache.c (dcache_info_1): Update.
3096         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3097         (btrace_fetch, btrace_clear): Update.
3098         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3099         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3100         type.
3101         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3102         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3103         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3104         * gdbarch.c, gdbarch.h: Rebuild.
3105         * gdbarch.sh (core_pid_to_str): Change return type.
3106         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3107         return type.
3108         (windows_nat_target::pid_to_str): Change return type.
3109         (windows_delete_thread): Update.
3110         (windows_nat_target::attach): Update.
3111         (windows_nat_target::files_info): Update.
3112         * target-delegates.c: Rebuild.
3113         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3114         return type.
3115         (sol_thread_target::pid_to_str): Change return type.
3116         * remote.c (class remote_target) <pid_to_str>: Change return
3117         type.
3118         (remote_target::pid_to_str): Change return type.
3119         (extended_remote_target::attach, remote_target::remote_stop_ns)
3120         (remote_target::remote_notif_remove_queued_reply)
3121         (remote_target::push_stop_reply, remote_target::disable_btrace):
3122         Update.
3123         (extended_remote_target::attach): Update.
3124         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3125         type.
3126         (gdbsim_target::pid_to_str): Change return type.
3127         * ravenscar-thread.c (struct ravenscar_thread_target)
3128         <pid_to_str>: Change return type.
3129         (ravenscar_thread_target::pid_to_str): Change return type.
3130         * procfs.c (class procfs_target) <pid_to_str>: Change return
3131         type.
3132         (procfs_target::pid_to_str): Change return type.
3133         (procfs_target::attach): Update.
3134         (procfs_target::detach): Update.
3135         (procfs_target::fetch_registers): Update.
3136         (procfs_target::store_registers): Update.
3137         (procfs_target::wait): Update.
3138         (procfs_target::files_info): Update.
3139         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3140         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3141         return type.
3142         (nto_procfs_target::pid_to_str): Change return type.
3143         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3144         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3145         return type.
3146         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3147         (exit_lwp): Update.
3148         (attach_proc_task_lwp_callback, get_detach_signal)
3149         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3150         (linux_nat_target::resume, wait_lwp, stop_callback)
3151         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3152         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3153         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3154         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3155         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3156         type.
3157         (inf_ptrace_target::attach): Update.
3158         (inf_ptrace_target::files_info): Update.
3159         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3160         type.
3161         (go32_nat_target::pid_to_str): Change return type.
3162         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3163         (gnu_nat_target::wait): Update.
3164         (gnu_nat_target::wait): Update.
3165         (gnu_nat_target::resume): Update.
3166         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3167         (fbsd_nat_target::wait): Update.
3168         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3169         type.
3170         (darwin_nat_target::attach): Update.
3171         * corelow.c (class core_target) <pid_to_str>: Change return type.
3172         (core_target::pid_to_str): Change return type.
3173         * target.c (normal_pid_to_str): Change return type.
3174         (default_pid_to_str): Likewise.
3175         (target_pid_to_str): Change return type.
3176         (target_translate_tls_address): Update.
3177         (target_announce_detach): Update.
3178         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3179         return type.
3180         (bsd_uthread_target::pid_to_str): Change return type.
3181         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3182         type.
3183         (bsd_kvm_target::pid_to_str): Change return type.
3184         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3185         return type.
3186         (aix_thread_target::pid_to_str): Change return type.
3187         * target.h (struct target_ops) <pid_to_str>: Change return type.
3188         (target_pid_to_str, normal_pid_to_str): Likewise.
3189         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3190         type.
3191         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3192         type.
3193         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3194         return type.
3195         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3196         type.
3197         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3198         type.
3199         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3200         return type.
3201
3202 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3203
3204         * NEWS: Mention that the new default MI version is 3.  Mention
3205         changes to the output of commands and events that deal with
3206         multi-location breakpoints.
3207         * breakpoint.c: Include "mi/mi-out.h".
3208         (print_one_breakpoint): Change output syntax if using MI version
3209         >= 3.
3210         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3211         New.
3212         (mi_multi_location_breakpoint_output_fixed): New.
3213         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3214         (mi_cmd_fix_multi_location_breakpoint_output): New.
3215         (mi_multi_location_breakpoint_output_fixed): New.
3216         * mi/mi-cmds.c (mi_cmds): Register command
3217         -fix-multi-location-breakpoint-output.
3218         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3219         interpreter "mi".
3220
3221 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3222
3223         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3224         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3225         instantiate mi_ui_out based on interpreter name.
3226         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3227         * mi/mi-main.c (mi_load_progress): Likewise.
3228
3229 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3230
3231         * NEWS: Combine separate "New targets" sections for 8.3.
3232
3233 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3234
3235         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3236         (ppcfbsd_init_abi): Install gdbarch
3237         "fetch_tls_load_module_address" and "get_thread_local_address"
3238         methods.
3239
3240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3241
3242         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3243         (riscv_fbsd_init_abi): Install gdbarch
3244         "fetch_tls_load_module_address" and "get_thread_local_address"
3245         methods.
3246
3247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3248
3249         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3250         (i386fbsd_init_abi): Install gdbarch
3251         "fetch_tls_load_module_address" and "get_thread_local_address"
3252         methods.
3253
3254 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3255
3256         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3257         (amd64fbsd_init_abi): Install gdbarch
3258         "fetch_tls_load_module_address" and "get_thread_local_address"
3259         methods.
3260
3261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3262
3263         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3264         (struct fbsd_pspace_data): New type.
3265         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3266         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3267         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3268         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3269         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3270
3271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3272
3273         * gdbtypes.c (lookup_struct_elt): New function.
3274         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3275         * gdbtypes.h (struct struct_elt): New type.
3276         (lookup_struct_elt): New prototype.
3277
3278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3279
3280         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3281         remove disabled code block.
3282
3283 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3284
3285         * gdbarch.sh (get_thread_local_address): New method.
3286         * gdbarch.h, gdbarch.c: Regenerate.
3287         * target.c (target_translate_tls_address): Use
3288         gdbarch_get_thread_local_address if present instead of
3289         target::get_thread_local_address.
3290
3291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3292
3293         * target.h (target::get_thread_local_address): Update comment.
3294
3295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3296
3297         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3298         objfile->separate_debug_objfile_backlink if not NULL.
3299
3300 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3301
3302         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3303         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3304         (amd64bsd_store_inferior_registers): Likewise.
3305         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3306         Enable segment base registers.
3307         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3308         PT_GETFSBASE and PT_GETGSBASE.
3309         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3310         PT_SETGSBASE.
3311         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3312         segment base registers.
3313         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3314
3315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3316
3317         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3318         Update calls to i386_target_description to add 'segments'
3319         parameter.
3320         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3321         add segment base registers.
3322         * arch/i386.c (i386_create_target_description): Add 'segments'
3323         parameter to enable segment base registers.
3324         * arch/i386.h (i386_create_target_description): Likewise.
3325         * features/i386/32bit-segments.xml: New file.
3326         * features/i386/32bit-segments.c: Generate.
3327         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3328         call to i386_target_description to add 'segments' parameter.
3329         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3330         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3331         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3332         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3333         if feature is present.
3334         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3335         Add 'segments' parameter to call to i386_target_description.
3336         (i386_target_description): Add 'segments' parameter to enable
3337         segment base registers.
3338         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3339         to call to i386_target_description.
3340         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3341         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3342         Define I386_NUM_REGS.
3343         (i386_target_description): Add 'segments' parameter to enable
3344         segment base registers.
3345
3346 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3347
3348         PR/24325
3349         * source-cache.c: #undef open and close, to avoid unresolved
3350         externals during linking.
3351
3352 2019-03-12  Tom Tromey  <tromey@adacore.com>
3353
3354         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3355         const.  Add initializers.
3356         (_initialize_remote): Don't initialize ptid globals.
3357
3358 2019-03-12  Pedro Alves  <palves@redhat.com>
3359
3360         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3361
3362 2019-03-12  Pedro Alves  <palves@redhat.com>
3363
3364         * cp-name-parser.y (main): Remove unused 'len' variable.
3365
3366 2019-03-12  Tom Tromey  <tromey@adacore.com>
3367
3368         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3369         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3370
3371 2019-03-12  Tom Tromey  <tromey@adacore.com>
3372
3373         * linux-nat.c (iterate_over_lwps): Update.
3374         (stop_callback): Remove parameter.
3375         (stop_wait_callback, detach_callback, resume_set_callback)
3376         (select_singlestep_lwp_callback, set_ignore_sigint)
3377         (status_callback, resumed_callback, resume_clear_callback)
3378         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3379         data parameter.
3380         (linux_nat_target::detach, linux_nat_target::resume)
3381         (linux_stop_and_wait_all_lwps, select_event_lwp)
3382         (linux_nat_filter_event, linux_nat_wait_1)
3383         (linux_nat_target::kill, linux_nat_target::stop)
3384         (linux_nat_target::stop): Update.
3385         (linux_nat_resume_callback): Change type.
3386         (resume_stopped_resumed_lwps, count_events_callback)
3387         (select_event_lwp_callback): Likewise.
3388         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3389         * arm-linux-nat.c (struct update_registers_data): Remove.
3390         (update_registers_callback): Change type.
3391         (arm_linux_insert_hw_breakpoint1): Update.
3392         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3393         parameter.
3394         (x86_linux_dr_set_addr): Update.
3395         (x86_linux_dr_set_control): Update.
3396         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3397         (iterate_over_lwps): Use gdb::function_view.
3398         * nat/aarch64-linux-hw-point.c (struct
3399         aarch64_dr_update_callback_param): Remove.
3400         (debug_reg_change_callback): Change type.
3401         (aarch64_notify_debug_reg_change): Update.
3402         * s390-linux-nat.c (s390_refresh_per_info): Update.
3403
3404 2019-03-11  Tom Tromey  <tromey@adacore.com>
3405
3406         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3407         redundant assignment to "this_cu".
3408
3409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3410
3411         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3412
3413 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3414
3415         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3416         from...
3417         (rank_one_type): ... this.
3418
3419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3420
3421         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3422         from...
3423         (rank_one_type): ... this.
3424
3425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3426
3427         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3428         from...
3429         (rank_one_type): ... this.
3430
3431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3432
3433         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3434         from...
3435         (rank_one_type): ... this.
3436
3437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3438
3439         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3440         from...
3441         (rank_one_type): ... this.
3442
3443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3444
3445         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3446         from...
3447         (rank_one_type): ... this.
3448
3449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3450
3451         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3452         from...
3453         (rank_one_type): ... this.
3454
3455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3456
3457         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3458         from...
3459         (rank_one_type): ... this.
3460
3461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3462
3463         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3464         from...
3465         (rank_one_type): ... this.
3466
3467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3468
3469         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3470         from...
3471         (rank_one_type): ... this.
3472
3473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3474
3475         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3476         from...
3477         (rank_one_type): ... this.
3478
3479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3480
3481         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3482         from...
3483         (rank_one_type): ... this.
3484
3485 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3486
3487         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3488         inferior-events' shows the example events.
3489
3490 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3491
3492         Support styling on native MS-Windows console
3493
3494         PR/24315
3495         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3496         on MS-Windows if $TERM is not defined.
3497
3498         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3499
3500         * posix-hdep.c (gdb_console_fputs):
3501         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3502         functions.
3503         * ui-file.h (gdb_console_fputs): Add prototype.
3504
3505         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3506         back to fputs only if the former returns zero.
3507
3508 2019-03-07  Tom Tromey  <tom@tromey.com>
3509
3510         * symmisc.c (print_symbol_bcache_statistics): Update.
3511         (print_objfile_statistics): Update.
3512         * symfile.c (allocate_symtab): Update.
3513         * stabsread.c: Don't include bcache.h.
3514         * psymtab.h (struct psymbol_bcache): Don't declare.
3515         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3516         (psymbol_bcache_init, psymbol_bcache_free)
3517         (psymbol_bcache_get_bcache): Don't declare.
3518         * psymtab.c (struct psymbol_bcache): Remove.
3519         (psymtab_storage::psymtab_storage): Update.
3520         (psymtab_storage::~psymtab_storage): Update.
3521         (psymbol_bcache_init, psymbol_bcache_free)
3522         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3523         (add_psymbol_to_bcache): Update.
3524         (allocate_psymtab): Update.
3525         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3526         macro_cache>: No longer pointers.
3527         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3528         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3529         * macrotab.c (macro_bcache): Update.
3530         * macroexp.c: Don't include bcache.h.
3531         * gdbtypes.c (check_types_worklist): Update.
3532         (types_deeply_equal): Remove TRY/CATCH.  Update.
3533         * elfread.c (elf_symtab_read): Update.
3534         * dwarf2read.c: Don't include bcache.h.
3535         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3536         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3537         (print_bcache_statistics, bcache_memory_used): Don't declare.
3538         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3539         methods.  Rename all data members.
3540         * bcache.c (struct bcache): Move to bcache.h.
3541         (bcache::expand_hash_table): Rename from expand_hash_table.
3542         (bcache): Remove.
3543         (bcache::insert): Rename from bcache_full.
3544         (bcache::compare): Rename from bcache_compare.
3545         (bcache_xmalloc): Remove.
3546         (bcache::~bcache): Rename from bcache_xfree.
3547         (bcache::print_statistics): Rename from print_bcache_statistics.
3548         (bcache::memory_used): Rename from bcache_memory_used.
3549
3550 2019-03-07  Pedro Alves  <palves@redhat.com>
3551
3552         * infrun.c (normal_stop): Also check for
3553         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3554
3555 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3556
3557         * f-lang.c (value_from_host_double): Moved to...
3558         * value.c (value_from_host_double): ...here.
3559         * value.h (value_from_host_double): Declare.
3560         * guile/scm-math.c (vlscm_convert_typed_number): Use
3561         value_from_host_double.
3562         (vlscm_convert_number): Likewise.
3563         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3564         * python/py-value.c (convert_value_from_python): Likewise.
3565
3566 2019-03-06  Tom Tromey  <tom@tromey.com>
3567
3568         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3569
3570 2019-03-06  Tom Tromey  <tom@tromey.com>
3571
3572         * utils.h (free_current_contents): Don't declare.
3573         * utils.c (free_current_contents): Remove.
3574
3575 2019-03-06  Tom Tromey  <tom@tromey.com>
3576
3577         * top.c (quit_force): Update.
3578         * main.c (captured_command_loop): Update.
3579         * common/new-op.c (operator new): Update.
3580         * common/common-exceptions.c (struct catcher)
3581         <save_cleanup_chain>: Remove member.
3582         (exceptions_state_mc_init): Update.
3583         (exception_try_scope_entry): Return nullptr.
3584         (exception_try_scope_exit, exception_rethrow)
3585         (throw_exception_sjlj, throw_exception_cxx): Update.
3586         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3587         (all_cleanups, do_cleanups, discard_cleanups)
3588         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3589         (restore_cleanups, restore_final_cleanups): Don't declare.
3590         (do_final_cleanups): Remove parameter.
3591         * common/cleanups.c (cleanup_chain, make_cleanup)
3592         (make_cleanup_dtor, all_cleanups, do_cleanups)
3593         (discard_my_cleanups, discard_cleanups)
3594         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3595         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3596         (null_cleanup): Remove.
3597         (do_final_cleanups): Remove parameter.
3598
3599 2019-03-06  Tom Tromey  <tom@tromey.com>
3600
3601         * remote.c (remote_target::remote_parse_stop_reply): Use
3602         unique_xmalloc_ptr.
3603
3604 2019-03-06  Tom Tromey  <tom@tromey.com>
3605
3606         * stabsread.c (struct stabs_field_info): Rename from field_info.
3607         <list, fnlist>: Add initializers.
3608         <obstack>: New member.
3609         (read_member_functions, read_struct_fields, read_baseclasses):
3610         Allocate on obstack.  Don't use cleanups.
3611         (read_one_struct_field, read_member_functions, read_struct_fields)
3612         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3613         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3614         (read_struct_type): Update.
3615
3616 2019-03-06  Tom Tromey  <tom@tromey.com>
3617
3618         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3619         * common/filestuff.h (make_cleanup_close): Don't declare.
3620         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3621         Remove.
3622
3623 2019-03-06  Tom Tromey  <tom@tromey.com>
3624
3625         * solib-aix.c: Use make_scope_exit.
3626
3627 2019-03-06  Tom Tromey  <tom@tromey.com>
3628
3629         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3630         Use make_scope_exit.
3631
3632 2019-03-06  Tom Tromey  <tom@tromey.com>
3633
3634         * solib-svr4.c (disable_probes_interface): Remove parameter.
3635         (svr4_handle_solib_event): Use make_scope_exit.
3636
3637 2019-03-06  Tom Tromey  <tom@tromey.com>
3638
3639         * remote.c (struct stop_reply_deleter): Remove.
3640         (stop_reply_up): Update.
3641         (struct stop_reply): Derive from notif_event.  Don't typedef.
3642         <regcache>: Now a std::vector.
3643         (stop_reply_xfree): Remove.
3644         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3645         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3646         (remote_target::discard_pending_stop_replies): Use delete.
3647         (remote_target::remote_parse_stop_reply): Update.
3648         (remote_target::process_stop_reply): Update.
3649         * remote-notif.h (struct notif_event): Add virtual destructor.
3650         Remove "dtr" member.
3651         (struct notif_client) <alloc_event>: Return a unique_ptr.
3652         (notif_event_xfree): Don't declare.
3653         (notif_event_up): New typedef.
3654         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3655         (notif_event_xfree, do_notif_event_xfree): Remove.
3656         (remote_notif_state_xfree): Update.
3657
3658 2019-03-06  Tom Tromey  <tom@tromey.com>
3659
3660         * infrun.c (displaced_step_clear_cleanup): Now a
3661         forward_scope_exit type.
3662         (displaced_step_prepare_throw): Update.
3663         (displaced_step_fixup): Update.
3664
3665 2019-03-06  Tom Tromey  <tom@tromey.com>
3666
3667         * inferior.h (class inferior): Update comment.
3668         * gdbthread.h (class thread_info): Update comment.
3669
3670 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3671             Tom Tromey  <tom@tromey.com>
3672
3673         * stabsread.h (struct stab_section_list): Remove.
3674         (coffstab_build_psymtabs): Update.
3675         * dbxread.c (symbuf_sections): Now a std::vector.
3676         (sect_idx): New global.
3677         (fill_symbuf): Update.
3678         (coffstab_build_psymtabs): Change type of stabsects parameter.
3679         Update.
3680         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3681         std::vector.
3682         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3683         (coff_locate_sections): Update.
3684         (coff_symfile_read): Remove cleanups.  Update.
3685         (init_stringtab): Add storage parameter.
3686         (free_stringtab, free_stringtab_cleanup): Remove.
3687         (init_lineno): Add storage parameter.
3688         (free_linetab, free_linetab_cleanup): Remove.
3689
3690 2019-03-06  Pedro Alves  <palves@redhat.com>
3691
3692         * linux-fork.c (fork_info::clobber_regs): Delete.
3693         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3694         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3695         comment.  Adjust.
3696         (scoped_switch_fork_info::scoped_switch_fork_info)
3697         (checkpoint_command, linux_fork_context): Adjust
3698         fork_save_infrun_state calls.
3699
3700 2019-03-06  Pedro Alves  <palves@redhat.com>
3701
3702         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3703         (inf_has_multiple_threads): Return 'bool' and rewrite using
3704         inferior_info::threads().
3705
3706 2019-03-06  Pedro Alves  <palves@redhat.com>
3707
3708         * linux-fork.c: Include <list>.
3709         (fork_list): Now a std::list instance.
3710         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3711         (forks_exist_p, find_last_fork): Adjust.
3712         (new_fork): Delete.
3713         (one_fork_p): New.
3714         (add_fork): Adjust.
3715         (free_fork): Delete, folded into fork_info::~fork_info().
3716         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3717         Adjust.
3718         (init_fork_list): Delete.
3719         (linux_fork_killall, linux_fork_mourn_inferior)
3720         (linux_fork_detach, info_checkpoints_command): Adjust.
3721         (_initialize_linux_fork): No longer call init_fork_list.
3722
3723 2019-03-06  Pedro Alves  <palves@redhat.com>
3724
3725         * linux-fork.c (new_fork): New, split out of ...
3726         (add_fork): ... this.  Return void.  Move "first fork" special
3727         case from here, to ...
3728         (checkpoint_command): ... here.
3729         * linux-linux.h (add_fork): Return void.
3730
3731 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3732
3733         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3734
3735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3736             Chris January  <chris.january@arm.com>
3737             David Lecomber  <david.lecomber@arm.com>
3738
3739         * f-exp.y: New token, UNOP_INTRINSIC.
3740         (exp): New pattern using UNOP_INTRINSIC token.
3741         (f77_keywords): Add 'abs' keyword.
3742         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3743         (value_from_host_double): New function.
3744         (evaluate_subexp_f): Support UNOP_ABS.
3745
3746 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3749         types.
3750
3751 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3752
3753         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3754         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3755         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3756
3757 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3760
3761 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3762             Chris January  <chris.january@arm.com>
3763
3764         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3765         * f-exp.y: Define 'KIND' token.
3766         (exp): New pattern for KIND expressions.
3767         (ptype): Handle types with a kind extension.
3768         (direct_abs_decl): Extend to spot kind extensions.
3769         (f77_keywords): Add 'kind' to the list.
3770         (push_kind_type): New function.
3771         (convert_to_kind_type): New function.
3772         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3773         * parse.c (operator_length_standard): Likewise.
3774         * parser-defs.h (enum type_pieces): Add tp_kind.
3775         * std-operator.def: Add UNOP_KIND.
3776
3777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3778
3779         * f-exp.y (f_parse): Set yydebug.
3780
3781 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         * f-lang.c (evaluate_subexp_f): New function.
3784         (exp_descriptor_f): New global.
3785         (f_language_defn): Use exp_descriptor_f instead of
3786         exp_descriptor_standard.
3787
3788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3789
3790         * f-exp.y (struct token): Add comments.
3791         (dot_ops): Remove uppercase versions and the end marker.
3792         (f77_keywords): Likewise.
3793         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3794         entries in the dot_ops array are case insensitive, and use
3795         strncasecmp to compare strings.  Also some whitespace cleanup in
3796         this area.  Similar for the f77_keywords array, except entries in
3797         this list might be case sensitive.
3798
3799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * f-exp.y (struct f77_boolean_val): Add comments.
3802         (boolean_values): Remove uppercase versions, and end marker.
3803         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3804         and use strncasecmp to achieve case insensitivity.  Additionally,
3805         perform whitespace cleanup around this code.
3806
3807 2019-03-06  Tom Tromey  <tromey@adacore.com>
3808
3809         * remote-sim.c (gdbsim_target_open): Use result of
3810         gdb_argv::release.
3811
3812 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3813         Dirk Schubert  <dirk.schubert@arm.com>
3814         Chris January  <chris.january@arm.com>
3815
3816         * eval.c (evaluate_subexp_standard): Call Fortran argument
3817         wrapping logic.
3818         * f-lang.c (struct value): A value which can be passed into a
3819         Fortran function call.
3820         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3821         where appropriate.
3822         (struct type): Value ready for a Fortran function call.
3823         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3824         is needed.
3825         * f-lang.h (fortran_argument_convert): Declaration.
3826         (fortran_preserve_arg_pointer): Declaration.
3827         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3828
3829 2019-03-05  Tom Tromey  <tromey@adacore.com>
3830
3831         * python/py-prettyprint.c (print_string_repr): Remove #if.
3832         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3833
3834 2019-03-05  Tom Tromey  <tromey@adacore.com>
3835
3836         * target.c (the_dummy_target): Move later.  Change type to
3837         "dummy_target".
3838         (initialize_targets): Don't initialize the_dummy_target.
3839
3840 2019-03-05  Tom Tromey  <tromey@adacore.com>
3841
3842         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3843         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3844
3845 2019-03-05  Tom Tromey  <tromey@adacore.com>
3846
3847         * windows-nat.c (windows_nat_target::attach)
3848         (windows_nat_target::detach): Don't call gdb_flush.
3849         * valprint.c (generic_val_print, val_print, val_print_string):
3850         Don't call gdb_flush.
3851         * utils.c (defaulted_query): Don't call gdb_flush.
3852         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3853         * target.c (target_announce_detach): Don't call gdb_flush.
3854         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3855         * remote.c (extended_remote_target::attach): Don't call
3856         gdb_flush.
3857         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3858         * printcmd.c (do_examine): Don't call gdb_flush.
3859         (info_display_command): Don't call gdb_flush.
3860         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3861         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3862         * memattr.c (info_mem_command): Don't call gdb_flush.
3863         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3864         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3865         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3866         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3867         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3868         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3869         (gnu_nat_target::detach): Don't call gdb_flush.
3870         * f-valprint.c (f_val_print): Don't call gdb_flush.
3871         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3872         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3873         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3874         gdb_flush.
3875         * c-valprint.c (c_val_print): Don't call gdb_flush.
3876         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3877
3878 2019-03-05  Tom Tromey  <tromey@adacore.com>
3879
3880         * varobj.c (update_dynamic_varobj_children): Update.
3881         (install_default_visualizer): Use reset, not release.
3882         * value.c (set_internalvar): Update.
3883         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3884         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3885         ATTRIBUTE_UNUSED_RESULT.
3886
3887 2019-03-05  Tom Tromey  <tromey@adacore.com>
3888
3889         * remote.c (class scoped_remote_fd) <release>: Add
3890         ATTRIBUTE_UNUSED_RESULT.
3891
3892 2019-03-05  Tom Tromey  <tromey@adacore.com>
3893
3894         * macroexp.c (struct macro_buffer) <release>: Add
3895         ATTRIBUTE_UNUSED_RESULT.
3896
3897 2019-03-05  Tom Tromey  <tromey@adacore.com>
3898
3899         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3900         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3901         ATTRIBUTE_UNUSED_RESULT.
3902
3903 2019-03-05  Tom Tromey  <tromey@adacore.com>
3904
3905         * common/scoped_fd.h (class scoped_fd) <release>: Add
3906         ATTRIBUTE_UNUSED_RESULT.
3907
3908 2019-03-05  Tom Tromey  <tromey@adacore.com>
3909
3910         * parser-defs.h (struct parser_state) <release>: Add
3911         ATTRIBUTE_UNUSED_RESULT.
3912
3913 2019-03-05  Tom Tromey  <tromey@adacore.com>
3914
3915         * utils.h (class gdb_argv) <release>: Add
3916         ATTRIBUTE_UNUSED_RESULT.
3917         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3918
3919 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3920
3921         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3922         for-loop range, to avoid compiler warnings.
3923
3924         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3925         avoid compiler warnings about unused variables.
3926
3927         * NEWS: Mention end of support for native debugging on MS-Windows
3928         before XP.
3929
3930         PR gdb/24292
3931         * common/netstuff.c:
3932         * gdbserver/gdbreplay.c
3933         * gdbserver/remote-utils.c:
3934         * ser-tcp.c:
3935         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3936         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3937         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3938         'getaddrinfo' and 'freeaddrinfo' were not available before
3939         Windows XP, and mingw.org's MinGW headers by default define
3940         _WIN32_WINNT to 0x500.
3941
3942 2019-03-01  Gary Benson <gbenson@redhat.com>
3943
3944         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3945
3946 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3947             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3948
3949         PR gdb/8527
3950         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3951         set_sigint_trap, clear_sigint_trap.
3952
3953 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3954
3955         * target.c (target_detach): Clear the regcache and the
3956         frame cache.
3957
3958 2019-02-27  Pedro Alves  <palves@redhat.com>
3959
3960         * utils.c (set_screen_size): When we cap the height/width sizes,
3961         tweak the corresponding command variable to show "unlimited":
3962
3963 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3964             Pedro Alves  <palves@redhat.com>
3965
3966         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3967         before calling rl_set_screen_size.
3968
3969 2019-02-27  Tom Tromey  <tromey@adacore.com>
3970
3971         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3972         define.
3973         * python/py-value.c: Remove Python 2.4 workaround.
3974         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3975         workaround.
3976         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3977         Python 2.4 workaround.
3978         * python/python-internal.h: Remove Python 2.4 comment.
3979         (Py_ssize_t): Don't define.
3980         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3981         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3982         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3983         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3984         * python/python.c (do_start_initialization): Remove Python 2.4
3985         workaround.
3986         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3987         (print_children): Remove Python 2.4 workaround.
3988         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3989         workaround.
3990         (CHARBUFFERPROC_NAME): Remove.
3991         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3992         Python 2.4 workaround.
3993
3994 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3995
3996         * NEWS: Note minimum Python version.
3997
3998 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3999
4000         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4001         code from these functions.  Remove corresponding ifdefs.  Use
4002         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4003         Remove gotos and target of gotos.
4004         (infpy_search_memory): Likewise.
4005
4006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4007
4008         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4009         (hppa_gdbarch_init): Don't register deleted functions with
4010         gdbarch.
4011
4012 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4015         (h8300_unwind_sp): Delete.
4016         (h8300_dummy_id): Delete.
4017         (h8300_gdbarch_init): Don't register deleted functions with
4018         gdbarch.
4019
4020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4021
4022         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4023         (ft32_unwind_pc): Delete.
4024         (ft32_unwind_sp): Delete.
4025         (ft32_gdbarch_init): Don't register deleted functions with
4026         gdbarch.
4027
4028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4029
4030         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4031         (frv_unwind_pc): Delete.
4032         (frv_unwind_sp): Delete.
4033         (frv_gdbarch_init): Don't register deleted functions with
4034         gdbarch.
4035
4036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4037
4038         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4039         (riscv_unwind_pc): Delete.
4040         (riscv_unwind_sp): Delete.
4041         (riscv_gdbarch_init): Don't register deleted functions with
4042         gdbarch.
4043
4044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4045
4046         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4047         (csky_unwind_pc): Delete.
4048         (csky_unwind_sp): Delete.
4049         (csky_gdbarch_init): Don't register deleted functions with
4050         gdbarch.
4051
4052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4053
4054         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4055         (cris_unwind_pc): Delete.
4056         (cris_unwind_sp): Delete.
4057         (cris_gdbarch_init): Don't register deleted functions with
4058         gdbarch.
4059
4060 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4061
4062         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4063         (bfin_unwind_pc): Delete.
4064         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4065
4066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4067
4068         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4069         (arm_unwind_pc): Delete.
4070         (arm_unwind_sp): Delete.
4071         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4072
4073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4074
4075         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4076         (arc_unwind_pc): Delete.
4077         (arc_unwind_sp): Delete.
4078         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4079
4080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4081
4082         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4083         (alpha_unwind_pc): Delete.
4084         (alpha_gdbarch_init): Don't register deleted functions with
4085         gdbarch.
4086
4087 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4088
4089         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4090         (aarch64_unwind_pc): Delete.
4091         (aarch64_unwind_sp): Delete.
4092         (aarch64_gdbarch_init): Don't register deleted functions with
4093         gdbarch.
4094
4095 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4096
4097         * gdbtypes.c (type_align): Don't consider static members when
4098         computing structure alignment.
4099
4100 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4101
4102         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4103         return 0 for other types.
4104         * arch-utils.c (default_type_align): Always return 0.
4105         * gdbarch.h: Regenerate.
4106         * gdbarch.sh (type_align): Extend comment.
4107         * gdbtypes.c (type_align): Add additional comments, always call
4108         gdbarch_type_align before applying the default rules.
4109         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4110         generic code will then apply a suitable default.
4111         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4112         types, return 0 for other types.
4113
4114 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4115
4116         * NEWS: Create a new section for the next release branch.
4117         Rename the section of the current branch, now that it has
4118         been cut.
4119
4120 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4121
4122         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4123         * version.in: Bump version to 8.3.50.DATE-git.
4124
4125 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4126
4127         * aix-thread.c (ptid_cmp): Remove unused variable.
4128         (get_signaled_thread): Likewise.
4129         (store_regs_user_thread): Likewise.
4130         (store_regs_kernel_thread): Likewise.
4131         (fetch_regs_kernel_thread): Remove shadowed variable.
4132
4133 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4134
4135         * features/riscv/32bit-cpu.xml: Add register numbers.
4136         * features/riscv/32bit-fpu.c: Regenerate.
4137         * features/riscv/32bit-fpu.xml: Add register numbers.
4138         * features/riscv/64bit-cpu.xml: Add register numbers.
4139         * features/riscv/64bit-fpu.c: Regenerate.
4140         * features/riscv/64bit-fpu.xml: Add register numbers.
4141
4142 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4143
4144         * NEWS: Mention two argument form of gdb.Value constructor.
4145         * python/py-value.c (convert_buffer_and_type_to_value): New
4146         function.
4147         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4148         Add support for handling an optional second argument.  Call
4149         convert_buffer_and_type_to_value as appropriate.
4150         * python/python-internal.h (Py_buffer_deleter): New struct.
4151         (Py_buffer_up): New typedef.
4152
4153 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4154
4155         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4156         instead of releasing ownership.
4157
4158 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4159
4160         * dwarf2read.c (open_and_init_dwp_file): Call
4161         elf_numsections instead of bfd_count_sections to initialize
4162         dwp_file->num_sections.
4163
4164 2019-02-25  Tom Tromey  <tromey@adacore.com>
4165
4166         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4167
4168 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4169
4170         * gcore.in: Add '--readnever' option when invoking GDB.
4171
4172 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4173
4174         * MAINTAINERS: Update my email address.
4175
4176 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4177
4178         * build-id.c (build_id_to_debug_bfd_1): New function.
4179         (build_id_to_debug_bfd): Look for separate debug file in
4180         sysroot.
4181
4182 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4183
4184         * gdbarch.sh: Update the copyright year range that is placed into
4185         generated files.
4186
4187 2019-02-22  Keith Seitz  <keiths@redhat.com>
4188
4189         PR symtab/23853
4190         * linespec.c (create_sals_line_offset): Search for the default
4191         symtab's filename instead of its fullname.
4192
4193 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4194
4195         * NEWS: Update style defaults.
4196
4197 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4198
4199         * main.c (captured_main_1): Disable styling in batch mode.
4200
4201 2019-02-20  Tom Tromey  <tom@tromey.com>
4202
4203         * symtab.c (symtab_symbol_info): Fix typos.
4204
4205 2019-02-20  Tom Tromey  <tromey@adacore.com>
4206
4207         * findcmd.c (_initialize_mem_search): Use upper case for
4208         metasyntactic variables.
4209
4210 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4211
4212         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4213         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4214
4215 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4216
4217         * top.h (source_file_name): Change to std::string.
4218         * top.c (source_file_name): Likewise.
4219         (command_line_input): Adjust.
4220         * cli/cli-script.c (script_from_file): Adjust.
4221
4222 2019-02-19  Tom Tromey  <tromey@adacore.com>
4223
4224         * ravenscar-thread.c
4225         (ravenscar_thread_target::update_thread_list): Don't call
4226         ada_build_task_list.
4227         * ada-lang.h (ada_build_task_list): Don't declare.
4228         * ada-tasks.c (struct ada_tasks_inferior_data)
4229         <task_list_valid_p>: Now bool.
4230         (read_known_tasks, ada_task_list_changed)
4231         (ada_tasks_invalidate_inferior_data): Update.
4232         (read_known_tasks_array): Return bool.
4233         (read_known_tasks_list): Likewise.
4234         (read_known_tasks): Return void.
4235         (ada_build_task_list): Now static.
4236
4237 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4238
4239         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4240         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4241
4242 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4243
4244         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4245         variant for ada_tasks_pspace_data_handle and
4246         ada_tasks_inferior_data_handle.
4247         (ada_tasks_pspace_data_cleanup): New function.
4248         (ada_tasks_inferior_data_cleanup): New function.
4249
4250 2019-02-17  Tom Tromey  <tom@tromey.com>
4251
4252         * macrotab.h (macro_source_fullname): Return a std::string.
4253         * macrotab.c (macro_include, check_for_redefinition)
4254         (macro_undef, macro_lookup_definition, foreach_macro)
4255         (foreach_macro_in_scope): Update.
4256         (macro_source_fullname): Return a std::string.
4257         * macrocmd.c (show_pp_source_pos): Update.
4258
4259 2019-02-17  Tom Tromey  <tom@tromey.com>
4260
4261         * macrocmd.c (show_pp_source_pos): Style the file names.
4262
4263 2019-02-17  Tom Tromey  <tom@tromey.com>
4264
4265         PR tui/24197:
4266         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4267
4268 2019-02-17  Tom Tromey  <tom@tromey.com>
4269
4270         * ada-lang.c (user_select_syms): Use filtered printing.
4271         * utils.c (wrap_style): New global.
4272         (desired_style): Remove.
4273         (emit_style_escape): Add stream parameter.
4274         (set_output_style, reset_terminal_style, prompt_for_continue):
4275         Update.
4276         (flush_wrap_buffer): Only flush gdb_stdout.
4277         (wrap_here): Set wrap_style.
4278         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4279         treat escape sequences as a character.  Change when wrap buffer is
4280         flushed.
4281         (fputs_styled): Do not set the output style when the default is
4282         requested.
4283         * ui-style.h (struct ui_file_style) <is_default>: New method.
4284         * source.c (print_source_lines_base): Emit escape sequences in one
4285         piece.
4286
4287 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4288
4289         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4290         integers and enumeration types.
4291
4292 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4293
4294         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4295         instead of lookup_symbol_in_language
4296         (do_exact_match): New function.
4297         (ada_get_symbol_name_matcher): Return do_exact_match when
4298         doing a verbatim match.
4299
4300 2019-02-15  Tom Tromey  <tromey@adacore.com>
4301
4302         * ravenscar-thread.c (ravenscar_thread_target::resume)
4303         (ravenscar_thread_target::wait): Special case wildcard requests.
4304
4305 2019-02-15  Tom Tromey  <tromey@adacore.com>
4306
4307         * ravenscar-thread.c (base_ptid): Remove.
4308         (struct ravenscar_thread_target) <close>: New method.
4309         <m_base_ptid>: New member.
4310         <update_inferior_ptid, active_task, task_is_currently_active,
4311         runtime_initialized>: Declare methods.
4312         <ravenscar_thread_target>: Add constructor.
4313         (ravenscar_thread_target::task_is_currently_active)
4314         (ravenscar_thread_target::update_inferior_ptid)
4315         (ravenscar_runtime_initialized): Rename.  Now methods.
4316         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4317         (ravenscar_thread_target::update_thread_list): Update.
4318         (ravenscar_thread_target::active_task): Now method.
4319         (ravenscar_thread_target::store_registers)
4320         (ravenscar_thread_target::prepare_to_store)
4321         (ravenscar_thread_target::prepare_to_store)
4322         (ravenscar_thread_target::mourn_inferior): Update.
4323         (ravenscar_inferior_created): Use "new" to create target.
4324         (ravenscar_thread_target::get_ada_task_ptid): Update.
4325         (_initialize_ravenscar): Don't initialize base_ptid.
4326         (ravenscar_ops): Remove global.
4327
4328 2019-02-15  Tom Tromey  <tromey@adacore.com>
4329
4330         * target.h (push_target): Declare new overload.
4331         * target.c (push_target): New overload, taking an rvalue reference.
4332         * remote.c (remote_target::open_1): Use push_target overload.
4333         * corelow.c (core_target_open): Use push_target overload.
4334
4335 2019-02-15  Tom Tromey  <tromey@adacore.com>
4336
4337         * ravenscar-thread.c (is_ravenscar_task)
4338         (ravenscar_task_is_currently_active): Return bool.
4339         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4340         (_initialize_ravenscar): Remove "(void)".
4341         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4342         Return bool.
4343
4344 2019-02-15  Tom Tromey  <tromey@adacore.com>
4345
4346         * ravenscar-thread.c (ravenscar_runtime_initializer)
4347         (has_ravenscar_runtime, get_running_thread_id)
4348         (ravenscar_thread_target::resume): Fix indentation.
4349
4350 2019-02-15  Tom Tromey  <tromey@adacore.com>
4351
4352         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4353         from ravenscar_arch_ops.
4354         (sparc_ravenscar_ops::fetch_registers)
4355         (sparc_ravenscar_ops::store_registers): Now methods.
4356         (sparc_ravenscar_prepare_to_store): Remove.
4357         (sparc_ravenscar_ops): Redefine.
4358         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4359         methods and destructor.  Remove members.
4360         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4361         (ravenscar_thread_target::store_registers)
4362         (ravenscar_thread_target::prepare_to_store): Update.
4363         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4364         Remove.
4365         (struct ppc_ravenscar_powerpc_ops): Derive from
4366         ravenscar_arch_ops.
4367         (ppc_ravenscar_powerpc_ops::fetch_registers)
4368         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4369         (ppc_ravenscar_powerpc_ops): Redefine.
4370         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4371         (ppc_ravenscar_e500_ops::fetch_registers)
4372         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4373         (ppc_ravenscar_e500_ops): Redefine.
4374         * aarch64-ravenscar-thread.c
4375         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4376         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4377         (aarch64_ravenscar_fetch_registers)
4378         (aarch64_ravenscar_store_registers): Now methods.
4379         (aarch64_ravenscar_ops): Redefine.
4380
4381 2019-02-15  Tom Tromey  <tromey@adacore.com>
4382
4383         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4384         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4385         (ravenscar_thread_target::stopped_by_watchpoint)
4386         (ravenscar_thread_target::stopped_data_address)
4387         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4388
4389 2019-02-15  Tom Tromey  <tromey@adacore.com>
4390
4391         * ravenscar-thread.c: Fix some typos.
4392
4393 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4394             Tom Tromey  <tromey@adacore.com>
4395
4396         * ada-lang.c (ada_exception_sal): Change addr_string to a
4397         std::string.
4398         (create_ada_exception_catchpoint): Update.
4399
4400 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4401             Tom Tromey  <tromey@adacore.com>
4402
4403         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4404         (bp_location_ops): Remove.
4405         (base_breakpoint_allocate_location): Update.
4406         (free_bp_location): Update.
4407         * ada-lang.c (class ada_catchpoint_location)
4408         <ada_catchpoint_location>: Remove ops parameter.
4409         (ada_catchpoint_location_dtor): Remove.
4410         (ada_catchpoint_location_ops): Remove.
4411         (allocate_location_exception): Update.
4412         * breakpoint.h (struct bp_location_ops): Remove.
4413         (class bp_location) <bp_location>: Remove bp_location_ops
4414         parameter.
4415         <~bp_location>: Add destructor.
4416         <ops>: Remove.
4417
4418 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4419             Pedro Alves  <palves@redhat.com>
4420
4421         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4422         'PATH_MAX'.
4423
4424 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4425             Samuel Thibault  <samuel.thibault@gnu.org>
4426             Thomas Schwinge  <thomas@codesourcery.com>
4427
4428         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4429         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4430
4431 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4432
4433         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4434         (check_empty): Use "const char *".
4435
4436         * gnu-nat.c (gnu_nat_target::detach): Instead of
4437         'detach_inferior (pid)' call
4438         'detach_inferior (find_inferior_pid (pid))'.
4439
4440         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4441         'nat/fork-inferior.o'.
4442         * gnu-nat.c: #include "nat/fork-inferior.h".
4443
4444         * gnu-nat.c (gnu_nat_target::detach): Instead of
4445         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4446         * gnu-nat.h: #include "inf-child.h".
4447         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4448         'i386_gnu_nat_target::fetch_registers'.
4449         (gnu_store_registers): Rename/move to
4450         'i386_gnu_nat_target::store_registers'.
4451
4452         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4453         * gnu-nat.h (mach_thread_info): New function.
4454         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4455
4456         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4457
4458 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4459
4460         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4461
4462 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4463
4464         * windows-nat.c (windows_add_thread): Add new parameter
4465         "main_thread_p" with default value set to false.  Update
4466         function documentation as well as all callers.
4467         (windows_delete_thread): Likewise.
4468         (fake_create_process): Update call to windows_add_thread.
4469         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4470         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4471         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4472         call to windows_delete_thread.
4473
4474 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4475
4476         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4477
4478 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4479
4480         * symfile.c (find_separate_debug_file): Use canonical path of
4481         sysroot with child_path instead of gdb_sysroot if it is valid.
4482
4483 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4484
4485         * symfile.c (find_separate_debug_file): Use child_path to
4486         determine if an object file is under a sysroot.
4487
4488 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4489
4490         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4491         unittests/child-path-selftests.c.
4492         * common/pathstuff.c (child_path): New function.
4493         * common/pathstuff.h (child_path): New prototype.
4494         * unittests/child-path-selftests.c: New file.
4495
4496 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4497
4498         * symfile.c (find_separate_debug_file): Look for separate debug
4499         files in debug directories under the sysroot.
4500
4501 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4502
4503         * symtab.h (struct minimal_symbol data_p): New const method.
4504         (struct minimal_symbol text_p): Likewise.
4505         * symtab.c (output_source_filename): Use file name style
4506         to print file name.
4507         (print_symbol_info): Likewise.
4508         (print_msymbol_info): Use address style to print addresses.
4509         Use function name style to print executable text symbols.
4510         (expand_symtab_containing_pc): Use data_p.
4511         (find_pc_sect_compunit_symtab): Likewise.
4512
4513 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4514
4515         * breakpoint.c (describe_other_breakpoints): Use address style
4516         to print addresses.
4517         (say_where): Likewise.
4518
4519 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4520
4521         * ada-typeprint.c (print_func_type): Print function name
4522         style to print function name.
4523         * c-typeprint.c (c_print_type_1): Likewise.
4524
4525 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4526
4527         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4528         for execve.
4529
4530 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4531
4532         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4533         type_stack.
4534
4535 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4536
4537         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4538         TYPE_CODE_REF types.
4539
4540 2019-02-08  Jim Wilson  <jimw@sifive.com>
4541
4542         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4543         (riscv_linux_fregset): New.
4544         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4545
4546 2019-02-07  Tom Tromey  <tom@tromey.com>
4547
4548         * thread.c (thread_cancel_execution_command): Update.
4549         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4550         methods.
4551         (struct thread_fsm_ops): Remove.
4552         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4553         (thread_fsm_should_stop, thread_fsm_return_value)
4554         (thread_fsm_set_finished, thread_fsm_finished_p)
4555         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4556         Don't declare.
4557         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4558         * infrun.c (clear_proceed_status_thread)
4559         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4560         (print_stop_event): Update.
4561         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4562         Add constructor.
4563         (step_command_fsm_ops): Remove.
4564         (new_step_command_fsm): Remove.
4565         (step_1): Update.
4566         (step_command_fsm::should_stop): Rename from
4567         step_command_fsm_should_stop.
4568         (step_command_fsm::clean_up): Rename from
4569         step_command_fsm_clean_up.
4570         (step_command_fsm::do_async_reply_reason): Rename from
4571         step_command_fsm_async_reply_reason.
4572         (struct until_next_fsm): Inherit from thread_fsm.  Add
4573         constructor.
4574         (until_next_fsm_ops): Remove.
4575         (new_until_next_fsm): Remove.
4576         (until_next_fsm::should_stop): Rename from
4577         until_next_fsm_should_stop.
4578         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4579         (until_next_fsm::do_async_reply_reason): Rename from
4580         until_next_fsm_async_reply_reason.
4581         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4582         constructor.  Change type of breakpoint.
4583         (finish_command_fsm_ops): Remove.
4584         (new_finish_command_fsm): Remove.
4585         (finish_command_fsm::should_stop): Rename from
4586         finish_command_fsm_should_stop.
4587         (finish_command_fsm::clean_up): Rename from
4588         finish_command_fsm_clean_up.
4589         (finish_command_fsm::return_value): Rename from
4590         finish_command_fsm_return_value.
4591         (finish_command_fsm::do_async_reply_reason): Rename from
4592         finish_command_fsm_async_reply_reason.
4593         (finish_command): Update.
4594         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4595         Add constructor.
4596         (call_thread_fsm_ops): Remove.
4597         (call_thread_fsm::call_thread_fsm): Rename from
4598         new_call_thread_fsm.
4599         (call_thread_fsm::should_stop): Rename from
4600         call_thread_fsm_should_stop.
4601         (call_thread_fsm::should_notify_stop): Rename from
4602         call_thread_fsm_should_notify_stop.
4603         (run_inferior_call, call_function_by_hand_dummy): Update.
4604         * cli/cli-interp.c (should_print_stop_to_console): Update.
4605         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4606         Add constructor.  Change type of location_breakpoint,
4607         caller_breakpoint.
4608         (until_break_fsm_ops): Remove.
4609         (new_until_break_fsm): Remove.
4610         (until_break_fsm::should_stop): Rename from
4611         until_break_fsm_should_stop.
4612         (until_break_fsm::clean_up): Rename from
4613         until_break_fsm_clean_up.
4614         (until_break_fsm::do_async_reply_reason): Rename from
4615         until_break_fsm_async_reply_reason.
4616         (until_break_command): Update.
4617         * thread-fsm.c: Remove.
4618         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4619
4620 2019-02-07  Tom Tromey  <tom@tromey.com>
4621
4622         * yy-remap.h: Add include guard.
4623         * xtensa-tdep.h: Add include guard.
4624         * xcoffread.h: Rename include guard.
4625         * varobj-iter.h: Add include guard.
4626         * tui/tui.h: Rename include guard.
4627         * tui/tui-winsource.h: Rename include guard.
4628         * tui/tui-wingeneral.h: Rename include guard.
4629         * tui/tui-windata.h: Rename include guard.
4630         * tui/tui-win.h: Rename include guard.
4631         * tui/tui-stack.h: Rename include guard.
4632         * tui/tui-source.h: Rename include guard.
4633         * tui/tui-regs.h: Rename include guard.
4634         * tui/tui-out.h: Rename include guard.
4635         * tui/tui-layout.h: Rename include guard.
4636         * tui/tui-io.h: Rename include guard.
4637         * tui/tui-hooks.h: Rename include guard.
4638         * tui/tui-file.h: Rename include guard.
4639         * tui/tui-disasm.h: Rename include guard.
4640         * tui/tui-data.h: Rename include guard.
4641         * tui/tui-command.h: Rename include guard.
4642         * tic6x-tdep.h: Add include guard.
4643         * target/waitstatus.h: Rename include guard.
4644         * target/wait.h: Rename include guard.
4645         * target/target.h: Rename include guard.
4646         * target/resume.h: Rename include guard.
4647         * target-float.h: Rename include guard.
4648         * stabsread.h: Add include guard.
4649         * rs6000-tdep.h: Add include guard.
4650         * riscv-fbsd-tdep.h: Add include guard.
4651         * regformats/regdef.h: Rename include guard.
4652         * record.h: Rename include guard.
4653         * python/python.h: Rename include guard.
4654         * python/python-internal.h: Rename include guard.
4655         * python/py-stopevent.h: Rename include guard.
4656         * python/py-ref.h: Rename include guard.
4657         * python/py-record.h: Rename include guard.
4658         * python/py-record-full.h: Rename include guard.
4659         * python/py-record-btrace.h: Rename include guard.
4660         * python/py-instruction.h: Rename include guard.
4661         * python/py-events.h: Rename include guard.
4662         * python/py-event.h: Rename include guard.
4663         * procfs.h: Add include guard.
4664         * proc-utils.h: Add include guard.
4665         * p-lang.h: Add include guard.
4666         * or1k-tdep.h: Rename include guard.
4667         * observable.h: Rename include guard.
4668         * nto-tdep.h: Rename include guard.
4669         * nat/x86-linux.h: Rename include guard.
4670         * nat/x86-linux-dregs.h: Rename include guard.
4671         * nat/x86-gcc-cpuid.h: Add include guard.
4672         * nat/x86-dregs.h: Rename include guard.
4673         * nat/x86-cpuid.h: Rename include guard.
4674         * nat/ppc-linux.h: Rename include guard.
4675         * nat/mips-linux-watch.h: Rename include guard.
4676         * nat/linux-waitpid.h: Rename include guard.
4677         * nat/linux-ptrace.h: Rename include guard.
4678         * nat/linux-procfs.h: Rename include guard.
4679         * nat/linux-osdata.h: Rename include guard.
4680         * nat/linux-nat.h: Rename include guard.
4681         * nat/linux-namespaces.h: Rename include guard.
4682         * nat/linux-btrace.h: Rename include guard.
4683         * nat/glibc_thread_db.h: Rename include guard.
4684         * nat/gdb_thread_db.h: Rename include guard.
4685         * nat/gdb_ptrace.h: Rename include guard.
4686         * nat/fork-inferior.h: Rename include guard.
4687         * nat/amd64-linux-siginfo.h: Rename include guard.
4688         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4689         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4690         * nat/aarch64-linux.h: Rename include guard.
4691         * nat/aarch64-linux-hw-point.h: Rename include guard.
4692         * mn10300-tdep.h: Add include guard.
4693         * mips-linux-tdep.h: Add include guard.
4694         * mi/mi-parse.h: Rename include guard.
4695         * mi/mi-out.h: Rename include guard.
4696         * mi/mi-main.h: Rename include guard.
4697         * mi/mi-interp.h: Rename include guard.
4698         * mi/mi-getopt.h: Rename include guard.
4699         * mi/mi-console.h: Rename include guard.
4700         * mi/mi-common.h: Rename include guard.
4701         * mi/mi-cmds.h: Rename include guard.
4702         * mi/mi-cmd-break.h: Rename include guard.
4703         * m2-lang.h: Add include guard.
4704         * location.h: Rename include guard.
4705         * linux-record.h: Rename include guard.
4706         * linux-nat.h: Add include guard.
4707         * linux-fork.h: Add include guard.
4708         * i386-darwin-tdep.h: Rename include guard.
4709         * hppa-linux-offsets.h: Add include guard.
4710         * guile/guile.h: Rename include guard.
4711         * guile/guile-internal.h: Rename include guard.
4712         * gnu-nat.h: Rename include guard.
4713         * gdb-stabs.h: Rename include guard.
4714         * frv-tdep.h: Add include guard.
4715         * f-lang.h: Add include guard.
4716         * event-loop.h: Add include guard.
4717         * darwin-nat.h: Rename include guard.
4718         * cp-abi.h: Rename include guard.
4719         * config/sparc/nm-sol2.h: Rename include guard.
4720         * config/nm-nto.h: Rename include guard.
4721         * config/nm-linux.h: Add include guard.
4722         * config/i386/nm-i386gnu.h: Rename include guard.
4723         * config/djgpp/nl_types.h: Rename include guard.
4724         * config/djgpp/langinfo.h: Rename include guard.
4725         * compile/gcc-cp-plugin.h: Add include guard.
4726         * compile/gcc-c-plugin.h: Add include guard.
4727         * compile/compile.h: Rename include guard.
4728         * compile/compile-object-run.h: Rename include guard.
4729         * compile/compile-object-load.h: Rename include guard.
4730         * compile/compile-internal.h: Rename include guard.
4731         * compile/compile-cplus.h: Rename include guard.
4732         * compile/compile-c.h: Rename include guard.
4733         * common/xml-utils.h: Rename include guard.
4734         * common/x86-xstate.h: Rename include guard.
4735         * common/version.h: Rename include guard.
4736         * common/vec.h: Rename include guard.
4737         * common/tdesc.h: Rename include guard.
4738         * common/selftest.h: Rename include guard.
4739         * common/scoped_restore.h: Rename include guard.
4740         * common/scoped_mmap.h: Rename include guard.
4741         * common/scoped_fd.h: Rename include guard.
4742         * common/safe-iterator.h: Rename include guard.
4743         * common/run-time-clock.h: Rename include guard.
4744         * common/refcounted-object.h: Rename include guard.
4745         * common/queue.h: Rename include guard.
4746         * common/ptid.h: Rename include guard.
4747         * common/print-utils.h: Rename include guard.
4748         * common/preprocessor.h: Rename include guard.
4749         * common/pathstuff.h: Rename include guard.
4750         * common/observable.h: Rename include guard.
4751         * common/netstuff.h: Rename include guard.
4752         * common/job-control.h: Rename include guard.
4753         * common/host-defs.h: Rename include guard.
4754         * common/gdb_wait.h: Rename include guard.
4755         * common/gdb_vecs.h: Rename include guard.
4756         * common/gdb_unlinker.h: Rename include guard.
4757         * common/gdb_unique_ptr.h: Rename include guard.
4758         * common/gdb_tilde_expand.h: Rename include guard.
4759         * common/gdb_sys_time.h: Rename include guard.
4760         * common/gdb_string_view.h: Rename include guard.
4761         * common/gdb_splay_tree.h: Rename include guard.
4762         * common/gdb_setjmp.h: Rename include guard.
4763         * common/gdb_ref_ptr.h: Rename include guard.
4764         * common/gdb_optional.h: Rename include guard.
4765         * common/gdb_locale.h: Rename include guard.
4766         * common/gdb_assert.h: Rename include guard.
4767         * common/filtered-iterator.h: Rename include guard.
4768         * common/filestuff.h: Rename include guard.
4769         * common/fileio.h: Rename include guard.
4770         * common/environ.h: Rename include guard.
4771         * common/common-utils.h: Rename include guard.
4772         * common/common-types.h: Rename include guard.
4773         * common/common-regcache.h: Rename include guard.
4774         * common/common-inferior.h: Rename include guard.
4775         * common/common-gdbthread.h: Rename include guard.
4776         * common/common-exceptions.h: Rename include guard.
4777         * common/common-defs.h: Rename include guard.
4778         * common/common-debug.h: Rename include guard.
4779         * common/cleanups.h: Rename include guard.
4780         * common/buffer.h: Rename include guard.
4781         * common/btrace-common.h: Rename include guard.
4782         * common/break-common.h: Rename include guard.
4783         * cli/cli-utils.h: Rename include guard.
4784         * cli/cli-style.h: Rename include guard.
4785         * cli/cli-setshow.h: Rename include guard.
4786         * cli/cli-script.h: Rename include guard.
4787         * cli/cli-interp.h: Rename include guard.
4788         * cli/cli-decode.h: Rename include guard.
4789         * cli/cli-cmds.h: Rename include guard.
4790         * charset-list.h: Add include guard.
4791         * buildsym-legacy.h: Rename include guard.
4792         * bfin-tdep.h: Add include guard.
4793         * ax.h: Rename include guard.
4794         * arm-linux-tdep.h: Add include guard.
4795         * arm-fbsd-tdep.h: Add include guard.
4796         * arch/xtensa.h: Rename include guard.
4797         * arch/tic6x.h: Add include guard.
4798         * arch/i386.h: Add include guard.
4799         * arch/arm.h: Rename include guard.
4800         * arch/arm-linux.h: Rename include guard.
4801         * arch/arm-get-next-pcs.h: Rename include guard.
4802         * arch/amd64.h: Add include guard.
4803         * arch/aarch64-insn.h: Rename include guard.
4804         * arch-utils.h: Rename include guard.
4805         * annotate.h: Add include guard.
4806         * amd64-darwin-tdep.h: Rename include guard.
4807         * aarch64-linux-tdep.h: Add include guard.
4808         * aarch64-fbsd-tdep.h: Add include guard.
4809         * aarch32-linux-nat.h: Add include guard.
4810
4811 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4812
4813         * macrotab.c (macro_define_internal): New function that
4814         factorizes macro_define_object_internal and macro_define_function
4815         code.
4816         (macro_define_object_internal): Use macro_define_internal.
4817         (macro_define_function): Likewise.
4818
4819 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4820
4821         * macrocmd.c (extract_identifier): Return
4822         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4823         callers.
4824
4825 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4826
4827         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4828
4829 2019-02-05  Tom Tromey  <tom@tromey.com>
4830
4831         * target.c (target_stack::unpush): Move assertion earlier.
4832
4833 2019-01-30  Tom Tromey  <tom@tromey.com>
4834
4835         PR python/23615:
4836         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4837         (gdbpy_parse_and_eval): Likewise.
4838         * python/python-internal.h (gdbpy_allow_threads): New class.
4839
4840 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4841
4842         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4843         (aarch64_fbsd_fpregmap): Move earlier.
4844         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4845         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4846         instead of individual calls to trad_frame_set_reg_addr.
4847         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4848         earlier.
4849         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4850         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4851         instead of individual calls to trad_frame_set_reg_addr.
4852
4853 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4854
4855         * CONTRIBUTE: Replace contribution list with wiki link.
4856
4857 2019-01-25  Tom Tromey  <tom@tromey.com>
4858
4859         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4860
4861 2019-01-25  Tom Tromey  <tom@tromey.com>
4862
4863         * xtensa-linux-nat.c: Fix common/ includes.
4864         * xml-support.h: Fix common/ includes.
4865         * xml-support.c: Fix common/ includes.
4866         * x86-linux-nat.c: Fix common/ includes.
4867         * windows-nat.c: Fix common/ includes.
4868         * varobj.h: Fix common/ includes.
4869         * varobj.c: Fix common/ includes.
4870         * value.c: Fix common/ includes.
4871         * valops.c: Fix common/ includes.
4872         * utils.c: Fix common/ includes.
4873         * unittests/xml-utils-selftests.c: Fix common/ includes.
4874         * unittests/utils-selftests.c: Fix common/ includes.
4875         * unittests/unpack-selftests.c: Fix common/ includes.
4876         * unittests/tracepoint-selftests.c: Fix common/ includes.
4877         * unittests/style-selftests.c: Fix common/ includes.
4878         * unittests/string_view-selftests.c: Fix common/ includes.
4879         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4880         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4881         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4882         * unittests/rsp-low-selftests.c: Fix common/ includes.
4883         * unittests/parse-connection-spec-selftests.c: Fix common/
4884         includes.
4885         * unittests/optional-selftests.c: Fix common/ includes.
4886         * unittests/offset-type-selftests.c: Fix common/ includes.
4887         * unittests/observable-selftests.c: Fix common/ includes.
4888         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4889         * unittests/memrange-selftests.c: Fix common/ includes.
4890         * unittests/memory-map-selftests.c: Fix common/ includes.
4891         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4892         * unittests/function-view-selftests.c: Fix common/ includes.
4893         * unittests/environ-selftests.c: Fix common/ includes.
4894         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4895         * unittests/common-utils-selftests.c: Fix common/ includes.
4896         * unittests/cli-utils-selftests.c: Fix common/ includes.
4897         * unittests/array-view-selftests.c: Fix common/ includes.
4898         * ui-file.c: Fix common/ includes.
4899         * tui/tui-io.c: Fix common/ includes.
4900         * tracepoint.h: Fix common/ includes.
4901         * tracepoint.c: Fix common/ includes.
4902         * tracefile-tfile.c: Fix common/ includes.
4903         * top.h: Fix common/ includes.
4904         * top.c: Fix common/ includes.
4905         * thread.c: Fix common/ includes.
4906         * target/waitstatus.h: Fix common/ includes.
4907         * target/waitstatus.c: Fix common/ includes.
4908         * target.h: Fix common/ includes.
4909         * target.c: Fix common/ includes.
4910         * target-memory.c: Fix common/ includes.
4911         * target-descriptions.c: Fix common/ includes.
4912         * symtab.h: Fix common/ includes.
4913         * symfile.c: Fix common/ includes.
4914         * stap-probe.c: Fix common/ includes.
4915         * spu-linux-nat.c: Fix common/ includes.
4916         * sparc-nat.c: Fix common/ includes.
4917         * source.c: Fix common/ includes.
4918         * solib.c: Fix common/ includes.
4919         * solib-target.c: Fix common/ includes.
4920         * ser-unix.c: Fix common/ includes.
4921         * ser-tcp.c: Fix common/ includes.
4922         * ser-pipe.c: Fix common/ includes.
4923         * ser-base.c: Fix common/ includes.
4924         * selftest-arch.c: Fix common/ includes.
4925         * s12z-tdep.c: Fix common/ includes.
4926         * rust-exp.y: Fix common/ includes.
4927         * rs6000-aix-tdep.c: Fix common/ includes.
4928         * riscv-tdep.c: Fix common/ includes.
4929         * remote.c: Fix common/ includes.
4930         * remote-notif.h: Fix common/ includes.
4931         * remote-fileio.h: Fix common/ includes.
4932         * remote-fileio.c: Fix common/ includes.
4933         * regcache.h: Fix common/ includes.
4934         * regcache.c: Fix common/ includes.
4935         * record-btrace.c: Fix common/ includes.
4936         * python/python.c: Fix common/ includes.
4937         * python/py-type.c: Fix common/ includes.
4938         * python/py-inferior.c: Fix common/ includes.
4939         * progspace.h: Fix common/ includes.
4940         * producer.c: Fix common/ includes.
4941         * procfs.c: Fix common/ includes.
4942         * proc-api.c: Fix common/ includes.
4943         * printcmd.c: Fix common/ includes.
4944         * ppc-linux-nat.c: Fix common/ includes.
4945         * parser-defs.h: Fix common/ includes.
4946         * osdata.c: Fix common/ includes.
4947         * obsd-nat.c: Fix common/ includes.
4948         * nat/x86-linux.c: Fix common/ includes.
4949         * nat/x86-linux-dregs.c: Fix common/ includes.
4950         * nat/x86-dregs.h: Fix common/ includes.
4951         * nat/x86-dregs.c: Fix common/ includes.
4952         * nat/ppc-linux.c: Fix common/ includes.
4953         * nat/mips-linux-watch.h: Fix common/ includes.
4954         * nat/mips-linux-watch.c: Fix common/ includes.
4955         * nat/linux-waitpid.c: Fix common/ includes.
4956         * nat/linux-ptrace.h: Fix common/ includes.
4957         * nat/linux-ptrace.c: Fix common/ includes.
4958         * nat/linux-procfs.c: Fix common/ includes.
4959         * nat/linux-personality.c: Fix common/ includes.
4960         * nat/linux-osdata.c: Fix common/ includes.
4961         * nat/linux-namespaces.c: Fix common/ includes.
4962         * nat/linux-btrace.h: Fix common/ includes.
4963         * nat/linux-btrace.c: Fix common/ includes.
4964         * nat/fork-inferior.c: Fix common/ includes.
4965         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4966         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4967         * nat/aarch64-linux.c: Fix common/ includes.
4968         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4969         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4970         * namespace.h: Fix common/ includes.
4971         * mips-linux-tdep.c: Fix common/ includes.
4972         * minsyms.c: Fix common/ includes.
4973         * mi/mi-parse.h: Fix common/ includes.
4974         * mi/mi-main.c: Fix common/ includes.
4975         * mi/mi-cmd-env.c: Fix common/ includes.
4976         * memrange.h: Fix common/ includes.
4977         * memattr.c: Fix common/ includes.
4978         * maint.h: Fix common/ includes.
4979         * maint.c: Fix common/ includes.
4980         * main.c: Fix common/ includes.
4981         * machoread.c: Fix common/ includes.
4982         * location.c: Fix common/ includes.
4983         * linux-thread-db.c: Fix common/ includes.
4984         * linux-nat.c: Fix common/ includes.
4985         * linux-fork.c: Fix common/ includes.
4986         * inline-frame.c: Fix common/ includes.
4987         * infrun.c: Fix common/ includes.
4988         * inflow.c: Fix common/ includes.
4989         * inferior.h: Fix common/ includes.
4990         * inferior.c: Fix common/ includes.
4991         * infcmd.c: Fix common/ includes.
4992         * inf-ptrace.c: Fix common/ includes.
4993         * inf-child.c: Fix common/ includes.
4994         * ia64-linux-nat.c: Fix common/ includes.
4995         * i387-tdep.c: Fix common/ includes.
4996         * i386-tdep.c: Fix common/ includes.
4997         * i386-linux-tdep.c: Fix common/ includes.
4998         * i386-linux-nat.c: Fix common/ includes.
4999         * i386-go32-tdep.c: Fix common/ includes.
5000         * i386-fbsd-tdep.c: Fix common/ includes.
5001         * i386-fbsd-nat.c: Fix common/ includes.
5002         * guile/scm-type.c: Fix common/ includes.
5003         * guile/guile.c: Fix common/ includes.
5004         * go32-nat.c: Fix common/ includes.
5005         * gnu-nat.c: Fix common/ includes.
5006         * gdbthread.h: Fix common/ includes.
5007         * gdbarch-selftests.c: Fix common/ includes.
5008         * gdb_usleep.c: Fix common/ includes.
5009         * gdb_select.h: Fix common/ includes.
5010         * gdb_bfd.c: Fix common/ includes.
5011         * gcore.c: Fix common/ includes.
5012         * fork-child.c: Fix common/ includes.
5013         * findvar.c: Fix common/ includes.
5014         * fbsd-nat.c: Fix common/ includes.
5015         * event-top.c: Fix common/ includes.
5016         * event-loop.c: Fix common/ includes.
5017         * dwarf2read.c: Fix common/ includes.
5018         * dwarf2loc.c: Fix common/ includes.
5019         * dwarf2-frame.c: Fix common/ includes.
5020         * dwarf-index-cache.c: Fix common/ includes.
5021         * dtrace-probe.c: Fix common/ includes.
5022         * disasm-selftests.c: Fix common/ includes.
5023         * defs.h: Fix common/ includes.
5024         * csky-tdep.c: Fix common/ includes.
5025         * cp-valprint.c: Fix common/ includes.
5026         * cp-support.h: Fix common/ includes.
5027         * cp-support.c: Fix common/ includes.
5028         * corelow.c: Fix common/ includes.
5029         * completer.h: Fix common/ includes.
5030         * completer.c: Fix common/ includes.
5031         * compile/compile.c: Fix common/ includes.
5032         * compile/compile-loc2c.c: Fix common/ includes.
5033         * compile/compile-cplus-types.c: Fix common/ includes.
5034         * compile/compile-cplus-symbols.c: Fix common/ includes.
5035         * command.h: Fix common/ includes.
5036         * cli/cli-dump.c: Fix common/ includes.
5037         * cli/cli-cmds.c: Fix common/ includes.
5038         * charset.c: Fix common/ includes.
5039         * build-id.c: Fix common/ includes.
5040         * btrace.h: Fix common/ includes.
5041         * btrace.c: Fix common/ includes.
5042         * breakpoint.h: Fix common/ includes.
5043         * breakpoint.c: Fix common/ includes.
5044         * ax.h:
5045         (enum agent_op): Fix common/ includes.
5046         * ax-general.c (struct aop_map): Fix common/ includes.
5047         * ax-gdb.c: Fix common/ includes.
5048         * auxv.c: Fix common/ includes.
5049         * auto-load.c: Fix common/ includes.
5050         * arm-tdep.c: Fix common/ includes.
5051         * arch/riscv.c: Fix common/ includes.
5052         * arch/ppc-linux-common.c: Fix common/ includes.
5053         * arch/i386.c: Fix common/ includes.
5054         * arch/arm.c: Fix common/ includes.
5055         * arch/arm-linux.c: Fix common/ includes.
5056         * arch/arm-get-next-pcs.c: Fix common/ includes.
5057         * arch/amd64.c: Fix common/ includes.
5058         * arch/aarch64.c: Fix common/ includes.
5059         * arch/aarch64-insn.c: Fix common/ includes.
5060         * arch-utils.c: Fix common/ includes.
5061         * amd64-windows-tdep.c: Fix common/ includes.
5062         * amd64-tdep.c: Fix common/ includes.
5063         * amd64-sol2-tdep.c: Fix common/ includes.
5064         * amd64-obsd-tdep.c: Fix common/ includes.
5065         * amd64-nbsd-tdep.c: Fix common/ includes.
5066         * amd64-linux-tdep.c: Fix common/ includes.
5067         * amd64-linux-nat.c: Fix common/ includes.
5068         * amd64-fbsd-tdep.c: Fix common/ includes.
5069         * amd64-fbsd-nat.c: Fix common/ includes.
5070         * amd64-dicos-tdep.c: Fix common/ includes.
5071         * amd64-darwin-tdep.c: Fix common/ includes.
5072         * agent.c: Fix common/ includes.
5073         * ada-lang.h: Fix common/ includes.
5074         * ada-lang.c: Fix common/ includes.
5075         * aarch64-tdep.c: Fix common/ includes.
5076
5077 2019-01-25  Tom Tromey  <tom@tromey.com>
5078
5079         * common/create-version.sh: Use common/version.h.
5080
5081 2019-01-24  Pedro Alves  <palves@redhat.com>
5082
5083         * infrun.c (signal_stop, signal_print, signal_program)
5084         (signal_catch, signal_pass): Now arrays instead of pointers.
5085         (update_signals_program_target, do_target_resume)
5086         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5087         * linux-nat.c (linux_nat_target::pass_signals)
5088         (linux_nat_target::create_inferior, linux_nat_target::attach):
5089         Adjust.
5090         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5091         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5092         * procfs.c (procfs_target::pass_signals): Adjust.
5093         * record-full.c (record_full_target::resume): Adjust.
5094         * remote.c (remote_target::pass_signals)
5095         (remote_target::program_signals): Adjust.
5096         * target-debug.h (target_debug_print_signals): Now takes a
5097         gdb::array_view as parameter.  Adjust.
5098         * target.h (target_ops) <pass_signals, program_signals>: Replace
5099         pointer and length parameters with gdb::array_view.
5100         (target_pass_signals, target_program_signals): Likewise.
5101         * target-delegates.c: Regenerate.
5102
5103 2019-01-24  Pedro Alves  <palves@redhat.com>
5104
5105         * common/forward-scope-exit.h
5106         (forward_scope_exit::forward_scope_exit): Pass arguments to
5107         m_bind_function directly, instead of creating a std::bind and
5108         copying that.
5109
5110 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5111
5112         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5113         for static members.
5114         (pass_in_v_vfp_candidate): Likewise.
5115
5116 2019-01-23  Tom Tromey  <tom@tromey.com>
5117             Pedro Alves  <palves@redhat.com>
5118
5119         * regcache.c (class regcache_invalidator): Remove.
5120         (regcache::raw_write): Use make_scope_exit.
5121
5122 2019-01-23  Tom Tromey  <tom@tromey.com>
5123
5124         * ui-out.h (class ui_out_emit_type): Update comment.
5125
5126 2019-01-23  Tom Tromey  <tom@tromey.com>
5127
5128         * infrun.c (fetch_inferior_event): Update comment.
5129
5130 2019-01-23  Tom Tromey  <tom@tromey.com>
5131             Pedro Alves  <palves@redhat.com>
5132
5133         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5134         parameter.
5135         (fetch_inferior_event): Use SCOPE_EXIT.
5136
5137
5138 2019-01-23  Tom Tromey  <tom@tromey.com>
5139             Pedro Alves  <palves@redhat.com>
5140
5141         * infrun.c (disable_thread_events): Delete.
5142         (stop_all_threads): Use SCOPE_EXIT.
5143
5144 2019-01-23  Tom Tromey  <tom@tromey.com>
5145             Pedro Alves  <palves@redhat.com>
5146
5147         * symfile.c: Include forward-scope-exit.h.
5148         (clear_symtab_users_cleanup): Replace forward declaration with
5149         a FORWARD_SCOPE_EXIT.
5150         (syms_from_objfile_1): Use the forward_scope_exit and
5151         gdb::optional instead of cleanup_function.
5152         (reread_symbols): Use the forward_scope_exit instead of
5153         cleanup_function.
5154         (clear_symtab_users_cleanup): Remove function.
5155
5156 2019-01-23  Tom Tromey  <tom@tromey.com>
5157             Pedro Alves  <palves@redhat.com>
5158
5159         * linux-nat.c: Include scope-exit.h.
5160         (cleanup_target_stop): Remove.
5161         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5162         SCOPE_EXIT.
5163
5164 2019-01-23  Tom Tromey  <tom@tromey.com>
5165             Pedro Alves  <palves@redhat.com>
5166
5167         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5168         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5169
5170 2019-01-23  Tom Tromey  <tom@tromey.com>
5171             Andrew Burgess  <andrew.burgess@embecosm.com>
5172             Pedro Alves  <palves@redhat.com>
5173
5174         * infrun.c (fetch_inferior_event): Use scope_exit.
5175         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5176         * top.c (execute_command): Use scope_exit.
5177         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5178         * utils.c (do_bpstat_clear_actions_cleanup)
5179         (make_bpstat_clear_actions_cleanup): Remove.
5180
5181 2019-01-23  Tom Tromey  <tom@tromey.com>
5182             Pedro Alves  <palves@redhat.com>
5183
5184         * infrun.c: Include "common/scope-exit.h"
5185         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5186         (wait_for_inferior): Use SCOPE_EXIT.
5187         (fetch_inferior_event): Use scope_exit.
5188
5189 2019-01-23  Tom Tromey  <tom@tromey.com>
5190             Pedro Alves  <palves@redhat.com>
5191
5192         * breakpoint.c (create_breakpoint): Remove cleanup.
5193
5194 2019-01-23  Tom Tromey  <tom@tromey.com>
5195             Andrew Burgess  <andrew.burgess@embecosm.com>
5196             Pedro Alves  <palves@redhat.com>
5197
5198 2019-01-23  Pedro Alves  <palves@redhat.com>
5199
5200         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5201
5202 2019-01-23  Pedro Alves  <palves@redhat.com>
5203             Andrew Burgess  <andrew.burgess@embecosm.com>
5204
5205         * gdbthread.h: Include "common/forward-scope-exit.h".
5206         (scoped_finish_thread_state): Redefine custom class in terms of
5207         forward_scope_exit.
5208
5209 2019-01-23  Pedro Alves  <palves@redhat.com>
5210             Andrew Burgess  <andrew.burgess@embecosm.com>
5211
5212         * common/forward-scope-exit.h: New file.
5213
5214 2019-01-23  Pedro Alves  <palves@redhat.com>
5215             Andrew Burgess  <andrew.burgess@embecosm.com>
5216             Tom Tromey  <tom@tromey.com>
5217
5218         * common/scope-exit.h: New file.
5219
5220 2019-01-23  Pedro Alves  <palves@redhat.com>
5221
5222         * common/preprocessor.h (ESC): Rename to ...
5223         (ESC_PARENS): ... this.
5224         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5225         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5226
5227 2019-01-23  Tom Tromey  <tom@tromey.com>
5228
5229         * language.h (class scoped_switch_to_sym_language_if_auto):
5230         Initialize m_lang in both cases.
5231
5232 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5233
5234         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5235         with XCNEW.
5236
5237 2019-01-22  Tom Tromey  <tom@tromey.com>
5238
5239         * corelow.c: Do not include sys/file.h.
5240
5241 2019-01-22  Tom Tromey  <tom@tromey.com>
5242
5243         * tui/tui-wingeneral.h: Include gdb_curses.h.
5244
5245 2019-01-22  Tom Tromey  <tom@tromey.com>
5246
5247         * source-cache.h (class source_cache) <get_source_lines,
5248         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5249
5250 2019-01-22  Tom Tromey  <tom@tromey.com>
5251
5252         * remote-fileio.h (struct remote_target): Declare.
5253
5254 2019-01-22  Tom Tromey  <tom@tromey.com>
5255
5256         * python/py-arch.c: Do not include py-ref.h.
5257         * python/py-bpevent.c: Do not include py-ref.h.
5258         * python/py-cmd.c: Do not include py-ref.h.
5259         * python/py-continueevent.c: Do not include py-ref.h.
5260         * python/py-event.h: Do not include py-ref.h.
5261         * python/py-evtregistry.c: Do not include py-ref.h.
5262         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5263         * python/py-frame.c: Do not include py-ref.h.
5264         * python/py-framefilter.c: Do not include py-ref.h.
5265         * python/py-function.c: Do not include py-ref.h.
5266         * python/py-infevents.c: Do not include py-ref.h.
5267         * python/py-linetable.c: Do not include py-ref.h.
5268         * python/py-objfile.c: Do not include py-ref.h.
5269         * python/py-param.c: Do not include py-ref.h.
5270         * python/py-prettyprint.c: Do not include py-ref.h.
5271         * python/py-progspace.c: Do not include py-ref.h.
5272         * python/py-symbol.c: Do not include py-ref.h.
5273         * python/py-symtab.c: Do not include py-ref.h.
5274         * python/py-type.c: Do not include py-ref.h.
5275         * python/py-unwind.c: Do not include py-ref.h.
5276         * python/py-utils.c: Do not include py-ref.h.
5277         * python/py-value.c: Do not include py-ref.h.
5278         * python/py-varobj.c: Do not include py-ref.h.
5279         * python/py-xmethods.c: Do not include py-ref.h.
5280         * python/python.c: Do not include py-ref.h.
5281         * varobj.c: Do not include py-ref.h.
5282
5283 2019-01-22  Tom Tromey  <tom@tromey.com>
5284
5285         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5286         keyword for bcache.
5287
5288 2019-01-22  Tom Tromey  <tom@tromey.com>
5289
5290         * compile/compile-cplus-types.c: Remove a comment by #include.
5291
5292 2019-01-22  Tom Tromey  <tom@tromey.com>
5293
5294         * compile/gcc-c-plugin.h: Include compile-internal.h.
5295
5296 2019-01-22  Tom Tromey  <tom@tromey.com>
5297
5298         * stabsread.c (EXTERN): Do not define.
5299         (symnum, next_symbol_text_func, processing_gcc_compilation)
5300         (within_function, global_sym_chain, global_stabs)
5301         (previous_stab_code, this_object_header_files)
5302         (n_this_object_header_files)
5303         (n_allocated_this_object_header_files): Define.
5304         * stabsread.h (EXTERN): Never define.  Use "extern".
5305
5306 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5307
5308         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5309         history_value.
5310
5311 2019-01-21  Tom Tromey  <tom@tromey.com>
5312
5313         * ui-out.c: Fix includes.
5314         * tui/tui-source.c: Fix includes.
5315         * target.c: Fix includes.
5316         * remote.c: Fix includes.
5317         * regcache.c: Fix includes.
5318         * python/py-block.c: Fix includes.
5319         * printcmd.c: Fix includes.
5320         * or1k-tdep.c: Fix includes.
5321         * mi/mi-main.c: Fix includes.
5322         * m32r-tdep.c: Fix includes.
5323         * csky-tdep.c: Fix includes.
5324         * compile/compile-cplus-types.c: Fix includes.
5325         * cli/cli-interp.c: Fix includes.
5326
5327 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5328
5329         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5330         for padding.
5331
5332 2019-01-16  Tom Tromey  <tom@tromey.com>
5333
5334         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5335         earlier.
5336         (struct objfile) <msymbols_range>: Move from top level.
5337         <msymbols>: New method.
5338         (class objfile_msymbols): Remove.
5339         * symtab.c (default_collect_symbol_completion_matches_break_on):
5340         Update.
5341         * symmisc.c (dump_msymbols): Update.
5342         * stabsread.c (scan_file_globals): Update.
5343         * objc-lang.c (info_selectors_command, info_classes_command)
5344         (find_methods): Update.
5345         * minsyms.c (find_solib_trampoline_target): Update.
5346         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5347         * coffread.c (coff_symfile_read): Update.
5348         * ada-lang.c (ada_lookup_simple_minsym)
5349         (ada_collect_symbol_completion_matches): Update.
5350
5351 2019-01-16  Tom Tromey  <tom@tromey.com>
5352
5353         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5354         type.  Remove no-argument constructor.
5355         <iterator::operator++>: Simplify.
5356         <begin>: Update.
5357         <end>: Use minimal_symbol_count.
5358
5359 2019-01-16  Tom Tromey  <tom@tromey.com>
5360
5361         * objfiles.h (struct objfile) <psymtabs>: New method.
5362         (class objfile_psymtabs): Remove.
5363         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5364         typedef.
5365         <range>: New method.
5366         (require_partial_symbols): Change return type.
5367         * psymtab.c (require_partial_symbols)
5368         (psym_expand_symtabs_matching): Update.
5369         * mdebugread.c (parse_partial_symbols): Update.
5370         * dbxread.c (dbx_end_psymtab): Update.
5371
5372 2019-01-15  Tom Tromey  <tom@tromey.com>
5373
5374         * symtab.c (lookup_objfile_from_block)
5375         (lookup_symbol_in_objfile_symtabs)
5376         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5377         (find_line_symtab, info_sources_command)
5378         (default_collect_symbol_completion_matches_break_on)
5379         (make_source_files_completion_list): Update.
5380         * symmisc.c (print_objfile_statistics, dump_objfile)
5381         (maintenance_print_symbols, maintenance_info_symtabs)
5382         (maintenance_check_symtabs, maintenance_info_line_tables):
5383         Update.
5384         * source.c (select_source_symtab)
5385         (forget_cached_source_info_for_objfile): Update.
5386         * objfiles.h (class objfile_compunits): Remove.
5387         (struct objfile) <compunits_range>: New typedef.
5388         (compunits): New method.
5389         * objfiles.c (objfile_relocate1): Update.
5390         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5391         * maint.c (count_symtabs_and_blocks): Update.
5392         * linespec.c (iterate_over_all_matching_symtabs): Update.
5393         * cp-support.c (add_symbol_overload_list_qualified): Update.
5394         * coffread.c (coff_symtab_read): Update.
5395         * ada-lang.c (add_nonlocal_symbols)
5396         (ada_collect_symbol_completion_matches)
5397         (ada_add_global_exceptions): Update.
5398
5399 2019-01-15  Tom Tromey  <tom@tromey.com>
5400
5401         * progspace.h (program_space) <objfiles_safe_range>: New
5402         typedef.
5403         <objfiles_safe>: New method.
5404         * objfiles.h (class all_objfiles_safe): Remove.
5405         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5406         * jit.c (jit_inferior_exit_hook): Update.
5407
5408 2019-01-17  Tom Tromey  <tom@tromey.com>
5409
5410         * progspace.h (program_space) <objfiles_range>: New typedef.
5411         <objfiles>: New method.
5412         <objfiles_head>: Rename from objfiles.
5413         (object_files): Update.
5414         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5415         * guile/scm-pretty-print.c
5416         (ppscm_find_pretty_printer_from_objfiles): Update.
5417         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5418         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5419         Update.
5420         * python/py-progspace.c (pspy_get_objfiles): Update.
5421         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5422         Update.
5423         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5424         (objfpy_lookup_objfile_by_build_id): Update.
5425         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5426         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5427         Update.
5428         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5429         (expand_symtab_containing_pc, lookup_objfile_from_block)
5430         (lookup_static_symbol, basic_lookup_transparent_type)
5431         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5432         (find_line_symtab, info_sources_command)
5433         (default_collect_symbol_completion_matches_break_on)
5434         (make_source_files_completion_list, find_main_name): Update.
5435         * symmisc.c (print_symbol_bcache_statistics)
5436         (print_objfile_statistics, maintenance_print_symbols)
5437         (maintenance_print_msymbols, maintenance_print_objfiles)
5438         (maintenance_info_symtabs, maintenance_check_symtabs)
5439         (maintenance_expand_symtabs, maintenance_info_line_tables):
5440         Update.
5441         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5442         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5443         (map_overlay_command, unmap_overlay_command)
5444         (simple_overlay_update, expand_symtabs_matching)
5445         (map_symbol_filenames): Update.
5446         * symfile-debug.c (set_debug_symfile): Update.
5447         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5448         Update.
5449         * source.c (select_source_symtab, forget_cached_source_info):
5450         Update.
5451         * solib.c (solib_read_symbols): Update.
5452         * solib-spu.c (append_ocl_sos): Update.
5453         * psymtab.c (maintenance_print_psymbols)
5454         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5455         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5456         * printcmd.c (info_symbol_command): Update.
5457         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5458         Update.
5459         * objfiles.h (class all_objfiles): Remove.
5460         * objfiles.c (have_partial_symbols, have_full_symbols)
5461         (have_minimal_symbols, qsort_cmp, update_section_map)
5462         (shared_objfile_contains_address_p)
5463         (default_iterate_over_objfiles_in_search_order): Update.
5464         * objc-lang.c (info_selectors_command, info_classes_command)
5465         (find_methods): Update.
5466         * minsyms.c (find_solib_trampoline_target): Update.
5467         * maint.c (maintenance_info_sections)
5468         (maintenance_translate_address, count_symtabs_and_blocks):
5469         Update.
5470         * main.c (captured_main_1): Update.
5471         * linux-thread-db.c (try_thread_db_load_from_pdir)
5472         (has_libpthread): Update.
5473         * linespec.c (iterate_over_all_matching_symtabs)
5474         (search_minsyms_for_name): Update.
5475         * jit.c (jit_find_objf_with_entry_addr): Update.
5476         * hppa-tdep.c (find_unwind_entry)
5477         (hppa_lookup_stub_minimal_symbol): Update.
5478         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5479         Update.
5480         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5481         (elf_gnu_ifunc_resolve_by_got): Update.
5482         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5483         * dwarf-index-write.c (save_gdb_index_command): Update.
5484         * cp-support.c (add_symbol_overload_list_qualified): Update.
5485         * breakpoint.c (create_overlay_event_breakpoint)
5486         (create_longjmp_master_breakpoint)
5487         (create_std_terminate_master_breakpoint)
5488         (create_exception_master_breakpoint): Update.
5489         * blockframe.c (find_pc_partial_function): Update.
5490         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5491         (ada_collect_symbol_completion_matches)
5492         (ada_add_global_exceptions): Update.
5493
5494 2019-01-17  Tom Tromey  <tom@tromey.com>
5495
5496         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5497         declare VEC.
5498         (solib_target_parse_libraries): Change return type.
5499         (library_list_start_segment, library_list_start_section)
5500         (library_list_end_library, library_list_start_library); Update.
5501         (solib_target_free_library_list): Remove.
5502         (solib_target_parse_libraries): Remove cleanup.  Change return
5503         type.
5504         (solib_target_current_sos): Update.
5505
5506 2019-01-17  Tom Tromey  <tromey@bapiya>
5507
5508         * valprint.c: Replace "the the" with "the".
5509         * symtab.c: Replace "the the" with "the".
5510         * solib.c: Replace "the the" with "the".
5511         * solib-dsbt.c: Replace "the the" with "the".
5512         * linespec.c: Replace "the the" with "the".
5513         * dwarf2loc.h: Replace "the the" with "the".
5514         * amd64-windows-tdep.c: Replace "the the" with "the".
5515         * aarch64-tdep.c: Replace "the the" with "the".
5516
5517 2019-01-16  Keith Seitz  <keiths@redhat.com>
5518
5519         PR gdb/23773
5520         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5521         <builder>: Rename to ..
5522         <m_builder>: ... this and make private.
5523         (dwarf2_cu::get_builder): New method.  Change all users of
5524         `builder' to use this method.
5525         (dwarf2_start_symtab): Move to ...
5526         (dwarf2_cu::start_symtab): ... here.  Update all callers
5527         (setup_type_unit_groups): Move to ...
5528         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5529         callers.
5530         (dwarf2_cu::reset_builder): New method.
5531         (process_full_compunit, process_full_type_unit): Use
5532         dwarf2_cu::reset_builder.
5533         (follow_die_offset): Record the ancestor CU if it is different
5534         from the followed DIE's CU.
5535         (follow_die_sig_1): Likewise.
5536
5537 2019-01-15  Tom Tromey  <tom@tromey.com>
5538
5539         * remote.c (class remote_state) <buf>: Now a char_vector.
5540         <buf_size>: Remove.
5541         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5542         parameter.
5543         (remote_target::getpkt_or_notif_sane_1)
5544         (remote_target::getpkt_sane)
5545         (remote_target::getpkt_or_notif_sane): Likewise.
5546         (class remote_target) <putpkt>: New overload.
5547         (remote_target::read_frame): Change type of "buf_p".  Remove
5548         sizeof_p parameter.
5549         (packet_ok): New overload.
5550         (packet_check_result): New overload.
5551         Update all uses.
5552
5553 2019-01-14  Tom Tromey  <tom@tromey.com>
5554
5555         * remote-notif.c (handle_notification, remote_notif_ack)
5556         (remote_notif_parse): Make "buf" const.
5557         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5558         const.
5559         (remote_notif_parse, remote_notif_ack, handle_notification):
5560         Likewise.
5561         * remote.c (remote_notif_stop_parse): Make "buf" const.
5562         (remote_target::remote_parse_stop_reply): Make "buf" const.
5563         (remote_notif_stop_ack): Make "buf" const.
5564
5565 2019-01-14  Tom Tromey  <tom@tromey.com>
5566
5567         * remote.c (remote_console_output): Make parameter const.
5568
5569 2019-01-14  Tom Tromey  <tom@tromey.com>
5570
5571         * target-debug.h (target_debug_print_signals): Constify.
5572         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5573         * procfs.c (procfs_target::pass_signals): Update.
5574         * linux-nat.c (linux_nat_target::pass_signals): Update.
5575         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5576         * target-delegates.c: Rebuild.
5577         * remote.c (remote_target::program_signals): Update.
5578         (remote_target::pass_signals): Update.
5579         * target.c (target_pass_signals): Constify argument.
5580         (target_program_signals): Likewise.
5581         * target.h (struct target_ops) <pass_signals, program_signals>:
5582         Constify argument.
5583         (target_pass_signals, target_program_signals): Constify argument.
5584
5585 2019-01-14  Tom Tromey  <tom@tromey.com>
5586
5587         PR tui/28819:
5588         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5589
5590 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5591
5592         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5593         field.
5594         * rs6000-tdep.c: Include reggroups.h.
5595         (IS_V_ALIAS_PSEUDOREG): Define.
5596         (rs6000_register_name): Return names for the "vX" aliases.
5597         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5598         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5599         aliases.  Call default_register_reggroup_p for all other
5600         pseudo-registers.
5601         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5602         New functions.
5603         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5604         Handle "vX" aliases.
5605         (v_alias_pseudo_register_collect): New function.
5606         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5607         (rs6000_gdbarch_init): Initialize "vX" aliases as
5608         pseudo-registers.  Restore registration of
5609         rs6000_pseudo_register_reggroup_p with
5610         set_tdesc_pseudo_register_reggroup_p.
5611
5612 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5613
5614         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5615         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5616         set_gdbarch_num_pseudo_regs.
5617
5618 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5619
5620         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5621         Remove arg prefixname, add do_set and do_show.
5622         Add member functions set_list and show_list.
5623         * cli/cli-style.c (class cli_style_option): Update accordingly.
5624         (style_set_list): Move to file scope.
5625         (style_show_list): Likewise.
5626         (set_style): Call help_list.
5627         (show_style): Call cmd_show_list.
5628         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5629         Update to use the new macro.
5630
5631 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5632
5633         * ada-lang.c (_initialize_ada_language): Expand the help text
5634         for the "catch exception" command.
5635
5636 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5637
5638         * symtab.c (matching_obj_sections): Initialize obj,
5639         declare it closer to its usage.
5640
5641 2019-01-10  Tom Tromey  <tom@tromey.com>
5642
5643         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5644         (basic_inf_threads_range): Remove.
5645         (inf_threads_range, inf_non_exited_threads_range)
5646         (safe_inf_threads_range): Use next_adapter.
5647
5648 2019-01-10  Keith Seitz  <keiths@redhat.com>
5649
5650         PR gdb/23712
5651         PR symtab/23010
5652         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5653         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5654
5655 2019-01-10  Keith Seitz  <keiths@redhat.com>
5656
5657         PR gdb/23712
5658         PR symtab/23010
5659         * dictionary.c (pending_to_vector): Remove.
5660         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5661         Remove _1 suffix, replacing functions of the same name.  Update
5662         all callers.
5663         (dict_create_hashed, dict_create_hashed_expandable)
5664         (dict_create_linear, dict_create_linear_expandable, dict_free)
5665         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5666         Make functions static.
5667
5668 2019-01-10  Keith Seitz  <keiths@redhat.com>
5669
5670         PR gdb/23712
5671         PR symtab/23010
5672         * dictionary.h (struct dictionary): Replace declaration with
5673         multidictionary.
5674         (dict_create_hashed, dict_create_hashed_expandable)
5675         (dict_create_linear, dict_create_linear_expandable)
5676         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5677         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5678         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5679         taking multidictionary argument.
5680         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5681         * block.h (struct block) <dict>: Change to multidictionary
5682         and rename `multidict'.
5683         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5684         symmisc.c: Update all dictionary references to multidictionary.
5685
5686 2019-01-10  Keith Seitz  <keiths@redhat.com>
5687
5688         PR gdb/23712
5689         PR symtab/23010
5690         * dictionary.c: Include unordered_map.
5691         (pending_to_vector): New function.
5692         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5693         Rewrite the non-"_1" functions to take vector instead
5694         of linked list.
5695         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5696         "new" _1 versions of the same name.
5697         (multidictionary): Define.
5698         (std::hash<enum language): New definition.
5699         (collate_pending_symbols_by_language, mdict_create_hashed)
5700         (mdict_create_hashed_expandable, mdict_create_linear)
5701         (mdict_create_linear_expandable, mdict_free)
5702         (find_language_dictionary, create_new_language_dictionary)
5703         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5704         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5705         (mdict_size, mdict_empty): New functions.
5706         * dictionary.h (mdict_iterator): Define.
5707
5708 2019-01-10  Pedro Alves  <palves@redhat.com>
5709
5710         * breakpoint.c (read_uploaded_action)
5711         (create_tracepoint_from_upload): Adjust to use
5712         gdb::unique_xmalloc_ptr.
5713         * ctf.c (ctf_write_uploaded_tp):
5714         (SET_ARRAY_FIELD): Use emplace_back.
5715         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5716         * tracefile-tfile.c (tfile_write_uploaded_tp):
5717         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5718         gdb::unique_xmalloc_ptr.
5719         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5720         at_string, cond_string, cmd_strings>: Replace char pointers
5721         with gdb::unique_xmalloc_ptr.
5722
5723 2019-01-10  Pedro Alves  <palves@redhat.com>
5724
5725         * solib-target.c (library_list_start_library): Don't xstrdup name.
5726
5727 2019-01-10  Pedro Alves  <palves@redhat.com>
5728
5729         * mdebugread.c (parse_partial_symbols): Use
5730         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5731
5732 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5733
5734         * linux-fork.c (scoped_switch_fork_info)
5735         <~scoped_switch_fork_info>: Fix incorrect variable name.
5736
5737 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5738
5739         * linux-fork.c (scoped_switch_fork_info)
5740         <scoped_switch_fork_info>: Make explicit.
5741         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5742
5743 2019-01-10  Tom Tromey  <tom@tromey.com>
5744
5745         * objfiles.h (objfile::reset_psymtabs): Update.
5746         * objfiles.c (objfile::objfile): Update.
5747         * psymtab.h (psymtab_storage::obstack): Update.
5748         (psymtab_storage::m_obstack): Use gdb::optional.
5749         (class psymtab_storage): Update comment.  Remove objfile
5750         parameter.
5751         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5752
5753 2019-01-10  Tom Tromey  <tom@tromey.com>
5754
5755         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5756         <free_psymtabs>: Now private.
5757         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5758         (allocate_psymtab): Use new method.
5759
5760 2019-01-10  Tom Tromey  <tom@tromey.com>
5761
5762         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5763         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5764         * mdebugread.c (parse_partial_symbols): Use
5765         allocate_dependencies.
5766         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5767         allocate_dependencies.
5768         (process_psymtab_comp_unit_reader)
5769         (build_type_psymtab_dependencies): Likewise.
5770         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5771
5772 2019-01-10  Tom Tromey  <tom@tromey.com>
5773
5774         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5775         PSYMBOL_SET_LANGUAGE.
5776         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5777
5778 2019-01-10  Tom Tromey  <tom@tromey.com>
5779
5780         * psymtab.h (psymtab_storage::obstack): New method.
5781         <m_obstack>: Rename from obstack; now private.
5782         * psymtab.c (psymtab_storage): Update.
5783         * dwarf2read.c (create_addrmap_from_index)
5784         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5785         Update.
5786
5787 2019-01-10  Tom Tromey  <tom@tromey.com>
5788
5789         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5790         * objfiles.h (objfile::reset_psymtabs): New method.
5791
5792 2019-01-10  Tom Tromey  <tom@tromey.com>
5793
5794         * symmisc.c (print_symbol_bcache_statistics): Update.
5795         (print_objfile_statistics): Update.
5796         * symfile.c (reread_symbols): Update.
5797         * psymtab.h (class psymtab_storage): New.
5798         * psymtab.c (psymtab_storage): New constructor.
5799         (~psymtab_storage): New destructor.
5800         (require_partial_symbols): Update.
5801         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5802         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5803         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5804         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5805         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5806         (start_psymtab_common, end_psymtab_common)
5807         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5808         (allocate_psymtab): Update.
5809         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5810         Update.
5811         (dump_psymtab_addrmap, maintenance_print_psymbols)
5812         (maintenance_check_psymtabs): Update.
5813         (class objfile_psymtabs): Move to objfiles.h.
5814         * psympriv.h (discard_psymtab): Now inline.
5815         (psymtab_discarder::psymtab_discarder): Update.
5816         (psymtab_discarder::~psymtab_discarder): Update.
5817         (ALL_OBJFILE_PSYMTABS): Rewrite.
5818         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5819         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5820         Remove fields.
5821         <partial_symtabs>: New field.
5822         (class objfile_psymtabs): Move from psymtab.h.  Update.
5823         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5824         psymbol_cache.
5825         (objfile::~objfile): Don't destroy psymbol_cache.
5826         * mdebugread.c (parse_partial_symbols): Update.
5827         * dwarf2read.c (create_addrmap_from_index)
5828         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5829         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5830         (add_partial_subprogram, dwarf2_ranges_read): Update.
5831         * dwarf-index-write.c (write_address_map)
5832         (write_one_signatured_type, recursively_write_psymbols)
5833         (class debug_names, class debug_names, write_psymtabs_to_index):
5834         Update.
5835
5836 2019-01-10  Tom Tromey  <tom@tromey.com>
5837
5838         * symtab.h (SYMBOL_SET_NAMES): Update.
5839         (symbol_set_names): Update.
5840         (MSYMBOL_SET_NAMES): Update.
5841         * symtab.c (symbol_set_names): Change argument to be an
5842         objfile_per_bfd_storage.
5843         * psymtab.c (add_psymbol_to_bcache): Update.
5844         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5845
5846 2019-01-10  Tom Tromey  <tom@tromey.com>
5847
5848         * symtab.c (create_demangled_names_hash): Change argument to be an
5849         objfile_per_bfd_storage.
5850         (symbol_set_names): Update.
5851
5852 2019-01-10  Tom Tromey  <tom@tromey.com>
5853
5854         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5855         init_psymbol_list.
5856         * psymtab.c (init_psymbol_list): Do nothing if already called.
5857         * psympriv.h (init_psymbol_list): Add comment.
5858         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5859         init_psymbol_list.
5860         * dbxread.c (dbx_symfile_read): Unconditionally call
5861         init_psymbol_list.
5862
5863 2019-01-10  Tom Tromey  <tom@tromey.com>
5864
5865         * xcoffread.c (scan_xcoff_symtab): Update.
5866         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5867         "where".
5868         * mdebugread.c (parse_partial_symbols)
5869         (handle_psymbol_enumerators): Update.
5870         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5871         * dbxread.c (read_dbx_symtab): Update.
5872         * psympriv.h (psymbol_placement): New enum.
5873         (add_psymbol_to_list): Update.
5874
5875 2019-01-10  Tom Tromey  <tom@tromey.com>
5876
5877         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5878         static_psymbols parameters.
5879         (scan_xcoff_symtab): Update.
5880         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5881         static_psymbols parameters.
5882         * psympriv.h (start_psymtab_common): Update.
5883         * mdebugread.c (parse_partial_symbols): Update.
5884         * dwarf2read.c (create_partial_symtab): Update.
5885         * dbxread.c (read_dbx_symtab): Update.
5886         (start_psymtab): Remove global_psymbols and static_psymbols
5887         parameters.
5888
5889 2019-01-10  Tom Tromey  <tom@tromey.com>
5890
5891         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5892         * psymtab.c (allocate_psymtab): Add comment.
5893         * psympriv.h (allocate_psymtab): Add comment.
5894         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5895         initializations.
5896         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5897
5898 2019-01-10  Tom Tromey  <tom@tromey.com>
5899
5900         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5901         Don't declare.
5902         * mipsread.c: Include mdebugread.h.
5903         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5904         Declare.
5905         * elfread.c: Include mdebugread.h.
5906
5907 2019-01-09  Tom Tromey  <tom@tromey.com>
5908
5909         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5910         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5911         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5912         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5913         (psym_lookup_symbol, psym_find_last_source_symtab)
5914         (psym_forget_cached_source_info, psym_print_stats)
5915         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5916         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5917         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5918         (psym_find_compunit_symtab_by_address)
5919         (maintenance_print_psymbols, maintenance_info_psymtabs)
5920         (maintenance_check_psymtabs): Use ranged for.
5921         * psymtab.h (class objfile_psymtabs): New.
5922         (require_partial_symbols): Return objfile_psymtabs.
5923         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5924
5925 2019-01-09  Tom Tromey  <tom@tromey.com>
5926
5927         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5928         (find_pc_mapped_section, list_overlays_command)
5929         (map_overlay_command, unmap_overlay_command)
5930         (simple_overlay_update): Use all_objfiles.
5931         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5932         * printcmd.c (info_symbol_command): Use all_objfiles.
5933         * objfiles.h (ALL_OBJSECTIONS): Remove.
5934         * maint.c (maintenance_translate_address): Use all_objfiles.
5935         * gcore.c (gcore_create_callback): Use all_objfiles.
5936         (objfile_find_memory_regions): Likewise.
5937
5938 2019-01-09  Tom Tromey  <tom@tromey.com>
5939
5940         * symtab.c (find_line_symtab, info_sources_command)
5941         (make_source_files_completion_list): Use objfile_compunits.
5942         * source.c (select_source_symtab): Use objfile_compunits.
5943         * objfiles.h (struct objfile): Update comment.
5944         (ALL_OBJFILES): Remove.
5945         (ALL_FILETABS): Remove.
5946         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5947         objfile_compunits.
5948
5949 2019-01-09  Tom Tromey  <tom@tromey.com>
5950
5951         * symmisc.c (print_objfile_statistics, dump_objfile)
5952         (maintenance_print_symbols): Use compunit_filetabs.
5953         * source.c (forget_cached_source_info_for_objfile): Use
5954         compunit_filetabs.
5955         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5956         (ALL_FILETABS): Use compunit_filetabs.
5957         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5958         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5959
5960 2019-01-09  Tom Tromey  <tom@tromey.com>
5961
5962         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5963         (compunit_filetabs): New.
5964         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5965         compunit_filetabs.
5966         (info_sources_command, make_source_files_completion_list): Remove
5967         declaration.
5968         * symmisc.c (print_objfile_statistics, dump_objfile)
5969         (maintenance_print_symbols): Remove declaration.
5970         (maintenance_info_symtabs): Use compunit_filetabs.
5971         (maintenance_info_line_tables): Likewise.
5972         * source.c (select_source_symtab): Change local variable name.
5973         (forget_cached_source_info_for_objfile): Remove declaration.
5974         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5975         * objfiles.c (objfile_relocate1): Remove declaration.
5976         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5977         declaration.
5978         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5979         * coffread.c (coff_symtab_read): Remove declaration.
5980         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5981         compunit_filetabs.
5982
5983 2019-01-09  Tom Tromey  <tom@tromey.com>
5984
5985         * symtab.c (lookup_objfile_from_block)
5986         (find_pc_sect_compunit_symtab, search_symbols)
5987         (default_collect_symbol_completion_matches_break_on): Use
5988         objfile_compunits.
5989         * objfiles.h (ALL_COMPUNITS): Remove.
5990         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5991         * cp-support.c (add_symbol_overload_list_qualified): Use
5992         objfile_compunits.
5993         * ada-lang.c (ada_collect_symbol_completion_matches)
5994         (ada_add_global_exceptions): Use objfile_compunits.
5995
5996 2019-01-09  Tom Tromey  <tom@tromey.com>
5997
5998         * source.c (select_source_symtab)
5999         (forget_cached_source_info_for_objfile): Remove declaration.
6000         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6001         declaration.
6002         * maint.c (count_symtabs_and_blocks): Remove declaration.
6003         * cp-support.c (add_symbol_overload_list_qualified): Remove
6004         declaration.
6005         * coffread.c (coff_symtab_read): Remove declaration.
6006         * symtab.c (lookup_symbol_in_objfile_symtabs)
6007         (basic_lookup_transparent_type_1): Use objfile_compunits.
6008         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6009         (info_sources_command, search_symbols)
6010         (default_collect_symbol_completion_matches_break_on)
6011         (make_source_files_completion_list): Remove declaration.
6012         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6013         (ada_collect_symbol_completion_matches)
6014         (ada_add_global_exceptions): Remove declaration.
6015         * linespec.c (iterate_over_all_matching_symtabs): Use
6016         objfile_compunits.
6017         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6018         (class objfile_compunits): New.
6019         (ALL_COMPUNITS): Use objfile_compunits.
6020         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6021         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6022         objfile_compunits.
6023         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6024
6025 2019-01-09  Tom Tromey  <tom@tromey.com>
6026
6027         * symtab.c (search_symbols)
6028         (default_collect_symbol_completion_matches_break_on): Use
6029         objfile_msymbols.
6030         * ada-lang.c (ada_lookup_simple_minsym)
6031         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6032         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6033         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6034         objfile_msymbols.
6035         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6036         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6037         * objc-lang.c (find_methods): Use objfile_msymbols.
6038         (info_selectors_command, info_classes_command): Likewise.
6039         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6040         * objfiles.h (class objfile_msymbols): New.
6041         (ALL_OBJFILE_MSYMBOLS): Remove.
6042         (ALL_MSYMBOLS): Remove.
6043
6044 2019-01-09  Tom Tromey  <tom@tromey.com>
6045
6046         * common/next-iterator.h (next_adapter): Add Iterator template
6047         parameter.
6048         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6049         (class all_objfiles_safe): New.
6050         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6051         * objfiles.c (put_objfile_before): Update comment.
6052         (add_separate_debug_objfile): Likewise.
6053         (free_all_objfiles): Use all_objfiles_safe.
6054         (objfile_purge_solibs): Likewise.
6055
6056 2019-01-09  Tom Tromey  <tom@tromey.com>
6057
6058         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6059         (expand_symtab_containing_pc, lookup_static_symbol)
6060         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6061         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6062         all_objfiles.
6063         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6064         * breakpoint.c (create_overlay_event_breakpoint)
6065         (create_longjmp_master_breakpoint)
6066         (create_std_terminate_master_breakpoint)
6067         (create_exception_master_breakpoint): Use all_objfiles.
6068         * linux-thread-db.c (try_thread_db_load_from_pdir)
6069         (has_libpthread): Use all_objfiles.
6070         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6071         * linespec.c (iterate_over_all_matching_symtabs)
6072         (search_minsyms_for_name): Use all_objfiles.
6073         * maint.c (maintenance_info_sections): Use all_objfiles.
6074         * main.c (captured_main_1): Use all_objfiles.
6075         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6076         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6077         * guile/scm-pretty-print.c
6078         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6079         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6080         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6081         (maintenance_print_msymbols): Use all_objfiles.
6082         * source.c (select_source_symtab): Use all_objfiles.
6083         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6084         * symfile.c (remove_symbol_file_command)
6085         (expand_symtabs_matching, map_symbol_filenames): Use
6086         all_objfiles.
6087         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6088         all_objfiles.
6089         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6090         * objc-lang.c (find_methods): Use all_objfiles.
6091         * objfiles.c (have_partial_symbols, have_full_symbols)
6092         (have_minimal_symbols, qsort_cmp)
6093         (default_iterate_over_objfiles_in_search_order): Use
6094         all_objfiles.
6095         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6096         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6097         (maintenance_check_psymtabs): Use all_objfiles.
6098         (ALL_PSYMTABS): Remove.
6099         * compile/compile-object-run.c (do_module_cleanup): Use
6100         all_objfiles.
6101         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6102         * cp-support.c (add_symbol_overload_list_qualified): Use
6103         all_objfiles.
6104         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6105         Use all_objfiles.
6106         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6107         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6108         all_objfiles.
6109         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6110         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6111         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6112         Uses all_objfiles.
6113         * solib.c (solib_read_symbols): Use all_objfiles
6114
6115 2019-01-09  Tom Tromey  <tom@tromey.com>
6116
6117         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6118         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6119         all_objfiles.
6120         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6121         * symmisc.c (print_symbol_bcache_statistics)
6122         (print_objfile_statistics, maintenance_print_objfiles)
6123         (maintenance_info_symtabs, maintenance_check_symtabs)
6124         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6125         all_objfiles.
6126         * source.c (forget_cached_source_info): Use all_objfiles.
6127         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6128         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6129         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6130         * objfiles.c (update_section_map): Use all_objfiles.
6131         (shared_objfile_contains_address_p): Likewise.
6132         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6133         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6134
6135 2019-01-09  Tom Tromey  <tom@tromey.com>
6136
6137         * common/next-iterator.h: New file.
6138         * objfiles.h (class all_objfiles): New.
6139         (struct objfile_iterator): New.
6140
6141 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6142
6143         * NEWS: Move the description of the changed "frame", "select-frame",
6144          and "info frame" commands to the Changed commands section.
6145
6146 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6147
6148         * gdbtypes.c (check_stub_method_group): Remove handling of old
6149         mangling schemes.
6150         * linespec.c (find_methods): Likewise.
6151         * stabsread.c (read_member_functions): Likewise.
6152         * valops.c (search_struct_method): Likewise.
6153         (value_struct_elt_for_reference): Likewise.
6154         * NEWS: Mention this change.
6155
6156 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6159         print_source_lines.
6160         * source.c (print_source_lines_base): Update line number check.
6161         (print_source_lines): New function.
6162         (source_lines_range::source_lines_range): New function.
6163         * source.h (class source_lines_range): New class.
6164         (print_source_lines): New declaration.
6165
6166 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6167
6168         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6169
6170 2019-01-08  Tom Tromey  <tom@tromey.com>
6171             Simon Marchi  <simon.marchi@ericsson.com>
6172
6173         PR gdb/24060
6174         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6175         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6176         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6177         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6178         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6179         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6180
6181 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6182
6183         * source.c (select_source_symtab): Move header comment to
6184         declaration in source.h.
6185         (forget_cached_source_info_for_objfile): Likewise.
6186         (forget_cached_source_info): Likewise.
6187         (identify_source_line): Likewise.
6188         * source.h (identify_source_line): Move declaration from symtab.h
6189         and add comment from source.c
6190         (print_source_lines): Likewise.
6191         (forget_cached_source_info_for_objfile): Likewise.
6192         (forget_cached_source_info): Likewise.
6193         (select_source_symtab): Likewise.
6194         (enum print_source_lines_flag): Move definition from symtab.h.
6195         * symtab.h (identify_source_line): Move declaration to source.h.
6196         (print_source_lines): Likewise.
6197         (forget_cached_source_info_for_objfile): Likewise.
6198         (forget_cached_source_info): Likewise.
6199         (select_source_symtab): Likewise.
6200         (enum print_source_lines_flag): Move definition to source.h.
6201         * tui/tui-hooks.c: Add 'source.h' include.
6202
6203 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6204
6205         * source.c (print_source_lines_base): Handle requests to print
6206         reverse line number sequences, and guard against empty lines
6207         string.
6208
6209 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6210
6211         * source.c (print_source_lines_base): Fix skip of '\r' if next
6212         character is '\n'.
6213
6214 2019-01-06  Tom Tromey  <tom@tromey.com>
6215
6216         * c-exp.y (struct c_parse_state) <macro_original_text,
6217         expansion_obstack>: New member.
6218         (macro_original_text, expansion_obstack): Remove globals.
6219         (scan_macro_expansion, scanning_macro_expansion)
6220         (finished_macro_expansion): Update.
6221         (scan_macro_cleanup): Remove.
6222         (yylex, c_parse): Update.
6223
6224 2019-01-06  Tom Tromey  <tom@tromey.com>
6225
6226         * c-exp.y (struct c_parse_state) <strings>: New member.
6227         (operator_stoken): Update.
6228
6229 2019-01-06  Tom Tromey  <tom@tromey.com>
6230
6231         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6232         (union type_stack_elt) <typelist_val>: Now a pointer to
6233         std::vector.
6234         (type_stack_cleanup): Don't declare.
6235         (push_typelist): Update.
6236         * parse.c (pop_typelist): Return a std::vector.
6237         (push_typelist): Take a std::vector.
6238         (follow_types): Update.  Do not free args.
6239         (type_stack_cleanup): Remove.
6240         * c-exp.y (struct c_parse_state): New.
6241         (cpstate): New global.
6242         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6243         (nonempty_typelist): Update.
6244         (func_mod): Create a new vector.
6245         (c_parse): Create a c_parse_state.
6246         (check_parameter_typelist): Do not delete params.
6247         (function_method): Update.  Do not delete type_list.
6248
6249 2019-01-06  Tom Tromey  <tom@tromey.com>
6250
6251         PR gdb/28155:
6252         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6253         check_typedef.
6254         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6255         (print_return_value): Likewise.
6256
6257 2019-01-05  Tom Tromey  <tom@tromey.com>
6258
6259         * contrib/cleanup_check.py: Remove.
6260         * contrib/gcc-with-excheck: Remove.
6261         * contrib/exsummary.py: Remove.
6262         * contrib/excheck.py: Remove.
6263
6264 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6265
6266         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6267         NULL. Initialize tpprev to NULL instead of assigning it
6268         to NULL on the next statement.
6269         * windows-nat.c (windows_delete_thread): Remove check for
6270         main_thread_id before printing thread exit notifications.
6271         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6272         Remove thread ID check against main_thread_id.
6273         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6274         windows_delete_thread.
6275         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6276
6277 2019-01-04  Tom Tromey  <tom@tromey.com>
6278
6279         * compile/compile.c (_initialize_compile): Use upper case for
6280         metasyntactic variables.
6281         * symmisc.c (_initialize_symmisc): Use upper case for
6282         metasyntactic variables.
6283         * psymtab.c (_initialize_psymtab): Use upper case for
6284         metasyntactic variables.
6285         * demangle.c (demangle_command): Use upper case for metasyntactic
6286         variables.
6287         (_initialize_demangler): Likewise.
6288         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6289         variables.
6290
6291 2019-01-03  Tom Tromey  <tom@tromey.com>
6292
6293         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6294
6295 2019-01-03  Tom Tromey  <tom@tromey.com>
6296
6297         * python/py-symtab.c (salpy_str): Update.
6298         (struct salpy_sal_object) <symtab>: Now a PyObject.
6299         (salpy_dealloc): Update.
6300         (del_objfile_sal): Use gdbpy_ref.
6301
6302 2019-01-03  Tom Tromey  <tom@tromey.com>
6303
6304         * python/py-type.c (convert_field): Use new_reference.  Return
6305         gdbpy_ref.
6306         (make_fielditem): Return gdbpy_ref.
6307         (typy_fields): Update.
6308         (typy_getitem): Update.
6309         (field_name): Return gdbpy_ref.  Use new_reference.
6310         (typy_iterator_iternext): Update.
6311
6312 2019-01-03  Tom Tromey  <tom@tromey.com>
6313
6314         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6315
6316 2019-01-03  Tom Tromey  <tom@tromey.com>
6317
6318         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6319         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6320         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6321         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6322         (pspy_set_type_printers): Likewise.
6323         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6324         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6325         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6326         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6327         (objfpy_set_type_printers): Likewise.
6328
6329 2019-01-03  Tom Tromey  <tom@tromey.com>
6330
6331         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6332         (gdbpy_print_stack): Use gdbpy_err_fetch.
6333         * python/python-internal.h (class gdbpy_err_fetch): New class.
6334         (class gdbpy_enter) <m_error_type, m_error_value,
6335         m_error_traceback>: Remove.
6336         <m_error>: New member.
6337         (gdbpy_exception_to_string): Don't declare.
6338         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6339         * python/py-value.c (convert_value_from_python): Use
6340         gdbpy_err_fetch.
6341         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6342         gdbpy_exception_to_string.
6343         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6344         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6345         gdbpy_err_fetch.
6346
6347 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6348
6349         * linux-nat.c (delete_lwp_cleanup): Delete.
6350         (struct lwp_deleter): New struct.
6351         (lwp_info_up): New typedef.
6352         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6353         lwp_info_up.
6354
6355 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6356
6357         * linux-fork.c (class scoped_switch_fork_info): New class.
6358         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6359
6360 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6361
6362         * valops.c (find_overload_match): Remove use of null_cleanup, and
6363         calls to do_cleanups.
6364
6365 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6366
6367         * compile/compile-cplus-types.c
6368         (compile_cplus_instance::decl_name): Handle changes to
6369         cp_func_name.
6370         * cp-support.c (cp_func_name): Update header comment, update
6371         return type.
6372         * cp-support.h (cp_func_name): Update return type in declaration.
6373         * valops.c (find_overload_match): Move temp_func local to top
6374         level of function and change its type.  Use temp_func to hold and
6375         delete temporary string obtained from cp_func_name.
6376
6377 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6378
6379         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6380         gdb::char_vector, remove cleanup, and update uses of `msg`.
6381
6382 2019-01-03  Jim Wilson  <jimw@sifive.com>
6383
6384         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6385
6386 2019-01-02  Tom Tromey  <tom@tromey.com>
6387
6388         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6389         (tdesc_parse_xml): Remove cleanups.
6390         * target-descriptions.h (make_cleanup_free_target_description):
6391         Don't declare.
6392         (target_desc_deleter): New struct.
6393         (target_desc_up): New typedef.
6394         * target-descriptions.c (target_desc_deleter::operator()): Rename
6395         from free_target_description.
6396         (make_cleanup_free_target_description): Remove.
6397
6398 2019-01-02  Tom Tromey  <tom@tromey.com>
6399
6400         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6401         constructor, destructor.
6402         (linespec_parser): Remove typedef.
6403         (~linespec_parser): Rename from linespec_parser_delete.
6404         (linespec_lex_to_end, linespec_complete_label)
6405         (linespec_complete): Update.
6406         (decode_line_full): Remove cleanups.
6407         (decode_line_1): Update.
6408
6409 2019-01-02  Tom Tromey  <tom@tromey.com>
6410
6411         * python/python-internal.h (inferior_to_inferior_object): Change
6412         return type.
6413         * python/py-exitedevent.c (create_exited_event_object): Update.
6414         * python/py-inferior.c (inferior_to_inferior_object): Return
6415         gdbpy_ref.
6416         (python_new_inferior, python_inferior_deleted)
6417         (thread_to_thread_object, delete_thread_object)
6418         (build_inferior_list, gdbpy_selected_inferior): Update.
6419         * python/py-infthread.c (create_thread_object): Update.  Also fail
6420         if inferior_to_inferior_object fails.
6421
6422 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6423
6424         * inferior.h (class inferior) <displaced_step_state>: New field.
6425         * infrun.h (struct displaced_step_state): Move here from
6426         infrun.c.  Initialize fields, add constructor.
6427         <inf>: Remove field.
6428         <reset>: New method.
6429         * infrun.c (struct displaced_step_inferior_state): Move to
6430         infrun.h.
6431         (displaced_step_inferior_states): Remove.
6432         (get_displaced_stepping_state): Adust.
6433         (displaced_step_in_progress_any_inferior): Adjust.
6434         (displaced_step_in_progress_thread): Adjust.
6435         (displaced_step_in_progress): Adjust.
6436         (add_displaced_stepping_state): Remove.
6437         (get_displaced_step_closure_by_addr): Adjust.
6438         (remove_displaced_stepping_state): Remove.
6439         (infrun_inferior_exit): Call displaced_step_state.reset.
6440         (use_displaced_stepping): Don't check for NULL.
6441         (displaced_step_prepare_throw): Call
6442         get_displaced_stepping_state.
6443         (displaced_step_fixup): Don't check for NULL.
6444         (prepare_for_detach): Don't check for NULL.
6445
6446 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6447
6448         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6449          in case of call that did not complete.
6450
6451 2019-01-02  Andrey Utkin  <autkin@undo.io>
6452
6453         * symfile.c (find_separate_debug_file): Fix search of debug files for
6454         remote debuggee.
6455
6456 2019-01-02  Tom Tromey  <tom@tromey.com>
6457
6458         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6459         indentation.
6460         * python/py-frame.c (frapy_older): Remove cast.
6461         (frapy_newer): Likewise.
6462         * python/py-breakpoint.c (local_setattro): Remove cast.
6463         * python/py-arch.c (archpy_name): Remove local variable.
6464         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6465
6466 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6467
6468         * unittests/basic_string_view/element_access/char/empty.cc:
6469         Fix year range in copyright header.
6470
6471 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6472
6473         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6474         Delete.
6475         <operator==>: Update with for removed field.
6476         <hash>: Likewise.
6477         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6478         <isa_features>: ...this.
6479         <abi_features>: New field.
6480         (riscv_isa_flen): Update comment.
6481         (riscv_abi_xlen): New declaration.
6482         (riscv_abi_flen): New declaration.
6483         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6484         isa_features.
6485         (riscv_abi_xlen): New function.
6486         (riscv_isa_flen): Update to get answer from isa_features.
6487         (riscv_abi_flen): New function.
6488         (riscv_has_fp_abi): Update to get answer from abi_features.
6489         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6490         xlen and flen.
6491         (riscv_call_info) <xlen, flen>: Update comment.
6492         (riscv_call_arg_struct): Remove invalid assertions
6493         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6494         is removed.
6495         (riscv_gdbarch_init): Gather isa features and abi features
6496         separately, ensure both match on the gdbarch when reusing an old
6497         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6498         a target with 64-bit float hardware.
6499
6500 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6501
6502         * source.c (search_command_helper): Stop reverse search
6503         when line 1 has been searched.
6504
6505 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6506
6507         * record-full.c (record_full_base_target::close): Rewrite
6508         record_full_core_buf_list free logic.
6509
6510 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6511
6512         * break-catch-syscall.c (print_one_catch_syscall): xfree
6513         the last text.
6514
6515 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6516
6517         * top.c (print_gdb_version): Update Copyright year in version
6518         message.
6519
6520 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6521
6522         Update copyright year range in all GDB files.
6523
6524 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6525
6526         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6527
6528 For older changes see ChangeLog-2018.
6529 \f
6530 Local Variables:
6531 mode: change-log
6532 left-margin: 8
6533 fill-column: 74
6534 version-control: never
6535 coding: utf-8
6536 End:
6537