gdb/ChangeLog

   1 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * event-top.c: Remove include comment.
   4         * inflow.c (class scoped_ignore_sigttou): Move from here...
   5         * inflow.h (class scoped_ignore_sigttou): ...to here.
   6         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
   7         * top.c:  Remove include comment.
   8
   9 2019-08-04  Alan Hayward  <alan.hayward@arm.com>
  10
  11         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
  12
  13 2019-05-29  Tom Tromey  <tromey@adacore.com>
  14
  15         PR c++/20020:
  16         * cp-valprint.c (cp_print_value_fields): Call
  17         cp_print_static_field inside "try".
  18
  19 2019-06-10  Tom de Vries  <tdevries@suse.de>
  20
  21         PR symtab/24545
  22         * symtab.c (struct demangled_name_entry): Add language field.
  23         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
  24         static minimal symbol".  Set and use language field.
  25
  26 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
  27
  28         PR gdb/24592
  29         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
  30         function.
  31         (fill_gregset): Call amd64_linux_collect_native_gregset instead
  32         of amd64_collect_native_gregset.
  33         (amd64_linux_nat_target::store_registers): Likewise.
  34
  35 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  36
  37         * version.in: Set GDB version number to 8.3.0.DATE-git.
  38
  39 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  40
  41         GDB 8.3 released.
  42
  43 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  44
  45         * version.in: Set GDB version number to 8.3.
  46
  47 2019-05-08  Tom Tromey  <tromey@adacore.com>
  48
  49         * utils.c (fputs_maybe_filtered): Reset style after paging, even
  50         when no wrap column is set.
  51
  52 2019-05-04  Tom Tromey  <tom@tromey.com>
  53
  54         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  55         (lookup_partial_symbol, print_partial_symbols)
  56         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  57         (psymbol_compare): Update.
  58         (add_psymbol_to_bcache): Clear the entire psymbol.
  59         (maintenance_check_psymtabs): Update.
  60         * psympriv.h (struct partial_symbol): Don't derive from
  61         general_symbol_info.
  62         <obj_section, unrelocated_address, address,
  63         set_unrelocated_address>: Update.
  64         <ginfo>: New member.
  65         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  66         (debug_names::write_psymbols): Update.
  67
  68 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  69
  70         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
  71         level, so that various Windows header files expose the necessary
  72         declarations and definitions.
  73
  74         * symfile.c (find_separate_debug_file): Remove colon from the
  75         drive spec of DOS/Windows file names of the target, so that the
  76         file name produced from DEBUGDIR and the target's directory will
  77         be valid on DOS/Windows systems.
  78
  79 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  80
  81         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  82         Use current_event.dwThreadId instead of main_thread_id.
  83
  84 2019-04-30  Tom Tromey  <tromey@adacore.com>
  85
  86         PR c++/24470:
  87         * dwarf2read.c (process_structure_scope): Handle case where type
  88         has template parameters but no symbol was created.
  89
  90 2019-04-19  Sergei Trofimovich <siarheit@google.com>
  91
  92         * configure.ac: add --enable-source-highlight switch.
  93         * configure: Regenerate.
  94         * top.c (print_gdb_version): plumb --enable-source-highlight
  95         status to "show configuration".
  96
  97 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
  98
  99         PR symtab/24423:
 100         * source.c (print_source_lines_base): Advance "iter" when a
 101         control character is seen.
 102
 103 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 104
 105         * inferior.h (struct infcall_suspend_state_deleter):
 106         Catch exception in destructor to avoid crash.
 107
 108 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 109
 110         * utils.c (prompt_for_continue): Don't restore the styling at the
 111         end, as applied_style has the wrong value.  This fixes styling in
 112         long lists of file names that are interrupted by the "Continue?"
 113         prompt.
 114
 115 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 116
 117         * version.in: Set GDB version number to 8.2.91.DATE-git.
 118
 119 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 120
 121         GDB 8.2.91 released.
 122
 123 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 124
 125         * version.in: Set GDB version number to 8.2.91.
 126
 127 2019-03-20  Tom Tromey  <tromey@adacore.com>
 128
 129         PR gdb/24391
 130         * infrun.c (handle_inferior_event): Rename from
 131         handle_inferior_event_1.  Create a scoped_value_mark.
 132         (handle_inferior_event): Remove.
 133
 134 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 135
 136         * source-cache.c (source_cache::get_source_lines): Re-read
 137         fullname after calling open_source_file.
 138
 139 2019-03-18  Pedro Alves  <palves@redhat.com>
 140             Eli Zaretskii <eliz@gnu.org>
 141
 142         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 143         m_line and m_start_of_line.
 144
 145 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 146
 147         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 148         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 149         it returns a newline.  This fixes a regression in TU mode, whereby
 150         the next line is output on the same screen line as the user input.
 151
 152 2019-03-18  Pedro Alves  <palves@redhat.com>
 153
 154         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 155         New globals.
 156         (apply_style): New, factored out from ...
 157         (apply_ansi_escape): ... this.  Handle reverse video mode.
 158         (tui_set_reverse_mode): New function.
 159         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 160         * tui/tui-winsource.c (tui_show_source_line): Use
 161         tui_set_reverse_mode instead of setting A_STANDOUT.
 162         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 163         New setter methods.
 164
 165 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 166
 167         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 168         Handle tabs.
 169
 170 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 171
 172         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 173         tui_refill_source_window instead of tui_refresh_win, to update the
 174         current execution line.  This fixes redisplay of the current line
 175         when stepping through the code with "next" or "step".
 176
 177 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 178
 179         * source-cache.c (source_cache::get_source_lines): Call
 180         find_source_lines to initialize s->nlines.  This fixes vertical
 181         scrolling of TUI source window when the DOWN arrow is pressed.
 182
 183 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 184
 185         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 186         wclrtoeol in tui_show_source_line".  This reverts changes made in
 187         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 188
 189 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 190
 191         * NEWS: Combine separate "New targets" sections for 8.3.
 192
 193 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 194
 195         The MS-Windows port of ncurses fails to switch to a color pair if
 196         one or both of the colors are the implicit default colors.  This
 197         change records the default colors when TUI is initialized, and
 198         then specifies them explicitly when a color pair uses the default
 199         colors.  This allows color styling in TUI mode on MS-Windows.
 200
 201         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 202         ncurses_norm_attr.
 203         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 204         colors in ncurses_norm_attr.
 205         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 206         "none", replace it with the default color recorded in
 207         ncurses_norm_attr.
 208
 209 2019-03-14  Tom Tromey  <tromey@adacore.com>
 210
 211         * source-cache.h (class source_cache) <get_source_lines>: Return
 212         std::string.
 213         * source-cache.c (source_cache::extract_lines): Handle case where
 214         first_pos==npos.  Return std::string.
 215         (source_cache::get_source_lines): Update.
 216
 217 2019-03-14  Tom Tromey  <tromey@adacore.com>
 218
 219         * NEWS: Add item for "style sources" commands.
 220         * source-cache.c (source_cache::get_source_lines): Check
 221         source_styling.
 222         * cli/cli-style.c (source_styling): New global.
 223         (_initialize_cli_style): Add "style sources" commands.
 224         (show_style_sources): New function.
 225         * cli/cli-style.h (source_styling): Declare.
 226
 227 2019-03-14  Pedro Alves  <palves@redhat.com>
 228             Tom Tromey  <tromey@adacore.com>
 229
 230         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 231         * tui/tui-winsource.c (tui_refill_source_window): New function,
 232         from...
 233         (tui_horizontal_source_scroll): ... here.  Move some logic.
 234         * cli/cli-style.c (set_style_enabled): Notify new observable.
 235         * tui/tui-hooks.c (tui_redisplay_source): New function.
 236         (tui_attach_detach_observers): Attach or detach
 237         tui_redisplay_source.
 238         * observable.h (source_styling_changed): New observable.
 239         * observable.c: Define source_styling_changed observable.
 240
 241 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 242
 243         PR/24325
 244         * source-cache.c: #undef open and close, to avoid unresolved
 245         externals during linking.
 246
 247 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 248
 249         Support styling on native MS-Windows console
 250
 251         PR/24315
 252         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 253         on MS-Windows if $TERM is not defined.
 254
 255         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 256
 257         * posix-hdep.c (gdb_console_fputs):
 258         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 259         functions.
 260         * ui-file.h (gdb_console_fputs): Add prototype.
 261
 262         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 263         back to fputs only if the former returns zero.
 264
 265 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 266             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 267
 268         PR gdb/8527
 269         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 270         set_sigint_trap, clear_sigint_trap.
 271
 272 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 273
 274         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 275         for-loop range, to avoid compiler warnings.
 276
 277         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 278         avoid compiler warnings about unused variables.
 279
 280 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 281
 282         * NEWS: Mention end of support for native debugging on MS-Windows
 283         before XP.
 284
 285 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 286
 287         PR gdb/24292
 288         * common/netstuff.c:
 289         * gdbserver/gdbreplay.c
 290         * gdbserver/remote-utils.c:
 291         * ser-tcp.c:
 292         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 293         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 294         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 295         'getaddrinfo' and 'freeaddrinfo' were not available before
 296         Windows XP, and mingw.org's MinGW headers by default define
 297         _WIN32_WINNT to 0x500.
 298
 299 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 300
 301         * NEWS: Note minimum Python version.
 302
 303 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 304
 305         * version.in: Set GDB version number to 8.2.90.DATE-git.
 306
 307 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 308
 309         GDB 8.2.90 released.
 310
 311 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 312
 313         * version.in: Set GDB version number to 8.2.90.
 314
 315 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 316
 317         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 318
 319 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 320
 321         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 322         * version.in: Bump version to 8.2.90.DATE-git.
 323
 324 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 325
 326         * aix-thread.c (ptid_cmp): Remove unused variable.
 327         (get_signaled_thread): Likewise.
 328         (store_regs_user_thread): Likewise.
 329         (store_regs_kernel_thread): Likewise.
 330         (fetch_regs_kernel_thread): Remove shadowed variable.
 331
 332 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 333
 334         * features/riscv/32bit-cpu.xml: Add register numbers.
 335         * features/riscv/32bit-fpu.c: Regenerate.
 336         * features/riscv/32bit-fpu.xml: Add register numbers.
 337         * features/riscv/64bit-cpu.xml: Add register numbers.
 338         * features/riscv/64bit-fpu.c: Regenerate.
 339         * features/riscv/64bit-fpu.xml: Add register numbers.
 340
 341 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 342
 343         * NEWS: Mention two argument form of gdb.Value constructor.
 344         * python/py-value.c (convert_buffer_and_type_to_value): New
 345         function.
 346         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 347         Add support for handling an optional second argument.  Call
 348         convert_buffer_and_type_to_value as appropriate.
 349         * python/python-internal.h (Py_buffer_deleter): New struct.
 350         (Py_buffer_up): New typedef.
 351
 352 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 353
 354         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 355         instead of releasing ownership.
 356
 357 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 358
 359         * dwarf2read.c (open_and_init_dwp_file): Call
 360         elf_numsections instead of bfd_count_sections to initialize
 361         dwp_file->num_sections.
 362
 363 2019-02-25  Tom Tromey  <tromey@adacore.com>
 364
 365         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 366
 367 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 368
 369         * gcore.in: Add '--readnever' option when invoking GDB.
 370
 371 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 372
 373         * MAINTAINERS: Update my email address.
 374
 375 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 376
 377         * build-id.c (build_id_to_debug_bfd_1): New function.
 378         (build_id_to_debug_bfd): Look for separate debug file in
 379         sysroot.
 380
 381 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 382
 383         * gdbarch.sh: Update the copyright year range that is placed into
 384         generated files.
 385
 386 2019-02-22  Keith Seitz  <keiths@redhat.com>
 387
 388         PR symtab/23853
 389         * linespec.c (create_sals_line_offset): Search for the default
 390         symtab's filename instead of its fullname.
 391
 392 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 393
 394         * NEWS: Update style defaults.
 395
 396 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 397
 398         * main.c (captured_main_1): Disable styling in batch mode.
 399
 400 2019-02-20  Tom Tromey  <tom@tromey.com>
 401
 402         * symtab.c (symtab_symbol_info): Fix typos.
 403
 404 2019-02-20  Tom Tromey  <tromey@adacore.com>
 405
 406         * findcmd.c (_initialize_mem_search): Use upper case for
 407         metasyntactic variables.
 408
 409 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 410
 411         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 412         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 413
 414 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 415
 416         * top.h (source_file_name): Change to std::string.
 417         * top.c (source_file_name): Likewise.
 418         (command_line_input): Adjust.
 419         * cli/cli-script.c (script_from_file): Adjust.
 420
 421 2019-02-19  Tom Tromey  <tromey@adacore.com>
 422
 423         * ravenscar-thread.c
 424         (ravenscar_thread_target::update_thread_list): Don't call
 425         ada_build_task_list.
 426         * ada-lang.h (ada_build_task_list): Don't declare.
 427         * ada-tasks.c (struct ada_tasks_inferior_data)
 428         <task_list_valid_p>: Now bool.
 429         (read_known_tasks, ada_task_list_changed)
 430         (ada_tasks_invalidate_inferior_data): Update.
 431         (read_known_tasks_array): Return bool.
 432         (read_known_tasks_list): Likewise.
 433         (read_known_tasks): Return void.
 434         (ada_build_task_list): Now static.
 435
 436 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 437
 438         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 439         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 440
 441 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 442
 443         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 444         variant for ada_tasks_pspace_data_handle and
 445         ada_tasks_inferior_data_handle.
 446         (ada_tasks_pspace_data_cleanup): New function.
 447         (ada_tasks_inferior_data_cleanup): New function.
 448
 449 2019-02-17  Tom Tromey  <tom@tromey.com>
 450
 451         * macrotab.h (macro_source_fullname): Return a std::string.
 452         * macrotab.c (macro_include, check_for_redefinition)
 453         (macro_undef, macro_lookup_definition, foreach_macro)
 454         (foreach_macro_in_scope): Update.
 455         (macro_source_fullname): Return a std::string.
 456         * macrocmd.c (show_pp_source_pos): Update.
 457
 458 2019-02-17  Tom Tromey  <tom@tromey.com>
 459
 460         * macrocmd.c (show_pp_source_pos): Style the file names.
 461
 462 2019-02-17  Tom Tromey  <tom@tromey.com>
 463
 464         PR tui/24197:
 465         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 466
 467 2019-02-17  Tom Tromey  <tom@tromey.com>
 468
 469         * ada-lang.c (user_select_syms): Use filtered printing.
 470         * utils.c (wrap_style): New global.
 471         (desired_style): Remove.
 472         (emit_style_escape): Add stream parameter.
 473         (set_output_style, reset_terminal_style, prompt_for_continue):
 474         Update.
 475         (flush_wrap_buffer): Only flush gdb_stdout.
 476         (wrap_here): Set wrap_style.
 477         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 478         treat escape sequences as a character.  Change when wrap buffer is
 479         flushed.
 480         (fputs_styled): Do not set the output style when the default is
 481         requested.
 482         * ui-style.h (struct ui_file_style) <is_default>: New method.
 483         * source.c (print_source_lines_base): Emit escape sequences in one
 484         piece.
 485
 486 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 487
 488         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 489         integers and enumeration types.
 490
 491 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 492
 493         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 494         instead of lookup_symbol_in_language
 495         (do_exact_match): New function.
 496         (ada_get_symbol_name_matcher): Return do_exact_match when
 497         doing a verbatim match.
 498
 499 2019-02-15  Tom Tromey  <tromey@adacore.com>
 500
 501         * ravenscar-thread.c (ravenscar_thread_target::resume)
 502         (ravenscar_thread_target::wait): Special case wildcard requests.
 503
 504 2019-02-15  Tom Tromey  <tromey@adacore.com>
 505
 506         * ravenscar-thread.c (base_ptid): Remove.
 507         (struct ravenscar_thread_target) <close>: New method.
 508         <m_base_ptid>: New member.
 509         <update_inferior_ptid, active_task, task_is_currently_active,
 510         runtime_initialized>: Declare methods.
 511         <ravenscar_thread_target>: Add constructor.
 512         (ravenscar_thread_target::task_is_currently_active)
 513         (ravenscar_thread_target::update_inferior_ptid)
 514         (ravenscar_runtime_initialized): Rename.  Now methods.
 515         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 516         (ravenscar_thread_target::update_thread_list): Update.
 517         (ravenscar_thread_target::active_task): Now method.
 518         (ravenscar_thread_target::store_registers)
 519         (ravenscar_thread_target::prepare_to_store)
 520         (ravenscar_thread_target::prepare_to_store)
 521         (ravenscar_thread_target::mourn_inferior): Update.
 522         (ravenscar_inferior_created): Use "new" to create target.
 523         (ravenscar_thread_target::get_ada_task_ptid): Update.
 524         (_initialize_ravenscar): Don't initialize base_ptid.
 525         (ravenscar_ops): Remove global.
 526
 527 2019-02-15  Tom Tromey  <tromey@adacore.com>
 528
 529         * target.h (push_target): Declare new overload.
 530         * target.c (push_target): New overload, taking an rvalue reference.
 531         * remote.c (remote_target::open_1): Use push_target overload.
 532         * corelow.c (core_target_open): Use push_target overload.
 533
 534 2019-02-15  Tom Tromey  <tromey@adacore.com>
 535
 536         * ravenscar-thread.c (is_ravenscar_task)
 537         (ravenscar_task_is_currently_active): Return bool.
 538         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 539         (_initialize_ravenscar): Remove "(void)".
 540         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 541         Return bool.
 542
 543 2019-02-15  Tom Tromey  <tromey@adacore.com>
 544
 545         * ravenscar-thread.c (ravenscar_runtime_initializer)
 546         (has_ravenscar_runtime, get_running_thread_id)
 547         (ravenscar_thread_target::resume): Fix indentation.
 548
 549 2019-02-15  Tom Tromey  <tromey@adacore.com>
 550
 551         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 552         from ravenscar_arch_ops.
 553         (sparc_ravenscar_ops::fetch_registers)
 554         (sparc_ravenscar_ops::store_registers): Now methods.
 555         (sparc_ravenscar_prepare_to_store): Remove.
 556         (sparc_ravenscar_ops): Redefine.
 557         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 558         methods and destructor.  Remove members.
 559         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 560         (ravenscar_thread_target::store_registers)
 561         (ravenscar_thread_target::prepare_to_store): Update.
 562         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 563         Remove.
 564         (struct ppc_ravenscar_powerpc_ops): Derive from
 565         ravenscar_arch_ops.
 566         (ppc_ravenscar_powerpc_ops::fetch_registers)
 567         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 568         (ppc_ravenscar_powerpc_ops): Redefine.
 569         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 570         (ppc_ravenscar_e500_ops::fetch_registers)
 571         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 572         (ppc_ravenscar_e500_ops): Redefine.
 573         * aarch64-ravenscar-thread.c
 574         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 575         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 576         (aarch64_ravenscar_fetch_registers)
 577         (aarch64_ravenscar_store_registers): Now methods.
 578         (aarch64_ravenscar_ops): Redefine.
 579
 580 2019-02-15  Tom Tromey  <tromey@adacore.com>
 581
 582         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 583         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 584         (ravenscar_thread_target::stopped_by_watchpoint)
 585         (ravenscar_thread_target::stopped_data_address)
 586         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 587
 588 2019-02-15  Tom Tromey  <tromey@adacore.com>
 589
 590         * ravenscar-thread.c: Fix some typos.
 591
 592 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 593             Tom Tromey  <tromey@adacore.com>
 594
 595         * ada-lang.c (ada_exception_sal): Change addr_string to a
 596         std::string.
 597         (create_ada_exception_catchpoint): Update.
 598
 599 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 600             Tom Tromey  <tromey@adacore.com>
 601
 602         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 603         (bp_location_ops): Remove.
 604         (base_breakpoint_allocate_location): Update.
 605         (free_bp_location): Update.
 606         * ada-lang.c (class ada_catchpoint_location)
 607         <ada_catchpoint_location>: Remove ops parameter.
 608         (ada_catchpoint_location_dtor): Remove.
 609         (ada_catchpoint_location_ops): Remove.
 610         (allocate_location_exception): Update.
 611         * breakpoint.h (struct bp_location_ops): Remove.
 612         (class bp_location) <bp_location>: Remove bp_location_ops
 613         parameter.
 614         <~bp_location>: Add destructor.
 615         <ops>: Remove.
 616
 617 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 618             Pedro Alves  <palves@redhat.com>
 619
 620         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 621         'PATH_MAX'.
 622
 623 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 624             Samuel Thibault  <samuel.thibault@gnu.org>
 625             Thomas Schwinge  <thomas@codesourcery.com>
 626
 627         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 628         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 629
 630 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 631
 632         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 633         (check_empty): Use "const char *".
 634
 635         * gnu-nat.c (gnu_nat_target::detach): Instead of
 636         'detach_inferior (pid)' call
 637         'detach_inferior (find_inferior_pid (pid))'.
 638
 639         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 640         'nat/fork-inferior.o'.
 641         * gnu-nat.c: #include "nat/fork-inferior.h".
 642
 643         * gnu-nat.c (gnu_nat_target::detach): Instead of
 644         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 645         * gnu-nat.h: #include "inf-child.h".
 646         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 647         'i386_gnu_nat_target::fetch_registers'.
 648         (gnu_store_registers): Rename/move to
 649         'i386_gnu_nat_target::store_registers'.
 650
 651         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 652         * gnu-nat.h (mach_thread_info): New function.
 653         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 654
 655         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 656
 657 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 658
 659         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 660
 661 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 662
 663         * windows-nat.c (windows_add_thread): Add new parameter
 664         "main_thread_p" with default value set to false.  Update
 665         function documentation as well as all callers.
 666         (windows_delete_thread): Likewise.
 667         (fake_create_process): Update call to windows_add_thread.
 668         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 669         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 670         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 671         call to windows_delete_thread.
 672
 673 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 674
 675         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 676
 677 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 678
 679         * symfile.c (find_separate_debug_file): Use canonical path of
 680         sysroot with child_path instead of gdb_sysroot if it is valid.
 681
 682 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 683
 684         * symfile.c (find_separate_debug_file): Use child_path to
 685         determine if an object file is under a sysroot.
 686
 687 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 688
 689         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 690         unittests/child-path-selftests.c.
 691         * common/pathstuff.c (child_path): New function.
 692         * common/pathstuff.h (child_path): New prototype.
 693         * unittests/child-path-selftests.c: New file.
 694
 695 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 696
 697         * symfile.c (find_separate_debug_file): Look for separate debug
 698         files in debug directories under the sysroot.
 699
 700 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 701
 702         * symtab.h (struct minimal_symbol data_p): New const method.
 703         (struct minimal_symbol text_p): Likewise.
 704         * symtab.c (output_source_filename): Use file name style
 705         to print file name.
 706         (print_symbol_info): Likewise.
 707         (print_msymbol_info): Use address style to print addresses.
 708         Use function name style to print executable text symbols.
 709         (expand_symtab_containing_pc): Use data_p.
 710         (find_pc_sect_compunit_symtab): Likewise.
 711
 712 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 713
 714         * breakpoint.c (describe_other_breakpoints): Use address style
 715         to print addresses.
 716         (say_where): Likewise.
 717
 718 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 719
 720         * ada-typeprint.c (print_func_type): Print function name
 721         style to print function name.
 722         * c-typeprint.c (c_print_type_1): Likewise.
 723
 724 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 725
 726         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 727         for execve.
 728
 729 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 730
 731         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 732         type_stack.
 733
 734 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 735
 736         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 737         TYPE_CODE_REF types.
 738
 739 2019-02-08  Jim Wilson  <jimw@sifive.com>
 740
 741         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 742         (riscv_linux_fregset): New.
 743         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 744
 745 2019-02-07  Tom Tromey  <tom@tromey.com>
 746
 747         * thread.c (thread_cancel_execution_command): Update.
 748         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 749         methods.
 750         (struct thread_fsm_ops): Remove.
 751         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 752         (thread_fsm_should_stop, thread_fsm_return_value)
 753         (thread_fsm_set_finished, thread_fsm_finished_p)
 754         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 755         Don't declare.
 756         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 757         * infrun.c (clear_proceed_status_thread)
 758         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 759         (print_stop_event): Update.
 760         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 761         Add constructor.
 762         (step_command_fsm_ops): Remove.
 763         (new_step_command_fsm): Remove.
 764         (step_1): Update.
 765         (step_command_fsm::should_stop): Rename from
 766         step_command_fsm_should_stop.
 767         (step_command_fsm::clean_up): Rename from
 768         step_command_fsm_clean_up.
 769         (step_command_fsm::do_async_reply_reason): Rename from
 770         step_command_fsm_async_reply_reason.
 771         (struct until_next_fsm): Inherit from thread_fsm.  Add
 772         constructor.
 773         (until_next_fsm_ops): Remove.
 774         (new_until_next_fsm): Remove.
 775         (until_next_fsm::should_stop): Rename from
 776         until_next_fsm_should_stop.
 777         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 778         (until_next_fsm::do_async_reply_reason): Rename from
 779         until_next_fsm_async_reply_reason.
 780         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 781         constructor.  Change type of breakpoint.
 782         (finish_command_fsm_ops): Remove.
 783         (new_finish_command_fsm): Remove.
 784         (finish_command_fsm::should_stop): Rename from
 785         finish_command_fsm_should_stop.
 786         (finish_command_fsm::clean_up): Rename from
 787         finish_command_fsm_clean_up.
 788         (finish_command_fsm::return_value): Rename from
 789         finish_command_fsm_return_value.
 790         (finish_command_fsm::do_async_reply_reason): Rename from
 791         finish_command_fsm_async_reply_reason.
 792         (finish_command): Update.
 793         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 794         Add constructor.
 795         (call_thread_fsm_ops): Remove.
 796         (call_thread_fsm::call_thread_fsm): Rename from
 797         new_call_thread_fsm.
 798         (call_thread_fsm::should_stop): Rename from
 799         call_thread_fsm_should_stop.
 800         (call_thread_fsm::should_notify_stop): Rename from
 801         call_thread_fsm_should_notify_stop.
 802         (run_inferior_call, call_function_by_hand_dummy): Update.
 803         * cli/cli-interp.c (should_print_stop_to_console): Update.
 804         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 805         Add constructor.  Change type of location_breakpoint,
 806         caller_breakpoint.
 807         (until_break_fsm_ops): Remove.
 808         (new_until_break_fsm): Remove.
 809         (until_break_fsm::should_stop): Rename from
 810         until_break_fsm_should_stop.
 811         (until_break_fsm::clean_up): Rename from
 812         until_break_fsm_clean_up.
 813         (until_break_fsm::do_async_reply_reason): Rename from
 814         until_break_fsm_async_reply_reason.
 815         (until_break_command): Update.
 816         * thread-fsm.c: Remove.
 817         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 818
 819 2019-02-07  Tom Tromey  <tom@tromey.com>
 820
 821         * yy-remap.h: Add include guard.
 822         * xtensa-tdep.h: Add include guard.
 823         * xcoffread.h: Rename include guard.
 824         * varobj-iter.h: Add include guard.
 825         * tui/tui.h: Rename include guard.
 826         * tui/tui-winsource.h: Rename include guard.
 827         * tui/tui-wingeneral.h: Rename include guard.
 828         * tui/tui-windata.h: Rename include guard.
 829         * tui/tui-win.h: Rename include guard.
 830         * tui/tui-stack.h: Rename include guard.
 831         * tui/tui-source.h: Rename include guard.
 832         * tui/tui-regs.h: Rename include guard.
 833         * tui/tui-out.h: Rename include guard.
 834         * tui/tui-layout.h: Rename include guard.
 835         * tui/tui-io.h: Rename include guard.
 836         * tui/tui-hooks.h: Rename include guard.
 837         * tui/tui-file.h: Rename include guard.
 838         * tui/tui-disasm.h: Rename include guard.
 839         * tui/tui-data.h: Rename include guard.
 840         * tui/tui-command.h: Rename include guard.
 841         * tic6x-tdep.h: Add include guard.
 842         * target/waitstatus.h: Rename include guard.
 843         * target/wait.h: Rename include guard.
 844         * target/target.h: Rename include guard.
 845         * target/resume.h: Rename include guard.
 846         * target-float.h: Rename include guard.
 847         * stabsread.h: Add include guard.
 848         * rs6000-tdep.h: Add include guard.
 849         * riscv-fbsd-tdep.h: Add include guard.
 850         * regformats/regdef.h: Rename include guard.
 851         * record.h: Rename include guard.
 852         * python/python.h: Rename include guard.
 853         * python/python-internal.h: Rename include guard.
 854         * python/py-stopevent.h: Rename include guard.
 855         * python/py-ref.h: Rename include guard.
 856         * python/py-record.h: Rename include guard.
 857         * python/py-record-full.h: Rename include guard.
 858         * python/py-record-btrace.h: Rename include guard.
 859         * python/py-instruction.h: Rename include guard.
 860         * python/py-events.h: Rename include guard.
 861         * python/py-event.h: Rename include guard.
 862         * procfs.h: Add include guard.
 863         * proc-utils.h: Add include guard.
 864         * p-lang.h: Add include guard.
 865         * or1k-tdep.h: Rename include guard.
 866         * observable.h: Rename include guard.
 867         * nto-tdep.h: Rename include guard.
 868         * nat/x86-linux.h: Rename include guard.
 869         * nat/x86-linux-dregs.h: Rename include guard.
 870         * nat/x86-gcc-cpuid.h: Add include guard.
 871         * nat/x86-dregs.h: Rename include guard.
 872         * nat/x86-cpuid.h: Rename include guard.
 873         * nat/ppc-linux.h: Rename include guard.
 874         * nat/mips-linux-watch.h: Rename include guard.
 875         * nat/linux-waitpid.h: Rename include guard.
 876         * nat/linux-ptrace.h: Rename include guard.
 877         * nat/linux-procfs.h: Rename include guard.
 878         * nat/linux-osdata.h: Rename include guard.
 879         * nat/linux-nat.h: Rename include guard.
 880         * nat/linux-namespaces.h: Rename include guard.
 881         * nat/linux-btrace.h: Rename include guard.
 882         * nat/glibc_thread_db.h: Rename include guard.
 883         * nat/gdb_thread_db.h: Rename include guard.
 884         * nat/gdb_ptrace.h: Rename include guard.
 885         * nat/fork-inferior.h: Rename include guard.
 886         * nat/amd64-linux-siginfo.h: Rename include guard.
 887         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 888         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 889         * nat/aarch64-linux.h: Rename include guard.
 890         * nat/aarch64-linux-hw-point.h: Rename include guard.
 891         * mn10300-tdep.h: Add include guard.
 892         * mips-linux-tdep.h: Add include guard.
 893         * mi/mi-parse.h: Rename include guard.
 894         * mi/mi-out.h: Rename include guard.
 895         * mi/mi-main.h: Rename include guard.
 896         * mi/mi-interp.h: Rename include guard.
 897         * mi/mi-getopt.h: Rename include guard.
 898         * mi/mi-console.h: Rename include guard.
 899         * mi/mi-common.h: Rename include guard.
 900         * mi/mi-cmds.h: Rename include guard.
 901         * mi/mi-cmd-break.h: Rename include guard.
 902         * m2-lang.h: Add include guard.
 903         * location.h: Rename include guard.
 904         * linux-record.h: Rename include guard.
 905         * linux-nat.h: Add include guard.
 906         * linux-fork.h: Add include guard.
 907         * i386-darwin-tdep.h: Rename include guard.
 908         * hppa-linux-offsets.h: Add include guard.
 909         * guile/guile.h: Rename include guard.
 910         * guile/guile-internal.h: Rename include guard.
 911         * gnu-nat.h: Rename include guard.
 912         * gdb-stabs.h: Rename include guard.
 913         * frv-tdep.h: Add include guard.
 914         * f-lang.h: Add include guard.
 915         * event-loop.h: Add include guard.
 916         * darwin-nat.h: Rename include guard.
 917         * cp-abi.h: Rename include guard.
 918         * config/sparc/nm-sol2.h: Rename include guard.
 919         * config/nm-nto.h: Rename include guard.
 920         * config/nm-linux.h: Add include guard.
 921         * config/i386/nm-i386gnu.h: Rename include guard.
 922         * config/djgpp/nl_types.h: Rename include guard.
 923         * config/djgpp/langinfo.h: Rename include guard.
 924         * compile/gcc-cp-plugin.h: Add include guard.
 925         * compile/gcc-c-plugin.h: Add include guard.
 926         * compile/compile.h: Rename include guard.
 927         * compile/compile-object-run.h: Rename include guard.
 928         * compile/compile-object-load.h: Rename include guard.
 929         * compile/compile-internal.h: Rename include guard.
 930         * compile/compile-cplus.h: Rename include guard.
 931         * compile/compile-c.h: Rename include guard.
 932         * common/xml-utils.h: Rename include guard.
 933         * common/x86-xstate.h: Rename include guard.
 934         * common/version.h: Rename include guard.
 935         * common/vec.h: Rename include guard.
 936         * common/tdesc.h: Rename include guard.
 937         * common/selftest.h: Rename include guard.
 938         * common/scoped_restore.h: Rename include guard.
 939         * common/scoped_mmap.h: Rename include guard.
 940         * common/scoped_fd.h: Rename include guard.
 941         * common/safe-iterator.h: Rename include guard.
 942         * common/run-time-clock.h: Rename include guard.
 943         * common/refcounted-object.h: Rename include guard.
 944         * common/queue.h: Rename include guard.
 945         * common/ptid.h: Rename include guard.
 946         * common/print-utils.h: Rename include guard.
 947         * common/preprocessor.h: Rename include guard.
 948         * common/pathstuff.h: Rename include guard.
 949         * common/observable.h: Rename include guard.
 950         * common/netstuff.h: Rename include guard.
 951         * common/job-control.h: Rename include guard.
 952         * common/host-defs.h: Rename include guard.
 953         * common/gdb_wait.h: Rename include guard.
 954         * common/gdb_vecs.h: Rename include guard.
 955         * common/gdb_unlinker.h: Rename include guard.
 956         * common/gdb_unique_ptr.h: Rename include guard.
 957         * common/gdb_tilde_expand.h: Rename include guard.
 958         * common/gdb_sys_time.h: Rename include guard.
 959         * common/gdb_string_view.h: Rename include guard.
 960         * common/gdb_splay_tree.h: Rename include guard.
 961         * common/gdb_setjmp.h: Rename include guard.
 962         * common/gdb_ref_ptr.h: Rename include guard.
 963         * common/gdb_optional.h: Rename include guard.
 964         * common/gdb_locale.h: Rename include guard.
 965         * common/gdb_assert.h: Rename include guard.
 966         * common/filtered-iterator.h: Rename include guard.
 967         * common/filestuff.h: Rename include guard.
 968         * common/fileio.h: Rename include guard.
 969         * common/environ.h: Rename include guard.
 970         * common/common-utils.h: Rename include guard.
 971         * common/common-types.h: Rename include guard.
 972         * common/common-regcache.h: Rename include guard.
 973         * common/common-inferior.h: Rename include guard.
 974         * common/common-gdbthread.h: Rename include guard.
 975         * common/common-exceptions.h: Rename include guard.
 976         * common/common-defs.h: Rename include guard.
 977         * common/common-debug.h: Rename include guard.
 978         * common/cleanups.h: Rename include guard.
 979         * common/buffer.h: Rename include guard.
 980         * common/btrace-common.h: Rename include guard.
 981         * common/break-common.h: Rename include guard.
 982         * cli/cli-utils.h: Rename include guard.
 983         * cli/cli-style.h: Rename include guard.
 984         * cli/cli-setshow.h: Rename include guard.
 985         * cli/cli-script.h: Rename include guard.
 986         * cli/cli-interp.h: Rename include guard.
 987         * cli/cli-decode.h: Rename include guard.
 988         * cli/cli-cmds.h: Rename include guard.
 989         * charset-list.h: Add include guard.
 990         * buildsym-legacy.h: Rename include guard.
 991         * bfin-tdep.h: Add include guard.
 992         * ax.h: Rename include guard.
 993         * arm-linux-tdep.h: Add include guard.
 994         * arm-fbsd-tdep.h: Add include guard.
 995         * arch/xtensa.h: Rename include guard.
 996         * arch/tic6x.h: Add include guard.
 997         * arch/i386.h: Add include guard.
 998         * arch/arm.h: Rename include guard.
 999         * arch/arm-linux.h: Rename include guard.
1000         * arch/arm-get-next-pcs.h: Rename include guard.
1001         * arch/amd64.h: Add include guard.
1002         * arch/aarch64-insn.h: Rename include guard.
1003         * arch-utils.h: Rename include guard.
1004         * annotate.h: Add include guard.
1005         * amd64-darwin-tdep.h: Rename include guard.
1006         * aarch64-linux-tdep.h: Add include guard.
1007         * aarch64-fbsd-tdep.h: Add include guard.
1008         * aarch32-linux-nat.h: Add include guard.
1009
1010 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1011
1012         * macrotab.c (macro_define_internal): New function that
1013         factorizes macro_define_object_internal and macro_define_function
1014         code.
1015         (macro_define_object_internal): Use macro_define_internal.
1016         (macro_define_function): Likewise.
1017
1018 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1019
1020         * macrocmd.c (extract_identifier): Return
1021         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1022         callers.
1023
1024 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1025
1026         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1027
1028 2019-02-05  Tom Tromey  <tom@tromey.com>
1029
1030         * target.c (target_stack::unpush): Move assertion earlier.
1031
1032 2019-01-30  Tom Tromey  <tom@tromey.com>
1033
1034         PR python/23615:
1035         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1036         (gdbpy_parse_and_eval): Likewise.
1037         * python/python-internal.h (gdbpy_allow_threads): New class.
1038
1039 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1040
1041         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1042         (aarch64_fbsd_fpregmap): Move earlier.
1043         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1044         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1045         instead of individual calls to trad_frame_set_reg_addr.
1046         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1047         earlier.
1048         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1049         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1050         instead of individual calls to trad_frame_set_reg_addr.
1051
1052 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1053
1054         * CONTRIBUTE: Replace contribution list with wiki link.
1055
1056 2019-01-25  Tom Tromey  <tom@tromey.com>
1057
1058         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1059
1060 2019-01-25  Tom Tromey  <tom@tromey.com>
1061
1062         * xtensa-linux-nat.c: Fix common/ includes.
1063         * xml-support.h: Fix common/ includes.
1064         * xml-support.c: Fix common/ includes.
1065         * x86-linux-nat.c: Fix common/ includes.
1066         * windows-nat.c: Fix common/ includes.
1067         * varobj.h: Fix common/ includes.
1068         * varobj.c: Fix common/ includes.
1069         * value.c: Fix common/ includes.
1070         * valops.c: Fix common/ includes.
1071         * utils.c: Fix common/ includes.
1072         * unittests/xml-utils-selftests.c: Fix common/ includes.
1073         * unittests/utils-selftests.c: Fix common/ includes.
1074         * unittests/unpack-selftests.c: Fix common/ includes.
1075         * unittests/tracepoint-selftests.c: Fix common/ includes.
1076         * unittests/style-selftests.c: Fix common/ includes.
1077         * unittests/string_view-selftests.c: Fix common/ includes.
1078         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1079         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1080         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1081         * unittests/rsp-low-selftests.c: Fix common/ includes.
1082         * unittests/parse-connection-spec-selftests.c: Fix common/
1083         includes.
1084         * unittests/optional-selftests.c: Fix common/ includes.
1085         * unittests/offset-type-selftests.c: Fix common/ includes.
1086         * unittests/observable-selftests.c: Fix common/ includes.
1087         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1088         * unittests/memrange-selftests.c: Fix common/ includes.
1089         * unittests/memory-map-selftests.c: Fix common/ includes.
1090         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1091         * unittests/function-view-selftests.c: Fix common/ includes.
1092         * unittests/environ-selftests.c: Fix common/ includes.
1093         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1094         * unittests/common-utils-selftests.c: Fix common/ includes.
1095         * unittests/cli-utils-selftests.c: Fix common/ includes.
1096         * unittests/array-view-selftests.c: Fix common/ includes.
1097         * ui-file.c: Fix common/ includes.
1098         * tui/tui-io.c: Fix common/ includes.
1099         * tracepoint.h: Fix common/ includes.
1100         * tracepoint.c: Fix common/ includes.
1101         * tracefile-tfile.c: Fix common/ includes.
1102         * top.h: Fix common/ includes.
1103         * top.c: Fix common/ includes.
1104         * thread.c: Fix common/ includes.
1105         * target/waitstatus.h: Fix common/ includes.
1106         * target/waitstatus.c: Fix common/ includes.
1107         * target.h: Fix common/ includes.
1108         * target.c: Fix common/ includes.
1109         * target-memory.c: Fix common/ includes.
1110         * target-descriptions.c: Fix common/ includes.
1111         * symtab.h: Fix common/ includes.
1112         * symfile.c: Fix common/ includes.
1113         * stap-probe.c: Fix common/ includes.
1114         * spu-linux-nat.c: Fix common/ includes.
1115         * sparc-nat.c: Fix common/ includes.
1116         * source.c: Fix common/ includes.
1117         * solib.c: Fix common/ includes.
1118         * solib-target.c: Fix common/ includes.
1119         * ser-unix.c: Fix common/ includes.
1120         * ser-tcp.c: Fix common/ includes.
1121         * ser-pipe.c: Fix common/ includes.
1122         * ser-base.c: Fix common/ includes.
1123         * selftest-arch.c: Fix common/ includes.
1124         * s12z-tdep.c: Fix common/ includes.
1125         * rust-exp.y: Fix common/ includes.
1126         * rs6000-aix-tdep.c: Fix common/ includes.
1127         * riscv-tdep.c: Fix common/ includes.
1128         * remote.c: Fix common/ includes.
1129         * remote-notif.h: Fix common/ includes.
1130         * remote-fileio.h: Fix common/ includes.
1131         * remote-fileio.c: Fix common/ includes.
1132         * regcache.h: Fix common/ includes.
1133         * regcache.c: Fix common/ includes.
1134         * record-btrace.c: Fix common/ includes.
1135         * python/python.c: Fix common/ includes.
1136         * python/py-type.c: Fix common/ includes.
1137         * python/py-inferior.c: Fix common/ includes.
1138         * progspace.h: Fix common/ includes.
1139         * producer.c: Fix common/ includes.
1140         * procfs.c: Fix common/ includes.
1141         * proc-api.c: Fix common/ includes.
1142         * printcmd.c: Fix common/ includes.
1143         * ppc-linux-nat.c: Fix common/ includes.
1144         * parser-defs.h: Fix common/ includes.
1145         * osdata.c: Fix common/ includes.
1146         * obsd-nat.c: Fix common/ includes.
1147         * nat/x86-linux.c: Fix common/ includes.
1148         * nat/x86-linux-dregs.c: Fix common/ includes.
1149         * nat/x86-dregs.h: Fix common/ includes.
1150         * nat/x86-dregs.c: Fix common/ includes.
1151         * nat/ppc-linux.c: Fix common/ includes.
1152         * nat/mips-linux-watch.h: Fix common/ includes.
1153         * nat/mips-linux-watch.c: Fix common/ includes.
1154         * nat/linux-waitpid.c: Fix common/ includes.
1155         * nat/linux-ptrace.h: Fix common/ includes.
1156         * nat/linux-ptrace.c: Fix common/ includes.
1157         * nat/linux-procfs.c: Fix common/ includes.
1158         * nat/linux-personality.c: Fix common/ includes.
1159         * nat/linux-osdata.c: Fix common/ includes.
1160         * nat/linux-namespaces.c: Fix common/ includes.
1161         * nat/linux-btrace.h: Fix common/ includes.
1162         * nat/linux-btrace.c: Fix common/ includes.
1163         * nat/fork-inferior.c: Fix common/ includes.
1164         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1165         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1166         * nat/aarch64-linux.c: Fix common/ includes.
1167         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1168         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1169         * namespace.h: Fix common/ includes.
1170         * mips-linux-tdep.c: Fix common/ includes.
1171         * minsyms.c: Fix common/ includes.
1172         * mi/mi-parse.h: Fix common/ includes.
1173         * mi/mi-main.c: Fix common/ includes.
1174         * mi/mi-cmd-env.c: Fix common/ includes.
1175         * memrange.h: Fix common/ includes.
1176         * memattr.c: Fix common/ includes.
1177         * maint.h: Fix common/ includes.
1178         * maint.c: Fix common/ includes.
1179         * main.c: Fix common/ includes.
1180         * machoread.c: Fix common/ includes.
1181         * location.c: Fix common/ includes.
1182         * linux-thread-db.c: Fix common/ includes.
1183         * linux-nat.c: Fix common/ includes.
1184         * linux-fork.c: Fix common/ includes.
1185         * inline-frame.c: Fix common/ includes.
1186         * infrun.c: Fix common/ includes.
1187         * inflow.c: Fix common/ includes.
1188         * inferior.h: Fix common/ includes.
1189         * inferior.c: Fix common/ includes.
1190         * infcmd.c: Fix common/ includes.
1191         * inf-ptrace.c: Fix common/ includes.
1192         * inf-child.c: Fix common/ includes.
1193         * ia64-linux-nat.c: Fix common/ includes.
1194         * i387-tdep.c: Fix common/ includes.
1195         * i386-tdep.c: Fix common/ includes.
1196         * i386-linux-tdep.c: Fix common/ includes.
1197         * i386-linux-nat.c: Fix common/ includes.
1198         * i386-go32-tdep.c: Fix common/ includes.
1199         * i386-fbsd-tdep.c: Fix common/ includes.
1200         * i386-fbsd-nat.c: Fix common/ includes.
1201         * guile/scm-type.c: Fix common/ includes.
1202         * guile/guile.c: Fix common/ includes.
1203         * go32-nat.c: Fix common/ includes.
1204         * gnu-nat.c: Fix common/ includes.
1205         * gdbthread.h: Fix common/ includes.
1206         * gdbarch-selftests.c: Fix common/ includes.
1207         * gdb_usleep.c: Fix common/ includes.
1208         * gdb_select.h: Fix common/ includes.
1209         * gdb_bfd.c: Fix common/ includes.
1210         * gcore.c: Fix common/ includes.
1211         * fork-child.c: Fix common/ includes.
1212         * findvar.c: Fix common/ includes.
1213         * fbsd-nat.c: Fix common/ includes.
1214         * event-top.c: Fix common/ includes.
1215         * event-loop.c: Fix common/ includes.
1216         * dwarf2read.c: Fix common/ includes.
1217         * dwarf2loc.c: Fix common/ includes.
1218         * dwarf2-frame.c: Fix common/ includes.
1219         * dwarf-index-cache.c: Fix common/ includes.
1220         * dtrace-probe.c: Fix common/ includes.
1221         * disasm-selftests.c: Fix common/ includes.
1222         * defs.h: Fix common/ includes.
1223         * csky-tdep.c: Fix common/ includes.
1224         * cp-valprint.c: Fix common/ includes.
1225         * cp-support.h: Fix common/ includes.
1226         * cp-support.c: Fix common/ includes.
1227         * corelow.c: Fix common/ includes.
1228         * completer.h: Fix common/ includes.
1229         * completer.c: Fix common/ includes.
1230         * compile/compile.c: Fix common/ includes.
1231         * compile/compile-loc2c.c: Fix common/ includes.
1232         * compile/compile-cplus-types.c: Fix common/ includes.
1233         * compile/compile-cplus-symbols.c: Fix common/ includes.
1234         * command.h: Fix common/ includes.
1235         * cli/cli-dump.c: Fix common/ includes.
1236         * cli/cli-cmds.c: Fix common/ includes.
1237         * charset.c: Fix common/ includes.
1238         * build-id.c: Fix common/ includes.
1239         * btrace.h: Fix common/ includes.
1240         * btrace.c: Fix common/ includes.
1241         * breakpoint.h: Fix common/ includes.
1242         * breakpoint.c: Fix common/ includes.
1243         * ax.h:
1244         (enum agent_op): Fix common/ includes.
1245         * ax-general.c (struct aop_map): Fix common/ includes.
1246         * ax-gdb.c: Fix common/ includes.
1247         * auxv.c: Fix common/ includes.
1248         * auto-load.c: Fix common/ includes.
1249         * arm-tdep.c: Fix common/ includes.
1250         * arch/riscv.c: Fix common/ includes.
1251         * arch/ppc-linux-common.c: Fix common/ includes.
1252         * arch/i386.c: Fix common/ includes.
1253         * arch/arm.c: Fix common/ includes.
1254         * arch/arm-linux.c: Fix common/ includes.
1255         * arch/arm-get-next-pcs.c: Fix common/ includes.
1256         * arch/amd64.c: Fix common/ includes.
1257         * arch/aarch64.c: Fix common/ includes.
1258         * arch/aarch64-insn.c: Fix common/ includes.
1259         * arch-utils.c: Fix common/ includes.
1260         * amd64-windows-tdep.c: Fix common/ includes.
1261         * amd64-tdep.c: Fix common/ includes.
1262         * amd64-sol2-tdep.c: Fix common/ includes.
1263         * amd64-obsd-tdep.c: Fix common/ includes.
1264         * amd64-nbsd-tdep.c: Fix common/ includes.
1265         * amd64-linux-tdep.c: Fix common/ includes.
1266         * amd64-linux-nat.c: Fix common/ includes.
1267         * amd64-fbsd-tdep.c: Fix common/ includes.
1268         * amd64-fbsd-nat.c: Fix common/ includes.
1269         * amd64-dicos-tdep.c: Fix common/ includes.
1270         * amd64-darwin-tdep.c: Fix common/ includes.
1271         * agent.c: Fix common/ includes.
1272         * ada-lang.h: Fix common/ includes.
1273         * ada-lang.c: Fix common/ includes.
1274         * aarch64-tdep.c: Fix common/ includes.
1275
1276 2019-01-25  Tom Tromey  <tom@tromey.com>
1277
1278         * common/create-version.sh: Use common/version.h.
1279
1280 2019-01-24  Pedro Alves  <palves@redhat.com>
1281
1282         * infrun.c (signal_stop, signal_print, signal_program)
1283         (signal_catch, signal_pass): Now arrays instead of pointers.
1284         (update_signals_program_target, do_target_resume)
1285         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1286         * linux-nat.c (linux_nat_target::pass_signals)
1287         (linux_nat_target::create_inferior, linux_nat_target::attach):
1288         Adjust.
1289         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1290         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1291         * procfs.c (procfs_target::pass_signals): Adjust.
1292         * record-full.c (record_full_target::resume): Adjust.
1293         * remote.c (remote_target::pass_signals)
1294         (remote_target::program_signals): Adjust.
1295         * target-debug.h (target_debug_print_signals): Now takes a
1296         gdb::array_view as parameter.  Adjust.
1297         * target.h (target_ops) <pass_signals, program_signals>: Replace
1298         pointer and length parameters with gdb::array_view.
1299         (target_pass_signals, target_program_signals): Likewise.
1300         * target-delegates.c: Regenerate.
1301
1302 2019-01-24  Pedro Alves  <palves@redhat.com>
1303
1304         * common/forward-scope-exit.h
1305         (forward_scope_exit::forward_scope_exit): Pass arguments to
1306         m_bind_function directly, instead of creating a std::bind and
1307         copying that.
1308
1309 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1310
1311         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1312         for static members.
1313         (pass_in_v_vfp_candidate): Likewise.
1314
1315 2019-01-23  Tom Tromey  <tom@tromey.com>
1316             Pedro Alves  <palves@redhat.com>
1317
1318         * regcache.c (class regcache_invalidator): Remove.
1319         (regcache::raw_write): Use make_scope_exit.
1320
1321 2019-01-23  Tom Tromey  <tom@tromey.com>
1322
1323         * ui-out.h (class ui_out_emit_type): Update comment.
1324
1325 2019-01-23  Tom Tromey  <tom@tromey.com>
1326
1327         * infrun.c (fetch_inferior_event): Update comment.
1328
1329 2019-01-23  Tom Tromey  <tom@tromey.com>
1330             Pedro Alves  <palves@redhat.com>
1331
1332         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1333         parameter.
1334         (fetch_inferior_event): Use SCOPE_EXIT.
1335
1336
1337 2019-01-23  Tom Tromey  <tom@tromey.com>
1338             Pedro Alves  <palves@redhat.com>
1339
1340         * infrun.c (disable_thread_events): Delete.
1341         (stop_all_threads): Use SCOPE_EXIT.
1342
1343 2019-01-23  Tom Tromey  <tom@tromey.com>
1344             Pedro Alves  <palves@redhat.com>
1345
1346         * symfile.c: Include forward-scope-exit.h.
1347         (clear_symtab_users_cleanup): Replace forward declaration with
1348         a FORWARD_SCOPE_EXIT.
1349         (syms_from_objfile_1): Use the forward_scope_exit and
1350         gdb::optional instead of cleanup_function.
1351         (reread_symbols): Use the forward_scope_exit instead of
1352         cleanup_function.
1353         (clear_symtab_users_cleanup): Remove function.
1354
1355 2019-01-23  Tom Tromey  <tom@tromey.com>
1356             Pedro Alves  <palves@redhat.com>
1357
1358         * linux-nat.c: Include scope-exit.h.
1359         (cleanup_target_stop): Remove.
1360         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1361         SCOPE_EXIT.
1362
1363 2019-01-23  Tom Tromey  <tom@tromey.com>
1364             Pedro Alves  <palves@redhat.com>
1365
1366         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1367         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1368
1369 2019-01-23  Tom Tromey  <tom@tromey.com>
1370             Andrew Burgess  <andrew.burgess@embecosm.com>
1371             Pedro Alves  <palves@redhat.com>
1372
1373         * infrun.c (fetch_inferior_event): Use scope_exit.
1374         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1375         * top.c (execute_command): Use scope_exit.
1376         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1377         * utils.c (do_bpstat_clear_actions_cleanup)
1378         (make_bpstat_clear_actions_cleanup): Remove.
1379
1380 2019-01-23  Tom Tromey  <tom@tromey.com>
1381             Pedro Alves  <palves@redhat.com>
1382
1383         * infrun.c: Include "common/scope-exit.h"
1384         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1385         (wait_for_inferior): Use SCOPE_EXIT.
1386         (fetch_inferior_event): Use scope_exit.
1387
1388 2019-01-23  Tom Tromey  <tom@tromey.com>
1389             Pedro Alves  <palves@redhat.com>
1390
1391         * breakpoint.c (create_breakpoint): Remove cleanup.
1392
1393 2019-01-23  Tom Tromey  <tom@tromey.com>
1394             Andrew Burgess  <andrew.burgess@embecosm.com>
1395             Pedro Alves  <palves@redhat.com>
1396
1397 2019-01-23  Pedro Alves  <palves@redhat.com>
1398
1399         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1400
1401 2019-01-23  Pedro Alves  <palves@redhat.com>
1402             Andrew Burgess  <andrew.burgess@embecosm.com>
1403
1404         * gdbthread.h: Include "common/forward-scope-exit.h".
1405         (scoped_finish_thread_state): Redefine custom class in terms of
1406         forward_scope_exit.
1407
1408 2019-01-23  Pedro Alves  <palves@redhat.com>
1409             Andrew Burgess  <andrew.burgess@embecosm.com>
1410
1411         * common/forward-scope-exit.h: New file.
1412
1413 2019-01-23  Pedro Alves  <palves@redhat.com>
1414             Andrew Burgess  <andrew.burgess@embecosm.com>
1415             Tom Tromey  <tom@tromey.com>
1416
1417         * common/scope-exit.h: New file.
1418
1419 2019-01-23  Pedro Alves  <palves@redhat.com>
1420
1421         * common/preprocessor.h (ESC): Rename to ...
1422         (ESC_PARENS): ... this.
1423         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1424         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1425
1426 2019-01-23  Tom Tromey  <tom@tromey.com>
1427
1428         * language.h (class scoped_switch_to_sym_language_if_auto):
1429         Initialize m_lang in both cases.
1430
1431 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1432
1433         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1434         with XCNEW.
1435
1436 2019-01-22  Tom Tromey  <tom@tromey.com>
1437
1438         * corelow.c: Do not include sys/file.h.
1439
1440 2019-01-22  Tom Tromey  <tom@tromey.com>
1441
1442         * tui/tui-wingeneral.h: Include gdb_curses.h.
1443
1444 2019-01-22  Tom Tromey  <tom@tromey.com>
1445
1446         * source-cache.h (class source_cache) <get_source_lines,
1447         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1448
1449 2019-01-22  Tom Tromey  <tom@tromey.com>
1450
1451         * remote-fileio.h (struct remote_target): Declare.
1452
1453 2019-01-22  Tom Tromey  <tom@tromey.com>
1454
1455         * python/py-arch.c: Do not include py-ref.h.
1456         * python/py-bpevent.c: Do not include py-ref.h.
1457         * python/py-cmd.c: Do not include py-ref.h.
1458         * python/py-continueevent.c: Do not include py-ref.h.
1459         * python/py-event.h: Do not include py-ref.h.
1460         * python/py-evtregistry.c: Do not include py-ref.h.
1461         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1462         * python/py-frame.c: Do not include py-ref.h.
1463         * python/py-framefilter.c: Do not include py-ref.h.
1464         * python/py-function.c: Do not include py-ref.h.
1465         * python/py-infevents.c: Do not include py-ref.h.
1466         * python/py-linetable.c: Do not include py-ref.h.
1467         * python/py-objfile.c: Do not include py-ref.h.
1468         * python/py-param.c: Do not include py-ref.h.
1469         * python/py-prettyprint.c: Do not include py-ref.h.
1470         * python/py-progspace.c: Do not include py-ref.h.
1471         * python/py-symbol.c: Do not include py-ref.h.
1472         * python/py-symtab.c: Do not include py-ref.h.
1473         * python/py-type.c: Do not include py-ref.h.
1474         * python/py-unwind.c: Do not include py-ref.h.
1475         * python/py-utils.c: Do not include py-ref.h.
1476         * python/py-value.c: Do not include py-ref.h.
1477         * python/py-varobj.c: Do not include py-ref.h.
1478         * python/py-xmethods.c: Do not include py-ref.h.
1479         * python/python.c: Do not include py-ref.h.
1480         * varobj.c: Do not include py-ref.h.
1481
1482 2019-01-22  Tom Tromey  <tom@tromey.com>
1483
1484         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1485         keyword for bcache.
1486
1487 2019-01-22  Tom Tromey  <tom@tromey.com>
1488
1489         * compile/compile-cplus-types.c: Remove a comment by #include.
1490
1491 2019-01-22  Tom Tromey  <tom@tromey.com>
1492
1493         * compile/gcc-c-plugin.h: Include compile-internal.h.
1494
1495 2019-01-22  Tom Tromey  <tom@tromey.com>
1496
1497         * stabsread.c (EXTERN): Do not define.
1498         (symnum, next_symbol_text_func, processing_gcc_compilation)
1499         (within_function, global_sym_chain, global_stabs)
1500         (previous_stab_code, this_object_header_files)
1501         (n_this_object_header_files)
1502         (n_allocated_this_object_header_files): Define.
1503         * stabsread.h (EXTERN): Never define.  Use "extern".
1504
1505 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1506
1507         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1508         history_value.
1509
1510 2019-01-21  Tom Tromey  <tom@tromey.com>
1511
1512         * ui-out.c: Fix includes.
1513         * tui/tui-source.c: Fix includes.
1514         * target.c: Fix includes.
1515         * remote.c: Fix includes.
1516         * regcache.c: Fix includes.
1517         * python/py-block.c: Fix includes.
1518         * printcmd.c: Fix includes.
1519         * or1k-tdep.c: Fix includes.
1520         * mi/mi-main.c: Fix includes.
1521         * m32r-tdep.c: Fix includes.
1522         * csky-tdep.c: Fix includes.
1523         * compile/compile-cplus-types.c: Fix includes.
1524         * cli/cli-interp.c: Fix includes.
1525
1526 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1527
1528         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1529         for padding.
1530
1531 2019-01-16  Tom Tromey  <tom@tromey.com>
1532
1533         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1534         earlier.
1535         (struct objfile) <msymbols_range>: Move from top level.
1536         <msymbols>: New method.
1537         (class objfile_msymbols): Remove.
1538         * symtab.c (default_collect_symbol_completion_matches_break_on):
1539         Update.
1540         * symmisc.c (dump_msymbols): Update.
1541         * stabsread.c (scan_file_globals): Update.
1542         * objc-lang.c (info_selectors_command, info_classes_command)
1543         (find_methods): Update.
1544         * minsyms.c (find_solib_trampoline_target): Update.
1545         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1546         * coffread.c (coff_symfile_read): Update.
1547         * ada-lang.c (ada_lookup_simple_minsym)
1548         (ada_collect_symbol_completion_matches): Update.
1549
1550 2019-01-16  Tom Tromey  <tom@tromey.com>
1551
1552         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1553         type.  Remove no-argument constructor.
1554         <iterator::operator++>: Simplify.
1555         <begin>: Update.
1556         <end>: Use minimal_symbol_count.
1557
1558 2019-01-16  Tom Tromey  <tom@tromey.com>
1559
1560         * objfiles.h (struct objfile) <psymtabs>: New method.
1561         (class objfile_psymtabs): Remove.
1562         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1563         typedef.
1564         <range>: New method.
1565         (require_partial_symbols): Change return type.
1566         * psymtab.c (require_partial_symbols)
1567         (psym_expand_symtabs_matching): Update.
1568         * mdebugread.c (parse_partial_symbols): Update.
1569         * dbxread.c (dbx_end_psymtab): Update.
1570
1571 2019-01-15  Tom Tromey  <tom@tromey.com>
1572
1573         * symtab.c (lookup_objfile_from_block)
1574         (lookup_symbol_in_objfile_symtabs)
1575         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1576         (find_line_symtab, info_sources_command)
1577         (default_collect_symbol_completion_matches_break_on)
1578         (make_source_files_completion_list): Update.
1579         * symmisc.c (print_objfile_statistics, dump_objfile)
1580         (maintenance_print_symbols, maintenance_info_symtabs)
1581         (maintenance_check_symtabs, maintenance_info_line_tables):
1582         Update.
1583         * source.c (select_source_symtab)
1584         (forget_cached_source_info_for_objfile): Update.
1585         * objfiles.h (class objfile_compunits): Remove.
1586         (struct objfile) <compunits_range>: New typedef.
1587         (compunits): New method.
1588         * objfiles.c (objfile_relocate1): Update.
1589         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1590         * maint.c (count_symtabs_and_blocks): Update.
1591         * linespec.c (iterate_over_all_matching_symtabs): Update.
1592         * cp-support.c (add_symbol_overload_list_qualified): Update.
1593         * coffread.c (coff_symtab_read): Update.
1594         * ada-lang.c (add_nonlocal_symbols)
1595         (ada_collect_symbol_completion_matches)
1596         (ada_add_global_exceptions): Update.
1597
1598 2019-01-15  Tom Tromey  <tom@tromey.com>
1599
1600         * progspace.h (program_space) <objfiles_safe_range>: New
1601         typedef.
1602         <objfiles_safe>: New method.
1603         * objfiles.h (class all_objfiles_safe): Remove.
1604         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1605         * jit.c (jit_inferior_exit_hook): Update.
1606
1607 2019-01-17  Tom Tromey  <tom@tromey.com>
1608
1609         * progspace.h (program_space) <objfiles_range>: New typedef.
1610         <objfiles>: New method.
1611         <objfiles_head>: Rename from objfiles.
1612         (object_files): Update.
1613         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1614         * guile/scm-pretty-print.c
1615         (ppscm_find_pretty_printer_from_objfiles): Update.
1616         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1617         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1618         Update.
1619         * python/py-progspace.c (pspy_get_objfiles): Update.
1620         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1621         Update.
1622         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1623         (objfpy_lookup_objfile_by_build_id): Update.
1624         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1625         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1626         Update.
1627         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1628         (expand_symtab_containing_pc, lookup_objfile_from_block)
1629         (lookup_static_symbol, basic_lookup_transparent_type)
1630         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1631         (find_line_symtab, info_sources_command)
1632         (default_collect_symbol_completion_matches_break_on)
1633         (make_source_files_completion_list, find_main_name): Update.
1634         * symmisc.c (print_symbol_bcache_statistics)
1635         (print_objfile_statistics, maintenance_print_symbols)
1636         (maintenance_print_msymbols, maintenance_print_objfiles)
1637         (maintenance_info_symtabs, maintenance_check_symtabs)
1638         (maintenance_expand_symtabs, maintenance_info_line_tables):
1639         Update.
1640         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1641         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1642         (map_overlay_command, unmap_overlay_command)
1643         (simple_overlay_update, expand_symtabs_matching)
1644         (map_symbol_filenames): Update.
1645         * symfile-debug.c (set_debug_symfile): Update.
1646         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1647         Update.
1648         * source.c (select_source_symtab, forget_cached_source_info):
1649         Update.
1650         * solib.c (solib_read_symbols): Update.
1651         * solib-spu.c (append_ocl_sos): Update.
1652         * psymtab.c (maintenance_print_psymbols)
1653         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1654         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1655         * printcmd.c (info_symbol_command): Update.
1656         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1657         Update.
1658         * objfiles.h (class all_objfiles): Remove.
1659         * objfiles.c (have_partial_symbols, have_full_symbols)
1660         (have_minimal_symbols, qsort_cmp, update_section_map)
1661         (shared_objfile_contains_address_p)
1662         (default_iterate_over_objfiles_in_search_order): Update.
1663         * objc-lang.c (info_selectors_command, info_classes_command)
1664         (find_methods): Update.
1665         * minsyms.c (find_solib_trampoline_target): Update.
1666         * maint.c (maintenance_info_sections)
1667         (maintenance_translate_address, count_symtabs_and_blocks):
1668         Update.
1669         * main.c (captured_main_1): Update.
1670         * linux-thread-db.c (try_thread_db_load_from_pdir)
1671         (has_libpthread): Update.
1672         * linespec.c (iterate_over_all_matching_symtabs)
1673         (search_minsyms_for_name): Update.
1674         * jit.c (jit_find_objf_with_entry_addr): Update.
1675         * hppa-tdep.c (find_unwind_entry)
1676         (hppa_lookup_stub_minimal_symbol): Update.
1677         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1678         Update.
1679         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1680         (elf_gnu_ifunc_resolve_by_got): Update.
1681         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1682         * dwarf-index-write.c (save_gdb_index_command): Update.
1683         * cp-support.c (add_symbol_overload_list_qualified): Update.
1684         * breakpoint.c (create_overlay_event_breakpoint)
1685         (create_longjmp_master_breakpoint)
1686         (create_std_terminate_master_breakpoint)
1687         (create_exception_master_breakpoint): Update.
1688         * blockframe.c (find_pc_partial_function): Update.
1689         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1690         (ada_collect_symbol_completion_matches)
1691         (ada_add_global_exceptions): Update.
1692
1693 2019-01-17  Tom Tromey  <tom@tromey.com>
1694
1695         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1696         declare VEC.
1697         (solib_target_parse_libraries): Change return type.
1698         (library_list_start_segment, library_list_start_section)
1699         (library_list_end_library, library_list_start_library); Update.
1700         (solib_target_free_library_list): Remove.
1701         (solib_target_parse_libraries): Remove cleanup.  Change return
1702         type.
1703         (solib_target_current_sos): Update.
1704
1705 2019-01-17  Tom Tromey  <tromey@bapiya>
1706
1707         * valprint.c: Replace "the the" with "the".
1708         * symtab.c: Replace "the the" with "the".
1709         * solib.c: Replace "the the" with "the".
1710         * solib-dsbt.c: Replace "the the" with "the".
1711         * linespec.c: Replace "the the" with "the".
1712         * dwarf2loc.h: Replace "the the" with "the".
1713         * amd64-windows-tdep.c: Replace "the the" with "the".
1714         * aarch64-tdep.c: Replace "the the" with "the".
1715
1716 2019-01-16  Keith Seitz  <keiths@redhat.com>
1717
1718         PR gdb/23773
1719         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1720         <builder>: Rename to ..
1721         <m_builder>: ... this and make private.
1722         (dwarf2_cu::get_builder): New method.  Change all users of
1723         `builder' to use this method.
1724         (dwarf2_start_symtab): Move to ...
1725         (dwarf2_cu::start_symtab): ... here.  Update all callers
1726         (setup_type_unit_groups): Move to ...
1727         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1728         callers.
1729         (dwarf2_cu::reset_builder): New method.
1730         (process_full_compunit, process_full_type_unit): Use
1731         dwarf2_cu::reset_builder.
1732         (follow_die_offset): Record the ancestor CU if it is different
1733         from the followed DIE's CU.
1734         (follow_die_sig_1): Likewise.
1735
1736 2019-01-15  Tom Tromey  <tom@tromey.com>
1737
1738         * remote.c (class remote_state) <buf>: Now a char_vector.
1739         <buf_size>: Remove.
1740         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1741         parameter.
1742         (remote_target::getpkt_or_notif_sane_1)
1743         (remote_target::getpkt_sane)
1744         (remote_target::getpkt_or_notif_sane): Likewise.
1745         (class remote_target) <putpkt>: New overload.
1746         (remote_target::read_frame): Change type of "buf_p".  Remove
1747         sizeof_p parameter.
1748         (packet_ok): New overload.
1749         (packet_check_result): New overload.
1750         Update all uses.
1751
1752 2019-01-14  Tom Tromey  <tom@tromey.com>
1753
1754         * remote-notif.c (handle_notification, remote_notif_ack)
1755         (remote_notif_parse): Make "buf" const.
1756         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1757         const.
1758         (remote_notif_parse, remote_notif_ack, handle_notification):
1759         Likewise.
1760         * remote.c (remote_notif_stop_parse): Make "buf" const.
1761         (remote_target::remote_parse_stop_reply): Make "buf" const.
1762         (remote_notif_stop_ack): Make "buf" const.
1763
1764 2019-01-14  Tom Tromey  <tom@tromey.com>
1765
1766         * remote.c (remote_console_output): Make parameter const.
1767
1768 2019-01-14  Tom Tromey  <tom@tromey.com>
1769
1770         * target-debug.h (target_debug_print_signals): Constify.
1771         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1772         * procfs.c (procfs_target::pass_signals): Update.
1773         * linux-nat.c (linux_nat_target::pass_signals): Update.
1774         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1775         * target-delegates.c: Rebuild.
1776         * remote.c (remote_target::program_signals): Update.
1777         (remote_target::pass_signals): Update.
1778         * target.c (target_pass_signals): Constify argument.
1779         (target_program_signals): Likewise.
1780         * target.h (struct target_ops) <pass_signals, program_signals>:
1781         Constify argument.
1782         (target_pass_signals, target_program_signals): Constify argument.
1783
1784 2019-01-14  Tom Tromey  <tom@tromey.com>
1785
1786         PR tui/28819:
1787         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1788
1789 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1790
1791         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1792         field.
1793         * rs6000-tdep.c: Include reggroups.h.
1794         (IS_V_ALIAS_PSEUDOREG): Define.
1795         (rs6000_register_name): Return names for the "vX" aliases.
1796         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1797         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1798         aliases.  Call default_register_reggroup_p for all other
1799         pseudo-registers.
1800         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1801         New functions.
1802         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1803         Handle "vX" aliases.
1804         (v_alias_pseudo_register_collect): New function.
1805         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1806         (rs6000_gdbarch_init): Initialize "vX" aliases as
1807         pseudo-registers.  Restore registration of
1808         rs6000_pseudo_register_reggroup_p with
1809         set_tdesc_pseudo_register_reggroup_p.
1810
1811 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1812
1813         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1814         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1815         set_gdbarch_num_pseudo_regs.
1816
1817 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1818
1819         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1820         Remove arg prefixname, add do_set and do_show.
1821         Add member functions set_list and show_list.
1822         * cli/cli-style.c (class cli_style_option): Update accordingly.
1823         (style_set_list): Move to file scope.
1824         (style_show_list): Likewise.
1825         (set_style): Call help_list.
1826         (show_style): Call cmd_show_list.
1827         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1828         Update to use the new macro.
1829
1830 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1831
1832         * ada-lang.c (_initialize_ada_language): Expand the help text
1833         for the "catch exception" command.
1834
1835 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1836
1837         * symtab.c (matching_obj_sections): Initialize obj,
1838         declare it closer to its usage.
1839
1840 2019-01-10  Tom Tromey  <tom@tromey.com>
1841
1842         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1843         (basic_inf_threads_range): Remove.
1844         (inf_threads_range, inf_non_exited_threads_range)
1845         (safe_inf_threads_range): Use next_adapter.
1846
1847 2019-01-10  Keith Seitz  <keiths@redhat.com>
1848
1849         PR gdb/23712
1850         PR symtab/23010
1851         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1852         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1853
1854 2019-01-10  Keith Seitz  <keiths@redhat.com>
1855
1856         PR gdb/23712
1857         PR symtab/23010
1858         * dictionary.c (pending_to_vector): Remove.
1859         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1860         Remove _1 suffix, replacing functions of the same name.  Update
1861         all callers.
1862         (dict_create_hashed, dict_create_hashed_expandable)
1863         (dict_create_linear, dict_create_linear_expandable, dict_free)
1864         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1865         Make functions static.
1866
1867 2019-01-10  Keith Seitz  <keiths@redhat.com>
1868
1869         PR gdb/23712
1870         PR symtab/23010
1871         * dictionary.h (struct dictionary): Replace declaration with
1872         multidictionary.
1873         (dict_create_hashed, dict_create_hashed_expandable)
1874         (dict_create_linear, dict_create_linear_expandable)
1875         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1876         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1877         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1878         taking multidictionary argument.
1879         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1880         * block.h (struct block) <dict>: Change to multidictionary
1881         and rename `multidict'.
1882         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1883         symmisc.c: Update all dictionary references to multidictionary.
1884
1885 2019-01-10  Keith Seitz  <keiths@redhat.com>
1886
1887         PR gdb/23712
1888         PR symtab/23010
1889         * dictionary.c: Include unordered_map.
1890         (pending_to_vector): New function.
1891         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1892         Rewrite the non-"_1" functions to take vector instead
1893         of linked list.
1894         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1895         "new" _1 versions of the same name.
1896         (multidictionary): Define.
1897         (std::hash<enum language): New definition.
1898         (collate_pending_symbols_by_language, mdict_create_hashed)
1899         (mdict_create_hashed_expandable, mdict_create_linear)
1900         (mdict_create_linear_expandable, mdict_free)
1901         (find_language_dictionary, create_new_language_dictionary)
1902         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1903         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1904         (mdict_size, mdict_empty): New functions.
1905         * dictionary.h (mdict_iterator): Define.
1906
1907 2019-01-10  Pedro Alves  <palves@redhat.com>
1908
1909         * breakpoint.c (read_uploaded_action)
1910         (create_tracepoint_from_upload): Adjust to use
1911         gdb::unique_xmalloc_ptr.
1912         * ctf.c (ctf_write_uploaded_tp):
1913         (SET_ARRAY_FIELD): Use emplace_back.
1914         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1915         * tracefile-tfile.c (tfile_write_uploaded_tp):
1916         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1917         gdb::unique_xmalloc_ptr.
1918         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1919         at_string, cond_string, cmd_strings>: Replace char pointers
1920         with gdb::unique_xmalloc_ptr.
1921
1922 2019-01-10  Pedro Alves  <palves@redhat.com>
1923
1924         * solib-target.c (library_list_start_library): Don't xstrdup name.
1925
1926 2019-01-10  Pedro Alves  <palves@redhat.com>
1927
1928         * mdebugread.c (parse_partial_symbols): Use
1929         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1930
1931 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1932
1933         * linux-fork.c (scoped_switch_fork_info)
1934         <~scoped_switch_fork_info>: Fix incorrect variable name.
1935
1936 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1937
1938         * linux-fork.c (scoped_switch_fork_info)
1939         <scoped_switch_fork_info>: Make explicit.
1940         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1941
1942 2019-01-10  Tom Tromey  <tom@tromey.com>
1943
1944         * objfiles.h (objfile::reset_psymtabs): Update.
1945         * objfiles.c (objfile::objfile): Update.
1946         * psymtab.h (psymtab_storage::obstack): Update.
1947         (psymtab_storage::m_obstack): Use gdb::optional.
1948         (class psymtab_storage): Update comment.  Remove objfile
1949         parameter.
1950         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1951
1952 2019-01-10  Tom Tromey  <tom@tromey.com>
1953
1954         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1955         <free_psymtabs>: Now private.
1956         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1957         (allocate_psymtab): Use new method.
1958
1959 2019-01-10  Tom Tromey  <tom@tromey.com>
1960
1961         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1962         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1963         * mdebugread.c (parse_partial_symbols): Use
1964         allocate_dependencies.
1965         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1966         allocate_dependencies.
1967         (process_psymtab_comp_unit_reader)
1968         (build_type_psymtab_dependencies): Likewise.
1969         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1970
1971 2019-01-10  Tom Tromey  <tom@tromey.com>
1972
1973         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1974         PSYMBOL_SET_LANGUAGE.
1975         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1976
1977 2019-01-10  Tom Tromey  <tom@tromey.com>
1978
1979         * psymtab.h (psymtab_storage::obstack): New method.
1980         <m_obstack>: Rename from obstack; now private.
1981         * psymtab.c (psymtab_storage): Update.
1982         * dwarf2read.c (create_addrmap_from_index)
1983         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1984         Update.
1985
1986 2019-01-10  Tom Tromey  <tom@tromey.com>
1987
1988         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1989         * objfiles.h (objfile::reset_psymtabs): New method.
1990
1991 2019-01-10  Tom Tromey  <tom@tromey.com>
1992
1993         * symmisc.c (print_symbol_bcache_statistics): Update.
1994         (print_objfile_statistics): Update.
1995         * symfile.c (reread_symbols): Update.
1996         * psymtab.h (class psymtab_storage): New.
1997         * psymtab.c (psymtab_storage): New constructor.
1998         (~psymtab_storage): New destructor.
1999         (require_partial_symbols): Update.
2000         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2001         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2002         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2003         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2004         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2005         (start_psymtab_common, end_psymtab_common)
2006         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2007         (allocate_psymtab): Update.
2008         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2009         Update.
2010         (dump_psymtab_addrmap, maintenance_print_psymbols)
2011         (maintenance_check_psymtabs): Update.
2012         (class objfile_psymtabs): Move to objfiles.h.
2013         * psympriv.h (discard_psymtab): Now inline.
2014         (psymtab_discarder::psymtab_discarder): Update.
2015         (psymtab_discarder::~psymtab_discarder): Update.
2016         (ALL_OBJFILE_PSYMTABS): Rewrite.
2017         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2018         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2019         Remove fields.
2020         <partial_symtabs>: New field.
2021         (class objfile_psymtabs): Move from psymtab.h.  Update.
2022         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2023         psymbol_cache.
2024         (objfile::~objfile): Don't destroy psymbol_cache.
2025         * mdebugread.c (parse_partial_symbols): Update.
2026         * dwarf2read.c (create_addrmap_from_index)
2027         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2028         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2029         (add_partial_subprogram, dwarf2_ranges_read): Update.
2030         * dwarf-index-write.c (write_address_map)
2031         (write_one_signatured_type, recursively_write_psymbols)
2032         (class debug_names, class debug_names, write_psymtabs_to_index):
2033         Update.
2034
2035 2019-01-10  Tom Tromey  <tom@tromey.com>
2036
2037         * symtab.h (SYMBOL_SET_NAMES): Update.
2038         (symbol_set_names): Update.
2039         (MSYMBOL_SET_NAMES): Update.
2040         * symtab.c (symbol_set_names): Change argument to be an
2041         objfile_per_bfd_storage.
2042         * psymtab.c (add_psymbol_to_bcache): Update.
2043         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2044
2045 2019-01-10  Tom Tromey  <tom@tromey.com>
2046
2047         * symtab.c (create_demangled_names_hash): Change argument to be an
2048         objfile_per_bfd_storage.
2049         (symbol_set_names): Update.
2050
2051 2019-01-10  Tom Tromey  <tom@tromey.com>
2052
2053         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2054         init_psymbol_list.
2055         * psymtab.c (init_psymbol_list): Do nothing if already called.
2056         * psympriv.h (init_psymbol_list): Add comment.
2057         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2058         init_psymbol_list.
2059         * dbxread.c (dbx_symfile_read): Unconditionally call
2060         init_psymbol_list.
2061
2062 2019-01-10  Tom Tromey  <tom@tromey.com>
2063
2064         * xcoffread.c (scan_xcoff_symtab): Update.
2065         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2066         "where".
2067         * mdebugread.c (parse_partial_symbols)
2068         (handle_psymbol_enumerators): Update.
2069         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2070         * dbxread.c (read_dbx_symtab): Update.
2071         * psympriv.h (psymbol_placement): New enum.
2072         (add_psymbol_to_list): Update.
2073
2074 2019-01-10  Tom Tromey  <tom@tromey.com>
2075
2076         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2077         static_psymbols parameters.
2078         (scan_xcoff_symtab): Update.
2079         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2080         static_psymbols parameters.
2081         * psympriv.h (start_psymtab_common): Update.
2082         * mdebugread.c (parse_partial_symbols): Update.
2083         * dwarf2read.c (create_partial_symtab): Update.
2084         * dbxread.c (read_dbx_symtab): Update.
2085         (start_psymtab): Remove global_psymbols and static_psymbols
2086         parameters.
2087
2088 2019-01-10  Tom Tromey  <tom@tromey.com>
2089
2090         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2091         * psymtab.c (allocate_psymtab): Add comment.
2092         * psympriv.h (allocate_psymtab): Add comment.
2093         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2094         initializations.
2095         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2096
2097 2019-01-10  Tom Tromey  <tom@tromey.com>
2098
2099         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2100         Don't declare.
2101         * mipsread.c: Include mdebugread.h.
2102         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2103         Declare.
2104         * elfread.c: Include mdebugread.h.
2105
2106 2019-01-09  Tom Tromey  <tom@tromey.com>
2107
2108         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2109         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2110         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2111         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2112         (psym_lookup_symbol, psym_find_last_source_symtab)
2113         (psym_forget_cached_source_info, psym_print_stats)
2114         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2115         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2116         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2117         (psym_find_compunit_symtab_by_address)
2118         (maintenance_print_psymbols, maintenance_info_psymtabs)
2119         (maintenance_check_psymtabs): Use ranged for.
2120         * psymtab.h (class objfile_psymtabs): New.
2121         (require_partial_symbols): Return objfile_psymtabs.
2122         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2123
2124 2019-01-09  Tom Tromey  <tom@tromey.com>
2125
2126         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2127         (find_pc_mapped_section, list_overlays_command)
2128         (map_overlay_command, unmap_overlay_command)
2129         (simple_overlay_update): Use all_objfiles.
2130         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2131         * printcmd.c (info_symbol_command): Use all_objfiles.
2132         * objfiles.h (ALL_OBJSECTIONS): Remove.
2133         * maint.c (maintenance_translate_address): Use all_objfiles.
2134         * gcore.c (gcore_create_callback): Use all_objfiles.
2135         (objfile_find_memory_regions): Likewise.
2136
2137 2019-01-09  Tom Tromey  <tom@tromey.com>
2138
2139         * symtab.c (find_line_symtab, info_sources_command)
2140         (make_source_files_completion_list): Use objfile_compunits.
2141         * source.c (select_source_symtab): Use objfile_compunits.
2142         * objfiles.h (struct objfile): Update comment.
2143         (ALL_OBJFILES): Remove.
2144         (ALL_FILETABS): Remove.
2145         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2146         objfile_compunits.
2147
2148 2019-01-09  Tom Tromey  <tom@tromey.com>
2149
2150         * symmisc.c (print_objfile_statistics, dump_objfile)
2151         (maintenance_print_symbols): Use compunit_filetabs.
2152         * source.c (forget_cached_source_info_for_objfile): Use
2153         compunit_filetabs.
2154         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2155         (ALL_FILETABS): Use compunit_filetabs.
2156         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2157         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2158
2159 2019-01-09  Tom Tromey  <tom@tromey.com>
2160
2161         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2162         (compunit_filetabs): New.
2163         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2164         compunit_filetabs.
2165         (info_sources_command, make_source_files_completion_list): Remove
2166         declaration.
2167         * symmisc.c (print_objfile_statistics, dump_objfile)
2168         (maintenance_print_symbols): Remove declaration.
2169         (maintenance_info_symtabs): Use compunit_filetabs.
2170         (maintenance_info_line_tables): Likewise.
2171         * source.c (select_source_symtab): Change local variable name.
2172         (forget_cached_source_info_for_objfile): Remove declaration.
2173         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2174         * objfiles.c (objfile_relocate1): Remove declaration.
2175         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2176         declaration.
2177         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2178         * coffread.c (coff_symtab_read): Remove declaration.
2179         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2180         compunit_filetabs.
2181
2182 2019-01-09  Tom Tromey  <tom@tromey.com>
2183
2184         * symtab.c (lookup_objfile_from_block)
2185         (find_pc_sect_compunit_symtab, search_symbols)
2186         (default_collect_symbol_completion_matches_break_on): Use
2187         objfile_compunits.
2188         * objfiles.h (ALL_COMPUNITS): Remove.
2189         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2190         * cp-support.c (add_symbol_overload_list_qualified): Use
2191         objfile_compunits.
2192         * ada-lang.c (ada_collect_symbol_completion_matches)
2193         (ada_add_global_exceptions): Use objfile_compunits.
2194
2195 2019-01-09  Tom Tromey  <tom@tromey.com>
2196
2197         * source.c (select_source_symtab)
2198         (forget_cached_source_info_for_objfile): Remove declaration.
2199         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2200         declaration.
2201         * maint.c (count_symtabs_and_blocks): Remove declaration.
2202         * cp-support.c (add_symbol_overload_list_qualified): Remove
2203         declaration.
2204         * coffread.c (coff_symtab_read): Remove declaration.
2205         * symtab.c (lookup_symbol_in_objfile_symtabs)
2206         (basic_lookup_transparent_type_1): Use objfile_compunits.
2207         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2208         (info_sources_command, search_symbols)
2209         (default_collect_symbol_completion_matches_break_on)
2210         (make_source_files_completion_list): Remove declaration.
2211         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2212         (ada_collect_symbol_completion_matches)
2213         (ada_add_global_exceptions): Remove declaration.
2214         * linespec.c (iterate_over_all_matching_symtabs): Use
2215         objfile_compunits.
2216         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2217         (class objfile_compunits): New.
2218         (ALL_COMPUNITS): Use objfile_compunits.
2219         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2220         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2221         objfile_compunits.
2222         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2223
2224 2019-01-09  Tom Tromey  <tom@tromey.com>
2225
2226         * symtab.c (search_symbols)
2227         (default_collect_symbol_completion_matches_break_on): Use
2228         objfile_msymbols.
2229         * ada-lang.c (ada_lookup_simple_minsym)
2230         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2231         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2232         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2233         objfile_msymbols.
2234         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2235         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2236         * objc-lang.c (find_methods): Use objfile_msymbols.
2237         (info_selectors_command, info_classes_command): Likewise.
2238         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2239         * objfiles.h (class objfile_msymbols): New.
2240         (ALL_OBJFILE_MSYMBOLS): Remove.
2241         (ALL_MSYMBOLS): Remove.
2242
2243 2019-01-09  Tom Tromey  <tom@tromey.com>
2244
2245         * common/next-iterator.h (next_adapter): Add Iterator template
2246         parameter.
2247         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2248         (class all_objfiles_safe): New.
2249         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2250         * objfiles.c (put_objfile_before): Update comment.
2251         (add_separate_debug_objfile): Likewise.
2252         (free_all_objfiles): Use all_objfiles_safe.
2253         (objfile_purge_solibs): Likewise.
2254
2255 2019-01-09  Tom Tromey  <tom@tromey.com>
2256
2257         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2258         (expand_symtab_containing_pc, lookup_static_symbol)
2259         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2260         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2261         all_objfiles.
2262         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2263         * breakpoint.c (create_overlay_event_breakpoint)
2264         (create_longjmp_master_breakpoint)
2265         (create_std_terminate_master_breakpoint)
2266         (create_exception_master_breakpoint): Use all_objfiles.
2267         * linux-thread-db.c (try_thread_db_load_from_pdir)
2268         (has_libpthread): Use all_objfiles.
2269         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2270         * linespec.c (iterate_over_all_matching_symtabs)
2271         (search_minsyms_for_name): Use all_objfiles.
2272         * maint.c (maintenance_info_sections): Use all_objfiles.
2273         * main.c (captured_main_1): Use all_objfiles.
2274         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2275         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2276         * guile/scm-pretty-print.c
2277         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2278         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2279         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2280         (maintenance_print_msymbols): Use all_objfiles.
2281         * source.c (select_source_symtab): Use all_objfiles.
2282         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2283         * symfile.c (remove_symbol_file_command)
2284         (expand_symtabs_matching, map_symbol_filenames): Use
2285         all_objfiles.
2286         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2287         all_objfiles.
2288         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2289         * objc-lang.c (find_methods): Use all_objfiles.
2290         * objfiles.c (have_partial_symbols, have_full_symbols)
2291         (have_minimal_symbols, qsort_cmp)
2292         (default_iterate_over_objfiles_in_search_order): Use
2293         all_objfiles.
2294         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2295         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2296         (maintenance_check_psymtabs): Use all_objfiles.
2297         (ALL_PSYMTABS): Remove.
2298         * compile/compile-object-run.c (do_module_cleanup): Use
2299         all_objfiles.
2300         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2301         * cp-support.c (add_symbol_overload_list_qualified): Use
2302         all_objfiles.
2303         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2304         Use all_objfiles.
2305         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2306         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2307         all_objfiles.
2308         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2309         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2310         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2311         Uses all_objfiles.
2312         * solib.c (solib_read_symbols): Use all_objfiles
2313
2314 2019-01-09  Tom Tromey  <tom@tromey.com>
2315
2316         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2317         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2318         all_objfiles.
2319         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2320         * symmisc.c (print_symbol_bcache_statistics)
2321         (print_objfile_statistics, maintenance_print_objfiles)
2322         (maintenance_info_symtabs, maintenance_check_symtabs)
2323         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2324         all_objfiles.
2325         * source.c (forget_cached_source_info): Use all_objfiles.
2326         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2327         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2328         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2329         * objfiles.c (update_section_map): Use all_objfiles.
2330         (shared_objfile_contains_address_p): Likewise.
2331         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2332         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2333
2334 2019-01-09  Tom Tromey  <tom@tromey.com>
2335
2336         * common/next-iterator.h: New file.
2337         * objfiles.h (class all_objfiles): New.
2338         (struct objfile_iterator): New.
2339
2340 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2341
2342         * NEWS: Move the description of the changed "frame", "select-frame",
2343          and "info frame" commands to the Changed commands section.
2344
2345 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2346
2347         * gdbtypes.c (check_stub_method_group): Remove handling of old
2348         mangling schemes.
2349         * linespec.c (find_methods): Likewise.
2350         * stabsread.c (read_member_functions): Likewise.
2351         * valops.c (search_struct_method): Likewise.
2352         (value_struct_elt_for_reference): Likewise.
2353         * NEWS: Mention this change.
2354
2355 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2356
2357         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2358         print_source_lines.
2359         * source.c (print_source_lines_base): Update line number check.
2360         (print_source_lines): New function.
2361         (source_lines_range::source_lines_range): New function.
2362         * source.h (class source_lines_range): New class.
2363         (print_source_lines): New declaration.
2364
2365 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2366
2367         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2368
2369 2019-01-08  Tom Tromey  <tom@tromey.com>
2370             Simon Marchi  <simon.marchi@ericsson.com>
2371
2372         PR gdb/24060
2373         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2374         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2375         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2376         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2377         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2378         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2379
2380 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2381
2382         * source.c (select_source_symtab): Move header comment to
2383         declaration in source.h.
2384         (forget_cached_source_info_for_objfile): Likewise.
2385         (forget_cached_source_info): Likewise.
2386         (identify_source_line): Likewise.
2387         * source.h (identify_source_line): Move declaration from symtab.h
2388         and add comment from source.c
2389         (print_source_lines): Likewise.
2390         (forget_cached_source_info_for_objfile): Likewise.
2391         (forget_cached_source_info): Likewise.
2392         (select_source_symtab): Likewise.
2393         (enum print_source_lines_flag): Move definition from symtab.h.
2394         * symtab.h (identify_source_line): Move declaration to source.h.
2395         (print_source_lines): Likewise.
2396         (forget_cached_source_info_for_objfile): Likewise.
2397         (forget_cached_source_info): Likewise.
2398         (select_source_symtab): Likewise.
2399         (enum print_source_lines_flag): Move definition to source.h.
2400         * tui/tui-hooks.c: Add 'source.h' include.
2401
2402 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * source.c (print_source_lines_base): Handle requests to print
2405         reverse line number sequences, and guard against empty lines
2406         string.
2407
2408 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2409
2410         * source.c (print_source_lines_base): Fix skip of '\r' if next
2411         character is '\n'.
2412
2413 2019-01-06  Tom Tromey  <tom@tromey.com>
2414
2415         * c-exp.y (struct c_parse_state) <macro_original_text,
2416         expansion_obstack>: New member.
2417         (macro_original_text, expansion_obstack): Remove globals.
2418         (scan_macro_expansion, scanning_macro_expansion)
2419         (finished_macro_expansion): Update.
2420         (scan_macro_cleanup): Remove.
2421         (yylex, c_parse): Update.
2422
2423 2019-01-06  Tom Tromey  <tom@tromey.com>
2424
2425         * c-exp.y (struct c_parse_state) <strings>: New member.
2426         (operator_stoken): Update.
2427
2428 2019-01-06  Tom Tromey  <tom@tromey.com>
2429
2430         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2431         (union type_stack_elt) <typelist_val>: Now a pointer to
2432         std::vector.
2433         (type_stack_cleanup): Don't declare.
2434         (push_typelist): Update.
2435         * parse.c (pop_typelist): Return a std::vector.
2436         (push_typelist): Take a std::vector.
2437         (follow_types): Update.  Do not free args.
2438         (type_stack_cleanup): Remove.
2439         * c-exp.y (struct c_parse_state): New.
2440         (cpstate): New global.
2441         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2442         (nonempty_typelist): Update.
2443         (func_mod): Create a new vector.
2444         (c_parse): Create a c_parse_state.
2445         (check_parameter_typelist): Do not delete params.
2446         (function_method): Update.  Do not delete type_list.
2447
2448 2019-01-06  Tom Tromey  <tom@tromey.com>
2449
2450         PR gdb/28155:
2451         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2452         check_typedef.
2453         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2454         (print_return_value): Likewise.
2455
2456 2019-01-05  Tom Tromey  <tom@tromey.com>
2457
2458         * contrib/cleanup_check.py: Remove.
2459         * contrib/gcc-with-excheck: Remove.
2460         * contrib/exsummary.py: Remove.
2461         * contrib/excheck.py: Remove.
2462
2463 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2464
2465         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2466         NULL. Initialize tpprev to NULL instead of assigning it
2467         to NULL on the next statement.
2468         * windows-nat.c (windows_delete_thread): Remove check for
2469         main_thread_id before printing thread exit notifications.
2470         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2471         Remove thread ID check against main_thread_id.
2472         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2473         windows_delete_thread.
2474         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2475
2476 2019-01-04  Tom Tromey  <tom@tromey.com>
2477
2478         * compile/compile.c (_initialize_compile): Use upper case for
2479         metasyntactic variables.
2480         * symmisc.c (_initialize_symmisc): Use upper case for
2481         metasyntactic variables.
2482         * psymtab.c (_initialize_psymtab): Use upper case for
2483         metasyntactic variables.
2484         * demangle.c (demangle_command): Use upper case for metasyntactic
2485         variables.
2486         (_initialize_demangler): Likewise.
2487         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2488         variables.
2489
2490 2019-01-03  Tom Tromey  <tom@tromey.com>
2491
2492         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2493
2494 2019-01-03  Tom Tromey  <tom@tromey.com>
2495
2496         * python/py-symtab.c (salpy_str): Update.
2497         (struct salpy_sal_object) <symtab>: Now a PyObject.
2498         (salpy_dealloc): Update.
2499         (del_objfile_sal): Use gdbpy_ref.
2500
2501 2019-01-03  Tom Tromey  <tom@tromey.com>
2502
2503         * python/py-type.c (convert_field): Use new_reference.  Return
2504         gdbpy_ref.
2505         (make_fielditem): Return gdbpy_ref.
2506         (typy_fields): Update.
2507         (typy_getitem): Update.
2508         (field_name): Return gdbpy_ref.  Use new_reference.
2509         (typy_iterator_iternext): Update.
2510
2511 2019-01-03  Tom Tromey  <tom@tromey.com>
2512
2513         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2514
2515 2019-01-03  Tom Tromey  <tom@tromey.com>
2516
2517         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2518         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2519         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2520         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2521         (pspy_set_type_printers): Likewise.
2522         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2523         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2524         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2525         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2526         (objfpy_set_type_printers): Likewise.
2527
2528 2019-01-03  Tom Tromey  <tom@tromey.com>
2529
2530         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2531         (gdbpy_print_stack): Use gdbpy_err_fetch.
2532         * python/python-internal.h (class gdbpy_err_fetch): New class.
2533         (class gdbpy_enter) <m_error_type, m_error_value,
2534         m_error_traceback>: Remove.
2535         <m_error>: New member.
2536         (gdbpy_exception_to_string): Don't declare.
2537         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2538         * python/py-value.c (convert_value_from_python): Use
2539         gdbpy_err_fetch.
2540         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2541         gdbpy_exception_to_string.
2542         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2543         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2544         gdbpy_err_fetch.
2545
2546 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2547
2548         * linux-nat.c (delete_lwp_cleanup): Delete.
2549         (struct lwp_deleter): New struct.
2550         (lwp_info_up): New typedef.
2551         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2552         lwp_info_up.
2553
2554 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2555
2556         * linux-fork.c (class scoped_switch_fork_info): New class.
2557         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2558
2559 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2560
2561         * valops.c (find_overload_match): Remove use of null_cleanup, and
2562         calls to do_cleanups.
2563
2564 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * compile/compile-cplus-types.c
2567         (compile_cplus_instance::decl_name): Handle changes to
2568         cp_func_name.
2569         * cp-support.c (cp_func_name): Update header comment, update
2570         return type.
2571         * cp-support.h (cp_func_name): Update return type in declaration.
2572         * valops.c (find_overload_match): Move temp_func local to top
2573         level of function and change its type.  Use temp_func to hold and
2574         delete temporary string obtained from cp_func_name.
2575
2576 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2577
2578         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2579         gdb::char_vector, remove cleanup, and update uses of `msg`.
2580
2581 2019-01-03  Jim Wilson  <jimw@sifive.com>
2582
2583         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2584
2585 2019-01-02  Tom Tromey  <tom@tromey.com>
2586
2587         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2588         (tdesc_parse_xml): Remove cleanups.
2589         * target-descriptions.h (make_cleanup_free_target_description):
2590         Don't declare.
2591         (target_desc_deleter): New struct.
2592         (target_desc_up): New typedef.
2593         * target-descriptions.c (target_desc_deleter::operator()): Rename
2594         from free_target_description.
2595         (make_cleanup_free_target_description): Remove.
2596
2597 2019-01-02  Tom Tromey  <tom@tromey.com>
2598
2599         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2600         constructor, destructor.
2601         (linespec_parser): Remove typedef.
2602         (~linespec_parser): Rename from linespec_parser_delete.
2603         (linespec_lex_to_end, linespec_complete_label)
2604         (linespec_complete): Update.
2605         (decode_line_full): Remove cleanups.
2606         (decode_line_1): Update.
2607
2608 2019-01-02  Tom Tromey  <tom@tromey.com>
2609
2610         * python/python-internal.h (inferior_to_inferior_object): Change
2611         return type.
2612         * python/py-exitedevent.c (create_exited_event_object): Update.
2613         * python/py-inferior.c (inferior_to_inferior_object): Return
2614         gdbpy_ref.
2615         (python_new_inferior, python_inferior_deleted)
2616         (thread_to_thread_object, delete_thread_object)
2617         (build_inferior_list, gdbpy_selected_inferior): Update.
2618         * python/py-infthread.c (create_thread_object): Update.  Also fail
2619         if inferior_to_inferior_object fails.
2620
2621 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2622
2623         * inferior.h (class inferior) <displaced_step_state>: New field.
2624         * infrun.h (struct displaced_step_state): Move here from
2625         infrun.c.  Initialize fields, add constructor.
2626         <inf>: Remove field.
2627         <reset>: New method.
2628         * infrun.c (struct displaced_step_inferior_state): Move to
2629         infrun.h.
2630         (displaced_step_inferior_states): Remove.
2631         (get_displaced_stepping_state): Adust.
2632         (displaced_step_in_progress_any_inferior): Adjust.
2633         (displaced_step_in_progress_thread): Adjust.
2634         (displaced_step_in_progress): Adjust.
2635         (add_displaced_stepping_state): Remove.
2636         (get_displaced_step_closure_by_addr): Adjust.
2637         (remove_displaced_stepping_state): Remove.
2638         (infrun_inferior_exit): Call displaced_step_state.reset.
2639         (use_displaced_stepping): Don't check for NULL.
2640         (displaced_step_prepare_throw): Call
2641         get_displaced_stepping_state.
2642         (displaced_step_fixup): Don't check for NULL.
2643         (prepare_for_detach): Don't check for NULL.
2644
2645 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2646
2647         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2648          in case of call that did not complete.
2649
2650 2019-01-02  Andrey Utkin  <autkin@undo.io>
2651
2652         * symfile.c (find_separate_debug_file): Fix search of debug files for
2653         remote debuggee.
2654
2655 2019-01-02  Tom Tromey  <tom@tromey.com>
2656
2657         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2658         indentation.
2659         * python/py-frame.c (frapy_older): Remove cast.
2660         (frapy_newer): Likewise.
2661         * python/py-breakpoint.c (local_setattro): Remove cast.
2662         * python/py-arch.c (archpy_name): Remove local variable.
2663         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2664
2665 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2666
2667         * unittests/basic_string_view/element_access/char/empty.cc:
2668         Fix year range in copyright header.
2669
2670 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2671
2672         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2673         Delete.
2674         <operator==>: Update with for removed field.
2675         <hash>: Likewise.
2676         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2677         <isa_features>: ...this.
2678         <abi_features>: New field.
2679         (riscv_isa_flen): Update comment.
2680         (riscv_abi_xlen): New declaration.
2681         (riscv_abi_flen): New declaration.
2682         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2683         isa_features.
2684         (riscv_abi_xlen): New function.
2685         (riscv_isa_flen): Update to get answer from isa_features.
2686         (riscv_abi_flen): New function.
2687         (riscv_has_fp_abi): Update to get answer from abi_features.
2688         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2689         xlen and flen.
2690         (riscv_call_info) <xlen, flen>: Update comment.
2691         (riscv_call_arg_struct): Remove invalid assertions
2692         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2693         is removed.
2694         (riscv_gdbarch_init): Gather isa features and abi features
2695         separately, ensure both match on the gdbarch when reusing an old
2696         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2697         a target with 64-bit float hardware.
2698
2699 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2700
2701         * source.c (search_command_helper): Stop reverse search
2702         when line 1 has been searched.
2703
2704 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2705
2706         * record-full.c (record_full_base_target::close): Rewrite
2707         record_full_core_buf_list free logic.
2708
2709 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2710
2711         * break-catch-syscall.c (print_one_catch_syscall): xfree
2712         the last text.
2713
2714 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2715
2716         * top.c (print_gdb_version): Update Copyright year in version
2717         message.
2718
2719 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2720
2721         Update copyright year range in all GDB files.
2722
2723 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2724
2725         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2726
2727 For older changes see ChangeLog-2018.
2728 \f
2729 Local Variables:
2730 mode: change-log
2731 left-margin: 8
2732 fill-column: 74
2733 version-control: never
2734 coding: utf-8
2735 End:
2736