gdb/ChangeLog

   1 2019-07-15  Tom Tromey  <tromey@adacore.com>
   2
   3         * target.c (flash_erase_command): Use field_core_addr.
   4         * symfile.c (generic_load): Use field_core_addr.
   5         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
   6         Use field_core_addr.
   7         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
   8         field_core_addr.
   9
  10 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  11
  12         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
  13         value if its desired type is smaller than a CORE_ADDR and signed.
  14
  15 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  16
  17         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
  18         of changes to field names, and use new is_reference field to
  19         decide if a property is a reference or not.
  20         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
  21         field.
  22         (struct dwarf2_property_baton): Update header comment, rename
  23         'referenced_type' to 'property_type' and update comments.
  24         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
  25         default property type, store in property baton, update to take
  26         accound of renamed field.
  27         (read_func_scope): Update call to attr_to_dynamic_prop.
  28         (read_array_type): Likewise.
  29         (dwarf2_per_cu_addr_sized_int_type): New function.
  30         (read_subrange_index_type): Move type finding code to
  31         dwarf2_per_cu_addr_sized_int_type.
  32         (read_subrange_type): Update calls to attr_to_dynamic_prop.
  33         (dwarf2_per_cu_addr_type): New function.
  34         (set_die_type): Update calls to attr_to_dynamic_prop.
  35
  36 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  37
  38         * dwarf2read.c (read_subrange_index_type): New function.
  39         (read_subrange_type): Move code into new function and call it.
  40         * gdbtypes.c (create_range_type): Add some asserts.
  41
  42 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  43
  44         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
  45         update return statements.
  46         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
  47         declaration, and update comment to match.
  48         * gdbtypes.c (resolve_dynamic_array): Update call to
  49         dwarf2_evaluate_property to match new return type.
  50
  51 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  52
  53         * valarith.c (value_subscripted_rvalue): Change lowerbound
  54         parameter type from int to LONGEST.
  55         * value.h (value_subscripted_rvalue): Likewise in declaration.
  56
  57 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  58
  59         * cli/cli-utils.c (info_print_command_completer): New function.
  60         * cli/cli-utils.h: Add 'completer.h' include, and forward
  61         declaration for 'struct cmd_list_element'.
  62         (info_print_command_completer): Declare.
  63         * stack.c (_initialize_stack): Add completer for 'info locals' and
  64         'info args'.
  65         * symtab.c (_initialize_symtab): Add completer for 'info
  66         variables' and 'info functions'.
  67         * NEWS: Mention completion for additional info commands.
  68
  69 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  70
  71         * cli/cli-utils.c (extract_info_print_args): Delete.
  72         (extract_arg_maybe_quoted): Delete.
  73         (info_print_options_defs): New variable.
  74         (make_info_print_options_def_group): New function.
  75         (extract_info_print_options): Define new function.
  76         * cli/cli-utils.h (extract_info_print_args): Delete.
  77         (struct info_print_options): New structure.
  78         (extract_info_print_options): Declare new function.
  79         * stack.c (info_locals_command): Update to use new
  80         extract_info_print_options, also add a header comment.
  81         (info_args_command): Likewise.
  82         * symtab.c (info_variables_command): Likewise.
  83         (info_functions_command): Likewise.
  84
  85 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  86
  87         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
  88         to extract string arguments.
  89         * common/common-utils.c (extract_string_maybe_quoted): New function.
  90         * common/common-utils.h (extract_string_maybe_quoted): Declare.
  91
  92 2019-07-11  Tom Tromey  <tromey@adacore.com>
  93
  94         * main.c (get_init_files): Use GDBINIT, not gdbinit.
  95         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
  96         * top.h (gdbinit): Don't declare.
  97         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
  98         into...
  99         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 100         * top.c (gdb_init): Don't call init_cli_cmds.
 101         (gdbinit): Remove.
 102         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 103
 104 2019-07-11  Tom Tromey  <tromey@adacore.com>
 105
 106         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 107         after it has been moved.
 108
 109 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 110
 111         * valops.c (value_must_coerce_to_target): Change return type to
 112         bool.
 113         * value.h (value_must_coerce_to_target): Likewise.
 114
 115 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 116
 117         * breakpoint.c (is_hardware_watchpoint): Remove
 118         forward-declaration.
 119         (is_masked_watchpoint): Change return type to bool.
 120         (is_tracepoint): Likewise.
 121         (is_breakpoint): Likewise.
 122         (is_hardware_watchpoint): Likewise.
 123         (is_watchpoint): Likewise.
 124         (is_no_memory_software_watchpoint): Likewise.
 125         (is_catchpoint): Likewise.
 126         (breakpoint_1): Make FILTER parameter's return type bool.
 127         is_masked_watchpoint): Change return type to bool.
 128         (save_breakpoints): Make FILTER parameter's return type bool.
 129         * breakpoint.h (is_breakpoint): Change return type to bool.
 130         (is_watchpoint): Likewise.
 131         (is_catchpoint): Likewise.
 132         (is_tracepoint): Likewise.
 133
 134 2019-07-10  Tom Tromey  <tom@tromey.com>
 135
 136         * defs.h: Don't include gdbarch.h.
 137         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 138         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 139         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 140         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 141         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 142         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 143         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 144         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 145         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 146         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 147         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 148         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 149         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 150         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 151         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 152         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 153         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 154         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 155         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 156         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 157         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 158         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 159         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 160         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 161         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 162         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 163         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 164
 165 2019-07-10  Tom Tromey  <tromey@adacore.com>
 166
 167         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 168         * breakpoint.c (init_ada_exception_breakpoint): Register as
 169         bp_catchpoint.
 170         (print_one_breakpoint_location, print_one_breakpoint): Use
 171         is_ada_exception_catchpoint.
 172         * ada-lang.c (class ada_catchpoint_location): Pass
 173         bp_loc_software_breakpoint to bp_location constructor.
 174         (is_ada_exception_catchpoint): New function.
 175
 176 2019-07-10  Tom Tromey  <tromey@adacore.com>
 177
 178         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 179         VEC.
 180         (struct arm_exidx_entry): New method operator<.
 181         (struct arm_exidx_data) <section_maps>: Change type.
 182         (arm_exidx_data_free): Remove.
 183         (arm_exidx_data_key): Change type.  Move lower.
 184         (arm_exidx_new_objfile): Update.
 185         (arm_compare_exidx_entries): Remove.
 186         (arm_find_exidx_entry, _initialize_arm_tdep)
 187
 188 2019-07-10  Tom Tromey  <tromey@adacore.com>
 189
 190         * solib-spu.c (ocl_program_data_key): Change type.
 191         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 192         Update.
 193
 194 2019-07-10  Tom Tromey  <tromey@adacore.com>
 195
 196         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 197         (struct solib_aix_inferior_data) <library_list>: Change type.
 198         (solib_aix_inferior_data_handle): Change type.
 199         (get_solib_aix_inferior_data): Update.
 200         (solib_aix_free_library_list): Remove.
 201         (library_list_start_library): Update.
 202         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 203         return type.
 204         (solib_aix_get_library_list)
 205         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 206         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 207
 208 2019-07-10  Tom Tromey  <tromey@adacore.com>
 209
 210         * solib-dsbt.c (struct dsbt_info): Add initializers.
 211         (solib_dsbt_pspace_data): Change type.
 212         (dsbt_pspace_data_cleanup): Remove.
 213         (get_dsbt_info, _initialize_dsbt_solib): Update.
 214
 215 2019-07-10  Tom Tromey  <tromey@adacore.com>
 216
 217         * spu-tdep.c (spu_overlay_data): Change type.
 218         (spu_get_overlay_table, spu_overlay_new_objfile)
 219         (_initialize_spu_tdep): Update.
 220
 221 2019-07-10  Tom Tromey  <tromey@adacore.com>
 222
 223         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 224         destructor.
 225         (dbx_objfile_data_key): Change type and declare later.
 226         (DBX_SYMFILE_INFO): Rewrite.
 227         * dbxread.c (dbx_objfile_data_key): Change type.
 228         (dbx_symfile_init): Update.
 229         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 230         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 231         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 232
 233 2019-07-10  Tom Tromey  <tromey@adacore.com>
 234
 235         * jit.c (jit_program_space_key): Change type.  Move lower.
 236         (get_jit_program_space_data): Update.
 237         (jit_program_space_data_cleanup): Remove.
 238         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 239         Update.
 240         (struct jit_program_space_data): Add initializers.
 241
 242 2019-07-10  Tom Tromey  <tromey@adacore.com>
 243
 244         * solib-darwin.c (struct darwin_info): Add initializers.
 245         (solib_darwin_pspace_data): Change type.
 246         (darwin_pspace_data_cleanup): Remove.
 247         (get_darwin_info, _initialize_darwin_solib): Update.
 248
 249 2019-07-10  Tom Tromey  <tromey@adacore.com>
 250
 251         * remote-sim.c (struct sim_inferior_data): Add initializers,
 252         constructor, and destructor.
 253         (sim_inferior_data_key): Change type.  Move lower.
 254         (check_for_duplicate_sim_descriptor): Update.
 255         (get_sim_inferior_data): Use new.  Update.
 256         (~sim_inferior_data_cleanup): Rename from
 257         sim_inferior_data_cleanup.  Simplify.
 258         (gdbsim_close_inferior, simulator_command)
 259         (sim_command_completer, _initialize_remote_sim): Update.
 260         (next_pid, INITIAL_PID): Move earlier.
 261
 262 2019-07-10  Tom Tromey  <tromey@adacore.com>
 263
 264         * python/python-internal.h (create_thread_object): Return
 265         gdbpy_ref.
 266         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 267         * python/py-inferior.c (struct threadlist_entry): Add
 268         constructor.
 269         <thread_obj>: Now a gdbpy_ref.
 270         (thread_to_thread_object): Update.
 271         (add_thread_object): Use new.
 272         (delete_thread_object): Use delete.
 273         (infpy_threads): Update.
 274         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 275         GIL.
 276
 277 2019-07-10  Tom Tromey  <tromey@adacore.com>
 278
 279         * valops.c (value_cast): Specialize error message for Ada.
 280
 281 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 282
 283         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 284
 285 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 286
 287         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 288         bpstat_should_step): Return bool, adjust comments.
 289         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 290         bpstat_should_step): Likewise.
 291
 292 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 293
 294         * features/Makefile: Use feature target descriptions for Arm.
 295         * features/arm/arm-core.c: Generate new file.
 296         * features/arm/arm-fpa.c: Likewise.
 297         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 298         * features/arm/arm-m-profile.c: Likewise.
 299         * features/arm/arm-vfpv2.c: Likewise.
 300         * features/arm/arm-vfpv3.c: Likewise.
 301         * features/arm/xscale-iwmmxt.c: Likewise.
 302         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 303
 304 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 305
 306         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 307         ptrace earlier.
 308
 309 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 310
 311         * features/aarch64-pauth.c: Regenerate.
 312
 313 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 314
 315         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 316         bool.
 317         (bpstat_what): Use false instead of 0.
 318
 319 2019-07-09  Pedro Alves  <palves@redhat.com>
 320
 321         * break-catch-throw.c (is_exception_catchpoint): New.
 322         * breakpoint.c (print_one_breakpoint_location): New parameter
 323         'raw_loc'.  Handle it.  Use
 324         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 325         looking at the breakpoint's type.
 326         (print_one_breakpoint): If handling "maint info breakpoints", also
 327         print locations of exception catchpoints.
 328         * breakpoint.h (is_exception_catchpoint): Declare.
 329
 330 2019-07-09  Pedro Alves  <palves@redhat.com>
 331
 332         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 333         "addr" field.
 334         (allocate_location_exception_catchpoint): New.
 335         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 336         (initialize_throw_catchpoint_ops): Install
 337         allocate_location_exception_catchpoint as allocate_location
 338         method.
 339         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 340         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 341         bp_loc_other.
 342         (breakpoint_address_is_meaningful): Delete.
 343         (bl_address_is_meaningful): New.
 344         (breakpoint_locations_match): Adjust comment.
 345         (bp_location_from_bp_type): New, factored out of...
 346         (bp_location::bp_location(breakpoint *)): ... this.
 347         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 348         factored out of...
 349         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 350         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 351         breakpoint_address_is_meaningful.
 352         (bp_locations_compare): Adjust comment.
 353         (update_global_location_list): Use bl_address_is_meaningful
 354         instead of breakpoint_address_is_meaningful.
 355         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 356         explicit.
 357         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 358         * python/py-breakpoint.c (bppy_get_location): No longer check
 359         whether location is null.
 360
 361 2019-07-09  Pedro Alves  <palves@redhat.com>
 362
 363         PR c++/15468
 364         * breakpoint.c (print_one_breakpoint_location): Remove
 365         single-location assert.
 366
 367 2019-07-09  Tom Tromey  <tom@tromey.com>
 368
 369         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 370         * configure: Rebuild.
 371         * configure.ac: Change common to gdbsupport.
 372         * gdbsupport: Rename from common.
 373         * acinclude.m4: Change common to gdbsupport.
 374         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 375         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 376         gdbsupport.
 377         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 378         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 379         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 380         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 381         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 382         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 383         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 384         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 385         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 386         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 387         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 388         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 389         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 390         coff-pe-read.c, command.h, compile/compile-c-support.c,
 391         compile/compile-c.h, compile/compile-cplus-symbols.c,
 392         compile/compile-cplus-types.c, compile/compile-cplus.h,
 393         compile/compile-loc2c.c, compile/compile.c, completer.c,
 394         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 395         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 396         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 397         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 398         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 399         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 400         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 401         features/aarch64-core.c, features/aarch64-fpu.c,
 402         features/aarch64-pauth.c, features/aarch64-sve.c,
 403         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 404         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 405         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 406         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 407         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 408         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 409         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 410         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 411         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 412         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 413         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 414         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 415         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 416         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 417         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 418         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 419         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 420         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 421         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 422         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 423         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 424         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 425         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 426         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 427         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 428         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 429         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 430         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 431         minsyms.c, mips-linux-tdep.c, namespace.h,
 432         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 433         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 434         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 435         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 436         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 437         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 438         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 439         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 440         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 441         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 442         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 443         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 444         procfs.c, producer.c, progspace.h, psymtab.h,
 445         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 446         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 447         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 448         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 449         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 450         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 451         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 452         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 453         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 454         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 455         target-memory.c, target.c, target.h, target/waitstatus.c,
 456         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 457         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 458         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 459         unittests/array-view-selftests.c,
 460         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 461         unittests/common-utils-selftests.c,
 462         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 463         unittests/format_pieces-selftests.c,
 464         unittests/function-view-selftests.c,
 465         unittests/lookup_name_info-selftests.c,
 466         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 467         unittests/mkdir-recursive-selftests.c,
 468         unittests/observable-selftests.c,
 469         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 470         unittests/parse-connection-spec-selftests.c,
 471         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 472         unittests/scoped_fd-selftests.c,
 473         unittests/scoped_mmap-selftests.c,
 474         unittests/scoped_restore-selftests.c,
 475         unittests/string_view-selftests.c, unittests/style-selftests.c,
 476         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 477         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 478         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 479         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 480         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 481         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 482
 483 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 484
 485         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 486         bool value.
 487         (decode_digits_ordinary): Set explicit_line field in sal.
 488         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 489         symtab_and_line that was set on an explicit line number in
 490         assembler code.  Do always update the recorded symtab and line if
 491         we do skip the prologue.
 492
 493 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * breakpoint.c (set_breakpoint_location_function): Remove
 496         explicit_loc parameter.
 497         (momentary_breakpoint_from_master): Update call to
 498         set_breakpoint_location_function.
 499         (add_location_to_breakpoint): Likewise.
 500
 501 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 502
 503         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 504         required features based on default bfd type when no specific bfd
 505         is present.
 506
 507 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 508
 509         * NEWS: Mention that GDB printf and eval commands can now print
 510         C-style and Ada-style convenience var strings without
 511         calling the inferior.
 512         * printcmd.c (printf_c_string): Locally print GDB internal var
 513         instead of transiting via the inferior.
 514         (printf_wide_c_string): Likewise.
 515
 516 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 517
 518         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 519
 520 2019-07-04  Tom Tromey  <tom@tromey.com>
 521
 522         PR tui/24724:
 523         * tui/tui-winsource.c (tui_clear_source_content): Update.
 524         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 525         (tui_update_breakpoint_info): Update.
 526         (tui_set_exec_info_content): Update.
 527         * tui/tui-source.c (tui_set_source_content_nil): Update.
 528         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 529         has_break.
 530         * tui/tui-data.h (enum tui_bp_flag): New.
 531         (tui_bp_flags): New enum flags type.
 532         (struct tui_source_element) <break_mode>: Change type.  Rename
 533         from has_break.
 534         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 535         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 536         constants.
 537         * tui/tui-winsource.h: Fix comment.
 538
 539 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 540
 541         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 542         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 543         (store_fpregs_to_thread)
 544         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 545         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 546         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 547         (IWMMXT_REGS_SIZE): Add define.
 548         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 549         (fetch_vfp_regs, store_vfp_regs)
 550         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 551         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 552
 553 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 554
 555         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 556         defines.
 557         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 558         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 559         (ARM_INT_REGISTER_SIZE): ...to this.
 560         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 561         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 562         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 563         (arm_linux_collect_gregset, supply_nwfpe_register)
 564         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 565         defines.
 566         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 567         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 568         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 569         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 570         (arm_return_in_memory, arm_store_return_value)
 571         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 572         (arm_record_ld_st_multiple): Likewise.
 573         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 574         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 575
 576 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 577
 578         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 579         AARCH64_DISPLACED_MODIFIED_INSNS.
 580         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 581         (aarch64_displaced_step_copy_insn): Likewise.
 582         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 583         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 584         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 585         ARM_DISPLACED_MODIFIED_INSNS.
 586         * arm-tdep.c (arm_gdbarch_init): Likewise.
 587         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 588         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 589         (struct arm_displaced_step_closure): Use
 590         ARM_DISPLACED_MODIFIED_INSNS.
 591
 592 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 593
 594         * features/Makefile: Remove unused xml files.
 595         * features/aarch64.xml: Remove.
 596         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 597         * features/i386/amd64-avx-avx512.xml: Remove.
 598         * features/i386/amd64-avx-linux.xml: Remove.
 599         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 600         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 601         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 602         * features/i386/amd64-avx-mpx.xml: Remove.
 603         * features/i386/amd64-avx.xml: Remove.
 604         * features/i386/amd64-linux.xml: Remove.
 605         * features/i386/amd64-mpx-linux.xml: Remove.
 606         * features/i386/amd64-mpx.xml: Remove.
 607         * features/i386/amd64.xml: Remove.
 608         * features/i386/i386-avx-avx512-linux.xml: Remove.
 609         * features/i386/i386-avx-avx512.xml: Remove.
 610         * features/i386/i386-avx-linux.xml: Remove.
 611         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 612         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 613         * features/i386/i386-avx-mpx-linux.xml: Remove.
 614         * features/i386/i386-avx-mpx.xml: Remove.
 615         * features/i386/i386-avx.xml: Remove.
 616         * features/i386/i386-linux.xml: Remove.
 617         * features/i386/i386-mmx-linux.xml: Remove.
 618         * features/i386/i386-mmx.xml: Remove.
 619         * features/i386/i386-mpx-linux.xml: Remove.
 620         * features/i386/i386-mpx.xml: Remove.
 621         * features/i386/i386.xml: Remove.
 622         * features/i386/x32-avx-avx512-linux.xml: Remove.
 623         * features/i386/x32-avx-linux.xml: Remove.
 624         * features/i386/x32-linux.xml: Remove.
 625
 626 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 627
 628         * regformats/aarch64.dat: Remove.
 629         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 630         * regformats/i386/amd64-avx-linux.dat: Remove.
 631         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 632         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 633         * regformats/i386/amd64-linux.dat: Remove.
 634         * regformats/i386/amd64-mpx-linux.dat: Remove.
 635         * regformats/i386/amd64.dat: Remove.
 636         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 637         * regformats/i386/i386-avx-linux.dat: Remove.
 638         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 639         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 640         * regformats/i386/i386-linux.dat: Remove.
 641         * regformats/i386/i386-mmx-linux.dat: Remove.
 642         * regformats/i386/i386-mpx-linux.dat: Remove.
 643         * regformats/i386/i386.dat: Remove.
 644         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 645         * regformats/i386/x32-avx-linux.dat: Remove.
 646         * regformats/i386/x32-linux.dat: Remove.
 647
 648 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 649
 650         * aarch64-tdep.c: Remove xml self tests.
 651         * amd64-linux-tdep.c: Likewise.
 652         * amd64-tdep.c: Likewise.
 653         * i386-linux-tdep.c: Likewise.
 654         * i386-tdep.c: Likewise.
 655
 656 2019-07-03  Pedro Alves  <palves@redhat.com>
 657
 658         PR cli/24732
 659         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 660         (pipe_cmd_option_defs): New.
 661         (make_pipe_cmd_options_def_group): New.
 662         (pipe_command): Use gdb::option::process_options.
 663         (pipe_command_completer): New function.
 664         (_initialize_cli_cmds): Install completer for "pipe" command.
 665
 666 2019-07-03  Pedro Alves  <palves@redhat.com>
 667
 668         * cli/cli-option.c (union option_value) <string>: New field.
 669         (struct option_def_and_value): Add ctor, move ctor, dtor and
 670         use DISABLE_COPY_AND_ASSIGN.
 671         (option_def_and_value::clear_value): New.
 672         (parse_option, save_option_value_in_ctx, get_val_type_str)
 673         (add_setshow_cmds_for_options): Handle var_string.
 674         * cli-option.h (union option_def::var_address) <string>: New
 675         field.
 676         (struct string_option_def): New.
 677         * maint-test-options.c (struct test_options_opts): Add default
 678         ctor and use DISABLE_COPY_AND_ASSIGN.
 679         <string_opt>: New field.
 680         (test_options_opts::~test_options_opts): New.
 681         (test_options_opts::dump): Also dump "-string".
 682         (test_options_option_defs): Install "string.
 683
 684 2019-07-03  Pedro Alves  <palves@redhat.com>
 685
 686         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 687         option_value with a null enumeration.
 688         (complete_options): Save the option values in the context.
 689         (save_option_value_in_ctx): New, factored out from ...
 690         (process_options): ... here.
 691         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 692         of the function.
 693         * maint-test-options.c (test_options_opts::dump): New, factored
 694         out from ...
 695         (maintenance_test_options_command_mode): ... here.
 696         (maintenance_test_options_command_completion_result): Delete.
 697         (maintenance_test_options_command_completion_text): Update
 698         comment.
 699         (maintenance_show_test_options_completion_result): Change
 700         prototype.  Just print
 701         maintenance_test_options_command_completion_text.
 702         (save_completion_result): New.
 703         (maintenance_test_options_completer_mode): Pass options context to
 704         complete_options, and then save a dump.
 705         (_initialize_maint_test_options): Use add_cmd to install "maint
 706         show test-options-completion-result".
 707
 708 2019-07-03  Pedro Alves  <palves@redhat.com>
 709
 710         * NEWS (New commands): Mention "with" and "maint with".
 711         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 712         (with_command, with_command_completer): New.
 713         (pipe_command): Adjust to new repeat_previous
 714         interface.
 715         (_initialize_cli_cmds): Install the "with" command and its "w"
 716         alias.
 717         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 718         declarations.
 719         * cli/cli-setshow.c (parse_cli_var_uinteger)
 720         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 721         argument strings for all var_types.
 722         (get_setshow_command_value_string): New, factored out from ...
 723         (do_show_command): ... this.
 724         * cli/cli-setshow.h: Include <string>.
 725         (get_setshow_command_value_string): Declare.
 726         * command.h (repeat_previous): Now returns const char *.  Adjust
 727         comment.
 728         * maint.c: Include "cli/cli-cmds.h".
 729         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 730         (_initialize_maint_cmds): Register the "maintenance with" command.
 731         * top.c (repeat_previous): Move bits from pipe_command here:
 732         Return the saved command line, if any; error out if there's no
 733         command to relaunch.
 734
 735 2019-07-03  Pedro Alves  <palves@redhat.com>
 736
 737         * NEWS (New commands): Mention "maint set/show test-settings"
 738         instead of "maint test-settings".
 739         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 740         (maintenance_test_settings_set_list): Rename to ...
 741         (maintenance_set_test_settings_list): ... this.
 742         (maintenance_test_settings_show_list): Rename to  ...
 743         (maintenance_show_test_settings_list): ... this.
 744         (maintenance_test_settings_cmd): Delete.
 745         (maintenance_test_settings_set_cmd): ...
 746         (maintenance_set_test_settings_cmd): ... this.
 747         (maintenance_test_settings_show_cmd): ...
 748         (maintenance_show_test_settings_cmd): ... this.
 749         (maintenance_test_settings_show_value_cmd):
 750         (maintenance_show_test_settings_value_cmd): ... this.
 751         (_initialize_maint_test_settings): No longer install the "maint
 752         test-settings" prefix command.  Rename "maint test-settings set"
 753         to "maint set test-settings", and "maint test-settings show" to
 754         "maint show test-settings".  Adjust all subcommands.
 755
 756 2019-07-03  Pedro Alves  <palves@redhat.com>
 757
 758         * maint-test-settings.c: Fix file's intro comment.  Replace all
 759         references to "test-options" with references to "test-settings",
 760         in comments.
 761
 762 2019-07-03  Pedro Alves  <palves@redhat.com>
 763
 764         * maint-test-settings.c (maintenance_test_settings_xxx)
 765         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 766         New.
 767         (maintenance_test_settings_enums): Use them.
 768         (maintenance_test_settings_enum): Default to
 769         maintenance_test_settings_xxx.
 770         (_initialize_maint_test_settings): Initialize
 771         MAINTENANCE_TEST_SETTINGS_FILENAME.
 772
 773 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 774
 775         * breakpoint.h (remove_breakpoints_inf): Change return type to
 776         void, move function documentation here.
 777         * breakpoint.c (remove_breakpoints_inf): Change return type to
 778         void, move function documentation to header.
 779
 780 2019-07-02  Pedro Alves  <palves@redhat.com>
 781
 782         * NEWS (Completion improvements): Mention "info threads".
 783         * thread.c (struct info_threads_opts, info_threads_option_defs)
 784         (make_info_threads_options_def_group): New.
 785         (info_threads_command): Use gdb::option::process_options.
 786         (info_threads_command_completer): New.
 787         (_initialize_thread): Use gdb::option::build_help to build the
 788         help text for "info threads".
 789
 790 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 791
 792         * defs.h (generic_load): Move from here...
 793         * symfile.h (generic_load): ... to here.  Rename name parameter
 794         to args.
 795         * symfile.c (generic_load): Add comment.
 796
 797 2019-07-01  Tom Tromey  <tromey@adacore.com>
 798
 799         * dwarf2read.c
 800         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 801         declaration of without_params.  Fix formatting.
 802
 803 2019-07-01  Tom Tromey  <tromey@adacore.com>
 804
 805         * ada-exp.y (find_primitive_type): Update.
 806         * ada-lang.h (ada_lookup_symbol): Update.
 807         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 808         parameter.
 809         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 810
 811 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 812
 813         PR breakpoints/24541
 814         * gdbarch.c: Regenerate.
 815         * gdbarch.h: Regenerate.
 816         * gdbarch.sh: Add 'stap_adjust_register'.
 817         * i386-tdep.c: Include '<unordered_set>'.
 818         (i386_stap_adjust_register): New function.
 819         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 820         * stap-probe.c (stap_parse_register_operand): Call
 821         'gdbarch_stap_adjust_register'.
 822
 823 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 824
 825         PR python/24742
 826         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 827         * python/python.c (do_start_initialization): Use 'xmalloc'
 828         instead of 'PyMem_Malloc'.
 829
 830 2019-06-28  Tom Tromey  <tromey@adacore.com>
 831
 832         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 833         for Ada.
 834
 835 2019-06-27  Tom Tromey  <tromey@adacore.com>
 836
 837         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 838         objfile_key.
 839         (arm_find_mapping_symbol, arm_record_special_symbol)
 840         (_initialize_arm_tdep): Update.
 841         (arm_objfile_data_free): Remove.
 842
 843 2019-06-27  Tom Tromey  <tromey@adacore.com>
 844
 845         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 846         to cp_print_static_field.
 847
 848 2019-06-26  Tom Tromey  <tromey@adacore.com>
 849
 850         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 851         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 852         declare.
 853
 854 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 855
 856         * features/aarch64-core.c (create_feature_aarch64_core):
 857         Regenerate.
 858         * features/aarch64-core.xml: Add cpsr flags.
 859
 860 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 861
 862         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 863         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 864
 865 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 866
 867         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 868         field.
 869         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 870         use.
 871         (arm_record_special_symbol): Don't insert new symbol in sorted
 872         position, push it at the end.
 873
 874 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 875
 876         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 877         (arm_mapping_symbol_s): Remove.
 878         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 879         (arm_mapping_symbol_vec): New typedef.
 880         (struct arm_per_objfile): Add constructor.
 881         <section_maps>: Change type to
 882         std::unique_ptr<arm_mapping_symbol_vec[]>.
 883         (arm_compare_mapping_symbols): Remove.
 884         (arm_find_mapping_symbol): Adjust to section_maps type change.
 885         (arm_objfile_data_free): Call delete on arm_per_objfile.
 886         (arm_record_special_symbol): Adjust to section_maps type change.
 887         Allocate arm_per_objfile with new.
 888
 889 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 890
 891         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 892         with the command prefix.
 893
 894 2019-06-25  Tom Tromey  <tom@tromey.com>
 895
 896         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 897         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 898
 899 2019-06-25  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 902         type.
 903         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 904         protected.
 905
 906 2019-06-25  Tom Tromey  <tom@tromey.com>
 907
 908         * tui/tui-winsource.c
 909         (tui_source_window_base::set_is_exec_point_at): Add check against
 910         LOA_ADDRESS.
 911
 912 2019-06-25  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-source.c (tui_set_source_content): Don't check before
 915         xfree.
 916         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 917
 918 2019-06-25  Tom Tromey  <tom@tromey.com>
 919
 920         * tui/tui-winsource.h (tui_update_source_window_as_is)
 921         (tui_alloc_source_buffer, tui_line_is_displayed)
 922         (tui_addr_is_displayed): Change type of win_info.
 923         * tui/tui-winsource.c (tui_update_source_window_as_is)
 924         (tui_clear_source_content, tui_show_source_line)
 925         (tui_show_source_content, tui_source_window_base::refill)
 926         (tui_source_window_base::set_is_exec_point_at)
 927         (tui_source_window_base::set_is_exec_point_at)
 928         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 929         (tui_alloc_source_buffer, tui_line_is_displayed)
 930         (tui_addr_is_displayed): Change type of win_info.  Update.
 931         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 932         (tui_source_window_base::do_make_visible_with_new_height):
 933         Update.
 934         * tui/tui-source.c (tui_set_source_content)
 935         (tui_set_source_content_nil)
 936         (tui_source_window::do_scroll_vertical): Update.
 937         * tui/tui-layout.c (show_layout): Update.
 938         * tui/tui-disasm.c (tui_set_disassem_content)
 939         (tui_disasm_window::do_scroll_vertical): Update.
 940         * tui/tui-data.h (tui_win_content): Remove.
 941         (struct tui_gen_win_info) <content, content_size>: Remove.
 942         (struct tui_source_element): Add initializers and destructor.
 943         (union tui_which_element, struct tui_win_element): Remove.
 944         (struct tui_source_window_base) <content>: New field.
 945         (struct tui_data_window): Remove destructor.
 946         (tui_alloc_content, tui_free_win_content)
 947         (tui_free_all_source_wins_content): Don't declare.
 948         * tui/tui-data.c (tui_initialize_static_data): Update.
 949         (init_content_element, tui_alloc_content): Remove.
 950         (~tui_gen_win_info): Update.
 951         (~tui_data_window, tui_free_all_source_wins_content)
 952         (tui_free_win_content, free_content, free_content_elements):
 953         Remove.
 954
 955 2019-06-25  Tom Tromey  <tom@tromey.com>
 956
 957         * tui/tui-winsource.h (tui_clear_source_content)
 958         (tui_erase_source_content, tui_show_source_content): Change type
 959         of win_info.
 960         * tui/tui-winsource.c (tui_clear_source_content)
 961         (tui_erase_source_content, tui_show_source_content): Change type
 962         of win_info.
 963         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 964         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 965         win_info.
 966         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 967         win_info.
 968         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 969
 970 2019-06-25  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-winsource.c (tui_clear_source_content)
 973         (tui_source_window_base::set_is_exec_point_at): Update.
 974         * tui/tui-source.c (tui_set_source_content_nil): Update.
 975         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 976         a bool.
 977         * tui/tui-data.c (init_content_element): Update.
 978
 979 2019-06-25  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 982         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 983         * tui/tui-layout.c (init_and_make_win): Update.
 984         * tui/tui.h (enum tui_win_type): Update.
 985         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 986         tui_win_is_auxillary.
 987         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 988         tui_win_is_auxillary.
 989
 990 2019-06-25  Tom Tromey  <tom@tromey.com>
 991
 992         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 993         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 994         (tui_delete_data_content_windows, tui_display_all_data)
 995         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 996         Update.
 997         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 998         * tui/tui-regs.c (tui_last_regs_line_no)
 999         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1000         (tui_show_registers): Update.
1001         (tui_show_register_group): Return void.  Update.
1002         (tui_display_registers_from, tui_display_reg_element_at_line)
1003         (tui_display_registers_from_line, tui_check_register_values):
1004         Update.
1005         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1006         member.
1007         (struct tui_data_window) <regs_content>: Now a std::vector.
1008         <regs_content_count>: Remove.
1009         (tui_add_content_elements, tui_free_data_content): Don't declare.
1010         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1011         (init_content_element): Remove DATA_WIN case.  Add assert.
1012         (tui_add_content_elements): Remove.
1013         (tui_data_window): Update.
1014         (tui_free_data_content): Remove.
1015         (free_content_elements): Remove DATA_WIN case.
1016
1017 2019-06-25  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-data.c (tui_data_item_window): Update.
1020         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1021         * tui/tui-windata.c (tui_display_all_data)
1022         (tui_display_data_from_line): Update.
1023         (tui_check_data_values): Remove.
1024         * tui/tui-regs.c (tui_show_register_group)
1025         (tui_display_reg_element_at_line): Update.
1026         * tui/tui-hooks.c (tui_register_changed)
1027         (tui_refresh_frame_and_register_information): Call
1028         tui_check_register_values.
1029         * tui/tui-data.h (struct tui_data_window) <data_content,
1030         data_content_count, data_type>: Remove.
1031         (enum tui_data_type): Remove.
1032
1033         * tui/tui-data.c (tui_data_window::clear_detail)
1034         (~tui_data_window): Update.
1035
1036 2019-06-25  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1039         declare.
1040         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1041         Rename from tui_first_data_item_displayed.  Update.
1042         (tui_data_window::refresh_all)
1043         (tui_data_window::do_scroll_vertical): Update.
1044         * tui/tui-data.h (struct tui_data_window)
1045         <first_data_item_displayed>: Declare new method.
1046
1047 2019-06-25  Tom Tromey  <tom@tromey.com>
1048
1049         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1050         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1051         contents...
1052         (tui_initialize_static_data): ...here.
1053
1054 2019-06-25  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1057         (tui_display_registers_from, tui_check_register_values): Update.
1058         (tui_display_register): Remove win_info parameter; update.
1059         (tui_get_register): Change type of parameters.
1060         * tui/tui-data.h (struct tui_data_element): Remove.
1061         (union tui_which_element) <data>: Remove.
1062         <data_window>: Change type.
1063         (struct tui_data_item_window): New.
1064         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1065         case.  Add assert.
1066         (~tui_data_item_window): New destructor.
1067         (free_content_elements): Remove DATA_ITEM_WIN case.
1068
1069 2019-06-25  Tom Tromey  <tom@tromey.com>
1070
1071         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1072         Remove.
1073
1074 2019-06-25  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-data.h (struct tui_command_element): Remove.
1077         (union tui_which_element) <command>: Remove.
1078         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1079         assert.
1080         (free_content_elements): Remove CMD_WIN case.
1081
1082 2019-06-25  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-layout.c (tui_set_layout): Update.
1085         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1086         * tui/tui-data.c (layout_def): Update.
1087
1088 2019-06-25  Tom Tromey  <tom@tromey.com>
1089
1090         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1091         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1092         (tui_source_window_base::set_new_height): Update.
1093         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1094         Update.
1095         (tui_set_locator_fullname, tui_set_locator_info)
1096         (tui_show_frame_info): Update.
1097         * tui/tui-source.c (tui_set_source_content)
1098         (tui_source_is_displayed): Update.
1099         * tui/tui-layout.c (show_source_disasm_command, show_data)
1100         (show_source_or_disasm_and_command): Update.
1101         * tui/tui-disasm.c (tui_set_disassem_content)
1102         (tui_get_begin_asm_address): Update.
1103         * tui/tui-data.h (struct tui_locator_element): Remove.
1104         (union tui_which_element) <locator>: Remove.
1105         (struct tui_locator_window): New.
1106         (tui_locator_win_info_ptr): Change return type.
1107         * tui/tui-data.c (_locator): Change type.
1108         (tui_locator_win_info_ptr): Change return type.
1109         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1110         (tui_alloc_content): Add assert.
1111
1112 2019-06-25  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-winsource.c
1115         (tui_exec_info_window::maybe_allocate_content): New method.
1116         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1117         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1118         (make_source_or_disasm_window): Add cast.
1119         * tui/tui-data.h (union tui_which_element) <simple_string>:
1120         Remove.
1121         (struct tui_source_info): New.
1122         (struct tui_source_window_base) <execution_info>: Change type.
1123         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1124         case, and add assert.
1125         (tui_alloc_content): Add assert.
1126
1127 2019-06-25  Tom Tromey  <tom@tromey.com>
1128
1129         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1130         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1131         * tui/tui-data.c (tui_alloc_win_info): Remove.
1132
1133 2019-06-25  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1136         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1137         can_highlight.
1138
1139 2019-06-25  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1142         make_visible_with_new_height method.
1143         (tui_win_info::make_visible_with_new_height): New method.
1144         (tui_source_window_base::do_make_visible_with_new_height)
1145         (tui_data_window::do_make_visible_with_new_height)
1146         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1147         (make_visible_with_new_height): Remove.
1148         (tui_resize_all, tui_adjust_win_heights): Use
1149         make_visible_with_new_height method.
1150         * tui/tui-data.h (struct tui_win_info)
1151         <do_make_visible_with_new_height, make_visible_with_new_height>:
1152         New methods.
1153         (struct tui_source_window_base, struct tui_data_window)
1154         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1155         methods.
1156
1157 2019-06-25  Tom Tromey  <tom@tromey.com>
1158
1159         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1160         method.
1161         (update_tab_width): Call update_tab_width method.
1162         * tui/tui-data.h (struct tui_win_info)
1163         (struct tui_source_window_base) <update_tab_width>: New methods.
1164
1165 2019-06-25  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1168         parameter.
1169         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1170         parameter.
1171         (tui_gen_win_info::make_visible): Update.
1172         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1173         parameter.
1174         * tui/tui-data.h (enum tui_box): New enum.
1175         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1176
1177 2019-06-25  Tom Tromey  <tom@tromey.com>
1178
1179         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1180         init_and_make_win for EXEC_INFO_WIN.
1181         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1182         longer inline.
1183         (struct tui_win_info) <~tui_win_info>: Inline.
1184         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1185         Don't declare.
1186         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1187         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1188         Remove.
1189         (tui_initialize_static_data): Update.
1190         (~tui_gen_win_info): Handle more cleanup here.
1191         (~tui_source_window_base): Delete "execution_info".
1192         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1193
1194 2019-06-25  Tom Tromey  <tom@tromey.com>
1195
1196         * tui/tui-layout.c (make_command_window): Don't set
1197         can_highlight.
1198         (show_source_disasm_command): Call the reset method.
1199         (show_data): Don't set can_highlight.  Call the reset method.
1200         (tui_gen_win_info::reset): Rename from init_gen_win_info
1201         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1202         (show_source_or_disasm_and_command): Call the reset method.
1203         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1204         (struct tui_cmd_window): Set can_highlight.
1205
1206 2019-06-25  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1209         from make_visible.
1210         (tui_make_visible, tui_make_invisible): Rewrite.
1211         (tui_win_info::make_visible): Remove.
1212         (tui_source_window_base::make_visible): Update.
1213         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1214         method.  Moved from...
1215         (struct tui_win_info) <make_visible>: ...here.
1216
1217 2019-06-25  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-winsource.c
1220         (tui_source_window_base::do_scroll_horizontal): Remove direction
1221         parameter.
1222         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1223         direction parameter.
1224         * tui/tui-win.c (tui_win_info::forward_scroll)
1225         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1226         (tui_win_info::right_scroll): Update.
1227         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1228         direction parameter.
1229         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1230         direction parameter.
1231         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1232         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1233         Remove direction parameter.
1234         (struct tui_source_window_base, struct tui_source_window)
1235         (struct tui_disasm_window, struct tui_data_window)
1236         (struct tui_cmd_window): Update.
1237
1238 2019-06-25  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-winsource.h (tui_set_exec_info_content)
1241         (tui_show_exec_info_content, tui_erase_exec_info_content)
1242         (tui_clear_exec_info_content, tui_update_exec_info): Change
1243         argument to tui_source_window_base.
1244         * tui/tui-winsource.c (tui_set_exec_info_content)
1245         (tui_show_exec_info_content, tui_erase_exec_info_content)
1246         (tui_clear_exec_info_content, tui_update_exec_info): Change
1247         argument to tui_source_window_base.
1248
1249 2019-06-25  Tom Tromey  <tom@tromey.com>
1250
1251         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1252         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1253
1254 2019-06-25  Tom Tromey  <tom@tromey.com>
1255
1256         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1257         check.
1258
1259 2019-06-25  Tom Tromey  <tom@tromey.com>
1260
1261         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1262         type to void.
1263         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1264         type to void.
1265         * tui/tui-source.c (tui_set_source_content): Update.
1266         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1267
1268 2019-06-25  Tom Tromey  <tom@tromey.com>
1269
1270         * tui/tui-win.c (window_name_completer, tui_set_focus)
1271         (tui_all_windows_info): Use name method.
1272         * tui/tui-data.h (struct tui_gen_win_info)
1273         (struct tui_source_window, struct tui_disasm_window)
1274         (struct tui_data_window, struct tui_cmd_window) <name>: New
1275         method.
1276         (tui_win_name): Don't declare.
1277         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1278         (tui_win_name): Remove.
1279
1280 2019-06-25  Tom Tromey  <tom@tromey.com>
1281
1282         * tui/tui-winsource.h (tui_update_source_window)
1283         (tui_update_source_window_as_is): Change parameter type.
1284         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1285         to be a tui_source_window_base.
1286         (tui_update_source_window_as_is): Likewise.
1287         * tui/tui-win.c (make_visible_with_new_height): Update.
1288
1289 2019-06-25  Tom Tromey  <tom@tromey.com>
1290
1291         * tui/tui-winsource.c (tui_erase_source_content)
1292         (tui_show_source_content, tui_show_exec_info_content)
1293         (tui_erase_exec_info_content): Use refresh_window method.
1294         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1295         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1296         from tui_refresh_win.
1297         (tui_data_window::refresh_window): New method.
1298         (tui_win_info::refresh, tui_source_window_base::refresh)
1299         (tui_refresh_all): Use refresh_window method.
1300         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1301         method.
1302         * tui/tui-regs.c (tui_display_register): Call refresh_window
1303         method.
1304         * tui/tui-layout.c (show_source_disasm_command)
1305         (show_source_or_disasm_and_command): Call refresh_window method.
1306         * tui/tui-data.h (struct tui_gen_win_info)
1307         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1308         New method.
1309
1310 2019-06-25  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui.c (tui_rl_other_window, tui_enable)
1313         (tui_is_window_visible, tui_get_command_dimension): Update.
1314         * tui/tui-winsource.c (tui_update_source_window_as_is)
1315         (tui_clear_source_content, tui_erase_source_content)
1316         (tui_show_source_line, tui_source_window_base::refill)
1317         (tui_source_window_base::do_scroll_horizontal)
1318         (tui_source_window_base::set_is_exec_point_at)
1319         (tui_update_breakpoint_info, tui_set_exec_info_content)
1320         (tui_alloc_source_buffer, tui_line_is_displayed)
1321         (tui_addr_is_displayed): Update.
1322         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1323         (tui_check_and_display_highlight_if_needed)
1324         (tui_win_info::make_visible, tui_win_info::refresh)
1325         (tui_refresh_all): Update.
1326         * tui/tui-windata.c (tui_first_data_item_displayed)
1327         (tui_delete_data_content_windows, tui_erase_data_content)
1328         (tui_display_all_data, tui_data_window::refresh_all)
1329         (tui_check_data_values): Update.
1330         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1331         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1332         (tui_win_info::backward_scroll, tui_refresh_all_win)
1333         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1334         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1335         (tui_source_window_base::set_new_height)
1336         (tui_data_window::set_new_height)
1337         (make_invisible_and_set_new_height)
1338         (make_visible_with_new_height, new_height_ok)
1339         (parse_scrolling_args): Update.
1340         * tui/tui-stack.c (tui_show_frame_info): Update.
1341         * tui/tui-source.c (tui_set_source_content)
1342         (tui_set_source_content_nil, tui_source_is_displayed)
1343         (tui_source_window::do_scroll_vertical): Update.
1344         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1345         (tui_display_registers_from, tui_display_reg_element_at_line)
1346         (tui_check_register_values, tui_reg_command): Update.
1347         * tui/tui-layout.c (tui_default_win_height)
1348         (show_source_disasm_command, show_data, init_and_make_win)
1349         (show_source_or_disasm_and_command): Update.
1350         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1351         (tui_redisplay_readline, tui_mld_flush)
1352         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1353         (tui_getc): Update.
1354         * tui/tui-disasm.c (tui_set_disassem_content)
1355         (tui_disasm_window::do_scroll_vertical): Update.
1356         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1357         Now virtual.
1358         (struct tui_win_info): Derive from tui_gen_win_info.
1359         <~tui_win_info>: Mark as override.
1360         <generic>: Remove member.
1361         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1362         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1363         (~tui_data_window, ~tui_win_info)
1364         (tui_free_all_source_wins_content): Update.
1365         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1366
1367 2019-06-25  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-layout.c (init_and_make_win): Use new.
1370         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1371         destructor, initializers.
1372         (tui_alloc_generic_win_info): Don't declare.
1373         * tui/tui-data.c (_locator): Add argument to constructor.
1374         (source_win, disasm_win): New globals.
1375         (exec_info): Remove.
1376         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1377         Update.
1378         (tui_alloc_generic_win_info): Remove.
1379         (init_content_element): Use new.
1380         (tui_win_info::tui_win_info): Update.
1381         (free_content_elements) <case DATA_WIN>: Use delete.
1382
1383 2019-06-25  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1386         * tui/tui-windata.c (tui_first_data_item_displayed)
1387         (tui_delete_data_content_windows): Update.
1388         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1389         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1390         (tui_display_registers_from, tui_check_register_values): Update.
1391         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1392         pointer.
1393         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1394         window.
1395         (tui_free_data_content): Update.
1396         (free_content_elements) <case DATA_WIN>: Free the window.
1397
1398 2019-06-25  Tom Tromey  <tom@tromey.com>
1399
1400         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1401         Update.
1402         * tui/tui-layout.c (make_command_window)
1403         (show_source_disasm_command, show_data, init_and_make_win)
1404         (show_source_or_disasm_and_command): Update.
1405         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1406         method.
1407         <can_highight, is_highlighted>: Now bool.
1408         (tui_set_win_highlight): Don't declare.
1409         * tui/tui-data.c (tui_set_win_highlight): Remove.
1410
1411 2019-06-25  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-wingeneral.c (make_visible): Remove check of window
1414         type.
1415
1416 2019-06-25  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-win.c (tui_win_info::max_height)
1419         (tui_cmd_window::max_height): New methods.
1420         (new_height_ok): Call max_height.
1421         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1422         <max_height>: New method.
1423
1424 2019-06-25  Tom Tromey  <tom@tromey.com>
1425
1426         * tui/tui-win.c (tui_source_window_base::set_new_height)
1427         (tui_data_window::set_new_height): New methods.
1428         (make_invisible_and_set_new_height): Call set_new_height method.
1429         * tui/tui-data.h (struct tui_win_info)
1430         (struct tui_source_window_base, struct tui_data_window)
1431         <set_new_height>: New method.
1432
1433 2019-06-25  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1436         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1437         tui_refresh_data_win.
1438         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1439         method.
1440         (tui_refresh_all_win): Call the refresh_all method.
1441         (tui_set_focus): Likewise.
1442         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1443         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1444         Likewise.
1445
1446 2019-06-25  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-winsource.h (tui_refill_source_window)
1449         (tui_set_is_exec_point_at): Don't declare.
1450         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1451         (tui_source_window_base::refill): Rename from
1452         tui_refill_source_window.
1453         (tui_source_window_base::do_scroll_horizontal): Update.
1454         (tui_source_window_base::set_is_exec_point_at): Rename from
1455         tui_set_is_exec_point_at.
1456         (tui_update_all_breakpoint_info): Update.
1457         * tui/tui-stack.c (tui_show_frame_info): Update.
1458         * tui/tui-layout.c (show_data): Add cast.
1459         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1460         * tui/tui-data.h (struct tui_source_window_base) <refill,
1461         set_is_exec_point_at>: New methods.
1462         (tui_source_windows, tui_add_to_source_windows): Update types.
1463         (tui_add_to_source_windows): Remove redundant declaration.
1464         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1465         (tui_source_windows): Change return type.
1466         (tui_clear_source_windows_detail): Update.
1467         (tui_add_to_source_windows): Change type of parameter.
1468         (tui_free_all_source_wins_content): Update.
1469
1470 2019-06-25  Tom Tromey  <tom@tromey.com>
1471
1472         * tui/tui-wingeneral.c (tui_win_info::refresh)
1473         (tui_source_window_base::refresh): New methods.
1474         (tui_refresh_all): Call the refresh method.
1475         * tui/tui-data.h (struct tui_win_info)
1476         (struct tui_source_window_base) <refresh>: New method.
1477
1478 2019-06-25  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui.h (tui_is_window_visible): Return bool.
1481         * tui/tui.c (tui_is_window_visible): Return bool.
1482         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1483         (tui_make_visible, tui_make_invisible)
1484         (tui_win_info::make_visible)
1485         (tui_source_window_base::make_visible, make_all_visible)
1486         (tui_make_all_visible, tui_make_all_invisible): Update.
1487         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1488         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1489         bool.
1490         (struct tui_win_info, struct tui_source_window_base)
1491         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1492         * tui/tui-data.c (tui_init_generic_part): Update.
1493
1494 2019-06-25  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1497         (tui_source_window_base::make_visible): New methods.
1498         (make_all_visible): Make method call.
1499         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1500         (struct tui_source_window_base, struct tui_cmd_window): Override
1501         make_visible.
1502         (tui_win_is_source_type): Don't declare.
1503         * tui/tui-data.c (tui_win_is_source_type): Remove.
1504
1505 2019-06-25  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1508         NULL check.
1509
1510 2019-06-25  Tom Tromey  <tom@tromey.com>
1511
1512         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1513         Inline constructor.  Add initializers for members.
1514         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1515         constructors; now inline in class.
1516
1517 2019-06-25  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-regs.c (tui_show_registers): Update.
1520         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1521         bool.
1522         * tui/tui-data.c (tui_data_window::clear_detail)
1523         (tui_data_window): Update.
1524
1525 2019-06-25  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-windata.c (tui_display_all_data)
1528         (tui_display_data_from_line, tui_display_data_from)
1529         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1530         Update.
1531         * tui/tui-regs.c (tui_last_regs_line_no)
1532         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1533         (tui_show_registers, tui_show_register_group)
1534         (tui_display_registers_from, tui_display_reg_element_at_line)
1535         (tui_display_registers_from_line, tui_check_register_values)
1536         (tui_reg_next, tui_reg_prev): Update.
1537         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1538         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1539         tui_data_window.
1540         (struct tui_win_info) <detail>: Remove.  Add new fields from
1541         tui_data_info.
1542         (TUI_DATA_WIN): Add cast.
1543         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1544         (~tui_data_window): Simplify.
1545
1546 2019-06-25  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-layout.c (show_source_disasm_command)
1549         (show_source_or_disasm_and_command): Update.
1550         * tui/tui-io.c (update_cmdwin_start_line)
1551         (tui_redisplay_readline): Update.
1552         * tui/tui-data.h (struct tui_command_info): Remove.
1553         (struct tui_win_info) <detail>: Remove command_info member.
1554         (struct tui_data_window) <start_line>: New member, from
1555         tui_command_info.
1556         (TUI_CMD_WIN): Add casts.
1557
1558 2019-06-25  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-winsource.c (tui_update_source_window)
1561         (tui_refill_source_window)
1562         (tui_source_window_base::do_scroll_horizontal)
1563         (tui_update_breakpoint_info, tui_set_exec_info_content)
1564         (tui_show_exec_info_content, tui_erase_exec_info_content)
1565         (tui_clear_exec_info_content): Update.
1566         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1567         Update.
1568         * tui/tui-win.c (make_invisible_and_set_new_height)
1569         (make_visible_with_new_height): Update.
1570         * tui/tui-source.c (tui_set_source_content)
1571         (tui_show_symtab_source): Update.
1572         * tui/tui-layout.c (extract_display_start_addr)
1573         (show_source_disasm_command, show_data)
1574         (make_source_or_disasm_window)
1575         (show_source_or_disasm_and_command): Update.
1576         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1577         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1578         "gdbarch".
1579         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1580         to tui_source_window_base.
1581         (struct tui_win_info) <detail>: Remove source_info member.
1582         (struct tui_source_window_base) <has_locator>: Inline.
1583         Move contents from tui_source_info; rename has_locator member to
1584         m_has_locator.
1585         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1586         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1587         header file.
1588         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1589         Simplify.
1590         (tui_free_all_source_wins_content): Cast to
1591         tui_source_window_base.
1592
1593 2019-06-25  Tom Tromey  <tom@tromey.com>
1594
1595         * tui/tui-win.c (make_invisible_and_set_new_height)
1596         (make_visible_with_new_height): Call has_locator method.
1597         * tui/tui-layout.c (show_source_disasm_command, show_data)
1598         (show_source_or_disasm_and_command): Update for bool change.
1599         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1600         (tui_win_info) <has_locator>: New method.
1601         (struct tui_source_window_base) <has_locator>: New method.
1602         (tui_win_has_locator): Don't declare.
1603         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1604         from tui_win_has_locator.
1605         (tui_source_window_base): Use false, not FALSE.
1606
1607 2019-06-25  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1610         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1611         clear_detail method directly.
1612         (tui_clear_win_detail): Remove.
1613
1614 2019-06-25  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1617         "this", not TUI_DISASM_WIN.
1618
1619 2019-06-25  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1622         declare.
1623         * tui/tui-winsource.c
1624         (tui_source_window_base::do_scroll_horizontal): Rename from
1625         tui_horizontal_source_scroll.
1626         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1627         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1628         from tui_vertical_data_scroll.
1629         * tui/tui-win.h (tui_scroll): Don't declare.
1630         * tui/tui-win.c (tui_win_info::forward_scroll)
1631         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1632         (tui_win_info::right_scroll): Rename and update.
1633         (tui_scroll_forward_command, tui_scroll_backward_command)
1634         (tui_scroll_left_command, tui_scroll_right_command): Update.
1635         (tui_scroll): Remove.
1636         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1637         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1638         from tui_vertical_source_scroll.
1639         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1640         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1641         from tui_vertical_disassem_scroll.
1642         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1643         do_scroll_horizontal>: New methods.
1644         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1645         Likewise.
1646         (struct tui_source_window_base): Add do_scroll_horizontal.
1647         (struct tui_source_window, struct tui_disasm_window): Add
1648         do_scroll_vertical.
1649         (struct tui_data_window, struct tui_cmd_window): Add
1650         do_scroll_horizontal and do_scroll_vertical.
1651         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1652
1653 2019-06-25  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui-data.h (struct tui_source_window_base): New struct.
1656         (struct tui_source_window): Derive from tui_source_window_base.
1657         (struct tui_disasm_window): New struct.
1658         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1659         from tui_source_window::clear_detail.
1660         (tui_source_window_base): Rename from tui_source_window.
1661         (~tui_source_window_base): Rename from ~tui_source_window.
1662         (tui_alloc_win_info): Create a tui_disasm_window.
1663
1664 2019-06-25  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-data.h (struct tui_source_window)
1667         (struct tui_data_window): Declare destructors.
1668         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1669         destructors.
1670         (tui_win_info): Simplify.
1671
1672 2019-06-25  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-winsource.c (tui_display_main)
1675         (tui_update_source_windows_with_addr)
1676         (tui_update_all_breakpoint_info): Update.
1677         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1678         (new_height_ok, parse_scrolling_args): Update.
1679         * tui/tui-stack.c (tui_show_frame_info): Update.
1680         * tui/tui-data.h (struct tui_list): Remove.
1681         (tui_source_windows): Return a reference to a std::vector.
1682         * tui/tui-data.c (source_windows): Now a std::vector.
1683         (tui_source_windows): Change return type.
1684         (tui_clear_source_windows): Rewrite.
1685         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1686         (tui_free_all_source_wins_content): Rewrite.
1687
1688 2019-06-25  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1691         (struct tui_data_window, struct tui_cmd_window): Declare
1692         clear_detail method.
1693         * tui/tui-data.c (tui_source_window::clear_detail)
1694         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1695         methods.
1696         (tui_clear_win_detail): Simplify.
1697
1698 2019-06-25  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-layout.c (make_source_window, make_disasm_window)
1701         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1702         Return the new window.
1703         (show_source_disasm_command, show_data)
1704         (show_source_or_disasm_and_command): Update.
1705
1706 2019-06-25  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1709         parameter.  Return the new window.
1710         (show_source_disasm_command): Update and remove NULL check.
1711         (show_source_or_disasm_and_command): Update.
1712
1713 2019-06-25  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1716
1717 2019-06-25  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-data.h (struct tui_win_info): Make constructor
1720         protected.  Make destructor virtual.  Add initializers.
1721         (tui_source_window, tui_data_window, tui_cmd_window): New
1722         classes.
1723         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1724         constructor.  Add "type" parameter.
1725         (tui_source_window, tui_data_window, tui_cmd_window): New
1726         constructors.
1727         (tui_alloc_win_info): Instantiate the appropriate subclass.
1728
1729 2019-06-25  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-win.c (tui_resize_all): Use delete.
1732         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1733         destructor.
1734         (tui_free_window): Don't declare.
1735         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1736         Update.
1737
1738 2019-06-25  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-data.h (struct tui_win_info): Add constructor.
1741         * tui/tui-data.c (tui_alloc_win_info): Use new.
1742         (tui_free_window): Use delete.
1743
1744 2019-06-22  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1747         declare.
1748         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1749
1750 2019-06-22  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1753         declare.
1754         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1755
1756 2019-06-22  Tom de Vries  <tdevries@suse.de>
1757
1758         * dwarf2read.c (create_addrmap_from_aranges)
1759         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1760         instead of '%zu'.
1761
1762 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1763
1764         * dwarf2read.h (dwarf2_section_info_def): Remove.
1765         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1766         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1767         std::vector<dwarf2_section_info>.
1768         (struct dwo_file) <~dwo_file>: Remove.
1769         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1770         types field.
1771         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1772         (dwarf2_read_debug_names): Likewise.
1773         (create_debug_types_hash_table): Change parameter type to
1774         array_view, adjust code accordingly.
1775         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1776         (partial_die_info::fixup): Likewise.
1777         (determine_prefix): Likewise.
1778         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1779
1780 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1781
1782         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1783         gdb_bfd_ref_ptr.
1784         <~dwo_file>: Remove call to gdb_bfd_unref.
1785         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1786         gdb_bfd_ref_ptr::get.
1787
1788 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1789
1790         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1791         type to htab_up.
1792         * dwarf2read.c (struct dwo_file): Initialize fields.
1793         <~dwo_file>: New.
1794         (free_dwo_file): Remove, move content to ~dwo_file.
1795         (struct dwo_file_deleter): Remove.
1796         (dwo_file_up>: Remove custom deleter.
1797         (free_dwo_files): Remove.
1798         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1799         dwo_files.
1800         (process_skeletonless_type_units): Call unique_ptr::get.
1801         (allocate_dwo_file_hash_table): Add deleter to created hash
1802         table.  Change return type to htab_up.
1803         (lookup_dwo_file_slot): Don't memset dwo_file, call
1804         unique_ptr::get.
1805         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1806         (create_dwo_unit_in_dwp_v2): Likewise.
1807         (open_and_init_dwo_file): Likewise.
1808         (free_dwo_file_from_slot): Remove.
1809
1810 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1811
1812         * dwarf2read.h (struct dwarf2_section_info) <readin,
1813         is_virtual>: Change type to bool.
1814         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1815         true instead of 1.
1816
1817 2019-06-19  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-data.h (tui_init_content_element): Don't declare.
1820
1821 2019-06-19  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-data.h (tui_init_win_info): Don't declare.
1824
1825 2019-06-19  Tom de Vries  <tdevries@suse.de>
1826
1827         * dwarf2read.h (abstract_to_concrete): Change type to
1828         std::unordered_map<sect_offset, std::vector<sect_offset>,
1829         gdb::hash_enum<sect_offset>>.
1830
1831 2019-06-19  Tom Tromey  <tromey@adacore.com>
1832
1833         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1834         EVAL_AVOID_SIDE_EFFECTS specially.
1835
1836 2019-06-19  Tom Tromey  <tromey@adacore.com>
1837
1838         * source-cache.c (highlighter): New global.
1839         (source_cache::get_source_lines): Create a highlighter on demand.
1840
1841 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1842
1843         * defs.h (deprecated_interactive_hook): Delete declaration.
1844         * interps.c (clear_interpreter_hooks): Remove use of
1845         deprecated_interactive_hook.
1846         * top.c (deprecated_interactive_hook): Delete definition.
1847         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1848
1849 2019-06-18  Tom de Vries  <tdevries@suse.de>
1850
1851         PR gdb/24515
1852         * dwarf2read.h (abstract_to_concrete): Change type from
1853         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1854         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1855         * dwarf2read.c (read_variable): Update.
1856         (dwarf2_fetch_die_loc_sect_off): Update.
1857
1858 2019-06-17  Tom de Vries  <tdevries@suse.de>
1859
1860         PR gdb/24617
1861         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1862         accessing parent[parent_len - 1].
1863
1864 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1865
1866         PR gdb/24364
1867         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1868         call dtrace_process_dof with NULL dof.
1869
1870 2019-06-16  Tom de Vries  <tdevries@suse.de>
1871
1872         PR gdb/24445
1873         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1874
1875 2019-06-16  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1878         (make_all_visible): Use address of member.
1879
1880 2019-06-16  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1883         (tui_free_window, free_content, free_content_elements): Remove
1884         unnecessary cast.
1885         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1886         cast.
1887         * tui/tui-regs.c (tui_show_register_group)
1888         (tui_display_registers_from, tui_display_reg_element_at_line):
1889         Remove unnecessary cast.
1890
1891 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1892
1893         * linux-nat.c (normal_mask): Delete.
1894         (_initialize_linux_nat): Don't initialise normal_mask.
1895
1896 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1897
1898         PR gdb/24445
1899         * dwarf-index-write.h (write_psymtabs_to_index): Add
1900         dwz_basename parameter.
1901         * dwarf-index-write.c (write_gdbindex): Move file writing to
1902         write_gdbindex_1.  Change return type void.
1903         (assert_file_size): Move up, remove filename parameter.
1904         (write_gdbindex_1): New function.
1905         (write_debug_names): Change return type to void, call
1906         assert_file_size.
1907         (struct index_wip_file): New struct.
1908         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1909         file logic to index_wip_file.  Write index for dwz file if
1910         needed.
1911         (save_gdb_index_command): Pass basename of dwz file, if present.
1912         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1913         build-id of dwz file, if present.
1914         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1915         (dwarf2_get_dwz_file): Likewise.
1916         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1917         (dwarf2_get_dwz_file): Likewise.
1918
1919 2019-06-16  Tom Tromey  <tom@tromey.com>
1920
1921         * coffread.c (process_coff_symbol): Use xstrdup.
1922         * value.c (create_internalvar): Use xstrdup.
1923
1924 2019-06-16  Tom Tromey  <tom@tromey.com>
1925
1926         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1927         * breakpoint.c (stopin_command, stopat_command)
1928         (until_break_command, decode_location_default): Remove unnecessary
1929         cast.
1930         * utils.c (subset_compare): Remove unnecessary cast.
1931         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1932         cast.
1933         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1934         cast.
1935         * infcmd.c (path_command): Remove unnecessary cast.
1936         * coffread.c (decode_type): Remove unnecessary cast.
1937         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1938         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1939         * tui/tui-stack.c (tui_show_locator_content)
1940         (tui_show_frame_info): Remove unnecessary cast.
1941         * tui/tui-win.c (tui_scroll_forward_command)
1942         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1943         (parse_scrolling_args): Remove unnecessary cast.
1944         * tui/tui-data.c (init_win_info, tui_del_window)
1945         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1946         (free_content_elements): Remove unnecessary cast.
1947         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1948         unnecessary cast.
1949         * tui/tui-source.c (tui_set_source_content)
1950         (tui_vertical_source_scroll): Remove unnecessary cast.
1951         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1952         cast.
1953         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1954         * tui/tui-regs.c (tui_display_registers_from)
1955         (tui_display_register): Remove unnecessary cast.
1956         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1957         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1958         (make_visible): Remove unnecessary cast.
1959         * tui/tui-winsource.c (tui_erase_source_content)
1960         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1961         unnecessary cast.
1962         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1963         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1964         * stabsread.c (read_type, read_array_type, read_range_type):
1965         Remove unnecessary cast.
1966         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1967         (parse_symbol, parse_type, upgrade_type, parse_external)
1968         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1969         unnecessary cast.
1970         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1971
1972 2019-06-16  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-data.c (tui_alloc_generic_win_info)
1975         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1976         checks.
1977
1978 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1979             Andrew Burgess  <andrew.burgess@embecosm.com>
1980
1981         * f-typeprint.c (f_print_type): Don't return early for not
1982         associated or not allocated types.
1983         (f_type_print_varspec_suffix): Add print_rank parameter and print
1984         ranks of array types in case they dangling.
1985         (f_type_print_base): Add print_rank parameter.
1986
1987 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1988
1989         * NEWS: Mention new MI commands.
1990         * break-catch-throw.c (enum exception_event_kind): Move to
1991         breakpoint.h.
1992         (print_mention_exception_catchpoint): Output text as a single
1993         message.
1994         (catch_exception_command_1): Rename to...
1995         (catch_exception_event): ...this, make non-static, update header
1996         command, and change some parameter types.
1997         (catch_catch_command): Update for changes to
1998         catch_exception_command_1.
1999         (catch_throw_command): Likewise.
2000         (catch_rethrow_command): Likewise.
2001         * breakpoint.c (enum exception_event_kind): Delete.
2002         * breakpoint.h (enum exception_event_kind): Moved here from
2003         break-catch-throw.c.
2004         (catch_exception_event): Declare.
2005         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2006         (mi_cmd_catch_throw): New function.
2007         (mi_cmd_catch_rethrow): New function.
2008         (mi_cmd_catch_catch): New function.
2009         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2010         'catch-catch' entries.
2011         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2012         (mi_cmd_catch_rethrow): Declare.
2013         (mi_cmd_catch_catch): Declare.
2014
2015 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2016
2017         * annotate.c (annotate_source_line): Change return type to void,
2018         update implementation to match.
2019         * annotate.h (annotate_source_line): Change return type to void,
2020         update header comment.
2021         * stack.c (print_frame_info): Don't change what frame information
2022         is printed based on whether annotations are on or not.
2023
2024 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2025
2026         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2027         (annotate_source): Make static.
2028         (annotate_source_line): Moved from source.c and renamed from
2029         identify_source_line.  Update the return type.
2030         * annotate.h (annotate_source): Delete declaration.
2031         (annotate_source_line): Declaration moved from source.h, and
2032         renamed from identify_source_line.  Return type updated.
2033         * source.c (identify_source_line): Moved to annotate.c and renamed
2034         to annotate_source_line.
2035         (info_line_command): Remove check of annotation_level.
2036         * source.h (identify_source_line): Move declaration to annotate.h
2037         and rename to annotate_source_line.
2038         * stack.c: Add 'annotate.h' include.
2039         (print_frame_info): Remove check of annotation_level before
2040         calling annotate_source_line.
2041
2042 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2043
2044         * source-cache.c (source_cache::get_plain_source_lines): Use
2045         open_source_file_with_line_charpos instead of just
2046         open_source_file, remove call to find_source_lines.
2047         (source_cache::get_source_lines): Likewise.
2048         * source.c (find_source_lines): Make static.
2049         (get_filename_and_charpos): Renamed into...
2050         (open_source_file_with_line_charpos): ..this along with changes to
2051         return a scoped_fd, and some other minor clean ups.
2052         (identify_source_line): Use open_source_file_with_line_charpos.
2053         (search_command_helper): Use open_source_file_with_line_charpos
2054         instead of just open_source_file, remove call to
2055         find_source_lines.
2056         * source.h (open_source_file_with_line_charpos): Declare new
2057         function.
2058         (find_source_lines): Delete declaration.
2059
2060 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2061
2062         * source.c (get_filename_and_charpos): Remove fullname
2063         parameter.
2064         (identify_source_line): Update call to get_filename_and_charpos.
2065
2066 2019-06-14  Tom Tromey  <tromey@adacore.com>
2067
2068         PR gdb/24502:
2069         * ui-style.h (skip_ansi_escape): Update comment.
2070         * ui-file.h (class no_terminal_escape_file): New class.
2071         * ui-file.c (no_terminal_escape_file::write)
2072         (no_terminal_escape_file::puts): New methods.
2073         * cli/cli-logging.c (handle_redirections): Use
2074         no_terminal_escape_file.
2075
2076 2019-06-14  Tom Tromey  <tromey@adacore.com>
2077
2078         * NEWS: Move convenience variable news above Python news.
2079
2080 2019-06-14  Tom Tromey  <tom@tromey.com>
2081
2082         * gnulib: Move directory to top-level.
2083         * configure.ac: Don't configure gnulib.
2084         * configure: Rebuild.
2085         * common/common-defs.h: Use new path to gnulib.
2086         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2087         (GNULIB_H): Remove.
2088         (INCGNU): Look in new gnulib location.
2089         (HFILES_NO_SRCDIR): Remove gnulib files.
2090         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2091         (generated_files): Remove GNULIB_H.
2092         ($(LIBGNU), all-lib): Remove targets.
2093         (distclean): Don't mention GNULIB_BUILDDIR.
2094         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2095
2096 2019-06-14  Tom Tromey  <tromey@adacore.com>
2097
2098         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2099         Warn if symbol file does not provide any symbols.
2100
2101 2019-06-14  Tom Tromey  <tromey@adacore.com>
2102
2103         * source.c (find_and_open_source): Respect basenames_may_differ.
2104
2105 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2106
2107         * annotate.c (annotate_breakpoints_invalid): Make use of
2108         scoped_restore_terminal_state.
2109         (annotate_frames_invalid): Likewise.
2110
2111 2019-06-14  Tom Tromey  <tromey@adacore.com>
2112
2113         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2114         allow assignment to an internalvar.
2115
2116 2019-06-14  Tom Tromey  <tromey@adacore.com>
2117
2118         * ada-lex.l: Allow "_" in attribute names.
2119
2120 2019-06-14  Tom Tromey  <tromey@adacore.com>
2121
2122         PR gdb/24653:
2123         * regcache.c (registers_changed): Don't call alloca.
2124         * top.c (execute_command): Don't call alloca.
2125
2126 2019-06-13  Pedro Alves  <palves@redhat.com>
2127
2128         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2129         'expression'.  When parsing an expression, error out if there's
2130         junk after "unlimited".
2131         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2132         (do_set_command): Adjust calls to is_unlimited_literal.
2133
2134 2019-06-13  Pedro Alves  <palves@redhat.com>
2135
2136         * compile/compile.c (make_compile_options_def_group): Add braces
2137         around array_view initializer.
2138         * thread.c (make_thread_apply_all_options_def_group)
2139         (make_thread_apply_all_options_def_group): Likewise.
2140
2141 2019-06-13  Pedro Alves  <palves@redhat.com>
2142
2143         * NEWS (New commands): Mention "maint test-options
2144         require-delimiter", "maint test-options unknown-is-error", "maint
2145         test-options unknown-is-operand" and "maint show
2146         test-options-completion-result".
2147         (New command options, command completion): New section.
2148         (Completion improvements): New section.
2149         Mention that you can abbreviate "unlimited".
2150
2151 2019-06-13  Pedro Alves  <palves@redhat.com>
2152
2153         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2154         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2155         * unittests/cli-utils-selftests.c (test_parse_flags)
2156         (test_parse_flags_qcs): Delete.
2157         (test_cli_utils): Don't call deleted functions.
2158
2159 2019-06-13  Pedro Alves  <palves@redhat.com>
2160
2161         * thread.c: Include "cli/cli-option.h".
2162         (tp_array_compar_ascending): Global.
2163         (tp_array_compar): Delete function.
2164         (tp_array_compar_ascending, tp_array_compar_descending): New
2165         functions.
2166         (ascending_option_def, qcs_flag_option_def)
2167         (thr_qcs_flags_option_defs)
2168         (make_thread_apply_all_options_def_group)
2169         (make_thread_apply_options_def_group): New.
2170         (thread_apply_all_command): Use gdb::option::process_options.
2171         (thread_apply_command_completer)
2172         (thread_apply_all_command_completer): New.
2173         (thread_apply_command): Use gdb::option::process_options.
2174         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2175         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2176         to generate help text of "thread apply".  Adjust "taas"'s help.
2177         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2178         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2179
2180 2019-06-13  Pedro Alves  <palves@redhat.com>
2181
2182         * thread.c (thread_apply_command): Check for invalid TID with
2183         isdigit instead of !isalpha.
2184
2185 2019-06-13  Pedro Alves  <palves@redhat.com>
2186
2187         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2188         (validate_flags_qcs): New.
2189         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2190         (validate_flags_qcs): Declare.
2191         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2192         (make_frame_apply_options_def_group): New.
2193         (frame_apply_command_count): Process options with
2194         gdb::option::process_options.
2195         (frame_apply_completer): New.
2196         (frame_apply_level_completer, frame_apply_all_completer)
2197         (frame_apply_completer): New.
2198         (_initialize_stack): Update help of "frame apply", "frame apply
2199         level", "frame apply all" and "faas" to mention supported options
2200         and install command completers.
2201         * stack.h (frame_apply_all_completer): Declare.
2202         * thread.c: Include "stack.h".
2203         (tfaas_command): Add "--".
2204         (_initialize_thread): Update help "tfaas" to mention supported
2205         options and install command completer.
2206
2207 2019-06-13  Pedro Alves  <palves@redhat.com>
2208
2209         * completer.c (complete_nested_command_line): New.
2210         (gdb_completion_word_break_characters_throw): Add assertion.
2211         * completer.h (complete_nested_command_line): Declare.
2212
2213 2019-06-13  Pedro Alves  <palves@redhat.com>
2214
2215         * stack.c (parse_backtrace_qualifiers): New.
2216         (backtrace_command): Use it.
2217         (backtrace_command_completer): Complete on qualifiers.
2218
2219 2019-06-13  Pedro Alves  <palves@redhat.com>
2220
2221         * frame.c: Include "cli/cli-option.h.
2222         (user_set_backtrace_options): New.
2223         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2224         Delete.
2225         (get_prev_frame): Adjust.
2226         (boolean_option_def, uinteger_option_def)
2227         (set_backtrace_option_defs): New.
2228         (_initialize_frame): Adjust and use
2229         gdb::option::add_setshow_cmds_for_options to install "set
2230         backtrace past-main" and "set backtrace past-entry".
2231         * frame.h: Include "cli/cli-option.h".
2232         (struct frame_print_options): Forward declare.
2233         (print_frame_arguments_all, print_frame_arguments_scalars)
2234         (print_frame_arguments_none): Declare.
2235         (print_entry_values): Delete declaration.
2236         (struct frame_print_options, user_frame_print_options): New.
2237         (struct set_backtrace_options): New.
2238         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2239         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2240         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2241         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2242         (list_args_or_locals): Add frame_print_options parameter.
2243         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2244         * python/py-framefilter.c (enumerate_args): Pass down
2245         USER_FRAME_PRINT_OPTIONS.
2246         * stack.c: Include "cli/cli-option.h".
2247         (print_frame_arguments_all, print_frame_arguments_scalars)
2248         (print_frame_arguments_none): Declare.
2249         (print_raw_frame_arguments, print_entry_values): Delete.
2250         (user_frame_print_options): New.
2251         (boolean_option_def, enum_option_def, frame_print_option_defs):
2252         New.
2253         (struct backtrace_cmd_options): New.
2254         (bt_flag_option_def): New.
2255         (backtrace_command_option_defs): New.
2256         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2257         (print_frame_arg, read_frame_arg, print_frame_args)
2258         (print_frame_info, print_frame): Add frame_print_options parameter
2259         and use it.
2260         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2261         (backtrace_command_1): Add frame_print_options and
2262         backtrace_cmd_options parameters and use them.
2263         (make_backtrace_options_def_group): New.
2264         (backtrace_command): Process command options with
2265         gdb::option::process_options.
2266         (backtrace_command_completer): New.
2267         (_initialize_stack): Extend "backtrace"'s help to mention
2268         supported options.  Install completer for "backtrace".
2269         Install some settings commands with add_setshow_cmds_for_options.
2270
2271 2019-06-13  Pedro Alves  <palves@redhat.com>
2272
2273         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2274         and that "set/show print raw frame-arguments" are now deprecated.
2275
2276         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2277         command.
2278         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2279         * stack.c (_initialize_stack): Install "set/show print
2280         raw-frame-arguments", and deprecate "set/show print raw
2281         frame-arguments".
2282         * valprint.c (_initialize_valprint): Deprecate "set/show print
2283         raw".
2284
2285 2019-06-13  Pedro Alves  <palves@redhat.com>
2286
2287         * compile/compile.c (struct compile_options): New.
2288         (compile_flag_option_def, compile_command_option_defs)
2289         (make_compile_options_def_group): New.
2290         (compile_file_command): Handle options with
2291         gdb::option::process_options.
2292         (compile_file_command_completer): New function.
2293         (compile_code_command): Handle options with
2294         gdb::option::process_options.
2295         (compile_code_command_completer): New function.
2296         (_initialize_compiler): Install completers for "compile code" and
2297         "compile file".  Mention available options in "compile code" and
2298         "compile code"'s help.
2299         * completer.c (advance_to_completion_word): New, factored out from
2300         ...
2301         (advance_to_expression_complete_word_point): ... this.
2302         (advance_to_filename_complete_word_point): New.
2303         * completer.h (advance_to_filename_complete_word_point): New
2304         declaration.
2305
2306 2019-06-13  Pedro Alves  <palves@redhat.com>
2307
2308         * compile/compile.c: Include "cli/cli-option.h".
2309         (compile_print_value): Scope data pointer is now a
2310         value_print_options pointer; adjust.
2311         (compile_print_command): Process options.  Scope data pointer is
2312         now a value_print_options pointer; adjust.
2313         (_initialize_compile): Update "compile print"'s help to include
2314         supported options.  Install a completer for "compile print".
2315         * cp-valprint.c (show_vtblprint, show_objectprint)
2316         (show_static_field_print): Delete.
2317         (_initialize_cp_valprint): Don't install "set print
2318         static-members", "set print vtbl", "set print object" here.
2319         * printcmd.c: Include "cli/cli-option.h" and
2320         "common/gdb_optional.h".
2321         (print_command_parse_format): Rework to fill in a
2322         value_print_options instead of a format_data.
2323         (print_value): Change parameter type from format_data pointer to
2324         value_print_options reference.  Adjust.
2325         (print_command_1): Process options.  Adjust to pass down a
2326         value_print_options.
2327         (print_command_completer): New.
2328         (_initialize_printcmd): Install print_command_completer as
2329         handle_brkchars completer for the "print" command.  Update
2330         "print"'s help to include supported options.
2331         * valprint.c: Include "cli/cli-option.h".
2332         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2333         here from cp-valprint.c.
2334         (boolean_option_def, uinteger_option_def)
2335         (value_print_option_defs, make_value_print_options_def_group):
2336         New.  Use gdb::option::add_setshow_cmds_for_options to install
2337         "set print elements", "set print null-stop", "set print repeats",
2338         "set print pretty", "set print union", "set print array", "set
2339         print address", "set print symbol", "set print array-indexes".
2340         * valprint.h: Include <string> and "cli/cli-option.h".
2341         (make_value_print_options_def_group): Declare.
2342         (print_value): Change parameter type from format_data pointer to
2343         value_print_options reference.
2344         (print_command_completer): Declare.
2345
2346 2019-06-13  Pedro Alves  <palves@redhat.com>
2347
2348         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2349         (COMMON_SFILES): Add maint-test-settings.c.
2350         * cli/cli-decode.c (boolean_enums): New global, factored out from
2351         ...
2352         (add_setshow_boolean_cmd): ... here.
2353         * cli/cli-decode.h (boolean_enums): Declare.
2354         * cli/cli-option.c: New file.
2355         * cli/cli-option.h: New file.
2356         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2357         factored out from ...
2358         (parse_cli_boolean_value(const char *)): ... this.
2359         (is_unlimited_literal): Change parameter type to pointer to
2360         pointer.  Adjust and advance ARG pointer.
2361         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2362         (parse_cli_var_enum): New, factored out from ...
2363         (do_set_command): ... this.  Adjust.
2364         * cli/cli-setshow.h (parse_cli_boolean_value)
2365         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2366         (parse_cli_var_enum): Declare.
2367         * cli/cli-utils.c: Include "cli/cli-option.h".
2368         (get_ulongest): New.
2369         * cli/cli-utils.h (get_ulongest): Declare.
2370         (check_for_argument): New overloads.
2371         * maint-test-options.c: New file.
2372
2373 2019-06-13  Pedro Alves  <palves@redhat.com>
2374
2375         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2376         parse a range if "-" is at the end of the string.
2377
2378 2019-06-13  Pedro Alves  <palves@redhat.com>
2379
2380         * cli/cli-setshow.c (parse_auto_binary_operation)
2381         (parse_cli_boolean_value): Don't allow "o".
2382
2383 2019-06-13  Pedro Alves  <palves@redhat.com>
2384
2385         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2386         * NEWS: Mention maint test-settings KIND.
2387         * maint-test-settings.c: New file.
2388
2389 2019-06-13  Pedro Alves  <palves@redhat.com>
2390
2391         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2392         completer.
2393         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2394         "set" completers.
2395
2396 2019-06-13  Pedro Alves  <palves@redhat.com>
2397
2398         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2399         after item.
2400
2401 2019-06-13  Pedro Alves  <palves@redhat.com>
2402
2403         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2404
2405 2019-06-13  Pedro Alves <palves@redhat.com>
2406
2407         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2408         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2409         call.
2410         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2411         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2412         calls.
2413         (check_for_argument): Skip spaces after argument.
2414
2415 2019-06-13  Pedro Alves  <palves@redhat.com>
2416
2417         * thread.c (thread_apply_command): Adjust TID parsing.
2418         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2419         detected before end of string.
2420         (tid_is_in_list): Error out if LIST is invalid.
2421
2422 2019-06-13  Pedro Alves  <palves@redhat.com>
2423
2424         * completer.c (complete_line_internal_1): Rewind completion word
2425         point.
2426         (completion_tracker::advance_custom_word_point_by): Change
2427         parameter type to int.
2428         * completer.h (completion_tracker::advance_custom_word_point_by):
2429         Likewise.
2430
2431 2019-06-13  Pedro Alves  <palves@redhat.com>
2432
2433         * completer.c (advance_to_completion_word): Handle delimiters.
2434
2435 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2436
2437         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2438
2439 2019-06-11  Tom Tromey  <tom@tromey.com>
2440
2441         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2442         (xmalloc_failed): Move to alloc.c.
2443         * alloc.c: New file.
2444         * Makefile.in (COMMON_SFILES): Add alloc.c.
2445
2446 2019-06-11  Tom Tromey  <tom@tromey.com>
2447
2448         * nat/linux-waitpid.c: Don't include server.h.
2449         (linux_debug): Remove.
2450         (my_waitpid): Update.
2451
2452 2019-06-11  Tom Tromey  <tromey@adacore.com>
2453
2454         * infcall.c (_initialize_infcall): Remove trailing newline from
2455         help.
2456         * user-regs.c (_initialize_user_regs): Remove trailing newline
2457         from help.
2458         * typeprint.c (_initialize_typeprint): Remove trailing newline
2459         from help.
2460         * reverse.c (_initialize_reverse): Remove trailing newlines from
2461         help.
2462         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2463         from help.
2464         * language.c (add_set_language_command): Remove trailing newline
2465         from help.
2466         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2467         help.
2468         * disasm.c (_initialize_disasm): Remove trailing newline from
2469         help.
2470         * top.c (init_main): Remove trailing newline from help.
2471         * interps.c (_initialize_interpreter): Remove trailing newline
2472         from help.
2473         * btrace.c (_initialize_btrace): Remove trailing newlines from
2474         help.
2475         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2476         from help.
2477         * python/python.c (_initialize_python): Remove trailing newline
2478         from help.
2479         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2480         help.
2481         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2482         from help.  Reformat some text.
2483         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2484         from help.
2485         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2486         newline from help.
2487
2488 2019-06-11  Tom Tromey  <tromey@adacore.com>
2489
2490         * darwin-nat.c (darwin_decode_exception_message)
2491         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2492
2493 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2494
2495         * valops.c (value_slice): Check for not allocated or not
2496         associated values.
2497
2498 2019-06-10  Tom de Vries  <tdevries@suse.de>
2499
2500         PR gdb/24618
2501         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2502         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2503         invalid.
2504
2505 2019-06-10  Tom de Vries  <tdevries@suse.de>
2506
2507         PR gdb/24611
2508         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2509         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2510
2511 2019-06-10  Tom de Vries  <tdevries@suse.de>
2512
2513         PR symtab/24545
2514         * symtab.c (struct demangled_name_entry): Add language field.
2515         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2516         static minimal symbol".  Set and use language field.
2517
2518 2019-06-10  Tom Tromey  <tromey@adacore.com>
2519
2520         * ada-lang.c (_initialize_ada_language): Update help text.
2521
2522 2019-06-10  Tom Tromey  <tromey@adacore.com>
2523
2524         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2525         with a newline.
2526         * guile/guile.c (handle_boot_error): Don't end warning with a
2527         newline.
2528         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2529         warning with a newline.
2530         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2531         newline.
2532         (s12z_frame_cache): Likewise.
2533         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2534         a newline.
2535         * solib-svr4.c (disable_probes_interface): Don't end warning with
2536         a newline.
2537         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2538         newline.
2539         * python/python.c (do_finish_initialization): Don't end warning
2540         with a newline.
2541
2542 2019-06-10  Tom Tromey  <tom@tromey.com>
2543
2544         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2545         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2546         gdbpy_enter.
2547
2548 2019-06-10  Tom Tromey  <tromey@adacore.com>
2549
2550         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2551         data.
2552         (elf_new_init): Don't call stabsread_new_init.
2553         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2554         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2555         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2556
2557 2019-06-10  Tom de Vries  <tdevries@suse.de>
2558
2559         PR symtab/16264
2560         PR symtab/24517
2561         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2562
2563 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2564
2565         * source.c (find_and_open_source): Also rewrite relative file
2566         names.
2567
2568 2019-04-26  Amos Bird  <amosbird@gmail.com>
2569
2570         * annotate.c (annotate_thread_exited): Add "thread-exited"
2571         annotation.
2572
2573 2019-06-06  Tom Tromey  <tromey@adacore.com>
2574
2575         * maint.h (class scoped_command_stats): Use
2576         DISABLE_COPY_AND_ASSIGN.
2577         <print_time>: New method.
2578         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2579         print_time.
2580         (scoped_command_stats::print_time): New method.
2581
2582 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2583
2584         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2585         instructions of lengths 6 or 8 bytes.
2586
2587 2019-06-04  Pedro Alves  <palves@redhat.com>
2588
2589         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2590
2591         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2592         * breakpoint.c (condition_completer): Likewise.
2593         * cli/cli-dump.c (scan_expression): Likewise.
2594         * common/filestuff.c (mkdir_recursive): Likewise.
2595         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2596         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2597         (gdb_abspath): Likewise.
2598         * compile/compile-cplus-types.c
2599         (compile_cplus_instance::decl_name): Likewise.
2600         * completer.c (complete_explicit_location):
2601         (signal_completer, reg_or_group_completer_1): Likewise.
2602         * cp-support.c (cp_remove_params_if_any): Likewise.
2603         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2604         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2605         * infcmd.c (strip_bg_char): Likewise.
2606         * linespec.c (copy_token_string): Likewise.
2607         * mi/mi-main.c (output_cores): Likewise.
2608         * psymtab.c (psymtab_search_name):
2609         * symfile.c (test_set_ext_lang_command): Likewise.
2610         * target.c (target_fileio_read_stralloc): Likewise.
2611         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2612         * value.c (complete_internalvar): Likewise.
2613
2614 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2615
2616         Add objfile property to gdb.Type.
2617         * NEWS: Mention Python API addition.
2618         * python/py-type.c (typy_get_objfile): New method.
2619
2620 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2621
2622         * NEWS: Mention the new set|show style [title|highlight].
2623         Mention changes to "show style", "help" and "apropos".
2624
2625 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2626
2627         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2628         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2629         instead of print_help_for_command.
2630         (print_doc_of_command): New function.
2631         (help_list): Add 'apropos -v word' suggestion.
2632         (print_help_for_command): Style the command name using title style.
2633         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2634         (_initialize_cli_cmds): Describe -v in apropos_command help.
2635
2636 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2637
2638         * cli/cli-style.h (cli_style_option): Add name in constructor,
2639         add m_name class member, add constructor with intensity,
2640         add name class function.
2641         (cli_style_option::add_setshow_commands): Remove name argument.
2642         (highlight_style, title_style): New styles.
2643         * cli/cli-style.c (do_show): New function that shows a style
2644         characteristic styling the style name with itself.
2645         (set_style_name): New function.
2646         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2647         Update all callers according to the changes in cli/cli-style.h.
2648         * utils.h (fputs_highlighted): New function.
2649         * utils.c (fputs_highlighted): Likewise.
2650
2651 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2652
2653         * NEWS: Mention new pipe command and new convenience variables.
2654
2655 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2656
2657         * cli/cli-cmds.c (pipe_command): New function.
2658         (_initialize_cli_cmds): Call add_com for pipe_command.
2659         Define | as an alias for pipe.
2660         (exit_status_set_internal_vars): New function.
2661         (shell_escape): Call exit_status_set_internal_vars.
2662         cli/cli-decode.c (find_command_name_length): Recognize | as
2663         a single character command.
2664
2665 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2666
2667         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2668         top.c (execute_command_to_ui_file): New function, mostly a copy
2669         of execute_command_to_string.
2670         (execute_command_to_string): Implement by calling
2671         execute_command_to_ui_file.
2672
2673 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2674
2675         * top.h (saved_command_line): Remove declaration.
2676         * top.c (previous_saved_command_line, previous_repeat_arguments):
2677         New variables.
2678         (saved_command_line): Make static, define together with other
2679         'repeat variables'.
2680         (dont_repeat): Clear repeat_arguments.
2681         (repeat_previous, get_saved_command_line, save_command_line):
2682         New functions.
2683         (gdb_init): Initialize saved_command_line
2684         and previous_saved_command_line.
2685         * main.c (captured_main_1): Remove saved_command_line initialization.
2686         * event-top.c (handle_line_of_input): Update to use
2687         the new 'repeat' related functions instead of direct access to
2688         saved_command_line.
2689         * command.h (repeat_previous, get_saved_command_line,
2690         save_command_line): New declarations.
2691         (dont_repeat): Add comment.
2692
2693 2019-05-30  Tom Tromey  <tromey@adacore.com>
2694
2695         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2696         Fix comment.
2697         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2698
2699 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2700
2701         PR cli/24587
2702         * completer.c (complete): Initialize variable word.
2703
2704 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2705
2706         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2707         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2708         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2709         'body' is NULL to the outter 'if', protecting the '!is_define'
2710         situation as well.
2711
2712 2019-05-29  Tom Tromey  <tromey@adacore.com>
2713
2714         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2715         (dwarf_unknown): New function.
2716         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2717         (dwarf_type_encoding_name): Use dwarf_unknown.
2718
2719 2019-05-29  Tom Tromey  <tromey@adacore.com>
2720
2721         PR c++/20020:
2722         * cp-valprint.c (cp_print_value_fields): Call
2723         cp_print_static_field inside "try".
2724
2725 2019-05-29  Tom Tromey  <tromey@adacore.com>
2726
2727         * inflow.c (struct terminal_info): Add default operator=.
2728         * configure: Rebuild.
2729         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2730         -Wdeprecated-copy-dtor, -Wredundant-move.
2731
2732 2019-05-29  Tom Tromey  <tromey@adacore.com>
2733
2734         * NEWS: Add entry.
2735         * infcmd.c (print_return_value_1): Handle finish_print
2736         option.
2737         (show_print_finish): New function.
2738         (_initialize_infcmd): Add "set/show print finish" commands.
2739         * valprint.c (user_print_options): Initialize new member.
2740         * valprint.h (struct value_print_options) <finish_print>: New
2741         member.
2742
2743 2019-05-28  Tom Tromey  <tromey@adacore.com>
2744
2745         * ada-lang.c (ada_remove_Xbn_suffix)
2746         (find_old_style_renaming_symbol)
2747         (parse_old_style_renaming): Remove.
2748         (ada_find_renaming_symbol): Don't call
2749         find_old_style_renaming_symbol.
2750         (ada_is_renaming_symbol): Rename from
2751         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2752         bool.  Now static.
2753         (ada_read_var_value): Update and simplify.
2754         * ada-exp.y (write_var_or_type): Remove old code.
2755
2756 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2757
2758         * event-top.c: Remove include comment.
2759         * inflow.c (class scoped_ignore_sigttou): Move from here...
2760         * inflow.h (class scoped_ignore_sigttou): ...to here.
2761         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2762         * top.c:  Remove include comment.
2763
2764 2019-05-27  Tom Tromey  <tom@tromey.com>
2765
2766         * NEWS: Fix typo.
2767
2768 2019-05-22  Tom Tromey  <tromey@adacore.com>
2769
2770         * target.c (target_follow_exec): Constify parameter.
2771         * target-delegates.c: Rebuild.
2772         * remote.c (remote_target::follow_exec): Constify parameter.
2773         * infrun.c (follow_exec): Constify parameter.
2774         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2775         (target_follow_exec): Likewise.
2776
2777 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2778
2779         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2780         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2781
2782 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2783
2784         * NEWS: Add debugredirect and testsuite sections.
2785
2786 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2787
2788         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2789         target descriptions using exclusively floating point register name
2790         aliases.
2791
2792 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2793
2794         PR gdb/18644:
2795         * f-lang.c (build_fortran_types): Handle the case where
2796         gdbarch_floatformat_for_type returns a nullptr.
2797
2798 2019-05-21  Tom de Vries  <tdevries@suse.de>
2799
2800         PR cli/24587
2801         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2802
2803 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2804
2805         PR gdb/18644:
2806         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2807         16-byte floats.
2808         * i386-tdep.c (i386_floatformat_for_type): Use
2809         floatformats_ia64_quad for the 16-byte floating point component
2810         within a fortran 32-byte complex number.
2811
2812 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2813
2814         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2815         delete default constructor.
2816         (find_partial_die): Update to return const struct.
2817         (partial_die_parent_scope): Move variable declaration into scope
2818         of its use and change its type to auto.
2819         (guess_partial_die_structure_name): Likewise.
2820         (partial_die_info::fixup): Likewise.
2821
2822 2019-05-17  Tom Tromey  <tromey@adacore.com>
2823
2824         * source.c (find_and_open_source): Remove cast.
2825
2826 2019-05-17  Tom Tromey  <tromey@adacore.com>
2827
2828         * annotate.c (annotate_source): Make "filename" const.
2829         * annotate.h (annotate_source): Use const.
2830
2831 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2832
2833         * disasm.c (set_disassembler_options): Send errors to stderr.
2834
2835 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2836
2837         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2838         (cli_interp_base::set_logging): Check debug_redirect.
2839         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2840         * cli/cli-logging.c (debug_redirect): Add static variable.
2841         (pop_output_files): Add default param.
2842         (handle_redirections): Print debug setting.
2843         (show_logging_command): Likewise.
2844         (_initialize_cli_logging): Add debugredirect command.
2845         * interps.c (current_interp_set_logging): Add debug_redirect
2846         parameter.
2847         * interps.h (set_logging): Add debug_redirect parameter.
2848         (current_interp_set_logging): Likewise.
2849         * mi/mi-common.h: Likewise.
2850         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2851
2852 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2853             Tom Tromey  <tromey@adacore.com>
2854
2855         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2856         directly.
2857         * cli/cli-interp.h (make_logging_output): Remove declaration.
2858         * cli/cli-logging.c (make_logging_output): Remove function.
2859         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2860         directly.
2861         * ui-file.c (tee_file::tee_file): Remove bools.
2862         (tee_file::~tee_file): Remove deletes.
2863         * ui-file.h (tee_file): Remove bools.
2864
2865 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2866
2867         * mi/mi-cmds.h (mi_cmd_complete): New function.
2868         * mi/mi-main.c (mi_cmd_complete): Likewise.
2869         * mi/mi-cmds.c: Define new MI command -complete.
2870         * NEWS: Mention new -complete command.
2871
2872 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2873
2874         * completer.h (complete): New function.
2875         * completer.c (complete): Likewise.
2876         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2877         function defined in completer.h.
2878
2879 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2880
2881         * MAINTAINERS (Write After Approval): Add myself.
2882
2883 2019-05-17  Tom de Vries  <tdevries@suse.de>
2884
2885         PR gdb/24094
2886         * dwarf2read.c (struct cu_partial_die_info): New struct.
2887         (find_partial_die): Return cu_partial_die_info.
2888         (partial_die_parent_scope, guess_partial_die_structure_name)
2889         (partial_die_info::fixup): Handle new return type of find_partial_die.
2890
2891 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2892
2893         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2894         "std::string", simplifying the algorithm.
2895
2896 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2897
2898         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2899         (stap_static_probe_ops::get_probes): Likewise.
2900
2901 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2902
2903         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2904         '-')" and "else if".
2905         (stap_parse_single_operand): Join checks for
2906         "gdbarch_stap_parse_special_token_p" and
2907         "gdbarch_stap_parse_special_token" in the same "if" statement.
2908         Invert check when verifying for operation on register
2909         displacement.
2910
2911 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2912
2913         * stap-probe.c (stap_get_opcode): Update comment.
2914         (stap_get_expected_argument_type): Likewise.
2915         (handle_stap_probe): Likewise.
2916
2917 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2918
2919         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2920         return type to 'bool'.  Adjust comment.  Use 'bool' when
2921         appropriate.
2922         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2923         * stap-probe.c (stap_parse_argument_1): Likewise.
2924         (stap_is_operator): Likewise.
2925         (stap_is_generic_prefix): Likewise.
2926         (stap_is_register_prefix): Likewise.
2927         (stap_is_register_indirection_prefix): Likewise.
2928         (stap_is_integer_prefix): Likewise.
2929         (stap_generic_check_suffix): Likewise.
2930         (stap_check_integer_suffix): Likewise.
2931         (stap_check_register_suffix): Likewise.
2932         (stap_check_register_indirection_suffix): Likewise.
2933         (stap_parse_register_operand): Likewise.
2934         (stap_parse_single_operand): Likewise.
2935         (stap_parse_argument_1): Likewise.
2936         (stap_probe::get_argument_count): Likewise.
2937         (stap_is_operator): Likewise.
2938
2939 2019-05-16  Tom Tromey  <tromey@adacore.com>
2940
2941         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2942         keyword to foreach.
2943
2944 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2945
2946         * linux-thread-db.c (try_thread_db_load_1): Change return type
2947         to bool.
2948         (try_thread_db_load): Likewise.
2949         (try_thread_db_load_from_pdir_1): Likewise.
2950         (try_thread_db_load_from_pdir): Likewise.
2951         (try_thread_db_load_from_sdir): Likewise.
2952         (try_thread_db_load_from_dir): Likewise.
2953         (thread_db_load_search): Likewise.
2954         (has_libpthread): Likewise.
2955         (thread_db_load): Likewise.
2956
2957 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2958
2959         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2960         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2961         NULL, and complain/return if that's the case.
2962
2963 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2964
2965         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2966         (advance, posn, abstract_read_memory): New functions.
2967         [struct mem_read_abstraction]: New struct.
2968         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2969
2970 2019-05-14  Tom Tromey  <tromey@adacore.com>
2971
2972         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2973         value is not lval_memory.
2974
2975 2019-05-14  Tom Tromey  <tromey@adacore.com>
2976
2977         * solib.c (info_sharedlibrary_command): Style the file name.
2978
2979 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2980
2981         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2982         (aarch64_vnv_type): Likewise.
2983         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2984         * common/tdesc.c: Likewise.
2985         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2986         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2987         * features/aarch64-fpu.xml: Add ieee half view.
2988         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2989         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2990         * gdbtypes.h (struct builtin_type): Likewise.
2991         (struct objfile_type): Likewise.
2992
2993 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2994
2995         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2996         typo.
2997         * location.h (string_to_event_location): Likewise.
2998
2999 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3000
3001         GDB 8.3 released.
3002
3003 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3004
3005         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3006         New variable declaration.
3007         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3008         New variable.
3009         (print_one_breakpoint): Use ui_out::test_flags and new global
3010         variable to compute use_fixed_output.
3011         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3012         Remove.
3013         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3014         (mi_multi_location_breakpoint_output_fixed): Remove.
3015         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3016         new variable.
3017         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3018         fix_multi_location_breakpoint_output flag if version >= 3.
3019         * ui-out.h (enum ui_out_flag)
3020         <fix_multi_location_breakpoint_output>: New enumerator.
3021
3022 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3023
3024         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3025
3026 2019-05-10  Tom Tromey  <tromey@adacore.com>
3027
3028         * ada-lang.c (catch_ada_completer): New function.
3029         (_initialize_ada_language): Use it.
3030
3031 2019-05-10  Tom Tromey  <tromey@adacore.com>
3032
3033         * thread.c (print_thread_info): Make "requested_threads" const.
3034         * gdbthread.h (print_thread_info): Make "requested_threads"
3035         const.
3036         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3037         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3038
3039 2019-05-08  Tom Tromey  <tom@tromey.com>
3040
3041         * gdbtypes.c (objfile_type_data): Change type.
3042         (objfile_type, _initialize_gdbtypes): Update.
3043
3044 2019-05-08  Tom Tromey  <tom@tromey.com>
3045
3046         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3047         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3048         (_initialize_dwarf2_frame): Update.
3049
3050 2019-05-08  Tom Tromey  <tom@tromey.com>
3051
3052         * objc-lang.c (objc_objfile_data): Change type.
3053         (find_methods): Update.
3054         (_initialize_objc_lang): Remove.
3055
3056 2019-05-08  Tom Tromey  <tom@tromey.com>
3057
3058         * stabsread.c (rs6000_builtin_type_data): Change type.
3059         (rs6000_builtin_type, _initialize_stabsread): Update.
3060
3061 2019-05-08  Tom Tromey  <tom@tromey.com>
3062
3063         * mips-tdep.c (mips_pdr_data): Remove.
3064         (_initialize_mips_tdep): Update.
3065
3066 2019-05-08  Tom Tromey  <tom@tromey.com>
3067
3068         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3069         (hppa_init_objfile_priv_data, read_unwind_info)
3070         (find_unwind_entry, _initialize_hppa_tdep): Update.
3071
3072 2019-05-08  Tom Tromey  <tom@tromey.com>
3073
3074         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3075         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3076         on obstack.
3077         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3078
3079 2019-05-08  Tom Tromey  <tom@tromey.com>
3080
3081         * mdebugread.c (basic_type_data): Change type.
3082         (basic_type, _initialize_mdebugread): Update.
3083
3084 2019-05-08  Tom Tromey  <tom@tromey.com>
3085
3086         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3087
3088 2019-05-08  Tom Tromey  <tom@tromey.com>
3089
3090         * nto-tdep.c (nto_inferior_data_reg): Change type.
3091         (nto_inferior_data): Update.
3092         (nto_inferior_data_cleanup, nto_new_inferior_data)
3093         (_initialize_nto_tdep): Remove.
3094         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3095
3096 2019-05-08  Tom Tromey  <tom@tromey.com>
3097
3098         * ada-lang.c (struct ada_inferior_data): Add initializers.
3099         (ada_inferior_data): Change type.
3100         (ada_inferior_data_cleanup): Remove.
3101         (get_ada_inferior_data, ada_inferior_exit)
3102         (struct ada_pspace_data): Add initializers, destructor.
3103         (ada_pspace_data_handle): Change type.
3104         (get_ada_pspace_data): Update.
3105         (ada_pspace_data_cleanup): Remove.
3106
3107 2019-05-08  Tom Tromey  <tom@tromey.com>
3108
3109         * coffread.c (struct coff_symfile_info): Add initializers.
3110         (coff_objfile_data_key): Move lower.  Change type.
3111         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3112         Update.
3113         (coff_free_info): Remove.
3114
3115 2019-05-08  Tom Tromey  <tom@tromey.com>
3116
3117         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3118         (fbsd_pspace_data_handle): Move lower.  Change type.
3119         (get_fbsd_pspace_data): Update.
3120         (fbsd_pspace_data_cleanup): Remove.
3121         (_initialize_fbsd_tdep): Update.
3122
3123 2019-05-08  Tom Tromey  <tom@tromey.com>
3124
3125         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3126         (get_ada_tasks_pspace_data): Update.
3127         (ada_tasks_pspace_data_cleanup): Remove.
3128         (_initialize_tasks): Update.
3129         (ada_tasks_inferior_data_handle): Change type.
3130         (get_ada_tasks_inferior_data): Update.
3131         (ada_tasks_inferior_data_cleanup): Remove.
3132         (struct ada_tasks_pspace_data): Add initializers.
3133
3134 2019-05-08  Tom Tromey  <tom@tromey.com>
3135
3136         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3137         * symfile-debug.c (debug_sym_get_probes): Change type.
3138         * stap-probe.c (handle_stap_probe):
3139         (stap_static_probe_ops::get_probes): Change type.
3140         * probe.h (class static_probe_ops) <get_probes>: Change type.
3141         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3142         (parse_probes_in_pspace): Update.
3143         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3144         Update.
3145         (any_static_probe_ops::get_probes): Change type.
3146         * elfread.c (elfread_data): New typedef.
3147         (probe_key): Change type.
3148         (elf_get_probes): Likewise.  Update.
3149         (probe_key_free): Remove.
3150         (_initialize_elfread): Update.
3151         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3152         Change type.
3153         (dtrace_process_dof_probe, dtrace_process_dof)
3154         (dtrace_static_probe_ops::get_probe): Change type.
3155
3156 2019-05-08  Tom Tromey  <tom@tromey.com>
3157
3158         * xcoffread.c (struct xcoff_symfile_info): Rename from
3159         coff_symfile_info.  Add initializers.
3160         (xcoff_objfile_data_key): Move lower.  Change type.
3161         (XCOFF_DATA): Rewrite.
3162         (xcoff_free_info): Remove.
3163         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3164         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3165         (xcoff_initial_scan): Update.
3166
3167 2019-05-08  Tom Tromey  <tom@tromey.com>
3168
3169         * solib-svr4.c (struct svr4_info): Add initializers and
3170         destructor.
3171         <probes_table>: Now an htab_up.
3172         (solib_svr4_pspace_data): Change type.
3173         (free_probes_table): Simplify.
3174         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3175         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3176         (probes_table_remove_objfile_probes, register_solib_event_probe)
3177         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3178         (_initialize_svr4_solib): Update.
3179
3180 2019-05-08  Tom Tromey  <tom@tromey.com>
3181
3182         * remote.c (remote_pspace_data): Change type.
3183         (remote_pspace_data_cleanup): Remove.
3184         (get_remote_exec_file, set_pspace_remote_exec_file)
3185         (_initialize_remote): Update.
3186
3187 2019-05-08  Tom Tromey  <tom@tromey.com>
3188
3189         * breakpoint.c (breakpoint_objfile_key): Change type.
3190         (get_breakpoint_objfile_data): Update.
3191         (free_breakpoint_objfile_data): Remove.
3192         (_initialize_breakpoint): Update.
3193
3194 2019-05-08  Tom Tromey  <tom@tromey.com>
3195
3196         * linux-tdep.c (struct linux_info): Add initializers.
3197         (linux_inferior_data): Move.  Change type.
3198         (invalidate_linux_cache_inf): Update.
3199         (linux_inferior_data_cleanup): Remove.
3200         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3201
3202 2019-05-08  Tom Tromey  <tom@tromey.com>
3203
3204         * auxv.c (auxv_inferior_data): Move.  Change type.
3205         (auxv_inferior_data_cleanup): Remove.
3206         (invalidate_auxv_cache_inf): Rewrite.
3207         (get_auxv_inferior_data, _initialize_auxv): Update.
3208
3209 2019-05-08  Tom Tromey  <tom@tromey.com>
3210
3211         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3212         (symfile_debug_objfile_data_key): Change type.
3213         (symfile_debug_installed, debug_qf_has_symbols)
3214         (debug_qf_find_last_source_symtab)
3215         (debug_qf_forget_cached_source_info)
3216         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3217         (debug_qf_print_stats, debug_qf_dump)
3218         (debug_qf_expand_symtabs_for_function)
3219         (debug_qf_expand_all_symtabs)
3220         (debug_qf_expand_symtabs_with_fullname)
3221         (debug_qf_map_matching_symbols)
3222         (debug_qf_expand_symtabs_matching)
3223         (debug_qf_find_pc_sect_compunit_symtab)
3224         (debug_qf_map_symbol_filenames)
3225         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3226         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3227         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3228         (debug_sym_read_linetable, debug_sym_relocate): Update.
3229         (symfile_debug_free_objfile): Remove.
3230         (install_symfile_debug_logging, _initialize_symfile_debug):
3231         Update.
3232
3233 2019-05-08  Tom Tromey  <tom@tromey.com>
3234
3235         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3236         allocate_on_obstack.
3237         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3238         (get_dwarf2_per_objfile): Update.
3239         (set_dwarf2_per_objfile): Remove.
3240         (dwarf2_has_info, dwarf2_get_section_info): Update.
3241         (dwarf2_free_objfile): Remove.
3242         (_initialize_dwarf2_read): Update.
3243
3244 2019-05-08  Tom Tromey  <tom@tromey.com>
3245
3246         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3247         initializers.
3248         <unsupported_script_warning_printed,
3249         script_not_found_warning_printed>: Now bool.
3250         (auto_load_pspace_data): Change type.
3251         (~auto_load_pspace_info): Rename from
3252         auto_load_pspace_data_cleanup.
3253         (get_auto_load_pspace_data, init_loaded_scripts_info)
3254         (clear_section_scripts, maybe_print_unsupported_script_warning)
3255         (maybe_print_script_not_found_warning, _initialize_auto_load):
3256         Update.
3257
3258 2019-05-08  Tom Tromey  <tom@tromey.com>
3259
3260         * objfiles.c (objfile_pspace_info): Add destructor and
3261         initializers.
3262         (objfiles_pspace_data): Change type.
3263         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3264         (get_objfile_pspace_data): Update.
3265         (objfiles_bfd_data): Change type.
3266         (get_objfile_bfd_data): Update.
3267         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3268
3269 2019-05-08  Tom Tromey  <tom@tromey.com>
3270
3271         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3272         Change type.
3273         (get_catch_syscall_inferior_data): Update.
3274         (catch_syscall_inferior_data_cleanup): Remove.
3275         (_initialize_break_catch_syscall): Update.
3276
3277 2019-05-08  Tom Tromey  <tom@tromey.com>
3278
3279         * inflow.c (struct terminal_info): Add destructor and
3280         initializers.
3281         (inflow_inferior_data): Change type.
3282         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3283         (get_inflow_inferior_data, inflow_inferior_exit)
3284         (swap_terminal_info, _initialize_inflow): Update.
3285
3286 2019-05-08  Tom Tromey  <tom@tromey.com>
3287
3288         * target-dcache.c (target_dcache_cleanup): Remove.
3289         (target_dcache_aspace_key): Change type.
3290         (target_dcache_init_p, target_dcache_invalidate)
3291         (target_dcache_get, target_dcache_get_or_init)
3292         (_initialize_target_dcache): Update.
3293         * dcache.h (struct dcache_deleter): New.
3294
3295 2019-05-08  Tom Tromey  <tom@tromey.com>
3296
3297         * symtab.c (struct symbol_cache): Add destructor and
3298         initializers.
3299         (symbol_cache_key): Move.  Change type.
3300         (make_symbol_cache, free_symbol_cache): Remove.
3301         (get_symbol_cache): Update.
3302         (symbol_cache_cleanup): Remove.
3303         (ALL_PSPACES, symbol_cache_flush)
3304         (maintenance_print_symbol_cache)
3305         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3306         Update.
3307
3308 2019-05-08  Tom Tromey  <tom@tromey.com>
3309
3310         * symtab.c (struct main_info): Add destructor and initializers.
3311         (main_progspace_key): Move.  Change type.
3312         (get_main_info): Update.
3313         (main_info_cleanup): Remove.
3314         (_initialize_symtab): Update.
3315
3316 2019-05-08  Tom Tromey  <tom@tromey.com>
3317
3318         * registry.h (DECLARE_REGISTRY): Define the _key class.
3319
3320 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3321
3322         * NEWS: Merge two 'New commands' sections.
3323
3324 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3325
3326         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3327         parameter and use Ada language definition instead.
3328         (ada_val_print_ptr): Remove unused language parameter.
3329         (ada_val_print_num): Remove language parameter and use Ada language
3330         definition instead.
3331         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3332         parameter.
3333         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3334         parameter and use Ada language definition instead.
3335         (ada_val_print_1): Update all ada_val_print_xxx calls.
3336         Remove language parameter.
3337         (ada_val_print): Update ada_val_print_1 call.
3338
3339 2019-05-08  Tom Tromey  <tromey@adacore.com>
3340
3341         * remote.c (remote_hw_watchpoint_limit)
3342         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3343         Now static.
3344
3345 2019-05-08  Tom Tromey  <tromey@adacore.com>
3346
3347         * maint.c (_initialize_maint_cmds): Move initialization code to
3348         remote.c.
3349         (watchdog, show_watchdog): Move to remote.c.
3350         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3351         "watchdog" static.
3352         (_initialize_remote): Move initialization code from maint.c.
3353         * defs.h (watchdog): Don't declare.
3354
3355 2019-05-08  Tom Tromey  <tromey@adacore.com>
3356
3357         * tui/tui-interp.c: Include main.h.
3358         * interps.c: Include main.h.
3359         * main.h (interpreter_p): Declare.
3360         * defs.h (interpreter_p): Don't declare.
3361
3362 2019-05-08  Tom Tromey  <tromey@adacore.com>
3363
3364         * dwarf2loc.c: Include dwarf2read.h.
3365         * defs.h (read_unsigned_leb128): Don't declare.
3366         * dwarf2read.h (read_unsigned_leb128): Declare.
3367
3368 2019-05-08  Tom Tromey  <tromey@adacore.com>
3369
3370         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3371         method.
3372
3373 2019-05-08  Tom Tromey  <tromey@adacore.com>
3374
3375         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3376         when no wrap column is set.
3377
3378 2019-05-08  Tom Tromey  <tromey@adacore.com>
3379
3380         * c-lang.c (c_get_string): Handle non-C-style arrays.
3381
3382 2019-05-08  Tom Tromey  <tromey@adacore.com>
3383
3384         * typeprint.c (print_offset_data::update): Print the bit offset,
3385         not the number of bits remaining.
3386
3387 2019-05-08  Tom Tromey  <tromey@adacore.com>
3388
3389         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3390         padding at end of comment.
3391
3392 2019-05-08  Tom Tromey  <tromey@adacore.com>
3393
3394         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3395         Compare main types.
3396
3397 2019-05-06  Tom Tromey  <tom@tromey.com>
3398
3399         * common/scoped_mmap.c: Include common-defs.h.
3400         * common/scoped_mmap.h: Don't include config.h.
3401
3402 2019-05-04  Tom Tromey  <tom@tromey.com>
3403
3404         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3405         (struct aarch64_call_info): Add initializers.
3406         <si>: Now a std::vector.
3407         (pass_on_stack, aarch64_push_dummy_call): Update.
3408
3409 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3410             Tom Tromey  <tom@tromey.com>
3411
3412         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3413         (ppc_threads): Now a std::vector.  Now static.
3414         (hwdebug_find_thread_points_by_tid)
3415         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3416         Update.
3417
3418 2019-05-04  Tom Tromey  <tom@tromey.com>
3419
3420         * arc-tdep.c (arc_tdesc_init): Return bool.
3421
3422 2019-05-04  Tom Tromey  <tom@tromey.com>
3423
3424         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3425         Use gdb_assert_not_reached.
3426
3427 2019-05-04  Tom Tromey  <tom@tromey.com>
3428
3429         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3430         "false".
3431
3432 2019-05-04  Tom Tromey  <tom@tromey.com>
3433
3434         * arc-tdep.c (arc_tdesc_init): Use bool.
3435
3436 2019-05-04  Tom Tromey  <tom@tromey.com>
3437
3438         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3439
3440 2019-05-04  Tom Tromey  <tom@tromey.com>
3441
3442         * cli/cli-cmds.c (valid_command_p): Return bool.
3443
3444 2019-05-04  Tom Tromey  <tom@tromey.com>
3445
3446         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3447         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3448
3449 2019-05-04  Raul Tambre  <raul@tambre.ee>
3450
3451         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3452         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3453         operator for comparison.
3454
3455 2019-05-04  Tom Tromey  <tom@tromey.com>
3456
3457         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3458         (lookup_partial_symbol, print_partial_symbols)
3459         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3460         (psymbol_compare): Update.
3461         (add_psymbol_to_bcache): Clear the entire psymbol.
3462         (maintenance_check_psymtabs): Update.
3463         * psympriv.h (struct partial_symbol): Don't derive from
3464         general_symbol_info.
3465         <obj_section, unrelocated_address, address,
3466         set_unrelocated_address>: Update.
3467         <ginfo>: New member.
3468         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3469         (debug_names::write_psymbols): Update.
3470
3471 2019-05-04  Tom de Vries  <tdevries@suse.de>
3472
3473         * contrib/cc-with-tweaks.sh: Support -n arg.
3474
3475 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3476
3477         * corelow.c (core_target::detach): Ensure frame cache and
3478         register caches are cleared.
3479         inferior.c (exit_inferior_1): Likewise.
3480
3481 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3482             Tom Tromey  <tom@tromey.com>
3483
3484         * dictionary.c (collate_pending_symbols_by_language): Remove
3485         "struct" from foreach.
3486         * symtab.c (lookup_global_symbol_from_objfile)
3487         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3488         foreach.
3489         * ser-tcp.c (net_open): Remove "struct" from foreach.
3490         * objfiles.c (objfile_relocate, objfile_rebase)
3491         (objfile_has_symbols): Remove "struct" from foreach.
3492         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3493         from foreach.
3494         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3495         foreach.
3496         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3497         "struct" from foreach.
3498         * ada-lang.c (create_excep_cond_exprs)
3499         (ada_exception_catchpoint_cond_string): Remove "struct" from
3500         foreach.
3501
3502 2019-05-03  Tom Tromey  <tromey@adacore.com>
3503
3504         * ada-exp.y (convert_char_literal): Check suffix of each
3505         enumerator.
3506
3507 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3508
3509         PR ada/21406:
3510         * ada-exp.y (yywrap): Don't define.
3511         * ada-lex.l (%option): Add noyywrap
3512         (yywrap): Remove.
3513
3514 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3515
3516         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3517         _WIN32_WINNT to the XP level, unless already defined to a higher
3518         level.
3519
3520         * unittests/parse-connection-spec-selftests.c:
3521         * ser-tcp.c:
3522         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3523         override.
3524
3525         * symfile.c (find_separate_debug_file): Remove colon from the
3526         drive spec of DOS/Windows file names of the target, so that the
3527         file name produced from DEBUGDIR and the target's directory will
3528         be valid on DOS/Windows systems.
3529
3530 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3531
3532         * rust-lang.c (val_print_struct): Handle printing structures
3533         containing strings.
3534
3535 2019-05-02  Tom Tromey  <tromey@adacore.com>
3536
3537         * valarith.c (_initialize_valarith): Remove.
3538
3539 2019-05-01  Tom Tromey  <tromey@adacore.com>
3540
3541         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3542         bitfields.
3543
3544 2019-05-01  Tom Tromey  <tromey@adacore.com>
3545
3546         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3547         for big-endian copies.
3548
3549 2019-04-30  Ali Tamur  <tamur@google.com>
3550         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3551         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3552         (read_3_bytes): New function.
3553
3554 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3555
3556         * windows-nat.c (main_thread_id): Delete.
3557         (handle_output_debug_string): Replace main_thread_id by
3558         current_event.dwThreadId.
3559         (fake_create_process): Likewise.
3560         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3561         Do not set main_thread_id.
3562         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3563         current_event.dwThreadId.
3564         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3565
3566 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3567
3568         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3569         Use current_event.dwThreadId instead of main_thread_id.
3570
3571 2019-04-30  Tom Tromey  <tromey@adacore.com>
3572
3573         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3574         (create_excep_cond_exprs): Iterate over program spaces.
3575         (ada_exception_catchpoint_cond_string): Examine all minimal
3576         symbols for exception types.
3577
3578 2019-04-30  Tom Tromey  <tromey@adacore.com>
3579
3580         PR c++/24470:
3581         * dwarf2read.c (process_structure_scope): Handle case where type
3582         has template parameters but no symbol was created.
3583
3584 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3585             Chris January  <chris.january@arm.com>
3586
3587         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3588         qualifier.
3589         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3590
3591 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3592
3593         * f-typeprint.c (f_print_type): Update rules for printing
3594         whitespace.
3595         (f_type_print_varspec_suffix): Likewise.
3596
3597 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3598             Chris January  <chris.january@arm.com>
3599
3600         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3601         function arguments.
3602
3603 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3604
3605         * f-lang.c (build_fortran_types): Change name of void type to
3606         lower case.
3607         * f-typeprint.c (f_type_print_base): Print the name of the void
3608         type, rather than a fixed string.
3609         * f-valprint.c (f_decorations): Use lower case void string.
3610
3611 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3612             Chris January  <chris.january@arm.com>
3613
3614         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3615         types for Fortran.
3616
3617 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3618             Chris January  <chris.january@arm.com>
3619             David Lecomber  <david.lecomber@arm.com>
3620
3621         * f-exp.y (BINOP_INTRINSIC): New token.
3622         (exp): New parser rule handling BINOP_INTRINSIC.
3623         (f77_keywords): Add new builtin procedures.
3624         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3625         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3626         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3627         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3628         (print_unop_subexp_f): New function.
3629         (print_binop_subexp_f): New function.
3630         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3631         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3632         (dump_subexp_body_f): Likewise.
3633         (operator_check_f): Likewise.
3634         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3635         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3636
3637 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3638
3639         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3640         UNOP_KIND.
3641         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3642         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3643         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3644         (operator_length_f): New fuction.
3645         (print_subexp_f): New function.
3646         (op_name_f): New function.
3647         (dump_subexp_body_f): New function.
3648         (operator_check_f): New function.
3649         (exp_descriptor_f): Replace standard expression handling functions
3650         with new functions.
3651         * gdb/fortran-operator.def: New file.
3652         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3653         * gdb/std-operator.def: Remove UNOP_KIND.
3654
3655 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3656
3657         * std-operator.def: Remove unbalanced, stray double quote
3658         character.
3659
3660 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3661             Chris January  <chris.january@arm.com>
3662             Daniel Everett  <daniel.everett@arm.com>
3663             Nick Forrington  <nick.forrington@arm.com>
3664             Richard Bunt  <richard.bunt@arm.com>
3665
3666         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3667         of depth when printing anonymous structs or unions.
3668         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3669         Don't print either the top-level value, or the children if the
3670         max-depth is exceeded.
3671         (ppscm_print_children): When printing the key of a map, allow one
3672         extra level of depth.
3673         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3674         print either the top-level value, or the children if the max-depth
3675         is exceeded.
3676         (print_children): When printing the key of a map, allow one extra
3677         level of depth.
3678         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3679         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3680         (user_print_options): Initialise max_depth field.
3681         (val_print_scalar_or_string_type_p): New function.
3682         (val_print): Check to see if the max depth has been reached.
3683         (val_print_check_max_depth): Define new function.
3684         (show_print_max_depth): New function.
3685         (_initialize_valprint): Add 'print max-depth' option.
3686         * valprint.h (struct value_print_options) <max_depth>: New field.
3687         (val_print_check_max_depth): Declare new function.
3688         * NEWS: Document new feature.
3689
3690 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3691
3692         * ada-lang.c (ada_language_defn): Initialise new field.
3693         * c-lang.c (c_is_string_type_p): New function.
3694         (c_language_defn): Initialise new field.
3695         (cplus_language_defn): Initialise new field.
3696         (asm_language_defn): Initialise new field.
3697         (minimal_language_defn): Initialise new field.
3698         * c-lang.h (c_is_string_type_p): Declare new function.
3699         * d-lang.c (d_language_defn): Initialise new field.
3700         * f-lang.c (f_is_string_type_p): New function.
3701         (f_language_defn): Initialise new field.
3702         * go-lang.c (go_is_string_type_p): New function.
3703         (go_language_defn): Initialise new field.
3704         * language.c (default_is_string_type_p): New function.
3705         (unknown_language_defn): Initialise new field.
3706         (auto_language_defn): Initialise new field.
3707         * language.h (struct language_defn) <la_is_string_type_p>: New
3708         member variable.
3709         (default_is_string_type_p): Declare new function.
3710         * m2-lang.c (m2_language_defn): Initialise new field.
3711         * objc-lang.c (objc_language_defn): Initialise new field.
3712         * opencl-lang.c (opencl_language_defn): Initialise new field.
3713         * p-lang.c (pascal_is_string_type_p): New function.
3714         (pascal_language_defn): Initialise new field.
3715         * rust-lang.c (rust_is_string_type_p): New function.
3716         (rust_language_defn): Initialise new field.
3717
3718 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3719
3720         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3721         New field.
3722         * ada-lang.c (ada_language_defn): Initialise new field.
3723         * c-lang.c (c_language_defn): Likewise.
3724         (cplus_language_defn): Likewise.
3725         (asm_language_defn): Likewise.
3726         (minimal_language_defn): Likewise.
3727         * d-lang.c (d_language_defn): Likewise.
3728         * f-lang.c (f_language_defn): Likewise.
3729         * go-lang.c (go_language_defn): Likewise.
3730         * language.c (unknown_language_defn): Likewise.
3731         (auto_language_defn): Likewise.
3732         * m2-lang.c (m2_language_defn): Likewise.
3733         * objc-lang.c (objc_language_defn): Likewise.
3734         * opencl-lang.c (opencl_language_defn): Likewise.
3735         * p-lang.c (pascal_language_defn): Likewise.
3736         * rust-lang.c (rust_language_defn): Likewise.
3737
3738 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3739
3740         * ada-lang.c (ada_is_character_type): Change return type to bool.
3741         (ada_is_string_type): Likewise.
3742         * ada-lang.h (ada_is_character_type): Update declaration
3743         (ada_is_string_type): Likewise.
3744
3745 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3746
3747         Support style in 'frame|thread apply'
3748
3749         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3750         * record.c (record_start, record_stop): Update callers of
3751         execute_command_to_string with false.
3752         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3753         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3754         methods.
3755         (class string_file): New constructor with term_out parameter.
3756         Override methods term_out and can_emit_style_escape.  New member
3757         term_out.
3758         (class stdio_file): Override can_emit_style_escape.
3759         (class tee_file): Override term_out and can_emit_style_escape.
3760         * utils.h (can_emit_style_escape): Remove.
3761         * utils.c (can_emit_style_escape): Likewise.
3762         Update all callers of can_emit_style_escape (SOMESTREAM) to
3763         SOMESTREAM->can_emit_style_escape.
3764         * source-cache.c (source_cache::get_source_lines): Likewise.
3765         * stack.c (frame_apply_command_count): Call execute_command_to_string
3766         passing the term_out characteristic of the current gdb_stdout.
3767         * thread.c (thr_try_catch_cmd): Likewise.
3768         * top.c (execute_command_to_string): pass term_out parameter
3769         to construct the string_file for the command output.
3770         * ui-file.c (term_cli_styling): New function (most code moved
3771         from utils.c can_emit_style_escape).
3772         (string_file::string_file, string_file::can_emit_style_escape,
3773         stdio_file::can_emit_style_escape, tee_file::term_out,
3774         tee_file::can_emit_style_escape): New functions.
3775
3776 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3777
3778         * NEWS: Mention the new set|show may-call-functions.
3779         * infcall.c (may_call_functions_p): New variable.
3780         (show_may_call_functions_p): New function.
3781         (call_function_by_hand_dummy): Throws an error if not
3782         may-call-functions.
3783         (_initialize_infcall): Call add_setshow_boolean_cmd for
3784         may-call-functions.
3785
3786 2019-04-25  Keith Seitz  <keiths@redhat.com>
3787
3788         PR c++/24367
3789         * cp-support.c (inspect_type): Don't attempt substitutions
3790         of symbol with the same name.
3791
3792 2019-04-25  Tom Tromey  <tromey@adacore.com>
3793
3794         PR gdb/24475:
3795         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3796         static.
3797
3798 2019-04-25  Tom Tromey  <tromey@adacore.com>
3799
3800         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3801         rvalue reference.
3802         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3803         (gdb_xml_parser::parse): Use std::move.
3804         * python/python-internal.h (gdbpy_convert_exception): Take a const
3805         reference.
3806         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3807         std::move.
3808         * python/py-utils.c (gdbpy_convert_exception): Take a const
3809         reference.
3810         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3811         Use std::move.
3812         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3813         Use std::move.
3814         * mi/mi-main.c (mi_print_exception): Take a const reference.
3815         * main.c (handle_command_errors): Take a const reference.
3816         * linespec.c (parse_linespec): Use std::move.
3817         * infcall.c (run_inferior_call): Use std::move.
3818         (call_function_by_hand_dummy): Use std::move.
3819         * exec.c (try_open_exec_file): Use std::move.
3820         * exceptions.h (exception_print, exception_fprintf)
3821         (exception_print_same): Update.
3822         * exceptions.c (print_exception, exception_print)
3823         (exception_fprintf, exception_print_same): Change parameters to
3824         const reference.
3825         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3826         * common/new-op.c: Use std::move.
3827         * common/common-exceptions.h (struct gdb_exception): Add move
3828         constructor.
3829         (struct gdb_exception_error, struct gdb_exception_quit, struct
3830         gdb_quit_bad_alloc): Change constructor to move constructor.
3831         (throw_exception): Change parameter to rvalue reference.
3832         * common/common-exceptions.c (throw_exception): Take rvalue
3833         reference.
3834         * cli/cli-interp.c (safe_execute_command): Use std::move.
3835         * breakpoint.c (insert_bp_location, location_to_sals): Use
3836         std::move.
3837
3838 2019-04-25  Tom Tromey  <tromey@adacore.com>
3839
3840         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3841         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3842         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3843         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3844         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3845         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3846         guile/scm-value.c: Use unpack.
3847         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3848         gdbscm_gdb_exception.
3849         (gdbscm_throw_gdb_exception): Likewise.
3850         (struct gdbscm_gdb_exception): New.
3851         (unpack): New function.
3852         (gdbscm_wrap): Use unpack.
3853
3854 2019-04-25  Tom Tromey  <tromey@adacore.com>
3855
3856         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3857         (gdb_rl_callback_handler): Use std::move.
3858         * common/common-exceptions.h (struct gdb_exception): Add move
3859         assignment operator.
3860         (throw_exception_sjlj): Change "exception" to const reference.
3861         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3862         (throw_exception_sjlj): Change "exception" to const reference.
3863
3864 2019-04-25  Tom Tromey  <tromey@adacore.com>
3865
3866         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3867         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3868         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3869         Update.
3870         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3871         Update.
3872         * mi/mi-interp.c (mi_interp::exec): Update.
3873         * linespec.c (parse_linespec): Update.
3874         * infcall.c (run_inferior_call): Update.
3875         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3876         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3877         (gdbscm_lookup_global_symbol): Update.
3878         * guile/scm-param.c (gdbscm_parameter_value): Update.
3879         * guile/scm-frame.c (gdbscm_frame_read_register)
3880         (gdbscm_frame_read_var): Update.
3881         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3882         * exec.c (try_open_exec_file): Update.
3883         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3884         (gdb_rl_callback_handler): Update.
3885         * common/common-exceptions.h (exception_none): Don't declare.
3886         * common/common-exceptions.c (exception_none): Don't define.
3887         (struct catcher) <exception>: Update.
3888         * cli/cli-interp.c (safe_execute_command): Update.
3889         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3890
3891 2019-04-25  Ali Tamur  <tamur@google.com>
3892
3893         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3894         (read_attribute_value): Likewise.
3895         (dwarf2_read_addr_index): Update comment.
3896         (read_str_index): Add DW_FORM_strx.
3897         (dwarf2_string_attr): Likewise.
3898         (dwarf2_const_value_attr): Likewise.
3899         (dump_die_shallow): Likewise.
3900         (dwarf2_fetch_constant_bytes): Likewise.
3901         (skip_form_bytes): Likewise.
3902         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3903
3904 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3905
3906         PR corefiles/11608
3907         PR corefiles/18187
3908         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3909         OFFSET.  Verify if current mapping contains an ELF header.
3910         (linux_find_memory_regions_full): Adjust call to
3911         dump_mapping_p.
3912
3913 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3914             Kang Li <kanglictf@gmail.com>
3915
3916         PR gdb/21600
3917
3918         * dwarf2-frame.c (read_initial_length): Be consistent about using
3919         unsigned representation of length.
3920         (decode_frame_entry_1): Likewise.  Check for wraparound of
3921         end pointer as well as buffer overflow.
3922
3923 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3924
3925         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3926         "vq".
3927
3928 2019-04-24  Tom Tromey  <tromey@adacore.com>
3929
3930         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3931
3932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3933
3934         * s12z-tdep.c (s12z_unwind_pc): Delete.
3935         (s12z_unwind_sp): Delete.
3936         (s12z_gdbarch_init): Don't register deleted functions with
3937         gdbarch.
3938
3939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3940
3941         * rl78-tdep.c (rl78_unwind_sp): Delete.
3942         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3943
3944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3945
3946         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3947         (xstormy16_unwind_pc): Delete.
3948         (xstormy16_dummy_id): Delete.
3949         (xstormy16_gdbarch_init): Don't register deleted functions with
3950         gdbarch.
3951
3952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3953
3954         * vax-tdep.c (vax_unwind_pc): Delete.
3955         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3956
3957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3958
3959         * v850-tdep.c (v850_unwind_sp): Delete.
3960         (v850_unwind_pc): Delete.
3961         (v850_dummy_id): Delete.
3962         (v850_gdbarch_init): Don't register deleted functions with
3963         gdbarch.
3964
3965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3966
3967         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3968         (tilegx_unwind_pc): Delete.
3969         (tilegx_unwind_dummy_id): Delete.
3970         (tilegx_gdbarch_init): Don't register deleted functions with
3971         gdbarch.
3972
3973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3974
3975         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3976         (tic6x_dummy_id): Delete.
3977         (tic6x_gdbarch_init): Don't register deleted functions with
3978         gdbarch.
3979
3980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3981
3982         * sparc-tdep.c (sparc_unwind_pc): Delete.
3983         (sparc32_gdbarch_init): Don't register deleted function with
3984         gdbarch.
3985
3986 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3987
3988         * sh-tdep.c (sh_unwind_sp): Delete.
3989         (sh_unwind_pc): Delete.
3990         (sh_dummy_id): Delete.
3991         (sh_gdbarch_init): Don't register deleted functions with
3992         gdbarch.
3993
3994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3995
3996         * score-tdep.c (score_unwind_sp): Delete.
3997         (score_unwind_pc): Delete.
3998         (score_dummy_id): Delete.
3999         (score_gdbarch_init): Don't register deleted functions with
4000         gdbarch.
4001
4002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4003
4004         * rx-tdep.c (rx_unwind_pc): Delete.
4005         (rx_unwind_sp): Delete.
4006         (rx_dummy_id): Delete.
4007         (rx_gdbarch_init): Don't register deleted functions with
4008         gdbarch.  Update comment.
4009
4010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4011
4012         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4013         (rs6000_dummy_id): Delete.
4014         (rs6000_gdbarch_init): Don't register deleted functions with
4015         gdbarch.
4016
4017 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4018
4019         * or1k-tdep.c (or1k_dummy_id): Delete.
4020         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4021
4022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4023
4024         * nios2-tdep.c (nios2_dummy_id): Delete.
4025         (nios2_unwind_sp): Delete.
4026         (nios2_gdbarch_init): Don't register deleted functions with
4027         gdbarch.
4028
4029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4030
4031         * nds32-tdep.c (nds32_dummy_id): Delete.
4032         (nds32_unwind_pc): Delete.
4033         (nds32_unwind_sp): Delete.
4034         (nds32_gdbarch_init): Don't register deleted functions with
4035         gdbarch.
4036
4037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4038
4039         * msp430-tdep.c (msp430_unwind_pc): Delete.
4040         (msp430_unwind_sp): Delete.
4041         (msp430_dummy_id): Delete.
4042         (msp430_gdbarch_init): Don't register deleted functions with
4043         gdbarch.
4044
4045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4046
4047         * moxie-tdep.c (moxie_unwind_sp): Delete.
4048         (moxie_unwind_pc): Delete.
4049         (moxie_dummy_id): Delete.
4050         (moxie_gdbarch_init): Don't register deleted functions with
4051         gdbarch.
4052
4053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4054
4055         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4056         (mn10300_unwind_pc): Delete.
4057         (mn10300_unwind_sp): Delete.
4058         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4059         mn10300_unwind_sp.
4060         (mn10300_frame_unwind_init): Don't register deleted functions with
4061         gdbarch.
4062
4063 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4064
4065         * mep-tdep.c (mep_unwind_pc): Delete.
4066         (mep_unwind_sp): Delete.
4067         (mep_dummy_id): Delete.
4068         (mep_gdbarch_init): Don't register deleted functions with
4069         gdbarch.
4070
4071 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4072
4073         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4074         (m68hc11_unwind_sp): Delete.
4075         (m68hc11_gdbarch_init): Don't register deleted functions with
4076         gdbarch.
4077
4078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4079
4080         * m32r-tdep.c (m32r_unwind_sp): Delete.
4081         (m32r_unwind_pc): Delete.
4082         (m32r_dummy_id): Delete.
4083         (m32r_gdbarch_init): Don't register deleted functions with
4084         gdbarch.
4085
4086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4087
4088         * m32c-tdep.c (m32c_unwind_pc): Delete.
4089         (m32c_unwind_sp): Delete.
4090         (m32c_dummy_id): Delete.
4091         (m32c_gdbarch_init): Don't register deleted functions with
4092         gdbarch.
4093
4094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4095
4096         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4097         (lm32_unwind_pc): Delete.
4098         (lm32_dummy_id): Delete.
4099         (lm32_gdbarch_init): Don't register deleted functions with
4100         gdbarch.
4101
4102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4103
4104         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4105         (iq2000_unwind_pc): Delete.
4106         (iq2000_dummy_id): Delete.
4107         (iq2000_gdbarch_init): Don't register deleted functions with
4108         gdbarch.
4109
4110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4111
4112         * nds32-tdep.c (nds32_type_align): Delete.
4113         (nds32_push_dummy_call): Use type_align instead.
4114
4115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4116
4117         * arm-tdep.c (arm_type_align): Only handle vector override case.
4118         (arm_push_dummy_call): Use type_align.
4119         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4120
4121 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4122
4123         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4124         case.
4125         (pass_on_stack): Use type_align.
4126         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4127         function.
4128
4129 2019-04-23  Tom Tromey  <tromey@adacore.com>
4130
4131         * dwarf2read.c (line_header::file_name_at): Remove unused
4132         overload.
4133
4134 2019-04-23  Tom de Vries  <tdevries@suse.de>
4135
4136         PR gdb/24438
4137         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4138         invocation.
4139
4140
4141 2019-03-27  Ali Tamur  <tamur@google.com>
4142
4143         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4144         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4145         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4146         (dwarf_expr_context::get_addr_index): Likewise
4147         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4148         (symbol_needs_eval_context::get_addr_index): Likewise
4149         (disassemble_dwarf_expression): Add DW_OP_addrx
4150         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4151         (read_cutu_die_from_dwo): Update comment
4152         (skip_one_die): Add DW_FORM_addrx
4153         (read_attribute_value): Likewise
4154         (var_decode_location): Add DW_OP_addrx
4155         (dwarf2_const_value_attr): Add DW_FORM_addrx
4156         (dump_die_shallow): Likewise
4157         (dwarf2_fetch_constant_bytes): Likewise
4158         (decode_locdesc): Add DW_OP_addrx
4159         (skip_form_bytes): Add DW_FORM_addrx
4160
4161 2019-04-22  Ali Tamur  <tamur@google.com>
4162
4163         * MAINTAINERS (Write After Approval): Add self.
4164
4165 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4166
4167         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4168         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4169         (open_symbol_file_object): Likewise.
4170         (svr4_default_sos): Add info parameter.
4171         (svr4_read_so_list): Likewise.
4172         (svr4_current_sos_direct): Adjust functions calls to pass down
4173         info.
4174         (svr4_current_sos_1): Add info parameter.
4175         (svr4_current_sos): Call get_svr4_info, pass info down to
4176         svr4_current_sos_1.
4177         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4178         get_svr4_info.
4179         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4180         get_svr4_info.
4181         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4182         to get_svr4_info.
4183         (probes_table_remove_objfile_probes): Likewise.
4184         (register_solib_event_probe): Add info parameter.
4185         (solist_update_incremental): Pass info parameter down to
4186         svr4_read_so_list.
4187         (disable_probes_interface): Add info parameter.
4188         (svr4_handle_solib_event): Pass current_program_space to
4189         get_svr4_info.  Adjust disable_probes_interface cleanup.
4190         (svr4_create_probe_breakpoints): Add info parameter, pass it
4191         down to register_solib_event_probe.
4192         (svr4_create_solib_event_breakpoints): Add info parameter,
4193         pass it down to svr4_create_probe_breakpoints.
4194         (enable_break): Pass info down to
4195         svr4_create_solib_event_breakpoints.
4196         (svr4_solib_create_inferior_hook): Pass current_program_space to
4197         get_svr4_info.
4198         (svr4_clear_solib): Likewise.
4199
4200 2019-04-22  Pedro Alves  <palves@redhat.com>
4201
4202         * solib-svr4.c (svr4_free_objfile_observer): New.
4203         (probe_and_action::objfile): New field.
4204         (probes_table_htab_remove_objfile_probes)
4205         (probes_table_remove_objfile_probes): New functions.
4206         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4207         in the new probe_and_action.  Don't store the probe in 'lookup'.
4208         (svr4_create_probe_breakpoints): Pass objfile to
4209         register_solib_event_probe.
4210         (_initialize_svr4_solib): Register a free_objfile observer.
4211
4212 2019-04-19  Tom Tromey  <tom@tromey.com>
4213
4214         * common/queue.h: Remove.
4215
4216 2019-04-19  Tom Tromey  <tom@tromey.com>
4217
4218         * event-loop.c: Don't include "common/queue.h".
4219
4220 2019-04-19  Tom Tromey  <tom@tromey.com>
4221
4222         * remote.c (remote_target): Use delete.
4223         * remote-notif.h: Include <list>, not "common/queue.h".
4224         (notif_client_p): Remove typedef.
4225         (remote_notif_state): Add constructor, destructor, initializer.
4226         <notif_queue>: Now a std::list.
4227         (remote_notif_state_xfree): Don't declare.
4228         * remote-notif.c (remote_notif_process, handle_notification)
4229         (remote_notif_state_allocate): Update.
4230         (~remote_notif_state): Rename from remote_notif_state_xfree.
4231
4232 2019-04-19  Tom Tromey  <tom@tromey.com>
4233
4234         * symfile.c (reread_symbols): Update.
4235         * objfiles.c (objfile_register_static_link)
4236         (objfile_lookup_static_link): Update
4237         (~objfile) Don't delete static_links.
4238         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4239
4240 2019-04-19  Tom Tromey  <tom@tromey.com>
4241
4242         * type-stack.h (struct type_stack) <insert>: Constify string.
4243         * type-stack.c (type_stack::insert): Constify string.
4244         * gdbtypes.h (lookup_template_type): Update.
4245         (address_space_name_to_int): Update.
4246         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4247         const.
4248         (lookup_template_type): Make name const.
4249         * c-exp.y: Update rules.
4250         (lex_one_token, classify_name, classify_inner_name)
4251         (c_print_token): Update.
4252         * p-exp.y: Update rules.
4253         (yylex): Update.
4254         * f-exp.y: Update rules.
4255         (yylex): Update.
4256         * d-exp.y: Update rules.
4257         (lex_one_token, classify_name, classify_inner_name): Update.
4258         * parse.c (write_dollar_variable, copy_name): Return std::string.
4259         * parser-defs.h (copy_name): Change return type.
4260         * m2-exp.y: Update rules.
4261         (yylex): Update.
4262         * go-exp.y (lex_one_token): Update.
4263         Update rules.
4264         (classify_unsafe_function, classify_packaged_name)
4265         (classify_name, yylex): Update.
4266
4267 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4268
4269         * configure.ac: add --enable-source-highlight switch.
4270         * configure: Regenerate.
4271         * top.c (print_gdb_version): plumb --enable-source-highlight
4272         status to "show configuration".
4273
4274 2019-04-19  Tom Tromey  <tromey@adacore.com>
4275
4276         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4277         Check ADA_TYPE_P.
4278         (empty_record, ada_template_to_fixed_record_type_1)
4279         (template_to_static_fixed_type)
4280         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4281         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4282         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4283         macros.
4284
4285 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4286
4287         PR symtab/24423:
4288         * source.c (print_source_lines_base): Advance "iter" when a
4289         control character is seen.
4290
4291 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4292
4293         * inferior.h (struct infcall_suspend_state_deleter):
4294         Catch exception in destructor to avoid crash.
4295
4296 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4297
4298         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4299         close to the add_com "shell".
4300
4301 2019-04-18  Tom Tromey  <tromey@adacore.com>
4302
4303         * process-stratum-target.h (class process_stratum_target)
4304         <stratum>: Add "final".
4305
4306 2019-04-17  Tom Tromey  <tromey@adacore.com>
4307
4308         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4309         against nullptr before use.
4310
4311 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4312
4313         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4314
4315 2019-04-17  Jim Wilson  <jimw@sifive.com>
4316             Andrew Burgess  <andrew.burgess@embecosm.com>
4317
4318         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4319         code read might fail, assume 4-byte breakpoint in that case.
4320
4321 2019-04-15  Leszek Swirski  <leszeks@google.com>
4322
4323         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4324         rather than a hand-rolled POD check when checking for forced MEMORY
4325         classification.
4326
4327 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4328
4329         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4330         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4331         function.
4332         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4333         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4334         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4335         declaration.
4336
4337 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4338
4339         * aarch64-linux-nat.c
4340         (aarch64_linux_nat_target::thread_architecture): Add override.
4341         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4342         each VQ.
4343
4344 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4345
4346         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4347
4348 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4349
4350         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4351         target types of size 96-bits, add some additional comments, and
4352         check that the builtin type we found was the correct size.
4353
4354 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4355
4356         * utils.c (prompt_for_continue): Don't restore the styling at the
4357         end, as applied_style has the wrong value.  This fixes styling in
4358         long lists of file names that are interrupted by the "Continue?"
4359         prompt.
4360
4361 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4362
4363         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4364         * c-lang.c (c_language_defn): Likewise.
4365         (cplus_language_defn): Likewise.
4366         (asm_language_defn): Likewise.
4367         (minimal_language_defn): Likewise.
4368         * d-lang.c (d_language_defn): Likewise.
4369         * f-lang.c (f_language_defn): Likewise.
4370         * go-lang.c (go_language_defn): Likewise.
4371         * language.c (unknown_language_defn): Likewise.
4372         (auto_language_defn): Likewise.
4373         * language.h (struct language_defn): Remove la_magic field.
4374         (LANG_MAGIC): Delete.
4375         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4376         * objc-lang.c (objc_language_defn): Likewise.
4377         * opencl-lang.c (opencl_language_defn): Likewise.
4378         * p-lang.c (pascal_language_defn): Likewise.
4379         * rust-lang.c (rust_language_defn): Likewise.
4380
4381 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4382
4383         * riscv-tdep.c (riscv_type_align): New function.
4384         (riscv_type_alignment): Delete.
4385         (riscv_arg_location): Use 'type_align'.
4386         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4387
4388 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4389
4390         * gdbtypes.c (type_align): A struct with no non-static fields also
4391         has alignment of 1.
4392
4393 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4394
4395         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4396         component to 0.
4397         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4398         member.
4399         (riscv_struct_info::analyse): New implementation using new
4400         analyse_inner member function.
4401         (riscv_struct_info::field_offset): New member function.
4402         (riscv_struct_info::m_offsets): New member variable.
4403         (riscv_struct_info::analyse_inner): New private member function,
4404         takes the old implementation of riscv_struct_info::analyse but
4405         extended to track field offsets.
4406         (riscv_call_arg_struct): Update the struct folding special cases
4407         to handle cases where empty C++ structs, which are non-zero
4408         length, are found.
4409         (riscv_arg_location): Initialise the length of each location, a
4410         non-zero length now indicates the location is in use.
4411         (riscv_push_dummy_call): Allow for the first location having a
4412         non-zero offset when setting up arguments.
4413         (riscv_return_value): Likewise, but for return values.
4414
4415 2019-04-11  Tom Tromey  <tromey@adacore.com>
4416
4417         * utils.c (internal_vproblem): Make "msg" const.
4418
4419 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4420
4421         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4422         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4423         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4424         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4425
4426 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4427
4428         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4429         function.
4430         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4431         of amd64_collect_native_gregset.
4432         (amd64_linux_nat_target::store_registers): Likewise.
4433
4434 2019-04-10  Tom Tromey  <tom@tromey.com>
4435
4436         * symtab.c (lookup_global_symbol_from_objfile)
4437         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4438         * objfiles.h (class separate_debug_iterator): New.
4439         (class separate_debug_range): New.
4440         (struct objfile) <separate_debug_objfiles>: New method.
4441         (objfile_separate_debug_iterate): Don't declare.
4442         * objfiles.c (separate_debug_iterator::operator++): Rename from
4443         objfile_separate_debug_iterate.
4444         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4445         iterator.
4446         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4447         iterator.
4448
4449 2019-04-10  Tom Tromey  <tom@tromey.com>
4450
4451         * symfile.c (reread_symbols): Remove old comment.
4452         * objfiles.c (free_all_objfiles): Fix a typo.
4453
4454 2019-04-10  Tom Tromey  <tom@tromey.com>
4455
4456         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4457         * minsyms.c (lookup_minimal_symbol): Use foreach.
4458         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4459         (lookup_minimal_symbol_solib_trampoline): Likewise.
4460         * symfile.c (reread_symbols): Use foreach.
4461
4462 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4463             Tom Tromey  <tromey@adacore.com>
4464
4465         PR rust/24414:
4466         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4467         (rust_lex_int_test): Change "value" to be LONGEST.
4468         (rust_lex_tests): Add test for long integer literal.
4469
4470 2019-04-09  Tom Tromey  <tromey@adacore.com>
4471
4472         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4473         to bool.
4474         (extended_remote_target::attach): Update.
4475         (remote_target::remote_notice_new_inferior): Update.
4476         (remote_target::add_current_inferior_and_thread): Update.
4477         * inferior.c (exit_inferior_1): Use "false".
4478         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4479
4480 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4481
4482         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4483         the "start" command.
4484
4485 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4486
4487         * python/py-inferior.c (infpy_thread_from_thread_handle):
4488         Adjust comments to reflect renaming of thread_from_thread_handle
4489         to thread_from_handle.  Adjust keywords.  Fix type error message.
4490         (inferior_object_methods): Add thread_from_handle.  Retain
4491         thread_from_thread_handle, but mark it as deprecated.
4492
4493 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4494
4495         * gdbthread.h (find_thread_by_handle): Revise declaration.
4496         * thread.c (find_thread_by_handle): Likewise.  Adjust
4497         implementation too.
4498         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4499         support for buffer objects as handles.
4500
4501 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4502
4503         * python/py-infthread.c (thpy_thread_handle): New function.
4504         (thread_object_methods): Register thpy_thread_handle.
4505
4506 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4507
4508         * gdbthread.h (thread_to_thread_handle): Declare.
4509         * thread.c (gdbtypes.h): Include.
4510         (thread_to_thread_handle): New function.
4511
4512         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4513         (target_thread_info_to_thread_handle): Declare.
4514         * target.c (target_thread_info_to_thread_handle): New function.
4515         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4516         * target-delegates.c: Regenerate.
4517
4518         * linux-thread-db.c (class thread_db_target): Add method
4519         thread_info_to_thread_handle.
4520         (thread_db_target::thread_info_to_thread_handle): Define.
4521         * remote.c (class remote_target): Add new method
4522         thread_info_to_thread_handle.
4523         (remote_target::thread_info_to_thread_handle): Define.
4524
4525 2019-04-08  Pedro Alves  <palves@redhat.com>
4526
4527         * common/common-exceptions.c (throw_exception): Don't create
4528         named object to throw; throw directly.
4529         (throw_it): Likewise.  Don't initialize gdb_exception::message
4530         here, with new; pass FMT and AP to the ctor instead.
4531         * common/common-exceptions.h: Include <string>.
4532         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4533         const char *, va_list)): New ctor.  Use std::make_shared.
4534         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4535         errors)): Delete.
4536         (gdb_exception_error::gdb_exception_error(enum errors, const char
4537         *, va_list)): New.
4538         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4539         Add assertion.
4540         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4541         errors)): Delete.
4542         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4543         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4544         Add assertion.
4545
4546 2019-04-08  Tom Tromey  <tom@tromey.com>
4547
4548         * valops.c (value_rtti_indirect_type): Replace throw_exception
4549         with throw.
4550         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4551         with throw.
4552         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4553         throw.
4554         * target.c (target_translate_tls_address): Replace throw_exception
4555         with throw.
4556         * stack.c (frame_apply_command_count): Replace throw_exception
4557         with throw.
4558         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4559         throw.
4560         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4561         with throw.
4562         * rs6000-tdep.c (rs6000_frame_cache)
4563         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4564         * remote.c: Replace throw_exception with throw.
4565         * record-full.c (record_full_message, record_full_wait_1)
4566         (record_full_restore): Replace throw_exception with throw.
4567         * record-btrace.c:
4568         (get_thread_current_frame_id, record_btrace_start_replaying)
4569         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4570         (cmd_record_btrace_start): Replace throw_exception with throw.
4571         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4572         throw.
4573         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4574         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4575         * linespec.c:
4576         (find_linespec_symbols): Replace throw_exception with throw.
4577         * infrun.c (displaced_step_prepare, resume): Replace
4578         throw_exception with throw.
4579         * infcmd.c (post_create_inferior): Replace throw_exception with
4580         throw.
4581         * inf-loop.c (inferior_event_handler): Replace throw_exception
4582         with throw.
4583         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4584         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4585         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4586         (get_prev_frame_always, get_frame_pc_if_available)
4587         (get_frame_address_in_block_if_available, get_frame_language):
4588         Replace throw_exception with throw.
4589         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4590         throw_exception with throw.
4591         * eval.c (fetch_subexp_value, evaluate_var_value)
4592         (evaluate_funcall, evaluate_subexp_standard): Replace
4593         throw_exception with throw.
4594         * dwarf2loc.c (call_site_find_chain)
4595         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4596         Replace throw_exception with throw.
4597         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4598         with throw.
4599         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4600         throw.
4601         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4602         * completer.c (complete_line_internal): Replace throw_exception
4603         with throw.
4604         * compile/compile-object-run.c (compile_object_run): Replace
4605         throw_exception with throw.
4606         * cli/cli-script.c (process_next_line): Replace throw_exception
4607         with throw.
4608         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4609         (btrace_enable, btrace_maint_update_pt_packets): Replace
4610         throw_exception with throw.
4611         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4612         throw_exception with throw.
4613         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4614         throw_exception with throw.
4615         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4616         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4617         * aarch64-tdep.c (aarch64_make_prologue_cache)
4618         (aarch64_make_stub_cache): Replace throw_exception with throw.
4619
4620 2019-04-08  Tom Tromey  <tom@tromey.com>
4621
4622         * common/common-exceptions.c (throw_exception): Rename from
4623         throw_exception_cxx.  Remove old copy.  Make argument const.
4624         (throw_it): Create and throw exception objects directly.
4625         * common/common-exceptions.h (throw_exception): Make argument
4626         const.
4627         (struct gdb_exception_error): Add constructor.
4628         (struct gdb_exception_quit): Add constructor.
4629
4630 2019-04-08  Tom Tromey  <tom@tromey.com>
4631
4632         * common/common-exceptions.h (exception_rethrow): Don't declare.
4633         (TRY_SJLJ): Update comment.
4634         (TRY, CATCH, END_CATCH): Remove.
4635         * common/common-exceptions.c (exception_rethrow): Remove.
4636
4637 2019-04-08  Tom Tromey  <tom@tromey.com>
4638
4639         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4640         Remove.
4641         (gdb_exception_error): Rename from
4642         gdb_exception_RETURN_MASK_ERROR.
4643         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4644         (gdb_quit_bad_alloc): Update.
4645         * aarch64-tdep.c: Update.
4646         * ada-lang.c: Update.
4647         * ada-typeprint.c: Update.
4648         * ada-valprint.c: Update.
4649         * amd64-tdep.c: Update.
4650         * arch-utils.c: Update.
4651         * break-catch-throw.c: Update.
4652         * breakpoint.c: Update.
4653         * btrace.c: Update.
4654         * c-varobj.c: Update.
4655         * cli/cli-cmds.c: Update.
4656         * cli/cli-interp.c: Update.
4657         * cli/cli-script.c: Update.
4658         * common/common-exceptions.c: Update.
4659         * common/new-op.c: Update.
4660         * common/selftest.c: Update.
4661         * compile/compile-c-symbols.c: Update.
4662         * compile/compile-cplus-symbols.c: Update.
4663         * compile/compile-object-load.c: Update.
4664         * compile/compile-object-run.c: Update.
4665         * completer.c: Update.
4666         * corelow.c: Update.
4667         * cp-abi.c: Update.
4668         * cp-support.c: Update.
4669         * cp-valprint.c: Update.
4670         * darwin-nat.c: Update.
4671         * disasm-selftests.c: Update.
4672         * dtrace-probe.c: Update.
4673         * dwarf-index-cache.c: Update.
4674         * dwarf-index-write.c: Update.
4675         * dwarf2-frame-tailcall.c: Update.
4676         * dwarf2-frame.c: Update.
4677         * dwarf2loc.c: Update.
4678         * dwarf2read.c: Update.
4679         * eval.c: Update.
4680         * event-loop.c: Update.
4681         * event-top.c: Update.
4682         * exec.c: Update.
4683         * f-valprint.c: Update.
4684         * fbsd-tdep.c: Update.
4685         * frame-unwind.c: Update.
4686         * frame.c: Update.
4687         * gdbtypes.c: Update.
4688         * gnu-v3-abi.c: Update.
4689         * guile/guile-internal.h: Update.
4690         * guile/scm-block.c: Update.
4691         * guile/scm-breakpoint.c: Update.
4692         * guile/scm-cmd.c: Update.
4693         * guile/scm-disasm.c: Update.
4694         * guile/scm-frame.c: Update.
4695         * guile/scm-lazy-string.c: Update.
4696         * guile/scm-math.c: Update.
4697         * guile/scm-param.c: Update.
4698         * guile/scm-ports.c: Update.
4699         * guile/scm-pretty-print.c: Update.
4700         * guile/scm-symbol.c: Update.
4701         * guile/scm-symtab.c: Update.
4702         * guile/scm-type.c: Update.
4703         * guile/scm-value.c: Update.
4704         * i386-linux-tdep.c: Update.
4705         * i386-tdep.c: Update.
4706         * inf-loop.c: Update.
4707         * infcall.c: Update.
4708         * infcmd.c: Update.
4709         * infrun.c: Update.
4710         * jit.c: Update.
4711         * language.c: Update.
4712         * linespec.c: Update.
4713         * linux-fork.c: Update.
4714         * linux-nat.c: Update.
4715         * linux-tdep.c: Update.
4716         * linux-thread-db.c: Update.
4717         * main.c: Update.
4718         * mi/mi-cmd-break.c: Update.
4719         * mi/mi-cmd-stack.c: Update.
4720         * mi/mi-interp.c: Update.
4721         * mi/mi-main.c: Update.
4722         * objc-lang.c: Update.
4723         * p-valprint.c: Update.
4724         * parse.c: Update.
4725         * ppc-linux-tdep.c: Update.
4726         * printcmd.c: Update.
4727         * python/py-arch.c: Update.
4728         * python/py-breakpoint.c: Update.
4729         * python/py-cmd.c: Update.
4730         * python/py-finishbreakpoint.c: Update.
4731         * python/py-frame.c: Update.
4732         * python/py-framefilter.c: Update.
4733         * python/py-gdb-readline.c: Update.
4734         * python/py-inferior.c: Update.
4735         * python/py-infthread.c: Update.
4736         * python/py-lazy-string.c: Update.
4737         * python/py-linetable.c: Update.
4738         * python/py-objfile.c: Update.
4739         * python/py-param.c: Update.
4740         * python/py-prettyprint.c: Update.
4741         * python/py-progspace.c: Update.
4742         * python/py-record-btrace.c: Update.
4743         * python/py-record.c: Update.
4744         * python/py-symbol.c: Update.
4745         * python/py-type.c: Update.
4746         * python/py-unwind.c: Update.
4747         * python/py-utils.c: Update.
4748         * python/py-value.c: Update.
4749         * python/python.c: Update.
4750         * record-btrace.c: Update.
4751         * record-full.c: Update.
4752         * remote-fileio.c: Update.
4753         * remote.c: Update.
4754         * riscv-tdep.c: Update.
4755         * rs6000-aix-tdep.c: Update.
4756         * rs6000-tdep.c: Update.
4757         * rust-exp.y: Update.
4758         * rust-lang.c: Update.
4759         * s390-tdep.c: Update.
4760         * selftest-arch.c: Update.
4761         * solib-dsbt.c: Update.
4762         * solib-frv.c: Update.
4763         * solib-spu.c: Update.
4764         * solib-svr4.c: Update.
4765         * solib.c: Update.
4766         * sparc64-linux-tdep.c: Update.
4767         * stack.c: Update.
4768         * symfile-mem.c: Update.
4769         * symmisc.c: Update.
4770         * target.c: Update.
4771         * thread.c: Update.
4772         * top.c: Update.
4773         * tracefile-tfile.c: Update.
4774         * tui/tui.c: Update.
4775         * typeprint.c: Update.
4776         * unittests/cli-utils-selftests.c: Update.
4777         * unittests/parse-connection-spec-selftests.c: Update.
4778         * valops.c: Update.
4779         * valprint.c: Update.
4780         * value.c: Update.
4781         * varobj.c: Update.
4782         * windows-nat.c: Update.
4783         * x86-linux-nat.c: Update.
4784         * xml-support.c: Update.
4785
4786 2019-04-08  Tom Tromey  <tom@tromey.com>
4787
4788         * xml-support.c: Use C++ exception handling.
4789         * x86-linux-nat.c: Use C++ exception handling.
4790         * windows-nat.c: Use C++ exception handling.
4791         * varobj.c: Use C++ exception handling.
4792         * value.c: Use C++ exception handling.
4793         * valprint.c: Use C++ exception handling.
4794         * valops.c: Use C++ exception handling.
4795         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4796         handling.
4797         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4798         * typeprint.c: Use C++ exception handling.
4799         * tui/tui.c: Use C++ exception handling.
4800         * tracefile-tfile.c: Use C++ exception handling.
4801         * top.c: Use C++ exception handling.
4802         * thread.c: Use C++ exception handling.
4803         * target.c: Use C++ exception handling.
4804         * symmisc.c: Use C++ exception handling.
4805         * symfile-mem.c: Use C++ exception handling.
4806         * stack.c: Use C++ exception handling.
4807         * sparc64-linux-tdep.c: Use C++ exception handling.
4808         * solib.c: Use C++ exception handling.
4809         * solib-svr4.c: Use C++ exception handling.
4810         * solib-spu.c: Use C++ exception handling.
4811         * solib-frv.c: Use C++ exception handling.
4812         * solib-dsbt.c: Use C++ exception handling.
4813         * selftest-arch.c: Use C++ exception handling.
4814         * s390-tdep.c: Use C++ exception handling.
4815         * rust-lang.c: Use C++ exception handling.
4816         * rust-exp.y: Use C++ exception handling.
4817         * rs6000-tdep.c: Use C++ exception handling.
4818         * rs6000-aix-tdep.c: Use C++ exception handling.
4819         * riscv-tdep.c: Use C++ exception handling.
4820         * remote.c: Use C++ exception handling.
4821         * remote-fileio.c: Use C++ exception handling.
4822         * record-full.c: Use C++ exception handling.
4823         * record-btrace.c: Use C++ exception handling.
4824         * python/python.c: Use C++ exception handling.
4825         * python/py-value.c: Use C++ exception handling.
4826         * python/py-utils.c: Use C++ exception handling.
4827         * python/py-unwind.c: Use C++ exception handling.
4828         * python/py-type.c: Use C++ exception handling.
4829         * python/py-symbol.c: Use C++ exception handling.
4830         * python/py-record.c: Use C++ exception handling.
4831         * python/py-record-btrace.c: Use C++ exception handling.
4832         * python/py-progspace.c: Use C++ exception handling.
4833         * python/py-prettyprint.c: Use C++ exception handling.
4834         * python/py-param.c: Use C++ exception handling.
4835         * python/py-objfile.c: Use C++ exception handling.
4836         * python/py-linetable.c: Use C++ exception handling.
4837         * python/py-lazy-string.c: Use C++ exception handling.
4838         * python/py-infthread.c: Use C++ exception handling.
4839         * python/py-inferior.c: Use C++ exception handling.
4840         * python/py-gdb-readline.c: Use C++ exception handling.
4841         * python/py-framefilter.c: Use C++ exception handling.
4842         * python/py-frame.c: Use C++ exception handling.
4843         * python/py-finishbreakpoint.c: Use C++ exception handling.
4844         * python/py-cmd.c: Use C++ exception handling.
4845         * python/py-breakpoint.c: Use C++ exception handling.
4846         * python/py-arch.c: Use C++ exception handling.
4847         * printcmd.c: Use C++ exception handling.
4848         * ppc-linux-tdep.c: Use C++ exception handling.
4849         * parse.c: Use C++ exception handling.
4850         * p-valprint.c: Use C++ exception handling.
4851         * objc-lang.c: Use C++ exception handling.
4852         * mi/mi-main.c: Use C++ exception handling.
4853         * mi/mi-interp.c: Use C++ exception handling.
4854         * mi/mi-cmd-stack.c: Use C++ exception handling.
4855         * mi/mi-cmd-break.c: Use C++ exception handling.
4856         * main.c: Use C++ exception handling.
4857         * linux-thread-db.c: Use C++ exception handling.
4858         * linux-tdep.c: Use C++ exception handling.
4859         * linux-nat.c: Use C++ exception handling.
4860         * linux-fork.c: Use C++ exception handling.
4861         * linespec.c: Use C++ exception handling.
4862         * language.c: Use C++ exception handling.
4863         * jit.c: Use C++ exception handling.
4864         * infrun.c: Use C++ exception handling.
4865         * infcmd.c: Use C++ exception handling.
4866         * infcall.c: Use C++ exception handling.
4867         * inf-loop.c: Use C++ exception handling.
4868         * i386-tdep.c: Use C++ exception handling.
4869         * i386-linux-tdep.c: Use C++ exception handling.
4870         * guile/scm-value.c: Use C++ exception handling.
4871         * guile/scm-type.c: Use C++ exception handling.
4872         * guile/scm-symtab.c: Use C++ exception handling.
4873         * guile/scm-symbol.c: Use C++ exception handling.
4874         * guile/scm-pretty-print.c: Use C++ exception handling.
4875         * guile/scm-ports.c: Use C++ exception handling.
4876         * guile/scm-param.c: Use C++ exception handling.
4877         * guile/scm-math.c: Use C++ exception handling.
4878         * guile/scm-lazy-string.c: Use C++ exception handling.
4879         * guile/scm-frame.c: Use C++ exception handling.
4880         * guile/scm-disasm.c: Use C++ exception handling.
4881         * guile/scm-cmd.c: Use C++ exception handling.
4882         * guile/scm-breakpoint.c: Use C++ exception handling.
4883         * guile/scm-block.c: Use C++ exception handling.
4884         * guile/guile-internal.h: Use C++ exception handling.
4885         * gnu-v3-abi.c: Use C++ exception handling.
4886         * gdbtypes.c: Use C++ exception handling.
4887         * frame.c: Use C++ exception handling.
4888         * frame-unwind.c: Use C++ exception handling.
4889         * fbsd-tdep.c: Use C++ exception handling.
4890         * f-valprint.c: Use C++ exception handling.
4891         * exec.c: Use C++ exception handling.
4892         * event-top.c: Use C++ exception handling.
4893         * event-loop.c: Use C++ exception handling.
4894         * eval.c: Use C++ exception handling.
4895         * dwarf2read.c: Use C++ exception handling.
4896         * dwarf2loc.c: Use C++ exception handling.
4897         * dwarf2-frame.c: Use C++ exception handling.
4898         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4899         * dwarf-index-write.c: Use C++ exception handling.
4900         * dwarf-index-cache.c: Use C++ exception handling.
4901         * dtrace-probe.c: Use C++ exception handling.
4902         * disasm-selftests.c: Use C++ exception handling.
4903         * darwin-nat.c: Use C++ exception handling.
4904         * cp-valprint.c: Use C++ exception handling.
4905         * cp-support.c: Use C++ exception handling.
4906         * cp-abi.c: Use C++ exception handling.
4907         * corelow.c: Use C++ exception handling.
4908         * completer.c: Use C++ exception handling.
4909         * compile/compile-object-run.c: Use C++ exception handling.
4910         * compile/compile-object-load.c: Use C++ exception handling.
4911         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4912         * compile/compile-c-symbols.c: Use C++ exception handling.
4913         * common/selftest.c: Use C++ exception handling.
4914         * common/new-op.c: Use C++ exception handling.
4915         * cli/cli-script.c: Use C++ exception handling.
4916         * cli/cli-interp.c: Use C++ exception handling.
4917         * cli/cli-cmds.c: Use C++ exception handling.
4918         * c-varobj.c: Use C++ exception handling.
4919         * btrace.c: Use C++ exception handling.
4920         * breakpoint.c: Use C++ exception handling.
4921         * break-catch-throw.c: Use C++ exception handling.
4922         * arch-utils.c: Use C++ exception handling.
4923         * amd64-tdep.c: Use C++ exception handling.
4924         * ada-valprint.c: Use C++ exception handling.
4925         * ada-typeprint.c: Use C++ exception handling.
4926         * ada-lang.c: Use C++ exception handling.
4927         * aarch64-tdep.c: Use C++ exception handling.
4928
4929 2019-04-08  Tom Tromey  <tom@tromey.com>
4930
4931         * xml-support.c (gdb_xml_parser::parse): Update.
4932         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4933         * value.c (show_convenience): Update.
4934         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4935         (test_parse_flags_qcs): Update.
4936         * thread.c (thr_try_catch_cmd): Update.
4937         * target.c (target_translate_tls_address): Update.
4938         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4939         (info_frame_command_core, frame_apply_command_count): Update.
4940         * rust-exp.y (rust_lex_exception_test): Update.
4941         * riscv-tdep.c (riscv_print_one_register_info): Update.
4942         * remote.c (remote_target::enable_btrace): Update.
4943         * record-btrace.c (record_btrace_enable_warn): Update.
4944         * python/py-utils.c (gdbpy_convert_exception): Update.
4945         * printcmd.c (do_one_display, print_variable_and_value): Update.
4946         * mi/mi-main.c (mi_print_exception): Update.
4947         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4948         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4949         * linux-nat.c (linux_nat_target::attach): Update.
4950         * linux-fork.c (class scoped_switch_fork_info): Update.
4951         * infrun.c (displaced_step_prepare): Update.
4952         * infcall.c (call_function_by_hand_dummy): Update.
4953         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4954         * gnu-v3-abi.c (print_one_vtable): Update.
4955         * frame.c (get_prev_frame_always): Update.
4956         * f-valprint.c (info_common_command_for_block): Update.
4957         * exec.c (try_open_exec_file): Update.
4958         * exceptions.c (print_exception, exception_print)
4959         (exception_fprintf, exception_print_same): Update.
4960         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4961         * dwarf-index-cache.c (index_cache::store)
4962         (index_cache::lookup_gdb_index): Update.
4963         * darwin-nat.c (maybe_cache_shell): Update.
4964         * cp-valprint.c (cp_print_value_fields): Update.
4965         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4966         (gcc_cplus_symbol_address): Update.
4967         * compile/compile-c-symbols.c (gcc_convert_symbol)
4968         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4969         * common/selftest.c: Update.
4970         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4971         a std::string.
4972         (exception_try_scope_entry, exception_try_scope_exit): Don't
4973         declare.
4974         (struct exception_try_scope): Remove.
4975         (TRY): Don't use exception_try_scope.
4976         (struct gdb_exception): Add constructor, operator=.
4977         <what>: New method.
4978         (struct gdb_exception_RETURN_MASK_ALL)
4979         (struct gdb_exception_RETURN_MASK_ERROR)
4980         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4981         (struct gdb_quit_bad_alloc): Update.
4982         * common/common-exceptions.c (exception_none): Change
4983         initializer.
4984         (struct catcher) <state, exception>: Initialize inline.
4985         <prev>: Remove member.
4986         (current_catcher): Remove.
4987         (catchers): New global.
4988         (exceptions_state_mc_init): Simplify.
4989         (catcher_pop): Remove.
4990         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4991         (try_scope_depth, exception_try_scope_entry)
4992         (exception_try_scope_exit): Remove.
4993         (throw_exception_sjlj): Update.
4994         (exception_messages, exception_messages_size): Remove.
4995         (throw_it): Simplify.
4996         (gdb_exception_sliced_copy): Remove.
4997         (throw_exception_cxx): Update.
4998         * cli/cli-script.c (script_from_file): Update.
4999         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5000         Update.
5001         * ada-valprint.c (ada_val_print): Update.
5002         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5003         (create_excep_cond_exprs): Update.
5004
5005 2019-04-08  Tom Tromey  <tom@tromey.com>
5006
5007         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5008         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5009         (TRY, CATCH, END_CATCH): Remove some definitions.
5010         * common/common-exceptions.c: Don't use GDB_XCPT.
5011         (catcher_list_size): Remove.
5012         (throw_exception, throw_it): Simplify.
5013
5014 2019-04-05  Tom Tromey  <tom@tromey.com>
5015
5016         Revert the header-sorting patch.
5017         * ft32-tdep.c: Revert.
5018         * frv-tdep.c: Revert.
5019         * frv-linux-tdep.c: Revert.
5020         * frame.c: Revert.
5021         * frame-unwind.c: Revert.
5022         * frame-base.c: Revert.
5023         * fork-child.c: Revert.
5024         * findvar.c: Revert.
5025         * findcmd.c: Revert.
5026         * filesystem.c: Revert.
5027         * filename-seen-cache.h: Revert.
5028         * filename-seen-cache.c: Revert.
5029         * fbsd-tdep.c: Revert.
5030         * fbsd-nat.h: Revert.
5031         * fbsd-nat.c: Revert.
5032         * f-valprint.c: Revert.
5033         * f-typeprint.c: Revert.
5034         * f-lang.c: Revert.
5035         * extension.h: Revert.
5036         * extension.c: Revert.
5037         * extension-priv.h: Revert.
5038         * expprint.c: Revert.
5039         * exec.h: Revert.
5040         * exec.c: Revert.
5041         * exceptions.c: Revert.
5042         * event-top.c: Revert.
5043         * event-loop.c: Revert.
5044         * eval.c: Revert.
5045         * elfread.c: Revert.
5046         * dwarf2read.h: Revert.
5047         * dwarf2read.c: Revert.
5048         * dwarf2loc.c: Revert.
5049         * dwarf2expr.h: Revert.
5050         * dwarf2expr.c: Revert.
5051         * dwarf2-frame.c: Revert.
5052         * dwarf2-frame-tailcall.c: Revert.
5053         * dwarf-index-write.h: Revert.
5054         * dwarf-index-write.c: Revert.
5055         * dwarf-index-common.c: Revert.
5056         * dwarf-index-cache.h: Revert.
5057         * dwarf-index-cache.c: Revert.
5058         * dummy-frame.c: Revert.
5059         * dtrace-probe.c: Revert.
5060         * disasm.h: Revert.
5061         * disasm.c: Revert.
5062         * disasm-selftests.c: Revert.
5063         * dictionary.c: Revert.
5064         * dicos-tdep.c: Revert.
5065         * demangle.c: Revert.
5066         * dcache.h: Revert.
5067         * dcache.c: Revert.
5068         * darwin-nat.h: Revert.
5069         * darwin-nat.c: Revert.
5070         * darwin-nat-info.c: Revert.
5071         * d-valprint.c: Revert.
5072         * d-namespace.c: Revert.
5073         * d-lang.c: Revert.
5074         * ctf.c: Revert.
5075         * csky-tdep.c: Revert.
5076         * csky-linux-tdep.c: Revert.
5077         * cris-tdep.c: Revert.
5078         * cris-linux-tdep.c: Revert.
5079         * cp-valprint.c: Revert.
5080         * cp-support.c: Revert.
5081         * cp-namespace.c: Revert.
5082         * cp-abi.c: Revert.
5083         * corelow.c: Revert.
5084         * corefile.c: Revert.
5085         * continuations.c: Revert.
5086         * completer.h: Revert.
5087         * completer.c: Revert.
5088         * complaints.c: Revert.
5089         * coffread.c: Revert.
5090         * coff-pe-read.c: Revert.
5091         * cli-out.h: Revert.
5092         * cli-out.c: Revert.
5093         * charset.c: Revert.
5094         * c-varobj.c: Revert.
5095         * c-valprint.c: Revert.
5096         * c-typeprint.c: Revert.
5097         * c-lang.c: Revert.
5098         * buildsym.c: Revert.
5099         * buildsym-legacy.c: Revert.
5100         * build-id.h: Revert.
5101         * build-id.c: Revert.
5102         * btrace.c: Revert.
5103         * bsd-uthread.c: Revert.
5104         * breakpoint.h: Revert.
5105         * breakpoint.c: Revert.
5106         * break-catch-throw.c: Revert.
5107         * break-catch-syscall.c: Revert.
5108         * break-catch-sig.c: Revert.
5109         * blockframe.c: Revert.
5110         * block.c: Revert.
5111         * bfin-tdep.c: Revert.
5112         * bfin-linux-tdep.c: Revert.
5113         * bfd-target.c: Revert.
5114         * bcache.c: Revert.
5115         * ax-general.c: Revert.
5116         * ax-gdb.h: Revert.
5117         * ax-gdb.c: Revert.
5118         * avr-tdep.c: Revert.
5119         * auxv.c: Revert.
5120         * auto-load.c: Revert.
5121         * arm-wince-tdep.c: Revert.
5122         * arm-tdep.c: Revert.
5123         * arm-symbian-tdep.c: Revert.
5124         * arm-pikeos-tdep.c: Revert.
5125         * arm-obsd-tdep.c: Revert.
5126         * arm-nbsd-tdep.c: Revert.
5127         * arm-nbsd-nat.c: Revert.
5128         * arm-linux-tdep.c: Revert.
5129         * arm-linux-nat.c: Revert.
5130         * arm-fbsd-tdep.c: Revert.
5131         * arm-fbsd-nat.c: Revert.
5132         * arm-bsd-tdep.c: Revert.
5133         * arch-utils.c: Revert.
5134         * arc-tdep.c: Revert.
5135         * arc-newlib-tdep.c: Revert.
5136         * annotate.h: Revert.
5137         * annotate.c: Revert.
5138         * amd64-windows-tdep.c: Revert.
5139         * amd64-windows-nat.c: Revert.
5140         * amd64-tdep.c: Revert.
5141         * amd64-sol2-tdep.c: Revert.
5142         * amd64-obsd-tdep.c: Revert.
5143         * amd64-obsd-nat.c: Revert.
5144         * amd64-nbsd-tdep.c: Revert.
5145         * amd64-nbsd-nat.c: Revert.
5146         * amd64-nat.c: Revert.
5147         * amd64-linux-tdep.c: Revert.
5148         * amd64-linux-nat.c: Revert.
5149         * amd64-fbsd-tdep.c: Revert.
5150         * amd64-fbsd-nat.c: Revert.
5151         * amd64-dicos-tdep.c: Revert.
5152         * amd64-darwin-tdep.c: Revert.
5153         * amd64-bsd-nat.c: Revert.
5154         * alpha-tdep.c: Revert.
5155         * alpha-obsd-tdep.c: Revert.
5156         * alpha-nbsd-tdep.c: Revert.
5157         * alpha-mdebug-tdep.c: Revert.
5158         * alpha-linux-tdep.c: Revert.
5159         * alpha-linux-nat.c: Revert.
5160         * alpha-bsd-tdep.c: Revert.
5161         * alpha-bsd-nat.c: Revert.
5162         * aix-thread.c: Revert.
5163         * agent.c: Revert.
5164         * addrmap.c: Revert.
5165         * ada-varobj.c: Revert.
5166         * ada-valprint.c: Revert.
5167         * ada-typeprint.c: Revert.
5168         * ada-tasks.c: Revert.
5169         * ada-lang.c: Revert.
5170         * aarch64-tdep.c: Revert.
5171         * aarch64-ravenscar-thread.c: Revert.
5172         * aarch64-newlib-tdep.c: Revert.
5173         * aarch64-linux-tdep.c: Revert.
5174         * aarch64-linux-nat.c: Revert.
5175         * aarch64-fbsd-tdep.c: Revert.
5176         * aarch64-fbsd-nat.c: Revert.
5177         * aarch32-linux-nat.c: Revert.
5178
5179 2019-04-05  Tom Tromey  <tom@tromey.com>
5180
5181         * ft32-tdep.c: Sort headers.
5182         * frv-tdep.c: Sort headers.
5183         * frv-linux-tdep.c: Sort headers.
5184         * frame.c: Sort headers.
5185         * frame-unwind.c: Sort headers.
5186         * frame-base.c: Sort headers.
5187         * fork-child.c: Sort headers.
5188         * findvar.c: Sort headers.
5189         * findcmd.c: Sort headers.
5190         * filesystem.c: Sort headers.
5191         * filename-seen-cache.h: Sort headers.
5192         * filename-seen-cache.c: Sort headers.
5193         * fbsd-tdep.c: Sort headers.
5194         * fbsd-nat.h: Sort headers.
5195         * fbsd-nat.c: Sort headers.
5196         * f-valprint.c: Sort headers.
5197         * f-typeprint.c: Sort headers.
5198         * f-lang.c: Sort headers.
5199         * extension.h: Sort headers.
5200         * extension.c: Sort headers.
5201         * extension-priv.h: Sort headers.
5202         * expprint.c: Sort headers.
5203         * exec.h: Sort headers.
5204         * exec.c: Sort headers.
5205         * exceptions.c: Sort headers.
5206         * event-top.c: Sort headers.
5207         * event-loop.c: Sort headers.
5208         * eval.c: Sort headers.
5209         * elfread.c: Sort headers.
5210         * dwarf2read.h: Sort headers.
5211         * dwarf2read.c: Sort headers.
5212         * dwarf2loc.c: Sort headers.
5213         * dwarf2expr.h: Sort headers.
5214         * dwarf2expr.c: Sort headers.
5215         * dwarf2-frame.c: Sort headers.
5216         * dwarf2-frame-tailcall.c: Sort headers.
5217         * dwarf-index-write.h: Sort headers.
5218         * dwarf-index-write.c: Sort headers.
5219         * dwarf-index-common.c: Sort headers.
5220         * dwarf-index-cache.h: Sort headers.
5221         * dwarf-index-cache.c: Sort headers.
5222         * dummy-frame.c: Sort headers.
5223         * dtrace-probe.c: Sort headers.
5224         * disasm.h: Sort headers.
5225         * disasm.c: Sort headers.
5226         * disasm-selftests.c: Sort headers.
5227         * dictionary.c: Sort headers.
5228         * dicos-tdep.c: Sort headers.
5229         * demangle.c: Sort headers.
5230         * dcache.h: Sort headers.
5231         * dcache.c: Sort headers.
5232         * darwin-nat.h: Sort headers.
5233         * darwin-nat.c: Sort headers.
5234         * darwin-nat-info.c: Sort headers.
5235         * d-valprint.c: Sort headers.
5236         * d-namespace.c: Sort headers.
5237         * d-lang.c: Sort headers.
5238         * ctf.c: Sort headers.
5239         * csky-tdep.c: Sort headers.
5240         * csky-linux-tdep.c: Sort headers.
5241         * cris-tdep.c: Sort headers.
5242         * cris-linux-tdep.c: Sort headers.
5243         * cp-valprint.c: Sort headers.
5244         * cp-support.c: Sort headers.
5245         * cp-namespace.c: Sort headers.
5246         * cp-abi.c: Sort headers.
5247         * corelow.c: Sort headers.
5248         * corefile.c: Sort headers.
5249         * continuations.c: Sort headers.
5250         * completer.h: Sort headers.
5251         * completer.c: Sort headers.
5252         * complaints.c: Sort headers.
5253         * coffread.c: Sort headers.
5254         * coff-pe-read.c: Sort headers.
5255         * cli-out.h: Sort headers.
5256         * cli-out.c: Sort headers.
5257         * charset.c: Sort headers.
5258         * c-varobj.c: Sort headers.
5259         * c-valprint.c: Sort headers.
5260         * c-typeprint.c: Sort headers.
5261         * c-lang.c: Sort headers.
5262         * buildsym.c: Sort headers.
5263         * buildsym-legacy.c: Sort headers.
5264         * build-id.h: Sort headers.
5265         * build-id.c: Sort headers.
5266         * btrace.c: Sort headers.
5267         * bsd-uthread.c: Sort headers.
5268         * breakpoint.h: Sort headers.
5269         * breakpoint.c: Sort headers.
5270         * break-catch-throw.c: Sort headers.
5271         * break-catch-syscall.c: Sort headers.
5272         * break-catch-sig.c: Sort headers.
5273         * blockframe.c: Sort headers.
5274         * block.c: Sort headers.
5275         * bfin-tdep.c: Sort headers.
5276         * bfin-linux-tdep.c: Sort headers.
5277         * bfd-target.c: Sort headers.
5278         * bcache.c: Sort headers.
5279         * ax-general.c: Sort headers.
5280         * ax-gdb.h: Sort headers.
5281         * ax-gdb.c: Sort headers.
5282         * avr-tdep.c: Sort headers.
5283         * auxv.c: Sort headers.
5284         * auto-load.c: Sort headers.
5285         * arm-wince-tdep.c: Sort headers.
5286         * arm-tdep.c: Sort headers.
5287         * arm-symbian-tdep.c: Sort headers.
5288         * arm-pikeos-tdep.c: Sort headers.
5289         * arm-obsd-tdep.c: Sort headers.
5290         * arm-nbsd-tdep.c: Sort headers.
5291         * arm-nbsd-nat.c: Sort headers.
5292         * arm-linux-tdep.c: Sort headers.
5293         * arm-linux-nat.c: Sort headers.
5294         * arm-fbsd-tdep.c: Sort headers.
5295         * arm-fbsd-nat.c: Sort headers.
5296         * arm-bsd-tdep.c: Sort headers.
5297         * arch-utils.c: Sort headers.
5298         * arc-tdep.c: Sort headers.
5299         * arc-newlib-tdep.c: Sort headers.
5300         * annotate.h: Sort headers.
5301         * annotate.c: Sort headers.
5302         * amd64-windows-tdep.c: Sort headers.
5303         * amd64-windows-nat.c: Sort headers.
5304         * amd64-tdep.c: Sort headers.
5305         * amd64-sol2-tdep.c: Sort headers.
5306         * amd64-obsd-tdep.c: Sort headers.
5307         * amd64-obsd-nat.c: Sort headers.
5308         * amd64-nbsd-tdep.c: Sort headers.
5309         * amd64-nbsd-nat.c: Sort headers.
5310         * amd64-nat.c: Sort headers.
5311         * amd64-linux-tdep.c: Sort headers.
5312         * amd64-linux-nat.c: Sort headers.
5313         * amd64-fbsd-tdep.c: Sort headers.
5314         * amd64-fbsd-nat.c: Sort headers.
5315         * amd64-dicos-tdep.c: Sort headers.
5316         * amd64-darwin-tdep.c: Sort headers.
5317         * amd64-bsd-nat.c: Sort headers.
5318         * alpha-tdep.c: Sort headers.
5319         * alpha-obsd-tdep.c: Sort headers.
5320         * alpha-nbsd-tdep.c: Sort headers.
5321         * alpha-mdebug-tdep.c: Sort headers.
5322         * alpha-linux-tdep.c: Sort headers.
5323         * alpha-linux-nat.c: Sort headers.
5324         * alpha-bsd-tdep.c: Sort headers.
5325         * alpha-bsd-nat.c: Sort headers.
5326         * aix-thread.c: Sort headers.
5327         * agent.c: Sort headers.
5328         * addrmap.c: Sort headers.
5329         * ada-varobj.c: Sort headers.
5330         * ada-valprint.c: Sort headers.
5331         * ada-typeprint.c: Sort headers.
5332         * ada-tasks.c: Sort headers.
5333         * ada-lang.c: Sort headers.
5334         * aarch64-tdep.c: Sort headers.
5335         * aarch64-ravenscar-thread.c: Sort headers.
5336         * aarch64-newlib-tdep.c: Sort headers.
5337         * aarch64-linux-tdep.c: Sort headers.
5338         * aarch64-linux-nat.c: Sort headers.
5339         * aarch64-fbsd-tdep.c: Sort headers.
5340         * aarch64-fbsd-nat.c: Sort headers.
5341         * aarch32-linux-nat.c: Sort headers.
5342
5343 2019-04-04  Tom Tromey  <tom@tromey.com>
5344
5345         * varobj.c (varobj_create): Update.
5346         * rust-exp.y (struct rust_parser) <update_innermost_block,
5347         lookup_symbol>: New methods.
5348         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5349         Rename.
5350         (rust_parser::rust_lookup_type)
5351         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5352         * printcmd.c (display_command, do_one_display): Update.
5353         * parser-defs.h (struct parser_state) <parser_state>: Add
5354         "tracker" parameter.
5355         (block_tracker): New member.
5356         (class innermost_block_tracker) <innermost_block_tracker>: Add
5357         "types" parameter.
5358         <reset>: Remove method.
5359         (innermost_block): Don't declare.
5360         (null_post_parser): Update.
5361         * parse.c (innermost_block): Remove global.
5362         (write_dollar_variable): Update.
5363         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5364         Remove "tracker_types" parameter.
5365         (parse_expression): Add "tracker" parameter.
5366         (parse_expression_for_completion): Update.
5367         (null_post_parser): Add "tracker" parameter.
5368         * p-exp.y: Update rules.
5369         * m2-exp.y: Update rules.
5370         * language.h (struct language_defn) <la_post_parser>: Add
5371         "tracker" parameter.
5372         * go-exp.y: Update rules.
5373         * f-exp.y: Update rules.
5374         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5375         parameter.
5376         * d-exp.y: Update rules.
5377         * c-exp.y: Update rules.
5378         * breakpoint.c (set_breakpoint_condition): Create an
5379         innermost_block_tracker.
5380         (watch_command_1): Likewise.
5381         * ada-lang.c (resolve): Add "tracker" parameter.
5382         (resolve_subexp): Likewise.
5383         * ada-exp.y (write_var_from_sym): Update.
5384
5385 2019-04-04  Tom Tromey  <tom@tromey.com>
5386
5387         * type-stack.h: New file.
5388         * type-stack.c: New file.
5389         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5390         type-stack.h.
5391         (insert_into_type_stack, insert_type, push_type, push_type_int)
5392         (insert_type_address_space, pop_type, pop_type_int)
5393         (pop_typelist, pop_type_stack, append_type_stack)
5394         (push_type_stack, get_type_stack, push_typelist)
5395         (follow_type_instance_flags, follow_types): Don't declare.
5396         * parse.c (type_stack): Remove global.
5397         (parse_exp_in_context): Update.
5398         (insert_into_type_stack, insert_type, push_type, push_type_int)
5399         (insert_type_address_space, pop_type, pop_type_int)
5400         (pop_typelist, pop_type_stack, append_type_stack)
5401         (push_type_stack, get_type_stack, push_typelist)
5402         (follow_type_instance_flags, follow_types): Remove (moved to
5403         type-stack.c).
5404         * f-exp.y (type_stack): New global.
5405         Update rules.
5406         (push_kind_type, f_parse): Update.
5407         * d-exp.y (type_stack): New global.
5408         Update rules.
5409         (d_parse): Update.
5410         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5411         Update rules.
5412         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5413         (HFILES_NO_SRCDIR): Add type-stack.h.
5414
5415 2019-04-04  Tom Tromey  <tom@tromey.com>
5416
5417         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5418         (rust_parser::convert_ast_to_expression, rust_parse)
5419         (rust_lex_test_completion, rust_lex_tests): Update.
5420         * parser-defs.h (struct expr_completion_state): New.
5421         (struct parser_state) <parser_state>: Add completion parameter.
5422         <mark_struct_expression, mark_completion_tag>: New methods.
5423         <parse_completion, m_completion_state>: New members.
5424         (prefixify_expression, null_post_parser): Update.
5425         (mark_struct_expression, mark_completion_tag): Don't declare.
5426         * parse.c (parse_completion, expout_last_struct)
5427         (expout_tag_completion_type, expout_completion_name): Remove
5428         globals.
5429         (parser_state::mark_struct_expression)
5430         (parser_state::mark_completion_tag): Now methods.
5431         (prefixify_expression): Add last_struct parameter.
5432         (prefixify_subexp): Likewise.
5433         (parse_exp_1): Update.
5434         (parse_exp_in_context): Add cstate parameter.  Update.
5435         (parse_expression_for_completion): Create an
5436         expr_completion_state.
5437         (null_post_parser): Add "completion" parameter.
5438         * p-exp.y: Update rules.
5439         (yylex): Update.
5440         * language.h (struct language_defn) <la_post_parser>: Add
5441         "completing" parameter.
5442         * go-exp.y: Update rules.
5443         (lex_one_token): Update.
5444         * expression.h (parse_completion): Don't declare.
5445         * d-exp.y: Update rules.
5446         (lex_one_token): Update rules.
5447         * c-exp.y: Update rules.
5448         (lex_one_token): Update.
5449         * ada-lang.c (resolve): Add "parse_completion" parameter.
5450         (resolve_subexp): Likewise.
5451         (ada_resolve_function): Likewise.
5452
5453 2019-04-04  Tom Tromey  <tom@tromey.com>
5454
5455         * parser-defs.h (struct parser_state) <start_arglist,
5456         end_arglist>: New methods.
5457         <arglist_len, m_funcall_chain>: New members.
5458         (arglist_len, start_arglist, end_arglist): Don't declare.
5459         * parse.c (arglist_len, funcall_chain): Remove global.
5460         (start_arglist, end_arglist): Remove functions.
5461         (parse_exp_in_context): Update.
5462         * p-exp.y: Update rules.
5463         * m2-exp.y: Update rules.
5464         * go-exp.y: Update rules.
5465         * f-exp.y: Update rules.
5466         * d-exp.y: Update rules.
5467         * c-exp.y: Update rules.
5468
5469 2019-04-04  Tom Tromey  <tom@tromey.com>
5470
5471         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5472         lex_operator, push_back>: New methods.
5473         Update all rules.
5474         (rust_parser::lex_hex, lex_escape): Rename and update.
5475         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5476         (rust_parser::lex_operator): Rename and update.
5477         (rust_parser::lex_number, rustyylex, rustyyerror)
5478         (rust_lex_test_init, rust_lex_test_sequence)
5479         (rust_lex_test_push_back, rust_lex_tests): Update.
5480         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5481         parameter.
5482         <lexptr, prev_lexptr>: New members.
5483         (lexptr, prev_lexptr): Don't declare.
5484         * parse.c (lexptr, prev_lexptr): Remove globals.
5485         (parse_exp_in_context): Update.
5486         * p-exp.y (yylex, yyerror): Update.
5487         * m2-exp.y (parse_number, yylex, yyerror): Update.
5488         * go-exp.y (lex_one_token, yyerror): Update.
5489         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5490         * d-exp.y (lex_one_token, yyerror): Update.
5491         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5492         (lex_one_token, yyerror): Update.
5493         * ada-lex.l (YY_INPUT): Update.
5494         (rewind_to_char): Update.
5495         * ada-exp.y (yyerror): Update.
5496
5497 2019-04-04  Tom Tromey  <tom@tromey.com>
5498
5499         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5500         * parser-defs.h (struct parser_state) <parser_state>: Add new
5501         parameter.
5502         <comma_terminates>: New member.
5503         (comma_terminates): Don't declare global.
5504         * parse.c (comma_terminates): Remove global.
5505         (parse_exp_in_context): Update.
5506         * p-exp.y (yylex): Update.
5507         * m2-exp.y (yylex): Update.
5508         * go-exp.y (lex_one_token): Update.
5509         * f-exp.y (yylex): Update.
5510         * d-exp.y (lex_one_token): Update.
5511         * c-exp.y (lex_one_token): Update.
5512         * ada-lex.l: Update.
5513
5514 2019-04-04  Tom Tromey  <tom@tromey.com>
5515
5516         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5517         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5518         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5519         * parser-defs.h (paren_depth): Don't declare.
5520         * parse.c (paren_depth): Remove global.
5521         (parse_exp_in_context): Update.
5522         * p-exp.y (paren_depth): New global.
5523         (pascal_parse): Initialize it.
5524         * m2-exp.y (paren_depth): New global.
5525         (m2_parse): Initialize it.
5526         * go-exp.y (paren_depth): New global.
5527         (go_parse): Initialize it.
5528         * f-exp.y (paren_depth): New global.
5529         (f_parse): Initialize it.
5530         * d-exp.y (paren_depth): New global.
5531         (d_parse): Initialize it.
5532         * c-exp.y (paren_depth): New global.
5533         (c_parse): Initialize it.
5534         * ada-lex.l (paren_depth): New global.
5535         (lexer_init): Initialize it.
5536
5537 2019-04-04  Tom Tromey  <tom@tromey.com>
5538
5539         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5540         (rust_parser::convert_ast_to_type)
5541         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5542         * parser-defs.h (struct parser_state) <parser_state>: Add
5543         parameters.  Initialize new members.
5544         <expression_context_block, expression_context_pc>: New members.
5545         * parse.c (expression_context_block, expression_context_pc):
5546         Remove globals.
5547         (parse_exp_in_context): Update.
5548         * p-exp.y: Update all rules.
5549         (yylex): Update.
5550         * m2-exp.y: Update all rules.
5551         (yylex): Update.
5552         * go-exp.y (yylex): Update.
5553         * f-exp.y (yylex): Update.
5554         * d-exp.y: Update all rules.
5555         (yylex): Update.
5556         * c-exp.y: Update all rules.
5557         (lex_one_token, classify_name, yylex, c_parse): Update.
5558         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5559
5560 2019-04-04  Tom Tromey  <tom@tromey.com>
5561
5562         * gdbarch.h, gdbarch.c: Rebuild.
5563         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5564         * stap-probe.h:
5565         (struct stap_parse_info): Replace "parser_state" with
5566         "expr_builder".
5567         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5568         (parser_state): New class.
5569         * parse.c (expr_builder): Rename.
5570         (expr_builder::release): Rename.
5571         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5572         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5573         (write_exp_elt_longcst, write_exp_elt_floatcst)
5574         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5575         (write_exp_string_vector, write_exp_bitstring)
5576         (write_exp_msymbol, mark_struct_expression)
5577         (write_dollar_variable)
5578         (insert_type_address_space, increase_expout_size): Replace
5579         "parser_state" with "expr_builder".
5580         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5581         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5582         "parser_state" with "expr_builder".
5583
5584 2019-04-04  Tom Tromey  <tom@tromey.com>
5585
5586         * rust-exp.y: Replace "parse_language" with method call.
5587         * p-exp.y:
5588         (yylex): Replace "parse_language" with method call.
5589         * m2-exp.y:
5590         (yylex): Replace "parse_language" with method call.
5591         * go-exp.y (classify_name): Replace "parse_language" with method
5592         call.
5593         * f-exp.y (yylex): Replace "parse_language" with method call.
5594         * d-exp.y (lex_one_token): Replace "parse_language" with method
5595         call.
5596         * c-exp.y:
5597         (lex_one_token, classify_name, yylex): Replace "parse_language"
5598         with method call.
5599         * ada-exp.y (find_primitive_type, type_char)
5600         (type_system_address): Replace "parse_language" with method call.
5601
5602 2019-04-04  Tom Tromey  <tom@tromey.com>
5603
5604         * rust-exp.y: Replace "parse_gdbarch" with method call.
5605         * parse.c (write_dollar_variable, insert_type_address_space):
5606         Replace "parse_gdbarch" with method call.
5607         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5608         call.
5609         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5610         call.
5611         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5612         "parse_gdbarch" with method call.
5613         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5614         with method call.
5615         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5616         "parse_gdbarch" with method call.
5617         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5618         "parse_gdbarch" with method call.
5619         * c-exp.y (parse_type, parse_number, classify_name): Replace
5620         "parse_gdbarch" with method call.
5621         * ada-lex.l: Replace "parse_gdbarch" with method call.
5622         * ada-exp.y (parse_type, find_primitive_type, type_char)
5623         (type_system_address): Replace "parse_gdbarch" with method call.
5624
5625 2019-04-04  Tom Tromey  <tom@tromey.com>
5626
5627         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5628         * stap-probe.c (stap_parse_argument): Update.
5629         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5630         initial_size parameter.
5631         * rust-exp.y (rust_lex_tests): Update.
5632         * parse.c (parser_state): Update.
5633         (parse_exp_in_context): Update.
5634         * parser-defs.h (struct parser_state) <parser_state>: Remove
5635         "initial_size" parameter.
5636
5637 2019-04-04  Tom Tromey  <tom@tromey.com>
5638
5639         * parser-defs.h (increase_expout_size): Don't declare.
5640         * parse.c (increase_expout_size): Now static.
5641
5642 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5643
5644         * gnu-nat.c (gnu_nat_target::wait): Fix
5645         target_waitstatus_to_string call.
5646
5647 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5648
5649         * eval.c (evaluate_subexp_standard): Handle internal functions
5650         during Fortran function call handling.
5651
5652 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5653
5654         * NEWS: Mention new internal functions.
5655         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5656         (read_base_type): Use dwarf2_init_complex_target_type.
5657         * value.c (creal_internal_fn): New function.
5658         (cimag_internal_fn): New function.
5659         (_initialize_values): Register new internal functions.
5660
5661 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5662
5663         * infrun.c (stop_all_threads): If debug_infrun, always
5664         trace the wait status after wait_one, using
5665         target_waitstatus_to_string and target_pid_to_str.
5666         (handle_inferior_event): Replace various trace of
5667         wait status kind by a single trace.
5668         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5669         wait status kind image by target_waitstatus_to_string.
5670         * target/waitstatus.c (target_waitstatus_to_string): Fix
5671         obsolete comment.
5672
5673 2019-04-01  Tom Tromey  <tromey@adacore.com>
5674
5675         PR symtab/23331:
5676         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5677
5678 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5679             Pedro Alves  <palves@redhat.com>
5680
5681         * top.c (quit_force): Call 'finalize_values'.
5682         * value.c (finalize_values): New function.
5683         * value.h (finalize_values): Declare.
5684
5685 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5686
5687         * NEWS: Announce $_gdb_major and $_gdb_minor.
5688
5689         * top.c (init_gdb_version_vars): New function.
5690         (gdb_init): Call init_gdb_version_vars.
5691
5692 2019-03-29  Tom Tromey  <tromey@adacore.com>
5693
5694         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5695         help text.  Remove dead code.
5696
5697 2019-03-29  Keith Seitz  <keiths@redhat.com>
5698
5699         From Siddhesh Poyarekar:
5700         * f-lang.h (f77_get_upperbound): Return LONGEST.
5701         (f77_get_lowerbound): Likewise.
5702         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5703         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5704         print them.
5705         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5706         plongest to format print it.
5707         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5708         (f77_get_upperbound): Likewise.
5709         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5710         LOWER_BOUND to LONGEST.
5711         (f77_create_arrayprint_offset_tbl): Likewise.
5712
5713 2019-03-29  Keith Seitz  <keiths@redhat.com>
5714
5715         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5716         %s/pulongest for TYPE_LENGTH instead of %d in format
5717         strings.
5718         * ada-typerint.c (ada_print_type): Likewise.
5719         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5720         * compile/compile-c-support.c (generate_register_struct): Likewise.
5721         * gdbtypes.c (recursive_dump_type): Likewise.
5722         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5723         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5724         instead of %d in format strings.
5725         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5726         to std::min to ULONGEST.
5727         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5728         instead of %d in format strings.
5729         * tracepoint.c (info_scope_command): Likewise.
5730         * typeprint.c (print_offset_data::update)
5731         (print_offset_data::finish): Likewise.
5732         * xtensa-tdep.c (xtensa_store_return_value)
5733         (xtensa_push_dummy_call): Likewise.
5734
5735 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5736
5737         * windows-nat.c (display_selector): Fixed format specifications
5738         for 64-bit Cygwin.
5739
5740 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5741
5742         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5743
5744 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5745
5746         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5747         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5748         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5749         (nios2_linux_init_abi): Install it.
5750
5751 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5752
5753         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5754
5755 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5756
5757         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5758
5759 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5760             Tom Tromey  <tromey@adacore.com>
5761
5762         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5763
5764 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5765
5766         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5767         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5768         method to compute the bounds of range types. Also print "[evaluated]"
5769         if the bounds' values come from a dynamic evaluation.
5770
5771 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5772
5773         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5774         whitespace when pretty printing is on.
5775
5776 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5777
5778         * ppc-linux-nat.c: Add include.
5779
5780 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5781
5782         * NEWS: Mention AArch64 Pointer Authentication.
5783
5784 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5785
5786         * arm-linux-nat.c: Add include.
5787
5788 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5789
5790         * source-cache.c (source_cache::get_source_lines): Re-read
5791         fullname after calling open_source_file.
5792
5793 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5794
5795         * NEWS: Mention TLS support for FreeBSD.
5796
5797 2019-03-25  Tom Tromey  <tromey@adacore.com>
5798
5799         * minsyms.c (BUNCH_SIZE): Update comment.
5800         (~minimal_symbol_reader): Remove old comment.
5801         (compact_minimal_symbols): Update comment.
5802         (minimal_symbol_reader::install): Remove old comment.  Update
5803         other comments.
5804
5805 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5806
5807         * s390-linux-nat.c: Add include.
5808
5809 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5810
5811         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5812         Call linux_get_hwcap.
5813         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5814         Likewise.
5815         (aarch64_linux_get_hwcap): Remove function.
5816         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5817         declaration.
5818         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5819         linux_get_hwcap.
5820         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5821         * linux-tdep.c (linux_get_hwcap): Add function.
5822         (linux_get_hwcap2): Likewise.
5823         * linux-tdep.h (linux_get_hwcap): Add declaration.
5824         (linux_get_hwcap2): Likewise.
5825         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5826         (ppc_linux_get_hwcap2): Likewise.
5827         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5828         linux_get_hwcap.
5829         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5830         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5831         (ppc_linux_nat_target::read_description): Likewise.
5832         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5833         * s390-linux-nat.c: Likewise.
5834         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5835
5836 2019-03-24  Tom Tromey  <tom@tromey.com>
5837
5838         * ada-lang.c (standard_lookup): Simplify initialization.
5839         (ada_lookup_symbol_nonlocal): Simplify return.
5840         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5841         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5842         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5843         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5844         initialization.
5845         * solib.c (solib_global_lookup): Simplify.
5846         * symtab.c (null_block_symbol): Remove.
5847         (symbol_cache_lookup): Simplify returns.
5848         (lookup_language_this): Simplify returns.
5849         (lookup_symbol_aux): Simplify return.
5850         (lookup_local_symbol): Simplify returns.
5851         (lookup_global_symbol_from_objfile): Simplify return.
5852         (lookup_symbol_in_objfile_symtabs)
5853         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5854         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5855         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5856         * cp-namespace.c (cp_lookup_bare_symbol)
5857         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5858         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5859         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5860         (cp_lookup_symbol_via_imports): Simplify initialization.
5861         (find_symbol_in_baseclass): Likewise.
5862         * symtab.h (null_block_symbol): Remove.
5863         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5864         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5865         (d_lookup_symbol_module): Likewise.
5866         (find_symbol_in_baseclass): Simplify initialization.
5867
5868 2019-03-24  Tom Tromey  <tom@tromey.com>
5869
5870         * expression.h: Don't include symtab.h.
5871         (struct block): Forward declare.
5872
5873 2019-03-24  Tom Tromey  <tom@tromey.com>
5874
5875         * c-exp.y (typebase): Remove casts.
5876         * gdbtypes.c (lookup_unsigned_typename, )
5877         (lookup_signed_typename): Remove cast.
5878         * eval.c (parse_to_comma_and_eval): Remove cast.
5879         * parse.c (write_dollar_variable): Remove cast.
5880         * block.h (struct block) <superblock>: Now const.
5881         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5882         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5883         (map_block): Make "block" const.
5884         * symfile.h (struct quick_symbol_functions)
5885         <map_matching_symbols>: Constify block argument to "callback".
5886         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5887         const.
5888         (find_pc_sect_compunit_symtab): Make "b" const.
5889         (find_symbol_at_address): Likewise.
5890         (search_symbols): Likewise.
5891         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5892         (dw2_debug_names_lookup_symbol): Likewise.
5893         (dw2_map_matching_symbols): Update.
5894         * p-valprint.c (pascal_val_print): Remove "block".
5895         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5896         (aux_add_nonlocal_symbols): Make "block" const.
5897         (resolve_subexp): Remove cast.
5898         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5899         const.
5900         (iterate_over_file_blocks): Likewise.
5901         * f-exp.y (%union) <bval>: Remove.
5902         * coffread.c (patch_opaque_types): Make "b" const.
5903         * spu-tdep.c (spu_catch_start): Make "block" const.
5904         * c-valprint.c (print_unpacked_pointer): Remove "block".
5905         * symmisc.c (dump_symtab_1): Make "b" const.
5906         (block_depth): Make "block" const.
5907         * d-exp.y (%union) <bval>: Remove.
5908         * cp-support.h (cp_lookup_rtti_type): Update.
5909         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5910         * psymtab.c (psym_lookup_symbol): Make "block" const.
5911         (maintenance_check_psymtabs): Make "b" const.
5912         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5913         (enumerate_locals, enumerate_args): Update.
5914         * python/py-symtab.c (stpy_global_block): Make "block" const.
5915         (stpy_static_block): Likewise.
5916         * inline-frame.c (block_starting_point_at): Make "new_block"
5917         const.
5918         * block.c (find_block_in_blockvector): Make return type const.
5919         (blockvector_for_pc_sect): Make "b" const.
5920         (find_block_in_blockvector): Make "b" const.
5921
5922 2019-03-23  Tom Tromey  <tom@tromey.com>
5923
5924         * varobj.c (varobj_create): Update.
5925         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5926         * printcmd.c (display_command, do_one_display): Don't reset
5927         innermost_block.
5928         * parser-defs.h (enum innermost_block_tracker_type): Move to
5929         expression.h.
5930         (innermost_block): Update comment.
5931         * parse.c (parse_exp_1): Add tracker_types parameter.
5932         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5933         tracker_types parameter.  Reset innermost_block.
5934         (parse_exp_in_context): Remove.
5935         (parse_expression_for_completion): Update.
5936         * objfiles.c (~objfile): Don't reset expression_context_block or
5937         innermost_block.
5938         * expression.h (enum innermost_block_tracker_type): Move from
5939         parser-defs.h.
5940         (parse_exp_1): Add tracker_types parameter.
5941         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5942         reset innermost_block.
5943
5944 2019-03-23  Tom Tromey  <tom@tromey.com>
5945
5946         * objfiles.h: Include bcache.h.
5947
5948 2019-03-23  Tom Tromey  <tom@tromey.com>
5949
5950         * linespec.c (get_current_search_block): Use
5951         scoped_restore_current_language.
5952         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5953
5954 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5955             Jiong Wang  <jiong.wang@arm.com>
5956
5957         * aarch64-linux-tdep.c
5958         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5959         section.
5960         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5961
5962 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5963             Jiong Wang  <jiong.wang@arm.com>
5964
5965         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5966         instructions.
5967         (aarch64_analyze_prologue_test): Add PACIASP test.
5968         (aarch64_prologue_prev_register): Unmask PC value.
5969
5970 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5971             Jiong Wang  <jiong.wang@arm.com>
5972
5973         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5974         (aarch64_dwarf2_prev_register): Unmask PC value.
5975         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5976         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5977         DW_CFA_AARCH64_negate_ra_state.
5978         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5979
5980 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5981             Jiong Wang  <jiong.wang@arm.com>
5982
5983         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5984         registers.
5985         (aarch64_pseudo_register_name): Likewise.
5986         (aarch64_pseudo_register_type): Likewise.
5987         (aarch64_pseudo_register_reggroup_p): Likewise.
5988         (aarch64_gdbarch_init): Add pauth registers.
5989         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5990         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5991         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5992         (struct gdbarch_tdep): Add regnum for ra_state.
5993
5994 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5995             Jiong Wang  <jiong.wang@arm.com>
5996
5997         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5998
5999 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6000             Jiong Wang  <jiong.wang@arm.com>
6001
6002         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6003         function.
6004         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6005         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6006         (aarch64_gdbarch_init): Add puth registers.
6007         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6008         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6009         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6010
6011 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6012             Jiong Wang  <jiong.wang@arm.com>
6013
6014         * aarch64-linux-nat.c
6015         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6016         * aarch64-linux-tdep.c
6017         (aarch64_linux_core_read_description): Likewise.
6018         (aarch64_linux_get_hwcap): New function.
6019         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6020         (aarch64_linux_get_hwcap): New declaration.
6021
6022 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6023             Jiong Wang  <jiong.wang@arm.com>
6024
6025         * aarch64-linux-nat.c
6026         (aarch64_linux_nat_target::read_description): Add pauth param.
6027         * aarch64-linux-tdep.c
6028         (aarch64_linux_core_read_description): Likewise.
6029         * aarch64-tdep.c (struct target_desc): Add in pauth.
6030         (aarch64_read_description): Add pauth param.
6031         (aarch64_gdbarch_init): Likewise.
6032         * aarch64-tdep.h (aarch64_read_description): Likewise.
6033         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6034         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6035         * features/Makefile: Add new files.
6036         * features/aarch64-pauth.c: New file.
6037         * features/aarch64-pauth.xml: New file.
6038
6039 2019-03-20  Tom Tromey  <tromey@adacore.com>
6040
6041         * infrun.c (handle_inferior_event): Rename from
6042         handle_inferior_event_1.  Create a scoped_value_mark.
6043         (handle_inferior_event): Remove.
6044
6045 2019-03-19  Tom Tromey  <tromey@adacore.com>
6046
6047         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6048         * infrun.h (print_stop_event): Add "displays" parameter.
6049         * infrun.c (print_stop_event): Add "displays" parameter.
6050
6051 2019-03-19  Pedro Alves  <palves@redhat.com>
6052
6053         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6054         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6055         to -1.  Fix TABs vs spaces.
6056         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6057         * tui/tui-out.h (tui_ui_out) Add intro comments.
6058         <m_line, m_start_of_line>: In-class initialize, and add describing
6059         comment.
6060
6061 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6062
6063         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6064         variable names.
6065         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6066
6067 2019-03-18  Pedro Alves  <palves@redhat.com>
6068             Eli Zaretskii <eliz@gnu.org>
6069
6070         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6071         m_line and m_start_of_line.
6072
6073 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6074
6075         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6076         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6077         it returns a newline.  This fixes a regression in TU mode, whereby
6078         the next line is output on the same screen line as the user input.
6079
6080 2019-03-18  Tom Tromey  <tromey@adacore.com>
6081
6082         * minsyms.c (minimal_symbol_reader::install): Remove call to
6083         obstack_blank.
6084
6085 2019-03-18  Pedro Alves  <palves@redhat.com>
6086
6087         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6088         New globals.
6089         (apply_style): New, factored out from ...
6090         (apply_ansi_escape): ... this.  Handle reverse video mode.
6091         (tui_set_reverse_mode): New function.
6092         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6093         * tui/tui-winsource.c (tui_show_source_line): Use
6094         tui_set_reverse_mode instead of setting A_STANDOUT.
6095         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6096         New setter methods.
6097
6098 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6099
6100         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6101         Handle tabs.
6102
6103 2019-03-18  Tom Tromey  <tromey@adacore.com>
6104
6105         * ada-lang.c (empty_array): Add "high" parameter.
6106         (ada_evaluate_subexp): Update.
6107
6108 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6109
6110         * unittests/string_view-selftests.c: Define
6111         _initialize_string_view_selftests unconditionally.
6112
6113 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6114
6115         PR gdb/24350
6116         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6117
6118 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6119
6120         PR gdb/24351
6121         * windows-nat.c (display_selector): Fix format specifiers.
6122
6123 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6124
6125         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6126         tui_refill_source_window instead of tui_refresh_win, to update the
6127         current execution line.  This fixes redisplay of the current line
6128         when stepping through the code with "next" or "step".
6129
6130 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6131
6132         * source-cache.c (source_cache::get_source_lines): Call
6133         find_source_lines to initialize s->nlines.  This fixes vertical
6134         scrolling of TUI source window when the DOWN arrow is pressed.
6135
6136 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6137
6138         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6139         linux-thread-db.c (_initialize_thread_db): Likewise.
6140
6141 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6142
6143         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6144         wclrtoeol in tui_show_source_line".  This reverts changes made in
6145         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6146
6147 2019-03-15  Tom Tromey  <tom@tromey.com>
6148
6149         * symtab.h (struct minimal_symbol): Derive from
6150         general_symbol_info.
6151         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6152         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6153         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6154         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6155         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6156         (MSYMBOL_SEARCH_NAME): Update.
6157         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6158         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6159         * minsyms.c (minimal_symbol_reader::record_full): Update.
6160
6161 2019-03-15  Tom Tromey  <tom@tromey.com>
6162
6163         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6164
6165 2019-03-15  Tom Tromey  <tom@tromey.com>
6166
6167         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6168         unique_xmalloc_ptr.
6169         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6170         Update.
6171         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6172         (build_minimal_symbol_hash_tables)
6173         (minimal_symbol_reader::install): Update.
6174
6175 2019-03-15  Tom Tromey  <tom@tromey.com>
6176
6177         * symtab.c (create_demangled_names_hash): Update.
6178         (symbol_set_names): Update.
6179         * objfiles.h (struct objfile_per_bfd_storage)
6180         <demangled_names_hash>: Now an htab_up.
6181         * objfiles.c (objfile_per_bfd_storage): Simplify.
6182
6183 2019-03-15  Tom Tromey  <tom@tromey.com>
6184
6185         * objfiles.h (struct objfile_per_bfd_storage): Declare
6186         destructor.
6187         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6188         New.
6189         (get_objfile_bfd_data): Use new.  Don't initialize
6190         language_of_main.
6191         (free_objfile_per_bfd_storage): Remove.
6192         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6193
6194 2019-03-15  Tom Tromey  <tom@tromey.com>
6195
6196         * symfile.c (reread_symbols): Update.
6197         * objfiles.c (objfile::objfile): Update.
6198         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6199         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6200         comment.
6201         (minimal_symbol_reader::install): Update.
6202         (terminate_minimal_symbol_table): Remove.
6203         * jit.c (jit_object_close_impl): Update.
6204
6205 2019-03-15  Tom Tromey  <tom@tromey.com>
6206
6207         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6208         initializations.
6209
6210 2019-03-15  Tom Tromey  <tom@tromey.com>
6211
6212         * objfiles.h (struct objfile_per_bfd_storage)
6213         <demangled_hash_languages>: Now a bitset.
6214         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6215         (lookup_minimal_symbol): Update.
6216
6217 2019-03-15  Tom Tromey  <tom@tromey.com>
6218
6219         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6220         Don't return the symbol.
6221         * coffread.c (record_minimal_symbol): Use record_full.
6222
6223 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6224
6225         The MS-Windows port of ncurses fails to switch to a color pair if
6226         one or both of the colors are the implicit default colors.  This
6227         change records the default colors when TUI is initialized, and
6228         then specifies them explicitly when a color pair uses the default
6229         colors.  This allows color styling in TUI mode on MS-Windows.
6230
6231         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6232         ncurses_norm_attr.
6233         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6234         colors in ncurses_norm_attr.
6235         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6236         "none", replace it with the default color recorded in
6237         ncurses_norm_attr.
6238
6239 2019-03-14  Tom Tromey  <tromey@adacore.com>
6240
6241         * source-cache.h (class source_cache) <get_source_lines>: Return
6242         std::string.
6243         * source-cache.c (source_cache::extract_lines): Handle case where
6244         first_pos==npos.  Return std::string.
6245         (source_cache::get_source_lines): Update.
6246
6247 2019-03-14  Tom Tromey  <tromey@adacore.com>
6248
6249         * NEWS: Add item for "style sources" commands.
6250         * source-cache.c (source_cache::get_source_lines): Check
6251         source_styling.
6252         * cli/cli-style.c (source_styling): New global.
6253         (_initialize_cli_style): Add "style sources" commands.
6254         (show_style_sources): New function.
6255         * cli/cli-style.h (source_styling): Declare.
6256
6257 2019-03-14  Pedro Alves  <palves@redhat.com>
6258             Tom Tromey  <tromey@adacore.com>
6259
6260         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6261         * tui/tui-winsource.c (tui_refill_source_window): New function,
6262         from...
6263         (tui_horizontal_source_scroll): ... here.  Move some logic.
6264         * cli/cli-style.c (set_style_enabled): Notify new observable.
6265         * tui/tui-hooks.c (tui_redisplay_source): New function.
6266         (tui_attach_detach_observers): Attach or detach
6267         tui_redisplay_source.
6268         * observable.h (source_styling_changed): New observable.
6269         * observable.c: Define source_styling_changed observable.
6270
6271 2019-03-13  Tom Tromey  <tromey@adacore.com>
6272
6273         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6274         (i386_gnu_nat_target::store_registers): Update.
6275         * target-debug.h (target_debug_print_std_string): New macro.
6276         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6277         * windows-tdep.c (display_one_tib): Update.
6278         * tui/tui-stack.c (tui_make_status_line): Update.
6279         * top.c (print_inferior_quit_action): Update.
6280         * thread.c (thr_try_catch_cmd): Update.
6281         (add_thread_with_info): Update.
6282         (thread_target_id_str): Update.
6283         (thr_try_catch_cmd): Update.
6284         (thread_command): Update.
6285         (thread_find_command): Update.
6286         * record-btrace.c (record_btrace_target::info_record)
6287         (record_btrace_resume_thread, record_btrace_target::resume)
6288         (record_btrace_cancel_resume, record_btrace_step_thread)
6289         (record_btrace_target::wait, record_btrace_target::wait)
6290         (record_btrace_target::wait, record_btrace_target::stop): Update.
6291         * progspace.c (print_program_space): Update.
6292         * process-stratum-target.c
6293         (process_stratum_target::thread_address_space): Update.
6294         * linux-fork.c (linux_fork_mourn_inferior)
6295         (detach_checkpoint_command, info_checkpoints_command)
6296         (linux_fork_context): Update.
6297         (linux_fork_detach): Update.
6298         (class scoped_switch_fork_info): Update.
6299         (delete_checkpoint_command): Update.
6300         * infrun.c (follow_fork_inferior): Update.
6301         (follow_fork_inferior): Update.
6302         (proceed_after_vfork_done): Update.
6303         (handle_vfork_child_exec_or_exit): Update.
6304         (follow_exec): Update.
6305         (displaced_step_prepare_throw): Update.
6306         (displaced_step_restore): Update.
6307         (start_step_over): Update.
6308         (resume_1): Update.
6309         (clear_proceed_status_thread): Update.
6310         (proceed): Update.
6311         (print_target_wait_results): Update.
6312         (do_target_wait): Update.
6313         (context_switch): Update.
6314         (stop_all_threads): Update.
6315         (restart_threads): Update.
6316         (finish_step_over): Update.
6317         (handle_signal_stop): Update.
6318         (switch_back_to_stepped_thread): Update.
6319         (keep_going_pass_signal): Update.
6320         (print_exited_reason): Update.
6321         (normal_stop): Update.
6322         * inferior.c (inferior_pid_to_str): Change return type.
6323         (print_selected_inferior): Update.
6324         (add_inferior): Update.
6325         (detach_inferior): Update.
6326         * dummy-frame.c (fprint_dummy_frames): Update.
6327         * dcache.c (dcache_info_1): Update.
6328         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6329         (btrace_fetch, btrace_clear): Update.
6330         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6331         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6332         type.
6333         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6334         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6335         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6336         * gdbarch.c, gdbarch.h: Rebuild.
6337         * gdbarch.sh (core_pid_to_str): Change return type.
6338         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6339         return type.
6340         (windows_nat_target::pid_to_str): Change return type.
6341         (windows_delete_thread): Update.
6342         (windows_nat_target::attach): Update.
6343         (windows_nat_target::files_info): Update.
6344         * target-delegates.c: Rebuild.
6345         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6346         return type.
6347         (sol_thread_target::pid_to_str): Change return type.
6348         * remote.c (class remote_target) <pid_to_str>: Change return
6349         type.
6350         (remote_target::pid_to_str): Change return type.
6351         (extended_remote_target::attach, remote_target::remote_stop_ns)
6352         (remote_target::remote_notif_remove_queued_reply)
6353         (remote_target::push_stop_reply, remote_target::disable_btrace):
6354         Update.
6355         (extended_remote_target::attach): Update.
6356         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6357         type.
6358         (gdbsim_target::pid_to_str): Change return type.
6359         * ravenscar-thread.c (struct ravenscar_thread_target)
6360         <pid_to_str>: Change return type.
6361         (ravenscar_thread_target::pid_to_str): Change return type.
6362         * procfs.c (class procfs_target) <pid_to_str>: Change return
6363         type.
6364         (procfs_target::pid_to_str): Change return type.
6365         (procfs_target::attach): Update.
6366         (procfs_target::detach): Update.
6367         (procfs_target::fetch_registers): Update.
6368         (procfs_target::store_registers): Update.
6369         (procfs_target::wait): Update.
6370         (procfs_target::files_info): Update.
6371         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6372         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6373         return type.
6374         (nto_procfs_target::pid_to_str): Change return type.
6375         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6376         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6377         return type.
6378         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6379         (exit_lwp): Update.
6380         (attach_proc_task_lwp_callback, get_detach_signal)
6381         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6382         (linux_nat_target::resume, wait_lwp, stop_callback)
6383         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6384         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6385         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6386         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6387         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6388         type.
6389         (inf_ptrace_target::attach): Update.
6390         (inf_ptrace_target::files_info): Update.
6391         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6392         type.
6393         (go32_nat_target::pid_to_str): Change return type.
6394         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6395         (gnu_nat_target::wait): Update.
6396         (gnu_nat_target::wait): Update.
6397         (gnu_nat_target::resume): Update.
6398         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6399         (fbsd_nat_target::wait): Update.
6400         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6401         type.
6402         (darwin_nat_target::attach): Update.
6403         * corelow.c (class core_target) <pid_to_str>: Change return type.
6404         (core_target::pid_to_str): Change return type.
6405         * target.c (normal_pid_to_str): Change return type.
6406         (default_pid_to_str): Likewise.
6407         (target_pid_to_str): Change return type.
6408         (target_translate_tls_address): Update.
6409         (target_announce_detach): Update.
6410         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6411         return type.
6412         (bsd_uthread_target::pid_to_str): Change return type.
6413         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6414         type.
6415         (bsd_kvm_target::pid_to_str): Change return type.
6416         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6417         return type.
6418         (aix_thread_target::pid_to_str): Change return type.
6419         * target.h (struct target_ops) <pid_to_str>: Change return type.
6420         (target_pid_to_str, normal_pid_to_str): Likewise.
6421         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6422         type.
6423         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6424         type.
6425         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6426         return type.
6427         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6428         type.
6429         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6430         type.
6431         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6432         return type.
6433
6434 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6435
6436         * NEWS: Mention that the new default MI version is 3.  Mention
6437         changes to the output of commands and events that deal with
6438         multi-location breakpoints.
6439         * breakpoint.c: Include "mi/mi-out.h".
6440         (print_one_breakpoint): Change output syntax if using MI version
6441         >= 3.
6442         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6443         New.
6444         (mi_multi_location_breakpoint_output_fixed): New.
6445         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6446         (mi_cmd_fix_multi_location_breakpoint_output): New.
6447         (mi_multi_location_breakpoint_output_fixed): New.
6448         * mi/mi-cmds.c (mi_cmds): Register command
6449         -fix-multi-location-breakpoint-output.
6450         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6451         interpreter "mi".
6452
6453 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6454
6455         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6456         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6457         instantiate mi_ui_out based on interpreter name.
6458         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6459         * mi/mi-main.c (mi_load_progress): Likewise.
6460
6461 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6462
6463         * NEWS: Combine separate "New targets" sections for 8.3.
6464
6465 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6466
6467         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6468         (ppcfbsd_init_abi): Install gdbarch
6469         "fetch_tls_load_module_address" and "get_thread_local_address"
6470         methods.
6471
6472 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6473
6474         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6475         (riscv_fbsd_init_abi): Install gdbarch
6476         "fetch_tls_load_module_address" and "get_thread_local_address"
6477         methods.
6478
6479 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6480
6481         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6482         (i386fbsd_init_abi): Install gdbarch
6483         "fetch_tls_load_module_address" and "get_thread_local_address"
6484         methods.
6485
6486 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6487
6488         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6489         (amd64fbsd_init_abi): Install gdbarch
6490         "fetch_tls_load_module_address" and "get_thread_local_address"
6491         methods.
6492
6493 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6494
6495         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6496         (struct fbsd_pspace_data): New type.
6497         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6498         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6499         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6500         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6501         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6502
6503 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6504
6505         * gdbtypes.c (lookup_struct_elt): New function.
6506         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6507         * gdbtypes.h (struct struct_elt): New type.
6508         (lookup_struct_elt): New prototype.
6509
6510 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6511
6512         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6513         remove disabled code block.
6514
6515 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6516
6517         * gdbarch.sh (get_thread_local_address): New method.
6518         * gdbarch.h, gdbarch.c: Regenerate.
6519         * target.c (target_translate_tls_address): Use
6520         gdbarch_get_thread_local_address if present instead of
6521         target::get_thread_local_address.
6522
6523 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6524
6525         * target.h (target::get_thread_local_address): Update comment.
6526
6527 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6528
6529         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6530         objfile->separate_debug_objfile_backlink if not NULL.
6531
6532 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6533
6534         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6535         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6536         (amd64bsd_store_inferior_registers): Likewise.
6537         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6538         Enable segment base registers.
6539         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6540         PT_GETFSBASE and PT_GETGSBASE.
6541         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6542         PT_SETGSBASE.
6543         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6544         segment base registers.
6545         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6546
6547 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6548
6549         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6550         Update calls to i386_target_description to add 'segments'
6551         parameter.
6552         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6553         add segment base registers.
6554         * arch/i386.c (i386_create_target_description): Add 'segments'
6555         parameter to enable segment base registers.
6556         * arch/i386.h (i386_create_target_description): Likewise.
6557         * features/i386/32bit-segments.xml: New file.
6558         * features/i386/32bit-segments.c: Generate.
6559         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6560         call to i386_target_description to add 'segments' parameter.
6561         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6562         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6563         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6564         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6565         if feature is present.
6566         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6567         Add 'segments' parameter to call to i386_target_description.
6568         (i386_target_description): Add 'segments' parameter to enable
6569         segment base registers.
6570         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6571         to call to i386_target_description.
6572         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6573         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6574         Define I386_NUM_REGS.
6575         (i386_target_description): Add 'segments' parameter to enable
6576         segment base registers.
6577
6578 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6579
6580         PR/24325
6581         * source-cache.c: #undef open and close, to avoid unresolved
6582         externals during linking.
6583
6584 2019-03-12  Tom Tromey  <tromey@adacore.com>
6585
6586         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6587         const.  Add initializers.
6588         (_initialize_remote): Don't initialize ptid globals.
6589
6590 2019-03-12  Pedro Alves  <palves@redhat.com>
6591
6592         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6593
6594 2019-03-12  Pedro Alves  <palves@redhat.com>
6595
6596         * cp-name-parser.y (main): Remove unused 'len' variable.
6597
6598 2019-03-12  Tom Tromey  <tromey@adacore.com>
6599
6600         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6601         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6602
6603 2019-03-12  Tom Tromey  <tromey@adacore.com>
6604
6605         * linux-nat.c (iterate_over_lwps): Update.
6606         (stop_callback): Remove parameter.
6607         (stop_wait_callback, detach_callback, resume_set_callback)
6608         (select_singlestep_lwp_callback, set_ignore_sigint)
6609         (status_callback, resumed_callback, resume_clear_callback)
6610         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6611         data parameter.
6612         (linux_nat_target::detach, linux_nat_target::resume)
6613         (linux_stop_and_wait_all_lwps, select_event_lwp)
6614         (linux_nat_filter_event, linux_nat_wait_1)
6615         (linux_nat_target::kill, linux_nat_target::stop)
6616         (linux_nat_target::stop): Update.
6617         (linux_nat_resume_callback): Change type.
6618         (resume_stopped_resumed_lwps, count_events_callback)
6619         (select_event_lwp_callback): Likewise.
6620         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6621         * arm-linux-nat.c (struct update_registers_data): Remove.
6622         (update_registers_callback): Change type.
6623         (arm_linux_insert_hw_breakpoint1): Update.
6624         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6625         parameter.
6626         (x86_linux_dr_set_addr): Update.
6627         (x86_linux_dr_set_control): Update.
6628         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6629         (iterate_over_lwps): Use gdb::function_view.
6630         * nat/aarch64-linux-hw-point.c (struct
6631         aarch64_dr_update_callback_param): Remove.
6632         (debug_reg_change_callback): Change type.
6633         (aarch64_notify_debug_reg_change): Update.
6634         * s390-linux-nat.c (s390_refresh_per_info): Update.
6635
6636 2019-03-11  Tom Tromey  <tromey@adacore.com>
6637
6638         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6639         redundant assignment to "this_cu".
6640
6641 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6642
6643         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6644
6645 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6646
6647         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6648         from...
6649         (rank_one_type): ... this.
6650
6651 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6652
6653         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6654         from...
6655         (rank_one_type): ... this.
6656
6657 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6658
6659         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6660         from...
6661         (rank_one_type): ... this.
6662
6663 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6664
6665         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6666         from...
6667         (rank_one_type): ... this.
6668
6669 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6670
6671         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6672         from...
6673         (rank_one_type): ... this.
6674
6675 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6676
6677         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6678         from...
6679         (rank_one_type): ... this.
6680
6681 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6682
6683         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6684         from...
6685         (rank_one_type): ... this.
6686
6687 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6688
6689         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6690         from...
6691         (rank_one_type): ... this.
6692
6693 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6694
6695         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6696         from...
6697         (rank_one_type): ... this.
6698
6699 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6700
6701         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6702         from...
6703         (rank_one_type): ... this.
6704
6705 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6706
6707         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6708         from...
6709         (rank_one_type): ... this.
6710
6711 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6712
6713         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6714         from...
6715         (rank_one_type): ... this.
6716
6717 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6718
6719         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6720         inferior-events' shows the example events.
6721
6722 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6723
6724         Support styling on native MS-Windows console
6725
6726         PR/24315
6727         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6728         on MS-Windows if $TERM is not defined.
6729
6730         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6731
6732         * posix-hdep.c (gdb_console_fputs):
6733         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6734         functions.
6735         * ui-file.h (gdb_console_fputs): Add prototype.
6736
6737         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6738         back to fputs only if the former returns zero.
6739
6740 2019-03-07  Tom Tromey  <tom@tromey.com>
6741
6742         * symmisc.c (print_symbol_bcache_statistics): Update.
6743         (print_objfile_statistics): Update.
6744         * symfile.c (allocate_symtab): Update.
6745         * stabsread.c: Don't include bcache.h.
6746         * psymtab.h (struct psymbol_bcache): Don't declare.
6747         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6748         (psymbol_bcache_init, psymbol_bcache_free)
6749         (psymbol_bcache_get_bcache): Don't declare.
6750         * psymtab.c (struct psymbol_bcache): Remove.
6751         (psymtab_storage::psymtab_storage): Update.
6752         (psymtab_storage::~psymtab_storage): Update.
6753         (psymbol_bcache_init, psymbol_bcache_free)
6754         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6755         (add_psymbol_to_bcache): Update.
6756         (allocate_psymtab): Update.
6757         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6758         macro_cache>: No longer pointers.
6759         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6760         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6761         * macrotab.c (macro_bcache): Update.
6762         * macroexp.c: Don't include bcache.h.
6763         * gdbtypes.c (check_types_worklist): Update.
6764         (types_deeply_equal): Remove TRY/CATCH.  Update.
6765         * elfread.c (elf_symtab_read): Update.
6766         * dwarf2read.c: Don't include bcache.h.
6767         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6768         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6769         (print_bcache_statistics, bcache_memory_used): Don't declare.
6770         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6771         methods.  Rename all data members.
6772         * bcache.c (struct bcache): Move to bcache.h.
6773         (bcache::expand_hash_table): Rename from expand_hash_table.
6774         (bcache): Remove.
6775         (bcache::insert): Rename from bcache_full.
6776         (bcache::compare): Rename from bcache_compare.
6777         (bcache_xmalloc): Remove.
6778         (bcache::~bcache): Rename from bcache_xfree.
6779         (bcache::print_statistics): Rename from print_bcache_statistics.
6780         (bcache::memory_used): Rename from bcache_memory_used.
6781
6782 2019-03-07  Pedro Alves  <palves@redhat.com>
6783
6784         * infrun.c (normal_stop): Also check for
6785         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6786
6787 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6788
6789         * f-lang.c (value_from_host_double): Moved to...
6790         * value.c (value_from_host_double): ...here.
6791         * value.h (value_from_host_double): Declare.
6792         * guile/scm-math.c (vlscm_convert_typed_number): Use
6793         value_from_host_double.
6794         (vlscm_convert_number): Likewise.
6795         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6796         * python/py-value.c (convert_value_from_python): Likewise.
6797
6798 2019-03-06  Tom Tromey  <tom@tromey.com>
6799
6800         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6801
6802 2019-03-06  Tom Tromey  <tom@tromey.com>
6803
6804         * utils.h (free_current_contents): Don't declare.
6805         * utils.c (free_current_contents): Remove.
6806
6807 2019-03-06  Tom Tromey  <tom@tromey.com>
6808
6809         * top.c (quit_force): Update.
6810         * main.c (captured_command_loop): Update.
6811         * common/new-op.c (operator new): Update.
6812         * common/common-exceptions.c (struct catcher)
6813         <save_cleanup_chain>: Remove member.
6814         (exceptions_state_mc_init): Update.
6815         (exception_try_scope_entry): Return nullptr.
6816         (exception_try_scope_exit, exception_rethrow)
6817         (throw_exception_sjlj, throw_exception_cxx): Update.
6818         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6819         (all_cleanups, do_cleanups, discard_cleanups)
6820         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6821         (restore_cleanups, restore_final_cleanups): Don't declare.
6822         (do_final_cleanups): Remove parameter.
6823         * common/cleanups.c (cleanup_chain, make_cleanup)
6824         (make_cleanup_dtor, all_cleanups, do_cleanups)
6825         (discard_my_cleanups, discard_cleanups)
6826         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6827         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6828         (null_cleanup): Remove.
6829         (do_final_cleanups): Remove parameter.
6830
6831 2019-03-06  Tom Tromey  <tom@tromey.com>
6832
6833         * remote.c (remote_target::remote_parse_stop_reply): Use
6834         unique_xmalloc_ptr.
6835
6836 2019-03-06  Tom Tromey  <tom@tromey.com>
6837
6838         * stabsread.c (struct stabs_field_info): Rename from field_info.
6839         <list, fnlist>: Add initializers.
6840         <obstack>: New member.
6841         (read_member_functions, read_struct_fields, read_baseclasses):
6842         Allocate on obstack.  Don't use cleanups.
6843         (read_one_struct_field, read_member_functions, read_struct_fields)
6844         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6845         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6846         (read_struct_type): Update.
6847
6848 2019-03-06  Tom Tromey  <tom@tromey.com>
6849
6850         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6851         * common/filestuff.h (make_cleanup_close): Don't declare.
6852         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6853         Remove.
6854
6855 2019-03-06  Tom Tromey  <tom@tromey.com>
6856
6857         * solib-aix.c: Use make_scope_exit.
6858
6859 2019-03-06  Tom Tromey  <tom@tromey.com>
6860
6861         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6862         Use make_scope_exit.
6863
6864 2019-03-06  Tom Tromey  <tom@tromey.com>
6865
6866         * solib-svr4.c (disable_probes_interface): Remove parameter.
6867         (svr4_handle_solib_event): Use make_scope_exit.
6868
6869 2019-03-06  Tom Tromey  <tom@tromey.com>
6870
6871         * remote.c (struct stop_reply_deleter): Remove.
6872         (stop_reply_up): Update.
6873         (struct stop_reply): Derive from notif_event.  Don't typedef.
6874         <regcache>: Now a std::vector.
6875         (stop_reply_xfree): Remove.
6876         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6877         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6878         (remote_target::discard_pending_stop_replies): Use delete.
6879         (remote_target::remote_parse_stop_reply): Update.
6880         (remote_target::process_stop_reply): Update.
6881         * remote-notif.h (struct notif_event): Add virtual destructor.
6882         Remove "dtr" member.
6883         (struct notif_client) <alloc_event>: Return a unique_ptr.
6884         (notif_event_xfree): Don't declare.
6885         (notif_event_up): New typedef.
6886         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6887         (notif_event_xfree, do_notif_event_xfree): Remove.
6888         (remote_notif_state_xfree): Update.
6889
6890 2019-03-06  Tom Tromey  <tom@tromey.com>
6891
6892         * infrun.c (displaced_step_clear_cleanup): Now a
6893         forward_scope_exit type.
6894         (displaced_step_prepare_throw): Update.
6895         (displaced_step_fixup): Update.
6896
6897 2019-03-06  Tom Tromey  <tom@tromey.com>
6898
6899         * inferior.h (class inferior): Update comment.
6900         * gdbthread.h (class thread_info): Update comment.
6901
6902 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6903             Tom Tromey  <tom@tromey.com>
6904
6905         * stabsread.h (struct stab_section_list): Remove.
6906         (coffstab_build_psymtabs): Update.
6907         * dbxread.c (symbuf_sections): Now a std::vector.
6908         (sect_idx): New global.
6909         (fill_symbuf): Update.
6910         (coffstab_build_psymtabs): Change type of stabsects parameter.
6911         Update.
6912         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6913         std::vector.
6914         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6915         (coff_locate_sections): Update.
6916         (coff_symfile_read): Remove cleanups.  Update.
6917         (init_stringtab): Add storage parameter.
6918         (free_stringtab, free_stringtab_cleanup): Remove.
6919         (init_lineno): Add storage parameter.
6920         (free_linetab, free_linetab_cleanup): Remove.
6921
6922 2019-03-06  Pedro Alves  <palves@redhat.com>
6923
6924         * linux-fork.c (fork_info::clobber_regs): Delete.
6925         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6926         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6927         comment.  Adjust.
6928         (scoped_switch_fork_info::scoped_switch_fork_info)
6929         (checkpoint_command, linux_fork_context): Adjust
6930         fork_save_infrun_state calls.
6931
6932 2019-03-06  Pedro Alves  <palves@redhat.com>
6933
6934         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6935         (inf_has_multiple_threads): Return 'bool' and rewrite using
6936         inferior_info::threads().
6937
6938 2019-03-06  Pedro Alves  <palves@redhat.com>
6939
6940         * linux-fork.c: Include <list>.
6941         (fork_list): Now a std::list instance.
6942         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6943         (forks_exist_p, find_last_fork): Adjust.
6944         (new_fork): Delete.
6945         (one_fork_p): New.
6946         (add_fork): Adjust.
6947         (free_fork): Delete, folded into fork_info::~fork_info().
6948         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6949         Adjust.
6950         (init_fork_list): Delete.
6951         (linux_fork_killall, linux_fork_mourn_inferior)
6952         (linux_fork_detach, info_checkpoints_command): Adjust.
6953         (_initialize_linux_fork): No longer call init_fork_list.
6954
6955 2019-03-06  Pedro Alves  <palves@redhat.com>
6956
6957         * linux-fork.c (new_fork): New, split out of ...
6958         (add_fork): ... this.  Return void.  Move "first fork" special
6959         case from here, to ...
6960         (checkpoint_command): ... here.
6961         * linux-linux.h (add_fork): Return void.
6962
6963 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6964
6965         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6966
6967 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6968             Chris January  <chris.january@arm.com>
6969             David Lecomber  <david.lecomber@arm.com>
6970
6971         * f-exp.y: New token, UNOP_INTRINSIC.
6972         (exp): New pattern using UNOP_INTRINSIC token.
6973         (f77_keywords): Add 'abs' keyword.
6974         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6975         (value_from_host_double): New function.
6976         (evaluate_subexp_f): Support UNOP_ABS.
6977
6978 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6979
6980         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6981         types.
6982
6983 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6984
6985         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6986         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6987         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6988
6989 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6990
6991         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6992
6993 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6994             Chris January  <chris.january@arm.com>
6995
6996         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6997         * f-exp.y: Define 'KIND' token.
6998         (exp): New pattern for KIND expressions.
6999         (ptype): Handle types with a kind extension.
7000         (direct_abs_decl): Extend to spot kind extensions.
7001         (f77_keywords): Add 'kind' to the list.
7002         (push_kind_type): New function.
7003         (convert_to_kind_type): New function.
7004         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7005         * parse.c (operator_length_standard): Likewise.
7006         * parser-defs.h (enum type_pieces): Add tp_kind.
7007         * std-operator.def: Add UNOP_KIND.
7008
7009 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7010
7011         * f-exp.y (f_parse): Set yydebug.
7012
7013 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7014
7015         * f-lang.c (evaluate_subexp_f): New function.
7016         (exp_descriptor_f): New global.
7017         (f_language_defn): Use exp_descriptor_f instead of
7018         exp_descriptor_standard.
7019
7020 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7021
7022         * f-exp.y (struct token): Add comments.
7023         (dot_ops): Remove uppercase versions and the end marker.
7024         (f77_keywords): Likewise.
7025         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7026         entries in the dot_ops array are case insensitive, and use
7027         strncasecmp to compare strings.  Also some whitespace cleanup in
7028         this area.  Similar for the f77_keywords array, except entries in
7029         this list might be case sensitive.
7030
7031 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7032
7033         * f-exp.y (struct f77_boolean_val): Add comments.
7034         (boolean_values): Remove uppercase versions, and end marker.
7035         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7036         and use strncasecmp to achieve case insensitivity.  Additionally,
7037         perform whitespace cleanup around this code.
7038
7039 2019-03-06  Tom Tromey  <tromey@adacore.com>
7040
7041         * remote-sim.c (gdbsim_target_open): Use result of
7042         gdb_argv::release.
7043
7044 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7045         Dirk Schubert  <dirk.schubert@arm.com>
7046         Chris January  <chris.january@arm.com>
7047
7048         * eval.c (evaluate_subexp_standard): Call Fortran argument
7049         wrapping logic.
7050         * f-lang.c (struct value): A value which can be passed into a
7051         Fortran function call.
7052         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7053         where appropriate.
7054         (struct type): Value ready for a Fortran function call.
7055         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7056         is needed.
7057         * f-lang.h (fortran_argument_convert): Declaration.
7058         (fortran_preserve_arg_pointer): Declaration.
7059         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7060
7061 2019-03-05  Tom Tromey  <tromey@adacore.com>
7062
7063         * python/py-prettyprint.c (print_string_repr): Remove #if.
7064         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7065
7066 2019-03-05  Tom Tromey  <tromey@adacore.com>
7067
7068         * target.c (the_dummy_target): Move later.  Change type to
7069         "dummy_target".
7070         (initialize_targets): Don't initialize the_dummy_target.
7071
7072 2019-03-05  Tom Tromey  <tromey@adacore.com>
7073
7074         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7075         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7076
7077 2019-03-05  Tom Tromey  <tromey@adacore.com>
7078
7079         * windows-nat.c (windows_nat_target::attach)
7080         (windows_nat_target::detach): Don't call gdb_flush.
7081         * valprint.c (generic_val_print, val_print, val_print_string):
7082         Don't call gdb_flush.
7083         * utils.c (defaulted_query): Don't call gdb_flush.
7084         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7085         * target.c (target_announce_detach): Don't call gdb_flush.
7086         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7087         * remote.c (extended_remote_target::attach): Don't call
7088         gdb_flush.
7089         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7090         * printcmd.c (do_examine): Don't call gdb_flush.
7091         (info_display_command): Don't call gdb_flush.
7092         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7093         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7094         * memattr.c (info_mem_command): Don't call gdb_flush.
7095         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7096         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7097         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7098         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7099         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7100         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7101         (gnu_nat_target::detach): Don't call gdb_flush.
7102         * f-valprint.c (f_val_print): Don't call gdb_flush.
7103         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7104         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7105         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7106         gdb_flush.
7107         * c-valprint.c (c_val_print): Don't call gdb_flush.
7108         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7109
7110 2019-03-05  Tom Tromey  <tromey@adacore.com>
7111
7112         * varobj.c (update_dynamic_varobj_children): Update.
7113         (install_default_visualizer): Use reset, not release.
7114         * value.c (set_internalvar): Update.
7115         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7116         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7117         ATTRIBUTE_UNUSED_RESULT.
7118
7119 2019-03-05  Tom Tromey  <tromey@adacore.com>
7120
7121         * remote.c (class scoped_remote_fd) <release>: Add
7122         ATTRIBUTE_UNUSED_RESULT.
7123
7124 2019-03-05  Tom Tromey  <tromey@adacore.com>
7125
7126         * macroexp.c (struct macro_buffer) <release>: Add
7127         ATTRIBUTE_UNUSED_RESULT.
7128
7129 2019-03-05  Tom Tromey  <tromey@adacore.com>
7130
7131         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7132         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7133         ATTRIBUTE_UNUSED_RESULT.
7134
7135 2019-03-05  Tom Tromey  <tromey@adacore.com>
7136
7137         * common/scoped_fd.h (class scoped_fd) <release>: Add
7138         ATTRIBUTE_UNUSED_RESULT.
7139
7140 2019-03-05  Tom Tromey  <tromey@adacore.com>
7141
7142         * parser-defs.h (struct parser_state) <release>: Add
7143         ATTRIBUTE_UNUSED_RESULT.
7144
7145 2019-03-05  Tom Tromey  <tromey@adacore.com>
7146
7147         * utils.h (class gdb_argv) <release>: Add
7148         ATTRIBUTE_UNUSED_RESULT.
7149         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7150
7151 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7152
7153         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7154         for-loop range, to avoid compiler warnings.
7155
7156         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7157         avoid compiler warnings about unused variables.
7158
7159         * NEWS: Mention end of support for native debugging on MS-Windows
7160         before XP.
7161
7162         PR gdb/24292
7163         * common/netstuff.c:
7164         * gdbserver/gdbreplay.c
7165         * gdbserver/remote-utils.c:
7166         * ser-tcp.c:
7167         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7168         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7169         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7170         'getaddrinfo' and 'freeaddrinfo' were not available before
7171         Windows XP, and mingw.org's MinGW headers by default define
7172         _WIN32_WINNT to 0x500.
7173
7174 2019-03-01  Gary Benson <gbenson@redhat.com>
7175
7176         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7177
7178 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7179             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7180
7181         PR gdb/8527
7182         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7183         set_sigint_trap, clear_sigint_trap.
7184
7185 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7186
7187         * target.c (target_detach): Clear the regcache and the
7188         frame cache.
7189
7190 2019-02-27  Pedro Alves  <palves@redhat.com>
7191
7192         * utils.c (set_screen_size): When we cap the height/width sizes,
7193         tweak the corresponding command variable to show "unlimited":
7194
7195 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7196             Pedro Alves  <palves@redhat.com>
7197
7198         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7199         before calling rl_set_screen_size.
7200
7201 2019-02-27  Tom Tromey  <tromey@adacore.com>
7202
7203         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7204         define.
7205         * python/py-value.c: Remove Python 2.4 workaround.
7206         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7207         workaround.
7208         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7209         Python 2.4 workaround.
7210         * python/python-internal.h: Remove Python 2.4 comment.
7211         (Py_ssize_t): Don't define.
7212         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7213         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7214         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7215         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7216         * python/python.c (do_start_initialization): Remove Python 2.4
7217         workaround.
7218         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7219         (print_children): Remove Python 2.4 workaround.
7220         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7221         workaround.
7222         (CHARBUFFERPROC_NAME): Remove.
7223         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7224         Python 2.4 workaround.
7225
7226 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7227
7228         * NEWS: Note minimum Python version.
7229
7230 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7231
7232         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7233         code from these functions.  Remove corresponding ifdefs.  Use
7234         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7235         Remove gotos and target of gotos.
7236         (infpy_search_memory): Likewise.
7237
7238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7239
7240         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7241         (hppa_gdbarch_init): Don't register deleted functions with
7242         gdbarch.
7243
7244 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7245
7246         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7247         (h8300_unwind_sp): Delete.
7248         (h8300_dummy_id): Delete.
7249         (h8300_gdbarch_init): Don't register deleted functions with
7250         gdbarch.
7251
7252 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7253
7254         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7255         (ft32_unwind_pc): Delete.
7256         (ft32_unwind_sp): Delete.
7257         (ft32_gdbarch_init): Don't register deleted functions with
7258         gdbarch.
7259
7260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7261
7262         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7263         (frv_unwind_pc): Delete.
7264         (frv_unwind_sp): Delete.
7265         (frv_gdbarch_init): Don't register deleted functions with
7266         gdbarch.
7267
7268 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7269
7270         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7271         (riscv_unwind_pc): Delete.
7272         (riscv_unwind_sp): Delete.
7273         (riscv_gdbarch_init): Don't register deleted functions with
7274         gdbarch.
7275
7276 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7277
7278         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7279         (csky_unwind_pc): Delete.
7280         (csky_unwind_sp): Delete.
7281         (csky_gdbarch_init): Don't register deleted functions with
7282         gdbarch.
7283
7284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7285
7286         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7287         (cris_unwind_pc): Delete.
7288         (cris_unwind_sp): Delete.
7289         (cris_gdbarch_init): Don't register deleted functions with
7290         gdbarch.
7291
7292 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7293
7294         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7295         (bfin_unwind_pc): Delete.
7296         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7297
7298 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7299
7300         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7301         (arm_unwind_pc): Delete.
7302         (arm_unwind_sp): Delete.
7303         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7304
7305 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7308         (arc_unwind_pc): Delete.
7309         (arc_unwind_sp): Delete.
7310         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7311
7312 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7313
7314         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7315         (alpha_unwind_pc): Delete.
7316         (alpha_gdbarch_init): Don't register deleted functions with
7317         gdbarch.
7318
7319 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7320
7321         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7322         (aarch64_unwind_pc): Delete.
7323         (aarch64_unwind_sp): Delete.
7324         (aarch64_gdbarch_init): Don't register deleted functions with
7325         gdbarch.
7326
7327 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7328
7329         * gdbtypes.c (type_align): Don't consider static members when
7330         computing structure alignment.
7331
7332 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7333
7334         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7335         return 0 for other types.
7336         * arch-utils.c (default_type_align): Always return 0.
7337         * gdbarch.h: Regenerate.
7338         * gdbarch.sh (type_align): Extend comment.
7339         * gdbtypes.c (type_align): Add additional comments, always call
7340         gdbarch_type_align before applying the default rules.
7341         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7342         generic code will then apply a suitable default.
7343         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7344         types, return 0 for other types.
7345
7346 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7347
7348         * NEWS: Create a new section for the next release branch.
7349         Rename the section of the current branch, now that it has
7350         been cut.
7351
7352 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7353
7354         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7355         * version.in: Bump version to 8.3.50.DATE-git.
7356
7357 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7358
7359         * aix-thread.c (ptid_cmp): Remove unused variable.
7360         (get_signaled_thread): Likewise.
7361         (store_regs_user_thread): Likewise.
7362         (store_regs_kernel_thread): Likewise.
7363         (fetch_regs_kernel_thread): Remove shadowed variable.
7364
7365 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7366
7367         * features/riscv/32bit-cpu.xml: Add register numbers.
7368         * features/riscv/32bit-fpu.c: Regenerate.
7369         * features/riscv/32bit-fpu.xml: Add register numbers.
7370         * features/riscv/64bit-cpu.xml: Add register numbers.
7371         * features/riscv/64bit-fpu.c: Regenerate.
7372         * features/riscv/64bit-fpu.xml: Add register numbers.
7373
7374 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7375
7376         * NEWS: Mention two argument form of gdb.Value constructor.
7377         * python/py-value.c (convert_buffer_and_type_to_value): New
7378         function.
7379         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7380         Add support for handling an optional second argument.  Call
7381         convert_buffer_and_type_to_value as appropriate.
7382         * python/python-internal.h (Py_buffer_deleter): New struct.
7383         (Py_buffer_up): New typedef.
7384
7385 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7386
7387         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7388         instead of releasing ownership.
7389
7390 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7391
7392         * dwarf2read.c (open_and_init_dwp_file): Call
7393         elf_numsections instead of bfd_count_sections to initialize
7394         dwp_file->num_sections.
7395
7396 2019-02-25  Tom Tromey  <tromey@adacore.com>
7397
7398         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7399
7400 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7401
7402         * gcore.in: Add '--readnever' option when invoking GDB.
7403
7404 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7405
7406         * MAINTAINERS: Update my email address.
7407
7408 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7409
7410         * build-id.c (build_id_to_debug_bfd_1): New function.
7411         (build_id_to_debug_bfd): Look for separate debug file in
7412         sysroot.
7413
7414 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7415
7416         * gdbarch.sh: Update the copyright year range that is placed into
7417         generated files.
7418
7419 2019-02-22  Keith Seitz  <keiths@redhat.com>
7420
7421         PR symtab/23853
7422         * linespec.c (create_sals_line_offset): Search for the default
7423         symtab's filename instead of its fullname.
7424
7425 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7426
7427         * NEWS: Update style defaults.
7428
7429 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7430
7431         * main.c (captured_main_1): Disable styling in batch mode.
7432
7433 2019-02-20  Tom Tromey  <tom@tromey.com>
7434
7435         * symtab.c (symtab_symbol_info): Fix typos.
7436
7437 2019-02-20  Tom Tromey  <tromey@adacore.com>
7438
7439         * findcmd.c (_initialize_mem_search): Use upper case for
7440         metasyntactic variables.
7441
7442 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7443
7444         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7445         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7446
7447 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7448
7449         * top.h (source_file_name): Change to std::string.
7450         * top.c (source_file_name): Likewise.
7451         (command_line_input): Adjust.
7452         * cli/cli-script.c (script_from_file): Adjust.
7453
7454 2019-02-19  Tom Tromey  <tromey@adacore.com>
7455
7456         * ravenscar-thread.c
7457         (ravenscar_thread_target::update_thread_list): Don't call
7458         ada_build_task_list.
7459         * ada-lang.h (ada_build_task_list): Don't declare.
7460         * ada-tasks.c (struct ada_tasks_inferior_data)
7461         <task_list_valid_p>: Now bool.
7462         (read_known_tasks, ada_task_list_changed)
7463         (ada_tasks_invalidate_inferior_data): Update.
7464         (read_known_tasks_array): Return bool.
7465         (read_known_tasks_list): Likewise.
7466         (read_known_tasks): Return void.
7467         (ada_build_task_list): Now static.
7468
7469 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7470
7471         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7472         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7473
7474 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7475
7476         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7477         variant for ada_tasks_pspace_data_handle and
7478         ada_tasks_inferior_data_handle.
7479         (ada_tasks_pspace_data_cleanup): New function.
7480         (ada_tasks_inferior_data_cleanup): New function.
7481
7482 2019-02-17  Tom Tromey  <tom@tromey.com>
7483
7484         * macrotab.h (macro_source_fullname): Return a std::string.
7485         * macrotab.c (macro_include, check_for_redefinition)
7486         (macro_undef, macro_lookup_definition, foreach_macro)
7487         (foreach_macro_in_scope): Update.
7488         (macro_source_fullname): Return a std::string.
7489         * macrocmd.c (show_pp_source_pos): Update.
7490
7491 2019-02-17  Tom Tromey  <tom@tromey.com>
7492
7493         * macrocmd.c (show_pp_source_pos): Style the file names.
7494
7495 2019-02-17  Tom Tromey  <tom@tromey.com>
7496
7497         PR tui/24197:
7498         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7499
7500 2019-02-17  Tom Tromey  <tom@tromey.com>
7501
7502         * ada-lang.c (user_select_syms): Use filtered printing.
7503         * utils.c (wrap_style): New global.
7504         (desired_style): Remove.
7505         (emit_style_escape): Add stream parameter.
7506         (set_output_style, reset_terminal_style, prompt_for_continue):
7507         Update.
7508         (flush_wrap_buffer): Only flush gdb_stdout.
7509         (wrap_here): Set wrap_style.
7510         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7511         treat escape sequences as a character.  Change when wrap buffer is
7512         flushed.
7513         (fputs_styled): Do not set the output style when the default is
7514         requested.
7515         * ui-style.h (struct ui_file_style) <is_default>: New method.
7516         * source.c (print_source_lines_base): Emit escape sequences in one
7517         piece.
7518
7519 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7520
7521         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7522         integers and enumeration types.
7523
7524 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7525
7526         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7527         instead of lookup_symbol_in_language
7528         (do_exact_match): New function.
7529         (ada_get_symbol_name_matcher): Return do_exact_match when
7530         doing a verbatim match.
7531
7532 2019-02-15  Tom Tromey  <tromey@adacore.com>
7533
7534         * ravenscar-thread.c (ravenscar_thread_target::resume)
7535         (ravenscar_thread_target::wait): Special case wildcard requests.
7536
7537 2019-02-15  Tom Tromey  <tromey@adacore.com>
7538
7539         * ravenscar-thread.c (base_ptid): Remove.
7540         (struct ravenscar_thread_target) <close>: New method.
7541         <m_base_ptid>: New member.
7542         <update_inferior_ptid, active_task, task_is_currently_active,
7543         runtime_initialized>: Declare methods.
7544         <ravenscar_thread_target>: Add constructor.
7545         (ravenscar_thread_target::task_is_currently_active)
7546         (ravenscar_thread_target::update_inferior_ptid)
7547         (ravenscar_runtime_initialized): Rename.  Now methods.
7548         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7549         (ravenscar_thread_target::update_thread_list): Update.
7550         (ravenscar_thread_target::active_task): Now method.
7551         (ravenscar_thread_target::store_registers)
7552         (ravenscar_thread_target::prepare_to_store)
7553         (ravenscar_thread_target::prepare_to_store)
7554         (ravenscar_thread_target::mourn_inferior): Update.
7555         (ravenscar_inferior_created): Use "new" to create target.
7556         (ravenscar_thread_target::get_ada_task_ptid): Update.
7557         (_initialize_ravenscar): Don't initialize base_ptid.
7558         (ravenscar_ops): Remove global.
7559
7560 2019-02-15  Tom Tromey  <tromey@adacore.com>
7561
7562         * target.h (push_target): Declare new overload.
7563         * target.c (push_target): New overload, taking an rvalue reference.
7564         * remote.c (remote_target::open_1): Use push_target overload.
7565         * corelow.c (core_target_open): Use push_target overload.
7566
7567 2019-02-15  Tom Tromey  <tromey@adacore.com>
7568
7569         * ravenscar-thread.c (is_ravenscar_task)
7570         (ravenscar_task_is_currently_active): Return bool.
7571         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7572         (_initialize_ravenscar): Remove "(void)".
7573         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7574         Return bool.
7575
7576 2019-02-15  Tom Tromey  <tromey@adacore.com>
7577
7578         * ravenscar-thread.c (ravenscar_runtime_initializer)
7579         (has_ravenscar_runtime, get_running_thread_id)
7580         (ravenscar_thread_target::resume): Fix indentation.
7581
7582 2019-02-15  Tom Tromey  <tromey@adacore.com>
7583
7584         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7585         from ravenscar_arch_ops.
7586         (sparc_ravenscar_ops::fetch_registers)
7587         (sparc_ravenscar_ops::store_registers): Now methods.
7588         (sparc_ravenscar_prepare_to_store): Remove.
7589         (sparc_ravenscar_ops): Redefine.
7590         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7591         methods and destructor.  Remove members.
7592         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7593         (ravenscar_thread_target::store_registers)
7594         (ravenscar_thread_target::prepare_to_store): Update.
7595         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7596         Remove.
7597         (struct ppc_ravenscar_powerpc_ops): Derive from
7598         ravenscar_arch_ops.
7599         (ppc_ravenscar_powerpc_ops::fetch_registers)
7600         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7601         (ppc_ravenscar_powerpc_ops): Redefine.
7602         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7603         (ppc_ravenscar_e500_ops::fetch_registers)
7604         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7605         (ppc_ravenscar_e500_ops): Redefine.
7606         * aarch64-ravenscar-thread.c
7607         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7608         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7609         (aarch64_ravenscar_fetch_registers)
7610         (aarch64_ravenscar_store_registers): Now methods.
7611         (aarch64_ravenscar_ops): Redefine.
7612
7613 2019-02-15  Tom Tromey  <tromey@adacore.com>
7614
7615         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7616         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7617         (ravenscar_thread_target::stopped_by_watchpoint)
7618         (ravenscar_thread_target::stopped_data_address)
7619         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7620
7621 2019-02-15  Tom Tromey  <tromey@adacore.com>
7622
7623         * ravenscar-thread.c: Fix some typos.
7624
7625 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7626             Tom Tromey  <tromey@adacore.com>
7627
7628         * ada-lang.c (ada_exception_sal): Change addr_string to a
7629         std::string.
7630         (create_ada_exception_catchpoint): Update.
7631
7632 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7633             Tom Tromey  <tromey@adacore.com>
7634
7635         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7636         (bp_location_ops): Remove.
7637         (base_breakpoint_allocate_location): Update.
7638         (free_bp_location): Update.
7639         * ada-lang.c (class ada_catchpoint_location)
7640         <ada_catchpoint_location>: Remove ops parameter.
7641         (ada_catchpoint_location_dtor): Remove.
7642         (ada_catchpoint_location_ops): Remove.
7643         (allocate_location_exception): Update.
7644         * breakpoint.h (struct bp_location_ops): Remove.
7645         (class bp_location) <bp_location>: Remove bp_location_ops
7646         parameter.
7647         <~bp_location>: Add destructor.
7648         <ops>: Remove.
7649
7650 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7651             Pedro Alves  <palves@redhat.com>
7652
7653         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7654         'PATH_MAX'.
7655
7656 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7657             Samuel Thibault  <samuel.thibault@gnu.org>
7658             Thomas Schwinge  <thomas@codesourcery.com>
7659
7660         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7661         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7662
7663 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7664
7665         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7666         (check_empty): Use "const char *".
7667
7668         * gnu-nat.c (gnu_nat_target::detach): Instead of
7669         'detach_inferior (pid)' call
7670         'detach_inferior (find_inferior_pid (pid))'.
7671
7672         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7673         'nat/fork-inferior.o'.
7674         * gnu-nat.c: #include "nat/fork-inferior.h".
7675
7676         * gnu-nat.c (gnu_nat_target::detach): Instead of
7677         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7678         * gnu-nat.h: #include "inf-child.h".
7679         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7680         'i386_gnu_nat_target::fetch_registers'.
7681         (gnu_store_registers): Rename/move to
7682         'i386_gnu_nat_target::store_registers'.
7683
7684         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7685         * gnu-nat.h (mach_thread_info): New function.
7686         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7687
7688         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7689
7690 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7691
7692         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7693
7694 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7695
7696         * windows-nat.c (windows_add_thread): Add new parameter
7697         "main_thread_p" with default value set to false.  Update
7698         function documentation as well as all callers.
7699         (windows_delete_thread): Likewise.
7700         (fake_create_process): Update call to windows_add_thread.
7701         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7702         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7703         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7704         call to windows_delete_thread.
7705
7706 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7707
7708         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7709
7710 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7711
7712         * symfile.c (find_separate_debug_file): Use canonical path of
7713         sysroot with child_path instead of gdb_sysroot if it is valid.
7714
7715 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7716
7717         * symfile.c (find_separate_debug_file): Use child_path to
7718         determine if an object file is under a sysroot.
7719
7720 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7721
7722         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7723         unittests/child-path-selftests.c.
7724         * common/pathstuff.c (child_path): New function.
7725         * common/pathstuff.h (child_path): New prototype.
7726         * unittests/child-path-selftests.c: New file.
7727
7728 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7729
7730         * symfile.c (find_separate_debug_file): Look for separate debug
7731         files in debug directories under the sysroot.
7732
7733 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7734
7735         * symtab.h (struct minimal_symbol data_p): New const method.
7736         (struct minimal_symbol text_p): Likewise.
7737         * symtab.c (output_source_filename): Use file name style
7738         to print file name.
7739         (print_symbol_info): Likewise.
7740         (print_msymbol_info): Use address style to print addresses.
7741         Use function name style to print executable text symbols.
7742         (expand_symtab_containing_pc): Use data_p.
7743         (find_pc_sect_compunit_symtab): Likewise.
7744
7745 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7746
7747         * breakpoint.c (describe_other_breakpoints): Use address style
7748         to print addresses.
7749         (say_where): Likewise.
7750
7751 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7752
7753         * ada-typeprint.c (print_func_type): Print function name
7754         style to print function name.
7755         * c-typeprint.c (c_print_type_1): Likewise.
7756
7757 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7758
7759         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7760         for execve.
7761
7762 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7763
7764         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7765         type_stack.
7766
7767 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7768
7769         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7770         TYPE_CODE_REF types.
7771
7772 2019-02-08  Jim Wilson  <jimw@sifive.com>
7773
7774         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7775         (riscv_linux_fregset): New.
7776         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7777
7778 2019-02-07  Tom Tromey  <tom@tromey.com>
7779
7780         * thread.c (thread_cancel_execution_command): Update.
7781         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7782         methods.
7783         (struct thread_fsm_ops): Remove.
7784         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7785         (thread_fsm_should_stop, thread_fsm_return_value)
7786         (thread_fsm_set_finished, thread_fsm_finished_p)
7787         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7788         Don't declare.
7789         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7790         * infrun.c (clear_proceed_status_thread)
7791         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7792         (print_stop_event): Update.
7793         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7794         Add constructor.
7795         (step_command_fsm_ops): Remove.
7796         (new_step_command_fsm): Remove.
7797         (step_1): Update.
7798         (step_command_fsm::should_stop): Rename from
7799         step_command_fsm_should_stop.
7800         (step_command_fsm::clean_up): Rename from
7801         step_command_fsm_clean_up.
7802         (step_command_fsm::do_async_reply_reason): Rename from
7803         step_command_fsm_async_reply_reason.
7804         (struct until_next_fsm): Inherit from thread_fsm.  Add
7805         constructor.
7806         (until_next_fsm_ops): Remove.
7807         (new_until_next_fsm): Remove.
7808         (until_next_fsm::should_stop): Rename from
7809         until_next_fsm_should_stop.
7810         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7811         (until_next_fsm::do_async_reply_reason): Rename from
7812         until_next_fsm_async_reply_reason.
7813         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7814         constructor.  Change type of breakpoint.
7815         (finish_command_fsm_ops): Remove.
7816         (new_finish_command_fsm): Remove.
7817         (finish_command_fsm::should_stop): Rename from
7818         finish_command_fsm_should_stop.
7819         (finish_command_fsm::clean_up): Rename from
7820         finish_command_fsm_clean_up.
7821         (finish_command_fsm::return_value): Rename from
7822         finish_command_fsm_return_value.
7823         (finish_command_fsm::do_async_reply_reason): Rename from
7824         finish_command_fsm_async_reply_reason.
7825         (finish_command): Update.
7826         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7827         Add constructor.
7828         (call_thread_fsm_ops): Remove.
7829         (call_thread_fsm::call_thread_fsm): Rename from
7830         new_call_thread_fsm.
7831         (call_thread_fsm::should_stop): Rename from
7832         call_thread_fsm_should_stop.
7833         (call_thread_fsm::should_notify_stop): Rename from
7834         call_thread_fsm_should_notify_stop.
7835         (run_inferior_call, call_function_by_hand_dummy): Update.
7836         * cli/cli-interp.c (should_print_stop_to_console): Update.
7837         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7838         Add constructor.  Change type of location_breakpoint,
7839         caller_breakpoint.
7840         (until_break_fsm_ops): Remove.
7841         (new_until_break_fsm): Remove.
7842         (until_break_fsm::should_stop): Rename from
7843         until_break_fsm_should_stop.
7844         (until_break_fsm::clean_up): Rename from
7845         until_break_fsm_clean_up.
7846         (until_break_fsm::do_async_reply_reason): Rename from
7847         until_break_fsm_async_reply_reason.
7848         (until_break_command): Update.
7849         * thread-fsm.c: Remove.
7850         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7851
7852 2019-02-07  Tom Tromey  <tom@tromey.com>
7853
7854         * yy-remap.h: Add include guard.
7855         * xtensa-tdep.h: Add include guard.
7856         * xcoffread.h: Rename include guard.
7857         * varobj-iter.h: Add include guard.
7858         * tui/tui.h: Rename include guard.
7859         * tui/tui-winsource.h: Rename include guard.
7860         * tui/tui-wingeneral.h: Rename include guard.
7861         * tui/tui-windata.h: Rename include guard.
7862         * tui/tui-win.h: Rename include guard.
7863         * tui/tui-stack.h: Rename include guard.
7864         * tui/tui-source.h: Rename include guard.
7865         * tui/tui-regs.h: Rename include guard.
7866         * tui/tui-out.h: Rename include guard.
7867         * tui/tui-layout.h: Rename include guard.
7868         * tui/tui-io.h: Rename include guard.
7869         * tui/tui-hooks.h: Rename include guard.
7870         * tui/tui-file.h: Rename include guard.
7871         * tui/tui-disasm.h: Rename include guard.
7872         * tui/tui-data.h: Rename include guard.
7873         * tui/tui-command.h: Rename include guard.
7874         * tic6x-tdep.h: Add include guard.
7875         * target/waitstatus.h: Rename include guard.
7876         * target/wait.h: Rename include guard.
7877         * target/target.h: Rename include guard.
7878         * target/resume.h: Rename include guard.
7879         * target-float.h: Rename include guard.
7880         * stabsread.h: Add include guard.
7881         * rs6000-tdep.h: Add include guard.
7882         * riscv-fbsd-tdep.h: Add include guard.
7883         * regformats/regdef.h: Rename include guard.
7884         * record.h: Rename include guard.
7885         * python/python.h: Rename include guard.
7886         * python/python-internal.h: Rename include guard.
7887         * python/py-stopevent.h: Rename include guard.
7888         * python/py-ref.h: Rename include guard.
7889         * python/py-record.h: Rename include guard.
7890         * python/py-record-full.h: Rename include guard.
7891         * python/py-record-btrace.h: Rename include guard.
7892         * python/py-instruction.h: Rename include guard.
7893         * python/py-events.h: Rename include guard.
7894         * python/py-event.h: Rename include guard.
7895         * procfs.h: Add include guard.
7896         * proc-utils.h: Add include guard.
7897         * p-lang.h: Add include guard.
7898         * or1k-tdep.h: Rename include guard.
7899         * observable.h: Rename include guard.
7900         * nto-tdep.h: Rename include guard.
7901         * nat/x86-linux.h: Rename include guard.
7902         * nat/x86-linux-dregs.h: Rename include guard.
7903         * nat/x86-gcc-cpuid.h: Add include guard.
7904         * nat/x86-dregs.h: Rename include guard.
7905         * nat/x86-cpuid.h: Rename include guard.
7906         * nat/ppc-linux.h: Rename include guard.
7907         * nat/mips-linux-watch.h: Rename include guard.
7908         * nat/linux-waitpid.h: Rename include guard.
7909         * nat/linux-ptrace.h: Rename include guard.
7910         * nat/linux-procfs.h: Rename include guard.
7911         * nat/linux-osdata.h: Rename include guard.
7912         * nat/linux-nat.h: Rename include guard.
7913         * nat/linux-namespaces.h: Rename include guard.
7914         * nat/linux-btrace.h: Rename include guard.
7915         * nat/glibc_thread_db.h: Rename include guard.
7916         * nat/gdb_thread_db.h: Rename include guard.
7917         * nat/gdb_ptrace.h: Rename include guard.
7918         * nat/fork-inferior.h: Rename include guard.
7919         * nat/amd64-linux-siginfo.h: Rename include guard.
7920         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7921         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7922         * nat/aarch64-linux.h: Rename include guard.
7923         * nat/aarch64-linux-hw-point.h: Rename include guard.
7924         * mn10300-tdep.h: Add include guard.
7925         * mips-linux-tdep.h: Add include guard.
7926         * mi/mi-parse.h: Rename include guard.
7927         * mi/mi-out.h: Rename include guard.
7928         * mi/mi-main.h: Rename include guard.
7929         * mi/mi-interp.h: Rename include guard.
7930         * mi/mi-getopt.h: Rename include guard.
7931         * mi/mi-console.h: Rename include guard.
7932         * mi/mi-common.h: Rename include guard.
7933         * mi/mi-cmds.h: Rename include guard.
7934         * mi/mi-cmd-break.h: Rename include guard.
7935         * m2-lang.h: Add include guard.
7936         * location.h: Rename include guard.
7937         * linux-record.h: Rename include guard.
7938         * linux-nat.h: Add include guard.
7939         * linux-fork.h: Add include guard.
7940         * i386-darwin-tdep.h: Rename include guard.
7941         * hppa-linux-offsets.h: Add include guard.
7942         * guile/guile.h: Rename include guard.
7943         * guile/guile-internal.h: Rename include guard.
7944         * gnu-nat.h: Rename include guard.
7945         * gdb-stabs.h: Rename include guard.
7946         * frv-tdep.h: Add include guard.
7947         * f-lang.h: Add include guard.
7948         * event-loop.h: Add include guard.
7949         * darwin-nat.h: Rename include guard.
7950         * cp-abi.h: Rename include guard.
7951         * config/sparc/nm-sol2.h: Rename include guard.
7952         * config/nm-nto.h: Rename include guard.
7953         * config/nm-linux.h: Add include guard.
7954         * config/i386/nm-i386gnu.h: Rename include guard.
7955         * config/djgpp/nl_types.h: Rename include guard.
7956         * config/djgpp/langinfo.h: Rename include guard.
7957         * compile/gcc-cp-plugin.h: Add include guard.
7958         * compile/gcc-c-plugin.h: Add include guard.
7959         * compile/compile.h: Rename include guard.
7960         * compile/compile-object-run.h: Rename include guard.
7961         * compile/compile-object-load.h: Rename include guard.
7962         * compile/compile-internal.h: Rename include guard.
7963         * compile/compile-cplus.h: Rename include guard.
7964         * compile/compile-c.h: Rename include guard.
7965         * common/xml-utils.h: Rename include guard.
7966         * common/x86-xstate.h: Rename include guard.
7967         * common/version.h: Rename include guard.
7968         * common/vec.h: Rename include guard.
7969         * common/tdesc.h: Rename include guard.
7970         * common/selftest.h: Rename include guard.
7971         * common/scoped_restore.h: Rename include guard.
7972         * common/scoped_mmap.h: Rename include guard.
7973         * common/scoped_fd.h: Rename include guard.
7974         * common/safe-iterator.h: Rename include guard.
7975         * common/run-time-clock.h: Rename include guard.
7976         * common/refcounted-object.h: Rename include guard.
7977         * common/queue.h: Rename include guard.
7978         * common/ptid.h: Rename include guard.
7979         * common/print-utils.h: Rename include guard.
7980         * common/preprocessor.h: Rename include guard.
7981         * common/pathstuff.h: Rename include guard.
7982         * common/observable.h: Rename include guard.
7983         * common/netstuff.h: Rename include guard.
7984         * common/job-control.h: Rename include guard.
7985         * common/host-defs.h: Rename include guard.
7986         * common/gdb_wait.h: Rename include guard.
7987         * common/gdb_vecs.h: Rename include guard.
7988         * common/gdb_unlinker.h: Rename include guard.
7989         * common/gdb_unique_ptr.h: Rename include guard.
7990         * common/gdb_tilde_expand.h: Rename include guard.
7991         * common/gdb_sys_time.h: Rename include guard.
7992         * common/gdb_string_view.h: Rename include guard.
7993         * common/gdb_splay_tree.h: Rename include guard.
7994         * common/gdb_setjmp.h: Rename include guard.
7995         * common/gdb_ref_ptr.h: Rename include guard.
7996         * common/gdb_optional.h: Rename include guard.
7997         * common/gdb_locale.h: Rename include guard.
7998         * common/gdb_assert.h: Rename include guard.
7999         * common/filtered-iterator.h: Rename include guard.
8000         * common/filestuff.h: Rename include guard.
8001         * common/fileio.h: Rename include guard.
8002         * common/environ.h: Rename include guard.
8003         * common/common-utils.h: Rename include guard.
8004         * common/common-types.h: Rename include guard.
8005         * common/common-regcache.h: Rename include guard.
8006         * common/common-inferior.h: Rename include guard.
8007         * common/common-gdbthread.h: Rename include guard.
8008         * common/common-exceptions.h: Rename include guard.
8009         * common/common-defs.h: Rename include guard.
8010         * common/common-debug.h: Rename include guard.
8011         * common/cleanups.h: Rename include guard.
8012         * common/buffer.h: Rename include guard.
8013         * common/btrace-common.h: Rename include guard.
8014         * common/break-common.h: Rename include guard.
8015         * cli/cli-utils.h: Rename include guard.
8016         * cli/cli-style.h: Rename include guard.
8017         * cli/cli-setshow.h: Rename include guard.
8018         * cli/cli-script.h: Rename include guard.
8019         * cli/cli-interp.h: Rename include guard.
8020         * cli/cli-decode.h: Rename include guard.
8021         * cli/cli-cmds.h: Rename include guard.
8022         * charset-list.h: Add include guard.
8023         * buildsym-legacy.h: Rename include guard.
8024         * bfin-tdep.h: Add include guard.
8025         * ax.h: Rename include guard.
8026         * arm-linux-tdep.h: Add include guard.
8027         * arm-fbsd-tdep.h: Add include guard.
8028         * arch/xtensa.h: Rename include guard.
8029         * arch/tic6x.h: Add include guard.
8030         * arch/i386.h: Add include guard.
8031         * arch/arm.h: Rename include guard.
8032         * arch/arm-linux.h: Rename include guard.
8033         * arch/arm-get-next-pcs.h: Rename include guard.
8034         * arch/amd64.h: Add include guard.
8035         * arch/aarch64-insn.h: Rename include guard.
8036         * arch-utils.h: Rename include guard.
8037         * annotate.h: Add include guard.
8038         * amd64-darwin-tdep.h: Rename include guard.
8039         * aarch64-linux-tdep.h: Add include guard.
8040         * aarch64-fbsd-tdep.h: Add include guard.
8041         * aarch32-linux-nat.h: Add include guard.
8042
8043 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8044
8045         * macrotab.c (macro_define_internal): New function that
8046         factorizes macro_define_object_internal and macro_define_function
8047         code.
8048         (macro_define_object_internal): Use macro_define_internal.
8049         (macro_define_function): Likewise.
8050
8051 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8052
8053         * macrocmd.c (extract_identifier): Return
8054         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8055         callers.
8056
8057 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8058
8059         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8060
8061 2019-02-05  Tom Tromey  <tom@tromey.com>
8062
8063         * target.c (target_stack::unpush): Move assertion earlier.
8064
8065 2019-01-30  Tom Tromey  <tom@tromey.com>
8066
8067         PR python/23615:
8068         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8069         (gdbpy_parse_and_eval): Likewise.
8070         * python/python-internal.h (gdbpy_allow_threads): New class.
8071
8072 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8073
8074         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8075         (aarch64_fbsd_fpregmap): Move earlier.
8076         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8077         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8078         instead of individual calls to trad_frame_set_reg_addr.
8079         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8080         earlier.
8081         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8082         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8083         instead of individual calls to trad_frame_set_reg_addr.
8084
8085 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8086
8087         * CONTRIBUTE: Replace contribution list with wiki link.
8088
8089 2019-01-25  Tom Tromey  <tom@tromey.com>
8090
8091         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8092
8093 2019-01-25  Tom Tromey  <tom@tromey.com>
8094
8095         * xtensa-linux-nat.c: Fix common/ includes.
8096         * xml-support.h: Fix common/ includes.
8097         * xml-support.c: Fix common/ includes.
8098         * x86-linux-nat.c: Fix common/ includes.
8099         * windows-nat.c: Fix common/ includes.
8100         * varobj.h: Fix common/ includes.
8101         * varobj.c: Fix common/ includes.
8102         * value.c: Fix common/ includes.
8103         * valops.c: Fix common/ includes.
8104         * utils.c: Fix common/ includes.
8105         * unittests/xml-utils-selftests.c: Fix common/ includes.
8106         * unittests/utils-selftests.c: Fix common/ includes.
8107         * unittests/unpack-selftests.c: Fix common/ includes.
8108         * unittests/tracepoint-selftests.c: Fix common/ includes.
8109         * unittests/style-selftests.c: Fix common/ includes.
8110         * unittests/string_view-selftests.c: Fix common/ includes.
8111         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8112         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8113         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8114         * unittests/rsp-low-selftests.c: Fix common/ includes.
8115         * unittests/parse-connection-spec-selftests.c: Fix common/
8116         includes.
8117         * unittests/optional-selftests.c: Fix common/ includes.
8118         * unittests/offset-type-selftests.c: Fix common/ includes.
8119         * unittests/observable-selftests.c: Fix common/ includes.
8120         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8121         * unittests/memrange-selftests.c: Fix common/ includes.
8122         * unittests/memory-map-selftests.c: Fix common/ includes.
8123         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8124         * unittests/function-view-selftests.c: Fix common/ includes.
8125         * unittests/environ-selftests.c: Fix common/ includes.
8126         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8127         * unittests/common-utils-selftests.c: Fix common/ includes.
8128         * unittests/cli-utils-selftests.c: Fix common/ includes.
8129         * unittests/array-view-selftests.c: Fix common/ includes.
8130         * ui-file.c: Fix common/ includes.
8131         * tui/tui-io.c: Fix common/ includes.
8132         * tracepoint.h: Fix common/ includes.
8133         * tracepoint.c: Fix common/ includes.
8134         * tracefile-tfile.c: Fix common/ includes.
8135         * top.h: Fix common/ includes.
8136         * top.c: Fix common/ includes.
8137         * thread.c: Fix common/ includes.
8138         * target/waitstatus.h: Fix common/ includes.
8139         * target/waitstatus.c: Fix common/ includes.
8140         * target.h: Fix common/ includes.
8141         * target.c: Fix common/ includes.
8142         * target-memory.c: Fix common/ includes.
8143         * target-descriptions.c: Fix common/ includes.
8144         * symtab.h: Fix common/ includes.
8145         * symfile.c: Fix common/ includes.
8146         * stap-probe.c: Fix common/ includes.
8147         * spu-linux-nat.c: Fix common/ includes.
8148         * sparc-nat.c: Fix common/ includes.
8149         * source.c: Fix common/ includes.
8150         * solib.c: Fix common/ includes.
8151         * solib-target.c: Fix common/ includes.
8152         * ser-unix.c: Fix common/ includes.
8153         * ser-tcp.c: Fix common/ includes.
8154         * ser-pipe.c: Fix common/ includes.
8155         * ser-base.c: Fix common/ includes.
8156         * selftest-arch.c: Fix common/ includes.
8157         * s12z-tdep.c: Fix common/ includes.
8158         * rust-exp.y: Fix common/ includes.
8159         * rs6000-aix-tdep.c: Fix common/ includes.
8160         * riscv-tdep.c: Fix common/ includes.
8161         * remote.c: Fix common/ includes.
8162         * remote-notif.h: Fix common/ includes.
8163         * remote-fileio.h: Fix common/ includes.
8164         * remote-fileio.c: Fix common/ includes.
8165         * regcache.h: Fix common/ includes.
8166         * regcache.c: Fix common/ includes.
8167         * record-btrace.c: Fix common/ includes.
8168         * python/python.c: Fix common/ includes.
8169         * python/py-type.c: Fix common/ includes.
8170         * python/py-inferior.c: Fix common/ includes.
8171         * progspace.h: Fix common/ includes.
8172         * producer.c: Fix common/ includes.
8173         * procfs.c: Fix common/ includes.
8174         * proc-api.c: Fix common/ includes.
8175         * printcmd.c: Fix common/ includes.
8176         * ppc-linux-nat.c: Fix common/ includes.
8177         * parser-defs.h: Fix common/ includes.
8178         * osdata.c: Fix common/ includes.
8179         * obsd-nat.c: Fix common/ includes.
8180         * nat/x86-linux.c: Fix common/ includes.
8181         * nat/x86-linux-dregs.c: Fix common/ includes.
8182         * nat/x86-dregs.h: Fix common/ includes.
8183         * nat/x86-dregs.c: Fix common/ includes.
8184         * nat/ppc-linux.c: Fix common/ includes.
8185         * nat/mips-linux-watch.h: Fix common/ includes.
8186         * nat/mips-linux-watch.c: Fix common/ includes.
8187         * nat/linux-waitpid.c: Fix common/ includes.
8188         * nat/linux-ptrace.h: Fix common/ includes.
8189         * nat/linux-ptrace.c: Fix common/ includes.
8190         * nat/linux-procfs.c: Fix common/ includes.
8191         * nat/linux-personality.c: Fix common/ includes.
8192         * nat/linux-osdata.c: Fix common/ includes.
8193         * nat/linux-namespaces.c: Fix common/ includes.
8194         * nat/linux-btrace.h: Fix common/ includes.
8195         * nat/linux-btrace.c: Fix common/ includes.
8196         * nat/fork-inferior.c: Fix common/ includes.
8197         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8198         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8199         * nat/aarch64-linux.c: Fix common/ includes.
8200         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8201         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8202         * namespace.h: Fix common/ includes.
8203         * mips-linux-tdep.c: Fix common/ includes.
8204         * minsyms.c: Fix common/ includes.
8205         * mi/mi-parse.h: Fix common/ includes.
8206         * mi/mi-main.c: Fix common/ includes.
8207         * mi/mi-cmd-env.c: Fix common/ includes.
8208         * memrange.h: Fix common/ includes.
8209         * memattr.c: Fix common/ includes.
8210         * maint.h: Fix common/ includes.
8211         * maint.c: Fix common/ includes.
8212         * main.c: Fix common/ includes.
8213         * machoread.c: Fix common/ includes.
8214         * location.c: Fix common/ includes.
8215         * linux-thread-db.c: Fix common/ includes.
8216         * linux-nat.c: Fix common/ includes.
8217         * linux-fork.c: Fix common/ includes.
8218         * inline-frame.c: Fix common/ includes.
8219         * infrun.c: Fix common/ includes.
8220         * inflow.c: Fix common/ includes.
8221         * inferior.h: Fix common/ includes.
8222         * inferior.c: Fix common/ includes.
8223         * infcmd.c: Fix common/ includes.
8224         * inf-ptrace.c: Fix common/ includes.
8225         * inf-child.c: Fix common/ includes.
8226         * ia64-linux-nat.c: Fix common/ includes.
8227         * i387-tdep.c: Fix common/ includes.
8228         * i386-tdep.c: Fix common/ includes.
8229         * i386-linux-tdep.c: Fix common/ includes.
8230         * i386-linux-nat.c: Fix common/ includes.
8231         * i386-go32-tdep.c: Fix common/ includes.
8232         * i386-fbsd-tdep.c: Fix common/ includes.
8233         * i386-fbsd-nat.c: Fix common/ includes.
8234         * guile/scm-type.c: Fix common/ includes.
8235         * guile/guile.c: Fix common/ includes.
8236         * go32-nat.c: Fix common/ includes.
8237         * gnu-nat.c: Fix common/ includes.
8238         * gdbthread.h: Fix common/ includes.
8239         * gdbarch-selftests.c: Fix common/ includes.
8240         * gdb_usleep.c: Fix common/ includes.
8241         * gdb_select.h: Fix common/ includes.
8242         * gdb_bfd.c: Fix common/ includes.
8243         * gcore.c: Fix common/ includes.
8244         * fork-child.c: Fix common/ includes.
8245         * findvar.c: Fix common/ includes.
8246         * fbsd-nat.c: Fix common/ includes.
8247         * event-top.c: Fix common/ includes.
8248         * event-loop.c: Fix common/ includes.
8249         * dwarf2read.c: Fix common/ includes.
8250         * dwarf2loc.c: Fix common/ includes.
8251         * dwarf2-frame.c: Fix common/ includes.
8252         * dwarf-index-cache.c: Fix common/ includes.
8253         * dtrace-probe.c: Fix common/ includes.
8254         * disasm-selftests.c: Fix common/ includes.
8255         * defs.h: Fix common/ includes.
8256         * csky-tdep.c: Fix common/ includes.
8257         * cp-valprint.c: Fix common/ includes.
8258         * cp-support.h: Fix common/ includes.
8259         * cp-support.c: Fix common/ includes.
8260         * corelow.c: Fix common/ includes.
8261         * completer.h: Fix common/ includes.
8262         * completer.c: Fix common/ includes.
8263         * compile/compile.c: Fix common/ includes.
8264         * compile/compile-loc2c.c: Fix common/ includes.
8265         * compile/compile-cplus-types.c: Fix common/ includes.
8266         * compile/compile-cplus-symbols.c: Fix common/ includes.
8267         * command.h: Fix common/ includes.
8268         * cli/cli-dump.c: Fix common/ includes.
8269         * cli/cli-cmds.c: Fix common/ includes.
8270         * charset.c: Fix common/ includes.
8271         * build-id.c: Fix common/ includes.
8272         * btrace.h: Fix common/ includes.
8273         * btrace.c: Fix common/ includes.
8274         * breakpoint.h: Fix common/ includes.
8275         * breakpoint.c: Fix common/ includes.
8276         * ax.h:
8277         (enum agent_op): Fix common/ includes.
8278         * ax-general.c (struct aop_map): Fix common/ includes.
8279         * ax-gdb.c: Fix common/ includes.
8280         * auxv.c: Fix common/ includes.
8281         * auto-load.c: Fix common/ includes.
8282         * arm-tdep.c: Fix common/ includes.
8283         * arch/riscv.c: Fix common/ includes.
8284         * arch/ppc-linux-common.c: Fix common/ includes.
8285         * arch/i386.c: Fix common/ includes.
8286         * arch/arm.c: Fix common/ includes.
8287         * arch/arm-linux.c: Fix common/ includes.
8288         * arch/arm-get-next-pcs.c: Fix common/ includes.
8289         * arch/amd64.c: Fix common/ includes.
8290         * arch/aarch64.c: Fix common/ includes.
8291         * arch/aarch64-insn.c: Fix common/ includes.
8292         * arch-utils.c: Fix common/ includes.
8293         * amd64-windows-tdep.c: Fix common/ includes.
8294         * amd64-tdep.c: Fix common/ includes.
8295         * amd64-sol2-tdep.c: Fix common/ includes.
8296         * amd64-obsd-tdep.c: Fix common/ includes.
8297         * amd64-nbsd-tdep.c: Fix common/ includes.
8298         * amd64-linux-tdep.c: Fix common/ includes.
8299         * amd64-linux-nat.c: Fix common/ includes.
8300         * amd64-fbsd-tdep.c: Fix common/ includes.
8301         * amd64-fbsd-nat.c: Fix common/ includes.
8302         * amd64-dicos-tdep.c: Fix common/ includes.
8303         * amd64-darwin-tdep.c: Fix common/ includes.
8304         * agent.c: Fix common/ includes.
8305         * ada-lang.h: Fix common/ includes.
8306         * ada-lang.c: Fix common/ includes.
8307         * aarch64-tdep.c: Fix common/ includes.
8308
8309 2019-01-25  Tom Tromey  <tom@tromey.com>
8310
8311         * common/create-version.sh: Use common/version.h.
8312
8313 2019-01-24  Pedro Alves  <palves@redhat.com>
8314
8315         * infrun.c (signal_stop, signal_print, signal_program)
8316         (signal_catch, signal_pass): Now arrays instead of pointers.
8317         (update_signals_program_target, do_target_resume)
8318         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8319         * linux-nat.c (linux_nat_target::pass_signals)
8320         (linux_nat_target::create_inferior, linux_nat_target::attach):
8321         Adjust.
8322         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8323         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8324         * procfs.c (procfs_target::pass_signals): Adjust.
8325         * record-full.c (record_full_target::resume): Adjust.
8326         * remote.c (remote_target::pass_signals)
8327         (remote_target::program_signals): Adjust.
8328         * target-debug.h (target_debug_print_signals): Now takes a
8329         gdb::array_view as parameter.  Adjust.
8330         * target.h (target_ops) <pass_signals, program_signals>: Replace
8331         pointer and length parameters with gdb::array_view.
8332         (target_pass_signals, target_program_signals): Likewise.
8333         * target-delegates.c: Regenerate.
8334
8335 2019-01-24  Pedro Alves  <palves@redhat.com>
8336
8337         * common/forward-scope-exit.h
8338         (forward_scope_exit::forward_scope_exit): Pass arguments to
8339         m_bind_function directly, instead of creating a std::bind and
8340         copying that.
8341
8342 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8343
8344         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8345         for static members.
8346         (pass_in_v_vfp_candidate): Likewise.
8347
8348 2019-01-23  Tom Tromey  <tom@tromey.com>
8349             Pedro Alves  <palves@redhat.com>
8350
8351         * regcache.c (class regcache_invalidator): Remove.
8352         (regcache::raw_write): Use make_scope_exit.
8353
8354 2019-01-23  Tom Tromey  <tom@tromey.com>
8355
8356         * ui-out.h (class ui_out_emit_type): Update comment.
8357
8358 2019-01-23  Tom Tromey  <tom@tromey.com>
8359
8360         * infrun.c (fetch_inferior_event): Update comment.
8361
8362 2019-01-23  Tom Tromey  <tom@tromey.com>
8363             Pedro Alves  <palves@redhat.com>
8364
8365         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8366         parameter.
8367         (fetch_inferior_event): Use SCOPE_EXIT.
8368
8369
8370 2019-01-23  Tom Tromey  <tom@tromey.com>
8371             Pedro Alves  <palves@redhat.com>
8372
8373         * infrun.c (disable_thread_events): Delete.
8374         (stop_all_threads): Use SCOPE_EXIT.
8375
8376 2019-01-23  Tom Tromey  <tom@tromey.com>
8377             Pedro Alves  <palves@redhat.com>
8378
8379         * symfile.c: Include forward-scope-exit.h.
8380         (clear_symtab_users_cleanup): Replace forward declaration with
8381         a FORWARD_SCOPE_EXIT.
8382         (syms_from_objfile_1): Use the forward_scope_exit and
8383         gdb::optional instead of cleanup_function.
8384         (reread_symbols): Use the forward_scope_exit instead of
8385         cleanup_function.
8386         (clear_symtab_users_cleanup): Remove function.
8387
8388 2019-01-23  Tom Tromey  <tom@tromey.com>
8389             Pedro Alves  <palves@redhat.com>
8390
8391         * linux-nat.c: Include scope-exit.h.
8392         (cleanup_target_stop): Remove.
8393         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8394         SCOPE_EXIT.
8395
8396 2019-01-23  Tom Tromey  <tom@tromey.com>
8397             Pedro Alves  <palves@redhat.com>
8398
8399         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8400         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8401
8402 2019-01-23  Tom Tromey  <tom@tromey.com>
8403             Andrew Burgess  <andrew.burgess@embecosm.com>
8404             Pedro Alves  <palves@redhat.com>
8405
8406         * infrun.c (fetch_inferior_event): Use scope_exit.
8407         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8408         * top.c (execute_command): Use scope_exit.
8409         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8410         * utils.c (do_bpstat_clear_actions_cleanup)
8411         (make_bpstat_clear_actions_cleanup): Remove.
8412
8413 2019-01-23  Tom Tromey  <tom@tromey.com>
8414             Pedro Alves  <palves@redhat.com>
8415
8416         * infrun.c: Include "common/scope-exit.h"
8417         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8418         (wait_for_inferior): Use SCOPE_EXIT.
8419         (fetch_inferior_event): Use scope_exit.
8420
8421 2019-01-23  Tom Tromey  <tom@tromey.com>
8422             Pedro Alves  <palves@redhat.com>
8423
8424         * breakpoint.c (create_breakpoint): Remove cleanup.
8425
8426 2019-01-23  Tom Tromey  <tom@tromey.com>
8427             Andrew Burgess  <andrew.burgess@embecosm.com>
8428             Pedro Alves  <palves@redhat.com>
8429
8430 2019-01-23  Pedro Alves  <palves@redhat.com>
8431
8432         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8433
8434 2019-01-23  Pedro Alves  <palves@redhat.com>
8435             Andrew Burgess  <andrew.burgess@embecosm.com>
8436
8437         * gdbthread.h: Include "common/forward-scope-exit.h".
8438         (scoped_finish_thread_state): Redefine custom class in terms of
8439         forward_scope_exit.
8440
8441 2019-01-23  Pedro Alves  <palves@redhat.com>
8442             Andrew Burgess  <andrew.burgess@embecosm.com>
8443
8444         * common/forward-scope-exit.h: New file.
8445
8446 2019-01-23  Pedro Alves  <palves@redhat.com>
8447             Andrew Burgess  <andrew.burgess@embecosm.com>
8448             Tom Tromey  <tom@tromey.com>
8449
8450         * common/scope-exit.h: New file.
8451
8452 2019-01-23  Pedro Alves  <palves@redhat.com>
8453
8454         * common/preprocessor.h (ESC): Rename to ...
8455         (ESC_PARENS): ... this.
8456         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8457         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8458
8459 2019-01-23  Tom Tromey  <tom@tromey.com>
8460
8461         * language.h (class scoped_switch_to_sym_language_if_auto):
8462         Initialize m_lang in both cases.
8463
8464 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8465
8466         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8467         with XCNEW.
8468
8469 2019-01-22  Tom Tromey  <tom@tromey.com>
8470
8471         * corelow.c: Do not include sys/file.h.
8472
8473 2019-01-22  Tom Tromey  <tom@tromey.com>
8474
8475         * tui/tui-wingeneral.h: Include gdb_curses.h.
8476
8477 2019-01-22  Tom Tromey  <tom@tromey.com>
8478
8479         * source-cache.h (class source_cache) <get_source_lines,
8480         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8481
8482 2019-01-22  Tom Tromey  <tom@tromey.com>
8483
8484         * remote-fileio.h (struct remote_target): Declare.
8485
8486 2019-01-22  Tom Tromey  <tom@tromey.com>
8487
8488         * python/py-arch.c: Do not include py-ref.h.
8489         * python/py-bpevent.c: Do not include py-ref.h.
8490         * python/py-cmd.c: Do not include py-ref.h.
8491         * python/py-continueevent.c: Do not include py-ref.h.
8492         * python/py-event.h: Do not include py-ref.h.
8493         * python/py-evtregistry.c: Do not include py-ref.h.
8494         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8495         * python/py-frame.c: Do not include py-ref.h.
8496         * python/py-framefilter.c: Do not include py-ref.h.
8497         * python/py-function.c: Do not include py-ref.h.
8498         * python/py-infevents.c: Do not include py-ref.h.
8499         * python/py-linetable.c: Do not include py-ref.h.
8500         * python/py-objfile.c: Do not include py-ref.h.
8501         * python/py-param.c: Do not include py-ref.h.
8502         * python/py-prettyprint.c: Do not include py-ref.h.
8503         * python/py-progspace.c: Do not include py-ref.h.
8504         * python/py-symbol.c: Do not include py-ref.h.
8505         * python/py-symtab.c: Do not include py-ref.h.
8506         * python/py-type.c: Do not include py-ref.h.
8507         * python/py-unwind.c: Do not include py-ref.h.
8508         * python/py-utils.c: Do not include py-ref.h.
8509         * python/py-value.c: Do not include py-ref.h.
8510         * python/py-varobj.c: Do not include py-ref.h.
8511         * python/py-xmethods.c: Do not include py-ref.h.
8512         * python/python.c: Do not include py-ref.h.
8513         * varobj.c: Do not include py-ref.h.
8514
8515 2019-01-22  Tom Tromey  <tom@tromey.com>
8516
8517         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8518         keyword for bcache.
8519
8520 2019-01-22  Tom Tromey  <tom@tromey.com>
8521
8522         * compile/compile-cplus-types.c: Remove a comment by #include.
8523
8524 2019-01-22  Tom Tromey  <tom@tromey.com>
8525
8526         * compile/gcc-c-plugin.h: Include compile-internal.h.
8527
8528 2019-01-22  Tom Tromey  <tom@tromey.com>
8529
8530         * stabsread.c (EXTERN): Do not define.
8531         (symnum, next_symbol_text_func, processing_gcc_compilation)
8532         (within_function, global_sym_chain, global_stabs)
8533         (previous_stab_code, this_object_header_files)
8534         (n_this_object_header_files)
8535         (n_allocated_this_object_header_files): Define.
8536         * stabsread.h (EXTERN): Never define.  Use "extern".
8537
8538 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8539
8540         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8541         history_value.
8542
8543 2019-01-21  Tom Tromey  <tom@tromey.com>
8544
8545         * ui-out.c: Fix includes.
8546         * tui/tui-source.c: Fix includes.
8547         * target.c: Fix includes.
8548         * remote.c: Fix includes.
8549         * regcache.c: Fix includes.
8550         * python/py-block.c: Fix includes.
8551         * printcmd.c: Fix includes.
8552         * or1k-tdep.c: Fix includes.
8553         * mi/mi-main.c: Fix includes.
8554         * m32r-tdep.c: Fix includes.
8555         * csky-tdep.c: Fix includes.
8556         * compile/compile-cplus-types.c: Fix includes.
8557         * cli/cli-interp.c: Fix includes.
8558
8559 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8560
8561         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8562         for padding.
8563
8564 2019-01-16  Tom Tromey  <tom@tromey.com>
8565
8566         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8567         earlier.
8568         (struct objfile) <msymbols_range>: Move from top level.
8569         <msymbols>: New method.
8570         (class objfile_msymbols): Remove.
8571         * symtab.c (default_collect_symbol_completion_matches_break_on):
8572         Update.
8573         * symmisc.c (dump_msymbols): Update.
8574         * stabsread.c (scan_file_globals): Update.
8575         * objc-lang.c (info_selectors_command, info_classes_command)
8576         (find_methods): Update.
8577         * minsyms.c (find_solib_trampoline_target): Update.
8578         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8579         * coffread.c (coff_symfile_read): Update.
8580         * ada-lang.c (ada_lookup_simple_minsym)
8581         (ada_collect_symbol_completion_matches): Update.
8582
8583 2019-01-16  Tom Tromey  <tom@tromey.com>
8584
8585         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8586         type.  Remove no-argument constructor.
8587         <iterator::operator++>: Simplify.
8588         <begin>: Update.
8589         <end>: Use minimal_symbol_count.
8590
8591 2019-01-16  Tom Tromey  <tom@tromey.com>
8592
8593         * objfiles.h (struct objfile) <psymtabs>: New method.
8594         (class objfile_psymtabs): Remove.
8595         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8596         typedef.
8597         <range>: New method.
8598         (require_partial_symbols): Change return type.
8599         * psymtab.c (require_partial_symbols)
8600         (psym_expand_symtabs_matching): Update.
8601         * mdebugread.c (parse_partial_symbols): Update.
8602         * dbxread.c (dbx_end_psymtab): Update.
8603
8604 2019-01-15  Tom Tromey  <tom@tromey.com>
8605
8606         * symtab.c (lookup_objfile_from_block)
8607         (lookup_symbol_in_objfile_symtabs)
8608         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8609         (find_line_symtab, info_sources_command)
8610         (default_collect_symbol_completion_matches_break_on)
8611         (make_source_files_completion_list): Update.
8612         * symmisc.c (print_objfile_statistics, dump_objfile)
8613         (maintenance_print_symbols, maintenance_info_symtabs)
8614         (maintenance_check_symtabs, maintenance_info_line_tables):
8615         Update.
8616         * source.c (select_source_symtab)
8617         (forget_cached_source_info_for_objfile): Update.
8618         * objfiles.h (class objfile_compunits): Remove.
8619         (struct objfile) <compunits_range>: New typedef.
8620         (compunits): New method.
8621         * objfiles.c (objfile_relocate1): Update.
8622         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8623         * maint.c (count_symtabs_and_blocks): Update.
8624         * linespec.c (iterate_over_all_matching_symtabs): Update.
8625         * cp-support.c (add_symbol_overload_list_qualified): Update.
8626         * coffread.c (coff_symtab_read): Update.
8627         * ada-lang.c (add_nonlocal_symbols)
8628         (ada_collect_symbol_completion_matches)
8629         (ada_add_global_exceptions): Update.
8630
8631 2019-01-15  Tom Tromey  <tom@tromey.com>
8632
8633         * progspace.h (program_space) <objfiles_safe_range>: New
8634         typedef.
8635         <objfiles_safe>: New method.
8636         * objfiles.h (class all_objfiles_safe): Remove.
8637         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8638         * jit.c (jit_inferior_exit_hook): Update.
8639
8640 2019-01-17  Tom Tromey  <tom@tromey.com>
8641
8642         * progspace.h (program_space) <objfiles_range>: New typedef.
8643         <objfiles>: New method.
8644         <objfiles_head>: Rename from objfiles.
8645         (object_files): Update.
8646         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8647         * guile/scm-pretty-print.c
8648         (ppscm_find_pretty_printer_from_objfiles): Update.
8649         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8650         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8651         Update.
8652         * python/py-progspace.c (pspy_get_objfiles): Update.
8653         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8654         Update.
8655         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8656         (objfpy_lookup_objfile_by_build_id): Update.
8657         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8658         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8659         Update.
8660         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8661         (expand_symtab_containing_pc, lookup_objfile_from_block)
8662         (lookup_static_symbol, basic_lookup_transparent_type)
8663         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8664         (find_line_symtab, info_sources_command)
8665         (default_collect_symbol_completion_matches_break_on)
8666         (make_source_files_completion_list, find_main_name): Update.
8667         * symmisc.c (print_symbol_bcache_statistics)
8668         (print_objfile_statistics, maintenance_print_symbols)
8669         (maintenance_print_msymbols, maintenance_print_objfiles)
8670         (maintenance_info_symtabs, maintenance_check_symtabs)
8671         (maintenance_expand_symtabs, maintenance_info_line_tables):
8672         Update.
8673         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8674         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8675         (map_overlay_command, unmap_overlay_command)
8676         (simple_overlay_update, expand_symtabs_matching)
8677         (map_symbol_filenames): Update.
8678         * symfile-debug.c (set_debug_symfile): Update.
8679         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8680         Update.
8681         * source.c (select_source_symtab, forget_cached_source_info):
8682         Update.
8683         * solib.c (solib_read_symbols): Update.
8684         * solib-spu.c (append_ocl_sos): Update.
8685         * psymtab.c (maintenance_print_psymbols)
8686         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8687         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8688         * printcmd.c (info_symbol_command): Update.
8689         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8690         Update.
8691         * objfiles.h (class all_objfiles): Remove.
8692         * objfiles.c (have_partial_symbols, have_full_symbols)
8693         (have_minimal_symbols, qsort_cmp, update_section_map)
8694         (shared_objfile_contains_address_p)
8695         (default_iterate_over_objfiles_in_search_order): Update.
8696         * objc-lang.c (info_selectors_command, info_classes_command)
8697         (find_methods): Update.
8698         * minsyms.c (find_solib_trampoline_target): Update.
8699         * maint.c (maintenance_info_sections)
8700         (maintenance_translate_address, count_symtabs_and_blocks):
8701         Update.
8702         * main.c (captured_main_1): Update.
8703         * linux-thread-db.c (try_thread_db_load_from_pdir)
8704         (has_libpthread): Update.
8705         * linespec.c (iterate_over_all_matching_symtabs)
8706         (search_minsyms_for_name): Update.
8707         * jit.c (jit_find_objf_with_entry_addr): Update.
8708         * hppa-tdep.c (find_unwind_entry)
8709         (hppa_lookup_stub_minimal_symbol): Update.
8710         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8711         Update.
8712         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8713         (elf_gnu_ifunc_resolve_by_got): Update.
8714         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8715         * dwarf-index-write.c (save_gdb_index_command): Update.
8716         * cp-support.c (add_symbol_overload_list_qualified): Update.
8717         * breakpoint.c (create_overlay_event_breakpoint)
8718         (create_longjmp_master_breakpoint)
8719         (create_std_terminate_master_breakpoint)
8720         (create_exception_master_breakpoint): Update.
8721         * blockframe.c (find_pc_partial_function): Update.
8722         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8723         (ada_collect_symbol_completion_matches)
8724         (ada_add_global_exceptions): Update.
8725
8726 2019-01-17  Tom Tromey  <tom@tromey.com>
8727
8728         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8729         declare VEC.
8730         (solib_target_parse_libraries): Change return type.
8731         (library_list_start_segment, library_list_start_section)
8732         (library_list_end_library, library_list_start_library); Update.
8733         (solib_target_free_library_list): Remove.
8734         (solib_target_parse_libraries): Remove cleanup.  Change return
8735         type.
8736         (solib_target_current_sos): Update.
8737
8738 2019-01-17  Tom Tromey  <tromey@bapiya>
8739
8740         * valprint.c: Replace "the the" with "the".
8741         * symtab.c: Replace "the the" with "the".
8742         * solib.c: Replace "the the" with "the".
8743         * solib-dsbt.c: Replace "the the" with "the".
8744         * linespec.c: Replace "the the" with "the".
8745         * dwarf2loc.h: Replace "the the" with "the".
8746         * amd64-windows-tdep.c: Replace "the the" with "the".
8747         * aarch64-tdep.c: Replace "the the" with "the".
8748
8749 2019-01-16  Keith Seitz  <keiths@redhat.com>
8750
8751         PR gdb/23773
8752         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8753         <builder>: Rename to ..
8754         <m_builder>: ... this and make private.
8755         (dwarf2_cu::get_builder): New method.  Change all users of
8756         `builder' to use this method.
8757         (dwarf2_start_symtab): Move to ...
8758         (dwarf2_cu::start_symtab): ... here.  Update all callers
8759         (setup_type_unit_groups): Move to ...
8760         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8761         callers.
8762         (dwarf2_cu::reset_builder): New method.
8763         (process_full_compunit, process_full_type_unit): Use
8764         dwarf2_cu::reset_builder.
8765         (follow_die_offset): Record the ancestor CU if it is different
8766         from the followed DIE's CU.
8767         (follow_die_sig_1): Likewise.
8768
8769 2019-01-15  Tom Tromey  <tom@tromey.com>
8770
8771         * remote.c (class remote_state) <buf>: Now a char_vector.
8772         <buf_size>: Remove.
8773         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8774         parameter.
8775         (remote_target::getpkt_or_notif_sane_1)
8776         (remote_target::getpkt_sane)
8777         (remote_target::getpkt_or_notif_sane): Likewise.
8778         (class remote_target) <putpkt>: New overload.
8779         (remote_target::read_frame): Change type of "buf_p".  Remove
8780         sizeof_p parameter.
8781         (packet_ok): New overload.
8782         (packet_check_result): New overload.
8783         Update all uses.
8784
8785 2019-01-14  Tom Tromey  <tom@tromey.com>
8786
8787         * remote-notif.c (handle_notification, remote_notif_ack)
8788         (remote_notif_parse): Make "buf" const.
8789         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8790         const.
8791         (remote_notif_parse, remote_notif_ack, handle_notification):
8792         Likewise.
8793         * remote.c (remote_notif_stop_parse): Make "buf" const.
8794         (remote_target::remote_parse_stop_reply): Make "buf" const.
8795         (remote_notif_stop_ack): Make "buf" const.
8796
8797 2019-01-14  Tom Tromey  <tom@tromey.com>
8798
8799         * remote.c (remote_console_output): Make parameter const.
8800
8801 2019-01-14  Tom Tromey  <tom@tromey.com>
8802
8803         * target-debug.h (target_debug_print_signals): Constify.
8804         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8805         * procfs.c (procfs_target::pass_signals): Update.
8806         * linux-nat.c (linux_nat_target::pass_signals): Update.
8807         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8808         * target-delegates.c: Rebuild.
8809         * remote.c (remote_target::program_signals): Update.
8810         (remote_target::pass_signals): Update.
8811         * target.c (target_pass_signals): Constify argument.
8812         (target_program_signals): Likewise.
8813         * target.h (struct target_ops) <pass_signals, program_signals>:
8814         Constify argument.
8815         (target_pass_signals, target_program_signals): Constify argument.
8816
8817 2019-01-14  Tom Tromey  <tom@tromey.com>
8818
8819         PR tui/28819:
8820         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8821
8822 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8823
8824         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8825         field.
8826         * rs6000-tdep.c: Include reggroups.h.
8827         (IS_V_ALIAS_PSEUDOREG): Define.
8828         (rs6000_register_name): Return names for the "vX" aliases.
8829         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8830         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8831         aliases.  Call default_register_reggroup_p for all other
8832         pseudo-registers.
8833         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8834         New functions.
8835         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8836         Handle "vX" aliases.
8837         (v_alias_pseudo_register_collect): New function.
8838         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8839         (rs6000_gdbarch_init): Initialize "vX" aliases as
8840         pseudo-registers.  Restore registration of
8841         rs6000_pseudo_register_reggroup_p with
8842         set_tdesc_pseudo_register_reggroup_p.
8843
8844 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8845
8846         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8847         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8848         set_gdbarch_num_pseudo_regs.
8849
8850 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8851
8852         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8853         Remove arg prefixname, add do_set and do_show.
8854         Add member functions set_list and show_list.
8855         * cli/cli-style.c (class cli_style_option): Update accordingly.
8856         (style_set_list): Move to file scope.
8857         (style_show_list): Likewise.
8858         (set_style): Call help_list.
8859         (show_style): Call cmd_show_list.
8860         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8861         Update to use the new macro.
8862
8863 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8864
8865         * ada-lang.c (_initialize_ada_language): Expand the help text
8866         for the "catch exception" command.
8867
8868 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8869
8870         * symtab.c (matching_obj_sections): Initialize obj,
8871         declare it closer to its usage.
8872
8873 2019-01-10  Tom Tromey  <tom@tromey.com>
8874
8875         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8876         (basic_inf_threads_range): Remove.
8877         (inf_threads_range, inf_non_exited_threads_range)
8878         (safe_inf_threads_range): Use next_adapter.
8879
8880 2019-01-10  Keith Seitz  <keiths@redhat.com>
8881
8882         PR gdb/23712
8883         PR symtab/23010
8884         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8885         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8886
8887 2019-01-10  Keith Seitz  <keiths@redhat.com>
8888
8889         PR gdb/23712
8890         PR symtab/23010
8891         * dictionary.c (pending_to_vector): Remove.
8892         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8893         Remove _1 suffix, replacing functions of the same name.  Update
8894         all callers.
8895         (dict_create_hashed, dict_create_hashed_expandable)
8896         (dict_create_linear, dict_create_linear_expandable, dict_free)
8897         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8898         Make functions static.
8899
8900 2019-01-10  Keith Seitz  <keiths@redhat.com>
8901
8902         PR gdb/23712
8903         PR symtab/23010
8904         * dictionary.h (struct dictionary): Replace declaration with
8905         multidictionary.
8906         (dict_create_hashed, dict_create_hashed_expandable)
8907         (dict_create_linear, dict_create_linear_expandable)
8908         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8909         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8910         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8911         taking multidictionary argument.
8912         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8913         * block.h (struct block) <dict>: Change to multidictionary
8914         and rename `multidict'.
8915         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8916         symmisc.c: Update all dictionary references to multidictionary.
8917
8918 2019-01-10  Keith Seitz  <keiths@redhat.com>
8919
8920         PR gdb/23712
8921         PR symtab/23010
8922         * dictionary.c: Include unordered_map.
8923         (pending_to_vector): New function.
8924         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8925         Rewrite the non-"_1" functions to take vector instead
8926         of linked list.
8927         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8928         "new" _1 versions of the same name.
8929         (multidictionary): Define.
8930         (std::hash<enum language): New definition.
8931         (collate_pending_symbols_by_language, mdict_create_hashed)
8932         (mdict_create_hashed_expandable, mdict_create_linear)
8933         (mdict_create_linear_expandable, mdict_free)
8934         (find_language_dictionary, create_new_language_dictionary)
8935         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8936         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8937         (mdict_size, mdict_empty): New functions.
8938         * dictionary.h (mdict_iterator): Define.
8939
8940 2019-01-10  Pedro Alves  <palves@redhat.com>
8941
8942         * breakpoint.c (read_uploaded_action)
8943         (create_tracepoint_from_upload): Adjust to use
8944         gdb::unique_xmalloc_ptr.
8945         * ctf.c (ctf_write_uploaded_tp):
8946         (SET_ARRAY_FIELD): Use emplace_back.
8947         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8948         * tracefile-tfile.c (tfile_write_uploaded_tp):
8949         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8950         gdb::unique_xmalloc_ptr.
8951         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8952         at_string, cond_string, cmd_strings>: Replace char pointers
8953         with gdb::unique_xmalloc_ptr.
8954
8955 2019-01-10  Pedro Alves  <palves@redhat.com>
8956
8957         * solib-target.c (library_list_start_library): Don't xstrdup name.
8958
8959 2019-01-10  Pedro Alves  <palves@redhat.com>
8960
8961         * mdebugread.c (parse_partial_symbols): Use
8962         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8963
8964 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8965
8966         * linux-fork.c (scoped_switch_fork_info)
8967         <~scoped_switch_fork_info>: Fix incorrect variable name.
8968
8969 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8970
8971         * linux-fork.c (scoped_switch_fork_info)
8972         <scoped_switch_fork_info>: Make explicit.
8973         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8974
8975 2019-01-10  Tom Tromey  <tom@tromey.com>
8976
8977         * objfiles.h (objfile::reset_psymtabs): Update.
8978         * objfiles.c (objfile::objfile): Update.
8979         * psymtab.h (psymtab_storage::obstack): Update.
8980         (psymtab_storage::m_obstack): Use gdb::optional.
8981         (class psymtab_storage): Update comment.  Remove objfile
8982         parameter.
8983         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8984
8985 2019-01-10  Tom Tromey  <tom@tromey.com>
8986
8987         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8988         <free_psymtabs>: Now private.
8989         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8990         (allocate_psymtab): Use new method.
8991
8992 2019-01-10  Tom Tromey  <tom@tromey.com>
8993
8994         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8995         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8996         * mdebugread.c (parse_partial_symbols): Use
8997         allocate_dependencies.
8998         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8999         allocate_dependencies.
9000         (process_psymtab_comp_unit_reader)
9001         (build_type_psymtab_dependencies): Likewise.
9002         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9003
9004 2019-01-10  Tom Tromey  <tom@tromey.com>
9005
9006         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9007         PSYMBOL_SET_LANGUAGE.
9008         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9009
9010 2019-01-10  Tom Tromey  <tom@tromey.com>
9011
9012         * psymtab.h (psymtab_storage::obstack): New method.
9013         <m_obstack>: Rename from obstack; now private.
9014         * psymtab.c (psymtab_storage): Update.
9015         * dwarf2read.c (create_addrmap_from_index)
9016         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9017         Update.
9018
9019 2019-01-10  Tom Tromey  <tom@tromey.com>
9020
9021         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9022         * objfiles.h (objfile::reset_psymtabs): New method.
9023
9024 2019-01-10  Tom Tromey  <tom@tromey.com>
9025
9026         * symmisc.c (print_symbol_bcache_statistics): Update.
9027         (print_objfile_statistics): Update.
9028         * symfile.c (reread_symbols): Update.
9029         * psymtab.h (class psymtab_storage): New.
9030         * psymtab.c (psymtab_storage): New constructor.
9031         (~psymtab_storage): New destructor.
9032         (require_partial_symbols): Update.
9033         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9034         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9035         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9036         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9037         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9038         (start_psymtab_common, end_psymtab_common)
9039         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9040         (allocate_psymtab): Update.
9041         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9042         Update.
9043         (dump_psymtab_addrmap, maintenance_print_psymbols)
9044         (maintenance_check_psymtabs): Update.
9045         (class objfile_psymtabs): Move to objfiles.h.
9046         * psympriv.h (discard_psymtab): Now inline.
9047         (psymtab_discarder::psymtab_discarder): Update.
9048         (psymtab_discarder::~psymtab_discarder): Update.
9049         (ALL_OBJFILE_PSYMTABS): Rewrite.
9050         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9051         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9052         Remove fields.
9053         <partial_symtabs>: New field.
9054         (class objfile_psymtabs): Move from psymtab.h.  Update.
9055         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9056         psymbol_cache.
9057         (objfile::~objfile): Don't destroy psymbol_cache.
9058         * mdebugread.c (parse_partial_symbols): Update.
9059         * dwarf2read.c (create_addrmap_from_index)
9060         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9061         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9062         (add_partial_subprogram, dwarf2_ranges_read): Update.
9063         * dwarf-index-write.c (write_address_map)
9064         (write_one_signatured_type, recursively_write_psymbols)
9065         (class debug_names, class debug_names, write_psymtabs_to_index):
9066         Update.
9067
9068 2019-01-10  Tom Tromey  <tom@tromey.com>
9069
9070         * symtab.h (SYMBOL_SET_NAMES): Update.
9071         (symbol_set_names): Update.
9072         (MSYMBOL_SET_NAMES): Update.
9073         * symtab.c (symbol_set_names): Change argument to be an
9074         objfile_per_bfd_storage.
9075         * psymtab.c (add_psymbol_to_bcache): Update.
9076         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9077
9078 2019-01-10  Tom Tromey  <tom@tromey.com>
9079
9080         * symtab.c (create_demangled_names_hash): Change argument to be an
9081         objfile_per_bfd_storage.
9082         (symbol_set_names): Update.
9083
9084 2019-01-10  Tom Tromey  <tom@tromey.com>
9085
9086         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9087         init_psymbol_list.
9088         * psymtab.c (init_psymbol_list): Do nothing if already called.
9089         * psympriv.h (init_psymbol_list): Add comment.
9090         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9091         init_psymbol_list.
9092         * dbxread.c (dbx_symfile_read): Unconditionally call
9093         init_psymbol_list.
9094
9095 2019-01-10  Tom Tromey  <tom@tromey.com>
9096
9097         * xcoffread.c (scan_xcoff_symtab): Update.
9098         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9099         "where".
9100         * mdebugread.c (parse_partial_symbols)
9101         (handle_psymbol_enumerators): Update.
9102         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9103         * dbxread.c (read_dbx_symtab): Update.
9104         * psympriv.h (psymbol_placement): New enum.
9105         (add_psymbol_to_list): Update.
9106
9107 2019-01-10  Tom Tromey  <tom@tromey.com>
9108
9109         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9110         static_psymbols parameters.
9111         (scan_xcoff_symtab): Update.
9112         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9113         static_psymbols parameters.
9114         * psympriv.h (start_psymtab_common): Update.
9115         * mdebugread.c (parse_partial_symbols): Update.
9116         * dwarf2read.c (create_partial_symtab): Update.
9117         * dbxread.c (read_dbx_symtab): Update.
9118         (start_psymtab): Remove global_psymbols and static_psymbols
9119         parameters.
9120
9121 2019-01-10  Tom Tromey  <tom@tromey.com>
9122
9123         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9124         * psymtab.c (allocate_psymtab): Add comment.
9125         * psympriv.h (allocate_psymtab): Add comment.
9126         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9127         initializations.
9128         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9129
9130 2019-01-10  Tom Tromey  <tom@tromey.com>
9131
9132         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9133         Don't declare.
9134         * mipsread.c: Include mdebugread.h.
9135         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9136         Declare.
9137         * elfread.c: Include mdebugread.h.
9138
9139 2019-01-09  Tom Tromey  <tom@tromey.com>
9140
9141         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9142         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9143         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9144         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9145         (psym_lookup_symbol, psym_find_last_source_symtab)
9146         (psym_forget_cached_source_info, psym_print_stats)
9147         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9148         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9149         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9150         (psym_find_compunit_symtab_by_address)
9151         (maintenance_print_psymbols, maintenance_info_psymtabs)
9152         (maintenance_check_psymtabs): Use ranged for.
9153         * psymtab.h (class objfile_psymtabs): New.
9154         (require_partial_symbols): Return objfile_psymtabs.
9155         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9156
9157 2019-01-09  Tom Tromey  <tom@tromey.com>
9158
9159         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9160         (find_pc_mapped_section, list_overlays_command)
9161         (map_overlay_command, unmap_overlay_command)
9162         (simple_overlay_update): Use all_objfiles.
9163         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9164         * printcmd.c (info_symbol_command): Use all_objfiles.
9165         * objfiles.h (ALL_OBJSECTIONS): Remove.
9166         * maint.c (maintenance_translate_address): Use all_objfiles.
9167         * gcore.c (gcore_create_callback): Use all_objfiles.
9168         (objfile_find_memory_regions): Likewise.
9169
9170 2019-01-09  Tom Tromey  <tom@tromey.com>
9171
9172         * symtab.c (find_line_symtab, info_sources_command)
9173         (make_source_files_completion_list): Use objfile_compunits.
9174         * source.c (select_source_symtab): Use objfile_compunits.
9175         * objfiles.h (struct objfile): Update comment.
9176         (ALL_OBJFILES): Remove.
9177         (ALL_FILETABS): Remove.
9178         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9179         objfile_compunits.
9180
9181 2019-01-09  Tom Tromey  <tom@tromey.com>
9182
9183         * symmisc.c (print_objfile_statistics, dump_objfile)
9184         (maintenance_print_symbols): Use compunit_filetabs.
9185         * source.c (forget_cached_source_info_for_objfile): Use
9186         compunit_filetabs.
9187         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9188         (ALL_FILETABS): Use compunit_filetabs.
9189         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9190         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9191
9192 2019-01-09  Tom Tromey  <tom@tromey.com>
9193
9194         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9195         (compunit_filetabs): New.
9196         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9197         compunit_filetabs.
9198         (info_sources_command, make_source_files_completion_list): Remove
9199         declaration.
9200         * symmisc.c (print_objfile_statistics, dump_objfile)
9201         (maintenance_print_symbols): Remove declaration.
9202         (maintenance_info_symtabs): Use compunit_filetabs.
9203         (maintenance_info_line_tables): Likewise.
9204         * source.c (select_source_symtab): Change local variable name.
9205         (forget_cached_source_info_for_objfile): Remove declaration.
9206         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9207         * objfiles.c (objfile_relocate1): Remove declaration.
9208         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9209         declaration.
9210         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9211         * coffread.c (coff_symtab_read): Remove declaration.
9212         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9213         compunit_filetabs.
9214
9215 2019-01-09  Tom Tromey  <tom@tromey.com>
9216
9217         * symtab.c (lookup_objfile_from_block)
9218         (find_pc_sect_compunit_symtab, search_symbols)
9219         (default_collect_symbol_completion_matches_break_on): Use
9220         objfile_compunits.
9221         * objfiles.h (ALL_COMPUNITS): Remove.
9222         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9223         * cp-support.c (add_symbol_overload_list_qualified): Use
9224         objfile_compunits.
9225         * ada-lang.c (ada_collect_symbol_completion_matches)
9226         (ada_add_global_exceptions): Use objfile_compunits.
9227
9228 2019-01-09  Tom Tromey  <tom@tromey.com>
9229
9230         * source.c (select_source_symtab)
9231         (forget_cached_source_info_for_objfile): Remove declaration.
9232         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9233         declaration.
9234         * maint.c (count_symtabs_and_blocks): Remove declaration.
9235         * cp-support.c (add_symbol_overload_list_qualified): Remove
9236         declaration.
9237         * coffread.c (coff_symtab_read): Remove declaration.
9238         * symtab.c (lookup_symbol_in_objfile_symtabs)
9239         (basic_lookup_transparent_type_1): Use objfile_compunits.
9240         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9241         (info_sources_command, search_symbols)
9242         (default_collect_symbol_completion_matches_break_on)
9243         (make_source_files_completion_list): Remove declaration.
9244         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9245         (ada_collect_symbol_completion_matches)
9246         (ada_add_global_exceptions): Remove declaration.
9247         * linespec.c (iterate_over_all_matching_symtabs): Use
9248         objfile_compunits.
9249         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9250         (class objfile_compunits): New.
9251         (ALL_COMPUNITS): Use objfile_compunits.
9252         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9253         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9254         objfile_compunits.
9255         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9256
9257 2019-01-09  Tom Tromey  <tom@tromey.com>
9258
9259         * symtab.c (search_symbols)
9260         (default_collect_symbol_completion_matches_break_on): Use
9261         objfile_msymbols.
9262         * ada-lang.c (ada_lookup_simple_minsym)
9263         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9264         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9265         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9266         objfile_msymbols.
9267         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9268         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9269         * objc-lang.c (find_methods): Use objfile_msymbols.
9270         (info_selectors_command, info_classes_command): Likewise.
9271         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9272         * objfiles.h (class objfile_msymbols): New.
9273         (ALL_OBJFILE_MSYMBOLS): Remove.
9274         (ALL_MSYMBOLS): Remove.
9275
9276 2019-01-09  Tom Tromey  <tom@tromey.com>
9277
9278         * common/next-iterator.h (next_adapter): Add Iterator template
9279         parameter.
9280         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9281         (class all_objfiles_safe): New.
9282         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9283         * objfiles.c (put_objfile_before): Update comment.
9284         (add_separate_debug_objfile): Likewise.
9285         (free_all_objfiles): Use all_objfiles_safe.
9286         (objfile_purge_solibs): Likewise.
9287
9288 2019-01-09  Tom Tromey  <tom@tromey.com>
9289
9290         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9291         (expand_symtab_containing_pc, lookup_static_symbol)
9292         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9293         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9294         all_objfiles.
9295         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9296         * breakpoint.c (create_overlay_event_breakpoint)
9297         (create_longjmp_master_breakpoint)
9298         (create_std_terminate_master_breakpoint)
9299         (create_exception_master_breakpoint): Use all_objfiles.
9300         * linux-thread-db.c (try_thread_db_load_from_pdir)
9301         (has_libpthread): Use all_objfiles.
9302         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9303         * linespec.c (iterate_over_all_matching_symtabs)
9304         (search_minsyms_for_name): Use all_objfiles.
9305         * maint.c (maintenance_info_sections): Use all_objfiles.
9306         * main.c (captured_main_1): Use all_objfiles.
9307         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9308         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9309         * guile/scm-pretty-print.c
9310         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9311         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9312         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9313         (maintenance_print_msymbols): Use all_objfiles.
9314         * source.c (select_source_symtab): Use all_objfiles.
9315         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9316         * symfile.c (remove_symbol_file_command)
9317         (expand_symtabs_matching, map_symbol_filenames): Use
9318         all_objfiles.
9319         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9320         all_objfiles.
9321         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9322         * objc-lang.c (find_methods): Use all_objfiles.
9323         * objfiles.c (have_partial_symbols, have_full_symbols)
9324         (have_minimal_symbols, qsort_cmp)
9325         (default_iterate_over_objfiles_in_search_order): Use
9326         all_objfiles.
9327         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9328         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9329         (maintenance_check_psymtabs): Use all_objfiles.
9330         (ALL_PSYMTABS): Remove.
9331         * compile/compile-object-run.c (do_module_cleanup): Use
9332         all_objfiles.
9333         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9334         * cp-support.c (add_symbol_overload_list_qualified): Use
9335         all_objfiles.
9336         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9337         Use all_objfiles.
9338         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9339         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9340         all_objfiles.
9341         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9342         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9343         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9344         Uses all_objfiles.
9345         * solib.c (solib_read_symbols): Use all_objfiles
9346
9347 2019-01-09  Tom Tromey  <tom@tromey.com>
9348
9349         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9350         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9351         all_objfiles.
9352         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9353         * symmisc.c (print_symbol_bcache_statistics)
9354         (print_objfile_statistics, maintenance_print_objfiles)
9355         (maintenance_info_symtabs, maintenance_check_symtabs)
9356         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9357         all_objfiles.
9358         * source.c (forget_cached_source_info): Use all_objfiles.
9359         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9360         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9361         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9362         * objfiles.c (update_section_map): Use all_objfiles.
9363         (shared_objfile_contains_address_p): Likewise.
9364         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9365         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9366
9367 2019-01-09  Tom Tromey  <tom@tromey.com>
9368
9369         * common/next-iterator.h: New file.
9370         * objfiles.h (class all_objfiles): New.
9371         (struct objfile_iterator): New.
9372
9373 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9374
9375         * NEWS: Move the description of the changed "frame", "select-frame",
9376          and "info frame" commands to the Changed commands section.
9377
9378 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9379
9380         * gdbtypes.c (check_stub_method_group): Remove handling of old
9381         mangling schemes.
9382         * linespec.c (find_methods): Likewise.
9383         * stabsread.c (read_member_functions): Likewise.
9384         * valops.c (search_struct_method): Likewise.
9385         (value_struct_elt_for_reference): Likewise.
9386         * NEWS: Mention this change.
9387
9388 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9389
9390         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9391         print_source_lines.
9392         * source.c (print_source_lines_base): Update line number check.
9393         (print_source_lines): New function.
9394         (source_lines_range::source_lines_range): New function.
9395         * source.h (class source_lines_range): New class.
9396         (print_source_lines): New declaration.
9397
9398 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9399
9400         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9401
9402 2019-01-08  Tom Tromey  <tom@tromey.com>
9403             Simon Marchi  <simon.marchi@ericsson.com>
9404
9405         PR gdb/24060
9406         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9407         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9408         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9409         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9410         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9411         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9412
9413 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9414
9415         * source.c (select_source_symtab): Move header comment to
9416         declaration in source.h.
9417         (forget_cached_source_info_for_objfile): Likewise.
9418         (forget_cached_source_info): Likewise.
9419         (identify_source_line): Likewise.
9420         * source.h (identify_source_line): Move declaration from symtab.h
9421         and add comment from source.c
9422         (print_source_lines): Likewise.
9423         (forget_cached_source_info_for_objfile): Likewise.
9424         (forget_cached_source_info): Likewise.
9425         (select_source_symtab): Likewise.
9426         (enum print_source_lines_flag): Move definition from symtab.h.
9427         * symtab.h (identify_source_line): Move declaration to source.h.
9428         (print_source_lines): Likewise.
9429         (forget_cached_source_info_for_objfile): Likewise.
9430         (forget_cached_source_info): Likewise.
9431         (select_source_symtab): Likewise.
9432         (enum print_source_lines_flag): Move definition to source.h.
9433         * tui/tui-hooks.c: Add 'source.h' include.
9434
9435 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9436
9437         * source.c (print_source_lines_base): Handle requests to print
9438         reverse line number sequences, and guard against empty lines
9439         string.
9440
9441 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9442
9443         * source.c (print_source_lines_base): Fix skip of '\r' if next
9444         character is '\n'.
9445
9446 2019-01-06  Tom Tromey  <tom@tromey.com>
9447
9448         * c-exp.y (struct c_parse_state) <macro_original_text,
9449         expansion_obstack>: New member.
9450         (macro_original_text, expansion_obstack): Remove globals.
9451         (scan_macro_expansion, scanning_macro_expansion)
9452         (finished_macro_expansion): Update.
9453         (scan_macro_cleanup): Remove.
9454         (yylex, c_parse): Update.
9455
9456 2019-01-06  Tom Tromey  <tom@tromey.com>
9457
9458         * c-exp.y (struct c_parse_state) <strings>: New member.
9459         (operator_stoken): Update.
9460
9461 2019-01-06  Tom Tromey  <tom@tromey.com>
9462
9463         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9464         (union type_stack_elt) <typelist_val>: Now a pointer to
9465         std::vector.
9466         (type_stack_cleanup): Don't declare.
9467         (push_typelist): Update.
9468         * parse.c (pop_typelist): Return a std::vector.
9469         (push_typelist): Take a std::vector.
9470         (follow_types): Update.  Do not free args.
9471         (type_stack_cleanup): Remove.
9472         * c-exp.y (struct c_parse_state): New.
9473         (cpstate): New global.
9474         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9475         (nonempty_typelist): Update.
9476         (func_mod): Create a new vector.
9477         (c_parse): Create a c_parse_state.
9478         (check_parameter_typelist): Do not delete params.
9479         (function_method): Update.  Do not delete type_list.
9480
9481 2019-01-06  Tom Tromey  <tom@tromey.com>
9482
9483         PR gdb/28155:
9484         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9485         check_typedef.
9486         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9487         (print_return_value): Likewise.
9488
9489 2019-01-05  Tom Tromey  <tom@tromey.com>
9490
9491         * contrib/cleanup_check.py: Remove.
9492         * contrib/gcc-with-excheck: Remove.
9493         * contrib/exsummary.py: Remove.
9494         * contrib/excheck.py: Remove.
9495
9496 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9497
9498         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9499         NULL. Initialize tpprev to NULL instead of assigning it
9500         to NULL on the next statement.
9501         * windows-nat.c (windows_delete_thread): Remove check for
9502         main_thread_id before printing thread exit notifications.
9503         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9504         Remove thread ID check against main_thread_id.
9505         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9506         windows_delete_thread.
9507         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9508
9509 2019-01-04  Tom Tromey  <tom@tromey.com>
9510
9511         * compile/compile.c (_initialize_compile): Use upper case for
9512         metasyntactic variables.
9513         * symmisc.c (_initialize_symmisc): Use upper case for
9514         metasyntactic variables.
9515         * psymtab.c (_initialize_psymtab): Use upper case for
9516         metasyntactic variables.
9517         * demangle.c (demangle_command): Use upper case for metasyntactic
9518         variables.
9519         (_initialize_demangler): Likewise.
9520         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9521         variables.
9522
9523 2019-01-03  Tom Tromey  <tom@tromey.com>
9524
9525         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9526
9527 2019-01-03  Tom Tromey  <tom@tromey.com>
9528
9529         * python/py-symtab.c (salpy_str): Update.
9530         (struct salpy_sal_object) <symtab>: Now a PyObject.
9531         (salpy_dealloc): Update.
9532         (del_objfile_sal): Use gdbpy_ref.
9533
9534 2019-01-03  Tom Tromey  <tom@tromey.com>
9535
9536         * python/py-type.c (convert_field): Use new_reference.  Return
9537         gdbpy_ref.
9538         (make_fielditem): Return gdbpy_ref.
9539         (typy_fields): Update.
9540         (typy_getitem): Update.
9541         (field_name): Return gdbpy_ref.  Use new_reference.
9542         (typy_iterator_iternext): Update.
9543
9544 2019-01-03  Tom Tromey  <tom@tromey.com>
9545
9546         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9547
9548 2019-01-03  Tom Tromey  <tom@tromey.com>
9549
9550         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9551         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9552         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9553         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9554         (pspy_set_type_printers): Likewise.
9555         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9556         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9557         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9558         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9559         (objfpy_set_type_printers): Likewise.
9560
9561 2019-01-03  Tom Tromey  <tom@tromey.com>
9562
9563         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9564         (gdbpy_print_stack): Use gdbpy_err_fetch.
9565         * python/python-internal.h (class gdbpy_err_fetch): New class.
9566         (class gdbpy_enter) <m_error_type, m_error_value,
9567         m_error_traceback>: Remove.
9568         <m_error>: New member.
9569         (gdbpy_exception_to_string): Don't declare.
9570         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9571         * python/py-value.c (convert_value_from_python): Use
9572         gdbpy_err_fetch.
9573         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9574         gdbpy_exception_to_string.
9575         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9576         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9577         gdbpy_err_fetch.
9578
9579 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9580
9581         * linux-nat.c (delete_lwp_cleanup): Delete.
9582         (struct lwp_deleter): New struct.
9583         (lwp_info_up): New typedef.
9584         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9585         lwp_info_up.
9586
9587 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9588
9589         * linux-fork.c (class scoped_switch_fork_info): New class.
9590         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9591
9592 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9593
9594         * valops.c (find_overload_match): Remove use of null_cleanup, and
9595         calls to do_cleanups.
9596
9597 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9598
9599         * compile/compile-cplus-types.c
9600         (compile_cplus_instance::decl_name): Handle changes to
9601         cp_func_name.
9602         * cp-support.c (cp_func_name): Update header comment, update
9603         return type.
9604         * cp-support.h (cp_func_name): Update return type in declaration.
9605         * valops.c (find_overload_match): Move temp_func local to top
9606         level of function and change its type.  Use temp_func to hold and
9607         delete temporary string obtained from cp_func_name.
9608
9609 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9610
9611         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9612         gdb::char_vector, remove cleanup, and update uses of `msg`.
9613
9614 2019-01-03  Jim Wilson  <jimw@sifive.com>
9615
9616         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9617
9618 2019-01-02  Tom Tromey  <tom@tromey.com>
9619
9620         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9621         (tdesc_parse_xml): Remove cleanups.
9622         * target-descriptions.h (make_cleanup_free_target_description):
9623         Don't declare.
9624         (target_desc_deleter): New struct.
9625         (target_desc_up): New typedef.
9626         * target-descriptions.c (target_desc_deleter::operator()): Rename
9627         from free_target_description.
9628         (make_cleanup_free_target_description): Remove.
9629
9630 2019-01-02  Tom Tromey  <tom@tromey.com>
9631
9632         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9633         constructor, destructor.
9634         (linespec_parser): Remove typedef.
9635         (~linespec_parser): Rename from linespec_parser_delete.
9636         (linespec_lex_to_end, linespec_complete_label)
9637         (linespec_complete): Update.
9638         (decode_line_full): Remove cleanups.
9639         (decode_line_1): Update.
9640
9641 2019-01-02  Tom Tromey  <tom@tromey.com>
9642
9643         * python/python-internal.h (inferior_to_inferior_object): Change
9644         return type.
9645         * python/py-exitedevent.c (create_exited_event_object): Update.
9646         * python/py-inferior.c (inferior_to_inferior_object): Return
9647         gdbpy_ref.
9648         (python_new_inferior, python_inferior_deleted)
9649         (thread_to_thread_object, delete_thread_object)
9650         (build_inferior_list, gdbpy_selected_inferior): Update.
9651         * python/py-infthread.c (create_thread_object): Update.  Also fail
9652         if inferior_to_inferior_object fails.
9653
9654 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9655
9656         * inferior.h (class inferior) <displaced_step_state>: New field.
9657         * infrun.h (struct displaced_step_state): Move here from
9658         infrun.c.  Initialize fields, add constructor.
9659         <inf>: Remove field.
9660         <reset>: New method.
9661         * infrun.c (struct displaced_step_inferior_state): Move to
9662         infrun.h.
9663         (displaced_step_inferior_states): Remove.
9664         (get_displaced_stepping_state): Adust.
9665         (displaced_step_in_progress_any_inferior): Adjust.
9666         (displaced_step_in_progress_thread): Adjust.
9667         (displaced_step_in_progress): Adjust.
9668         (add_displaced_stepping_state): Remove.
9669         (get_displaced_step_closure_by_addr): Adjust.
9670         (remove_displaced_stepping_state): Remove.
9671         (infrun_inferior_exit): Call displaced_step_state.reset.
9672         (use_displaced_stepping): Don't check for NULL.
9673         (displaced_step_prepare_throw): Call
9674         get_displaced_stepping_state.
9675         (displaced_step_fixup): Don't check for NULL.
9676         (prepare_for_detach): Don't check for NULL.
9677
9678 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9679
9680         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9681          in case of call that did not complete.
9682
9683 2019-01-02  Andrey Utkin  <autkin@undo.io>
9684
9685         * symfile.c (find_separate_debug_file): Fix search of debug files for
9686         remote debuggee.
9687
9688 2019-01-02  Tom Tromey  <tom@tromey.com>
9689
9690         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9691         indentation.
9692         * python/py-frame.c (frapy_older): Remove cast.
9693         (frapy_newer): Likewise.
9694         * python/py-breakpoint.c (local_setattro): Remove cast.
9695         * python/py-arch.c (archpy_name): Remove local variable.
9696         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9697
9698 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9699
9700         * unittests/basic_string_view/element_access/char/empty.cc:
9701         Fix year range in copyright header.
9702
9703 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9704
9705         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9706         Delete.
9707         <operator==>: Update with for removed field.
9708         <hash>: Likewise.
9709         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9710         <isa_features>: ...this.
9711         <abi_features>: New field.
9712         (riscv_isa_flen): Update comment.
9713         (riscv_abi_xlen): New declaration.
9714         (riscv_abi_flen): New declaration.
9715         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9716         isa_features.
9717         (riscv_abi_xlen): New function.
9718         (riscv_isa_flen): Update to get answer from isa_features.
9719         (riscv_abi_flen): New function.
9720         (riscv_has_fp_abi): Update to get answer from abi_features.
9721         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9722         xlen and flen.
9723         (riscv_call_info) <xlen, flen>: Update comment.
9724         (riscv_call_arg_struct): Remove invalid assertions
9725         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9726         is removed.
9727         (riscv_gdbarch_init): Gather isa features and abi features
9728         separately, ensure both match on the gdbarch when reusing an old
9729         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9730         a target with 64-bit float hardware.
9731
9732 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9733
9734         * source.c (search_command_helper): Stop reverse search
9735         when line 1 has been searched.
9736
9737 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9738
9739         * record-full.c (record_full_base_target::close): Rewrite
9740         record_full_core_buf_list free logic.
9741
9742 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9743
9744         * break-catch-syscall.c (print_one_catch_syscall): xfree
9745         the last text.
9746
9747 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9748
9749         * top.c (print_gdb_version): Update Copyright year in version
9750         message.
9751
9752 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9753
9754         Update copyright year range in all GDB files.
9755
9756 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9757
9758         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9759
9760 For older changes see ChangeLog-2018.
9761 \f
9762 Local Variables:
9763 mode: change-log
9764 left-margin: 8
9765 fill-column: 74
9766 version-control: never
9767 coding: utf-8
9768 End:
9769