gdb/ChangeLog

   1 2019-07-19  Tom Tromey  <tromey@adacore.com>
   2
   3         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
   4         (ARGSUSED, PARAMS, __func__): Remove rules.
   5
   6 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
   7
   8         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
   9         * features/arm/arm-with-iwmmxt.c: Remove.
  10         * features/arm/arm-with-iwmmxt.xml: Remove.
  11         * features/arm/arm-with-m-fpa-layout.c: Remove.
  12         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  13         * features/arm/arm-with-m-vfp-d16.c: Remove.
  14         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  15         * features/arm/arm-with-m.c: Remove.
  16         * features/arm/arm-with-m.xml: Remove.
  17         * features/arm/arm-with-neon.c: Remove.
  18         * features/arm/arm-with-neon.xml: Remove.
  19         * features/arm/arm-with-vfpv2.c: Remove.
  20         * features/arm/arm-with-vfpv2.xml: Remove.
  21         * features/arm/arm-with-vfpv3.c: Remove.
  22         * features/arm/arm-with-vfpv3.xml: Remove.
  23
  24 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  25
  26         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  27
  28 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  29
  30         * arch/aarch32.c (aarch32_create_target_description): Create
  31         target descriptions using features.
  32         * arch/arm.c (arm_create_target_description)
  33         (arm_create_mprofile_target_description): Likewise.
  34         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  35
  36 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  37
  38         * Makefile.in: Add new files.
  39         * aarch32-tdep.c: New file.
  40         * aarch32-tdep.h: New file.
  41         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  42         Call aarch32_read_description.
  43         * arch/aarch32.c: New file.
  44         * arch/aarch32.h: New file.
  45         * arch/arm.c (arm_create_target_description)
  46         (arm_create_mprofile_target_description): New function.
  47         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  48         (arm_create_target_description)
  49         (arm_create_mprofile_target_description): New declaration.
  50         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  51         read_description functions.
  52         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  53         Likewise.
  54         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  55         * arm-tdep.c (tdesc_arm_list): New variable.
  56         (arm_register_g_packet_guesses): Call create description functions.
  57         (arm_read_description) (arm_read_mprofile_description): New
  58         function.
  59         * arm-tdep.h (arm_read_description)
  60         (arm_read_mprofile_description): Add declaration.
  61         * configure.tgt: Add new files.
  62
  63 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
  64
  65         * top.c (new_ui_command): Open specified terminal just once.
  66
  67 2019-07-18  Tom Tromey  <tromey@adacore.com>
  68
  69         * symtab.c (main_name): Constify return type.
  70         * symfile.c (set_initial_language): Update.
  71         * symtab.h (main_name): Constify return type.
  72
  73 2019-07-17  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-winsource.c (tui_update_source_window)
  76         (tui_update_source_window_as_is)
  77         (tui_update_source_windows_with_line): Remove return.
  78         * tui/tui-disasm.c (tui_show_disassem)
  79         (tui_show_disassem_and_update_source): Remove return.
  80         * tui/tui.c (tui_reset): Remove return.
  81         * tui/tui-wingeneral.c
  82         (tui_check_and_display_highlight_if_needed): Remove return.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
  87
  88 2019-07-17  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-winsource.h (struct tui_exec_info_window)
  91         (struct tui_source_window_base): Move from tui-data.h.
  92         * tui/tui-winsource.c: Move many method definitions from
  93         elsewhere.  Remove "structuring" comments.
  94         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
  95         (tui_source_window_base::refresh_window): Move to
  96         tui-winsource.c.
  97         * tui/tui-win.c (tui_source_window_base::refresh_all)
  98         (tui_source_window_base::update_tab_width)
  99         (tui_source_window_base::set_new_height)
 100         (tui_source_window_base::do_make_visible_with_new_height): Move to
 101         tui-winsource.c.
 102         * tui/tui-source.h: Update.
 103         * tui/tui-source.c (tui_source_window_base::reset): Move to
 104         tui-winsource.c.
 105         * tui/tui-disasm.h: Update.
 106         * tui/tui-data.h (struct tui_exec_info_window): Move to
 107         tui-winsource.h.
 108         (struct tui_source_window_base): Likewise.
 109         * tui/tui-data.c (tui_source_window_base::clear_detail)
 110         (tui_source_window_base, ~tui_source_window_base): Move to
 111         tui-winsource.c.
 112
 113 2019-07-17  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-win.c (tui_resize_all)
 116         (tui_source_window_base::update_tab_width)
 117         (tui_adjust_win_heights): Update.
 118         (tui_win_info::make_invisible_and_set_new_height): Rename from
 119         make_invisible_and_set_new_height.
 120         * tui/tui-data.h (struct tui_win_info)
 121         <make_invisible_and_set_new_height>: New method.
 122
 123 2019-07-17  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui.c: Update.
 126         * tui/tui-source.h (struct tui_source_window): Move from
 127         tui-data.h.
 128         * tui/tui-layout.c: Update.
 129         * tui/tui-disasm.c: Update.
 130         * tui/tui-data.h (struct tui_source_window): Move to
 131         tui-source.h.
 132
 133 2019-07-17  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 136         tui-data.h.
 137         * tui/tui-data.h (struct tui_disasm_window): Move to
 138         tui-disasm.h.
 139
 140 2019-07-17  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-regs.h (struct tui_data_item_window): Move from
 143         tui-data.h.
 144         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 145         * tui/tui-data.h (struct tui_data_item_window): Move to
 146         tui-regs.h.
 147         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 148
 149 2019-07-17  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui.c: Update.
 152         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 153         (tui_cmd_window::max_height): Move to tui-command.c.
 154         * tui/tui-layout.c: Update.
 155         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 156         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 157         tui-command.c.
 158         * tui/tui-command.h (struct tui_cmd_window): Move from
 159         tui-data.h.
 160         * tui/tui-command.c: Remove "structuring" comments.
 161         (tui_cmd_window::clear_detail)
 162         (tui_cmd_window::do_make_visible_with_new_height)
 163         (tui_cmd_window::max_height): Move from elsewhere.
 164
 165 2019-07-17  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 168         Now static.
 169         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 170         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 171
 172 2019-07-17  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui.c: Update.
 175         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 176         tui-regs.c.
 177         * tui/tui-windata.h: Remove file.
 178         * tui/tui-windata.c: Remove file.
 179         * tui/tui-win.c (tui_data_window::set_new_height)
 180         (tui_data_window::do_make_visible_with_new_height): Move to
 181         tui-regs.c.
 182         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 183         * tui/tui-regs.c: Remove "structuring" comments.
 184         (tui_data_window::first_data_item_displayed)
 185         (tui_data_window::delete_data_content_windows)
 186         (tui_data_window::erase_data_content)
 187         (tui_data_window::display_all_data)
 188         (tui_data_window::refresh_all)
 189         (tui_data_window::do_scroll_vertical)
 190         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 191         (tui_data_window::do_make_visible_with_new_height)
 192         (tui_data_window::refresh_window): Move from elsewhere.
 193         (_initialize_tui_regs): Move to end of file.
 194         * tui/tui-layout.c: Update.
 195         * tui/tui-hooks.c: Update.
 196         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 197         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 198         tui-regs.c.
 199         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 200
 201 2019-07-17  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 204         seen.
 205
 206 2019-07-17  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-win.c (tui_source_window_base::set_new_height)
 209         (tui_source_window_base::do_make_visible_with_new_height): Use
 210         m_has_locator field directly.
 211         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 212         method.
 213         (struct tui_source_window_base) <has_locator>: Likewise.
 214
 215 2019-07-17  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 218         Don't declare.
 219         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 220         Remove.
 221         * tui/tui-win.c (tui_source_window_base::set_new_height)
 222         (tui_source_window_base::set_new_height)
 223         (make_invisible_and_set_new_height)
 224         (tui_source_window_base::do_make_visible_with_new_height)
 225         (tui_source_window_base::do_make_visible_with_new_height):
 226         Update.
 227         * tui/tui-layout.c (show_source_disasm_command, show_data)
 228         (show_source_or_disasm_and_command): Update.
 229         * tui/tui-layout.c (show_layout): Update.
 230
 231 2019-07-17  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-layout.c (make_data_window): Remove.
 234         (show_data): Unify creation and re-initialization cases.
 235
 236 2019-07-17  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-layout.c (make_source_window, make_disasm_window):
 239         Remove.
 240         (show_data): Unify creation and re-initialization cases.
 241
 242 2019-07-17  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-layout.c (make_command_window): Remove.
 245         (show_source_disasm_command, show_source_or_disasm_and_command):
 246         Unify creation and re-initialization cases.
 247
 248 2019-07-17  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 251         creation and re-initialization cases.
 252
 253 2019-07-17  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-regs.c (tui_get_register): Return void.
 256
 257 2019-07-17  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 260         Simplify.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 265         resetting.
 266
 267 2019-07-17  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 270         * tui/tui-regs.c (tui_reg_layout): New function.
 271         (tui_show_registers, tui_reg_command): Use it.
 272         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 273         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 274         parameters.
 275         (tui_layout_command): Remove.
 276
 277 2019-07-17  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-layout.h (tui/tui-layout): Return void.
 280         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 281
 282 2019-07-17  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-layout.c (show_source_disasm_command, show_data):
 285         Update.
 286         (reset_locator): Remove.
 287         (show_source_or_disasm_and_command): Update.
 288
 289 2019-07-17  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-source.c (tui_source_window_base::reset): Remove
 292         win_type parameter.
 293         * tui/tui-layout.c (make_command_window, make_source_window)
 294         (make_disasm_window, make_data_window)
 295         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 296         (reset_locator, show_source_or_disasm_and_command): Update.
 297         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 298         win_type parameter.
 299         (struct tui_source_window_base) <reset>: Likewise.
 300
 301 2019-07-17  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-layout.c (show_source_disasm_command): Use
 304         reset_locator.
 305         (reset_locator): New function.
 306         (init_and_make_win): Remove.
 307         (show_source_or_disasm_and_command): Use reset_locator.
 308
 309 2019-07-17  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 312         condition.
 313         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 314         Remove condition.
 315         * tui/tui-source.c (tui_source_window_base::reset): New method.
 316         * tui/tui-layout.c (make_command_window): Don't call
 317         init_and_make_win.
 318         (make_source_window, make_disasm_window): Don't call
 319         make_source_or_disasm_window.
 320         (make_data_window): Don't call init_and_make_win.  Change calling
 321         convention.
 322         (show_source_disasm_command, show_data): Simplify.
 323         (make_source_or_disasm_window): Remove.
 324         (show_source_or_disasm_and_command): Simplify.
 325         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 326         (struct tui_source_window_base) <reset>: Likewise.
 327         <execution_info>: Remove initializer.
 328         * tui/tui-data.c (tui_source_window_base): Initialize
 329         execution_info.
 330
 331 2019-07-17  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 334         variable.
 335
 336 2019-07-17  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui.c (tui_rl_other_window): Update.
 339         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 340         superclass method first.  Always iterate over regs_content.
 341         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 342         method.
 343         * tui/tui-win.c (tui_set_focus_command): Update.
 344
 345 2019-07-17  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-win.c (tui_set_focus_command): Rename from
 348         tui_set_focus.  Call tui_enable.
 349         (tui_set_focus_command): Remove.
 350
 351 2019-07-17  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 354         refresh_window.
 355         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 356         touchwin.
 357         (tui_data_window::refresh_window): Call refresh_window on data
 358         items.  Always call superclass refresh_window.
 359         (tui_win_info::refresh): Remove.
 360         (tui_source_window_base::refresh_window): Update.
 361         (tui_refresh_all): Update.
 362         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 363         refresh_window.
 364         (show_source_or_disasm_and_command): Likewise.
 365         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 366         (struct tui_source_window_base) <refresh>: Likewise.
 367
 368 2019-07-17  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-winsource.c (tui_clear_source_content)
 371         (tui_show_source_content): Update.
 372         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 373         whether content is empty.
 374         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 375         Remove.
 376
 377 2019-07-17  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 380         window's contents.
 381         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 382         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 383
 384 2019-07-17  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 387         (struct tui_data_item_window): Update.
 388
 389 2019-07-17  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 392         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 393         defines.
 394
 395 2019-07-17  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-winsource.h (tui_erase_source_content)
 398         (tui_clear_source_content): Remove "display_prompt" parameter.
 399         * tui/tui-winsource.c (tui_update_source_window_as_is)
 400         (tui_update_source_windows_with_addr): Update.
 401         (tui_clear_source_content): Remove "display_prompt" parameter.
 402         (tui_erase_source_content): Likewise.  Simplify.
 403         (tui_show_source_content): Update.
 404         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 405         * tui/tui-stack.c (tui_show_frame_info): Update.
 406         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 407         Remove defines.
 408
 409 2019-07-17  Tom Tromey  <tom@tromey.com>
 410
 411         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 412         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 413         parameter.
 414         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 415         parameter.
 416
 417 2019-07-17  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-winsource.c (tui_clear_source_content)
 420         (tui_show_source_content, tui_show_exec_info_content)
 421         (tui_clear_exec_info_content): Update.
 422         * tui/tui-stack.c (tui_show_locator_content): Update.
 423         (tui_show_frame_info): Update.
 424         * tui/tui-source.h (tui_source_window): Don't declare.
 425         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 426         from tui_source_is_displayed.
 427         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 428         Remove field.
 429         (struct tui_source_window_base) <content_in_use>: New field.  Now
 430         bool.
 431         (struct tui_source_window) <showing_source_p>: New method.
 432         (TUI_SRC_WIN): Change cast.
 433         * tui/tui-data.c (tui_initialize_static_data): Update.
 434
 435 2019-07-17  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 438         location_matches_p.
 439         * tui/tui-source.c (tui_source_window::location_matches_p): New
 440         method.
 441         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 442         method.
 443         * tui/tui-data.h (struct tui_source_window_base)
 444         <location_matches_p>: New method.
 445         (struct tui_source_window, struct tui_disasm_window)
 446         <location_matches_p>: Likewise.
 447
 448 2019-07-17  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-win.c (tui_set_win_height_command): Rename from
 451         tui_set_win_height.
 452         (tui_set_win_height_command): Remove.
 453
 454 2019-07-17  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-source.c (tui_source_window): New constructor.  Add
 457         observer.
 458         (~tui_source_window): New destructor.
 459         (tui_source_window::style_changed): New method.
 460         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 461         (tui_attach_detach_observers): Update.
 462         * tui/tui-data.h (struct tui_source_window): Make constructor not
 463         inline.  Add destructor.
 464         (struct tui_source_window) <style_changed>: New method.
 465         <m_observable>: New member.
 466
 467 2019-07-17  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 470         * tui/tui-win.c (tui_resize_all): Fix typo.
 471
 472 2019-07-17  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 475         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 476         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 477         * tui/tui-win.c (window_name_completer): Use foreach.
 478         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 479         (update_tab_width): Likewise.
 480         * tui/tui-layout.c (show_layout): Update.
 481         * tui/tui-data.h (class tui_window_iterator): New.
 482         (struct all_tui_windows): New.
 483         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 484
 485 2019-07-17  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 488         parameter.  Don't reference globals.
 489         (tui_reg_command): Update.
 490
 491 2019-07-17  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-regs.c (tui_show_registers): Simplify.
 494
 495 2019-07-17  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-regs.c (tui_show_registers): Update.
 498         (tui_show_register_group): Add win_info parameter.
 499
 500 2019-07-17  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 503         Rename from tui_display_reg_element_at_line.
 504         (tui_data_window::display_registers_from_line): Update.
 505         * tui/tui-data.h (struct tui_data_window)
 506         <display_reg_element_at_line>: New method.
 507
 508 2019-07-17  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-regs.h (tui_display_registers_from)
 511         (tui_display_registers_from_line): Don't declare.
 512         * tui/tui-windata.c (tui_data_window::display_all_data)
 513         (tui_data_window::refresh_all)
 514         (tui_data_window::do_scroll_vertical): Update.
 515         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 516         from tui_display_registers_from.
 517         (tui_display_reg_element_at_line): Update.
 518         (tui_data_window::display_registers_from_line): Rename from
 519         tui_display_registers_from_line.
 520         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 521         display_registers_from_line>: New methods.
 522
 523 2019-07-17  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 526         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 527         from tui_erase_data_content.
 528         (tui_data_window::display_all_data)
 529         (tui_data_window::refresh_all)
 530         (tui_data_window::do_scroll_vertical): Update.
 531         * tui/tui-regs.c (tui_show_registers): Update.
 532         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 533         New method.
 534
 535 2019-07-17  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 538         declare.
 539         * tui/tui-windata.c
 540         (tui_data_window::delete_data_content_windows): Rename from
 541         tui_delete_data_content_windows.
 542         (tui_data_window::display_all_data)
 543         (tui_data_window::do_scroll_vertical): Update.
 544         * tui/tui-data.h (struct tui_data_window)
 545         <delete_data_content_windows>: New method.
 546
 547 2019-07-17  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 550         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 551
 552 2019-07-17  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 555         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 556         from tui_display_all_data.
 557         * tui/tui-win.c
 558         (tui_data_window::do_make_visible_with_new_height): Update.
 559         * tui/tui-regs.c (tui_show_registers): Update.
 560         * tui/tui-layout.c (tui_set_layout): Update.
 561         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 562         method.
 563
 564 2019-07-17  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 567         * tui/tui-windata.c (tui_display_data_from): Remove.
 568         (tui_data_window::refresh_all): Update.
 569
 570 2019-07-17  Tom Tromey  <tom@tromey.com>
 571
 572         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 573         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 574         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 575         tui_display_registers_from_line.
 576         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 577         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 578         "force_display" parameter.
 579
 580 2019-07-17  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 583         declare.
 584         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 585         Rename from tui_first_reg_element_no_inline.
 586         (tui_display_reg_element_at_line)
 587         (tui_display_registers_from_line): Update.
 588         * tui/tui-data.h (struct tui_data_window)
 589         <first_reg_element_no_inline>: New method.
 590
 591 2019-07-17  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-windata.c (tui_display_data_from)
 594         (tui_data_window::do_scroll_vertical): Update.
 595         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 596         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 597         Rename from tui_line_from_reg_element_no.
 598         (tui_display_registers_from_line): Update.
 599         * tui/tui-data.h (struct tui_data_window)
 600         <line_from_reg_element_no>: New method.
 601
 602 2019-07-17  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 605         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 606         tui_last_regs_line_no.
 607         (tui_display_reg_element_at_line)
 608         (tui_display_registers_from_line): Update.
 609         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 610         method.
 611
 612 2019-07-17  Tom Tromey  <tom@tromey.com>
 613
 614         PR tui/24722:
 615         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 616         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 617         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 618         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 619         (tui_update_breakpoint_info): Likewise.
 620         * tui/tui-hooks.c (tui_event_create_breakpoint)
 621         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 622         Update.
 623
 624 2019-07-17  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 627
 628 2019-07-17  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-winsource.c (tui_update_source_window_as_is)
 631         (tui_update_source_windows_with_addr): Update.
 632         * tui/tui-source.h (tui_set_source_content)
 633         (tui_show_symtab_source): Add "win_info" parameter.
 634         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 635         parameter.
 636         (tui_show_symtab_source): Likewise.
 637
 638 2019-07-17  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-wingeneral.c
 641         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 642
 643 2019-07-17  Tom Tromey  <tom@tromey.com>
 644
 645         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 646         (struct tui_cmd_window) <can_scroll>: New method.
 647         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 648         method.
 649
 650 2019-07-17  Tom Tromey  <tromey@adacore.com>
 651
 652         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 653         do_field_signed>: Rename.  Change type of "value".
 654         * ui-out.c (ui_out::field_signed): Rename from field_int.
 655         Change type of "value".
 656         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 657         type of "value".
 658         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 659         do_field_int.  Change type of "value".
 660         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 661         do_field_int.  Change type of "value".
 662         * tracepoint.c (trace_status_mi, tfind_1)
 663         (print_one_static_tracepoint_marker): Update.
 664         * thread.c (print_thread_info_1, print_selected_thread_frame):
 665         Update.
 666         * stack.c (print_frame, print_frame_info): Update.
 667         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 668         Update.
 669         * source.c (print_source_lines_base): Update.
 670         * skip.c (info_skip_command): Update.
 671         * record-btrace.c (btrace_ui_out_decode_error)
 672         (btrace_call_history_src_line): Update.
 673         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 674         Update.
 675         * progspace.c (print_program_space): Update.
 676         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 677         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 678         do_field_int.  Change type of "value".
 679         * mi/mi-out.c (mi_ui_out::do_table_begin)
 680         (mi_ui_out::do_table_header): Update.
 681         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 682         type of "value".
 683         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 684         (mi_cmd_data_list_changed_registers, output_register)
 685         (mi_cmd_data_read_memory, mi_load_progress)
 686         (mi_cmd_trace_frame_collected): Update.
 687         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 688         Update.
 689         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 690         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 691         (mi_cmd_var_list_children, varobj_update_one): Update.
 692         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 693         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 694         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 695         * inferior.c (print_inferior): Update.
 696         * gdb_bfd.c (print_one_bfd): Update.
 697         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 698         Update.
 699         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 700         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 701         do_field_int.  Change type of "value".
 702         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 703         do_field_int.  Change type of "value".
 704         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 705         (print_one_breakpoint_location, print_it_catch_fork)
 706         (print_one_catch_fork, print_it_catch_vfork)
 707         (print_one_catch_vfork, print_it_catch_solib)
 708         (print_it_catch_exec, print_it_ranged_breakpoint)
 709         (print_mention_watchpoint, print_mention_masked_watchpoint)
 710         (bkpt_print_it, update_static_tracepoint): Update.
 711         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 712         * break-catch-syscall.c (print_it_catch_syscall): Update.
 713         * ada-tasks.c (print_ada_task_info): Update.
 714         * ada-lang.c (print_it_exception, print_mention_exception):
 715         Update.
 716
 717 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 718
 719         PR breakpoints/24541
 720         * gdbarch.c: Regenerate.
 721         * gdbarch.h: Regenerate.
 722         * gdbarch.sh: Adjust return type and parameter types for
 723         'stap_adjust_register'.
 724         (i386_stap_adjust_register): Adjust signature and return new
 725         register name.
 726         * stap-probe.c (stap_parse_register_operand): Adjust use of
 727         'gdbarch_stap_adjust_register'.
 728
 729 2019-07-17  Tom Tromey  <tromey@adacore.com>
 730
 731         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 732         declare VEC.
 733         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 734         std::vector.
 735         (struct s390_process_info): Add initializers.
 736         (s390_add_process): Use new.
 737         (s390_linux_nat_target::low_forget_process): Use delete.
 738         (s390_linux_nat_target::low_new_fork)
 739         (s390_linux_nat_target::stopped_by_watchpoint)
 740         (s390_linux_nat_target::low_prepare_to_resume)
 741         (s390_linux_nat_target::insert_watchpoint)
 742         (s390_linux_nat_target::insert_hw_breakpoint)
 743         (s390_linux_nat_target::remove_watchpoint)
 744         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 745
 746 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 747
 748         * aarch64-fbsd-nat.c: Include regcache.h.
 749         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 750         argument.
 751         (aarch64_fbsd_nat_target::fetch_registers)
 752         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 753         variable.
 754         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 755
 756 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 757
 758         * fbsd-nat.c: Include gdbarch.h.
 759
 760 2019-07-15  Tom Tromey  <tromey@adacore.com>
 761
 762         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 763
 764 2019-07-15  Tom Tromey  <tromey@adacore.com>
 765
 766         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 767         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 768         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 769         * cli-out.c (cli_ui_out::do_field_int): New method.
 770         * ui-out.c (ui_out::field_unsigned): New method.
 771         * symfile.c (generic_load): Use field_unsigned.
 772         (print_transfer_performance): Likewise.
 773         * record-btrace.c (ui_out_field_uint): Remove.
 774         (btrace_call_history_insn_range, btrace_call_history): Use
 775         field_unsigned.
 776         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 777         field_unsigned.
 778         * ui-out.h (class ui_out) <field_unsigned>: New method.
 779         <do_field_unsigned>: Likewise.
 780
 781 2019-07-15  Tom Tromey  <tromey@adacore.com>
 782
 783         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 784         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 785         * target.c (flash_erase_command): Use field_string.
 786         * infrun.c (print_signal_received_reason): Use field_string.
 787         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 788         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 789         field_string.
 790         * ada-tasks.c (print_ada_task_info): Use field_string.
 791
 792 2019-07-15  Tom Tromey  <tromey@adacore.com>
 793
 794         * target.c (flash_erase_command): Use field_core_addr.
 795         * symfile.c (generic_load): Use field_core_addr.
 796         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 797         Use field_core_addr.
 798         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 799         field_core_addr.
 800
 801 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 802
 803         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 804         value if its desired type is smaller than a CORE_ADDR and signed.
 805
 806 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 809         of changes to field names, and use new is_reference field to
 810         decide if a property is a reference or not.
 811         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 812         field.
 813         (struct dwarf2_property_baton): Update header comment, rename
 814         'referenced_type' to 'property_type' and update comments.
 815         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 816         default property type, store in property baton, update to take
 817         accound of renamed field.
 818         (read_func_scope): Update call to attr_to_dynamic_prop.
 819         (read_array_type): Likewise.
 820         (dwarf2_per_cu_addr_sized_int_type): New function.
 821         (read_subrange_index_type): Move type finding code to
 822         dwarf2_per_cu_addr_sized_int_type.
 823         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 824         (dwarf2_per_cu_addr_type): New function.
 825         (set_die_type): Update calls to attr_to_dynamic_prop.
 826
 827 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * dwarf2read.c (read_subrange_index_type): New function.
 830         (read_subrange_type): Move code into new function and call it.
 831         * gdbtypes.c (create_range_type): Add some asserts.
 832
 833 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 834
 835         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 836         update return statements.
 837         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 838         declaration, and update comment to match.
 839         * gdbtypes.c (resolve_dynamic_array): Update call to
 840         dwarf2_evaluate_property to match new return type.
 841
 842 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 843
 844         * valarith.c (value_subscripted_rvalue): Change lowerbound
 845         parameter type from int to LONGEST.
 846         * value.h (value_subscripted_rvalue): Likewise in declaration.
 847
 848 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 849
 850         * cli/cli-utils.c (info_print_command_completer): New function.
 851         * cli/cli-utils.h: Add 'completer.h' include, and forward
 852         declaration for 'struct cmd_list_element'.
 853         (info_print_command_completer): Declare.
 854         * stack.c (_initialize_stack): Add completer for 'info locals' and
 855         'info args'.
 856         * symtab.c (_initialize_symtab): Add completer for 'info
 857         variables' and 'info functions'.
 858         * NEWS: Mention completion for additional info commands.
 859
 860 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 861
 862         * cli/cli-utils.c (extract_info_print_args): Delete.
 863         (extract_arg_maybe_quoted): Delete.
 864         (info_print_options_defs): New variable.
 865         (make_info_print_options_def_group): New function.
 866         (extract_info_print_options): Define new function.
 867         * cli/cli-utils.h (extract_info_print_args): Delete.
 868         (struct info_print_options): New structure.
 869         (extract_info_print_options): Declare new function.
 870         * stack.c (info_locals_command): Update to use new
 871         extract_info_print_options, also add a header comment.
 872         (info_args_command): Likewise.
 873         * symtab.c (info_variables_command): Likewise.
 874         (info_functions_command): Likewise.
 875
 876 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 877
 878         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 879         to extract string arguments.
 880         * common/common-utils.c (extract_string_maybe_quoted): New function.
 881         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 882
 883 2019-07-11  Tom Tromey  <tromey@adacore.com>
 884
 885         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 886         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 887         * top.h (gdbinit): Don't declare.
 888         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 889         into...
 890         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 891         * top.c (gdb_init): Don't call init_cli_cmds.
 892         (gdbinit): Remove.
 893         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 894
 895 2019-07-11  Tom Tromey  <tromey@adacore.com>
 896
 897         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 898         after it has been moved.
 899
 900 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 901
 902         * valops.c (value_must_coerce_to_target): Change return type to
 903         bool.
 904         * value.h (value_must_coerce_to_target): Likewise.
 905
 906 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 907
 908         * breakpoint.c (is_hardware_watchpoint): Remove
 909         forward-declaration.
 910         (is_masked_watchpoint): Change return type to bool.
 911         (is_tracepoint): Likewise.
 912         (is_breakpoint): Likewise.
 913         (is_hardware_watchpoint): Likewise.
 914         (is_watchpoint): Likewise.
 915         (is_no_memory_software_watchpoint): Likewise.
 916         (is_catchpoint): Likewise.
 917         (breakpoint_1): Make FILTER parameter's return type bool.
 918         is_masked_watchpoint): Change return type to bool.
 919         (save_breakpoints): Make FILTER parameter's return type bool.
 920         * breakpoint.h (is_breakpoint): Change return type to bool.
 921         (is_watchpoint): Likewise.
 922         (is_catchpoint): Likewise.
 923         (is_tracepoint): Likewise.
 924
 925 2019-07-10  Tom Tromey  <tom@tromey.com>
 926
 927         * defs.h: Don't include gdbarch.h.
 928         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 929         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 930         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 931         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 932         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 933         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 934         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 935         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 936         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 937         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 938         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 939         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 940         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 941         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 942         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 943         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 944         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 945         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 946         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 947         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 948         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 949         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 950         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 951         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 952         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 953         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 954         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 955
 956 2019-07-10  Tom Tromey  <tromey@adacore.com>
 957
 958         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 959         * breakpoint.c (init_ada_exception_breakpoint): Register as
 960         bp_catchpoint.
 961         (print_one_breakpoint_location, print_one_breakpoint): Use
 962         is_ada_exception_catchpoint.
 963         * ada-lang.c (class ada_catchpoint_location): Pass
 964         bp_loc_software_breakpoint to bp_location constructor.
 965         (is_ada_exception_catchpoint): New function.
 966
 967 2019-07-10  Tom Tromey  <tromey@adacore.com>
 968
 969         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 970         VEC.
 971         (struct arm_exidx_entry): New method operator<.
 972         (struct arm_exidx_data) <section_maps>: Change type.
 973         (arm_exidx_data_free): Remove.
 974         (arm_exidx_data_key): Change type.  Move lower.
 975         (arm_exidx_new_objfile): Update.
 976         (arm_compare_exidx_entries): Remove.
 977         (arm_find_exidx_entry, _initialize_arm_tdep)
 978
 979 2019-07-10  Tom Tromey  <tromey@adacore.com>
 980
 981         * solib-spu.c (ocl_program_data_key): Change type.
 982         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 983         Update.
 984
 985 2019-07-10  Tom Tromey  <tromey@adacore.com>
 986
 987         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 988         (struct solib_aix_inferior_data) <library_list>: Change type.
 989         (solib_aix_inferior_data_handle): Change type.
 990         (get_solib_aix_inferior_data): Update.
 991         (solib_aix_free_library_list): Remove.
 992         (library_list_start_library): Update.
 993         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 994         return type.
 995         (solib_aix_get_library_list)
 996         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 997         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 998
 999 2019-07-10  Tom Tromey  <tromey@adacore.com>
1000
1001         * solib-dsbt.c (struct dsbt_info): Add initializers.
1002         (solib_dsbt_pspace_data): Change type.
1003         (dsbt_pspace_data_cleanup): Remove.
1004         (get_dsbt_info, _initialize_dsbt_solib): Update.
1005
1006 2019-07-10  Tom Tromey  <tromey@adacore.com>
1007
1008         * spu-tdep.c (spu_overlay_data): Change type.
1009         (spu_get_overlay_table, spu_overlay_new_objfile)
1010         (_initialize_spu_tdep): Update.
1011
1012 2019-07-10  Tom Tromey  <tromey@adacore.com>
1013
1014         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1015         destructor.
1016         (dbx_objfile_data_key): Change type and declare later.
1017         (DBX_SYMFILE_INFO): Rewrite.
1018         * dbxread.c (dbx_objfile_data_key): Change type.
1019         (dbx_symfile_init): Update.
1020         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1021         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1022         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1023
1024 2019-07-10  Tom Tromey  <tromey@adacore.com>
1025
1026         * jit.c (jit_program_space_key): Change type.  Move lower.
1027         (get_jit_program_space_data): Update.
1028         (jit_program_space_data_cleanup): Remove.
1029         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1030         Update.
1031         (struct jit_program_space_data): Add initializers.
1032
1033 2019-07-10  Tom Tromey  <tromey@adacore.com>
1034
1035         * solib-darwin.c (struct darwin_info): Add initializers.
1036         (solib_darwin_pspace_data): Change type.
1037         (darwin_pspace_data_cleanup): Remove.
1038         (get_darwin_info, _initialize_darwin_solib): Update.
1039
1040 2019-07-10  Tom Tromey  <tromey@adacore.com>
1041
1042         * remote-sim.c (struct sim_inferior_data): Add initializers,
1043         constructor, and destructor.
1044         (sim_inferior_data_key): Change type.  Move lower.
1045         (check_for_duplicate_sim_descriptor): Update.
1046         (get_sim_inferior_data): Use new.  Update.
1047         (~sim_inferior_data_cleanup): Rename from
1048         sim_inferior_data_cleanup.  Simplify.
1049         (gdbsim_close_inferior, simulator_command)
1050         (sim_command_completer, _initialize_remote_sim): Update.
1051         (next_pid, INITIAL_PID): Move earlier.
1052
1053 2019-07-10  Tom Tromey  <tromey@adacore.com>
1054
1055         * python/python-internal.h (create_thread_object): Return
1056         gdbpy_ref.
1057         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1058         * python/py-inferior.c (struct threadlist_entry): Add
1059         constructor.
1060         <thread_obj>: Now a gdbpy_ref.
1061         (thread_to_thread_object): Update.
1062         (add_thread_object): Use new.
1063         (delete_thread_object): Use delete.
1064         (infpy_threads): Update.
1065         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1066         GIL.
1067
1068 2019-07-10  Tom Tromey  <tromey@adacore.com>
1069
1070         * valops.c (value_cast): Specialize error message for Ada.
1071
1072 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1073
1074         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1075
1076 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1077
1078         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1079         bpstat_should_step): Return bool, adjust comments.
1080         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1081         bpstat_should_step): Likewise.
1082
1083 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1084
1085         * features/Makefile: Use feature target descriptions for Arm.
1086         * features/arm/arm-core.c: Generate new file.
1087         * features/arm/arm-fpa.c: Likewise.
1088         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1089         * features/arm/arm-m-profile.c: Likewise.
1090         * features/arm/arm-vfpv2.c: Likewise.
1091         * features/arm/arm-vfpv3.c: Likewise.
1092         * features/arm/xscale-iwmmxt.c: Likewise.
1093         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1094
1095 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1096
1097         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1098         ptrace earlier.
1099
1100 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1101
1102         * features/aarch64-pauth.c: Regenerate.
1103
1104 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1105
1106         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1107         bool.
1108         (bpstat_what): Use false instead of 0.
1109
1110 2019-07-09  Pedro Alves  <palves@redhat.com>
1111
1112         * break-catch-throw.c (is_exception_catchpoint): New.
1113         * breakpoint.c (print_one_breakpoint_location): New parameter
1114         'raw_loc'.  Handle it.  Use
1115         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1116         looking at the breakpoint's type.
1117         (print_one_breakpoint): If handling "maint info breakpoints", also
1118         print locations of exception catchpoints.
1119         * breakpoint.h (is_exception_catchpoint): Declare.
1120
1121 2019-07-09  Pedro Alves  <palves@redhat.com>
1122
1123         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1124         "addr" field.
1125         (allocate_location_exception_catchpoint): New.
1126         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1127         (initialize_throw_catchpoint_ops): Install
1128         allocate_location_exception_catchpoint as allocate_location
1129         method.
1130         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1131         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1132         bp_loc_other.
1133         (breakpoint_address_is_meaningful): Delete.
1134         (bl_address_is_meaningful): New.
1135         (breakpoint_locations_match): Adjust comment.
1136         (bp_location_from_bp_type): New, factored out of...
1137         (bp_location::bp_location(breakpoint *)): ... this.
1138         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1139         factored out of...
1140         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1141         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1142         breakpoint_address_is_meaningful.
1143         (bp_locations_compare): Adjust comment.
1144         (update_global_location_list): Use bl_address_is_meaningful
1145         instead of breakpoint_address_is_meaningful.
1146         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1147         explicit.
1148         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1149         * python/py-breakpoint.c (bppy_get_location): No longer check
1150         whether location is null.
1151
1152 2019-07-09  Pedro Alves  <palves@redhat.com>
1153
1154         PR c++/15468
1155         * breakpoint.c (print_one_breakpoint_location): Remove
1156         single-location assert.
1157
1158 2019-07-09  Tom Tromey  <tom@tromey.com>
1159
1160         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1161         * configure: Rebuild.
1162         * configure.ac: Change common to gdbsupport.
1163         * gdbsupport: Rename from common.
1164         * acinclude.m4: Change common to gdbsupport.
1165         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1166         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1167         gdbsupport.
1168         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1169         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1170         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1171         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1172         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1173         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1174         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1175         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1176         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1177         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1178         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1179         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1180         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1181         coff-pe-read.c, command.h, compile/compile-c-support.c,
1182         compile/compile-c.h, compile/compile-cplus-symbols.c,
1183         compile/compile-cplus-types.c, compile/compile-cplus.h,
1184         compile/compile-loc2c.c, compile/compile.c, completer.c,
1185         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1186         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1187         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1188         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1189         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1190         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1191         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1192         features/aarch64-core.c, features/aarch64-fpu.c,
1193         features/aarch64-pauth.c, features/aarch64-sve.c,
1194         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1195         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1196         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1197         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1198         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1199         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1200         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1201         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1202         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1203         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1204         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1205         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1206         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1207         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1208         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1209         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1210         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1211         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1212         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1213         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1214         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1215         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1216         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1217         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1218         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1219         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1220         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1221         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1222         minsyms.c, mips-linux-tdep.c, namespace.h,
1223         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1224         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1225         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1226         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1227         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1228         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1229         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1230         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1231         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1232         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1233         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1234         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1235         procfs.c, producer.c, progspace.h, psymtab.h,
1236         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1237         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1238         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1239         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1240         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1241         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1242         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1243         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1244         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1245         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1246         target-memory.c, target.c, target.h, target/waitstatus.c,
1247         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1248         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1249         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1250         unittests/array-view-selftests.c,
1251         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1252         unittests/common-utils-selftests.c,
1253         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1254         unittests/format_pieces-selftests.c,
1255         unittests/function-view-selftests.c,
1256         unittests/lookup_name_info-selftests.c,
1257         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1258         unittests/mkdir-recursive-selftests.c,
1259         unittests/observable-selftests.c,
1260         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1261         unittests/parse-connection-spec-selftests.c,
1262         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1263         unittests/scoped_fd-selftests.c,
1264         unittests/scoped_mmap-selftests.c,
1265         unittests/scoped_restore-selftests.c,
1266         unittests/string_view-selftests.c, unittests/style-selftests.c,
1267         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1268         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1269         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1270         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1271         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1272         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1273
1274 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1275
1276         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1277         bool value.
1278         (decode_digits_ordinary): Set explicit_line field in sal.
1279         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1280         symtab_and_line that was set on an explicit line number in
1281         assembler code.  Do always update the recorded symtab and line if
1282         we do skip the prologue.
1283
1284 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1285
1286         * breakpoint.c (set_breakpoint_location_function): Remove
1287         explicit_loc parameter.
1288         (momentary_breakpoint_from_master): Update call to
1289         set_breakpoint_location_function.
1290         (add_location_to_breakpoint): Likewise.
1291
1292 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1293
1294         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1295         required features based on default bfd type when no specific bfd
1296         is present.
1297
1298 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1299
1300         * NEWS: Mention that GDB printf and eval commands can now print
1301         C-style and Ada-style convenience var strings without
1302         calling the inferior.
1303         * printcmd.c (printf_c_string): Locally print GDB internal var
1304         instead of transiting via the inferior.
1305         (printf_wide_c_string): Likewise.
1306
1307 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1308
1309         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1310
1311 2019-07-04  Tom Tromey  <tom@tromey.com>
1312
1313         PR tui/24724:
1314         * tui/tui-winsource.c (tui_clear_source_content): Update.
1315         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1316         (tui_update_breakpoint_info): Update.
1317         (tui_set_exec_info_content): Update.
1318         * tui/tui-source.c (tui_set_source_content_nil): Update.
1319         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1320         has_break.
1321         * tui/tui-data.h (enum tui_bp_flag): New.
1322         (tui_bp_flags): New enum flags type.
1323         (struct tui_source_element) <break_mode>: Change type.  Rename
1324         from has_break.
1325         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1326         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1327         constants.
1328         * tui/tui-winsource.h: Fix comment.
1329
1330 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1331
1332         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1333         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1334         (store_fpregs_to_thread)
1335         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1336         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1337         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1338         (IWMMXT_REGS_SIZE): Add define.
1339         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1340         (fetch_vfp_regs, store_vfp_regs)
1341         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1342         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1343
1344 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1345
1346         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1347         defines.
1348         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1349         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1350         (ARM_INT_REGISTER_SIZE): ...to this.
1351         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1352         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1353         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1354         (arm_linux_collect_gregset, supply_nwfpe_register)
1355         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1356         defines.
1357         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1358         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1359         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1360         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1361         (arm_return_in_memory, arm_store_return_value)
1362         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1363         (arm_record_ld_st_multiple): Likewise.
1364         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1365         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1366
1367 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1368
1369         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1370         AARCH64_DISPLACED_MODIFIED_INSNS.
1371         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1372         (aarch64_displaced_step_copy_insn): Likewise.
1373         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1374         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1375         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1376         ARM_DISPLACED_MODIFIED_INSNS.
1377         * arm-tdep.c (arm_gdbarch_init): Likewise.
1378         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1379         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1380         (struct arm_displaced_step_closure): Use
1381         ARM_DISPLACED_MODIFIED_INSNS.
1382
1383 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1384
1385         * features/Makefile: Remove unused xml files.
1386         * features/aarch64.xml: Remove.
1387         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1388         * features/i386/amd64-avx-avx512.xml: Remove.
1389         * features/i386/amd64-avx-linux.xml: Remove.
1390         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1391         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1392         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1393         * features/i386/amd64-avx-mpx.xml: Remove.
1394         * features/i386/amd64-avx.xml: Remove.
1395         * features/i386/amd64-linux.xml: Remove.
1396         * features/i386/amd64-mpx-linux.xml: Remove.
1397         * features/i386/amd64-mpx.xml: Remove.
1398         * features/i386/amd64.xml: Remove.
1399         * features/i386/i386-avx-avx512-linux.xml: Remove.
1400         * features/i386/i386-avx-avx512.xml: Remove.
1401         * features/i386/i386-avx-linux.xml: Remove.
1402         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1403         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1404         * features/i386/i386-avx-mpx-linux.xml: Remove.
1405         * features/i386/i386-avx-mpx.xml: Remove.
1406         * features/i386/i386-avx.xml: Remove.
1407         * features/i386/i386-linux.xml: Remove.
1408         * features/i386/i386-mmx-linux.xml: Remove.
1409         * features/i386/i386-mmx.xml: Remove.
1410         * features/i386/i386-mpx-linux.xml: Remove.
1411         * features/i386/i386-mpx.xml: Remove.
1412         * features/i386/i386.xml: Remove.
1413         * features/i386/x32-avx-avx512-linux.xml: Remove.
1414         * features/i386/x32-avx-linux.xml: Remove.
1415         * features/i386/x32-linux.xml: Remove.
1416
1417 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1418
1419         * regformats/aarch64.dat: Remove.
1420         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1421         * regformats/i386/amd64-avx-linux.dat: Remove.
1422         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1423         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1424         * regformats/i386/amd64-linux.dat: Remove.
1425         * regformats/i386/amd64-mpx-linux.dat: Remove.
1426         * regformats/i386/amd64.dat: Remove.
1427         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1428         * regformats/i386/i386-avx-linux.dat: Remove.
1429         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1430         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1431         * regformats/i386/i386-linux.dat: Remove.
1432         * regformats/i386/i386-mmx-linux.dat: Remove.
1433         * regformats/i386/i386-mpx-linux.dat: Remove.
1434         * regformats/i386/i386.dat: Remove.
1435         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1436         * regformats/i386/x32-avx-linux.dat: Remove.
1437         * regformats/i386/x32-linux.dat: Remove.
1438
1439 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1440
1441         * aarch64-tdep.c: Remove xml self tests.
1442         * amd64-linux-tdep.c: Likewise.
1443         * amd64-tdep.c: Likewise.
1444         * i386-linux-tdep.c: Likewise.
1445         * i386-tdep.c: Likewise.
1446
1447 2019-07-03  Pedro Alves  <palves@redhat.com>
1448
1449         PR cli/24732
1450         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1451         (pipe_cmd_option_defs): New.
1452         (make_pipe_cmd_options_def_group): New.
1453         (pipe_command): Use gdb::option::process_options.
1454         (pipe_command_completer): New function.
1455         (_initialize_cli_cmds): Install completer for "pipe" command.
1456
1457 2019-07-03  Pedro Alves  <palves@redhat.com>
1458
1459         * cli/cli-option.c (union option_value) <string>: New field.
1460         (struct option_def_and_value): Add ctor, move ctor, dtor and
1461         use DISABLE_COPY_AND_ASSIGN.
1462         (option_def_and_value::clear_value): New.
1463         (parse_option, save_option_value_in_ctx, get_val_type_str)
1464         (add_setshow_cmds_for_options): Handle var_string.
1465         * cli-option.h (union option_def::var_address) <string>: New
1466         field.
1467         (struct string_option_def): New.
1468         * maint-test-options.c (struct test_options_opts): Add default
1469         ctor and use DISABLE_COPY_AND_ASSIGN.
1470         <string_opt>: New field.
1471         (test_options_opts::~test_options_opts): New.
1472         (test_options_opts::dump): Also dump "-string".
1473         (test_options_option_defs): Install "string.
1474
1475 2019-07-03  Pedro Alves  <palves@redhat.com>
1476
1477         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1478         option_value with a null enumeration.
1479         (complete_options): Save the option values in the context.
1480         (save_option_value_in_ctx): New, factored out from ...
1481         (process_options): ... here.
1482         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1483         of the function.
1484         * maint-test-options.c (test_options_opts::dump): New, factored
1485         out from ...
1486         (maintenance_test_options_command_mode): ... here.
1487         (maintenance_test_options_command_completion_result): Delete.
1488         (maintenance_test_options_command_completion_text): Update
1489         comment.
1490         (maintenance_show_test_options_completion_result): Change
1491         prototype.  Just print
1492         maintenance_test_options_command_completion_text.
1493         (save_completion_result): New.
1494         (maintenance_test_options_completer_mode): Pass options context to
1495         complete_options, and then save a dump.
1496         (_initialize_maint_test_options): Use add_cmd to install "maint
1497         show test-options-completion-result".
1498
1499 2019-07-03  Pedro Alves  <palves@redhat.com>
1500
1501         * NEWS (New commands): Mention "with" and "maint with".
1502         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1503         (with_command, with_command_completer): New.
1504         (pipe_command): Adjust to new repeat_previous
1505         interface.
1506         (_initialize_cli_cmds): Install the "with" command and its "w"
1507         alias.
1508         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1509         declarations.
1510         * cli/cli-setshow.c (parse_cli_var_uinteger)
1511         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1512         argument strings for all var_types.
1513         (get_setshow_command_value_string): New, factored out from ...
1514         (do_show_command): ... this.
1515         * cli/cli-setshow.h: Include <string>.
1516         (get_setshow_command_value_string): Declare.
1517         * command.h (repeat_previous): Now returns const char *.  Adjust
1518         comment.
1519         * maint.c: Include "cli/cli-cmds.h".
1520         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1521         (_initialize_maint_cmds): Register the "maintenance with" command.
1522         * top.c (repeat_previous): Move bits from pipe_command here:
1523         Return the saved command line, if any; error out if there's no
1524         command to relaunch.
1525
1526 2019-07-03  Pedro Alves  <palves@redhat.com>
1527
1528         * NEWS (New commands): Mention "maint set/show test-settings"
1529         instead of "maint test-settings".
1530         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1531         (maintenance_test_settings_set_list): Rename to ...
1532         (maintenance_set_test_settings_list): ... this.
1533         (maintenance_test_settings_show_list): Rename to  ...
1534         (maintenance_show_test_settings_list): ... this.
1535         (maintenance_test_settings_cmd): Delete.
1536         (maintenance_test_settings_set_cmd): ...
1537         (maintenance_set_test_settings_cmd): ... this.
1538         (maintenance_test_settings_show_cmd): ...
1539         (maintenance_show_test_settings_cmd): ... this.
1540         (maintenance_test_settings_show_value_cmd):
1541         (maintenance_show_test_settings_value_cmd): ... this.
1542         (_initialize_maint_test_settings): No longer install the "maint
1543         test-settings" prefix command.  Rename "maint test-settings set"
1544         to "maint set test-settings", and "maint test-settings show" to
1545         "maint show test-settings".  Adjust all subcommands.
1546
1547 2019-07-03  Pedro Alves  <palves@redhat.com>
1548
1549         * maint-test-settings.c: Fix file's intro comment.  Replace all
1550         references to "test-options" with references to "test-settings",
1551         in comments.
1552
1553 2019-07-03  Pedro Alves  <palves@redhat.com>
1554
1555         * maint-test-settings.c (maintenance_test_settings_xxx)
1556         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1557         New.
1558         (maintenance_test_settings_enums): Use them.
1559         (maintenance_test_settings_enum): Default to
1560         maintenance_test_settings_xxx.
1561         (_initialize_maint_test_settings): Initialize
1562         MAINTENANCE_TEST_SETTINGS_FILENAME.
1563
1564 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1565
1566         * breakpoint.h (remove_breakpoints_inf): Change return type to
1567         void, move function documentation here.
1568         * breakpoint.c (remove_breakpoints_inf): Change return type to
1569         void, move function documentation to header.
1570
1571 2019-07-02  Pedro Alves  <palves@redhat.com>
1572
1573         * NEWS (Completion improvements): Mention "info threads".
1574         * thread.c (struct info_threads_opts, info_threads_option_defs)
1575         (make_info_threads_options_def_group): New.
1576         (info_threads_command): Use gdb::option::process_options.
1577         (info_threads_command_completer): New.
1578         (_initialize_thread): Use gdb::option::build_help to build the
1579         help text for "info threads".
1580
1581 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1582
1583         * defs.h (generic_load): Move from here...
1584         * symfile.h (generic_load): ... to here.  Rename name parameter
1585         to args.
1586         * symfile.c (generic_load): Add comment.
1587
1588 2019-07-01  Tom Tromey  <tromey@adacore.com>
1589
1590         * dwarf2read.c
1591         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1592         declaration of without_params.  Fix formatting.
1593
1594 2019-07-01  Tom Tromey  <tromey@adacore.com>
1595
1596         * ada-exp.y (find_primitive_type): Update.
1597         * ada-lang.h (ada_lookup_symbol): Update.
1598         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1599         parameter.
1600         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1601
1602 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1603
1604         PR breakpoints/24541
1605         * gdbarch.c: Regenerate.
1606         * gdbarch.h: Regenerate.
1607         * gdbarch.sh: Add 'stap_adjust_register'.
1608         * i386-tdep.c: Include '<unordered_set>'.
1609         (i386_stap_adjust_register): New function.
1610         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1611         * stap-probe.c (stap_parse_register_operand): Call
1612         'gdbarch_stap_adjust_register'.
1613
1614 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1615
1616         PR python/24742
1617         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1618         * python/python.c (do_start_initialization): Use 'xmalloc'
1619         instead of 'PyMem_Malloc'.
1620
1621 2019-06-28  Tom Tromey  <tromey@adacore.com>
1622
1623         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1624         for Ada.
1625
1626 2019-06-27  Tom Tromey  <tromey@adacore.com>
1627
1628         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1629         objfile_key.
1630         (arm_find_mapping_symbol, arm_record_special_symbol)
1631         (_initialize_arm_tdep): Update.
1632         (arm_objfile_data_free): Remove.
1633
1634 2019-06-27  Tom Tromey  <tromey@adacore.com>
1635
1636         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1637         to cp_print_static_field.
1638
1639 2019-06-26  Tom Tromey  <tromey@adacore.com>
1640
1641         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1642         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1643         declare.
1644
1645 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1646
1647         * features/aarch64-core.c (create_feature_aarch64_core):
1648         Regenerate.
1649         * features/aarch64-core.xml: Add cpsr flags.
1650
1651 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1652
1653         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1654         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1655
1656 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1657
1658         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1659         field.
1660         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1661         use.
1662         (arm_record_special_symbol): Don't insert new symbol in sorted
1663         position, push it at the end.
1664
1665 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1666
1667         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1668         (arm_mapping_symbol_s): Remove.
1669         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1670         (arm_mapping_symbol_vec): New typedef.
1671         (struct arm_per_objfile): Add constructor.
1672         <section_maps>: Change type to
1673         std::unique_ptr<arm_mapping_symbol_vec[]>.
1674         (arm_compare_mapping_symbols): Remove.
1675         (arm_find_mapping_symbol): Adjust to section_maps type change.
1676         (arm_objfile_data_free): Call delete on arm_per_objfile.
1677         (arm_record_special_symbol): Adjust to section_maps type change.
1678         Allocate arm_per_objfile with new.
1679
1680 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1681
1682         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1683         with the command prefix.
1684
1685 2019-06-25  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1688         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1689
1690 2019-06-25  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1693         type.
1694         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1695         protected.
1696
1697 2019-06-25  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-winsource.c
1700         (tui_source_window_base::set_is_exec_point_at): Add check against
1701         LOA_ADDRESS.
1702
1703 2019-06-25  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-source.c (tui_set_source_content): Don't check before
1706         xfree.
1707         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1708
1709 2019-06-25  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-winsource.h (tui_update_source_window_as_is)
1712         (tui_alloc_source_buffer, tui_line_is_displayed)
1713         (tui_addr_is_displayed): Change type of win_info.
1714         * tui/tui-winsource.c (tui_update_source_window_as_is)
1715         (tui_clear_source_content, tui_show_source_line)
1716         (tui_show_source_content, tui_source_window_base::refill)
1717         (tui_source_window_base::set_is_exec_point_at)
1718         (tui_source_window_base::set_is_exec_point_at)
1719         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1720         (tui_alloc_source_buffer, tui_line_is_displayed)
1721         (tui_addr_is_displayed): Change type of win_info.  Update.
1722         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1723         (tui_source_window_base::do_make_visible_with_new_height):
1724         Update.
1725         * tui/tui-source.c (tui_set_source_content)
1726         (tui_set_source_content_nil)
1727         (tui_source_window::do_scroll_vertical): Update.
1728         * tui/tui-layout.c (show_layout): Update.
1729         * tui/tui-disasm.c (tui_set_disassem_content)
1730         (tui_disasm_window::do_scroll_vertical): Update.
1731         * tui/tui-data.h (tui_win_content): Remove.
1732         (struct tui_gen_win_info) <content, content_size>: Remove.
1733         (struct tui_source_element): Add initializers and destructor.
1734         (union tui_which_element, struct tui_win_element): Remove.
1735         (struct tui_source_window_base) <content>: New field.
1736         (struct tui_data_window): Remove destructor.
1737         (tui_alloc_content, tui_free_win_content)
1738         (tui_free_all_source_wins_content): Don't declare.
1739         * tui/tui-data.c (tui_initialize_static_data): Update.
1740         (init_content_element, tui_alloc_content): Remove.
1741         (~tui_gen_win_info): Update.
1742         (~tui_data_window, tui_free_all_source_wins_content)
1743         (tui_free_win_content, free_content, free_content_elements):
1744         Remove.
1745
1746 2019-06-25  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-winsource.h (tui_clear_source_content)
1749         (tui_erase_source_content, tui_show_source_content): Change type
1750         of win_info.
1751         * tui/tui-winsource.c (tui_clear_source_content)
1752         (tui_erase_source_content, tui_show_source_content): Change type
1753         of win_info.
1754         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1755         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1756         win_info.
1757         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1758         win_info.
1759         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1760
1761 2019-06-25  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-winsource.c (tui_clear_source_content)
1764         (tui_source_window_base::set_is_exec_point_at): Update.
1765         * tui/tui-source.c (tui_set_source_content_nil): Update.
1766         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1767         a bool.
1768         * tui/tui-data.c (init_content_element): Update.
1769
1770 2019-06-25  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1773         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1774         * tui/tui-layout.c (init_and_make_win): Update.
1775         * tui/tui.h (enum tui_win_type): Update.
1776         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1777         tui_win_is_auxillary.
1778         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1779         tui_win_is_auxillary.
1780
1781 2019-06-25  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1784         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1785         (tui_delete_data_content_windows, tui_display_all_data)
1786         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1787         Update.
1788         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1789         * tui/tui-regs.c (tui_last_regs_line_no)
1790         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1791         (tui_show_registers): Update.
1792         (tui_show_register_group): Return void.  Update.
1793         (tui_display_registers_from, tui_display_reg_element_at_line)
1794         (tui_display_registers_from_line, tui_check_register_values):
1795         Update.
1796         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1797         member.
1798         (struct tui_data_window) <regs_content>: Now a std::vector.
1799         <regs_content_count>: Remove.
1800         (tui_add_content_elements, tui_free_data_content): Don't declare.
1801         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1802         (init_content_element): Remove DATA_WIN case.  Add assert.
1803         (tui_add_content_elements): Remove.
1804         (tui_data_window): Update.
1805         (tui_free_data_content): Remove.
1806         (free_content_elements): Remove DATA_WIN case.
1807
1808 2019-06-25  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-data.c (tui_data_item_window): Update.
1811         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1812         * tui/tui-windata.c (tui_display_all_data)
1813         (tui_display_data_from_line): Update.
1814         (tui_check_data_values): Remove.
1815         * tui/tui-regs.c (tui_show_register_group)
1816         (tui_display_reg_element_at_line): Update.
1817         * tui/tui-hooks.c (tui_register_changed)
1818         (tui_refresh_frame_and_register_information): Call
1819         tui_check_register_values.
1820         * tui/tui-data.h (struct tui_data_window) <data_content,
1821         data_content_count, data_type>: Remove.
1822         (enum tui_data_type): Remove.
1823
1824         * tui/tui-data.c (tui_data_window::clear_detail)
1825         (~tui_data_window): Update.
1826
1827 2019-06-25  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1830         declare.
1831         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1832         Rename from tui_first_data_item_displayed.  Update.
1833         (tui_data_window::refresh_all)
1834         (tui_data_window::do_scroll_vertical): Update.
1835         * tui/tui-data.h (struct tui_data_window)
1836         <first_data_item_displayed>: Declare new method.
1837
1838 2019-06-25  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1841         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1842         contents...
1843         (tui_initialize_static_data): ...here.
1844
1845 2019-06-25  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1848         (tui_display_registers_from, tui_check_register_values): Update.
1849         (tui_display_register): Remove win_info parameter; update.
1850         (tui_get_register): Change type of parameters.
1851         * tui/tui-data.h (struct tui_data_element): Remove.
1852         (union tui_which_element) <data>: Remove.
1853         <data_window>: Change type.
1854         (struct tui_data_item_window): New.
1855         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1856         case.  Add assert.
1857         (~tui_data_item_window): New destructor.
1858         (free_content_elements): Remove DATA_ITEM_WIN case.
1859
1860 2019-06-25  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1863         Remove.
1864
1865 2019-06-25  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-data.h (struct tui_command_element): Remove.
1868         (union tui_which_element) <command>: Remove.
1869         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1870         assert.
1871         (free_content_elements): Remove CMD_WIN case.
1872
1873 2019-06-25  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-layout.c (tui_set_layout): Update.
1876         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1877         * tui/tui-data.c (layout_def): Update.
1878
1879 2019-06-25  Tom Tromey  <tom@tromey.com>
1880
1881         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1882         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1883         (tui_source_window_base::set_new_height): Update.
1884         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1885         Update.
1886         (tui_set_locator_fullname, tui_set_locator_info)
1887         (tui_show_frame_info): Update.
1888         * tui/tui-source.c (tui_set_source_content)
1889         (tui_source_is_displayed): Update.
1890         * tui/tui-layout.c (show_source_disasm_command, show_data)
1891         (show_source_or_disasm_and_command): Update.
1892         * tui/tui-disasm.c (tui_set_disassem_content)
1893         (tui_get_begin_asm_address): Update.
1894         * tui/tui-data.h (struct tui_locator_element): Remove.
1895         (union tui_which_element) <locator>: Remove.
1896         (struct tui_locator_window): New.
1897         (tui_locator_win_info_ptr): Change return type.
1898         * tui/tui-data.c (_locator): Change type.
1899         (tui_locator_win_info_ptr): Change return type.
1900         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1901         (tui_alloc_content): Add assert.
1902
1903 2019-06-25  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-winsource.c
1906         (tui_exec_info_window::maybe_allocate_content): New method.
1907         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1908         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1909         (make_source_or_disasm_window): Add cast.
1910         * tui/tui-data.h (union tui_which_element) <simple_string>:
1911         Remove.
1912         (struct tui_source_info): New.
1913         (struct tui_source_window_base) <execution_info>: Change type.
1914         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1915         case, and add assert.
1916         (tui_alloc_content): Add assert.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1921         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1922         * tui/tui-data.c (tui_alloc_win_info): Remove.
1923
1924 2019-06-25  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1927         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1928         can_highlight.
1929
1930 2019-06-25  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1933         make_visible_with_new_height method.
1934         (tui_win_info::make_visible_with_new_height): New method.
1935         (tui_source_window_base::do_make_visible_with_new_height)
1936         (tui_data_window::do_make_visible_with_new_height)
1937         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1938         (make_visible_with_new_height): Remove.
1939         (tui_resize_all, tui_adjust_win_heights): Use
1940         make_visible_with_new_height method.
1941         * tui/tui-data.h (struct tui_win_info)
1942         <do_make_visible_with_new_height, make_visible_with_new_height>:
1943         New methods.
1944         (struct tui_source_window_base, struct tui_data_window)
1945         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1946         methods.
1947
1948 2019-06-25  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1951         method.
1952         (update_tab_width): Call update_tab_width method.
1953         * tui/tui-data.h (struct tui_win_info)
1954         (struct tui_source_window_base) <update_tab_width>: New methods.
1955
1956 2019-06-25  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1959         parameter.
1960         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1961         parameter.
1962         (tui_gen_win_info::make_visible): Update.
1963         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1964         parameter.
1965         * tui/tui-data.h (enum tui_box): New enum.
1966         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1967
1968 2019-06-25  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1971         init_and_make_win for EXEC_INFO_WIN.
1972         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1973         longer inline.
1974         (struct tui_win_info) <~tui_win_info>: Inline.
1975         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1976         Don't declare.
1977         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1978         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1979         Remove.
1980         (tui_initialize_static_data): Update.
1981         (~tui_gen_win_info): Handle more cleanup here.
1982         (~tui_source_window_base): Delete "execution_info".
1983         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-layout.c (make_command_window): Don't set
1988         can_highlight.
1989         (show_source_disasm_command): Call the reset method.
1990         (show_data): Don't set can_highlight.  Call the reset method.
1991         (tui_gen_win_info::reset): Rename from init_gen_win_info
1992         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1993         (show_source_or_disasm_and_command): Call the reset method.
1994         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1995         (struct tui_cmd_window): Set can_highlight.
1996
1997 2019-06-25  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2000         from make_visible.
2001         (tui_make_visible, tui_make_invisible): Rewrite.
2002         (tui_win_info::make_visible): Remove.
2003         (tui_source_window_base::make_visible): Update.
2004         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2005         method.  Moved from...
2006         (struct tui_win_info) <make_visible>: ...here.
2007
2008 2019-06-25  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-winsource.c
2011         (tui_source_window_base::do_scroll_horizontal): Remove direction
2012         parameter.
2013         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2014         direction parameter.
2015         * tui/tui-win.c (tui_win_info::forward_scroll)
2016         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2017         (tui_win_info::right_scroll): Update.
2018         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2019         direction parameter.
2020         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2021         direction parameter.
2022         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2023         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2024         Remove direction parameter.
2025         (struct tui_source_window_base, struct tui_source_window)
2026         (struct tui_disasm_window, struct tui_data_window)
2027         (struct tui_cmd_window): Update.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-winsource.h (tui_set_exec_info_content)
2032         (tui_show_exec_info_content, tui_erase_exec_info_content)
2033         (tui_clear_exec_info_content, tui_update_exec_info): Change
2034         argument to tui_source_window_base.
2035         * tui/tui-winsource.c (tui_set_exec_info_content)
2036         (tui_show_exec_info_content, tui_erase_exec_info_content)
2037         (tui_clear_exec_info_content, tui_update_exec_info): Change
2038         argument to tui_source_window_base.
2039
2040 2019-06-25  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2043         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2044
2045 2019-06-25  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2048         check.
2049
2050 2019-06-25  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2053         type to void.
2054         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2055         type to void.
2056         * tui/tui-source.c (tui_set_source_content): Update.
2057         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2058
2059 2019-06-25  Tom Tromey  <tom@tromey.com>
2060
2061         * tui/tui-win.c (window_name_completer, tui_set_focus)
2062         (tui_all_windows_info): Use name method.
2063         * tui/tui-data.h (struct tui_gen_win_info)
2064         (struct tui_source_window, struct tui_disasm_window)
2065         (struct tui_data_window, struct tui_cmd_window) <name>: New
2066         method.
2067         (tui_win_name): Don't declare.
2068         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2069         (tui_win_name): Remove.
2070
2071 2019-06-25  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-winsource.h (tui_update_source_window)
2074         (tui_update_source_window_as_is): Change parameter type.
2075         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2076         to be a tui_source_window_base.
2077         (tui_update_source_window_as_is): Likewise.
2078         * tui/tui-win.c (make_visible_with_new_height): Update.
2079
2080 2019-06-25  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-winsource.c (tui_erase_source_content)
2083         (tui_show_source_content, tui_show_exec_info_content)
2084         (tui_erase_exec_info_content): Use refresh_window method.
2085         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2086         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2087         from tui_refresh_win.
2088         (tui_data_window::refresh_window): New method.
2089         (tui_win_info::refresh, tui_source_window_base::refresh)
2090         (tui_refresh_all): Use refresh_window method.
2091         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2092         method.
2093         * tui/tui-regs.c (tui_display_register): Call refresh_window
2094         method.
2095         * tui/tui-layout.c (show_source_disasm_command)
2096         (show_source_or_disasm_and_command): Call refresh_window method.
2097         * tui/tui-data.h (struct tui_gen_win_info)
2098         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2099         New method.
2100
2101 2019-06-25  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui.c (tui_rl_other_window, tui_enable)
2104         (tui_is_window_visible, tui_get_command_dimension): Update.
2105         * tui/tui-winsource.c (tui_update_source_window_as_is)
2106         (tui_clear_source_content, tui_erase_source_content)
2107         (tui_show_source_line, tui_source_window_base::refill)
2108         (tui_source_window_base::do_scroll_horizontal)
2109         (tui_source_window_base::set_is_exec_point_at)
2110         (tui_update_breakpoint_info, tui_set_exec_info_content)
2111         (tui_alloc_source_buffer, tui_line_is_displayed)
2112         (tui_addr_is_displayed): Update.
2113         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2114         (tui_check_and_display_highlight_if_needed)
2115         (tui_win_info::make_visible, tui_win_info::refresh)
2116         (tui_refresh_all): Update.
2117         * tui/tui-windata.c (tui_first_data_item_displayed)
2118         (tui_delete_data_content_windows, tui_erase_data_content)
2119         (tui_display_all_data, tui_data_window::refresh_all)
2120         (tui_check_data_values): Update.
2121         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2122         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2123         (tui_win_info::backward_scroll, tui_refresh_all_win)
2124         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2125         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2126         (tui_source_window_base::set_new_height)
2127         (tui_data_window::set_new_height)
2128         (make_invisible_and_set_new_height)
2129         (make_visible_with_new_height, new_height_ok)
2130         (parse_scrolling_args): Update.
2131         * tui/tui-stack.c (tui_show_frame_info): Update.
2132         * tui/tui-source.c (tui_set_source_content)
2133         (tui_set_source_content_nil, tui_source_is_displayed)
2134         (tui_source_window::do_scroll_vertical): Update.
2135         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2136         (tui_display_registers_from, tui_display_reg_element_at_line)
2137         (tui_check_register_values, tui_reg_command): Update.
2138         * tui/tui-layout.c (tui_default_win_height)
2139         (show_source_disasm_command, show_data, init_and_make_win)
2140         (show_source_or_disasm_and_command): Update.
2141         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2142         (tui_redisplay_readline, tui_mld_flush)
2143         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2144         (tui_getc): Update.
2145         * tui/tui-disasm.c (tui_set_disassem_content)
2146         (tui_disasm_window::do_scroll_vertical): Update.
2147         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2148         Now virtual.
2149         (struct tui_win_info): Derive from tui_gen_win_info.
2150         <~tui_win_info>: Mark as override.
2151         <generic>: Remove member.
2152         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2153         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2154         (~tui_data_window, ~tui_win_info)
2155         (tui_free_all_source_wins_content): Update.
2156         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2157
2158 2019-06-25  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-layout.c (init_and_make_win): Use new.
2161         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2162         destructor, initializers.
2163         (tui_alloc_generic_win_info): Don't declare.
2164         * tui/tui-data.c (_locator): Add argument to constructor.
2165         (source_win, disasm_win): New globals.
2166         (exec_info): Remove.
2167         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2168         Update.
2169         (tui_alloc_generic_win_info): Remove.
2170         (init_content_element): Use new.
2171         (tui_win_info::tui_win_info): Update.
2172         (free_content_elements) <case DATA_WIN>: Use delete.
2173
2174 2019-06-25  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2177         * tui/tui-windata.c (tui_first_data_item_displayed)
2178         (tui_delete_data_content_windows): Update.
2179         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2180         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2181         (tui_display_registers_from, tui_check_register_values): Update.
2182         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2183         pointer.
2184         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2185         window.
2186         (tui_free_data_content): Update.
2187         (free_content_elements) <case DATA_WIN>: Free the window.
2188
2189 2019-06-25  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2192         Update.
2193         * tui/tui-layout.c (make_command_window)
2194         (show_source_disasm_command, show_data, init_and_make_win)
2195         (show_source_or_disasm_and_command): Update.
2196         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2197         method.
2198         <can_highight, is_highlighted>: Now bool.
2199         (tui_set_win_highlight): Don't declare.
2200         * tui/tui-data.c (tui_set_win_highlight): Remove.
2201
2202 2019-06-25  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-wingeneral.c (make_visible): Remove check of window
2205         type.
2206
2207 2019-06-25  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui-win.c (tui_win_info::max_height)
2210         (tui_cmd_window::max_height): New methods.
2211         (new_height_ok): Call max_height.
2212         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2213         <max_height>: New method.
2214
2215 2019-06-25  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-win.c (tui_source_window_base::set_new_height)
2218         (tui_data_window::set_new_height): New methods.
2219         (make_invisible_and_set_new_height): Call set_new_height method.
2220         * tui/tui-data.h (struct tui_win_info)
2221         (struct tui_source_window_base, struct tui_data_window)
2222         <set_new_height>: New method.
2223
2224 2019-06-25  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2227         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2228         tui_refresh_data_win.
2229         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2230         method.
2231         (tui_refresh_all_win): Call the refresh_all method.
2232         (tui_set_focus): Likewise.
2233         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2234         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2235         Likewise.
2236
2237 2019-06-25  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-winsource.h (tui_refill_source_window)
2240         (tui_set_is_exec_point_at): Don't declare.
2241         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2242         (tui_source_window_base::refill): Rename from
2243         tui_refill_source_window.
2244         (tui_source_window_base::do_scroll_horizontal): Update.
2245         (tui_source_window_base::set_is_exec_point_at): Rename from
2246         tui_set_is_exec_point_at.
2247         (tui_update_all_breakpoint_info): Update.
2248         * tui/tui-stack.c (tui_show_frame_info): Update.
2249         * tui/tui-layout.c (show_data): Add cast.
2250         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2251         * tui/tui-data.h (struct tui_source_window_base) <refill,
2252         set_is_exec_point_at>: New methods.
2253         (tui_source_windows, tui_add_to_source_windows): Update types.
2254         (tui_add_to_source_windows): Remove redundant declaration.
2255         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2256         (tui_source_windows): Change return type.
2257         (tui_clear_source_windows_detail): Update.
2258         (tui_add_to_source_windows): Change type of parameter.
2259         (tui_free_all_source_wins_content): Update.
2260
2261 2019-06-25  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-wingeneral.c (tui_win_info::refresh)
2264         (tui_source_window_base::refresh): New methods.
2265         (tui_refresh_all): Call the refresh method.
2266         * tui/tui-data.h (struct tui_win_info)
2267         (struct tui_source_window_base) <refresh>: New method.
2268
2269 2019-06-25  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui.h (tui_is_window_visible): Return bool.
2272         * tui/tui.c (tui_is_window_visible): Return bool.
2273         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2274         (tui_make_visible, tui_make_invisible)
2275         (tui_win_info::make_visible)
2276         (tui_source_window_base::make_visible, make_all_visible)
2277         (tui_make_all_visible, tui_make_all_invisible): Update.
2278         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2279         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2280         bool.
2281         (struct tui_win_info, struct tui_source_window_base)
2282         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2283         * tui/tui-data.c (tui_init_generic_part): Update.
2284
2285 2019-06-25  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2288         (tui_source_window_base::make_visible): New methods.
2289         (make_all_visible): Make method call.
2290         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2291         (struct tui_source_window_base, struct tui_cmd_window): Override
2292         make_visible.
2293         (tui_win_is_source_type): Don't declare.
2294         * tui/tui-data.c (tui_win_is_source_type): Remove.
2295
2296 2019-06-25  Tom Tromey  <tom@tromey.com>
2297
2298         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2299         NULL check.
2300
2301 2019-06-25  Tom Tromey  <tom@tromey.com>
2302
2303         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2304         Inline constructor.  Add initializers for members.
2305         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2306         constructors; now inline in class.
2307
2308 2019-06-25  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-regs.c (tui_show_registers): Update.
2311         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2312         bool.
2313         * tui/tui-data.c (tui_data_window::clear_detail)
2314         (tui_data_window): Update.
2315
2316 2019-06-25  Tom Tromey  <tom@tromey.com>
2317
2318         * tui/tui-windata.c (tui_display_all_data)
2319         (tui_display_data_from_line, tui_display_data_from)
2320         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2321         Update.
2322         * tui/tui-regs.c (tui_last_regs_line_no)
2323         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2324         (tui_show_registers, tui_show_register_group)
2325         (tui_display_registers_from, tui_display_reg_element_at_line)
2326         (tui_display_registers_from_line, tui_check_register_values)
2327         (tui_reg_next, tui_reg_prev): Update.
2328         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2329         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2330         tui_data_window.
2331         (struct tui_win_info) <detail>: Remove.  Add new fields from
2332         tui_data_info.
2333         (TUI_DATA_WIN): Add cast.
2334         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2335         (~tui_data_window): Simplify.
2336
2337 2019-06-25  Tom Tromey  <tom@tromey.com>
2338
2339         * tui/tui-layout.c (show_source_disasm_command)
2340         (show_source_or_disasm_and_command): Update.
2341         * tui/tui-io.c (update_cmdwin_start_line)
2342         (tui_redisplay_readline): Update.
2343         * tui/tui-data.h (struct tui_command_info): Remove.
2344         (struct tui_win_info) <detail>: Remove command_info member.
2345         (struct tui_data_window) <start_line>: New member, from
2346         tui_command_info.
2347         (TUI_CMD_WIN): Add casts.
2348
2349 2019-06-25  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-winsource.c (tui_update_source_window)
2352         (tui_refill_source_window)
2353         (tui_source_window_base::do_scroll_horizontal)
2354         (tui_update_breakpoint_info, tui_set_exec_info_content)
2355         (tui_show_exec_info_content, tui_erase_exec_info_content)
2356         (tui_clear_exec_info_content): Update.
2357         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2358         Update.
2359         * tui/tui-win.c (make_invisible_and_set_new_height)
2360         (make_visible_with_new_height): Update.
2361         * tui/tui-source.c (tui_set_source_content)
2362         (tui_show_symtab_source): Update.
2363         * tui/tui-layout.c (extract_display_start_addr)
2364         (show_source_disasm_command, show_data)
2365         (make_source_or_disasm_window)
2366         (show_source_or_disasm_and_command): Update.
2367         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2368         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2369         "gdbarch".
2370         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2371         to tui_source_window_base.
2372         (struct tui_win_info) <detail>: Remove source_info member.
2373         (struct tui_source_window_base) <has_locator>: Inline.
2374         Move contents from tui_source_info; rename has_locator member to
2375         m_has_locator.
2376         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2377         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2378         header file.
2379         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2380         Simplify.
2381         (tui_free_all_source_wins_content): Cast to
2382         tui_source_window_base.
2383
2384 2019-06-25  Tom Tromey  <tom@tromey.com>
2385
2386         * tui/tui-win.c (make_invisible_and_set_new_height)
2387         (make_visible_with_new_height): Call has_locator method.
2388         * tui/tui-layout.c (show_source_disasm_command, show_data)
2389         (show_source_or_disasm_and_command): Update for bool change.
2390         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2391         (tui_win_info) <has_locator>: New method.
2392         (struct tui_source_window_base) <has_locator>: New method.
2393         (tui_win_has_locator): Don't declare.
2394         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2395         from tui_win_has_locator.
2396         (tui_source_window_base): Use false, not FALSE.
2397
2398 2019-06-25  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2401         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2402         clear_detail method directly.
2403         (tui_clear_win_detail): Remove.
2404
2405 2019-06-25  Tom Tromey  <tom@tromey.com>
2406
2407         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2408         "this", not TUI_DISASM_WIN.
2409
2410 2019-06-25  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2413         declare.
2414         * tui/tui-winsource.c
2415         (tui_source_window_base::do_scroll_horizontal): Rename from
2416         tui_horizontal_source_scroll.
2417         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2418         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2419         from tui_vertical_data_scroll.
2420         * tui/tui-win.h (tui_scroll): Don't declare.
2421         * tui/tui-win.c (tui_win_info::forward_scroll)
2422         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2423         (tui_win_info::right_scroll): Rename and update.
2424         (tui_scroll_forward_command, tui_scroll_backward_command)
2425         (tui_scroll_left_command, tui_scroll_right_command): Update.
2426         (tui_scroll): Remove.
2427         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2428         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2429         from tui_vertical_source_scroll.
2430         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2431         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2432         from tui_vertical_disassem_scroll.
2433         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2434         do_scroll_horizontal>: New methods.
2435         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2436         Likewise.
2437         (struct tui_source_window_base): Add do_scroll_horizontal.
2438         (struct tui_source_window, struct tui_disasm_window): Add
2439         do_scroll_vertical.
2440         (struct tui_data_window, struct tui_cmd_window): Add
2441         do_scroll_horizontal and do_scroll_vertical.
2442         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2443
2444 2019-06-25  Tom Tromey  <tom@tromey.com>
2445
2446         * tui/tui-data.h (struct tui_source_window_base): New struct.
2447         (struct tui_source_window): Derive from tui_source_window_base.
2448         (struct tui_disasm_window): New struct.
2449         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2450         from tui_source_window::clear_detail.
2451         (tui_source_window_base): Rename from tui_source_window.
2452         (~tui_source_window_base): Rename from ~tui_source_window.
2453         (tui_alloc_win_info): Create a tui_disasm_window.
2454
2455 2019-06-25  Tom Tromey  <tom@tromey.com>
2456
2457         * tui/tui-data.h (struct tui_source_window)
2458         (struct tui_data_window): Declare destructors.
2459         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2460         destructors.
2461         (tui_win_info): Simplify.
2462
2463 2019-06-25  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-winsource.c (tui_display_main)
2466         (tui_update_source_windows_with_addr)
2467         (tui_update_all_breakpoint_info): Update.
2468         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2469         (new_height_ok, parse_scrolling_args): Update.
2470         * tui/tui-stack.c (tui_show_frame_info): Update.
2471         * tui/tui-data.h (struct tui_list): Remove.
2472         (tui_source_windows): Return a reference to a std::vector.
2473         * tui/tui-data.c (source_windows): Now a std::vector.
2474         (tui_source_windows): Change return type.
2475         (tui_clear_source_windows): Rewrite.
2476         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2477         (tui_free_all_source_wins_content): Rewrite.
2478
2479 2019-06-25  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2482         (struct tui_data_window, struct tui_cmd_window): Declare
2483         clear_detail method.
2484         * tui/tui-data.c (tui_source_window::clear_detail)
2485         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2486         methods.
2487         (tui_clear_win_detail): Simplify.
2488
2489 2019-06-25  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-layout.c (make_source_window, make_disasm_window)
2492         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2493         Return the new window.
2494         (show_source_disasm_command, show_data)
2495         (show_source_or_disasm_and_command): Update.
2496
2497 2019-06-25  Tom Tromey  <tom@tromey.com>
2498
2499         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2500         parameter.  Return the new window.
2501         (show_source_disasm_command): Update and remove NULL check.
2502         (show_source_or_disasm_and_command): Update.
2503
2504 2019-06-25  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2507
2508 2019-06-25  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-data.h (struct tui_win_info): Make constructor
2511         protected.  Make destructor virtual.  Add initializers.
2512         (tui_source_window, tui_data_window, tui_cmd_window): New
2513         classes.
2514         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2515         constructor.  Add "type" parameter.
2516         (tui_source_window, tui_data_window, tui_cmd_window): New
2517         constructors.
2518         (tui_alloc_win_info): Instantiate the appropriate subclass.
2519
2520 2019-06-25  Tom Tromey  <tom@tromey.com>
2521
2522         * tui/tui-win.c (tui_resize_all): Use delete.
2523         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2524         destructor.
2525         (tui_free_window): Don't declare.
2526         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2527         Update.
2528
2529 2019-06-25  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-data.h (struct tui_win_info): Add constructor.
2532         * tui/tui-data.c (tui_alloc_win_info): Use new.
2533         (tui_free_window): Use delete.
2534
2535 2019-06-22  Tom Tromey  <tom@tromey.com>
2536
2537         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2538         declare.
2539         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2540
2541 2019-06-22  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2544         declare.
2545         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2546
2547 2019-06-22  Tom de Vries  <tdevries@suse.de>
2548
2549         * dwarf2read.c (create_addrmap_from_aranges)
2550         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2551         instead of '%zu'.
2552
2553 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2554
2555         * dwarf2read.h (dwarf2_section_info_def): Remove.
2556         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2557         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2558         std::vector<dwarf2_section_info>.
2559         (struct dwo_file) <~dwo_file>: Remove.
2560         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2561         types field.
2562         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2563         (dwarf2_read_debug_names): Likewise.
2564         (create_debug_types_hash_table): Change parameter type to
2565         array_view, adjust code accordingly.
2566         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2567         (partial_die_info::fixup): Likewise.
2568         (determine_prefix): Likewise.
2569         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2570
2571 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2572
2573         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2574         gdb_bfd_ref_ptr.
2575         <~dwo_file>: Remove call to gdb_bfd_unref.
2576         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2577         gdb_bfd_ref_ptr::get.
2578
2579 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2580
2581         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2582         type to htab_up.
2583         * dwarf2read.c (struct dwo_file): Initialize fields.
2584         <~dwo_file>: New.
2585         (free_dwo_file): Remove, move content to ~dwo_file.
2586         (struct dwo_file_deleter): Remove.
2587         (dwo_file_up>: Remove custom deleter.
2588         (free_dwo_files): Remove.
2589         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2590         dwo_files.
2591         (process_skeletonless_type_units): Call unique_ptr::get.
2592         (allocate_dwo_file_hash_table): Add deleter to created hash
2593         table.  Change return type to htab_up.
2594         (lookup_dwo_file_slot): Don't memset dwo_file, call
2595         unique_ptr::get.
2596         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2597         (create_dwo_unit_in_dwp_v2): Likewise.
2598         (open_and_init_dwo_file): Likewise.
2599         (free_dwo_file_from_slot): Remove.
2600
2601 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2602
2603         * dwarf2read.h (struct dwarf2_section_info) <readin,
2604         is_virtual>: Change type to bool.
2605         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2606         true instead of 1.
2607
2608 2019-06-19  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-data.h (tui_init_content_element): Don't declare.
2611
2612 2019-06-19  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-data.h (tui_init_win_info): Don't declare.
2615
2616 2019-06-19  Tom de Vries  <tdevries@suse.de>
2617
2618         * dwarf2read.h (abstract_to_concrete): Change type to
2619         std::unordered_map<sect_offset, std::vector<sect_offset>,
2620         gdb::hash_enum<sect_offset>>.
2621
2622 2019-06-19  Tom Tromey  <tromey@adacore.com>
2623
2624         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2625         EVAL_AVOID_SIDE_EFFECTS specially.
2626
2627 2019-06-19  Tom Tromey  <tromey@adacore.com>
2628
2629         * source-cache.c (highlighter): New global.
2630         (source_cache::get_source_lines): Create a highlighter on demand.
2631
2632 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2633
2634         * defs.h (deprecated_interactive_hook): Delete declaration.
2635         * interps.c (clear_interpreter_hooks): Remove use of
2636         deprecated_interactive_hook.
2637         * top.c (deprecated_interactive_hook): Delete definition.
2638         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2639
2640 2019-06-18  Tom de Vries  <tdevries@suse.de>
2641
2642         PR gdb/24515
2643         * dwarf2read.h (abstract_to_concrete): Change type from
2644         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2645         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2646         * dwarf2read.c (read_variable): Update.
2647         (dwarf2_fetch_die_loc_sect_off): Update.
2648
2649 2019-06-17  Tom de Vries  <tdevries@suse.de>
2650
2651         PR gdb/24617
2652         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2653         accessing parent[parent_len - 1].
2654
2655 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2656
2657         PR gdb/24364
2658         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2659         call dtrace_process_dof with NULL dof.
2660
2661 2019-06-16  Tom de Vries  <tdevries@suse.de>
2662
2663         PR gdb/24445
2664         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2665
2666 2019-06-16  Tom Tromey  <tom@tromey.com>
2667
2668         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2669         (make_all_visible): Use address of member.
2670
2671 2019-06-16  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2674         (tui_free_window, free_content, free_content_elements): Remove
2675         unnecessary cast.
2676         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2677         cast.
2678         * tui/tui-regs.c (tui_show_register_group)
2679         (tui_display_registers_from, tui_display_reg_element_at_line):
2680         Remove unnecessary cast.
2681
2682 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2683
2684         * linux-nat.c (normal_mask): Delete.
2685         (_initialize_linux_nat): Don't initialise normal_mask.
2686
2687 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2688
2689         PR gdb/24445
2690         * dwarf-index-write.h (write_psymtabs_to_index): Add
2691         dwz_basename parameter.
2692         * dwarf-index-write.c (write_gdbindex): Move file writing to
2693         write_gdbindex_1.  Change return type void.
2694         (assert_file_size): Move up, remove filename parameter.
2695         (write_gdbindex_1): New function.
2696         (write_debug_names): Change return type to void, call
2697         assert_file_size.
2698         (struct index_wip_file): New struct.
2699         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2700         file logic to index_wip_file.  Write index for dwz file if
2701         needed.
2702         (save_gdb_index_command): Pass basename of dwz file, if present.
2703         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2704         build-id of dwz file, if present.
2705         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2706         (dwarf2_get_dwz_file): Likewise.
2707         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2708         (dwarf2_get_dwz_file): Likewise.
2709
2710 2019-06-16  Tom Tromey  <tom@tromey.com>
2711
2712         * coffread.c (process_coff_symbol): Use xstrdup.
2713         * value.c (create_internalvar): Use xstrdup.
2714
2715 2019-06-16  Tom Tromey  <tom@tromey.com>
2716
2717         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2718         * breakpoint.c (stopin_command, stopat_command)
2719         (until_break_command, decode_location_default): Remove unnecessary
2720         cast.
2721         * utils.c (subset_compare): Remove unnecessary cast.
2722         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2723         cast.
2724         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2725         cast.
2726         * infcmd.c (path_command): Remove unnecessary cast.
2727         * coffread.c (decode_type): Remove unnecessary cast.
2728         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2729         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2730         * tui/tui-stack.c (tui_show_locator_content)
2731         (tui_show_frame_info): Remove unnecessary cast.
2732         * tui/tui-win.c (tui_scroll_forward_command)
2733         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2734         (parse_scrolling_args): Remove unnecessary cast.
2735         * tui/tui-data.c (init_win_info, tui_del_window)
2736         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2737         (free_content_elements): Remove unnecessary cast.
2738         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2739         unnecessary cast.
2740         * tui/tui-source.c (tui_set_source_content)
2741         (tui_vertical_source_scroll): Remove unnecessary cast.
2742         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2743         cast.
2744         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2745         * tui/tui-regs.c (tui_display_registers_from)
2746         (tui_display_register): Remove unnecessary cast.
2747         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2748         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2749         (make_visible): Remove unnecessary cast.
2750         * tui/tui-winsource.c (tui_erase_source_content)
2751         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2752         unnecessary cast.
2753         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2754         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2755         * stabsread.c (read_type, read_array_type, read_range_type):
2756         Remove unnecessary cast.
2757         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2758         (parse_symbol, parse_type, upgrade_type, parse_external)
2759         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2760         unnecessary cast.
2761         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2762
2763 2019-06-16  Tom Tromey  <tom@tromey.com>
2764
2765         * tui/tui-data.c (tui_alloc_generic_win_info)
2766         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2767         checks.
2768
2769 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2770             Andrew Burgess  <andrew.burgess@embecosm.com>
2771
2772         * f-typeprint.c (f_print_type): Don't return early for not
2773         associated or not allocated types.
2774         (f_type_print_varspec_suffix): Add print_rank parameter and print
2775         ranks of array types in case they dangling.
2776         (f_type_print_base): Add print_rank parameter.
2777
2778 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2779
2780         * NEWS: Mention new MI commands.
2781         * break-catch-throw.c (enum exception_event_kind): Move to
2782         breakpoint.h.
2783         (print_mention_exception_catchpoint): Output text as a single
2784         message.
2785         (catch_exception_command_1): Rename to...
2786         (catch_exception_event): ...this, make non-static, update header
2787         command, and change some parameter types.
2788         (catch_catch_command): Update for changes to
2789         catch_exception_command_1.
2790         (catch_throw_command): Likewise.
2791         (catch_rethrow_command): Likewise.
2792         * breakpoint.c (enum exception_event_kind): Delete.
2793         * breakpoint.h (enum exception_event_kind): Moved here from
2794         break-catch-throw.c.
2795         (catch_exception_event): Declare.
2796         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2797         (mi_cmd_catch_throw): New function.
2798         (mi_cmd_catch_rethrow): New function.
2799         (mi_cmd_catch_catch): New function.
2800         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2801         'catch-catch' entries.
2802         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2803         (mi_cmd_catch_rethrow): Declare.
2804         (mi_cmd_catch_catch): Declare.
2805
2806 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2807
2808         * annotate.c (annotate_source_line): Change return type to void,
2809         update implementation to match.
2810         * annotate.h (annotate_source_line): Change return type to void,
2811         update header comment.
2812         * stack.c (print_frame_info): Don't change what frame information
2813         is printed based on whether annotations are on or not.
2814
2815 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2816
2817         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2818         (annotate_source): Make static.
2819         (annotate_source_line): Moved from source.c and renamed from
2820         identify_source_line.  Update the return type.
2821         * annotate.h (annotate_source): Delete declaration.
2822         (annotate_source_line): Declaration moved from source.h, and
2823         renamed from identify_source_line.  Return type updated.
2824         * source.c (identify_source_line): Moved to annotate.c and renamed
2825         to annotate_source_line.
2826         (info_line_command): Remove check of annotation_level.
2827         * source.h (identify_source_line): Move declaration to annotate.h
2828         and rename to annotate_source_line.
2829         * stack.c: Add 'annotate.h' include.
2830         (print_frame_info): Remove check of annotation_level before
2831         calling annotate_source_line.
2832
2833 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2834
2835         * source-cache.c (source_cache::get_plain_source_lines): Use
2836         open_source_file_with_line_charpos instead of just
2837         open_source_file, remove call to find_source_lines.
2838         (source_cache::get_source_lines): Likewise.
2839         * source.c (find_source_lines): Make static.
2840         (get_filename_and_charpos): Renamed into...
2841         (open_source_file_with_line_charpos): ..this along with changes to
2842         return a scoped_fd, and some other minor clean ups.
2843         (identify_source_line): Use open_source_file_with_line_charpos.
2844         (search_command_helper): Use open_source_file_with_line_charpos
2845         instead of just open_source_file, remove call to
2846         find_source_lines.
2847         * source.h (open_source_file_with_line_charpos): Declare new
2848         function.
2849         (find_source_lines): Delete declaration.
2850
2851 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2852
2853         * source.c (get_filename_and_charpos): Remove fullname
2854         parameter.
2855         (identify_source_line): Update call to get_filename_and_charpos.
2856
2857 2019-06-14  Tom Tromey  <tromey@adacore.com>
2858
2859         PR gdb/24502:
2860         * ui-style.h (skip_ansi_escape): Update comment.
2861         * ui-file.h (class no_terminal_escape_file): New class.
2862         * ui-file.c (no_terminal_escape_file::write)
2863         (no_terminal_escape_file::puts): New methods.
2864         * cli/cli-logging.c (handle_redirections): Use
2865         no_terminal_escape_file.
2866
2867 2019-06-14  Tom Tromey  <tromey@adacore.com>
2868
2869         * NEWS: Move convenience variable news above Python news.
2870
2871 2019-06-14  Tom Tromey  <tom@tromey.com>
2872
2873         * gnulib: Move directory to top-level.
2874         * configure.ac: Don't configure gnulib.
2875         * configure: Rebuild.
2876         * common/common-defs.h: Use new path to gnulib.
2877         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2878         (GNULIB_H): Remove.
2879         (INCGNU): Look in new gnulib location.
2880         (HFILES_NO_SRCDIR): Remove gnulib files.
2881         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2882         (generated_files): Remove GNULIB_H.
2883         ($(LIBGNU), all-lib): Remove targets.
2884         (distclean): Don't mention GNULIB_BUILDDIR.
2885         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2886
2887 2019-06-14  Tom Tromey  <tromey@adacore.com>
2888
2889         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2890         Warn if symbol file does not provide any symbols.
2891
2892 2019-06-14  Tom Tromey  <tromey@adacore.com>
2893
2894         * source.c (find_and_open_source): Respect basenames_may_differ.
2895
2896 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2897
2898         * annotate.c (annotate_breakpoints_invalid): Make use of
2899         scoped_restore_terminal_state.
2900         (annotate_frames_invalid): Likewise.
2901
2902 2019-06-14  Tom Tromey  <tromey@adacore.com>
2903
2904         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2905         allow assignment to an internalvar.
2906
2907 2019-06-14  Tom Tromey  <tromey@adacore.com>
2908
2909         * ada-lex.l: Allow "_" in attribute names.
2910
2911 2019-06-14  Tom Tromey  <tromey@adacore.com>
2912
2913         PR gdb/24653:
2914         * regcache.c (registers_changed): Don't call alloca.
2915         * top.c (execute_command): Don't call alloca.
2916
2917 2019-06-13  Pedro Alves  <palves@redhat.com>
2918
2919         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2920         'expression'.  When parsing an expression, error out if there's
2921         junk after "unlimited".
2922         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2923         (do_set_command): Adjust calls to is_unlimited_literal.
2924
2925 2019-06-13  Pedro Alves  <palves@redhat.com>
2926
2927         * compile/compile.c (make_compile_options_def_group): Add braces
2928         around array_view initializer.
2929         * thread.c (make_thread_apply_all_options_def_group)
2930         (make_thread_apply_all_options_def_group): Likewise.
2931
2932 2019-06-13  Pedro Alves  <palves@redhat.com>
2933
2934         * NEWS (New commands): Mention "maint test-options
2935         require-delimiter", "maint test-options unknown-is-error", "maint
2936         test-options unknown-is-operand" and "maint show
2937         test-options-completion-result".
2938         (New command options, command completion): New section.
2939         (Completion improvements): New section.
2940         Mention that you can abbreviate "unlimited".
2941
2942 2019-06-13  Pedro Alves  <palves@redhat.com>
2943
2944         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2945         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2946         * unittests/cli-utils-selftests.c (test_parse_flags)
2947         (test_parse_flags_qcs): Delete.
2948         (test_cli_utils): Don't call deleted functions.
2949
2950 2019-06-13  Pedro Alves  <palves@redhat.com>
2951
2952         * thread.c: Include "cli/cli-option.h".
2953         (tp_array_compar_ascending): Global.
2954         (tp_array_compar): Delete function.
2955         (tp_array_compar_ascending, tp_array_compar_descending): New
2956         functions.
2957         (ascending_option_def, qcs_flag_option_def)
2958         (thr_qcs_flags_option_defs)
2959         (make_thread_apply_all_options_def_group)
2960         (make_thread_apply_options_def_group): New.
2961         (thread_apply_all_command): Use gdb::option::process_options.
2962         (thread_apply_command_completer)
2963         (thread_apply_all_command_completer): New.
2964         (thread_apply_command): Use gdb::option::process_options.
2965         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2966         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2967         to generate help text of "thread apply".  Adjust "taas"'s help.
2968         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2969         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2970
2971 2019-06-13  Pedro Alves  <palves@redhat.com>
2972
2973         * thread.c (thread_apply_command): Check for invalid TID with
2974         isdigit instead of !isalpha.
2975
2976 2019-06-13  Pedro Alves  <palves@redhat.com>
2977
2978         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2979         (validate_flags_qcs): New.
2980         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2981         (validate_flags_qcs): Declare.
2982         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2983         (make_frame_apply_options_def_group): New.
2984         (frame_apply_command_count): Process options with
2985         gdb::option::process_options.
2986         (frame_apply_completer): New.
2987         (frame_apply_level_completer, frame_apply_all_completer)
2988         (frame_apply_completer): New.
2989         (_initialize_stack): Update help of "frame apply", "frame apply
2990         level", "frame apply all" and "faas" to mention supported options
2991         and install command completers.
2992         * stack.h (frame_apply_all_completer): Declare.
2993         * thread.c: Include "stack.h".
2994         (tfaas_command): Add "--".
2995         (_initialize_thread): Update help "tfaas" to mention supported
2996         options and install command completer.
2997
2998 2019-06-13  Pedro Alves  <palves@redhat.com>
2999
3000         * completer.c (complete_nested_command_line): New.
3001         (gdb_completion_word_break_characters_throw): Add assertion.
3002         * completer.h (complete_nested_command_line): Declare.
3003
3004 2019-06-13  Pedro Alves  <palves@redhat.com>
3005
3006         * stack.c (parse_backtrace_qualifiers): New.
3007         (backtrace_command): Use it.
3008         (backtrace_command_completer): Complete on qualifiers.
3009
3010 2019-06-13  Pedro Alves  <palves@redhat.com>
3011
3012         * frame.c: Include "cli/cli-option.h.
3013         (user_set_backtrace_options): New.
3014         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3015         Delete.
3016         (get_prev_frame): Adjust.
3017         (boolean_option_def, uinteger_option_def)
3018         (set_backtrace_option_defs): New.
3019         (_initialize_frame): Adjust and use
3020         gdb::option::add_setshow_cmds_for_options to install "set
3021         backtrace past-main" and "set backtrace past-entry".
3022         * frame.h: Include "cli/cli-option.h".
3023         (struct frame_print_options): Forward declare.
3024         (print_frame_arguments_all, print_frame_arguments_scalars)
3025         (print_frame_arguments_none): Declare.
3026         (print_entry_values): Delete declaration.
3027         (struct frame_print_options, user_frame_print_options): New.
3028         (struct set_backtrace_options): New.
3029         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3030         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3031         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3032         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3033         (list_args_or_locals): Add frame_print_options parameter.
3034         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3035         * python/py-framefilter.c (enumerate_args): Pass down
3036         USER_FRAME_PRINT_OPTIONS.
3037         * stack.c: Include "cli/cli-option.h".
3038         (print_frame_arguments_all, print_frame_arguments_scalars)
3039         (print_frame_arguments_none): Declare.
3040         (print_raw_frame_arguments, print_entry_values): Delete.
3041         (user_frame_print_options): New.
3042         (boolean_option_def, enum_option_def, frame_print_option_defs):
3043         New.
3044         (struct backtrace_cmd_options): New.
3045         (bt_flag_option_def): New.
3046         (backtrace_command_option_defs): New.
3047         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3048         (print_frame_arg, read_frame_arg, print_frame_args)
3049         (print_frame_info, print_frame): Add frame_print_options parameter
3050         and use it.
3051         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3052         (backtrace_command_1): Add frame_print_options and
3053         backtrace_cmd_options parameters and use them.
3054         (make_backtrace_options_def_group): New.
3055         (backtrace_command): Process command options with
3056         gdb::option::process_options.
3057         (backtrace_command_completer): New.
3058         (_initialize_stack): Extend "backtrace"'s help to mention
3059         supported options.  Install completer for "backtrace".
3060         Install some settings commands with add_setshow_cmds_for_options.
3061
3062 2019-06-13  Pedro Alves  <palves@redhat.com>
3063
3064         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3065         and that "set/show print raw frame-arguments" are now deprecated.
3066
3067         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3068         command.
3069         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3070         * stack.c (_initialize_stack): Install "set/show print
3071         raw-frame-arguments", and deprecate "set/show print raw
3072         frame-arguments".
3073         * valprint.c (_initialize_valprint): Deprecate "set/show print
3074         raw".
3075
3076 2019-06-13  Pedro Alves  <palves@redhat.com>
3077
3078         * compile/compile.c (struct compile_options): New.
3079         (compile_flag_option_def, compile_command_option_defs)
3080         (make_compile_options_def_group): New.
3081         (compile_file_command): Handle options with
3082         gdb::option::process_options.
3083         (compile_file_command_completer): New function.
3084         (compile_code_command): Handle options with
3085         gdb::option::process_options.
3086         (compile_code_command_completer): New function.
3087         (_initialize_compiler): Install completers for "compile code" and
3088         "compile file".  Mention available options in "compile code" and
3089         "compile code"'s help.
3090         * completer.c (advance_to_completion_word): New, factored out from
3091         ...
3092         (advance_to_expression_complete_word_point): ... this.
3093         (advance_to_filename_complete_word_point): New.
3094         * completer.h (advance_to_filename_complete_word_point): New
3095         declaration.
3096
3097 2019-06-13  Pedro Alves  <palves@redhat.com>
3098
3099         * compile/compile.c: Include "cli/cli-option.h".
3100         (compile_print_value): Scope data pointer is now a
3101         value_print_options pointer; adjust.
3102         (compile_print_command): Process options.  Scope data pointer is
3103         now a value_print_options pointer; adjust.
3104         (_initialize_compile): Update "compile print"'s help to include
3105         supported options.  Install a completer for "compile print".
3106         * cp-valprint.c (show_vtblprint, show_objectprint)
3107         (show_static_field_print): Delete.
3108         (_initialize_cp_valprint): Don't install "set print
3109         static-members", "set print vtbl", "set print object" here.
3110         * printcmd.c: Include "cli/cli-option.h" and
3111         "common/gdb_optional.h".
3112         (print_command_parse_format): Rework to fill in a
3113         value_print_options instead of a format_data.
3114         (print_value): Change parameter type from format_data pointer to
3115         value_print_options reference.  Adjust.
3116         (print_command_1): Process options.  Adjust to pass down a
3117         value_print_options.
3118         (print_command_completer): New.
3119         (_initialize_printcmd): Install print_command_completer as
3120         handle_brkchars completer for the "print" command.  Update
3121         "print"'s help to include supported options.
3122         * valprint.c: Include "cli/cli-option.h".
3123         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3124         here from cp-valprint.c.
3125         (boolean_option_def, uinteger_option_def)
3126         (value_print_option_defs, make_value_print_options_def_group):
3127         New.  Use gdb::option::add_setshow_cmds_for_options to install
3128         "set print elements", "set print null-stop", "set print repeats",
3129         "set print pretty", "set print union", "set print array", "set
3130         print address", "set print symbol", "set print array-indexes".
3131         * valprint.h: Include <string> and "cli/cli-option.h".
3132         (make_value_print_options_def_group): Declare.
3133         (print_value): Change parameter type from format_data pointer to
3134         value_print_options reference.
3135         (print_command_completer): Declare.
3136
3137 2019-06-13  Pedro Alves  <palves@redhat.com>
3138
3139         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3140         (COMMON_SFILES): Add maint-test-settings.c.
3141         * cli/cli-decode.c (boolean_enums): New global, factored out from
3142         ...
3143         (add_setshow_boolean_cmd): ... here.
3144         * cli/cli-decode.h (boolean_enums): Declare.
3145         * cli/cli-option.c: New file.
3146         * cli/cli-option.h: New file.
3147         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3148         factored out from ...
3149         (parse_cli_boolean_value(const char *)): ... this.
3150         (is_unlimited_literal): Change parameter type to pointer to
3151         pointer.  Adjust and advance ARG pointer.
3152         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3153         (parse_cli_var_enum): New, factored out from ...
3154         (do_set_command): ... this.  Adjust.
3155         * cli/cli-setshow.h (parse_cli_boolean_value)
3156         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3157         (parse_cli_var_enum): Declare.
3158         * cli/cli-utils.c: Include "cli/cli-option.h".
3159         (get_ulongest): New.
3160         * cli/cli-utils.h (get_ulongest): Declare.
3161         (check_for_argument): New overloads.
3162         * maint-test-options.c: New file.
3163
3164 2019-06-13  Pedro Alves  <palves@redhat.com>
3165
3166         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3167         parse a range if "-" is at the end of the string.
3168
3169 2019-06-13  Pedro Alves  <palves@redhat.com>
3170
3171         * cli/cli-setshow.c (parse_auto_binary_operation)
3172         (parse_cli_boolean_value): Don't allow "o".
3173
3174 2019-06-13  Pedro Alves  <palves@redhat.com>
3175
3176         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3177         * NEWS: Mention maint test-settings KIND.
3178         * maint-test-settings.c: New file.
3179
3180 2019-06-13  Pedro Alves  <palves@redhat.com>
3181
3182         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3183         completer.
3184         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3185         "set" completers.
3186
3187 2019-06-13  Pedro Alves  <palves@redhat.com>
3188
3189         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3190         after item.
3191
3192 2019-06-13  Pedro Alves  <palves@redhat.com>
3193
3194         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3195
3196 2019-06-13  Pedro Alves <palves@redhat.com>
3197
3198         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3199         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3200         call.
3201         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3202         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3203         calls.
3204         (check_for_argument): Skip spaces after argument.
3205
3206 2019-06-13  Pedro Alves  <palves@redhat.com>
3207
3208         * thread.c (thread_apply_command): Adjust TID parsing.
3209         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3210         detected before end of string.
3211         (tid_is_in_list): Error out if LIST is invalid.
3212
3213 2019-06-13  Pedro Alves  <palves@redhat.com>
3214
3215         * completer.c (complete_line_internal_1): Rewind completion word
3216         point.
3217         (completion_tracker::advance_custom_word_point_by): Change
3218         parameter type to int.
3219         * completer.h (completion_tracker::advance_custom_word_point_by):
3220         Likewise.
3221
3222 2019-06-13  Pedro Alves  <palves@redhat.com>
3223
3224         * completer.c (advance_to_completion_word): Handle delimiters.
3225
3226 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3227
3228         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3229
3230 2019-06-11  Tom Tromey  <tom@tromey.com>
3231
3232         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3233         (xmalloc_failed): Move to alloc.c.
3234         * alloc.c: New file.
3235         * Makefile.in (COMMON_SFILES): Add alloc.c.
3236
3237 2019-06-11  Tom Tromey  <tom@tromey.com>
3238
3239         * nat/linux-waitpid.c: Don't include server.h.
3240         (linux_debug): Remove.
3241         (my_waitpid): Update.
3242
3243 2019-06-11  Tom Tromey  <tromey@adacore.com>
3244
3245         * infcall.c (_initialize_infcall): Remove trailing newline from
3246         help.
3247         * user-regs.c (_initialize_user_regs): Remove trailing newline
3248         from help.
3249         * typeprint.c (_initialize_typeprint): Remove trailing newline
3250         from help.
3251         * reverse.c (_initialize_reverse): Remove trailing newlines from
3252         help.
3253         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3254         from help.
3255         * language.c (add_set_language_command): Remove trailing newline
3256         from help.
3257         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3258         help.
3259         * disasm.c (_initialize_disasm): Remove trailing newline from
3260         help.
3261         * top.c (init_main): Remove trailing newline from help.
3262         * interps.c (_initialize_interpreter): Remove trailing newline
3263         from help.
3264         * btrace.c (_initialize_btrace): Remove trailing newlines from
3265         help.
3266         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3267         from help.
3268         * python/python.c (_initialize_python): Remove trailing newline
3269         from help.
3270         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3271         help.
3272         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3273         from help.  Reformat some text.
3274         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3275         from help.
3276         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3277         newline from help.
3278
3279 2019-06-11  Tom Tromey  <tromey@adacore.com>
3280
3281         * darwin-nat.c (darwin_decode_exception_message)
3282         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3283
3284 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3285
3286         * valops.c (value_slice): Check for not allocated or not
3287         associated values.
3288
3289 2019-06-10  Tom de Vries  <tdevries@suse.de>
3290
3291         PR gdb/24618
3292         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3293         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3294         invalid.
3295
3296 2019-06-10  Tom de Vries  <tdevries@suse.de>
3297
3298         PR gdb/24611
3299         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3300         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3301
3302 2019-06-10  Tom de Vries  <tdevries@suse.de>
3303
3304         PR symtab/24545
3305         * symtab.c (struct demangled_name_entry): Add language field.
3306         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3307         static minimal symbol".  Set and use language field.
3308
3309 2019-06-10  Tom Tromey  <tromey@adacore.com>
3310
3311         * ada-lang.c (_initialize_ada_language): Update help text.
3312
3313 2019-06-10  Tom Tromey  <tromey@adacore.com>
3314
3315         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3316         with a newline.
3317         * guile/guile.c (handle_boot_error): Don't end warning with a
3318         newline.
3319         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3320         warning with a newline.
3321         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3322         newline.
3323         (s12z_frame_cache): Likewise.
3324         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3325         a newline.
3326         * solib-svr4.c (disable_probes_interface): Don't end warning with
3327         a newline.
3328         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3329         newline.
3330         * python/python.c (do_finish_initialization): Don't end warning
3331         with a newline.
3332
3333 2019-06-10  Tom Tromey  <tom@tromey.com>
3334
3335         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3336         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3337         gdbpy_enter.
3338
3339 2019-06-10  Tom Tromey  <tromey@adacore.com>
3340
3341         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3342         data.
3343         (elf_new_init): Don't call stabsread_new_init.
3344         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3345         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3346         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3347
3348 2019-06-10  Tom de Vries  <tdevries@suse.de>
3349
3350         PR symtab/16264
3351         PR symtab/24517
3352         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3353
3354 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3355
3356         * source.c (find_and_open_source): Also rewrite relative file
3357         names.
3358
3359 2019-04-26  Amos Bird  <amosbird@gmail.com>
3360
3361         * annotate.c (annotate_thread_exited): Add "thread-exited"
3362         annotation.
3363
3364 2019-06-06  Tom Tromey  <tromey@adacore.com>
3365
3366         * maint.h (class scoped_command_stats): Use
3367         DISABLE_COPY_AND_ASSIGN.
3368         <print_time>: New method.
3369         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3370         print_time.
3371         (scoped_command_stats::print_time): New method.
3372
3373 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3374
3375         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3376         instructions of lengths 6 or 8 bytes.
3377
3378 2019-06-04  Pedro Alves  <palves@redhat.com>
3379
3380         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3381
3382         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3383         * breakpoint.c (condition_completer): Likewise.
3384         * cli/cli-dump.c (scan_expression): Likewise.
3385         * common/filestuff.c (mkdir_recursive): Likewise.
3386         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3387         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3388         (gdb_abspath): Likewise.
3389         * compile/compile-cplus-types.c
3390         (compile_cplus_instance::decl_name): Likewise.
3391         * completer.c (complete_explicit_location):
3392         (signal_completer, reg_or_group_completer_1): Likewise.
3393         * cp-support.c (cp_remove_params_if_any): Likewise.
3394         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3395         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3396         * infcmd.c (strip_bg_char): Likewise.
3397         * linespec.c (copy_token_string): Likewise.
3398         * mi/mi-main.c (output_cores): Likewise.
3399         * psymtab.c (psymtab_search_name):
3400         * symfile.c (test_set_ext_lang_command): Likewise.
3401         * target.c (target_fileio_read_stralloc): Likewise.
3402         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3403         * value.c (complete_internalvar): Likewise.
3404
3405 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3406
3407         Add objfile property to gdb.Type.
3408         * NEWS: Mention Python API addition.
3409         * python/py-type.c (typy_get_objfile): New method.
3410
3411 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3412
3413         * NEWS: Mention the new set|show style [title|highlight].
3414         Mention changes to "show style", "help" and "apropos".
3415
3416 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3417
3418         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3419         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3420         instead of print_help_for_command.
3421         (print_doc_of_command): New function.
3422         (help_list): Add 'apropos -v word' suggestion.
3423         (print_help_for_command): Style the command name using title style.
3424         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3425         (_initialize_cli_cmds): Describe -v in apropos_command help.
3426
3427 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3428
3429         * cli/cli-style.h (cli_style_option): Add name in constructor,
3430         add m_name class member, add constructor with intensity,
3431         add name class function.
3432         (cli_style_option::add_setshow_commands): Remove name argument.
3433         (highlight_style, title_style): New styles.
3434         * cli/cli-style.c (do_show): New function that shows a style
3435         characteristic styling the style name with itself.
3436         (set_style_name): New function.
3437         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3438         Update all callers according to the changes in cli/cli-style.h.
3439         * utils.h (fputs_highlighted): New function.
3440         * utils.c (fputs_highlighted): Likewise.
3441
3442 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3443
3444         * NEWS: Mention new pipe command and new convenience variables.
3445
3446 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3447
3448         * cli/cli-cmds.c (pipe_command): New function.
3449         (_initialize_cli_cmds): Call add_com for pipe_command.
3450         Define | as an alias for pipe.
3451         (exit_status_set_internal_vars): New function.
3452         (shell_escape): Call exit_status_set_internal_vars.
3453         cli/cli-decode.c (find_command_name_length): Recognize | as
3454         a single character command.
3455
3456 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3457
3458         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3459         top.c (execute_command_to_ui_file): New function, mostly a copy
3460         of execute_command_to_string.
3461         (execute_command_to_string): Implement by calling
3462         execute_command_to_ui_file.
3463
3464 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3465
3466         * top.h (saved_command_line): Remove declaration.
3467         * top.c (previous_saved_command_line, previous_repeat_arguments):
3468         New variables.
3469         (saved_command_line): Make static, define together with other
3470         'repeat variables'.
3471         (dont_repeat): Clear repeat_arguments.
3472         (repeat_previous, get_saved_command_line, save_command_line):
3473         New functions.
3474         (gdb_init): Initialize saved_command_line
3475         and previous_saved_command_line.
3476         * main.c (captured_main_1): Remove saved_command_line initialization.
3477         * event-top.c (handle_line_of_input): Update to use
3478         the new 'repeat' related functions instead of direct access to
3479         saved_command_line.
3480         * command.h (repeat_previous, get_saved_command_line,
3481         save_command_line): New declarations.
3482         (dont_repeat): Add comment.
3483
3484 2019-05-30  Tom Tromey  <tromey@adacore.com>
3485
3486         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3487         Fix comment.
3488         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3489
3490 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3491
3492         PR cli/24587
3493         * completer.c (complete): Initialize variable word.
3494
3495 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3496
3497         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3498         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3499         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3500         'body' is NULL to the outter 'if', protecting the '!is_define'
3501         situation as well.
3502
3503 2019-05-29  Tom Tromey  <tromey@adacore.com>
3504
3505         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3506         (dwarf_unknown): New function.
3507         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3508         (dwarf_type_encoding_name): Use dwarf_unknown.
3509
3510 2019-05-29  Tom Tromey  <tromey@adacore.com>
3511
3512         PR c++/20020:
3513         * cp-valprint.c (cp_print_value_fields): Call
3514         cp_print_static_field inside "try".
3515
3516 2019-05-29  Tom Tromey  <tromey@adacore.com>
3517
3518         * inflow.c (struct terminal_info): Add default operator=.
3519         * configure: Rebuild.
3520         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3521         -Wdeprecated-copy-dtor, -Wredundant-move.
3522
3523 2019-05-29  Tom Tromey  <tromey@adacore.com>
3524
3525         * NEWS: Add entry.
3526         * infcmd.c (print_return_value_1): Handle finish_print
3527         option.
3528         (show_print_finish): New function.
3529         (_initialize_infcmd): Add "set/show print finish" commands.
3530         * valprint.c (user_print_options): Initialize new member.
3531         * valprint.h (struct value_print_options) <finish_print>: New
3532         member.
3533
3534 2019-05-28  Tom Tromey  <tromey@adacore.com>
3535
3536         * ada-lang.c (ada_remove_Xbn_suffix)
3537         (find_old_style_renaming_symbol)
3538         (parse_old_style_renaming): Remove.
3539         (ada_find_renaming_symbol): Don't call
3540         find_old_style_renaming_symbol.
3541         (ada_is_renaming_symbol): Rename from
3542         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3543         bool.  Now static.
3544         (ada_read_var_value): Update and simplify.
3545         * ada-exp.y (write_var_or_type): Remove old code.
3546
3547 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3548
3549         * event-top.c: Remove include comment.
3550         * inflow.c (class scoped_ignore_sigttou): Move from here...
3551         * inflow.h (class scoped_ignore_sigttou): ...to here.
3552         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3553         * top.c:  Remove include comment.
3554
3555 2019-05-27  Tom Tromey  <tom@tromey.com>
3556
3557         * NEWS: Fix typo.
3558
3559 2019-05-22  Tom Tromey  <tromey@adacore.com>
3560
3561         * target.c (target_follow_exec): Constify parameter.
3562         * target-delegates.c: Rebuild.
3563         * remote.c (remote_target::follow_exec): Constify parameter.
3564         * infrun.c (follow_exec): Constify parameter.
3565         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3566         (target_follow_exec): Likewise.
3567
3568 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3569
3570         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3571         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3572
3573 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3574
3575         * NEWS: Add debugredirect and testsuite sections.
3576
3577 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3578
3579         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3580         target descriptions using exclusively floating point register name
3581         aliases.
3582
3583 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3584
3585         PR gdb/18644:
3586         * f-lang.c (build_fortran_types): Handle the case where
3587         gdbarch_floatformat_for_type returns a nullptr.
3588
3589 2019-05-21  Tom de Vries  <tdevries@suse.de>
3590
3591         PR cli/24587
3592         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3593
3594 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3595
3596         PR gdb/18644:
3597         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3598         16-byte floats.
3599         * i386-tdep.c (i386_floatformat_for_type): Use
3600         floatformats_ia64_quad for the 16-byte floating point component
3601         within a fortran 32-byte complex number.
3602
3603 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3604
3605         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3606         delete default constructor.
3607         (find_partial_die): Update to return const struct.
3608         (partial_die_parent_scope): Move variable declaration into scope
3609         of its use and change its type to auto.
3610         (guess_partial_die_structure_name): Likewise.
3611         (partial_die_info::fixup): Likewise.
3612
3613 2019-05-17  Tom Tromey  <tromey@adacore.com>
3614
3615         * source.c (find_and_open_source): Remove cast.
3616
3617 2019-05-17  Tom Tromey  <tromey@adacore.com>
3618
3619         * annotate.c (annotate_source): Make "filename" const.
3620         * annotate.h (annotate_source): Use const.
3621
3622 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3623
3624         * disasm.c (set_disassembler_options): Send errors to stderr.
3625
3626 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3627
3628         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3629         (cli_interp_base::set_logging): Check debug_redirect.
3630         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3631         * cli/cli-logging.c (debug_redirect): Add static variable.
3632         (pop_output_files): Add default param.
3633         (handle_redirections): Print debug setting.
3634         (show_logging_command): Likewise.
3635         (_initialize_cli_logging): Add debugredirect command.
3636         * interps.c (current_interp_set_logging): Add debug_redirect
3637         parameter.
3638         * interps.h (set_logging): Add debug_redirect parameter.
3639         (current_interp_set_logging): Likewise.
3640         * mi/mi-common.h: Likewise.
3641         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3642
3643 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3644             Tom Tromey  <tromey@adacore.com>
3645
3646         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3647         directly.
3648         * cli/cli-interp.h (make_logging_output): Remove declaration.
3649         * cli/cli-logging.c (make_logging_output): Remove function.
3650         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3651         directly.
3652         * ui-file.c (tee_file::tee_file): Remove bools.
3653         (tee_file::~tee_file): Remove deletes.
3654         * ui-file.h (tee_file): Remove bools.
3655
3656 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3657
3658         * mi/mi-cmds.h (mi_cmd_complete): New function.
3659         * mi/mi-main.c (mi_cmd_complete): Likewise.
3660         * mi/mi-cmds.c: Define new MI command -complete.
3661         * NEWS: Mention new -complete command.
3662
3663 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3664
3665         * completer.h (complete): New function.
3666         * completer.c (complete): Likewise.
3667         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3668         function defined in completer.h.
3669
3670 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3671
3672         * MAINTAINERS (Write After Approval): Add myself.
3673
3674 2019-05-17  Tom de Vries  <tdevries@suse.de>
3675
3676         PR gdb/24094
3677         * dwarf2read.c (struct cu_partial_die_info): New struct.
3678         (find_partial_die): Return cu_partial_die_info.
3679         (partial_die_parent_scope, guess_partial_die_structure_name)
3680         (partial_die_info::fixup): Handle new return type of find_partial_die.
3681
3682 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3683
3684         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3685         "std::string", simplifying the algorithm.
3686
3687 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3688
3689         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3690         (stap_static_probe_ops::get_probes): Likewise.
3691
3692 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3693
3694         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3695         '-')" and "else if".
3696         (stap_parse_single_operand): Join checks for
3697         "gdbarch_stap_parse_special_token_p" and
3698         "gdbarch_stap_parse_special_token" in the same "if" statement.
3699         Invert check when verifying for operation on register
3700         displacement.
3701
3702 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3703
3704         * stap-probe.c (stap_get_opcode): Update comment.
3705         (stap_get_expected_argument_type): Likewise.
3706         (handle_stap_probe): Likewise.
3707
3708 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3709
3710         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3711         return type to 'bool'.  Adjust comment.  Use 'bool' when
3712         appropriate.
3713         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3714         * stap-probe.c (stap_parse_argument_1): Likewise.
3715         (stap_is_operator): Likewise.
3716         (stap_is_generic_prefix): Likewise.
3717         (stap_is_register_prefix): Likewise.
3718         (stap_is_register_indirection_prefix): Likewise.
3719         (stap_is_integer_prefix): Likewise.
3720         (stap_generic_check_suffix): Likewise.
3721         (stap_check_integer_suffix): Likewise.
3722         (stap_check_register_suffix): Likewise.
3723         (stap_check_register_indirection_suffix): Likewise.
3724         (stap_parse_register_operand): Likewise.
3725         (stap_parse_single_operand): Likewise.
3726         (stap_parse_argument_1): Likewise.
3727         (stap_probe::get_argument_count): Likewise.
3728         (stap_is_operator): Likewise.
3729
3730 2019-05-16  Tom Tromey  <tromey@adacore.com>
3731
3732         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3733         keyword to foreach.
3734
3735 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3736
3737         * linux-thread-db.c (try_thread_db_load_1): Change return type
3738         to bool.
3739         (try_thread_db_load): Likewise.
3740         (try_thread_db_load_from_pdir_1): Likewise.
3741         (try_thread_db_load_from_pdir): Likewise.
3742         (try_thread_db_load_from_sdir): Likewise.
3743         (try_thread_db_load_from_dir): Likewise.
3744         (thread_db_load_search): Likewise.
3745         (has_libpthread): Likewise.
3746         (thread_db_load): Likewise.
3747
3748 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3749
3750         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3751         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3752         NULL, and complain/return if that's the case.
3753
3754 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3755
3756         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3757         (advance, posn, abstract_read_memory): New functions.
3758         [struct mem_read_abstraction]: New struct.
3759         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3760
3761 2019-05-14  Tom Tromey  <tromey@adacore.com>
3762
3763         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3764         value is not lval_memory.
3765
3766 2019-05-14  Tom Tromey  <tromey@adacore.com>
3767
3768         * solib.c (info_sharedlibrary_command): Style the file name.
3769
3770 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3771
3772         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3773         (aarch64_vnv_type): Likewise.
3774         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3775         * common/tdesc.c: Likewise.
3776         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3777         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3778         * features/aarch64-fpu.xml: Add ieee half view.
3779         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3780         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3781         * gdbtypes.h (struct builtin_type): Likewise.
3782         (struct objfile_type): Likewise.
3783
3784 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3785
3786         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3787         typo.
3788         * location.h (string_to_event_location): Likewise.
3789
3790 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3791
3792         GDB 8.3 released.
3793
3794 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3795
3796         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3797         New variable declaration.
3798         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3799         New variable.
3800         (print_one_breakpoint): Use ui_out::test_flags and new global
3801         variable to compute use_fixed_output.
3802         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3803         Remove.
3804         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3805         (mi_multi_location_breakpoint_output_fixed): Remove.
3806         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3807         new variable.
3808         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3809         fix_multi_location_breakpoint_output flag if version >= 3.
3810         * ui-out.h (enum ui_out_flag)
3811         <fix_multi_location_breakpoint_output>: New enumerator.
3812
3813 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3814
3815         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3816
3817 2019-05-10  Tom Tromey  <tromey@adacore.com>
3818
3819         * ada-lang.c (catch_ada_completer): New function.
3820         (_initialize_ada_language): Use it.
3821
3822 2019-05-10  Tom Tromey  <tromey@adacore.com>
3823
3824         * thread.c (print_thread_info): Make "requested_threads" const.
3825         * gdbthread.h (print_thread_info): Make "requested_threads"
3826         const.
3827         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3828         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3829
3830 2019-05-08  Tom Tromey  <tom@tromey.com>
3831
3832         * gdbtypes.c (objfile_type_data): Change type.
3833         (objfile_type, _initialize_gdbtypes): Update.
3834
3835 2019-05-08  Tom Tromey  <tom@tromey.com>
3836
3837         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3838         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3839         (_initialize_dwarf2_frame): Update.
3840
3841 2019-05-08  Tom Tromey  <tom@tromey.com>
3842
3843         * objc-lang.c (objc_objfile_data): Change type.
3844         (find_methods): Update.
3845         (_initialize_objc_lang): Remove.
3846
3847 2019-05-08  Tom Tromey  <tom@tromey.com>
3848
3849         * stabsread.c (rs6000_builtin_type_data): Change type.
3850         (rs6000_builtin_type, _initialize_stabsread): Update.
3851
3852 2019-05-08  Tom Tromey  <tom@tromey.com>
3853
3854         * mips-tdep.c (mips_pdr_data): Remove.
3855         (_initialize_mips_tdep): Update.
3856
3857 2019-05-08  Tom Tromey  <tom@tromey.com>
3858
3859         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3860         (hppa_init_objfile_priv_data, read_unwind_info)
3861         (find_unwind_entry, _initialize_hppa_tdep): Update.
3862
3863 2019-05-08  Tom Tromey  <tom@tromey.com>
3864
3865         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3866         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3867         on obstack.
3868         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3869
3870 2019-05-08  Tom Tromey  <tom@tromey.com>
3871
3872         * mdebugread.c (basic_type_data): Change type.
3873         (basic_type, _initialize_mdebugread): Update.
3874
3875 2019-05-08  Tom Tromey  <tom@tromey.com>
3876
3877         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3878
3879 2019-05-08  Tom Tromey  <tom@tromey.com>
3880
3881         * nto-tdep.c (nto_inferior_data_reg): Change type.
3882         (nto_inferior_data): Update.
3883         (nto_inferior_data_cleanup, nto_new_inferior_data)
3884         (_initialize_nto_tdep): Remove.
3885         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3886
3887 2019-05-08  Tom Tromey  <tom@tromey.com>
3888
3889         * ada-lang.c (struct ada_inferior_data): Add initializers.
3890         (ada_inferior_data): Change type.
3891         (ada_inferior_data_cleanup): Remove.
3892         (get_ada_inferior_data, ada_inferior_exit)
3893         (struct ada_pspace_data): Add initializers, destructor.
3894         (ada_pspace_data_handle): Change type.
3895         (get_ada_pspace_data): Update.
3896         (ada_pspace_data_cleanup): Remove.
3897
3898 2019-05-08  Tom Tromey  <tom@tromey.com>
3899
3900         * coffread.c (struct coff_symfile_info): Add initializers.
3901         (coff_objfile_data_key): Move lower.  Change type.
3902         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3903         Update.
3904         (coff_free_info): Remove.
3905
3906 2019-05-08  Tom Tromey  <tom@tromey.com>
3907
3908         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3909         (fbsd_pspace_data_handle): Move lower.  Change type.
3910         (get_fbsd_pspace_data): Update.
3911         (fbsd_pspace_data_cleanup): Remove.
3912         (_initialize_fbsd_tdep): Update.
3913
3914 2019-05-08  Tom Tromey  <tom@tromey.com>
3915
3916         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3917         (get_ada_tasks_pspace_data): Update.
3918         (ada_tasks_pspace_data_cleanup): Remove.
3919         (_initialize_tasks): Update.
3920         (ada_tasks_inferior_data_handle): Change type.
3921         (get_ada_tasks_inferior_data): Update.
3922         (ada_tasks_inferior_data_cleanup): Remove.
3923         (struct ada_tasks_pspace_data): Add initializers.
3924
3925 2019-05-08  Tom Tromey  <tom@tromey.com>
3926
3927         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3928         * symfile-debug.c (debug_sym_get_probes): Change type.
3929         * stap-probe.c (handle_stap_probe):
3930         (stap_static_probe_ops::get_probes): Change type.
3931         * probe.h (class static_probe_ops) <get_probes>: Change type.
3932         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3933         (parse_probes_in_pspace): Update.
3934         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3935         Update.
3936         (any_static_probe_ops::get_probes): Change type.
3937         * elfread.c (elfread_data): New typedef.
3938         (probe_key): Change type.
3939         (elf_get_probes): Likewise.  Update.
3940         (probe_key_free): Remove.
3941         (_initialize_elfread): Update.
3942         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3943         Change type.
3944         (dtrace_process_dof_probe, dtrace_process_dof)
3945         (dtrace_static_probe_ops::get_probe): Change type.
3946
3947 2019-05-08  Tom Tromey  <tom@tromey.com>
3948
3949         * xcoffread.c (struct xcoff_symfile_info): Rename from
3950         coff_symfile_info.  Add initializers.
3951         (xcoff_objfile_data_key): Move lower.  Change type.
3952         (XCOFF_DATA): Rewrite.
3953         (xcoff_free_info): Remove.
3954         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3955         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3956         (xcoff_initial_scan): Update.
3957
3958 2019-05-08  Tom Tromey  <tom@tromey.com>
3959
3960         * solib-svr4.c (struct svr4_info): Add initializers and
3961         destructor.
3962         <probes_table>: Now an htab_up.
3963         (solib_svr4_pspace_data): Change type.
3964         (free_probes_table): Simplify.
3965         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3966         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3967         (probes_table_remove_objfile_probes, register_solib_event_probe)
3968         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3969         (_initialize_svr4_solib): Update.
3970
3971 2019-05-08  Tom Tromey  <tom@tromey.com>
3972
3973         * remote.c (remote_pspace_data): Change type.
3974         (remote_pspace_data_cleanup): Remove.
3975         (get_remote_exec_file, set_pspace_remote_exec_file)
3976         (_initialize_remote): Update.
3977
3978 2019-05-08  Tom Tromey  <tom@tromey.com>
3979
3980         * breakpoint.c (breakpoint_objfile_key): Change type.
3981         (get_breakpoint_objfile_data): Update.
3982         (free_breakpoint_objfile_data): Remove.
3983         (_initialize_breakpoint): Update.
3984
3985 2019-05-08  Tom Tromey  <tom@tromey.com>
3986
3987         * linux-tdep.c (struct linux_info): Add initializers.
3988         (linux_inferior_data): Move.  Change type.
3989         (invalidate_linux_cache_inf): Update.
3990         (linux_inferior_data_cleanup): Remove.
3991         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3992
3993 2019-05-08  Tom Tromey  <tom@tromey.com>
3994
3995         * auxv.c (auxv_inferior_data): Move.  Change type.
3996         (auxv_inferior_data_cleanup): Remove.
3997         (invalidate_auxv_cache_inf): Rewrite.
3998         (get_auxv_inferior_data, _initialize_auxv): Update.
3999
4000 2019-05-08  Tom Tromey  <tom@tromey.com>
4001
4002         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4003         (symfile_debug_objfile_data_key): Change type.
4004         (symfile_debug_installed, debug_qf_has_symbols)
4005         (debug_qf_find_last_source_symtab)
4006         (debug_qf_forget_cached_source_info)
4007         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4008         (debug_qf_print_stats, debug_qf_dump)
4009         (debug_qf_expand_symtabs_for_function)
4010         (debug_qf_expand_all_symtabs)
4011         (debug_qf_expand_symtabs_with_fullname)
4012         (debug_qf_map_matching_symbols)
4013         (debug_qf_expand_symtabs_matching)
4014         (debug_qf_find_pc_sect_compunit_symtab)
4015         (debug_qf_map_symbol_filenames)
4016         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4017         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4018         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4019         (debug_sym_read_linetable, debug_sym_relocate): Update.
4020         (symfile_debug_free_objfile): Remove.
4021         (install_symfile_debug_logging, _initialize_symfile_debug):
4022         Update.
4023
4024 2019-05-08  Tom Tromey  <tom@tromey.com>
4025
4026         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4027         allocate_on_obstack.
4028         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4029         (get_dwarf2_per_objfile): Update.
4030         (set_dwarf2_per_objfile): Remove.
4031         (dwarf2_has_info, dwarf2_get_section_info): Update.
4032         (dwarf2_free_objfile): Remove.
4033         (_initialize_dwarf2_read): Update.
4034
4035 2019-05-08  Tom Tromey  <tom@tromey.com>
4036
4037         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4038         initializers.
4039         <unsupported_script_warning_printed,
4040         script_not_found_warning_printed>: Now bool.
4041         (auto_load_pspace_data): Change type.
4042         (~auto_load_pspace_info): Rename from
4043         auto_load_pspace_data_cleanup.
4044         (get_auto_load_pspace_data, init_loaded_scripts_info)
4045         (clear_section_scripts, maybe_print_unsupported_script_warning)
4046         (maybe_print_script_not_found_warning, _initialize_auto_load):
4047         Update.
4048
4049 2019-05-08  Tom Tromey  <tom@tromey.com>
4050
4051         * objfiles.c (objfile_pspace_info): Add destructor and
4052         initializers.
4053         (objfiles_pspace_data): Change type.
4054         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4055         (get_objfile_pspace_data): Update.
4056         (objfiles_bfd_data): Change type.
4057         (get_objfile_bfd_data): Update.
4058         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4059
4060 2019-05-08  Tom Tromey  <tom@tromey.com>
4061
4062         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4063         Change type.
4064         (get_catch_syscall_inferior_data): Update.
4065         (catch_syscall_inferior_data_cleanup): Remove.
4066         (_initialize_break_catch_syscall): Update.
4067
4068 2019-05-08  Tom Tromey  <tom@tromey.com>
4069
4070         * inflow.c (struct terminal_info): Add destructor and
4071         initializers.
4072         (inflow_inferior_data): Change type.
4073         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4074         (get_inflow_inferior_data, inflow_inferior_exit)
4075         (swap_terminal_info, _initialize_inflow): Update.
4076
4077 2019-05-08  Tom Tromey  <tom@tromey.com>
4078
4079         * target-dcache.c (target_dcache_cleanup): Remove.
4080         (target_dcache_aspace_key): Change type.
4081         (target_dcache_init_p, target_dcache_invalidate)
4082         (target_dcache_get, target_dcache_get_or_init)
4083         (_initialize_target_dcache): Update.
4084         * dcache.h (struct dcache_deleter): New.
4085
4086 2019-05-08  Tom Tromey  <tom@tromey.com>
4087
4088         * symtab.c (struct symbol_cache): Add destructor and
4089         initializers.
4090         (symbol_cache_key): Move.  Change type.
4091         (make_symbol_cache, free_symbol_cache): Remove.
4092         (get_symbol_cache): Update.
4093         (symbol_cache_cleanup): Remove.
4094         (ALL_PSPACES, symbol_cache_flush)
4095         (maintenance_print_symbol_cache)
4096         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4097         Update.
4098
4099 2019-05-08  Tom Tromey  <tom@tromey.com>
4100
4101         * symtab.c (struct main_info): Add destructor and initializers.
4102         (main_progspace_key): Move.  Change type.
4103         (get_main_info): Update.
4104         (main_info_cleanup): Remove.
4105         (_initialize_symtab): Update.
4106
4107 2019-05-08  Tom Tromey  <tom@tromey.com>
4108
4109         * registry.h (DECLARE_REGISTRY): Define the _key class.
4110
4111 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4112
4113         * NEWS: Merge two 'New commands' sections.
4114
4115 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4116
4117         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4118         parameter and use Ada language definition instead.
4119         (ada_val_print_ptr): Remove unused language parameter.
4120         (ada_val_print_num): Remove language parameter and use Ada language
4121         definition instead.
4122         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4123         parameter.
4124         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4125         parameter and use Ada language definition instead.
4126         (ada_val_print_1): Update all ada_val_print_xxx calls.
4127         Remove language parameter.
4128         (ada_val_print): Update ada_val_print_1 call.
4129
4130 2019-05-08  Tom Tromey  <tromey@adacore.com>
4131
4132         * remote.c (remote_hw_watchpoint_limit)
4133         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4134         Now static.
4135
4136 2019-05-08  Tom Tromey  <tromey@adacore.com>
4137
4138         * maint.c (_initialize_maint_cmds): Move initialization code to
4139         remote.c.
4140         (watchdog, show_watchdog): Move to remote.c.
4141         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4142         "watchdog" static.
4143         (_initialize_remote): Move initialization code from maint.c.
4144         * defs.h (watchdog): Don't declare.
4145
4146 2019-05-08  Tom Tromey  <tromey@adacore.com>
4147
4148         * tui/tui-interp.c: Include main.h.
4149         * interps.c: Include main.h.
4150         * main.h (interpreter_p): Declare.
4151         * defs.h (interpreter_p): Don't declare.
4152
4153 2019-05-08  Tom Tromey  <tromey@adacore.com>
4154
4155         * dwarf2loc.c: Include dwarf2read.h.
4156         * defs.h (read_unsigned_leb128): Don't declare.
4157         * dwarf2read.h (read_unsigned_leb128): Declare.
4158
4159 2019-05-08  Tom Tromey  <tromey@adacore.com>
4160
4161         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4162         method.
4163
4164 2019-05-08  Tom Tromey  <tromey@adacore.com>
4165
4166         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4167         when no wrap column is set.
4168
4169 2019-05-08  Tom Tromey  <tromey@adacore.com>
4170
4171         * c-lang.c (c_get_string): Handle non-C-style arrays.
4172
4173 2019-05-08  Tom Tromey  <tromey@adacore.com>
4174
4175         * typeprint.c (print_offset_data::update): Print the bit offset,
4176         not the number of bits remaining.
4177
4178 2019-05-08  Tom Tromey  <tromey@adacore.com>
4179
4180         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4181         padding at end of comment.
4182
4183 2019-05-08  Tom Tromey  <tromey@adacore.com>
4184
4185         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4186         Compare main types.
4187
4188 2019-05-06  Tom Tromey  <tom@tromey.com>
4189
4190         * common/scoped_mmap.c: Include common-defs.h.
4191         * common/scoped_mmap.h: Don't include config.h.
4192
4193 2019-05-04  Tom Tromey  <tom@tromey.com>
4194
4195         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4196         (struct aarch64_call_info): Add initializers.
4197         <si>: Now a std::vector.
4198         (pass_on_stack, aarch64_push_dummy_call): Update.
4199
4200 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4201             Tom Tromey  <tom@tromey.com>
4202
4203         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4204         (ppc_threads): Now a std::vector.  Now static.
4205         (hwdebug_find_thread_points_by_tid)
4206         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4207         Update.
4208
4209 2019-05-04  Tom Tromey  <tom@tromey.com>
4210
4211         * arc-tdep.c (arc_tdesc_init): Return bool.
4212
4213 2019-05-04  Tom Tromey  <tom@tromey.com>
4214
4215         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4216         Use gdb_assert_not_reached.
4217
4218 2019-05-04  Tom Tromey  <tom@tromey.com>
4219
4220         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4221         "false".
4222
4223 2019-05-04  Tom Tromey  <tom@tromey.com>
4224
4225         * arc-tdep.c (arc_tdesc_init): Use bool.
4226
4227 2019-05-04  Tom Tromey  <tom@tromey.com>
4228
4229         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4230
4231 2019-05-04  Tom Tromey  <tom@tromey.com>
4232
4233         * cli/cli-cmds.c (valid_command_p): Return bool.
4234
4235 2019-05-04  Tom Tromey  <tom@tromey.com>
4236
4237         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4238         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4239
4240 2019-05-04  Raul Tambre  <raul@tambre.ee>
4241
4242         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4243         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4244         operator for comparison.
4245
4246 2019-05-04  Tom Tromey  <tom@tromey.com>
4247
4248         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4249         (lookup_partial_symbol, print_partial_symbols)
4250         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4251         (psymbol_compare): Update.
4252         (add_psymbol_to_bcache): Clear the entire psymbol.
4253         (maintenance_check_psymtabs): Update.
4254         * psympriv.h (struct partial_symbol): Don't derive from
4255         general_symbol_info.
4256         <obj_section, unrelocated_address, address,
4257         set_unrelocated_address>: Update.
4258         <ginfo>: New member.
4259         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4260         (debug_names::write_psymbols): Update.
4261
4262 2019-05-04  Tom de Vries  <tdevries@suse.de>
4263
4264         * contrib/cc-with-tweaks.sh: Support -n arg.
4265
4266 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4267
4268         * corelow.c (core_target::detach): Ensure frame cache and
4269         register caches are cleared.
4270         inferior.c (exit_inferior_1): Likewise.
4271
4272 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4273             Tom Tromey  <tom@tromey.com>
4274
4275         * dictionary.c (collate_pending_symbols_by_language): Remove
4276         "struct" from foreach.
4277         * symtab.c (lookup_global_symbol_from_objfile)
4278         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4279         foreach.
4280         * ser-tcp.c (net_open): Remove "struct" from foreach.
4281         * objfiles.c (objfile_relocate, objfile_rebase)
4282         (objfile_has_symbols): Remove "struct" from foreach.
4283         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4284         from foreach.
4285         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4286         foreach.
4287         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4288         "struct" from foreach.
4289         * ada-lang.c (create_excep_cond_exprs)
4290         (ada_exception_catchpoint_cond_string): Remove "struct" from
4291         foreach.
4292
4293 2019-05-03  Tom Tromey  <tromey@adacore.com>
4294
4295         * ada-exp.y (convert_char_literal): Check suffix of each
4296         enumerator.
4297
4298 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4299
4300         PR ada/21406:
4301         * ada-exp.y (yywrap): Don't define.
4302         * ada-lex.l (%option): Add noyywrap
4303         (yywrap): Remove.
4304
4305 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4306
4307         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4308         _WIN32_WINNT to the XP level, unless already defined to a higher
4309         level.
4310
4311         * unittests/parse-connection-spec-selftests.c:
4312         * ser-tcp.c:
4313         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4314         override.
4315
4316         * symfile.c (find_separate_debug_file): Remove colon from the
4317         drive spec of DOS/Windows file names of the target, so that the
4318         file name produced from DEBUGDIR and the target's directory will
4319         be valid on DOS/Windows systems.
4320
4321 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4322
4323         * rust-lang.c (val_print_struct): Handle printing structures
4324         containing strings.
4325
4326 2019-05-02  Tom Tromey  <tromey@adacore.com>
4327
4328         * valarith.c (_initialize_valarith): Remove.
4329
4330 2019-05-01  Tom Tromey  <tromey@adacore.com>
4331
4332         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4333         bitfields.
4334
4335 2019-05-01  Tom Tromey  <tromey@adacore.com>
4336
4337         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4338         for big-endian copies.
4339
4340 2019-04-30  Ali Tamur  <tamur@google.com>
4341         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4342         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4343         (read_3_bytes): New function.
4344
4345 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4346
4347         * windows-nat.c (main_thread_id): Delete.
4348         (handle_output_debug_string): Replace main_thread_id by
4349         current_event.dwThreadId.
4350         (fake_create_process): Likewise.
4351         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4352         Do not set main_thread_id.
4353         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4354         current_event.dwThreadId.
4355         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4356
4357 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4358
4359         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4360         Use current_event.dwThreadId instead of main_thread_id.
4361
4362 2019-04-30  Tom Tromey  <tromey@adacore.com>
4363
4364         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4365         (create_excep_cond_exprs): Iterate over program spaces.
4366         (ada_exception_catchpoint_cond_string): Examine all minimal
4367         symbols for exception types.
4368
4369 2019-04-30  Tom Tromey  <tromey@adacore.com>
4370
4371         PR c++/24470:
4372         * dwarf2read.c (process_structure_scope): Handle case where type
4373         has template parameters but no symbol was created.
4374
4375 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4376             Chris January  <chris.january@arm.com>
4377
4378         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4379         qualifier.
4380         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4381
4382 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4383
4384         * f-typeprint.c (f_print_type): Update rules for printing
4385         whitespace.
4386         (f_type_print_varspec_suffix): Likewise.
4387
4388 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4389             Chris January  <chris.january@arm.com>
4390
4391         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4392         function arguments.
4393
4394 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4395
4396         * f-lang.c (build_fortran_types): Change name of void type to
4397         lower case.
4398         * f-typeprint.c (f_type_print_base): Print the name of the void
4399         type, rather than a fixed string.
4400         * f-valprint.c (f_decorations): Use lower case void string.
4401
4402 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4403             Chris January  <chris.january@arm.com>
4404
4405         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4406         types for Fortran.
4407
4408 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4409             Chris January  <chris.january@arm.com>
4410             David Lecomber  <david.lecomber@arm.com>
4411
4412         * f-exp.y (BINOP_INTRINSIC): New token.
4413         (exp): New parser rule handling BINOP_INTRINSIC.
4414         (f77_keywords): Add new builtin procedures.
4415         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4416         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4417         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4418         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4419         (print_unop_subexp_f): New function.
4420         (print_binop_subexp_f): New function.
4421         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4422         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4423         (dump_subexp_body_f): Likewise.
4424         (operator_check_f): Likewise.
4425         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4426         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4427
4428 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4429
4430         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4431         UNOP_KIND.
4432         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4433         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4434         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4435         (operator_length_f): New fuction.
4436         (print_subexp_f): New function.
4437         (op_name_f): New function.
4438         (dump_subexp_body_f): New function.
4439         (operator_check_f): New function.
4440         (exp_descriptor_f): Replace standard expression handling functions
4441         with new functions.
4442         * gdb/fortran-operator.def: New file.
4443         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4444         * gdb/std-operator.def: Remove UNOP_KIND.
4445
4446 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4447
4448         * std-operator.def: Remove unbalanced, stray double quote
4449         character.
4450
4451 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4452             Chris January  <chris.january@arm.com>
4453             Daniel Everett  <daniel.everett@arm.com>
4454             Nick Forrington  <nick.forrington@arm.com>
4455             Richard Bunt  <richard.bunt@arm.com>
4456
4457         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4458         of depth when printing anonymous structs or unions.
4459         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4460         Don't print either the top-level value, or the children if the
4461         max-depth is exceeded.
4462         (ppscm_print_children): When printing the key of a map, allow one
4463         extra level of depth.
4464         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4465         print either the top-level value, or the children if the max-depth
4466         is exceeded.
4467         (print_children): When printing the key of a map, allow one extra
4468         level of depth.
4469         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4470         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4471         (user_print_options): Initialise max_depth field.
4472         (val_print_scalar_or_string_type_p): New function.
4473         (val_print): Check to see if the max depth has been reached.
4474         (val_print_check_max_depth): Define new function.
4475         (show_print_max_depth): New function.
4476         (_initialize_valprint): Add 'print max-depth' option.
4477         * valprint.h (struct value_print_options) <max_depth>: New field.
4478         (val_print_check_max_depth): Declare new function.
4479         * NEWS: Document new feature.
4480
4481 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4482
4483         * ada-lang.c (ada_language_defn): Initialise new field.
4484         * c-lang.c (c_is_string_type_p): New function.
4485         (c_language_defn): Initialise new field.
4486         (cplus_language_defn): Initialise new field.
4487         (asm_language_defn): Initialise new field.
4488         (minimal_language_defn): Initialise new field.
4489         * c-lang.h (c_is_string_type_p): Declare new function.
4490         * d-lang.c (d_language_defn): Initialise new field.
4491         * f-lang.c (f_is_string_type_p): New function.
4492         (f_language_defn): Initialise new field.
4493         * go-lang.c (go_is_string_type_p): New function.
4494         (go_language_defn): Initialise new field.
4495         * language.c (default_is_string_type_p): New function.
4496         (unknown_language_defn): Initialise new field.
4497         (auto_language_defn): Initialise new field.
4498         * language.h (struct language_defn) <la_is_string_type_p>: New
4499         member variable.
4500         (default_is_string_type_p): Declare new function.
4501         * m2-lang.c (m2_language_defn): Initialise new field.
4502         * objc-lang.c (objc_language_defn): Initialise new field.
4503         * opencl-lang.c (opencl_language_defn): Initialise new field.
4504         * p-lang.c (pascal_is_string_type_p): New function.
4505         (pascal_language_defn): Initialise new field.
4506         * rust-lang.c (rust_is_string_type_p): New function.
4507         (rust_language_defn): Initialise new field.
4508
4509 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4510
4511         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4512         New field.
4513         * ada-lang.c (ada_language_defn): Initialise new field.
4514         * c-lang.c (c_language_defn): Likewise.
4515         (cplus_language_defn): Likewise.
4516         (asm_language_defn): Likewise.
4517         (minimal_language_defn): Likewise.
4518         * d-lang.c (d_language_defn): Likewise.
4519         * f-lang.c (f_language_defn): Likewise.
4520         * go-lang.c (go_language_defn): Likewise.
4521         * language.c (unknown_language_defn): Likewise.
4522         (auto_language_defn): Likewise.
4523         * m2-lang.c (m2_language_defn): Likewise.
4524         * objc-lang.c (objc_language_defn): Likewise.
4525         * opencl-lang.c (opencl_language_defn): Likewise.
4526         * p-lang.c (pascal_language_defn): Likewise.
4527         * rust-lang.c (rust_language_defn): Likewise.
4528
4529 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * ada-lang.c (ada_is_character_type): Change return type to bool.
4532         (ada_is_string_type): Likewise.
4533         * ada-lang.h (ada_is_character_type): Update declaration
4534         (ada_is_string_type): Likewise.
4535
4536 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4537
4538         Support style in 'frame|thread apply'
4539
4540         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4541         * record.c (record_start, record_stop): Update callers of
4542         execute_command_to_string with false.
4543         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4544         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4545         methods.
4546         (class string_file): New constructor with term_out parameter.
4547         Override methods term_out and can_emit_style_escape.  New member
4548         term_out.
4549         (class stdio_file): Override can_emit_style_escape.
4550         (class tee_file): Override term_out and can_emit_style_escape.
4551         * utils.h (can_emit_style_escape): Remove.
4552         * utils.c (can_emit_style_escape): Likewise.
4553         Update all callers of can_emit_style_escape (SOMESTREAM) to
4554         SOMESTREAM->can_emit_style_escape.
4555         * source-cache.c (source_cache::get_source_lines): Likewise.
4556         * stack.c (frame_apply_command_count): Call execute_command_to_string
4557         passing the term_out characteristic of the current gdb_stdout.
4558         * thread.c (thr_try_catch_cmd): Likewise.
4559         * top.c (execute_command_to_string): pass term_out parameter
4560         to construct the string_file for the command output.
4561         * ui-file.c (term_cli_styling): New function (most code moved
4562         from utils.c can_emit_style_escape).
4563         (string_file::string_file, string_file::can_emit_style_escape,
4564         stdio_file::can_emit_style_escape, tee_file::term_out,
4565         tee_file::can_emit_style_escape): New functions.
4566
4567 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4568
4569         * NEWS: Mention the new set|show may-call-functions.
4570         * infcall.c (may_call_functions_p): New variable.
4571         (show_may_call_functions_p): New function.
4572         (call_function_by_hand_dummy): Throws an error if not
4573         may-call-functions.
4574         (_initialize_infcall): Call add_setshow_boolean_cmd for
4575         may-call-functions.
4576
4577 2019-04-25  Keith Seitz  <keiths@redhat.com>
4578
4579         PR c++/24367
4580         * cp-support.c (inspect_type): Don't attempt substitutions
4581         of symbol with the same name.
4582
4583 2019-04-25  Tom Tromey  <tromey@adacore.com>
4584
4585         PR gdb/24475:
4586         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4587         static.
4588
4589 2019-04-25  Tom Tromey  <tromey@adacore.com>
4590
4591         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4592         rvalue reference.
4593         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4594         (gdb_xml_parser::parse): Use std::move.
4595         * python/python-internal.h (gdbpy_convert_exception): Take a const
4596         reference.
4597         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4598         std::move.
4599         * python/py-utils.c (gdbpy_convert_exception): Take a const
4600         reference.
4601         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4602         Use std::move.
4603         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4604         Use std::move.
4605         * mi/mi-main.c (mi_print_exception): Take a const reference.
4606         * main.c (handle_command_errors): Take a const reference.
4607         * linespec.c (parse_linespec): Use std::move.
4608         * infcall.c (run_inferior_call): Use std::move.
4609         (call_function_by_hand_dummy): Use std::move.
4610         * exec.c (try_open_exec_file): Use std::move.
4611         * exceptions.h (exception_print, exception_fprintf)
4612         (exception_print_same): Update.
4613         * exceptions.c (print_exception, exception_print)
4614         (exception_fprintf, exception_print_same): Change parameters to
4615         const reference.
4616         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4617         * common/new-op.c: Use std::move.
4618         * common/common-exceptions.h (struct gdb_exception): Add move
4619         constructor.
4620         (struct gdb_exception_error, struct gdb_exception_quit, struct
4621         gdb_quit_bad_alloc): Change constructor to move constructor.
4622         (throw_exception): Change parameter to rvalue reference.
4623         * common/common-exceptions.c (throw_exception): Take rvalue
4624         reference.
4625         * cli/cli-interp.c (safe_execute_command): Use std::move.
4626         * breakpoint.c (insert_bp_location, location_to_sals): Use
4627         std::move.
4628
4629 2019-04-25  Tom Tromey  <tromey@adacore.com>
4630
4631         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4632         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4633         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4634         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4635         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4636         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4637         guile/scm-value.c: Use unpack.
4638         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4639         gdbscm_gdb_exception.
4640         (gdbscm_throw_gdb_exception): Likewise.
4641         (struct gdbscm_gdb_exception): New.
4642         (unpack): New function.
4643         (gdbscm_wrap): Use unpack.
4644
4645 2019-04-25  Tom Tromey  <tromey@adacore.com>
4646
4647         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4648         (gdb_rl_callback_handler): Use std::move.
4649         * common/common-exceptions.h (struct gdb_exception): Add move
4650         assignment operator.
4651         (throw_exception_sjlj): Change "exception" to const reference.
4652         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4653         (throw_exception_sjlj): Change "exception" to const reference.
4654
4655 2019-04-25  Tom Tromey  <tromey@adacore.com>
4656
4657         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4658         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4659         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4660         Update.
4661         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4662         Update.
4663         * mi/mi-interp.c (mi_interp::exec): Update.
4664         * linespec.c (parse_linespec): Update.
4665         * infcall.c (run_inferior_call): Update.
4666         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4667         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4668         (gdbscm_lookup_global_symbol): Update.
4669         * guile/scm-param.c (gdbscm_parameter_value): Update.
4670         * guile/scm-frame.c (gdbscm_frame_read_register)
4671         (gdbscm_frame_read_var): Update.
4672         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4673         * exec.c (try_open_exec_file): Update.
4674         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4675         (gdb_rl_callback_handler): Update.
4676         * common/common-exceptions.h (exception_none): Don't declare.
4677         * common/common-exceptions.c (exception_none): Don't define.
4678         (struct catcher) <exception>: Update.
4679         * cli/cli-interp.c (safe_execute_command): Update.
4680         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4681
4682 2019-04-25  Ali Tamur  <tamur@google.com>
4683
4684         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4685         (read_attribute_value): Likewise.
4686         (dwarf2_read_addr_index): Update comment.
4687         (read_str_index): Add DW_FORM_strx.
4688         (dwarf2_string_attr): Likewise.
4689         (dwarf2_const_value_attr): Likewise.
4690         (dump_die_shallow): Likewise.
4691         (dwarf2_fetch_constant_bytes): Likewise.
4692         (skip_form_bytes): Likewise.
4693         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4694
4695 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4696
4697         PR corefiles/11608
4698         PR corefiles/18187
4699         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4700         OFFSET.  Verify if current mapping contains an ELF header.
4701         (linux_find_memory_regions_full): Adjust call to
4702         dump_mapping_p.
4703
4704 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4705             Kang Li <kanglictf@gmail.com>
4706
4707         PR gdb/21600
4708
4709         * dwarf2-frame.c (read_initial_length): Be consistent about using
4710         unsigned representation of length.
4711         (decode_frame_entry_1): Likewise.  Check for wraparound of
4712         end pointer as well as buffer overflow.
4713
4714 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4715
4716         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4717         "vq".
4718
4719 2019-04-24  Tom Tromey  <tromey@adacore.com>
4720
4721         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4722
4723 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4724
4725         * s12z-tdep.c (s12z_unwind_pc): Delete.
4726         (s12z_unwind_sp): Delete.
4727         (s12z_gdbarch_init): Don't register deleted functions with
4728         gdbarch.
4729
4730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4731
4732         * rl78-tdep.c (rl78_unwind_sp): Delete.
4733         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4734
4735 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4736
4737         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4738         (xstormy16_unwind_pc): Delete.
4739         (xstormy16_dummy_id): Delete.
4740         (xstormy16_gdbarch_init): Don't register deleted functions with
4741         gdbarch.
4742
4743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4744
4745         * vax-tdep.c (vax_unwind_pc): Delete.
4746         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4747
4748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4749
4750         * v850-tdep.c (v850_unwind_sp): Delete.
4751         (v850_unwind_pc): Delete.
4752         (v850_dummy_id): Delete.
4753         (v850_gdbarch_init): Don't register deleted functions with
4754         gdbarch.
4755
4756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4757
4758         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4759         (tilegx_unwind_pc): Delete.
4760         (tilegx_unwind_dummy_id): Delete.
4761         (tilegx_gdbarch_init): Don't register deleted functions with
4762         gdbarch.
4763
4764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4765
4766         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4767         (tic6x_dummy_id): Delete.
4768         (tic6x_gdbarch_init): Don't register deleted functions with
4769         gdbarch.
4770
4771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4772
4773         * sparc-tdep.c (sparc_unwind_pc): Delete.
4774         (sparc32_gdbarch_init): Don't register deleted function with
4775         gdbarch.
4776
4777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4778
4779         * sh-tdep.c (sh_unwind_sp): Delete.
4780         (sh_unwind_pc): Delete.
4781         (sh_dummy_id): Delete.
4782         (sh_gdbarch_init): Don't register deleted functions with
4783         gdbarch.
4784
4785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4786
4787         * score-tdep.c (score_unwind_sp): Delete.
4788         (score_unwind_pc): Delete.
4789         (score_dummy_id): Delete.
4790         (score_gdbarch_init): Don't register deleted functions with
4791         gdbarch.
4792
4793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4794
4795         * rx-tdep.c (rx_unwind_pc): Delete.
4796         (rx_unwind_sp): Delete.
4797         (rx_dummy_id): Delete.
4798         (rx_gdbarch_init): Don't register deleted functions with
4799         gdbarch.  Update comment.
4800
4801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4802
4803         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4804         (rs6000_dummy_id): Delete.
4805         (rs6000_gdbarch_init): Don't register deleted functions with
4806         gdbarch.
4807
4808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4809
4810         * or1k-tdep.c (or1k_dummy_id): Delete.
4811         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4812
4813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4814
4815         * nios2-tdep.c (nios2_dummy_id): Delete.
4816         (nios2_unwind_sp): Delete.
4817         (nios2_gdbarch_init): Don't register deleted functions with
4818         gdbarch.
4819
4820 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4821
4822         * nds32-tdep.c (nds32_dummy_id): Delete.
4823         (nds32_unwind_pc): Delete.
4824         (nds32_unwind_sp): Delete.
4825         (nds32_gdbarch_init): Don't register deleted functions with
4826         gdbarch.
4827
4828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4829
4830         * msp430-tdep.c (msp430_unwind_pc): Delete.
4831         (msp430_unwind_sp): Delete.
4832         (msp430_dummy_id): Delete.
4833         (msp430_gdbarch_init): Don't register deleted functions with
4834         gdbarch.
4835
4836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4837
4838         * moxie-tdep.c (moxie_unwind_sp): Delete.
4839         (moxie_unwind_pc): Delete.
4840         (moxie_dummy_id): Delete.
4841         (moxie_gdbarch_init): Don't register deleted functions with
4842         gdbarch.
4843
4844 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4845
4846         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4847         (mn10300_unwind_pc): Delete.
4848         (mn10300_unwind_sp): Delete.
4849         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4850         mn10300_unwind_sp.
4851         (mn10300_frame_unwind_init): Don't register deleted functions with
4852         gdbarch.
4853
4854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * mep-tdep.c (mep_unwind_pc): Delete.
4857         (mep_unwind_sp): Delete.
4858         (mep_dummy_id): Delete.
4859         (mep_gdbarch_init): Don't register deleted functions with
4860         gdbarch.
4861
4862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4863
4864         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4865         (m68hc11_unwind_sp): Delete.
4866         (m68hc11_gdbarch_init): Don't register deleted functions with
4867         gdbarch.
4868
4869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4870
4871         * m32r-tdep.c (m32r_unwind_sp): Delete.
4872         (m32r_unwind_pc): Delete.
4873         (m32r_dummy_id): Delete.
4874         (m32r_gdbarch_init): Don't register deleted functions with
4875         gdbarch.
4876
4877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4878
4879         * m32c-tdep.c (m32c_unwind_pc): Delete.
4880         (m32c_unwind_sp): Delete.
4881         (m32c_dummy_id): Delete.
4882         (m32c_gdbarch_init): Don't register deleted functions with
4883         gdbarch.
4884
4885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4886
4887         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4888         (lm32_unwind_pc): Delete.
4889         (lm32_dummy_id): Delete.
4890         (lm32_gdbarch_init): Don't register deleted functions with
4891         gdbarch.
4892
4893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4894
4895         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4896         (iq2000_unwind_pc): Delete.
4897         (iq2000_dummy_id): Delete.
4898         (iq2000_gdbarch_init): Don't register deleted functions with
4899         gdbarch.
4900
4901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4902
4903         * nds32-tdep.c (nds32_type_align): Delete.
4904         (nds32_push_dummy_call): Use type_align instead.
4905
4906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4907
4908         * arm-tdep.c (arm_type_align): Only handle vector override case.
4909         (arm_push_dummy_call): Use type_align.
4910         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4911
4912 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4913
4914         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4915         case.
4916         (pass_on_stack): Use type_align.
4917         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4918         function.
4919
4920 2019-04-23  Tom Tromey  <tromey@adacore.com>
4921
4922         * dwarf2read.c (line_header::file_name_at): Remove unused
4923         overload.
4924
4925 2019-04-23  Tom de Vries  <tdevries@suse.de>
4926
4927         PR gdb/24438
4928         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4929         invocation.
4930
4931
4932 2019-03-27  Ali Tamur  <tamur@google.com>
4933
4934         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4935         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4936         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4937         (dwarf_expr_context::get_addr_index): Likewise
4938         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4939         (symbol_needs_eval_context::get_addr_index): Likewise
4940         (disassemble_dwarf_expression): Add DW_OP_addrx
4941         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4942         (read_cutu_die_from_dwo): Update comment
4943         (skip_one_die): Add DW_FORM_addrx
4944         (read_attribute_value): Likewise
4945         (var_decode_location): Add DW_OP_addrx
4946         (dwarf2_const_value_attr): Add DW_FORM_addrx
4947         (dump_die_shallow): Likewise
4948         (dwarf2_fetch_constant_bytes): Likewise
4949         (decode_locdesc): Add DW_OP_addrx
4950         (skip_form_bytes): Add DW_FORM_addrx
4951
4952 2019-04-22  Ali Tamur  <tamur@google.com>
4953
4954         * MAINTAINERS (Write After Approval): Add self.
4955
4956 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4957
4958         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4959         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4960         (open_symbol_file_object): Likewise.
4961         (svr4_default_sos): Add info parameter.
4962         (svr4_read_so_list): Likewise.
4963         (svr4_current_sos_direct): Adjust functions calls to pass down
4964         info.
4965         (svr4_current_sos_1): Add info parameter.
4966         (svr4_current_sos): Call get_svr4_info, pass info down to
4967         svr4_current_sos_1.
4968         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4969         get_svr4_info.
4970         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4971         get_svr4_info.
4972         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4973         to get_svr4_info.
4974         (probes_table_remove_objfile_probes): Likewise.
4975         (register_solib_event_probe): Add info parameter.
4976         (solist_update_incremental): Pass info parameter down to
4977         svr4_read_so_list.
4978         (disable_probes_interface): Add info parameter.
4979         (svr4_handle_solib_event): Pass current_program_space to
4980         get_svr4_info.  Adjust disable_probes_interface cleanup.
4981         (svr4_create_probe_breakpoints): Add info parameter, pass it
4982         down to register_solib_event_probe.
4983         (svr4_create_solib_event_breakpoints): Add info parameter,
4984         pass it down to svr4_create_probe_breakpoints.
4985         (enable_break): Pass info down to
4986         svr4_create_solib_event_breakpoints.
4987         (svr4_solib_create_inferior_hook): Pass current_program_space to
4988         get_svr4_info.
4989         (svr4_clear_solib): Likewise.
4990
4991 2019-04-22  Pedro Alves  <palves@redhat.com>
4992
4993         * solib-svr4.c (svr4_free_objfile_observer): New.
4994         (probe_and_action::objfile): New field.
4995         (probes_table_htab_remove_objfile_probes)
4996         (probes_table_remove_objfile_probes): New functions.
4997         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4998         in the new probe_and_action.  Don't store the probe in 'lookup'.
4999         (svr4_create_probe_breakpoints): Pass objfile to
5000         register_solib_event_probe.
5001         (_initialize_svr4_solib): Register a free_objfile observer.
5002
5003 2019-04-19  Tom Tromey  <tom@tromey.com>
5004
5005         * common/queue.h: Remove.
5006
5007 2019-04-19  Tom Tromey  <tom@tromey.com>
5008
5009         * event-loop.c: Don't include "common/queue.h".
5010
5011 2019-04-19  Tom Tromey  <tom@tromey.com>
5012
5013         * remote.c (remote_target): Use delete.
5014         * remote-notif.h: Include <list>, not "common/queue.h".
5015         (notif_client_p): Remove typedef.
5016         (remote_notif_state): Add constructor, destructor, initializer.
5017         <notif_queue>: Now a std::list.
5018         (remote_notif_state_xfree): Don't declare.
5019         * remote-notif.c (remote_notif_process, handle_notification)
5020         (remote_notif_state_allocate): Update.
5021         (~remote_notif_state): Rename from remote_notif_state_xfree.
5022
5023 2019-04-19  Tom Tromey  <tom@tromey.com>
5024
5025         * symfile.c (reread_symbols): Update.
5026         * objfiles.c (objfile_register_static_link)
5027         (objfile_lookup_static_link): Update
5028         (~objfile) Don't delete static_links.
5029         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5030
5031 2019-04-19  Tom Tromey  <tom@tromey.com>
5032
5033         * type-stack.h (struct type_stack) <insert>: Constify string.
5034         * type-stack.c (type_stack::insert): Constify string.
5035         * gdbtypes.h (lookup_template_type): Update.
5036         (address_space_name_to_int): Update.
5037         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5038         const.
5039         (lookup_template_type): Make name const.
5040         * c-exp.y: Update rules.
5041         (lex_one_token, classify_name, classify_inner_name)
5042         (c_print_token): Update.
5043         * p-exp.y: Update rules.
5044         (yylex): Update.
5045         * f-exp.y: Update rules.
5046         (yylex): Update.
5047         * d-exp.y: Update rules.
5048         (lex_one_token, classify_name, classify_inner_name): Update.
5049         * parse.c (write_dollar_variable, copy_name): Return std::string.
5050         * parser-defs.h (copy_name): Change return type.
5051         * m2-exp.y: Update rules.
5052         (yylex): Update.
5053         * go-exp.y (lex_one_token): Update.
5054         Update rules.
5055         (classify_unsafe_function, classify_packaged_name)
5056         (classify_name, yylex): Update.
5057
5058 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5059
5060         * configure.ac: add --enable-source-highlight switch.
5061         * configure: Regenerate.
5062         * top.c (print_gdb_version): plumb --enable-source-highlight
5063         status to "show configuration".
5064
5065 2019-04-19  Tom Tromey  <tromey@adacore.com>
5066
5067         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5068         Check ADA_TYPE_P.
5069         (empty_record, ada_template_to_fixed_record_type_1)
5070         (template_to_static_fixed_type)
5071         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5072         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5073         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5074         macros.
5075
5076 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5077
5078         PR symtab/24423:
5079         * source.c (print_source_lines_base): Advance "iter" when a
5080         control character is seen.
5081
5082 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5083
5084         * inferior.h (struct infcall_suspend_state_deleter):
5085         Catch exception in destructor to avoid crash.
5086
5087 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5088
5089         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5090         close to the add_com "shell".
5091
5092 2019-04-18  Tom Tromey  <tromey@adacore.com>
5093
5094         * process-stratum-target.h (class process_stratum_target)
5095         <stratum>: Add "final".
5096
5097 2019-04-17  Tom Tromey  <tromey@adacore.com>
5098
5099         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5100         against nullptr before use.
5101
5102 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5103
5104         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5105
5106 2019-04-17  Jim Wilson  <jimw@sifive.com>
5107             Andrew Burgess  <andrew.burgess@embecosm.com>
5108
5109         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5110         code read might fail, assume 4-byte breakpoint in that case.
5111
5112 2019-04-15  Leszek Swirski  <leszeks@google.com>
5113
5114         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5115         rather than a hand-rolled POD check when checking for forced MEMORY
5116         classification.
5117
5118 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5119
5120         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5121         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5122         function.
5123         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5124         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5125         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5126         declaration.
5127
5128 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5129
5130         * aarch64-linux-nat.c
5131         (aarch64_linux_nat_target::thread_architecture): Add override.
5132         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5133         each VQ.
5134
5135 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5136
5137         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5138
5139 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5140
5141         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5142         target types of size 96-bits, add some additional comments, and
5143         check that the builtin type we found was the correct size.
5144
5145 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5146
5147         * utils.c (prompt_for_continue): Don't restore the styling at the
5148         end, as applied_style has the wrong value.  This fixes styling in
5149         long lists of file names that are interrupted by the "Continue?"
5150         prompt.
5151
5152 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5155         * c-lang.c (c_language_defn): Likewise.
5156         (cplus_language_defn): Likewise.
5157         (asm_language_defn): Likewise.
5158         (minimal_language_defn): Likewise.
5159         * d-lang.c (d_language_defn): Likewise.
5160         * f-lang.c (f_language_defn): Likewise.
5161         * go-lang.c (go_language_defn): Likewise.
5162         * language.c (unknown_language_defn): Likewise.
5163         (auto_language_defn): Likewise.
5164         * language.h (struct language_defn): Remove la_magic field.
5165         (LANG_MAGIC): Delete.
5166         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5167         * objc-lang.c (objc_language_defn): Likewise.
5168         * opencl-lang.c (opencl_language_defn): Likewise.
5169         * p-lang.c (pascal_language_defn): Likewise.
5170         * rust-lang.c (rust_language_defn): Likewise.
5171
5172 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5173
5174         * riscv-tdep.c (riscv_type_align): New function.
5175         (riscv_type_alignment): Delete.
5176         (riscv_arg_location): Use 'type_align'.
5177         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5178
5179 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5180
5181         * gdbtypes.c (type_align): A struct with no non-static fields also
5182         has alignment of 1.
5183
5184 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5185
5186         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5187         component to 0.
5188         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5189         member.
5190         (riscv_struct_info::analyse): New implementation using new
5191         analyse_inner member function.
5192         (riscv_struct_info::field_offset): New member function.
5193         (riscv_struct_info::m_offsets): New member variable.
5194         (riscv_struct_info::analyse_inner): New private member function,
5195         takes the old implementation of riscv_struct_info::analyse but
5196         extended to track field offsets.
5197         (riscv_call_arg_struct): Update the struct folding special cases
5198         to handle cases where empty C++ structs, which are non-zero
5199         length, are found.
5200         (riscv_arg_location): Initialise the length of each location, a
5201         non-zero length now indicates the location is in use.
5202         (riscv_push_dummy_call): Allow for the first location having a
5203         non-zero offset when setting up arguments.
5204         (riscv_return_value): Likewise, but for return values.
5205
5206 2019-04-11  Tom Tromey  <tromey@adacore.com>
5207
5208         * utils.c (internal_vproblem): Make "msg" const.
5209
5210 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5211
5212         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5213         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5214         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5215         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5216
5217 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5218
5219         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5220         function.
5221         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5222         of amd64_collect_native_gregset.
5223         (amd64_linux_nat_target::store_registers): Likewise.
5224
5225 2019-04-10  Tom Tromey  <tom@tromey.com>
5226
5227         * symtab.c (lookup_global_symbol_from_objfile)
5228         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5229         * objfiles.h (class separate_debug_iterator): New.
5230         (class separate_debug_range): New.
5231         (struct objfile) <separate_debug_objfiles>: New method.
5232         (objfile_separate_debug_iterate): Don't declare.
5233         * objfiles.c (separate_debug_iterator::operator++): Rename from
5234         objfile_separate_debug_iterate.
5235         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5236         iterator.
5237         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5238         iterator.
5239
5240 2019-04-10  Tom Tromey  <tom@tromey.com>
5241
5242         * symfile.c (reread_symbols): Remove old comment.
5243         * objfiles.c (free_all_objfiles): Fix a typo.
5244
5245 2019-04-10  Tom Tromey  <tom@tromey.com>
5246
5247         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5248         * minsyms.c (lookup_minimal_symbol): Use foreach.
5249         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5250         (lookup_minimal_symbol_solib_trampoline): Likewise.
5251         * symfile.c (reread_symbols): Use foreach.
5252
5253 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5254             Tom Tromey  <tromey@adacore.com>
5255
5256         PR rust/24414:
5257         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5258         (rust_lex_int_test): Change "value" to be LONGEST.
5259         (rust_lex_tests): Add test for long integer literal.
5260
5261 2019-04-09  Tom Tromey  <tromey@adacore.com>
5262
5263         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5264         to bool.
5265         (extended_remote_target::attach): Update.
5266         (remote_target::remote_notice_new_inferior): Update.
5267         (remote_target::add_current_inferior_and_thread): Update.
5268         * inferior.c (exit_inferior_1): Use "false".
5269         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5270
5271 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5272
5273         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5274         the "start" command.
5275
5276 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5277
5278         * python/py-inferior.c (infpy_thread_from_thread_handle):
5279         Adjust comments to reflect renaming of thread_from_thread_handle
5280         to thread_from_handle.  Adjust keywords.  Fix type error message.
5281         (inferior_object_methods): Add thread_from_handle.  Retain
5282         thread_from_thread_handle, but mark it as deprecated.
5283
5284 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5285
5286         * gdbthread.h (find_thread_by_handle): Revise declaration.
5287         * thread.c (find_thread_by_handle): Likewise.  Adjust
5288         implementation too.
5289         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5290         support for buffer objects as handles.
5291
5292 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5293
5294         * python/py-infthread.c (thpy_thread_handle): New function.
5295         (thread_object_methods): Register thpy_thread_handle.
5296
5297 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5298
5299         * gdbthread.h (thread_to_thread_handle): Declare.
5300         * thread.c (gdbtypes.h): Include.
5301         (thread_to_thread_handle): New function.
5302
5303         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5304         (target_thread_info_to_thread_handle): Declare.
5305         * target.c (target_thread_info_to_thread_handle): New function.
5306         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5307         * target-delegates.c: Regenerate.
5308
5309         * linux-thread-db.c (class thread_db_target): Add method
5310         thread_info_to_thread_handle.
5311         (thread_db_target::thread_info_to_thread_handle): Define.
5312         * remote.c (class remote_target): Add new method
5313         thread_info_to_thread_handle.
5314         (remote_target::thread_info_to_thread_handle): Define.
5315
5316 2019-04-08  Pedro Alves  <palves@redhat.com>
5317
5318         * common/common-exceptions.c (throw_exception): Don't create
5319         named object to throw; throw directly.
5320         (throw_it): Likewise.  Don't initialize gdb_exception::message
5321         here, with new; pass FMT and AP to the ctor instead.
5322         * common/common-exceptions.h: Include <string>.
5323         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5324         const char *, va_list)): New ctor.  Use std::make_shared.
5325         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5326         errors)): Delete.
5327         (gdb_exception_error::gdb_exception_error(enum errors, const char
5328         *, va_list)): New.
5329         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5330         Add assertion.
5331         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5332         errors)): Delete.
5333         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5334         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5335         Add assertion.
5336
5337 2019-04-08  Tom Tromey  <tom@tromey.com>
5338
5339         * valops.c (value_rtti_indirect_type): Replace throw_exception
5340         with throw.
5341         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5342         with throw.
5343         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5344         throw.
5345         * target.c (target_translate_tls_address): Replace throw_exception
5346         with throw.
5347         * stack.c (frame_apply_command_count): Replace throw_exception
5348         with throw.
5349         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5350         throw.
5351         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5352         with throw.
5353         * rs6000-tdep.c (rs6000_frame_cache)
5354         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5355         * remote.c: Replace throw_exception with throw.
5356         * record-full.c (record_full_message, record_full_wait_1)
5357         (record_full_restore): Replace throw_exception with throw.
5358         * record-btrace.c:
5359         (get_thread_current_frame_id, record_btrace_start_replaying)
5360         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5361         (cmd_record_btrace_start): Replace throw_exception with throw.
5362         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5363         throw.
5364         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5365         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5366         * linespec.c:
5367         (find_linespec_symbols): Replace throw_exception with throw.
5368         * infrun.c (displaced_step_prepare, resume): Replace
5369         throw_exception with throw.
5370         * infcmd.c (post_create_inferior): Replace throw_exception with
5371         throw.
5372         * inf-loop.c (inferior_event_handler): Replace throw_exception
5373         with throw.
5374         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5375         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5376         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5377         (get_prev_frame_always, get_frame_pc_if_available)
5378         (get_frame_address_in_block_if_available, get_frame_language):
5379         Replace throw_exception with throw.
5380         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5381         throw_exception with throw.
5382         * eval.c (fetch_subexp_value, evaluate_var_value)
5383         (evaluate_funcall, evaluate_subexp_standard): Replace
5384         throw_exception with throw.
5385         * dwarf2loc.c (call_site_find_chain)
5386         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5387         Replace throw_exception with throw.
5388         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5389         with throw.
5390         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5391         throw.
5392         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5393         * completer.c (complete_line_internal): Replace throw_exception
5394         with throw.
5395         * compile/compile-object-run.c (compile_object_run): Replace
5396         throw_exception with throw.
5397         * cli/cli-script.c (process_next_line): Replace throw_exception
5398         with throw.
5399         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5400         (btrace_enable, btrace_maint_update_pt_packets): Replace
5401         throw_exception with throw.
5402         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5403         throw_exception with throw.
5404         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5405         throw_exception with throw.
5406         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5407         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5408         * aarch64-tdep.c (aarch64_make_prologue_cache)
5409         (aarch64_make_stub_cache): Replace throw_exception with throw.
5410
5411 2019-04-08  Tom Tromey  <tom@tromey.com>
5412
5413         * common/common-exceptions.c (throw_exception): Rename from
5414         throw_exception_cxx.  Remove old copy.  Make argument const.
5415         (throw_it): Create and throw exception objects directly.
5416         * common/common-exceptions.h (throw_exception): Make argument
5417         const.
5418         (struct gdb_exception_error): Add constructor.
5419         (struct gdb_exception_quit): Add constructor.
5420
5421 2019-04-08  Tom Tromey  <tom@tromey.com>
5422
5423         * common/common-exceptions.h (exception_rethrow): Don't declare.
5424         (TRY_SJLJ): Update comment.
5425         (TRY, CATCH, END_CATCH): Remove.
5426         * common/common-exceptions.c (exception_rethrow): Remove.
5427
5428 2019-04-08  Tom Tromey  <tom@tromey.com>
5429
5430         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5431         Remove.
5432         (gdb_exception_error): Rename from
5433         gdb_exception_RETURN_MASK_ERROR.
5434         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5435         (gdb_quit_bad_alloc): Update.
5436         * aarch64-tdep.c: Update.
5437         * ada-lang.c: Update.
5438         * ada-typeprint.c: Update.
5439         * ada-valprint.c: Update.
5440         * amd64-tdep.c: Update.
5441         * arch-utils.c: Update.
5442         * break-catch-throw.c: Update.
5443         * breakpoint.c: Update.
5444         * btrace.c: Update.
5445         * c-varobj.c: Update.
5446         * cli/cli-cmds.c: Update.
5447         * cli/cli-interp.c: Update.
5448         * cli/cli-script.c: Update.
5449         * common/common-exceptions.c: Update.
5450         * common/new-op.c: Update.
5451         * common/selftest.c: Update.
5452         * compile/compile-c-symbols.c: Update.
5453         * compile/compile-cplus-symbols.c: Update.
5454         * compile/compile-object-load.c: Update.
5455         * compile/compile-object-run.c: Update.
5456         * completer.c: Update.
5457         * corelow.c: Update.
5458         * cp-abi.c: Update.
5459         * cp-support.c: Update.
5460         * cp-valprint.c: Update.
5461         * darwin-nat.c: Update.
5462         * disasm-selftests.c: Update.
5463         * dtrace-probe.c: Update.
5464         * dwarf-index-cache.c: Update.
5465         * dwarf-index-write.c: Update.
5466         * dwarf2-frame-tailcall.c: Update.
5467         * dwarf2-frame.c: Update.
5468         * dwarf2loc.c: Update.
5469         * dwarf2read.c: Update.
5470         * eval.c: Update.
5471         * event-loop.c: Update.
5472         * event-top.c: Update.
5473         * exec.c: Update.
5474         * f-valprint.c: Update.
5475         * fbsd-tdep.c: Update.
5476         * frame-unwind.c: Update.
5477         * frame.c: Update.
5478         * gdbtypes.c: Update.
5479         * gnu-v3-abi.c: Update.
5480         * guile/guile-internal.h: Update.
5481         * guile/scm-block.c: Update.
5482         * guile/scm-breakpoint.c: Update.
5483         * guile/scm-cmd.c: Update.
5484         * guile/scm-disasm.c: Update.
5485         * guile/scm-frame.c: Update.
5486         * guile/scm-lazy-string.c: Update.
5487         * guile/scm-math.c: Update.
5488         * guile/scm-param.c: Update.
5489         * guile/scm-ports.c: Update.
5490         * guile/scm-pretty-print.c: Update.
5491         * guile/scm-symbol.c: Update.
5492         * guile/scm-symtab.c: Update.
5493         * guile/scm-type.c: Update.
5494         * guile/scm-value.c: Update.
5495         * i386-linux-tdep.c: Update.
5496         * i386-tdep.c: Update.
5497         * inf-loop.c: Update.
5498         * infcall.c: Update.
5499         * infcmd.c: Update.
5500         * infrun.c: Update.
5501         * jit.c: Update.
5502         * language.c: Update.
5503         * linespec.c: Update.
5504         * linux-fork.c: Update.
5505         * linux-nat.c: Update.
5506         * linux-tdep.c: Update.
5507         * linux-thread-db.c: Update.
5508         * main.c: Update.
5509         * mi/mi-cmd-break.c: Update.
5510         * mi/mi-cmd-stack.c: Update.
5511         * mi/mi-interp.c: Update.
5512         * mi/mi-main.c: Update.
5513         * objc-lang.c: Update.
5514         * p-valprint.c: Update.
5515         * parse.c: Update.
5516         * ppc-linux-tdep.c: Update.
5517         * printcmd.c: Update.
5518         * python/py-arch.c: Update.
5519         * python/py-breakpoint.c: Update.
5520         * python/py-cmd.c: Update.
5521         * python/py-finishbreakpoint.c: Update.
5522         * python/py-frame.c: Update.
5523         * python/py-framefilter.c: Update.
5524         * python/py-gdb-readline.c: Update.
5525         * python/py-inferior.c: Update.
5526         * python/py-infthread.c: Update.
5527         * python/py-lazy-string.c: Update.
5528         * python/py-linetable.c: Update.
5529         * python/py-objfile.c: Update.
5530         * python/py-param.c: Update.
5531         * python/py-prettyprint.c: Update.
5532         * python/py-progspace.c: Update.
5533         * python/py-record-btrace.c: Update.
5534         * python/py-record.c: Update.
5535         * python/py-symbol.c: Update.
5536         * python/py-type.c: Update.
5537         * python/py-unwind.c: Update.
5538         * python/py-utils.c: Update.
5539         * python/py-value.c: Update.
5540         * python/python.c: Update.
5541         * record-btrace.c: Update.
5542         * record-full.c: Update.
5543         * remote-fileio.c: Update.
5544         * remote.c: Update.
5545         * riscv-tdep.c: Update.
5546         * rs6000-aix-tdep.c: Update.
5547         * rs6000-tdep.c: Update.
5548         * rust-exp.y: Update.
5549         * rust-lang.c: Update.
5550         * s390-tdep.c: Update.
5551         * selftest-arch.c: Update.
5552         * solib-dsbt.c: Update.
5553         * solib-frv.c: Update.
5554         * solib-spu.c: Update.
5555         * solib-svr4.c: Update.
5556         * solib.c: Update.
5557         * sparc64-linux-tdep.c: Update.
5558         * stack.c: Update.
5559         * symfile-mem.c: Update.
5560         * symmisc.c: Update.
5561         * target.c: Update.
5562         * thread.c: Update.
5563         * top.c: Update.
5564         * tracefile-tfile.c: Update.
5565         * tui/tui.c: Update.
5566         * typeprint.c: Update.
5567         * unittests/cli-utils-selftests.c: Update.
5568         * unittests/parse-connection-spec-selftests.c: Update.
5569         * valops.c: Update.
5570         * valprint.c: Update.
5571         * value.c: Update.
5572         * varobj.c: Update.
5573         * windows-nat.c: Update.
5574         * x86-linux-nat.c: Update.
5575         * xml-support.c: Update.
5576
5577 2019-04-08  Tom Tromey  <tom@tromey.com>
5578
5579         * xml-support.c: Use C++ exception handling.
5580         * x86-linux-nat.c: Use C++ exception handling.
5581         * windows-nat.c: Use C++ exception handling.
5582         * varobj.c: Use C++ exception handling.
5583         * value.c: Use C++ exception handling.
5584         * valprint.c: Use C++ exception handling.
5585         * valops.c: Use C++ exception handling.
5586         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5587         handling.
5588         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5589         * typeprint.c: Use C++ exception handling.
5590         * tui/tui.c: Use C++ exception handling.
5591         * tracefile-tfile.c: Use C++ exception handling.
5592         * top.c: Use C++ exception handling.
5593         * thread.c: Use C++ exception handling.
5594         * target.c: Use C++ exception handling.
5595         * symmisc.c: Use C++ exception handling.
5596         * symfile-mem.c: Use C++ exception handling.
5597         * stack.c: Use C++ exception handling.
5598         * sparc64-linux-tdep.c: Use C++ exception handling.
5599         * solib.c: Use C++ exception handling.
5600         * solib-svr4.c: Use C++ exception handling.
5601         * solib-spu.c: Use C++ exception handling.
5602         * solib-frv.c: Use C++ exception handling.
5603         * solib-dsbt.c: Use C++ exception handling.
5604         * selftest-arch.c: Use C++ exception handling.
5605         * s390-tdep.c: Use C++ exception handling.
5606         * rust-lang.c: Use C++ exception handling.
5607         * rust-exp.y: Use C++ exception handling.
5608         * rs6000-tdep.c: Use C++ exception handling.
5609         * rs6000-aix-tdep.c: Use C++ exception handling.
5610         * riscv-tdep.c: Use C++ exception handling.
5611         * remote.c: Use C++ exception handling.
5612         * remote-fileio.c: Use C++ exception handling.
5613         * record-full.c: Use C++ exception handling.
5614         * record-btrace.c: Use C++ exception handling.
5615         * python/python.c: Use C++ exception handling.
5616         * python/py-value.c: Use C++ exception handling.
5617         * python/py-utils.c: Use C++ exception handling.
5618         * python/py-unwind.c: Use C++ exception handling.
5619         * python/py-type.c: Use C++ exception handling.
5620         * python/py-symbol.c: Use C++ exception handling.
5621         * python/py-record.c: Use C++ exception handling.
5622         * python/py-record-btrace.c: Use C++ exception handling.
5623         * python/py-progspace.c: Use C++ exception handling.
5624         * python/py-prettyprint.c: Use C++ exception handling.
5625         * python/py-param.c: Use C++ exception handling.
5626         * python/py-objfile.c: Use C++ exception handling.
5627         * python/py-linetable.c: Use C++ exception handling.
5628         * python/py-lazy-string.c: Use C++ exception handling.
5629         * python/py-infthread.c: Use C++ exception handling.
5630         * python/py-inferior.c: Use C++ exception handling.
5631         * python/py-gdb-readline.c: Use C++ exception handling.
5632         * python/py-framefilter.c: Use C++ exception handling.
5633         * python/py-frame.c: Use C++ exception handling.
5634         * python/py-finishbreakpoint.c: Use C++ exception handling.
5635         * python/py-cmd.c: Use C++ exception handling.
5636         * python/py-breakpoint.c: Use C++ exception handling.
5637         * python/py-arch.c: Use C++ exception handling.
5638         * printcmd.c: Use C++ exception handling.
5639         * ppc-linux-tdep.c: Use C++ exception handling.
5640         * parse.c: Use C++ exception handling.
5641         * p-valprint.c: Use C++ exception handling.
5642         * objc-lang.c: Use C++ exception handling.
5643         * mi/mi-main.c: Use C++ exception handling.
5644         * mi/mi-interp.c: Use C++ exception handling.
5645         * mi/mi-cmd-stack.c: Use C++ exception handling.
5646         * mi/mi-cmd-break.c: Use C++ exception handling.
5647         * main.c: Use C++ exception handling.
5648         * linux-thread-db.c: Use C++ exception handling.
5649         * linux-tdep.c: Use C++ exception handling.
5650         * linux-nat.c: Use C++ exception handling.
5651         * linux-fork.c: Use C++ exception handling.
5652         * linespec.c: Use C++ exception handling.
5653         * language.c: Use C++ exception handling.
5654         * jit.c: Use C++ exception handling.
5655         * infrun.c: Use C++ exception handling.
5656         * infcmd.c: Use C++ exception handling.
5657         * infcall.c: Use C++ exception handling.
5658         * inf-loop.c: Use C++ exception handling.
5659         * i386-tdep.c: Use C++ exception handling.
5660         * i386-linux-tdep.c: Use C++ exception handling.
5661         * guile/scm-value.c: Use C++ exception handling.
5662         * guile/scm-type.c: Use C++ exception handling.
5663         * guile/scm-symtab.c: Use C++ exception handling.
5664         * guile/scm-symbol.c: Use C++ exception handling.
5665         * guile/scm-pretty-print.c: Use C++ exception handling.
5666         * guile/scm-ports.c: Use C++ exception handling.
5667         * guile/scm-param.c: Use C++ exception handling.
5668         * guile/scm-math.c: Use C++ exception handling.
5669         * guile/scm-lazy-string.c: Use C++ exception handling.
5670         * guile/scm-frame.c: Use C++ exception handling.
5671         * guile/scm-disasm.c: Use C++ exception handling.
5672         * guile/scm-cmd.c: Use C++ exception handling.
5673         * guile/scm-breakpoint.c: Use C++ exception handling.
5674         * guile/scm-block.c: Use C++ exception handling.
5675         * guile/guile-internal.h: Use C++ exception handling.
5676         * gnu-v3-abi.c: Use C++ exception handling.
5677         * gdbtypes.c: Use C++ exception handling.
5678         * frame.c: Use C++ exception handling.
5679         * frame-unwind.c: Use C++ exception handling.
5680         * fbsd-tdep.c: Use C++ exception handling.
5681         * f-valprint.c: Use C++ exception handling.
5682         * exec.c: Use C++ exception handling.
5683         * event-top.c: Use C++ exception handling.
5684         * event-loop.c: Use C++ exception handling.
5685         * eval.c: Use C++ exception handling.
5686         * dwarf2read.c: Use C++ exception handling.
5687         * dwarf2loc.c: Use C++ exception handling.
5688         * dwarf2-frame.c: Use C++ exception handling.
5689         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5690         * dwarf-index-write.c: Use C++ exception handling.
5691         * dwarf-index-cache.c: Use C++ exception handling.
5692         * dtrace-probe.c: Use C++ exception handling.
5693         * disasm-selftests.c: Use C++ exception handling.
5694         * darwin-nat.c: Use C++ exception handling.
5695         * cp-valprint.c: Use C++ exception handling.
5696         * cp-support.c: Use C++ exception handling.
5697         * cp-abi.c: Use C++ exception handling.
5698         * corelow.c: Use C++ exception handling.
5699         * completer.c: Use C++ exception handling.
5700         * compile/compile-object-run.c: Use C++ exception handling.
5701         * compile/compile-object-load.c: Use C++ exception handling.
5702         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5703         * compile/compile-c-symbols.c: Use C++ exception handling.
5704         * common/selftest.c: Use C++ exception handling.
5705         * common/new-op.c: Use C++ exception handling.
5706         * cli/cli-script.c: Use C++ exception handling.
5707         * cli/cli-interp.c: Use C++ exception handling.
5708         * cli/cli-cmds.c: Use C++ exception handling.
5709         * c-varobj.c: Use C++ exception handling.
5710         * btrace.c: Use C++ exception handling.
5711         * breakpoint.c: Use C++ exception handling.
5712         * break-catch-throw.c: Use C++ exception handling.
5713         * arch-utils.c: Use C++ exception handling.
5714         * amd64-tdep.c: Use C++ exception handling.
5715         * ada-valprint.c: Use C++ exception handling.
5716         * ada-typeprint.c: Use C++ exception handling.
5717         * ada-lang.c: Use C++ exception handling.
5718         * aarch64-tdep.c: Use C++ exception handling.
5719
5720 2019-04-08  Tom Tromey  <tom@tromey.com>
5721
5722         * xml-support.c (gdb_xml_parser::parse): Update.
5723         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5724         * value.c (show_convenience): Update.
5725         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5726         (test_parse_flags_qcs): Update.
5727         * thread.c (thr_try_catch_cmd): Update.
5728         * target.c (target_translate_tls_address): Update.
5729         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5730         (info_frame_command_core, frame_apply_command_count): Update.
5731         * rust-exp.y (rust_lex_exception_test): Update.
5732         * riscv-tdep.c (riscv_print_one_register_info): Update.
5733         * remote.c (remote_target::enable_btrace): Update.
5734         * record-btrace.c (record_btrace_enable_warn): Update.
5735         * python/py-utils.c (gdbpy_convert_exception): Update.
5736         * printcmd.c (do_one_display, print_variable_and_value): Update.
5737         * mi/mi-main.c (mi_print_exception): Update.
5738         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5739         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5740         * linux-nat.c (linux_nat_target::attach): Update.
5741         * linux-fork.c (class scoped_switch_fork_info): Update.
5742         * infrun.c (displaced_step_prepare): Update.
5743         * infcall.c (call_function_by_hand_dummy): Update.
5744         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5745         * gnu-v3-abi.c (print_one_vtable): Update.
5746         * frame.c (get_prev_frame_always): Update.
5747         * f-valprint.c (info_common_command_for_block): Update.
5748         * exec.c (try_open_exec_file): Update.
5749         * exceptions.c (print_exception, exception_print)
5750         (exception_fprintf, exception_print_same): Update.
5751         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5752         * dwarf-index-cache.c (index_cache::store)
5753         (index_cache::lookup_gdb_index): Update.
5754         * darwin-nat.c (maybe_cache_shell): Update.
5755         * cp-valprint.c (cp_print_value_fields): Update.
5756         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5757         (gcc_cplus_symbol_address): Update.
5758         * compile/compile-c-symbols.c (gcc_convert_symbol)
5759         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5760         * common/selftest.c: Update.
5761         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5762         a std::string.
5763         (exception_try_scope_entry, exception_try_scope_exit): Don't
5764         declare.
5765         (struct exception_try_scope): Remove.
5766         (TRY): Don't use exception_try_scope.
5767         (struct gdb_exception): Add constructor, operator=.
5768         <what>: New method.
5769         (struct gdb_exception_RETURN_MASK_ALL)
5770         (struct gdb_exception_RETURN_MASK_ERROR)
5771         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5772         (struct gdb_quit_bad_alloc): Update.
5773         * common/common-exceptions.c (exception_none): Change
5774         initializer.
5775         (struct catcher) <state, exception>: Initialize inline.
5776         <prev>: Remove member.
5777         (current_catcher): Remove.
5778         (catchers): New global.
5779         (exceptions_state_mc_init): Simplify.
5780         (catcher_pop): Remove.
5781         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5782         (try_scope_depth, exception_try_scope_entry)
5783         (exception_try_scope_exit): Remove.
5784         (throw_exception_sjlj): Update.
5785         (exception_messages, exception_messages_size): Remove.
5786         (throw_it): Simplify.
5787         (gdb_exception_sliced_copy): Remove.
5788         (throw_exception_cxx): Update.
5789         * cli/cli-script.c (script_from_file): Update.
5790         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5791         Update.
5792         * ada-valprint.c (ada_val_print): Update.
5793         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5794         (create_excep_cond_exprs): Update.
5795
5796 2019-04-08  Tom Tromey  <tom@tromey.com>
5797
5798         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5799         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5800         (TRY, CATCH, END_CATCH): Remove some definitions.
5801         * common/common-exceptions.c: Don't use GDB_XCPT.
5802         (catcher_list_size): Remove.
5803         (throw_exception, throw_it): Simplify.
5804
5805 2019-04-05  Tom Tromey  <tom@tromey.com>
5806
5807         Revert the header-sorting patch.
5808         * ft32-tdep.c: Revert.
5809         * frv-tdep.c: Revert.
5810         * frv-linux-tdep.c: Revert.
5811         * frame.c: Revert.
5812         * frame-unwind.c: Revert.
5813         * frame-base.c: Revert.
5814         * fork-child.c: Revert.
5815         * findvar.c: Revert.
5816         * findcmd.c: Revert.
5817         * filesystem.c: Revert.
5818         * filename-seen-cache.h: Revert.
5819         * filename-seen-cache.c: Revert.
5820         * fbsd-tdep.c: Revert.
5821         * fbsd-nat.h: Revert.
5822         * fbsd-nat.c: Revert.
5823         * f-valprint.c: Revert.
5824         * f-typeprint.c: Revert.
5825         * f-lang.c: Revert.
5826         * extension.h: Revert.
5827         * extension.c: Revert.
5828         * extension-priv.h: Revert.
5829         * expprint.c: Revert.
5830         * exec.h: Revert.
5831         * exec.c: Revert.
5832         * exceptions.c: Revert.
5833         * event-top.c: Revert.
5834         * event-loop.c: Revert.
5835         * eval.c: Revert.
5836         * elfread.c: Revert.
5837         * dwarf2read.h: Revert.
5838         * dwarf2read.c: Revert.
5839         * dwarf2loc.c: Revert.
5840         * dwarf2expr.h: Revert.
5841         * dwarf2expr.c: Revert.
5842         * dwarf2-frame.c: Revert.
5843         * dwarf2-frame-tailcall.c: Revert.
5844         * dwarf-index-write.h: Revert.
5845         * dwarf-index-write.c: Revert.
5846         * dwarf-index-common.c: Revert.
5847         * dwarf-index-cache.h: Revert.
5848         * dwarf-index-cache.c: Revert.
5849         * dummy-frame.c: Revert.
5850         * dtrace-probe.c: Revert.
5851         * disasm.h: Revert.
5852         * disasm.c: Revert.
5853         * disasm-selftests.c: Revert.
5854         * dictionary.c: Revert.
5855         * dicos-tdep.c: Revert.
5856         * demangle.c: Revert.
5857         * dcache.h: Revert.
5858         * dcache.c: Revert.
5859         * darwin-nat.h: Revert.
5860         * darwin-nat.c: Revert.
5861         * darwin-nat-info.c: Revert.
5862         * d-valprint.c: Revert.
5863         * d-namespace.c: Revert.
5864         * d-lang.c: Revert.
5865         * ctf.c: Revert.
5866         * csky-tdep.c: Revert.
5867         * csky-linux-tdep.c: Revert.
5868         * cris-tdep.c: Revert.
5869         * cris-linux-tdep.c: Revert.
5870         * cp-valprint.c: Revert.
5871         * cp-support.c: Revert.
5872         * cp-namespace.c: Revert.
5873         * cp-abi.c: Revert.
5874         * corelow.c: Revert.
5875         * corefile.c: Revert.
5876         * continuations.c: Revert.
5877         * completer.h: Revert.
5878         * completer.c: Revert.
5879         * complaints.c: Revert.
5880         * coffread.c: Revert.
5881         * coff-pe-read.c: Revert.
5882         * cli-out.h: Revert.
5883         * cli-out.c: Revert.
5884         * charset.c: Revert.
5885         * c-varobj.c: Revert.
5886         * c-valprint.c: Revert.
5887         * c-typeprint.c: Revert.
5888         * c-lang.c: Revert.
5889         * buildsym.c: Revert.
5890         * buildsym-legacy.c: Revert.
5891         * build-id.h: Revert.
5892         * build-id.c: Revert.
5893         * btrace.c: Revert.
5894         * bsd-uthread.c: Revert.
5895         * breakpoint.h: Revert.
5896         * breakpoint.c: Revert.
5897         * break-catch-throw.c: Revert.
5898         * break-catch-syscall.c: Revert.
5899         * break-catch-sig.c: Revert.
5900         * blockframe.c: Revert.
5901         * block.c: Revert.
5902         * bfin-tdep.c: Revert.
5903         * bfin-linux-tdep.c: Revert.
5904         * bfd-target.c: Revert.
5905         * bcache.c: Revert.
5906         * ax-general.c: Revert.
5907         * ax-gdb.h: Revert.
5908         * ax-gdb.c: Revert.
5909         * avr-tdep.c: Revert.
5910         * auxv.c: Revert.
5911         * auto-load.c: Revert.
5912         * arm-wince-tdep.c: Revert.
5913         * arm-tdep.c: Revert.
5914         * arm-symbian-tdep.c: Revert.
5915         * arm-pikeos-tdep.c: Revert.
5916         * arm-obsd-tdep.c: Revert.
5917         * arm-nbsd-tdep.c: Revert.
5918         * arm-nbsd-nat.c: Revert.
5919         * arm-linux-tdep.c: Revert.
5920         * arm-linux-nat.c: Revert.
5921         * arm-fbsd-tdep.c: Revert.
5922         * arm-fbsd-nat.c: Revert.
5923         * arm-bsd-tdep.c: Revert.
5924         * arch-utils.c: Revert.
5925         * arc-tdep.c: Revert.
5926         * arc-newlib-tdep.c: Revert.
5927         * annotate.h: Revert.
5928         * annotate.c: Revert.
5929         * amd64-windows-tdep.c: Revert.
5930         * amd64-windows-nat.c: Revert.
5931         * amd64-tdep.c: Revert.
5932         * amd64-sol2-tdep.c: Revert.
5933         * amd64-obsd-tdep.c: Revert.
5934         * amd64-obsd-nat.c: Revert.
5935         * amd64-nbsd-tdep.c: Revert.
5936         * amd64-nbsd-nat.c: Revert.
5937         * amd64-nat.c: Revert.
5938         * amd64-linux-tdep.c: Revert.
5939         * amd64-linux-nat.c: Revert.
5940         * amd64-fbsd-tdep.c: Revert.
5941         * amd64-fbsd-nat.c: Revert.
5942         * amd64-dicos-tdep.c: Revert.
5943         * amd64-darwin-tdep.c: Revert.
5944         * amd64-bsd-nat.c: Revert.
5945         * alpha-tdep.c: Revert.
5946         * alpha-obsd-tdep.c: Revert.
5947         * alpha-nbsd-tdep.c: Revert.
5948         * alpha-mdebug-tdep.c: Revert.
5949         * alpha-linux-tdep.c: Revert.
5950         * alpha-linux-nat.c: Revert.
5951         * alpha-bsd-tdep.c: Revert.
5952         * alpha-bsd-nat.c: Revert.
5953         * aix-thread.c: Revert.
5954         * agent.c: Revert.
5955         * addrmap.c: Revert.
5956         * ada-varobj.c: Revert.
5957         * ada-valprint.c: Revert.
5958         * ada-typeprint.c: Revert.
5959         * ada-tasks.c: Revert.
5960         * ada-lang.c: Revert.
5961         * aarch64-tdep.c: Revert.
5962         * aarch64-ravenscar-thread.c: Revert.
5963         * aarch64-newlib-tdep.c: Revert.
5964         * aarch64-linux-tdep.c: Revert.
5965         * aarch64-linux-nat.c: Revert.
5966         * aarch64-fbsd-tdep.c: Revert.
5967         * aarch64-fbsd-nat.c: Revert.
5968         * aarch32-linux-nat.c: Revert.
5969
5970 2019-04-05  Tom Tromey  <tom@tromey.com>
5971
5972         * ft32-tdep.c: Sort headers.
5973         * frv-tdep.c: Sort headers.
5974         * frv-linux-tdep.c: Sort headers.
5975         * frame.c: Sort headers.
5976         * frame-unwind.c: Sort headers.
5977         * frame-base.c: Sort headers.
5978         * fork-child.c: Sort headers.
5979         * findvar.c: Sort headers.
5980         * findcmd.c: Sort headers.
5981         * filesystem.c: Sort headers.
5982         * filename-seen-cache.h: Sort headers.
5983         * filename-seen-cache.c: Sort headers.
5984         * fbsd-tdep.c: Sort headers.
5985         * fbsd-nat.h: Sort headers.
5986         * fbsd-nat.c: Sort headers.
5987         * f-valprint.c: Sort headers.
5988         * f-typeprint.c: Sort headers.
5989         * f-lang.c: Sort headers.
5990         * extension.h: Sort headers.
5991         * extension.c: Sort headers.
5992         * extension-priv.h: Sort headers.
5993         * expprint.c: Sort headers.
5994         * exec.h: Sort headers.
5995         * exec.c: Sort headers.
5996         * exceptions.c: Sort headers.
5997         * event-top.c: Sort headers.
5998         * event-loop.c: Sort headers.
5999         * eval.c: Sort headers.
6000         * elfread.c: Sort headers.
6001         * dwarf2read.h: Sort headers.
6002         * dwarf2read.c: Sort headers.
6003         * dwarf2loc.c: Sort headers.
6004         * dwarf2expr.h: Sort headers.
6005         * dwarf2expr.c: Sort headers.
6006         * dwarf2-frame.c: Sort headers.
6007         * dwarf2-frame-tailcall.c: Sort headers.
6008         * dwarf-index-write.h: Sort headers.
6009         * dwarf-index-write.c: Sort headers.
6010         * dwarf-index-common.c: Sort headers.
6011         * dwarf-index-cache.h: Sort headers.
6012         * dwarf-index-cache.c: Sort headers.
6013         * dummy-frame.c: Sort headers.
6014         * dtrace-probe.c: Sort headers.
6015         * disasm.h: Sort headers.
6016         * disasm.c: Sort headers.
6017         * disasm-selftests.c: Sort headers.
6018         * dictionary.c: Sort headers.
6019         * dicos-tdep.c: Sort headers.
6020         * demangle.c: Sort headers.
6021         * dcache.h: Sort headers.
6022         * dcache.c: Sort headers.
6023         * darwin-nat.h: Sort headers.
6024         * darwin-nat.c: Sort headers.
6025         * darwin-nat-info.c: Sort headers.
6026         * d-valprint.c: Sort headers.
6027         * d-namespace.c: Sort headers.
6028         * d-lang.c: Sort headers.
6029         * ctf.c: Sort headers.
6030         * csky-tdep.c: Sort headers.
6031         * csky-linux-tdep.c: Sort headers.
6032         * cris-tdep.c: Sort headers.
6033         * cris-linux-tdep.c: Sort headers.
6034         * cp-valprint.c: Sort headers.
6035         * cp-support.c: Sort headers.
6036         * cp-namespace.c: Sort headers.
6037         * cp-abi.c: Sort headers.
6038         * corelow.c: Sort headers.
6039         * corefile.c: Sort headers.
6040         * continuations.c: Sort headers.
6041         * completer.h: Sort headers.
6042         * completer.c: Sort headers.
6043         * complaints.c: Sort headers.
6044         * coffread.c: Sort headers.
6045         * coff-pe-read.c: Sort headers.
6046         * cli-out.h: Sort headers.
6047         * cli-out.c: Sort headers.
6048         * charset.c: Sort headers.
6049         * c-varobj.c: Sort headers.
6050         * c-valprint.c: Sort headers.
6051         * c-typeprint.c: Sort headers.
6052         * c-lang.c: Sort headers.
6053         * buildsym.c: Sort headers.
6054         * buildsym-legacy.c: Sort headers.
6055         * build-id.h: Sort headers.
6056         * build-id.c: Sort headers.
6057         * btrace.c: Sort headers.
6058         * bsd-uthread.c: Sort headers.
6059         * breakpoint.h: Sort headers.
6060         * breakpoint.c: Sort headers.
6061         * break-catch-throw.c: Sort headers.
6062         * break-catch-syscall.c: Sort headers.
6063         * break-catch-sig.c: Sort headers.
6064         * blockframe.c: Sort headers.
6065         * block.c: Sort headers.
6066         * bfin-tdep.c: Sort headers.
6067         * bfin-linux-tdep.c: Sort headers.
6068         * bfd-target.c: Sort headers.
6069         * bcache.c: Sort headers.
6070         * ax-general.c: Sort headers.
6071         * ax-gdb.h: Sort headers.
6072         * ax-gdb.c: Sort headers.
6073         * avr-tdep.c: Sort headers.
6074         * auxv.c: Sort headers.
6075         * auto-load.c: Sort headers.
6076         * arm-wince-tdep.c: Sort headers.
6077         * arm-tdep.c: Sort headers.
6078         * arm-symbian-tdep.c: Sort headers.
6079         * arm-pikeos-tdep.c: Sort headers.
6080         * arm-obsd-tdep.c: Sort headers.
6081         * arm-nbsd-tdep.c: Sort headers.
6082         * arm-nbsd-nat.c: Sort headers.
6083         * arm-linux-tdep.c: Sort headers.
6084         * arm-linux-nat.c: Sort headers.
6085         * arm-fbsd-tdep.c: Sort headers.
6086         * arm-fbsd-nat.c: Sort headers.
6087         * arm-bsd-tdep.c: Sort headers.
6088         * arch-utils.c: Sort headers.
6089         * arc-tdep.c: Sort headers.
6090         * arc-newlib-tdep.c: Sort headers.
6091         * annotate.h: Sort headers.
6092         * annotate.c: Sort headers.
6093         * amd64-windows-tdep.c: Sort headers.
6094         * amd64-windows-nat.c: Sort headers.
6095         * amd64-tdep.c: Sort headers.
6096         * amd64-sol2-tdep.c: Sort headers.
6097         * amd64-obsd-tdep.c: Sort headers.
6098         * amd64-obsd-nat.c: Sort headers.
6099         * amd64-nbsd-tdep.c: Sort headers.
6100         * amd64-nbsd-nat.c: Sort headers.
6101         * amd64-nat.c: Sort headers.
6102         * amd64-linux-tdep.c: Sort headers.
6103         * amd64-linux-nat.c: Sort headers.
6104         * amd64-fbsd-tdep.c: Sort headers.
6105         * amd64-fbsd-nat.c: Sort headers.
6106         * amd64-dicos-tdep.c: Sort headers.
6107         * amd64-darwin-tdep.c: Sort headers.
6108         * amd64-bsd-nat.c: Sort headers.
6109         * alpha-tdep.c: Sort headers.
6110         * alpha-obsd-tdep.c: Sort headers.
6111         * alpha-nbsd-tdep.c: Sort headers.
6112         * alpha-mdebug-tdep.c: Sort headers.
6113         * alpha-linux-tdep.c: Sort headers.
6114         * alpha-linux-nat.c: Sort headers.
6115         * alpha-bsd-tdep.c: Sort headers.
6116         * alpha-bsd-nat.c: Sort headers.
6117         * aix-thread.c: Sort headers.
6118         * agent.c: Sort headers.
6119         * addrmap.c: Sort headers.
6120         * ada-varobj.c: Sort headers.
6121         * ada-valprint.c: Sort headers.
6122         * ada-typeprint.c: Sort headers.
6123         * ada-tasks.c: Sort headers.
6124         * ada-lang.c: Sort headers.
6125         * aarch64-tdep.c: Sort headers.
6126         * aarch64-ravenscar-thread.c: Sort headers.
6127         * aarch64-newlib-tdep.c: Sort headers.
6128         * aarch64-linux-tdep.c: Sort headers.
6129         * aarch64-linux-nat.c: Sort headers.
6130         * aarch64-fbsd-tdep.c: Sort headers.
6131         * aarch64-fbsd-nat.c: Sort headers.
6132         * aarch32-linux-nat.c: Sort headers.
6133
6134 2019-04-04  Tom Tromey  <tom@tromey.com>
6135
6136         * varobj.c (varobj_create): Update.
6137         * rust-exp.y (struct rust_parser) <update_innermost_block,
6138         lookup_symbol>: New methods.
6139         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6140         Rename.
6141         (rust_parser::rust_lookup_type)
6142         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6143         * printcmd.c (display_command, do_one_display): Update.
6144         * parser-defs.h (struct parser_state) <parser_state>: Add
6145         "tracker" parameter.
6146         (block_tracker): New member.
6147         (class innermost_block_tracker) <innermost_block_tracker>: Add
6148         "types" parameter.
6149         <reset>: Remove method.
6150         (innermost_block): Don't declare.
6151         (null_post_parser): Update.
6152         * parse.c (innermost_block): Remove global.
6153         (write_dollar_variable): Update.
6154         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6155         Remove "tracker_types" parameter.
6156         (parse_expression): Add "tracker" parameter.
6157         (parse_expression_for_completion): Update.
6158         (null_post_parser): Add "tracker" parameter.
6159         * p-exp.y: Update rules.
6160         * m2-exp.y: Update rules.
6161         * language.h (struct language_defn) <la_post_parser>: Add
6162         "tracker" parameter.
6163         * go-exp.y: Update rules.
6164         * f-exp.y: Update rules.
6165         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6166         parameter.
6167         * d-exp.y: Update rules.
6168         * c-exp.y: Update rules.
6169         * breakpoint.c (set_breakpoint_condition): Create an
6170         innermost_block_tracker.
6171         (watch_command_1): Likewise.
6172         * ada-lang.c (resolve): Add "tracker" parameter.
6173         (resolve_subexp): Likewise.
6174         * ada-exp.y (write_var_from_sym): Update.
6175
6176 2019-04-04  Tom Tromey  <tom@tromey.com>
6177
6178         * type-stack.h: New file.
6179         * type-stack.c: New file.
6180         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6181         type-stack.h.
6182         (insert_into_type_stack, insert_type, push_type, push_type_int)
6183         (insert_type_address_space, pop_type, pop_type_int)
6184         (pop_typelist, pop_type_stack, append_type_stack)
6185         (push_type_stack, get_type_stack, push_typelist)
6186         (follow_type_instance_flags, follow_types): Don't declare.
6187         * parse.c (type_stack): Remove global.
6188         (parse_exp_in_context): Update.
6189         (insert_into_type_stack, insert_type, push_type, push_type_int)
6190         (insert_type_address_space, pop_type, pop_type_int)
6191         (pop_typelist, pop_type_stack, append_type_stack)
6192         (push_type_stack, get_type_stack, push_typelist)
6193         (follow_type_instance_flags, follow_types): Remove (moved to
6194         type-stack.c).
6195         * f-exp.y (type_stack): New global.
6196         Update rules.
6197         (push_kind_type, f_parse): Update.
6198         * d-exp.y (type_stack): New global.
6199         Update rules.
6200         (d_parse): Update.
6201         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6202         Update rules.
6203         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6204         (HFILES_NO_SRCDIR): Add type-stack.h.
6205
6206 2019-04-04  Tom Tromey  <tom@tromey.com>
6207
6208         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6209         (rust_parser::convert_ast_to_expression, rust_parse)
6210         (rust_lex_test_completion, rust_lex_tests): Update.
6211         * parser-defs.h (struct expr_completion_state): New.
6212         (struct parser_state) <parser_state>: Add completion parameter.
6213         <mark_struct_expression, mark_completion_tag>: New methods.
6214         <parse_completion, m_completion_state>: New members.
6215         (prefixify_expression, null_post_parser): Update.
6216         (mark_struct_expression, mark_completion_tag): Don't declare.
6217         * parse.c (parse_completion, expout_last_struct)
6218         (expout_tag_completion_type, expout_completion_name): Remove
6219         globals.
6220         (parser_state::mark_struct_expression)
6221         (parser_state::mark_completion_tag): Now methods.
6222         (prefixify_expression): Add last_struct parameter.
6223         (prefixify_subexp): Likewise.
6224         (parse_exp_1): Update.
6225         (parse_exp_in_context): Add cstate parameter.  Update.
6226         (parse_expression_for_completion): Create an
6227         expr_completion_state.
6228         (null_post_parser): Add "completion" parameter.
6229         * p-exp.y: Update rules.
6230         (yylex): Update.
6231         * language.h (struct language_defn) <la_post_parser>: Add
6232         "completing" parameter.
6233         * go-exp.y: Update rules.
6234         (lex_one_token): Update.
6235         * expression.h (parse_completion): Don't declare.
6236         * d-exp.y: Update rules.
6237         (lex_one_token): Update rules.
6238         * c-exp.y: Update rules.
6239         (lex_one_token): Update.
6240         * ada-lang.c (resolve): Add "parse_completion" parameter.
6241         (resolve_subexp): Likewise.
6242         (ada_resolve_function): Likewise.
6243
6244 2019-04-04  Tom Tromey  <tom@tromey.com>
6245
6246         * parser-defs.h (struct parser_state) <start_arglist,
6247         end_arglist>: New methods.
6248         <arglist_len, m_funcall_chain>: New members.
6249         (arglist_len, start_arglist, end_arglist): Don't declare.
6250         * parse.c (arglist_len, funcall_chain): Remove global.
6251         (start_arglist, end_arglist): Remove functions.
6252         (parse_exp_in_context): Update.
6253         * p-exp.y: Update rules.
6254         * m2-exp.y: Update rules.
6255         * go-exp.y: Update rules.
6256         * f-exp.y: Update rules.
6257         * d-exp.y: Update rules.
6258         * c-exp.y: Update rules.
6259
6260 2019-04-04  Tom Tromey  <tom@tromey.com>
6261
6262         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6263         lex_operator, push_back>: New methods.
6264         Update all rules.
6265         (rust_parser::lex_hex, lex_escape): Rename and update.
6266         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6267         (rust_parser::lex_operator): Rename and update.
6268         (rust_parser::lex_number, rustyylex, rustyyerror)
6269         (rust_lex_test_init, rust_lex_test_sequence)
6270         (rust_lex_test_push_back, rust_lex_tests): Update.
6271         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6272         parameter.
6273         <lexptr, prev_lexptr>: New members.
6274         (lexptr, prev_lexptr): Don't declare.
6275         * parse.c (lexptr, prev_lexptr): Remove globals.
6276         (parse_exp_in_context): Update.
6277         * p-exp.y (yylex, yyerror): Update.
6278         * m2-exp.y (parse_number, yylex, yyerror): Update.
6279         * go-exp.y (lex_one_token, yyerror): Update.
6280         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6281         * d-exp.y (lex_one_token, yyerror): Update.
6282         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6283         (lex_one_token, yyerror): Update.
6284         * ada-lex.l (YY_INPUT): Update.
6285         (rewind_to_char): Update.
6286         * ada-exp.y (yyerror): Update.
6287
6288 2019-04-04  Tom Tromey  <tom@tromey.com>
6289
6290         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6291         * parser-defs.h (struct parser_state) <parser_state>: Add new
6292         parameter.
6293         <comma_terminates>: New member.
6294         (comma_terminates): Don't declare global.
6295         * parse.c (comma_terminates): Remove global.
6296         (parse_exp_in_context): Update.
6297         * p-exp.y (yylex): Update.
6298         * m2-exp.y (yylex): Update.
6299         * go-exp.y (lex_one_token): Update.
6300         * f-exp.y (yylex): Update.
6301         * d-exp.y (lex_one_token): Update.
6302         * c-exp.y (lex_one_token): Update.
6303         * ada-lex.l: Update.
6304
6305 2019-04-04  Tom Tromey  <tom@tromey.com>
6306
6307         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6308         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6309         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6310         * parser-defs.h (paren_depth): Don't declare.
6311         * parse.c (paren_depth): Remove global.
6312         (parse_exp_in_context): Update.
6313         * p-exp.y (paren_depth): New global.
6314         (pascal_parse): Initialize it.
6315         * m2-exp.y (paren_depth): New global.
6316         (m2_parse): Initialize it.
6317         * go-exp.y (paren_depth): New global.
6318         (go_parse): Initialize it.
6319         * f-exp.y (paren_depth): New global.
6320         (f_parse): Initialize it.
6321         * d-exp.y (paren_depth): New global.
6322         (d_parse): Initialize it.
6323         * c-exp.y (paren_depth): New global.
6324         (c_parse): Initialize it.
6325         * ada-lex.l (paren_depth): New global.
6326         (lexer_init): Initialize it.
6327
6328 2019-04-04  Tom Tromey  <tom@tromey.com>
6329
6330         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6331         (rust_parser::convert_ast_to_type)
6332         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6333         * parser-defs.h (struct parser_state) <parser_state>: Add
6334         parameters.  Initialize new members.
6335         <expression_context_block, expression_context_pc>: New members.
6336         * parse.c (expression_context_block, expression_context_pc):
6337         Remove globals.
6338         (parse_exp_in_context): Update.
6339         * p-exp.y: Update all rules.
6340         (yylex): Update.
6341         * m2-exp.y: Update all rules.
6342         (yylex): Update.
6343         * go-exp.y (yylex): Update.
6344         * f-exp.y (yylex): Update.
6345         * d-exp.y: Update all rules.
6346         (yylex): Update.
6347         * c-exp.y: Update all rules.
6348         (lex_one_token, classify_name, yylex, c_parse): Update.
6349         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6350
6351 2019-04-04  Tom Tromey  <tom@tromey.com>
6352
6353         * gdbarch.h, gdbarch.c: Rebuild.
6354         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6355         * stap-probe.h:
6356         (struct stap_parse_info): Replace "parser_state" with
6357         "expr_builder".
6358         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6359         (parser_state): New class.
6360         * parse.c (expr_builder): Rename.
6361         (expr_builder::release): Rename.
6362         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6363         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6364         (write_exp_elt_longcst, write_exp_elt_floatcst)
6365         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6366         (write_exp_string_vector, write_exp_bitstring)
6367         (write_exp_msymbol, mark_struct_expression)
6368         (write_dollar_variable)
6369         (insert_type_address_space, increase_expout_size): Replace
6370         "parser_state" with "expr_builder".
6371         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6372         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6373         "parser_state" with "expr_builder".
6374
6375 2019-04-04  Tom Tromey  <tom@tromey.com>
6376
6377         * rust-exp.y: Replace "parse_language" with method call.
6378         * p-exp.y:
6379         (yylex): Replace "parse_language" with method call.
6380         * m2-exp.y:
6381         (yylex): Replace "parse_language" with method call.
6382         * go-exp.y (classify_name): Replace "parse_language" with method
6383         call.
6384         * f-exp.y (yylex): Replace "parse_language" with method call.
6385         * d-exp.y (lex_one_token): Replace "parse_language" with method
6386         call.
6387         * c-exp.y:
6388         (lex_one_token, classify_name, yylex): Replace "parse_language"
6389         with method call.
6390         * ada-exp.y (find_primitive_type, type_char)
6391         (type_system_address): Replace "parse_language" with method call.
6392
6393 2019-04-04  Tom Tromey  <tom@tromey.com>
6394
6395         * rust-exp.y: Replace "parse_gdbarch" with method call.
6396         * parse.c (write_dollar_variable, insert_type_address_space):
6397         Replace "parse_gdbarch" with method call.
6398         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6399         call.
6400         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6401         call.
6402         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6403         "parse_gdbarch" with method call.
6404         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6405         with method call.
6406         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6407         "parse_gdbarch" with method call.
6408         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6409         "parse_gdbarch" with method call.
6410         * c-exp.y (parse_type, parse_number, classify_name): Replace
6411         "parse_gdbarch" with method call.
6412         * ada-lex.l: Replace "parse_gdbarch" with method call.
6413         * ada-exp.y (parse_type, find_primitive_type, type_char)
6414         (type_system_address): Replace "parse_gdbarch" with method call.
6415
6416 2019-04-04  Tom Tromey  <tom@tromey.com>
6417
6418         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6419         * stap-probe.c (stap_parse_argument): Update.
6420         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6421         initial_size parameter.
6422         * rust-exp.y (rust_lex_tests): Update.
6423         * parse.c (parser_state): Update.
6424         (parse_exp_in_context): Update.
6425         * parser-defs.h (struct parser_state) <parser_state>: Remove
6426         "initial_size" parameter.
6427
6428 2019-04-04  Tom Tromey  <tom@tromey.com>
6429
6430         * parser-defs.h (increase_expout_size): Don't declare.
6431         * parse.c (increase_expout_size): Now static.
6432
6433 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6434
6435         * gnu-nat.c (gnu_nat_target::wait): Fix
6436         target_waitstatus_to_string call.
6437
6438 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6439
6440         * eval.c (evaluate_subexp_standard): Handle internal functions
6441         during Fortran function call handling.
6442
6443 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6444
6445         * NEWS: Mention new internal functions.
6446         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6447         (read_base_type): Use dwarf2_init_complex_target_type.
6448         * value.c (creal_internal_fn): New function.
6449         (cimag_internal_fn): New function.
6450         (_initialize_values): Register new internal functions.
6451
6452 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6453
6454         * infrun.c (stop_all_threads): If debug_infrun, always
6455         trace the wait status after wait_one, using
6456         target_waitstatus_to_string and target_pid_to_str.
6457         (handle_inferior_event): Replace various trace of
6458         wait status kind by a single trace.
6459         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6460         wait status kind image by target_waitstatus_to_string.
6461         * target/waitstatus.c (target_waitstatus_to_string): Fix
6462         obsolete comment.
6463
6464 2019-04-01  Tom Tromey  <tromey@adacore.com>
6465
6466         PR symtab/23331:
6467         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6468
6469 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6470             Pedro Alves  <palves@redhat.com>
6471
6472         * top.c (quit_force): Call 'finalize_values'.
6473         * value.c (finalize_values): New function.
6474         * value.h (finalize_values): Declare.
6475
6476 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6477
6478         * NEWS: Announce $_gdb_major and $_gdb_minor.
6479
6480         * top.c (init_gdb_version_vars): New function.
6481         (gdb_init): Call init_gdb_version_vars.
6482
6483 2019-03-29  Tom Tromey  <tromey@adacore.com>
6484
6485         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6486         help text.  Remove dead code.
6487
6488 2019-03-29  Keith Seitz  <keiths@redhat.com>
6489
6490         From Siddhesh Poyarekar:
6491         * f-lang.h (f77_get_upperbound): Return LONGEST.
6492         (f77_get_lowerbound): Likewise.
6493         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6494         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6495         print them.
6496         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6497         plongest to format print it.
6498         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6499         (f77_get_upperbound): Likewise.
6500         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6501         LOWER_BOUND to LONGEST.
6502         (f77_create_arrayprint_offset_tbl): Likewise.
6503
6504 2019-03-29  Keith Seitz  <keiths@redhat.com>
6505
6506         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6507         %s/pulongest for TYPE_LENGTH instead of %d in format
6508         strings.
6509         * ada-typerint.c (ada_print_type): Likewise.
6510         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6511         * compile/compile-c-support.c (generate_register_struct): Likewise.
6512         * gdbtypes.c (recursive_dump_type): Likewise.
6513         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6514         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6515         instead of %d in format strings.
6516         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6517         to std::min to ULONGEST.
6518         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6519         instead of %d in format strings.
6520         * tracepoint.c (info_scope_command): Likewise.
6521         * typeprint.c (print_offset_data::update)
6522         (print_offset_data::finish): Likewise.
6523         * xtensa-tdep.c (xtensa_store_return_value)
6524         (xtensa_push_dummy_call): Likewise.
6525
6526 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6527
6528         * windows-nat.c (display_selector): Fixed format specifications
6529         for 64-bit Cygwin.
6530
6531 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6532
6533         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6534
6535 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6536
6537         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6538         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6539         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6540         (nios2_linux_init_abi): Install it.
6541
6542 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6543
6544         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6545
6546 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6547
6548         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6549
6550 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6551             Tom Tromey  <tromey@adacore.com>
6552
6553         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6554
6555 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6556
6557         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6558         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6559         method to compute the bounds of range types. Also print "[evaluated]"
6560         if the bounds' values come from a dynamic evaluation.
6561
6562 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6563
6564         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6565         whitespace when pretty printing is on.
6566
6567 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6568
6569         * ppc-linux-nat.c: Add include.
6570
6571 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6572
6573         * NEWS: Mention AArch64 Pointer Authentication.
6574
6575 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6576
6577         * arm-linux-nat.c: Add include.
6578
6579 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6580
6581         * source-cache.c (source_cache::get_source_lines): Re-read
6582         fullname after calling open_source_file.
6583
6584 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6585
6586         * NEWS: Mention TLS support for FreeBSD.
6587
6588 2019-03-25  Tom Tromey  <tromey@adacore.com>
6589
6590         * minsyms.c (BUNCH_SIZE): Update comment.
6591         (~minimal_symbol_reader): Remove old comment.
6592         (compact_minimal_symbols): Update comment.
6593         (minimal_symbol_reader::install): Remove old comment.  Update
6594         other comments.
6595
6596 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6597
6598         * s390-linux-nat.c: Add include.
6599
6600 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6601
6602         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6603         Call linux_get_hwcap.
6604         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6605         Likewise.
6606         (aarch64_linux_get_hwcap): Remove function.
6607         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6608         declaration.
6609         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6610         linux_get_hwcap.
6611         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6612         * linux-tdep.c (linux_get_hwcap): Add function.
6613         (linux_get_hwcap2): Likewise.
6614         * linux-tdep.h (linux_get_hwcap): Add declaration.
6615         (linux_get_hwcap2): Likewise.
6616         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6617         (ppc_linux_get_hwcap2): Likewise.
6618         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6619         linux_get_hwcap.
6620         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6621         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6622         (ppc_linux_nat_target::read_description): Likewise.
6623         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6624         * s390-linux-nat.c: Likewise.
6625         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6626
6627 2019-03-24  Tom Tromey  <tom@tromey.com>
6628
6629         * ada-lang.c (standard_lookup): Simplify initialization.
6630         (ada_lookup_symbol_nonlocal): Simplify return.
6631         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6632         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6633         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6634         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6635         initialization.
6636         * solib.c (solib_global_lookup): Simplify.
6637         * symtab.c (null_block_symbol): Remove.
6638         (symbol_cache_lookup): Simplify returns.
6639         (lookup_language_this): Simplify returns.
6640         (lookup_symbol_aux): Simplify return.
6641         (lookup_local_symbol): Simplify returns.
6642         (lookup_global_symbol_from_objfile): Simplify return.
6643         (lookup_symbol_in_objfile_symtabs)
6644         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6645         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6646         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6647         * cp-namespace.c (cp_lookup_bare_symbol)
6648         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6649         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6650         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6651         (cp_lookup_symbol_via_imports): Simplify initialization.
6652         (find_symbol_in_baseclass): Likewise.
6653         * symtab.h (null_block_symbol): Remove.
6654         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6655         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6656         (d_lookup_symbol_module): Likewise.
6657         (find_symbol_in_baseclass): Simplify initialization.
6658
6659 2019-03-24  Tom Tromey  <tom@tromey.com>
6660
6661         * expression.h: Don't include symtab.h.
6662         (struct block): Forward declare.
6663
6664 2019-03-24  Tom Tromey  <tom@tromey.com>
6665
6666         * c-exp.y (typebase): Remove casts.
6667         * gdbtypes.c (lookup_unsigned_typename, )
6668         (lookup_signed_typename): Remove cast.
6669         * eval.c (parse_to_comma_and_eval): Remove cast.
6670         * parse.c (write_dollar_variable): Remove cast.
6671         * block.h (struct block) <superblock>: Now const.
6672         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6673         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6674         (map_block): Make "block" const.
6675         * symfile.h (struct quick_symbol_functions)
6676         <map_matching_symbols>: Constify block argument to "callback".
6677         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6678         const.
6679         (find_pc_sect_compunit_symtab): Make "b" const.
6680         (find_symbol_at_address): Likewise.
6681         (search_symbols): Likewise.
6682         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6683         (dw2_debug_names_lookup_symbol): Likewise.
6684         (dw2_map_matching_symbols): Update.
6685         * p-valprint.c (pascal_val_print): Remove "block".
6686         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6687         (aux_add_nonlocal_symbols): Make "block" const.
6688         (resolve_subexp): Remove cast.
6689         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6690         const.
6691         (iterate_over_file_blocks): Likewise.
6692         * f-exp.y (%union) <bval>: Remove.
6693         * coffread.c (patch_opaque_types): Make "b" const.
6694         * spu-tdep.c (spu_catch_start): Make "block" const.
6695         * c-valprint.c (print_unpacked_pointer): Remove "block".
6696         * symmisc.c (dump_symtab_1): Make "b" const.
6697         (block_depth): Make "block" const.
6698         * d-exp.y (%union) <bval>: Remove.
6699         * cp-support.h (cp_lookup_rtti_type): Update.
6700         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6701         * psymtab.c (psym_lookup_symbol): Make "block" const.
6702         (maintenance_check_psymtabs): Make "b" const.
6703         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6704         (enumerate_locals, enumerate_args): Update.
6705         * python/py-symtab.c (stpy_global_block): Make "block" const.
6706         (stpy_static_block): Likewise.
6707         * inline-frame.c (block_starting_point_at): Make "new_block"
6708         const.
6709         * block.c (find_block_in_blockvector): Make return type const.
6710         (blockvector_for_pc_sect): Make "b" const.
6711         (find_block_in_blockvector): Make "b" const.
6712
6713 2019-03-23  Tom Tromey  <tom@tromey.com>
6714
6715         * varobj.c (varobj_create): Update.
6716         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6717         * printcmd.c (display_command, do_one_display): Don't reset
6718         innermost_block.
6719         * parser-defs.h (enum innermost_block_tracker_type): Move to
6720         expression.h.
6721         (innermost_block): Update comment.
6722         * parse.c (parse_exp_1): Add tracker_types parameter.
6723         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6724         tracker_types parameter.  Reset innermost_block.
6725         (parse_exp_in_context): Remove.
6726         (parse_expression_for_completion): Update.
6727         * objfiles.c (~objfile): Don't reset expression_context_block or
6728         innermost_block.
6729         * expression.h (enum innermost_block_tracker_type): Move from
6730         parser-defs.h.
6731         (parse_exp_1): Add tracker_types parameter.
6732         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6733         reset innermost_block.
6734
6735 2019-03-23  Tom Tromey  <tom@tromey.com>
6736
6737         * objfiles.h: Include bcache.h.
6738
6739 2019-03-23  Tom Tromey  <tom@tromey.com>
6740
6741         * linespec.c (get_current_search_block): Use
6742         scoped_restore_current_language.
6743         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6744
6745 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6746             Jiong Wang  <jiong.wang@arm.com>
6747
6748         * aarch64-linux-tdep.c
6749         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6750         section.
6751         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6752
6753 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6754             Jiong Wang  <jiong.wang@arm.com>
6755
6756         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6757         instructions.
6758         (aarch64_analyze_prologue_test): Add PACIASP test.
6759         (aarch64_prologue_prev_register): Unmask PC value.
6760
6761 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6762             Jiong Wang  <jiong.wang@arm.com>
6763
6764         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6765         (aarch64_dwarf2_prev_register): Unmask PC value.
6766         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6767         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6768         DW_CFA_AARCH64_negate_ra_state.
6769         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6770
6771 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6772             Jiong Wang  <jiong.wang@arm.com>
6773
6774         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6775         registers.
6776         (aarch64_pseudo_register_name): Likewise.
6777         (aarch64_pseudo_register_type): Likewise.
6778         (aarch64_pseudo_register_reggroup_p): Likewise.
6779         (aarch64_gdbarch_init): Add pauth registers.
6780         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6781         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6782         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6783         (struct gdbarch_tdep): Add regnum for ra_state.
6784
6785 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6786             Jiong Wang  <jiong.wang@arm.com>
6787
6788         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6789
6790 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6791             Jiong Wang  <jiong.wang@arm.com>
6792
6793         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6794         function.
6795         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6796         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6797         (aarch64_gdbarch_init): Add puth registers.
6798         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6799         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6800         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6801
6802 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6803             Jiong Wang  <jiong.wang@arm.com>
6804
6805         * aarch64-linux-nat.c
6806         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6807         * aarch64-linux-tdep.c
6808         (aarch64_linux_core_read_description): Likewise.
6809         (aarch64_linux_get_hwcap): New function.
6810         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6811         (aarch64_linux_get_hwcap): New declaration.
6812
6813 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6814             Jiong Wang  <jiong.wang@arm.com>
6815
6816         * aarch64-linux-nat.c
6817         (aarch64_linux_nat_target::read_description): Add pauth param.
6818         * aarch64-linux-tdep.c
6819         (aarch64_linux_core_read_description): Likewise.
6820         * aarch64-tdep.c (struct target_desc): Add in pauth.
6821         (aarch64_read_description): Add pauth param.
6822         (aarch64_gdbarch_init): Likewise.
6823         * aarch64-tdep.h (aarch64_read_description): Likewise.
6824         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6825         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6826         * features/Makefile: Add new files.
6827         * features/aarch64-pauth.c: New file.
6828         * features/aarch64-pauth.xml: New file.
6829
6830 2019-03-20  Tom Tromey  <tromey@adacore.com>
6831
6832         * infrun.c (handle_inferior_event): Rename from
6833         handle_inferior_event_1.  Create a scoped_value_mark.
6834         (handle_inferior_event): Remove.
6835
6836 2019-03-19  Tom Tromey  <tromey@adacore.com>
6837
6838         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6839         * infrun.h (print_stop_event): Add "displays" parameter.
6840         * infrun.c (print_stop_event): Add "displays" parameter.
6841
6842 2019-03-19  Pedro Alves  <palves@redhat.com>
6843
6844         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6845         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6846         to -1.  Fix TABs vs spaces.
6847         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6848         * tui/tui-out.h (tui_ui_out) Add intro comments.
6849         <m_line, m_start_of_line>: In-class initialize, and add describing
6850         comment.
6851
6852 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6853
6854         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6855         variable names.
6856         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6857
6858 2019-03-18  Pedro Alves  <palves@redhat.com>
6859             Eli Zaretskii <eliz@gnu.org>
6860
6861         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6862         m_line and m_start_of_line.
6863
6864 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6865
6866         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6867         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6868         it returns a newline.  This fixes a regression in TU mode, whereby
6869         the next line is output on the same screen line as the user input.
6870
6871 2019-03-18  Tom Tromey  <tromey@adacore.com>
6872
6873         * minsyms.c (minimal_symbol_reader::install): Remove call to
6874         obstack_blank.
6875
6876 2019-03-18  Pedro Alves  <palves@redhat.com>
6877
6878         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6879         New globals.
6880         (apply_style): New, factored out from ...
6881         (apply_ansi_escape): ... this.  Handle reverse video mode.
6882         (tui_set_reverse_mode): New function.
6883         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6884         * tui/tui-winsource.c (tui_show_source_line): Use
6885         tui_set_reverse_mode instead of setting A_STANDOUT.
6886         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6887         New setter methods.
6888
6889 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6890
6891         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6892         Handle tabs.
6893
6894 2019-03-18  Tom Tromey  <tromey@adacore.com>
6895
6896         * ada-lang.c (empty_array): Add "high" parameter.
6897         (ada_evaluate_subexp): Update.
6898
6899 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6900
6901         * unittests/string_view-selftests.c: Define
6902         _initialize_string_view_selftests unconditionally.
6903
6904 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6905
6906         PR gdb/24350
6907         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6908
6909 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6910
6911         PR gdb/24351
6912         * windows-nat.c (display_selector): Fix format specifiers.
6913
6914 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6915
6916         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6917         tui_refill_source_window instead of tui_refresh_win, to update the
6918         current execution line.  This fixes redisplay of the current line
6919         when stepping through the code with "next" or "step".
6920
6921 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6922
6923         * source-cache.c (source_cache::get_source_lines): Call
6924         find_source_lines to initialize s->nlines.  This fixes vertical
6925         scrolling of TUI source window when the DOWN arrow is pressed.
6926
6927 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6928
6929         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6930         linux-thread-db.c (_initialize_thread_db): Likewise.
6931
6932 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6933
6934         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6935         wclrtoeol in tui_show_source_line".  This reverts changes made in
6936         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6937
6938 2019-03-15  Tom Tromey  <tom@tromey.com>
6939
6940         * symtab.h (struct minimal_symbol): Derive from
6941         general_symbol_info.
6942         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6943         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6944         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6945         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6946         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6947         (MSYMBOL_SEARCH_NAME): Update.
6948         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6949         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6950         * minsyms.c (minimal_symbol_reader::record_full): Update.
6951
6952 2019-03-15  Tom Tromey  <tom@tromey.com>
6953
6954         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6955
6956 2019-03-15  Tom Tromey  <tom@tromey.com>
6957
6958         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6959         unique_xmalloc_ptr.
6960         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6961         Update.
6962         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6963         (build_minimal_symbol_hash_tables)
6964         (minimal_symbol_reader::install): Update.
6965
6966 2019-03-15  Tom Tromey  <tom@tromey.com>
6967
6968         * symtab.c (create_demangled_names_hash): Update.
6969         (symbol_set_names): Update.
6970         * objfiles.h (struct objfile_per_bfd_storage)
6971         <demangled_names_hash>: Now an htab_up.
6972         * objfiles.c (objfile_per_bfd_storage): Simplify.
6973
6974 2019-03-15  Tom Tromey  <tom@tromey.com>
6975
6976         * objfiles.h (struct objfile_per_bfd_storage): Declare
6977         destructor.
6978         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6979         New.
6980         (get_objfile_bfd_data): Use new.  Don't initialize
6981         language_of_main.
6982         (free_objfile_per_bfd_storage): Remove.
6983         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6984
6985 2019-03-15  Tom Tromey  <tom@tromey.com>
6986
6987         * symfile.c (reread_symbols): Update.
6988         * objfiles.c (objfile::objfile): Update.
6989         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6990         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6991         comment.
6992         (minimal_symbol_reader::install): Update.
6993         (terminate_minimal_symbol_table): Remove.
6994         * jit.c (jit_object_close_impl): Update.
6995
6996 2019-03-15  Tom Tromey  <tom@tromey.com>
6997
6998         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6999         initializations.
7000
7001 2019-03-15  Tom Tromey  <tom@tromey.com>
7002
7003         * objfiles.h (struct objfile_per_bfd_storage)
7004         <demangled_hash_languages>: Now a bitset.
7005         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7006         (lookup_minimal_symbol): Update.
7007
7008 2019-03-15  Tom Tromey  <tom@tromey.com>
7009
7010         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7011         Don't return the symbol.
7012         * coffread.c (record_minimal_symbol): Use record_full.
7013
7014 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7015
7016         The MS-Windows port of ncurses fails to switch to a color pair if
7017         one or both of the colors are the implicit default colors.  This
7018         change records the default colors when TUI is initialized, and
7019         then specifies them explicitly when a color pair uses the default
7020         colors.  This allows color styling in TUI mode on MS-Windows.
7021
7022         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7023         ncurses_norm_attr.
7024         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7025         colors in ncurses_norm_attr.
7026         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7027         "none", replace it with the default color recorded in
7028         ncurses_norm_attr.
7029
7030 2019-03-14  Tom Tromey  <tromey@adacore.com>
7031
7032         * source-cache.h (class source_cache) <get_source_lines>: Return
7033         std::string.
7034         * source-cache.c (source_cache::extract_lines): Handle case where
7035         first_pos==npos.  Return std::string.
7036         (source_cache::get_source_lines): Update.
7037
7038 2019-03-14  Tom Tromey  <tromey@adacore.com>
7039
7040         * NEWS: Add item for "style sources" commands.
7041         * source-cache.c (source_cache::get_source_lines): Check
7042         source_styling.
7043         * cli/cli-style.c (source_styling): New global.
7044         (_initialize_cli_style): Add "style sources" commands.
7045         (show_style_sources): New function.
7046         * cli/cli-style.h (source_styling): Declare.
7047
7048 2019-03-14  Pedro Alves  <palves@redhat.com>
7049             Tom Tromey  <tromey@adacore.com>
7050
7051         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7052         * tui/tui-winsource.c (tui_refill_source_window): New function,
7053         from...
7054         (tui_horizontal_source_scroll): ... here.  Move some logic.
7055         * cli/cli-style.c (set_style_enabled): Notify new observable.
7056         * tui/tui-hooks.c (tui_redisplay_source): New function.
7057         (tui_attach_detach_observers): Attach or detach
7058         tui_redisplay_source.
7059         * observable.h (source_styling_changed): New observable.
7060         * observable.c: Define source_styling_changed observable.
7061
7062 2019-03-13  Tom Tromey  <tromey@adacore.com>
7063
7064         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7065         (i386_gnu_nat_target::store_registers): Update.
7066         * target-debug.h (target_debug_print_std_string): New macro.
7067         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7068         * windows-tdep.c (display_one_tib): Update.
7069         * tui/tui-stack.c (tui_make_status_line): Update.
7070         * top.c (print_inferior_quit_action): Update.
7071         * thread.c (thr_try_catch_cmd): Update.
7072         (add_thread_with_info): Update.
7073         (thread_target_id_str): Update.
7074         (thr_try_catch_cmd): Update.
7075         (thread_command): Update.
7076         (thread_find_command): Update.
7077         * record-btrace.c (record_btrace_target::info_record)
7078         (record_btrace_resume_thread, record_btrace_target::resume)
7079         (record_btrace_cancel_resume, record_btrace_step_thread)
7080         (record_btrace_target::wait, record_btrace_target::wait)
7081         (record_btrace_target::wait, record_btrace_target::stop): Update.
7082         * progspace.c (print_program_space): Update.
7083         * process-stratum-target.c
7084         (process_stratum_target::thread_address_space): Update.
7085         * linux-fork.c (linux_fork_mourn_inferior)
7086         (detach_checkpoint_command, info_checkpoints_command)
7087         (linux_fork_context): Update.
7088         (linux_fork_detach): Update.
7089         (class scoped_switch_fork_info): Update.
7090         (delete_checkpoint_command): Update.
7091         * infrun.c (follow_fork_inferior): Update.
7092         (follow_fork_inferior): Update.
7093         (proceed_after_vfork_done): Update.
7094         (handle_vfork_child_exec_or_exit): Update.
7095         (follow_exec): Update.
7096         (displaced_step_prepare_throw): Update.
7097         (displaced_step_restore): Update.
7098         (start_step_over): Update.
7099         (resume_1): Update.
7100         (clear_proceed_status_thread): Update.
7101         (proceed): Update.
7102         (print_target_wait_results): Update.
7103         (do_target_wait): Update.
7104         (context_switch): Update.
7105         (stop_all_threads): Update.
7106         (restart_threads): Update.
7107         (finish_step_over): Update.
7108         (handle_signal_stop): Update.
7109         (switch_back_to_stepped_thread): Update.
7110         (keep_going_pass_signal): Update.
7111         (print_exited_reason): Update.
7112         (normal_stop): Update.
7113         * inferior.c (inferior_pid_to_str): Change return type.
7114         (print_selected_inferior): Update.
7115         (add_inferior): Update.
7116         (detach_inferior): Update.
7117         * dummy-frame.c (fprint_dummy_frames): Update.
7118         * dcache.c (dcache_info_1): Update.
7119         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7120         (btrace_fetch, btrace_clear): Update.
7121         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7122         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7123         type.
7124         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7125         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7126         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7127         * gdbarch.c, gdbarch.h: Rebuild.
7128         * gdbarch.sh (core_pid_to_str): Change return type.
7129         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7130         return type.
7131         (windows_nat_target::pid_to_str): Change return type.
7132         (windows_delete_thread): Update.
7133         (windows_nat_target::attach): Update.
7134         (windows_nat_target::files_info): Update.
7135         * target-delegates.c: Rebuild.
7136         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7137         return type.
7138         (sol_thread_target::pid_to_str): Change return type.
7139         * remote.c (class remote_target) <pid_to_str>: Change return
7140         type.
7141         (remote_target::pid_to_str): Change return type.
7142         (extended_remote_target::attach, remote_target::remote_stop_ns)
7143         (remote_target::remote_notif_remove_queued_reply)
7144         (remote_target::push_stop_reply, remote_target::disable_btrace):
7145         Update.
7146         (extended_remote_target::attach): Update.
7147         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7148         type.
7149         (gdbsim_target::pid_to_str): Change return type.
7150         * ravenscar-thread.c (struct ravenscar_thread_target)
7151         <pid_to_str>: Change return type.
7152         (ravenscar_thread_target::pid_to_str): Change return type.
7153         * procfs.c (class procfs_target) <pid_to_str>: Change return
7154         type.
7155         (procfs_target::pid_to_str): Change return type.
7156         (procfs_target::attach): Update.
7157         (procfs_target::detach): Update.
7158         (procfs_target::fetch_registers): Update.
7159         (procfs_target::store_registers): Update.
7160         (procfs_target::wait): Update.
7161         (procfs_target::files_info): Update.
7162         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7163         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7164         return type.
7165         (nto_procfs_target::pid_to_str): Change return type.
7166         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7167         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7168         return type.
7169         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7170         (exit_lwp): Update.
7171         (attach_proc_task_lwp_callback, get_detach_signal)
7172         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7173         (linux_nat_target::resume, wait_lwp, stop_callback)
7174         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7175         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7176         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7177         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7178         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7179         type.
7180         (inf_ptrace_target::attach): Update.
7181         (inf_ptrace_target::files_info): Update.
7182         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7183         type.
7184         (go32_nat_target::pid_to_str): Change return type.
7185         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7186         (gnu_nat_target::wait): Update.
7187         (gnu_nat_target::wait): Update.
7188         (gnu_nat_target::resume): Update.
7189         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7190         (fbsd_nat_target::wait): Update.
7191         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7192         type.
7193         (darwin_nat_target::attach): Update.
7194         * corelow.c (class core_target) <pid_to_str>: Change return type.
7195         (core_target::pid_to_str): Change return type.
7196         * target.c (normal_pid_to_str): Change return type.
7197         (default_pid_to_str): Likewise.
7198         (target_pid_to_str): Change return type.
7199         (target_translate_tls_address): Update.
7200         (target_announce_detach): Update.
7201         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7202         return type.
7203         (bsd_uthread_target::pid_to_str): Change return type.
7204         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7205         type.
7206         (bsd_kvm_target::pid_to_str): Change return type.
7207         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7208         return type.
7209         (aix_thread_target::pid_to_str): Change return type.
7210         * target.h (struct target_ops) <pid_to_str>: Change return type.
7211         (target_pid_to_str, normal_pid_to_str): Likewise.
7212         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7213         type.
7214         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7215         type.
7216         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7217         return type.
7218         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7219         type.
7220         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7221         type.
7222         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7223         return type.
7224
7225 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7226
7227         * NEWS: Mention that the new default MI version is 3.  Mention
7228         changes to the output of commands and events that deal with
7229         multi-location breakpoints.
7230         * breakpoint.c: Include "mi/mi-out.h".
7231         (print_one_breakpoint): Change output syntax if using MI version
7232         >= 3.
7233         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7234         New.
7235         (mi_multi_location_breakpoint_output_fixed): New.
7236         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7237         (mi_cmd_fix_multi_location_breakpoint_output): New.
7238         (mi_multi_location_breakpoint_output_fixed): New.
7239         * mi/mi-cmds.c (mi_cmds): Register command
7240         -fix-multi-location-breakpoint-output.
7241         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7242         interpreter "mi".
7243
7244 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7245
7246         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7247         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7248         instantiate mi_ui_out based on interpreter name.
7249         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7250         * mi/mi-main.c (mi_load_progress): Likewise.
7251
7252 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7253
7254         * NEWS: Combine separate "New targets" sections for 8.3.
7255
7256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7257
7258         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7259         (ppcfbsd_init_abi): Install gdbarch
7260         "fetch_tls_load_module_address" and "get_thread_local_address"
7261         methods.
7262
7263 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7264
7265         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7266         (riscv_fbsd_init_abi): Install gdbarch
7267         "fetch_tls_load_module_address" and "get_thread_local_address"
7268         methods.
7269
7270 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7271
7272         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7273         (i386fbsd_init_abi): Install gdbarch
7274         "fetch_tls_load_module_address" and "get_thread_local_address"
7275         methods.
7276
7277 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7278
7279         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7280         (amd64fbsd_init_abi): Install gdbarch
7281         "fetch_tls_load_module_address" and "get_thread_local_address"
7282         methods.
7283
7284 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7285
7286         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7287         (struct fbsd_pspace_data): New type.
7288         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7289         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7290         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7291         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7292         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7293
7294 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7295
7296         * gdbtypes.c (lookup_struct_elt): New function.
7297         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7298         * gdbtypes.h (struct struct_elt): New type.
7299         (lookup_struct_elt): New prototype.
7300
7301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7302
7303         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7304         remove disabled code block.
7305
7306 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7307
7308         * gdbarch.sh (get_thread_local_address): New method.
7309         * gdbarch.h, gdbarch.c: Regenerate.
7310         * target.c (target_translate_tls_address): Use
7311         gdbarch_get_thread_local_address if present instead of
7312         target::get_thread_local_address.
7313
7314 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7315
7316         * target.h (target::get_thread_local_address): Update comment.
7317
7318 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7319
7320         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7321         objfile->separate_debug_objfile_backlink if not NULL.
7322
7323 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7324
7325         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7326         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7327         (amd64bsd_store_inferior_registers): Likewise.
7328         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7329         Enable segment base registers.
7330         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7331         PT_GETFSBASE and PT_GETGSBASE.
7332         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7333         PT_SETGSBASE.
7334         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7335         segment base registers.
7336         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7337
7338 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7339
7340         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7341         Update calls to i386_target_description to add 'segments'
7342         parameter.
7343         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7344         add segment base registers.
7345         * arch/i386.c (i386_create_target_description): Add 'segments'
7346         parameter to enable segment base registers.
7347         * arch/i386.h (i386_create_target_description): Likewise.
7348         * features/i386/32bit-segments.xml: New file.
7349         * features/i386/32bit-segments.c: Generate.
7350         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7351         call to i386_target_description to add 'segments' parameter.
7352         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7353         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7354         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7355         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7356         if feature is present.
7357         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7358         Add 'segments' parameter to call to i386_target_description.
7359         (i386_target_description): Add 'segments' parameter to enable
7360         segment base registers.
7361         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7362         to call to i386_target_description.
7363         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7364         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7365         Define I386_NUM_REGS.
7366         (i386_target_description): Add 'segments' parameter to enable
7367         segment base registers.
7368
7369 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7370
7371         PR/24325
7372         * source-cache.c: #undef open and close, to avoid unresolved
7373         externals during linking.
7374
7375 2019-03-12  Tom Tromey  <tromey@adacore.com>
7376
7377         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7378         const.  Add initializers.
7379         (_initialize_remote): Don't initialize ptid globals.
7380
7381 2019-03-12  Pedro Alves  <palves@redhat.com>
7382
7383         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7384
7385 2019-03-12  Pedro Alves  <palves@redhat.com>
7386
7387         * cp-name-parser.y (main): Remove unused 'len' variable.
7388
7389 2019-03-12  Tom Tromey  <tromey@adacore.com>
7390
7391         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7392         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7393
7394 2019-03-12  Tom Tromey  <tromey@adacore.com>
7395
7396         * linux-nat.c (iterate_over_lwps): Update.
7397         (stop_callback): Remove parameter.
7398         (stop_wait_callback, detach_callback, resume_set_callback)
7399         (select_singlestep_lwp_callback, set_ignore_sigint)
7400         (status_callback, resumed_callback, resume_clear_callback)
7401         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7402         data parameter.
7403         (linux_nat_target::detach, linux_nat_target::resume)
7404         (linux_stop_and_wait_all_lwps, select_event_lwp)
7405         (linux_nat_filter_event, linux_nat_wait_1)
7406         (linux_nat_target::kill, linux_nat_target::stop)
7407         (linux_nat_target::stop): Update.
7408         (linux_nat_resume_callback): Change type.
7409         (resume_stopped_resumed_lwps, count_events_callback)
7410         (select_event_lwp_callback): Likewise.
7411         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7412         * arm-linux-nat.c (struct update_registers_data): Remove.
7413         (update_registers_callback): Change type.
7414         (arm_linux_insert_hw_breakpoint1): Update.
7415         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7416         parameter.
7417         (x86_linux_dr_set_addr): Update.
7418         (x86_linux_dr_set_control): Update.
7419         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7420         (iterate_over_lwps): Use gdb::function_view.
7421         * nat/aarch64-linux-hw-point.c (struct
7422         aarch64_dr_update_callback_param): Remove.
7423         (debug_reg_change_callback): Change type.
7424         (aarch64_notify_debug_reg_change): Update.
7425         * s390-linux-nat.c (s390_refresh_per_info): Update.
7426
7427 2019-03-11  Tom Tromey  <tromey@adacore.com>
7428
7429         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7430         redundant assignment to "this_cu".
7431
7432 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7433
7434         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7435
7436 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7437
7438         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7439         from...
7440         (rank_one_type): ... this.
7441
7442 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7443
7444         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7445         from...
7446         (rank_one_type): ... this.
7447
7448 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7449
7450         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7451         from...
7452         (rank_one_type): ... this.
7453
7454 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7455
7456         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7457         from...
7458         (rank_one_type): ... this.
7459
7460 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7461
7462         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7463         from...
7464         (rank_one_type): ... this.
7465
7466 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7467
7468         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7469         from...
7470         (rank_one_type): ... this.
7471
7472 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7473
7474         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7475         from...
7476         (rank_one_type): ... this.
7477
7478 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7479
7480         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7481         from...
7482         (rank_one_type): ... this.
7483
7484 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7485
7486         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7487         from...
7488         (rank_one_type): ... this.
7489
7490 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7491
7492         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7493         from...
7494         (rank_one_type): ... this.
7495
7496 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7497
7498         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7499         from...
7500         (rank_one_type): ... this.
7501
7502 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7503
7504         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7505         from...
7506         (rank_one_type): ... this.
7507
7508 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7509
7510         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7511         inferior-events' shows the example events.
7512
7513 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7514
7515         Support styling on native MS-Windows console
7516
7517         PR/24315
7518         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7519         on MS-Windows if $TERM is not defined.
7520
7521         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7522
7523         * posix-hdep.c (gdb_console_fputs):
7524         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7525         functions.
7526         * ui-file.h (gdb_console_fputs): Add prototype.
7527
7528         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7529         back to fputs only if the former returns zero.
7530
7531 2019-03-07  Tom Tromey  <tom@tromey.com>
7532
7533         * symmisc.c (print_symbol_bcache_statistics): Update.
7534         (print_objfile_statistics): Update.
7535         * symfile.c (allocate_symtab): Update.
7536         * stabsread.c: Don't include bcache.h.
7537         * psymtab.h (struct psymbol_bcache): Don't declare.
7538         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7539         (psymbol_bcache_init, psymbol_bcache_free)
7540         (psymbol_bcache_get_bcache): Don't declare.
7541         * psymtab.c (struct psymbol_bcache): Remove.
7542         (psymtab_storage::psymtab_storage): Update.
7543         (psymtab_storage::~psymtab_storage): Update.
7544         (psymbol_bcache_init, psymbol_bcache_free)
7545         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7546         (add_psymbol_to_bcache): Update.
7547         (allocate_psymtab): Update.
7548         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7549         macro_cache>: No longer pointers.
7550         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7551         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7552         * macrotab.c (macro_bcache): Update.
7553         * macroexp.c: Don't include bcache.h.
7554         * gdbtypes.c (check_types_worklist): Update.
7555         (types_deeply_equal): Remove TRY/CATCH.  Update.
7556         * elfread.c (elf_symtab_read): Update.
7557         * dwarf2read.c: Don't include bcache.h.
7558         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7559         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7560         (print_bcache_statistics, bcache_memory_used): Don't declare.
7561         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7562         methods.  Rename all data members.
7563         * bcache.c (struct bcache): Move to bcache.h.
7564         (bcache::expand_hash_table): Rename from expand_hash_table.
7565         (bcache): Remove.
7566         (bcache::insert): Rename from bcache_full.
7567         (bcache::compare): Rename from bcache_compare.
7568         (bcache_xmalloc): Remove.
7569         (bcache::~bcache): Rename from bcache_xfree.
7570         (bcache::print_statistics): Rename from print_bcache_statistics.
7571         (bcache::memory_used): Rename from bcache_memory_used.
7572
7573 2019-03-07  Pedro Alves  <palves@redhat.com>
7574
7575         * infrun.c (normal_stop): Also check for
7576         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7577
7578 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7579
7580         * f-lang.c (value_from_host_double): Moved to...
7581         * value.c (value_from_host_double): ...here.
7582         * value.h (value_from_host_double): Declare.
7583         * guile/scm-math.c (vlscm_convert_typed_number): Use
7584         value_from_host_double.
7585         (vlscm_convert_number): Likewise.
7586         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7587         * python/py-value.c (convert_value_from_python): Likewise.
7588
7589 2019-03-06  Tom Tromey  <tom@tromey.com>
7590
7591         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7592
7593 2019-03-06  Tom Tromey  <tom@tromey.com>
7594
7595         * utils.h (free_current_contents): Don't declare.
7596         * utils.c (free_current_contents): Remove.
7597
7598 2019-03-06  Tom Tromey  <tom@tromey.com>
7599
7600         * top.c (quit_force): Update.
7601         * main.c (captured_command_loop): Update.
7602         * common/new-op.c (operator new): Update.
7603         * common/common-exceptions.c (struct catcher)
7604         <save_cleanup_chain>: Remove member.
7605         (exceptions_state_mc_init): Update.
7606         (exception_try_scope_entry): Return nullptr.
7607         (exception_try_scope_exit, exception_rethrow)
7608         (throw_exception_sjlj, throw_exception_cxx): Update.
7609         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7610         (all_cleanups, do_cleanups, discard_cleanups)
7611         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7612         (restore_cleanups, restore_final_cleanups): Don't declare.
7613         (do_final_cleanups): Remove parameter.
7614         * common/cleanups.c (cleanup_chain, make_cleanup)
7615         (make_cleanup_dtor, all_cleanups, do_cleanups)
7616         (discard_my_cleanups, discard_cleanups)
7617         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7618         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7619         (null_cleanup): Remove.
7620         (do_final_cleanups): Remove parameter.
7621
7622 2019-03-06  Tom Tromey  <tom@tromey.com>
7623
7624         * remote.c (remote_target::remote_parse_stop_reply): Use
7625         unique_xmalloc_ptr.
7626
7627 2019-03-06  Tom Tromey  <tom@tromey.com>
7628
7629         * stabsread.c (struct stabs_field_info): Rename from field_info.
7630         <list, fnlist>: Add initializers.
7631         <obstack>: New member.
7632         (read_member_functions, read_struct_fields, read_baseclasses):
7633         Allocate on obstack.  Don't use cleanups.
7634         (read_one_struct_field, read_member_functions, read_struct_fields)
7635         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7636         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7637         (read_struct_type): Update.
7638
7639 2019-03-06  Tom Tromey  <tom@tromey.com>
7640
7641         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7642         * common/filestuff.h (make_cleanup_close): Don't declare.
7643         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7644         Remove.
7645
7646 2019-03-06  Tom Tromey  <tom@tromey.com>
7647
7648         * solib-aix.c: Use make_scope_exit.
7649
7650 2019-03-06  Tom Tromey  <tom@tromey.com>
7651
7652         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7653         Use make_scope_exit.
7654
7655 2019-03-06  Tom Tromey  <tom@tromey.com>
7656
7657         * solib-svr4.c (disable_probes_interface): Remove parameter.
7658         (svr4_handle_solib_event): Use make_scope_exit.
7659
7660 2019-03-06  Tom Tromey  <tom@tromey.com>
7661
7662         * remote.c (struct stop_reply_deleter): Remove.
7663         (stop_reply_up): Update.
7664         (struct stop_reply): Derive from notif_event.  Don't typedef.
7665         <regcache>: Now a std::vector.
7666         (stop_reply_xfree): Remove.
7667         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7668         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7669         (remote_target::discard_pending_stop_replies): Use delete.
7670         (remote_target::remote_parse_stop_reply): Update.
7671         (remote_target::process_stop_reply): Update.
7672         * remote-notif.h (struct notif_event): Add virtual destructor.
7673         Remove "dtr" member.
7674         (struct notif_client) <alloc_event>: Return a unique_ptr.
7675         (notif_event_xfree): Don't declare.
7676         (notif_event_up): New typedef.
7677         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7678         (notif_event_xfree, do_notif_event_xfree): Remove.
7679         (remote_notif_state_xfree): Update.
7680
7681 2019-03-06  Tom Tromey  <tom@tromey.com>
7682
7683         * infrun.c (displaced_step_clear_cleanup): Now a
7684         forward_scope_exit type.
7685         (displaced_step_prepare_throw): Update.
7686         (displaced_step_fixup): Update.
7687
7688 2019-03-06  Tom Tromey  <tom@tromey.com>
7689
7690         * inferior.h (class inferior): Update comment.
7691         * gdbthread.h (class thread_info): Update comment.
7692
7693 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7694             Tom Tromey  <tom@tromey.com>
7695
7696         * stabsread.h (struct stab_section_list): Remove.
7697         (coffstab_build_psymtabs): Update.
7698         * dbxread.c (symbuf_sections): Now a std::vector.
7699         (sect_idx): New global.
7700         (fill_symbuf): Update.
7701         (coffstab_build_psymtabs): Change type of stabsects parameter.
7702         Update.
7703         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7704         std::vector.
7705         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7706         (coff_locate_sections): Update.
7707         (coff_symfile_read): Remove cleanups.  Update.
7708         (init_stringtab): Add storage parameter.
7709         (free_stringtab, free_stringtab_cleanup): Remove.
7710         (init_lineno): Add storage parameter.
7711         (free_linetab, free_linetab_cleanup): Remove.
7712
7713 2019-03-06  Pedro Alves  <palves@redhat.com>
7714
7715         * linux-fork.c (fork_info::clobber_regs): Delete.
7716         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7717         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7718         comment.  Adjust.
7719         (scoped_switch_fork_info::scoped_switch_fork_info)
7720         (checkpoint_command, linux_fork_context): Adjust
7721         fork_save_infrun_state calls.
7722
7723 2019-03-06  Pedro Alves  <palves@redhat.com>
7724
7725         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7726         (inf_has_multiple_threads): Return 'bool' and rewrite using
7727         inferior_info::threads().
7728
7729 2019-03-06  Pedro Alves  <palves@redhat.com>
7730
7731         * linux-fork.c: Include <list>.
7732         (fork_list): Now a std::list instance.
7733         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7734         (forks_exist_p, find_last_fork): Adjust.
7735         (new_fork): Delete.
7736         (one_fork_p): New.
7737         (add_fork): Adjust.
7738         (free_fork): Delete, folded into fork_info::~fork_info().
7739         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7740         Adjust.
7741         (init_fork_list): Delete.
7742         (linux_fork_killall, linux_fork_mourn_inferior)
7743         (linux_fork_detach, info_checkpoints_command): Adjust.
7744         (_initialize_linux_fork): No longer call init_fork_list.
7745
7746 2019-03-06  Pedro Alves  <palves@redhat.com>
7747
7748         * linux-fork.c (new_fork): New, split out of ...
7749         (add_fork): ... this.  Return void.  Move "first fork" special
7750         case from here, to ...
7751         (checkpoint_command): ... here.
7752         * linux-linux.h (add_fork): Return void.
7753
7754 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7755
7756         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7757
7758 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7759             Chris January  <chris.january@arm.com>
7760             David Lecomber  <david.lecomber@arm.com>
7761
7762         * f-exp.y: New token, UNOP_INTRINSIC.
7763         (exp): New pattern using UNOP_INTRINSIC token.
7764         (f77_keywords): Add 'abs' keyword.
7765         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7766         (value_from_host_double): New function.
7767         (evaluate_subexp_f): Support UNOP_ABS.
7768
7769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7770
7771         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7772         types.
7773
7774 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7775
7776         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7777         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7778         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7779
7780 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7781
7782         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7783
7784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7785             Chris January  <chris.january@arm.com>
7786
7787         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7788         * f-exp.y: Define 'KIND' token.
7789         (exp): New pattern for KIND expressions.
7790         (ptype): Handle types with a kind extension.
7791         (direct_abs_decl): Extend to spot kind extensions.
7792         (f77_keywords): Add 'kind' to the list.
7793         (push_kind_type): New function.
7794         (convert_to_kind_type): New function.
7795         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7796         * parse.c (operator_length_standard): Likewise.
7797         * parser-defs.h (enum type_pieces): Add tp_kind.
7798         * std-operator.def: Add UNOP_KIND.
7799
7800 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7801
7802         * f-exp.y (f_parse): Set yydebug.
7803
7804 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7805
7806         * f-lang.c (evaluate_subexp_f): New function.
7807         (exp_descriptor_f): New global.
7808         (f_language_defn): Use exp_descriptor_f instead of
7809         exp_descriptor_standard.
7810
7811 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7812
7813         * f-exp.y (struct token): Add comments.
7814         (dot_ops): Remove uppercase versions and the end marker.
7815         (f77_keywords): Likewise.
7816         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7817         entries in the dot_ops array are case insensitive, and use
7818         strncasecmp to compare strings.  Also some whitespace cleanup in
7819         this area.  Similar for the f77_keywords array, except entries in
7820         this list might be case sensitive.
7821
7822 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7823
7824         * f-exp.y (struct f77_boolean_val): Add comments.
7825         (boolean_values): Remove uppercase versions, and end marker.
7826         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7827         and use strncasecmp to achieve case insensitivity.  Additionally,
7828         perform whitespace cleanup around this code.
7829
7830 2019-03-06  Tom Tromey  <tromey@adacore.com>
7831
7832         * remote-sim.c (gdbsim_target_open): Use result of
7833         gdb_argv::release.
7834
7835 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7836         Dirk Schubert  <dirk.schubert@arm.com>
7837         Chris January  <chris.january@arm.com>
7838
7839         * eval.c (evaluate_subexp_standard): Call Fortran argument
7840         wrapping logic.
7841         * f-lang.c (struct value): A value which can be passed into a
7842         Fortran function call.
7843         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7844         where appropriate.
7845         (struct type): Value ready for a Fortran function call.
7846         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7847         is needed.
7848         * f-lang.h (fortran_argument_convert): Declaration.
7849         (fortran_preserve_arg_pointer): Declaration.
7850         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7851
7852 2019-03-05  Tom Tromey  <tromey@adacore.com>
7853
7854         * python/py-prettyprint.c (print_string_repr): Remove #if.
7855         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7856
7857 2019-03-05  Tom Tromey  <tromey@adacore.com>
7858
7859         * target.c (the_dummy_target): Move later.  Change type to
7860         "dummy_target".
7861         (initialize_targets): Don't initialize the_dummy_target.
7862
7863 2019-03-05  Tom Tromey  <tromey@adacore.com>
7864
7865         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7866         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7867
7868 2019-03-05  Tom Tromey  <tromey@adacore.com>
7869
7870         * windows-nat.c (windows_nat_target::attach)
7871         (windows_nat_target::detach): Don't call gdb_flush.
7872         * valprint.c (generic_val_print, val_print, val_print_string):
7873         Don't call gdb_flush.
7874         * utils.c (defaulted_query): Don't call gdb_flush.
7875         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7876         * target.c (target_announce_detach): Don't call gdb_flush.
7877         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7878         * remote.c (extended_remote_target::attach): Don't call
7879         gdb_flush.
7880         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7881         * printcmd.c (do_examine): Don't call gdb_flush.
7882         (info_display_command): Don't call gdb_flush.
7883         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7884         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7885         * memattr.c (info_mem_command): Don't call gdb_flush.
7886         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7887         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7888         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7889         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7890         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7891         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7892         (gnu_nat_target::detach): Don't call gdb_flush.
7893         * f-valprint.c (f_val_print): Don't call gdb_flush.
7894         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7895         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7896         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7897         gdb_flush.
7898         * c-valprint.c (c_val_print): Don't call gdb_flush.
7899         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7900
7901 2019-03-05  Tom Tromey  <tromey@adacore.com>
7902
7903         * varobj.c (update_dynamic_varobj_children): Update.
7904         (install_default_visualizer): Use reset, not release.
7905         * value.c (set_internalvar): Update.
7906         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7907         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7908         ATTRIBUTE_UNUSED_RESULT.
7909
7910 2019-03-05  Tom Tromey  <tromey@adacore.com>
7911
7912         * remote.c (class scoped_remote_fd) <release>: Add
7913         ATTRIBUTE_UNUSED_RESULT.
7914
7915 2019-03-05  Tom Tromey  <tromey@adacore.com>
7916
7917         * macroexp.c (struct macro_buffer) <release>: Add
7918         ATTRIBUTE_UNUSED_RESULT.
7919
7920 2019-03-05  Tom Tromey  <tromey@adacore.com>
7921
7922         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7923         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7924         ATTRIBUTE_UNUSED_RESULT.
7925
7926 2019-03-05  Tom Tromey  <tromey@adacore.com>
7927
7928         * common/scoped_fd.h (class scoped_fd) <release>: Add
7929         ATTRIBUTE_UNUSED_RESULT.
7930
7931 2019-03-05  Tom Tromey  <tromey@adacore.com>
7932
7933         * parser-defs.h (struct parser_state) <release>: Add
7934         ATTRIBUTE_UNUSED_RESULT.
7935
7936 2019-03-05  Tom Tromey  <tromey@adacore.com>
7937
7938         * utils.h (class gdb_argv) <release>: Add
7939         ATTRIBUTE_UNUSED_RESULT.
7940         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7941
7942 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7943
7944         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7945         for-loop range, to avoid compiler warnings.
7946
7947         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7948         avoid compiler warnings about unused variables.
7949
7950         * NEWS: Mention end of support for native debugging on MS-Windows
7951         before XP.
7952
7953         PR gdb/24292
7954         * common/netstuff.c:
7955         * gdbserver/gdbreplay.c
7956         * gdbserver/remote-utils.c:
7957         * ser-tcp.c:
7958         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7959         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7960         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7961         'getaddrinfo' and 'freeaddrinfo' were not available before
7962         Windows XP, and mingw.org's MinGW headers by default define
7963         _WIN32_WINNT to 0x500.
7964
7965 2019-03-01  Gary Benson <gbenson@redhat.com>
7966
7967         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7968
7969 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7970             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7971
7972         PR gdb/8527
7973         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7974         set_sigint_trap, clear_sigint_trap.
7975
7976 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7977
7978         * target.c (target_detach): Clear the regcache and the
7979         frame cache.
7980
7981 2019-02-27  Pedro Alves  <palves@redhat.com>
7982
7983         * utils.c (set_screen_size): When we cap the height/width sizes,
7984         tweak the corresponding command variable to show "unlimited":
7985
7986 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7987             Pedro Alves  <palves@redhat.com>
7988
7989         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7990         before calling rl_set_screen_size.
7991
7992 2019-02-27  Tom Tromey  <tromey@adacore.com>
7993
7994         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7995         define.
7996         * python/py-value.c: Remove Python 2.4 workaround.
7997         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7998         workaround.
7999         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8000         Python 2.4 workaround.
8001         * python/python-internal.h: Remove Python 2.4 comment.
8002         (Py_ssize_t): Don't define.
8003         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8004         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8005         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8006         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8007         * python/python.c (do_start_initialization): Remove Python 2.4
8008         workaround.
8009         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8010         (print_children): Remove Python 2.4 workaround.
8011         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8012         workaround.
8013         (CHARBUFFERPROC_NAME): Remove.
8014         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8015         Python 2.4 workaround.
8016
8017 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8018
8019         * NEWS: Note minimum Python version.
8020
8021 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8022
8023         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8024         code from these functions.  Remove corresponding ifdefs.  Use
8025         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8026         Remove gotos and target of gotos.
8027         (infpy_search_memory): Likewise.
8028
8029 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8030
8031         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8032         (hppa_gdbarch_init): Don't register deleted functions with
8033         gdbarch.
8034
8035 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8036
8037         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8038         (h8300_unwind_sp): Delete.
8039         (h8300_dummy_id): Delete.
8040         (h8300_gdbarch_init): Don't register deleted functions with
8041         gdbarch.
8042
8043 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8044
8045         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8046         (ft32_unwind_pc): Delete.
8047         (ft32_unwind_sp): Delete.
8048         (ft32_gdbarch_init): Don't register deleted functions with
8049         gdbarch.
8050
8051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8052
8053         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8054         (frv_unwind_pc): Delete.
8055         (frv_unwind_sp): Delete.
8056         (frv_gdbarch_init): Don't register deleted functions with
8057         gdbarch.
8058
8059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8060
8061         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8062         (riscv_unwind_pc): Delete.
8063         (riscv_unwind_sp): Delete.
8064         (riscv_gdbarch_init): Don't register deleted functions with
8065         gdbarch.
8066
8067 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8068
8069         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8070         (csky_unwind_pc): Delete.
8071         (csky_unwind_sp): Delete.
8072         (csky_gdbarch_init): Don't register deleted functions with
8073         gdbarch.
8074
8075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8076
8077         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8078         (cris_unwind_pc): Delete.
8079         (cris_unwind_sp): Delete.
8080         (cris_gdbarch_init): Don't register deleted functions with
8081         gdbarch.
8082
8083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8084
8085         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8086         (bfin_unwind_pc): Delete.
8087         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8088
8089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8090
8091         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8092         (arm_unwind_pc): Delete.
8093         (arm_unwind_sp): Delete.
8094         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8095
8096 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8097
8098         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8099         (arc_unwind_pc): Delete.
8100         (arc_unwind_sp): Delete.
8101         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8102
8103 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8104
8105         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8106         (alpha_unwind_pc): Delete.
8107         (alpha_gdbarch_init): Don't register deleted functions with
8108         gdbarch.
8109
8110 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8111
8112         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8113         (aarch64_unwind_pc): Delete.
8114         (aarch64_unwind_sp): Delete.
8115         (aarch64_gdbarch_init): Don't register deleted functions with
8116         gdbarch.
8117
8118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8119
8120         * gdbtypes.c (type_align): Don't consider static members when
8121         computing structure alignment.
8122
8123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8124
8125         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8126         return 0 for other types.
8127         * arch-utils.c (default_type_align): Always return 0.
8128         * gdbarch.h: Regenerate.
8129         * gdbarch.sh (type_align): Extend comment.
8130         * gdbtypes.c (type_align): Add additional comments, always call
8131         gdbarch_type_align before applying the default rules.
8132         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8133         generic code will then apply a suitable default.
8134         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8135         types, return 0 for other types.
8136
8137 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8138
8139         * NEWS: Create a new section for the next release branch.
8140         Rename the section of the current branch, now that it has
8141         been cut.
8142
8143 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8144
8145         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8146         * version.in: Bump version to 8.3.50.DATE-git.
8147
8148 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8149
8150         * aix-thread.c (ptid_cmp): Remove unused variable.
8151         (get_signaled_thread): Likewise.
8152         (store_regs_user_thread): Likewise.
8153         (store_regs_kernel_thread): Likewise.
8154         (fetch_regs_kernel_thread): Remove shadowed variable.
8155
8156 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8157
8158         * features/riscv/32bit-cpu.xml: Add register numbers.
8159         * features/riscv/32bit-fpu.c: Regenerate.
8160         * features/riscv/32bit-fpu.xml: Add register numbers.
8161         * features/riscv/64bit-cpu.xml: Add register numbers.
8162         * features/riscv/64bit-fpu.c: Regenerate.
8163         * features/riscv/64bit-fpu.xml: Add register numbers.
8164
8165 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8166
8167         * NEWS: Mention two argument form of gdb.Value constructor.
8168         * python/py-value.c (convert_buffer_and_type_to_value): New
8169         function.
8170         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8171         Add support for handling an optional second argument.  Call
8172         convert_buffer_and_type_to_value as appropriate.
8173         * python/python-internal.h (Py_buffer_deleter): New struct.
8174         (Py_buffer_up): New typedef.
8175
8176 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8177
8178         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8179         instead of releasing ownership.
8180
8181 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8182
8183         * dwarf2read.c (open_and_init_dwp_file): Call
8184         elf_numsections instead of bfd_count_sections to initialize
8185         dwp_file->num_sections.
8186
8187 2019-02-25  Tom Tromey  <tromey@adacore.com>
8188
8189         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8190
8191 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8192
8193         * gcore.in: Add '--readnever' option when invoking GDB.
8194
8195 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8196
8197         * MAINTAINERS: Update my email address.
8198
8199 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8200
8201         * build-id.c (build_id_to_debug_bfd_1): New function.
8202         (build_id_to_debug_bfd): Look for separate debug file in
8203         sysroot.
8204
8205 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8206
8207         * gdbarch.sh: Update the copyright year range that is placed into
8208         generated files.
8209
8210 2019-02-22  Keith Seitz  <keiths@redhat.com>
8211
8212         PR symtab/23853
8213         * linespec.c (create_sals_line_offset): Search for the default
8214         symtab's filename instead of its fullname.
8215
8216 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8217
8218         * NEWS: Update style defaults.
8219
8220 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8221
8222         * main.c (captured_main_1): Disable styling in batch mode.
8223
8224 2019-02-20  Tom Tromey  <tom@tromey.com>
8225
8226         * symtab.c (symtab_symbol_info): Fix typos.
8227
8228 2019-02-20  Tom Tromey  <tromey@adacore.com>
8229
8230         * findcmd.c (_initialize_mem_search): Use upper case for
8231         metasyntactic variables.
8232
8233 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8234
8235         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8236         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8237
8238 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8239
8240         * top.h (source_file_name): Change to std::string.
8241         * top.c (source_file_name): Likewise.
8242         (command_line_input): Adjust.
8243         * cli/cli-script.c (script_from_file): Adjust.
8244
8245 2019-02-19  Tom Tromey  <tromey@adacore.com>
8246
8247         * ravenscar-thread.c
8248         (ravenscar_thread_target::update_thread_list): Don't call
8249         ada_build_task_list.
8250         * ada-lang.h (ada_build_task_list): Don't declare.
8251         * ada-tasks.c (struct ada_tasks_inferior_data)
8252         <task_list_valid_p>: Now bool.
8253         (read_known_tasks, ada_task_list_changed)
8254         (ada_tasks_invalidate_inferior_data): Update.
8255         (read_known_tasks_array): Return bool.
8256         (read_known_tasks_list): Likewise.
8257         (read_known_tasks): Return void.
8258         (ada_build_task_list): Now static.
8259
8260 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8261
8262         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8263         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8264
8265 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8266
8267         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8268         variant for ada_tasks_pspace_data_handle and
8269         ada_tasks_inferior_data_handle.
8270         (ada_tasks_pspace_data_cleanup): New function.
8271         (ada_tasks_inferior_data_cleanup): New function.
8272
8273 2019-02-17  Tom Tromey  <tom@tromey.com>
8274
8275         * macrotab.h (macro_source_fullname): Return a std::string.
8276         * macrotab.c (macro_include, check_for_redefinition)
8277         (macro_undef, macro_lookup_definition, foreach_macro)
8278         (foreach_macro_in_scope): Update.
8279         (macro_source_fullname): Return a std::string.
8280         * macrocmd.c (show_pp_source_pos): Update.
8281
8282 2019-02-17  Tom Tromey  <tom@tromey.com>
8283
8284         * macrocmd.c (show_pp_source_pos): Style the file names.
8285
8286 2019-02-17  Tom Tromey  <tom@tromey.com>
8287
8288         PR tui/24197:
8289         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8290
8291 2019-02-17  Tom Tromey  <tom@tromey.com>
8292
8293         * ada-lang.c (user_select_syms): Use filtered printing.
8294         * utils.c (wrap_style): New global.
8295         (desired_style): Remove.
8296         (emit_style_escape): Add stream parameter.
8297         (set_output_style, reset_terminal_style, prompt_for_continue):
8298         Update.
8299         (flush_wrap_buffer): Only flush gdb_stdout.
8300         (wrap_here): Set wrap_style.
8301         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8302         treat escape sequences as a character.  Change when wrap buffer is
8303         flushed.
8304         (fputs_styled): Do not set the output style when the default is
8305         requested.
8306         * ui-style.h (struct ui_file_style) <is_default>: New method.
8307         * source.c (print_source_lines_base): Emit escape sequences in one
8308         piece.
8309
8310 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8311
8312         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8313         integers and enumeration types.
8314
8315 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8316
8317         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8318         instead of lookup_symbol_in_language
8319         (do_exact_match): New function.
8320         (ada_get_symbol_name_matcher): Return do_exact_match when
8321         doing a verbatim match.
8322
8323 2019-02-15  Tom Tromey  <tromey@adacore.com>
8324
8325         * ravenscar-thread.c (ravenscar_thread_target::resume)
8326         (ravenscar_thread_target::wait): Special case wildcard requests.
8327
8328 2019-02-15  Tom Tromey  <tromey@adacore.com>
8329
8330         * ravenscar-thread.c (base_ptid): Remove.
8331         (struct ravenscar_thread_target) <close>: New method.
8332         <m_base_ptid>: New member.
8333         <update_inferior_ptid, active_task, task_is_currently_active,
8334         runtime_initialized>: Declare methods.
8335         <ravenscar_thread_target>: Add constructor.
8336         (ravenscar_thread_target::task_is_currently_active)
8337         (ravenscar_thread_target::update_inferior_ptid)
8338         (ravenscar_runtime_initialized): Rename.  Now methods.
8339         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8340         (ravenscar_thread_target::update_thread_list): Update.
8341         (ravenscar_thread_target::active_task): Now method.
8342         (ravenscar_thread_target::store_registers)
8343         (ravenscar_thread_target::prepare_to_store)
8344         (ravenscar_thread_target::prepare_to_store)
8345         (ravenscar_thread_target::mourn_inferior): Update.
8346         (ravenscar_inferior_created): Use "new" to create target.
8347         (ravenscar_thread_target::get_ada_task_ptid): Update.
8348         (_initialize_ravenscar): Don't initialize base_ptid.
8349         (ravenscar_ops): Remove global.
8350
8351 2019-02-15  Tom Tromey  <tromey@adacore.com>
8352
8353         * target.h (push_target): Declare new overload.
8354         * target.c (push_target): New overload, taking an rvalue reference.
8355         * remote.c (remote_target::open_1): Use push_target overload.
8356         * corelow.c (core_target_open): Use push_target overload.
8357
8358 2019-02-15  Tom Tromey  <tromey@adacore.com>
8359
8360         * ravenscar-thread.c (is_ravenscar_task)
8361         (ravenscar_task_is_currently_active): Return bool.
8362         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8363         (_initialize_ravenscar): Remove "(void)".
8364         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8365         Return bool.
8366
8367 2019-02-15  Tom Tromey  <tromey@adacore.com>
8368
8369         * ravenscar-thread.c (ravenscar_runtime_initializer)
8370         (has_ravenscar_runtime, get_running_thread_id)
8371         (ravenscar_thread_target::resume): Fix indentation.
8372
8373 2019-02-15  Tom Tromey  <tromey@adacore.com>
8374
8375         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8376         from ravenscar_arch_ops.
8377         (sparc_ravenscar_ops::fetch_registers)
8378         (sparc_ravenscar_ops::store_registers): Now methods.
8379         (sparc_ravenscar_prepare_to_store): Remove.
8380         (sparc_ravenscar_ops): Redefine.
8381         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8382         methods and destructor.  Remove members.
8383         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8384         (ravenscar_thread_target::store_registers)
8385         (ravenscar_thread_target::prepare_to_store): Update.
8386         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8387         Remove.
8388         (struct ppc_ravenscar_powerpc_ops): Derive from
8389         ravenscar_arch_ops.
8390         (ppc_ravenscar_powerpc_ops::fetch_registers)
8391         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8392         (ppc_ravenscar_powerpc_ops): Redefine.
8393         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8394         (ppc_ravenscar_e500_ops::fetch_registers)
8395         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8396         (ppc_ravenscar_e500_ops): Redefine.
8397         * aarch64-ravenscar-thread.c
8398         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8399         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8400         (aarch64_ravenscar_fetch_registers)
8401         (aarch64_ravenscar_store_registers): Now methods.
8402         (aarch64_ravenscar_ops): Redefine.
8403
8404 2019-02-15  Tom Tromey  <tromey@adacore.com>
8405
8406         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8407         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8408         (ravenscar_thread_target::stopped_by_watchpoint)
8409         (ravenscar_thread_target::stopped_data_address)
8410         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8411
8412 2019-02-15  Tom Tromey  <tromey@adacore.com>
8413
8414         * ravenscar-thread.c: Fix some typos.
8415
8416 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8417             Tom Tromey  <tromey@adacore.com>
8418
8419         * ada-lang.c (ada_exception_sal): Change addr_string to a
8420         std::string.
8421         (create_ada_exception_catchpoint): Update.
8422
8423 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8424             Tom Tromey  <tromey@adacore.com>
8425
8426         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8427         (bp_location_ops): Remove.
8428         (base_breakpoint_allocate_location): Update.
8429         (free_bp_location): Update.
8430         * ada-lang.c (class ada_catchpoint_location)
8431         <ada_catchpoint_location>: Remove ops parameter.
8432         (ada_catchpoint_location_dtor): Remove.
8433         (ada_catchpoint_location_ops): Remove.
8434         (allocate_location_exception): Update.
8435         * breakpoint.h (struct bp_location_ops): Remove.
8436         (class bp_location) <bp_location>: Remove bp_location_ops
8437         parameter.
8438         <~bp_location>: Add destructor.
8439         <ops>: Remove.
8440
8441 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8442             Pedro Alves  <palves@redhat.com>
8443
8444         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8445         'PATH_MAX'.
8446
8447 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8448             Samuel Thibault  <samuel.thibault@gnu.org>
8449             Thomas Schwinge  <thomas@codesourcery.com>
8450
8451         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8452         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8453
8454 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8455
8456         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8457         (check_empty): Use "const char *".
8458
8459         * gnu-nat.c (gnu_nat_target::detach): Instead of
8460         'detach_inferior (pid)' call
8461         'detach_inferior (find_inferior_pid (pid))'.
8462
8463         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8464         'nat/fork-inferior.o'.
8465         * gnu-nat.c: #include "nat/fork-inferior.h".
8466
8467         * gnu-nat.c (gnu_nat_target::detach): Instead of
8468         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8469         * gnu-nat.h: #include "inf-child.h".
8470         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8471         'i386_gnu_nat_target::fetch_registers'.
8472         (gnu_store_registers): Rename/move to
8473         'i386_gnu_nat_target::store_registers'.
8474
8475         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8476         * gnu-nat.h (mach_thread_info): New function.
8477         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8478
8479         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8480
8481 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8482
8483         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8484
8485 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8486
8487         * windows-nat.c (windows_add_thread): Add new parameter
8488         "main_thread_p" with default value set to false.  Update
8489         function documentation as well as all callers.
8490         (windows_delete_thread): Likewise.
8491         (fake_create_process): Update call to windows_add_thread.
8492         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8493         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8494         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8495         call to windows_delete_thread.
8496
8497 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8498
8499         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8500
8501 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8502
8503         * symfile.c (find_separate_debug_file): Use canonical path of
8504         sysroot with child_path instead of gdb_sysroot if it is valid.
8505
8506 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8507
8508         * symfile.c (find_separate_debug_file): Use child_path to
8509         determine if an object file is under a sysroot.
8510
8511 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8512
8513         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8514         unittests/child-path-selftests.c.
8515         * common/pathstuff.c (child_path): New function.
8516         * common/pathstuff.h (child_path): New prototype.
8517         * unittests/child-path-selftests.c: New file.
8518
8519 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8520
8521         * symfile.c (find_separate_debug_file): Look for separate debug
8522         files in debug directories under the sysroot.
8523
8524 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8525
8526         * symtab.h (struct minimal_symbol data_p): New const method.
8527         (struct minimal_symbol text_p): Likewise.
8528         * symtab.c (output_source_filename): Use file name style
8529         to print file name.
8530         (print_symbol_info): Likewise.
8531         (print_msymbol_info): Use address style to print addresses.
8532         Use function name style to print executable text symbols.
8533         (expand_symtab_containing_pc): Use data_p.
8534         (find_pc_sect_compunit_symtab): Likewise.
8535
8536 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8537
8538         * breakpoint.c (describe_other_breakpoints): Use address style
8539         to print addresses.
8540         (say_where): Likewise.
8541
8542 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8543
8544         * ada-typeprint.c (print_func_type): Print function name
8545         style to print function name.
8546         * c-typeprint.c (c_print_type_1): Likewise.
8547
8548 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8549
8550         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8551         for execve.
8552
8553 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8554
8555         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8556         type_stack.
8557
8558 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8559
8560         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8561         TYPE_CODE_REF types.
8562
8563 2019-02-08  Jim Wilson  <jimw@sifive.com>
8564
8565         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8566         (riscv_linux_fregset): New.
8567         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8568
8569 2019-02-07  Tom Tromey  <tom@tromey.com>
8570
8571         * thread.c (thread_cancel_execution_command): Update.
8572         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8573         methods.
8574         (struct thread_fsm_ops): Remove.
8575         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8576         (thread_fsm_should_stop, thread_fsm_return_value)
8577         (thread_fsm_set_finished, thread_fsm_finished_p)
8578         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8579         Don't declare.
8580         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8581         * infrun.c (clear_proceed_status_thread)
8582         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8583         (print_stop_event): Update.
8584         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8585         Add constructor.
8586         (step_command_fsm_ops): Remove.
8587         (new_step_command_fsm): Remove.
8588         (step_1): Update.
8589         (step_command_fsm::should_stop): Rename from
8590         step_command_fsm_should_stop.
8591         (step_command_fsm::clean_up): Rename from
8592         step_command_fsm_clean_up.
8593         (step_command_fsm::do_async_reply_reason): Rename from
8594         step_command_fsm_async_reply_reason.
8595         (struct until_next_fsm): Inherit from thread_fsm.  Add
8596         constructor.
8597         (until_next_fsm_ops): Remove.
8598         (new_until_next_fsm): Remove.
8599         (until_next_fsm::should_stop): Rename from
8600         until_next_fsm_should_stop.
8601         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8602         (until_next_fsm::do_async_reply_reason): Rename from
8603         until_next_fsm_async_reply_reason.
8604         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8605         constructor.  Change type of breakpoint.
8606         (finish_command_fsm_ops): Remove.
8607         (new_finish_command_fsm): Remove.
8608         (finish_command_fsm::should_stop): Rename from
8609         finish_command_fsm_should_stop.
8610         (finish_command_fsm::clean_up): Rename from
8611         finish_command_fsm_clean_up.
8612         (finish_command_fsm::return_value): Rename from
8613         finish_command_fsm_return_value.
8614         (finish_command_fsm::do_async_reply_reason): Rename from
8615         finish_command_fsm_async_reply_reason.
8616         (finish_command): Update.
8617         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8618         Add constructor.
8619         (call_thread_fsm_ops): Remove.
8620         (call_thread_fsm::call_thread_fsm): Rename from
8621         new_call_thread_fsm.
8622         (call_thread_fsm::should_stop): Rename from
8623         call_thread_fsm_should_stop.
8624         (call_thread_fsm::should_notify_stop): Rename from
8625         call_thread_fsm_should_notify_stop.
8626         (run_inferior_call, call_function_by_hand_dummy): Update.
8627         * cli/cli-interp.c (should_print_stop_to_console): Update.
8628         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8629         Add constructor.  Change type of location_breakpoint,
8630         caller_breakpoint.
8631         (until_break_fsm_ops): Remove.
8632         (new_until_break_fsm): Remove.
8633         (until_break_fsm::should_stop): Rename from
8634         until_break_fsm_should_stop.
8635         (until_break_fsm::clean_up): Rename from
8636         until_break_fsm_clean_up.
8637         (until_break_fsm::do_async_reply_reason): Rename from
8638         until_break_fsm_async_reply_reason.
8639         (until_break_command): Update.
8640         * thread-fsm.c: Remove.
8641         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8642
8643 2019-02-07  Tom Tromey  <tom@tromey.com>
8644
8645         * yy-remap.h: Add include guard.
8646         * xtensa-tdep.h: Add include guard.
8647         * xcoffread.h: Rename include guard.
8648         * varobj-iter.h: Add include guard.
8649         * tui/tui.h: Rename include guard.
8650         * tui/tui-winsource.h: Rename include guard.
8651         * tui/tui-wingeneral.h: Rename include guard.
8652         * tui/tui-windata.h: Rename include guard.
8653         * tui/tui-win.h: Rename include guard.
8654         * tui/tui-stack.h: Rename include guard.
8655         * tui/tui-source.h: Rename include guard.
8656         * tui/tui-regs.h: Rename include guard.
8657         * tui/tui-out.h: Rename include guard.
8658         * tui/tui-layout.h: Rename include guard.
8659         * tui/tui-io.h: Rename include guard.
8660         * tui/tui-hooks.h: Rename include guard.
8661         * tui/tui-file.h: Rename include guard.
8662         * tui/tui-disasm.h: Rename include guard.
8663         * tui/tui-data.h: Rename include guard.
8664         * tui/tui-command.h: Rename include guard.
8665         * tic6x-tdep.h: Add include guard.
8666         * target/waitstatus.h: Rename include guard.
8667         * target/wait.h: Rename include guard.
8668         * target/target.h: Rename include guard.
8669         * target/resume.h: Rename include guard.
8670         * target-float.h: Rename include guard.
8671         * stabsread.h: Add include guard.
8672         * rs6000-tdep.h: Add include guard.
8673         * riscv-fbsd-tdep.h: Add include guard.
8674         * regformats/regdef.h: Rename include guard.
8675         * record.h: Rename include guard.
8676         * python/python.h: Rename include guard.
8677         * python/python-internal.h: Rename include guard.
8678         * python/py-stopevent.h: Rename include guard.
8679         * python/py-ref.h: Rename include guard.
8680         * python/py-record.h: Rename include guard.
8681         * python/py-record-full.h: Rename include guard.
8682         * python/py-record-btrace.h: Rename include guard.
8683         * python/py-instruction.h: Rename include guard.
8684         * python/py-events.h: Rename include guard.
8685         * python/py-event.h: Rename include guard.
8686         * procfs.h: Add include guard.
8687         * proc-utils.h: Add include guard.
8688         * p-lang.h: Add include guard.
8689         * or1k-tdep.h: Rename include guard.
8690         * observable.h: Rename include guard.
8691         * nto-tdep.h: Rename include guard.
8692         * nat/x86-linux.h: Rename include guard.
8693         * nat/x86-linux-dregs.h: Rename include guard.
8694         * nat/x86-gcc-cpuid.h: Add include guard.
8695         * nat/x86-dregs.h: Rename include guard.
8696         * nat/x86-cpuid.h: Rename include guard.
8697         * nat/ppc-linux.h: Rename include guard.
8698         * nat/mips-linux-watch.h: Rename include guard.
8699         * nat/linux-waitpid.h: Rename include guard.
8700         * nat/linux-ptrace.h: Rename include guard.
8701         * nat/linux-procfs.h: Rename include guard.
8702         * nat/linux-osdata.h: Rename include guard.
8703         * nat/linux-nat.h: Rename include guard.
8704         * nat/linux-namespaces.h: Rename include guard.
8705         * nat/linux-btrace.h: Rename include guard.
8706         * nat/glibc_thread_db.h: Rename include guard.
8707         * nat/gdb_thread_db.h: Rename include guard.
8708         * nat/gdb_ptrace.h: Rename include guard.
8709         * nat/fork-inferior.h: Rename include guard.
8710         * nat/amd64-linux-siginfo.h: Rename include guard.
8711         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8712         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8713         * nat/aarch64-linux.h: Rename include guard.
8714         * nat/aarch64-linux-hw-point.h: Rename include guard.
8715         * mn10300-tdep.h: Add include guard.
8716         * mips-linux-tdep.h: Add include guard.
8717         * mi/mi-parse.h: Rename include guard.
8718         * mi/mi-out.h: Rename include guard.
8719         * mi/mi-main.h: Rename include guard.
8720         * mi/mi-interp.h: Rename include guard.
8721         * mi/mi-getopt.h: Rename include guard.
8722         * mi/mi-console.h: Rename include guard.
8723         * mi/mi-common.h: Rename include guard.
8724         * mi/mi-cmds.h: Rename include guard.
8725         * mi/mi-cmd-break.h: Rename include guard.
8726         * m2-lang.h: Add include guard.
8727         * location.h: Rename include guard.
8728         * linux-record.h: Rename include guard.
8729         * linux-nat.h: Add include guard.
8730         * linux-fork.h: Add include guard.
8731         * i386-darwin-tdep.h: Rename include guard.
8732         * hppa-linux-offsets.h: Add include guard.
8733         * guile/guile.h: Rename include guard.
8734         * guile/guile-internal.h: Rename include guard.
8735         * gnu-nat.h: Rename include guard.
8736         * gdb-stabs.h: Rename include guard.
8737         * frv-tdep.h: Add include guard.
8738         * f-lang.h: Add include guard.
8739         * event-loop.h: Add include guard.
8740         * darwin-nat.h: Rename include guard.
8741         * cp-abi.h: Rename include guard.
8742         * config/sparc/nm-sol2.h: Rename include guard.
8743         * config/nm-nto.h: Rename include guard.
8744         * config/nm-linux.h: Add include guard.
8745         * config/i386/nm-i386gnu.h: Rename include guard.
8746         * config/djgpp/nl_types.h: Rename include guard.
8747         * config/djgpp/langinfo.h: Rename include guard.
8748         * compile/gcc-cp-plugin.h: Add include guard.
8749         * compile/gcc-c-plugin.h: Add include guard.
8750         * compile/compile.h: Rename include guard.
8751         * compile/compile-object-run.h: Rename include guard.
8752         * compile/compile-object-load.h: Rename include guard.
8753         * compile/compile-internal.h: Rename include guard.
8754         * compile/compile-cplus.h: Rename include guard.
8755         * compile/compile-c.h: Rename include guard.
8756         * common/xml-utils.h: Rename include guard.
8757         * common/x86-xstate.h: Rename include guard.
8758         * common/version.h: Rename include guard.
8759         * common/vec.h: Rename include guard.
8760         * common/tdesc.h: Rename include guard.
8761         * common/selftest.h: Rename include guard.
8762         * common/scoped_restore.h: Rename include guard.
8763         * common/scoped_mmap.h: Rename include guard.
8764         * common/scoped_fd.h: Rename include guard.
8765         * common/safe-iterator.h: Rename include guard.
8766         * common/run-time-clock.h: Rename include guard.
8767         * common/refcounted-object.h: Rename include guard.
8768         * common/queue.h: Rename include guard.
8769         * common/ptid.h: Rename include guard.
8770         * common/print-utils.h: Rename include guard.
8771         * common/preprocessor.h: Rename include guard.
8772         * common/pathstuff.h: Rename include guard.
8773         * common/observable.h: Rename include guard.
8774         * common/netstuff.h: Rename include guard.
8775         * common/job-control.h: Rename include guard.
8776         * common/host-defs.h: Rename include guard.
8777         * common/gdb_wait.h: Rename include guard.
8778         * common/gdb_vecs.h: Rename include guard.
8779         * common/gdb_unlinker.h: Rename include guard.
8780         * common/gdb_unique_ptr.h: Rename include guard.
8781         * common/gdb_tilde_expand.h: Rename include guard.
8782         * common/gdb_sys_time.h: Rename include guard.
8783         * common/gdb_string_view.h: Rename include guard.
8784         * common/gdb_splay_tree.h: Rename include guard.
8785         * common/gdb_setjmp.h: Rename include guard.
8786         * common/gdb_ref_ptr.h: Rename include guard.
8787         * common/gdb_optional.h: Rename include guard.
8788         * common/gdb_locale.h: Rename include guard.
8789         * common/gdb_assert.h: Rename include guard.
8790         * common/filtered-iterator.h: Rename include guard.
8791         * common/filestuff.h: Rename include guard.
8792         * common/fileio.h: Rename include guard.
8793         * common/environ.h: Rename include guard.
8794         * common/common-utils.h: Rename include guard.
8795         * common/common-types.h: Rename include guard.
8796         * common/common-regcache.h: Rename include guard.
8797         * common/common-inferior.h: Rename include guard.
8798         * common/common-gdbthread.h: Rename include guard.
8799         * common/common-exceptions.h: Rename include guard.
8800         * common/common-defs.h: Rename include guard.
8801         * common/common-debug.h: Rename include guard.
8802         * common/cleanups.h: Rename include guard.
8803         * common/buffer.h: Rename include guard.
8804         * common/btrace-common.h: Rename include guard.
8805         * common/break-common.h: Rename include guard.
8806         * cli/cli-utils.h: Rename include guard.
8807         * cli/cli-style.h: Rename include guard.
8808         * cli/cli-setshow.h: Rename include guard.
8809         * cli/cli-script.h: Rename include guard.
8810         * cli/cli-interp.h: Rename include guard.
8811         * cli/cli-decode.h: Rename include guard.
8812         * cli/cli-cmds.h: Rename include guard.
8813         * charset-list.h: Add include guard.
8814         * buildsym-legacy.h: Rename include guard.
8815         * bfin-tdep.h: Add include guard.
8816         * ax.h: Rename include guard.
8817         * arm-linux-tdep.h: Add include guard.
8818         * arm-fbsd-tdep.h: Add include guard.
8819         * arch/xtensa.h: Rename include guard.
8820         * arch/tic6x.h: Add include guard.
8821         * arch/i386.h: Add include guard.
8822         * arch/arm.h: Rename include guard.
8823         * arch/arm-linux.h: Rename include guard.
8824         * arch/arm-get-next-pcs.h: Rename include guard.
8825         * arch/amd64.h: Add include guard.
8826         * arch/aarch64-insn.h: Rename include guard.
8827         * arch-utils.h: Rename include guard.
8828         * annotate.h: Add include guard.
8829         * amd64-darwin-tdep.h: Rename include guard.
8830         * aarch64-linux-tdep.h: Add include guard.
8831         * aarch64-fbsd-tdep.h: Add include guard.
8832         * aarch32-linux-nat.h: Add include guard.
8833
8834 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8835
8836         * macrotab.c (macro_define_internal): New function that
8837         factorizes macro_define_object_internal and macro_define_function
8838         code.
8839         (macro_define_object_internal): Use macro_define_internal.
8840         (macro_define_function): Likewise.
8841
8842 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8843
8844         * macrocmd.c (extract_identifier): Return
8845         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8846         callers.
8847
8848 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8849
8850         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8851
8852 2019-02-05  Tom Tromey  <tom@tromey.com>
8853
8854         * target.c (target_stack::unpush): Move assertion earlier.
8855
8856 2019-01-30  Tom Tromey  <tom@tromey.com>
8857
8858         PR python/23615:
8859         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8860         (gdbpy_parse_and_eval): Likewise.
8861         * python/python-internal.h (gdbpy_allow_threads): New class.
8862
8863 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8864
8865         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8866         (aarch64_fbsd_fpregmap): Move earlier.
8867         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8868         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8869         instead of individual calls to trad_frame_set_reg_addr.
8870         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8871         earlier.
8872         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8873         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8874         instead of individual calls to trad_frame_set_reg_addr.
8875
8876 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8877
8878         * CONTRIBUTE: Replace contribution list with wiki link.
8879
8880 2019-01-25  Tom Tromey  <tom@tromey.com>
8881
8882         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8883
8884 2019-01-25  Tom Tromey  <tom@tromey.com>
8885
8886         * xtensa-linux-nat.c: Fix common/ includes.
8887         * xml-support.h: Fix common/ includes.
8888         * xml-support.c: Fix common/ includes.
8889         * x86-linux-nat.c: Fix common/ includes.
8890         * windows-nat.c: Fix common/ includes.
8891         * varobj.h: Fix common/ includes.
8892         * varobj.c: Fix common/ includes.
8893         * value.c: Fix common/ includes.
8894         * valops.c: Fix common/ includes.
8895         * utils.c: Fix common/ includes.
8896         * unittests/xml-utils-selftests.c: Fix common/ includes.
8897         * unittests/utils-selftests.c: Fix common/ includes.
8898         * unittests/unpack-selftests.c: Fix common/ includes.
8899         * unittests/tracepoint-selftests.c: Fix common/ includes.
8900         * unittests/style-selftests.c: Fix common/ includes.
8901         * unittests/string_view-selftests.c: Fix common/ includes.
8902         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8903         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8904         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8905         * unittests/rsp-low-selftests.c: Fix common/ includes.
8906         * unittests/parse-connection-spec-selftests.c: Fix common/
8907         includes.
8908         * unittests/optional-selftests.c: Fix common/ includes.
8909         * unittests/offset-type-selftests.c: Fix common/ includes.
8910         * unittests/observable-selftests.c: Fix common/ includes.
8911         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8912         * unittests/memrange-selftests.c: Fix common/ includes.
8913         * unittests/memory-map-selftests.c: Fix common/ includes.
8914         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8915         * unittests/function-view-selftests.c: Fix common/ includes.
8916         * unittests/environ-selftests.c: Fix common/ includes.
8917         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8918         * unittests/common-utils-selftests.c: Fix common/ includes.
8919         * unittests/cli-utils-selftests.c: Fix common/ includes.
8920         * unittests/array-view-selftests.c: Fix common/ includes.
8921         * ui-file.c: Fix common/ includes.
8922         * tui/tui-io.c: Fix common/ includes.
8923         * tracepoint.h: Fix common/ includes.
8924         * tracepoint.c: Fix common/ includes.
8925         * tracefile-tfile.c: Fix common/ includes.
8926         * top.h: Fix common/ includes.
8927         * top.c: Fix common/ includes.
8928         * thread.c: Fix common/ includes.
8929         * target/waitstatus.h: Fix common/ includes.
8930         * target/waitstatus.c: Fix common/ includes.
8931         * target.h: Fix common/ includes.
8932         * target.c: Fix common/ includes.
8933         * target-memory.c: Fix common/ includes.
8934         * target-descriptions.c: Fix common/ includes.
8935         * symtab.h: Fix common/ includes.
8936         * symfile.c: Fix common/ includes.
8937         * stap-probe.c: Fix common/ includes.
8938         * spu-linux-nat.c: Fix common/ includes.
8939         * sparc-nat.c: Fix common/ includes.
8940         * source.c: Fix common/ includes.
8941         * solib.c: Fix common/ includes.
8942         * solib-target.c: Fix common/ includes.
8943         * ser-unix.c: Fix common/ includes.
8944         * ser-tcp.c: Fix common/ includes.
8945         * ser-pipe.c: Fix common/ includes.
8946         * ser-base.c: Fix common/ includes.
8947         * selftest-arch.c: Fix common/ includes.
8948         * s12z-tdep.c: Fix common/ includes.
8949         * rust-exp.y: Fix common/ includes.
8950         * rs6000-aix-tdep.c: Fix common/ includes.
8951         * riscv-tdep.c: Fix common/ includes.
8952         * remote.c: Fix common/ includes.
8953         * remote-notif.h: Fix common/ includes.
8954         * remote-fileio.h: Fix common/ includes.
8955         * remote-fileio.c: Fix common/ includes.
8956         * regcache.h: Fix common/ includes.
8957         * regcache.c: Fix common/ includes.
8958         * record-btrace.c: Fix common/ includes.
8959         * python/python.c: Fix common/ includes.
8960         * python/py-type.c: Fix common/ includes.
8961         * python/py-inferior.c: Fix common/ includes.
8962         * progspace.h: Fix common/ includes.
8963         * producer.c: Fix common/ includes.
8964         * procfs.c: Fix common/ includes.
8965         * proc-api.c: Fix common/ includes.
8966         * printcmd.c: Fix common/ includes.
8967         * ppc-linux-nat.c: Fix common/ includes.
8968         * parser-defs.h: Fix common/ includes.
8969         * osdata.c: Fix common/ includes.
8970         * obsd-nat.c: Fix common/ includes.
8971         * nat/x86-linux.c: Fix common/ includes.
8972         * nat/x86-linux-dregs.c: Fix common/ includes.
8973         * nat/x86-dregs.h: Fix common/ includes.
8974         * nat/x86-dregs.c: Fix common/ includes.
8975         * nat/ppc-linux.c: Fix common/ includes.
8976         * nat/mips-linux-watch.h: Fix common/ includes.
8977         * nat/mips-linux-watch.c: Fix common/ includes.
8978         * nat/linux-waitpid.c: Fix common/ includes.
8979         * nat/linux-ptrace.h: Fix common/ includes.
8980         * nat/linux-ptrace.c: Fix common/ includes.
8981         * nat/linux-procfs.c: Fix common/ includes.
8982         * nat/linux-personality.c: Fix common/ includes.
8983         * nat/linux-osdata.c: Fix common/ includes.
8984         * nat/linux-namespaces.c: Fix common/ includes.
8985         * nat/linux-btrace.h: Fix common/ includes.
8986         * nat/linux-btrace.c: Fix common/ includes.
8987         * nat/fork-inferior.c: Fix common/ includes.
8988         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8989         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8990         * nat/aarch64-linux.c: Fix common/ includes.
8991         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8992         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8993         * namespace.h: Fix common/ includes.
8994         * mips-linux-tdep.c: Fix common/ includes.
8995         * minsyms.c: Fix common/ includes.
8996         * mi/mi-parse.h: Fix common/ includes.
8997         * mi/mi-main.c: Fix common/ includes.
8998         * mi/mi-cmd-env.c: Fix common/ includes.
8999         * memrange.h: Fix common/ includes.
9000         * memattr.c: Fix common/ includes.
9001         * maint.h: Fix common/ includes.
9002         * maint.c: Fix common/ includes.
9003         * main.c: Fix common/ includes.
9004         * machoread.c: Fix common/ includes.
9005         * location.c: Fix common/ includes.
9006         * linux-thread-db.c: Fix common/ includes.
9007         * linux-nat.c: Fix common/ includes.
9008         * linux-fork.c: Fix common/ includes.
9009         * inline-frame.c: Fix common/ includes.
9010         * infrun.c: Fix common/ includes.
9011         * inflow.c: Fix common/ includes.
9012         * inferior.h: Fix common/ includes.
9013         * inferior.c: Fix common/ includes.
9014         * infcmd.c: Fix common/ includes.
9015         * inf-ptrace.c: Fix common/ includes.
9016         * inf-child.c: Fix common/ includes.
9017         * ia64-linux-nat.c: Fix common/ includes.
9018         * i387-tdep.c: Fix common/ includes.
9019         * i386-tdep.c: Fix common/ includes.
9020         * i386-linux-tdep.c: Fix common/ includes.
9021         * i386-linux-nat.c: Fix common/ includes.
9022         * i386-go32-tdep.c: Fix common/ includes.
9023         * i386-fbsd-tdep.c: Fix common/ includes.
9024         * i386-fbsd-nat.c: Fix common/ includes.
9025         * guile/scm-type.c: Fix common/ includes.
9026         * guile/guile.c: Fix common/ includes.
9027         * go32-nat.c: Fix common/ includes.
9028         * gnu-nat.c: Fix common/ includes.
9029         * gdbthread.h: Fix common/ includes.
9030         * gdbarch-selftests.c: Fix common/ includes.
9031         * gdb_usleep.c: Fix common/ includes.
9032         * gdb_select.h: Fix common/ includes.
9033         * gdb_bfd.c: Fix common/ includes.
9034         * gcore.c: Fix common/ includes.
9035         * fork-child.c: Fix common/ includes.
9036         * findvar.c: Fix common/ includes.
9037         * fbsd-nat.c: Fix common/ includes.
9038         * event-top.c: Fix common/ includes.
9039         * event-loop.c: Fix common/ includes.
9040         * dwarf2read.c: Fix common/ includes.
9041         * dwarf2loc.c: Fix common/ includes.
9042         * dwarf2-frame.c: Fix common/ includes.
9043         * dwarf-index-cache.c: Fix common/ includes.
9044         * dtrace-probe.c: Fix common/ includes.
9045         * disasm-selftests.c: Fix common/ includes.
9046         * defs.h: Fix common/ includes.
9047         * csky-tdep.c: Fix common/ includes.
9048         * cp-valprint.c: Fix common/ includes.
9049         * cp-support.h: Fix common/ includes.
9050         * cp-support.c: Fix common/ includes.
9051         * corelow.c: Fix common/ includes.
9052         * completer.h: Fix common/ includes.
9053         * completer.c: Fix common/ includes.
9054         * compile/compile.c: Fix common/ includes.
9055         * compile/compile-loc2c.c: Fix common/ includes.
9056         * compile/compile-cplus-types.c: Fix common/ includes.
9057         * compile/compile-cplus-symbols.c: Fix common/ includes.
9058         * command.h: Fix common/ includes.
9059         * cli/cli-dump.c: Fix common/ includes.
9060         * cli/cli-cmds.c: Fix common/ includes.
9061         * charset.c: Fix common/ includes.
9062         * build-id.c: Fix common/ includes.
9063         * btrace.h: Fix common/ includes.
9064         * btrace.c: Fix common/ includes.
9065         * breakpoint.h: Fix common/ includes.
9066         * breakpoint.c: Fix common/ includes.
9067         * ax.h:
9068         (enum agent_op): Fix common/ includes.
9069         * ax-general.c (struct aop_map): Fix common/ includes.
9070         * ax-gdb.c: Fix common/ includes.
9071         * auxv.c: Fix common/ includes.
9072         * auto-load.c: Fix common/ includes.
9073         * arm-tdep.c: Fix common/ includes.
9074         * arch/riscv.c: Fix common/ includes.
9075         * arch/ppc-linux-common.c: Fix common/ includes.
9076         * arch/i386.c: Fix common/ includes.
9077         * arch/arm.c: Fix common/ includes.
9078         * arch/arm-linux.c: Fix common/ includes.
9079         * arch/arm-get-next-pcs.c: Fix common/ includes.
9080         * arch/amd64.c: Fix common/ includes.
9081         * arch/aarch64.c: Fix common/ includes.
9082         * arch/aarch64-insn.c: Fix common/ includes.
9083         * arch-utils.c: Fix common/ includes.
9084         * amd64-windows-tdep.c: Fix common/ includes.
9085         * amd64-tdep.c: Fix common/ includes.
9086         * amd64-sol2-tdep.c: Fix common/ includes.
9087         * amd64-obsd-tdep.c: Fix common/ includes.
9088         * amd64-nbsd-tdep.c: Fix common/ includes.
9089         * amd64-linux-tdep.c: Fix common/ includes.
9090         * amd64-linux-nat.c: Fix common/ includes.
9091         * amd64-fbsd-tdep.c: Fix common/ includes.
9092         * amd64-fbsd-nat.c: Fix common/ includes.
9093         * amd64-dicos-tdep.c: Fix common/ includes.
9094         * amd64-darwin-tdep.c: Fix common/ includes.
9095         * agent.c: Fix common/ includes.
9096         * ada-lang.h: Fix common/ includes.
9097         * ada-lang.c: Fix common/ includes.
9098         * aarch64-tdep.c: Fix common/ includes.
9099
9100 2019-01-25  Tom Tromey  <tom@tromey.com>
9101
9102         * common/create-version.sh: Use common/version.h.
9103
9104 2019-01-24  Pedro Alves  <palves@redhat.com>
9105
9106         * infrun.c (signal_stop, signal_print, signal_program)
9107         (signal_catch, signal_pass): Now arrays instead of pointers.
9108         (update_signals_program_target, do_target_resume)
9109         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9110         * linux-nat.c (linux_nat_target::pass_signals)
9111         (linux_nat_target::create_inferior, linux_nat_target::attach):
9112         Adjust.
9113         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9114         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9115         * procfs.c (procfs_target::pass_signals): Adjust.
9116         * record-full.c (record_full_target::resume): Adjust.
9117         * remote.c (remote_target::pass_signals)
9118         (remote_target::program_signals): Adjust.
9119         * target-debug.h (target_debug_print_signals): Now takes a
9120         gdb::array_view as parameter.  Adjust.
9121         * target.h (target_ops) <pass_signals, program_signals>: Replace
9122         pointer and length parameters with gdb::array_view.
9123         (target_pass_signals, target_program_signals): Likewise.
9124         * target-delegates.c: Regenerate.
9125
9126 2019-01-24  Pedro Alves  <palves@redhat.com>
9127
9128         * common/forward-scope-exit.h
9129         (forward_scope_exit::forward_scope_exit): Pass arguments to
9130         m_bind_function directly, instead of creating a std::bind and
9131         copying that.
9132
9133 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9134
9135         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9136         for static members.
9137         (pass_in_v_vfp_candidate): Likewise.
9138
9139 2019-01-23  Tom Tromey  <tom@tromey.com>
9140             Pedro Alves  <palves@redhat.com>
9141
9142         * regcache.c (class regcache_invalidator): Remove.
9143         (regcache::raw_write): Use make_scope_exit.
9144
9145 2019-01-23  Tom Tromey  <tom@tromey.com>
9146
9147         * ui-out.h (class ui_out_emit_type): Update comment.
9148
9149 2019-01-23  Tom Tromey  <tom@tromey.com>
9150
9151         * infrun.c (fetch_inferior_event): Update comment.
9152
9153 2019-01-23  Tom Tromey  <tom@tromey.com>
9154             Pedro Alves  <palves@redhat.com>
9155
9156         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9157         parameter.
9158         (fetch_inferior_event): Use SCOPE_EXIT.
9159
9160
9161 2019-01-23  Tom Tromey  <tom@tromey.com>
9162             Pedro Alves  <palves@redhat.com>
9163
9164         * infrun.c (disable_thread_events): Delete.
9165         (stop_all_threads): Use SCOPE_EXIT.
9166
9167 2019-01-23  Tom Tromey  <tom@tromey.com>
9168             Pedro Alves  <palves@redhat.com>
9169
9170         * symfile.c: Include forward-scope-exit.h.
9171         (clear_symtab_users_cleanup): Replace forward declaration with
9172         a FORWARD_SCOPE_EXIT.
9173         (syms_from_objfile_1): Use the forward_scope_exit and
9174         gdb::optional instead of cleanup_function.
9175         (reread_symbols): Use the forward_scope_exit instead of
9176         cleanup_function.
9177         (clear_symtab_users_cleanup): Remove function.
9178
9179 2019-01-23  Tom Tromey  <tom@tromey.com>
9180             Pedro Alves  <palves@redhat.com>
9181
9182         * linux-nat.c: Include scope-exit.h.
9183         (cleanup_target_stop): Remove.
9184         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9185         SCOPE_EXIT.
9186
9187 2019-01-23  Tom Tromey  <tom@tromey.com>
9188             Pedro Alves  <palves@redhat.com>
9189
9190         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9191         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9192
9193 2019-01-23  Tom Tromey  <tom@tromey.com>
9194             Andrew Burgess  <andrew.burgess@embecosm.com>
9195             Pedro Alves  <palves@redhat.com>
9196
9197         * infrun.c (fetch_inferior_event): Use scope_exit.
9198         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9199         * top.c (execute_command): Use scope_exit.
9200         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9201         * utils.c (do_bpstat_clear_actions_cleanup)
9202         (make_bpstat_clear_actions_cleanup): Remove.
9203
9204 2019-01-23  Tom Tromey  <tom@tromey.com>
9205             Pedro Alves  <palves@redhat.com>
9206
9207         * infrun.c: Include "common/scope-exit.h"
9208         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9209         (wait_for_inferior): Use SCOPE_EXIT.
9210         (fetch_inferior_event): Use scope_exit.
9211
9212 2019-01-23  Tom Tromey  <tom@tromey.com>
9213             Pedro Alves  <palves@redhat.com>
9214
9215         * breakpoint.c (create_breakpoint): Remove cleanup.
9216
9217 2019-01-23  Tom Tromey  <tom@tromey.com>
9218             Andrew Burgess  <andrew.burgess@embecosm.com>
9219             Pedro Alves  <palves@redhat.com>
9220
9221 2019-01-23  Pedro Alves  <palves@redhat.com>
9222
9223         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9224
9225 2019-01-23  Pedro Alves  <palves@redhat.com>
9226             Andrew Burgess  <andrew.burgess@embecosm.com>
9227
9228         * gdbthread.h: Include "common/forward-scope-exit.h".
9229         (scoped_finish_thread_state): Redefine custom class in terms of
9230         forward_scope_exit.
9231
9232 2019-01-23  Pedro Alves  <palves@redhat.com>
9233             Andrew Burgess  <andrew.burgess@embecosm.com>
9234
9235         * common/forward-scope-exit.h: New file.
9236
9237 2019-01-23  Pedro Alves  <palves@redhat.com>
9238             Andrew Burgess  <andrew.burgess@embecosm.com>
9239             Tom Tromey  <tom@tromey.com>
9240
9241         * common/scope-exit.h: New file.
9242
9243 2019-01-23  Pedro Alves  <palves@redhat.com>
9244
9245         * common/preprocessor.h (ESC): Rename to ...
9246         (ESC_PARENS): ... this.
9247         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9248         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9249
9250 2019-01-23  Tom Tromey  <tom@tromey.com>
9251
9252         * language.h (class scoped_switch_to_sym_language_if_auto):
9253         Initialize m_lang in both cases.
9254
9255 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9256
9257         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9258         with XCNEW.
9259
9260 2019-01-22  Tom Tromey  <tom@tromey.com>
9261
9262         * corelow.c: Do not include sys/file.h.
9263
9264 2019-01-22  Tom Tromey  <tom@tromey.com>
9265
9266         * tui/tui-wingeneral.h: Include gdb_curses.h.
9267
9268 2019-01-22  Tom Tromey  <tom@tromey.com>
9269
9270         * source-cache.h (class source_cache) <get_source_lines,
9271         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9272
9273 2019-01-22  Tom Tromey  <tom@tromey.com>
9274
9275         * remote-fileio.h (struct remote_target): Declare.
9276
9277 2019-01-22  Tom Tromey  <tom@tromey.com>
9278
9279         * python/py-arch.c: Do not include py-ref.h.
9280         * python/py-bpevent.c: Do not include py-ref.h.
9281         * python/py-cmd.c: Do not include py-ref.h.
9282         * python/py-continueevent.c: Do not include py-ref.h.
9283         * python/py-event.h: Do not include py-ref.h.
9284         * python/py-evtregistry.c: Do not include py-ref.h.
9285         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9286         * python/py-frame.c: Do not include py-ref.h.
9287         * python/py-framefilter.c: Do not include py-ref.h.
9288         * python/py-function.c: Do not include py-ref.h.
9289         * python/py-infevents.c: Do not include py-ref.h.
9290         * python/py-linetable.c: Do not include py-ref.h.
9291         * python/py-objfile.c: Do not include py-ref.h.
9292         * python/py-param.c: Do not include py-ref.h.
9293         * python/py-prettyprint.c: Do not include py-ref.h.
9294         * python/py-progspace.c: Do not include py-ref.h.
9295         * python/py-symbol.c: Do not include py-ref.h.
9296         * python/py-symtab.c: Do not include py-ref.h.
9297         * python/py-type.c: Do not include py-ref.h.
9298         * python/py-unwind.c: Do not include py-ref.h.
9299         * python/py-utils.c: Do not include py-ref.h.
9300         * python/py-value.c: Do not include py-ref.h.
9301         * python/py-varobj.c: Do not include py-ref.h.
9302         * python/py-xmethods.c: Do not include py-ref.h.
9303         * python/python.c: Do not include py-ref.h.
9304         * varobj.c: Do not include py-ref.h.
9305
9306 2019-01-22  Tom Tromey  <tom@tromey.com>
9307
9308         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9309         keyword for bcache.
9310
9311 2019-01-22  Tom Tromey  <tom@tromey.com>
9312
9313         * compile/compile-cplus-types.c: Remove a comment by #include.
9314
9315 2019-01-22  Tom Tromey  <tom@tromey.com>
9316
9317         * compile/gcc-c-plugin.h: Include compile-internal.h.
9318
9319 2019-01-22  Tom Tromey  <tom@tromey.com>
9320
9321         * stabsread.c (EXTERN): Do not define.
9322         (symnum, next_symbol_text_func, processing_gcc_compilation)
9323         (within_function, global_sym_chain, global_stabs)
9324         (previous_stab_code, this_object_header_files)
9325         (n_this_object_header_files)
9326         (n_allocated_this_object_header_files): Define.
9327         * stabsread.h (EXTERN): Never define.  Use "extern".
9328
9329 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9330
9331         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9332         history_value.
9333
9334 2019-01-21  Tom Tromey  <tom@tromey.com>
9335
9336         * ui-out.c: Fix includes.
9337         * tui/tui-source.c: Fix includes.
9338         * target.c: Fix includes.
9339         * remote.c: Fix includes.
9340         * regcache.c: Fix includes.
9341         * python/py-block.c: Fix includes.
9342         * printcmd.c: Fix includes.
9343         * or1k-tdep.c: Fix includes.
9344         * mi/mi-main.c: Fix includes.
9345         * m32r-tdep.c: Fix includes.
9346         * csky-tdep.c: Fix includes.
9347         * compile/compile-cplus-types.c: Fix includes.
9348         * cli/cli-interp.c: Fix includes.
9349
9350 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9351
9352         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9353         for padding.
9354
9355 2019-01-16  Tom Tromey  <tom@tromey.com>
9356
9357         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9358         earlier.
9359         (struct objfile) <msymbols_range>: Move from top level.
9360         <msymbols>: New method.
9361         (class objfile_msymbols): Remove.
9362         * symtab.c (default_collect_symbol_completion_matches_break_on):
9363         Update.
9364         * symmisc.c (dump_msymbols): Update.
9365         * stabsread.c (scan_file_globals): Update.
9366         * objc-lang.c (info_selectors_command, info_classes_command)
9367         (find_methods): Update.
9368         * minsyms.c (find_solib_trampoline_target): Update.
9369         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9370         * coffread.c (coff_symfile_read): Update.
9371         * ada-lang.c (ada_lookup_simple_minsym)
9372         (ada_collect_symbol_completion_matches): Update.
9373
9374 2019-01-16  Tom Tromey  <tom@tromey.com>
9375
9376         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9377         type.  Remove no-argument constructor.
9378         <iterator::operator++>: Simplify.
9379         <begin>: Update.
9380         <end>: Use minimal_symbol_count.
9381
9382 2019-01-16  Tom Tromey  <tom@tromey.com>
9383
9384         * objfiles.h (struct objfile) <psymtabs>: New method.
9385         (class objfile_psymtabs): Remove.
9386         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9387         typedef.
9388         <range>: New method.
9389         (require_partial_symbols): Change return type.
9390         * psymtab.c (require_partial_symbols)
9391         (psym_expand_symtabs_matching): Update.
9392         * mdebugread.c (parse_partial_symbols): Update.
9393         * dbxread.c (dbx_end_psymtab): Update.
9394
9395 2019-01-15  Tom Tromey  <tom@tromey.com>
9396
9397         * symtab.c (lookup_objfile_from_block)
9398         (lookup_symbol_in_objfile_symtabs)
9399         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9400         (find_line_symtab, info_sources_command)
9401         (default_collect_symbol_completion_matches_break_on)
9402         (make_source_files_completion_list): Update.
9403         * symmisc.c (print_objfile_statistics, dump_objfile)
9404         (maintenance_print_symbols, maintenance_info_symtabs)
9405         (maintenance_check_symtabs, maintenance_info_line_tables):
9406         Update.
9407         * source.c (select_source_symtab)
9408         (forget_cached_source_info_for_objfile): Update.
9409         * objfiles.h (class objfile_compunits): Remove.
9410         (struct objfile) <compunits_range>: New typedef.
9411         (compunits): New method.
9412         * objfiles.c (objfile_relocate1): Update.
9413         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9414         * maint.c (count_symtabs_and_blocks): Update.
9415         * linespec.c (iterate_over_all_matching_symtabs): Update.
9416         * cp-support.c (add_symbol_overload_list_qualified): Update.
9417         * coffread.c (coff_symtab_read): Update.
9418         * ada-lang.c (add_nonlocal_symbols)
9419         (ada_collect_symbol_completion_matches)
9420         (ada_add_global_exceptions): Update.
9421
9422 2019-01-15  Tom Tromey  <tom@tromey.com>
9423
9424         * progspace.h (program_space) <objfiles_safe_range>: New
9425         typedef.
9426         <objfiles_safe>: New method.
9427         * objfiles.h (class all_objfiles_safe): Remove.
9428         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9429         * jit.c (jit_inferior_exit_hook): Update.
9430
9431 2019-01-17  Tom Tromey  <tom@tromey.com>
9432
9433         * progspace.h (program_space) <objfiles_range>: New typedef.
9434         <objfiles>: New method.
9435         <objfiles_head>: Rename from objfiles.
9436         (object_files): Update.
9437         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9438         * guile/scm-pretty-print.c
9439         (ppscm_find_pretty_printer_from_objfiles): Update.
9440         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9441         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9442         Update.
9443         * python/py-progspace.c (pspy_get_objfiles): Update.
9444         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9445         Update.
9446         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9447         (objfpy_lookup_objfile_by_build_id): Update.
9448         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9449         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9450         Update.
9451         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9452         (expand_symtab_containing_pc, lookup_objfile_from_block)
9453         (lookup_static_symbol, basic_lookup_transparent_type)
9454         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9455         (find_line_symtab, info_sources_command)
9456         (default_collect_symbol_completion_matches_break_on)
9457         (make_source_files_completion_list, find_main_name): Update.
9458         * symmisc.c (print_symbol_bcache_statistics)
9459         (print_objfile_statistics, maintenance_print_symbols)
9460         (maintenance_print_msymbols, maintenance_print_objfiles)
9461         (maintenance_info_symtabs, maintenance_check_symtabs)
9462         (maintenance_expand_symtabs, maintenance_info_line_tables):
9463         Update.
9464         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9465         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9466         (map_overlay_command, unmap_overlay_command)
9467         (simple_overlay_update, expand_symtabs_matching)
9468         (map_symbol_filenames): Update.
9469         * symfile-debug.c (set_debug_symfile): Update.
9470         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9471         Update.
9472         * source.c (select_source_symtab, forget_cached_source_info):
9473         Update.
9474         * solib.c (solib_read_symbols): Update.
9475         * solib-spu.c (append_ocl_sos): Update.
9476         * psymtab.c (maintenance_print_psymbols)
9477         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9478         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9479         * printcmd.c (info_symbol_command): Update.
9480         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9481         Update.
9482         * objfiles.h (class all_objfiles): Remove.
9483         * objfiles.c (have_partial_symbols, have_full_symbols)
9484         (have_minimal_symbols, qsort_cmp, update_section_map)
9485         (shared_objfile_contains_address_p)
9486         (default_iterate_over_objfiles_in_search_order): Update.
9487         * objc-lang.c (info_selectors_command, info_classes_command)
9488         (find_methods): Update.
9489         * minsyms.c (find_solib_trampoline_target): Update.
9490         * maint.c (maintenance_info_sections)
9491         (maintenance_translate_address, count_symtabs_and_blocks):
9492         Update.
9493         * main.c (captured_main_1): Update.
9494         * linux-thread-db.c (try_thread_db_load_from_pdir)
9495         (has_libpthread): Update.
9496         * linespec.c (iterate_over_all_matching_symtabs)
9497         (search_minsyms_for_name): Update.
9498         * jit.c (jit_find_objf_with_entry_addr): Update.
9499         * hppa-tdep.c (find_unwind_entry)
9500         (hppa_lookup_stub_minimal_symbol): Update.
9501         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9502         Update.
9503         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9504         (elf_gnu_ifunc_resolve_by_got): Update.
9505         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9506         * dwarf-index-write.c (save_gdb_index_command): Update.
9507         * cp-support.c (add_symbol_overload_list_qualified): Update.
9508         * breakpoint.c (create_overlay_event_breakpoint)
9509         (create_longjmp_master_breakpoint)
9510         (create_std_terminate_master_breakpoint)
9511         (create_exception_master_breakpoint): Update.
9512         * blockframe.c (find_pc_partial_function): Update.
9513         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9514         (ada_collect_symbol_completion_matches)
9515         (ada_add_global_exceptions): Update.
9516
9517 2019-01-17  Tom Tromey  <tom@tromey.com>
9518
9519         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9520         declare VEC.
9521         (solib_target_parse_libraries): Change return type.
9522         (library_list_start_segment, library_list_start_section)
9523         (library_list_end_library, library_list_start_library); Update.
9524         (solib_target_free_library_list): Remove.
9525         (solib_target_parse_libraries): Remove cleanup.  Change return
9526         type.
9527         (solib_target_current_sos): Update.
9528
9529 2019-01-17  Tom Tromey  <tromey@bapiya>
9530
9531         * valprint.c: Replace "the the" with "the".
9532         * symtab.c: Replace "the the" with "the".
9533         * solib.c: Replace "the the" with "the".
9534         * solib-dsbt.c: Replace "the the" with "the".
9535         * linespec.c: Replace "the the" with "the".
9536         * dwarf2loc.h: Replace "the the" with "the".
9537         * amd64-windows-tdep.c: Replace "the the" with "the".
9538         * aarch64-tdep.c: Replace "the the" with "the".
9539
9540 2019-01-16  Keith Seitz  <keiths@redhat.com>
9541
9542         PR gdb/23773
9543         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9544         <builder>: Rename to ..
9545         <m_builder>: ... this and make private.
9546         (dwarf2_cu::get_builder): New method.  Change all users of
9547         `builder' to use this method.
9548         (dwarf2_start_symtab): Move to ...
9549         (dwarf2_cu::start_symtab): ... here.  Update all callers
9550         (setup_type_unit_groups): Move to ...
9551         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9552         callers.
9553         (dwarf2_cu::reset_builder): New method.
9554         (process_full_compunit, process_full_type_unit): Use
9555         dwarf2_cu::reset_builder.
9556         (follow_die_offset): Record the ancestor CU if it is different
9557         from the followed DIE's CU.
9558         (follow_die_sig_1): Likewise.
9559
9560 2019-01-15  Tom Tromey  <tom@tromey.com>
9561
9562         * remote.c (class remote_state) <buf>: Now a char_vector.
9563         <buf_size>: Remove.
9564         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9565         parameter.
9566         (remote_target::getpkt_or_notif_sane_1)
9567         (remote_target::getpkt_sane)
9568         (remote_target::getpkt_or_notif_sane): Likewise.
9569         (class remote_target) <putpkt>: New overload.
9570         (remote_target::read_frame): Change type of "buf_p".  Remove
9571         sizeof_p parameter.
9572         (packet_ok): New overload.
9573         (packet_check_result): New overload.
9574         Update all uses.
9575
9576 2019-01-14  Tom Tromey  <tom@tromey.com>
9577
9578         * remote-notif.c (handle_notification, remote_notif_ack)
9579         (remote_notif_parse): Make "buf" const.
9580         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9581         const.
9582         (remote_notif_parse, remote_notif_ack, handle_notification):
9583         Likewise.
9584         * remote.c (remote_notif_stop_parse): Make "buf" const.
9585         (remote_target::remote_parse_stop_reply): Make "buf" const.
9586         (remote_notif_stop_ack): Make "buf" const.
9587
9588 2019-01-14  Tom Tromey  <tom@tromey.com>
9589
9590         * remote.c (remote_console_output): Make parameter const.
9591
9592 2019-01-14  Tom Tromey  <tom@tromey.com>
9593
9594         * target-debug.h (target_debug_print_signals): Constify.
9595         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9596         * procfs.c (procfs_target::pass_signals): Update.
9597         * linux-nat.c (linux_nat_target::pass_signals): Update.
9598         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9599         * target-delegates.c: Rebuild.
9600         * remote.c (remote_target::program_signals): Update.
9601         (remote_target::pass_signals): Update.
9602         * target.c (target_pass_signals): Constify argument.
9603         (target_program_signals): Likewise.
9604         * target.h (struct target_ops) <pass_signals, program_signals>:
9605         Constify argument.
9606         (target_pass_signals, target_program_signals): Constify argument.
9607
9608 2019-01-14  Tom Tromey  <tom@tromey.com>
9609
9610         PR tui/28819:
9611         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9612
9613 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9614
9615         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9616         field.
9617         * rs6000-tdep.c: Include reggroups.h.
9618         (IS_V_ALIAS_PSEUDOREG): Define.
9619         (rs6000_register_name): Return names for the "vX" aliases.
9620         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9621         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9622         aliases.  Call default_register_reggroup_p for all other
9623         pseudo-registers.
9624         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9625         New functions.
9626         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9627         Handle "vX" aliases.
9628         (v_alias_pseudo_register_collect): New function.
9629         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9630         (rs6000_gdbarch_init): Initialize "vX" aliases as
9631         pseudo-registers.  Restore registration of
9632         rs6000_pseudo_register_reggroup_p with
9633         set_tdesc_pseudo_register_reggroup_p.
9634
9635 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9636
9637         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9638         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9639         set_gdbarch_num_pseudo_regs.
9640
9641 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9642
9643         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9644         Remove arg prefixname, add do_set and do_show.
9645         Add member functions set_list and show_list.
9646         * cli/cli-style.c (class cli_style_option): Update accordingly.
9647         (style_set_list): Move to file scope.
9648         (style_show_list): Likewise.
9649         (set_style): Call help_list.
9650         (show_style): Call cmd_show_list.
9651         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9652         Update to use the new macro.
9653
9654 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9655
9656         * ada-lang.c (_initialize_ada_language): Expand the help text
9657         for the "catch exception" command.
9658
9659 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9660
9661         * symtab.c (matching_obj_sections): Initialize obj,
9662         declare it closer to its usage.
9663
9664 2019-01-10  Tom Tromey  <tom@tromey.com>
9665
9666         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9667         (basic_inf_threads_range): Remove.
9668         (inf_threads_range, inf_non_exited_threads_range)
9669         (safe_inf_threads_range): Use next_adapter.
9670
9671 2019-01-10  Keith Seitz  <keiths@redhat.com>
9672
9673         PR gdb/23712
9674         PR symtab/23010
9675         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9676         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9677
9678 2019-01-10  Keith Seitz  <keiths@redhat.com>
9679
9680         PR gdb/23712
9681         PR symtab/23010
9682         * dictionary.c (pending_to_vector): Remove.
9683         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9684         Remove _1 suffix, replacing functions of the same name.  Update
9685         all callers.
9686         (dict_create_hashed, dict_create_hashed_expandable)
9687         (dict_create_linear, dict_create_linear_expandable, dict_free)
9688         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9689         Make functions static.
9690
9691 2019-01-10  Keith Seitz  <keiths@redhat.com>
9692
9693         PR gdb/23712
9694         PR symtab/23010
9695         * dictionary.h (struct dictionary): Replace declaration with
9696         multidictionary.
9697         (dict_create_hashed, dict_create_hashed_expandable)
9698         (dict_create_linear, dict_create_linear_expandable)
9699         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9700         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9701         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9702         taking multidictionary argument.
9703         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9704         * block.h (struct block) <dict>: Change to multidictionary
9705         and rename `multidict'.
9706         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9707         symmisc.c: Update all dictionary references to multidictionary.
9708
9709 2019-01-10  Keith Seitz  <keiths@redhat.com>
9710
9711         PR gdb/23712
9712         PR symtab/23010
9713         * dictionary.c: Include unordered_map.
9714         (pending_to_vector): New function.
9715         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9716         Rewrite the non-"_1" functions to take vector instead
9717         of linked list.
9718         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9719         "new" _1 versions of the same name.
9720         (multidictionary): Define.
9721         (std::hash<enum language): New definition.
9722         (collate_pending_symbols_by_language, mdict_create_hashed)
9723         (mdict_create_hashed_expandable, mdict_create_linear)
9724         (mdict_create_linear_expandable, mdict_free)
9725         (find_language_dictionary, create_new_language_dictionary)
9726         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9727         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9728         (mdict_size, mdict_empty): New functions.
9729         * dictionary.h (mdict_iterator): Define.
9730
9731 2019-01-10  Pedro Alves  <palves@redhat.com>
9732
9733         * breakpoint.c (read_uploaded_action)
9734         (create_tracepoint_from_upload): Adjust to use
9735         gdb::unique_xmalloc_ptr.
9736         * ctf.c (ctf_write_uploaded_tp):
9737         (SET_ARRAY_FIELD): Use emplace_back.
9738         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9739         * tracefile-tfile.c (tfile_write_uploaded_tp):
9740         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9741         gdb::unique_xmalloc_ptr.
9742         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9743         at_string, cond_string, cmd_strings>: Replace char pointers
9744         with gdb::unique_xmalloc_ptr.
9745
9746 2019-01-10  Pedro Alves  <palves@redhat.com>
9747
9748         * solib-target.c (library_list_start_library): Don't xstrdup name.
9749
9750 2019-01-10  Pedro Alves  <palves@redhat.com>
9751
9752         * mdebugread.c (parse_partial_symbols): Use
9753         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9754
9755 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9756
9757         * linux-fork.c (scoped_switch_fork_info)
9758         <~scoped_switch_fork_info>: Fix incorrect variable name.
9759
9760 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9761
9762         * linux-fork.c (scoped_switch_fork_info)
9763         <scoped_switch_fork_info>: Make explicit.
9764         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9765
9766 2019-01-10  Tom Tromey  <tom@tromey.com>
9767
9768         * objfiles.h (objfile::reset_psymtabs): Update.
9769         * objfiles.c (objfile::objfile): Update.
9770         * psymtab.h (psymtab_storage::obstack): Update.
9771         (psymtab_storage::m_obstack): Use gdb::optional.
9772         (class psymtab_storage): Update comment.  Remove objfile
9773         parameter.
9774         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9775
9776 2019-01-10  Tom Tromey  <tom@tromey.com>
9777
9778         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9779         <free_psymtabs>: Now private.
9780         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9781         (allocate_psymtab): Use new method.
9782
9783 2019-01-10  Tom Tromey  <tom@tromey.com>
9784
9785         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9786         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9787         * mdebugread.c (parse_partial_symbols): Use
9788         allocate_dependencies.
9789         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9790         allocate_dependencies.
9791         (process_psymtab_comp_unit_reader)
9792         (build_type_psymtab_dependencies): Likewise.
9793         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9794
9795 2019-01-10  Tom Tromey  <tom@tromey.com>
9796
9797         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9798         PSYMBOL_SET_LANGUAGE.
9799         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9800
9801 2019-01-10  Tom Tromey  <tom@tromey.com>
9802
9803         * psymtab.h (psymtab_storage::obstack): New method.
9804         <m_obstack>: Rename from obstack; now private.
9805         * psymtab.c (psymtab_storage): Update.
9806         * dwarf2read.c (create_addrmap_from_index)
9807         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9808         Update.
9809
9810 2019-01-10  Tom Tromey  <tom@tromey.com>
9811
9812         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9813         * objfiles.h (objfile::reset_psymtabs): New method.
9814
9815 2019-01-10  Tom Tromey  <tom@tromey.com>
9816
9817         * symmisc.c (print_symbol_bcache_statistics): Update.
9818         (print_objfile_statistics): Update.
9819         * symfile.c (reread_symbols): Update.
9820         * psymtab.h (class psymtab_storage): New.
9821         * psymtab.c (psymtab_storage): New constructor.
9822         (~psymtab_storage): New destructor.
9823         (require_partial_symbols): Update.
9824         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9825         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9826         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9827         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9828         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9829         (start_psymtab_common, end_psymtab_common)
9830         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9831         (allocate_psymtab): Update.
9832         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9833         Update.
9834         (dump_psymtab_addrmap, maintenance_print_psymbols)
9835         (maintenance_check_psymtabs): Update.
9836         (class objfile_psymtabs): Move to objfiles.h.
9837         * psympriv.h (discard_psymtab): Now inline.
9838         (psymtab_discarder::psymtab_discarder): Update.
9839         (psymtab_discarder::~psymtab_discarder): Update.
9840         (ALL_OBJFILE_PSYMTABS): Rewrite.
9841         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9842         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9843         Remove fields.
9844         <partial_symtabs>: New field.
9845         (class objfile_psymtabs): Move from psymtab.h.  Update.
9846         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9847         psymbol_cache.
9848         (objfile::~objfile): Don't destroy psymbol_cache.
9849         * mdebugread.c (parse_partial_symbols): Update.
9850         * dwarf2read.c (create_addrmap_from_index)
9851         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9852         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9853         (add_partial_subprogram, dwarf2_ranges_read): Update.
9854         * dwarf-index-write.c (write_address_map)
9855         (write_one_signatured_type, recursively_write_psymbols)
9856         (class debug_names, class debug_names, write_psymtabs_to_index):
9857         Update.
9858
9859 2019-01-10  Tom Tromey  <tom@tromey.com>
9860
9861         * symtab.h (SYMBOL_SET_NAMES): Update.
9862         (symbol_set_names): Update.
9863         (MSYMBOL_SET_NAMES): Update.
9864         * symtab.c (symbol_set_names): Change argument to be an
9865         objfile_per_bfd_storage.
9866         * psymtab.c (add_psymbol_to_bcache): Update.
9867         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9868
9869 2019-01-10  Tom Tromey  <tom@tromey.com>
9870
9871         * symtab.c (create_demangled_names_hash): Change argument to be an
9872         objfile_per_bfd_storage.
9873         (symbol_set_names): Update.
9874
9875 2019-01-10  Tom Tromey  <tom@tromey.com>
9876
9877         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9878         init_psymbol_list.
9879         * psymtab.c (init_psymbol_list): Do nothing if already called.
9880         * psympriv.h (init_psymbol_list): Add comment.
9881         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9882         init_psymbol_list.
9883         * dbxread.c (dbx_symfile_read): Unconditionally call
9884         init_psymbol_list.
9885
9886 2019-01-10  Tom Tromey  <tom@tromey.com>
9887
9888         * xcoffread.c (scan_xcoff_symtab): Update.
9889         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9890         "where".
9891         * mdebugread.c (parse_partial_symbols)
9892         (handle_psymbol_enumerators): Update.
9893         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9894         * dbxread.c (read_dbx_symtab): Update.
9895         * psympriv.h (psymbol_placement): New enum.
9896         (add_psymbol_to_list): Update.
9897
9898 2019-01-10  Tom Tromey  <tom@tromey.com>
9899
9900         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9901         static_psymbols parameters.
9902         (scan_xcoff_symtab): Update.
9903         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9904         static_psymbols parameters.
9905         * psympriv.h (start_psymtab_common): Update.
9906         * mdebugread.c (parse_partial_symbols): Update.
9907         * dwarf2read.c (create_partial_symtab): Update.
9908         * dbxread.c (read_dbx_symtab): Update.
9909         (start_psymtab): Remove global_psymbols and static_psymbols
9910         parameters.
9911
9912 2019-01-10  Tom Tromey  <tom@tromey.com>
9913
9914         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9915         * psymtab.c (allocate_psymtab): Add comment.
9916         * psympriv.h (allocate_psymtab): Add comment.
9917         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9918         initializations.
9919         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9920
9921 2019-01-10  Tom Tromey  <tom@tromey.com>
9922
9923         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9924         Don't declare.
9925         * mipsread.c: Include mdebugread.h.
9926         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9927         Declare.
9928         * elfread.c: Include mdebugread.h.
9929
9930 2019-01-09  Tom Tromey  <tom@tromey.com>
9931
9932         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9933         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9934         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9935         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9936         (psym_lookup_symbol, psym_find_last_source_symtab)
9937         (psym_forget_cached_source_info, psym_print_stats)
9938         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9939         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9940         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9941         (psym_find_compunit_symtab_by_address)
9942         (maintenance_print_psymbols, maintenance_info_psymtabs)
9943         (maintenance_check_psymtabs): Use ranged for.
9944         * psymtab.h (class objfile_psymtabs): New.
9945         (require_partial_symbols): Return objfile_psymtabs.
9946         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9947
9948 2019-01-09  Tom Tromey  <tom@tromey.com>
9949
9950         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9951         (find_pc_mapped_section, list_overlays_command)
9952         (map_overlay_command, unmap_overlay_command)
9953         (simple_overlay_update): Use all_objfiles.
9954         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9955         * printcmd.c (info_symbol_command): Use all_objfiles.
9956         * objfiles.h (ALL_OBJSECTIONS): Remove.
9957         * maint.c (maintenance_translate_address): Use all_objfiles.
9958         * gcore.c (gcore_create_callback): Use all_objfiles.
9959         (objfile_find_memory_regions): Likewise.
9960
9961 2019-01-09  Tom Tromey  <tom@tromey.com>
9962
9963         * symtab.c (find_line_symtab, info_sources_command)
9964         (make_source_files_completion_list): Use objfile_compunits.
9965         * source.c (select_source_symtab): Use objfile_compunits.
9966         * objfiles.h (struct objfile): Update comment.
9967         (ALL_OBJFILES): Remove.
9968         (ALL_FILETABS): Remove.
9969         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9970         objfile_compunits.
9971
9972 2019-01-09  Tom Tromey  <tom@tromey.com>
9973
9974         * symmisc.c (print_objfile_statistics, dump_objfile)
9975         (maintenance_print_symbols): Use compunit_filetabs.
9976         * source.c (forget_cached_source_info_for_objfile): Use
9977         compunit_filetabs.
9978         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9979         (ALL_FILETABS): Use compunit_filetabs.
9980         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9981         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9982
9983 2019-01-09  Tom Tromey  <tom@tromey.com>
9984
9985         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9986         (compunit_filetabs): New.
9987         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9988         compunit_filetabs.
9989         (info_sources_command, make_source_files_completion_list): Remove
9990         declaration.
9991         * symmisc.c (print_objfile_statistics, dump_objfile)
9992         (maintenance_print_symbols): Remove declaration.
9993         (maintenance_info_symtabs): Use compunit_filetabs.
9994         (maintenance_info_line_tables): Likewise.
9995         * source.c (select_source_symtab): Change local variable name.
9996         (forget_cached_source_info_for_objfile): Remove declaration.
9997         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9998         * objfiles.c (objfile_relocate1): Remove declaration.
9999         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10000         declaration.
10001         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10002         * coffread.c (coff_symtab_read): Remove declaration.
10003         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10004         compunit_filetabs.
10005
10006 2019-01-09  Tom Tromey  <tom@tromey.com>
10007
10008         * symtab.c (lookup_objfile_from_block)
10009         (find_pc_sect_compunit_symtab, search_symbols)
10010         (default_collect_symbol_completion_matches_break_on): Use
10011         objfile_compunits.
10012         * objfiles.h (ALL_COMPUNITS): Remove.
10013         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10014         * cp-support.c (add_symbol_overload_list_qualified): Use
10015         objfile_compunits.
10016         * ada-lang.c (ada_collect_symbol_completion_matches)
10017         (ada_add_global_exceptions): Use objfile_compunits.
10018
10019 2019-01-09  Tom Tromey  <tom@tromey.com>
10020
10021         * source.c (select_source_symtab)
10022         (forget_cached_source_info_for_objfile): Remove declaration.
10023         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10024         declaration.
10025         * maint.c (count_symtabs_and_blocks): Remove declaration.
10026         * cp-support.c (add_symbol_overload_list_qualified): Remove
10027         declaration.
10028         * coffread.c (coff_symtab_read): Remove declaration.
10029         * symtab.c (lookup_symbol_in_objfile_symtabs)
10030         (basic_lookup_transparent_type_1): Use objfile_compunits.
10031         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10032         (info_sources_command, search_symbols)
10033         (default_collect_symbol_completion_matches_break_on)
10034         (make_source_files_completion_list): Remove declaration.
10035         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10036         (ada_collect_symbol_completion_matches)
10037         (ada_add_global_exceptions): Remove declaration.
10038         * linespec.c (iterate_over_all_matching_symtabs): Use
10039         objfile_compunits.
10040         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10041         (class objfile_compunits): New.
10042         (ALL_COMPUNITS): Use objfile_compunits.
10043         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10044         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10045         objfile_compunits.
10046         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10047
10048 2019-01-09  Tom Tromey  <tom@tromey.com>
10049
10050         * symtab.c (search_symbols)
10051         (default_collect_symbol_completion_matches_break_on): Use
10052         objfile_msymbols.
10053         * ada-lang.c (ada_lookup_simple_minsym)
10054         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10055         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10056         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10057         objfile_msymbols.
10058         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10059         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10060         * objc-lang.c (find_methods): Use objfile_msymbols.
10061         (info_selectors_command, info_classes_command): Likewise.
10062         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10063         * objfiles.h (class objfile_msymbols): New.
10064         (ALL_OBJFILE_MSYMBOLS): Remove.
10065         (ALL_MSYMBOLS): Remove.
10066
10067 2019-01-09  Tom Tromey  <tom@tromey.com>
10068
10069         * common/next-iterator.h (next_adapter): Add Iterator template
10070         parameter.
10071         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10072         (class all_objfiles_safe): New.
10073         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10074         * objfiles.c (put_objfile_before): Update comment.
10075         (add_separate_debug_objfile): Likewise.
10076         (free_all_objfiles): Use all_objfiles_safe.
10077         (objfile_purge_solibs): Likewise.
10078
10079 2019-01-09  Tom Tromey  <tom@tromey.com>
10080
10081         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10082         (expand_symtab_containing_pc, lookup_static_symbol)
10083         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10084         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10085         all_objfiles.
10086         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10087         * breakpoint.c (create_overlay_event_breakpoint)
10088         (create_longjmp_master_breakpoint)
10089         (create_std_terminate_master_breakpoint)
10090         (create_exception_master_breakpoint): Use all_objfiles.
10091         * linux-thread-db.c (try_thread_db_load_from_pdir)
10092         (has_libpthread): Use all_objfiles.
10093         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10094         * linespec.c (iterate_over_all_matching_symtabs)
10095         (search_minsyms_for_name): Use all_objfiles.
10096         * maint.c (maintenance_info_sections): Use all_objfiles.
10097         * main.c (captured_main_1): Use all_objfiles.
10098         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10099         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10100         * guile/scm-pretty-print.c
10101         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10102         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10103         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10104         (maintenance_print_msymbols): Use all_objfiles.
10105         * source.c (select_source_symtab): Use all_objfiles.
10106         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10107         * symfile.c (remove_symbol_file_command)
10108         (expand_symtabs_matching, map_symbol_filenames): Use
10109         all_objfiles.
10110         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10111         all_objfiles.
10112         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10113         * objc-lang.c (find_methods): Use all_objfiles.
10114         * objfiles.c (have_partial_symbols, have_full_symbols)
10115         (have_minimal_symbols, qsort_cmp)
10116         (default_iterate_over_objfiles_in_search_order): Use
10117         all_objfiles.
10118         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10119         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10120         (maintenance_check_psymtabs): Use all_objfiles.
10121         (ALL_PSYMTABS): Remove.
10122         * compile/compile-object-run.c (do_module_cleanup): Use
10123         all_objfiles.
10124         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10125         * cp-support.c (add_symbol_overload_list_qualified): Use
10126         all_objfiles.
10127         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10128         Use all_objfiles.
10129         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10130         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10131         all_objfiles.
10132         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10133         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10134         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10135         Uses all_objfiles.
10136         * solib.c (solib_read_symbols): Use all_objfiles
10137
10138 2019-01-09  Tom Tromey  <tom@tromey.com>
10139
10140         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10141         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10142         all_objfiles.
10143         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10144         * symmisc.c (print_symbol_bcache_statistics)
10145         (print_objfile_statistics, maintenance_print_objfiles)
10146         (maintenance_info_symtabs, maintenance_check_symtabs)
10147         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10148         all_objfiles.
10149         * source.c (forget_cached_source_info): Use all_objfiles.
10150         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10151         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10152         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10153         * objfiles.c (update_section_map): Use all_objfiles.
10154         (shared_objfile_contains_address_p): Likewise.
10155         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10156         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10157
10158 2019-01-09  Tom Tromey  <tom@tromey.com>
10159
10160         * common/next-iterator.h: New file.
10161         * objfiles.h (class all_objfiles): New.
10162         (struct objfile_iterator): New.
10163
10164 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10165
10166         * NEWS: Move the description of the changed "frame", "select-frame",
10167          and "info frame" commands to the Changed commands section.
10168
10169 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10170
10171         * gdbtypes.c (check_stub_method_group): Remove handling of old
10172         mangling schemes.
10173         * linespec.c (find_methods): Likewise.
10174         * stabsread.c (read_member_functions): Likewise.
10175         * valops.c (search_struct_method): Likewise.
10176         (value_struct_elt_for_reference): Likewise.
10177         * NEWS: Mention this change.
10178
10179 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10180
10181         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10182         print_source_lines.
10183         * source.c (print_source_lines_base): Update line number check.
10184         (print_source_lines): New function.
10185         (source_lines_range::source_lines_range): New function.
10186         * source.h (class source_lines_range): New class.
10187         (print_source_lines): New declaration.
10188
10189 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10190
10191         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10192
10193 2019-01-08  Tom Tromey  <tom@tromey.com>
10194             Simon Marchi  <simon.marchi@ericsson.com>
10195
10196         PR gdb/24060
10197         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10198         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10199         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10200         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10201         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10202         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10203
10204 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10205
10206         * source.c (select_source_symtab): Move header comment to
10207         declaration in source.h.
10208         (forget_cached_source_info_for_objfile): Likewise.
10209         (forget_cached_source_info): Likewise.
10210         (identify_source_line): Likewise.
10211         * source.h (identify_source_line): Move declaration from symtab.h
10212         and add comment from source.c
10213         (print_source_lines): Likewise.
10214         (forget_cached_source_info_for_objfile): Likewise.
10215         (forget_cached_source_info): Likewise.
10216         (select_source_symtab): Likewise.
10217         (enum print_source_lines_flag): Move definition from symtab.h.
10218         * symtab.h (identify_source_line): Move declaration to source.h.
10219         (print_source_lines): Likewise.
10220         (forget_cached_source_info_for_objfile): Likewise.
10221         (forget_cached_source_info): Likewise.
10222         (select_source_symtab): Likewise.
10223         (enum print_source_lines_flag): Move definition to source.h.
10224         * tui/tui-hooks.c: Add 'source.h' include.
10225
10226 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10227
10228         * source.c (print_source_lines_base): Handle requests to print
10229         reverse line number sequences, and guard against empty lines
10230         string.
10231
10232 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10233
10234         * source.c (print_source_lines_base): Fix skip of '\r' if next
10235         character is '\n'.
10236
10237 2019-01-06  Tom Tromey  <tom@tromey.com>
10238
10239         * c-exp.y (struct c_parse_state) <macro_original_text,
10240         expansion_obstack>: New member.
10241         (macro_original_text, expansion_obstack): Remove globals.
10242         (scan_macro_expansion, scanning_macro_expansion)
10243         (finished_macro_expansion): Update.
10244         (scan_macro_cleanup): Remove.
10245         (yylex, c_parse): Update.
10246
10247 2019-01-06  Tom Tromey  <tom@tromey.com>
10248
10249         * c-exp.y (struct c_parse_state) <strings>: New member.
10250         (operator_stoken): Update.
10251
10252 2019-01-06  Tom Tromey  <tom@tromey.com>
10253
10254         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10255         (union type_stack_elt) <typelist_val>: Now a pointer to
10256         std::vector.
10257         (type_stack_cleanup): Don't declare.
10258         (push_typelist): Update.
10259         * parse.c (pop_typelist): Return a std::vector.
10260         (push_typelist): Take a std::vector.
10261         (follow_types): Update.  Do not free args.
10262         (type_stack_cleanup): Remove.
10263         * c-exp.y (struct c_parse_state): New.
10264         (cpstate): New global.
10265         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10266         (nonempty_typelist): Update.
10267         (func_mod): Create a new vector.
10268         (c_parse): Create a c_parse_state.
10269         (check_parameter_typelist): Do not delete params.
10270         (function_method): Update.  Do not delete type_list.
10271
10272 2019-01-06  Tom Tromey  <tom@tromey.com>
10273
10274         PR gdb/28155:
10275         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10276         check_typedef.
10277         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10278         (print_return_value): Likewise.
10279
10280 2019-01-05  Tom Tromey  <tom@tromey.com>
10281
10282         * contrib/cleanup_check.py: Remove.
10283         * contrib/gcc-with-excheck: Remove.
10284         * contrib/exsummary.py: Remove.
10285         * contrib/excheck.py: Remove.
10286
10287 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10288
10289         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10290         NULL. Initialize tpprev to NULL instead of assigning it
10291         to NULL on the next statement.
10292         * windows-nat.c (windows_delete_thread): Remove check for
10293         main_thread_id before printing thread exit notifications.
10294         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10295         Remove thread ID check against main_thread_id.
10296         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10297         windows_delete_thread.
10298         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10299
10300 2019-01-04  Tom Tromey  <tom@tromey.com>
10301
10302         * compile/compile.c (_initialize_compile): Use upper case for
10303         metasyntactic variables.
10304         * symmisc.c (_initialize_symmisc): Use upper case for
10305         metasyntactic variables.
10306         * psymtab.c (_initialize_psymtab): Use upper case for
10307         metasyntactic variables.
10308         * demangle.c (demangle_command): Use upper case for metasyntactic
10309         variables.
10310         (_initialize_demangler): Likewise.
10311         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10312         variables.
10313
10314 2019-01-03  Tom Tromey  <tom@tromey.com>
10315
10316         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10317
10318 2019-01-03  Tom Tromey  <tom@tromey.com>
10319
10320         * python/py-symtab.c (salpy_str): Update.
10321         (struct salpy_sal_object) <symtab>: Now a PyObject.
10322         (salpy_dealloc): Update.
10323         (del_objfile_sal): Use gdbpy_ref.
10324
10325 2019-01-03  Tom Tromey  <tom@tromey.com>
10326
10327         * python/py-type.c (convert_field): Use new_reference.  Return
10328         gdbpy_ref.
10329         (make_fielditem): Return gdbpy_ref.
10330         (typy_fields): Update.
10331         (typy_getitem): Update.
10332         (field_name): Return gdbpy_ref.  Use new_reference.
10333         (typy_iterator_iternext): Update.
10334
10335 2019-01-03  Tom Tromey  <tom@tromey.com>
10336
10337         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10338
10339 2019-01-03  Tom Tromey  <tom@tromey.com>
10340
10341         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10342         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10343         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10344         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10345         (pspy_set_type_printers): Likewise.
10346         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10347         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10348         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10349         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10350         (objfpy_set_type_printers): Likewise.
10351
10352 2019-01-03  Tom Tromey  <tom@tromey.com>
10353
10354         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10355         (gdbpy_print_stack): Use gdbpy_err_fetch.
10356         * python/python-internal.h (class gdbpy_err_fetch): New class.
10357         (class gdbpy_enter) <m_error_type, m_error_value,
10358         m_error_traceback>: Remove.
10359         <m_error>: New member.
10360         (gdbpy_exception_to_string): Don't declare.
10361         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10362         * python/py-value.c (convert_value_from_python): Use
10363         gdbpy_err_fetch.
10364         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10365         gdbpy_exception_to_string.
10366         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10367         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10368         gdbpy_err_fetch.
10369
10370 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10371
10372         * linux-nat.c (delete_lwp_cleanup): Delete.
10373         (struct lwp_deleter): New struct.
10374         (lwp_info_up): New typedef.
10375         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10376         lwp_info_up.
10377
10378 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10379
10380         * linux-fork.c (class scoped_switch_fork_info): New class.
10381         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10382
10383 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10384
10385         * valops.c (find_overload_match): Remove use of null_cleanup, and
10386         calls to do_cleanups.
10387
10388 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10389
10390         * compile/compile-cplus-types.c
10391         (compile_cplus_instance::decl_name): Handle changes to
10392         cp_func_name.
10393         * cp-support.c (cp_func_name): Update header comment, update
10394         return type.
10395         * cp-support.h (cp_func_name): Update return type in declaration.
10396         * valops.c (find_overload_match): Move temp_func local to top
10397         level of function and change its type.  Use temp_func to hold and
10398         delete temporary string obtained from cp_func_name.
10399
10400 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10401
10402         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10403         gdb::char_vector, remove cleanup, and update uses of `msg`.
10404
10405 2019-01-03  Jim Wilson  <jimw@sifive.com>
10406
10407         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10408
10409 2019-01-02  Tom Tromey  <tom@tromey.com>
10410
10411         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10412         (tdesc_parse_xml): Remove cleanups.
10413         * target-descriptions.h (make_cleanup_free_target_description):
10414         Don't declare.
10415         (target_desc_deleter): New struct.
10416         (target_desc_up): New typedef.
10417         * target-descriptions.c (target_desc_deleter::operator()): Rename
10418         from free_target_description.
10419         (make_cleanup_free_target_description): Remove.
10420
10421 2019-01-02  Tom Tromey  <tom@tromey.com>
10422
10423         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10424         constructor, destructor.
10425         (linespec_parser): Remove typedef.
10426         (~linespec_parser): Rename from linespec_parser_delete.
10427         (linespec_lex_to_end, linespec_complete_label)
10428         (linespec_complete): Update.
10429         (decode_line_full): Remove cleanups.
10430         (decode_line_1): Update.
10431
10432 2019-01-02  Tom Tromey  <tom@tromey.com>
10433
10434         * python/python-internal.h (inferior_to_inferior_object): Change
10435         return type.
10436         * python/py-exitedevent.c (create_exited_event_object): Update.
10437         * python/py-inferior.c (inferior_to_inferior_object): Return
10438         gdbpy_ref.
10439         (python_new_inferior, python_inferior_deleted)
10440         (thread_to_thread_object, delete_thread_object)
10441         (build_inferior_list, gdbpy_selected_inferior): Update.
10442         * python/py-infthread.c (create_thread_object): Update.  Also fail
10443         if inferior_to_inferior_object fails.
10444
10445 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10446
10447         * inferior.h (class inferior) <displaced_step_state>: New field.
10448         * infrun.h (struct displaced_step_state): Move here from
10449         infrun.c.  Initialize fields, add constructor.
10450         <inf>: Remove field.
10451         <reset>: New method.
10452         * infrun.c (struct displaced_step_inferior_state): Move to
10453         infrun.h.
10454         (displaced_step_inferior_states): Remove.
10455         (get_displaced_stepping_state): Adust.
10456         (displaced_step_in_progress_any_inferior): Adjust.
10457         (displaced_step_in_progress_thread): Adjust.
10458         (displaced_step_in_progress): Adjust.
10459         (add_displaced_stepping_state): Remove.
10460         (get_displaced_step_closure_by_addr): Adjust.
10461         (remove_displaced_stepping_state): Remove.
10462         (infrun_inferior_exit): Call displaced_step_state.reset.
10463         (use_displaced_stepping): Don't check for NULL.
10464         (displaced_step_prepare_throw): Call
10465         get_displaced_stepping_state.
10466         (displaced_step_fixup): Don't check for NULL.
10467         (prepare_for_detach): Don't check for NULL.
10468
10469 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10470
10471         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10472          in case of call that did not complete.
10473
10474 2019-01-02  Andrey Utkin  <autkin@undo.io>
10475
10476         * symfile.c (find_separate_debug_file): Fix search of debug files for
10477         remote debuggee.
10478
10479 2019-01-02  Tom Tromey  <tom@tromey.com>
10480
10481         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10482         indentation.
10483         * python/py-frame.c (frapy_older): Remove cast.
10484         (frapy_newer): Likewise.
10485         * python/py-breakpoint.c (local_setattro): Remove cast.
10486         * python/py-arch.c (archpy_name): Remove local variable.
10487         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10488
10489 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10490
10491         * unittests/basic_string_view/element_access/char/empty.cc:
10492         Fix year range in copyright header.
10493
10494 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10495
10496         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10497         Delete.
10498         <operator==>: Update with for removed field.
10499         <hash>: Likewise.
10500         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10501         <isa_features>: ...this.
10502         <abi_features>: New field.
10503         (riscv_isa_flen): Update comment.
10504         (riscv_abi_xlen): New declaration.
10505         (riscv_abi_flen): New declaration.
10506         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10507         isa_features.
10508         (riscv_abi_xlen): New function.
10509         (riscv_isa_flen): Update to get answer from isa_features.
10510         (riscv_abi_flen): New function.
10511         (riscv_has_fp_abi): Update to get answer from abi_features.
10512         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10513         xlen and flen.
10514         (riscv_call_info) <xlen, flen>: Update comment.
10515         (riscv_call_arg_struct): Remove invalid assertions
10516         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10517         is removed.
10518         (riscv_gdbarch_init): Gather isa features and abi features
10519         separately, ensure both match on the gdbarch when reusing an old
10520         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10521         a target with 64-bit float hardware.
10522
10523 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10524
10525         * source.c (search_command_helper): Stop reverse search
10526         when line 1 has been searched.
10527
10528 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10529
10530         * record-full.c (record_full_base_target::close): Rewrite
10531         record_full_core_buf_list free logic.
10532
10533 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10534
10535         * break-catch-syscall.c (print_one_catch_syscall): xfree
10536         the last text.
10537
10538 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10539
10540         * top.c (print_gdb_version): Update Copyright year in version
10541         message.
10542
10543 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10544
10545         Update copyright year range in all GDB files.
10546
10547 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10548
10549         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10550
10551 For older changes see ChangeLog-2018.
10552 \f
10553 Local Variables:
10554 mode: change-log
10555 left-margin: 8
10556 fill-column: 74
10557 version-control: never
10558 coding: utf-8
10559 End:
10560