gdb/ChangeLog

   1 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * mn10300-tdep.c (mn10300_dummy_id): Delete.
   4         (mn10300_unwind_pc): Delete.
   5         (mn10300_unwind_sp): Delete.
   6         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
   7         mn10300_unwind_sp.
   8         (mn10300_frame_unwind_init): Don't register deleted functions with
   9         gdbarch.
  10
  11 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  12
  13         * mep-tdep.c (mep_unwind_pc): Delete.
  14         (mep_unwind_sp): Delete.
  15         (mep_dummy_id): Delete.
  16         (mep_gdbarch_init): Don't register deleted functions with
  17         gdbarch.
  18
  19 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  20
  21         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
  22         (m68hc11_unwind_sp): Delete.
  23         (m68hc11_gdbarch_init): Don't register deleted functions with
  24         gdbarch.
  25
  26 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  27
  28         * m32r-tdep.c (m32r_unwind_sp): Delete.
  29         (m32r_unwind_pc): Delete.
  30         (m32r_dummy_id): Delete.
  31         (m32r_gdbarch_init): Don't register deleted functions with
  32         gdbarch.
  33
  34 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  35
  36         * m32c-tdep.c (m32c_unwind_pc): Delete.
  37         (m32c_unwind_sp): Delete.
  38         (m32c_dummy_id): Delete.
  39         (m32c_gdbarch_init): Don't register deleted functions with
  40         gdbarch.
  41
  42 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  43
  44         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
  45         (lm32_unwind_pc): Delete.
  46         (lm32_dummy_id): Delete.
  47         (lm32_gdbarch_init): Don't register deleted functions with
  48         gdbarch.
  49
  50 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  51
  52         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
  53         (iq2000_unwind_pc): Delete.
  54         (iq2000_dummy_id): Delete.
  55         (iq2000_gdbarch_init): Don't register deleted functions with
  56         gdbarch.
  57
  58 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  59
  60         * nds32-tdep.c (nds32_type_align): Delete.
  61         (nds32_push_dummy_call): Use type_align instead.
  62
  63 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  64
  65         * arm-tdep.c (arm_type_align): Only handle vector override case.
  66         (arm_push_dummy_call): Use type_align.
  67         (arm_gdbarch_init): Register arm_type_align gdbarch function.
  68
  69 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  70
  71         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
  72         case.
  73         (pass_on_stack): Use type_align.
  74         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
  75         function.
  76
  77 2019-04-23  Tom Tromey  <tromey@adacore.com>
  78
  79         * dwarf2read.c (line_header::file_name_at): Remove unused
  80         overload.
  81
  82 2019-04-23  Tom de Vries  <tdevries@suse.de>
  83
  84         PR gdb/24438
  85         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
  86         invocation.
  87
  88
  89 2019-03-27  Ali Tamur  <tamur@google.com>
  90
  91         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
  92         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
  93         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
  94         (dwarf_expr_context::get_addr_index): Likewise
  95         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
  96         (symbol_needs_eval_context::get_addr_index): Likewise
  97         (disassemble_dwarf_expression): Add DW_OP_addrx
  98         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
  99         (read_cutu_die_from_dwo): Update comment
 100         (skip_one_die): Add DW_FORM_addrx
 101         (read_attribute_value): Likewise
 102         (var_decode_location): Add DW_OP_addrx
 103         (dwarf2_const_value_attr): Add DW_FORM_addrx
 104         (dump_die_shallow): Likewise
 105         (dwarf2_fetch_constant_bytes): Likewise
 106         (decode_locdesc): Add DW_OP_addrx
 107         (skip_form_bytes): Add DW_FORM_addrx
 108
 109 2019-04-22  Ali Tamur  <tamur@google.com>
 110
 111         * MAINTAINERS (Write After Approval): Add self.
 112
 113 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 114
 115         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 116         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 117         (open_symbol_file_object): Likewise.
 118         (svr4_default_sos): Add info parameter.
 119         (svr4_read_so_list): Likewise.
 120         (svr4_current_sos_direct): Adjust functions calls to pass down
 121         info.
 122         (svr4_current_sos_1): Add info parameter.
 123         (svr4_current_sos): Call get_svr4_info, pass info down to
 124         svr4_current_sos_1.
 125         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 126         get_svr4_info.
 127         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 128         get_svr4_info.
 129         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 130         to get_svr4_info.
 131         (probes_table_remove_objfile_probes): Likewise.
 132         (register_solib_event_probe): Add info parameter.
 133         (solist_update_incremental): Pass info parameter down to
 134         svr4_read_so_list.
 135         (disable_probes_interface): Add info parameter.
 136         (svr4_handle_solib_event): Pass current_program_space to
 137         get_svr4_info.  Adjust disable_probes_interface cleanup.
 138         (svr4_create_probe_breakpoints): Add info parameter, pass it
 139         down to register_solib_event_probe.
 140         (svr4_create_solib_event_breakpoints): Add info parameter,
 141         pass it down to svr4_create_probe_breakpoints.
 142         (enable_break): Pass info down to
 143         svr4_create_solib_event_breakpoints.
 144         (svr4_solib_create_inferior_hook): Pass current_program_space to
 145         get_svr4_info.
 146         (svr4_clear_solib): Likewise.
 147
 148 2019-04-22  Pedro Alves  <palves@redhat.com>
 149
 150         * solib-svr4.c (svr4_free_objfile_observer): New.
 151         (probe_and_action::objfile): New field.
 152         (probes_table_htab_remove_objfile_probes)
 153         (probes_table_remove_objfile_probes): New functions.
 154         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 155         in the new probe_and_action.  Don't store the probe in 'lookup'.
 156         (svr4_create_probe_breakpoints): Pass objfile to
 157         register_solib_event_probe.
 158         (_initialize_svr4_solib): Register a free_objfile observer.
 159
 160 2019-04-19  Tom Tromey  <tom@tromey.com>
 161
 162         * common/queue.h: Remove.
 163
 164 2019-04-19  Tom Tromey  <tom@tromey.com>
 165
 166         * event-loop.c: Don't include "common/queue.h".
 167
 168 2019-04-19  Tom Tromey  <tom@tromey.com>
 169
 170         * remote.c (remote_target): Use delete.
 171         * remote-notif.h: Include <list>, not "common/queue.h".
 172         (notif_client_p): Remove typedef.
 173         (remote_notif_state): Add constructor, destructor, initializer.
 174         <notif_queue>: Now a std::list.
 175         (remote_notif_state_xfree): Don't declare.
 176         * remote-notif.c (remote_notif_process, handle_notification)
 177         (remote_notif_state_allocate): Update.
 178         (~remote_notif_state): Rename from remote_notif_state_xfree.
 179
 180 2019-04-19  Tom Tromey  <tom@tromey.com>
 181
 182         * symfile.c (reread_symbols): Update.
 183         * objfiles.c (objfile_register_static_link)
 184         (objfile_lookup_static_link): Update
 185         (~objfile) Don't delete static_links.
 186         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 187
 188 2019-04-19  Tom Tromey  <tom@tromey.com>
 189
 190         * type-stack.h (struct type_stack) <insert>: Constify string.
 191         * type-stack.c (type_stack::insert): Constify string.
 192         * gdbtypes.h (lookup_template_type): Update.
 193         (address_space_name_to_int): Update.
 194         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 195         const.
 196         (lookup_template_type): Make name const.
 197         * c-exp.y: Update rules.
 198         (lex_one_token, classify_name, classify_inner_name)
 199         (c_print_token): Update.
 200         * p-exp.y: Update rules.
 201         (yylex): Update.
 202         * f-exp.y: Update rules.
 203         (yylex): Update.
 204         * d-exp.y: Update rules.
 205         (lex_one_token, classify_name, classify_inner_name): Update.
 206         * parse.c (write_dollar_variable, copy_name): Return std::string.
 207         * parser-defs.h (copy_name): Change return type.
 208         * m2-exp.y: Update rules.
 209         (yylex): Update.
 210         * go-exp.y (lex_one_token): Update.
 211         Update rules.
 212         (classify_unsafe_function, classify_packaged_name)
 213         (classify_name, yylex): Update.
 214
 215 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 216
 217         * configure.ac: add --enable-source-highlight switch.
 218         * configure: Regenerate.
 219         * top.c (print_gdb_version): plumb --enable-source-highlight
 220         status to "show configuration".
 221
 222 2019-04-19  Tom Tromey  <tromey@adacore.com>
 223
 224         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 225         Check ADA_TYPE_P.
 226         (empty_record, ada_template_to_fixed_record_type_1)
 227         (template_to_static_fixed_type)
 228         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 229         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 230         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 231         macros.
 232
 233 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 234
 235         PR symtab/24423:
 236         * source.c (print_source_lines_base): Advance "iter" when a
 237         control character is seen.
 238
 239 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 240
 241         * inferior.h (struct infcall_suspend_state_deleter):
 242         Catch exception in destructor to avoid crash.
 243
 244 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 245
 246         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 247         close to the add_com "shell".
 248
 249 2019-04-18  Tom Tromey  <tromey@adacore.com>
 250
 251         * process-stratum-target.h (class process_stratum_target)
 252         <stratum>: Add "final".
 253
 254 2019-04-17  Tom Tromey  <tromey@adacore.com>
 255
 256         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 257         against nullptr before use.
 258
 259 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 260
 261         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 262
 263 2019-04-17  Jim Wilson  <jimw@sifive.com>
 264             Andrew Burgess  <andrew.burgess@embecosm.com>
 265
 266         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 267         code read might fail, assume 4-byte breakpoint in that case.
 268
 269 2019-04-15  Leszek Swirski  <leszeks@google.com>
 270
 271         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 272         rather than a hand-rolled POD check when checking for forced MEMORY
 273         classification.
 274
 275 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 276
 277         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 278         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 279         function.
 280         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 281         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 282         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 283         declaration.
 284
 285 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 286
 287         * aarch64-linux-nat.c
 288         (aarch64_linux_nat_target::thread_architecture): Add override.
 289         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 290         each VQ.
 291
 292 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 293
 294         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 295
 296 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 297
 298         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 299         target types of size 96-bits, add some additional comments, and
 300         check that the builtin type we found was the correct size.
 301
 302 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 303
 304         * utils.c (prompt_for_continue): Don't restore the styling at the
 305         end, as applied_style has the wrong value.  This fixes styling in
 306         long lists of file names that are interrupted by the "Continue?"
 307         prompt.
 308
 309 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 310
 311         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 312         * c-lang.c (c_language_defn): Likewise.
 313         (cplus_language_defn): Likewise.
 314         (asm_language_defn): Likewise.
 315         (minimal_language_defn): Likewise.
 316         * d-lang.c (d_language_defn): Likewise.
 317         * f-lang.c (f_language_defn): Likewise.
 318         * go-lang.c (go_language_defn): Likewise.
 319         * language.c (unknown_language_defn): Likewise.
 320         (auto_language_defn): Likewise.
 321         * language.h (struct language_defn): Remove la_magic field.
 322         (LANG_MAGIC): Delete.
 323         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 324         * objc-lang.c (objc_language_defn): Likewise.
 325         * opencl-lang.c (opencl_language_defn): Likewise.
 326         * p-lang.c (pascal_language_defn): Likewise.
 327         * rust-lang.c (rust_language_defn): Likewise.
 328
 329 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 330
 331         * riscv-tdep.c (riscv_type_align): New function.
 332         (riscv_type_alignment): Delete.
 333         (riscv_arg_location): Use 'type_align'.
 334         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 335
 336 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 337
 338         * gdbtypes.c (type_align): A struct with no non-static fields also
 339         has alignment of 1.
 340
 341 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 342
 343         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 344         component to 0.
 345         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 346         member.
 347         (riscv_struct_info::analyse): New implementation using new
 348         analyse_inner member function.
 349         (riscv_struct_info::field_offset): New member function.
 350         (riscv_struct_info::m_offsets): New member variable.
 351         (riscv_struct_info::analyse_inner): New private member function,
 352         takes the old implementation of riscv_struct_info::analyse but
 353         extended to track field offsets.
 354         (riscv_call_arg_struct): Update the struct folding special cases
 355         to handle cases where empty C++ structs, which are non-zero
 356         length, are found.
 357         (riscv_arg_location): Initialise the length of each location, a
 358         non-zero length now indicates the location is in use.
 359         (riscv_push_dummy_call): Allow for the first location having a
 360         non-zero offset when setting up arguments.
 361         (riscv_return_value): Likewise, but for return values.
 362
 363 2019-04-11  Tom Tromey  <tromey@adacore.com>
 364
 365         * utils.c (internal_vproblem): Make "msg" const.
 366
 367 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 368
 369         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 370         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 371         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 372         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 373
 374 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 375
 376         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 377         function.
 378         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 379         of amd64_collect_native_gregset.
 380         (amd64_linux_nat_target::store_registers): Likewise.
 381
 382 2019-04-10  Tom Tromey  <tom@tromey.com>
 383
 384         * symtab.c (lookup_global_symbol_from_objfile)
 385         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 386         * objfiles.h (class separate_debug_iterator): New.
 387         (class separate_debug_range): New.
 388         (struct objfile) <separate_debug_objfiles>: New method.
 389         (objfile_separate_debug_iterate): Don't declare.
 390         * objfiles.c (separate_debug_iterator::operator++): Rename from
 391         objfile_separate_debug_iterate.
 392         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 393         iterator.
 394         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 395         iterator.
 396
 397 2019-04-10  Tom Tromey  <tom@tromey.com>
 398
 399         * symfile.c (reread_symbols): Remove old comment.
 400         * objfiles.c (free_all_objfiles): Fix a typo.
 401
 402 2019-04-10  Tom Tromey  <tom@tromey.com>
 403
 404         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 405         * minsyms.c (lookup_minimal_symbol): Use foreach.
 406         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 407         (lookup_minimal_symbol_solib_trampoline): Likewise.
 408         * symfile.c (reread_symbols): Use foreach.
 409
 410 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 411             Tom Tromey  <tromey@adacore.com>
 412
 413         PR rust/24414:
 414         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 415         (rust_lex_int_test): Change "value" to be LONGEST.
 416         (rust_lex_tests): Add test for long integer literal.
 417
 418 2019-04-09  Tom Tromey  <tromey@adacore.com>
 419
 420         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 421         to bool.
 422         (extended_remote_target::attach): Update.
 423         (remote_target::remote_notice_new_inferior): Update.
 424         (remote_target::add_current_inferior_and_thread): Update.
 425         * inferior.c (exit_inferior_1): Use "false".
 426         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 427
 428 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 429
 430         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 431         the "start" command.
 432
 433 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 434
 435         * python/py-inferior.c (infpy_thread_from_thread_handle):
 436         Adjust comments to reflect renaming of thread_from_thread_handle
 437         to thread_from_handle.  Adjust keywords.  Fix type error message.
 438         (inferior_object_methods): Add thread_from_handle.  Retain
 439         thread_from_thread_handle, but mark it as deprecated.
 440
 441 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 442
 443         * gdbthread.h (find_thread_by_handle): Revise declaration.
 444         * thread.c (find_thread_by_handle): Likewise.  Adjust
 445         implementation too.
 446         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 447         support for buffer objects as handles.
 448
 449 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 450
 451         * python/py-infthread.c (thpy_thread_handle): New function.
 452         (thread_object_methods): Register thpy_thread_handle.
 453
 454 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 455
 456         * gdbthread.h (thread_to_thread_handle): Declare.
 457         * thread.c (gdbtypes.h): Include.
 458         (thread_to_thread_handle): New function.
 459
 460         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 461         (target_thread_info_to_thread_handle): Declare.
 462         * target.c (target_thread_info_to_thread_handle): New function.
 463         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 464         * target-delegates.c: Regenerate.
 465
 466         * linux-thread-db.c (class thread_db_target): Add method
 467         thread_info_to_thread_handle.
 468         (thread_db_target::thread_info_to_thread_handle): Define.
 469         * remote.c (class remote_target): Add new method
 470         thread_info_to_thread_handle.
 471         (remote_target::thread_info_to_thread_handle): Define.
 472
 473 2019-04-08  Pedro Alves  <palves@redhat.com>
 474
 475         * common/common-exceptions.c (throw_exception): Don't create
 476         named object to throw; throw directly.
 477         (throw_it): Likewise.  Don't initialize gdb_exception::message
 478         here, with new; pass FMT and AP to the ctor instead.
 479         * common/common-exceptions.h: Include <string>.
 480         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 481         const char *, va_list)): New ctor.  Use std::make_shared.
 482         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 483         errors)): Delete.
 484         (gdb_exception_error::gdb_exception_error(enum errors, const char
 485         *, va_list)): New.
 486         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 487         Add assertion.
 488         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 489         errors)): Delete.
 490         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 491         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 492         Add assertion.
 493
 494 2019-04-08  Tom Tromey  <tom@tromey.com>
 495
 496         * valops.c (value_rtti_indirect_type): Replace throw_exception
 497         with throw.
 498         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 499         with throw.
 500         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 501         throw.
 502         * target.c (target_translate_tls_address): Replace throw_exception
 503         with throw.
 504         * stack.c (frame_apply_command_count): Replace throw_exception
 505         with throw.
 506         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 507         throw.
 508         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 509         with throw.
 510         * rs6000-tdep.c (rs6000_frame_cache)
 511         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 512         * remote.c: Replace throw_exception with throw.
 513         * record-full.c (record_full_message, record_full_wait_1)
 514         (record_full_restore): Replace throw_exception with throw.
 515         * record-btrace.c:
 516         (get_thread_current_frame_id, record_btrace_start_replaying)
 517         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 518         (cmd_record_btrace_start): Replace throw_exception with throw.
 519         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 520         throw.
 521         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 522         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 523         * linespec.c:
 524         (find_linespec_symbols): Replace throw_exception with throw.
 525         * infrun.c (displaced_step_prepare, resume): Replace
 526         throw_exception with throw.
 527         * infcmd.c (post_create_inferior): Replace throw_exception with
 528         throw.
 529         * inf-loop.c (inferior_event_handler): Replace throw_exception
 530         with throw.
 531         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 532         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 533         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 534         (get_prev_frame_always, get_frame_pc_if_available)
 535         (get_frame_address_in_block_if_available, get_frame_language):
 536         Replace throw_exception with throw.
 537         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 538         throw_exception with throw.
 539         * eval.c (fetch_subexp_value, evaluate_var_value)
 540         (evaluate_funcall, evaluate_subexp_standard): Replace
 541         throw_exception with throw.
 542         * dwarf2loc.c (call_site_find_chain)
 543         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 544         Replace throw_exception with throw.
 545         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 546         with throw.
 547         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 548         throw.
 549         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 550         * completer.c (complete_line_internal): Replace throw_exception
 551         with throw.
 552         * compile/compile-object-run.c (compile_object_run): Replace
 553         throw_exception with throw.
 554         * cli/cli-script.c (process_next_line): Replace throw_exception
 555         with throw.
 556         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 557         (btrace_enable, btrace_maint_update_pt_packets): Replace
 558         throw_exception with throw.
 559         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
 560         throw_exception with throw.
 561         * break-catch-throw.c (re_set_exception_catchpoint): Replace
 562         throw_exception with throw.
 563         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
 564         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
 565         * aarch64-tdep.c (aarch64_make_prologue_cache)
 566         (aarch64_make_stub_cache): Replace throw_exception with throw.
 567
 568 2019-04-08  Tom Tromey  <tom@tromey.com>
 569
 570         * common/common-exceptions.c (throw_exception): Rename from
 571         throw_exception_cxx.  Remove old copy.  Make argument const.
 572         (throw_it): Create and throw exception objects directly.
 573         * common/common-exceptions.h (throw_exception): Make argument
 574         const.
 575         (struct gdb_exception_error): Add constructor.
 576         (struct gdb_exception_quit): Add constructor.
 577
 578 2019-04-08  Tom Tromey  <tom@tromey.com>
 579
 580         * common/common-exceptions.h (exception_rethrow): Don't declare.
 581         (TRY_SJLJ): Update comment.
 582         (TRY, CATCH, END_CATCH): Remove.
 583         * common/common-exceptions.c (exception_rethrow): Remove.
 584
 585 2019-04-08  Tom Tromey  <tom@tromey.com>
 586
 587         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
 588         Remove.
 589         (gdb_exception_error): Rename from
 590         gdb_exception_RETURN_MASK_ERROR.
 591         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
 592         (gdb_quit_bad_alloc): Update.
 593         * aarch64-tdep.c: Update.
 594         * ada-lang.c: Update.
 595         * ada-typeprint.c: Update.
 596         * ada-valprint.c: Update.
 597         * amd64-tdep.c: Update.
 598         * arch-utils.c: Update.
 599         * break-catch-throw.c: Update.
 600         * breakpoint.c: Update.
 601         * btrace.c: Update.
 602         * c-varobj.c: Update.
 603         * cli/cli-cmds.c: Update.
 604         * cli/cli-interp.c: Update.
 605         * cli/cli-script.c: Update.
 606         * common/common-exceptions.c: Update.
 607         * common/new-op.c: Update.
 608         * common/selftest.c: Update.
 609         * compile/compile-c-symbols.c: Update.
 610         * compile/compile-cplus-symbols.c: Update.
 611         * compile/compile-object-load.c: Update.
 612         * compile/compile-object-run.c: Update.
 613         * completer.c: Update.
 614         * corelow.c: Update.
 615         * cp-abi.c: Update.
 616         * cp-support.c: Update.
 617         * cp-valprint.c: Update.
 618         * darwin-nat.c: Update.
 619         * disasm-selftests.c: Update.
 620         * dtrace-probe.c: Update.
 621         * dwarf-index-cache.c: Update.
 622         * dwarf-index-write.c: Update.
 623         * dwarf2-frame-tailcall.c: Update.
 624         * dwarf2-frame.c: Update.
 625         * dwarf2loc.c: Update.
 626         * dwarf2read.c: Update.
 627         * eval.c: Update.
 628         * event-loop.c: Update.
 629         * event-top.c: Update.
 630         * exec.c: Update.
 631         * f-valprint.c: Update.
 632         * fbsd-tdep.c: Update.
 633         * frame-unwind.c: Update.
 634         * frame.c: Update.
 635         * gdbtypes.c: Update.
 636         * gnu-v3-abi.c: Update.
 637         * guile/guile-internal.h: Update.
 638         * guile/scm-block.c: Update.
 639         * guile/scm-breakpoint.c: Update.
 640         * guile/scm-cmd.c: Update.
 641         * guile/scm-disasm.c: Update.
 642         * guile/scm-frame.c: Update.
 643         * guile/scm-lazy-string.c: Update.
 644         * guile/scm-math.c: Update.
 645         * guile/scm-param.c: Update.
 646         * guile/scm-ports.c: Update.
 647         * guile/scm-pretty-print.c: Update.
 648         * guile/scm-symbol.c: Update.
 649         * guile/scm-symtab.c: Update.
 650         * guile/scm-type.c: Update.
 651         * guile/scm-value.c: Update.
 652         * i386-linux-tdep.c: Update.
 653         * i386-tdep.c: Update.
 654         * inf-loop.c: Update.
 655         * infcall.c: Update.
 656         * infcmd.c: Update.
 657         * infrun.c: Update.
 658         * jit.c: Update.
 659         * language.c: Update.
 660         * linespec.c: Update.
 661         * linux-fork.c: Update.
 662         * linux-nat.c: Update.
 663         * linux-tdep.c: Update.
 664         * linux-thread-db.c: Update.
 665         * main.c: Update.
 666         * mi/mi-cmd-break.c: Update.
 667         * mi/mi-cmd-stack.c: Update.
 668         * mi/mi-interp.c: Update.
 669         * mi/mi-main.c: Update.
 670         * objc-lang.c: Update.
 671         * p-valprint.c: Update.
 672         * parse.c: Update.
 673         * ppc-linux-tdep.c: Update.
 674         * printcmd.c: Update.
 675         * python/py-arch.c: Update.
 676         * python/py-breakpoint.c: Update.
 677         * python/py-cmd.c: Update.
 678         * python/py-finishbreakpoint.c: Update.
 679         * python/py-frame.c: Update.
 680         * python/py-framefilter.c: Update.
 681         * python/py-gdb-readline.c: Update.
 682         * python/py-inferior.c: Update.
 683         * python/py-infthread.c: Update.
 684         * python/py-lazy-string.c: Update.
 685         * python/py-linetable.c: Update.
 686         * python/py-objfile.c: Update.
 687         * python/py-param.c: Update.
 688         * python/py-prettyprint.c: Update.
 689         * python/py-progspace.c: Update.
 690         * python/py-record-btrace.c: Update.
 691         * python/py-record.c: Update.
 692         * python/py-symbol.c: Update.
 693         * python/py-type.c: Update.
 694         * python/py-unwind.c: Update.
 695         * python/py-utils.c: Update.
 696         * python/py-value.c: Update.
 697         * python/python.c: Update.
 698         * record-btrace.c: Update.
 699         * record-full.c: Update.
 700         * remote-fileio.c: Update.
 701         * remote.c: Update.
 702         * riscv-tdep.c: Update.
 703         * rs6000-aix-tdep.c: Update.
 704         * rs6000-tdep.c: Update.
 705         * rust-exp.y: Update.
 706         * rust-lang.c: Update.
 707         * s390-tdep.c: Update.
 708         * selftest-arch.c: Update.
 709         * solib-dsbt.c: Update.
 710         * solib-frv.c: Update.
 711         * solib-spu.c: Update.
 712         * solib-svr4.c: Update.
 713         * solib.c: Update.
 714         * sparc64-linux-tdep.c: Update.
 715         * stack.c: Update.
 716         * symfile-mem.c: Update.
 717         * symmisc.c: Update.
 718         * target.c: Update.
 719         * thread.c: Update.
 720         * top.c: Update.
 721         * tracefile-tfile.c: Update.
 722         * tui/tui.c: Update.
 723         * typeprint.c: Update.
 724         * unittests/cli-utils-selftests.c: Update.
 725         * unittests/parse-connection-spec-selftests.c: Update.
 726         * valops.c: Update.
 727         * valprint.c: Update.
 728         * value.c: Update.
 729         * varobj.c: Update.
 730         * windows-nat.c: Update.
 731         * x86-linux-nat.c: Update.
 732         * xml-support.c: Update.
 733
 734 2019-04-08  Tom Tromey  <tom@tromey.com>
 735
 736         * xml-support.c: Use C++ exception handling.
 737         * x86-linux-nat.c: Use C++ exception handling.
 738         * windows-nat.c: Use C++ exception handling.
 739         * varobj.c: Use C++ exception handling.
 740         * value.c: Use C++ exception handling.
 741         * valprint.c: Use C++ exception handling.
 742         * valops.c: Use C++ exception handling.
 743         * unittests/parse-connection-spec-selftests.c: Use C++ exception
 744         handling.
 745         * unittests/cli-utils-selftests.c: Use C++ exception handling.
 746         * typeprint.c: Use C++ exception handling.
 747         * tui/tui.c: Use C++ exception handling.
 748         * tracefile-tfile.c: Use C++ exception handling.
 749         * top.c: Use C++ exception handling.
 750         * thread.c: Use C++ exception handling.
 751         * target.c: Use C++ exception handling.
 752         * symmisc.c: Use C++ exception handling.
 753         * symfile-mem.c: Use C++ exception handling.
 754         * stack.c: Use C++ exception handling.
 755         * sparc64-linux-tdep.c: Use C++ exception handling.
 756         * solib.c: Use C++ exception handling.
 757         * solib-svr4.c: Use C++ exception handling.
 758         * solib-spu.c: Use C++ exception handling.
 759         * solib-frv.c: Use C++ exception handling.
 760         * solib-dsbt.c: Use C++ exception handling.
 761         * selftest-arch.c: Use C++ exception handling.
 762         * s390-tdep.c: Use C++ exception handling.
 763         * rust-lang.c: Use C++ exception handling.
 764         * rust-exp.y: Use C++ exception handling.
 765         * rs6000-tdep.c: Use C++ exception handling.
 766         * rs6000-aix-tdep.c: Use C++ exception handling.
 767         * riscv-tdep.c: Use C++ exception handling.
 768         * remote.c: Use C++ exception handling.
 769         * remote-fileio.c: Use C++ exception handling.
 770         * record-full.c: Use C++ exception handling.
 771         * record-btrace.c: Use C++ exception handling.
 772         * python/python.c: Use C++ exception handling.
 773         * python/py-value.c: Use C++ exception handling.
 774         * python/py-utils.c: Use C++ exception handling.
 775         * python/py-unwind.c: Use C++ exception handling.
 776         * python/py-type.c: Use C++ exception handling.
 777         * python/py-symbol.c: Use C++ exception handling.
 778         * python/py-record.c: Use C++ exception handling.
 779         * python/py-record-btrace.c: Use C++ exception handling.
 780         * python/py-progspace.c: Use C++ exception handling.
 781         * python/py-prettyprint.c: Use C++ exception handling.
 782         * python/py-param.c: Use C++ exception handling.
 783         * python/py-objfile.c: Use C++ exception handling.
 784         * python/py-linetable.c: Use C++ exception handling.
 785         * python/py-lazy-string.c: Use C++ exception handling.
 786         * python/py-infthread.c: Use C++ exception handling.
 787         * python/py-inferior.c: Use C++ exception handling.
 788         * python/py-gdb-readline.c: Use C++ exception handling.
 789         * python/py-framefilter.c: Use C++ exception handling.
 790         * python/py-frame.c: Use C++ exception handling.
 791         * python/py-finishbreakpoint.c: Use C++ exception handling.
 792         * python/py-cmd.c: Use C++ exception handling.
 793         * python/py-breakpoint.c: Use C++ exception handling.
 794         * python/py-arch.c: Use C++ exception handling.
 795         * printcmd.c: Use C++ exception handling.
 796         * ppc-linux-tdep.c: Use C++ exception handling.
 797         * parse.c: Use C++ exception handling.
 798         * p-valprint.c: Use C++ exception handling.
 799         * objc-lang.c: Use C++ exception handling.
 800         * mi/mi-main.c: Use C++ exception handling.
 801         * mi/mi-interp.c: Use C++ exception handling.
 802         * mi/mi-cmd-stack.c: Use C++ exception handling.
 803         * mi/mi-cmd-break.c: Use C++ exception handling.
 804         * main.c: Use C++ exception handling.
 805         * linux-thread-db.c: Use C++ exception handling.
 806         * linux-tdep.c: Use C++ exception handling.
 807         * linux-nat.c: Use C++ exception handling.
 808         * linux-fork.c: Use C++ exception handling.
 809         * linespec.c: Use C++ exception handling.
 810         * language.c: Use C++ exception handling.
 811         * jit.c: Use C++ exception handling.
 812         * infrun.c: Use C++ exception handling.
 813         * infcmd.c: Use C++ exception handling.
 814         * infcall.c: Use C++ exception handling.
 815         * inf-loop.c: Use C++ exception handling.
 816         * i386-tdep.c: Use C++ exception handling.
 817         * i386-linux-tdep.c: Use C++ exception handling.
 818         * guile/scm-value.c: Use C++ exception handling.
 819         * guile/scm-type.c: Use C++ exception handling.
 820         * guile/scm-symtab.c: Use C++ exception handling.
 821         * guile/scm-symbol.c: Use C++ exception handling.
 822         * guile/scm-pretty-print.c: Use C++ exception handling.
 823         * guile/scm-ports.c: Use C++ exception handling.
 824         * guile/scm-param.c: Use C++ exception handling.
 825         * guile/scm-math.c: Use C++ exception handling.
 826         * guile/scm-lazy-string.c: Use C++ exception handling.
 827         * guile/scm-frame.c: Use C++ exception handling.
 828         * guile/scm-disasm.c: Use C++ exception handling.
 829         * guile/scm-cmd.c: Use C++ exception handling.
 830         * guile/scm-breakpoint.c: Use C++ exception handling.
 831         * guile/scm-block.c: Use C++ exception handling.
 832         * guile/guile-internal.h: Use C++ exception handling.
 833         * gnu-v3-abi.c: Use C++ exception handling.
 834         * gdbtypes.c: Use C++ exception handling.
 835         * frame.c: Use C++ exception handling.
 836         * frame-unwind.c: Use C++ exception handling.
 837         * fbsd-tdep.c: Use C++ exception handling.
 838         * f-valprint.c: Use C++ exception handling.
 839         * exec.c: Use C++ exception handling.
 840         * event-top.c: Use C++ exception handling.
 841         * event-loop.c: Use C++ exception handling.
 842         * eval.c: Use C++ exception handling.
 843         * dwarf2read.c: Use C++ exception handling.
 844         * dwarf2loc.c: Use C++ exception handling.
 845         * dwarf2-frame.c: Use C++ exception handling.
 846         * dwarf2-frame-tailcall.c: Use C++ exception handling.
 847         * dwarf-index-write.c: Use C++ exception handling.
 848         * dwarf-index-cache.c: Use C++ exception handling.
 849         * dtrace-probe.c: Use C++ exception handling.
 850         * disasm-selftests.c: Use C++ exception handling.
 851         * darwin-nat.c: Use C++ exception handling.
 852         * cp-valprint.c: Use C++ exception handling.
 853         * cp-support.c: Use C++ exception handling.
 854         * cp-abi.c: Use C++ exception handling.
 855         * corelow.c: Use C++ exception handling.
 856         * completer.c: Use C++ exception handling.
 857         * compile/compile-object-run.c: Use C++ exception handling.
 858         * compile/compile-object-load.c: Use C++ exception handling.
 859         * compile/compile-cplus-symbols.c: Use C++ exception handling.
 860         * compile/compile-c-symbols.c: Use C++ exception handling.
 861         * common/selftest.c: Use C++ exception handling.
 862         * common/new-op.c: Use C++ exception handling.
 863         * cli/cli-script.c: Use C++ exception handling.
 864         * cli/cli-interp.c: Use C++ exception handling.
 865         * cli/cli-cmds.c: Use C++ exception handling.
 866         * c-varobj.c: Use C++ exception handling.
 867         * btrace.c: Use C++ exception handling.
 868         * breakpoint.c: Use C++ exception handling.
 869         * break-catch-throw.c: Use C++ exception handling.
 870         * arch-utils.c: Use C++ exception handling.
 871         * amd64-tdep.c: Use C++ exception handling.
 872         * ada-valprint.c: Use C++ exception handling.
 873         * ada-typeprint.c: Use C++ exception handling.
 874         * ada-lang.c: Use C++ exception handling.
 875         * aarch64-tdep.c: Use C++ exception handling.
 876
 877 2019-04-08  Tom Tromey  <tom@tromey.com>
 878
 879         * xml-support.c (gdb_xml_parser::parse): Update.
 880         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 881         * value.c (show_convenience): Update.
 882         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
 883         (test_parse_flags_qcs): Update.
 884         * thread.c (thr_try_catch_cmd): Update.
 885         * target.c (target_translate_tls_address): Update.
 886         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 887         (info_frame_command_core, frame_apply_command_count): Update.
 888         * rust-exp.y (rust_lex_exception_test): Update.
 889         * riscv-tdep.c (riscv_print_one_register_info): Update.
 890         * remote.c (remote_target::enable_btrace): Update.
 891         * record-btrace.c (record_btrace_enable_warn): Update.
 892         * python/py-utils.c (gdbpy_convert_exception): Update.
 893         * printcmd.c (do_one_display, print_variable_and_value): Update.
 894         * mi/mi-main.c (mi_print_exception): Update.
 895         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
 896         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 897         * linux-nat.c (linux_nat_target::attach): Update.
 898         * linux-fork.c (class scoped_switch_fork_info): Update.
 899         * infrun.c (displaced_step_prepare): Update.
 900         * infcall.c (call_function_by_hand_dummy): Update.
 901         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
 902         * gnu-v3-abi.c (print_one_vtable): Update.
 903         * frame.c (get_prev_frame_always): Update.
 904         * f-valprint.c (info_common_command_for_block): Update.
 905         * exec.c (try_open_exec_file): Update.
 906         * exceptions.c (print_exception, exception_print)
 907         (exception_fprintf, exception_print_same): Update.
 908         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
 909         * dwarf-index-cache.c (index_cache::store)
 910         (index_cache::lookup_gdb_index): Update.
 911         * darwin-nat.c (maybe_cache_shell): Update.
 912         * cp-valprint.c (cp_print_value_fields): Update.
 913         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
 914         (gcc_cplus_symbol_address): Update.
 915         * compile/compile-c-symbols.c (gcc_convert_symbol)
 916         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
 917         * common/selftest.c: Update.
 918         * common/common-exceptions.h (struct gdb_exception) <message>: Now
 919         a std::string.
 920         (exception_try_scope_entry, exception_try_scope_exit): Don't
 921         declare.
 922         (struct exception_try_scope): Remove.
 923         (TRY): Don't use exception_try_scope.
 924         (struct gdb_exception): Add constructor, operator=.
 925         <what>: New method.
 926         (struct gdb_exception_RETURN_MASK_ALL)
 927         (struct gdb_exception_RETURN_MASK_ERROR)
 928         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
 929         (struct gdb_quit_bad_alloc): Update.
 930         * common/common-exceptions.c (exception_none): Change
 931         initializer.
 932         (struct catcher) <state, exception>: Initialize inline.
 933         <prev>: Remove member.
 934         (current_catcher): Remove.
 935         (catchers): New global.
 936         (exceptions_state_mc_init): Simplify.
 937         (catcher_pop): Remove.
 938         (exceptions_state_mc, exceptions_state_mc_catch): Update.
 939         (try_scope_depth, exception_try_scope_entry)
 940         (exception_try_scope_exit): Remove.
 941         (throw_exception_sjlj): Update.
 942         (exception_messages, exception_messages_size): Remove.
 943         (throw_it): Simplify.
 944         (gdb_exception_sliced_copy): Remove.
 945         (throw_exception_cxx): Update.
 946         * cli/cli-script.c (script_from_file): Update.
 947         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
 948         Update.
 949         * ada-valprint.c (ada_val_print): Update.
 950         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
 951         (create_excep_cond_exprs): Update.
 952
 953 2019-04-08  Tom Tromey  <tom@tromey.com>
 954
 955         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
 956         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
 957         (TRY, CATCH, END_CATCH): Remove some definitions.
 958         * common/common-exceptions.c: Don't use GDB_XCPT.
 959         (catcher_list_size): Remove.
 960         (throw_exception, throw_it): Simplify.
 961
 962 2019-04-05  Tom Tromey  <tom@tromey.com>
 963
 964         Revert the header-sorting patch.
 965         * ft32-tdep.c: Revert.
 966         * frv-tdep.c: Revert.
 967         * frv-linux-tdep.c: Revert.
 968         * frame.c: Revert.
 969         * frame-unwind.c: Revert.
 970         * frame-base.c: Revert.
 971         * fork-child.c: Revert.
 972         * findvar.c: Revert.
 973         * findcmd.c: Revert.
 974         * filesystem.c: Revert.
 975         * filename-seen-cache.h: Revert.
 976         * filename-seen-cache.c: Revert.
 977         * fbsd-tdep.c: Revert.
 978         * fbsd-nat.h: Revert.
 979         * fbsd-nat.c: Revert.
 980         * f-valprint.c: Revert.
 981         * f-typeprint.c: Revert.
 982         * f-lang.c: Revert.
 983         * extension.h: Revert.
 984         * extension.c: Revert.
 985         * extension-priv.h: Revert.
 986         * expprint.c: Revert.
 987         * exec.h: Revert.
 988         * exec.c: Revert.
 989         * exceptions.c: Revert.
 990         * event-top.c: Revert.
 991         * event-loop.c: Revert.
 992         * eval.c: Revert.
 993         * elfread.c: Revert.
 994         * dwarf2read.h: Revert.
 995         * dwarf2read.c: Revert.
 996         * dwarf2loc.c: Revert.
 997         * dwarf2expr.h: Revert.
 998         * dwarf2expr.c: Revert.
 999         * dwarf2-frame.c: Revert.
1000         * dwarf2-frame-tailcall.c: Revert.
1001         * dwarf-index-write.h: Revert.
1002         * dwarf-index-write.c: Revert.
1003         * dwarf-index-common.c: Revert.
1004         * dwarf-index-cache.h: Revert.
1005         * dwarf-index-cache.c: Revert.
1006         * dummy-frame.c: Revert.
1007         * dtrace-probe.c: Revert.
1008         * disasm.h: Revert.
1009         * disasm.c: Revert.
1010         * disasm-selftests.c: Revert.
1011         * dictionary.c: Revert.
1012         * dicos-tdep.c: Revert.
1013         * demangle.c: Revert.
1014         * dcache.h: Revert.
1015         * dcache.c: Revert.
1016         * darwin-nat.h: Revert.
1017         * darwin-nat.c: Revert.
1018         * darwin-nat-info.c: Revert.
1019         * d-valprint.c: Revert.
1020         * d-namespace.c: Revert.
1021         * d-lang.c: Revert.
1022         * ctf.c: Revert.
1023         * csky-tdep.c: Revert.
1024         * csky-linux-tdep.c: Revert.
1025         * cris-tdep.c: Revert.
1026         * cris-linux-tdep.c: Revert.
1027         * cp-valprint.c: Revert.
1028         * cp-support.c: Revert.
1029         * cp-namespace.c: Revert.
1030         * cp-abi.c: Revert.
1031         * corelow.c: Revert.
1032         * corefile.c: Revert.
1033         * continuations.c: Revert.
1034         * completer.h: Revert.
1035         * completer.c: Revert.
1036         * complaints.c: Revert.
1037         * coffread.c: Revert.
1038         * coff-pe-read.c: Revert.
1039         * cli-out.h: Revert.
1040         * cli-out.c: Revert.
1041         * charset.c: Revert.
1042         * c-varobj.c: Revert.
1043         * c-valprint.c: Revert.
1044         * c-typeprint.c: Revert.
1045         * c-lang.c: Revert.
1046         * buildsym.c: Revert.
1047         * buildsym-legacy.c: Revert.
1048         * build-id.h: Revert.
1049         * build-id.c: Revert.
1050         * btrace.c: Revert.
1051         * bsd-uthread.c: Revert.
1052         * breakpoint.h: Revert.
1053         * breakpoint.c: Revert.
1054         * break-catch-throw.c: Revert.
1055         * break-catch-syscall.c: Revert.
1056         * break-catch-sig.c: Revert.
1057         * blockframe.c: Revert.
1058         * block.c: Revert.
1059         * bfin-tdep.c: Revert.
1060         * bfin-linux-tdep.c: Revert.
1061         * bfd-target.c: Revert.
1062         * bcache.c: Revert.
1063         * ax-general.c: Revert.
1064         * ax-gdb.h: Revert.
1065         * ax-gdb.c: Revert.
1066         * avr-tdep.c: Revert.
1067         * auxv.c: Revert.
1068         * auto-load.c: Revert.
1069         * arm-wince-tdep.c: Revert.
1070         * arm-tdep.c: Revert.
1071         * arm-symbian-tdep.c: Revert.
1072         * arm-pikeos-tdep.c: Revert.
1073         * arm-obsd-tdep.c: Revert.
1074         * arm-nbsd-tdep.c: Revert.
1075         * arm-nbsd-nat.c: Revert.
1076         * arm-linux-tdep.c: Revert.
1077         * arm-linux-nat.c: Revert.
1078         * arm-fbsd-tdep.c: Revert.
1079         * arm-fbsd-nat.c: Revert.
1080         * arm-bsd-tdep.c: Revert.
1081         * arch-utils.c: Revert.
1082         * arc-tdep.c: Revert.
1083         * arc-newlib-tdep.c: Revert.
1084         * annotate.h: Revert.
1085         * annotate.c: Revert.
1086         * amd64-windows-tdep.c: Revert.
1087         * amd64-windows-nat.c: Revert.
1088         * amd64-tdep.c: Revert.
1089         * amd64-sol2-tdep.c: Revert.
1090         * amd64-obsd-tdep.c: Revert.
1091         * amd64-obsd-nat.c: Revert.
1092         * amd64-nbsd-tdep.c: Revert.
1093         * amd64-nbsd-nat.c: Revert.
1094         * amd64-nat.c: Revert.
1095         * amd64-linux-tdep.c: Revert.
1096         * amd64-linux-nat.c: Revert.
1097         * amd64-fbsd-tdep.c: Revert.
1098         * amd64-fbsd-nat.c: Revert.
1099         * amd64-dicos-tdep.c: Revert.
1100         * amd64-darwin-tdep.c: Revert.
1101         * amd64-bsd-nat.c: Revert.
1102         * alpha-tdep.c: Revert.
1103         * alpha-obsd-tdep.c: Revert.
1104         * alpha-nbsd-tdep.c: Revert.
1105         * alpha-mdebug-tdep.c: Revert.
1106         * alpha-linux-tdep.c: Revert.
1107         * alpha-linux-nat.c: Revert.
1108         * alpha-bsd-tdep.c: Revert.
1109         * alpha-bsd-nat.c: Revert.
1110         * aix-thread.c: Revert.
1111         * agent.c: Revert.
1112         * addrmap.c: Revert.
1113         * ada-varobj.c: Revert.
1114         * ada-valprint.c: Revert.
1115         * ada-typeprint.c: Revert.
1116         * ada-tasks.c: Revert.
1117         * ada-lang.c: Revert.
1118         * aarch64-tdep.c: Revert.
1119         * aarch64-ravenscar-thread.c: Revert.
1120         * aarch64-newlib-tdep.c: Revert.
1121         * aarch64-linux-tdep.c: Revert.
1122         * aarch64-linux-nat.c: Revert.
1123         * aarch64-fbsd-tdep.c: Revert.
1124         * aarch64-fbsd-nat.c: Revert.
1125         * aarch32-linux-nat.c: Revert.
1126
1127 2019-04-05  Tom Tromey  <tom@tromey.com>
1128
1129         * ft32-tdep.c: Sort headers.
1130         * frv-tdep.c: Sort headers.
1131         * frv-linux-tdep.c: Sort headers.
1132         * frame.c: Sort headers.
1133         * frame-unwind.c: Sort headers.
1134         * frame-base.c: Sort headers.
1135         * fork-child.c: Sort headers.
1136         * findvar.c: Sort headers.
1137         * findcmd.c: Sort headers.
1138         * filesystem.c: Sort headers.
1139         * filename-seen-cache.h: Sort headers.
1140         * filename-seen-cache.c: Sort headers.
1141         * fbsd-tdep.c: Sort headers.
1142         * fbsd-nat.h: Sort headers.
1143         * fbsd-nat.c: Sort headers.
1144         * f-valprint.c: Sort headers.
1145         * f-typeprint.c: Sort headers.
1146         * f-lang.c: Sort headers.
1147         * extension.h: Sort headers.
1148         * extension.c: Sort headers.
1149         * extension-priv.h: Sort headers.
1150         * expprint.c: Sort headers.
1151         * exec.h: Sort headers.
1152         * exec.c: Sort headers.
1153         * exceptions.c: Sort headers.
1154         * event-top.c: Sort headers.
1155         * event-loop.c: Sort headers.
1156         * eval.c: Sort headers.
1157         * elfread.c: Sort headers.
1158         * dwarf2read.h: Sort headers.
1159         * dwarf2read.c: Sort headers.
1160         * dwarf2loc.c: Sort headers.
1161         * dwarf2expr.h: Sort headers.
1162         * dwarf2expr.c: Sort headers.
1163         * dwarf2-frame.c: Sort headers.
1164         * dwarf2-frame-tailcall.c: Sort headers.
1165         * dwarf-index-write.h: Sort headers.
1166         * dwarf-index-write.c: Sort headers.
1167         * dwarf-index-common.c: Sort headers.
1168         * dwarf-index-cache.h: Sort headers.
1169         * dwarf-index-cache.c: Sort headers.
1170         * dummy-frame.c: Sort headers.
1171         * dtrace-probe.c: Sort headers.
1172         * disasm.h: Sort headers.
1173         * disasm.c: Sort headers.
1174         * disasm-selftests.c: Sort headers.
1175         * dictionary.c: Sort headers.
1176         * dicos-tdep.c: Sort headers.
1177         * demangle.c: Sort headers.
1178         * dcache.h: Sort headers.
1179         * dcache.c: Sort headers.
1180         * darwin-nat.h: Sort headers.
1181         * darwin-nat.c: Sort headers.
1182         * darwin-nat-info.c: Sort headers.
1183         * d-valprint.c: Sort headers.
1184         * d-namespace.c: Sort headers.
1185         * d-lang.c: Sort headers.
1186         * ctf.c: Sort headers.
1187         * csky-tdep.c: Sort headers.
1188         * csky-linux-tdep.c: Sort headers.
1189         * cris-tdep.c: Sort headers.
1190         * cris-linux-tdep.c: Sort headers.
1191         * cp-valprint.c: Sort headers.
1192         * cp-support.c: Sort headers.
1193         * cp-namespace.c: Sort headers.
1194         * cp-abi.c: Sort headers.
1195         * corelow.c: Sort headers.
1196         * corefile.c: Sort headers.
1197         * continuations.c: Sort headers.
1198         * completer.h: Sort headers.
1199         * completer.c: Sort headers.
1200         * complaints.c: Sort headers.
1201         * coffread.c: Sort headers.
1202         * coff-pe-read.c: Sort headers.
1203         * cli-out.h: Sort headers.
1204         * cli-out.c: Sort headers.
1205         * charset.c: Sort headers.
1206         * c-varobj.c: Sort headers.
1207         * c-valprint.c: Sort headers.
1208         * c-typeprint.c: Sort headers.
1209         * c-lang.c: Sort headers.
1210         * buildsym.c: Sort headers.
1211         * buildsym-legacy.c: Sort headers.
1212         * build-id.h: Sort headers.
1213         * build-id.c: Sort headers.
1214         * btrace.c: Sort headers.
1215         * bsd-uthread.c: Sort headers.
1216         * breakpoint.h: Sort headers.
1217         * breakpoint.c: Sort headers.
1218         * break-catch-throw.c: Sort headers.
1219         * break-catch-syscall.c: Sort headers.
1220         * break-catch-sig.c: Sort headers.
1221         * blockframe.c: Sort headers.
1222         * block.c: Sort headers.
1223         * bfin-tdep.c: Sort headers.
1224         * bfin-linux-tdep.c: Sort headers.
1225         * bfd-target.c: Sort headers.
1226         * bcache.c: Sort headers.
1227         * ax-general.c: Sort headers.
1228         * ax-gdb.h: Sort headers.
1229         * ax-gdb.c: Sort headers.
1230         * avr-tdep.c: Sort headers.
1231         * auxv.c: Sort headers.
1232         * auto-load.c: Sort headers.
1233         * arm-wince-tdep.c: Sort headers.
1234         * arm-tdep.c: Sort headers.
1235         * arm-symbian-tdep.c: Sort headers.
1236         * arm-pikeos-tdep.c: Sort headers.
1237         * arm-obsd-tdep.c: Sort headers.
1238         * arm-nbsd-tdep.c: Sort headers.
1239         * arm-nbsd-nat.c: Sort headers.
1240         * arm-linux-tdep.c: Sort headers.
1241         * arm-linux-nat.c: Sort headers.
1242         * arm-fbsd-tdep.c: Sort headers.
1243         * arm-fbsd-nat.c: Sort headers.
1244         * arm-bsd-tdep.c: Sort headers.
1245         * arch-utils.c: Sort headers.
1246         * arc-tdep.c: Sort headers.
1247         * arc-newlib-tdep.c: Sort headers.
1248         * annotate.h: Sort headers.
1249         * annotate.c: Sort headers.
1250         * amd64-windows-tdep.c: Sort headers.
1251         * amd64-windows-nat.c: Sort headers.
1252         * amd64-tdep.c: Sort headers.
1253         * amd64-sol2-tdep.c: Sort headers.
1254         * amd64-obsd-tdep.c: Sort headers.
1255         * amd64-obsd-nat.c: Sort headers.
1256         * amd64-nbsd-tdep.c: Sort headers.
1257         * amd64-nbsd-nat.c: Sort headers.
1258         * amd64-nat.c: Sort headers.
1259         * amd64-linux-tdep.c: Sort headers.
1260         * amd64-linux-nat.c: Sort headers.
1261         * amd64-fbsd-tdep.c: Sort headers.
1262         * amd64-fbsd-nat.c: Sort headers.
1263         * amd64-dicos-tdep.c: Sort headers.
1264         * amd64-darwin-tdep.c: Sort headers.
1265         * amd64-bsd-nat.c: Sort headers.
1266         * alpha-tdep.c: Sort headers.
1267         * alpha-obsd-tdep.c: Sort headers.
1268         * alpha-nbsd-tdep.c: Sort headers.
1269         * alpha-mdebug-tdep.c: Sort headers.
1270         * alpha-linux-tdep.c: Sort headers.
1271         * alpha-linux-nat.c: Sort headers.
1272         * alpha-bsd-tdep.c: Sort headers.
1273         * alpha-bsd-nat.c: Sort headers.
1274         * aix-thread.c: Sort headers.
1275         * agent.c: Sort headers.
1276         * addrmap.c: Sort headers.
1277         * ada-varobj.c: Sort headers.
1278         * ada-valprint.c: Sort headers.
1279         * ada-typeprint.c: Sort headers.
1280         * ada-tasks.c: Sort headers.
1281         * ada-lang.c: Sort headers.
1282         * aarch64-tdep.c: Sort headers.
1283         * aarch64-ravenscar-thread.c: Sort headers.
1284         * aarch64-newlib-tdep.c: Sort headers.
1285         * aarch64-linux-tdep.c: Sort headers.
1286         * aarch64-linux-nat.c: Sort headers.
1287         * aarch64-fbsd-tdep.c: Sort headers.
1288         * aarch64-fbsd-nat.c: Sort headers.
1289         * aarch32-linux-nat.c: Sort headers.
1290
1291 2019-04-04  Tom Tromey  <tom@tromey.com>
1292
1293         * varobj.c (varobj_create): Update.
1294         * rust-exp.y (struct rust_parser) <update_innermost_block,
1295         lookup_symbol>: New methods.
1296         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1297         Rename.
1298         (rust_parser::rust_lookup_type)
1299         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1300         * printcmd.c (display_command, do_one_display): Update.
1301         * parser-defs.h (struct parser_state) <parser_state>: Add
1302         "tracker" parameter.
1303         (block_tracker): New member.
1304         (class innermost_block_tracker) <innermost_block_tracker>: Add
1305         "types" parameter.
1306         <reset>: Remove method.
1307         (innermost_block): Don't declare.
1308         (null_post_parser): Update.
1309         * parse.c (innermost_block): Remove global.
1310         (write_dollar_variable): Update.
1311         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1312         Remove "tracker_types" parameter.
1313         (parse_expression): Add "tracker" parameter.
1314         (parse_expression_for_completion): Update.
1315         (null_post_parser): Add "tracker" parameter.
1316         * p-exp.y: Update rules.
1317         * m2-exp.y: Update rules.
1318         * language.h (struct language_defn) <la_post_parser>: Add
1319         "tracker" parameter.
1320         * go-exp.y: Update rules.
1321         * f-exp.y: Update rules.
1322         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1323         parameter.
1324         * d-exp.y: Update rules.
1325         * c-exp.y: Update rules.
1326         * breakpoint.c (set_breakpoint_condition): Create an
1327         innermost_block_tracker.
1328         (watch_command_1): Likewise.
1329         * ada-lang.c (resolve): Add "tracker" parameter.
1330         (resolve_subexp): Likewise.
1331         * ada-exp.y (write_var_from_sym): Update.
1332
1333 2019-04-04  Tom Tromey  <tom@tromey.com>
1334
1335         * type-stack.h: New file.
1336         * type-stack.c: New file.
1337         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1338         type-stack.h.
1339         (insert_into_type_stack, insert_type, push_type, push_type_int)
1340         (insert_type_address_space, pop_type, pop_type_int)
1341         (pop_typelist, pop_type_stack, append_type_stack)
1342         (push_type_stack, get_type_stack, push_typelist)
1343         (follow_type_instance_flags, follow_types): Don't declare.
1344         * parse.c (type_stack): Remove global.
1345         (parse_exp_in_context): Update.
1346         (insert_into_type_stack, insert_type, push_type, push_type_int)
1347         (insert_type_address_space, pop_type, pop_type_int)
1348         (pop_typelist, pop_type_stack, append_type_stack)
1349         (push_type_stack, get_type_stack, push_typelist)
1350         (follow_type_instance_flags, follow_types): Remove (moved to
1351         type-stack.c).
1352         * f-exp.y (type_stack): New global.
1353         Update rules.
1354         (push_kind_type, f_parse): Update.
1355         * d-exp.y (type_stack): New global.
1356         Update rules.
1357         (d_parse): Update.
1358         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1359         Update rules.
1360         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1361         (HFILES_NO_SRCDIR): Add type-stack.h.
1362
1363 2019-04-04  Tom Tromey  <tom@tromey.com>
1364
1365         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1366         (rust_parser::convert_ast_to_expression, rust_parse)
1367         (rust_lex_test_completion, rust_lex_tests): Update.
1368         * parser-defs.h (struct expr_completion_state): New.
1369         (struct parser_state) <parser_state>: Add completion parameter.
1370         <mark_struct_expression, mark_completion_tag>: New methods.
1371         <parse_completion, m_completion_state>: New members.
1372         (prefixify_expression, null_post_parser): Update.
1373         (mark_struct_expression, mark_completion_tag): Don't declare.
1374         * parse.c (parse_completion, expout_last_struct)
1375         (expout_tag_completion_type, expout_completion_name): Remove
1376         globals.
1377         (parser_state::mark_struct_expression)
1378         (parser_state::mark_completion_tag): Now methods.
1379         (prefixify_expression): Add last_struct parameter.
1380         (prefixify_subexp): Likewise.
1381         (parse_exp_1): Update.
1382         (parse_exp_in_context): Add cstate parameter.  Update.
1383         (parse_expression_for_completion): Create an
1384         expr_completion_state.
1385         (null_post_parser): Add "completion" parameter.
1386         * p-exp.y: Update rules.
1387         (yylex): Update.
1388         * language.h (struct language_defn) <la_post_parser>: Add
1389         "completing" parameter.
1390         * go-exp.y: Update rules.
1391         (lex_one_token): Update.
1392         * expression.h (parse_completion): Don't declare.
1393         * d-exp.y: Update rules.
1394         (lex_one_token): Update rules.
1395         * c-exp.y: Update rules.
1396         (lex_one_token): Update.
1397         * ada-lang.c (resolve): Add "parse_completion" parameter.
1398         (resolve_subexp): Likewise.
1399         (ada_resolve_function): Likewise.
1400
1401 2019-04-04  Tom Tromey  <tom@tromey.com>
1402
1403         * parser-defs.h (struct parser_state) <start_arglist,
1404         end_arglist>: New methods.
1405         <arglist_len, m_funcall_chain>: New members.
1406         (arglist_len, start_arglist, end_arglist): Don't declare.
1407         * parse.c (arglist_len, funcall_chain): Remove global.
1408         (start_arglist, end_arglist): Remove functions.
1409         (parse_exp_in_context): Update.
1410         * p-exp.y: Update rules.
1411         * m2-exp.y: Update rules.
1412         * go-exp.y: Update rules.
1413         * f-exp.y: Update rules.
1414         * d-exp.y: Update rules.
1415         * c-exp.y: Update rules.
1416
1417 2019-04-04  Tom Tromey  <tom@tromey.com>
1418
1419         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1420         lex_operator, push_back>: New methods.
1421         Update all rules.
1422         (rust_parser::lex_hex, lex_escape): Rename and update.
1423         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1424         (rust_parser::lex_operator): Rename and update.
1425         (rust_parser::lex_number, rustyylex, rustyyerror)
1426         (rust_lex_test_init, rust_lex_test_sequence)
1427         (rust_lex_test_push_back, rust_lex_tests): Update.
1428         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1429         parameter.
1430         <lexptr, prev_lexptr>: New members.
1431         (lexptr, prev_lexptr): Don't declare.
1432         * parse.c (lexptr, prev_lexptr): Remove globals.
1433         (parse_exp_in_context): Update.
1434         * p-exp.y (yylex, yyerror): Update.
1435         * m2-exp.y (parse_number, yylex, yyerror): Update.
1436         * go-exp.y (lex_one_token, yyerror): Update.
1437         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1438         * d-exp.y (lex_one_token, yyerror): Update.
1439         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1440         (lex_one_token, yyerror): Update.
1441         * ada-lex.l (YY_INPUT): Update.
1442         (rewind_to_char): Update.
1443         * ada-exp.y (yyerror): Update.
1444
1445 2019-04-04  Tom Tromey  <tom@tromey.com>
1446
1447         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1448         * parser-defs.h (struct parser_state) <parser_state>: Add new
1449         parameter.
1450         <comma_terminates>: New member.
1451         (comma_terminates): Don't declare global.
1452         * parse.c (comma_terminates): Remove global.
1453         (parse_exp_in_context): Update.
1454         * p-exp.y (yylex): Update.
1455         * m2-exp.y (yylex): Update.
1456         * go-exp.y (lex_one_token): Update.
1457         * f-exp.y (yylex): Update.
1458         * d-exp.y (lex_one_token): Update.
1459         * c-exp.y (lex_one_token): Update.
1460         * ada-lex.l: Update.
1461
1462 2019-04-04  Tom Tromey  <tom@tromey.com>
1463
1464         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1465         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1466         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1467         * parser-defs.h (paren_depth): Don't declare.
1468         * parse.c (paren_depth): Remove global.
1469         (parse_exp_in_context): Update.
1470         * p-exp.y (paren_depth): New global.
1471         (pascal_parse): Initialize it.
1472         * m2-exp.y (paren_depth): New global.
1473         (m2_parse): Initialize it.
1474         * go-exp.y (paren_depth): New global.
1475         (go_parse): Initialize it.
1476         * f-exp.y (paren_depth): New global.
1477         (f_parse): Initialize it.
1478         * d-exp.y (paren_depth): New global.
1479         (d_parse): Initialize it.
1480         * c-exp.y (paren_depth): New global.
1481         (c_parse): Initialize it.
1482         * ada-lex.l (paren_depth): New global.
1483         (lexer_init): Initialize it.
1484
1485 2019-04-04  Tom Tromey  <tom@tromey.com>
1486
1487         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1488         (rust_parser::convert_ast_to_type)
1489         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1490         * parser-defs.h (struct parser_state) <parser_state>: Add
1491         parameters.  Initialize new members.
1492         <expression_context_block, expression_context_pc>: New members.
1493         * parse.c (expression_context_block, expression_context_pc):
1494         Remove globals.
1495         (parse_exp_in_context): Update.
1496         * p-exp.y: Update all rules.
1497         (yylex): Update.
1498         * m2-exp.y: Update all rules.
1499         (yylex): Update.
1500         * go-exp.y (yylex): Update.
1501         * f-exp.y (yylex): Update.
1502         * d-exp.y: Update all rules.
1503         (yylex): Update.
1504         * c-exp.y: Update all rules.
1505         (lex_one_token, classify_name, yylex, c_parse): Update.
1506         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1507
1508 2019-04-04  Tom Tromey  <tom@tromey.com>
1509
1510         * gdbarch.h, gdbarch.c: Rebuild.
1511         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1512         * stap-probe.h:
1513         (struct stap_parse_info): Replace "parser_state" with
1514         "expr_builder".
1515         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1516         (parser_state): New class.
1517         * parse.c (expr_builder): Rename.
1518         (expr_builder::release): Rename.
1519         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1520         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1521         (write_exp_elt_longcst, write_exp_elt_floatcst)
1522         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1523         (write_exp_string_vector, write_exp_bitstring)
1524         (write_exp_msymbol, mark_struct_expression)
1525         (write_dollar_variable)
1526         (insert_type_address_space, increase_expout_size): Replace
1527         "parser_state" with "expr_builder".
1528         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1529         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1530         "parser_state" with "expr_builder".
1531
1532 2019-04-04  Tom Tromey  <tom@tromey.com>
1533
1534         * rust-exp.y: Replace "parse_language" with method call.
1535         * p-exp.y:
1536         (yylex): Replace "parse_language" with method call.
1537         * m2-exp.y:
1538         (yylex): Replace "parse_language" with method call.
1539         * go-exp.y (classify_name): Replace "parse_language" with method
1540         call.
1541         * f-exp.y (yylex): Replace "parse_language" with method call.
1542         * d-exp.y (lex_one_token): Replace "parse_language" with method
1543         call.
1544         * c-exp.y:
1545         (lex_one_token, classify_name, yylex): Replace "parse_language"
1546         with method call.
1547         * ada-exp.y (find_primitive_type, type_char)
1548         (type_system_address): Replace "parse_language" with method call.
1549
1550 2019-04-04  Tom Tromey  <tom@tromey.com>
1551
1552         * rust-exp.y: Replace "parse_gdbarch" with method call.
1553         * parse.c (write_dollar_variable, insert_type_address_space):
1554         Replace "parse_gdbarch" with method call.
1555         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1556         call.
1557         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1558         call.
1559         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1560         "parse_gdbarch" with method call.
1561         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1562         with method call.
1563         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1564         "parse_gdbarch" with method call.
1565         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1566         "parse_gdbarch" with method call.
1567         * c-exp.y (parse_type, parse_number, classify_name): Replace
1568         "parse_gdbarch" with method call.
1569         * ada-lex.l: Replace "parse_gdbarch" with method call.
1570         * ada-exp.y (parse_type, find_primitive_type, type_char)
1571         (type_system_address): Replace "parse_gdbarch" with method call.
1572
1573 2019-04-04  Tom Tromey  <tom@tromey.com>
1574
1575         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1576         * stap-probe.c (stap_parse_argument): Update.
1577         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1578         initial_size parameter.
1579         * rust-exp.y (rust_lex_tests): Update.
1580         * parse.c (parser_state): Update.
1581         (parse_exp_in_context): Update.
1582         * parser-defs.h (struct parser_state) <parser_state>: Remove
1583         "initial_size" parameter.
1584
1585 2019-04-04  Tom Tromey  <tom@tromey.com>
1586
1587         * parser-defs.h (increase_expout_size): Don't declare.
1588         * parse.c (increase_expout_size): Now static.
1589
1590 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1591
1592         * gnu-nat.c (gnu_nat_target::wait): Fix
1593         target_waitstatus_to_string call.
1594
1595 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1596
1597         * eval.c (evaluate_subexp_standard): Handle internal functions
1598         during Fortran function call handling.
1599
1600 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1601
1602         * NEWS: Mention new internal functions.
1603         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1604         (read_base_type): Use dwarf2_init_complex_target_type.
1605         * value.c (creal_internal_fn): New function.
1606         (cimag_internal_fn): New function.
1607         (_initialize_values): Register new internal functions.
1608
1609 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1610
1611         * infrun.c (stop_all_threads): If debug_infrun, always
1612         trace the wait status after wait_one, using
1613         target_waitstatus_to_string and target_pid_to_str.
1614         (handle_inferior_event): Replace various trace of
1615         wait status kind by a single trace.
1616         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1617         wait status kind image by target_waitstatus_to_string.
1618         * target/waitstatus.c (target_waitstatus_to_string): Fix
1619         obsolete comment.
1620
1621 2019-04-01  Tom Tromey  <tromey@adacore.com>
1622
1623         PR symtab/23331:
1624         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1625
1626 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1627             Pedro Alves  <palves@redhat.com>
1628
1629         * top.c (quit_force): Call 'finalize_values'.
1630         * value.c (finalize_values): New function.
1631         * value.h (finalize_values): Declare.
1632
1633 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1634
1635         * NEWS: Announce $_gdb_major and $_gdb_minor.
1636
1637         * top.c (init_gdb_version_vars): New function.
1638         (gdb_init): Call init_gdb_version_vars.
1639
1640 2019-03-29  Tom Tromey  <tromey@adacore.com>
1641
1642         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1643         help text.  Remove dead code.
1644
1645 2019-03-29  Keith Seitz  <keiths@redhat.com>
1646
1647         From Siddhesh Poyarekar:
1648         * f-lang.h (f77_get_upperbound): Return LONGEST.
1649         (f77_get_lowerbound): Likewise.
1650         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1651         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1652         print them.
1653         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1654         plongest to format print it.
1655         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1656         (f77_get_upperbound): Likewise.
1657         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1658         LOWER_BOUND to LONGEST.
1659         (f77_create_arrayprint_offset_tbl): Likewise.
1660
1661 2019-03-29  Keith Seitz  <keiths@redhat.com>
1662
1663         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1664         %s/pulongest for TYPE_LENGTH instead of %d in format
1665         strings.
1666         * ada-typerint.c (ada_print_type): Likewise.
1667         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1668         * compile/compile-c-support.c (generate_register_struct): Likewise.
1669         * gdbtypes.c (recursive_dump_type): Likewise.
1670         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1671         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1672         instead of %d in format strings.
1673         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1674         to std::min to ULONGEST.
1675         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1676         instead of %d in format strings.
1677         * tracepoint.c (info_scope_command): Likewise.
1678         * typeprint.c (print_offset_data::update)
1679         (print_offset_data::finish): Likewise.
1680         * xtensa-tdep.c (xtensa_store_return_value)
1681         (xtensa_push_dummy_call): Likewise.
1682
1683 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1684
1685         * windows-nat.c (display_selector): Fixed format specifications
1686         for 64-bit Cygwin.
1687
1688 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1689
1690         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1691
1692 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1693
1694         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1695         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1696         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1697         (nios2_linux_init_abi): Install it.
1698
1699 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1700
1701         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1702
1703 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1704
1705         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1706
1707 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1708             Tom Tromey  <tromey@adacore.com>
1709
1710         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1711
1712 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1713
1714         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1715         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1716         method to compute the bounds of range types. Also print "[evaluated]"
1717         if the bounds' values come from a dynamic evaluation.
1718
1719 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1720
1721         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1722         whitespace when pretty printing is on.
1723
1724 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1725
1726         * ppc-linux-nat.c: Add include.
1727
1728 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1729
1730         * NEWS: Mention AArch64 Pointer Authentication.
1731
1732 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1733
1734         * arm-linux-nat.c: Add include.
1735
1736 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1737
1738         * source-cache.c (source_cache::get_source_lines): Re-read
1739         fullname after calling open_source_file.
1740
1741 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1742
1743         * NEWS: Mention TLS support for FreeBSD.
1744
1745 2019-03-25  Tom Tromey  <tromey@adacore.com>
1746
1747         * minsyms.c (BUNCH_SIZE): Update comment.
1748         (~minimal_symbol_reader): Remove old comment.
1749         (compact_minimal_symbols): Update comment.
1750         (minimal_symbol_reader::install): Remove old comment.  Update
1751         other comments.
1752
1753 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1754
1755         * s390-linux-nat.c: Add include.
1756
1757 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1758
1759         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1760         Call linux_get_hwcap.
1761         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1762         Likewise.
1763         (aarch64_linux_get_hwcap): Remove function.
1764         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1765         declaration.
1766         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1767         linux_get_hwcap.
1768         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1769         * linux-tdep.c (linux_get_hwcap): Add function.
1770         (linux_get_hwcap2): Likewise.
1771         * linux-tdep.h (linux_get_hwcap): Add declaration.
1772         (linux_get_hwcap2): Likewise.
1773         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1774         (ppc_linux_get_hwcap2): Likewise.
1775         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1776         linux_get_hwcap.
1777         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1778         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1779         (ppc_linux_nat_target::read_description): Likewise.
1780         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1781         * s390-linux-nat.c: Likewise.
1782         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1783
1784 2019-03-24  Tom Tromey  <tom@tromey.com>
1785
1786         * ada-lang.c (standard_lookup): Simplify initialization.
1787         (ada_lookup_symbol_nonlocal): Simplify return.
1788         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1789         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1790         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1791         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1792         initialization.
1793         * solib.c (solib_global_lookup): Simplify.
1794         * symtab.c (null_block_symbol): Remove.
1795         (symbol_cache_lookup): Simplify returns.
1796         (lookup_language_this): Simplify returns.
1797         (lookup_symbol_aux): Simplify return.
1798         (lookup_local_symbol): Simplify returns.
1799         (lookup_global_symbol_from_objfile): Simplify return.
1800         (lookup_symbol_in_objfile_symtabs)
1801         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1802         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1803         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1804         * cp-namespace.c (cp_lookup_bare_symbol)
1805         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1806         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1807         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1808         (cp_lookup_symbol_via_imports): Simplify initialization.
1809         (find_symbol_in_baseclass): Likewise.
1810         * symtab.h (null_block_symbol): Remove.
1811         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1812         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1813         (d_lookup_symbol_module): Likewise.
1814         (find_symbol_in_baseclass): Simplify initialization.
1815
1816 2019-03-24  Tom Tromey  <tom@tromey.com>
1817
1818         * expression.h: Don't include symtab.h.
1819         (struct block): Forward declare.
1820
1821 2019-03-24  Tom Tromey  <tom@tromey.com>
1822
1823         * c-exp.y (typebase): Remove casts.
1824         * gdbtypes.c (lookup_unsigned_typename, )
1825         (lookup_signed_typename): Remove cast.
1826         * eval.c (parse_to_comma_and_eval): Remove cast.
1827         * parse.c (write_dollar_variable): Remove cast.
1828         * block.h (struct block) <superblock>: Now const.
1829         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1830         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1831         (map_block): Make "block" const.
1832         * symfile.h (struct quick_symbol_functions)
1833         <map_matching_symbols>: Constify block argument to "callback".
1834         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1835         const.
1836         (find_pc_sect_compunit_symtab): Make "b" const.
1837         (find_symbol_at_address): Likewise.
1838         (search_symbols): Likewise.
1839         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1840         (dw2_debug_names_lookup_symbol): Likewise.
1841         (dw2_map_matching_symbols): Update.
1842         * p-valprint.c (pascal_val_print): Remove "block".
1843         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1844         (aux_add_nonlocal_symbols): Make "block" const.
1845         (resolve_subexp): Remove cast.
1846         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1847         const.
1848         (iterate_over_file_blocks): Likewise.
1849         * f-exp.y (%union) <bval>: Remove.
1850         * coffread.c (patch_opaque_types): Make "b" const.
1851         * spu-tdep.c (spu_catch_start): Make "block" const.
1852         * c-valprint.c (print_unpacked_pointer): Remove "block".
1853         * symmisc.c (dump_symtab_1): Make "b" const.
1854         (block_depth): Make "block" const.
1855         * d-exp.y (%union) <bval>: Remove.
1856         * cp-support.h (cp_lookup_rtti_type): Update.
1857         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1858         * psymtab.c (psym_lookup_symbol): Make "block" const.
1859         (maintenance_check_psymtabs): Make "b" const.
1860         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1861         (enumerate_locals, enumerate_args): Update.
1862         * python/py-symtab.c (stpy_global_block): Make "block" const.
1863         (stpy_static_block): Likewise.
1864         * inline-frame.c (block_starting_point_at): Make "new_block"
1865         const.
1866         * block.c (find_block_in_blockvector): Make return type const.
1867         (blockvector_for_pc_sect): Make "b" const.
1868         (find_block_in_blockvector): Make "b" const.
1869
1870 2019-03-23  Tom Tromey  <tom@tromey.com>
1871
1872         * varobj.c (varobj_create): Update.
1873         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1874         * printcmd.c (display_command, do_one_display): Don't reset
1875         innermost_block.
1876         * parser-defs.h (enum innermost_block_tracker_type): Move to
1877         expression.h.
1878         (innermost_block): Update comment.
1879         * parse.c (parse_exp_1): Add tracker_types parameter.
1880         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1881         tracker_types parameter.  Reset innermost_block.
1882         (parse_exp_in_context): Remove.
1883         (parse_expression_for_completion): Update.
1884         * objfiles.c (~objfile): Don't reset expression_context_block or
1885         innermost_block.
1886         * expression.h (enum innermost_block_tracker_type): Move from
1887         parser-defs.h.
1888         (parse_exp_1): Add tracker_types parameter.
1889         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1890         reset innermost_block.
1891
1892 2019-03-23  Tom Tromey  <tom@tromey.com>
1893
1894         * objfiles.h: Include bcache.h.
1895
1896 2019-03-23  Tom Tromey  <tom@tromey.com>
1897
1898         * linespec.c (get_current_search_block): Use
1899         scoped_restore_current_language.
1900         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1901
1902 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1903             Jiong Wang  <jiong.wang@arm.com>
1904
1905         * aarch64-linux-tdep.c
1906         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1907         section.
1908         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1909
1910 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1911             Jiong Wang  <jiong.wang@arm.com>
1912
1913         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1914         instructions.
1915         (aarch64_analyze_prologue_test): Add PACIASP test.
1916         (aarch64_prologue_prev_register): Unmask PC value.
1917
1918 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1919             Jiong Wang  <jiong.wang@arm.com>
1920
1921         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1922         (aarch64_dwarf2_prev_register): Unmask PC value.
1923         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1924         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1925         DW_CFA_AARCH64_negate_ra_state.
1926         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1927
1928 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1929             Jiong Wang  <jiong.wang@arm.com>
1930
1931         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1932         registers.
1933         (aarch64_pseudo_register_name): Likewise.
1934         (aarch64_pseudo_register_type): Likewise.
1935         (aarch64_pseudo_register_reggroup_p): Likewise.
1936         (aarch64_gdbarch_init): Add pauth registers.
1937         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1938         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1939         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1940         (struct gdbarch_tdep): Add regnum for ra_state.
1941
1942 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1943             Jiong Wang  <jiong.wang@arm.com>
1944
1945         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1946
1947 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1948             Jiong Wang  <jiong.wang@arm.com>
1949
1950         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1951         function.
1952         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1953         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1954         (aarch64_gdbarch_init): Add puth registers.
1955         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1956         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1957         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1958
1959 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1960             Jiong Wang  <jiong.wang@arm.com>
1961
1962         * aarch64-linux-nat.c
1963         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1964         * aarch64-linux-tdep.c
1965         (aarch64_linux_core_read_description): Likewise.
1966         (aarch64_linux_get_hwcap): New function.
1967         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1968         (aarch64_linux_get_hwcap): New declaration.
1969
1970 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1971             Jiong Wang  <jiong.wang@arm.com>
1972
1973         * aarch64-linux-nat.c
1974         (aarch64_linux_nat_target::read_description): Add pauth param.
1975         * aarch64-linux-tdep.c
1976         (aarch64_linux_core_read_description): Likewise.
1977         * aarch64-tdep.c (struct target_desc): Add in pauth.
1978         (aarch64_read_description): Add pauth param.
1979         (aarch64_gdbarch_init): Likewise.
1980         * aarch64-tdep.h (aarch64_read_description): Likewise.
1981         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1982         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1983         * features/Makefile: Add new files.
1984         * features/aarch64-pauth.c: New file.
1985         * features/aarch64-pauth.xml: New file.
1986
1987 2019-03-20  Tom Tromey  <tromey@adacore.com>
1988
1989         * infrun.c (handle_inferior_event): Rename from
1990         handle_inferior_event_1.  Create a scoped_value_mark.
1991         (handle_inferior_event): Remove.
1992
1993 2019-03-19  Tom Tromey  <tromey@adacore.com>
1994
1995         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1996         * infrun.h (print_stop_event): Add "displays" parameter.
1997         * infrun.c (print_stop_event): Add "displays" parameter.
1998
1999 2019-03-19  Pedro Alves  <palves@redhat.com>
2000
2001         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2002         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2003         to -1.  Fix TABs vs spaces.
2004         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2005         * tui/tui-out.h (tui_ui_out) Add intro comments.
2006         <m_line, m_start_of_line>: In-class initialize, and add describing
2007         comment.
2008
2009 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2010
2011         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2012         variable names.
2013         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2014
2015 2019-03-18  Pedro Alves  <palves@redhat.com>
2016             Eli Zaretskii <eliz@gnu.org>
2017
2018         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2019         m_line and m_start_of_line.
2020
2021 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2022
2023         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2024         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2025         it returns a newline.  This fixes a regression in TU mode, whereby
2026         the next line is output on the same screen line as the user input.
2027
2028 2019-03-18  Tom Tromey  <tromey@adacore.com>
2029
2030         * minsyms.c (minimal_symbol_reader::install): Remove call to
2031         obstack_blank.
2032
2033 2019-03-18  Pedro Alves  <palves@redhat.com>
2034
2035         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2036         New globals.
2037         (apply_style): New, factored out from ...
2038         (apply_ansi_escape): ... this.  Handle reverse video mode.
2039         (tui_set_reverse_mode): New function.
2040         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2041         * tui/tui-winsource.c (tui_show_source_line): Use
2042         tui_set_reverse_mode instead of setting A_STANDOUT.
2043         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2044         New setter methods.
2045
2046 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2047
2048         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2049         Handle tabs.
2050
2051 2019-03-18  Tom Tromey  <tromey@adacore.com>
2052
2053         * ada-lang.c (empty_array): Add "high" parameter.
2054         (ada_evaluate_subexp): Update.
2055
2056 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2057
2058         * unittests/string_view-selftests.c: Define
2059         _initialize_string_view_selftests unconditionally.
2060
2061 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2062
2063         PR gdb/24350
2064         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2065
2066 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2067
2068         PR gdb/24351
2069         * windows-nat.c (display_selector): Fix format specifiers.
2070
2071 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2072
2073         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2074         tui_refill_source_window instead of tui_refresh_win, to update the
2075         current execution line.  This fixes redisplay of the current line
2076         when stepping through the code with "next" or "step".
2077
2078 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2079
2080         * source-cache.c (source_cache::get_source_lines): Call
2081         find_source_lines to initialize s->nlines.  This fixes vertical
2082         scrolling of TUI source window when the DOWN arrow is pressed.
2083
2084 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2085
2086         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2087         linux-thread-db.c (_initialize_thread_db): Likewise.
2088
2089 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2090
2091         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2092         wclrtoeol in tui_show_source_line".  This reverts changes made in
2093         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2094
2095 2019-03-15  Tom Tromey  <tom@tromey.com>
2096
2097         * symtab.h (struct minimal_symbol): Derive from
2098         general_symbol_info.
2099         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2100         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2101         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2102         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2103         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2104         (MSYMBOL_SEARCH_NAME): Update.
2105         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2106         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2107         * minsyms.c (minimal_symbol_reader::record_full): Update.
2108
2109 2019-03-15  Tom Tromey  <tom@tromey.com>
2110
2111         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2112
2113 2019-03-15  Tom Tromey  <tom@tromey.com>
2114
2115         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2116         unique_xmalloc_ptr.
2117         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2118         Update.
2119         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2120         (build_minimal_symbol_hash_tables)
2121         (minimal_symbol_reader::install): Update.
2122
2123 2019-03-15  Tom Tromey  <tom@tromey.com>
2124
2125         * symtab.c (create_demangled_names_hash): Update.
2126         (symbol_set_names): Update.
2127         * objfiles.h (struct objfile_per_bfd_storage)
2128         <demangled_names_hash>: Now an htab_up.
2129         * objfiles.c (objfile_per_bfd_storage): Simplify.
2130
2131 2019-03-15  Tom Tromey  <tom@tromey.com>
2132
2133         * objfiles.h (struct objfile_per_bfd_storage): Declare
2134         destructor.
2135         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2136         New.
2137         (get_objfile_bfd_data): Use new.  Don't initialize
2138         language_of_main.
2139         (free_objfile_per_bfd_storage): Remove.
2140         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2141
2142 2019-03-15  Tom Tromey  <tom@tromey.com>
2143
2144         * symfile.c (reread_symbols): Update.
2145         * objfiles.c (objfile::objfile): Update.
2146         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2147         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2148         comment.
2149         (minimal_symbol_reader::install): Update.
2150         (terminate_minimal_symbol_table): Remove.
2151         * jit.c (jit_object_close_impl): Update.
2152
2153 2019-03-15  Tom Tromey  <tom@tromey.com>
2154
2155         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2156         initializations.
2157
2158 2019-03-15  Tom Tromey  <tom@tromey.com>
2159
2160         * objfiles.h (struct objfile_per_bfd_storage)
2161         <demangled_hash_languages>: Now a bitset.
2162         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2163         (lookup_minimal_symbol): Update.
2164
2165 2019-03-15  Tom Tromey  <tom@tromey.com>
2166
2167         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2168         Don't return the symbol.
2169         * coffread.c (record_minimal_symbol): Use record_full.
2170
2171 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2172
2173         The MS-Windows port of ncurses fails to switch to a color pair if
2174         one or both of the colors are the implicit default colors.  This
2175         change records the default colors when TUI is initialized, and
2176         then specifies them explicitly when a color pair uses the default
2177         colors.  This allows color styling in TUI mode on MS-Windows.
2178
2179         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2180         ncurses_norm_attr.
2181         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2182         colors in ncurses_norm_attr.
2183         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2184         "none", replace it with the default color recorded in
2185         ncurses_norm_attr.
2186
2187 2019-03-14  Tom Tromey  <tromey@adacore.com>
2188
2189         * source-cache.h (class source_cache) <get_source_lines>: Return
2190         std::string.
2191         * source-cache.c (source_cache::extract_lines): Handle case where
2192         first_pos==npos.  Return std::string.
2193         (source_cache::get_source_lines): Update.
2194
2195 2019-03-14  Tom Tromey  <tromey@adacore.com>
2196
2197         * NEWS: Add item for "style sources" commands.
2198         * source-cache.c (source_cache::get_source_lines): Check
2199         source_styling.
2200         * cli/cli-style.c (source_styling): New global.
2201         (_initialize_cli_style): Add "style sources" commands.
2202         (show_style_sources): New function.
2203         * cli/cli-style.h (source_styling): Declare.
2204
2205 2019-03-14  Pedro Alves  <palves@redhat.com>
2206             Tom Tromey  <tromey@adacore.com>
2207
2208         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2209         * tui/tui-winsource.c (tui_refill_source_window): New function,
2210         from...
2211         (tui_horizontal_source_scroll): ... here.  Move some logic.
2212         * cli/cli-style.c (set_style_enabled): Notify new observable.
2213         * tui/tui-hooks.c (tui_redisplay_source): New function.
2214         (tui_attach_detach_observers): Attach or detach
2215         tui_redisplay_source.
2216         * observable.h (source_styling_changed): New observable.
2217         * observable.c: Define source_styling_changed observable.
2218
2219 2019-03-13  Tom Tromey  <tromey@adacore.com>
2220
2221         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2222         (i386_gnu_nat_target::store_registers): Update.
2223         * target-debug.h (target_debug_print_std_string): New macro.
2224         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2225         * windows-tdep.c (display_one_tib): Update.
2226         * tui/tui-stack.c (tui_make_status_line): Update.
2227         * top.c (print_inferior_quit_action): Update.
2228         * thread.c (thr_try_catch_cmd): Update.
2229         (add_thread_with_info): Update.
2230         (thread_target_id_str): Update.
2231         (thr_try_catch_cmd): Update.
2232         (thread_command): Update.
2233         (thread_find_command): Update.
2234         * record-btrace.c (record_btrace_target::info_record)
2235         (record_btrace_resume_thread, record_btrace_target::resume)
2236         (record_btrace_cancel_resume, record_btrace_step_thread)
2237         (record_btrace_target::wait, record_btrace_target::wait)
2238         (record_btrace_target::wait, record_btrace_target::stop): Update.
2239         * progspace.c (print_program_space): Update.
2240         * process-stratum-target.c
2241         (process_stratum_target::thread_address_space): Update.
2242         * linux-fork.c (linux_fork_mourn_inferior)
2243         (detach_checkpoint_command, info_checkpoints_command)
2244         (linux_fork_context): Update.
2245         (linux_fork_detach): Update.
2246         (class scoped_switch_fork_info): Update.
2247         (delete_checkpoint_command): Update.
2248         * infrun.c (follow_fork_inferior): Update.
2249         (follow_fork_inferior): Update.
2250         (proceed_after_vfork_done): Update.
2251         (handle_vfork_child_exec_or_exit): Update.
2252         (follow_exec): Update.
2253         (displaced_step_prepare_throw): Update.
2254         (displaced_step_restore): Update.
2255         (start_step_over): Update.
2256         (resume_1): Update.
2257         (clear_proceed_status_thread): Update.
2258         (proceed): Update.
2259         (print_target_wait_results): Update.
2260         (do_target_wait): Update.
2261         (context_switch): Update.
2262         (stop_all_threads): Update.
2263         (restart_threads): Update.
2264         (finish_step_over): Update.
2265         (handle_signal_stop): Update.
2266         (switch_back_to_stepped_thread): Update.
2267         (keep_going_pass_signal): Update.
2268         (print_exited_reason): Update.
2269         (normal_stop): Update.
2270         * inferior.c (inferior_pid_to_str): Change return type.
2271         (print_selected_inferior): Update.
2272         (add_inferior): Update.
2273         (detach_inferior): Update.
2274         * dummy-frame.c (fprint_dummy_frames): Update.
2275         * dcache.c (dcache_info_1): Update.
2276         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2277         (btrace_fetch, btrace_clear): Update.
2278         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2279         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2280         type.
2281         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2282         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2283         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2284         * gdbarch.c, gdbarch.h: Rebuild.
2285         * gdbarch.sh (core_pid_to_str): Change return type.
2286         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2287         return type.
2288         (windows_nat_target::pid_to_str): Change return type.
2289         (windows_delete_thread): Update.
2290         (windows_nat_target::attach): Update.
2291         (windows_nat_target::files_info): Update.
2292         * target-delegates.c: Rebuild.
2293         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2294         return type.
2295         (sol_thread_target::pid_to_str): Change return type.
2296         * remote.c (class remote_target) <pid_to_str>: Change return
2297         type.
2298         (remote_target::pid_to_str): Change return type.
2299         (extended_remote_target::attach, remote_target::remote_stop_ns)
2300         (remote_target::remote_notif_remove_queued_reply)
2301         (remote_target::push_stop_reply, remote_target::disable_btrace):
2302         Update.
2303         (extended_remote_target::attach): Update.
2304         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2305         type.
2306         (gdbsim_target::pid_to_str): Change return type.
2307         * ravenscar-thread.c (struct ravenscar_thread_target)
2308         <pid_to_str>: Change return type.
2309         (ravenscar_thread_target::pid_to_str): Change return type.
2310         * procfs.c (class procfs_target) <pid_to_str>: Change return
2311         type.
2312         (procfs_target::pid_to_str): Change return type.
2313         (procfs_target::attach): Update.
2314         (procfs_target::detach): Update.
2315         (procfs_target::fetch_registers): Update.
2316         (procfs_target::store_registers): Update.
2317         (procfs_target::wait): Update.
2318         (procfs_target::files_info): Update.
2319         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2320         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2321         return type.
2322         (nto_procfs_target::pid_to_str): Change return type.
2323         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2324         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2325         return type.
2326         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2327         (exit_lwp): Update.
2328         (attach_proc_task_lwp_callback, get_detach_signal)
2329         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2330         (linux_nat_target::resume, wait_lwp, stop_callback)
2331         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2332         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2333         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2334         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2335         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2336         type.
2337         (inf_ptrace_target::attach): Update.
2338         (inf_ptrace_target::files_info): Update.
2339         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2340         type.
2341         (go32_nat_target::pid_to_str): Change return type.
2342         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2343         (gnu_nat_target::wait): Update.
2344         (gnu_nat_target::wait): Update.
2345         (gnu_nat_target::resume): Update.
2346         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2347         (fbsd_nat_target::wait): Update.
2348         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2349         type.
2350         (darwin_nat_target::attach): Update.
2351         * corelow.c (class core_target) <pid_to_str>: Change return type.
2352         (core_target::pid_to_str): Change return type.
2353         * target.c (normal_pid_to_str): Change return type.
2354         (default_pid_to_str): Likewise.
2355         (target_pid_to_str): Change return type.
2356         (target_translate_tls_address): Update.
2357         (target_announce_detach): Update.
2358         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2359         return type.
2360         (bsd_uthread_target::pid_to_str): Change return type.
2361         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2362         type.
2363         (bsd_kvm_target::pid_to_str): Change return type.
2364         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2365         return type.
2366         (aix_thread_target::pid_to_str): Change return type.
2367         * target.h (struct target_ops) <pid_to_str>: Change return type.
2368         (target_pid_to_str, normal_pid_to_str): Likewise.
2369         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2370         type.
2371         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2372         type.
2373         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2374         return type.
2375         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2376         type.
2377         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2378         type.
2379         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2380         return type.
2381
2382 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2383
2384         * NEWS: Mention that the new default MI version is 3.  Mention
2385         changes to the output of commands and events that deal with
2386         multi-location breakpoints.
2387         * breakpoint.c: Include "mi/mi-out.h".
2388         (print_one_breakpoint): Change output syntax if using MI version
2389         >= 3.
2390         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2391         New.
2392         (mi_multi_location_breakpoint_output_fixed): New.
2393         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2394         (mi_cmd_fix_multi_location_breakpoint_output): New.
2395         (mi_multi_location_breakpoint_output_fixed): New.
2396         * mi/mi-cmds.c (mi_cmds): Register command
2397         -fix-multi-location-breakpoint-output.
2398         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2399         interpreter "mi".
2400
2401 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2402
2403         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2404         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2405         instantiate mi_ui_out based on interpreter name.
2406         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2407         * mi/mi-main.c (mi_load_progress): Likewise.
2408
2409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2410
2411         * NEWS: Combine separate "New targets" sections for 8.3.
2412
2413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2414
2415         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2416         (ppcfbsd_init_abi): Install gdbarch
2417         "fetch_tls_load_module_address" and "get_thread_local_address"
2418         methods.
2419
2420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2421
2422         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2423         (riscv_fbsd_init_abi): Install gdbarch
2424         "fetch_tls_load_module_address" and "get_thread_local_address"
2425         methods.
2426
2427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2428
2429         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2430         (i386fbsd_init_abi): Install gdbarch
2431         "fetch_tls_load_module_address" and "get_thread_local_address"
2432         methods.
2433
2434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2435
2436         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2437         (amd64fbsd_init_abi): Install gdbarch
2438         "fetch_tls_load_module_address" and "get_thread_local_address"
2439         methods.
2440
2441 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2442
2443         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2444         (struct fbsd_pspace_data): New type.
2445         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2446         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2447         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2448         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2449         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2450
2451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2452
2453         * gdbtypes.c (lookup_struct_elt): New function.
2454         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2455         * gdbtypes.h (struct struct_elt): New type.
2456         (lookup_struct_elt): New prototype.
2457
2458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2459
2460         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2461         remove disabled code block.
2462
2463 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2464
2465         * gdbarch.sh (get_thread_local_address): New method.
2466         * gdbarch.h, gdbarch.c: Regenerate.
2467         * target.c (target_translate_tls_address): Use
2468         gdbarch_get_thread_local_address if present instead of
2469         target::get_thread_local_address.
2470
2471 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2472
2473         * target.h (target::get_thread_local_address): Update comment.
2474
2475 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2476
2477         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2478         objfile->separate_debug_objfile_backlink if not NULL.
2479
2480 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2481
2482         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2483         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2484         (amd64bsd_store_inferior_registers): Likewise.
2485         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2486         Enable segment base registers.
2487         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2488         PT_GETFSBASE and PT_GETGSBASE.
2489         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2490         PT_SETGSBASE.
2491         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2492         segment base registers.
2493         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2494
2495 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2496
2497         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2498         Update calls to i386_target_description to add 'segments'
2499         parameter.
2500         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2501         add segment base registers.
2502         * arch/i386.c (i386_create_target_description): Add 'segments'
2503         parameter to enable segment base registers.
2504         * arch/i386.h (i386_create_target_description): Likewise.
2505         * features/i386/32bit-segments.xml: New file.
2506         * features/i386/32bit-segments.c: Generate.
2507         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2508         call to i386_target_description to add 'segments' parameter.
2509         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2510         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2511         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2512         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2513         if feature is present.
2514         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2515         Add 'segments' parameter to call to i386_target_description.
2516         (i386_target_description): Add 'segments' parameter to enable
2517         segment base registers.
2518         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2519         to call to i386_target_description.
2520         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2521         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2522         Define I386_NUM_REGS.
2523         (i386_target_description): Add 'segments' parameter to enable
2524         segment base registers.
2525
2526 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2527
2528         PR/24325
2529         * source-cache.c: #undef open and close, to avoid unresolved
2530         externals during linking.
2531
2532 2019-03-12  Tom Tromey  <tromey@adacore.com>
2533
2534         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2535         const.  Add initializers.
2536         (_initialize_remote): Don't initialize ptid globals.
2537
2538 2019-03-12  Pedro Alves  <palves@redhat.com>
2539
2540         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2541
2542 2019-03-12  Pedro Alves  <palves@redhat.com>
2543
2544         * cp-name-parser.y (main): Remove unused 'len' variable.
2545
2546 2019-03-12  Tom Tromey  <tromey@adacore.com>
2547
2548         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2549         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2550
2551 2019-03-12  Tom Tromey  <tromey@adacore.com>
2552
2553         * linux-nat.c (iterate_over_lwps): Update.
2554         (stop_callback): Remove parameter.
2555         (stop_wait_callback, detach_callback, resume_set_callback)
2556         (select_singlestep_lwp_callback, set_ignore_sigint)
2557         (status_callback, resumed_callback, resume_clear_callback)
2558         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2559         data parameter.
2560         (linux_nat_target::detach, linux_nat_target::resume)
2561         (linux_stop_and_wait_all_lwps, select_event_lwp)
2562         (linux_nat_filter_event, linux_nat_wait_1)
2563         (linux_nat_target::kill, linux_nat_target::stop)
2564         (linux_nat_target::stop): Update.
2565         (linux_nat_resume_callback): Change type.
2566         (resume_stopped_resumed_lwps, count_events_callback)
2567         (select_event_lwp_callback): Likewise.
2568         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2569         * arm-linux-nat.c (struct update_registers_data): Remove.
2570         (update_registers_callback): Change type.
2571         (arm_linux_insert_hw_breakpoint1): Update.
2572         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2573         parameter.
2574         (x86_linux_dr_set_addr): Update.
2575         (x86_linux_dr_set_control): Update.
2576         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2577         (iterate_over_lwps): Use gdb::function_view.
2578         * nat/aarch64-linux-hw-point.c (struct
2579         aarch64_dr_update_callback_param): Remove.
2580         (debug_reg_change_callback): Change type.
2581         (aarch64_notify_debug_reg_change): Update.
2582         * s390-linux-nat.c (s390_refresh_per_info): Update.
2583
2584 2019-03-11  Tom Tromey  <tromey@adacore.com>
2585
2586         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2587         redundant assignment to "this_cu".
2588
2589 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2590
2591         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2592
2593 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2594
2595         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2596         from...
2597         (rank_one_type): ... this.
2598
2599 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2600
2601         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2602         from...
2603         (rank_one_type): ... this.
2604
2605 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2606
2607         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2608         from...
2609         (rank_one_type): ... this.
2610
2611 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2612
2613         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2614         from...
2615         (rank_one_type): ... this.
2616
2617 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2618
2619         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2620         from...
2621         (rank_one_type): ... this.
2622
2623 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2624
2625         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2626         from...
2627         (rank_one_type): ... this.
2628
2629 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2630
2631         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2632         from...
2633         (rank_one_type): ... this.
2634
2635 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2636
2637         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2638         from...
2639         (rank_one_type): ... this.
2640
2641 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2642
2643         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2644         from...
2645         (rank_one_type): ... this.
2646
2647 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2648
2649         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2650         from...
2651         (rank_one_type): ... this.
2652
2653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2654
2655         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2656         from...
2657         (rank_one_type): ... this.
2658
2659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2660
2661         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2662         from...
2663         (rank_one_type): ... this.
2664
2665 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2666
2667         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2668         inferior-events' shows the example events.
2669
2670 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2671
2672         Support styling on native MS-Windows console
2673
2674         PR/24315
2675         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2676         on MS-Windows if $TERM is not defined.
2677
2678         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2679
2680         * posix-hdep.c (gdb_console_fputs):
2681         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2682         functions.
2683         * ui-file.h (gdb_console_fputs): Add prototype.
2684
2685         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2686         back to fputs only if the former returns zero.
2687
2688 2019-03-07  Tom Tromey  <tom@tromey.com>
2689
2690         * symmisc.c (print_symbol_bcache_statistics): Update.
2691         (print_objfile_statistics): Update.
2692         * symfile.c (allocate_symtab): Update.
2693         * stabsread.c: Don't include bcache.h.
2694         * psymtab.h (struct psymbol_bcache): Don't declare.
2695         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2696         (psymbol_bcache_init, psymbol_bcache_free)
2697         (psymbol_bcache_get_bcache): Don't declare.
2698         * psymtab.c (struct psymbol_bcache): Remove.
2699         (psymtab_storage::psymtab_storage): Update.
2700         (psymtab_storage::~psymtab_storage): Update.
2701         (psymbol_bcache_init, psymbol_bcache_free)
2702         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2703         (add_psymbol_to_bcache): Update.
2704         (allocate_psymtab): Update.
2705         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2706         macro_cache>: No longer pointers.
2707         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2708         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2709         * macrotab.c (macro_bcache): Update.
2710         * macroexp.c: Don't include bcache.h.
2711         * gdbtypes.c (check_types_worklist): Update.
2712         (types_deeply_equal): Remove TRY/CATCH.  Update.
2713         * elfread.c (elf_symtab_read): Update.
2714         * dwarf2read.c: Don't include bcache.h.
2715         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2716         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2717         (print_bcache_statistics, bcache_memory_used): Don't declare.
2718         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2719         methods.  Rename all data members.
2720         * bcache.c (struct bcache): Move to bcache.h.
2721         (bcache::expand_hash_table): Rename from expand_hash_table.
2722         (bcache): Remove.
2723         (bcache::insert): Rename from bcache_full.
2724         (bcache::compare): Rename from bcache_compare.
2725         (bcache_xmalloc): Remove.
2726         (bcache::~bcache): Rename from bcache_xfree.
2727         (bcache::print_statistics): Rename from print_bcache_statistics.
2728         (bcache::memory_used): Rename from bcache_memory_used.
2729
2730 2019-03-07  Pedro Alves  <palves@redhat.com>
2731
2732         * infrun.c (normal_stop): Also check for
2733         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2734
2735 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2736
2737         * f-lang.c (value_from_host_double): Moved to...
2738         * value.c (value_from_host_double): ...here.
2739         * value.h (value_from_host_double): Declare.
2740         * guile/scm-math.c (vlscm_convert_typed_number): Use
2741         value_from_host_double.
2742         (vlscm_convert_number): Likewise.
2743         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2744         * python/py-value.c (convert_value_from_python): Likewise.
2745
2746 2019-03-06  Tom Tromey  <tom@tromey.com>
2747
2748         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2749
2750 2019-03-06  Tom Tromey  <tom@tromey.com>
2751
2752         * utils.h (free_current_contents): Don't declare.
2753         * utils.c (free_current_contents): Remove.
2754
2755 2019-03-06  Tom Tromey  <tom@tromey.com>
2756
2757         * top.c (quit_force): Update.
2758         * main.c (captured_command_loop): Update.
2759         * common/new-op.c (operator new): Update.
2760         * common/common-exceptions.c (struct catcher)
2761         <save_cleanup_chain>: Remove member.
2762         (exceptions_state_mc_init): Update.
2763         (exception_try_scope_entry): Return nullptr.
2764         (exception_try_scope_exit, exception_rethrow)
2765         (throw_exception_sjlj, throw_exception_cxx): Update.
2766         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2767         (all_cleanups, do_cleanups, discard_cleanups)
2768         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2769         (restore_cleanups, restore_final_cleanups): Don't declare.
2770         (do_final_cleanups): Remove parameter.
2771         * common/cleanups.c (cleanup_chain, make_cleanup)
2772         (make_cleanup_dtor, all_cleanups, do_cleanups)
2773         (discard_my_cleanups, discard_cleanups)
2774         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2775         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2776         (null_cleanup): Remove.
2777         (do_final_cleanups): Remove parameter.
2778
2779 2019-03-06  Tom Tromey  <tom@tromey.com>
2780
2781         * remote.c (remote_target::remote_parse_stop_reply): Use
2782         unique_xmalloc_ptr.
2783
2784 2019-03-06  Tom Tromey  <tom@tromey.com>
2785
2786         * stabsread.c (struct stabs_field_info): Rename from field_info.
2787         <list, fnlist>: Add initializers.
2788         <obstack>: New member.
2789         (read_member_functions, read_struct_fields, read_baseclasses):
2790         Allocate on obstack.  Don't use cleanups.
2791         (read_one_struct_field, read_member_functions, read_struct_fields)
2792         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2793         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2794         (read_struct_type): Update.
2795
2796 2019-03-06  Tom Tromey  <tom@tromey.com>
2797
2798         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2799         * common/filestuff.h (make_cleanup_close): Don't declare.
2800         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2801         Remove.
2802
2803 2019-03-06  Tom Tromey  <tom@tromey.com>
2804
2805         * solib-aix.c: Use make_scope_exit.
2806
2807 2019-03-06  Tom Tromey  <tom@tromey.com>
2808
2809         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2810         Use make_scope_exit.
2811
2812 2019-03-06  Tom Tromey  <tom@tromey.com>
2813
2814         * solib-svr4.c (disable_probes_interface): Remove parameter.
2815         (svr4_handle_solib_event): Use make_scope_exit.
2816
2817 2019-03-06  Tom Tromey  <tom@tromey.com>
2818
2819         * remote.c (struct stop_reply_deleter): Remove.
2820         (stop_reply_up): Update.
2821         (struct stop_reply): Derive from notif_event.  Don't typedef.
2822         <regcache>: Now a std::vector.
2823         (stop_reply_xfree): Remove.
2824         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2825         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2826         (remote_target::discard_pending_stop_replies): Use delete.
2827         (remote_target::remote_parse_stop_reply): Update.
2828         (remote_target::process_stop_reply): Update.
2829         * remote-notif.h (struct notif_event): Add virtual destructor.
2830         Remove "dtr" member.
2831         (struct notif_client) <alloc_event>: Return a unique_ptr.
2832         (notif_event_xfree): Don't declare.
2833         (notif_event_up): New typedef.
2834         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2835         (notif_event_xfree, do_notif_event_xfree): Remove.
2836         (remote_notif_state_xfree): Update.
2837
2838 2019-03-06  Tom Tromey  <tom@tromey.com>
2839
2840         * infrun.c (displaced_step_clear_cleanup): Now a
2841         forward_scope_exit type.
2842         (displaced_step_prepare_throw): Update.
2843         (displaced_step_fixup): Update.
2844
2845 2019-03-06  Tom Tromey  <tom@tromey.com>
2846
2847         * inferior.h (class inferior): Update comment.
2848         * gdbthread.h (class thread_info): Update comment.
2849
2850 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2851             Tom Tromey  <tom@tromey.com>
2852
2853         * stabsread.h (struct stab_section_list): Remove.
2854         (coffstab_build_psymtabs): Update.
2855         * dbxread.c (symbuf_sections): Now a std::vector.
2856         (sect_idx): New global.
2857         (fill_symbuf): Update.
2858         (coffstab_build_psymtabs): Change type of stabsects parameter.
2859         Update.
2860         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2861         std::vector.
2862         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2863         (coff_locate_sections): Update.
2864         (coff_symfile_read): Remove cleanups.  Update.
2865         (init_stringtab): Add storage parameter.
2866         (free_stringtab, free_stringtab_cleanup): Remove.
2867         (init_lineno): Add storage parameter.
2868         (free_linetab, free_linetab_cleanup): Remove.
2869
2870 2019-03-06  Pedro Alves  <palves@redhat.com>
2871
2872         * linux-fork.c (fork_info::clobber_regs): Delete.
2873         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2874         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2875         comment.  Adjust.
2876         (scoped_switch_fork_info::scoped_switch_fork_info)
2877         (checkpoint_command, linux_fork_context): Adjust
2878         fork_save_infrun_state calls.
2879
2880 2019-03-06  Pedro Alves  <palves@redhat.com>
2881
2882         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2883         (inf_has_multiple_threads): Return 'bool' and rewrite using
2884         inferior_info::threads().
2885
2886 2019-03-06  Pedro Alves  <palves@redhat.com>
2887
2888         * linux-fork.c: Include <list>.
2889         (fork_list): Now a std::list instance.
2890         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2891         (forks_exist_p, find_last_fork): Adjust.
2892         (new_fork): Delete.
2893         (one_fork_p): New.
2894         (add_fork): Adjust.
2895         (free_fork): Delete, folded into fork_info::~fork_info().
2896         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2897         Adjust.
2898         (init_fork_list): Delete.
2899         (linux_fork_killall, linux_fork_mourn_inferior)
2900         (linux_fork_detach, info_checkpoints_command): Adjust.
2901         (_initialize_linux_fork): No longer call init_fork_list.
2902
2903 2019-03-06  Pedro Alves  <palves@redhat.com>
2904
2905         * linux-fork.c (new_fork): New, split out of ...
2906         (add_fork): ... this.  Return void.  Move "first fork" special
2907         case from here, to ...
2908         (checkpoint_command): ... here.
2909         * linux-linux.h (add_fork): Return void.
2910
2911 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2912
2913         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2914
2915 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2916             Chris January  <chris.january@arm.com>
2917             David Lecomber  <david.lecomber@arm.com>
2918
2919         * f-exp.y: New token, UNOP_INTRINSIC.
2920         (exp): New pattern using UNOP_INTRINSIC token.
2921         (f77_keywords): Add 'abs' keyword.
2922         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2923         (value_from_host_double): New function.
2924         (evaluate_subexp_f): Support UNOP_ABS.
2925
2926 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2927
2928         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2929         types.
2930
2931 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2932
2933         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2934         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2935         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2936
2937 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2938
2939         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2940
2941 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2942             Chris January  <chris.january@arm.com>
2943
2944         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2945         * f-exp.y: Define 'KIND' token.
2946         (exp): New pattern for KIND expressions.
2947         (ptype): Handle types with a kind extension.
2948         (direct_abs_decl): Extend to spot kind extensions.
2949         (f77_keywords): Add 'kind' to the list.
2950         (push_kind_type): New function.
2951         (convert_to_kind_type): New function.
2952         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2953         * parse.c (operator_length_standard): Likewise.
2954         * parser-defs.h (enum type_pieces): Add tp_kind.
2955         * std-operator.def: Add UNOP_KIND.
2956
2957 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2958
2959         * f-exp.y (f_parse): Set yydebug.
2960
2961 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2962
2963         * f-lang.c (evaluate_subexp_f): New function.
2964         (exp_descriptor_f): New global.
2965         (f_language_defn): Use exp_descriptor_f instead of
2966         exp_descriptor_standard.
2967
2968 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2969
2970         * f-exp.y (struct token): Add comments.
2971         (dot_ops): Remove uppercase versions and the end marker.
2972         (f77_keywords): Likewise.
2973         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2974         entries in the dot_ops array are case insensitive, and use
2975         strncasecmp to compare strings.  Also some whitespace cleanup in
2976         this area.  Similar for the f77_keywords array, except entries in
2977         this list might be case sensitive.
2978
2979 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2980
2981         * f-exp.y (struct f77_boolean_val): Add comments.
2982         (boolean_values): Remove uppercase versions, and end marker.
2983         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2984         and use strncasecmp to achieve case insensitivity.  Additionally,
2985         perform whitespace cleanup around this code.
2986
2987 2019-03-06  Tom Tromey  <tromey@adacore.com>
2988
2989         * remote-sim.c (gdbsim_target_open): Use result of
2990         gdb_argv::release.
2991
2992 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2993         Dirk Schubert  <dirk.schubert@arm.com>
2994         Chris January  <chris.january@arm.com>
2995
2996         * eval.c (evaluate_subexp_standard): Call Fortran argument
2997         wrapping logic.
2998         * f-lang.c (struct value): A value which can be passed into a
2999         Fortran function call.
3000         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3001         where appropriate.
3002         (struct type): Value ready for a Fortran function call.
3003         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3004         is needed.
3005         * f-lang.h (fortran_argument_convert): Declaration.
3006         (fortran_preserve_arg_pointer): Declaration.
3007         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3008
3009 2019-03-05  Tom Tromey  <tromey@adacore.com>
3010
3011         * python/py-prettyprint.c (print_string_repr): Remove #if.
3012         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3013
3014 2019-03-05  Tom Tromey  <tromey@adacore.com>
3015
3016         * target.c (the_dummy_target): Move later.  Change type to
3017         "dummy_target".
3018         (initialize_targets): Don't initialize the_dummy_target.
3019
3020 2019-03-05  Tom Tromey  <tromey@adacore.com>
3021
3022         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3023         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3024
3025 2019-03-05  Tom Tromey  <tromey@adacore.com>
3026
3027         * windows-nat.c (windows_nat_target::attach)
3028         (windows_nat_target::detach): Don't call gdb_flush.
3029         * valprint.c (generic_val_print, val_print, val_print_string):
3030         Don't call gdb_flush.
3031         * utils.c (defaulted_query): Don't call gdb_flush.
3032         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3033         * target.c (target_announce_detach): Don't call gdb_flush.
3034         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3035         * remote.c (extended_remote_target::attach): Don't call
3036         gdb_flush.
3037         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3038         * printcmd.c (do_examine): Don't call gdb_flush.
3039         (info_display_command): Don't call gdb_flush.
3040         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3041         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3042         * memattr.c (info_mem_command): Don't call gdb_flush.
3043         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3044         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3045         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3046         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3047         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3048         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3049         (gnu_nat_target::detach): Don't call gdb_flush.
3050         * f-valprint.c (f_val_print): Don't call gdb_flush.
3051         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3052         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3053         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3054         gdb_flush.
3055         * c-valprint.c (c_val_print): Don't call gdb_flush.
3056         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3057
3058 2019-03-05  Tom Tromey  <tromey@adacore.com>
3059
3060         * varobj.c (update_dynamic_varobj_children): Update.
3061         (install_default_visualizer): Use reset, not release.
3062         * value.c (set_internalvar): Update.
3063         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3064         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3065         ATTRIBUTE_UNUSED_RESULT.
3066
3067 2019-03-05  Tom Tromey  <tromey@adacore.com>
3068
3069         * remote.c (class scoped_remote_fd) <release>: Add
3070         ATTRIBUTE_UNUSED_RESULT.
3071
3072 2019-03-05  Tom Tromey  <tromey@adacore.com>
3073
3074         * macroexp.c (struct macro_buffer) <release>: Add
3075         ATTRIBUTE_UNUSED_RESULT.
3076
3077 2019-03-05  Tom Tromey  <tromey@adacore.com>
3078
3079         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3080         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3081         ATTRIBUTE_UNUSED_RESULT.
3082
3083 2019-03-05  Tom Tromey  <tromey@adacore.com>
3084
3085         * common/scoped_fd.h (class scoped_fd) <release>: Add
3086         ATTRIBUTE_UNUSED_RESULT.
3087
3088 2019-03-05  Tom Tromey  <tromey@adacore.com>
3089
3090         * parser-defs.h (struct parser_state) <release>: Add
3091         ATTRIBUTE_UNUSED_RESULT.
3092
3093 2019-03-05  Tom Tromey  <tromey@adacore.com>
3094
3095         * utils.h (class gdb_argv) <release>: Add
3096         ATTRIBUTE_UNUSED_RESULT.
3097         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3098
3099 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3100
3101         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3102         for-loop range, to avoid compiler warnings.
3103
3104         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3105         avoid compiler warnings about unused variables.
3106
3107         * NEWS: Mention end of support for native debugging on MS-Windows
3108         before XP.
3109
3110         PR gdb/24292
3111         * common/netstuff.c:
3112         * gdbserver/gdbreplay.c
3113         * gdbserver/remote-utils.c:
3114         * ser-tcp.c:
3115         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3116         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3117         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3118         'getaddrinfo' and 'freeaddrinfo' were not available before
3119         Windows XP, and mingw.org's MinGW headers by default define
3120         _WIN32_WINNT to 0x500.
3121
3122 2019-03-01  Gary Benson <gbenson@redhat.com>
3123
3124         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3125
3126 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3127             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3128
3129         PR gdb/8527
3130         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3131         set_sigint_trap, clear_sigint_trap.
3132
3133 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3134
3135         * target.c (target_detach): Clear the regcache and the
3136         frame cache.
3137
3138 2019-02-27  Pedro Alves  <palves@redhat.com>
3139
3140         * utils.c (set_screen_size): When we cap the height/width sizes,
3141         tweak the corresponding command variable to show "unlimited":
3142
3143 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3144             Pedro Alves  <palves@redhat.com>
3145
3146         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3147         before calling rl_set_screen_size.
3148
3149 2019-02-27  Tom Tromey  <tromey@adacore.com>
3150
3151         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3152         define.
3153         * python/py-value.c: Remove Python 2.4 workaround.
3154         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3155         workaround.
3156         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3157         Python 2.4 workaround.
3158         * python/python-internal.h: Remove Python 2.4 comment.
3159         (Py_ssize_t): Don't define.
3160         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3161         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3162         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3163         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3164         * python/python.c (do_start_initialization): Remove Python 2.4
3165         workaround.
3166         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3167         (print_children): Remove Python 2.4 workaround.
3168         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3169         workaround.
3170         (CHARBUFFERPROC_NAME): Remove.
3171         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3172         Python 2.4 workaround.
3173
3174 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3175
3176         * NEWS: Note minimum Python version.
3177
3178 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3179
3180         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3181         code from these functions.  Remove corresponding ifdefs.  Use
3182         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3183         Remove gotos and target of gotos.
3184         (infpy_search_memory): Likewise.
3185
3186 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3187
3188         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3189         (hppa_gdbarch_init): Don't register deleted functions with
3190         gdbarch.
3191
3192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3193
3194         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3195         (h8300_unwind_sp): Delete.
3196         (h8300_dummy_id): Delete.
3197         (h8300_gdbarch_init): Don't register deleted functions with
3198         gdbarch.
3199
3200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3201
3202         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3203         (ft32_unwind_pc): Delete.
3204         (ft32_unwind_sp): Delete.
3205         (ft32_gdbarch_init): Don't register deleted functions with
3206         gdbarch.
3207
3208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3209
3210         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3211         (frv_unwind_pc): Delete.
3212         (frv_unwind_sp): Delete.
3213         (frv_gdbarch_init): Don't register deleted functions with
3214         gdbarch.
3215
3216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3217
3218         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3219         (riscv_unwind_pc): Delete.
3220         (riscv_unwind_sp): Delete.
3221         (riscv_gdbarch_init): Don't register deleted functions with
3222         gdbarch.
3223
3224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3225
3226         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3227         (csky_unwind_pc): Delete.
3228         (csky_unwind_sp): Delete.
3229         (csky_gdbarch_init): Don't register deleted functions with
3230         gdbarch.
3231
3232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3233
3234         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3235         (cris_unwind_pc): Delete.
3236         (cris_unwind_sp): Delete.
3237         (cris_gdbarch_init): Don't register deleted functions with
3238         gdbarch.
3239
3240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3241
3242         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3243         (bfin_unwind_pc): Delete.
3244         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3245
3246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3247
3248         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3249         (arm_unwind_pc): Delete.
3250         (arm_unwind_sp): Delete.
3251         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3252
3253 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3254
3255         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3256         (arc_unwind_pc): Delete.
3257         (arc_unwind_sp): Delete.
3258         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3259
3260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3261
3262         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3263         (alpha_unwind_pc): Delete.
3264         (alpha_gdbarch_init): Don't register deleted functions with
3265         gdbarch.
3266
3267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3268
3269         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3270         (aarch64_unwind_pc): Delete.
3271         (aarch64_unwind_sp): Delete.
3272         (aarch64_gdbarch_init): Don't register deleted functions with
3273         gdbarch.
3274
3275 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3276
3277         * gdbtypes.c (type_align): Don't consider static members when
3278         computing structure alignment.
3279
3280 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3281
3282         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3283         return 0 for other types.
3284         * arch-utils.c (default_type_align): Always return 0.
3285         * gdbarch.h: Regenerate.
3286         * gdbarch.sh (type_align): Extend comment.
3287         * gdbtypes.c (type_align): Add additional comments, always call
3288         gdbarch_type_align before applying the default rules.
3289         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3290         generic code will then apply a suitable default.
3291         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3292         types, return 0 for other types.
3293
3294 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3295
3296         * NEWS: Create a new section for the next release branch.
3297         Rename the section of the current branch, now that it has
3298         been cut.
3299
3300 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3301
3302         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3303         * version.in: Bump version to 8.3.50.DATE-git.
3304
3305 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3306
3307         * aix-thread.c (ptid_cmp): Remove unused variable.
3308         (get_signaled_thread): Likewise.
3309         (store_regs_user_thread): Likewise.
3310         (store_regs_kernel_thread): Likewise.
3311         (fetch_regs_kernel_thread): Remove shadowed variable.
3312
3313 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3314
3315         * features/riscv/32bit-cpu.xml: Add register numbers.
3316         * features/riscv/32bit-fpu.c: Regenerate.
3317         * features/riscv/32bit-fpu.xml: Add register numbers.
3318         * features/riscv/64bit-cpu.xml: Add register numbers.
3319         * features/riscv/64bit-fpu.c: Regenerate.
3320         * features/riscv/64bit-fpu.xml: Add register numbers.
3321
3322 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3323
3324         * NEWS: Mention two argument form of gdb.Value constructor.
3325         * python/py-value.c (convert_buffer_and_type_to_value): New
3326         function.
3327         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3328         Add support for handling an optional second argument.  Call
3329         convert_buffer_and_type_to_value as appropriate.
3330         * python/python-internal.h (Py_buffer_deleter): New struct.
3331         (Py_buffer_up): New typedef.
3332
3333 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3334
3335         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3336         instead of releasing ownership.
3337
3338 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3339
3340         * dwarf2read.c (open_and_init_dwp_file): Call
3341         elf_numsections instead of bfd_count_sections to initialize
3342         dwp_file->num_sections.
3343
3344 2019-02-25  Tom Tromey  <tromey@adacore.com>
3345
3346         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3347
3348 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3349
3350         * gcore.in: Add '--readnever' option when invoking GDB.
3351
3352 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3353
3354         * MAINTAINERS: Update my email address.
3355
3356 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3357
3358         * build-id.c (build_id_to_debug_bfd_1): New function.
3359         (build_id_to_debug_bfd): Look for separate debug file in
3360         sysroot.
3361
3362 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3363
3364         * gdbarch.sh: Update the copyright year range that is placed into
3365         generated files.
3366
3367 2019-02-22  Keith Seitz  <keiths@redhat.com>
3368
3369         PR symtab/23853
3370         * linespec.c (create_sals_line_offset): Search for the default
3371         symtab's filename instead of its fullname.
3372
3373 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3374
3375         * NEWS: Update style defaults.
3376
3377 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3378
3379         * main.c (captured_main_1): Disable styling in batch mode.
3380
3381 2019-02-20  Tom Tromey  <tom@tromey.com>
3382
3383         * symtab.c (symtab_symbol_info): Fix typos.
3384
3385 2019-02-20  Tom Tromey  <tromey@adacore.com>
3386
3387         * findcmd.c (_initialize_mem_search): Use upper case for
3388         metasyntactic variables.
3389
3390 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3391
3392         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3393         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3394
3395 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3396
3397         * top.h (source_file_name): Change to std::string.
3398         * top.c (source_file_name): Likewise.
3399         (command_line_input): Adjust.
3400         * cli/cli-script.c (script_from_file): Adjust.
3401
3402 2019-02-19  Tom Tromey  <tromey@adacore.com>
3403
3404         * ravenscar-thread.c
3405         (ravenscar_thread_target::update_thread_list): Don't call
3406         ada_build_task_list.
3407         * ada-lang.h (ada_build_task_list): Don't declare.
3408         * ada-tasks.c (struct ada_tasks_inferior_data)
3409         <task_list_valid_p>: Now bool.
3410         (read_known_tasks, ada_task_list_changed)
3411         (ada_tasks_invalidate_inferior_data): Update.
3412         (read_known_tasks_array): Return bool.
3413         (read_known_tasks_list): Likewise.
3414         (read_known_tasks): Return void.
3415         (ada_build_task_list): Now static.
3416
3417 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3418
3419         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3420         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3421
3422 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3423
3424         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3425         variant for ada_tasks_pspace_data_handle and
3426         ada_tasks_inferior_data_handle.
3427         (ada_tasks_pspace_data_cleanup): New function.
3428         (ada_tasks_inferior_data_cleanup): New function.
3429
3430 2019-02-17  Tom Tromey  <tom@tromey.com>
3431
3432         * macrotab.h (macro_source_fullname): Return a std::string.
3433         * macrotab.c (macro_include, check_for_redefinition)
3434         (macro_undef, macro_lookup_definition, foreach_macro)
3435         (foreach_macro_in_scope): Update.
3436         (macro_source_fullname): Return a std::string.
3437         * macrocmd.c (show_pp_source_pos): Update.
3438
3439 2019-02-17  Tom Tromey  <tom@tromey.com>
3440
3441         * macrocmd.c (show_pp_source_pos): Style the file names.
3442
3443 2019-02-17  Tom Tromey  <tom@tromey.com>
3444
3445         PR tui/24197:
3446         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3447
3448 2019-02-17  Tom Tromey  <tom@tromey.com>
3449
3450         * ada-lang.c (user_select_syms): Use filtered printing.
3451         * utils.c (wrap_style): New global.
3452         (desired_style): Remove.
3453         (emit_style_escape): Add stream parameter.
3454         (set_output_style, reset_terminal_style, prompt_for_continue):
3455         Update.
3456         (flush_wrap_buffer): Only flush gdb_stdout.
3457         (wrap_here): Set wrap_style.
3458         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3459         treat escape sequences as a character.  Change when wrap buffer is
3460         flushed.
3461         (fputs_styled): Do not set the output style when the default is
3462         requested.
3463         * ui-style.h (struct ui_file_style) <is_default>: New method.
3464         * source.c (print_source_lines_base): Emit escape sequences in one
3465         piece.
3466
3467 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3468
3469         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3470         integers and enumeration types.
3471
3472 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3473
3474         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3475         instead of lookup_symbol_in_language
3476         (do_exact_match): New function.
3477         (ada_get_symbol_name_matcher): Return do_exact_match when
3478         doing a verbatim match.
3479
3480 2019-02-15  Tom Tromey  <tromey@adacore.com>
3481
3482         * ravenscar-thread.c (ravenscar_thread_target::resume)
3483         (ravenscar_thread_target::wait): Special case wildcard requests.
3484
3485 2019-02-15  Tom Tromey  <tromey@adacore.com>
3486
3487         * ravenscar-thread.c (base_ptid): Remove.
3488         (struct ravenscar_thread_target) <close>: New method.
3489         <m_base_ptid>: New member.
3490         <update_inferior_ptid, active_task, task_is_currently_active,
3491         runtime_initialized>: Declare methods.
3492         <ravenscar_thread_target>: Add constructor.
3493         (ravenscar_thread_target::task_is_currently_active)
3494         (ravenscar_thread_target::update_inferior_ptid)
3495         (ravenscar_runtime_initialized): Rename.  Now methods.
3496         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3497         (ravenscar_thread_target::update_thread_list): Update.
3498         (ravenscar_thread_target::active_task): Now method.
3499         (ravenscar_thread_target::store_registers)
3500         (ravenscar_thread_target::prepare_to_store)
3501         (ravenscar_thread_target::prepare_to_store)
3502         (ravenscar_thread_target::mourn_inferior): Update.
3503         (ravenscar_inferior_created): Use "new" to create target.
3504         (ravenscar_thread_target::get_ada_task_ptid): Update.
3505         (_initialize_ravenscar): Don't initialize base_ptid.
3506         (ravenscar_ops): Remove global.
3507
3508 2019-02-15  Tom Tromey  <tromey@adacore.com>
3509
3510         * target.h (push_target): Declare new overload.
3511         * target.c (push_target): New overload, taking an rvalue reference.
3512         * remote.c (remote_target::open_1): Use push_target overload.
3513         * corelow.c (core_target_open): Use push_target overload.
3514
3515 2019-02-15  Tom Tromey  <tromey@adacore.com>
3516
3517         * ravenscar-thread.c (is_ravenscar_task)
3518         (ravenscar_task_is_currently_active): Return bool.
3519         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3520         (_initialize_ravenscar): Remove "(void)".
3521         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3522         Return bool.
3523
3524 2019-02-15  Tom Tromey  <tromey@adacore.com>
3525
3526         * ravenscar-thread.c (ravenscar_runtime_initializer)
3527         (has_ravenscar_runtime, get_running_thread_id)
3528         (ravenscar_thread_target::resume): Fix indentation.
3529
3530 2019-02-15  Tom Tromey  <tromey@adacore.com>
3531
3532         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3533         from ravenscar_arch_ops.
3534         (sparc_ravenscar_ops::fetch_registers)
3535         (sparc_ravenscar_ops::store_registers): Now methods.
3536         (sparc_ravenscar_prepare_to_store): Remove.
3537         (sparc_ravenscar_ops): Redefine.
3538         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3539         methods and destructor.  Remove members.
3540         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3541         (ravenscar_thread_target::store_registers)
3542         (ravenscar_thread_target::prepare_to_store): Update.
3543         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3544         Remove.
3545         (struct ppc_ravenscar_powerpc_ops): Derive from
3546         ravenscar_arch_ops.
3547         (ppc_ravenscar_powerpc_ops::fetch_registers)
3548         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3549         (ppc_ravenscar_powerpc_ops): Redefine.
3550         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3551         (ppc_ravenscar_e500_ops::fetch_registers)
3552         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3553         (ppc_ravenscar_e500_ops): Redefine.
3554         * aarch64-ravenscar-thread.c
3555         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3556         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3557         (aarch64_ravenscar_fetch_registers)
3558         (aarch64_ravenscar_store_registers): Now methods.
3559         (aarch64_ravenscar_ops): Redefine.
3560
3561 2019-02-15  Tom Tromey  <tromey@adacore.com>
3562
3563         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3564         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3565         (ravenscar_thread_target::stopped_by_watchpoint)
3566         (ravenscar_thread_target::stopped_data_address)
3567         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3568
3569 2019-02-15  Tom Tromey  <tromey@adacore.com>
3570
3571         * ravenscar-thread.c: Fix some typos.
3572
3573 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3574             Tom Tromey  <tromey@adacore.com>
3575
3576         * ada-lang.c (ada_exception_sal): Change addr_string to a
3577         std::string.
3578         (create_ada_exception_catchpoint): Update.
3579
3580 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3581             Tom Tromey  <tromey@adacore.com>
3582
3583         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3584         (bp_location_ops): Remove.
3585         (base_breakpoint_allocate_location): Update.
3586         (free_bp_location): Update.
3587         * ada-lang.c (class ada_catchpoint_location)
3588         <ada_catchpoint_location>: Remove ops parameter.
3589         (ada_catchpoint_location_dtor): Remove.
3590         (ada_catchpoint_location_ops): Remove.
3591         (allocate_location_exception): Update.
3592         * breakpoint.h (struct bp_location_ops): Remove.
3593         (class bp_location) <bp_location>: Remove bp_location_ops
3594         parameter.
3595         <~bp_location>: Add destructor.
3596         <ops>: Remove.
3597
3598 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3599             Pedro Alves  <palves@redhat.com>
3600
3601         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3602         'PATH_MAX'.
3603
3604 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3605             Samuel Thibault  <samuel.thibault@gnu.org>
3606             Thomas Schwinge  <thomas@codesourcery.com>
3607
3608         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3609         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3610
3611 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3612
3613         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3614         (check_empty): Use "const char *".
3615
3616         * gnu-nat.c (gnu_nat_target::detach): Instead of
3617         'detach_inferior (pid)' call
3618         'detach_inferior (find_inferior_pid (pid))'.
3619
3620         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3621         'nat/fork-inferior.o'.
3622         * gnu-nat.c: #include "nat/fork-inferior.h".
3623
3624         * gnu-nat.c (gnu_nat_target::detach): Instead of
3625         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3626         * gnu-nat.h: #include "inf-child.h".
3627         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3628         'i386_gnu_nat_target::fetch_registers'.
3629         (gnu_store_registers): Rename/move to
3630         'i386_gnu_nat_target::store_registers'.
3631
3632         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3633         * gnu-nat.h (mach_thread_info): New function.
3634         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3635
3636         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3637
3638 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3639
3640         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3641
3642 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3643
3644         * windows-nat.c (windows_add_thread): Add new parameter
3645         "main_thread_p" with default value set to false.  Update
3646         function documentation as well as all callers.
3647         (windows_delete_thread): Likewise.
3648         (fake_create_process): Update call to windows_add_thread.
3649         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3650         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3651         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3652         call to windows_delete_thread.
3653
3654 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3655
3656         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3657
3658 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3659
3660         * symfile.c (find_separate_debug_file): Use canonical path of
3661         sysroot with child_path instead of gdb_sysroot if it is valid.
3662
3663 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3664
3665         * symfile.c (find_separate_debug_file): Use child_path to
3666         determine if an object file is under a sysroot.
3667
3668 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3669
3670         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3671         unittests/child-path-selftests.c.
3672         * common/pathstuff.c (child_path): New function.
3673         * common/pathstuff.h (child_path): New prototype.
3674         * unittests/child-path-selftests.c: New file.
3675
3676 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3677
3678         * symfile.c (find_separate_debug_file): Look for separate debug
3679         files in debug directories under the sysroot.
3680
3681 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3682
3683         * symtab.h (struct minimal_symbol data_p): New const method.
3684         (struct minimal_symbol text_p): Likewise.
3685         * symtab.c (output_source_filename): Use file name style
3686         to print file name.
3687         (print_symbol_info): Likewise.
3688         (print_msymbol_info): Use address style to print addresses.
3689         Use function name style to print executable text symbols.
3690         (expand_symtab_containing_pc): Use data_p.
3691         (find_pc_sect_compunit_symtab): Likewise.
3692
3693 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3694
3695         * breakpoint.c (describe_other_breakpoints): Use address style
3696         to print addresses.
3697         (say_where): Likewise.
3698
3699 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3700
3701         * ada-typeprint.c (print_func_type): Print function name
3702         style to print function name.
3703         * c-typeprint.c (c_print_type_1): Likewise.
3704
3705 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3706
3707         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3708         for execve.
3709
3710 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3711
3712         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3713         type_stack.
3714
3715 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3716
3717         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3718         TYPE_CODE_REF types.
3719
3720 2019-02-08  Jim Wilson  <jimw@sifive.com>
3721
3722         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3723         (riscv_linux_fregset): New.
3724         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3725
3726 2019-02-07  Tom Tromey  <tom@tromey.com>
3727
3728         * thread.c (thread_cancel_execution_command): Update.
3729         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3730         methods.
3731         (struct thread_fsm_ops): Remove.
3732         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3733         (thread_fsm_should_stop, thread_fsm_return_value)
3734         (thread_fsm_set_finished, thread_fsm_finished_p)
3735         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3736         Don't declare.
3737         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3738         * infrun.c (clear_proceed_status_thread)
3739         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3740         (print_stop_event): Update.
3741         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3742         Add constructor.
3743         (step_command_fsm_ops): Remove.
3744         (new_step_command_fsm): Remove.
3745         (step_1): Update.
3746         (step_command_fsm::should_stop): Rename from
3747         step_command_fsm_should_stop.
3748         (step_command_fsm::clean_up): Rename from
3749         step_command_fsm_clean_up.
3750         (step_command_fsm::do_async_reply_reason): Rename from
3751         step_command_fsm_async_reply_reason.
3752         (struct until_next_fsm): Inherit from thread_fsm.  Add
3753         constructor.
3754         (until_next_fsm_ops): Remove.
3755         (new_until_next_fsm): Remove.
3756         (until_next_fsm::should_stop): Rename from
3757         until_next_fsm_should_stop.
3758         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3759         (until_next_fsm::do_async_reply_reason): Rename from
3760         until_next_fsm_async_reply_reason.
3761         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3762         constructor.  Change type of breakpoint.
3763         (finish_command_fsm_ops): Remove.
3764         (new_finish_command_fsm): Remove.
3765         (finish_command_fsm::should_stop): Rename from
3766         finish_command_fsm_should_stop.
3767         (finish_command_fsm::clean_up): Rename from
3768         finish_command_fsm_clean_up.
3769         (finish_command_fsm::return_value): Rename from
3770         finish_command_fsm_return_value.
3771         (finish_command_fsm::do_async_reply_reason): Rename from
3772         finish_command_fsm_async_reply_reason.
3773         (finish_command): Update.
3774         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3775         Add constructor.
3776         (call_thread_fsm_ops): Remove.
3777         (call_thread_fsm::call_thread_fsm): Rename from
3778         new_call_thread_fsm.
3779         (call_thread_fsm::should_stop): Rename from
3780         call_thread_fsm_should_stop.
3781         (call_thread_fsm::should_notify_stop): Rename from
3782         call_thread_fsm_should_notify_stop.
3783         (run_inferior_call, call_function_by_hand_dummy): Update.
3784         * cli/cli-interp.c (should_print_stop_to_console): Update.
3785         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3786         Add constructor.  Change type of location_breakpoint,
3787         caller_breakpoint.
3788         (until_break_fsm_ops): Remove.
3789         (new_until_break_fsm): Remove.
3790         (until_break_fsm::should_stop): Rename from
3791         until_break_fsm_should_stop.
3792         (until_break_fsm::clean_up): Rename from
3793         until_break_fsm_clean_up.
3794         (until_break_fsm::do_async_reply_reason): Rename from
3795         until_break_fsm_async_reply_reason.
3796         (until_break_command): Update.
3797         * thread-fsm.c: Remove.
3798         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3799
3800 2019-02-07  Tom Tromey  <tom@tromey.com>
3801
3802         * yy-remap.h: Add include guard.
3803         * xtensa-tdep.h: Add include guard.
3804         * xcoffread.h: Rename include guard.
3805         * varobj-iter.h: Add include guard.
3806         * tui/tui.h: Rename include guard.
3807         * tui/tui-winsource.h: Rename include guard.
3808         * tui/tui-wingeneral.h: Rename include guard.
3809         * tui/tui-windata.h: Rename include guard.
3810         * tui/tui-win.h: Rename include guard.
3811         * tui/tui-stack.h: Rename include guard.
3812         * tui/tui-source.h: Rename include guard.
3813         * tui/tui-regs.h: Rename include guard.
3814         * tui/tui-out.h: Rename include guard.
3815         * tui/tui-layout.h: Rename include guard.
3816         * tui/tui-io.h: Rename include guard.
3817         * tui/tui-hooks.h: Rename include guard.
3818         * tui/tui-file.h: Rename include guard.
3819         * tui/tui-disasm.h: Rename include guard.
3820         * tui/tui-data.h: Rename include guard.
3821         * tui/tui-command.h: Rename include guard.
3822         * tic6x-tdep.h: Add include guard.
3823         * target/waitstatus.h: Rename include guard.
3824         * target/wait.h: Rename include guard.
3825         * target/target.h: Rename include guard.
3826         * target/resume.h: Rename include guard.
3827         * target-float.h: Rename include guard.
3828         * stabsread.h: Add include guard.
3829         * rs6000-tdep.h: Add include guard.
3830         * riscv-fbsd-tdep.h: Add include guard.
3831         * regformats/regdef.h: Rename include guard.
3832         * record.h: Rename include guard.
3833         * python/python.h: Rename include guard.
3834         * python/python-internal.h: Rename include guard.
3835         * python/py-stopevent.h: Rename include guard.
3836         * python/py-ref.h: Rename include guard.
3837         * python/py-record.h: Rename include guard.
3838         * python/py-record-full.h: Rename include guard.
3839         * python/py-record-btrace.h: Rename include guard.
3840         * python/py-instruction.h: Rename include guard.
3841         * python/py-events.h: Rename include guard.
3842         * python/py-event.h: Rename include guard.
3843         * procfs.h: Add include guard.
3844         * proc-utils.h: Add include guard.
3845         * p-lang.h: Add include guard.
3846         * or1k-tdep.h: Rename include guard.
3847         * observable.h: Rename include guard.
3848         * nto-tdep.h: Rename include guard.
3849         * nat/x86-linux.h: Rename include guard.
3850         * nat/x86-linux-dregs.h: Rename include guard.
3851         * nat/x86-gcc-cpuid.h: Add include guard.
3852         * nat/x86-dregs.h: Rename include guard.
3853         * nat/x86-cpuid.h: Rename include guard.
3854         * nat/ppc-linux.h: Rename include guard.
3855         * nat/mips-linux-watch.h: Rename include guard.
3856         * nat/linux-waitpid.h: Rename include guard.
3857         * nat/linux-ptrace.h: Rename include guard.
3858         * nat/linux-procfs.h: Rename include guard.
3859         * nat/linux-osdata.h: Rename include guard.
3860         * nat/linux-nat.h: Rename include guard.
3861         * nat/linux-namespaces.h: Rename include guard.
3862         * nat/linux-btrace.h: Rename include guard.
3863         * nat/glibc_thread_db.h: Rename include guard.
3864         * nat/gdb_thread_db.h: Rename include guard.
3865         * nat/gdb_ptrace.h: Rename include guard.
3866         * nat/fork-inferior.h: Rename include guard.
3867         * nat/amd64-linux-siginfo.h: Rename include guard.
3868         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3869         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3870         * nat/aarch64-linux.h: Rename include guard.
3871         * nat/aarch64-linux-hw-point.h: Rename include guard.
3872         * mn10300-tdep.h: Add include guard.
3873         * mips-linux-tdep.h: Add include guard.
3874         * mi/mi-parse.h: Rename include guard.
3875         * mi/mi-out.h: Rename include guard.
3876         * mi/mi-main.h: Rename include guard.
3877         * mi/mi-interp.h: Rename include guard.
3878         * mi/mi-getopt.h: Rename include guard.
3879         * mi/mi-console.h: Rename include guard.
3880         * mi/mi-common.h: Rename include guard.
3881         * mi/mi-cmds.h: Rename include guard.
3882         * mi/mi-cmd-break.h: Rename include guard.
3883         * m2-lang.h: Add include guard.
3884         * location.h: Rename include guard.
3885         * linux-record.h: Rename include guard.
3886         * linux-nat.h: Add include guard.
3887         * linux-fork.h: Add include guard.
3888         * i386-darwin-tdep.h: Rename include guard.
3889         * hppa-linux-offsets.h: Add include guard.
3890         * guile/guile.h: Rename include guard.
3891         * guile/guile-internal.h: Rename include guard.
3892         * gnu-nat.h: Rename include guard.
3893         * gdb-stabs.h: Rename include guard.
3894         * frv-tdep.h: Add include guard.
3895         * f-lang.h: Add include guard.
3896         * event-loop.h: Add include guard.
3897         * darwin-nat.h: Rename include guard.
3898         * cp-abi.h: Rename include guard.
3899         * config/sparc/nm-sol2.h: Rename include guard.
3900         * config/nm-nto.h: Rename include guard.
3901         * config/nm-linux.h: Add include guard.
3902         * config/i386/nm-i386gnu.h: Rename include guard.
3903         * config/djgpp/nl_types.h: Rename include guard.
3904         * config/djgpp/langinfo.h: Rename include guard.
3905         * compile/gcc-cp-plugin.h: Add include guard.
3906         * compile/gcc-c-plugin.h: Add include guard.
3907         * compile/compile.h: Rename include guard.
3908         * compile/compile-object-run.h: Rename include guard.
3909         * compile/compile-object-load.h: Rename include guard.
3910         * compile/compile-internal.h: Rename include guard.
3911         * compile/compile-cplus.h: Rename include guard.
3912         * compile/compile-c.h: Rename include guard.
3913         * common/xml-utils.h: Rename include guard.
3914         * common/x86-xstate.h: Rename include guard.
3915         * common/version.h: Rename include guard.
3916         * common/vec.h: Rename include guard.
3917         * common/tdesc.h: Rename include guard.
3918         * common/selftest.h: Rename include guard.
3919         * common/scoped_restore.h: Rename include guard.
3920         * common/scoped_mmap.h: Rename include guard.
3921         * common/scoped_fd.h: Rename include guard.
3922         * common/safe-iterator.h: Rename include guard.
3923         * common/run-time-clock.h: Rename include guard.
3924         * common/refcounted-object.h: Rename include guard.
3925         * common/queue.h: Rename include guard.
3926         * common/ptid.h: Rename include guard.
3927         * common/print-utils.h: Rename include guard.
3928         * common/preprocessor.h: Rename include guard.
3929         * common/pathstuff.h: Rename include guard.
3930         * common/observable.h: Rename include guard.
3931         * common/netstuff.h: Rename include guard.
3932         * common/job-control.h: Rename include guard.
3933         * common/host-defs.h: Rename include guard.
3934         * common/gdb_wait.h: Rename include guard.
3935         * common/gdb_vecs.h: Rename include guard.
3936         * common/gdb_unlinker.h: Rename include guard.
3937         * common/gdb_unique_ptr.h: Rename include guard.
3938         * common/gdb_tilde_expand.h: Rename include guard.
3939         * common/gdb_sys_time.h: Rename include guard.
3940         * common/gdb_string_view.h: Rename include guard.
3941         * common/gdb_splay_tree.h: Rename include guard.
3942         * common/gdb_setjmp.h: Rename include guard.
3943         * common/gdb_ref_ptr.h: Rename include guard.
3944         * common/gdb_optional.h: Rename include guard.
3945         * common/gdb_locale.h: Rename include guard.
3946         * common/gdb_assert.h: Rename include guard.
3947         * common/filtered-iterator.h: Rename include guard.
3948         * common/filestuff.h: Rename include guard.
3949         * common/fileio.h: Rename include guard.
3950         * common/environ.h: Rename include guard.
3951         * common/common-utils.h: Rename include guard.
3952         * common/common-types.h: Rename include guard.
3953         * common/common-regcache.h: Rename include guard.
3954         * common/common-inferior.h: Rename include guard.
3955         * common/common-gdbthread.h: Rename include guard.
3956         * common/common-exceptions.h: Rename include guard.
3957         * common/common-defs.h: Rename include guard.
3958         * common/common-debug.h: Rename include guard.
3959         * common/cleanups.h: Rename include guard.
3960         * common/buffer.h: Rename include guard.
3961         * common/btrace-common.h: Rename include guard.
3962         * common/break-common.h: Rename include guard.
3963         * cli/cli-utils.h: Rename include guard.
3964         * cli/cli-style.h: Rename include guard.
3965         * cli/cli-setshow.h: Rename include guard.
3966         * cli/cli-script.h: Rename include guard.
3967         * cli/cli-interp.h: Rename include guard.
3968         * cli/cli-decode.h: Rename include guard.
3969         * cli/cli-cmds.h: Rename include guard.
3970         * charset-list.h: Add include guard.
3971         * buildsym-legacy.h: Rename include guard.
3972         * bfin-tdep.h: Add include guard.
3973         * ax.h: Rename include guard.
3974         * arm-linux-tdep.h: Add include guard.
3975         * arm-fbsd-tdep.h: Add include guard.
3976         * arch/xtensa.h: Rename include guard.
3977         * arch/tic6x.h: Add include guard.
3978         * arch/i386.h: Add include guard.
3979         * arch/arm.h: Rename include guard.
3980         * arch/arm-linux.h: Rename include guard.
3981         * arch/arm-get-next-pcs.h: Rename include guard.
3982         * arch/amd64.h: Add include guard.
3983         * arch/aarch64-insn.h: Rename include guard.
3984         * arch-utils.h: Rename include guard.
3985         * annotate.h: Add include guard.
3986         * amd64-darwin-tdep.h: Rename include guard.
3987         * aarch64-linux-tdep.h: Add include guard.
3988         * aarch64-fbsd-tdep.h: Add include guard.
3989         * aarch32-linux-nat.h: Add include guard.
3990
3991 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3992
3993         * macrotab.c (macro_define_internal): New function that
3994         factorizes macro_define_object_internal and macro_define_function
3995         code.
3996         (macro_define_object_internal): Use macro_define_internal.
3997         (macro_define_function): Likewise.
3998
3999 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4000
4001         * macrocmd.c (extract_identifier): Return
4002         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4003         callers.
4004
4005 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4006
4007         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4008
4009 2019-02-05  Tom Tromey  <tom@tromey.com>
4010
4011         * target.c (target_stack::unpush): Move assertion earlier.
4012
4013 2019-01-30  Tom Tromey  <tom@tromey.com>
4014
4015         PR python/23615:
4016         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4017         (gdbpy_parse_and_eval): Likewise.
4018         * python/python-internal.h (gdbpy_allow_threads): New class.
4019
4020 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4021
4022         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4023         (aarch64_fbsd_fpregmap): Move earlier.
4024         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4025         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4026         instead of individual calls to trad_frame_set_reg_addr.
4027         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4028         earlier.
4029         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4030         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4031         instead of individual calls to trad_frame_set_reg_addr.
4032
4033 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4034
4035         * CONTRIBUTE: Replace contribution list with wiki link.
4036
4037 2019-01-25  Tom Tromey  <tom@tromey.com>
4038
4039         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4040
4041 2019-01-25  Tom Tromey  <tom@tromey.com>
4042
4043         * xtensa-linux-nat.c: Fix common/ includes.
4044         * xml-support.h: Fix common/ includes.
4045         * xml-support.c: Fix common/ includes.
4046         * x86-linux-nat.c: Fix common/ includes.
4047         * windows-nat.c: Fix common/ includes.
4048         * varobj.h: Fix common/ includes.
4049         * varobj.c: Fix common/ includes.
4050         * value.c: Fix common/ includes.
4051         * valops.c: Fix common/ includes.
4052         * utils.c: Fix common/ includes.
4053         * unittests/xml-utils-selftests.c: Fix common/ includes.
4054         * unittests/utils-selftests.c: Fix common/ includes.
4055         * unittests/unpack-selftests.c: Fix common/ includes.
4056         * unittests/tracepoint-selftests.c: Fix common/ includes.
4057         * unittests/style-selftests.c: Fix common/ includes.
4058         * unittests/string_view-selftests.c: Fix common/ includes.
4059         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4060         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4061         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4062         * unittests/rsp-low-selftests.c: Fix common/ includes.
4063         * unittests/parse-connection-spec-selftests.c: Fix common/
4064         includes.
4065         * unittests/optional-selftests.c: Fix common/ includes.
4066         * unittests/offset-type-selftests.c: Fix common/ includes.
4067         * unittests/observable-selftests.c: Fix common/ includes.
4068         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4069         * unittests/memrange-selftests.c: Fix common/ includes.
4070         * unittests/memory-map-selftests.c: Fix common/ includes.
4071         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4072         * unittests/function-view-selftests.c: Fix common/ includes.
4073         * unittests/environ-selftests.c: Fix common/ includes.
4074         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4075         * unittests/common-utils-selftests.c: Fix common/ includes.
4076         * unittests/cli-utils-selftests.c: Fix common/ includes.
4077         * unittests/array-view-selftests.c: Fix common/ includes.
4078         * ui-file.c: Fix common/ includes.
4079         * tui/tui-io.c: Fix common/ includes.
4080         * tracepoint.h: Fix common/ includes.
4081         * tracepoint.c: Fix common/ includes.
4082         * tracefile-tfile.c: Fix common/ includes.
4083         * top.h: Fix common/ includes.
4084         * top.c: Fix common/ includes.
4085         * thread.c: Fix common/ includes.
4086         * target/waitstatus.h: Fix common/ includes.
4087         * target/waitstatus.c: Fix common/ includes.
4088         * target.h: Fix common/ includes.
4089         * target.c: Fix common/ includes.
4090         * target-memory.c: Fix common/ includes.
4091         * target-descriptions.c: Fix common/ includes.
4092         * symtab.h: Fix common/ includes.
4093         * symfile.c: Fix common/ includes.
4094         * stap-probe.c: Fix common/ includes.
4095         * spu-linux-nat.c: Fix common/ includes.
4096         * sparc-nat.c: Fix common/ includes.
4097         * source.c: Fix common/ includes.
4098         * solib.c: Fix common/ includes.
4099         * solib-target.c: Fix common/ includes.
4100         * ser-unix.c: Fix common/ includes.
4101         * ser-tcp.c: Fix common/ includes.
4102         * ser-pipe.c: Fix common/ includes.
4103         * ser-base.c: Fix common/ includes.
4104         * selftest-arch.c: Fix common/ includes.
4105         * s12z-tdep.c: Fix common/ includes.
4106         * rust-exp.y: Fix common/ includes.
4107         * rs6000-aix-tdep.c: Fix common/ includes.
4108         * riscv-tdep.c: Fix common/ includes.
4109         * remote.c: Fix common/ includes.
4110         * remote-notif.h: Fix common/ includes.
4111         * remote-fileio.h: Fix common/ includes.
4112         * remote-fileio.c: Fix common/ includes.
4113         * regcache.h: Fix common/ includes.
4114         * regcache.c: Fix common/ includes.
4115         * record-btrace.c: Fix common/ includes.
4116         * python/python.c: Fix common/ includes.
4117         * python/py-type.c: Fix common/ includes.
4118         * python/py-inferior.c: Fix common/ includes.
4119         * progspace.h: Fix common/ includes.
4120         * producer.c: Fix common/ includes.
4121         * procfs.c: Fix common/ includes.
4122         * proc-api.c: Fix common/ includes.
4123         * printcmd.c: Fix common/ includes.
4124         * ppc-linux-nat.c: Fix common/ includes.
4125         * parser-defs.h: Fix common/ includes.
4126         * osdata.c: Fix common/ includes.
4127         * obsd-nat.c: Fix common/ includes.
4128         * nat/x86-linux.c: Fix common/ includes.
4129         * nat/x86-linux-dregs.c: Fix common/ includes.
4130         * nat/x86-dregs.h: Fix common/ includes.
4131         * nat/x86-dregs.c: Fix common/ includes.
4132         * nat/ppc-linux.c: Fix common/ includes.
4133         * nat/mips-linux-watch.h: Fix common/ includes.
4134         * nat/mips-linux-watch.c: Fix common/ includes.
4135         * nat/linux-waitpid.c: Fix common/ includes.
4136         * nat/linux-ptrace.h: Fix common/ includes.
4137         * nat/linux-ptrace.c: Fix common/ includes.
4138         * nat/linux-procfs.c: Fix common/ includes.
4139         * nat/linux-personality.c: Fix common/ includes.
4140         * nat/linux-osdata.c: Fix common/ includes.
4141         * nat/linux-namespaces.c: Fix common/ includes.
4142         * nat/linux-btrace.h: Fix common/ includes.
4143         * nat/linux-btrace.c: Fix common/ includes.
4144         * nat/fork-inferior.c: Fix common/ includes.
4145         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4146         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4147         * nat/aarch64-linux.c: Fix common/ includes.
4148         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4149         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4150         * namespace.h: Fix common/ includes.
4151         * mips-linux-tdep.c: Fix common/ includes.
4152         * minsyms.c: Fix common/ includes.
4153         * mi/mi-parse.h: Fix common/ includes.
4154         * mi/mi-main.c: Fix common/ includes.
4155         * mi/mi-cmd-env.c: Fix common/ includes.
4156         * memrange.h: Fix common/ includes.
4157         * memattr.c: Fix common/ includes.
4158         * maint.h: Fix common/ includes.
4159         * maint.c: Fix common/ includes.
4160         * main.c: Fix common/ includes.
4161         * machoread.c: Fix common/ includes.
4162         * location.c: Fix common/ includes.
4163         * linux-thread-db.c: Fix common/ includes.
4164         * linux-nat.c: Fix common/ includes.
4165         * linux-fork.c: Fix common/ includes.
4166         * inline-frame.c: Fix common/ includes.
4167         * infrun.c: Fix common/ includes.
4168         * inflow.c: Fix common/ includes.
4169         * inferior.h: Fix common/ includes.
4170         * inferior.c: Fix common/ includes.
4171         * infcmd.c: Fix common/ includes.
4172         * inf-ptrace.c: Fix common/ includes.
4173         * inf-child.c: Fix common/ includes.
4174         * ia64-linux-nat.c: Fix common/ includes.
4175         * i387-tdep.c: Fix common/ includes.
4176         * i386-tdep.c: Fix common/ includes.
4177         * i386-linux-tdep.c: Fix common/ includes.
4178         * i386-linux-nat.c: Fix common/ includes.
4179         * i386-go32-tdep.c: Fix common/ includes.
4180         * i386-fbsd-tdep.c: Fix common/ includes.
4181         * i386-fbsd-nat.c: Fix common/ includes.
4182         * guile/scm-type.c: Fix common/ includes.
4183         * guile/guile.c: Fix common/ includes.
4184         * go32-nat.c: Fix common/ includes.
4185         * gnu-nat.c: Fix common/ includes.
4186         * gdbthread.h: Fix common/ includes.
4187         * gdbarch-selftests.c: Fix common/ includes.
4188         * gdb_usleep.c: Fix common/ includes.
4189         * gdb_select.h: Fix common/ includes.
4190         * gdb_bfd.c: Fix common/ includes.
4191         * gcore.c: Fix common/ includes.
4192         * fork-child.c: Fix common/ includes.
4193         * findvar.c: Fix common/ includes.
4194         * fbsd-nat.c: Fix common/ includes.
4195         * event-top.c: Fix common/ includes.
4196         * event-loop.c: Fix common/ includes.
4197         * dwarf2read.c: Fix common/ includes.
4198         * dwarf2loc.c: Fix common/ includes.
4199         * dwarf2-frame.c: Fix common/ includes.
4200         * dwarf-index-cache.c: Fix common/ includes.
4201         * dtrace-probe.c: Fix common/ includes.
4202         * disasm-selftests.c: Fix common/ includes.
4203         * defs.h: Fix common/ includes.
4204         * csky-tdep.c: Fix common/ includes.
4205         * cp-valprint.c: Fix common/ includes.
4206         * cp-support.h: Fix common/ includes.
4207         * cp-support.c: Fix common/ includes.
4208         * corelow.c: Fix common/ includes.
4209         * completer.h: Fix common/ includes.
4210         * completer.c: Fix common/ includes.
4211         * compile/compile.c: Fix common/ includes.
4212         * compile/compile-loc2c.c: Fix common/ includes.
4213         * compile/compile-cplus-types.c: Fix common/ includes.
4214         * compile/compile-cplus-symbols.c: Fix common/ includes.
4215         * command.h: Fix common/ includes.
4216         * cli/cli-dump.c: Fix common/ includes.
4217         * cli/cli-cmds.c: Fix common/ includes.
4218         * charset.c: Fix common/ includes.
4219         * build-id.c: Fix common/ includes.
4220         * btrace.h: Fix common/ includes.
4221         * btrace.c: Fix common/ includes.
4222         * breakpoint.h: Fix common/ includes.
4223         * breakpoint.c: Fix common/ includes.
4224         * ax.h:
4225         (enum agent_op): Fix common/ includes.
4226         * ax-general.c (struct aop_map): Fix common/ includes.
4227         * ax-gdb.c: Fix common/ includes.
4228         * auxv.c: Fix common/ includes.
4229         * auto-load.c: Fix common/ includes.
4230         * arm-tdep.c: Fix common/ includes.
4231         * arch/riscv.c: Fix common/ includes.
4232         * arch/ppc-linux-common.c: Fix common/ includes.
4233         * arch/i386.c: Fix common/ includes.
4234         * arch/arm.c: Fix common/ includes.
4235         * arch/arm-linux.c: Fix common/ includes.
4236         * arch/arm-get-next-pcs.c: Fix common/ includes.
4237         * arch/amd64.c: Fix common/ includes.
4238         * arch/aarch64.c: Fix common/ includes.
4239         * arch/aarch64-insn.c: Fix common/ includes.
4240         * arch-utils.c: Fix common/ includes.
4241         * amd64-windows-tdep.c: Fix common/ includes.
4242         * amd64-tdep.c: Fix common/ includes.
4243         * amd64-sol2-tdep.c: Fix common/ includes.
4244         * amd64-obsd-tdep.c: Fix common/ includes.
4245         * amd64-nbsd-tdep.c: Fix common/ includes.
4246         * amd64-linux-tdep.c: Fix common/ includes.
4247         * amd64-linux-nat.c: Fix common/ includes.
4248         * amd64-fbsd-tdep.c: Fix common/ includes.
4249         * amd64-fbsd-nat.c: Fix common/ includes.
4250         * amd64-dicos-tdep.c: Fix common/ includes.
4251         * amd64-darwin-tdep.c: Fix common/ includes.
4252         * agent.c: Fix common/ includes.
4253         * ada-lang.h: Fix common/ includes.
4254         * ada-lang.c: Fix common/ includes.
4255         * aarch64-tdep.c: Fix common/ includes.
4256
4257 2019-01-25  Tom Tromey  <tom@tromey.com>
4258
4259         * common/create-version.sh: Use common/version.h.
4260
4261 2019-01-24  Pedro Alves  <palves@redhat.com>
4262
4263         * infrun.c (signal_stop, signal_print, signal_program)
4264         (signal_catch, signal_pass): Now arrays instead of pointers.
4265         (update_signals_program_target, do_target_resume)
4266         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4267         * linux-nat.c (linux_nat_target::pass_signals)
4268         (linux_nat_target::create_inferior, linux_nat_target::attach):
4269         Adjust.
4270         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4271         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4272         * procfs.c (procfs_target::pass_signals): Adjust.
4273         * record-full.c (record_full_target::resume): Adjust.
4274         * remote.c (remote_target::pass_signals)
4275         (remote_target::program_signals): Adjust.
4276         * target-debug.h (target_debug_print_signals): Now takes a
4277         gdb::array_view as parameter.  Adjust.
4278         * target.h (target_ops) <pass_signals, program_signals>: Replace
4279         pointer and length parameters with gdb::array_view.
4280         (target_pass_signals, target_program_signals): Likewise.
4281         * target-delegates.c: Regenerate.
4282
4283 2019-01-24  Pedro Alves  <palves@redhat.com>
4284
4285         * common/forward-scope-exit.h
4286         (forward_scope_exit::forward_scope_exit): Pass arguments to
4287         m_bind_function directly, instead of creating a std::bind and
4288         copying that.
4289
4290 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4291
4292         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4293         for static members.
4294         (pass_in_v_vfp_candidate): Likewise.
4295
4296 2019-01-23  Tom Tromey  <tom@tromey.com>
4297             Pedro Alves  <palves@redhat.com>
4298
4299         * regcache.c (class regcache_invalidator): Remove.
4300         (regcache::raw_write): Use make_scope_exit.
4301
4302 2019-01-23  Tom Tromey  <tom@tromey.com>
4303
4304         * ui-out.h (class ui_out_emit_type): Update comment.
4305
4306 2019-01-23  Tom Tromey  <tom@tromey.com>
4307
4308         * infrun.c (fetch_inferior_event): Update comment.
4309
4310 2019-01-23  Tom Tromey  <tom@tromey.com>
4311             Pedro Alves  <palves@redhat.com>
4312
4313         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4314         parameter.
4315         (fetch_inferior_event): Use SCOPE_EXIT.
4316
4317
4318 2019-01-23  Tom Tromey  <tom@tromey.com>
4319             Pedro Alves  <palves@redhat.com>
4320
4321         * infrun.c (disable_thread_events): Delete.
4322         (stop_all_threads): Use SCOPE_EXIT.
4323
4324 2019-01-23  Tom Tromey  <tom@tromey.com>
4325             Pedro Alves  <palves@redhat.com>
4326
4327         * symfile.c: Include forward-scope-exit.h.
4328         (clear_symtab_users_cleanup): Replace forward declaration with
4329         a FORWARD_SCOPE_EXIT.
4330         (syms_from_objfile_1): Use the forward_scope_exit and
4331         gdb::optional instead of cleanup_function.
4332         (reread_symbols): Use the forward_scope_exit instead of
4333         cleanup_function.
4334         (clear_symtab_users_cleanup): Remove function.
4335
4336 2019-01-23  Tom Tromey  <tom@tromey.com>
4337             Pedro Alves  <palves@redhat.com>
4338
4339         * linux-nat.c: Include scope-exit.h.
4340         (cleanup_target_stop): Remove.
4341         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4342         SCOPE_EXIT.
4343
4344 2019-01-23  Tom Tromey  <tom@tromey.com>
4345             Pedro Alves  <palves@redhat.com>
4346
4347         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4348         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4349
4350 2019-01-23  Tom Tromey  <tom@tromey.com>
4351             Andrew Burgess  <andrew.burgess@embecosm.com>
4352             Pedro Alves  <palves@redhat.com>
4353
4354         * infrun.c (fetch_inferior_event): Use scope_exit.
4355         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4356         * top.c (execute_command): Use scope_exit.
4357         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4358         * utils.c (do_bpstat_clear_actions_cleanup)
4359         (make_bpstat_clear_actions_cleanup): Remove.
4360
4361 2019-01-23  Tom Tromey  <tom@tromey.com>
4362             Pedro Alves  <palves@redhat.com>
4363
4364         * infrun.c: Include "common/scope-exit.h"
4365         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4366         (wait_for_inferior): Use SCOPE_EXIT.
4367         (fetch_inferior_event): Use scope_exit.
4368
4369 2019-01-23  Tom Tromey  <tom@tromey.com>
4370             Pedro Alves  <palves@redhat.com>
4371
4372         * breakpoint.c (create_breakpoint): Remove cleanup.
4373
4374 2019-01-23  Tom Tromey  <tom@tromey.com>
4375             Andrew Burgess  <andrew.burgess@embecosm.com>
4376             Pedro Alves  <palves@redhat.com>
4377
4378 2019-01-23  Pedro Alves  <palves@redhat.com>
4379
4380         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4381
4382 2019-01-23  Pedro Alves  <palves@redhat.com>
4383             Andrew Burgess  <andrew.burgess@embecosm.com>
4384
4385         * gdbthread.h: Include "common/forward-scope-exit.h".
4386         (scoped_finish_thread_state): Redefine custom class in terms of
4387         forward_scope_exit.
4388
4389 2019-01-23  Pedro Alves  <palves@redhat.com>
4390             Andrew Burgess  <andrew.burgess@embecosm.com>
4391
4392         * common/forward-scope-exit.h: New file.
4393
4394 2019-01-23  Pedro Alves  <palves@redhat.com>
4395             Andrew Burgess  <andrew.burgess@embecosm.com>
4396             Tom Tromey  <tom@tromey.com>
4397
4398         * common/scope-exit.h: New file.
4399
4400 2019-01-23  Pedro Alves  <palves@redhat.com>
4401
4402         * common/preprocessor.h (ESC): Rename to ...
4403         (ESC_PARENS): ... this.
4404         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4405         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4406
4407 2019-01-23  Tom Tromey  <tom@tromey.com>
4408
4409         * language.h (class scoped_switch_to_sym_language_if_auto):
4410         Initialize m_lang in both cases.
4411
4412 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4413
4414         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4415         with XCNEW.
4416
4417 2019-01-22  Tom Tromey  <tom@tromey.com>
4418
4419         * corelow.c: Do not include sys/file.h.
4420
4421 2019-01-22  Tom Tromey  <tom@tromey.com>
4422
4423         * tui/tui-wingeneral.h: Include gdb_curses.h.
4424
4425 2019-01-22  Tom Tromey  <tom@tromey.com>
4426
4427         * source-cache.h (class source_cache) <get_source_lines,
4428         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4429
4430 2019-01-22  Tom Tromey  <tom@tromey.com>
4431
4432         * remote-fileio.h (struct remote_target): Declare.
4433
4434 2019-01-22  Tom Tromey  <tom@tromey.com>
4435
4436         * python/py-arch.c: Do not include py-ref.h.
4437         * python/py-bpevent.c: Do not include py-ref.h.
4438         * python/py-cmd.c: Do not include py-ref.h.
4439         * python/py-continueevent.c: Do not include py-ref.h.
4440         * python/py-event.h: Do not include py-ref.h.
4441         * python/py-evtregistry.c: Do not include py-ref.h.
4442         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4443         * python/py-frame.c: Do not include py-ref.h.
4444         * python/py-framefilter.c: Do not include py-ref.h.
4445         * python/py-function.c: Do not include py-ref.h.
4446         * python/py-infevents.c: Do not include py-ref.h.
4447         * python/py-linetable.c: Do not include py-ref.h.
4448         * python/py-objfile.c: Do not include py-ref.h.
4449         * python/py-param.c: Do not include py-ref.h.
4450         * python/py-prettyprint.c: Do not include py-ref.h.
4451         * python/py-progspace.c: Do not include py-ref.h.
4452         * python/py-symbol.c: Do not include py-ref.h.
4453         * python/py-symtab.c: Do not include py-ref.h.
4454         * python/py-type.c: Do not include py-ref.h.
4455         * python/py-unwind.c: Do not include py-ref.h.
4456         * python/py-utils.c: Do not include py-ref.h.
4457         * python/py-value.c: Do not include py-ref.h.
4458         * python/py-varobj.c: Do not include py-ref.h.
4459         * python/py-xmethods.c: Do not include py-ref.h.
4460         * python/python.c: Do not include py-ref.h.
4461         * varobj.c: Do not include py-ref.h.
4462
4463 2019-01-22  Tom Tromey  <tom@tromey.com>
4464
4465         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4466         keyword for bcache.
4467
4468 2019-01-22  Tom Tromey  <tom@tromey.com>
4469
4470         * compile/compile-cplus-types.c: Remove a comment by #include.
4471
4472 2019-01-22  Tom Tromey  <tom@tromey.com>
4473
4474         * compile/gcc-c-plugin.h: Include compile-internal.h.
4475
4476 2019-01-22  Tom Tromey  <tom@tromey.com>
4477
4478         * stabsread.c (EXTERN): Do not define.
4479         (symnum, next_symbol_text_func, processing_gcc_compilation)
4480         (within_function, global_sym_chain, global_stabs)
4481         (previous_stab_code, this_object_header_files)
4482         (n_this_object_header_files)
4483         (n_allocated_this_object_header_files): Define.
4484         * stabsread.h (EXTERN): Never define.  Use "extern".
4485
4486 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4487
4488         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4489         history_value.
4490
4491 2019-01-21  Tom Tromey  <tom@tromey.com>
4492
4493         * ui-out.c: Fix includes.
4494         * tui/tui-source.c: Fix includes.
4495         * target.c: Fix includes.
4496         * remote.c: Fix includes.
4497         * regcache.c: Fix includes.
4498         * python/py-block.c: Fix includes.
4499         * printcmd.c: Fix includes.
4500         * or1k-tdep.c: Fix includes.
4501         * mi/mi-main.c: Fix includes.
4502         * m32r-tdep.c: Fix includes.
4503         * csky-tdep.c: Fix includes.
4504         * compile/compile-cplus-types.c: Fix includes.
4505         * cli/cli-interp.c: Fix includes.
4506
4507 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4508
4509         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4510         for padding.
4511
4512 2019-01-16  Tom Tromey  <tom@tromey.com>
4513
4514         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4515         earlier.
4516         (struct objfile) <msymbols_range>: Move from top level.
4517         <msymbols>: New method.
4518         (class objfile_msymbols): Remove.
4519         * symtab.c (default_collect_symbol_completion_matches_break_on):
4520         Update.
4521         * symmisc.c (dump_msymbols): Update.
4522         * stabsread.c (scan_file_globals): Update.
4523         * objc-lang.c (info_selectors_command, info_classes_command)
4524         (find_methods): Update.
4525         * minsyms.c (find_solib_trampoline_target): Update.
4526         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4527         * coffread.c (coff_symfile_read): Update.
4528         * ada-lang.c (ada_lookup_simple_minsym)
4529         (ada_collect_symbol_completion_matches): Update.
4530
4531 2019-01-16  Tom Tromey  <tom@tromey.com>
4532
4533         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4534         type.  Remove no-argument constructor.
4535         <iterator::operator++>: Simplify.
4536         <begin>: Update.
4537         <end>: Use minimal_symbol_count.
4538
4539 2019-01-16  Tom Tromey  <tom@tromey.com>
4540
4541         * objfiles.h (struct objfile) <psymtabs>: New method.
4542         (class objfile_psymtabs): Remove.
4543         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4544         typedef.
4545         <range>: New method.
4546         (require_partial_symbols): Change return type.
4547         * psymtab.c (require_partial_symbols)
4548         (psym_expand_symtabs_matching): Update.
4549         * mdebugread.c (parse_partial_symbols): Update.
4550         * dbxread.c (dbx_end_psymtab): Update.
4551
4552 2019-01-15  Tom Tromey  <tom@tromey.com>
4553
4554         * symtab.c (lookup_objfile_from_block)
4555         (lookup_symbol_in_objfile_symtabs)
4556         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4557         (find_line_symtab, info_sources_command)
4558         (default_collect_symbol_completion_matches_break_on)
4559         (make_source_files_completion_list): Update.
4560         * symmisc.c (print_objfile_statistics, dump_objfile)
4561         (maintenance_print_symbols, maintenance_info_symtabs)
4562         (maintenance_check_symtabs, maintenance_info_line_tables):
4563         Update.
4564         * source.c (select_source_symtab)
4565         (forget_cached_source_info_for_objfile): Update.
4566         * objfiles.h (class objfile_compunits): Remove.
4567         (struct objfile) <compunits_range>: New typedef.
4568         (compunits): New method.
4569         * objfiles.c (objfile_relocate1): Update.
4570         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4571         * maint.c (count_symtabs_and_blocks): Update.
4572         * linespec.c (iterate_over_all_matching_symtabs): Update.
4573         * cp-support.c (add_symbol_overload_list_qualified): Update.
4574         * coffread.c (coff_symtab_read): Update.
4575         * ada-lang.c (add_nonlocal_symbols)
4576         (ada_collect_symbol_completion_matches)
4577         (ada_add_global_exceptions): Update.
4578
4579 2019-01-15  Tom Tromey  <tom@tromey.com>
4580
4581         * progspace.h (program_space) <objfiles_safe_range>: New
4582         typedef.
4583         <objfiles_safe>: New method.
4584         * objfiles.h (class all_objfiles_safe): Remove.
4585         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4586         * jit.c (jit_inferior_exit_hook): Update.
4587
4588 2019-01-17  Tom Tromey  <tom@tromey.com>
4589
4590         * progspace.h (program_space) <objfiles_range>: New typedef.
4591         <objfiles>: New method.
4592         <objfiles_head>: Rename from objfiles.
4593         (object_files): Update.
4594         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4595         * guile/scm-pretty-print.c
4596         (ppscm_find_pretty_printer_from_objfiles): Update.
4597         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4598         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4599         Update.
4600         * python/py-progspace.c (pspy_get_objfiles): Update.
4601         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4602         Update.
4603         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4604         (objfpy_lookup_objfile_by_build_id): Update.
4605         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4606         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4607         Update.
4608         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4609         (expand_symtab_containing_pc, lookup_objfile_from_block)
4610         (lookup_static_symbol, basic_lookup_transparent_type)
4611         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4612         (find_line_symtab, info_sources_command)
4613         (default_collect_symbol_completion_matches_break_on)
4614         (make_source_files_completion_list, find_main_name): Update.
4615         * symmisc.c (print_symbol_bcache_statistics)
4616         (print_objfile_statistics, maintenance_print_symbols)
4617         (maintenance_print_msymbols, maintenance_print_objfiles)
4618         (maintenance_info_symtabs, maintenance_check_symtabs)
4619         (maintenance_expand_symtabs, maintenance_info_line_tables):
4620         Update.
4621         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4622         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4623         (map_overlay_command, unmap_overlay_command)
4624         (simple_overlay_update, expand_symtabs_matching)
4625         (map_symbol_filenames): Update.
4626         * symfile-debug.c (set_debug_symfile): Update.
4627         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4628         Update.
4629         * source.c (select_source_symtab, forget_cached_source_info):
4630         Update.
4631         * solib.c (solib_read_symbols): Update.
4632         * solib-spu.c (append_ocl_sos): Update.
4633         * psymtab.c (maintenance_print_psymbols)
4634         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4635         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4636         * printcmd.c (info_symbol_command): Update.
4637         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4638         Update.
4639         * objfiles.h (class all_objfiles): Remove.
4640         * objfiles.c (have_partial_symbols, have_full_symbols)
4641         (have_minimal_symbols, qsort_cmp, update_section_map)
4642         (shared_objfile_contains_address_p)
4643         (default_iterate_over_objfiles_in_search_order): Update.
4644         * objc-lang.c (info_selectors_command, info_classes_command)
4645         (find_methods): Update.
4646         * minsyms.c (find_solib_trampoline_target): Update.
4647         * maint.c (maintenance_info_sections)
4648         (maintenance_translate_address, count_symtabs_and_blocks):
4649         Update.
4650         * main.c (captured_main_1): Update.
4651         * linux-thread-db.c (try_thread_db_load_from_pdir)
4652         (has_libpthread): Update.
4653         * linespec.c (iterate_over_all_matching_symtabs)
4654         (search_minsyms_for_name): Update.
4655         * jit.c (jit_find_objf_with_entry_addr): Update.
4656         * hppa-tdep.c (find_unwind_entry)
4657         (hppa_lookup_stub_minimal_symbol): Update.
4658         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4659         Update.
4660         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4661         (elf_gnu_ifunc_resolve_by_got): Update.
4662         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4663         * dwarf-index-write.c (save_gdb_index_command): Update.
4664         * cp-support.c (add_symbol_overload_list_qualified): Update.
4665         * breakpoint.c (create_overlay_event_breakpoint)
4666         (create_longjmp_master_breakpoint)
4667         (create_std_terminate_master_breakpoint)
4668         (create_exception_master_breakpoint): Update.
4669         * blockframe.c (find_pc_partial_function): Update.
4670         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4671         (ada_collect_symbol_completion_matches)
4672         (ada_add_global_exceptions): Update.
4673
4674 2019-01-17  Tom Tromey  <tom@tromey.com>
4675
4676         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4677         declare VEC.
4678         (solib_target_parse_libraries): Change return type.
4679         (library_list_start_segment, library_list_start_section)
4680         (library_list_end_library, library_list_start_library); Update.
4681         (solib_target_free_library_list): Remove.
4682         (solib_target_parse_libraries): Remove cleanup.  Change return
4683         type.
4684         (solib_target_current_sos): Update.
4685
4686 2019-01-17  Tom Tromey  <tromey@bapiya>
4687
4688         * valprint.c: Replace "the the" with "the".
4689         * symtab.c: Replace "the the" with "the".
4690         * solib.c: Replace "the the" with "the".
4691         * solib-dsbt.c: Replace "the the" with "the".
4692         * linespec.c: Replace "the the" with "the".
4693         * dwarf2loc.h: Replace "the the" with "the".
4694         * amd64-windows-tdep.c: Replace "the the" with "the".
4695         * aarch64-tdep.c: Replace "the the" with "the".
4696
4697 2019-01-16  Keith Seitz  <keiths@redhat.com>
4698
4699         PR gdb/23773
4700         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4701         <builder>: Rename to ..
4702         <m_builder>: ... this and make private.
4703         (dwarf2_cu::get_builder): New method.  Change all users of
4704         `builder' to use this method.
4705         (dwarf2_start_symtab): Move to ...
4706         (dwarf2_cu::start_symtab): ... here.  Update all callers
4707         (setup_type_unit_groups): Move to ...
4708         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4709         callers.
4710         (dwarf2_cu::reset_builder): New method.
4711         (process_full_compunit, process_full_type_unit): Use
4712         dwarf2_cu::reset_builder.
4713         (follow_die_offset): Record the ancestor CU if it is different
4714         from the followed DIE's CU.
4715         (follow_die_sig_1): Likewise.
4716
4717 2019-01-15  Tom Tromey  <tom@tromey.com>
4718
4719         * remote.c (class remote_state) <buf>: Now a char_vector.
4720         <buf_size>: Remove.
4721         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4722         parameter.
4723         (remote_target::getpkt_or_notif_sane_1)
4724         (remote_target::getpkt_sane)
4725         (remote_target::getpkt_or_notif_sane): Likewise.
4726         (class remote_target) <putpkt>: New overload.
4727         (remote_target::read_frame): Change type of "buf_p".  Remove
4728         sizeof_p parameter.
4729         (packet_ok): New overload.
4730         (packet_check_result): New overload.
4731         Update all uses.
4732
4733 2019-01-14  Tom Tromey  <tom@tromey.com>
4734
4735         * remote-notif.c (handle_notification, remote_notif_ack)
4736         (remote_notif_parse): Make "buf" const.
4737         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4738         const.
4739         (remote_notif_parse, remote_notif_ack, handle_notification):
4740         Likewise.
4741         * remote.c (remote_notif_stop_parse): Make "buf" const.
4742         (remote_target::remote_parse_stop_reply): Make "buf" const.
4743         (remote_notif_stop_ack): Make "buf" const.
4744
4745 2019-01-14  Tom Tromey  <tom@tromey.com>
4746
4747         * remote.c (remote_console_output): Make parameter const.
4748
4749 2019-01-14  Tom Tromey  <tom@tromey.com>
4750
4751         * target-debug.h (target_debug_print_signals): Constify.
4752         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4753         * procfs.c (procfs_target::pass_signals): Update.
4754         * linux-nat.c (linux_nat_target::pass_signals): Update.
4755         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4756         * target-delegates.c: Rebuild.
4757         * remote.c (remote_target::program_signals): Update.
4758         (remote_target::pass_signals): Update.
4759         * target.c (target_pass_signals): Constify argument.
4760         (target_program_signals): Likewise.
4761         * target.h (struct target_ops) <pass_signals, program_signals>:
4762         Constify argument.
4763         (target_pass_signals, target_program_signals): Constify argument.
4764
4765 2019-01-14  Tom Tromey  <tom@tromey.com>
4766
4767         PR tui/28819:
4768         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4769
4770 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4771
4772         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4773         field.
4774         * rs6000-tdep.c: Include reggroups.h.
4775         (IS_V_ALIAS_PSEUDOREG): Define.
4776         (rs6000_register_name): Return names for the "vX" aliases.
4777         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4778         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4779         aliases.  Call default_register_reggroup_p for all other
4780         pseudo-registers.
4781         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4782         New functions.
4783         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4784         Handle "vX" aliases.
4785         (v_alias_pseudo_register_collect): New function.
4786         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4787         (rs6000_gdbarch_init): Initialize "vX" aliases as
4788         pseudo-registers.  Restore registration of
4789         rs6000_pseudo_register_reggroup_p with
4790         set_tdesc_pseudo_register_reggroup_p.
4791
4792 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4793
4794         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4795         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4796         set_gdbarch_num_pseudo_regs.
4797
4798 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4799
4800         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4801         Remove arg prefixname, add do_set and do_show.
4802         Add member functions set_list and show_list.
4803         * cli/cli-style.c (class cli_style_option): Update accordingly.
4804         (style_set_list): Move to file scope.
4805         (style_show_list): Likewise.
4806         (set_style): Call help_list.
4807         (show_style): Call cmd_show_list.
4808         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4809         Update to use the new macro.
4810
4811 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4812
4813         * ada-lang.c (_initialize_ada_language): Expand the help text
4814         for the "catch exception" command.
4815
4816 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4817
4818         * symtab.c (matching_obj_sections): Initialize obj,
4819         declare it closer to its usage.
4820
4821 2019-01-10  Tom Tromey  <tom@tromey.com>
4822
4823         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4824         (basic_inf_threads_range): Remove.
4825         (inf_threads_range, inf_non_exited_threads_range)
4826         (safe_inf_threads_range): Use next_adapter.
4827
4828 2019-01-10  Keith Seitz  <keiths@redhat.com>
4829
4830         PR gdb/23712
4831         PR symtab/23010
4832         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4833         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4834
4835 2019-01-10  Keith Seitz  <keiths@redhat.com>
4836
4837         PR gdb/23712
4838         PR symtab/23010
4839         * dictionary.c (pending_to_vector): Remove.
4840         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4841         Remove _1 suffix, replacing functions of the same name.  Update
4842         all callers.
4843         (dict_create_hashed, dict_create_hashed_expandable)
4844         (dict_create_linear, dict_create_linear_expandable, dict_free)
4845         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4846         Make functions static.
4847
4848 2019-01-10  Keith Seitz  <keiths@redhat.com>
4849
4850         PR gdb/23712
4851         PR symtab/23010
4852         * dictionary.h (struct dictionary): Replace declaration with
4853         multidictionary.
4854         (dict_create_hashed, dict_create_hashed_expandable)
4855         (dict_create_linear, dict_create_linear_expandable)
4856         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4857         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4858         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4859         taking multidictionary argument.
4860         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4861         * block.h (struct block) <dict>: Change to multidictionary
4862         and rename `multidict'.
4863         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4864         symmisc.c: Update all dictionary references to multidictionary.
4865
4866 2019-01-10  Keith Seitz  <keiths@redhat.com>
4867
4868         PR gdb/23712
4869         PR symtab/23010
4870         * dictionary.c: Include unordered_map.
4871         (pending_to_vector): New function.
4872         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4873         Rewrite the non-"_1" functions to take vector instead
4874         of linked list.
4875         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4876         "new" _1 versions of the same name.
4877         (multidictionary): Define.
4878         (std::hash<enum language): New definition.
4879         (collate_pending_symbols_by_language, mdict_create_hashed)
4880         (mdict_create_hashed_expandable, mdict_create_linear)
4881         (mdict_create_linear_expandable, mdict_free)
4882         (find_language_dictionary, create_new_language_dictionary)
4883         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4884         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4885         (mdict_size, mdict_empty): New functions.
4886         * dictionary.h (mdict_iterator): Define.
4887
4888 2019-01-10  Pedro Alves  <palves@redhat.com>
4889
4890         * breakpoint.c (read_uploaded_action)
4891         (create_tracepoint_from_upload): Adjust to use
4892         gdb::unique_xmalloc_ptr.
4893         * ctf.c (ctf_write_uploaded_tp):
4894         (SET_ARRAY_FIELD): Use emplace_back.
4895         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4896         * tracefile-tfile.c (tfile_write_uploaded_tp):
4897         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4898         gdb::unique_xmalloc_ptr.
4899         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4900         at_string, cond_string, cmd_strings>: Replace char pointers
4901         with gdb::unique_xmalloc_ptr.
4902
4903 2019-01-10  Pedro Alves  <palves@redhat.com>
4904
4905         * solib-target.c (library_list_start_library): Don't xstrdup name.
4906
4907 2019-01-10  Pedro Alves  <palves@redhat.com>
4908
4909         * mdebugread.c (parse_partial_symbols): Use
4910         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4911
4912 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4913
4914         * linux-fork.c (scoped_switch_fork_info)
4915         <~scoped_switch_fork_info>: Fix incorrect variable name.
4916
4917 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4918
4919         * linux-fork.c (scoped_switch_fork_info)
4920         <scoped_switch_fork_info>: Make explicit.
4921         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4922
4923 2019-01-10  Tom Tromey  <tom@tromey.com>
4924
4925         * objfiles.h (objfile::reset_psymtabs): Update.
4926         * objfiles.c (objfile::objfile): Update.
4927         * psymtab.h (psymtab_storage::obstack): Update.
4928         (psymtab_storage::m_obstack): Use gdb::optional.
4929         (class psymtab_storage): Update comment.  Remove objfile
4930         parameter.
4931         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4932
4933 2019-01-10  Tom Tromey  <tom@tromey.com>
4934
4935         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4936         <free_psymtabs>: Now private.
4937         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4938         (allocate_psymtab): Use new method.
4939
4940 2019-01-10  Tom Tromey  <tom@tromey.com>
4941
4942         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4943         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4944         * mdebugread.c (parse_partial_symbols): Use
4945         allocate_dependencies.
4946         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4947         allocate_dependencies.
4948         (process_psymtab_comp_unit_reader)
4949         (build_type_psymtab_dependencies): Likewise.
4950         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4951
4952 2019-01-10  Tom Tromey  <tom@tromey.com>
4953
4954         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4955         PSYMBOL_SET_LANGUAGE.
4956         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4957
4958 2019-01-10  Tom Tromey  <tom@tromey.com>
4959
4960         * psymtab.h (psymtab_storage::obstack): New method.
4961         <m_obstack>: Rename from obstack; now private.
4962         * psymtab.c (psymtab_storage): Update.
4963         * dwarf2read.c (create_addrmap_from_index)
4964         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4965         Update.
4966
4967 2019-01-10  Tom Tromey  <tom@tromey.com>
4968
4969         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4970         * objfiles.h (objfile::reset_psymtabs): New method.
4971
4972 2019-01-10  Tom Tromey  <tom@tromey.com>
4973
4974         * symmisc.c (print_symbol_bcache_statistics): Update.
4975         (print_objfile_statistics): Update.
4976         * symfile.c (reread_symbols): Update.
4977         * psymtab.h (class psymtab_storage): New.
4978         * psymtab.c (psymtab_storage): New constructor.
4979         (~psymtab_storage): New destructor.
4980         (require_partial_symbols): Update.
4981         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4982         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4983         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4984         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4985         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4986         (start_psymtab_common, end_psymtab_common)
4987         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4988         (allocate_psymtab): Update.
4989         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4990         Update.
4991         (dump_psymtab_addrmap, maintenance_print_psymbols)
4992         (maintenance_check_psymtabs): Update.
4993         (class objfile_psymtabs): Move to objfiles.h.
4994         * psympriv.h (discard_psymtab): Now inline.
4995         (psymtab_discarder::psymtab_discarder): Update.
4996         (psymtab_discarder::~psymtab_discarder): Update.
4997         (ALL_OBJFILE_PSYMTABS): Rewrite.
4998         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4999         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5000         Remove fields.
5001         <partial_symtabs>: New field.
5002         (class objfile_psymtabs): Move from psymtab.h.  Update.
5003         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5004         psymbol_cache.
5005         (objfile::~objfile): Don't destroy psymbol_cache.
5006         * mdebugread.c (parse_partial_symbols): Update.
5007         * dwarf2read.c (create_addrmap_from_index)
5008         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5009         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5010         (add_partial_subprogram, dwarf2_ranges_read): Update.
5011         * dwarf-index-write.c (write_address_map)
5012         (write_one_signatured_type, recursively_write_psymbols)
5013         (class debug_names, class debug_names, write_psymtabs_to_index):
5014         Update.
5015
5016 2019-01-10  Tom Tromey  <tom@tromey.com>
5017
5018         * symtab.h (SYMBOL_SET_NAMES): Update.
5019         (symbol_set_names): Update.
5020         (MSYMBOL_SET_NAMES): Update.
5021         * symtab.c (symbol_set_names): Change argument to be an
5022         objfile_per_bfd_storage.
5023         * psymtab.c (add_psymbol_to_bcache): Update.
5024         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5025
5026 2019-01-10  Tom Tromey  <tom@tromey.com>
5027
5028         * symtab.c (create_demangled_names_hash): Change argument to be an
5029         objfile_per_bfd_storage.
5030         (symbol_set_names): Update.
5031
5032 2019-01-10  Tom Tromey  <tom@tromey.com>
5033
5034         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5035         init_psymbol_list.
5036         * psymtab.c (init_psymbol_list): Do nothing if already called.
5037         * psympriv.h (init_psymbol_list): Add comment.
5038         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5039         init_psymbol_list.
5040         * dbxread.c (dbx_symfile_read): Unconditionally call
5041         init_psymbol_list.
5042
5043 2019-01-10  Tom Tromey  <tom@tromey.com>
5044
5045         * xcoffread.c (scan_xcoff_symtab): Update.
5046         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5047         "where".
5048         * mdebugread.c (parse_partial_symbols)
5049         (handle_psymbol_enumerators): Update.
5050         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5051         * dbxread.c (read_dbx_symtab): Update.
5052         * psympriv.h (psymbol_placement): New enum.
5053         (add_psymbol_to_list): Update.
5054
5055 2019-01-10  Tom Tromey  <tom@tromey.com>
5056
5057         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5058         static_psymbols parameters.
5059         (scan_xcoff_symtab): Update.
5060         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5061         static_psymbols parameters.
5062         * psympriv.h (start_psymtab_common): Update.
5063         * mdebugread.c (parse_partial_symbols): Update.
5064         * dwarf2read.c (create_partial_symtab): Update.
5065         * dbxread.c (read_dbx_symtab): Update.
5066         (start_psymtab): Remove global_psymbols and static_psymbols
5067         parameters.
5068
5069 2019-01-10  Tom Tromey  <tom@tromey.com>
5070
5071         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5072         * psymtab.c (allocate_psymtab): Add comment.
5073         * psympriv.h (allocate_psymtab): Add comment.
5074         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5075         initializations.
5076         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5077
5078 2019-01-10  Tom Tromey  <tom@tromey.com>
5079
5080         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5081         Don't declare.
5082         * mipsread.c: Include mdebugread.h.
5083         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5084         Declare.
5085         * elfread.c: Include mdebugread.h.
5086
5087 2019-01-09  Tom Tromey  <tom@tromey.com>
5088
5089         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5090         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5091         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5092         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5093         (psym_lookup_symbol, psym_find_last_source_symtab)
5094         (psym_forget_cached_source_info, psym_print_stats)
5095         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5096         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5097         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5098         (psym_find_compunit_symtab_by_address)
5099         (maintenance_print_psymbols, maintenance_info_psymtabs)
5100         (maintenance_check_psymtabs): Use ranged for.
5101         * psymtab.h (class objfile_psymtabs): New.
5102         (require_partial_symbols): Return objfile_psymtabs.
5103         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5104
5105 2019-01-09  Tom Tromey  <tom@tromey.com>
5106
5107         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5108         (find_pc_mapped_section, list_overlays_command)
5109         (map_overlay_command, unmap_overlay_command)
5110         (simple_overlay_update): Use all_objfiles.
5111         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5112         * printcmd.c (info_symbol_command): Use all_objfiles.
5113         * objfiles.h (ALL_OBJSECTIONS): Remove.
5114         * maint.c (maintenance_translate_address): Use all_objfiles.
5115         * gcore.c (gcore_create_callback): Use all_objfiles.
5116         (objfile_find_memory_regions): Likewise.
5117
5118 2019-01-09  Tom Tromey  <tom@tromey.com>
5119
5120         * symtab.c (find_line_symtab, info_sources_command)
5121         (make_source_files_completion_list): Use objfile_compunits.
5122         * source.c (select_source_symtab): Use objfile_compunits.
5123         * objfiles.h (struct objfile): Update comment.
5124         (ALL_OBJFILES): Remove.
5125         (ALL_FILETABS): Remove.
5126         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5127         objfile_compunits.
5128
5129 2019-01-09  Tom Tromey  <tom@tromey.com>
5130
5131         * symmisc.c (print_objfile_statistics, dump_objfile)
5132         (maintenance_print_symbols): Use compunit_filetabs.
5133         * source.c (forget_cached_source_info_for_objfile): Use
5134         compunit_filetabs.
5135         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5136         (ALL_FILETABS): Use compunit_filetabs.
5137         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5138         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5139
5140 2019-01-09  Tom Tromey  <tom@tromey.com>
5141
5142         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5143         (compunit_filetabs): New.
5144         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5145         compunit_filetabs.
5146         (info_sources_command, make_source_files_completion_list): Remove
5147         declaration.
5148         * symmisc.c (print_objfile_statistics, dump_objfile)
5149         (maintenance_print_symbols): Remove declaration.
5150         (maintenance_info_symtabs): Use compunit_filetabs.
5151         (maintenance_info_line_tables): Likewise.
5152         * source.c (select_source_symtab): Change local variable name.
5153         (forget_cached_source_info_for_objfile): Remove declaration.
5154         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5155         * objfiles.c (objfile_relocate1): Remove declaration.
5156         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5157         declaration.
5158         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5159         * coffread.c (coff_symtab_read): Remove declaration.
5160         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5161         compunit_filetabs.
5162
5163 2019-01-09  Tom Tromey  <tom@tromey.com>
5164
5165         * symtab.c (lookup_objfile_from_block)
5166         (find_pc_sect_compunit_symtab, search_symbols)
5167         (default_collect_symbol_completion_matches_break_on): Use
5168         objfile_compunits.
5169         * objfiles.h (ALL_COMPUNITS): Remove.
5170         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5171         * cp-support.c (add_symbol_overload_list_qualified): Use
5172         objfile_compunits.
5173         * ada-lang.c (ada_collect_symbol_completion_matches)
5174         (ada_add_global_exceptions): Use objfile_compunits.
5175
5176 2019-01-09  Tom Tromey  <tom@tromey.com>
5177
5178         * source.c (select_source_symtab)
5179         (forget_cached_source_info_for_objfile): Remove declaration.
5180         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5181         declaration.
5182         * maint.c (count_symtabs_and_blocks): Remove declaration.
5183         * cp-support.c (add_symbol_overload_list_qualified): Remove
5184         declaration.
5185         * coffread.c (coff_symtab_read): Remove declaration.
5186         * symtab.c (lookup_symbol_in_objfile_symtabs)
5187         (basic_lookup_transparent_type_1): Use objfile_compunits.
5188         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5189         (info_sources_command, search_symbols)
5190         (default_collect_symbol_completion_matches_break_on)
5191         (make_source_files_completion_list): Remove declaration.
5192         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5193         (ada_collect_symbol_completion_matches)
5194         (ada_add_global_exceptions): Remove declaration.
5195         * linespec.c (iterate_over_all_matching_symtabs): Use
5196         objfile_compunits.
5197         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5198         (class objfile_compunits): New.
5199         (ALL_COMPUNITS): Use objfile_compunits.
5200         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5201         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5202         objfile_compunits.
5203         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5204
5205 2019-01-09  Tom Tromey  <tom@tromey.com>
5206
5207         * symtab.c (search_symbols)
5208         (default_collect_symbol_completion_matches_break_on): Use
5209         objfile_msymbols.
5210         * ada-lang.c (ada_lookup_simple_minsym)
5211         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5212         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5213         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5214         objfile_msymbols.
5215         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5216         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5217         * objc-lang.c (find_methods): Use objfile_msymbols.
5218         (info_selectors_command, info_classes_command): Likewise.
5219         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5220         * objfiles.h (class objfile_msymbols): New.
5221         (ALL_OBJFILE_MSYMBOLS): Remove.
5222         (ALL_MSYMBOLS): Remove.
5223
5224 2019-01-09  Tom Tromey  <tom@tromey.com>
5225
5226         * common/next-iterator.h (next_adapter): Add Iterator template
5227         parameter.
5228         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5229         (class all_objfiles_safe): New.
5230         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5231         * objfiles.c (put_objfile_before): Update comment.
5232         (add_separate_debug_objfile): Likewise.
5233         (free_all_objfiles): Use all_objfiles_safe.
5234         (objfile_purge_solibs): Likewise.
5235
5236 2019-01-09  Tom Tromey  <tom@tromey.com>
5237
5238         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5239         (expand_symtab_containing_pc, lookup_static_symbol)
5240         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5241         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5242         all_objfiles.
5243         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5244         * breakpoint.c (create_overlay_event_breakpoint)
5245         (create_longjmp_master_breakpoint)
5246         (create_std_terminate_master_breakpoint)
5247         (create_exception_master_breakpoint): Use all_objfiles.
5248         * linux-thread-db.c (try_thread_db_load_from_pdir)
5249         (has_libpthread): Use all_objfiles.
5250         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5251         * linespec.c (iterate_over_all_matching_symtabs)
5252         (search_minsyms_for_name): Use all_objfiles.
5253         * maint.c (maintenance_info_sections): Use all_objfiles.
5254         * main.c (captured_main_1): Use all_objfiles.
5255         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5256         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5257         * guile/scm-pretty-print.c
5258         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5259         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5260         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5261         (maintenance_print_msymbols): Use all_objfiles.
5262         * source.c (select_source_symtab): Use all_objfiles.
5263         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5264         * symfile.c (remove_symbol_file_command)
5265         (expand_symtabs_matching, map_symbol_filenames): Use
5266         all_objfiles.
5267         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5268         all_objfiles.
5269         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5270         * objc-lang.c (find_methods): Use all_objfiles.
5271         * objfiles.c (have_partial_symbols, have_full_symbols)
5272         (have_minimal_symbols, qsort_cmp)
5273         (default_iterate_over_objfiles_in_search_order): Use
5274         all_objfiles.
5275         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5276         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5277         (maintenance_check_psymtabs): Use all_objfiles.
5278         (ALL_PSYMTABS): Remove.
5279         * compile/compile-object-run.c (do_module_cleanup): Use
5280         all_objfiles.
5281         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5282         * cp-support.c (add_symbol_overload_list_qualified): Use
5283         all_objfiles.
5284         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5285         Use all_objfiles.
5286         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5287         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5288         all_objfiles.
5289         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5290         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5291         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5292         Uses all_objfiles.
5293         * solib.c (solib_read_symbols): Use all_objfiles
5294
5295 2019-01-09  Tom Tromey  <tom@tromey.com>
5296
5297         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5298         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5299         all_objfiles.
5300         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5301         * symmisc.c (print_symbol_bcache_statistics)
5302         (print_objfile_statistics, maintenance_print_objfiles)
5303         (maintenance_info_symtabs, maintenance_check_symtabs)
5304         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5305         all_objfiles.
5306         * source.c (forget_cached_source_info): Use all_objfiles.
5307         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5308         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5309         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5310         * objfiles.c (update_section_map): Use all_objfiles.
5311         (shared_objfile_contains_address_p): Likewise.
5312         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5313         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5314
5315 2019-01-09  Tom Tromey  <tom@tromey.com>
5316
5317         * common/next-iterator.h: New file.
5318         * objfiles.h (class all_objfiles): New.
5319         (struct objfile_iterator): New.
5320
5321 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5322
5323         * NEWS: Move the description of the changed "frame", "select-frame",
5324          and "info frame" commands to the Changed commands section.
5325
5326 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5327
5328         * gdbtypes.c (check_stub_method_group): Remove handling of old
5329         mangling schemes.
5330         * linespec.c (find_methods): Likewise.
5331         * stabsread.c (read_member_functions): Likewise.
5332         * valops.c (search_struct_method): Likewise.
5333         (value_struct_elt_for_reference): Likewise.
5334         * NEWS: Mention this change.
5335
5336 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5339         print_source_lines.
5340         * source.c (print_source_lines_base): Update line number check.
5341         (print_source_lines): New function.
5342         (source_lines_range::source_lines_range): New function.
5343         * source.h (class source_lines_range): New class.
5344         (print_source_lines): New declaration.
5345
5346 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5347
5348         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5349
5350 2019-01-08  Tom Tromey  <tom@tromey.com>
5351             Simon Marchi  <simon.marchi@ericsson.com>
5352
5353         PR gdb/24060
5354         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5355         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5356         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5357         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5358         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5359         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5360
5361 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5362
5363         * source.c (select_source_symtab): Move header comment to
5364         declaration in source.h.
5365         (forget_cached_source_info_for_objfile): Likewise.
5366         (forget_cached_source_info): Likewise.
5367         (identify_source_line): Likewise.
5368         * source.h (identify_source_line): Move declaration from symtab.h
5369         and add comment from source.c
5370         (print_source_lines): Likewise.
5371         (forget_cached_source_info_for_objfile): Likewise.
5372         (forget_cached_source_info): Likewise.
5373         (select_source_symtab): Likewise.
5374         (enum print_source_lines_flag): Move definition from symtab.h.
5375         * symtab.h (identify_source_line): Move declaration to source.h.
5376         (print_source_lines): Likewise.
5377         (forget_cached_source_info_for_objfile): Likewise.
5378         (forget_cached_source_info): Likewise.
5379         (select_source_symtab): Likewise.
5380         (enum print_source_lines_flag): Move definition to source.h.
5381         * tui/tui-hooks.c: Add 'source.h' include.
5382
5383 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5384
5385         * source.c (print_source_lines_base): Handle requests to print
5386         reverse line number sequences, and guard against empty lines
5387         string.
5388
5389 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * source.c (print_source_lines_base): Fix skip of '\r' if next
5392         character is '\n'.
5393
5394 2019-01-06  Tom Tromey  <tom@tromey.com>
5395
5396         * c-exp.y (struct c_parse_state) <macro_original_text,
5397         expansion_obstack>: New member.
5398         (macro_original_text, expansion_obstack): Remove globals.
5399         (scan_macro_expansion, scanning_macro_expansion)
5400         (finished_macro_expansion): Update.
5401         (scan_macro_cleanup): Remove.
5402         (yylex, c_parse): Update.
5403
5404 2019-01-06  Tom Tromey  <tom@tromey.com>
5405
5406         * c-exp.y (struct c_parse_state) <strings>: New member.
5407         (operator_stoken): Update.
5408
5409 2019-01-06  Tom Tromey  <tom@tromey.com>
5410
5411         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5412         (union type_stack_elt) <typelist_val>: Now a pointer to
5413         std::vector.
5414         (type_stack_cleanup): Don't declare.
5415         (push_typelist): Update.
5416         * parse.c (pop_typelist): Return a std::vector.
5417         (push_typelist): Take a std::vector.
5418         (follow_types): Update.  Do not free args.
5419         (type_stack_cleanup): Remove.
5420         * c-exp.y (struct c_parse_state): New.
5421         (cpstate): New global.
5422         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5423         (nonempty_typelist): Update.
5424         (func_mod): Create a new vector.
5425         (c_parse): Create a c_parse_state.
5426         (check_parameter_typelist): Do not delete params.
5427         (function_method): Update.  Do not delete type_list.
5428
5429 2019-01-06  Tom Tromey  <tom@tromey.com>
5430
5431         PR gdb/28155:
5432         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5433         check_typedef.
5434         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5435         (print_return_value): Likewise.
5436
5437 2019-01-05  Tom Tromey  <tom@tromey.com>
5438
5439         * contrib/cleanup_check.py: Remove.
5440         * contrib/gcc-with-excheck: Remove.
5441         * contrib/exsummary.py: Remove.
5442         * contrib/excheck.py: Remove.
5443
5444 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5445
5446         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5447         NULL. Initialize tpprev to NULL instead of assigning it
5448         to NULL on the next statement.
5449         * windows-nat.c (windows_delete_thread): Remove check for
5450         main_thread_id before printing thread exit notifications.
5451         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5452         Remove thread ID check against main_thread_id.
5453         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5454         windows_delete_thread.
5455         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5456
5457 2019-01-04  Tom Tromey  <tom@tromey.com>
5458
5459         * compile/compile.c (_initialize_compile): Use upper case for
5460         metasyntactic variables.
5461         * symmisc.c (_initialize_symmisc): Use upper case for
5462         metasyntactic variables.
5463         * psymtab.c (_initialize_psymtab): Use upper case for
5464         metasyntactic variables.
5465         * demangle.c (demangle_command): Use upper case for metasyntactic
5466         variables.
5467         (_initialize_demangler): Likewise.
5468         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5469         variables.
5470
5471 2019-01-03  Tom Tromey  <tom@tromey.com>
5472
5473         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5474
5475 2019-01-03  Tom Tromey  <tom@tromey.com>
5476
5477         * python/py-symtab.c (salpy_str): Update.
5478         (struct salpy_sal_object) <symtab>: Now a PyObject.
5479         (salpy_dealloc): Update.
5480         (del_objfile_sal): Use gdbpy_ref.
5481
5482 2019-01-03  Tom Tromey  <tom@tromey.com>
5483
5484         * python/py-type.c (convert_field): Use new_reference.  Return
5485         gdbpy_ref.
5486         (make_fielditem): Return gdbpy_ref.
5487         (typy_fields): Update.
5488         (typy_getitem): Update.
5489         (field_name): Return gdbpy_ref.  Use new_reference.
5490         (typy_iterator_iternext): Update.
5491
5492 2019-01-03  Tom Tromey  <tom@tromey.com>
5493
5494         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5495
5496 2019-01-03  Tom Tromey  <tom@tromey.com>
5497
5498         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5499         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5500         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5501         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5502         (pspy_set_type_printers): Likewise.
5503         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5504         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5505         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5506         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5507         (objfpy_set_type_printers): Likewise.
5508
5509 2019-01-03  Tom Tromey  <tom@tromey.com>
5510
5511         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5512         (gdbpy_print_stack): Use gdbpy_err_fetch.
5513         * python/python-internal.h (class gdbpy_err_fetch): New class.
5514         (class gdbpy_enter) <m_error_type, m_error_value,
5515         m_error_traceback>: Remove.
5516         <m_error>: New member.
5517         (gdbpy_exception_to_string): Don't declare.
5518         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5519         * python/py-value.c (convert_value_from_python): Use
5520         gdbpy_err_fetch.
5521         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5522         gdbpy_exception_to_string.
5523         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5524         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5525         gdbpy_err_fetch.
5526
5527 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5528
5529         * linux-nat.c (delete_lwp_cleanup): Delete.
5530         (struct lwp_deleter): New struct.
5531         (lwp_info_up): New typedef.
5532         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5533         lwp_info_up.
5534
5535 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5536
5537         * linux-fork.c (class scoped_switch_fork_info): New class.
5538         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5539
5540 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5541
5542         * valops.c (find_overload_match): Remove use of null_cleanup, and
5543         calls to do_cleanups.
5544
5545 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5546
5547         * compile/compile-cplus-types.c
5548         (compile_cplus_instance::decl_name): Handle changes to
5549         cp_func_name.
5550         * cp-support.c (cp_func_name): Update header comment, update
5551         return type.
5552         * cp-support.h (cp_func_name): Update return type in declaration.
5553         * valops.c (find_overload_match): Move temp_func local to top
5554         level of function and change its type.  Use temp_func to hold and
5555         delete temporary string obtained from cp_func_name.
5556
5557 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5558
5559         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5560         gdb::char_vector, remove cleanup, and update uses of `msg`.
5561
5562 2019-01-03  Jim Wilson  <jimw@sifive.com>
5563
5564         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5565
5566 2019-01-02  Tom Tromey  <tom@tromey.com>
5567
5568         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5569         (tdesc_parse_xml): Remove cleanups.
5570         * target-descriptions.h (make_cleanup_free_target_description):
5571         Don't declare.
5572         (target_desc_deleter): New struct.
5573         (target_desc_up): New typedef.
5574         * target-descriptions.c (target_desc_deleter::operator()): Rename
5575         from free_target_description.
5576         (make_cleanup_free_target_description): Remove.
5577
5578 2019-01-02  Tom Tromey  <tom@tromey.com>
5579
5580         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5581         constructor, destructor.
5582         (linespec_parser): Remove typedef.
5583         (~linespec_parser): Rename from linespec_parser_delete.
5584         (linespec_lex_to_end, linespec_complete_label)
5585         (linespec_complete): Update.
5586         (decode_line_full): Remove cleanups.
5587         (decode_line_1): Update.
5588
5589 2019-01-02  Tom Tromey  <tom@tromey.com>
5590
5591         * python/python-internal.h (inferior_to_inferior_object): Change
5592         return type.
5593         * python/py-exitedevent.c (create_exited_event_object): Update.
5594         * python/py-inferior.c (inferior_to_inferior_object): Return
5595         gdbpy_ref.
5596         (python_new_inferior, python_inferior_deleted)
5597         (thread_to_thread_object, delete_thread_object)
5598         (build_inferior_list, gdbpy_selected_inferior): Update.
5599         * python/py-infthread.c (create_thread_object): Update.  Also fail
5600         if inferior_to_inferior_object fails.
5601
5602 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5603
5604         * inferior.h (class inferior) <displaced_step_state>: New field.
5605         * infrun.h (struct displaced_step_state): Move here from
5606         infrun.c.  Initialize fields, add constructor.
5607         <inf>: Remove field.
5608         <reset>: New method.
5609         * infrun.c (struct displaced_step_inferior_state): Move to
5610         infrun.h.
5611         (displaced_step_inferior_states): Remove.
5612         (get_displaced_stepping_state): Adust.
5613         (displaced_step_in_progress_any_inferior): Adjust.
5614         (displaced_step_in_progress_thread): Adjust.
5615         (displaced_step_in_progress): Adjust.
5616         (add_displaced_stepping_state): Remove.
5617         (get_displaced_step_closure_by_addr): Adjust.
5618         (remove_displaced_stepping_state): Remove.
5619         (infrun_inferior_exit): Call displaced_step_state.reset.
5620         (use_displaced_stepping): Don't check for NULL.
5621         (displaced_step_prepare_throw): Call
5622         get_displaced_stepping_state.
5623         (displaced_step_fixup): Don't check for NULL.
5624         (prepare_for_detach): Don't check for NULL.
5625
5626 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5627
5628         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5629          in case of call that did not complete.
5630
5631 2019-01-02  Andrey Utkin  <autkin@undo.io>
5632
5633         * symfile.c (find_separate_debug_file): Fix search of debug files for
5634         remote debuggee.
5635
5636 2019-01-02  Tom Tromey  <tom@tromey.com>
5637
5638         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5639         indentation.
5640         * python/py-frame.c (frapy_older): Remove cast.
5641         (frapy_newer): Likewise.
5642         * python/py-breakpoint.c (local_setattro): Remove cast.
5643         * python/py-arch.c (archpy_name): Remove local variable.
5644         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5645
5646 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5647
5648         * unittests/basic_string_view/element_access/char/empty.cc:
5649         Fix year range in copyright header.
5650
5651 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5652
5653         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5654         Delete.
5655         <operator==>: Update with for removed field.
5656         <hash>: Likewise.
5657         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5658         <isa_features>: ...this.
5659         <abi_features>: New field.
5660         (riscv_isa_flen): Update comment.
5661         (riscv_abi_xlen): New declaration.
5662         (riscv_abi_flen): New declaration.
5663         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5664         isa_features.
5665         (riscv_abi_xlen): New function.
5666         (riscv_isa_flen): Update to get answer from isa_features.
5667         (riscv_abi_flen): New function.
5668         (riscv_has_fp_abi): Update to get answer from abi_features.
5669         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5670         xlen and flen.
5671         (riscv_call_info) <xlen, flen>: Update comment.
5672         (riscv_call_arg_struct): Remove invalid assertions
5673         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5674         is removed.
5675         (riscv_gdbarch_init): Gather isa features and abi features
5676         separately, ensure both match on the gdbarch when reusing an old
5677         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5678         a target with 64-bit float hardware.
5679
5680 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5681
5682         * source.c (search_command_helper): Stop reverse search
5683         when line 1 has been searched.
5684
5685 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5686
5687         * record-full.c (record_full_base_target::close): Rewrite
5688         record_full_core_buf_list free logic.
5689
5690 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5691
5692         * break-catch-syscall.c (print_one_catch_syscall): xfree
5693         the last text.
5694
5695 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5696
5697         * top.c (print_gdb_version): Update Copyright year in version
5698         message.
5699
5700 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5701
5702         Update copyright year range in all GDB files.
5703
5704 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5705
5706         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5707
5708 For older changes see ChangeLog-2018.
5709 \f
5710 Local Variables:
5711 mode: change-log
5712 left-margin: 8
5713 fill-column: 74
5714 version-control: never
5715 coding: utf-8
5716 End:
5717