be4e883bfdcfc1739bfee239848056629b529b39
[external/binutils.git] / gdb / ChangeLog
1 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2
3         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4         from...
5         (rank_one_type): ... this.
6
7 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8
9         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10         from...
11         (rank_one_type): ... this.
12
13 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14
15         * gdbtypes.c (rank_one_type_parm_func): New function extracted
16         from...
17         (rank_one_type): ... this.
18
19 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
20
21         * gdbtypes.c (rank_one_type_parm_array): New function extracted
22         from...
23         (rank_one_type): ... this.
24
25 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
26
27         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
28         from...
29         (rank_one_type): ... this.
30
31 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
32
33         * inferior.c (initialize_inferiors): Ensure 'help set/show print
34         inferior-events' shows the example events.
35
36 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
37
38         Support styling on native MS-Windows console
39
40         PR/24315
41         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
42         on MS-Windows if $TERM is not defined.
43
44         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
45
46         * posix-hdep.c (gdb_console_fputs):
47         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
48         functions.
49         * ui-file.h (gdb_console_fputs): Add prototype.
50
51         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
52         back to fputs only if the former returns zero.
53
54 2019-03-07  Tom Tromey  <tom@tromey.com>
55
56         * symmisc.c (print_symbol_bcache_statistics): Update.
57         (print_objfile_statistics): Update.
58         * symfile.c (allocate_symtab): Update.
59         * stabsread.c: Don't include bcache.h.
60         * psymtab.h (struct psymbol_bcache): Don't declare.
61         (class psymtab_storage) <psymbol_cache>: Now a bcache.
62         (psymbol_bcache_init, psymbol_bcache_free)
63         (psymbol_bcache_get_bcache): Don't declare.
64         * psymtab.c (struct psymbol_bcache): Remove.
65         (psymtab_storage::psymtab_storage): Update.
66         (psymtab_storage::~psymtab_storage): Update.
67         (psymbol_bcache_init, psymbol_bcache_free)
68         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
69         (add_psymbol_to_bcache): Update.
70         (allocate_psymtab): Update.
71         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
72         macro_cache>: No longer pointers.
73         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
74         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
75         * macrotab.c (macro_bcache): Update.
76         * macroexp.c: Don't include bcache.h.
77         * gdbtypes.c (check_types_worklist): Update.
78         (types_deeply_equal): Remove TRY/CATCH.  Update.
79         * elfread.c (elf_symtab_read): Update.
80         * dwarf2read.c: Don't include bcache.h.
81         * buildsym.c (buildsym_compunit::get_macro_table): Update.
82         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
83         (print_bcache_statistics, bcache_memory_used): Don't declare.
84         (struct bcache): Move from bcache.c.  Add constructor, destructor,
85         methods.  Rename all data members.
86         * bcache.c (struct bcache): Move to bcache.h.
87         (bcache::expand_hash_table): Rename from expand_hash_table.
88         (bcache): Remove.
89         (bcache::insert): Rename from bcache_full.
90         (bcache::compare): Rename from bcache_compare.
91         (bcache_xmalloc): Remove.
92         (bcache::~bcache): Rename from bcache_xfree.
93         (bcache::print_statistics): Rename from print_bcache_statistics.
94         (bcache::memory_used): Rename from bcache_memory_used.
95
96 2019-03-07  Pedro Alves  <palves@redhat.com>
97
98         * infrun.c (normal_stop): Also check for
99         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
100
101 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
102
103         * f-lang.c (value_from_host_double): Moved to...
104         * value.c (value_from_host_double): ...here.
105         * value.h (value_from_host_double): Declare.
106         * guile/scm-math.c (vlscm_convert_typed_number): Use
107         value_from_host_double.
108         (vlscm_convert_number): Likewise.
109         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
110         * python/py-value.c (convert_value_from_python): Likewise.
111
112 2019-03-06  Tom Tromey  <tom@tromey.com>
113
114         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
115
116 2019-03-06  Tom Tromey  <tom@tromey.com>
117
118         * utils.h (free_current_contents): Don't declare.
119         * utils.c (free_current_contents): Remove.
120
121 2019-03-06  Tom Tromey  <tom@tromey.com>
122
123         * top.c (quit_force): Update.
124         * main.c (captured_command_loop): Update.
125         * common/new-op.c (operator new): Update.
126         * common/common-exceptions.c (struct catcher)
127         <save_cleanup_chain>: Remove member.
128         (exceptions_state_mc_init): Update.
129         (exception_try_scope_entry): Return nullptr.
130         (exception_try_scope_exit, exception_rethrow)
131         (throw_exception_sjlj, throw_exception_cxx): Update.
132         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
133         (all_cleanups, do_cleanups, discard_cleanups)
134         (discard_final_cleanups, save_cleanups, save_final_cleanups)
135         (restore_cleanups, restore_final_cleanups): Don't declare.
136         (do_final_cleanups): Remove parameter.
137         * common/cleanups.c (cleanup_chain, make_cleanup)
138         (make_cleanup_dtor, all_cleanups, do_cleanups)
139         (discard_my_cleanups, discard_cleanups)
140         (discard_final_cleanups, save_my_cleanups, save_cleanups)
141         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
142         (null_cleanup): Remove.
143         (do_final_cleanups): Remove parameter.
144
145 2019-03-06  Tom Tromey  <tom@tromey.com>
146
147         * remote.c (remote_target::remote_parse_stop_reply): Use
148         unique_xmalloc_ptr.
149
150 2019-03-06  Tom Tromey  <tom@tromey.com>
151
152         * stabsread.c (struct stabs_field_info): Rename from field_info.
153         <list, fnlist>: Add initializers.
154         <obstack>: New member.
155         (read_member_functions, read_struct_fields, read_baseclasses):
156         Allocate on obstack.  Don't use cleanups.
157         (read_one_struct_field, read_member_functions, read_struct_fields)
158         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
159         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
160         (read_struct_type): Update.
161
162 2019-03-06  Tom Tromey  <tom@tromey.com>
163
164         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
165         * common/filestuff.h (make_cleanup_close): Don't declare.
166         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
167         Remove.
168
169 2019-03-06  Tom Tromey  <tom@tromey.com>
170
171         * solib-aix.c: Use make_scope_exit.
172
173 2019-03-06  Tom Tromey  <tom@tromey.com>
174
175         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
176         Use make_scope_exit.
177
178 2019-03-06  Tom Tromey  <tom@tromey.com>
179
180         * solib-svr4.c (disable_probes_interface): Remove parameter.
181         (svr4_handle_solib_event): Use make_scope_exit.
182
183 2019-03-06  Tom Tromey  <tom@tromey.com>
184
185         * remote.c (struct stop_reply_deleter): Remove.
186         (stop_reply_up): Update.
187         (struct stop_reply): Derive from notif_event.  Don't typedef.
188         <regcache>: Now a std::vector.
189         (stop_reply_xfree): Remove.
190         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
191         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
192         (remote_target::discard_pending_stop_replies): Use delete.
193         (remote_target::remote_parse_stop_reply): Update.
194         (remote_target::process_stop_reply): Update.
195         * remote-notif.h (struct notif_event): Add virtual destructor.
196         Remove "dtr" member.
197         (struct notif_client) <alloc_event>: Return a unique_ptr.
198         (notif_event_xfree): Don't declare.
199         (notif_event_up): New typedef.
200         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
201         (notif_event_xfree, do_notif_event_xfree): Remove.
202         (remote_notif_state_xfree): Update.
203
204 2019-03-06  Tom Tromey  <tom@tromey.com>
205
206         * infrun.c (displaced_step_clear_cleanup): Now a
207         forward_scope_exit type.
208         (displaced_step_prepare_throw): Update.
209         (displaced_step_fixup): Update.
210
211 2019-03-06  Tom Tromey  <tom@tromey.com>
212
213         * inferior.h (class inferior): Update comment.
214         * gdbthread.h (class thread_info): Update comment.
215
216 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
217             Tom Tromey  <tom@tromey.com>
218
219         * stabsread.h (struct stab_section_list): Remove.
220         (coffstab_build_psymtabs): Update.
221         * dbxread.c (symbuf_sections): Now a std::vector.
222         (sect_idx): New global.
223         (fill_symbuf): Update.
224         (coffstab_build_psymtabs): Change type of stabsects parameter.
225         Update.
226         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
227         std::vector.
228         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
229         (coff_locate_sections): Update.
230         (coff_symfile_read): Remove cleanups.  Update.
231         (init_stringtab): Add storage parameter.
232         (free_stringtab, free_stringtab_cleanup): Remove.
233         (init_lineno): Add storage parameter.
234         (free_linetab, free_linetab_cleanup): Remove.
235
236 2019-03-06  Pedro Alves  <palves@redhat.com>
237
238         * linux-fork.c (fork_info::clobber_regs): Delete.
239         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
240         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
241         comment.  Adjust.
242         (scoped_switch_fork_info::scoped_switch_fork_info)
243         (checkpoint_command, linux_fork_context): Adjust
244         fork_save_infrun_state calls.
245
246 2019-03-06  Pedro Alves  <palves@redhat.com>
247
248         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
249         (inf_has_multiple_threads): Return 'bool' and rewrite using
250         inferior_info::threads().
251
252 2019-03-06  Pedro Alves  <palves@redhat.com>
253
254         * linux-fork.c: Include <list>.
255         (fork_list): Now a std::list instance.
256         (fork_info): Add ctor, dtor, and in-class initialize all fields.
257         (forks_exist_p, find_last_fork): Adjust.
258         (new_fork): Delete.
259         (one_fork_p): New.
260         (add_fork): Adjust.
261         (free_fork): Delete, folded into fork_info::~fork_info().
262         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
263         Adjust.
264         (init_fork_list): Delete.
265         (linux_fork_killall, linux_fork_mourn_inferior)
266         (linux_fork_detach, info_checkpoints_command): Adjust.
267         (_initialize_linux_fork): No longer call init_fork_list.
268
269 2019-03-06  Pedro Alves  <palves@redhat.com>
270
271         * linux-fork.c (new_fork): New, split out of ...
272         (add_fork): ... this.  Return void.  Move "first fork" special
273         case from here, to ...
274         (checkpoint_command): ... here.
275         * linux-linux.h (add_fork): Return void.
276
277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
278
279         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
280
281 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
282             Chris January  <chris.january@arm.com>
283             David Lecomber  <david.lecomber@arm.com>
284
285         * f-exp.y: New token, UNOP_INTRINSIC.
286         (exp): New pattern using UNOP_INTRINSIC token.
287         (f77_keywords): Add 'abs' keyword.
288         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
289         (value_from_host_double): New function.
290         (evaluate_subexp_f): Support UNOP_ABS.
291
292 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
293
294         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
295         types.
296
297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
298
299         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
300         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
301         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
302
303 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
304
305         * f-exp.y (convert_to_kind_type): Handle more type kinds.
306
307 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
308             Chris January  <chris.january@arm.com>
309
310         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
311         * f-exp.y: Define 'KIND' token.
312         (exp): New pattern for KIND expressions.
313         (ptype): Handle types with a kind extension.
314         (direct_abs_decl): Extend to spot kind extensions.
315         (f77_keywords): Add 'kind' to the list.
316         (push_kind_type): New function.
317         (convert_to_kind_type): New function.
318         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
319         * parse.c (operator_length_standard): Likewise.
320         * parser-defs.h (enum type_pieces): Add tp_kind.
321         * std-operator.def: Add UNOP_KIND.
322
323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
324
325         * f-exp.y (f_parse): Set yydebug.
326
327 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
328
329         * f-lang.c (evaluate_subexp_f): New function.
330         (exp_descriptor_f): New global.
331         (f_language_defn): Use exp_descriptor_f instead of
332         exp_descriptor_standard.
333
334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
335
336         * f-exp.y (struct token): Add comments.
337         (dot_ops): Remove uppercase versions and the end marker.
338         (f77_keywords): Likewise.
339         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
340         entries in the dot_ops array are case insensitive, and use
341         strncasecmp to compare strings.  Also some whitespace cleanup in
342         this area.  Similar for the f77_keywords array, except entries in
343         this list might be case sensitive.
344
345 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
346
347         * f-exp.y (struct f77_boolean_val): Add comments.
348         (boolean_values): Remove uppercase versions, and end marker.
349         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
350         and use strncasecmp to achieve case insensitivity.  Additionally,
351         perform whitespace cleanup around this code.
352
353 2019-03-06  Tom Tromey  <tromey@adacore.com>
354
355         * remote-sim.c (gdbsim_target_open): Use result of
356         gdb_argv::release.
357
358 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
359         Dirk Schubert  <dirk.schubert@arm.com>
360         Chris January  <chris.january@arm.com>
361
362         * eval.c (evaluate_subexp_standard): Call Fortran argument
363         wrapping logic.
364         * f-lang.c (struct value): A value which can be passed into a
365         Fortran function call.
366         (fortran_argument_convert): Wrap Fortran arguments in a pointer
367         where appropriate.
368         (struct type): Value ready for a Fortran function call.
369         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
370         is needed.
371         * f-lang.h (fortran_argument_convert): Declaration.
372         (fortran_preserve_arg_pointer): Declaration.
373         * infcall.c (value_arg_coerce): Call Fortran argument logic.
374
375 2019-03-05  Tom Tromey  <tromey@adacore.com>
376
377         * python/py-prettyprint.c (print_string_repr): Remove #if.
378         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
379
380 2019-03-05  Tom Tromey  <tromey@adacore.com>
381
382         * target.c (the_dummy_target): Move later.  Change type to
383         "dummy_target".
384         (initialize_targets): Don't initialize the_dummy_target.
385
386 2019-03-05  Tom Tromey  <tromey@adacore.com>
387
388         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
389         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
390
391 2019-03-05  Tom Tromey  <tromey@adacore.com>
392
393         * windows-nat.c (windows_nat_target::attach)
394         (windows_nat_target::detach): Don't call gdb_flush.
395         * valprint.c (generic_val_print, val_print, val_print_string):
396         Don't call gdb_flush.
397         * utils.c (defaulted_query): Don't call gdb_flush.
398         * typeprint.c (print_type_scalar): Don't call gdb_flush.
399         * target.c (target_announce_detach): Don't call gdb_flush.
400         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
401         * remote.c (extended_remote_target::attach): Don't call
402         gdb_flush.
403         * procfs.c (procfs_target::detach): Don't call gdb_flush.
404         * printcmd.c (do_examine): Don't call gdb_flush.
405         (info_display_command): Don't call gdb_flush.
406         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
407         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
408         * memattr.c (info_mem_command): Don't call gdb_flush.
409         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
410         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
411         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
412         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
413         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
414         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
415         (gnu_nat_target::detach): Don't call gdb_flush.
416         * f-valprint.c (f_val_print): Don't call gdb_flush.
417         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
418         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
419         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
420         gdb_flush.
421         * c-valprint.c (c_val_print): Don't call gdb_flush.
422         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
423
424 2019-03-05  Tom Tromey  <tromey@adacore.com>
425
426         * varobj.c (update_dynamic_varobj_children): Update.
427         (install_default_visualizer): Use reset, not release.
428         * value.c (set_internalvar): Update.
429         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
430         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
431         ATTRIBUTE_UNUSED_RESULT.
432
433 2019-03-05  Tom Tromey  <tromey@adacore.com>
434
435         * remote.c (class scoped_remote_fd) <release>: Add
436         ATTRIBUTE_UNUSED_RESULT.
437
438 2019-03-05  Tom Tromey  <tromey@adacore.com>
439
440         * macroexp.c (struct macro_buffer) <release>: Add
441         ATTRIBUTE_UNUSED_RESULT.
442
443 2019-03-05  Tom Tromey  <tromey@adacore.com>
444
445         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
446         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
447         ATTRIBUTE_UNUSED_RESULT.
448
449 2019-03-05  Tom Tromey  <tromey@adacore.com>
450
451         * common/scoped_fd.h (class scoped_fd) <release>: Add
452         ATTRIBUTE_UNUSED_RESULT.
453
454 2019-03-05  Tom Tromey  <tromey@adacore.com>
455
456         * parser-defs.h (struct parser_state) <release>: Add
457         ATTRIBUTE_UNUSED_RESULT.
458
459 2019-03-05  Tom Tromey  <tromey@adacore.com>
460
461         * utils.h (class gdb_argv) <release>: Add
462         ATTRIBUTE_UNUSED_RESULT.
463         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
464
465 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
466
467         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
468         for-loop range, to avoid compiler warnings.
469
470         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
471         avoid compiler warnings about unused variables.
472
473         * NEWS: Mention end of support for native debugging on MS-Windows
474         before XP.
475
476         PR gdb/24292
477         * common/netstuff.c:
478         * gdbserver/gdbreplay.c
479         * gdbserver/remote-utils.c:
480         * ser-tcp.c:
481         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
482         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
483         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
484         'getaddrinfo' and 'freeaddrinfo' were not available before
485         Windows XP, and mingw.org's MinGW headers by default define
486         _WIN32_WINNT to 0x500.
487
488 2019-03-01  Gary Benson <gbenson@redhat.com>
489
490         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
491
492 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
493             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
494
495         PR gdb/8527
496         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
497         set_sigint_trap, clear_sigint_trap.
498
499 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
500
501         * target.c (target_detach): Clear the regcache and the
502         frame cache.
503
504 2019-02-27  Pedro Alves  <palves@redhat.com>
505
506         * utils.c (set_screen_size): When we cap the height/width sizes,
507         tweak the corresponding command variable to show "unlimited":
508
509 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
510             Pedro Alves  <palves@redhat.com>
511
512         * utils.c (set_screen_size): Reduce "infinite" rows and columns
513         before calling rl_set_screen_size.
514
515 2019-02-27  Tom Tromey  <tromey@adacore.com>
516
517         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
518         define.
519         * python/py-value.c: Remove Python 2.4 workaround.
520         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
521         workaround.
522         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
523         Python 2.4 workaround.
524         * python/python-internal.h: Remove Python 2.4 comment.
525         (Py_ssize_t): Don't define.
526         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
527         (gdb_Py_DECREF): Remove Python 2.4 workaround.
528         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
529         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
530         * python/python.c (do_start_initialization): Remove Python 2.4
531         workaround.
532         * python/py-prettyprint.c (class dummy_python_frame): Remove.
533         (print_children): Remove Python 2.4 workaround.
534         * python/py-inferior.c (buffer_procs): Remove Python 2.4
535         workaround.
536         (CHARBUFFERPROC_NAME): Remove.
537         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
538         Python 2.4 workaround.
539
540 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
541
542         * NEWS: Note minimum Python version.
543
544 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
545
546         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
547         code from these functions.  Remove corresponding ifdefs.  Use
548         Py_buffer_up instead of explicit calls to PyBuffer_Release.
549         Remove gotos and target of gotos.
550         (infpy_search_memory): Likewise.
551
552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
553
554         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
555         (hppa_gdbarch_init): Don't register deleted functions with
556         gdbarch.
557
558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
559
560         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
561         (h8300_unwind_sp): Delete.
562         (h8300_dummy_id): Delete.
563         (h8300_gdbarch_init): Don't register deleted functions with
564         gdbarch.
565
566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
567
568         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
569         (ft32_unwind_pc): Delete.
570         (ft32_unwind_sp): Delete.
571         (ft32_gdbarch_init): Don't register deleted functions with
572         gdbarch.
573
574 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
575
576         * gdb/frv-tdep.c (frv_dummy_id): Delete.
577         (frv_unwind_pc): Delete.
578         (frv_unwind_sp): Delete.
579         (frv_gdbarch_init): Don't register deleted functions with
580         gdbarch.
581
582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
583
584         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
585         (riscv_unwind_pc): Delete.
586         (riscv_unwind_sp): Delete.
587         (riscv_gdbarch_init): Don't register deleted functions with
588         gdbarch.
589
590 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
591
592         * gdb/csky-tdep.c (csky_dummy_id): Delete.
593         (csky_unwind_pc): Delete.
594         (csky_unwind_sp): Delete.
595         (csky_gdbarch_init): Don't register deleted functions with
596         gdbarch.
597
598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
599
600         * gdb/cris-tdep.c (cris_dummy_id): Delete.
601         (cris_unwind_pc): Delete.
602         (cris_unwind_sp): Delete.
603         (cris_gdbarch_init): Don't register deleted functions with
604         gdbarch.
605
606 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
607
608         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
609         (bfin_unwind_pc): Delete.
610         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
611
612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
613
614         * gdb/arm-tdep.c (arm_dummy_id): Delete.
615         (arm_unwind_pc): Delete.
616         (arm_unwind_sp): Delete.
617         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
618
619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
620
621         * gdb/arc-tdep.c (arc_dummy_id): Delete.
622         (arc_unwind_pc): Delete.
623         (arc_unwind_sp): Delete.
624         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
625
626 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
627
628         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
629         (alpha_unwind_pc): Delete.
630         (alpha_gdbarch_init): Don't register deleted functions with
631         gdbarch.
632
633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
634
635         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
636         (aarch64_unwind_pc): Delete.
637         (aarch64_unwind_sp): Delete.
638         (aarch64_gdbarch_init): Don't register deleted functions with
639         gdbarch.
640
641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
642
643         * gdbtypes.c (type_align): Don't consider static members when
644         computing structure alignment.
645
646 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
647
648         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
649         return 0 for other types.
650         * arch-utils.c (default_type_align): Always return 0.
651         * gdbarch.h: Regenerate.
652         * gdbarch.sh (type_align): Extend comment.
653         * gdbtypes.c (type_align): Add additional comments, always call
654         gdbarch_type_align before applying the default rules.
655         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
656         generic code will then apply a suitable default.
657         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
658         types, return 0 for other types.
659
660 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
661
662         * NEWS: Create a new section for the next release branch.
663         Rename the section of the current branch, now that it has
664         been cut.
665
666 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
667
668         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
669         * version.in: Bump version to 8.3.50.DATE-git.
670
671 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
672
673         * aix-thread.c (ptid_cmp): Remove unused variable.
674         (get_signaled_thread): Likewise.
675         (store_regs_user_thread): Likewise.
676         (store_regs_kernel_thread): Likewise.
677         (fetch_regs_kernel_thread): Remove shadowed variable.
678
679 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
680
681         * features/riscv/32bit-cpu.xml: Add register numbers.
682         * features/riscv/32bit-fpu.c: Regenerate.
683         * features/riscv/32bit-fpu.xml: Add register numbers.
684         * features/riscv/64bit-cpu.xml: Add register numbers.
685         * features/riscv/64bit-fpu.c: Regenerate.
686         * features/riscv/64bit-fpu.xml: Add register numbers.
687
688 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
689
690         * NEWS: Mention two argument form of gdb.Value constructor.
691         * python/py-value.c (convert_buffer_and_type_to_value): New
692         function.
693         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
694         Add support for handling an optional second argument.  Call
695         convert_buffer_and_type_to_value as appropriate.
696         * python/python-internal.h (Py_buffer_deleter): New struct.
697         (Py_buffer_up): New typedef.
698
699 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
700
701         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
702         instead of releasing ownership.
703
704 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
705
706         * dwarf2read.c (open_and_init_dwp_file): Call
707         elf_numsections instead of bfd_count_sections to initialize
708         dwp_file->num_sections.
709
710 2019-02-25  Tom Tromey  <tromey@adacore.com>
711
712         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
713
714 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
715
716         * gcore.in: Add '--readnever' option when invoking GDB.
717
718 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
719
720         * MAINTAINERS: Update my email address.
721
722 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
723
724         * build-id.c (build_id_to_debug_bfd_1): New function.
725         (build_id_to_debug_bfd): Look for separate debug file in
726         sysroot.
727
728 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
729
730         * gdbarch.sh: Update the copyright year range that is placed into
731         generated files.
732
733 2019-02-22  Keith Seitz  <keiths@redhat.com>
734
735         PR symtab/23853
736         * linespec.c (create_sals_line_offset): Search for the default
737         symtab's filename instead of its fullname.
738
739 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
740
741         * NEWS: Update style defaults.
742
743 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
744
745         * main.c (captured_main_1): Disable styling in batch mode.
746
747 2019-02-20  Tom Tromey  <tom@tromey.com>
748
749         * symtab.c (symtab_symbol_info): Fix typos.
750
751 2019-02-20  Tom Tromey  <tromey@adacore.com>
752
753         * findcmd.c (_initialize_mem_search): Use upper case for
754         metasyntactic variables.
755
756 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
757
758         * aarch64-tdep.c (aarch64_add_reggroups): New function.
759         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
760
761 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
762
763         * top.h (source_file_name): Change to std::string.
764         * top.c (source_file_name): Likewise.
765         (command_line_input): Adjust.
766         * cli/cli-script.c (script_from_file): Adjust.
767
768 2019-02-19  Tom Tromey  <tromey@adacore.com>
769
770         * ravenscar-thread.c
771         (ravenscar_thread_target::update_thread_list): Don't call
772         ada_build_task_list.
773         * ada-lang.h (ada_build_task_list): Don't declare.
774         * ada-tasks.c (struct ada_tasks_inferior_data)
775         <task_list_valid_p>: Now bool.
776         (read_known_tasks, ada_task_list_changed)
777         (ada_tasks_invalidate_inferior_data): Update.
778         (read_known_tasks_array): Return bool.
779         (read_known_tasks_list): Likewise.
780         (read_known_tasks): Return void.
781         (ada_build_task_list): Now static.
782
783 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
784
785         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
786         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
787
788 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
789
790         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
791         variant for ada_tasks_pspace_data_handle and
792         ada_tasks_inferior_data_handle.
793         (ada_tasks_pspace_data_cleanup): New function.
794         (ada_tasks_inferior_data_cleanup): New function.
795
796 2019-02-17  Tom Tromey  <tom@tromey.com>
797
798         * macrotab.h (macro_source_fullname): Return a std::string.
799         * macrotab.c (macro_include, check_for_redefinition)
800         (macro_undef, macro_lookup_definition, foreach_macro)
801         (foreach_macro_in_scope): Update.
802         (macro_source_fullname): Return a std::string.
803         * macrocmd.c (show_pp_source_pos): Update.
804
805 2019-02-17  Tom Tromey  <tom@tromey.com>
806
807         * macrocmd.c (show_pp_source_pos): Style the file names.
808
809 2019-02-17  Tom Tromey  <tom@tromey.com>
810
811         PR tui/24197:
812         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
813
814 2019-02-17  Tom Tromey  <tom@tromey.com>
815
816         * ada-lang.c (user_select_syms): Use filtered printing.
817         * utils.c (wrap_style): New global.
818         (desired_style): Remove.
819         (emit_style_escape): Add stream parameter.
820         (set_output_style, reset_terminal_style, prompt_for_continue):
821         Update.
822         (flush_wrap_buffer): Only flush gdb_stdout.
823         (wrap_here): Set wrap_style.
824         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
825         treat escape sequences as a character.  Change when wrap buffer is
826         flushed.
827         (fputs_styled): Do not set the output style when the default is
828         requested.
829         * ui-style.h (struct ui_file_style) <is_default>: New method.
830         * source.c (print_source_lines_base): Emit escape sequences in one
831         piece.
832
833 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
834
835         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
836         integers and enumeration types.
837
838 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
839
840         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
841         instead of lookup_symbol_in_language
842         (do_exact_match): New function.
843         (ada_get_symbol_name_matcher): Return do_exact_match when
844         doing a verbatim match.
845
846 2019-02-15  Tom Tromey  <tromey@adacore.com>
847
848         * ravenscar-thread.c (ravenscar_thread_target::resume)
849         (ravenscar_thread_target::wait): Special case wildcard requests.
850
851 2019-02-15  Tom Tromey  <tromey@adacore.com>
852
853         * ravenscar-thread.c (base_ptid): Remove.
854         (struct ravenscar_thread_target) <close>: New method.
855         <m_base_ptid>: New member.
856         <update_inferior_ptid, active_task, task_is_currently_active,
857         runtime_initialized>: Declare methods.
858         <ravenscar_thread_target>: Add constructor.
859         (ravenscar_thread_target::task_is_currently_active)
860         (ravenscar_thread_target::update_inferior_ptid)
861         (ravenscar_runtime_initialized): Rename.  Now methods.
862         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
863         (ravenscar_thread_target::update_thread_list): Update.
864         (ravenscar_thread_target::active_task): Now method.
865         (ravenscar_thread_target::store_registers)
866         (ravenscar_thread_target::prepare_to_store)
867         (ravenscar_thread_target::prepare_to_store)
868         (ravenscar_thread_target::mourn_inferior): Update.
869         (ravenscar_inferior_created): Use "new" to create target.
870         (ravenscar_thread_target::get_ada_task_ptid): Update.
871         (_initialize_ravenscar): Don't initialize base_ptid.
872         (ravenscar_ops): Remove global.
873
874 2019-02-15  Tom Tromey  <tromey@adacore.com>
875
876         * target.h (push_target): Declare new overload.
877         * target.c (push_target): New overload, taking an rvalue reference.
878         * remote.c (remote_target::open_1): Use push_target overload.
879         * corelow.c (core_target_open): Use push_target overload.
880
881 2019-02-15  Tom Tromey  <tromey@adacore.com>
882
883         * ravenscar-thread.c (is_ravenscar_task)
884         (ravenscar_task_is_currently_active): Return bool.
885         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
886         (_initialize_ravenscar): Remove "(void)".
887         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
888         Return bool.
889
890 2019-02-15  Tom Tromey  <tromey@adacore.com>
891
892         * ravenscar-thread.c (ravenscar_runtime_initializer)
893         (has_ravenscar_runtime, get_running_thread_id)
894         (ravenscar_thread_target::resume): Fix indentation.
895
896 2019-02-15  Tom Tromey  <tromey@adacore.com>
897
898         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
899         from ravenscar_arch_ops.
900         (sparc_ravenscar_ops::fetch_registers)
901         (sparc_ravenscar_ops::store_registers): Now methods.
902         (sparc_ravenscar_prepare_to_store): Remove.
903         (sparc_ravenscar_ops): Redefine.
904         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
905         methods and destructor.  Remove members.
906         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
907         (ravenscar_thread_target::store_registers)
908         (ravenscar_thread_target::prepare_to_store): Update.
909         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
910         Remove.
911         (struct ppc_ravenscar_powerpc_ops): Derive from
912         ravenscar_arch_ops.
913         (ppc_ravenscar_powerpc_ops::fetch_registers)
914         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
915         (ppc_ravenscar_powerpc_ops): Redefine.
916         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
917         (ppc_ravenscar_e500_ops::fetch_registers)
918         (ppc_ravenscar_e500_ops::store_registers): Now methods.
919         (ppc_ravenscar_e500_ops): Redefine.
920         * aarch64-ravenscar-thread.c
921         (aarch64_ravenscar_generic_prepare_to_store): Remove.
922         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
923         (aarch64_ravenscar_fetch_registers)
924         (aarch64_ravenscar_store_registers): Now methods.
925         (aarch64_ravenscar_ops): Redefine.
926
927 2019-02-15  Tom Tromey  <tromey@adacore.com>
928
929         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
930         (ravenscar_thread_target::stopped_by_hw_breakpoint)
931         (ravenscar_thread_target::stopped_by_watchpoint)
932         (ravenscar_thread_target::stopped_data_address)
933         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
934
935 2019-02-15  Tom Tromey  <tromey@adacore.com>
936
937         * ravenscar-thread.c: Fix some typos.
938
939 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
940             Tom Tromey  <tromey@adacore.com>
941
942         * ada-lang.c (ada_exception_sal): Change addr_string to a
943         std::string.
944         (create_ada_exception_catchpoint): Update.
945
946 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
947             Tom Tromey  <tromey@adacore.com>
948
949         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
950         (bp_location_ops): Remove.
951         (base_breakpoint_allocate_location): Update.
952         (free_bp_location): Update.
953         * ada-lang.c (class ada_catchpoint_location)
954         <ada_catchpoint_location>: Remove ops parameter.
955         (ada_catchpoint_location_dtor): Remove.
956         (ada_catchpoint_location_ops): Remove.
957         (allocate_location_exception): Update.
958         * breakpoint.h (struct bp_location_ops): Remove.
959         (class bp_location) <bp_location>: Remove bp_location_ops
960         parameter.
961         <~bp_location>: Add destructor.
962         <ops>: Remove.
963
964 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
965             Pedro Alves  <palves@redhat.com>
966
967         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
968         'PATH_MAX'.
969
970 2019-02-14  David Michael  <fedora.dm0@gmail.com>
971             Samuel Thibault  <samuel.thibault@gnu.org>
972             Thomas Schwinge  <thomas@codesourcery.com>
973
974         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
975         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
976
977 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
978
979         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
980         (check_empty): Use "const char *".
981
982         * gnu-nat.c (gnu_nat_target::detach): Instead of
983         'detach_inferior (pid)' call
984         'detach_inferior (find_inferior_pid (pid))'.
985
986         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
987         'nat/fork-inferior.o'.
988         * gnu-nat.c: #include "nat/fork-inferior.h".
989
990         * gnu-nat.c (gnu_nat_target::detach): Instead of
991         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
992         * gnu-nat.h: #include "inf-child.h".
993         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
994         'i386_gnu_nat_target::fetch_registers'.
995         (gnu_store_registers): Rename/move to
996         'i386_gnu_nat_target::store_registers'.
997
998         * config/i386/nm-i386gnu.h: Don't "#include" any files.
999         * gnu-nat.h (mach_thread_info): New function.
1000         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1001
1002         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1003
1004 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1005
1006         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1007
1008 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1009
1010         * windows-nat.c (windows_add_thread): Add new parameter
1011         "main_thread_p" with default value set to false.  Update
1012         function documentation as well as all callers.
1013         (windows_delete_thread): Likewise.
1014         (fake_create_process): Update call to windows_add_thread.
1015         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1016         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1017         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1018         call to windows_delete_thread.
1019
1020 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1021
1022         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1023
1024 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1025
1026         * symfile.c (find_separate_debug_file): Use canonical path of
1027         sysroot with child_path instead of gdb_sysroot if it is valid.
1028
1029 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1030
1031         * symfile.c (find_separate_debug_file): Use child_path to
1032         determine if an object file is under a sysroot.
1033
1034 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1035
1036         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1037         unittests/child-path-selftests.c.
1038         * common/pathstuff.c (child_path): New function.
1039         * common/pathstuff.h (child_path): New prototype.
1040         * unittests/child-path-selftests.c: New file.
1041
1042 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1043
1044         * symfile.c (find_separate_debug_file): Look for separate debug
1045         files in debug directories under the sysroot.
1046
1047 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1048
1049         * symtab.h (struct minimal_symbol data_p): New const method.
1050         (struct minimal_symbol text_p): Likewise.
1051         * symtab.c (output_source_filename): Use file name style
1052         to print file name.
1053         (print_symbol_info): Likewise.
1054         (print_msymbol_info): Use address style to print addresses.
1055         Use function name style to print executable text symbols.
1056         (expand_symtab_containing_pc): Use data_p.
1057         (find_pc_sect_compunit_symtab): Likewise.
1058
1059 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1060
1061         * breakpoint.c (describe_other_breakpoints): Use address style
1062         to print addresses.
1063         (say_where): Likewise.
1064
1065 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1066
1067         * ada-typeprint.c (print_func_type): Print function name
1068         style to print function name.
1069         * c-typeprint.c (c_print_type_1): Likewise.
1070
1071 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1072
1073         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1074         for execve.
1075
1076 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1077
1078         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1079         type_stack.
1080
1081 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1082
1083         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1084         TYPE_CODE_REF types.
1085
1086 2019-02-08  Jim Wilson  <jimw@sifive.com>
1087
1088         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1089         (riscv_linux_fregset): New.
1090         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1091
1092 2019-02-07  Tom Tromey  <tom@tromey.com>
1093
1094         * thread.c (thread_cancel_execution_command): Update.
1095         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1096         methods.
1097         (struct thread_fsm_ops): Remove.
1098         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1099         (thread_fsm_should_stop, thread_fsm_return_value)
1100         (thread_fsm_set_finished, thread_fsm_finished_p)
1101         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1102         Don't declare.
1103         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1104         * infrun.c (clear_proceed_status_thread)
1105         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1106         (print_stop_event): Update.
1107         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1108         Add constructor.
1109         (step_command_fsm_ops): Remove.
1110         (new_step_command_fsm): Remove.
1111         (step_1): Update.
1112         (step_command_fsm::should_stop): Rename from
1113         step_command_fsm_should_stop.
1114         (step_command_fsm::clean_up): Rename from
1115         step_command_fsm_clean_up.
1116         (step_command_fsm::do_async_reply_reason): Rename from
1117         step_command_fsm_async_reply_reason.
1118         (struct until_next_fsm): Inherit from thread_fsm.  Add
1119         constructor.
1120         (until_next_fsm_ops): Remove.
1121         (new_until_next_fsm): Remove.
1122         (until_next_fsm::should_stop): Rename from
1123         until_next_fsm_should_stop.
1124         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1125         (until_next_fsm::do_async_reply_reason): Rename from
1126         until_next_fsm_async_reply_reason.
1127         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1128         constructor.  Change type of breakpoint.
1129         (finish_command_fsm_ops): Remove.
1130         (new_finish_command_fsm): Remove.
1131         (finish_command_fsm::should_stop): Rename from
1132         finish_command_fsm_should_stop.
1133         (finish_command_fsm::clean_up): Rename from
1134         finish_command_fsm_clean_up.
1135         (finish_command_fsm::return_value): Rename from
1136         finish_command_fsm_return_value.
1137         (finish_command_fsm::do_async_reply_reason): Rename from
1138         finish_command_fsm_async_reply_reason.
1139         (finish_command): Update.
1140         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1141         Add constructor.
1142         (call_thread_fsm_ops): Remove.
1143         (call_thread_fsm::call_thread_fsm): Rename from
1144         new_call_thread_fsm.
1145         (call_thread_fsm::should_stop): Rename from
1146         call_thread_fsm_should_stop.
1147         (call_thread_fsm::should_notify_stop): Rename from
1148         call_thread_fsm_should_notify_stop.
1149         (run_inferior_call, call_function_by_hand_dummy): Update.
1150         * cli/cli-interp.c (should_print_stop_to_console): Update.
1151         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1152         Add constructor.  Change type of location_breakpoint,
1153         caller_breakpoint.
1154         (until_break_fsm_ops): Remove.
1155         (new_until_break_fsm): Remove.
1156         (until_break_fsm::should_stop): Rename from
1157         until_break_fsm_should_stop.
1158         (until_break_fsm::clean_up): Rename from
1159         until_break_fsm_clean_up.
1160         (until_break_fsm::do_async_reply_reason): Rename from
1161         until_break_fsm_async_reply_reason.
1162         (until_break_command): Update.
1163         * thread-fsm.c: Remove.
1164         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1165
1166 2019-02-07  Tom Tromey  <tom@tromey.com>
1167
1168         * yy-remap.h: Add include guard.
1169         * xtensa-tdep.h: Add include guard.
1170         * xcoffread.h: Rename include guard.
1171         * varobj-iter.h: Add include guard.
1172         * tui/tui.h: Rename include guard.
1173         * tui/tui-winsource.h: Rename include guard.
1174         * tui/tui-wingeneral.h: Rename include guard.
1175         * tui/tui-windata.h: Rename include guard.
1176         * tui/tui-win.h: Rename include guard.
1177         * tui/tui-stack.h: Rename include guard.
1178         * tui/tui-source.h: Rename include guard.
1179         * tui/tui-regs.h: Rename include guard.
1180         * tui/tui-out.h: Rename include guard.
1181         * tui/tui-layout.h: Rename include guard.
1182         * tui/tui-io.h: Rename include guard.
1183         * tui/tui-hooks.h: Rename include guard.
1184         * tui/tui-file.h: Rename include guard.
1185         * tui/tui-disasm.h: Rename include guard.
1186         * tui/tui-data.h: Rename include guard.
1187         * tui/tui-command.h: Rename include guard.
1188         * tic6x-tdep.h: Add include guard.
1189         * target/waitstatus.h: Rename include guard.
1190         * target/wait.h: Rename include guard.
1191         * target/target.h: Rename include guard.
1192         * target/resume.h: Rename include guard.
1193         * target-float.h: Rename include guard.
1194         * stabsread.h: Add include guard.
1195         * rs6000-tdep.h: Add include guard.
1196         * riscv-fbsd-tdep.h: Add include guard.
1197         * regformats/regdef.h: Rename include guard.
1198         * record.h: Rename include guard.
1199         * python/python.h: Rename include guard.
1200         * python/python-internal.h: Rename include guard.
1201         * python/py-stopevent.h: Rename include guard.
1202         * python/py-ref.h: Rename include guard.
1203         * python/py-record.h: Rename include guard.
1204         * python/py-record-full.h: Rename include guard.
1205         * python/py-record-btrace.h: Rename include guard.
1206         * python/py-instruction.h: Rename include guard.
1207         * python/py-events.h: Rename include guard.
1208         * python/py-event.h: Rename include guard.
1209         * procfs.h: Add include guard.
1210         * proc-utils.h: Add include guard.
1211         * p-lang.h: Add include guard.
1212         * or1k-tdep.h: Rename include guard.
1213         * observable.h: Rename include guard.
1214         * nto-tdep.h: Rename include guard.
1215         * nat/x86-linux.h: Rename include guard.
1216         * nat/x86-linux-dregs.h: Rename include guard.
1217         * nat/x86-gcc-cpuid.h: Add include guard.
1218         * nat/x86-dregs.h: Rename include guard.
1219         * nat/x86-cpuid.h: Rename include guard.
1220         * nat/ppc-linux.h: Rename include guard.
1221         * nat/mips-linux-watch.h: Rename include guard.
1222         * nat/linux-waitpid.h: Rename include guard.
1223         * nat/linux-ptrace.h: Rename include guard.
1224         * nat/linux-procfs.h: Rename include guard.
1225         * nat/linux-osdata.h: Rename include guard.
1226         * nat/linux-nat.h: Rename include guard.
1227         * nat/linux-namespaces.h: Rename include guard.
1228         * nat/linux-btrace.h: Rename include guard.
1229         * nat/glibc_thread_db.h: Rename include guard.
1230         * nat/gdb_thread_db.h: Rename include guard.
1231         * nat/gdb_ptrace.h: Rename include guard.
1232         * nat/fork-inferior.h: Rename include guard.
1233         * nat/amd64-linux-siginfo.h: Rename include guard.
1234         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1235         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1236         * nat/aarch64-linux.h: Rename include guard.
1237         * nat/aarch64-linux-hw-point.h: Rename include guard.
1238         * mn10300-tdep.h: Add include guard.
1239         * mips-linux-tdep.h: Add include guard.
1240         * mi/mi-parse.h: Rename include guard.
1241         * mi/mi-out.h: Rename include guard.
1242         * mi/mi-main.h: Rename include guard.
1243         * mi/mi-interp.h: Rename include guard.
1244         * mi/mi-getopt.h: Rename include guard.
1245         * mi/mi-console.h: Rename include guard.
1246         * mi/mi-common.h: Rename include guard.
1247         * mi/mi-cmds.h: Rename include guard.
1248         * mi/mi-cmd-break.h: Rename include guard.
1249         * m2-lang.h: Add include guard.
1250         * location.h: Rename include guard.
1251         * linux-record.h: Rename include guard.
1252         * linux-nat.h: Add include guard.
1253         * linux-fork.h: Add include guard.
1254         * i386-darwin-tdep.h: Rename include guard.
1255         * hppa-linux-offsets.h: Add include guard.
1256         * guile/guile.h: Rename include guard.
1257         * guile/guile-internal.h: Rename include guard.
1258         * gnu-nat.h: Rename include guard.
1259         * gdb-stabs.h: Rename include guard.
1260         * frv-tdep.h: Add include guard.
1261         * f-lang.h: Add include guard.
1262         * event-loop.h: Add include guard.
1263         * darwin-nat.h: Rename include guard.
1264         * cp-abi.h: Rename include guard.
1265         * config/sparc/nm-sol2.h: Rename include guard.
1266         * config/nm-nto.h: Rename include guard.
1267         * config/nm-linux.h: Add include guard.
1268         * config/i386/nm-i386gnu.h: Rename include guard.
1269         * config/djgpp/nl_types.h: Rename include guard.
1270         * config/djgpp/langinfo.h: Rename include guard.
1271         * compile/gcc-cp-plugin.h: Add include guard.
1272         * compile/gcc-c-plugin.h: Add include guard.
1273         * compile/compile.h: Rename include guard.
1274         * compile/compile-object-run.h: Rename include guard.
1275         * compile/compile-object-load.h: Rename include guard.
1276         * compile/compile-internal.h: Rename include guard.
1277         * compile/compile-cplus.h: Rename include guard.
1278         * compile/compile-c.h: Rename include guard.
1279         * common/xml-utils.h: Rename include guard.
1280         * common/x86-xstate.h: Rename include guard.
1281         * common/version.h: Rename include guard.
1282         * common/vec.h: Rename include guard.
1283         * common/tdesc.h: Rename include guard.
1284         * common/selftest.h: Rename include guard.
1285         * common/scoped_restore.h: Rename include guard.
1286         * common/scoped_mmap.h: Rename include guard.
1287         * common/scoped_fd.h: Rename include guard.
1288         * common/safe-iterator.h: Rename include guard.
1289         * common/run-time-clock.h: Rename include guard.
1290         * common/refcounted-object.h: Rename include guard.
1291         * common/queue.h: Rename include guard.
1292         * common/ptid.h: Rename include guard.
1293         * common/print-utils.h: Rename include guard.
1294         * common/preprocessor.h: Rename include guard.
1295         * common/pathstuff.h: Rename include guard.
1296         * common/observable.h: Rename include guard.
1297         * common/netstuff.h: Rename include guard.
1298         * common/job-control.h: Rename include guard.
1299         * common/host-defs.h: Rename include guard.
1300         * common/gdb_wait.h: Rename include guard.
1301         * common/gdb_vecs.h: Rename include guard.
1302         * common/gdb_unlinker.h: Rename include guard.
1303         * common/gdb_unique_ptr.h: Rename include guard.
1304         * common/gdb_tilde_expand.h: Rename include guard.
1305         * common/gdb_sys_time.h: Rename include guard.
1306         * common/gdb_string_view.h: Rename include guard.
1307         * common/gdb_splay_tree.h: Rename include guard.
1308         * common/gdb_setjmp.h: Rename include guard.
1309         * common/gdb_ref_ptr.h: Rename include guard.
1310         * common/gdb_optional.h: Rename include guard.
1311         * common/gdb_locale.h: Rename include guard.
1312         * common/gdb_assert.h: Rename include guard.
1313         * common/filtered-iterator.h: Rename include guard.
1314         * common/filestuff.h: Rename include guard.
1315         * common/fileio.h: Rename include guard.
1316         * common/environ.h: Rename include guard.
1317         * common/common-utils.h: Rename include guard.
1318         * common/common-types.h: Rename include guard.
1319         * common/common-regcache.h: Rename include guard.
1320         * common/common-inferior.h: Rename include guard.
1321         * common/common-gdbthread.h: Rename include guard.
1322         * common/common-exceptions.h: Rename include guard.
1323         * common/common-defs.h: Rename include guard.
1324         * common/common-debug.h: Rename include guard.
1325         * common/cleanups.h: Rename include guard.
1326         * common/buffer.h: Rename include guard.
1327         * common/btrace-common.h: Rename include guard.
1328         * common/break-common.h: Rename include guard.
1329         * cli/cli-utils.h: Rename include guard.
1330         * cli/cli-style.h: Rename include guard.
1331         * cli/cli-setshow.h: Rename include guard.
1332         * cli/cli-script.h: Rename include guard.
1333         * cli/cli-interp.h: Rename include guard.
1334         * cli/cli-decode.h: Rename include guard.
1335         * cli/cli-cmds.h: Rename include guard.
1336         * charset-list.h: Add include guard.
1337         * buildsym-legacy.h: Rename include guard.
1338         * bfin-tdep.h: Add include guard.
1339         * ax.h: Rename include guard.
1340         * arm-linux-tdep.h: Add include guard.
1341         * arm-fbsd-tdep.h: Add include guard.
1342         * arch/xtensa.h: Rename include guard.
1343         * arch/tic6x.h: Add include guard.
1344         * arch/i386.h: Add include guard.
1345         * arch/arm.h: Rename include guard.
1346         * arch/arm-linux.h: Rename include guard.
1347         * arch/arm-get-next-pcs.h: Rename include guard.
1348         * arch/amd64.h: Add include guard.
1349         * arch/aarch64-insn.h: Rename include guard.
1350         * arch-utils.h: Rename include guard.
1351         * annotate.h: Add include guard.
1352         * amd64-darwin-tdep.h: Rename include guard.
1353         * aarch64-linux-tdep.h: Add include guard.
1354         * aarch64-fbsd-tdep.h: Add include guard.
1355         * aarch32-linux-nat.h: Add include guard.
1356
1357 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1358
1359         * macrotab.c (macro_define_internal): New function that
1360         factorizes macro_define_object_internal and macro_define_function
1361         code.
1362         (macro_define_object_internal): Use macro_define_internal.
1363         (macro_define_function): Likewise.
1364
1365 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1366
1367         * macrocmd.c (extract_identifier): Return
1368         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1369         callers.
1370
1371 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1372
1373         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1374
1375 2019-02-05  Tom Tromey  <tom@tromey.com>
1376
1377         * target.c (target_stack::unpush): Move assertion earlier.
1378
1379 2019-01-30  Tom Tromey  <tom@tromey.com>
1380
1381         PR python/23615:
1382         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1383         (gdbpy_parse_and_eval): Likewise.
1384         * python/python-internal.h (gdbpy_allow_threads): New class.
1385
1386 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1387
1388         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1389         (aarch64_fbsd_fpregmap): Move earlier.
1390         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1391         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1392         instead of individual calls to trad_frame_set_reg_addr.
1393         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1394         earlier.
1395         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1396         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1397         instead of individual calls to trad_frame_set_reg_addr.
1398
1399 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1400
1401         * CONTRIBUTE: Replace contribution list with wiki link.
1402
1403 2019-01-25  Tom Tromey  <tom@tromey.com>
1404
1405         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1406
1407 2019-01-25  Tom Tromey  <tom@tromey.com>
1408
1409         * xtensa-linux-nat.c: Fix common/ includes.
1410         * xml-support.h: Fix common/ includes.
1411         * xml-support.c: Fix common/ includes.
1412         * x86-linux-nat.c: Fix common/ includes.
1413         * windows-nat.c: Fix common/ includes.
1414         * varobj.h: Fix common/ includes.
1415         * varobj.c: Fix common/ includes.
1416         * value.c: Fix common/ includes.
1417         * valops.c: Fix common/ includes.
1418         * utils.c: Fix common/ includes.
1419         * unittests/xml-utils-selftests.c: Fix common/ includes.
1420         * unittests/utils-selftests.c: Fix common/ includes.
1421         * unittests/unpack-selftests.c: Fix common/ includes.
1422         * unittests/tracepoint-selftests.c: Fix common/ includes.
1423         * unittests/style-selftests.c: Fix common/ includes.
1424         * unittests/string_view-selftests.c: Fix common/ includes.
1425         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1426         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1427         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1428         * unittests/rsp-low-selftests.c: Fix common/ includes.
1429         * unittests/parse-connection-spec-selftests.c: Fix common/
1430         includes.
1431         * unittests/optional-selftests.c: Fix common/ includes.
1432         * unittests/offset-type-selftests.c: Fix common/ includes.
1433         * unittests/observable-selftests.c: Fix common/ includes.
1434         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1435         * unittests/memrange-selftests.c: Fix common/ includes.
1436         * unittests/memory-map-selftests.c: Fix common/ includes.
1437         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1438         * unittests/function-view-selftests.c: Fix common/ includes.
1439         * unittests/environ-selftests.c: Fix common/ includes.
1440         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1441         * unittests/common-utils-selftests.c: Fix common/ includes.
1442         * unittests/cli-utils-selftests.c: Fix common/ includes.
1443         * unittests/array-view-selftests.c: Fix common/ includes.
1444         * ui-file.c: Fix common/ includes.
1445         * tui/tui-io.c: Fix common/ includes.
1446         * tracepoint.h: Fix common/ includes.
1447         * tracepoint.c: Fix common/ includes.
1448         * tracefile-tfile.c: Fix common/ includes.
1449         * top.h: Fix common/ includes.
1450         * top.c: Fix common/ includes.
1451         * thread.c: Fix common/ includes.
1452         * target/waitstatus.h: Fix common/ includes.
1453         * target/waitstatus.c: Fix common/ includes.
1454         * target.h: Fix common/ includes.
1455         * target.c: Fix common/ includes.
1456         * target-memory.c: Fix common/ includes.
1457         * target-descriptions.c: Fix common/ includes.
1458         * symtab.h: Fix common/ includes.
1459         * symfile.c: Fix common/ includes.
1460         * stap-probe.c: Fix common/ includes.
1461         * spu-linux-nat.c: Fix common/ includes.
1462         * sparc-nat.c: Fix common/ includes.
1463         * source.c: Fix common/ includes.
1464         * solib.c: Fix common/ includes.
1465         * solib-target.c: Fix common/ includes.
1466         * ser-unix.c: Fix common/ includes.
1467         * ser-tcp.c: Fix common/ includes.
1468         * ser-pipe.c: Fix common/ includes.
1469         * ser-base.c: Fix common/ includes.
1470         * selftest-arch.c: Fix common/ includes.
1471         * s12z-tdep.c: Fix common/ includes.
1472         * rust-exp.y: Fix common/ includes.
1473         * rs6000-aix-tdep.c: Fix common/ includes.
1474         * riscv-tdep.c: Fix common/ includes.
1475         * remote.c: Fix common/ includes.
1476         * remote-notif.h: Fix common/ includes.
1477         * remote-fileio.h: Fix common/ includes.
1478         * remote-fileio.c: Fix common/ includes.
1479         * regcache.h: Fix common/ includes.
1480         * regcache.c: Fix common/ includes.
1481         * record-btrace.c: Fix common/ includes.
1482         * python/python.c: Fix common/ includes.
1483         * python/py-type.c: Fix common/ includes.
1484         * python/py-inferior.c: Fix common/ includes.
1485         * progspace.h: Fix common/ includes.
1486         * producer.c: Fix common/ includes.
1487         * procfs.c: Fix common/ includes.
1488         * proc-api.c: Fix common/ includes.
1489         * printcmd.c: Fix common/ includes.
1490         * ppc-linux-nat.c: Fix common/ includes.
1491         * parser-defs.h: Fix common/ includes.
1492         * osdata.c: Fix common/ includes.
1493         * obsd-nat.c: Fix common/ includes.
1494         * nat/x86-linux.c: Fix common/ includes.
1495         * nat/x86-linux-dregs.c: Fix common/ includes.
1496         * nat/x86-dregs.h: Fix common/ includes.
1497         * nat/x86-dregs.c: Fix common/ includes.
1498         * nat/ppc-linux.c: Fix common/ includes.
1499         * nat/mips-linux-watch.h: Fix common/ includes.
1500         * nat/mips-linux-watch.c: Fix common/ includes.
1501         * nat/linux-waitpid.c: Fix common/ includes.
1502         * nat/linux-ptrace.h: Fix common/ includes.
1503         * nat/linux-ptrace.c: Fix common/ includes.
1504         * nat/linux-procfs.c: Fix common/ includes.
1505         * nat/linux-personality.c: Fix common/ includes.
1506         * nat/linux-osdata.c: Fix common/ includes.
1507         * nat/linux-namespaces.c: Fix common/ includes.
1508         * nat/linux-btrace.h: Fix common/ includes.
1509         * nat/linux-btrace.c: Fix common/ includes.
1510         * nat/fork-inferior.c: Fix common/ includes.
1511         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1512         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1513         * nat/aarch64-linux.c: Fix common/ includes.
1514         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1515         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1516         * namespace.h: Fix common/ includes.
1517         * mips-linux-tdep.c: Fix common/ includes.
1518         * minsyms.c: Fix common/ includes.
1519         * mi/mi-parse.h: Fix common/ includes.
1520         * mi/mi-main.c: Fix common/ includes.
1521         * mi/mi-cmd-env.c: Fix common/ includes.
1522         * memrange.h: Fix common/ includes.
1523         * memattr.c: Fix common/ includes.
1524         * maint.h: Fix common/ includes.
1525         * maint.c: Fix common/ includes.
1526         * main.c: Fix common/ includes.
1527         * machoread.c: Fix common/ includes.
1528         * location.c: Fix common/ includes.
1529         * linux-thread-db.c: Fix common/ includes.
1530         * linux-nat.c: Fix common/ includes.
1531         * linux-fork.c: Fix common/ includes.
1532         * inline-frame.c: Fix common/ includes.
1533         * infrun.c: Fix common/ includes.
1534         * inflow.c: Fix common/ includes.
1535         * inferior.h: Fix common/ includes.
1536         * inferior.c: Fix common/ includes.
1537         * infcmd.c: Fix common/ includes.
1538         * inf-ptrace.c: Fix common/ includes.
1539         * inf-child.c: Fix common/ includes.
1540         * ia64-linux-nat.c: Fix common/ includes.
1541         * i387-tdep.c: Fix common/ includes.
1542         * i386-tdep.c: Fix common/ includes.
1543         * i386-linux-tdep.c: Fix common/ includes.
1544         * i386-linux-nat.c: Fix common/ includes.
1545         * i386-go32-tdep.c: Fix common/ includes.
1546         * i386-fbsd-tdep.c: Fix common/ includes.
1547         * i386-fbsd-nat.c: Fix common/ includes.
1548         * guile/scm-type.c: Fix common/ includes.
1549         * guile/guile.c: Fix common/ includes.
1550         * go32-nat.c: Fix common/ includes.
1551         * gnu-nat.c: Fix common/ includes.
1552         * gdbthread.h: Fix common/ includes.
1553         * gdbarch-selftests.c: Fix common/ includes.
1554         * gdb_usleep.c: Fix common/ includes.
1555         * gdb_select.h: Fix common/ includes.
1556         * gdb_bfd.c: Fix common/ includes.
1557         * gcore.c: Fix common/ includes.
1558         * fork-child.c: Fix common/ includes.
1559         * findvar.c: Fix common/ includes.
1560         * fbsd-nat.c: Fix common/ includes.
1561         * event-top.c: Fix common/ includes.
1562         * event-loop.c: Fix common/ includes.
1563         * dwarf2read.c: Fix common/ includes.
1564         * dwarf2loc.c: Fix common/ includes.
1565         * dwarf2-frame.c: Fix common/ includes.
1566         * dwarf-index-cache.c: Fix common/ includes.
1567         * dtrace-probe.c: Fix common/ includes.
1568         * disasm-selftests.c: Fix common/ includes.
1569         * defs.h: Fix common/ includes.
1570         * csky-tdep.c: Fix common/ includes.
1571         * cp-valprint.c: Fix common/ includes.
1572         * cp-support.h: Fix common/ includes.
1573         * cp-support.c: Fix common/ includes.
1574         * corelow.c: Fix common/ includes.
1575         * completer.h: Fix common/ includes.
1576         * completer.c: Fix common/ includes.
1577         * compile/compile.c: Fix common/ includes.
1578         * compile/compile-loc2c.c: Fix common/ includes.
1579         * compile/compile-cplus-types.c: Fix common/ includes.
1580         * compile/compile-cplus-symbols.c: Fix common/ includes.
1581         * command.h: Fix common/ includes.
1582         * cli/cli-dump.c: Fix common/ includes.
1583         * cli/cli-cmds.c: Fix common/ includes.
1584         * charset.c: Fix common/ includes.
1585         * build-id.c: Fix common/ includes.
1586         * btrace.h: Fix common/ includes.
1587         * btrace.c: Fix common/ includes.
1588         * breakpoint.h: Fix common/ includes.
1589         * breakpoint.c: Fix common/ includes.
1590         * ax.h: 
1591         (enum agent_op): Fix common/ includes.
1592         * ax-general.c (struct aop_map): Fix common/ includes.
1593         * ax-gdb.c: Fix common/ includes.
1594         * auxv.c: Fix common/ includes.
1595         * auto-load.c: Fix common/ includes.
1596         * arm-tdep.c: Fix common/ includes.
1597         * arch/riscv.c: Fix common/ includes.
1598         * arch/ppc-linux-common.c: Fix common/ includes.
1599         * arch/i386.c: Fix common/ includes.
1600         * arch/arm.c: Fix common/ includes.
1601         * arch/arm-linux.c: Fix common/ includes.
1602         * arch/arm-get-next-pcs.c: Fix common/ includes.
1603         * arch/amd64.c: Fix common/ includes.
1604         * arch/aarch64.c: Fix common/ includes.
1605         * arch/aarch64-insn.c: Fix common/ includes.
1606         * arch-utils.c: Fix common/ includes.
1607         * amd64-windows-tdep.c: Fix common/ includes.
1608         * amd64-tdep.c: Fix common/ includes.
1609         * amd64-sol2-tdep.c: Fix common/ includes.
1610         * amd64-obsd-tdep.c: Fix common/ includes.
1611         * amd64-nbsd-tdep.c: Fix common/ includes.
1612         * amd64-linux-tdep.c: Fix common/ includes.
1613         * amd64-linux-nat.c: Fix common/ includes.
1614         * amd64-fbsd-tdep.c: Fix common/ includes.
1615         * amd64-fbsd-nat.c: Fix common/ includes.
1616         * amd64-dicos-tdep.c: Fix common/ includes.
1617         * amd64-darwin-tdep.c: Fix common/ includes.
1618         * agent.c: Fix common/ includes.
1619         * ada-lang.h: Fix common/ includes.
1620         * ada-lang.c: Fix common/ includes.
1621         * aarch64-tdep.c: Fix common/ includes.
1622
1623 2019-01-25  Tom Tromey  <tom@tromey.com>
1624
1625         * common/create-version.sh: Use common/version.h.
1626
1627 2019-01-24  Pedro Alves  <palves@redhat.com>
1628
1629         * infrun.c (signal_stop, signal_print, signal_program)
1630         (signal_catch, signal_pass): Now arrays instead of pointers.
1631         (update_signals_program_target, do_target_resume)
1632         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1633         * linux-nat.c (linux_nat_target::pass_signals)
1634         (linux_nat_target::create_inferior, linux_nat_target::attach):
1635         Adjust.
1636         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1637         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1638         * procfs.c (procfs_target::pass_signals): Adjust.
1639         * record-full.c (record_full_target::resume): Adjust.
1640         * remote.c (remote_target::pass_signals)
1641         (remote_target::program_signals): Adjust.
1642         * target-debug.h (target_debug_print_signals): Now takes a
1643         gdb::array_view as parameter.  Adjust.
1644         * target.h (target_ops) <pass_signals, program_signals>: Replace
1645         pointer and length parameters with gdb::array_view.
1646         (target_pass_signals, target_program_signals): Likewise.
1647         * target-delegates.c: Regenerate.
1648
1649 2019-01-24  Pedro Alves  <palves@redhat.com>
1650
1651         * common/forward-scope-exit.h
1652         (forward_scope_exit::forward_scope_exit): Pass arguments to
1653         m_bind_function directly, instead of creating a std::bind and
1654         copying that.
1655
1656 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1657
1658         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1659         for static members.
1660         (pass_in_v_vfp_candidate): Likewise.
1661
1662 2019-01-23  Tom Tromey  <tom@tromey.com>
1663             Pedro Alves  <palves@redhat.com>
1664
1665         * regcache.c (class regcache_invalidator): Remove.
1666         (regcache::raw_write): Use make_scope_exit.
1667
1668 2019-01-23  Tom Tromey  <tom@tromey.com>
1669
1670         * ui-out.h (class ui_out_emit_type): Update comment.
1671
1672 2019-01-23  Tom Tromey  <tom@tromey.com>
1673
1674         * infrun.c (fetch_inferior_event): Update comment.
1675
1676 2019-01-23  Tom Tromey  <tom@tromey.com>
1677             Pedro Alves  <palves@redhat.com>
1678
1679         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1680         parameter.
1681         (fetch_inferior_event): Use SCOPE_EXIT.
1682
1683
1684 2019-01-23  Tom Tromey  <tom@tromey.com>
1685             Pedro Alves  <palves@redhat.com>
1686
1687         * infrun.c (disable_thread_events): Delete.
1688         (stop_all_threads): Use SCOPE_EXIT.
1689
1690 2019-01-23  Tom Tromey  <tom@tromey.com>
1691             Pedro Alves  <palves@redhat.com>
1692
1693         * symfile.c: Include forward-scope-exit.h.
1694         (clear_symtab_users_cleanup): Replace forward declaration with
1695         a FORWARD_SCOPE_EXIT.
1696         (syms_from_objfile_1): Use the forward_scope_exit and
1697         gdb::optional instead of cleanup_function.
1698         (reread_symbols): Use the forward_scope_exit instead of
1699         cleanup_function.
1700         (clear_symtab_users_cleanup): Remove function.
1701
1702 2019-01-23  Tom Tromey  <tom@tromey.com>
1703             Pedro Alves  <palves@redhat.com>
1704
1705         * linux-nat.c: Include scope-exit.h.
1706         (cleanup_target_stop): Remove.
1707         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1708         SCOPE_EXIT.
1709
1710 2019-01-23  Tom Tromey  <tom@tromey.com>
1711             Pedro Alves  <palves@redhat.com>
1712
1713         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1714         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1715
1716 2019-01-23  Tom Tromey  <tom@tromey.com>
1717             Andrew Burgess  <andrew.burgess@embecosm.com>
1718             Pedro Alves  <palves@redhat.com>
1719
1720         * infrun.c (fetch_inferior_event): Use scope_exit.
1721         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1722         * top.c (execute_command): Use scope_exit.
1723         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1724         * utils.c (do_bpstat_clear_actions_cleanup)
1725         (make_bpstat_clear_actions_cleanup): Remove.
1726
1727 2019-01-23  Tom Tromey  <tom@tromey.com>
1728             Pedro Alves  <palves@redhat.com>
1729
1730         * infrun.c: Include "common/scope-exit.h"
1731         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1732         (wait_for_inferior): Use SCOPE_EXIT.
1733         (fetch_inferior_event): Use scope_exit.
1734
1735 2019-01-23  Tom Tromey  <tom@tromey.com>
1736             Pedro Alves  <palves@redhat.com>
1737
1738         * breakpoint.c (create_breakpoint): Remove cleanup.
1739
1740 2019-01-23  Tom Tromey  <tom@tromey.com>
1741             Andrew Burgess  <andrew.burgess@embecosm.com>
1742             Pedro Alves  <palves@redhat.com>
1743
1744 2019-01-23  Pedro Alves  <palves@redhat.com>
1745
1746         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1747
1748 2019-01-23  Pedro Alves  <palves@redhat.com>
1749             Andrew Burgess  <andrew.burgess@embecosm.com>
1750
1751         * gdbthread.h: Include "common/forward-scope-exit.h".
1752         (scoped_finish_thread_state): Redefine custom class in terms of
1753         forward_scope_exit.
1754
1755 2019-01-23  Pedro Alves  <palves@redhat.com>
1756             Andrew Burgess  <andrew.burgess@embecosm.com>
1757
1758         * common/forward-scope-exit.h: New file.
1759
1760 2019-01-23  Pedro Alves  <palves@redhat.com>
1761             Andrew Burgess  <andrew.burgess@embecosm.com>
1762             Tom Tromey  <tom@tromey.com>
1763
1764         * common/scope-exit.h: New file.
1765
1766 2019-01-23  Pedro Alves  <palves@redhat.com>
1767
1768         * common/preprocessor.h (ESC): Rename to ...
1769         (ESC_PARENS): ... this.
1770         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1771         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1772
1773 2019-01-23  Tom Tromey  <tom@tromey.com>
1774
1775         * language.h (class scoped_switch_to_sym_language_if_auto):
1776         Initialize m_lang in both cases.
1777
1778 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1779
1780         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1781         with XCNEW.
1782
1783 2019-01-22  Tom Tromey  <tom@tromey.com>
1784
1785         * corelow.c: Do not include sys/file.h.
1786
1787 2019-01-22  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-wingeneral.h: Include gdb_curses.h.
1790
1791 2019-01-22  Tom Tromey  <tom@tromey.com>
1792
1793         * source-cache.h (class source_cache) <get_source_lines,
1794         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1795
1796 2019-01-22  Tom Tromey  <tom@tromey.com>
1797
1798         * remote-fileio.h (struct remote_target): Declare.
1799
1800 2019-01-22  Tom Tromey  <tom@tromey.com>
1801
1802         * python/py-arch.c: Do not include py-ref.h.
1803         * python/py-bpevent.c: Do not include py-ref.h.
1804         * python/py-cmd.c: Do not include py-ref.h.
1805         * python/py-continueevent.c: Do not include py-ref.h.
1806         * python/py-event.h: Do not include py-ref.h.
1807         * python/py-evtregistry.c: Do not include py-ref.h.
1808         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1809         * python/py-frame.c: Do not include py-ref.h.
1810         * python/py-framefilter.c: Do not include py-ref.h.
1811         * python/py-function.c: Do not include py-ref.h.
1812         * python/py-infevents.c: Do not include py-ref.h.
1813         * python/py-linetable.c: Do not include py-ref.h.
1814         * python/py-objfile.c: Do not include py-ref.h.
1815         * python/py-param.c: Do not include py-ref.h.
1816         * python/py-prettyprint.c: Do not include py-ref.h.
1817         * python/py-progspace.c: Do not include py-ref.h.
1818         * python/py-symbol.c: Do not include py-ref.h.
1819         * python/py-symtab.c: Do not include py-ref.h.
1820         * python/py-type.c: Do not include py-ref.h.
1821         * python/py-unwind.c: Do not include py-ref.h.
1822         * python/py-utils.c: Do not include py-ref.h.
1823         * python/py-value.c: Do not include py-ref.h.
1824         * python/py-varobj.c: Do not include py-ref.h.
1825         * python/py-xmethods.c: Do not include py-ref.h.
1826         * python/python.c: Do not include py-ref.h.
1827         * varobj.c: Do not include py-ref.h.
1828
1829 2019-01-22  Tom Tromey  <tom@tromey.com>
1830
1831         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1832         keyword for bcache.
1833
1834 2019-01-22  Tom Tromey  <tom@tromey.com>
1835
1836         * compile/compile-cplus-types.c: Remove a comment by #include.
1837
1838 2019-01-22  Tom Tromey  <tom@tromey.com>
1839
1840         * compile/gcc-c-plugin.h: Include compile-internal.h.
1841
1842 2019-01-22  Tom Tromey  <tom@tromey.com>
1843
1844         * stabsread.c (EXTERN): Do not define.
1845         (symnum, next_symbol_text_func, processing_gcc_compilation)
1846         (within_function, global_sym_chain, global_stabs)
1847         (previous_stab_code, this_object_header_files)
1848         (n_this_object_header_files)
1849         (n_allocated_this_object_header_files): Define.
1850         * stabsread.h (EXTERN): Never define.  Use "extern".
1851
1852 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1853
1854         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1855         history_value.
1856
1857 2019-01-21  Tom Tromey  <tom@tromey.com>
1858
1859         * ui-out.c: Fix includes.
1860         * tui/tui-source.c: Fix includes.
1861         * target.c: Fix includes.
1862         * remote.c: Fix includes.
1863         * regcache.c: Fix includes.
1864         * python/py-block.c: Fix includes.
1865         * printcmd.c: Fix includes.
1866         * or1k-tdep.c: Fix includes.
1867         * mi/mi-main.c: Fix includes.
1868         * m32r-tdep.c: Fix includes.
1869         * csky-tdep.c: Fix includes.
1870         * compile/compile-cplus-types.c: Fix includes.
1871         * cli/cli-interp.c: Fix includes.
1872
1873 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1874
1875         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1876         for padding.
1877
1878 2019-01-16  Tom Tromey  <tom@tromey.com>
1879
1880         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1881         earlier.
1882         (struct objfile) <msymbols_range>: Move from top level.
1883         <msymbols>: New method.
1884         (class objfile_msymbols): Remove.
1885         * symtab.c (default_collect_symbol_completion_matches_break_on):
1886         Update.
1887         * symmisc.c (dump_msymbols): Update.
1888         * stabsread.c (scan_file_globals): Update.
1889         * objc-lang.c (info_selectors_command, info_classes_command)
1890         (find_methods): Update.
1891         * minsyms.c (find_solib_trampoline_target): Update.
1892         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1893         * coffread.c (coff_symfile_read): Update.
1894         * ada-lang.c (ada_lookup_simple_minsym)
1895         (ada_collect_symbol_completion_matches): Update.
1896
1897 2019-01-16  Tom Tromey  <tom@tromey.com>
1898
1899         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1900         type.  Remove no-argument constructor.
1901         <iterator::operator++>: Simplify.
1902         <begin>: Update.
1903         <end>: Use minimal_symbol_count.
1904
1905 2019-01-16  Tom Tromey  <tom@tromey.com>
1906
1907         * objfiles.h (struct objfile) <psymtabs>: New method.
1908         (class objfile_psymtabs): Remove.
1909         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1910         typedef.
1911         <range>: New method.
1912         (require_partial_symbols): Change return type.
1913         * psymtab.c (require_partial_symbols)
1914         (psym_expand_symtabs_matching): Update.
1915         * mdebugread.c (parse_partial_symbols): Update.
1916         * dbxread.c (dbx_end_psymtab): Update.
1917
1918 2019-01-15  Tom Tromey  <tom@tromey.com>
1919
1920         * symtab.c (lookup_objfile_from_block)
1921         (lookup_symbol_in_objfile_symtabs)
1922         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1923         (find_line_symtab, info_sources_command)
1924         (default_collect_symbol_completion_matches_break_on)
1925         (make_source_files_completion_list): Update.
1926         * symmisc.c (print_objfile_statistics, dump_objfile)
1927         (maintenance_print_symbols, maintenance_info_symtabs)
1928         (maintenance_check_symtabs, maintenance_info_line_tables):
1929         Update.
1930         * source.c (select_source_symtab)
1931         (forget_cached_source_info_for_objfile): Update.
1932         * objfiles.h (class objfile_compunits): Remove.
1933         (struct objfile) <compunits_range>: New typedef.
1934         (compunits): New method.
1935         * objfiles.c (objfile_relocate1): Update.
1936         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1937         * maint.c (count_symtabs_and_blocks): Update.
1938         * linespec.c (iterate_over_all_matching_symtabs): Update.
1939         * cp-support.c (add_symbol_overload_list_qualified): Update.
1940         * coffread.c (coff_symtab_read): Update.
1941         * ada-lang.c (add_nonlocal_symbols)
1942         (ada_collect_symbol_completion_matches)
1943         (ada_add_global_exceptions): Update.
1944
1945 2019-01-15  Tom Tromey  <tom@tromey.com>
1946
1947         * progspace.h (program_space) <objfiles_safe_range>: New
1948         typedef.
1949         <objfiles_safe>: New method.
1950         * objfiles.h (class all_objfiles_safe): Remove.
1951         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1952         * jit.c (jit_inferior_exit_hook): Update.
1953
1954 2019-01-17  Tom Tromey  <tom@tromey.com>
1955
1956         * progspace.h (program_space) <objfiles_range>: New typedef.
1957         <objfiles>: New method.
1958         <objfiles_head>: Rename from objfiles.
1959         (object_files): Update.
1960         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1961         * guile/scm-pretty-print.c
1962         (ppscm_find_pretty_printer_from_objfiles): Update.
1963         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1964         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1965         Update.
1966         * python/py-progspace.c (pspy_get_objfiles): Update.
1967         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1968         Update.
1969         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1970         (objfpy_lookup_objfile_by_build_id): Update.
1971         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1972         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1973         Update.
1974         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1975         (expand_symtab_containing_pc, lookup_objfile_from_block)
1976         (lookup_static_symbol, basic_lookup_transparent_type)
1977         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1978         (find_line_symtab, info_sources_command)
1979         (default_collect_symbol_completion_matches_break_on)
1980         (make_source_files_completion_list, find_main_name): Update.
1981         * symmisc.c (print_symbol_bcache_statistics)
1982         (print_objfile_statistics, maintenance_print_symbols)
1983         (maintenance_print_msymbols, maintenance_print_objfiles)
1984         (maintenance_info_symtabs, maintenance_check_symtabs)
1985         (maintenance_expand_symtabs, maintenance_info_line_tables):
1986         Update.
1987         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1988         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1989         (map_overlay_command, unmap_overlay_command)
1990         (simple_overlay_update, expand_symtabs_matching)
1991         (map_symbol_filenames): Update.
1992         * symfile-debug.c (set_debug_symfile): Update.
1993         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1994         Update.
1995         * source.c (select_source_symtab, forget_cached_source_info):
1996         Update.
1997         * solib.c (solib_read_symbols): Update.
1998         * solib-spu.c (append_ocl_sos): Update.
1999         * psymtab.c (maintenance_print_psymbols)
2000         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2001         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2002         * printcmd.c (info_symbol_command): Update.
2003         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2004         Update.
2005         * objfiles.h (class all_objfiles): Remove.
2006         * objfiles.c (have_partial_symbols, have_full_symbols)
2007         (have_minimal_symbols, qsort_cmp, update_section_map)
2008         (shared_objfile_contains_address_p)
2009         (default_iterate_over_objfiles_in_search_order): Update.
2010         * objc-lang.c (info_selectors_command, info_classes_command)
2011         (find_methods): Update.
2012         * minsyms.c (find_solib_trampoline_target): Update.
2013         * maint.c (maintenance_info_sections)
2014         (maintenance_translate_address, count_symtabs_and_blocks):
2015         Update.
2016         * main.c (captured_main_1): Update.
2017         * linux-thread-db.c (try_thread_db_load_from_pdir)
2018         (has_libpthread): Update.
2019         * linespec.c (iterate_over_all_matching_symtabs)
2020         (search_minsyms_for_name): Update.
2021         * jit.c (jit_find_objf_with_entry_addr): Update.
2022         * hppa-tdep.c (find_unwind_entry)
2023         (hppa_lookup_stub_minimal_symbol): Update.
2024         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2025         Update.
2026         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2027         (elf_gnu_ifunc_resolve_by_got): Update.
2028         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2029         * dwarf-index-write.c (save_gdb_index_command): Update.
2030         * cp-support.c (add_symbol_overload_list_qualified): Update.
2031         * breakpoint.c (create_overlay_event_breakpoint)
2032         (create_longjmp_master_breakpoint)
2033         (create_std_terminate_master_breakpoint)
2034         (create_exception_master_breakpoint): Update.
2035         * blockframe.c (find_pc_partial_function): Update.
2036         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2037         (ada_collect_symbol_completion_matches)
2038         (ada_add_global_exceptions): Update.
2039
2040 2019-01-17  Tom Tromey  <tom@tromey.com>
2041
2042         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2043         declare VEC.
2044         (solib_target_parse_libraries): Change return type.
2045         (library_list_start_segment, library_list_start_section)
2046         (library_list_end_library, library_list_start_library); Update.
2047         (solib_target_free_library_list): Remove.
2048         (solib_target_parse_libraries): Remove cleanup.  Change return
2049         type.
2050         (solib_target_current_sos): Update.
2051
2052 2019-01-17  Tom Tromey  <tromey@bapiya>
2053
2054         * valprint.c: Replace "the the" with "the".
2055         * symtab.c: Replace "the the" with "the".
2056         * solib.c: Replace "the the" with "the".
2057         * solib-dsbt.c: Replace "the the" with "the".
2058         * linespec.c: Replace "the the" with "the".
2059         * dwarf2loc.h: Replace "the the" with "the".
2060         * amd64-windows-tdep.c: Replace "the the" with "the".
2061         * aarch64-tdep.c: Replace "the the" with "the".
2062
2063 2019-01-16  Keith Seitz  <keiths@redhat.com>
2064
2065         PR gdb/23773
2066         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2067         <builder>: Rename to ..
2068         <m_builder>: ... this and make private.
2069         (dwarf2_cu::get_builder): New method.  Change all users of
2070         `builder' to use this method.
2071         (dwarf2_start_symtab): Move to ...
2072         (dwarf2_cu::start_symtab): ... here.  Update all callers
2073         (setup_type_unit_groups): Move to ...
2074         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2075         callers.
2076         (dwarf2_cu::reset_builder): New method.
2077         (process_full_compunit, process_full_type_unit): Use
2078         dwarf2_cu::reset_builder.
2079         (follow_die_offset): Record the ancestor CU if it is different
2080         from the followed DIE's CU.
2081         (follow_die_sig_1): Likewise.
2082
2083 2019-01-15  Tom Tromey  <tom@tromey.com>
2084
2085         * remote.c (class remote_state) <buf>: Now a char_vector.
2086         <buf_size>: Remove.
2087         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2088         parameter.
2089         (remote_target::getpkt_or_notif_sane_1)
2090         (remote_target::getpkt_sane)
2091         (remote_target::getpkt_or_notif_sane): Likewise.
2092         (class remote_target) <putpkt>: New overload.
2093         (remote_target::read_frame): Change type of "buf_p".  Remove
2094         sizeof_p parameter.
2095         (packet_ok): New overload.
2096         (packet_check_result): New overload.
2097         Update all uses.
2098
2099 2019-01-14  Tom Tromey  <tom@tromey.com>
2100
2101         * remote-notif.c (handle_notification, remote_notif_ack)
2102         (remote_notif_parse): Make "buf" const.
2103         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2104         const.
2105         (remote_notif_parse, remote_notif_ack, handle_notification):
2106         Likewise.
2107         * remote.c (remote_notif_stop_parse): Make "buf" const.
2108         (remote_target::remote_parse_stop_reply): Make "buf" const.
2109         (remote_notif_stop_ack): Make "buf" const.
2110
2111 2019-01-14  Tom Tromey  <tom@tromey.com>
2112
2113         * remote.c (remote_console_output): Make parameter const.
2114
2115 2019-01-14  Tom Tromey  <tom@tromey.com>
2116
2117         * target-debug.h (target_debug_print_signals): Constify.
2118         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2119         * procfs.c (procfs_target::pass_signals): Update.
2120         * linux-nat.c (linux_nat_target::pass_signals): Update.
2121         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2122         * target-delegates.c: Rebuild.
2123         * remote.c (remote_target::program_signals): Update.
2124         (remote_target::pass_signals): Update.
2125         * target.c (target_pass_signals): Constify argument.
2126         (target_program_signals): Likewise.
2127         * target.h (struct target_ops) <pass_signals, program_signals>:
2128         Constify argument.
2129         (target_pass_signals, target_program_signals): Constify argument.
2130
2131 2019-01-14  Tom Tromey  <tom@tromey.com>
2132
2133         PR tui/28819:
2134         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2135
2136 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2137
2138         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2139         field.
2140         * rs6000-tdep.c: Include reggroups.h.
2141         (IS_V_ALIAS_PSEUDOREG): Define.
2142         (rs6000_register_name): Return names for the "vX" aliases.
2143         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2144         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2145         aliases.  Call default_register_reggroup_p for all other
2146         pseudo-registers.
2147         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2148         New functions.
2149         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2150         Handle "vX" aliases.
2151         (v_alias_pseudo_register_collect): New function.
2152         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2153         (rs6000_gdbarch_init): Initialize "vX" aliases as
2154         pseudo-registers.  Restore registration of
2155         rs6000_pseudo_register_reggroup_p with
2156         set_tdesc_pseudo_register_reggroup_p.
2157
2158 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2159
2160         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2161         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2162         set_gdbarch_num_pseudo_regs.
2163
2164 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2165
2166         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2167         Remove arg prefixname, add do_set and do_show.
2168         Add member functions set_list and show_list.
2169         * cli/cli-style.c (class cli_style_option): Update accordingly.
2170         (style_set_list): Move to file scope.
2171         (style_show_list): Likewise.
2172         (set_style): Call help_list.
2173         (show_style): Call cmd_show_list.
2174         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2175         Update to use the new macro.
2176
2177 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2178
2179         * ada-lang.c (_initialize_ada_language): Expand the help text
2180         for the "catch exception" command.
2181
2182 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2183
2184         * symtab.c (matching_obj_sections): Initialize obj,
2185         declare it closer to its usage.
2186
2187 2019-01-10  Tom Tromey  <tom@tromey.com>
2188
2189         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2190         (basic_inf_threads_range): Remove.
2191         (inf_threads_range, inf_non_exited_threads_range)
2192         (safe_inf_threads_range): Use next_adapter.
2193
2194 2019-01-10  Keith Seitz  <keiths@redhat.com>
2195
2196         PR gdb/23712
2197         PR symtab/23010
2198         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2199         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2200
2201 2019-01-10  Keith Seitz  <keiths@redhat.com>
2202
2203         PR gdb/23712
2204         PR symtab/23010
2205         * dictionary.c (pending_to_vector): Remove.
2206         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2207         Remove _1 suffix, replacing functions of the same name.  Update
2208         all callers.
2209         (dict_create_hashed, dict_create_hashed_expandable)
2210         (dict_create_linear, dict_create_linear_expandable, dict_free)
2211         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2212         Make functions static.
2213
2214 2019-01-10  Keith Seitz  <keiths@redhat.com>
2215
2216         PR gdb/23712
2217         PR symtab/23010
2218         * dictionary.h (struct dictionary): Replace declaration with
2219         multidictionary.
2220         (dict_create_hashed, dict_create_hashed_expandable)
2221         (dict_create_linear, dict_create_linear_expandable)
2222         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2223         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2224         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2225         taking multidictionary argument.
2226         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2227         * block.h (struct block) <dict>: Change to multidictionary
2228         and rename `multidict'.
2229         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2230         symmisc.c: Update all dictionary references to multidictionary.
2231
2232 2019-01-10  Keith Seitz  <keiths@redhat.com>
2233
2234         PR gdb/23712
2235         PR symtab/23010
2236         * dictionary.c: Include unordered_map.
2237         (pending_to_vector): New function.
2238         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2239         Rewrite the non-"_1" functions to take vector instead
2240         of linked list.
2241         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2242         "new" _1 versions of the same name.
2243         (multidictionary): Define.
2244         (std::hash<enum language): New definition.
2245         (collate_pending_symbols_by_language, mdict_create_hashed)
2246         (mdict_create_hashed_expandable, mdict_create_linear)
2247         (mdict_create_linear_expandable, mdict_free)
2248         (find_language_dictionary, create_new_language_dictionary)
2249         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2250         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2251         (mdict_size, mdict_empty): New functions.
2252         * dictionary.h (mdict_iterator): Define.
2253
2254 2019-01-10  Pedro Alves  <palves@redhat.com>
2255
2256         * breakpoint.c (read_uploaded_action)
2257         (create_tracepoint_from_upload): Adjust to use
2258         gdb::unique_xmalloc_ptr.
2259         * ctf.c (ctf_write_uploaded_tp):
2260         (SET_ARRAY_FIELD): Use emplace_back.
2261         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2262         * tracefile-tfile.c (tfile_write_uploaded_tp):
2263         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2264         gdb::unique_xmalloc_ptr.
2265         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2266         at_string, cond_string, cmd_strings>: Replace char pointers
2267         with gdb::unique_xmalloc_ptr.
2268
2269 2019-01-10  Pedro Alves  <palves@redhat.com>
2270
2271         * solib-target.c (library_list_start_library): Don't xstrdup name.
2272
2273 2019-01-10  Pedro Alves  <palves@redhat.com>
2274
2275         * mdebugread.c (parse_partial_symbols): Use
2276         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2277
2278 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2279
2280         * linux-fork.c (scoped_switch_fork_info)
2281         <~scoped_switch_fork_info>: Fix incorrect variable name.
2282
2283 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2284
2285         * linux-fork.c (scoped_switch_fork_info)
2286         <scoped_switch_fork_info>: Make explicit.
2287         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2288
2289 2019-01-10  Tom Tromey  <tom@tromey.com>
2290
2291         * objfiles.h (objfile::reset_psymtabs): Update.
2292         * objfiles.c (objfile::objfile): Update.
2293         * psymtab.h (psymtab_storage::obstack): Update.
2294         (psymtab_storage::m_obstack): Use gdb::optional.
2295         (class psymtab_storage): Update comment.  Remove objfile
2296         parameter.
2297         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2298
2299 2019-01-10  Tom Tromey  <tom@tromey.com>
2300
2301         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2302         <free_psymtabs>: Now private.
2303         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2304         (allocate_psymtab): Use new method.
2305
2306 2019-01-10  Tom Tromey  <tom@tromey.com>
2307
2308         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2309         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2310         * mdebugread.c (parse_partial_symbols): Use
2311         allocate_dependencies.
2312         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2313         allocate_dependencies.
2314         (process_psymtab_comp_unit_reader)
2315         (build_type_psymtab_dependencies): Likewise.
2316         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2317
2318 2019-01-10  Tom Tromey  <tom@tromey.com>
2319
2320         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2321         PSYMBOL_SET_LANGUAGE.
2322         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2323
2324 2019-01-10  Tom Tromey  <tom@tromey.com>
2325
2326         * psymtab.h (psymtab_storage::obstack): New method.
2327         <m_obstack>: Rename from obstack; now private.
2328         * psymtab.c (psymtab_storage): Update.
2329         * dwarf2read.c (create_addrmap_from_index)
2330         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2331         Update.
2332
2333 2019-01-10  Tom Tromey  <tom@tromey.com>
2334
2335         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2336         * objfiles.h (objfile::reset_psymtabs): New method.
2337
2338 2019-01-10  Tom Tromey  <tom@tromey.com>
2339
2340         * symmisc.c (print_symbol_bcache_statistics): Update.
2341         (print_objfile_statistics): Update.
2342         * symfile.c (reread_symbols): Update.
2343         * psymtab.h (class psymtab_storage): New.
2344         * psymtab.c (psymtab_storage): New constructor.
2345         (~psymtab_storage): New destructor.
2346         (require_partial_symbols): Update.
2347         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2348         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2349         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2350         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2351         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2352         (start_psymtab_common, end_psymtab_common)
2353         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2354         (allocate_psymtab): Update.
2355         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2356         Update.
2357         (dump_psymtab_addrmap, maintenance_print_psymbols)
2358         (maintenance_check_psymtabs): Update.
2359         (class objfile_psymtabs): Move to objfiles.h.
2360         * psympriv.h (discard_psymtab): Now inline.
2361         (psymtab_discarder::psymtab_discarder): Update.
2362         (psymtab_discarder::~psymtab_discarder): Update.
2363         (ALL_OBJFILE_PSYMTABS): Rewrite.
2364         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2365         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2366         Remove fields.
2367         <partial_symtabs>: New field.
2368         (class objfile_psymtabs): Move from psymtab.h.  Update.
2369         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2370         psymbol_cache.
2371         (objfile::~objfile): Don't destroy psymbol_cache.
2372         * mdebugread.c (parse_partial_symbols): Update.
2373         * dwarf2read.c (create_addrmap_from_index)
2374         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2375         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2376         (add_partial_subprogram, dwarf2_ranges_read): Update.
2377         * dwarf-index-write.c (write_address_map)
2378         (write_one_signatured_type, recursively_write_psymbols)
2379         (class debug_names, class debug_names, write_psymtabs_to_index):
2380         Update.
2381
2382 2019-01-10  Tom Tromey  <tom@tromey.com>
2383
2384         * symtab.h (SYMBOL_SET_NAMES): Update.
2385         (symbol_set_names): Update.
2386         (MSYMBOL_SET_NAMES): Update.
2387         * symtab.c (symbol_set_names): Change argument to be an
2388         objfile_per_bfd_storage.
2389         * psymtab.c (add_psymbol_to_bcache): Update.
2390         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2391
2392 2019-01-10  Tom Tromey  <tom@tromey.com>
2393
2394         * symtab.c (create_demangled_names_hash): Change argument to be an
2395         objfile_per_bfd_storage.
2396         (symbol_set_names): Update.
2397
2398 2019-01-10  Tom Tromey  <tom@tromey.com>
2399
2400         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2401         init_psymbol_list.
2402         * psymtab.c (init_psymbol_list): Do nothing if already called.
2403         * psympriv.h (init_psymbol_list): Add comment.
2404         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2405         init_psymbol_list.
2406         * dbxread.c (dbx_symfile_read): Unconditionally call
2407         init_psymbol_list.
2408
2409 2019-01-10  Tom Tromey  <tom@tromey.com>
2410
2411         * xcoffread.c (scan_xcoff_symtab): Update.
2412         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2413         "where".
2414         * mdebugread.c (parse_partial_symbols)
2415         (handle_psymbol_enumerators): Update.
2416         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2417         * dbxread.c (read_dbx_symtab): Update.
2418         * psympriv.h (psymbol_placement): New enum.
2419         (add_psymbol_to_list): Update.
2420
2421 2019-01-10  Tom Tromey  <tom@tromey.com>
2422
2423         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2424         static_psymbols parameters.
2425         (scan_xcoff_symtab): Update.
2426         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2427         static_psymbols parameters.
2428         * psympriv.h (start_psymtab_common): Update.
2429         * mdebugread.c (parse_partial_symbols): Update.
2430         * dwarf2read.c (create_partial_symtab): Update.
2431         * dbxread.c (read_dbx_symtab): Update.
2432         (start_psymtab): Remove global_psymbols and static_psymbols
2433         parameters.
2434
2435 2019-01-10  Tom Tromey  <tom@tromey.com>
2436
2437         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2438         * psymtab.c (allocate_psymtab): Add comment.
2439         * psympriv.h (allocate_psymtab): Add comment.
2440         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2441         initializations.
2442         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2443
2444 2019-01-10  Tom Tromey  <tom@tromey.com>
2445
2446         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2447         Don't declare.
2448         * mipsread.c: Include mdebugread.h.
2449         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2450         Declare.
2451         * elfread.c: Include mdebugread.h.
2452
2453 2019-01-09  Tom Tromey  <tom@tromey.com>
2454
2455         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2456         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2457         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2458         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2459         (psym_lookup_symbol, psym_find_last_source_symtab)
2460         (psym_forget_cached_source_info, psym_print_stats)
2461         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2462         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2463         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2464         (psym_find_compunit_symtab_by_address)
2465         (maintenance_print_psymbols, maintenance_info_psymtabs)
2466         (maintenance_check_psymtabs): Use ranged for.
2467         * psymtab.h (class objfile_psymtabs): New.
2468         (require_partial_symbols): Return objfile_psymtabs.
2469         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2470
2471 2019-01-09  Tom Tromey  <tom@tromey.com>
2472
2473         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2474         (find_pc_mapped_section, list_overlays_command)
2475         (map_overlay_command, unmap_overlay_command)
2476         (simple_overlay_update): Use all_objfiles.
2477         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2478         * printcmd.c (info_symbol_command): Use all_objfiles.
2479         * objfiles.h (ALL_OBJSECTIONS): Remove.
2480         * maint.c (maintenance_translate_address): Use all_objfiles.
2481         * gcore.c (gcore_create_callback): Use all_objfiles.
2482         (objfile_find_memory_regions): Likewise.
2483
2484 2019-01-09  Tom Tromey  <tom@tromey.com>
2485
2486         * symtab.c (find_line_symtab, info_sources_command)
2487         (make_source_files_completion_list): Use objfile_compunits.
2488         * source.c (select_source_symtab): Use objfile_compunits.
2489         * objfiles.h (struct objfile): Update comment.
2490         (ALL_OBJFILES): Remove.
2491         (ALL_FILETABS): Remove.
2492         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2493         objfile_compunits.
2494
2495 2019-01-09  Tom Tromey  <tom@tromey.com>
2496
2497         * symmisc.c (print_objfile_statistics, dump_objfile)
2498         (maintenance_print_symbols): Use compunit_filetabs.
2499         * source.c (forget_cached_source_info_for_objfile): Use
2500         compunit_filetabs.
2501         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2502         (ALL_FILETABS): Use compunit_filetabs.
2503         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2504         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2505
2506 2019-01-09  Tom Tromey  <tom@tromey.com>
2507
2508         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2509         (compunit_filetabs): New.
2510         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2511         compunit_filetabs.
2512         (info_sources_command, make_source_files_completion_list): Remove
2513         declaration.
2514         * symmisc.c (print_objfile_statistics, dump_objfile)
2515         (maintenance_print_symbols): Remove declaration.
2516         (maintenance_info_symtabs): Use compunit_filetabs.
2517         (maintenance_info_line_tables): Likewise.
2518         * source.c (select_source_symtab): Change local variable name.
2519         (forget_cached_source_info_for_objfile): Remove declaration.
2520         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2521         * objfiles.c (objfile_relocate1): Remove declaration.
2522         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2523         declaration.
2524         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2525         * coffread.c (coff_symtab_read): Remove declaration.
2526         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2527         compunit_filetabs.
2528
2529 2019-01-09  Tom Tromey  <tom@tromey.com>
2530
2531         * symtab.c (lookup_objfile_from_block)
2532         (find_pc_sect_compunit_symtab, search_symbols)
2533         (default_collect_symbol_completion_matches_break_on): Use
2534         objfile_compunits.
2535         * objfiles.h (ALL_COMPUNITS): Remove.
2536         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2537         * cp-support.c (add_symbol_overload_list_qualified): Use
2538         objfile_compunits.
2539         * ada-lang.c (ada_collect_symbol_completion_matches)
2540         (ada_add_global_exceptions): Use objfile_compunits.
2541
2542 2019-01-09  Tom Tromey  <tom@tromey.com>
2543
2544         * source.c (select_source_symtab)
2545         (forget_cached_source_info_for_objfile): Remove declaration.
2546         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2547         declaration.
2548         * maint.c (count_symtabs_and_blocks): Remove declaration.
2549         * cp-support.c (add_symbol_overload_list_qualified): Remove
2550         declaration.
2551         * coffread.c (coff_symtab_read): Remove declaration.
2552         * symtab.c (lookup_symbol_in_objfile_symtabs)
2553         (basic_lookup_transparent_type_1): Use objfile_compunits.
2554         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2555         (info_sources_command, search_symbols)
2556         (default_collect_symbol_completion_matches_break_on)
2557         (make_source_files_completion_list): Remove declaration.
2558         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2559         (ada_collect_symbol_completion_matches)
2560         (ada_add_global_exceptions): Remove declaration.
2561         * linespec.c (iterate_over_all_matching_symtabs): Use
2562         objfile_compunits.
2563         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2564         (class objfile_compunits): New.
2565         (ALL_COMPUNITS): Use objfile_compunits.
2566         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2567         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2568         objfile_compunits.
2569         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2570
2571 2019-01-09  Tom Tromey  <tom@tromey.com>
2572
2573         * symtab.c (search_symbols)
2574         (default_collect_symbol_completion_matches_break_on): Use
2575         objfile_msymbols.
2576         * ada-lang.c (ada_lookup_simple_minsym)
2577         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2578         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2579         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2580         objfile_msymbols.
2581         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2582         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2583         * objc-lang.c (find_methods): Use objfile_msymbols.
2584         (info_selectors_command, info_classes_command): Likewise.
2585         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2586         * objfiles.h (class objfile_msymbols): New.
2587         (ALL_OBJFILE_MSYMBOLS): Remove.
2588         (ALL_MSYMBOLS): Remove.
2589
2590 2019-01-09  Tom Tromey  <tom@tromey.com>
2591
2592         * common/next-iterator.h (next_adapter): Add Iterator template
2593         parameter.
2594         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2595         (class all_objfiles_safe): New.
2596         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2597         * objfiles.c (put_objfile_before): Update comment.
2598         (add_separate_debug_objfile): Likewise.
2599         (free_all_objfiles): Use all_objfiles_safe.
2600         (objfile_purge_solibs): Likewise.
2601
2602 2019-01-09  Tom Tromey  <tom@tromey.com>
2603
2604         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2605         (expand_symtab_containing_pc, lookup_static_symbol)
2606         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2607         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2608         all_objfiles.
2609         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2610         * breakpoint.c (create_overlay_event_breakpoint)
2611         (create_longjmp_master_breakpoint)
2612         (create_std_terminate_master_breakpoint)
2613         (create_exception_master_breakpoint): Use all_objfiles.
2614         * linux-thread-db.c (try_thread_db_load_from_pdir)
2615         (has_libpthread): Use all_objfiles.
2616         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2617         * linespec.c (iterate_over_all_matching_symtabs)
2618         (search_minsyms_for_name): Use all_objfiles.
2619         * maint.c (maintenance_info_sections): Use all_objfiles.
2620         * main.c (captured_main_1): Use all_objfiles.
2621         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2622         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2623         * guile/scm-pretty-print.c
2624         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2625         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2626         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2627         (maintenance_print_msymbols): Use all_objfiles.
2628         * source.c (select_source_symtab): Use all_objfiles.
2629         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2630         * symfile.c (remove_symbol_file_command)
2631         (expand_symtabs_matching, map_symbol_filenames): Use
2632         all_objfiles.
2633         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2634         all_objfiles.
2635         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2636         * objc-lang.c (find_methods): Use all_objfiles.
2637         * objfiles.c (have_partial_symbols, have_full_symbols)
2638         (have_minimal_symbols, qsort_cmp)
2639         (default_iterate_over_objfiles_in_search_order): Use
2640         all_objfiles.
2641         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2642         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2643         (maintenance_check_psymtabs): Use all_objfiles.
2644         (ALL_PSYMTABS): Remove.
2645         * compile/compile-object-run.c (do_module_cleanup): Use
2646         all_objfiles.
2647         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2648         * cp-support.c (add_symbol_overload_list_qualified): Use
2649         all_objfiles.
2650         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2651         Use all_objfiles.
2652         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2653         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2654         all_objfiles.
2655         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2656         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2657         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2658         Uses all_objfiles.
2659         * solib.c (solib_read_symbols): Use all_objfiles
2660
2661 2019-01-09  Tom Tromey  <tom@tromey.com>
2662
2663         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2664         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2665         all_objfiles.
2666         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2667         * symmisc.c (print_symbol_bcache_statistics)
2668         (print_objfile_statistics, maintenance_print_objfiles)
2669         (maintenance_info_symtabs, maintenance_check_symtabs)
2670         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2671         all_objfiles.
2672         * source.c (forget_cached_source_info): Use all_objfiles.
2673         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2674         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2675         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2676         * objfiles.c (update_section_map): Use all_objfiles.
2677         (shared_objfile_contains_address_p): Likewise.
2678         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2679         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2680
2681 2019-01-09  Tom Tromey  <tom@tromey.com>
2682
2683         * common/next-iterator.h: New file.
2684         * objfiles.h (class all_objfiles): New.
2685         (struct objfile_iterator): New.
2686
2687 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2688
2689         * NEWS: Move the description of the changed "frame", "select-frame",
2690          and "info frame" commands to the Changed commands section.
2691
2692 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2693
2694         * gdbtypes.c (check_stub_method_group): Remove handling of old
2695         mangling schemes.
2696         * linespec.c (find_methods): Likewise.
2697         * stabsread.c (read_member_functions): Likewise.
2698         * valops.c (search_struct_method): Likewise.
2699         (value_struct_elt_for_reference): Likewise.
2700         * NEWS: Mention this change.
2701
2702 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2703
2704         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2705         print_source_lines.
2706         * source.c (print_source_lines_base): Update line number check.
2707         (print_source_lines): New function.
2708         (source_lines_range::source_lines_range): New function.
2709         * source.h (class source_lines_range): New class.
2710         (print_source_lines): New declaration.
2711
2712 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2713
2714         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2715
2716 2019-01-08  Tom Tromey  <tom@tromey.com>
2717             Simon Marchi  <simon.marchi@ericsson.com>
2718
2719         PR gdb/24060
2720         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2721         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2722         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2723         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2724         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2725         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2726
2727 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2728
2729         * source.c (select_source_symtab): Move header comment to
2730         declaration in source.h.
2731         (forget_cached_source_info_for_objfile): Likewise.
2732         (forget_cached_source_info): Likewise.
2733         (identify_source_line): Likewise.
2734         * source.h (identify_source_line): Move declaration from symtab.h
2735         and add comment from source.c
2736         (print_source_lines): Likewise.
2737         (forget_cached_source_info_for_objfile): Likewise.
2738         (forget_cached_source_info): Likewise.
2739         (select_source_symtab): Likewise.
2740         (enum print_source_lines_flag): Move definition from symtab.h.
2741         * symtab.h (identify_source_line): Move declaration to source.h.
2742         (print_source_lines): Likewise.
2743         (forget_cached_source_info_for_objfile): Likewise.
2744         (forget_cached_source_info): Likewise.
2745         (select_source_symtab): Likewise.
2746         (enum print_source_lines_flag): Move definition to source.h.
2747         * tui/tui-hooks.c: Add 'source.h' include.
2748
2749 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2750
2751         * source.c (print_source_lines_base): Handle requests to print
2752         reverse line number sequences, and guard against empty lines
2753         string.
2754
2755 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2756
2757         * source.c (print_source_lines_base): Fix skip of '\r' if next
2758         character is '\n'.
2759
2760 2019-01-06  Tom Tromey  <tom@tromey.com>
2761
2762         * c-exp.y (struct c_parse_state) <macro_original_text,
2763         expansion_obstack>: New member.
2764         (macro_original_text, expansion_obstack): Remove globals.
2765         (scan_macro_expansion, scanning_macro_expansion)
2766         (finished_macro_expansion): Update.
2767         (scan_macro_cleanup): Remove.
2768         (yylex, c_parse): Update.
2769
2770 2019-01-06  Tom Tromey  <tom@tromey.com>
2771
2772         * c-exp.y (struct c_parse_state) <strings>: New member.
2773         (operator_stoken): Update.
2774
2775 2019-01-06  Tom Tromey  <tom@tromey.com>
2776
2777         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2778         (union type_stack_elt) <typelist_val>: Now a pointer to
2779         std::vector.
2780         (type_stack_cleanup): Don't declare.
2781         (push_typelist): Update.
2782         * parse.c (pop_typelist): Return a std::vector.
2783         (push_typelist): Take a std::vector.
2784         (follow_types): Update.  Do not free args.
2785         (type_stack_cleanup): Remove.
2786         * c-exp.y (struct c_parse_state): New.
2787         (cpstate): New global.
2788         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2789         (nonempty_typelist): Update.
2790         (func_mod): Create a new vector.
2791         (c_parse): Create a c_parse_state.
2792         (check_parameter_typelist): Do not delete params.
2793         (function_method): Update.  Do not delete type_list.
2794
2795 2019-01-06  Tom Tromey  <tom@tromey.com>
2796
2797         PR gdb/28155:
2798         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2799         check_typedef.
2800         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2801         (print_return_value): Likewise.
2802
2803 2019-01-05  Tom Tromey  <tom@tromey.com>
2804
2805         * contrib/cleanup_check.py: Remove.
2806         * contrib/gcc-with-excheck: Remove.
2807         * contrib/exsummary.py: Remove.
2808         * contrib/excheck.py: Remove.
2809
2810 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2811
2812         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2813         NULL. Initialize tpprev to NULL instead of assigning it
2814         to NULL on the next statement.
2815         * windows-nat.c (windows_delete_thread): Remove check for
2816         main_thread_id before printing thread exit notifications.
2817         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2818         Remove thread ID check against main_thread_id.
2819         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2820         windows_delete_thread.
2821         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2822
2823 2019-01-04  Tom Tromey  <tom@tromey.com>
2824
2825         * compile/compile.c (_initialize_compile): Use upper case for
2826         metasyntactic variables.
2827         * symmisc.c (_initialize_symmisc): Use upper case for
2828         metasyntactic variables.
2829         * psymtab.c (_initialize_psymtab): Use upper case for
2830         metasyntactic variables.
2831         * demangle.c (demangle_command): Use upper case for metasyntactic
2832         variables.
2833         (_initialize_demangler): Likewise.
2834         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2835         variables.
2836
2837 2019-01-03  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2840
2841 2019-01-03  Tom Tromey  <tom@tromey.com>
2842
2843         * python/py-symtab.c (salpy_str): Update.
2844         (struct salpy_sal_object) <symtab>: Now a PyObject.
2845         (salpy_dealloc): Update.
2846         (del_objfile_sal): Use gdbpy_ref.
2847
2848 2019-01-03  Tom Tromey  <tom@tromey.com>
2849
2850         * python/py-type.c (convert_field): Use new_reference.  Return
2851         gdbpy_ref.
2852         (make_fielditem): Return gdbpy_ref.
2853         (typy_fields): Update.
2854         (typy_getitem): Update.
2855         (field_name): Return gdbpy_ref.  Use new_reference.
2856         (typy_iterator_iternext): Update.
2857
2858 2019-01-03  Tom Tromey  <tom@tromey.com>
2859
2860         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2861
2862 2019-01-03  Tom Tromey  <tom@tromey.com>
2863
2864         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2865         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2866         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2867         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2868         (pspy_set_type_printers): Likewise.
2869         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2870         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2871         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2872         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2873         (objfpy_set_type_printers): Likewise.
2874
2875 2019-01-03  Tom Tromey  <tom@tromey.com>
2876
2877         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2878         (gdbpy_print_stack): Use gdbpy_err_fetch.
2879         * python/python-internal.h (class gdbpy_err_fetch): New class.
2880         (class gdbpy_enter) <m_error_type, m_error_value,
2881         m_error_traceback>: Remove.
2882         <m_error>: New member.
2883         (gdbpy_exception_to_string): Don't declare.
2884         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2885         * python/py-value.c (convert_value_from_python): Use
2886         gdbpy_err_fetch.
2887         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2888         gdbpy_exception_to_string.
2889         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2890         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2891         gdbpy_err_fetch.
2892
2893 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2894
2895         * linux-nat.c (delete_lwp_cleanup): Delete.
2896         (struct lwp_deleter): New struct.
2897         (lwp_info_up): New typedef.
2898         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2899         lwp_info_up.
2900
2901 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2902
2903         * linux-fork.c (class scoped_switch_fork_info): New class.
2904         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2905
2906 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2907
2908         * valops.c (find_overload_match): Remove use of null_cleanup, and
2909         calls to do_cleanups.
2910
2911 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2912
2913         * compile/compile-cplus-types.c
2914         (compile_cplus_instance::decl_name): Handle changes to
2915         cp_func_name.
2916         * cp-support.c (cp_func_name): Update header comment, update
2917         return type.
2918         * cp-support.h (cp_func_name): Update return type in declaration.
2919         * valops.c (find_overload_match): Move temp_func local to top
2920         level of function and change its type.  Use temp_func to hold and
2921         delete temporary string obtained from cp_func_name.
2922
2923 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2924
2925         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2926         gdb::char_vector, remove cleanup, and update uses of `msg`.
2927
2928 2019-01-03  Jim Wilson  <jimw@sifive.com>
2929
2930         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2931
2932 2019-01-02  Tom Tromey  <tom@tromey.com>
2933
2934         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2935         (tdesc_parse_xml): Remove cleanups.
2936         * target-descriptions.h (make_cleanup_free_target_description):
2937         Don't declare.
2938         (target_desc_deleter): New struct.
2939         (target_desc_up): New typedef.
2940         * target-descriptions.c (target_desc_deleter::operator()): Rename
2941         from free_target_description.
2942         (make_cleanup_free_target_description): Remove.
2943
2944 2019-01-02  Tom Tromey  <tom@tromey.com>
2945
2946         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2947         constructor, destructor.
2948         (linespec_parser): Remove typedef.
2949         (~linespec_parser): Rename from linespec_parser_delete.
2950         (linespec_lex_to_end, linespec_complete_label)
2951         (linespec_complete): Update.
2952         (decode_line_full): Remove cleanups.
2953         (decode_line_1): Update.
2954
2955 2019-01-02  Tom Tromey  <tom@tromey.com>
2956
2957         * python/python-internal.h (inferior_to_inferior_object): Change
2958         return type.
2959         * python/py-exitedevent.c (create_exited_event_object): Update.
2960         * python/py-inferior.c (inferior_to_inferior_object): Return
2961         gdbpy_ref.
2962         (python_new_inferior, python_inferior_deleted)
2963         (thread_to_thread_object, delete_thread_object)
2964         (build_inferior_list, gdbpy_selected_inferior): Update.
2965         * python/py-infthread.c (create_thread_object): Update.  Also fail
2966         if inferior_to_inferior_object fails.
2967
2968 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2969
2970         * inferior.h (class inferior) <displaced_step_state>: New field.
2971         * infrun.h (struct displaced_step_state): Move here from
2972         infrun.c.  Initialize fields, add constructor.
2973         <inf>: Remove field.
2974         <reset>: New method.
2975         * infrun.c (struct displaced_step_inferior_state): Move to
2976         infrun.h.
2977         (displaced_step_inferior_states): Remove.
2978         (get_displaced_stepping_state): Adust.
2979         (displaced_step_in_progress_any_inferior): Adjust.
2980         (displaced_step_in_progress_thread): Adjust.
2981         (displaced_step_in_progress): Adjust.
2982         (add_displaced_stepping_state): Remove.
2983         (get_displaced_step_closure_by_addr): Adjust.
2984         (remove_displaced_stepping_state): Remove.
2985         (infrun_inferior_exit): Call displaced_step_state.reset.
2986         (use_displaced_stepping): Don't check for NULL.
2987         (displaced_step_prepare_throw): Call
2988         get_displaced_stepping_state.
2989         (displaced_step_fixup): Don't check for NULL.
2990         (prepare_for_detach): Don't check for NULL.
2991
2992 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2993
2994         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2995          in case of call that did not complete.
2996
2997 2019-01-02  Andrey Utkin  <autkin@undo.io>
2998
2999         * symfile.c (find_separate_debug_file): Fix search of debug files for
3000         remote debuggee.
3001
3002 2019-01-02  Tom Tromey  <tom@tromey.com>
3003
3004         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3005         indentation.
3006         * python/py-frame.c (frapy_older): Remove cast.
3007         (frapy_newer): Likewise.
3008         * python/py-breakpoint.c (local_setattro): Remove cast.
3009         * python/py-arch.c (archpy_name): Remove local variable.
3010         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3011
3012 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3013
3014         * unittests/basic_string_view/element_access/char/empty.cc:
3015         Fix year range in copyright header.
3016
3017 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3018
3019         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3020         Delete.
3021         <operator==>: Update with for removed field.
3022         <hash>: Likewise.
3023         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3024         <isa_features>: ...this.
3025         <abi_features>: New field.
3026         (riscv_isa_flen): Update comment.
3027         (riscv_abi_xlen): New declaration.
3028         (riscv_abi_flen): New declaration.
3029         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3030         isa_features.
3031         (riscv_abi_xlen): New function.
3032         (riscv_isa_flen): Update to get answer from isa_features.
3033         (riscv_abi_flen): New function.
3034         (riscv_has_fp_abi): Update to get answer from abi_features.
3035         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3036         xlen and flen.
3037         (riscv_call_info) <xlen, flen>: Update comment.
3038         (riscv_call_arg_struct): Remove invalid assertions
3039         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3040         is removed.
3041         (riscv_gdbarch_init): Gather isa features and abi features
3042         separately, ensure both match on the gdbarch when reusing an old
3043         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3044         a target with 64-bit float hardware.
3045
3046 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3047
3048         * source.c (search_command_helper): Stop reverse search
3049         when line 1 has been searched.
3050
3051 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3052
3053         * record-full.c (record_full_base_target::close): Rewrite
3054         record_full_core_buf_list free logic.
3055
3056 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3057
3058         * break-catch-syscall.c (print_one_catch_syscall): xfree
3059         the last text.
3060
3061 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3062
3063         * top.c (print_gdb_version): Update Copyright year in version
3064         message.
3065
3066 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3067
3068         Update copyright year range in all GDB files.
3069
3070 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3071
3072         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3073
3074 For older changes see ChangeLog-2018.
3075 \f
3076 Local Variables:
3077 mode: change-log
3078 left-margin: 8
3079 fill-column: 74
3080 version-control: never
3081 coding: utf-8
3082 End:
3083