gdb/ChangeLog

   1 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * version.in: Set GDB version number to 8.3.0.DATE-git.
   4
   5 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
   6
   7         GDB 8.3 released.
   8
   9 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  10
  11         * version.in: Set GDB version number to 8.3.
  12
  13 2019-05-08  Tom Tromey  <tromey@adacore.com>
  14
  15         * utils.c (fputs_maybe_filtered): Reset style after paging, even
  16         when no wrap column is set.
  17
  18 2019-05-04  Tom Tromey  <tom@tromey.com>
  19
  20         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  21         (lookup_partial_symbol, print_partial_symbols)
  22         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  23         (psymbol_compare): Update.
  24         (add_psymbol_to_bcache): Clear the entire psymbol.
  25         (maintenance_check_psymtabs): Update.
  26         * psympriv.h (struct partial_symbol): Don't derive from
  27         general_symbol_info.
  28         <obj_section, unrelocated_address, address,
  29         set_unrelocated_address>: Update.
  30         <ginfo>: New member.
  31         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  32         (debug_names::write_psymbols): Update.
  33
  34 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  35
  36         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
  37         level, so that various Windows header files expose the necessary
  38         declarations and definitions.
  39
  40         * symfile.c (find_separate_debug_file): Remove colon from the
  41         drive spec of DOS/Windows file names of the target, so that the
  42         file name produced from DEBUGDIR and the target's directory will
  43         be valid on DOS/Windows systems.
  44
  45 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  46
  47         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  48         Use current_event.dwThreadId instead of main_thread_id.
  49
  50 2019-04-30  Tom Tromey  <tromey@adacore.com>
  51
  52         PR c++/24470:
  53         * dwarf2read.c (process_structure_scope): Handle case where type
  54         has template parameters but no symbol was created.
  55
  56 2019-04-19  Sergei Trofimovich <siarheit@google.com>
  57
  58         * configure.ac: add --enable-source-highlight switch.
  59         * configure: Regenerate.
  60         * top.c (print_gdb_version): plumb --enable-source-highlight
  61         status to "show configuration".
  62
  63 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
  64
  65         PR symtab/24423:
  66         * source.c (print_source_lines_base): Advance "iter" when a
  67         control character is seen.
  68
  69 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  70
  71         * inferior.h (struct infcall_suspend_state_deleter):
  72         Catch exception in destructor to avoid crash.
  73
  74 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
  75
  76         * utils.c (prompt_for_continue): Don't restore the styling at the
  77         end, as applied_style has the wrong value.  This fixes styling in
  78         long lists of file names that are interrupted by the "Continue?"
  79         prompt.
  80
  81 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  82
  83         * version.in: Set GDB version number to 8.2.91.DATE-git.
  84
  85 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  86
  87         GDB 8.2.91 released.
  88
  89 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  90
  91         * version.in: Set GDB version number to 8.2.91.
  92
  93 2019-03-20  Tom Tromey  <tromey@adacore.com>
  94
  95         PR gdb/24391
  96         * infrun.c (handle_inferior_event): Rename from
  97         handle_inferior_event_1.  Create a scoped_value_mark.
  98         (handle_inferior_event): Remove.
  99
 100 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 101
 102         * source-cache.c (source_cache::get_source_lines): Re-read
 103         fullname after calling open_source_file.
 104
 105 2019-03-18  Pedro Alves  <palves@redhat.com>
 106             Eli Zaretskii <eliz@gnu.org>
 107
 108         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 109         m_line and m_start_of_line.
 110
 111 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 112
 113         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 114         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 115         it returns a newline.  This fixes a regression in TU mode, whereby
 116         the next line is output on the same screen line as the user input.
 117
 118 2019-03-18  Pedro Alves  <palves@redhat.com>
 119
 120         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 121         New globals.
 122         (apply_style): New, factored out from ...
 123         (apply_ansi_escape): ... this.  Handle reverse video mode.
 124         (tui_set_reverse_mode): New function.
 125         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 126         * tui/tui-winsource.c (tui_show_source_line): Use
 127         tui_set_reverse_mode instead of setting A_STANDOUT.
 128         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 129         New setter methods.
 130
 131 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 132
 133         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 134         Handle tabs.
 135
 136 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 137
 138         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 139         tui_refill_source_window instead of tui_refresh_win, to update the
 140         current execution line.  This fixes redisplay of the current line
 141         when stepping through the code with "next" or "step".
 142
 143 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 144
 145         * source-cache.c (source_cache::get_source_lines): Call
 146         find_source_lines to initialize s->nlines.  This fixes vertical
 147         scrolling of TUI source window when the DOWN arrow is pressed.
 148
 149 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 150
 151         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 152         wclrtoeol in tui_show_source_line".  This reverts changes made in
 153         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 154
 155 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 156
 157         * NEWS: Combine separate "New targets" sections for 8.3.
 158
 159 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 160
 161         The MS-Windows port of ncurses fails to switch to a color pair if
 162         one or both of the colors are the implicit default colors.  This
 163         change records the default colors when TUI is initialized, and
 164         then specifies them explicitly when a color pair uses the default
 165         colors.  This allows color styling in TUI mode on MS-Windows.
 166
 167         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 168         ncurses_norm_attr.
 169         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 170         colors in ncurses_norm_attr.
 171         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 172         "none", replace it with the default color recorded in
 173         ncurses_norm_attr.
 174
 175 2019-03-14  Tom Tromey  <tromey@adacore.com>
 176
 177         * source-cache.h (class source_cache) <get_source_lines>: Return
 178         std::string.
 179         * source-cache.c (source_cache::extract_lines): Handle case where
 180         first_pos==npos.  Return std::string.
 181         (source_cache::get_source_lines): Update.
 182
 183 2019-03-14  Tom Tromey  <tromey@adacore.com>
 184
 185         * NEWS: Add item for "style sources" commands.
 186         * source-cache.c (source_cache::get_source_lines): Check
 187         source_styling.
 188         * cli/cli-style.c (source_styling): New global.
 189         (_initialize_cli_style): Add "style sources" commands.
 190         (show_style_sources): New function.
 191         * cli/cli-style.h (source_styling): Declare.
 192
 193 2019-03-14  Pedro Alves  <palves@redhat.com>
 194             Tom Tromey  <tromey@adacore.com>
 195
 196         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 197         * tui/tui-winsource.c (tui_refill_source_window): New function,
 198         from...
 199         (tui_horizontal_source_scroll): ... here.  Move some logic.
 200         * cli/cli-style.c (set_style_enabled): Notify new observable.
 201         * tui/tui-hooks.c (tui_redisplay_source): New function.
 202         (tui_attach_detach_observers): Attach or detach
 203         tui_redisplay_source.
 204         * observable.h (source_styling_changed): New observable.
 205         * observable.c: Define source_styling_changed observable.
 206
 207 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 208
 209         PR/24325
 210         * source-cache.c: #undef open and close, to avoid unresolved
 211         externals during linking.
 212
 213 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 214
 215         Support styling on native MS-Windows console
 216
 217         PR/24315
 218         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 219         on MS-Windows if $TERM is not defined.
 220
 221         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 222
 223         * posix-hdep.c (gdb_console_fputs):
 224         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 225         functions.
 226         * ui-file.h (gdb_console_fputs): Add prototype.
 227
 228         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 229         back to fputs only if the former returns zero.
 230
 231 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 232             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 233
 234         PR gdb/8527
 235         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 236         set_sigint_trap, clear_sigint_trap.
 237
 238 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 239
 240         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 241         for-loop range, to avoid compiler warnings.
 242
 243         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 244         avoid compiler warnings about unused variables.
 245
 246 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 247
 248         * NEWS: Mention end of support for native debugging on MS-Windows
 249         before XP.
 250
 251 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 252
 253         PR gdb/24292
 254         * common/netstuff.c:
 255         * gdbserver/gdbreplay.c
 256         * gdbserver/remote-utils.c:
 257         * ser-tcp.c:
 258         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 259         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 260         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 261         'getaddrinfo' and 'freeaddrinfo' were not available before
 262         Windows XP, and mingw.org's MinGW headers by default define
 263         _WIN32_WINNT to 0x500.
 264
 265 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 266
 267         * NEWS: Note minimum Python version.
 268
 269 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 270
 271         * version.in: Set GDB version number to 8.2.90.DATE-git.
 272
 273 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 274
 275         GDB 8.2.90 released.
 276
 277 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 278
 279         * version.in: Set GDB version number to 8.2.90.
 280
 281 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 282
 283         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 284
 285 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 286
 287         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 288         * version.in: Bump version to 8.2.90.DATE-git.
 289
 290 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 291
 292         * aix-thread.c (ptid_cmp): Remove unused variable.
 293         (get_signaled_thread): Likewise.
 294         (store_regs_user_thread): Likewise.
 295         (store_regs_kernel_thread): Likewise.
 296         (fetch_regs_kernel_thread): Remove shadowed variable.
 297
 298 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 299
 300         * features/riscv/32bit-cpu.xml: Add register numbers.
 301         * features/riscv/32bit-fpu.c: Regenerate.
 302         * features/riscv/32bit-fpu.xml: Add register numbers.
 303         * features/riscv/64bit-cpu.xml: Add register numbers.
 304         * features/riscv/64bit-fpu.c: Regenerate.
 305         * features/riscv/64bit-fpu.xml: Add register numbers.
 306
 307 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 308
 309         * NEWS: Mention two argument form of gdb.Value constructor.
 310         * python/py-value.c (convert_buffer_and_type_to_value): New
 311         function.
 312         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 313         Add support for handling an optional second argument.  Call
 314         convert_buffer_and_type_to_value as appropriate.
 315         * python/python-internal.h (Py_buffer_deleter): New struct.
 316         (Py_buffer_up): New typedef.
 317
 318 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 319
 320         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 321         instead of releasing ownership.
 322
 323 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 324
 325         * dwarf2read.c (open_and_init_dwp_file): Call
 326         elf_numsections instead of bfd_count_sections to initialize
 327         dwp_file->num_sections.
 328
 329 2019-02-25  Tom Tromey  <tromey@adacore.com>
 330
 331         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 332
 333 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 334
 335         * gcore.in: Add '--readnever' option when invoking GDB.
 336
 337 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 338
 339         * MAINTAINERS: Update my email address.
 340
 341 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 342
 343         * build-id.c (build_id_to_debug_bfd_1): New function.
 344         (build_id_to_debug_bfd): Look for separate debug file in
 345         sysroot.
 346
 347 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 348
 349         * gdbarch.sh: Update the copyright year range that is placed into
 350         generated files.
 351
 352 2019-02-22  Keith Seitz  <keiths@redhat.com>
 353
 354         PR symtab/23853
 355         * linespec.c (create_sals_line_offset): Search for the default
 356         symtab's filename instead of its fullname.
 357
 358 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 359
 360         * NEWS: Update style defaults.
 361
 362 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 363
 364         * main.c (captured_main_1): Disable styling in batch mode.
 365
 366 2019-02-20  Tom Tromey  <tom@tromey.com>
 367
 368         * symtab.c (symtab_symbol_info): Fix typos.
 369
 370 2019-02-20  Tom Tromey  <tromey@adacore.com>
 371
 372         * findcmd.c (_initialize_mem_search): Use upper case for
 373         metasyntactic variables.
 374
 375 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 376
 377         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 378         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 379
 380 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 381
 382         * top.h (source_file_name): Change to std::string.
 383         * top.c (source_file_name): Likewise.
 384         (command_line_input): Adjust.
 385         * cli/cli-script.c (script_from_file): Adjust.
 386
 387 2019-02-19  Tom Tromey  <tromey@adacore.com>
 388
 389         * ravenscar-thread.c
 390         (ravenscar_thread_target::update_thread_list): Don't call
 391         ada_build_task_list.
 392         * ada-lang.h (ada_build_task_list): Don't declare.
 393         * ada-tasks.c (struct ada_tasks_inferior_data)
 394         <task_list_valid_p>: Now bool.
 395         (read_known_tasks, ada_task_list_changed)
 396         (ada_tasks_invalidate_inferior_data): Update.
 397         (read_known_tasks_array): Return bool.
 398         (read_known_tasks_list): Likewise.
 399         (read_known_tasks): Return void.
 400         (ada_build_task_list): Now static.
 401
 402 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 403
 404         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 405         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 406
 407 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 408
 409         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 410         variant for ada_tasks_pspace_data_handle and
 411         ada_tasks_inferior_data_handle.
 412         (ada_tasks_pspace_data_cleanup): New function.
 413         (ada_tasks_inferior_data_cleanup): New function.
 414
 415 2019-02-17  Tom Tromey  <tom@tromey.com>
 416
 417         * macrotab.h (macro_source_fullname): Return a std::string.
 418         * macrotab.c (macro_include, check_for_redefinition)
 419         (macro_undef, macro_lookup_definition, foreach_macro)
 420         (foreach_macro_in_scope): Update.
 421         (macro_source_fullname): Return a std::string.
 422         * macrocmd.c (show_pp_source_pos): Update.
 423
 424 2019-02-17  Tom Tromey  <tom@tromey.com>
 425
 426         * macrocmd.c (show_pp_source_pos): Style the file names.
 427
 428 2019-02-17  Tom Tromey  <tom@tromey.com>
 429
 430         PR tui/24197:
 431         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 432
 433 2019-02-17  Tom Tromey  <tom@tromey.com>
 434
 435         * ada-lang.c (user_select_syms): Use filtered printing.
 436         * utils.c (wrap_style): New global.
 437         (desired_style): Remove.
 438         (emit_style_escape): Add stream parameter.
 439         (set_output_style, reset_terminal_style, prompt_for_continue):
 440         Update.
 441         (flush_wrap_buffer): Only flush gdb_stdout.
 442         (wrap_here): Set wrap_style.
 443         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 444         treat escape sequences as a character.  Change when wrap buffer is
 445         flushed.
 446         (fputs_styled): Do not set the output style when the default is
 447         requested.
 448         * ui-style.h (struct ui_file_style) <is_default>: New method.
 449         * source.c (print_source_lines_base): Emit escape sequences in one
 450         piece.
 451
 452 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 453
 454         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 455         integers and enumeration types.
 456
 457 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 458
 459         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 460         instead of lookup_symbol_in_language
 461         (do_exact_match): New function.
 462         (ada_get_symbol_name_matcher): Return do_exact_match when
 463         doing a verbatim match.
 464
 465 2019-02-15  Tom Tromey  <tromey@adacore.com>
 466
 467         * ravenscar-thread.c (ravenscar_thread_target::resume)
 468         (ravenscar_thread_target::wait): Special case wildcard requests.
 469
 470 2019-02-15  Tom Tromey  <tromey@adacore.com>
 471
 472         * ravenscar-thread.c (base_ptid): Remove.
 473         (struct ravenscar_thread_target) <close>: New method.
 474         <m_base_ptid>: New member.
 475         <update_inferior_ptid, active_task, task_is_currently_active,
 476         runtime_initialized>: Declare methods.
 477         <ravenscar_thread_target>: Add constructor.
 478         (ravenscar_thread_target::task_is_currently_active)
 479         (ravenscar_thread_target::update_inferior_ptid)
 480         (ravenscar_runtime_initialized): Rename.  Now methods.
 481         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 482         (ravenscar_thread_target::update_thread_list): Update.
 483         (ravenscar_thread_target::active_task): Now method.
 484         (ravenscar_thread_target::store_registers)
 485         (ravenscar_thread_target::prepare_to_store)
 486         (ravenscar_thread_target::prepare_to_store)
 487         (ravenscar_thread_target::mourn_inferior): Update.
 488         (ravenscar_inferior_created): Use "new" to create target.
 489         (ravenscar_thread_target::get_ada_task_ptid): Update.
 490         (_initialize_ravenscar): Don't initialize base_ptid.
 491         (ravenscar_ops): Remove global.
 492
 493 2019-02-15  Tom Tromey  <tromey@adacore.com>
 494
 495         * target.h (push_target): Declare new overload.
 496         * target.c (push_target): New overload, taking an rvalue reference.
 497         * remote.c (remote_target::open_1): Use push_target overload.
 498         * corelow.c (core_target_open): Use push_target overload.
 499
 500 2019-02-15  Tom Tromey  <tromey@adacore.com>
 501
 502         * ravenscar-thread.c (is_ravenscar_task)
 503         (ravenscar_task_is_currently_active): Return bool.
 504         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 505         (_initialize_ravenscar): Remove "(void)".
 506         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 507         Return bool.
 508
 509 2019-02-15  Tom Tromey  <tromey@adacore.com>
 510
 511         * ravenscar-thread.c (ravenscar_runtime_initializer)
 512         (has_ravenscar_runtime, get_running_thread_id)
 513         (ravenscar_thread_target::resume): Fix indentation.
 514
 515 2019-02-15  Tom Tromey  <tromey@adacore.com>
 516
 517         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 518         from ravenscar_arch_ops.
 519         (sparc_ravenscar_ops::fetch_registers)
 520         (sparc_ravenscar_ops::store_registers): Now methods.
 521         (sparc_ravenscar_prepare_to_store): Remove.
 522         (sparc_ravenscar_ops): Redefine.
 523         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 524         methods and destructor.  Remove members.
 525         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 526         (ravenscar_thread_target::store_registers)
 527         (ravenscar_thread_target::prepare_to_store): Update.
 528         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 529         Remove.
 530         (struct ppc_ravenscar_powerpc_ops): Derive from
 531         ravenscar_arch_ops.
 532         (ppc_ravenscar_powerpc_ops::fetch_registers)
 533         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 534         (ppc_ravenscar_powerpc_ops): Redefine.
 535         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 536         (ppc_ravenscar_e500_ops::fetch_registers)
 537         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 538         (ppc_ravenscar_e500_ops): Redefine.
 539         * aarch64-ravenscar-thread.c
 540         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 541         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 542         (aarch64_ravenscar_fetch_registers)
 543         (aarch64_ravenscar_store_registers): Now methods.
 544         (aarch64_ravenscar_ops): Redefine.
 545
 546 2019-02-15  Tom Tromey  <tromey@adacore.com>
 547
 548         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 549         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 550         (ravenscar_thread_target::stopped_by_watchpoint)
 551         (ravenscar_thread_target::stopped_data_address)
 552         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 553
 554 2019-02-15  Tom Tromey  <tromey@adacore.com>
 555
 556         * ravenscar-thread.c: Fix some typos.
 557
 558 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 559             Tom Tromey  <tromey@adacore.com>
 560
 561         * ada-lang.c (ada_exception_sal): Change addr_string to a
 562         std::string.
 563         (create_ada_exception_catchpoint): Update.
 564
 565 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 566             Tom Tromey  <tromey@adacore.com>
 567
 568         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 569         (bp_location_ops): Remove.
 570         (base_breakpoint_allocate_location): Update.
 571         (free_bp_location): Update.
 572         * ada-lang.c (class ada_catchpoint_location)
 573         <ada_catchpoint_location>: Remove ops parameter.
 574         (ada_catchpoint_location_dtor): Remove.
 575         (ada_catchpoint_location_ops): Remove.
 576         (allocate_location_exception): Update.
 577         * breakpoint.h (struct bp_location_ops): Remove.
 578         (class bp_location) <bp_location>: Remove bp_location_ops
 579         parameter.
 580         <~bp_location>: Add destructor.
 581         <ops>: Remove.
 582
 583 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 584             Pedro Alves  <palves@redhat.com>
 585
 586         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 587         'PATH_MAX'.
 588
 589 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 590             Samuel Thibault  <samuel.thibault@gnu.org>
 591             Thomas Schwinge  <thomas@codesourcery.com>
 592
 593         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 594         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 595
 596 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 597
 598         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 599         (check_empty): Use "const char *".
 600
 601         * gnu-nat.c (gnu_nat_target::detach): Instead of
 602         'detach_inferior (pid)' call
 603         'detach_inferior (find_inferior_pid (pid))'.
 604
 605         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 606         'nat/fork-inferior.o'.
 607         * gnu-nat.c: #include "nat/fork-inferior.h".
 608
 609         * gnu-nat.c (gnu_nat_target::detach): Instead of
 610         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 611         * gnu-nat.h: #include "inf-child.h".
 612         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 613         'i386_gnu_nat_target::fetch_registers'.
 614         (gnu_store_registers): Rename/move to
 615         'i386_gnu_nat_target::store_registers'.
 616
 617         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 618         * gnu-nat.h (mach_thread_info): New function.
 619         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 620
 621         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 622
 623 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 624
 625         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 626
 627 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 628
 629         * windows-nat.c (windows_add_thread): Add new parameter
 630         "main_thread_p" with default value set to false.  Update
 631         function documentation as well as all callers.
 632         (windows_delete_thread): Likewise.
 633         (fake_create_process): Update call to windows_add_thread.
 634         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 635         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 636         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 637         call to windows_delete_thread.
 638
 639 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 640
 641         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 642
 643 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 644
 645         * symfile.c (find_separate_debug_file): Use canonical path of
 646         sysroot with child_path instead of gdb_sysroot if it is valid.
 647
 648 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 649
 650         * symfile.c (find_separate_debug_file): Use child_path to
 651         determine if an object file is under a sysroot.
 652
 653 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 654
 655         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 656         unittests/child-path-selftests.c.
 657         * common/pathstuff.c (child_path): New function.
 658         * common/pathstuff.h (child_path): New prototype.
 659         * unittests/child-path-selftests.c: New file.
 660
 661 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 662
 663         * symfile.c (find_separate_debug_file): Look for separate debug
 664         files in debug directories under the sysroot.
 665
 666 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 667
 668         * symtab.h (struct minimal_symbol data_p): New const method.
 669         (struct minimal_symbol text_p): Likewise.
 670         * symtab.c (output_source_filename): Use file name style
 671         to print file name.
 672         (print_symbol_info): Likewise.
 673         (print_msymbol_info): Use address style to print addresses.
 674         Use function name style to print executable text symbols.
 675         (expand_symtab_containing_pc): Use data_p.
 676         (find_pc_sect_compunit_symtab): Likewise.
 677
 678 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 679
 680         * breakpoint.c (describe_other_breakpoints): Use address style
 681         to print addresses.
 682         (say_where): Likewise.
 683
 684 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 685
 686         * ada-typeprint.c (print_func_type): Print function name
 687         style to print function name.
 688         * c-typeprint.c (c_print_type_1): Likewise.
 689
 690 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 691
 692         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 693         for execve.
 694
 695 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 696
 697         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 698         type_stack.
 699
 700 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 701
 702         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 703         TYPE_CODE_REF types.
 704
 705 2019-02-08  Jim Wilson  <jimw@sifive.com>
 706
 707         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 708         (riscv_linux_fregset): New.
 709         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 710
 711 2019-02-07  Tom Tromey  <tom@tromey.com>
 712
 713         * thread.c (thread_cancel_execution_command): Update.
 714         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 715         methods.
 716         (struct thread_fsm_ops): Remove.
 717         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 718         (thread_fsm_should_stop, thread_fsm_return_value)
 719         (thread_fsm_set_finished, thread_fsm_finished_p)
 720         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 721         Don't declare.
 722         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 723         * infrun.c (clear_proceed_status_thread)
 724         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 725         (print_stop_event): Update.
 726         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 727         Add constructor.
 728         (step_command_fsm_ops): Remove.
 729         (new_step_command_fsm): Remove.
 730         (step_1): Update.
 731         (step_command_fsm::should_stop): Rename from
 732         step_command_fsm_should_stop.
 733         (step_command_fsm::clean_up): Rename from
 734         step_command_fsm_clean_up.
 735         (step_command_fsm::do_async_reply_reason): Rename from
 736         step_command_fsm_async_reply_reason.
 737         (struct until_next_fsm): Inherit from thread_fsm.  Add
 738         constructor.
 739         (until_next_fsm_ops): Remove.
 740         (new_until_next_fsm): Remove.
 741         (until_next_fsm::should_stop): Rename from
 742         until_next_fsm_should_stop.
 743         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 744         (until_next_fsm::do_async_reply_reason): Rename from
 745         until_next_fsm_async_reply_reason.
 746         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 747         constructor.  Change type of breakpoint.
 748         (finish_command_fsm_ops): Remove.
 749         (new_finish_command_fsm): Remove.
 750         (finish_command_fsm::should_stop): Rename from
 751         finish_command_fsm_should_stop.
 752         (finish_command_fsm::clean_up): Rename from
 753         finish_command_fsm_clean_up.
 754         (finish_command_fsm::return_value): Rename from
 755         finish_command_fsm_return_value.
 756         (finish_command_fsm::do_async_reply_reason): Rename from
 757         finish_command_fsm_async_reply_reason.
 758         (finish_command): Update.
 759         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 760         Add constructor.
 761         (call_thread_fsm_ops): Remove.
 762         (call_thread_fsm::call_thread_fsm): Rename from
 763         new_call_thread_fsm.
 764         (call_thread_fsm::should_stop): Rename from
 765         call_thread_fsm_should_stop.
 766         (call_thread_fsm::should_notify_stop): Rename from
 767         call_thread_fsm_should_notify_stop.
 768         (run_inferior_call, call_function_by_hand_dummy): Update.
 769         * cli/cli-interp.c (should_print_stop_to_console): Update.
 770         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 771         Add constructor.  Change type of location_breakpoint,
 772         caller_breakpoint.
 773         (until_break_fsm_ops): Remove.
 774         (new_until_break_fsm): Remove.
 775         (until_break_fsm::should_stop): Rename from
 776         until_break_fsm_should_stop.
 777         (until_break_fsm::clean_up): Rename from
 778         until_break_fsm_clean_up.
 779         (until_break_fsm::do_async_reply_reason): Rename from
 780         until_break_fsm_async_reply_reason.
 781         (until_break_command): Update.
 782         * thread-fsm.c: Remove.
 783         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 784
 785 2019-02-07  Tom Tromey  <tom@tromey.com>
 786
 787         * yy-remap.h: Add include guard.
 788         * xtensa-tdep.h: Add include guard.
 789         * xcoffread.h: Rename include guard.
 790         * varobj-iter.h: Add include guard.
 791         * tui/tui.h: Rename include guard.
 792         * tui/tui-winsource.h: Rename include guard.
 793         * tui/tui-wingeneral.h: Rename include guard.
 794         * tui/tui-windata.h: Rename include guard.
 795         * tui/tui-win.h: Rename include guard.
 796         * tui/tui-stack.h: Rename include guard.
 797         * tui/tui-source.h: Rename include guard.
 798         * tui/tui-regs.h: Rename include guard.
 799         * tui/tui-out.h: Rename include guard.
 800         * tui/tui-layout.h: Rename include guard.
 801         * tui/tui-io.h: Rename include guard.
 802         * tui/tui-hooks.h: Rename include guard.
 803         * tui/tui-file.h: Rename include guard.
 804         * tui/tui-disasm.h: Rename include guard.
 805         * tui/tui-data.h: Rename include guard.
 806         * tui/tui-command.h: Rename include guard.
 807         * tic6x-tdep.h: Add include guard.
 808         * target/waitstatus.h: Rename include guard.
 809         * target/wait.h: Rename include guard.
 810         * target/target.h: Rename include guard.
 811         * target/resume.h: Rename include guard.
 812         * target-float.h: Rename include guard.
 813         * stabsread.h: Add include guard.
 814         * rs6000-tdep.h: Add include guard.
 815         * riscv-fbsd-tdep.h: Add include guard.
 816         * regformats/regdef.h: Rename include guard.
 817         * record.h: Rename include guard.
 818         * python/python.h: Rename include guard.
 819         * python/python-internal.h: Rename include guard.
 820         * python/py-stopevent.h: Rename include guard.
 821         * python/py-ref.h: Rename include guard.
 822         * python/py-record.h: Rename include guard.
 823         * python/py-record-full.h: Rename include guard.
 824         * python/py-record-btrace.h: Rename include guard.
 825         * python/py-instruction.h: Rename include guard.
 826         * python/py-events.h: Rename include guard.
 827         * python/py-event.h: Rename include guard.
 828         * procfs.h: Add include guard.
 829         * proc-utils.h: Add include guard.
 830         * p-lang.h: Add include guard.
 831         * or1k-tdep.h: Rename include guard.
 832         * observable.h: Rename include guard.
 833         * nto-tdep.h: Rename include guard.
 834         * nat/x86-linux.h: Rename include guard.
 835         * nat/x86-linux-dregs.h: Rename include guard.
 836         * nat/x86-gcc-cpuid.h: Add include guard.
 837         * nat/x86-dregs.h: Rename include guard.
 838         * nat/x86-cpuid.h: Rename include guard.
 839         * nat/ppc-linux.h: Rename include guard.
 840         * nat/mips-linux-watch.h: Rename include guard.
 841         * nat/linux-waitpid.h: Rename include guard.
 842         * nat/linux-ptrace.h: Rename include guard.
 843         * nat/linux-procfs.h: Rename include guard.
 844         * nat/linux-osdata.h: Rename include guard.
 845         * nat/linux-nat.h: Rename include guard.
 846         * nat/linux-namespaces.h: Rename include guard.
 847         * nat/linux-btrace.h: Rename include guard.
 848         * nat/glibc_thread_db.h: Rename include guard.
 849         * nat/gdb_thread_db.h: Rename include guard.
 850         * nat/gdb_ptrace.h: Rename include guard.
 851         * nat/fork-inferior.h: Rename include guard.
 852         * nat/amd64-linux-siginfo.h: Rename include guard.
 853         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 854         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 855         * nat/aarch64-linux.h: Rename include guard.
 856         * nat/aarch64-linux-hw-point.h: Rename include guard.
 857         * mn10300-tdep.h: Add include guard.
 858         * mips-linux-tdep.h: Add include guard.
 859         * mi/mi-parse.h: Rename include guard.
 860         * mi/mi-out.h: Rename include guard.
 861         * mi/mi-main.h: Rename include guard.
 862         * mi/mi-interp.h: Rename include guard.
 863         * mi/mi-getopt.h: Rename include guard.
 864         * mi/mi-console.h: Rename include guard.
 865         * mi/mi-common.h: Rename include guard.
 866         * mi/mi-cmds.h: Rename include guard.
 867         * mi/mi-cmd-break.h: Rename include guard.
 868         * m2-lang.h: Add include guard.
 869         * location.h: Rename include guard.
 870         * linux-record.h: Rename include guard.
 871         * linux-nat.h: Add include guard.
 872         * linux-fork.h: Add include guard.
 873         * i386-darwin-tdep.h: Rename include guard.
 874         * hppa-linux-offsets.h: Add include guard.
 875         * guile/guile.h: Rename include guard.
 876         * guile/guile-internal.h: Rename include guard.
 877         * gnu-nat.h: Rename include guard.
 878         * gdb-stabs.h: Rename include guard.
 879         * frv-tdep.h: Add include guard.
 880         * f-lang.h: Add include guard.
 881         * event-loop.h: Add include guard.
 882         * darwin-nat.h: Rename include guard.
 883         * cp-abi.h: Rename include guard.
 884         * config/sparc/nm-sol2.h: Rename include guard.
 885         * config/nm-nto.h: Rename include guard.
 886         * config/nm-linux.h: Add include guard.
 887         * config/i386/nm-i386gnu.h: Rename include guard.
 888         * config/djgpp/nl_types.h: Rename include guard.
 889         * config/djgpp/langinfo.h: Rename include guard.
 890         * compile/gcc-cp-plugin.h: Add include guard.
 891         * compile/gcc-c-plugin.h: Add include guard.
 892         * compile/compile.h: Rename include guard.
 893         * compile/compile-object-run.h: Rename include guard.
 894         * compile/compile-object-load.h: Rename include guard.
 895         * compile/compile-internal.h: Rename include guard.
 896         * compile/compile-cplus.h: Rename include guard.
 897         * compile/compile-c.h: Rename include guard.
 898         * common/xml-utils.h: Rename include guard.
 899         * common/x86-xstate.h: Rename include guard.
 900         * common/version.h: Rename include guard.
 901         * common/vec.h: Rename include guard.
 902         * common/tdesc.h: Rename include guard.
 903         * common/selftest.h: Rename include guard.
 904         * common/scoped_restore.h: Rename include guard.
 905         * common/scoped_mmap.h: Rename include guard.
 906         * common/scoped_fd.h: Rename include guard.
 907         * common/safe-iterator.h: Rename include guard.
 908         * common/run-time-clock.h: Rename include guard.
 909         * common/refcounted-object.h: Rename include guard.
 910         * common/queue.h: Rename include guard.
 911         * common/ptid.h: Rename include guard.
 912         * common/print-utils.h: Rename include guard.
 913         * common/preprocessor.h: Rename include guard.
 914         * common/pathstuff.h: Rename include guard.
 915         * common/observable.h: Rename include guard.
 916         * common/netstuff.h: Rename include guard.
 917         * common/job-control.h: Rename include guard.
 918         * common/host-defs.h: Rename include guard.
 919         * common/gdb_wait.h: Rename include guard.
 920         * common/gdb_vecs.h: Rename include guard.
 921         * common/gdb_unlinker.h: Rename include guard.
 922         * common/gdb_unique_ptr.h: Rename include guard.
 923         * common/gdb_tilde_expand.h: Rename include guard.
 924         * common/gdb_sys_time.h: Rename include guard.
 925         * common/gdb_string_view.h: Rename include guard.
 926         * common/gdb_splay_tree.h: Rename include guard.
 927         * common/gdb_setjmp.h: Rename include guard.
 928         * common/gdb_ref_ptr.h: Rename include guard.
 929         * common/gdb_optional.h: Rename include guard.
 930         * common/gdb_locale.h: Rename include guard.
 931         * common/gdb_assert.h: Rename include guard.
 932         * common/filtered-iterator.h: Rename include guard.
 933         * common/filestuff.h: Rename include guard.
 934         * common/fileio.h: Rename include guard.
 935         * common/environ.h: Rename include guard.
 936         * common/common-utils.h: Rename include guard.
 937         * common/common-types.h: Rename include guard.
 938         * common/common-regcache.h: Rename include guard.
 939         * common/common-inferior.h: Rename include guard.
 940         * common/common-gdbthread.h: Rename include guard.
 941         * common/common-exceptions.h: Rename include guard.
 942         * common/common-defs.h: Rename include guard.
 943         * common/common-debug.h: Rename include guard.
 944         * common/cleanups.h: Rename include guard.
 945         * common/buffer.h: Rename include guard.
 946         * common/btrace-common.h: Rename include guard.
 947         * common/break-common.h: Rename include guard.
 948         * cli/cli-utils.h: Rename include guard.
 949         * cli/cli-style.h: Rename include guard.
 950         * cli/cli-setshow.h: Rename include guard.
 951         * cli/cli-script.h: Rename include guard.
 952         * cli/cli-interp.h: Rename include guard.
 953         * cli/cli-decode.h: Rename include guard.
 954         * cli/cli-cmds.h: Rename include guard.
 955         * charset-list.h: Add include guard.
 956         * buildsym-legacy.h: Rename include guard.
 957         * bfin-tdep.h: Add include guard.
 958         * ax.h: Rename include guard.
 959         * arm-linux-tdep.h: Add include guard.
 960         * arm-fbsd-tdep.h: Add include guard.
 961         * arch/xtensa.h: Rename include guard.
 962         * arch/tic6x.h: Add include guard.
 963         * arch/i386.h: Add include guard.
 964         * arch/arm.h: Rename include guard.
 965         * arch/arm-linux.h: Rename include guard.
 966         * arch/arm-get-next-pcs.h: Rename include guard.
 967         * arch/amd64.h: Add include guard.
 968         * arch/aarch64-insn.h: Rename include guard.
 969         * arch-utils.h: Rename include guard.
 970         * annotate.h: Add include guard.
 971         * amd64-darwin-tdep.h: Rename include guard.
 972         * aarch64-linux-tdep.h: Add include guard.
 973         * aarch64-fbsd-tdep.h: Add include guard.
 974         * aarch32-linux-nat.h: Add include guard.
 975
 976 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 977
 978         * macrotab.c (macro_define_internal): New function that
 979         factorizes macro_define_object_internal and macro_define_function
 980         code.
 981         (macro_define_object_internal): Use macro_define_internal.
 982         (macro_define_function): Likewise.
 983
 984 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 985
 986         * macrocmd.c (extract_identifier): Return
 987         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 988         callers.
 989
 990 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 991
 992         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 993
 994 2019-02-05  Tom Tromey  <tom@tromey.com>
 995
 996         * target.c (target_stack::unpush): Move assertion earlier.
 997
 998 2019-01-30  Tom Tromey  <tom@tromey.com>
 999
1000         PR python/23615:
1001         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1002         (gdbpy_parse_and_eval): Likewise.
1003         * python/python-internal.h (gdbpy_allow_threads): New class.
1004
1005 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1006
1007         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1008         (aarch64_fbsd_fpregmap): Move earlier.
1009         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1010         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1011         instead of individual calls to trad_frame_set_reg_addr.
1012         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1013         earlier.
1014         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1015         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1016         instead of individual calls to trad_frame_set_reg_addr.
1017
1018 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1019
1020         * CONTRIBUTE: Replace contribution list with wiki link.
1021
1022 2019-01-25  Tom Tromey  <tom@tromey.com>
1023
1024         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1025
1026 2019-01-25  Tom Tromey  <tom@tromey.com>
1027
1028         * xtensa-linux-nat.c: Fix common/ includes.
1029         * xml-support.h: Fix common/ includes.
1030         * xml-support.c: Fix common/ includes.
1031         * x86-linux-nat.c: Fix common/ includes.
1032         * windows-nat.c: Fix common/ includes.
1033         * varobj.h: Fix common/ includes.
1034         * varobj.c: Fix common/ includes.
1035         * value.c: Fix common/ includes.
1036         * valops.c: Fix common/ includes.
1037         * utils.c: Fix common/ includes.
1038         * unittests/xml-utils-selftests.c: Fix common/ includes.
1039         * unittests/utils-selftests.c: Fix common/ includes.
1040         * unittests/unpack-selftests.c: Fix common/ includes.
1041         * unittests/tracepoint-selftests.c: Fix common/ includes.
1042         * unittests/style-selftests.c: Fix common/ includes.
1043         * unittests/string_view-selftests.c: Fix common/ includes.
1044         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1045         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1046         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1047         * unittests/rsp-low-selftests.c: Fix common/ includes.
1048         * unittests/parse-connection-spec-selftests.c: Fix common/
1049         includes.
1050         * unittests/optional-selftests.c: Fix common/ includes.
1051         * unittests/offset-type-selftests.c: Fix common/ includes.
1052         * unittests/observable-selftests.c: Fix common/ includes.
1053         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1054         * unittests/memrange-selftests.c: Fix common/ includes.
1055         * unittests/memory-map-selftests.c: Fix common/ includes.
1056         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1057         * unittests/function-view-selftests.c: Fix common/ includes.
1058         * unittests/environ-selftests.c: Fix common/ includes.
1059         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1060         * unittests/common-utils-selftests.c: Fix common/ includes.
1061         * unittests/cli-utils-selftests.c: Fix common/ includes.
1062         * unittests/array-view-selftests.c: Fix common/ includes.
1063         * ui-file.c: Fix common/ includes.
1064         * tui/tui-io.c: Fix common/ includes.
1065         * tracepoint.h: Fix common/ includes.
1066         * tracepoint.c: Fix common/ includes.
1067         * tracefile-tfile.c: Fix common/ includes.
1068         * top.h: Fix common/ includes.
1069         * top.c: Fix common/ includes.
1070         * thread.c: Fix common/ includes.
1071         * target/waitstatus.h: Fix common/ includes.
1072         * target/waitstatus.c: Fix common/ includes.
1073         * target.h: Fix common/ includes.
1074         * target.c: Fix common/ includes.
1075         * target-memory.c: Fix common/ includes.
1076         * target-descriptions.c: Fix common/ includes.
1077         * symtab.h: Fix common/ includes.
1078         * symfile.c: Fix common/ includes.
1079         * stap-probe.c: Fix common/ includes.
1080         * spu-linux-nat.c: Fix common/ includes.
1081         * sparc-nat.c: Fix common/ includes.
1082         * source.c: Fix common/ includes.
1083         * solib.c: Fix common/ includes.
1084         * solib-target.c: Fix common/ includes.
1085         * ser-unix.c: Fix common/ includes.
1086         * ser-tcp.c: Fix common/ includes.
1087         * ser-pipe.c: Fix common/ includes.
1088         * ser-base.c: Fix common/ includes.
1089         * selftest-arch.c: Fix common/ includes.
1090         * s12z-tdep.c: Fix common/ includes.
1091         * rust-exp.y: Fix common/ includes.
1092         * rs6000-aix-tdep.c: Fix common/ includes.
1093         * riscv-tdep.c: Fix common/ includes.
1094         * remote.c: Fix common/ includes.
1095         * remote-notif.h: Fix common/ includes.
1096         * remote-fileio.h: Fix common/ includes.
1097         * remote-fileio.c: Fix common/ includes.
1098         * regcache.h: Fix common/ includes.
1099         * regcache.c: Fix common/ includes.
1100         * record-btrace.c: Fix common/ includes.
1101         * python/python.c: Fix common/ includes.
1102         * python/py-type.c: Fix common/ includes.
1103         * python/py-inferior.c: Fix common/ includes.
1104         * progspace.h: Fix common/ includes.
1105         * producer.c: Fix common/ includes.
1106         * procfs.c: Fix common/ includes.
1107         * proc-api.c: Fix common/ includes.
1108         * printcmd.c: Fix common/ includes.
1109         * ppc-linux-nat.c: Fix common/ includes.
1110         * parser-defs.h: Fix common/ includes.
1111         * osdata.c: Fix common/ includes.
1112         * obsd-nat.c: Fix common/ includes.
1113         * nat/x86-linux.c: Fix common/ includes.
1114         * nat/x86-linux-dregs.c: Fix common/ includes.
1115         * nat/x86-dregs.h: Fix common/ includes.
1116         * nat/x86-dregs.c: Fix common/ includes.
1117         * nat/ppc-linux.c: Fix common/ includes.
1118         * nat/mips-linux-watch.h: Fix common/ includes.
1119         * nat/mips-linux-watch.c: Fix common/ includes.
1120         * nat/linux-waitpid.c: Fix common/ includes.
1121         * nat/linux-ptrace.h: Fix common/ includes.
1122         * nat/linux-ptrace.c: Fix common/ includes.
1123         * nat/linux-procfs.c: Fix common/ includes.
1124         * nat/linux-personality.c: Fix common/ includes.
1125         * nat/linux-osdata.c: Fix common/ includes.
1126         * nat/linux-namespaces.c: Fix common/ includes.
1127         * nat/linux-btrace.h: Fix common/ includes.
1128         * nat/linux-btrace.c: Fix common/ includes.
1129         * nat/fork-inferior.c: Fix common/ includes.
1130         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1131         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1132         * nat/aarch64-linux.c: Fix common/ includes.
1133         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1134         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1135         * namespace.h: Fix common/ includes.
1136         * mips-linux-tdep.c: Fix common/ includes.
1137         * minsyms.c: Fix common/ includes.
1138         * mi/mi-parse.h: Fix common/ includes.
1139         * mi/mi-main.c: Fix common/ includes.
1140         * mi/mi-cmd-env.c: Fix common/ includes.
1141         * memrange.h: Fix common/ includes.
1142         * memattr.c: Fix common/ includes.
1143         * maint.h: Fix common/ includes.
1144         * maint.c: Fix common/ includes.
1145         * main.c: Fix common/ includes.
1146         * machoread.c: Fix common/ includes.
1147         * location.c: Fix common/ includes.
1148         * linux-thread-db.c: Fix common/ includes.
1149         * linux-nat.c: Fix common/ includes.
1150         * linux-fork.c: Fix common/ includes.
1151         * inline-frame.c: Fix common/ includes.
1152         * infrun.c: Fix common/ includes.
1153         * inflow.c: Fix common/ includes.
1154         * inferior.h: Fix common/ includes.
1155         * inferior.c: Fix common/ includes.
1156         * infcmd.c: Fix common/ includes.
1157         * inf-ptrace.c: Fix common/ includes.
1158         * inf-child.c: Fix common/ includes.
1159         * ia64-linux-nat.c: Fix common/ includes.
1160         * i387-tdep.c: Fix common/ includes.
1161         * i386-tdep.c: Fix common/ includes.
1162         * i386-linux-tdep.c: Fix common/ includes.
1163         * i386-linux-nat.c: Fix common/ includes.
1164         * i386-go32-tdep.c: Fix common/ includes.
1165         * i386-fbsd-tdep.c: Fix common/ includes.
1166         * i386-fbsd-nat.c: Fix common/ includes.
1167         * guile/scm-type.c: Fix common/ includes.
1168         * guile/guile.c: Fix common/ includes.
1169         * go32-nat.c: Fix common/ includes.
1170         * gnu-nat.c: Fix common/ includes.
1171         * gdbthread.h: Fix common/ includes.
1172         * gdbarch-selftests.c: Fix common/ includes.
1173         * gdb_usleep.c: Fix common/ includes.
1174         * gdb_select.h: Fix common/ includes.
1175         * gdb_bfd.c: Fix common/ includes.
1176         * gcore.c: Fix common/ includes.
1177         * fork-child.c: Fix common/ includes.
1178         * findvar.c: Fix common/ includes.
1179         * fbsd-nat.c: Fix common/ includes.
1180         * event-top.c: Fix common/ includes.
1181         * event-loop.c: Fix common/ includes.
1182         * dwarf2read.c: Fix common/ includes.
1183         * dwarf2loc.c: Fix common/ includes.
1184         * dwarf2-frame.c: Fix common/ includes.
1185         * dwarf-index-cache.c: Fix common/ includes.
1186         * dtrace-probe.c: Fix common/ includes.
1187         * disasm-selftests.c: Fix common/ includes.
1188         * defs.h: Fix common/ includes.
1189         * csky-tdep.c: Fix common/ includes.
1190         * cp-valprint.c: Fix common/ includes.
1191         * cp-support.h: Fix common/ includes.
1192         * cp-support.c: Fix common/ includes.
1193         * corelow.c: Fix common/ includes.
1194         * completer.h: Fix common/ includes.
1195         * completer.c: Fix common/ includes.
1196         * compile/compile.c: Fix common/ includes.
1197         * compile/compile-loc2c.c: Fix common/ includes.
1198         * compile/compile-cplus-types.c: Fix common/ includes.
1199         * compile/compile-cplus-symbols.c: Fix common/ includes.
1200         * command.h: Fix common/ includes.
1201         * cli/cli-dump.c: Fix common/ includes.
1202         * cli/cli-cmds.c: Fix common/ includes.
1203         * charset.c: Fix common/ includes.
1204         * build-id.c: Fix common/ includes.
1205         * btrace.h: Fix common/ includes.
1206         * btrace.c: Fix common/ includes.
1207         * breakpoint.h: Fix common/ includes.
1208         * breakpoint.c: Fix common/ includes.
1209         * ax.h:
1210         (enum agent_op): Fix common/ includes.
1211         * ax-general.c (struct aop_map): Fix common/ includes.
1212         * ax-gdb.c: Fix common/ includes.
1213         * auxv.c: Fix common/ includes.
1214         * auto-load.c: Fix common/ includes.
1215         * arm-tdep.c: Fix common/ includes.
1216         * arch/riscv.c: Fix common/ includes.
1217         * arch/ppc-linux-common.c: Fix common/ includes.
1218         * arch/i386.c: Fix common/ includes.
1219         * arch/arm.c: Fix common/ includes.
1220         * arch/arm-linux.c: Fix common/ includes.
1221         * arch/arm-get-next-pcs.c: Fix common/ includes.
1222         * arch/amd64.c: Fix common/ includes.
1223         * arch/aarch64.c: Fix common/ includes.
1224         * arch/aarch64-insn.c: Fix common/ includes.
1225         * arch-utils.c: Fix common/ includes.
1226         * amd64-windows-tdep.c: Fix common/ includes.
1227         * amd64-tdep.c: Fix common/ includes.
1228         * amd64-sol2-tdep.c: Fix common/ includes.
1229         * amd64-obsd-tdep.c: Fix common/ includes.
1230         * amd64-nbsd-tdep.c: Fix common/ includes.
1231         * amd64-linux-tdep.c: Fix common/ includes.
1232         * amd64-linux-nat.c: Fix common/ includes.
1233         * amd64-fbsd-tdep.c: Fix common/ includes.
1234         * amd64-fbsd-nat.c: Fix common/ includes.
1235         * amd64-dicos-tdep.c: Fix common/ includes.
1236         * amd64-darwin-tdep.c: Fix common/ includes.
1237         * agent.c: Fix common/ includes.
1238         * ada-lang.h: Fix common/ includes.
1239         * ada-lang.c: Fix common/ includes.
1240         * aarch64-tdep.c: Fix common/ includes.
1241
1242 2019-01-25  Tom Tromey  <tom@tromey.com>
1243
1244         * common/create-version.sh: Use common/version.h.
1245
1246 2019-01-24  Pedro Alves  <palves@redhat.com>
1247
1248         * infrun.c (signal_stop, signal_print, signal_program)
1249         (signal_catch, signal_pass): Now arrays instead of pointers.
1250         (update_signals_program_target, do_target_resume)
1251         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1252         * linux-nat.c (linux_nat_target::pass_signals)
1253         (linux_nat_target::create_inferior, linux_nat_target::attach):
1254         Adjust.
1255         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1256         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1257         * procfs.c (procfs_target::pass_signals): Adjust.
1258         * record-full.c (record_full_target::resume): Adjust.
1259         * remote.c (remote_target::pass_signals)
1260         (remote_target::program_signals): Adjust.
1261         * target-debug.h (target_debug_print_signals): Now takes a
1262         gdb::array_view as parameter.  Adjust.
1263         * target.h (target_ops) <pass_signals, program_signals>: Replace
1264         pointer and length parameters with gdb::array_view.
1265         (target_pass_signals, target_program_signals): Likewise.
1266         * target-delegates.c: Regenerate.
1267
1268 2019-01-24  Pedro Alves  <palves@redhat.com>
1269
1270         * common/forward-scope-exit.h
1271         (forward_scope_exit::forward_scope_exit): Pass arguments to
1272         m_bind_function directly, instead of creating a std::bind and
1273         copying that.
1274
1275 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1276
1277         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1278         for static members.
1279         (pass_in_v_vfp_candidate): Likewise.
1280
1281 2019-01-23  Tom Tromey  <tom@tromey.com>
1282             Pedro Alves  <palves@redhat.com>
1283
1284         * regcache.c (class regcache_invalidator): Remove.
1285         (regcache::raw_write): Use make_scope_exit.
1286
1287 2019-01-23  Tom Tromey  <tom@tromey.com>
1288
1289         * ui-out.h (class ui_out_emit_type): Update comment.
1290
1291 2019-01-23  Tom Tromey  <tom@tromey.com>
1292
1293         * infrun.c (fetch_inferior_event): Update comment.
1294
1295 2019-01-23  Tom Tromey  <tom@tromey.com>
1296             Pedro Alves  <palves@redhat.com>
1297
1298         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1299         parameter.
1300         (fetch_inferior_event): Use SCOPE_EXIT.
1301
1302
1303 2019-01-23  Tom Tromey  <tom@tromey.com>
1304             Pedro Alves  <palves@redhat.com>
1305
1306         * infrun.c (disable_thread_events): Delete.
1307         (stop_all_threads): Use SCOPE_EXIT.
1308
1309 2019-01-23  Tom Tromey  <tom@tromey.com>
1310             Pedro Alves  <palves@redhat.com>
1311
1312         * symfile.c: Include forward-scope-exit.h.
1313         (clear_symtab_users_cleanup): Replace forward declaration with
1314         a FORWARD_SCOPE_EXIT.
1315         (syms_from_objfile_1): Use the forward_scope_exit and
1316         gdb::optional instead of cleanup_function.
1317         (reread_symbols): Use the forward_scope_exit instead of
1318         cleanup_function.
1319         (clear_symtab_users_cleanup): Remove function.
1320
1321 2019-01-23  Tom Tromey  <tom@tromey.com>
1322             Pedro Alves  <palves@redhat.com>
1323
1324         * linux-nat.c: Include scope-exit.h.
1325         (cleanup_target_stop): Remove.
1326         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1327         SCOPE_EXIT.
1328
1329 2019-01-23  Tom Tromey  <tom@tromey.com>
1330             Pedro Alves  <palves@redhat.com>
1331
1332         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1333         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1334
1335 2019-01-23  Tom Tromey  <tom@tromey.com>
1336             Andrew Burgess  <andrew.burgess@embecosm.com>
1337             Pedro Alves  <palves@redhat.com>
1338
1339         * infrun.c (fetch_inferior_event): Use scope_exit.
1340         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1341         * top.c (execute_command): Use scope_exit.
1342         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1343         * utils.c (do_bpstat_clear_actions_cleanup)
1344         (make_bpstat_clear_actions_cleanup): Remove.
1345
1346 2019-01-23  Tom Tromey  <tom@tromey.com>
1347             Pedro Alves  <palves@redhat.com>
1348
1349         * infrun.c: Include "common/scope-exit.h"
1350         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1351         (wait_for_inferior): Use SCOPE_EXIT.
1352         (fetch_inferior_event): Use scope_exit.
1353
1354 2019-01-23  Tom Tromey  <tom@tromey.com>
1355             Pedro Alves  <palves@redhat.com>
1356
1357         * breakpoint.c (create_breakpoint): Remove cleanup.
1358
1359 2019-01-23  Tom Tromey  <tom@tromey.com>
1360             Andrew Burgess  <andrew.burgess@embecosm.com>
1361             Pedro Alves  <palves@redhat.com>
1362
1363 2019-01-23  Pedro Alves  <palves@redhat.com>
1364
1365         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1366
1367 2019-01-23  Pedro Alves  <palves@redhat.com>
1368             Andrew Burgess  <andrew.burgess@embecosm.com>
1369
1370         * gdbthread.h: Include "common/forward-scope-exit.h".
1371         (scoped_finish_thread_state): Redefine custom class in terms of
1372         forward_scope_exit.
1373
1374 2019-01-23  Pedro Alves  <palves@redhat.com>
1375             Andrew Burgess  <andrew.burgess@embecosm.com>
1376
1377         * common/forward-scope-exit.h: New file.
1378
1379 2019-01-23  Pedro Alves  <palves@redhat.com>
1380             Andrew Burgess  <andrew.burgess@embecosm.com>
1381             Tom Tromey  <tom@tromey.com>
1382
1383         * common/scope-exit.h: New file.
1384
1385 2019-01-23  Pedro Alves  <palves@redhat.com>
1386
1387         * common/preprocessor.h (ESC): Rename to ...
1388         (ESC_PARENS): ... this.
1389         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1390         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1391
1392 2019-01-23  Tom Tromey  <tom@tromey.com>
1393
1394         * language.h (class scoped_switch_to_sym_language_if_auto):
1395         Initialize m_lang in both cases.
1396
1397 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1398
1399         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1400         with XCNEW.
1401
1402 2019-01-22  Tom Tromey  <tom@tromey.com>
1403
1404         * corelow.c: Do not include sys/file.h.
1405
1406 2019-01-22  Tom Tromey  <tom@tromey.com>
1407
1408         * tui/tui-wingeneral.h: Include gdb_curses.h.
1409
1410 2019-01-22  Tom Tromey  <tom@tromey.com>
1411
1412         * source-cache.h (class source_cache) <get_source_lines,
1413         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1414
1415 2019-01-22  Tom Tromey  <tom@tromey.com>
1416
1417         * remote-fileio.h (struct remote_target): Declare.
1418
1419 2019-01-22  Tom Tromey  <tom@tromey.com>
1420
1421         * python/py-arch.c: Do not include py-ref.h.
1422         * python/py-bpevent.c: Do not include py-ref.h.
1423         * python/py-cmd.c: Do not include py-ref.h.
1424         * python/py-continueevent.c: Do not include py-ref.h.
1425         * python/py-event.h: Do not include py-ref.h.
1426         * python/py-evtregistry.c: Do not include py-ref.h.
1427         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1428         * python/py-frame.c: Do not include py-ref.h.
1429         * python/py-framefilter.c: Do not include py-ref.h.
1430         * python/py-function.c: Do not include py-ref.h.
1431         * python/py-infevents.c: Do not include py-ref.h.
1432         * python/py-linetable.c: Do not include py-ref.h.
1433         * python/py-objfile.c: Do not include py-ref.h.
1434         * python/py-param.c: Do not include py-ref.h.
1435         * python/py-prettyprint.c: Do not include py-ref.h.
1436         * python/py-progspace.c: Do not include py-ref.h.
1437         * python/py-symbol.c: Do not include py-ref.h.
1438         * python/py-symtab.c: Do not include py-ref.h.
1439         * python/py-type.c: Do not include py-ref.h.
1440         * python/py-unwind.c: Do not include py-ref.h.
1441         * python/py-utils.c: Do not include py-ref.h.
1442         * python/py-value.c: Do not include py-ref.h.
1443         * python/py-varobj.c: Do not include py-ref.h.
1444         * python/py-xmethods.c: Do not include py-ref.h.
1445         * python/python.c: Do not include py-ref.h.
1446         * varobj.c: Do not include py-ref.h.
1447
1448 2019-01-22  Tom Tromey  <tom@tromey.com>
1449
1450         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1451         keyword for bcache.
1452
1453 2019-01-22  Tom Tromey  <tom@tromey.com>
1454
1455         * compile/compile-cplus-types.c: Remove a comment by #include.
1456
1457 2019-01-22  Tom Tromey  <tom@tromey.com>
1458
1459         * compile/gcc-c-plugin.h: Include compile-internal.h.
1460
1461 2019-01-22  Tom Tromey  <tom@tromey.com>
1462
1463         * stabsread.c (EXTERN): Do not define.
1464         (symnum, next_symbol_text_func, processing_gcc_compilation)
1465         (within_function, global_sym_chain, global_stabs)
1466         (previous_stab_code, this_object_header_files)
1467         (n_this_object_header_files)
1468         (n_allocated_this_object_header_files): Define.
1469         * stabsread.h (EXTERN): Never define.  Use "extern".
1470
1471 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1472
1473         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1474         history_value.
1475
1476 2019-01-21  Tom Tromey  <tom@tromey.com>
1477
1478         * ui-out.c: Fix includes.
1479         * tui/tui-source.c: Fix includes.
1480         * target.c: Fix includes.
1481         * remote.c: Fix includes.
1482         * regcache.c: Fix includes.
1483         * python/py-block.c: Fix includes.
1484         * printcmd.c: Fix includes.
1485         * or1k-tdep.c: Fix includes.
1486         * mi/mi-main.c: Fix includes.
1487         * m32r-tdep.c: Fix includes.
1488         * csky-tdep.c: Fix includes.
1489         * compile/compile-cplus-types.c: Fix includes.
1490         * cli/cli-interp.c: Fix includes.
1491
1492 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1493
1494         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1495         for padding.
1496
1497 2019-01-16  Tom Tromey  <tom@tromey.com>
1498
1499         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1500         earlier.
1501         (struct objfile) <msymbols_range>: Move from top level.
1502         <msymbols>: New method.
1503         (class objfile_msymbols): Remove.
1504         * symtab.c (default_collect_symbol_completion_matches_break_on):
1505         Update.
1506         * symmisc.c (dump_msymbols): Update.
1507         * stabsread.c (scan_file_globals): Update.
1508         * objc-lang.c (info_selectors_command, info_classes_command)
1509         (find_methods): Update.
1510         * minsyms.c (find_solib_trampoline_target): Update.
1511         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1512         * coffread.c (coff_symfile_read): Update.
1513         * ada-lang.c (ada_lookup_simple_minsym)
1514         (ada_collect_symbol_completion_matches): Update.
1515
1516 2019-01-16  Tom Tromey  <tom@tromey.com>
1517
1518         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1519         type.  Remove no-argument constructor.
1520         <iterator::operator++>: Simplify.
1521         <begin>: Update.
1522         <end>: Use minimal_symbol_count.
1523
1524 2019-01-16  Tom Tromey  <tom@tromey.com>
1525
1526         * objfiles.h (struct objfile) <psymtabs>: New method.
1527         (class objfile_psymtabs): Remove.
1528         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1529         typedef.
1530         <range>: New method.
1531         (require_partial_symbols): Change return type.
1532         * psymtab.c (require_partial_symbols)
1533         (psym_expand_symtabs_matching): Update.
1534         * mdebugread.c (parse_partial_symbols): Update.
1535         * dbxread.c (dbx_end_psymtab): Update.
1536
1537 2019-01-15  Tom Tromey  <tom@tromey.com>
1538
1539         * symtab.c (lookup_objfile_from_block)
1540         (lookup_symbol_in_objfile_symtabs)
1541         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1542         (find_line_symtab, info_sources_command)
1543         (default_collect_symbol_completion_matches_break_on)
1544         (make_source_files_completion_list): Update.
1545         * symmisc.c (print_objfile_statistics, dump_objfile)
1546         (maintenance_print_symbols, maintenance_info_symtabs)
1547         (maintenance_check_symtabs, maintenance_info_line_tables):
1548         Update.
1549         * source.c (select_source_symtab)
1550         (forget_cached_source_info_for_objfile): Update.
1551         * objfiles.h (class objfile_compunits): Remove.
1552         (struct objfile) <compunits_range>: New typedef.
1553         (compunits): New method.
1554         * objfiles.c (objfile_relocate1): Update.
1555         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1556         * maint.c (count_symtabs_and_blocks): Update.
1557         * linespec.c (iterate_over_all_matching_symtabs): Update.
1558         * cp-support.c (add_symbol_overload_list_qualified): Update.
1559         * coffread.c (coff_symtab_read): Update.
1560         * ada-lang.c (add_nonlocal_symbols)
1561         (ada_collect_symbol_completion_matches)
1562         (ada_add_global_exceptions): Update.
1563
1564 2019-01-15  Tom Tromey  <tom@tromey.com>
1565
1566         * progspace.h (program_space) <objfiles_safe_range>: New
1567         typedef.
1568         <objfiles_safe>: New method.
1569         * objfiles.h (class all_objfiles_safe): Remove.
1570         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1571         * jit.c (jit_inferior_exit_hook): Update.
1572
1573 2019-01-17  Tom Tromey  <tom@tromey.com>
1574
1575         * progspace.h (program_space) <objfiles_range>: New typedef.
1576         <objfiles>: New method.
1577         <objfiles_head>: Rename from objfiles.
1578         (object_files): Update.
1579         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1580         * guile/scm-pretty-print.c
1581         (ppscm_find_pretty_printer_from_objfiles): Update.
1582         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1583         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1584         Update.
1585         * python/py-progspace.c (pspy_get_objfiles): Update.
1586         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1587         Update.
1588         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1589         (objfpy_lookup_objfile_by_build_id): Update.
1590         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1591         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1592         Update.
1593         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1594         (expand_symtab_containing_pc, lookup_objfile_from_block)
1595         (lookup_static_symbol, basic_lookup_transparent_type)
1596         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1597         (find_line_symtab, info_sources_command)
1598         (default_collect_symbol_completion_matches_break_on)
1599         (make_source_files_completion_list, find_main_name): Update.
1600         * symmisc.c (print_symbol_bcache_statistics)
1601         (print_objfile_statistics, maintenance_print_symbols)
1602         (maintenance_print_msymbols, maintenance_print_objfiles)
1603         (maintenance_info_symtabs, maintenance_check_symtabs)
1604         (maintenance_expand_symtabs, maintenance_info_line_tables):
1605         Update.
1606         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1607         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1608         (map_overlay_command, unmap_overlay_command)
1609         (simple_overlay_update, expand_symtabs_matching)
1610         (map_symbol_filenames): Update.
1611         * symfile-debug.c (set_debug_symfile): Update.
1612         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1613         Update.
1614         * source.c (select_source_symtab, forget_cached_source_info):
1615         Update.
1616         * solib.c (solib_read_symbols): Update.
1617         * solib-spu.c (append_ocl_sos): Update.
1618         * psymtab.c (maintenance_print_psymbols)
1619         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1620         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1621         * printcmd.c (info_symbol_command): Update.
1622         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1623         Update.
1624         * objfiles.h (class all_objfiles): Remove.
1625         * objfiles.c (have_partial_symbols, have_full_symbols)
1626         (have_minimal_symbols, qsort_cmp, update_section_map)
1627         (shared_objfile_contains_address_p)
1628         (default_iterate_over_objfiles_in_search_order): Update.
1629         * objc-lang.c (info_selectors_command, info_classes_command)
1630         (find_methods): Update.
1631         * minsyms.c (find_solib_trampoline_target): Update.
1632         * maint.c (maintenance_info_sections)
1633         (maintenance_translate_address, count_symtabs_and_blocks):
1634         Update.
1635         * main.c (captured_main_1): Update.
1636         * linux-thread-db.c (try_thread_db_load_from_pdir)
1637         (has_libpthread): Update.
1638         * linespec.c (iterate_over_all_matching_symtabs)
1639         (search_minsyms_for_name): Update.
1640         * jit.c (jit_find_objf_with_entry_addr): Update.
1641         * hppa-tdep.c (find_unwind_entry)
1642         (hppa_lookup_stub_minimal_symbol): Update.
1643         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1644         Update.
1645         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1646         (elf_gnu_ifunc_resolve_by_got): Update.
1647         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1648         * dwarf-index-write.c (save_gdb_index_command): Update.
1649         * cp-support.c (add_symbol_overload_list_qualified): Update.
1650         * breakpoint.c (create_overlay_event_breakpoint)
1651         (create_longjmp_master_breakpoint)
1652         (create_std_terminate_master_breakpoint)
1653         (create_exception_master_breakpoint): Update.
1654         * blockframe.c (find_pc_partial_function): Update.
1655         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1656         (ada_collect_symbol_completion_matches)
1657         (ada_add_global_exceptions): Update.
1658
1659 2019-01-17  Tom Tromey  <tom@tromey.com>
1660
1661         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1662         declare VEC.
1663         (solib_target_parse_libraries): Change return type.
1664         (library_list_start_segment, library_list_start_section)
1665         (library_list_end_library, library_list_start_library); Update.
1666         (solib_target_free_library_list): Remove.
1667         (solib_target_parse_libraries): Remove cleanup.  Change return
1668         type.
1669         (solib_target_current_sos): Update.
1670
1671 2019-01-17  Tom Tromey  <tromey@bapiya>
1672
1673         * valprint.c: Replace "the the" with "the".
1674         * symtab.c: Replace "the the" with "the".
1675         * solib.c: Replace "the the" with "the".
1676         * solib-dsbt.c: Replace "the the" with "the".
1677         * linespec.c: Replace "the the" with "the".
1678         * dwarf2loc.h: Replace "the the" with "the".
1679         * amd64-windows-tdep.c: Replace "the the" with "the".
1680         * aarch64-tdep.c: Replace "the the" with "the".
1681
1682 2019-01-16  Keith Seitz  <keiths@redhat.com>
1683
1684         PR gdb/23773
1685         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1686         <builder>: Rename to ..
1687         <m_builder>: ... this and make private.
1688         (dwarf2_cu::get_builder): New method.  Change all users of
1689         `builder' to use this method.
1690         (dwarf2_start_symtab): Move to ...
1691         (dwarf2_cu::start_symtab): ... here.  Update all callers
1692         (setup_type_unit_groups): Move to ...
1693         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1694         callers.
1695         (dwarf2_cu::reset_builder): New method.
1696         (process_full_compunit, process_full_type_unit): Use
1697         dwarf2_cu::reset_builder.
1698         (follow_die_offset): Record the ancestor CU if it is different
1699         from the followed DIE's CU.
1700         (follow_die_sig_1): Likewise.
1701
1702 2019-01-15  Tom Tromey  <tom@tromey.com>
1703
1704         * remote.c (class remote_state) <buf>: Now a char_vector.
1705         <buf_size>: Remove.
1706         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1707         parameter.
1708         (remote_target::getpkt_or_notif_sane_1)
1709         (remote_target::getpkt_sane)
1710         (remote_target::getpkt_or_notif_sane): Likewise.
1711         (class remote_target) <putpkt>: New overload.
1712         (remote_target::read_frame): Change type of "buf_p".  Remove
1713         sizeof_p parameter.
1714         (packet_ok): New overload.
1715         (packet_check_result): New overload.
1716         Update all uses.
1717
1718 2019-01-14  Tom Tromey  <tom@tromey.com>
1719
1720         * remote-notif.c (handle_notification, remote_notif_ack)
1721         (remote_notif_parse): Make "buf" const.
1722         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1723         const.
1724         (remote_notif_parse, remote_notif_ack, handle_notification):
1725         Likewise.
1726         * remote.c (remote_notif_stop_parse): Make "buf" const.
1727         (remote_target::remote_parse_stop_reply): Make "buf" const.
1728         (remote_notif_stop_ack): Make "buf" const.
1729
1730 2019-01-14  Tom Tromey  <tom@tromey.com>
1731
1732         * remote.c (remote_console_output): Make parameter const.
1733
1734 2019-01-14  Tom Tromey  <tom@tromey.com>
1735
1736         * target-debug.h (target_debug_print_signals): Constify.
1737         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1738         * procfs.c (procfs_target::pass_signals): Update.
1739         * linux-nat.c (linux_nat_target::pass_signals): Update.
1740         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1741         * target-delegates.c: Rebuild.
1742         * remote.c (remote_target::program_signals): Update.
1743         (remote_target::pass_signals): Update.
1744         * target.c (target_pass_signals): Constify argument.
1745         (target_program_signals): Likewise.
1746         * target.h (struct target_ops) <pass_signals, program_signals>:
1747         Constify argument.
1748         (target_pass_signals, target_program_signals): Constify argument.
1749
1750 2019-01-14  Tom Tromey  <tom@tromey.com>
1751
1752         PR tui/28819:
1753         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1754
1755 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1756
1757         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1758         field.
1759         * rs6000-tdep.c: Include reggroups.h.
1760         (IS_V_ALIAS_PSEUDOREG): Define.
1761         (rs6000_register_name): Return names for the "vX" aliases.
1762         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1763         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1764         aliases.  Call default_register_reggroup_p for all other
1765         pseudo-registers.
1766         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1767         New functions.
1768         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1769         Handle "vX" aliases.
1770         (v_alias_pseudo_register_collect): New function.
1771         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1772         (rs6000_gdbarch_init): Initialize "vX" aliases as
1773         pseudo-registers.  Restore registration of
1774         rs6000_pseudo_register_reggroup_p with
1775         set_tdesc_pseudo_register_reggroup_p.
1776
1777 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1778
1779         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1780         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1781         set_gdbarch_num_pseudo_regs.
1782
1783 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1784
1785         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1786         Remove arg prefixname, add do_set and do_show.
1787         Add member functions set_list and show_list.
1788         * cli/cli-style.c (class cli_style_option): Update accordingly.
1789         (style_set_list): Move to file scope.
1790         (style_show_list): Likewise.
1791         (set_style): Call help_list.
1792         (show_style): Call cmd_show_list.
1793         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1794         Update to use the new macro.
1795
1796 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1797
1798         * ada-lang.c (_initialize_ada_language): Expand the help text
1799         for the "catch exception" command.
1800
1801 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1802
1803         * symtab.c (matching_obj_sections): Initialize obj,
1804         declare it closer to its usage.
1805
1806 2019-01-10  Tom Tromey  <tom@tromey.com>
1807
1808         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1809         (basic_inf_threads_range): Remove.
1810         (inf_threads_range, inf_non_exited_threads_range)
1811         (safe_inf_threads_range): Use next_adapter.
1812
1813 2019-01-10  Keith Seitz  <keiths@redhat.com>
1814
1815         PR gdb/23712
1816         PR symtab/23010
1817         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1818         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1819
1820 2019-01-10  Keith Seitz  <keiths@redhat.com>
1821
1822         PR gdb/23712
1823         PR symtab/23010
1824         * dictionary.c (pending_to_vector): Remove.
1825         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1826         Remove _1 suffix, replacing functions of the same name.  Update
1827         all callers.
1828         (dict_create_hashed, dict_create_hashed_expandable)
1829         (dict_create_linear, dict_create_linear_expandable, dict_free)
1830         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1831         Make functions static.
1832
1833 2019-01-10  Keith Seitz  <keiths@redhat.com>
1834
1835         PR gdb/23712
1836         PR symtab/23010
1837         * dictionary.h (struct dictionary): Replace declaration with
1838         multidictionary.
1839         (dict_create_hashed, dict_create_hashed_expandable)
1840         (dict_create_linear, dict_create_linear_expandable)
1841         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1842         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1843         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1844         taking multidictionary argument.
1845         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1846         * block.h (struct block) <dict>: Change to multidictionary
1847         and rename `multidict'.
1848         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1849         symmisc.c: Update all dictionary references to multidictionary.
1850
1851 2019-01-10  Keith Seitz  <keiths@redhat.com>
1852
1853         PR gdb/23712
1854         PR symtab/23010
1855         * dictionary.c: Include unordered_map.
1856         (pending_to_vector): New function.
1857         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1858         Rewrite the non-"_1" functions to take vector instead
1859         of linked list.
1860         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1861         "new" _1 versions of the same name.
1862         (multidictionary): Define.
1863         (std::hash<enum language): New definition.
1864         (collate_pending_symbols_by_language, mdict_create_hashed)
1865         (mdict_create_hashed_expandable, mdict_create_linear)
1866         (mdict_create_linear_expandable, mdict_free)
1867         (find_language_dictionary, create_new_language_dictionary)
1868         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1869         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1870         (mdict_size, mdict_empty): New functions.
1871         * dictionary.h (mdict_iterator): Define.
1872
1873 2019-01-10  Pedro Alves  <palves@redhat.com>
1874
1875         * breakpoint.c (read_uploaded_action)
1876         (create_tracepoint_from_upload): Adjust to use
1877         gdb::unique_xmalloc_ptr.
1878         * ctf.c (ctf_write_uploaded_tp):
1879         (SET_ARRAY_FIELD): Use emplace_back.
1880         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1881         * tracefile-tfile.c (tfile_write_uploaded_tp):
1882         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1883         gdb::unique_xmalloc_ptr.
1884         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1885         at_string, cond_string, cmd_strings>: Replace char pointers
1886         with gdb::unique_xmalloc_ptr.
1887
1888 2019-01-10  Pedro Alves  <palves@redhat.com>
1889
1890         * solib-target.c (library_list_start_library): Don't xstrdup name.
1891
1892 2019-01-10  Pedro Alves  <palves@redhat.com>
1893
1894         * mdebugread.c (parse_partial_symbols): Use
1895         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1896
1897 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1898
1899         * linux-fork.c (scoped_switch_fork_info)
1900         <~scoped_switch_fork_info>: Fix incorrect variable name.
1901
1902 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1903
1904         * linux-fork.c (scoped_switch_fork_info)
1905         <scoped_switch_fork_info>: Make explicit.
1906         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1907
1908 2019-01-10  Tom Tromey  <tom@tromey.com>
1909
1910         * objfiles.h (objfile::reset_psymtabs): Update.
1911         * objfiles.c (objfile::objfile): Update.
1912         * psymtab.h (psymtab_storage::obstack): Update.
1913         (psymtab_storage::m_obstack): Use gdb::optional.
1914         (class psymtab_storage): Update comment.  Remove objfile
1915         parameter.
1916         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1917
1918 2019-01-10  Tom Tromey  <tom@tromey.com>
1919
1920         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1921         <free_psymtabs>: Now private.
1922         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1923         (allocate_psymtab): Use new method.
1924
1925 2019-01-10  Tom Tromey  <tom@tromey.com>
1926
1927         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1928         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1929         * mdebugread.c (parse_partial_symbols): Use
1930         allocate_dependencies.
1931         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1932         allocate_dependencies.
1933         (process_psymtab_comp_unit_reader)
1934         (build_type_psymtab_dependencies): Likewise.
1935         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1936
1937 2019-01-10  Tom Tromey  <tom@tromey.com>
1938
1939         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1940         PSYMBOL_SET_LANGUAGE.
1941         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1942
1943 2019-01-10  Tom Tromey  <tom@tromey.com>
1944
1945         * psymtab.h (psymtab_storage::obstack): New method.
1946         <m_obstack>: Rename from obstack; now private.
1947         * psymtab.c (psymtab_storage): Update.
1948         * dwarf2read.c (create_addrmap_from_index)
1949         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1950         Update.
1951
1952 2019-01-10  Tom Tromey  <tom@tromey.com>
1953
1954         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1955         * objfiles.h (objfile::reset_psymtabs): New method.
1956
1957 2019-01-10  Tom Tromey  <tom@tromey.com>
1958
1959         * symmisc.c (print_symbol_bcache_statistics): Update.
1960         (print_objfile_statistics): Update.
1961         * symfile.c (reread_symbols): Update.
1962         * psymtab.h (class psymtab_storage): New.
1963         * psymtab.c (psymtab_storage): New constructor.
1964         (~psymtab_storage): New destructor.
1965         (require_partial_symbols): Update.
1966         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1967         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1968         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1969         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1970         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1971         (start_psymtab_common, end_psymtab_common)
1972         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1973         (allocate_psymtab): Update.
1974         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1975         Update.
1976         (dump_psymtab_addrmap, maintenance_print_psymbols)
1977         (maintenance_check_psymtabs): Update.
1978         (class objfile_psymtabs): Move to objfiles.h.
1979         * psympriv.h (discard_psymtab): Now inline.
1980         (psymtab_discarder::psymtab_discarder): Update.
1981         (psymtab_discarder::~psymtab_discarder): Update.
1982         (ALL_OBJFILE_PSYMTABS): Rewrite.
1983         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1984         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1985         Remove fields.
1986         <partial_symtabs>: New field.
1987         (class objfile_psymtabs): Move from psymtab.h.  Update.
1988         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1989         psymbol_cache.
1990         (objfile::~objfile): Don't destroy psymbol_cache.
1991         * mdebugread.c (parse_partial_symbols): Update.
1992         * dwarf2read.c (create_addrmap_from_index)
1993         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1994         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1995         (add_partial_subprogram, dwarf2_ranges_read): Update.
1996         * dwarf-index-write.c (write_address_map)
1997         (write_one_signatured_type, recursively_write_psymbols)
1998         (class debug_names, class debug_names, write_psymtabs_to_index):
1999         Update.
2000
2001 2019-01-10  Tom Tromey  <tom@tromey.com>
2002
2003         * symtab.h (SYMBOL_SET_NAMES): Update.
2004         (symbol_set_names): Update.
2005         (MSYMBOL_SET_NAMES): Update.
2006         * symtab.c (symbol_set_names): Change argument to be an
2007         objfile_per_bfd_storage.
2008         * psymtab.c (add_psymbol_to_bcache): Update.
2009         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2010
2011 2019-01-10  Tom Tromey  <tom@tromey.com>
2012
2013         * symtab.c (create_demangled_names_hash): Change argument to be an
2014         objfile_per_bfd_storage.
2015         (symbol_set_names): Update.
2016
2017 2019-01-10  Tom Tromey  <tom@tromey.com>
2018
2019         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2020         init_psymbol_list.
2021         * psymtab.c (init_psymbol_list): Do nothing if already called.
2022         * psympriv.h (init_psymbol_list): Add comment.
2023         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2024         init_psymbol_list.
2025         * dbxread.c (dbx_symfile_read): Unconditionally call
2026         init_psymbol_list.
2027
2028 2019-01-10  Tom Tromey  <tom@tromey.com>
2029
2030         * xcoffread.c (scan_xcoff_symtab): Update.
2031         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2032         "where".
2033         * mdebugread.c (parse_partial_symbols)
2034         (handle_psymbol_enumerators): Update.
2035         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2036         * dbxread.c (read_dbx_symtab): Update.
2037         * psympriv.h (psymbol_placement): New enum.
2038         (add_psymbol_to_list): Update.
2039
2040 2019-01-10  Tom Tromey  <tom@tromey.com>
2041
2042         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2043         static_psymbols parameters.
2044         (scan_xcoff_symtab): Update.
2045         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2046         static_psymbols parameters.
2047         * psympriv.h (start_psymtab_common): Update.
2048         * mdebugread.c (parse_partial_symbols): Update.
2049         * dwarf2read.c (create_partial_symtab): Update.
2050         * dbxread.c (read_dbx_symtab): Update.
2051         (start_psymtab): Remove global_psymbols and static_psymbols
2052         parameters.
2053
2054 2019-01-10  Tom Tromey  <tom@tromey.com>
2055
2056         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2057         * psymtab.c (allocate_psymtab): Add comment.
2058         * psympriv.h (allocate_psymtab): Add comment.
2059         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2060         initializations.
2061         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2062
2063 2019-01-10  Tom Tromey  <tom@tromey.com>
2064
2065         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2066         Don't declare.
2067         * mipsread.c: Include mdebugread.h.
2068         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2069         Declare.
2070         * elfread.c: Include mdebugread.h.
2071
2072 2019-01-09  Tom Tromey  <tom@tromey.com>
2073
2074         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2075         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2076         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2077         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2078         (psym_lookup_symbol, psym_find_last_source_symtab)
2079         (psym_forget_cached_source_info, psym_print_stats)
2080         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2081         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2082         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2083         (psym_find_compunit_symtab_by_address)
2084         (maintenance_print_psymbols, maintenance_info_psymtabs)
2085         (maintenance_check_psymtabs): Use ranged for.
2086         * psymtab.h (class objfile_psymtabs): New.
2087         (require_partial_symbols): Return objfile_psymtabs.
2088         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2089
2090 2019-01-09  Tom Tromey  <tom@tromey.com>
2091
2092         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2093         (find_pc_mapped_section, list_overlays_command)
2094         (map_overlay_command, unmap_overlay_command)
2095         (simple_overlay_update): Use all_objfiles.
2096         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2097         * printcmd.c (info_symbol_command): Use all_objfiles.
2098         * objfiles.h (ALL_OBJSECTIONS): Remove.
2099         * maint.c (maintenance_translate_address): Use all_objfiles.
2100         * gcore.c (gcore_create_callback): Use all_objfiles.
2101         (objfile_find_memory_regions): Likewise.
2102
2103 2019-01-09  Tom Tromey  <tom@tromey.com>
2104
2105         * symtab.c (find_line_symtab, info_sources_command)
2106         (make_source_files_completion_list): Use objfile_compunits.
2107         * source.c (select_source_symtab): Use objfile_compunits.
2108         * objfiles.h (struct objfile): Update comment.
2109         (ALL_OBJFILES): Remove.
2110         (ALL_FILETABS): Remove.
2111         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2112         objfile_compunits.
2113
2114 2019-01-09  Tom Tromey  <tom@tromey.com>
2115
2116         * symmisc.c (print_objfile_statistics, dump_objfile)
2117         (maintenance_print_symbols): Use compunit_filetabs.
2118         * source.c (forget_cached_source_info_for_objfile): Use
2119         compunit_filetabs.
2120         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2121         (ALL_FILETABS): Use compunit_filetabs.
2122         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2123         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2124
2125 2019-01-09  Tom Tromey  <tom@tromey.com>
2126
2127         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2128         (compunit_filetabs): New.
2129         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2130         compunit_filetabs.
2131         (info_sources_command, make_source_files_completion_list): Remove
2132         declaration.
2133         * symmisc.c (print_objfile_statistics, dump_objfile)
2134         (maintenance_print_symbols): Remove declaration.
2135         (maintenance_info_symtabs): Use compunit_filetabs.
2136         (maintenance_info_line_tables): Likewise.
2137         * source.c (select_source_symtab): Change local variable name.
2138         (forget_cached_source_info_for_objfile): Remove declaration.
2139         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2140         * objfiles.c (objfile_relocate1): Remove declaration.
2141         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2142         declaration.
2143         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2144         * coffread.c (coff_symtab_read): Remove declaration.
2145         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2146         compunit_filetabs.
2147
2148 2019-01-09  Tom Tromey  <tom@tromey.com>
2149
2150         * symtab.c (lookup_objfile_from_block)
2151         (find_pc_sect_compunit_symtab, search_symbols)
2152         (default_collect_symbol_completion_matches_break_on): Use
2153         objfile_compunits.
2154         * objfiles.h (ALL_COMPUNITS): Remove.
2155         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2156         * cp-support.c (add_symbol_overload_list_qualified): Use
2157         objfile_compunits.
2158         * ada-lang.c (ada_collect_symbol_completion_matches)
2159         (ada_add_global_exceptions): Use objfile_compunits.
2160
2161 2019-01-09  Tom Tromey  <tom@tromey.com>
2162
2163         * source.c (select_source_symtab)
2164         (forget_cached_source_info_for_objfile): Remove declaration.
2165         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2166         declaration.
2167         * maint.c (count_symtabs_and_blocks): Remove declaration.
2168         * cp-support.c (add_symbol_overload_list_qualified): Remove
2169         declaration.
2170         * coffread.c (coff_symtab_read): Remove declaration.
2171         * symtab.c (lookup_symbol_in_objfile_symtabs)
2172         (basic_lookup_transparent_type_1): Use objfile_compunits.
2173         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2174         (info_sources_command, search_symbols)
2175         (default_collect_symbol_completion_matches_break_on)
2176         (make_source_files_completion_list): Remove declaration.
2177         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2178         (ada_collect_symbol_completion_matches)
2179         (ada_add_global_exceptions): Remove declaration.
2180         * linespec.c (iterate_over_all_matching_symtabs): Use
2181         objfile_compunits.
2182         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2183         (class objfile_compunits): New.
2184         (ALL_COMPUNITS): Use objfile_compunits.
2185         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2186         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2187         objfile_compunits.
2188         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2189
2190 2019-01-09  Tom Tromey  <tom@tromey.com>
2191
2192         * symtab.c (search_symbols)
2193         (default_collect_symbol_completion_matches_break_on): Use
2194         objfile_msymbols.
2195         * ada-lang.c (ada_lookup_simple_minsym)
2196         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2197         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2198         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2199         objfile_msymbols.
2200         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2201         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2202         * objc-lang.c (find_methods): Use objfile_msymbols.
2203         (info_selectors_command, info_classes_command): Likewise.
2204         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2205         * objfiles.h (class objfile_msymbols): New.
2206         (ALL_OBJFILE_MSYMBOLS): Remove.
2207         (ALL_MSYMBOLS): Remove.
2208
2209 2019-01-09  Tom Tromey  <tom@tromey.com>
2210
2211         * common/next-iterator.h (next_adapter): Add Iterator template
2212         parameter.
2213         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2214         (class all_objfiles_safe): New.
2215         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2216         * objfiles.c (put_objfile_before): Update comment.
2217         (add_separate_debug_objfile): Likewise.
2218         (free_all_objfiles): Use all_objfiles_safe.
2219         (objfile_purge_solibs): Likewise.
2220
2221 2019-01-09  Tom Tromey  <tom@tromey.com>
2222
2223         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2224         (expand_symtab_containing_pc, lookup_static_symbol)
2225         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2226         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2227         all_objfiles.
2228         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2229         * breakpoint.c (create_overlay_event_breakpoint)
2230         (create_longjmp_master_breakpoint)
2231         (create_std_terminate_master_breakpoint)
2232         (create_exception_master_breakpoint): Use all_objfiles.
2233         * linux-thread-db.c (try_thread_db_load_from_pdir)
2234         (has_libpthread): Use all_objfiles.
2235         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2236         * linespec.c (iterate_over_all_matching_symtabs)
2237         (search_minsyms_for_name): Use all_objfiles.
2238         * maint.c (maintenance_info_sections): Use all_objfiles.
2239         * main.c (captured_main_1): Use all_objfiles.
2240         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2241         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2242         * guile/scm-pretty-print.c
2243         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2244         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2245         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2246         (maintenance_print_msymbols): Use all_objfiles.
2247         * source.c (select_source_symtab): Use all_objfiles.
2248         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2249         * symfile.c (remove_symbol_file_command)
2250         (expand_symtabs_matching, map_symbol_filenames): Use
2251         all_objfiles.
2252         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2253         all_objfiles.
2254         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2255         * objc-lang.c (find_methods): Use all_objfiles.
2256         * objfiles.c (have_partial_symbols, have_full_symbols)
2257         (have_minimal_symbols, qsort_cmp)
2258         (default_iterate_over_objfiles_in_search_order): Use
2259         all_objfiles.
2260         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2261         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2262         (maintenance_check_psymtabs): Use all_objfiles.
2263         (ALL_PSYMTABS): Remove.
2264         * compile/compile-object-run.c (do_module_cleanup): Use
2265         all_objfiles.
2266         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2267         * cp-support.c (add_symbol_overload_list_qualified): Use
2268         all_objfiles.
2269         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2270         Use all_objfiles.
2271         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2272         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2273         all_objfiles.
2274         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2275         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2276         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2277         Uses all_objfiles.
2278         * solib.c (solib_read_symbols): Use all_objfiles
2279
2280 2019-01-09  Tom Tromey  <tom@tromey.com>
2281
2282         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2283         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2284         all_objfiles.
2285         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2286         * symmisc.c (print_symbol_bcache_statistics)
2287         (print_objfile_statistics, maintenance_print_objfiles)
2288         (maintenance_info_symtabs, maintenance_check_symtabs)
2289         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2290         all_objfiles.
2291         * source.c (forget_cached_source_info): Use all_objfiles.
2292         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2293         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2294         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2295         * objfiles.c (update_section_map): Use all_objfiles.
2296         (shared_objfile_contains_address_p): Likewise.
2297         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2298         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2299
2300 2019-01-09  Tom Tromey  <tom@tromey.com>
2301
2302         * common/next-iterator.h: New file.
2303         * objfiles.h (class all_objfiles): New.
2304         (struct objfile_iterator): New.
2305
2306 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2307
2308         * NEWS: Move the description of the changed "frame", "select-frame",
2309          and "info frame" commands to the Changed commands section.
2310
2311 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2312
2313         * gdbtypes.c (check_stub_method_group): Remove handling of old
2314         mangling schemes.
2315         * linespec.c (find_methods): Likewise.
2316         * stabsread.c (read_member_functions): Likewise.
2317         * valops.c (search_struct_method): Likewise.
2318         (value_struct_elt_for_reference): Likewise.
2319         * NEWS: Mention this change.
2320
2321 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2322
2323         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2324         print_source_lines.
2325         * source.c (print_source_lines_base): Update line number check.
2326         (print_source_lines): New function.
2327         (source_lines_range::source_lines_range): New function.
2328         * source.h (class source_lines_range): New class.
2329         (print_source_lines): New declaration.
2330
2331 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2332
2333         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2334
2335 2019-01-08  Tom Tromey  <tom@tromey.com>
2336             Simon Marchi  <simon.marchi@ericsson.com>
2337
2338         PR gdb/24060
2339         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2340         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2341         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2342         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2343         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2344         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2345
2346 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2347
2348         * source.c (select_source_symtab): Move header comment to
2349         declaration in source.h.
2350         (forget_cached_source_info_for_objfile): Likewise.
2351         (forget_cached_source_info): Likewise.
2352         (identify_source_line): Likewise.
2353         * source.h (identify_source_line): Move declaration from symtab.h
2354         and add comment from source.c
2355         (print_source_lines): Likewise.
2356         (forget_cached_source_info_for_objfile): Likewise.
2357         (forget_cached_source_info): Likewise.
2358         (select_source_symtab): Likewise.
2359         (enum print_source_lines_flag): Move definition from symtab.h.
2360         * symtab.h (identify_source_line): Move declaration to source.h.
2361         (print_source_lines): Likewise.
2362         (forget_cached_source_info_for_objfile): Likewise.
2363         (forget_cached_source_info): Likewise.
2364         (select_source_symtab): Likewise.
2365         (enum print_source_lines_flag): Move definition to source.h.
2366         * tui/tui-hooks.c: Add 'source.h' include.
2367
2368 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2369
2370         * source.c (print_source_lines_base): Handle requests to print
2371         reverse line number sequences, and guard against empty lines
2372         string.
2373
2374 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2375
2376         * source.c (print_source_lines_base): Fix skip of '\r' if next
2377         character is '\n'.
2378
2379 2019-01-06  Tom Tromey  <tom@tromey.com>
2380
2381         * c-exp.y (struct c_parse_state) <macro_original_text,
2382         expansion_obstack>: New member.
2383         (macro_original_text, expansion_obstack): Remove globals.
2384         (scan_macro_expansion, scanning_macro_expansion)
2385         (finished_macro_expansion): Update.
2386         (scan_macro_cleanup): Remove.
2387         (yylex, c_parse): Update.
2388
2389 2019-01-06  Tom Tromey  <tom@tromey.com>
2390
2391         * c-exp.y (struct c_parse_state) <strings>: New member.
2392         (operator_stoken): Update.
2393
2394 2019-01-06  Tom Tromey  <tom@tromey.com>
2395
2396         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2397         (union type_stack_elt) <typelist_val>: Now a pointer to
2398         std::vector.
2399         (type_stack_cleanup): Don't declare.
2400         (push_typelist): Update.
2401         * parse.c (pop_typelist): Return a std::vector.
2402         (push_typelist): Take a std::vector.
2403         (follow_types): Update.  Do not free args.
2404         (type_stack_cleanup): Remove.
2405         * c-exp.y (struct c_parse_state): New.
2406         (cpstate): New global.
2407         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2408         (nonempty_typelist): Update.
2409         (func_mod): Create a new vector.
2410         (c_parse): Create a c_parse_state.
2411         (check_parameter_typelist): Do not delete params.
2412         (function_method): Update.  Do not delete type_list.
2413
2414 2019-01-06  Tom Tromey  <tom@tromey.com>
2415
2416         PR gdb/28155:
2417         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2418         check_typedef.
2419         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2420         (print_return_value): Likewise.
2421
2422 2019-01-05  Tom Tromey  <tom@tromey.com>
2423
2424         * contrib/cleanup_check.py: Remove.
2425         * contrib/gcc-with-excheck: Remove.
2426         * contrib/exsummary.py: Remove.
2427         * contrib/excheck.py: Remove.
2428
2429 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2430
2431         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2432         NULL. Initialize tpprev to NULL instead of assigning it
2433         to NULL on the next statement.
2434         * windows-nat.c (windows_delete_thread): Remove check for
2435         main_thread_id before printing thread exit notifications.
2436         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2437         Remove thread ID check against main_thread_id.
2438         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2439         windows_delete_thread.
2440         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2441
2442 2019-01-04  Tom Tromey  <tom@tromey.com>
2443
2444         * compile/compile.c (_initialize_compile): Use upper case for
2445         metasyntactic variables.
2446         * symmisc.c (_initialize_symmisc): Use upper case for
2447         metasyntactic variables.
2448         * psymtab.c (_initialize_psymtab): Use upper case for
2449         metasyntactic variables.
2450         * demangle.c (demangle_command): Use upper case for metasyntactic
2451         variables.
2452         (_initialize_demangler): Likewise.
2453         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2454         variables.
2455
2456 2019-01-03  Tom Tromey  <tom@tromey.com>
2457
2458         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2459
2460 2019-01-03  Tom Tromey  <tom@tromey.com>
2461
2462         * python/py-symtab.c (salpy_str): Update.
2463         (struct salpy_sal_object) <symtab>: Now a PyObject.
2464         (salpy_dealloc): Update.
2465         (del_objfile_sal): Use gdbpy_ref.
2466
2467 2019-01-03  Tom Tromey  <tom@tromey.com>
2468
2469         * python/py-type.c (convert_field): Use new_reference.  Return
2470         gdbpy_ref.
2471         (make_fielditem): Return gdbpy_ref.
2472         (typy_fields): Update.
2473         (typy_getitem): Update.
2474         (field_name): Return gdbpy_ref.  Use new_reference.
2475         (typy_iterator_iternext): Update.
2476
2477 2019-01-03  Tom Tromey  <tom@tromey.com>
2478
2479         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2480
2481 2019-01-03  Tom Tromey  <tom@tromey.com>
2482
2483         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2484         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2485         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2486         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2487         (pspy_set_type_printers): Likewise.
2488         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2489         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2490         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2491         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2492         (objfpy_set_type_printers): Likewise.
2493
2494 2019-01-03  Tom Tromey  <tom@tromey.com>
2495
2496         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2497         (gdbpy_print_stack): Use gdbpy_err_fetch.
2498         * python/python-internal.h (class gdbpy_err_fetch): New class.
2499         (class gdbpy_enter) <m_error_type, m_error_value,
2500         m_error_traceback>: Remove.
2501         <m_error>: New member.
2502         (gdbpy_exception_to_string): Don't declare.
2503         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2504         * python/py-value.c (convert_value_from_python): Use
2505         gdbpy_err_fetch.
2506         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2507         gdbpy_exception_to_string.
2508         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2509         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2510         gdbpy_err_fetch.
2511
2512 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2513
2514         * linux-nat.c (delete_lwp_cleanup): Delete.
2515         (struct lwp_deleter): New struct.
2516         (lwp_info_up): New typedef.
2517         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2518         lwp_info_up.
2519
2520 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * linux-fork.c (class scoped_switch_fork_info): New class.
2523         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2524
2525 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2526
2527         * valops.c (find_overload_match): Remove use of null_cleanup, and
2528         calls to do_cleanups.
2529
2530 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2531
2532         * compile/compile-cplus-types.c
2533         (compile_cplus_instance::decl_name): Handle changes to
2534         cp_func_name.
2535         * cp-support.c (cp_func_name): Update header comment, update
2536         return type.
2537         * cp-support.h (cp_func_name): Update return type in declaration.
2538         * valops.c (find_overload_match): Move temp_func local to top
2539         level of function and change its type.  Use temp_func to hold and
2540         delete temporary string obtained from cp_func_name.
2541
2542 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2543
2544         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2545         gdb::char_vector, remove cleanup, and update uses of `msg`.
2546
2547 2019-01-03  Jim Wilson  <jimw@sifive.com>
2548
2549         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2550
2551 2019-01-02  Tom Tromey  <tom@tromey.com>
2552
2553         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2554         (tdesc_parse_xml): Remove cleanups.
2555         * target-descriptions.h (make_cleanup_free_target_description):
2556         Don't declare.
2557         (target_desc_deleter): New struct.
2558         (target_desc_up): New typedef.
2559         * target-descriptions.c (target_desc_deleter::operator()): Rename
2560         from free_target_description.
2561         (make_cleanup_free_target_description): Remove.
2562
2563 2019-01-02  Tom Tromey  <tom@tromey.com>
2564
2565         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2566         constructor, destructor.
2567         (linespec_parser): Remove typedef.
2568         (~linespec_parser): Rename from linespec_parser_delete.
2569         (linespec_lex_to_end, linespec_complete_label)
2570         (linespec_complete): Update.
2571         (decode_line_full): Remove cleanups.
2572         (decode_line_1): Update.
2573
2574 2019-01-02  Tom Tromey  <tom@tromey.com>
2575
2576         * python/python-internal.h (inferior_to_inferior_object): Change
2577         return type.
2578         * python/py-exitedevent.c (create_exited_event_object): Update.
2579         * python/py-inferior.c (inferior_to_inferior_object): Return
2580         gdbpy_ref.
2581         (python_new_inferior, python_inferior_deleted)
2582         (thread_to_thread_object, delete_thread_object)
2583         (build_inferior_list, gdbpy_selected_inferior): Update.
2584         * python/py-infthread.c (create_thread_object): Update.  Also fail
2585         if inferior_to_inferior_object fails.
2586
2587 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2588
2589         * inferior.h (class inferior) <displaced_step_state>: New field.
2590         * infrun.h (struct displaced_step_state): Move here from
2591         infrun.c.  Initialize fields, add constructor.
2592         <inf>: Remove field.
2593         <reset>: New method.
2594         * infrun.c (struct displaced_step_inferior_state): Move to
2595         infrun.h.
2596         (displaced_step_inferior_states): Remove.
2597         (get_displaced_stepping_state): Adust.
2598         (displaced_step_in_progress_any_inferior): Adjust.
2599         (displaced_step_in_progress_thread): Adjust.
2600         (displaced_step_in_progress): Adjust.
2601         (add_displaced_stepping_state): Remove.
2602         (get_displaced_step_closure_by_addr): Adjust.
2603         (remove_displaced_stepping_state): Remove.
2604         (infrun_inferior_exit): Call displaced_step_state.reset.
2605         (use_displaced_stepping): Don't check for NULL.
2606         (displaced_step_prepare_throw): Call
2607         get_displaced_stepping_state.
2608         (displaced_step_fixup): Don't check for NULL.
2609         (prepare_for_detach): Don't check for NULL.
2610
2611 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2612
2613         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2614          in case of call that did not complete.
2615
2616 2019-01-02  Andrey Utkin  <autkin@undo.io>
2617
2618         * symfile.c (find_separate_debug_file): Fix search of debug files for
2619         remote debuggee.
2620
2621 2019-01-02  Tom Tromey  <tom@tromey.com>
2622
2623         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2624         indentation.
2625         * python/py-frame.c (frapy_older): Remove cast.
2626         (frapy_newer): Likewise.
2627         * python/py-breakpoint.c (local_setattro): Remove cast.
2628         * python/py-arch.c (archpy_name): Remove local variable.
2629         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2630
2631 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2632
2633         * unittests/basic_string_view/element_access/char/empty.cc:
2634         Fix year range in copyright header.
2635
2636 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2637
2638         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2639         Delete.
2640         <operator==>: Update with for removed field.
2641         <hash>: Likewise.
2642         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2643         <isa_features>: ...this.
2644         <abi_features>: New field.
2645         (riscv_isa_flen): Update comment.
2646         (riscv_abi_xlen): New declaration.
2647         (riscv_abi_flen): New declaration.
2648         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2649         isa_features.
2650         (riscv_abi_xlen): New function.
2651         (riscv_isa_flen): Update to get answer from isa_features.
2652         (riscv_abi_flen): New function.
2653         (riscv_has_fp_abi): Update to get answer from abi_features.
2654         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2655         xlen and flen.
2656         (riscv_call_info) <xlen, flen>: Update comment.
2657         (riscv_call_arg_struct): Remove invalid assertions
2658         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2659         is removed.
2660         (riscv_gdbarch_init): Gather isa features and abi features
2661         separately, ensure both match on the gdbarch when reusing an old
2662         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2663         a target with 64-bit float hardware.
2664
2665 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2666
2667         * source.c (search_command_helper): Stop reverse search
2668         when line 1 has been searched.
2669
2670 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2671
2672         * record-full.c (record_full_base_target::close): Rewrite
2673         record_full_core_buf_list free logic.
2674
2675 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2676
2677         * break-catch-syscall.c (print_one_catch_syscall): xfree
2678         the last text.
2679
2680 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2681
2682         * top.c (print_gdb_version): Update Copyright year in version
2683         message.
2684
2685 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2686
2687         Update copyright year range in all GDB files.
2688
2689 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2690
2691         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2692
2693 For older changes see ChangeLog-2018.
2694 \f
2695 Local Variables:
2696 mode: change-log
2697 left-margin: 8
2698 fill-column: 74
2699 version-control: never
2700 coding: utf-8
2701 End:
2702