gdb/ChangeLog

   1 2019-02-17  Tom Tromey  <tom@tromey.com>
   2
   3         PR tui/24197:
   4         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
   5
   6 2019-02-17  Tom Tromey  <tom@tromey.com>
   7
   8         * ada-lang.c (user_select_syms): Use filtered printing.
   9         * utils.c (wrap_style): New global.
  10         (desired_style): Remove.
  11         (emit_style_escape): Add stream parameter.
  12         (set_output_style, reset_terminal_style, prompt_for_continue):
  13         Update.
  14         (flush_wrap_buffer): Only flush gdb_stdout.
  15         (wrap_here): Set wrap_style.
  16         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  17         treat escape sequences as a character.  Change when wrap buffer is
  18         flushed.
  19         (fputs_styled): Do not set the output style when the default is
  20         requested.
  21         * ui-style.h (struct ui_file_style) <is_default>: New method.
  22         * source.c (print_source_lines_base): Emit escape sequences in one
  23         piece.
  24
  25 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  26
  27         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  28         integers and enumeration types.
  29
  30 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  31
  32         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
  33         instead of lookup_symbol_in_language
  34         (do_exact_match): New function.
  35         (ada_get_symbol_name_matcher): Return do_exact_match when
  36         doing a verbatim match.
  37
  38 2019-02-15  Tom Tromey  <tromey@adacore.com>
  39
  40         * ravenscar-thread.c (ravenscar_thread_target::resume)
  41         (ravenscar_thread_target::wait): Special case wildcard requests.
  42
  43 2019-02-15  Tom Tromey  <tromey@adacore.com>
  44
  45         * ravenscar-thread.c (base_ptid): Remove.
  46         (struct ravenscar_thread_target) <close>: New method.
  47         <m_base_ptid>: New member.
  48         <update_inferior_ptid, active_task, task_is_currently_active,
  49         runtime_initialized>: Declare methods.
  50         <ravenscar_thread_target>: Add constructor.
  51         (ravenscar_thread_target::task_is_currently_active)
  52         (ravenscar_thread_target::update_inferior_ptid)
  53         (ravenscar_runtime_initialized): Rename.  Now methods.
  54         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
  55         (ravenscar_thread_target::update_thread_list): Update.
  56         (ravenscar_thread_target::active_task): Now method.
  57         (ravenscar_thread_target::store_registers)
  58         (ravenscar_thread_target::prepare_to_store)
  59         (ravenscar_thread_target::prepare_to_store)
  60         (ravenscar_thread_target::mourn_inferior): Update.
  61         (ravenscar_inferior_created): Use "new" to create target.
  62         (ravenscar_thread_target::get_ada_task_ptid): Update.
  63         (_initialize_ravenscar): Don't initialize base_ptid.
  64         (ravenscar_ops): Remove global.
  65
  66 2019-02-15  Tom Tromey  <tromey@adacore.com>
  67
  68         * target.h (push_target): Declare new overload.
  69         * target.c (push_target): New overload, taking an rvalue reference.
  70         * remote.c (remote_target::open_1): Use push_target overload.
  71         * corelow.c (core_target_open): Use push_target overload.
  72
  73 2019-02-15  Tom Tromey  <tromey@adacore.com>
  74
  75         * ravenscar-thread.c (is_ravenscar_task)
  76         (ravenscar_task_is_currently_active): Return bool.
  77         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
  78         (_initialize_ravenscar): Remove "(void)".
  79         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
  80         Return bool.
  81
  82 2019-02-15  Tom Tromey  <tromey@adacore.com>
  83
  84         * ravenscar-thread.c (ravenscar_runtime_initializer)
  85         (has_ravenscar_runtime, get_running_thread_id)
  86         (ravenscar_thread_target::resume): Fix indentation.
  87
  88 2019-02-15  Tom Tromey  <tromey@adacore.com>
  89
  90         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
  91         from ravenscar_arch_ops.
  92         (sparc_ravenscar_ops::fetch_registers)
  93         (sparc_ravenscar_ops::store_registers): Now methods.
  94         (sparc_ravenscar_prepare_to_store): Remove.
  95         (sparc_ravenscar_ops): Redefine.
  96         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
  97         methods and destructor.  Remove members.
  98         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
  99         (ravenscar_thread_target::store_registers)
 100         (ravenscar_thread_target::prepare_to_store): Update.
 101         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 102         Remove.
 103         (struct ppc_ravenscar_powerpc_ops): Derive from
 104         ravenscar_arch_ops.
 105         (ppc_ravenscar_powerpc_ops::fetch_registers)
 106         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 107         (ppc_ravenscar_powerpc_ops): Redefine.
 108         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 109         (ppc_ravenscar_e500_ops::fetch_registers)
 110         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 111         (ppc_ravenscar_e500_ops): Redefine.
 112         * aarch64-ravenscar-thread.c
 113         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 114         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 115         (aarch64_ravenscar_fetch_registers)
 116         (aarch64_ravenscar_store_registers): Now methods.
 117         (aarch64_ravenscar_ops): Redefine.
 118
 119 2019-02-15  Tom Tromey  <tromey@adacore.com>
 120
 121         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 122         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 123         (ravenscar_thread_target::stopped_by_watchpoint)
 124         (ravenscar_thread_target::stopped_data_address)
 125         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 126
 127 2019-02-15  Tom Tromey  <tromey@adacore.com>
 128
 129         * ravenscar-thread.c: Fix some typos.
 130
 131 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 132             Tom Tromey  <tromey@adacore.com>
 133
 134         * ada-lang.c (ada_exception_sal): Change addr_string to a
 135         std::string.
 136         (create_ada_exception_catchpoint): Update.
 137
 138 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 139             Tom Tromey  <tromey@adacore.com>
 140
 141         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 142         (bp_location_ops): Remove.
 143         (base_breakpoint_allocate_location): Update.
 144         (free_bp_location): Update.
 145         * ada-lang.c (class ada_catchpoint_location)
 146         <ada_catchpoint_location>: Remove ops parameter.
 147         (ada_catchpoint_location_dtor): Remove.
 148         (ada_catchpoint_location_ops): Remove.
 149         (allocate_location_exception): Update.
 150         * breakpoint.h (struct bp_location_ops): Remove.
 151         (class bp_location) <bp_location>: Remove bp_location_ops
 152         parameter.
 153         <~bp_location>: Add destructor.
 154         <ops>: Remove.
 155
 156 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 157             Pedro Alves  <palves@redhat.com>
 158
 159         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 160         'PATH_MAX'.
 161
 162 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 163             Samuel Thibault  <samuel.thibault@gnu.org>
 164             Thomas Schwinge  <thomas@codesourcery.com>
 165
 166         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 167         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 168
 169 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 170
 171         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 172         (check_empty): Use "const char *".
 173
 174         * gnu-nat.c (gnu_nat_target::detach): Instead of
 175         'detach_inferior (pid)' call
 176         'detach_inferior (find_inferior_pid (pid))'.
 177
 178         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 179         'nat/fork-inferior.o'.
 180         * gnu-nat.c: #include "nat/fork-inferior.h".
 181
 182         * gnu-nat.c (gnu_nat_target::detach): Instead of
 183         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 184         * gnu-nat.h: #include "inf-child.h".
 185         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 186         'i386_gnu_nat_target::fetch_registers'.
 187         (gnu_store_registers): Rename/move to
 188         'i386_gnu_nat_target::store_registers'.
 189
 190         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 191         * gnu-nat.h (mach_thread_info): New function.
 192         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 193
 194         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 195
 196 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 197
 198         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 199
 200 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 201
 202         * windows-nat.c (windows_add_thread): Add new parameter
 203         "main_thread_p" with default value set to false.  Update
 204         function documentation as well as all callers.
 205         (windows_delete_thread): Likewise.
 206         (fake_create_process): Update call to windows_add_thread.
 207         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 208         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 209         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 210         call to windows_delete_thread.
 211
 212 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 213
 214         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 215
 216 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 217
 218         * symfile.c (find_separate_debug_file): Use canonical path of
 219         sysroot with child_path instead of gdb_sysroot if it is valid.
 220
 221 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 222
 223         * symfile.c (find_separate_debug_file): Use child_path to
 224         determine if an object file is under a sysroot.
 225
 226 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 227
 228         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 229         unittests/child-path-selftests.c.
 230         * common/pathstuff.c (child_path): New function.
 231         * common/pathstuff.h (child_path): New prototype.
 232         * unittests/child-path-selftests.c: New file.
 233
 234 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 235
 236         * symfile.c (find_separate_debug_file): Look for separate debug
 237         files in debug directories under the sysroot.
 238
 239 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 240
 241         * symtab.h (struct minimal_symbol data_p): New const method.
 242         (struct minimal_symbol text_p): Likewise.
 243         * symtab.c (output_source_filename): Use file name style
 244         to print file name.
 245         (print_symbol_info): Likewise.
 246         (print_msymbol_info): Use address style to print addresses.
 247         Use function name style to print executable text symbols.
 248         (expand_symtab_containing_pc): Use data_p.
 249         (find_pc_sect_compunit_symtab): Likewise.
 250
 251 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 252
 253         * breakpoint.c (describe_other_breakpoints): Use address style
 254         to print addresses.
 255         (say_where): Likewise.
 256
 257 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 258
 259         * ada-typeprint.c (print_func_type): Print function name
 260         style to print function name.
 261         * c-typeprint.c (c_print_type_1): Likewise.
 262
 263 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 264
 265         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 266         for execve.
 267
 268 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 269
 270         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 271         type_stack.
 272
 273 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 274
 275         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 276         TYPE_CODE_REF types.
 277
 278 2019-02-08  Jim Wilson  <jimw@sifive.com>
 279
 280         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 281         (riscv_linux_fregset): New.
 282         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 283
 284 2019-02-07  Tom Tromey  <tom@tromey.com>
 285
 286         * thread.c (thread_cancel_execution_command): Update.
 287         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 288         methods.
 289         (struct thread_fsm_ops): Remove.
 290         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 291         (thread_fsm_should_stop, thread_fsm_return_value)
 292         (thread_fsm_set_finished, thread_fsm_finished_p)
 293         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 294         Don't declare.
 295         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 296         * infrun.c (clear_proceed_status_thread)
 297         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 298         (print_stop_event): Update.
 299         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 300         Add constructor.
 301         (step_command_fsm_ops): Remove.
 302         (new_step_command_fsm): Remove.
 303         (step_1): Update.
 304         (step_command_fsm::should_stop): Rename from
 305         step_command_fsm_should_stop.
 306         (step_command_fsm::clean_up): Rename from
 307         step_command_fsm_clean_up.
 308         (step_command_fsm::do_async_reply_reason): Rename from
 309         step_command_fsm_async_reply_reason.
 310         (struct until_next_fsm): Inherit from thread_fsm.  Add
 311         constructor.
 312         (until_next_fsm_ops): Remove.
 313         (new_until_next_fsm): Remove.
 314         (until_next_fsm::should_stop): Rename from
 315         until_next_fsm_should_stop.
 316         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 317         (until_next_fsm::do_async_reply_reason): Rename from
 318         until_next_fsm_async_reply_reason.
 319         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 320         constructor.  Change type of breakpoint.
 321         (finish_command_fsm_ops): Remove.
 322         (new_finish_command_fsm): Remove.
 323         (finish_command_fsm::should_stop): Rename from
 324         finish_command_fsm_should_stop.
 325         (finish_command_fsm::clean_up): Rename from
 326         finish_command_fsm_clean_up.
 327         (finish_command_fsm::return_value): Rename from
 328         finish_command_fsm_return_value.
 329         (finish_command_fsm::do_async_reply_reason): Rename from
 330         finish_command_fsm_async_reply_reason.
 331         (finish_command): Update.
 332         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 333         Add constructor.
 334         (call_thread_fsm_ops): Remove.
 335         (call_thread_fsm::call_thread_fsm): Rename from
 336         new_call_thread_fsm.
 337         (call_thread_fsm::should_stop): Rename from
 338         call_thread_fsm_should_stop.
 339         (call_thread_fsm::should_notify_stop): Rename from
 340         call_thread_fsm_should_notify_stop.
 341         (run_inferior_call, call_function_by_hand_dummy): Update.
 342         * cli/cli-interp.c (should_print_stop_to_console): Update.
 343         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 344         Add constructor.  Change type of location_breakpoint,
 345         caller_breakpoint.
 346         (until_break_fsm_ops): Remove.
 347         (new_until_break_fsm): Remove.
 348         (until_break_fsm::should_stop): Rename from
 349         until_break_fsm_should_stop.
 350         (until_break_fsm::clean_up): Rename from
 351         until_break_fsm_clean_up.
 352         (until_break_fsm::do_async_reply_reason): Rename from
 353         until_break_fsm_async_reply_reason.
 354         (until_break_command): Update.
 355         * thread-fsm.c: Remove.
 356         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 357
 358 2019-02-07  Tom Tromey  <tom@tromey.com>
 359
 360         * yy-remap.h: Add include guard.
 361         * xtensa-tdep.h: Add include guard.
 362         * xcoffread.h: Rename include guard.
 363         * varobj-iter.h: Add include guard.
 364         * tui/tui.h: Rename include guard.
 365         * tui/tui-winsource.h: Rename include guard.
 366         * tui/tui-wingeneral.h: Rename include guard.
 367         * tui/tui-windata.h: Rename include guard.
 368         * tui/tui-win.h: Rename include guard.
 369         * tui/tui-stack.h: Rename include guard.
 370         * tui/tui-source.h: Rename include guard.
 371         * tui/tui-regs.h: Rename include guard.
 372         * tui/tui-out.h: Rename include guard.
 373         * tui/tui-layout.h: Rename include guard.
 374         * tui/tui-io.h: Rename include guard.
 375         * tui/tui-hooks.h: Rename include guard.
 376         * tui/tui-file.h: Rename include guard.
 377         * tui/tui-disasm.h: Rename include guard.
 378         * tui/tui-data.h: Rename include guard.
 379         * tui/tui-command.h: Rename include guard.
 380         * tic6x-tdep.h: Add include guard.
 381         * target/waitstatus.h: Rename include guard.
 382         * target/wait.h: Rename include guard.
 383         * target/target.h: Rename include guard.
 384         * target/resume.h: Rename include guard.
 385         * target-float.h: Rename include guard.
 386         * stabsread.h: Add include guard.
 387         * rs6000-tdep.h: Add include guard.
 388         * riscv-fbsd-tdep.h: Add include guard.
 389         * regformats/regdef.h: Rename include guard.
 390         * record.h: Rename include guard.
 391         * python/python.h: Rename include guard.
 392         * python/python-internal.h: Rename include guard.
 393         * python/py-stopevent.h: Rename include guard.
 394         * python/py-ref.h: Rename include guard.
 395         * python/py-record.h: Rename include guard.
 396         * python/py-record-full.h: Rename include guard.
 397         * python/py-record-btrace.h: Rename include guard.
 398         * python/py-instruction.h: Rename include guard.
 399         * python/py-events.h: Rename include guard.
 400         * python/py-event.h: Rename include guard.
 401         * procfs.h: Add include guard.
 402         * proc-utils.h: Add include guard.
 403         * p-lang.h: Add include guard.
 404         * or1k-tdep.h: Rename include guard.
 405         * observable.h: Rename include guard.
 406         * nto-tdep.h: Rename include guard.
 407         * nat/x86-linux.h: Rename include guard.
 408         * nat/x86-linux-dregs.h: Rename include guard.
 409         * nat/x86-gcc-cpuid.h: Add include guard.
 410         * nat/x86-dregs.h: Rename include guard.
 411         * nat/x86-cpuid.h: Rename include guard.
 412         * nat/ppc-linux.h: Rename include guard.
 413         * nat/mips-linux-watch.h: Rename include guard.
 414         * nat/linux-waitpid.h: Rename include guard.
 415         * nat/linux-ptrace.h: Rename include guard.
 416         * nat/linux-procfs.h: Rename include guard.
 417         * nat/linux-osdata.h: Rename include guard.
 418         * nat/linux-nat.h: Rename include guard.
 419         * nat/linux-namespaces.h: Rename include guard.
 420         * nat/linux-btrace.h: Rename include guard.
 421         * nat/glibc_thread_db.h: Rename include guard.
 422         * nat/gdb_thread_db.h: Rename include guard.
 423         * nat/gdb_ptrace.h: Rename include guard.
 424         * nat/fork-inferior.h: Rename include guard.
 425         * nat/amd64-linux-siginfo.h: Rename include guard.
 426         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 427         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 428         * nat/aarch64-linux.h: Rename include guard.
 429         * nat/aarch64-linux-hw-point.h: Rename include guard.
 430         * mn10300-tdep.h: Add include guard.
 431         * mips-linux-tdep.h: Add include guard.
 432         * mi/mi-parse.h: Rename include guard.
 433         * mi/mi-out.h: Rename include guard.
 434         * mi/mi-main.h: Rename include guard.
 435         * mi/mi-interp.h: Rename include guard.
 436         * mi/mi-getopt.h: Rename include guard.
 437         * mi/mi-console.h: Rename include guard.
 438         * mi/mi-common.h: Rename include guard.
 439         * mi/mi-cmds.h: Rename include guard.
 440         * mi/mi-cmd-break.h: Rename include guard.
 441         * m2-lang.h: Add include guard.
 442         * location.h: Rename include guard.
 443         * linux-record.h: Rename include guard.
 444         * linux-nat.h: Add include guard.
 445         * linux-fork.h: Add include guard.
 446         * i386-darwin-tdep.h: Rename include guard.
 447         * hppa-linux-offsets.h: Add include guard.
 448         * guile/guile.h: Rename include guard.
 449         * guile/guile-internal.h: Rename include guard.
 450         * gnu-nat.h: Rename include guard.
 451         * gdb-stabs.h: Rename include guard.
 452         * frv-tdep.h: Add include guard.
 453         * f-lang.h: Add include guard.
 454         * event-loop.h: Add include guard.
 455         * darwin-nat.h: Rename include guard.
 456         * cp-abi.h: Rename include guard.
 457         * config/sparc/nm-sol2.h: Rename include guard.
 458         * config/nm-nto.h: Rename include guard.
 459         * config/nm-linux.h: Add include guard.
 460         * config/i386/nm-i386gnu.h: Rename include guard.
 461         * config/djgpp/nl_types.h: Rename include guard.
 462         * config/djgpp/langinfo.h: Rename include guard.
 463         * compile/gcc-cp-plugin.h: Add include guard.
 464         * compile/gcc-c-plugin.h: Add include guard.
 465         * compile/compile.h: Rename include guard.
 466         * compile/compile-object-run.h: Rename include guard.
 467         * compile/compile-object-load.h: Rename include guard.
 468         * compile/compile-internal.h: Rename include guard.
 469         * compile/compile-cplus.h: Rename include guard.
 470         * compile/compile-c.h: Rename include guard.
 471         * common/xml-utils.h: Rename include guard.
 472         * common/x86-xstate.h: Rename include guard.
 473         * common/version.h: Rename include guard.
 474         * common/vec.h: Rename include guard.
 475         * common/tdesc.h: Rename include guard.
 476         * common/selftest.h: Rename include guard.
 477         * common/scoped_restore.h: Rename include guard.
 478         * common/scoped_mmap.h: Rename include guard.
 479         * common/scoped_fd.h: Rename include guard.
 480         * common/safe-iterator.h: Rename include guard.
 481         * common/run-time-clock.h: Rename include guard.
 482         * common/refcounted-object.h: Rename include guard.
 483         * common/queue.h: Rename include guard.
 484         * common/ptid.h: Rename include guard.
 485         * common/print-utils.h: Rename include guard.
 486         * common/preprocessor.h: Rename include guard.
 487         * common/pathstuff.h: Rename include guard.
 488         * common/observable.h: Rename include guard.
 489         * common/netstuff.h: Rename include guard.
 490         * common/job-control.h: Rename include guard.
 491         * common/host-defs.h: Rename include guard.
 492         * common/gdb_wait.h: Rename include guard.
 493         * common/gdb_vecs.h: Rename include guard.
 494         * common/gdb_unlinker.h: Rename include guard.
 495         * common/gdb_unique_ptr.h: Rename include guard.
 496         * common/gdb_tilde_expand.h: Rename include guard.
 497         * common/gdb_sys_time.h: Rename include guard.
 498         * common/gdb_string_view.h: Rename include guard.
 499         * common/gdb_splay_tree.h: Rename include guard.
 500         * common/gdb_setjmp.h: Rename include guard.
 501         * common/gdb_ref_ptr.h: Rename include guard.
 502         * common/gdb_optional.h: Rename include guard.
 503         * common/gdb_locale.h: Rename include guard.
 504         * common/gdb_assert.h: Rename include guard.
 505         * common/filtered-iterator.h: Rename include guard.
 506         * common/filestuff.h: Rename include guard.
 507         * common/fileio.h: Rename include guard.
 508         * common/environ.h: Rename include guard.
 509         * common/common-utils.h: Rename include guard.
 510         * common/common-types.h: Rename include guard.
 511         * common/common-regcache.h: Rename include guard.
 512         * common/common-inferior.h: Rename include guard.
 513         * common/common-gdbthread.h: Rename include guard.
 514         * common/common-exceptions.h: Rename include guard.
 515         * common/common-defs.h: Rename include guard.
 516         * common/common-debug.h: Rename include guard.
 517         * common/cleanups.h: Rename include guard.
 518         * common/buffer.h: Rename include guard.
 519         * common/btrace-common.h: Rename include guard.
 520         * common/break-common.h: Rename include guard.
 521         * cli/cli-utils.h: Rename include guard.
 522         * cli/cli-style.h: Rename include guard.
 523         * cli/cli-setshow.h: Rename include guard.
 524         * cli/cli-script.h: Rename include guard.
 525         * cli/cli-interp.h: Rename include guard.
 526         * cli/cli-decode.h: Rename include guard.
 527         * cli/cli-cmds.h: Rename include guard.
 528         * charset-list.h: Add include guard.
 529         * buildsym-legacy.h: Rename include guard.
 530         * bfin-tdep.h: Add include guard.
 531         * ax.h: Rename include guard.
 532         * arm-linux-tdep.h: Add include guard.
 533         * arm-fbsd-tdep.h: Add include guard.
 534         * arch/xtensa.h: Rename include guard.
 535         * arch/tic6x.h: Add include guard.
 536         * arch/i386.h: Add include guard.
 537         * arch/arm.h: Rename include guard.
 538         * arch/arm-linux.h: Rename include guard.
 539         * arch/arm-get-next-pcs.h: Rename include guard.
 540         * arch/amd64.h: Add include guard.
 541         * arch/aarch64-insn.h: Rename include guard.
 542         * arch-utils.h: Rename include guard.
 543         * annotate.h: Add include guard.
 544         * amd64-darwin-tdep.h: Rename include guard.
 545         * aarch64-linux-tdep.h: Add include guard.
 546         * aarch64-fbsd-tdep.h: Add include guard.
 547         * aarch32-linux-nat.h: Add include guard.
 548
 549 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 550
 551         * macrotab.c (macro_define_internal): New function that
 552         factorizes macro_define_object_internal and macro_define_function
 553         code.
 554         (macro_define_object_internal): Use macro_define_internal.
 555         (macro_define_function): Likewise.
 556
 557 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 558
 559         * macrocmd.c (extract_identifier): Return
 560         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 561         callers.
 562
 563 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 564
 565         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 566
 567 2019-02-05  Tom Tromey  <tom@tromey.com>
 568
 569         * target.c (target_stack::unpush): Move assertion earlier.
 570
 571 2019-01-30  Tom Tromey  <tom@tromey.com>
 572
 573         PR python/23615:
 574         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 575         (gdbpy_parse_and_eval): Likewise.
 576         * python/python-internal.h (gdbpy_allow_threads): New class.
 577
 578 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 579
 580         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 581         (aarch64_fbsd_fpregmap): Move earlier.
 582         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 583         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 584         instead of individual calls to trad_frame_set_reg_addr.
 585         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 586         earlier.
 587         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 588         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 589         instead of individual calls to trad_frame_set_reg_addr.
 590
 591 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 592
 593         * CONTRIBUTE: Replace contribution list with wiki link.
 594
 595 2019-01-25  Tom Tromey  <tom@tromey.com>
 596
 597         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 598
 599 2019-01-25  Tom Tromey  <tom@tromey.com>
 600
 601         * xtensa-linux-nat.c: Fix common/ includes.
 602         * xml-support.h: Fix common/ includes.
 603         * xml-support.c: Fix common/ includes.
 604         * x86-linux-nat.c: Fix common/ includes.
 605         * windows-nat.c: Fix common/ includes.
 606         * varobj.h: Fix common/ includes.
 607         * varobj.c: Fix common/ includes.
 608         * value.c: Fix common/ includes.
 609         * valops.c: Fix common/ includes.
 610         * utils.c: Fix common/ includes.
 611         * unittests/xml-utils-selftests.c: Fix common/ includes.
 612         * unittests/utils-selftests.c: Fix common/ includes.
 613         * unittests/unpack-selftests.c: Fix common/ includes.
 614         * unittests/tracepoint-selftests.c: Fix common/ includes.
 615         * unittests/style-selftests.c: Fix common/ includes.
 616         * unittests/string_view-selftests.c: Fix common/ includes.
 617         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 618         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 619         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 620         * unittests/rsp-low-selftests.c: Fix common/ includes.
 621         * unittests/parse-connection-spec-selftests.c: Fix common/
 622         includes.
 623         * unittests/optional-selftests.c: Fix common/ includes.
 624         * unittests/offset-type-selftests.c: Fix common/ includes.
 625         * unittests/observable-selftests.c: Fix common/ includes.
 626         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 627         * unittests/memrange-selftests.c: Fix common/ includes.
 628         * unittests/memory-map-selftests.c: Fix common/ includes.
 629         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 630         * unittests/function-view-selftests.c: Fix common/ includes.
 631         * unittests/environ-selftests.c: Fix common/ includes.
 632         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 633         * unittests/common-utils-selftests.c: Fix common/ includes.
 634         * unittests/cli-utils-selftests.c: Fix common/ includes.
 635         * unittests/array-view-selftests.c: Fix common/ includes.
 636         * ui-file.c: Fix common/ includes.
 637         * tui/tui-io.c: Fix common/ includes.
 638         * tracepoint.h: Fix common/ includes.
 639         * tracepoint.c: Fix common/ includes.
 640         * tracefile-tfile.c: Fix common/ includes.
 641         * top.h: Fix common/ includes.
 642         * top.c: Fix common/ includes.
 643         * thread.c: Fix common/ includes.
 644         * target/waitstatus.h: Fix common/ includes.
 645         * target/waitstatus.c: Fix common/ includes.
 646         * target.h: Fix common/ includes.
 647         * target.c: Fix common/ includes.
 648         * target-memory.c: Fix common/ includes.
 649         * target-descriptions.c: Fix common/ includes.
 650         * symtab.h: Fix common/ includes.
 651         * symfile.c: Fix common/ includes.
 652         * stap-probe.c: Fix common/ includes.
 653         * spu-linux-nat.c: Fix common/ includes.
 654         * sparc-nat.c: Fix common/ includes.
 655         * source.c: Fix common/ includes.
 656         * solib.c: Fix common/ includes.
 657         * solib-target.c: Fix common/ includes.
 658         * ser-unix.c: Fix common/ includes.
 659         * ser-tcp.c: Fix common/ includes.
 660         * ser-pipe.c: Fix common/ includes.
 661         * ser-base.c: Fix common/ includes.
 662         * selftest-arch.c: Fix common/ includes.
 663         * s12z-tdep.c: Fix common/ includes.
 664         * rust-exp.y: Fix common/ includes.
 665         * rs6000-aix-tdep.c: Fix common/ includes.
 666         * riscv-tdep.c: Fix common/ includes.
 667         * remote.c: Fix common/ includes.
 668         * remote-notif.h: Fix common/ includes.
 669         * remote-fileio.h: Fix common/ includes.
 670         * remote-fileio.c: Fix common/ includes.
 671         * regcache.h: Fix common/ includes.
 672         * regcache.c: Fix common/ includes.
 673         * record-btrace.c: Fix common/ includes.
 674         * python/python.c: Fix common/ includes.
 675         * python/py-type.c: Fix common/ includes.
 676         * python/py-inferior.c: Fix common/ includes.
 677         * progspace.h: Fix common/ includes.
 678         * producer.c: Fix common/ includes.
 679         * procfs.c: Fix common/ includes.
 680         * proc-api.c: Fix common/ includes.
 681         * printcmd.c: Fix common/ includes.
 682         * ppc-linux-nat.c: Fix common/ includes.
 683         * parser-defs.h: Fix common/ includes.
 684         * osdata.c: Fix common/ includes.
 685         * obsd-nat.c: Fix common/ includes.
 686         * nat/x86-linux.c: Fix common/ includes.
 687         * nat/x86-linux-dregs.c: Fix common/ includes.
 688         * nat/x86-dregs.h: Fix common/ includes.
 689         * nat/x86-dregs.c: Fix common/ includes.
 690         * nat/ppc-linux.c: Fix common/ includes.
 691         * nat/mips-linux-watch.h: Fix common/ includes.
 692         * nat/mips-linux-watch.c: Fix common/ includes.
 693         * nat/linux-waitpid.c: Fix common/ includes.
 694         * nat/linux-ptrace.h: Fix common/ includes.
 695         * nat/linux-ptrace.c: Fix common/ includes.
 696         * nat/linux-procfs.c: Fix common/ includes.
 697         * nat/linux-personality.c: Fix common/ includes.
 698         * nat/linux-osdata.c: Fix common/ includes.
 699         * nat/linux-namespaces.c: Fix common/ includes.
 700         * nat/linux-btrace.h: Fix common/ includes.
 701         * nat/linux-btrace.c: Fix common/ includes.
 702         * nat/fork-inferior.c: Fix common/ includes.
 703         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 704         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 705         * nat/aarch64-linux.c: Fix common/ includes.
 706         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 707         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 708         * namespace.h: Fix common/ includes.
 709         * mips-linux-tdep.c: Fix common/ includes.
 710         * minsyms.c: Fix common/ includes.
 711         * mi/mi-parse.h: Fix common/ includes.
 712         * mi/mi-main.c: Fix common/ includes.
 713         * mi/mi-cmd-env.c: Fix common/ includes.
 714         * memrange.h: Fix common/ includes.
 715         * memattr.c: Fix common/ includes.
 716         * maint.h: Fix common/ includes.
 717         * maint.c: Fix common/ includes.
 718         * main.c: Fix common/ includes.
 719         * machoread.c: Fix common/ includes.
 720         * location.c: Fix common/ includes.
 721         * linux-thread-db.c: Fix common/ includes.
 722         * linux-nat.c: Fix common/ includes.
 723         * linux-fork.c: Fix common/ includes.
 724         * inline-frame.c: Fix common/ includes.
 725         * infrun.c: Fix common/ includes.
 726         * inflow.c: Fix common/ includes.
 727         * inferior.h: Fix common/ includes.
 728         * inferior.c: Fix common/ includes.
 729         * infcmd.c: Fix common/ includes.
 730         * inf-ptrace.c: Fix common/ includes.
 731         * inf-child.c: Fix common/ includes.
 732         * ia64-linux-nat.c: Fix common/ includes.
 733         * i387-tdep.c: Fix common/ includes.
 734         * i386-tdep.c: Fix common/ includes.
 735         * i386-linux-tdep.c: Fix common/ includes.
 736         * i386-linux-nat.c: Fix common/ includes.
 737         * i386-go32-tdep.c: Fix common/ includes.
 738         * i386-fbsd-tdep.c: Fix common/ includes.
 739         * i386-fbsd-nat.c: Fix common/ includes.
 740         * guile/scm-type.c: Fix common/ includes.
 741         * guile/guile.c: Fix common/ includes.
 742         * go32-nat.c: Fix common/ includes.
 743         * gnu-nat.c: Fix common/ includes.
 744         * gdbthread.h: Fix common/ includes.
 745         * gdbarch-selftests.c: Fix common/ includes.
 746         * gdb_usleep.c: Fix common/ includes.
 747         * gdb_select.h: Fix common/ includes.
 748         * gdb_bfd.c: Fix common/ includes.
 749         * gcore.c: Fix common/ includes.
 750         * fork-child.c: Fix common/ includes.
 751         * findvar.c: Fix common/ includes.
 752         * fbsd-nat.c: Fix common/ includes.
 753         * event-top.c: Fix common/ includes.
 754         * event-loop.c: Fix common/ includes.
 755         * dwarf2read.c: Fix common/ includes.
 756         * dwarf2loc.c: Fix common/ includes.
 757         * dwarf2-frame.c: Fix common/ includes.
 758         * dwarf-index-cache.c: Fix common/ includes.
 759         * dtrace-probe.c: Fix common/ includes.
 760         * disasm-selftests.c: Fix common/ includes.
 761         * defs.h: Fix common/ includes.
 762         * csky-tdep.c: Fix common/ includes.
 763         * cp-valprint.c: Fix common/ includes.
 764         * cp-support.h: Fix common/ includes.
 765         * cp-support.c: Fix common/ includes.
 766         * corelow.c: Fix common/ includes.
 767         * completer.h: Fix common/ includes.
 768         * completer.c: Fix common/ includes.
 769         * compile/compile.c: Fix common/ includes.
 770         * compile/compile-loc2c.c: Fix common/ includes.
 771         * compile/compile-cplus-types.c: Fix common/ includes.
 772         * compile/compile-cplus-symbols.c: Fix common/ includes.
 773         * command.h: Fix common/ includes.
 774         * cli/cli-dump.c: Fix common/ includes.
 775         * cli/cli-cmds.c: Fix common/ includes.
 776         * charset.c: Fix common/ includes.
 777         * build-id.c: Fix common/ includes.
 778         * btrace.h: Fix common/ includes.
 779         * btrace.c: Fix common/ includes.
 780         * breakpoint.h: Fix common/ includes.
 781         * breakpoint.c: Fix common/ includes.
 782         * ax.h:
 783         (enum agent_op): Fix common/ includes.
 784         * ax-general.c (struct aop_map): Fix common/ includes.
 785         * ax-gdb.c: Fix common/ includes.
 786         * auxv.c: Fix common/ includes.
 787         * auto-load.c: Fix common/ includes.
 788         * arm-tdep.c: Fix common/ includes.
 789         * arch/riscv.c: Fix common/ includes.
 790         * arch/ppc-linux-common.c: Fix common/ includes.
 791         * arch/i386.c: Fix common/ includes.
 792         * arch/arm.c: Fix common/ includes.
 793         * arch/arm-linux.c: Fix common/ includes.
 794         * arch/arm-get-next-pcs.c: Fix common/ includes.
 795         * arch/amd64.c: Fix common/ includes.
 796         * arch/aarch64.c: Fix common/ includes.
 797         * arch/aarch64-insn.c: Fix common/ includes.
 798         * arch-utils.c: Fix common/ includes.
 799         * amd64-windows-tdep.c: Fix common/ includes.
 800         * amd64-tdep.c: Fix common/ includes.
 801         * amd64-sol2-tdep.c: Fix common/ includes.
 802         * amd64-obsd-tdep.c: Fix common/ includes.
 803         * amd64-nbsd-tdep.c: Fix common/ includes.
 804         * amd64-linux-tdep.c: Fix common/ includes.
 805         * amd64-linux-nat.c: Fix common/ includes.
 806         * amd64-fbsd-tdep.c: Fix common/ includes.
 807         * amd64-fbsd-nat.c: Fix common/ includes.
 808         * amd64-dicos-tdep.c: Fix common/ includes.
 809         * amd64-darwin-tdep.c: Fix common/ includes.
 810         * agent.c: Fix common/ includes.
 811         * ada-lang.h: Fix common/ includes.
 812         * ada-lang.c: Fix common/ includes.
 813         * aarch64-tdep.c: Fix common/ includes.
 814
 815 2019-01-25  Tom Tromey  <tom@tromey.com>
 816
 817         * common/create-version.sh: Use common/version.h.
 818
 819 2019-01-24  Pedro Alves  <palves@redhat.com>
 820
 821         * infrun.c (signal_stop, signal_print, signal_program)
 822         (signal_catch, signal_pass): Now arrays instead of pointers.
 823         (update_signals_program_target, do_target_resume)
 824         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 825         * linux-nat.c (linux_nat_target::pass_signals)
 826         (linux_nat_target::create_inferior, linux_nat_target::attach):
 827         Adjust.
 828         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 829         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 830         * procfs.c (procfs_target::pass_signals): Adjust.
 831         * record-full.c (record_full_target::resume): Adjust.
 832         * remote.c (remote_target::pass_signals)
 833         (remote_target::program_signals): Adjust.
 834         * target-debug.h (target_debug_print_signals): Now takes a
 835         gdb::array_view as parameter.  Adjust.
 836         * target.h (target_ops) <pass_signals, program_signals>: Replace
 837         pointer and length parameters with gdb::array_view.
 838         (target_pass_signals, target_program_signals): Likewise.
 839         * target-delegates.c: Regenerate.
 840
 841 2019-01-24  Pedro Alves  <palves@redhat.com>
 842
 843         * common/forward-scope-exit.h
 844         (forward_scope_exit::forward_scope_exit): Pass arguments to
 845         m_bind_function directly, instead of creating a std::bind and
 846         copying that.
 847
 848 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 849
 850         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 851         for static members.
 852         (pass_in_v_vfp_candidate): Likewise.
 853
 854 2019-01-23  Tom Tromey  <tom@tromey.com>
 855             Pedro Alves  <palves@redhat.com>
 856
 857         * regcache.c (class regcache_invalidator): Remove.
 858         (regcache::raw_write): Use make_scope_exit.
 859
 860 2019-01-23  Tom Tromey  <tom@tromey.com>
 861
 862         * ui-out.h (class ui_out_emit_type): Update comment.
 863
 864 2019-01-23  Tom Tromey  <tom@tromey.com>
 865
 866         * infrun.c (fetch_inferior_event): Update comment.
 867
 868 2019-01-23  Tom Tromey  <tom@tromey.com>
 869             Pedro Alves  <palves@redhat.com>
 870
 871         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 872         parameter.
 873         (fetch_inferior_event): Use SCOPE_EXIT.
 874
 875
 876 2019-01-23  Tom Tromey  <tom@tromey.com>
 877             Pedro Alves  <palves@redhat.com>
 878
 879         * infrun.c (disable_thread_events): Delete.
 880         (stop_all_threads): Use SCOPE_EXIT.
 881
 882 2019-01-23  Tom Tromey  <tom@tromey.com>
 883             Pedro Alves  <palves@redhat.com>
 884
 885         * symfile.c: Include forward-scope-exit.h.
 886         (clear_symtab_users_cleanup): Replace forward declaration with
 887         a FORWARD_SCOPE_EXIT.
 888         (syms_from_objfile_1): Use the forward_scope_exit and
 889         gdb::optional instead of cleanup_function.
 890         (reread_symbols): Use the forward_scope_exit instead of
 891         cleanup_function.
 892         (clear_symtab_users_cleanup): Remove function.
 893
 894 2019-01-23  Tom Tromey  <tom@tromey.com>
 895             Pedro Alves  <palves@redhat.com>
 896
 897         * linux-nat.c: Include scope-exit.h.
 898         (cleanup_target_stop): Remove.
 899         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 900         SCOPE_EXIT.
 901
 902 2019-01-23  Tom Tromey  <tom@tromey.com>
 903             Pedro Alves  <palves@redhat.com>
 904
 905         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 906         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 907
 908 2019-01-23  Tom Tromey  <tom@tromey.com>
 909             Andrew Burgess  <andrew.burgess@embecosm.com>
 910             Pedro Alves  <palves@redhat.com>
 911
 912         * infrun.c (fetch_inferior_event): Use scope_exit.
 913         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 914         * top.c (execute_command): Use scope_exit.
 915         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 916         * utils.c (do_bpstat_clear_actions_cleanup)
 917         (make_bpstat_clear_actions_cleanup): Remove.
 918
 919 2019-01-23  Tom Tromey  <tom@tromey.com>
 920             Pedro Alves  <palves@redhat.com>
 921
 922         * infrun.c: Include "common/scope-exit.h"
 923         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 924         (wait_for_inferior): Use SCOPE_EXIT.
 925         (fetch_inferior_event): Use scope_exit.
 926
 927 2019-01-23  Tom Tromey  <tom@tromey.com>
 928             Pedro Alves  <palves@redhat.com>
 929
 930         * breakpoint.c (create_breakpoint): Remove cleanup.
 931
 932 2019-01-23  Tom Tromey  <tom@tromey.com>
 933             Andrew Burgess  <andrew.burgess@embecosm.com>
 934             Pedro Alves  <palves@redhat.com>
 935
 936 2019-01-23  Pedro Alves  <palves@redhat.com>
 937
 938         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 939
 940 2019-01-23  Pedro Alves  <palves@redhat.com>
 941             Andrew Burgess  <andrew.burgess@embecosm.com>
 942
 943         * gdbthread.h: Include "common/forward-scope-exit.h".
 944         (scoped_finish_thread_state): Redefine custom class in terms of
 945         forward_scope_exit.
 946
 947 2019-01-23  Pedro Alves  <palves@redhat.com>
 948             Andrew Burgess  <andrew.burgess@embecosm.com>
 949
 950         * common/forward-scope-exit.h: New file.
 951
 952 2019-01-23  Pedro Alves  <palves@redhat.com>
 953             Andrew Burgess  <andrew.burgess@embecosm.com>
 954             Tom Tromey  <tom@tromey.com>
 955
 956         * common/scope-exit.h: New file.
 957
 958 2019-01-23  Pedro Alves  <palves@redhat.com>
 959
 960         * common/preprocessor.h (ESC): Rename to ...
 961         (ESC_PARENS): ... this.
 962         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 963         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 964
 965 2019-01-23  Tom Tromey  <tom@tromey.com>
 966
 967         * language.h (class scoped_switch_to_sym_language_if_auto):
 968         Initialize m_lang in both cases.
 969
 970 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 971
 972         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 973         with XCNEW.
 974
 975 2019-01-22  Tom Tromey  <tom@tromey.com>
 976
 977         * corelow.c: Do not include sys/file.h.
 978
 979 2019-01-22  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-wingeneral.h: Include gdb_curses.h.
 982
 983 2019-01-22  Tom Tromey  <tom@tromey.com>
 984
 985         * source-cache.h (class source_cache) <get_source_lines,
 986         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 987
 988 2019-01-22  Tom Tromey  <tom@tromey.com>
 989
 990         * remote-fileio.h (struct remote_target): Declare.
 991
 992 2019-01-22  Tom Tromey  <tom@tromey.com>
 993
 994         * python/py-arch.c: Do not include py-ref.h.
 995         * python/py-bpevent.c: Do not include py-ref.h.
 996         * python/py-cmd.c: Do not include py-ref.h.
 997         * python/py-continueevent.c: Do not include py-ref.h.
 998         * python/py-event.h: Do not include py-ref.h.
 999         * python/py-evtregistry.c: Do not include py-ref.h.
1000         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1001         * python/py-frame.c: Do not include py-ref.h.
1002         * python/py-framefilter.c: Do not include py-ref.h.
1003         * python/py-function.c: Do not include py-ref.h.
1004         * python/py-infevents.c: Do not include py-ref.h.
1005         * python/py-linetable.c: Do not include py-ref.h.
1006         * python/py-objfile.c: Do not include py-ref.h.
1007         * python/py-param.c: Do not include py-ref.h.
1008         * python/py-prettyprint.c: Do not include py-ref.h.
1009         * python/py-progspace.c: Do not include py-ref.h.
1010         * python/py-symbol.c: Do not include py-ref.h.
1011         * python/py-symtab.c: Do not include py-ref.h.
1012         * python/py-type.c: Do not include py-ref.h.
1013         * python/py-unwind.c: Do not include py-ref.h.
1014         * python/py-utils.c: Do not include py-ref.h.
1015         * python/py-value.c: Do not include py-ref.h.
1016         * python/py-varobj.c: Do not include py-ref.h.
1017         * python/py-xmethods.c: Do not include py-ref.h.
1018         * python/python.c: Do not include py-ref.h.
1019         * varobj.c: Do not include py-ref.h.
1020
1021 2019-01-22  Tom Tromey  <tom@tromey.com>
1022
1023         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1024         keyword for bcache.
1025
1026 2019-01-22  Tom Tromey  <tom@tromey.com>
1027
1028         * compile/compile-cplus-types.c: Remove a comment by #include.
1029
1030 2019-01-22  Tom Tromey  <tom@tromey.com>
1031
1032         * compile/gcc-c-plugin.h: Include compile-internal.h.
1033
1034 2019-01-22  Tom Tromey  <tom@tromey.com>
1035
1036         * stabsread.c (EXTERN): Do not define.
1037         (symnum, next_symbol_text_func, processing_gcc_compilation)
1038         (within_function, global_sym_chain, global_stabs)
1039         (previous_stab_code, this_object_header_files)
1040         (n_this_object_header_files)
1041         (n_allocated_this_object_header_files): Define.
1042         * stabsread.h (EXTERN): Never define.  Use "extern".
1043
1044 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1045
1046         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1047         history_value.
1048
1049 2019-01-21  Tom Tromey  <tom@tromey.com>
1050
1051         * ui-out.c: Fix includes.
1052         * tui/tui-source.c: Fix includes.
1053         * target.c: Fix includes.
1054         * remote.c: Fix includes.
1055         * regcache.c: Fix includes.
1056         * python/py-block.c: Fix includes.
1057         * printcmd.c: Fix includes.
1058         * or1k-tdep.c: Fix includes.
1059         * mi/mi-main.c: Fix includes.
1060         * m32r-tdep.c: Fix includes.
1061         * csky-tdep.c: Fix includes.
1062         * compile/compile-cplus-types.c: Fix includes.
1063         * cli/cli-interp.c: Fix includes.
1064
1065 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1066
1067         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1068         for padding.
1069
1070 2019-01-16  Tom Tromey  <tom@tromey.com>
1071
1072         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1073         earlier.
1074         (struct objfile) <msymbols_range>: Move from top level.
1075         <msymbols>: New method.
1076         (class objfile_msymbols): Remove.
1077         * symtab.c (default_collect_symbol_completion_matches_break_on):
1078         Update.
1079         * symmisc.c (dump_msymbols): Update.
1080         * stabsread.c (scan_file_globals): Update.
1081         * objc-lang.c (info_selectors_command, info_classes_command)
1082         (find_methods): Update.
1083         * minsyms.c (find_solib_trampoline_target): Update.
1084         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1085         * coffread.c (coff_symfile_read): Update.
1086         * ada-lang.c (ada_lookup_simple_minsym)
1087         (ada_collect_symbol_completion_matches): Update.
1088
1089 2019-01-16  Tom Tromey  <tom@tromey.com>
1090
1091         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1092         type.  Remove no-argument constructor.
1093         <iterator::operator++>: Simplify.
1094         <begin>: Update.
1095         <end>: Use minimal_symbol_count.
1096
1097 2019-01-16  Tom Tromey  <tom@tromey.com>
1098
1099         * objfiles.h (struct objfile) <psymtabs>: New method.
1100         (class objfile_psymtabs): Remove.
1101         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1102         typedef.
1103         <range>: New method.
1104         (require_partial_symbols): Change return type.
1105         * psymtab.c (require_partial_symbols)
1106         (psym_expand_symtabs_matching): Update.
1107         * mdebugread.c (parse_partial_symbols): Update.
1108         * dbxread.c (dbx_end_psymtab): Update.
1109
1110 2019-01-15  Tom Tromey  <tom@tromey.com>
1111
1112         * symtab.c (lookup_objfile_from_block)
1113         (lookup_symbol_in_objfile_symtabs)
1114         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1115         (find_line_symtab, info_sources_command)
1116         (default_collect_symbol_completion_matches_break_on)
1117         (make_source_files_completion_list): Update.
1118         * symmisc.c (print_objfile_statistics, dump_objfile)
1119         (maintenance_print_symbols, maintenance_info_symtabs)
1120         (maintenance_check_symtabs, maintenance_info_line_tables):
1121         Update.
1122         * source.c (select_source_symtab)
1123         (forget_cached_source_info_for_objfile): Update.
1124         * objfiles.h (class objfile_compunits): Remove.
1125         (struct objfile) <compunits_range>: New typedef.
1126         (compunits): New method.
1127         * objfiles.c (objfile_relocate1): Update.
1128         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1129         * maint.c (count_symtabs_and_blocks): Update.
1130         * linespec.c (iterate_over_all_matching_symtabs): Update.
1131         * cp-support.c (add_symbol_overload_list_qualified): Update.
1132         * coffread.c (coff_symtab_read): Update.
1133         * ada-lang.c (add_nonlocal_symbols)
1134         (ada_collect_symbol_completion_matches)
1135         (ada_add_global_exceptions): Update.
1136
1137 2019-01-15  Tom Tromey  <tom@tromey.com>
1138
1139         * progspace.h (program_space) <objfiles_safe_range>: New
1140         typedef.
1141         <objfiles_safe>: New method.
1142         * objfiles.h (class all_objfiles_safe): Remove.
1143         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1144         * jit.c (jit_inferior_exit_hook): Update.
1145
1146 2019-01-17  Tom Tromey  <tom@tromey.com>
1147
1148         * progspace.h (program_space) <objfiles_range>: New typedef.
1149         <objfiles>: New method.
1150         <objfiles_head>: Rename from objfiles.
1151         (object_files): Update.
1152         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1153         * guile/scm-pretty-print.c
1154         (ppscm_find_pretty_printer_from_objfiles): Update.
1155         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1156         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1157         Update.
1158         * python/py-progspace.c (pspy_get_objfiles): Update.
1159         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1160         Update.
1161         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1162         (objfpy_lookup_objfile_by_build_id): Update.
1163         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1164         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1165         Update.
1166         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1167         (expand_symtab_containing_pc, lookup_objfile_from_block)
1168         (lookup_static_symbol, basic_lookup_transparent_type)
1169         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1170         (find_line_symtab, info_sources_command)
1171         (default_collect_symbol_completion_matches_break_on)
1172         (make_source_files_completion_list, find_main_name): Update.
1173         * symmisc.c (print_symbol_bcache_statistics)
1174         (print_objfile_statistics, maintenance_print_symbols)
1175         (maintenance_print_msymbols, maintenance_print_objfiles)
1176         (maintenance_info_symtabs, maintenance_check_symtabs)
1177         (maintenance_expand_symtabs, maintenance_info_line_tables):
1178         Update.
1179         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1180         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1181         (map_overlay_command, unmap_overlay_command)
1182         (simple_overlay_update, expand_symtabs_matching)
1183         (map_symbol_filenames): Update.
1184         * symfile-debug.c (set_debug_symfile): Update.
1185         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1186         Update.
1187         * source.c (select_source_symtab, forget_cached_source_info):
1188         Update.
1189         * solib.c (solib_read_symbols): Update.
1190         * solib-spu.c (append_ocl_sos): Update.
1191         * psymtab.c (maintenance_print_psymbols)
1192         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1193         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1194         * printcmd.c (info_symbol_command): Update.
1195         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1196         Update.
1197         * objfiles.h (class all_objfiles): Remove.
1198         * objfiles.c (have_partial_symbols, have_full_symbols)
1199         (have_minimal_symbols, qsort_cmp, update_section_map)
1200         (shared_objfile_contains_address_p)
1201         (default_iterate_over_objfiles_in_search_order): Update.
1202         * objc-lang.c (info_selectors_command, info_classes_command)
1203         (find_methods): Update.
1204         * minsyms.c (find_solib_trampoline_target): Update.
1205         * maint.c (maintenance_info_sections)
1206         (maintenance_translate_address, count_symtabs_and_blocks):
1207         Update.
1208         * main.c (captured_main_1): Update.
1209         * linux-thread-db.c (try_thread_db_load_from_pdir)
1210         (has_libpthread): Update.
1211         * linespec.c (iterate_over_all_matching_symtabs)
1212         (search_minsyms_for_name): Update.
1213         * jit.c (jit_find_objf_with_entry_addr): Update.
1214         * hppa-tdep.c (find_unwind_entry)
1215         (hppa_lookup_stub_minimal_symbol): Update.
1216         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1217         Update.
1218         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1219         (elf_gnu_ifunc_resolve_by_got): Update.
1220         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1221         * dwarf-index-write.c (save_gdb_index_command): Update.
1222         * cp-support.c (add_symbol_overload_list_qualified): Update.
1223         * breakpoint.c (create_overlay_event_breakpoint)
1224         (create_longjmp_master_breakpoint)
1225         (create_std_terminate_master_breakpoint)
1226         (create_exception_master_breakpoint): Update.
1227         * blockframe.c (find_pc_partial_function): Update.
1228         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1229         (ada_collect_symbol_completion_matches)
1230         (ada_add_global_exceptions): Update.
1231
1232 2019-01-17  Tom Tromey  <tom@tromey.com>
1233
1234         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1235         declare VEC.
1236         (solib_target_parse_libraries): Change return type.
1237         (library_list_start_segment, library_list_start_section)
1238         (library_list_end_library, library_list_start_library); Update.
1239         (solib_target_free_library_list): Remove.
1240         (solib_target_parse_libraries): Remove cleanup.  Change return
1241         type.
1242         (solib_target_current_sos): Update.
1243
1244 2019-01-17  Tom Tromey  <tromey@bapiya>
1245
1246         * valprint.c: Replace "the the" with "the".
1247         * symtab.c: Replace "the the" with "the".
1248         * solib.c: Replace "the the" with "the".
1249         * solib-dsbt.c: Replace "the the" with "the".
1250         * linespec.c: Replace "the the" with "the".
1251         * dwarf2loc.h: Replace "the the" with "the".
1252         * amd64-windows-tdep.c: Replace "the the" with "the".
1253         * aarch64-tdep.c: Replace "the the" with "the".
1254
1255 2019-01-16  Keith Seitz  <keiths@redhat.com>
1256
1257         PR gdb/23773
1258         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1259         <builder>: Rename to ..
1260         <m_builder>: ... this and make private.
1261         (dwarf2_cu::get_builder): New method.  Change all users of
1262         `builder' to use this method.
1263         (dwarf2_start_symtab): Move to ...
1264         (dwarf2_cu::start_symtab): ... here.  Update all callers
1265         (setup_type_unit_groups): Move to ...
1266         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1267         callers.
1268         (dwarf2_cu::reset_builder): New method.
1269         (process_full_compunit, process_full_type_unit): Use
1270         dwarf2_cu::reset_builder.
1271         (follow_die_offset): Record the ancestor CU if it is different
1272         from the followed DIE's CU.
1273         (follow_die_sig_1): Likewise.
1274
1275 2019-01-15  Tom Tromey  <tom@tromey.com>
1276
1277         * remote.c (class remote_state) <buf>: Now a char_vector.
1278         <buf_size>: Remove.
1279         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1280         parameter.
1281         (remote_target::getpkt_or_notif_sane_1)
1282         (remote_target::getpkt_sane)
1283         (remote_target::getpkt_or_notif_sane): Likewise.
1284         (class remote_target) <putpkt>: New overload.
1285         (remote_target::read_frame): Change type of "buf_p".  Remove
1286         sizeof_p parameter.
1287         (packet_ok): New overload.
1288         (packet_check_result): New overload.
1289         Update all uses.
1290
1291 2019-01-14  Tom Tromey  <tom@tromey.com>
1292
1293         * remote-notif.c (handle_notification, remote_notif_ack)
1294         (remote_notif_parse): Make "buf" const.
1295         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1296         const.
1297         (remote_notif_parse, remote_notif_ack, handle_notification):
1298         Likewise.
1299         * remote.c (remote_notif_stop_parse): Make "buf" const.
1300         (remote_target::remote_parse_stop_reply): Make "buf" const.
1301         (remote_notif_stop_ack): Make "buf" const.
1302
1303 2019-01-14  Tom Tromey  <tom@tromey.com>
1304
1305         * remote.c (remote_console_output): Make parameter const.
1306
1307 2019-01-14  Tom Tromey  <tom@tromey.com>
1308
1309         * target-debug.h (target_debug_print_signals): Constify.
1310         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1311         * procfs.c (procfs_target::pass_signals): Update.
1312         * linux-nat.c (linux_nat_target::pass_signals): Update.
1313         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1314         * target-delegates.c: Rebuild.
1315         * remote.c (remote_target::program_signals): Update.
1316         (remote_target::pass_signals): Update.
1317         * target.c (target_pass_signals): Constify argument.
1318         (target_program_signals): Likewise.
1319         * target.h (struct target_ops) <pass_signals, program_signals>:
1320         Constify argument.
1321         (target_pass_signals, target_program_signals): Constify argument.
1322
1323 2019-01-14  Tom Tromey  <tom@tromey.com>
1324
1325         PR tui/28819:
1326         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1327
1328 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1329
1330         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1331         field.
1332         * rs6000-tdep.c: Include reggroups.h.
1333         (IS_V_ALIAS_PSEUDOREG): Define.
1334         (rs6000_register_name): Return names for the "vX" aliases.
1335         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1336         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1337         aliases.  Call default_register_reggroup_p for all other
1338         pseudo-registers.
1339         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1340         New functions.
1341         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1342         Handle "vX" aliases.
1343         (v_alias_pseudo_register_collect): New function.
1344         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1345         (rs6000_gdbarch_init): Initialize "vX" aliases as
1346         pseudo-registers.  Restore registration of
1347         rs6000_pseudo_register_reggroup_p with
1348         set_tdesc_pseudo_register_reggroup_p.
1349
1350 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1351
1352         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1353         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1354         set_gdbarch_num_pseudo_regs.
1355
1356 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1357
1358         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1359         Remove arg prefixname, add do_set and do_show.
1360         Add member functions set_list and show_list.
1361         * cli/cli-style.c (class cli_style_option): Update accordingly.
1362         (style_set_list): Move to file scope.
1363         (style_show_list): Likewise.
1364         (set_style): Call help_list.
1365         (show_style): Call cmd_show_list.
1366         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1367         Update to use the new macro.
1368
1369 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1370
1371         * ada-lang.c (_initialize_ada_language): Expand the help text
1372         for the "catch exception" command.
1373
1374 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1375
1376         * symtab.c (matching_obj_sections): Initialize obj,
1377         declare it closer to its usage.
1378
1379 2019-01-10  Tom Tromey  <tom@tromey.com>
1380
1381         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1382         (basic_inf_threads_range): Remove.
1383         (inf_threads_range, inf_non_exited_threads_range)
1384         (safe_inf_threads_range): Use next_adapter.
1385
1386 2019-01-10  Keith Seitz  <keiths@redhat.com>
1387
1388         PR gdb/23712
1389         PR symtab/23010
1390         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1391         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1392
1393 2019-01-10  Keith Seitz  <keiths@redhat.com>
1394
1395         PR gdb/23712
1396         PR symtab/23010
1397         * dictionary.c (pending_to_vector): Remove.
1398         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1399         Remove _1 suffix, replacing functions of the same name.  Update
1400         all callers.
1401         (dict_create_hashed, dict_create_hashed_expandable)
1402         (dict_create_linear, dict_create_linear_expandable, dict_free)
1403         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1404         Make functions static.
1405
1406 2019-01-10  Keith Seitz  <keiths@redhat.com>
1407
1408         PR gdb/23712
1409         PR symtab/23010
1410         * dictionary.h (struct dictionary): Replace declaration with
1411         multidictionary.
1412         (dict_create_hashed, dict_create_hashed_expandable)
1413         (dict_create_linear, dict_create_linear_expandable)
1414         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1415         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1416         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1417         taking multidictionary argument.
1418         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1419         * block.h (struct block) <dict>: Change to multidictionary
1420         and rename `multidict'.
1421         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1422         symmisc.c: Update all dictionary references to multidictionary.
1423
1424 2019-01-10  Keith Seitz  <keiths@redhat.com>
1425
1426         PR gdb/23712
1427         PR symtab/23010
1428         * dictionary.c: Include unordered_map.
1429         (pending_to_vector): New function.
1430         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1431         Rewrite the non-"_1" functions to take vector instead
1432         of linked list.
1433         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1434         "new" _1 versions of the same name.
1435         (multidictionary): Define.
1436         (std::hash<enum language): New definition.
1437         (collate_pending_symbols_by_language, mdict_create_hashed)
1438         (mdict_create_hashed_expandable, mdict_create_linear)
1439         (mdict_create_linear_expandable, mdict_free)
1440         (find_language_dictionary, create_new_language_dictionary)
1441         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1442         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1443         (mdict_size, mdict_empty): New functions.
1444         * dictionary.h (mdict_iterator): Define.
1445
1446 2019-01-10  Pedro Alves  <palves@redhat.com>
1447
1448         * breakpoint.c (read_uploaded_action)
1449         (create_tracepoint_from_upload): Adjust to use
1450         gdb::unique_xmalloc_ptr.
1451         * ctf.c (ctf_write_uploaded_tp):
1452         (SET_ARRAY_FIELD): Use emplace_back.
1453         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1454         * tracefile-tfile.c (tfile_write_uploaded_tp):
1455         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1456         gdb::unique_xmalloc_ptr.
1457         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1458         at_string, cond_string, cmd_strings>: Replace char pointers
1459         with gdb::unique_xmalloc_ptr.
1460
1461 2019-01-10  Pedro Alves  <palves@redhat.com>
1462
1463         * solib-target.c (library_list_start_library): Don't xstrdup name.
1464
1465 2019-01-10  Pedro Alves  <palves@redhat.com>
1466
1467         * mdebugread.c (parse_partial_symbols): Use
1468         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1469
1470 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1471
1472         * linux-fork.c (scoped_switch_fork_info)
1473         <~scoped_switch_fork_info>: Fix incorrect variable name.
1474
1475 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1476
1477         * linux-fork.c (scoped_switch_fork_info)
1478         <scoped_switch_fork_info>: Make explicit.
1479         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1480
1481 2019-01-10  Tom Tromey  <tom@tromey.com>
1482
1483         * objfiles.h (objfile::reset_psymtabs): Update.
1484         * objfiles.c (objfile::objfile): Update.
1485         * psymtab.h (psymtab_storage::obstack): Update.
1486         (psymtab_storage::m_obstack): Use gdb::optional.
1487         (class psymtab_storage): Update comment.  Remove objfile
1488         parameter.
1489         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1490
1491 2019-01-10  Tom Tromey  <tom@tromey.com>
1492
1493         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1494         <free_psymtabs>: Now private.
1495         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1496         (allocate_psymtab): Use new method.
1497
1498 2019-01-10  Tom Tromey  <tom@tromey.com>
1499
1500         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1501         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1502         * mdebugread.c (parse_partial_symbols): Use
1503         allocate_dependencies.
1504         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1505         allocate_dependencies.
1506         (process_psymtab_comp_unit_reader)
1507         (build_type_psymtab_dependencies): Likewise.
1508         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1509
1510 2019-01-10  Tom Tromey  <tom@tromey.com>
1511
1512         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1513         PSYMBOL_SET_LANGUAGE.
1514         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1515
1516 2019-01-10  Tom Tromey  <tom@tromey.com>
1517
1518         * psymtab.h (psymtab_storage::obstack): New method.
1519         <m_obstack>: Rename from obstack; now private.
1520         * psymtab.c (psymtab_storage): Update.
1521         * dwarf2read.c (create_addrmap_from_index)
1522         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1523         Update.
1524
1525 2019-01-10  Tom Tromey  <tom@tromey.com>
1526
1527         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1528         * objfiles.h (objfile::reset_psymtabs): New method.
1529
1530 2019-01-10  Tom Tromey  <tom@tromey.com>
1531
1532         * symmisc.c (print_symbol_bcache_statistics): Update.
1533         (print_objfile_statistics): Update.
1534         * symfile.c (reread_symbols): Update.
1535         * psymtab.h (class psymtab_storage): New.
1536         * psymtab.c (psymtab_storage): New constructor.
1537         (~psymtab_storage): New destructor.
1538         (require_partial_symbols): Update.
1539         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1540         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1541         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1542         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1543         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1544         (start_psymtab_common, end_psymtab_common)
1545         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1546         (allocate_psymtab): Update.
1547         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1548         Update.
1549         (dump_psymtab_addrmap, maintenance_print_psymbols)
1550         (maintenance_check_psymtabs): Update.
1551         (class objfile_psymtabs): Move to objfiles.h.
1552         * psympriv.h (discard_psymtab): Now inline.
1553         (psymtab_discarder::psymtab_discarder): Update.
1554         (psymtab_discarder::~psymtab_discarder): Update.
1555         (ALL_OBJFILE_PSYMTABS): Rewrite.
1556         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1557         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1558         Remove fields.
1559         <partial_symtabs>: New field.
1560         (class objfile_psymtabs): Move from psymtab.h.  Update.
1561         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1562         psymbol_cache.
1563         (objfile::~objfile): Don't destroy psymbol_cache.
1564         * mdebugread.c (parse_partial_symbols): Update.
1565         * dwarf2read.c (create_addrmap_from_index)
1566         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1567         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1568         (add_partial_subprogram, dwarf2_ranges_read): Update.
1569         * dwarf-index-write.c (write_address_map)
1570         (write_one_signatured_type, recursively_write_psymbols)
1571         (class debug_names, class debug_names, write_psymtabs_to_index):
1572         Update.
1573
1574 2019-01-10  Tom Tromey  <tom@tromey.com>
1575
1576         * symtab.h (SYMBOL_SET_NAMES): Update.
1577         (symbol_set_names): Update.
1578         (MSYMBOL_SET_NAMES): Update.
1579         * symtab.c (symbol_set_names): Change argument to be an
1580         objfile_per_bfd_storage.
1581         * psymtab.c (add_psymbol_to_bcache): Update.
1582         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1583
1584 2019-01-10  Tom Tromey  <tom@tromey.com>
1585
1586         * symtab.c (create_demangled_names_hash): Change argument to be an
1587         objfile_per_bfd_storage.
1588         (symbol_set_names): Update.
1589
1590 2019-01-10  Tom Tromey  <tom@tromey.com>
1591
1592         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1593         init_psymbol_list.
1594         * psymtab.c (init_psymbol_list): Do nothing if already called.
1595         * psympriv.h (init_psymbol_list): Add comment.
1596         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1597         init_psymbol_list.
1598         * dbxread.c (dbx_symfile_read): Unconditionally call
1599         init_psymbol_list.
1600
1601 2019-01-10  Tom Tromey  <tom@tromey.com>
1602
1603         * xcoffread.c (scan_xcoff_symtab): Update.
1604         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1605         "where".
1606         * mdebugread.c (parse_partial_symbols)
1607         (handle_psymbol_enumerators): Update.
1608         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1609         * dbxread.c (read_dbx_symtab): Update.
1610         * psympriv.h (psymbol_placement): New enum.
1611         (add_psymbol_to_list): Update.
1612
1613 2019-01-10  Tom Tromey  <tom@tromey.com>
1614
1615         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1616         static_psymbols parameters.
1617         (scan_xcoff_symtab): Update.
1618         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1619         static_psymbols parameters.
1620         * psympriv.h (start_psymtab_common): Update.
1621         * mdebugread.c (parse_partial_symbols): Update.
1622         * dwarf2read.c (create_partial_symtab): Update.
1623         * dbxread.c (read_dbx_symtab): Update.
1624         (start_psymtab): Remove global_psymbols and static_psymbols
1625         parameters.
1626
1627 2019-01-10  Tom Tromey  <tom@tromey.com>
1628
1629         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1630         * psymtab.c (allocate_psymtab): Add comment.
1631         * psympriv.h (allocate_psymtab): Add comment.
1632         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1633         initializations.
1634         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1635
1636 2019-01-10  Tom Tromey  <tom@tromey.com>
1637
1638         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1639         Don't declare.
1640         * mipsread.c: Include mdebugread.h.
1641         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1642         Declare.
1643         * elfread.c: Include mdebugread.h.
1644
1645 2019-01-09  Tom Tromey  <tom@tromey.com>
1646
1647         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1648         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1649         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1650         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1651         (psym_lookup_symbol, psym_find_last_source_symtab)
1652         (psym_forget_cached_source_info, psym_print_stats)
1653         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1654         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1655         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1656         (psym_find_compunit_symtab_by_address)
1657         (maintenance_print_psymbols, maintenance_info_psymtabs)
1658         (maintenance_check_psymtabs): Use ranged for.
1659         * psymtab.h (class objfile_psymtabs): New.
1660         (require_partial_symbols): Return objfile_psymtabs.
1661         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1662
1663 2019-01-09  Tom Tromey  <tom@tromey.com>
1664
1665         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1666         (find_pc_mapped_section, list_overlays_command)
1667         (map_overlay_command, unmap_overlay_command)
1668         (simple_overlay_update): Use all_objfiles.
1669         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1670         * printcmd.c (info_symbol_command): Use all_objfiles.
1671         * objfiles.h (ALL_OBJSECTIONS): Remove.
1672         * maint.c (maintenance_translate_address): Use all_objfiles.
1673         * gcore.c (gcore_create_callback): Use all_objfiles.
1674         (objfile_find_memory_regions): Likewise.
1675
1676 2019-01-09  Tom Tromey  <tom@tromey.com>
1677
1678         * symtab.c (find_line_symtab, info_sources_command)
1679         (make_source_files_completion_list): Use objfile_compunits.
1680         * source.c (select_source_symtab): Use objfile_compunits.
1681         * objfiles.h (struct objfile): Update comment.
1682         (ALL_OBJFILES): Remove.
1683         (ALL_FILETABS): Remove.
1684         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1685         objfile_compunits.
1686
1687 2019-01-09  Tom Tromey  <tom@tromey.com>
1688
1689         * symmisc.c (print_objfile_statistics, dump_objfile)
1690         (maintenance_print_symbols): Use compunit_filetabs.
1691         * source.c (forget_cached_source_info_for_objfile): Use
1692         compunit_filetabs.
1693         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1694         (ALL_FILETABS): Use compunit_filetabs.
1695         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1696         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1697
1698 2019-01-09  Tom Tromey  <tom@tromey.com>
1699
1700         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1701         (compunit_filetabs): New.
1702         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1703         compunit_filetabs.
1704         (info_sources_command, make_source_files_completion_list): Remove
1705         declaration.
1706         * symmisc.c (print_objfile_statistics, dump_objfile)
1707         (maintenance_print_symbols): Remove declaration.
1708         (maintenance_info_symtabs): Use compunit_filetabs.
1709         (maintenance_info_line_tables): Likewise.
1710         * source.c (select_source_symtab): Change local variable name.
1711         (forget_cached_source_info_for_objfile): Remove declaration.
1712         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1713         * objfiles.c (objfile_relocate1): Remove declaration.
1714         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1715         declaration.
1716         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1717         * coffread.c (coff_symtab_read): Remove declaration.
1718         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1719         compunit_filetabs.
1720
1721 2019-01-09  Tom Tromey  <tom@tromey.com>
1722
1723         * symtab.c (lookup_objfile_from_block)
1724         (find_pc_sect_compunit_symtab, search_symbols)
1725         (default_collect_symbol_completion_matches_break_on): Use
1726         objfile_compunits.
1727         * objfiles.h (ALL_COMPUNITS): Remove.
1728         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1729         * cp-support.c (add_symbol_overload_list_qualified): Use
1730         objfile_compunits.
1731         * ada-lang.c (ada_collect_symbol_completion_matches)
1732         (ada_add_global_exceptions): Use objfile_compunits.
1733
1734 2019-01-09  Tom Tromey  <tom@tromey.com>
1735
1736         * source.c (select_source_symtab)
1737         (forget_cached_source_info_for_objfile): Remove declaration.
1738         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1739         declaration.
1740         * maint.c (count_symtabs_and_blocks): Remove declaration.
1741         * cp-support.c (add_symbol_overload_list_qualified): Remove
1742         declaration.
1743         * coffread.c (coff_symtab_read): Remove declaration.
1744         * symtab.c (lookup_symbol_in_objfile_symtabs)
1745         (basic_lookup_transparent_type_1): Use objfile_compunits.
1746         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1747         (info_sources_command, search_symbols)
1748         (default_collect_symbol_completion_matches_break_on)
1749         (make_source_files_completion_list): Remove declaration.
1750         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1751         (ada_collect_symbol_completion_matches)
1752         (ada_add_global_exceptions): Remove declaration.
1753         * linespec.c (iterate_over_all_matching_symtabs): Use
1754         objfile_compunits.
1755         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1756         (class objfile_compunits): New.
1757         (ALL_COMPUNITS): Use objfile_compunits.
1758         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1759         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1760         objfile_compunits.
1761         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1762
1763 2019-01-09  Tom Tromey  <tom@tromey.com>
1764
1765         * symtab.c (search_symbols)
1766         (default_collect_symbol_completion_matches_break_on): Use
1767         objfile_msymbols.
1768         * ada-lang.c (ada_lookup_simple_minsym)
1769         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1770         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1771         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1772         objfile_msymbols.
1773         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1774         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1775         * objc-lang.c (find_methods): Use objfile_msymbols.
1776         (info_selectors_command, info_classes_command): Likewise.
1777         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1778         * objfiles.h (class objfile_msymbols): New.
1779         (ALL_OBJFILE_MSYMBOLS): Remove.
1780         (ALL_MSYMBOLS): Remove.
1781
1782 2019-01-09  Tom Tromey  <tom@tromey.com>
1783
1784         * common/next-iterator.h (next_adapter): Add Iterator template
1785         parameter.
1786         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1787         (class all_objfiles_safe): New.
1788         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1789         * objfiles.c (put_objfile_before): Update comment.
1790         (add_separate_debug_objfile): Likewise.
1791         (free_all_objfiles): Use all_objfiles_safe.
1792         (objfile_purge_solibs): Likewise.
1793
1794 2019-01-09  Tom Tromey  <tom@tromey.com>
1795
1796         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1797         (expand_symtab_containing_pc, lookup_static_symbol)
1798         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1799         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1800         all_objfiles.
1801         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1802         * breakpoint.c (create_overlay_event_breakpoint)
1803         (create_longjmp_master_breakpoint)
1804         (create_std_terminate_master_breakpoint)
1805         (create_exception_master_breakpoint): Use all_objfiles.
1806         * linux-thread-db.c (try_thread_db_load_from_pdir)
1807         (has_libpthread): Use all_objfiles.
1808         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1809         * linespec.c (iterate_over_all_matching_symtabs)
1810         (search_minsyms_for_name): Use all_objfiles.
1811         * maint.c (maintenance_info_sections): Use all_objfiles.
1812         * main.c (captured_main_1): Use all_objfiles.
1813         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1814         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1815         * guile/scm-pretty-print.c
1816         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1817         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1818         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1819         (maintenance_print_msymbols): Use all_objfiles.
1820         * source.c (select_source_symtab): Use all_objfiles.
1821         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1822         * symfile.c (remove_symbol_file_command)
1823         (expand_symtabs_matching, map_symbol_filenames): Use
1824         all_objfiles.
1825         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1826         all_objfiles.
1827         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1828         * objc-lang.c (find_methods): Use all_objfiles.
1829         * objfiles.c (have_partial_symbols, have_full_symbols)
1830         (have_minimal_symbols, qsort_cmp)
1831         (default_iterate_over_objfiles_in_search_order): Use
1832         all_objfiles.
1833         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1834         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1835         (maintenance_check_psymtabs): Use all_objfiles.
1836         (ALL_PSYMTABS): Remove.
1837         * compile/compile-object-run.c (do_module_cleanup): Use
1838         all_objfiles.
1839         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1840         * cp-support.c (add_symbol_overload_list_qualified): Use
1841         all_objfiles.
1842         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1843         Use all_objfiles.
1844         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1845         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1846         all_objfiles.
1847         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1848         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1849         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1850         Uses all_objfiles.
1851         * solib.c (solib_read_symbols): Use all_objfiles
1852
1853 2019-01-09  Tom Tromey  <tom@tromey.com>
1854
1855         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1856         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1857         all_objfiles.
1858         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1859         * symmisc.c (print_symbol_bcache_statistics)
1860         (print_objfile_statistics, maintenance_print_objfiles)
1861         (maintenance_info_symtabs, maintenance_check_symtabs)
1862         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1863         all_objfiles.
1864         * source.c (forget_cached_source_info): Use all_objfiles.
1865         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1866         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1867         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1868         * objfiles.c (update_section_map): Use all_objfiles.
1869         (shared_objfile_contains_address_p): Likewise.
1870         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1871         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1872
1873 2019-01-09  Tom Tromey  <tom@tromey.com>
1874
1875         * common/next-iterator.h: New file.
1876         * objfiles.h (class all_objfiles): New.
1877         (struct objfile_iterator): New.
1878
1879 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1880
1881         * NEWS: Move the description of the changed "frame", "select-frame",
1882          and "info frame" commands to the Changed commands section.
1883
1884 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1885
1886         * gdbtypes.c (check_stub_method_group): Remove handling of old
1887         mangling schemes.
1888         * linespec.c (find_methods): Likewise.
1889         * stabsread.c (read_member_functions): Likewise.
1890         * valops.c (search_struct_method): Likewise.
1891         (value_struct_elt_for_reference): Likewise.
1892         * NEWS: Mention this change.
1893
1894 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1897         print_source_lines.
1898         * source.c (print_source_lines_base): Update line number check.
1899         (print_source_lines): New function.
1900         (source_lines_range::source_lines_range): New function.
1901         * source.h (class source_lines_range): New class.
1902         (print_source_lines): New declaration.
1903
1904 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1905
1906         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1907
1908 2019-01-08  Tom Tromey  <tom@tromey.com>
1909             Simon Marchi  <simon.marchi@ericsson.com>
1910
1911         PR gdb/24060
1912         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1913         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1914         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1915         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1916         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1917         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1918
1919 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1920
1921         * source.c (select_source_symtab): Move header comment to
1922         declaration in source.h.
1923         (forget_cached_source_info_for_objfile): Likewise.
1924         (forget_cached_source_info): Likewise.
1925         (identify_source_line): Likewise.
1926         * source.h (identify_source_line): Move declaration from symtab.h
1927         and add comment from source.c
1928         (print_source_lines): Likewise.
1929         (forget_cached_source_info_for_objfile): Likewise.
1930         (forget_cached_source_info): Likewise.
1931         (select_source_symtab): Likewise.
1932         (enum print_source_lines_flag): Move definition from symtab.h.
1933         * symtab.h (identify_source_line): Move declaration to source.h.
1934         (print_source_lines): Likewise.
1935         (forget_cached_source_info_for_objfile): Likewise.
1936         (forget_cached_source_info): Likewise.
1937         (select_source_symtab): Likewise.
1938         (enum print_source_lines_flag): Move definition to source.h.
1939         * tui/tui-hooks.c: Add 'source.h' include.
1940
1941 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1942
1943         * source.c (print_source_lines_base): Handle requests to print
1944         reverse line number sequences, and guard against empty lines
1945         string.
1946
1947 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1948
1949         * source.c (print_source_lines_base): Fix skip of '\r' if next
1950         character is '\n'.
1951
1952 2019-01-06  Tom Tromey  <tom@tromey.com>
1953
1954         * c-exp.y (struct c_parse_state) <macro_original_text,
1955         expansion_obstack>: New member.
1956         (macro_original_text, expansion_obstack): Remove globals.
1957         (scan_macro_expansion, scanning_macro_expansion)
1958         (finished_macro_expansion): Update.
1959         (scan_macro_cleanup): Remove.
1960         (yylex, c_parse): Update.
1961
1962 2019-01-06  Tom Tromey  <tom@tromey.com>
1963
1964         * c-exp.y (struct c_parse_state) <strings>: New member.
1965         (operator_stoken): Update.
1966
1967 2019-01-06  Tom Tromey  <tom@tromey.com>
1968
1969         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1970         (union type_stack_elt) <typelist_val>: Now a pointer to
1971         std::vector.
1972         (type_stack_cleanup): Don't declare.
1973         (push_typelist): Update.
1974         * parse.c (pop_typelist): Return a std::vector.
1975         (push_typelist): Take a std::vector.
1976         (follow_types): Update.  Do not free args.
1977         (type_stack_cleanup): Remove.
1978         * c-exp.y (struct c_parse_state): New.
1979         (cpstate): New global.
1980         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1981         (nonempty_typelist): Update.
1982         (func_mod): Create a new vector.
1983         (c_parse): Create a c_parse_state.
1984         (check_parameter_typelist): Do not delete params.
1985         (function_method): Update.  Do not delete type_list.
1986
1987 2019-01-06  Tom Tromey  <tom@tromey.com>
1988
1989         PR gdb/28155:
1990         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1991         check_typedef.
1992         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1993         (print_return_value): Likewise.
1994
1995 2019-01-05  Tom Tromey  <tom@tromey.com>
1996
1997         * contrib/cleanup_check.py: Remove.
1998         * contrib/gcc-with-excheck: Remove.
1999         * contrib/exsummary.py: Remove.
2000         * contrib/excheck.py: Remove.
2001
2002 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2003
2004         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2005         NULL. Initialize tpprev to NULL instead of assigning it
2006         to NULL on the next statement.
2007         * windows-nat.c (windows_delete_thread): Remove check for
2008         main_thread_id before printing thread exit notifications.
2009         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2010         Remove thread ID check against main_thread_id.
2011         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2012         windows_delete_thread.
2013         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2014
2015 2019-01-04  Tom Tromey  <tom@tromey.com>
2016
2017         * compile/compile.c (_initialize_compile): Use upper case for
2018         metasyntactic variables.
2019         * symmisc.c (_initialize_symmisc): Use upper case for
2020         metasyntactic variables.
2021         * psymtab.c (_initialize_psymtab): Use upper case for
2022         metasyntactic variables.
2023         * demangle.c (demangle_command): Use upper case for metasyntactic
2024         variables.
2025         (_initialize_demangler): Likewise.
2026         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2027         variables.
2028
2029 2019-01-03  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2032
2033 2019-01-03  Tom Tromey  <tom@tromey.com>
2034
2035         * python/py-symtab.c (salpy_str): Update.
2036         (struct salpy_sal_object) <symtab>: Now a PyObject.
2037         (salpy_dealloc): Update.
2038         (del_objfile_sal): Use gdbpy_ref.
2039
2040 2019-01-03  Tom Tromey  <tom@tromey.com>
2041
2042         * python/py-type.c (convert_field): Use new_reference.  Return
2043         gdbpy_ref.
2044         (make_fielditem): Return gdbpy_ref.
2045         (typy_fields): Update.
2046         (typy_getitem): Update.
2047         (field_name): Return gdbpy_ref.  Use new_reference.
2048         (typy_iterator_iternext): Update.
2049
2050 2019-01-03  Tom Tromey  <tom@tromey.com>
2051
2052         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2053
2054 2019-01-03  Tom Tromey  <tom@tromey.com>
2055
2056         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2057         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2058         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2059         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2060         (pspy_set_type_printers): Likewise.
2061         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2062         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2063         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2064         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2065         (objfpy_set_type_printers): Likewise.
2066
2067 2019-01-03  Tom Tromey  <tom@tromey.com>
2068
2069         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2070         (gdbpy_print_stack): Use gdbpy_err_fetch.
2071         * python/python-internal.h (class gdbpy_err_fetch): New class.
2072         (class gdbpy_enter) <m_error_type, m_error_value,
2073         m_error_traceback>: Remove.
2074         <m_error>: New member.
2075         (gdbpy_exception_to_string): Don't declare.
2076         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2077         * python/py-value.c (convert_value_from_python): Use
2078         gdbpy_err_fetch.
2079         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2080         gdbpy_exception_to_string.
2081         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2082         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2083         gdbpy_err_fetch.
2084
2085 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2086
2087         * linux-nat.c (delete_lwp_cleanup): Delete.
2088         (struct lwp_deleter): New struct.
2089         (lwp_info_up): New typedef.
2090         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2091         lwp_info_up.
2092
2093 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2094
2095         * linux-fork.c (class scoped_switch_fork_info): New class.
2096         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2097
2098 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2099
2100         * valops.c (find_overload_match): Remove use of null_cleanup, and
2101         calls to do_cleanups.
2102
2103 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2104
2105         * compile/compile-cplus-types.c
2106         (compile_cplus_instance::decl_name): Handle changes to
2107         cp_func_name.
2108         * cp-support.c (cp_func_name): Update header comment, update
2109         return type.
2110         * cp-support.h (cp_func_name): Update return type in declaration.
2111         * valops.c (find_overload_match): Move temp_func local to top
2112         level of function and change its type.  Use temp_func to hold and
2113         delete temporary string obtained from cp_func_name.
2114
2115 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2116
2117         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2118         gdb::char_vector, remove cleanup, and update uses of `msg`.
2119
2120 2019-01-03  Jim Wilson  <jimw@sifive.com>
2121
2122         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2123
2124 2019-01-02  Tom Tromey  <tom@tromey.com>
2125
2126         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2127         (tdesc_parse_xml): Remove cleanups.
2128         * target-descriptions.h (make_cleanup_free_target_description):
2129         Don't declare.
2130         (target_desc_deleter): New struct.
2131         (target_desc_up): New typedef.
2132         * target-descriptions.c (target_desc_deleter::operator()): Rename
2133         from free_target_description.
2134         (make_cleanup_free_target_description): Remove.
2135
2136 2019-01-02  Tom Tromey  <tom@tromey.com>
2137
2138         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2139         constructor, destructor.
2140         (linespec_parser): Remove typedef.
2141         (~linespec_parser): Rename from linespec_parser_delete.
2142         (linespec_lex_to_end, linespec_complete_label)
2143         (linespec_complete): Update.
2144         (decode_line_full): Remove cleanups.
2145         (decode_line_1): Update.
2146
2147 2019-01-02  Tom Tromey  <tom@tromey.com>
2148
2149         * python/python-internal.h (inferior_to_inferior_object): Change
2150         return type.
2151         * python/py-exitedevent.c (create_exited_event_object): Update.
2152         * python/py-inferior.c (inferior_to_inferior_object): Return
2153         gdbpy_ref.
2154         (python_new_inferior, python_inferior_deleted)
2155         (thread_to_thread_object, delete_thread_object)
2156         (build_inferior_list, gdbpy_selected_inferior): Update.
2157         * python/py-infthread.c (create_thread_object): Update.  Also fail
2158         if inferior_to_inferior_object fails.
2159
2160 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2161
2162         * inferior.h (class inferior) <displaced_step_state>: New field.
2163         * infrun.h (struct displaced_step_state): Move here from
2164         infrun.c.  Initialize fields, add constructor.
2165         <inf>: Remove field.
2166         <reset>: New method.
2167         * infrun.c (struct displaced_step_inferior_state): Move to
2168         infrun.h.
2169         (displaced_step_inferior_states): Remove.
2170         (get_displaced_stepping_state): Adust.
2171         (displaced_step_in_progress_any_inferior): Adjust.
2172         (displaced_step_in_progress_thread): Adjust.
2173         (displaced_step_in_progress): Adjust.
2174         (add_displaced_stepping_state): Remove.
2175         (get_displaced_step_closure_by_addr): Adjust.
2176         (remove_displaced_stepping_state): Remove.
2177         (infrun_inferior_exit): Call displaced_step_state.reset.
2178         (use_displaced_stepping): Don't check for NULL.
2179         (displaced_step_prepare_throw): Call
2180         get_displaced_stepping_state.
2181         (displaced_step_fixup): Don't check for NULL.
2182         (prepare_for_detach): Don't check for NULL.
2183
2184 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2185
2186         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2187          in case of call that did not complete.
2188
2189 2019-01-02  Andrey Utkin  <autkin@undo.io>
2190
2191         * symfile.c (find_separate_debug_file): Fix search of debug files for
2192         remote debuggee.
2193
2194 2019-01-02  Tom Tromey  <tom@tromey.com>
2195
2196         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2197         indentation.
2198         * python/py-frame.c (frapy_older): Remove cast.
2199         (frapy_newer): Likewise.
2200         * python/py-breakpoint.c (local_setattro): Remove cast.
2201         * python/py-arch.c (archpy_name): Remove local variable.
2202         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2203
2204 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2205
2206         * unittests/basic_string_view/element_access/char/empty.cc:
2207         Fix year range in copyright header.
2208
2209 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2212         Delete.
2213         <operator==>: Update with for removed field.
2214         <hash>: Likewise.
2215         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2216         <isa_features>: ...this.
2217         <abi_features>: New field.
2218         (riscv_isa_flen): Update comment.
2219         (riscv_abi_xlen): New declaration.
2220         (riscv_abi_flen): New declaration.
2221         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2222         isa_features.
2223         (riscv_abi_xlen): New function.
2224         (riscv_isa_flen): Update to get answer from isa_features.
2225         (riscv_abi_flen): New function.
2226         (riscv_has_fp_abi): Update to get answer from abi_features.
2227         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2228         xlen and flen.
2229         (riscv_call_info) <xlen, flen>: Update comment.
2230         (riscv_call_arg_struct): Remove invalid assertions
2231         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2232         is removed.
2233         (riscv_gdbarch_init): Gather isa features and abi features
2234         separately, ensure both match on the gdbarch when reusing an old
2235         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2236         a target with 64-bit float hardware.
2237
2238 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2239
2240         * source.c (search_command_helper): Stop reverse search
2241         when line 1 has been searched.
2242
2243 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2244
2245         * record-full.c (record_full_base_target::close): Rewrite
2246         record_full_core_buf_list free logic.
2247
2248 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2249
2250         * break-catch-syscall.c (print_one_catch_syscall): xfree
2251         the last text.
2252
2253 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2254
2255         * top.c (print_gdb_version): Update Copyright year in version
2256         message.
2257
2258 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2259
2260         Update copyright year range in all GDB files.
2261
2262 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2263
2264         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2265
2266 For older changes see ChangeLog-2018.
2267 \f
2268 Local Variables:
2269 mode: change-log
2270 left-margin: 8
2271 fill-column: 74
2272 version-control: never
2273 coding: utf-8
2274 End:
2275