gdb/ChangeLog

   1 2019-08-15  Tom de Vries  <tdevries@suse.de>
   2
   3         * linux-nat-trad.c: Include gdbarch.h.
   4
   5 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
   6
   7         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
   8         register sizes.
   9
  10 2019-08-14  Tom Tromey  <tromey@adacore.com>
  11
  12         * darwin-nat.c: Include gdbarch.h.
  13         * darwin-nat-info.c: Include gdbarch.h.
  14
  15 2019-08-13  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
  18         Remove.
  19         * tui/tui-data.c (tui_initialize_static_data): Update.
  20
  21 2019-08-13  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-winsource.h (struct tui_exec_info_window)
  24         <~tui_exec_info_window, maybe_allocate_content, get_content,
  25         m_content>: Remove.
  26         (struct tui_source_window_base) <set_exec_info_content,
  27         show_exec_info_content>: Don't declare.
  28         * tui/tui-winsource.c
  29         (tui_exec_info_window::maybe_allocate_content): Remove.
  30         (tui_source_window_base::update_exec_info): Rename from
  31         set_exec_info_content.
  32         (tui_source_window_base::show_exec_info_content)
  33         (tui_source_window_base::update_exec_info): Remove.
  34
  35 2019-08-13  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
  38         declare.
  39         * tui/tui-winsource.c (tui_update_source_window_as_is)
  40         (tui_update_source_windows_with_addr, tui_erase_source_content):
  41         Update.
  42         (tui_clear_exec_info_content): Remove.
  43
  44 2019-08-13  Tom Tromey  <tom@tromey.com>
  45
  46         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
  47         declare.
  48         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
  49         call tui_erase_exec_info_content.
  50         (tui_clear_exec_info_content): Rename from
  51         tui_erase_exec_info_content.
  52         (tui_clear_exec_info_content): Delete.
  53
  54 2019-08-13  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-winsource.h (struct tui_source_window_base)
  57         <show_exec_info_content>: Declare.
  58         (tui_show_exec_info_content): Don't declare.
  59         * tui/tui-winsource.c
  60         (tui_source_window_base::show_exec_info_content): Rename from
  61         tui_show_exec_info_content.
  62         (tui_source_window_base::update_exec_info): Update.
  63
  64 2019-08-13  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
  67         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
  68         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
  69         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
  70         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
  71         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
  72         ... here.
  73
  74 2019-08-13  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-winsource.h (struct tui_source_window_base)
  77         <update_exec_info>: Declare.
  78         (tui_update_exec_info): Don't declare.
  79         * tui/tui-winsource.c (tui_update_source_window_as_is)
  80         (tui_source_window_base::refresh_all)
  81         (tui_update_all_breakpoint_info): Update.
  82         (tui_source_window_base::update_exec_info): Rename from
  83         tui_update_exec_info.
  84         * tui/tui-stack.c (tui_show_frame_info): Update.
  85
  86 2019-08-13  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-winsource.h (struct tui_source_window_base)
  89         <set_exec_info_content>: Declare.
  90         (tui_set_exec_info_content): Don't declare.
  91         * tui/tui-winsource.c
  92         (tui_source_window_base::set_exec_info_content): Rename from
  93         tui_set_exec_info_content.
  94         (tui_update_exec_info): Update.
  95
  96 2019-08-13  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-winsource.h (struct tui_source_window_base)
  99         <show_source_content>: Declare.
 100         (tui_show_source_content): Don't declare.
 101         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 102         (tui_source_window_base::show_source_content): Rename from
 103         tui_show_source_content.
 104         (tui_source_window_base::refresh_all): Update.
 105         * tui/tui-layout.c (show_source_disasm_command)
 106         (show_source_or_disasm_and_command): Update.
 107
 108 2019-08-13  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-winsource.c (tui_erase_source_content)
 111         (tui_show_source_content, tui_source_window_base::refresh_all):
 112         Update.
 113         * tui/tui-wingeneral.h
 114         (tui_check_and_display_highlight_if_needed): Don't declare.
 115         * tui/tui-wingeneral.c
 116         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 117         check_and_display_highlight_if_needed.
 118         * tui/tui-win.c (tui_rehighlight_all)
 119         (tui_win_info::make_visible_with_new_height): Update.
 120         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 121         (tui_data_window::erase_data_content)
 122         (tui_data_window::display_all_data): Update.
 123         * tui/tui-data.h (struct tui_win_info)
 124         <check_and_display_highlight_if_needed>: Declare.
 125
 126 2019-08-13  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-win.c (tui_resize_all): Call
 129         tui_delete_invisible_windows.
 130         * tui/tui-layout.c (show_layout): Call
 131         tui_delete_invisible_windows.
 132         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 133         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 134
 135 2019-08-13  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 138         tui_add_win_to_layout.
 139
 140 2019-08-13  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 143         * tui/tui-layout.c (tui_default_win_height): Now static.
 144
 145 2019-08-13  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 148         single switch.
 149         (show_source_disasm_command, show_source_or_disasm_and_command):
 150         Don't check current layout.
 151
 152 2019-08-13  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-wingeneral.c (make_all_visible): Remove.
 155         (tui_make_all_invisible): Simplify.
 156         * tui/tui-layout.c (tui_make_all_invisible): Move from
 157         tui-wingeneral.c; simplify.
 158         (show_layout): Hoist call to tui_make_all_invisible.
 159         (show_data): Don't call tui_make_all_invisible.
 160
 161 2019-08-13  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 164         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 165
 166 2019-08-13  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 169         tui-data.c.
 170         (show_source_disasm_command, show_data)
 171         (show_source_or_disasm_and_command): Don't use
 172         tui_set_current_layout_to.
 173         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 174         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 175         tui-layout.c.
 176         (tui_set_current_layout_to): Remove.
 177
 178 2019-08-13  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-layout.c (tui_set_layout): Update.
 181         * tui/tui-data.h (struct tui_layout_def): Remove.
 182         (tui_layout_def): Don't declare.
 183         * tui/tui-data.c (layout_def): Remove.
 184         (tui_layout_def): Remove.
 185
 186 2019-08-13  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-winsource.h (struct tui_source_window_base)
 189         <clear_detail>: No longer "override".
 190         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 191         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 192         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 193         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 194         Remove.
 195         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 196
 197 2019-08-13  Tom Tromey  <tromey@adacore.com>
 198
 199         * tracepoint.c: Don't include readline.h or history.h.
 200
 201 2019-08-12  Tom Tromey  <tom@tromey.com>
 202
 203         * configure: Rebuild.
 204         * configure.ac: Check for readline 7.
 205         * NEWS: Mention readline 7 requirement.
 206         * README: Update.
 207
 208 2019-08-12  Tom Tromey  <tom@tromey.com>
 209
 210         * mingw-hdep.c (gdb_select): Remove readline hack.
 211
 212 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 213
 214         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 215         when the function fails.
 216
 217 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 218
 219         * s390-tdep.c (s390_type_align): New function.
 220         (s390_gdbarch_init): Set it as type_align gdbarch method.
 221
 222 2019-08-09  Tom de Vries  <tdevries@suse.de>
 223
 224         PR gdb/24591
 225         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 226         pc_low with relocation offset.
 227
 228 2019-08-07  Tom Tromey  <tromey@adacore.com>
 229
 230         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 231         (print_frame_args): Update.
 232         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 233         Update.
 234         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 235         * frame.h (struct frame_arg): Add initializers.
 236         <error>: Now a unique_xmalloc_ptr.
 237
 238 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 239
 240         * NEWS: Expand the Pointer Authentication entry.
 241         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 242         (aarch64_frame_unmask_lr): ... to this.
 243         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 244         Call aarch64_frame_unmask_lr.
 245         * frame.c (struct frame_info): Add "masked" variable.
 246         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 247         (fprint_frame): Check for masked pc.
 248         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 249         declarations.
 250         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 251         * stack.c (print_frame): Check for masked pc.
 252
 253 2019-08-06  Tom Tromey  <tom@tromey.com>
 254
 255         * stabsread.c (patch_block_stabs, read_one_struct_field)
 256         (read_enum_type): Use obstack_strndup.
 257         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 258         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 259         * dwarf2read.c (guess_full_die_structure_name)
 260         (anonymous_struct_prefix): Use obstack_strndup.
 261         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 262         * c-exp.y (yylex): Use obstack_strndup.
 263         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 264         (write_var_or_type): Use obstack_strndup.
 265
 266 2019-08-06  Tom Tromey  <tom@tromey.com>
 267
 268         * symfile.c (reread_symbols): Use obstack_strdup.
 269         * stabsread.c (read_type): Use obstack_strdup.
 270         * gdb_obstack.h (obstack_strdup): New overload.
 271         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 272         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 273         (dwarf2_canonicalize_name): Use obstack_strdup.
 274         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 275         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 276         Use obstack_strdup.
 277
 278 2019-08-06  Tom Tromey  <tom@tromey.com>
 279
 280         * gdb_obstack.h (obstack_strdup): Define.
 281         * gdb_obstack.c (obstack_strdup): Don't define.
 282
 283 2019-08-06  Tom Tromey  <tom@tromey.com>
 284
 285         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 286         obstack_strdup.
 287         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 288         obstack_strdup.
 289         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 290         * stabsread.c (common_block_start): Use obstack_strdup.
 291         * objfiles.c (set_objfile_main_name, objfile): Use
 292         obstack_strdup.
 293         * namespace.c (add_using_directive): Use obstack_strdup.
 294         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 295         * jit.c (finalize_symtab): Use obstack_strdup.
 296         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 297         (guess_partial_die_structure_name, partial_die_info::fixup)
 298         (dwarf2_name): Use obstack_strdup.
 299         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 300         obstack_strdup.
 301         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 302         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 303         obstack_strdup.
 304         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 305
 306 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 307
 308         * unittests/help-doc-selftests.c: New file.
 309         * Makefile.in: Add the new file.
 310
 311 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 312
 313         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 314         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 315         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 316         the trailing '.' is not output, and the first character is uppercased.
 317         (print_help_for_command): Update call to print_doc_line.
 318         (print_doc_of_command): Likewise.
 319         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 320         * cli/cli-option.c (append_indented_doc): Do not append newline.
 321         (build_help_option): Append newline after first appended_indented_doc
 322         only if a second call is done.
 323         (build_help): Append 2 new lines before each option, except the first
 324         one.
 325         * compile/compile.c (_initialize_compile): Add new lines after
 326         %OPTIONS%, when not at the end of the help.
 327         Change help doc or code
 328         producing the help doc to respect the invariants.
 329         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 330         Also removed the new line after 'Options:', as all other commands
 331         do not put an empty line between 'Options:' and the first option.
 332         * printcmd.c (_initialize_printcmd): Likewise.
 333         * stack.c (_initialize_stack): Likewise.
 334         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 335         incorrectly telling COMMAND is optional.
 336         * ada-lang.c (_initialize_ada_language): Change help doc or code
 337         producing the help doc to respect the invariants.
 338         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 339         * breakpoint.c (_initialize_breakpoint): Likewise.
 340         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 341         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 342         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 343         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 344         _initialize_cli_style): Likewise.
 345         * corelow.c (core_target_info): Likewise.
 346         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 347         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 348         * filesystem.c (_initialize_filesystem): Likewise.
 349         * frame.c (_initialize_frame): Likewise.
 350         * gnu-nat.c (add_task_commands): Likewise.
 351         * infcall.c (_initialize_infcall): Likewise.
 352         * infcmd.c (_initialize_infcmd): Likewise.
 353         * interps.c (_initialize_interpreter): Likewise.
 354         * language.c (_initialize_language): Likewise.
 355         * linux-fork.c (_initialize_linux_fork): Likewise.
 356         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 357         * maint.c (_initialize_maint_cmds): Likewise.
 358         * memattr.c (_initialize_mem): Likewise.
 359         * printcmd.c (_initialize_printcmd): Likewise.
 360         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 361         _RegEx): Likewise.
 362         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 363         * record-btrace.c (_initialize_record_btrace): Likewise.
 364         * record-full.c (_initialize_record_full): Likewise.
 365         * record.c (_initialize_record): Likewise.
 366         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 367         * regcache.c (_initialize_regcache): Likewise.
 368         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 369         _initialize_remote): Likewise.
 370         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 371         * serial.c (_initialize_serial): Likewise.
 372         * skip.c (_initialize_step_skip): Likewise.
 373         * source.c (_initialize_source): Likewise.
 374         * stack.c (_initialize_stack): Likewise.
 375         * symfile.c (_initialize_symfile): Likewise.
 376         * symtab.c (_initialize_symtab): Likewise.
 377         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 378         * top.c (init_main): Likewise.
 379         * tracefile-tfile.c (tfile_target_info): Likewise.
 380         * tracepoint.c (_initialize_tracepoint): Likewise.
 381         * tui/tui-win.c (_initialize_tui_win): Likewise.
 382         * utils.c (add_internal_problem_command): Likewise.
 383         * valprint.c (value_print_option_defs): Likewise.
 384
 385 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 386
 387         PR build/24886
 388         * configure.ac: Drop enable-libmcheck support.
 389         * configure, config.in: Rebuild.
 390         * libmcheck.m4: Remove.
 391         * acinclude.m4: Don't include it.
 392         * Makefile.in: Don't distribute it.
 393         * top.c (print_gdb_configuration): Don't mention it.
 394
 395 2019-08-06  Tom Tromey  <tom@tromey.com>
 396
 397         * utils.c (set_output_style): Sometimes pass stream to
 398         emit_style_escape.
 399         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 400         * record-btrace.c (btrace_insn_history): Update.
 401         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 402         method.
 403         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 404         Update initializers.
 405         <m_uiout>: New field.
 406         <m_di>: Move lower.
 407         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 408         Remove "uiout" parameter.
 409         (dump_insns): Update.
 410         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 411         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 412
 413 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 414
 415         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 416         (error_in_psymtab_expansion): Likewise.
 417         (lookup_symbol_via_quick_fns): Likewise.
 418         (basic_lookup_transparent_type_quick): Likewise.
 419         (basic_lookup_transparent_type_1): Likewise.
 420
 421 2019-08-06  Tom Tromey  <tromey@adacore.com>
 422
 423         * source.c (last_source_error): Now bool.
 424         (print_source_lines_base): Make "noprint" bool.  Only open
 425         source file when last_source_visited changes.
 426
 427 2019-08-06  Tom Tromey  <tromey@adacore.com>
 428
 429         * annotate.c (annotate_source_line): Use g_source_cache.
 430         * source-cache.c (source_cache::get_plain_source_lines): Change
 431         parameters.  Populate m_offset_cache.
 432         (source_cache::ensure): New method.
 433         (source_cache::get_line_charpos): New method.
 434         (extract_lines): Move lower.  Change parameters.
 435         (source_cache::get_source_lines): Move lower.
 436         * source-cache.h (class source_cache): Update comment.
 437         <get_line_charpos>: New method.
 438         <get_source_lines>: Update comment.
 439         <clear>: Clear m_offset_cache.
 440         <get_plain_source_lines>: Change parameters.
 441         <ensure>: New method
 442         <m_offset_cache>: New member.
 443         * source.c (forget_cached_source_info_for_objfile): Update.
 444         (info_source_command): Use g_source_cache.
 445         (find_source_lines, open_source_file_with_line_charpos): Remove.
 446         (print_source_lines_base, search_command_helper): Use g_source_cache.
 447         * source.h (open_source_file_with_line_charpos): Don't declare.
 448         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 449         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 450         Use g_source_cache.
 451
 452 2019-08-06  Tom Tromey  <tromey@adacore.com>
 453
 454         * source-cache.c (source_cache::get_plain_source_lines):
 455         Remove "first_line" and "last_line" parameters.
 456         (source_cache::get_source_lines): Cache plain text.
 457         * source-cache.h (class source_cache)
 458         <get_plain_source_lines>: Update.
 459
 460 2019-08-06  Tom Tromey  <tromey@adacore.com>
 461
 462         * source-cache.c (extract_lines): No longer a method.
 463         Changed type of parameter.  Include final newline.
 464         (selftests::extract_lines_test): New function.
 465         (_initialize_source_cache): Likewise.
 466         * source-cache.h (class source_cache)
 467         <extract_lines>: Don't declare.
 468
 469 2019-08-06  Tom Tromey  <tromey@adacore.com>
 470
 471         * breakpoint.c (init_breakpoint_sal): Update.
 472         (breakpoint): Update.
 473         * breakpoint.h (struct breakpoint) <filter>: Now a
 474         unique_xmalloc_ptr.
 475
 476 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 477
 478         * NEWS: Mention dictionary access on blocks.
 479         * python/py-block.c (blpy_getitem): New function.
 480         (block_object_as_mapping): New struct.
 481         (block_object_type): Use new struct for tp_as_mapping field.
 482
 483 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 484
 485         * objfiles.h (objfile): Add a comment describing partial symbols.
 486
 487 2019-08-05  Tom Tromey  <tromey@adacore.com>
 488
 489         * compile/compile.c (_initialize_compile): Use _(), not N_().
 490         * thread.c (_initialize_thread): Use _(), not N_().
 491         * stack.c (_initialize_stack): Use _(), not N_().
 492         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 493
 494 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 495
 496         * dwarf2read.c (struct dw2_symtab_iterator):
 497         <want_specific_block>: Remove.
 498         <block_index>: Change type to gdb::optional.
 499         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 500         change type of BLOCK_INDEX parameter to gdb::optional.
 501         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 502         (dw2_lookup_symbol): Don't pass argument for
 503         WANT_SPECIFIC_BLOCK.
 504         (dw2_expand_symtabs_for_function): Don't pass argument for
 505         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 506         (class dw2_debug_names_iterator)
 507         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 508         parameter, change BLOCK_INDEX type to gdb::optional.
 509         <m_want_specific_block>: Remove.
 510         <m_block_index>: Change type to gdb::optional.
 511         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 512         gdb::optional.  Re-write in function of gdb::optional.
 513         (dw2_debug_names_lookup_symbol): Don't pass argument for
 514         WANT_SPECIFIC_BLOCK.
 515         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 516         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 517         BLOCK_INDEX.
 518
 519 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 520
 521         * NEWS: Mention changes to "info sources" command.
 522
 523 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 524
 525         * symtab.c (filename_partial_match_opts): New struct type.
 526         (struct output_source_filename_data): New members
 527         regexp, c_regexp, partial_match.
 528         (output_source_filename): Use new members to decide to print file.
 529         (info_sources_option_defs): New variable.
 530         (make_info_sources_options_def_group, print_info_sources_header,
 531         info_sources_command_completer):
 532         New functions.
 533         (info_sources_command): Read new optional arguments.
 534         (_initialize_symtab): Update info sources help.
 535
 536 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 537
 538         * ada-lang.c (exception_support_info_v0): Renamed from...
 539         (default_exception_support_info): ... this.  Create new
 540         definition for v1.
 541         (ada_has_this_exception_support): Look up catch_handlers_sym.
 542         (ada_exception_support_info_sniffer): Try v0 after default.
 543
 544 2019-08-01  Tom Tromey  <tromey@adacore.com>
 545
 546         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 547         gdbarch.h.
 548
 549 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 550
 551         * s12z-tdep.c: Fix include path for s12z-opc.h.
 552
 553 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 554
 555         * NEWS: Require GNU make 3.82.
 556
 557 2019-07-16  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 560         declare.
 561
 562 2019-07-30  Tom Tromey  <tromey@adacore.com>
 563
 564         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 565
 566 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 567
 568         * printcmd.c (print_address_symbolic): Print negative offsets.
 569         (build_address_symbolic): Force signed arithmetic when computing
 570         offset.
 571
 572 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 573
 574         PR/24474: Add a function to lookup static variables.
 575         * NEWS: Mention this new function.
 576         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 577         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 578         * python/python.c (python_GdbMethods): Add new function.
 579
 580 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 581
 582         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 583         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 584         (objfpy_lookup_static_symbol): New function.
 585         (objfile_object_methods): Add new functions.
 586
 587 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 588
 589         * NEWS: Mention 'set|show print frame-info'.  Mention new
 590         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 591         backtrace argument.  Mention that python frame filtering code
 592         is now consistent with what 'backtrace' command prints.
 593
 594 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 595
 596         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 597         comments.
 598         (print_frame_info_auto, print_frame_info_source_line,
 599         print_frame_info_location, print_frame_info_source_and_location,
 600         print_frame_info_location_and_address, print_frame_info_short_location):
 601         New declarations.
 602         (struct frame_print_options): New member print_frame_info.
 603         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 604         * stack.h (get_user_print_what_frame_info): New declaration.
 605         (frame_show_address): New declaration.
 606         * stack.c (print_frame_arguments_choices): New value 'presence'.
 607         (print_frame_info_auto, print_frame_info_source_line,
 608         print_frame_info_location, print_frame_info_source_and_location,
 609         print_frame_info_location_and_address, print_frame_info_short_location,
 610         print_frame_info_choices, print_frame_info_print_what): New definitions.
 611         (print_frame_args): Only print dots for args if print frame-arguments
 612         is 'presence'.
 613         (frame_print_option_defs): New element for "frame-info".
 614         (get_user_print_what_frame_info): New function.
 615         (frame_show_address): Make non static.  Move comment to stack.h.
 616         (print_frame_info_to_print_what): New function.
 617         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 618         to decide what to print.
 619         (backtrace_command_1): Handle the new print_frame_arguments_presence
 620         value.
 621         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 622         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 623         (py_print_frame): In non-mi mode, use LOCATION as default for
 624         print_what, similarly to frame information printed directly by
 625         backtrace command. Handle frame-info user option in non MI mode.
 626
 627 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 628
 629         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 630         Add case for debugging 32-bit target on 64-bit host.  Revise
 631         comment.
 632
 633 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 634
 635         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 636         instead of find_function_entry_range_from_pc.
 637
 638 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 639
 640         * stack.c (find_frame_funname): Remove code which preferred
 641         minsym over symtab sym in "certain pathological cases".
 642
 643         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 644         parameter.  Change type of "do_demangle" to bool.
 645         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 646         Pass suitable "prefer_sym_over_minsym" flag to
 647         build_address_symbolic().  Don't output "+" for negative offsets.
 648         * printcmd.c (print_address_symbolic): Update invocation of
 649         build_address_symbolic to include a "prefer_sym_over_minsym"
 650         flag.
 651         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 652         Restrict cases in which use of minimal symbol is preferred to that
 653         of a found symbol.  Update comments.
 654
 655         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 656         for entry pc when entry pc is out of range for that FDE.
 657
 658 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 659
 660         PR gdb/24839:
 661         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 662         type.
 663
 664 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 665
 666         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 667         this function's Python signature.
 668
 669
 670 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 671
 672         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 673         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 674         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 675         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 676         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 677
 678
 679 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 680
 681         * h8300-tdep.c (h8300_register_name_common): New.
 682         h8300_register_name): Use h8300_register_name_common.
 683         (h8300s_register_name): Likewise.
 684         (h8300sx_register_name): Likewise.
 685         (h8300h_register_nam): New.
 686         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 687
 688
 689 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 690
 691         * arm-tdep.c (arm_skip_cmse_entry): New function.
 692         (arm_is_sgstubs_section): New function.
 693         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 694
 695 2019-07-22  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 698         Don't self-assign.
 699
 700 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 701
 702         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 703         type_print.
 704
 705 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 706
 707         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 708         so that GDB doesn't match any msymbols when searching in the
 709         TYPES_DOMAIN.
 710         (print_symbol_info): Print using typedef_print or type_print based
 711         on the type of the symbol.  Add updated FIXME comment moved from...
 712         (_initialize_symtab): ... move and update FIXME comment to above.
 713
 714 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 715
 716         * NEWS: Mention adding -q option to "info types".
 717         * symtab.c (struct info_types_options): New struct.
 718         (info_types_options_defs): New variable.
 719         (make_info_types_options_def_group): New function.
 720         (info_types_command): Use gdb::option framework to parse options.
 721         (info_types_command_completer): New function.
 722         (_initialize_symtab): Extend the help text on "info types" and
 723         register command completer.
 724
 725 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 726
 727         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 728         (lookup_symbol_in_objfile): Change int to block_enum and add a
 729         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 730
 731 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 732
 733         * MAINTAINERS (Write After Approval): Add self.
 734
 735 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 736
 737         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 738         instruction to the dummy code region.
 739
 740 2019-07-19  Tom Tromey  <tromey@adacore.com>
 741
 742         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 743         (ARGSUSED, PARAMS, __func__): Remove rules.
 744
 745 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 746
 747         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 748         * features/arm/arm-with-iwmmxt.c: Remove.
 749         * features/arm/arm-with-iwmmxt.xml: Remove.
 750         * features/arm/arm-with-m-fpa-layout.c: Remove.
 751         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 752         * features/arm/arm-with-m-vfp-d16.c: Remove.
 753         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 754         * features/arm/arm-with-m.c: Remove.
 755         * features/arm/arm-with-m.xml: Remove.
 756         * features/arm/arm-with-neon.c: Remove.
 757         * features/arm/arm-with-neon.xml: Remove.
 758         * features/arm/arm-with-vfpv2.c: Remove.
 759         * features/arm/arm-with-vfpv2.xml: Remove.
 760         * features/arm/arm-with-vfpv3.c: Remove.
 761         * features/arm/arm-with-vfpv3.xml: Remove.
 762
 763 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 764
 765         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 766
 767 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 768
 769         * arch/aarch32.c (aarch32_create_target_description): Create
 770         target descriptions using features.
 771         * arch/arm.c (arm_create_target_description)
 772         (arm_create_mprofile_target_description): Likewise.
 773         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 774
 775 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 776
 777         * Makefile.in: Add new files.
 778         * aarch32-tdep.c: New file.
 779         * aarch32-tdep.h: New file.
 780         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 781         Call aarch32_read_description.
 782         * arch/aarch32.c: New file.
 783         * arch/aarch32.h: New file.
 784         * arch/arm.c (arm_create_target_description)
 785         (arm_create_mprofile_target_description): New function.
 786         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 787         (arm_create_target_description)
 788         (arm_create_mprofile_target_description): New declaration.
 789         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 790         read_description functions.
 791         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 792         Likewise.
 793         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 794         * arm-tdep.c (tdesc_arm_list): New variable.
 795         (arm_register_g_packet_guesses): Call create description functions.
 796         (arm_read_description) (arm_read_mprofile_description): New
 797         function.
 798         * arm-tdep.h (arm_read_description)
 799         (arm_read_mprofile_description): Add declaration.
 800         * configure.tgt: Add new files.
 801
 802 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 803
 804         * top.c (new_ui_command): Open specified terminal just once.
 805
 806 2019-07-18  Tom Tromey  <tromey@adacore.com>
 807
 808         * symtab.c (main_name): Constify return type.
 809         * symfile.c (set_initial_language): Update.
 810         * symtab.h (main_name): Constify return type.
 811
 812 2019-07-17  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-winsource.c (tui_update_source_window)
 815         (tui_update_source_window_as_is)
 816         (tui_update_source_windows_with_line): Remove return.
 817         * tui/tui-disasm.c (tui_show_disassem)
 818         (tui_show_disassem_and_update_source): Remove return.
 819         * tui/tui.c (tui_reset): Remove return.
 820         * tui/tui-wingeneral.c
 821         (tui_check_and_display_highlight_if_needed): Remove return.
 822
 823 2019-07-17  Tom Tromey  <tom@tromey.com>
 824
 825         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 826
 827 2019-07-17  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-winsource.h (struct tui_exec_info_window)
 830         (struct tui_source_window_base): Move from tui-data.h.
 831         * tui/tui-winsource.c: Move many method definitions from
 832         elsewhere.  Remove "structuring" comments.
 833         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 834         (tui_source_window_base::refresh_window): Move to
 835         tui-winsource.c.
 836         * tui/tui-win.c (tui_source_window_base::refresh_all)
 837         (tui_source_window_base::update_tab_width)
 838         (tui_source_window_base::set_new_height)
 839         (tui_source_window_base::do_make_visible_with_new_height): Move to
 840         tui-winsource.c.
 841         * tui/tui-source.h: Update.
 842         * tui/tui-source.c (tui_source_window_base::reset): Move to
 843         tui-winsource.c.
 844         * tui/tui-disasm.h: Update.
 845         * tui/tui-data.h (struct tui_exec_info_window): Move to
 846         tui-winsource.h.
 847         (struct tui_source_window_base): Likewise.
 848         * tui/tui-data.c (tui_source_window_base::clear_detail)
 849         (tui_source_window_base, ~tui_source_window_base): Move to
 850         tui-winsource.c.
 851
 852 2019-07-17  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-win.c (tui_resize_all)
 855         (tui_source_window_base::update_tab_width)
 856         (tui_adjust_win_heights): Update.
 857         (tui_win_info::make_invisible_and_set_new_height): Rename from
 858         make_invisible_and_set_new_height.
 859         * tui/tui-data.h (struct tui_win_info)
 860         <make_invisible_and_set_new_height>: New method.
 861
 862 2019-07-17  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui.c: Update.
 865         * tui/tui-source.h (struct tui_source_window): Move from
 866         tui-data.h.
 867         * tui/tui-layout.c: Update.
 868         * tui/tui-disasm.c: Update.
 869         * tui/tui-data.h (struct tui_source_window): Move to
 870         tui-source.h.
 871
 872 2019-07-17  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 875         tui-data.h.
 876         * tui/tui-data.h (struct tui_disasm_window): Move to
 877         tui-disasm.h.
 878
 879 2019-07-17  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-regs.h (struct tui_data_item_window): Move from
 882         tui-data.h.
 883         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 884         * tui/tui-data.h (struct tui_data_item_window): Move to
 885         tui-regs.h.
 886         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 887
 888 2019-07-17  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui.c: Update.
 891         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 892         (tui_cmd_window::max_height): Move to tui-command.c.
 893         * tui/tui-layout.c: Update.
 894         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 895         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 896         tui-command.c.
 897         * tui/tui-command.h (struct tui_cmd_window): Move from
 898         tui-data.h.
 899         * tui/tui-command.c: Remove "structuring" comments.
 900         (tui_cmd_window::clear_detail)
 901         (tui_cmd_window::do_make_visible_with_new_height)
 902         (tui_cmd_window::max_height): Move from elsewhere.
 903
 904 2019-07-17  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 907         Now static.
 908         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 909         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 910
 911 2019-07-17  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui.c: Update.
 914         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 915         tui-regs.c.
 916         * tui/tui-windata.h: Remove file.
 917         * tui/tui-windata.c: Remove file.
 918         * tui/tui-win.c (tui_data_window::set_new_height)
 919         (tui_data_window::do_make_visible_with_new_height): Move to
 920         tui-regs.c.
 921         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 922         * tui/tui-regs.c: Remove "structuring" comments.
 923         (tui_data_window::first_data_item_displayed)
 924         (tui_data_window::delete_data_content_windows)
 925         (tui_data_window::erase_data_content)
 926         (tui_data_window::display_all_data)
 927         (tui_data_window::refresh_all)
 928         (tui_data_window::do_scroll_vertical)
 929         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 930         (tui_data_window::do_make_visible_with_new_height)
 931         (tui_data_window::refresh_window): Move from elsewhere.
 932         (_initialize_tui_regs): Move to end of file.
 933         * tui/tui-layout.c: Update.
 934         * tui/tui-hooks.c: Update.
 935         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 936         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 937         tui-regs.c.
 938         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 939
 940 2019-07-17  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 943         seen.
 944
 945 2019-07-17  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-win.c (tui_source_window_base::set_new_height)
 948         (tui_source_window_base::do_make_visible_with_new_height): Use
 949         m_has_locator field directly.
 950         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 951         method.
 952         (struct tui_source_window_base) <has_locator>: Likewise.
 953
 954 2019-07-17  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 957         Don't declare.
 958         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 959         Remove.
 960         * tui/tui-win.c (tui_source_window_base::set_new_height)
 961         (tui_source_window_base::set_new_height)
 962         (make_invisible_and_set_new_height)
 963         (tui_source_window_base::do_make_visible_with_new_height)
 964         (tui_source_window_base::do_make_visible_with_new_height):
 965         Update.
 966         * tui/tui-layout.c (show_source_disasm_command, show_data)
 967         (show_source_or_disasm_and_command): Update.
 968         * tui/tui-layout.c (show_layout): Update.
 969
 970 2019-07-17  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-layout.c (make_data_window): Remove.
 973         (show_data): Unify creation and re-initialization cases.
 974
 975 2019-07-17  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-layout.c (make_source_window, make_disasm_window):
 978         Remove.
 979         (show_data): Unify creation and re-initialization cases.
 980
 981 2019-07-17  Tom Tromey  <tom@tromey.com>
 982
 983         * tui/tui-layout.c (make_command_window): Remove.
 984         (show_source_disasm_command, show_source_or_disasm_and_command):
 985         Unify creation and re-initialization cases.
 986
 987 2019-07-17  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 990         creation and re-initialization cases.
 991
 992 2019-07-17  Tom Tromey  <tom@tromey.com>
 993
 994         * tui/tui-regs.c (tui_get_register): Return void.
 995
 996 2019-07-17  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 999         Simplify.
1000
1001 2019-07-17  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1004         resetting.
1005
1006 2019-07-17  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1009         * tui/tui-regs.c (tui_reg_layout): New function.
1010         (tui_show_registers, tui_reg_command): Use it.
1011         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1012         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1013         parameters.
1014         (tui_layout_command): Remove.
1015
1016 2019-07-17  Tom Tromey  <tom@tromey.com>
1017
1018         * tui/tui-layout.h (tui/tui-layout): Return void.
1019         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1020
1021 2019-07-17  Tom Tromey  <tom@tromey.com>
1022
1023         * tui/tui-layout.c (show_source_disasm_command, show_data):
1024         Update.
1025         (reset_locator): Remove.
1026         (show_source_or_disasm_and_command): Update.
1027
1028 2019-07-17  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-source.c (tui_source_window_base::reset): Remove
1031         win_type parameter.
1032         * tui/tui-layout.c (make_command_window, make_source_window)
1033         (make_disasm_window, make_data_window)
1034         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1035         (reset_locator, show_source_or_disasm_and_command): Update.
1036         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1037         win_type parameter.
1038         (struct tui_source_window_base) <reset>: Likewise.
1039
1040 2019-07-17  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-layout.c (show_source_disasm_command): Use
1043         reset_locator.
1044         (reset_locator): New function.
1045         (init_and_make_win): Remove.
1046         (show_source_or_disasm_and_command): Use reset_locator.
1047
1048 2019-07-17  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1051         condition.
1052         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1053         Remove condition.
1054         * tui/tui-source.c (tui_source_window_base::reset): New method.
1055         * tui/tui-layout.c (make_command_window): Don't call
1056         init_and_make_win.
1057         (make_source_window, make_disasm_window): Don't call
1058         make_source_or_disasm_window.
1059         (make_data_window): Don't call init_and_make_win.  Change calling
1060         convention.
1061         (show_source_disasm_command, show_data): Simplify.
1062         (make_source_or_disasm_window): Remove.
1063         (show_source_or_disasm_and_command): Simplify.
1064         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1065         (struct tui_source_window_base) <reset>: Likewise.
1066         <execution_info>: Remove initializer.
1067         * tui/tui-data.c (tui_source_window_base): Initialize
1068         execution_info.
1069
1070 2019-07-17  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1073         variable.
1074
1075 2019-07-17  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui.c (tui_rl_other_window): Update.
1078         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1079         superclass method first.  Always iterate over regs_content.
1080         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1081         method.
1082         * tui/tui-win.c (tui_set_focus_command): Update.
1083
1084 2019-07-17  Tom Tromey  <tom@tromey.com>
1085
1086         * tui/tui-win.c (tui_set_focus_command): Rename from
1087         tui_set_focus.  Call tui_enable.
1088         (tui_set_focus_command): Remove.
1089
1090 2019-07-17  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1093         refresh_window.
1094         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1095         touchwin.
1096         (tui_data_window::refresh_window): Call refresh_window on data
1097         items.  Always call superclass refresh_window.
1098         (tui_win_info::refresh): Remove.
1099         (tui_source_window_base::refresh_window): Update.
1100         (tui_refresh_all): Update.
1101         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1102         refresh_window.
1103         (show_source_or_disasm_and_command): Likewise.
1104         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1105         (struct tui_source_window_base) <refresh>: Likewise.
1106
1107 2019-07-17  Tom Tromey  <tom@tromey.com>
1108
1109         * tui/tui-winsource.c (tui_clear_source_content)
1110         (tui_show_source_content): Update.
1111         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1112         whether content is empty.
1113         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1114         Remove.
1115
1116 2019-07-17  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1119         window's contents.
1120         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1121         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1122
1123 2019-07-17  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1126         (struct tui_data_item_window): Update.
1127
1128 2019-07-17  Tom Tromey  <tom@tromey.com>
1129
1130         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1131         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1132         defines.
1133
1134 2019-07-17  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-winsource.h (tui_erase_source_content)
1137         (tui_clear_source_content): Remove "display_prompt" parameter.
1138         * tui/tui-winsource.c (tui_update_source_window_as_is)
1139         (tui_update_source_windows_with_addr): Update.
1140         (tui_clear_source_content): Remove "display_prompt" parameter.
1141         (tui_erase_source_content): Likewise.  Simplify.
1142         (tui_show_source_content): Update.
1143         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1144         * tui/tui-stack.c (tui_show_frame_info): Update.
1145         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1146         Remove defines.
1147
1148 2019-07-17  Tom Tromey  <tom@tromey.com>
1149
1150         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1151         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1152         parameter.
1153         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1154         parameter.
1155
1156 2019-07-17  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-winsource.c (tui_clear_source_content)
1159         (tui_show_source_content, tui_show_exec_info_content)
1160         (tui_clear_exec_info_content): Update.
1161         * tui/tui-stack.c (tui_show_locator_content): Update.
1162         (tui_show_frame_info): Update.
1163         * tui/tui-source.h (tui_source_window): Don't declare.
1164         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1165         from tui_source_is_displayed.
1166         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1167         Remove field.
1168         (struct tui_source_window_base) <content_in_use>: New field.  Now
1169         bool.
1170         (struct tui_source_window) <showing_source_p>: New method.
1171         (TUI_SRC_WIN): Change cast.
1172         * tui/tui-data.c (tui_initialize_static_data): Update.
1173
1174 2019-07-17  Tom Tromey  <tom@tromey.com>
1175
1176         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1177         location_matches_p.
1178         * tui/tui-source.c (tui_source_window::location_matches_p): New
1179         method.
1180         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1181         method.
1182         * tui/tui-data.h (struct tui_source_window_base)
1183         <location_matches_p>: New method.
1184         (struct tui_source_window, struct tui_disasm_window)
1185         <location_matches_p>: Likewise.
1186
1187 2019-07-17  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui-win.c (tui_set_win_height_command): Rename from
1190         tui_set_win_height.
1191         (tui_set_win_height_command): Remove.
1192
1193 2019-07-17  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-source.c (tui_source_window): New constructor.  Add
1196         observer.
1197         (~tui_source_window): New destructor.
1198         (tui_source_window::style_changed): New method.
1199         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1200         (tui_attach_detach_observers): Update.
1201         * tui/tui-data.h (struct tui_source_window): Make constructor not
1202         inline.  Add destructor.
1203         (struct tui_source_window) <style_changed>: New method.
1204         <m_observable>: New member.
1205
1206 2019-07-17  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1209         * tui/tui-win.c (tui_resize_all): Fix typo.
1210
1211 2019-07-17  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1214         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1215         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1216         * tui/tui-win.c (window_name_completer): Use foreach.
1217         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1218         (update_tab_width): Likewise.
1219         * tui/tui-layout.c (show_layout): Update.
1220         * tui/tui-data.h (class tui_window_iterator): New.
1221         (struct all_tui_windows): New.
1222         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1223
1224 2019-07-17  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1227         parameter.  Don't reference globals.
1228         (tui_reg_command): Update.
1229
1230 2019-07-17  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-regs.c (tui_show_registers): Simplify.
1233
1234 2019-07-17  Tom Tromey  <tom@tromey.com>
1235
1236         * tui/tui-regs.c (tui_show_registers): Update.
1237         (tui_show_register_group): Add win_info parameter.
1238
1239 2019-07-17  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1242         Rename from tui_display_reg_element_at_line.
1243         (tui_data_window::display_registers_from_line): Update.
1244         * tui/tui-data.h (struct tui_data_window)
1245         <display_reg_element_at_line>: New method.
1246
1247 2019-07-17  Tom Tromey  <tom@tromey.com>
1248
1249         * tui/tui-regs.h (tui_display_registers_from)
1250         (tui_display_registers_from_line): Don't declare.
1251         * tui/tui-windata.c (tui_data_window::display_all_data)
1252         (tui_data_window::refresh_all)
1253         (tui_data_window::do_scroll_vertical): Update.
1254         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1255         from tui_display_registers_from.
1256         (tui_display_reg_element_at_line): Update.
1257         (tui_data_window::display_registers_from_line): Rename from
1258         tui_display_registers_from_line.
1259         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1260         display_registers_from_line>: New methods.
1261
1262 2019-07-17  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1265         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1266         from tui_erase_data_content.
1267         (tui_data_window::display_all_data)
1268         (tui_data_window::refresh_all)
1269         (tui_data_window::do_scroll_vertical): Update.
1270         * tui/tui-regs.c (tui_show_registers): Update.
1271         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1272         New method.
1273
1274 2019-07-17  Tom Tromey  <tom@tromey.com>
1275
1276         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1277         declare.
1278         * tui/tui-windata.c
1279         (tui_data_window::delete_data_content_windows): Rename from
1280         tui_delete_data_content_windows.
1281         (tui_data_window::display_all_data)
1282         (tui_data_window::do_scroll_vertical): Update.
1283         * tui/tui-data.h (struct tui_data_window)
1284         <delete_data_content_windows>: New method.
1285
1286 2019-07-17  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1289         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1290
1291 2019-07-17  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1294         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1295         from tui_display_all_data.
1296         * tui/tui-win.c
1297         (tui_data_window::do_make_visible_with_new_height): Update.
1298         * tui/tui-regs.c (tui_show_registers): Update.
1299         * tui/tui-layout.c (tui_set_layout): Update.
1300         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1301         method.
1302
1303 2019-07-17  Tom Tromey  <tom@tromey.com>
1304
1305         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1306         * tui/tui-windata.c (tui_display_data_from): Remove.
1307         (tui_data_window::refresh_all): Update.
1308
1309 2019-07-17  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1312         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1313         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1314         tui_display_registers_from_line.
1315         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1316         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1317         "force_display" parameter.
1318
1319 2019-07-17  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1322         declare.
1323         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1324         Rename from tui_first_reg_element_no_inline.
1325         (tui_display_reg_element_at_line)
1326         (tui_display_registers_from_line): Update.
1327         * tui/tui-data.h (struct tui_data_window)
1328         <first_reg_element_no_inline>: New method.
1329
1330 2019-07-17  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-windata.c (tui_display_data_from)
1333         (tui_data_window::do_scroll_vertical): Update.
1334         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1335         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1336         Rename from tui_line_from_reg_element_no.
1337         (tui_display_registers_from_line): Update.
1338         * tui/tui-data.h (struct tui_data_window)
1339         <line_from_reg_element_no>: New method.
1340
1341 2019-07-17  Tom Tromey  <tom@tromey.com>
1342
1343         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1344         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1345         tui_last_regs_line_no.
1346         (tui_display_reg_element_at_line)
1347         (tui_display_registers_from_line): Update.
1348         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1349         method.
1350
1351 2019-07-17  Tom Tromey  <tom@tromey.com>
1352
1353         PR tui/24722:
1354         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1355         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1356         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1357         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1358         (tui_update_breakpoint_info): Likewise.
1359         * tui/tui-hooks.c (tui_event_create_breakpoint)
1360         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1361         Update.
1362
1363 2019-07-17  Tom Tromey  <tom@tromey.com>
1364
1365         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1366
1367 2019-07-17  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-winsource.c (tui_update_source_window_as_is)
1370         (tui_update_source_windows_with_addr): Update.
1371         * tui/tui-source.h (tui_set_source_content)
1372         (tui_show_symtab_source): Add "win_info" parameter.
1373         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1374         parameter.
1375         (tui_show_symtab_source): Likewise.
1376
1377 2019-07-17  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-wingeneral.c
1380         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1381
1382 2019-07-17  Tom Tromey  <tom@tromey.com>
1383
1384         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1385         (struct tui_cmd_window) <can_scroll>: New method.
1386         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1387         method.
1388
1389 2019-07-17  Tom Tromey  <tromey@adacore.com>
1390
1391         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1392         do_field_signed>: Rename.  Change type of "value".
1393         * ui-out.c (ui_out::field_signed): Rename from field_int.
1394         Change type of "value".
1395         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1396         type of "value".
1397         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1398         do_field_int.  Change type of "value".
1399         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1400         do_field_int.  Change type of "value".
1401         * tracepoint.c (trace_status_mi, tfind_1)
1402         (print_one_static_tracepoint_marker): Update.
1403         * thread.c (print_thread_info_1, print_selected_thread_frame):
1404         Update.
1405         * stack.c (print_frame, print_frame_info): Update.
1406         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1407         Update.
1408         * source.c (print_source_lines_base): Update.
1409         * skip.c (info_skip_command): Update.
1410         * record-btrace.c (btrace_ui_out_decode_error)
1411         (btrace_call_history_src_line): Update.
1412         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1413         Update.
1414         * progspace.c (print_program_space): Update.
1415         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1416         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1417         do_field_int.  Change type of "value".
1418         * mi/mi-out.c (mi_ui_out::do_table_begin)
1419         (mi_ui_out::do_table_header): Update.
1420         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1421         type of "value".
1422         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1423         (mi_cmd_data_list_changed_registers, output_register)
1424         (mi_cmd_data_read_memory, mi_load_progress)
1425         (mi_cmd_trace_frame_collected): Update.
1426         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1427         Update.
1428         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1429         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1430         (mi_cmd_var_list_children, varobj_update_one): Update.
1431         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1432         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1433         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1434         * inferior.c (print_inferior): Update.
1435         * gdb_bfd.c (print_one_bfd): Update.
1436         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1437         Update.
1438         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1439         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1440         do_field_int.  Change type of "value".
1441         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1442         do_field_int.  Change type of "value".
1443         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1444         (print_one_breakpoint_location, print_it_catch_fork)
1445         (print_one_catch_fork, print_it_catch_vfork)
1446         (print_one_catch_vfork, print_it_catch_solib)
1447         (print_it_catch_exec, print_it_ranged_breakpoint)
1448         (print_mention_watchpoint, print_mention_masked_watchpoint)
1449         (bkpt_print_it, update_static_tracepoint): Update.
1450         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1451         * break-catch-syscall.c (print_it_catch_syscall): Update.
1452         * ada-tasks.c (print_ada_task_info): Update.
1453         * ada-lang.c (print_it_exception, print_mention_exception):
1454         Update.
1455
1456 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1457
1458         PR breakpoints/24541
1459         * gdbarch.c: Regenerate.
1460         * gdbarch.h: Regenerate.
1461         * gdbarch.sh: Adjust return type and parameter types for
1462         'stap_adjust_register'.
1463         (i386_stap_adjust_register): Adjust signature and return new
1464         register name.
1465         * stap-probe.c (stap_parse_register_operand): Adjust use of
1466         'gdbarch_stap_adjust_register'.
1467
1468 2019-07-17  Tom Tromey  <tromey@adacore.com>
1469
1470         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1471         declare VEC.
1472         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1473         std::vector.
1474         (struct s390_process_info): Add initializers.
1475         (s390_add_process): Use new.
1476         (s390_linux_nat_target::low_forget_process): Use delete.
1477         (s390_linux_nat_target::low_new_fork)
1478         (s390_linux_nat_target::stopped_by_watchpoint)
1479         (s390_linux_nat_target::low_prepare_to_resume)
1480         (s390_linux_nat_target::insert_watchpoint)
1481         (s390_linux_nat_target::insert_hw_breakpoint)
1482         (s390_linux_nat_target::remove_watchpoint)
1483         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1484
1485 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1486
1487         * aarch64-fbsd-nat.c: Include regcache.h.
1488         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1489         argument.
1490         (aarch64_fbsd_nat_target::fetch_registers)
1491         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1492         variable.
1493         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1494
1495 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1496
1497         * fbsd-nat.c: Include gdbarch.h.
1498
1499 2019-07-15  Tom Tromey  <tromey@adacore.com>
1500
1501         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1502
1503 2019-07-15  Tom Tromey  <tromey@adacore.com>
1504
1505         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1506         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1507         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1508         * cli-out.c (cli_ui_out::do_field_int): New method.
1509         * ui-out.c (ui_out::field_unsigned): New method.
1510         * symfile.c (generic_load): Use field_unsigned.
1511         (print_transfer_performance): Likewise.
1512         * record-btrace.c (ui_out_field_uint): Remove.
1513         (btrace_call_history_insn_range, btrace_call_history): Use
1514         field_unsigned.
1515         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1516         field_unsigned.
1517         * ui-out.h (class ui_out) <field_unsigned>: New method.
1518         <do_field_unsigned>: Likewise.
1519
1520 2019-07-15  Tom Tromey  <tromey@adacore.com>
1521
1522         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1523         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1524         * target.c (flash_erase_command): Use field_string.
1525         * infrun.c (print_signal_received_reason): Use field_string.
1526         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1527         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1528         field_string.
1529         * ada-tasks.c (print_ada_task_info): Use field_string.
1530
1531 2019-07-15  Tom Tromey  <tromey@adacore.com>
1532
1533         * target.c (flash_erase_command): Use field_core_addr.
1534         * symfile.c (generic_load): Use field_core_addr.
1535         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1536         Use field_core_addr.
1537         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1538         field_core_addr.
1539
1540 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1543         value if its desired type is smaller than a CORE_ADDR and signed.
1544
1545 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1546
1547         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1548         of changes to field names, and use new is_reference field to
1549         decide if a property is a reference or not.
1550         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1551         field.
1552         (struct dwarf2_property_baton): Update header comment, rename
1553         'referenced_type' to 'property_type' and update comments.
1554         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1555         default property type, store in property baton, update to take
1556         accound of renamed field.
1557         (read_func_scope): Update call to attr_to_dynamic_prop.
1558         (read_array_type): Likewise.
1559         (dwarf2_per_cu_addr_sized_int_type): New function.
1560         (read_subrange_index_type): Move type finding code to
1561         dwarf2_per_cu_addr_sized_int_type.
1562         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1563         (dwarf2_per_cu_addr_type): New function.
1564         (set_die_type): Update calls to attr_to_dynamic_prop.
1565
1566 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1567
1568         * dwarf2read.c (read_subrange_index_type): New function.
1569         (read_subrange_type): Move code into new function and call it.
1570         * gdbtypes.c (create_range_type): Add some asserts.
1571
1572 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1575         update return statements.
1576         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1577         declaration, and update comment to match.
1578         * gdbtypes.c (resolve_dynamic_array): Update call to
1579         dwarf2_evaluate_property to match new return type.
1580
1581 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1582
1583         * valarith.c (value_subscripted_rvalue): Change lowerbound
1584         parameter type from int to LONGEST.
1585         * value.h (value_subscripted_rvalue): Likewise in declaration.
1586
1587 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1588
1589         * cli/cli-utils.c (info_print_command_completer): New function.
1590         * cli/cli-utils.h: Add 'completer.h' include, and forward
1591         declaration for 'struct cmd_list_element'.
1592         (info_print_command_completer): Declare.
1593         * stack.c (_initialize_stack): Add completer for 'info locals' and
1594         'info args'.
1595         * symtab.c (_initialize_symtab): Add completer for 'info
1596         variables' and 'info functions'.
1597         * NEWS: Mention completion for additional info commands.
1598
1599 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1600
1601         * cli/cli-utils.c (extract_info_print_args): Delete.
1602         (extract_arg_maybe_quoted): Delete.
1603         (info_print_options_defs): New variable.
1604         (make_info_print_options_def_group): New function.
1605         (extract_info_print_options): Define new function.
1606         * cli/cli-utils.h (extract_info_print_args): Delete.
1607         (struct info_print_options): New structure.
1608         (extract_info_print_options): Declare new function.
1609         * stack.c (info_locals_command): Update to use new
1610         extract_info_print_options, also add a header comment.
1611         (info_args_command): Likewise.
1612         * symtab.c (info_variables_command): Likewise.
1613         (info_functions_command): Likewise.
1614
1615 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1618         to extract string arguments.
1619         * common/common-utils.c (extract_string_maybe_quoted): New function.
1620         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1621
1622 2019-07-11  Tom Tromey  <tromey@adacore.com>
1623
1624         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1625         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1626         * top.h (gdbinit): Don't declare.
1627         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1628         into...
1629         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1630         * top.c (gdb_init): Don't call init_cli_cmds.
1631         (gdbinit): Remove.
1632         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1633
1634 2019-07-11  Tom Tromey  <tromey@adacore.com>
1635
1636         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1637         after it has been moved.
1638
1639 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1640
1641         * valops.c (value_must_coerce_to_target): Change return type to
1642         bool.
1643         * value.h (value_must_coerce_to_target): Likewise.
1644
1645 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1646
1647         * breakpoint.c (is_hardware_watchpoint): Remove
1648         forward-declaration.
1649         (is_masked_watchpoint): Change return type to bool.
1650         (is_tracepoint): Likewise.
1651         (is_breakpoint): Likewise.
1652         (is_hardware_watchpoint): Likewise.
1653         (is_watchpoint): Likewise.
1654         (is_no_memory_software_watchpoint): Likewise.
1655         (is_catchpoint): Likewise.
1656         (breakpoint_1): Make FILTER parameter's return type bool.
1657         is_masked_watchpoint): Change return type to bool.
1658         (save_breakpoints): Make FILTER parameter's return type bool.
1659         * breakpoint.h (is_breakpoint): Change return type to bool.
1660         (is_watchpoint): Likewise.
1661         (is_catchpoint): Likewise.
1662         (is_tracepoint): Likewise.
1663
1664 2019-07-10  Tom Tromey  <tom@tromey.com>
1665
1666         * defs.h: Don't include gdbarch.h.
1667         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1668         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1669         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1670         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1671         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1672         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1673         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1674         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1675         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1676         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1677         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1678         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1679         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1680         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1681         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1682         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1683         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1684         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1685         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1686         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1687         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1688         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1689         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1690         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1691         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1692         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1693         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1694
1695 2019-07-10  Tom Tromey  <tromey@adacore.com>
1696
1697         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1698         * breakpoint.c (init_ada_exception_breakpoint): Register as
1699         bp_catchpoint.
1700         (print_one_breakpoint_location, print_one_breakpoint): Use
1701         is_ada_exception_catchpoint.
1702         * ada-lang.c (class ada_catchpoint_location): Pass
1703         bp_loc_software_breakpoint to bp_location constructor.
1704         (is_ada_exception_catchpoint): New function.
1705
1706 2019-07-10  Tom Tromey  <tromey@adacore.com>
1707
1708         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1709         VEC.
1710         (struct arm_exidx_entry): New method operator<.
1711         (struct arm_exidx_data) <section_maps>: Change type.
1712         (arm_exidx_data_free): Remove.
1713         (arm_exidx_data_key): Change type.  Move lower.
1714         (arm_exidx_new_objfile): Update.
1715         (arm_compare_exidx_entries): Remove.
1716         (arm_find_exidx_entry, _initialize_arm_tdep)
1717
1718 2019-07-10  Tom Tromey  <tromey@adacore.com>
1719
1720         * solib-spu.c (ocl_program_data_key): Change type.
1721         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1722         Update.
1723
1724 2019-07-10  Tom Tromey  <tromey@adacore.com>
1725
1726         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1727         (struct solib_aix_inferior_data) <library_list>: Change type.
1728         (solib_aix_inferior_data_handle): Change type.
1729         (get_solib_aix_inferior_data): Update.
1730         (solib_aix_free_library_list): Remove.
1731         (library_list_start_library): Update.
1732         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1733         return type.
1734         (solib_aix_get_library_list)
1735         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1736         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1737
1738 2019-07-10  Tom Tromey  <tromey@adacore.com>
1739
1740         * solib-dsbt.c (struct dsbt_info): Add initializers.
1741         (solib_dsbt_pspace_data): Change type.
1742         (dsbt_pspace_data_cleanup): Remove.
1743         (get_dsbt_info, _initialize_dsbt_solib): Update.
1744
1745 2019-07-10  Tom Tromey  <tromey@adacore.com>
1746
1747         * spu-tdep.c (spu_overlay_data): Change type.
1748         (spu_get_overlay_table, spu_overlay_new_objfile)
1749         (_initialize_spu_tdep): Update.
1750
1751 2019-07-10  Tom Tromey  <tromey@adacore.com>
1752
1753         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1754         destructor.
1755         (dbx_objfile_data_key): Change type and declare later.
1756         (DBX_SYMFILE_INFO): Rewrite.
1757         * dbxread.c (dbx_objfile_data_key): Change type.
1758         (dbx_symfile_init): Update.
1759         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1760         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1761         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1762
1763 2019-07-10  Tom Tromey  <tromey@adacore.com>
1764
1765         * jit.c (jit_program_space_key): Change type.  Move lower.
1766         (get_jit_program_space_data): Update.
1767         (jit_program_space_data_cleanup): Remove.
1768         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1769         Update.
1770         (struct jit_program_space_data): Add initializers.
1771
1772 2019-07-10  Tom Tromey  <tromey@adacore.com>
1773
1774         * solib-darwin.c (struct darwin_info): Add initializers.
1775         (solib_darwin_pspace_data): Change type.
1776         (darwin_pspace_data_cleanup): Remove.
1777         (get_darwin_info, _initialize_darwin_solib): Update.
1778
1779 2019-07-10  Tom Tromey  <tromey@adacore.com>
1780
1781         * remote-sim.c (struct sim_inferior_data): Add initializers,
1782         constructor, and destructor.
1783         (sim_inferior_data_key): Change type.  Move lower.
1784         (check_for_duplicate_sim_descriptor): Update.
1785         (get_sim_inferior_data): Use new.  Update.
1786         (~sim_inferior_data_cleanup): Rename from
1787         sim_inferior_data_cleanup.  Simplify.
1788         (gdbsim_close_inferior, simulator_command)
1789         (sim_command_completer, _initialize_remote_sim): Update.
1790         (next_pid, INITIAL_PID): Move earlier.
1791
1792 2019-07-10  Tom Tromey  <tromey@adacore.com>
1793
1794         * python/python-internal.h (create_thread_object): Return
1795         gdbpy_ref.
1796         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1797         * python/py-inferior.c (struct threadlist_entry): Add
1798         constructor.
1799         <thread_obj>: Now a gdbpy_ref.
1800         (thread_to_thread_object): Update.
1801         (add_thread_object): Use new.
1802         (delete_thread_object): Use delete.
1803         (infpy_threads): Update.
1804         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1805         GIL.
1806
1807 2019-07-10  Tom Tromey  <tromey@adacore.com>
1808
1809         * valops.c (value_cast): Specialize error message for Ada.
1810
1811 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1812
1813         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1814
1815 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1816
1817         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1818         bpstat_should_step): Return bool, adjust comments.
1819         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1820         bpstat_should_step): Likewise.
1821
1822 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1823
1824         * features/Makefile: Use feature target descriptions for Arm.
1825         * features/arm/arm-core.c: Generate new file.
1826         * features/arm/arm-fpa.c: Likewise.
1827         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1828         * features/arm/arm-m-profile.c: Likewise.
1829         * features/arm/arm-vfpv2.c: Likewise.
1830         * features/arm/arm-vfpv3.c: Likewise.
1831         * features/arm/xscale-iwmmxt.c: Likewise.
1832         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1833
1834 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1835
1836         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1837         ptrace earlier.
1838
1839 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1840
1841         * features/aarch64-pauth.c: Regenerate.
1842
1843 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1844
1845         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1846         bool.
1847         (bpstat_what): Use false instead of 0.
1848
1849 2019-07-09  Pedro Alves  <palves@redhat.com>
1850
1851         * break-catch-throw.c (is_exception_catchpoint): New.
1852         * breakpoint.c (print_one_breakpoint_location): New parameter
1853         'raw_loc'.  Handle it.  Use
1854         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1855         looking at the breakpoint's type.
1856         (print_one_breakpoint): If handling "maint info breakpoints", also
1857         print locations of exception catchpoints.
1858         * breakpoint.h (is_exception_catchpoint): Declare.
1859
1860 2019-07-09  Pedro Alves  <palves@redhat.com>
1861
1862         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1863         "addr" field.
1864         (allocate_location_exception_catchpoint): New.
1865         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1866         (initialize_throw_catchpoint_ops): Install
1867         allocate_location_exception_catchpoint as allocate_location
1868         method.
1869         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1870         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1871         bp_loc_other.
1872         (breakpoint_address_is_meaningful): Delete.
1873         (bl_address_is_meaningful): New.
1874         (breakpoint_locations_match): Adjust comment.
1875         (bp_location_from_bp_type): New, factored out of...
1876         (bp_location::bp_location(breakpoint *)): ... this.
1877         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1878         factored out of...
1879         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1880         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1881         breakpoint_address_is_meaningful.
1882         (bp_locations_compare): Adjust comment.
1883         (update_global_location_list): Use bl_address_is_meaningful
1884         instead of breakpoint_address_is_meaningful.
1885         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1886         explicit.
1887         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1888         * python/py-breakpoint.c (bppy_get_location): No longer check
1889         whether location is null.
1890
1891 2019-07-09  Pedro Alves  <palves@redhat.com>
1892
1893         PR c++/15468
1894         * breakpoint.c (print_one_breakpoint_location): Remove
1895         single-location assert.
1896
1897 2019-07-09  Tom Tromey  <tom@tromey.com>
1898
1899         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1900         * configure: Rebuild.
1901         * configure.ac: Change common to gdbsupport.
1902         * gdbsupport: Rename from common.
1903         * acinclude.m4: Change common to gdbsupport.
1904         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1905         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1906         gdbsupport.
1907         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1908         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1909         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1910         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1911         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1912         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1913         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1914         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1915         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1916         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1917         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1918         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1919         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1920         coff-pe-read.c, command.h, compile/compile-c-support.c,
1921         compile/compile-c.h, compile/compile-cplus-symbols.c,
1922         compile/compile-cplus-types.c, compile/compile-cplus.h,
1923         compile/compile-loc2c.c, compile/compile.c, completer.c,
1924         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1925         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1926         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1927         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1928         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1929         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1930         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1931         features/aarch64-core.c, features/aarch64-fpu.c,
1932         features/aarch64-pauth.c, features/aarch64-sve.c,
1933         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1934         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1935         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1936         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1937         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1938         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1939         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1940         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1941         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1942         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1943         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1944         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1945         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1946         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1947         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1948         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1949         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1950         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1951         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1952         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1953         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1954         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1955         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1956         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1957         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1958         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1959         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1960         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1961         minsyms.c, mips-linux-tdep.c, namespace.h,
1962         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1963         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1964         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1965         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1966         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1967         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1968         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1969         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1970         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1971         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1972         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1973         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1974         procfs.c, producer.c, progspace.h, psymtab.h,
1975         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1976         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1977         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1978         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1979         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1980         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1981         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1982         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1983         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1984         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1985         target-memory.c, target.c, target.h, target/waitstatus.c,
1986         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1987         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1988         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1989         unittests/array-view-selftests.c,
1990         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1991         unittests/common-utils-selftests.c,
1992         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1993         unittests/format_pieces-selftests.c,
1994         unittests/function-view-selftests.c,
1995         unittests/lookup_name_info-selftests.c,
1996         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1997         unittests/mkdir-recursive-selftests.c,
1998         unittests/observable-selftests.c,
1999         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2000         unittests/parse-connection-spec-selftests.c,
2001         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2002         unittests/scoped_fd-selftests.c,
2003         unittests/scoped_mmap-selftests.c,
2004         unittests/scoped_restore-selftests.c,
2005         unittests/string_view-selftests.c, unittests/style-selftests.c,
2006         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2007         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2008         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2009         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2010         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2011         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2012
2013 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2014
2015         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2016         bool value.
2017         (decode_digits_ordinary): Set explicit_line field in sal.
2018         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2019         symtab_and_line that was set on an explicit line number in
2020         assembler code.  Do always update the recorded symtab and line if
2021         we do skip the prologue.
2022
2023 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2024
2025         * breakpoint.c (set_breakpoint_location_function): Remove
2026         explicit_loc parameter.
2027         (momentary_breakpoint_from_master): Update call to
2028         set_breakpoint_location_function.
2029         (add_location_to_breakpoint): Likewise.
2030
2031 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2032
2033         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2034         required features based on default bfd type when no specific bfd
2035         is present.
2036
2037 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2038
2039         * NEWS: Mention that GDB printf and eval commands can now print
2040         C-style and Ada-style convenience var strings without
2041         calling the inferior.
2042         * printcmd.c (printf_c_string): Locally print GDB internal var
2043         instead of transiting via the inferior.
2044         (printf_wide_c_string): Likewise.
2045
2046 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2047
2048         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2049
2050 2019-07-04  Tom Tromey  <tom@tromey.com>
2051
2052         PR tui/24724:
2053         * tui/tui-winsource.c (tui_clear_source_content): Update.
2054         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2055         (tui_update_breakpoint_info): Update.
2056         (tui_set_exec_info_content): Update.
2057         * tui/tui-source.c (tui_set_source_content_nil): Update.
2058         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2059         has_break.
2060         * tui/tui-data.h (enum tui_bp_flag): New.
2061         (tui_bp_flags): New enum flags type.
2062         (struct tui_source_element) <break_mode>: Change type.  Rename
2063         from has_break.
2064         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2065         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2066         constants.
2067         * tui/tui-winsource.h: Fix comment.
2068
2069 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2070
2071         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2072         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2073         (store_fpregs_to_thread)
2074         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2075         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2076         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2077         (IWMMXT_REGS_SIZE): Add define.
2078         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2079         (fetch_vfp_regs, store_vfp_regs)
2080         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2081         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2082
2083 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2084
2085         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2086         defines.
2087         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2088         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2089         (ARM_INT_REGISTER_SIZE): ...to this.
2090         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2091         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2092         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2093         (arm_linux_collect_gregset, supply_nwfpe_register)
2094         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2095         defines.
2096         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2097         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2098         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2099         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2100         (arm_return_in_memory, arm_store_return_value)
2101         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2102         (arm_record_ld_st_multiple): Likewise.
2103         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2104         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2105
2106 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2107
2108         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2109         AARCH64_DISPLACED_MODIFIED_INSNS.
2110         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2111         (aarch64_displaced_step_copy_insn): Likewise.
2112         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2113         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2114         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2115         ARM_DISPLACED_MODIFIED_INSNS.
2116         * arm-tdep.c (arm_gdbarch_init): Likewise.
2117         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2118         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2119         (struct arm_displaced_step_closure): Use
2120         ARM_DISPLACED_MODIFIED_INSNS.
2121
2122 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2123
2124         * features/Makefile: Remove unused xml files.
2125         * features/aarch64.xml: Remove.
2126         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2127         * features/i386/amd64-avx-avx512.xml: Remove.
2128         * features/i386/amd64-avx-linux.xml: Remove.
2129         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2130         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2131         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2132         * features/i386/amd64-avx-mpx.xml: Remove.
2133         * features/i386/amd64-avx.xml: Remove.
2134         * features/i386/amd64-linux.xml: Remove.
2135         * features/i386/amd64-mpx-linux.xml: Remove.
2136         * features/i386/amd64-mpx.xml: Remove.
2137         * features/i386/amd64.xml: Remove.
2138         * features/i386/i386-avx-avx512-linux.xml: Remove.
2139         * features/i386/i386-avx-avx512.xml: Remove.
2140         * features/i386/i386-avx-linux.xml: Remove.
2141         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2142         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2143         * features/i386/i386-avx-mpx-linux.xml: Remove.
2144         * features/i386/i386-avx-mpx.xml: Remove.
2145         * features/i386/i386-avx.xml: Remove.
2146         * features/i386/i386-linux.xml: Remove.
2147         * features/i386/i386-mmx-linux.xml: Remove.
2148         * features/i386/i386-mmx.xml: Remove.
2149         * features/i386/i386-mpx-linux.xml: Remove.
2150         * features/i386/i386-mpx.xml: Remove.
2151         * features/i386/i386.xml: Remove.
2152         * features/i386/x32-avx-avx512-linux.xml: Remove.
2153         * features/i386/x32-avx-linux.xml: Remove.
2154         * features/i386/x32-linux.xml: Remove.
2155
2156 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2157
2158         * regformats/aarch64.dat: Remove.
2159         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2160         * regformats/i386/amd64-avx-linux.dat: Remove.
2161         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2162         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2163         * regformats/i386/amd64-linux.dat: Remove.
2164         * regformats/i386/amd64-mpx-linux.dat: Remove.
2165         * regformats/i386/amd64.dat: Remove.
2166         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2167         * regformats/i386/i386-avx-linux.dat: Remove.
2168         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2169         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2170         * regformats/i386/i386-linux.dat: Remove.
2171         * regformats/i386/i386-mmx-linux.dat: Remove.
2172         * regformats/i386/i386-mpx-linux.dat: Remove.
2173         * regformats/i386/i386.dat: Remove.
2174         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2175         * regformats/i386/x32-avx-linux.dat: Remove.
2176         * regformats/i386/x32-linux.dat: Remove.
2177
2178 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2179
2180         * aarch64-tdep.c: Remove xml self tests.
2181         * amd64-linux-tdep.c: Likewise.
2182         * amd64-tdep.c: Likewise.
2183         * i386-linux-tdep.c: Likewise.
2184         * i386-tdep.c: Likewise.
2185
2186 2019-07-03  Pedro Alves  <palves@redhat.com>
2187
2188         PR cli/24732
2189         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2190         (pipe_cmd_option_defs): New.
2191         (make_pipe_cmd_options_def_group): New.
2192         (pipe_command): Use gdb::option::process_options.
2193         (pipe_command_completer): New function.
2194         (_initialize_cli_cmds): Install completer for "pipe" command.
2195
2196 2019-07-03  Pedro Alves  <palves@redhat.com>
2197
2198         * cli/cli-option.c (union option_value) <string>: New field.
2199         (struct option_def_and_value): Add ctor, move ctor, dtor and
2200         use DISABLE_COPY_AND_ASSIGN.
2201         (option_def_and_value::clear_value): New.
2202         (parse_option, save_option_value_in_ctx, get_val_type_str)
2203         (add_setshow_cmds_for_options): Handle var_string.
2204         * cli-option.h (union option_def::var_address) <string>: New
2205         field.
2206         (struct string_option_def): New.
2207         * maint-test-options.c (struct test_options_opts): Add default
2208         ctor and use DISABLE_COPY_AND_ASSIGN.
2209         <string_opt>: New field.
2210         (test_options_opts::~test_options_opts): New.
2211         (test_options_opts::dump): Also dump "-string".
2212         (test_options_option_defs): Install "string.
2213
2214 2019-07-03  Pedro Alves  <palves@redhat.com>
2215
2216         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2217         option_value with a null enumeration.
2218         (complete_options): Save the option values in the context.
2219         (save_option_value_in_ctx): New, factored out from ...
2220         (process_options): ... here.
2221         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2222         of the function.
2223         * maint-test-options.c (test_options_opts::dump): New, factored
2224         out from ...
2225         (maintenance_test_options_command_mode): ... here.
2226         (maintenance_test_options_command_completion_result): Delete.
2227         (maintenance_test_options_command_completion_text): Update
2228         comment.
2229         (maintenance_show_test_options_completion_result): Change
2230         prototype.  Just print
2231         maintenance_test_options_command_completion_text.
2232         (save_completion_result): New.
2233         (maintenance_test_options_completer_mode): Pass options context to
2234         complete_options, and then save a dump.
2235         (_initialize_maint_test_options): Use add_cmd to install "maint
2236         show test-options-completion-result".
2237
2238 2019-07-03  Pedro Alves  <palves@redhat.com>
2239
2240         * NEWS (New commands): Mention "with" and "maint with".
2241         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2242         (with_command, with_command_completer): New.
2243         (pipe_command): Adjust to new repeat_previous
2244         interface.
2245         (_initialize_cli_cmds): Install the "with" command and its "w"
2246         alias.
2247         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2248         declarations.
2249         * cli/cli-setshow.c (parse_cli_var_uinteger)
2250         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2251         argument strings for all var_types.
2252         (get_setshow_command_value_string): New, factored out from ...
2253         (do_show_command): ... this.
2254         * cli/cli-setshow.h: Include <string>.
2255         (get_setshow_command_value_string): Declare.
2256         * command.h (repeat_previous): Now returns const char *.  Adjust
2257         comment.
2258         * maint.c: Include "cli/cli-cmds.h".
2259         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2260         (_initialize_maint_cmds): Register the "maintenance with" command.
2261         * top.c (repeat_previous): Move bits from pipe_command here:
2262         Return the saved command line, if any; error out if there's no
2263         command to relaunch.
2264
2265 2019-07-03  Pedro Alves  <palves@redhat.com>
2266
2267         * NEWS (New commands): Mention "maint set/show test-settings"
2268         instead of "maint test-settings".
2269         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2270         (maintenance_test_settings_set_list): Rename to ...
2271         (maintenance_set_test_settings_list): ... this.
2272         (maintenance_test_settings_show_list): Rename to  ...
2273         (maintenance_show_test_settings_list): ... this.
2274         (maintenance_test_settings_cmd): Delete.
2275         (maintenance_test_settings_set_cmd): ...
2276         (maintenance_set_test_settings_cmd): ... this.
2277         (maintenance_test_settings_show_cmd): ...
2278         (maintenance_show_test_settings_cmd): ... this.
2279         (maintenance_test_settings_show_value_cmd):
2280         (maintenance_show_test_settings_value_cmd): ... this.
2281         (_initialize_maint_test_settings): No longer install the "maint
2282         test-settings" prefix command.  Rename "maint test-settings set"
2283         to "maint set test-settings", and "maint test-settings show" to
2284         "maint show test-settings".  Adjust all subcommands.
2285
2286 2019-07-03  Pedro Alves  <palves@redhat.com>
2287
2288         * maint-test-settings.c: Fix file's intro comment.  Replace all
2289         references to "test-options" with references to "test-settings",
2290         in comments.
2291
2292 2019-07-03  Pedro Alves  <palves@redhat.com>
2293
2294         * maint-test-settings.c (maintenance_test_settings_xxx)
2295         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2296         New.
2297         (maintenance_test_settings_enums): Use them.
2298         (maintenance_test_settings_enum): Default to
2299         maintenance_test_settings_xxx.
2300         (_initialize_maint_test_settings): Initialize
2301         MAINTENANCE_TEST_SETTINGS_FILENAME.
2302
2303 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2304
2305         * breakpoint.h (remove_breakpoints_inf): Change return type to
2306         void, move function documentation here.
2307         * breakpoint.c (remove_breakpoints_inf): Change return type to
2308         void, move function documentation to header.
2309
2310 2019-07-02  Pedro Alves  <palves@redhat.com>
2311
2312         * NEWS (Completion improvements): Mention "info threads".
2313         * thread.c (struct info_threads_opts, info_threads_option_defs)
2314         (make_info_threads_options_def_group): New.
2315         (info_threads_command): Use gdb::option::process_options.
2316         (info_threads_command_completer): New.
2317         (_initialize_thread): Use gdb::option::build_help to build the
2318         help text for "info threads".
2319
2320 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2321
2322         * defs.h (generic_load): Move from here...
2323         * symfile.h (generic_load): ... to here.  Rename name parameter
2324         to args.
2325         * symfile.c (generic_load): Add comment.
2326
2327 2019-07-01  Tom Tromey  <tromey@adacore.com>
2328
2329         * dwarf2read.c
2330         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2331         declaration of without_params.  Fix formatting.
2332
2333 2019-07-01  Tom Tromey  <tromey@adacore.com>
2334
2335         * ada-exp.y (find_primitive_type): Update.
2336         * ada-lang.h (ada_lookup_symbol): Update.
2337         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2338         parameter.
2339         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2340
2341 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2342
2343         PR breakpoints/24541
2344         * gdbarch.c: Regenerate.
2345         * gdbarch.h: Regenerate.
2346         * gdbarch.sh: Add 'stap_adjust_register'.
2347         * i386-tdep.c: Include '<unordered_set>'.
2348         (i386_stap_adjust_register): New function.
2349         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2350         * stap-probe.c (stap_parse_register_operand): Call
2351         'gdbarch_stap_adjust_register'.
2352
2353 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2354
2355         PR python/24742
2356         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2357         * python/python.c (do_start_initialization): Use 'xmalloc'
2358         instead of 'PyMem_Malloc'.
2359
2360 2019-06-28  Tom Tromey  <tromey@adacore.com>
2361
2362         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2363         for Ada.
2364
2365 2019-06-27  Tom Tromey  <tromey@adacore.com>
2366
2367         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2368         objfile_key.
2369         (arm_find_mapping_symbol, arm_record_special_symbol)
2370         (_initialize_arm_tdep): Update.
2371         (arm_objfile_data_free): Remove.
2372
2373 2019-06-27  Tom Tromey  <tromey@adacore.com>
2374
2375         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2376         to cp_print_static_field.
2377
2378 2019-06-26  Tom Tromey  <tromey@adacore.com>
2379
2380         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2381         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2382         declare.
2383
2384 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2385
2386         * features/aarch64-core.c (create_feature_aarch64_core):
2387         Regenerate.
2388         * features/aarch64-core.xml: Add cpsr flags.
2389
2390 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2391
2392         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2393         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2394
2395 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2396
2397         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2398         field.
2399         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2400         use.
2401         (arm_record_special_symbol): Don't insert new symbol in sorted
2402         position, push it at the end.
2403
2404 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2405
2406         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2407         (arm_mapping_symbol_s): Remove.
2408         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2409         (arm_mapping_symbol_vec): New typedef.
2410         (struct arm_per_objfile): Add constructor.
2411         <section_maps>: Change type to
2412         std::unique_ptr<arm_mapping_symbol_vec[]>.
2413         (arm_compare_mapping_symbols): Remove.
2414         (arm_find_mapping_symbol): Adjust to section_maps type change.
2415         (arm_objfile_data_free): Call delete on arm_per_objfile.
2416         (arm_record_special_symbol): Adjust to section_maps type change.
2417         Allocate arm_per_objfile with new.
2418
2419 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2420
2421         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2422         with the command prefix.
2423
2424 2019-06-25  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2427         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2428
2429 2019-06-25  Tom Tromey  <tom@tromey.com>
2430
2431         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2432         type.
2433         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2434         protected.
2435
2436 2019-06-25  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-winsource.c
2439         (tui_source_window_base::set_is_exec_point_at): Add check against
2440         LOA_ADDRESS.
2441
2442 2019-06-25  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-source.c (tui_set_source_content): Don't check before
2445         xfree.
2446         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2447
2448 2019-06-25  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-winsource.h (tui_update_source_window_as_is)
2451         (tui_alloc_source_buffer, tui_line_is_displayed)
2452         (tui_addr_is_displayed): Change type of win_info.
2453         * tui/tui-winsource.c (tui_update_source_window_as_is)
2454         (tui_clear_source_content, tui_show_source_line)
2455         (tui_show_source_content, tui_source_window_base::refill)
2456         (tui_source_window_base::set_is_exec_point_at)
2457         (tui_source_window_base::set_is_exec_point_at)
2458         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2459         (tui_alloc_source_buffer, tui_line_is_displayed)
2460         (tui_addr_is_displayed): Change type of win_info.  Update.
2461         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2462         (tui_source_window_base::do_make_visible_with_new_height):
2463         Update.
2464         * tui/tui-source.c (tui_set_source_content)
2465         (tui_set_source_content_nil)
2466         (tui_source_window::do_scroll_vertical): Update.
2467         * tui/tui-layout.c (show_layout): Update.
2468         * tui/tui-disasm.c (tui_set_disassem_content)
2469         (tui_disasm_window::do_scroll_vertical): Update.
2470         * tui/tui-data.h (tui_win_content): Remove.
2471         (struct tui_gen_win_info) <content, content_size>: Remove.
2472         (struct tui_source_element): Add initializers and destructor.
2473         (union tui_which_element, struct tui_win_element): Remove.
2474         (struct tui_source_window_base) <content>: New field.
2475         (struct tui_data_window): Remove destructor.
2476         (tui_alloc_content, tui_free_win_content)
2477         (tui_free_all_source_wins_content): Don't declare.
2478         * tui/tui-data.c (tui_initialize_static_data): Update.
2479         (init_content_element, tui_alloc_content): Remove.
2480         (~tui_gen_win_info): Update.
2481         (~tui_data_window, tui_free_all_source_wins_content)
2482         (tui_free_win_content, free_content, free_content_elements):
2483         Remove.
2484
2485 2019-06-25  Tom Tromey  <tom@tromey.com>
2486
2487         * tui/tui-winsource.h (tui_clear_source_content)
2488         (tui_erase_source_content, tui_show_source_content): Change type
2489         of win_info.
2490         * tui/tui-winsource.c (tui_clear_source_content)
2491         (tui_erase_source_content, tui_show_source_content): Change type
2492         of win_info.
2493         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2494         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2495         win_info.
2496         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2497         win_info.
2498         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2499
2500 2019-06-25  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-winsource.c (tui_clear_source_content)
2503         (tui_source_window_base::set_is_exec_point_at): Update.
2504         * tui/tui-source.c (tui_set_source_content_nil): Update.
2505         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2506         a bool.
2507         * tui/tui-data.c (init_content_element): Update.
2508
2509 2019-06-25  Tom Tromey  <tom@tromey.com>
2510
2511         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2512         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2513         * tui/tui-layout.c (init_and_make_win): Update.
2514         * tui/tui.h (enum tui_win_type): Update.
2515         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2516         tui_win_is_auxillary.
2517         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2518         tui_win_is_auxillary.
2519
2520 2019-06-25  Tom Tromey  <tom@tromey.com>
2521
2522         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2523         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2524         (tui_delete_data_content_windows, tui_display_all_data)
2525         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2526         Update.
2527         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2528         * tui/tui-regs.c (tui_last_regs_line_no)
2529         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2530         (tui_show_registers): Update.
2531         (tui_show_register_group): Return void.  Update.
2532         (tui_display_registers_from, tui_display_reg_element_at_line)
2533         (tui_display_registers_from_line, tui_check_register_values):
2534         Update.
2535         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2536         member.
2537         (struct tui_data_window) <regs_content>: Now a std::vector.
2538         <regs_content_count>: Remove.
2539         (tui_add_content_elements, tui_free_data_content): Don't declare.
2540         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2541         (init_content_element): Remove DATA_WIN case.  Add assert.
2542         (tui_add_content_elements): Remove.
2543         (tui_data_window): Update.
2544         (tui_free_data_content): Remove.
2545         (free_content_elements): Remove DATA_WIN case.
2546
2547 2019-06-25  Tom Tromey  <tom@tromey.com>
2548
2549         * tui/tui-data.c (tui_data_item_window): Update.
2550         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2551         * tui/tui-windata.c (tui_display_all_data)
2552         (tui_display_data_from_line): Update.
2553         (tui_check_data_values): Remove.
2554         * tui/tui-regs.c (tui_show_register_group)
2555         (tui_display_reg_element_at_line): Update.
2556         * tui/tui-hooks.c (tui_register_changed)
2557         (tui_refresh_frame_and_register_information): Call
2558         tui_check_register_values.
2559         * tui/tui-data.h (struct tui_data_window) <data_content,
2560         data_content_count, data_type>: Remove.
2561         (enum tui_data_type): Remove.
2562
2563         * tui/tui-data.c (tui_data_window::clear_detail)
2564         (~tui_data_window): Update.
2565
2566 2019-06-25  Tom Tromey  <tom@tromey.com>
2567
2568         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2569         declare.
2570         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2571         Rename from tui_first_data_item_displayed.  Update.
2572         (tui_data_window::refresh_all)
2573         (tui_data_window::do_scroll_vertical): Update.
2574         * tui/tui-data.h (struct tui_data_window)
2575         <first_data_item_displayed>: Declare new method.
2576
2577 2019-06-25  Tom Tromey  <tom@tromey.com>
2578
2579         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2580         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2581         contents...
2582         (tui_initialize_static_data): ...here.
2583
2584 2019-06-25  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2587         (tui_display_registers_from, tui_check_register_values): Update.
2588         (tui_display_register): Remove win_info parameter; update.
2589         (tui_get_register): Change type of parameters.
2590         * tui/tui-data.h (struct tui_data_element): Remove.
2591         (union tui_which_element) <data>: Remove.
2592         <data_window>: Change type.
2593         (struct tui_data_item_window): New.
2594         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2595         case.  Add assert.
2596         (~tui_data_item_window): New destructor.
2597         (free_content_elements): Remove DATA_ITEM_WIN case.
2598
2599 2019-06-25  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2602         Remove.
2603
2604 2019-06-25  Tom Tromey  <tom@tromey.com>
2605
2606         * tui/tui-data.h (struct tui_command_element): Remove.
2607         (union tui_which_element) <command>: Remove.
2608         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2609         assert.
2610         (free_content_elements): Remove CMD_WIN case.
2611
2612 2019-06-25  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-layout.c (tui_set_layout): Update.
2615         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2616         * tui/tui-data.c (layout_def): Update.
2617
2618 2019-06-25  Tom Tromey  <tom@tromey.com>
2619
2620         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2621         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2622         (tui_source_window_base::set_new_height): Update.
2623         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2624         Update.
2625         (tui_set_locator_fullname, tui_set_locator_info)
2626         (tui_show_frame_info): Update.
2627         * tui/tui-source.c (tui_set_source_content)
2628         (tui_source_is_displayed): Update.
2629         * tui/tui-layout.c (show_source_disasm_command, show_data)
2630         (show_source_or_disasm_and_command): Update.
2631         * tui/tui-disasm.c (tui_set_disassem_content)
2632         (tui_get_begin_asm_address): Update.
2633         * tui/tui-data.h (struct tui_locator_element): Remove.
2634         (union tui_which_element) <locator>: Remove.
2635         (struct tui_locator_window): New.
2636         (tui_locator_win_info_ptr): Change return type.
2637         * tui/tui-data.c (_locator): Change type.
2638         (tui_locator_win_info_ptr): Change return type.
2639         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2640         (tui_alloc_content): Add assert.
2641
2642 2019-06-25  Tom Tromey  <tom@tromey.com>
2643
2644         * tui/tui-winsource.c
2645         (tui_exec_info_window::maybe_allocate_content): New method.
2646         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2647         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2648         (make_source_or_disasm_window): Add cast.
2649         * tui/tui-data.h (union tui_which_element) <simple_string>:
2650         Remove.
2651         (struct tui_source_info): New.
2652         (struct tui_source_window_base) <execution_info>: Change type.
2653         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2654         case, and add assert.
2655         (tui_alloc_content): Add assert.
2656
2657 2019-06-25  Tom Tromey  <tom@tromey.com>
2658
2659         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2660         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2661         * tui/tui-data.c (tui_alloc_win_info): Remove.
2662
2663 2019-06-25  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2666         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2667         can_highlight.
2668
2669 2019-06-25  Tom Tromey  <tom@tromey.com>
2670
2671         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2672         make_visible_with_new_height method.
2673         (tui_win_info::make_visible_with_new_height): New method.
2674         (tui_source_window_base::do_make_visible_with_new_height)
2675         (tui_data_window::do_make_visible_with_new_height)
2676         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2677         (make_visible_with_new_height): Remove.
2678         (tui_resize_all, tui_adjust_win_heights): Use
2679         make_visible_with_new_height method.
2680         * tui/tui-data.h (struct tui_win_info)
2681         <do_make_visible_with_new_height, make_visible_with_new_height>:
2682         New methods.
2683         (struct tui_source_window_base, struct tui_data_window)
2684         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2685         methods.
2686
2687 2019-06-25  Tom Tromey  <tom@tromey.com>
2688
2689         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2690         method.
2691         (update_tab_width): Call update_tab_width method.
2692         * tui/tui-data.h (struct tui_win_info)
2693         (struct tui_source_window_base) <update_tab_width>: New methods.
2694
2695 2019-06-25  Tom Tromey  <tom@tromey.com>
2696
2697         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2698         parameter.
2699         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2700         parameter.
2701         (tui_gen_win_info::make_visible): Update.
2702         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2703         parameter.
2704         * tui/tui-data.h (enum tui_box): New enum.
2705         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2706
2707 2019-06-25  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2710         init_and_make_win for EXEC_INFO_WIN.
2711         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2712         longer inline.
2713         (struct tui_win_info) <~tui_win_info>: Inline.
2714         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2715         Don't declare.
2716         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2717         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2718         Remove.
2719         (tui_initialize_static_data): Update.
2720         (~tui_gen_win_info): Handle more cleanup here.
2721         (~tui_source_window_base): Delete "execution_info".
2722         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2723
2724 2019-06-25  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui-layout.c (make_command_window): Don't set
2727         can_highlight.
2728         (show_source_disasm_command): Call the reset method.
2729         (show_data): Don't set can_highlight.  Call the reset method.
2730         (tui_gen_win_info::reset): Rename from init_gen_win_info
2731         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2732         (show_source_or_disasm_and_command): Call the reset method.
2733         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2734         (struct tui_cmd_window): Set can_highlight.
2735
2736 2019-06-25  Tom Tromey  <tom@tromey.com>
2737
2738         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2739         from make_visible.
2740         (tui_make_visible, tui_make_invisible): Rewrite.
2741         (tui_win_info::make_visible): Remove.
2742         (tui_source_window_base::make_visible): Update.
2743         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2744         method.  Moved from...
2745         (struct tui_win_info) <make_visible>: ...here.
2746
2747 2019-06-25  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui-winsource.c
2750         (tui_source_window_base::do_scroll_horizontal): Remove direction
2751         parameter.
2752         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2753         direction parameter.
2754         * tui/tui-win.c (tui_win_info::forward_scroll)
2755         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2756         (tui_win_info::right_scroll): Update.
2757         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2758         direction parameter.
2759         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2760         direction parameter.
2761         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2762         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2763         Remove direction parameter.
2764         (struct tui_source_window_base, struct tui_source_window)
2765         (struct tui_disasm_window, struct tui_data_window)
2766         (struct tui_cmd_window): Update.
2767
2768 2019-06-25  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-winsource.h (tui_set_exec_info_content)
2771         (tui_show_exec_info_content, tui_erase_exec_info_content)
2772         (tui_clear_exec_info_content, tui_update_exec_info): Change
2773         argument to tui_source_window_base.
2774         * tui/tui-winsource.c (tui_set_exec_info_content)
2775         (tui_show_exec_info_content, tui_erase_exec_info_content)
2776         (tui_clear_exec_info_content, tui_update_exec_info): Change
2777         argument to tui_source_window_base.
2778
2779 2019-06-25  Tom Tromey  <tom@tromey.com>
2780
2781         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2782         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2783
2784 2019-06-25  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2787         check.
2788
2789 2019-06-25  Tom Tromey  <tom@tromey.com>
2790
2791         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2792         type to void.
2793         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2794         type to void.
2795         * tui/tui-source.c (tui_set_source_content): Update.
2796         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2797
2798 2019-06-25  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-win.c (window_name_completer, tui_set_focus)
2801         (tui_all_windows_info): Use name method.
2802         * tui/tui-data.h (struct tui_gen_win_info)
2803         (struct tui_source_window, struct tui_disasm_window)
2804         (struct tui_data_window, struct tui_cmd_window) <name>: New
2805         method.
2806         (tui_win_name): Don't declare.
2807         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2808         (tui_win_name): Remove.
2809
2810 2019-06-25  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-winsource.h (tui_update_source_window)
2813         (tui_update_source_window_as_is): Change parameter type.
2814         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2815         to be a tui_source_window_base.
2816         (tui_update_source_window_as_is): Likewise.
2817         * tui/tui-win.c (make_visible_with_new_height): Update.
2818
2819 2019-06-25  Tom Tromey  <tom@tromey.com>
2820
2821         * tui/tui-winsource.c (tui_erase_source_content)
2822         (tui_show_source_content, tui_show_exec_info_content)
2823         (tui_erase_exec_info_content): Use refresh_window method.
2824         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2825         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2826         from tui_refresh_win.
2827         (tui_data_window::refresh_window): New method.
2828         (tui_win_info::refresh, tui_source_window_base::refresh)
2829         (tui_refresh_all): Use refresh_window method.
2830         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2831         method.
2832         * tui/tui-regs.c (tui_display_register): Call refresh_window
2833         method.
2834         * tui/tui-layout.c (show_source_disasm_command)
2835         (show_source_or_disasm_and_command): Call refresh_window method.
2836         * tui/tui-data.h (struct tui_gen_win_info)
2837         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2838         New method.
2839
2840 2019-06-25  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui.c (tui_rl_other_window, tui_enable)
2843         (tui_is_window_visible, tui_get_command_dimension): Update.
2844         * tui/tui-winsource.c (tui_update_source_window_as_is)
2845         (tui_clear_source_content, tui_erase_source_content)
2846         (tui_show_source_line, tui_source_window_base::refill)
2847         (tui_source_window_base::do_scroll_horizontal)
2848         (tui_source_window_base::set_is_exec_point_at)
2849         (tui_update_breakpoint_info, tui_set_exec_info_content)
2850         (tui_alloc_source_buffer, tui_line_is_displayed)
2851         (tui_addr_is_displayed): Update.
2852         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2853         (tui_check_and_display_highlight_if_needed)
2854         (tui_win_info::make_visible, tui_win_info::refresh)
2855         (tui_refresh_all): Update.
2856         * tui/tui-windata.c (tui_first_data_item_displayed)
2857         (tui_delete_data_content_windows, tui_erase_data_content)
2858         (tui_display_all_data, tui_data_window::refresh_all)
2859         (tui_check_data_values): Update.
2860         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2861         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2862         (tui_win_info::backward_scroll, tui_refresh_all_win)
2863         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2864         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2865         (tui_source_window_base::set_new_height)
2866         (tui_data_window::set_new_height)
2867         (make_invisible_and_set_new_height)
2868         (make_visible_with_new_height, new_height_ok)
2869         (parse_scrolling_args): Update.
2870         * tui/tui-stack.c (tui_show_frame_info): Update.
2871         * tui/tui-source.c (tui_set_source_content)
2872         (tui_set_source_content_nil, tui_source_is_displayed)
2873         (tui_source_window::do_scroll_vertical): Update.
2874         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2875         (tui_display_registers_from, tui_display_reg_element_at_line)
2876         (tui_check_register_values, tui_reg_command): Update.
2877         * tui/tui-layout.c (tui_default_win_height)
2878         (show_source_disasm_command, show_data, init_and_make_win)
2879         (show_source_or_disasm_and_command): Update.
2880         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2881         (tui_redisplay_readline, tui_mld_flush)
2882         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2883         (tui_getc): Update.
2884         * tui/tui-disasm.c (tui_set_disassem_content)
2885         (tui_disasm_window::do_scroll_vertical): Update.
2886         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2887         Now virtual.
2888         (struct tui_win_info): Derive from tui_gen_win_info.
2889         <~tui_win_info>: Mark as override.
2890         <generic>: Remove member.
2891         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2892         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2893         (~tui_data_window, ~tui_win_info)
2894         (tui_free_all_source_wins_content): Update.
2895         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2896
2897 2019-06-25  Tom Tromey  <tom@tromey.com>
2898
2899         * tui/tui-layout.c (init_and_make_win): Use new.
2900         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2901         destructor, initializers.
2902         (tui_alloc_generic_win_info): Don't declare.
2903         * tui/tui-data.c (_locator): Add argument to constructor.
2904         (source_win, disasm_win): New globals.
2905         (exec_info): Remove.
2906         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2907         Update.
2908         (tui_alloc_generic_win_info): Remove.
2909         (init_content_element): Use new.
2910         (tui_win_info::tui_win_info): Update.
2911         (free_content_elements) <case DATA_WIN>: Use delete.
2912
2913 2019-06-25  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2916         * tui/tui-windata.c (tui_first_data_item_displayed)
2917         (tui_delete_data_content_windows): Update.
2918         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2919         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2920         (tui_display_registers_from, tui_check_register_values): Update.
2921         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2922         pointer.
2923         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2924         window.
2925         (tui_free_data_content): Update.
2926         (free_content_elements) <case DATA_WIN>: Free the window.
2927
2928 2019-06-25  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2931         Update.
2932         * tui/tui-layout.c (make_command_window)
2933         (show_source_disasm_command, show_data, init_and_make_win)
2934         (show_source_or_disasm_and_command): Update.
2935         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2936         method.
2937         <can_highight, is_highlighted>: Now bool.
2938         (tui_set_win_highlight): Don't declare.
2939         * tui/tui-data.c (tui_set_win_highlight): Remove.
2940
2941 2019-06-25  Tom Tromey  <tom@tromey.com>
2942
2943         * tui/tui-wingeneral.c (make_visible): Remove check of window
2944         type.
2945
2946 2019-06-25  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-win.c (tui_win_info::max_height)
2949         (tui_cmd_window::max_height): New methods.
2950         (new_height_ok): Call max_height.
2951         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2952         <max_height>: New method.
2953
2954 2019-06-25  Tom Tromey  <tom@tromey.com>
2955
2956         * tui/tui-win.c (tui_source_window_base::set_new_height)
2957         (tui_data_window::set_new_height): New methods.
2958         (make_invisible_and_set_new_height): Call set_new_height method.
2959         * tui/tui-data.h (struct tui_win_info)
2960         (struct tui_source_window_base, struct tui_data_window)
2961         <set_new_height>: New method.
2962
2963 2019-06-25  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2966         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2967         tui_refresh_data_win.
2968         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2969         method.
2970         (tui_refresh_all_win): Call the refresh_all method.
2971         (tui_set_focus): Likewise.
2972         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2973         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2974         Likewise.
2975
2976 2019-06-25  Tom Tromey  <tom@tromey.com>
2977
2978         * tui/tui-winsource.h (tui_refill_source_window)
2979         (tui_set_is_exec_point_at): Don't declare.
2980         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2981         (tui_source_window_base::refill): Rename from
2982         tui_refill_source_window.
2983         (tui_source_window_base::do_scroll_horizontal): Update.
2984         (tui_source_window_base::set_is_exec_point_at): Rename from
2985         tui_set_is_exec_point_at.
2986         (tui_update_all_breakpoint_info): Update.
2987         * tui/tui-stack.c (tui_show_frame_info): Update.
2988         * tui/tui-layout.c (show_data): Add cast.
2989         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2990         * tui/tui-data.h (struct tui_source_window_base) <refill,
2991         set_is_exec_point_at>: New methods.
2992         (tui_source_windows, tui_add_to_source_windows): Update types.
2993         (tui_add_to_source_windows): Remove redundant declaration.
2994         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2995         (tui_source_windows): Change return type.
2996         (tui_clear_source_windows_detail): Update.
2997         (tui_add_to_source_windows): Change type of parameter.
2998         (tui_free_all_source_wins_content): Update.
2999
3000 2019-06-25  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-wingeneral.c (tui_win_info::refresh)
3003         (tui_source_window_base::refresh): New methods.
3004         (tui_refresh_all): Call the refresh method.
3005         * tui/tui-data.h (struct tui_win_info)
3006         (struct tui_source_window_base) <refresh>: New method.
3007
3008 2019-06-25  Tom Tromey  <tom@tromey.com>
3009
3010         * tui/tui.h (tui_is_window_visible): Return bool.
3011         * tui/tui.c (tui_is_window_visible): Return bool.
3012         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3013         (tui_make_visible, tui_make_invisible)
3014         (tui_win_info::make_visible)
3015         (tui_source_window_base::make_visible, make_all_visible)
3016         (tui_make_all_visible, tui_make_all_invisible): Update.
3017         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3018         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3019         bool.
3020         (struct tui_win_info, struct tui_source_window_base)
3021         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3022         * tui/tui-data.c (tui_init_generic_part): Update.
3023
3024 2019-06-25  Tom Tromey  <tom@tromey.com>
3025
3026         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3027         (tui_source_window_base::make_visible): New methods.
3028         (make_all_visible): Make method call.
3029         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3030         (struct tui_source_window_base, struct tui_cmd_window): Override
3031         make_visible.
3032         (tui_win_is_source_type): Don't declare.
3033         * tui/tui-data.c (tui_win_is_source_type): Remove.
3034
3035 2019-06-25  Tom Tromey  <tom@tromey.com>
3036
3037         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3038         NULL check.
3039
3040 2019-06-25  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3043         Inline constructor.  Add initializers for members.
3044         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3045         constructors; now inline in class.
3046
3047 2019-06-25  Tom Tromey  <tom@tromey.com>
3048
3049         * tui/tui-regs.c (tui_show_registers): Update.
3050         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3051         bool.
3052         * tui/tui-data.c (tui_data_window::clear_detail)
3053         (tui_data_window): Update.
3054
3055 2019-06-25  Tom Tromey  <tom@tromey.com>
3056
3057         * tui/tui-windata.c (tui_display_all_data)
3058         (tui_display_data_from_line, tui_display_data_from)
3059         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3060         Update.
3061         * tui/tui-regs.c (tui_last_regs_line_no)
3062         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3063         (tui_show_registers, tui_show_register_group)
3064         (tui_display_registers_from, tui_display_reg_element_at_line)
3065         (tui_display_registers_from_line, tui_check_register_values)
3066         (tui_reg_next, tui_reg_prev): Update.
3067         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3068         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3069         tui_data_window.
3070         (struct tui_win_info) <detail>: Remove.  Add new fields from
3071         tui_data_info.
3072         (TUI_DATA_WIN): Add cast.
3073         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3074         (~tui_data_window): Simplify.
3075
3076 2019-06-25  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-layout.c (show_source_disasm_command)
3079         (show_source_or_disasm_and_command): Update.
3080         * tui/tui-io.c (update_cmdwin_start_line)
3081         (tui_redisplay_readline): Update.
3082         * tui/tui-data.h (struct tui_command_info): Remove.
3083         (struct tui_win_info) <detail>: Remove command_info member.
3084         (struct tui_data_window) <start_line>: New member, from
3085         tui_command_info.
3086         (TUI_CMD_WIN): Add casts.
3087
3088 2019-06-25  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-winsource.c (tui_update_source_window)
3091         (tui_refill_source_window)
3092         (tui_source_window_base::do_scroll_horizontal)
3093         (tui_update_breakpoint_info, tui_set_exec_info_content)
3094         (tui_show_exec_info_content, tui_erase_exec_info_content)
3095         (tui_clear_exec_info_content): Update.
3096         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3097         Update.
3098         * tui/tui-win.c (make_invisible_and_set_new_height)
3099         (make_visible_with_new_height): Update.
3100         * tui/tui-source.c (tui_set_source_content)
3101         (tui_show_symtab_source): Update.
3102         * tui/tui-layout.c (extract_display_start_addr)
3103         (show_source_disasm_command, show_data)
3104         (make_source_or_disasm_window)
3105         (show_source_or_disasm_and_command): Update.
3106         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3107         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3108         "gdbarch".
3109         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3110         to tui_source_window_base.
3111         (struct tui_win_info) <detail>: Remove source_info member.
3112         (struct tui_source_window_base) <has_locator>: Inline.
3113         Move contents from tui_source_info; rename has_locator member to
3114         m_has_locator.
3115         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3116         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3117         header file.
3118         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3119         Simplify.
3120         (tui_free_all_source_wins_content): Cast to
3121         tui_source_window_base.
3122
3123 2019-06-25  Tom Tromey  <tom@tromey.com>
3124
3125         * tui/tui-win.c (make_invisible_and_set_new_height)
3126         (make_visible_with_new_height): Call has_locator method.
3127         * tui/tui-layout.c (show_source_disasm_command, show_data)
3128         (show_source_or_disasm_and_command): Update for bool change.
3129         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3130         (tui_win_info) <has_locator>: New method.
3131         (struct tui_source_window_base) <has_locator>: New method.
3132         (tui_win_has_locator): Don't declare.
3133         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3134         from tui_win_has_locator.
3135         (tui_source_window_base): Use false, not FALSE.
3136
3137 2019-06-25  Tom Tromey  <tom@tromey.com>
3138
3139         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3140         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3141         clear_detail method directly.
3142         (tui_clear_win_detail): Remove.
3143
3144 2019-06-25  Tom Tromey  <tom@tromey.com>
3145
3146         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3147         "this", not TUI_DISASM_WIN.
3148
3149 2019-06-25  Tom Tromey  <tom@tromey.com>
3150
3151         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3152         declare.
3153         * tui/tui-winsource.c
3154         (tui_source_window_base::do_scroll_horizontal): Rename from
3155         tui_horizontal_source_scroll.
3156         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3157         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3158         from tui_vertical_data_scroll.
3159         * tui/tui-win.h (tui_scroll): Don't declare.
3160         * tui/tui-win.c (tui_win_info::forward_scroll)
3161         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3162         (tui_win_info::right_scroll): Rename and update.
3163         (tui_scroll_forward_command, tui_scroll_backward_command)
3164         (tui_scroll_left_command, tui_scroll_right_command): Update.
3165         (tui_scroll): Remove.
3166         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3167         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3168         from tui_vertical_source_scroll.
3169         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3170         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3171         from tui_vertical_disassem_scroll.
3172         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3173         do_scroll_horizontal>: New methods.
3174         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3175         Likewise.
3176         (struct tui_source_window_base): Add do_scroll_horizontal.
3177         (struct tui_source_window, struct tui_disasm_window): Add
3178         do_scroll_vertical.
3179         (struct tui_data_window, struct tui_cmd_window): Add
3180         do_scroll_horizontal and do_scroll_vertical.
3181         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3182
3183 2019-06-25  Tom Tromey  <tom@tromey.com>
3184
3185         * tui/tui-data.h (struct tui_source_window_base): New struct.
3186         (struct tui_source_window): Derive from tui_source_window_base.
3187         (struct tui_disasm_window): New struct.
3188         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3189         from tui_source_window::clear_detail.
3190         (tui_source_window_base): Rename from tui_source_window.
3191         (~tui_source_window_base): Rename from ~tui_source_window.
3192         (tui_alloc_win_info): Create a tui_disasm_window.
3193
3194 2019-06-25  Tom Tromey  <tom@tromey.com>
3195
3196         * tui/tui-data.h (struct tui_source_window)
3197         (struct tui_data_window): Declare destructors.
3198         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3199         destructors.
3200         (tui_win_info): Simplify.
3201
3202 2019-06-25  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-winsource.c (tui_display_main)
3205         (tui_update_source_windows_with_addr)
3206         (tui_update_all_breakpoint_info): Update.
3207         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3208         (new_height_ok, parse_scrolling_args): Update.
3209         * tui/tui-stack.c (tui_show_frame_info): Update.
3210         * tui/tui-data.h (struct tui_list): Remove.
3211         (tui_source_windows): Return a reference to a std::vector.
3212         * tui/tui-data.c (source_windows): Now a std::vector.
3213         (tui_source_windows): Change return type.
3214         (tui_clear_source_windows): Rewrite.
3215         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3216         (tui_free_all_source_wins_content): Rewrite.
3217
3218 2019-06-25  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3221         (struct tui_data_window, struct tui_cmd_window): Declare
3222         clear_detail method.
3223         * tui/tui-data.c (tui_source_window::clear_detail)
3224         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3225         methods.
3226         (tui_clear_win_detail): Simplify.
3227
3228 2019-06-25  Tom Tromey  <tom@tromey.com>
3229
3230         * tui/tui-layout.c (make_source_window, make_disasm_window)
3231         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3232         Return the new window.
3233         (show_source_disasm_command, show_data)
3234         (show_source_or_disasm_and_command): Update.
3235
3236 2019-06-25  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3239         parameter.  Return the new window.
3240         (show_source_disasm_command): Update and remove NULL check.
3241         (show_source_or_disasm_and_command): Update.
3242
3243 2019-06-25  Tom Tromey  <tom@tromey.com>
3244
3245         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3246
3247 2019-06-25  Tom Tromey  <tom@tromey.com>
3248
3249         * tui/tui-data.h (struct tui_win_info): Make constructor
3250         protected.  Make destructor virtual.  Add initializers.
3251         (tui_source_window, tui_data_window, tui_cmd_window): New
3252         classes.
3253         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3254         constructor.  Add "type" parameter.
3255         (tui_source_window, tui_data_window, tui_cmd_window): New
3256         constructors.
3257         (tui_alloc_win_info): Instantiate the appropriate subclass.
3258
3259 2019-06-25  Tom Tromey  <tom@tromey.com>
3260
3261         * tui/tui-win.c (tui_resize_all): Use delete.
3262         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3263         destructor.
3264         (tui_free_window): Don't declare.
3265         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3266         Update.
3267
3268 2019-06-25  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-data.h (struct tui_win_info): Add constructor.
3271         * tui/tui-data.c (tui_alloc_win_info): Use new.
3272         (tui_free_window): Use delete.
3273
3274 2019-06-22  Tom Tromey  <tom@tromey.com>
3275
3276         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3277         declare.
3278         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3279
3280 2019-06-22  Tom Tromey  <tom@tromey.com>
3281
3282         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3283         declare.
3284         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3285
3286 2019-06-22  Tom de Vries  <tdevries@suse.de>
3287
3288         * dwarf2read.c (create_addrmap_from_aranges)
3289         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3290         instead of '%zu'.
3291
3292 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3293
3294         * dwarf2read.h (dwarf2_section_info_def): Remove.
3295         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3296         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3297         std::vector<dwarf2_section_info>.
3298         (struct dwo_file) <~dwo_file>: Remove.
3299         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3300         types field.
3301         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3302         (dwarf2_read_debug_names): Likewise.
3303         (create_debug_types_hash_table): Change parameter type to
3304         array_view, adjust code accordingly.
3305         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3306         (partial_die_info::fixup): Likewise.
3307         (determine_prefix): Likewise.
3308         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3309
3310 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3311
3312         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3313         gdb_bfd_ref_ptr.
3314         <~dwo_file>: Remove call to gdb_bfd_unref.
3315         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3316         gdb_bfd_ref_ptr::get.
3317
3318 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3319
3320         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3321         type to htab_up.
3322         * dwarf2read.c (struct dwo_file): Initialize fields.
3323         <~dwo_file>: New.
3324         (free_dwo_file): Remove, move content to ~dwo_file.
3325         (struct dwo_file_deleter): Remove.
3326         (dwo_file_up>: Remove custom deleter.
3327         (free_dwo_files): Remove.
3328         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3329         dwo_files.
3330         (process_skeletonless_type_units): Call unique_ptr::get.
3331         (allocate_dwo_file_hash_table): Add deleter to created hash
3332         table.  Change return type to htab_up.
3333         (lookup_dwo_file_slot): Don't memset dwo_file, call
3334         unique_ptr::get.
3335         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3336         (create_dwo_unit_in_dwp_v2): Likewise.
3337         (open_and_init_dwo_file): Likewise.
3338         (free_dwo_file_from_slot): Remove.
3339
3340 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3341
3342         * dwarf2read.h (struct dwarf2_section_info) <readin,
3343         is_virtual>: Change type to bool.
3344         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3345         true instead of 1.
3346
3347 2019-06-19  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui-data.h (tui_init_content_element): Don't declare.
3350
3351 2019-06-19  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-data.h (tui_init_win_info): Don't declare.
3354
3355 2019-06-19  Tom de Vries  <tdevries@suse.de>
3356
3357         * dwarf2read.h (abstract_to_concrete): Change type to
3358         std::unordered_map<sect_offset, std::vector<sect_offset>,
3359         gdb::hash_enum<sect_offset>>.
3360
3361 2019-06-19  Tom Tromey  <tromey@adacore.com>
3362
3363         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3364         EVAL_AVOID_SIDE_EFFECTS specially.
3365
3366 2019-06-19  Tom Tromey  <tromey@adacore.com>
3367
3368         * source-cache.c (highlighter): New global.
3369         (source_cache::get_source_lines): Create a highlighter on demand.
3370
3371 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * defs.h (deprecated_interactive_hook): Delete declaration.
3374         * interps.c (clear_interpreter_hooks): Remove use of
3375         deprecated_interactive_hook.
3376         * top.c (deprecated_interactive_hook): Delete definition.
3377         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3378
3379 2019-06-18  Tom de Vries  <tdevries@suse.de>
3380
3381         PR gdb/24515
3382         * dwarf2read.h (abstract_to_concrete): Change type from
3383         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3384         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3385         * dwarf2read.c (read_variable): Update.
3386         (dwarf2_fetch_die_loc_sect_off): Update.
3387
3388 2019-06-17  Tom de Vries  <tdevries@suse.de>
3389
3390         PR gdb/24617
3391         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3392         accessing parent[parent_len - 1].
3393
3394 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3395
3396         PR gdb/24364
3397         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3398         call dtrace_process_dof with NULL dof.
3399
3400 2019-06-16  Tom de Vries  <tdevries@suse.de>
3401
3402         PR gdb/24445
3403         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3404
3405 2019-06-16  Tom Tromey  <tom@tromey.com>
3406
3407         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3408         (make_all_visible): Use address of member.
3409
3410 2019-06-16  Tom Tromey  <tom@tromey.com>
3411
3412         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3413         (tui_free_window, free_content, free_content_elements): Remove
3414         unnecessary cast.
3415         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3416         cast.
3417         * tui/tui-regs.c (tui_show_register_group)
3418         (tui_display_registers_from, tui_display_reg_element_at_line):
3419         Remove unnecessary cast.
3420
3421 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3422
3423         * linux-nat.c (normal_mask): Delete.
3424         (_initialize_linux_nat): Don't initialise normal_mask.
3425
3426 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3427
3428         PR gdb/24445
3429         * dwarf-index-write.h (write_psymtabs_to_index): Add
3430         dwz_basename parameter.
3431         * dwarf-index-write.c (write_gdbindex): Move file writing to
3432         write_gdbindex_1.  Change return type void.
3433         (assert_file_size): Move up, remove filename parameter.
3434         (write_gdbindex_1): New function.
3435         (write_debug_names): Change return type to void, call
3436         assert_file_size.
3437         (struct index_wip_file): New struct.
3438         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3439         file logic to index_wip_file.  Write index for dwz file if
3440         needed.
3441         (save_gdb_index_command): Pass basename of dwz file, if present.
3442         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3443         build-id of dwz file, if present.
3444         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3445         (dwarf2_get_dwz_file): Likewise.
3446         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3447         (dwarf2_get_dwz_file): Likewise.
3448
3449 2019-06-16  Tom Tromey  <tom@tromey.com>
3450
3451         * coffread.c (process_coff_symbol): Use xstrdup.
3452         * value.c (create_internalvar): Use xstrdup.
3453
3454 2019-06-16  Tom Tromey  <tom@tromey.com>
3455
3456         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3457         * breakpoint.c (stopin_command, stopat_command)
3458         (until_break_command, decode_location_default): Remove unnecessary
3459         cast.
3460         * utils.c (subset_compare): Remove unnecessary cast.
3461         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3462         cast.
3463         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3464         cast.
3465         * infcmd.c (path_command): Remove unnecessary cast.
3466         * coffread.c (decode_type): Remove unnecessary cast.
3467         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3468         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3469         * tui/tui-stack.c (tui_show_locator_content)
3470         (tui_show_frame_info): Remove unnecessary cast.
3471         * tui/tui-win.c (tui_scroll_forward_command)
3472         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3473         (parse_scrolling_args): Remove unnecessary cast.
3474         * tui/tui-data.c (init_win_info, tui_del_window)
3475         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3476         (free_content_elements): Remove unnecessary cast.
3477         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3478         unnecessary cast.
3479         * tui/tui-source.c (tui_set_source_content)
3480         (tui_vertical_source_scroll): Remove unnecessary cast.
3481         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3482         cast.
3483         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3484         * tui/tui-regs.c (tui_display_registers_from)
3485         (tui_display_register): Remove unnecessary cast.
3486         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3487         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3488         (make_visible): Remove unnecessary cast.
3489         * tui/tui-winsource.c (tui_erase_source_content)
3490         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3491         unnecessary cast.
3492         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3493         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3494         * stabsread.c (read_type, read_array_type, read_range_type):
3495         Remove unnecessary cast.
3496         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3497         (parse_symbol, parse_type, upgrade_type, parse_external)
3498         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3499         unnecessary cast.
3500         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3501
3502 2019-06-16  Tom Tromey  <tom@tromey.com>
3503
3504         * tui/tui-data.c (tui_alloc_generic_win_info)
3505         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3506         checks.
3507
3508 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3509             Andrew Burgess  <andrew.burgess@embecosm.com>
3510
3511         * f-typeprint.c (f_print_type): Don't return early for not
3512         associated or not allocated types.
3513         (f_type_print_varspec_suffix): Add print_rank parameter and print
3514         ranks of array types in case they dangling.
3515         (f_type_print_base): Add print_rank parameter.
3516
3517 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3518
3519         * NEWS: Mention new MI commands.
3520         * break-catch-throw.c (enum exception_event_kind): Move to
3521         breakpoint.h.
3522         (print_mention_exception_catchpoint): Output text as a single
3523         message.
3524         (catch_exception_command_1): Rename to...
3525         (catch_exception_event): ...this, make non-static, update header
3526         command, and change some parameter types.
3527         (catch_catch_command): Update for changes to
3528         catch_exception_command_1.
3529         (catch_throw_command): Likewise.
3530         (catch_rethrow_command): Likewise.
3531         * breakpoint.c (enum exception_event_kind): Delete.
3532         * breakpoint.h (enum exception_event_kind): Moved here from
3533         break-catch-throw.c.
3534         (catch_exception_event): Declare.
3535         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3536         (mi_cmd_catch_throw): New function.
3537         (mi_cmd_catch_rethrow): New function.
3538         (mi_cmd_catch_catch): New function.
3539         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3540         'catch-catch' entries.
3541         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3542         (mi_cmd_catch_rethrow): Declare.
3543         (mi_cmd_catch_catch): Declare.
3544
3545 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3546
3547         * annotate.c (annotate_source_line): Change return type to void,
3548         update implementation to match.
3549         * annotate.h (annotate_source_line): Change return type to void,
3550         update header comment.
3551         * stack.c (print_frame_info): Don't change what frame information
3552         is printed based on whether annotations are on or not.
3553
3554 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3555
3556         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3557         (annotate_source): Make static.
3558         (annotate_source_line): Moved from source.c and renamed from
3559         identify_source_line.  Update the return type.
3560         * annotate.h (annotate_source): Delete declaration.
3561         (annotate_source_line): Declaration moved from source.h, and
3562         renamed from identify_source_line.  Return type updated.
3563         * source.c (identify_source_line): Moved to annotate.c and renamed
3564         to annotate_source_line.
3565         (info_line_command): Remove check of annotation_level.
3566         * source.h (identify_source_line): Move declaration to annotate.h
3567         and rename to annotate_source_line.
3568         * stack.c: Add 'annotate.h' include.
3569         (print_frame_info): Remove check of annotation_level before
3570         calling annotate_source_line.
3571
3572 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3573
3574         * source-cache.c (source_cache::get_plain_source_lines): Use
3575         open_source_file_with_line_charpos instead of just
3576         open_source_file, remove call to find_source_lines.
3577         (source_cache::get_source_lines): Likewise.
3578         * source.c (find_source_lines): Make static.
3579         (get_filename_and_charpos): Renamed into...
3580         (open_source_file_with_line_charpos): ..this along with changes to
3581         return a scoped_fd, and some other minor clean ups.
3582         (identify_source_line): Use open_source_file_with_line_charpos.
3583         (search_command_helper): Use open_source_file_with_line_charpos
3584         instead of just open_source_file, remove call to
3585         find_source_lines.
3586         * source.h (open_source_file_with_line_charpos): Declare new
3587         function.
3588         (find_source_lines): Delete declaration.
3589
3590 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3591
3592         * source.c (get_filename_and_charpos): Remove fullname
3593         parameter.
3594         (identify_source_line): Update call to get_filename_and_charpos.
3595
3596 2019-06-14  Tom Tromey  <tromey@adacore.com>
3597
3598         PR gdb/24502:
3599         * ui-style.h (skip_ansi_escape): Update comment.
3600         * ui-file.h (class no_terminal_escape_file): New class.
3601         * ui-file.c (no_terminal_escape_file::write)
3602         (no_terminal_escape_file::puts): New methods.
3603         * cli/cli-logging.c (handle_redirections): Use
3604         no_terminal_escape_file.
3605
3606 2019-06-14  Tom Tromey  <tromey@adacore.com>
3607
3608         * NEWS: Move convenience variable news above Python news.
3609
3610 2019-06-14  Tom Tromey  <tom@tromey.com>
3611
3612         * gnulib: Move directory to top-level.
3613         * configure.ac: Don't configure gnulib.
3614         * configure: Rebuild.
3615         * common/common-defs.h: Use new path to gnulib.
3616         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3617         (GNULIB_H): Remove.
3618         (INCGNU): Look in new gnulib location.
3619         (HFILES_NO_SRCDIR): Remove gnulib files.
3620         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3621         (generated_files): Remove GNULIB_H.
3622         ($(LIBGNU), all-lib): Remove targets.
3623         (distclean): Don't mention GNULIB_BUILDDIR.
3624         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3625
3626 2019-06-14  Tom Tromey  <tromey@adacore.com>
3627
3628         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3629         Warn if symbol file does not provide any symbols.
3630
3631 2019-06-14  Tom Tromey  <tromey@adacore.com>
3632
3633         * source.c (find_and_open_source): Respect basenames_may_differ.
3634
3635 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3636
3637         * annotate.c (annotate_breakpoints_invalid): Make use of
3638         scoped_restore_terminal_state.
3639         (annotate_frames_invalid): Likewise.
3640
3641 2019-06-14  Tom Tromey  <tromey@adacore.com>
3642
3643         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3644         allow assignment to an internalvar.
3645
3646 2019-06-14  Tom Tromey  <tromey@adacore.com>
3647
3648         * ada-lex.l: Allow "_" in attribute names.
3649
3650 2019-06-14  Tom Tromey  <tromey@adacore.com>
3651
3652         PR gdb/24653:
3653         * regcache.c (registers_changed): Don't call alloca.
3654         * top.c (execute_command): Don't call alloca.
3655
3656 2019-06-13  Pedro Alves  <palves@redhat.com>
3657
3658         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3659         'expression'.  When parsing an expression, error out if there's
3660         junk after "unlimited".
3661         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3662         (do_set_command): Adjust calls to is_unlimited_literal.
3663
3664 2019-06-13  Pedro Alves  <palves@redhat.com>
3665
3666         * compile/compile.c (make_compile_options_def_group): Add braces
3667         around array_view initializer.
3668         * thread.c (make_thread_apply_all_options_def_group)
3669         (make_thread_apply_all_options_def_group): Likewise.
3670
3671 2019-06-13  Pedro Alves  <palves@redhat.com>
3672
3673         * NEWS (New commands): Mention "maint test-options
3674         require-delimiter", "maint test-options unknown-is-error", "maint
3675         test-options unknown-is-operand" and "maint show
3676         test-options-completion-result".
3677         (New command options, command completion): New section.
3678         (Completion improvements): New section.
3679         Mention that you can abbreviate "unlimited".
3680
3681 2019-06-13  Pedro Alves  <palves@redhat.com>
3682
3683         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3684         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3685         * unittests/cli-utils-selftests.c (test_parse_flags)
3686         (test_parse_flags_qcs): Delete.
3687         (test_cli_utils): Don't call deleted functions.
3688
3689 2019-06-13  Pedro Alves  <palves@redhat.com>
3690
3691         * thread.c: Include "cli/cli-option.h".
3692         (tp_array_compar_ascending): Global.
3693         (tp_array_compar): Delete function.
3694         (tp_array_compar_ascending, tp_array_compar_descending): New
3695         functions.
3696         (ascending_option_def, qcs_flag_option_def)
3697         (thr_qcs_flags_option_defs)
3698         (make_thread_apply_all_options_def_group)
3699         (make_thread_apply_options_def_group): New.
3700         (thread_apply_all_command): Use gdb::option::process_options.
3701         (thread_apply_command_completer)
3702         (thread_apply_all_command_completer): New.
3703         (thread_apply_command): Use gdb::option::process_options.
3704         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3705         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3706         to generate help text of "thread apply".  Adjust "taas"'s help.
3707         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3708         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3709
3710 2019-06-13  Pedro Alves  <palves@redhat.com>
3711
3712         * thread.c (thread_apply_command): Check for invalid TID with
3713         isdigit instead of !isalpha.
3714
3715 2019-06-13  Pedro Alves  <palves@redhat.com>
3716
3717         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3718         (validate_flags_qcs): New.
3719         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3720         (validate_flags_qcs): Declare.
3721         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3722         (make_frame_apply_options_def_group): New.
3723         (frame_apply_command_count): Process options with
3724         gdb::option::process_options.
3725         (frame_apply_completer): New.
3726         (frame_apply_level_completer, frame_apply_all_completer)
3727         (frame_apply_completer): New.
3728         (_initialize_stack): Update help of "frame apply", "frame apply
3729         level", "frame apply all" and "faas" to mention supported options
3730         and install command completers.
3731         * stack.h (frame_apply_all_completer): Declare.
3732         * thread.c: Include "stack.h".
3733         (tfaas_command): Add "--".
3734         (_initialize_thread): Update help "tfaas" to mention supported
3735         options and install command completer.
3736
3737 2019-06-13  Pedro Alves  <palves@redhat.com>
3738
3739         * completer.c (complete_nested_command_line): New.
3740         (gdb_completion_word_break_characters_throw): Add assertion.
3741         * completer.h (complete_nested_command_line): Declare.
3742
3743 2019-06-13  Pedro Alves  <palves@redhat.com>
3744
3745         * stack.c (parse_backtrace_qualifiers): New.
3746         (backtrace_command): Use it.
3747         (backtrace_command_completer): Complete on qualifiers.
3748
3749 2019-06-13  Pedro Alves  <palves@redhat.com>
3750
3751         * frame.c: Include "cli/cli-option.h.
3752         (user_set_backtrace_options): New.
3753         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3754         Delete.
3755         (get_prev_frame): Adjust.
3756         (boolean_option_def, uinteger_option_def)
3757         (set_backtrace_option_defs): New.
3758         (_initialize_frame): Adjust and use
3759         gdb::option::add_setshow_cmds_for_options to install "set
3760         backtrace past-main" and "set backtrace past-entry".
3761         * frame.h: Include "cli/cli-option.h".
3762         (struct frame_print_options): Forward declare.
3763         (print_frame_arguments_all, print_frame_arguments_scalars)
3764         (print_frame_arguments_none): Declare.
3765         (print_entry_values): Delete declaration.
3766         (struct frame_print_options, user_frame_print_options): New.
3767         (struct set_backtrace_options): New.
3768         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3769         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3770         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3771         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3772         (list_args_or_locals): Add frame_print_options parameter.
3773         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3774         * python/py-framefilter.c (enumerate_args): Pass down
3775         USER_FRAME_PRINT_OPTIONS.
3776         * stack.c: Include "cli/cli-option.h".
3777         (print_frame_arguments_all, print_frame_arguments_scalars)
3778         (print_frame_arguments_none): Declare.
3779         (print_raw_frame_arguments, print_entry_values): Delete.
3780         (user_frame_print_options): New.
3781         (boolean_option_def, enum_option_def, frame_print_option_defs):
3782         New.
3783         (struct backtrace_cmd_options): New.
3784         (bt_flag_option_def): New.
3785         (backtrace_command_option_defs): New.
3786         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3787         (print_frame_arg, read_frame_arg, print_frame_args)
3788         (print_frame_info, print_frame): Add frame_print_options parameter
3789         and use it.
3790         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3791         (backtrace_command_1): Add frame_print_options and
3792         backtrace_cmd_options parameters and use them.
3793         (make_backtrace_options_def_group): New.
3794         (backtrace_command): Process command options with
3795         gdb::option::process_options.
3796         (backtrace_command_completer): New.
3797         (_initialize_stack): Extend "backtrace"'s help to mention
3798         supported options.  Install completer for "backtrace".
3799         Install some settings commands with add_setshow_cmds_for_options.
3800
3801 2019-06-13  Pedro Alves  <palves@redhat.com>
3802
3803         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3804         and that "set/show print raw frame-arguments" are now deprecated.
3805
3806         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3807         command.
3808         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3809         * stack.c (_initialize_stack): Install "set/show print
3810         raw-frame-arguments", and deprecate "set/show print raw
3811         frame-arguments".
3812         * valprint.c (_initialize_valprint): Deprecate "set/show print
3813         raw".
3814
3815 2019-06-13  Pedro Alves  <palves@redhat.com>
3816
3817         * compile/compile.c (struct compile_options): New.
3818         (compile_flag_option_def, compile_command_option_defs)
3819         (make_compile_options_def_group): New.
3820         (compile_file_command): Handle options with
3821         gdb::option::process_options.
3822         (compile_file_command_completer): New function.
3823         (compile_code_command): Handle options with
3824         gdb::option::process_options.
3825         (compile_code_command_completer): New function.
3826         (_initialize_compiler): Install completers for "compile code" and
3827         "compile file".  Mention available options in "compile code" and
3828         "compile code"'s help.
3829         * completer.c (advance_to_completion_word): New, factored out from
3830         ...
3831         (advance_to_expression_complete_word_point): ... this.
3832         (advance_to_filename_complete_word_point): New.
3833         * completer.h (advance_to_filename_complete_word_point): New
3834         declaration.
3835
3836 2019-06-13  Pedro Alves  <palves@redhat.com>
3837
3838         * compile/compile.c: Include "cli/cli-option.h".
3839         (compile_print_value): Scope data pointer is now a
3840         value_print_options pointer; adjust.
3841         (compile_print_command): Process options.  Scope data pointer is
3842         now a value_print_options pointer; adjust.
3843         (_initialize_compile): Update "compile print"'s help to include
3844         supported options.  Install a completer for "compile print".
3845         * cp-valprint.c (show_vtblprint, show_objectprint)
3846         (show_static_field_print): Delete.
3847         (_initialize_cp_valprint): Don't install "set print
3848         static-members", "set print vtbl", "set print object" here.
3849         * printcmd.c: Include "cli/cli-option.h" and
3850         "common/gdb_optional.h".
3851         (print_command_parse_format): Rework to fill in a
3852         value_print_options instead of a format_data.
3853         (print_value): Change parameter type from format_data pointer to
3854         value_print_options reference.  Adjust.
3855         (print_command_1): Process options.  Adjust to pass down a
3856         value_print_options.
3857         (print_command_completer): New.
3858         (_initialize_printcmd): Install print_command_completer as
3859         handle_brkchars completer for the "print" command.  Update
3860         "print"'s help to include supported options.
3861         * valprint.c: Include "cli/cli-option.h".
3862         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3863         here from cp-valprint.c.
3864         (boolean_option_def, uinteger_option_def)
3865         (value_print_option_defs, make_value_print_options_def_group):
3866         New.  Use gdb::option::add_setshow_cmds_for_options to install
3867         "set print elements", "set print null-stop", "set print repeats",
3868         "set print pretty", "set print union", "set print array", "set
3869         print address", "set print symbol", "set print array-indexes".
3870         * valprint.h: Include <string> and "cli/cli-option.h".
3871         (make_value_print_options_def_group): Declare.
3872         (print_value): Change parameter type from format_data pointer to
3873         value_print_options reference.
3874         (print_command_completer): Declare.
3875
3876 2019-06-13  Pedro Alves  <palves@redhat.com>
3877
3878         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3879         (COMMON_SFILES): Add maint-test-settings.c.
3880         * cli/cli-decode.c (boolean_enums): New global, factored out from
3881         ...
3882         (add_setshow_boolean_cmd): ... here.
3883         * cli/cli-decode.h (boolean_enums): Declare.
3884         * cli/cli-option.c: New file.
3885         * cli/cli-option.h: New file.
3886         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3887         factored out from ...
3888         (parse_cli_boolean_value(const char *)): ... this.
3889         (is_unlimited_literal): Change parameter type to pointer to
3890         pointer.  Adjust and advance ARG pointer.
3891         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3892         (parse_cli_var_enum): New, factored out from ...
3893         (do_set_command): ... this.  Adjust.
3894         * cli/cli-setshow.h (parse_cli_boolean_value)
3895         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3896         (parse_cli_var_enum): Declare.
3897         * cli/cli-utils.c: Include "cli/cli-option.h".
3898         (get_ulongest): New.
3899         * cli/cli-utils.h (get_ulongest): Declare.
3900         (check_for_argument): New overloads.
3901         * maint-test-options.c: New file.
3902
3903 2019-06-13  Pedro Alves  <palves@redhat.com>
3904
3905         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3906         parse a range if "-" is at the end of the string.
3907
3908 2019-06-13  Pedro Alves  <palves@redhat.com>
3909
3910         * cli/cli-setshow.c (parse_auto_binary_operation)
3911         (parse_cli_boolean_value): Don't allow "o".
3912
3913 2019-06-13  Pedro Alves  <palves@redhat.com>
3914
3915         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3916         * NEWS: Mention maint test-settings KIND.
3917         * maint-test-settings.c: New file.
3918
3919 2019-06-13  Pedro Alves  <palves@redhat.com>
3920
3921         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3922         completer.
3923         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3924         "set" completers.
3925
3926 2019-06-13  Pedro Alves  <palves@redhat.com>
3927
3928         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3929         after item.
3930
3931 2019-06-13  Pedro Alves  <palves@redhat.com>
3932
3933         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3934
3935 2019-06-13  Pedro Alves <palves@redhat.com>
3936
3937         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3938         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3939         call.
3940         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3941         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3942         calls.
3943         (check_for_argument): Skip spaces after argument.
3944
3945 2019-06-13  Pedro Alves  <palves@redhat.com>
3946
3947         * thread.c (thread_apply_command): Adjust TID parsing.
3948         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3949         detected before end of string.
3950         (tid_is_in_list): Error out if LIST is invalid.
3951
3952 2019-06-13  Pedro Alves  <palves@redhat.com>
3953
3954         * completer.c (complete_line_internal_1): Rewind completion word
3955         point.
3956         (completion_tracker::advance_custom_word_point_by): Change
3957         parameter type to int.
3958         * completer.h (completion_tracker::advance_custom_word_point_by):
3959         Likewise.
3960
3961 2019-06-13  Pedro Alves  <palves@redhat.com>
3962
3963         * completer.c (advance_to_completion_word): Handle delimiters.
3964
3965 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3966
3967         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3968
3969 2019-06-11  Tom Tromey  <tom@tromey.com>
3970
3971         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3972         (xmalloc_failed): Move to alloc.c.
3973         * alloc.c: New file.
3974         * Makefile.in (COMMON_SFILES): Add alloc.c.
3975
3976 2019-06-11  Tom Tromey  <tom@tromey.com>
3977
3978         * nat/linux-waitpid.c: Don't include server.h.
3979         (linux_debug): Remove.
3980         (my_waitpid): Update.
3981
3982 2019-06-11  Tom Tromey  <tromey@adacore.com>
3983
3984         * infcall.c (_initialize_infcall): Remove trailing newline from
3985         help.
3986         * user-regs.c (_initialize_user_regs): Remove trailing newline
3987         from help.
3988         * typeprint.c (_initialize_typeprint): Remove trailing newline
3989         from help.
3990         * reverse.c (_initialize_reverse): Remove trailing newlines from
3991         help.
3992         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3993         from help.
3994         * language.c (add_set_language_command): Remove trailing newline
3995         from help.
3996         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3997         help.
3998         * disasm.c (_initialize_disasm): Remove trailing newline from
3999         help.
4000         * top.c (init_main): Remove trailing newline from help.
4001         * interps.c (_initialize_interpreter): Remove trailing newline
4002         from help.
4003         * btrace.c (_initialize_btrace): Remove trailing newlines from
4004         help.
4005         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4006         from help.
4007         * python/python.c (_initialize_python): Remove trailing newline
4008         from help.
4009         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4010         help.
4011         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4012         from help.  Reformat some text.
4013         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4014         from help.
4015         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4016         newline from help.
4017
4018 2019-06-11  Tom Tromey  <tromey@adacore.com>
4019
4020         * darwin-nat.c (darwin_decode_exception_message)
4021         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4022
4023 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4024
4025         * valops.c (value_slice): Check for not allocated or not
4026         associated values.
4027
4028 2019-06-10  Tom de Vries  <tdevries@suse.de>
4029
4030         PR gdb/24618
4031         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4032         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4033         invalid.
4034
4035 2019-06-10  Tom de Vries  <tdevries@suse.de>
4036
4037         PR gdb/24611
4038         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4039         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4040
4041 2019-06-10  Tom de Vries  <tdevries@suse.de>
4042
4043         PR symtab/24545
4044         * symtab.c (struct demangled_name_entry): Add language field.
4045         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4046         static minimal symbol".  Set and use language field.
4047
4048 2019-06-10  Tom Tromey  <tromey@adacore.com>
4049
4050         * ada-lang.c (_initialize_ada_language): Update help text.
4051
4052 2019-06-10  Tom Tromey  <tromey@adacore.com>
4053
4054         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4055         with a newline.
4056         * guile/guile.c (handle_boot_error): Don't end warning with a
4057         newline.
4058         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4059         warning with a newline.
4060         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4061         newline.
4062         (s12z_frame_cache): Likewise.
4063         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4064         a newline.
4065         * solib-svr4.c (disable_probes_interface): Don't end warning with
4066         a newline.
4067         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4068         newline.
4069         * python/python.c (do_finish_initialization): Don't end warning
4070         with a newline.
4071
4072 2019-06-10  Tom Tromey  <tom@tromey.com>
4073
4074         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4075         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4076         gdbpy_enter.
4077
4078 2019-06-10  Tom Tromey  <tromey@adacore.com>
4079
4080         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4081         data.
4082         (elf_new_init): Don't call stabsread_new_init.
4083         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4084         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4085         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4086
4087 2019-06-10  Tom de Vries  <tdevries@suse.de>
4088
4089         PR symtab/16264
4090         PR symtab/24517
4091         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4092
4093 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4094
4095         * source.c (find_and_open_source): Also rewrite relative file
4096         names.
4097
4098 2019-04-26  Amos Bird  <amosbird@gmail.com>
4099
4100         * annotate.c (annotate_thread_exited): Add "thread-exited"
4101         annotation.
4102
4103 2019-06-06  Tom Tromey  <tromey@adacore.com>
4104
4105         * maint.h (class scoped_command_stats): Use
4106         DISABLE_COPY_AND_ASSIGN.
4107         <print_time>: New method.
4108         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4109         print_time.
4110         (scoped_command_stats::print_time): New method.
4111
4112 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4113
4114         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4115         instructions of lengths 6 or 8 bytes.
4116
4117 2019-06-04  Pedro Alves  <palves@redhat.com>
4118
4119         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4120
4121         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4122         * breakpoint.c (condition_completer): Likewise.
4123         * cli/cli-dump.c (scan_expression): Likewise.
4124         * common/filestuff.c (mkdir_recursive): Likewise.
4125         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4126         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4127         (gdb_abspath): Likewise.
4128         * compile/compile-cplus-types.c
4129         (compile_cplus_instance::decl_name): Likewise.
4130         * completer.c (complete_explicit_location):
4131         (signal_completer, reg_or_group_completer_1): Likewise.
4132         * cp-support.c (cp_remove_params_if_any): Likewise.
4133         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4134         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4135         * infcmd.c (strip_bg_char): Likewise.
4136         * linespec.c (copy_token_string): Likewise.
4137         * mi/mi-main.c (output_cores): Likewise.
4138         * psymtab.c (psymtab_search_name):
4139         * symfile.c (test_set_ext_lang_command): Likewise.
4140         * target.c (target_fileio_read_stralloc): Likewise.
4141         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4142         * value.c (complete_internalvar): Likewise.
4143
4144 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4145
4146         Add objfile property to gdb.Type.
4147         * NEWS: Mention Python API addition.
4148         * python/py-type.c (typy_get_objfile): New method.
4149
4150 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4151
4152         * NEWS: Mention the new set|show style [title|highlight].
4153         Mention changes to "show style", "help" and "apropos".
4154
4155 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4156
4157         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4158         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4159         instead of print_help_for_command.
4160         (print_doc_of_command): New function.
4161         (help_list): Add 'apropos -v word' suggestion.
4162         (print_help_for_command): Style the command name using title style.
4163         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4164         (_initialize_cli_cmds): Describe -v in apropos_command help.
4165
4166 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4167
4168         * cli/cli-style.h (cli_style_option): Add name in constructor,
4169         add m_name class member, add constructor with intensity,
4170         add name class function.
4171         (cli_style_option::add_setshow_commands): Remove name argument.
4172         (highlight_style, title_style): New styles.
4173         * cli/cli-style.c (do_show): New function that shows a style
4174         characteristic styling the style name with itself.
4175         (set_style_name): New function.
4176         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4177         Update all callers according to the changes in cli/cli-style.h.
4178         * utils.h (fputs_highlighted): New function.
4179         * utils.c (fputs_highlighted): Likewise.
4180
4181 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4182
4183         * NEWS: Mention new pipe command and new convenience variables.
4184
4185 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4186
4187         * cli/cli-cmds.c (pipe_command): New function.
4188         (_initialize_cli_cmds): Call add_com for pipe_command.
4189         Define | as an alias for pipe.
4190         (exit_status_set_internal_vars): New function.
4191         (shell_escape): Call exit_status_set_internal_vars.
4192         cli/cli-decode.c (find_command_name_length): Recognize | as
4193         a single character command.
4194
4195 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4196
4197         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4198         top.c (execute_command_to_ui_file): New function, mostly a copy
4199         of execute_command_to_string.
4200         (execute_command_to_string): Implement by calling
4201         execute_command_to_ui_file.
4202
4203 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4204
4205         * top.h (saved_command_line): Remove declaration.
4206         * top.c (previous_saved_command_line, previous_repeat_arguments):
4207         New variables.
4208         (saved_command_line): Make static, define together with other
4209         'repeat variables'.
4210         (dont_repeat): Clear repeat_arguments.
4211         (repeat_previous, get_saved_command_line, save_command_line):
4212         New functions.
4213         (gdb_init): Initialize saved_command_line
4214         and previous_saved_command_line.
4215         * main.c (captured_main_1): Remove saved_command_line initialization.
4216         * event-top.c (handle_line_of_input): Update to use
4217         the new 'repeat' related functions instead of direct access to
4218         saved_command_line.
4219         * command.h (repeat_previous, get_saved_command_line,
4220         save_command_line): New declarations.
4221         (dont_repeat): Add comment.
4222
4223 2019-05-30  Tom Tromey  <tromey@adacore.com>
4224
4225         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4226         Fix comment.
4227         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4228
4229 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4230
4231         PR cli/24587
4232         * completer.c (complete): Initialize variable word.
4233
4234 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4235
4236         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4237         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4238         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4239         'body' is NULL to the outter 'if', protecting the '!is_define'
4240         situation as well.
4241
4242 2019-05-29  Tom Tromey  <tromey@adacore.com>
4243
4244         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4245         (dwarf_unknown): New function.
4246         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4247         (dwarf_type_encoding_name): Use dwarf_unknown.
4248
4249 2019-05-29  Tom Tromey  <tromey@adacore.com>
4250
4251         PR c++/20020:
4252         * cp-valprint.c (cp_print_value_fields): Call
4253         cp_print_static_field inside "try".
4254
4255 2019-05-29  Tom Tromey  <tromey@adacore.com>
4256
4257         * inflow.c (struct terminal_info): Add default operator=.
4258         * configure: Rebuild.
4259         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4260         -Wdeprecated-copy-dtor, -Wredundant-move.
4261
4262 2019-05-29  Tom Tromey  <tromey@adacore.com>
4263
4264         * NEWS: Add entry.
4265         * infcmd.c (print_return_value_1): Handle finish_print
4266         option.
4267         (show_print_finish): New function.
4268         (_initialize_infcmd): Add "set/show print finish" commands.
4269         * valprint.c (user_print_options): Initialize new member.
4270         * valprint.h (struct value_print_options) <finish_print>: New
4271         member.
4272
4273 2019-05-28  Tom Tromey  <tromey@adacore.com>
4274
4275         * ada-lang.c (ada_remove_Xbn_suffix)
4276         (find_old_style_renaming_symbol)
4277         (parse_old_style_renaming): Remove.
4278         (ada_find_renaming_symbol): Don't call
4279         find_old_style_renaming_symbol.
4280         (ada_is_renaming_symbol): Rename from
4281         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4282         bool.  Now static.
4283         (ada_read_var_value): Update and simplify.
4284         * ada-exp.y (write_var_or_type): Remove old code.
4285
4286 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4287
4288         * event-top.c: Remove include comment.
4289         * inflow.c (class scoped_ignore_sigttou): Move from here...
4290         * inflow.h (class scoped_ignore_sigttou): ...to here.
4291         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4292         * top.c:  Remove include comment.
4293
4294 2019-05-27  Tom Tromey  <tom@tromey.com>
4295
4296         * NEWS: Fix typo.
4297
4298 2019-05-22  Tom Tromey  <tromey@adacore.com>
4299
4300         * target.c (target_follow_exec): Constify parameter.
4301         * target-delegates.c: Rebuild.
4302         * remote.c (remote_target::follow_exec): Constify parameter.
4303         * infrun.c (follow_exec): Constify parameter.
4304         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4305         (target_follow_exec): Likewise.
4306
4307 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4308
4309         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4310         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4311
4312 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4313
4314         * NEWS: Add debugredirect and testsuite sections.
4315
4316 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4317
4318         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4319         target descriptions using exclusively floating point register name
4320         aliases.
4321
4322 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         PR gdb/18644:
4325         * f-lang.c (build_fortran_types): Handle the case where
4326         gdbarch_floatformat_for_type returns a nullptr.
4327
4328 2019-05-21  Tom de Vries  <tdevries@suse.de>
4329
4330         PR cli/24587
4331         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4332
4333 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4334
4335         PR gdb/18644:
4336         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4337         16-byte floats.
4338         * i386-tdep.c (i386_floatformat_for_type): Use
4339         floatformats_ia64_quad for the 16-byte floating point component
4340         within a fortran 32-byte complex number.
4341
4342 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4343
4344         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4345         delete default constructor.
4346         (find_partial_die): Update to return const struct.
4347         (partial_die_parent_scope): Move variable declaration into scope
4348         of its use and change its type to auto.
4349         (guess_partial_die_structure_name): Likewise.
4350         (partial_die_info::fixup): Likewise.
4351
4352 2019-05-17  Tom Tromey  <tromey@adacore.com>
4353
4354         * source.c (find_and_open_source): Remove cast.
4355
4356 2019-05-17  Tom Tromey  <tromey@adacore.com>
4357
4358         * annotate.c (annotate_source): Make "filename" const.
4359         * annotate.h (annotate_source): Use const.
4360
4361 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4362
4363         * disasm.c (set_disassembler_options): Send errors to stderr.
4364
4365 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4366
4367         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4368         (cli_interp_base::set_logging): Check debug_redirect.
4369         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4370         * cli/cli-logging.c (debug_redirect): Add static variable.
4371         (pop_output_files): Add default param.
4372         (handle_redirections): Print debug setting.
4373         (show_logging_command): Likewise.
4374         (_initialize_cli_logging): Add debugredirect command.
4375         * interps.c (current_interp_set_logging): Add debug_redirect
4376         parameter.
4377         * interps.h (set_logging): Add debug_redirect parameter.
4378         (current_interp_set_logging): Likewise.
4379         * mi/mi-common.h: Likewise.
4380         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4381
4382 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4383             Tom Tromey  <tromey@adacore.com>
4384
4385         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4386         directly.
4387         * cli/cli-interp.h (make_logging_output): Remove declaration.
4388         * cli/cli-logging.c (make_logging_output): Remove function.
4389         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4390         directly.
4391         * ui-file.c (tee_file::tee_file): Remove bools.
4392         (tee_file::~tee_file): Remove deletes.
4393         * ui-file.h (tee_file): Remove bools.
4394
4395 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4396
4397         * mi/mi-cmds.h (mi_cmd_complete): New function.
4398         * mi/mi-main.c (mi_cmd_complete): Likewise.
4399         * mi/mi-cmds.c: Define new MI command -complete.
4400         * NEWS: Mention new -complete command.
4401
4402 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4403
4404         * completer.h (complete): New function.
4405         * completer.c (complete): Likewise.
4406         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4407         function defined in completer.h.
4408
4409 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4410
4411         * MAINTAINERS (Write After Approval): Add myself.
4412
4413 2019-05-17  Tom de Vries  <tdevries@suse.de>
4414
4415         PR gdb/24094
4416         * dwarf2read.c (struct cu_partial_die_info): New struct.
4417         (find_partial_die): Return cu_partial_die_info.
4418         (partial_die_parent_scope, guess_partial_die_structure_name)
4419         (partial_die_info::fixup): Handle new return type of find_partial_die.
4420
4421 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4422
4423         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4424         "std::string", simplifying the algorithm.
4425
4426 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4427
4428         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4429         (stap_static_probe_ops::get_probes): Likewise.
4430
4431 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4432
4433         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4434         '-')" and "else if".
4435         (stap_parse_single_operand): Join checks for
4436         "gdbarch_stap_parse_special_token_p" and
4437         "gdbarch_stap_parse_special_token" in the same "if" statement.
4438         Invert check when verifying for operation on register
4439         displacement.
4440
4441 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4442
4443         * stap-probe.c (stap_get_opcode): Update comment.
4444         (stap_get_expected_argument_type): Likewise.
4445         (handle_stap_probe): Likewise.
4446
4447 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4448
4449         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4450         return type to 'bool'.  Adjust comment.  Use 'bool' when
4451         appropriate.
4452         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4453         * stap-probe.c (stap_parse_argument_1): Likewise.
4454         (stap_is_operator): Likewise.
4455         (stap_is_generic_prefix): Likewise.
4456         (stap_is_register_prefix): Likewise.
4457         (stap_is_register_indirection_prefix): Likewise.
4458         (stap_is_integer_prefix): Likewise.
4459         (stap_generic_check_suffix): Likewise.
4460         (stap_check_integer_suffix): Likewise.
4461         (stap_check_register_suffix): Likewise.
4462         (stap_check_register_indirection_suffix): Likewise.
4463         (stap_parse_register_operand): Likewise.
4464         (stap_parse_single_operand): Likewise.
4465         (stap_parse_argument_1): Likewise.
4466         (stap_probe::get_argument_count): Likewise.
4467         (stap_is_operator): Likewise.
4468
4469 2019-05-16  Tom Tromey  <tromey@adacore.com>
4470
4471         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4472         keyword to foreach.
4473
4474 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4475
4476         * linux-thread-db.c (try_thread_db_load_1): Change return type
4477         to bool.
4478         (try_thread_db_load): Likewise.
4479         (try_thread_db_load_from_pdir_1): Likewise.
4480         (try_thread_db_load_from_pdir): Likewise.
4481         (try_thread_db_load_from_sdir): Likewise.
4482         (try_thread_db_load_from_dir): Likewise.
4483         (thread_db_load_search): Likewise.
4484         (has_libpthread): Likewise.
4485         (thread_db_load): Likewise.
4486
4487 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4488
4489         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4490         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4491         NULL, and complain/return if that's the case.
4492
4493 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4494
4495         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4496         (advance, posn, abstract_read_memory): New functions.
4497         [struct mem_read_abstraction]: New struct.
4498         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4499
4500 2019-05-14  Tom Tromey  <tromey@adacore.com>
4501
4502         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4503         value is not lval_memory.
4504
4505 2019-05-14  Tom Tromey  <tromey@adacore.com>
4506
4507         * solib.c (info_sharedlibrary_command): Style the file name.
4508
4509 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4510
4511         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4512         (aarch64_vnv_type): Likewise.
4513         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4514         * common/tdesc.c: Likewise.
4515         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4516         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4517         * features/aarch64-fpu.xml: Add ieee half view.
4518         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4519         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4520         * gdbtypes.h (struct builtin_type): Likewise.
4521         (struct objfile_type): Likewise.
4522
4523 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4524
4525         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4526         typo.
4527         * location.h (string_to_event_location): Likewise.
4528
4529 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4530
4531         GDB 8.3 released.
4532
4533 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4534
4535         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4536         New variable declaration.
4537         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4538         New variable.
4539         (print_one_breakpoint): Use ui_out::test_flags and new global
4540         variable to compute use_fixed_output.
4541         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4542         Remove.
4543         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4544         (mi_multi_location_breakpoint_output_fixed): Remove.
4545         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4546         new variable.
4547         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4548         fix_multi_location_breakpoint_output flag if version >= 3.
4549         * ui-out.h (enum ui_out_flag)
4550         <fix_multi_location_breakpoint_output>: New enumerator.
4551
4552 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4553
4554         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4555
4556 2019-05-10  Tom Tromey  <tromey@adacore.com>
4557
4558         * ada-lang.c (catch_ada_completer): New function.
4559         (_initialize_ada_language): Use it.
4560
4561 2019-05-10  Tom Tromey  <tromey@adacore.com>
4562
4563         * thread.c (print_thread_info): Make "requested_threads" const.
4564         * gdbthread.h (print_thread_info): Make "requested_threads"
4565         const.
4566         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4567         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4568
4569 2019-05-08  Tom Tromey  <tom@tromey.com>
4570
4571         * gdbtypes.c (objfile_type_data): Change type.
4572         (objfile_type, _initialize_gdbtypes): Update.
4573
4574 2019-05-08  Tom Tromey  <tom@tromey.com>
4575
4576         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4577         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4578         (_initialize_dwarf2_frame): Update.
4579
4580 2019-05-08  Tom Tromey  <tom@tromey.com>
4581
4582         * objc-lang.c (objc_objfile_data): Change type.
4583         (find_methods): Update.
4584         (_initialize_objc_lang): Remove.
4585
4586 2019-05-08  Tom Tromey  <tom@tromey.com>
4587
4588         * stabsread.c (rs6000_builtin_type_data): Change type.
4589         (rs6000_builtin_type, _initialize_stabsread): Update.
4590
4591 2019-05-08  Tom Tromey  <tom@tromey.com>
4592
4593         * mips-tdep.c (mips_pdr_data): Remove.
4594         (_initialize_mips_tdep): Update.
4595
4596 2019-05-08  Tom Tromey  <tom@tromey.com>
4597
4598         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4599         (hppa_init_objfile_priv_data, read_unwind_info)
4600         (find_unwind_entry, _initialize_hppa_tdep): Update.
4601
4602 2019-05-08  Tom Tromey  <tom@tromey.com>
4603
4604         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4605         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4606         on obstack.
4607         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4608
4609 2019-05-08  Tom Tromey  <tom@tromey.com>
4610
4611         * mdebugread.c (basic_type_data): Change type.
4612         (basic_type, _initialize_mdebugread): Update.
4613
4614 2019-05-08  Tom Tromey  <tom@tromey.com>
4615
4616         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4617
4618 2019-05-08  Tom Tromey  <tom@tromey.com>
4619
4620         * nto-tdep.c (nto_inferior_data_reg): Change type.
4621         (nto_inferior_data): Update.
4622         (nto_inferior_data_cleanup, nto_new_inferior_data)
4623         (_initialize_nto_tdep): Remove.
4624         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4625
4626 2019-05-08  Tom Tromey  <tom@tromey.com>
4627
4628         * ada-lang.c (struct ada_inferior_data): Add initializers.
4629         (ada_inferior_data): Change type.
4630         (ada_inferior_data_cleanup): Remove.
4631         (get_ada_inferior_data, ada_inferior_exit)
4632         (struct ada_pspace_data): Add initializers, destructor.
4633         (ada_pspace_data_handle): Change type.
4634         (get_ada_pspace_data): Update.
4635         (ada_pspace_data_cleanup): Remove.
4636
4637 2019-05-08  Tom Tromey  <tom@tromey.com>
4638
4639         * coffread.c (struct coff_symfile_info): Add initializers.
4640         (coff_objfile_data_key): Move lower.  Change type.
4641         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4642         Update.
4643         (coff_free_info): Remove.
4644
4645 2019-05-08  Tom Tromey  <tom@tromey.com>
4646
4647         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4648         (fbsd_pspace_data_handle): Move lower.  Change type.
4649         (get_fbsd_pspace_data): Update.
4650         (fbsd_pspace_data_cleanup): Remove.
4651         (_initialize_fbsd_tdep): Update.
4652
4653 2019-05-08  Tom Tromey  <tom@tromey.com>
4654
4655         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4656         (get_ada_tasks_pspace_data): Update.
4657         (ada_tasks_pspace_data_cleanup): Remove.
4658         (_initialize_tasks): Update.
4659         (ada_tasks_inferior_data_handle): Change type.
4660         (get_ada_tasks_inferior_data): Update.
4661         (ada_tasks_inferior_data_cleanup): Remove.
4662         (struct ada_tasks_pspace_data): Add initializers.
4663
4664 2019-05-08  Tom Tromey  <tom@tromey.com>
4665
4666         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4667         * symfile-debug.c (debug_sym_get_probes): Change type.
4668         * stap-probe.c (handle_stap_probe):
4669         (stap_static_probe_ops::get_probes): Change type.
4670         * probe.h (class static_probe_ops) <get_probes>: Change type.
4671         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4672         (parse_probes_in_pspace): Update.
4673         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4674         Update.
4675         (any_static_probe_ops::get_probes): Change type.
4676         * elfread.c (elfread_data): New typedef.
4677         (probe_key): Change type.
4678         (elf_get_probes): Likewise.  Update.
4679         (probe_key_free): Remove.
4680         (_initialize_elfread): Update.
4681         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4682         Change type.
4683         (dtrace_process_dof_probe, dtrace_process_dof)
4684         (dtrace_static_probe_ops::get_probe): Change type.
4685
4686 2019-05-08  Tom Tromey  <tom@tromey.com>
4687
4688         * xcoffread.c (struct xcoff_symfile_info): Rename from
4689         coff_symfile_info.  Add initializers.
4690         (xcoff_objfile_data_key): Move lower.  Change type.
4691         (XCOFF_DATA): Rewrite.
4692         (xcoff_free_info): Remove.
4693         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4694         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4695         (xcoff_initial_scan): Update.
4696
4697 2019-05-08  Tom Tromey  <tom@tromey.com>
4698
4699         * solib-svr4.c (struct svr4_info): Add initializers and
4700         destructor.
4701         <probes_table>: Now an htab_up.
4702         (solib_svr4_pspace_data): Change type.
4703         (free_probes_table): Simplify.
4704         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4705         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4706         (probes_table_remove_objfile_probes, register_solib_event_probe)
4707         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4708         (_initialize_svr4_solib): Update.
4709
4710 2019-05-08  Tom Tromey  <tom@tromey.com>
4711
4712         * remote.c (remote_pspace_data): Change type.
4713         (remote_pspace_data_cleanup): Remove.
4714         (get_remote_exec_file, set_pspace_remote_exec_file)
4715         (_initialize_remote): Update.
4716
4717 2019-05-08  Tom Tromey  <tom@tromey.com>
4718
4719         * breakpoint.c (breakpoint_objfile_key): Change type.
4720         (get_breakpoint_objfile_data): Update.
4721         (free_breakpoint_objfile_data): Remove.
4722         (_initialize_breakpoint): Update.
4723
4724 2019-05-08  Tom Tromey  <tom@tromey.com>
4725
4726         * linux-tdep.c (struct linux_info): Add initializers.
4727         (linux_inferior_data): Move.  Change type.
4728         (invalidate_linux_cache_inf): Update.
4729         (linux_inferior_data_cleanup): Remove.
4730         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4731
4732 2019-05-08  Tom Tromey  <tom@tromey.com>
4733
4734         * auxv.c (auxv_inferior_data): Move.  Change type.
4735         (auxv_inferior_data_cleanup): Remove.
4736         (invalidate_auxv_cache_inf): Rewrite.
4737         (get_auxv_inferior_data, _initialize_auxv): Update.
4738
4739 2019-05-08  Tom Tromey  <tom@tromey.com>
4740
4741         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4742         (symfile_debug_objfile_data_key): Change type.
4743         (symfile_debug_installed, debug_qf_has_symbols)
4744         (debug_qf_find_last_source_symtab)
4745         (debug_qf_forget_cached_source_info)
4746         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4747         (debug_qf_print_stats, debug_qf_dump)
4748         (debug_qf_expand_symtabs_for_function)
4749         (debug_qf_expand_all_symtabs)
4750         (debug_qf_expand_symtabs_with_fullname)
4751         (debug_qf_map_matching_symbols)
4752         (debug_qf_expand_symtabs_matching)
4753         (debug_qf_find_pc_sect_compunit_symtab)
4754         (debug_qf_map_symbol_filenames)
4755         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4756         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4757         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4758         (debug_sym_read_linetable, debug_sym_relocate): Update.
4759         (symfile_debug_free_objfile): Remove.
4760         (install_symfile_debug_logging, _initialize_symfile_debug):
4761         Update.
4762
4763 2019-05-08  Tom Tromey  <tom@tromey.com>
4764
4765         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4766         allocate_on_obstack.
4767         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4768         (get_dwarf2_per_objfile): Update.
4769         (set_dwarf2_per_objfile): Remove.
4770         (dwarf2_has_info, dwarf2_get_section_info): Update.
4771         (dwarf2_free_objfile): Remove.
4772         (_initialize_dwarf2_read): Update.
4773
4774 2019-05-08  Tom Tromey  <tom@tromey.com>
4775
4776         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4777         initializers.
4778         <unsupported_script_warning_printed,
4779         script_not_found_warning_printed>: Now bool.
4780         (auto_load_pspace_data): Change type.
4781         (~auto_load_pspace_info): Rename from
4782         auto_load_pspace_data_cleanup.
4783         (get_auto_load_pspace_data, init_loaded_scripts_info)
4784         (clear_section_scripts, maybe_print_unsupported_script_warning)
4785         (maybe_print_script_not_found_warning, _initialize_auto_load):
4786         Update.
4787
4788 2019-05-08  Tom Tromey  <tom@tromey.com>
4789
4790         * objfiles.c (objfile_pspace_info): Add destructor and
4791         initializers.
4792         (objfiles_pspace_data): Change type.
4793         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4794         (get_objfile_pspace_data): Update.
4795         (objfiles_bfd_data): Change type.
4796         (get_objfile_bfd_data): Update.
4797         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4798
4799 2019-05-08  Tom Tromey  <tom@tromey.com>
4800
4801         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4802         Change type.
4803         (get_catch_syscall_inferior_data): Update.
4804         (catch_syscall_inferior_data_cleanup): Remove.
4805         (_initialize_break_catch_syscall): Update.
4806
4807 2019-05-08  Tom Tromey  <tom@tromey.com>
4808
4809         * inflow.c (struct terminal_info): Add destructor and
4810         initializers.
4811         (inflow_inferior_data): Change type.
4812         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4813         (get_inflow_inferior_data, inflow_inferior_exit)
4814         (swap_terminal_info, _initialize_inflow): Update.
4815
4816 2019-05-08  Tom Tromey  <tom@tromey.com>
4817
4818         * target-dcache.c (target_dcache_cleanup): Remove.
4819         (target_dcache_aspace_key): Change type.
4820         (target_dcache_init_p, target_dcache_invalidate)
4821         (target_dcache_get, target_dcache_get_or_init)
4822         (_initialize_target_dcache): Update.
4823         * dcache.h (struct dcache_deleter): New.
4824
4825 2019-05-08  Tom Tromey  <tom@tromey.com>
4826
4827         * symtab.c (struct symbol_cache): Add destructor and
4828         initializers.
4829         (symbol_cache_key): Move.  Change type.
4830         (make_symbol_cache, free_symbol_cache): Remove.
4831         (get_symbol_cache): Update.
4832         (symbol_cache_cleanup): Remove.
4833         (ALL_PSPACES, symbol_cache_flush)
4834         (maintenance_print_symbol_cache)
4835         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4836         Update.
4837
4838 2019-05-08  Tom Tromey  <tom@tromey.com>
4839
4840         * symtab.c (struct main_info): Add destructor and initializers.
4841         (main_progspace_key): Move.  Change type.
4842         (get_main_info): Update.
4843         (main_info_cleanup): Remove.
4844         (_initialize_symtab): Update.
4845
4846 2019-05-08  Tom Tromey  <tom@tromey.com>
4847
4848         * registry.h (DECLARE_REGISTRY): Define the _key class.
4849
4850 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4851
4852         * NEWS: Merge two 'New commands' sections.
4853
4854 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4855
4856         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4857         parameter and use Ada language definition instead.
4858         (ada_val_print_ptr): Remove unused language parameter.
4859         (ada_val_print_num): Remove language parameter and use Ada language
4860         definition instead.
4861         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4862         parameter.
4863         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4864         parameter and use Ada language definition instead.
4865         (ada_val_print_1): Update all ada_val_print_xxx calls.
4866         Remove language parameter.
4867         (ada_val_print): Update ada_val_print_1 call.
4868
4869 2019-05-08  Tom Tromey  <tromey@adacore.com>
4870
4871         * remote.c (remote_hw_watchpoint_limit)
4872         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4873         Now static.
4874
4875 2019-05-08  Tom Tromey  <tromey@adacore.com>
4876
4877         * maint.c (_initialize_maint_cmds): Move initialization code to
4878         remote.c.
4879         (watchdog, show_watchdog): Move to remote.c.
4880         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4881         "watchdog" static.
4882         (_initialize_remote): Move initialization code from maint.c.
4883         * defs.h (watchdog): Don't declare.
4884
4885 2019-05-08  Tom Tromey  <tromey@adacore.com>
4886
4887         * tui/tui-interp.c: Include main.h.
4888         * interps.c: Include main.h.
4889         * main.h (interpreter_p): Declare.
4890         * defs.h (interpreter_p): Don't declare.
4891
4892 2019-05-08  Tom Tromey  <tromey@adacore.com>
4893
4894         * dwarf2loc.c: Include dwarf2read.h.
4895         * defs.h (read_unsigned_leb128): Don't declare.
4896         * dwarf2read.h (read_unsigned_leb128): Declare.
4897
4898 2019-05-08  Tom Tromey  <tromey@adacore.com>
4899
4900         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4901         method.
4902
4903 2019-05-08  Tom Tromey  <tromey@adacore.com>
4904
4905         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4906         when no wrap column is set.
4907
4908 2019-05-08  Tom Tromey  <tromey@adacore.com>
4909
4910         * c-lang.c (c_get_string): Handle non-C-style arrays.
4911
4912 2019-05-08  Tom Tromey  <tromey@adacore.com>
4913
4914         * typeprint.c (print_offset_data::update): Print the bit offset,
4915         not the number of bits remaining.
4916
4917 2019-05-08  Tom Tromey  <tromey@adacore.com>
4918
4919         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4920         padding at end of comment.
4921
4922 2019-05-08  Tom Tromey  <tromey@adacore.com>
4923
4924         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4925         Compare main types.
4926
4927 2019-05-06  Tom Tromey  <tom@tromey.com>
4928
4929         * common/scoped_mmap.c: Include common-defs.h.
4930         * common/scoped_mmap.h: Don't include config.h.
4931
4932 2019-05-04  Tom Tromey  <tom@tromey.com>
4933
4934         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4935         (struct aarch64_call_info): Add initializers.
4936         <si>: Now a std::vector.
4937         (pass_on_stack, aarch64_push_dummy_call): Update.
4938
4939 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4940             Tom Tromey  <tom@tromey.com>
4941
4942         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4943         (ppc_threads): Now a std::vector.  Now static.
4944         (hwdebug_find_thread_points_by_tid)
4945         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4946         Update.
4947
4948 2019-05-04  Tom Tromey  <tom@tromey.com>
4949
4950         * arc-tdep.c (arc_tdesc_init): Return bool.
4951
4952 2019-05-04  Tom Tromey  <tom@tromey.com>
4953
4954         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4955         Use gdb_assert_not_reached.
4956
4957 2019-05-04  Tom Tromey  <tom@tromey.com>
4958
4959         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4960         "false".
4961
4962 2019-05-04  Tom Tromey  <tom@tromey.com>
4963
4964         * arc-tdep.c (arc_tdesc_init): Use bool.
4965
4966 2019-05-04  Tom Tromey  <tom@tromey.com>
4967
4968         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4969
4970 2019-05-04  Tom Tromey  <tom@tromey.com>
4971
4972         * cli/cli-cmds.c (valid_command_p): Return bool.
4973
4974 2019-05-04  Tom Tromey  <tom@tromey.com>
4975
4976         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4977         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4978
4979 2019-05-04  Raul Tambre  <raul@tambre.ee>
4980
4981         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4982         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4983         operator for comparison.
4984
4985 2019-05-04  Tom Tromey  <tom@tromey.com>
4986
4987         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4988         (lookup_partial_symbol, print_partial_symbols)
4989         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4990         (psymbol_compare): Update.
4991         (add_psymbol_to_bcache): Clear the entire psymbol.
4992         (maintenance_check_psymtabs): Update.
4993         * psympriv.h (struct partial_symbol): Don't derive from
4994         general_symbol_info.
4995         <obj_section, unrelocated_address, address,
4996         set_unrelocated_address>: Update.
4997         <ginfo>: New member.
4998         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4999         (debug_names::write_psymbols): Update.
5000
5001 2019-05-04  Tom de Vries  <tdevries@suse.de>
5002
5003         * contrib/cc-with-tweaks.sh: Support -n arg.
5004
5005 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5006
5007         * corelow.c (core_target::detach): Ensure frame cache and
5008         register caches are cleared.
5009         inferior.c (exit_inferior_1): Likewise.
5010
5011 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5012             Tom Tromey  <tom@tromey.com>
5013
5014         * dictionary.c (collate_pending_symbols_by_language): Remove
5015         "struct" from foreach.
5016         * symtab.c (lookup_global_symbol_from_objfile)
5017         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5018         foreach.
5019         * ser-tcp.c (net_open): Remove "struct" from foreach.
5020         * objfiles.c (objfile_relocate, objfile_rebase)
5021         (objfile_has_symbols): Remove "struct" from foreach.
5022         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5023         from foreach.
5024         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5025         foreach.
5026         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5027         "struct" from foreach.
5028         * ada-lang.c (create_excep_cond_exprs)
5029         (ada_exception_catchpoint_cond_string): Remove "struct" from
5030         foreach.
5031
5032 2019-05-03  Tom Tromey  <tromey@adacore.com>
5033
5034         * ada-exp.y (convert_char_literal): Check suffix of each
5035         enumerator.
5036
5037 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5038
5039         PR ada/21406:
5040         * ada-exp.y (yywrap): Don't define.
5041         * ada-lex.l (%option): Add noyywrap
5042         (yywrap): Remove.
5043
5044 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5045
5046         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5047         _WIN32_WINNT to the XP level, unless already defined to a higher
5048         level.
5049
5050         * unittests/parse-connection-spec-selftests.c:
5051         * ser-tcp.c:
5052         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5053         override.
5054
5055         * symfile.c (find_separate_debug_file): Remove colon from the
5056         drive spec of DOS/Windows file names of the target, so that the
5057         file name produced from DEBUGDIR and the target's directory will
5058         be valid on DOS/Windows systems.
5059
5060 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5061
5062         * rust-lang.c (val_print_struct): Handle printing structures
5063         containing strings.
5064
5065 2019-05-02  Tom Tromey  <tromey@adacore.com>
5066
5067         * valarith.c (_initialize_valarith): Remove.
5068
5069 2019-05-01  Tom Tromey  <tromey@adacore.com>
5070
5071         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5072         bitfields.
5073
5074 2019-05-01  Tom Tromey  <tromey@adacore.com>
5075
5076         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5077         for big-endian copies.
5078
5079 2019-04-30  Ali Tamur  <tamur@google.com>
5080         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5081         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5082         (read_3_bytes): New function.
5083
5084 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5085
5086         * windows-nat.c (main_thread_id): Delete.
5087         (handle_output_debug_string): Replace main_thread_id by
5088         current_event.dwThreadId.
5089         (fake_create_process): Likewise.
5090         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5091         Do not set main_thread_id.
5092         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5093         current_event.dwThreadId.
5094         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5095
5096 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5097
5098         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5099         Use current_event.dwThreadId instead of main_thread_id.
5100
5101 2019-04-30  Tom Tromey  <tromey@adacore.com>
5102
5103         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5104         (create_excep_cond_exprs): Iterate over program spaces.
5105         (ada_exception_catchpoint_cond_string): Examine all minimal
5106         symbols for exception types.
5107
5108 2019-04-30  Tom Tromey  <tromey@adacore.com>
5109
5110         PR c++/24470:
5111         * dwarf2read.c (process_structure_scope): Handle case where type
5112         has template parameters but no symbol was created.
5113
5114 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5115             Chris January  <chris.january@arm.com>
5116
5117         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5118         qualifier.
5119         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5120
5121 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5122
5123         * f-typeprint.c (f_print_type): Update rules for printing
5124         whitespace.
5125         (f_type_print_varspec_suffix): Likewise.
5126
5127 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5128             Chris January  <chris.january@arm.com>
5129
5130         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5131         function arguments.
5132
5133 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5134
5135         * f-lang.c (build_fortran_types): Change name of void type to
5136         lower case.
5137         * f-typeprint.c (f_type_print_base): Print the name of the void
5138         type, rather than a fixed string.
5139         * f-valprint.c (f_decorations): Use lower case void string.
5140
5141 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5142             Chris January  <chris.january@arm.com>
5143
5144         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5145         types for Fortran.
5146
5147 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5148             Chris January  <chris.january@arm.com>
5149             David Lecomber  <david.lecomber@arm.com>
5150
5151         * f-exp.y (BINOP_INTRINSIC): New token.
5152         (exp): New parser rule handling BINOP_INTRINSIC.
5153         (f77_keywords): Add new builtin procedures.
5154         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5155         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5156         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5157         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5158         (print_unop_subexp_f): New function.
5159         (print_binop_subexp_f): New function.
5160         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5161         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5162         (dump_subexp_body_f): Likewise.
5163         (operator_check_f): Likewise.
5164         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5165         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5166
5167 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5168
5169         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5170         UNOP_KIND.
5171         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5172         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5173         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5174         (operator_length_f): New fuction.
5175         (print_subexp_f): New function.
5176         (op_name_f): New function.
5177         (dump_subexp_body_f): New function.
5178         (operator_check_f): New function.
5179         (exp_descriptor_f): Replace standard expression handling functions
5180         with new functions.
5181         * gdb/fortran-operator.def: New file.
5182         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5183         * gdb/std-operator.def: Remove UNOP_KIND.
5184
5185 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5186
5187         * std-operator.def: Remove unbalanced, stray double quote
5188         character.
5189
5190 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5191             Chris January  <chris.january@arm.com>
5192             Daniel Everett  <daniel.everett@arm.com>
5193             Nick Forrington  <nick.forrington@arm.com>
5194             Richard Bunt  <richard.bunt@arm.com>
5195
5196         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5197         of depth when printing anonymous structs or unions.
5198         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5199         Don't print either the top-level value, or the children if the
5200         max-depth is exceeded.
5201         (ppscm_print_children): When printing the key of a map, allow one
5202         extra level of depth.
5203         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5204         print either the top-level value, or the children if the max-depth
5205         is exceeded.
5206         (print_children): When printing the key of a map, allow one extra
5207         level of depth.
5208         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5209         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5210         (user_print_options): Initialise max_depth field.
5211         (val_print_scalar_or_string_type_p): New function.
5212         (val_print): Check to see if the max depth has been reached.
5213         (val_print_check_max_depth): Define new function.
5214         (show_print_max_depth): New function.
5215         (_initialize_valprint): Add 'print max-depth' option.
5216         * valprint.h (struct value_print_options) <max_depth>: New field.
5217         (val_print_check_max_depth): Declare new function.
5218         * NEWS: Document new feature.
5219
5220 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5221
5222         * ada-lang.c (ada_language_defn): Initialise new field.
5223         * c-lang.c (c_is_string_type_p): New function.
5224         (c_language_defn): Initialise new field.
5225         (cplus_language_defn): Initialise new field.
5226         (asm_language_defn): Initialise new field.
5227         (minimal_language_defn): Initialise new field.
5228         * c-lang.h (c_is_string_type_p): Declare new function.
5229         * d-lang.c (d_language_defn): Initialise new field.
5230         * f-lang.c (f_is_string_type_p): New function.
5231         (f_language_defn): Initialise new field.
5232         * go-lang.c (go_is_string_type_p): New function.
5233         (go_language_defn): Initialise new field.
5234         * language.c (default_is_string_type_p): New function.
5235         (unknown_language_defn): Initialise new field.
5236         (auto_language_defn): Initialise new field.
5237         * language.h (struct language_defn) <la_is_string_type_p>: New
5238         member variable.
5239         (default_is_string_type_p): Declare new function.
5240         * m2-lang.c (m2_language_defn): Initialise new field.
5241         * objc-lang.c (objc_language_defn): Initialise new field.
5242         * opencl-lang.c (opencl_language_defn): Initialise new field.
5243         * p-lang.c (pascal_is_string_type_p): New function.
5244         (pascal_language_defn): Initialise new field.
5245         * rust-lang.c (rust_is_string_type_p): New function.
5246         (rust_language_defn): Initialise new field.
5247
5248 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5249
5250         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5251         New field.
5252         * ada-lang.c (ada_language_defn): Initialise new field.
5253         * c-lang.c (c_language_defn): Likewise.
5254         (cplus_language_defn): Likewise.
5255         (asm_language_defn): Likewise.
5256         (minimal_language_defn): Likewise.
5257         * d-lang.c (d_language_defn): Likewise.
5258         * f-lang.c (f_language_defn): Likewise.
5259         * go-lang.c (go_language_defn): Likewise.
5260         * language.c (unknown_language_defn): Likewise.
5261         (auto_language_defn): Likewise.
5262         * m2-lang.c (m2_language_defn): Likewise.
5263         * objc-lang.c (objc_language_defn): Likewise.
5264         * opencl-lang.c (opencl_language_defn): Likewise.
5265         * p-lang.c (pascal_language_defn): Likewise.
5266         * rust-lang.c (rust_language_defn): Likewise.
5267
5268 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5269
5270         * ada-lang.c (ada_is_character_type): Change return type to bool.
5271         (ada_is_string_type): Likewise.
5272         * ada-lang.h (ada_is_character_type): Update declaration
5273         (ada_is_string_type): Likewise.
5274
5275 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5276
5277         Support style in 'frame|thread apply'
5278
5279         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5280         * record.c (record_start, record_stop): Update callers of
5281         execute_command_to_string with false.
5282         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5283         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5284         methods.
5285         (class string_file): New constructor with term_out parameter.
5286         Override methods term_out and can_emit_style_escape.  New member
5287         term_out.
5288         (class stdio_file): Override can_emit_style_escape.
5289         (class tee_file): Override term_out and can_emit_style_escape.
5290         * utils.h (can_emit_style_escape): Remove.
5291         * utils.c (can_emit_style_escape): Likewise.
5292         Update all callers of can_emit_style_escape (SOMESTREAM) to
5293         SOMESTREAM->can_emit_style_escape.
5294         * source-cache.c (source_cache::get_source_lines): Likewise.
5295         * stack.c (frame_apply_command_count): Call execute_command_to_string
5296         passing the term_out characteristic of the current gdb_stdout.
5297         * thread.c (thr_try_catch_cmd): Likewise.
5298         * top.c (execute_command_to_string): pass term_out parameter
5299         to construct the string_file for the command output.
5300         * ui-file.c (term_cli_styling): New function (most code moved
5301         from utils.c can_emit_style_escape).
5302         (string_file::string_file, string_file::can_emit_style_escape,
5303         stdio_file::can_emit_style_escape, tee_file::term_out,
5304         tee_file::can_emit_style_escape): New functions.
5305
5306 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5307
5308         * NEWS: Mention the new set|show may-call-functions.
5309         * infcall.c (may_call_functions_p): New variable.
5310         (show_may_call_functions_p): New function.
5311         (call_function_by_hand_dummy): Throws an error if not
5312         may-call-functions.
5313         (_initialize_infcall): Call add_setshow_boolean_cmd for
5314         may-call-functions.
5315
5316 2019-04-25  Keith Seitz  <keiths@redhat.com>
5317
5318         PR c++/24367
5319         * cp-support.c (inspect_type): Don't attempt substitutions
5320         of symbol with the same name.
5321
5322 2019-04-25  Tom Tromey  <tromey@adacore.com>
5323
5324         PR gdb/24475:
5325         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5326         static.
5327
5328 2019-04-25  Tom Tromey  <tromey@adacore.com>
5329
5330         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5331         rvalue reference.
5332         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5333         (gdb_xml_parser::parse): Use std::move.
5334         * python/python-internal.h (gdbpy_convert_exception): Take a const
5335         reference.
5336         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5337         std::move.
5338         * python/py-utils.c (gdbpy_convert_exception): Take a const
5339         reference.
5340         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5341         Use std::move.
5342         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5343         Use std::move.
5344         * mi/mi-main.c (mi_print_exception): Take a const reference.
5345         * main.c (handle_command_errors): Take a const reference.
5346         * linespec.c (parse_linespec): Use std::move.
5347         * infcall.c (run_inferior_call): Use std::move.
5348         (call_function_by_hand_dummy): Use std::move.
5349         * exec.c (try_open_exec_file): Use std::move.
5350         * exceptions.h (exception_print, exception_fprintf)
5351         (exception_print_same): Update.
5352         * exceptions.c (print_exception, exception_print)
5353         (exception_fprintf, exception_print_same): Change parameters to
5354         const reference.
5355         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5356         * common/new-op.c: Use std::move.
5357         * common/common-exceptions.h (struct gdb_exception): Add move
5358         constructor.
5359         (struct gdb_exception_error, struct gdb_exception_quit, struct
5360         gdb_quit_bad_alloc): Change constructor to move constructor.
5361         (throw_exception): Change parameter to rvalue reference.
5362         * common/common-exceptions.c (throw_exception): Take rvalue
5363         reference.
5364         * cli/cli-interp.c (safe_execute_command): Use std::move.
5365         * breakpoint.c (insert_bp_location, location_to_sals): Use
5366         std::move.
5367
5368 2019-04-25  Tom Tromey  <tromey@adacore.com>
5369
5370         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5371         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5372         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5373         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5374         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5375         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5376         guile/scm-value.c: Use unpack.
5377         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5378         gdbscm_gdb_exception.
5379         (gdbscm_throw_gdb_exception): Likewise.
5380         (struct gdbscm_gdb_exception): New.
5381         (unpack): New function.
5382         (gdbscm_wrap): Use unpack.
5383
5384 2019-04-25  Tom Tromey  <tromey@adacore.com>
5385
5386         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5387         (gdb_rl_callback_handler): Use std::move.
5388         * common/common-exceptions.h (struct gdb_exception): Add move
5389         assignment operator.
5390         (throw_exception_sjlj): Change "exception" to const reference.
5391         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5392         (throw_exception_sjlj): Change "exception" to const reference.
5393
5394 2019-04-25  Tom Tromey  <tromey@adacore.com>
5395
5396         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5397         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5398         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5399         Update.
5400         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5401         Update.
5402         * mi/mi-interp.c (mi_interp::exec): Update.
5403         * linespec.c (parse_linespec): Update.
5404         * infcall.c (run_inferior_call): Update.
5405         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5406         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5407         (gdbscm_lookup_global_symbol): Update.
5408         * guile/scm-param.c (gdbscm_parameter_value): Update.
5409         * guile/scm-frame.c (gdbscm_frame_read_register)
5410         (gdbscm_frame_read_var): Update.
5411         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5412         * exec.c (try_open_exec_file): Update.
5413         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5414         (gdb_rl_callback_handler): Update.
5415         * common/common-exceptions.h (exception_none): Don't declare.
5416         * common/common-exceptions.c (exception_none): Don't define.
5417         (struct catcher) <exception>: Update.
5418         * cli/cli-interp.c (safe_execute_command): Update.
5419         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5420
5421 2019-04-25  Ali Tamur  <tamur@google.com>
5422
5423         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5424         (read_attribute_value): Likewise.
5425         (dwarf2_read_addr_index): Update comment.
5426         (read_str_index): Add DW_FORM_strx.
5427         (dwarf2_string_attr): Likewise.
5428         (dwarf2_const_value_attr): Likewise.
5429         (dump_die_shallow): Likewise.
5430         (dwarf2_fetch_constant_bytes): Likewise.
5431         (skip_form_bytes): Likewise.
5432         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5433
5434 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5435
5436         PR corefiles/11608
5437         PR corefiles/18187
5438         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5439         OFFSET.  Verify if current mapping contains an ELF header.
5440         (linux_find_memory_regions_full): Adjust call to
5441         dump_mapping_p.
5442
5443 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5444             Kang Li <kanglictf@gmail.com>
5445
5446         PR gdb/21600
5447
5448         * dwarf2-frame.c (read_initial_length): Be consistent about using
5449         unsigned representation of length.
5450         (decode_frame_entry_1): Likewise.  Check for wraparound of
5451         end pointer as well as buffer overflow.
5452
5453 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5454
5455         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5456         "vq".
5457
5458 2019-04-24  Tom Tromey  <tromey@adacore.com>
5459
5460         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5461
5462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5463
5464         * s12z-tdep.c (s12z_unwind_pc): Delete.
5465         (s12z_unwind_sp): Delete.
5466         (s12z_gdbarch_init): Don't register deleted functions with
5467         gdbarch.
5468
5469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5470
5471         * rl78-tdep.c (rl78_unwind_sp): Delete.
5472         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5473
5474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5475
5476         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5477         (xstormy16_unwind_pc): Delete.
5478         (xstormy16_dummy_id): Delete.
5479         (xstormy16_gdbarch_init): Don't register deleted functions with
5480         gdbarch.
5481
5482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5483
5484         * vax-tdep.c (vax_unwind_pc): Delete.
5485         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5486
5487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5488
5489         * v850-tdep.c (v850_unwind_sp): Delete.
5490         (v850_unwind_pc): Delete.
5491         (v850_dummy_id): Delete.
5492         (v850_gdbarch_init): Don't register deleted functions with
5493         gdbarch.
5494
5495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5496
5497         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5498         (tilegx_unwind_pc): Delete.
5499         (tilegx_unwind_dummy_id): Delete.
5500         (tilegx_gdbarch_init): Don't register deleted functions with
5501         gdbarch.
5502
5503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5504
5505         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5506         (tic6x_dummy_id): Delete.
5507         (tic6x_gdbarch_init): Don't register deleted functions with
5508         gdbarch.
5509
5510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5511
5512         * sparc-tdep.c (sparc_unwind_pc): Delete.
5513         (sparc32_gdbarch_init): Don't register deleted function with
5514         gdbarch.
5515
5516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5517
5518         * sh-tdep.c (sh_unwind_sp): Delete.
5519         (sh_unwind_pc): Delete.
5520         (sh_dummy_id): Delete.
5521         (sh_gdbarch_init): Don't register deleted functions with
5522         gdbarch.
5523
5524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5525
5526         * score-tdep.c (score_unwind_sp): Delete.
5527         (score_unwind_pc): Delete.
5528         (score_dummy_id): Delete.
5529         (score_gdbarch_init): Don't register deleted functions with
5530         gdbarch.
5531
5532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5533
5534         * rx-tdep.c (rx_unwind_pc): Delete.
5535         (rx_unwind_sp): Delete.
5536         (rx_dummy_id): Delete.
5537         (rx_gdbarch_init): Don't register deleted functions with
5538         gdbarch.  Update comment.
5539
5540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5541
5542         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5543         (rs6000_dummy_id): Delete.
5544         (rs6000_gdbarch_init): Don't register deleted functions with
5545         gdbarch.
5546
5547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5548
5549         * or1k-tdep.c (or1k_dummy_id): Delete.
5550         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5551
5552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5553
5554         * nios2-tdep.c (nios2_dummy_id): Delete.
5555         (nios2_unwind_sp): Delete.
5556         (nios2_gdbarch_init): Don't register deleted functions with
5557         gdbarch.
5558
5559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5560
5561         * nds32-tdep.c (nds32_dummy_id): Delete.
5562         (nds32_unwind_pc): Delete.
5563         (nds32_unwind_sp): Delete.
5564         (nds32_gdbarch_init): Don't register deleted functions with
5565         gdbarch.
5566
5567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5568
5569         * msp430-tdep.c (msp430_unwind_pc): Delete.
5570         (msp430_unwind_sp): Delete.
5571         (msp430_dummy_id): Delete.
5572         (msp430_gdbarch_init): Don't register deleted functions with
5573         gdbarch.
5574
5575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5576
5577         * moxie-tdep.c (moxie_unwind_sp): Delete.
5578         (moxie_unwind_pc): Delete.
5579         (moxie_dummy_id): Delete.
5580         (moxie_gdbarch_init): Don't register deleted functions with
5581         gdbarch.
5582
5583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5584
5585         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5586         (mn10300_unwind_pc): Delete.
5587         (mn10300_unwind_sp): Delete.
5588         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5589         mn10300_unwind_sp.
5590         (mn10300_frame_unwind_init): Don't register deleted functions with
5591         gdbarch.
5592
5593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5594
5595         * mep-tdep.c (mep_unwind_pc): Delete.
5596         (mep_unwind_sp): Delete.
5597         (mep_dummy_id): Delete.
5598         (mep_gdbarch_init): Don't register deleted functions with
5599         gdbarch.
5600
5601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5602
5603         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5604         (m68hc11_unwind_sp): Delete.
5605         (m68hc11_gdbarch_init): Don't register deleted functions with
5606         gdbarch.
5607
5608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5609
5610         * m32r-tdep.c (m32r_unwind_sp): Delete.
5611         (m32r_unwind_pc): Delete.
5612         (m32r_dummy_id): Delete.
5613         (m32r_gdbarch_init): Don't register deleted functions with
5614         gdbarch.
5615
5616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5617
5618         * m32c-tdep.c (m32c_unwind_pc): Delete.
5619         (m32c_unwind_sp): Delete.
5620         (m32c_dummy_id): Delete.
5621         (m32c_gdbarch_init): Don't register deleted functions with
5622         gdbarch.
5623
5624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5625
5626         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5627         (lm32_unwind_pc): Delete.
5628         (lm32_dummy_id): Delete.
5629         (lm32_gdbarch_init): Don't register deleted functions with
5630         gdbarch.
5631
5632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5633
5634         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5635         (iq2000_unwind_pc): Delete.
5636         (iq2000_dummy_id): Delete.
5637         (iq2000_gdbarch_init): Don't register deleted functions with
5638         gdbarch.
5639
5640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5641
5642         * nds32-tdep.c (nds32_type_align): Delete.
5643         (nds32_push_dummy_call): Use type_align instead.
5644
5645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5646
5647         * arm-tdep.c (arm_type_align): Only handle vector override case.
5648         (arm_push_dummy_call): Use type_align.
5649         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5650
5651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5652
5653         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5654         case.
5655         (pass_on_stack): Use type_align.
5656         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5657         function.
5658
5659 2019-04-23  Tom Tromey  <tromey@adacore.com>
5660
5661         * dwarf2read.c (line_header::file_name_at): Remove unused
5662         overload.
5663
5664 2019-04-23  Tom de Vries  <tdevries@suse.de>
5665
5666         PR gdb/24438
5667         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5668         invocation.
5669
5670
5671 2019-03-27  Ali Tamur  <tamur@google.com>
5672
5673         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5674         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5675         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5676         (dwarf_expr_context::get_addr_index): Likewise
5677         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5678         (symbol_needs_eval_context::get_addr_index): Likewise
5679         (disassemble_dwarf_expression): Add DW_OP_addrx
5680         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5681         (read_cutu_die_from_dwo): Update comment
5682         (skip_one_die): Add DW_FORM_addrx
5683         (read_attribute_value): Likewise
5684         (var_decode_location): Add DW_OP_addrx
5685         (dwarf2_const_value_attr): Add DW_FORM_addrx
5686         (dump_die_shallow): Likewise
5687         (dwarf2_fetch_constant_bytes): Likewise
5688         (decode_locdesc): Add DW_OP_addrx
5689         (skip_form_bytes): Add DW_FORM_addrx
5690
5691 2019-04-22  Ali Tamur  <tamur@google.com>
5692
5693         * MAINTAINERS (Write After Approval): Add self.
5694
5695 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5696
5697         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5698         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5699         (open_symbol_file_object): Likewise.
5700         (svr4_default_sos): Add info parameter.
5701         (svr4_read_so_list): Likewise.
5702         (svr4_current_sos_direct): Adjust functions calls to pass down
5703         info.
5704         (svr4_current_sos_1): Add info parameter.
5705         (svr4_current_sos): Call get_svr4_info, pass info down to
5706         svr4_current_sos_1.
5707         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5708         get_svr4_info.
5709         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5710         get_svr4_info.
5711         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5712         to get_svr4_info.
5713         (probes_table_remove_objfile_probes): Likewise.
5714         (register_solib_event_probe): Add info parameter.
5715         (solist_update_incremental): Pass info parameter down to
5716         svr4_read_so_list.
5717         (disable_probes_interface): Add info parameter.
5718         (svr4_handle_solib_event): Pass current_program_space to
5719         get_svr4_info.  Adjust disable_probes_interface cleanup.
5720         (svr4_create_probe_breakpoints): Add info parameter, pass it
5721         down to register_solib_event_probe.
5722         (svr4_create_solib_event_breakpoints): Add info parameter,
5723         pass it down to svr4_create_probe_breakpoints.
5724         (enable_break): Pass info down to
5725         svr4_create_solib_event_breakpoints.
5726         (svr4_solib_create_inferior_hook): Pass current_program_space to
5727         get_svr4_info.
5728         (svr4_clear_solib): Likewise.
5729
5730 2019-04-22  Pedro Alves  <palves@redhat.com>
5731
5732         * solib-svr4.c (svr4_free_objfile_observer): New.
5733         (probe_and_action::objfile): New field.
5734         (probes_table_htab_remove_objfile_probes)
5735         (probes_table_remove_objfile_probes): New functions.
5736         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5737         in the new probe_and_action.  Don't store the probe in 'lookup'.
5738         (svr4_create_probe_breakpoints): Pass objfile to
5739         register_solib_event_probe.
5740         (_initialize_svr4_solib): Register a free_objfile observer.
5741
5742 2019-04-19  Tom Tromey  <tom@tromey.com>
5743
5744         * common/queue.h: Remove.
5745
5746 2019-04-19  Tom Tromey  <tom@tromey.com>
5747
5748         * event-loop.c: Don't include "common/queue.h".
5749
5750 2019-04-19  Tom Tromey  <tom@tromey.com>
5751
5752         * remote.c (remote_target): Use delete.
5753         * remote-notif.h: Include <list>, not "common/queue.h".
5754         (notif_client_p): Remove typedef.
5755         (remote_notif_state): Add constructor, destructor, initializer.
5756         <notif_queue>: Now a std::list.
5757         (remote_notif_state_xfree): Don't declare.
5758         * remote-notif.c (remote_notif_process, handle_notification)
5759         (remote_notif_state_allocate): Update.
5760         (~remote_notif_state): Rename from remote_notif_state_xfree.
5761
5762 2019-04-19  Tom Tromey  <tom@tromey.com>
5763
5764         * symfile.c (reread_symbols): Update.
5765         * objfiles.c (objfile_register_static_link)
5766         (objfile_lookup_static_link): Update
5767         (~objfile) Don't delete static_links.
5768         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5769
5770 2019-04-19  Tom Tromey  <tom@tromey.com>
5771
5772         * type-stack.h (struct type_stack) <insert>: Constify string.
5773         * type-stack.c (type_stack::insert): Constify string.
5774         * gdbtypes.h (lookup_template_type): Update.
5775         (address_space_name_to_int): Update.
5776         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5777         const.
5778         (lookup_template_type): Make name const.
5779         * c-exp.y: Update rules.
5780         (lex_one_token, classify_name, classify_inner_name)
5781         (c_print_token): Update.
5782         * p-exp.y: Update rules.
5783         (yylex): Update.
5784         * f-exp.y: Update rules.
5785         (yylex): Update.
5786         * d-exp.y: Update rules.
5787         (lex_one_token, classify_name, classify_inner_name): Update.
5788         * parse.c (write_dollar_variable, copy_name): Return std::string.
5789         * parser-defs.h (copy_name): Change return type.
5790         * m2-exp.y: Update rules.
5791         (yylex): Update.
5792         * go-exp.y (lex_one_token): Update.
5793         Update rules.
5794         (classify_unsafe_function, classify_packaged_name)
5795         (classify_name, yylex): Update.
5796
5797 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5798
5799         * configure.ac: add --enable-source-highlight switch.
5800         * configure: Regenerate.
5801         * top.c (print_gdb_version): plumb --enable-source-highlight
5802         status to "show configuration".
5803
5804 2019-04-19  Tom Tromey  <tromey@adacore.com>
5805
5806         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5807         Check ADA_TYPE_P.
5808         (empty_record, ada_template_to_fixed_record_type_1)
5809         (template_to_static_fixed_type)
5810         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5811         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5812         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5813         macros.
5814
5815 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5816
5817         PR symtab/24423:
5818         * source.c (print_source_lines_base): Advance "iter" when a
5819         control character is seen.
5820
5821 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5822
5823         * inferior.h (struct infcall_suspend_state_deleter):
5824         Catch exception in destructor to avoid crash.
5825
5826 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5827
5828         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5829         close to the add_com "shell".
5830
5831 2019-04-18  Tom Tromey  <tromey@adacore.com>
5832
5833         * process-stratum-target.h (class process_stratum_target)
5834         <stratum>: Add "final".
5835
5836 2019-04-17  Tom Tromey  <tromey@adacore.com>
5837
5838         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5839         against nullptr before use.
5840
5841 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5842
5843         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5844
5845 2019-04-17  Jim Wilson  <jimw@sifive.com>
5846             Andrew Burgess  <andrew.burgess@embecosm.com>
5847
5848         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5849         code read might fail, assume 4-byte breakpoint in that case.
5850
5851 2019-04-15  Leszek Swirski  <leszeks@google.com>
5852
5853         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5854         rather than a hand-rolled POD check when checking for forced MEMORY
5855         classification.
5856
5857 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5858
5859         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5860         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5861         function.
5862         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5863         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5864         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5865         declaration.
5866
5867 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5868
5869         * aarch64-linux-nat.c
5870         (aarch64_linux_nat_target::thread_architecture): Add override.
5871         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5872         each VQ.
5873
5874 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5875
5876         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5877
5878 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5879
5880         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5881         target types of size 96-bits, add some additional comments, and
5882         check that the builtin type we found was the correct size.
5883
5884 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5885
5886         * utils.c (prompt_for_continue): Don't restore the styling at the
5887         end, as applied_style has the wrong value.  This fixes styling in
5888         long lists of file names that are interrupted by the "Continue?"
5889         prompt.
5890
5891 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5892
5893         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5894         * c-lang.c (c_language_defn): Likewise.
5895         (cplus_language_defn): Likewise.
5896         (asm_language_defn): Likewise.
5897         (minimal_language_defn): Likewise.
5898         * d-lang.c (d_language_defn): Likewise.
5899         * f-lang.c (f_language_defn): Likewise.
5900         * go-lang.c (go_language_defn): Likewise.
5901         * language.c (unknown_language_defn): Likewise.
5902         (auto_language_defn): Likewise.
5903         * language.h (struct language_defn): Remove la_magic field.
5904         (LANG_MAGIC): Delete.
5905         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5906         * objc-lang.c (objc_language_defn): Likewise.
5907         * opencl-lang.c (opencl_language_defn): Likewise.
5908         * p-lang.c (pascal_language_defn): Likewise.
5909         * rust-lang.c (rust_language_defn): Likewise.
5910
5911 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5912
5913         * riscv-tdep.c (riscv_type_align): New function.
5914         (riscv_type_alignment): Delete.
5915         (riscv_arg_location): Use 'type_align'.
5916         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5917
5918 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5919
5920         * gdbtypes.c (type_align): A struct with no non-static fields also
5921         has alignment of 1.
5922
5923 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5924
5925         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5926         component to 0.
5927         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5928         member.
5929         (riscv_struct_info::analyse): New implementation using new
5930         analyse_inner member function.
5931         (riscv_struct_info::field_offset): New member function.
5932         (riscv_struct_info::m_offsets): New member variable.
5933         (riscv_struct_info::analyse_inner): New private member function,
5934         takes the old implementation of riscv_struct_info::analyse but
5935         extended to track field offsets.
5936         (riscv_call_arg_struct): Update the struct folding special cases
5937         to handle cases where empty C++ structs, which are non-zero
5938         length, are found.
5939         (riscv_arg_location): Initialise the length of each location, a
5940         non-zero length now indicates the location is in use.
5941         (riscv_push_dummy_call): Allow for the first location having a
5942         non-zero offset when setting up arguments.
5943         (riscv_return_value): Likewise, but for return values.
5944
5945 2019-04-11  Tom Tromey  <tromey@adacore.com>
5946
5947         * utils.c (internal_vproblem): Make "msg" const.
5948
5949 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5950
5951         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5952         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5953         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5954         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5955
5956 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5957
5958         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5959         function.
5960         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5961         of amd64_collect_native_gregset.
5962         (amd64_linux_nat_target::store_registers): Likewise.
5963
5964 2019-04-10  Tom Tromey  <tom@tromey.com>
5965
5966         * symtab.c (lookup_global_symbol_from_objfile)
5967         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5968         * objfiles.h (class separate_debug_iterator): New.
5969         (class separate_debug_range): New.
5970         (struct objfile) <separate_debug_objfiles>: New method.
5971         (objfile_separate_debug_iterate): Don't declare.
5972         * objfiles.c (separate_debug_iterator::operator++): Rename from
5973         objfile_separate_debug_iterate.
5974         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5975         iterator.
5976         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5977         iterator.
5978
5979 2019-04-10  Tom Tromey  <tom@tromey.com>
5980
5981         * symfile.c (reread_symbols): Remove old comment.
5982         * objfiles.c (free_all_objfiles): Fix a typo.
5983
5984 2019-04-10  Tom Tromey  <tom@tromey.com>
5985
5986         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5987         * minsyms.c (lookup_minimal_symbol): Use foreach.
5988         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5989         (lookup_minimal_symbol_solib_trampoline): Likewise.
5990         * symfile.c (reread_symbols): Use foreach.
5991
5992 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5993             Tom Tromey  <tromey@adacore.com>
5994
5995         PR rust/24414:
5996         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5997         (rust_lex_int_test): Change "value" to be LONGEST.
5998         (rust_lex_tests): Add test for long integer literal.
5999
6000 2019-04-09  Tom Tromey  <tromey@adacore.com>
6001
6002         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6003         to bool.
6004         (extended_remote_target::attach): Update.
6005         (remote_target::remote_notice_new_inferior): Update.
6006         (remote_target::add_current_inferior_and_thread): Update.
6007         * inferior.c (exit_inferior_1): Use "false".
6008         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6009
6010 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6011
6012         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6013         the "start" command.
6014
6015 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6016
6017         * python/py-inferior.c (infpy_thread_from_thread_handle):
6018         Adjust comments to reflect renaming of thread_from_thread_handle
6019         to thread_from_handle.  Adjust keywords.  Fix type error message.
6020         (inferior_object_methods): Add thread_from_handle.  Retain
6021         thread_from_thread_handle, but mark it as deprecated.
6022
6023 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6024
6025         * gdbthread.h (find_thread_by_handle): Revise declaration.
6026         * thread.c (find_thread_by_handle): Likewise.  Adjust
6027         implementation too.
6028         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6029         support for buffer objects as handles.
6030
6031 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6032
6033         * python/py-infthread.c (thpy_thread_handle): New function.
6034         (thread_object_methods): Register thpy_thread_handle.
6035
6036 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6037
6038         * gdbthread.h (thread_to_thread_handle): Declare.
6039         * thread.c (gdbtypes.h): Include.
6040         (thread_to_thread_handle): New function.
6041
6042         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6043         (target_thread_info_to_thread_handle): Declare.
6044         * target.c (target_thread_info_to_thread_handle): New function.
6045         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6046         * target-delegates.c: Regenerate.
6047
6048         * linux-thread-db.c (class thread_db_target): Add method
6049         thread_info_to_thread_handle.
6050         (thread_db_target::thread_info_to_thread_handle): Define.
6051         * remote.c (class remote_target): Add new method
6052         thread_info_to_thread_handle.
6053         (remote_target::thread_info_to_thread_handle): Define.
6054
6055 2019-04-08  Pedro Alves  <palves@redhat.com>
6056
6057         * common/common-exceptions.c (throw_exception): Don't create
6058         named object to throw; throw directly.
6059         (throw_it): Likewise.  Don't initialize gdb_exception::message
6060         here, with new; pass FMT and AP to the ctor instead.
6061         * common/common-exceptions.h: Include <string>.
6062         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6063         const char *, va_list)): New ctor.  Use std::make_shared.
6064         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6065         errors)): Delete.
6066         (gdb_exception_error::gdb_exception_error(enum errors, const char
6067         *, va_list)): New.
6068         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6069         Add assertion.
6070         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6071         errors)): Delete.
6072         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6073         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6074         Add assertion.
6075
6076 2019-04-08  Tom Tromey  <tom@tromey.com>
6077
6078         * valops.c (value_rtti_indirect_type): Replace throw_exception
6079         with throw.
6080         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6081         with throw.
6082         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6083         throw.
6084         * target.c (target_translate_tls_address): Replace throw_exception
6085         with throw.
6086         * stack.c (frame_apply_command_count): Replace throw_exception
6087         with throw.
6088         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6089         throw.
6090         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6091         with throw.
6092         * rs6000-tdep.c (rs6000_frame_cache)
6093         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6094         * remote.c: Replace throw_exception with throw.
6095         * record-full.c (record_full_message, record_full_wait_1)
6096         (record_full_restore): Replace throw_exception with throw.
6097         * record-btrace.c:
6098         (get_thread_current_frame_id, record_btrace_start_replaying)
6099         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6100         (cmd_record_btrace_start): Replace throw_exception with throw.
6101         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6102         throw.
6103         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6104         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6105         * linespec.c:
6106         (find_linespec_symbols): Replace throw_exception with throw.
6107         * infrun.c (displaced_step_prepare, resume): Replace
6108         throw_exception with throw.
6109         * infcmd.c (post_create_inferior): Replace throw_exception with
6110         throw.
6111         * inf-loop.c (inferior_event_handler): Replace throw_exception
6112         with throw.
6113         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6114         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6115         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6116         (get_prev_frame_always, get_frame_pc_if_available)
6117         (get_frame_address_in_block_if_available, get_frame_language):
6118         Replace throw_exception with throw.
6119         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6120         throw_exception with throw.
6121         * eval.c (fetch_subexp_value, evaluate_var_value)
6122         (evaluate_funcall, evaluate_subexp_standard): Replace
6123         throw_exception with throw.
6124         * dwarf2loc.c (call_site_find_chain)
6125         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6126         Replace throw_exception with throw.
6127         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6128         with throw.
6129         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6130         throw.
6131         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6132         * completer.c (complete_line_internal): Replace throw_exception
6133         with throw.
6134         * compile/compile-object-run.c (compile_object_run): Replace
6135         throw_exception with throw.
6136         * cli/cli-script.c (process_next_line): Replace throw_exception
6137         with throw.
6138         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6139         (btrace_enable, btrace_maint_update_pt_packets): Replace
6140         throw_exception with throw.
6141         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6142         throw_exception with throw.
6143         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6144         throw_exception with throw.
6145         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6146         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6147         * aarch64-tdep.c (aarch64_make_prologue_cache)
6148         (aarch64_make_stub_cache): Replace throw_exception with throw.
6149
6150 2019-04-08  Tom Tromey  <tom@tromey.com>
6151
6152         * common/common-exceptions.c (throw_exception): Rename from
6153         throw_exception_cxx.  Remove old copy.  Make argument const.
6154         (throw_it): Create and throw exception objects directly.
6155         * common/common-exceptions.h (throw_exception): Make argument
6156         const.
6157         (struct gdb_exception_error): Add constructor.
6158         (struct gdb_exception_quit): Add constructor.
6159
6160 2019-04-08  Tom Tromey  <tom@tromey.com>
6161
6162         * common/common-exceptions.h (exception_rethrow): Don't declare.
6163         (TRY_SJLJ): Update comment.
6164         (TRY, CATCH, END_CATCH): Remove.
6165         * common/common-exceptions.c (exception_rethrow): Remove.
6166
6167 2019-04-08  Tom Tromey  <tom@tromey.com>
6168
6169         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6170         Remove.
6171         (gdb_exception_error): Rename from
6172         gdb_exception_RETURN_MASK_ERROR.
6173         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6174         (gdb_quit_bad_alloc): Update.
6175         * aarch64-tdep.c: Update.
6176         * ada-lang.c: Update.
6177         * ada-typeprint.c: Update.
6178         * ada-valprint.c: Update.
6179         * amd64-tdep.c: Update.
6180         * arch-utils.c: Update.
6181         * break-catch-throw.c: Update.
6182         * breakpoint.c: Update.
6183         * btrace.c: Update.
6184         * c-varobj.c: Update.
6185         * cli/cli-cmds.c: Update.
6186         * cli/cli-interp.c: Update.
6187         * cli/cli-script.c: Update.
6188         * common/common-exceptions.c: Update.
6189         * common/new-op.c: Update.
6190         * common/selftest.c: Update.
6191         * compile/compile-c-symbols.c: Update.
6192         * compile/compile-cplus-symbols.c: Update.
6193         * compile/compile-object-load.c: Update.
6194         * compile/compile-object-run.c: Update.
6195         * completer.c: Update.
6196         * corelow.c: Update.
6197         * cp-abi.c: Update.
6198         * cp-support.c: Update.
6199         * cp-valprint.c: Update.
6200         * darwin-nat.c: Update.
6201         * disasm-selftests.c: Update.
6202         * dtrace-probe.c: Update.
6203         * dwarf-index-cache.c: Update.
6204         * dwarf-index-write.c: Update.
6205         * dwarf2-frame-tailcall.c: Update.
6206         * dwarf2-frame.c: Update.
6207         * dwarf2loc.c: Update.
6208         * dwarf2read.c: Update.
6209         * eval.c: Update.
6210         * event-loop.c: Update.
6211         * event-top.c: Update.
6212         * exec.c: Update.
6213         * f-valprint.c: Update.
6214         * fbsd-tdep.c: Update.
6215         * frame-unwind.c: Update.
6216         * frame.c: Update.
6217         * gdbtypes.c: Update.
6218         * gnu-v3-abi.c: Update.
6219         * guile/guile-internal.h: Update.
6220         * guile/scm-block.c: Update.
6221         * guile/scm-breakpoint.c: Update.
6222         * guile/scm-cmd.c: Update.
6223         * guile/scm-disasm.c: Update.
6224         * guile/scm-frame.c: Update.
6225         * guile/scm-lazy-string.c: Update.
6226         * guile/scm-math.c: Update.
6227         * guile/scm-param.c: Update.
6228         * guile/scm-ports.c: Update.
6229         * guile/scm-pretty-print.c: Update.
6230         * guile/scm-symbol.c: Update.
6231         * guile/scm-symtab.c: Update.
6232         * guile/scm-type.c: Update.
6233         * guile/scm-value.c: Update.
6234         * i386-linux-tdep.c: Update.
6235         * i386-tdep.c: Update.
6236         * inf-loop.c: Update.
6237         * infcall.c: Update.
6238         * infcmd.c: Update.
6239         * infrun.c: Update.
6240         * jit.c: Update.
6241         * language.c: Update.
6242         * linespec.c: Update.
6243         * linux-fork.c: Update.
6244         * linux-nat.c: Update.
6245         * linux-tdep.c: Update.
6246         * linux-thread-db.c: Update.
6247         * main.c: Update.
6248         * mi/mi-cmd-break.c: Update.
6249         * mi/mi-cmd-stack.c: Update.
6250         * mi/mi-interp.c: Update.
6251         * mi/mi-main.c: Update.
6252         * objc-lang.c: Update.
6253         * p-valprint.c: Update.
6254         * parse.c: Update.
6255         * ppc-linux-tdep.c: Update.
6256         * printcmd.c: Update.
6257         * python/py-arch.c: Update.
6258         * python/py-breakpoint.c: Update.
6259         * python/py-cmd.c: Update.
6260         * python/py-finishbreakpoint.c: Update.
6261         * python/py-frame.c: Update.
6262         * python/py-framefilter.c: Update.
6263         * python/py-gdb-readline.c: Update.
6264         * python/py-inferior.c: Update.
6265         * python/py-infthread.c: Update.
6266         * python/py-lazy-string.c: Update.
6267         * python/py-linetable.c: Update.
6268         * python/py-objfile.c: Update.
6269         * python/py-param.c: Update.
6270         * python/py-prettyprint.c: Update.
6271         * python/py-progspace.c: Update.
6272         * python/py-record-btrace.c: Update.
6273         * python/py-record.c: Update.
6274         * python/py-symbol.c: Update.
6275         * python/py-type.c: Update.
6276         * python/py-unwind.c: Update.
6277         * python/py-utils.c: Update.
6278         * python/py-value.c: Update.
6279         * python/python.c: Update.
6280         * record-btrace.c: Update.
6281         * record-full.c: Update.
6282         * remote-fileio.c: Update.
6283         * remote.c: Update.
6284         * riscv-tdep.c: Update.
6285         * rs6000-aix-tdep.c: Update.
6286         * rs6000-tdep.c: Update.
6287         * rust-exp.y: Update.
6288         * rust-lang.c: Update.
6289         * s390-tdep.c: Update.
6290         * selftest-arch.c: Update.
6291         * solib-dsbt.c: Update.
6292         * solib-frv.c: Update.
6293         * solib-spu.c: Update.
6294         * solib-svr4.c: Update.
6295         * solib.c: Update.
6296         * sparc64-linux-tdep.c: Update.
6297         * stack.c: Update.
6298         * symfile-mem.c: Update.
6299         * symmisc.c: Update.
6300         * target.c: Update.
6301         * thread.c: Update.
6302         * top.c: Update.
6303         * tracefile-tfile.c: Update.
6304         * tui/tui.c: Update.
6305         * typeprint.c: Update.
6306         * unittests/cli-utils-selftests.c: Update.
6307         * unittests/parse-connection-spec-selftests.c: Update.
6308         * valops.c: Update.
6309         * valprint.c: Update.
6310         * value.c: Update.
6311         * varobj.c: Update.
6312         * windows-nat.c: Update.
6313         * x86-linux-nat.c: Update.
6314         * xml-support.c: Update.
6315
6316 2019-04-08  Tom Tromey  <tom@tromey.com>
6317
6318         * xml-support.c: Use C++ exception handling.
6319         * x86-linux-nat.c: Use C++ exception handling.
6320         * windows-nat.c: Use C++ exception handling.
6321         * varobj.c: Use C++ exception handling.
6322         * value.c: Use C++ exception handling.
6323         * valprint.c: Use C++ exception handling.
6324         * valops.c: Use C++ exception handling.
6325         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6326         handling.
6327         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6328         * typeprint.c: Use C++ exception handling.
6329         * tui/tui.c: Use C++ exception handling.
6330         * tracefile-tfile.c: Use C++ exception handling.
6331         * top.c: Use C++ exception handling.
6332         * thread.c: Use C++ exception handling.
6333         * target.c: Use C++ exception handling.
6334         * symmisc.c: Use C++ exception handling.
6335         * symfile-mem.c: Use C++ exception handling.
6336         * stack.c: Use C++ exception handling.
6337         * sparc64-linux-tdep.c: Use C++ exception handling.
6338         * solib.c: Use C++ exception handling.
6339         * solib-svr4.c: Use C++ exception handling.
6340         * solib-spu.c: Use C++ exception handling.
6341         * solib-frv.c: Use C++ exception handling.
6342         * solib-dsbt.c: Use C++ exception handling.
6343         * selftest-arch.c: Use C++ exception handling.
6344         * s390-tdep.c: Use C++ exception handling.
6345         * rust-lang.c: Use C++ exception handling.
6346         * rust-exp.y: Use C++ exception handling.
6347         * rs6000-tdep.c: Use C++ exception handling.
6348         * rs6000-aix-tdep.c: Use C++ exception handling.
6349         * riscv-tdep.c: Use C++ exception handling.
6350         * remote.c: Use C++ exception handling.
6351         * remote-fileio.c: Use C++ exception handling.
6352         * record-full.c: Use C++ exception handling.
6353         * record-btrace.c: Use C++ exception handling.
6354         * python/python.c: Use C++ exception handling.
6355         * python/py-value.c: Use C++ exception handling.
6356         * python/py-utils.c: Use C++ exception handling.
6357         * python/py-unwind.c: Use C++ exception handling.
6358         * python/py-type.c: Use C++ exception handling.
6359         * python/py-symbol.c: Use C++ exception handling.
6360         * python/py-record.c: Use C++ exception handling.
6361         * python/py-record-btrace.c: Use C++ exception handling.
6362         * python/py-progspace.c: Use C++ exception handling.
6363         * python/py-prettyprint.c: Use C++ exception handling.
6364         * python/py-param.c: Use C++ exception handling.
6365         * python/py-objfile.c: Use C++ exception handling.
6366         * python/py-linetable.c: Use C++ exception handling.
6367         * python/py-lazy-string.c: Use C++ exception handling.
6368         * python/py-infthread.c: Use C++ exception handling.
6369         * python/py-inferior.c: Use C++ exception handling.
6370         * python/py-gdb-readline.c: Use C++ exception handling.
6371         * python/py-framefilter.c: Use C++ exception handling.
6372         * python/py-frame.c: Use C++ exception handling.
6373         * python/py-finishbreakpoint.c: Use C++ exception handling.
6374         * python/py-cmd.c: Use C++ exception handling.
6375         * python/py-breakpoint.c: Use C++ exception handling.
6376         * python/py-arch.c: Use C++ exception handling.
6377         * printcmd.c: Use C++ exception handling.
6378         * ppc-linux-tdep.c: Use C++ exception handling.
6379         * parse.c: Use C++ exception handling.
6380         * p-valprint.c: Use C++ exception handling.
6381         * objc-lang.c: Use C++ exception handling.
6382         * mi/mi-main.c: Use C++ exception handling.
6383         * mi/mi-interp.c: Use C++ exception handling.
6384         * mi/mi-cmd-stack.c: Use C++ exception handling.
6385         * mi/mi-cmd-break.c: Use C++ exception handling.
6386         * main.c: Use C++ exception handling.
6387         * linux-thread-db.c: Use C++ exception handling.
6388         * linux-tdep.c: Use C++ exception handling.
6389         * linux-nat.c: Use C++ exception handling.
6390         * linux-fork.c: Use C++ exception handling.
6391         * linespec.c: Use C++ exception handling.
6392         * language.c: Use C++ exception handling.
6393         * jit.c: Use C++ exception handling.
6394         * infrun.c: Use C++ exception handling.
6395         * infcmd.c: Use C++ exception handling.
6396         * infcall.c: Use C++ exception handling.
6397         * inf-loop.c: Use C++ exception handling.
6398         * i386-tdep.c: Use C++ exception handling.
6399         * i386-linux-tdep.c: Use C++ exception handling.
6400         * guile/scm-value.c: Use C++ exception handling.
6401         * guile/scm-type.c: Use C++ exception handling.
6402         * guile/scm-symtab.c: Use C++ exception handling.
6403         * guile/scm-symbol.c: Use C++ exception handling.
6404         * guile/scm-pretty-print.c: Use C++ exception handling.
6405         * guile/scm-ports.c: Use C++ exception handling.
6406         * guile/scm-param.c: Use C++ exception handling.
6407         * guile/scm-math.c: Use C++ exception handling.
6408         * guile/scm-lazy-string.c: Use C++ exception handling.
6409         * guile/scm-frame.c: Use C++ exception handling.
6410         * guile/scm-disasm.c: Use C++ exception handling.
6411         * guile/scm-cmd.c: Use C++ exception handling.
6412         * guile/scm-breakpoint.c: Use C++ exception handling.
6413         * guile/scm-block.c: Use C++ exception handling.
6414         * guile/guile-internal.h: Use C++ exception handling.
6415         * gnu-v3-abi.c: Use C++ exception handling.
6416         * gdbtypes.c: Use C++ exception handling.
6417         * frame.c: Use C++ exception handling.
6418         * frame-unwind.c: Use C++ exception handling.
6419         * fbsd-tdep.c: Use C++ exception handling.
6420         * f-valprint.c: Use C++ exception handling.
6421         * exec.c: Use C++ exception handling.
6422         * event-top.c: Use C++ exception handling.
6423         * event-loop.c: Use C++ exception handling.
6424         * eval.c: Use C++ exception handling.
6425         * dwarf2read.c: Use C++ exception handling.
6426         * dwarf2loc.c: Use C++ exception handling.
6427         * dwarf2-frame.c: Use C++ exception handling.
6428         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6429         * dwarf-index-write.c: Use C++ exception handling.
6430         * dwarf-index-cache.c: Use C++ exception handling.
6431         * dtrace-probe.c: Use C++ exception handling.
6432         * disasm-selftests.c: Use C++ exception handling.
6433         * darwin-nat.c: Use C++ exception handling.
6434         * cp-valprint.c: Use C++ exception handling.
6435         * cp-support.c: Use C++ exception handling.
6436         * cp-abi.c: Use C++ exception handling.
6437         * corelow.c: Use C++ exception handling.
6438         * completer.c: Use C++ exception handling.
6439         * compile/compile-object-run.c: Use C++ exception handling.
6440         * compile/compile-object-load.c: Use C++ exception handling.
6441         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6442         * compile/compile-c-symbols.c: Use C++ exception handling.
6443         * common/selftest.c: Use C++ exception handling.
6444         * common/new-op.c: Use C++ exception handling.
6445         * cli/cli-script.c: Use C++ exception handling.
6446         * cli/cli-interp.c: Use C++ exception handling.
6447         * cli/cli-cmds.c: Use C++ exception handling.
6448         * c-varobj.c: Use C++ exception handling.
6449         * btrace.c: Use C++ exception handling.
6450         * breakpoint.c: Use C++ exception handling.
6451         * break-catch-throw.c: Use C++ exception handling.
6452         * arch-utils.c: Use C++ exception handling.
6453         * amd64-tdep.c: Use C++ exception handling.
6454         * ada-valprint.c: Use C++ exception handling.
6455         * ada-typeprint.c: Use C++ exception handling.
6456         * ada-lang.c: Use C++ exception handling.
6457         * aarch64-tdep.c: Use C++ exception handling.
6458
6459 2019-04-08  Tom Tromey  <tom@tromey.com>
6460
6461         * xml-support.c (gdb_xml_parser::parse): Update.
6462         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6463         * value.c (show_convenience): Update.
6464         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6465         (test_parse_flags_qcs): Update.
6466         * thread.c (thr_try_catch_cmd): Update.
6467         * target.c (target_translate_tls_address): Update.
6468         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6469         (info_frame_command_core, frame_apply_command_count): Update.
6470         * rust-exp.y (rust_lex_exception_test): Update.
6471         * riscv-tdep.c (riscv_print_one_register_info): Update.
6472         * remote.c (remote_target::enable_btrace): Update.
6473         * record-btrace.c (record_btrace_enable_warn): Update.
6474         * python/py-utils.c (gdbpy_convert_exception): Update.
6475         * printcmd.c (do_one_display, print_variable_and_value): Update.
6476         * mi/mi-main.c (mi_print_exception): Update.
6477         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6478         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6479         * linux-nat.c (linux_nat_target::attach): Update.
6480         * linux-fork.c (class scoped_switch_fork_info): Update.
6481         * infrun.c (displaced_step_prepare): Update.
6482         * infcall.c (call_function_by_hand_dummy): Update.
6483         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6484         * gnu-v3-abi.c (print_one_vtable): Update.
6485         * frame.c (get_prev_frame_always): Update.
6486         * f-valprint.c (info_common_command_for_block): Update.
6487         * exec.c (try_open_exec_file): Update.
6488         * exceptions.c (print_exception, exception_print)
6489         (exception_fprintf, exception_print_same): Update.
6490         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6491         * dwarf-index-cache.c (index_cache::store)
6492         (index_cache::lookup_gdb_index): Update.
6493         * darwin-nat.c (maybe_cache_shell): Update.
6494         * cp-valprint.c (cp_print_value_fields): Update.
6495         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6496         (gcc_cplus_symbol_address): Update.
6497         * compile/compile-c-symbols.c (gcc_convert_symbol)
6498         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6499         * common/selftest.c: Update.
6500         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6501         a std::string.
6502         (exception_try_scope_entry, exception_try_scope_exit): Don't
6503         declare.
6504         (struct exception_try_scope): Remove.
6505         (TRY): Don't use exception_try_scope.
6506         (struct gdb_exception): Add constructor, operator=.
6507         <what>: New method.
6508         (struct gdb_exception_RETURN_MASK_ALL)
6509         (struct gdb_exception_RETURN_MASK_ERROR)
6510         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6511         (struct gdb_quit_bad_alloc): Update.
6512         * common/common-exceptions.c (exception_none): Change
6513         initializer.
6514         (struct catcher) <state, exception>: Initialize inline.
6515         <prev>: Remove member.
6516         (current_catcher): Remove.
6517         (catchers): New global.
6518         (exceptions_state_mc_init): Simplify.
6519         (catcher_pop): Remove.
6520         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6521         (try_scope_depth, exception_try_scope_entry)
6522         (exception_try_scope_exit): Remove.
6523         (throw_exception_sjlj): Update.
6524         (exception_messages, exception_messages_size): Remove.
6525         (throw_it): Simplify.
6526         (gdb_exception_sliced_copy): Remove.
6527         (throw_exception_cxx): Update.
6528         * cli/cli-script.c (script_from_file): Update.
6529         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6530         Update.
6531         * ada-valprint.c (ada_val_print): Update.
6532         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6533         (create_excep_cond_exprs): Update.
6534
6535 2019-04-08  Tom Tromey  <tom@tromey.com>
6536
6537         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6538         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6539         (TRY, CATCH, END_CATCH): Remove some definitions.
6540         * common/common-exceptions.c: Don't use GDB_XCPT.
6541         (catcher_list_size): Remove.
6542         (throw_exception, throw_it): Simplify.
6543
6544 2019-04-05  Tom Tromey  <tom@tromey.com>
6545
6546         Revert the header-sorting patch.
6547         * ft32-tdep.c: Revert.
6548         * frv-tdep.c: Revert.
6549         * frv-linux-tdep.c: Revert.
6550         * frame.c: Revert.
6551         * frame-unwind.c: Revert.
6552         * frame-base.c: Revert.
6553         * fork-child.c: Revert.
6554         * findvar.c: Revert.
6555         * findcmd.c: Revert.
6556         * filesystem.c: Revert.
6557         * filename-seen-cache.h: Revert.
6558         * filename-seen-cache.c: Revert.
6559         * fbsd-tdep.c: Revert.
6560         * fbsd-nat.h: Revert.
6561         * fbsd-nat.c: Revert.
6562         * f-valprint.c: Revert.
6563         * f-typeprint.c: Revert.
6564         * f-lang.c: Revert.
6565         * extension.h: Revert.
6566         * extension.c: Revert.
6567         * extension-priv.h: Revert.
6568         * expprint.c: Revert.
6569         * exec.h: Revert.
6570         * exec.c: Revert.
6571         * exceptions.c: Revert.
6572         * event-top.c: Revert.
6573         * event-loop.c: Revert.
6574         * eval.c: Revert.
6575         * elfread.c: Revert.
6576         * dwarf2read.h: Revert.
6577         * dwarf2read.c: Revert.
6578         * dwarf2loc.c: Revert.
6579         * dwarf2expr.h: Revert.
6580         * dwarf2expr.c: Revert.
6581         * dwarf2-frame.c: Revert.
6582         * dwarf2-frame-tailcall.c: Revert.
6583         * dwarf-index-write.h: Revert.
6584         * dwarf-index-write.c: Revert.
6585         * dwarf-index-common.c: Revert.
6586         * dwarf-index-cache.h: Revert.
6587         * dwarf-index-cache.c: Revert.
6588         * dummy-frame.c: Revert.
6589         * dtrace-probe.c: Revert.
6590         * disasm.h: Revert.
6591         * disasm.c: Revert.
6592         * disasm-selftests.c: Revert.
6593         * dictionary.c: Revert.
6594         * dicos-tdep.c: Revert.
6595         * demangle.c: Revert.
6596         * dcache.h: Revert.
6597         * dcache.c: Revert.
6598         * darwin-nat.h: Revert.
6599         * darwin-nat.c: Revert.
6600         * darwin-nat-info.c: Revert.
6601         * d-valprint.c: Revert.
6602         * d-namespace.c: Revert.
6603         * d-lang.c: Revert.
6604         * ctf.c: Revert.
6605         * csky-tdep.c: Revert.
6606         * csky-linux-tdep.c: Revert.
6607         * cris-tdep.c: Revert.
6608         * cris-linux-tdep.c: Revert.
6609         * cp-valprint.c: Revert.
6610         * cp-support.c: Revert.
6611         * cp-namespace.c: Revert.
6612         * cp-abi.c: Revert.
6613         * corelow.c: Revert.
6614         * corefile.c: Revert.
6615         * continuations.c: Revert.
6616         * completer.h: Revert.
6617         * completer.c: Revert.
6618         * complaints.c: Revert.
6619         * coffread.c: Revert.
6620         * coff-pe-read.c: Revert.
6621         * cli-out.h: Revert.
6622         * cli-out.c: Revert.
6623         * charset.c: Revert.
6624         * c-varobj.c: Revert.
6625         * c-valprint.c: Revert.
6626         * c-typeprint.c: Revert.
6627         * c-lang.c: Revert.
6628         * buildsym.c: Revert.
6629         * buildsym-legacy.c: Revert.
6630         * build-id.h: Revert.
6631         * build-id.c: Revert.
6632         * btrace.c: Revert.
6633         * bsd-uthread.c: Revert.
6634         * breakpoint.h: Revert.
6635         * breakpoint.c: Revert.
6636         * break-catch-throw.c: Revert.
6637         * break-catch-syscall.c: Revert.
6638         * break-catch-sig.c: Revert.
6639         * blockframe.c: Revert.
6640         * block.c: Revert.
6641         * bfin-tdep.c: Revert.
6642         * bfin-linux-tdep.c: Revert.
6643         * bfd-target.c: Revert.
6644         * bcache.c: Revert.
6645         * ax-general.c: Revert.
6646         * ax-gdb.h: Revert.
6647         * ax-gdb.c: Revert.
6648         * avr-tdep.c: Revert.
6649         * auxv.c: Revert.
6650         * auto-load.c: Revert.
6651         * arm-wince-tdep.c: Revert.
6652         * arm-tdep.c: Revert.
6653         * arm-symbian-tdep.c: Revert.
6654         * arm-pikeos-tdep.c: Revert.
6655         * arm-obsd-tdep.c: Revert.
6656         * arm-nbsd-tdep.c: Revert.
6657         * arm-nbsd-nat.c: Revert.
6658         * arm-linux-tdep.c: Revert.
6659         * arm-linux-nat.c: Revert.
6660         * arm-fbsd-tdep.c: Revert.
6661         * arm-fbsd-nat.c: Revert.
6662         * arm-bsd-tdep.c: Revert.
6663         * arch-utils.c: Revert.
6664         * arc-tdep.c: Revert.
6665         * arc-newlib-tdep.c: Revert.
6666         * annotate.h: Revert.
6667         * annotate.c: Revert.
6668         * amd64-windows-tdep.c: Revert.
6669         * amd64-windows-nat.c: Revert.
6670         * amd64-tdep.c: Revert.
6671         * amd64-sol2-tdep.c: Revert.
6672         * amd64-obsd-tdep.c: Revert.
6673         * amd64-obsd-nat.c: Revert.
6674         * amd64-nbsd-tdep.c: Revert.
6675         * amd64-nbsd-nat.c: Revert.
6676         * amd64-nat.c: Revert.
6677         * amd64-linux-tdep.c: Revert.
6678         * amd64-linux-nat.c: Revert.
6679         * amd64-fbsd-tdep.c: Revert.
6680         * amd64-fbsd-nat.c: Revert.
6681         * amd64-dicos-tdep.c: Revert.
6682         * amd64-darwin-tdep.c: Revert.
6683         * amd64-bsd-nat.c: Revert.
6684         * alpha-tdep.c: Revert.
6685         * alpha-obsd-tdep.c: Revert.
6686         * alpha-nbsd-tdep.c: Revert.
6687         * alpha-mdebug-tdep.c: Revert.
6688         * alpha-linux-tdep.c: Revert.
6689         * alpha-linux-nat.c: Revert.
6690         * alpha-bsd-tdep.c: Revert.
6691         * alpha-bsd-nat.c: Revert.
6692         * aix-thread.c: Revert.
6693         * agent.c: Revert.
6694         * addrmap.c: Revert.
6695         * ada-varobj.c: Revert.
6696         * ada-valprint.c: Revert.
6697         * ada-typeprint.c: Revert.
6698         * ada-tasks.c: Revert.
6699         * ada-lang.c: Revert.
6700         * aarch64-tdep.c: Revert.
6701         * aarch64-ravenscar-thread.c: Revert.
6702         * aarch64-newlib-tdep.c: Revert.
6703         * aarch64-linux-tdep.c: Revert.
6704         * aarch64-linux-nat.c: Revert.
6705         * aarch64-fbsd-tdep.c: Revert.
6706         * aarch64-fbsd-nat.c: Revert.
6707         * aarch32-linux-nat.c: Revert.
6708
6709 2019-04-05  Tom Tromey  <tom@tromey.com>
6710
6711         * ft32-tdep.c: Sort headers.
6712         * frv-tdep.c: Sort headers.
6713         * frv-linux-tdep.c: Sort headers.
6714         * frame.c: Sort headers.
6715         * frame-unwind.c: Sort headers.
6716         * frame-base.c: Sort headers.
6717         * fork-child.c: Sort headers.
6718         * findvar.c: Sort headers.
6719         * findcmd.c: Sort headers.
6720         * filesystem.c: Sort headers.
6721         * filename-seen-cache.h: Sort headers.
6722         * filename-seen-cache.c: Sort headers.
6723         * fbsd-tdep.c: Sort headers.
6724         * fbsd-nat.h: Sort headers.
6725         * fbsd-nat.c: Sort headers.
6726         * f-valprint.c: Sort headers.
6727         * f-typeprint.c: Sort headers.
6728         * f-lang.c: Sort headers.
6729         * extension.h: Sort headers.
6730         * extension.c: Sort headers.
6731         * extension-priv.h: Sort headers.
6732         * expprint.c: Sort headers.
6733         * exec.h: Sort headers.
6734         * exec.c: Sort headers.
6735         * exceptions.c: Sort headers.
6736         * event-top.c: Sort headers.
6737         * event-loop.c: Sort headers.
6738         * eval.c: Sort headers.
6739         * elfread.c: Sort headers.
6740         * dwarf2read.h: Sort headers.
6741         * dwarf2read.c: Sort headers.
6742         * dwarf2loc.c: Sort headers.
6743         * dwarf2expr.h: Sort headers.
6744         * dwarf2expr.c: Sort headers.
6745         * dwarf2-frame.c: Sort headers.
6746         * dwarf2-frame-tailcall.c: Sort headers.
6747         * dwarf-index-write.h: Sort headers.
6748         * dwarf-index-write.c: Sort headers.
6749         * dwarf-index-common.c: Sort headers.
6750         * dwarf-index-cache.h: Sort headers.
6751         * dwarf-index-cache.c: Sort headers.
6752         * dummy-frame.c: Sort headers.
6753         * dtrace-probe.c: Sort headers.
6754         * disasm.h: Sort headers.
6755         * disasm.c: Sort headers.
6756         * disasm-selftests.c: Sort headers.
6757         * dictionary.c: Sort headers.
6758         * dicos-tdep.c: Sort headers.
6759         * demangle.c: Sort headers.
6760         * dcache.h: Sort headers.
6761         * dcache.c: Sort headers.
6762         * darwin-nat.h: Sort headers.
6763         * darwin-nat.c: Sort headers.
6764         * darwin-nat-info.c: Sort headers.
6765         * d-valprint.c: Sort headers.
6766         * d-namespace.c: Sort headers.
6767         * d-lang.c: Sort headers.
6768         * ctf.c: Sort headers.
6769         * csky-tdep.c: Sort headers.
6770         * csky-linux-tdep.c: Sort headers.
6771         * cris-tdep.c: Sort headers.
6772         * cris-linux-tdep.c: Sort headers.
6773         * cp-valprint.c: Sort headers.
6774         * cp-support.c: Sort headers.
6775         * cp-namespace.c: Sort headers.
6776         * cp-abi.c: Sort headers.
6777         * corelow.c: Sort headers.
6778         * corefile.c: Sort headers.
6779         * continuations.c: Sort headers.
6780         * completer.h: Sort headers.
6781         * completer.c: Sort headers.
6782         * complaints.c: Sort headers.
6783         * coffread.c: Sort headers.
6784         * coff-pe-read.c: Sort headers.
6785         * cli-out.h: Sort headers.
6786         * cli-out.c: Sort headers.
6787         * charset.c: Sort headers.
6788         * c-varobj.c: Sort headers.
6789         * c-valprint.c: Sort headers.
6790         * c-typeprint.c: Sort headers.
6791         * c-lang.c: Sort headers.
6792         * buildsym.c: Sort headers.
6793         * buildsym-legacy.c: Sort headers.
6794         * build-id.h: Sort headers.
6795         * build-id.c: Sort headers.
6796         * btrace.c: Sort headers.
6797         * bsd-uthread.c: Sort headers.
6798         * breakpoint.h: Sort headers.
6799         * breakpoint.c: Sort headers.
6800         * break-catch-throw.c: Sort headers.
6801         * break-catch-syscall.c: Sort headers.
6802         * break-catch-sig.c: Sort headers.
6803         * blockframe.c: Sort headers.
6804         * block.c: Sort headers.
6805         * bfin-tdep.c: Sort headers.
6806         * bfin-linux-tdep.c: Sort headers.
6807         * bfd-target.c: Sort headers.
6808         * bcache.c: Sort headers.
6809         * ax-general.c: Sort headers.
6810         * ax-gdb.h: Sort headers.
6811         * ax-gdb.c: Sort headers.
6812         * avr-tdep.c: Sort headers.
6813         * auxv.c: Sort headers.
6814         * auto-load.c: Sort headers.
6815         * arm-wince-tdep.c: Sort headers.
6816         * arm-tdep.c: Sort headers.
6817         * arm-symbian-tdep.c: Sort headers.
6818         * arm-pikeos-tdep.c: Sort headers.
6819         * arm-obsd-tdep.c: Sort headers.
6820         * arm-nbsd-tdep.c: Sort headers.
6821         * arm-nbsd-nat.c: Sort headers.
6822         * arm-linux-tdep.c: Sort headers.
6823         * arm-linux-nat.c: Sort headers.
6824         * arm-fbsd-tdep.c: Sort headers.
6825         * arm-fbsd-nat.c: Sort headers.
6826         * arm-bsd-tdep.c: Sort headers.
6827         * arch-utils.c: Sort headers.
6828         * arc-tdep.c: Sort headers.
6829         * arc-newlib-tdep.c: Sort headers.
6830         * annotate.h: Sort headers.
6831         * annotate.c: Sort headers.
6832         * amd64-windows-tdep.c: Sort headers.
6833         * amd64-windows-nat.c: Sort headers.
6834         * amd64-tdep.c: Sort headers.
6835         * amd64-sol2-tdep.c: Sort headers.
6836         * amd64-obsd-tdep.c: Sort headers.
6837         * amd64-obsd-nat.c: Sort headers.
6838         * amd64-nbsd-tdep.c: Sort headers.
6839         * amd64-nbsd-nat.c: Sort headers.
6840         * amd64-nat.c: Sort headers.
6841         * amd64-linux-tdep.c: Sort headers.
6842         * amd64-linux-nat.c: Sort headers.
6843         * amd64-fbsd-tdep.c: Sort headers.
6844         * amd64-fbsd-nat.c: Sort headers.
6845         * amd64-dicos-tdep.c: Sort headers.
6846         * amd64-darwin-tdep.c: Sort headers.
6847         * amd64-bsd-nat.c: Sort headers.
6848         * alpha-tdep.c: Sort headers.
6849         * alpha-obsd-tdep.c: Sort headers.
6850         * alpha-nbsd-tdep.c: Sort headers.
6851         * alpha-mdebug-tdep.c: Sort headers.
6852         * alpha-linux-tdep.c: Sort headers.
6853         * alpha-linux-nat.c: Sort headers.
6854         * alpha-bsd-tdep.c: Sort headers.
6855         * alpha-bsd-nat.c: Sort headers.
6856         * aix-thread.c: Sort headers.
6857         * agent.c: Sort headers.
6858         * addrmap.c: Sort headers.
6859         * ada-varobj.c: Sort headers.
6860         * ada-valprint.c: Sort headers.
6861         * ada-typeprint.c: Sort headers.
6862         * ada-tasks.c: Sort headers.
6863         * ada-lang.c: Sort headers.
6864         * aarch64-tdep.c: Sort headers.
6865         * aarch64-ravenscar-thread.c: Sort headers.
6866         * aarch64-newlib-tdep.c: Sort headers.
6867         * aarch64-linux-tdep.c: Sort headers.
6868         * aarch64-linux-nat.c: Sort headers.
6869         * aarch64-fbsd-tdep.c: Sort headers.
6870         * aarch64-fbsd-nat.c: Sort headers.
6871         * aarch32-linux-nat.c: Sort headers.
6872
6873 2019-04-04  Tom Tromey  <tom@tromey.com>
6874
6875         * varobj.c (varobj_create): Update.
6876         * rust-exp.y (struct rust_parser) <update_innermost_block,
6877         lookup_symbol>: New methods.
6878         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6879         Rename.
6880         (rust_parser::rust_lookup_type)
6881         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6882         * printcmd.c (display_command, do_one_display): Update.
6883         * parser-defs.h (struct parser_state) <parser_state>: Add
6884         "tracker" parameter.
6885         (block_tracker): New member.
6886         (class innermost_block_tracker) <innermost_block_tracker>: Add
6887         "types" parameter.
6888         <reset>: Remove method.
6889         (innermost_block): Don't declare.
6890         (null_post_parser): Update.
6891         * parse.c (innermost_block): Remove global.
6892         (write_dollar_variable): Update.
6893         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6894         Remove "tracker_types" parameter.
6895         (parse_expression): Add "tracker" parameter.
6896         (parse_expression_for_completion): Update.
6897         (null_post_parser): Add "tracker" parameter.
6898         * p-exp.y: Update rules.
6899         * m2-exp.y: Update rules.
6900         * language.h (struct language_defn) <la_post_parser>: Add
6901         "tracker" parameter.
6902         * go-exp.y: Update rules.
6903         * f-exp.y: Update rules.
6904         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6905         parameter.
6906         * d-exp.y: Update rules.
6907         * c-exp.y: Update rules.
6908         * breakpoint.c (set_breakpoint_condition): Create an
6909         innermost_block_tracker.
6910         (watch_command_1): Likewise.
6911         * ada-lang.c (resolve): Add "tracker" parameter.
6912         (resolve_subexp): Likewise.
6913         * ada-exp.y (write_var_from_sym): Update.
6914
6915 2019-04-04  Tom Tromey  <tom@tromey.com>
6916
6917         * type-stack.h: New file.
6918         * type-stack.c: New file.
6919         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6920         type-stack.h.
6921         (insert_into_type_stack, insert_type, push_type, push_type_int)
6922         (insert_type_address_space, pop_type, pop_type_int)
6923         (pop_typelist, pop_type_stack, append_type_stack)
6924         (push_type_stack, get_type_stack, push_typelist)
6925         (follow_type_instance_flags, follow_types): Don't declare.
6926         * parse.c (type_stack): Remove global.
6927         (parse_exp_in_context): Update.
6928         (insert_into_type_stack, insert_type, push_type, push_type_int)
6929         (insert_type_address_space, pop_type, pop_type_int)
6930         (pop_typelist, pop_type_stack, append_type_stack)
6931         (push_type_stack, get_type_stack, push_typelist)
6932         (follow_type_instance_flags, follow_types): Remove (moved to
6933         type-stack.c).
6934         * f-exp.y (type_stack): New global.
6935         Update rules.
6936         (push_kind_type, f_parse): Update.
6937         * d-exp.y (type_stack): New global.
6938         Update rules.
6939         (d_parse): Update.
6940         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6941         Update rules.
6942         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6943         (HFILES_NO_SRCDIR): Add type-stack.h.
6944
6945 2019-04-04  Tom Tromey  <tom@tromey.com>
6946
6947         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6948         (rust_parser::convert_ast_to_expression, rust_parse)
6949         (rust_lex_test_completion, rust_lex_tests): Update.
6950         * parser-defs.h (struct expr_completion_state): New.
6951         (struct parser_state) <parser_state>: Add completion parameter.
6952         <mark_struct_expression, mark_completion_tag>: New methods.
6953         <parse_completion, m_completion_state>: New members.
6954         (prefixify_expression, null_post_parser): Update.
6955         (mark_struct_expression, mark_completion_tag): Don't declare.
6956         * parse.c (parse_completion, expout_last_struct)
6957         (expout_tag_completion_type, expout_completion_name): Remove
6958         globals.
6959         (parser_state::mark_struct_expression)
6960         (parser_state::mark_completion_tag): Now methods.
6961         (prefixify_expression): Add last_struct parameter.
6962         (prefixify_subexp): Likewise.
6963         (parse_exp_1): Update.
6964         (parse_exp_in_context): Add cstate parameter.  Update.
6965         (parse_expression_for_completion): Create an
6966         expr_completion_state.
6967         (null_post_parser): Add "completion" parameter.
6968         * p-exp.y: Update rules.
6969         (yylex): Update.
6970         * language.h (struct language_defn) <la_post_parser>: Add
6971         "completing" parameter.
6972         * go-exp.y: Update rules.
6973         (lex_one_token): Update.
6974         * expression.h (parse_completion): Don't declare.
6975         * d-exp.y: Update rules.
6976         (lex_one_token): Update rules.
6977         * c-exp.y: Update rules.
6978         (lex_one_token): Update.
6979         * ada-lang.c (resolve): Add "parse_completion" parameter.
6980         (resolve_subexp): Likewise.
6981         (ada_resolve_function): Likewise.
6982
6983 2019-04-04  Tom Tromey  <tom@tromey.com>
6984
6985         * parser-defs.h (struct parser_state) <start_arglist,
6986         end_arglist>: New methods.
6987         <arglist_len, m_funcall_chain>: New members.
6988         (arglist_len, start_arglist, end_arglist): Don't declare.
6989         * parse.c (arglist_len, funcall_chain): Remove global.
6990         (start_arglist, end_arglist): Remove functions.
6991         (parse_exp_in_context): Update.
6992         * p-exp.y: Update rules.
6993         * m2-exp.y: Update rules.
6994         * go-exp.y: Update rules.
6995         * f-exp.y: Update rules.
6996         * d-exp.y: Update rules.
6997         * c-exp.y: Update rules.
6998
6999 2019-04-04  Tom Tromey  <tom@tromey.com>
7000
7001         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7002         lex_operator, push_back>: New methods.
7003         Update all rules.
7004         (rust_parser::lex_hex, lex_escape): Rename and update.
7005         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7006         (rust_parser::lex_operator): Rename and update.
7007         (rust_parser::lex_number, rustyylex, rustyyerror)
7008         (rust_lex_test_init, rust_lex_test_sequence)
7009         (rust_lex_test_push_back, rust_lex_tests): Update.
7010         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7011         parameter.
7012         <lexptr, prev_lexptr>: New members.
7013         (lexptr, prev_lexptr): Don't declare.
7014         * parse.c (lexptr, prev_lexptr): Remove globals.
7015         (parse_exp_in_context): Update.
7016         * p-exp.y (yylex, yyerror): Update.
7017         * m2-exp.y (parse_number, yylex, yyerror): Update.
7018         * go-exp.y (lex_one_token, yyerror): Update.
7019         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7020         * d-exp.y (lex_one_token, yyerror): Update.
7021         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7022         (lex_one_token, yyerror): Update.
7023         * ada-lex.l (YY_INPUT): Update.
7024         (rewind_to_char): Update.
7025         * ada-exp.y (yyerror): Update.
7026
7027 2019-04-04  Tom Tromey  <tom@tromey.com>
7028
7029         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7030         * parser-defs.h (struct parser_state) <parser_state>: Add new
7031         parameter.
7032         <comma_terminates>: New member.
7033         (comma_terminates): Don't declare global.
7034         * parse.c (comma_terminates): Remove global.
7035         (parse_exp_in_context): Update.
7036         * p-exp.y (yylex): Update.
7037         * m2-exp.y (yylex): Update.
7038         * go-exp.y (lex_one_token): Update.
7039         * f-exp.y (yylex): Update.
7040         * d-exp.y (lex_one_token): Update.
7041         * c-exp.y (lex_one_token): Update.
7042         * ada-lex.l: Update.
7043
7044 2019-04-04  Tom Tromey  <tom@tromey.com>
7045
7046         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7047         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7048         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7049         * parser-defs.h (paren_depth): Don't declare.
7050         * parse.c (paren_depth): Remove global.
7051         (parse_exp_in_context): Update.
7052         * p-exp.y (paren_depth): New global.
7053         (pascal_parse): Initialize it.
7054         * m2-exp.y (paren_depth): New global.
7055         (m2_parse): Initialize it.
7056         * go-exp.y (paren_depth): New global.
7057         (go_parse): Initialize it.
7058         * f-exp.y (paren_depth): New global.
7059         (f_parse): Initialize it.
7060         * d-exp.y (paren_depth): New global.
7061         (d_parse): Initialize it.
7062         * c-exp.y (paren_depth): New global.
7063         (c_parse): Initialize it.
7064         * ada-lex.l (paren_depth): New global.
7065         (lexer_init): Initialize it.
7066
7067 2019-04-04  Tom Tromey  <tom@tromey.com>
7068
7069         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7070         (rust_parser::convert_ast_to_type)
7071         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7072         * parser-defs.h (struct parser_state) <parser_state>: Add
7073         parameters.  Initialize new members.
7074         <expression_context_block, expression_context_pc>: New members.
7075         * parse.c (expression_context_block, expression_context_pc):
7076         Remove globals.
7077         (parse_exp_in_context): Update.
7078         * p-exp.y: Update all rules.
7079         (yylex): Update.
7080         * m2-exp.y: Update all rules.
7081         (yylex): Update.
7082         * go-exp.y (yylex): Update.
7083         * f-exp.y (yylex): Update.
7084         * d-exp.y: Update all rules.
7085         (yylex): Update.
7086         * c-exp.y: Update all rules.
7087         (lex_one_token, classify_name, yylex, c_parse): Update.
7088         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7089
7090 2019-04-04  Tom Tromey  <tom@tromey.com>
7091
7092         * gdbarch.h, gdbarch.c: Rebuild.
7093         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7094         * stap-probe.h:
7095         (struct stap_parse_info): Replace "parser_state" with
7096         "expr_builder".
7097         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7098         (parser_state): New class.
7099         * parse.c (expr_builder): Rename.
7100         (expr_builder::release): Rename.
7101         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7102         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7103         (write_exp_elt_longcst, write_exp_elt_floatcst)
7104         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7105         (write_exp_string_vector, write_exp_bitstring)
7106         (write_exp_msymbol, mark_struct_expression)
7107         (write_dollar_variable)
7108         (insert_type_address_space, increase_expout_size): Replace
7109         "parser_state" with "expr_builder".
7110         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7111         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7112         "parser_state" with "expr_builder".
7113
7114 2019-04-04  Tom Tromey  <tom@tromey.com>
7115
7116         * rust-exp.y: Replace "parse_language" with method call.
7117         * p-exp.y:
7118         (yylex): Replace "parse_language" with method call.
7119         * m2-exp.y:
7120         (yylex): Replace "parse_language" with method call.
7121         * go-exp.y (classify_name): Replace "parse_language" with method
7122         call.
7123         * f-exp.y (yylex): Replace "parse_language" with method call.
7124         * d-exp.y (lex_one_token): Replace "parse_language" with method
7125         call.
7126         * c-exp.y:
7127         (lex_one_token, classify_name, yylex): Replace "parse_language"
7128         with method call.
7129         * ada-exp.y (find_primitive_type, type_char)
7130         (type_system_address): Replace "parse_language" with method call.
7131
7132 2019-04-04  Tom Tromey  <tom@tromey.com>
7133
7134         * rust-exp.y: Replace "parse_gdbarch" with method call.
7135         * parse.c (write_dollar_variable, insert_type_address_space):
7136         Replace "parse_gdbarch" with method call.
7137         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7138         call.
7139         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7140         call.
7141         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7142         "parse_gdbarch" with method call.
7143         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7144         with method call.
7145         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7146         "parse_gdbarch" with method call.
7147         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7148         "parse_gdbarch" with method call.
7149         * c-exp.y (parse_type, parse_number, classify_name): Replace
7150         "parse_gdbarch" with method call.
7151         * ada-lex.l: Replace "parse_gdbarch" with method call.
7152         * ada-exp.y (parse_type, find_primitive_type, type_char)
7153         (type_system_address): Replace "parse_gdbarch" with method call.
7154
7155 2019-04-04  Tom Tromey  <tom@tromey.com>
7156
7157         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7158         * stap-probe.c (stap_parse_argument): Update.
7159         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7160         initial_size parameter.
7161         * rust-exp.y (rust_lex_tests): Update.
7162         * parse.c (parser_state): Update.
7163         (parse_exp_in_context): Update.
7164         * parser-defs.h (struct parser_state) <parser_state>: Remove
7165         "initial_size" parameter.
7166
7167 2019-04-04  Tom Tromey  <tom@tromey.com>
7168
7169         * parser-defs.h (increase_expout_size): Don't declare.
7170         * parse.c (increase_expout_size): Now static.
7171
7172 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7173
7174         * gnu-nat.c (gnu_nat_target::wait): Fix
7175         target_waitstatus_to_string call.
7176
7177 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7178
7179         * eval.c (evaluate_subexp_standard): Handle internal functions
7180         during Fortran function call handling.
7181
7182 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7183
7184         * NEWS: Mention new internal functions.
7185         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7186         (read_base_type): Use dwarf2_init_complex_target_type.
7187         * value.c (creal_internal_fn): New function.
7188         (cimag_internal_fn): New function.
7189         (_initialize_values): Register new internal functions.
7190
7191 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7192
7193         * infrun.c (stop_all_threads): If debug_infrun, always
7194         trace the wait status after wait_one, using
7195         target_waitstatus_to_string and target_pid_to_str.
7196         (handle_inferior_event): Replace various trace of
7197         wait status kind by a single trace.
7198         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7199         wait status kind image by target_waitstatus_to_string.
7200         * target/waitstatus.c (target_waitstatus_to_string): Fix
7201         obsolete comment.
7202
7203 2019-04-01  Tom Tromey  <tromey@adacore.com>
7204
7205         PR symtab/23331:
7206         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7207
7208 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7209             Pedro Alves  <palves@redhat.com>
7210
7211         * top.c (quit_force): Call 'finalize_values'.
7212         * value.c (finalize_values): New function.
7213         * value.h (finalize_values): Declare.
7214
7215 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7216
7217         * NEWS: Announce $_gdb_major and $_gdb_minor.
7218
7219         * top.c (init_gdb_version_vars): New function.
7220         (gdb_init): Call init_gdb_version_vars.
7221
7222 2019-03-29  Tom Tromey  <tromey@adacore.com>
7223
7224         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7225         help text.  Remove dead code.
7226
7227 2019-03-29  Keith Seitz  <keiths@redhat.com>
7228
7229         From Siddhesh Poyarekar:
7230         * f-lang.h (f77_get_upperbound): Return LONGEST.
7231         (f77_get_lowerbound): Likewise.
7232         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7233         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7234         print them.
7235         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7236         plongest to format print it.
7237         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7238         (f77_get_upperbound): Likewise.
7239         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7240         LOWER_BOUND to LONGEST.
7241         (f77_create_arrayprint_offset_tbl): Likewise.
7242
7243 2019-03-29  Keith Seitz  <keiths@redhat.com>
7244
7245         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7246         %s/pulongest for TYPE_LENGTH instead of %d in format
7247         strings.
7248         * ada-typerint.c (ada_print_type): Likewise.
7249         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7250         * compile/compile-c-support.c (generate_register_struct): Likewise.
7251         * gdbtypes.c (recursive_dump_type): Likewise.
7252         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7253         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7254         instead of %d in format strings.
7255         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7256         to std::min to ULONGEST.
7257         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7258         instead of %d in format strings.
7259         * tracepoint.c (info_scope_command): Likewise.
7260         * typeprint.c (print_offset_data::update)
7261         (print_offset_data::finish): Likewise.
7262         * xtensa-tdep.c (xtensa_store_return_value)
7263         (xtensa_push_dummy_call): Likewise.
7264
7265 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7266
7267         * windows-nat.c (display_selector): Fixed format specifications
7268         for 64-bit Cygwin.
7269
7270 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7271
7272         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7273
7274 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7275
7276         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7277         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7278         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7279         (nios2_linux_init_abi): Install it.
7280
7281 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7282
7283         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7284
7285 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7286
7287         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7288
7289 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7290             Tom Tromey  <tromey@adacore.com>
7291
7292         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7293
7294 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7295
7296         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7297         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7298         method to compute the bounds of range types. Also print "[evaluated]"
7299         if the bounds' values come from a dynamic evaluation.
7300
7301 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7302
7303         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7304         whitespace when pretty printing is on.
7305
7306 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7307
7308         * ppc-linux-nat.c: Add include.
7309
7310 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7311
7312         * NEWS: Mention AArch64 Pointer Authentication.
7313
7314 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7315
7316         * arm-linux-nat.c: Add include.
7317
7318 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7319
7320         * source-cache.c (source_cache::get_source_lines): Re-read
7321         fullname after calling open_source_file.
7322
7323 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7324
7325         * NEWS: Mention TLS support for FreeBSD.
7326
7327 2019-03-25  Tom Tromey  <tromey@adacore.com>
7328
7329         * minsyms.c (BUNCH_SIZE): Update comment.
7330         (~minimal_symbol_reader): Remove old comment.
7331         (compact_minimal_symbols): Update comment.
7332         (minimal_symbol_reader::install): Remove old comment.  Update
7333         other comments.
7334
7335 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7336
7337         * s390-linux-nat.c: Add include.
7338
7339 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7340
7341         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7342         Call linux_get_hwcap.
7343         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7344         Likewise.
7345         (aarch64_linux_get_hwcap): Remove function.
7346         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7347         declaration.
7348         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7349         linux_get_hwcap.
7350         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7351         * linux-tdep.c (linux_get_hwcap): Add function.
7352         (linux_get_hwcap2): Likewise.
7353         * linux-tdep.h (linux_get_hwcap): Add declaration.
7354         (linux_get_hwcap2): Likewise.
7355         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7356         (ppc_linux_get_hwcap2): Likewise.
7357         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7358         linux_get_hwcap.
7359         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7360         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7361         (ppc_linux_nat_target::read_description): Likewise.
7362         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7363         * s390-linux-nat.c: Likewise.
7364         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7365
7366 2019-03-24  Tom Tromey  <tom@tromey.com>
7367
7368         * ada-lang.c (standard_lookup): Simplify initialization.
7369         (ada_lookup_symbol_nonlocal): Simplify return.
7370         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7371         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7372         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7373         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7374         initialization.
7375         * solib.c (solib_global_lookup): Simplify.
7376         * symtab.c (null_block_symbol): Remove.
7377         (symbol_cache_lookup): Simplify returns.
7378         (lookup_language_this): Simplify returns.
7379         (lookup_symbol_aux): Simplify return.
7380         (lookup_local_symbol): Simplify returns.
7381         (lookup_global_symbol_from_objfile): Simplify return.
7382         (lookup_symbol_in_objfile_symtabs)
7383         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7384         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7385         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7386         * cp-namespace.c (cp_lookup_bare_symbol)
7387         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7388         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7389         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7390         (cp_lookup_symbol_via_imports): Simplify initialization.
7391         (find_symbol_in_baseclass): Likewise.
7392         * symtab.h (null_block_symbol): Remove.
7393         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7394         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7395         (d_lookup_symbol_module): Likewise.
7396         (find_symbol_in_baseclass): Simplify initialization.
7397
7398 2019-03-24  Tom Tromey  <tom@tromey.com>
7399
7400         * expression.h: Don't include symtab.h.
7401         (struct block): Forward declare.
7402
7403 2019-03-24  Tom Tromey  <tom@tromey.com>
7404
7405         * c-exp.y (typebase): Remove casts.
7406         * gdbtypes.c (lookup_unsigned_typename, )
7407         (lookup_signed_typename): Remove cast.
7408         * eval.c (parse_to_comma_and_eval): Remove cast.
7409         * parse.c (write_dollar_variable): Remove cast.
7410         * block.h (struct block) <superblock>: Now const.
7411         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7412         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7413         (map_block): Make "block" const.
7414         * symfile.h (struct quick_symbol_functions)
7415         <map_matching_symbols>: Constify block argument to "callback".
7416         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7417         const.
7418         (find_pc_sect_compunit_symtab): Make "b" const.
7419         (find_symbol_at_address): Likewise.
7420         (search_symbols): Likewise.
7421         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7422         (dw2_debug_names_lookup_symbol): Likewise.
7423         (dw2_map_matching_symbols): Update.
7424         * p-valprint.c (pascal_val_print): Remove "block".
7425         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7426         (aux_add_nonlocal_symbols): Make "block" const.
7427         (resolve_subexp): Remove cast.
7428         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7429         const.
7430         (iterate_over_file_blocks): Likewise.
7431         * f-exp.y (%union) <bval>: Remove.
7432         * coffread.c (patch_opaque_types): Make "b" const.
7433         * spu-tdep.c (spu_catch_start): Make "block" const.
7434         * c-valprint.c (print_unpacked_pointer): Remove "block".
7435         * symmisc.c (dump_symtab_1): Make "b" const.
7436         (block_depth): Make "block" const.
7437         * d-exp.y (%union) <bval>: Remove.
7438         * cp-support.h (cp_lookup_rtti_type): Update.
7439         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7440         * psymtab.c (psym_lookup_symbol): Make "block" const.
7441         (maintenance_check_psymtabs): Make "b" const.
7442         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7443         (enumerate_locals, enumerate_args): Update.
7444         * python/py-symtab.c (stpy_global_block): Make "block" const.
7445         (stpy_static_block): Likewise.
7446         * inline-frame.c (block_starting_point_at): Make "new_block"
7447         const.
7448         * block.c (find_block_in_blockvector): Make return type const.
7449         (blockvector_for_pc_sect): Make "b" const.
7450         (find_block_in_blockvector): Make "b" const.
7451
7452 2019-03-23  Tom Tromey  <tom@tromey.com>
7453
7454         * varobj.c (varobj_create): Update.
7455         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7456         * printcmd.c (display_command, do_one_display): Don't reset
7457         innermost_block.
7458         * parser-defs.h (enum innermost_block_tracker_type): Move to
7459         expression.h.
7460         (innermost_block): Update comment.
7461         * parse.c (parse_exp_1): Add tracker_types parameter.
7462         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7463         tracker_types parameter.  Reset innermost_block.
7464         (parse_exp_in_context): Remove.
7465         (parse_expression_for_completion): Update.
7466         * objfiles.c (~objfile): Don't reset expression_context_block or
7467         innermost_block.
7468         * expression.h (enum innermost_block_tracker_type): Move from
7469         parser-defs.h.
7470         (parse_exp_1): Add tracker_types parameter.
7471         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7472         reset innermost_block.
7473
7474 2019-03-23  Tom Tromey  <tom@tromey.com>
7475
7476         * objfiles.h: Include bcache.h.
7477
7478 2019-03-23  Tom Tromey  <tom@tromey.com>
7479
7480         * linespec.c (get_current_search_block): Use
7481         scoped_restore_current_language.
7482         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7483
7484 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7485             Jiong Wang  <jiong.wang@arm.com>
7486
7487         * aarch64-linux-tdep.c
7488         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7489         section.
7490         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7491
7492 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7493             Jiong Wang  <jiong.wang@arm.com>
7494
7495         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7496         instructions.
7497         (aarch64_analyze_prologue_test): Add PACIASP test.
7498         (aarch64_prologue_prev_register): Unmask PC value.
7499
7500 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7501             Jiong Wang  <jiong.wang@arm.com>
7502
7503         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7504         (aarch64_dwarf2_prev_register): Unmask PC value.
7505         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7506         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7507         DW_CFA_AARCH64_negate_ra_state.
7508         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7509
7510 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7511             Jiong Wang  <jiong.wang@arm.com>
7512
7513         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7514         registers.
7515         (aarch64_pseudo_register_name): Likewise.
7516         (aarch64_pseudo_register_type): Likewise.
7517         (aarch64_pseudo_register_reggroup_p): Likewise.
7518         (aarch64_gdbarch_init): Add pauth registers.
7519         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7520         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7521         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7522         (struct gdbarch_tdep): Add regnum for ra_state.
7523
7524 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7525             Jiong Wang  <jiong.wang@arm.com>
7526
7527         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7528
7529 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7530             Jiong Wang  <jiong.wang@arm.com>
7531
7532         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7533         function.
7534         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7535         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7536         (aarch64_gdbarch_init): Add puth registers.
7537         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7538         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7539         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7540
7541 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7542             Jiong Wang  <jiong.wang@arm.com>
7543
7544         * aarch64-linux-nat.c
7545         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7546         * aarch64-linux-tdep.c
7547         (aarch64_linux_core_read_description): Likewise.
7548         (aarch64_linux_get_hwcap): New function.
7549         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7550         (aarch64_linux_get_hwcap): New declaration.
7551
7552 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7553             Jiong Wang  <jiong.wang@arm.com>
7554
7555         * aarch64-linux-nat.c
7556         (aarch64_linux_nat_target::read_description): Add pauth param.
7557         * aarch64-linux-tdep.c
7558         (aarch64_linux_core_read_description): Likewise.
7559         * aarch64-tdep.c (struct target_desc): Add in pauth.
7560         (aarch64_read_description): Add pauth param.
7561         (aarch64_gdbarch_init): Likewise.
7562         * aarch64-tdep.h (aarch64_read_description): Likewise.
7563         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7564         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7565         * features/Makefile: Add new files.
7566         * features/aarch64-pauth.c: New file.
7567         * features/aarch64-pauth.xml: New file.
7568
7569 2019-03-20  Tom Tromey  <tromey@adacore.com>
7570
7571         * infrun.c (handle_inferior_event): Rename from
7572         handle_inferior_event_1.  Create a scoped_value_mark.
7573         (handle_inferior_event): Remove.
7574
7575 2019-03-19  Tom Tromey  <tromey@adacore.com>
7576
7577         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7578         * infrun.h (print_stop_event): Add "displays" parameter.
7579         * infrun.c (print_stop_event): Add "displays" parameter.
7580
7581 2019-03-19  Pedro Alves  <palves@redhat.com>
7582
7583         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7584         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7585         to -1.  Fix TABs vs spaces.
7586         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7587         * tui/tui-out.h (tui_ui_out) Add intro comments.
7588         <m_line, m_start_of_line>: In-class initialize, and add describing
7589         comment.
7590
7591 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7592
7593         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7594         variable names.
7595         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7596
7597 2019-03-18  Pedro Alves  <palves@redhat.com>
7598             Eli Zaretskii <eliz@gnu.org>
7599
7600         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7601         m_line and m_start_of_line.
7602
7603 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7604
7605         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7606         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7607         it returns a newline.  This fixes a regression in TU mode, whereby
7608         the next line is output on the same screen line as the user input.
7609
7610 2019-03-18  Tom Tromey  <tromey@adacore.com>
7611
7612         * minsyms.c (minimal_symbol_reader::install): Remove call to
7613         obstack_blank.
7614
7615 2019-03-18  Pedro Alves  <palves@redhat.com>
7616
7617         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7618         New globals.
7619         (apply_style): New, factored out from ...
7620         (apply_ansi_escape): ... this.  Handle reverse video mode.
7621         (tui_set_reverse_mode): New function.
7622         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7623         * tui/tui-winsource.c (tui_show_source_line): Use
7624         tui_set_reverse_mode instead of setting A_STANDOUT.
7625         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7626         New setter methods.
7627
7628 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7629
7630         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7631         Handle tabs.
7632
7633 2019-03-18  Tom Tromey  <tromey@adacore.com>
7634
7635         * ada-lang.c (empty_array): Add "high" parameter.
7636         (ada_evaluate_subexp): Update.
7637
7638 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7639
7640         * unittests/string_view-selftests.c: Define
7641         _initialize_string_view_selftests unconditionally.
7642
7643 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7644
7645         PR gdb/24350
7646         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7647
7648 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7649
7650         PR gdb/24351
7651         * windows-nat.c (display_selector): Fix format specifiers.
7652
7653 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7654
7655         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7656         tui_refill_source_window instead of tui_refresh_win, to update the
7657         current execution line.  This fixes redisplay of the current line
7658         when stepping through the code with "next" or "step".
7659
7660 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7661
7662         * source-cache.c (source_cache::get_source_lines): Call
7663         find_source_lines to initialize s->nlines.  This fixes vertical
7664         scrolling of TUI source window when the DOWN arrow is pressed.
7665
7666 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7667
7668         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7669         linux-thread-db.c (_initialize_thread_db): Likewise.
7670
7671 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7672
7673         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7674         wclrtoeol in tui_show_source_line".  This reverts changes made in
7675         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7676
7677 2019-03-15  Tom Tromey  <tom@tromey.com>
7678
7679         * symtab.h (struct minimal_symbol): Derive from
7680         general_symbol_info.
7681         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7682         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7683         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7684         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7685         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7686         (MSYMBOL_SEARCH_NAME): Update.
7687         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7688         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7689         * minsyms.c (minimal_symbol_reader::record_full): Update.
7690
7691 2019-03-15  Tom Tromey  <tom@tromey.com>
7692
7693         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7694
7695 2019-03-15  Tom Tromey  <tom@tromey.com>
7696
7697         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7698         unique_xmalloc_ptr.
7699         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7700         Update.
7701         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7702         (build_minimal_symbol_hash_tables)
7703         (minimal_symbol_reader::install): Update.
7704
7705 2019-03-15  Tom Tromey  <tom@tromey.com>
7706
7707         * symtab.c (create_demangled_names_hash): Update.
7708         (symbol_set_names): Update.
7709         * objfiles.h (struct objfile_per_bfd_storage)
7710         <demangled_names_hash>: Now an htab_up.
7711         * objfiles.c (objfile_per_bfd_storage): Simplify.
7712
7713 2019-03-15  Tom Tromey  <tom@tromey.com>
7714
7715         * objfiles.h (struct objfile_per_bfd_storage): Declare
7716         destructor.
7717         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7718         New.
7719         (get_objfile_bfd_data): Use new.  Don't initialize
7720         language_of_main.
7721         (free_objfile_per_bfd_storage): Remove.
7722         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7723
7724 2019-03-15  Tom Tromey  <tom@tromey.com>
7725
7726         * symfile.c (reread_symbols): Update.
7727         * objfiles.c (objfile::objfile): Update.
7728         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7729         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7730         comment.
7731         (minimal_symbol_reader::install): Update.
7732         (terminate_minimal_symbol_table): Remove.
7733         * jit.c (jit_object_close_impl): Update.
7734
7735 2019-03-15  Tom Tromey  <tom@tromey.com>
7736
7737         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7738         initializations.
7739
7740 2019-03-15  Tom Tromey  <tom@tromey.com>
7741
7742         * objfiles.h (struct objfile_per_bfd_storage)
7743         <demangled_hash_languages>: Now a bitset.
7744         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7745         (lookup_minimal_symbol): Update.
7746
7747 2019-03-15  Tom Tromey  <tom@tromey.com>
7748
7749         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7750         Don't return the symbol.
7751         * coffread.c (record_minimal_symbol): Use record_full.
7752
7753 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7754
7755         The MS-Windows port of ncurses fails to switch to a color pair if
7756         one or both of the colors are the implicit default colors.  This
7757         change records the default colors when TUI is initialized, and
7758         then specifies them explicitly when a color pair uses the default
7759         colors.  This allows color styling in TUI mode on MS-Windows.
7760
7761         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7762         ncurses_norm_attr.
7763         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7764         colors in ncurses_norm_attr.
7765         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7766         "none", replace it with the default color recorded in
7767         ncurses_norm_attr.
7768
7769 2019-03-14  Tom Tromey  <tromey@adacore.com>
7770
7771         * source-cache.h (class source_cache) <get_source_lines>: Return
7772         std::string.
7773         * source-cache.c (source_cache::extract_lines): Handle case where
7774         first_pos==npos.  Return std::string.
7775         (source_cache::get_source_lines): Update.
7776
7777 2019-03-14  Tom Tromey  <tromey@adacore.com>
7778
7779         * NEWS: Add item for "style sources" commands.
7780         * source-cache.c (source_cache::get_source_lines): Check
7781         source_styling.
7782         * cli/cli-style.c (source_styling): New global.
7783         (_initialize_cli_style): Add "style sources" commands.
7784         (show_style_sources): New function.
7785         * cli/cli-style.h (source_styling): Declare.
7786
7787 2019-03-14  Pedro Alves  <palves@redhat.com>
7788             Tom Tromey  <tromey@adacore.com>
7789
7790         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7791         * tui/tui-winsource.c (tui_refill_source_window): New function,
7792         from...
7793         (tui_horizontal_source_scroll): ... here.  Move some logic.
7794         * cli/cli-style.c (set_style_enabled): Notify new observable.
7795         * tui/tui-hooks.c (tui_redisplay_source): New function.
7796         (tui_attach_detach_observers): Attach or detach
7797         tui_redisplay_source.
7798         * observable.h (source_styling_changed): New observable.
7799         * observable.c: Define source_styling_changed observable.
7800
7801 2019-03-13  Tom Tromey  <tromey@adacore.com>
7802
7803         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7804         (i386_gnu_nat_target::store_registers): Update.
7805         * target-debug.h (target_debug_print_std_string): New macro.
7806         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7807         * windows-tdep.c (display_one_tib): Update.
7808         * tui/tui-stack.c (tui_make_status_line): Update.
7809         * top.c (print_inferior_quit_action): Update.
7810         * thread.c (thr_try_catch_cmd): Update.
7811         (add_thread_with_info): Update.
7812         (thread_target_id_str): Update.
7813         (thr_try_catch_cmd): Update.
7814         (thread_command): Update.
7815         (thread_find_command): Update.
7816         * record-btrace.c (record_btrace_target::info_record)
7817         (record_btrace_resume_thread, record_btrace_target::resume)
7818         (record_btrace_cancel_resume, record_btrace_step_thread)
7819         (record_btrace_target::wait, record_btrace_target::wait)
7820         (record_btrace_target::wait, record_btrace_target::stop): Update.
7821         * progspace.c (print_program_space): Update.
7822         * process-stratum-target.c
7823         (process_stratum_target::thread_address_space): Update.
7824         * linux-fork.c (linux_fork_mourn_inferior)
7825         (detach_checkpoint_command, info_checkpoints_command)
7826         (linux_fork_context): Update.
7827         (linux_fork_detach): Update.
7828         (class scoped_switch_fork_info): Update.
7829         (delete_checkpoint_command): Update.
7830         * infrun.c (follow_fork_inferior): Update.
7831         (follow_fork_inferior): Update.
7832         (proceed_after_vfork_done): Update.
7833         (handle_vfork_child_exec_or_exit): Update.
7834         (follow_exec): Update.
7835         (displaced_step_prepare_throw): Update.
7836         (displaced_step_restore): Update.
7837         (start_step_over): Update.
7838         (resume_1): Update.
7839         (clear_proceed_status_thread): Update.
7840         (proceed): Update.
7841         (print_target_wait_results): Update.
7842         (do_target_wait): Update.
7843         (context_switch): Update.
7844         (stop_all_threads): Update.
7845         (restart_threads): Update.
7846         (finish_step_over): Update.
7847         (handle_signal_stop): Update.
7848         (switch_back_to_stepped_thread): Update.
7849         (keep_going_pass_signal): Update.
7850         (print_exited_reason): Update.
7851         (normal_stop): Update.
7852         * inferior.c (inferior_pid_to_str): Change return type.
7853         (print_selected_inferior): Update.
7854         (add_inferior): Update.
7855         (detach_inferior): Update.
7856         * dummy-frame.c (fprint_dummy_frames): Update.
7857         * dcache.c (dcache_info_1): Update.
7858         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7859         (btrace_fetch, btrace_clear): Update.
7860         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7861         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7862         type.
7863         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7864         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7865         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7866         * gdbarch.c, gdbarch.h: Rebuild.
7867         * gdbarch.sh (core_pid_to_str): Change return type.
7868         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7869         return type.
7870         (windows_nat_target::pid_to_str): Change return type.
7871         (windows_delete_thread): Update.
7872         (windows_nat_target::attach): Update.
7873         (windows_nat_target::files_info): Update.
7874         * target-delegates.c: Rebuild.
7875         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7876         return type.
7877         (sol_thread_target::pid_to_str): Change return type.
7878         * remote.c (class remote_target) <pid_to_str>: Change return
7879         type.
7880         (remote_target::pid_to_str): Change return type.
7881         (extended_remote_target::attach, remote_target::remote_stop_ns)
7882         (remote_target::remote_notif_remove_queued_reply)
7883         (remote_target::push_stop_reply, remote_target::disable_btrace):
7884         Update.
7885         (extended_remote_target::attach): Update.
7886         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7887         type.
7888         (gdbsim_target::pid_to_str): Change return type.
7889         * ravenscar-thread.c (struct ravenscar_thread_target)
7890         <pid_to_str>: Change return type.
7891         (ravenscar_thread_target::pid_to_str): Change return type.
7892         * procfs.c (class procfs_target) <pid_to_str>: Change return
7893         type.
7894         (procfs_target::pid_to_str): Change return type.
7895         (procfs_target::attach): Update.
7896         (procfs_target::detach): Update.
7897         (procfs_target::fetch_registers): Update.
7898         (procfs_target::store_registers): Update.
7899         (procfs_target::wait): Update.
7900         (procfs_target::files_info): Update.
7901         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7902         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7903         return type.
7904         (nto_procfs_target::pid_to_str): Change return type.
7905         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7906         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7907         return type.
7908         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7909         (exit_lwp): Update.
7910         (attach_proc_task_lwp_callback, get_detach_signal)
7911         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7912         (linux_nat_target::resume, wait_lwp, stop_callback)
7913         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7914         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7915         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7916         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7917         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7918         type.
7919         (inf_ptrace_target::attach): Update.
7920         (inf_ptrace_target::files_info): Update.
7921         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7922         type.
7923         (go32_nat_target::pid_to_str): Change return type.
7924         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7925         (gnu_nat_target::wait): Update.
7926         (gnu_nat_target::wait): Update.
7927         (gnu_nat_target::resume): Update.
7928         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7929         (fbsd_nat_target::wait): Update.
7930         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7931         type.
7932         (darwin_nat_target::attach): Update.
7933         * corelow.c (class core_target) <pid_to_str>: Change return type.
7934         (core_target::pid_to_str): Change return type.
7935         * target.c (normal_pid_to_str): Change return type.
7936         (default_pid_to_str): Likewise.
7937         (target_pid_to_str): Change return type.
7938         (target_translate_tls_address): Update.
7939         (target_announce_detach): Update.
7940         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7941         return type.
7942         (bsd_uthread_target::pid_to_str): Change return type.
7943         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7944         type.
7945         (bsd_kvm_target::pid_to_str): Change return type.
7946         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7947         return type.
7948         (aix_thread_target::pid_to_str): Change return type.
7949         * target.h (struct target_ops) <pid_to_str>: Change return type.
7950         (target_pid_to_str, normal_pid_to_str): Likewise.
7951         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7952         type.
7953         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7954         type.
7955         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7956         return type.
7957         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7958         type.
7959         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7960         type.
7961         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7962         return type.
7963
7964 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7965
7966         * NEWS: Mention that the new default MI version is 3.  Mention
7967         changes to the output of commands and events that deal with
7968         multi-location breakpoints.
7969         * breakpoint.c: Include "mi/mi-out.h".
7970         (print_one_breakpoint): Change output syntax if using MI version
7971         >= 3.
7972         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7973         New.
7974         (mi_multi_location_breakpoint_output_fixed): New.
7975         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7976         (mi_cmd_fix_multi_location_breakpoint_output): New.
7977         (mi_multi_location_breakpoint_output_fixed): New.
7978         * mi/mi-cmds.c (mi_cmds): Register command
7979         -fix-multi-location-breakpoint-output.
7980         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7981         interpreter "mi".
7982
7983 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7984
7985         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7986         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7987         instantiate mi_ui_out based on interpreter name.
7988         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7989         * mi/mi-main.c (mi_load_progress): Likewise.
7990
7991 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7992
7993         * NEWS: Combine separate "New targets" sections for 8.3.
7994
7995 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7996
7997         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7998         (ppcfbsd_init_abi): Install gdbarch
7999         "fetch_tls_load_module_address" and "get_thread_local_address"
8000         methods.
8001
8002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8003
8004         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8005         (riscv_fbsd_init_abi): Install gdbarch
8006         "fetch_tls_load_module_address" and "get_thread_local_address"
8007         methods.
8008
8009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8010
8011         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8012         (i386fbsd_init_abi): Install gdbarch
8013         "fetch_tls_load_module_address" and "get_thread_local_address"
8014         methods.
8015
8016 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8017
8018         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8019         (amd64fbsd_init_abi): Install gdbarch
8020         "fetch_tls_load_module_address" and "get_thread_local_address"
8021         methods.
8022
8023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8024
8025         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8026         (struct fbsd_pspace_data): New type.
8027         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8028         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8029         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8030         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8031         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8032
8033 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8034
8035         * gdbtypes.c (lookup_struct_elt): New function.
8036         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8037         * gdbtypes.h (struct struct_elt): New type.
8038         (lookup_struct_elt): New prototype.
8039
8040 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8041
8042         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8043         remove disabled code block.
8044
8045 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8046
8047         * gdbarch.sh (get_thread_local_address): New method.
8048         * gdbarch.h, gdbarch.c: Regenerate.
8049         * target.c (target_translate_tls_address): Use
8050         gdbarch_get_thread_local_address if present instead of
8051         target::get_thread_local_address.
8052
8053 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8054
8055         * target.h (target::get_thread_local_address): Update comment.
8056
8057 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8058
8059         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8060         objfile->separate_debug_objfile_backlink if not NULL.
8061
8062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8063
8064         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8065         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8066         (amd64bsd_store_inferior_registers): Likewise.
8067         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8068         Enable segment base registers.
8069         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8070         PT_GETFSBASE and PT_GETGSBASE.
8071         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8072         PT_SETGSBASE.
8073         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8074         segment base registers.
8075         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8076
8077 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8078
8079         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8080         Update calls to i386_target_description to add 'segments'
8081         parameter.
8082         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8083         add segment base registers.
8084         * arch/i386.c (i386_create_target_description): Add 'segments'
8085         parameter to enable segment base registers.
8086         * arch/i386.h (i386_create_target_description): Likewise.
8087         * features/i386/32bit-segments.xml: New file.
8088         * features/i386/32bit-segments.c: Generate.
8089         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8090         call to i386_target_description to add 'segments' parameter.
8091         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8092         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8093         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8094         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8095         if feature is present.
8096         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8097         Add 'segments' parameter to call to i386_target_description.
8098         (i386_target_description): Add 'segments' parameter to enable
8099         segment base registers.
8100         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8101         to call to i386_target_description.
8102         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8103         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8104         Define I386_NUM_REGS.
8105         (i386_target_description): Add 'segments' parameter to enable
8106         segment base registers.
8107
8108 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8109
8110         PR/24325
8111         * source-cache.c: #undef open and close, to avoid unresolved
8112         externals during linking.
8113
8114 2019-03-12  Tom Tromey  <tromey@adacore.com>
8115
8116         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8117         const.  Add initializers.
8118         (_initialize_remote): Don't initialize ptid globals.
8119
8120 2019-03-12  Pedro Alves  <palves@redhat.com>
8121
8122         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8123
8124 2019-03-12  Pedro Alves  <palves@redhat.com>
8125
8126         * cp-name-parser.y (main): Remove unused 'len' variable.
8127
8128 2019-03-12  Tom Tromey  <tromey@adacore.com>
8129
8130         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8131         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8132
8133 2019-03-12  Tom Tromey  <tromey@adacore.com>
8134
8135         * linux-nat.c (iterate_over_lwps): Update.
8136         (stop_callback): Remove parameter.
8137         (stop_wait_callback, detach_callback, resume_set_callback)
8138         (select_singlestep_lwp_callback, set_ignore_sigint)
8139         (status_callback, resumed_callback, resume_clear_callback)
8140         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8141         data parameter.
8142         (linux_nat_target::detach, linux_nat_target::resume)
8143         (linux_stop_and_wait_all_lwps, select_event_lwp)
8144         (linux_nat_filter_event, linux_nat_wait_1)
8145         (linux_nat_target::kill, linux_nat_target::stop)
8146         (linux_nat_target::stop): Update.
8147         (linux_nat_resume_callback): Change type.
8148         (resume_stopped_resumed_lwps, count_events_callback)
8149         (select_event_lwp_callback): Likewise.
8150         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8151         * arm-linux-nat.c (struct update_registers_data): Remove.
8152         (update_registers_callback): Change type.
8153         (arm_linux_insert_hw_breakpoint1): Update.
8154         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8155         parameter.
8156         (x86_linux_dr_set_addr): Update.
8157         (x86_linux_dr_set_control): Update.
8158         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8159         (iterate_over_lwps): Use gdb::function_view.
8160         * nat/aarch64-linux-hw-point.c (struct
8161         aarch64_dr_update_callback_param): Remove.
8162         (debug_reg_change_callback): Change type.
8163         (aarch64_notify_debug_reg_change): Update.
8164         * s390-linux-nat.c (s390_refresh_per_info): Update.
8165
8166 2019-03-11  Tom Tromey  <tromey@adacore.com>
8167
8168         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8169         redundant assignment to "this_cu".
8170
8171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8172
8173         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8174
8175 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8176
8177         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8178         from...
8179         (rank_one_type): ... this.
8180
8181 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8182
8183         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8184         from...
8185         (rank_one_type): ... this.
8186
8187 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8188
8189         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8190         from...
8191         (rank_one_type): ... this.
8192
8193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8194
8195         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8196         from...
8197         (rank_one_type): ... this.
8198
8199 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8200
8201         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8202         from...
8203         (rank_one_type): ... this.
8204
8205 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8206
8207         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8208         from...
8209         (rank_one_type): ... this.
8210
8211 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8212
8213         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8214         from...
8215         (rank_one_type): ... this.
8216
8217 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8218
8219         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8220         from...
8221         (rank_one_type): ... this.
8222
8223 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8224
8225         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8226         from...
8227         (rank_one_type): ... this.
8228
8229 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8230
8231         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8232         from...
8233         (rank_one_type): ... this.
8234
8235 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8236
8237         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8238         from...
8239         (rank_one_type): ... this.
8240
8241 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8242
8243         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8244         from...
8245         (rank_one_type): ... this.
8246
8247 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8248
8249         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8250         inferior-events' shows the example events.
8251
8252 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8253
8254         Support styling on native MS-Windows console
8255
8256         PR/24315
8257         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8258         on MS-Windows if $TERM is not defined.
8259
8260         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8261
8262         * posix-hdep.c (gdb_console_fputs):
8263         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8264         functions.
8265         * ui-file.h (gdb_console_fputs): Add prototype.
8266
8267         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8268         back to fputs only if the former returns zero.
8269
8270 2019-03-07  Tom Tromey  <tom@tromey.com>
8271
8272         * symmisc.c (print_symbol_bcache_statistics): Update.
8273         (print_objfile_statistics): Update.
8274         * symfile.c (allocate_symtab): Update.
8275         * stabsread.c: Don't include bcache.h.
8276         * psymtab.h (struct psymbol_bcache): Don't declare.
8277         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8278         (psymbol_bcache_init, psymbol_bcache_free)
8279         (psymbol_bcache_get_bcache): Don't declare.
8280         * psymtab.c (struct psymbol_bcache): Remove.
8281         (psymtab_storage::psymtab_storage): Update.
8282         (psymtab_storage::~psymtab_storage): Update.
8283         (psymbol_bcache_init, psymbol_bcache_free)
8284         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8285         (add_psymbol_to_bcache): Update.
8286         (allocate_psymtab): Update.
8287         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8288         macro_cache>: No longer pointers.
8289         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8290         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8291         * macrotab.c (macro_bcache): Update.
8292         * macroexp.c: Don't include bcache.h.
8293         * gdbtypes.c (check_types_worklist): Update.
8294         (types_deeply_equal): Remove TRY/CATCH.  Update.
8295         * elfread.c (elf_symtab_read): Update.
8296         * dwarf2read.c: Don't include bcache.h.
8297         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8298         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8299         (print_bcache_statistics, bcache_memory_used): Don't declare.
8300         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8301         methods.  Rename all data members.
8302         * bcache.c (struct bcache): Move to bcache.h.
8303         (bcache::expand_hash_table): Rename from expand_hash_table.
8304         (bcache): Remove.
8305         (bcache::insert): Rename from bcache_full.
8306         (bcache::compare): Rename from bcache_compare.
8307         (bcache_xmalloc): Remove.
8308         (bcache::~bcache): Rename from bcache_xfree.
8309         (bcache::print_statistics): Rename from print_bcache_statistics.
8310         (bcache::memory_used): Rename from bcache_memory_used.
8311
8312 2019-03-07  Pedro Alves  <palves@redhat.com>
8313
8314         * infrun.c (normal_stop): Also check for
8315         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8316
8317 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8318
8319         * f-lang.c (value_from_host_double): Moved to...
8320         * value.c (value_from_host_double): ...here.
8321         * value.h (value_from_host_double): Declare.
8322         * guile/scm-math.c (vlscm_convert_typed_number): Use
8323         value_from_host_double.
8324         (vlscm_convert_number): Likewise.
8325         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8326         * python/py-value.c (convert_value_from_python): Likewise.
8327
8328 2019-03-06  Tom Tromey  <tom@tromey.com>
8329
8330         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8331
8332 2019-03-06  Tom Tromey  <tom@tromey.com>
8333
8334         * utils.h (free_current_contents): Don't declare.
8335         * utils.c (free_current_contents): Remove.
8336
8337 2019-03-06  Tom Tromey  <tom@tromey.com>
8338
8339         * top.c (quit_force): Update.
8340         * main.c (captured_command_loop): Update.
8341         * common/new-op.c (operator new): Update.
8342         * common/common-exceptions.c (struct catcher)
8343         <save_cleanup_chain>: Remove member.
8344         (exceptions_state_mc_init): Update.
8345         (exception_try_scope_entry): Return nullptr.
8346         (exception_try_scope_exit, exception_rethrow)
8347         (throw_exception_sjlj, throw_exception_cxx): Update.
8348         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8349         (all_cleanups, do_cleanups, discard_cleanups)
8350         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8351         (restore_cleanups, restore_final_cleanups): Don't declare.
8352         (do_final_cleanups): Remove parameter.
8353         * common/cleanups.c (cleanup_chain, make_cleanup)
8354         (make_cleanup_dtor, all_cleanups, do_cleanups)
8355         (discard_my_cleanups, discard_cleanups)
8356         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8357         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8358         (null_cleanup): Remove.
8359         (do_final_cleanups): Remove parameter.
8360
8361 2019-03-06  Tom Tromey  <tom@tromey.com>
8362
8363         * remote.c (remote_target::remote_parse_stop_reply): Use
8364         unique_xmalloc_ptr.
8365
8366 2019-03-06  Tom Tromey  <tom@tromey.com>
8367
8368         * stabsread.c (struct stabs_field_info): Rename from field_info.
8369         <list, fnlist>: Add initializers.
8370         <obstack>: New member.
8371         (read_member_functions, read_struct_fields, read_baseclasses):
8372         Allocate on obstack.  Don't use cleanups.
8373         (read_one_struct_field, read_member_functions, read_struct_fields)
8374         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8375         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8376         (read_struct_type): Update.
8377
8378 2019-03-06  Tom Tromey  <tom@tromey.com>
8379
8380         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8381         * common/filestuff.h (make_cleanup_close): Don't declare.
8382         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8383         Remove.
8384
8385 2019-03-06  Tom Tromey  <tom@tromey.com>
8386
8387         * solib-aix.c: Use make_scope_exit.
8388
8389 2019-03-06  Tom Tromey  <tom@tromey.com>
8390
8391         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8392         Use make_scope_exit.
8393
8394 2019-03-06  Tom Tromey  <tom@tromey.com>
8395
8396         * solib-svr4.c (disable_probes_interface): Remove parameter.
8397         (svr4_handle_solib_event): Use make_scope_exit.
8398
8399 2019-03-06  Tom Tromey  <tom@tromey.com>
8400
8401         * remote.c (struct stop_reply_deleter): Remove.
8402         (stop_reply_up): Update.
8403         (struct stop_reply): Derive from notif_event.  Don't typedef.
8404         <regcache>: Now a std::vector.
8405         (stop_reply_xfree): Remove.
8406         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8407         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8408         (remote_target::discard_pending_stop_replies): Use delete.
8409         (remote_target::remote_parse_stop_reply): Update.
8410         (remote_target::process_stop_reply): Update.
8411         * remote-notif.h (struct notif_event): Add virtual destructor.
8412         Remove "dtr" member.
8413         (struct notif_client) <alloc_event>: Return a unique_ptr.
8414         (notif_event_xfree): Don't declare.
8415         (notif_event_up): New typedef.
8416         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8417         (notif_event_xfree, do_notif_event_xfree): Remove.
8418         (remote_notif_state_xfree): Update.
8419
8420 2019-03-06  Tom Tromey  <tom@tromey.com>
8421
8422         * infrun.c (displaced_step_clear_cleanup): Now a
8423         forward_scope_exit type.
8424         (displaced_step_prepare_throw): Update.
8425         (displaced_step_fixup): Update.
8426
8427 2019-03-06  Tom Tromey  <tom@tromey.com>
8428
8429         * inferior.h (class inferior): Update comment.
8430         * gdbthread.h (class thread_info): Update comment.
8431
8432 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8433             Tom Tromey  <tom@tromey.com>
8434
8435         * stabsread.h (struct stab_section_list): Remove.
8436         (coffstab_build_psymtabs): Update.
8437         * dbxread.c (symbuf_sections): Now a std::vector.
8438         (sect_idx): New global.
8439         (fill_symbuf): Update.
8440         (coffstab_build_psymtabs): Change type of stabsects parameter.
8441         Update.
8442         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8443         std::vector.
8444         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8445         (coff_locate_sections): Update.
8446         (coff_symfile_read): Remove cleanups.  Update.
8447         (init_stringtab): Add storage parameter.
8448         (free_stringtab, free_stringtab_cleanup): Remove.
8449         (init_lineno): Add storage parameter.
8450         (free_linetab, free_linetab_cleanup): Remove.
8451
8452 2019-03-06  Pedro Alves  <palves@redhat.com>
8453
8454         * linux-fork.c (fork_info::clobber_regs): Delete.
8455         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8456         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8457         comment.  Adjust.
8458         (scoped_switch_fork_info::scoped_switch_fork_info)
8459         (checkpoint_command, linux_fork_context): Adjust
8460         fork_save_infrun_state calls.
8461
8462 2019-03-06  Pedro Alves  <palves@redhat.com>
8463
8464         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8465         (inf_has_multiple_threads): Return 'bool' and rewrite using
8466         inferior_info::threads().
8467
8468 2019-03-06  Pedro Alves  <palves@redhat.com>
8469
8470         * linux-fork.c: Include <list>.
8471         (fork_list): Now a std::list instance.
8472         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8473         (forks_exist_p, find_last_fork): Adjust.
8474         (new_fork): Delete.
8475         (one_fork_p): New.
8476         (add_fork): Adjust.
8477         (free_fork): Delete, folded into fork_info::~fork_info().
8478         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8479         Adjust.
8480         (init_fork_list): Delete.
8481         (linux_fork_killall, linux_fork_mourn_inferior)
8482         (linux_fork_detach, info_checkpoints_command): Adjust.
8483         (_initialize_linux_fork): No longer call init_fork_list.
8484
8485 2019-03-06  Pedro Alves  <palves@redhat.com>
8486
8487         * linux-fork.c (new_fork): New, split out of ...
8488         (add_fork): ... this.  Return void.  Move "first fork" special
8489         case from here, to ...
8490         (checkpoint_command): ... here.
8491         * linux-linux.h (add_fork): Return void.
8492
8493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8494
8495         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8496
8497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8498             Chris January  <chris.january@arm.com>
8499             David Lecomber  <david.lecomber@arm.com>
8500
8501         * f-exp.y: New token, UNOP_INTRINSIC.
8502         (exp): New pattern using UNOP_INTRINSIC token.
8503         (f77_keywords): Add 'abs' keyword.
8504         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8505         (value_from_host_double): New function.
8506         (evaluate_subexp_f): Support UNOP_ABS.
8507
8508 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8509
8510         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8511         types.
8512
8513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8514
8515         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8516         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8517         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8518
8519 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8520
8521         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8522
8523 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8524             Chris January  <chris.january@arm.com>
8525
8526         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8527         * f-exp.y: Define 'KIND' token.
8528         (exp): New pattern for KIND expressions.
8529         (ptype): Handle types with a kind extension.
8530         (direct_abs_decl): Extend to spot kind extensions.
8531         (f77_keywords): Add 'kind' to the list.
8532         (push_kind_type): New function.
8533         (convert_to_kind_type): New function.
8534         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8535         * parse.c (operator_length_standard): Likewise.
8536         * parser-defs.h (enum type_pieces): Add tp_kind.
8537         * std-operator.def: Add UNOP_KIND.
8538
8539 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8540
8541         * f-exp.y (f_parse): Set yydebug.
8542
8543 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8544
8545         * f-lang.c (evaluate_subexp_f): New function.
8546         (exp_descriptor_f): New global.
8547         (f_language_defn): Use exp_descriptor_f instead of
8548         exp_descriptor_standard.
8549
8550 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8551
8552         * f-exp.y (struct token): Add comments.
8553         (dot_ops): Remove uppercase versions and the end marker.
8554         (f77_keywords): Likewise.
8555         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8556         entries in the dot_ops array are case insensitive, and use
8557         strncasecmp to compare strings.  Also some whitespace cleanup in
8558         this area.  Similar for the f77_keywords array, except entries in
8559         this list might be case sensitive.
8560
8561 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8562
8563         * f-exp.y (struct f77_boolean_val): Add comments.
8564         (boolean_values): Remove uppercase versions, and end marker.
8565         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8566         and use strncasecmp to achieve case insensitivity.  Additionally,
8567         perform whitespace cleanup around this code.
8568
8569 2019-03-06  Tom Tromey  <tromey@adacore.com>
8570
8571         * remote-sim.c (gdbsim_target_open): Use result of
8572         gdb_argv::release.
8573
8574 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8575         Dirk Schubert  <dirk.schubert@arm.com>
8576         Chris January  <chris.january@arm.com>
8577
8578         * eval.c (evaluate_subexp_standard): Call Fortran argument
8579         wrapping logic.
8580         * f-lang.c (struct value): A value which can be passed into a
8581         Fortran function call.
8582         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8583         where appropriate.
8584         (struct type): Value ready for a Fortran function call.
8585         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8586         is needed.
8587         * f-lang.h (fortran_argument_convert): Declaration.
8588         (fortran_preserve_arg_pointer): Declaration.
8589         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8590
8591 2019-03-05  Tom Tromey  <tromey@adacore.com>
8592
8593         * python/py-prettyprint.c (print_string_repr): Remove #if.
8594         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8595
8596 2019-03-05  Tom Tromey  <tromey@adacore.com>
8597
8598         * target.c (the_dummy_target): Move later.  Change type to
8599         "dummy_target".
8600         (initialize_targets): Don't initialize the_dummy_target.
8601
8602 2019-03-05  Tom Tromey  <tromey@adacore.com>
8603
8604         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8605         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8606
8607 2019-03-05  Tom Tromey  <tromey@adacore.com>
8608
8609         * windows-nat.c (windows_nat_target::attach)
8610         (windows_nat_target::detach): Don't call gdb_flush.
8611         * valprint.c (generic_val_print, val_print, val_print_string):
8612         Don't call gdb_flush.
8613         * utils.c (defaulted_query): Don't call gdb_flush.
8614         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8615         * target.c (target_announce_detach): Don't call gdb_flush.
8616         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8617         * remote.c (extended_remote_target::attach): Don't call
8618         gdb_flush.
8619         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8620         * printcmd.c (do_examine): Don't call gdb_flush.
8621         (info_display_command): Don't call gdb_flush.
8622         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8623         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8624         * memattr.c (info_mem_command): Don't call gdb_flush.
8625         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8626         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8627         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8628         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8629         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8630         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8631         (gnu_nat_target::detach): Don't call gdb_flush.
8632         * f-valprint.c (f_val_print): Don't call gdb_flush.
8633         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8634         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8635         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8636         gdb_flush.
8637         * c-valprint.c (c_val_print): Don't call gdb_flush.
8638         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8639
8640 2019-03-05  Tom Tromey  <tromey@adacore.com>
8641
8642         * varobj.c (update_dynamic_varobj_children): Update.
8643         (install_default_visualizer): Use reset, not release.
8644         * value.c (set_internalvar): Update.
8645         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8646         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8647         ATTRIBUTE_UNUSED_RESULT.
8648
8649 2019-03-05  Tom Tromey  <tromey@adacore.com>
8650
8651         * remote.c (class scoped_remote_fd) <release>: Add
8652         ATTRIBUTE_UNUSED_RESULT.
8653
8654 2019-03-05  Tom Tromey  <tromey@adacore.com>
8655
8656         * macroexp.c (struct macro_buffer) <release>: Add
8657         ATTRIBUTE_UNUSED_RESULT.
8658
8659 2019-03-05  Tom Tromey  <tromey@adacore.com>
8660
8661         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8662         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8663         ATTRIBUTE_UNUSED_RESULT.
8664
8665 2019-03-05  Tom Tromey  <tromey@adacore.com>
8666
8667         * common/scoped_fd.h (class scoped_fd) <release>: Add
8668         ATTRIBUTE_UNUSED_RESULT.
8669
8670 2019-03-05  Tom Tromey  <tromey@adacore.com>
8671
8672         * parser-defs.h (struct parser_state) <release>: Add
8673         ATTRIBUTE_UNUSED_RESULT.
8674
8675 2019-03-05  Tom Tromey  <tromey@adacore.com>
8676
8677         * utils.h (class gdb_argv) <release>: Add
8678         ATTRIBUTE_UNUSED_RESULT.
8679         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8680
8681 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8682
8683         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8684         for-loop range, to avoid compiler warnings.
8685
8686         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8687         avoid compiler warnings about unused variables.
8688
8689         * NEWS: Mention end of support for native debugging on MS-Windows
8690         before XP.
8691
8692         PR gdb/24292
8693         * common/netstuff.c:
8694         * gdbserver/gdbreplay.c
8695         * gdbserver/remote-utils.c:
8696         * ser-tcp.c:
8697         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8698         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8699         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8700         'getaddrinfo' and 'freeaddrinfo' were not available before
8701         Windows XP, and mingw.org's MinGW headers by default define
8702         _WIN32_WINNT to 0x500.
8703
8704 2019-03-01  Gary Benson <gbenson@redhat.com>
8705
8706         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8707
8708 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8709             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8710
8711         PR gdb/8527
8712         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8713         set_sigint_trap, clear_sigint_trap.
8714
8715 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8716
8717         * target.c (target_detach): Clear the regcache and the
8718         frame cache.
8719
8720 2019-02-27  Pedro Alves  <palves@redhat.com>
8721
8722         * utils.c (set_screen_size): When we cap the height/width sizes,
8723         tweak the corresponding command variable to show "unlimited":
8724
8725 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8726             Pedro Alves  <palves@redhat.com>
8727
8728         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8729         before calling rl_set_screen_size.
8730
8731 2019-02-27  Tom Tromey  <tromey@adacore.com>
8732
8733         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8734         define.
8735         * python/py-value.c: Remove Python 2.4 workaround.
8736         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8737         workaround.
8738         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8739         Python 2.4 workaround.
8740         * python/python-internal.h: Remove Python 2.4 comment.
8741         (Py_ssize_t): Don't define.
8742         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8743         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8744         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8745         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8746         * python/python.c (do_start_initialization): Remove Python 2.4
8747         workaround.
8748         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8749         (print_children): Remove Python 2.4 workaround.
8750         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8751         workaround.
8752         (CHARBUFFERPROC_NAME): Remove.
8753         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8754         Python 2.4 workaround.
8755
8756 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8757
8758         * NEWS: Note minimum Python version.
8759
8760 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8761
8762         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8763         code from these functions.  Remove corresponding ifdefs.  Use
8764         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8765         Remove gotos and target of gotos.
8766         (infpy_search_memory): Likewise.
8767
8768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8769
8770         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8771         (hppa_gdbarch_init): Don't register deleted functions with
8772         gdbarch.
8773
8774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8775
8776         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8777         (h8300_unwind_sp): Delete.
8778         (h8300_dummy_id): Delete.
8779         (h8300_gdbarch_init): Don't register deleted functions with
8780         gdbarch.
8781
8782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8783
8784         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8785         (ft32_unwind_pc): Delete.
8786         (ft32_unwind_sp): Delete.
8787         (ft32_gdbarch_init): Don't register deleted functions with
8788         gdbarch.
8789
8790 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8791
8792         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8793         (frv_unwind_pc): Delete.
8794         (frv_unwind_sp): Delete.
8795         (frv_gdbarch_init): Don't register deleted functions with
8796         gdbarch.
8797
8798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8799
8800         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8801         (riscv_unwind_pc): Delete.
8802         (riscv_unwind_sp): Delete.
8803         (riscv_gdbarch_init): Don't register deleted functions with
8804         gdbarch.
8805
8806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8807
8808         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8809         (csky_unwind_pc): Delete.
8810         (csky_unwind_sp): Delete.
8811         (csky_gdbarch_init): Don't register deleted functions with
8812         gdbarch.
8813
8814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8815
8816         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8817         (cris_unwind_pc): Delete.
8818         (cris_unwind_sp): Delete.
8819         (cris_gdbarch_init): Don't register deleted functions with
8820         gdbarch.
8821
8822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8823
8824         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8825         (bfin_unwind_pc): Delete.
8826         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8827
8828 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8829
8830         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8831         (arm_unwind_pc): Delete.
8832         (arm_unwind_sp): Delete.
8833         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8834
8835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8836
8837         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8838         (arc_unwind_pc): Delete.
8839         (arc_unwind_sp): Delete.
8840         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8841
8842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8843
8844         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8845         (alpha_unwind_pc): Delete.
8846         (alpha_gdbarch_init): Don't register deleted functions with
8847         gdbarch.
8848
8849 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8850
8851         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8852         (aarch64_unwind_pc): Delete.
8853         (aarch64_unwind_sp): Delete.
8854         (aarch64_gdbarch_init): Don't register deleted functions with
8855         gdbarch.
8856
8857 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8858
8859         * gdbtypes.c (type_align): Don't consider static members when
8860         computing structure alignment.
8861
8862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8863
8864         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8865         return 0 for other types.
8866         * arch-utils.c (default_type_align): Always return 0.
8867         * gdbarch.h: Regenerate.
8868         * gdbarch.sh (type_align): Extend comment.
8869         * gdbtypes.c (type_align): Add additional comments, always call
8870         gdbarch_type_align before applying the default rules.
8871         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8872         generic code will then apply a suitable default.
8873         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8874         types, return 0 for other types.
8875
8876 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8877
8878         * NEWS: Create a new section for the next release branch.
8879         Rename the section of the current branch, now that it has
8880         been cut.
8881
8882 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8883
8884         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8885         * version.in: Bump version to 8.3.50.DATE-git.
8886
8887 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8888
8889         * aix-thread.c (ptid_cmp): Remove unused variable.
8890         (get_signaled_thread): Likewise.
8891         (store_regs_user_thread): Likewise.
8892         (store_regs_kernel_thread): Likewise.
8893         (fetch_regs_kernel_thread): Remove shadowed variable.
8894
8895 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8896
8897         * features/riscv/32bit-cpu.xml: Add register numbers.
8898         * features/riscv/32bit-fpu.c: Regenerate.
8899         * features/riscv/32bit-fpu.xml: Add register numbers.
8900         * features/riscv/64bit-cpu.xml: Add register numbers.
8901         * features/riscv/64bit-fpu.c: Regenerate.
8902         * features/riscv/64bit-fpu.xml: Add register numbers.
8903
8904 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8905
8906         * NEWS: Mention two argument form of gdb.Value constructor.
8907         * python/py-value.c (convert_buffer_and_type_to_value): New
8908         function.
8909         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8910         Add support for handling an optional second argument.  Call
8911         convert_buffer_and_type_to_value as appropriate.
8912         * python/python-internal.h (Py_buffer_deleter): New struct.
8913         (Py_buffer_up): New typedef.
8914
8915 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8916
8917         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8918         instead of releasing ownership.
8919
8920 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8921
8922         * dwarf2read.c (open_and_init_dwp_file): Call
8923         elf_numsections instead of bfd_count_sections to initialize
8924         dwp_file->num_sections.
8925
8926 2019-02-25  Tom Tromey  <tromey@adacore.com>
8927
8928         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8929
8930 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8931
8932         * gcore.in: Add '--readnever' option when invoking GDB.
8933
8934 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8935
8936         * MAINTAINERS: Update my email address.
8937
8938 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8939
8940         * build-id.c (build_id_to_debug_bfd_1): New function.
8941         (build_id_to_debug_bfd): Look for separate debug file in
8942         sysroot.
8943
8944 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8945
8946         * gdbarch.sh: Update the copyright year range that is placed into
8947         generated files.
8948
8949 2019-02-22  Keith Seitz  <keiths@redhat.com>
8950
8951         PR symtab/23853
8952         * linespec.c (create_sals_line_offset): Search for the default
8953         symtab's filename instead of its fullname.
8954
8955 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8956
8957         * NEWS: Update style defaults.
8958
8959 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8960
8961         * main.c (captured_main_1): Disable styling in batch mode.
8962
8963 2019-02-20  Tom Tromey  <tom@tromey.com>
8964
8965         * symtab.c (symtab_symbol_info): Fix typos.
8966
8967 2019-02-20  Tom Tromey  <tromey@adacore.com>
8968
8969         * findcmd.c (_initialize_mem_search): Use upper case for
8970         metasyntactic variables.
8971
8972 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8973
8974         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8975         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8976
8977 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8978
8979         * top.h (source_file_name): Change to std::string.
8980         * top.c (source_file_name): Likewise.
8981         (command_line_input): Adjust.
8982         * cli/cli-script.c (script_from_file): Adjust.
8983
8984 2019-02-19  Tom Tromey  <tromey@adacore.com>
8985
8986         * ravenscar-thread.c
8987         (ravenscar_thread_target::update_thread_list): Don't call
8988         ada_build_task_list.
8989         * ada-lang.h (ada_build_task_list): Don't declare.
8990         * ada-tasks.c (struct ada_tasks_inferior_data)
8991         <task_list_valid_p>: Now bool.
8992         (read_known_tasks, ada_task_list_changed)
8993         (ada_tasks_invalidate_inferior_data): Update.
8994         (read_known_tasks_array): Return bool.
8995         (read_known_tasks_list): Likewise.
8996         (read_known_tasks): Return void.
8997         (ada_build_task_list): Now static.
8998
8999 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9000
9001         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9002         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9003
9004 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9005
9006         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9007         variant for ada_tasks_pspace_data_handle and
9008         ada_tasks_inferior_data_handle.
9009         (ada_tasks_pspace_data_cleanup): New function.
9010         (ada_tasks_inferior_data_cleanup): New function.
9011
9012 2019-02-17  Tom Tromey  <tom@tromey.com>
9013
9014         * macrotab.h (macro_source_fullname): Return a std::string.
9015         * macrotab.c (macro_include, check_for_redefinition)
9016         (macro_undef, macro_lookup_definition, foreach_macro)
9017         (foreach_macro_in_scope): Update.
9018         (macro_source_fullname): Return a std::string.
9019         * macrocmd.c (show_pp_source_pos): Update.
9020
9021 2019-02-17  Tom Tromey  <tom@tromey.com>
9022
9023         * macrocmd.c (show_pp_source_pos): Style the file names.
9024
9025 2019-02-17  Tom Tromey  <tom@tromey.com>
9026
9027         PR tui/24197:
9028         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9029
9030 2019-02-17  Tom Tromey  <tom@tromey.com>
9031
9032         * ada-lang.c (user_select_syms): Use filtered printing.
9033         * utils.c (wrap_style): New global.
9034         (desired_style): Remove.
9035         (emit_style_escape): Add stream parameter.
9036         (set_output_style, reset_terminal_style, prompt_for_continue):
9037         Update.
9038         (flush_wrap_buffer): Only flush gdb_stdout.
9039         (wrap_here): Set wrap_style.
9040         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9041         treat escape sequences as a character.  Change when wrap buffer is
9042         flushed.
9043         (fputs_styled): Do not set the output style when the default is
9044         requested.
9045         * ui-style.h (struct ui_file_style) <is_default>: New method.
9046         * source.c (print_source_lines_base): Emit escape sequences in one
9047         piece.
9048
9049 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9050
9051         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9052         integers and enumeration types.
9053
9054 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9055
9056         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9057         instead of lookup_symbol_in_language
9058         (do_exact_match): New function.
9059         (ada_get_symbol_name_matcher): Return do_exact_match when
9060         doing a verbatim match.
9061
9062 2019-02-15  Tom Tromey  <tromey@adacore.com>
9063
9064         * ravenscar-thread.c (ravenscar_thread_target::resume)
9065         (ravenscar_thread_target::wait): Special case wildcard requests.
9066
9067 2019-02-15  Tom Tromey  <tromey@adacore.com>
9068
9069         * ravenscar-thread.c (base_ptid): Remove.
9070         (struct ravenscar_thread_target) <close>: New method.
9071         <m_base_ptid>: New member.
9072         <update_inferior_ptid, active_task, task_is_currently_active,
9073         runtime_initialized>: Declare methods.
9074         <ravenscar_thread_target>: Add constructor.
9075         (ravenscar_thread_target::task_is_currently_active)
9076         (ravenscar_thread_target::update_inferior_ptid)
9077         (ravenscar_runtime_initialized): Rename.  Now methods.
9078         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9079         (ravenscar_thread_target::update_thread_list): Update.
9080         (ravenscar_thread_target::active_task): Now method.
9081         (ravenscar_thread_target::store_registers)
9082         (ravenscar_thread_target::prepare_to_store)
9083         (ravenscar_thread_target::prepare_to_store)
9084         (ravenscar_thread_target::mourn_inferior): Update.
9085         (ravenscar_inferior_created): Use "new" to create target.
9086         (ravenscar_thread_target::get_ada_task_ptid): Update.
9087         (_initialize_ravenscar): Don't initialize base_ptid.
9088         (ravenscar_ops): Remove global.
9089
9090 2019-02-15  Tom Tromey  <tromey@adacore.com>
9091
9092         * target.h (push_target): Declare new overload.
9093         * target.c (push_target): New overload, taking an rvalue reference.
9094         * remote.c (remote_target::open_1): Use push_target overload.
9095         * corelow.c (core_target_open): Use push_target overload.
9096
9097 2019-02-15  Tom Tromey  <tromey@adacore.com>
9098
9099         * ravenscar-thread.c (is_ravenscar_task)
9100         (ravenscar_task_is_currently_active): Return bool.
9101         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9102         (_initialize_ravenscar): Remove "(void)".
9103         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9104         Return bool.
9105
9106 2019-02-15  Tom Tromey  <tromey@adacore.com>
9107
9108         * ravenscar-thread.c (ravenscar_runtime_initializer)
9109         (has_ravenscar_runtime, get_running_thread_id)
9110         (ravenscar_thread_target::resume): Fix indentation.
9111
9112 2019-02-15  Tom Tromey  <tromey@adacore.com>
9113
9114         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9115         from ravenscar_arch_ops.
9116         (sparc_ravenscar_ops::fetch_registers)
9117         (sparc_ravenscar_ops::store_registers): Now methods.
9118         (sparc_ravenscar_prepare_to_store): Remove.
9119         (sparc_ravenscar_ops): Redefine.
9120         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9121         methods and destructor.  Remove members.
9122         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9123         (ravenscar_thread_target::store_registers)
9124         (ravenscar_thread_target::prepare_to_store): Update.
9125         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9126         Remove.
9127         (struct ppc_ravenscar_powerpc_ops): Derive from
9128         ravenscar_arch_ops.
9129         (ppc_ravenscar_powerpc_ops::fetch_registers)
9130         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9131         (ppc_ravenscar_powerpc_ops): Redefine.
9132         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9133         (ppc_ravenscar_e500_ops::fetch_registers)
9134         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9135         (ppc_ravenscar_e500_ops): Redefine.
9136         * aarch64-ravenscar-thread.c
9137         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9138         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9139         (aarch64_ravenscar_fetch_registers)
9140         (aarch64_ravenscar_store_registers): Now methods.
9141         (aarch64_ravenscar_ops): Redefine.
9142
9143 2019-02-15  Tom Tromey  <tromey@adacore.com>
9144
9145         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9146         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9147         (ravenscar_thread_target::stopped_by_watchpoint)
9148         (ravenscar_thread_target::stopped_data_address)
9149         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9150
9151 2019-02-15  Tom Tromey  <tromey@adacore.com>
9152
9153         * ravenscar-thread.c: Fix some typos.
9154
9155 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9156             Tom Tromey  <tromey@adacore.com>
9157
9158         * ada-lang.c (ada_exception_sal): Change addr_string to a
9159         std::string.
9160         (create_ada_exception_catchpoint): Update.
9161
9162 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9163             Tom Tromey  <tromey@adacore.com>
9164
9165         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9166         (bp_location_ops): Remove.
9167         (base_breakpoint_allocate_location): Update.
9168         (free_bp_location): Update.
9169         * ada-lang.c (class ada_catchpoint_location)
9170         <ada_catchpoint_location>: Remove ops parameter.
9171         (ada_catchpoint_location_dtor): Remove.
9172         (ada_catchpoint_location_ops): Remove.
9173         (allocate_location_exception): Update.
9174         * breakpoint.h (struct bp_location_ops): Remove.
9175         (class bp_location) <bp_location>: Remove bp_location_ops
9176         parameter.
9177         <~bp_location>: Add destructor.
9178         <ops>: Remove.
9179
9180 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9181             Pedro Alves  <palves@redhat.com>
9182
9183         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9184         'PATH_MAX'.
9185
9186 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9187             Samuel Thibault  <samuel.thibault@gnu.org>
9188             Thomas Schwinge  <thomas@codesourcery.com>
9189
9190         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9191         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9192
9193 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9194
9195         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9196         (check_empty): Use "const char *".
9197
9198         * gnu-nat.c (gnu_nat_target::detach): Instead of
9199         'detach_inferior (pid)' call
9200         'detach_inferior (find_inferior_pid (pid))'.
9201
9202         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9203         'nat/fork-inferior.o'.
9204         * gnu-nat.c: #include "nat/fork-inferior.h".
9205
9206         * gnu-nat.c (gnu_nat_target::detach): Instead of
9207         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9208         * gnu-nat.h: #include "inf-child.h".
9209         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9210         'i386_gnu_nat_target::fetch_registers'.
9211         (gnu_store_registers): Rename/move to
9212         'i386_gnu_nat_target::store_registers'.
9213
9214         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9215         * gnu-nat.h (mach_thread_info): New function.
9216         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9217
9218         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9219
9220 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9221
9222         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9223
9224 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9225
9226         * windows-nat.c (windows_add_thread): Add new parameter
9227         "main_thread_p" with default value set to false.  Update
9228         function documentation as well as all callers.
9229         (windows_delete_thread): Likewise.
9230         (fake_create_process): Update call to windows_add_thread.
9231         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9232         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9233         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9234         call to windows_delete_thread.
9235
9236 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9237
9238         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9239
9240 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9241
9242         * symfile.c (find_separate_debug_file): Use canonical path of
9243         sysroot with child_path instead of gdb_sysroot if it is valid.
9244
9245 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9246
9247         * symfile.c (find_separate_debug_file): Use child_path to
9248         determine if an object file is under a sysroot.
9249
9250 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9251
9252         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9253         unittests/child-path-selftests.c.
9254         * common/pathstuff.c (child_path): New function.
9255         * common/pathstuff.h (child_path): New prototype.
9256         * unittests/child-path-selftests.c: New file.
9257
9258 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9259
9260         * symfile.c (find_separate_debug_file): Look for separate debug
9261         files in debug directories under the sysroot.
9262
9263 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9264
9265         * symtab.h (struct minimal_symbol data_p): New const method.
9266         (struct minimal_symbol text_p): Likewise.
9267         * symtab.c (output_source_filename): Use file name style
9268         to print file name.
9269         (print_symbol_info): Likewise.
9270         (print_msymbol_info): Use address style to print addresses.
9271         Use function name style to print executable text symbols.
9272         (expand_symtab_containing_pc): Use data_p.
9273         (find_pc_sect_compunit_symtab): Likewise.
9274
9275 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9276
9277         * breakpoint.c (describe_other_breakpoints): Use address style
9278         to print addresses.
9279         (say_where): Likewise.
9280
9281 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9282
9283         * ada-typeprint.c (print_func_type): Print function name
9284         style to print function name.
9285         * c-typeprint.c (c_print_type_1): Likewise.
9286
9287 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9288
9289         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9290         for execve.
9291
9292 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9293
9294         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9295         type_stack.
9296
9297 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9298
9299         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9300         TYPE_CODE_REF types.
9301
9302 2019-02-08  Jim Wilson  <jimw@sifive.com>
9303
9304         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9305         (riscv_linux_fregset): New.
9306         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9307
9308 2019-02-07  Tom Tromey  <tom@tromey.com>
9309
9310         * thread.c (thread_cancel_execution_command): Update.
9311         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9312         methods.
9313         (struct thread_fsm_ops): Remove.
9314         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9315         (thread_fsm_should_stop, thread_fsm_return_value)
9316         (thread_fsm_set_finished, thread_fsm_finished_p)
9317         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9318         Don't declare.
9319         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9320         * infrun.c (clear_proceed_status_thread)
9321         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9322         (print_stop_event): Update.
9323         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9324         Add constructor.
9325         (step_command_fsm_ops): Remove.
9326         (new_step_command_fsm): Remove.
9327         (step_1): Update.
9328         (step_command_fsm::should_stop): Rename from
9329         step_command_fsm_should_stop.
9330         (step_command_fsm::clean_up): Rename from
9331         step_command_fsm_clean_up.
9332         (step_command_fsm::do_async_reply_reason): Rename from
9333         step_command_fsm_async_reply_reason.
9334         (struct until_next_fsm): Inherit from thread_fsm.  Add
9335         constructor.
9336         (until_next_fsm_ops): Remove.
9337         (new_until_next_fsm): Remove.
9338         (until_next_fsm::should_stop): Rename from
9339         until_next_fsm_should_stop.
9340         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9341         (until_next_fsm::do_async_reply_reason): Rename from
9342         until_next_fsm_async_reply_reason.
9343         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9344         constructor.  Change type of breakpoint.
9345         (finish_command_fsm_ops): Remove.
9346         (new_finish_command_fsm): Remove.
9347         (finish_command_fsm::should_stop): Rename from
9348         finish_command_fsm_should_stop.
9349         (finish_command_fsm::clean_up): Rename from
9350         finish_command_fsm_clean_up.
9351         (finish_command_fsm::return_value): Rename from
9352         finish_command_fsm_return_value.
9353         (finish_command_fsm::do_async_reply_reason): Rename from
9354         finish_command_fsm_async_reply_reason.
9355         (finish_command): Update.
9356         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9357         Add constructor.
9358         (call_thread_fsm_ops): Remove.
9359         (call_thread_fsm::call_thread_fsm): Rename from
9360         new_call_thread_fsm.
9361         (call_thread_fsm::should_stop): Rename from
9362         call_thread_fsm_should_stop.
9363         (call_thread_fsm::should_notify_stop): Rename from
9364         call_thread_fsm_should_notify_stop.
9365         (run_inferior_call, call_function_by_hand_dummy): Update.
9366         * cli/cli-interp.c (should_print_stop_to_console): Update.
9367         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9368         Add constructor.  Change type of location_breakpoint,
9369         caller_breakpoint.
9370         (until_break_fsm_ops): Remove.
9371         (new_until_break_fsm): Remove.
9372         (until_break_fsm::should_stop): Rename from
9373         until_break_fsm_should_stop.
9374         (until_break_fsm::clean_up): Rename from
9375         until_break_fsm_clean_up.
9376         (until_break_fsm::do_async_reply_reason): Rename from
9377         until_break_fsm_async_reply_reason.
9378         (until_break_command): Update.
9379         * thread-fsm.c: Remove.
9380         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9381
9382 2019-02-07  Tom Tromey  <tom@tromey.com>
9383
9384         * yy-remap.h: Add include guard.
9385         * xtensa-tdep.h: Add include guard.
9386         * xcoffread.h: Rename include guard.
9387         * varobj-iter.h: Add include guard.
9388         * tui/tui.h: Rename include guard.
9389         * tui/tui-winsource.h: Rename include guard.
9390         * tui/tui-wingeneral.h: Rename include guard.
9391         * tui/tui-windata.h: Rename include guard.
9392         * tui/tui-win.h: Rename include guard.
9393         * tui/tui-stack.h: Rename include guard.
9394         * tui/tui-source.h: Rename include guard.
9395         * tui/tui-regs.h: Rename include guard.
9396         * tui/tui-out.h: Rename include guard.
9397         * tui/tui-layout.h: Rename include guard.
9398         * tui/tui-io.h: Rename include guard.
9399         * tui/tui-hooks.h: Rename include guard.
9400         * tui/tui-file.h: Rename include guard.
9401         * tui/tui-disasm.h: Rename include guard.
9402         * tui/tui-data.h: Rename include guard.
9403         * tui/tui-command.h: Rename include guard.
9404         * tic6x-tdep.h: Add include guard.
9405         * target/waitstatus.h: Rename include guard.
9406         * target/wait.h: Rename include guard.
9407         * target/target.h: Rename include guard.
9408         * target/resume.h: Rename include guard.
9409         * target-float.h: Rename include guard.
9410         * stabsread.h: Add include guard.
9411         * rs6000-tdep.h: Add include guard.
9412         * riscv-fbsd-tdep.h: Add include guard.
9413         * regformats/regdef.h: Rename include guard.
9414         * record.h: Rename include guard.
9415         * python/python.h: Rename include guard.
9416         * python/python-internal.h: Rename include guard.
9417         * python/py-stopevent.h: Rename include guard.
9418         * python/py-ref.h: Rename include guard.
9419         * python/py-record.h: Rename include guard.
9420         * python/py-record-full.h: Rename include guard.
9421         * python/py-record-btrace.h: Rename include guard.
9422         * python/py-instruction.h: Rename include guard.
9423         * python/py-events.h: Rename include guard.
9424         * python/py-event.h: Rename include guard.
9425         * procfs.h: Add include guard.
9426         * proc-utils.h: Add include guard.
9427         * p-lang.h: Add include guard.
9428         * or1k-tdep.h: Rename include guard.
9429         * observable.h: Rename include guard.
9430         * nto-tdep.h: Rename include guard.
9431         * nat/x86-linux.h: Rename include guard.
9432         * nat/x86-linux-dregs.h: Rename include guard.
9433         * nat/x86-gcc-cpuid.h: Add include guard.
9434         * nat/x86-dregs.h: Rename include guard.
9435         * nat/x86-cpuid.h: Rename include guard.
9436         * nat/ppc-linux.h: Rename include guard.
9437         * nat/mips-linux-watch.h: Rename include guard.
9438         * nat/linux-waitpid.h: Rename include guard.
9439         * nat/linux-ptrace.h: Rename include guard.
9440         * nat/linux-procfs.h: Rename include guard.
9441         * nat/linux-osdata.h: Rename include guard.
9442         * nat/linux-nat.h: Rename include guard.
9443         * nat/linux-namespaces.h: Rename include guard.
9444         * nat/linux-btrace.h: Rename include guard.
9445         * nat/glibc_thread_db.h: Rename include guard.
9446         * nat/gdb_thread_db.h: Rename include guard.
9447         * nat/gdb_ptrace.h: Rename include guard.
9448         * nat/fork-inferior.h: Rename include guard.
9449         * nat/amd64-linux-siginfo.h: Rename include guard.
9450         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9451         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9452         * nat/aarch64-linux.h: Rename include guard.
9453         * nat/aarch64-linux-hw-point.h: Rename include guard.
9454         * mn10300-tdep.h: Add include guard.
9455         * mips-linux-tdep.h: Add include guard.
9456         * mi/mi-parse.h: Rename include guard.
9457         * mi/mi-out.h: Rename include guard.
9458         * mi/mi-main.h: Rename include guard.
9459         * mi/mi-interp.h: Rename include guard.
9460         * mi/mi-getopt.h: Rename include guard.
9461         * mi/mi-console.h: Rename include guard.
9462         * mi/mi-common.h: Rename include guard.
9463         * mi/mi-cmds.h: Rename include guard.
9464         * mi/mi-cmd-break.h: Rename include guard.
9465         * m2-lang.h: Add include guard.
9466         * location.h: Rename include guard.
9467         * linux-record.h: Rename include guard.
9468         * linux-nat.h: Add include guard.
9469         * linux-fork.h: Add include guard.
9470         * i386-darwin-tdep.h: Rename include guard.
9471         * hppa-linux-offsets.h: Add include guard.
9472         * guile/guile.h: Rename include guard.
9473         * guile/guile-internal.h: Rename include guard.
9474         * gnu-nat.h: Rename include guard.
9475         * gdb-stabs.h: Rename include guard.
9476         * frv-tdep.h: Add include guard.
9477         * f-lang.h: Add include guard.
9478         * event-loop.h: Add include guard.
9479         * darwin-nat.h: Rename include guard.
9480         * cp-abi.h: Rename include guard.
9481         * config/sparc/nm-sol2.h: Rename include guard.
9482         * config/nm-nto.h: Rename include guard.
9483         * config/nm-linux.h: Add include guard.
9484         * config/i386/nm-i386gnu.h: Rename include guard.
9485         * config/djgpp/nl_types.h: Rename include guard.
9486         * config/djgpp/langinfo.h: Rename include guard.
9487         * compile/gcc-cp-plugin.h: Add include guard.
9488         * compile/gcc-c-plugin.h: Add include guard.
9489         * compile/compile.h: Rename include guard.
9490         * compile/compile-object-run.h: Rename include guard.
9491         * compile/compile-object-load.h: Rename include guard.
9492         * compile/compile-internal.h: Rename include guard.
9493         * compile/compile-cplus.h: Rename include guard.
9494         * compile/compile-c.h: Rename include guard.
9495         * common/xml-utils.h: Rename include guard.
9496         * common/x86-xstate.h: Rename include guard.
9497         * common/version.h: Rename include guard.
9498         * common/vec.h: Rename include guard.
9499         * common/tdesc.h: Rename include guard.
9500         * common/selftest.h: Rename include guard.
9501         * common/scoped_restore.h: Rename include guard.
9502         * common/scoped_mmap.h: Rename include guard.
9503         * common/scoped_fd.h: Rename include guard.
9504         * common/safe-iterator.h: Rename include guard.
9505         * common/run-time-clock.h: Rename include guard.
9506         * common/refcounted-object.h: Rename include guard.
9507         * common/queue.h: Rename include guard.
9508         * common/ptid.h: Rename include guard.
9509         * common/print-utils.h: Rename include guard.
9510         * common/preprocessor.h: Rename include guard.
9511         * common/pathstuff.h: Rename include guard.
9512         * common/observable.h: Rename include guard.
9513         * common/netstuff.h: Rename include guard.
9514         * common/job-control.h: Rename include guard.
9515         * common/host-defs.h: Rename include guard.
9516         * common/gdb_wait.h: Rename include guard.
9517         * common/gdb_vecs.h: Rename include guard.
9518         * common/gdb_unlinker.h: Rename include guard.
9519         * common/gdb_unique_ptr.h: Rename include guard.
9520         * common/gdb_tilde_expand.h: Rename include guard.
9521         * common/gdb_sys_time.h: Rename include guard.
9522         * common/gdb_string_view.h: Rename include guard.
9523         * common/gdb_splay_tree.h: Rename include guard.
9524         * common/gdb_setjmp.h: Rename include guard.
9525         * common/gdb_ref_ptr.h: Rename include guard.
9526         * common/gdb_optional.h: Rename include guard.
9527         * common/gdb_locale.h: Rename include guard.
9528         * common/gdb_assert.h: Rename include guard.
9529         * common/filtered-iterator.h: Rename include guard.
9530         * common/filestuff.h: Rename include guard.
9531         * common/fileio.h: Rename include guard.
9532         * common/environ.h: Rename include guard.
9533         * common/common-utils.h: Rename include guard.
9534         * common/common-types.h: Rename include guard.
9535         * common/common-regcache.h: Rename include guard.
9536         * common/common-inferior.h: Rename include guard.
9537         * common/common-gdbthread.h: Rename include guard.
9538         * common/common-exceptions.h: Rename include guard.
9539         * common/common-defs.h: Rename include guard.
9540         * common/common-debug.h: Rename include guard.
9541         * common/cleanups.h: Rename include guard.
9542         * common/buffer.h: Rename include guard.
9543         * common/btrace-common.h: Rename include guard.
9544         * common/break-common.h: Rename include guard.
9545         * cli/cli-utils.h: Rename include guard.
9546         * cli/cli-style.h: Rename include guard.
9547         * cli/cli-setshow.h: Rename include guard.
9548         * cli/cli-script.h: Rename include guard.
9549         * cli/cli-interp.h: Rename include guard.
9550         * cli/cli-decode.h: Rename include guard.
9551         * cli/cli-cmds.h: Rename include guard.
9552         * charset-list.h: Add include guard.
9553         * buildsym-legacy.h: Rename include guard.
9554         * bfin-tdep.h: Add include guard.
9555         * ax.h: Rename include guard.
9556         * arm-linux-tdep.h: Add include guard.
9557         * arm-fbsd-tdep.h: Add include guard.
9558         * arch/xtensa.h: Rename include guard.
9559         * arch/tic6x.h: Add include guard.
9560         * arch/i386.h: Add include guard.
9561         * arch/arm.h: Rename include guard.
9562         * arch/arm-linux.h: Rename include guard.
9563         * arch/arm-get-next-pcs.h: Rename include guard.
9564         * arch/amd64.h: Add include guard.
9565         * arch/aarch64-insn.h: Rename include guard.
9566         * arch-utils.h: Rename include guard.
9567         * annotate.h: Add include guard.
9568         * amd64-darwin-tdep.h: Rename include guard.
9569         * aarch64-linux-tdep.h: Add include guard.
9570         * aarch64-fbsd-tdep.h: Add include guard.
9571         * aarch32-linux-nat.h: Add include guard.
9572
9573 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9574
9575         * macrotab.c (macro_define_internal): New function that
9576         factorizes macro_define_object_internal and macro_define_function
9577         code.
9578         (macro_define_object_internal): Use macro_define_internal.
9579         (macro_define_function): Likewise.
9580
9581 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9582
9583         * macrocmd.c (extract_identifier): Return
9584         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9585         callers.
9586
9587 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9588
9589         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9590
9591 2019-02-05  Tom Tromey  <tom@tromey.com>
9592
9593         * target.c (target_stack::unpush): Move assertion earlier.
9594
9595 2019-01-30  Tom Tromey  <tom@tromey.com>
9596
9597         PR python/23615:
9598         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9599         (gdbpy_parse_and_eval): Likewise.
9600         * python/python-internal.h (gdbpy_allow_threads): New class.
9601
9602 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9603
9604         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9605         (aarch64_fbsd_fpregmap): Move earlier.
9606         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9607         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9608         instead of individual calls to trad_frame_set_reg_addr.
9609         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9610         earlier.
9611         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9612         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9613         instead of individual calls to trad_frame_set_reg_addr.
9614
9615 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9616
9617         * CONTRIBUTE: Replace contribution list with wiki link.
9618
9619 2019-01-25  Tom Tromey  <tom@tromey.com>
9620
9621         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9622
9623 2019-01-25  Tom Tromey  <tom@tromey.com>
9624
9625         * xtensa-linux-nat.c: Fix common/ includes.
9626         * xml-support.h: Fix common/ includes.
9627         * xml-support.c: Fix common/ includes.
9628         * x86-linux-nat.c: Fix common/ includes.
9629         * windows-nat.c: Fix common/ includes.
9630         * varobj.h: Fix common/ includes.
9631         * varobj.c: Fix common/ includes.
9632         * value.c: Fix common/ includes.
9633         * valops.c: Fix common/ includes.
9634         * utils.c: Fix common/ includes.
9635         * unittests/xml-utils-selftests.c: Fix common/ includes.
9636         * unittests/utils-selftests.c: Fix common/ includes.
9637         * unittests/unpack-selftests.c: Fix common/ includes.
9638         * unittests/tracepoint-selftests.c: Fix common/ includes.
9639         * unittests/style-selftests.c: Fix common/ includes.
9640         * unittests/string_view-selftests.c: Fix common/ includes.
9641         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9642         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9643         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9644         * unittests/rsp-low-selftests.c: Fix common/ includes.
9645         * unittests/parse-connection-spec-selftests.c: Fix common/
9646         includes.
9647         * unittests/optional-selftests.c: Fix common/ includes.
9648         * unittests/offset-type-selftests.c: Fix common/ includes.
9649         * unittests/observable-selftests.c: Fix common/ includes.
9650         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9651         * unittests/memrange-selftests.c: Fix common/ includes.
9652         * unittests/memory-map-selftests.c: Fix common/ includes.
9653         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9654         * unittests/function-view-selftests.c: Fix common/ includes.
9655         * unittests/environ-selftests.c: Fix common/ includes.
9656         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9657         * unittests/common-utils-selftests.c: Fix common/ includes.
9658         * unittests/cli-utils-selftests.c: Fix common/ includes.
9659         * unittests/array-view-selftests.c: Fix common/ includes.
9660         * ui-file.c: Fix common/ includes.
9661         * tui/tui-io.c: Fix common/ includes.
9662         * tracepoint.h: Fix common/ includes.
9663         * tracepoint.c: Fix common/ includes.
9664         * tracefile-tfile.c: Fix common/ includes.
9665         * top.h: Fix common/ includes.
9666         * top.c: Fix common/ includes.
9667         * thread.c: Fix common/ includes.
9668         * target/waitstatus.h: Fix common/ includes.
9669         * target/waitstatus.c: Fix common/ includes.
9670         * target.h: Fix common/ includes.
9671         * target.c: Fix common/ includes.
9672         * target-memory.c: Fix common/ includes.
9673         * target-descriptions.c: Fix common/ includes.
9674         * symtab.h: Fix common/ includes.
9675         * symfile.c: Fix common/ includes.
9676         * stap-probe.c: Fix common/ includes.
9677         * spu-linux-nat.c: Fix common/ includes.
9678         * sparc-nat.c: Fix common/ includes.
9679         * source.c: Fix common/ includes.
9680         * solib.c: Fix common/ includes.
9681         * solib-target.c: Fix common/ includes.
9682         * ser-unix.c: Fix common/ includes.
9683         * ser-tcp.c: Fix common/ includes.
9684         * ser-pipe.c: Fix common/ includes.
9685         * ser-base.c: Fix common/ includes.
9686         * selftest-arch.c: Fix common/ includes.
9687         * s12z-tdep.c: Fix common/ includes.
9688         * rust-exp.y: Fix common/ includes.
9689         * rs6000-aix-tdep.c: Fix common/ includes.
9690         * riscv-tdep.c: Fix common/ includes.
9691         * remote.c: Fix common/ includes.
9692         * remote-notif.h: Fix common/ includes.
9693         * remote-fileio.h: Fix common/ includes.
9694         * remote-fileio.c: Fix common/ includes.
9695         * regcache.h: Fix common/ includes.
9696         * regcache.c: Fix common/ includes.
9697         * record-btrace.c: Fix common/ includes.
9698         * python/python.c: Fix common/ includes.
9699         * python/py-type.c: Fix common/ includes.
9700         * python/py-inferior.c: Fix common/ includes.
9701         * progspace.h: Fix common/ includes.
9702         * producer.c: Fix common/ includes.
9703         * procfs.c: Fix common/ includes.
9704         * proc-api.c: Fix common/ includes.
9705         * printcmd.c: Fix common/ includes.
9706         * ppc-linux-nat.c: Fix common/ includes.
9707         * parser-defs.h: Fix common/ includes.
9708         * osdata.c: Fix common/ includes.
9709         * obsd-nat.c: Fix common/ includes.
9710         * nat/x86-linux.c: Fix common/ includes.
9711         * nat/x86-linux-dregs.c: Fix common/ includes.
9712         * nat/x86-dregs.h: Fix common/ includes.
9713         * nat/x86-dregs.c: Fix common/ includes.
9714         * nat/ppc-linux.c: Fix common/ includes.
9715         * nat/mips-linux-watch.h: Fix common/ includes.
9716         * nat/mips-linux-watch.c: Fix common/ includes.
9717         * nat/linux-waitpid.c: Fix common/ includes.
9718         * nat/linux-ptrace.h: Fix common/ includes.
9719         * nat/linux-ptrace.c: Fix common/ includes.
9720         * nat/linux-procfs.c: Fix common/ includes.
9721         * nat/linux-personality.c: Fix common/ includes.
9722         * nat/linux-osdata.c: Fix common/ includes.
9723         * nat/linux-namespaces.c: Fix common/ includes.
9724         * nat/linux-btrace.h: Fix common/ includes.
9725         * nat/linux-btrace.c: Fix common/ includes.
9726         * nat/fork-inferior.c: Fix common/ includes.
9727         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9728         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9729         * nat/aarch64-linux.c: Fix common/ includes.
9730         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9731         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9732         * namespace.h: Fix common/ includes.
9733         * mips-linux-tdep.c: Fix common/ includes.
9734         * minsyms.c: Fix common/ includes.
9735         * mi/mi-parse.h: Fix common/ includes.
9736         * mi/mi-main.c: Fix common/ includes.
9737         * mi/mi-cmd-env.c: Fix common/ includes.
9738         * memrange.h: Fix common/ includes.
9739         * memattr.c: Fix common/ includes.
9740         * maint.h: Fix common/ includes.
9741         * maint.c: Fix common/ includes.
9742         * main.c: Fix common/ includes.
9743         * machoread.c: Fix common/ includes.
9744         * location.c: Fix common/ includes.
9745         * linux-thread-db.c: Fix common/ includes.
9746         * linux-nat.c: Fix common/ includes.
9747         * linux-fork.c: Fix common/ includes.
9748         * inline-frame.c: Fix common/ includes.
9749         * infrun.c: Fix common/ includes.
9750         * inflow.c: Fix common/ includes.
9751         * inferior.h: Fix common/ includes.
9752         * inferior.c: Fix common/ includes.
9753         * infcmd.c: Fix common/ includes.
9754         * inf-ptrace.c: Fix common/ includes.
9755         * inf-child.c: Fix common/ includes.
9756         * ia64-linux-nat.c: Fix common/ includes.
9757         * i387-tdep.c: Fix common/ includes.
9758         * i386-tdep.c: Fix common/ includes.
9759         * i386-linux-tdep.c: Fix common/ includes.
9760         * i386-linux-nat.c: Fix common/ includes.
9761         * i386-go32-tdep.c: Fix common/ includes.
9762         * i386-fbsd-tdep.c: Fix common/ includes.
9763         * i386-fbsd-nat.c: Fix common/ includes.
9764         * guile/scm-type.c: Fix common/ includes.
9765         * guile/guile.c: Fix common/ includes.
9766         * go32-nat.c: Fix common/ includes.
9767         * gnu-nat.c: Fix common/ includes.
9768         * gdbthread.h: Fix common/ includes.
9769         * gdbarch-selftests.c: Fix common/ includes.
9770         * gdb_usleep.c: Fix common/ includes.
9771         * gdb_select.h: Fix common/ includes.
9772         * gdb_bfd.c: Fix common/ includes.
9773         * gcore.c: Fix common/ includes.
9774         * fork-child.c: Fix common/ includes.
9775         * findvar.c: Fix common/ includes.
9776         * fbsd-nat.c: Fix common/ includes.
9777         * event-top.c: Fix common/ includes.
9778         * event-loop.c: Fix common/ includes.
9779         * dwarf2read.c: Fix common/ includes.
9780         * dwarf2loc.c: Fix common/ includes.
9781         * dwarf2-frame.c: Fix common/ includes.
9782         * dwarf-index-cache.c: Fix common/ includes.
9783         * dtrace-probe.c: Fix common/ includes.
9784         * disasm-selftests.c: Fix common/ includes.
9785         * defs.h: Fix common/ includes.
9786         * csky-tdep.c: Fix common/ includes.
9787         * cp-valprint.c: Fix common/ includes.
9788         * cp-support.h: Fix common/ includes.
9789         * cp-support.c: Fix common/ includes.
9790         * corelow.c: Fix common/ includes.
9791         * completer.h: Fix common/ includes.
9792         * completer.c: Fix common/ includes.
9793         * compile/compile.c: Fix common/ includes.
9794         * compile/compile-loc2c.c: Fix common/ includes.
9795         * compile/compile-cplus-types.c: Fix common/ includes.
9796         * compile/compile-cplus-symbols.c: Fix common/ includes.
9797         * command.h: Fix common/ includes.
9798         * cli/cli-dump.c: Fix common/ includes.
9799         * cli/cli-cmds.c: Fix common/ includes.
9800         * charset.c: Fix common/ includes.
9801         * build-id.c: Fix common/ includes.
9802         * btrace.h: Fix common/ includes.
9803         * btrace.c: Fix common/ includes.
9804         * breakpoint.h: Fix common/ includes.
9805         * breakpoint.c: Fix common/ includes.
9806         * ax.h:
9807         (enum agent_op): Fix common/ includes.
9808         * ax-general.c (struct aop_map): Fix common/ includes.
9809         * ax-gdb.c: Fix common/ includes.
9810         * auxv.c: Fix common/ includes.
9811         * auto-load.c: Fix common/ includes.
9812         * arm-tdep.c: Fix common/ includes.
9813         * arch/riscv.c: Fix common/ includes.
9814         * arch/ppc-linux-common.c: Fix common/ includes.
9815         * arch/i386.c: Fix common/ includes.
9816         * arch/arm.c: Fix common/ includes.
9817         * arch/arm-linux.c: Fix common/ includes.
9818         * arch/arm-get-next-pcs.c: Fix common/ includes.
9819         * arch/amd64.c: Fix common/ includes.
9820         * arch/aarch64.c: Fix common/ includes.
9821         * arch/aarch64-insn.c: Fix common/ includes.
9822         * arch-utils.c: Fix common/ includes.
9823         * amd64-windows-tdep.c: Fix common/ includes.
9824         * amd64-tdep.c: Fix common/ includes.
9825         * amd64-sol2-tdep.c: Fix common/ includes.
9826         * amd64-obsd-tdep.c: Fix common/ includes.
9827         * amd64-nbsd-tdep.c: Fix common/ includes.
9828         * amd64-linux-tdep.c: Fix common/ includes.
9829         * amd64-linux-nat.c: Fix common/ includes.
9830         * amd64-fbsd-tdep.c: Fix common/ includes.
9831         * amd64-fbsd-nat.c: Fix common/ includes.
9832         * amd64-dicos-tdep.c: Fix common/ includes.
9833         * amd64-darwin-tdep.c: Fix common/ includes.
9834         * agent.c: Fix common/ includes.
9835         * ada-lang.h: Fix common/ includes.
9836         * ada-lang.c: Fix common/ includes.
9837         * aarch64-tdep.c: Fix common/ includes.
9838
9839 2019-01-25  Tom Tromey  <tom@tromey.com>
9840
9841         * common/create-version.sh: Use common/version.h.
9842
9843 2019-01-24  Pedro Alves  <palves@redhat.com>
9844
9845         * infrun.c (signal_stop, signal_print, signal_program)
9846         (signal_catch, signal_pass): Now arrays instead of pointers.
9847         (update_signals_program_target, do_target_resume)
9848         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9849         * linux-nat.c (linux_nat_target::pass_signals)
9850         (linux_nat_target::create_inferior, linux_nat_target::attach):
9851         Adjust.
9852         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9853         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9854         * procfs.c (procfs_target::pass_signals): Adjust.
9855         * record-full.c (record_full_target::resume): Adjust.
9856         * remote.c (remote_target::pass_signals)
9857         (remote_target::program_signals): Adjust.
9858         * target-debug.h (target_debug_print_signals): Now takes a
9859         gdb::array_view as parameter.  Adjust.
9860         * target.h (target_ops) <pass_signals, program_signals>: Replace
9861         pointer and length parameters with gdb::array_view.
9862         (target_pass_signals, target_program_signals): Likewise.
9863         * target-delegates.c: Regenerate.
9864
9865 2019-01-24  Pedro Alves  <palves@redhat.com>
9866
9867         * common/forward-scope-exit.h
9868         (forward_scope_exit::forward_scope_exit): Pass arguments to
9869         m_bind_function directly, instead of creating a std::bind and
9870         copying that.
9871
9872 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9873
9874         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9875         for static members.
9876         (pass_in_v_vfp_candidate): Likewise.
9877
9878 2019-01-23  Tom Tromey  <tom@tromey.com>
9879             Pedro Alves  <palves@redhat.com>
9880
9881         * regcache.c (class regcache_invalidator): Remove.
9882         (regcache::raw_write): Use make_scope_exit.
9883
9884 2019-01-23  Tom Tromey  <tom@tromey.com>
9885
9886         * ui-out.h (class ui_out_emit_type): Update comment.
9887
9888 2019-01-23  Tom Tromey  <tom@tromey.com>
9889
9890         * infrun.c (fetch_inferior_event): Update comment.
9891
9892 2019-01-23  Tom Tromey  <tom@tromey.com>
9893             Pedro Alves  <palves@redhat.com>
9894
9895         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9896         parameter.
9897         (fetch_inferior_event): Use SCOPE_EXIT.
9898
9899
9900 2019-01-23  Tom Tromey  <tom@tromey.com>
9901             Pedro Alves  <palves@redhat.com>
9902
9903         * infrun.c (disable_thread_events): Delete.
9904         (stop_all_threads): Use SCOPE_EXIT.
9905
9906 2019-01-23  Tom Tromey  <tom@tromey.com>
9907             Pedro Alves  <palves@redhat.com>
9908
9909         * symfile.c: Include forward-scope-exit.h.
9910         (clear_symtab_users_cleanup): Replace forward declaration with
9911         a FORWARD_SCOPE_EXIT.
9912         (syms_from_objfile_1): Use the forward_scope_exit and
9913         gdb::optional instead of cleanup_function.
9914         (reread_symbols): Use the forward_scope_exit instead of
9915         cleanup_function.
9916         (clear_symtab_users_cleanup): Remove function.
9917
9918 2019-01-23  Tom Tromey  <tom@tromey.com>
9919             Pedro Alves  <palves@redhat.com>
9920
9921         * linux-nat.c: Include scope-exit.h.
9922         (cleanup_target_stop): Remove.
9923         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9924         SCOPE_EXIT.
9925
9926 2019-01-23  Tom Tromey  <tom@tromey.com>
9927             Pedro Alves  <palves@redhat.com>
9928
9929         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9930         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9931
9932 2019-01-23  Tom Tromey  <tom@tromey.com>
9933             Andrew Burgess  <andrew.burgess@embecosm.com>
9934             Pedro Alves  <palves@redhat.com>
9935
9936         * infrun.c (fetch_inferior_event): Use scope_exit.
9937         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9938         * top.c (execute_command): Use scope_exit.
9939         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9940         * utils.c (do_bpstat_clear_actions_cleanup)
9941         (make_bpstat_clear_actions_cleanup): Remove.
9942
9943 2019-01-23  Tom Tromey  <tom@tromey.com>
9944             Pedro Alves  <palves@redhat.com>
9945
9946         * infrun.c: Include "common/scope-exit.h"
9947         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9948         (wait_for_inferior): Use SCOPE_EXIT.
9949         (fetch_inferior_event): Use scope_exit.
9950
9951 2019-01-23  Tom Tromey  <tom@tromey.com>
9952             Pedro Alves  <palves@redhat.com>
9953
9954         * breakpoint.c (create_breakpoint): Remove cleanup.
9955
9956 2019-01-23  Tom Tromey  <tom@tromey.com>
9957             Andrew Burgess  <andrew.burgess@embecosm.com>
9958             Pedro Alves  <palves@redhat.com>
9959
9960 2019-01-23  Pedro Alves  <palves@redhat.com>
9961
9962         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9963
9964 2019-01-23  Pedro Alves  <palves@redhat.com>
9965             Andrew Burgess  <andrew.burgess@embecosm.com>
9966
9967         * gdbthread.h: Include "common/forward-scope-exit.h".
9968         (scoped_finish_thread_state): Redefine custom class in terms of
9969         forward_scope_exit.
9970
9971 2019-01-23  Pedro Alves  <palves@redhat.com>
9972             Andrew Burgess  <andrew.burgess@embecosm.com>
9973
9974         * common/forward-scope-exit.h: New file.
9975
9976 2019-01-23  Pedro Alves  <palves@redhat.com>
9977             Andrew Burgess  <andrew.burgess@embecosm.com>
9978             Tom Tromey  <tom@tromey.com>
9979
9980         * common/scope-exit.h: New file.
9981
9982 2019-01-23  Pedro Alves  <palves@redhat.com>
9983
9984         * common/preprocessor.h (ESC): Rename to ...
9985         (ESC_PARENS): ... this.
9986         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9987         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9988
9989 2019-01-23  Tom Tromey  <tom@tromey.com>
9990
9991         * language.h (class scoped_switch_to_sym_language_if_auto):
9992         Initialize m_lang in both cases.
9993
9994 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9995
9996         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9997         with XCNEW.
9998
9999 2019-01-22  Tom Tromey  <tom@tromey.com>
10000
10001         * corelow.c: Do not include sys/file.h.
10002
10003 2019-01-22  Tom Tromey  <tom@tromey.com>
10004
10005         * tui/tui-wingeneral.h: Include gdb_curses.h.
10006
10007 2019-01-22  Tom Tromey  <tom@tromey.com>
10008
10009         * source-cache.h (class source_cache) <get_source_lines,
10010         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10011
10012 2019-01-22  Tom Tromey  <tom@tromey.com>
10013
10014         * remote-fileio.h (struct remote_target): Declare.
10015
10016 2019-01-22  Tom Tromey  <tom@tromey.com>
10017
10018         * python/py-arch.c: Do not include py-ref.h.
10019         * python/py-bpevent.c: Do not include py-ref.h.
10020         * python/py-cmd.c: Do not include py-ref.h.
10021         * python/py-continueevent.c: Do not include py-ref.h.
10022         * python/py-event.h: Do not include py-ref.h.
10023         * python/py-evtregistry.c: Do not include py-ref.h.
10024         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10025         * python/py-frame.c: Do not include py-ref.h.
10026         * python/py-framefilter.c: Do not include py-ref.h.
10027         * python/py-function.c: Do not include py-ref.h.
10028         * python/py-infevents.c: Do not include py-ref.h.
10029         * python/py-linetable.c: Do not include py-ref.h.
10030         * python/py-objfile.c: Do not include py-ref.h.
10031         * python/py-param.c: Do not include py-ref.h.
10032         * python/py-prettyprint.c: Do not include py-ref.h.
10033         * python/py-progspace.c: Do not include py-ref.h.
10034         * python/py-symbol.c: Do not include py-ref.h.
10035         * python/py-symtab.c: Do not include py-ref.h.
10036         * python/py-type.c: Do not include py-ref.h.
10037         * python/py-unwind.c: Do not include py-ref.h.
10038         * python/py-utils.c: Do not include py-ref.h.
10039         * python/py-value.c: Do not include py-ref.h.
10040         * python/py-varobj.c: Do not include py-ref.h.
10041         * python/py-xmethods.c: Do not include py-ref.h.
10042         * python/python.c: Do not include py-ref.h.
10043         * varobj.c: Do not include py-ref.h.
10044
10045 2019-01-22  Tom Tromey  <tom@tromey.com>
10046
10047         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10048         keyword for bcache.
10049
10050 2019-01-22  Tom Tromey  <tom@tromey.com>
10051
10052         * compile/compile-cplus-types.c: Remove a comment by #include.
10053
10054 2019-01-22  Tom Tromey  <tom@tromey.com>
10055
10056         * compile/gcc-c-plugin.h: Include compile-internal.h.
10057
10058 2019-01-22  Tom Tromey  <tom@tromey.com>
10059
10060         * stabsread.c (EXTERN): Do not define.
10061         (symnum, next_symbol_text_func, processing_gcc_compilation)
10062         (within_function, global_sym_chain, global_stabs)
10063         (previous_stab_code, this_object_header_files)
10064         (n_this_object_header_files)
10065         (n_allocated_this_object_header_files): Define.
10066         * stabsread.h (EXTERN): Never define.  Use "extern".
10067
10068 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10069
10070         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10071         history_value.
10072
10073 2019-01-21  Tom Tromey  <tom@tromey.com>
10074
10075         * ui-out.c: Fix includes.
10076         * tui/tui-source.c: Fix includes.
10077         * target.c: Fix includes.
10078         * remote.c: Fix includes.
10079         * regcache.c: Fix includes.
10080         * python/py-block.c: Fix includes.
10081         * printcmd.c: Fix includes.
10082         * or1k-tdep.c: Fix includes.
10083         * mi/mi-main.c: Fix includes.
10084         * m32r-tdep.c: Fix includes.
10085         * csky-tdep.c: Fix includes.
10086         * compile/compile-cplus-types.c: Fix includes.
10087         * cli/cli-interp.c: Fix includes.
10088
10089 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10090
10091         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10092         for padding.
10093
10094 2019-01-16  Tom Tromey  <tom@tromey.com>
10095
10096         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10097         earlier.
10098         (struct objfile) <msymbols_range>: Move from top level.
10099         <msymbols>: New method.
10100         (class objfile_msymbols): Remove.
10101         * symtab.c (default_collect_symbol_completion_matches_break_on):
10102         Update.
10103         * symmisc.c (dump_msymbols): Update.
10104         * stabsread.c (scan_file_globals): Update.
10105         * objc-lang.c (info_selectors_command, info_classes_command)
10106         (find_methods): Update.
10107         * minsyms.c (find_solib_trampoline_target): Update.
10108         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10109         * coffread.c (coff_symfile_read): Update.
10110         * ada-lang.c (ada_lookup_simple_minsym)
10111         (ada_collect_symbol_completion_matches): Update.
10112
10113 2019-01-16  Tom Tromey  <tom@tromey.com>
10114
10115         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10116         type.  Remove no-argument constructor.
10117         <iterator::operator++>: Simplify.
10118         <begin>: Update.
10119         <end>: Use minimal_symbol_count.
10120
10121 2019-01-16  Tom Tromey  <tom@tromey.com>
10122
10123         * objfiles.h (struct objfile) <psymtabs>: New method.
10124         (class objfile_psymtabs): Remove.
10125         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10126         typedef.
10127         <range>: New method.
10128         (require_partial_symbols): Change return type.
10129         * psymtab.c (require_partial_symbols)
10130         (psym_expand_symtabs_matching): Update.
10131         * mdebugread.c (parse_partial_symbols): Update.
10132         * dbxread.c (dbx_end_psymtab): Update.
10133
10134 2019-01-15  Tom Tromey  <tom@tromey.com>
10135
10136         * symtab.c (lookup_objfile_from_block)
10137         (lookup_symbol_in_objfile_symtabs)
10138         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10139         (find_line_symtab, info_sources_command)
10140         (default_collect_symbol_completion_matches_break_on)
10141         (make_source_files_completion_list): Update.
10142         * symmisc.c (print_objfile_statistics, dump_objfile)
10143         (maintenance_print_symbols, maintenance_info_symtabs)
10144         (maintenance_check_symtabs, maintenance_info_line_tables):
10145         Update.
10146         * source.c (select_source_symtab)
10147         (forget_cached_source_info_for_objfile): Update.
10148         * objfiles.h (class objfile_compunits): Remove.
10149         (struct objfile) <compunits_range>: New typedef.
10150         (compunits): New method.
10151         * objfiles.c (objfile_relocate1): Update.
10152         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10153         * maint.c (count_symtabs_and_blocks): Update.
10154         * linespec.c (iterate_over_all_matching_symtabs): Update.
10155         * cp-support.c (add_symbol_overload_list_qualified): Update.
10156         * coffread.c (coff_symtab_read): Update.
10157         * ada-lang.c (add_nonlocal_symbols)
10158         (ada_collect_symbol_completion_matches)
10159         (ada_add_global_exceptions): Update.
10160
10161 2019-01-15  Tom Tromey  <tom@tromey.com>
10162
10163         * progspace.h (program_space) <objfiles_safe_range>: New
10164         typedef.
10165         <objfiles_safe>: New method.
10166         * objfiles.h (class all_objfiles_safe): Remove.
10167         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10168         * jit.c (jit_inferior_exit_hook): Update.
10169
10170 2019-01-17  Tom Tromey  <tom@tromey.com>
10171
10172         * progspace.h (program_space) <objfiles_range>: New typedef.
10173         <objfiles>: New method.
10174         <objfiles_head>: Rename from objfiles.
10175         (object_files): Update.
10176         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10177         * guile/scm-pretty-print.c
10178         (ppscm_find_pretty_printer_from_objfiles): Update.
10179         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10180         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10181         Update.
10182         * python/py-progspace.c (pspy_get_objfiles): Update.
10183         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10184         Update.
10185         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10186         (objfpy_lookup_objfile_by_build_id): Update.
10187         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10188         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10189         Update.
10190         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10191         (expand_symtab_containing_pc, lookup_objfile_from_block)
10192         (lookup_static_symbol, basic_lookup_transparent_type)
10193         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10194         (find_line_symtab, info_sources_command)
10195         (default_collect_symbol_completion_matches_break_on)
10196         (make_source_files_completion_list, find_main_name): Update.
10197         * symmisc.c (print_symbol_bcache_statistics)
10198         (print_objfile_statistics, maintenance_print_symbols)
10199         (maintenance_print_msymbols, maintenance_print_objfiles)
10200         (maintenance_info_symtabs, maintenance_check_symtabs)
10201         (maintenance_expand_symtabs, maintenance_info_line_tables):
10202         Update.
10203         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10204         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10205         (map_overlay_command, unmap_overlay_command)
10206         (simple_overlay_update, expand_symtabs_matching)
10207         (map_symbol_filenames): Update.
10208         * symfile-debug.c (set_debug_symfile): Update.
10209         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10210         Update.
10211         * source.c (select_source_symtab, forget_cached_source_info):
10212         Update.
10213         * solib.c (solib_read_symbols): Update.
10214         * solib-spu.c (append_ocl_sos): Update.
10215         * psymtab.c (maintenance_print_psymbols)
10216         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10217         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10218         * printcmd.c (info_symbol_command): Update.
10219         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10220         Update.
10221         * objfiles.h (class all_objfiles): Remove.
10222         * objfiles.c (have_partial_symbols, have_full_symbols)
10223         (have_minimal_symbols, qsort_cmp, update_section_map)
10224         (shared_objfile_contains_address_p)
10225         (default_iterate_over_objfiles_in_search_order): Update.
10226         * objc-lang.c (info_selectors_command, info_classes_command)
10227         (find_methods): Update.
10228         * minsyms.c (find_solib_trampoline_target): Update.
10229         * maint.c (maintenance_info_sections)
10230         (maintenance_translate_address, count_symtabs_and_blocks):
10231         Update.
10232         * main.c (captured_main_1): Update.
10233         * linux-thread-db.c (try_thread_db_load_from_pdir)
10234         (has_libpthread): Update.
10235         * linespec.c (iterate_over_all_matching_symtabs)
10236         (search_minsyms_for_name): Update.
10237         * jit.c (jit_find_objf_with_entry_addr): Update.
10238         * hppa-tdep.c (find_unwind_entry)
10239         (hppa_lookup_stub_minimal_symbol): Update.
10240         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10241         Update.
10242         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10243         (elf_gnu_ifunc_resolve_by_got): Update.
10244         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10245         * dwarf-index-write.c (save_gdb_index_command): Update.
10246         * cp-support.c (add_symbol_overload_list_qualified): Update.
10247         * breakpoint.c (create_overlay_event_breakpoint)
10248         (create_longjmp_master_breakpoint)
10249         (create_std_terminate_master_breakpoint)
10250         (create_exception_master_breakpoint): Update.
10251         * blockframe.c (find_pc_partial_function): Update.
10252         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10253         (ada_collect_symbol_completion_matches)
10254         (ada_add_global_exceptions): Update.
10255
10256 2019-01-17  Tom Tromey  <tom@tromey.com>
10257
10258         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10259         declare VEC.
10260         (solib_target_parse_libraries): Change return type.
10261         (library_list_start_segment, library_list_start_section)
10262         (library_list_end_library, library_list_start_library); Update.
10263         (solib_target_free_library_list): Remove.
10264         (solib_target_parse_libraries): Remove cleanup.  Change return
10265         type.
10266         (solib_target_current_sos): Update.
10267
10268 2019-01-17  Tom Tromey  <tromey@bapiya>
10269
10270         * valprint.c: Replace "the the" with "the".
10271         * symtab.c: Replace "the the" with "the".
10272         * solib.c: Replace "the the" with "the".
10273         * solib-dsbt.c: Replace "the the" with "the".
10274         * linespec.c: Replace "the the" with "the".
10275         * dwarf2loc.h: Replace "the the" with "the".
10276         * amd64-windows-tdep.c: Replace "the the" with "the".
10277         * aarch64-tdep.c: Replace "the the" with "the".
10278
10279 2019-01-16  Keith Seitz  <keiths@redhat.com>
10280
10281         PR gdb/23773
10282         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10283         <builder>: Rename to ..
10284         <m_builder>: ... this and make private.
10285         (dwarf2_cu::get_builder): New method.  Change all users of
10286         `builder' to use this method.
10287         (dwarf2_start_symtab): Move to ...
10288         (dwarf2_cu::start_symtab): ... here.  Update all callers
10289         (setup_type_unit_groups): Move to ...
10290         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10291         callers.
10292         (dwarf2_cu::reset_builder): New method.
10293         (process_full_compunit, process_full_type_unit): Use
10294         dwarf2_cu::reset_builder.
10295         (follow_die_offset): Record the ancestor CU if it is different
10296         from the followed DIE's CU.
10297         (follow_die_sig_1): Likewise.
10298
10299 2019-01-15  Tom Tromey  <tom@tromey.com>
10300
10301         * remote.c (class remote_state) <buf>: Now a char_vector.
10302         <buf_size>: Remove.
10303         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10304         parameter.
10305         (remote_target::getpkt_or_notif_sane_1)
10306         (remote_target::getpkt_sane)
10307         (remote_target::getpkt_or_notif_sane): Likewise.
10308         (class remote_target) <putpkt>: New overload.
10309         (remote_target::read_frame): Change type of "buf_p".  Remove
10310         sizeof_p parameter.
10311         (packet_ok): New overload.
10312         (packet_check_result): New overload.
10313         Update all uses.
10314
10315 2019-01-14  Tom Tromey  <tom@tromey.com>
10316
10317         * remote-notif.c (handle_notification, remote_notif_ack)
10318         (remote_notif_parse): Make "buf" const.
10319         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10320         const.
10321         (remote_notif_parse, remote_notif_ack, handle_notification):
10322         Likewise.
10323         * remote.c (remote_notif_stop_parse): Make "buf" const.
10324         (remote_target::remote_parse_stop_reply): Make "buf" const.
10325         (remote_notif_stop_ack): Make "buf" const.
10326
10327 2019-01-14  Tom Tromey  <tom@tromey.com>
10328
10329         * remote.c (remote_console_output): Make parameter const.
10330
10331 2019-01-14  Tom Tromey  <tom@tromey.com>
10332
10333         * target-debug.h (target_debug_print_signals): Constify.
10334         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10335         * procfs.c (procfs_target::pass_signals): Update.
10336         * linux-nat.c (linux_nat_target::pass_signals): Update.
10337         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10338         * target-delegates.c: Rebuild.
10339         * remote.c (remote_target::program_signals): Update.
10340         (remote_target::pass_signals): Update.
10341         * target.c (target_pass_signals): Constify argument.
10342         (target_program_signals): Likewise.
10343         * target.h (struct target_ops) <pass_signals, program_signals>:
10344         Constify argument.
10345         (target_pass_signals, target_program_signals): Constify argument.
10346
10347 2019-01-14  Tom Tromey  <tom@tromey.com>
10348
10349         PR tui/28819:
10350         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10351
10352 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10353
10354         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10355         field.
10356         * rs6000-tdep.c: Include reggroups.h.
10357         (IS_V_ALIAS_PSEUDOREG): Define.
10358         (rs6000_register_name): Return names for the "vX" aliases.
10359         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10360         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10361         aliases.  Call default_register_reggroup_p for all other
10362         pseudo-registers.
10363         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10364         New functions.
10365         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10366         Handle "vX" aliases.
10367         (v_alias_pseudo_register_collect): New function.
10368         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10369         (rs6000_gdbarch_init): Initialize "vX" aliases as
10370         pseudo-registers.  Restore registration of
10371         rs6000_pseudo_register_reggroup_p with
10372         set_tdesc_pseudo_register_reggroup_p.
10373
10374 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10375
10376         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10377         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10378         set_gdbarch_num_pseudo_regs.
10379
10380 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10381
10382         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10383         Remove arg prefixname, add do_set and do_show.
10384         Add member functions set_list and show_list.
10385         * cli/cli-style.c (class cli_style_option): Update accordingly.
10386         (style_set_list): Move to file scope.
10387         (style_show_list): Likewise.
10388         (set_style): Call help_list.
10389         (show_style): Call cmd_show_list.
10390         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10391         Update to use the new macro.
10392
10393 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10394
10395         * ada-lang.c (_initialize_ada_language): Expand the help text
10396         for the "catch exception" command.
10397
10398 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10399
10400         * symtab.c (matching_obj_sections): Initialize obj,
10401         declare it closer to its usage.
10402
10403 2019-01-10  Tom Tromey  <tom@tromey.com>
10404
10405         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10406         (basic_inf_threads_range): Remove.
10407         (inf_threads_range, inf_non_exited_threads_range)
10408         (safe_inf_threads_range): Use next_adapter.
10409
10410 2019-01-10  Keith Seitz  <keiths@redhat.com>
10411
10412         PR gdb/23712
10413         PR symtab/23010
10414         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10415         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10416
10417 2019-01-10  Keith Seitz  <keiths@redhat.com>
10418
10419         PR gdb/23712
10420         PR symtab/23010
10421         * dictionary.c (pending_to_vector): Remove.
10422         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10423         Remove _1 suffix, replacing functions of the same name.  Update
10424         all callers.
10425         (dict_create_hashed, dict_create_hashed_expandable)
10426         (dict_create_linear, dict_create_linear_expandable, dict_free)
10427         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10428         Make functions static.
10429
10430 2019-01-10  Keith Seitz  <keiths@redhat.com>
10431
10432         PR gdb/23712
10433         PR symtab/23010
10434         * dictionary.h (struct dictionary): Replace declaration with
10435         multidictionary.
10436         (dict_create_hashed, dict_create_hashed_expandable)
10437         (dict_create_linear, dict_create_linear_expandable)
10438         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10439         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10440         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10441         taking multidictionary argument.
10442         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10443         * block.h (struct block) <dict>: Change to multidictionary
10444         and rename `multidict'.
10445         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10446         symmisc.c: Update all dictionary references to multidictionary.
10447
10448 2019-01-10  Keith Seitz  <keiths@redhat.com>
10449
10450         PR gdb/23712
10451         PR symtab/23010
10452         * dictionary.c: Include unordered_map.
10453         (pending_to_vector): New function.
10454         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10455         Rewrite the non-"_1" functions to take vector instead
10456         of linked list.
10457         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10458         "new" _1 versions of the same name.
10459         (multidictionary): Define.
10460         (std::hash<enum language): New definition.
10461         (collate_pending_symbols_by_language, mdict_create_hashed)
10462         (mdict_create_hashed_expandable, mdict_create_linear)
10463         (mdict_create_linear_expandable, mdict_free)
10464         (find_language_dictionary, create_new_language_dictionary)
10465         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10466         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10467         (mdict_size, mdict_empty): New functions.
10468         * dictionary.h (mdict_iterator): Define.
10469
10470 2019-01-10  Pedro Alves  <palves@redhat.com>
10471
10472         * breakpoint.c (read_uploaded_action)
10473         (create_tracepoint_from_upload): Adjust to use
10474         gdb::unique_xmalloc_ptr.
10475         * ctf.c (ctf_write_uploaded_tp):
10476         (SET_ARRAY_FIELD): Use emplace_back.
10477         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10478         * tracefile-tfile.c (tfile_write_uploaded_tp):
10479         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10480         gdb::unique_xmalloc_ptr.
10481         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10482         at_string, cond_string, cmd_strings>: Replace char pointers
10483         with gdb::unique_xmalloc_ptr.
10484
10485 2019-01-10  Pedro Alves  <palves@redhat.com>
10486
10487         * solib-target.c (library_list_start_library): Don't xstrdup name.
10488
10489 2019-01-10  Pedro Alves  <palves@redhat.com>
10490
10491         * mdebugread.c (parse_partial_symbols): Use
10492         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10493
10494 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10495
10496         * linux-fork.c (scoped_switch_fork_info)
10497         <~scoped_switch_fork_info>: Fix incorrect variable name.
10498
10499 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10500
10501         * linux-fork.c (scoped_switch_fork_info)
10502         <scoped_switch_fork_info>: Make explicit.
10503         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10504
10505 2019-01-10  Tom Tromey  <tom@tromey.com>
10506
10507         * objfiles.h (objfile::reset_psymtabs): Update.
10508         * objfiles.c (objfile::objfile): Update.
10509         * psymtab.h (psymtab_storage::obstack): Update.
10510         (psymtab_storage::m_obstack): Use gdb::optional.
10511         (class psymtab_storage): Update comment.  Remove objfile
10512         parameter.
10513         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10514
10515 2019-01-10  Tom Tromey  <tom@tromey.com>
10516
10517         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10518         <free_psymtabs>: Now private.
10519         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10520         (allocate_psymtab): Use new method.
10521
10522 2019-01-10  Tom Tromey  <tom@tromey.com>
10523
10524         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10525         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10526         * mdebugread.c (parse_partial_symbols): Use
10527         allocate_dependencies.
10528         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10529         allocate_dependencies.
10530         (process_psymtab_comp_unit_reader)
10531         (build_type_psymtab_dependencies): Likewise.
10532         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10533
10534 2019-01-10  Tom Tromey  <tom@tromey.com>
10535
10536         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10537         PSYMBOL_SET_LANGUAGE.
10538         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10539
10540 2019-01-10  Tom Tromey  <tom@tromey.com>
10541
10542         * psymtab.h (psymtab_storage::obstack): New method.
10543         <m_obstack>: Rename from obstack; now private.
10544         * psymtab.c (psymtab_storage): Update.
10545         * dwarf2read.c (create_addrmap_from_index)
10546         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10547         Update.
10548
10549 2019-01-10  Tom Tromey  <tom@tromey.com>
10550
10551         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10552         * objfiles.h (objfile::reset_psymtabs): New method.
10553
10554 2019-01-10  Tom Tromey  <tom@tromey.com>
10555
10556         * symmisc.c (print_symbol_bcache_statistics): Update.
10557         (print_objfile_statistics): Update.
10558         * symfile.c (reread_symbols): Update.
10559         * psymtab.h (class psymtab_storage): New.
10560         * psymtab.c (psymtab_storage): New constructor.
10561         (~psymtab_storage): New destructor.
10562         (require_partial_symbols): Update.
10563         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10564         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10565         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10566         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10567         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10568         (start_psymtab_common, end_psymtab_common)
10569         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10570         (allocate_psymtab): Update.
10571         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10572         Update.
10573         (dump_psymtab_addrmap, maintenance_print_psymbols)
10574         (maintenance_check_psymtabs): Update.
10575         (class objfile_psymtabs): Move to objfiles.h.
10576         * psympriv.h (discard_psymtab): Now inline.
10577         (psymtab_discarder::psymtab_discarder): Update.
10578         (psymtab_discarder::~psymtab_discarder): Update.
10579         (ALL_OBJFILE_PSYMTABS): Rewrite.
10580         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10581         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10582         Remove fields.
10583         <partial_symtabs>: New field.
10584         (class objfile_psymtabs): Move from psymtab.h.  Update.
10585         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10586         psymbol_cache.
10587         (objfile::~objfile): Don't destroy psymbol_cache.
10588         * mdebugread.c (parse_partial_symbols): Update.
10589         * dwarf2read.c (create_addrmap_from_index)
10590         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10591         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10592         (add_partial_subprogram, dwarf2_ranges_read): Update.
10593         * dwarf-index-write.c (write_address_map)
10594         (write_one_signatured_type, recursively_write_psymbols)
10595         (class debug_names, class debug_names, write_psymtabs_to_index):
10596         Update.
10597
10598 2019-01-10  Tom Tromey  <tom@tromey.com>
10599
10600         * symtab.h (SYMBOL_SET_NAMES): Update.
10601         (symbol_set_names): Update.
10602         (MSYMBOL_SET_NAMES): Update.
10603         * symtab.c (symbol_set_names): Change argument to be an
10604         objfile_per_bfd_storage.
10605         * psymtab.c (add_psymbol_to_bcache): Update.
10606         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10607
10608 2019-01-10  Tom Tromey  <tom@tromey.com>
10609
10610         * symtab.c (create_demangled_names_hash): Change argument to be an
10611         objfile_per_bfd_storage.
10612         (symbol_set_names): Update.
10613
10614 2019-01-10  Tom Tromey  <tom@tromey.com>
10615
10616         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10617         init_psymbol_list.
10618         * psymtab.c (init_psymbol_list): Do nothing if already called.
10619         * psympriv.h (init_psymbol_list): Add comment.
10620         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10621         init_psymbol_list.
10622         * dbxread.c (dbx_symfile_read): Unconditionally call
10623         init_psymbol_list.
10624
10625 2019-01-10  Tom Tromey  <tom@tromey.com>
10626
10627         * xcoffread.c (scan_xcoff_symtab): Update.
10628         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10629         "where".
10630         * mdebugread.c (parse_partial_symbols)
10631         (handle_psymbol_enumerators): Update.
10632         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10633         * dbxread.c (read_dbx_symtab): Update.
10634         * psympriv.h (psymbol_placement): New enum.
10635         (add_psymbol_to_list): Update.
10636
10637 2019-01-10  Tom Tromey  <tom@tromey.com>
10638
10639         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10640         static_psymbols parameters.
10641         (scan_xcoff_symtab): Update.
10642         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10643         static_psymbols parameters.
10644         * psympriv.h (start_psymtab_common): Update.
10645         * mdebugread.c (parse_partial_symbols): Update.
10646         * dwarf2read.c (create_partial_symtab): Update.
10647         * dbxread.c (read_dbx_symtab): Update.
10648         (start_psymtab): Remove global_psymbols and static_psymbols
10649         parameters.
10650
10651 2019-01-10  Tom Tromey  <tom@tromey.com>
10652
10653         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10654         * psymtab.c (allocate_psymtab): Add comment.
10655         * psympriv.h (allocate_psymtab): Add comment.
10656         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10657         initializations.
10658         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10659
10660 2019-01-10  Tom Tromey  <tom@tromey.com>
10661
10662         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10663         Don't declare.
10664         * mipsread.c: Include mdebugread.h.
10665         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10666         Declare.
10667         * elfread.c: Include mdebugread.h.
10668
10669 2019-01-09  Tom Tromey  <tom@tromey.com>
10670
10671         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10672         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10673         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10674         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10675         (psym_lookup_symbol, psym_find_last_source_symtab)
10676         (psym_forget_cached_source_info, psym_print_stats)
10677         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10678         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10679         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10680         (psym_find_compunit_symtab_by_address)
10681         (maintenance_print_psymbols, maintenance_info_psymtabs)
10682         (maintenance_check_psymtabs): Use ranged for.
10683         * psymtab.h (class objfile_psymtabs): New.
10684         (require_partial_symbols): Return objfile_psymtabs.
10685         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10686
10687 2019-01-09  Tom Tromey  <tom@tromey.com>
10688
10689         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10690         (find_pc_mapped_section, list_overlays_command)
10691         (map_overlay_command, unmap_overlay_command)
10692         (simple_overlay_update): Use all_objfiles.
10693         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10694         * printcmd.c (info_symbol_command): Use all_objfiles.
10695         * objfiles.h (ALL_OBJSECTIONS): Remove.
10696         * maint.c (maintenance_translate_address): Use all_objfiles.
10697         * gcore.c (gcore_create_callback): Use all_objfiles.
10698         (objfile_find_memory_regions): Likewise.
10699
10700 2019-01-09  Tom Tromey  <tom@tromey.com>
10701
10702         * symtab.c (find_line_symtab, info_sources_command)
10703         (make_source_files_completion_list): Use objfile_compunits.
10704         * source.c (select_source_symtab): Use objfile_compunits.
10705         * objfiles.h (struct objfile): Update comment.
10706         (ALL_OBJFILES): Remove.
10707         (ALL_FILETABS): Remove.
10708         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10709         objfile_compunits.
10710
10711 2019-01-09  Tom Tromey  <tom@tromey.com>
10712
10713         * symmisc.c (print_objfile_statistics, dump_objfile)
10714         (maintenance_print_symbols): Use compunit_filetabs.
10715         * source.c (forget_cached_source_info_for_objfile): Use
10716         compunit_filetabs.
10717         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10718         (ALL_FILETABS): Use compunit_filetabs.
10719         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10720         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10721
10722 2019-01-09  Tom Tromey  <tom@tromey.com>
10723
10724         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10725         (compunit_filetabs): New.
10726         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10727         compunit_filetabs.
10728         (info_sources_command, make_source_files_completion_list): Remove
10729         declaration.
10730         * symmisc.c (print_objfile_statistics, dump_objfile)
10731         (maintenance_print_symbols): Remove declaration.
10732         (maintenance_info_symtabs): Use compunit_filetabs.
10733         (maintenance_info_line_tables): Likewise.
10734         * source.c (select_source_symtab): Change local variable name.
10735         (forget_cached_source_info_for_objfile): Remove declaration.
10736         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10737         * objfiles.c (objfile_relocate1): Remove declaration.
10738         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10739         declaration.
10740         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10741         * coffread.c (coff_symtab_read): Remove declaration.
10742         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10743         compunit_filetabs.
10744
10745 2019-01-09  Tom Tromey  <tom@tromey.com>
10746
10747         * symtab.c (lookup_objfile_from_block)
10748         (find_pc_sect_compunit_symtab, search_symbols)
10749         (default_collect_symbol_completion_matches_break_on): Use
10750         objfile_compunits.
10751         * objfiles.h (ALL_COMPUNITS): Remove.
10752         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10753         * cp-support.c (add_symbol_overload_list_qualified): Use
10754         objfile_compunits.
10755         * ada-lang.c (ada_collect_symbol_completion_matches)
10756         (ada_add_global_exceptions): Use objfile_compunits.
10757
10758 2019-01-09  Tom Tromey  <tom@tromey.com>
10759
10760         * source.c (select_source_symtab)
10761         (forget_cached_source_info_for_objfile): Remove declaration.
10762         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10763         declaration.
10764         * maint.c (count_symtabs_and_blocks): Remove declaration.
10765         * cp-support.c (add_symbol_overload_list_qualified): Remove
10766         declaration.
10767         * coffread.c (coff_symtab_read): Remove declaration.
10768         * symtab.c (lookup_symbol_in_objfile_symtabs)
10769         (basic_lookup_transparent_type_1): Use objfile_compunits.
10770         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10771         (info_sources_command, search_symbols)
10772         (default_collect_symbol_completion_matches_break_on)
10773         (make_source_files_completion_list): Remove declaration.
10774         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10775         (ada_collect_symbol_completion_matches)
10776         (ada_add_global_exceptions): Remove declaration.
10777         * linespec.c (iterate_over_all_matching_symtabs): Use
10778         objfile_compunits.
10779         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10780         (class objfile_compunits): New.
10781         (ALL_COMPUNITS): Use objfile_compunits.
10782         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10783         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10784         objfile_compunits.
10785         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10786
10787 2019-01-09  Tom Tromey  <tom@tromey.com>
10788
10789         * symtab.c (search_symbols)
10790         (default_collect_symbol_completion_matches_break_on): Use
10791         objfile_msymbols.
10792         * ada-lang.c (ada_lookup_simple_minsym)
10793         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10794         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10795         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10796         objfile_msymbols.
10797         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10798         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10799         * objc-lang.c (find_methods): Use objfile_msymbols.
10800         (info_selectors_command, info_classes_command): Likewise.
10801         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10802         * objfiles.h (class objfile_msymbols): New.
10803         (ALL_OBJFILE_MSYMBOLS): Remove.
10804         (ALL_MSYMBOLS): Remove.
10805
10806 2019-01-09  Tom Tromey  <tom@tromey.com>
10807
10808         * common/next-iterator.h (next_adapter): Add Iterator template
10809         parameter.
10810         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10811         (class all_objfiles_safe): New.
10812         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10813         * objfiles.c (put_objfile_before): Update comment.
10814         (add_separate_debug_objfile): Likewise.
10815         (free_all_objfiles): Use all_objfiles_safe.
10816         (objfile_purge_solibs): Likewise.
10817
10818 2019-01-09  Tom Tromey  <tom@tromey.com>
10819
10820         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10821         (expand_symtab_containing_pc, lookup_static_symbol)
10822         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10823         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10824         all_objfiles.
10825         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10826         * breakpoint.c (create_overlay_event_breakpoint)
10827         (create_longjmp_master_breakpoint)
10828         (create_std_terminate_master_breakpoint)
10829         (create_exception_master_breakpoint): Use all_objfiles.
10830         * linux-thread-db.c (try_thread_db_load_from_pdir)
10831         (has_libpthread): Use all_objfiles.
10832         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10833         * linespec.c (iterate_over_all_matching_symtabs)
10834         (search_minsyms_for_name): Use all_objfiles.
10835         * maint.c (maintenance_info_sections): Use all_objfiles.
10836         * main.c (captured_main_1): Use all_objfiles.
10837         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10838         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10839         * guile/scm-pretty-print.c
10840         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10841         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10842         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10843         (maintenance_print_msymbols): Use all_objfiles.
10844         * source.c (select_source_symtab): Use all_objfiles.
10845         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10846         * symfile.c (remove_symbol_file_command)
10847         (expand_symtabs_matching, map_symbol_filenames): Use
10848         all_objfiles.
10849         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10850         all_objfiles.
10851         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10852         * objc-lang.c (find_methods): Use all_objfiles.
10853         * objfiles.c (have_partial_symbols, have_full_symbols)
10854         (have_minimal_symbols, qsort_cmp)
10855         (default_iterate_over_objfiles_in_search_order): Use
10856         all_objfiles.
10857         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10858         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10859         (maintenance_check_psymtabs): Use all_objfiles.
10860         (ALL_PSYMTABS): Remove.
10861         * compile/compile-object-run.c (do_module_cleanup): Use
10862         all_objfiles.
10863         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10864         * cp-support.c (add_symbol_overload_list_qualified): Use
10865         all_objfiles.
10866         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10867         Use all_objfiles.
10868         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10869         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10870         all_objfiles.
10871         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10872         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10873         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10874         Uses all_objfiles.
10875         * solib.c (solib_read_symbols): Use all_objfiles
10876
10877 2019-01-09  Tom Tromey  <tom@tromey.com>
10878
10879         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10880         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10881         all_objfiles.
10882         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10883         * symmisc.c (print_symbol_bcache_statistics)
10884         (print_objfile_statistics, maintenance_print_objfiles)
10885         (maintenance_info_symtabs, maintenance_check_symtabs)
10886         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10887         all_objfiles.
10888         * source.c (forget_cached_source_info): Use all_objfiles.
10889         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10890         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10891         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10892         * objfiles.c (update_section_map): Use all_objfiles.
10893         (shared_objfile_contains_address_p): Likewise.
10894         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10895         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10896
10897 2019-01-09  Tom Tromey  <tom@tromey.com>
10898
10899         * common/next-iterator.h: New file.
10900         * objfiles.h (class all_objfiles): New.
10901         (struct objfile_iterator): New.
10902
10903 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10904
10905         * NEWS: Move the description of the changed "frame", "select-frame",
10906          and "info frame" commands to the Changed commands section.
10907
10908 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10909
10910         * gdbtypes.c (check_stub_method_group): Remove handling of old
10911         mangling schemes.
10912         * linespec.c (find_methods): Likewise.
10913         * stabsread.c (read_member_functions): Likewise.
10914         * valops.c (search_struct_method): Likewise.
10915         (value_struct_elt_for_reference): Likewise.
10916         * NEWS: Mention this change.
10917
10918 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10919
10920         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10921         print_source_lines.
10922         * source.c (print_source_lines_base): Update line number check.
10923         (print_source_lines): New function.
10924         (source_lines_range::source_lines_range): New function.
10925         * source.h (class source_lines_range): New class.
10926         (print_source_lines): New declaration.
10927
10928 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10929
10930         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10931
10932 2019-01-08  Tom Tromey  <tom@tromey.com>
10933             Simon Marchi  <simon.marchi@ericsson.com>
10934
10935         PR gdb/24060
10936         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10937         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10938         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10939         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10940         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10941         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10942
10943 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10944
10945         * source.c (select_source_symtab): Move header comment to
10946         declaration in source.h.
10947         (forget_cached_source_info_for_objfile): Likewise.
10948         (forget_cached_source_info): Likewise.
10949         (identify_source_line): Likewise.
10950         * source.h (identify_source_line): Move declaration from symtab.h
10951         and add comment from source.c
10952         (print_source_lines): Likewise.
10953         (forget_cached_source_info_for_objfile): Likewise.
10954         (forget_cached_source_info): Likewise.
10955         (select_source_symtab): Likewise.
10956         (enum print_source_lines_flag): Move definition from symtab.h.
10957         * symtab.h (identify_source_line): Move declaration to source.h.
10958         (print_source_lines): Likewise.
10959         (forget_cached_source_info_for_objfile): Likewise.
10960         (forget_cached_source_info): Likewise.
10961         (select_source_symtab): Likewise.
10962         (enum print_source_lines_flag): Move definition to source.h.
10963         * tui/tui-hooks.c: Add 'source.h' include.
10964
10965 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10966
10967         * source.c (print_source_lines_base): Handle requests to print
10968         reverse line number sequences, and guard against empty lines
10969         string.
10970
10971 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10972
10973         * source.c (print_source_lines_base): Fix skip of '\r' if next
10974         character is '\n'.
10975
10976 2019-01-06  Tom Tromey  <tom@tromey.com>
10977
10978         * c-exp.y (struct c_parse_state) <macro_original_text,
10979         expansion_obstack>: New member.
10980         (macro_original_text, expansion_obstack): Remove globals.
10981         (scan_macro_expansion, scanning_macro_expansion)
10982         (finished_macro_expansion): Update.
10983         (scan_macro_cleanup): Remove.
10984         (yylex, c_parse): Update.
10985
10986 2019-01-06  Tom Tromey  <tom@tromey.com>
10987
10988         * c-exp.y (struct c_parse_state) <strings>: New member.
10989         (operator_stoken): Update.
10990
10991 2019-01-06  Tom Tromey  <tom@tromey.com>
10992
10993         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10994         (union type_stack_elt) <typelist_val>: Now a pointer to
10995         std::vector.
10996         (type_stack_cleanup): Don't declare.
10997         (push_typelist): Update.
10998         * parse.c (pop_typelist): Return a std::vector.
10999         (push_typelist): Take a std::vector.
11000         (follow_types): Update.  Do not free args.
11001         (type_stack_cleanup): Remove.
11002         * c-exp.y (struct c_parse_state): New.
11003         (cpstate): New global.
11004         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11005         (nonempty_typelist): Update.
11006         (func_mod): Create a new vector.
11007         (c_parse): Create a c_parse_state.
11008         (check_parameter_typelist): Do not delete params.
11009         (function_method): Update.  Do not delete type_list.
11010
11011 2019-01-06  Tom Tromey  <tom@tromey.com>
11012
11013         PR gdb/28155:
11014         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11015         check_typedef.
11016         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11017         (print_return_value): Likewise.
11018
11019 2019-01-05  Tom Tromey  <tom@tromey.com>
11020
11021         * contrib/cleanup_check.py: Remove.
11022         * contrib/gcc-with-excheck: Remove.
11023         * contrib/exsummary.py: Remove.
11024         * contrib/excheck.py: Remove.
11025
11026 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11027
11028         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11029         NULL. Initialize tpprev to NULL instead of assigning it
11030         to NULL on the next statement.
11031         * windows-nat.c (windows_delete_thread): Remove check for
11032         main_thread_id before printing thread exit notifications.
11033         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11034         Remove thread ID check against main_thread_id.
11035         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11036         windows_delete_thread.
11037         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11038
11039 2019-01-04  Tom Tromey  <tom@tromey.com>
11040
11041         * compile/compile.c (_initialize_compile): Use upper case for
11042         metasyntactic variables.
11043         * symmisc.c (_initialize_symmisc): Use upper case for
11044         metasyntactic variables.
11045         * psymtab.c (_initialize_psymtab): Use upper case for
11046         metasyntactic variables.
11047         * demangle.c (demangle_command): Use upper case for metasyntactic
11048         variables.
11049         (_initialize_demangler): Likewise.
11050         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11051         variables.
11052
11053 2019-01-03  Tom Tromey  <tom@tromey.com>
11054
11055         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11056
11057 2019-01-03  Tom Tromey  <tom@tromey.com>
11058
11059         * python/py-symtab.c (salpy_str): Update.
11060         (struct salpy_sal_object) <symtab>: Now a PyObject.
11061         (salpy_dealloc): Update.
11062         (del_objfile_sal): Use gdbpy_ref.
11063
11064 2019-01-03  Tom Tromey  <tom@tromey.com>
11065
11066         * python/py-type.c (convert_field): Use new_reference.  Return
11067         gdbpy_ref.
11068         (make_fielditem): Return gdbpy_ref.
11069         (typy_fields): Update.
11070         (typy_getitem): Update.
11071         (field_name): Return gdbpy_ref.  Use new_reference.
11072         (typy_iterator_iternext): Update.
11073
11074 2019-01-03  Tom Tromey  <tom@tromey.com>
11075
11076         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11077
11078 2019-01-03  Tom Tromey  <tom@tromey.com>
11079
11080         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11081         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11082         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11083         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11084         (pspy_set_type_printers): Likewise.
11085         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11086         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11087         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11088         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11089         (objfpy_set_type_printers): Likewise.
11090
11091 2019-01-03  Tom Tromey  <tom@tromey.com>
11092
11093         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11094         (gdbpy_print_stack): Use gdbpy_err_fetch.
11095         * python/python-internal.h (class gdbpy_err_fetch): New class.
11096         (class gdbpy_enter) <m_error_type, m_error_value,
11097         m_error_traceback>: Remove.
11098         <m_error>: New member.
11099         (gdbpy_exception_to_string): Don't declare.
11100         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11101         * python/py-value.c (convert_value_from_python): Use
11102         gdbpy_err_fetch.
11103         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11104         gdbpy_exception_to_string.
11105         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11106         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11107         gdbpy_err_fetch.
11108
11109 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11110
11111         * linux-nat.c (delete_lwp_cleanup): Delete.
11112         (struct lwp_deleter): New struct.
11113         (lwp_info_up): New typedef.
11114         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11115         lwp_info_up.
11116
11117 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11118
11119         * linux-fork.c (class scoped_switch_fork_info): New class.
11120         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11121
11122 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11123
11124         * valops.c (find_overload_match): Remove use of null_cleanup, and
11125         calls to do_cleanups.
11126
11127 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11128
11129         * compile/compile-cplus-types.c
11130         (compile_cplus_instance::decl_name): Handle changes to
11131         cp_func_name.
11132         * cp-support.c (cp_func_name): Update header comment, update
11133         return type.
11134         * cp-support.h (cp_func_name): Update return type in declaration.
11135         * valops.c (find_overload_match): Move temp_func local to top
11136         level of function and change its type.  Use temp_func to hold and
11137         delete temporary string obtained from cp_func_name.
11138
11139 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11140
11141         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11142         gdb::char_vector, remove cleanup, and update uses of `msg`.
11143
11144 2019-01-03  Jim Wilson  <jimw@sifive.com>
11145
11146         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11147
11148 2019-01-02  Tom Tromey  <tom@tromey.com>
11149
11150         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11151         (tdesc_parse_xml): Remove cleanups.
11152         * target-descriptions.h (make_cleanup_free_target_description):
11153         Don't declare.
11154         (target_desc_deleter): New struct.
11155         (target_desc_up): New typedef.
11156         * target-descriptions.c (target_desc_deleter::operator()): Rename
11157         from free_target_description.
11158         (make_cleanup_free_target_description): Remove.
11159
11160 2019-01-02  Tom Tromey  <tom@tromey.com>
11161
11162         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11163         constructor, destructor.
11164         (linespec_parser): Remove typedef.
11165         (~linespec_parser): Rename from linespec_parser_delete.
11166         (linespec_lex_to_end, linespec_complete_label)
11167         (linespec_complete): Update.
11168         (decode_line_full): Remove cleanups.
11169         (decode_line_1): Update.
11170
11171 2019-01-02  Tom Tromey  <tom@tromey.com>
11172
11173         * python/python-internal.h (inferior_to_inferior_object): Change
11174         return type.
11175         * python/py-exitedevent.c (create_exited_event_object): Update.
11176         * python/py-inferior.c (inferior_to_inferior_object): Return
11177         gdbpy_ref.
11178         (python_new_inferior, python_inferior_deleted)
11179         (thread_to_thread_object, delete_thread_object)
11180         (build_inferior_list, gdbpy_selected_inferior): Update.
11181         * python/py-infthread.c (create_thread_object): Update.  Also fail
11182         if inferior_to_inferior_object fails.
11183
11184 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11185
11186         * inferior.h (class inferior) <displaced_step_state>: New field.
11187         * infrun.h (struct displaced_step_state): Move here from
11188         infrun.c.  Initialize fields, add constructor.
11189         <inf>: Remove field.
11190         <reset>: New method.
11191         * infrun.c (struct displaced_step_inferior_state): Move to
11192         infrun.h.
11193         (displaced_step_inferior_states): Remove.
11194         (get_displaced_stepping_state): Adust.
11195         (displaced_step_in_progress_any_inferior): Adjust.
11196         (displaced_step_in_progress_thread): Adjust.
11197         (displaced_step_in_progress): Adjust.
11198         (add_displaced_stepping_state): Remove.
11199         (get_displaced_step_closure_by_addr): Adjust.
11200         (remove_displaced_stepping_state): Remove.
11201         (infrun_inferior_exit): Call displaced_step_state.reset.
11202         (use_displaced_stepping): Don't check for NULL.
11203         (displaced_step_prepare_throw): Call
11204         get_displaced_stepping_state.
11205         (displaced_step_fixup): Don't check for NULL.
11206         (prepare_for_detach): Don't check for NULL.
11207
11208 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11209
11210         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11211          in case of call that did not complete.
11212
11213 2019-01-02  Andrey Utkin  <autkin@undo.io>
11214
11215         * symfile.c (find_separate_debug_file): Fix search of debug files for
11216         remote debuggee.
11217
11218 2019-01-02  Tom Tromey  <tom@tromey.com>
11219
11220         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11221         indentation.
11222         * python/py-frame.c (frapy_older): Remove cast.
11223         (frapy_newer): Likewise.
11224         * python/py-breakpoint.c (local_setattro): Remove cast.
11225         * python/py-arch.c (archpy_name): Remove local variable.
11226         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11227
11228 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11229
11230         * unittests/basic_string_view/element_access/char/empty.cc:
11231         Fix year range in copyright header.
11232
11233 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11234
11235         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11236         Delete.
11237         <operator==>: Update with for removed field.
11238         <hash>: Likewise.
11239         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11240         <isa_features>: ...this.
11241         <abi_features>: New field.
11242         (riscv_isa_flen): Update comment.
11243         (riscv_abi_xlen): New declaration.
11244         (riscv_abi_flen): New declaration.
11245         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11246         isa_features.
11247         (riscv_abi_xlen): New function.
11248         (riscv_isa_flen): Update to get answer from isa_features.
11249         (riscv_abi_flen): New function.
11250         (riscv_has_fp_abi): Update to get answer from abi_features.
11251         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11252         xlen and flen.
11253         (riscv_call_info) <xlen, flen>: Update comment.
11254         (riscv_call_arg_struct): Remove invalid assertions
11255         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11256         is removed.
11257         (riscv_gdbarch_init): Gather isa features and abi features
11258         separately, ensure both match on the gdbarch when reusing an old
11259         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11260         a target with 64-bit float hardware.
11261
11262 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11263
11264         * source.c (search_command_helper): Stop reverse search
11265         when line 1 has been searched.
11266
11267 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11268
11269         * record-full.c (record_full_base_target::close): Rewrite
11270         record_full_core_buf_list free logic.
11271
11272 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11273
11274         * break-catch-syscall.c (print_one_catch_syscall): xfree
11275         the last text.
11276
11277 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11278
11279         * top.c (print_gdb_version): Update Copyright year in version
11280         message.
11281
11282 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11283
11284         Update copyright year range in all GDB files.
11285
11286 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11287
11288         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11289
11290 For older changes see ChangeLog-2018.
11291 \f
11292 Local Variables:
11293 mode: change-log
11294 left-margin: 8
11295 fill-column: 74
11296 version-control: never
11297 coding: utf-8
11298 End:
11299