gdb/ChangeLog

   1 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
   2             Chris January  <chris.january@arm.com>
   3             Daniel Everett  <daniel.everett@arm.com>
   4             Nick Forrington  <nick.forrington@arm.com>
   5             Richard Bunt  <richard.bunt@arm.com>
   6
   7         * cp-valprint.c (cp_print_value_fields): Allow an additional level
   8         of depth when printing anonymous structs or unions.
   9         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
  10         Don't print either the top-level value, or the children if the
  11         max-depth is exceeded.
  12         (ppscm_print_children): When printing the key of a map, allow one
  13         extra level of depth.
  14         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
  15         print either the top-level value, or the children if the max-depth
  16         is exceeded.
  17         (print_children): When printing the key of a map, allow one extra
  18         level of depth.
  19         * python/py-value.c (valpy_format_string): Add max_depth keyword.
  20         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
  21         (user_print_options): Initialise max_depth field.
  22         (val_print_scalar_or_string_type_p): New function.
  23         (val_print): Check to see if the max depth has been reached.
  24         (val_print_check_max_depth): Define new function.
  25         (show_print_max_depth): New function.
  26         (_initialize_valprint): Add 'print max-depth' option.
  27         * valprint.h (struct value_print_options) <max_depth>: New field.
  28         (val_print_check_max_depth): Declare new function.
  29         * NEWS: Document new feature.
  30
  31 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  32
  33         * ada-lang.c (ada_language_defn): Initialise new field.
  34         * c-lang.c (c_is_string_type_p): New function.
  35         (c_language_defn): Initialise new field.
  36         (cplus_language_defn): Initialise new field.
  37         (asm_language_defn): Initialise new field.
  38         (minimal_language_defn): Initialise new field.
  39         * c-lang.h (c_is_string_type_p): Declare new function.
  40         * d-lang.c (d_language_defn): Initialise new field.
  41         * f-lang.c (f_is_string_type_p): New function.
  42         (f_language_defn): Initialise new field.
  43         * go-lang.c (go_is_string_type_p): New function.
  44         (go_language_defn): Initialise new field.
  45         * language.c (default_is_string_type_p): New function.
  46         (unknown_language_defn): Initialise new field.
  47         (auto_language_defn): Initialise new field.
  48         * language.h (struct language_defn) <la_is_string_type_p>: New
  49         member variable.
  50         (default_is_string_type_p): Declare new function.
  51         * m2-lang.c (m2_language_defn): Initialise new field.
  52         * objc-lang.c (objc_language_defn): Initialise new field.
  53         * opencl-lang.c (opencl_language_defn): Initialise new field.
  54         * p-lang.c (pascal_is_string_type_p): New function.
  55         (pascal_language_defn): Initialise new field.
  56         * rust-lang.c (rust_is_string_type_p): New function.
  57         (rust_language_defn): Initialise new field.
  58
  59 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  60
  61         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
  62         New field.
  63         * ada-lang.c (ada_language_defn): Initialise new field.
  64         * c-lang.c (c_language_defn): Likewise.
  65         (cplus_language_defn): Likewise.
  66         (asm_language_defn): Likewise.
  67         (minimal_language_defn): Likewise.
  68         * d-lang.c (d_language_defn): Likewise.
  69         * f-lang.c (f_language_defn): Likewise.
  70         * go-lang.c (go_language_defn): Likewise.
  71         * language.c (unknown_language_defn): Likewise.
  72         (auto_language_defn): Likewise.
  73         * m2-lang.c (m2_language_defn): Likewise.
  74         * objc-lang.c (objc_language_defn): Likewise.
  75         * opencl-lang.c (opencl_language_defn): Likewise.
  76         * p-lang.c (pascal_language_defn): Likewise.
  77         * rust-lang.c (rust_language_defn): Likewise.
  78
  79 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  80
  81         * ada-lang.c (ada_is_character_type): Change return type to bool.
  82         (ada_is_string_type): Likewise.
  83         * ada-lang.h (ada_is_character_type): Update declaration
  84         (ada_is_string_type): Likewise.
  85
  86 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  87
  88         Support style in 'frame|thread apply'
  89
  90         * gdbcmd.h (execute_command_to_string): New term_out parameter.
  91         * record.c (record_start, record_stop): Update callers of
  92         execute_command_to_string with false.
  93         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
  94         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
  95         methods.
  96         (class string_file): New constructor with term_out parameter.
  97         Override methods term_out and can_emit_style_escape.  New member
  98         term_out.
  99         (class stdio_file): Override can_emit_style_escape.
 100         (class tee_file): Override term_out and can_emit_style_escape.
 101         * utils.h (can_emit_style_escape): Remove.
 102         * utils.c (can_emit_style_escape): Likewise.
 103         Update all callers of can_emit_style_escape (SOMESTREAM) to
 104         SOMESTREAM->can_emit_style_escape.
 105         * source-cache.c (source_cache::get_source_lines): Likewise.
 106         * stack.c (frame_apply_command_count): Call execute_command_to_string
 107         passing the term_out characteristic of the current gdb_stdout.
 108         * thread.c (thr_try_catch_cmd): Likewise.
 109         * top.c (execute_command_to_string): pass term_out parameter
 110         to construct the string_file for the command output.
 111         * ui-file.c (term_cli_styling): New function (most code moved
 112         from utils.c can_emit_style_escape).
 113         (string_file::string_file, string_file::can_emit_style_escape,
 114         stdio_file::can_emit_style_escape, tee_file::term_out,
 115         tee_file::can_emit_style_escape): New functions.
 116
 117 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 118
 119         * NEWS: Mention the new set|show may-call-functions.
 120         * infcall.c (may_call_functions_p): New variable.
 121         (show_may_call_functions_p): New function.
 122         (call_function_by_hand_dummy): Throws an error if not
 123         may-call-functions.
 124         (_initialize_infcall): Call add_setshow_boolean_cmd for
 125         may-call-functions.
 126
 127 2019-04-25  Keith Seitz  <keiths@redhat.com>
 128
 129         PR c++/24367
 130         * cp-support.c (inspect_type): Don't attempt substitutions
 131         of symbol with the same name.
 132
 133 2019-04-25  Tom Tromey  <tromey@adacore.com>
 134
 135         PR gdb/24475:
 136         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 137         static.
 138
 139 2019-04-25  Tom Tromey  <tromey@adacore.com>
 140
 141         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 142         rvalue reference.
 143         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 144         (gdb_xml_parser::parse): Use std::move.
 145         * python/python-internal.h (gdbpy_convert_exception): Take a const
 146         reference.
 147         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 148         std::move.
 149         * python/py-utils.c (gdbpy_convert_exception): Take a const
 150         reference.
 151         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 152         Use std::move.
 153         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 154         Use std::move.
 155         * mi/mi-main.c (mi_print_exception): Take a const reference.
 156         * main.c (handle_command_errors): Take a const reference.
 157         * linespec.c (parse_linespec): Use std::move.
 158         * infcall.c (run_inferior_call): Use std::move.
 159         (call_function_by_hand_dummy): Use std::move.
 160         * exec.c (try_open_exec_file): Use std::move.
 161         * exceptions.h (exception_print, exception_fprintf)
 162         (exception_print_same): Update.
 163         * exceptions.c (print_exception, exception_print)
 164         (exception_fprintf, exception_print_same): Change parameters to
 165         const reference.
 166         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 167         * common/new-op.c: Use std::move.
 168         * common/common-exceptions.h (struct gdb_exception): Add move
 169         constructor.
 170         (struct gdb_exception_error, struct gdb_exception_quit, struct
 171         gdb_quit_bad_alloc): Change constructor to move constructor.
 172         (throw_exception): Change parameter to rvalue reference.
 173         * common/common-exceptions.c (throw_exception): Take rvalue
 174         reference.
 175         * cli/cli-interp.c (safe_execute_command): Use std::move.
 176         * breakpoint.c (insert_bp_location, location_to_sals): Use
 177         std::move.
 178
 179 2019-04-25  Tom Tromey  <tromey@adacore.com>
 180
 181         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 182         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 183         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 184         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 185         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 186         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 187         guile/scm-value.c: Use unpack.
 188         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 189         gdbscm_gdb_exception.
 190         (gdbscm_throw_gdb_exception): Likewise.
 191         (struct gdbscm_gdb_exception): New.
 192         (unpack): New function.
 193         (gdbscm_wrap): Use unpack.
 194
 195 2019-04-25  Tom Tromey  <tromey@adacore.com>
 196
 197         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 198         (gdb_rl_callback_handler): Use std::move.
 199         * common/common-exceptions.h (struct gdb_exception): Add move
 200         assignment operator.
 201         (throw_exception_sjlj): Change "exception" to const reference.
 202         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 203         (throw_exception_sjlj): Change "exception" to const reference.
 204
 205 2019-04-25  Tom Tromey  <tromey@adacore.com>
 206
 207         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 208         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 209         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 210         Update.
 211         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 212         Update.
 213         * mi/mi-interp.c (mi_interp::exec): Update.
 214         * linespec.c (parse_linespec): Update.
 215         * infcall.c (run_inferior_call): Update.
 216         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 217         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 218         (gdbscm_lookup_global_symbol): Update.
 219         * guile/scm-param.c (gdbscm_parameter_value): Update.
 220         * guile/scm-frame.c (gdbscm_frame_read_register)
 221         (gdbscm_frame_read_var): Update.
 222         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 223         * exec.c (try_open_exec_file): Update.
 224         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 225         (gdb_rl_callback_handler): Update.
 226         * common/common-exceptions.h (exception_none): Don't declare.
 227         * common/common-exceptions.c (exception_none): Don't define.
 228         (struct catcher) <exception>: Update.
 229         * cli/cli-interp.c (safe_execute_command): Update.
 230         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 231
 232 2019-04-25  Ali Tamur  <tamur@google.com>
 233
 234         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 235         (read_attribute_value): Likewise.
 236         (dwarf2_read_addr_index): Update comment.
 237         (read_str_index): Add DW_FORM_strx.
 238         (dwarf2_string_attr): Likewise.
 239         (dwarf2_const_value_attr): Likewise.
 240         (dump_die_shallow): Likewise.
 241         (dwarf2_fetch_constant_bytes): Likewise.
 242         (skip_form_bytes): Likewise.
 243         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 244
 245 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 246
 247         PR corefiles/11608
 248         PR corefiles/18187
 249         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 250         OFFSET.  Verify if current mapping contains an ELF header.
 251         (linux_find_memory_regions_full): Adjust call to
 252         dump_mapping_p.
 253
 254 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 255             Kang Li <kanglictf@gmail.com>
 256
 257         PR gdb/21600
 258
 259         * dwarf2-frame.c (read_initial_length): Be consistent about using
 260         unsigned representation of length.
 261         (decode_frame_entry_1): Likewise.  Check for wraparound of
 262         end pointer as well as buffer overflow.
 263
 264 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 265
 266         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 267         "vq".
 268
 269 2019-04-24  Tom Tromey  <tromey@adacore.com>
 270
 271         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 272
 273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 274
 275         * s12z-tdep.c (s12z_unwind_pc): Delete.
 276         (s12z_unwind_sp): Delete.
 277         (s12z_gdbarch_init): Don't register deleted functions with
 278         gdbarch.
 279
 280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 281
 282         * rl78-tdep.c (rl78_unwind_sp): Delete.
 283         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 284
 285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 286
 287         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 288         (xstormy16_unwind_pc): Delete.
 289         (xstormy16_dummy_id): Delete.
 290         (xstormy16_gdbarch_init): Don't register deleted functions with
 291         gdbarch.
 292
 293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 294
 295         * vax-tdep.c (vax_unwind_pc): Delete.
 296         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 297
 298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 299
 300         * v850-tdep.c (v850_unwind_sp): Delete.
 301         (v850_unwind_pc): Delete.
 302         (v850_dummy_id): Delete.
 303         (v850_gdbarch_init): Don't register deleted functions with
 304         gdbarch.
 305
 306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 307
 308         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 309         (tilegx_unwind_pc): Delete.
 310         (tilegx_unwind_dummy_id): Delete.
 311         (tilegx_gdbarch_init): Don't register deleted functions with
 312         gdbarch.
 313
 314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 315
 316         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 317         (tic6x_dummy_id): Delete.
 318         (tic6x_gdbarch_init): Don't register deleted functions with
 319         gdbarch.
 320
 321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 322
 323         * sparc-tdep.c (sparc_unwind_pc): Delete.
 324         (sparc32_gdbarch_init): Don't register deleted function with
 325         gdbarch.
 326
 327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 328
 329         * sh-tdep.c (sh_unwind_sp): Delete.
 330         (sh_unwind_pc): Delete.
 331         (sh_dummy_id): Delete.
 332         (sh_gdbarch_init): Don't register deleted functions with
 333         gdbarch.
 334
 335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 336
 337         * score-tdep.c (score_unwind_sp): Delete.
 338         (score_unwind_pc): Delete.
 339         (score_dummy_id): Delete.
 340         (score_gdbarch_init): Don't register deleted functions with
 341         gdbarch.
 342
 343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 344
 345         * rx-tdep.c (rx_unwind_pc): Delete.
 346         (rx_unwind_sp): Delete.
 347         (rx_dummy_id): Delete.
 348         (rx_gdbarch_init): Don't register deleted functions with
 349         gdbarch.  Update comment.
 350
 351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 352
 353         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 354         (rs6000_dummy_id): Delete.
 355         (rs6000_gdbarch_init): Don't register deleted functions with
 356         gdbarch.
 357
 358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 359
 360         * or1k-tdep.c (or1k_dummy_id): Delete.
 361         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 362
 363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 364
 365         * nios2-tdep.c (nios2_dummy_id): Delete.
 366         (nios2_unwind_sp): Delete.
 367         (nios2_gdbarch_init): Don't register deleted functions with
 368         gdbarch.
 369
 370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 371
 372         * nds32-tdep.c (nds32_dummy_id): Delete.
 373         (nds32_unwind_pc): Delete.
 374         (nds32_unwind_sp): Delete.
 375         (nds32_gdbarch_init): Don't register deleted functions with
 376         gdbarch.
 377
 378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 379
 380         * msp430-tdep.c (msp430_unwind_pc): Delete.
 381         (msp430_unwind_sp): Delete.
 382         (msp430_dummy_id): Delete.
 383         (msp430_gdbarch_init): Don't register deleted functions with
 384         gdbarch.
 385
 386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 387
 388         * moxie-tdep.c (moxie_unwind_sp): Delete.
 389         (moxie_unwind_pc): Delete.
 390         (moxie_dummy_id): Delete.
 391         (moxie_gdbarch_init): Don't register deleted functions with
 392         gdbarch.
 393
 394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 395
 396         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 397         (mn10300_unwind_pc): Delete.
 398         (mn10300_unwind_sp): Delete.
 399         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 400         mn10300_unwind_sp.
 401         (mn10300_frame_unwind_init): Don't register deleted functions with
 402         gdbarch.
 403
 404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 405
 406         * mep-tdep.c (mep_unwind_pc): Delete.
 407         (mep_unwind_sp): Delete.
 408         (mep_dummy_id): Delete.
 409         (mep_gdbarch_init): Don't register deleted functions with
 410         gdbarch.
 411
 412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 413
 414         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 415         (m68hc11_unwind_sp): Delete.
 416         (m68hc11_gdbarch_init): Don't register deleted functions with
 417         gdbarch.
 418
 419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 420
 421         * m32r-tdep.c (m32r_unwind_sp): Delete.
 422         (m32r_unwind_pc): Delete.
 423         (m32r_dummy_id): Delete.
 424         (m32r_gdbarch_init): Don't register deleted functions with
 425         gdbarch.
 426
 427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 428
 429         * m32c-tdep.c (m32c_unwind_pc): Delete.
 430         (m32c_unwind_sp): Delete.
 431         (m32c_dummy_id): Delete.
 432         (m32c_gdbarch_init): Don't register deleted functions with
 433         gdbarch.
 434
 435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 436
 437         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 438         (lm32_unwind_pc): Delete.
 439         (lm32_dummy_id): Delete.
 440         (lm32_gdbarch_init): Don't register deleted functions with
 441         gdbarch.
 442
 443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 444
 445         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 446         (iq2000_unwind_pc): Delete.
 447         (iq2000_dummy_id): Delete.
 448         (iq2000_gdbarch_init): Don't register deleted functions with
 449         gdbarch.
 450
 451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         * nds32-tdep.c (nds32_type_align): Delete.
 454         (nds32_push_dummy_call): Use type_align instead.
 455
 456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 457
 458         * arm-tdep.c (arm_type_align): Only handle vector override case.
 459         (arm_push_dummy_call): Use type_align.
 460         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 461
 462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 463
 464         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 465         case.
 466         (pass_on_stack): Use type_align.
 467         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 468         function.
 469
 470 2019-04-23  Tom Tromey  <tromey@adacore.com>
 471
 472         * dwarf2read.c (line_header::file_name_at): Remove unused
 473         overload.
 474
 475 2019-04-23  Tom de Vries  <tdevries@suse.de>
 476
 477         PR gdb/24438
 478         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 479         invocation.
 480
 481
 482 2019-03-27  Ali Tamur  <tamur@google.com>
 483
 484         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 485         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 486         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 487         (dwarf_expr_context::get_addr_index): Likewise
 488         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 489         (symbol_needs_eval_context::get_addr_index): Likewise
 490         (disassemble_dwarf_expression): Add DW_OP_addrx
 491         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 492         (read_cutu_die_from_dwo): Update comment
 493         (skip_one_die): Add DW_FORM_addrx
 494         (read_attribute_value): Likewise
 495         (var_decode_location): Add DW_OP_addrx
 496         (dwarf2_const_value_attr): Add DW_FORM_addrx
 497         (dump_die_shallow): Likewise
 498         (dwarf2_fetch_constant_bytes): Likewise
 499         (decode_locdesc): Add DW_OP_addrx
 500         (skip_form_bytes): Add DW_FORM_addrx
 501
 502 2019-04-22  Ali Tamur  <tamur@google.com>
 503
 504         * MAINTAINERS (Write After Approval): Add self.
 505
 506 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 507
 508         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 509         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 510         (open_symbol_file_object): Likewise.
 511         (svr4_default_sos): Add info parameter.
 512         (svr4_read_so_list): Likewise.
 513         (svr4_current_sos_direct): Adjust functions calls to pass down
 514         info.
 515         (svr4_current_sos_1): Add info parameter.
 516         (svr4_current_sos): Call get_svr4_info, pass info down to
 517         svr4_current_sos_1.
 518         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 519         get_svr4_info.
 520         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 521         get_svr4_info.
 522         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 523         to get_svr4_info.
 524         (probes_table_remove_objfile_probes): Likewise.
 525         (register_solib_event_probe): Add info parameter.
 526         (solist_update_incremental): Pass info parameter down to
 527         svr4_read_so_list.
 528         (disable_probes_interface): Add info parameter.
 529         (svr4_handle_solib_event): Pass current_program_space to
 530         get_svr4_info.  Adjust disable_probes_interface cleanup.
 531         (svr4_create_probe_breakpoints): Add info parameter, pass it
 532         down to register_solib_event_probe.
 533         (svr4_create_solib_event_breakpoints): Add info parameter,
 534         pass it down to svr4_create_probe_breakpoints.
 535         (enable_break): Pass info down to
 536         svr4_create_solib_event_breakpoints.
 537         (svr4_solib_create_inferior_hook): Pass current_program_space to
 538         get_svr4_info.
 539         (svr4_clear_solib): Likewise.
 540
 541 2019-04-22  Pedro Alves  <palves@redhat.com>
 542
 543         * solib-svr4.c (svr4_free_objfile_observer): New.
 544         (probe_and_action::objfile): New field.
 545         (probes_table_htab_remove_objfile_probes)
 546         (probes_table_remove_objfile_probes): New functions.
 547         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 548         in the new probe_and_action.  Don't store the probe in 'lookup'.
 549         (svr4_create_probe_breakpoints): Pass objfile to
 550         register_solib_event_probe.
 551         (_initialize_svr4_solib): Register a free_objfile observer.
 552
 553 2019-04-19  Tom Tromey  <tom@tromey.com>
 554
 555         * common/queue.h: Remove.
 556
 557 2019-04-19  Tom Tromey  <tom@tromey.com>
 558
 559         * event-loop.c: Don't include "common/queue.h".
 560
 561 2019-04-19  Tom Tromey  <tom@tromey.com>
 562
 563         * remote.c (remote_target): Use delete.
 564         * remote-notif.h: Include <list>, not "common/queue.h".
 565         (notif_client_p): Remove typedef.
 566         (remote_notif_state): Add constructor, destructor, initializer.
 567         <notif_queue>: Now a std::list.
 568         (remote_notif_state_xfree): Don't declare.
 569         * remote-notif.c (remote_notif_process, handle_notification)
 570         (remote_notif_state_allocate): Update.
 571         (~remote_notif_state): Rename from remote_notif_state_xfree.
 572
 573 2019-04-19  Tom Tromey  <tom@tromey.com>
 574
 575         * symfile.c (reread_symbols): Update.
 576         * objfiles.c (objfile_register_static_link)
 577         (objfile_lookup_static_link): Update
 578         (~objfile) Don't delete static_links.
 579         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 580
 581 2019-04-19  Tom Tromey  <tom@tromey.com>
 582
 583         * type-stack.h (struct type_stack) <insert>: Constify string.
 584         * type-stack.c (type_stack::insert): Constify string.
 585         * gdbtypes.h (lookup_template_type): Update.
 586         (address_space_name_to_int): Update.
 587         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 588         const.
 589         (lookup_template_type): Make name const.
 590         * c-exp.y: Update rules.
 591         (lex_one_token, classify_name, classify_inner_name)
 592         (c_print_token): Update.
 593         * p-exp.y: Update rules.
 594         (yylex): Update.
 595         * f-exp.y: Update rules.
 596         (yylex): Update.
 597         * d-exp.y: Update rules.
 598         (lex_one_token, classify_name, classify_inner_name): Update.
 599         * parse.c (write_dollar_variable, copy_name): Return std::string.
 600         * parser-defs.h (copy_name): Change return type.
 601         * m2-exp.y: Update rules.
 602         (yylex): Update.
 603         * go-exp.y (lex_one_token): Update.
 604         Update rules.
 605         (classify_unsafe_function, classify_packaged_name)
 606         (classify_name, yylex): Update.
 607
 608 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 609
 610         * configure.ac: add --enable-source-highlight switch.
 611         * configure: Regenerate.
 612         * top.c (print_gdb_version): plumb --enable-source-highlight
 613         status to "show configuration".
 614
 615 2019-04-19  Tom Tromey  <tromey@adacore.com>
 616
 617         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 618         Check ADA_TYPE_P.
 619         (empty_record, ada_template_to_fixed_record_type_1)
 620         (template_to_static_fixed_type)
 621         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 622         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 623         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 624         macros.
 625
 626 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 627
 628         PR symtab/24423:
 629         * source.c (print_source_lines_base): Advance "iter" when a
 630         control character is seen.
 631
 632 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 633
 634         * inferior.h (struct infcall_suspend_state_deleter):
 635         Catch exception in destructor to avoid crash.
 636
 637 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 638
 639         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 640         close to the add_com "shell".
 641
 642 2019-04-18  Tom Tromey  <tromey@adacore.com>
 643
 644         * process-stratum-target.h (class process_stratum_target)
 645         <stratum>: Add "final".
 646
 647 2019-04-17  Tom Tromey  <tromey@adacore.com>
 648
 649         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 650         against nullptr before use.
 651
 652 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 653
 654         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 655
 656 2019-04-17  Jim Wilson  <jimw@sifive.com>
 657             Andrew Burgess  <andrew.burgess@embecosm.com>
 658
 659         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 660         code read might fail, assume 4-byte breakpoint in that case.
 661
 662 2019-04-15  Leszek Swirski  <leszeks@google.com>
 663
 664         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 665         rather than a hand-rolled POD check when checking for forced MEMORY
 666         classification.
 667
 668 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 669
 670         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 671         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 672         function.
 673         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 674         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 675         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 676         declaration.
 677
 678 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 679
 680         * aarch64-linux-nat.c
 681         (aarch64_linux_nat_target::thread_architecture): Add override.
 682         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 683         each VQ.
 684
 685 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 686
 687         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 688
 689 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 692         target types of size 96-bits, add some additional comments, and
 693         check that the builtin type we found was the correct size.
 694
 695 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 696
 697         * utils.c (prompt_for_continue): Don't restore the styling at the
 698         end, as applied_style has the wrong value.  This fixes styling in
 699         long lists of file names that are interrupted by the "Continue?"
 700         prompt.
 701
 702 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 703
 704         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 705         * c-lang.c (c_language_defn): Likewise.
 706         (cplus_language_defn): Likewise.
 707         (asm_language_defn): Likewise.
 708         (minimal_language_defn): Likewise.
 709         * d-lang.c (d_language_defn): Likewise.
 710         * f-lang.c (f_language_defn): Likewise.
 711         * go-lang.c (go_language_defn): Likewise.
 712         * language.c (unknown_language_defn): Likewise.
 713         (auto_language_defn): Likewise.
 714         * language.h (struct language_defn): Remove la_magic field.
 715         (LANG_MAGIC): Delete.
 716         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 717         * objc-lang.c (objc_language_defn): Likewise.
 718         * opencl-lang.c (opencl_language_defn): Likewise.
 719         * p-lang.c (pascal_language_defn): Likewise.
 720         * rust-lang.c (rust_language_defn): Likewise.
 721
 722 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 723
 724         * riscv-tdep.c (riscv_type_align): New function.
 725         (riscv_type_alignment): Delete.
 726         (riscv_arg_location): Use 'type_align'.
 727         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 728
 729 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 730
 731         * gdbtypes.c (type_align): A struct with no non-static fields also
 732         has alignment of 1.
 733
 734 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 735
 736         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 737         component to 0.
 738         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 739         member.
 740         (riscv_struct_info::analyse): New implementation using new
 741         analyse_inner member function.
 742         (riscv_struct_info::field_offset): New member function.
 743         (riscv_struct_info::m_offsets): New member variable.
 744         (riscv_struct_info::analyse_inner): New private member function,
 745         takes the old implementation of riscv_struct_info::analyse but
 746         extended to track field offsets.
 747         (riscv_call_arg_struct): Update the struct folding special cases
 748         to handle cases where empty C++ structs, which are non-zero
 749         length, are found.
 750         (riscv_arg_location): Initialise the length of each location, a
 751         non-zero length now indicates the location is in use.
 752         (riscv_push_dummy_call): Allow for the first location having a
 753         non-zero offset when setting up arguments.
 754         (riscv_return_value): Likewise, but for return values.
 755
 756 2019-04-11  Tom Tromey  <tromey@adacore.com>
 757
 758         * utils.c (internal_vproblem): Make "msg" const.
 759
 760 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 761
 762         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 763         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 764         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 765         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 766
 767 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 768
 769         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 770         function.
 771         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 772         of amd64_collect_native_gregset.
 773         (amd64_linux_nat_target::store_registers): Likewise.
 774
 775 2019-04-10  Tom Tromey  <tom@tromey.com>
 776
 777         * symtab.c (lookup_global_symbol_from_objfile)
 778         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 779         * objfiles.h (class separate_debug_iterator): New.
 780         (class separate_debug_range): New.
 781         (struct objfile) <separate_debug_objfiles>: New method.
 782         (objfile_separate_debug_iterate): Don't declare.
 783         * objfiles.c (separate_debug_iterator::operator++): Rename from
 784         objfile_separate_debug_iterate.
 785         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 786         iterator.
 787         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 788         iterator.
 789
 790 2019-04-10  Tom Tromey  <tom@tromey.com>
 791
 792         * symfile.c (reread_symbols): Remove old comment.
 793         * objfiles.c (free_all_objfiles): Fix a typo.
 794
 795 2019-04-10  Tom Tromey  <tom@tromey.com>
 796
 797         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 798         * minsyms.c (lookup_minimal_symbol): Use foreach.
 799         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 800         (lookup_minimal_symbol_solib_trampoline): Likewise.
 801         * symfile.c (reread_symbols): Use foreach.
 802
 803 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 804             Tom Tromey  <tromey@adacore.com>
 805
 806         PR rust/24414:
 807         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 808         (rust_lex_int_test): Change "value" to be LONGEST.
 809         (rust_lex_tests): Add test for long integer literal.
 810
 811 2019-04-09  Tom Tromey  <tromey@adacore.com>
 812
 813         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 814         to bool.
 815         (extended_remote_target::attach): Update.
 816         (remote_target::remote_notice_new_inferior): Update.
 817         (remote_target::add_current_inferior_and_thread): Update.
 818         * inferior.c (exit_inferior_1): Use "false".
 819         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 820
 821 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 822
 823         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 824         the "start" command.
 825
 826 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 827
 828         * python/py-inferior.c (infpy_thread_from_thread_handle):
 829         Adjust comments to reflect renaming of thread_from_thread_handle
 830         to thread_from_handle.  Adjust keywords.  Fix type error message.
 831         (inferior_object_methods): Add thread_from_handle.  Retain
 832         thread_from_thread_handle, but mark it as deprecated.
 833
 834 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 835
 836         * gdbthread.h (find_thread_by_handle): Revise declaration.
 837         * thread.c (find_thread_by_handle): Likewise.  Adjust
 838         implementation too.
 839         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 840         support for buffer objects as handles.
 841
 842 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 843
 844         * python/py-infthread.c (thpy_thread_handle): New function.
 845         (thread_object_methods): Register thpy_thread_handle.
 846
 847 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 848
 849         * gdbthread.h (thread_to_thread_handle): Declare.
 850         * thread.c (gdbtypes.h): Include.
 851         (thread_to_thread_handle): New function.
 852
 853         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 854         (target_thread_info_to_thread_handle): Declare.
 855         * target.c (target_thread_info_to_thread_handle): New function.
 856         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 857         * target-delegates.c: Regenerate.
 858
 859         * linux-thread-db.c (class thread_db_target): Add method
 860         thread_info_to_thread_handle.
 861         (thread_db_target::thread_info_to_thread_handle): Define.
 862         * remote.c (class remote_target): Add new method
 863         thread_info_to_thread_handle.
 864         (remote_target::thread_info_to_thread_handle): Define.
 865
 866 2019-04-08  Pedro Alves  <palves@redhat.com>
 867
 868         * common/common-exceptions.c (throw_exception): Don't create
 869         named object to throw; throw directly.
 870         (throw_it): Likewise.  Don't initialize gdb_exception::message
 871         here, with new; pass FMT and AP to the ctor instead.
 872         * common/common-exceptions.h: Include <string>.
 873         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 874         const char *, va_list)): New ctor.  Use std::make_shared.
 875         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 876         errors)): Delete.
 877         (gdb_exception_error::gdb_exception_error(enum errors, const char
 878         *, va_list)): New.
 879         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 880         Add assertion.
 881         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 882         errors)): Delete.
 883         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 884         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 885         Add assertion.
 886
 887 2019-04-08  Tom Tromey  <tom@tromey.com>
 888
 889         * valops.c (value_rtti_indirect_type): Replace throw_exception
 890         with throw.
 891         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 892         with throw.
 893         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 894         throw.
 895         * target.c (target_translate_tls_address): Replace throw_exception
 896         with throw.
 897         * stack.c (frame_apply_command_count): Replace throw_exception
 898         with throw.
 899         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 900         throw.
 901         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 902         with throw.
 903         * rs6000-tdep.c (rs6000_frame_cache)
 904         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 905         * remote.c: Replace throw_exception with throw.
 906         * record-full.c (record_full_message, record_full_wait_1)
 907         (record_full_restore): Replace throw_exception with throw.
 908         * record-btrace.c:
 909         (get_thread_current_frame_id, record_btrace_start_replaying)
 910         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 911         (cmd_record_btrace_start): Replace throw_exception with throw.
 912         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 913         throw.
 914         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 915         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 916         * linespec.c:
 917         (find_linespec_symbols): Replace throw_exception with throw.
 918         * infrun.c (displaced_step_prepare, resume): Replace
 919         throw_exception with throw.
 920         * infcmd.c (post_create_inferior): Replace throw_exception with
 921         throw.
 922         * inf-loop.c (inferior_event_handler): Replace throw_exception
 923         with throw.
 924         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 925         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 926         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 927         (get_prev_frame_always, get_frame_pc_if_available)
 928         (get_frame_address_in_block_if_available, get_frame_language):
 929         Replace throw_exception with throw.
 930         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 931         throw_exception with throw.
 932         * eval.c (fetch_subexp_value, evaluate_var_value)
 933         (evaluate_funcall, evaluate_subexp_standard): Replace
 934         throw_exception with throw.
 935         * dwarf2loc.c (call_site_find_chain)
 936         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 937         Replace throw_exception with throw.
 938         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 939         with throw.
 940         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 941         throw.
 942         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 943         * completer.c (complete_line_internal): Replace throw_exception
 944         with throw.
 945         * compile/compile-object-run.c (compile_object_run): Replace
 946         throw_exception with throw.
 947         * cli/cli-script.c (process_next_line): Replace throw_exception
 948         with throw.
 949         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 950         (btrace_enable, btrace_maint_update_pt_packets): Replace
 951         throw_exception with throw.
 952         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
 953         throw_exception with throw.
 954         * break-catch-throw.c (re_set_exception_catchpoint): Replace
 955         throw_exception with throw.
 956         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
 957         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
 958         * aarch64-tdep.c (aarch64_make_prologue_cache)
 959         (aarch64_make_stub_cache): Replace throw_exception with throw.
 960
 961 2019-04-08  Tom Tromey  <tom@tromey.com>
 962
 963         * common/common-exceptions.c (throw_exception): Rename from
 964         throw_exception_cxx.  Remove old copy.  Make argument const.
 965         (throw_it): Create and throw exception objects directly.
 966         * common/common-exceptions.h (throw_exception): Make argument
 967         const.
 968         (struct gdb_exception_error): Add constructor.
 969         (struct gdb_exception_quit): Add constructor.
 970
 971 2019-04-08  Tom Tromey  <tom@tromey.com>
 972
 973         * common/common-exceptions.h (exception_rethrow): Don't declare.
 974         (TRY_SJLJ): Update comment.
 975         (TRY, CATCH, END_CATCH): Remove.
 976         * common/common-exceptions.c (exception_rethrow): Remove.
 977
 978 2019-04-08  Tom Tromey  <tom@tromey.com>
 979
 980         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
 981         Remove.
 982         (gdb_exception_error): Rename from
 983         gdb_exception_RETURN_MASK_ERROR.
 984         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
 985         (gdb_quit_bad_alloc): Update.
 986         * aarch64-tdep.c: Update.
 987         * ada-lang.c: Update.
 988         * ada-typeprint.c: Update.
 989         * ada-valprint.c: Update.
 990         * amd64-tdep.c: Update.
 991         * arch-utils.c: Update.
 992         * break-catch-throw.c: Update.
 993         * breakpoint.c: Update.
 994         * btrace.c: Update.
 995         * c-varobj.c: Update.
 996         * cli/cli-cmds.c: Update.
 997         * cli/cli-interp.c: Update.
 998         * cli/cli-script.c: Update.
 999         * common/common-exceptions.c: Update.
1000         * common/new-op.c: Update.
1001         * common/selftest.c: Update.
1002         * compile/compile-c-symbols.c: Update.
1003         * compile/compile-cplus-symbols.c: Update.
1004         * compile/compile-object-load.c: Update.
1005         * compile/compile-object-run.c: Update.
1006         * completer.c: Update.
1007         * corelow.c: Update.
1008         * cp-abi.c: Update.
1009         * cp-support.c: Update.
1010         * cp-valprint.c: Update.
1011         * darwin-nat.c: Update.
1012         * disasm-selftests.c: Update.
1013         * dtrace-probe.c: Update.
1014         * dwarf-index-cache.c: Update.
1015         * dwarf-index-write.c: Update.
1016         * dwarf2-frame-tailcall.c: Update.
1017         * dwarf2-frame.c: Update.
1018         * dwarf2loc.c: Update.
1019         * dwarf2read.c: Update.
1020         * eval.c: Update.
1021         * event-loop.c: Update.
1022         * event-top.c: Update.
1023         * exec.c: Update.
1024         * f-valprint.c: Update.
1025         * fbsd-tdep.c: Update.
1026         * frame-unwind.c: Update.
1027         * frame.c: Update.
1028         * gdbtypes.c: Update.
1029         * gnu-v3-abi.c: Update.
1030         * guile/guile-internal.h: Update.
1031         * guile/scm-block.c: Update.
1032         * guile/scm-breakpoint.c: Update.
1033         * guile/scm-cmd.c: Update.
1034         * guile/scm-disasm.c: Update.
1035         * guile/scm-frame.c: Update.
1036         * guile/scm-lazy-string.c: Update.
1037         * guile/scm-math.c: Update.
1038         * guile/scm-param.c: Update.
1039         * guile/scm-ports.c: Update.
1040         * guile/scm-pretty-print.c: Update.
1041         * guile/scm-symbol.c: Update.
1042         * guile/scm-symtab.c: Update.
1043         * guile/scm-type.c: Update.
1044         * guile/scm-value.c: Update.
1045         * i386-linux-tdep.c: Update.
1046         * i386-tdep.c: Update.
1047         * inf-loop.c: Update.
1048         * infcall.c: Update.
1049         * infcmd.c: Update.
1050         * infrun.c: Update.
1051         * jit.c: Update.
1052         * language.c: Update.
1053         * linespec.c: Update.
1054         * linux-fork.c: Update.
1055         * linux-nat.c: Update.
1056         * linux-tdep.c: Update.
1057         * linux-thread-db.c: Update.
1058         * main.c: Update.
1059         * mi/mi-cmd-break.c: Update.
1060         * mi/mi-cmd-stack.c: Update.
1061         * mi/mi-interp.c: Update.
1062         * mi/mi-main.c: Update.
1063         * objc-lang.c: Update.
1064         * p-valprint.c: Update.
1065         * parse.c: Update.
1066         * ppc-linux-tdep.c: Update.
1067         * printcmd.c: Update.
1068         * python/py-arch.c: Update.
1069         * python/py-breakpoint.c: Update.
1070         * python/py-cmd.c: Update.
1071         * python/py-finishbreakpoint.c: Update.
1072         * python/py-frame.c: Update.
1073         * python/py-framefilter.c: Update.
1074         * python/py-gdb-readline.c: Update.
1075         * python/py-inferior.c: Update.
1076         * python/py-infthread.c: Update.
1077         * python/py-lazy-string.c: Update.
1078         * python/py-linetable.c: Update.
1079         * python/py-objfile.c: Update.
1080         * python/py-param.c: Update.
1081         * python/py-prettyprint.c: Update.
1082         * python/py-progspace.c: Update.
1083         * python/py-record-btrace.c: Update.
1084         * python/py-record.c: Update.
1085         * python/py-symbol.c: Update.
1086         * python/py-type.c: Update.
1087         * python/py-unwind.c: Update.
1088         * python/py-utils.c: Update.
1089         * python/py-value.c: Update.
1090         * python/python.c: Update.
1091         * record-btrace.c: Update.
1092         * record-full.c: Update.
1093         * remote-fileio.c: Update.
1094         * remote.c: Update.
1095         * riscv-tdep.c: Update.
1096         * rs6000-aix-tdep.c: Update.
1097         * rs6000-tdep.c: Update.
1098         * rust-exp.y: Update.
1099         * rust-lang.c: Update.
1100         * s390-tdep.c: Update.
1101         * selftest-arch.c: Update.
1102         * solib-dsbt.c: Update.
1103         * solib-frv.c: Update.
1104         * solib-spu.c: Update.
1105         * solib-svr4.c: Update.
1106         * solib.c: Update.
1107         * sparc64-linux-tdep.c: Update.
1108         * stack.c: Update.
1109         * symfile-mem.c: Update.
1110         * symmisc.c: Update.
1111         * target.c: Update.
1112         * thread.c: Update.
1113         * top.c: Update.
1114         * tracefile-tfile.c: Update.
1115         * tui/tui.c: Update.
1116         * typeprint.c: Update.
1117         * unittests/cli-utils-selftests.c: Update.
1118         * unittests/parse-connection-spec-selftests.c: Update.
1119         * valops.c: Update.
1120         * valprint.c: Update.
1121         * value.c: Update.
1122         * varobj.c: Update.
1123         * windows-nat.c: Update.
1124         * x86-linux-nat.c: Update.
1125         * xml-support.c: Update.
1126
1127 2019-04-08  Tom Tromey  <tom@tromey.com>
1128
1129         * xml-support.c: Use C++ exception handling.
1130         * x86-linux-nat.c: Use C++ exception handling.
1131         * windows-nat.c: Use C++ exception handling.
1132         * varobj.c: Use C++ exception handling.
1133         * value.c: Use C++ exception handling.
1134         * valprint.c: Use C++ exception handling.
1135         * valops.c: Use C++ exception handling.
1136         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1137         handling.
1138         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1139         * typeprint.c: Use C++ exception handling.
1140         * tui/tui.c: Use C++ exception handling.
1141         * tracefile-tfile.c: Use C++ exception handling.
1142         * top.c: Use C++ exception handling.
1143         * thread.c: Use C++ exception handling.
1144         * target.c: Use C++ exception handling.
1145         * symmisc.c: Use C++ exception handling.
1146         * symfile-mem.c: Use C++ exception handling.
1147         * stack.c: Use C++ exception handling.
1148         * sparc64-linux-tdep.c: Use C++ exception handling.
1149         * solib.c: Use C++ exception handling.
1150         * solib-svr4.c: Use C++ exception handling.
1151         * solib-spu.c: Use C++ exception handling.
1152         * solib-frv.c: Use C++ exception handling.
1153         * solib-dsbt.c: Use C++ exception handling.
1154         * selftest-arch.c: Use C++ exception handling.
1155         * s390-tdep.c: Use C++ exception handling.
1156         * rust-lang.c: Use C++ exception handling.
1157         * rust-exp.y: Use C++ exception handling.
1158         * rs6000-tdep.c: Use C++ exception handling.
1159         * rs6000-aix-tdep.c: Use C++ exception handling.
1160         * riscv-tdep.c: Use C++ exception handling.
1161         * remote.c: Use C++ exception handling.
1162         * remote-fileio.c: Use C++ exception handling.
1163         * record-full.c: Use C++ exception handling.
1164         * record-btrace.c: Use C++ exception handling.
1165         * python/python.c: Use C++ exception handling.
1166         * python/py-value.c: Use C++ exception handling.
1167         * python/py-utils.c: Use C++ exception handling.
1168         * python/py-unwind.c: Use C++ exception handling.
1169         * python/py-type.c: Use C++ exception handling.
1170         * python/py-symbol.c: Use C++ exception handling.
1171         * python/py-record.c: Use C++ exception handling.
1172         * python/py-record-btrace.c: Use C++ exception handling.
1173         * python/py-progspace.c: Use C++ exception handling.
1174         * python/py-prettyprint.c: Use C++ exception handling.
1175         * python/py-param.c: Use C++ exception handling.
1176         * python/py-objfile.c: Use C++ exception handling.
1177         * python/py-linetable.c: Use C++ exception handling.
1178         * python/py-lazy-string.c: Use C++ exception handling.
1179         * python/py-infthread.c: Use C++ exception handling.
1180         * python/py-inferior.c: Use C++ exception handling.
1181         * python/py-gdb-readline.c: Use C++ exception handling.
1182         * python/py-framefilter.c: Use C++ exception handling.
1183         * python/py-frame.c: Use C++ exception handling.
1184         * python/py-finishbreakpoint.c: Use C++ exception handling.
1185         * python/py-cmd.c: Use C++ exception handling.
1186         * python/py-breakpoint.c: Use C++ exception handling.
1187         * python/py-arch.c: Use C++ exception handling.
1188         * printcmd.c: Use C++ exception handling.
1189         * ppc-linux-tdep.c: Use C++ exception handling.
1190         * parse.c: Use C++ exception handling.
1191         * p-valprint.c: Use C++ exception handling.
1192         * objc-lang.c: Use C++ exception handling.
1193         * mi/mi-main.c: Use C++ exception handling.
1194         * mi/mi-interp.c: Use C++ exception handling.
1195         * mi/mi-cmd-stack.c: Use C++ exception handling.
1196         * mi/mi-cmd-break.c: Use C++ exception handling.
1197         * main.c: Use C++ exception handling.
1198         * linux-thread-db.c: Use C++ exception handling.
1199         * linux-tdep.c: Use C++ exception handling.
1200         * linux-nat.c: Use C++ exception handling.
1201         * linux-fork.c: Use C++ exception handling.
1202         * linespec.c: Use C++ exception handling.
1203         * language.c: Use C++ exception handling.
1204         * jit.c: Use C++ exception handling.
1205         * infrun.c: Use C++ exception handling.
1206         * infcmd.c: Use C++ exception handling.
1207         * infcall.c: Use C++ exception handling.
1208         * inf-loop.c: Use C++ exception handling.
1209         * i386-tdep.c: Use C++ exception handling.
1210         * i386-linux-tdep.c: Use C++ exception handling.
1211         * guile/scm-value.c: Use C++ exception handling.
1212         * guile/scm-type.c: Use C++ exception handling.
1213         * guile/scm-symtab.c: Use C++ exception handling.
1214         * guile/scm-symbol.c: Use C++ exception handling.
1215         * guile/scm-pretty-print.c: Use C++ exception handling.
1216         * guile/scm-ports.c: Use C++ exception handling.
1217         * guile/scm-param.c: Use C++ exception handling.
1218         * guile/scm-math.c: Use C++ exception handling.
1219         * guile/scm-lazy-string.c: Use C++ exception handling.
1220         * guile/scm-frame.c: Use C++ exception handling.
1221         * guile/scm-disasm.c: Use C++ exception handling.
1222         * guile/scm-cmd.c: Use C++ exception handling.
1223         * guile/scm-breakpoint.c: Use C++ exception handling.
1224         * guile/scm-block.c: Use C++ exception handling.
1225         * guile/guile-internal.h: Use C++ exception handling.
1226         * gnu-v3-abi.c: Use C++ exception handling.
1227         * gdbtypes.c: Use C++ exception handling.
1228         * frame.c: Use C++ exception handling.
1229         * frame-unwind.c: Use C++ exception handling.
1230         * fbsd-tdep.c: Use C++ exception handling.
1231         * f-valprint.c: Use C++ exception handling.
1232         * exec.c: Use C++ exception handling.
1233         * event-top.c: Use C++ exception handling.
1234         * event-loop.c: Use C++ exception handling.
1235         * eval.c: Use C++ exception handling.
1236         * dwarf2read.c: Use C++ exception handling.
1237         * dwarf2loc.c: Use C++ exception handling.
1238         * dwarf2-frame.c: Use C++ exception handling.
1239         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1240         * dwarf-index-write.c: Use C++ exception handling.
1241         * dwarf-index-cache.c: Use C++ exception handling.
1242         * dtrace-probe.c: Use C++ exception handling.
1243         * disasm-selftests.c: Use C++ exception handling.
1244         * darwin-nat.c: Use C++ exception handling.
1245         * cp-valprint.c: Use C++ exception handling.
1246         * cp-support.c: Use C++ exception handling.
1247         * cp-abi.c: Use C++ exception handling.
1248         * corelow.c: Use C++ exception handling.
1249         * completer.c: Use C++ exception handling.
1250         * compile/compile-object-run.c: Use C++ exception handling.
1251         * compile/compile-object-load.c: Use C++ exception handling.
1252         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1253         * compile/compile-c-symbols.c: Use C++ exception handling.
1254         * common/selftest.c: Use C++ exception handling.
1255         * common/new-op.c: Use C++ exception handling.
1256         * cli/cli-script.c: Use C++ exception handling.
1257         * cli/cli-interp.c: Use C++ exception handling.
1258         * cli/cli-cmds.c: Use C++ exception handling.
1259         * c-varobj.c: Use C++ exception handling.
1260         * btrace.c: Use C++ exception handling.
1261         * breakpoint.c: Use C++ exception handling.
1262         * break-catch-throw.c: Use C++ exception handling.
1263         * arch-utils.c: Use C++ exception handling.
1264         * amd64-tdep.c: Use C++ exception handling.
1265         * ada-valprint.c: Use C++ exception handling.
1266         * ada-typeprint.c: Use C++ exception handling.
1267         * ada-lang.c: Use C++ exception handling.
1268         * aarch64-tdep.c: Use C++ exception handling.
1269
1270 2019-04-08  Tom Tromey  <tom@tromey.com>
1271
1272         * xml-support.c (gdb_xml_parser::parse): Update.
1273         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1274         * value.c (show_convenience): Update.
1275         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1276         (test_parse_flags_qcs): Update.
1277         * thread.c (thr_try_catch_cmd): Update.
1278         * target.c (target_translate_tls_address): Update.
1279         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1280         (info_frame_command_core, frame_apply_command_count): Update.
1281         * rust-exp.y (rust_lex_exception_test): Update.
1282         * riscv-tdep.c (riscv_print_one_register_info): Update.
1283         * remote.c (remote_target::enable_btrace): Update.
1284         * record-btrace.c (record_btrace_enable_warn): Update.
1285         * python/py-utils.c (gdbpy_convert_exception): Update.
1286         * printcmd.c (do_one_display, print_variable_and_value): Update.
1287         * mi/mi-main.c (mi_print_exception): Update.
1288         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1289         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1290         * linux-nat.c (linux_nat_target::attach): Update.
1291         * linux-fork.c (class scoped_switch_fork_info): Update.
1292         * infrun.c (displaced_step_prepare): Update.
1293         * infcall.c (call_function_by_hand_dummy): Update.
1294         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1295         * gnu-v3-abi.c (print_one_vtable): Update.
1296         * frame.c (get_prev_frame_always): Update.
1297         * f-valprint.c (info_common_command_for_block): Update.
1298         * exec.c (try_open_exec_file): Update.
1299         * exceptions.c (print_exception, exception_print)
1300         (exception_fprintf, exception_print_same): Update.
1301         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1302         * dwarf-index-cache.c (index_cache::store)
1303         (index_cache::lookup_gdb_index): Update.
1304         * darwin-nat.c (maybe_cache_shell): Update.
1305         * cp-valprint.c (cp_print_value_fields): Update.
1306         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1307         (gcc_cplus_symbol_address): Update.
1308         * compile/compile-c-symbols.c (gcc_convert_symbol)
1309         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1310         * common/selftest.c: Update.
1311         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1312         a std::string.
1313         (exception_try_scope_entry, exception_try_scope_exit): Don't
1314         declare.
1315         (struct exception_try_scope): Remove.
1316         (TRY): Don't use exception_try_scope.
1317         (struct gdb_exception): Add constructor, operator=.
1318         <what>: New method.
1319         (struct gdb_exception_RETURN_MASK_ALL)
1320         (struct gdb_exception_RETURN_MASK_ERROR)
1321         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1322         (struct gdb_quit_bad_alloc): Update.
1323         * common/common-exceptions.c (exception_none): Change
1324         initializer.
1325         (struct catcher) <state, exception>: Initialize inline.
1326         <prev>: Remove member.
1327         (current_catcher): Remove.
1328         (catchers): New global.
1329         (exceptions_state_mc_init): Simplify.
1330         (catcher_pop): Remove.
1331         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1332         (try_scope_depth, exception_try_scope_entry)
1333         (exception_try_scope_exit): Remove.
1334         (throw_exception_sjlj): Update.
1335         (exception_messages, exception_messages_size): Remove.
1336         (throw_it): Simplify.
1337         (gdb_exception_sliced_copy): Remove.
1338         (throw_exception_cxx): Update.
1339         * cli/cli-script.c (script_from_file): Update.
1340         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1341         Update.
1342         * ada-valprint.c (ada_val_print): Update.
1343         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1344         (create_excep_cond_exprs): Update.
1345
1346 2019-04-08  Tom Tromey  <tom@tromey.com>
1347
1348         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1349         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1350         (TRY, CATCH, END_CATCH): Remove some definitions.
1351         * common/common-exceptions.c: Don't use GDB_XCPT.
1352         (catcher_list_size): Remove.
1353         (throw_exception, throw_it): Simplify.
1354
1355 2019-04-05  Tom Tromey  <tom@tromey.com>
1356
1357         Revert the header-sorting patch.
1358         * ft32-tdep.c: Revert.
1359         * frv-tdep.c: Revert.
1360         * frv-linux-tdep.c: Revert.
1361         * frame.c: Revert.
1362         * frame-unwind.c: Revert.
1363         * frame-base.c: Revert.
1364         * fork-child.c: Revert.
1365         * findvar.c: Revert.
1366         * findcmd.c: Revert.
1367         * filesystem.c: Revert.
1368         * filename-seen-cache.h: Revert.
1369         * filename-seen-cache.c: Revert.
1370         * fbsd-tdep.c: Revert.
1371         * fbsd-nat.h: Revert.
1372         * fbsd-nat.c: Revert.
1373         * f-valprint.c: Revert.
1374         * f-typeprint.c: Revert.
1375         * f-lang.c: Revert.
1376         * extension.h: Revert.
1377         * extension.c: Revert.
1378         * extension-priv.h: Revert.
1379         * expprint.c: Revert.
1380         * exec.h: Revert.
1381         * exec.c: Revert.
1382         * exceptions.c: Revert.
1383         * event-top.c: Revert.
1384         * event-loop.c: Revert.
1385         * eval.c: Revert.
1386         * elfread.c: Revert.
1387         * dwarf2read.h: Revert.
1388         * dwarf2read.c: Revert.
1389         * dwarf2loc.c: Revert.
1390         * dwarf2expr.h: Revert.
1391         * dwarf2expr.c: Revert.
1392         * dwarf2-frame.c: Revert.
1393         * dwarf2-frame-tailcall.c: Revert.
1394         * dwarf-index-write.h: Revert.
1395         * dwarf-index-write.c: Revert.
1396         * dwarf-index-common.c: Revert.
1397         * dwarf-index-cache.h: Revert.
1398         * dwarf-index-cache.c: Revert.
1399         * dummy-frame.c: Revert.
1400         * dtrace-probe.c: Revert.
1401         * disasm.h: Revert.
1402         * disasm.c: Revert.
1403         * disasm-selftests.c: Revert.
1404         * dictionary.c: Revert.
1405         * dicos-tdep.c: Revert.
1406         * demangle.c: Revert.
1407         * dcache.h: Revert.
1408         * dcache.c: Revert.
1409         * darwin-nat.h: Revert.
1410         * darwin-nat.c: Revert.
1411         * darwin-nat-info.c: Revert.
1412         * d-valprint.c: Revert.
1413         * d-namespace.c: Revert.
1414         * d-lang.c: Revert.
1415         * ctf.c: Revert.
1416         * csky-tdep.c: Revert.
1417         * csky-linux-tdep.c: Revert.
1418         * cris-tdep.c: Revert.
1419         * cris-linux-tdep.c: Revert.
1420         * cp-valprint.c: Revert.
1421         * cp-support.c: Revert.
1422         * cp-namespace.c: Revert.
1423         * cp-abi.c: Revert.
1424         * corelow.c: Revert.
1425         * corefile.c: Revert.
1426         * continuations.c: Revert.
1427         * completer.h: Revert.
1428         * completer.c: Revert.
1429         * complaints.c: Revert.
1430         * coffread.c: Revert.
1431         * coff-pe-read.c: Revert.
1432         * cli-out.h: Revert.
1433         * cli-out.c: Revert.
1434         * charset.c: Revert.
1435         * c-varobj.c: Revert.
1436         * c-valprint.c: Revert.
1437         * c-typeprint.c: Revert.
1438         * c-lang.c: Revert.
1439         * buildsym.c: Revert.
1440         * buildsym-legacy.c: Revert.
1441         * build-id.h: Revert.
1442         * build-id.c: Revert.
1443         * btrace.c: Revert.
1444         * bsd-uthread.c: Revert.
1445         * breakpoint.h: Revert.
1446         * breakpoint.c: Revert.
1447         * break-catch-throw.c: Revert.
1448         * break-catch-syscall.c: Revert.
1449         * break-catch-sig.c: Revert.
1450         * blockframe.c: Revert.
1451         * block.c: Revert.
1452         * bfin-tdep.c: Revert.
1453         * bfin-linux-tdep.c: Revert.
1454         * bfd-target.c: Revert.
1455         * bcache.c: Revert.
1456         * ax-general.c: Revert.
1457         * ax-gdb.h: Revert.
1458         * ax-gdb.c: Revert.
1459         * avr-tdep.c: Revert.
1460         * auxv.c: Revert.
1461         * auto-load.c: Revert.
1462         * arm-wince-tdep.c: Revert.
1463         * arm-tdep.c: Revert.
1464         * arm-symbian-tdep.c: Revert.
1465         * arm-pikeos-tdep.c: Revert.
1466         * arm-obsd-tdep.c: Revert.
1467         * arm-nbsd-tdep.c: Revert.
1468         * arm-nbsd-nat.c: Revert.
1469         * arm-linux-tdep.c: Revert.
1470         * arm-linux-nat.c: Revert.
1471         * arm-fbsd-tdep.c: Revert.
1472         * arm-fbsd-nat.c: Revert.
1473         * arm-bsd-tdep.c: Revert.
1474         * arch-utils.c: Revert.
1475         * arc-tdep.c: Revert.
1476         * arc-newlib-tdep.c: Revert.
1477         * annotate.h: Revert.
1478         * annotate.c: Revert.
1479         * amd64-windows-tdep.c: Revert.
1480         * amd64-windows-nat.c: Revert.
1481         * amd64-tdep.c: Revert.
1482         * amd64-sol2-tdep.c: Revert.
1483         * amd64-obsd-tdep.c: Revert.
1484         * amd64-obsd-nat.c: Revert.
1485         * amd64-nbsd-tdep.c: Revert.
1486         * amd64-nbsd-nat.c: Revert.
1487         * amd64-nat.c: Revert.
1488         * amd64-linux-tdep.c: Revert.
1489         * amd64-linux-nat.c: Revert.
1490         * amd64-fbsd-tdep.c: Revert.
1491         * amd64-fbsd-nat.c: Revert.
1492         * amd64-dicos-tdep.c: Revert.
1493         * amd64-darwin-tdep.c: Revert.
1494         * amd64-bsd-nat.c: Revert.
1495         * alpha-tdep.c: Revert.
1496         * alpha-obsd-tdep.c: Revert.
1497         * alpha-nbsd-tdep.c: Revert.
1498         * alpha-mdebug-tdep.c: Revert.
1499         * alpha-linux-tdep.c: Revert.
1500         * alpha-linux-nat.c: Revert.
1501         * alpha-bsd-tdep.c: Revert.
1502         * alpha-bsd-nat.c: Revert.
1503         * aix-thread.c: Revert.
1504         * agent.c: Revert.
1505         * addrmap.c: Revert.
1506         * ada-varobj.c: Revert.
1507         * ada-valprint.c: Revert.
1508         * ada-typeprint.c: Revert.
1509         * ada-tasks.c: Revert.
1510         * ada-lang.c: Revert.
1511         * aarch64-tdep.c: Revert.
1512         * aarch64-ravenscar-thread.c: Revert.
1513         * aarch64-newlib-tdep.c: Revert.
1514         * aarch64-linux-tdep.c: Revert.
1515         * aarch64-linux-nat.c: Revert.
1516         * aarch64-fbsd-tdep.c: Revert.
1517         * aarch64-fbsd-nat.c: Revert.
1518         * aarch32-linux-nat.c: Revert.
1519
1520 2019-04-05  Tom Tromey  <tom@tromey.com>
1521
1522         * ft32-tdep.c: Sort headers.
1523         * frv-tdep.c: Sort headers.
1524         * frv-linux-tdep.c: Sort headers.
1525         * frame.c: Sort headers.
1526         * frame-unwind.c: Sort headers.
1527         * frame-base.c: Sort headers.
1528         * fork-child.c: Sort headers.
1529         * findvar.c: Sort headers.
1530         * findcmd.c: Sort headers.
1531         * filesystem.c: Sort headers.
1532         * filename-seen-cache.h: Sort headers.
1533         * filename-seen-cache.c: Sort headers.
1534         * fbsd-tdep.c: Sort headers.
1535         * fbsd-nat.h: Sort headers.
1536         * fbsd-nat.c: Sort headers.
1537         * f-valprint.c: Sort headers.
1538         * f-typeprint.c: Sort headers.
1539         * f-lang.c: Sort headers.
1540         * extension.h: Sort headers.
1541         * extension.c: Sort headers.
1542         * extension-priv.h: Sort headers.
1543         * expprint.c: Sort headers.
1544         * exec.h: Sort headers.
1545         * exec.c: Sort headers.
1546         * exceptions.c: Sort headers.
1547         * event-top.c: Sort headers.
1548         * event-loop.c: Sort headers.
1549         * eval.c: Sort headers.
1550         * elfread.c: Sort headers.
1551         * dwarf2read.h: Sort headers.
1552         * dwarf2read.c: Sort headers.
1553         * dwarf2loc.c: Sort headers.
1554         * dwarf2expr.h: Sort headers.
1555         * dwarf2expr.c: Sort headers.
1556         * dwarf2-frame.c: Sort headers.
1557         * dwarf2-frame-tailcall.c: Sort headers.
1558         * dwarf-index-write.h: Sort headers.
1559         * dwarf-index-write.c: Sort headers.
1560         * dwarf-index-common.c: Sort headers.
1561         * dwarf-index-cache.h: Sort headers.
1562         * dwarf-index-cache.c: Sort headers.
1563         * dummy-frame.c: Sort headers.
1564         * dtrace-probe.c: Sort headers.
1565         * disasm.h: Sort headers.
1566         * disasm.c: Sort headers.
1567         * disasm-selftests.c: Sort headers.
1568         * dictionary.c: Sort headers.
1569         * dicos-tdep.c: Sort headers.
1570         * demangle.c: Sort headers.
1571         * dcache.h: Sort headers.
1572         * dcache.c: Sort headers.
1573         * darwin-nat.h: Sort headers.
1574         * darwin-nat.c: Sort headers.
1575         * darwin-nat-info.c: Sort headers.
1576         * d-valprint.c: Sort headers.
1577         * d-namespace.c: Sort headers.
1578         * d-lang.c: Sort headers.
1579         * ctf.c: Sort headers.
1580         * csky-tdep.c: Sort headers.
1581         * csky-linux-tdep.c: Sort headers.
1582         * cris-tdep.c: Sort headers.
1583         * cris-linux-tdep.c: Sort headers.
1584         * cp-valprint.c: Sort headers.
1585         * cp-support.c: Sort headers.
1586         * cp-namespace.c: Sort headers.
1587         * cp-abi.c: Sort headers.
1588         * corelow.c: Sort headers.
1589         * corefile.c: Sort headers.
1590         * continuations.c: Sort headers.
1591         * completer.h: Sort headers.
1592         * completer.c: Sort headers.
1593         * complaints.c: Sort headers.
1594         * coffread.c: Sort headers.
1595         * coff-pe-read.c: Sort headers.
1596         * cli-out.h: Sort headers.
1597         * cli-out.c: Sort headers.
1598         * charset.c: Sort headers.
1599         * c-varobj.c: Sort headers.
1600         * c-valprint.c: Sort headers.
1601         * c-typeprint.c: Sort headers.
1602         * c-lang.c: Sort headers.
1603         * buildsym.c: Sort headers.
1604         * buildsym-legacy.c: Sort headers.
1605         * build-id.h: Sort headers.
1606         * build-id.c: Sort headers.
1607         * btrace.c: Sort headers.
1608         * bsd-uthread.c: Sort headers.
1609         * breakpoint.h: Sort headers.
1610         * breakpoint.c: Sort headers.
1611         * break-catch-throw.c: Sort headers.
1612         * break-catch-syscall.c: Sort headers.
1613         * break-catch-sig.c: Sort headers.
1614         * blockframe.c: Sort headers.
1615         * block.c: Sort headers.
1616         * bfin-tdep.c: Sort headers.
1617         * bfin-linux-tdep.c: Sort headers.
1618         * bfd-target.c: Sort headers.
1619         * bcache.c: Sort headers.
1620         * ax-general.c: Sort headers.
1621         * ax-gdb.h: Sort headers.
1622         * ax-gdb.c: Sort headers.
1623         * avr-tdep.c: Sort headers.
1624         * auxv.c: Sort headers.
1625         * auto-load.c: Sort headers.
1626         * arm-wince-tdep.c: Sort headers.
1627         * arm-tdep.c: Sort headers.
1628         * arm-symbian-tdep.c: Sort headers.
1629         * arm-pikeos-tdep.c: Sort headers.
1630         * arm-obsd-tdep.c: Sort headers.
1631         * arm-nbsd-tdep.c: Sort headers.
1632         * arm-nbsd-nat.c: Sort headers.
1633         * arm-linux-tdep.c: Sort headers.
1634         * arm-linux-nat.c: Sort headers.
1635         * arm-fbsd-tdep.c: Sort headers.
1636         * arm-fbsd-nat.c: Sort headers.
1637         * arm-bsd-tdep.c: Sort headers.
1638         * arch-utils.c: Sort headers.
1639         * arc-tdep.c: Sort headers.
1640         * arc-newlib-tdep.c: Sort headers.
1641         * annotate.h: Sort headers.
1642         * annotate.c: Sort headers.
1643         * amd64-windows-tdep.c: Sort headers.
1644         * amd64-windows-nat.c: Sort headers.
1645         * amd64-tdep.c: Sort headers.
1646         * amd64-sol2-tdep.c: Sort headers.
1647         * amd64-obsd-tdep.c: Sort headers.
1648         * amd64-obsd-nat.c: Sort headers.
1649         * amd64-nbsd-tdep.c: Sort headers.
1650         * amd64-nbsd-nat.c: Sort headers.
1651         * amd64-nat.c: Sort headers.
1652         * amd64-linux-tdep.c: Sort headers.
1653         * amd64-linux-nat.c: Sort headers.
1654         * amd64-fbsd-tdep.c: Sort headers.
1655         * amd64-fbsd-nat.c: Sort headers.
1656         * amd64-dicos-tdep.c: Sort headers.
1657         * amd64-darwin-tdep.c: Sort headers.
1658         * amd64-bsd-nat.c: Sort headers.
1659         * alpha-tdep.c: Sort headers.
1660         * alpha-obsd-tdep.c: Sort headers.
1661         * alpha-nbsd-tdep.c: Sort headers.
1662         * alpha-mdebug-tdep.c: Sort headers.
1663         * alpha-linux-tdep.c: Sort headers.
1664         * alpha-linux-nat.c: Sort headers.
1665         * alpha-bsd-tdep.c: Sort headers.
1666         * alpha-bsd-nat.c: Sort headers.
1667         * aix-thread.c: Sort headers.
1668         * agent.c: Sort headers.
1669         * addrmap.c: Sort headers.
1670         * ada-varobj.c: Sort headers.
1671         * ada-valprint.c: Sort headers.
1672         * ada-typeprint.c: Sort headers.
1673         * ada-tasks.c: Sort headers.
1674         * ada-lang.c: Sort headers.
1675         * aarch64-tdep.c: Sort headers.
1676         * aarch64-ravenscar-thread.c: Sort headers.
1677         * aarch64-newlib-tdep.c: Sort headers.
1678         * aarch64-linux-tdep.c: Sort headers.
1679         * aarch64-linux-nat.c: Sort headers.
1680         * aarch64-fbsd-tdep.c: Sort headers.
1681         * aarch64-fbsd-nat.c: Sort headers.
1682         * aarch32-linux-nat.c: Sort headers.
1683
1684 2019-04-04  Tom Tromey  <tom@tromey.com>
1685
1686         * varobj.c (varobj_create): Update.
1687         * rust-exp.y (struct rust_parser) <update_innermost_block,
1688         lookup_symbol>: New methods.
1689         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1690         Rename.
1691         (rust_parser::rust_lookup_type)
1692         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1693         * printcmd.c (display_command, do_one_display): Update.
1694         * parser-defs.h (struct parser_state) <parser_state>: Add
1695         "tracker" parameter.
1696         (block_tracker): New member.
1697         (class innermost_block_tracker) <innermost_block_tracker>: Add
1698         "types" parameter.
1699         <reset>: Remove method.
1700         (innermost_block): Don't declare.
1701         (null_post_parser): Update.
1702         * parse.c (innermost_block): Remove global.
1703         (write_dollar_variable): Update.
1704         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1705         Remove "tracker_types" parameter.
1706         (parse_expression): Add "tracker" parameter.
1707         (parse_expression_for_completion): Update.
1708         (null_post_parser): Add "tracker" parameter.
1709         * p-exp.y: Update rules.
1710         * m2-exp.y: Update rules.
1711         * language.h (struct language_defn) <la_post_parser>: Add
1712         "tracker" parameter.
1713         * go-exp.y: Update rules.
1714         * f-exp.y: Update rules.
1715         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1716         parameter.
1717         * d-exp.y: Update rules.
1718         * c-exp.y: Update rules.
1719         * breakpoint.c (set_breakpoint_condition): Create an
1720         innermost_block_tracker.
1721         (watch_command_1): Likewise.
1722         * ada-lang.c (resolve): Add "tracker" parameter.
1723         (resolve_subexp): Likewise.
1724         * ada-exp.y (write_var_from_sym): Update.
1725
1726 2019-04-04  Tom Tromey  <tom@tromey.com>
1727
1728         * type-stack.h: New file.
1729         * type-stack.c: New file.
1730         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1731         type-stack.h.
1732         (insert_into_type_stack, insert_type, push_type, push_type_int)
1733         (insert_type_address_space, pop_type, pop_type_int)
1734         (pop_typelist, pop_type_stack, append_type_stack)
1735         (push_type_stack, get_type_stack, push_typelist)
1736         (follow_type_instance_flags, follow_types): Don't declare.
1737         * parse.c (type_stack): Remove global.
1738         (parse_exp_in_context): Update.
1739         (insert_into_type_stack, insert_type, push_type, push_type_int)
1740         (insert_type_address_space, pop_type, pop_type_int)
1741         (pop_typelist, pop_type_stack, append_type_stack)
1742         (push_type_stack, get_type_stack, push_typelist)
1743         (follow_type_instance_flags, follow_types): Remove (moved to
1744         type-stack.c).
1745         * f-exp.y (type_stack): New global.
1746         Update rules.
1747         (push_kind_type, f_parse): Update.
1748         * d-exp.y (type_stack): New global.
1749         Update rules.
1750         (d_parse): Update.
1751         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1752         Update rules.
1753         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1754         (HFILES_NO_SRCDIR): Add type-stack.h.
1755
1756 2019-04-04  Tom Tromey  <tom@tromey.com>
1757
1758         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1759         (rust_parser::convert_ast_to_expression, rust_parse)
1760         (rust_lex_test_completion, rust_lex_tests): Update.
1761         * parser-defs.h (struct expr_completion_state): New.
1762         (struct parser_state) <parser_state>: Add completion parameter.
1763         <mark_struct_expression, mark_completion_tag>: New methods.
1764         <parse_completion, m_completion_state>: New members.
1765         (prefixify_expression, null_post_parser): Update.
1766         (mark_struct_expression, mark_completion_tag): Don't declare.
1767         * parse.c (parse_completion, expout_last_struct)
1768         (expout_tag_completion_type, expout_completion_name): Remove
1769         globals.
1770         (parser_state::mark_struct_expression)
1771         (parser_state::mark_completion_tag): Now methods.
1772         (prefixify_expression): Add last_struct parameter.
1773         (prefixify_subexp): Likewise.
1774         (parse_exp_1): Update.
1775         (parse_exp_in_context): Add cstate parameter.  Update.
1776         (parse_expression_for_completion): Create an
1777         expr_completion_state.
1778         (null_post_parser): Add "completion" parameter.
1779         * p-exp.y: Update rules.
1780         (yylex): Update.
1781         * language.h (struct language_defn) <la_post_parser>: Add
1782         "completing" parameter.
1783         * go-exp.y: Update rules.
1784         (lex_one_token): Update.
1785         * expression.h (parse_completion): Don't declare.
1786         * d-exp.y: Update rules.
1787         (lex_one_token): Update rules.
1788         * c-exp.y: Update rules.
1789         (lex_one_token): Update.
1790         * ada-lang.c (resolve): Add "parse_completion" parameter.
1791         (resolve_subexp): Likewise.
1792         (ada_resolve_function): Likewise.
1793
1794 2019-04-04  Tom Tromey  <tom@tromey.com>
1795
1796         * parser-defs.h (struct parser_state) <start_arglist,
1797         end_arglist>: New methods.
1798         <arglist_len, m_funcall_chain>: New members.
1799         (arglist_len, start_arglist, end_arglist): Don't declare.
1800         * parse.c (arglist_len, funcall_chain): Remove global.
1801         (start_arglist, end_arglist): Remove functions.
1802         (parse_exp_in_context): Update.
1803         * p-exp.y: Update rules.
1804         * m2-exp.y: Update rules.
1805         * go-exp.y: Update rules.
1806         * f-exp.y: Update rules.
1807         * d-exp.y: Update rules.
1808         * c-exp.y: Update rules.
1809
1810 2019-04-04  Tom Tromey  <tom@tromey.com>
1811
1812         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1813         lex_operator, push_back>: New methods.
1814         Update all rules.
1815         (rust_parser::lex_hex, lex_escape): Rename and update.
1816         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1817         (rust_parser::lex_operator): Rename and update.
1818         (rust_parser::lex_number, rustyylex, rustyyerror)
1819         (rust_lex_test_init, rust_lex_test_sequence)
1820         (rust_lex_test_push_back, rust_lex_tests): Update.
1821         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1822         parameter.
1823         <lexptr, prev_lexptr>: New members.
1824         (lexptr, prev_lexptr): Don't declare.
1825         * parse.c (lexptr, prev_lexptr): Remove globals.
1826         (parse_exp_in_context): Update.
1827         * p-exp.y (yylex, yyerror): Update.
1828         * m2-exp.y (parse_number, yylex, yyerror): Update.
1829         * go-exp.y (lex_one_token, yyerror): Update.
1830         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1831         * d-exp.y (lex_one_token, yyerror): Update.
1832         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1833         (lex_one_token, yyerror): Update.
1834         * ada-lex.l (YY_INPUT): Update.
1835         (rewind_to_char): Update.
1836         * ada-exp.y (yyerror): Update.
1837
1838 2019-04-04  Tom Tromey  <tom@tromey.com>
1839
1840         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1841         * parser-defs.h (struct parser_state) <parser_state>: Add new
1842         parameter.
1843         <comma_terminates>: New member.
1844         (comma_terminates): Don't declare global.
1845         * parse.c (comma_terminates): Remove global.
1846         (parse_exp_in_context): Update.
1847         * p-exp.y (yylex): Update.
1848         * m2-exp.y (yylex): Update.
1849         * go-exp.y (lex_one_token): Update.
1850         * f-exp.y (yylex): Update.
1851         * d-exp.y (lex_one_token): Update.
1852         * c-exp.y (lex_one_token): Update.
1853         * ada-lex.l: Update.
1854
1855 2019-04-04  Tom Tromey  <tom@tromey.com>
1856
1857         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1858         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1859         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1860         * parser-defs.h (paren_depth): Don't declare.
1861         * parse.c (paren_depth): Remove global.
1862         (parse_exp_in_context): Update.
1863         * p-exp.y (paren_depth): New global.
1864         (pascal_parse): Initialize it.
1865         * m2-exp.y (paren_depth): New global.
1866         (m2_parse): Initialize it.
1867         * go-exp.y (paren_depth): New global.
1868         (go_parse): Initialize it.
1869         * f-exp.y (paren_depth): New global.
1870         (f_parse): Initialize it.
1871         * d-exp.y (paren_depth): New global.
1872         (d_parse): Initialize it.
1873         * c-exp.y (paren_depth): New global.
1874         (c_parse): Initialize it.
1875         * ada-lex.l (paren_depth): New global.
1876         (lexer_init): Initialize it.
1877
1878 2019-04-04  Tom Tromey  <tom@tromey.com>
1879
1880         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1881         (rust_parser::convert_ast_to_type)
1882         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1883         * parser-defs.h (struct parser_state) <parser_state>: Add
1884         parameters.  Initialize new members.
1885         <expression_context_block, expression_context_pc>: New members.
1886         * parse.c (expression_context_block, expression_context_pc):
1887         Remove globals.
1888         (parse_exp_in_context): Update.
1889         * p-exp.y: Update all rules.
1890         (yylex): Update.
1891         * m2-exp.y: Update all rules.
1892         (yylex): Update.
1893         * go-exp.y (yylex): Update.
1894         * f-exp.y (yylex): Update.
1895         * d-exp.y: Update all rules.
1896         (yylex): Update.
1897         * c-exp.y: Update all rules.
1898         (lex_one_token, classify_name, yylex, c_parse): Update.
1899         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1900
1901 2019-04-04  Tom Tromey  <tom@tromey.com>
1902
1903         * gdbarch.h, gdbarch.c: Rebuild.
1904         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1905         * stap-probe.h:
1906         (struct stap_parse_info): Replace "parser_state" with
1907         "expr_builder".
1908         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1909         (parser_state): New class.
1910         * parse.c (expr_builder): Rename.
1911         (expr_builder::release): Rename.
1912         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1913         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1914         (write_exp_elt_longcst, write_exp_elt_floatcst)
1915         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1916         (write_exp_string_vector, write_exp_bitstring)
1917         (write_exp_msymbol, mark_struct_expression)
1918         (write_dollar_variable)
1919         (insert_type_address_space, increase_expout_size): Replace
1920         "parser_state" with "expr_builder".
1921         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1922         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1923         "parser_state" with "expr_builder".
1924
1925 2019-04-04  Tom Tromey  <tom@tromey.com>
1926
1927         * rust-exp.y: Replace "parse_language" with method call.
1928         * p-exp.y:
1929         (yylex): Replace "parse_language" with method call.
1930         * m2-exp.y:
1931         (yylex): Replace "parse_language" with method call.
1932         * go-exp.y (classify_name): Replace "parse_language" with method
1933         call.
1934         * f-exp.y (yylex): Replace "parse_language" with method call.
1935         * d-exp.y (lex_one_token): Replace "parse_language" with method
1936         call.
1937         * c-exp.y:
1938         (lex_one_token, classify_name, yylex): Replace "parse_language"
1939         with method call.
1940         * ada-exp.y (find_primitive_type, type_char)
1941         (type_system_address): Replace "parse_language" with method call.
1942
1943 2019-04-04  Tom Tromey  <tom@tromey.com>
1944
1945         * rust-exp.y: Replace "parse_gdbarch" with method call.
1946         * parse.c (write_dollar_variable, insert_type_address_space):
1947         Replace "parse_gdbarch" with method call.
1948         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1949         call.
1950         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1951         call.
1952         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1953         "parse_gdbarch" with method call.
1954         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1955         with method call.
1956         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1957         "parse_gdbarch" with method call.
1958         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1959         "parse_gdbarch" with method call.
1960         * c-exp.y (parse_type, parse_number, classify_name): Replace
1961         "parse_gdbarch" with method call.
1962         * ada-lex.l: Replace "parse_gdbarch" with method call.
1963         * ada-exp.y (parse_type, find_primitive_type, type_char)
1964         (type_system_address): Replace "parse_gdbarch" with method call.
1965
1966 2019-04-04  Tom Tromey  <tom@tromey.com>
1967
1968         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1969         * stap-probe.c (stap_parse_argument): Update.
1970         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1971         initial_size parameter.
1972         * rust-exp.y (rust_lex_tests): Update.
1973         * parse.c (parser_state): Update.
1974         (parse_exp_in_context): Update.
1975         * parser-defs.h (struct parser_state) <parser_state>: Remove
1976         "initial_size" parameter.
1977
1978 2019-04-04  Tom Tromey  <tom@tromey.com>
1979
1980         * parser-defs.h (increase_expout_size): Don't declare.
1981         * parse.c (increase_expout_size): Now static.
1982
1983 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1984
1985         * gnu-nat.c (gnu_nat_target::wait): Fix
1986         target_waitstatus_to_string call.
1987
1988 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1989
1990         * eval.c (evaluate_subexp_standard): Handle internal functions
1991         during Fortran function call handling.
1992
1993 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1994
1995         * NEWS: Mention new internal functions.
1996         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1997         (read_base_type): Use dwarf2_init_complex_target_type.
1998         * value.c (creal_internal_fn): New function.
1999         (cimag_internal_fn): New function.
2000         (_initialize_values): Register new internal functions.
2001
2002 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2003
2004         * infrun.c (stop_all_threads): If debug_infrun, always
2005         trace the wait status after wait_one, using
2006         target_waitstatus_to_string and target_pid_to_str.
2007         (handle_inferior_event): Replace various trace of
2008         wait status kind by a single trace.
2009         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2010         wait status kind image by target_waitstatus_to_string.
2011         * target/waitstatus.c (target_waitstatus_to_string): Fix
2012         obsolete comment.
2013
2014 2019-04-01  Tom Tromey  <tromey@adacore.com>
2015
2016         PR symtab/23331:
2017         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2018
2019 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2020             Pedro Alves  <palves@redhat.com>
2021
2022         * top.c (quit_force): Call 'finalize_values'.
2023         * value.c (finalize_values): New function.
2024         * value.h (finalize_values): Declare.
2025
2026 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2027
2028         * NEWS: Announce $_gdb_major and $_gdb_minor.
2029
2030         * top.c (init_gdb_version_vars): New function.
2031         (gdb_init): Call init_gdb_version_vars.
2032
2033 2019-03-29  Tom Tromey  <tromey@adacore.com>
2034
2035         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2036         help text.  Remove dead code.
2037
2038 2019-03-29  Keith Seitz  <keiths@redhat.com>
2039
2040         From Siddhesh Poyarekar:
2041         * f-lang.h (f77_get_upperbound): Return LONGEST.
2042         (f77_get_lowerbound): Likewise.
2043         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2044         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2045         print them.
2046         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2047         plongest to format print it.
2048         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2049         (f77_get_upperbound): Likewise.
2050         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2051         LOWER_BOUND to LONGEST.
2052         (f77_create_arrayprint_offset_tbl): Likewise.
2053
2054 2019-03-29  Keith Seitz  <keiths@redhat.com>
2055
2056         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2057         %s/pulongest for TYPE_LENGTH instead of %d in format
2058         strings.
2059         * ada-typerint.c (ada_print_type): Likewise.
2060         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2061         * compile/compile-c-support.c (generate_register_struct): Likewise.
2062         * gdbtypes.c (recursive_dump_type): Likewise.
2063         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2064         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2065         instead of %d in format strings.
2066         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2067         to std::min to ULONGEST.
2068         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2069         instead of %d in format strings.
2070         * tracepoint.c (info_scope_command): Likewise.
2071         * typeprint.c (print_offset_data::update)
2072         (print_offset_data::finish): Likewise.
2073         * xtensa-tdep.c (xtensa_store_return_value)
2074         (xtensa_push_dummy_call): Likewise.
2075
2076 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2077
2078         * windows-nat.c (display_selector): Fixed format specifications
2079         for 64-bit Cygwin.
2080
2081 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2082
2083         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2084
2085 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2086
2087         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2088         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2089         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2090         (nios2_linux_init_abi): Install it.
2091
2092 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2093
2094         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2095
2096 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2097
2098         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2099
2100 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2101             Tom Tromey  <tromey@adacore.com>
2102
2103         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2104
2105 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2106
2107         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2108         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2109         method to compute the bounds of range types. Also print "[evaluated]"
2110         if the bounds' values come from a dynamic evaluation.
2111
2112 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2113
2114         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2115         whitespace when pretty printing is on.
2116
2117 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2118
2119         * ppc-linux-nat.c: Add include.
2120
2121 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2122
2123         * NEWS: Mention AArch64 Pointer Authentication.
2124
2125 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2126
2127         * arm-linux-nat.c: Add include.
2128
2129 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2130
2131         * source-cache.c (source_cache::get_source_lines): Re-read
2132         fullname after calling open_source_file.
2133
2134 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2135
2136         * NEWS: Mention TLS support for FreeBSD.
2137
2138 2019-03-25  Tom Tromey  <tromey@adacore.com>
2139
2140         * minsyms.c (BUNCH_SIZE): Update comment.
2141         (~minimal_symbol_reader): Remove old comment.
2142         (compact_minimal_symbols): Update comment.
2143         (minimal_symbol_reader::install): Remove old comment.  Update
2144         other comments.
2145
2146 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2147
2148         * s390-linux-nat.c: Add include.
2149
2150 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2151
2152         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2153         Call linux_get_hwcap.
2154         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2155         Likewise.
2156         (aarch64_linux_get_hwcap): Remove function.
2157         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2158         declaration.
2159         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2160         linux_get_hwcap.
2161         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2162         * linux-tdep.c (linux_get_hwcap): Add function.
2163         (linux_get_hwcap2): Likewise.
2164         * linux-tdep.h (linux_get_hwcap): Add declaration.
2165         (linux_get_hwcap2): Likewise.
2166         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2167         (ppc_linux_get_hwcap2): Likewise.
2168         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2169         linux_get_hwcap.
2170         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2171         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2172         (ppc_linux_nat_target::read_description): Likewise.
2173         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2174         * s390-linux-nat.c: Likewise.
2175         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2176
2177 2019-03-24  Tom Tromey  <tom@tromey.com>
2178
2179         * ada-lang.c (standard_lookup): Simplify initialization.
2180         (ada_lookup_symbol_nonlocal): Simplify return.
2181         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2182         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2183         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2184         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2185         initialization.
2186         * solib.c (solib_global_lookup): Simplify.
2187         * symtab.c (null_block_symbol): Remove.
2188         (symbol_cache_lookup): Simplify returns.
2189         (lookup_language_this): Simplify returns.
2190         (lookup_symbol_aux): Simplify return.
2191         (lookup_local_symbol): Simplify returns.
2192         (lookup_global_symbol_from_objfile): Simplify return.
2193         (lookup_symbol_in_objfile_symtabs)
2194         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2195         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2196         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2197         * cp-namespace.c (cp_lookup_bare_symbol)
2198         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2199         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2200         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2201         (cp_lookup_symbol_via_imports): Simplify initialization.
2202         (find_symbol_in_baseclass): Likewise.
2203         * symtab.h (null_block_symbol): Remove.
2204         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2205         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2206         (d_lookup_symbol_module): Likewise.
2207         (find_symbol_in_baseclass): Simplify initialization.
2208
2209 2019-03-24  Tom Tromey  <tom@tromey.com>
2210
2211         * expression.h: Don't include symtab.h.
2212         (struct block): Forward declare.
2213
2214 2019-03-24  Tom Tromey  <tom@tromey.com>
2215
2216         * c-exp.y (typebase): Remove casts.
2217         * gdbtypes.c (lookup_unsigned_typename, )
2218         (lookup_signed_typename): Remove cast.
2219         * eval.c (parse_to_comma_and_eval): Remove cast.
2220         * parse.c (write_dollar_variable): Remove cast.
2221         * block.h (struct block) <superblock>: Now const.
2222         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2223         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2224         (map_block): Make "block" const.
2225         * symfile.h (struct quick_symbol_functions)
2226         <map_matching_symbols>: Constify block argument to "callback".
2227         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2228         const.
2229         (find_pc_sect_compunit_symtab): Make "b" const.
2230         (find_symbol_at_address): Likewise.
2231         (search_symbols): Likewise.
2232         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2233         (dw2_debug_names_lookup_symbol): Likewise.
2234         (dw2_map_matching_symbols): Update.
2235         * p-valprint.c (pascal_val_print): Remove "block".
2236         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2237         (aux_add_nonlocal_symbols): Make "block" const.
2238         (resolve_subexp): Remove cast.
2239         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2240         const.
2241         (iterate_over_file_blocks): Likewise.
2242         * f-exp.y (%union) <bval>: Remove.
2243         * coffread.c (patch_opaque_types): Make "b" const.
2244         * spu-tdep.c (spu_catch_start): Make "block" const.
2245         * c-valprint.c (print_unpacked_pointer): Remove "block".
2246         * symmisc.c (dump_symtab_1): Make "b" const.
2247         (block_depth): Make "block" const.
2248         * d-exp.y (%union) <bval>: Remove.
2249         * cp-support.h (cp_lookup_rtti_type): Update.
2250         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2251         * psymtab.c (psym_lookup_symbol): Make "block" const.
2252         (maintenance_check_psymtabs): Make "b" const.
2253         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2254         (enumerate_locals, enumerate_args): Update.
2255         * python/py-symtab.c (stpy_global_block): Make "block" const.
2256         (stpy_static_block): Likewise.
2257         * inline-frame.c (block_starting_point_at): Make "new_block"
2258         const.
2259         * block.c (find_block_in_blockvector): Make return type const.
2260         (blockvector_for_pc_sect): Make "b" const.
2261         (find_block_in_blockvector): Make "b" const.
2262
2263 2019-03-23  Tom Tromey  <tom@tromey.com>
2264
2265         * varobj.c (varobj_create): Update.
2266         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2267         * printcmd.c (display_command, do_one_display): Don't reset
2268         innermost_block.
2269         * parser-defs.h (enum innermost_block_tracker_type): Move to
2270         expression.h.
2271         (innermost_block): Update comment.
2272         * parse.c (parse_exp_1): Add tracker_types parameter.
2273         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2274         tracker_types parameter.  Reset innermost_block.
2275         (parse_exp_in_context): Remove.
2276         (parse_expression_for_completion): Update.
2277         * objfiles.c (~objfile): Don't reset expression_context_block or
2278         innermost_block.
2279         * expression.h (enum innermost_block_tracker_type): Move from
2280         parser-defs.h.
2281         (parse_exp_1): Add tracker_types parameter.
2282         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2283         reset innermost_block.
2284
2285 2019-03-23  Tom Tromey  <tom@tromey.com>
2286
2287         * objfiles.h: Include bcache.h.
2288
2289 2019-03-23  Tom Tromey  <tom@tromey.com>
2290
2291         * linespec.c (get_current_search_block): Use
2292         scoped_restore_current_language.
2293         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2294
2295 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2296             Jiong Wang  <jiong.wang@arm.com>
2297
2298         * aarch64-linux-tdep.c
2299         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2300         section.
2301         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2302
2303 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2304             Jiong Wang  <jiong.wang@arm.com>
2305
2306         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2307         instructions.
2308         (aarch64_analyze_prologue_test): Add PACIASP test.
2309         (aarch64_prologue_prev_register): Unmask PC value.
2310
2311 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2312             Jiong Wang  <jiong.wang@arm.com>
2313
2314         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2315         (aarch64_dwarf2_prev_register): Unmask PC value.
2316         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2317         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2318         DW_CFA_AARCH64_negate_ra_state.
2319         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2320
2321 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2322             Jiong Wang  <jiong.wang@arm.com>
2323
2324         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2325         registers.
2326         (aarch64_pseudo_register_name): Likewise.
2327         (aarch64_pseudo_register_type): Likewise.
2328         (aarch64_pseudo_register_reggroup_p): Likewise.
2329         (aarch64_gdbarch_init): Add pauth registers.
2330         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2331         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2332         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2333         (struct gdbarch_tdep): Add regnum for ra_state.
2334
2335 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2336             Jiong Wang  <jiong.wang@arm.com>
2337
2338         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2339
2340 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2341             Jiong Wang  <jiong.wang@arm.com>
2342
2343         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2344         function.
2345         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2346         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2347         (aarch64_gdbarch_init): Add puth registers.
2348         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2349         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2350         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2351
2352 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2353             Jiong Wang  <jiong.wang@arm.com>
2354
2355         * aarch64-linux-nat.c
2356         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2357         * aarch64-linux-tdep.c
2358         (aarch64_linux_core_read_description): Likewise.
2359         (aarch64_linux_get_hwcap): New function.
2360         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2361         (aarch64_linux_get_hwcap): New declaration.
2362
2363 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2364             Jiong Wang  <jiong.wang@arm.com>
2365
2366         * aarch64-linux-nat.c
2367         (aarch64_linux_nat_target::read_description): Add pauth param.
2368         * aarch64-linux-tdep.c
2369         (aarch64_linux_core_read_description): Likewise.
2370         * aarch64-tdep.c (struct target_desc): Add in pauth.
2371         (aarch64_read_description): Add pauth param.
2372         (aarch64_gdbarch_init): Likewise.
2373         * aarch64-tdep.h (aarch64_read_description): Likewise.
2374         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2375         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2376         * features/Makefile: Add new files.
2377         * features/aarch64-pauth.c: New file.
2378         * features/aarch64-pauth.xml: New file.
2379
2380 2019-03-20  Tom Tromey  <tromey@adacore.com>
2381
2382         * infrun.c (handle_inferior_event): Rename from
2383         handle_inferior_event_1.  Create a scoped_value_mark.
2384         (handle_inferior_event): Remove.
2385
2386 2019-03-19  Tom Tromey  <tromey@adacore.com>
2387
2388         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2389         * infrun.h (print_stop_event): Add "displays" parameter.
2390         * infrun.c (print_stop_event): Add "displays" parameter.
2391
2392 2019-03-19  Pedro Alves  <palves@redhat.com>
2393
2394         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2395         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2396         to -1.  Fix TABs vs spaces.
2397         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2398         * tui/tui-out.h (tui_ui_out) Add intro comments.
2399         <m_line, m_start_of_line>: In-class initialize, and add describing
2400         comment.
2401
2402 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2403
2404         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2405         variable names.
2406         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2407
2408 2019-03-18  Pedro Alves  <palves@redhat.com>
2409             Eli Zaretskii <eliz@gnu.org>
2410
2411         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2412         m_line and m_start_of_line.
2413
2414 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2415
2416         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2417         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2418         it returns a newline.  This fixes a regression in TU mode, whereby
2419         the next line is output on the same screen line as the user input.
2420
2421 2019-03-18  Tom Tromey  <tromey@adacore.com>
2422
2423         * minsyms.c (minimal_symbol_reader::install): Remove call to
2424         obstack_blank.
2425
2426 2019-03-18  Pedro Alves  <palves@redhat.com>
2427
2428         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2429         New globals.
2430         (apply_style): New, factored out from ...
2431         (apply_ansi_escape): ... this.  Handle reverse video mode.
2432         (tui_set_reverse_mode): New function.
2433         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2434         * tui/tui-winsource.c (tui_show_source_line): Use
2435         tui_set_reverse_mode instead of setting A_STANDOUT.
2436         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2437         New setter methods.
2438
2439 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2440
2441         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2442         Handle tabs.
2443
2444 2019-03-18  Tom Tromey  <tromey@adacore.com>
2445
2446         * ada-lang.c (empty_array): Add "high" parameter.
2447         (ada_evaluate_subexp): Update.
2448
2449 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2450
2451         * unittests/string_view-selftests.c: Define
2452         _initialize_string_view_selftests unconditionally.
2453
2454 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2455
2456         PR gdb/24350
2457         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2458
2459 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2460
2461         PR gdb/24351
2462         * windows-nat.c (display_selector): Fix format specifiers.
2463
2464 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2465
2466         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2467         tui_refill_source_window instead of tui_refresh_win, to update the
2468         current execution line.  This fixes redisplay of the current line
2469         when stepping through the code with "next" or "step".
2470
2471 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2472
2473         * source-cache.c (source_cache::get_source_lines): Call
2474         find_source_lines to initialize s->nlines.  This fixes vertical
2475         scrolling of TUI source window when the DOWN arrow is pressed.
2476
2477 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2478
2479         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2480         linux-thread-db.c (_initialize_thread_db): Likewise.
2481
2482 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2483
2484         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2485         wclrtoeol in tui_show_source_line".  This reverts changes made in
2486         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2487
2488 2019-03-15  Tom Tromey  <tom@tromey.com>
2489
2490         * symtab.h (struct minimal_symbol): Derive from
2491         general_symbol_info.
2492         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2493         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2494         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2495         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2496         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2497         (MSYMBOL_SEARCH_NAME): Update.
2498         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2499         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2500         * minsyms.c (minimal_symbol_reader::record_full): Update.
2501
2502 2019-03-15  Tom Tromey  <tom@tromey.com>
2503
2504         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2505
2506 2019-03-15  Tom Tromey  <tom@tromey.com>
2507
2508         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2509         unique_xmalloc_ptr.
2510         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2511         Update.
2512         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2513         (build_minimal_symbol_hash_tables)
2514         (minimal_symbol_reader::install): Update.
2515
2516 2019-03-15  Tom Tromey  <tom@tromey.com>
2517
2518         * symtab.c (create_demangled_names_hash): Update.
2519         (symbol_set_names): Update.
2520         * objfiles.h (struct objfile_per_bfd_storage)
2521         <demangled_names_hash>: Now an htab_up.
2522         * objfiles.c (objfile_per_bfd_storage): Simplify.
2523
2524 2019-03-15  Tom Tromey  <tom@tromey.com>
2525
2526         * objfiles.h (struct objfile_per_bfd_storage): Declare
2527         destructor.
2528         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2529         New.
2530         (get_objfile_bfd_data): Use new.  Don't initialize
2531         language_of_main.
2532         (free_objfile_per_bfd_storage): Remove.
2533         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2534
2535 2019-03-15  Tom Tromey  <tom@tromey.com>
2536
2537         * symfile.c (reread_symbols): Update.
2538         * objfiles.c (objfile::objfile): Update.
2539         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2540         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2541         comment.
2542         (minimal_symbol_reader::install): Update.
2543         (terminate_minimal_symbol_table): Remove.
2544         * jit.c (jit_object_close_impl): Update.
2545
2546 2019-03-15  Tom Tromey  <tom@tromey.com>
2547
2548         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2549         initializations.
2550
2551 2019-03-15  Tom Tromey  <tom@tromey.com>
2552
2553         * objfiles.h (struct objfile_per_bfd_storage)
2554         <demangled_hash_languages>: Now a bitset.
2555         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2556         (lookup_minimal_symbol): Update.
2557
2558 2019-03-15  Tom Tromey  <tom@tromey.com>
2559
2560         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2561         Don't return the symbol.
2562         * coffread.c (record_minimal_symbol): Use record_full.
2563
2564 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2565
2566         The MS-Windows port of ncurses fails to switch to a color pair if
2567         one or both of the colors are the implicit default colors.  This
2568         change records the default colors when TUI is initialized, and
2569         then specifies them explicitly when a color pair uses the default
2570         colors.  This allows color styling in TUI mode on MS-Windows.
2571
2572         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2573         ncurses_norm_attr.
2574         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2575         colors in ncurses_norm_attr.
2576         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2577         "none", replace it with the default color recorded in
2578         ncurses_norm_attr.
2579
2580 2019-03-14  Tom Tromey  <tromey@adacore.com>
2581
2582         * source-cache.h (class source_cache) <get_source_lines>: Return
2583         std::string.
2584         * source-cache.c (source_cache::extract_lines): Handle case where
2585         first_pos==npos.  Return std::string.
2586         (source_cache::get_source_lines): Update.
2587
2588 2019-03-14  Tom Tromey  <tromey@adacore.com>
2589
2590         * NEWS: Add item for "style sources" commands.
2591         * source-cache.c (source_cache::get_source_lines): Check
2592         source_styling.
2593         * cli/cli-style.c (source_styling): New global.
2594         (_initialize_cli_style): Add "style sources" commands.
2595         (show_style_sources): New function.
2596         * cli/cli-style.h (source_styling): Declare.
2597
2598 2019-03-14  Pedro Alves  <palves@redhat.com>
2599             Tom Tromey  <tromey@adacore.com>
2600
2601         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2602         * tui/tui-winsource.c (tui_refill_source_window): New function,
2603         from...
2604         (tui_horizontal_source_scroll): ... here.  Move some logic.
2605         * cli/cli-style.c (set_style_enabled): Notify new observable.
2606         * tui/tui-hooks.c (tui_redisplay_source): New function.
2607         (tui_attach_detach_observers): Attach or detach
2608         tui_redisplay_source.
2609         * observable.h (source_styling_changed): New observable.
2610         * observable.c: Define source_styling_changed observable.
2611
2612 2019-03-13  Tom Tromey  <tromey@adacore.com>
2613
2614         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2615         (i386_gnu_nat_target::store_registers): Update.
2616         * target-debug.h (target_debug_print_std_string): New macro.
2617         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2618         * windows-tdep.c (display_one_tib): Update.
2619         * tui/tui-stack.c (tui_make_status_line): Update.
2620         * top.c (print_inferior_quit_action): Update.
2621         * thread.c (thr_try_catch_cmd): Update.
2622         (add_thread_with_info): Update.
2623         (thread_target_id_str): Update.
2624         (thr_try_catch_cmd): Update.
2625         (thread_command): Update.
2626         (thread_find_command): Update.
2627         * record-btrace.c (record_btrace_target::info_record)
2628         (record_btrace_resume_thread, record_btrace_target::resume)
2629         (record_btrace_cancel_resume, record_btrace_step_thread)
2630         (record_btrace_target::wait, record_btrace_target::wait)
2631         (record_btrace_target::wait, record_btrace_target::stop): Update.
2632         * progspace.c (print_program_space): Update.
2633         * process-stratum-target.c
2634         (process_stratum_target::thread_address_space): Update.
2635         * linux-fork.c (linux_fork_mourn_inferior)
2636         (detach_checkpoint_command, info_checkpoints_command)
2637         (linux_fork_context): Update.
2638         (linux_fork_detach): Update.
2639         (class scoped_switch_fork_info): Update.
2640         (delete_checkpoint_command): Update.
2641         * infrun.c (follow_fork_inferior): Update.
2642         (follow_fork_inferior): Update.
2643         (proceed_after_vfork_done): Update.
2644         (handle_vfork_child_exec_or_exit): Update.
2645         (follow_exec): Update.
2646         (displaced_step_prepare_throw): Update.
2647         (displaced_step_restore): Update.
2648         (start_step_over): Update.
2649         (resume_1): Update.
2650         (clear_proceed_status_thread): Update.
2651         (proceed): Update.
2652         (print_target_wait_results): Update.
2653         (do_target_wait): Update.
2654         (context_switch): Update.
2655         (stop_all_threads): Update.
2656         (restart_threads): Update.
2657         (finish_step_over): Update.
2658         (handle_signal_stop): Update.
2659         (switch_back_to_stepped_thread): Update.
2660         (keep_going_pass_signal): Update.
2661         (print_exited_reason): Update.
2662         (normal_stop): Update.
2663         * inferior.c (inferior_pid_to_str): Change return type.
2664         (print_selected_inferior): Update.
2665         (add_inferior): Update.
2666         (detach_inferior): Update.
2667         * dummy-frame.c (fprint_dummy_frames): Update.
2668         * dcache.c (dcache_info_1): Update.
2669         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2670         (btrace_fetch, btrace_clear): Update.
2671         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2672         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2673         type.
2674         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2675         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2676         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2677         * gdbarch.c, gdbarch.h: Rebuild.
2678         * gdbarch.sh (core_pid_to_str): Change return type.
2679         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2680         return type.
2681         (windows_nat_target::pid_to_str): Change return type.
2682         (windows_delete_thread): Update.
2683         (windows_nat_target::attach): Update.
2684         (windows_nat_target::files_info): Update.
2685         * target-delegates.c: Rebuild.
2686         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2687         return type.
2688         (sol_thread_target::pid_to_str): Change return type.
2689         * remote.c (class remote_target) <pid_to_str>: Change return
2690         type.
2691         (remote_target::pid_to_str): Change return type.
2692         (extended_remote_target::attach, remote_target::remote_stop_ns)
2693         (remote_target::remote_notif_remove_queued_reply)
2694         (remote_target::push_stop_reply, remote_target::disable_btrace):
2695         Update.
2696         (extended_remote_target::attach): Update.
2697         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2698         type.
2699         (gdbsim_target::pid_to_str): Change return type.
2700         * ravenscar-thread.c (struct ravenscar_thread_target)
2701         <pid_to_str>: Change return type.
2702         (ravenscar_thread_target::pid_to_str): Change return type.
2703         * procfs.c (class procfs_target) <pid_to_str>: Change return
2704         type.
2705         (procfs_target::pid_to_str): Change return type.
2706         (procfs_target::attach): Update.
2707         (procfs_target::detach): Update.
2708         (procfs_target::fetch_registers): Update.
2709         (procfs_target::store_registers): Update.
2710         (procfs_target::wait): Update.
2711         (procfs_target::files_info): Update.
2712         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2713         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2714         return type.
2715         (nto_procfs_target::pid_to_str): Change return type.
2716         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2717         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2718         return type.
2719         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2720         (exit_lwp): Update.
2721         (attach_proc_task_lwp_callback, get_detach_signal)
2722         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2723         (linux_nat_target::resume, wait_lwp, stop_callback)
2724         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2725         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2726         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2727         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2728         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2729         type.
2730         (inf_ptrace_target::attach): Update.
2731         (inf_ptrace_target::files_info): Update.
2732         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2733         type.
2734         (go32_nat_target::pid_to_str): Change return type.
2735         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2736         (gnu_nat_target::wait): Update.
2737         (gnu_nat_target::wait): Update.
2738         (gnu_nat_target::resume): Update.
2739         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2740         (fbsd_nat_target::wait): Update.
2741         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2742         type.
2743         (darwin_nat_target::attach): Update.
2744         * corelow.c (class core_target) <pid_to_str>: Change return type.
2745         (core_target::pid_to_str): Change return type.
2746         * target.c (normal_pid_to_str): Change return type.
2747         (default_pid_to_str): Likewise.
2748         (target_pid_to_str): Change return type.
2749         (target_translate_tls_address): Update.
2750         (target_announce_detach): Update.
2751         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2752         return type.
2753         (bsd_uthread_target::pid_to_str): Change return type.
2754         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2755         type.
2756         (bsd_kvm_target::pid_to_str): Change return type.
2757         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2758         return type.
2759         (aix_thread_target::pid_to_str): Change return type.
2760         * target.h (struct target_ops) <pid_to_str>: Change return type.
2761         (target_pid_to_str, normal_pid_to_str): Likewise.
2762         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2763         type.
2764         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2765         type.
2766         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2767         return type.
2768         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2769         type.
2770         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2771         type.
2772         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2773         return type.
2774
2775 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2776
2777         * NEWS: Mention that the new default MI version is 3.  Mention
2778         changes to the output of commands and events that deal with
2779         multi-location breakpoints.
2780         * breakpoint.c: Include "mi/mi-out.h".
2781         (print_one_breakpoint): Change output syntax if using MI version
2782         >= 3.
2783         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2784         New.
2785         (mi_multi_location_breakpoint_output_fixed): New.
2786         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2787         (mi_cmd_fix_multi_location_breakpoint_output): New.
2788         (mi_multi_location_breakpoint_output_fixed): New.
2789         * mi/mi-cmds.c (mi_cmds): Register command
2790         -fix-multi-location-breakpoint-output.
2791         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2792         interpreter "mi".
2793
2794 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2795
2796         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2797         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2798         instantiate mi_ui_out based on interpreter name.
2799         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2800         * mi/mi-main.c (mi_load_progress): Likewise.
2801
2802 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2803
2804         * NEWS: Combine separate "New targets" sections for 8.3.
2805
2806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2807
2808         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2809         (ppcfbsd_init_abi): Install gdbarch
2810         "fetch_tls_load_module_address" and "get_thread_local_address"
2811         methods.
2812
2813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2814
2815         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2816         (riscv_fbsd_init_abi): Install gdbarch
2817         "fetch_tls_load_module_address" and "get_thread_local_address"
2818         methods.
2819
2820 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2821
2822         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2823         (i386fbsd_init_abi): Install gdbarch
2824         "fetch_tls_load_module_address" and "get_thread_local_address"
2825         methods.
2826
2827 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2828
2829         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2830         (amd64fbsd_init_abi): Install gdbarch
2831         "fetch_tls_load_module_address" and "get_thread_local_address"
2832         methods.
2833
2834 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2835
2836         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2837         (struct fbsd_pspace_data): New type.
2838         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2839         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2840         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2841         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2842         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2843
2844 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2845
2846         * gdbtypes.c (lookup_struct_elt): New function.
2847         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2848         * gdbtypes.h (struct struct_elt): New type.
2849         (lookup_struct_elt): New prototype.
2850
2851 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2852
2853         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2854         remove disabled code block.
2855
2856 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2857
2858         * gdbarch.sh (get_thread_local_address): New method.
2859         * gdbarch.h, gdbarch.c: Regenerate.
2860         * target.c (target_translate_tls_address): Use
2861         gdbarch_get_thread_local_address if present instead of
2862         target::get_thread_local_address.
2863
2864 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2865
2866         * target.h (target::get_thread_local_address): Update comment.
2867
2868 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2869
2870         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2871         objfile->separate_debug_objfile_backlink if not NULL.
2872
2873 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2874
2875         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2876         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2877         (amd64bsd_store_inferior_registers): Likewise.
2878         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2879         Enable segment base registers.
2880         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2881         PT_GETFSBASE and PT_GETGSBASE.
2882         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2883         PT_SETGSBASE.
2884         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2885         segment base registers.
2886         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2887
2888 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2889
2890         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2891         Update calls to i386_target_description to add 'segments'
2892         parameter.
2893         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2894         add segment base registers.
2895         * arch/i386.c (i386_create_target_description): Add 'segments'
2896         parameter to enable segment base registers.
2897         * arch/i386.h (i386_create_target_description): Likewise.
2898         * features/i386/32bit-segments.xml: New file.
2899         * features/i386/32bit-segments.c: Generate.
2900         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2901         call to i386_target_description to add 'segments' parameter.
2902         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2903         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2904         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2905         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2906         if feature is present.
2907         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2908         Add 'segments' parameter to call to i386_target_description.
2909         (i386_target_description): Add 'segments' parameter to enable
2910         segment base registers.
2911         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2912         to call to i386_target_description.
2913         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2914         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2915         Define I386_NUM_REGS.
2916         (i386_target_description): Add 'segments' parameter to enable
2917         segment base registers.
2918
2919 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2920
2921         PR/24325
2922         * source-cache.c: #undef open and close, to avoid unresolved
2923         externals during linking.
2924
2925 2019-03-12  Tom Tromey  <tromey@adacore.com>
2926
2927         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2928         const.  Add initializers.
2929         (_initialize_remote): Don't initialize ptid globals.
2930
2931 2019-03-12  Pedro Alves  <palves@redhat.com>
2932
2933         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2934
2935 2019-03-12  Pedro Alves  <palves@redhat.com>
2936
2937         * cp-name-parser.y (main): Remove unused 'len' variable.
2938
2939 2019-03-12  Tom Tromey  <tromey@adacore.com>
2940
2941         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2942         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2943
2944 2019-03-12  Tom Tromey  <tromey@adacore.com>
2945
2946         * linux-nat.c (iterate_over_lwps): Update.
2947         (stop_callback): Remove parameter.
2948         (stop_wait_callback, detach_callback, resume_set_callback)
2949         (select_singlestep_lwp_callback, set_ignore_sigint)
2950         (status_callback, resumed_callback, resume_clear_callback)
2951         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2952         data parameter.
2953         (linux_nat_target::detach, linux_nat_target::resume)
2954         (linux_stop_and_wait_all_lwps, select_event_lwp)
2955         (linux_nat_filter_event, linux_nat_wait_1)
2956         (linux_nat_target::kill, linux_nat_target::stop)
2957         (linux_nat_target::stop): Update.
2958         (linux_nat_resume_callback): Change type.
2959         (resume_stopped_resumed_lwps, count_events_callback)
2960         (select_event_lwp_callback): Likewise.
2961         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2962         * arm-linux-nat.c (struct update_registers_data): Remove.
2963         (update_registers_callback): Change type.
2964         (arm_linux_insert_hw_breakpoint1): Update.
2965         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2966         parameter.
2967         (x86_linux_dr_set_addr): Update.
2968         (x86_linux_dr_set_control): Update.
2969         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2970         (iterate_over_lwps): Use gdb::function_view.
2971         * nat/aarch64-linux-hw-point.c (struct
2972         aarch64_dr_update_callback_param): Remove.
2973         (debug_reg_change_callback): Change type.
2974         (aarch64_notify_debug_reg_change): Update.
2975         * s390-linux-nat.c (s390_refresh_per_info): Update.
2976
2977 2019-03-11  Tom Tromey  <tromey@adacore.com>
2978
2979         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2980         redundant assignment to "this_cu".
2981
2982 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2983
2984         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2985
2986 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2987
2988         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2989         from...
2990         (rank_one_type): ... this.
2991
2992 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2993
2994         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2995         from...
2996         (rank_one_type): ... this.
2997
2998 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2999
3000         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3001         from...
3002         (rank_one_type): ... this.
3003
3004 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3005
3006         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3007         from...
3008         (rank_one_type): ... this.
3009
3010 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3011
3012         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3013         from...
3014         (rank_one_type): ... this.
3015
3016 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3017
3018         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3019         from...
3020         (rank_one_type): ... this.
3021
3022 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3023
3024         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3025         from...
3026         (rank_one_type): ... this.
3027
3028 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3029
3030         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3031         from...
3032         (rank_one_type): ... this.
3033
3034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3035
3036         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3037         from...
3038         (rank_one_type): ... this.
3039
3040 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3041
3042         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3043         from...
3044         (rank_one_type): ... this.
3045
3046 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3047
3048         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3049         from...
3050         (rank_one_type): ... this.
3051
3052 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3053
3054         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3055         from...
3056         (rank_one_type): ... this.
3057
3058 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3059
3060         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3061         inferior-events' shows the example events.
3062
3063 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3064
3065         Support styling on native MS-Windows console
3066
3067         PR/24315
3068         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3069         on MS-Windows if $TERM is not defined.
3070
3071         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3072
3073         * posix-hdep.c (gdb_console_fputs):
3074         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3075         functions.
3076         * ui-file.h (gdb_console_fputs): Add prototype.
3077
3078         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3079         back to fputs only if the former returns zero.
3080
3081 2019-03-07  Tom Tromey  <tom@tromey.com>
3082
3083         * symmisc.c (print_symbol_bcache_statistics): Update.
3084         (print_objfile_statistics): Update.
3085         * symfile.c (allocate_symtab): Update.
3086         * stabsread.c: Don't include bcache.h.
3087         * psymtab.h (struct psymbol_bcache): Don't declare.
3088         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3089         (psymbol_bcache_init, psymbol_bcache_free)
3090         (psymbol_bcache_get_bcache): Don't declare.
3091         * psymtab.c (struct psymbol_bcache): Remove.
3092         (psymtab_storage::psymtab_storage): Update.
3093         (psymtab_storage::~psymtab_storage): Update.
3094         (psymbol_bcache_init, psymbol_bcache_free)
3095         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3096         (add_psymbol_to_bcache): Update.
3097         (allocate_psymtab): Update.
3098         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3099         macro_cache>: No longer pointers.
3100         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3101         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3102         * macrotab.c (macro_bcache): Update.
3103         * macroexp.c: Don't include bcache.h.
3104         * gdbtypes.c (check_types_worklist): Update.
3105         (types_deeply_equal): Remove TRY/CATCH.  Update.
3106         * elfread.c (elf_symtab_read): Update.
3107         * dwarf2read.c: Don't include bcache.h.
3108         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3109         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3110         (print_bcache_statistics, bcache_memory_used): Don't declare.
3111         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3112         methods.  Rename all data members.
3113         * bcache.c (struct bcache): Move to bcache.h.
3114         (bcache::expand_hash_table): Rename from expand_hash_table.
3115         (bcache): Remove.
3116         (bcache::insert): Rename from bcache_full.
3117         (bcache::compare): Rename from bcache_compare.
3118         (bcache_xmalloc): Remove.
3119         (bcache::~bcache): Rename from bcache_xfree.
3120         (bcache::print_statistics): Rename from print_bcache_statistics.
3121         (bcache::memory_used): Rename from bcache_memory_used.
3122
3123 2019-03-07  Pedro Alves  <palves@redhat.com>
3124
3125         * infrun.c (normal_stop): Also check for
3126         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3127
3128 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3129
3130         * f-lang.c (value_from_host_double): Moved to...
3131         * value.c (value_from_host_double): ...here.
3132         * value.h (value_from_host_double): Declare.
3133         * guile/scm-math.c (vlscm_convert_typed_number): Use
3134         value_from_host_double.
3135         (vlscm_convert_number): Likewise.
3136         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3137         * python/py-value.c (convert_value_from_python): Likewise.
3138
3139 2019-03-06  Tom Tromey  <tom@tromey.com>
3140
3141         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3142
3143 2019-03-06  Tom Tromey  <tom@tromey.com>
3144
3145         * utils.h (free_current_contents): Don't declare.
3146         * utils.c (free_current_contents): Remove.
3147
3148 2019-03-06  Tom Tromey  <tom@tromey.com>
3149
3150         * top.c (quit_force): Update.
3151         * main.c (captured_command_loop): Update.
3152         * common/new-op.c (operator new): Update.
3153         * common/common-exceptions.c (struct catcher)
3154         <save_cleanup_chain>: Remove member.
3155         (exceptions_state_mc_init): Update.
3156         (exception_try_scope_entry): Return nullptr.
3157         (exception_try_scope_exit, exception_rethrow)
3158         (throw_exception_sjlj, throw_exception_cxx): Update.
3159         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3160         (all_cleanups, do_cleanups, discard_cleanups)
3161         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3162         (restore_cleanups, restore_final_cleanups): Don't declare.
3163         (do_final_cleanups): Remove parameter.
3164         * common/cleanups.c (cleanup_chain, make_cleanup)
3165         (make_cleanup_dtor, all_cleanups, do_cleanups)
3166         (discard_my_cleanups, discard_cleanups)
3167         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3168         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3169         (null_cleanup): Remove.
3170         (do_final_cleanups): Remove parameter.
3171
3172 2019-03-06  Tom Tromey  <tom@tromey.com>
3173
3174         * remote.c (remote_target::remote_parse_stop_reply): Use
3175         unique_xmalloc_ptr.
3176
3177 2019-03-06  Tom Tromey  <tom@tromey.com>
3178
3179         * stabsread.c (struct stabs_field_info): Rename from field_info.
3180         <list, fnlist>: Add initializers.
3181         <obstack>: New member.
3182         (read_member_functions, read_struct_fields, read_baseclasses):
3183         Allocate on obstack.  Don't use cleanups.
3184         (read_one_struct_field, read_member_functions, read_struct_fields)
3185         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3186         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3187         (read_struct_type): Update.
3188
3189 2019-03-06  Tom Tromey  <tom@tromey.com>
3190
3191         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3192         * common/filestuff.h (make_cleanup_close): Don't declare.
3193         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3194         Remove.
3195
3196 2019-03-06  Tom Tromey  <tom@tromey.com>
3197
3198         * solib-aix.c: Use make_scope_exit.
3199
3200 2019-03-06  Tom Tromey  <tom@tromey.com>
3201
3202         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3203         Use make_scope_exit.
3204
3205 2019-03-06  Tom Tromey  <tom@tromey.com>
3206
3207         * solib-svr4.c (disable_probes_interface): Remove parameter.
3208         (svr4_handle_solib_event): Use make_scope_exit.
3209
3210 2019-03-06  Tom Tromey  <tom@tromey.com>
3211
3212         * remote.c (struct stop_reply_deleter): Remove.
3213         (stop_reply_up): Update.
3214         (struct stop_reply): Derive from notif_event.  Don't typedef.
3215         <regcache>: Now a std::vector.
3216         (stop_reply_xfree): Remove.
3217         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3218         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3219         (remote_target::discard_pending_stop_replies): Use delete.
3220         (remote_target::remote_parse_stop_reply): Update.
3221         (remote_target::process_stop_reply): Update.
3222         * remote-notif.h (struct notif_event): Add virtual destructor.
3223         Remove "dtr" member.
3224         (struct notif_client) <alloc_event>: Return a unique_ptr.
3225         (notif_event_xfree): Don't declare.
3226         (notif_event_up): New typedef.
3227         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3228         (notif_event_xfree, do_notif_event_xfree): Remove.
3229         (remote_notif_state_xfree): Update.
3230
3231 2019-03-06  Tom Tromey  <tom@tromey.com>
3232
3233         * infrun.c (displaced_step_clear_cleanup): Now a
3234         forward_scope_exit type.
3235         (displaced_step_prepare_throw): Update.
3236         (displaced_step_fixup): Update.
3237
3238 2019-03-06  Tom Tromey  <tom@tromey.com>
3239
3240         * inferior.h (class inferior): Update comment.
3241         * gdbthread.h (class thread_info): Update comment.
3242
3243 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3244             Tom Tromey  <tom@tromey.com>
3245
3246         * stabsread.h (struct stab_section_list): Remove.
3247         (coffstab_build_psymtabs): Update.
3248         * dbxread.c (symbuf_sections): Now a std::vector.
3249         (sect_idx): New global.
3250         (fill_symbuf): Update.
3251         (coffstab_build_psymtabs): Change type of stabsects parameter.
3252         Update.
3253         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3254         std::vector.
3255         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3256         (coff_locate_sections): Update.
3257         (coff_symfile_read): Remove cleanups.  Update.
3258         (init_stringtab): Add storage parameter.
3259         (free_stringtab, free_stringtab_cleanup): Remove.
3260         (init_lineno): Add storage parameter.
3261         (free_linetab, free_linetab_cleanup): Remove.
3262
3263 2019-03-06  Pedro Alves  <palves@redhat.com>
3264
3265         * linux-fork.c (fork_info::clobber_regs): Delete.
3266         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3267         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3268         comment.  Adjust.
3269         (scoped_switch_fork_info::scoped_switch_fork_info)
3270         (checkpoint_command, linux_fork_context): Adjust
3271         fork_save_infrun_state calls.
3272
3273 2019-03-06  Pedro Alves  <palves@redhat.com>
3274
3275         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3276         (inf_has_multiple_threads): Return 'bool' and rewrite using
3277         inferior_info::threads().
3278
3279 2019-03-06  Pedro Alves  <palves@redhat.com>
3280
3281         * linux-fork.c: Include <list>.
3282         (fork_list): Now a std::list instance.
3283         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3284         (forks_exist_p, find_last_fork): Adjust.
3285         (new_fork): Delete.
3286         (one_fork_p): New.
3287         (add_fork): Adjust.
3288         (free_fork): Delete, folded into fork_info::~fork_info().
3289         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3290         Adjust.
3291         (init_fork_list): Delete.
3292         (linux_fork_killall, linux_fork_mourn_inferior)
3293         (linux_fork_detach, info_checkpoints_command): Adjust.
3294         (_initialize_linux_fork): No longer call init_fork_list.
3295
3296 2019-03-06  Pedro Alves  <palves@redhat.com>
3297
3298         * linux-fork.c (new_fork): New, split out of ...
3299         (add_fork): ... this.  Return void.  Move "first fork" special
3300         case from here, to ...
3301         (checkpoint_command): ... here.
3302         * linux-linux.h (add_fork): Return void.
3303
3304 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3305
3306         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3307
3308 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3309             Chris January  <chris.january@arm.com>
3310             David Lecomber  <david.lecomber@arm.com>
3311
3312         * f-exp.y: New token, UNOP_INTRINSIC.
3313         (exp): New pattern using UNOP_INTRINSIC token.
3314         (f77_keywords): Add 'abs' keyword.
3315         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3316         (value_from_host_double): New function.
3317         (evaluate_subexp_f): Support UNOP_ABS.
3318
3319 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3320
3321         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3322         types.
3323
3324 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3325
3326         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3327         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3328         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3329
3330 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3331
3332         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3333
3334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3335             Chris January  <chris.january@arm.com>
3336
3337         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3338         * f-exp.y: Define 'KIND' token.
3339         (exp): New pattern for KIND expressions.
3340         (ptype): Handle types with a kind extension.
3341         (direct_abs_decl): Extend to spot kind extensions.
3342         (f77_keywords): Add 'kind' to the list.
3343         (push_kind_type): New function.
3344         (convert_to_kind_type): New function.
3345         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3346         * parse.c (operator_length_standard): Likewise.
3347         * parser-defs.h (enum type_pieces): Add tp_kind.
3348         * std-operator.def: Add UNOP_KIND.
3349
3350 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3351
3352         * f-exp.y (f_parse): Set yydebug.
3353
3354 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3355
3356         * f-lang.c (evaluate_subexp_f): New function.
3357         (exp_descriptor_f): New global.
3358         (f_language_defn): Use exp_descriptor_f instead of
3359         exp_descriptor_standard.
3360
3361 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3362
3363         * f-exp.y (struct token): Add comments.
3364         (dot_ops): Remove uppercase versions and the end marker.
3365         (f77_keywords): Likewise.
3366         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3367         entries in the dot_ops array are case insensitive, and use
3368         strncasecmp to compare strings.  Also some whitespace cleanup in
3369         this area.  Similar for the f77_keywords array, except entries in
3370         this list might be case sensitive.
3371
3372 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3373
3374         * f-exp.y (struct f77_boolean_val): Add comments.
3375         (boolean_values): Remove uppercase versions, and end marker.
3376         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3377         and use strncasecmp to achieve case insensitivity.  Additionally,
3378         perform whitespace cleanup around this code.
3379
3380 2019-03-06  Tom Tromey  <tromey@adacore.com>
3381
3382         * remote-sim.c (gdbsim_target_open): Use result of
3383         gdb_argv::release.
3384
3385 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3386         Dirk Schubert  <dirk.schubert@arm.com>
3387         Chris January  <chris.january@arm.com>
3388
3389         * eval.c (evaluate_subexp_standard): Call Fortran argument
3390         wrapping logic.
3391         * f-lang.c (struct value): A value which can be passed into a
3392         Fortran function call.
3393         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3394         where appropriate.
3395         (struct type): Value ready for a Fortran function call.
3396         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3397         is needed.
3398         * f-lang.h (fortran_argument_convert): Declaration.
3399         (fortran_preserve_arg_pointer): Declaration.
3400         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3401
3402 2019-03-05  Tom Tromey  <tromey@adacore.com>
3403
3404         * python/py-prettyprint.c (print_string_repr): Remove #if.
3405         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3406
3407 2019-03-05  Tom Tromey  <tromey@adacore.com>
3408
3409         * target.c (the_dummy_target): Move later.  Change type to
3410         "dummy_target".
3411         (initialize_targets): Don't initialize the_dummy_target.
3412
3413 2019-03-05  Tom Tromey  <tromey@adacore.com>
3414
3415         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3416         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3417
3418 2019-03-05  Tom Tromey  <tromey@adacore.com>
3419
3420         * windows-nat.c (windows_nat_target::attach)
3421         (windows_nat_target::detach): Don't call gdb_flush.
3422         * valprint.c (generic_val_print, val_print, val_print_string):
3423         Don't call gdb_flush.
3424         * utils.c (defaulted_query): Don't call gdb_flush.
3425         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3426         * target.c (target_announce_detach): Don't call gdb_flush.
3427         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3428         * remote.c (extended_remote_target::attach): Don't call
3429         gdb_flush.
3430         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3431         * printcmd.c (do_examine): Don't call gdb_flush.
3432         (info_display_command): Don't call gdb_flush.
3433         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3434         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3435         * memattr.c (info_mem_command): Don't call gdb_flush.
3436         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3437         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3438         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3439         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3440         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3441         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3442         (gnu_nat_target::detach): Don't call gdb_flush.
3443         * f-valprint.c (f_val_print): Don't call gdb_flush.
3444         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3445         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3446         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3447         gdb_flush.
3448         * c-valprint.c (c_val_print): Don't call gdb_flush.
3449         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3450
3451 2019-03-05  Tom Tromey  <tromey@adacore.com>
3452
3453         * varobj.c (update_dynamic_varobj_children): Update.
3454         (install_default_visualizer): Use reset, not release.
3455         * value.c (set_internalvar): Update.
3456         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3457         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3458         ATTRIBUTE_UNUSED_RESULT.
3459
3460 2019-03-05  Tom Tromey  <tromey@adacore.com>
3461
3462         * remote.c (class scoped_remote_fd) <release>: Add
3463         ATTRIBUTE_UNUSED_RESULT.
3464
3465 2019-03-05  Tom Tromey  <tromey@adacore.com>
3466
3467         * macroexp.c (struct macro_buffer) <release>: Add
3468         ATTRIBUTE_UNUSED_RESULT.
3469
3470 2019-03-05  Tom Tromey  <tromey@adacore.com>
3471
3472         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3473         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3474         ATTRIBUTE_UNUSED_RESULT.
3475
3476 2019-03-05  Tom Tromey  <tromey@adacore.com>
3477
3478         * common/scoped_fd.h (class scoped_fd) <release>: Add
3479         ATTRIBUTE_UNUSED_RESULT.
3480
3481 2019-03-05  Tom Tromey  <tromey@adacore.com>
3482
3483         * parser-defs.h (struct parser_state) <release>: Add
3484         ATTRIBUTE_UNUSED_RESULT.
3485
3486 2019-03-05  Tom Tromey  <tromey@adacore.com>
3487
3488         * utils.h (class gdb_argv) <release>: Add
3489         ATTRIBUTE_UNUSED_RESULT.
3490         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3491
3492 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3493
3494         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3495         for-loop range, to avoid compiler warnings.
3496
3497         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3498         avoid compiler warnings about unused variables.
3499
3500         * NEWS: Mention end of support for native debugging on MS-Windows
3501         before XP.
3502
3503         PR gdb/24292
3504         * common/netstuff.c:
3505         * gdbserver/gdbreplay.c
3506         * gdbserver/remote-utils.c:
3507         * ser-tcp.c:
3508         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3509         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3510         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3511         'getaddrinfo' and 'freeaddrinfo' were not available before
3512         Windows XP, and mingw.org's MinGW headers by default define
3513         _WIN32_WINNT to 0x500.
3514
3515 2019-03-01  Gary Benson <gbenson@redhat.com>
3516
3517         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3518
3519 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3520             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3521
3522         PR gdb/8527
3523         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3524         set_sigint_trap, clear_sigint_trap.
3525
3526 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3527
3528         * target.c (target_detach): Clear the regcache and the
3529         frame cache.
3530
3531 2019-02-27  Pedro Alves  <palves@redhat.com>
3532
3533         * utils.c (set_screen_size): When we cap the height/width sizes,
3534         tweak the corresponding command variable to show "unlimited":
3535
3536 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3537             Pedro Alves  <palves@redhat.com>
3538
3539         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3540         before calling rl_set_screen_size.
3541
3542 2019-02-27  Tom Tromey  <tromey@adacore.com>
3543
3544         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3545         define.
3546         * python/py-value.c: Remove Python 2.4 workaround.
3547         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3548         workaround.
3549         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3550         Python 2.4 workaround.
3551         * python/python-internal.h: Remove Python 2.4 comment.
3552         (Py_ssize_t): Don't define.
3553         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3554         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3555         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3556         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3557         * python/python.c (do_start_initialization): Remove Python 2.4
3558         workaround.
3559         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3560         (print_children): Remove Python 2.4 workaround.
3561         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3562         workaround.
3563         (CHARBUFFERPROC_NAME): Remove.
3564         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3565         Python 2.4 workaround.
3566
3567 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3568
3569         * NEWS: Note minimum Python version.
3570
3571 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3572
3573         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3574         code from these functions.  Remove corresponding ifdefs.  Use
3575         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3576         Remove gotos and target of gotos.
3577         (infpy_search_memory): Likewise.
3578
3579 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3580
3581         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3582         (hppa_gdbarch_init): Don't register deleted functions with
3583         gdbarch.
3584
3585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3586
3587         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3588         (h8300_unwind_sp): Delete.
3589         (h8300_dummy_id): Delete.
3590         (h8300_gdbarch_init): Don't register deleted functions with
3591         gdbarch.
3592
3593 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3594
3595         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3596         (ft32_unwind_pc): Delete.
3597         (ft32_unwind_sp): Delete.
3598         (ft32_gdbarch_init): Don't register deleted functions with
3599         gdbarch.
3600
3601 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3602
3603         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3604         (frv_unwind_pc): Delete.
3605         (frv_unwind_sp): Delete.
3606         (frv_gdbarch_init): Don't register deleted functions with
3607         gdbarch.
3608
3609 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3610
3611         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3612         (riscv_unwind_pc): Delete.
3613         (riscv_unwind_sp): Delete.
3614         (riscv_gdbarch_init): Don't register deleted functions with
3615         gdbarch.
3616
3617 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3618
3619         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3620         (csky_unwind_pc): Delete.
3621         (csky_unwind_sp): Delete.
3622         (csky_gdbarch_init): Don't register deleted functions with
3623         gdbarch.
3624
3625 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3626
3627         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3628         (cris_unwind_pc): Delete.
3629         (cris_unwind_sp): Delete.
3630         (cris_gdbarch_init): Don't register deleted functions with
3631         gdbarch.
3632
3633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3634
3635         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3636         (bfin_unwind_pc): Delete.
3637         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3638
3639 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3640
3641         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3642         (arm_unwind_pc): Delete.
3643         (arm_unwind_sp): Delete.
3644         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3645
3646 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3647
3648         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3649         (arc_unwind_pc): Delete.
3650         (arc_unwind_sp): Delete.
3651         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3652
3653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3654
3655         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3656         (alpha_unwind_pc): Delete.
3657         (alpha_gdbarch_init): Don't register deleted functions with
3658         gdbarch.
3659
3660 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3661
3662         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3663         (aarch64_unwind_pc): Delete.
3664         (aarch64_unwind_sp): Delete.
3665         (aarch64_gdbarch_init): Don't register deleted functions with
3666         gdbarch.
3667
3668 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * gdbtypes.c (type_align): Don't consider static members when
3671         computing structure alignment.
3672
3673 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3674
3675         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3676         return 0 for other types.
3677         * arch-utils.c (default_type_align): Always return 0.
3678         * gdbarch.h: Regenerate.
3679         * gdbarch.sh (type_align): Extend comment.
3680         * gdbtypes.c (type_align): Add additional comments, always call
3681         gdbarch_type_align before applying the default rules.
3682         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3683         generic code will then apply a suitable default.
3684         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3685         types, return 0 for other types.
3686
3687 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3688
3689         * NEWS: Create a new section for the next release branch.
3690         Rename the section of the current branch, now that it has
3691         been cut.
3692
3693 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3694
3695         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3696         * version.in: Bump version to 8.3.50.DATE-git.
3697
3698 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3699
3700         * aix-thread.c (ptid_cmp): Remove unused variable.
3701         (get_signaled_thread): Likewise.
3702         (store_regs_user_thread): Likewise.
3703         (store_regs_kernel_thread): Likewise.
3704         (fetch_regs_kernel_thread): Remove shadowed variable.
3705
3706 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3707
3708         * features/riscv/32bit-cpu.xml: Add register numbers.
3709         * features/riscv/32bit-fpu.c: Regenerate.
3710         * features/riscv/32bit-fpu.xml: Add register numbers.
3711         * features/riscv/64bit-cpu.xml: Add register numbers.
3712         * features/riscv/64bit-fpu.c: Regenerate.
3713         * features/riscv/64bit-fpu.xml: Add register numbers.
3714
3715 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3716
3717         * NEWS: Mention two argument form of gdb.Value constructor.
3718         * python/py-value.c (convert_buffer_and_type_to_value): New
3719         function.
3720         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3721         Add support for handling an optional second argument.  Call
3722         convert_buffer_and_type_to_value as appropriate.
3723         * python/python-internal.h (Py_buffer_deleter): New struct.
3724         (Py_buffer_up): New typedef.
3725
3726 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3727
3728         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3729         instead of releasing ownership.
3730
3731 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3732
3733         * dwarf2read.c (open_and_init_dwp_file): Call
3734         elf_numsections instead of bfd_count_sections to initialize
3735         dwp_file->num_sections.
3736
3737 2019-02-25  Tom Tromey  <tromey@adacore.com>
3738
3739         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3740
3741 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3742
3743         * gcore.in: Add '--readnever' option when invoking GDB.
3744
3745 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3746
3747         * MAINTAINERS: Update my email address.
3748
3749 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3750
3751         * build-id.c (build_id_to_debug_bfd_1): New function.
3752         (build_id_to_debug_bfd): Look for separate debug file in
3753         sysroot.
3754
3755 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3756
3757         * gdbarch.sh: Update the copyright year range that is placed into
3758         generated files.
3759
3760 2019-02-22  Keith Seitz  <keiths@redhat.com>
3761
3762         PR symtab/23853
3763         * linespec.c (create_sals_line_offset): Search for the default
3764         symtab's filename instead of its fullname.
3765
3766 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3767
3768         * NEWS: Update style defaults.
3769
3770 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3771
3772         * main.c (captured_main_1): Disable styling in batch mode.
3773
3774 2019-02-20  Tom Tromey  <tom@tromey.com>
3775
3776         * symtab.c (symtab_symbol_info): Fix typos.
3777
3778 2019-02-20  Tom Tromey  <tromey@adacore.com>
3779
3780         * findcmd.c (_initialize_mem_search): Use upper case for
3781         metasyntactic variables.
3782
3783 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3784
3785         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3786         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3787
3788 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3789
3790         * top.h (source_file_name): Change to std::string.
3791         * top.c (source_file_name): Likewise.
3792         (command_line_input): Adjust.
3793         * cli/cli-script.c (script_from_file): Adjust.
3794
3795 2019-02-19  Tom Tromey  <tromey@adacore.com>
3796
3797         * ravenscar-thread.c
3798         (ravenscar_thread_target::update_thread_list): Don't call
3799         ada_build_task_list.
3800         * ada-lang.h (ada_build_task_list): Don't declare.
3801         * ada-tasks.c (struct ada_tasks_inferior_data)
3802         <task_list_valid_p>: Now bool.
3803         (read_known_tasks, ada_task_list_changed)
3804         (ada_tasks_invalidate_inferior_data): Update.
3805         (read_known_tasks_array): Return bool.
3806         (read_known_tasks_list): Likewise.
3807         (read_known_tasks): Return void.
3808         (ada_build_task_list): Now static.
3809
3810 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3813         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3814
3815 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3816
3817         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3818         variant for ada_tasks_pspace_data_handle and
3819         ada_tasks_inferior_data_handle.
3820         (ada_tasks_pspace_data_cleanup): New function.
3821         (ada_tasks_inferior_data_cleanup): New function.
3822
3823 2019-02-17  Tom Tromey  <tom@tromey.com>
3824
3825         * macrotab.h (macro_source_fullname): Return a std::string.
3826         * macrotab.c (macro_include, check_for_redefinition)
3827         (macro_undef, macro_lookup_definition, foreach_macro)
3828         (foreach_macro_in_scope): Update.
3829         (macro_source_fullname): Return a std::string.
3830         * macrocmd.c (show_pp_source_pos): Update.
3831
3832 2019-02-17  Tom Tromey  <tom@tromey.com>
3833
3834         * macrocmd.c (show_pp_source_pos): Style the file names.
3835
3836 2019-02-17  Tom Tromey  <tom@tromey.com>
3837
3838         PR tui/24197:
3839         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3840
3841 2019-02-17  Tom Tromey  <tom@tromey.com>
3842
3843         * ada-lang.c (user_select_syms): Use filtered printing.
3844         * utils.c (wrap_style): New global.
3845         (desired_style): Remove.
3846         (emit_style_escape): Add stream parameter.
3847         (set_output_style, reset_terminal_style, prompt_for_continue):
3848         Update.
3849         (flush_wrap_buffer): Only flush gdb_stdout.
3850         (wrap_here): Set wrap_style.
3851         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3852         treat escape sequences as a character.  Change when wrap buffer is
3853         flushed.
3854         (fputs_styled): Do not set the output style when the default is
3855         requested.
3856         * ui-style.h (struct ui_file_style) <is_default>: New method.
3857         * source.c (print_source_lines_base): Emit escape sequences in one
3858         piece.
3859
3860 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3861
3862         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3863         integers and enumeration types.
3864
3865 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3866
3867         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3868         instead of lookup_symbol_in_language
3869         (do_exact_match): New function.
3870         (ada_get_symbol_name_matcher): Return do_exact_match when
3871         doing a verbatim match.
3872
3873 2019-02-15  Tom Tromey  <tromey@adacore.com>
3874
3875         * ravenscar-thread.c (ravenscar_thread_target::resume)
3876         (ravenscar_thread_target::wait): Special case wildcard requests.
3877
3878 2019-02-15  Tom Tromey  <tromey@adacore.com>
3879
3880         * ravenscar-thread.c (base_ptid): Remove.
3881         (struct ravenscar_thread_target) <close>: New method.
3882         <m_base_ptid>: New member.
3883         <update_inferior_ptid, active_task, task_is_currently_active,
3884         runtime_initialized>: Declare methods.
3885         <ravenscar_thread_target>: Add constructor.
3886         (ravenscar_thread_target::task_is_currently_active)
3887         (ravenscar_thread_target::update_inferior_ptid)
3888         (ravenscar_runtime_initialized): Rename.  Now methods.
3889         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3890         (ravenscar_thread_target::update_thread_list): Update.
3891         (ravenscar_thread_target::active_task): Now method.
3892         (ravenscar_thread_target::store_registers)
3893         (ravenscar_thread_target::prepare_to_store)
3894         (ravenscar_thread_target::prepare_to_store)
3895         (ravenscar_thread_target::mourn_inferior): Update.
3896         (ravenscar_inferior_created): Use "new" to create target.
3897         (ravenscar_thread_target::get_ada_task_ptid): Update.
3898         (_initialize_ravenscar): Don't initialize base_ptid.
3899         (ravenscar_ops): Remove global.
3900
3901 2019-02-15  Tom Tromey  <tromey@adacore.com>
3902
3903         * target.h (push_target): Declare new overload.
3904         * target.c (push_target): New overload, taking an rvalue reference.
3905         * remote.c (remote_target::open_1): Use push_target overload.
3906         * corelow.c (core_target_open): Use push_target overload.
3907
3908 2019-02-15  Tom Tromey  <tromey@adacore.com>
3909
3910         * ravenscar-thread.c (is_ravenscar_task)
3911         (ravenscar_task_is_currently_active): Return bool.
3912         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3913         (_initialize_ravenscar): Remove "(void)".
3914         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3915         Return bool.
3916
3917 2019-02-15  Tom Tromey  <tromey@adacore.com>
3918
3919         * ravenscar-thread.c (ravenscar_runtime_initializer)
3920         (has_ravenscar_runtime, get_running_thread_id)
3921         (ravenscar_thread_target::resume): Fix indentation.
3922
3923 2019-02-15  Tom Tromey  <tromey@adacore.com>
3924
3925         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3926         from ravenscar_arch_ops.
3927         (sparc_ravenscar_ops::fetch_registers)
3928         (sparc_ravenscar_ops::store_registers): Now methods.
3929         (sparc_ravenscar_prepare_to_store): Remove.
3930         (sparc_ravenscar_ops): Redefine.
3931         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3932         methods and destructor.  Remove members.
3933         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3934         (ravenscar_thread_target::store_registers)
3935         (ravenscar_thread_target::prepare_to_store): Update.
3936         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3937         Remove.
3938         (struct ppc_ravenscar_powerpc_ops): Derive from
3939         ravenscar_arch_ops.
3940         (ppc_ravenscar_powerpc_ops::fetch_registers)
3941         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3942         (ppc_ravenscar_powerpc_ops): Redefine.
3943         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3944         (ppc_ravenscar_e500_ops::fetch_registers)
3945         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3946         (ppc_ravenscar_e500_ops): Redefine.
3947         * aarch64-ravenscar-thread.c
3948         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3949         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3950         (aarch64_ravenscar_fetch_registers)
3951         (aarch64_ravenscar_store_registers): Now methods.
3952         (aarch64_ravenscar_ops): Redefine.
3953
3954 2019-02-15  Tom Tromey  <tromey@adacore.com>
3955
3956         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3957         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3958         (ravenscar_thread_target::stopped_by_watchpoint)
3959         (ravenscar_thread_target::stopped_data_address)
3960         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3961
3962 2019-02-15  Tom Tromey  <tromey@adacore.com>
3963
3964         * ravenscar-thread.c: Fix some typos.
3965
3966 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3967             Tom Tromey  <tromey@adacore.com>
3968
3969         * ada-lang.c (ada_exception_sal): Change addr_string to a
3970         std::string.
3971         (create_ada_exception_catchpoint): Update.
3972
3973 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3974             Tom Tromey  <tromey@adacore.com>
3975
3976         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3977         (bp_location_ops): Remove.
3978         (base_breakpoint_allocate_location): Update.
3979         (free_bp_location): Update.
3980         * ada-lang.c (class ada_catchpoint_location)
3981         <ada_catchpoint_location>: Remove ops parameter.
3982         (ada_catchpoint_location_dtor): Remove.
3983         (ada_catchpoint_location_ops): Remove.
3984         (allocate_location_exception): Update.
3985         * breakpoint.h (struct bp_location_ops): Remove.
3986         (class bp_location) <bp_location>: Remove bp_location_ops
3987         parameter.
3988         <~bp_location>: Add destructor.
3989         <ops>: Remove.
3990
3991 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3992             Pedro Alves  <palves@redhat.com>
3993
3994         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3995         'PATH_MAX'.
3996
3997 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3998             Samuel Thibault  <samuel.thibault@gnu.org>
3999             Thomas Schwinge  <thomas@codesourcery.com>
4000
4001         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4002         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4003
4004 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4005
4006         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4007         (check_empty): Use "const char *".
4008
4009         * gnu-nat.c (gnu_nat_target::detach): Instead of
4010         'detach_inferior (pid)' call
4011         'detach_inferior (find_inferior_pid (pid))'.
4012
4013         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4014         'nat/fork-inferior.o'.
4015         * gnu-nat.c: #include "nat/fork-inferior.h".
4016
4017         * gnu-nat.c (gnu_nat_target::detach): Instead of
4018         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4019         * gnu-nat.h: #include "inf-child.h".
4020         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4021         'i386_gnu_nat_target::fetch_registers'.
4022         (gnu_store_registers): Rename/move to
4023         'i386_gnu_nat_target::store_registers'.
4024
4025         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4026         * gnu-nat.h (mach_thread_info): New function.
4027         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4028
4029         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4030
4031 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4032
4033         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4034
4035 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4036
4037         * windows-nat.c (windows_add_thread): Add new parameter
4038         "main_thread_p" with default value set to false.  Update
4039         function documentation as well as all callers.
4040         (windows_delete_thread): Likewise.
4041         (fake_create_process): Update call to windows_add_thread.
4042         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4043         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4044         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4045         call to windows_delete_thread.
4046
4047 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4048
4049         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4050
4051 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4052
4053         * symfile.c (find_separate_debug_file): Use canonical path of
4054         sysroot with child_path instead of gdb_sysroot if it is valid.
4055
4056 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4057
4058         * symfile.c (find_separate_debug_file): Use child_path to
4059         determine if an object file is under a sysroot.
4060
4061 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4062
4063         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4064         unittests/child-path-selftests.c.
4065         * common/pathstuff.c (child_path): New function.
4066         * common/pathstuff.h (child_path): New prototype.
4067         * unittests/child-path-selftests.c: New file.
4068
4069 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4070
4071         * symfile.c (find_separate_debug_file): Look for separate debug
4072         files in debug directories under the sysroot.
4073
4074 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4075
4076         * symtab.h (struct minimal_symbol data_p): New const method.
4077         (struct minimal_symbol text_p): Likewise.
4078         * symtab.c (output_source_filename): Use file name style
4079         to print file name.
4080         (print_symbol_info): Likewise.
4081         (print_msymbol_info): Use address style to print addresses.
4082         Use function name style to print executable text symbols.
4083         (expand_symtab_containing_pc): Use data_p.
4084         (find_pc_sect_compunit_symtab): Likewise.
4085
4086 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4087
4088         * breakpoint.c (describe_other_breakpoints): Use address style
4089         to print addresses.
4090         (say_where): Likewise.
4091
4092 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4093
4094         * ada-typeprint.c (print_func_type): Print function name
4095         style to print function name.
4096         * c-typeprint.c (c_print_type_1): Likewise.
4097
4098 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4099
4100         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4101         for execve.
4102
4103 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4104
4105         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4106         type_stack.
4107
4108 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4109
4110         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4111         TYPE_CODE_REF types.
4112
4113 2019-02-08  Jim Wilson  <jimw@sifive.com>
4114
4115         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4116         (riscv_linux_fregset): New.
4117         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4118
4119 2019-02-07  Tom Tromey  <tom@tromey.com>
4120
4121         * thread.c (thread_cancel_execution_command): Update.
4122         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4123         methods.
4124         (struct thread_fsm_ops): Remove.
4125         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4126         (thread_fsm_should_stop, thread_fsm_return_value)
4127         (thread_fsm_set_finished, thread_fsm_finished_p)
4128         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4129         Don't declare.
4130         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4131         * infrun.c (clear_proceed_status_thread)
4132         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4133         (print_stop_event): Update.
4134         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4135         Add constructor.
4136         (step_command_fsm_ops): Remove.
4137         (new_step_command_fsm): Remove.
4138         (step_1): Update.
4139         (step_command_fsm::should_stop): Rename from
4140         step_command_fsm_should_stop.
4141         (step_command_fsm::clean_up): Rename from
4142         step_command_fsm_clean_up.
4143         (step_command_fsm::do_async_reply_reason): Rename from
4144         step_command_fsm_async_reply_reason.
4145         (struct until_next_fsm): Inherit from thread_fsm.  Add
4146         constructor.
4147         (until_next_fsm_ops): Remove.
4148         (new_until_next_fsm): Remove.
4149         (until_next_fsm::should_stop): Rename from
4150         until_next_fsm_should_stop.
4151         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4152         (until_next_fsm::do_async_reply_reason): Rename from
4153         until_next_fsm_async_reply_reason.
4154         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4155         constructor.  Change type of breakpoint.
4156         (finish_command_fsm_ops): Remove.
4157         (new_finish_command_fsm): Remove.
4158         (finish_command_fsm::should_stop): Rename from
4159         finish_command_fsm_should_stop.
4160         (finish_command_fsm::clean_up): Rename from
4161         finish_command_fsm_clean_up.
4162         (finish_command_fsm::return_value): Rename from
4163         finish_command_fsm_return_value.
4164         (finish_command_fsm::do_async_reply_reason): Rename from
4165         finish_command_fsm_async_reply_reason.
4166         (finish_command): Update.
4167         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4168         Add constructor.
4169         (call_thread_fsm_ops): Remove.
4170         (call_thread_fsm::call_thread_fsm): Rename from
4171         new_call_thread_fsm.
4172         (call_thread_fsm::should_stop): Rename from
4173         call_thread_fsm_should_stop.
4174         (call_thread_fsm::should_notify_stop): Rename from
4175         call_thread_fsm_should_notify_stop.
4176         (run_inferior_call, call_function_by_hand_dummy): Update.
4177         * cli/cli-interp.c (should_print_stop_to_console): Update.
4178         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4179         Add constructor.  Change type of location_breakpoint,
4180         caller_breakpoint.
4181         (until_break_fsm_ops): Remove.
4182         (new_until_break_fsm): Remove.
4183         (until_break_fsm::should_stop): Rename from
4184         until_break_fsm_should_stop.
4185         (until_break_fsm::clean_up): Rename from
4186         until_break_fsm_clean_up.
4187         (until_break_fsm::do_async_reply_reason): Rename from
4188         until_break_fsm_async_reply_reason.
4189         (until_break_command): Update.
4190         * thread-fsm.c: Remove.
4191         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4192
4193 2019-02-07  Tom Tromey  <tom@tromey.com>
4194
4195         * yy-remap.h: Add include guard.
4196         * xtensa-tdep.h: Add include guard.
4197         * xcoffread.h: Rename include guard.
4198         * varobj-iter.h: Add include guard.
4199         * tui/tui.h: Rename include guard.
4200         * tui/tui-winsource.h: Rename include guard.
4201         * tui/tui-wingeneral.h: Rename include guard.
4202         * tui/tui-windata.h: Rename include guard.
4203         * tui/tui-win.h: Rename include guard.
4204         * tui/tui-stack.h: Rename include guard.
4205         * tui/tui-source.h: Rename include guard.
4206         * tui/tui-regs.h: Rename include guard.
4207         * tui/tui-out.h: Rename include guard.
4208         * tui/tui-layout.h: Rename include guard.
4209         * tui/tui-io.h: Rename include guard.
4210         * tui/tui-hooks.h: Rename include guard.
4211         * tui/tui-file.h: Rename include guard.
4212         * tui/tui-disasm.h: Rename include guard.
4213         * tui/tui-data.h: Rename include guard.
4214         * tui/tui-command.h: Rename include guard.
4215         * tic6x-tdep.h: Add include guard.
4216         * target/waitstatus.h: Rename include guard.
4217         * target/wait.h: Rename include guard.
4218         * target/target.h: Rename include guard.
4219         * target/resume.h: Rename include guard.
4220         * target-float.h: Rename include guard.
4221         * stabsread.h: Add include guard.
4222         * rs6000-tdep.h: Add include guard.
4223         * riscv-fbsd-tdep.h: Add include guard.
4224         * regformats/regdef.h: Rename include guard.
4225         * record.h: Rename include guard.
4226         * python/python.h: Rename include guard.
4227         * python/python-internal.h: Rename include guard.
4228         * python/py-stopevent.h: Rename include guard.
4229         * python/py-ref.h: Rename include guard.
4230         * python/py-record.h: Rename include guard.
4231         * python/py-record-full.h: Rename include guard.
4232         * python/py-record-btrace.h: Rename include guard.
4233         * python/py-instruction.h: Rename include guard.
4234         * python/py-events.h: Rename include guard.
4235         * python/py-event.h: Rename include guard.
4236         * procfs.h: Add include guard.
4237         * proc-utils.h: Add include guard.
4238         * p-lang.h: Add include guard.
4239         * or1k-tdep.h: Rename include guard.
4240         * observable.h: Rename include guard.
4241         * nto-tdep.h: Rename include guard.
4242         * nat/x86-linux.h: Rename include guard.
4243         * nat/x86-linux-dregs.h: Rename include guard.
4244         * nat/x86-gcc-cpuid.h: Add include guard.
4245         * nat/x86-dregs.h: Rename include guard.
4246         * nat/x86-cpuid.h: Rename include guard.
4247         * nat/ppc-linux.h: Rename include guard.
4248         * nat/mips-linux-watch.h: Rename include guard.
4249         * nat/linux-waitpid.h: Rename include guard.
4250         * nat/linux-ptrace.h: Rename include guard.
4251         * nat/linux-procfs.h: Rename include guard.
4252         * nat/linux-osdata.h: Rename include guard.
4253         * nat/linux-nat.h: Rename include guard.
4254         * nat/linux-namespaces.h: Rename include guard.
4255         * nat/linux-btrace.h: Rename include guard.
4256         * nat/glibc_thread_db.h: Rename include guard.
4257         * nat/gdb_thread_db.h: Rename include guard.
4258         * nat/gdb_ptrace.h: Rename include guard.
4259         * nat/fork-inferior.h: Rename include guard.
4260         * nat/amd64-linux-siginfo.h: Rename include guard.
4261         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4262         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4263         * nat/aarch64-linux.h: Rename include guard.
4264         * nat/aarch64-linux-hw-point.h: Rename include guard.
4265         * mn10300-tdep.h: Add include guard.
4266         * mips-linux-tdep.h: Add include guard.
4267         * mi/mi-parse.h: Rename include guard.
4268         * mi/mi-out.h: Rename include guard.
4269         * mi/mi-main.h: Rename include guard.
4270         * mi/mi-interp.h: Rename include guard.
4271         * mi/mi-getopt.h: Rename include guard.
4272         * mi/mi-console.h: Rename include guard.
4273         * mi/mi-common.h: Rename include guard.
4274         * mi/mi-cmds.h: Rename include guard.
4275         * mi/mi-cmd-break.h: Rename include guard.
4276         * m2-lang.h: Add include guard.
4277         * location.h: Rename include guard.
4278         * linux-record.h: Rename include guard.
4279         * linux-nat.h: Add include guard.
4280         * linux-fork.h: Add include guard.
4281         * i386-darwin-tdep.h: Rename include guard.
4282         * hppa-linux-offsets.h: Add include guard.
4283         * guile/guile.h: Rename include guard.
4284         * guile/guile-internal.h: Rename include guard.
4285         * gnu-nat.h: Rename include guard.
4286         * gdb-stabs.h: Rename include guard.
4287         * frv-tdep.h: Add include guard.
4288         * f-lang.h: Add include guard.
4289         * event-loop.h: Add include guard.
4290         * darwin-nat.h: Rename include guard.
4291         * cp-abi.h: Rename include guard.
4292         * config/sparc/nm-sol2.h: Rename include guard.
4293         * config/nm-nto.h: Rename include guard.
4294         * config/nm-linux.h: Add include guard.
4295         * config/i386/nm-i386gnu.h: Rename include guard.
4296         * config/djgpp/nl_types.h: Rename include guard.
4297         * config/djgpp/langinfo.h: Rename include guard.
4298         * compile/gcc-cp-plugin.h: Add include guard.
4299         * compile/gcc-c-plugin.h: Add include guard.
4300         * compile/compile.h: Rename include guard.
4301         * compile/compile-object-run.h: Rename include guard.
4302         * compile/compile-object-load.h: Rename include guard.
4303         * compile/compile-internal.h: Rename include guard.
4304         * compile/compile-cplus.h: Rename include guard.
4305         * compile/compile-c.h: Rename include guard.
4306         * common/xml-utils.h: Rename include guard.
4307         * common/x86-xstate.h: Rename include guard.
4308         * common/version.h: Rename include guard.
4309         * common/vec.h: Rename include guard.
4310         * common/tdesc.h: Rename include guard.
4311         * common/selftest.h: Rename include guard.
4312         * common/scoped_restore.h: Rename include guard.
4313         * common/scoped_mmap.h: Rename include guard.
4314         * common/scoped_fd.h: Rename include guard.
4315         * common/safe-iterator.h: Rename include guard.
4316         * common/run-time-clock.h: Rename include guard.
4317         * common/refcounted-object.h: Rename include guard.
4318         * common/queue.h: Rename include guard.
4319         * common/ptid.h: Rename include guard.
4320         * common/print-utils.h: Rename include guard.
4321         * common/preprocessor.h: Rename include guard.
4322         * common/pathstuff.h: Rename include guard.
4323         * common/observable.h: Rename include guard.
4324         * common/netstuff.h: Rename include guard.
4325         * common/job-control.h: Rename include guard.
4326         * common/host-defs.h: Rename include guard.
4327         * common/gdb_wait.h: Rename include guard.
4328         * common/gdb_vecs.h: Rename include guard.
4329         * common/gdb_unlinker.h: Rename include guard.
4330         * common/gdb_unique_ptr.h: Rename include guard.
4331         * common/gdb_tilde_expand.h: Rename include guard.
4332         * common/gdb_sys_time.h: Rename include guard.
4333         * common/gdb_string_view.h: Rename include guard.
4334         * common/gdb_splay_tree.h: Rename include guard.
4335         * common/gdb_setjmp.h: Rename include guard.
4336         * common/gdb_ref_ptr.h: Rename include guard.
4337         * common/gdb_optional.h: Rename include guard.
4338         * common/gdb_locale.h: Rename include guard.
4339         * common/gdb_assert.h: Rename include guard.
4340         * common/filtered-iterator.h: Rename include guard.
4341         * common/filestuff.h: Rename include guard.
4342         * common/fileio.h: Rename include guard.
4343         * common/environ.h: Rename include guard.
4344         * common/common-utils.h: Rename include guard.
4345         * common/common-types.h: Rename include guard.
4346         * common/common-regcache.h: Rename include guard.
4347         * common/common-inferior.h: Rename include guard.
4348         * common/common-gdbthread.h: Rename include guard.
4349         * common/common-exceptions.h: Rename include guard.
4350         * common/common-defs.h: Rename include guard.
4351         * common/common-debug.h: Rename include guard.
4352         * common/cleanups.h: Rename include guard.
4353         * common/buffer.h: Rename include guard.
4354         * common/btrace-common.h: Rename include guard.
4355         * common/break-common.h: Rename include guard.
4356         * cli/cli-utils.h: Rename include guard.
4357         * cli/cli-style.h: Rename include guard.
4358         * cli/cli-setshow.h: Rename include guard.
4359         * cli/cli-script.h: Rename include guard.
4360         * cli/cli-interp.h: Rename include guard.
4361         * cli/cli-decode.h: Rename include guard.
4362         * cli/cli-cmds.h: Rename include guard.
4363         * charset-list.h: Add include guard.
4364         * buildsym-legacy.h: Rename include guard.
4365         * bfin-tdep.h: Add include guard.
4366         * ax.h: Rename include guard.
4367         * arm-linux-tdep.h: Add include guard.
4368         * arm-fbsd-tdep.h: Add include guard.
4369         * arch/xtensa.h: Rename include guard.
4370         * arch/tic6x.h: Add include guard.
4371         * arch/i386.h: Add include guard.
4372         * arch/arm.h: Rename include guard.
4373         * arch/arm-linux.h: Rename include guard.
4374         * arch/arm-get-next-pcs.h: Rename include guard.
4375         * arch/amd64.h: Add include guard.
4376         * arch/aarch64-insn.h: Rename include guard.
4377         * arch-utils.h: Rename include guard.
4378         * annotate.h: Add include guard.
4379         * amd64-darwin-tdep.h: Rename include guard.
4380         * aarch64-linux-tdep.h: Add include guard.
4381         * aarch64-fbsd-tdep.h: Add include guard.
4382         * aarch32-linux-nat.h: Add include guard.
4383
4384 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4385
4386         * macrotab.c (macro_define_internal): New function that
4387         factorizes macro_define_object_internal and macro_define_function
4388         code.
4389         (macro_define_object_internal): Use macro_define_internal.
4390         (macro_define_function): Likewise.
4391
4392 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4393
4394         * macrocmd.c (extract_identifier): Return
4395         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4396         callers.
4397
4398 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4399
4400         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4401
4402 2019-02-05  Tom Tromey  <tom@tromey.com>
4403
4404         * target.c (target_stack::unpush): Move assertion earlier.
4405
4406 2019-01-30  Tom Tromey  <tom@tromey.com>
4407
4408         PR python/23615:
4409         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4410         (gdbpy_parse_and_eval): Likewise.
4411         * python/python-internal.h (gdbpy_allow_threads): New class.
4412
4413 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4414
4415         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4416         (aarch64_fbsd_fpregmap): Move earlier.
4417         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4418         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4419         instead of individual calls to trad_frame_set_reg_addr.
4420         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4421         earlier.
4422         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4423         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4424         instead of individual calls to trad_frame_set_reg_addr.
4425
4426 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4427
4428         * CONTRIBUTE: Replace contribution list with wiki link.
4429
4430 2019-01-25  Tom Tromey  <tom@tromey.com>
4431
4432         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4433
4434 2019-01-25  Tom Tromey  <tom@tromey.com>
4435
4436         * xtensa-linux-nat.c: Fix common/ includes.
4437         * xml-support.h: Fix common/ includes.
4438         * xml-support.c: Fix common/ includes.
4439         * x86-linux-nat.c: Fix common/ includes.
4440         * windows-nat.c: Fix common/ includes.
4441         * varobj.h: Fix common/ includes.
4442         * varobj.c: Fix common/ includes.
4443         * value.c: Fix common/ includes.
4444         * valops.c: Fix common/ includes.
4445         * utils.c: Fix common/ includes.
4446         * unittests/xml-utils-selftests.c: Fix common/ includes.
4447         * unittests/utils-selftests.c: Fix common/ includes.
4448         * unittests/unpack-selftests.c: Fix common/ includes.
4449         * unittests/tracepoint-selftests.c: Fix common/ includes.
4450         * unittests/style-selftests.c: Fix common/ includes.
4451         * unittests/string_view-selftests.c: Fix common/ includes.
4452         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4453         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4454         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4455         * unittests/rsp-low-selftests.c: Fix common/ includes.
4456         * unittests/parse-connection-spec-selftests.c: Fix common/
4457         includes.
4458         * unittests/optional-selftests.c: Fix common/ includes.
4459         * unittests/offset-type-selftests.c: Fix common/ includes.
4460         * unittests/observable-selftests.c: Fix common/ includes.
4461         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4462         * unittests/memrange-selftests.c: Fix common/ includes.
4463         * unittests/memory-map-selftests.c: Fix common/ includes.
4464         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4465         * unittests/function-view-selftests.c: Fix common/ includes.
4466         * unittests/environ-selftests.c: Fix common/ includes.
4467         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4468         * unittests/common-utils-selftests.c: Fix common/ includes.
4469         * unittests/cli-utils-selftests.c: Fix common/ includes.
4470         * unittests/array-view-selftests.c: Fix common/ includes.
4471         * ui-file.c: Fix common/ includes.
4472         * tui/tui-io.c: Fix common/ includes.
4473         * tracepoint.h: Fix common/ includes.
4474         * tracepoint.c: Fix common/ includes.
4475         * tracefile-tfile.c: Fix common/ includes.
4476         * top.h: Fix common/ includes.
4477         * top.c: Fix common/ includes.
4478         * thread.c: Fix common/ includes.
4479         * target/waitstatus.h: Fix common/ includes.
4480         * target/waitstatus.c: Fix common/ includes.
4481         * target.h: Fix common/ includes.
4482         * target.c: Fix common/ includes.
4483         * target-memory.c: Fix common/ includes.
4484         * target-descriptions.c: Fix common/ includes.
4485         * symtab.h: Fix common/ includes.
4486         * symfile.c: Fix common/ includes.
4487         * stap-probe.c: Fix common/ includes.
4488         * spu-linux-nat.c: Fix common/ includes.
4489         * sparc-nat.c: Fix common/ includes.
4490         * source.c: Fix common/ includes.
4491         * solib.c: Fix common/ includes.
4492         * solib-target.c: Fix common/ includes.
4493         * ser-unix.c: Fix common/ includes.
4494         * ser-tcp.c: Fix common/ includes.
4495         * ser-pipe.c: Fix common/ includes.
4496         * ser-base.c: Fix common/ includes.
4497         * selftest-arch.c: Fix common/ includes.
4498         * s12z-tdep.c: Fix common/ includes.
4499         * rust-exp.y: Fix common/ includes.
4500         * rs6000-aix-tdep.c: Fix common/ includes.
4501         * riscv-tdep.c: Fix common/ includes.
4502         * remote.c: Fix common/ includes.
4503         * remote-notif.h: Fix common/ includes.
4504         * remote-fileio.h: Fix common/ includes.
4505         * remote-fileio.c: Fix common/ includes.
4506         * regcache.h: Fix common/ includes.
4507         * regcache.c: Fix common/ includes.
4508         * record-btrace.c: Fix common/ includes.
4509         * python/python.c: Fix common/ includes.
4510         * python/py-type.c: Fix common/ includes.
4511         * python/py-inferior.c: Fix common/ includes.
4512         * progspace.h: Fix common/ includes.
4513         * producer.c: Fix common/ includes.
4514         * procfs.c: Fix common/ includes.
4515         * proc-api.c: Fix common/ includes.
4516         * printcmd.c: Fix common/ includes.
4517         * ppc-linux-nat.c: Fix common/ includes.
4518         * parser-defs.h: Fix common/ includes.
4519         * osdata.c: Fix common/ includes.
4520         * obsd-nat.c: Fix common/ includes.
4521         * nat/x86-linux.c: Fix common/ includes.
4522         * nat/x86-linux-dregs.c: Fix common/ includes.
4523         * nat/x86-dregs.h: Fix common/ includes.
4524         * nat/x86-dregs.c: Fix common/ includes.
4525         * nat/ppc-linux.c: Fix common/ includes.
4526         * nat/mips-linux-watch.h: Fix common/ includes.
4527         * nat/mips-linux-watch.c: Fix common/ includes.
4528         * nat/linux-waitpid.c: Fix common/ includes.
4529         * nat/linux-ptrace.h: Fix common/ includes.
4530         * nat/linux-ptrace.c: Fix common/ includes.
4531         * nat/linux-procfs.c: Fix common/ includes.
4532         * nat/linux-personality.c: Fix common/ includes.
4533         * nat/linux-osdata.c: Fix common/ includes.
4534         * nat/linux-namespaces.c: Fix common/ includes.
4535         * nat/linux-btrace.h: Fix common/ includes.
4536         * nat/linux-btrace.c: Fix common/ includes.
4537         * nat/fork-inferior.c: Fix common/ includes.
4538         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4539         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4540         * nat/aarch64-linux.c: Fix common/ includes.
4541         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4542         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4543         * namespace.h: Fix common/ includes.
4544         * mips-linux-tdep.c: Fix common/ includes.
4545         * minsyms.c: Fix common/ includes.
4546         * mi/mi-parse.h: Fix common/ includes.
4547         * mi/mi-main.c: Fix common/ includes.
4548         * mi/mi-cmd-env.c: Fix common/ includes.
4549         * memrange.h: Fix common/ includes.
4550         * memattr.c: Fix common/ includes.
4551         * maint.h: Fix common/ includes.
4552         * maint.c: Fix common/ includes.
4553         * main.c: Fix common/ includes.
4554         * machoread.c: Fix common/ includes.
4555         * location.c: Fix common/ includes.
4556         * linux-thread-db.c: Fix common/ includes.
4557         * linux-nat.c: Fix common/ includes.
4558         * linux-fork.c: Fix common/ includes.
4559         * inline-frame.c: Fix common/ includes.
4560         * infrun.c: Fix common/ includes.
4561         * inflow.c: Fix common/ includes.
4562         * inferior.h: Fix common/ includes.
4563         * inferior.c: Fix common/ includes.
4564         * infcmd.c: Fix common/ includes.
4565         * inf-ptrace.c: Fix common/ includes.
4566         * inf-child.c: Fix common/ includes.
4567         * ia64-linux-nat.c: Fix common/ includes.
4568         * i387-tdep.c: Fix common/ includes.
4569         * i386-tdep.c: Fix common/ includes.
4570         * i386-linux-tdep.c: Fix common/ includes.
4571         * i386-linux-nat.c: Fix common/ includes.
4572         * i386-go32-tdep.c: Fix common/ includes.
4573         * i386-fbsd-tdep.c: Fix common/ includes.
4574         * i386-fbsd-nat.c: Fix common/ includes.
4575         * guile/scm-type.c: Fix common/ includes.
4576         * guile/guile.c: Fix common/ includes.
4577         * go32-nat.c: Fix common/ includes.
4578         * gnu-nat.c: Fix common/ includes.
4579         * gdbthread.h: Fix common/ includes.
4580         * gdbarch-selftests.c: Fix common/ includes.
4581         * gdb_usleep.c: Fix common/ includes.
4582         * gdb_select.h: Fix common/ includes.
4583         * gdb_bfd.c: Fix common/ includes.
4584         * gcore.c: Fix common/ includes.
4585         * fork-child.c: Fix common/ includes.
4586         * findvar.c: Fix common/ includes.
4587         * fbsd-nat.c: Fix common/ includes.
4588         * event-top.c: Fix common/ includes.
4589         * event-loop.c: Fix common/ includes.
4590         * dwarf2read.c: Fix common/ includes.
4591         * dwarf2loc.c: Fix common/ includes.
4592         * dwarf2-frame.c: Fix common/ includes.
4593         * dwarf-index-cache.c: Fix common/ includes.
4594         * dtrace-probe.c: Fix common/ includes.
4595         * disasm-selftests.c: Fix common/ includes.
4596         * defs.h: Fix common/ includes.
4597         * csky-tdep.c: Fix common/ includes.
4598         * cp-valprint.c: Fix common/ includes.
4599         * cp-support.h: Fix common/ includes.
4600         * cp-support.c: Fix common/ includes.
4601         * corelow.c: Fix common/ includes.
4602         * completer.h: Fix common/ includes.
4603         * completer.c: Fix common/ includes.
4604         * compile/compile.c: Fix common/ includes.
4605         * compile/compile-loc2c.c: Fix common/ includes.
4606         * compile/compile-cplus-types.c: Fix common/ includes.
4607         * compile/compile-cplus-symbols.c: Fix common/ includes.
4608         * command.h: Fix common/ includes.
4609         * cli/cli-dump.c: Fix common/ includes.
4610         * cli/cli-cmds.c: Fix common/ includes.
4611         * charset.c: Fix common/ includes.
4612         * build-id.c: Fix common/ includes.
4613         * btrace.h: Fix common/ includes.
4614         * btrace.c: Fix common/ includes.
4615         * breakpoint.h: Fix common/ includes.
4616         * breakpoint.c: Fix common/ includes.
4617         * ax.h:
4618         (enum agent_op): Fix common/ includes.
4619         * ax-general.c (struct aop_map): Fix common/ includes.
4620         * ax-gdb.c: Fix common/ includes.
4621         * auxv.c: Fix common/ includes.
4622         * auto-load.c: Fix common/ includes.
4623         * arm-tdep.c: Fix common/ includes.
4624         * arch/riscv.c: Fix common/ includes.
4625         * arch/ppc-linux-common.c: Fix common/ includes.
4626         * arch/i386.c: Fix common/ includes.
4627         * arch/arm.c: Fix common/ includes.
4628         * arch/arm-linux.c: Fix common/ includes.
4629         * arch/arm-get-next-pcs.c: Fix common/ includes.
4630         * arch/amd64.c: Fix common/ includes.
4631         * arch/aarch64.c: Fix common/ includes.
4632         * arch/aarch64-insn.c: Fix common/ includes.
4633         * arch-utils.c: Fix common/ includes.
4634         * amd64-windows-tdep.c: Fix common/ includes.
4635         * amd64-tdep.c: Fix common/ includes.
4636         * amd64-sol2-tdep.c: Fix common/ includes.
4637         * amd64-obsd-tdep.c: Fix common/ includes.
4638         * amd64-nbsd-tdep.c: Fix common/ includes.
4639         * amd64-linux-tdep.c: Fix common/ includes.
4640         * amd64-linux-nat.c: Fix common/ includes.
4641         * amd64-fbsd-tdep.c: Fix common/ includes.
4642         * amd64-fbsd-nat.c: Fix common/ includes.
4643         * amd64-dicos-tdep.c: Fix common/ includes.
4644         * amd64-darwin-tdep.c: Fix common/ includes.
4645         * agent.c: Fix common/ includes.
4646         * ada-lang.h: Fix common/ includes.
4647         * ada-lang.c: Fix common/ includes.
4648         * aarch64-tdep.c: Fix common/ includes.
4649
4650 2019-01-25  Tom Tromey  <tom@tromey.com>
4651
4652         * common/create-version.sh: Use common/version.h.
4653
4654 2019-01-24  Pedro Alves  <palves@redhat.com>
4655
4656         * infrun.c (signal_stop, signal_print, signal_program)
4657         (signal_catch, signal_pass): Now arrays instead of pointers.
4658         (update_signals_program_target, do_target_resume)
4659         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4660         * linux-nat.c (linux_nat_target::pass_signals)
4661         (linux_nat_target::create_inferior, linux_nat_target::attach):
4662         Adjust.
4663         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4664         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4665         * procfs.c (procfs_target::pass_signals): Adjust.
4666         * record-full.c (record_full_target::resume): Adjust.
4667         * remote.c (remote_target::pass_signals)
4668         (remote_target::program_signals): Adjust.
4669         * target-debug.h (target_debug_print_signals): Now takes a
4670         gdb::array_view as parameter.  Adjust.
4671         * target.h (target_ops) <pass_signals, program_signals>: Replace
4672         pointer and length parameters with gdb::array_view.
4673         (target_pass_signals, target_program_signals): Likewise.
4674         * target-delegates.c: Regenerate.
4675
4676 2019-01-24  Pedro Alves  <palves@redhat.com>
4677
4678         * common/forward-scope-exit.h
4679         (forward_scope_exit::forward_scope_exit): Pass arguments to
4680         m_bind_function directly, instead of creating a std::bind and
4681         copying that.
4682
4683 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4684
4685         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4686         for static members.
4687         (pass_in_v_vfp_candidate): Likewise.
4688
4689 2019-01-23  Tom Tromey  <tom@tromey.com>
4690             Pedro Alves  <palves@redhat.com>
4691
4692         * regcache.c (class regcache_invalidator): Remove.
4693         (regcache::raw_write): Use make_scope_exit.
4694
4695 2019-01-23  Tom Tromey  <tom@tromey.com>
4696
4697         * ui-out.h (class ui_out_emit_type): Update comment.
4698
4699 2019-01-23  Tom Tromey  <tom@tromey.com>
4700
4701         * infrun.c (fetch_inferior_event): Update comment.
4702
4703 2019-01-23  Tom Tromey  <tom@tromey.com>
4704             Pedro Alves  <palves@redhat.com>
4705
4706         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4707         parameter.
4708         (fetch_inferior_event): Use SCOPE_EXIT.
4709
4710
4711 2019-01-23  Tom Tromey  <tom@tromey.com>
4712             Pedro Alves  <palves@redhat.com>
4713
4714         * infrun.c (disable_thread_events): Delete.
4715         (stop_all_threads): Use SCOPE_EXIT.
4716
4717 2019-01-23  Tom Tromey  <tom@tromey.com>
4718             Pedro Alves  <palves@redhat.com>
4719
4720         * symfile.c: Include forward-scope-exit.h.
4721         (clear_symtab_users_cleanup): Replace forward declaration with
4722         a FORWARD_SCOPE_EXIT.
4723         (syms_from_objfile_1): Use the forward_scope_exit and
4724         gdb::optional instead of cleanup_function.
4725         (reread_symbols): Use the forward_scope_exit instead of
4726         cleanup_function.
4727         (clear_symtab_users_cleanup): Remove function.
4728
4729 2019-01-23  Tom Tromey  <tom@tromey.com>
4730             Pedro Alves  <palves@redhat.com>
4731
4732         * linux-nat.c: Include scope-exit.h.
4733         (cleanup_target_stop): Remove.
4734         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4735         SCOPE_EXIT.
4736
4737 2019-01-23  Tom Tromey  <tom@tromey.com>
4738             Pedro Alves  <palves@redhat.com>
4739
4740         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4741         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4742
4743 2019-01-23  Tom Tromey  <tom@tromey.com>
4744             Andrew Burgess  <andrew.burgess@embecosm.com>
4745             Pedro Alves  <palves@redhat.com>
4746
4747         * infrun.c (fetch_inferior_event): Use scope_exit.
4748         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4749         * top.c (execute_command): Use scope_exit.
4750         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4751         * utils.c (do_bpstat_clear_actions_cleanup)
4752         (make_bpstat_clear_actions_cleanup): Remove.
4753
4754 2019-01-23  Tom Tromey  <tom@tromey.com>
4755             Pedro Alves  <palves@redhat.com>
4756
4757         * infrun.c: Include "common/scope-exit.h"
4758         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4759         (wait_for_inferior): Use SCOPE_EXIT.
4760         (fetch_inferior_event): Use scope_exit.
4761
4762 2019-01-23  Tom Tromey  <tom@tromey.com>
4763             Pedro Alves  <palves@redhat.com>
4764
4765         * breakpoint.c (create_breakpoint): Remove cleanup.
4766
4767 2019-01-23  Tom Tromey  <tom@tromey.com>
4768             Andrew Burgess  <andrew.burgess@embecosm.com>
4769             Pedro Alves  <palves@redhat.com>
4770
4771 2019-01-23  Pedro Alves  <palves@redhat.com>
4772
4773         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4774
4775 2019-01-23  Pedro Alves  <palves@redhat.com>
4776             Andrew Burgess  <andrew.burgess@embecosm.com>
4777
4778         * gdbthread.h: Include "common/forward-scope-exit.h".
4779         (scoped_finish_thread_state): Redefine custom class in terms of
4780         forward_scope_exit.
4781
4782 2019-01-23  Pedro Alves  <palves@redhat.com>
4783             Andrew Burgess  <andrew.burgess@embecosm.com>
4784
4785         * common/forward-scope-exit.h: New file.
4786
4787 2019-01-23  Pedro Alves  <palves@redhat.com>
4788             Andrew Burgess  <andrew.burgess@embecosm.com>
4789             Tom Tromey  <tom@tromey.com>
4790
4791         * common/scope-exit.h: New file.
4792
4793 2019-01-23  Pedro Alves  <palves@redhat.com>
4794
4795         * common/preprocessor.h (ESC): Rename to ...
4796         (ESC_PARENS): ... this.
4797         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4798         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4799
4800 2019-01-23  Tom Tromey  <tom@tromey.com>
4801
4802         * language.h (class scoped_switch_to_sym_language_if_auto):
4803         Initialize m_lang in both cases.
4804
4805 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4806
4807         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4808         with XCNEW.
4809
4810 2019-01-22  Tom Tromey  <tom@tromey.com>
4811
4812         * corelow.c: Do not include sys/file.h.
4813
4814 2019-01-22  Tom Tromey  <tom@tromey.com>
4815
4816         * tui/tui-wingeneral.h: Include gdb_curses.h.
4817
4818 2019-01-22  Tom Tromey  <tom@tromey.com>
4819
4820         * source-cache.h (class source_cache) <get_source_lines,
4821         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4822
4823 2019-01-22  Tom Tromey  <tom@tromey.com>
4824
4825         * remote-fileio.h (struct remote_target): Declare.
4826
4827 2019-01-22  Tom Tromey  <tom@tromey.com>
4828
4829         * python/py-arch.c: Do not include py-ref.h.
4830         * python/py-bpevent.c: Do not include py-ref.h.
4831         * python/py-cmd.c: Do not include py-ref.h.
4832         * python/py-continueevent.c: Do not include py-ref.h.
4833         * python/py-event.h: Do not include py-ref.h.
4834         * python/py-evtregistry.c: Do not include py-ref.h.
4835         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4836         * python/py-frame.c: Do not include py-ref.h.
4837         * python/py-framefilter.c: Do not include py-ref.h.
4838         * python/py-function.c: Do not include py-ref.h.
4839         * python/py-infevents.c: Do not include py-ref.h.
4840         * python/py-linetable.c: Do not include py-ref.h.
4841         * python/py-objfile.c: Do not include py-ref.h.
4842         * python/py-param.c: Do not include py-ref.h.
4843         * python/py-prettyprint.c: Do not include py-ref.h.
4844         * python/py-progspace.c: Do not include py-ref.h.
4845         * python/py-symbol.c: Do not include py-ref.h.
4846         * python/py-symtab.c: Do not include py-ref.h.
4847         * python/py-type.c: Do not include py-ref.h.
4848         * python/py-unwind.c: Do not include py-ref.h.
4849         * python/py-utils.c: Do not include py-ref.h.
4850         * python/py-value.c: Do not include py-ref.h.
4851         * python/py-varobj.c: Do not include py-ref.h.
4852         * python/py-xmethods.c: Do not include py-ref.h.
4853         * python/python.c: Do not include py-ref.h.
4854         * varobj.c: Do not include py-ref.h.
4855
4856 2019-01-22  Tom Tromey  <tom@tromey.com>
4857
4858         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4859         keyword for bcache.
4860
4861 2019-01-22  Tom Tromey  <tom@tromey.com>
4862
4863         * compile/compile-cplus-types.c: Remove a comment by #include.
4864
4865 2019-01-22  Tom Tromey  <tom@tromey.com>
4866
4867         * compile/gcc-c-plugin.h: Include compile-internal.h.
4868
4869 2019-01-22  Tom Tromey  <tom@tromey.com>
4870
4871         * stabsread.c (EXTERN): Do not define.
4872         (symnum, next_symbol_text_func, processing_gcc_compilation)
4873         (within_function, global_sym_chain, global_stabs)
4874         (previous_stab_code, this_object_header_files)
4875         (n_this_object_header_files)
4876         (n_allocated_this_object_header_files): Define.
4877         * stabsread.h (EXTERN): Never define.  Use "extern".
4878
4879 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4880
4881         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4882         history_value.
4883
4884 2019-01-21  Tom Tromey  <tom@tromey.com>
4885
4886         * ui-out.c: Fix includes.
4887         * tui/tui-source.c: Fix includes.
4888         * target.c: Fix includes.
4889         * remote.c: Fix includes.
4890         * regcache.c: Fix includes.
4891         * python/py-block.c: Fix includes.
4892         * printcmd.c: Fix includes.
4893         * or1k-tdep.c: Fix includes.
4894         * mi/mi-main.c: Fix includes.
4895         * m32r-tdep.c: Fix includes.
4896         * csky-tdep.c: Fix includes.
4897         * compile/compile-cplus-types.c: Fix includes.
4898         * cli/cli-interp.c: Fix includes.
4899
4900 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4901
4902         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4903         for padding.
4904
4905 2019-01-16  Tom Tromey  <tom@tromey.com>
4906
4907         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4908         earlier.
4909         (struct objfile) <msymbols_range>: Move from top level.
4910         <msymbols>: New method.
4911         (class objfile_msymbols): Remove.
4912         * symtab.c (default_collect_symbol_completion_matches_break_on):
4913         Update.
4914         * symmisc.c (dump_msymbols): Update.
4915         * stabsread.c (scan_file_globals): Update.
4916         * objc-lang.c (info_selectors_command, info_classes_command)
4917         (find_methods): Update.
4918         * minsyms.c (find_solib_trampoline_target): Update.
4919         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4920         * coffread.c (coff_symfile_read): Update.
4921         * ada-lang.c (ada_lookup_simple_minsym)
4922         (ada_collect_symbol_completion_matches): Update.
4923
4924 2019-01-16  Tom Tromey  <tom@tromey.com>
4925
4926         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4927         type.  Remove no-argument constructor.
4928         <iterator::operator++>: Simplify.
4929         <begin>: Update.
4930         <end>: Use minimal_symbol_count.
4931
4932 2019-01-16  Tom Tromey  <tom@tromey.com>
4933
4934         * objfiles.h (struct objfile) <psymtabs>: New method.
4935         (class objfile_psymtabs): Remove.
4936         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4937         typedef.
4938         <range>: New method.
4939         (require_partial_symbols): Change return type.
4940         * psymtab.c (require_partial_symbols)
4941         (psym_expand_symtabs_matching): Update.
4942         * mdebugread.c (parse_partial_symbols): Update.
4943         * dbxread.c (dbx_end_psymtab): Update.
4944
4945 2019-01-15  Tom Tromey  <tom@tromey.com>
4946
4947         * symtab.c (lookup_objfile_from_block)
4948         (lookup_symbol_in_objfile_symtabs)
4949         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4950         (find_line_symtab, info_sources_command)
4951         (default_collect_symbol_completion_matches_break_on)
4952         (make_source_files_completion_list): Update.
4953         * symmisc.c (print_objfile_statistics, dump_objfile)
4954         (maintenance_print_symbols, maintenance_info_symtabs)
4955         (maintenance_check_symtabs, maintenance_info_line_tables):
4956         Update.
4957         * source.c (select_source_symtab)
4958         (forget_cached_source_info_for_objfile): Update.
4959         * objfiles.h (class objfile_compunits): Remove.
4960         (struct objfile) <compunits_range>: New typedef.
4961         (compunits): New method.
4962         * objfiles.c (objfile_relocate1): Update.
4963         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4964         * maint.c (count_symtabs_and_blocks): Update.
4965         * linespec.c (iterate_over_all_matching_symtabs): Update.
4966         * cp-support.c (add_symbol_overload_list_qualified): Update.
4967         * coffread.c (coff_symtab_read): Update.
4968         * ada-lang.c (add_nonlocal_symbols)
4969         (ada_collect_symbol_completion_matches)
4970         (ada_add_global_exceptions): Update.
4971
4972 2019-01-15  Tom Tromey  <tom@tromey.com>
4973
4974         * progspace.h (program_space) <objfiles_safe_range>: New
4975         typedef.
4976         <objfiles_safe>: New method.
4977         * objfiles.h (class all_objfiles_safe): Remove.
4978         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4979         * jit.c (jit_inferior_exit_hook): Update.
4980
4981 2019-01-17  Tom Tromey  <tom@tromey.com>
4982
4983         * progspace.h (program_space) <objfiles_range>: New typedef.
4984         <objfiles>: New method.
4985         <objfiles_head>: Rename from objfiles.
4986         (object_files): Update.
4987         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4988         * guile/scm-pretty-print.c
4989         (ppscm_find_pretty_printer_from_objfiles): Update.
4990         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4991         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4992         Update.
4993         * python/py-progspace.c (pspy_get_objfiles): Update.
4994         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4995         Update.
4996         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4997         (objfpy_lookup_objfile_by_build_id): Update.
4998         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4999         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5000         Update.
5001         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5002         (expand_symtab_containing_pc, lookup_objfile_from_block)
5003         (lookup_static_symbol, basic_lookup_transparent_type)
5004         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5005         (find_line_symtab, info_sources_command)
5006         (default_collect_symbol_completion_matches_break_on)
5007         (make_source_files_completion_list, find_main_name): Update.
5008         * symmisc.c (print_symbol_bcache_statistics)
5009         (print_objfile_statistics, maintenance_print_symbols)
5010         (maintenance_print_msymbols, maintenance_print_objfiles)
5011         (maintenance_info_symtabs, maintenance_check_symtabs)
5012         (maintenance_expand_symtabs, maintenance_info_line_tables):
5013         Update.
5014         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5015         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5016         (map_overlay_command, unmap_overlay_command)
5017         (simple_overlay_update, expand_symtabs_matching)
5018         (map_symbol_filenames): Update.
5019         * symfile-debug.c (set_debug_symfile): Update.
5020         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5021         Update.
5022         * source.c (select_source_symtab, forget_cached_source_info):
5023         Update.
5024         * solib.c (solib_read_symbols): Update.
5025         * solib-spu.c (append_ocl_sos): Update.
5026         * psymtab.c (maintenance_print_psymbols)
5027         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5028         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5029         * printcmd.c (info_symbol_command): Update.
5030         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5031         Update.
5032         * objfiles.h (class all_objfiles): Remove.
5033         * objfiles.c (have_partial_symbols, have_full_symbols)
5034         (have_minimal_symbols, qsort_cmp, update_section_map)
5035         (shared_objfile_contains_address_p)
5036         (default_iterate_over_objfiles_in_search_order): Update.
5037         * objc-lang.c (info_selectors_command, info_classes_command)
5038         (find_methods): Update.
5039         * minsyms.c (find_solib_trampoline_target): Update.
5040         * maint.c (maintenance_info_sections)
5041         (maintenance_translate_address, count_symtabs_and_blocks):
5042         Update.
5043         * main.c (captured_main_1): Update.
5044         * linux-thread-db.c (try_thread_db_load_from_pdir)
5045         (has_libpthread): Update.
5046         * linespec.c (iterate_over_all_matching_symtabs)
5047         (search_minsyms_for_name): Update.
5048         * jit.c (jit_find_objf_with_entry_addr): Update.
5049         * hppa-tdep.c (find_unwind_entry)
5050         (hppa_lookup_stub_minimal_symbol): Update.
5051         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5052         Update.
5053         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5054         (elf_gnu_ifunc_resolve_by_got): Update.
5055         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5056         * dwarf-index-write.c (save_gdb_index_command): Update.
5057         * cp-support.c (add_symbol_overload_list_qualified): Update.
5058         * breakpoint.c (create_overlay_event_breakpoint)
5059         (create_longjmp_master_breakpoint)
5060         (create_std_terminate_master_breakpoint)
5061         (create_exception_master_breakpoint): Update.
5062         * blockframe.c (find_pc_partial_function): Update.
5063         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5064         (ada_collect_symbol_completion_matches)
5065         (ada_add_global_exceptions): Update.
5066
5067 2019-01-17  Tom Tromey  <tom@tromey.com>
5068
5069         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5070         declare VEC.
5071         (solib_target_parse_libraries): Change return type.
5072         (library_list_start_segment, library_list_start_section)
5073         (library_list_end_library, library_list_start_library); Update.
5074         (solib_target_free_library_list): Remove.
5075         (solib_target_parse_libraries): Remove cleanup.  Change return
5076         type.
5077         (solib_target_current_sos): Update.
5078
5079 2019-01-17  Tom Tromey  <tromey@bapiya>
5080
5081         * valprint.c: Replace "the the" with "the".
5082         * symtab.c: Replace "the the" with "the".
5083         * solib.c: Replace "the the" with "the".
5084         * solib-dsbt.c: Replace "the the" with "the".
5085         * linespec.c: Replace "the the" with "the".
5086         * dwarf2loc.h: Replace "the the" with "the".
5087         * amd64-windows-tdep.c: Replace "the the" with "the".
5088         * aarch64-tdep.c: Replace "the the" with "the".
5089
5090 2019-01-16  Keith Seitz  <keiths@redhat.com>
5091
5092         PR gdb/23773
5093         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5094         <builder>: Rename to ..
5095         <m_builder>: ... this and make private.
5096         (dwarf2_cu::get_builder): New method.  Change all users of
5097         `builder' to use this method.
5098         (dwarf2_start_symtab): Move to ...
5099         (dwarf2_cu::start_symtab): ... here.  Update all callers
5100         (setup_type_unit_groups): Move to ...
5101         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5102         callers.
5103         (dwarf2_cu::reset_builder): New method.
5104         (process_full_compunit, process_full_type_unit): Use
5105         dwarf2_cu::reset_builder.
5106         (follow_die_offset): Record the ancestor CU if it is different
5107         from the followed DIE's CU.
5108         (follow_die_sig_1): Likewise.
5109
5110 2019-01-15  Tom Tromey  <tom@tromey.com>
5111
5112         * remote.c (class remote_state) <buf>: Now a char_vector.
5113         <buf_size>: Remove.
5114         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5115         parameter.
5116         (remote_target::getpkt_or_notif_sane_1)
5117         (remote_target::getpkt_sane)
5118         (remote_target::getpkt_or_notif_sane): Likewise.
5119         (class remote_target) <putpkt>: New overload.
5120         (remote_target::read_frame): Change type of "buf_p".  Remove
5121         sizeof_p parameter.
5122         (packet_ok): New overload.
5123         (packet_check_result): New overload.
5124         Update all uses.
5125
5126 2019-01-14  Tom Tromey  <tom@tromey.com>
5127
5128         * remote-notif.c (handle_notification, remote_notif_ack)
5129         (remote_notif_parse): Make "buf" const.
5130         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5131         const.
5132         (remote_notif_parse, remote_notif_ack, handle_notification):
5133         Likewise.
5134         * remote.c (remote_notif_stop_parse): Make "buf" const.
5135         (remote_target::remote_parse_stop_reply): Make "buf" const.
5136         (remote_notif_stop_ack): Make "buf" const.
5137
5138 2019-01-14  Tom Tromey  <tom@tromey.com>
5139
5140         * remote.c (remote_console_output): Make parameter const.
5141
5142 2019-01-14  Tom Tromey  <tom@tromey.com>
5143
5144         * target-debug.h (target_debug_print_signals): Constify.
5145         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5146         * procfs.c (procfs_target::pass_signals): Update.
5147         * linux-nat.c (linux_nat_target::pass_signals): Update.
5148         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5149         * target-delegates.c: Rebuild.
5150         * remote.c (remote_target::program_signals): Update.
5151         (remote_target::pass_signals): Update.
5152         * target.c (target_pass_signals): Constify argument.
5153         (target_program_signals): Likewise.
5154         * target.h (struct target_ops) <pass_signals, program_signals>:
5155         Constify argument.
5156         (target_pass_signals, target_program_signals): Constify argument.
5157
5158 2019-01-14  Tom Tromey  <tom@tromey.com>
5159
5160         PR tui/28819:
5161         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5162
5163 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5164
5165         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5166         field.
5167         * rs6000-tdep.c: Include reggroups.h.
5168         (IS_V_ALIAS_PSEUDOREG): Define.
5169         (rs6000_register_name): Return names for the "vX" aliases.
5170         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5171         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5172         aliases.  Call default_register_reggroup_p for all other
5173         pseudo-registers.
5174         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5175         New functions.
5176         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5177         Handle "vX" aliases.
5178         (v_alias_pseudo_register_collect): New function.
5179         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5180         (rs6000_gdbarch_init): Initialize "vX" aliases as
5181         pseudo-registers.  Restore registration of
5182         rs6000_pseudo_register_reggroup_p with
5183         set_tdesc_pseudo_register_reggroup_p.
5184
5185 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5186
5187         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5188         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5189         set_gdbarch_num_pseudo_regs.
5190
5191 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5192
5193         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5194         Remove arg prefixname, add do_set and do_show.
5195         Add member functions set_list and show_list.
5196         * cli/cli-style.c (class cli_style_option): Update accordingly.
5197         (style_set_list): Move to file scope.
5198         (style_show_list): Likewise.
5199         (set_style): Call help_list.
5200         (show_style): Call cmd_show_list.
5201         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5202         Update to use the new macro.
5203
5204 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5205
5206         * ada-lang.c (_initialize_ada_language): Expand the help text
5207         for the "catch exception" command.
5208
5209 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5210
5211         * symtab.c (matching_obj_sections): Initialize obj,
5212         declare it closer to its usage.
5213
5214 2019-01-10  Tom Tromey  <tom@tromey.com>
5215
5216         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5217         (basic_inf_threads_range): Remove.
5218         (inf_threads_range, inf_non_exited_threads_range)
5219         (safe_inf_threads_range): Use next_adapter.
5220
5221 2019-01-10  Keith Seitz  <keiths@redhat.com>
5222
5223         PR gdb/23712
5224         PR symtab/23010
5225         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5226         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5227
5228 2019-01-10  Keith Seitz  <keiths@redhat.com>
5229
5230         PR gdb/23712
5231         PR symtab/23010
5232         * dictionary.c (pending_to_vector): Remove.
5233         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5234         Remove _1 suffix, replacing functions of the same name.  Update
5235         all callers.
5236         (dict_create_hashed, dict_create_hashed_expandable)
5237         (dict_create_linear, dict_create_linear_expandable, dict_free)
5238         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5239         Make functions static.
5240
5241 2019-01-10  Keith Seitz  <keiths@redhat.com>
5242
5243         PR gdb/23712
5244         PR symtab/23010
5245         * dictionary.h (struct dictionary): Replace declaration with
5246         multidictionary.
5247         (dict_create_hashed, dict_create_hashed_expandable)
5248         (dict_create_linear, dict_create_linear_expandable)
5249         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5250         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5251         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5252         taking multidictionary argument.
5253         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5254         * block.h (struct block) <dict>: Change to multidictionary
5255         and rename `multidict'.
5256         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5257         symmisc.c: Update all dictionary references to multidictionary.
5258
5259 2019-01-10  Keith Seitz  <keiths@redhat.com>
5260
5261         PR gdb/23712
5262         PR symtab/23010
5263         * dictionary.c: Include unordered_map.
5264         (pending_to_vector): New function.
5265         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5266         Rewrite the non-"_1" functions to take vector instead
5267         of linked list.
5268         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5269         "new" _1 versions of the same name.
5270         (multidictionary): Define.
5271         (std::hash<enum language): New definition.
5272         (collate_pending_symbols_by_language, mdict_create_hashed)
5273         (mdict_create_hashed_expandable, mdict_create_linear)
5274         (mdict_create_linear_expandable, mdict_free)
5275         (find_language_dictionary, create_new_language_dictionary)
5276         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5277         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5278         (mdict_size, mdict_empty): New functions.
5279         * dictionary.h (mdict_iterator): Define.
5280
5281 2019-01-10  Pedro Alves  <palves@redhat.com>
5282
5283         * breakpoint.c (read_uploaded_action)
5284         (create_tracepoint_from_upload): Adjust to use
5285         gdb::unique_xmalloc_ptr.
5286         * ctf.c (ctf_write_uploaded_tp):
5287         (SET_ARRAY_FIELD): Use emplace_back.
5288         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5289         * tracefile-tfile.c (tfile_write_uploaded_tp):
5290         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5291         gdb::unique_xmalloc_ptr.
5292         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5293         at_string, cond_string, cmd_strings>: Replace char pointers
5294         with gdb::unique_xmalloc_ptr.
5295
5296 2019-01-10  Pedro Alves  <palves@redhat.com>
5297
5298         * solib-target.c (library_list_start_library): Don't xstrdup name.
5299
5300 2019-01-10  Pedro Alves  <palves@redhat.com>
5301
5302         * mdebugread.c (parse_partial_symbols): Use
5303         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5304
5305 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5306
5307         * linux-fork.c (scoped_switch_fork_info)
5308         <~scoped_switch_fork_info>: Fix incorrect variable name.
5309
5310 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5311
5312         * linux-fork.c (scoped_switch_fork_info)
5313         <scoped_switch_fork_info>: Make explicit.
5314         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5315
5316 2019-01-10  Tom Tromey  <tom@tromey.com>
5317
5318         * objfiles.h (objfile::reset_psymtabs): Update.
5319         * objfiles.c (objfile::objfile): Update.
5320         * psymtab.h (psymtab_storage::obstack): Update.
5321         (psymtab_storage::m_obstack): Use gdb::optional.
5322         (class psymtab_storage): Update comment.  Remove objfile
5323         parameter.
5324         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5325
5326 2019-01-10  Tom Tromey  <tom@tromey.com>
5327
5328         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5329         <free_psymtabs>: Now private.
5330         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5331         (allocate_psymtab): Use new method.
5332
5333 2019-01-10  Tom Tromey  <tom@tromey.com>
5334
5335         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5336         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5337         * mdebugread.c (parse_partial_symbols): Use
5338         allocate_dependencies.
5339         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5340         allocate_dependencies.
5341         (process_psymtab_comp_unit_reader)
5342         (build_type_psymtab_dependencies): Likewise.
5343         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5344
5345 2019-01-10  Tom Tromey  <tom@tromey.com>
5346
5347         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5348         PSYMBOL_SET_LANGUAGE.
5349         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5350
5351 2019-01-10  Tom Tromey  <tom@tromey.com>
5352
5353         * psymtab.h (psymtab_storage::obstack): New method.
5354         <m_obstack>: Rename from obstack; now private.
5355         * psymtab.c (psymtab_storage): Update.
5356         * dwarf2read.c (create_addrmap_from_index)
5357         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5358         Update.
5359
5360 2019-01-10  Tom Tromey  <tom@tromey.com>
5361
5362         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5363         * objfiles.h (objfile::reset_psymtabs): New method.
5364
5365 2019-01-10  Tom Tromey  <tom@tromey.com>
5366
5367         * symmisc.c (print_symbol_bcache_statistics): Update.
5368         (print_objfile_statistics): Update.
5369         * symfile.c (reread_symbols): Update.
5370         * psymtab.h (class psymtab_storage): New.
5371         * psymtab.c (psymtab_storage): New constructor.
5372         (~psymtab_storage): New destructor.
5373         (require_partial_symbols): Update.
5374         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5375         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5376         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5377         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5378         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5379         (start_psymtab_common, end_psymtab_common)
5380         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5381         (allocate_psymtab): Update.
5382         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5383         Update.
5384         (dump_psymtab_addrmap, maintenance_print_psymbols)
5385         (maintenance_check_psymtabs): Update.
5386         (class objfile_psymtabs): Move to objfiles.h.
5387         * psympriv.h (discard_psymtab): Now inline.
5388         (psymtab_discarder::psymtab_discarder): Update.
5389         (psymtab_discarder::~psymtab_discarder): Update.
5390         (ALL_OBJFILE_PSYMTABS): Rewrite.
5391         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5392         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5393         Remove fields.
5394         <partial_symtabs>: New field.
5395         (class objfile_psymtabs): Move from psymtab.h.  Update.
5396         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5397         psymbol_cache.
5398         (objfile::~objfile): Don't destroy psymbol_cache.
5399         * mdebugread.c (parse_partial_symbols): Update.
5400         * dwarf2read.c (create_addrmap_from_index)
5401         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5402         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5403         (add_partial_subprogram, dwarf2_ranges_read): Update.
5404         * dwarf-index-write.c (write_address_map)
5405         (write_one_signatured_type, recursively_write_psymbols)
5406         (class debug_names, class debug_names, write_psymtabs_to_index):
5407         Update.
5408
5409 2019-01-10  Tom Tromey  <tom@tromey.com>
5410
5411         * symtab.h (SYMBOL_SET_NAMES): Update.
5412         (symbol_set_names): Update.
5413         (MSYMBOL_SET_NAMES): Update.
5414         * symtab.c (symbol_set_names): Change argument to be an
5415         objfile_per_bfd_storage.
5416         * psymtab.c (add_psymbol_to_bcache): Update.
5417         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5418
5419 2019-01-10  Tom Tromey  <tom@tromey.com>
5420
5421         * symtab.c (create_demangled_names_hash): Change argument to be an
5422         objfile_per_bfd_storage.
5423         (symbol_set_names): Update.
5424
5425 2019-01-10  Tom Tromey  <tom@tromey.com>
5426
5427         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5428         init_psymbol_list.
5429         * psymtab.c (init_psymbol_list): Do nothing if already called.
5430         * psympriv.h (init_psymbol_list): Add comment.
5431         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5432         init_psymbol_list.
5433         * dbxread.c (dbx_symfile_read): Unconditionally call
5434         init_psymbol_list.
5435
5436 2019-01-10  Tom Tromey  <tom@tromey.com>
5437
5438         * xcoffread.c (scan_xcoff_symtab): Update.
5439         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5440         "where".
5441         * mdebugread.c (parse_partial_symbols)
5442         (handle_psymbol_enumerators): Update.
5443         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5444         * dbxread.c (read_dbx_symtab): Update.
5445         * psympriv.h (psymbol_placement): New enum.
5446         (add_psymbol_to_list): Update.
5447
5448 2019-01-10  Tom Tromey  <tom@tromey.com>
5449
5450         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5451         static_psymbols parameters.
5452         (scan_xcoff_symtab): Update.
5453         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5454         static_psymbols parameters.
5455         * psympriv.h (start_psymtab_common): Update.
5456         * mdebugread.c (parse_partial_symbols): Update.
5457         * dwarf2read.c (create_partial_symtab): Update.
5458         * dbxread.c (read_dbx_symtab): Update.
5459         (start_psymtab): Remove global_psymbols and static_psymbols
5460         parameters.
5461
5462 2019-01-10  Tom Tromey  <tom@tromey.com>
5463
5464         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5465         * psymtab.c (allocate_psymtab): Add comment.
5466         * psympriv.h (allocate_psymtab): Add comment.
5467         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5468         initializations.
5469         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5470
5471 2019-01-10  Tom Tromey  <tom@tromey.com>
5472
5473         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5474         Don't declare.
5475         * mipsread.c: Include mdebugread.h.
5476         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5477         Declare.
5478         * elfread.c: Include mdebugread.h.
5479
5480 2019-01-09  Tom Tromey  <tom@tromey.com>
5481
5482         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5483         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5484         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5485         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5486         (psym_lookup_symbol, psym_find_last_source_symtab)
5487         (psym_forget_cached_source_info, psym_print_stats)
5488         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5489         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5490         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5491         (psym_find_compunit_symtab_by_address)
5492         (maintenance_print_psymbols, maintenance_info_psymtabs)
5493         (maintenance_check_psymtabs): Use ranged for.
5494         * psymtab.h (class objfile_psymtabs): New.
5495         (require_partial_symbols): Return objfile_psymtabs.
5496         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5497
5498 2019-01-09  Tom Tromey  <tom@tromey.com>
5499
5500         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5501         (find_pc_mapped_section, list_overlays_command)
5502         (map_overlay_command, unmap_overlay_command)
5503         (simple_overlay_update): Use all_objfiles.
5504         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5505         * printcmd.c (info_symbol_command): Use all_objfiles.
5506         * objfiles.h (ALL_OBJSECTIONS): Remove.
5507         * maint.c (maintenance_translate_address): Use all_objfiles.
5508         * gcore.c (gcore_create_callback): Use all_objfiles.
5509         (objfile_find_memory_regions): Likewise.
5510
5511 2019-01-09  Tom Tromey  <tom@tromey.com>
5512
5513         * symtab.c (find_line_symtab, info_sources_command)
5514         (make_source_files_completion_list): Use objfile_compunits.
5515         * source.c (select_source_symtab): Use objfile_compunits.
5516         * objfiles.h (struct objfile): Update comment.
5517         (ALL_OBJFILES): Remove.
5518         (ALL_FILETABS): Remove.
5519         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5520         objfile_compunits.
5521
5522 2019-01-09  Tom Tromey  <tom@tromey.com>
5523
5524         * symmisc.c (print_objfile_statistics, dump_objfile)
5525         (maintenance_print_symbols): Use compunit_filetabs.
5526         * source.c (forget_cached_source_info_for_objfile): Use
5527         compunit_filetabs.
5528         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5529         (ALL_FILETABS): Use compunit_filetabs.
5530         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5531         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5532
5533 2019-01-09  Tom Tromey  <tom@tromey.com>
5534
5535         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5536         (compunit_filetabs): New.
5537         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5538         compunit_filetabs.
5539         (info_sources_command, make_source_files_completion_list): Remove
5540         declaration.
5541         * symmisc.c (print_objfile_statistics, dump_objfile)
5542         (maintenance_print_symbols): Remove declaration.
5543         (maintenance_info_symtabs): Use compunit_filetabs.
5544         (maintenance_info_line_tables): Likewise.
5545         * source.c (select_source_symtab): Change local variable name.
5546         (forget_cached_source_info_for_objfile): Remove declaration.
5547         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5548         * objfiles.c (objfile_relocate1): Remove declaration.
5549         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5550         declaration.
5551         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5552         * coffread.c (coff_symtab_read): Remove declaration.
5553         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5554         compunit_filetabs.
5555
5556 2019-01-09  Tom Tromey  <tom@tromey.com>
5557
5558         * symtab.c (lookup_objfile_from_block)
5559         (find_pc_sect_compunit_symtab, search_symbols)
5560         (default_collect_symbol_completion_matches_break_on): Use
5561         objfile_compunits.
5562         * objfiles.h (ALL_COMPUNITS): Remove.
5563         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5564         * cp-support.c (add_symbol_overload_list_qualified): Use
5565         objfile_compunits.
5566         * ada-lang.c (ada_collect_symbol_completion_matches)
5567         (ada_add_global_exceptions): Use objfile_compunits.
5568
5569 2019-01-09  Tom Tromey  <tom@tromey.com>
5570
5571         * source.c (select_source_symtab)
5572         (forget_cached_source_info_for_objfile): Remove declaration.
5573         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5574         declaration.
5575         * maint.c (count_symtabs_and_blocks): Remove declaration.
5576         * cp-support.c (add_symbol_overload_list_qualified): Remove
5577         declaration.
5578         * coffread.c (coff_symtab_read): Remove declaration.
5579         * symtab.c (lookup_symbol_in_objfile_symtabs)
5580         (basic_lookup_transparent_type_1): Use objfile_compunits.
5581         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5582         (info_sources_command, search_symbols)
5583         (default_collect_symbol_completion_matches_break_on)
5584         (make_source_files_completion_list): Remove declaration.
5585         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5586         (ada_collect_symbol_completion_matches)
5587         (ada_add_global_exceptions): Remove declaration.
5588         * linespec.c (iterate_over_all_matching_symtabs): Use
5589         objfile_compunits.
5590         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5591         (class objfile_compunits): New.
5592         (ALL_COMPUNITS): Use objfile_compunits.
5593         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5594         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5595         objfile_compunits.
5596         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5597
5598 2019-01-09  Tom Tromey  <tom@tromey.com>
5599
5600         * symtab.c (search_symbols)
5601         (default_collect_symbol_completion_matches_break_on): Use
5602         objfile_msymbols.
5603         * ada-lang.c (ada_lookup_simple_minsym)
5604         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5605         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5606         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5607         objfile_msymbols.
5608         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5609         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5610         * objc-lang.c (find_methods): Use objfile_msymbols.
5611         (info_selectors_command, info_classes_command): Likewise.
5612         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5613         * objfiles.h (class objfile_msymbols): New.
5614         (ALL_OBJFILE_MSYMBOLS): Remove.
5615         (ALL_MSYMBOLS): Remove.
5616
5617 2019-01-09  Tom Tromey  <tom@tromey.com>
5618
5619         * common/next-iterator.h (next_adapter): Add Iterator template
5620         parameter.
5621         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5622         (class all_objfiles_safe): New.
5623         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5624         * objfiles.c (put_objfile_before): Update comment.
5625         (add_separate_debug_objfile): Likewise.
5626         (free_all_objfiles): Use all_objfiles_safe.
5627         (objfile_purge_solibs): Likewise.
5628
5629 2019-01-09  Tom Tromey  <tom@tromey.com>
5630
5631         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5632         (expand_symtab_containing_pc, lookup_static_symbol)
5633         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5634         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5635         all_objfiles.
5636         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5637         * breakpoint.c (create_overlay_event_breakpoint)
5638         (create_longjmp_master_breakpoint)
5639         (create_std_terminate_master_breakpoint)
5640         (create_exception_master_breakpoint): Use all_objfiles.
5641         * linux-thread-db.c (try_thread_db_load_from_pdir)
5642         (has_libpthread): Use all_objfiles.
5643         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5644         * linespec.c (iterate_over_all_matching_symtabs)
5645         (search_minsyms_for_name): Use all_objfiles.
5646         * maint.c (maintenance_info_sections): Use all_objfiles.
5647         * main.c (captured_main_1): Use all_objfiles.
5648         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5649         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5650         * guile/scm-pretty-print.c
5651         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5652         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5653         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5654         (maintenance_print_msymbols): Use all_objfiles.
5655         * source.c (select_source_symtab): Use all_objfiles.
5656         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5657         * symfile.c (remove_symbol_file_command)
5658         (expand_symtabs_matching, map_symbol_filenames): Use
5659         all_objfiles.
5660         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5661         all_objfiles.
5662         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5663         * objc-lang.c (find_methods): Use all_objfiles.
5664         * objfiles.c (have_partial_symbols, have_full_symbols)
5665         (have_minimal_symbols, qsort_cmp)
5666         (default_iterate_over_objfiles_in_search_order): Use
5667         all_objfiles.
5668         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5669         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5670         (maintenance_check_psymtabs): Use all_objfiles.
5671         (ALL_PSYMTABS): Remove.
5672         * compile/compile-object-run.c (do_module_cleanup): Use
5673         all_objfiles.
5674         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5675         * cp-support.c (add_symbol_overload_list_qualified): Use
5676         all_objfiles.
5677         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5678         Use all_objfiles.
5679         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5680         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5681         all_objfiles.
5682         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5683         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5684         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5685         Uses all_objfiles.
5686         * solib.c (solib_read_symbols): Use all_objfiles
5687
5688 2019-01-09  Tom Tromey  <tom@tromey.com>
5689
5690         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5691         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5692         all_objfiles.
5693         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5694         * symmisc.c (print_symbol_bcache_statistics)
5695         (print_objfile_statistics, maintenance_print_objfiles)
5696         (maintenance_info_symtabs, maintenance_check_symtabs)
5697         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5698         all_objfiles.
5699         * source.c (forget_cached_source_info): Use all_objfiles.
5700         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5701         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5702         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5703         * objfiles.c (update_section_map): Use all_objfiles.
5704         (shared_objfile_contains_address_p): Likewise.
5705         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5706         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5707
5708 2019-01-09  Tom Tromey  <tom@tromey.com>
5709
5710         * common/next-iterator.h: New file.
5711         * objfiles.h (class all_objfiles): New.
5712         (struct objfile_iterator): New.
5713
5714 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5715
5716         * NEWS: Move the description of the changed "frame", "select-frame",
5717          and "info frame" commands to the Changed commands section.
5718
5719 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5720
5721         * gdbtypes.c (check_stub_method_group): Remove handling of old
5722         mangling schemes.
5723         * linespec.c (find_methods): Likewise.
5724         * stabsread.c (read_member_functions): Likewise.
5725         * valops.c (search_struct_method): Likewise.
5726         (value_struct_elt_for_reference): Likewise.
5727         * NEWS: Mention this change.
5728
5729 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5730
5731         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5732         print_source_lines.
5733         * source.c (print_source_lines_base): Update line number check.
5734         (print_source_lines): New function.
5735         (source_lines_range::source_lines_range): New function.
5736         * source.h (class source_lines_range): New class.
5737         (print_source_lines): New declaration.
5738
5739 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5740
5741         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5742
5743 2019-01-08  Tom Tromey  <tom@tromey.com>
5744             Simon Marchi  <simon.marchi@ericsson.com>
5745
5746         PR gdb/24060
5747         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5748         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5749         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5750         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5751         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5752         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5753
5754 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5755
5756         * source.c (select_source_symtab): Move header comment to
5757         declaration in source.h.
5758         (forget_cached_source_info_for_objfile): Likewise.
5759         (forget_cached_source_info): Likewise.
5760         (identify_source_line): Likewise.
5761         * source.h (identify_source_line): Move declaration from symtab.h
5762         and add comment from source.c
5763         (print_source_lines): Likewise.
5764         (forget_cached_source_info_for_objfile): Likewise.
5765         (forget_cached_source_info): Likewise.
5766         (select_source_symtab): Likewise.
5767         (enum print_source_lines_flag): Move definition from symtab.h.
5768         * symtab.h (identify_source_line): Move declaration to source.h.
5769         (print_source_lines): Likewise.
5770         (forget_cached_source_info_for_objfile): Likewise.
5771         (forget_cached_source_info): Likewise.
5772         (select_source_symtab): Likewise.
5773         (enum print_source_lines_flag): Move definition to source.h.
5774         * tui/tui-hooks.c: Add 'source.h' include.
5775
5776 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5777
5778         * source.c (print_source_lines_base): Handle requests to print
5779         reverse line number sequences, and guard against empty lines
5780         string.
5781
5782 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5783
5784         * source.c (print_source_lines_base): Fix skip of '\r' if next
5785         character is '\n'.
5786
5787 2019-01-06  Tom Tromey  <tom@tromey.com>
5788
5789         * c-exp.y (struct c_parse_state) <macro_original_text,
5790         expansion_obstack>: New member.
5791         (macro_original_text, expansion_obstack): Remove globals.
5792         (scan_macro_expansion, scanning_macro_expansion)
5793         (finished_macro_expansion): Update.
5794         (scan_macro_cleanup): Remove.
5795         (yylex, c_parse): Update.
5796
5797 2019-01-06  Tom Tromey  <tom@tromey.com>
5798
5799         * c-exp.y (struct c_parse_state) <strings>: New member.
5800         (operator_stoken): Update.
5801
5802 2019-01-06  Tom Tromey  <tom@tromey.com>
5803
5804         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5805         (union type_stack_elt) <typelist_val>: Now a pointer to
5806         std::vector.
5807         (type_stack_cleanup): Don't declare.
5808         (push_typelist): Update.
5809         * parse.c (pop_typelist): Return a std::vector.
5810         (push_typelist): Take a std::vector.
5811         (follow_types): Update.  Do not free args.
5812         (type_stack_cleanup): Remove.
5813         * c-exp.y (struct c_parse_state): New.
5814         (cpstate): New global.
5815         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5816         (nonempty_typelist): Update.
5817         (func_mod): Create a new vector.
5818         (c_parse): Create a c_parse_state.
5819         (check_parameter_typelist): Do not delete params.
5820         (function_method): Update.  Do not delete type_list.
5821
5822 2019-01-06  Tom Tromey  <tom@tromey.com>
5823
5824         PR gdb/28155:
5825         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5826         check_typedef.
5827         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5828         (print_return_value): Likewise.
5829
5830 2019-01-05  Tom Tromey  <tom@tromey.com>
5831
5832         * contrib/cleanup_check.py: Remove.
5833         * contrib/gcc-with-excheck: Remove.
5834         * contrib/exsummary.py: Remove.
5835         * contrib/excheck.py: Remove.
5836
5837 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5838
5839         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5840         NULL. Initialize tpprev to NULL instead of assigning it
5841         to NULL on the next statement.
5842         * windows-nat.c (windows_delete_thread): Remove check for
5843         main_thread_id before printing thread exit notifications.
5844         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5845         Remove thread ID check against main_thread_id.
5846         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5847         windows_delete_thread.
5848         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5849
5850 2019-01-04  Tom Tromey  <tom@tromey.com>
5851
5852         * compile/compile.c (_initialize_compile): Use upper case for
5853         metasyntactic variables.
5854         * symmisc.c (_initialize_symmisc): Use upper case for
5855         metasyntactic variables.
5856         * psymtab.c (_initialize_psymtab): Use upper case for
5857         metasyntactic variables.
5858         * demangle.c (demangle_command): Use upper case for metasyntactic
5859         variables.
5860         (_initialize_demangler): Likewise.
5861         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5862         variables.
5863
5864 2019-01-03  Tom Tromey  <tom@tromey.com>
5865
5866         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5867
5868 2019-01-03  Tom Tromey  <tom@tromey.com>
5869
5870         * python/py-symtab.c (salpy_str): Update.
5871         (struct salpy_sal_object) <symtab>: Now a PyObject.
5872         (salpy_dealloc): Update.
5873         (del_objfile_sal): Use gdbpy_ref.
5874
5875 2019-01-03  Tom Tromey  <tom@tromey.com>
5876
5877         * python/py-type.c (convert_field): Use new_reference.  Return
5878         gdbpy_ref.
5879         (make_fielditem): Return gdbpy_ref.
5880         (typy_fields): Update.
5881         (typy_getitem): Update.
5882         (field_name): Return gdbpy_ref.  Use new_reference.
5883         (typy_iterator_iternext): Update.
5884
5885 2019-01-03  Tom Tromey  <tom@tromey.com>
5886
5887         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5888
5889 2019-01-03  Tom Tromey  <tom@tromey.com>
5890
5891         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5892         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5893         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5894         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5895         (pspy_set_type_printers): Likewise.
5896         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5897         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5898         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5899         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5900         (objfpy_set_type_printers): Likewise.
5901
5902 2019-01-03  Tom Tromey  <tom@tromey.com>
5903
5904         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5905         (gdbpy_print_stack): Use gdbpy_err_fetch.
5906         * python/python-internal.h (class gdbpy_err_fetch): New class.
5907         (class gdbpy_enter) <m_error_type, m_error_value,
5908         m_error_traceback>: Remove.
5909         <m_error>: New member.
5910         (gdbpy_exception_to_string): Don't declare.
5911         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5912         * python/py-value.c (convert_value_from_python): Use
5913         gdbpy_err_fetch.
5914         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5915         gdbpy_exception_to_string.
5916         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5917         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5918         gdbpy_err_fetch.
5919
5920 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5921
5922         * linux-nat.c (delete_lwp_cleanup): Delete.
5923         (struct lwp_deleter): New struct.
5924         (lwp_info_up): New typedef.
5925         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5926         lwp_info_up.
5927
5928 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5929
5930         * linux-fork.c (class scoped_switch_fork_info): New class.
5931         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5932
5933 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5934
5935         * valops.c (find_overload_match): Remove use of null_cleanup, and
5936         calls to do_cleanups.
5937
5938 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5939
5940         * compile/compile-cplus-types.c
5941         (compile_cplus_instance::decl_name): Handle changes to
5942         cp_func_name.
5943         * cp-support.c (cp_func_name): Update header comment, update
5944         return type.
5945         * cp-support.h (cp_func_name): Update return type in declaration.
5946         * valops.c (find_overload_match): Move temp_func local to top
5947         level of function and change its type.  Use temp_func to hold and
5948         delete temporary string obtained from cp_func_name.
5949
5950 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5951
5952         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5953         gdb::char_vector, remove cleanup, and update uses of `msg`.
5954
5955 2019-01-03  Jim Wilson  <jimw@sifive.com>
5956
5957         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5958
5959 2019-01-02  Tom Tromey  <tom@tromey.com>
5960
5961         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5962         (tdesc_parse_xml): Remove cleanups.
5963         * target-descriptions.h (make_cleanup_free_target_description):
5964         Don't declare.
5965         (target_desc_deleter): New struct.
5966         (target_desc_up): New typedef.
5967         * target-descriptions.c (target_desc_deleter::operator()): Rename
5968         from free_target_description.
5969         (make_cleanup_free_target_description): Remove.
5970
5971 2019-01-02  Tom Tromey  <tom@tromey.com>
5972
5973         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5974         constructor, destructor.
5975         (linespec_parser): Remove typedef.
5976         (~linespec_parser): Rename from linespec_parser_delete.
5977         (linespec_lex_to_end, linespec_complete_label)
5978         (linespec_complete): Update.
5979         (decode_line_full): Remove cleanups.
5980         (decode_line_1): Update.
5981
5982 2019-01-02  Tom Tromey  <tom@tromey.com>
5983
5984         * python/python-internal.h (inferior_to_inferior_object): Change
5985         return type.
5986         * python/py-exitedevent.c (create_exited_event_object): Update.
5987         * python/py-inferior.c (inferior_to_inferior_object): Return
5988         gdbpy_ref.
5989         (python_new_inferior, python_inferior_deleted)
5990         (thread_to_thread_object, delete_thread_object)
5991         (build_inferior_list, gdbpy_selected_inferior): Update.
5992         * python/py-infthread.c (create_thread_object): Update.  Also fail
5993         if inferior_to_inferior_object fails.
5994
5995 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5996
5997         * inferior.h (class inferior) <displaced_step_state>: New field.
5998         * infrun.h (struct displaced_step_state): Move here from
5999         infrun.c.  Initialize fields, add constructor.
6000         <inf>: Remove field.
6001         <reset>: New method.
6002         * infrun.c (struct displaced_step_inferior_state): Move to
6003         infrun.h.
6004         (displaced_step_inferior_states): Remove.
6005         (get_displaced_stepping_state): Adust.
6006         (displaced_step_in_progress_any_inferior): Adjust.
6007         (displaced_step_in_progress_thread): Adjust.
6008         (displaced_step_in_progress): Adjust.
6009         (add_displaced_stepping_state): Remove.
6010         (get_displaced_step_closure_by_addr): Adjust.
6011         (remove_displaced_stepping_state): Remove.
6012         (infrun_inferior_exit): Call displaced_step_state.reset.
6013         (use_displaced_stepping): Don't check for NULL.
6014         (displaced_step_prepare_throw): Call
6015         get_displaced_stepping_state.
6016         (displaced_step_fixup): Don't check for NULL.
6017         (prepare_for_detach): Don't check for NULL.
6018
6019 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6020
6021         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6022          in case of call that did not complete.
6023
6024 2019-01-02  Andrey Utkin  <autkin@undo.io>
6025
6026         * symfile.c (find_separate_debug_file): Fix search of debug files for
6027         remote debuggee.
6028
6029 2019-01-02  Tom Tromey  <tom@tromey.com>
6030
6031         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6032         indentation.
6033         * python/py-frame.c (frapy_older): Remove cast.
6034         (frapy_newer): Likewise.
6035         * python/py-breakpoint.c (local_setattro): Remove cast.
6036         * python/py-arch.c (archpy_name): Remove local variable.
6037         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6038
6039 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6040
6041         * unittests/basic_string_view/element_access/char/empty.cc:
6042         Fix year range in copyright header.
6043
6044 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6047         Delete.
6048         <operator==>: Update with for removed field.
6049         <hash>: Likewise.
6050         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6051         <isa_features>: ...this.
6052         <abi_features>: New field.
6053         (riscv_isa_flen): Update comment.
6054         (riscv_abi_xlen): New declaration.
6055         (riscv_abi_flen): New declaration.
6056         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6057         isa_features.
6058         (riscv_abi_xlen): New function.
6059         (riscv_isa_flen): Update to get answer from isa_features.
6060         (riscv_abi_flen): New function.
6061         (riscv_has_fp_abi): Update to get answer from abi_features.
6062         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6063         xlen and flen.
6064         (riscv_call_info) <xlen, flen>: Update comment.
6065         (riscv_call_arg_struct): Remove invalid assertions
6066         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6067         is removed.
6068         (riscv_gdbarch_init): Gather isa features and abi features
6069         separately, ensure both match on the gdbarch when reusing an old
6070         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6071         a target with 64-bit float hardware.
6072
6073 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6074
6075         * source.c (search_command_helper): Stop reverse search
6076         when line 1 has been searched.
6077
6078 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6079
6080         * record-full.c (record_full_base_target::close): Rewrite
6081         record_full_core_buf_list free logic.
6082
6083 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6084
6085         * break-catch-syscall.c (print_one_catch_syscall): xfree
6086         the last text.
6087
6088 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6089
6090         * top.c (print_gdb_version): Update Copyright year in version
6091         message.
6092
6093 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6094
6095         Update copyright year range in all GDB files.
6096
6097 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6098
6099         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6100
6101 For older changes see ChangeLog-2018.
6102 \f
6103 Local Variables:
6104 mode: change-log
6105 left-margin: 8
6106 fill-column: 74
6107 version-control: never
6108 coding: utf-8
6109 End:
6110