gdb/ChangeLog

   1 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
   4         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
   5         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
   6
   7 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
   8
   9         * f-exp.y (convert_to_kind_type): Handle more type kinds.
  10
  11 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  12             Chris January  <chris.january@arm.com>
  13
  14         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
  15         * f-exp.y: Define 'KIND' token.
  16         (exp): New pattern for KIND expressions.
  17         (ptype): Handle types with a kind extension.
  18         (direct_abs_decl): Extend to spot kind extensions.
  19         (f77_keywords): Add 'kind' to the list.
  20         (push_kind_type): New function.
  21         (convert_to_kind_type): New function.
  22         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
  23         * parse.c (operator_length_standard): Likewise.
  24         * parser-defs.h (enum type_pieces): Add tp_kind.
  25         * std-operator.def: Add UNOP_KIND.
  26
  27 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  28
  29         * f-exp.y (f_parse): Set yydebug.
  30
  31 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  32
  33         * f-lang.c (evaluate_subexp_f): New function.
  34         (exp_descriptor_f): New global.
  35         (f_language_defn): Use exp_descriptor_f instead of
  36         exp_descriptor_standard.
  37
  38 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  39
  40         * f-exp.y (struct token): Add comments.
  41         (dot_ops): Remove uppercase versions and the end marker.
  42         (f77_keywords): Likewise.
  43         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
  44         entries in the dot_ops array are case insensitive, and use
  45         strncasecmp to compare strings.  Also some whitespace cleanup in
  46         this area.  Similar for the f77_keywords array, except entries in
  47         this list might be case sensitive.
  48
  49 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  50
  51         * f-exp.y (struct f77_boolean_val): Add comments.
  52         (boolean_values): Remove uppercase versions, and end marker.
  53         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
  54         and use strncasecmp to achieve case insensitivity.  Additionally,
  55         perform whitespace cleanup around this code.
  56
  57 2019-03-06  Tom Tromey  <tromey@adacore.com>
  58
  59         * remote-sim.c (gdbsim_target_open): Use result of
  60         gdb_argv::release.
  61
  62 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
  63         Dirk Schubert  <dirk.schubert@arm.com>
  64         Chris January  <chris.january@arm.com>
  65
  66         * eval.c (evaluate_subexp_standard): Call Fortran argument
  67         wrapping logic.
  68         * f-lang.c (struct value): A value which can be passed into a
  69         Fortran function call.
  70         (fortran_argument_convert): Wrap Fortran arguments in a pointer
  71         where appropriate.
  72         (struct type): Value ready for a Fortran function call.
  73         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
  74         is needed.
  75         * f-lang.h (fortran_argument_convert): Declaration.
  76         (fortran_preserve_arg_pointer): Declaration.
  77         * infcall.c (value_arg_coerce): Call Fortran argument logic.
  78
  79 2019-03-05  Tom Tromey  <tromey@adacore.com>
  80
  81         * python/py-prettyprint.c (print_string_repr): Remove #if.
  82         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
  83
  84 2019-03-05  Tom Tromey  <tromey@adacore.com>
  85
  86         * target.c (the_dummy_target): Move later.  Change type to
  87         "dummy_target".
  88         (initialize_targets): Don't initialize the_dummy_target.
  89
  90 2019-03-05  Tom Tromey  <tromey@adacore.com>
  91
  92         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
  93         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
  94
  95 2019-03-05  Tom Tromey  <tromey@adacore.com>
  96
  97         * windows-nat.c (windows_nat_target::attach)
  98         (windows_nat_target::detach): Don't call gdb_flush.
  99         * valprint.c (generic_val_print, val_print, val_print_string):
 100         Don't call gdb_flush.
 101         * utils.c (defaulted_query): Don't call gdb_flush.
 102         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 103         * target.c (target_announce_detach): Don't call gdb_flush.
 104         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 105         * remote.c (extended_remote_target::attach): Don't call
 106         gdb_flush.
 107         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 108         * printcmd.c (do_examine): Don't call gdb_flush.
 109         (info_display_command): Don't call gdb_flush.
 110         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 111         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 112         * memattr.c (info_mem_command): Don't call gdb_flush.
 113         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 114         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 115         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 116         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 117         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 118         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 119         (gnu_nat_target::detach): Don't call gdb_flush.
 120         * f-valprint.c (f_val_print): Don't call gdb_flush.
 121         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 122         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 123         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 124         gdb_flush.
 125         * c-valprint.c (c_val_print): Don't call gdb_flush.
 126         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 127
 128 2019-03-05  Tom Tromey  <tromey@adacore.com>
 129
 130         * varobj.c (update_dynamic_varobj_children): Update.
 131         (install_default_visualizer): Use reset, not release.
 132         * value.c (set_internalvar): Update.
 133         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 134         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 135         ATTRIBUTE_UNUSED_RESULT.
 136
 137 2019-03-05  Tom Tromey  <tromey@adacore.com>
 138
 139         * remote.c (class scoped_remote_fd) <release>: Add
 140         ATTRIBUTE_UNUSED_RESULT.
 141
 142 2019-03-05  Tom Tromey  <tromey@adacore.com>
 143
 144         * macroexp.c (struct macro_buffer) <release>: Add
 145         ATTRIBUTE_UNUSED_RESULT.
 146
 147 2019-03-05  Tom Tromey  <tromey@adacore.com>
 148
 149         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 150         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 151         ATTRIBUTE_UNUSED_RESULT.
 152
 153 2019-03-05  Tom Tromey  <tromey@adacore.com>
 154
 155         * common/scoped_fd.h (class scoped_fd) <release>: Add
 156         ATTRIBUTE_UNUSED_RESULT.
 157
 158 2019-03-05  Tom Tromey  <tromey@adacore.com>
 159
 160         * parser-defs.h (struct parser_state) <release>: Add
 161         ATTRIBUTE_UNUSED_RESULT.
 162
 163 2019-03-05  Tom Tromey  <tromey@adacore.com>
 164
 165         * utils.h (class gdb_argv) <release>: Add
 166         ATTRIBUTE_UNUSED_RESULT.
 167         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 168
 169 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 170
 171         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 172         for-loop range, to avoid compiler warnings.
 173
 174         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 175         avoid compiler warnings about unused variables.
 176
 177         * NEWS: Mention end of support for native debugging on MS-Windows
 178         before XP.
 179
 180         PR gdb/24292
 181         * common/netstuff.c:
 182         * gdbserver/gdbreplay.c
 183         * gdbserver/remote-utils.c:
 184         * ser-tcp.c:
 185         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 186         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 187         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 188         'getaddrinfo' and 'freeaddrinfo' were not available before
 189         Windows XP, and mingw.org's MinGW headers by default define
 190         _WIN32_WINNT to 0x500.
 191
 192 2019-03-01  Gary Benson <gbenson@redhat.com>
 193
 194         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 195
 196 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 197             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 198
 199         PR gdb/8527
 200         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 201         set_sigint_trap, clear_sigint_trap.
 202
 203 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 204
 205         * target.c (target_detach): Clear the regcache and the
 206         frame cache.
 207
 208 2019-02-27  Pedro Alves  <palves@redhat.com>
 209
 210         * utils.c (set_screen_size): When we cap the height/width sizes,
 211         tweak the corresponding command variable to show "unlimited":
 212
 213 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 214             Pedro Alves  <palves@redhat.com>
 215
 216         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 217         before calling rl_set_screen_size.
 218
 219 2019-02-27  Tom Tromey  <tromey@adacore.com>
 220
 221         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 222         define.
 223         * python/py-value.c: Remove Python 2.4 workaround.
 224         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 225         workaround.
 226         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 227         Python 2.4 workaround.
 228         * python/python-internal.h: Remove Python 2.4 comment.
 229         (Py_ssize_t): Don't define.
 230         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 231         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 232         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 233         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 234         * python/python.c (do_start_initialization): Remove Python 2.4
 235         workaround.
 236         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 237         (print_children): Remove Python 2.4 workaround.
 238         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 239         workaround.
 240         (CHARBUFFERPROC_NAME): Remove.
 241         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 242         Python 2.4 workaround.
 243
 244 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 245
 246         * NEWS: Note minimum Python version.
 247
 248 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 249
 250         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 251         code from these functions.  Remove corresponding ifdefs.  Use
 252         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 253         Remove gotos and target of gotos.
 254         (infpy_search_memory): Likewise.
 255
 256 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 257
 258         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 259         (hppa_gdbarch_init): Don't register deleted functions with
 260         gdbarch.
 261
 262 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 263
 264         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 265         (h8300_unwind_sp): Delete.
 266         (h8300_dummy_id): Delete.
 267         (h8300_gdbarch_init): Don't register deleted functions with
 268         gdbarch.
 269
 270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 271
 272         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 273         (ft32_unwind_pc): Delete.
 274         (ft32_unwind_sp): Delete.
 275         (ft32_gdbarch_init): Don't register deleted functions with
 276         gdbarch.
 277
 278 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 279
 280         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 281         (frv_unwind_pc): Delete.
 282         (frv_unwind_sp): Delete.
 283         (frv_gdbarch_init): Don't register deleted functions with
 284         gdbarch.
 285
 286 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 287
 288         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 289         (riscv_unwind_pc): Delete.
 290         (riscv_unwind_sp): Delete.
 291         (riscv_gdbarch_init): Don't register deleted functions with
 292         gdbarch.
 293
 294 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 295
 296         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 297         (csky_unwind_pc): Delete.
 298         (csky_unwind_sp): Delete.
 299         (csky_gdbarch_init): Don't register deleted functions with
 300         gdbarch.
 301
 302 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 303
 304         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 305         (cris_unwind_pc): Delete.
 306         (cris_unwind_sp): Delete.
 307         (cris_gdbarch_init): Don't register deleted functions with
 308         gdbarch.
 309
 310 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 311
 312         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 313         (bfin_unwind_pc): Delete.
 314         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 315
 316 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 317
 318         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 319         (arm_unwind_pc): Delete.
 320         (arm_unwind_sp): Delete.
 321         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 322
 323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 324
 325         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 326         (arc_unwind_pc): Delete.
 327         (arc_unwind_sp): Delete.
 328         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 329
 330 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 333         (alpha_unwind_pc): Delete.
 334         (alpha_gdbarch_init): Don't register deleted functions with
 335         gdbarch.
 336
 337 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 338
 339         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 340         (aarch64_unwind_pc): Delete.
 341         (aarch64_unwind_sp): Delete.
 342         (aarch64_gdbarch_init): Don't register deleted functions with
 343         gdbarch.
 344
 345 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 346
 347         * gdbtypes.c (type_align): Don't consider static members when
 348         computing structure alignment.
 349
 350 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 351
 352         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 353         return 0 for other types.
 354         * arch-utils.c (default_type_align): Always return 0.
 355         * gdbarch.h: Regenerate.
 356         * gdbarch.sh (type_align): Extend comment.
 357         * gdbtypes.c (type_align): Add additional comments, always call
 358         gdbarch_type_align before applying the default rules.
 359         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 360         generic code will then apply a suitable default.
 361         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 362         types, return 0 for other types.
 363
 364 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 365
 366         * NEWS: Create a new section for the next release branch.
 367         Rename the section of the current branch, now that it has
 368         been cut.
 369
 370 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 371
 372         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 373         * version.in: Bump version to 8.3.50.DATE-git.
 374
 375 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 376
 377         * aix-thread.c (ptid_cmp): Remove unused variable.
 378         (get_signaled_thread): Likewise.
 379         (store_regs_user_thread): Likewise.
 380         (store_regs_kernel_thread): Likewise.
 381         (fetch_regs_kernel_thread): Remove shadowed variable.
 382
 383 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 384
 385         * features/riscv/32bit-cpu.xml: Add register numbers.
 386         * features/riscv/32bit-fpu.c: Regenerate.
 387         * features/riscv/32bit-fpu.xml: Add register numbers.
 388         * features/riscv/64bit-cpu.xml: Add register numbers.
 389         * features/riscv/64bit-fpu.c: Regenerate.
 390         * features/riscv/64bit-fpu.xml: Add register numbers.
 391
 392 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 393
 394         * NEWS: Mention two argument form of gdb.Value constructor.
 395         * python/py-value.c (convert_buffer_and_type_to_value): New
 396         function.
 397         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 398         Add support for handling an optional second argument.  Call
 399         convert_buffer_and_type_to_value as appropriate.
 400         * python/python-internal.h (Py_buffer_deleter): New struct.
 401         (Py_buffer_up): New typedef.
 402
 403 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 404
 405         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 406         instead of releasing ownership.
 407
 408 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 409
 410         * dwarf2read.c (open_and_init_dwp_file): Call
 411         elf_numsections instead of bfd_count_sections to initialize
 412         dwp_file->num_sections.
 413
 414 2019-02-25  Tom Tromey  <tromey@adacore.com>
 415
 416         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 417
 418 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 419
 420         * gcore.in: Add '--readnever' option when invoking GDB.
 421
 422 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 423
 424         * MAINTAINERS: Update my email address.
 425
 426 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 427
 428         * build-id.c (build_id_to_debug_bfd_1): New function.
 429         (build_id_to_debug_bfd): Look for separate debug file in
 430         sysroot.
 431
 432 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 433
 434         * gdbarch.sh: Update the copyright year range that is placed into
 435         generated files.
 436
 437 2019-02-22  Keith Seitz  <keiths@redhat.com>
 438
 439         PR symtab/23853
 440         * linespec.c (create_sals_line_offset): Search for the default
 441         symtab's filename instead of its fullname.
 442
 443 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 444
 445         * NEWS: Update style defaults.
 446
 447 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 448
 449         * main.c (captured_main_1): Disable styling in batch mode.
 450
 451 2019-02-20  Tom Tromey  <tom@tromey.com>
 452
 453         * symtab.c (symtab_symbol_info): Fix typos.
 454
 455 2019-02-20  Tom Tromey  <tromey@adacore.com>
 456
 457         * findcmd.c (_initialize_mem_search): Use upper case for
 458         metasyntactic variables.
 459
 460 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 461
 462         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 463         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 464
 465 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 466
 467         * top.h (source_file_name): Change to std::string.
 468         * top.c (source_file_name): Likewise.
 469         (command_line_input): Adjust.
 470         * cli/cli-script.c (script_from_file): Adjust.
 471
 472 2019-02-19  Tom Tromey  <tromey@adacore.com>
 473
 474         * ravenscar-thread.c
 475         (ravenscar_thread_target::update_thread_list): Don't call
 476         ada_build_task_list.
 477         * ada-lang.h (ada_build_task_list): Don't declare.
 478         * ada-tasks.c (struct ada_tasks_inferior_data)
 479         <task_list_valid_p>: Now bool.
 480         (read_known_tasks, ada_task_list_changed)
 481         (ada_tasks_invalidate_inferior_data): Update.
 482         (read_known_tasks_array): Return bool.
 483         (read_known_tasks_list): Likewise.
 484         (read_known_tasks): Return void.
 485         (ada_build_task_list): Now static.
 486
 487 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 488
 489         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 490         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 491
 492 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 493
 494         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 495         variant for ada_tasks_pspace_data_handle and
 496         ada_tasks_inferior_data_handle.
 497         (ada_tasks_pspace_data_cleanup): New function.
 498         (ada_tasks_inferior_data_cleanup): New function.
 499
 500 2019-02-17  Tom Tromey  <tom@tromey.com>
 501
 502         * macrotab.h (macro_source_fullname): Return a std::string.
 503         * macrotab.c (macro_include, check_for_redefinition)
 504         (macro_undef, macro_lookup_definition, foreach_macro)
 505         (foreach_macro_in_scope): Update.
 506         (macro_source_fullname): Return a std::string.
 507         * macrocmd.c (show_pp_source_pos): Update.
 508
 509 2019-02-17  Tom Tromey  <tom@tromey.com>
 510
 511         * macrocmd.c (show_pp_source_pos): Style the file names.
 512
 513 2019-02-17  Tom Tromey  <tom@tromey.com>
 514
 515         PR tui/24197:
 516         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 517
 518 2019-02-17  Tom Tromey  <tom@tromey.com>
 519
 520         * ada-lang.c (user_select_syms): Use filtered printing.
 521         * utils.c (wrap_style): New global.
 522         (desired_style): Remove.
 523         (emit_style_escape): Add stream parameter.
 524         (set_output_style, reset_terminal_style, prompt_for_continue):
 525         Update.
 526         (flush_wrap_buffer): Only flush gdb_stdout.
 527         (wrap_here): Set wrap_style.
 528         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 529         treat escape sequences as a character.  Change when wrap buffer is
 530         flushed.
 531         (fputs_styled): Do not set the output style when the default is
 532         requested.
 533         * ui-style.h (struct ui_file_style) <is_default>: New method.
 534         * source.c (print_source_lines_base): Emit escape sequences in one
 535         piece.
 536
 537 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 538
 539         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 540         integers and enumeration types.
 541
 542 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 543
 544         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 545         instead of lookup_symbol_in_language
 546         (do_exact_match): New function.
 547         (ada_get_symbol_name_matcher): Return do_exact_match when
 548         doing a verbatim match.
 549
 550 2019-02-15  Tom Tromey  <tromey@adacore.com>
 551
 552         * ravenscar-thread.c (ravenscar_thread_target::resume)
 553         (ravenscar_thread_target::wait): Special case wildcard requests.
 554
 555 2019-02-15  Tom Tromey  <tromey@adacore.com>
 556
 557         * ravenscar-thread.c (base_ptid): Remove.
 558         (struct ravenscar_thread_target) <close>: New method.
 559         <m_base_ptid>: New member.
 560         <update_inferior_ptid, active_task, task_is_currently_active,
 561         runtime_initialized>: Declare methods.
 562         <ravenscar_thread_target>: Add constructor.
 563         (ravenscar_thread_target::task_is_currently_active)
 564         (ravenscar_thread_target::update_inferior_ptid)
 565         (ravenscar_runtime_initialized): Rename.  Now methods.
 566         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 567         (ravenscar_thread_target::update_thread_list): Update.
 568         (ravenscar_thread_target::active_task): Now method.
 569         (ravenscar_thread_target::store_registers)
 570         (ravenscar_thread_target::prepare_to_store)
 571         (ravenscar_thread_target::prepare_to_store)
 572         (ravenscar_thread_target::mourn_inferior): Update.
 573         (ravenscar_inferior_created): Use "new" to create target.
 574         (ravenscar_thread_target::get_ada_task_ptid): Update.
 575         (_initialize_ravenscar): Don't initialize base_ptid.
 576         (ravenscar_ops): Remove global.
 577
 578 2019-02-15  Tom Tromey  <tromey@adacore.com>
 579
 580         * target.h (push_target): Declare new overload.
 581         * target.c (push_target): New overload, taking an rvalue reference.
 582         * remote.c (remote_target::open_1): Use push_target overload.
 583         * corelow.c (core_target_open): Use push_target overload.
 584
 585 2019-02-15  Tom Tromey  <tromey@adacore.com>
 586
 587         * ravenscar-thread.c (is_ravenscar_task)
 588         (ravenscar_task_is_currently_active): Return bool.
 589         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 590         (_initialize_ravenscar): Remove "(void)".
 591         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 592         Return bool.
 593
 594 2019-02-15  Tom Tromey  <tromey@adacore.com>
 595
 596         * ravenscar-thread.c (ravenscar_runtime_initializer)
 597         (has_ravenscar_runtime, get_running_thread_id)
 598         (ravenscar_thread_target::resume): Fix indentation.
 599
 600 2019-02-15  Tom Tromey  <tromey@adacore.com>
 601
 602         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 603         from ravenscar_arch_ops.
 604         (sparc_ravenscar_ops::fetch_registers)
 605         (sparc_ravenscar_ops::store_registers): Now methods.
 606         (sparc_ravenscar_prepare_to_store): Remove.
 607         (sparc_ravenscar_ops): Redefine.
 608         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 609         methods and destructor.  Remove members.
 610         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 611         (ravenscar_thread_target::store_registers)
 612         (ravenscar_thread_target::prepare_to_store): Update.
 613         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 614         Remove.
 615         (struct ppc_ravenscar_powerpc_ops): Derive from
 616         ravenscar_arch_ops.
 617         (ppc_ravenscar_powerpc_ops::fetch_registers)
 618         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 619         (ppc_ravenscar_powerpc_ops): Redefine.
 620         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 621         (ppc_ravenscar_e500_ops::fetch_registers)
 622         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 623         (ppc_ravenscar_e500_ops): Redefine.
 624         * aarch64-ravenscar-thread.c
 625         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 626         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 627         (aarch64_ravenscar_fetch_registers)
 628         (aarch64_ravenscar_store_registers): Now methods.
 629         (aarch64_ravenscar_ops): Redefine.
 630
 631 2019-02-15  Tom Tromey  <tromey@adacore.com>
 632
 633         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 634         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 635         (ravenscar_thread_target::stopped_by_watchpoint)
 636         (ravenscar_thread_target::stopped_data_address)
 637         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 638
 639 2019-02-15  Tom Tromey  <tromey@adacore.com>
 640
 641         * ravenscar-thread.c: Fix some typos.
 642
 643 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 644             Tom Tromey  <tromey@adacore.com>
 645
 646         * ada-lang.c (ada_exception_sal): Change addr_string to a
 647         std::string.
 648         (create_ada_exception_catchpoint): Update.
 649
 650 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 651             Tom Tromey  <tromey@adacore.com>
 652
 653         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 654         (bp_location_ops): Remove.
 655         (base_breakpoint_allocate_location): Update.
 656         (free_bp_location): Update.
 657         * ada-lang.c (class ada_catchpoint_location)
 658         <ada_catchpoint_location>: Remove ops parameter.
 659         (ada_catchpoint_location_dtor): Remove.
 660         (ada_catchpoint_location_ops): Remove.
 661         (allocate_location_exception): Update.
 662         * breakpoint.h (struct bp_location_ops): Remove.
 663         (class bp_location) <bp_location>: Remove bp_location_ops
 664         parameter.
 665         <~bp_location>: Add destructor.
 666         <ops>: Remove.
 667
 668 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 669             Pedro Alves  <palves@redhat.com>
 670
 671         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 672         'PATH_MAX'.
 673
 674 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 675             Samuel Thibault  <samuel.thibault@gnu.org>
 676             Thomas Schwinge  <thomas@codesourcery.com>
 677
 678         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 679         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 680
 681 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 682
 683         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 684         (check_empty): Use "const char *".
 685
 686         * gnu-nat.c (gnu_nat_target::detach): Instead of
 687         'detach_inferior (pid)' call
 688         'detach_inferior (find_inferior_pid (pid))'.
 689
 690         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 691         'nat/fork-inferior.o'.
 692         * gnu-nat.c: #include "nat/fork-inferior.h".
 693
 694         * gnu-nat.c (gnu_nat_target::detach): Instead of
 695         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 696         * gnu-nat.h: #include "inf-child.h".
 697         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 698         'i386_gnu_nat_target::fetch_registers'.
 699         (gnu_store_registers): Rename/move to
 700         'i386_gnu_nat_target::store_registers'.
 701
 702         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 703         * gnu-nat.h (mach_thread_info): New function.
 704         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 705
 706         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 707
 708 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 709
 710         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 711
 712 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 713
 714         * windows-nat.c (windows_add_thread): Add new parameter
 715         "main_thread_p" with default value set to false.  Update
 716         function documentation as well as all callers.
 717         (windows_delete_thread): Likewise.
 718         (fake_create_process): Update call to windows_add_thread.
 719         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 720         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 721         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 722         call to windows_delete_thread.
 723
 724 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 725
 726         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 727
 728 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 729
 730         * symfile.c (find_separate_debug_file): Use canonical path of
 731         sysroot with child_path instead of gdb_sysroot if it is valid.
 732
 733 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 734
 735         * symfile.c (find_separate_debug_file): Use child_path to
 736         determine if an object file is under a sysroot.
 737
 738 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 739
 740         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 741         unittests/child-path-selftests.c.
 742         * common/pathstuff.c (child_path): New function.
 743         * common/pathstuff.h (child_path): New prototype.
 744         * unittests/child-path-selftests.c: New file.
 745
 746 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 747
 748         * symfile.c (find_separate_debug_file): Look for separate debug
 749         files in debug directories under the sysroot.
 750
 751 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 752
 753         * symtab.h (struct minimal_symbol data_p): New const method.
 754         (struct minimal_symbol text_p): Likewise.
 755         * symtab.c (output_source_filename): Use file name style
 756         to print file name.
 757         (print_symbol_info): Likewise.
 758         (print_msymbol_info): Use address style to print addresses.
 759         Use function name style to print executable text symbols.
 760         (expand_symtab_containing_pc): Use data_p.
 761         (find_pc_sect_compunit_symtab): Likewise.
 762
 763 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 764
 765         * breakpoint.c (describe_other_breakpoints): Use address style
 766         to print addresses.
 767         (say_where): Likewise.
 768
 769 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 770
 771         * ada-typeprint.c (print_func_type): Print function name
 772         style to print function name.
 773         * c-typeprint.c (c_print_type_1): Likewise.
 774
 775 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 776
 777         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 778         for execve.
 779
 780 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 781
 782         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 783         type_stack.
 784
 785 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 786
 787         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 788         TYPE_CODE_REF types.
 789
 790 2019-02-08  Jim Wilson  <jimw@sifive.com>
 791
 792         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 793         (riscv_linux_fregset): New.
 794         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 795
 796 2019-02-07  Tom Tromey  <tom@tromey.com>
 797
 798         * thread.c (thread_cancel_execution_command): Update.
 799         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 800         methods.
 801         (struct thread_fsm_ops): Remove.
 802         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 803         (thread_fsm_should_stop, thread_fsm_return_value)
 804         (thread_fsm_set_finished, thread_fsm_finished_p)
 805         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 806         Don't declare.
 807         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 808         * infrun.c (clear_proceed_status_thread)
 809         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 810         (print_stop_event): Update.
 811         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 812         Add constructor.
 813         (step_command_fsm_ops): Remove.
 814         (new_step_command_fsm): Remove.
 815         (step_1): Update.
 816         (step_command_fsm::should_stop): Rename from
 817         step_command_fsm_should_stop.
 818         (step_command_fsm::clean_up): Rename from
 819         step_command_fsm_clean_up.
 820         (step_command_fsm::do_async_reply_reason): Rename from
 821         step_command_fsm_async_reply_reason.
 822         (struct until_next_fsm): Inherit from thread_fsm.  Add
 823         constructor.
 824         (until_next_fsm_ops): Remove.
 825         (new_until_next_fsm): Remove.
 826         (until_next_fsm::should_stop): Rename from
 827         until_next_fsm_should_stop.
 828         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 829         (until_next_fsm::do_async_reply_reason): Rename from
 830         until_next_fsm_async_reply_reason.
 831         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 832         constructor.  Change type of breakpoint.
 833         (finish_command_fsm_ops): Remove.
 834         (new_finish_command_fsm): Remove.
 835         (finish_command_fsm::should_stop): Rename from
 836         finish_command_fsm_should_stop.
 837         (finish_command_fsm::clean_up): Rename from
 838         finish_command_fsm_clean_up.
 839         (finish_command_fsm::return_value): Rename from
 840         finish_command_fsm_return_value.
 841         (finish_command_fsm::do_async_reply_reason): Rename from
 842         finish_command_fsm_async_reply_reason.
 843         (finish_command): Update.
 844         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 845         Add constructor.
 846         (call_thread_fsm_ops): Remove.
 847         (call_thread_fsm::call_thread_fsm): Rename from
 848         new_call_thread_fsm.
 849         (call_thread_fsm::should_stop): Rename from
 850         call_thread_fsm_should_stop.
 851         (call_thread_fsm::should_notify_stop): Rename from
 852         call_thread_fsm_should_notify_stop.
 853         (run_inferior_call, call_function_by_hand_dummy): Update.
 854         * cli/cli-interp.c (should_print_stop_to_console): Update.
 855         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 856         Add constructor.  Change type of location_breakpoint,
 857         caller_breakpoint.
 858         (until_break_fsm_ops): Remove.
 859         (new_until_break_fsm): Remove.
 860         (until_break_fsm::should_stop): Rename from
 861         until_break_fsm_should_stop.
 862         (until_break_fsm::clean_up): Rename from
 863         until_break_fsm_clean_up.
 864         (until_break_fsm::do_async_reply_reason): Rename from
 865         until_break_fsm_async_reply_reason.
 866         (until_break_command): Update.
 867         * thread-fsm.c: Remove.
 868         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 869
 870 2019-02-07  Tom Tromey  <tom@tromey.com>
 871
 872         * yy-remap.h: Add include guard.
 873         * xtensa-tdep.h: Add include guard.
 874         * xcoffread.h: Rename include guard.
 875         * varobj-iter.h: Add include guard.
 876         * tui/tui.h: Rename include guard.
 877         * tui/tui-winsource.h: Rename include guard.
 878         * tui/tui-wingeneral.h: Rename include guard.
 879         * tui/tui-windata.h: Rename include guard.
 880         * tui/tui-win.h: Rename include guard.
 881         * tui/tui-stack.h: Rename include guard.
 882         * tui/tui-source.h: Rename include guard.
 883         * tui/tui-regs.h: Rename include guard.
 884         * tui/tui-out.h: Rename include guard.
 885         * tui/tui-layout.h: Rename include guard.
 886         * tui/tui-io.h: Rename include guard.
 887         * tui/tui-hooks.h: Rename include guard.
 888         * tui/tui-file.h: Rename include guard.
 889         * tui/tui-disasm.h: Rename include guard.
 890         * tui/tui-data.h: Rename include guard.
 891         * tui/tui-command.h: Rename include guard.
 892         * tic6x-tdep.h: Add include guard.
 893         * target/waitstatus.h: Rename include guard.
 894         * target/wait.h: Rename include guard.
 895         * target/target.h: Rename include guard.
 896         * target/resume.h: Rename include guard.
 897         * target-float.h: Rename include guard.
 898         * stabsread.h: Add include guard.
 899         * rs6000-tdep.h: Add include guard.
 900         * riscv-fbsd-tdep.h: Add include guard.
 901         * regformats/regdef.h: Rename include guard.
 902         * record.h: Rename include guard.
 903         * python/python.h: Rename include guard.
 904         * python/python-internal.h: Rename include guard.
 905         * python/py-stopevent.h: Rename include guard.
 906         * python/py-ref.h: Rename include guard.
 907         * python/py-record.h: Rename include guard.
 908         * python/py-record-full.h: Rename include guard.
 909         * python/py-record-btrace.h: Rename include guard.
 910         * python/py-instruction.h: Rename include guard.
 911         * python/py-events.h: Rename include guard.
 912         * python/py-event.h: Rename include guard.
 913         * procfs.h: Add include guard.
 914         * proc-utils.h: Add include guard.
 915         * p-lang.h: Add include guard.
 916         * or1k-tdep.h: Rename include guard.
 917         * observable.h: Rename include guard.
 918         * nto-tdep.h: Rename include guard.
 919         * nat/x86-linux.h: Rename include guard.
 920         * nat/x86-linux-dregs.h: Rename include guard.
 921         * nat/x86-gcc-cpuid.h: Add include guard.
 922         * nat/x86-dregs.h: Rename include guard.
 923         * nat/x86-cpuid.h: Rename include guard.
 924         * nat/ppc-linux.h: Rename include guard.
 925         * nat/mips-linux-watch.h: Rename include guard.
 926         * nat/linux-waitpid.h: Rename include guard.
 927         * nat/linux-ptrace.h: Rename include guard.
 928         * nat/linux-procfs.h: Rename include guard.
 929         * nat/linux-osdata.h: Rename include guard.
 930         * nat/linux-nat.h: Rename include guard.
 931         * nat/linux-namespaces.h: Rename include guard.
 932         * nat/linux-btrace.h: Rename include guard.
 933         * nat/glibc_thread_db.h: Rename include guard.
 934         * nat/gdb_thread_db.h: Rename include guard.
 935         * nat/gdb_ptrace.h: Rename include guard.
 936         * nat/fork-inferior.h: Rename include guard.
 937         * nat/amd64-linux-siginfo.h: Rename include guard.
 938         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 939         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 940         * nat/aarch64-linux.h: Rename include guard.
 941         * nat/aarch64-linux-hw-point.h: Rename include guard.
 942         * mn10300-tdep.h: Add include guard.
 943         * mips-linux-tdep.h: Add include guard.
 944         * mi/mi-parse.h: Rename include guard.
 945         * mi/mi-out.h: Rename include guard.
 946         * mi/mi-main.h: Rename include guard.
 947         * mi/mi-interp.h: Rename include guard.
 948         * mi/mi-getopt.h: Rename include guard.
 949         * mi/mi-console.h: Rename include guard.
 950         * mi/mi-common.h: Rename include guard.
 951         * mi/mi-cmds.h: Rename include guard.
 952         * mi/mi-cmd-break.h: Rename include guard.
 953         * m2-lang.h: Add include guard.
 954         * location.h: Rename include guard.
 955         * linux-record.h: Rename include guard.
 956         * linux-nat.h: Add include guard.
 957         * linux-fork.h: Add include guard.
 958         * i386-darwin-tdep.h: Rename include guard.
 959         * hppa-linux-offsets.h: Add include guard.
 960         * guile/guile.h: Rename include guard.
 961         * guile/guile-internal.h: Rename include guard.
 962         * gnu-nat.h: Rename include guard.
 963         * gdb-stabs.h: Rename include guard.
 964         * frv-tdep.h: Add include guard.
 965         * f-lang.h: Add include guard.
 966         * event-loop.h: Add include guard.
 967         * darwin-nat.h: Rename include guard.
 968         * cp-abi.h: Rename include guard.
 969         * config/sparc/nm-sol2.h: Rename include guard.
 970         * config/nm-nto.h: Rename include guard.
 971         * config/nm-linux.h: Add include guard.
 972         * config/i386/nm-i386gnu.h: Rename include guard.
 973         * config/djgpp/nl_types.h: Rename include guard.
 974         * config/djgpp/langinfo.h: Rename include guard.
 975         * compile/gcc-cp-plugin.h: Add include guard.
 976         * compile/gcc-c-plugin.h: Add include guard.
 977         * compile/compile.h: Rename include guard.
 978         * compile/compile-object-run.h: Rename include guard.
 979         * compile/compile-object-load.h: Rename include guard.
 980         * compile/compile-internal.h: Rename include guard.
 981         * compile/compile-cplus.h: Rename include guard.
 982         * compile/compile-c.h: Rename include guard.
 983         * common/xml-utils.h: Rename include guard.
 984         * common/x86-xstate.h: Rename include guard.
 985         * common/version.h: Rename include guard.
 986         * common/vec.h: Rename include guard.
 987         * common/tdesc.h: Rename include guard.
 988         * common/selftest.h: Rename include guard.
 989         * common/scoped_restore.h: Rename include guard.
 990         * common/scoped_mmap.h: Rename include guard.
 991         * common/scoped_fd.h: Rename include guard.
 992         * common/safe-iterator.h: Rename include guard.
 993         * common/run-time-clock.h: Rename include guard.
 994         * common/refcounted-object.h: Rename include guard.
 995         * common/queue.h: Rename include guard.
 996         * common/ptid.h: Rename include guard.
 997         * common/print-utils.h: Rename include guard.
 998         * common/preprocessor.h: Rename include guard.
 999         * common/pathstuff.h: Rename include guard.
1000         * common/observable.h: Rename include guard.
1001         * common/netstuff.h: Rename include guard.
1002         * common/job-control.h: Rename include guard.
1003         * common/host-defs.h: Rename include guard.
1004         * common/gdb_wait.h: Rename include guard.
1005         * common/gdb_vecs.h: Rename include guard.
1006         * common/gdb_unlinker.h: Rename include guard.
1007         * common/gdb_unique_ptr.h: Rename include guard.
1008         * common/gdb_tilde_expand.h: Rename include guard.
1009         * common/gdb_sys_time.h: Rename include guard.
1010         * common/gdb_string_view.h: Rename include guard.
1011         * common/gdb_splay_tree.h: Rename include guard.
1012         * common/gdb_setjmp.h: Rename include guard.
1013         * common/gdb_ref_ptr.h: Rename include guard.
1014         * common/gdb_optional.h: Rename include guard.
1015         * common/gdb_locale.h: Rename include guard.
1016         * common/gdb_assert.h: Rename include guard.
1017         * common/filtered-iterator.h: Rename include guard.
1018         * common/filestuff.h: Rename include guard.
1019         * common/fileio.h: Rename include guard.
1020         * common/environ.h: Rename include guard.
1021         * common/common-utils.h: Rename include guard.
1022         * common/common-types.h: Rename include guard.
1023         * common/common-regcache.h: Rename include guard.
1024         * common/common-inferior.h: Rename include guard.
1025         * common/common-gdbthread.h: Rename include guard.
1026         * common/common-exceptions.h: Rename include guard.
1027         * common/common-defs.h: Rename include guard.
1028         * common/common-debug.h: Rename include guard.
1029         * common/cleanups.h: Rename include guard.
1030         * common/buffer.h: Rename include guard.
1031         * common/btrace-common.h: Rename include guard.
1032         * common/break-common.h: Rename include guard.
1033         * cli/cli-utils.h: Rename include guard.
1034         * cli/cli-style.h: Rename include guard.
1035         * cli/cli-setshow.h: Rename include guard.
1036         * cli/cli-script.h: Rename include guard.
1037         * cli/cli-interp.h: Rename include guard.
1038         * cli/cli-decode.h: Rename include guard.
1039         * cli/cli-cmds.h: Rename include guard.
1040         * charset-list.h: Add include guard.
1041         * buildsym-legacy.h: Rename include guard.
1042         * bfin-tdep.h: Add include guard.
1043         * ax.h: Rename include guard.
1044         * arm-linux-tdep.h: Add include guard.
1045         * arm-fbsd-tdep.h: Add include guard.
1046         * arch/xtensa.h: Rename include guard.
1047         * arch/tic6x.h: Add include guard.
1048         * arch/i386.h: Add include guard.
1049         * arch/arm.h: Rename include guard.
1050         * arch/arm-linux.h: Rename include guard.
1051         * arch/arm-get-next-pcs.h: Rename include guard.
1052         * arch/amd64.h: Add include guard.
1053         * arch/aarch64-insn.h: Rename include guard.
1054         * arch-utils.h: Rename include guard.
1055         * annotate.h: Add include guard.
1056         * amd64-darwin-tdep.h: Rename include guard.
1057         * aarch64-linux-tdep.h: Add include guard.
1058         * aarch64-fbsd-tdep.h: Add include guard.
1059         * aarch32-linux-nat.h: Add include guard.
1060
1061 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1062
1063         * macrotab.c (macro_define_internal): New function that
1064         factorizes macro_define_object_internal and macro_define_function
1065         code.
1066         (macro_define_object_internal): Use macro_define_internal.
1067         (macro_define_function): Likewise.
1068
1069 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1070
1071         * macrocmd.c (extract_identifier): Return
1072         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1073         callers.
1074
1075 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1076
1077         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1078
1079 2019-02-05  Tom Tromey  <tom@tromey.com>
1080
1081         * target.c (target_stack::unpush): Move assertion earlier.
1082
1083 2019-01-30  Tom Tromey  <tom@tromey.com>
1084
1085         PR python/23615:
1086         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1087         (gdbpy_parse_and_eval): Likewise.
1088         * python/python-internal.h (gdbpy_allow_threads): New class.
1089
1090 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1091
1092         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1093         (aarch64_fbsd_fpregmap): Move earlier.
1094         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1095         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1096         instead of individual calls to trad_frame_set_reg_addr.
1097         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1098         earlier.
1099         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1100         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1101         instead of individual calls to trad_frame_set_reg_addr.
1102
1103 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1104
1105         * CONTRIBUTE: Replace contribution list with wiki link.
1106
1107 2019-01-25  Tom Tromey  <tom@tromey.com>
1108
1109         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1110
1111 2019-01-25  Tom Tromey  <tom@tromey.com>
1112
1113         * xtensa-linux-nat.c: Fix common/ includes.
1114         * xml-support.h: Fix common/ includes.
1115         * xml-support.c: Fix common/ includes.
1116         * x86-linux-nat.c: Fix common/ includes.
1117         * windows-nat.c: Fix common/ includes.
1118         * varobj.h: Fix common/ includes.
1119         * varobj.c: Fix common/ includes.
1120         * value.c: Fix common/ includes.
1121         * valops.c: Fix common/ includes.
1122         * utils.c: Fix common/ includes.
1123         * unittests/xml-utils-selftests.c: Fix common/ includes.
1124         * unittests/utils-selftests.c: Fix common/ includes.
1125         * unittests/unpack-selftests.c: Fix common/ includes.
1126         * unittests/tracepoint-selftests.c: Fix common/ includes.
1127         * unittests/style-selftests.c: Fix common/ includes.
1128         * unittests/string_view-selftests.c: Fix common/ includes.
1129         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1130         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1131         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1132         * unittests/rsp-low-selftests.c: Fix common/ includes.
1133         * unittests/parse-connection-spec-selftests.c: Fix common/
1134         includes.
1135         * unittests/optional-selftests.c: Fix common/ includes.
1136         * unittests/offset-type-selftests.c: Fix common/ includes.
1137         * unittests/observable-selftests.c: Fix common/ includes.
1138         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1139         * unittests/memrange-selftests.c: Fix common/ includes.
1140         * unittests/memory-map-selftests.c: Fix common/ includes.
1141         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1142         * unittests/function-view-selftests.c: Fix common/ includes.
1143         * unittests/environ-selftests.c: Fix common/ includes.
1144         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1145         * unittests/common-utils-selftests.c: Fix common/ includes.
1146         * unittests/cli-utils-selftests.c: Fix common/ includes.
1147         * unittests/array-view-selftests.c: Fix common/ includes.
1148         * ui-file.c: Fix common/ includes.
1149         * tui/tui-io.c: Fix common/ includes.
1150         * tracepoint.h: Fix common/ includes.
1151         * tracepoint.c: Fix common/ includes.
1152         * tracefile-tfile.c: Fix common/ includes.
1153         * top.h: Fix common/ includes.
1154         * top.c: Fix common/ includes.
1155         * thread.c: Fix common/ includes.
1156         * target/waitstatus.h: Fix common/ includes.
1157         * target/waitstatus.c: Fix common/ includes.
1158         * target.h: Fix common/ includes.
1159         * target.c: Fix common/ includes.
1160         * target-memory.c: Fix common/ includes.
1161         * target-descriptions.c: Fix common/ includes.
1162         * symtab.h: Fix common/ includes.
1163         * symfile.c: Fix common/ includes.
1164         * stap-probe.c: Fix common/ includes.
1165         * spu-linux-nat.c: Fix common/ includes.
1166         * sparc-nat.c: Fix common/ includes.
1167         * source.c: Fix common/ includes.
1168         * solib.c: Fix common/ includes.
1169         * solib-target.c: Fix common/ includes.
1170         * ser-unix.c: Fix common/ includes.
1171         * ser-tcp.c: Fix common/ includes.
1172         * ser-pipe.c: Fix common/ includes.
1173         * ser-base.c: Fix common/ includes.
1174         * selftest-arch.c: Fix common/ includes.
1175         * s12z-tdep.c: Fix common/ includes.
1176         * rust-exp.y: Fix common/ includes.
1177         * rs6000-aix-tdep.c: Fix common/ includes.
1178         * riscv-tdep.c: Fix common/ includes.
1179         * remote.c: Fix common/ includes.
1180         * remote-notif.h: Fix common/ includes.
1181         * remote-fileio.h: Fix common/ includes.
1182         * remote-fileio.c: Fix common/ includes.
1183         * regcache.h: Fix common/ includes.
1184         * regcache.c: Fix common/ includes.
1185         * record-btrace.c: Fix common/ includes.
1186         * python/python.c: Fix common/ includes.
1187         * python/py-type.c: Fix common/ includes.
1188         * python/py-inferior.c: Fix common/ includes.
1189         * progspace.h: Fix common/ includes.
1190         * producer.c: Fix common/ includes.
1191         * procfs.c: Fix common/ includes.
1192         * proc-api.c: Fix common/ includes.
1193         * printcmd.c: Fix common/ includes.
1194         * ppc-linux-nat.c: Fix common/ includes.
1195         * parser-defs.h: Fix common/ includes.
1196         * osdata.c: Fix common/ includes.
1197         * obsd-nat.c: Fix common/ includes.
1198         * nat/x86-linux.c: Fix common/ includes.
1199         * nat/x86-linux-dregs.c: Fix common/ includes.
1200         * nat/x86-dregs.h: Fix common/ includes.
1201         * nat/x86-dregs.c: Fix common/ includes.
1202         * nat/ppc-linux.c: Fix common/ includes.
1203         * nat/mips-linux-watch.h: Fix common/ includes.
1204         * nat/mips-linux-watch.c: Fix common/ includes.
1205         * nat/linux-waitpid.c: Fix common/ includes.
1206         * nat/linux-ptrace.h: Fix common/ includes.
1207         * nat/linux-ptrace.c: Fix common/ includes.
1208         * nat/linux-procfs.c: Fix common/ includes.
1209         * nat/linux-personality.c: Fix common/ includes.
1210         * nat/linux-osdata.c: Fix common/ includes.
1211         * nat/linux-namespaces.c: Fix common/ includes.
1212         * nat/linux-btrace.h: Fix common/ includes.
1213         * nat/linux-btrace.c: Fix common/ includes.
1214         * nat/fork-inferior.c: Fix common/ includes.
1215         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1216         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1217         * nat/aarch64-linux.c: Fix common/ includes.
1218         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1219         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1220         * namespace.h: Fix common/ includes.
1221         * mips-linux-tdep.c: Fix common/ includes.
1222         * minsyms.c: Fix common/ includes.
1223         * mi/mi-parse.h: Fix common/ includes.
1224         * mi/mi-main.c: Fix common/ includes.
1225         * mi/mi-cmd-env.c: Fix common/ includes.
1226         * memrange.h: Fix common/ includes.
1227         * memattr.c: Fix common/ includes.
1228         * maint.h: Fix common/ includes.
1229         * maint.c: Fix common/ includes.
1230         * main.c: Fix common/ includes.
1231         * machoread.c: Fix common/ includes.
1232         * location.c: Fix common/ includes.
1233         * linux-thread-db.c: Fix common/ includes.
1234         * linux-nat.c: Fix common/ includes.
1235         * linux-fork.c: Fix common/ includes.
1236         * inline-frame.c: Fix common/ includes.
1237         * infrun.c: Fix common/ includes.
1238         * inflow.c: Fix common/ includes.
1239         * inferior.h: Fix common/ includes.
1240         * inferior.c: Fix common/ includes.
1241         * infcmd.c: Fix common/ includes.
1242         * inf-ptrace.c: Fix common/ includes.
1243         * inf-child.c: Fix common/ includes.
1244         * ia64-linux-nat.c: Fix common/ includes.
1245         * i387-tdep.c: Fix common/ includes.
1246         * i386-tdep.c: Fix common/ includes.
1247         * i386-linux-tdep.c: Fix common/ includes.
1248         * i386-linux-nat.c: Fix common/ includes.
1249         * i386-go32-tdep.c: Fix common/ includes.
1250         * i386-fbsd-tdep.c: Fix common/ includes.
1251         * i386-fbsd-nat.c: Fix common/ includes.
1252         * guile/scm-type.c: Fix common/ includes.
1253         * guile/guile.c: Fix common/ includes.
1254         * go32-nat.c: Fix common/ includes.
1255         * gnu-nat.c: Fix common/ includes.
1256         * gdbthread.h: Fix common/ includes.
1257         * gdbarch-selftests.c: Fix common/ includes.
1258         * gdb_usleep.c: Fix common/ includes.
1259         * gdb_select.h: Fix common/ includes.
1260         * gdb_bfd.c: Fix common/ includes.
1261         * gcore.c: Fix common/ includes.
1262         * fork-child.c: Fix common/ includes.
1263         * findvar.c: Fix common/ includes.
1264         * fbsd-nat.c: Fix common/ includes.
1265         * event-top.c: Fix common/ includes.
1266         * event-loop.c: Fix common/ includes.
1267         * dwarf2read.c: Fix common/ includes.
1268         * dwarf2loc.c: Fix common/ includes.
1269         * dwarf2-frame.c: Fix common/ includes.
1270         * dwarf-index-cache.c: Fix common/ includes.
1271         * dtrace-probe.c: Fix common/ includes.
1272         * disasm-selftests.c: Fix common/ includes.
1273         * defs.h: Fix common/ includes.
1274         * csky-tdep.c: Fix common/ includes.
1275         * cp-valprint.c: Fix common/ includes.
1276         * cp-support.h: Fix common/ includes.
1277         * cp-support.c: Fix common/ includes.
1278         * corelow.c: Fix common/ includes.
1279         * completer.h: Fix common/ includes.
1280         * completer.c: Fix common/ includes.
1281         * compile/compile.c: Fix common/ includes.
1282         * compile/compile-loc2c.c: Fix common/ includes.
1283         * compile/compile-cplus-types.c: Fix common/ includes.
1284         * compile/compile-cplus-symbols.c: Fix common/ includes.
1285         * command.h: Fix common/ includes.
1286         * cli/cli-dump.c: Fix common/ includes.
1287         * cli/cli-cmds.c: Fix common/ includes.
1288         * charset.c: Fix common/ includes.
1289         * build-id.c: Fix common/ includes.
1290         * btrace.h: Fix common/ includes.
1291         * btrace.c: Fix common/ includes.
1292         * breakpoint.h: Fix common/ includes.
1293         * breakpoint.c: Fix common/ includes.
1294         * ax.h:
1295         (enum agent_op): Fix common/ includes.
1296         * ax-general.c (struct aop_map): Fix common/ includes.
1297         * ax-gdb.c: Fix common/ includes.
1298         * auxv.c: Fix common/ includes.
1299         * auto-load.c: Fix common/ includes.
1300         * arm-tdep.c: Fix common/ includes.
1301         * arch/riscv.c: Fix common/ includes.
1302         * arch/ppc-linux-common.c: Fix common/ includes.
1303         * arch/i386.c: Fix common/ includes.
1304         * arch/arm.c: Fix common/ includes.
1305         * arch/arm-linux.c: Fix common/ includes.
1306         * arch/arm-get-next-pcs.c: Fix common/ includes.
1307         * arch/amd64.c: Fix common/ includes.
1308         * arch/aarch64.c: Fix common/ includes.
1309         * arch/aarch64-insn.c: Fix common/ includes.
1310         * arch-utils.c: Fix common/ includes.
1311         * amd64-windows-tdep.c: Fix common/ includes.
1312         * amd64-tdep.c: Fix common/ includes.
1313         * amd64-sol2-tdep.c: Fix common/ includes.
1314         * amd64-obsd-tdep.c: Fix common/ includes.
1315         * amd64-nbsd-tdep.c: Fix common/ includes.
1316         * amd64-linux-tdep.c: Fix common/ includes.
1317         * amd64-linux-nat.c: Fix common/ includes.
1318         * amd64-fbsd-tdep.c: Fix common/ includes.
1319         * amd64-fbsd-nat.c: Fix common/ includes.
1320         * amd64-dicos-tdep.c: Fix common/ includes.
1321         * amd64-darwin-tdep.c: Fix common/ includes.
1322         * agent.c: Fix common/ includes.
1323         * ada-lang.h: Fix common/ includes.
1324         * ada-lang.c: Fix common/ includes.
1325         * aarch64-tdep.c: Fix common/ includes.
1326
1327 2019-01-25  Tom Tromey  <tom@tromey.com>
1328
1329         * common/create-version.sh: Use common/version.h.
1330
1331 2019-01-24  Pedro Alves  <palves@redhat.com>
1332
1333         * infrun.c (signal_stop, signal_print, signal_program)
1334         (signal_catch, signal_pass): Now arrays instead of pointers.
1335         (update_signals_program_target, do_target_resume)
1336         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1337         * linux-nat.c (linux_nat_target::pass_signals)
1338         (linux_nat_target::create_inferior, linux_nat_target::attach):
1339         Adjust.
1340         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1341         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1342         * procfs.c (procfs_target::pass_signals): Adjust.
1343         * record-full.c (record_full_target::resume): Adjust.
1344         * remote.c (remote_target::pass_signals)
1345         (remote_target::program_signals): Adjust.
1346         * target-debug.h (target_debug_print_signals): Now takes a
1347         gdb::array_view as parameter.  Adjust.
1348         * target.h (target_ops) <pass_signals, program_signals>: Replace
1349         pointer and length parameters with gdb::array_view.
1350         (target_pass_signals, target_program_signals): Likewise.
1351         * target-delegates.c: Regenerate.
1352
1353 2019-01-24  Pedro Alves  <palves@redhat.com>
1354
1355         * common/forward-scope-exit.h
1356         (forward_scope_exit::forward_scope_exit): Pass arguments to
1357         m_bind_function directly, instead of creating a std::bind and
1358         copying that.
1359
1360 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1361
1362         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1363         for static members.
1364         (pass_in_v_vfp_candidate): Likewise.
1365
1366 2019-01-23  Tom Tromey  <tom@tromey.com>
1367             Pedro Alves  <palves@redhat.com>
1368
1369         * regcache.c (class regcache_invalidator): Remove.
1370         (regcache::raw_write): Use make_scope_exit.
1371
1372 2019-01-23  Tom Tromey  <tom@tromey.com>
1373
1374         * ui-out.h (class ui_out_emit_type): Update comment.
1375
1376 2019-01-23  Tom Tromey  <tom@tromey.com>
1377
1378         * infrun.c (fetch_inferior_event): Update comment.
1379
1380 2019-01-23  Tom Tromey  <tom@tromey.com>
1381             Pedro Alves  <palves@redhat.com>
1382
1383         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1384         parameter.
1385         (fetch_inferior_event): Use SCOPE_EXIT.
1386
1387
1388 2019-01-23  Tom Tromey  <tom@tromey.com>
1389             Pedro Alves  <palves@redhat.com>
1390
1391         * infrun.c (disable_thread_events): Delete.
1392         (stop_all_threads): Use SCOPE_EXIT.
1393
1394 2019-01-23  Tom Tromey  <tom@tromey.com>
1395             Pedro Alves  <palves@redhat.com>
1396
1397         * symfile.c: Include forward-scope-exit.h.
1398         (clear_symtab_users_cleanup): Replace forward declaration with
1399         a FORWARD_SCOPE_EXIT.
1400         (syms_from_objfile_1): Use the forward_scope_exit and
1401         gdb::optional instead of cleanup_function.
1402         (reread_symbols): Use the forward_scope_exit instead of
1403         cleanup_function.
1404         (clear_symtab_users_cleanup): Remove function.
1405
1406 2019-01-23  Tom Tromey  <tom@tromey.com>
1407             Pedro Alves  <palves@redhat.com>
1408
1409         * linux-nat.c: Include scope-exit.h.
1410         (cleanup_target_stop): Remove.
1411         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1412         SCOPE_EXIT.
1413
1414 2019-01-23  Tom Tromey  <tom@tromey.com>
1415             Pedro Alves  <palves@redhat.com>
1416
1417         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1418         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1419
1420 2019-01-23  Tom Tromey  <tom@tromey.com>
1421             Andrew Burgess  <andrew.burgess@embecosm.com>
1422             Pedro Alves  <palves@redhat.com>
1423
1424         * infrun.c (fetch_inferior_event): Use scope_exit.
1425         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1426         * top.c (execute_command): Use scope_exit.
1427         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1428         * utils.c (do_bpstat_clear_actions_cleanup)
1429         (make_bpstat_clear_actions_cleanup): Remove.
1430
1431 2019-01-23  Tom Tromey  <tom@tromey.com>
1432             Pedro Alves  <palves@redhat.com>
1433
1434         * infrun.c: Include "common/scope-exit.h"
1435         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1436         (wait_for_inferior): Use SCOPE_EXIT.
1437         (fetch_inferior_event): Use scope_exit.
1438
1439 2019-01-23  Tom Tromey  <tom@tromey.com>
1440             Pedro Alves  <palves@redhat.com>
1441
1442         * breakpoint.c (create_breakpoint): Remove cleanup.
1443
1444 2019-01-23  Tom Tromey  <tom@tromey.com>
1445             Andrew Burgess  <andrew.burgess@embecosm.com>
1446             Pedro Alves  <palves@redhat.com>
1447
1448 2019-01-23  Pedro Alves  <palves@redhat.com>
1449
1450         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1451
1452 2019-01-23  Pedro Alves  <palves@redhat.com>
1453             Andrew Burgess  <andrew.burgess@embecosm.com>
1454
1455         * gdbthread.h: Include "common/forward-scope-exit.h".
1456         (scoped_finish_thread_state): Redefine custom class in terms of
1457         forward_scope_exit.
1458
1459 2019-01-23  Pedro Alves  <palves@redhat.com>
1460             Andrew Burgess  <andrew.burgess@embecosm.com>
1461
1462         * common/forward-scope-exit.h: New file.
1463
1464 2019-01-23  Pedro Alves  <palves@redhat.com>
1465             Andrew Burgess  <andrew.burgess@embecosm.com>
1466             Tom Tromey  <tom@tromey.com>
1467
1468         * common/scope-exit.h: New file.
1469
1470 2019-01-23  Pedro Alves  <palves@redhat.com>
1471
1472         * common/preprocessor.h (ESC): Rename to ...
1473         (ESC_PARENS): ... this.
1474         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1475         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1476
1477 2019-01-23  Tom Tromey  <tom@tromey.com>
1478
1479         * language.h (class scoped_switch_to_sym_language_if_auto):
1480         Initialize m_lang in both cases.
1481
1482 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1483
1484         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1485         with XCNEW.
1486
1487 2019-01-22  Tom Tromey  <tom@tromey.com>
1488
1489         * corelow.c: Do not include sys/file.h.
1490
1491 2019-01-22  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-wingeneral.h: Include gdb_curses.h.
1494
1495 2019-01-22  Tom Tromey  <tom@tromey.com>
1496
1497         * source-cache.h (class source_cache) <get_source_lines,
1498         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1499
1500 2019-01-22  Tom Tromey  <tom@tromey.com>
1501
1502         * remote-fileio.h (struct remote_target): Declare.
1503
1504 2019-01-22  Tom Tromey  <tom@tromey.com>
1505
1506         * python/py-arch.c: Do not include py-ref.h.
1507         * python/py-bpevent.c: Do not include py-ref.h.
1508         * python/py-cmd.c: Do not include py-ref.h.
1509         * python/py-continueevent.c: Do not include py-ref.h.
1510         * python/py-event.h: Do not include py-ref.h.
1511         * python/py-evtregistry.c: Do not include py-ref.h.
1512         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1513         * python/py-frame.c: Do not include py-ref.h.
1514         * python/py-framefilter.c: Do not include py-ref.h.
1515         * python/py-function.c: Do not include py-ref.h.
1516         * python/py-infevents.c: Do not include py-ref.h.
1517         * python/py-linetable.c: Do not include py-ref.h.
1518         * python/py-objfile.c: Do not include py-ref.h.
1519         * python/py-param.c: Do not include py-ref.h.
1520         * python/py-prettyprint.c: Do not include py-ref.h.
1521         * python/py-progspace.c: Do not include py-ref.h.
1522         * python/py-symbol.c: Do not include py-ref.h.
1523         * python/py-symtab.c: Do not include py-ref.h.
1524         * python/py-type.c: Do not include py-ref.h.
1525         * python/py-unwind.c: Do not include py-ref.h.
1526         * python/py-utils.c: Do not include py-ref.h.
1527         * python/py-value.c: Do not include py-ref.h.
1528         * python/py-varobj.c: Do not include py-ref.h.
1529         * python/py-xmethods.c: Do not include py-ref.h.
1530         * python/python.c: Do not include py-ref.h.
1531         * varobj.c: Do not include py-ref.h.
1532
1533 2019-01-22  Tom Tromey  <tom@tromey.com>
1534
1535         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1536         keyword for bcache.
1537
1538 2019-01-22  Tom Tromey  <tom@tromey.com>
1539
1540         * compile/compile-cplus-types.c: Remove a comment by #include.
1541
1542 2019-01-22  Tom Tromey  <tom@tromey.com>
1543
1544         * compile/gcc-c-plugin.h: Include compile-internal.h.
1545
1546 2019-01-22  Tom Tromey  <tom@tromey.com>
1547
1548         * stabsread.c (EXTERN): Do not define.
1549         (symnum, next_symbol_text_func, processing_gcc_compilation)
1550         (within_function, global_sym_chain, global_stabs)
1551         (previous_stab_code, this_object_header_files)
1552         (n_this_object_header_files)
1553         (n_allocated_this_object_header_files): Define.
1554         * stabsread.h (EXTERN): Never define.  Use "extern".
1555
1556 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1557
1558         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1559         history_value.
1560
1561 2019-01-21  Tom Tromey  <tom@tromey.com>
1562
1563         * ui-out.c: Fix includes.
1564         * tui/tui-source.c: Fix includes.
1565         * target.c: Fix includes.
1566         * remote.c: Fix includes.
1567         * regcache.c: Fix includes.
1568         * python/py-block.c: Fix includes.
1569         * printcmd.c: Fix includes.
1570         * or1k-tdep.c: Fix includes.
1571         * mi/mi-main.c: Fix includes.
1572         * m32r-tdep.c: Fix includes.
1573         * csky-tdep.c: Fix includes.
1574         * compile/compile-cplus-types.c: Fix includes.
1575         * cli/cli-interp.c: Fix includes.
1576
1577 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1578
1579         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1580         for padding.
1581
1582 2019-01-16  Tom Tromey  <tom@tromey.com>
1583
1584         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1585         earlier.
1586         (struct objfile) <msymbols_range>: Move from top level.
1587         <msymbols>: New method.
1588         (class objfile_msymbols): Remove.
1589         * symtab.c (default_collect_symbol_completion_matches_break_on):
1590         Update.
1591         * symmisc.c (dump_msymbols): Update.
1592         * stabsread.c (scan_file_globals): Update.
1593         * objc-lang.c (info_selectors_command, info_classes_command)
1594         (find_methods): Update.
1595         * minsyms.c (find_solib_trampoline_target): Update.
1596         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1597         * coffread.c (coff_symfile_read): Update.
1598         * ada-lang.c (ada_lookup_simple_minsym)
1599         (ada_collect_symbol_completion_matches): Update.
1600
1601 2019-01-16  Tom Tromey  <tom@tromey.com>
1602
1603         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1604         type.  Remove no-argument constructor.
1605         <iterator::operator++>: Simplify.
1606         <begin>: Update.
1607         <end>: Use minimal_symbol_count.
1608
1609 2019-01-16  Tom Tromey  <tom@tromey.com>
1610
1611         * objfiles.h (struct objfile) <psymtabs>: New method.
1612         (class objfile_psymtabs): Remove.
1613         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1614         typedef.
1615         <range>: New method.
1616         (require_partial_symbols): Change return type.
1617         * psymtab.c (require_partial_symbols)
1618         (psym_expand_symtabs_matching): Update.
1619         * mdebugread.c (parse_partial_symbols): Update.
1620         * dbxread.c (dbx_end_psymtab): Update.
1621
1622 2019-01-15  Tom Tromey  <tom@tromey.com>
1623
1624         * symtab.c (lookup_objfile_from_block)
1625         (lookup_symbol_in_objfile_symtabs)
1626         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1627         (find_line_symtab, info_sources_command)
1628         (default_collect_symbol_completion_matches_break_on)
1629         (make_source_files_completion_list): Update.
1630         * symmisc.c (print_objfile_statistics, dump_objfile)
1631         (maintenance_print_symbols, maintenance_info_symtabs)
1632         (maintenance_check_symtabs, maintenance_info_line_tables):
1633         Update.
1634         * source.c (select_source_symtab)
1635         (forget_cached_source_info_for_objfile): Update.
1636         * objfiles.h (class objfile_compunits): Remove.
1637         (struct objfile) <compunits_range>: New typedef.
1638         (compunits): New method.
1639         * objfiles.c (objfile_relocate1): Update.
1640         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1641         * maint.c (count_symtabs_and_blocks): Update.
1642         * linespec.c (iterate_over_all_matching_symtabs): Update.
1643         * cp-support.c (add_symbol_overload_list_qualified): Update.
1644         * coffread.c (coff_symtab_read): Update.
1645         * ada-lang.c (add_nonlocal_symbols)
1646         (ada_collect_symbol_completion_matches)
1647         (ada_add_global_exceptions): Update.
1648
1649 2019-01-15  Tom Tromey  <tom@tromey.com>
1650
1651         * progspace.h (program_space) <objfiles_safe_range>: New
1652         typedef.
1653         <objfiles_safe>: New method.
1654         * objfiles.h (class all_objfiles_safe): Remove.
1655         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1656         * jit.c (jit_inferior_exit_hook): Update.
1657
1658 2019-01-17  Tom Tromey  <tom@tromey.com>
1659
1660         * progspace.h (program_space) <objfiles_range>: New typedef.
1661         <objfiles>: New method.
1662         <objfiles_head>: Rename from objfiles.
1663         (object_files): Update.
1664         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1665         * guile/scm-pretty-print.c
1666         (ppscm_find_pretty_printer_from_objfiles): Update.
1667         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1668         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1669         Update.
1670         * python/py-progspace.c (pspy_get_objfiles): Update.
1671         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1672         Update.
1673         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1674         (objfpy_lookup_objfile_by_build_id): Update.
1675         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1676         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1677         Update.
1678         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1679         (expand_symtab_containing_pc, lookup_objfile_from_block)
1680         (lookup_static_symbol, basic_lookup_transparent_type)
1681         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1682         (find_line_symtab, info_sources_command)
1683         (default_collect_symbol_completion_matches_break_on)
1684         (make_source_files_completion_list, find_main_name): Update.
1685         * symmisc.c (print_symbol_bcache_statistics)
1686         (print_objfile_statistics, maintenance_print_symbols)
1687         (maintenance_print_msymbols, maintenance_print_objfiles)
1688         (maintenance_info_symtabs, maintenance_check_symtabs)
1689         (maintenance_expand_symtabs, maintenance_info_line_tables):
1690         Update.
1691         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1692         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1693         (map_overlay_command, unmap_overlay_command)
1694         (simple_overlay_update, expand_symtabs_matching)
1695         (map_symbol_filenames): Update.
1696         * symfile-debug.c (set_debug_symfile): Update.
1697         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1698         Update.
1699         * source.c (select_source_symtab, forget_cached_source_info):
1700         Update.
1701         * solib.c (solib_read_symbols): Update.
1702         * solib-spu.c (append_ocl_sos): Update.
1703         * psymtab.c (maintenance_print_psymbols)
1704         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1705         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1706         * printcmd.c (info_symbol_command): Update.
1707         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1708         Update.
1709         * objfiles.h (class all_objfiles): Remove.
1710         * objfiles.c (have_partial_symbols, have_full_symbols)
1711         (have_minimal_symbols, qsort_cmp, update_section_map)
1712         (shared_objfile_contains_address_p)
1713         (default_iterate_over_objfiles_in_search_order): Update.
1714         * objc-lang.c (info_selectors_command, info_classes_command)
1715         (find_methods): Update.
1716         * minsyms.c (find_solib_trampoline_target): Update.
1717         * maint.c (maintenance_info_sections)
1718         (maintenance_translate_address, count_symtabs_and_blocks):
1719         Update.
1720         * main.c (captured_main_1): Update.
1721         * linux-thread-db.c (try_thread_db_load_from_pdir)
1722         (has_libpthread): Update.
1723         * linespec.c (iterate_over_all_matching_symtabs)
1724         (search_minsyms_for_name): Update.
1725         * jit.c (jit_find_objf_with_entry_addr): Update.
1726         * hppa-tdep.c (find_unwind_entry)
1727         (hppa_lookup_stub_minimal_symbol): Update.
1728         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1729         Update.
1730         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1731         (elf_gnu_ifunc_resolve_by_got): Update.
1732         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1733         * dwarf-index-write.c (save_gdb_index_command): Update.
1734         * cp-support.c (add_symbol_overload_list_qualified): Update.
1735         * breakpoint.c (create_overlay_event_breakpoint)
1736         (create_longjmp_master_breakpoint)
1737         (create_std_terminate_master_breakpoint)
1738         (create_exception_master_breakpoint): Update.
1739         * blockframe.c (find_pc_partial_function): Update.
1740         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1741         (ada_collect_symbol_completion_matches)
1742         (ada_add_global_exceptions): Update.
1743
1744 2019-01-17  Tom Tromey  <tom@tromey.com>
1745
1746         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1747         declare VEC.
1748         (solib_target_parse_libraries): Change return type.
1749         (library_list_start_segment, library_list_start_section)
1750         (library_list_end_library, library_list_start_library); Update.
1751         (solib_target_free_library_list): Remove.
1752         (solib_target_parse_libraries): Remove cleanup.  Change return
1753         type.
1754         (solib_target_current_sos): Update.
1755
1756 2019-01-17  Tom Tromey  <tromey@bapiya>
1757
1758         * valprint.c: Replace "the the" with "the".
1759         * symtab.c: Replace "the the" with "the".
1760         * solib.c: Replace "the the" with "the".
1761         * solib-dsbt.c: Replace "the the" with "the".
1762         * linespec.c: Replace "the the" with "the".
1763         * dwarf2loc.h: Replace "the the" with "the".
1764         * amd64-windows-tdep.c: Replace "the the" with "the".
1765         * aarch64-tdep.c: Replace "the the" with "the".
1766
1767 2019-01-16  Keith Seitz  <keiths@redhat.com>
1768
1769         PR gdb/23773
1770         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1771         <builder>: Rename to ..
1772         <m_builder>: ... this and make private.
1773         (dwarf2_cu::get_builder): New method.  Change all users of
1774         `builder' to use this method.
1775         (dwarf2_start_symtab): Move to ...
1776         (dwarf2_cu::start_symtab): ... here.  Update all callers
1777         (setup_type_unit_groups): Move to ...
1778         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1779         callers.
1780         (dwarf2_cu::reset_builder): New method.
1781         (process_full_compunit, process_full_type_unit): Use
1782         dwarf2_cu::reset_builder.
1783         (follow_die_offset): Record the ancestor CU if it is different
1784         from the followed DIE's CU.
1785         (follow_die_sig_1): Likewise.
1786
1787 2019-01-15  Tom Tromey  <tom@tromey.com>
1788
1789         * remote.c (class remote_state) <buf>: Now a char_vector.
1790         <buf_size>: Remove.
1791         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1792         parameter.
1793         (remote_target::getpkt_or_notif_sane_1)
1794         (remote_target::getpkt_sane)
1795         (remote_target::getpkt_or_notif_sane): Likewise.
1796         (class remote_target) <putpkt>: New overload.
1797         (remote_target::read_frame): Change type of "buf_p".  Remove
1798         sizeof_p parameter.
1799         (packet_ok): New overload.
1800         (packet_check_result): New overload.
1801         Update all uses.
1802
1803 2019-01-14  Tom Tromey  <tom@tromey.com>
1804
1805         * remote-notif.c (handle_notification, remote_notif_ack)
1806         (remote_notif_parse): Make "buf" const.
1807         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1808         const.
1809         (remote_notif_parse, remote_notif_ack, handle_notification):
1810         Likewise.
1811         * remote.c (remote_notif_stop_parse): Make "buf" const.
1812         (remote_target::remote_parse_stop_reply): Make "buf" const.
1813         (remote_notif_stop_ack): Make "buf" const.
1814
1815 2019-01-14  Tom Tromey  <tom@tromey.com>
1816
1817         * remote.c (remote_console_output): Make parameter const.
1818
1819 2019-01-14  Tom Tromey  <tom@tromey.com>
1820
1821         * target-debug.h (target_debug_print_signals): Constify.
1822         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1823         * procfs.c (procfs_target::pass_signals): Update.
1824         * linux-nat.c (linux_nat_target::pass_signals): Update.
1825         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1826         * target-delegates.c: Rebuild.
1827         * remote.c (remote_target::program_signals): Update.
1828         (remote_target::pass_signals): Update.
1829         * target.c (target_pass_signals): Constify argument.
1830         (target_program_signals): Likewise.
1831         * target.h (struct target_ops) <pass_signals, program_signals>:
1832         Constify argument.
1833         (target_pass_signals, target_program_signals): Constify argument.
1834
1835 2019-01-14  Tom Tromey  <tom@tromey.com>
1836
1837         PR tui/28819:
1838         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1839
1840 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1841
1842         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1843         field.
1844         * rs6000-tdep.c: Include reggroups.h.
1845         (IS_V_ALIAS_PSEUDOREG): Define.
1846         (rs6000_register_name): Return names for the "vX" aliases.
1847         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1848         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1849         aliases.  Call default_register_reggroup_p for all other
1850         pseudo-registers.
1851         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1852         New functions.
1853         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1854         Handle "vX" aliases.
1855         (v_alias_pseudo_register_collect): New function.
1856         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1857         (rs6000_gdbarch_init): Initialize "vX" aliases as
1858         pseudo-registers.  Restore registration of
1859         rs6000_pseudo_register_reggroup_p with
1860         set_tdesc_pseudo_register_reggroup_p.
1861
1862 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1863
1864         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1865         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1866         set_gdbarch_num_pseudo_regs.
1867
1868 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1869
1870         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1871         Remove arg prefixname, add do_set and do_show.
1872         Add member functions set_list and show_list.
1873         * cli/cli-style.c (class cli_style_option): Update accordingly.
1874         (style_set_list): Move to file scope.
1875         (style_show_list): Likewise.
1876         (set_style): Call help_list.
1877         (show_style): Call cmd_show_list.
1878         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1879         Update to use the new macro.
1880
1881 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1882
1883         * ada-lang.c (_initialize_ada_language): Expand the help text
1884         for the "catch exception" command.
1885
1886 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1887
1888         * symtab.c (matching_obj_sections): Initialize obj,
1889         declare it closer to its usage.
1890
1891 2019-01-10  Tom Tromey  <tom@tromey.com>
1892
1893         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1894         (basic_inf_threads_range): Remove.
1895         (inf_threads_range, inf_non_exited_threads_range)
1896         (safe_inf_threads_range): Use next_adapter.
1897
1898 2019-01-10  Keith Seitz  <keiths@redhat.com>
1899
1900         PR gdb/23712
1901         PR symtab/23010
1902         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1903         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1904
1905 2019-01-10  Keith Seitz  <keiths@redhat.com>
1906
1907         PR gdb/23712
1908         PR symtab/23010
1909         * dictionary.c (pending_to_vector): Remove.
1910         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1911         Remove _1 suffix, replacing functions of the same name.  Update
1912         all callers.
1913         (dict_create_hashed, dict_create_hashed_expandable)
1914         (dict_create_linear, dict_create_linear_expandable, dict_free)
1915         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1916         Make functions static.
1917
1918 2019-01-10  Keith Seitz  <keiths@redhat.com>
1919
1920         PR gdb/23712
1921         PR symtab/23010
1922         * dictionary.h (struct dictionary): Replace declaration with
1923         multidictionary.
1924         (dict_create_hashed, dict_create_hashed_expandable)
1925         (dict_create_linear, dict_create_linear_expandable)
1926         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1927         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1928         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1929         taking multidictionary argument.
1930         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1931         * block.h (struct block) <dict>: Change to multidictionary
1932         and rename `multidict'.
1933         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1934         symmisc.c: Update all dictionary references to multidictionary.
1935
1936 2019-01-10  Keith Seitz  <keiths@redhat.com>
1937
1938         PR gdb/23712
1939         PR symtab/23010
1940         * dictionary.c: Include unordered_map.
1941         (pending_to_vector): New function.
1942         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1943         Rewrite the non-"_1" functions to take vector instead
1944         of linked list.
1945         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1946         "new" _1 versions of the same name.
1947         (multidictionary): Define.
1948         (std::hash<enum language): New definition.
1949         (collate_pending_symbols_by_language, mdict_create_hashed)
1950         (mdict_create_hashed_expandable, mdict_create_linear)
1951         (mdict_create_linear_expandable, mdict_free)
1952         (find_language_dictionary, create_new_language_dictionary)
1953         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1954         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1955         (mdict_size, mdict_empty): New functions.
1956         * dictionary.h (mdict_iterator): Define.
1957
1958 2019-01-10  Pedro Alves  <palves@redhat.com>
1959
1960         * breakpoint.c (read_uploaded_action)
1961         (create_tracepoint_from_upload): Adjust to use
1962         gdb::unique_xmalloc_ptr.
1963         * ctf.c (ctf_write_uploaded_tp):
1964         (SET_ARRAY_FIELD): Use emplace_back.
1965         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1966         * tracefile-tfile.c (tfile_write_uploaded_tp):
1967         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1968         gdb::unique_xmalloc_ptr.
1969         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1970         at_string, cond_string, cmd_strings>: Replace char pointers
1971         with gdb::unique_xmalloc_ptr.
1972
1973 2019-01-10  Pedro Alves  <palves@redhat.com>
1974
1975         * solib-target.c (library_list_start_library): Don't xstrdup name.
1976
1977 2019-01-10  Pedro Alves  <palves@redhat.com>
1978
1979         * mdebugread.c (parse_partial_symbols): Use
1980         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1981
1982 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1983
1984         * linux-fork.c (scoped_switch_fork_info)
1985         <~scoped_switch_fork_info>: Fix incorrect variable name.
1986
1987 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1988
1989         * linux-fork.c (scoped_switch_fork_info)
1990         <scoped_switch_fork_info>: Make explicit.
1991         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1992
1993 2019-01-10  Tom Tromey  <tom@tromey.com>
1994
1995         * objfiles.h (objfile::reset_psymtabs): Update.
1996         * objfiles.c (objfile::objfile): Update.
1997         * psymtab.h (psymtab_storage::obstack): Update.
1998         (psymtab_storage::m_obstack): Use gdb::optional.
1999         (class psymtab_storage): Update comment.  Remove objfile
2000         parameter.
2001         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2002
2003 2019-01-10  Tom Tromey  <tom@tromey.com>
2004
2005         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2006         <free_psymtabs>: Now private.
2007         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2008         (allocate_psymtab): Use new method.
2009
2010 2019-01-10  Tom Tromey  <tom@tromey.com>
2011
2012         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2013         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2014         * mdebugread.c (parse_partial_symbols): Use
2015         allocate_dependencies.
2016         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2017         allocate_dependencies.
2018         (process_psymtab_comp_unit_reader)
2019         (build_type_psymtab_dependencies): Likewise.
2020         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2021
2022 2019-01-10  Tom Tromey  <tom@tromey.com>
2023
2024         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2025         PSYMBOL_SET_LANGUAGE.
2026         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2027
2028 2019-01-10  Tom Tromey  <tom@tromey.com>
2029
2030         * psymtab.h (psymtab_storage::obstack): New method.
2031         <m_obstack>: Rename from obstack; now private.
2032         * psymtab.c (psymtab_storage): Update.
2033         * dwarf2read.c (create_addrmap_from_index)
2034         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2035         Update.
2036
2037 2019-01-10  Tom Tromey  <tom@tromey.com>
2038
2039         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2040         * objfiles.h (objfile::reset_psymtabs): New method.
2041
2042 2019-01-10  Tom Tromey  <tom@tromey.com>
2043
2044         * symmisc.c (print_symbol_bcache_statistics): Update.
2045         (print_objfile_statistics): Update.
2046         * symfile.c (reread_symbols): Update.
2047         * psymtab.h (class psymtab_storage): New.
2048         * psymtab.c (psymtab_storage): New constructor.
2049         (~psymtab_storage): New destructor.
2050         (require_partial_symbols): Update.
2051         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2052         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2053         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2054         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2055         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2056         (start_psymtab_common, end_psymtab_common)
2057         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2058         (allocate_psymtab): Update.
2059         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2060         Update.
2061         (dump_psymtab_addrmap, maintenance_print_psymbols)
2062         (maintenance_check_psymtabs): Update.
2063         (class objfile_psymtabs): Move to objfiles.h.
2064         * psympriv.h (discard_psymtab): Now inline.
2065         (psymtab_discarder::psymtab_discarder): Update.
2066         (psymtab_discarder::~psymtab_discarder): Update.
2067         (ALL_OBJFILE_PSYMTABS): Rewrite.
2068         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2069         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2070         Remove fields.
2071         <partial_symtabs>: New field.
2072         (class objfile_psymtabs): Move from psymtab.h.  Update.
2073         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2074         psymbol_cache.
2075         (objfile::~objfile): Don't destroy psymbol_cache.
2076         * mdebugread.c (parse_partial_symbols): Update.
2077         * dwarf2read.c (create_addrmap_from_index)
2078         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2079         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2080         (add_partial_subprogram, dwarf2_ranges_read): Update.
2081         * dwarf-index-write.c (write_address_map)
2082         (write_one_signatured_type, recursively_write_psymbols)
2083         (class debug_names, class debug_names, write_psymtabs_to_index):
2084         Update.
2085
2086 2019-01-10  Tom Tromey  <tom@tromey.com>
2087
2088         * symtab.h (SYMBOL_SET_NAMES): Update.
2089         (symbol_set_names): Update.
2090         (MSYMBOL_SET_NAMES): Update.
2091         * symtab.c (symbol_set_names): Change argument to be an
2092         objfile_per_bfd_storage.
2093         * psymtab.c (add_psymbol_to_bcache): Update.
2094         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2095
2096 2019-01-10  Tom Tromey  <tom@tromey.com>
2097
2098         * symtab.c (create_demangled_names_hash): Change argument to be an
2099         objfile_per_bfd_storage.
2100         (symbol_set_names): Update.
2101
2102 2019-01-10  Tom Tromey  <tom@tromey.com>
2103
2104         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2105         init_psymbol_list.
2106         * psymtab.c (init_psymbol_list): Do nothing if already called.
2107         * psympriv.h (init_psymbol_list): Add comment.
2108         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2109         init_psymbol_list.
2110         * dbxread.c (dbx_symfile_read): Unconditionally call
2111         init_psymbol_list.
2112
2113 2019-01-10  Tom Tromey  <tom@tromey.com>
2114
2115         * xcoffread.c (scan_xcoff_symtab): Update.
2116         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2117         "where".
2118         * mdebugread.c (parse_partial_symbols)
2119         (handle_psymbol_enumerators): Update.
2120         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2121         * dbxread.c (read_dbx_symtab): Update.
2122         * psympriv.h (psymbol_placement): New enum.
2123         (add_psymbol_to_list): Update.
2124
2125 2019-01-10  Tom Tromey  <tom@tromey.com>
2126
2127         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2128         static_psymbols parameters.
2129         (scan_xcoff_symtab): Update.
2130         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2131         static_psymbols parameters.
2132         * psympriv.h (start_psymtab_common): Update.
2133         * mdebugread.c (parse_partial_symbols): Update.
2134         * dwarf2read.c (create_partial_symtab): Update.
2135         * dbxread.c (read_dbx_symtab): Update.
2136         (start_psymtab): Remove global_psymbols and static_psymbols
2137         parameters.
2138
2139 2019-01-10  Tom Tromey  <tom@tromey.com>
2140
2141         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2142         * psymtab.c (allocate_psymtab): Add comment.
2143         * psympriv.h (allocate_psymtab): Add comment.
2144         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2145         initializations.
2146         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2147
2148 2019-01-10  Tom Tromey  <tom@tromey.com>
2149
2150         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2151         Don't declare.
2152         * mipsread.c: Include mdebugread.h.
2153         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2154         Declare.
2155         * elfread.c: Include mdebugread.h.
2156
2157 2019-01-09  Tom Tromey  <tom@tromey.com>
2158
2159         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2160         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2161         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2162         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2163         (psym_lookup_symbol, psym_find_last_source_symtab)
2164         (psym_forget_cached_source_info, psym_print_stats)
2165         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2166         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2167         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2168         (psym_find_compunit_symtab_by_address)
2169         (maintenance_print_psymbols, maintenance_info_psymtabs)
2170         (maintenance_check_psymtabs): Use ranged for.
2171         * psymtab.h (class objfile_psymtabs): New.
2172         (require_partial_symbols): Return objfile_psymtabs.
2173         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2174
2175 2019-01-09  Tom Tromey  <tom@tromey.com>
2176
2177         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2178         (find_pc_mapped_section, list_overlays_command)
2179         (map_overlay_command, unmap_overlay_command)
2180         (simple_overlay_update): Use all_objfiles.
2181         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2182         * printcmd.c (info_symbol_command): Use all_objfiles.
2183         * objfiles.h (ALL_OBJSECTIONS): Remove.
2184         * maint.c (maintenance_translate_address): Use all_objfiles.
2185         * gcore.c (gcore_create_callback): Use all_objfiles.
2186         (objfile_find_memory_regions): Likewise.
2187
2188 2019-01-09  Tom Tromey  <tom@tromey.com>
2189
2190         * symtab.c (find_line_symtab, info_sources_command)
2191         (make_source_files_completion_list): Use objfile_compunits.
2192         * source.c (select_source_symtab): Use objfile_compunits.
2193         * objfiles.h (struct objfile): Update comment.
2194         (ALL_OBJFILES): Remove.
2195         (ALL_FILETABS): Remove.
2196         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2197         objfile_compunits.
2198
2199 2019-01-09  Tom Tromey  <tom@tromey.com>
2200
2201         * symmisc.c (print_objfile_statistics, dump_objfile)
2202         (maintenance_print_symbols): Use compunit_filetabs.
2203         * source.c (forget_cached_source_info_for_objfile): Use
2204         compunit_filetabs.
2205         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2206         (ALL_FILETABS): Use compunit_filetabs.
2207         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2208         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2209
2210 2019-01-09  Tom Tromey  <tom@tromey.com>
2211
2212         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2213         (compunit_filetabs): New.
2214         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2215         compunit_filetabs.
2216         (info_sources_command, make_source_files_completion_list): Remove
2217         declaration.
2218         * symmisc.c (print_objfile_statistics, dump_objfile)
2219         (maintenance_print_symbols): Remove declaration.
2220         (maintenance_info_symtabs): Use compunit_filetabs.
2221         (maintenance_info_line_tables): Likewise.
2222         * source.c (select_source_symtab): Change local variable name.
2223         (forget_cached_source_info_for_objfile): Remove declaration.
2224         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2225         * objfiles.c (objfile_relocate1): Remove declaration.
2226         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2227         declaration.
2228         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2229         * coffread.c (coff_symtab_read): Remove declaration.
2230         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2231         compunit_filetabs.
2232
2233 2019-01-09  Tom Tromey  <tom@tromey.com>
2234
2235         * symtab.c (lookup_objfile_from_block)
2236         (find_pc_sect_compunit_symtab, search_symbols)
2237         (default_collect_symbol_completion_matches_break_on): Use
2238         objfile_compunits.
2239         * objfiles.h (ALL_COMPUNITS): Remove.
2240         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2241         * cp-support.c (add_symbol_overload_list_qualified): Use
2242         objfile_compunits.
2243         * ada-lang.c (ada_collect_symbol_completion_matches)
2244         (ada_add_global_exceptions): Use objfile_compunits.
2245
2246 2019-01-09  Tom Tromey  <tom@tromey.com>
2247
2248         * source.c (select_source_symtab)
2249         (forget_cached_source_info_for_objfile): Remove declaration.
2250         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2251         declaration.
2252         * maint.c (count_symtabs_and_blocks): Remove declaration.
2253         * cp-support.c (add_symbol_overload_list_qualified): Remove
2254         declaration.
2255         * coffread.c (coff_symtab_read): Remove declaration.
2256         * symtab.c (lookup_symbol_in_objfile_symtabs)
2257         (basic_lookup_transparent_type_1): Use objfile_compunits.
2258         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2259         (info_sources_command, search_symbols)
2260         (default_collect_symbol_completion_matches_break_on)
2261         (make_source_files_completion_list): Remove declaration.
2262         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2263         (ada_collect_symbol_completion_matches)
2264         (ada_add_global_exceptions): Remove declaration.
2265         * linespec.c (iterate_over_all_matching_symtabs): Use
2266         objfile_compunits.
2267         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2268         (class objfile_compunits): New.
2269         (ALL_COMPUNITS): Use objfile_compunits.
2270         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2271         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2272         objfile_compunits.
2273         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2274
2275 2019-01-09  Tom Tromey  <tom@tromey.com>
2276
2277         * symtab.c (search_symbols)
2278         (default_collect_symbol_completion_matches_break_on): Use
2279         objfile_msymbols.
2280         * ada-lang.c (ada_lookup_simple_minsym)
2281         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2282         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2283         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2284         objfile_msymbols.
2285         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2286         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2287         * objc-lang.c (find_methods): Use objfile_msymbols.
2288         (info_selectors_command, info_classes_command): Likewise.
2289         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2290         * objfiles.h (class objfile_msymbols): New.
2291         (ALL_OBJFILE_MSYMBOLS): Remove.
2292         (ALL_MSYMBOLS): Remove.
2293
2294 2019-01-09  Tom Tromey  <tom@tromey.com>
2295
2296         * common/next-iterator.h (next_adapter): Add Iterator template
2297         parameter.
2298         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2299         (class all_objfiles_safe): New.
2300         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2301         * objfiles.c (put_objfile_before): Update comment.
2302         (add_separate_debug_objfile): Likewise.
2303         (free_all_objfiles): Use all_objfiles_safe.
2304         (objfile_purge_solibs): Likewise.
2305
2306 2019-01-09  Tom Tromey  <tom@tromey.com>
2307
2308         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2309         (expand_symtab_containing_pc, lookup_static_symbol)
2310         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2311         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2312         all_objfiles.
2313         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2314         * breakpoint.c (create_overlay_event_breakpoint)
2315         (create_longjmp_master_breakpoint)
2316         (create_std_terminate_master_breakpoint)
2317         (create_exception_master_breakpoint): Use all_objfiles.
2318         * linux-thread-db.c (try_thread_db_load_from_pdir)
2319         (has_libpthread): Use all_objfiles.
2320         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2321         * linespec.c (iterate_over_all_matching_symtabs)
2322         (search_minsyms_for_name): Use all_objfiles.
2323         * maint.c (maintenance_info_sections): Use all_objfiles.
2324         * main.c (captured_main_1): Use all_objfiles.
2325         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2326         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2327         * guile/scm-pretty-print.c
2328         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2329         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2330         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2331         (maintenance_print_msymbols): Use all_objfiles.
2332         * source.c (select_source_symtab): Use all_objfiles.
2333         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2334         * symfile.c (remove_symbol_file_command)
2335         (expand_symtabs_matching, map_symbol_filenames): Use
2336         all_objfiles.
2337         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2338         all_objfiles.
2339         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2340         * objc-lang.c (find_methods): Use all_objfiles.
2341         * objfiles.c (have_partial_symbols, have_full_symbols)
2342         (have_minimal_symbols, qsort_cmp)
2343         (default_iterate_over_objfiles_in_search_order): Use
2344         all_objfiles.
2345         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2346         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2347         (maintenance_check_psymtabs): Use all_objfiles.
2348         (ALL_PSYMTABS): Remove.
2349         * compile/compile-object-run.c (do_module_cleanup): Use
2350         all_objfiles.
2351         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2352         * cp-support.c (add_symbol_overload_list_qualified): Use
2353         all_objfiles.
2354         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2355         Use all_objfiles.
2356         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2357         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2358         all_objfiles.
2359         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2360         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2361         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2362         Uses all_objfiles.
2363         * solib.c (solib_read_symbols): Use all_objfiles
2364
2365 2019-01-09  Tom Tromey  <tom@tromey.com>
2366
2367         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2368         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2369         all_objfiles.
2370         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2371         * symmisc.c (print_symbol_bcache_statistics)
2372         (print_objfile_statistics, maintenance_print_objfiles)
2373         (maintenance_info_symtabs, maintenance_check_symtabs)
2374         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2375         all_objfiles.
2376         * source.c (forget_cached_source_info): Use all_objfiles.
2377         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2378         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2379         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2380         * objfiles.c (update_section_map): Use all_objfiles.
2381         (shared_objfile_contains_address_p): Likewise.
2382         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2383         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2384
2385 2019-01-09  Tom Tromey  <tom@tromey.com>
2386
2387         * common/next-iterator.h: New file.
2388         * objfiles.h (class all_objfiles): New.
2389         (struct objfile_iterator): New.
2390
2391 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2392
2393         * NEWS: Move the description of the changed "frame", "select-frame",
2394          and "info frame" commands to the Changed commands section.
2395
2396 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2397
2398         * gdbtypes.c (check_stub_method_group): Remove handling of old
2399         mangling schemes.
2400         * linespec.c (find_methods): Likewise.
2401         * stabsread.c (read_member_functions): Likewise.
2402         * valops.c (search_struct_method): Likewise.
2403         (value_struct_elt_for_reference): Likewise.
2404         * NEWS: Mention this change.
2405
2406 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2407
2408         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2409         print_source_lines.
2410         * source.c (print_source_lines_base): Update line number check.
2411         (print_source_lines): New function.
2412         (source_lines_range::source_lines_range): New function.
2413         * source.h (class source_lines_range): New class.
2414         (print_source_lines): New declaration.
2415
2416 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2417
2418         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2419
2420 2019-01-08  Tom Tromey  <tom@tromey.com>
2421             Simon Marchi  <simon.marchi@ericsson.com>
2422
2423         PR gdb/24060
2424         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2425         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2426         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2427         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2428         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2429         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2430
2431 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2432
2433         * source.c (select_source_symtab): Move header comment to
2434         declaration in source.h.
2435         (forget_cached_source_info_for_objfile): Likewise.
2436         (forget_cached_source_info): Likewise.
2437         (identify_source_line): Likewise.
2438         * source.h (identify_source_line): Move declaration from symtab.h
2439         and add comment from source.c
2440         (print_source_lines): Likewise.
2441         (forget_cached_source_info_for_objfile): Likewise.
2442         (forget_cached_source_info): Likewise.
2443         (select_source_symtab): Likewise.
2444         (enum print_source_lines_flag): Move definition from symtab.h.
2445         * symtab.h (identify_source_line): Move declaration to source.h.
2446         (print_source_lines): Likewise.
2447         (forget_cached_source_info_for_objfile): Likewise.
2448         (forget_cached_source_info): Likewise.
2449         (select_source_symtab): Likewise.
2450         (enum print_source_lines_flag): Move definition to source.h.
2451         * tui/tui-hooks.c: Add 'source.h' include.
2452
2453 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2454
2455         * source.c (print_source_lines_base): Handle requests to print
2456         reverse line number sequences, and guard against empty lines
2457         string.
2458
2459 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2460
2461         * source.c (print_source_lines_base): Fix skip of '\r' if next
2462         character is '\n'.
2463
2464 2019-01-06  Tom Tromey  <tom@tromey.com>
2465
2466         * c-exp.y (struct c_parse_state) <macro_original_text,
2467         expansion_obstack>: New member.
2468         (macro_original_text, expansion_obstack): Remove globals.
2469         (scan_macro_expansion, scanning_macro_expansion)
2470         (finished_macro_expansion): Update.
2471         (scan_macro_cleanup): Remove.
2472         (yylex, c_parse): Update.
2473
2474 2019-01-06  Tom Tromey  <tom@tromey.com>
2475
2476         * c-exp.y (struct c_parse_state) <strings>: New member.
2477         (operator_stoken): Update.
2478
2479 2019-01-06  Tom Tromey  <tom@tromey.com>
2480
2481         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2482         (union type_stack_elt) <typelist_val>: Now a pointer to
2483         std::vector.
2484         (type_stack_cleanup): Don't declare.
2485         (push_typelist): Update.
2486         * parse.c (pop_typelist): Return a std::vector.
2487         (push_typelist): Take a std::vector.
2488         (follow_types): Update.  Do not free args.
2489         (type_stack_cleanup): Remove.
2490         * c-exp.y (struct c_parse_state): New.
2491         (cpstate): New global.
2492         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2493         (nonempty_typelist): Update.
2494         (func_mod): Create a new vector.
2495         (c_parse): Create a c_parse_state.
2496         (check_parameter_typelist): Do not delete params.
2497         (function_method): Update.  Do not delete type_list.
2498
2499 2019-01-06  Tom Tromey  <tom@tromey.com>
2500
2501         PR gdb/28155:
2502         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2503         check_typedef.
2504         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2505         (print_return_value): Likewise.
2506
2507 2019-01-05  Tom Tromey  <tom@tromey.com>
2508
2509         * contrib/cleanup_check.py: Remove.
2510         * contrib/gcc-with-excheck: Remove.
2511         * contrib/exsummary.py: Remove.
2512         * contrib/excheck.py: Remove.
2513
2514 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2515
2516         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2517         NULL. Initialize tpprev to NULL instead of assigning it
2518         to NULL on the next statement.
2519         * windows-nat.c (windows_delete_thread): Remove check for
2520         main_thread_id before printing thread exit notifications.
2521         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2522         Remove thread ID check against main_thread_id.
2523         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2524         windows_delete_thread.
2525         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2526
2527 2019-01-04  Tom Tromey  <tom@tromey.com>
2528
2529         * compile/compile.c (_initialize_compile): Use upper case for
2530         metasyntactic variables.
2531         * symmisc.c (_initialize_symmisc): Use upper case for
2532         metasyntactic variables.
2533         * psymtab.c (_initialize_psymtab): Use upper case for
2534         metasyntactic variables.
2535         * demangle.c (demangle_command): Use upper case for metasyntactic
2536         variables.
2537         (_initialize_demangler): Likewise.
2538         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2539         variables.
2540
2541 2019-01-03  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2544
2545 2019-01-03  Tom Tromey  <tom@tromey.com>
2546
2547         * python/py-symtab.c (salpy_str): Update.
2548         (struct salpy_sal_object) <symtab>: Now a PyObject.
2549         (salpy_dealloc): Update.
2550         (del_objfile_sal): Use gdbpy_ref.
2551
2552 2019-01-03  Tom Tromey  <tom@tromey.com>
2553
2554         * python/py-type.c (convert_field): Use new_reference.  Return
2555         gdbpy_ref.
2556         (make_fielditem): Return gdbpy_ref.
2557         (typy_fields): Update.
2558         (typy_getitem): Update.
2559         (field_name): Return gdbpy_ref.  Use new_reference.
2560         (typy_iterator_iternext): Update.
2561
2562 2019-01-03  Tom Tromey  <tom@tromey.com>
2563
2564         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2565
2566 2019-01-03  Tom Tromey  <tom@tromey.com>
2567
2568         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2569         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2570         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2571         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2572         (pspy_set_type_printers): Likewise.
2573         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2574         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2575         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2576         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2577         (objfpy_set_type_printers): Likewise.
2578
2579 2019-01-03  Tom Tromey  <tom@tromey.com>
2580
2581         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2582         (gdbpy_print_stack): Use gdbpy_err_fetch.
2583         * python/python-internal.h (class gdbpy_err_fetch): New class.
2584         (class gdbpy_enter) <m_error_type, m_error_value,
2585         m_error_traceback>: Remove.
2586         <m_error>: New member.
2587         (gdbpy_exception_to_string): Don't declare.
2588         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2589         * python/py-value.c (convert_value_from_python): Use
2590         gdbpy_err_fetch.
2591         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2592         gdbpy_exception_to_string.
2593         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2594         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2595         gdbpy_err_fetch.
2596
2597 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2598
2599         * linux-nat.c (delete_lwp_cleanup): Delete.
2600         (struct lwp_deleter): New struct.
2601         (lwp_info_up): New typedef.
2602         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2603         lwp_info_up.
2604
2605 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * linux-fork.c (class scoped_switch_fork_info): New class.
2608         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2609
2610 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2611
2612         * valops.c (find_overload_match): Remove use of null_cleanup, and
2613         calls to do_cleanups.
2614
2615 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2616
2617         * compile/compile-cplus-types.c
2618         (compile_cplus_instance::decl_name): Handle changes to
2619         cp_func_name.
2620         * cp-support.c (cp_func_name): Update header comment, update
2621         return type.
2622         * cp-support.h (cp_func_name): Update return type in declaration.
2623         * valops.c (find_overload_match): Move temp_func local to top
2624         level of function and change its type.  Use temp_func to hold and
2625         delete temporary string obtained from cp_func_name.
2626
2627 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2628
2629         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2630         gdb::char_vector, remove cleanup, and update uses of `msg`.
2631
2632 2019-01-03  Jim Wilson  <jimw@sifive.com>
2633
2634         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2635
2636 2019-01-02  Tom Tromey  <tom@tromey.com>
2637
2638         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2639         (tdesc_parse_xml): Remove cleanups.
2640         * target-descriptions.h (make_cleanup_free_target_description):
2641         Don't declare.
2642         (target_desc_deleter): New struct.
2643         (target_desc_up): New typedef.
2644         * target-descriptions.c (target_desc_deleter::operator()): Rename
2645         from free_target_description.
2646         (make_cleanup_free_target_description): Remove.
2647
2648 2019-01-02  Tom Tromey  <tom@tromey.com>
2649
2650         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2651         constructor, destructor.
2652         (linespec_parser): Remove typedef.
2653         (~linespec_parser): Rename from linespec_parser_delete.
2654         (linespec_lex_to_end, linespec_complete_label)
2655         (linespec_complete): Update.
2656         (decode_line_full): Remove cleanups.
2657         (decode_line_1): Update.
2658
2659 2019-01-02  Tom Tromey  <tom@tromey.com>
2660
2661         * python/python-internal.h (inferior_to_inferior_object): Change
2662         return type.
2663         * python/py-exitedevent.c (create_exited_event_object): Update.
2664         * python/py-inferior.c (inferior_to_inferior_object): Return
2665         gdbpy_ref.
2666         (python_new_inferior, python_inferior_deleted)
2667         (thread_to_thread_object, delete_thread_object)
2668         (build_inferior_list, gdbpy_selected_inferior): Update.
2669         * python/py-infthread.c (create_thread_object): Update.  Also fail
2670         if inferior_to_inferior_object fails.
2671
2672 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2673
2674         * inferior.h (class inferior) <displaced_step_state>: New field.
2675         * infrun.h (struct displaced_step_state): Move here from
2676         infrun.c.  Initialize fields, add constructor.
2677         <inf>: Remove field.
2678         <reset>: New method.
2679         * infrun.c (struct displaced_step_inferior_state): Move to
2680         infrun.h.
2681         (displaced_step_inferior_states): Remove.
2682         (get_displaced_stepping_state): Adust.
2683         (displaced_step_in_progress_any_inferior): Adjust.
2684         (displaced_step_in_progress_thread): Adjust.
2685         (displaced_step_in_progress): Adjust.
2686         (add_displaced_stepping_state): Remove.
2687         (get_displaced_step_closure_by_addr): Adjust.
2688         (remove_displaced_stepping_state): Remove.
2689         (infrun_inferior_exit): Call displaced_step_state.reset.
2690         (use_displaced_stepping): Don't check for NULL.
2691         (displaced_step_prepare_throw): Call
2692         get_displaced_stepping_state.
2693         (displaced_step_fixup): Don't check for NULL.
2694         (prepare_for_detach): Don't check for NULL.
2695
2696 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2697
2698         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2699          in case of call that did not complete.
2700
2701 2019-01-02  Andrey Utkin  <autkin@undo.io>
2702
2703         * symfile.c (find_separate_debug_file): Fix search of debug files for
2704         remote debuggee.
2705
2706 2019-01-02  Tom Tromey  <tom@tromey.com>
2707
2708         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2709         indentation.
2710         * python/py-frame.c (frapy_older): Remove cast.
2711         (frapy_newer): Likewise.
2712         * python/py-breakpoint.c (local_setattro): Remove cast.
2713         * python/py-arch.c (archpy_name): Remove local variable.
2714         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2715
2716 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2717
2718         * unittests/basic_string_view/element_access/char/empty.cc:
2719         Fix year range in copyright header.
2720
2721 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2722
2723         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2724         Delete.
2725         <operator==>: Update with for removed field.
2726         <hash>: Likewise.
2727         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2728         <isa_features>: ...this.
2729         <abi_features>: New field.
2730         (riscv_isa_flen): Update comment.
2731         (riscv_abi_xlen): New declaration.
2732         (riscv_abi_flen): New declaration.
2733         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2734         isa_features.
2735         (riscv_abi_xlen): New function.
2736         (riscv_isa_flen): Update to get answer from isa_features.
2737         (riscv_abi_flen): New function.
2738         (riscv_has_fp_abi): Update to get answer from abi_features.
2739         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2740         xlen and flen.
2741         (riscv_call_info) <xlen, flen>: Update comment.
2742         (riscv_call_arg_struct): Remove invalid assertions
2743         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2744         is removed.
2745         (riscv_gdbarch_init): Gather isa features and abi features
2746         separately, ensure both match on the gdbarch when reusing an old
2747         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2748         a target with 64-bit float hardware.
2749
2750 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2751
2752         * source.c (search_command_helper): Stop reverse search
2753         when line 1 has been searched.
2754
2755 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2756
2757         * record-full.c (record_full_base_target::close): Rewrite
2758         record_full_core_buf_list free logic.
2759
2760 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2761
2762         * break-catch-syscall.c (print_one_catch_syscall): xfree
2763         the last text.
2764
2765 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2766
2767         * top.c (print_gdb_version): Update Copyright year in version
2768         message.
2769
2770 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2771
2772         Update copyright year range in all GDB files.
2773
2774 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2775
2776         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2777
2778 For older changes see ChangeLog-2018.
2779 \f
2780 Local Variables:
2781 mode: change-log
2782 left-margin: 8
2783 fill-column: 74
2784 version-control: never
2785 coding: utf-8
2786 End:
2787