gdb/ChangeLog

   1 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         PR gdb/18644:
   4         * f-lang.c (build_fortran_types): Handle the case where
   5         gdbarch_floatformat_for_type returns a nullptr.
   6
   7 2019-05-21  Tom de Vries  <tdevries@suse.de>
   8
   9         PR cli/24587
  10         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
  11
  12 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  13
  14         PR gdb/18644:
  15         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
  16         16-byte floats.
  17         * i386-tdep.c (i386_floatformat_for_type): Use
  18         floatformats_ia64_quad for the 16-byte floating point component
  19         within a fortran 32-byte complex number.
  20
  21 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  22
  23         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
  24         delete default constructor.
  25         (find_partial_die): Update to return const struct.
  26         (partial_die_parent_scope): Move variable declaration into scope
  27         of its use and change its type to auto.
  28         (guess_partial_die_structure_name): Likewise.
  29         (partial_die_info::fixup): Likewise.
  30
  31 2019-05-17  Tom Tromey  <tromey@adacore.com>
  32
  33         * source.c (find_and_open_source): Remove cast.
  34
  35 2019-05-17  Tom Tromey  <tromey@adacore.com>
  36
  37         * annotate.c (annotate_source): Make "filename" const.
  38         * annotate.h (annotate_source): Use const.
  39
  40 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  41
  42         * disasm.c (set_disassembler_options): Send errors to stderr.
  43
  44 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  45
  46         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
  47         (cli_interp_base::set_logging): Check debug_redirect.
  48         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
  49         * cli/cli-logging.c (debug_redirect): Add static variable.
  50         (pop_output_files): Add default param.
  51         (handle_redirections): Print debug setting.
  52         (show_logging_command): Likewise.
  53         (_initialize_cli_logging): Add debugredirect command.
  54         * interps.c (current_interp_set_logging): Add debug_redirect
  55         parameter.
  56         * interps.h (set_logging): Add debug_redirect parameter.
  57         (current_interp_set_logging): Likewise.
  58         * mi/mi-common.h: Likewise.
  59         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
  60
  61 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  62             Tom Tromey  <tromey@adacore.com>
  63
  64         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
  65         directly.
  66         * cli/cli-interp.h (make_logging_output): Remove declaration.
  67         * cli/cli-logging.c (make_logging_output): Remove function.
  68         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
  69         directly.
  70         * ui-file.c (tee_file::tee_file): Remove bools.
  71         (tee_file::~tee_file): Remove deletes.
  72         * ui-file.h (tee_file): Remove bools.
  73
  74 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
  75
  76         * mi/mi-cmds.h (mi_cmd_complete): New function.
  77         * mi/mi-main.c (mi_cmd_complete): Likewise.
  78         * mi/mi-cmds.c: Define new MI command -complete.
  79         * NEWS: Mention new -complete command.
  80
  81 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
  82
  83         * completer.h (complete): New function.
  84         * completer.c (complete): Likewise.
  85         * cli/cli-cmds.c: (complete_command): Update to use new complete()
  86         function defined in completer.h.
  87
  88 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
  89
  90        * MAINTAINERS (Write After Approval): Add myself.
  91
  92 2019-05-17  Tom de Vries  <tdevries@suse.de>
  93
  94         PR gdb/24094
  95         * dwarf2read.c (struct cu_partial_die_info): New struct.
  96         (find_partial_die): Return cu_partial_die_info.
  97         (partial_die_parent_scope, guess_partial_die_structure_name)
  98         (partial_die_info::fixup): Handle new return type of find_partial_die.
  99
 100 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 101
 102         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 103         "std::string", simplifying the algorithm.
 104
 105 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 106
 107         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 108         (stap_static_probe_ops::get_probes): Likewise.
 109
 110 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 111
 112         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 113         '-')" and "else if".
 114         (stap_parse_single_operand): Join checks for
 115         "gdbarch_stap_parse_special_token_p" and
 116         "gdbarch_stap_parse_special_token" in the same "if" statement.
 117         Invert check when verifying for operation on register
 118         displacement.
 119
 120 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 121
 122         * stap-probe.c (stap_get_opcode): Update comment.
 123         (stap_get_expected_argument_type): Likewise.
 124         (handle_stap_probe): Likewise.
 125
 126 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 127
 128         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 129         return type to 'bool'.  Adjust comment.  Use 'bool' when
 130         appropriate.
 131         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 132         * stap-probe.c (stap_parse_argument_1): Likewise.
 133         (stap_is_operator): Likewise.
 134         (stap_is_generic_prefix): Likewise.
 135         (stap_is_register_prefix): Likewise.
 136         (stap_is_register_indirection_prefix): Likewise.
 137         (stap_is_integer_prefix): Likewise.
 138         (stap_generic_check_suffix): Likewise.
 139         (stap_check_integer_suffix): Likewise.
 140         (stap_check_register_suffix): Likewise.
 141         (stap_check_register_indirection_suffix): Likewise.
 142         (stap_parse_register_operand): Likewise.
 143         (stap_parse_single_operand): Likewise.
 144         (stap_parse_argument_1): Likewise.
 145         (stap_probe::get_argument_count): Likewise.
 146         (stap_is_operator): Likewise.
 147
 148 2019-05-16  Tom Tromey  <tromey@adacore.com>
 149
 150         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 151         keyword to foreach.
 152
 153 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 154
 155         * linux-thread-db.c (try_thread_db_load_1): Change return type
 156         to bool.
 157         (try_thread_db_load): Likewise.
 158         (try_thread_db_load_from_pdir_1): Likewise.
 159         (try_thread_db_load_from_pdir): Likewise.
 160         (try_thread_db_load_from_sdir): Likewise.
 161         (try_thread_db_load_from_dir): Likewise.
 162         (thread_db_load_search): Likewise.
 163         (has_libpthread): Likewise.
 164         (thread_db_load): Likewise.
 165
 166 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 167
 168         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 169         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 170         NULL, and complain/return if that's the case.
 171
 172 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 173
 174         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 175         (advance, posn, abstract_read_memory): New functions.
 176         [struct mem_read_abstraction]: New struct.
 177         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 178
 179 2019-05-14  Tom Tromey  <tromey@adacore.com>
 180
 181         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 182         value is not lval_memory.
 183
 184 2019-05-14  Tom Tromey  <tromey@adacore.com>
 185
 186         * solib.c (info_sharedlibrary_command): Style the file name.
 187
 188 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 189
 190         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 191         (aarch64_vnv_type): Likewise.
 192         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 193         * common/tdesc.c: Likewise.
 194         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 195         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 196         * features/aarch64-fpu.xml: Add ieee half view.
 197         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 198         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 199         * gdbtypes.h (struct builtin_type): Likewise.
 200         (struct objfile_type): Likewise.
 201
 202 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 203
 204         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 205         typo.
 206         * location.h (string_to_event_location): Likewise.
 207
 208 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 209
 210         GDB 8.3 released.
 211
 212 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 213
 214         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 215         New variable declaration.
 216         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 217         New variable.
 218         (print_one_breakpoint): Use ui_out::test_flags and new global
 219         variable to compute use_fixed_output.
 220         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 221         Remove.
 222         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 223         (mi_multi_location_breakpoint_output_fixed): Remove.
 224         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 225         new variable.
 226         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 227         fix_multi_location_breakpoint_output flag if version >= 3.
 228         * ui-out.h (enum ui_out_flag)
 229         <fix_multi_location_breakpoint_output>: New enumerator.
 230
 231 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 232
 233         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 234
 235 2019-05-10  Tom Tromey  <tromey@adacore.com>
 236
 237         * ada-lang.c (catch_ada_completer): New function.
 238         (_initialize_ada_language): Use it.
 239
 240 2019-05-10  Tom Tromey  <tromey@adacore.com>
 241
 242         * thread.c (print_thread_info): Make "requested_threads" const.
 243         * gdbthread.h (print_thread_info): Make "requested_threads"
 244         const.
 245         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 246         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 247
 248 2019-05-08  Tom Tromey  <tom@tromey.com>
 249
 250         * gdbtypes.c (objfile_type_data): Change type.
 251         (objfile_type, _initialize_gdbtypes): Update.
 252
 253 2019-05-08  Tom Tromey  <tom@tromey.com>
 254
 255         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 256         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 257         (_initialize_dwarf2_frame): Update.
 258
 259 2019-05-08  Tom Tromey  <tom@tromey.com>
 260
 261         * objc-lang.c (objc_objfile_data): Change type.
 262         (find_methods): Update.
 263         (_initialize_objc_lang): Remove.
 264
 265 2019-05-08  Tom Tromey  <tom@tromey.com>
 266
 267         * stabsread.c (rs6000_builtin_type_data): Change type.
 268         (rs6000_builtin_type, _initialize_stabsread): Update.
 269
 270 2019-05-08  Tom Tromey  <tom@tromey.com>
 271
 272         * mips-tdep.c (mips_pdr_data): Remove.
 273         (_initialize_mips_tdep): Update.
 274
 275 2019-05-08  Tom Tromey  <tom@tromey.com>
 276
 277         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 278         (hppa_init_objfile_priv_data, read_unwind_info)
 279         (find_unwind_entry, _initialize_hppa_tdep): Update.
 280
 281 2019-05-08  Tom Tromey  <tom@tromey.com>
 282
 283         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 284         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 285         on obstack.
 286         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 287
 288 2019-05-08  Tom Tromey  <tom@tromey.com>
 289
 290         * mdebugread.c (basic_type_data): Change type.
 291         (basic_type, _initialize_mdebugread): Update.
 292
 293 2019-05-08  Tom Tromey  <tom@tromey.com>
 294
 295         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 296
 297 2019-05-08  Tom Tromey  <tom@tromey.com>
 298
 299         * nto-tdep.c (nto_inferior_data_reg): Change type.
 300         (nto_inferior_data): Update.
 301         (nto_inferior_data_cleanup, nto_new_inferior_data)
 302         (_initialize_nto_tdep): Remove.
 303         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 304
 305 2019-05-08  Tom Tromey  <tom@tromey.com>
 306
 307         * ada-lang.c (struct ada_inferior_data): Add initializers.
 308         (ada_inferior_data): Change type.
 309         (ada_inferior_data_cleanup): Remove.
 310         (get_ada_inferior_data, ada_inferior_exit)
 311         (struct ada_pspace_data): Add initializers, destructor.
 312         (ada_pspace_data_handle): Change type.
 313         (get_ada_pspace_data): Update.
 314         (ada_pspace_data_cleanup): Remove.
 315
 316 2019-05-08  Tom Tromey  <tom@tromey.com>
 317
 318         * coffread.c (struct coff_symfile_info): Add initializers.
 319         (coff_objfile_data_key): Move lower.  Change type.
 320         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 321         Update.
 322         (coff_free_info): Remove.
 323
 324 2019-05-08  Tom Tromey  <tom@tromey.com>
 325
 326         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 327         (fbsd_pspace_data_handle): Move lower.  Change type.
 328         (get_fbsd_pspace_data): Update.
 329         (fbsd_pspace_data_cleanup): Remove.
 330         (_initialize_fbsd_tdep): Update.
 331
 332 2019-05-08  Tom Tromey  <tom@tromey.com>
 333
 334         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 335         (get_ada_tasks_pspace_data): Update.
 336         (ada_tasks_pspace_data_cleanup): Remove.
 337         (_initialize_tasks): Update.
 338         (ada_tasks_inferior_data_handle): Change type.
 339         (get_ada_tasks_inferior_data): Update.
 340         (ada_tasks_inferior_data_cleanup): Remove.
 341         (struct ada_tasks_pspace_data): Add initializers.
 342
 343 2019-05-08  Tom Tromey  <tom@tromey.com>
 344
 345         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 346         * symfile-debug.c (debug_sym_get_probes): Change type.
 347         * stap-probe.c (handle_stap_probe):
 348         (stap_static_probe_ops::get_probes): Change type.
 349         * probe.h (class static_probe_ops) <get_probes>: Change type.
 350         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 351         (parse_probes_in_pspace): Update.
 352         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 353         Update.
 354         (any_static_probe_ops::get_probes): Change type.
 355         * elfread.c (elfread_data): New typedef.
 356         (probe_key): Change type.
 357         (elf_get_probes): Likewise.  Update.
 358         (probe_key_free): Remove.
 359         (_initialize_elfread): Update.
 360         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 361         Change type.
 362         (dtrace_process_dof_probe, dtrace_process_dof)
 363         (dtrace_static_probe_ops::get_probe): Change type.
 364
 365 2019-05-08  Tom Tromey  <tom@tromey.com>
 366
 367         * xcoffread.c (struct xcoff_symfile_info): Rename from
 368         coff_symfile_info.  Add initializers.
 369         (xcoff_objfile_data_key): Move lower.  Change type.
 370         (XCOFF_DATA): Rewrite.
 371         (xcoff_free_info): Remove.
 372         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 373         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 374         (xcoff_initial_scan): Update.
 375
 376 2019-05-08  Tom Tromey  <tom@tromey.com>
 377
 378         * solib-svr4.c (struct svr4_info): Add initializers and
 379         destructor.
 380         <probes_table>: Now an htab_up.
 381         (solib_svr4_pspace_data): Change type.
 382         (free_probes_table): Simplify.
 383         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 384         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 385         (probes_table_remove_objfile_probes, register_solib_event_probe)
 386         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 387         (_initialize_svr4_solib): Update.
 388
 389 2019-05-08  Tom Tromey  <tom@tromey.com>
 390
 391         * remote.c (remote_pspace_data): Change type.
 392         (remote_pspace_data_cleanup): Remove.
 393         (get_remote_exec_file, set_pspace_remote_exec_file)
 394         (_initialize_remote): Update.
 395
 396 2019-05-08  Tom Tromey  <tom@tromey.com>
 397
 398         * breakpoint.c (breakpoint_objfile_key): Change type.
 399         (get_breakpoint_objfile_data): Update.
 400         (free_breakpoint_objfile_data): Remove.
 401         (_initialize_breakpoint): Update.
 402
 403 2019-05-08  Tom Tromey  <tom@tromey.com>
 404
 405         * linux-tdep.c (struct linux_info): Add initializers.
 406         (linux_inferior_data): Move.  Change type.
 407         (invalidate_linux_cache_inf): Update.
 408         (linux_inferior_data_cleanup): Remove.
 409         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 410
 411 2019-05-08  Tom Tromey  <tom@tromey.com>
 412
 413         * auxv.c (auxv_inferior_data): Move.  Change type.
 414         (auxv_inferior_data_cleanup): Remove.
 415         (invalidate_auxv_cache_inf): Rewrite.
 416         (get_auxv_inferior_data, _initialize_auxv): Update.
 417
 418 2019-05-08  Tom Tromey  <tom@tromey.com>
 419
 420         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 421         (symfile_debug_objfile_data_key): Change type.
 422         (symfile_debug_installed, debug_qf_has_symbols)
 423         (debug_qf_find_last_source_symtab)
 424         (debug_qf_forget_cached_source_info)
 425         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 426         (debug_qf_print_stats, debug_qf_dump)
 427         (debug_qf_expand_symtabs_for_function)
 428         (debug_qf_expand_all_symtabs)
 429         (debug_qf_expand_symtabs_with_fullname)
 430         (debug_qf_map_matching_symbols)
 431         (debug_qf_expand_symtabs_matching)
 432         (debug_qf_find_pc_sect_compunit_symtab)
 433         (debug_qf_map_symbol_filenames)
 434         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 435         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 436         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 437         (debug_sym_read_linetable, debug_sym_relocate): Update.
 438         (symfile_debug_free_objfile): Remove.
 439         (install_symfile_debug_logging, _initialize_symfile_debug):
 440         Update.
 441
 442 2019-05-08  Tom Tromey  <tom@tromey.com>
 443
 444         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 445         allocate_on_obstack.
 446         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 447         (get_dwarf2_per_objfile): Update.
 448         (set_dwarf2_per_objfile): Remove.
 449         (dwarf2_has_info, dwarf2_get_section_info): Update.
 450         (dwarf2_free_objfile): Remove.
 451         (_initialize_dwarf2_read): Update.
 452
 453 2019-05-08  Tom Tromey  <tom@tromey.com>
 454
 455         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 456         initializers.
 457         <unsupported_script_warning_printed,
 458         script_not_found_warning_printed>: Now bool.
 459         (auto_load_pspace_data): Change type.
 460         (~auto_load_pspace_info): Rename from
 461         auto_load_pspace_data_cleanup.
 462         (get_auto_load_pspace_data, init_loaded_scripts_info)
 463         (clear_section_scripts, maybe_print_unsupported_script_warning)
 464         (maybe_print_script_not_found_warning, _initialize_auto_load):
 465         Update.
 466
 467 2019-05-08  Tom Tromey  <tom@tromey.com>
 468
 469         * objfiles.c (objfile_pspace_info): Add destructor and
 470         initializers.
 471         (objfiles_pspace_data): Change type.
 472         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 473         (get_objfile_pspace_data): Update.
 474         (objfiles_bfd_data): Change type.
 475         (get_objfile_bfd_data): Update.
 476         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 477
 478 2019-05-08  Tom Tromey  <tom@tromey.com>
 479
 480         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 481         Change type.
 482         (get_catch_syscall_inferior_data): Update.
 483         (catch_syscall_inferior_data_cleanup): Remove.
 484         (_initialize_break_catch_syscall): Update.
 485
 486 2019-05-08  Tom Tromey  <tom@tromey.com>
 487
 488         * inflow.c (struct terminal_info): Add destructor and
 489         initializers.
 490         (inflow_inferior_data): Change type.
 491         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 492         (get_inflow_inferior_data, inflow_inferior_exit)
 493         (swap_terminal_info, _initialize_inflow): Update.
 494
 495 2019-05-08  Tom Tromey  <tom@tromey.com>
 496
 497         * target-dcache.c (target_dcache_cleanup): Remove.
 498         (target_dcache_aspace_key): Change type.
 499         (target_dcache_init_p, target_dcache_invalidate)
 500         (target_dcache_get, target_dcache_get_or_init)
 501         (_initialize_target_dcache): Update.
 502         * dcache.h (struct dcache_deleter): New.
 503
 504 2019-05-08  Tom Tromey  <tom@tromey.com>
 505
 506         * symtab.c (struct symbol_cache): Add destructor and
 507         initializers.
 508         (symbol_cache_key): Move.  Change type.
 509         (make_symbol_cache, free_symbol_cache): Remove.
 510         (get_symbol_cache): Update.
 511         (symbol_cache_cleanup): Remove.
 512         (ALL_PSPACES, symbol_cache_flush)
 513         (maintenance_print_symbol_cache)
 514         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 515         Update.
 516
 517 2019-05-08  Tom Tromey  <tom@tromey.com>
 518
 519         * symtab.c (struct main_info): Add destructor and initializers.
 520         (main_progspace_key): Move.  Change type.
 521         (get_main_info): Update.
 522         (main_info_cleanup): Remove.
 523         (_initialize_symtab): Update.
 524
 525 2019-05-08  Tom Tromey  <tom@tromey.com>
 526
 527         * registry.h (DECLARE_REGISTRY): Define the _key class.
 528
 529 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * NEWS: Merge two 'New commands' sections.
 532
 533 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 534
 535         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 536         parameter and use Ada language definition instead.
 537         (ada_val_print_ptr): Remove unused language parameter.
 538         (ada_val_print_num): Remove language parameter and use Ada language
 539         definition instead.
 540         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 541         parameter.
 542         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 543         parameter and use Ada language definition instead.
 544         (ada_val_print_1): Update all ada_val_print_xxx calls.
 545         Remove language parameter.
 546         (ada_val_print): Update ada_val_print_1 call.
 547
 548 2019-05-08  Tom Tromey  <tromey@adacore.com>
 549
 550         * remote.c (remote_hw_watchpoint_limit)
 551         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 552         Now static.
 553
 554 2019-05-08  Tom Tromey  <tromey@adacore.com>
 555
 556         * maint.c (_initialize_maint_cmds): Move initialization code to
 557         remote.c.
 558         (watchdog, show_watchdog): Move to remote.c.
 559         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 560         "watchdog" static.
 561         (_initialize_remote): Move initialization code from maint.c.
 562         * defs.h (watchdog): Don't declare.
 563
 564 2019-05-08  Tom Tromey  <tromey@adacore.com>
 565
 566         * tui/tui-interp.c: Include main.h.
 567         * interps.c: Include main.h.
 568         * main.h (interpreter_p): Declare.
 569         * defs.h (interpreter_p): Don't declare.
 570
 571 2019-05-08  Tom Tromey  <tromey@adacore.com>
 572
 573         * dwarf2loc.c: Include dwarf2read.h.
 574         * defs.h (read_unsigned_leb128): Don't declare.
 575         * dwarf2read.h (read_unsigned_leb128): Declare.
 576
 577 2019-05-08  Tom Tromey  <tromey@adacore.com>
 578
 579         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 580         method.
 581
 582 2019-05-08  Tom Tromey  <tromey@adacore.com>
 583
 584         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 585         when no wrap column is set.
 586
 587 2019-05-08  Tom Tromey  <tromey@adacore.com>
 588
 589         * c-lang.c (c_get_string): Handle non-C-style arrays.
 590
 591 2019-05-08  Tom Tromey  <tromey@adacore.com>
 592
 593         * typeprint.c (print_offset_data::update): Print the bit offset,
 594         not the number of bits remaining.
 595
 596 2019-05-08  Tom Tromey  <tromey@adacore.com>
 597
 598         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 599         padding at end of comment.
 600
 601 2019-05-08  Tom Tromey  <tromey@adacore.com>
 602
 603         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 604         Compare main types.
 605
 606 2019-05-06  Tom Tromey  <tom@tromey.com>
 607
 608         * common/scoped_mmap.c: Include common-defs.h.
 609         * common/scoped_mmap.h: Don't include config.h.
 610
 611 2019-05-04  Tom Tromey  <tom@tromey.com>
 612
 613         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 614         (struct aarch64_call_info): Add initializers.
 615         <si>: Now a std::vector.
 616         (pass_on_stack, aarch64_push_dummy_call): Update.
 617
 618 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 619             Tom Tromey  <tom@tromey.com>
 620
 621         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 622         (ppc_threads): Now a std::vector.  Now static.
 623         (hwdebug_find_thread_points_by_tid)
 624         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 625         Update.
 626
 627 2019-05-04  Tom Tromey  <tom@tromey.com>
 628
 629         * arc-tdep.c (arc_tdesc_init): Return bool.
 630
 631 2019-05-04  Tom Tromey  <tom@tromey.com>
 632
 633         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 634         Use gdb_assert_not_reached.
 635
 636 2019-05-04  Tom Tromey  <tom@tromey.com>
 637
 638         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 639         "false".
 640
 641 2019-05-04  Tom Tromey  <tom@tromey.com>
 642
 643         * arc-tdep.c (arc_tdesc_init): Use bool.
 644
 645 2019-05-04  Tom Tromey  <tom@tromey.com>
 646
 647         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 648
 649 2019-05-04  Tom Tromey  <tom@tromey.com>
 650
 651         * cli/cli-cmds.c (valid_command_p): Return bool.
 652
 653 2019-05-04  Tom Tromey  <tom@tromey.com>
 654
 655         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 656         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 657
 658 2019-05-04  Raul Tambre  <raul@tambre.ee>
 659
 660         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 661         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 662         operator for comparison.
 663
 664 2019-05-04  Tom Tromey  <tom@tromey.com>
 665
 666         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 667         (lookup_partial_symbol, print_partial_symbols)
 668         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 669         (psymbol_compare): Update.
 670         (add_psymbol_to_bcache): Clear the entire psymbol.
 671         (maintenance_check_psymtabs): Update.
 672         * psympriv.h (struct partial_symbol): Don't derive from
 673         general_symbol_info.
 674         <obj_section, unrelocated_address, address,
 675         set_unrelocated_address>: Update.
 676         <ginfo>: New member.
 677         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 678         (debug_names::write_psymbols): Update.
 679
 680 2019-05-04  Tom de Vries  <tdevries@suse.de>
 681
 682         * contrib/cc-with-tweaks.sh: Support -n arg.
 683
 684 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 685
 686         * corelow.c (core_target::detach): Ensure frame cache and
 687         register caches are cleared.
 688         inferior.c (exit_inferior_1): Likewise.
 689
 690 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 691             Tom Tromey  <tom@tromey.com>
 692
 693         * dictionary.c (collate_pending_symbols_by_language): Remove
 694         "struct" from foreach.
 695         * symtab.c (lookup_global_symbol_from_objfile)
 696         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 697         foreach.
 698         * ser-tcp.c (net_open): Remove "struct" from foreach.
 699         * objfiles.c (objfile_relocate, objfile_rebase)
 700         (objfile_has_symbols): Remove "struct" from foreach.
 701         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 702         from foreach.
 703         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 704         foreach.
 705         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 706         "struct" from foreach.
 707         * ada-lang.c (create_excep_cond_exprs)
 708         (ada_exception_catchpoint_cond_string): Remove "struct" from
 709         foreach.
 710
 711 2019-05-03  Tom Tromey  <tromey@adacore.com>
 712
 713         * ada-exp.y (convert_char_literal): Check suffix of each
 714         enumerator.
 715
 716 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 717
 718         PR ada/21406:
 719         * ada-exp.y (yywrap): Don't define.
 720         * ada-lex.l (%option): Add noyywrap
 721         (yywrap): Remove.
 722
 723 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 724
 725         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 726         _WIN32_WINNT to the XP level, unless already defined to a higher
 727         level.
 728
 729         * unittests/parse-connection-spec-selftests.c:
 730         * ser-tcp.c:
 731         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 732         override.
 733
 734         * symfile.c (find_separate_debug_file): Remove colon from the
 735         drive spec of DOS/Windows file names of the target, so that the
 736         file name produced from DEBUGDIR and the target's directory will
 737         be valid on DOS/Windows systems.
 738
 739 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 740
 741         * rust-lang.c (val_print_struct): Handle printing structures
 742         containing strings.
 743
 744 2019-05-02  Tom Tromey  <tromey@adacore.com>
 745
 746         * valarith.c (_initialize_valarith): Remove.
 747
 748 2019-05-01  Tom Tromey  <tromey@adacore.com>
 749
 750         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 751         bitfields.
 752
 753 2019-05-01  Tom Tromey  <tromey@adacore.com>
 754
 755         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 756         for big-endian copies.
 757
 758 2019-04-30  Ali Tamur  <tamur@google.com>
 759         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 760         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 761         (read_3_bytes): New function.
 762
 763 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 764
 765         * windows-nat.c (main_thread_id): Delete.
 766         (handle_output_debug_string): Replace main_thread_id by
 767         current_event.dwThreadId.
 768         (fake_create_process): Likewise.
 769         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 770         Do not set main_thread_id.
 771         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 772         current_event.dwThreadId.
 773         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 774
 775 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 776
 777         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 778         Use current_event.dwThreadId instead of main_thread_id.
 779
 780 2019-04-30  Tom Tromey  <tromey@adacore.com>
 781
 782         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 783         (create_excep_cond_exprs): Iterate over program spaces.
 784         (ada_exception_catchpoint_cond_string): Examine all minimal
 785         symbols for exception types.
 786
 787 2019-04-30  Tom Tromey  <tromey@adacore.com>
 788
 789         PR c++/24470:
 790         * dwarf2read.c (process_structure_scope): Handle case where type
 791         has template parameters but no symbol was created.
 792
 793 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 794             Chris January  <chris.january@arm.com>
 795
 796         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 797         qualifier.
 798         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 799
 800 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 801
 802         * f-typeprint.c (f_print_type): Update rules for printing
 803         whitespace.
 804         (f_type_print_varspec_suffix): Likewise.
 805
 806 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 807             Chris January  <chris.january@arm.com>
 808
 809         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 810         function arguments.
 811
 812 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 813
 814         * f-lang.c (build_fortran_types): Change name of void type to
 815         lower case.
 816         * f-typeprint.c (f_type_print_base): Print the name of the void
 817         type, rather than a fixed string.
 818         * f-valprint.c (f_decorations): Use lower case void string.
 819
 820 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 821             Chris January  <chris.january@arm.com>
 822
 823         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 824         types for Fortran.
 825
 826 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 827             Chris January  <chris.january@arm.com>
 828             David Lecomber  <david.lecomber@arm.com>
 829
 830         * f-exp.y (BINOP_INTRINSIC): New token.
 831         (exp): New parser rule handling BINOP_INTRINSIC.
 832         (f77_keywords): Add new builtin procedures.
 833         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 834         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 835         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 836         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 837         (print_unop_subexp_f): New function.
 838         (print_binop_subexp_f): New function.
 839         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 840         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 841         (dump_subexp_body_f): Likewise.
 842         (operator_check_f): Likewise.
 843         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 844         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 845
 846 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 847
 848         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 849         UNOP_KIND.
 850         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 851         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 852         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 853         (operator_length_f): New fuction.
 854         (print_subexp_f): New function.
 855         (op_name_f): New function.
 856         (dump_subexp_body_f): New function.
 857         (operator_check_f): New function.
 858         (exp_descriptor_f): Replace standard expression handling functions
 859         with new functions.
 860         * gdb/fortran-operator.def: New file.
 861         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 862         * gdb/std-operator.def: Remove UNOP_KIND.
 863
 864 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 865
 866         * std-operator.def: Remove unbalanced, stray double quote
 867         character.
 868
 869 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 870             Chris January  <chris.january@arm.com>
 871             Daniel Everett  <daniel.everett@arm.com>
 872             Nick Forrington  <nick.forrington@arm.com>
 873             Richard Bunt  <richard.bunt@arm.com>
 874
 875         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 876         of depth when printing anonymous structs or unions.
 877         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 878         Don't print either the top-level value, or the children if the
 879         max-depth is exceeded.
 880         (ppscm_print_children): When printing the key of a map, allow one
 881         extra level of depth.
 882         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 883         print either the top-level value, or the children if the max-depth
 884         is exceeded.
 885         (print_children): When printing the key of a map, allow one extra
 886         level of depth.
 887         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 888         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 889         (user_print_options): Initialise max_depth field.
 890         (val_print_scalar_or_string_type_p): New function.
 891         (val_print): Check to see if the max depth has been reached.
 892         (val_print_check_max_depth): Define new function.
 893         (show_print_max_depth): New function.
 894         (_initialize_valprint): Add 'print max-depth' option.
 895         * valprint.h (struct value_print_options) <max_depth>: New field.
 896         (val_print_check_max_depth): Declare new function.
 897         * NEWS: Document new feature.
 898
 899 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * ada-lang.c (ada_language_defn): Initialise new field.
 902         * c-lang.c (c_is_string_type_p): New function.
 903         (c_language_defn): Initialise new field.
 904         (cplus_language_defn): Initialise new field.
 905         (asm_language_defn): Initialise new field.
 906         (minimal_language_defn): Initialise new field.
 907         * c-lang.h (c_is_string_type_p): Declare new function.
 908         * d-lang.c (d_language_defn): Initialise new field.
 909         * f-lang.c (f_is_string_type_p): New function.
 910         (f_language_defn): Initialise new field.
 911         * go-lang.c (go_is_string_type_p): New function.
 912         (go_language_defn): Initialise new field.
 913         * language.c (default_is_string_type_p): New function.
 914         (unknown_language_defn): Initialise new field.
 915         (auto_language_defn): Initialise new field.
 916         * language.h (struct language_defn) <la_is_string_type_p>: New
 917         member variable.
 918         (default_is_string_type_p): Declare new function.
 919         * m2-lang.c (m2_language_defn): Initialise new field.
 920         * objc-lang.c (objc_language_defn): Initialise new field.
 921         * opencl-lang.c (opencl_language_defn): Initialise new field.
 922         * p-lang.c (pascal_is_string_type_p): New function.
 923         (pascal_language_defn): Initialise new field.
 924         * rust-lang.c (rust_is_string_type_p): New function.
 925         (rust_language_defn): Initialise new field.
 926
 927 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 930         New field.
 931         * ada-lang.c (ada_language_defn): Initialise new field.
 932         * c-lang.c (c_language_defn): Likewise.
 933         (cplus_language_defn): Likewise.
 934         (asm_language_defn): Likewise.
 935         (minimal_language_defn): Likewise.
 936         * d-lang.c (d_language_defn): Likewise.
 937         * f-lang.c (f_language_defn): Likewise.
 938         * go-lang.c (go_language_defn): Likewise.
 939         * language.c (unknown_language_defn): Likewise.
 940         (auto_language_defn): Likewise.
 941         * m2-lang.c (m2_language_defn): Likewise.
 942         * objc-lang.c (objc_language_defn): Likewise.
 943         * opencl-lang.c (opencl_language_defn): Likewise.
 944         * p-lang.c (pascal_language_defn): Likewise.
 945         * rust-lang.c (rust_language_defn): Likewise.
 946
 947 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 948
 949         * ada-lang.c (ada_is_character_type): Change return type to bool.
 950         (ada_is_string_type): Likewise.
 951         * ada-lang.h (ada_is_character_type): Update declaration
 952         (ada_is_string_type): Likewise.
 953
 954 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 955
 956         Support style in 'frame|thread apply'
 957
 958         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 959         * record.c (record_start, record_stop): Update callers of
 960         execute_command_to_string with false.
 961         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 962         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 963         methods.
 964         (class string_file): New constructor with term_out parameter.
 965         Override methods term_out and can_emit_style_escape.  New member
 966         term_out.
 967         (class stdio_file): Override can_emit_style_escape.
 968         (class tee_file): Override term_out and can_emit_style_escape.
 969         * utils.h (can_emit_style_escape): Remove.
 970         * utils.c (can_emit_style_escape): Likewise.
 971         Update all callers of can_emit_style_escape (SOMESTREAM) to
 972         SOMESTREAM->can_emit_style_escape.
 973         * source-cache.c (source_cache::get_source_lines): Likewise.
 974         * stack.c (frame_apply_command_count): Call execute_command_to_string
 975         passing the term_out characteristic of the current gdb_stdout.
 976         * thread.c (thr_try_catch_cmd): Likewise.
 977         * top.c (execute_command_to_string): pass term_out parameter
 978         to construct the string_file for the command output.
 979         * ui-file.c (term_cli_styling): New function (most code moved
 980         from utils.c can_emit_style_escape).
 981         (string_file::string_file, string_file::can_emit_style_escape,
 982         stdio_file::can_emit_style_escape, tee_file::term_out,
 983         tee_file::can_emit_style_escape): New functions.
 984
 985 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 986
 987         * NEWS: Mention the new set|show may-call-functions.
 988         * infcall.c (may_call_functions_p): New variable.
 989         (show_may_call_functions_p): New function.
 990         (call_function_by_hand_dummy): Throws an error if not
 991         may-call-functions.
 992         (_initialize_infcall): Call add_setshow_boolean_cmd for
 993         may-call-functions.
 994
 995 2019-04-25  Keith Seitz  <keiths@redhat.com>
 996
 997         PR c++/24367
 998         * cp-support.c (inspect_type): Don't attempt substitutions
 999         of symbol with the same name.
1000
1001 2019-04-25  Tom Tromey  <tromey@adacore.com>
1002
1003         PR gdb/24475:
1004         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1005         static.
1006
1007 2019-04-25  Tom Tromey  <tromey@adacore.com>
1008
1009         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1010         rvalue reference.
1011         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1012         (gdb_xml_parser::parse): Use std::move.
1013         * python/python-internal.h (gdbpy_convert_exception): Take a const
1014         reference.
1015         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1016         std::move.
1017         * python/py-utils.c (gdbpy_convert_exception): Take a const
1018         reference.
1019         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1020         Use std::move.
1021         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1022         Use std::move.
1023         * mi/mi-main.c (mi_print_exception): Take a const reference.
1024         * main.c (handle_command_errors): Take a const reference.
1025         * linespec.c (parse_linespec): Use std::move.
1026         * infcall.c (run_inferior_call): Use std::move.
1027         (call_function_by_hand_dummy): Use std::move.
1028         * exec.c (try_open_exec_file): Use std::move.
1029         * exceptions.h (exception_print, exception_fprintf)
1030         (exception_print_same): Update.
1031         * exceptions.c (print_exception, exception_print)
1032         (exception_fprintf, exception_print_same): Change parameters to
1033         const reference.
1034         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1035         * common/new-op.c: Use std::move.
1036         * common/common-exceptions.h (struct gdb_exception): Add move
1037         constructor.
1038         (struct gdb_exception_error, struct gdb_exception_quit, struct
1039         gdb_quit_bad_alloc): Change constructor to move constructor.
1040         (throw_exception): Change parameter to rvalue reference.
1041         * common/common-exceptions.c (throw_exception): Take rvalue
1042         reference.
1043         * cli/cli-interp.c (safe_execute_command): Use std::move.
1044         * breakpoint.c (insert_bp_location, location_to_sals): Use
1045         std::move.
1046
1047 2019-04-25  Tom Tromey  <tromey@adacore.com>
1048
1049         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1050         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1051         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1052         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1053         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1054         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1055         guile/scm-value.c: Use unpack.
1056         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1057         gdbscm_gdb_exception.
1058         (gdbscm_throw_gdb_exception): Likewise.
1059         (struct gdbscm_gdb_exception): New.
1060         (unpack): New function.
1061         (gdbscm_wrap): Use unpack.
1062
1063 2019-04-25  Tom Tromey  <tromey@adacore.com>
1064
1065         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1066         (gdb_rl_callback_handler): Use std::move.
1067         * common/common-exceptions.h (struct gdb_exception): Add move
1068         assignment operator.
1069         (throw_exception_sjlj): Change "exception" to const reference.
1070         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1071         (throw_exception_sjlj): Change "exception" to const reference.
1072
1073 2019-04-25  Tom Tromey  <tromey@adacore.com>
1074
1075         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1076         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1077         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1078         Update.
1079         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1080         Update.
1081         * mi/mi-interp.c (mi_interp::exec): Update.
1082         * linespec.c (parse_linespec): Update.
1083         * infcall.c (run_inferior_call): Update.
1084         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1085         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1086         (gdbscm_lookup_global_symbol): Update.
1087         * guile/scm-param.c (gdbscm_parameter_value): Update.
1088         * guile/scm-frame.c (gdbscm_frame_read_register)
1089         (gdbscm_frame_read_var): Update.
1090         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1091         * exec.c (try_open_exec_file): Update.
1092         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1093         (gdb_rl_callback_handler): Update.
1094         * common/common-exceptions.h (exception_none): Don't declare.
1095         * common/common-exceptions.c (exception_none): Don't define.
1096         (struct catcher) <exception>: Update.
1097         * cli/cli-interp.c (safe_execute_command): Update.
1098         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1099
1100 2019-04-25  Ali Tamur  <tamur@google.com>
1101
1102         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1103         (read_attribute_value): Likewise.
1104         (dwarf2_read_addr_index): Update comment.
1105         (read_str_index): Add DW_FORM_strx.
1106         (dwarf2_string_attr): Likewise.
1107         (dwarf2_const_value_attr): Likewise.
1108         (dump_die_shallow): Likewise.
1109         (dwarf2_fetch_constant_bytes): Likewise.
1110         (skip_form_bytes): Likewise.
1111         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1112
1113 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1114
1115         PR corefiles/11608
1116         PR corefiles/18187
1117         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1118         OFFSET.  Verify if current mapping contains an ELF header.
1119         (linux_find_memory_regions_full): Adjust call to
1120         dump_mapping_p.
1121
1122 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1123             Kang Li <kanglictf@gmail.com>
1124
1125         PR gdb/21600
1126
1127         * dwarf2-frame.c (read_initial_length): Be consistent about using
1128         unsigned representation of length.
1129         (decode_frame_entry_1): Likewise.  Check for wraparound of
1130         end pointer as well as buffer overflow.
1131
1132 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1133
1134         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1135         "vq".
1136
1137 2019-04-24  Tom Tromey  <tromey@adacore.com>
1138
1139         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1140
1141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * s12z-tdep.c (s12z_unwind_pc): Delete.
1144         (s12z_unwind_sp): Delete.
1145         (s12z_gdbarch_init): Don't register deleted functions with
1146         gdbarch.
1147
1148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1149
1150         * rl78-tdep.c (rl78_unwind_sp): Delete.
1151         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1152
1153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1154
1155         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1156         (xstormy16_unwind_pc): Delete.
1157         (xstormy16_dummy_id): Delete.
1158         (xstormy16_gdbarch_init): Don't register deleted functions with
1159         gdbarch.
1160
1161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * vax-tdep.c (vax_unwind_pc): Delete.
1164         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1165
1166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1167
1168         * v850-tdep.c (v850_unwind_sp): Delete.
1169         (v850_unwind_pc): Delete.
1170         (v850_dummy_id): Delete.
1171         (v850_gdbarch_init): Don't register deleted functions with
1172         gdbarch.
1173
1174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1175
1176         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1177         (tilegx_unwind_pc): Delete.
1178         (tilegx_unwind_dummy_id): Delete.
1179         (tilegx_gdbarch_init): Don't register deleted functions with
1180         gdbarch.
1181
1182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1183
1184         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1185         (tic6x_dummy_id): Delete.
1186         (tic6x_gdbarch_init): Don't register deleted functions with
1187         gdbarch.
1188
1189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * sparc-tdep.c (sparc_unwind_pc): Delete.
1192         (sparc32_gdbarch_init): Don't register deleted function with
1193         gdbarch.
1194
1195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1196
1197         * sh-tdep.c (sh_unwind_sp): Delete.
1198         (sh_unwind_pc): Delete.
1199         (sh_dummy_id): Delete.
1200         (sh_gdbarch_init): Don't register deleted functions with
1201         gdbarch.
1202
1203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1204
1205         * score-tdep.c (score_unwind_sp): Delete.
1206         (score_unwind_pc): Delete.
1207         (score_dummy_id): Delete.
1208         (score_gdbarch_init): Don't register deleted functions with
1209         gdbarch.
1210
1211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1212
1213         * rx-tdep.c (rx_unwind_pc): Delete.
1214         (rx_unwind_sp): Delete.
1215         (rx_dummy_id): Delete.
1216         (rx_gdbarch_init): Don't register deleted functions with
1217         gdbarch.  Update comment.
1218
1219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1220
1221         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1222         (rs6000_dummy_id): Delete.
1223         (rs6000_gdbarch_init): Don't register deleted functions with
1224         gdbarch.
1225
1226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * or1k-tdep.c (or1k_dummy_id): Delete.
1229         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1230
1231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * nios2-tdep.c (nios2_dummy_id): Delete.
1234         (nios2_unwind_sp): Delete.
1235         (nios2_gdbarch_init): Don't register deleted functions with
1236         gdbarch.
1237
1238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1239
1240         * nds32-tdep.c (nds32_dummy_id): Delete.
1241         (nds32_unwind_pc): Delete.
1242         (nds32_unwind_sp): Delete.
1243         (nds32_gdbarch_init): Don't register deleted functions with
1244         gdbarch.
1245
1246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * msp430-tdep.c (msp430_unwind_pc): Delete.
1249         (msp430_unwind_sp): Delete.
1250         (msp430_dummy_id): Delete.
1251         (msp430_gdbarch_init): Don't register deleted functions with
1252         gdbarch.
1253
1254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1255
1256         * moxie-tdep.c (moxie_unwind_sp): Delete.
1257         (moxie_unwind_pc): Delete.
1258         (moxie_dummy_id): Delete.
1259         (moxie_gdbarch_init): Don't register deleted functions with
1260         gdbarch.
1261
1262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1263
1264         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1265         (mn10300_unwind_pc): Delete.
1266         (mn10300_unwind_sp): Delete.
1267         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1268         mn10300_unwind_sp.
1269         (mn10300_frame_unwind_init): Don't register deleted functions with
1270         gdbarch.
1271
1272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1273
1274         * mep-tdep.c (mep_unwind_pc): Delete.
1275         (mep_unwind_sp): Delete.
1276         (mep_dummy_id): Delete.
1277         (mep_gdbarch_init): Don't register deleted functions with
1278         gdbarch.
1279
1280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1281
1282         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1283         (m68hc11_unwind_sp): Delete.
1284         (m68hc11_gdbarch_init): Don't register deleted functions with
1285         gdbarch.
1286
1287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * m32r-tdep.c (m32r_unwind_sp): Delete.
1290         (m32r_unwind_pc): Delete.
1291         (m32r_dummy_id): Delete.
1292         (m32r_gdbarch_init): Don't register deleted functions with
1293         gdbarch.
1294
1295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * m32c-tdep.c (m32c_unwind_pc): Delete.
1298         (m32c_unwind_sp): Delete.
1299         (m32c_dummy_id): Delete.
1300         (m32c_gdbarch_init): Don't register deleted functions with
1301         gdbarch.
1302
1303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1304
1305         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1306         (lm32_unwind_pc): Delete.
1307         (lm32_dummy_id): Delete.
1308         (lm32_gdbarch_init): Don't register deleted functions with
1309         gdbarch.
1310
1311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1312
1313         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1314         (iq2000_unwind_pc): Delete.
1315         (iq2000_dummy_id): Delete.
1316         (iq2000_gdbarch_init): Don't register deleted functions with
1317         gdbarch.
1318
1319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * nds32-tdep.c (nds32_type_align): Delete.
1322         (nds32_push_dummy_call): Use type_align instead.
1323
1324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * arm-tdep.c (arm_type_align): Only handle vector override case.
1327         (arm_push_dummy_call): Use type_align.
1328         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1329
1330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1331
1332         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1333         case.
1334         (pass_on_stack): Use type_align.
1335         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1336         function.
1337
1338 2019-04-23  Tom Tromey  <tromey@adacore.com>
1339
1340         * dwarf2read.c (line_header::file_name_at): Remove unused
1341         overload.
1342
1343 2019-04-23  Tom de Vries  <tdevries@suse.de>
1344
1345         PR gdb/24438
1346         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1347         invocation.
1348
1349
1350 2019-03-27  Ali Tamur  <tamur@google.com>
1351
1352         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1353         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1354         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1355         (dwarf_expr_context::get_addr_index): Likewise
1356         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1357         (symbol_needs_eval_context::get_addr_index): Likewise
1358         (disassemble_dwarf_expression): Add DW_OP_addrx
1359         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1360         (read_cutu_die_from_dwo): Update comment
1361         (skip_one_die): Add DW_FORM_addrx
1362         (read_attribute_value): Likewise
1363         (var_decode_location): Add DW_OP_addrx
1364         (dwarf2_const_value_attr): Add DW_FORM_addrx
1365         (dump_die_shallow): Likewise
1366         (dwarf2_fetch_constant_bytes): Likewise
1367         (decode_locdesc): Add DW_OP_addrx
1368         (skip_form_bytes): Add DW_FORM_addrx
1369
1370 2019-04-22  Ali Tamur  <tamur@google.com>
1371
1372         * MAINTAINERS (Write After Approval): Add self.
1373
1374 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1375
1376         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1377         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1378         (open_symbol_file_object): Likewise.
1379         (svr4_default_sos): Add info parameter.
1380         (svr4_read_so_list): Likewise.
1381         (svr4_current_sos_direct): Adjust functions calls to pass down
1382         info.
1383         (svr4_current_sos_1): Add info parameter.
1384         (svr4_current_sos): Call get_svr4_info, pass info down to
1385         svr4_current_sos_1.
1386         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1387         get_svr4_info.
1388         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1389         get_svr4_info.
1390         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1391         to get_svr4_info.
1392         (probes_table_remove_objfile_probes): Likewise.
1393         (register_solib_event_probe): Add info parameter.
1394         (solist_update_incremental): Pass info parameter down to
1395         svr4_read_so_list.
1396         (disable_probes_interface): Add info parameter.
1397         (svr4_handle_solib_event): Pass current_program_space to
1398         get_svr4_info.  Adjust disable_probes_interface cleanup.
1399         (svr4_create_probe_breakpoints): Add info parameter, pass it
1400         down to register_solib_event_probe.
1401         (svr4_create_solib_event_breakpoints): Add info parameter,
1402         pass it down to svr4_create_probe_breakpoints.
1403         (enable_break): Pass info down to
1404         svr4_create_solib_event_breakpoints.
1405         (svr4_solib_create_inferior_hook): Pass current_program_space to
1406         get_svr4_info.
1407         (svr4_clear_solib): Likewise.
1408
1409 2019-04-22  Pedro Alves  <palves@redhat.com>
1410
1411         * solib-svr4.c (svr4_free_objfile_observer): New.
1412         (probe_and_action::objfile): New field.
1413         (probes_table_htab_remove_objfile_probes)
1414         (probes_table_remove_objfile_probes): New functions.
1415         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1416         in the new probe_and_action.  Don't store the probe in 'lookup'.
1417         (svr4_create_probe_breakpoints): Pass objfile to
1418         register_solib_event_probe.
1419         (_initialize_svr4_solib): Register a free_objfile observer.
1420
1421 2019-04-19  Tom Tromey  <tom@tromey.com>
1422
1423         * common/queue.h: Remove.
1424
1425 2019-04-19  Tom Tromey  <tom@tromey.com>
1426
1427         * event-loop.c: Don't include "common/queue.h".
1428
1429 2019-04-19  Tom Tromey  <tom@tromey.com>
1430
1431         * remote.c (remote_target): Use delete.
1432         * remote-notif.h: Include <list>, not "common/queue.h".
1433         (notif_client_p): Remove typedef.
1434         (remote_notif_state): Add constructor, destructor, initializer.
1435         <notif_queue>: Now a std::list.
1436         (remote_notif_state_xfree): Don't declare.
1437         * remote-notif.c (remote_notif_process, handle_notification)
1438         (remote_notif_state_allocate): Update.
1439         (~remote_notif_state): Rename from remote_notif_state_xfree.
1440
1441 2019-04-19  Tom Tromey  <tom@tromey.com>
1442
1443         * symfile.c (reread_symbols): Update.
1444         * objfiles.c (objfile_register_static_link)
1445         (objfile_lookup_static_link): Update
1446         (~objfile) Don't delete static_links.
1447         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1448
1449 2019-04-19  Tom Tromey  <tom@tromey.com>
1450
1451         * type-stack.h (struct type_stack) <insert>: Constify string.
1452         * type-stack.c (type_stack::insert): Constify string.
1453         * gdbtypes.h (lookup_template_type): Update.
1454         (address_space_name_to_int): Update.
1455         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1456         const.
1457         (lookup_template_type): Make name const.
1458         * c-exp.y: Update rules.
1459         (lex_one_token, classify_name, classify_inner_name)
1460         (c_print_token): Update.
1461         * p-exp.y: Update rules.
1462         (yylex): Update.
1463         * f-exp.y: Update rules.
1464         (yylex): Update.
1465         * d-exp.y: Update rules.
1466         (lex_one_token, classify_name, classify_inner_name): Update.
1467         * parse.c (write_dollar_variable, copy_name): Return std::string.
1468         * parser-defs.h (copy_name): Change return type.
1469         * m2-exp.y: Update rules.
1470         (yylex): Update.
1471         * go-exp.y (lex_one_token): Update.
1472         Update rules.
1473         (classify_unsafe_function, classify_packaged_name)
1474         (classify_name, yylex): Update.
1475
1476 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1477
1478         * configure.ac: add --enable-source-highlight switch.
1479         * configure: Regenerate.
1480         * top.c (print_gdb_version): plumb --enable-source-highlight
1481         status to "show configuration".
1482
1483 2019-04-19  Tom Tromey  <tromey@adacore.com>
1484
1485         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1486         Check ADA_TYPE_P.
1487         (empty_record, ada_template_to_fixed_record_type_1)
1488         (template_to_static_fixed_type)
1489         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1490         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1491         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1492         macros.
1493
1494 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1495
1496         PR symtab/24423:
1497         * source.c (print_source_lines_base): Advance "iter" when a
1498         control character is seen.
1499
1500 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1501
1502         * inferior.h (struct infcall_suspend_state_deleter):
1503         Catch exception in destructor to avoid crash.
1504
1505 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1506
1507         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1508         close to the add_com "shell".
1509
1510 2019-04-18  Tom Tromey  <tromey@adacore.com>
1511
1512         * process-stratum-target.h (class process_stratum_target)
1513         <stratum>: Add "final".
1514
1515 2019-04-17  Tom Tromey  <tromey@adacore.com>
1516
1517         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1518         against nullptr before use.
1519
1520 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1521
1522         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1523
1524 2019-04-17  Jim Wilson  <jimw@sifive.com>
1525             Andrew Burgess  <andrew.burgess@embecosm.com>
1526
1527         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1528         code read might fail, assume 4-byte breakpoint in that case.
1529
1530 2019-04-15  Leszek Swirski  <leszeks@google.com>
1531
1532         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1533         rather than a hand-rolled POD check when checking for forced MEMORY
1534         classification.
1535
1536 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1537
1538         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1539         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1540         function.
1541         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1542         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1543         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1544         declaration.
1545
1546 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1547
1548         * aarch64-linux-nat.c
1549         (aarch64_linux_nat_target::thread_architecture): Add override.
1550         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1551         each VQ.
1552
1553 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1554
1555         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1556
1557 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1558
1559         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1560         target types of size 96-bits, add some additional comments, and
1561         check that the builtin type we found was the correct size.
1562
1563 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1564
1565         * utils.c (prompt_for_continue): Don't restore the styling at the
1566         end, as applied_style has the wrong value.  This fixes styling in
1567         long lists of file names that are interrupted by the "Continue?"
1568         prompt.
1569
1570 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1571
1572         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1573         * c-lang.c (c_language_defn): Likewise.
1574         (cplus_language_defn): Likewise.
1575         (asm_language_defn): Likewise.
1576         (minimal_language_defn): Likewise.
1577         * d-lang.c (d_language_defn): Likewise.
1578         * f-lang.c (f_language_defn): Likewise.
1579         * go-lang.c (go_language_defn): Likewise.
1580         * language.c (unknown_language_defn): Likewise.
1581         (auto_language_defn): Likewise.
1582         * language.h (struct language_defn): Remove la_magic field.
1583         (LANG_MAGIC): Delete.
1584         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1585         * objc-lang.c (objc_language_defn): Likewise.
1586         * opencl-lang.c (opencl_language_defn): Likewise.
1587         * p-lang.c (pascal_language_defn): Likewise.
1588         * rust-lang.c (rust_language_defn): Likewise.
1589
1590 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1591
1592         * riscv-tdep.c (riscv_type_align): New function.
1593         (riscv_type_alignment): Delete.
1594         (riscv_arg_location): Use 'type_align'.
1595         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1596
1597 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1598
1599         * gdbtypes.c (type_align): A struct with no non-static fields also
1600         has alignment of 1.
1601
1602 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1603
1604         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1605         component to 0.
1606         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1607         member.
1608         (riscv_struct_info::analyse): New implementation using new
1609         analyse_inner member function.
1610         (riscv_struct_info::field_offset): New member function.
1611         (riscv_struct_info::m_offsets): New member variable.
1612         (riscv_struct_info::analyse_inner): New private member function,
1613         takes the old implementation of riscv_struct_info::analyse but
1614         extended to track field offsets.
1615         (riscv_call_arg_struct): Update the struct folding special cases
1616         to handle cases where empty C++ structs, which are non-zero
1617         length, are found.
1618         (riscv_arg_location): Initialise the length of each location, a
1619         non-zero length now indicates the location is in use.
1620         (riscv_push_dummy_call): Allow for the first location having a
1621         non-zero offset when setting up arguments.
1622         (riscv_return_value): Likewise, but for return values.
1623
1624 2019-04-11  Tom Tromey  <tromey@adacore.com>
1625
1626         * utils.c (internal_vproblem): Make "msg" const.
1627
1628 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1629
1630         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1631         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1632         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1633         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1634
1635 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1636
1637         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1638         function.
1639         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1640         of amd64_collect_native_gregset.
1641         (amd64_linux_nat_target::store_registers): Likewise.
1642
1643 2019-04-10  Tom Tromey  <tom@tromey.com>
1644
1645         * symtab.c (lookup_global_symbol_from_objfile)
1646         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1647         * objfiles.h (class separate_debug_iterator): New.
1648         (class separate_debug_range): New.
1649         (struct objfile) <separate_debug_objfiles>: New method.
1650         (objfile_separate_debug_iterate): Don't declare.
1651         * objfiles.c (separate_debug_iterator::operator++): Rename from
1652         objfile_separate_debug_iterate.
1653         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1654         iterator.
1655         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1656         iterator.
1657
1658 2019-04-10  Tom Tromey  <tom@tromey.com>
1659
1660         * symfile.c (reread_symbols): Remove old comment.
1661         * objfiles.c (free_all_objfiles): Fix a typo.
1662
1663 2019-04-10  Tom Tromey  <tom@tromey.com>
1664
1665         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1666         * minsyms.c (lookup_minimal_symbol): Use foreach.
1667         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1668         (lookup_minimal_symbol_solib_trampoline): Likewise.
1669         * symfile.c (reread_symbols): Use foreach.
1670
1671 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1672             Tom Tromey  <tromey@adacore.com>
1673
1674         PR rust/24414:
1675         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1676         (rust_lex_int_test): Change "value" to be LONGEST.
1677         (rust_lex_tests): Add test for long integer literal.
1678
1679 2019-04-09  Tom Tromey  <tromey@adacore.com>
1680
1681         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1682         to bool.
1683         (extended_remote_target::attach): Update.
1684         (remote_target::remote_notice_new_inferior): Update.
1685         (remote_target::add_current_inferior_and_thread): Update.
1686         * inferior.c (exit_inferior_1): Use "false".
1687         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1688
1689 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1690
1691         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1692         the "start" command.
1693
1694 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1695
1696         * python/py-inferior.c (infpy_thread_from_thread_handle):
1697         Adjust comments to reflect renaming of thread_from_thread_handle
1698         to thread_from_handle.  Adjust keywords.  Fix type error message.
1699         (inferior_object_methods): Add thread_from_handle.  Retain
1700         thread_from_thread_handle, but mark it as deprecated.
1701
1702 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1703
1704         * gdbthread.h (find_thread_by_handle): Revise declaration.
1705         * thread.c (find_thread_by_handle): Likewise.  Adjust
1706         implementation too.
1707         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1708         support for buffer objects as handles.
1709
1710 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1711
1712         * python/py-infthread.c (thpy_thread_handle): New function.
1713         (thread_object_methods): Register thpy_thread_handle.
1714
1715 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1716
1717         * gdbthread.h (thread_to_thread_handle): Declare.
1718         * thread.c (gdbtypes.h): Include.
1719         (thread_to_thread_handle): New function.
1720
1721         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1722         (target_thread_info_to_thread_handle): Declare.
1723         * target.c (target_thread_info_to_thread_handle): New function.
1724         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1725         * target-delegates.c: Regenerate.
1726
1727         * linux-thread-db.c (class thread_db_target): Add method
1728         thread_info_to_thread_handle.
1729         (thread_db_target::thread_info_to_thread_handle): Define.
1730         * remote.c (class remote_target): Add new method
1731         thread_info_to_thread_handle.
1732         (remote_target::thread_info_to_thread_handle): Define.
1733
1734 2019-04-08  Pedro Alves  <palves@redhat.com>
1735
1736         * common/common-exceptions.c (throw_exception): Don't create
1737         named object to throw; throw directly.
1738         (throw_it): Likewise.  Don't initialize gdb_exception::message
1739         here, with new; pass FMT and AP to the ctor instead.
1740         * common/common-exceptions.h: Include <string>.
1741         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1742         const char *, va_list)): New ctor.  Use std::make_shared.
1743         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1744         errors)): Delete.
1745         (gdb_exception_error::gdb_exception_error(enum errors, const char
1746         *, va_list)): New.
1747         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1748         Add assertion.
1749         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1750         errors)): Delete.
1751         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1752         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1753         Add assertion.
1754
1755 2019-04-08  Tom Tromey  <tom@tromey.com>
1756
1757         * valops.c (value_rtti_indirect_type): Replace throw_exception
1758         with throw.
1759         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1760         with throw.
1761         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1762         throw.
1763         * target.c (target_translate_tls_address): Replace throw_exception
1764         with throw.
1765         * stack.c (frame_apply_command_count): Replace throw_exception
1766         with throw.
1767         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1768         throw.
1769         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1770         with throw.
1771         * rs6000-tdep.c (rs6000_frame_cache)
1772         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1773         * remote.c: Replace throw_exception with throw.
1774         * record-full.c (record_full_message, record_full_wait_1)
1775         (record_full_restore): Replace throw_exception with throw.
1776         * record-btrace.c:
1777         (get_thread_current_frame_id, record_btrace_start_replaying)
1778         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1779         (cmd_record_btrace_start): Replace throw_exception with throw.
1780         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1781         throw.
1782         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1783         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1784         * linespec.c:
1785         (find_linespec_symbols): Replace throw_exception with throw.
1786         * infrun.c (displaced_step_prepare, resume): Replace
1787         throw_exception with throw.
1788         * infcmd.c (post_create_inferior): Replace throw_exception with
1789         throw.
1790         * inf-loop.c (inferior_event_handler): Replace throw_exception
1791         with throw.
1792         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1793         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1794         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1795         (get_prev_frame_always, get_frame_pc_if_available)
1796         (get_frame_address_in_block_if_available, get_frame_language):
1797         Replace throw_exception with throw.
1798         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1799         throw_exception with throw.
1800         * eval.c (fetch_subexp_value, evaluate_var_value)
1801         (evaluate_funcall, evaluate_subexp_standard): Replace
1802         throw_exception with throw.
1803         * dwarf2loc.c (call_site_find_chain)
1804         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1805         Replace throw_exception with throw.
1806         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1807         with throw.
1808         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1809         throw.
1810         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1811         * completer.c (complete_line_internal): Replace throw_exception
1812         with throw.
1813         * compile/compile-object-run.c (compile_object_run): Replace
1814         throw_exception with throw.
1815         * cli/cli-script.c (process_next_line): Replace throw_exception
1816         with throw.
1817         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1818         (btrace_enable, btrace_maint_update_pt_packets): Replace
1819         throw_exception with throw.
1820         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1821         throw_exception with throw.
1822         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1823         throw_exception with throw.
1824         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1825         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1826         * aarch64-tdep.c (aarch64_make_prologue_cache)
1827         (aarch64_make_stub_cache): Replace throw_exception with throw.
1828
1829 2019-04-08  Tom Tromey  <tom@tromey.com>
1830
1831         * common/common-exceptions.c (throw_exception): Rename from
1832         throw_exception_cxx.  Remove old copy.  Make argument const.
1833         (throw_it): Create and throw exception objects directly.
1834         * common/common-exceptions.h (throw_exception): Make argument
1835         const.
1836         (struct gdb_exception_error): Add constructor.
1837         (struct gdb_exception_quit): Add constructor.
1838
1839 2019-04-08  Tom Tromey  <tom@tromey.com>
1840
1841         * common/common-exceptions.h (exception_rethrow): Don't declare.
1842         (TRY_SJLJ): Update comment.
1843         (TRY, CATCH, END_CATCH): Remove.
1844         * common/common-exceptions.c (exception_rethrow): Remove.
1845
1846 2019-04-08  Tom Tromey  <tom@tromey.com>
1847
1848         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1849         Remove.
1850         (gdb_exception_error): Rename from
1851         gdb_exception_RETURN_MASK_ERROR.
1852         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1853         (gdb_quit_bad_alloc): Update.
1854         * aarch64-tdep.c: Update.
1855         * ada-lang.c: Update.
1856         * ada-typeprint.c: Update.
1857         * ada-valprint.c: Update.
1858         * amd64-tdep.c: Update.
1859         * arch-utils.c: Update.
1860         * break-catch-throw.c: Update.
1861         * breakpoint.c: Update.
1862         * btrace.c: Update.
1863         * c-varobj.c: Update.
1864         * cli/cli-cmds.c: Update.
1865         * cli/cli-interp.c: Update.
1866         * cli/cli-script.c: Update.
1867         * common/common-exceptions.c: Update.
1868         * common/new-op.c: Update.
1869         * common/selftest.c: Update.
1870         * compile/compile-c-symbols.c: Update.
1871         * compile/compile-cplus-symbols.c: Update.
1872         * compile/compile-object-load.c: Update.
1873         * compile/compile-object-run.c: Update.
1874         * completer.c: Update.
1875         * corelow.c: Update.
1876         * cp-abi.c: Update.
1877         * cp-support.c: Update.
1878         * cp-valprint.c: Update.
1879         * darwin-nat.c: Update.
1880         * disasm-selftests.c: Update.
1881         * dtrace-probe.c: Update.
1882         * dwarf-index-cache.c: Update.
1883         * dwarf-index-write.c: Update.
1884         * dwarf2-frame-tailcall.c: Update.
1885         * dwarf2-frame.c: Update.
1886         * dwarf2loc.c: Update.
1887         * dwarf2read.c: Update.
1888         * eval.c: Update.
1889         * event-loop.c: Update.
1890         * event-top.c: Update.
1891         * exec.c: Update.
1892         * f-valprint.c: Update.
1893         * fbsd-tdep.c: Update.
1894         * frame-unwind.c: Update.
1895         * frame.c: Update.
1896         * gdbtypes.c: Update.
1897         * gnu-v3-abi.c: Update.
1898         * guile/guile-internal.h: Update.
1899         * guile/scm-block.c: Update.
1900         * guile/scm-breakpoint.c: Update.
1901         * guile/scm-cmd.c: Update.
1902         * guile/scm-disasm.c: Update.
1903         * guile/scm-frame.c: Update.
1904         * guile/scm-lazy-string.c: Update.
1905         * guile/scm-math.c: Update.
1906         * guile/scm-param.c: Update.
1907         * guile/scm-ports.c: Update.
1908         * guile/scm-pretty-print.c: Update.
1909         * guile/scm-symbol.c: Update.
1910         * guile/scm-symtab.c: Update.
1911         * guile/scm-type.c: Update.
1912         * guile/scm-value.c: Update.
1913         * i386-linux-tdep.c: Update.
1914         * i386-tdep.c: Update.
1915         * inf-loop.c: Update.
1916         * infcall.c: Update.
1917         * infcmd.c: Update.
1918         * infrun.c: Update.
1919         * jit.c: Update.
1920         * language.c: Update.
1921         * linespec.c: Update.
1922         * linux-fork.c: Update.
1923         * linux-nat.c: Update.
1924         * linux-tdep.c: Update.
1925         * linux-thread-db.c: Update.
1926         * main.c: Update.
1927         * mi/mi-cmd-break.c: Update.
1928         * mi/mi-cmd-stack.c: Update.
1929         * mi/mi-interp.c: Update.
1930         * mi/mi-main.c: Update.
1931         * objc-lang.c: Update.
1932         * p-valprint.c: Update.
1933         * parse.c: Update.
1934         * ppc-linux-tdep.c: Update.
1935         * printcmd.c: Update.
1936         * python/py-arch.c: Update.
1937         * python/py-breakpoint.c: Update.
1938         * python/py-cmd.c: Update.
1939         * python/py-finishbreakpoint.c: Update.
1940         * python/py-frame.c: Update.
1941         * python/py-framefilter.c: Update.
1942         * python/py-gdb-readline.c: Update.
1943         * python/py-inferior.c: Update.
1944         * python/py-infthread.c: Update.
1945         * python/py-lazy-string.c: Update.
1946         * python/py-linetable.c: Update.
1947         * python/py-objfile.c: Update.
1948         * python/py-param.c: Update.
1949         * python/py-prettyprint.c: Update.
1950         * python/py-progspace.c: Update.
1951         * python/py-record-btrace.c: Update.
1952         * python/py-record.c: Update.
1953         * python/py-symbol.c: Update.
1954         * python/py-type.c: Update.
1955         * python/py-unwind.c: Update.
1956         * python/py-utils.c: Update.
1957         * python/py-value.c: Update.
1958         * python/python.c: Update.
1959         * record-btrace.c: Update.
1960         * record-full.c: Update.
1961         * remote-fileio.c: Update.
1962         * remote.c: Update.
1963         * riscv-tdep.c: Update.
1964         * rs6000-aix-tdep.c: Update.
1965         * rs6000-tdep.c: Update.
1966         * rust-exp.y: Update.
1967         * rust-lang.c: Update.
1968         * s390-tdep.c: Update.
1969         * selftest-arch.c: Update.
1970         * solib-dsbt.c: Update.
1971         * solib-frv.c: Update.
1972         * solib-spu.c: Update.
1973         * solib-svr4.c: Update.
1974         * solib.c: Update.
1975         * sparc64-linux-tdep.c: Update.
1976         * stack.c: Update.
1977         * symfile-mem.c: Update.
1978         * symmisc.c: Update.
1979         * target.c: Update.
1980         * thread.c: Update.
1981         * top.c: Update.
1982         * tracefile-tfile.c: Update.
1983         * tui/tui.c: Update.
1984         * typeprint.c: Update.
1985         * unittests/cli-utils-selftests.c: Update.
1986         * unittests/parse-connection-spec-selftests.c: Update.
1987         * valops.c: Update.
1988         * valprint.c: Update.
1989         * value.c: Update.
1990         * varobj.c: Update.
1991         * windows-nat.c: Update.
1992         * x86-linux-nat.c: Update.
1993         * xml-support.c: Update.
1994
1995 2019-04-08  Tom Tromey  <tom@tromey.com>
1996
1997         * xml-support.c: Use C++ exception handling.
1998         * x86-linux-nat.c: Use C++ exception handling.
1999         * windows-nat.c: Use C++ exception handling.
2000         * varobj.c: Use C++ exception handling.
2001         * value.c: Use C++ exception handling.
2002         * valprint.c: Use C++ exception handling.
2003         * valops.c: Use C++ exception handling.
2004         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2005         handling.
2006         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2007         * typeprint.c: Use C++ exception handling.
2008         * tui/tui.c: Use C++ exception handling.
2009         * tracefile-tfile.c: Use C++ exception handling.
2010         * top.c: Use C++ exception handling.
2011         * thread.c: Use C++ exception handling.
2012         * target.c: Use C++ exception handling.
2013         * symmisc.c: Use C++ exception handling.
2014         * symfile-mem.c: Use C++ exception handling.
2015         * stack.c: Use C++ exception handling.
2016         * sparc64-linux-tdep.c: Use C++ exception handling.
2017         * solib.c: Use C++ exception handling.
2018         * solib-svr4.c: Use C++ exception handling.
2019         * solib-spu.c: Use C++ exception handling.
2020         * solib-frv.c: Use C++ exception handling.
2021         * solib-dsbt.c: Use C++ exception handling.
2022         * selftest-arch.c: Use C++ exception handling.
2023         * s390-tdep.c: Use C++ exception handling.
2024         * rust-lang.c: Use C++ exception handling.
2025         * rust-exp.y: Use C++ exception handling.
2026         * rs6000-tdep.c: Use C++ exception handling.
2027         * rs6000-aix-tdep.c: Use C++ exception handling.
2028         * riscv-tdep.c: Use C++ exception handling.
2029         * remote.c: Use C++ exception handling.
2030         * remote-fileio.c: Use C++ exception handling.
2031         * record-full.c: Use C++ exception handling.
2032         * record-btrace.c: Use C++ exception handling.
2033         * python/python.c: Use C++ exception handling.
2034         * python/py-value.c: Use C++ exception handling.
2035         * python/py-utils.c: Use C++ exception handling.
2036         * python/py-unwind.c: Use C++ exception handling.
2037         * python/py-type.c: Use C++ exception handling.
2038         * python/py-symbol.c: Use C++ exception handling.
2039         * python/py-record.c: Use C++ exception handling.
2040         * python/py-record-btrace.c: Use C++ exception handling.
2041         * python/py-progspace.c: Use C++ exception handling.
2042         * python/py-prettyprint.c: Use C++ exception handling.
2043         * python/py-param.c: Use C++ exception handling.
2044         * python/py-objfile.c: Use C++ exception handling.
2045         * python/py-linetable.c: Use C++ exception handling.
2046         * python/py-lazy-string.c: Use C++ exception handling.
2047         * python/py-infthread.c: Use C++ exception handling.
2048         * python/py-inferior.c: Use C++ exception handling.
2049         * python/py-gdb-readline.c: Use C++ exception handling.
2050         * python/py-framefilter.c: Use C++ exception handling.
2051         * python/py-frame.c: Use C++ exception handling.
2052         * python/py-finishbreakpoint.c: Use C++ exception handling.
2053         * python/py-cmd.c: Use C++ exception handling.
2054         * python/py-breakpoint.c: Use C++ exception handling.
2055         * python/py-arch.c: Use C++ exception handling.
2056         * printcmd.c: Use C++ exception handling.
2057         * ppc-linux-tdep.c: Use C++ exception handling.
2058         * parse.c: Use C++ exception handling.
2059         * p-valprint.c: Use C++ exception handling.
2060         * objc-lang.c: Use C++ exception handling.
2061         * mi/mi-main.c: Use C++ exception handling.
2062         * mi/mi-interp.c: Use C++ exception handling.
2063         * mi/mi-cmd-stack.c: Use C++ exception handling.
2064         * mi/mi-cmd-break.c: Use C++ exception handling.
2065         * main.c: Use C++ exception handling.
2066         * linux-thread-db.c: Use C++ exception handling.
2067         * linux-tdep.c: Use C++ exception handling.
2068         * linux-nat.c: Use C++ exception handling.
2069         * linux-fork.c: Use C++ exception handling.
2070         * linespec.c: Use C++ exception handling.
2071         * language.c: Use C++ exception handling.
2072         * jit.c: Use C++ exception handling.
2073         * infrun.c: Use C++ exception handling.
2074         * infcmd.c: Use C++ exception handling.
2075         * infcall.c: Use C++ exception handling.
2076         * inf-loop.c: Use C++ exception handling.
2077         * i386-tdep.c: Use C++ exception handling.
2078         * i386-linux-tdep.c: Use C++ exception handling.
2079         * guile/scm-value.c: Use C++ exception handling.
2080         * guile/scm-type.c: Use C++ exception handling.
2081         * guile/scm-symtab.c: Use C++ exception handling.
2082         * guile/scm-symbol.c: Use C++ exception handling.
2083         * guile/scm-pretty-print.c: Use C++ exception handling.
2084         * guile/scm-ports.c: Use C++ exception handling.
2085         * guile/scm-param.c: Use C++ exception handling.
2086         * guile/scm-math.c: Use C++ exception handling.
2087         * guile/scm-lazy-string.c: Use C++ exception handling.
2088         * guile/scm-frame.c: Use C++ exception handling.
2089         * guile/scm-disasm.c: Use C++ exception handling.
2090         * guile/scm-cmd.c: Use C++ exception handling.
2091         * guile/scm-breakpoint.c: Use C++ exception handling.
2092         * guile/scm-block.c: Use C++ exception handling.
2093         * guile/guile-internal.h: Use C++ exception handling.
2094         * gnu-v3-abi.c: Use C++ exception handling.
2095         * gdbtypes.c: Use C++ exception handling.
2096         * frame.c: Use C++ exception handling.
2097         * frame-unwind.c: Use C++ exception handling.
2098         * fbsd-tdep.c: Use C++ exception handling.
2099         * f-valprint.c: Use C++ exception handling.
2100         * exec.c: Use C++ exception handling.
2101         * event-top.c: Use C++ exception handling.
2102         * event-loop.c: Use C++ exception handling.
2103         * eval.c: Use C++ exception handling.
2104         * dwarf2read.c: Use C++ exception handling.
2105         * dwarf2loc.c: Use C++ exception handling.
2106         * dwarf2-frame.c: Use C++ exception handling.
2107         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2108         * dwarf-index-write.c: Use C++ exception handling.
2109         * dwarf-index-cache.c: Use C++ exception handling.
2110         * dtrace-probe.c: Use C++ exception handling.
2111         * disasm-selftests.c: Use C++ exception handling.
2112         * darwin-nat.c: Use C++ exception handling.
2113         * cp-valprint.c: Use C++ exception handling.
2114         * cp-support.c: Use C++ exception handling.
2115         * cp-abi.c: Use C++ exception handling.
2116         * corelow.c: Use C++ exception handling.
2117         * completer.c: Use C++ exception handling.
2118         * compile/compile-object-run.c: Use C++ exception handling.
2119         * compile/compile-object-load.c: Use C++ exception handling.
2120         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2121         * compile/compile-c-symbols.c: Use C++ exception handling.
2122         * common/selftest.c: Use C++ exception handling.
2123         * common/new-op.c: Use C++ exception handling.
2124         * cli/cli-script.c: Use C++ exception handling.
2125         * cli/cli-interp.c: Use C++ exception handling.
2126         * cli/cli-cmds.c: Use C++ exception handling.
2127         * c-varobj.c: Use C++ exception handling.
2128         * btrace.c: Use C++ exception handling.
2129         * breakpoint.c: Use C++ exception handling.
2130         * break-catch-throw.c: Use C++ exception handling.
2131         * arch-utils.c: Use C++ exception handling.
2132         * amd64-tdep.c: Use C++ exception handling.
2133         * ada-valprint.c: Use C++ exception handling.
2134         * ada-typeprint.c: Use C++ exception handling.
2135         * ada-lang.c: Use C++ exception handling.
2136         * aarch64-tdep.c: Use C++ exception handling.
2137
2138 2019-04-08  Tom Tromey  <tom@tromey.com>
2139
2140         * xml-support.c (gdb_xml_parser::parse): Update.
2141         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2142         * value.c (show_convenience): Update.
2143         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2144         (test_parse_flags_qcs): Update.
2145         * thread.c (thr_try_catch_cmd): Update.
2146         * target.c (target_translate_tls_address): Update.
2147         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2148         (info_frame_command_core, frame_apply_command_count): Update.
2149         * rust-exp.y (rust_lex_exception_test): Update.
2150         * riscv-tdep.c (riscv_print_one_register_info): Update.
2151         * remote.c (remote_target::enable_btrace): Update.
2152         * record-btrace.c (record_btrace_enable_warn): Update.
2153         * python/py-utils.c (gdbpy_convert_exception): Update.
2154         * printcmd.c (do_one_display, print_variable_and_value): Update.
2155         * mi/mi-main.c (mi_print_exception): Update.
2156         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2157         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2158         * linux-nat.c (linux_nat_target::attach): Update.
2159         * linux-fork.c (class scoped_switch_fork_info): Update.
2160         * infrun.c (displaced_step_prepare): Update.
2161         * infcall.c (call_function_by_hand_dummy): Update.
2162         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2163         * gnu-v3-abi.c (print_one_vtable): Update.
2164         * frame.c (get_prev_frame_always): Update.
2165         * f-valprint.c (info_common_command_for_block): Update.
2166         * exec.c (try_open_exec_file): Update.
2167         * exceptions.c (print_exception, exception_print)
2168         (exception_fprintf, exception_print_same): Update.
2169         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2170         * dwarf-index-cache.c (index_cache::store)
2171         (index_cache::lookup_gdb_index): Update.
2172         * darwin-nat.c (maybe_cache_shell): Update.
2173         * cp-valprint.c (cp_print_value_fields): Update.
2174         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2175         (gcc_cplus_symbol_address): Update.
2176         * compile/compile-c-symbols.c (gcc_convert_symbol)
2177         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2178         * common/selftest.c: Update.
2179         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2180         a std::string.
2181         (exception_try_scope_entry, exception_try_scope_exit): Don't
2182         declare.
2183         (struct exception_try_scope): Remove.
2184         (TRY): Don't use exception_try_scope.
2185         (struct gdb_exception): Add constructor, operator=.
2186         <what>: New method.
2187         (struct gdb_exception_RETURN_MASK_ALL)
2188         (struct gdb_exception_RETURN_MASK_ERROR)
2189         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2190         (struct gdb_quit_bad_alloc): Update.
2191         * common/common-exceptions.c (exception_none): Change
2192         initializer.
2193         (struct catcher) <state, exception>: Initialize inline.
2194         <prev>: Remove member.
2195         (current_catcher): Remove.
2196         (catchers): New global.
2197         (exceptions_state_mc_init): Simplify.
2198         (catcher_pop): Remove.
2199         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2200         (try_scope_depth, exception_try_scope_entry)
2201         (exception_try_scope_exit): Remove.
2202         (throw_exception_sjlj): Update.
2203         (exception_messages, exception_messages_size): Remove.
2204         (throw_it): Simplify.
2205         (gdb_exception_sliced_copy): Remove.
2206         (throw_exception_cxx): Update.
2207         * cli/cli-script.c (script_from_file): Update.
2208         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2209         Update.
2210         * ada-valprint.c (ada_val_print): Update.
2211         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2212         (create_excep_cond_exprs): Update.
2213
2214 2019-04-08  Tom Tromey  <tom@tromey.com>
2215
2216         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2217         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2218         (TRY, CATCH, END_CATCH): Remove some definitions.
2219         * common/common-exceptions.c: Don't use GDB_XCPT.
2220         (catcher_list_size): Remove.
2221         (throw_exception, throw_it): Simplify.
2222
2223 2019-04-05  Tom Tromey  <tom@tromey.com>
2224
2225         Revert the header-sorting patch.
2226         * ft32-tdep.c: Revert.
2227         * frv-tdep.c: Revert.
2228         * frv-linux-tdep.c: Revert.
2229         * frame.c: Revert.
2230         * frame-unwind.c: Revert.
2231         * frame-base.c: Revert.
2232         * fork-child.c: Revert.
2233         * findvar.c: Revert.
2234         * findcmd.c: Revert.
2235         * filesystem.c: Revert.
2236         * filename-seen-cache.h: Revert.
2237         * filename-seen-cache.c: Revert.
2238         * fbsd-tdep.c: Revert.
2239         * fbsd-nat.h: Revert.
2240         * fbsd-nat.c: Revert.
2241         * f-valprint.c: Revert.
2242         * f-typeprint.c: Revert.
2243         * f-lang.c: Revert.
2244         * extension.h: Revert.
2245         * extension.c: Revert.
2246         * extension-priv.h: Revert.
2247         * expprint.c: Revert.
2248         * exec.h: Revert.
2249         * exec.c: Revert.
2250         * exceptions.c: Revert.
2251         * event-top.c: Revert.
2252         * event-loop.c: Revert.
2253         * eval.c: Revert.
2254         * elfread.c: Revert.
2255         * dwarf2read.h: Revert.
2256         * dwarf2read.c: Revert.
2257         * dwarf2loc.c: Revert.
2258         * dwarf2expr.h: Revert.
2259         * dwarf2expr.c: Revert.
2260         * dwarf2-frame.c: Revert.
2261         * dwarf2-frame-tailcall.c: Revert.
2262         * dwarf-index-write.h: Revert.
2263         * dwarf-index-write.c: Revert.
2264         * dwarf-index-common.c: Revert.
2265         * dwarf-index-cache.h: Revert.
2266         * dwarf-index-cache.c: Revert.
2267         * dummy-frame.c: Revert.
2268         * dtrace-probe.c: Revert.
2269         * disasm.h: Revert.
2270         * disasm.c: Revert.
2271         * disasm-selftests.c: Revert.
2272         * dictionary.c: Revert.
2273         * dicos-tdep.c: Revert.
2274         * demangle.c: Revert.
2275         * dcache.h: Revert.
2276         * dcache.c: Revert.
2277         * darwin-nat.h: Revert.
2278         * darwin-nat.c: Revert.
2279         * darwin-nat-info.c: Revert.
2280         * d-valprint.c: Revert.
2281         * d-namespace.c: Revert.
2282         * d-lang.c: Revert.
2283         * ctf.c: Revert.
2284         * csky-tdep.c: Revert.
2285         * csky-linux-tdep.c: Revert.
2286         * cris-tdep.c: Revert.
2287         * cris-linux-tdep.c: Revert.
2288         * cp-valprint.c: Revert.
2289         * cp-support.c: Revert.
2290         * cp-namespace.c: Revert.
2291         * cp-abi.c: Revert.
2292         * corelow.c: Revert.
2293         * corefile.c: Revert.
2294         * continuations.c: Revert.
2295         * completer.h: Revert.
2296         * completer.c: Revert.
2297         * complaints.c: Revert.
2298         * coffread.c: Revert.
2299         * coff-pe-read.c: Revert.
2300         * cli-out.h: Revert.
2301         * cli-out.c: Revert.
2302         * charset.c: Revert.
2303         * c-varobj.c: Revert.
2304         * c-valprint.c: Revert.
2305         * c-typeprint.c: Revert.
2306         * c-lang.c: Revert.
2307         * buildsym.c: Revert.
2308         * buildsym-legacy.c: Revert.
2309         * build-id.h: Revert.
2310         * build-id.c: Revert.
2311         * btrace.c: Revert.
2312         * bsd-uthread.c: Revert.
2313         * breakpoint.h: Revert.
2314         * breakpoint.c: Revert.
2315         * break-catch-throw.c: Revert.
2316         * break-catch-syscall.c: Revert.
2317         * break-catch-sig.c: Revert.
2318         * blockframe.c: Revert.
2319         * block.c: Revert.
2320         * bfin-tdep.c: Revert.
2321         * bfin-linux-tdep.c: Revert.
2322         * bfd-target.c: Revert.
2323         * bcache.c: Revert.
2324         * ax-general.c: Revert.
2325         * ax-gdb.h: Revert.
2326         * ax-gdb.c: Revert.
2327         * avr-tdep.c: Revert.
2328         * auxv.c: Revert.
2329         * auto-load.c: Revert.
2330         * arm-wince-tdep.c: Revert.
2331         * arm-tdep.c: Revert.
2332         * arm-symbian-tdep.c: Revert.
2333         * arm-pikeos-tdep.c: Revert.
2334         * arm-obsd-tdep.c: Revert.
2335         * arm-nbsd-tdep.c: Revert.
2336         * arm-nbsd-nat.c: Revert.
2337         * arm-linux-tdep.c: Revert.
2338         * arm-linux-nat.c: Revert.
2339         * arm-fbsd-tdep.c: Revert.
2340         * arm-fbsd-nat.c: Revert.
2341         * arm-bsd-tdep.c: Revert.
2342         * arch-utils.c: Revert.
2343         * arc-tdep.c: Revert.
2344         * arc-newlib-tdep.c: Revert.
2345         * annotate.h: Revert.
2346         * annotate.c: Revert.
2347         * amd64-windows-tdep.c: Revert.
2348         * amd64-windows-nat.c: Revert.
2349         * amd64-tdep.c: Revert.
2350         * amd64-sol2-tdep.c: Revert.
2351         * amd64-obsd-tdep.c: Revert.
2352         * amd64-obsd-nat.c: Revert.
2353         * amd64-nbsd-tdep.c: Revert.
2354         * amd64-nbsd-nat.c: Revert.
2355         * amd64-nat.c: Revert.
2356         * amd64-linux-tdep.c: Revert.
2357         * amd64-linux-nat.c: Revert.
2358         * amd64-fbsd-tdep.c: Revert.
2359         * amd64-fbsd-nat.c: Revert.
2360         * amd64-dicos-tdep.c: Revert.
2361         * amd64-darwin-tdep.c: Revert.
2362         * amd64-bsd-nat.c: Revert.
2363         * alpha-tdep.c: Revert.
2364         * alpha-obsd-tdep.c: Revert.
2365         * alpha-nbsd-tdep.c: Revert.
2366         * alpha-mdebug-tdep.c: Revert.
2367         * alpha-linux-tdep.c: Revert.
2368         * alpha-linux-nat.c: Revert.
2369         * alpha-bsd-tdep.c: Revert.
2370         * alpha-bsd-nat.c: Revert.
2371         * aix-thread.c: Revert.
2372         * agent.c: Revert.
2373         * addrmap.c: Revert.
2374         * ada-varobj.c: Revert.
2375         * ada-valprint.c: Revert.
2376         * ada-typeprint.c: Revert.
2377         * ada-tasks.c: Revert.
2378         * ada-lang.c: Revert.
2379         * aarch64-tdep.c: Revert.
2380         * aarch64-ravenscar-thread.c: Revert.
2381         * aarch64-newlib-tdep.c: Revert.
2382         * aarch64-linux-tdep.c: Revert.
2383         * aarch64-linux-nat.c: Revert.
2384         * aarch64-fbsd-tdep.c: Revert.
2385         * aarch64-fbsd-nat.c: Revert.
2386         * aarch32-linux-nat.c: Revert.
2387
2388 2019-04-05  Tom Tromey  <tom@tromey.com>
2389
2390         * ft32-tdep.c: Sort headers.
2391         * frv-tdep.c: Sort headers.
2392         * frv-linux-tdep.c: Sort headers.
2393         * frame.c: Sort headers.
2394         * frame-unwind.c: Sort headers.
2395         * frame-base.c: Sort headers.
2396         * fork-child.c: Sort headers.
2397         * findvar.c: Sort headers.
2398         * findcmd.c: Sort headers.
2399         * filesystem.c: Sort headers.
2400         * filename-seen-cache.h: Sort headers.
2401         * filename-seen-cache.c: Sort headers.
2402         * fbsd-tdep.c: Sort headers.
2403         * fbsd-nat.h: Sort headers.
2404         * fbsd-nat.c: Sort headers.
2405         * f-valprint.c: Sort headers.
2406         * f-typeprint.c: Sort headers.
2407         * f-lang.c: Sort headers.
2408         * extension.h: Sort headers.
2409         * extension.c: Sort headers.
2410         * extension-priv.h: Sort headers.
2411         * expprint.c: Sort headers.
2412         * exec.h: Sort headers.
2413         * exec.c: Sort headers.
2414         * exceptions.c: Sort headers.
2415         * event-top.c: Sort headers.
2416         * event-loop.c: Sort headers.
2417         * eval.c: Sort headers.
2418         * elfread.c: Sort headers.
2419         * dwarf2read.h: Sort headers.
2420         * dwarf2read.c: Sort headers.
2421         * dwarf2loc.c: Sort headers.
2422         * dwarf2expr.h: Sort headers.
2423         * dwarf2expr.c: Sort headers.
2424         * dwarf2-frame.c: Sort headers.
2425         * dwarf2-frame-tailcall.c: Sort headers.
2426         * dwarf-index-write.h: Sort headers.
2427         * dwarf-index-write.c: Sort headers.
2428         * dwarf-index-common.c: Sort headers.
2429         * dwarf-index-cache.h: Sort headers.
2430         * dwarf-index-cache.c: Sort headers.
2431         * dummy-frame.c: Sort headers.
2432         * dtrace-probe.c: Sort headers.
2433         * disasm.h: Sort headers.
2434         * disasm.c: Sort headers.
2435         * disasm-selftests.c: Sort headers.
2436         * dictionary.c: Sort headers.
2437         * dicos-tdep.c: Sort headers.
2438         * demangle.c: Sort headers.
2439         * dcache.h: Sort headers.
2440         * dcache.c: Sort headers.
2441         * darwin-nat.h: Sort headers.
2442         * darwin-nat.c: Sort headers.
2443         * darwin-nat-info.c: Sort headers.
2444         * d-valprint.c: Sort headers.
2445         * d-namespace.c: Sort headers.
2446         * d-lang.c: Sort headers.
2447         * ctf.c: Sort headers.
2448         * csky-tdep.c: Sort headers.
2449         * csky-linux-tdep.c: Sort headers.
2450         * cris-tdep.c: Sort headers.
2451         * cris-linux-tdep.c: Sort headers.
2452         * cp-valprint.c: Sort headers.
2453         * cp-support.c: Sort headers.
2454         * cp-namespace.c: Sort headers.
2455         * cp-abi.c: Sort headers.
2456         * corelow.c: Sort headers.
2457         * corefile.c: Sort headers.
2458         * continuations.c: Sort headers.
2459         * completer.h: Sort headers.
2460         * completer.c: Sort headers.
2461         * complaints.c: Sort headers.
2462         * coffread.c: Sort headers.
2463         * coff-pe-read.c: Sort headers.
2464         * cli-out.h: Sort headers.
2465         * cli-out.c: Sort headers.
2466         * charset.c: Sort headers.
2467         * c-varobj.c: Sort headers.
2468         * c-valprint.c: Sort headers.
2469         * c-typeprint.c: Sort headers.
2470         * c-lang.c: Sort headers.
2471         * buildsym.c: Sort headers.
2472         * buildsym-legacy.c: Sort headers.
2473         * build-id.h: Sort headers.
2474         * build-id.c: Sort headers.
2475         * btrace.c: Sort headers.
2476         * bsd-uthread.c: Sort headers.
2477         * breakpoint.h: Sort headers.
2478         * breakpoint.c: Sort headers.
2479         * break-catch-throw.c: Sort headers.
2480         * break-catch-syscall.c: Sort headers.
2481         * break-catch-sig.c: Sort headers.
2482         * blockframe.c: Sort headers.
2483         * block.c: Sort headers.
2484         * bfin-tdep.c: Sort headers.
2485         * bfin-linux-tdep.c: Sort headers.
2486         * bfd-target.c: Sort headers.
2487         * bcache.c: Sort headers.
2488         * ax-general.c: Sort headers.
2489         * ax-gdb.h: Sort headers.
2490         * ax-gdb.c: Sort headers.
2491         * avr-tdep.c: Sort headers.
2492         * auxv.c: Sort headers.
2493         * auto-load.c: Sort headers.
2494         * arm-wince-tdep.c: Sort headers.
2495         * arm-tdep.c: Sort headers.
2496         * arm-symbian-tdep.c: Sort headers.
2497         * arm-pikeos-tdep.c: Sort headers.
2498         * arm-obsd-tdep.c: Sort headers.
2499         * arm-nbsd-tdep.c: Sort headers.
2500         * arm-nbsd-nat.c: Sort headers.
2501         * arm-linux-tdep.c: Sort headers.
2502         * arm-linux-nat.c: Sort headers.
2503         * arm-fbsd-tdep.c: Sort headers.
2504         * arm-fbsd-nat.c: Sort headers.
2505         * arm-bsd-tdep.c: Sort headers.
2506         * arch-utils.c: Sort headers.
2507         * arc-tdep.c: Sort headers.
2508         * arc-newlib-tdep.c: Sort headers.
2509         * annotate.h: Sort headers.
2510         * annotate.c: Sort headers.
2511         * amd64-windows-tdep.c: Sort headers.
2512         * amd64-windows-nat.c: Sort headers.
2513         * amd64-tdep.c: Sort headers.
2514         * amd64-sol2-tdep.c: Sort headers.
2515         * amd64-obsd-tdep.c: Sort headers.
2516         * amd64-obsd-nat.c: Sort headers.
2517         * amd64-nbsd-tdep.c: Sort headers.
2518         * amd64-nbsd-nat.c: Sort headers.
2519         * amd64-nat.c: Sort headers.
2520         * amd64-linux-tdep.c: Sort headers.
2521         * amd64-linux-nat.c: Sort headers.
2522         * amd64-fbsd-tdep.c: Sort headers.
2523         * amd64-fbsd-nat.c: Sort headers.
2524         * amd64-dicos-tdep.c: Sort headers.
2525         * amd64-darwin-tdep.c: Sort headers.
2526         * amd64-bsd-nat.c: Sort headers.
2527         * alpha-tdep.c: Sort headers.
2528         * alpha-obsd-tdep.c: Sort headers.
2529         * alpha-nbsd-tdep.c: Sort headers.
2530         * alpha-mdebug-tdep.c: Sort headers.
2531         * alpha-linux-tdep.c: Sort headers.
2532         * alpha-linux-nat.c: Sort headers.
2533         * alpha-bsd-tdep.c: Sort headers.
2534         * alpha-bsd-nat.c: Sort headers.
2535         * aix-thread.c: Sort headers.
2536         * agent.c: Sort headers.
2537         * addrmap.c: Sort headers.
2538         * ada-varobj.c: Sort headers.
2539         * ada-valprint.c: Sort headers.
2540         * ada-typeprint.c: Sort headers.
2541         * ada-tasks.c: Sort headers.
2542         * ada-lang.c: Sort headers.
2543         * aarch64-tdep.c: Sort headers.
2544         * aarch64-ravenscar-thread.c: Sort headers.
2545         * aarch64-newlib-tdep.c: Sort headers.
2546         * aarch64-linux-tdep.c: Sort headers.
2547         * aarch64-linux-nat.c: Sort headers.
2548         * aarch64-fbsd-tdep.c: Sort headers.
2549         * aarch64-fbsd-nat.c: Sort headers.
2550         * aarch32-linux-nat.c: Sort headers.
2551
2552 2019-04-04  Tom Tromey  <tom@tromey.com>
2553
2554         * varobj.c (varobj_create): Update.
2555         * rust-exp.y (struct rust_parser) <update_innermost_block,
2556         lookup_symbol>: New methods.
2557         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2558         Rename.
2559         (rust_parser::rust_lookup_type)
2560         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2561         * printcmd.c (display_command, do_one_display): Update.
2562         * parser-defs.h (struct parser_state) <parser_state>: Add
2563         "tracker" parameter.
2564         (block_tracker): New member.
2565         (class innermost_block_tracker) <innermost_block_tracker>: Add
2566         "types" parameter.
2567         <reset>: Remove method.
2568         (innermost_block): Don't declare.
2569         (null_post_parser): Update.
2570         * parse.c (innermost_block): Remove global.
2571         (write_dollar_variable): Update.
2572         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2573         Remove "tracker_types" parameter.
2574         (parse_expression): Add "tracker" parameter.
2575         (parse_expression_for_completion): Update.
2576         (null_post_parser): Add "tracker" parameter.
2577         * p-exp.y: Update rules.
2578         * m2-exp.y: Update rules.
2579         * language.h (struct language_defn) <la_post_parser>: Add
2580         "tracker" parameter.
2581         * go-exp.y: Update rules.
2582         * f-exp.y: Update rules.
2583         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2584         parameter.
2585         * d-exp.y: Update rules.
2586         * c-exp.y: Update rules.
2587         * breakpoint.c (set_breakpoint_condition): Create an
2588         innermost_block_tracker.
2589         (watch_command_1): Likewise.
2590         * ada-lang.c (resolve): Add "tracker" parameter.
2591         (resolve_subexp): Likewise.
2592         * ada-exp.y (write_var_from_sym): Update.
2593
2594 2019-04-04  Tom Tromey  <tom@tromey.com>
2595
2596         * type-stack.h: New file.
2597         * type-stack.c: New file.
2598         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2599         type-stack.h.
2600         (insert_into_type_stack, insert_type, push_type, push_type_int)
2601         (insert_type_address_space, pop_type, pop_type_int)
2602         (pop_typelist, pop_type_stack, append_type_stack)
2603         (push_type_stack, get_type_stack, push_typelist)
2604         (follow_type_instance_flags, follow_types): Don't declare.
2605         * parse.c (type_stack): Remove global.
2606         (parse_exp_in_context): Update.
2607         (insert_into_type_stack, insert_type, push_type, push_type_int)
2608         (insert_type_address_space, pop_type, pop_type_int)
2609         (pop_typelist, pop_type_stack, append_type_stack)
2610         (push_type_stack, get_type_stack, push_typelist)
2611         (follow_type_instance_flags, follow_types): Remove (moved to
2612         type-stack.c).
2613         * f-exp.y (type_stack): New global.
2614         Update rules.
2615         (push_kind_type, f_parse): Update.
2616         * d-exp.y (type_stack): New global.
2617         Update rules.
2618         (d_parse): Update.
2619         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2620         Update rules.
2621         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2622         (HFILES_NO_SRCDIR): Add type-stack.h.
2623
2624 2019-04-04  Tom Tromey  <tom@tromey.com>
2625
2626         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2627         (rust_parser::convert_ast_to_expression, rust_parse)
2628         (rust_lex_test_completion, rust_lex_tests): Update.
2629         * parser-defs.h (struct expr_completion_state): New.
2630         (struct parser_state) <parser_state>: Add completion parameter.
2631         <mark_struct_expression, mark_completion_tag>: New methods.
2632         <parse_completion, m_completion_state>: New members.
2633         (prefixify_expression, null_post_parser): Update.
2634         (mark_struct_expression, mark_completion_tag): Don't declare.
2635         * parse.c (parse_completion, expout_last_struct)
2636         (expout_tag_completion_type, expout_completion_name): Remove
2637         globals.
2638         (parser_state::mark_struct_expression)
2639         (parser_state::mark_completion_tag): Now methods.
2640         (prefixify_expression): Add last_struct parameter.
2641         (prefixify_subexp): Likewise.
2642         (parse_exp_1): Update.
2643         (parse_exp_in_context): Add cstate parameter.  Update.
2644         (parse_expression_for_completion): Create an
2645         expr_completion_state.
2646         (null_post_parser): Add "completion" parameter.
2647         * p-exp.y: Update rules.
2648         (yylex): Update.
2649         * language.h (struct language_defn) <la_post_parser>: Add
2650         "completing" parameter.
2651         * go-exp.y: Update rules.
2652         (lex_one_token): Update.
2653         * expression.h (parse_completion): Don't declare.
2654         * d-exp.y: Update rules.
2655         (lex_one_token): Update rules.
2656         * c-exp.y: Update rules.
2657         (lex_one_token): Update.
2658         * ada-lang.c (resolve): Add "parse_completion" parameter.
2659         (resolve_subexp): Likewise.
2660         (ada_resolve_function): Likewise.
2661
2662 2019-04-04  Tom Tromey  <tom@tromey.com>
2663
2664         * parser-defs.h (struct parser_state) <start_arglist,
2665         end_arglist>: New methods.
2666         <arglist_len, m_funcall_chain>: New members.
2667         (arglist_len, start_arglist, end_arglist): Don't declare.
2668         * parse.c (arglist_len, funcall_chain): Remove global.
2669         (start_arglist, end_arglist): Remove functions.
2670         (parse_exp_in_context): Update.
2671         * p-exp.y: Update rules.
2672         * m2-exp.y: Update rules.
2673         * go-exp.y: Update rules.
2674         * f-exp.y: Update rules.
2675         * d-exp.y: Update rules.
2676         * c-exp.y: Update rules.
2677
2678 2019-04-04  Tom Tromey  <tom@tromey.com>
2679
2680         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2681         lex_operator, push_back>: New methods.
2682         Update all rules.
2683         (rust_parser::lex_hex, lex_escape): Rename and update.
2684         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2685         (rust_parser::lex_operator): Rename and update.
2686         (rust_parser::lex_number, rustyylex, rustyyerror)
2687         (rust_lex_test_init, rust_lex_test_sequence)
2688         (rust_lex_test_push_back, rust_lex_tests): Update.
2689         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2690         parameter.
2691         <lexptr, prev_lexptr>: New members.
2692         (lexptr, prev_lexptr): Don't declare.
2693         * parse.c (lexptr, prev_lexptr): Remove globals.
2694         (parse_exp_in_context): Update.
2695         * p-exp.y (yylex, yyerror): Update.
2696         * m2-exp.y (parse_number, yylex, yyerror): Update.
2697         * go-exp.y (lex_one_token, yyerror): Update.
2698         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2699         * d-exp.y (lex_one_token, yyerror): Update.
2700         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2701         (lex_one_token, yyerror): Update.
2702         * ada-lex.l (YY_INPUT): Update.
2703         (rewind_to_char): Update.
2704         * ada-exp.y (yyerror): Update.
2705
2706 2019-04-04  Tom Tromey  <tom@tromey.com>
2707
2708         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2709         * parser-defs.h (struct parser_state) <parser_state>: Add new
2710         parameter.
2711         <comma_terminates>: New member.
2712         (comma_terminates): Don't declare global.
2713         * parse.c (comma_terminates): Remove global.
2714         (parse_exp_in_context): Update.
2715         * p-exp.y (yylex): Update.
2716         * m2-exp.y (yylex): Update.
2717         * go-exp.y (lex_one_token): Update.
2718         * f-exp.y (yylex): Update.
2719         * d-exp.y (lex_one_token): Update.
2720         * c-exp.y (lex_one_token): Update.
2721         * ada-lex.l: Update.
2722
2723 2019-04-04  Tom Tromey  <tom@tromey.com>
2724
2725         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2726         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2727         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2728         * parser-defs.h (paren_depth): Don't declare.
2729         * parse.c (paren_depth): Remove global.
2730         (parse_exp_in_context): Update.
2731         * p-exp.y (paren_depth): New global.
2732         (pascal_parse): Initialize it.
2733         * m2-exp.y (paren_depth): New global.
2734         (m2_parse): Initialize it.
2735         * go-exp.y (paren_depth): New global.
2736         (go_parse): Initialize it.
2737         * f-exp.y (paren_depth): New global.
2738         (f_parse): Initialize it.
2739         * d-exp.y (paren_depth): New global.
2740         (d_parse): Initialize it.
2741         * c-exp.y (paren_depth): New global.
2742         (c_parse): Initialize it.
2743         * ada-lex.l (paren_depth): New global.
2744         (lexer_init): Initialize it.
2745
2746 2019-04-04  Tom Tromey  <tom@tromey.com>
2747
2748         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2749         (rust_parser::convert_ast_to_type)
2750         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2751         * parser-defs.h (struct parser_state) <parser_state>: Add
2752         parameters.  Initialize new members.
2753         <expression_context_block, expression_context_pc>: New members.
2754         * parse.c (expression_context_block, expression_context_pc):
2755         Remove globals.
2756         (parse_exp_in_context): Update.
2757         * p-exp.y: Update all rules.
2758         (yylex): Update.
2759         * m2-exp.y: Update all rules.
2760         (yylex): Update.
2761         * go-exp.y (yylex): Update.
2762         * f-exp.y (yylex): Update.
2763         * d-exp.y: Update all rules.
2764         (yylex): Update.
2765         * c-exp.y: Update all rules.
2766         (lex_one_token, classify_name, yylex, c_parse): Update.
2767         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2768
2769 2019-04-04  Tom Tromey  <tom@tromey.com>
2770
2771         * gdbarch.h, gdbarch.c: Rebuild.
2772         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2773         * stap-probe.h:
2774         (struct stap_parse_info): Replace "parser_state" with
2775         "expr_builder".
2776         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2777         (parser_state): New class.
2778         * parse.c (expr_builder): Rename.
2779         (expr_builder::release): Rename.
2780         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2781         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2782         (write_exp_elt_longcst, write_exp_elt_floatcst)
2783         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2784         (write_exp_string_vector, write_exp_bitstring)
2785         (write_exp_msymbol, mark_struct_expression)
2786         (write_dollar_variable)
2787         (insert_type_address_space, increase_expout_size): Replace
2788         "parser_state" with "expr_builder".
2789         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2790         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2791         "parser_state" with "expr_builder".
2792
2793 2019-04-04  Tom Tromey  <tom@tromey.com>
2794
2795         * rust-exp.y: Replace "parse_language" with method call.
2796         * p-exp.y:
2797         (yylex): Replace "parse_language" with method call.
2798         * m2-exp.y:
2799         (yylex): Replace "parse_language" with method call.
2800         * go-exp.y (classify_name): Replace "parse_language" with method
2801         call.
2802         * f-exp.y (yylex): Replace "parse_language" with method call.
2803         * d-exp.y (lex_one_token): Replace "parse_language" with method
2804         call.
2805         * c-exp.y:
2806         (lex_one_token, classify_name, yylex): Replace "parse_language"
2807         with method call.
2808         * ada-exp.y (find_primitive_type, type_char)
2809         (type_system_address): Replace "parse_language" with method call.
2810
2811 2019-04-04  Tom Tromey  <tom@tromey.com>
2812
2813         * rust-exp.y: Replace "parse_gdbarch" with method call.
2814         * parse.c (write_dollar_variable, insert_type_address_space):
2815         Replace "parse_gdbarch" with method call.
2816         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2817         call.
2818         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2819         call.
2820         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2821         "parse_gdbarch" with method call.
2822         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2823         with method call.
2824         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2825         "parse_gdbarch" with method call.
2826         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2827         "parse_gdbarch" with method call.
2828         * c-exp.y (parse_type, parse_number, classify_name): Replace
2829         "parse_gdbarch" with method call.
2830         * ada-lex.l: Replace "parse_gdbarch" with method call.
2831         * ada-exp.y (parse_type, find_primitive_type, type_char)
2832         (type_system_address): Replace "parse_gdbarch" with method call.
2833
2834 2019-04-04  Tom Tromey  <tom@tromey.com>
2835
2836         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2837         * stap-probe.c (stap_parse_argument): Update.
2838         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2839         initial_size parameter.
2840         * rust-exp.y (rust_lex_tests): Update.
2841         * parse.c (parser_state): Update.
2842         (parse_exp_in_context): Update.
2843         * parser-defs.h (struct parser_state) <parser_state>: Remove
2844         "initial_size" parameter.
2845
2846 2019-04-04  Tom Tromey  <tom@tromey.com>
2847
2848         * parser-defs.h (increase_expout_size): Don't declare.
2849         * parse.c (increase_expout_size): Now static.
2850
2851 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2852
2853         * gnu-nat.c (gnu_nat_target::wait): Fix
2854         target_waitstatus_to_string call.
2855
2856 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2857
2858         * eval.c (evaluate_subexp_standard): Handle internal functions
2859         during Fortran function call handling.
2860
2861 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2862
2863         * NEWS: Mention new internal functions.
2864         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2865         (read_base_type): Use dwarf2_init_complex_target_type.
2866         * value.c (creal_internal_fn): New function.
2867         (cimag_internal_fn): New function.
2868         (_initialize_values): Register new internal functions.
2869
2870 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2871
2872         * infrun.c (stop_all_threads): If debug_infrun, always
2873         trace the wait status after wait_one, using
2874         target_waitstatus_to_string and target_pid_to_str.
2875         (handle_inferior_event): Replace various trace of
2876         wait status kind by a single trace.
2877         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2878         wait status kind image by target_waitstatus_to_string.
2879         * target/waitstatus.c (target_waitstatus_to_string): Fix
2880         obsolete comment.
2881
2882 2019-04-01  Tom Tromey  <tromey@adacore.com>
2883
2884         PR symtab/23331:
2885         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2886
2887 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2888             Pedro Alves  <palves@redhat.com>
2889
2890         * top.c (quit_force): Call 'finalize_values'.
2891         * value.c (finalize_values): New function.
2892         * value.h (finalize_values): Declare.
2893
2894 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2895
2896         * NEWS: Announce $_gdb_major and $_gdb_minor.
2897
2898         * top.c (init_gdb_version_vars): New function.
2899         (gdb_init): Call init_gdb_version_vars.
2900
2901 2019-03-29  Tom Tromey  <tromey@adacore.com>
2902
2903         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2904         help text.  Remove dead code.
2905
2906 2019-03-29  Keith Seitz  <keiths@redhat.com>
2907
2908         From Siddhesh Poyarekar:
2909         * f-lang.h (f77_get_upperbound): Return LONGEST.
2910         (f77_get_lowerbound): Likewise.
2911         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2912         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2913         print them.
2914         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2915         plongest to format print it.
2916         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2917         (f77_get_upperbound): Likewise.
2918         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2919         LOWER_BOUND to LONGEST.
2920         (f77_create_arrayprint_offset_tbl): Likewise.
2921
2922 2019-03-29  Keith Seitz  <keiths@redhat.com>
2923
2924         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2925         %s/pulongest for TYPE_LENGTH instead of %d in format
2926         strings.
2927         * ada-typerint.c (ada_print_type): Likewise.
2928         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2929         * compile/compile-c-support.c (generate_register_struct): Likewise.
2930         * gdbtypes.c (recursive_dump_type): Likewise.
2931         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2932         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2933         instead of %d in format strings.
2934         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2935         to std::min to ULONGEST.
2936         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2937         instead of %d in format strings.
2938         * tracepoint.c (info_scope_command): Likewise.
2939         * typeprint.c (print_offset_data::update)
2940         (print_offset_data::finish): Likewise.
2941         * xtensa-tdep.c (xtensa_store_return_value)
2942         (xtensa_push_dummy_call): Likewise.
2943
2944 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2945
2946         * windows-nat.c (display_selector): Fixed format specifications
2947         for 64-bit Cygwin.
2948
2949 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2950
2951         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2952
2953 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2954
2955         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2956         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2957         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2958         (nios2_linux_init_abi): Install it.
2959
2960 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2961
2962         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2963
2964 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2965
2966         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2967
2968 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2969             Tom Tromey  <tromey@adacore.com>
2970
2971         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2972
2973 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2974
2975         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2976         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2977         method to compute the bounds of range types. Also print "[evaluated]"
2978         if the bounds' values come from a dynamic evaluation.
2979
2980 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2981
2982         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2983         whitespace when pretty printing is on.
2984
2985 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2986
2987         * ppc-linux-nat.c: Add include.
2988
2989 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2990
2991         * NEWS: Mention AArch64 Pointer Authentication.
2992
2993 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2994
2995         * arm-linux-nat.c: Add include.
2996
2997 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2998
2999         * source-cache.c (source_cache::get_source_lines): Re-read
3000         fullname after calling open_source_file.
3001
3002 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3003
3004         * NEWS: Mention TLS support for FreeBSD.
3005
3006 2019-03-25  Tom Tromey  <tromey@adacore.com>
3007
3008         * minsyms.c (BUNCH_SIZE): Update comment.
3009         (~minimal_symbol_reader): Remove old comment.
3010         (compact_minimal_symbols): Update comment.
3011         (minimal_symbol_reader::install): Remove old comment.  Update
3012         other comments.
3013
3014 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3015
3016         * s390-linux-nat.c: Add include.
3017
3018 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3019
3020         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3021         Call linux_get_hwcap.
3022         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3023         Likewise.
3024         (aarch64_linux_get_hwcap): Remove function.
3025         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3026         declaration.
3027         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3028         linux_get_hwcap.
3029         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3030         * linux-tdep.c (linux_get_hwcap): Add function.
3031         (linux_get_hwcap2): Likewise.
3032         * linux-tdep.h (linux_get_hwcap): Add declaration.
3033         (linux_get_hwcap2): Likewise.
3034         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3035         (ppc_linux_get_hwcap2): Likewise.
3036         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3037         linux_get_hwcap.
3038         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3039         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3040         (ppc_linux_nat_target::read_description): Likewise.
3041         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3042         * s390-linux-nat.c: Likewise.
3043         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3044
3045 2019-03-24  Tom Tromey  <tom@tromey.com>
3046
3047         * ada-lang.c (standard_lookup): Simplify initialization.
3048         (ada_lookup_symbol_nonlocal): Simplify return.
3049         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3050         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3051         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3052         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3053         initialization.
3054         * solib.c (solib_global_lookup): Simplify.
3055         * symtab.c (null_block_symbol): Remove.
3056         (symbol_cache_lookup): Simplify returns.
3057         (lookup_language_this): Simplify returns.
3058         (lookup_symbol_aux): Simplify return.
3059         (lookup_local_symbol): Simplify returns.
3060         (lookup_global_symbol_from_objfile): Simplify return.
3061         (lookup_symbol_in_objfile_symtabs)
3062         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3063         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3064         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3065         * cp-namespace.c (cp_lookup_bare_symbol)
3066         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3067         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3068         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3069         (cp_lookup_symbol_via_imports): Simplify initialization.
3070         (find_symbol_in_baseclass): Likewise.
3071         * symtab.h (null_block_symbol): Remove.
3072         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3073         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3074         (d_lookup_symbol_module): Likewise.
3075         (find_symbol_in_baseclass): Simplify initialization.
3076
3077 2019-03-24  Tom Tromey  <tom@tromey.com>
3078
3079         * expression.h: Don't include symtab.h.
3080         (struct block): Forward declare.
3081
3082 2019-03-24  Tom Tromey  <tom@tromey.com>
3083
3084         * c-exp.y (typebase): Remove casts.
3085         * gdbtypes.c (lookup_unsigned_typename, )
3086         (lookup_signed_typename): Remove cast.
3087         * eval.c (parse_to_comma_and_eval): Remove cast.
3088         * parse.c (write_dollar_variable): Remove cast.
3089         * block.h (struct block) <superblock>: Now const.
3090         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3091         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3092         (map_block): Make "block" const.
3093         * symfile.h (struct quick_symbol_functions)
3094         <map_matching_symbols>: Constify block argument to "callback".
3095         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3096         const.
3097         (find_pc_sect_compunit_symtab): Make "b" const.
3098         (find_symbol_at_address): Likewise.
3099         (search_symbols): Likewise.
3100         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3101         (dw2_debug_names_lookup_symbol): Likewise.
3102         (dw2_map_matching_symbols): Update.
3103         * p-valprint.c (pascal_val_print): Remove "block".
3104         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3105         (aux_add_nonlocal_symbols): Make "block" const.
3106         (resolve_subexp): Remove cast.
3107         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3108         const.
3109         (iterate_over_file_blocks): Likewise.
3110         * f-exp.y (%union) <bval>: Remove.
3111         * coffread.c (patch_opaque_types): Make "b" const.
3112         * spu-tdep.c (spu_catch_start): Make "block" const.
3113         * c-valprint.c (print_unpacked_pointer): Remove "block".
3114         * symmisc.c (dump_symtab_1): Make "b" const.
3115         (block_depth): Make "block" const.
3116         * d-exp.y (%union) <bval>: Remove.
3117         * cp-support.h (cp_lookup_rtti_type): Update.
3118         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3119         * psymtab.c (psym_lookup_symbol): Make "block" const.
3120         (maintenance_check_psymtabs): Make "b" const.
3121         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3122         (enumerate_locals, enumerate_args): Update.
3123         * python/py-symtab.c (stpy_global_block): Make "block" const.
3124         (stpy_static_block): Likewise.
3125         * inline-frame.c (block_starting_point_at): Make "new_block"
3126         const.
3127         * block.c (find_block_in_blockvector): Make return type const.
3128         (blockvector_for_pc_sect): Make "b" const.
3129         (find_block_in_blockvector): Make "b" const.
3130
3131 2019-03-23  Tom Tromey  <tom@tromey.com>
3132
3133         * varobj.c (varobj_create): Update.
3134         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3135         * printcmd.c (display_command, do_one_display): Don't reset
3136         innermost_block.
3137         * parser-defs.h (enum innermost_block_tracker_type): Move to
3138         expression.h.
3139         (innermost_block): Update comment.
3140         * parse.c (parse_exp_1): Add tracker_types parameter.
3141         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3142         tracker_types parameter.  Reset innermost_block.
3143         (parse_exp_in_context): Remove.
3144         (parse_expression_for_completion): Update.
3145         * objfiles.c (~objfile): Don't reset expression_context_block or
3146         innermost_block.
3147         * expression.h (enum innermost_block_tracker_type): Move from
3148         parser-defs.h.
3149         (parse_exp_1): Add tracker_types parameter.
3150         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3151         reset innermost_block.
3152
3153 2019-03-23  Tom Tromey  <tom@tromey.com>
3154
3155         * objfiles.h: Include bcache.h.
3156
3157 2019-03-23  Tom Tromey  <tom@tromey.com>
3158
3159         * linespec.c (get_current_search_block): Use
3160         scoped_restore_current_language.
3161         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3162
3163 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3164             Jiong Wang  <jiong.wang@arm.com>
3165
3166         * aarch64-linux-tdep.c
3167         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3168         section.
3169         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3170
3171 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3172             Jiong Wang  <jiong.wang@arm.com>
3173
3174         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3175         instructions.
3176         (aarch64_analyze_prologue_test): Add PACIASP test.
3177         (aarch64_prologue_prev_register): Unmask PC value.
3178
3179 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3180             Jiong Wang  <jiong.wang@arm.com>
3181
3182         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3183         (aarch64_dwarf2_prev_register): Unmask PC value.
3184         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3185         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3186         DW_CFA_AARCH64_negate_ra_state.
3187         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3188
3189 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3190             Jiong Wang  <jiong.wang@arm.com>
3191
3192         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3193         registers.
3194         (aarch64_pseudo_register_name): Likewise.
3195         (aarch64_pseudo_register_type): Likewise.
3196         (aarch64_pseudo_register_reggroup_p): Likewise.
3197         (aarch64_gdbarch_init): Add pauth registers.
3198         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3199         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3200         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3201         (struct gdbarch_tdep): Add regnum for ra_state.
3202
3203 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3204             Jiong Wang  <jiong.wang@arm.com>
3205
3206         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3207
3208 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3209             Jiong Wang  <jiong.wang@arm.com>
3210
3211         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3212         function.
3213         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3214         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3215         (aarch64_gdbarch_init): Add puth registers.
3216         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3217         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3218         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3219
3220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3221             Jiong Wang  <jiong.wang@arm.com>
3222
3223         * aarch64-linux-nat.c
3224         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3225         * aarch64-linux-tdep.c
3226         (aarch64_linux_core_read_description): Likewise.
3227         (aarch64_linux_get_hwcap): New function.
3228         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3229         (aarch64_linux_get_hwcap): New declaration.
3230
3231 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3232             Jiong Wang  <jiong.wang@arm.com>
3233
3234         * aarch64-linux-nat.c
3235         (aarch64_linux_nat_target::read_description): Add pauth param.
3236         * aarch64-linux-tdep.c
3237         (aarch64_linux_core_read_description): Likewise.
3238         * aarch64-tdep.c (struct target_desc): Add in pauth.
3239         (aarch64_read_description): Add pauth param.
3240         (aarch64_gdbarch_init): Likewise.
3241         * aarch64-tdep.h (aarch64_read_description): Likewise.
3242         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3243         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3244         * features/Makefile: Add new files.
3245         * features/aarch64-pauth.c: New file.
3246         * features/aarch64-pauth.xml: New file.
3247
3248 2019-03-20  Tom Tromey  <tromey@adacore.com>
3249
3250         * infrun.c (handle_inferior_event): Rename from
3251         handle_inferior_event_1.  Create a scoped_value_mark.
3252         (handle_inferior_event): Remove.
3253
3254 2019-03-19  Tom Tromey  <tromey@adacore.com>
3255
3256         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3257         * infrun.h (print_stop_event): Add "displays" parameter.
3258         * infrun.c (print_stop_event): Add "displays" parameter.
3259
3260 2019-03-19  Pedro Alves  <palves@redhat.com>
3261
3262         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3263         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3264         to -1.  Fix TABs vs spaces.
3265         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3266         * tui/tui-out.h (tui_ui_out) Add intro comments.
3267         <m_line, m_start_of_line>: In-class initialize, and add describing
3268         comment.
3269
3270 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3271
3272         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3273         variable names.
3274         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3275
3276 2019-03-18  Pedro Alves  <palves@redhat.com>
3277             Eli Zaretskii <eliz@gnu.org>
3278
3279         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3280         m_line and m_start_of_line.
3281
3282 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3283
3284         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3285         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3286         it returns a newline.  This fixes a regression in TU mode, whereby
3287         the next line is output on the same screen line as the user input.
3288
3289 2019-03-18  Tom Tromey  <tromey@adacore.com>
3290
3291         * minsyms.c (minimal_symbol_reader::install): Remove call to
3292         obstack_blank.
3293
3294 2019-03-18  Pedro Alves  <palves@redhat.com>
3295
3296         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3297         New globals.
3298         (apply_style): New, factored out from ...
3299         (apply_ansi_escape): ... this.  Handle reverse video mode.
3300         (tui_set_reverse_mode): New function.
3301         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3302         * tui/tui-winsource.c (tui_show_source_line): Use
3303         tui_set_reverse_mode instead of setting A_STANDOUT.
3304         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3305         New setter methods.
3306
3307 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3308
3309         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3310         Handle tabs.
3311
3312 2019-03-18  Tom Tromey  <tromey@adacore.com>
3313
3314         * ada-lang.c (empty_array): Add "high" parameter.
3315         (ada_evaluate_subexp): Update.
3316
3317 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3318
3319         * unittests/string_view-selftests.c: Define
3320         _initialize_string_view_selftests unconditionally.
3321
3322 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3323
3324         PR gdb/24350
3325         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3326
3327 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3328
3329         PR gdb/24351
3330         * windows-nat.c (display_selector): Fix format specifiers.
3331
3332 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3333
3334         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3335         tui_refill_source_window instead of tui_refresh_win, to update the
3336         current execution line.  This fixes redisplay of the current line
3337         when stepping through the code with "next" or "step".
3338
3339 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3340
3341         * source-cache.c (source_cache::get_source_lines): Call
3342         find_source_lines to initialize s->nlines.  This fixes vertical
3343         scrolling of TUI source window when the DOWN arrow is pressed.
3344
3345 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3346
3347         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3348         linux-thread-db.c (_initialize_thread_db): Likewise.
3349
3350 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3351
3352         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3353         wclrtoeol in tui_show_source_line".  This reverts changes made in
3354         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3355
3356 2019-03-15  Tom Tromey  <tom@tromey.com>
3357
3358         * symtab.h (struct minimal_symbol): Derive from
3359         general_symbol_info.
3360         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3361         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3362         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3363         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3364         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3365         (MSYMBOL_SEARCH_NAME): Update.
3366         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3367         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3368         * minsyms.c (minimal_symbol_reader::record_full): Update.
3369
3370 2019-03-15  Tom Tromey  <tom@tromey.com>
3371
3372         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3373
3374 2019-03-15  Tom Tromey  <tom@tromey.com>
3375
3376         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3377         unique_xmalloc_ptr.
3378         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3379         Update.
3380         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3381         (build_minimal_symbol_hash_tables)
3382         (minimal_symbol_reader::install): Update.
3383
3384 2019-03-15  Tom Tromey  <tom@tromey.com>
3385
3386         * symtab.c (create_demangled_names_hash): Update.
3387         (symbol_set_names): Update.
3388         * objfiles.h (struct objfile_per_bfd_storage)
3389         <demangled_names_hash>: Now an htab_up.
3390         * objfiles.c (objfile_per_bfd_storage): Simplify.
3391
3392 2019-03-15  Tom Tromey  <tom@tromey.com>
3393
3394         * objfiles.h (struct objfile_per_bfd_storage): Declare
3395         destructor.
3396         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3397         New.
3398         (get_objfile_bfd_data): Use new.  Don't initialize
3399         language_of_main.
3400         (free_objfile_per_bfd_storage): Remove.
3401         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3402
3403 2019-03-15  Tom Tromey  <tom@tromey.com>
3404
3405         * symfile.c (reread_symbols): Update.
3406         * objfiles.c (objfile::objfile): Update.
3407         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3408         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3409         comment.
3410         (minimal_symbol_reader::install): Update.
3411         (terminate_minimal_symbol_table): Remove.
3412         * jit.c (jit_object_close_impl): Update.
3413
3414 2019-03-15  Tom Tromey  <tom@tromey.com>
3415
3416         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3417         initializations.
3418
3419 2019-03-15  Tom Tromey  <tom@tromey.com>
3420
3421         * objfiles.h (struct objfile_per_bfd_storage)
3422         <demangled_hash_languages>: Now a bitset.
3423         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3424         (lookup_minimal_symbol): Update.
3425
3426 2019-03-15  Tom Tromey  <tom@tromey.com>
3427
3428         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3429         Don't return the symbol.
3430         * coffread.c (record_minimal_symbol): Use record_full.
3431
3432 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3433
3434         The MS-Windows port of ncurses fails to switch to a color pair if
3435         one or both of the colors are the implicit default colors.  This
3436         change records the default colors when TUI is initialized, and
3437         then specifies them explicitly when a color pair uses the default
3438         colors.  This allows color styling in TUI mode on MS-Windows.
3439
3440         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3441         ncurses_norm_attr.
3442         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3443         colors in ncurses_norm_attr.
3444         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3445         "none", replace it with the default color recorded in
3446         ncurses_norm_attr.
3447
3448 2019-03-14  Tom Tromey  <tromey@adacore.com>
3449
3450         * source-cache.h (class source_cache) <get_source_lines>: Return
3451         std::string.
3452         * source-cache.c (source_cache::extract_lines): Handle case where
3453         first_pos==npos.  Return std::string.
3454         (source_cache::get_source_lines): Update.
3455
3456 2019-03-14  Tom Tromey  <tromey@adacore.com>
3457
3458         * NEWS: Add item for "style sources" commands.
3459         * source-cache.c (source_cache::get_source_lines): Check
3460         source_styling.
3461         * cli/cli-style.c (source_styling): New global.
3462         (_initialize_cli_style): Add "style sources" commands.
3463         (show_style_sources): New function.
3464         * cli/cli-style.h (source_styling): Declare.
3465
3466 2019-03-14  Pedro Alves  <palves@redhat.com>
3467             Tom Tromey  <tromey@adacore.com>
3468
3469         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3470         * tui/tui-winsource.c (tui_refill_source_window): New function,
3471         from...
3472         (tui_horizontal_source_scroll): ... here.  Move some logic.
3473         * cli/cli-style.c (set_style_enabled): Notify new observable.
3474         * tui/tui-hooks.c (tui_redisplay_source): New function.
3475         (tui_attach_detach_observers): Attach or detach
3476         tui_redisplay_source.
3477         * observable.h (source_styling_changed): New observable.
3478         * observable.c: Define source_styling_changed observable.
3479
3480 2019-03-13  Tom Tromey  <tromey@adacore.com>
3481
3482         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3483         (i386_gnu_nat_target::store_registers): Update.
3484         * target-debug.h (target_debug_print_std_string): New macro.
3485         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3486         * windows-tdep.c (display_one_tib): Update.
3487         * tui/tui-stack.c (tui_make_status_line): Update.
3488         * top.c (print_inferior_quit_action): Update.
3489         * thread.c (thr_try_catch_cmd): Update.
3490         (add_thread_with_info): Update.
3491         (thread_target_id_str): Update.
3492         (thr_try_catch_cmd): Update.
3493         (thread_command): Update.
3494         (thread_find_command): Update.
3495         * record-btrace.c (record_btrace_target::info_record)
3496         (record_btrace_resume_thread, record_btrace_target::resume)
3497         (record_btrace_cancel_resume, record_btrace_step_thread)
3498         (record_btrace_target::wait, record_btrace_target::wait)
3499         (record_btrace_target::wait, record_btrace_target::stop): Update.
3500         * progspace.c (print_program_space): Update.
3501         * process-stratum-target.c
3502         (process_stratum_target::thread_address_space): Update.
3503         * linux-fork.c (linux_fork_mourn_inferior)
3504         (detach_checkpoint_command, info_checkpoints_command)
3505         (linux_fork_context): Update.
3506         (linux_fork_detach): Update.
3507         (class scoped_switch_fork_info): Update.
3508         (delete_checkpoint_command): Update.
3509         * infrun.c (follow_fork_inferior): Update.
3510         (follow_fork_inferior): Update.
3511         (proceed_after_vfork_done): Update.
3512         (handle_vfork_child_exec_or_exit): Update.
3513         (follow_exec): Update.
3514         (displaced_step_prepare_throw): Update.
3515         (displaced_step_restore): Update.
3516         (start_step_over): Update.
3517         (resume_1): Update.
3518         (clear_proceed_status_thread): Update.
3519         (proceed): Update.
3520         (print_target_wait_results): Update.
3521         (do_target_wait): Update.
3522         (context_switch): Update.
3523         (stop_all_threads): Update.
3524         (restart_threads): Update.
3525         (finish_step_over): Update.
3526         (handle_signal_stop): Update.
3527         (switch_back_to_stepped_thread): Update.
3528         (keep_going_pass_signal): Update.
3529         (print_exited_reason): Update.
3530         (normal_stop): Update.
3531         * inferior.c (inferior_pid_to_str): Change return type.
3532         (print_selected_inferior): Update.
3533         (add_inferior): Update.
3534         (detach_inferior): Update.
3535         * dummy-frame.c (fprint_dummy_frames): Update.
3536         * dcache.c (dcache_info_1): Update.
3537         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3538         (btrace_fetch, btrace_clear): Update.
3539         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3540         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3541         type.
3542         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3543         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3544         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3545         * gdbarch.c, gdbarch.h: Rebuild.
3546         * gdbarch.sh (core_pid_to_str): Change return type.
3547         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3548         return type.
3549         (windows_nat_target::pid_to_str): Change return type.
3550         (windows_delete_thread): Update.
3551         (windows_nat_target::attach): Update.
3552         (windows_nat_target::files_info): Update.
3553         * target-delegates.c: Rebuild.
3554         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3555         return type.
3556         (sol_thread_target::pid_to_str): Change return type.
3557         * remote.c (class remote_target) <pid_to_str>: Change return
3558         type.
3559         (remote_target::pid_to_str): Change return type.
3560         (extended_remote_target::attach, remote_target::remote_stop_ns)
3561         (remote_target::remote_notif_remove_queued_reply)
3562         (remote_target::push_stop_reply, remote_target::disable_btrace):
3563         Update.
3564         (extended_remote_target::attach): Update.
3565         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3566         type.
3567         (gdbsim_target::pid_to_str): Change return type.
3568         * ravenscar-thread.c (struct ravenscar_thread_target)
3569         <pid_to_str>: Change return type.
3570         (ravenscar_thread_target::pid_to_str): Change return type.
3571         * procfs.c (class procfs_target) <pid_to_str>: Change return
3572         type.
3573         (procfs_target::pid_to_str): Change return type.
3574         (procfs_target::attach): Update.
3575         (procfs_target::detach): Update.
3576         (procfs_target::fetch_registers): Update.
3577         (procfs_target::store_registers): Update.
3578         (procfs_target::wait): Update.
3579         (procfs_target::files_info): Update.
3580         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3581         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3582         return type.
3583         (nto_procfs_target::pid_to_str): Change return type.
3584         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3585         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3586         return type.
3587         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3588         (exit_lwp): Update.
3589         (attach_proc_task_lwp_callback, get_detach_signal)
3590         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3591         (linux_nat_target::resume, wait_lwp, stop_callback)
3592         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3593         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3594         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3595         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3596         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3597         type.
3598         (inf_ptrace_target::attach): Update.
3599         (inf_ptrace_target::files_info): Update.
3600         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3601         type.
3602         (go32_nat_target::pid_to_str): Change return type.
3603         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3604         (gnu_nat_target::wait): Update.
3605         (gnu_nat_target::wait): Update.
3606         (gnu_nat_target::resume): Update.
3607         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3608         (fbsd_nat_target::wait): Update.
3609         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3610         type.
3611         (darwin_nat_target::attach): Update.
3612         * corelow.c (class core_target) <pid_to_str>: Change return type.
3613         (core_target::pid_to_str): Change return type.
3614         * target.c (normal_pid_to_str): Change return type.
3615         (default_pid_to_str): Likewise.
3616         (target_pid_to_str): Change return type.
3617         (target_translate_tls_address): Update.
3618         (target_announce_detach): Update.
3619         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3620         return type.
3621         (bsd_uthread_target::pid_to_str): Change return type.
3622         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3623         type.
3624         (bsd_kvm_target::pid_to_str): Change return type.
3625         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3626         return type.
3627         (aix_thread_target::pid_to_str): Change return type.
3628         * target.h (struct target_ops) <pid_to_str>: Change return type.
3629         (target_pid_to_str, normal_pid_to_str): Likewise.
3630         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3631         type.
3632         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3633         type.
3634         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3635         return type.
3636         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3637         type.
3638         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3639         type.
3640         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3641         return type.
3642
3643 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3644
3645         * NEWS: Mention that the new default MI version is 3.  Mention
3646         changes to the output of commands and events that deal with
3647         multi-location breakpoints.
3648         * breakpoint.c: Include "mi/mi-out.h".
3649         (print_one_breakpoint): Change output syntax if using MI version
3650         >= 3.
3651         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3652         New.
3653         (mi_multi_location_breakpoint_output_fixed): New.
3654         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3655         (mi_cmd_fix_multi_location_breakpoint_output): New.
3656         (mi_multi_location_breakpoint_output_fixed): New.
3657         * mi/mi-cmds.c (mi_cmds): Register command
3658         -fix-multi-location-breakpoint-output.
3659         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3660         interpreter "mi".
3661
3662 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3663
3664         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3665         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3666         instantiate mi_ui_out based on interpreter name.
3667         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3668         * mi/mi-main.c (mi_load_progress): Likewise.
3669
3670 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3671
3672         * NEWS: Combine separate "New targets" sections for 8.3.
3673
3674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3675
3676         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3677         (ppcfbsd_init_abi): Install gdbarch
3678         "fetch_tls_load_module_address" and "get_thread_local_address"
3679         methods.
3680
3681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3682
3683         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3684         (riscv_fbsd_init_abi): Install gdbarch
3685         "fetch_tls_load_module_address" and "get_thread_local_address"
3686         methods.
3687
3688 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3689
3690         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3691         (i386fbsd_init_abi): Install gdbarch
3692         "fetch_tls_load_module_address" and "get_thread_local_address"
3693         methods.
3694
3695 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3696
3697         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3698         (amd64fbsd_init_abi): Install gdbarch
3699         "fetch_tls_load_module_address" and "get_thread_local_address"
3700         methods.
3701
3702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3703
3704         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3705         (struct fbsd_pspace_data): New type.
3706         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3707         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3708         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3709         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3710         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3711
3712 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3713
3714         * gdbtypes.c (lookup_struct_elt): New function.
3715         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3716         * gdbtypes.h (struct struct_elt): New type.
3717         (lookup_struct_elt): New prototype.
3718
3719 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3720
3721         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3722         remove disabled code block.
3723
3724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3725
3726         * gdbarch.sh (get_thread_local_address): New method.
3727         * gdbarch.h, gdbarch.c: Regenerate.
3728         * target.c (target_translate_tls_address): Use
3729         gdbarch_get_thread_local_address if present instead of
3730         target::get_thread_local_address.
3731
3732 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3733
3734         * target.h (target::get_thread_local_address): Update comment.
3735
3736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3737
3738         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3739         objfile->separate_debug_objfile_backlink if not NULL.
3740
3741 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3742
3743         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3744         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3745         (amd64bsd_store_inferior_registers): Likewise.
3746         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3747         Enable segment base registers.
3748         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3749         PT_GETFSBASE and PT_GETGSBASE.
3750         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3751         PT_SETGSBASE.
3752         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3753         segment base registers.
3754         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3755
3756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3757
3758         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3759         Update calls to i386_target_description to add 'segments'
3760         parameter.
3761         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3762         add segment base registers.
3763         * arch/i386.c (i386_create_target_description): Add 'segments'
3764         parameter to enable segment base registers.
3765         * arch/i386.h (i386_create_target_description): Likewise.
3766         * features/i386/32bit-segments.xml: New file.
3767         * features/i386/32bit-segments.c: Generate.
3768         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3769         call to i386_target_description to add 'segments' parameter.
3770         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3771         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3772         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3773         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3774         if feature is present.
3775         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3776         Add 'segments' parameter to call to i386_target_description.
3777         (i386_target_description): Add 'segments' parameter to enable
3778         segment base registers.
3779         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3780         to call to i386_target_description.
3781         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3782         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3783         Define I386_NUM_REGS.
3784         (i386_target_description): Add 'segments' parameter to enable
3785         segment base registers.
3786
3787 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3788
3789         PR/24325
3790         * source-cache.c: #undef open and close, to avoid unresolved
3791         externals during linking.
3792
3793 2019-03-12  Tom Tromey  <tromey@adacore.com>
3794
3795         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3796         const.  Add initializers.
3797         (_initialize_remote): Don't initialize ptid globals.
3798
3799 2019-03-12  Pedro Alves  <palves@redhat.com>
3800
3801         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3802
3803 2019-03-12  Pedro Alves  <palves@redhat.com>
3804
3805         * cp-name-parser.y (main): Remove unused 'len' variable.
3806
3807 2019-03-12  Tom Tromey  <tromey@adacore.com>
3808
3809         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3810         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3811
3812 2019-03-12  Tom Tromey  <tromey@adacore.com>
3813
3814         * linux-nat.c (iterate_over_lwps): Update.
3815         (stop_callback): Remove parameter.
3816         (stop_wait_callback, detach_callback, resume_set_callback)
3817         (select_singlestep_lwp_callback, set_ignore_sigint)
3818         (status_callback, resumed_callback, resume_clear_callback)
3819         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3820         data parameter.
3821         (linux_nat_target::detach, linux_nat_target::resume)
3822         (linux_stop_and_wait_all_lwps, select_event_lwp)
3823         (linux_nat_filter_event, linux_nat_wait_1)
3824         (linux_nat_target::kill, linux_nat_target::stop)
3825         (linux_nat_target::stop): Update.
3826         (linux_nat_resume_callback): Change type.
3827         (resume_stopped_resumed_lwps, count_events_callback)
3828         (select_event_lwp_callback): Likewise.
3829         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3830         * arm-linux-nat.c (struct update_registers_data): Remove.
3831         (update_registers_callback): Change type.
3832         (arm_linux_insert_hw_breakpoint1): Update.
3833         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3834         parameter.
3835         (x86_linux_dr_set_addr): Update.
3836         (x86_linux_dr_set_control): Update.
3837         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3838         (iterate_over_lwps): Use gdb::function_view.
3839         * nat/aarch64-linux-hw-point.c (struct
3840         aarch64_dr_update_callback_param): Remove.
3841         (debug_reg_change_callback): Change type.
3842         (aarch64_notify_debug_reg_change): Update.
3843         * s390-linux-nat.c (s390_refresh_per_info): Update.
3844
3845 2019-03-11  Tom Tromey  <tromey@adacore.com>
3846
3847         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3848         redundant assignment to "this_cu".
3849
3850 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3851
3852         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3853
3854 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3855
3856         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3857         from...
3858         (rank_one_type): ... this.
3859
3860 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3861
3862         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3863         from...
3864         (rank_one_type): ... this.
3865
3866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3867
3868         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3869         from...
3870         (rank_one_type): ... this.
3871
3872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3873
3874         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3875         from...
3876         (rank_one_type): ... this.
3877
3878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3879
3880         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3881         from...
3882         (rank_one_type): ... this.
3883
3884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3885
3886         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3887         from...
3888         (rank_one_type): ... this.
3889
3890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3891
3892         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3893         from...
3894         (rank_one_type): ... this.
3895
3896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3897
3898         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3899         from...
3900         (rank_one_type): ... this.
3901
3902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3903
3904         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3905         from...
3906         (rank_one_type): ... this.
3907
3908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3909
3910         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3911         from...
3912         (rank_one_type): ... this.
3913
3914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3915
3916         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3917         from...
3918         (rank_one_type): ... this.
3919
3920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3921
3922         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3923         from...
3924         (rank_one_type): ... this.
3925
3926 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3927
3928         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3929         inferior-events' shows the example events.
3930
3931 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3932
3933         Support styling on native MS-Windows console
3934
3935         PR/24315
3936         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3937         on MS-Windows if $TERM is not defined.
3938
3939         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3940
3941         * posix-hdep.c (gdb_console_fputs):
3942         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3943         functions.
3944         * ui-file.h (gdb_console_fputs): Add prototype.
3945
3946         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3947         back to fputs only if the former returns zero.
3948
3949 2019-03-07  Tom Tromey  <tom@tromey.com>
3950
3951         * symmisc.c (print_symbol_bcache_statistics): Update.
3952         (print_objfile_statistics): Update.
3953         * symfile.c (allocate_symtab): Update.
3954         * stabsread.c: Don't include bcache.h.
3955         * psymtab.h (struct psymbol_bcache): Don't declare.
3956         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3957         (psymbol_bcache_init, psymbol_bcache_free)
3958         (psymbol_bcache_get_bcache): Don't declare.
3959         * psymtab.c (struct psymbol_bcache): Remove.
3960         (psymtab_storage::psymtab_storage): Update.
3961         (psymtab_storage::~psymtab_storage): Update.
3962         (psymbol_bcache_init, psymbol_bcache_free)
3963         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3964         (add_psymbol_to_bcache): Update.
3965         (allocate_psymtab): Update.
3966         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3967         macro_cache>: No longer pointers.
3968         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3969         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3970         * macrotab.c (macro_bcache): Update.
3971         * macroexp.c: Don't include bcache.h.
3972         * gdbtypes.c (check_types_worklist): Update.
3973         (types_deeply_equal): Remove TRY/CATCH.  Update.
3974         * elfread.c (elf_symtab_read): Update.
3975         * dwarf2read.c: Don't include bcache.h.
3976         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3977         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3978         (print_bcache_statistics, bcache_memory_used): Don't declare.
3979         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3980         methods.  Rename all data members.
3981         * bcache.c (struct bcache): Move to bcache.h.
3982         (bcache::expand_hash_table): Rename from expand_hash_table.
3983         (bcache): Remove.
3984         (bcache::insert): Rename from bcache_full.
3985         (bcache::compare): Rename from bcache_compare.
3986         (bcache_xmalloc): Remove.
3987         (bcache::~bcache): Rename from bcache_xfree.
3988         (bcache::print_statistics): Rename from print_bcache_statistics.
3989         (bcache::memory_used): Rename from bcache_memory_used.
3990
3991 2019-03-07  Pedro Alves  <palves@redhat.com>
3992
3993         * infrun.c (normal_stop): Also check for
3994         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3995
3996 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3997
3998         * f-lang.c (value_from_host_double): Moved to...
3999         * value.c (value_from_host_double): ...here.
4000         * value.h (value_from_host_double): Declare.
4001         * guile/scm-math.c (vlscm_convert_typed_number): Use
4002         value_from_host_double.
4003         (vlscm_convert_number): Likewise.
4004         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4005         * python/py-value.c (convert_value_from_python): Likewise.
4006
4007 2019-03-06  Tom Tromey  <tom@tromey.com>
4008
4009         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4010
4011 2019-03-06  Tom Tromey  <tom@tromey.com>
4012
4013         * utils.h (free_current_contents): Don't declare.
4014         * utils.c (free_current_contents): Remove.
4015
4016 2019-03-06  Tom Tromey  <tom@tromey.com>
4017
4018         * top.c (quit_force): Update.
4019         * main.c (captured_command_loop): Update.
4020         * common/new-op.c (operator new): Update.
4021         * common/common-exceptions.c (struct catcher)
4022         <save_cleanup_chain>: Remove member.
4023         (exceptions_state_mc_init): Update.
4024         (exception_try_scope_entry): Return nullptr.
4025         (exception_try_scope_exit, exception_rethrow)
4026         (throw_exception_sjlj, throw_exception_cxx): Update.
4027         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4028         (all_cleanups, do_cleanups, discard_cleanups)
4029         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4030         (restore_cleanups, restore_final_cleanups): Don't declare.
4031         (do_final_cleanups): Remove parameter.
4032         * common/cleanups.c (cleanup_chain, make_cleanup)
4033         (make_cleanup_dtor, all_cleanups, do_cleanups)
4034         (discard_my_cleanups, discard_cleanups)
4035         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4036         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4037         (null_cleanup): Remove.
4038         (do_final_cleanups): Remove parameter.
4039
4040 2019-03-06  Tom Tromey  <tom@tromey.com>
4041
4042         * remote.c (remote_target::remote_parse_stop_reply): Use
4043         unique_xmalloc_ptr.
4044
4045 2019-03-06  Tom Tromey  <tom@tromey.com>
4046
4047         * stabsread.c (struct stabs_field_info): Rename from field_info.
4048         <list, fnlist>: Add initializers.
4049         <obstack>: New member.
4050         (read_member_functions, read_struct_fields, read_baseclasses):
4051         Allocate on obstack.  Don't use cleanups.
4052         (read_one_struct_field, read_member_functions, read_struct_fields)
4053         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4054         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4055         (read_struct_type): Update.
4056
4057 2019-03-06  Tom Tromey  <tom@tromey.com>
4058
4059         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4060         * common/filestuff.h (make_cleanup_close): Don't declare.
4061         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4062         Remove.
4063
4064 2019-03-06  Tom Tromey  <tom@tromey.com>
4065
4066         * solib-aix.c: Use make_scope_exit.
4067
4068 2019-03-06  Tom Tromey  <tom@tromey.com>
4069
4070         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4071         Use make_scope_exit.
4072
4073 2019-03-06  Tom Tromey  <tom@tromey.com>
4074
4075         * solib-svr4.c (disable_probes_interface): Remove parameter.
4076         (svr4_handle_solib_event): Use make_scope_exit.
4077
4078 2019-03-06  Tom Tromey  <tom@tromey.com>
4079
4080         * remote.c (struct stop_reply_deleter): Remove.
4081         (stop_reply_up): Update.
4082         (struct stop_reply): Derive from notif_event.  Don't typedef.
4083         <regcache>: Now a std::vector.
4084         (stop_reply_xfree): Remove.
4085         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4086         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4087         (remote_target::discard_pending_stop_replies): Use delete.
4088         (remote_target::remote_parse_stop_reply): Update.
4089         (remote_target::process_stop_reply): Update.
4090         * remote-notif.h (struct notif_event): Add virtual destructor.
4091         Remove "dtr" member.
4092         (struct notif_client) <alloc_event>: Return a unique_ptr.
4093         (notif_event_xfree): Don't declare.
4094         (notif_event_up): New typedef.
4095         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4096         (notif_event_xfree, do_notif_event_xfree): Remove.
4097         (remote_notif_state_xfree): Update.
4098
4099 2019-03-06  Tom Tromey  <tom@tromey.com>
4100
4101         * infrun.c (displaced_step_clear_cleanup): Now a
4102         forward_scope_exit type.
4103         (displaced_step_prepare_throw): Update.
4104         (displaced_step_fixup): Update.
4105
4106 2019-03-06  Tom Tromey  <tom@tromey.com>
4107
4108         * inferior.h (class inferior): Update comment.
4109         * gdbthread.h (class thread_info): Update comment.
4110
4111 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4112             Tom Tromey  <tom@tromey.com>
4113
4114         * stabsread.h (struct stab_section_list): Remove.
4115         (coffstab_build_psymtabs): Update.
4116         * dbxread.c (symbuf_sections): Now a std::vector.
4117         (sect_idx): New global.
4118         (fill_symbuf): Update.
4119         (coffstab_build_psymtabs): Change type of stabsects parameter.
4120         Update.
4121         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4122         std::vector.
4123         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4124         (coff_locate_sections): Update.
4125         (coff_symfile_read): Remove cleanups.  Update.
4126         (init_stringtab): Add storage parameter.
4127         (free_stringtab, free_stringtab_cleanup): Remove.
4128         (init_lineno): Add storage parameter.
4129         (free_linetab, free_linetab_cleanup): Remove.
4130
4131 2019-03-06  Pedro Alves  <palves@redhat.com>
4132
4133         * linux-fork.c (fork_info::clobber_regs): Delete.
4134         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4135         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4136         comment.  Adjust.
4137         (scoped_switch_fork_info::scoped_switch_fork_info)
4138         (checkpoint_command, linux_fork_context): Adjust
4139         fork_save_infrun_state calls.
4140
4141 2019-03-06  Pedro Alves  <palves@redhat.com>
4142
4143         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4144         (inf_has_multiple_threads): Return 'bool' and rewrite using
4145         inferior_info::threads().
4146
4147 2019-03-06  Pedro Alves  <palves@redhat.com>
4148
4149         * linux-fork.c: Include <list>.
4150         (fork_list): Now a std::list instance.
4151         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4152         (forks_exist_p, find_last_fork): Adjust.
4153         (new_fork): Delete.
4154         (one_fork_p): New.
4155         (add_fork): Adjust.
4156         (free_fork): Delete, folded into fork_info::~fork_info().
4157         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4158         Adjust.
4159         (init_fork_list): Delete.
4160         (linux_fork_killall, linux_fork_mourn_inferior)
4161         (linux_fork_detach, info_checkpoints_command): Adjust.
4162         (_initialize_linux_fork): No longer call init_fork_list.
4163
4164 2019-03-06  Pedro Alves  <palves@redhat.com>
4165
4166         * linux-fork.c (new_fork): New, split out of ...
4167         (add_fork): ... this.  Return void.  Move "first fork" special
4168         case from here, to ...
4169         (checkpoint_command): ... here.
4170         * linux-linux.h (add_fork): Return void.
4171
4172 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4173
4174         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4175
4176 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4177             Chris January  <chris.january@arm.com>
4178             David Lecomber  <david.lecomber@arm.com>
4179
4180         * f-exp.y: New token, UNOP_INTRINSIC.
4181         (exp): New pattern using UNOP_INTRINSIC token.
4182         (f77_keywords): Add 'abs' keyword.
4183         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4184         (value_from_host_double): New function.
4185         (evaluate_subexp_f): Support UNOP_ABS.
4186
4187 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4188
4189         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4190         types.
4191
4192 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4193
4194         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4195         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4196         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4197
4198 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4199
4200         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4201
4202 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4203             Chris January  <chris.january@arm.com>
4204
4205         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4206         * f-exp.y: Define 'KIND' token.
4207         (exp): New pattern for KIND expressions.
4208         (ptype): Handle types with a kind extension.
4209         (direct_abs_decl): Extend to spot kind extensions.
4210         (f77_keywords): Add 'kind' to the list.
4211         (push_kind_type): New function.
4212         (convert_to_kind_type): New function.
4213         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4214         * parse.c (operator_length_standard): Likewise.
4215         * parser-defs.h (enum type_pieces): Add tp_kind.
4216         * std-operator.def: Add UNOP_KIND.
4217
4218 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4219
4220         * f-exp.y (f_parse): Set yydebug.
4221
4222 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * f-lang.c (evaluate_subexp_f): New function.
4225         (exp_descriptor_f): New global.
4226         (f_language_defn): Use exp_descriptor_f instead of
4227         exp_descriptor_standard.
4228
4229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4230
4231         * f-exp.y (struct token): Add comments.
4232         (dot_ops): Remove uppercase versions and the end marker.
4233         (f77_keywords): Likewise.
4234         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4235         entries in the dot_ops array are case insensitive, and use
4236         strncasecmp to compare strings.  Also some whitespace cleanup in
4237         this area.  Similar for the f77_keywords array, except entries in
4238         this list might be case sensitive.
4239
4240 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4241
4242         * f-exp.y (struct f77_boolean_val): Add comments.
4243         (boolean_values): Remove uppercase versions, and end marker.
4244         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4245         and use strncasecmp to achieve case insensitivity.  Additionally,
4246         perform whitespace cleanup around this code.
4247
4248 2019-03-06  Tom Tromey  <tromey@adacore.com>
4249
4250         * remote-sim.c (gdbsim_target_open): Use result of
4251         gdb_argv::release.
4252
4253 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4254         Dirk Schubert  <dirk.schubert@arm.com>
4255         Chris January  <chris.january@arm.com>
4256
4257         * eval.c (evaluate_subexp_standard): Call Fortran argument
4258         wrapping logic.
4259         * f-lang.c (struct value): A value which can be passed into a
4260         Fortran function call.
4261         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4262         where appropriate.
4263         (struct type): Value ready for a Fortran function call.
4264         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4265         is needed.
4266         * f-lang.h (fortran_argument_convert): Declaration.
4267         (fortran_preserve_arg_pointer): Declaration.
4268         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4269
4270 2019-03-05  Tom Tromey  <tromey@adacore.com>
4271
4272         * python/py-prettyprint.c (print_string_repr): Remove #if.
4273         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4274
4275 2019-03-05  Tom Tromey  <tromey@adacore.com>
4276
4277         * target.c (the_dummy_target): Move later.  Change type to
4278         "dummy_target".
4279         (initialize_targets): Don't initialize the_dummy_target.
4280
4281 2019-03-05  Tom Tromey  <tromey@adacore.com>
4282
4283         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4284         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4285
4286 2019-03-05  Tom Tromey  <tromey@adacore.com>
4287
4288         * windows-nat.c (windows_nat_target::attach)
4289         (windows_nat_target::detach): Don't call gdb_flush.
4290         * valprint.c (generic_val_print, val_print, val_print_string):
4291         Don't call gdb_flush.
4292         * utils.c (defaulted_query): Don't call gdb_flush.
4293         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4294         * target.c (target_announce_detach): Don't call gdb_flush.
4295         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4296         * remote.c (extended_remote_target::attach): Don't call
4297         gdb_flush.
4298         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4299         * printcmd.c (do_examine): Don't call gdb_flush.
4300         (info_display_command): Don't call gdb_flush.
4301         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4302         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4303         * memattr.c (info_mem_command): Don't call gdb_flush.
4304         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4305         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4306         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4307         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4308         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4309         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4310         (gnu_nat_target::detach): Don't call gdb_flush.
4311         * f-valprint.c (f_val_print): Don't call gdb_flush.
4312         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4313         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4314         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4315         gdb_flush.
4316         * c-valprint.c (c_val_print): Don't call gdb_flush.
4317         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4318
4319 2019-03-05  Tom Tromey  <tromey@adacore.com>
4320
4321         * varobj.c (update_dynamic_varobj_children): Update.
4322         (install_default_visualizer): Use reset, not release.
4323         * value.c (set_internalvar): Update.
4324         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4325         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4326         ATTRIBUTE_UNUSED_RESULT.
4327
4328 2019-03-05  Tom Tromey  <tromey@adacore.com>
4329
4330         * remote.c (class scoped_remote_fd) <release>: Add
4331         ATTRIBUTE_UNUSED_RESULT.
4332
4333 2019-03-05  Tom Tromey  <tromey@adacore.com>
4334
4335         * macroexp.c (struct macro_buffer) <release>: Add
4336         ATTRIBUTE_UNUSED_RESULT.
4337
4338 2019-03-05  Tom Tromey  <tromey@adacore.com>
4339
4340         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4341         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4342         ATTRIBUTE_UNUSED_RESULT.
4343
4344 2019-03-05  Tom Tromey  <tromey@adacore.com>
4345
4346         * common/scoped_fd.h (class scoped_fd) <release>: Add
4347         ATTRIBUTE_UNUSED_RESULT.
4348
4349 2019-03-05  Tom Tromey  <tromey@adacore.com>
4350
4351         * parser-defs.h (struct parser_state) <release>: Add
4352         ATTRIBUTE_UNUSED_RESULT.
4353
4354 2019-03-05  Tom Tromey  <tromey@adacore.com>
4355
4356         * utils.h (class gdb_argv) <release>: Add
4357         ATTRIBUTE_UNUSED_RESULT.
4358         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4359
4360 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4361
4362         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4363         for-loop range, to avoid compiler warnings.
4364
4365         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4366         avoid compiler warnings about unused variables.
4367
4368         * NEWS: Mention end of support for native debugging on MS-Windows
4369         before XP.
4370
4371         PR gdb/24292
4372         * common/netstuff.c:
4373         * gdbserver/gdbreplay.c
4374         * gdbserver/remote-utils.c:
4375         * ser-tcp.c:
4376         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4377         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4378         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4379         'getaddrinfo' and 'freeaddrinfo' were not available before
4380         Windows XP, and mingw.org's MinGW headers by default define
4381         _WIN32_WINNT to 0x500.
4382
4383 2019-03-01  Gary Benson <gbenson@redhat.com>
4384
4385         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4386
4387 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4388             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4389
4390         PR gdb/8527
4391         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4392         set_sigint_trap, clear_sigint_trap.
4393
4394 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4395
4396         * target.c (target_detach): Clear the regcache and the
4397         frame cache.
4398
4399 2019-02-27  Pedro Alves  <palves@redhat.com>
4400
4401         * utils.c (set_screen_size): When we cap the height/width sizes,
4402         tweak the corresponding command variable to show "unlimited":
4403
4404 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4405             Pedro Alves  <palves@redhat.com>
4406
4407         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4408         before calling rl_set_screen_size.
4409
4410 2019-02-27  Tom Tromey  <tromey@adacore.com>
4411
4412         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4413         define.
4414         * python/py-value.c: Remove Python 2.4 workaround.
4415         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4416         workaround.
4417         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4418         Python 2.4 workaround.
4419         * python/python-internal.h: Remove Python 2.4 comment.
4420         (Py_ssize_t): Don't define.
4421         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4422         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4423         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4424         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4425         * python/python.c (do_start_initialization): Remove Python 2.4
4426         workaround.
4427         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4428         (print_children): Remove Python 2.4 workaround.
4429         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4430         workaround.
4431         (CHARBUFFERPROC_NAME): Remove.
4432         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4433         Python 2.4 workaround.
4434
4435 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4436
4437         * NEWS: Note minimum Python version.
4438
4439 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4440
4441         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4442         code from these functions.  Remove corresponding ifdefs.  Use
4443         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4444         Remove gotos and target of gotos.
4445         (infpy_search_memory): Likewise.
4446
4447 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4448
4449         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4450         (hppa_gdbarch_init): Don't register deleted functions with
4451         gdbarch.
4452
4453 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4454
4455         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4456         (h8300_unwind_sp): Delete.
4457         (h8300_dummy_id): Delete.
4458         (h8300_gdbarch_init): Don't register deleted functions with
4459         gdbarch.
4460
4461 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4462
4463         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4464         (ft32_unwind_pc): Delete.
4465         (ft32_unwind_sp): Delete.
4466         (ft32_gdbarch_init): Don't register deleted functions with
4467         gdbarch.
4468
4469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4472         (frv_unwind_pc): Delete.
4473         (frv_unwind_sp): Delete.
4474         (frv_gdbarch_init): Don't register deleted functions with
4475         gdbarch.
4476
4477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4478
4479         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4480         (riscv_unwind_pc): Delete.
4481         (riscv_unwind_sp): Delete.
4482         (riscv_gdbarch_init): Don't register deleted functions with
4483         gdbarch.
4484
4485 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4486
4487         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4488         (csky_unwind_pc): Delete.
4489         (csky_unwind_sp): Delete.
4490         (csky_gdbarch_init): Don't register deleted functions with
4491         gdbarch.
4492
4493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4494
4495         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4496         (cris_unwind_pc): Delete.
4497         (cris_unwind_sp): Delete.
4498         (cris_gdbarch_init): Don't register deleted functions with
4499         gdbarch.
4500
4501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4504         (bfin_unwind_pc): Delete.
4505         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4506
4507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4510         (arm_unwind_pc): Delete.
4511         (arm_unwind_sp): Delete.
4512         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4513
4514 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4515
4516         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4517         (arc_unwind_pc): Delete.
4518         (arc_unwind_sp): Delete.
4519         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4520
4521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4524         (alpha_unwind_pc): Delete.
4525         (alpha_gdbarch_init): Don't register deleted functions with
4526         gdbarch.
4527
4528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4529
4530         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4531         (aarch64_unwind_pc): Delete.
4532         (aarch64_unwind_sp): Delete.
4533         (aarch64_gdbarch_init): Don't register deleted functions with
4534         gdbarch.
4535
4536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4537
4538         * gdbtypes.c (type_align): Don't consider static members when
4539         computing structure alignment.
4540
4541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4542
4543         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4544         return 0 for other types.
4545         * arch-utils.c (default_type_align): Always return 0.
4546         * gdbarch.h: Regenerate.
4547         * gdbarch.sh (type_align): Extend comment.
4548         * gdbtypes.c (type_align): Add additional comments, always call
4549         gdbarch_type_align before applying the default rules.
4550         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4551         generic code will then apply a suitable default.
4552         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4553         types, return 0 for other types.
4554
4555 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4556
4557         * NEWS: Create a new section for the next release branch.
4558         Rename the section of the current branch, now that it has
4559         been cut.
4560
4561 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4562
4563         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4564         * version.in: Bump version to 8.3.50.DATE-git.
4565
4566 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4567
4568         * aix-thread.c (ptid_cmp): Remove unused variable.
4569         (get_signaled_thread): Likewise.
4570         (store_regs_user_thread): Likewise.
4571         (store_regs_kernel_thread): Likewise.
4572         (fetch_regs_kernel_thread): Remove shadowed variable.
4573
4574 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4575
4576         * features/riscv/32bit-cpu.xml: Add register numbers.
4577         * features/riscv/32bit-fpu.c: Regenerate.
4578         * features/riscv/32bit-fpu.xml: Add register numbers.
4579         * features/riscv/64bit-cpu.xml: Add register numbers.
4580         * features/riscv/64bit-fpu.c: Regenerate.
4581         * features/riscv/64bit-fpu.xml: Add register numbers.
4582
4583 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4584
4585         * NEWS: Mention two argument form of gdb.Value constructor.
4586         * python/py-value.c (convert_buffer_and_type_to_value): New
4587         function.
4588         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4589         Add support for handling an optional second argument.  Call
4590         convert_buffer_and_type_to_value as appropriate.
4591         * python/python-internal.h (Py_buffer_deleter): New struct.
4592         (Py_buffer_up): New typedef.
4593
4594 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4595
4596         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4597         instead of releasing ownership.
4598
4599 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4600
4601         * dwarf2read.c (open_and_init_dwp_file): Call
4602         elf_numsections instead of bfd_count_sections to initialize
4603         dwp_file->num_sections.
4604
4605 2019-02-25  Tom Tromey  <tromey@adacore.com>
4606
4607         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4608
4609 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4610
4611         * gcore.in: Add '--readnever' option when invoking GDB.
4612
4613 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4614
4615         * MAINTAINERS: Update my email address.
4616
4617 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4618
4619         * build-id.c (build_id_to_debug_bfd_1): New function.
4620         (build_id_to_debug_bfd): Look for separate debug file in
4621         sysroot.
4622
4623 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4624
4625         * gdbarch.sh: Update the copyright year range that is placed into
4626         generated files.
4627
4628 2019-02-22  Keith Seitz  <keiths@redhat.com>
4629
4630         PR symtab/23853
4631         * linespec.c (create_sals_line_offset): Search for the default
4632         symtab's filename instead of its fullname.
4633
4634 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4635
4636         * NEWS: Update style defaults.
4637
4638 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4639
4640         * main.c (captured_main_1): Disable styling in batch mode.
4641
4642 2019-02-20  Tom Tromey  <tom@tromey.com>
4643
4644         * symtab.c (symtab_symbol_info): Fix typos.
4645
4646 2019-02-20  Tom Tromey  <tromey@adacore.com>
4647
4648         * findcmd.c (_initialize_mem_search): Use upper case for
4649         metasyntactic variables.
4650
4651 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4652
4653         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4654         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4655
4656 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4657
4658         * top.h (source_file_name): Change to std::string.
4659         * top.c (source_file_name): Likewise.
4660         (command_line_input): Adjust.
4661         * cli/cli-script.c (script_from_file): Adjust.
4662
4663 2019-02-19  Tom Tromey  <tromey@adacore.com>
4664
4665         * ravenscar-thread.c
4666         (ravenscar_thread_target::update_thread_list): Don't call
4667         ada_build_task_list.
4668         * ada-lang.h (ada_build_task_list): Don't declare.
4669         * ada-tasks.c (struct ada_tasks_inferior_data)
4670         <task_list_valid_p>: Now bool.
4671         (read_known_tasks, ada_task_list_changed)
4672         (ada_tasks_invalidate_inferior_data): Update.
4673         (read_known_tasks_array): Return bool.
4674         (read_known_tasks_list): Likewise.
4675         (read_known_tasks): Return void.
4676         (ada_build_task_list): Now static.
4677
4678 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4679
4680         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4681         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4682
4683 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4684
4685         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4686         variant for ada_tasks_pspace_data_handle and
4687         ada_tasks_inferior_data_handle.
4688         (ada_tasks_pspace_data_cleanup): New function.
4689         (ada_tasks_inferior_data_cleanup): New function.
4690
4691 2019-02-17  Tom Tromey  <tom@tromey.com>
4692
4693         * macrotab.h (macro_source_fullname): Return a std::string.
4694         * macrotab.c (macro_include, check_for_redefinition)
4695         (macro_undef, macro_lookup_definition, foreach_macro)
4696         (foreach_macro_in_scope): Update.
4697         (macro_source_fullname): Return a std::string.
4698         * macrocmd.c (show_pp_source_pos): Update.
4699
4700 2019-02-17  Tom Tromey  <tom@tromey.com>
4701
4702         * macrocmd.c (show_pp_source_pos): Style the file names.
4703
4704 2019-02-17  Tom Tromey  <tom@tromey.com>
4705
4706         PR tui/24197:
4707         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4708
4709 2019-02-17  Tom Tromey  <tom@tromey.com>
4710
4711         * ada-lang.c (user_select_syms): Use filtered printing.
4712         * utils.c (wrap_style): New global.
4713         (desired_style): Remove.
4714         (emit_style_escape): Add stream parameter.
4715         (set_output_style, reset_terminal_style, prompt_for_continue):
4716         Update.
4717         (flush_wrap_buffer): Only flush gdb_stdout.
4718         (wrap_here): Set wrap_style.
4719         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4720         treat escape sequences as a character.  Change when wrap buffer is
4721         flushed.
4722         (fputs_styled): Do not set the output style when the default is
4723         requested.
4724         * ui-style.h (struct ui_file_style) <is_default>: New method.
4725         * source.c (print_source_lines_base): Emit escape sequences in one
4726         piece.
4727
4728 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4729
4730         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4731         integers and enumeration types.
4732
4733 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4734
4735         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4736         instead of lookup_symbol_in_language
4737         (do_exact_match): New function.
4738         (ada_get_symbol_name_matcher): Return do_exact_match when
4739         doing a verbatim match.
4740
4741 2019-02-15  Tom Tromey  <tromey@adacore.com>
4742
4743         * ravenscar-thread.c (ravenscar_thread_target::resume)
4744         (ravenscar_thread_target::wait): Special case wildcard requests.
4745
4746 2019-02-15  Tom Tromey  <tromey@adacore.com>
4747
4748         * ravenscar-thread.c (base_ptid): Remove.
4749         (struct ravenscar_thread_target) <close>: New method.
4750         <m_base_ptid>: New member.
4751         <update_inferior_ptid, active_task, task_is_currently_active,
4752         runtime_initialized>: Declare methods.
4753         <ravenscar_thread_target>: Add constructor.
4754         (ravenscar_thread_target::task_is_currently_active)
4755         (ravenscar_thread_target::update_inferior_ptid)
4756         (ravenscar_runtime_initialized): Rename.  Now methods.
4757         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4758         (ravenscar_thread_target::update_thread_list): Update.
4759         (ravenscar_thread_target::active_task): Now method.
4760         (ravenscar_thread_target::store_registers)
4761         (ravenscar_thread_target::prepare_to_store)
4762         (ravenscar_thread_target::prepare_to_store)
4763         (ravenscar_thread_target::mourn_inferior): Update.
4764         (ravenscar_inferior_created): Use "new" to create target.
4765         (ravenscar_thread_target::get_ada_task_ptid): Update.
4766         (_initialize_ravenscar): Don't initialize base_ptid.
4767         (ravenscar_ops): Remove global.
4768
4769 2019-02-15  Tom Tromey  <tromey@adacore.com>
4770
4771         * target.h (push_target): Declare new overload.
4772         * target.c (push_target): New overload, taking an rvalue reference.
4773         * remote.c (remote_target::open_1): Use push_target overload.
4774         * corelow.c (core_target_open): Use push_target overload.
4775
4776 2019-02-15  Tom Tromey  <tromey@adacore.com>
4777
4778         * ravenscar-thread.c (is_ravenscar_task)
4779         (ravenscar_task_is_currently_active): Return bool.
4780         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4781         (_initialize_ravenscar): Remove "(void)".
4782         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4783         Return bool.
4784
4785 2019-02-15  Tom Tromey  <tromey@adacore.com>
4786
4787         * ravenscar-thread.c (ravenscar_runtime_initializer)
4788         (has_ravenscar_runtime, get_running_thread_id)
4789         (ravenscar_thread_target::resume): Fix indentation.
4790
4791 2019-02-15  Tom Tromey  <tromey@adacore.com>
4792
4793         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4794         from ravenscar_arch_ops.
4795         (sparc_ravenscar_ops::fetch_registers)
4796         (sparc_ravenscar_ops::store_registers): Now methods.
4797         (sparc_ravenscar_prepare_to_store): Remove.
4798         (sparc_ravenscar_ops): Redefine.
4799         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4800         methods and destructor.  Remove members.
4801         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4802         (ravenscar_thread_target::store_registers)
4803         (ravenscar_thread_target::prepare_to_store): Update.
4804         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4805         Remove.
4806         (struct ppc_ravenscar_powerpc_ops): Derive from
4807         ravenscar_arch_ops.
4808         (ppc_ravenscar_powerpc_ops::fetch_registers)
4809         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4810         (ppc_ravenscar_powerpc_ops): Redefine.
4811         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4812         (ppc_ravenscar_e500_ops::fetch_registers)
4813         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4814         (ppc_ravenscar_e500_ops): Redefine.
4815         * aarch64-ravenscar-thread.c
4816         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4817         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4818         (aarch64_ravenscar_fetch_registers)
4819         (aarch64_ravenscar_store_registers): Now methods.
4820         (aarch64_ravenscar_ops): Redefine.
4821
4822 2019-02-15  Tom Tromey  <tromey@adacore.com>
4823
4824         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4825         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4826         (ravenscar_thread_target::stopped_by_watchpoint)
4827         (ravenscar_thread_target::stopped_data_address)
4828         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4829
4830 2019-02-15  Tom Tromey  <tromey@adacore.com>
4831
4832         * ravenscar-thread.c: Fix some typos.
4833
4834 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4835             Tom Tromey  <tromey@adacore.com>
4836
4837         * ada-lang.c (ada_exception_sal): Change addr_string to a
4838         std::string.
4839         (create_ada_exception_catchpoint): Update.
4840
4841 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4842             Tom Tromey  <tromey@adacore.com>
4843
4844         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4845         (bp_location_ops): Remove.
4846         (base_breakpoint_allocate_location): Update.
4847         (free_bp_location): Update.
4848         * ada-lang.c (class ada_catchpoint_location)
4849         <ada_catchpoint_location>: Remove ops parameter.
4850         (ada_catchpoint_location_dtor): Remove.
4851         (ada_catchpoint_location_ops): Remove.
4852         (allocate_location_exception): Update.
4853         * breakpoint.h (struct bp_location_ops): Remove.
4854         (class bp_location) <bp_location>: Remove bp_location_ops
4855         parameter.
4856         <~bp_location>: Add destructor.
4857         <ops>: Remove.
4858
4859 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4860             Pedro Alves  <palves@redhat.com>
4861
4862         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4863         'PATH_MAX'.
4864
4865 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4866             Samuel Thibault  <samuel.thibault@gnu.org>
4867             Thomas Schwinge  <thomas@codesourcery.com>
4868
4869         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4870         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4871
4872 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4873
4874         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4875         (check_empty): Use "const char *".
4876
4877         * gnu-nat.c (gnu_nat_target::detach): Instead of
4878         'detach_inferior (pid)' call
4879         'detach_inferior (find_inferior_pid (pid))'.
4880
4881         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4882         'nat/fork-inferior.o'.
4883         * gnu-nat.c: #include "nat/fork-inferior.h".
4884
4885         * gnu-nat.c (gnu_nat_target::detach): Instead of
4886         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4887         * gnu-nat.h: #include "inf-child.h".
4888         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4889         'i386_gnu_nat_target::fetch_registers'.
4890         (gnu_store_registers): Rename/move to
4891         'i386_gnu_nat_target::store_registers'.
4892
4893         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4894         * gnu-nat.h (mach_thread_info): New function.
4895         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4896
4897         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4898
4899 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4900
4901         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4902
4903 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4904
4905         * windows-nat.c (windows_add_thread): Add new parameter
4906         "main_thread_p" with default value set to false.  Update
4907         function documentation as well as all callers.
4908         (windows_delete_thread): Likewise.
4909         (fake_create_process): Update call to windows_add_thread.
4910         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4911         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4912         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4913         call to windows_delete_thread.
4914
4915 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4916
4917         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4918
4919 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4920
4921         * symfile.c (find_separate_debug_file): Use canonical path of
4922         sysroot with child_path instead of gdb_sysroot if it is valid.
4923
4924 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4925
4926         * symfile.c (find_separate_debug_file): Use child_path to
4927         determine if an object file is under a sysroot.
4928
4929 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4930
4931         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4932         unittests/child-path-selftests.c.
4933         * common/pathstuff.c (child_path): New function.
4934         * common/pathstuff.h (child_path): New prototype.
4935         * unittests/child-path-selftests.c: New file.
4936
4937 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4938
4939         * symfile.c (find_separate_debug_file): Look for separate debug
4940         files in debug directories under the sysroot.
4941
4942 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4943
4944         * symtab.h (struct minimal_symbol data_p): New const method.
4945         (struct minimal_symbol text_p): Likewise.
4946         * symtab.c (output_source_filename): Use file name style
4947         to print file name.
4948         (print_symbol_info): Likewise.
4949         (print_msymbol_info): Use address style to print addresses.
4950         Use function name style to print executable text symbols.
4951         (expand_symtab_containing_pc): Use data_p.
4952         (find_pc_sect_compunit_symtab): Likewise.
4953
4954 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4955
4956         * breakpoint.c (describe_other_breakpoints): Use address style
4957         to print addresses.
4958         (say_where): Likewise.
4959
4960 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4961
4962         * ada-typeprint.c (print_func_type): Print function name
4963         style to print function name.
4964         * c-typeprint.c (c_print_type_1): Likewise.
4965
4966 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4967
4968         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4969         for execve.
4970
4971 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4972
4973         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4974         type_stack.
4975
4976 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4977
4978         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4979         TYPE_CODE_REF types.
4980
4981 2019-02-08  Jim Wilson  <jimw@sifive.com>
4982
4983         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4984         (riscv_linux_fregset): New.
4985         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4986
4987 2019-02-07  Tom Tromey  <tom@tromey.com>
4988
4989         * thread.c (thread_cancel_execution_command): Update.
4990         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4991         methods.
4992         (struct thread_fsm_ops): Remove.
4993         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4994         (thread_fsm_should_stop, thread_fsm_return_value)
4995         (thread_fsm_set_finished, thread_fsm_finished_p)
4996         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4997         Don't declare.
4998         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4999         * infrun.c (clear_proceed_status_thread)
5000         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5001         (print_stop_event): Update.
5002         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5003         Add constructor.
5004         (step_command_fsm_ops): Remove.
5005         (new_step_command_fsm): Remove.
5006         (step_1): Update.
5007         (step_command_fsm::should_stop): Rename from
5008         step_command_fsm_should_stop.
5009         (step_command_fsm::clean_up): Rename from
5010         step_command_fsm_clean_up.
5011         (step_command_fsm::do_async_reply_reason): Rename from
5012         step_command_fsm_async_reply_reason.
5013         (struct until_next_fsm): Inherit from thread_fsm.  Add
5014         constructor.
5015         (until_next_fsm_ops): Remove.
5016         (new_until_next_fsm): Remove.
5017         (until_next_fsm::should_stop): Rename from
5018         until_next_fsm_should_stop.
5019         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5020         (until_next_fsm::do_async_reply_reason): Rename from
5021         until_next_fsm_async_reply_reason.
5022         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5023         constructor.  Change type of breakpoint.
5024         (finish_command_fsm_ops): Remove.
5025         (new_finish_command_fsm): Remove.
5026         (finish_command_fsm::should_stop): Rename from
5027         finish_command_fsm_should_stop.
5028         (finish_command_fsm::clean_up): Rename from
5029         finish_command_fsm_clean_up.
5030         (finish_command_fsm::return_value): Rename from
5031         finish_command_fsm_return_value.
5032         (finish_command_fsm::do_async_reply_reason): Rename from
5033         finish_command_fsm_async_reply_reason.
5034         (finish_command): Update.
5035         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5036         Add constructor.
5037         (call_thread_fsm_ops): Remove.
5038         (call_thread_fsm::call_thread_fsm): Rename from
5039         new_call_thread_fsm.
5040         (call_thread_fsm::should_stop): Rename from
5041         call_thread_fsm_should_stop.
5042         (call_thread_fsm::should_notify_stop): Rename from
5043         call_thread_fsm_should_notify_stop.
5044         (run_inferior_call, call_function_by_hand_dummy): Update.
5045         * cli/cli-interp.c (should_print_stop_to_console): Update.
5046         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5047         Add constructor.  Change type of location_breakpoint,
5048         caller_breakpoint.
5049         (until_break_fsm_ops): Remove.
5050         (new_until_break_fsm): Remove.
5051         (until_break_fsm::should_stop): Rename from
5052         until_break_fsm_should_stop.
5053         (until_break_fsm::clean_up): Rename from
5054         until_break_fsm_clean_up.
5055         (until_break_fsm::do_async_reply_reason): Rename from
5056         until_break_fsm_async_reply_reason.
5057         (until_break_command): Update.
5058         * thread-fsm.c: Remove.
5059         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5060
5061 2019-02-07  Tom Tromey  <tom@tromey.com>
5062
5063         * yy-remap.h: Add include guard.
5064         * xtensa-tdep.h: Add include guard.
5065         * xcoffread.h: Rename include guard.
5066         * varobj-iter.h: Add include guard.
5067         * tui/tui.h: Rename include guard.
5068         * tui/tui-winsource.h: Rename include guard.
5069         * tui/tui-wingeneral.h: Rename include guard.
5070         * tui/tui-windata.h: Rename include guard.
5071         * tui/tui-win.h: Rename include guard.
5072         * tui/tui-stack.h: Rename include guard.
5073         * tui/tui-source.h: Rename include guard.
5074         * tui/tui-regs.h: Rename include guard.
5075         * tui/tui-out.h: Rename include guard.
5076         * tui/tui-layout.h: Rename include guard.
5077         * tui/tui-io.h: Rename include guard.
5078         * tui/tui-hooks.h: Rename include guard.
5079         * tui/tui-file.h: Rename include guard.
5080         * tui/tui-disasm.h: Rename include guard.
5081         * tui/tui-data.h: Rename include guard.
5082         * tui/tui-command.h: Rename include guard.
5083         * tic6x-tdep.h: Add include guard.
5084         * target/waitstatus.h: Rename include guard.
5085         * target/wait.h: Rename include guard.
5086         * target/target.h: Rename include guard.
5087         * target/resume.h: Rename include guard.
5088         * target-float.h: Rename include guard.
5089         * stabsread.h: Add include guard.
5090         * rs6000-tdep.h: Add include guard.
5091         * riscv-fbsd-tdep.h: Add include guard.
5092         * regformats/regdef.h: Rename include guard.
5093         * record.h: Rename include guard.
5094         * python/python.h: Rename include guard.
5095         * python/python-internal.h: Rename include guard.
5096         * python/py-stopevent.h: Rename include guard.
5097         * python/py-ref.h: Rename include guard.
5098         * python/py-record.h: Rename include guard.
5099         * python/py-record-full.h: Rename include guard.
5100         * python/py-record-btrace.h: Rename include guard.
5101         * python/py-instruction.h: Rename include guard.
5102         * python/py-events.h: Rename include guard.
5103         * python/py-event.h: Rename include guard.
5104         * procfs.h: Add include guard.
5105         * proc-utils.h: Add include guard.
5106         * p-lang.h: Add include guard.
5107         * or1k-tdep.h: Rename include guard.
5108         * observable.h: Rename include guard.
5109         * nto-tdep.h: Rename include guard.
5110         * nat/x86-linux.h: Rename include guard.
5111         * nat/x86-linux-dregs.h: Rename include guard.
5112         * nat/x86-gcc-cpuid.h: Add include guard.
5113         * nat/x86-dregs.h: Rename include guard.
5114         * nat/x86-cpuid.h: Rename include guard.
5115         * nat/ppc-linux.h: Rename include guard.
5116         * nat/mips-linux-watch.h: Rename include guard.
5117         * nat/linux-waitpid.h: Rename include guard.
5118         * nat/linux-ptrace.h: Rename include guard.
5119         * nat/linux-procfs.h: Rename include guard.
5120         * nat/linux-osdata.h: Rename include guard.
5121         * nat/linux-nat.h: Rename include guard.
5122         * nat/linux-namespaces.h: Rename include guard.
5123         * nat/linux-btrace.h: Rename include guard.
5124         * nat/glibc_thread_db.h: Rename include guard.
5125         * nat/gdb_thread_db.h: Rename include guard.
5126         * nat/gdb_ptrace.h: Rename include guard.
5127         * nat/fork-inferior.h: Rename include guard.
5128         * nat/amd64-linux-siginfo.h: Rename include guard.
5129         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5130         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5131         * nat/aarch64-linux.h: Rename include guard.
5132         * nat/aarch64-linux-hw-point.h: Rename include guard.
5133         * mn10300-tdep.h: Add include guard.
5134         * mips-linux-tdep.h: Add include guard.
5135         * mi/mi-parse.h: Rename include guard.
5136         * mi/mi-out.h: Rename include guard.
5137         * mi/mi-main.h: Rename include guard.
5138         * mi/mi-interp.h: Rename include guard.
5139         * mi/mi-getopt.h: Rename include guard.
5140         * mi/mi-console.h: Rename include guard.
5141         * mi/mi-common.h: Rename include guard.
5142         * mi/mi-cmds.h: Rename include guard.
5143         * mi/mi-cmd-break.h: Rename include guard.
5144         * m2-lang.h: Add include guard.
5145         * location.h: Rename include guard.
5146         * linux-record.h: Rename include guard.
5147         * linux-nat.h: Add include guard.
5148         * linux-fork.h: Add include guard.
5149         * i386-darwin-tdep.h: Rename include guard.
5150         * hppa-linux-offsets.h: Add include guard.
5151         * guile/guile.h: Rename include guard.
5152         * guile/guile-internal.h: Rename include guard.
5153         * gnu-nat.h: Rename include guard.
5154         * gdb-stabs.h: Rename include guard.
5155         * frv-tdep.h: Add include guard.
5156         * f-lang.h: Add include guard.
5157         * event-loop.h: Add include guard.
5158         * darwin-nat.h: Rename include guard.
5159         * cp-abi.h: Rename include guard.
5160         * config/sparc/nm-sol2.h: Rename include guard.
5161         * config/nm-nto.h: Rename include guard.
5162         * config/nm-linux.h: Add include guard.
5163         * config/i386/nm-i386gnu.h: Rename include guard.
5164         * config/djgpp/nl_types.h: Rename include guard.
5165         * config/djgpp/langinfo.h: Rename include guard.
5166         * compile/gcc-cp-plugin.h: Add include guard.
5167         * compile/gcc-c-plugin.h: Add include guard.
5168         * compile/compile.h: Rename include guard.
5169         * compile/compile-object-run.h: Rename include guard.
5170         * compile/compile-object-load.h: Rename include guard.
5171         * compile/compile-internal.h: Rename include guard.
5172         * compile/compile-cplus.h: Rename include guard.
5173         * compile/compile-c.h: Rename include guard.
5174         * common/xml-utils.h: Rename include guard.
5175         * common/x86-xstate.h: Rename include guard.
5176         * common/version.h: Rename include guard.
5177         * common/vec.h: Rename include guard.
5178         * common/tdesc.h: Rename include guard.
5179         * common/selftest.h: Rename include guard.
5180         * common/scoped_restore.h: Rename include guard.
5181         * common/scoped_mmap.h: Rename include guard.
5182         * common/scoped_fd.h: Rename include guard.
5183         * common/safe-iterator.h: Rename include guard.
5184         * common/run-time-clock.h: Rename include guard.
5185         * common/refcounted-object.h: Rename include guard.
5186         * common/queue.h: Rename include guard.
5187         * common/ptid.h: Rename include guard.
5188         * common/print-utils.h: Rename include guard.
5189         * common/preprocessor.h: Rename include guard.
5190         * common/pathstuff.h: Rename include guard.
5191         * common/observable.h: Rename include guard.
5192         * common/netstuff.h: Rename include guard.
5193         * common/job-control.h: Rename include guard.
5194         * common/host-defs.h: Rename include guard.
5195         * common/gdb_wait.h: Rename include guard.
5196         * common/gdb_vecs.h: Rename include guard.
5197         * common/gdb_unlinker.h: Rename include guard.
5198         * common/gdb_unique_ptr.h: Rename include guard.
5199         * common/gdb_tilde_expand.h: Rename include guard.
5200         * common/gdb_sys_time.h: Rename include guard.
5201         * common/gdb_string_view.h: Rename include guard.
5202         * common/gdb_splay_tree.h: Rename include guard.
5203         * common/gdb_setjmp.h: Rename include guard.
5204         * common/gdb_ref_ptr.h: Rename include guard.
5205         * common/gdb_optional.h: Rename include guard.
5206         * common/gdb_locale.h: Rename include guard.
5207         * common/gdb_assert.h: Rename include guard.
5208         * common/filtered-iterator.h: Rename include guard.
5209         * common/filestuff.h: Rename include guard.
5210         * common/fileio.h: Rename include guard.
5211         * common/environ.h: Rename include guard.
5212         * common/common-utils.h: Rename include guard.
5213         * common/common-types.h: Rename include guard.
5214         * common/common-regcache.h: Rename include guard.
5215         * common/common-inferior.h: Rename include guard.
5216         * common/common-gdbthread.h: Rename include guard.
5217         * common/common-exceptions.h: Rename include guard.
5218         * common/common-defs.h: Rename include guard.
5219         * common/common-debug.h: Rename include guard.
5220         * common/cleanups.h: Rename include guard.
5221         * common/buffer.h: Rename include guard.
5222         * common/btrace-common.h: Rename include guard.
5223         * common/break-common.h: Rename include guard.
5224         * cli/cli-utils.h: Rename include guard.
5225         * cli/cli-style.h: Rename include guard.
5226         * cli/cli-setshow.h: Rename include guard.
5227         * cli/cli-script.h: Rename include guard.
5228         * cli/cli-interp.h: Rename include guard.
5229         * cli/cli-decode.h: Rename include guard.
5230         * cli/cli-cmds.h: Rename include guard.
5231         * charset-list.h: Add include guard.
5232         * buildsym-legacy.h: Rename include guard.
5233         * bfin-tdep.h: Add include guard.
5234         * ax.h: Rename include guard.
5235         * arm-linux-tdep.h: Add include guard.
5236         * arm-fbsd-tdep.h: Add include guard.
5237         * arch/xtensa.h: Rename include guard.
5238         * arch/tic6x.h: Add include guard.
5239         * arch/i386.h: Add include guard.
5240         * arch/arm.h: Rename include guard.
5241         * arch/arm-linux.h: Rename include guard.
5242         * arch/arm-get-next-pcs.h: Rename include guard.
5243         * arch/amd64.h: Add include guard.
5244         * arch/aarch64-insn.h: Rename include guard.
5245         * arch-utils.h: Rename include guard.
5246         * annotate.h: Add include guard.
5247         * amd64-darwin-tdep.h: Rename include guard.
5248         * aarch64-linux-tdep.h: Add include guard.
5249         * aarch64-fbsd-tdep.h: Add include guard.
5250         * aarch32-linux-nat.h: Add include guard.
5251
5252 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5253
5254         * macrotab.c (macro_define_internal): New function that
5255         factorizes macro_define_object_internal and macro_define_function
5256         code.
5257         (macro_define_object_internal): Use macro_define_internal.
5258         (macro_define_function): Likewise.
5259
5260 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5261
5262         * macrocmd.c (extract_identifier): Return
5263         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5264         callers.
5265
5266 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5267
5268         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5269
5270 2019-02-05  Tom Tromey  <tom@tromey.com>
5271
5272         * target.c (target_stack::unpush): Move assertion earlier.
5273
5274 2019-01-30  Tom Tromey  <tom@tromey.com>
5275
5276         PR python/23615:
5277         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5278         (gdbpy_parse_and_eval): Likewise.
5279         * python/python-internal.h (gdbpy_allow_threads): New class.
5280
5281 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5282
5283         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5284         (aarch64_fbsd_fpregmap): Move earlier.
5285         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5286         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5287         instead of individual calls to trad_frame_set_reg_addr.
5288         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5289         earlier.
5290         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5291         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5292         instead of individual calls to trad_frame_set_reg_addr.
5293
5294 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5295
5296         * CONTRIBUTE: Replace contribution list with wiki link.
5297
5298 2019-01-25  Tom Tromey  <tom@tromey.com>
5299
5300         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5301
5302 2019-01-25  Tom Tromey  <tom@tromey.com>
5303
5304         * xtensa-linux-nat.c: Fix common/ includes.
5305         * xml-support.h: Fix common/ includes.
5306         * xml-support.c: Fix common/ includes.
5307         * x86-linux-nat.c: Fix common/ includes.
5308         * windows-nat.c: Fix common/ includes.
5309         * varobj.h: Fix common/ includes.
5310         * varobj.c: Fix common/ includes.
5311         * value.c: Fix common/ includes.
5312         * valops.c: Fix common/ includes.
5313         * utils.c: Fix common/ includes.
5314         * unittests/xml-utils-selftests.c: Fix common/ includes.
5315         * unittests/utils-selftests.c: Fix common/ includes.
5316         * unittests/unpack-selftests.c: Fix common/ includes.
5317         * unittests/tracepoint-selftests.c: Fix common/ includes.
5318         * unittests/style-selftests.c: Fix common/ includes.
5319         * unittests/string_view-selftests.c: Fix common/ includes.
5320         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5321         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5322         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5323         * unittests/rsp-low-selftests.c: Fix common/ includes.
5324         * unittests/parse-connection-spec-selftests.c: Fix common/
5325         includes.
5326         * unittests/optional-selftests.c: Fix common/ includes.
5327         * unittests/offset-type-selftests.c: Fix common/ includes.
5328         * unittests/observable-selftests.c: Fix common/ includes.
5329         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5330         * unittests/memrange-selftests.c: Fix common/ includes.
5331         * unittests/memory-map-selftests.c: Fix common/ includes.
5332         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5333         * unittests/function-view-selftests.c: Fix common/ includes.
5334         * unittests/environ-selftests.c: Fix common/ includes.
5335         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5336         * unittests/common-utils-selftests.c: Fix common/ includes.
5337         * unittests/cli-utils-selftests.c: Fix common/ includes.
5338         * unittests/array-view-selftests.c: Fix common/ includes.
5339         * ui-file.c: Fix common/ includes.
5340         * tui/tui-io.c: Fix common/ includes.
5341         * tracepoint.h: Fix common/ includes.
5342         * tracepoint.c: Fix common/ includes.
5343         * tracefile-tfile.c: Fix common/ includes.
5344         * top.h: Fix common/ includes.
5345         * top.c: Fix common/ includes.
5346         * thread.c: Fix common/ includes.
5347         * target/waitstatus.h: Fix common/ includes.
5348         * target/waitstatus.c: Fix common/ includes.
5349         * target.h: Fix common/ includes.
5350         * target.c: Fix common/ includes.
5351         * target-memory.c: Fix common/ includes.
5352         * target-descriptions.c: Fix common/ includes.
5353         * symtab.h: Fix common/ includes.
5354         * symfile.c: Fix common/ includes.
5355         * stap-probe.c: Fix common/ includes.
5356         * spu-linux-nat.c: Fix common/ includes.
5357         * sparc-nat.c: Fix common/ includes.
5358         * source.c: Fix common/ includes.
5359         * solib.c: Fix common/ includes.
5360         * solib-target.c: Fix common/ includes.
5361         * ser-unix.c: Fix common/ includes.
5362         * ser-tcp.c: Fix common/ includes.
5363         * ser-pipe.c: Fix common/ includes.
5364         * ser-base.c: Fix common/ includes.
5365         * selftest-arch.c: Fix common/ includes.
5366         * s12z-tdep.c: Fix common/ includes.
5367         * rust-exp.y: Fix common/ includes.
5368         * rs6000-aix-tdep.c: Fix common/ includes.
5369         * riscv-tdep.c: Fix common/ includes.
5370         * remote.c: Fix common/ includes.
5371         * remote-notif.h: Fix common/ includes.
5372         * remote-fileio.h: Fix common/ includes.
5373         * remote-fileio.c: Fix common/ includes.
5374         * regcache.h: Fix common/ includes.
5375         * regcache.c: Fix common/ includes.
5376         * record-btrace.c: Fix common/ includes.
5377         * python/python.c: Fix common/ includes.
5378         * python/py-type.c: Fix common/ includes.
5379         * python/py-inferior.c: Fix common/ includes.
5380         * progspace.h: Fix common/ includes.
5381         * producer.c: Fix common/ includes.
5382         * procfs.c: Fix common/ includes.
5383         * proc-api.c: Fix common/ includes.
5384         * printcmd.c: Fix common/ includes.
5385         * ppc-linux-nat.c: Fix common/ includes.
5386         * parser-defs.h: Fix common/ includes.
5387         * osdata.c: Fix common/ includes.
5388         * obsd-nat.c: Fix common/ includes.
5389         * nat/x86-linux.c: Fix common/ includes.
5390         * nat/x86-linux-dregs.c: Fix common/ includes.
5391         * nat/x86-dregs.h: Fix common/ includes.
5392         * nat/x86-dregs.c: Fix common/ includes.
5393         * nat/ppc-linux.c: Fix common/ includes.
5394         * nat/mips-linux-watch.h: Fix common/ includes.
5395         * nat/mips-linux-watch.c: Fix common/ includes.
5396         * nat/linux-waitpid.c: Fix common/ includes.
5397         * nat/linux-ptrace.h: Fix common/ includes.
5398         * nat/linux-ptrace.c: Fix common/ includes.
5399         * nat/linux-procfs.c: Fix common/ includes.
5400         * nat/linux-personality.c: Fix common/ includes.
5401         * nat/linux-osdata.c: Fix common/ includes.
5402         * nat/linux-namespaces.c: Fix common/ includes.
5403         * nat/linux-btrace.h: Fix common/ includes.
5404         * nat/linux-btrace.c: Fix common/ includes.
5405         * nat/fork-inferior.c: Fix common/ includes.
5406         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5407         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5408         * nat/aarch64-linux.c: Fix common/ includes.
5409         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5410         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5411         * namespace.h: Fix common/ includes.
5412         * mips-linux-tdep.c: Fix common/ includes.
5413         * minsyms.c: Fix common/ includes.
5414         * mi/mi-parse.h: Fix common/ includes.
5415         * mi/mi-main.c: Fix common/ includes.
5416         * mi/mi-cmd-env.c: Fix common/ includes.
5417         * memrange.h: Fix common/ includes.
5418         * memattr.c: Fix common/ includes.
5419         * maint.h: Fix common/ includes.
5420         * maint.c: Fix common/ includes.
5421         * main.c: Fix common/ includes.
5422         * machoread.c: Fix common/ includes.
5423         * location.c: Fix common/ includes.
5424         * linux-thread-db.c: Fix common/ includes.
5425         * linux-nat.c: Fix common/ includes.
5426         * linux-fork.c: Fix common/ includes.
5427         * inline-frame.c: Fix common/ includes.
5428         * infrun.c: Fix common/ includes.
5429         * inflow.c: Fix common/ includes.
5430         * inferior.h: Fix common/ includes.
5431         * inferior.c: Fix common/ includes.
5432         * infcmd.c: Fix common/ includes.
5433         * inf-ptrace.c: Fix common/ includes.
5434         * inf-child.c: Fix common/ includes.
5435         * ia64-linux-nat.c: Fix common/ includes.
5436         * i387-tdep.c: Fix common/ includes.
5437         * i386-tdep.c: Fix common/ includes.
5438         * i386-linux-tdep.c: Fix common/ includes.
5439         * i386-linux-nat.c: Fix common/ includes.
5440         * i386-go32-tdep.c: Fix common/ includes.
5441         * i386-fbsd-tdep.c: Fix common/ includes.
5442         * i386-fbsd-nat.c: Fix common/ includes.
5443         * guile/scm-type.c: Fix common/ includes.
5444         * guile/guile.c: Fix common/ includes.
5445         * go32-nat.c: Fix common/ includes.
5446         * gnu-nat.c: Fix common/ includes.
5447         * gdbthread.h: Fix common/ includes.
5448         * gdbarch-selftests.c: Fix common/ includes.
5449         * gdb_usleep.c: Fix common/ includes.
5450         * gdb_select.h: Fix common/ includes.
5451         * gdb_bfd.c: Fix common/ includes.
5452         * gcore.c: Fix common/ includes.
5453         * fork-child.c: Fix common/ includes.
5454         * findvar.c: Fix common/ includes.
5455         * fbsd-nat.c: Fix common/ includes.
5456         * event-top.c: Fix common/ includes.
5457         * event-loop.c: Fix common/ includes.
5458         * dwarf2read.c: Fix common/ includes.
5459         * dwarf2loc.c: Fix common/ includes.
5460         * dwarf2-frame.c: Fix common/ includes.
5461         * dwarf-index-cache.c: Fix common/ includes.
5462         * dtrace-probe.c: Fix common/ includes.
5463         * disasm-selftests.c: Fix common/ includes.
5464         * defs.h: Fix common/ includes.
5465         * csky-tdep.c: Fix common/ includes.
5466         * cp-valprint.c: Fix common/ includes.
5467         * cp-support.h: Fix common/ includes.
5468         * cp-support.c: Fix common/ includes.
5469         * corelow.c: Fix common/ includes.
5470         * completer.h: Fix common/ includes.
5471         * completer.c: Fix common/ includes.
5472         * compile/compile.c: Fix common/ includes.
5473         * compile/compile-loc2c.c: Fix common/ includes.
5474         * compile/compile-cplus-types.c: Fix common/ includes.
5475         * compile/compile-cplus-symbols.c: Fix common/ includes.
5476         * command.h: Fix common/ includes.
5477         * cli/cli-dump.c: Fix common/ includes.
5478         * cli/cli-cmds.c: Fix common/ includes.
5479         * charset.c: Fix common/ includes.
5480         * build-id.c: Fix common/ includes.
5481         * btrace.h: Fix common/ includes.
5482         * btrace.c: Fix common/ includes.
5483         * breakpoint.h: Fix common/ includes.
5484         * breakpoint.c: Fix common/ includes.
5485         * ax.h:
5486         (enum agent_op): Fix common/ includes.
5487         * ax-general.c (struct aop_map): Fix common/ includes.
5488         * ax-gdb.c: Fix common/ includes.
5489         * auxv.c: Fix common/ includes.
5490         * auto-load.c: Fix common/ includes.
5491         * arm-tdep.c: Fix common/ includes.
5492         * arch/riscv.c: Fix common/ includes.
5493         * arch/ppc-linux-common.c: Fix common/ includes.
5494         * arch/i386.c: Fix common/ includes.
5495         * arch/arm.c: Fix common/ includes.
5496         * arch/arm-linux.c: Fix common/ includes.
5497         * arch/arm-get-next-pcs.c: Fix common/ includes.
5498         * arch/amd64.c: Fix common/ includes.
5499         * arch/aarch64.c: Fix common/ includes.
5500         * arch/aarch64-insn.c: Fix common/ includes.
5501         * arch-utils.c: Fix common/ includes.
5502         * amd64-windows-tdep.c: Fix common/ includes.
5503         * amd64-tdep.c: Fix common/ includes.
5504         * amd64-sol2-tdep.c: Fix common/ includes.
5505         * amd64-obsd-tdep.c: Fix common/ includes.
5506         * amd64-nbsd-tdep.c: Fix common/ includes.
5507         * amd64-linux-tdep.c: Fix common/ includes.
5508         * amd64-linux-nat.c: Fix common/ includes.
5509         * amd64-fbsd-tdep.c: Fix common/ includes.
5510         * amd64-fbsd-nat.c: Fix common/ includes.
5511         * amd64-dicos-tdep.c: Fix common/ includes.
5512         * amd64-darwin-tdep.c: Fix common/ includes.
5513         * agent.c: Fix common/ includes.
5514         * ada-lang.h: Fix common/ includes.
5515         * ada-lang.c: Fix common/ includes.
5516         * aarch64-tdep.c: Fix common/ includes.
5517
5518 2019-01-25  Tom Tromey  <tom@tromey.com>
5519
5520         * common/create-version.sh: Use common/version.h.
5521
5522 2019-01-24  Pedro Alves  <palves@redhat.com>
5523
5524         * infrun.c (signal_stop, signal_print, signal_program)
5525         (signal_catch, signal_pass): Now arrays instead of pointers.
5526         (update_signals_program_target, do_target_resume)
5527         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5528         * linux-nat.c (linux_nat_target::pass_signals)
5529         (linux_nat_target::create_inferior, linux_nat_target::attach):
5530         Adjust.
5531         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5532         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5533         * procfs.c (procfs_target::pass_signals): Adjust.
5534         * record-full.c (record_full_target::resume): Adjust.
5535         * remote.c (remote_target::pass_signals)
5536         (remote_target::program_signals): Adjust.
5537         * target-debug.h (target_debug_print_signals): Now takes a
5538         gdb::array_view as parameter.  Adjust.
5539         * target.h (target_ops) <pass_signals, program_signals>: Replace
5540         pointer and length parameters with gdb::array_view.
5541         (target_pass_signals, target_program_signals): Likewise.
5542         * target-delegates.c: Regenerate.
5543
5544 2019-01-24  Pedro Alves  <palves@redhat.com>
5545
5546         * common/forward-scope-exit.h
5547         (forward_scope_exit::forward_scope_exit): Pass arguments to
5548         m_bind_function directly, instead of creating a std::bind and
5549         copying that.
5550
5551 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5552
5553         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5554         for static members.
5555         (pass_in_v_vfp_candidate): Likewise.
5556
5557 2019-01-23  Tom Tromey  <tom@tromey.com>
5558             Pedro Alves  <palves@redhat.com>
5559
5560         * regcache.c (class regcache_invalidator): Remove.
5561         (regcache::raw_write): Use make_scope_exit.
5562
5563 2019-01-23  Tom Tromey  <tom@tromey.com>
5564
5565         * ui-out.h (class ui_out_emit_type): Update comment.
5566
5567 2019-01-23  Tom Tromey  <tom@tromey.com>
5568
5569         * infrun.c (fetch_inferior_event): Update comment.
5570
5571 2019-01-23  Tom Tromey  <tom@tromey.com>
5572             Pedro Alves  <palves@redhat.com>
5573
5574         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5575         parameter.
5576         (fetch_inferior_event): Use SCOPE_EXIT.
5577
5578
5579 2019-01-23  Tom Tromey  <tom@tromey.com>
5580             Pedro Alves  <palves@redhat.com>
5581
5582         * infrun.c (disable_thread_events): Delete.
5583         (stop_all_threads): Use SCOPE_EXIT.
5584
5585 2019-01-23  Tom Tromey  <tom@tromey.com>
5586             Pedro Alves  <palves@redhat.com>
5587
5588         * symfile.c: Include forward-scope-exit.h.
5589         (clear_symtab_users_cleanup): Replace forward declaration with
5590         a FORWARD_SCOPE_EXIT.
5591         (syms_from_objfile_1): Use the forward_scope_exit and
5592         gdb::optional instead of cleanup_function.
5593         (reread_symbols): Use the forward_scope_exit instead of
5594         cleanup_function.
5595         (clear_symtab_users_cleanup): Remove function.
5596
5597 2019-01-23  Tom Tromey  <tom@tromey.com>
5598             Pedro Alves  <palves@redhat.com>
5599
5600         * linux-nat.c: Include scope-exit.h.
5601         (cleanup_target_stop): Remove.
5602         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5603         SCOPE_EXIT.
5604
5605 2019-01-23  Tom Tromey  <tom@tromey.com>
5606             Pedro Alves  <palves@redhat.com>
5607
5608         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5609         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5610
5611 2019-01-23  Tom Tromey  <tom@tromey.com>
5612             Andrew Burgess  <andrew.burgess@embecosm.com>
5613             Pedro Alves  <palves@redhat.com>
5614
5615         * infrun.c (fetch_inferior_event): Use scope_exit.
5616         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5617         * top.c (execute_command): Use scope_exit.
5618         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5619         * utils.c (do_bpstat_clear_actions_cleanup)
5620         (make_bpstat_clear_actions_cleanup): Remove.
5621
5622 2019-01-23  Tom Tromey  <tom@tromey.com>
5623             Pedro Alves  <palves@redhat.com>
5624
5625         * infrun.c: Include "common/scope-exit.h"
5626         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5627         (wait_for_inferior): Use SCOPE_EXIT.
5628         (fetch_inferior_event): Use scope_exit.
5629
5630 2019-01-23  Tom Tromey  <tom@tromey.com>
5631             Pedro Alves  <palves@redhat.com>
5632
5633         * breakpoint.c (create_breakpoint): Remove cleanup.
5634
5635 2019-01-23  Tom Tromey  <tom@tromey.com>
5636             Andrew Burgess  <andrew.burgess@embecosm.com>
5637             Pedro Alves  <palves@redhat.com>
5638
5639 2019-01-23  Pedro Alves  <palves@redhat.com>
5640
5641         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5642
5643 2019-01-23  Pedro Alves  <palves@redhat.com>
5644             Andrew Burgess  <andrew.burgess@embecosm.com>
5645
5646         * gdbthread.h: Include "common/forward-scope-exit.h".
5647         (scoped_finish_thread_state): Redefine custom class in terms of
5648         forward_scope_exit.
5649
5650 2019-01-23  Pedro Alves  <palves@redhat.com>
5651             Andrew Burgess  <andrew.burgess@embecosm.com>
5652
5653         * common/forward-scope-exit.h: New file.
5654
5655 2019-01-23  Pedro Alves  <palves@redhat.com>
5656             Andrew Burgess  <andrew.burgess@embecosm.com>
5657             Tom Tromey  <tom@tromey.com>
5658
5659         * common/scope-exit.h: New file.
5660
5661 2019-01-23  Pedro Alves  <palves@redhat.com>
5662
5663         * common/preprocessor.h (ESC): Rename to ...
5664         (ESC_PARENS): ... this.
5665         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5666         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5667
5668 2019-01-23  Tom Tromey  <tom@tromey.com>
5669
5670         * language.h (class scoped_switch_to_sym_language_if_auto):
5671         Initialize m_lang in both cases.
5672
5673 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5674
5675         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5676         with XCNEW.
5677
5678 2019-01-22  Tom Tromey  <tom@tromey.com>
5679
5680         * corelow.c: Do not include sys/file.h.
5681
5682 2019-01-22  Tom Tromey  <tom@tromey.com>
5683
5684         * tui/tui-wingeneral.h: Include gdb_curses.h.
5685
5686 2019-01-22  Tom Tromey  <tom@tromey.com>
5687
5688         * source-cache.h (class source_cache) <get_source_lines,
5689         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5690
5691 2019-01-22  Tom Tromey  <tom@tromey.com>
5692
5693         * remote-fileio.h (struct remote_target): Declare.
5694
5695 2019-01-22  Tom Tromey  <tom@tromey.com>
5696
5697         * python/py-arch.c: Do not include py-ref.h.
5698         * python/py-bpevent.c: Do not include py-ref.h.
5699         * python/py-cmd.c: Do not include py-ref.h.
5700         * python/py-continueevent.c: Do not include py-ref.h.
5701         * python/py-event.h: Do not include py-ref.h.
5702         * python/py-evtregistry.c: Do not include py-ref.h.
5703         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5704         * python/py-frame.c: Do not include py-ref.h.
5705         * python/py-framefilter.c: Do not include py-ref.h.
5706         * python/py-function.c: Do not include py-ref.h.
5707         * python/py-infevents.c: Do not include py-ref.h.
5708         * python/py-linetable.c: Do not include py-ref.h.
5709         * python/py-objfile.c: Do not include py-ref.h.
5710         * python/py-param.c: Do not include py-ref.h.
5711         * python/py-prettyprint.c: Do not include py-ref.h.
5712         * python/py-progspace.c: Do not include py-ref.h.
5713         * python/py-symbol.c: Do not include py-ref.h.
5714         * python/py-symtab.c: Do not include py-ref.h.
5715         * python/py-type.c: Do not include py-ref.h.
5716         * python/py-unwind.c: Do not include py-ref.h.
5717         * python/py-utils.c: Do not include py-ref.h.
5718         * python/py-value.c: Do not include py-ref.h.
5719         * python/py-varobj.c: Do not include py-ref.h.
5720         * python/py-xmethods.c: Do not include py-ref.h.
5721         * python/python.c: Do not include py-ref.h.
5722         * varobj.c: Do not include py-ref.h.
5723
5724 2019-01-22  Tom Tromey  <tom@tromey.com>
5725
5726         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5727         keyword for bcache.
5728
5729 2019-01-22  Tom Tromey  <tom@tromey.com>
5730
5731         * compile/compile-cplus-types.c: Remove a comment by #include.
5732
5733 2019-01-22  Tom Tromey  <tom@tromey.com>
5734
5735         * compile/gcc-c-plugin.h: Include compile-internal.h.
5736
5737 2019-01-22  Tom Tromey  <tom@tromey.com>
5738
5739         * stabsread.c (EXTERN): Do not define.
5740         (symnum, next_symbol_text_func, processing_gcc_compilation)
5741         (within_function, global_sym_chain, global_stabs)
5742         (previous_stab_code, this_object_header_files)
5743         (n_this_object_header_files)
5744         (n_allocated_this_object_header_files): Define.
5745         * stabsread.h (EXTERN): Never define.  Use "extern".
5746
5747 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5748
5749         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5750         history_value.
5751
5752 2019-01-21  Tom Tromey  <tom@tromey.com>
5753
5754         * ui-out.c: Fix includes.
5755         * tui/tui-source.c: Fix includes.
5756         * target.c: Fix includes.
5757         * remote.c: Fix includes.
5758         * regcache.c: Fix includes.
5759         * python/py-block.c: Fix includes.
5760         * printcmd.c: Fix includes.
5761         * or1k-tdep.c: Fix includes.
5762         * mi/mi-main.c: Fix includes.
5763         * m32r-tdep.c: Fix includes.
5764         * csky-tdep.c: Fix includes.
5765         * compile/compile-cplus-types.c: Fix includes.
5766         * cli/cli-interp.c: Fix includes.
5767
5768 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5769
5770         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5771         for padding.
5772
5773 2019-01-16  Tom Tromey  <tom@tromey.com>
5774
5775         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5776         earlier.
5777         (struct objfile) <msymbols_range>: Move from top level.
5778         <msymbols>: New method.
5779         (class objfile_msymbols): Remove.
5780         * symtab.c (default_collect_symbol_completion_matches_break_on):
5781         Update.
5782         * symmisc.c (dump_msymbols): Update.
5783         * stabsread.c (scan_file_globals): Update.
5784         * objc-lang.c (info_selectors_command, info_classes_command)
5785         (find_methods): Update.
5786         * minsyms.c (find_solib_trampoline_target): Update.
5787         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5788         * coffread.c (coff_symfile_read): Update.
5789         * ada-lang.c (ada_lookup_simple_minsym)
5790         (ada_collect_symbol_completion_matches): Update.
5791
5792 2019-01-16  Tom Tromey  <tom@tromey.com>
5793
5794         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5795         type.  Remove no-argument constructor.
5796         <iterator::operator++>: Simplify.
5797         <begin>: Update.
5798         <end>: Use minimal_symbol_count.
5799
5800 2019-01-16  Tom Tromey  <tom@tromey.com>
5801
5802         * objfiles.h (struct objfile) <psymtabs>: New method.
5803         (class objfile_psymtabs): Remove.
5804         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5805         typedef.
5806         <range>: New method.
5807         (require_partial_symbols): Change return type.
5808         * psymtab.c (require_partial_symbols)
5809         (psym_expand_symtabs_matching): Update.
5810         * mdebugread.c (parse_partial_symbols): Update.
5811         * dbxread.c (dbx_end_psymtab): Update.
5812
5813 2019-01-15  Tom Tromey  <tom@tromey.com>
5814
5815         * symtab.c (lookup_objfile_from_block)
5816         (lookup_symbol_in_objfile_symtabs)
5817         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5818         (find_line_symtab, info_sources_command)
5819         (default_collect_symbol_completion_matches_break_on)
5820         (make_source_files_completion_list): Update.
5821         * symmisc.c (print_objfile_statistics, dump_objfile)
5822         (maintenance_print_symbols, maintenance_info_symtabs)
5823         (maintenance_check_symtabs, maintenance_info_line_tables):
5824         Update.
5825         * source.c (select_source_symtab)
5826         (forget_cached_source_info_for_objfile): Update.
5827         * objfiles.h (class objfile_compunits): Remove.
5828         (struct objfile) <compunits_range>: New typedef.
5829         (compunits): New method.
5830         * objfiles.c (objfile_relocate1): Update.
5831         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5832         * maint.c (count_symtabs_and_blocks): Update.
5833         * linespec.c (iterate_over_all_matching_symtabs): Update.
5834         * cp-support.c (add_symbol_overload_list_qualified): Update.
5835         * coffread.c (coff_symtab_read): Update.
5836         * ada-lang.c (add_nonlocal_symbols)
5837         (ada_collect_symbol_completion_matches)
5838         (ada_add_global_exceptions): Update.
5839
5840 2019-01-15  Tom Tromey  <tom@tromey.com>
5841
5842         * progspace.h (program_space) <objfiles_safe_range>: New
5843         typedef.
5844         <objfiles_safe>: New method.
5845         * objfiles.h (class all_objfiles_safe): Remove.
5846         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5847         * jit.c (jit_inferior_exit_hook): Update.
5848
5849 2019-01-17  Tom Tromey  <tom@tromey.com>
5850
5851         * progspace.h (program_space) <objfiles_range>: New typedef.
5852         <objfiles>: New method.
5853         <objfiles_head>: Rename from objfiles.
5854         (object_files): Update.
5855         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5856         * guile/scm-pretty-print.c
5857         (ppscm_find_pretty_printer_from_objfiles): Update.
5858         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5859         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5860         Update.
5861         * python/py-progspace.c (pspy_get_objfiles): Update.
5862         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5863         Update.
5864         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5865         (objfpy_lookup_objfile_by_build_id): Update.
5866         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5867         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5868         Update.
5869         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5870         (expand_symtab_containing_pc, lookup_objfile_from_block)
5871         (lookup_static_symbol, basic_lookup_transparent_type)
5872         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5873         (find_line_symtab, info_sources_command)
5874         (default_collect_symbol_completion_matches_break_on)
5875         (make_source_files_completion_list, find_main_name): Update.
5876         * symmisc.c (print_symbol_bcache_statistics)
5877         (print_objfile_statistics, maintenance_print_symbols)
5878         (maintenance_print_msymbols, maintenance_print_objfiles)
5879         (maintenance_info_symtabs, maintenance_check_symtabs)
5880         (maintenance_expand_symtabs, maintenance_info_line_tables):
5881         Update.
5882         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5883         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5884         (map_overlay_command, unmap_overlay_command)
5885         (simple_overlay_update, expand_symtabs_matching)
5886         (map_symbol_filenames): Update.
5887         * symfile-debug.c (set_debug_symfile): Update.
5888         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5889         Update.
5890         * source.c (select_source_symtab, forget_cached_source_info):
5891         Update.
5892         * solib.c (solib_read_symbols): Update.
5893         * solib-spu.c (append_ocl_sos): Update.
5894         * psymtab.c (maintenance_print_psymbols)
5895         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5896         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5897         * printcmd.c (info_symbol_command): Update.
5898         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5899         Update.
5900         * objfiles.h (class all_objfiles): Remove.
5901         * objfiles.c (have_partial_symbols, have_full_symbols)
5902         (have_minimal_symbols, qsort_cmp, update_section_map)
5903         (shared_objfile_contains_address_p)
5904         (default_iterate_over_objfiles_in_search_order): Update.
5905         * objc-lang.c (info_selectors_command, info_classes_command)
5906         (find_methods): Update.
5907         * minsyms.c (find_solib_trampoline_target): Update.
5908         * maint.c (maintenance_info_sections)
5909         (maintenance_translate_address, count_symtabs_and_blocks):
5910         Update.
5911         * main.c (captured_main_1): Update.
5912         * linux-thread-db.c (try_thread_db_load_from_pdir)
5913         (has_libpthread): Update.
5914         * linespec.c (iterate_over_all_matching_symtabs)
5915         (search_minsyms_for_name): Update.
5916         * jit.c (jit_find_objf_with_entry_addr): Update.
5917         * hppa-tdep.c (find_unwind_entry)
5918         (hppa_lookup_stub_minimal_symbol): Update.
5919         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5920         Update.
5921         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5922         (elf_gnu_ifunc_resolve_by_got): Update.
5923         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5924         * dwarf-index-write.c (save_gdb_index_command): Update.
5925         * cp-support.c (add_symbol_overload_list_qualified): Update.
5926         * breakpoint.c (create_overlay_event_breakpoint)
5927         (create_longjmp_master_breakpoint)
5928         (create_std_terminate_master_breakpoint)
5929         (create_exception_master_breakpoint): Update.
5930         * blockframe.c (find_pc_partial_function): Update.
5931         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5932         (ada_collect_symbol_completion_matches)
5933         (ada_add_global_exceptions): Update.
5934
5935 2019-01-17  Tom Tromey  <tom@tromey.com>
5936
5937         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5938         declare VEC.
5939         (solib_target_parse_libraries): Change return type.
5940         (library_list_start_segment, library_list_start_section)
5941         (library_list_end_library, library_list_start_library); Update.
5942         (solib_target_free_library_list): Remove.
5943         (solib_target_parse_libraries): Remove cleanup.  Change return
5944         type.
5945         (solib_target_current_sos): Update.
5946
5947 2019-01-17  Tom Tromey  <tromey@bapiya>
5948
5949         * valprint.c: Replace "the the" with "the".
5950         * symtab.c: Replace "the the" with "the".
5951         * solib.c: Replace "the the" with "the".
5952         * solib-dsbt.c: Replace "the the" with "the".
5953         * linespec.c: Replace "the the" with "the".
5954         * dwarf2loc.h: Replace "the the" with "the".
5955         * amd64-windows-tdep.c: Replace "the the" with "the".
5956         * aarch64-tdep.c: Replace "the the" with "the".
5957
5958 2019-01-16  Keith Seitz  <keiths@redhat.com>
5959
5960         PR gdb/23773
5961         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5962         <builder>: Rename to ..
5963         <m_builder>: ... this and make private.
5964         (dwarf2_cu::get_builder): New method.  Change all users of
5965         `builder' to use this method.
5966         (dwarf2_start_symtab): Move to ...
5967         (dwarf2_cu::start_symtab): ... here.  Update all callers
5968         (setup_type_unit_groups): Move to ...
5969         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5970         callers.
5971         (dwarf2_cu::reset_builder): New method.
5972         (process_full_compunit, process_full_type_unit): Use
5973         dwarf2_cu::reset_builder.
5974         (follow_die_offset): Record the ancestor CU if it is different
5975         from the followed DIE's CU.
5976         (follow_die_sig_1): Likewise.
5977
5978 2019-01-15  Tom Tromey  <tom@tromey.com>
5979
5980         * remote.c (class remote_state) <buf>: Now a char_vector.
5981         <buf_size>: Remove.
5982         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5983         parameter.
5984         (remote_target::getpkt_or_notif_sane_1)
5985         (remote_target::getpkt_sane)
5986         (remote_target::getpkt_or_notif_sane): Likewise.
5987         (class remote_target) <putpkt>: New overload.
5988         (remote_target::read_frame): Change type of "buf_p".  Remove
5989         sizeof_p parameter.
5990         (packet_ok): New overload.
5991         (packet_check_result): New overload.
5992         Update all uses.
5993
5994 2019-01-14  Tom Tromey  <tom@tromey.com>
5995
5996         * remote-notif.c (handle_notification, remote_notif_ack)
5997         (remote_notif_parse): Make "buf" const.
5998         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5999         const.
6000         (remote_notif_parse, remote_notif_ack, handle_notification):
6001         Likewise.
6002         * remote.c (remote_notif_stop_parse): Make "buf" const.
6003         (remote_target::remote_parse_stop_reply): Make "buf" const.
6004         (remote_notif_stop_ack): Make "buf" const.
6005
6006 2019-01-14  Tom Tromey  <tom@tromey.com>
6007
6008         * remote.c (remote_console_output): Make parameter const.
6009
6010 2019-01-14  Tom Tromey  <tom@tromey.com>
6011
6012         * target-debug.h (target_debug_print_signals): Constify.
6013         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6014         * procfs.c (procfs_target::pass_signals): Update.
6015         * linux-nat.c (linux_nat_target::pass_signals): Update.
6016         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6017         * target-delegates.c: Rebuild.
6018         * remote.c (remote_target::program_signals): Update.
6019         (remote_target::pass_signals): Update.
6020         * target.c (target_pass_signals): Constify argument.
6021         (target_program_signals): Likewise.
6022         * target.h (struct target_ops) <pass_signals, program_signals>:
6023         Constify argument.
6024         (target_pass_signals, target_program_signals): Constify argument.
6025
6026 2019-01-14  Tom Tromey  <tom@tromey.com>
6027
6028         PR tui/28819:
6029         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6030
6031 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6032
6033         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6034         field.
6035         * rs6000-tdep.c: Include reggroups.h.
6036         (IS_V_ALIAS_PSEUDOREG): Define.
6037         (rs6000_register_name): Return names for the "vX" aliases.
6038         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6039         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6040         aliases.  Call default_register_reggroup_p for all other
6041         pseudo-registers.
6042         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6043         New functions.
6044         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6045         Handle "vX" aliases.
6046         (v_alias_pseudo_register_collect): New function.
6047         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6048         (rs6000_gdbarch_init): Initialize "vX" aliases as
6049         pseudo-registers.  Restore registration of
6050         rs6000_pseudo_register_reggroup_p with
6051         set_tdesc_pseudo_register_reggroup_p.
6052
6053 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6054
6055         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6056         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6057         set_gdbarch_num_pseudo_regs.
6058
6059 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6060
6061         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6062         Remove arg prefixname, add do_set and do_show.
6063         Add member functions set_list and show_list.
6064         * cli/cli-style.c (class cli_style_option): Update accordingly.
6065         (style_set_list): Move to file scope.
6066         (style_show_list): Likewise.
6067         (set_style): Call help_list.
6068         (show_style): Call cmd_show_list.
6069         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6070         Update to use the new macro.
6071
6072 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6073
6074         * ada-lang.c (_initialize_ada_language): Expand the help text
6075         for the "catch exception" command.
6076
6077 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6078
6079         * symtab.c (matching_obj_sections): Initialize obj,
6080         declare it closer to its usage.
6081
6082 2019-01-10  Tom Tromey  <tom@tromey.com>
6083
6084         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6085         (basic_inf_threads_range): Remove.
6086         (inf_threads_range, inf_non_exited_threads_range)
6087         (safe_inf_threads_range): Use next_adapter.
6088
6089 2019-01-10  Keith Seitz  <keiths@redhat.com>
6090
6091         PR gdb/23712
6092         PR symtab/23010
6093         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6094         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6095
6096 2019-01-10  Keith Seitz  <keiths@redhat.com>
6097
6098         PR gdb/23712
6099         PR symtab/23010
6100         * dictionary.c (pending_to_vector): Remove.
6101         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6102         Remove _1 suffix, replacing functions of the same name.  Update
6103         all callers.
6104         (dict_create_hashed, dict_create_hashed_expandable)
6105         (dict_create_linear, dict_create_linear_expandable, dict_free)
6106         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6107         Make functions static.
6108
6109 2019-01-10  Keith Seitz  <keiths@redhat.com>
6110
6111         PR gdb/23712
6112         PR symtab/23010
6113         * dictionary.h (struct dictionary): Replace declaration with
6114         multidictionary.
6115         (dict_create_hashed, dict_create_hashed_expandable)
6116         (dict_create_linear, dict_create_linear_expandable)
6117         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6118         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6119         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6120         taking multidictionary argument.
6121         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6122         * block.h (struct block) <dict>: Change to multidictionary
6123         and rename `multidict'.
6124         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6125         symmisc.c: Update all dictionary references to multidictionary.
6126
6127 2019-01-10  Keith Seitz  <keiths@redhat.com>
6128
6129         PR gdb/23712
6130         PR symtab/23010
6131         * dictionary.c: Include unordered_map.
6132         (pending_to_vector): New function.
6133         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6134         Rewrite the non-"_1" functions to take vector instead
6135         of linked list.
6136         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6137         "new" _1 versions of the same name.
6138         (multidictionary): Define.
6139         (std::hash<enum language): New definition.
6140         (collate_pending_symbols_by_language, mdict_create_hashed)
6141         (mdict_create_hashed_expandable, mdict_create_linear)
6142         (mdict_create_linear_expandable, mdict_free)
6143         (find_language_dictionary, create_new_language_dictionary)
6144         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6145         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6146         (mdict_size, mdict_empty): New functions.
6147         * dictionary.h (mdict_iterator): Define.
6148
6149 2019-01-10  Pedro Alves  <palves@redhat.com>
6150
6151         * breakpoint.c (read_uploaded_action)
6152         (create_tracepoint_from_upload): Adjust to use
6153         gdb::unique_xmalloc_ptr.
6154         * ctf.c (ctf_write_uploaded_tp):
6155         (SET_ARRAY_FIELD): Use emplace_back.
6156         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6157         * tracefile-tfile.c (tfile_write_uploaded_tp):
6158         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6159         gdb::unique_xmalloc_ptr.
6160         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6161         at_string, cond_string, cmd_strings>: Replace char pointers
6162         with gdb::unique_xmalloc_ptr.
6163
6164 2019-01-10  Pedro Alves  <palves@redhat.com>
6165
6166         * solib-target.c (library_list_start_library): Don't xstrdup name.
6167
6168 2019-01-10  Pedro Alves  <palves@redhat.com>
6169
6170         * mdebugread.c (parse_partial_symbols): Use
6171         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6172
6173 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6174
6175         * linux-fork.c (scoped_switch_fork_info)
6176         <~scoped_switch_fork_info>: Fix incorrect variable name.
6177
6178 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6179
6180         * linux-fork.c (scoped_switch_fork_info)
6181         <scoped_switch_fork_info>: Make explicit.
6182         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6183
6184 2019-01-10  Tom Tromey  <tom@tromey.com>
6185
6186         * objfiles.h (objfile::reset_psymtabs): Update.
6187         * objfiles.c (objfile::objfile): Update.
6188         * psymtab.h (psymtab_storage::obstack): Update.
6189         (psymtab_storage::m_obstack): Use gdb::optional.
6190         (class psymtab_storage): Update comment.  Remove objfile
6191         parameter.
6192         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6193
6194 2019-01-10  Tom Tromey  <tom@tromey.com>
6195
6196         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6197         <free_psymtabs>: Now private.
6198         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6199         (allocate_psymtab): Use new method.
6200
6201 2019-01-10  Tom Tromey  <tom@tromey.com>
6202
6203         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6204         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6205         * mdebugread.c (parse_partial_symbols): Use
6206         allocate_dependencies.
6207         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6208         allocate_dependencies.
6209         (process_psymtab_comp_unit_reader)
6210         (build_type_psymtab_dependencies): Likewise.
6211         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6212
6213 2019-01-10  Tom Tromey  <tom@tromey.com>
6214
6215         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6216         PSYMBOL_SET_LANGUAGE.
6217         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6218
6219 2019-01-10  Tom Tromey  <tom@tromey.com>
6220
6221         * psymtab.h (psymtab_storage::obstack): New method.
6222         <m_obstack>: Rename from obstack; now private.
6223         * psymtab.c (psymtab_storage): Update.
6224         * dwarf2read.c (create_addrmap_from_index)
6225         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6226         Update.
6227
6228 2019-01-10  Tom Tromey  <tom@tromey.com>
6229
6230         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6231         * objfiles.h (objfile::reset_psymtabs): New method.
6232
6233 2019-01-10  Tom Tromey  <tom@tromey.com>
6234
6235         * symmisc.c (print_symbol_bcache_statistics): Update.
6236         (print_objfile_statistics): Update.
6237         * symfile.c (reread_symbols): Update.
6238         * psymtab.h (class psymtab_storage): New.
6239         * psymtab.c (psymtab_storage): New constructor.
6240         (~psymtab_storage): New destructor.
6241         (require_partial_symbols): Update.
6242         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6243         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6244         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6245         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6246         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6247         (start_psymtab_common, end_psymtab_common)
6248         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6249         (allocate_psymtab): Update.
6250         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6251         Update.
6252         (dump_psymtab_addrmap, maintenance_print_psymbols)
6253         (maintenance_check_psymtabs): Update.
6254         (class objfile_psymtabs): Move to objfiles.h.
6255         * psympriv.h (discard_psymtab): Now inline.
6256         (psymtab_discarder::psymtab_discarder): Update.
6257         (psymtab_discarder::~psymtab_discarder): Update.
6258         (ALL_OBJFILE_PSYMTABS): Rewrite.
6259         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6260         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6261         Remove fields.
6262         <partial_symtabs>: New field.
6263         (class objfile_psymtabs): Move from psymtab.h.  Update.
6264         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6265         psymbol_cache.
6266         (objfile::~objfile): Don't destroy psymbol_cache.
6267         * mdebugread.c (parse_partial_symbols): Update.
6268         * dwarf2read.c (create_addrmap_from_index)
6269         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6270         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6271         (add_partial_subprogram, dwarf2_ranges_read): Update.
6272         * dwarf-index-write.c (write_address_map)
6273         (write_one_signatured_type, recursively_write_psymbols)
6274         (class debug_names, class debug_names, write_psymtabs_to_index):
6275         Update.
6276
6277 2019-01-10  Tom Tromey  <tom@tromey.com>
6278
6279         * symtab.h (SYMBOL_SET_NAMES): Update.
6280         (symbol_set_names): Update.
6281         (MSYMBOL_SET_NAMES): Update.
6282         * symtab.c (symbol_set_names): Change argument to be an
6283         objfile_per_bfd_storage.
6284         * psymtab.c (add_psymbol_to_bcache): Update.
6285         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6286
6287 2019-01-10  Tom Tromey  <tom@tromey.com>
6288
6289         * symtab.c (create_demangled_names_hash): Change argument to be an
6290         objfile_per_bfd_storage.
6291         (symbol_set_names): Update.
6292
6293 2019-01-10  Tom Tromey  <tom@tromey.com>
6294
6295         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6296         init_psymbol_list.
6297         * psymtab.c (init_psymbol_list): Do nothing if already called.
6298         * psympriv.h (init_psymbol_list): Add comment.
6299         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6300         init_psymbol_list.
6301         * dbxread.c (dbx_symfile_read): Unconditionally call
6302         init_psymbol_list.
6303
6304 2019-01-10  Tom Tromey  <tom@tromey.com>
6305
6306         * xcoffread.c (scan_xcoff_symtab): Update.
6307         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6308         "where".
6309         * mdebugread.c (parse_partial_symbols)
6310         (handle_psymbol_enumerators): Update.
6311         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6312         * dbxread.c (read_dbx_symtab): Update.
6313         * psympriv.h (psymbol_placement): New enum.
6314         (add_psymbol_to_list): Update.
6315
6316 2019-01-10  Tom Tromey  <tom@tromey.com>
6317
6318         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6319         static_psymbols parameters.
6320         (scan_xcoff_symtab): Update.
6321         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6322         static_psymbols parameters.
6323         * psympriv.h (start_psymtab_common): Update.
6324         * mdebugread.c (parse_partial_symbols): Update.
6325         * dwarf2read.c (create_partial_symtab): Update.
6326         * dbxread.c (read_dbx_symtab): Update.
6327         (start_psymtab): Remove global_psymbols and static_psymbols
6328         parameters.
6329
6330 2019-01-10  Tom Tromey  <tom@tromey.com>
6331
6332         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6333         * psymtab.c (allocate_psymtab): Add comment.
6334         * psympriv.h (allocate_psymtab): Add comment.
6335         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6336         initializations.
6337         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6338
6339 2019-01-10  Tom Tromey  <tom@tromey.com>
6340
6341         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6342         Don't declare.
6343         * mipsread.c: Include mdebugread.h.
6344         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6345         Declare.
6346         * elfread.c: Include mdebugread.h.
6347
6348 2019-01-09  Tom Tromey  <tom@tromey.com>
6349
6350         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6351         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6352         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6353         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6354         (psym_lookup_symbol, psym_find_last_source_symtab)
6355         (psym_forget_cached_source_info, psym_print_stats)
6356         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6357         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6358         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6359         (psym_find_compunit_symtab_by_address)
6360         (maintenance_print_psymbols, maintenance_info_psymtabs)
6361         (maintenance_check_psymtabs): Use ranged for.
6362         * psymtab.h (class objfile_psymtabs): New.
6363         (require_partial_symbols): Return objfile_psymtabs.
6364         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6365
6366 2019-01-09  Tom Tromey  <tom@tromey.com>
6367
6368         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6369         (find_pc_mapped_section, list_overlays_command)
6370         (map_overlay_command, unmap_overlay_command)
6371         (simple_overlay_update): Use all_objfiles.
6372         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6373         * printcmd.c (info_symbol_command): Use all_objfiles.
6374         * objfiles.h (ALL_OBJSECTIONS): Remove.
6375         * maint.c (maintenance_translate_address): Use all_objfiles.
6376         * gcore.c (gcore_create_callback): Use all_objfiles.
6377         (objfile_find_memory_regions): Likewise.
6378
6379 2019-01-09  Tom Tromey  <tom@tromey.com>
6380
6381         * symtab.c (find_line_symtab, info_sources_command)
6382         (make_source_files_completion_list): Use objfile_compunits.
6383         * source.c (select_source_symtab): Use objfile_compunits.
6384         * objfiles.h (struct objfile): Update comment.
6385         (ALL_OBJFILES): Remove.
6386         (ALL_FILETABS): Remove.
6387         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6388         objfile_compunits.
6389
6390 2019-01-09  Tom Tromey  <tom@tromey.com>
6391
6392         * symmisc.c (print_objfile_statistics, dump_objfile)
6393         (maintenance_print_symbols): Use compunit_filetabs.
6394         * source.c (forget_cached_source_info_for_objfile): Use
6395         compunit_filetabs.
6396         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6397         (ALL_FILETABS): Use compunit_filetabs.
6398         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6399         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6400
6401 2019-01-09  Tom Tromey  <tom@tromey.com>
6402
6403         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6404         (compunit_filetabs): New.
6405         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6406         compunit_filetabs.
6407         (info_sources_command, make_source_files_completion_list): Remove
6408         declaration.
6409         * symmisc.c (print_objfile_statistics, dump_objfile)
6410         (maintenance_print_symbols): Remove declaration.
6411         (maintenance_info_symtabs): Use compunit_filetabs.
6412         (maintenance_info_line_tables): Likewise.
6413         * source.c (select_source_symtab): Change local variable name.
6414         (forget_cached_source_info_for_objfile): Remove declaration.
6415         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6416         * objfiles.c (objfile_relocate1): Remove declaration.
6417         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6418         declaration.
6419         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6420         * coffread.c (coff_symtab_read): Remove declaration.
6421         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6422         compunit_filetabs.
6423
6424 2019-01-09  Tom Tromey  <tom@tromey.com>
6425
6426         * symtab.c (lookup_objfile_from_block)
6427         (find_pc_sect_compunit_symtab, search_symbols)
6428         (default_collect_symbol_completion_matches_break_on): Use
6429         objfile_compunits.
6430         * objfiles.h (ALL_COMPUNITS): Remove.
6431         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6432         * cp-support.c (add_symbol_overload_list_qualified): Use
6433         objfile_compunits.
6434         * ada-lang.c (ada_collect_symbol_completion_matches)
6435         (ada_add_global_exceptions): Use objfile_compunits.
6436
6437 2019-01-09  Tom Tromey  <tom@tromey.com>
6438
6439         * source.c (select_source_symtab)
6440         (forget_cached_source_info_for_objfile): Remove declaration.
6441         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6442         declaration.
6443         * maint.c (count_symtabs_and_blocks): Remove declaration.
6444         * cp-support.c (add_symbol_overload_list_qualified): Remove
6445         declaration.
6446         * coffread.c (coff_symtab_read): Remove declaration.
6447         * symtab.c (lookup_symbol_in_objfile_symtabs)
6448         (basic_lookup_transparent_type_1): Use objfile_compunits.
6449         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6450         (info_sources_command, search_symbols)
6451         (default_collect_symbol_completion_matches_break_on)
6452         (make_source_files_completion_list): Remove declaration.
6453         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6454         (ada_collect_symbol_completion_matches)
6455         (ada_add_global_exceptions): Remove declaration.
6456         * linespec.c (iterate_over_all_matching_symtabs): Use
6457         objfile_compunits.
6458         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6459         (class objfile_compunits): New.
6460         (ALL_COMPUNITS): Use objfile_compunits.
6461         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6462         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6463         objfile_compunits.
6464         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6465
6466 2019-01-09  Tom Tromey  <tom@tromey.com>
6467
6468         * symtab.c (search_symbols)
6469         (default_collect_symbol_completion_matches_break_on): Use
6470         objfile_msymbols.
6471         * ada-lang.c (ada_lookup_simple_minsym)
6472         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6473         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6474         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6475         objfile_msymbols.
6476         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6477         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6478         * objc-lang.c (find_methods): Use objfile_msymbols.
6479         (info_selectors_command, info_classes_command): Likewise.
6480         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6481         * objfiles.h (class objfile_msymbols): New.
6482         (ALL_OBJFILE_MSYMBOLS): Remove.
6483         (ALL_MSYMBOLS): Remove.
6484
6485 2019-01-09  Tom Tromey  <tom@tromey.com>
6486
6487         * common/next-iterator.h (next_adapter): Add Iterator template
6488         parameter.
6489         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6490         (class all_objfiles_safe): New.
6491         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6492         * objfiles.c (put_objfile_before): Update comment.
6493         (add_separate_debug_objfile): Likewise.
6494         (free_all_objfiles): Use all_objfiles_safe.
6495         (objfile_purge_solibs): Likewise.
6496
6497 2019-01-09  Tom Tromey  <tom@tromey.com>
6498
6499         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6500         (expand_symtab_containing_pc, lookup_static_symbol)
6501         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6502         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6503         all_objfiles.
6504         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6505         * breakpoint.c (create_overlay_event_breakpoint)
6506         (create_longjmp_master_breakpoint)
6507         (create_std_terminate_master_breakpoint)
6508         (create_exception_master_breakpoint): Use all_objfiles.
6509         * linux-thread-db.c (try_thread_db_load_from_pdir)
6510         (has_libpthread): Use all_objfiles.
6511         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6512         * linespec.c (iterate_over_all_matching_symtabs)
6513         (search_minsyms_for_name): Use all_objfiles.
6514         * maint.c (maintenance_info_sections): Use all_objfiles.
6515         * main.c (captured_main_1): Use all_objfiles.
6516         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6517         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6518         * guile/scm-pretty-print.c
6519         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6520         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6521         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6522         (maintenance_print_msymbols): Use all_objfiles.
6523         * source.c (select_source_symtab): Use all_objfiles.
6524         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6525         * symfile.c (remove_symbol_file_command)
6526         (expand_symtabs_matching, map_symbol_filenames): Use
6527         all_objfiles.
6528         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6529         all_objfiles.
6530         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6531         * objc-lang.c (find_methods): Use all_objfiles.
6532         * objfiles.c (have_partial_symbols, have_full_symbols)
6533         (have_minimal_symbols, qsort_cmp)
6534         (default_iterate_over_objfiles_in_search_order): Use
6535         all_objfiles.
6536         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6537         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6538         (maintenance_check_psymtabs): Use all_objfiles.
6539         (ALL_PSYMTABS): Remove.
6540         * compile/compile-object-run.c (do_module_cleanup): Use
6541         all_objfiles.
6542         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6543         * cp-support.c (add_symbol_overload_list_qualified): Use
6544         all_objfiles.
6545         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6546         Use all_objfiles.
6547         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6548         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6549         all_objfiles.
6550         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6551         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6552         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6553         Uses all_objfiles.
6554         * solib.c (solib_read_symbols): Use all_objfiles
6555
6556 2019-01-09  Tom Tromey  <tom@tromey.com>
6557
6558         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6559         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6560         all_objfiles.
6561         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6562         * symmisc.c (print_symbol_bcache_statistics)
6563         (print_objfile_statistics, maintenance_print_objfiles)
6564         (maintenance_info_symtabs, maintenance_check_symtabs)
6565         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6566         all_objfiles.
6567         * source.c (forget_cached_source_info): Use all_objfiles.
6568         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6569         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6570         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6571         * objfiles.c (update_section_map): Use all_objfiles.
6572         (shared_objfile_contains_address_p): Likewise.
6573         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6574         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6575
6576 2019-01-09  Tom Tromey  <tom@tromey.com>
6577
6578         * common/next-iterator.h: New file.
6579         * objfiles.h (class all_objfiles): New.
6580         (struct objfile_iterator): New.
6581
6582 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6583
6584         * NEWS: Move the description of the changed "frame", "select-frame",
6585          and "info frame" commands to the Changed commands section.
6586
6587 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6588
6589         * gdbtypes.c (check_stub_method_group): Remove handling of old
6590         mangling schemes.
6591         * linespec.c (find_methods): Likewise.
6592         * stabsread.c (read_member_functions): Likewise.
6593         * valops.c (search_struct_method): Likewise.
6594         (value_struct_elt_for_reference): Likewise.
6595         * NEWS: Mention this change.
6596
6597 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6598
6599         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6600         print_source_lines.
6601         * source.c (print_source_lines_base): Update line number check.
6602         (print_source_lines): New function.
6603         (source_lines_range::source_lines_range): New function.
6604         * source.h (class source_lines_range): New class.
6605         (print_source_lines): New declaration.
6606
6607 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6608
6609         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6610
6611 2019-01-08  Tom Tromey  <tom@tromey.com>
6612             Simon Marchi  <simon.marchi@ericsson.com>
6613
6614         PR gdb/24060
6615         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6616         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6617         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6618         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6619         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6620         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6621
6622 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6623
6624         * source.c (select_source_symtab): Move header comment to
6625         declaration in source.h.
6626         (forget_cached_source_info_for_objfile): Likewise.
6627         (forget_cached_source_info): Likewise.
6628         (identify_source_line): Likewise.
6629         * source.h (identify_source_line): Move declaration from symtab.h
6630         and add comment from source.c
6631         (print_source_lines): Likewise.
6632         (forget_cached_source_info_for_objfile): Likewise.
6633         (forget_cached_source_info): Likewise.
6634         (select_source_symtab): Likewise.
6635         (enum print_source_lines_flag): Move definition from symtab.h.
6636         * symtab.h (identify_source_line): Move declaration to source.h.
6637         (print_source_lines): Likewise.
6638         (forget_cached_source_info_for_objfile): Likewise.
6639         (forget_cached_source_info): Likewise.
6640         (select_source_symtab): Likewise.
6641         (enum print_source_lines_flag): Move definition to source.h.
6642         * tui/tui-hooks.c: Add 'source.h' include.
6643
6644 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6645
6646         * source.c (print_source_lines_base): Handle requests to print
6647         reverse line number sequences, and guard against empty lines
6648         string.
6649
6650 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6651
6652         * source.c (print_source_lines_base): Fix skip of '\r' if next
6653         character is '\n'.
6654
6655 2019-01-06  Tom Tromey  <tom@tromey.com>
6656
6657         * c-exp.y (struct c_parse_state) <macro_original_text,
6658         expansion_obstack>: New member.
6659         (macro_original_text, expansion_obstack): Remove globals.
6660         (scan_macro_expansion, scanning_macro_expansion)
6661         (finished_macro_expansion): Update.
6662         (scan_macro_cleanup): Remove.
6663         (yylex, c_parse): Update.
6664
6665 2019-01-06  Tom Tromey  <tom@tromey.com>
6666
6667         * c-exp.y (struct c_parse_state) <strings>: New member.
6668         (operator_stoken): Update.
6669
6670 2019-01-06  Tom Tromey  <tom@tromey.com>
6671
6672         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6673         (union type_stack_elt) <typelist_val>: Now a pointer to
6674         std::vector.
6675         (type_stack_cleanup): Don't declare.
6676         (push_typelist): Update.
6677         * parse.c (pop_typelist): Return a std::vector.
6678         (push_typelist): Take a std::vector.
6679         (follow_types): Update.  Do not free args.
6680         (type_stack_cleanup): Remove.
6681         * c-exp.y (struct c_parse_state): New.
6682         (cpstate): New global.
6683         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6684         (nonempty_typelist): Update.
6685         (func_mod): Create a new vector.
6686         (c_parse): Create a c_parse_state.
6687         (check_parameter_typelist): Do not delete params.
6688         (function_method): Update.  Do not delete type_list.
6689
6690 2019-01-06  Tom Tromey  <tom@tromey.com>
6691
6692         PR gdb/28155:
6693         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6694         check_typedef.
6695         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6696         (print_return_value): Likewise.
6697
6698 2019-01-05  Tom Tromey  <tom@tromey.com>
6699
6700         * contrib/cleanup_check.py: Remove.
6701         * contrib/gcc-with-excheck: Remove.
6702         * contrib/exsummary.py: Remove.
6703         * contrib/excheck.py: Remove.
6704
6705 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6706
6707         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6708         NULL. Initialize tpprev to NULL instead of assigning it
6709         to NULL on the next statement.
6710         * windows-nat.c (windows_delete_thread): Remove check for
6711         main_thread_id before printing thread exit notifications.
6712         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6713         Remove thread ID check against main_thread_id.
6714         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6715         windows_delete_thread.
6716         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6717
6718 2019-01-04  Tom Tromey  <tom@tromey.com>
6719
6720         * compile/compile.c (_initialize_compile): Use upper case for
6721         metasyntactic variables.
6722         * symmisc.c (_initialize_symmisc): Use upper case for
6723         metasyntactic variables.
6724         * psymtab.c (_initialize_psymtab): Use upper case for
6725         metasyntactic variables.
6726         * demangle.c (demangle_command): Use upper case for metasyntactic
6727         variables.
6728         (_initialize_demangler): Likewise.
6729         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6730         variables.
6731
6732 2019-01-03  Tom Tromey  <tom@tromey.com>
6733
6734         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6735
6736 2019-01-03  Tom Tromey  <tom@tromey.com>
6737
6738         * python/py-symtab.c (salpy_str): Update.
6739         (struct salpy_sal_object) <symtab>: Now a PyObject.
6740         (salpy_dealloc): Update.
6741         (del_objfile_sal): Use gdbpy_ref.
6742
6743 2019-01-03  Tom Tromey  <tom@tromey.com>
6744
6745         * python/py-type.c (convert_field): Use new_reference.  Return
6746         gdbpy_ref.
6747         (make_fielditem): Return gdbpy_ref.
6748         (typy_fields): Update.
6749         (typy_getitem): Update.
6750         (field_name): Return gdbpy_ref.  Use new_reference.
6751         (typy_iterator_iternext): Update.
6752
6753 2019-01-03  Tom Tromey  <tom@tromey.com>
6754
6755         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6756
6757 2019-01-03  Tom Tromey  <tom@tromey.com>
6758
6759         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6760         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6761         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6762         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6763         (pspy_set_type_printers): Likewise.
6764         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6765         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6766         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6767         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6768         (objfpy_set_type_printers): Likewise.
6769
6770 2019-01-03  Tom Tromey  <tom@tromey.com>
6771
6772         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6773         (gdbpy_print_stack): Use gdbpy_err_fetch.
6774         * python/python-internal.h (class gdbpy_err_fetch): New class.
6775         (class gdbpy_enter) <m_error_type, m_error_value,
6776         m_error_traceback>: Remove.
6777         <m_error>: New member.
6778         (gdbpy_exception_to_string): Don't declare.
6779         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6780         * python/py-value.c (convert_value_from_python): Use
6781         gdbpy_err_fetch.
6782         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6783         gdbpy_exception_to_string.
6784         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6785         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6786         gdbpy_err_fetch.
6787
6788 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6789
6790         * linux-nat.c (delete_lwp_cleanup): Delete.
6791         (struct lwp_deleter): New struct.
6792         (lwp_info_up): New typedef.
6793         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6794         lwp_info_up.
6795
6796 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6797
6798         * linux-fork.c (class scoped_switch_fork_info): New class.
6799         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6800
6801 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6802
6803         * valops.c (find_overload_match): Remove use of null_cleanup, and
6804         calls to do_cleanups.
6805
6806 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6807
6808         * compile/compile-cplus-types.c
6809         (compile_cplus_instance::decl_name): Handle changes to
6810         cp_func_name.
6811         * cp-support.c (cp_func_name): Update header comment, update
6812         return type.
6813         * cp-support.h (cp_func_name): Update return type in declaration.
6814         * valops.c (find_overload_match): Move temp_func local to top
6815         level of function and change its type.  Use temp_func to hold and
6816         delete temporary string obtained from cp_func_name.
6817
6818 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6819
6820         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6821         gdb::char_vector, remove cleanup, and update uses of `msg`.
6822
6823 2019-01-03  Jim Wilson  <jimw@sifive.com>
6824
6825         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6826
6827 2019-01-02  Tom Tromey  <tom@tromey.com>
6828
6829         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6830         (tdesc_parse_xml): Remove cleanups.
6831         * target-descriptions.h (make_cleanup_free_target_description):
6832         Don't declare.
6833         (target_desc_deleter): New struct.
6834         (target_desc_up): New typedef.
6835         * target-descriptions.c (target_desc_deleter::operator()): Rename
6836         from free_target_description.
6837         (make_cleanup_free_target_description): Remove.
6838
6839 2019-01-02  Tom Tromey  <tom@tromey.com>
6840
6841         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6842         constructor, destructor.
6843         (linespec_parser): Remove typedef.
6844         (~linespec_parser): Rename from linespec_parser_delete.
6845         (linespec_lex_to_end, linespec_complete_label)
6846         (linespec_complete): Update.
6847         (decode_line_full): Remove cleanups.
6848         (decode_line_1): Update.
6849
6850 2019-01-02  Tom Tromey  <tom@tromey.com>
6851
6852         * python/python-internal.h (inferior_to_inferior_object): Change
6853         return type.
6854         * python/py-exitedevent.c (create_exited_event_object): Update.
6855         * python/py-inferior.c (inferior_to_inferior_object): Return
6856         gdbpy_ref.
6857         (python_new_inferior, python_inferior_deleted)
6858         (thread_to_thread_object, delete_thread_object)
6859         (build_inferior_list, gdbpy_selected_inferior): Update.
6860         * python/py-infthread.c (create_thread_object): Update.  Also fail
6861         if inferior_to_inferior_object fails.
6862
6863 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6864
6865         * inferior.h (class inferior) <displaced_step_state>: New field.
6866         * infrun.h (struct displaced_step_state): Move here from
6867         infrun.c.  Initialize fields, add constructor.
6868         <inf>: Remove field.
6869         <reset>: New method.
6870         * infrun.c (struct displaced_step_inferior_state): Move to
6871         infrun.h.
6872         (displaced_step_inferior_states): Remove.
6873         (get_displaced_stepping_state): Adust.
6874         (displaced_step_in_progress_any_inferior): Adjust.
6875         (displaced_step_in_progress_thread): Adjust.
6876         (displaced_step_in_progress): Adjust.
6877         (add_displaced_stepping_state): Remove.
6878         (get_displaced_step_closure_by_addr): Adjust.
6879         (remove_displaced_stepping_state): Remove.
6880         (infrun_inferior_exit): Call displaced_step_state.reset.
6881         (use_displaced_stepping): Don't check for NULL.
6882         (displaced_step_prepare_throw): Call
6883         get_displaced_stepping_state.
6884         (displaced_step_fixup): Don't check for NULL.
6885         (prepare_for_detach): Don't check for NULL.
6886
6887 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6888
6889         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6890          in case of call that did not complete.
6891
6892 2019-01-02  Andrey Utkin  <autkin@undo.io>
6893
6894         * symfile.c (find_separate_debug_file): Fix search of debug files for
6895         remote debuggee.
6896
6897 2019-01-02  Tom Tromey  <tom@tromey.com>
6898
6899         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6900         indentation.
6901         * python/py-frame.c (frapy_older): Remove cast.
6902         (frapy_newer): Likewise.
6903         * python/py-breakpoint.c (local_setattro): Remove cast.
6904         * python/py-arch.c (archpy_name): Remove local variable.
6905         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6906
6907 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6908
6909         * unittests/basic_string_view/element_access/char/empty.cc:
6910         Fix year range in copyright header.
6911
6912 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6913
6914         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6915         Delete.
6916         <operator==>: Update with for removed field.
6917         <hash>: Likewise.
6918         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6919         <isa_features>: ...this.
6920         <abi_features>: New field.
6921         (riscv_isa_flen): Update comment.
6922         (riscv_abi_xlen): New declaration.
6923         (riscv_abi_flen): New declaration.
6924         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6925         isa_features.
6926         (riscv_abi_xlen): New function.
6927         (riscv_isa_flen): Update to get answer from isa_features.
6928         (riscv_abi_flen): New function.
6929         (riscv_has_fp_abi): Update to get answer from abi_features.
6930         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6931         xlen and flen.
6932         (riscv_call_info) <xlen, flen>: Update comment.
6933         (riscv_call_arg_struct): Remove invalid assertions
6934         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6935         is removed.
6936         (riscv_gdbarch_init): Gather isa features and abi features
6937         separately, ensure both match on the gdbarch when reusing an old
6938         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6939         a target with 64-bit float hardware.
6940
6941 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6942
6943         * source.c (search_command_helper): Stop reverse search
6944         when line 1 has been searched.
6945
6946 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6947
6948         * record-full.c (record_full_base_target::close): Rewrite
6949         record_full_core_buf_list free logic.
6950
6951 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6952
6953         * break-catch-syscall.c (print_one_catch_syscall): xfree
6954         the last text.
6955
6956 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6957
6958         * top.c (print_gdb_version): Update Copyright year in version
6959         message.
6960
6961 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6962
6963         Update copyright year range in all GDB files.
6964
6965 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6966
6967         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6968
6969 For older changes see ChangeLog-2018.
6970 \f
6971 Local Variables:
6972 mode: change-log
6973 left-margin: 8
6974 fill-column: 74
6975 version-control: never
6976 coding: utf-8
6977 End:
6978