gdb/ChangeLog

   1 2019-09-08  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
   4
   5 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
   6
   7         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
   8         Change type to gdb::optional<block_enum>.
   9         (dw2_symtab_iter_init): Change block_index parameter type
  10         to gdb::optional<block_enum>.
  11         (dw2_lookup_symbol): Change block_index parameter
  12         type to block_enum.c
  13         (dw2_debug_names_lookup_symbol): Likewise.
  14         * psymtab.c (psym_lookup_symbol): Likewise.
  15         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
  16         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
  17         Likewise.
  18
  19 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
  20
  21         * defs.h (relocate_gdb_directory): Change int to bool in
  22         signature and rename flag to relocatable.
  23         * main.c (relocate_path): Likewise.
  24         (relocate_gdb_directory): Likewise.
  25
  26 2019-09-06  Alan Modra  <amodra@gmail.com>
  27
  28         * coffread.c (coff_symfile_read): Constify filename variable.
  29         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
  30         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
  31         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
  32         * solib.c (reload_shared_libraries_1): Likewise.
  33         * symfile.c (reread_symbols): Likewise.
  34         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
  35         * solib-darwin.c (darwin_bfd_open): Likewise.
  36         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
  37
  38 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  39
  40         * psymtab.c (print_partial_symbols): Handle missing domain_enum
  41         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
  42
  43 2019-09-03  Tom Tromey  <tromey@adacore.com>
  44
  45         * ada-valprint.c (ada_val_print_num): Don't recurse for range
  46         types.
  47         (has_negatives): Unbias a range type bound.
  48         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
  49         * gdbtypes.c (operator==): Handle new field.
  50         (create_range_type): Add "bias" parameter.
  51         (create_static_range_type, resolve_dynamic_range): Update.
  52         * gdbtypes.h (struct range_bounds) <bias>: New member.
  53         (create_range_type): Add bias parameter.
  54         * printcmd.c (print_scalar_formatted): Unbias range types.
  55         * value.c (unpack_long): Unbias range types.
  56         (pack_long): Bias range types.
  57
  58 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  59
  60         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
  61         probe arguments.
  62
  63 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  64
  65         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
  66         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
  67         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
  68         (compile_probe_arg): Likewise.
  69         * probe.h (get_argument_count): Likewise.
  70         * solib-svr4.c (solib_event_probe_action): Likewise.
  71         * stap-probe.c (stap_probe::get_argument_count): Likewise.
  72
  73 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  74
  75         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
  76         code to here...
  77         (svr4_create_solib_event_breakpoints): ...from here.
  78
  79 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
  80
  81         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
  82         suffix from warning message.
  83
  84 2019-08-30  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-winsource.h (struct tui_source_window_base)
  87         <refresh_all>: Don't declare.
  88         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
  89         Remove.
  90         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
  91         tui_show_locator_content.
  92         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
  93         declare.
  94         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
  95         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
  96         declare.
  97
  98 2019-08-30  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 101
 102 2019-08-30  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 105         Remove unnecessary forward declarations.
 106
 107 2019-08-30  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 110         rerender.
 111         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 112         tui_show_locator_content.
 113
 114 2019-08-30  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 117         (tui_locator_window::rerender): Rewrite using body of previous
 118         tui_show_locator_content.
 119
 120 2019-08-30  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 123         set_locator_fullname>: New methods.
 124         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 125         Rename from tui_set_locator_fullname.
 126         (tui_locator_window::set_locator_info): Rename from
 127         tui_set_locator_info.  Return bool.
 128         (tui_update_locator_fullname, tui_show_frame_info): Update.
 129
 130 2019-08-30  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 133
 134 2019-08-30  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 137         call touchwin.
 138
 139 2019-08-30  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-wingeneral.c (box_win): Assume win_info and
 142         win_info->handle cannot be NULL.
 143
 144 2019-08-30  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 147         refresh_window>: Declare.
 148         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 149         resize.
 150         (tui_data_item_window::rerender): Rename from
 151         tui_display_register.
 152         (tui_data_item_window::refresh_window): New method.
 153         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 154         no-op.
 155
 156 2019-08-30  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 159         regs_column_count, current_group>: Move later.  Now private.
 160         <get_current_group>: New method.
 161         * tui/tui-regs.c (tui_reg_command): Update.
 162         * tui/tui-layout.c (tui_set_layout): Update.
 163
 164 2019-08-30  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 167         (tui_data_window::rerender): Don't call
 168         check_and_display_highlight_if_needed.
 169         (tui_data_window::refresh_all): Remove call to
 170         erase_data_content.
 171
 172 2019-08-30  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 175         (tui_data_window::display_registers_from)
 176         (tui_data_window::display_reg_element_at_line)
 177         (tui_data_window::display_registers_from_line): Remove checks of
 178         "empty".
 179
 180 2019-08-30  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 183         Don't declare.
 184         * tui/tui-regs.c (tui_data_window::show_registers): Call
 185         rerender.
 186         (tui_data_window::rerender): Rename from display_all_data.
 187         (tui_data_window::rerender): Remove old implementation.
 188
 189 2019-08-30  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 192         text.
 193         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 194
 195 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 196             Sergio Durigan Junior  <sergiodj@redhat.com>
 197
 198         PR win32/24284
 199         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 200
 201 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 202
 203         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 204         when searching for types.
 205
 206 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * f-lang.c (f_language_defn): Use f_print_typedef.
 209         * f-lang.h (f_print_typedef): Declare.
 210         * f-typeprint.c (f_print_typedef): Define.
 211
 212 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 213
 214         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 215
 216 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 217
 218         * cli/cli-utils.c (info_print_options_defs): Delete.
 219         (make_info_print_options_def_group): Delete.
 220         (extract_info_print_options): Delete.
 221         (info_print_command_completer): Delete.
 222         (info_print_args_help): Add extra parameter, and optionally
 223         include text about -n flag.
 224         * cli/cli-utils.h (struct info_print_options): Delete.
 225         (extract_info_print_options): Delete declaration.
 226         (info_print_command_completer): Delete declaration.
 227         (info_print_args_help): Add extra parameter, extend header
 228         comment.
 229         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 230         search_symbols.
 231         * stack.c (struct info_print_options): New type.
 232         (info_print_options_defs): New file scoped variable.
 233         (make_info_print_options_def_group): New static function.
 234         (info_print_command_completer): New static function.
 235         (info_locals_command): Update to use new local functions.
 236         (info_args_command): Likewise.
 237         (_initialize_stack): Add extra parameter to calls to
 238         info_print_args_help.
 239         * symtab.c (search_symbols): Add extra parameter, use this to
 240         possibly excluse non-debug symbols.
 241         (symtab_symbol_info): Add extra parameter, which is passed on to
 242         search_symbols.
 243         (struct info_print_options): New type.
 244         (info_print_options_defs): New file scoped variable.
 245         (make_info_print_options_def_group): New static function.
 246         (info_print_command_completer): New static function.
 247         (info_variables_command): Update to use local functions, and pass
 248         extra parameter through to symtab_symbol_info.
 249         (info_functions_command): Likewise.
 250         (info_types_command): Pass additional argument through to
 251         symtab_symbol_info.
 252         (rbreak_command): Pass extra argument to search_symbols.
 253         (_initialize_symtab): Add extra arguments for calls to
 254         info_print_args_help, and update help text for 'info variables',
 255         'whereis', and 'info functions' commands.
 256         * symtab.h (search_symbols): Add extra argument to declaration.
 257         * NEWS: Mention new flags.
 258
 259 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 260
 261         * symtab.c (lookup_static_symbol): Call the new function (and move
 262         it down to be next to lookup_global_symbol).
 263         (struct global_sym_lookup_data): Add block_enum member and rename to...
 264         (struct global_or_static_sym_lookup_data): ...this.
 265         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 266         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 267         (lookup_symbol_global_or_static_iterator_cb): ...this.
 268         (lookup_global_or_static_symbol): New function.
 269         (lookup_global_symbol): Call new function.
 270
 271 2019-08-26  Tom de Vries  <tdevries@suse.de>
 272
 273         PR c++/24852
 274         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 275         when pc_probe.prob == NULL.
 276
 277 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 278
 279         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 280         variable symbol_linkage to symbol_linkage_.
 281
 282 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 283
 284         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 285         represent whether the symbol is static, dynamic, or we don't
 286         know.
 287
 288 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 289
 290         * gdb/rx-tdep.c (rx_register_names): New.
 291         (rx_register_name): Delete.
 292         (rx_psw_type): Delete.
 293         (rx_fpsw_type): Delete.
 294         (rx_register_type): Delete.
 295         (rx_gdbarch_init): Convert target-descriptions.
 296         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 297         * gdb/features/Makefile: Add rx.xml.
 298         * gdb/features/rx.xml: New.
 299         * gdb/features/rx.c: Generated.
 300         * gdb/NEWS: Mention target description support.
 301
 302 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 303
 304         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 305         *slot_ptr.
 306
 307 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 308
 309         * configure.ac: Don't check for 'dlfcn.h' (moved to
 310         gdbsupport/common.m4).
 311         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 312         'gdbsupport/'.
 313         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 314         * compile/compile-c-support.c: Include
 315         'gdbsupport/gdb-dlfcn.h'.
 316         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 317         * gdb-dlfcn.c: Move to...
 318         * gdbsupport/gdb-dlfcn.c: ... here.
 319         * gdb-dlfcn.h: Move to...
 320         * gdbsupport/gdb-dlfcn.h: ... here.
 321
 322 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 323
 324         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 325         the offset field signed.
 326
 327 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 328
 329         * python/lib/gdb/__init__.py (_execute_file): New function.
 330         * python/python.c (python_run_simple_file): Call gdb._execute_file
 331         on Windows.
 332
 333 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 334
 335         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 336         all uses as this was never set to anything but a zero value.
 337
 338 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 339
 340         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 341
 342 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 343
 344         * tui/tui-data.h (tui_gen_win_info): Add an =default
 345         move constructor, required by some GCC versions.
 346
 347 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 348
 349         * go32-nat.c (go32_sysinfo): Add hygon_p.
 350
 351 2019-08-20  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 354         line_from_reg_element_no, first_reg_element_no_inline,
 355         display_all_data, delete_data_content_windows,
 356         erase_data_content>: Now private.
 357
 358 2019-08-20  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 361         (tui_unhighlight_win, tui_highlight_win)
 362         (tui_win_info::make_window): Update.
 363         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 364
 365 2019-08-20  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 368         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 369         (MAX_PID_WIDTH): Move to tui-stack.c.
 370         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 371         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 372         (MAX_PID_WIDTH): Move from tui-data.h.
 373
 374 2019-08-20  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 377         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 378         (box_win): Update.
 379         (tui_gen_win_info::make_window): Rename from tui_make_window.
 380         (tui_win_info::make_window): New method.
 381         (tui_gen_win_info::make_visible): Update.
 382         * tui/tui-source.c (tui_source_window::set_contents): Update.
 383         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 384         (tui_data_window::display_registers_from): Update.
 385         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 386         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 387         Declare.
 388         <can_box>: Remove.
 389         <title>: Remove.
 390         (struct tui_win_info) <make_window>: Declare.
 391         <can_box>: Now virtual.
 392         <title>: New member.
 393         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 394         * tui/tui-command.c (tui_cmd_window::resize): Update.
 395
 396 2019-08-20  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 399         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 400         (tui_data_window::check_register_values): Update.
 401
 402 2019-08-20  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-regs.h (struct tui_data_window): Use
 405         DISABLE_COPY_AND_ASSIGN.
 406         <regs_content>: Change type, removing unique_ptr.
 407         <tui_data_window>: Add move constructor.
 408         * tui/tui-regs.c (tui_data_window::show_registers)
 409         (tui_data_window::show_register_group)
 410         (tui_data_window::display_registers_from)
 411         (tui_data_window::display_registers_from)
 412         (tui_data_window::first_data_item_displayed)
 413         (tui_data_window::delete_data_content_windows)
 414         (tui_data_window::rerender, tui_data_window::refresh_window)
 415         (tui_data_window::check_register_values): Update.
 416
 417 2019-08-20  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 420         show_register_group>: Declare.
 421         (tui_show_register_group): Don't declare.
 422         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 423         tui_show_registers.
 424         (tui_data_window::show_register_group): Rename from
 425         tui_show_register_group.
 426         (tui_data_window::check_register_values, tui_reg_command):
 427         Update.
 428         * tui/tui-layout.c (tui_set_layout): Update.
 429
 430 2019-08-20  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 433         Declare.
 434         (tui_check_register_values): Don't declare.
 435         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 436         from tui_check_register_values.
 437         * tui/tui-hooks.c (tui_register_changed): Update.
 438
 439 2019-08-20  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-regs.c (tui_reg_layout): Move later.
 442         (tui_show_registers): Don't enable TUI mode or change layout.
 443
 444 2019-08-20  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-regs.h (struct tui_data_item_window)
 447         <~tui_data_item_window>: Remove.
 448         <content>: Now a unique_xmalloc_ptr.
 449         * tui/tui-regs.c (tui_register_format): Return a
 450         unique_xmalloc_ptr.
 451         (tui_get_register): Update.
 452         (~tui_data_item_window): Remove.
 453         (tui_data_window::display_registers_from, tui_display_register):
 454         Update.
 455         * tui/tui-io.h (tui_expand_tabs): Update.
 456         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 457         Remove "col" parameter.
 458
 459 2019-08-20  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 462         field.
 463         * tui/tui-regs.c (~tui_data_item_window): Update.
 464
 465 2019-08-20  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 468         earlier.
 469
 470 2019-08-20  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 473
 474 2019-08-20  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-source.h (struct tui_source_window): Update.
 477         * tui/tui-regs.c (tui_show_registers): Update.
 478         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 479         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 480         (NO_REGS_STRING): Remove defines.
 481
 482 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 483
 484         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 485         unnecessary thread walk if remote doesn't support the packet.
 486
 487 2019-08-19  Tom Tromey  <tromey@adacore.com>
 488
 489         * python/py-value.c (value_has_field): Fix indentation.
 490
 491 2019-08-19  Tom Tromey  <tromey@adacore.com>
 492
 493         * printcmd.c (do_one_display, info_display_command): Update.
 494         * block.h (contained_in): Return bool.  Add allow_nested
 495         parameter.
 496         * block.c (contained_in): Return bool.  Add allow_nested
 497         parameter.
 498
 499 2019-08-19  Tom Tromey  <tom@tromey.com>
 500
 501         * configure: Rebuild.
 502         * configure.ac: Disallow the combination of -static-libstdc++ and
 503         source highlight.
 504         * source-cache.c (get_language_name): Handle rust.
 505         (source_cache::get_source_lines): Ignore highlighting exceptions.
 506
 507 2019-08-16  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 510         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 511         (struct tui_source_window_base) <make_visible, refresh_window,
 512         resize>: Remove methods.
 513         <execution_info>: Remove field.
 514         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 515         (tui_show_source_line, tui_source_window_base)
 516         (~tui_source_window_base): Update.
 517         (tui_source_window_base::resize)
 518         (tui_source_window_base::make_visible)
 519         (tui_source_window_base::refresh_window): Remove.
 520         (tui_source_window_base::update_exec_info): Update.
 521         * tui/tui-source.c (tui_source_window::set_contents): Update.
 522         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 523
 524 2019-08-16  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 527         deprecated_query_hook.
 528
 529 2019-08-16  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 532         (tui_update_source_windows_with_line): Update.
 533         * tui/tui-source.h (struct tui_source_window)
 534         <show_symtab_source>: Declare.
 535         (tui_show_symtab_source): Don't declare.
 536         * tui/tui-source.c (tui_show_symtab_source): Rename from
 537         tui_show_symtab_source.
 538
 539 2019-08-16  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-winsource.h (struct tui_source_window_base)
 542         <set_contents>: Declare.
 543         * tui/tui-winsource.c
 544         (tui_source_window_base::update_source_window_as_is): Update.
 545         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 546         Declare.
 547         (tui_set_source_content): Don't declare.
 548         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 549         tui_set_source_content.
 550         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 551         Declare.
 552         (tui_set_disassem_content): Don't declare.
 553         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 554         tui_set_disassem_content.
 555
 556 2019-08-16  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-winsource.h (struct tui_source_window_base)
 559         <update_breakpoint_info>: Declare.
 560         (tui_update_breakpoint_info): Don't declare.
 561         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 562         (tui_update_all_breakpoint_info): Update.
 563         (tui_source_window_base::update_breakpoint_info): Rename from
 564         tui_update_breakpoint_info.
 565         (tui_source_window_base::update_exec_info): Update.
 566
 567 2019-08-16  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-winsource.h (struct tui_source_window_base)
 570         <update_source_window>: Declare.
 571         (tui_update_source_window): Don't declare.
 572         * tui/tui-winsource.c
 573         (tui_source_window_base::update_source_window): Rename from
 574         tui_update_source_window.
 575         (tui_source_window_base::rerender): Update.
 576         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 577         * tui/tui-disasm.c (tui_show_disassem)
 578         (tui_show_disassem_and_update_source)
 579         (tui_disasm_window::maybe_update): Update.
 580
 581 2019-08-16  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-winsource.h (struct tui_source_window_base)
 584         <update_source_window_as_is>: Declare.
 585         (tui_update_source_window_as_is): Don't declare.
 586         * tui/tui-winsource.c (tui_update_source_window): Update
 587         (tui_source_window_base::update_source_window_as_is): Rename from
 588         tui_update_source_window_as_is.
 589         (tui_source_window_base::refill): Update.
 590         * tui/tui-source.c (tui_show_symtab_source): Update.
 591         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 592         Update.
 593
 594 2019-08-16  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-winsource.h (tui_update_source_window)
 597         (tui_update_source_window_as_is): Remove "noerror" parameter.
 598         * tui/tui-winsource.c (tui_update_source_window)
 599         (tui_update_source_window_as_is): Remove "noerror" parameter.
 600         (tui_update_source_windows_with_addr)
 601         (tui_update_source_windows_with_line)
 602         (tui_source_window_base::rerender)
 603         (tui_source_window_base::refill): Update.
 604         * tui/tui-source.h (tui_set_source_content)
 605         (tui_show_symtab_source): Remove "noerror" parameter.
 606         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 607         parameter.
 608         (tui_show_symtab_source): Likewise.
 609         (tui_source_window::maybe_update): Update.
 610         * tui/tui-disasm.c (tui_show_disassem)
 611         (tui_show_disassem_and_update_source)
 612         (tui_disasm_window::do_scroll_vertical)
 613         (tui_disasm_window::maybe_update): Update.
 614
 615 2019-08-16  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui.c (tui_is_window_visible): Update.
 618         * tui/tui-wingeneral.c (tui_make_window)
 619         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 620         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 621         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 622         (tui_set_win_height_command, parse_scrolling_args): Update.
 623         * tui/tui-source.c (tui_source_window::style_changed): Update.
 624         * tui/tui-regs.c (tui_show_registers)
 625         (tui_data_window::first_data_item_displayed)
 626         (tui_data_window::delete_data_content_windows)
 627         (tui_check_register_values, tui_reg_command): Update.
 628         * tui/tui-disasm.c (tui_show_disassem): Update.
 629         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 630         method.
 631         <is_visible>: Remove field.
 632         * tui/tui-data.c (tui_next_win, tui_prev_win)
 633         (tui_delete_invisible_windows): Update.
 634
 635 2019-08-16  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-winsource.h (struct tui_source_window_base)
 638         <m_has_locator>: Remove.
 639         * tui/tui-layout.c (show_source_disasm_command, show_data)
 640         (show_source_or_disasm_and_command): Update.
 641
 642 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 643
 644         * NEWS (Other MI changes): New subsection.
 645         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 646         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 647         * arch-utils.c (default_get_pc_address_flags): New function.
 648         * arch-utils.h (default_get_pc_address_flags): New declaration.
 649         * gdbarch.sh: Add get_pc_address_flags.
 650         * gdbarch.c: Regenerate.
 651         * gdbarch.h: Likewise.
 652         * stack.c (print_pc): New function.
 653         (print_frame_info) (print_frame): Call print_pc.
 654
 655 2019-08-16  Tom de Vries  <tdevries@suse.de>
 656
 657         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 658         print_objfile_section_info.
 659
 660 2019-08-15  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 663         calling update_cmdwin_start_line.
 664         * tui/tui-winsource.h (struct tui_source_window_base)
 665         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 666         <rerender>: Declare.
 667         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 668         Call rerender.
 669         (tui_source_window_base::set_new_height): Remove.
 670         (tui_source_window_base::rerender): Rename from
 671         do_make_visible_with_new_height.
 672         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 673         resize method.
 674         (tui_win_info::make_invisible_and_set_new_height)
 675         (tui_win_info::make_visible_with_new_height): Remove.
 676         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 677         Declare.
 678         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 679         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 680         do_make_visible_with_new_height>: Don't declare.
 681         <rerender>: Declare.
 682         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 683         set_new_height.
 684         (tui_data_window::do_make_visible_with_new_height): Remove.
 685         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 686         call tui_show_locator_content.
 687         (tui_gen_win_info::resize): Call rerender.
 688         (show_source_or_disasm_and_command): Don't call
 689         tui_show_locator_content.
 690         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 691         method.
 692         (struct tui_win_info) <rerender>: Declare.
 693         <set_new_height, make_invisible_and_set_new_height,
 694         make_visible_with_new_height>: Don't declare.
 695         * tui/tui-data.c (tui_win_list::rerender): New method.
 696         * tui/tui-command.h (struct tui_cmd_window)
 697         <do_make_visible_with_new_height>: Don't declare.
 698         * tui/tui-command.c
 699         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 700
 701 2019-08-15  Tom Tromey  <tromey@adacore.com>
 702
 703         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 704         * ada-lang.c (ada_enum_name): Likewise.
 705
 706 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 707
 708         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 709         leading underscore.
 710         (GdbOutputErrorFile): Likewise.
 711         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 712         accordingly.
 713         (execute_unwinders): Rename to have a leading underscore.
 714         (auto_load_packages): Likewise.
 715         (global scope): Adjust call to auto_load_packages accordingly.
 716         (GdbSetPythonDirectory): Likewise.
 717         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 718         instead of execute_unwinders.
 719
 720 2019-08-15  Tom Tromey  <tom@tromey.com>
 721
 722         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 723         (show_data): Don't change window visibility.
 724         (tui_gen_win_info::resize): Remove special case for command
 725         window.  Use wresize, when available.
 726         (show_source_or_disasm_and_command): Don't change window
 727         visibility.
 728         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 729         <make_visible>: New method.
 730         * tui/tui-command.c (tui_cmd_window::resize): New method.
 731
 732 2019-08-15  Tom Tromey  <tom@tromey.com>
 733
 734         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 735         (struct tui_source_windows): New.
 736         * tui/tui-winsource.c (tui_display_main): Update.
 737         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 738         (new_height_ok, parse_scrolling_args): Update.
 739         * tui/tui-layout.c (show_layout, show_data): Update.
 740         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 741         (tui_add_to_source_windows): Don't declare.
 742         * tui/tui-data.c (source_windows, tui_source_windows)
 743         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 744
 745 2019-08-15  Tom Tromey  <tom@tromey.com>
 746
 747         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 748         Rename from reset.
 749         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 750         * tui/tui-layout.c (show_source_disasm_command, show_data):
 751         Update.
 752         (tui_gen_win_info::resize): Rename.
 753         (show_source_or_disasm_and_command): Update.
 754         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 755         reset.
 756
 757 2019-08-15  Tom Tromey  <tom@tromey.com>
 758
 759         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 760         * tui/tui-interp.c (tui_interp::init): Don't call
 761         tui_initialize_static_data.
 762         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 763
 764 2019-08-15  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 767         examine tui_win_list.
 768
 769 2019-08-15  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 772         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 773         tui_clear_source_content.
 774         (tui_clear_source_content): Remove.
 775         (tui_source_window_base::do_erase_source_content): Hoist call to
 776         content.clear().
 777         * tui/tui-stack.c (tui_show_frame_info): Don't call
 778         tui_clear_source_content.
 779
 780 2019-08-15  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-winsource.h (struct tui_source_window_base)
 783         <do_erase_source_content>: New method.
 784         <erase_source_content>: New method.
 785         (tui_erase_source_content): Don't declare.
 786         * tui/tui-winsource.c (tui_clear_source_content): Update.
 787         (tui_source_window_base::do_erase_source_content): Rename from
 788         tui_erase_source_content.
 789         (tui_source_window_base::show_source_content): Update.
 790         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 791         * tui/tui-source.h (struct tui_source_window)
 792         <erase_source_content>: New method.
 793         * tui/tui-disasm.h (struct tui_disasm_window)
 794         <erase_source_content>: New method.
 795
 796 2019-08-15  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 799         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 800         constructor.
 801         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 802         * tui/tui-source.c (tui_set_source_content): Update.
 803         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 804
 805 2019-08-15  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 808         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 809         tui-source.c.
 810         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 811         Declare.
 812         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 813         method.
 814         (tui_source_window::maybe_update): Update.
 815
 816 2019-08-15  Tom Tromey  <tom@tromey.com>
 817
 818         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 819         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 820         tui-disasm.c.
 821         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 822         Declare.
 823         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 824         method.
 825         (tui_disasm_window::maybe_update): Update.
 826
 827 2019-08-15  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-winsource.h (struct tui_source_window_base)
 830         <maybe_update>: Declare.
 831         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 832         method.
 833         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 834         Declare.
 835         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 836         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 837         Declare.
 838         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 839
 840 2019-08-15  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 843
 844 2019-08-15  Tom Tromey  <tom@tromey.com>
 845
 846         * tui/tui-wingeneral.c: Include tui-stack.h.
 847         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 848         (struct tui_locator_window): Move from tui-data.h.
 849         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 850         (tui_initialize_static_data): Move from tui-data.c.
 851         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 852         (struct tui_locator_window): Move to tui-stack.c.
 853         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 854         (tui_initialize_static_data): Move to tui-stack.c.
 855
 856 2019-08-15  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-layout.c (show_source_disasm_command)
 859         (show_source_or_disasm_and_command): Use make_visible method, not
 860         tui_make_window.
 861         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 862         Remove.
 863
 864 2019-08-15  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-wingeneral.h (tui_make_window): Update.
 867         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 868         parameter.
 869         (tui_gen_win_info::make_visible): Update.
 870         * tui/tui-regs.c (tui_data_window::display_registers_from):
 871         Update.
 872         * tui/tui-layout.c (show_source_disasm_command)
 873         (show_source_or_disasm_and_command): Update.
 874         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 875         (enum tui_box): Remove.
 876         (struct tui_win_info) <can_box>: New method.
 877         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 878         method.
 879
 880 2019-08-15  Tom de Vries  <tdevries@suse.de>
 881
 882         * linux-nat-trad.c: Include gdbarch.h.
 883
 884 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 885
 886         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 887         register sizes.
 888
 889 2019-08-14  Tom Tromey  <tromey@adacore.com>
 890
 891         * darwin-nat.c: Include gdbarch.h.
 892         * darwin-nat-info.c: Include gdbarch.h.
 893
 894 2019-08-13  Tom Tromey  <tom@tromey.com>
 895
 896         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 897         Remove.
 898         * tui/tui-data.c (tui_initialize_static_data): Update.
 899
 900 2019-08-13  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-winsource.h (struct tui_exec_info_window)
 903         <~tui_exec_info_window, maybe_allocate_content, get_content,
 904         m_content>: Remove.
 905         (struct tui_source_window_base) <set_exec_info_content,
 906         show_exec_info_content>: Don't declare.
 907         * tui/tui-winsource.c
 908         (tui_exec_info_window::maybe_allocate_content): Remove.
 909         (tui_source_window_base::update_exec_info): Rename from
 910         set_exec_info_content.
 911         (tui_source_window_base::show_exec_info_content)
 912         (tui_source_window_base::update_exec_info): Remove.
 913
 914 2019-08-13  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 917         declare.
 918         * tui/tui-winsource.c (tui_update_source_window_as_is)
 919         (tui_update_source_windows_with_addr, tui_erase_source_content):
 920         Update.
 921         (tui_clear_exec_info_content): Remove.
 922
 923 2019-08-13  Tom Tromey  <tom@tromey.com>
 924
 925         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 926         declare.
 927         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 928         call tui_erase_exec_info_content.
 929         (tui_clear_exec_info_content): Rename from
 930         tui_erase_exec_info_content.
 931         (tui_clear_exec_info_content): Delete.
 932
 933 2019-08-13  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-winsource.h (struct tui_source_window_base)
 936         <show_exec_info_content>: Declare.
 937         (tui_show_exec_info_content): Don't declare.
 938         * tui/tui-winsource.c
 939         (tui_source_window_base::show_exec_info_content): Rename from
 940         tui_show_exec_info_content.
 941         (tui_source_window_base::update_exec_info): Update.
 942
 943 2019-08-13  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 946         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 947         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 948         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 949         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 950         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 951         ... here.
 952
 953 2019-08-13  Tom Tromey  <tom@tromey.com>
 954
 955         * tui/tui-winsource.h (struct tui_source_window_base)
 956         <update_exec_info>: Declare.
 957         (tui_update_exec_info): Don't declare.
 958         * tui/tui-winsource.c (tui_update_source_window_as_is)
 959         (tui_source_window_base::refresh_all)
 960         (tui_update_all_breakpoint_info): Update.
 961         (tui_source_window_base::update_exec_info): Rename from
 962         tui_update_exec_info.
 963         * tui/tui-stack.c (tui_show_frame_info): Update.
 964
 965 2019-08-13  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-winsource.h (struct tui_source_window_base)
 968         <set_exec_info_content>: Declare.
 969         (tui_set_exec_info_content): Don't declare.
 970         * tui/tui-winsource.c
 971         (tui_source_window_base::set_exec_info_content): Rename from
 972         tui_set_exec_info_content.
 973         (tui_update_exec_info): Update.
 974
 975 2019-08-13  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-winsource.h (struct tui_source_window_base)
 978         <show_source_content>: Declare.
 979         (tui_show_source_content): Don't declare.
 980         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 981         (tui_source_window_base::show_source_content): Rename from
 982         tui_show_source_content.
 983         (tui_source_window_base::refresh_all): Update.
 984         * tui/tui-layout.c (show_source_disasm_command)
 985         (show_source_or_disasm_and_command): Update.
 986
 987 2019-08-13  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-winsource.c (tui_erase_source_content)
 990         (tui_show_source_content, tui_source_window_base::refresh_all):
 991         Update.
 992         * tui/tui-wingeneral.h
 993         (tui_check_and_display_highlight_if_needed): Don't declare.
 994         * tui/tui-wingeneral.c
 995         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 996         check_and_display_highlight_if_needed.
 997         * tui/tui-win.c (tui_rehighlight_all)
 998         (tui_win_info::make_visible_with_new_height): Update.
 999         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1000         (tui_data_window::erase_data_content)
1001         (tui_data_window::display_all_data): Update.
1002         * tui/tui-data.h (struct tui_win_info)
1003         <check_and_display_highlight_if_needed>: Declare.
1004
1005 2019-08-13  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-win.c (tui_resize_all): Call
1008         tui_delete_invisible_windows.
1009         * tui/tui-layout.c (show_layout): Call
1010         tui_delete_invisible_windows.
1011         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1012         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1013
1014 2019-08-13  Tom Tromey  <tom@tromey.com>
1015
1016         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1017         tui_add_win_to_layout.
1018
1019 2019-08-13  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1022         * tui/tui-layout.c (tui_default_win_height): Now static.
1023
1024 2019-08-13  Tom Tromey  <tom@tromey.com>
1025
1026         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1027         single switch.
1028         (show_source_disasm_command, show_source_or_disasm_and_command):
1029         Don't check current layout.
1030
1031 2019-08-13  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-wingeneral.c (make_all_visible): Remove.
1034         (tui_make_all_invisible): Simplify.
1035         * tui/tui-layout.c (tui_make_all_invisible): Move from
1036         tui-wingeneral.c; simplify.
1037         (show_layout): Hoist call to tui_make_all_invisible.
1038         (show_data): Don't call tui_make_all_invisible.
1039
1040 2019-08-13  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1043         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1044
1045 2019-08-13  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1048         tui-data.c.
1049         (show_source_disasm_command, show_data)
1050         (show_source_or_disasm_and_command): Don't use
1051         tui_set_current_layout_to.
1052         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1053         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1054         tui-layout.c.
1055         (tui_set_current_layout_to): Remove.
1056
1057 2019-08-13  Tom Tromey  <tom@tromey.com>
1058
1059         * tui/tui-layout.c (tui_set_layout): Update.
1060         * tui/tui-data.h (struct tui_layout_def): Remove.
1061         (tui_layout_def): Don't declare.
1062         * tui/tui-data.c (layout_def): Remove.
1063         (tui_layout_def): Remove.
1064
1065 2019-08-13  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-winsource.h (struct tui_source_window_base)
1068         <clear_detail>: No longer "override".
1069         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1070         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1071         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1072         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1073         Remove.
1074         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1075
1076 2019-08-13  Tom Tromey  <tromey@adacore.com>
1077
1078         * tracepoint.c: Don't include readline.h or history.h.
1079
1080 2019-08-12  Tom Tromey  <tom@tromey.com>
1081
1082         * configure: Rebuild.
1083         * configure.ac: Check for readline 7.
1084         * NEWS: Mention readline 7 requirement.
1085         * README: Update.
1086
1087 2019-08-12  Tom Tromey  <tom@tromey.com>
1088
1089         * mingw-hdep.c (gdb_select): Remove readline hack.
1090
1091 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1092
1093         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1094         when the function fails.
1095
1096 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1097
1098         * s390-tdep.c (s390_type_align): New function.
1099         (s390_gdbarch_init): Set it as type_align gdbarch method.
1100
1101 2019-08-09  Tom de Vries  <tdevries@suse.de>
1102
1103         PR gdb/24591
1104         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1105         pc_low with relocation offset.
1106
1107 2019-08-07  Tom Tromey  <tromey@adacore.com>
1108
1109         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1110         (print_frame_args): Update.
1111         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1112         Update.
1113         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1114         * frame.h (struct frame_arg): Add initializers.
1115         <error>: Now a unique_xmalloc_ptr.
1116
1117 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1118
1119         * NEWS: Expand the Pointer Authentication entry.
1120         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1121         (aarch64_frame_unmask_lr): ... to this.
1122         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1123         Call aarch64_frame_unmask_lr.
1124         * frame.c (struct frame_info): Add "masked" variable.
1125         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1126         (fprint_frame): Check for masked pc.
1127         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1128         declarations.
1129         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1130         * stack.c (print_frame): Check for masked pc.
1131
1132 2019-08-06  Tom Tromey  <tom@tromey.com>
1133
1134         * stabsread.c (patch_block_stabs, read_one_struct_field)
1135         (read_enum_type): Use obstack_strndup.
1136         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1137         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1138         * dwarf2read.c (guess_full_die_structure_name)
1139         (anonymous_struct_prefix): Use obstack_strndup.
1140         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1141         * c-exp.y (yylex): Use obstack_strndup.
1142         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1143         (write_var_or_type): Use obstack_strndup.
1144
1145 2019-08-06  Tom Tromey  <tom@tromey.com>
1146
1147         * symfile.c (reread_symbols): Use obstack_strdup.
1148         * stabsread.c (read_type): Use obstack_strdup.
1149         * gdb_obstack.h (obstack_strdup): New overload.
1150         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1151         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1152         (dwarf2_canonicalize_name): Use obstack_strdup.
1153         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1154         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1155         Use obstack_strdup.
1156
1157 2019-08-06  Tom Tromey  <tom@tromey.com>
1158
1159         * gdb_obstack.h (obstack_strdup): Define.
1160         * gdb_obstack.c (obstack_strdup): Don't define.
1161
1162 2019-08-06  Tom Tromey  <tom@tromey.com>
1163
1164         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1165         obstack_strdup.
1166         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1167         obstack_strdup.
1168         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1169         * stabsread.c (common_block_start): Use obstack_strdup.
1170         * objfiles.c (set_objfile_main_name, objfile): Use
1171         obstack_strdup.
1172         * namespace.c (add_using_directive): Use obstack_strdup.
1173         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1174         * jit.c (finalize_symtab): Use obstack_strdup.
1175         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1176         (guess_partial_die_structure_name, partial_die_info::fixup)
1177         (dwarf2_name): Use obstack_strdup.
1178         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1179         obstack_strdup.
1180         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1181         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1182         obstack_strdup.
1183         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1184
1185 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1186
1187         * unittests/help-doc-selftests.c: New file.
1188         * Makefile.in: Add the new file.
1189
1190 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1191
1192         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1193         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1194         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1195         the trailing '.' is not output, and the first character is uppercased.
1196         (print_help_for_command): Update call to print_doc_line.
1197         (print_doc_of_command): Likewise.
1198         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1199         * cli/cli-option.c (append_indented_doc): Do not append newline.
1200         (build_help_option): Append newline after first appended_indented_doc
1201         only if a second call is done.
1202         (build_help): Append 2 new lines before each option, except the first
1203         one.
1204         * compile/compile.c (_initialize_compile): Add new lines after
1205         %OPTIONS%, when not at the end of the help.
1206         Change help doc or code
1207         producing the help doc to respect the invariants.
1208         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1209         Also removed the new line after 'Options:', as all other commands
1210         do not put an empty line between 'Options:' and the first option.
1211         * printcmd.c (_initialize_printcmd): Likewise.
1212         * stack.c (_initialize_stack): Likewise.
1213         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1214         incorrectly telling COMMAND is optional.
1215         * ada-lang.c (_initialize_ada_language): Change help doc or code
1216         producing the help doc to respect the invariants.
1217         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1218         * breakpoint.c (_initialize_breakpoint): Likewise.
1219         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1220         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1221         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1222         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1223         _initialize_cli_style): Likewise.
1224         * corelow.c (core_target_info): Likewise.
1225         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1226         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1227         * filesystem.c (_initialize_filesystem): Likewise.
1228         * frame.c (_initialize_frame): Likewise.
1229         * gnu-nat.c (add_task_commands): Likewise.
1230         * infcall.c (_initialize_infcall): Likewise.
1231         * infcmd.c (_initialize_infcmd): Likewise.
1232         * interps.c (_initialize_interpreter): Likewise.
1233         * language.c (_initialize_language): Likewise.
1234         * linux-fork.c (_initialize_linux_fork): Likewise.
1235         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1236         * maint.c (_initialize_maint_cmds): Likewise.
1237         * memattr.c (_initialize_mem): Likewise.
1238         * printcmd.c (_initialize_printcmd): Likewise.
1239         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1240         _RegEx): Likewise.
1241         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1242         * record-btrace.c (_initialize_record_btrace): Likewise.
1243         * record-full.c (_initialize_record_full): Likewise.
1244         * record.c (_initialize_record): Likewise.
1245         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1246         * regcache.c (_initialize_regcache): Likewise.
1247         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1248         _initialize_remote): Likewise.
1249         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1250         * serial.c (_initialize_serial): Likewise.
1251         * skip.c (_initialize_step_skip): Likewise.
1252         * source.c (_initialize_source): Likewise.
1253         * stack.c (_initialize_stack): Likewise.
1254         * symfile.c (_initialize_symfile): Likewise.
1255         * symtab.c (_initialize_symtab): Likewise.
1256         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1257         * top.c (init_main): Likewise.
1258         * tracefile-tfile.c (tfile_target_info): Likewise.
1259         * tracepoint.c (_initialize_tracepoint): Likewise.
1260         * tui/tui-win.c (_initialize_tui_win): Likewise.
1261         * utils.c (add_internal_problem_command): Likewise.
1262         * valprint.c (value_print_option_defs): Likewise.
1263
1264 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1265
1266         PR build/24886
1267         * configure.ac: Drop enable-libmcheck support.
1268         * configure, config.in: Rebuild.
1269         * libmcheck.m4: Remove.
1270         * acinclude.m4: Don't include it.
1271         * Makefile.in: Don't distribute it.
1272         * top.c (print_gdb_configuration): Don't mention it.
1273
1274 2019-08-06  Tom Tromey  <tom@tromey.com>
1275
1276         * utils.c (set_output_style): Sometimes pass stream to
1277         emit_style_escape.
1278         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1279         * record-btrace.c (btrace_insn_history): Update.
1280         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1281         method.
1282         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1283         Update initializers.
1284         <m_uiout>: New field.
1285         <m_di>: Move lower.
1286         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1287         Remove "uiout" parameter.
1288         (dump_insns): Update.
1289         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1290         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1291
1292 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1293
1294         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1295         (error_in_psymtab_expansion): Likewise.
1296         (lookup_symbol_via_quick_fns): Likewise.
1297         (basic_lookup_transparent_type_quick): Likewise.
1298         (basic_lookup_transparent_type_1): Likewise.
1299
1300 2019-08-06  Tom Tromey  <tromey@adacore.com>
1301
1302         * source.c (last_source_error): Now bool.
1303         (print_source_lines_base): Make "noprint" bool.  Only open
1304         source file when last_source_visited changes.
1305
1306 2019-08-06  Tom Tromey  <tromey@adacore.com>
1307
1308         * annotate.c (annotate_source_line): Use g_source_cache.
1309         * source-cache.c (source_cache::get_plain_source_lines): Change
1310         parameters.  Populate m_offset_cache.
1311         (source_cache::ensure): New method.
1312         (source_cache::get_line_charpos): New method.
1313         (extract_lines): Move lower.  Change parameters.
1314         (source_cache::get_source_lines): Move lower.
1315         * source-cache.h (class source_cache): Update comment.
1316         <get_line_charpos>: New method.
1317         <get_source_lines>: Update comment.
1318         <clear>: Clear m_offset_cache.
1319         <get_plain_source_lines>: Change parameters.
1320         <ensure>: New method
1321         <m_offset_cache>: New member.
1322         * source.c (forget_cached_source_info_for_objfile): Update.
1323         (info_source_command): Use g_source_cache.
1324         (find_source_lines, open_source_file_with_line_charpos): Remove.
1325         (print_source_lines_base, search_command_helper): Use g_source_cache.
1326         * source.h (open_source_file_with_line_charpos): Don't declare.
1327         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1328         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1329         Use g_source_cache.
1330
1331 2019-08-06  Tom Tromey  <tromey@adacore.com>
1332
1333         * source-cache.c (source_cache::get_plain_source_lines):
1334         Remove "first_line" and "last_line" parameters.
1335         (source_cache::get_source_lines): Cache plain text.
1336         * source-cache.h (class source_cache)
1337         <get_plain_source_lines>: Update.
1338
1339 2019-08-06  Tom Tromey  <tromey@adacore.com>
1340
1341         * source-cache.c (extract_lines): No longer a method.
1342         Changed type of parameter.  Include final newline.
1343         (selftests::extract_lines_test): New function.
1344         (_initialize_source_cache): Likewise.
1345         * source-cache.h (class source_cache)
1346         <extract_lines>: Don't declare.
1347
1348 2019-08-06  Tom Tromey  <tromey@adacore.com>
1349
1350         * breakpoint.c (init_breakpoint_sal): Update.
1351         (breakpoint): Update.
1352         * breakpoint.h (struct breakpoint) <filter>: Now a
1353         unique_xmalloc_ptr.
1354
1355 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1356
1357         * NEWS: Mention dictionary access on blocks.
1358         * python/py-block.c (blpy_getitem): New function.
1359         (block_object_as_mapping): New struct.
1360         (block_object_type): Use new struct for tp_as_mapping field.
1361
1362 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1363
1364         * objfiles.h (objfile): Add a comment describing partial symbols.
1365
1366 2019-08-05  Tom Tromey  <tromey@adacore.com>
1367
1368         * compile/compile.c (_initialize_compile): Use _(), not N_().
1369         * thread.c (_initialize_thread): Use _(), not N_().
1370         * stack.c (_initialize_stack): Use _(), not N_().
1371         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1372
1373 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1374
1375         * dwarf2read.c (struct dw2_symtab_iterator):
1376         <want_specific_block>: Remove.
1377         <block_index>: Change type to gdb::optional.
1378         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1379         change type of BLOCK_INDEX parameter to gdb::optional.
1380         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1381         (dw2_lookup_symbol): Don't pass argument for
1382         WANT_SPECIFIC_BLOCK.
1383         (dw2_expand_symtabs_for_function): Don't pass argument for
1384         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1385         (class dw2_debug_names_iterator)
1386         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1387         parameter, change BLOCK_INDEX type to gdb::optional.
1388         <m_want_specific_block>: Remove.
1389         <m_block_index>: Change type to gdb::optional.
1390         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1391         gdb::optional.  Re-write in function of gdb::optional.
1392         (dw2_debug_names_lookup_symbol): Don't pass argument for
1393         WANT_SPECIFIC_BLOCK.
1394         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1395         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1396         BLOCK_INDEX.
1397
1398 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1399
1400         * NEWS: Mention changes to "info sources" command.
1401
1402 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1403
1404         * symtab.c (filename_partial_match_opts): New struct type.
1405         (struct output_source_filename_data): New members
1406         regexp, c_regexp, partial_match.
1407         (output_source_filename): Use new members to decide to print file.
1408         (info_sources_option_defs): New variable.
1409         (make_info_sources_options_def_group, print_info_sources_header,
1410         info_sources_command_completer):
1411         New functions.
1412         (info_sources_command): Read new optional arguments.
1413         (_initialize_symtab): Update info sources help.
1414
1415 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1416
1417         * ada-lang.c (exception_support_info_v0): Renamed from...
1418         (default_exception_support_info): ... this.  Create new
1419         definition for v1.
1420         (ada_has_this_exception_support): Look up catch_handlers_sym.
1421         (ada_exception_support_info_sniffer): Try v0 after default.
1422
1423 2019-08-01  Tom Tromey  <tromey@adacore.com>
1424
1425         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1426         gdbarch.h.
1427
1428 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1429
1430         * s12z-tdep.c: Fix include path for s12z-opc.h.
1431
1432 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1433
1434         * NEWS: Require GNU make 3.82.
1435
1436 2019-07-16  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1439         declare.
1440
1441 2019-07-30  Tom Tromey  <tromey@adacore.com>
1442
1443         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1444
1445 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1446
1447         * printcmd.c (print_address_symbolic): Print negative offsets.
1448         (build_address_symbolic): Force signed arithmetic when computing
1449         offset.
1450
1451 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1452
1453         PR/24474: Add a function to lookup static variables.
1454         * NEWS: Mention this new function.
1455         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1456         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1457         * python/python.c (python_GdbMethods): Add new function.
1458
1459 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1460
1461         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1462         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1463         (objfpy_lookup_static_symbol): New function.
1464         (objfile_object_methods): Add new functions.
1465
1466 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1467
1468         * NEWS: Mention 'set|show print frame-info'.  Mention new
1469         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1470         backtrace argument.  Mention that python frame filtering code
1471         is now consistent with what 'backtrace' command prints.
1472
1473 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1474
1475         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1476         comments.
1477         (print_frame_info_auto, print_frame_info_source_line,
1478         print_frame_info_location, print_frame_info_source_and_location,
1479         print_frame_info_location_and_address, print_frame_info_short_location):
1480         New declarations.
1481         (struct frame_print_options): New member print_frame_info.
1482         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1483         * stack.h (get_user_print_what_frame_info): New declaration.
1484         (frame_show_address): New declaration.
1485         * stack.c (print_frame_arguments_choices): New value 'presence'.
1486         (print_frame_info_auto, print_frame_info_source_line,
1487         print_frame_info_location, print_frame_info_source_and_location,
1488         print_frame_info_location_and_address, print_frame_info_short_location,
1489         print_frame_info_choices, print_frame_info_print_what): New definitions.
1490         (print_frame_args): Only print dots for args if print frame-arguments
1491         is 'presence'.
1492         (frame_print_option_defs): New element for "frame-info".
1493         (get_user_print_what_frame_info): New function.
1494         (frame_show_address): Make non static.  Move comment to stack.h.
1495         (print_frame_info_to_print_what): New function.
1496         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1497         to decide what to print.
1498         (backtrace_command_1): Handle the new print_frame_arguments_presence
1499         value.
1500         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1501         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1502         (py_print_frame): In non-mi mode, use LOCATION as default for
1503         print_what, similarly to frame information printed directly by
1504         backtrace command. Handle frame-info user option in non MI mode.
1505
1506 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1507
1508         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1509         Add case for debugging 32-bit target on 64-bit host.  Revise
1510         comment.
1511
1512 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1513
1514         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1515         instead of find_function_entry_range_from_pc.
1516
1517 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1518
1519         * stack.c (find_frame_funname): Remove code which preferred
1520         minsym over symtab sym in "certain pathological cases".
1521
1522         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1523         parameter.  Change type of "do_demangle" to bool.
1524         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1525         Pass suitable "prefer_sym_over_minsym" flag to
1526         build_address_symbolic().  Don't output "+" for negative offsets.
1527         * printcmd.c (print_address_symbolic): Update invocation of
1528         build_address_symbolic to include a "prefer_sym_over_minsym"
1529         flag.
1530         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1531         Restrict cases in which use of minimal symbol is preferred to that
1532         of a found symbol.  Update comments.
1533
1534         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1535         for entry pc when entry pc is out of range for that FDE.
1536
1537 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1538
1539         PR gdb/24839:
1540         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1541         type.
1542
1543 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1544
1545         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1546         this function's Python signature.
1547
1548
1549 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1550
1551         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1552         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1553         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1554         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1555         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1556
1557
1558 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1559
1560         * h8300-tdep.c (h8300_register_name_common): New.
1561         h8300_register_name): Use h8300_register_name_common.
1562         (h8300s_register_name): Likewise.
1563         (h8300sx_register_name): Likewise.
1564         (h8300h_register_nam): New.
1565         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1566
1567
1568 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1569
1570         * arm-tdep.c (arm_skip_cmse_entry): New function.
1571         (arm_is_sgstubs_section): New function.
1572         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1573
1574 2019-07-22  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1577         Don't self-assign.
1578
1579 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1580
1581         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1582         type_print.
1583
1584 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1585
1586         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1587         so that GDB doesn't match any msymbols when searching in the
1588         TYPES_DOMAIN.
1589         (print_symbol_info): Print using typedef_print or type_print based
1590         on the type of the symbol.  Add updated FIXME comment moved from...
1591         (_initialize_symtab): ... move and update FIXME comment to above.
1592
1593 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1594
1595         * NEWS: Mention adding -q option to "info types".
1596         * symtab.c (struct info_types_options): New struct.
1597         (info_types_options_defs): New variable.
1598         (make_info_types_options_def_group): New function.
1599         (info_types_command): Use gdb::option framework to parse options.
1600         (info_types_command_completer): New function.
1601         (_initialize_symtab): Extend the help text on "info types" and
1602         register command completer.
1603
1604 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1605
1606         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1607         (lookup_symbol_in_objfile): Change int to block_enum and add a
1608         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1609
1610 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1611
1612         * MAINTAINERS (Write After Approval): Add self.
1613
1614 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1615
1616         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1617         instruction to the dummy code region.
1618
1619 2019-07-19  Tom Tromey  <tromey@adacore.com>
1620
1621         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1622         (ARGSUSED, PARAMS, __func__): Remove rules.
1623
1624 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1625
1626         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1627         * features/arm/arm-with-iwmmxt.c: Remove.
1628         * features/arm/arm-with-iwmmxt.xml: Remove.
1629         * features/arm/arm-with-m-fpa-layout.c: Remove.
1630         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1631         * features/arm/arm-with-m-vfp-d16.c: Remove.
1632         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1633         * features/arm/arm-with-m.c: Remove.
1634         * features/arm/arm-with-m.xml: Remove.
1635         * features/arm/arm-with-neon.c: Remove.
1636         * features/arm/arm-with-neon.xml: Remove.
1637         * features/arm/arm-with-vfpv2.c: Remove.
1638         * features/arm/arm-with-vfpv2.xml: Remove.
1639         * features/arm/arm-with-vfpv3.c: Remove.
1640         * features/arm/arm-with-vfpv3.xml: Remove.
1641
1642 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1643
1644         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1645
1646 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1647
1648         * arch/aarch32.c (aarch32_create_target_description): Create
1649         target descriptions using features.
1650         * arch/arm.c (arm_create_target_description)
1651         (arm_create_mprofile_target_description): Likewise.
1652         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1653
1654 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1655
1656         * Makefile.in: Add new files.
1657         * aarch32-tdep.c: New file.
1658         * aarch32-tdep.h: New file.
1659         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1660         Call aarch32_read_description.
1661         * arch/aarch32.c: New file.
1662         * arch/aarch32.h: New file.
1663         * arch/arm.c (arm_create_target_description)
1664         (arm_create_mprofile_target_description): New function.
1665         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1666         (arm_create_target_description)
1667         (arm_create_mprofile_target_description): New declaration.
1668         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1669         read_description functions.
1670         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1671         Likewise.
1672         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1673         * arm-tdep.c (tdesc_arm_list): New variable.
1674         (arm_register_g_packet_guesses): Call create description functions.
1675         (arm_read_description) (arm_read_mprofile_description): New
1676         function.
1677         * arm-tdep.h (arm_read_description)
1678         (arm_read_mprofile_description): Add declaration.
1679         * configure.tgt: Add new files.
1680
1681 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1682
1683         * top.c (new_ui_command): Open specified terminal just once.
1684
1685 2019-07-18  Tom Tromey  <tromey@adacore.com>
1686
1687         * symtab.c (main_name): Constify return type.
1688         * symfile.c (set_initial_language): Update.
1689         * symtab.h (main_name): Constify return type.
1690
1691 2019-07-17  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui-winsource.c (tui_update_source_window)
1694         (tui_update_source_window_as_is)
1695         (tui_update_source_windows_with_line): Remove return.
1696         * tui/tui-disasm.c (tui_show_disassem)
1697         (tui_show_disassem_and_update_source): Remove return.
1698         * tui/tui.c (tui_reset): Remove return.
1699         * tui/tui-wingeneral.c
1700         (tui_check_and_display_highlight_if_needed): Remove return.
1701
1702 2019-07-17  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1705
1706 2019-07-17  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-winsource.h (struct tui_exec_info_window)
1709         (struct tui_source_window_base): Move from tui-data.h.
1710         * tui/tui-winsource.c: Move many method definitions from
1711         elsewhere.  Remove "structuring" comments.
1712         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1713         (tui_source_window_base::refresh_window): Move to
1714         tui-winsource.c.
1715         * tui/tui-win.c (tui_source_window_base::refresh_all)
1716         (tui_source_window_base::update_tab_width)
1717         (tui_source_window_base::set_new_height)
1718         (tui_source_window_base::do_make_visible_with_new_height): Move to
1719         tui-winsource.c.
1720         * tui/tui-source.h: Update.
1721         * tui/tui-source.c (tui_source_window_base::reset): Move to
1722         tui-winsource.c.
1723         * tui/tui-disasm.h: Update.
1724         * tui/tui-data.h (struct tui_exec_info_window): Move to
1725         tui-winsource.h.
1726         (struct tui_source_window_base): Likewise.
1727         * tui/tui-data.c (tui_source_window_base::clear_detail)
1728         (tui_source_window_base, ~tui_source_window_base): Move to
1729         tui-winsource.c.
1730
1731 2019-07-17  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-win.c (tui_resize_all)
1734         (tui_source_window_base::update_tab_width)
1735         (tui_adjust_win_heights): Update.
1736         (tui_win_info::make_invisible_and_set_new_height): Rename from
1737         make_invisible_and_set_new_height.
1738         * tui/tui-data.h (struct tui_win_info)
1739         <make_invisible_and_set_new_height>: New method.
1740
1741 2019-07-17  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui.c: Update.
1744         * tui/tui-source.h (struct tui_source_window): Move from
1745         tui-data.h.
1746         * tui/tui-layout.c: Update.
1747         * tui/tui-disasm.c: Update.
1748         * tui/tui-data.h (struct tui_source_window): Move to
1749         tui-source.h.
1750
1751 2019-07-17  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1754         tui-data.h.
1755         * tui/tui-data.h (struct tui_disasm_window): Move to
1756         tui-disasm.h.
1757
1758 2019-07-17  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-regs.h (struct tui_data_item_window): Move from
1761         tui-data.h.
1762         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1763         * tui/tui-data.h (struct tui_data_item_window): Move to
1764         tui-regs.h.
1765         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1766
1767 2019-07-17  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui.c: Update.
1770         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1771         (tui_cmd_window::max_height): Move to tui-command.c.
1772         * tui/tui-layout.c: Update.
1773         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1774         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1775         tui-command.c.
1776         * tui/tui-command.h (struct tui_cmd_window): Move from
1777         tui-data.h.
1778         * tui/tui-command.c: Remove "structuring" comments.
1779         (tui_cmd_window::clear_detail)
1780         (tui_cmd_window::do_make_visible_with_new_height)
1781         (tui_cmd_window::max_height): Move from elsewhere.
1782
1783 2019-07-17  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1786         Now static.
1787         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1788         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1789
1790 2019-07-17  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui.c: Update.
1793         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1794         tui-regs.c.
1795         * tui/tui-windata.h: Remove file.
1796         * tui/tui-windata.c: Remove file.
1797         * tui/tui-win.c (tui_data_window::set_new_height)
1798         (tui_data_window::do_make_visible_with_new_height): Move to
1799         tui-regs.c.
1800         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1801         * tui/tui-regs.c: Remove "structuring" comments.
1802         (tui_data_window::first_data_item_displayed)
1803         (tui_data_window::delete_data_content_windows)
1804         (tui_data_window::erase_data_content)
1805         (tui_data_window::display_all_data)
1806         (tui_data_window::refresh_all)
1807         (tui_data_window::do_scroll_vertical)
1808         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1809         (tui_data_window::do_make_visible_with_new_height)
1810         (tui_data_window::refresh_window): Move from elsewhere.
1811         (_initialize_tui_regs): Move to end of file.
1812         * tui/tui-layout.c: Update.
1813         * tui/tui-hooks.c: Update.
1814         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1815         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1816         tui-regs.c.
1817         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1818
1819 2019-07-17  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1822         seen.
1823
1824 2019-07-17  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-win.c (tui_source_window_base::set_new_height)
1827         (tui_source_window_base::do_make_visible_with_new_height): Use
1828         m_has_locator field directly.
1829         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1830         method.
1831         (struct tui_source_window_base) <has_locator>: Likewise.
1832
1833 2019-07-17  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1836         Don't declare.
1837         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1838         Remove.
1839         * tui/tui-win.c (tui_source_window_base::set_new_height)
1840         (tui_source_window_base::set_new_height)
1841         (make_invisible_and_set_new_height)
1842         (tui_source_window_base::do_make_visible_with_new_height)
1843         (tui_source_window_base::do_make_visible_with_new_height):
1844         Update.
1845         * tui/tui-layout.c (show_source_disasm_command, show_data)
1846         (show_source_or_disasm_and_command): Update.
1847         * tui/tui-layout.c (show_layout): Update.
1848
1849 2019-07-17  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui-layout.c (make_data_window): Remove.
1852         (show_data): Unify creation and re-initialization cases.
1853
1854 2019-07-17  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-layout.c (make_source_window, make_disasm_window):
1857         Remove.
1858         (show_data): Unify creation and re-initialization cases.
1859
1860 2019-07-17  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-layout.c (make_command_window): Remove.
1863         (show_source_disasm_command, show_source_or_disasm_and_command):
1864         Unify creation and re-initialization cases.
1865
1866 2019-07-17  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1869         creation and re-initialization cases.
1870
1871 2019-07-17  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-regs.c (tui_get_register): Return void.
1874
1875 2019-07-17  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1878         Simplify.
1879
1880 2019-07-17  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1883         resetting.
1884
1885 2019-07-17  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1888         * tui/tui-regs.c (tui_reg_layout): New function.
1889         (tui_show_registers, tui_reg_command): Use it.
1890         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1891         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1892         parameters.
1893         (tui_layout_command): Remove.
1894
1895 2019-07-17  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui-layout.h (tui/tui-layout): Return void.
1898         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1899
1900 2019-07-17  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-layout.c (show_source_disasm_command, show_data):
1903         Update.
1904         (reset_locator): Remove.
1905         (show_source_or_disasm_and_command): Update.
1906
1907 2019-07-17  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-source.c (tui_source_window_base::reset): Remove
1910         win_type parameter.
1911         * tui/tui-layout.c (make_command_window, make_source_window)
1912         (make_disasm_window, make_data_window)
1913         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1914         (reset_locator, show_source_or_disasm_and_command): Update.
1915         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1916         win_type parameter.
1917         (struct tui_source_window_base) <reset>: Likewise.
1918
1919 2019-07-17  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-layout.c (show_source_disasm_command): Use
1922         reset_locator.
1923         (reset_locator): New function.
1924         (init_and_make_win): Remove.
1925         (show_source_or_disasm_and_command): Use reset_locator.
1926
1927 2019-07-17  Tom Tromey  <tom@tromey.com>
1928
1929         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1930         condition.
1931         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1932         Remove condition.
1933         * tui/tui-source.c (tui_source_window_base::reset): New method.
1934         * tui/tui-layout.c (make_command_window): Don't call
1935         init_and_make_win.
1936         (make_source_window, make_disasm_window): Don't call
1937         make_source_or_disasm_window.
1938         (make_data_window): Don't call init_and_make_win.  Change calling
1939         convention.
1940         (show_source_disasm_command, show_data): Simplify.
1941         (make_source_or_disasm_window): Remove.
1942         (show_source_or_disasm_and_command): Simplify.
1943         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1944         (struct tui_source_window_base) <reset>: Likewise.
1945         <execution_info>: Remove initializer.
1946         * tui/tui-data.c (tui_source_window_base): Initialize
1947         execution_info.
1948
1949 2019-07-17  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1952         variable.
1953
1954 2019-07-17  Tom Tromey  <tom@tromey.com>
1955
1956         * tui/tui.c (tui_rl_other_window): Update.
1957         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1958         superclass method first.  Always iterate over regs_content.
1959         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1960         method.
1961         * tui/tui-win.c (tui_set_focus_command): Update.
1962
1963 2019-07-17  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-win.c (tui_set_focus_command): Rename from
1966         tui_set_focus.  Call tui_enable.
1967         (tui_set_focus_command): Remove.
1968
1969 2019-07-17  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1972         refresh_window.
1973         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1974         touchwin.
1975         (tui_data_window::refresh_window): Call refresh_window on data
1976         items.  Always call superclass refresh_window.
1977         (tui_win_info::refresh): Remove.
1978         (tui_source_window_base::refresh_window): Update.
1979         (tui_refresh_all): Update.
1980         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1981         refresh_window.
1982         (show_source_or_disasm_and_command): Likewise.
1983         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1984         (struct tui_source_window_base) <refresh>: Likewise.
1985
1986 2019-07-17  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-winsource.c (tui_clear_source_content)
1989         (tui_show_source_content): Update.
1990         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1991         whether content is empty.
1992         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1993         Remove.
1994
1995 2019-07-17  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1998         window's contents.
1999         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2000         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2001
2002 2019-07-17  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2005         (struct tui_data_item_window): Update.
2006
2007 2019-07-17  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2010         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2011         defines.
2012
2013 2019-07-17  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-winsource.h (tui_erase_source_content)
2016         (tui_clear_source_content): Remove "display_prompt" parameter.
2017         * tui/tui-winsource.c (tui_update_source_window_as_is)
2018         (tui_update_source_windows_with_addr): Update.
2019         (tui_clear_source_content): Remove "display_prompt" parameter.
2020         (tui_erase_source_content): Likewise.  Simplify.
2021         (tui_show_source_content): Update.
2022         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2023         * tui/tui-stack.c (tui_show_frame_info): Update.
2024         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2025         Remove defines.
2026
2027 2019-07-17  Tom Tromey  <tom@tromey.com>
2028
2029         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2030         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2031         parameter.
2032         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2033         parameter.
2034
2035 2019-07-17  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-winsource.c (tui_clear_source_content)
2038         (tui_show_source_content, tui_show_exec_info_content)
2039         (tui_clear_exec_info_content): Update.
2040         * tui/tui-stack.c (tui_show_locator_content): Update.
2041         (tui_show_frame_info): Update.
2042         * tui/tui-source.h (tui_source_window): Don't declare.
2043         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2044         from tui_source_is_displayed.
2045         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2046         Remove field.
2047         (struct tui_source_window_base) <content_in_use>: New field.  Now
2048         bool.
2049         (struct tui_source_window) <showing_source_p>: New method.
2050         (TUI_SRC_WIN): Change cast.
2051         * tui/tui-data.c (tui_initialize_static_data): Update.
2052
2053 2019-07-17  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2056         location_matches_p.
2057         * tui/tui-source.c (tui_source_window::location_matches_p): New
2058         method.
2059         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2060         method.
2061         * tui/tui-data.h (struct tui_source_window_base)
2062         <location_matches_p>: New method.
2063         (struct tui_source_window, struct tui_disasm_window)
2064         <location_matches_p>: Likewise.
2065
2066 2019-07-17  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-win.c (tui_set_win_height_command): Rename from
2069         tui_set_win_height.
2070         (tui_set_win_height_command): Remove.
2071
2072 2019-07-17  Tom Tromey  <tom@tromey.com>
2073
2074         * tui/tui-source.c (tui_source_window): New constructor.  Add
2075         observer.
2076         (~tui_source_window): New destructor.
2077         (tui_source_window::style_changed): New method.
2078         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2079         (tui_attach_detach_observers): Update.
2080         * tui/tui-data.h (struct tui_source_window): Make constructor not
2081         inline.  Add destructor.
2082         (struct tui_source_window) <style_changed>: New method.
2083         <m_observable>: New member.
2084
2085 2019-07-17  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2088         * tui/tui-win.c (tui_resize_all): Fix typo.
2089
2090 2019-07-17  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2093         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2094         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2095         * tui/tui-win.c (window_name_completer): Use foreach.
2096         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2097         (update_tab_width): Likewise.
2098         * tui/tui-layout.c (show_layout): Update.
2099         * tui/tui-data.h (class tui_window_iterator): New.
2100         (struct all_tui_windows): New.
2101         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2102
2103 2019-07-17  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2106         parameter.  Don't reference globals.
2107         (tui_reg_command): Update.
2108
2109 2019-07-17  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-regs.c (tui_show_registers): Simplify.
2112
2113 2019-07-17  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-regs.c (tui_show_registers): Update.
2116         (tui_show_register_group): Add win_info parameter.
2117
2118 2019-07-17  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2121         Rename from tui_display_reg_element_at_line.
2122         (tui_data_window::display_registers_from_line): Update.
2123         * tui/tui-data.h (struct tui_data_window)
2124         <display_reg_element_at_line>: New method.
2125
2126 2019-07-17  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-regs.h (tui_display_registers_from)
2129         (tui_display_registers_from_line): Don't declare.
2130         * tui/tui-windata.c (tui_data_window::display_all_data)
2131         (tui_data_window::refresh_all)
2132         (tui_data_window::do_scroll_vertical): Update.
2133         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2134         from tui_display_registers_from.
2135         (tui_display_reg_element_at_line): Update.
2136         (tui_data_window::display_registers_from_line): Rename from
2137         tui_display_registers_from_line.
2138         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2139         display_registers_from_line>: New methods.
2140
2141 2019-07-17  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2144         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2145         from tui_erase_data_content.
2146         (tui_data_window::display_all_data)
2147         (tui_data_window::refresh_all)
2148         (tui_data_window::do_scroll_vertical): Update.
2149         * tui/tui-regs.c (tui_show_registers): Update.
2150         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2151         New method.
2152
2153 2019-07-17  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2156         declare.
2157         * tui/tui-windata.c
2158         (tui_data_window::delete_data_content_windows): Rename from
2159         tui_delete_data_content_windows.
2160         (tui_data_window::display_all_data)
2161         (tui_data_window::do_scroll_vertical): Update.
2162         * tui/tui-data.h (struct tui_data_window)
2163         <delete_data_content_windows>: New method.
2164
2165 2019-07-17  Tom Tromey  <tom@tromey.com>
2166
2167         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2168         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2169
2170 2019-07-17  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2173         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2174         from tui_display_all_data.
2175         * tui/tui-win.c
2176         (tui_data_window::do_make_visible_with_new_height): Update.
2177         * tui/tui-regs.c (tui_show_registers): Update.
2178         * tui/tui-layout.c (tui_set_layout): Update.
2179         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2180         method.
2181
2182 2019-07-17  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2185         * tui/tui-windata.c (tui_display_data_from): Remove.
2186         (tui_data_window::refresh_all): Update.
2187
2188 2019-07-17  Tom Tromey  <tom@tromey.com>
2189
2190         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2191         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2192         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2193         tui_display_registers_from_line.
2194         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2195         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2196         "force_display" parameter.
2197
2198 2019-07-17  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2201         declare.
2202         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2203         Rename from tui_first_reg_element_no_inline.
2204         (tui_display_reg_element_at_line)
2205         (tui_display_registers_from_line): Update.
2206         * tui/tui-data.h (struct tui_data_window)
2207         <first_reg_element_no_inline>: New method.
2208
2209 2019-07-17  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-windata.c (tui_display_data_from)
2212         (tui_data_window::do_scroll_vertical): Update.
2213         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2214         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2215         Rename from tui_line_from_reg_element_no.
2216         (tui_display_registers_from_line): Update.
2217         * tui/tui-data.h (struct tui_data_window)
2218         <line_from_reg_element_no>: New method.
2219
2220 2019-07-17  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2223         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2224         tui_last_regs_line_no.
2225         (tui_display_reg_element_at_line)
2226         (tui_display_registers_from_line): Update.
2227         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2228         method.
2229
2230 2019-07-17  Tom Tromey  <tom@tromey.com>
2231
2232         PR tui/24722:
2233         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2234         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2235         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2236         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2237         (tui_update_breakpoint_info): Likewise.
2238         * tui/tui-hooks.c (tui_event_create_breakpoint)
2239         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2240         Update.
2241
2242 2019-07-17  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2245
2246 2019-07-17  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-winsource.c (tui_update_source_window_as_is)
2249         (tui_update_source_windows_with_addr): Update.
2250         * tui/tui-source.h (tui_set_source_content)
2251         (tui_show_symtab_source): Add "win_info" parameter.
2252         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2253         parameter.
2254         (tui_show_symtab_source): Likewise.
2255
2256 2019-07-17  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-wingeneral.c
2259         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2260
2261 2019-07-17  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2264         (struct tui_cmd_window) <can_scroll>: New method.
2265         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2266         method.
2267
2268 2019-07-17  Tom Tromey  <tromey@adacore.com>
2269
2270         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2271         do_field_signed>: Rename.  Change type of "value".
2272         * ui-out.c (ui_out::field_signed): Rename from field_int.
2273         Change type of "value".
2274         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2275         type of "value".
2276         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2277         do_field_int.  Change type of "value".
2278         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2279         do_field_int.  Change type of "value".
2280         * tracepoint.c (trace_status_mi, tfind_1)
2281         (print_one_static_tracepoint_marker): Update.
2282         * thread.c (print_thread_info_1, print_selected_thread_frame):
2283         Update.
2284         * stack.c (print_frame, print_frame_info): Update.
2285         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2286         Update.
2287         * source.c (print_source_lines_base): Update.
2288         * skip.c (info_skip_command): Update.
2289         * record-btrace.c (btrace_ui_out_decode_error)
2290         (btrace_call_history_src_line): Update.
2291         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2292         Update.
2293         * progspace.c (print_program_space): Update.
2294         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2295         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2296         do_field_int.  Change type of "value".
2297         * mi/mi-out.c (mi_ui_out::do_table_begin)
2298         (mi_ui_out::do_table_header): Update.
2299         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2300         type of "value".
2301         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2302         (mi_cmd_data_list_changed_registers, output_register)
2303         (mi_cmd_data_read_memory, mi_load_progress)
2304         (mi_cmd_trace_frame_collected): Update.
2305         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2306         Update.
2307         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2308         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2309         (mi_cmd_var_list_children, varobj_update_one): Update.
2310         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2311         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2312         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2313         * inferior.c (print_inferior): Update.
2314         * gdb_bfd.c (print_one_bfd): Update.
2315         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2316         Update.
2317         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2318         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2319         do_field_int.  Change type of "value".
2320         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2321         do_field_int.  Change type of "value".
2322         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2323         (print_one_breakpoint_location, print_it_catch_fork)
2324         (print_one_catch_fork, print_it_catch_vfork)
2325         (print_one_catch_vfork, print_it_catch_solib)
2326         (print_it_catch_exec, print_it_ranged_breakpoint)
2327         (print_mention_watchpoint, print_mention_masked_watchpoint)
2328         (bkpt_print_it, update_static_tracepoint): Update.
2329         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2330         * break-catch-syscall.c (print_it_catch_syscall): Update.
2331         * ada-tasks.c (print_ada_task_info): Update.
2332         * ada-lang.c (print_it_exception, print_mention_exception):
2333         Update.
2334
2335 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2336
2337         PR breakpoints/24541
2338         * gdbarch.c: Regenerate.
2339         * gdbarch.h: Regenerate.
2340         * gdbarch.sh: Adjust return type and parameter types for
2341         'stap_adjust_register'.
2342         (i386_stap_adjust_register): Adjust signature and return new
2343         register name.
2344         * stap-probe.c (stap_parse_register_operand): Adjust use of
2345         'gdbarch_stap_adjust_register'.
2346
2347 2019-07-17  Tom Tromey  <tromey@adacore.com>
2348
2349         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2350         declare VEC.
2351         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2352         std::vector.
2353         (struct s390_process_info): Add initializers.
2354         (s390_add_process): Use new.
2355         (s390_linux_nat_target::low_forget_process): Use delete.
2356         (s390_linux_nat_target::low_new_fork)
2357         (s390_linux_nat_target::stopped_by_watchpoint)
2358         (s390_linux_nat_target::low_prepare_to_resume)
2359         (s390_linux_nat_target::insert_watchpoint)
2360         (s390_linux_nat_target::insert_hw_breakpoint)
2361         (s390_linux_nat_target::remove_watchpoint)
2362         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2363
2364 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2365
2366         * aarch64-fbsd-nat.c: Include regcache.h.
2367         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2368         argument.
2369         (aarch64_fbsd_nat_target::fetch_registers)
2370         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2371         variable.
2372         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2373
2374 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2375
2376         * fbsd-nat.c: Include gdbarch.h.
2377
2378 2019-07-15  Tom Tromey  <tromey@adacore.com>
2379
2380         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2381
2382 2019-07-15  Tom Tromey  <tromey@adacore.com>
2383
2384         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2385         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2386         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2387         * cli-out.c (cli_ui_out::do_field_int): New method.
2388         * ui-out.c (ui_out::field_unsigned): New method.
2389         * symfile.c (generic_load): Use field_unsigned.
2390         (print_transfer_performance): Likewise.
2391         * record-btrace.c (ui_out_field_uint): Remove.
2392         (btrace_call_history_insn_range, btrace_call_history): Use
2393         field_unsigned.
2394         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2395         field_unsigned.
2396         * ui-out.h (class ui_out) <field_unsigned>: New method.
2397         <do_field_unsigned>: Likewise.
2398
2399 2019-07-15  Tom Tromey  <tromey@adacore.com>
2400
2401         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2402         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2403         * target.c (flash_erase_command): Use field_string.
2404         * infrun.c (print_signal_received_reason): Use field_string.
2405         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2406         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2407         field_string.
2408         * ada-tasks.c (print_ada_task_info): Use field_string.
2409
2410 2019-07-15  Tom Tromey  <tromey@adacore.com>
2411
2412         * target.c (flash_erase_command): Use field_core_addr.
2413         * symfile.c (generic_load): Use field_core_addr.
2414         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2415         Use field_core_addr.
2416         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2417         field_core_addr.
2418
2419 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2420
2421         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2422         value if its desired type is smaller than a CORE_ADDR and signed.
2423
2424 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2425
2426         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2427         of changes to field names, and use new is_reference field to
2428         decide if a property is a reference or not.
2429         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2430         field.
2431         (struct dwarf2_property_baton): Update header comment, rename
2432         'referenced_type' to 'property_type' and update comments.
2433         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2434         default property type, store in property baton, update to take
2435         accound of renamed field.
2436         (read_func_scope): Update call to attr_to_dynamic_prop.
2437         (read_array_type): Likewise.
2438         (dwarf2_per_cu_addr_sized_int_type): New function.
2439         (read_subrange_index_type): Move type finding code to
2440         dwarf2_per_cu_addr_sized_int_type.
2441         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2442         (dwarf2_per_cu_addr_type): New function.
2443         (set_die_type): Update calls to attr_to_dynamic_prop.
2444
2445 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2446
2447         * dwarf2read.c (read_subrange_index_type): New function.
2448         (read_subrange_type): Move code into new function and call it.
2449         * gdbtypes.c (create_range_type): Add some asserts.
2450
2451 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2452
2453         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2454         update return statements.
2455         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2456         declaration, and update comment to match.
2457         * gdbtypes.c (resolve_dynamic_array): Update call to
2458         dwarf2_evaluate_property to match new return type.
2459
2460 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2461
2462         * valarith.c (value_subscripted_rvalue): Change lowerbound
2463         parameter type from int to LONGEST.
2464         * value.h (value_subscripted_rvalue): Likewise in declaration.
2465
2466 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2467
2468         * cli/cli-utils.c (info_print_command_completer): New function.
2469         * cli/cli-utils.h: Add 'completer.h' include, and forward
2470         declaration for 'struct cmd_list_element'.
2471         (info_print_command_completer): Declare.
2472         * stack.c (_initialize_stack): Add completer for 'info locals' and
2473         'info args'.
2474         * symtab.c (_initialize_symtab): Add completer for 'info
2475         variables' and 'info functions'.
2476         * NEWS: Mention completion for additional info commands.
2477
2478 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2479
2480         * cli/cli-utils.c (extract_info_print_args): Delete.
2481         (extract_arg_maybe_quoted): Delete.
2482         (info_print_options_defs): New variable.
2483         (make_info_print_options_def_group): New function.
2484         (extract_info_print_options): Define new function.
2485         * cli/cli-utils.h (extract_info_print_args): Delete.
2486         (struct info_print_options): New structure.
2487         (extract_info_print_options): Declare new function.
2488         * stack.c (info_locals_command): Update to use new
2489         extract_info_print_options, also add a header comment.
2490         (info_args_command): Likewise.
2491         * symtab.c (info_variables_command): Likewise.
2492         (info_functions_command): Likewise.
2493
2494 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2495
2496         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2497         to extract string arguments.
2498         * common/common-utils.c (extract_string_maybe_quoted): New function.
2499         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2500
2501 2019-07-11  Tom Tromey  <tromey@adacore.com>
2502
2503         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2504         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2505         * top.h (gdbinit): Don't declare.
2506         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2507         into...
2508         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2509         * top.c (gdb_init): Don't call init_cli_cmds.
2510         (gdbinit): Remove.
2511         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2512
2513 2019-07-11  Tom Tromey  <tromey@adacore.com>
2514
2515         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2516         after it has been moved.
2517
2518 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2519
2520         * valops.c (value_must_coerce_to_target): Change return type to
2521         bool.
2522         * value.h (value_must_coerce_to_target): Likewise.
2523
2524 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2525
2526         * breakpoint.c (is_hardware_watchpoint): Remove
2527         forward-declaration.
2528         (is_masked_watchpoint): Change return type to bool.
2529         (is_tracepoint): Likewise.
2530         (is_breakpoint): Likewise.
2531         (is_hardware_watchpoint): Likewise.
2532         (is_watchpoint): Likewise.
2533         (is_no_memory_software_watchpoint): Likewise.
2534         (is_catchpoint): Likewise.
2535         (breakpoint_1): Make FILTER parameter's return type bool.
2536         is_masked_watchpoint): Change return type to bool.
2537         (save_breakpoints): Make FILTER parameter's return type bool.
2538         * breakpoint.h (is_breakpoint): Change return type to bool.
2539         (is_watchpoint): Likewise.
2540         (is_catchpoint): Likewise.
2541         (is_tracepoint): Likewise.
2542
2543 2019-07-10  Tom Tromey  <tom@tromey.com>
2544
2545         * defs.h: Don't include gdbarch.h.
2546         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2547         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2548         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2549         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2550         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2551         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2552         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2553         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2554         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2555         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2556         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2557         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2558         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2559         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2560         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2561         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2562         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2563         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2564         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2565         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2566         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2567         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2568         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2569         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2570         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2571         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2572         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2573
2574 2019-07-10  Tom Tromey  <tromey@adacore.com>
2575
2576         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2577         * breakpoint.c (init_ada_exception_breakpoint): Register as
2578         bp_catchpoint.
2579         (print_one_breakpoint_location, print_one_breakpoint): Use
2580         is_ada_exception_catchpoint.
2581         * ada-lang.c (class ada_catchpoint_location): Pass
2582         bp_loc_software_breakpoint to bp_location constructor.
2583         (is_ada_exception_catchpoint): New function.
2584
2585 2019-07-10  Tom Tromey  <tromey@adacore.com>
2586
2587         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2588         VEC.
2589         (struct arm_exidx_entry): New method operator<.
2590         (struct arm_exidx_data) <section_maps>: Change type.
2591         (arm_exidx_data_free): Remove.
2592         (arm_exidx_data_key): Change type.  Move lower.
2593         (arm_exidx_new_objfile): Update.
2594         (arm_compare_exidx_entries): Remove.
2595         (arm_find_exidx_entry, _initialize_arm_tdep)
2596
2597 2019-07-10  Tom Tromey  <tromey@adacore.com>
2598
2599         * solib-spu.c (ocl_program_data_key): Change type.
2600         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2601         Update.
2602
2603 2019-07-10  Tom Tromey  <tromey@adacore.com>
2604
2605         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2606         (struct solib_aix_inferior_data) <library_list>: Change type.
2607         (solib_aix_inferior_data_handle): Change type.
2608         (get_solib_aix_inferior_data): Update.
2609         (solib_aix_free_library_list): Remove.
2610         (library_list_start_library): Update.
2611         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2612         return type.
2613         (solib_aix_get_library_list)
2614         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2615         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2616
2617 2019-07-10  Tom Tromey  <tromey@adacore.com>
2618
2619         * solib-dsbt.c (struct dsbt_info): Add initializers.
2620         (solib_dsbt_pspace_data): Change type.
2621         (dsbt_pspace_data_cleanup): Remove.
2622         (get_dsbt_info, _initialize_dsbt_solib): Update.
2623
2624 2019-07-10  Tom Tromey  <tromey@adacore.com>
2625
2626         * spu-tdep.c (spu_overlay_data): Change type.
2627         (spu_get_overlay_table, spu_overlay_new_objfile)
2628         (_initialize_spu_tdep): Update.
2629
2630 2019-07-10  Tom Tromey  <tromey@adacore.com>
2631
2632         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2633         destructor.
2634         (dbx_objfile_data_key): Change type and declare later.
2635         (DBX_SYMFILE_INFO): Rewrite.
2636         * dbxread.c (dbx_objfile_data_key): Change type.
2637         (dbx_symfile_init): Update.
2638         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2639         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2640         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2641
2642 2019-07-10  Tom Tromey  <tromey@adacore.com>
2643
2644         * jit.c (jit_program_space_key): Change type.  Move lower.
2645         (get_jit_program_space_data): Update.
2646         (jit_program_space_data_cleanup): Remove.
2647         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2648         Update.
2649         (struct jit_program_space_data): Add initializers.
2650
2651 2019-07-10  Tom Tromey  <tromey@adacore.com>
2652
2653         * solib-darwin.c (struct darwin_info): Add initializers.
2654         (solib_darwin_pspace_data): Change type.
2655         (darwin_pspace_data_cleanup): Remove.
2656         (get_darwin_info, _initialize_darwin_solib): Update.
2657
2658 2019-07-10  Tom Tromey  <tromey@adacore.com>
2659
2660         * remote-sim.c (struct sim_inferior_data): Add initializers,
2661         constructor, and destructor.
2662         (sim_inferior_data_key): Change type.  Move lower.
2663         (check_for_duplicate_sim_descriptor): Update.
2664         (get_sim_inferior_data): Use new.  Update.
2665         (~sim_inferior_data_cleanup): Rename from
2666         sim_inferior_data_cleanup.  Simplify.
2667         (gdbsim_close_inferior, simulator_command)
2668         (sim_command_completer, _initialize_remote_sim): Update.
2669         (next_pid, INITIAL_PID): Move earlier.
2670
2671 2019-07-10  Tom Tromey  <tromey@adacore.com>
2672
2673         * python/python-internal.h (create_thread_object): Return
2674         gdbpy_ref.
2675         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2676         * python/py-inferior.c (struct threadlist_entry): Add
2677         constructor.
2678         <thread_obj>: Now a gdbpy_ref.
2679         (thread_to_thread_object): Update.
2680         (add_thread_object): Use new.
2681         (delete_thread_object): Use delete.
2682         (infpy_threads): Update.
2683         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2684         GIL.
2685
2686 2019-07-10  Tom Tromey  <tromey@adacore.com>
2687
2688         * valops.c (value_cast): Specialize error message for Ada.
2689
2690 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2691
2692         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2693
2694 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2695
2696         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2697         bpstat_should_step): Return bool, adjust comments.
2698         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2699         bpstat_should_step): Likewise.
2700
2701 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2702
2703         * features/Makefile: Use feature target descriptions for Arm.
2704         * features/arm/arm-core.c: Generate new file.
2705         * features/arm/arm-fpa.c: Likewise.
2706         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2707         * features/arm/arm-m-profile.c: Likewise.
2708         * features/arm/arm-vfpv2.c: Likewise.
2709         * features/arm/arm-vfpv3.c: Likewise.
2710         * features/arm/xscale-iwmmxt.c: Likewise.
2711         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2712
2713 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2714
2715         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2716         ptrace earlier.
2717
2718 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2719
2720         * features/aarch64-pauth.c: Regenerate.
2721
2722 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2723
2724         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2725         bool.
2726         (bpstat_what): Use false instead of 0.
2727
2728 2019-07-09  Pedro Alves  <palves@redhat.com>
2729
2730         * break-catch-throw.c (is_exception_catchpoint): New.
2731         * breakpoint.c (print_one_breakpoint_location): New parameter
2732         'raw_loc'.  Handle it.  Use
2733         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2734         looking at the breakpoint's type.
2735         (print_one_breakpoint): If handling "maint info breakpoints", also
2736         print locations of exception catchpoints.
2737         * breakpoint.h (is_exception_catchpoint): Declare.
2738
2739 2019-07-09  Pedro Alves  <palves@redhat.com>
2740
2741         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2742         "addr" field.
2743         (allocate_location_exception_catchpoint): New.
2744         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2745         (initialize_throw_catchpoint_ops): Install
2746         allocate_location_exception_catchpoint as allocate_location
2747         method.
2748         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2749         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2750         bp_loc_other.
2751         (breakpoint_address_is_meaningful): Delete.
2752         (bl_address_is_meaningful): New.
2753         (breakpoint_locations_match): Adjust comment.
2754         (bp_location_from_bp_type): New, factored out of...
2755         (bp_location::bp_location(breakpoint *)): ... this.
2756         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2757         factored out of...
2758         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2759         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2760         breakpoint_address_is_meaningful.
2761         (bp_locations_compare): Adjust comment.
2762         (update_global_location_list): Use bl_address_is_meaningful
2763         instead of breakpoint_address_is_meaningful.
2764         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2765         explicit.
2766         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2767         * python/py-breakpoint.c (bppy_get_location): No longer check
2768         whether location is null.
2769
2770 2019-07-09  Pedro Alves  <palves@redhat.com>
2771
2772         PR c++/15468
2773         * breakpoint.c (print_one_breakpoint_location): Remove
2774         single-location assert.
2775
2776 2019-07-09  Tom Tromey  <tom@tromey.com>
2777
2778         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2779         * configure: Rebuild.
2780         * configure.ac: Change common to gdbsupport.
2781         * gdbsupport: Rename from common.
2782         * acinclude.m4: Change common to gdbsupport.
2783         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2784         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2785         gdbsupport.
2786         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2787         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2788         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2789         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2790         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2791         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2792         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2793         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2794         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2795         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2796         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2797         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2798         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2799         coff-pe-read.c, command.h, compile/compile-c-support.c,
2800         compile/compile-c.h, compile/compile-cplus-symbols.c,
2801         compile/compile-cplus-types.c, compile/compile-cplus.h,
2802         compile/compile-loc2c.c, compile/compile.c, completer.c,
2803         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2804         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2805         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2806         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2807         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2808         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2809         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2810         features/aarch64-core.c, features/aarch64-fpu.c,
2811         features/aarch64-pauth.c, features/aarch64-sve.c,
2812         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2813         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2814         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2815         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2816         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2817         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2818         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2819         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2820         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2821         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2822         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2823         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2824         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2825         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2826         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2827         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2828         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2829         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2830         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2831         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2832         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2833         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2834         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2835         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2836         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2837         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2838         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2839         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2840         minsyms.c, mips-linux-tdep.c, namespace.h,
2841         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2842         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2843         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2844         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2845         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2846         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2847         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2848         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2849         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2850         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2851         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2852         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2853         procfs.c, producer.c, progspace.h, psymtab.h,
2854         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2855         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2856         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2857         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2858         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2859         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2860         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2861         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2862         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2863         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2864         target-memory.c, target.c, target.h, target/waitstatus.c,
2865         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2866         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2867         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2868         unittests/array-view-selftests.c,
2869         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2870         unittests/common-utils-selftests.c,
2871         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2872         unittests/format_pieces-selftests.c,
2873         unittests/function-view-selftests.c,
2874         unittests/lookup_name_info-selftests.c,
2875         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2876         unittests/mkdir-recursive-selftests.c,
2877         unittests/observable-selftests.c,
2878         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2879         unittests/parse-connection-spec-selftests.c,
2880         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2881         unittests/scoped_fd-selftests.c,
2882         unittests/scoped_mmap-selftests.c,
2883         unittests/scoped_restore-selftests.c,
2884         unittests/string_view-selftests.c, unittests/style-selftests.c,
2885         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2886         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2887         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2888         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2889         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2890         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2891
2892 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2893
2894         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2895         bool value.
2896         (decode_digits_ordinary): Set explicit_line field in sal.
2897         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2898         symtab_and_line that was set on an explicit line number in
2899         assembler code.  Do always update the recorded symtab and line if
2900         we do skip the prologue.
2901
2902 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2903
2904         * breakpoint.c (set_breakpoint_location_function): Remove
2905         explicit_loc parameter.
2906         (momentary_breakpoint_from_master): Update call to
2907         set_breakpoint_location_function.
2908         (add_location_to_breakpoint): Likewise.
2909
2910 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2911
2912         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2913         required features based on default bfd type when no specific bfd
2914         is present.
2915
2916 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2917
2918         * NEWS: Mention that GDB printf and eval commands can now print
2919         C-style and Ada-style convenience var strings without
2920         calling the inferior.
2921         * printcmd.c (printf_c_string): Locally print GDB internal var
2922         instead of transiting via the inferior.
2923         (printf_wide_c_string): Likewise.
2924
2925 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2926
2927         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2928
2929 2019-07-04  Tom Tromey  <tom@tromey.com>
2930
2931         PR tui/24724:
2932         * tui/tui-winsource.c (tui_clear_source_content): Update.
2933         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2934         (tui_update_breakpoint_info): Update.
2935         (tui_set_exec_info_content): Update.
2936         * tui/tui-source.c (tui_set_source_content_nil): Update.
2937         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2938         has_break.
2939         * tui/tui-data.h (enum tui_bp_flag): New.
2940         (tui_bp_flags): New enum flags type.
2941         (struct tui_source_element) <break_mode>: Change type.  Rename
2942         from has_break.
2943         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2944         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2945         constants.
2946         * tui/tui-winsource.h: Fix comment.
2947
2948 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2949
2950         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2951         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2952         (store_fpregs_to_thread)
2953         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2954         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2955         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2956         (IWMMXT_REGS_SIZE): Add define.
2957         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2958         (fetch_vfp_regs, store_vfp_regs)
2959         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2960         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2961
2962 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2963
2964         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2965         defines.
2966         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2967         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2968         (ARM_INT_REGISTER_SIZE): ...to this.
2969         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2970         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2971         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2972         (arm_linux_collect_gregset, supply_nwfpe_register)
2973         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2974         defines.
2975         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2976         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2977         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2978         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2979         (arm_return_in_memory, arm_store_return_value)
2980         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2981         (arm_record_ld_st_multiple): Likewise.
2982         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2983         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2984
2985 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2986
2987         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2988         AARCH64_DISPLACED_MODIFIED_INSNS.
2989         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2990         (aarch64_displaced_step_copy_insn): Likewise.
2991         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2992         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2993         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2994         ARM_DISPLACED_MODIFIED_INSNS.
2995         * arm-tdep.c (arm_gdbarch_init): Likewise.
2996         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2997         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2998         (struct arm_displaced_step_closure): Use
2999         ARM_DISPLACED_MODIFIED_INSNS.
3000
3001 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3002
3003         * features/Makefile: Remove unused xml files.
3004         * features/aarch64.xml: Remove.
3005         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3006         * features/i386/amd64-avx-avx512.xml: Remove.
3007         * features/i386/amd64-avx-linux.xml: Remove.
3008         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3009         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3010         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3011         * features/i386/amd64-avx-mpx.xml: Remove.
3012         * features/i386/amd64-avx.xml: Remove.
3013         * features/i386/amd64-linux.xml: Remove.
3014         * features/i386/amd64-mpx-linux.xml: Remove.
3015         * features/i386/amd64-mpx.xml: Remove.
3016         * features/i386/amd64.xml: Remove.
3017         * features/i386/i386-avx-avx512-linux.xml: Remove.
3018         * features/i386/i386-avx-avx512.xml: Remove.
3019         * features/i386/i386-avx-linux.xml: Remove.
3020         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3021         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3022         * features/i386/i386-avx-mpx-linux.xml: Remove.
3023         * features/i386/i386-avx-mpx.xml: Remove.
3024         * features/i386/i386-avx.xml: Remove.
3025         * features/i386/i386-linux.xml: Remove.
3026         * features/i386/i386-mmx-linux.xml: Remove.
3027         * features/i386/i386-mmx.xml: Remove.
3028         * features/i386/i386-mpx-linux.xml: Remove.
3029         * features/i386/i386-mpx.xml: Remove.
3030         * features/i386/i386.xml: Remove.
3031         * features/i386/x32-avx-avx512-linux.xml: Remove.
3032         * features/i386/x32-avx-linux.xml: Remove.
3033         * features/i386/x32-linux.xml: Remove.
3034
3035 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3036
3037         * regformats/aarch64.dat: Remove.
3038         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3039         * regformats/i386/amd64-avx-linux.dat: Remove.
3040         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3041         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3042         * regformats/i386/amd64-linux.dat: Remove.
3043         * regformats/i386/amd64-mpx-linux.dat: Remove.
3044         * regformats/i386/amd64.dat: Remove.
3045         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3046         * regformats/i386/i386-avx-linux.dat: Remove.
3047         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3048         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3049         * regformats/i386/i386-linux.dat: Remove.
3050         * regformats/i386/i386-mmx-linux.dat: Remove.
3051         * regformats/i386/i386-mpx-linux.dat: Remove.
3052         * regformats/i386/i386.dat: Remove.
3053         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3054         * regformats/i386/x32-avx-linux.dat: Remove.
3055         * regformats/i386/x32-linux.dat: Remove.
3056
3057 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3058
3059         * aarch64-tdep.c: Remove xml self tests.
3060         * amd64-linux-tdep.c: Likewise.
3061         * amd64-tdep.c: Likewise.
3062         * i386-linux-tdep.c: Likewise.
3063         * i386-tdep.c: Likewise.
3064
3065 2019-07-03  Pedro Alves  <palves@redhat.com>
3066
3067         PR cli/24732
3068         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3069         (pipe_cmd_option_defs): New.
3070         (make_pipe_cmd_options_def_group): New.
3071         (pipe_command): Use gdb::option::process_options.
3072         (pipe_command_completer): New function.
3073         (_initialize_cli_cmds): Install completer for "pipe" command.
3074
3075 2019-07-03  Pedro Alves  <palves@redhat.com>
3076
3077         * cli/cli-option.c (union option_value) <string>: New field.
3078         (struct option_def_and_value): Add ctor, move ctor, dtor and
3079         use DISABLE_COPY_AND_ASSIGN.
3080         (option_def_and_value::clear_value): New.
3081         (parse_option, save_option_value_in_ctx, get_val_type_str)
3082         (add_setshow_cmds_for_options): Handle var_string.
3083         * cli-option.h (union option_def::var_address) <string>: New
3084         field.
3085         (struct string_option_def): New.
3086         * maint-test-options.c (struct test_options_opts): Add default
3087         ctor and use DISABLE_COPY_AND_ASSIGN.
3088         <string_opt>: New field.
3089         (test_options_opts::~test_options_opts): New.
3090         (test_options_opts::dump): Also dump "-string".
3091         (test_options_option_defs): Install "string.
3092
3093 2019-07-03  Pedro Alves  <palves@redhat.com>
3094
3095         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3096         option_value with a null enumeration.
3097         (complete_options): Save the option values in the context.
3098         (save_option_value_in_ctx): New, factored out from ...
3099         (process_options): ... here.
3100         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3101         of the function.
3102         * maint-test-options.c (test_options_opts::dump): New, factored
3103         out from ...
3104         (maintenance_test_options_command_mode): ... here.
3105         (maintenance_test_options_command_completion_result): Delete.
3106         (maintenance_test_options_command_completion_text): Update
3107         comment.
3108         (maintenance_show_test_options_completion_result): Change
3109         prototype.  Just print
3110         maintenance_test_options_command_completion_text.
3111         (save_completion_result): New.
3112         (maintenance_test_options_completer_mode): Pass options context to
3113         complete_options, and then save a dump.
3114         (_initialize_maint_test_options): Use add_cmd to install "maint
3115         show test-options-completion-result".
3116
3117 2019-07-03  Pedro Alves  <palves@redhat.com>
3118
3119         * NEWS (New commands): Mention "with" and "maint with".
3120         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3121         (with_command, with_command_completer): New.
3122         (pipe_command): Adjust to new repeat_previous
3123         interface.
3124         (_initialize_cli_cmds): Install the "with" command and its "w"
3125         alias.
3126         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3127         declarations.
3128         * cli/cli-setshow.c (parse_cli_var_uinteger)
3129         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3130         argument strings for all var_types.
3131         (get_setshow_command_value_string): New, factored out from ...
3132         (do_show_command): ... this.
3133         * cli/cli-setshow.h: Include <string>.
3134         (get_setshow_command_value_string): Declare.
3135         * command.h (repeat_previous): Now returns const char *.  Adjust
3136         comment.
3137         * maint.c: Include "cli/cli-cmds.h".
3138         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3139         (_initialize_maint_cmds): Register the "maintenance with" command.
3140         * top.c (repeat_previous): Move bits from pipe_command here:
3141         Return the saved command line, if any; error out if there's no
3142         command to relaunch.
3143
3144 2019-07-03  Pedro Alves  <palves@redhat.com>
3145
3146         * NEWS (New commands): Mention "maint set/show test-settings"
3147         instead of "maint test-settings".
3148         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3149         (maintenance_test_settings_set_list): Rename to ...
3150         (maintenance_set_test_settings_list): ... this.
3151         (maintenance_test_settings_show_list): Rename to  ...
3152         (maintenance_show_test_settings_list): ... this.
3153         (maintenance_test_settings_cmd): Delete.
3154         (maintenance_test_settings_set_cmd): ...
3155         (maintenance_set_test_settings_cmd): ... this.
3156         (maintenance_test_settings_show_cmd): ...
3157         (maintenance_show_test_settings_cmd): ... this.
3158         (maintenance_test_settings_show_value_cmd):
3159         (maintenance_show_test_settings_value_cmd): ... this.
3160         (_initialize_maint_test_settings): No longer install the "maint
3161         test-settings" prefix command.  Rename "maint test-settings set"
3162         to "maint set test-settings", and "maint test-settings show" to
3163         "maint show test-settings".  Adjust all subcommands.
3164
3165 2019-07-03  Pedro Alves  <palves@redhat.com>
3166
3167         * maint-test-settings.c: Fix file's intro comment.  Replace all
3168         references to "test-options" with references to "test-settings",
3169         in comments.
3170
3171 2019-07-03  Pedro Alves  <palves@redhat.com>
3172
3173         * maint-test-settings.c (maintenance_test_settings_xxx)
3174         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3175         New.
3176         (maintenance_test_settings_enums): Use them.
3177         (maintenance_test_settings_enum): Default to
3178         maintenance_test_settings_xxx.
3179         (_initialize_maint_test_settings): Initialize
3180         MAINTENANCE_TEST_SETTINGS_FILENAME.
3181
3182 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3183
3184         * breakpoint.h (remove_breakpoints_inf): Change return type to
3185         void, move function documentation here.
3186         * breakpoint.c (remove_breakpoints_inf): Change return type to
3187         void, move function documentation to header.
3188
3189 2019-07-02  Pedro Alves  <palves@redhat.com>
3190
3191         * NEWS (Completion improvements): Mention "info threads".
3192         * thread.c (struct info_threads_opts, info_threads_option_defs)
3193         (make_info_threads_options_def_group): New.
3194         (info_threads_command): Use gdb::option::process_options.
3195         (info_threads_command_completer): New.
3196         (_initialize_thread): Use gdb::option::build_help to build the
3197         help text for "info threads".
3198
3199 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3200
3201         * defs.h (generic_load): Move from here...
3202         * symfile.h (generic_load): ... to here.  Rename name parameter
3203         to args.
3204         * symfile.c (generic_load): Add comment.
3205
3206 2019-07-01  Tom Tromey  <tromey@adacore.com>
3207
3208         * dwarf2read.c
3209         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3210         declaration of without_params.  Fix formatting.
3211
3212 2019-07-01  Tom Tromey  <tromey@adacore.com>
3213
3214         * ada-exp.y (find_primitive_type): Update.
3215         * ada-lang.h (ada_lookup_symbol): Update.
3216         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3217         parameter.
3218         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3219
3220 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3221
3222         PR breakpoints/24541
3223         * gdbarch.c: Regenerate.
3224         * gdbarch.h: Regenerate.
3225         * gdbarch.sh: Add 'stap_adjust_register'.
3226         * i386-tdep.c: Include '<unordered_set>'.
3227         (i386_stap_adjust_register): New function.
3228         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3229         * stap-probe.c (stap_parse_register_operand): Call
3230         'gdbarch_stap_adjust_register'.
3231
3232 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3233
3234         PR python/24742
3235         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3236         * python/python.c (do_start_initialization): Use 'xmalloc'
3237         instead of 'PyMem_Malloc'.
3238
3239 2019-06-28  Tom Tromey  <tromey@adacore.com>
3240
3241         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3242         for Ada.
3243
3244 2019-06-27  Tom Tromey  <tromey@adacore.com>
3245
3246         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3247         objfile_key.
3248         (arm_find_mapping_symbol, arm_record_special_symbol)
3249         (_initialize_arm_tdep): Update.
3250         (arm_objfile_data_free): Remove.
3251
3252 2019-06-27  Tom Tromey  <tromey@adacore.com>
3253
3254         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3255         to cp_print_static_field.
3256
3257 2019-06-26  Tom Tromey  <tromey@adacore.com>
3258
3259         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3260         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3261         declare.
3262
3263 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3264
3265         * features/aarch64-core.c (create_feature_aarch64_core):
3266         Regenerate.
3267         * features/aarch64-core.xml: Add cpsr flags.
3268
3269 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3270
3271         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3272         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3273
3274 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3275
3276         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3277         field.
3278         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3279         use.
3280         (arm_record_special_symbol): Don't insert new symbol in sorted
3281         position, push it at the end.
3282
3283 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3284
3285         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3286         (arm_mapping_symbol_s): Remove.
3287         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3288         (arm_mapping_symbol_vec): New typedef.
3289         (struct arm_per_objfile): Add constructor.
3290         <section_maps>: Change type to
3291         std::unique_ptr<arm_mapping_symbol_vec[]>.
3292         (arm_compare_mapping_symbols): Remove.
3293         (arm_find_mapping_symbol): Adjust to section_maps type change.
3294         (arm_objfile_data_free): Call delete on arm_per_objfile.
3295         (arm_record_special_symbol): Adjust to section_maps type change.
3296         Allocate arm_per_objfile with new.
3297
3298 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3299
3300         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3301         with the command prefix.
3302
3303 2019-06-25  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3306         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3307
3308 2019-06-25  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3311         type.
3312         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3313         protected.
3314
3315 2019-06-25  Tom Tromey  <tom@tromey.com>
3316
3317         * tui/tui-winsource.c
3318         (tui_source_window_base::set_is_exec_point_at): Add check against
3319         LOA_ADDRESS.
3320
3321 2019-06-25  Tom Tromey  <tom@tromey.com>
3322
3323         * tui/tui-source.c (tui_set_source_content): Don't check before
3324         xfree.
3325         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-winsource.h (tui_update_source_window_as_is)
3330         (tui_alloc_source_buffer, tui_line_is_displayed)
3331         (tui_addr_is_displayed): Change type of win_info.
3332         * tui/tui-winsource.c (tui_update_source_window_as_is)
3333         (tui_clear_source_content, tui_show_source_line)
3334         (tui_show_source_content, tui_source_window_base::refill)
3335         (tui_source_window_base::set_is_exec_point_at)
3336         (tui_source_window_base::set_is_exec_point_at)
3337         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3338         (tui_alloc_source_buffer, tui_line_is_displayed)
3339         (tui_addr_is_displayed): Change type of win_info.  Update.
3340         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3341         (tui_source_window_base::do_make_visible_with_new_height):
3342         Update.
3343         * tui/tui-source.c (tui_set_source_content)
3344         (tui_set_source_content_nil)
3345         (tui_source_window::do_scroll_vertical): Update.
3346         * tui/tui-layout.c (show_layout): Update.
3347         * tui/tui-disasm.c (tui_set_disassem_content)
3348         (tui_disasm_window::do_scroll_vertical): Update.
3349         * tui/tui-data.h (tui_win_content): Remove.
3350         (struct tui_gen_win_info) <content, content_size>: Remove.
3351         (struct tui_source_element): Add initializers and destructor.
3352         (union tui_which_element, struct tui_win_element): Remove.
3353         (struct tui_source_window_base) <content>: New field.
3354         (struct tui_data_window): Remove destructor.
3355         (tui_alloc_content, tui_free_win_content)
3356         (tui_free_all_source_wins_content): Don't declare.
3357         * tui/tui-data.c (tui_initialize_static_data): Update.
3358         (init_content_element, tui_alloc_content): Remove.
3359         (~tui_gen_win_info): Update.
3360         (~tui_data_window, tui_free_all_source_wins_content)
3361         (tui_free_win_content, free_content, free_content_elements):
3362         Remove.
3363
3364 2019-06-25  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-winsource.h (tui_clear_source_content)
3367         (tui_erase_source_content, tui_show_source_content): Change type
3368         of win_info.
3369         * tui/tui-winsource.c (tui_clear_source_content)
3370         (tui_erase_source_content, tui_show_source_content): Change type
3371         of win_info.
3372         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3373         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3374         win_info.
3375         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3376         win_info.
3377         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3378
3379 2019-06-25  Tom Tromey  <tom@tromey.com>
3380
3381         * tui/tui-winsource.c (tui_clear_source_content)
3382         (tui_source_window_base::set_is_exec_point_at): Update.
3383         * tui/tui-source.c (tui_set_source_content_nil): Update.
3384         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3385         a bool.
3386         * tui/tui-data.c (init_content_element): Update.
3387
3388 2019-06-25  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3391         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3392         * tui/tui-layout.c (init_and_make_win): Update.
3393         * tui/tui.h (enum tui_win_type): Update.
3394         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3395         tui_win_is_auxillary.
3396         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3397         tui_win_is_auxillary.
3398
3399 2019-06-25  Tom Tromey  <tom@tromey.com>
3400
3401         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3402         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3403         (tui_delete_data_content_windows, tui_display_all_data)
3404         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3405         Update.
3406         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3407         * tui/tui-regs.c (tui_last_regs_line_no)
3408         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3409         (tui_show_registers): Update.
3410         (tui_show_register_group): Return void.  Update.
3411         (tui_display_registers_from, tui_display_reg_element_at_line)
3412         (tui_display_registers_from_line, tui_check_register_values):
3413         Update.
3414         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3415         member.
3416         (struct tui_data_window) <regs_content>: Now a std::vector.
3417         <regs_content_count>: Remove.
3418         (tui_add_content_elements, tui_free_data_content): Don't declare.
3419         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3420         (init_content_element): Remove DATA_WIN case.  Add assert.
3421         (tui_add_content_elements): Remove.
3422         (tui_data_window): Update.
3423         (tui_free_data_content): Remove.
3424         (free_content_elements): Remove DATA_WIN case.
3425
3426 2019-06-25  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-data.c (tui_data_item_window): Update.
3429         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3430         * tui/tui-windata.c (tui_display_all_data)
3431         (tui_display_data_from_line): Update.
3432         (tui_check_data_values): Remove.
3433         * tui/tui-regs.c (tui_show_register_group)
3434         (tui_display_reg_element_at_line): Update.
3435         * tui/tui-hooks.c (tui_register_changed)
3436         (tui_refresh_frame_and_register_information): Call
3437         tui_check_register_values.
3438         * tui/tui-data.h (struct tui_data_window) <data_content,
3439         data_content_count, data_type>: Remove.
3440         (enum tui_data_type): Remove.
3441
3442         * tui/tui-data.c (tui_data_window::clear_detail)
3443         (~tui_data_window): Update.
3444
3445 2019-06-25  Tom Tromey  <tom@tromey.com>
3446
3447         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3448         declare.
3449         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3450         Rename from tui_first_data_item_displayed.  Update.
3451         (tui_data_window::refresh_all)
3452         (tui_data_window::do_scroll_vertical): Update.
3453         * tui/tui-data.h (struct tui_data_window)
3454         <first_data_item_displayed>: Declare new method.
3455
3456 2019-06-25  Tom Tromey  <tom@tromey.com>
3457
3458         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3459         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3460         contents...
3461         (tui_initialize_static_data): ...here.
3462
3463 2019-06-25  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3466         (tui_display_registers_from, tui_check_register_values): Update.
3467         (tui_display_register): Remove win_info parameter; update.
3468         (tui_get_register): Change type of parameters.
3469         * tui/tui-data.h (struct tui_data_element): Remove.
3470         (union tui_which_element) <data>: Remove.
3471         <data_window>: Change type.
3472         (struct tui_data_item_window): New.
3473         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3474         case.  Add assert.
3475         (~tui_data_item_window): New destructor.
3476         (free_content_elements): Remove DATA_ITEM_WIN case.
3477
3478 2019-06-25  Tom Tromey  <tom@tromey.com>
3479
3480         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3481         Remove.
3482
3483 2019-06-25  Tom Tromey  <tom@tromey.com>
3484
3485         * tui/tui-data.h (struct tui_command_element): Remove.
3486         (union tui_which_element) <command>: Remove.
3487         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3488         assert.
3489         (free_content_elements): Remove CMD_WIN case.
3490
3491 2019-06-25  Tom Tromey  <tom@tromey.com>
3492
3493         * tui/tui-layout.c (tui_set_layout): Update.
3494         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3495         * tui/tui-data.c (layout_def): Update.
3496
3497 2019-06-25  Tom Tromey  <tom@tromey.com>
3498
3499         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3500         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3501         (tui_source_window_base::set_new_height): Update.
3502         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3503         Update.
3504         (tui_set_locator_fullname, tui_set_locator_info)
3505         (tui_show_frame_info): Update.
3506         * tui/tui-source.c (tui_set_source_content)
3507         (tui_source_is_displayed): Update.
3508         * tui/tui-layout.c (show_source_disasm_command, show_data)
3509         (show_source_or_disasm_and_command): Update.
3510         * tui/tui-disasm.c (tui_set_disassem_content)
3511         (tui_get_begin_asm_address): Update.
3512         * tui/tui-data.h (struct tui_locator_element): Remove.
3513         (union tui_which_element) <locator>: Remove.
3514         (struct tui_locator_window): New.
3515         (tui_locator_win_info_ptr): Change return type.
3516         * tui/tui-data.c (_locator): Change type.
3517         (tui_locator_win_info_ptr): Change return type.
3518         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3519         (tui_alloc_content): Add assert.
3520
3521 2019-06-25  Tom Tromey  <tom@tromey.com>
3522
3523         * tui/tui-winsource.c
3524         (tui_exec_info_window::maybe_allocate_content): New method.
3525         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3526         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3527         (make_source_or_disasm_window): Add cast.
3528         * tui/tui-data.h (union tui_which_element) <simple_string>:
3529         Remove.
3530         (struct tui_source_info): New.
3531         (struct tui_source_window_base) <execution_info>: Change type.
3532         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3533         case, and add assert.
3534         (tui_alloc_content): Add assert.
3535
3536 2019-06-25  Tom Tromey  <tom@tromey.com>
3537
3538         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3539         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3540         * tui/tui-data.c (tui_alloc_win_info): Remove.
3541
3542 2019-06-25  Tom Tromey  <tom@tromey.com>
3543
3544         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3545         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3546         can_highlight.
3547
3548 2019-06-25  Tom Tromey  <tom@tromey.com>
3549
3550         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3551         make_visible_with_new_height method.
3552         (tui_win_info::make_visible_with_new_height): New method.
3553         (tui_source_window_base::do_make_visible_with_new_height)
3554         (tui_data_window::do_make_visible_with_new_height)
3555         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3556         (make_visible_with_new_height): Remove.
3557         (tui_resize_all, tui_adjust_win_heights): Use
3558         make_visible_with_new_height method.
3559         * tui/tui-data.h (struct tui_win_info)
3560         <do_make_visible_with_new_height, make_visible_with_new_height>:
3561         New methods.
3562         (struct tui_source_window_base, struct tui_data_window)
3563         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3564         methods.
3565
3566 2019-06-25  Tom Tromey  <tom@tromey.com>
3567
3568         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3569         method.
3570         (update_tab_width): Call update_tab_width method.
3571         * tui/tui-data.h (struct tui_win_info)
3572         (struct tui_source_window_base) <update_tab_width>: New methods.
3573
3574 2019-06-25  Tom Tromey  <tom@tromey.com>
3575
3576         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3577         parameter.
3578         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3579         parameter.
3580         (tui_gen_win_info::make_visible): Update.
3581         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3582         parameter.
3583         * tui/tui-data.h (enum tui_box): New enum.
3584         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3585
3586 2019-06-25  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3589         init_and_make_win for EXEC_INFO_WIN.
3590         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3591         longer inline.
3592         (struct tui_win_info) <~tui_win_info>: Inline.
3593         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3594         Don't declare.
3595         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3596         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3597         Remove.
3598         (tui_initialize_static_data): Update.
3599         (~tui_gen_win_info): Handle more cleanup here.
3600         (~tui_source_window_base): Delete "execution_info".
3601         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3602
3603 2019-06-25  Tom Tromey  <tom@tromey.com>
3604
3605         * tui/tui-layout.c (make_command_window): Don't set
3606         can_highlight.
3607         (show_source_disasm_command): Call the reset method.
3608         (show_data): Don't set can_highlight.  Call the reset method.
3609         (tui_gen_win_info::reset): Rename from init_gen_win_info
3610         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3611         (show_source_or_disasm_and_command): Call the reset method.
3612         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3613         (struct tui_cmd_window): Set can_highlight.
3614
3615 2019-06-25  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3618         from make_visible.
3619         (tui_make_visible, tui_make_invisible): Rewrite.
3620         (tui_win_info::make_visible): Remove.
3621         (tui_source_window_base::make_visible): Update.
3622         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3623         method.  Moved from...
3624         (struct tui_win_info) <make_visible>: ...here.
3625
3626 2019-06-25  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-winsource.c
3629         (tui_source_window_base::do_scroll_horizontal): Remove direction
3630         parameter.
3631         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3632         direction parameter.
3633         * tui/tui-win.c (tui_win_info::forward_scroll)
3634         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3635         (tui_win_info::right_scroll): Update.
3636         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3637         direction parameter.
3638         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3639         direction parameter.
3640         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3641         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3642         Remove direction parameter.
3643         (struct tui_source_window_base, struct tui_source_window)
3644         (struct tui_disasm_window, struct tui_data_window)
3645         (struct tui_cmd_window): Update.
3646
3647 2019-06-25  Tom Tromey  <tom@tromey.com>
3648
3649         * tui/tui-winsource.h (tui_set_exec_info_content)
3650         (tui_show_exec_info_content, tui_erase_exec_info_content)
3651         (tui_clear_exec_info_content, tui_update_exec_info): Change
3652         argument to tui_source_window_base.
3653         * tui/tui-winsource.c (tui_set_exec_info_content)
3654         (tui_show_exec_info_content, tui_erase_exec_info_content)
3655         (tui_clear_exec_info_content, tui_update_exec_info): Change
3656         argument to tui_source_window_base.
3657
3658 2019-06-25  Tom Tromey  <tom@tromey.com>
3659
3660         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3661         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3662
3663 2019-06-25  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3666         check.
3667
3668 2019-06-25  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3671         type to void.
3672         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3673         type to void.
3674         * tui/tui-source.c (tui_set_source_content): Update.
3675         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3676
3677 2019-06-25  Tom Tromey  <tom@tromey.com>
3678
3679         * tui/tui-win.c (window_name_completer, tui_set_focus)
3680         (tui_all_windows_info): Use name method.
3681         * tui/tui-data.h (struct tui_gen_win_info)
3682         (struct tui_source_window, struct tui_disasm_window)
3683         (struct tui_data_window, struct tui_cmd_window) <name>: New
3684         method.
3685         (tui_win_name): Don't declare.
3686         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3687         (tui_win_name): Remove.
3688
3689 2019-06-25  Tom Tromey  <tom@tromey.com>
3690
3691         * tui/tui-winsource.h (tui_update_source_window)
3692         (tui_update_source_window_as_is): Change parameter type.
3693         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3694         to be a tui_source_window_base.
3695         (tui_update_source_window_as_is): Likewise.
3696         * tui/tui-win.c (make_visible_with_new_height): Update.
3697
3698 2019-06-25  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui-winsource.c (tui_erase_source_content)
3701         (tui_show_source_content, tui_show_exec_info_content)
3702         (tui_erase_exec_info_content): Use refresh_window method.
3703         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3704         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3705         from tui_refresh_win.
3706         (tui_data_window::refresh_window): New method.
3707         (tui_win_info::refresh, tui_source_window_base::refresh)
3708         (tui_refresh_all): Use refresh_window method.
3709         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3710         method.
3711         * tui/tui-regs.c (tui_display_register): Call refresh_window
3712         method.
3713         * tui/tui-layout.c (show_source_disasm_command)
3714         (show_source_or_disasm_and_command): Call refresh_window method.
3715         * tui/tui-data.h (struct tui_gen_win_info)
3716         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3717         New method.
3718
3719 2019-06-25  Tom Tromey  <tom@tromey.com>
3720
3721         * tui/tui.c (tui_rl_other_window, tui_enable)
3722         (tui_is_window_visible, tui_get_command_dimension): Update.
3723         * tui/tui-winsource.c (tui_update_source_window_as_is)
3724         (tui_clear_source_content, tui_erase_source_content)
3725         (tui_show_source_line, tui_source_window_base::refill)
3726         (tui_source_window_base::do_scroll_horizontal)
3727         (tui_source_window_base::set_is_exec_point_at)
3728         (tui_update_breakpoint_info, tui_set_exec_info_content)
3729         (tui_alloc_source_buffer, tui_line_is_displayed)
3730         (tui_addr_is_displayed): Update.
3731         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3732         (tui_check_and_display_highlight_if_needed)
3733         (tui_win_info::make_visible, tui_win_info::refresh)
3734         (tui_refresh_all): Update.
3735         * tui/tui-windata.c (tui_first_data_item_displayed)
3736         (tui_delete_data_content_windows, tui_erase_data_content)
3737         (tui_display_all_data, tui_data_window::refresh_all)
3738         (tui_check_data_values): Update.
3739         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3740         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3741         (tui_win_info::backward_scroll, tui_refresh_all_win)
3742         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3743         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3744         (tui_source_window_base::set_new_height)
3745         (tui_data_window::set_new_height)
3746         (make_invisible_and_set_new_height)
3747         (make_visible_with_new_height, new_height_ok)
3748         (parse_scrolling_args): Update.
3749         * tui/tui-stack.c (tui_show_frame_info): Update.
3750         * tui/tui-source.c (tui_set_source_content)
3751         (tui_set_source_content_nil, tui_source_is_displayed)
3752         (tui_source_window::do_scroll_vertical): Update.
3753         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3754         (tui_display_registers_from, tui_display_reg_element_at_line)
3755         (tui_check_register_values, tui_reg_command): Update.
3756         * tui/tui-layout.c (tui_default_win_height)
3757         (show_source_disasm_command, show_data, init_and_make_win)
3758         (show_source_or_disasm_and_command): Update.
3759         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3760         (tui_redisplay_readline, tui_mld_flush)
3761         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3762         (tui_getc): Update.
3763         * tui/tui-disasm.c (tui_set_disassem_content)
3764         (tui_disasm_window::do_scroll_vertical): Update.
3765         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3766         Now virtual.
3767         (struct tui_win_info): Derive from tui_gen_win_info.
3768         <~tui_win_info>: Mark as override.
3769         <generic>: Remove member.
3770         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3771         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3772         (~tui_data_window, ~tui_win_info)
3773         (tui_free_all_source_wins_content): Update.
3774         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3775
3776 2019-06-25  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui-layout.c (init_and_make_win): Use new.
3779         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3780         destructor, initializers.
3781         (tui_alloc_generic_win_info): Don't declare.
3782         * tui/tui-data.c (_locator): Add argument to constructor.
3783         (source_win, disasm_win): New globals.
3784         (exec_info): Remove.
3785         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3786         Update.
3787         (tui_alloc_generic_win_info): Remove.
3788         (init_content_element): Use new.
3789         (tui_win_info::tui_win_info): Update.
3790         (free_content_elements) <case DATA_WIN>: Use delete.
3791
3792 2019-06-25  Tom Tromey  <tom@tromey.com>
3793
3794         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3795         * tui/tui-windata.c (tui_first_data_item_displayed)
3796         (tui_delete_data_content_windows): Update.
3797         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3798         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3799         (tui_display_registers_from, tui_check_register_values): Update.
3800         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3801         pointer.
3802         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3803         window.
3804         (tui_free_data_content): Update.
3805         (free_content_elements) <case DATA_WIN>: Free the window.
3806
3807 2019-06-25  Tom Tromey  <tom@tromey.com>
3808
3809         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3810         Update.
3811         * tui/tui-layout.c (make_command_window)
3812         (show_source_disasm_command, show_data, init_and_make_win)
3813         (show_source_or_disasm_and_command): Update.
3814         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3815         method.
3816         <can_highight, is_highlighted>: Now bool.
3817         (tui_set_win_highlight): Don't declare.
3818         * tui/tui-data.c (tui_set_win_highlight): Remove.
3819
3820 2019-06-25  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-wingeneral.c (make_visible): Remove check of window
3823         type.
3824
3825 2019-06-25  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-win.c (tui_win_info::max_height)
3828         (tui_cmd_window::max_height): New methods.
3829         (new_height_ok): Call max_height.
3830         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3831         <max_height>: New method.
3832
3833 2019-06-25  Tom Tromey  <tom@tromey.com>
3834
3835         * tui/tui-win.c (tui_source_window_base::set_new_height)
3836         (tui_data_window::set_new_height): New methods.
3837         (make_invisible_and_set_new_height): Call set_new_height method.
3838         * tui/tui-data.h (struct tui_win_info)
3839         (struct tui_source_window_base, struct tui_data_window)
3840         <set_new_height>: New method.
3841
3842 2019-06-25  Tom Tromey  <tom@tromey.com>
3843
3844         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3845         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3846         tui_refresh_data_win.
3847         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3848         method.
3849         (tui_refresh_all_win): Call the refresh_all method.
3850         (tui_set_focus): Likewise.
3851         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3852         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3853         Likewise.
3854
3855 2019-06-25  Tom Tromey  <tom@tromey.com>
3856
3857         * tui/tui-winsource.h (tui_refill_source_window)
3858         (tui_set_is_exec_point_at): Don't declare.
3859         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3860         (tui_source_window_base::refill): Rename from
3861         tui_refill_source_window.
3862         (tui_source_window_base::do_scroll_horizontal): Update.
3863         (tui_source_window_base::set_is_exec_point_at): Rename from
3864         tui_set_is_exec_point_at.
3865         (tui_update_all_breakpoint_info): Update.
3866         * tui/tui-stack.c (tui_show_frame_info): Update.
3867         * tui/tui-layout.c (show_data): Add cast.
3868         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3869         * tui/tui-data.h (struct tui_source_window_base) <refill,
3870         set_is_exec_point_at>: New methods.
3871         (tui_source_windows, tui_add_to_source_windows): Update types.
3872         (tui_add_to_source_windows): Remove redundant declaration.
3873         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3874         (tui_source_windows): Change return type.
3875         (tui_clear_source_windows_detail): Update.
3876         (tui_add_to_source_windows): Change type of parameter.
3877         (tui_free_all_source_wins_content): Update.
3878
3879 2019-06-25  Tom Tromey  <tom@tromey.com>
3880
3881         * tui/tui-wingeneral.c (tui_win_info::refresh)
3882         (tui_source_window_base::refresh): New methods.
3883         (tui_refresh_all): Call the refresh method.
3884         * tui/tui-data.h (struct tui_win_info)
3885         (struct tui_source_window_base) <refresh>: New method.
3886
3887 2019-06-25  Tom Tromey  <tom@tromey.com>
3888
3889         * tui/tui.h (tui_is_window_visible): Return bool.
3890         * tui/tui.c (tui_is_window_visible): Return bool.
3891         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3892         (tui_make_visible, tui_make_invisible)
3893         (tui_win_info::make_visible)
3894         (tui_source_window_base::make_visible, make_all_visible)
3895         (tui_make_all_visible, tui_make_all_invisible): Update.
3896         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3897         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3898         bool.
3899         (struct tui_win_info, struct tui_source_window_base)
3900         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3901         * tui/tui-data.c (tui_init_generic_part): Update.
3902
3903 2019-06-25  Tom Tromey  <tom@tromey.com>
3904
3905         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3906         (tui_source_window_base::make_visible): New methods.
3907         (make_all_visible): Make method call.
3908         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3909         (struct tui_source_window_base, struct tui_cmd_window): Override
3910         make_visible.
3911         (tui_win_is_source_type): Don't declare.
3912         * tui/tui-data.c (tui_win_is_source_type): Remove.
3913
3914 2019-06-25  Tom Tromey  <tom@tromey.com>
3915
3916         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3917         NULL check.
3918
3919 2019-06-25  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3922         Inline constructor.  Add initializers for members.
3923         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3924         constructors; now inline in class.
3925
3926 2019-06-25  Tom Tromey  <tom@tromey.com>
3927
3928         * tui/tui-regs.c (tui_show_registers): Update.
3929         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3930         bool.
3931         * tui/tui-data.c (tui_data_window::clear_detail)
3932         (tui_data_window): Update.
3933
3934 2019-06-25  Tom Tromey  <tom@tromey.com>
3935
3936         * tui/tui-windata.c (tui_display_all_data)
3937         (tui_display_data_from_line, tui_display_data_from)
3938         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3939         Update.
3940         * tui/tui-regs.c (tui_last_regs_line_no)
3941         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3942         (tui_show_registers, tui_show_register_group)
3943         (tui_display_registers_from, tui_display_reg_element_at_line)
3944         (tui_display_registers_from_line, tui_check_register_values)
3945         (tui_reg_next, tui_reg_prev): Update.
3946         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3947         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3948         tui_data_window.
3949         (struct tui_win_info) <detail>: Remove.  Add new fields from
3950         tui_data_info.
3951         (TUI_DATA_WIN): Add cast.
3952         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3953         (~tui_data_window): Simplify.
3954
3955 2019-06-25  Tom Tromey  <tom@tromey.com>
3956
3957         * tui/tui-layout.c (show_source_disasm_command)
3958         (show_source_or_disasm_and_command): Update.
3959         * tui/tui-io.c (update_cmdwin_start_line)
3960         (tui_redisplay_readline): Update.
3961         * tui/tui-data.h (struct tui_command_info): Remove.
3962         (struct tui_win_info) <detail>: Remove command_info member.
3963         (struct tui_data_window) <start_line>: New member, from
3964         tui_command_info.
3965         (TUI_CMD_WIN): Add casts.
3966
3967 2019-06-25  Tom Tromey  <tom@tromey.com>
3968
3969         * tui/tui-winsource.c (tui_update_source_window)
3970         (tui_refill_source_window)
3971         (tui_source_window_base::do_scroll_horizontal)
3972         (tui_update_breakpoint_info, tui_set_exec_info_content)
3973         (tui_show_exec_info_content, tui_erase_exec_info_content)
3974         (tui_clear_exec_info_content): Update.
3975         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3976         Update.
3977         * tui/tui-win.c (make_invisible_and_set_new_height)
3978         (make_visible_with_new_height): Update.
3979         * tui/tui-source.c (tui_set_source_content)
3980         (tui_show_symtab_source): Update.
3981         * tui/tui-layout.c (extract_display_start_addr)
3982         (show_source_disasm_command, show_data)
3983         (make_source_or_disasm_window)
3984         (show_source_or_disasm_and_command): Update.
3985         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3986         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3987         "gdbarch".
3988         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3989         to tui_source_window_base.
3990         (struct tui_win_info) <detail>: Remove source_info member.
3991         (struct tui_source_window_base) <has_locator>: Inline.
3992         Move contents from tui_source_info; rename has_locator member to
3993         m_has_locator.
3994         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3995         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3996         header file.
3997         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3998         Simplify.
3999         (tui_free_all_source_wins_content): Cast to
4000         tui_source_window_base.
4001
4002 2019-06-25  Tom Tromey  <tom@tromey.com>
4003
4004         * tui/tui-win.c (make_invisible_and_set_new_height)
4005         (make_visible_with_new_height): Call has_locator method.
4006         * tui/tui-layout.c (show_source_disasm_command, show_data)
4007         (show_source_or_disasm_and_command): Update for bool change.
4008         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4009         (tui_win_info) <has_locator>: New method.
4010         (struct tui_source_window_base) <has_locator>: New method.
4011         (tui_win_has_locator): Don't declare.
4012         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4013         from tui_win_has_locator.
4014         (tui_source_window_base): Use false, not FALSE.
4015
4016 2019-06-25  Tom Tromey  <tom@tromey.com>
4017
4018         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4019         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4020         clear_detail method directly.
4021         (tui_clear_win_detail): Remove.
4022
4023 2019-06-25  Tom Tromey  <tom@tromey.com>
4024
4025         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4026         "this", not TUI_DISASM_WIN.
4027
4028 2019-06-25  Tom Tromey  <tom@tromey.com>
4029
4030         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4031         declare.
4032         * tui/tui-winsource.c
4033         (tui_source_window_base::do_scroll_horizontal): Rename from
4034         tui_horizontal_source_scroll.
4035         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4036         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4037         from tui_vertical_data_scroll.
4038         * tui/tui-win.h (tui_scroll): Don't declare.
4039         * tui/tui-win.c (tui_win_info::forward_scroll)
4040         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4041         (tui_win_info::right_scroll): Rename and update.
4042         (tui_scroll_forward_command, tui_scroll_backward_command)
4043         (tui_scroll_left_command, tui_scroll_right_command): Update.
4044         (tui_scroll): Remove.
4045         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4046         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4047         from tui_vertical_source_scroll.
4048         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4049         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4050         from tui_vertical_disassem_scroll.
4051         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4052         do_scroll_horizontal>: New methods.
4053         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4054         Likewise.
4055         (struct tui_source_window_base): Add do_scroll_horizontal.
4056         (struct tui_source_window, struct tui_disasm_window): Add
4057         do_scroll_vertical.
4058         (struct tui_data_window, struct tui_cmd_window): Add
4059         do_scroll_horizontal and do_scroll_vertical.
4060         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4061
4062 2019-06-25  Tom Tromey  <tom@tromey.com>
4063
4064         * tui/tui-data.h (struct tui_source_window_base): New struct.
4065         (struct tui_source_window): Derive from tui_source_window_base.
4066         (struct tui_disasm_window): New struct.
4067         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4068         from tui_source_window::clear_detail.
4069         (tui_source_window_base): Rename from tui_source_window.
4070         (~tui_source_window_base): Rename from ~tui_source_window.
4071         (tui_alloc_win_info): Create a tui_disasm_window.
4072
4073 2019-06-25  Tom Tromey  <tom@tromey.com>
4074
4075         * tui/tui-data.h (struct tui_source_window)
4076         (struct tui_data_window): Declare destructors.
4077         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4078         destructors.
4079         (tui_win_info): Simplify.
4080
4081 2019-06-25  Tom Tromey  <tom@tromey.com>
4082
4083         * tui/tui-winsource.c (tui_display_main)
4084         (tui_update_source_windows_with_addr)
4085         (tui_update_all_breakpoint_info): Update.
4086         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4087         (new_height_ok, parse_scrolling_args): Update.
4088         * tui/tui-stack.c (tui_show_frame_info): Update.
4089         * tui/tui-data.h (struct tui_list): Remove.
4090         (tui_source_windows): Return a reference to a std::vector.
4091         * tui/tui-data.c (source_windows): Now a std::vector.
4092         (tui_source_windows): Change return type.
4093         (tui_clear_source_windows): Rewrite.
4094         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4095         (tui_free_all_source_wins_content): Rewrite.
4096
4097 2019-06-25  Tom Tromey  <tom@tromey.com>
4098
4099         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4100         (struct tui_data_window, struct tui_cmd_window): Declare
4101         clear_detail method.
4102         * tui/tui-data.c (tui_source_window::clear_detail)
4103         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4104         methods.
4105         (tui_clear_win_detail): Simplify.
4106
4107 2019-06-25  Tom Tromey  <tom@tromey.com>
4108
4109         * tui/tui-layout.c (make_source_window, make_disasm_window)
4110         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4111         Return the new window.
4112         (show_source_disasm_command, show_data)
4113         (show_source_or_disasm_and_command): Update.
4114
4115 2019-06-25  Tom Tromey  <tom@tromey.com>
4116
4117         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4118         parameter.  Return the new window.
4119         (show_source_disasm_command): Update and remove NULL check.
4120         (show_source_or_disasm_and_command): Update.
4121
4122 2019-06-25  Tom Tromey  <tom@tromey.com>
4123
4124         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4125
4126 2019-06-25  Tom Tromey  <tom@tromey.com>
4127
4128         * tui/tui-data.h (struct tui_win_info): Make constructor
4129         protected.  Make destructor virtual.  Add initializers.
4130         (tui_source_window, tui_data_window, tui_cmd_window): New
4131         classes.
4132         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4133         constructor.  Add "type" parameter.
4134         (tui_source_window, tui_data_window, tui_cmd_window): New
4135         constructors.
4136         (tui_alloc_win_info): Instantiate the appropriate subclass.
4137
4138 2019-06-25  Tom Tromey  <tom@tromey.com>
4139
4140         * tui/tui-win.c (tui_resize_all): Use delete.
4141         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4142         destructor.
4143         (tui_free_window): Don't declare.
4144         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4145         Update.
4146
4147 2019-06-25  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-data.h (struct tui_win_info): Add constructor.
4150         * tui/tui-data.c (tui_alloc_win_info): Use new.
4151         (tui_free_window): Use delete.
4152
4153 2019-06-22  Tom Tromey  <tom@tromey.com>
4154
4155         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4156         declare.
4157         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4158
4159 2019-06-22  Tom Tromey  <tom@tromey.com>
4160
4161         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4162         declare.
4163         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4164
4165 2019-06-22  Tom de Vries  <tdevries@suse.de>
4166
4167         * dwarf2read.c (create_addrmap_from_aranges)
4168         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4169         instead of '%zu'.
4170
4171 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4172
4173         * dwarf2read.h (dwarf2_section_info_def): Remove.
4174         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4175         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4176         std::vector<dwarf2_section_info>.
4177         (struct dwo_file) <~dwo_file>: Remove.
4178         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4179         types field.
4180         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4181         (dwarf2_read_debug_names): Likewise.
4182         (create_debug_types_hash_table): Change parameter type to
4183         array_view, adjust code accordingly.
4184         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4185         (partial_die_info::fixup): Likewise.
4186         (determine_prefix): Likewise.
4187         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4188
4189 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4190
4191         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4192         gdb_bfd_ref_ptr.
4193         <~dwo_file>: Remove call to gdb_bfd_unref.
4194         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4195         gdb_bfd_ref_ptr::get.
4196
4197 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4198
4199         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4200         type to htab_up.
4201         * dwarf2read.c (struct dwo_file): Initialize fields.
4202         <~dwo_file>: New.
4203         (free_dwo_file): Remove, move content to ~dwo_file.
4204         (struct dwo_file_deleter): Remove.
4205         (dwo_file_up>: Remove custom deleter.
4206         (free_dwo_files): Remove.
4207         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4208         dwo_files.
4209         (process_skeletonless_type_units): Call unique_ptr::get.
4210         (allocate_dwo_file_hash_table): Add deleter to created hash
4211         table.  Change return type to htab_up.
4212         (lookup_dwo_file_slot): Don't memset dwo_file, call
4213         unique_ptr::get.
4214         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4215         (create_dwo_unit_in_dwp_v2): Likewise.
4216         (open_and_init_dwo_file): Likewise.
4217         (free_dwo_file_from_slot): Remove.
4218
4219 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4220
4221         * dwarf2read.h (struct dwarf2_section_info) <readin,
4222         is_virtual>: Change type to bool.
4223         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4224         true instead of 1.
4225
4226 2019-06-19  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-data.h (tui_init_content_element): Don't declare.
4229
4230 2019-06-19  Tom Tromey  <tom@tromey.com>
4231
4232         * tui/tui-data.h (tui_init_win_info): Don't declare.
4233
4234 2019-06-19  Tom de Vries  <tdevries@suse.de>
4235
4236         * dwarf2read.h (abstract_to_concrete): Change type to
4237         std::unordered_map<sect_offset, std::vector<sect_offset>,
4238         gdb::hash_enum<sect_offset>>.
4239
4240 2019-06-19  Tom Tromey  <tromey@adacore.com>
4241
4242         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4243         EVAL_AVOID_SIDE_EFFECTS specially.
4244
4245 2019-06-19  Tom Tromey  <tromey@adacore.com>
4246
4247         * source-cache.c (highlighter): New global.
4248         (source_cache::get_source_lines): Create a highlighter on demand.
4249
4250 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4251
4252         * defs.h (deprecated_interactive_hook): Delete declaration.
4253         * interps.c (clear_interpreter_hooks): Remove use of
4254         deprecated_interactive_hook.
4255         * top.c (deprecated_interactive_hook): Delete definition.
4256         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4257
4258 2019-06-18  Tom de Vries  <tdevries@suse.de>
4259
4260         PR gdb/24515
4261         * dwarf2read.h (abstract_to_concrete): Change type from
4262         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4263         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4264         * dwarf2read.c (read_variable): Update.
4265         (dwarf2_fetch_die_loc_sect_off): Update.
4266
4267 2019-06-17  Tom de Vries  <tdevries@suse.de>
4268
4269         PR gdb/24617
4270         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4271         accessing parent[parent_len - 1].
4272
4273 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4274
4275         PR gdb/24364
4276         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4277         call dtrace_process_dof with NULL dof.
4278
4279 2019-06-16  Tom de Vries  <tdevries@suse.de>
4280
4281         PR gdb/24445
4282         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4283
4284 2019-06-16  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4287         (make_all_visible): Use address of member.
4288
4289 2019-06-16  Tom Tromey  <tom@tromey.com>
4290
4291         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4292         (tui_free_window, free_content, free_content_elements): Remove
4293         unnecessary cast.
4294         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4295         cast.
4296         * tui/tui-regs.c (tui_show_register_group)
4297         (tui_display_registers_from, tui_display_reg_element_at_line):
4298         Remove unnecessary cast.
4299
4300 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4301
4302         * linux-nat.c (normal_mask): Delete.
4303         (_initialize_linux_nat): Don't initialise normal_mask.
4304
4305 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4306
4307         PR gdb/24445
4308         * dwarf-index-write.h (write_psymtabs_to_index): Add
4309         dwz_basename parameter.
4310         * dwarf-index-write.c (write_gdbindex): Move file writing to
4311         write_gdbindex_1.  Change return type void.
4312         (assert_file_size): Move up, remove filename parameter.
4313         (write_gdbindex_1): New function.
4314         (write_debug_names): Change return type to void, call
4315         assert_file_size.
4316         (struct index_wip_file): New struct.
4317         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4318         file logic to index_wip_file.  Write index for dwz file if
4319         needed.
4320         (save_gdb_index_command): Pass basename of dwz file, if present.
4321         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4322         build-id of dwz file, if present.
4323         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4324         (dwarf2_get_dwz_file): Likewise.
4325         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4326         (dwarf2_get_dwz_file): Likewise.
4327
4328 2019-06-16  Tom Tromey  <tom@tromey.com>
4329
4330         * coffread.c (process_coff_symbol): Use xstrdup.
4331         * value.c (create_internalvar): Use xstrdup.
4332
4333 2019-06-16  Tom Tromey  <tom@tromey.com>
4334
4335         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4336         * breakpoint.c (stopin_command, stopat_command)
4337         (until_break_command, decode_location_default): Remove unnecessary
4338         cast.
4339         * utils.c (subset_compare): Remove unnecessary cast.
4340         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4341         cast.
4342         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4343         cast.
4344         * infcmd.c (path_command): Remove unnecessary cast.
4345         * coffread.c (decode_type): Remove unnecessary cast.
4346         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4347         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4348         * tui/tui-stack.c (tui_show_locator_content)
4349         (tui_show_frame_info): Remove unnecessary cast.
4350         * tui/tui-win.c (tui_scroll_forward_command)
4351         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4352         (parse_scrolling_args): Remove unnecessary cast.
4353         * tui/tui-data.c (init_win_info, tui_del_window)
4354         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4355         (free_content_elements): Remove unnecessary cast.
4356         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4357         unnecessary cast.
4358         * tui/tui-source.c (tui_set_source_content)
4359         (tui_vertical_source_scroll): Remove unnecessary cast.
4360         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4361         cast.
4362         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4363         * tui/tui-regs.c (tui_display_registers_from)
4364         (tui_display_register): Remove unnecessary cast.
4365         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4366         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4367         (make_visible): Remove unnecessary cast.
4368         * tui/tui-winsource.c (tui_erase_source_content)
4369         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4370         unnecessary cast.
4371         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4372         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4373         * stabsread.c (read_type, read_array_type, read_range_type):
4374         Remove unnecessary cast.
4375         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4376         (parse_symbol, parse_type, upgrade_type, parse_external)
4377         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4378         unnecessary cast.
4379         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4380
4381 2019-06-16  Tom Tromey  <tom@tromey.com>
4382
4383         * tui/tui-data.c (tui_alloc_generic_win_info)
4384         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4385         checks.
4386
4387 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4388             Andrew Burgess  <andrew.burgess@embecosm.com>
4389
4390         * f-typeprint.c (f_print_type): Don't return early for not
4391         associated or not allocated types.
4392         (f_type_print_varspec_suffix): Add print_rank parameter and print
4393         ranks of array types in case they dangling.
4394         (f_type_print_base): Add print_rank parameter.
4395
4396 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4397
4398         * NEWS: Mention new MI commands.
4399         * break-catch-throw.c (enum exception_event_kind): Move to
4400         breakpoint.h.
4401         (print_mention_exception_catchpoint): Output text as a single
4402         message.
4403         (catch_exception_command_1): Rename to...
4404         (catch_exception_event): ...this, make non-static, update header
4405         command, and change some parameter types.
4406         (catch_catch_command): Update for changes to
4407         catch_exception_command_1.
4408         (catch_throw_command): Likewise.
4409         (catch_rethrow_command): Likewise.
4410         * breakpoint.c (enum exception_event_kind): Delete.
4411         * breakpoint.h (enum exception_event_kind): Moved here from
4412         break-catch-throw.c.
4413         (catch_exception_event): Declare.
4414         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4415         (mi_cmd_catch_throw): New function.
4416         (mi_cmd_catch_rethrow): New function.
4417         (mi_cmd_catch_catch): New function.
4418         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4419         'catch-catch' entries.
4420         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4421         (mi_cmd_catch_rethrow): Declare.
4422         (mi_cmd_catch_catch): Declare.
4423
4424 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4425
4426         * annotate.c (annotate_source_line): Change return type to void,
4427         update implementation to match.
4428         * annotate.h (annotate_source_line): Change return type to void,
4429         update header comment.
4430         * stack.c (print_frame_info): Don't change what frame information
4431         is printed based on whether annotations are on or not.
4432
4433 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4434
4435         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4436         (annotate_source): Make static.
4437         (annotate_source_line): Moved from source.c and renamed from
4438         identify_source_line.  Update the return type.
4439         * annotate.h (annotate_source): Delete declaration.
4440         (annotate_source_line): Declaration moved from source.h, and
4441         renamed from identify_source_line.  Return type updated.
4442         * source.c (identify_source_line): Moved to annotate.c and renamed
4443         to annotate_source_line.
4444         (info_line_command): Remove check of annotation_level.
4445         * source.h (identify_source_line): Move declaration to annotate.h
4446         and rename to annotate_source_line.
4447         * stack.c: Add 'annotate.h' include.
4448         (print_frame_info): Remove check of annotation_level before
4449         calling annotate_source_line.
4450
4451 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4452
4453         * source-cache.c (source_cache::get_plain_source_lines): Use
4454         open_source_file_with_line_charpos instead of just
4455         open_source_file, remove call to find_source_lines.
4456         (source_cache::get_source_lines): Likewise.
4457         * source.c (find_source_lines): Make static.
4458         (get_filename_and_charpos): Renamed into...
4459         (open_source_file_with_line_charpos): ..this along with changes to
4460         return a scoped_fd, and some other minor clean ups.
4461         (identify_source_line): Use open_source_file_with_line_charpos.
4462         (search_command_helper): Use open_source_file_with_line_charpos
4463         instead of just open_source_file, remove call to
4464         find_source_lines.
4465         * source.h (open_source_file_with_line_charpos): Declare new
4466         function.
4467         (find_source_lines): Delete declaration.
4468
4469 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * source.c (get_filename_and_charpos): Remove fullname
4472         parameter.
4473         (identify_source_line): Update call to get_filename_and_charpos.
4474
4475 2019-06-14  Tom Tromey  <tromey@adacore.com>
4476
4477         PR gdb/24502:
4478         * ui-style.h (skip_ansi_escape): Update comment.
4479         * ui-file.h (class no_terminal_escape_file): New class.
4480         * ui-file.c (no_terminal_escape_file::write)
4481         (no_terminal_escape_file::puts): New methods.
4482         * cli/cli-logging.c (handle_redirections): Use
4483         no_terminal_escape_file.
4484
4485 2019-06-14  Tom Tromey  <tromey@adacore.com>
4486
4487         * NEWS: Move convenience variable news above Python news.
4488
4489 2019-06-14  Tom Tromey  <tom@tromey.com>
4490
4491         * gnulib: Move directory to top-level.
4492         * configure.ac: Don't configure gnulib.
4493         * configure: Rebuild.
4494         * common/common-defs.h: Use new path to gnulib.
4495         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4496         (GNULIB_H): Remove.
4497         (INCGNU): Look in new gnulib location.
4498         (HFILES_NO_SRCDIR): Remove gnulib files.
4499         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4500         (generated_files): Remove GNULIB_H.
4501         ($(LIBGNU), all-lib): Remove targets.
4502         (distclean): Don't mention GNULIB_BUILDDIR.
4503         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4504
4505 2019-06-14  Tom Tromey  <tromey@adacore.com>
4506
4507         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4508         Warn if symbol file does not provide any symbols.
4509
4510 2019-06-14  Tom Tromey  <tromey@adacore.com>
4511
4512         * source.c (find_and_open_source): Respect basenames_may_differ.
4513
4514 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4515
4516         * annotate.c (annotate_breakpoints_invalid): Make use of
4517         scoped_restore_terminal_state.
4518         (annotate_frames_invalid): Likewise.
4519
4520 2019-06-14  Tom Tromey  <tromey@adacore.com>
4521
4522         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4523         allow assignment to an internalvar.
4524
4525 2019-06-14  Tom Tromey  <tromey@adacore.com>
4526
4527         * ada-lex.l: Allow "_" in attribute names.
4528
4529 2019-06-14  Tom Tromey  <tromey@adacore.com>
4530
4531         PR gdb/24653:
4532         * regcache.c (registers_changed): Don't call alloca.
4533         * top.c (execute_command): Don't call alloca.
4534
4535 2019-06-13  Pedro Alves  <palves@redhat.com>
4536
4537         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4538         'expression'.  When parsing an expression, error out if there's
4539         junk after "unlimited".
4540         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4541         (do_set_command): Adjust calls to is_unlimited_literal.
4542
4543 2019-06-13  Pedro Alves  <palves@redhat.com>
4544
4545         * compile/compile.c (make_compile_options_def_group): Add braces
4546         around array_view initializer.
4547         * thread.c (make_thread_apply_all_options_def_group)
4548         (make_thread_apply_all_options_def_group): Likewise.
4549
4550 2019-06-13  Pedro Alves  <palves@redhat.com>
4551
4552         * NEWS (New commands): Mention "maint test-options
4553         require-delimiter", "maint test-options unknown-is-error", "maint
4554         test-options unknown-is-operand" and "maint show
4555         test-options-completion-result".
4556         (New command options, command completion): New section.
4557         (Completion improvements): New section.
4558         Mention that you can abbreviate "unlimited".
4559
4560 2019-06-13  Pedro Alves  <palves@redhat.com>
4561
4562         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4563         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4564         * unittests/cli-utils-selftests.c (test_parse_flags)
4565         (test_parse_flags_qcs): Delete.
4566         (test_cli_utils): Don't call deleted functions.
4567
4568 2019-06-13  Pedro Alves  <palves@redhat.com>
4569
4570         * thread.c: Include "cli/cli-option.h".
4571         (tp_array_compar_ascending): Global.
4572         (tp_array_compar): Delete function.
4573         (tp_array_compar_ascending, tp_array_compar_descending): New
4574         functions.
4575         (ascending_option_def, qcs_flag_option_def)
4576         (thr_qcs_flags_option_defs)
4577         (make_thread_apply_all_options_def_group)
4578         (make_thread_apply_options_def_group): New.
4579         (thread_apply_all_command): Use gdb::option::process_options.
4580         (thread_apply_command_completer)
4581         (thread_apply_all_command_completer): New.
4582         (thread_apply_command): Use gdb::option::process_options.
4583         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4584         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4585         to generate help text of "thread apply".  Adjust "taas"'s help.
4586         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4587         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4588
4589 2019-06-13  Pedro Alves  <palves@redhat.com>
4590
4591         * thread.c (thread_apply_command): Check for invalid TID with
4592         isdigit instead of !isalpha.
4593
4594 2019-06-13  Pedro Alves  <palves@redhat.com>
4595
4596         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4597         (validate_flags_qcs): New.
4598         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4599         (validate_flags_qcs): Declare.
4600         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4601         (make_frame_apply_options_def_group): New.
4602         (frame_apply_command_count): Process options with
4603         gdb::option::process_options.
4604         (frame_apply_completer): New.
4605         (frame_apply_level_completer, frame_apply_all_completer)
4606         (frame_apply_completer): New.
4607         (_initialize_stack): Update help of "frame apply", "frame apply
4608         level", "frame apply all" and "faas" to mention supported options
4609         and install command completers.
4610         * stack.h (frame_apply_all_completer): Declare.
4611         * thread.c: Include "stack.h".
4612         (tfaas_command): Add "--".
4613         (_initialize_thread): Update help "tfaas" to mention supported
4614         options and install command completer.
4615
4616 2019-06-13  Pedro Alves  <palves@redhat.com>
4617
4618         * completer.c (complete_nested_command_line): New.
4619         (gdb_completion_word_break_characters_throw): Add assertion.
4620         * completer.h (complete_nested_command_line): Declare.
4621
4622 2019-06-13  Pedro Alves  <palves@redhat.com>
4623
4624         * stack.c (parse_backtrace_qualifiers): New.
4625         (backtrace_command): Use it.
4626         (backtrace_command_completer): Complete on qualifiers.
4627
4628 2019-06-13  Pedro Alves  <palves@redhat.com>
4629
4630         * frame.c: Include "cli/cli-option.h.
4631         (user_set_backtrace_options): New.
4632         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4633         Delete.
4634         (get_prev_frame): Adjust.
4635         (boolean_option_def, uinteger_option_def)
4636         (set_backtrace_option_defs): New.
4637         (_initialize_frame): Adjust and use
4638         gdb::option::add_setshow_cmds_for_options to install "set
4639         backtrace past-main" and "set backtrace past-entry".
4640         * frame.h: Include "cli/cli-option.h".
4641         (struct frame_print_options): Forward declare.
4642         (print_frame_arguments_all, print_frame_arguments_scalars)
4643         (print_frame_arguments_none): Declare.
4644         (print_entry_values): Delete declaration.
4645         (struct frame_print_options, user_frame_print_options): New.
4646         (struct set_backtrace_options): New.
4647         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4648         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4649         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4650         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4651         (list_args_or_locals): Add frame_print_options parameter.
4652         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4653         * python/py-framefilter.c (enumerate_args): Pass down
4654         USER_FRAME_PRINT_OPTIONS.
4655         * stack.c: Include "cli/cli-option.h".
4656         (print_frame_arguments_all, print_frame_arguments_scalars)
4657         (print_frame_arguments_none): Declare.
4658         (print_raw_frame_arguments, print_entry_values): Delete.
4659         (user_frame_print_options): New.
4660         (boolean_option_def, enum_option_def, frame_print_option_defs):
4661         New.
4662         (struct backtrace_cmd_options): New.
4663         (bt_flag_option_def): New.
4664         (backtrace_command_option_defs): New.
4665         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4666         (print_frame_arg, read_frame_arg, print_frame_args)
4667         (print_frame_info, print_frame): Add frame_print_options parameter
4668         and use it.
4669         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4670         (backtrace_command_1): Add frame_print_options and
4671         backtrace_cmd_options parameters and use them.
4672         (make_backtrace_options_def_group): New.
4673         (backtrace_command): Process command options with
4674         gdb::option::process_options.
4675         (backtrace_command_completer): New.
4676         (_initialize_stack): Extend "backtrace"'s help to mention
4677         supported options.  Install completer for "backtrace".
4678         Install some settings commands with add_setshow_cmds_for_options.
4679
4680 2019-06-13  Pedro Alves  <palves@redhat.com>
4681
4682         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4683         and that "set/show print raw frame-arguments" are now deprecated.
4684
4685         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4686         command.
4687         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4688         * stack.c (_initialize_stack): Install "set/show print
4689         raw-frame-arguments", and deprecate "set/show print raw
4690         frame-arguments".
4691         * valprint.c (_initialize_valprint): Deprecate "set/show print
4692         raw".
4693
4694 2019-06-13  Pedro Alves  <palves@redhat.com>
4695
4696         * compile/compile.c (struct compile_options): New.
4697         (compile_flag_option_def, compile_command_option_defs)
4698         (make_compile_options_def_group): New.
4699         (compile_file_command): Handle options with
4700         gdb::option::process_options.
4701         (compile_file_command_completer): New function.
4702         (compile_code_command): Handle options with
4703         gdb::option::process_options.
4704         (compile_code_command_completer): New function.
4705         (_initialize_compiler): Install completers for "compile code" and
4706         "compile file".  Mention available options in "compile code" and
4707         "compile code"'s help.
4708         * completer.c (advance_to_completion_word): New, factored out from
4709         ...
4710         (advance_to_expression_complete_word_point): ... this.
4711         (advance_to_filename_complete_word_point): New.
4712         * completer.h (advance_to_filename_complete_word_point): New
4713         declaration.
4714
4715 2019-06-13  Pedro Alves  <palves@redhat.com>
4716
4717         * compile/compile.c: Include "cli/cli-option.h".
4718         (compile_print_value): Scope data pointer is now a
4719         value_print_options pointer; adjust.
4720         (compile_print_command): Process options.  Scope data pointer is
4721         now a value_print_options pointer; adjust.
4722         (_initialize_compile): Update "compile print"'s help to include
4723         supported options.  Install a completer for "compile print".
4724         * cp-valprint.c (show_vtblprint, show_objectprint)
4725         (show_static_field_print): Delete.
4726         (_initialize_cp_valprint): Don't install "set print
4727         static-members", "set print vtbl", "set print object" here.
4728         * printcmd.c: Include "cli/cli-option.h" and
4729         "common/gdb_optional.h".
4730         (print_command_parse_format): Rework to fill in a
4731         value_print_options instead of a format_data.
4732         (print_value): Change parameter type from format_data pointer to
4733         value_print_options reference.  Adjust.
4734         (print_command_1): Process options.  Adjust to pass down a
4735         value_print_options.
4736         (print_command_completer): New.
4737         (_initialize_printcmd): Install print_command_completer as
4738         handle_brkchars completer for the "print" command.  Update
4739         "print"'s help to include supported options.
4740         * valprint.c: Include "cli/cli-option.h".
4741         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4742         here from cp-valprint.c.
4743         (boolean_option_def, uinteger_option_def)
4744         (value_print_option_defs, make_value_print_options_def_group):
4745         New.  Use gdb::option::add_setshow_cmds_for_options to install
4746         "set print elements", "set print null-stop", "set print repeats",
4747         "set print pretty", "set print union", "set print array", "set
4748         print address", "set print symbol", "set print array-indexes".
4749         * valprint.h: Include <string> and "cli/cli-option.h".
4750         (make_value_print_options_def_group): Declare.
4751         (print_value): Change parameter type from format_data pointer to
4752         value_print_options reference.
4753         (print_command_completer): Declare.
4754
4755 2019-06-13  Pedro Alves  <palves@redhat.com>
4756
4757         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4758         (COMMON_SFILES): Add maint-test-settings.c.
4759         * cli/cli-decode.c (boolean_enums): New global, factored out from
4760         ...
4761         (add_setshow_boolean_cmd): ... here.
4762         * cli/cli-decode.h (boolean_enums): Declare.
4763         * cli/cli-option.c: New file.
4764         * cli/cli-option.h: New file.
4765         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4766         factored out from ...
4767         (parse_cli_boolean_value(const char *)): ... this.
4768         (is_unlimited_literal): Change parameter type to pointer to
4769         pointer.  Adjust and advance ARG pointer.
4770         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4771         (parse_cli_var_enum): New, factored out from ...
4772         (do_set_command): ... this.  Adjust.
4773         * cli/cli-setshow.h (parse_cli_boolean_value)
4774         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4775         (parse_cli_var_enum): Declare.
4776         * cli/cli-utils.c: Include "cli/cli-option.h".
4777         (get_ulongest): New.
4778         * cli/cli-utils.h (get_ulongest): Declare.
4779         (check_for_argument): New overloads.
4780         * maint-test-options.c: New file.
4781
4782 2019-06-13  Pedro Alves  <palves@redhat.com>
4783
4784         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4785         parse a range if "-" is at the end of the string.
4786
4787 2019-06-13  Pedro Alves  <palves@redhat.com>
4788
4789         * cli/cli-setshow.c (parse_auto_binary_operation)
4790         (parse_cli_boolean_value): Don't allow "o".
4791
4792 2019-06-13  Pedro Alves  <palves@redhat.com>
4793
4794         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4795         * NEWS: Mention maint test-settings KIND.
4796         * maint-test-settings.c: New file.
4797
4798 2019-06-13  Pedro Alves  <palves@redhat.com>
4799
4800         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4801         completer.
4802         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4803         "set" completers.
4804
4805 2019-06-13  Pedro Alves  <palves@redhat.com>
4806
4807         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4808         after item.
4809
4810 2019-06-13  Pedro Alves  <palves@redhat.com>
4811
4812         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4813
4814 2019-06-13  Pedro Alves <palves@redhat.com>
4815
4816         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4817         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4818         call.
4819         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4820         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4821         calls.
4822         (check_for_argument): Skip spaces after argument.
4823
4824 2019-06-13  Pedro Alves  <palves@redhat.com>
4825
4826         * thread.c (thread_apply_command): Adjust TID parsing.
4827         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4828         detected before end of string.
4829         (tid_is_in_list): Error out if LIST is invalid.
4830
4831 2019-06-13  Pedro Alves  <palves@redhat.com>
4832
4833         * completer.c (complete_line_internal_1): Rewind completion word
4834         point.
4835         (completion_tracker::advance_custom_word_point_by): Change
4836         parameter type to int.
4837         * completer.h (completion_tracker::advance_custom_word_point_by):
4838         Likewise.
4839
4840 2019-06-13  Pedro Alves  <palves@redhat.com>
4841
4842         * completer.c (advance_to_completion_word): Handle delimiters.
4843
4844 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4845
4846         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4847
4848 2019-06-11  Tom Tromey  <tom@tromey.com>
4849
4850         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4851         (xmalloc_failed): Move to alloc.c.
4852         * alloc.c: New file.
4853         * Makefile.in (COMMON_SFILES): Add alloc.c.
4854
4855 2019-06-11  Tom Tromey  <tom@tromey.com>
4856
4857         * nat/linux-waitpid.c: Don't include server.h.
4858         (linux_debug): Remove.
4859         (my_waitpid): Update.
4860
4861 2019-06-11  Tom Tromey  <tromey@adacore.com>
4862
4863         * infcall.c (_initialize_infcall): Remove trailing newline from
4864         help.
4865         * user-regs.c (_initialize_user_regs): Remove trailing newline
4866         from help.
4867         * typeprint.c (_initialize_typeprint): Remove trailing newline
4868         from help.
4869         * reverse.c (_initialize_reverse): Remove trailing newlines from
4870         help.
4871         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4872         from help.
4873         * language.c (add_set_language_command): Remove trailing newline
4874         from help.
4875         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4876         help.
4877         * disasm.c (_initialize_disasm): Remove trailing newline from
4878         help.
4879         * top.c (init_main): Remove trailing newline from help.
4880         * interps.c (_initialize_interpreter): Remove trailing newline
4881         from help.
4882         * btrace.c (_initialize_btrace): Remove trailing newlines from
4883         help.
4884         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4885         from help.
4886         * python/python.c (_initialize_python): Remove trailing newline
4887         from help.
4888         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4889         help.
4890         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4891         from help.  Reformat some text.
4892         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4893         from help.
4894         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4895         newline from help.
4896
4897 2019-06-11  Tom Tromey  <tromey@adacore.com>
4898
4899         * darwin-nat.c (darwin_decode_exception_message)
4900         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4901
4902 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4903
4904         * valops.c (value_slice): Check for not allocated or not
4905         associated values.
4906
4907 2019-06-10  Tom de Vries  <tdevries@suse.de>
4908
4909         PR gdb/24618
4910         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4911         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4912         invalid.
4913
4914 2019-06-10  Tom de Vries  <tdevries@suse.de>
4915
4916         PR gdb/24611
4917         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4918         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4919
4920 2019-06-10  Tom de Vries  <tdevries@suse.de>
4921
4922         PR symtab/24545
4923         * symtab.c (struct demangled_name_entry): Add language field.
4924         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4925         static minimal symbol".  Set and use language field.
4926
4927 2019-06-10  Tom Tromey  <tromey@adacore.com>
4928
4929         * ada-lang.c (_initialize_ada_language): Update help text.
4930
4931 2019-06-10  Tom Tromey  <tromey@adacore.com>
4932
4933         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4934         with a newline.
4935         * guile/guile.c (handle_boot_error): Don't end warning with a
4936         newline.
4937         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4938         warning with a newline.
4939         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4940         newline.
4941         (s12z_frame_cache): Likewise.
4942         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4943         a newline.
4944         * solib-svr4.c (disable_probes_interface): Don't end warning with
4945         a newline.
4946         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4947         newline.
4948         * python/python.c (do_finish_initialization): Don't end warning
4949         with a newline.
4950
4951 2019-06-10  Tom Tromey  <tom@tromey.com>
4952
4953         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4954         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4955         gdbpy_enter.
4956
4957 2019-06-10  Tom Tromey  <tromey@adacore.com>
4958
4959         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4960         data.
4961         (elf_new_init): Don't call stabsread_new_init.
4962         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4963         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4964         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4965
4966 2019-06-10  Tom de Vries  <tdevries@suse.de>
4967
4968         PR symtab/16264
4969         PR symtab/24517
4970         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4971
4972 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4973
4974         * source.c (find_and_open_source): Also rewrite relative file
4975         names.
4976
4977 2019-04-26  Amos Bird  <amosbird@gmail.com>
4978
4979         * annotate.c (annotate_thread_exited): Add "thread-exited"
4980         annotation.
4981
4982 2019-06-06  Tom Tromey  <tromey@adacore.com>
4983
4984         * maint.h (class scoped_command_stats): Use
4985         DISABLE_COPY_AND_ASSIGN.
4986         <print_time>: New method.
4987         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4988         print_time.
4989         (scoped_command_stats::print_time): New method.
4990
4991 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4992
4993         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4994         instructions of lengths 6 or 8 bytes.
4995
4996 2019-06-04  Pedro Alves  <palves@redhat.com>
4997
4998         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4999
5000         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5001         * breakpoint.c (condition_completer): Likewise.
5002         * cli/cli-dump.c (scan_expression): Likewise.
5003         * common/filestuff.c (mkdir_recursive): Likewise.
5004         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5005         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5006         (gdb_abspath): Likewise.
5007         * compile/compile-cplus-types.c
5008         (compile_cplus_instance::decl_name): Likewise.
5009         * completer.c (complete_explicit_location):
5010         (signal_completer, reg_or_group_completer_1): Likewise.
5011         * cp-support.c (cp_remove_params_if_any): Likewise.
5012         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5013         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5014         * infcmd.c (strip_bg_char): Likewise.
5015         * linespec.c (copy_token_string): Likewise.
5016         * mi/mi-main.c (output_cores): Likewise.
5017         * psymtab.c (psymtab_search_name):
5018         * symfile.c (test_set_ext_lang_command): Likewise.
5019         * target.c (target_fileio_read_stralloc): Likewise.
5020         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5021         * value.c (complete_internalvar): Likewise.
5022
5023 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5024
5025         Add objfile property to gdb.Type.
5026         * NEWS: Mention Python API addition.
5027         * python/py-type.c (typy_get_objfile): New method.
5028
5029 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5030
5031         * NEWS: Mention the new set|show style [title|highlight].
5032         Mention changes to "show style", "help" and "apropos".
5033
5034 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5035
5036         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5037         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5038         instead of print_help_for_command.
5039         (print_doc_of_command): New function.
5040         (help_list): Add 'apropos -v word' suggestion.
5041         (print_help_for_command): Style the command name using title style.
5042         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5043         (_initialize_cli_cmds): Describe -v in apropos_command help.
5044
5045 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5046
5047         * cli/cli-style.h (cli_style_option): Add name in constructor,
5048         add m_name class member, add constructor with intensity,
5049         add name class function.
5050         (cli_style_option::add_setshow_commands): Remove name argument.
5051         (highlight_style, title_style): New styles.
5052         * cli/cli-style.c (do_show): New function that shows a style
5053         characteristic styling the style name with itself.
5054         (set_style_name): New function.
5055         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5056         Update all callers according to the changes in cli/cli-style.h.
5057         * utils.h (fputs_highlighted): New function.
5058         * utils.c (fputs_highlighted): Likewise.
5059
5060 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5061
5062         * NEWS: Mention new pipe command and new convenience variables.
5063
5064 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5065
5066         * cli/cli-cmds.c (pipe_command): New function.
5067         (_initialize_cli_cmds): Call add_com for pipe_command.
5068         Define | as an alias for pipe.
5069         (exit_status_set_internal_vars): New function.
5070         (shell_escape): Call exit_status_set_internal_vars.
5071         cli/cli-decode.c (find_command_name_length): Recognize | as
5072         a single character command.
5073
5074 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5075
5076         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5077         top.c (execute_command_to_ui_file): New function, mostly a copy
5078         of execute_command_to_string.
5079         (execute_command_to_string): Implement by calling
5080         execute_command_to_ui_file.
5081
5082 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5083
5084         * top.h (saved_command_line): Remove declaration.
5085         * top.c (previous_saved_command_line, previous_repeat_arguments):
5086         New variables.
5087         (saved_command_line): Make static, define together with other
5088         'repeat variables'.
5089         (dont_repeat): Clear repeat_arguments.
5090         (repeat_previous, get_saved_command_line, save_command_line):
5091         New functions.
5092         (gdb_init): Initialize saved_command_line
5093         and previous_saved_command_line.
5094         * main.c (captured_main_1): Remove saved_command_line initialization.
5095         * event-top.c (handle_line_of_input): Update to use
5096         the new 'repeat' related functions instead of direct access to
5097         saved_command_line.
5098         * command.h (repeat_previous, get_saved_command_line,
5099         save_command_line): New declarations.
5100         (dont_repeat): Add comment.
5101
5102 2019-05-30  Tom Tromey  <tromey@adacore.com>
5103
5104         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5105         Fix comment.
5106         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5107
5108 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5109
5110         PR cli/24587
5111         * completer.c (complete): Initialize variable word.
5112
5113 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5114
5115         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5116         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5117         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5118         'body' is NULL to the outter 'if', protecting the '!is_define'
5119         situation as well.
5120
5121 2019-05-29  Tom Tromey  <tromey@adacore.com>
5122
5123         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5124         (dwarf_unknown): New function.
5125         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5126         (dwarf_type_encoding_name): Use dwarf_unknown.
5127
5128 2019-05-29  Tom Tromey  <tromey@adacore.com>
5129
5130         PR c++/20020:
5131         * cp-valprint.c (cp_print_value_fields): Call
5132         cp_print_static_field inside "try".
5133
5134 2019-05-29  Tom Tromey  <tromey@adacore.com>
5135
5136         * inflow.c (struct terminal_info): Add default operator=.
5137         * configure: Rebuild.
5138         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5139         -Wdeprecated-copy-dtor, -Wredundant-move.
5140
5141 2019-05-29  Tom Tromey  <tromey@adacore.com>
5142
5143         * NEWS: Add entry.
5144         * infcmd.c (print_return_value_1): Handle finish_print
5145         option.
5146         (show_print_finish): New function.
5147         (_initialize_infcmd): Add "set/show print finish" commands.
5148         * valprint.c (user_print_options): Initialize new member.
5149         * valprint.h (struct value_print_options) <finish_print>: New
5150         member.
5151
5152 2019-05-28  Tom Tromey  <tromey@adacore.com>
5153
5154         * ada-lang.c (ada_remove_Xbn_suffix)
5155         (find_old_style_renaming_symbol)
5156         (parse_old_style_renaming): Remove.
5157         (ada_find_renaming_symbol): Don't call
5158         find_old_style_renaming_symbol.
5159         (ada_is_renaming_symbol): Rename from
5160         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5161         bool.  Now static.
5162         (ada_read_var_value): Update and simplify.
5163         * ada-exp.y (write_var_or_type): Remove old code.
5164
5165 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5166
5167         * event-top.c: Remove include comment.
5168         * inflow.c (class scoped_ignore_sigttou): Move from here...
5169         * inflow.h (class scoped_ignore_sigttou): ...to here.
5170         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5171         * top.c:  Remove include comment.
5172
5173 2019-05-27  Tom Tromey  <tom@tromey.com>
5174
5175         * NEWS: Fix typo.
5176
5177 2019-05-22  Tom Tromey  <tromey@adacore.com>
5178
5179         * target.c (target_follow_exec): Constify parameter.
5180         * target-delegates.c: Rebuild.
5181         * remote.c (remote_target::follow_exec): Constify parameter.
5182         * infrun.c (follow_exec): Constify parameter.
5183         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5184         (target_follow_exec): Likewise.
5185
5186 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5187
5188         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5189         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5190
5191 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5192
5193         * NEWS: Add debugredirect and testsuite sections.
5194
5195 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5196
5197         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5198         target descriptions using exclusively floating point register name
5199         aliases.
5200
5201 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5202
5203         PR gdb/18644:
5204         * f-lang.c (build_fortran_types): Handle the case where
5205         gdbarch_floatformat_for_type returns a nullptr.
5206
5207 2019-05-21  Tom de Vries  <tdevries@suse.de>
5208
5209         PR cli/24587
5210         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5211
5212 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5213
5214         PR gdb/18644:
5215         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5216         16-byte floats.
5217         * i386-tdep.c (i386_floatformat_for_type): Use
5218         floatformats_ia64_quad for the 16-byte floating point component
5219         within a fortran 32-byte complex number.
5220
5221 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5222
5223         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5224         delete default constructor.
5225         (find_partial_die): Update to return const struct.
5226         (partial_die_parent_scope): Move variable declaration into scope
5227         of its use and change its type to auto.
5228         (guess_partial_die_structure_name): Likewise.
5229         (partial_die_info::fixup): Likewise.
5230
5231 2019-05-17  Tom Tromey  <tromey@adacore.com>
5232
5233         * source.c (find_and_open_source): Remove cast.
5234
5235 2019-05-17  Tom Tromey  <tromey@adacore.com>
5236
5237         * annotate.c (annotate_source): Make "filename" const.
5238         * annotate.h (annotate_source): Use const.
5239
5240 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5241
5242         * disasm.c (set_disassembler_options): Send errors to stderr.
5243
5244 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5245
5246         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5247         (cli_interp_base::set_logging): Check debug_redirect.
5248         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5249         * cli/cli-logging.c (debug_redirect): Add static variable.
5250         (pop_output_files): Add default param.
5251         (handle_redirections): Print debug setting.
5252         (show_logging_command): Likewise.
5253         (_initialize_cli_logging): Add debugredirect command.
5254         * interps.c (current_interp_set_logging): Add debug_redirect
5255         parameter.
5256         * interps.h (set_logging): Add debug_redirect parameter.
5257         (current_interp_set_logging): Likewise.
5258         * mi/mi-common.h: Likewise.
5259         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5260
5261 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5262             Tom Tromey  <tromey@adacore.com>
5263
5264         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5265         directly.
5266         * cli/cli-interp.h (make_logging_output): Remove declaration.
5267         * cli/cli-logging.c (make_logging_output): Remove function.
5268         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5269         directly.
5270         * ui-file.c (tee_file::tee_file): Remove bools.
5271         (tee_file::~tee_file): Remove deletes.
5272         * ui-file.h (tee_file): Remove bools.
5273
5274 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5275
5276         * mi/mi-cmds.h (mi_cmd_complete): New function.
5277         * mi/mi-main.c (mi_cmd_complete): Likewise.
5278         * mi/mi-cmds.c: Define new MI command -complete.
5279         * NEWS: Mention new -complete command.
5280
5281 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5282
5283         * completer.h (complete): New function.
5284         * completer.c (complete): Likewise.
5285         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5286         function defined in completer.h.
5287
5288 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5289
5290         * MAINTAINERS (Write After Approval): Add myself.
5291
5292 2019-05-17  Tom de Vries  <tdevries@suse.de>
5293
5294         PR gdb/24094
5295         * dwarf2read.c (struct cu_partial_die_info): New struct.
5296         (find_partial_die): Return cu_partial_die_info.
5297         (partial_die_parent_scope, guess_partial_die_structure_name)
5298         (partial_die_info::fixup): Handle new return type of find_partial_die.
5299
5300 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5301
5302         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5303         "std::string", simplifying the algorithm.
5304
5305 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5306
5307         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5308         (stap_static_probe_ops::get_probes): Likewise.
5309
5310 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5311
5312         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5313         '-')" and "else if".
5314         (stap_parse_single_operand): Join checks for
5315         "gdbarch_stap_parse_special_token_p" and
5316         "gdbarch_stap_parse_special_token" in the same "if" statement.
5317         Invert check when verifying for operation on register
5318         displacement.
5319
5320 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5321
5322         * stap-probe.c (stap_get_opcode): Update comment.
5323         (stap_get_expected_argument_type): Likewise.
5324         (handle_stap_probe): Likewise.
5325
5326 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5327
5328         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5329         return type to 'bool'.  Adjust comment.  Use 'bool' when
5330         appropriate.
5331         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5332         * stap-probe.c (stap_parse_argument_1): Likewise.
5333         (stap_is_operator): Likewise.
5334         (stap_is_generic_prefix): Likewise.
5335         (stap_is_register_prefix): Likewise.
5336         (stap_is_register_indirection_prefix): Likewise.
5337         (stap_is_integer_prefix): Likewise.
5338         (stap_generic_check_suffix): Likewise.
5339         (stap_check_integer_suffix): Likewise.
5340         (stap_check_register_suffix): Likewise.
5341         (stap_check_register_indirection_suffix): Likewise.
5342         (stap_parse_register_operand): Likewise.
5343         (stap_parse_single_operand): Likewise.
5344         (stap_parse_argument_1): Likewise.
5345         (stap_probe::get_argument_count): Likewise.
5346         (stap_is_operator): Likewise.
5347
5348 2019-05-16  Tom Tromey  <tromey@adacore.com>
5349
5350         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5351         keyword to foreach.
5352
5353 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5354
5355         * linux-thread-db.c (try_thread_db_load_1): Change return type
5356         to bool.
5357         (try_thread_db_load): Likewise.
5358         (try_thread_db_load_from_pdir_1): Likewise.
5359         (try_thread_db_load_from_pdir): Likewise.
5360         (try_thread_db_load_from_sdir): Likewise.
5361         (try_thread_db_load_from_dir): Likewise.
5362         (thread_db_load_search): Likewise.
5363         (has_libpthread): Likewise.
5364         (thread_db_load): Likewise.
5365
5366 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5367
5368         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5369         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5370         NULL, and complain/return if that's the case.
5371
5372 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5373
5374         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5375         (advance, posn, abstract_read_memory): New functions.
5376         [struct mem_read_abstraction]: New struct.
5377         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5378
5379 2019-05-14  Tom Tromey  <tromey@adacore.com>
5380
5381         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5382         value is not lval_memory.
5383
5384 2019-05-14  Tom Tromey  <tromey@adacore.com>
5385
5386         * solib.c (info_sharedlibrary_command): Style the file name.
5387
5388 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5389
5390         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5391         (aarch64_vnv_type): Likewise.
5392         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5393         * common/tdesc.c: Likewise.
5394         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5395         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5396         * features/aarch64-fpu.xml: Add ieee half view.
5397         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5398         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5399         * gdbtypes.h (struct builtin_type): Likewise.
5400         (struct objfile_type): Likewise.
5401
5402 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5403
5404         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5405         typo.
5406         * location.h (string_to_event_location): Likewise.
5407
5408 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5409
5410         GDB 8.3 released.
5411
5412 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5413
5414         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5415         New variable declaration.
5416         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5417         New variable.
5418         (print_one_breakpoint): Use ui_out::test_flags and new global
5419         variable to compute use_fixed_output.
5420         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5421         Remove.
5422         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5423         (mi_multi_location_breakpoint_output_fixed): Remove.
5424         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5425         new variable.
5426         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5427         fix_multi_location_breakpoint_output flag if version >= 3.
5428         * ui-out.h (enum ui_out_flag)
5429         <fix_multi_location_breakpoint_output>: New enumerator.
5430
5431 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5432
5433         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5434
5435 2019-05-10  Tom Tromey  <tromey@adacore.com>
5436
5437         * ada-lang.c (catch_ada_completer): New function.
5438         (_initialize_ada_language): Use it.
5439
5440 2019-05-10  Tom Tromey  <tromey@adacore.com>
5441
5442         * thread.c (print_thread_info): Make "requested_threads" const.
5443         * gdbthread.h (print_thread_info): Make "requested_threads"
5444         const.
5445         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5446         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5447
5448 2019-05-08  Tom Tromey  <tom@tromey.com>
5449
5450         * gdbtypes.c (objfile_type_data): Change type.
5451         (objfile_type, _initialize_gdbtypes): Update.
5452
5453 2019-05-08  Tom Tromey  <tom@tromey.com>
5454
5455         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5456         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5457         (_initialize_dwarf2_frame): Update.
5458
5459 2019-05-08  Tom Tromey  <tom@tromey.com>
5460
5461         * objc-lang.c (objc_objfile_data): Change type.
5462         (find_methods): Update.
5463         (_initialize_objc_lang): Remove.
5464
5465 2019-05-08  Tom Tromey  <tom@tromey.com>
5466
5467         * stabsread.c (rs6000_builtin_type_data): Change type.
5468         (rs6000_builtin_type, _initialize_stabsread): Update.
5469
5470 2019-05-08  Tom Tromey  <tom@tromey.com>
5471
5472         * mips-tdep.c (mips_pdr_data): Remove.
5473         (_initialize_mips_tdep): Update.
5474
5475 2019-05-08  Tom Tromey  <tom@tromey.com>
5476
5477         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5478         (hppa_init_objfile_priv_data, read_unwind_info)
5479         (find_unwind_entry, _initialize_hppa_tdep): Update.
5480
5481 2019-05-08  Tom Tromey  <tom@tromey.com>
5482
5483         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5484         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5485         on obstack.
5486         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5487
5488 2019-05-08  Tom Tromey  <tom@tromey.com>
5489
5490         * mdebugread.c (basic_type_data): Change type.
5491         (basic_type, _initialize_mdebugread): Update.
5492
5493 2019-05-08  Tom Tromey  <tom@tromey.com>
5494
5495         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5496
5497 2019-05-08  Tom Tromey  <tom@tromey.com>
5498
5499         * nto-tdep.c (nto_inferior_data_reg): Change type.
5500         (nto_inferior_data): Update.
5501         (nto_inferior_data_cleanup, nto_new_inferior_data)
5502         (_initialize_nto_tdep): Remove.
5503         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5504
5505 2019-05-08  Tom Tromey  <tom@tromey.com>
5506
5507         * ada-lang.c (struct ada_inferior_data): Add initializers.
5508         (ada_inferior_data): Change type.
5509         (ada_inferior_data_cleanup): Remove.
5510         (get_ada_inferior_data, ada_inferior_exit)
5511         (struct ada_pspace_data): Add initializers, destructor.
5512         (ada_pspace_data_handle): Change type.
5513         (get_ada_pspace_data): Update.
5514         (ada_pspace_data_cleanup): Remove.
5515
5516 2019-05-08  Tom Tromey  <tom@tromey.com>
5517
5518         * coffread.c (struct coff_symfile_info): Add initializers.
5519         (coff_objfile_data_key): Move lower.  Change type.
5520         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5521         Update.
5522         (coff_free_info): Remove.
5523
5524 2019-05-08  Tom Tromey  <tom@tromey.com>
5525
5526         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5527         (fbsd_pspace_data_handle): Move lower.  Change type.
5528         (get_fbsd_pspace_data): Update.
5529         (fbsd_pspace_data_cleanup): Remove.
5530         (_initialize_fbsd_tdep): Update.
5531
5532 2019-05-08  Tom Tromey  <tom@tromey.com>
5533
5534         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5535         (get_ada_tasks_pspace_data): Update.
5536         (ada_tasks_pspace_data_cleanup): Remove.
5537         (_initialize_tasks): Update.
5538         (ada_tasks_inferior_data_handle): Change type.
5539         (get_ada_tasks_inferior_data): Update.
5540         (ada_tasks_inferior_data_cleanup): Remove.
5541         (struct ada_tasks_pspace_data): Add initializers.
5542
5543 2019-05-08  Tom Tromey  <tom@tromey.com>
5544
5545         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5546         * symfile-debug.c (debug_sym_get_probes): Change type.
5547         * stap-probe.c (handle_stap_probe):
5548         (stap_static_probe_ops::get_probes): Change type.
5549         * probe.h (class static_probe_ops) <get_probes>: Change type.
5550         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5551         (parse_probes_in_pspace): Update.
5552         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5553         Update.
5554         (any_static_probe_ops::get_probes): Change type.
5555         * elfread.c (elfread_data): New typedef.
5556         (probe_key): Change type.
5557         (elf_get_probes): Likewise.  Update.
5558         (probe_key_free): Remove.
5559         (_initialize_elfread): Update.
5560         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5561         Change type.
5562         (dtrace_process_dof_probe, dtrace_process_dof)
5563         (dtrace_static_probe_ops::get_probe): Change type.
5564
5565 2019-05-08  Tom Tromey  <tom@tromey.com>
5566
5567         * xcoffread.c (struct xcoff_symfile_info): Rename from
5568         coff_symfile_info.  Add initializers.
5569         (xcoff_objfile_data_key): Move lower.  Change type.
5570         (XCOFF_DATA): Rewrite.
5571         (xcoff_free_info): Remove.
5572         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5573         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5574         (xcoff_initial_scan): Update.
5575
5576 2019-05-08  Tom Tromey  <tom@tromey.com>
5577
5578         * solib-svr4.c (struct svr4_info): Add initializers and
5579         destructor.
5580         <probes_table>: Now an htab_up.
5581         (solib_svr4_pspace_data): Change type.
5582         (free_probes_table): Simplify.
5583         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5584         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5585         (probes_table_remove_objfile_probes, register_solib_event_probe)
5586         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5587         (_initialize_svr4_solib): Update.
5588
5589 2019-05-08  Tom Tromey  <tom@tromey.com>
5590
5591         * remote.c (remote_pspace_data): Change type.
5592         (remote_pspace_data_cleanup): Remove.
5593         (get_remote_exec_file, set_pspace_remote_exec_file)
5594         (_initialize_remote): Update.
5595
5596 2019-05-08  Tom Tromey  <tom@tromey.com>
5597
5598         * breakpoint.c (breakpoint_objfile_key): Change type.
5599         (get_breakpoint_objfile_data): Update.
5600         (free_breakpoint_objfile_data): Remove.
5601         (_initialize_breakpoint): Update.
5602
5603 2019-05-08  Tom Tromey  <tom@tromey.com>
5604
5605         * linux-tdep.c (struct linux_info): Add initializers.
5606         (linux_inferior_data): Move.  Change type.
5607         (invalidate_linux_cache_inf): Update.
5608         (linux_inferior_data_cleanup): Remove.
5609         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5610
5611 2019-05-08  Tom Tromey  <tom@tromey.com>
5612
5613         * auxv.c (auxv_inferior_data): Move.  Change type.
5614         (auxv_inferior_data_cleanup): Remove.
5615         (invalidate_auxv_cache_inf): Rewrite.
5616         (get_auxv_inferior_data, _initialize_auxv): Update.
5617
5618 2019-05-08  Tom Tromey  <tom@tromey.com>
5619
5620         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5621         (symfile_debug_objfile_data_key): Change type.
5622         (symfile_debug_installed, debug_qf_has_symbols)
5623         (debug_qf_find_last_source_symtab)
5624         (debug_qf_forget_cached_source_info)
5625         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5626         (debug_qf_print_stats, debug_qf_dump)
5627         (debug_qf_expand_symtabs_for_function)
5628         (debug_qf_expand_all_symtabs)
5629         (debug_qf_expand_symtabs_with_fullname)
5630         (debug_qf_map_matching_symbols)
5631         (debug_qf_expand_symtabs_matching)
5632         (debug_qf_find_pc_sect_compunit_symtab)
5633         (debug_qf_map_symbol_filenames)
5634         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5635         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5636         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5637         (debug_sym_read_linetable, debug_sym_relocate): Update.
5638         (symfile_debug_free_objfile): Remove.
5639         (install_symfile_debug_logging, _initialize_symfile_debug):
5640         Update.
5641
5642 2019-05-08  Tom Tromey  <tom@tromey.com>
5643
5644         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5645         allocate_on_obstack.
5646         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5647         (get_dwarf2_per_objfile): Update.
5648         (set_dwarf2_per_objfile): Remove.
5649         (dwarf2_has_info, dwarf2_get_section_info): Update.
5650         (dwarf2_free_objfile): Remove.
5651         (_initialize_dwarf2_read): Update.
5652
5653 2019-05-08  Tom Tromey  <tom@tromey.com>
5654
5655         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5656         initializers.
5657         <unsupported_script_warning_printed,
5658         script_not_found_warning_printed>: Now bool.
5659         (auto_load_pspace_data): Change type.
5660         (~auto_load_pspace_info): Rename from
5661         auto_load_pspace_data_cleanup.
5662         (get_auto_load_pspace_data, init_loaded_scripts_info)
5663         (clear_section_scripts, maybe_print_unsupported_script_warning)
5664         (maybe_print_script_not_found_warning, _initialize_auto_load):
5665         Update.
5666
5667 2019-05-08  Tom Tromey  <tom@tromey.com>
5668
5669         * objfiles.c (objfile_pspace_info): Add destructor and
5670         initializers.
5671         (objfiles_pspace_data): Change type.
5672         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5673         (get_objfile_pspace_data): Update.
5674         (objfiles_bfd_data): Change type.
5675         (get_objfile_bfd_data): Update.
5676         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5677
5678 2019-05-08  Tom Tromey  <tom@tromey.com>
5679
5680         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5681         Change type.
5682         (get_catch_syscall_inferior_data): Update.
5683         (catch_syscall_inferior_data_cleanup): Remove.
5684         (_initialize_break_catch_syscall): Update.
5685
5686 2019-05-08  Tom Tromey  <tom@tromey.com>
5687
5688         * inflow.c (struct terminal_info): Add destructor and
5689         initializers.
5690         (inflow_inferior_data): Change type.
5691         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5692         (get_inflow_inferior_data, inflow_inferior_exit)
5693         (swap_terminal_info, _initialize_inflow): Update.
5694
5695 2019-05-08  Tom Tromey  <tom@tromey.com>
5696
5697         * target-dcache.c (target_dcache_cleanup): Remove.
5698         (target_dcache_aspace_key): Change type.
5699         (target_dcache_init_p, target_dcache_invalidate)
5700         (target_dcache_get, target_dcache_get_or_init)
5701         (_initialize_target_dcache): Update.
5702         * dcache.h (struct dcache_deleter): New.
5703
5704 2019-05-08  Tom Tromey  <tom@tromey.com>
5705
5706         * symtab.c (struct symbol_cache): Add destructor and
5707         initializers.
5708         (symbol_cache_key): Move.  Change type.
5709         (make_symbol_cache, free_symbol_cache): Remove.
5710         (get_symbol_cache): Update.
5711         (symbol_cache_cleanup): Remove.
5712         (ALL_PSPACES, symbol_cache_flush)
5713         (maintenance_print_symbol_cache)
5714         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5715         Update.
5716
5717 2019-05-08  Tom Tromey  <tom@tromey.com>
5718
5719         * symtab.c (struct main_info): Add destructor and initializers.
5720         (main_progspace_key): Move.  Change type.
5721         (get_main_info): Update.
5722         (main_info_cleanup): Remove.
5723         (_initialize_symtab): Update.
5724
5725 2019-05-08  Tom Tromey  <tom@tromey.com>
5726
5727         * registry.h (DECLARE_REGISTRY): Define the _key class.
5728
5729 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5730
5731         * NEWS: Merge two 'New commands' sections.
5732
5733 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5734
5735         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5736         parameter and use Ada language definition instead.
5737         (ada_val_print_ptr): Remove unused language parameter.
5738         (ada_val_print_num): Remove language parameter and use Ada language
5739         definition instead.
5740         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5741         parameter.
5742         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5743         parameter and use Ada language definition instead.
5744         (ada_val_print_1): Update all ada_val_print_xxx calls.
5745         Remove language parameter.
5746         (ada_val_print): Update ada_val_print_1 call.
5747
5748 2019-05-08  Tom Tromey  <tromey@adacore.com>
5749
5750         * remote.c (remote_hw_watchpoint_limit)
5751         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5752         Now static.
5753
5754 2019-05-08  Tom Tromey  <tromey@adacore.com>
5755
5756         * maint.c (_initialize_maint_cmds): Move initialization code to
5757         remote.c.
5758         (watchdog, show_watchdog): Move to remote.c.
5759         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5760         "watchdog" static.
5761         (_initialize_remote): Move initialization code from maint.c.
5762         * defs.h (watchdog): Don't declare.
5763
5764 2019-05-08  Tom Tromey  <tromey@adacore.com>
5765
5766         * tui/tui-interp.c: Include main.h.
5767         * interps.c: Include main.h.
5768         * main.h (interpreter_p): Declare.
5769         * defs.h (interpreter_p): Don't declare.
5770
5771 2019-05-08  Tom Tromey  <tromey@adacore.com>
5772
5773         * dwarf2loc.c: Include dwarf2read.h.
5774         * defs.h (read_unsigned_leb128): Don't declare.
5775         * dwarf2read.h (read_unsigned_leb128): Declare.
5776
5777 2019-05-08  Tom Tromey  <tromey@adacore.com>
5778
5779         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5780         method.
5781
5782 2019-05-08  Tom Tromey  <tromey@adacore.com>
5783
5784         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5785         when no wrap column is set.
5786
5787 2019-05-08  Tom Tromey  <tromey@adacore.com>
5788
5789         * c-lang.c (c_get_string): Handle non-C-style arrays.
5790
5791 2019-05-08  Tom Tromey  <tromey@adacore.com>
5792
5793         * typeprint.c (print_offset_data::update): Print the bit offset,
5794         not the number of bits remaining.
5795
5796 2019-05-08  Tom Tromey  <tromey@adacore.com>
5797
5798         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5799         padding at end of comment.
5800
5801 2019-05-08  Tom Tromey  <tromey@adacore.com>
5802
5803         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5804         Compare main types.
5805
5806 2019-05-06  Tom Tromey  <tom@tromey.com>
5807
5808         * common/scoped_mmap.c: Include common-defs.h.
5809         * common/scoped_mmap.h: Don't include config.h.
5810
5811 2019-05-04  Tom Tromey  <tom@tromey.com>
5812
5813         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5814         (struct aarch64_call_info): Add initializers.
5815         <si>: Now a std::vector.
5816         (pass_on_stack, aarch64_push_dummy_call): Update.
5817
5818 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5819             Tom Tromey  <tom@tromey.com>
5820
5821         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5822         (ppc_threads): Now a std::vector.  Now static.
5823         (hwdebug_find_thread_points_by_tid)
5824         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5825         Update.
5826
5827 2019-05-04  Tom Tromey  <tom@tromey.com>
5828
5829         * arc-tdep.c (arc_tdesc_init): Return bool.
5830
5831 2019-05-04  Tom Tromey  <tom@tromey.com>
5832
5833         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5834         Use gdb_assert_not_reached.
5835
5836 2019-05-04  Tom Tromey  <tom@tromey.com>
5837
5838         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5839         "false".
5840
5841 2019-05-04  Tom Tromey  <tom@tromey.com>
5842
5843         * arc-tdep.c (arc_tdesc_init): Use bool.
5844
5845 2019-05-04  Tom Tromey  <tom@tromey.com>
5846
5847         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5848
5849 2019-05-04  Tom Tromey  <tom@tromey.com>
5850
5851         * cli/cli-cmds.c (valid_command_p): Return bool.
5852
5853 2019-05-04  Tom Tromey  <tom@tromey.com>
5854
5855         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5856         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5857
5858 2019-05-04  Raul Tambre  <raul@tambre.ee>
5859
5860         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5861         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5862         operator for comparison.
5863
5864 2019-05-04  Tom Tromey  <tom@tromey.com>
5865
5866         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5867         (lookup_partial_symbol, print_partial_symbols)
5868         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5869         (psymbol_compare): Update.
5870         (add_psymbol_to_bcache): Clear the entire psymbol.
5871         (maintenance_check_psymtabs): Update.
5872         * psympriv.h (struct partial_symbol): Don't derive from
5873         general_symbol_info.
5874         <obj_section, unrelocated_address, address,
5875         set_unrelocated_address>: Update.
5876         <ginfo>: New member.
5877         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5878         (debug_names::write_psymbols): Update.
5879
5880 2019-05-04  Tom de Vries  <tdevries@suse.de>
5881
5882         * contrib/cc-with-tweaks.sh: Support -n arg.
5883
5884 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5885
5886         * corelow.c (core_target::detach): Ensure frame cache and
5887         register caches are cleared.
5888         inferior.c (exit_inferior_1): Likewise.
5889
5890 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5891             Tom Tromey  <tom@tromey.com>
5892
5893         * dictionary.c (collate_pending_symbols_by_language): Remove
5894         "struct" from foreach.
5895         * symtab.c (lookup_global_symbol_from_objfile)
5896         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5897         foreach.
5898         * ser-tcp.c (net_open): Remove "struct" from foreach.
5899         * objfiles.c (objfile_relocate, objfile_rebase)
5900         (objfile_has_symbols): Remove "struct" from foreach.
5901         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5902         from foreach.
5903         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5904         foreach.
5905         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5906         "struct" from foreach.
5907         * ada-lang.c (create_excep_cond_exprs)
5908         (ada_exception_catchpoint_cond_string): Remove "struct" from
5909         foreach.
5910
5911 2019-05-03  Tom Tromey  <tromey@adacore.com>
5912
5913         * ada-exp.y (convert_char_literal): Check suffix of each
5914         enumerator.
5915
5916 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5917
5918         PR ada/21406:
5919         * ada-exp.y (yywrap): Don't define.
5920         * ada-lex.l (%option): Add noyywrap
5921         (yywrap): Remove.
5922
5923 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5924
5925         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5926         _WIN32_WINNT to the XP level, unless already defined to a higher
5927         level.
5928
5929         * unittests/parse-connection-spec-selftests.c:
5930         * ser-tcp.c:
5931         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5932         override.
5933
5934         * symfile.c (find_separate_debug_file): Remove colon from the
5935         drive spec of DOS/Windows file names of the target, so that the
5936         file name produced from DEBUGDIR and the target's directory will
5937         be valid on DOS/Windows systems.
5938
5939 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * rust-lang.c (val_print_struct): Handle printing structures
5942         containing strings.
5943
5944 2019-05-02  Tom Tromey  <tromey@adacore.com>
5945
5946         * valarith.c (_initialize_valarith): Remove.
5947
5948 2019-05-01  Tom Tromey  <tromey@adacore.com>
5949
5950         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5951         bitfields.
5952
5953 2019-05-01  Tom Tromey  <tromey@adacore.com>
5954
5955         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5956         for big-endian copies.
5957
5958 2019-04-30  Ali Tamur  <tamur@google.com>
5959         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5960         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5961         (read_3_bytes): New function.
5962
5963 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5964
5965         * windows-nat.c (main_thread_id): Delete.
5966         (handle_output_debug_string): Replace main_thread_id by
5967         current_event.dwThreadId.
5968         (fake_create_process): Likewise.
5969         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5970         Do not set main_thread_id.
5971         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5972         current_event.dwThreadId.
5973         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5974
5975 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5976
5977         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5978         Use current_event.dwThreadId instead of main_thread_id.
5979
5980 2019-04-30  Tom Tromey  <tromey@adacore.com>
5981
5982         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5983         (create_excep_cond_exprs): Iterate over program spaces.
5984         (ada_exception_catchpoint_cond_string): Examine all minimal
5985         symbols for exception types.
5986
5987 2019-04-30  Tom Tromey  <tromey@adacore.com>
5988
5989         PR c++/24470:
5990         * dwarf2read.c (process_structure_scope): Handle case where type
5991         has template parameters but no symbol was created.
5992
5993 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5994             Chris January  <chris.january@arm.com>
5995
5996         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5997         qualifier.
5998         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5999
6000 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6001
6002         * f-typeprint.c (f_print_type): Update rules for printing
6003         whitespace.
6004         (f_type_print_varspec_suffix): Likewise.
6005
6006 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6007             Chris January  <chris.january@arm.com>
6008
6009         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6010         function arguments.
6011
6012 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6013
6014         * f-lang.c (build_fortran_types): Change name of void type to
6015         lower case.
6016         * f-typeprint.c (f_type_print_base): Print the name of the void
6017         type, rather than a fixed string.
6018         * f-valprint.c (f_decorations): Use lower case void string.
6019
6020 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6021             Chris January  <chris.january@arm.com>
6022
6023         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6024         types for Fortran.
6025
6026 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6027             Chris January  <chris.january@arm.com>
6028             David Lecomber  <david.lecomber@arm.com>
6029
6030         * f-exp.y (BINOP_INTRINSIC): New token.
6031         (exp): New parser rule handling BINOP_INTRINSIC.
6032         (f77_keywords): Add new builtin procedures.
6033         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6034         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6035         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6036         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6037         (print_unop_subexp_f): New function.
6038         (print_binop_subexp_f): New function.
6039         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6040         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6041         (dump_subexp_body_f): Likewise.
6042         (operator_check_f): Likewise.
6043         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6044         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6045
6046 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6047
6048         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6049         UNOP_KIND.
6050         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6051         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6052         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6053         (operator_length_f): New fuction.
6054         (print_subexp_f): New function.
6055         (op_name_f): New function.
6056         (dump_subexp_body_f): New function.
6057         (operator_check_f): New function.
6058         (exp_descriptor_f): Replace standard expression handling functions
6059         with new functions.
6060         * gdb/fortran-operator.def: New file.
6061         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6062         * gdb/std-operator.def: Remove UNOP_KIND.
6063
6064 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6065
6066         * std-operator.def: Remove unbalanced, stray double quote
6067         character.
6068
6069 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6070             Chris January  <chris.january@arm.com>
6071             Daniel Everett  <daniel.everett@arm.com>
6072             Nick Forrington  <nick.forrington@arm.com>
6073             Richard Bunt  <richard.bunt@arm.com>
6074
6075         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6076         of depth when printing anonymous structs or unions.
6077         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6078         Don't print either the top-level value, or the children if the
6079         max-depth is exceeded.
6080         (ppscm_print_children): When printing the key of a map, allow one
6081         extra level of depth.
6082         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6083         print either the top-level value, or the children if the max-depth
6084         is exceeded.
6085         (print_children): When printing the key of a map, allow one extra
6086         level of depth.
6087         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6088         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6089         (user_print_options): Initialise max_depth field.
6090         (val_print_scalar_or_string_type_p): New function.
6091         (val_print): Check to see if the max depth has been reached.
6092         (val_print_check_max_depth): Define new function.
6093         (show_print_max_depth): New function.
6094         (_initialize_valprint): Add 'print max-depth' option.
6095         * valprint.h (struct value_print_options) <max_depth>: New field.
6096         (val_print_check_max_depth): Declare new function.
6097         * NEWS: Document new feature.
6098
6099 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6100
6101         * ada-lang.c (ada_language_defn): Initialise new field.
6102         * c-lang.c (c_is_string_type_p): New function.
6103         (c_language_defn): Initialise new field.
6104         (cplus_language_defn): Initialise new field.
6105         (asm_language_defn): Initialise new field.
6106         (minimal_language_defn): Initialise new field.
6107         * c-lang.h (c_is_string_type_p): Declare new function.
6108         * d-lang.c (d_language_defn): Initialise new field.
6109         * f-lang.c (f_is_string_type_p): New function.
6110         (f_language_defn): Initialise new field.
6111         * go-lang.c (go_is_string_type_p): New function.
6112         (go_language_defn): Initialise new field.
6113         * language.c (default_is_string_type_p): New function.
6114         (unknown_language_defn): Initialise new field.
6115         (auto_language_defn): Initialise new field.
6116         * language.h (struct language_defn) <la_is_string_type_p>: New
6117         member variable.
6118         (default_is_string_type_p): Declare new function.
6119         * m2-lang.c (m2_language_defn): Initialise new field.
6120         * objc-lang.c (objc_language_defn): Initialise new field.
6121         * opencl-lang.c (opencl_language_defn): Initialise new field.
6122         * p-lang.c (pascal_is_string_type_p): New function.
6123         (pascal_language_defn): Initialise new field.
6124         * rust-lang.c (rust_is_string_type_p): New function.
6125         (rust_language_defn): Initialise new field.
6126
6127 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6128
6129         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6130         New field.
6131         * ada-lang.c (ada_language_defn): Initialise new field.
6132         * c-lang.c (c_language_defn): Likewise.
6133         (cplus_language_defn): Likewise.
6134         (asm_language_defn): Likewise.
6135         (minimal_language_defn): Likewise.
6136         * d-lang.c (d_language_defn): Likewise.
6137         * f-lang.c (f_language_defn): Likewise.
6138         * go-lang.c (go_language_defn): Likewise.
6139         * language.c (unknown_language_defn): Likewise.
6140         (auto_language_defn): Likewise.
6141         * m2-lang.c (m2_language_defn): Likewise.
6142         * objc-lang.c (objc_language_defn): Likewise.
6143         * opencl-lang.c (opencl_language_defn): Likewise.
6144         * p-lang.c (pascal_language_defn): Likewise.
6145         * rust-lang.c (rust_language_defn): Likewise.
6146
6147 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6148
6149         * ada-lang.c (ada_is_character_type): Change return type to bool.
6150         (ada_is_string_type): Likewise.
6151         * ada-lang.h (ada_is_character_type): Update declaration
6152         (ada_is_string_type): Likewise.
6153
6154 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6155
6156         Support style in 'frame|thread apply'
6157
6158         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6159         * record.c (record_start, record_stop): Update callers of
6160         execute_command_to_string with false.
6161         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6162         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6163         methods.
6164         (class string_file): New constructor with term_out parameter.
6165         Override methods term_out and can_emit_style_escape.  New member
6166         term_out.
6167         (class stdio_file): Override can_emit_style_escape.
6168         (class tee_file): Override term_out and can_emit_style_escape.
6169         * utils.h (can_emit_style_escape): Remove.
6170         * utils.c (can_emit_style_escape): Likewise.
6171         Update all callers of can_emit_style_escape (SOMESTREAM) to
6172         SOMESTREAM->can_emit_style_escape.
6173         * source-cache.c (source_cache::get_source_lines): Likewise.
6174         * stack.c (frame_apply_command_count): Call execute_command_to_string
6175         passing the term_out characteristic of the current gdb_stdout.
6176         * thread.c (thr_try_catch_cmd): Likewise.
6177         * top.c (execute_command_to_string): pass term_out parameter
6178         to construct the string_file for the command output.
6179         * ui-file.c (term_cli_styling): New function (most code moved
6180         from utils.c can_emit_style_escape).
6181         (string_file::string_file, string_file::can_emit_style_escape,
6182         stdio_file::can_emit_style_escape, tee_file::term_out,
6183         tee_file::can_emit_style_escape): New functions.
6184
6185 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6186
6187         * NEWS: Mention the new set|show may-call-functions.
6188         * infcall.c (may_call_functions_p): New variable.
6189         (show_may_call_functions_p): New function.
6190         (call_function_by_hand_dummy): Throws an error if not
6191         may-call-functions.
6192         (_initialize_infcall): Call add_setshow_boolean_cmd for
6193         may-call-functions.
6194
6195 2019-04-25  Keith Seitz  <keiths@redhat.com>
6196
6197         PR c++/24367
6198         * cp-support.c (inspect_type): Don't attempt substitutions
6199         of symbol with the same name.
6200
6201 2019-04-25  Tom Tromey  <tromey@adacore.com>
6202
6203         PR gdb/24475:
6204         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6205         static.
6206
6207 2019-04-25  Tom Tromey  <tromey@adacore.com>
6208
6209         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6210         rvalue reference.
6211         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6212         (gdb_xml_parser::parse): Use std::move.
6213         * python/python-internal.h (gdbpy_convert_exception): Take a const
6214         reference.
6215         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6216         std::move.
6217         * python/py-utils.c (gdbpy_convert_exception): Take a const
6218         reference.
6219         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6220         Use std::move.
6221         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6222         Use std::move.
6223         * mi/mi-main.c (mi_print_exception): Take a const reference.
6224         * main.c (handle_command_errors): Take a const reference.
6225         * linespec.c (parse_linespec): Use std::move.
6226         * infcall.c (run_inferior_call): Use std::move.
6227         (call_function_by_hand_dummy): Use std::move.
6228         * exec.c (try_open_exec_file): Use std::move.
6229         * exceptions.h (exception_print, exception_fprintf)
6230         (exception_print_same): Update.
6231         * exceptions.c (print_exception, exception_print)
6232         (exception_fprintf, exception_print_same): Change parameters to
6233         const reference.
6234         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6235         * common/new-op.c: Use std::move.
6236         * common/common-exceptions.h (struct gdb_exception): Add move
6237         constructor.
6238         (struct gdb_exception_error, struct gdb_exception_quit, struct
6239         gdb_quit_bad_alloc): Change constructor to move constructor.
6240         (throw_exception): Change parameter to rvalue reference.
6241         * common/common-exceptions.c (throw_exception): Take rvalue
6242         reference.
6243         * cli/cli-interp.c (safe_execute_command): Use std::move.
6244         * breakpoint.c (insert_bp_location, location_to_sals): Use
6245         std::move.
6246
6247 2019-04-25  Tom Tromey  <tromey@adacore.com>
6248
6249         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6250         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6251         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6252         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6253         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6254         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6255         guile/scm-value.c: Use unpack.
6256         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6257         gdbscm_gdb_exception.
6258         (gdbscm_throw_gdb_exception): Likewise.
6259         (struct gdbscm_gdb_exception): New.
6260         (unpack): New function.
6261         (gdbscm_wrap): Use unpack.
6262
6263 2019-04-25  Tom Tromey  <tromey@adacore.com>
6264
6265         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6266         (gdb_rl_callback_handler): Use std::move.
6267         * common/common-exceptions.h (struct gdb_exception): Add move
6268         assignment operator.
6269         (throw_exception_sjlj): Change "exception" to const reference.
6270         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6271         (throw_exception_sjlj): Change "exception" to const reference.
6272
6273 2019-04-25  Tom Tromey  <tromey@adacore.com>
6274
6275         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6276         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6277         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6278         Update.
6279         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6280         Update.
6281         * mi/mi-interp.c (mi_interp::exec): Update.
6282         * linespec.c (parse_linespec): Update.
6283         * infcall.c (run_inferior_call): Update.
6284         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6285         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6286         (gdbscm_lookup_global_symbol): Update.
6287         * guile/scm-param.c (gdbscm_parameter_value): Update.
6288         * guile/scm-frame.c (gdbscm_frame_read_register)
6289         (gdbscm_frame_read_var): Update.
6290         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6291         * exec.c (try_open_exec_file): Update.
6292         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6293         (gdb_rl_callback_handler): Update.
6294         * common/common-exceptions.h (exception_none): Don't declare.
6295         * common/common-exceptions.c (exception_none): Don't define.
6296         (struct catcher) <exception>: Update.
6297         * cli/cli-interp.c (safe_execute_command): Update.
6298         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6299
6300 2019-04-25  Ali Tamur  <tamur@google.com>
6301
6302         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6303         (read_attribute_value): Likewise.
6304         (dwarf2_read_addr_index): Update comment.
6305         (read_str_index): Add DW_FORM_strx.
6306         (dwarf2_string_attr): Likewise.
6307         (dwarf2_const_value_attr): Likewise.
6308         (dump_die_shallow): Likewise.
6309         (dwarf2_fetch_constant_bytes): Likewise.
6310         (skip_form_bytes): Likewise.
6311         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6312
6313 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6314
6315         PR corefiles/11608
6316         PR corefiles/18187
6317         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6318         OFFSET.  Verify if current mapping contains an ELF header.
6319         (linux_find_memory_regions_full): Adjust call to
6320         dump_mapping_p.
6321
6322 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6323             Kang Li <kanglictf@gmail.com>
6324
6325         PR gdb/21600
6326
6327         * dwarf2-frame.c (read_initial_length): Be consistent about using
6328         unsigned representation of length.
6329         (decode_frame_entry_1): Likewise.  Check for wraparound of
6330         end pointer as well as buffer overflow.
6331
6332 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6333
6334         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6335         "vq".
6336
6337 2019-04-24  Tom Tromey  <tromey@adacore.com>
6338
6339         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6340
6341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6342
6343         * s12z-tdep.c (s12z_unwind_pc): Delete.
6344         (s12z_unwind_sp): Delete.
6345         (s12z_gdbarch_init): Don't register deleted functions with
6346         gdbarch.
6347
6348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * rl78-tdep.c (rl78_unwind_sp): Delete.
6351         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6352
6353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6354
6355         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6356         (xstormy16_unwind_pc): Delete.
6357         (xstormy16_dummy_id): Delete.
6358         (xstormy16_gdbarch_init): Don't register deleted functions with
6359         gdbarch.
6360
6361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6362
6363         * vax-tdep.c (vax_unwind_pc): Delete.
6364         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6365
6366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6367
6368         * v850-tdep.c (v850_unwind_sp): Delete.
6369         (v850_unwind_pc): Delete.
6370         (v850_dummy_id): Delete.
6371         (v850_gdbarch_init): Don't register deleted functions with
6372         gdbarch.
6373
6374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6375
6376         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6377         (tilegx_unwind_pc): Delete.
6378         (tilegx_unwind_dummy_id): Delete.
6379         (tilegx_gdbarch_init): Don't register deleted functions with
6380         gdbarch.
6381
6382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6383
6384         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6385         (tic6x_dummy_id): Delete.
6386         (tic6x_gdbarch_init): Don't register deleted functions with
6387         gdbarch.
6388
6389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6390
6391         * sparc-tdep.c (sparc_unwind_pc): Delete.
6392         (sparc32_gdbarch_init): Don't register deleted function with
6393         gdbarch.
6394
6395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6396
6397         * sh-tdep.c (sh_unwind_sp): Delete.
6398         (sh_unwind_pc): Delete.
6399         (sh_dummy_id): Delete.
6400         (sh_gdbarch_init): Don't register deleted functions with
6401         gdbarch.
6402
6403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6404
6405         * score-tdep.c (score_unwind_sp): Delete.
6406         (score_unwind_pc): Delete.
6407         (score_dummy_id): Delete.
6408         (score_gdbarch_init): Don't register deleted functions with
6409         gdbarch.
6410
6411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6412
6413         * rx-tdep.c (rx_unwind_pc): Delete.
6414         (rx_unwind_sp): Delete.
6415         (rx_dummy_id): Delete.
6416         (rx_gdbarch_init): Don't register deleted functions with
6417         gdbarch.  Update comment.
6418
6419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6420
6421         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6422         (rs6000_dummy_id): Delete.
6423         (rs6000_gdbarch_init): Don't register deleted functions with
6424         gdbarch.
6425
6426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6427
6428         * or1k-tdep.c (or1k_dummy_id): Delete.
6429         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6430
6431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6432
6433         * nios2-tdep.c (nios2_dummy_id): Delete.
6434         (nios2_unwind_sp): Delete.
6435         (nios2_gdbarch_init): Don't register deleted functions with
6436         gdbarch.
6437
6438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6439
6440         * nds32-tdep.c (nds32_dummy_id): Delete.
6441         (nds32_unwind_pc): Delete.
6442         (nds32_unwind_sp): Delete.
6443         (nds32_gdbarch_init): Don't register deleted functions with
6444         gdbarch.
6445
6446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6447
6448         * msp430-tdep.c (msp430_unwind_pc): Delete.
6449         (msp430_unwind_sp): Delete.
6450         (msp430_dummy_id): Delete.
6451         (msp430_gdbarch_init): Don't register deleted functions with
6452         gdbarch.
6453
6454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6455
6456         * moxie-tdep.c (moxie_unwind_sp): Delete.
6457         (moxie_unwind_pc): Delete.
6458         (moxie_dummy_id): Delete.
6459         (moxie_gdbarch_init): Don't register deleted functions with
6460         gdbarch.
6461
6462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6463
6464         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6465         (mn10300_unwind_pc): Delete.
6466         (mn10300_unwind_sp): Delete.
6467         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6468         mn10300_unwind_sp.
6469         (mn10300_frame_unwind_init): Don't register deleted functions with
6470         gdbarch.
6471
6472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6473
6474         * mep-tdep.c (mep_unwind_pc): Delete.
6475         (mep_unwind_sp): Delete.
6476         (mep_dummy_id): Delete.
6477         (mep_gdbarch_init): Don't register deleted functions with
6478         gdbarch.
6479
6480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6481
6482         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6483         (m68hc11_unwind_sp): Delete.
6484         (m68hc11_gdbarch_init): Don't register deleted functions with
6485         gdbarch.
6486
6487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6488
6489         * m32r-tdep.c (m32r_unwind_sp): Delete.
6490         (m32r_unwind_pc): Delete.
6491         (m32r_dummy_id): Delete.
6492         (m32r_gdbarch_init): Don't register deleted functions with
6493         gdbarch.
6494
6495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6496
6497         * m32c-tdep.c (m32c_unwind_pc): Delete.
6498         (m32c_unwind_sp): Delete.
6499         (m32c_dummy_id): Delete.
6500         (m32c_gdbarch_init): Don't register deleted functions with
6501         gdbarch.
6502
6503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6504
6505         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6506         (lm32_unwind_pc): Delete.
6507         (lm32_dummy_id): Delete.
6508         (lm32_gdbarch_init): Don't register deleted functions with
6509         gdbarch.
6510
6511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6512
6513         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6514         (iq2000_unwind_pc): Delete.
6515         (iq2000_dummy_id): Delete.
6516         (iq2000_gdbarch_init): Don't register deleted functions with
6517         gdbarch.
6518
6519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6520
6521         * nds32-tdep.c (nds32_type_align): Delete.
6522         (nds32_push_dummy_call): Use type_align instead.
6523
6524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6525
6526         * arm-tdep.c (arm_type_align): Only handle vector override case.
6527         (arm_push_dummy_call): Use type_align.
6528         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6529
6530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6531
6532         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6533         case.
6534         (pass_on_stack): Use type_align.
6535         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6536         function.
6537
6538 2019-04-23  Tom Tromey  <tromey@adacore.com>
6539
6540         * dwarf2read.c (line_header::file_name_at): Remove unused
6541         overload.
6542
6543 2019-04-23  Tom de Vries  <tdevries@suse.de>
6544
6545         PR gdb/24438
6546         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6547         invocation.
6548
6549
6550 2019-03-27  Ali Tamur  <tamur@google.com>
6551
6552         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6553         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6554         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6555         (dwarf_expr_context::get_addr_index): Likewise
6556         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6557         (symbol_needs_eval_context::get_addr_index): Likewise
6558         (disassemble_dwarf_expression): Add DW_OP_addrx
6559         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6560         (read_cutu_die_from_dwo): Update comment
6561         (skip_one_die): Add DW_FORM_addrx
6562         (read_attribute_value): Likewise
6563         (var_decode_location): Add DW_OP_addrx
6564         (dwarf2_const_value_attr): Add DW_FORM_addrx
6565         (dump_die_shallow): Likewise
6566         (dwarf2_fetch_constant_bytes): Likewise
6567         (decode_locdesc): Add DW_OP_addrx
6568         (skip_form_bytes): Add DW_FORM_addrx
6569
6570 2019-04-22  Ali Tamur  <tamur@google.com>
6571
6572         * MAINTAINERS (Write After Approval): Add self.
6573
6574 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6575
6576         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6577         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6578         (open_symbol_file_object): Likewise.
6579         (svr4_default_sos): Add info parameter.
6580         (svr4_read_so_list): Likewise.
6581         (svr4_current_sos_direct): Adjust functions calls to pass down
6582         info.
6583         (svr4_current_sos_1): Add info parameter.
6584         (svr4_current_sos): Call get_svr4_info, pass info down to
6585         svr4_current_sos_1.
6586         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6587         get_svr4_info.
6588         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6589         get_svr4_info.
6590         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6591         to get_svr4_info.
6592         (probes_table_remove_objfile_probes): Likewise.
6593         (register_solib_event_probe): Add info parameter.
6594         (solist_update_incremental): Pass info parameter down to
6595         svr4_read_so_list.
6596         (disable_probes_interface): Add info parameter.
6597         (svr4_handle_solib_event): Pass current_program_space to
6598         get_svr4_info.  Adjust disable_probes_interface cleanup.
6599         (svr4_create_probe_breakpoints): Add info parameter, pass it
6600         down to register_solib_event_probe.
6601         (svr4_create_solib_event_breakpoints): Add info parameter,
6602         pass it down to svr4_create_probe_breakpoints.
6603         (enable_break): Pass info down to
6604         svr4_create_solib_event_breakpoints.
6605         (svr4_solib_create_inferior_hook): Pass current_program_space to
6606         get_svr4_info.
6607         (svr4_clear_solib): Likewise.
6608
6609 2019-04-22  Pedro Alves  <palves@redhat.com>
6610
6611         * solib-svr4.c (svr4_free_objfile_observer): New.
6612         (probe_and_action::objfile): New field.
6613         (probes_table_htab_remove_objfile_probes)
6614         (probes_table_remove_objfile_probes): New functions.
6615         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6616         in the new probe_and_action.  Don't store the probe in 'lookup'.
6617         (svr4_create_probe_breakpoints): Pass objfile to
6618         register_solib_event_probe.
6619         (_initialize_svr4_solib): Register a free_objfile observer.
6620
6621 2019-04-19  Tom Tromey  <tom@tromey.com>
6622
6623         * common/queue.h: Remove.
6624
6625 2019-04-19  Tom Tromey  <tom@tromey.com>
6626
6627         * event-loop.c: Don't include "common/queue.h".
6628
6629 2019-04-19  Tom Tromey  <tom@tromey.com>
6630
6631         * remote.c (remote_target): Use delete.
6632         * remote-notif.h: Include <list>, not "common/queue.h".
6633         (notif_client_p): Remove typedef.
6634         (remote_notif_state): Add constructor, destructor, initializer.
6635         <notif_queue>: Now a std::list.
6636         (remote_notif_state_xfree): Don't declare.
6637         * remote-notif.c (remote_notif_process, handle_notification)
6638         (remote_notif_state_allocate): Update.
6639         (~remote_notif_state): Rename from remote_notif_state_xfree.
6640
6641 2019-04-19  Tom Tromey  <tom@tromey.com>
6642
6643         * symfile.c (reread_symbols): Update.
6644         * objfiles.c (objfile_register_static_link)
6645         (objfile_lookup_static_link): Update
6646         (~objfile) Don't delete static_links.
6647         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6648
6649 2019-04-19  Tom Tromey  <tom@tromey.com>
6650
6651         * type-stack.h (struct type_stack) <insert>: Constify string.
6652         * type-stack.c (type_stack::insert): Constify string.
6653         * gdbtypes.h (lookup_template_type): Update.
6654         (address_space_name_to_int): Update.
6655         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6656         const.
6657         (lookup_template_type): Make name const.
6658         * c-exp.y: Update rules.
6659         (lex_one_token, classify_name, classify_inner_name)
6660         (c_print_token): Update.
6661         * p-exp.y: Update rules.
6662         (yylex): Update.
6663         * f-exp.y: Update rules.
6664         (yylex): Update.
6665         * d-exp.y: Update rules.
6666         (lex_one_token, classify_name, classify_inner_name): Update.
6667         * parse.c (write_dollar_variable, copy_name): Return std::string.
6668         * parser-defs.h (copy_name): Change return type.
6669         * m2-exp.y: Update rules.
6670         (yylex): Update.
6671         * go-exp.y (lex_one_token): Update.
6672         Update rules.
6673         (classify_unsafe_function, classify_packaged_name)
6674         (classify_name, yylex): Update.
6675
6676 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6677
6678         * configure.ac: add --enable-source-highlight switch.
6679         * configure: Regenerate.
6680         * top.c (print_gdb_version): plumb --enable-source-highlight
6681         status to "show configuration".
6682
6683 2019-04-19  Tom Tromey  <tromey@adacore.com>
6684
6685         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6686         Check ADA_TYPE_P.
6687         (empty_record, ada_template_to_fixed_record_type_1)
6688         (template_to_static_fixed_type)
6689         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6690         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6691         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6692         macros.
6693
6694 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6695
6696         PR symtab/24423:
6697         * source.c (print_source_lines_base): Advance "iter" when a
6698         control character is seen.
6699
6700 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6701
6702         * inferior.h (struct infcall_suspend_state_deleter):
6703         Catch exception in destructor to avoid crash.
6704
6705 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6706
6707         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6708         close to the add_com "shell".
6709
6710 2019-04-18  Tom Tromey  <tromey@adacore.com>
6711
6712         * process-stratum-target.h (class process_stratum_target)
6713         <stratum>: Add "final".
6714
6715 2019-04-17  Tom Tromey  <tromey@adacore.com>
6716
6717         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6718         against nullptr before use.
6719
6720 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6721
6722         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6723
6724 2019-04-17  Jim Wilson  <jimw@sifive.com>
6725             Andrew Burgess  <andrew.burgess@embecosm.com>
6726
6727         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6728         code read might fail, assume 4-byte breakpoint in that case.
6729
6730 2019-04-15  Leszek Swirski  <leszeks@google.com>
6731
6732         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6733         rather than a hand-rolled POD check when checking for forced MEMORY
6734         classification.
6735
6736 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6737
6738         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6739         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6740         function.
6741         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6742         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6743         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6744         declaration.
6745
6746 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6747
6748         * aarch64-linux-nat.c
6749         (aarch64_linux_nat_target::thread_architecture): Add override.
6750         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6751         each VQ.
6752
6753 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6754
6755         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6756
6757 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6758
6759         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6760         target types of size 96-bits, add some additional comments, and
6761         check that the builtin type we found was the correct size.
6762
6763 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6764
6765         * utils.c (prompt_for_continue): Don't restore the styling at the
6766         end, as applied_style has the wrong value.  This fixes styling in
6767         long lists of file names that are interrupted by the "Continue?"
6768         prompt.
6769
6770 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6771
6772         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6773         * c-lang.c (c_language_defn): Likewise.
6774         (cplus_language_defn): Likewise.
6775         (asm_language_defn): Likewise.
6776         (minimal_language_defn): Likewise.
6777         * d-lang.c (d_language_defn): Likewise.
6778         * f-lang.c (f_language_defn): Likewise.
6779         * go-lang.c (go_language_defn): Likewise.
6780         * language.c (unknown_language_defn): Likewise.
6781         (auto_language_defn): Likewise.
6782         * language.h (struct language_defn): Remove la_magic field.
6783         (LANG_MAGIC): Delete.
6784         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6785         * objc-lang.c (objc_language_defn): Likewise.
6786         * opencl-lang.c (opencl_language_defn): Likewise.
6787         * p-lang.c (pascal_language_defn): Likewise.
6788         * rust-lang.c (rust_language_defn): Likewise.
6789
6790 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6791
6792         * riscv-tdep.c (riscv_type_align): New function.
6793         (riscv_type_alignment): Delete.
6794         (riscv_arg_location): Use 'type_align'.
6795         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6796
6797 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6798
6799         * gdbtypes.c (type_align): A struct with no non-static fields also
6800         has alignment of 1.
6801
6802 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6803
6804         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6805         component to 0.
6806         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6807         member.
6808         (riscv_struct_info::analyse): New implementation using new
6809         analyse_inner member function.
6810         (riscv_struct_info::field_offset): New member function.
6811         (riscv_struct_info::m_offsets): New member variable.
6812         (riscv_struct_info::analyse_inner): New private member function,
6813         takes the old implementation of riscv_struct_info::analyse but
6814         extended to track field offsets.
6815         (riscv_call_arg_struct): Update the struct folding special cases
6816         to handle cases where empty C++ structs, which are non-zero
6817         length, are found.
6818         (riscv_arg_location): Initialise the length of each location, a
6819         non-zero length now indicates the location is in use.
6820         (riscv_push_dummy_call): Allow for the first location having a
6821         non-zero offset when setting up arguments.
6822         (riscv_return_value): Likewise, but for return values.
6823
6824 2019-04-11  Tom Tromey  <tromey@adacore.com>
6825
6826         * utils.c (internal_vproblem): Make "msg" const.
6827
6828 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6829
6830         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6831         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6832         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6833         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6834
6835 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6836
6837         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6838         function.
6839         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6840         of amd64_collect_native_gregset.
6841         (amd64_linux_nat_target::store_registers): Likewise.
6842
6843 2019-04-10  Tom Tromey  <tom@tromey.com>
6844
6845         * symtab.c (lookup_global_symbol_from_objfile)
6846         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6847         * objfiles.h (class separate_debug_iterator): New.
6848         (class separate_debug_range): New.
6849         (struct objfile) <separate_debug_objfiles>: New method.
6850         (objfile_separate_debug_iterate): Don't declare.
6851         * objfiles.c (separate_debug_iterator::operator++): Rename from
6852         objfile_separate_debug_iterate.
6853         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6854         iterator.
6855         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6856         iterator.
6857
6858 2019-04-10  Tom Tromey  <tom@tromey.com>
6859
6860         * symfile.c (reread_symbols): Remove old comment.
6861         * objfiles.c (free_all_objfiles): Fix a typo.
6862
6863 2019-04-10  Tom Tromey  <tom@tromey.com>
6864
6865         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6866         * minsyms.c (lookup_minimal_symbol): Use foreach.
6867         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6868         (lookup_minimal_symbol_solib_trampoline): Likewise.
6869         * symfile.c (reread_symbols): Use foreach.
6870
6871 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6872             Tom Tromey  <tromey@adacore.com>
6873
6874         PR rust/24414:
6875         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6876         (rust_lex_int_test): Change "value" to be LONGEST.
6877         (rust_lex_tests): Add test for long integer literal.
6878
6879 2019-04-09  Tom Tromey  <tromey@adacore.com>
6880
6881         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6882         to bool.
6883         (extended_remote_target::attach): Update.
6884         (remote_target::remote_notice_new_inferior): Update.
6885         (remote_target::add_current_inferior_and_thread): Update.
6886         * inferior.c (exit_inferior_1): Use "false".
6887         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6888
6889 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6890
6891         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6892         the "start" command.
6893
6894 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6895
6896         * python/py-inferior.c (infpy_thread_from_thread_handle):
6897         Adjust comments to reflect renaming of thread_from_thread_handle
6898         to thread_from_handle.  Adjust keywords.  Fix type error message.
6899         (inferior_object_methods): Add thread_from_handle.  Retain
6900         thread_from_thread_handle, but mark it as deprecated.
6901
6902 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6903
6904         * gdbthread.h (find_thread_by_handle): Revise declaration.
6905         * thread.c (find_thread_by_handle): Likewise.  Adjust
6906         implementation too.
6907         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6908         support for buffer objects as handles.
6909
6910 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6911
6912         * python/py-infthread.c (thpy_thread_handle): New function.
6913         (thread_object_methods): Register thpy_thread_handle.
6914
6915 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6916
6917         * gdbthread.h (thread_to_thread_handle): Declare.
6918         * thread.c (gdbtypes.h): Include.
6919         (thread_to_thread_handle): New function.
6920
6921         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6922         (target_thread_info_to_thread_handle): Declare.
6923         * target.c (target_thread_info_to_thread_handle): New function.
6924         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6925         * target-delegates.c: Regenerate.
6926
6927         * linux-thread-db.c (class thread_db_target): Add method
6928         thread_info_to_thread_handle.
6929         (thread_db_target::thread_info_to_thread_handle): Define.
6930         * remote.c (class remote_target): Add new method
6931         thread_info_to_thread_handle.
6932         (remote_target::thread_info_to_thread_handle): Define.
6933
6934 2019-04-08  Pedro Alves  <palves@redhat.com>
6935
6936         * common/common-exceptions.c (throw_exception): Don't create
6937         named object to throw; throw directly.
6938         (throw_it): Likewise.  Don't initialize gdb_exception::message
6939         here, with new; pass FMT and AP to the ctor instead.
6940         * common/common-exceptions.h: Include <string>.
6941         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6942         const char *, va_list)): New ctor.  Use std::make_shared.
6943         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6944         errors)): Delete.
6945         (gdb_exception_error::gdb_exception_error(enum errors, const char
6946         *, va_list)): New.
6947         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6948         Add assertion.
6949         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6950         errors)): Delete.
6951         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6952         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6953         Add assertion.
6954
6955 2019-04-08  Tom Tromey  <tom@tromey.com>
6956
6957         * valops.c (value_rtti_indirect_type): Replace throw_exception
6958         with throw.
6959         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6960         with throw.
6961         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6962         throw.
6963         * target.c (target_translate_tls_address): Replace throw_exception
6964         with throw.
6965         * stack.c (frame_apply_command_count): Replace throw_exception
6966         with throw.
6967         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6968         throw.
6969         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6970         with throw.
6971         * rs6000-tdep.c (rs6000_frame_cache)
6972         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6973         * remote.c: Replace throw_exception with throw.
6974         * record-full.c (record_full_message, record_full_wait_1)
6975         (record_full_restore): Replace throw_exception with throw.
6976         * record-btrace.c:
6977         (get_thread_current_frame_id, record_btrace_start_replaying)
6978         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6979         (cmd_record_btrace_start): Replace throw_exception with throw.
6980         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6981         throw.
6982         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6983         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6984         * linespec.c:
6985         (find_linespec_symbols): Replace throw_exception with throw.
6986         * infrun.c (displaced_step_prepare, resume): Replace
6987         throw_exception with throw.
6988         * infcmd.c (post_create_inferior): Replace throw_exception with
6989         throw.
6990         * inf-loop.c (inferior_event_handler): Replace throw_exception
6991         with throw.
6992         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6993         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6994         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6995         (get_prev_frame_always, get_frame_pc_if_available)
6996         (get_frame_address_in_block_if_available, get_frame_language):
6997         Replace throw_exception with throw.
6998         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6999         throw_exception with throw.
7000         * eval.c (fetch_subexp_value, evaluate_var_value)
7001         (evaluate_funcall, evaluate_subexp_standard): Replace
7002         throw_exception with throw.
7003         * dwarf2loc.c (call_site_find_chain)
7004         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7005         Replace throw_exception with throw.
7006         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7007         with throw.
7008         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7009         throw.
7010         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7011         * completer.c (complete_line_internal): Replace throw_exception
7012         with throw.
7013         * compile/compile-object-run.c (compile_object_run): Replace
7014         throw_exception with throw.
7015         * cli/cli-script.c (process_next_line): Replace throw_exception
7016         with throw.
7017         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7018         (btrace_enable, btrace_maint_update_pt_packets): Replace
7019         throw_exception with throw.
7020         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7021         throw_exception with throw.
7022         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7023         throw_exception with throw.
7024         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7025         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7026         * aarch64-tdep.c (aarch64_make_prologue_cache)
7027         (aarch64_make_stub_cache): Replace throw_exception with throw.
7028
7029 2019-04-08  Tom Tromey  <tom@tromey.com>
7030
7031         * common/common-exceptions.c (throw_exception): Rename from
7032         throw_exception_cxx.  Remove old copy.  Make argument const.
7033         (throw_it): Create and throw exception objects directly.
7034         * common/common-exceptions.h (throw_exception): Make argument
7035         const.
7036         (struct gdb_exception_error): Add constructor.
7037         (struct gdb_exception_quit): Add constructor.
7038
7039 2019-04-08  Tom Tromey  <tom@tromey.com>
7040
7041         * common/common-exceptions.h (exception_rethrow): Don't declare.
7042         (TRY_SJLJ): Update comment.
7043         (TRY, CATCH, END_CATCH): Remove.
7044         * common/common-exceptions.c (exception_rethrow): Remove.
7045
7046 2019-04-08  Tom Tromey  <tom@tromey.com>
7047
7048         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7049         Remove.
7050         (gdb_exception_error): Rename from
7051         gdb_exception_RETURN_MASK_ERROR.
7052         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7053         (gdb_quit_bad_alloc): Update.
7054         * aarch64-tdep.c: Update.
7055         * ada-lang.c: Update.
7056         * ada-typeprint.c: Update.
7057         * ada-valprint.c: Update.
7058         * amd64-tdep.c: Update.
7059         * arch-utils.c: Update.
7060         * break-catch-throw.c: Update.
7061         * breakpoint.c: Update.
7062         * btrace.c: Update.
7063         * c-varobj.c: Update.
7064         * cli/cli-cmds.c: Update.
7065         * cli/cli-interp.c: Update.
7066         * cli/cli-script.c: Update.
7067         * common/common-exceptions.c: Update.
7068         * common/new-op.c: Update.
7069         * common/selftest.c: Update.
7070         * compile/compile-c-symbols.c: Update.
7071         * compile/compile-cplus-symbols.c: Update.
7072         * compile/compile-object-load.c: Update.
7073         * compile/compile-object-run.c: Update.
7074         * completer.c: Update.
7075         * corelow.c: Update.
7076         * cp-abi.c: Update.
7077         * cp-support.c: Update.
7078         * cp-valprint.c: Update.
7079         * darwin-nat.c: Update.
7080         * disasm-selftests.c: Update.
7081         * dtrace-probe.c: Update.
7082         * dwarf-index-cache.c: Update.
7083         * dwarf-index-write.c: Update.
7084         * dwarf2-frame-tailcall.c: Update.
7085         * dwarf2-frame.c: Update.
7086         * dwarf2loc.c: Update.
7087         * dwarf2read.c: Update.
7088         * eval.c: Update.
7089         * event-loop.c: Update.
7090         * event-top.c: Update.
7091         * exec.c: Update.
7092         * f-valprint.c: Update.
7093         * fbsd-tdep.c: Update.
7094         * frame-unwind.c: Update.
7095         * frame.c: Update.
7096         * gdbtypes.c: Update.
7097         * gnu-v3-abi.c: Update.
7098         * guile/guile-internal.h: Update.
7099         * guile/scm-block.c: Update.
7100         * guile/scm-breakpoint.c: Update.
7101         * guile/scm-cmd.c: Update.
7102         * guile/scm-disasm.c: Update.
7103         * guile/scm-frame.c: Update.
7104         * guile/scm-lazy-string.c: Update.
7105         * guile/scm-math.c: Update.
7106         * guile/scm-param.c: Update.
7107         * guile/scm-ports.c: Update.
7108         * guile/scm-pretty-print.c: Update.
7109         * guile/scm-symbol.c: Update.
7110         * guile/scm-symtab.c: Update.
7111         * guile/scm-type.c: Update.
7112         * guile/scm-value.c: Update.
7113         * i386-linux-tdep.c: Update.
7114         * i386-tdep.c: Update.
7115         * inf-loop.c: Update.
7116         * infcall.c: Update.
7117         * infcmd.c: Update.
7118         * infrun.c: Update.
7119         * jit.c: Update.
7120         * language.c: Update.
7121         * linespec.c: Update.
7122         * linux-fork.c: Update.
7123         * linux-nat.c: Update.
7124         * linux-tdep.c: Update.
7125         * linux-thread-db.c: Update.
7126         * main.c: Update.
7127         * mi/mi-cmd-break.c: Update.
7128         * mi/mi-cmd-stack.c: Update.
7129         * mi/mi-interp.c: Update.
7130         * mi/mi-main.c: Update.
7131         * objc-lang.c: Update.
7132         * p-valprint.c: Update.
7133         * parse.c: Update.
7134         * ppc-linux-tdep.c: Update.
7135         * printcmd.c: Update.
7136         * python/py-arch.c: Update.
7137         * python/py-breakpoint.c: Update.
7138         * python/py-cmd.c: Update.
7139         * python/py-finishbreakpoint.c: Update.
7140         * python/py-frame.c: Update.
7141         * python/py-framefilter.c: Update.
7142         * python/py-gdb-readline.c: Update.
7143         * python/py-inferior.c: Update.
7144         * python/py-infthread.c: Update.
7145         * python/py-lazy-string.c: Update.
7146         * python/py-linetable.c: Update.
7147         * python/py-objfile.c: Update.
7148         * python/py-param.c: Update.
7149         * python/py-prettyprint.c: Update.
7150         * python/py-progspace.c: Update.
7151         * python/py-record-btrace.c: Update.
7152         * python/py-record.c: Update.
7153         * python/py-symbol.c: Update.
7154         * python/py-type.c: Update.
7155         * python/py-unwind.c: Update.
7156         * python/py-utils.c: Update.
7157         * python/py-value.c: Update.
7158         * python/python.c: Update.
7159         * record-btrace.c: Update.
7160         * record-full.c: Update.
7161         * remote-fileio.c: Update.
7162         * remote.c: Update.
7163         * riscv-tdep.c: Update.
7164         * rs6000-aix-tdep.c: Update.
7165         * rs6000-tdep.c: Update.
7166         * rust-exp.y: Update.
7167         * rust-lang.c: Update.
7168         * s390-tdep.c: Update.
7169         * selftest-arch.c: Update.
7170         * solib-dsbt.c: Update.
7171         * solib-frv.c: Update.
7172         * solib-spu.c: Update.
7173         * solib-svr4.c: Update.
7174         * solib.c: Update.
7175         * sparc64-linux-tdep.c: Update.
7176         * stack.c: Update.
7177         * symfile-mem.c: Update.
7178         * symmisc.c: Update.
7179         * target.c: Update.
7180         * thread.c: Update.
7181         * top.c: Update.
7182         * tracefile-tfile.c: Update.
7183         * tui/tui.c: Update.
7184         * typeprint.c: Update.
7185         * unittests/cli-utils-selftests.c: Update.
7186         * unittests/parse-connection-spec-selftests.c: Update.
7187         * valops.c: Update.
7188         * valprint.c: Update.
7189         * value.c: Update.
7190         * varobj.c: Update.
7191         * windows-nat.c: Update.
7192         * x86-linux-nat.c: Update.
7193         * xml-support.c: Update.
7194
7195 2019-04-08  Tom Tromey  <tom@tromey.com>
7196
7197         * xml-support.c: Use C++ exception handling.
7198         * x86-linux-nat.c: Use C++ exception handling.
7199         * windows-nat.c: Use C++ exception handling.
7200         * varobj.c: Use C++ exception handling.
7201         * value.c: Use C++ exception handling.
7202         * valprint.c: Use C++ exception handling.
7203         * valops.c: Use C++ exception handling.
7204         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7205         handling.
7206         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7207         * typeprint.c: Use C++ exception handling.
7208         * tui/tui.c: Use C++ exception handling.
7209         * tracefile-tfile.c: Use C++ exception handling.
7210         * top.c: Use C++ exception handling.
7211         * thread.c: Use C++ exception handling.
7212         * target.c: Use C++ exception handling.
7213         * symmisc.c: Use C++ exception handling.
7214         * symfile-mem.c: Use C++ exception handling.
7215         * stack.c: Use C++ exception handling.
7216         * sparc64-linux-tdep.c: Use C++ exception handling.
7217         * solib.c: Use C++ exception handling.
7218         * solib-svr4.c: Use C++ exception handling.
7219         * solib-spu.c: Use C++ exception handling.
7220         * solib-frv.c: Use C++ exception handling.
7221         * solib-dsbt.c: Use C++ exception handling.
7222         * selftest-arch.c: Use C++ exception handling.
7223         * s390-tdep.c: Use C++ exception handling.
7224         * rust-lang.c: Use C++ exception handling.
7225         * rust-exp.y: Use C++ exception handling.
7226         * rs6000-tdep.c: Use C++ exception handling.
7227         * rs6000-aix-tdep.c: Use C++ exception handling.
7228         * riscv-tdep.c: Use C++ exception handling.
7229         * remote.c: Use C++ exception handling.
7230         * remote-fileio.c: Use C++ exception handling.
7231         * record-full.c: Use C++ exception handling.
7232         * record-btrace.c: Use C++ exception handling.
7233         * python/python.c: Use C++ exception handling.
7234         * python/py-value.c: Use C++ exception handling.
7235         * python/py-utils.c: Use C++ exception handling.
7236         * python/py-unwind.c: Use C++ exception handling.
7237         * python/py-type.c: Use C++ exception handling.
7238         * python/py-symbol.c: Use C++ exception handling.
7239         * python/py-record.c: Use C++ exception handling.
7240         * python/py-record-btrace.c: Use C++ exception handling.
7241         * python/py-progspace.c: Use C++ exception handling.
7242         * python/py-prettyprint.c: Use C++ exception handling.
7243         * python/py-param.c: Use C++ exception handling.
7244         * python/py-objfile.c: Use C++ exception handling.
7245         * python/py-linetable.c: Use C++ exception handling.
7246         * python/py-lazy-string.c: Use C++ exception handling.
7247         * python/py-infthread.c: Use C++ exception handling.
7248         * python/py-inferior.c: Use C++ exception handling.
7249         * python/py-gdb-readline.c: Use C++ exception handling.
7250         * python/py-framefilter.c: Use C++ exception handling.
7251         * python/py-frame.c: Use C++ exception handling.
7252         * python/py-finishbreakpoint.c: Use C++ exception handling.
7253         * python/py-cmd.c: Use C++ exception handling.
7254         * python/py-breakpoint.c: Use C++ exception handling.
7255         * python/py-arch.c: Use C++ exception handling.
7256         * printcmd.c: Use C++ exception handling.
7257         * ppc-linux-tdep.c: Use C++ exception handling.
7258         * parse.c: Use C++ exception handling.
7259         * p-valprint.c: Use C++ exception handling.
7260         * objc-lang.c: Use C++ exception handling.
7261         * mi/mi-main.c: Use C++ exception handling.
7262         * mi/mi-interp.c: Use C++ exception handling.
7263         * mi/mi-cmd-stack.c: Use C++ exception handling.
7264         * mi/mi-cmd-break.c: Use C++ exception handling.
7265         * main.c: Use C++ exception handling.
7266         * linux-thread-db.c: Use C++ exception handling.
7267         * linux-tdep.c: Use C++ exception handling.
7268         * linux-nat.c: Use C++ exception handling.
7269         * linux-fork.c: Use C++ exception handling.
7270         * linespec.c: Use C++ exception handling.
7271         * language.c: Use C++ exception handling.
7272         * jit.c: Use C++ exception handling.
7273         * infrun.c: Use C++ exception handling.
7274         * infcmd.c: Use C++ exception handling.
7275         * infcall.c: Use C++ exception handling.
7276         * inf-loop.c: Use C++ exception handling.
7277         * i386-tdep.c: Use C++ exception handling.
7278         * i386-linux-tdep.c: Use C++ exception handling.
7279         * guile/scm-value.c: Use C++ exception handling.
7280         * guile/scm-type.c: Use C++ exception handling.
7281         * guile/scm-symtab.c: Use C++ exception handling.
7282         * guile/scm-symbol.c: Use C++ exception handling.
7283         * guile/scm-pretty-print.c: Use C++ exception handling.
7284         * guile/scm-ports.c: Use C++ exception handling.
7285         * guile/scm-param.c: Use C++ exception handling.
7286         * guile/scm-math.c: Use C++ exception handling.
7287         * guile/scm-lazy-string.c: Use C++ exception handling.
7288         * guile/scm-frame.c: Use C++ exception handling.
7289         * guile/scm-disasm.c: Use C++ exception handling.
7290         * guile/scm-cmd.c: Use C++ exception handling.
7291         * guile/scm-breakpoint.c: Use C++ exception handling.
7292         * guile/scm-block.c: Use C++ exception handling.
7293         * guile/guile-internal.h: Use C++ exception handling.
7294         * gnu-v3-abi.c: Use C++ exception handling.
7295         * gdbtypes.c: Use C++ exception handling.
7296         * frame.c: Use C++ exception handling.
7297         * frame-unwind.c: Use C++ exception handling.
7298         * fbsd-tdep.c: Use C++ exception handling.
7299         * f-valprint.c: Use C++ exception handling.
7300         * exec.c: Use C++ exception handling.
7301         * event-top.c: Use C++ exception handling.
7302         * event-loop.c: Use C++ exception handling.
7303         * eval.c: Use C++ exception handling.
7304         * dwarf2read.c: Use C++ exception handling.
7305         * dwarf2loc.c: Use C++ exception handling.
7306         * dwarf2-frame.c: Use C++ exception handling.
7307         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7308         * dwarf-index-write.c: Use C++ exception handling.
7309         * dwarf-index-cache.c: Use C++ exception handling.
7310         * dtrace-probe.c: Use C++ exception handling.
7311         * disasm-selftests.c: Use C++ exception handling.
7312         * darwin-nat.c: Use C++ exception handling.
7313         * cp-valprint.c: Use C++ exception handling.
7314         * cp-support.c: Use C++ exception handling.
7315         * cp-abi.c: Use C++ exception handling.
7316         * corelow.c: Use C++ exception handling.
7317         * completer.c: Use C++ exception handling.
7318         * compile/compile-object-run.c: Use C++ exception handling.
7319         * compile/compile-object-load.c: Use C++ exception handling.
7320         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7321         * compile/compile-c-symbols.c: Use C++ exception handling.
7322         * common/selftest.c: Use C++ exception handling.
7323         * common/new-op.c: Use C++ exception handling.
7324         * cli/cli-script.c: Use C++ exception handling.
7325         * cli/cli-interp.c: Use C++ exception handling.
7326         * cli/cli-cmds.c: Use C++ exception handling.
7327         * c-varobj.c: Use C++ exception handling.
7328         * btrace.c: Use C++ exception handling.
7329         * breakpoint.c: Use C++ exception handling.
7330         * break-catch-throw.c: Use C++ exception handling.
7331         * arch-utils.c: Use C++ exception handling.
7332         * amd64-tdep.c: Use C++ exception handling.
7333         * ada-valprint.c: Use C++ exception handling.
7334         * ada-typeprint.c: Use C++ exception handling.
7335         * ada-lang.c: Use C++ exception handling.
7336         * aarch64-tdep.c: Use C++ exception handling.
7337
7338 2019-04-08  Tom Tromey  <tom@tromey.com>
7339
7340         * xml-support.c (gdb_xml_parser::parse): Update.
7341         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7342         * value.c (show_convenience): Update.
7343         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7344         (test_parse_flags_qcs): Update.
7345         * thread.c (thr_try_catch_cmd): Update.
7346         * target.c (target_translate_tls_address): Update.
7347         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7348         (info_frame_command_core, frame_apply_command_count): Update.
7349         * rust-exp.y (rust_lex_exception_test): Update.
7350         * riscv-tdep.c (riscv_print_one_register_info): Update.
7351         * remote.c (remote_target::enable_btrace): Update.
7352         * record-btrace.c (record_btrace_enable_warn): Update.
7353         * python/py-utils.c (gdbpy_convert_exception): Update.
7354         * printcmd.c (do_one_display, print_variable_and_value): Update.
7355         * mi/mi-main.c (mi_print_exception): Update.
7356         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7357         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7358         * linux-nat.c (linux_nat_target::attach): Update.
7359         * linux-fork.c (class scoped_switch_fork_info): Update.
7360         * infrun.c (displaced_step_prepare): Update.
7361         * infcall.c (call_function_by_hand_dummy): Update.
7362         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7363         * gnu-v3-abi.c (print_one_vtable): Update.
7364         * frame.c (get_prev_frame_always): Update.
7365         * f-valprint.c (info_common_command_for_block): Update.
7366         * exec.c (try_open_exec_file): Update.
7367         * exceptions.c (print_exception, exception_print)
7368         (exception_fprintf, exception_print_same): Update.
7369         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7370         * dwarf-index-cache.c (index_cache::store)
7371         (index_cache::lookup_gdb_index): Update.
7372         * darwin-nat.c (maybe_cache_shell): Update.
7373         * cp-valprint.c (cp_print_value_fields): Update.
7374         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7375         (gcc_cplus_symbol_address): Update.
7376         * compile/compile-c-symbols.c (gcc_convert_symbol)
7377         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7378         * common/selftest.c: Update.
7379         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7380         a std::string.
7381         (exception_try_scope_entry, exception_try_scope_exit): Don't
7382         declare.
7383         (struct exception_try_scope): Remove.
7384         (TRY): Don't use exception_try_scope.
7385         (struct gdb_exception): Add constructor, operator=.
7386         <what>: New method.
7387         (struct gdb_exception_RETURN_MASK_ALL)
7388         (struct gdb_exception_RETURN_MASK_ERROR)
7389         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7390         (struct gdb_quit_bad_alloc): Update.
7391         * common/common-exceptions.c (exception_none): Change
7392         initializer.
7393         (struct catcher) <state, exception>: Initialize inline.
7394         <prev>: Remove member.
7395         (current_catcher): Remove.
7396         (catchers): New global.
7397         (exceptions_state_mc_init): Simplify.
7398         (catcher_pop): Remove.
7399         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7400         (try_scope_depth, exception_try_scope_entry)
7401         (exception_try_scope_exit): Remove.
7402         (throw_exception_sjlj): Update.
7403         (exception_messages, exception_messages_size): Remove.
7404         (throw_it): Simplify.
7405         (gdb_exception_sliced_copy): Remove.
7406         (throw_exception_cxx): Update.
7407         * cli/cli-script.c (script_from_file): Update.
7408         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7409         Update.
7410         * ada-valprint.c (ada_val_print): Update.
7411         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7412         (create_excep_cond_exprs): Update.
7413
7414 2019-04-08  Tom Tromey  <tom@tromey.com>
7415
7416         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7417         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7418         (TRY, CATCH, END_CATCH): Remove some definitions.
7419         * common/common-exceptions.c: Don't use GDB_XCPT.
7420         (catcher_list_size): Remove.
7421         (throw_exception, throw_it): Simplify.
7422
7423 2019-04-05  Tom Tromey  <tom@tromey.com>
7424
7425         Revert the header-sorting patch.
7426         * ft32-tdep.c: Revert.
7427         * frv-tdep.c: Revert.
7428         * frv-linux-tdep.c: Revert.
7429         * frame.c: Revert.
7430         * frame-unwind.c: Revert.
7431         * frame-base.c: Revert.
7432         * fork-child.c: Revert.
7433         * findvar.c: Revert.
7434         * findcmd.c: Revert.
7435         * filesystem.c: Revert.
7436         * filename-seen-cache.h: Revert.
7437         * filename-seen-cache.c: Revert.
7438         * fbsd-tdep.c: Revert.
7439         * fbsd-nat.h: Revert.
7440         * fbsd-nat.c: Revert.
7441         * f-valprint.c: Revert.
7442         * f-typeprint.c: Revert.
7443         * f-lang.c: Revert.
7444         * extension.h: Revert.
7445         * extension.c: Revert.
7446         * extension-priv.h: Revert.
7447         * expprint.c: Revert.
7448         * exec.h: Revert.
7449         * exec.c: Revert.
7450         * exceptions.c: Revert.
7451         * event-top.c: Revert.
7452         * event-loop.c: Revert.
7453         * eval.c: Revert.
7454         * elfread.c: Revert.
7455         * dwarf2read.h: Revert.
7456         * dwarf2read.c: Revert.
7457         * dwarf2loc.c: Revert.
7458         * dwarf2expr.h: Revert.
7459         * dwarf2expr.c: Revert.
7460         * dwarf2-frame.c: Revert.
7461         * dwarf2-frame-tailcall.c: Revert.
7462         * dwarf-index-write.h: Revert.
7463         * dwarf-index-write.c: Revert.
7464         * dwarf-index-common.c: Revert.
7465         * dwarf-index-cache.h: Revert.
7466         * dwarf-index-cache.c: Revert.
7467         * dummy-frame.c: Revert.
7468         * dtrace-probe.c: Revert.
7469         * disasm.h: Revert.
7470         * disasm.c: Revert.
7471         * disasm-selftests.c: Revert.
7472         * dictionary.c: Revert.
7473         * dicos-tdep.c: Revert.
7474         * demangle.c: Revert.
7475         * dcache.h: Revert.
7476         * dcache.c: Revert.
7477         * darwin-nat.h: Revert.
7478         * darwin-nat.c: Revert.
7479         * darwin-nat-info.c: Revert.
7480         * d-valprint.c: Revert.
7481         * d-namespace.c: Revert.
7482         * d-lang.c: Revert.
7483         * ctf.c: Revert.
7484         * csky-tdep.c: Revert.
7485         * csky-linux-tdep.c: Revert.
7486         * cris-tdep.c: Revert.
7487         * cris-linux-tdep.c: Revert.
7488         * cp-valprint.c: Revert.
7489         * cp-support.c: Revert.
7490         * cp-namespace.c: Revert.
7491         * cp-abi.c: Revert.
7492         * corelow.c: Revert.
7493         * corefile.c: Revert.
7494         * continuations.c: Revert.
7495         * completer.h: Revert.
7496         * completer.c: Revert.
7497         * complaints.c: Revert.
7498         * coffread.c: Revert.
7499         * coff-pe-read.c: Revert.
7500         * cli-out.h: Revert.
7501         * cli-out.c: Revert.
7502         * charset.c: Revert.
7503         * c-varobj.c: Revert.
7504         * c-valprint.c: Revert.
7505         * c-typeprint.c: Revert.
7506         * c-lang.c: Revert.
7507         * buildsym.c: Revert.
7508         * buildsym-legacy.c: Revert.
7509         * build-id.h: Revert.
7510         * build-id.c: Revert.
7511         * btrace.c: Revert.
7512         * bsd-uthread.c: Revert.
7513         * breakpoint.h: Revert.
7514         * breakpoint.c: Revert.
7515         * break-catch-throw.c: Revert.
7516         * break-catch-syscall.c: Revert.
7517         * break-catch-sig.c: Revert.
7518         * blockframe.c: Revert.
7519         * block.c: Revert.
7520         * bfin-tdep.c: Revert.
7521         * bfin-linux-tdep.c: Revert.
7522         * bfd-target.c: Revert.
7523         * bcache.c: Revert.
7524         * ax-general.c: Revert.
7525         * ax-gdb.h: Revert.
7526         * ax-gdb.c: Revert.
7527         * avr-tdep.c: Revert.
7528         * auxv.c: Revert.
7529         * auto-load.c: Revert.
7530         * arm-wince-tdep.c: Revert.
7531         * arm-tdep.c: Revert.
7532         * arm-symbian-tdep.c: Revert.
7533         * arm-pikeos-tdep.c: Revert.
7534         * arm-obsd-tdep.c: Revert.
7535         * arm-nbsd-tdep.c: Revert.
7536         * arm-nbsd-nat.c: Revert.
7537         * arm-linux-tdep.c: Revert.
7538         * arm-linux-nat.c: Revert.
7539         * arm-fbsd-tdep.c: Revert.
7540         * arm-fbsd-nat.c: Revert.
7541         * arm-bsd-tdep.c: Revert.
7542         * arch-utils.c: Revert.
7543         * arc-tdep.c: Revert.
7544         * arc-newlib-tdep.c: Revert.
7545         * annotate.h: Revert.
7546         * annotate.c: Revert.
7547         * amd64-windows-tdep.c: Revert.
7548         * amd64-windows-nat.c: Revert.
7549         * amd64-tdep.c: Revert.
7550         * amd64-sol2-tdep.c: Revert.
7551         * amd64-obsd-tdep.c: Revert.
7552         * amd64-obsd-nat.c: Revert.
7553         * amd64-nbsd-tdep.c: Revert.
7554         * amd64-nbsd-nat.c: Revert.
7555         * amd64-nat.c: Revert.
7556         * amd64-linux-tdep.c: Revert.
7557         * amd64-linux-nat.c: Revert.
7558         * amd64-fbsd-tdep.c: Revert.
7559         * amd64-fbsd-nat.c: Revert.
7560         * amd64-dicos-tdep.c: Revert.
7561         * amd64-darwin-tdep.c: Revert.
7562         * amd64-bsd-nat.c: Revert.
7563         * alpha-tdep.c: Revert.
7564         * alpha-obsd-tdep.c: Revert.
7565         * alpha-nbsd-tdep.c: Revert.
7566         * alpha-mdebug-tdep.c: Revert.
7567         * alpha-linux-tdep.c: Revert.
7568         * alpha-linux-nat.c: Revert.
7569         * alpha-bsd-tdep.c: Revert.
7570         * alpha-bsd-nat.c: Revert.
7571         * aix-thread.c: Revert.
7572         * agent.c: Revert.
7573         * addrmap.c: Revert.
7574         * ada-varobj.c: Revert.
7575         * ada-valprint.c: Revert.
7576         * ada-typeprint.c: Revert.
7577         * ada-tasks.c: Revert.
7578         * ada-lang.c: Revert.
7579         * aarch64-tdep.c: Revert.
7580         * aarch64-ravenscar-thread.c: Revert.
7581         * aarch64-newlib-tdep.c: Revert.
7582         * aarch64-linux-tdep.c: Revert.
7583         * aarch64-linux-nat.c: Revert.
7584         * aarch64-fbsd-tdep.c: Revert.
7585         * aarch64-fbsd-nat.c: Revert.
7586         * aarch32-linux-nat.c: Revert.
7587
7588 2019-04-05  Tom Tromey  <tom@tromey.com>
7589
7590         * ft32-tdep.c: Sort headers.
7591         * frv-tdep.c: Sort headers.
7592         * frv-linux-tdep.c: Sort headers.
7593         * frame.c: Sort headers.
7594         * frame-unwind.c: Sort headers.
7595         * frame-base.c: Sort headers.
7596         * fork-child.c: Sort headers.
7597         * findvar.c: Sort headers.
7598         * findcmd.c: Sort headers.
7599         * filesystem.c: Sort headers.
7600         * filename-seen-cache.h: Sort headers.
7601         * filename-seen-cache.c: Sort headers.
7602         * fbsd-tdep.c: Sort headers.
7603         * fbsd-nat.h: Sort headers.
7604         * fbsd-nat.c: Sort headers.
7605         * f-valprint.c: Sort headers.
7606         * f-typeprint.c: Sort headers.
7607         * f-lang.c: Sort headers.
7608         * extension.h: Sort headers.
7609         * extension.c: Sort headers.
7610         * extension-priv.h: Sort headers.
7611         * expprint.c: Sort headers.
7612         * exec.h: Sort headers.
7613         * exec.c: Sort headers.
7614         * exceptions.c: Sort headers.
7615         * event-top.c: Sort headers.
7616         * event-loop.c: Sort headers.
7617         * eval.c: Sort headers.
7618         * elfread.c: Sort headers.
7619         * dwarf2read.h: Sort headers.
7620         * dwarf2read.c: Sort headers.
7621         * dwarf2loc.c: Sort headers.
7622         * dwarf2expr.h: Sort headers.
7623         * dwarf2expr.c: Sort headers.
7624         * dwarf2-frame.c: Sort headers.
7625         * dwarf2-frame-tailcall.c: Sort headers.
7626         * dwarf-index-write.h: Sort headers.
7627         * dwarf-index-write.c: Sort headers.
7628         * dwarf-index-common.c: Sort headers.
7629         * dwarf-index-cache.h: Sort headers.
7630         * dwarf-index-cache.c: Sort headers.
7631         * dummy-frame.c: Sort headers.
7632         * dtrace-probe.c: Sort headers.
7633         * disasm.h: Sort headers.
7634         * disasm.c: Sort headers.
7635         * disasm-selftests.c: Sort headers.
7636         * dictionary.c: Sort headers.
7637         * dicos-tdep.c: Sort headers.
7638         * demangle.c: Sort headers.
7639         * dcache.h: Sort headers.
7640         * dcache.c: Sort headers.
7641         * darwin-nat.h: Sort headers.
7642         * darwin-nat.c: Sort headers.
7643         * darwin-nat-info.c: Sort headers.
7644         * d-valprint.c: Sort headers.
7645         * d-namespace.c: Sort headers.
7646         * d-lang.c: Sort headers.
7647         * ctf.c: Sort headers.
7648         * csky-tdep.c: Sort headers.
7649         * csky-linux-tdep.c: Sort headers.
7650         * cris-tdep.c: Sort headers.
7651         * cris-linux-tdep.c: Sort headers.
7652         * cp-valprint.c: Sort headers.
7653         * cp-support.c: Sort headers.
7654         * cp-namespace.c: Sort headers.
7655         * cp-abi.c: Sort headers.
7656         * corelow.c: Sort headers.
7657         * corefile.c: Sort headers.
7658         * continuations.c: Sort headers.
7659         * completer.h: Sort headers.
7660         * completer.c: Sort headers.
7661         * complaints.c: Sort headers.
7662         * coffread.c: Sort headers.
7663         * coff-pe-read.c: Sort headers.
7664         * cli-out.h: Sort headers.
7665         * cli-out.c: Sort headers.
7666         * charset.c: Sort headers.
7667         * c-varobj.c: Sort headers.
7668         * c-valprint.c: Sort headers.
7669         * c-typeprint.c: Sort headers.
7670         * c-lang.c: Sort headers.
7671         * buildsym.c: Sort headers.
7672         * buildsym-legacy.c: Sort headers.
7673         * build-id.h: Sort headers.
7674         * build-id.c: Sort headers.
7675         * btrace.c: Sort headers.
7676         * bsd-uthread.c: Sort headers.
7677         * breakpoint.h: Sort headers.
7678         * breakpoint.c: Sort headers.
7679         * break-catch-throw.c: Sort headers.
7680         * break-catch-syscall.c: Sort headers.
7681         * break-catch-sig.c: Sort headers.
7682         * blockframe.c: Sort headers.
7683         * block.c: Sort headers.
7684         * bfin-tdep.c: Sort headers.
7685         * bfin-linux-tdep.c: Sort headers.
7686         * bfd-target.c: Sort headers.
7687         * bcache.c: Sort headers.
7688         * ax-general.c: Sort headers.
7689         * ax-gdb.h: Sort headers.
7690         * ax-gdb.c: Sort headers.
7691         * avr-tdep.c: Sort headers.
7692         * auxv.c: Sort headers.
7693         * auto-load.c: Sort headers.
7694         * arm-wince-tdep.c: Sort headers.
7695         * arm-tdep.c: Sort headers.
7696         * arm-symbian-tdep.c: Sort headers.
7697         * arm-pikeos-tdep.c: Sort headers.
7698         * arm-obsd-tdep.c: Sort headers.
7699         * arm-nbsd-tdep.c: Sort headers.
7700         * arm-nbsd-nat.c: Sort headers.
7701         * arm-linux-tdep.c: Sort headers.
7702         * arm-linux-nat.c: Sort headers.
7703         * arm-fbsd-tdep.c: Sort headers.
7704         * arm-fbsd-nat.c: Sort headers.
7705         * arm-bsd-tdep.c: Sort headers.
7706         * arch-utils.c: Sort headers.
7707         * arc-tdep.c: Sort headers.
7708         * arc-newlib-tdep.c: Sort headers.
7709         * annotate.h: Sort headers.
7710         * annotate.c: Sort headers.
7711         * amd64-windows-tdep.c: Sort headers.
7712         * amd64-windows-nat.c: Sort headers.
7713         * amd64-tdep.c: Sort headers.
7714         * amd64-sol2-tdep.c: Sort headers.
7715         * amd64-obsd-tdep.c: Sort headers.
7716         * amd64-obsd-nat.c: Sort headers.
7717         * amd64-nbsd-tdep.c: Sort headers.
7718         * amd64-nbsd-nat.c: Sort headers.
7719         * amd64-nat.c: Sort headers.
7720         * amd64-linux-tdep.c: Sort headers.
7721         * amd64-linux-nat.c: Sort headers.
7722         * amd64-fbsd-tdep.c: Sort headers.
7723         * amd64-fbsd-nat.c: Sort headers.
7724         * amd64-dicos-tdep.c: Sort headers.
7725         * amd64-darwin-tdep.c: Sort headers.
7726         * amd64-bsd-nat.c: Sort headers.
7727         * alpha-tdep.c: Sort headers.
7728         * alpha-obsd-tdep.c: Sort headers.
7729         * alpha-nbsd-tdep.c: Sort headers.
7730         * alpha-mdebug-tdep.c: Sort headers.
7731         * alpha-linux-tdep.c: Sort headers.
7732         * alpha-linux-nat.c: Sort headers.
7733         * alpha-bsd-tdep.c: Sort headers.
7734         * alpha-bsd-nat.c: Sort headers.
7735         * aix-thread.c: Sort headers.
7736         * agent.c: Sort headers.
7737         * addrmap.c: Sort headers.
7738         * ada-varobj.c: Sort headers.
7739         * ada-valprint.c: Sort headers.
7740         * ada-typeprint.c: Sort headers.
7741         * ada-tasks.c: Sort headers.
7742         * ada-lang.c: Sort headers.
7743         * aarch64-tdep.c: Sort headers.
7744         * aarch64-ravenscar-thread.c: Sort headers.
7745         * aarch64-newlib-tdep.c: Sort headers.
7746         * aarch64-linux-tdep.c: Sort headers.
7747         * aarch64-linux-nat.c: Sort headers.
7748         * aarch64-fbsd-tdep.c: Sort headers.
7749         * aarch64-fbsd-nat.c: Sort headers.
7750         * aarch32-linux-nat.c: Sort headers.
7751
7752 2019-04-04  Tom Tromey  <tom@tromey.com>
7753
7754         * varobj.c (varobj_create): Update.
7755         * rust-exp.y (struct rust_parser) <update_innermost_block,
7756         lookup_symbol>: New methods.
7757         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7758         Rename.
7759         (rust_parser::rust_lookup_type)
7760         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7761         * printcmd.c (display_command, do_one_display): Update.
7762         * parser-defs.h (struct parser_state) <parser_state>: Add
7763         "tracker" parameter.
7764         (block_tracker): New member.
7765         (class innermost_block_tracker) <innermost_block_tracker>: Add
7766         "types" parameter.
7767         <reset>: Remove method.
7768         (innermost_block): Don't declare.
7769         (null_post_parser): Update.
7770         * parse.c (innermost_block): Remove global.
7771         (write_dollar_variable): Update.
7772         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7773         Remove "tracker_types" parameter.
7774         (parse_expression): Add "tracker" parameter.
7775         (parse_expression_for_completion): Update.
7776         (null_post_parser): Add "tracker" parameter.
7777         * p-exp.y: Update rules.
7778         * m2-exp.y: Update rules.
7779         * language.h (struct language_defn) <la_post_parser>: Add
7780         "tracker" parameter.
7781         * go-exp.y: Update rules.
7782         * f-exp.y: Update rules.
7783         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7784         parameter.
7785         * d-exp.y: Update rules.
7786         * c-exp.y: Update rules.
7787         * breakpoint.c (set_breakpoint_condition): Create an
7788         innermost_block_tracker.
7789         (watch_command_1): Likewise.
7790         * ada-lang.c (resolve): Add "tracker" parameter.
7791         (resolve_subexp): Likewise.
7792         * ada-exp.y (write_var_from_sym): Update.
7793
7794 2019-04-04  Tom Tromey  <tom@tromey.com>
7795
7796         * type-stack.h: New file.
7797         * type-stack.c: New file.
7798         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7799         type-stack.h.
7800         (insert_into_type_stack, insert_type, push_type, push_type_int)
7801         (insert_type_address_space, pop_type, pop_type_int)
7802         (pop_typelist, pop_type_stack, append_type_stack)
7803         (push_type_stack, get_type_stack, push_typelist)
7804         (follow_type_instance_flags, follow_types): Don't declare.
7805         * parse.c (type_stack): Remove global.
7806         (parse_exp_in_context): Update.
7807         (insert_into_type_stack, insert_type, push_type, push_type_int)
7808         (insert_type_address_space, pop_type, pop_type_int)
7809         (pop_typelist, pop_type_stack, append_type_stack)
7810         (push_type_stack, get_type_stack, push_typelist)
7811         (follow_type_instance_flags, follow_types): Remove (moved to
7812         type-stack.c).
7813         * f-exp.y (type_stack): New global.
7814         Update rules.
7815         (push_kind_type, f_parse): Update.
7816         * d-exp.y (type_stack): New global.
7817         Update rules.
7818         (d_parse): Update.
7819         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7820         Update rules.
7821         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7822         (HFILES_NO_SRCDIR): Add type-stack.h.
7823
7824 2019-04-04  Tom Tromey  <tom@tromey.com>
7825
7826         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7827         (rust_parser::convert_ast_to_expression, rust_parse)
7828         (rust_lex_test_completion, rust_lex_tests): Update.
7829         * parser-defs.h (struct expr_completion_state): New.
7830         (struct parser_state) <parser_state>: Add completion parameter.
7831         <mark_struct_expression, mark_completion_tag>: New methods.
7832         <parse_completion, m_completion_state>: New members.
7833         (prefixify_expression, null_post_parser): Update.
7834         (mark_struct_expression, mark_completion_tag): Don't declare.
7835         * parse.c (parse_completion, expout_last_struct)
7836         (expout_tag_completion_type, expout_completion_name): Remove
7837         globals.
7838         (parser_state::mark_struct_expression)
7839         (parser_state::mark_completion_tag): Now methods.
7840         (prefixify_expression): Add last_struct parameter.
7841         (prefixify_subexp): Likewise.
7842         (parse_exp_1): Update.
7843         (parse_exp_in_context): Add cstate parameter.  Update.
7844         (parse_expression_for_completion): Create an
7845         expr_completion_state.
7846         (null_post_parser): Add "completion" parameter.
7847         * p-exp.y: Update rules.
7848         (yylex): Update.
7849         * language.h (struct language_defn) <la_post_parser>: Add
7850         "completing" parameter.
7851         * go-exp.y: Update rules.
7852         (lex_one_token): Update.
7853         * expression.h (parse_completion): Don't declare.
7854         * d-exp.y: Update rules.
7855         (lex_one_token): Update rules.
7856         * c-exp.y: Update rules.
7857         (lex_one_token): Update.
7858         * ada-lang.c (resolve): Add "parse_completion" parameter.
7859         (resolve_subexp): Likewise.
7860         (ada_resolve_function): Likewise.
7861
7862 2019-04-04  Tom Tromey  <tom@tromey.com>
7863
7864         * parser-defs.h (struct parser_state) <start_arglist,
7865         end_arglist>: New methods.
7866         <arglist_len, m_funcall_chain>: New members.
7867         (arglist_len, start_arglist, end_arglist): Don't declare.
7868         * parse.c (arglist_len, funcall_chain): Remove global.
7869         (start_arglist, end_arglist): Remove functions.
7870         (parse_exp_in_context): Update.
7871         * p-exp.y: Update rules.
7872         * m2-exp.y: Update rules.
7873         * go-exp.y: Update rules.
7874         * f-exp.y: Update rules.
7875         * d-exp.y: Update rules.
7876         * c-exp.y: Update rules.
7877
7878 2019-04-04  Tom Tromey  <tom@tromey.com>
7879
7880         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7881         lex_operator, push_back>: New methods.
7882         Update all rules.
7883         (rust_parser::lex_hex, lex_escape): Rename and update.
7884         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7885         (rust_parser::lex_operator): Rename and update.
7886         (rust_parser::lex_number, rustyylex, rustyyerror)
7887         (rust_lex_test_init, rust_lex_test_sequence)
7888         (rust_lex_test_push_back, rust_lex_tests): Update.
7889         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7890         parameter.
7891         <lexptr, prev_lexptr>: New members.
7892         (lexptr, prev_lexptr): Don't declare.
7893         * parse.c (lexptr, prev_lexptr): Remove globals.
7894         (parse_exp_in_context): Update.
7895         * p-exp.y (yylex, yyerror): Update.
7896         * m2-exp.y (parse_number, yylex, yyerror): Update.
7897         * go-exp.y (lex_one_token, yyerror): Update.
7898         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7899         * d-exp.y (lex_one_token, yyerror): Update.
7900         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7901         (lex_one_token, yyerror): Update.
7902         * ada-lex.l (YY_INPUT): Update.
7903         (rewind_to_char): Update.
7904         * ada-exp.y (yyerror): Update.
7905
7906 2019-04-04  Tom Tromey  <tom@tromey.com>
7907
7908         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7909         * parser-defs.h (struct parser_state) <parser_state>: Add new
7910         parameter.
7911         <comma_terminates>: New member.
7912         (comma_terminates): Don't declare global.
7913         * parse.c (comma_terminates): Remove global.
7914         (parse_exp_in_context): Update.
7915         * p-exp.y (yylex): Update.
7916         * m2-exp.y (yylex): Update.
7917         * go-exp.y (lex_one_token): Update.
7918         * f-exp.y (yylex): Update.
7919         * d-exp.y (lex_one_token): Update.
7920         * c-exp.y (lex_one_token): Update.
7921         * ada-lex.l: Update.
7922
7923 2019-04-04  Tom Tromey  <tom@tromey.com>
7924
7925         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7926         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7927         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7928         * parser-defs.h (paren_depth): Don't declare.
7929         * parse.c (paren_depth): Remove global.
7930         (parse_exp_in_context): Update.
7931         * p-exp.y (paren_depth): New global.
7932         (pascal_parse): Initialize it.
7933         * m2-exp.y (paren_depth): New global.
7934         (m2_parse): Initialize it.
7935         * go-exp.y (paren_depth): New global.
7936         (go_parse): Initialize it.
7937         * f-exp.y (paren_depth): New global.
7938         (f_parse): Initialize it.
7939         * d-exp.y (paren_depth): New global.
7940         (d_parse): Initialize it.
7941         * c-exp.y (paren_depth): New global.
7942         (c_parse): Initialize it.
7943         * ada-lex.l (paren_depth): New global.
7944         (lexer_init): Initialize it.
7945
7946 2019-04-04  Tom Tromey  <tom@tromey.com>
7947
7948         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7949         (rust_parser::convert_ast_to_type)
7950         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7951         * parser-defs.h (struct parser_state) <parser_state>: Add
7952         parameters.  Initialize new members.
7953         <expression_context_block, expression_context_pc>: New members.
7954         * parse.c (expression_context_block, expression_context_pc):
7955         Remove globals.
7956         (parse_exp_in_context): Update.
7957         * p-exp.y: Update all rules.
7958         (yylex): Update.
7959         * m2-exp.y: Update all rules.
7960         (yylex): Update.
7961         * go-exp.y (yylex): Update.
7962         * f-exp.y (yylex): Update.
7963         * d-exp.y: Update all rules.
7964         (yylex): Update.
7965         * c-exp.y: Update all rules.
7966         (lex_one_token, classify_name, yylex, c_parse): Update.
7967         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7968
7969 2019-04-04  Tom Tromey  <tom@tromey.com>
7970
7971         * gdbarch.h, gdbarch.c: Rebuild.
7972         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7973         * stap-probe.h:
7974         (struct stap_parse_info): Replace "parser_state" with
7975         "expr_builder".
7976         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7977         (parser_state): New class.
7978         * parse.c (expr_builder): Rename.
7979         (expr_builder::release): Rename.
7980         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7981         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7982         (write_exp_elt_longcst, write_exp_elt_floatcst)
7983         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7984         (write_exp_string_vector, write_exp_bitstring)
7985         (write_exp_msymbol, mark_struct_expression)
7986         (write_dollar_variable)
7987         (insert_type_address_space, increase_expout_size): Replace
7988         "parser_state" with "expr_builder".
7989         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7990         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7991         "parser_state" with "expr_builder".
7992
7993 2019-04-04  Tom Tromey  <tom@tromey.com>
7994
7995         * rust-exp.y: Replace "parse_language" with method call.
7996         * p-exp.y:
7997         (yylex): Replace "parse_language" with method call.
7998         * m2-exp.y:
7999         (yylex): Replace "parse_language" with method call.
8000         * go-exp.y (classify_name): Replace "parse_language" with method
8001         call.
8002         * f-exp.y (yylex): Replace "parse_language" with method call.
8003         * d-exp.y (lex_one_token): Replace "parse_language" with method
8004         call.
8005         * c-exp.y:
8006         (lex_one_token, classify_name, yylex): Replace "parse_language"
8007         with method call.
8008         * ada-exp.y (find_primitive_type, type_char)
8009         (type_system_address): Replace "parse_language" with method call.
8010
8011 2019-04-04  Tom Tromey  <tom@tromey.com>
8012
8013         * rust-exp.y: Replace "parse_gdbarch" with method call.
8014         * parse.c (write_dollar_variable, insert_type_address_space):
8015         Replace "parse_gdbarch" with method call.
8016         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8017         call.
8018         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8019         call.
8020         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8021         "parse_gdbarch" with method call.
8022         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8023         with method call.
8024         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8025         "parse_gdbarch" with method call.
8026         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8027         "parse_gdbarch" with method call.
8028         * c-exp.y (parse_type, parse_number, classify_name): Replace
8029         "parse_gdbarch" with method call.
8030         * ada-lex.l: Replace "parse_gdbarch" with method call.
8031         * ada-exp.y (parse_type, find_primitive_type, type_char)
8032         (type_system_address): Replace "parse_gdbarch" with method call.
8033
8034 2019-04-04  Tom Tromey  <tom@tromey.com>
8035
8036         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8037         * stap-probe.c (stap_parse_argument): Update.
8038         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8039         initial_size parameter.
8040         * rust-exp.y (rust_lex_tests): Update.
8041         * parse.c (parser_state): Update.
8042         (parse_exp_in_context): Update.
8043         * parser-defs.h (struct parser_state) <parser_state>: Remove
8044         "initial_size" parameter.
8045
8046 2019-04-04  Tom Tromey  <tom@tromey.com>
8047
8048         * parser-defs.h (increase_expout_size): Don't declare.
8049         * parse.c (increase_expout_size): Now static.
8050
8051 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8052
8053         * gnu-nat.c (gnu_nat_target::wait): Fix
8054         target_waitstatus_to_string call.
8055
8056 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8057
8058         * eval.c (evaluate_subexp_standard): Handle internal functions
8059         during Fortran function call handling.
8060
8061 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8062
8063         * NEWS: Mention new internal functions.
8064         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8065         (read_base_type): Use dwarf2_init_complex_target_type.
8066         * value.c (creal_internal_fn): New function.
8067         (cimag_internal_fn): New function.
8068         (_initialize_values): Register new internal functions.
8069
8070 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8071
8072         * infrun.c (stop_all_threads): If debug_infrun, always
8073         trace the wait status after wait_one, using
8074         target_waitstatus_to_string and target_pid_to_str.
8075         (handle_inferior_event): Replace various trace of
8076         wait status kind by a single trace.
8077         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8078         wait status kind image by target_waitstatus_to_string.
8079         * target/waitstatus.c (target_waitstatus_to_string): Fix
8080         obsolete comment.
8081
8082 2019-04-01  Tom Tromey  <tromey@adacore.com>
8083
8084         PR symtab/23331:
8085         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8086
8087 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8088             Pedro Alves  <palves@redhat.com>
8089
8090         * top.c (quit_force): Call 'finalize_values'.
8091         * value.c (finalize_values): New function.
8092         * value.h (finalize_values): Declare.
8093
8094 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8095
8096         * NEWS: Announce $_gdb_major and $_gdb_minor.
8097
8098         * top.c (init_gdb_version_vars): New function.
8099         (gdb_init): Call init_gdb_version_vars.
8100
8101 2019-03-29  Tom Tromey  <tromey@adacore.com>
8102
8103         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8104         help text.  Remove dead code.
8105
8106 2019-03-29  Keith Seitz  <keiths@redhat.com>
8107
8108         From Siddhesh Poyarekar:
8109         * f-lang.h (f77_get_upperbound): Return LONGEST.
8110         (f77_get_lowerbound): Likewise.
8111         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8112         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8113         print them.
8114         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8115         plongest to format print it.
8116         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8117         (f77_get_upperbound): Likewise.
8118         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8119         LOWER_BOUND to LONGEST.
8120         (f77_create_arrayprint_offset_tbl): Likewise.
8121
8122 2019-03-29  Keith Seitz  <keiths@redhat.com>
8123
8124         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8125         %s/pulongest for TYPE_LENGTH instead of %d in format
8126         strings.
8127         * ada-typerint.c (ada_print_type): Likewise.
8128         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8129         * compile/compile-c-support.c (generate_register_struct): Likewise.
8130         * gdbtypes.c (recursive_dump_type): Likewise.
8131         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8132         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8133         instead of %d in format strings.
8134         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8135         to std::min to ULONGEST.
8136         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8137         instead of %d in format strings.
8138         * tracepoint.c (info_scope_command): Likewise.
8139         * typeprint.c (print_offset_data::update)
8140         (print_offset_data::finish): Likewise.
8141         * xtensa-tdep.c (xtensa_store_return_value)
8142         (xtensa_push_dummy_call): Likewise.
8143
8144 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8145
8146         * windows-nat.c (display_selector): Fixed format specifications
8147         for 64-bit Cygwin.
8148
8149 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8150
8151         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8152
8153 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8154
8155         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8156         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8157         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8158         (nios2_linux_init_abi): Install it.
8159
8160 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8161
8162         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8163
8164 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8165
8166         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8167
8168 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8169             Tom Tromey  <tromey@adacore.com>
8170
8171         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8172
8173 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8174
8175         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8176         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8177         method to compute the bounds of range types. Also print "[evaluated]"
8178         if the bounds' values come from a dynamic evaluation.
8179
8180 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8181
8182         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8183         whitespace when pretty printing is on.
8184
8185 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8186
8187         * ppc-linux-nat.c: Add include.
8188
8189 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8190
8191         * NEWS: Mention AArch64 Pointer Authentication.
8192
8193 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8194
8195         * arm-linux-nat.c: Add include.
8196
8197 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8198
8199         * source-cache.c (source_cache::get_source_lines): Re-read
8200         fullname after calling open_source_file.
8201
8202 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8203
8204         * NEWS: Mention TLS support for FreeBSD.
8205
8206 2019-03-25  Tom Tromey  <tromey@adacore.com>
8207
8208         * minsyms.c (BUNCH_SIZE): Update comment.
8209         (~minimal_symbol_reader): Remove old comment.
8210         (compact_minimal_symbols): Update comment.
8211         (minimal_symbol_reader::install): Remove old comment.  Update
8212         other comments.
8213
8214 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8215
8216         * s390-linux-nat.c: Add include.
8217
8218 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8219
8220         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8221         Call linux_get_hwcap.
8222         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8223         Likewise.
8224         (aarch64_linux_get_hwcap): Remove function.
8225         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8226         declaration.
8227         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8228         linux_get_hwcap.
8229         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8230         * linux-tdep.c (linux_get_hwcap): Add function.
8231         (linux_get_hwcap2): Likewise.
8232         * linux-tdep.h (linux_get_hwcap): Add declaration.
8233         (linux_get_hwcap2): Likewise.
8234         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8235         (ppc_linux_get_hwcap2): Likewise.
8236         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8237         linux_get_hwcap.
8238         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8239         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8240         (ppc_linux_nat_target::read_description): Likewise.
8241         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8242         * s390-linux-nat.c: Likewise.
8243         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8244
8245 2019-03-24  Tom Tromey  <tom@tromey.com>
8246
8247         * ada-lang.c (standard_lookup): Simplify initialization.
8248         (ada_lookup_symbol_nonlocal): Simplify return.
8249         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8250         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8251         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8252         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8253         initialization.
8254         * solib.c (solib_global_lookup): Simplify.
8255         * symtab.c (null_block_symbol): Remove.
8256         (symbol_cache_lookup): Simplify returns.
8257         (lookup_language_this): Simplify returns.
8258         (lookup_symbol_aux): Simplify return.
8259         (lookup_local_symbol): Simplify returns.
8260         (lookup_global_symbol_from_objfile): Simplify return.
8261         (lookup_symbol_in_objfile_symtabs)
8262         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8263         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8264         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8265         * cp-namespace.c (cp_lookup_bare_symbol)
8266         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8267         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8268         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8269         (cp_lookup_symbol_via_imports): Simplify initialization.
8270         (find_symbol_in_baseclass): Likewise.
8271         * symtab.h (null_block_symbol): Remove.
8272         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8273         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8274         (d_lookup_symbol_module): Likewise.
8275         (find_symbol_in_baseclass): Simplify initialization.
8276
8277 2019-03-24  Tom Tromey  <tom@tromey.com>
8278
8279         * expression.h: Don't include symtab.h.
8280         (struct block): Forward declare.
8281
8282 2019-03-24  Tom Tromey  <tom@tromey.com>
8283
8284         * c-exp.y (typebase): Remove casts.
8285         * gdbtypes.c (lookup_unsigned_typename, )
8286         (lookup_signed_typename): Remove cast.
8287         * eval.c (parse_to_comma_and_eval): Remove cast.
8288         * parse.c (write_dollar_variable): Remove cast.
8289         * block.h (struct block) <superblock>: Now const.
8290         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8291         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8292         (map_block): Make "block" const.
8293         * symfile.h (struct quick_symbol_functions)
8294         <map_matching_symbols>: Constify block argument to "callback".
8295         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8296         const.
8297         (find_pc_sect_compunit_symtab): Make "b" const.
8298         (find_symbol_at_address): Likewise.
8299         (search_symbols): Likewise.
8300         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8301         (dw2_debug_names_lookup_symbol): Likewise.
8302         (dw2_map_matching_symbols): Update.
8303         * p-valprint.c (pascal_val_print): Remove "block".
8304         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8305         (aux_add_nonlocal_symbols): Make "block" const.
8306         (resolve_subexp): Remove cast.
8307         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8308         const.
8309         (iterate_over_file_blocks): Likewise.
8310         * f-exp.y (%union) <bval>: Remove.
8311         * coffread.c (patch_opaque_types): Make "b" const.
8312         * spu-tdep.c (spu_catch_start): Make "block" const.
8313         * c-valprint.c (print_unpacked_pointer): Remove "block".
8314         * symmisc.c (dump_symtab_1): Make "b" const.
8315         (block_depth): Make "block" const.
8316         * d-exp.y (%union) <bval>: Remove.
8317         * cp-support.h (cp_lookup_rtti_type): Update.
8318         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8319         * psymtab.c (psym_lookup_symbol): Make "block" const.
8320         (maintenance_check_psymtabs): Make "b" const.
8321         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8322         (enumerate_locals, enumerate_args): Update.
8323         * python/py-symtab.c (stpy_global_block): Make "block" const.
8324         (stpy_static_block): Likewise.
8325         * inline-frame.c (block_starting_point_at): Make "new_block"
8326         const.
8327         * block.c (find_block_in_blockvector): Make return type const.
8328         (blockvector_for_pc_sect): Make "b" const.
8329         (find_block_in_blockvector): Make "b" const.
8330
8331 2019-03-23  Tom Tromey  <tom@tromey.com>
8332
8333         * varobj.c (varobj_create): Update.
8334         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8335         * printcmd.c (display_command, do_one_display): Don't reset
8336         innermost_block.
8337         * parser-defs.h (enum innermost_block_tracker_type): Move to
8338         expression.h.
8339         (innermost_block): Update comment.
8340         * parse.c (parse_exp_1): Add tracker_types parameter.
8341         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8342         tracker_types parameter.  Reset innermost_block.
8343         (parse_exp_in_context): Remove.
8344         (parse_expression_for_completion): Update.
8345         * objfiles.c (~objfile): Don't reset expression_context_block or
8346         innermost_block.
8347         * expression.h (enum innermost_block_tracker_type): Move from
8348         parser-defs.h.
8349         (parse_exp_1): Add tracker_types parameter.
8350         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8351         reset innermost_block.
8352
8353 2019-03-23  Tom Tromey  <tom@tromey.com>
8354
8355         * objfiles.h: Include bcache.h.
8356
8357 2019-03-23  Tom Tromey  <tom@tromey.com>
8358
8359         * linespec.c (get_current_search_block): Use
8360         scoped_restore_current_language.
8361         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8362
8363 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8364             Jiong Wang  <jiong.wang@arm.com>
8365
8366         * aarch64-linux-tdep.c
8367         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8368         section.
8369         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8370
8371 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8372             Jiong Wang  <jiong.wang@arm.com>
8373
8374         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8375         instructions.
8376         (aarch64_analyze_prologue_test): Add PACIASP test.
8377         (aarch64_prologue_prev_register): Unmask PC value.
8378
8379 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8380             Jiong Wang  <jiong.wang@arm.com>
8381
8382         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8383         (aarch64_dwarf2_prev_register): Unmask PC value.
8384         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8385         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8386         DW_CFA_AARCH64_negate_ra_state.
8387         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8388
8389 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8390             Jiong Wang  <jiong.wang@arm.com>
8391
8392         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8393         registers.
8394         (aarch64_pseudo_register_name): Likewise.
8395         (aarch64_pseudo_register_type): Likewise.
8396         (aarch64_pseudo_register_reggroup_p): Likewise.
8397         (aarch64_gdbarch_init): Add pauth registers.
8398         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8399         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8400         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8401         (struct gdbarch_tdep): Add regnum for ra_state.
8402
8403 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8404             Jiong Wang  <jiong.wang@arm.com>
8405
8406         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8407
8408 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8409             Jiong Wang  <jiong.wang@arm.com>
8410
8411         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8412         function.
8413         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8414         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8415         (aarch64_gdbarch_init): Add puth registers.
8416         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8417         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8418         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8419
8420 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8421             Jiong Wang  <jiong.wang@arm.com>
8422
8423         * aarch64-linux-nat.c
8424         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8425         * aarch64-linux-tdep.c
8426         (aarch64_linux_core_read_description): Likewise.
8427         (aarch64_linux_get_hwcap): New function.
8428         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8429         (aarch64_linux_get_hwcap): New declaration.
8430
8431 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8432             Jiong Wang  <jiong.wang@arm.com>
8433
8434         * aarch64-linux-nat.c
8435         (aarch64_linux_nat_target::read_description): Add pauth param.
8436         * aarch64-linux-tdep.c
8437         (aarch64_linux_core_read_description): Likewise.
8438         * aarch64-tdep.c (struct target_desc): Add in pauth.
8439         (aarch64_read_description): Add pauth param.
8440         (aarch64_gdbarch_init): Likewise.
8441         * aarch64-tdep.h (aarch64_read_description): Likewise.
8442         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8443         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8444         * features/Makefile: Add new files.
8445         * features/aarch64-pauth.c: New file.
8446         * features/aarch64-pauth.xml: New file.
8447
8448 2019-03-20  Tom Tromey  <tromey@adacore.com>
8449
8450         * infrun.c (handle_inferior_event): Rename from
8451         handle_inferior_event_1.  Create a scoped_value_mark.
8452         (handle_inferior_event): Remove.
8453
8454 2019-03-19  Tom Tromey  <tromey@adacore.com>
8455
8456         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8457         * infrun.h (print_stop_event): Add "displays" parameter.
8458         * infrun.c (print_stop_event): Add "displays" parameter.
8459
8460 2019-03-19  Pedro Alves  <palves@redhat.com>
8461
8462         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8463         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8464         to -1.  Fix TABs vs spaces.
8465         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8466         * tui/tui-out.h (tui_ui_out) Add intro comments.
8467         <m_line, m_start_of_line>: In-class initialize, and add describing
8468         comment.
8469
8470 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8471
8472         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8473         variable names.
8474         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8475
8476 2019-03-18  Pedro Alves  <palves@redhat.com>
8477             Eli Zaretskii <eliz@gnu.org>
8478
8479         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8480         m_line and m_start_of_line.
8481
8482 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8483
8484         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8485         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8486         it returns a newline.  This fixes a regression in TU mode, whereby
8487         the next line is output on the same screen line as the user input.
8488
8489 2019-03-18  Tom Tromey  <tromey@adacore.com>
8490
8491         * minsyms.c (minimal_symbol_reader::install): Remove call to
8492         obstack_blank.
8493
8494 2019-03-18  Pedro Alves  <palves@redhat.com>
8495
8496         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8497         New globals.
8498         (apply_style): New, factored out from ...
8499         (apply_ansi_escape): ... this.  Handle reverse video mode.
8500         (tui_set_reverse_mode): New function.
8501         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8502         * tui/tui-winsource.c (tui_show_source_line): Use
8503         tui_set_reverse_mode instead of setting A_STANDOUT.
8504         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8505         New setter methods.
8506
8507 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8508
8509         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8510         Handle tabs.
8511
8512 2019-03-18  Tom Tromey  <tromey@adacore.com>
8513
8514         * ada-lang.c (empty_array): Add "high" parameter.
8515         (ada_evaluate_subexp): Update.
8516
8517 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8518
8519         * unittests/string_view-selftests.c: Define
8520         _initialize_string_view_selftests unconditionally.
8521
8522 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8523
8524         PR gdb/24350
8525         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8526
8527 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8528
8529         PR gdb/24351
8530         * windows-nat.c (display_selector): Fix format specifiers.
8531
8532 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8533
8534         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8535         tui_refill_source_window instead of tui_refresh_win, to update the
8536         current execution line.  This fixes redisplay of the current line
8537         when stepping through the code with "next" or "step".
8538
8539 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8540
8541         * source-cache.c (source_cache::get_source_lines): Call
8542         find_source_lines to initialize s->nlines.  This fixes vertical
8543         scrolling of TUI source window when the DOWN arrow is pressed.
8544
8545 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8546
8547         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8548         linux-thread-db.c (_initialize_thread_db): Likewise.
8549
8550 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8551
8552         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8553         wclrtoeol in tui_show_source_line".  This reverts changes made in
8554         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8555
8556 2019-03-15  Tom Tromey  <tom@tromey.com>
8557
8558         * symtab.h (struct minimal_symbol): Derive from
8559         general_symbol_info.
8560         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8561         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8562         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8563         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8564         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8565         (MSYMBOL_SEARCH_NAME): Update.
8566         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8567         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8568         * minsyms.c (minimal_symbol_reader::record_full): Update.
8569
8570 2019-03-15  Tom Tromey  <tom@tromey.com>
8571
8572         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8573
8574 2019-03-15  Tom Tromey  <tom@tromey.com>
8575
8576         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8577         unique_xmalloc_ptr.
8578         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8579         Update.
8580         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8581         (build_minimal_symbol_hash_tables)
8582         (minimal_symbol_reader::install): Update.
8583
8584 2019-03-15  Tom Tromey  <tom@tromey.com>
8585
8586         * symtab.c (create_demangled_names_hash): Update.
8587         (symbol_set_names): Update.
8588         * objfiles.h (struct objfile_per_bfd_storage)
8589         <demangled_names_hash>: Now an htab_up.
8590         * objfiles.c (objfile_per_bfd_storage): Simplify.
8591
8592 2019-03-15  Tom Tromey  <tom@tromey.com>
8593
8594         * objfiles.h (struct objfile_per_bfd_storage): Declare
8595         destructor.
8596         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8597         New.
8598         (get_objfile_bfd_data): Use new.  Don't initialize
8599         language_of_main.
8600         (free_objfile_per_bfd_storage): Remove.
8601         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8602
8603 2019-03-15  Tom Tromey  <tom@tromey.com>
8604
8605         * symfile.c (reread_symbols): Update.
8606         * objfiles.c (objfile::objfile): Update.
8607         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8608         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8609         comment.
8610         (minimal_symbol_reader::install): Update.
8611         (terminate_minimal_symbol_table): Remove.
8612         * jit.c (jit_object_close_impl): Update.
8613
8614 2019-03-15  Tom Tromey  <tom@tromey.com>
8615
8616         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8617         initializations.
8618
8619 2019-03-15  Tom Tromey  <tom@tromey.com>
8620
8621         * objfiles.h (struct objfile_per_bfd_storage)
8622         <demangled_hash_languages>: Now a bitset.
8623         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8624         (lookup_minimal_symbol): Update.
8625
8626 2019-03-15  Tom Tromey  <tom@tromey.com>
8627
8628         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8629         Don't return the symbol.
8630         * coffread.c (record_minimal_symbol): Use record_full.
8631
8632 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8633
8634         The MS-Windows port of ncurses fails to switch to a color pair if
8635         one or both of the colors are the implicit default colors.  This
8636         change records the default colors when TUI is initialized, and
8637         then specifies them explicitly when a color pair uses the default
8638         colors.  This allows color styling in TUI mode on MS-Windows.
8639
8640         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8641         ncurses_norm_attr.
8642         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8643         colors in ncurses_norm_attr.
8644         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8645         "none", replace it with the default color recorded in
8646         ncurses_norm_attr.
8647
8648 2019-03-14  Tom Tromey  <tromey@adacore.com>
8649
8650         * source-cache.h (class source_cache) <get_source_lines>: Return
8651         std::string.
8652         * source-cache.c (source_cache::extract_lines): Handle case where
8653         first_pos==npos.  Return std::string.
8654         (source_cache::get_source_lines): Update.
8655
8656 2019-03-14  Tom Tromey  <tromey@adacore.com>
8657
8658         * NEWS: Add item for "style sources" commands.
8659         * source-cache.c (source_cache::get_source_lines): Check
8660         source_styling.
8661         * cli/cli-style.c (source_styling): New global.
8662         (_initialize_cli_style): Add "style sources" commands.
8663         (show_style_sources): New function.
8664         * cli/cli-style.h (source_styling): Declare.
8665
8666 2019-03-14  Pedro Alves  <palves@redhat.com>
8667             Tom Tromey  <tromey@adacore.com>
8668
8669         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8670         * tui/tui-winsource.c (tui_refill_source_window): New function,
8671         from...
8672         (tui_horizontal_source_scroll): ... here.  Move some logic.
8673         * cli/cli-style.c (set_style_enabled): Notify new observable.
8674         * tui/tui-hooks.c (tui_redisplay_source): New function.
8675         (tui_attach_detach_observers): Attach or detach
8676         tui_redisplay_source.
8677         * observable.h (source_styling_changed): New observable.
8678         * observable.c: Define source_styling_changed observable.
8679
8680 2019-03-13  Tom Tromey  <tromey@adacore.com>
8681
8682         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8683         (i386_gnu_nat_target::store_registers): Update.
8684         * target-debug.h (target_debug_print_std_string): New macro.
8685         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8686         * windows-tdep.c (display_one_tib): Update.
8687         * tui/tui-stack.c (tui_make_status_line): Update.
8688         * top.c (print_inferior_quit_action): Update.
8689         * thread.c (thr_try_catch_cmd): Update.
8690         (add_thread_with_info): Update.
8691         (thread_target_id_str): Update.
8692         (thr_try_catch_cmd): Update.
8693         (thread_command): Update.
8694         (thread_find_command): Update.
8695         * record-btrace.c (record_btrace_target::info_record)
8696         (record_btrace_resume_thread, record_btrace_target::resume)
8697         (record_btrace_cancel_resume, record_btrace_step_thread)
8698         (record_btrace_target::wait, record_btrace_target::wait)
8699         (record_btrace_target::wait, record_btrace_target::stop): Update.
8700         * progspace.c (print_program_space): Update.
8701         * process-stratum-target.c
8702         (process_stratum_target::thread_address_space): Update.
8703         * linux-fork.c (linux_fork_mourn_inferior)
8704         (detach_checkpoint_command, info_checkpoints_command)
8705         (linux_fork_context): Update.
8706         (linux_fork_detach): Update.
8707         (class scoped_switch_fork_info): Update.
8708         (delete_checkpoint_command): Update.
8709         * infrun.c (follow_fork_inferior): Update.
8710         (follow_fork_inferior): Update.
8711         (proceed_after_vfork_done): Update.
8712         (handle_vfork_child_exec_or_exit): Update.
8713         (follow_exec): Update.
8714         (displaced_step_prepare_throw): Update.
8715         (displaced_step_restore): Update.
8716         (start_step_over): Update.
8717         (resume_1): Update.
8718         (clear_proceed_status_thread): Update.
8719         (proceed): Update.
8720         (print_target_wait_results): Update.
8721         (do_target_wait): Update.
8722         (context_switch): Update.
8723         (stop_all_threads): Update.
8724         (restart_threads): Update.
8725         (finish_step_over): Update.
8726         (handle_signal_stop): Update.
8727         (switch_back_to_stepped_thread): Update.
8728         (keep_going_pass_signal): Update.
8729         (print_exited_reason): Update.
8730         (normal_stop): Update.
8731         * inferior.c (inferior_pid_to_str): Change return type.
8732         (print_selected_inferior): Update.
8733         (add_inferior): Update.
8734         (detach_inferior): Update.
8735         * dummy-frame.c (fprint_dummy_frames): Update.
8736         * dcache.c (dcache_info_1): Update.
8737         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8738         (btrace_fetch, btrace_clear): Update.
8739         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8740         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8741         type.
8742         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8743         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8744         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8745         * gdbarch.c, gdbarch.h: Rebuild.
8746         * gdbarch.sh (core_pid_to_str): Change return type.
8747         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8748         return type.
8749         (windows_nat_target::pid_to_str): Change return type.
8750         (windows_delete_thread): Update.
8751         (windows_nat_target::attach): Update.
8752         (windows_nat_target::files_info): Update.
8753         * target-delegates.c: Rebuild.
8754         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8755         return type.
8756         (sol_thread_target::pid_to_str): Change return type.
8757         * remote.c (class remote_target) <pid_to_str>: Change return
8758         type.
8759         (remote_target::pid_to_str): Change return type.
8760         (extended_remote_target::attach, remote_target::remote_stop_ns)
8761         (remote_target::remote_notif_remove_queued_reply)
8762         (remote_target::push_stop_reply, remote_target::disable_btrace):
8763         Update.
8764         (extended_remote_target::attach): Update.
8765         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8766         type.
8767         (gdbsim_target::pid_to_str): Change return type.
8768         * ravenscar-thread.c (struct ravenscar_thread_target)
8769         <pid_to_str>: Change return type.
8770         (ravenscar_thread_target::pid_to_str): Change return type.
8771         * procfs.c (class procfs_target) <pid_to_str>: Change return
8772         type.
8773         (procfs_target::pid_to_str): Change return type.
8774         (procfs_target::attach): Update.
8775         (procfs_target::detach): Update.
8776         (procfs_target::fetch_registers): Update.
8777         (procfs_target::store_registers): Update.
8778         (procfs_target::wait): Update.
8779         (procfs_target::files_info): Update.
8780         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8781         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8782         return type.
8783         (nto_procfs_target::pid_to_str): Change return type.
8784         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8785         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8786         return type.
8787         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8788         (exit_lwp): Update.
8789         (attach_proc_task_lwp_callback, get_detach_signal)
8790         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8791         (linux_nat_target::resume, wait_lwp, stop_callback)
8792         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8793         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8794         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8795         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8796         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8797         type.
8798         (inf_ptrace_target::attach): Update.
8799         (inf_ptrace_target::files_info): Update.
8800         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8801         type.
8802         (go32_nat_target::pid_to_str): Change return type.
8803         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8804         (gnu_nat_target::wait): Update.
8805         (gnu_nat_target::wait): Update.
8806         (gnu_nat_target::resume): Update.
8807         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8808         (fbsd_nat_target::wait): Update.
8809         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8810         type.
8811         (darwin_nat_target::attach): Update.
8812         * corelow.c (class core_target) <pid_to_str>: Change return type.
8813         (core_target::pid_to_str): Change return type.
8814         * target.c (normal_pid_to_str): Change return type.
8815         (default_pid_to_str): Likewise.
8816         (target_pid_to_str): Change return type.
8817         (target_translate_tls_address): Update.
8818         (target_announce_detach): Update.
8819         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8820         return type.
8821         (bsd_uthread_target::pid_to_str): Change return type.
8822         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8823         type.
8824         (bsd_kvm_target::pid_to_str): Change return type.
8825         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8826         return type.
8827         (aix_thread_target::pid_to_str): Change return type.
8828         * target.h (struct target_ops) <pid_to_str>: Change return type.
8829         (target_pid_to_str, normal_pid_to_str): Likewise.
8830         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8831         type.
8832         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8833         type.
8834         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8835         return type.
8836         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8837         type.
8838         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8839         type.
8840         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8841         return type.
8842
8843 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8844
8845         * NEWS: Mention that the new default MI version is 3.  Mention
8846         changes to the output of commands and events that deal with
8847         multi-location breakpoints.
8848         * breakpoint.c: Include "mi/mi-out.h".
8849         (print_one_breakpoint): Change output syntax if using MI version
8850         >= 3.
8851         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8852         New.
8853         (mi_multi_location_breakpoint_output_fixed): New.
8854         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8855         (mi_cmd_fix_multi_location_breakpoint_output): New.
8856         (mi_multi_location_breakpoint_output_fixed): New.
8857         * mi/mi-cmds.c (mi_cmds): Register command
8858         -fix-multi-location-breakpoint-output.
8859         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8860         interpreter "mi".
8861
8862 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8863
8864         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8865         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8866         instantiate mi_ui_out based on interpreter name.
8867         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8868         * mi/mi-main.c (mi_load_progress): Likewise.
8869
8870 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8871
8872         * NEWS: Combine separate "New targets" sections for 8.3.
8873
8874 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8875
8876         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8877         (ppcfbsd_init_abi): Install gdbarch
8878         "fetch_tls_load_module_address" and "get_thread_local_address"
8879         methods.
8880
8881 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8882
8883         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8884         (riscv_fbsd_init_abi): Install gdbarch
8885         "fetch_tls_load_module_address" and "get_thread_local_address"
8886         methods.
8887
8888 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8889
8890         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8891         (i386fbsd_init_abi): Install gdbarch
8892         "fetch_tls_load_module_address" and "get_thread_local_address"
8893         methods.
8894
8895 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8896
8897         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8898         (amd64fbsd_init_abi): Install gdbarch
8899         "fetch_tls_load_module_address" and "get_thread_local_address"
8900         methods.
8901
8902 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8903
8904         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8905         (struct fbsd_pspace_data): New type.
8906         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8907         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8908         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8909         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8910         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8911
8912 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8913
8914         * gdbtypes.c (lookup_struct_elt): New function.
8915         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8916         * gdbtypes.h (struct struct_elt): New type.
8917         (lookup_struct_elt): New prototype.
8918
8919 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8920
8921         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8922         remove disabled code block.
8923
8924 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8925
8926         * gdbarch.sh (get_thread_local_address): New method.
8927         * gdbarch.h, gdbarch.c: Regenerate.
8928         * target.c (target_translate_tls_address): Use
8929         gdbarch_get_thread_local_address if present instead of
8930         target::get_thread_local_address.
8931
8932 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8933
8934         * target.h (target::get_thread_local_address): Update comment.
8935
8936 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8937
8938         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8939         objfile->separate_debug_objfile_backlink if not NULL.
8940
8941 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8942
8943         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8944         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8945         (amd64bsd_store_inferior_registers): Likewise.
8946         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8947         Enable segment base registers.
8948         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8949         PT_GETFSBASE and PT_GETGSBASE.
8950         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8951         PT_SETGSBASE.
8952         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8953         segment base registers.
8954         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8955
8956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8957
8958         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8959         Update calls to i386_target_description to add 'segments'
8960         parameter.
8961         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8962         add segment base registers.
8963         * arch/i386.c (i386_create_target_description): Add 'segments'
8964         parameter to enable segment base registers.
8965         * arch/i386.h (i386_create_target_description): Likewise.
8966         * features/i386/32bit-segments.xml: New file.
8967         * features/i386/32bit-segments.c: Generate.
8968         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8969         call to i386_target_description to add 'segments' parameter.
8970         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8971         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8972         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8973         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8974         if feature is present.
8975         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8976         Add 'segments' parameter to call to i386_target_description.
8977         (i386_target_description): Add 'segments' parameter to enable
8978         segment base registers.
8979         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8980         to call to i386_target_description.
8981         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8982         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8983         Define I386_NUM_REGS.
8984         (i386_target_description): Add 'segments' parameter to enable
8985         segment base registers.
8986
8987 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8988
8989         PR/24325
8990         * source-cache.c: #undef open and close, to avoid unresolved
8991         externals during linking.
8992
8993 2019-03-12  Tom Tromey  <tromey@adacore.com>
8994
8995         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8996         const.  Add initializers.
8997         (_initialize_remote): Don't initialize ptid globals.
8998
8999 2019-03-12  Pedro Alves  <palves@redhat.com>
9000
9001         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9002
9003 2019-03-12  Pedro Alves  <palves@redhat.com>
9004
9005         * cp-name-parser.y (main): Remove unused 'len' variable.
9006
9007 2019-03-12  Tom Tromey  <tromey@adacore.com>
9008
9009         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9010         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9011
9012 2019-03-12  Tom Tromey  <tromey@adacore.com>
9013
9014         * linux-nat.c (iterate_over_lwps): Update.
9015         (stop_callback): Remove parameter.
9016         (stop_wait_callback, detach_callback, resume_set_callback)
9017         (select_singlestep_lwp_callback, set_ignore_sigint)
9018         (status_callback, resumed_callback, resume_clear_callback)
9019         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9020         data parameter.
9021         (linux_nat_target::detach, linux_nat_target::resume)
9022         (linux_stop_and_wait_all_lwps, select_event_lwp)
9023         (linux_nat_filter_event, linux_nat_wait_1)
9024         (linux_nat_target::kill, linux_nat_target::stop)
9025         (linux_nat_target::stop): Update.
9026         (linux_nat_resume_callback): Change type.
9027         (resume_stopped_resumed_lwps, count_events_callback)
9028         (select_event_lwp_callback): Likewise.
9029         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9030         * arm-linux-nat.c (struct update_registers_data): Remove.
9031         (update_registers_callback): Change type.
9032         (arm_linux_insert_hw_breakpoint1): Update.
9033         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9034         parameter.
9035         (x86_linux_dr_set_addr): Update.
9036         (x86_linux_dr_set_control): Update.
9037         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9038         (iterate_over_lwps): Use gdb::function_view.
9039         * nat/aarch64-linux-hw-point.c (struct
9040         aarch64_dr_update_callback_param): Remove.
9041         (debug_reg_change_callback): Change type.
9042         (aarch64_notify_debug_reg_change): Update.
9043         * s390-linux-nat.c (s390_refresh_per_info): Update.
9044
9045 2019-03-11  Tom Tromey  <tromey@adacore.com>
9046
9047         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9048         redundant assignment to "this_cu".
9049
9050 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9051
9052         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9053
9054 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9055
9056         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9057         from...
9058         (rank_one_type): ... this.
9059
9060 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9061
9062         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9063         from...
9064         (rank_one_type): ... this.
9065
9066 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9067
9068         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9069         from...
9070         (rank_one_type): ... this.
9071
9072 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9073
9074         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9075         from...
9076         (rank_one_type): ... this.
9077
9078 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9079
9080         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9081         from...
9082         (rank_one_type): ... this.
9083
9084 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9085
9086         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9087         from...
9088         (rank_one_type): ... this.
9089
9090 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9091
9092         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9093         from...
9094         (rank_one_type): ... this.
9095
9096 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9097
9098         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9099         from...
9100         (rank_one_type): ... this.
9101
9102 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9103
9104         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9105         from...
9106         (rank_one_type): ... this.
9107
9108 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9109
9110         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9111         from...
9112         (rank_one_type): ... this.
9113
9114 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9115
9116         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9117         from...
9118         (rank_one_type): ... this.
9119
9120 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9121
9122         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9123         from...
9124         (rank_one_type): ... this.
9125
9126 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9127
9128         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9129         inferior-events' shows the example events.
9130
9131 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9132
9133         Support styling on native MS-Windows console
9134
9135         PR/24315
9136         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9137         on MS-Windows if $TERM is not defined.
9138
9139         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9140
9141         * posix-hdep.c (gdb_console_fputs):
9142         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9143         functions.
9144         * ui-file.h (gdb_console_fputs): Add prototype.
9145
9146         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9147         back to fputs only if the former returns zero.
9148
9149 2019-03-07  Tom Tromey  <tom@tromey.com>
9150
9151         * symmisc.c (print_symbol_bcache_statistics): Update.
9152         (print_objfile_statistics): Update.
9153         * symfile.c (allocate_symtab): Update.
9154         * stabsread.c: Don't include bcache.h.
9155         * psymtab.h (struct psymbol_bcache): Don't declare.
9156         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9157         (psymbol_bcache_init, psymbol_bcache_free)
9158         (psymbol_bcache_get_bcache): Don't declare.
9159         * psymtab.c (struct psymbol_bcache): Remove.
9160         (psymtab_storage::psymtab_storage): Update.
9161         (psymtab_storage::~psymtab_storage): Update.
9162         (psymbol_bcache_init, psymbol_bcache_free)
9163         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9164         (add_psymbol_to_bcache): Update.
9165         (allocate_psymtab): Update.
9166         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9167         macro_cache>: No longer pointers.
9168         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9169         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9170         * macrotab.c (macro_bcache): Update.
9171         * macroexp.c: Don't include bcache.h.
9172         * gdbtypes.c (check_types_worklist): Update.
9173         (types_deeply_equal): Remove TRY/CATCH.  Update.
9174         * elfread.c (elf_symtab_read): Update.
9175         * dwarf2read.c: Don't include bcache.h.
9176         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9177         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9178         (print_bcache_statistics, bcache_memory_used): Don't declare.
9179         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9180         methods.  Rename all data members.
9181         * bcache.c (struct bcache): Move to bcache.h.
9182         (bcache::expand_hash_table): Rename from expand_hash_table.
9183         (bcache): Remove.
9184         (bcache::insert): Rename from bcache_full.
9185         (bcache::compare): Rename from bcache_compare.
9186         (bcache_xmalloc): Remove.
9187         (bcache::~bcache): Rename from bcache_xfree.
9188         (bcache::print_statistics): Rename from print_bcache_statistics.
9189         (bcache::memory_used): Rename from bcache_memory_used.
9190
9191 2019-03-07  Pedro Alves  <palves@redhat.com>
9192
9193         * infrun.c (normal_stop): Also check for
9194         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9195
9196 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9197
9198         * f-lang.c (value_from_host_double): Moved to...
9199         * value.c (value_from_host_double): ...here.
9200         * value.h (value_from_host_double): Declare.
9201         * guile/scm-math.c (vlscm_convert_typed_number): Use
9202         value_from_host_double.
9203         (vlscm_convert_number): Likewise.
9204         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9205         * python/py-value.c (convert_value_from_python): Likewise.
9206
9207 2019-03-06  Tom Tromey  <tom@tromey.com>
9208
9209         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9210
9211 2019-03-06  Tom Tromey  <tom@tromey.com>
9212
9213         * utils.h (free_current_contents): Don't declare.
9214         * utils.c (free_current_contents): Remove.
9215
9216 2019-03-06  Tom Tromey  <tom@tromey.com>
9217
9218         * top.c (quit_force): Update.
9219         * main.c (captured_command_loop): Update.
9220         * common/new-op.c (operator new): Update.
9221         * common/common-exceptions.c (struct catcher)
9222         <save_cleanup_chain>: Remove member.
9223         (exceptions_state_mc_init): Update.
9224         (exception_try_scope_entry): Return nullptr.
9225         (exception_try_scope_exit, exception_rethrow)
9226         (throw_exception_sjlj, throw_exception_cxx): Update.
9227         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9228         (all_cleanups, do_cleanups, discard_cleanups)
9229         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9230         (restore_cleanups, restore_final_cleanups): Don't declare.
9231         (do_final_cleanups): Remove parameter.
9232         * common/cleanups.c (cleanup_chain, make_cleanup)
9233         (make_cleanup_dtor, all_cleanups, do_cleanups)
9234         (discard_my_cleanups, discard_cleanups)
9235         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9236         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9237         (null_cleanup): Remove.
9238         (do_final_cleanups): Remove parameter.
9239
9240 2019-03-06  Tom Tromey  <tom@tromey.com>
9241
9242         * remote.c (remote_target::remote_parse_stop_reply): Use
9243         unique_xmalloc_ptr.
9244
9245 2019-03-06  Tom Tromey  <tom@tromey.com>
9246
9247         * stabsread.c (struct stabs_field_info): Rename from field_info.
9248         <list, fnlist>: Add initializers.
9249         <obstack>: New member.
9250         (read_member_functions, read_struct_fields, read_baseclasses):
9251         Allocate on obstack.  Don't use cleanups.
9252         (read_one_struct_field, read_member_functions, read_struct_fields)
9253         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9254         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9255         (read_struct_type): Update.
9256
9257 2019-03-06  Tom Tromey  <tom@tromey.com>
9258
9259         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9260         * common/filestuff.h (make_cleanup_close): Don't declare.
9261         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9262         Remove.
9263
9264 2019-03-06  Tom Tromey  <tom@tromey.com>
9265
9266         * solib-aix.c: Use make_scope_exit.
9267
9268 2019-03-06  Tom Tromey  <tom@tromey.com>
9269
9270         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9271         Use make_scope_exit.
9272
9273 2019-03-06  Tom Tromey  <tom@tromey.com>
9274
9275         * solib-svr4.c (disable_probes_interface): Remove parameter.
9276         (svr4_handle_solib_event): Use make_scope_exit.
9277
9278 2019-03-06  Tom Tromey  <tom@tromey.com>
9279
9280         * remote.c (struct stop_reply_deleter): Remove.
9281         (stop_reply_up): Update.
9282         (struct stop_reply): Derive from notif_event.  Don't typedef.
9283         <regcache>: Now a std::vector.
9284         (stop_reply_xfree): Remove.
9285         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9286         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9287         (remote_target::discard_pending_stop_replies): Use delete.
9288         (remote_target::remote_parse_stop_reply): Update.
9289         (remote_target::process_stop_reply): Update.
9290         * remote-notif.h (struct notif_event): Add virtual destructor.
9291         Remove "dtr" member.
9292         (struct notif_client) <alloc_event>: Return a unique_ptr.
9293         (notif_event_xfree): Don't declare.
9294         (notif_event_up): New typedef.
9295         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9296         (notif_event_xfree, do_notif_event_xfree): Remove.
9297         (remote_notif_state_xfree): Update.
9298
9299 2019-03-06  Tom Tromey  <tom@tromey.com>
9300
9301         * infrun.c (displaced_step_clear_cleanup): Now a
9302         forward_scope_exit type.
9303         (displaced_step_prepare_throw): Update.
9304         (displaced_step_fixup): Update.
9305
9306 2019-03-06  Tom Tromey  <tom@tromey.com>
9307
9308         * inferior.h (class inferior): Update comment.
9309         * gdbthread.h (class thread_info): Update comment.
9310
9311 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9312             Tom Tromey  <tom@tromey.com>
9313
9314         * stabsread.h (struct stab_section_list): Remove.
9315         (coffstab_build_psymtabs): Update.
9316         * dbxread.c (symbuf_sections): Now a std::vector.
9317         (sect_idx): New global.
9318         (fill_symbuf): Update.
9319         (coffstab_build_psymtabs): Change type of stabsects parameter.
9320         Update.
9321         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9322         std::vector.
9323         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9324         (coff_locate_sections): Update.
9325         (coff_symfile_read): Remove cleanups.  Update.
9326         (init_stringtab): Add storage parameter.
9327         (free_stringtab, free_stringtab_cleanup): Remove.
9328         (init_lineno): Add storage parameter.
9329         (free_linetab, free_linetab_cleanup): Remove.
9330
9331 2019-03-06  Pedro Alves  <palves@redhat.com>
9332
9333         * linux-fork.c (fork_info::clobber_regs): Delete.
9334         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9335         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9336         comment.  Adjust.
9337         (scoped_switch_fork_info::scoped_switch_fork_info)
9338         (checkpoint_command, linux_fork_context): Adjust
9339         fork_save_infrun_state calls.
9340
9341 2019-03-06  Pedro Alves  <palves@redhat.com>
9342
9343         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9344         (inf_has_multiple_threads): Return 'bool' and rewrite using
9345         inferior_info::threads().
9346
9347 2019-03-06  Pedro Alves  <palves@redhat.com>
9348
9349         * linux-fork.c: Include <list>.
9350         (fork_list): Now a std::list instance.
9351         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9352         (forks_exist_p, find_last_fork): Adjust.
9353         (new_fork): Delete.
9354         (one_fork_p): New.
9355         (add_fork): Adjust.
9356         (free_fork): Delete, folded into fork_info::~fork_info().
9357         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9358         Adjust.
9359         (init_fork_list): Delete.
9360         (linux_fork_killall, linux_fork_mourn_inferior)
9361         (linux_fork_detach, info_checkpoints_command): Adjust.
9362         (_initialize_linux_fork): No longer call init_fork_list.
9363
9364 2019-03-06  Pedro Alves  <palves@redhat.com>
9365
9366         * linux-fork.c (new_fork): New, split out of ...
9367         (add_fork): ... this.  Return void.  Move "first fork" special
9368         case from here, to ...
9369         (checkpoint_command): ... here.
9370         * linux-linux.h (add_fork): Return void.
9371
9372 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9375
9376 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9377             Chris January  <chris.january@arm.com>
9378             David Lecomber  <david.lecomber@arm.com>
9379
9380         * f-exp.y: New token, UNOP_INTRINSIC.
9381         (exp): New pattern using UNOP_INTRINSIC token.
9382         (f77_keywords): Add 'abs' keyword.
9383         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9384         (value_from_host_double): New function.
9385         (evaluate_subexp_f): Support UNOP_ABS.
9386
9387 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9388
9389         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9390         types.
9391
9392 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9393
9394         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9395         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9396         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9397
9398 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9399
9400         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9401
9402 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9403             Chris January  <chris.january@arm.com>
9404
9405         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9406         * f-exp.y: Define 'KIND' token.
9407         (exp): New pattern for KIND expressions.
9408         (ptype): Handle types with a kind extension.
9409         (direct_abs_decl): Extend to spot kind extensions.
9410         (f77_keywords): Add 'kind' to the list.
9411         (push_kind_type): New function.
9412         (convert_to_kind_type): New function.
9413         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9414         * parse.c (operator_length_standard): Likewise.
9415         * parser-defs.h (enum type_pieces): Add tp_kind.
9416         * std-operator.def: Add UNOP_KIND.
9417
9418 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9419
9420         * f-exp.y (f_parse): Set yydebug.
9421
9422 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9423
9424         * f-lang.c (evaluate_subexp_f): New function.
9425         (exp_descriptor_f): New global.
9426         (f_language_defn): Use exp_descriptor_f instead of
9427         exp_descriptor_standard.
9428
9429 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9430
9431         * f-exp.y (struct token): Add comments.
9432         (dot_ops): Remove uppercase versions and the end marker.
9433         (f77_keywords): Likewise.
9434         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9435         entries in the dot_ops array are case insensitive, and use
9436         strncasecmp to compare strings.  Also some whitespace cleanup in
9437         this area.  Similar for the f77_keywords array, except entries in
9438         this list might be case sensitive.
9439
9440 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9441
9442         * f-exp.y (struct f77_boolean_val): Add comments.
9443         (boolean_values): Remove uppercase versions, and end marker.
9444         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9445         and use strncasecmp to achieve case insensitivity.  Additionally,
9446         perform whitespace cleanup around this code.
9447
9448 2019-03-06  Tom Tromey  <tromey@adacore.com>
9449
9450         * remote-sim.c (gdbsim_target_open): Use result of
9451         gdb_argv::release.
9452
9453 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9454         Dirk Schubert  <dirk.schubert@arm.com>
9455         Chris January  <chris.january@arm.com>
9456
9457         * eval.c (evaluate_subexp_standard): Call Fortran argument
9458         wrapping logic.
9459         * f-lang.c (struct value): A value which can be passed into a
9460         Fortran function call.
9461         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9462         where appropriate.
9463         (struct type): Value ready for a Fortran function call.
9464         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9465         is needed.
9466         * f-lang.h (fortran_argument_convert): Declaration.
9467         (fortran_preserve_arg_pointer): Declaration.
9468         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9469
9470 2019-03-05  Tom Tromey  <tromey@adacore.com>
9471
9472         * python/py-prettyprint.c (print_string_repr): Remove #if.
9473         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9474
9475 2019-03-05  Tom Tromey  <tromey@adacore.com>
9476
9477         * target.c (the_dummy_target): Move later.  Change type to
9478         "dummy_target".
9479         (initialize_targets): Don't initialize the_dummy_target.
9480
9481 2019-03-05  Tom Tromey  <tromey@adacore.com>
9482
9483         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9484         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9485
9486 2019-03-05  Tom Tromey  <tromey@adacore.com>
9487
9488         * windows-nat.c (windows_nat_target::attach)
9489         (windows_nat_target::detach): Don't call gdb_flush.
9490         * valprint.c (generic_val_print, val_print, val_print_string):
9491         Don't call gdb_flush.
9492         * utils.c (defaulted_query): Don't call gdb_flush.
9493         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9494         * target.c (target_announce_detach): Don't call gdb_flush.
9495         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9496         * remote.c (extended_remote_target::attach): Don't call
9497         gdb_flush.
9498         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9499         * printcmd.c (do_examine): Don't call gdb_flush.
9500         (info_display_command): Don't call gdb_flush.
9501         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9502         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9503         * memattr.c (info_mem_command): Don't call gdb_flush.
9504         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9505         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9506         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9507         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9508         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9509         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9510         (gnu_nat_target::detach): Don't call gdb_flush.
9511         * f-valprint.c (f_val_print): Don't call gdb_flush.
9512         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9513         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9514         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9515         gdb_flush.
9516         * c-valprint.c (c_val_print): Don't call gdb_flush.
9517         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9518
9519 2019-03-05  Tom Tromey  <tromey@adacore.com>
9520
9521         * varobj.c (update_dynamic_varobj_children): Update.
9522         (install_default_visualizer): Use reset, not release.
9523         * value.c (set_internalvar): Update.
9524         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9525         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9526         ATTRIBUTE_UNUSED_RESULT.
9527
9528 2019-03-05  Tom Tromey  <tromey@adacore.com>
9529
9530         * remote.c (class scoped_remote_fd) <release>: Add
9531         ATTRIBUTE_UNUSED_RESULT.
9532
9533 2019-03-05  Tom Tromey  <tromey@adacore.com>
9534
9535         * macroexp.c (struct macro_buffer) <release>: Add
9536         ATTRIBUTE_UNUSED_RESULT.
9537
9538 2019-03-05  Tom Tromey  <tromey@adacore.com>
9539
9540         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9541         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9542         ATTRIBUTE_UNUSED_RESULT.
9543
9544 2019-03-05  Tom Tromey  <tromey@adacore.com>
9545
9546         * common/scoped_fd.h (class scoped_fd) <release>: Add
9547         ATTRIBUTE_UNUSED_RESULT.
9548
9549 2019-03-05  Tom Tromey  <tromey@adacore.com>
9550
9551         * parser-defs.h (struct parser_state) <release>: Add
9552         ATTRIBUTE_UNUSED_RESULT.
9553
9554 2019-03-05  Tom Tromey  <tromey@adacore.com>
9555
9556         * utils.h (class gdb_argv) <release>: Add
9557         ATTRIBUTE_UNUSED_RESULT.
9558         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9559
9560 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9561
9562         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9563         for-loop range, to avoid compiler warnings.
9564
9565         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9566         avoid compiler warnings about unused variables.
9567
9568         * NEWS: Mention end of support for native debugging on MS-Windows
9569         before XP.
9570
9571         PR gdb/24292
9572         * common/netstuff.c:
9573         * gdbserver/gdbreplay.c
9574         * gdbserver/remote-utils.c:
9575         * ser-tcp.c:
9576         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9577         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9578         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9579         'getaddrinfo' and 'freeaddrinfo' were not available before
9580         Windows XP, and mingw.org's MinGW headers by default define
9581         _WIN32_WINNT to 0x500.
9582
9583 2019-03-01  Gary Benson <gbenson@redhat.com>
9584
9585         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9586
9587 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9588             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9589
9590         PR gdb/8527
9591         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9592         set_sigint_trap, clear_sigint_trap.
9593
9594 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9595
9596         * target.c (target_detach): Clear the regcache and the
9597         frame cache.
9598
9599 2019-02-27  Pedro Alves  <palves@redhat.com>
9600
9601         * utils.c (set_screen_size): When we cap the height/width sizes,
9602         tweak the corresponding command variable to show "unlimited":
9603
9604 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9605             Pedro Alves  <palves@redhat.com>
9606
9607         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9608         before calling rl_set_screen_size.
9609
9610 2019-02-27  Tom Tromey  <tromey@adacore.com>
9611
9612         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9613         define.
9614         * python/py-value.c: Remove Python 2.4 workaround.
9615         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9616         workaround.
9617         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9618         Python 2.4 workaround.
9619         * python/python-internal.h: Remove Python 2.4 comment.
9620         (Py_ssize_t): Don't define.
9621         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9622         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9623         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9624         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9625         * python/python.c (do_start_initialization): Remove Python 2.4
9626         workaround.
9627         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9628         (print_children): Remove Python 2.4 workaround.
9629         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9630         workaround.
9631         (CHARBUFFERPROC_NAME): Remove.
9632         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9633         Python 2.4 workaround.
9634
9635 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9636
9637         * NEWS: Note minimum Python version.
9638
9639 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9640
9641         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9642         code from these functions.  Remove corresponding ifdefs.  Use
9643         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9644         Remove gotos and target of gotos.
9645         (infpy_search_memory): Likewise.
9646
9647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9648
9649         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9650         (hppa_gdbarch_init): Don't register deleted functions with
9651         gdbarch.
9652
9653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9654
9655         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9656         (h8300_unwind_sp): Delete.
9657         (h8300_dummy_id): Delete.
9658         (h8300_gdbarch_init): Don't register deleted functions with
9659         gdbarch.
9660
9661 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9662
9663         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9664         (ft32_unwind_pc): Delete.
9665         (ft32_unwind_sp): Delete.
9666         (ft32_gdbarch_init): Don't register deleted functions with
9667         gdbarch.
9668
9669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9670
9671         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9672         (frv_unwind_pc): Delete.
9673         (frv_unwind_sp): Delete.
9674         (frv_gdbarch_init): Don't register deleted functions with
9675         gdbarch.
9676
9677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9678
9679         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9680         (riscv_unwind_pc): Delete.
9681         (riscv_unwind_sp): Delete.
9682         (riscv_gdbarch_init): Don't register deleted functions with
9683         gdbarch.
9684
9685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9686
9687         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9688         (csky_unwind_pc): Delete.
9689         (csky_unwind_sp): Delete.
9690         (csky_gdbarch_init): Don't register deleted functions with
9691         gdbarch.
9692
9693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9694
9695         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9696         (cris_unwind_pc): Delete.
9697         (cris_unwind_sp): Delete.
9698         (cris_gdbarch_init): Don't register deleted functions with
9699         gdbarch.
9700
9701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9702
9703         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9704         (bfin_unwind_pc): Delete.
9705         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9706
9707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9708
9709         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9710         (arm_unwind_pc): Delete.
9711         (arm_unwind_sp): Delete.
9712         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9713
9714 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9715
9716         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9717         (arc_unwind_pc): Delete.
9718         (arc_unwind_sp): Delete.
9719         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9720
9721 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9722
9723         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9724         (alpha_unwind_pc): Delete.
9725         (alpha_gdbarch_init): Don't register deleted functions with
9726         gdbarch.
9727
9728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9729
9730         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9731         (aarch64_unwind_pc): Delete.
9732         (aarch64_unwind_sp): Delete.
9733         (aarch64_gdbarch_init): Don't register deleted functions with
9734         gdbarch.
9735
9736 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9737
9738         * gdbtypes.c (type_align): Don't consider static members when
9739         computing structure alignment.
9740
9741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9742
9743         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9744         return 0 for other types.
9745         * arch-utils.c (default_type_align): Always return 0.
9746         * gdbarch.h: Regenerate.
9747         * gdbarch.sh (type_align): Extend comment.
9748         * gdbtypes.c (type_align): Add additional comments, always call
9749         gdbarch_type_align before applying the default rules.
9750         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9751         generic code will then apply a suitable default.
9752         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9753         types, return 0 for other types.
9754
9755 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9756
9757         * NEWS: Create a new section for the next release branch.
9758         Rename the section of the current branch, now that it has
9759         been cut.
9760
9761 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9762
9763         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9764         * version.in: Bump version to 8.3.50.DATE-git.
9765
9766 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9767
9768         * aix-thread.c (ptid_cmp): Remove unused variable.
9769         (get_signaled_thread): Likewise.
9770         (store_regs_user_thread): Likewise.
9771         (store_regs_kernel_thread): Likewise.
9772         (fetch_regs_kernel_thread): Remove shadowed variable.
9773
9774 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9775
9776         * features/riscv/32bit-cpu.xml: Add register numbers.
9777         * features/riscv/32bit-fpu.c: Regenerate.
9778         * features/riscv/32bit-fpu.xml: Add register numbers.
9779         * features/riscv/64bit-cpu.xml: Add register numbers.
9780         * features/riscv/64bit-fpu.c: Regenerate.
9781         * features/riscv/64bit-fpu.xml: Add register numbers.
9782
9783 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9784
9785         * NEWS: Mention two argument form of gdb.Value constructor.
9786         * python/py-value.c (convert_buffer_and_type_to_value): New
9787         function.
9788         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9789         Add support for handling an optional second argument.  Call
9790         convert_buffer_and_type_to_value as appropriate.
9791         * python/python-internal.h (Py_buffer_deleter): New struct.
9792         (Py_buffer_up): New typedef.
9793
9794 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9795
9796         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9797         instead of releasing ownership.
9798
9799 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9800
9801         * dwarf2read.c (open_and_init_dwp_file): Call
9802         elf_numsections instead of bfd_count_sections to initialize
9803         dwp_file->num_sections.
9804
9805 2019-02-25  Tom Tromey  <tromey@adacore.com>
9806
9807         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9808
9809 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9810
9811         * gcore.in: Add '--readnever' option when invoking GDB.
9812
9813 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9814
9815         * MAINTAINERS: Update my email address.
9816
9817 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9818
9819         * build-id.c (build_id_to_debug_bfd_1): New function.
9820         (build_id_to_debug_bfd): Look for separate debug file in
9821         sysroot.
9822
9823 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9824
9825         * gdbarch.sh: Update the copyright year range that is placed into
9826         generated files.
9827
9828 2019-02-22  Keith Seitz  <keiths@redhat.com>
9829
9830         PR symtab/23853
9831         * linespec.c (create_sals_line_offset): Search for the default
9832         symtab's filename instead of its fullname.
9833
9834 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9835
9836         * NEWS: Update style defaults.
9837
9838 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9839
9840         * main.c (captured_main_1): Disable styling in batch mode.
9841
9842 2019-02-20  Tom Tromey  <tom@tromey.com>
9843
9844         * symtab.c (symtab_symbol_info): Fix typos.
9845
9846 2019-02-20  Tom Tromey  <tromey@adacore.com>
9847
9848         * findcmd.c (_initialize_mem_search): Use upper case for
9849         metasyntactic variables.
9850
9851 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9852
9853         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9854         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9855
9856 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9857
9858         * top.h (source_file_name): Change to std::string.
9859         * top.c (source_file_name): Likewise.
9860         (command_line_input): Adjust.
9861         * cli/cli-script.c (script_from_file): Adjust.
9862
9863 2019-02-19  Tom Tromey  <tromey@adacore.com>
9864
9865         * ravenscar-thread.c
9866         (ravenscar_thread_target::update_thread_list): Don't call
9867         ada_build_task_list.
9868         * ada-lang.h (ada_build_task_list): Don't declare.
9869         * ada-tasks.c (struct ada_tasks_inferior_data)
9870         <task_list_valid_p>: Now bool.
9871         (read_known_tasks, ada_task_list_changed)
9872         (ada_tasks_invalidate_inferior_data): Update.
9873         (read_known_tasks_array): Return bool.
9874         (read_known_tasks_list): Likewise.
9875         (read_known_tasks): Return void.
9876         (ada_build_task_list): Now static.
9877
9878 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9879
9880         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9881         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9882
9883 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9884
9885         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9886         variant for ada_tasks_pspace_data_handle and
9887         ada_tasks_inferior_data_handle.
9888         (ada_tasks_pspace_data_cleanup): New function.
9889         (ada_tasks_inferior_data_cleanup): New function.
9890
9891 2019-02-17  Tom Tromey  <tom@tromey.com>
9892
9893         * macrotab.h (macro_source_fullname): Return a std::string.
9894         * macrotab.c (macro_include, check_for_redefinition)
9895         (macro_undef, macro_lookup_definition, foreach_macro)
9896         (foreach_macro_in_scope): Update.
9897         (macro_source_fullname): Return a std::string.
9898         * macrocmd.c (show_pp_source_pos): Update.
9899
9900 2019-02-17  Tom Tromey  <tom@tromey.com>
9901
9902         * macrocmd.c (show_pp_source_pos): Style the file names.
9903
9904 2019-02-17  Tom Tromey  <tom@tromey.com>
9905
9906         PR tui/24197:
9907         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9908
9909 2019-02-17  Tom Tromey  <tom@tromey.com>
9910
9911         * ada-lang.c (user_select_syms): Use filtered printing.
9912         * utils.c (wrap_style): New global.
9913         (desired_style): Remove.
9914         (emit_style_escape): Add stream parameter.
9915         (set_output_style, reset_terminal_style, prompt_for_continue):
9916         Update.
9917         (flush_wrap_buffer): Only flush gdb_stdout.
9918         (wrap_here): Set wrap_style.
9919         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9920         treat escape sequences as a character.  Change when wrap buffer is
9921         flushed.
9922         (fputs_styled): Do not set the output style when the default is
9923         requested.
9924         * ui-style.h (struct ui_file_style) <is_default>: New method.
9925         * source.c (print_source_lines_base): Emit escape sequences in one
9926         piece.
9927
9928 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9929
9930         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9931         integers and enumeration types.
9932
9933 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9934
9935         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9936         instead of lookup_symbol_in_language
9937         (do_exact_match): New function.
9938         (ada_get_symbol_name_matcher): Return do_exact_match when
9939         doing a verbatim match.
9940
9941 2019-02-15  Tom Tromey  <tromey@adacore.com>
9942
9943         * ravenscar-thread.c (ravenscar_thread_target::resume)
9944         (ravenscar_thread_target::wait): Special case wildcard requests.
9945
9946 2019-02-15  Tom Tromey  <tromey@adacore.com>
9947
9948         * ravenscar-thread.c (base_ptid): Remove.
9949         (struct ravenscar_thread_target) <close>: New method.
9950         <m_base_ptid>: New member.
9951         <update_inferior_ptid, active_task, task_is_currently_active,
9952         runtime_initialized>: Declare methods.
9953         <ravenscar_thread_target>: Add constructor.
9954         (ravenscar_thread_target::task_is_currently_active)
9955         (ravenscar_thread_target::update_inferior_ptid)
9956         (ravenscar_runtime_initialized): Rename.  Now methods.
9957         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9958         (ravenscar_thread_target::update_thread_list): Update.
9959         (ravenscar_thread_target::active_task): Now method.
9960         (ravenscar_thread_target::store_registers)
9961         (ravenscar_thread_target::prepare_to_store)
9962         (ravenscar_thread_target::prepare_to_store)
9963         (ravenscar_thread_target::mourn_inferior): Update.
9964         (ravenscar_inferior_created): Use "new" to create target.
9965         (ravenscar_thread_target::get_ada_task_ptid): Update.
9966         (_initialize_ravenscar): Don't initialize base_ptid.
9967         (ravenscar_ops): Remove global.
9968
9969 2019-02-15  Tom Tromey  <tromey@adacore.com>
9970
9971         * target.h (push_target): Declare new overload.
9972         * target.c (push_target): New overload, taking an rvalue reference.
9973         * remote.c (remote_target::open_1): Use push_target overload.
9974         * corelow.c (core_target_open): Use push_target overload.
9975
9976 2019-02-15  Tom Tromey  <tromey@adacore.com>
9977
9978         * ravenscar-thread.c (is_ravenscar_task)
9979         (ravenscar_task_is_currently_active): Return bool.
9980         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9981         (_initialize_ravenscar): Remove "(void)".
9982         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9983         Return bool.
9984
9985 2019-02-15  Tom Tromey  <tromey@adacore.com>
9986
9987         * ravenscar-thread.c (ravenscar_runtime_initializer)
9988         (has_ravenscar_runtime, get_running_thread_id)
9989         (ravenscar_thread_target::resume): Fix indentation.
9990
9991 2019-02-15  Tom Tromey  <tromey@adacore.com>
9992
9993         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9994         from ravenscar_arch_ops.
9995         (sparc_ravenscar_ops::fetch_registers)
9996         (sparc_ravenscar_ops::store_registers): Now methods.
9997         (sparc_ravenscar_prepare_to_store): Remove.
9998         (sparc_ravenscar_ops): Redefine.
9999         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10000         methods and destructor.  Remove members.
10001         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10002         (ravenscar_thread_target::store_registers)
10003         (ravenscar_thread_target::prepare_to_store): Update.
10004         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10005         Remove.
10006         (struct ppc_ravenscar_powerpc_ops): Derive from
10007         ravenscar_arch_ops.
10008         (ppc_ravenscar_powerpc_ops::fetch_registers)
10009         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10010         (ppc_ravenscar_powerpc_ops): Redefine.
10011         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10012         (ppc_ravenscar_e500_ops::fetch_registers)
10013         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10014         (ppc_ravenscar_e500_ops): Redefine.
10015         * aarch64-ravenscar-thread.c
10016         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10017         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10018         (aarch64_ravenscar_fetch_registers)
10019         (aarch64_ravenscar_store_registers): Now methods.
10020         (aarch64_ravenscar_ops): Redefine.
10021
10022 2019-02-15  Tom Tromey  <tromey@adacore.com>
10023
10024         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10025         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10026         (ravenscar_thread_target::stopped_by_watchpoint)
10027         (ravenscar_thread_target::stopped_data_address)
10028         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10029
10030 2019-02-15  Tom Tromey  <tromey@adacore.com>
10031
10032         * ravenscar-thread.c: Fix some typos.
10033
10034 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10035             Tom Tromey  <tromey@adacore.com>
10036
10037         * ada-lang.c (ada_exception_sal): Change addr_string to a
10038         std::string.
10039         (create_ada_exception_catchpoint): Update.
10040
10041 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10042             Tom Tromey  <tromey@adacore.com>
10043
10044         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10045         (bp_location_ops): Remove.
10046         (base_breakpoint_allocate_location): Update.
10047         (free_bp_location): Update.
10048         * ada-lang.c (class ada_catchpoint_location)
10049         <ada_catchpoint_location>: Remove ops parameter.
10050         (ada_catchpoint_location_dtor): Remove.
10051         (ada_catchpoint_location_ops): Remove.
10052         (allocate_location_exception): Update.
10053         * breakpoint.h (struct bp_location_ops): Remove.
10054         (class bp_location) <bp_location>: Remove bp_location_ops
10055         parameter.
10056         <~bp_location>: Add destructor.
10057         <ops>: Remove.
10058
10059 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10060             Pedro Alves  <palves@redhat.com>
10061
10062         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10063         'PATH_MAX'.
10064
10065 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10066             Samuel Thibault  <samuel.thibault@gnu.org>
10067             Thomas Schwinge  <thomas@codesourcery.com>
10068
10069         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10070         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10071
10072 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10073
10074         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10075         (check_empty): Use "const char *".
10076
10077         * gnu-nat.c (gnu_nat_target::detach): Instead of
10078         'detach_inferior (pid)' call
10079         'detach_inferior (find_inferior_pid (pid))'.
10080
10081         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10082         'nat/fork-inferior.o'.
10083         * gnu-nat.c: #include "nat/fork-inferior.h".
10084
10085         * gnu-nat.c (gnu_nat_target::detach): Instead of
10086         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10087         * gnu-nat.h: #include "inf-child.h".
10088         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10089         'i386_gnu_nat_target::fetch_registers'.
10090         (gnu_store_registers): Rename/move to
10091         'i386_gnu_nat_target::store_registers'.
10092
10093         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10094         * gnu-nat.h (mach_thread_info): New function.
10095         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10096
10097         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10098
10099 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10100
10101         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10102
10103 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10104
10105         * windows-nat.c (windows_add_thread): Add new parameter
10106         "main_thread_p" with default value set to false.  Update
10107         function documentation as well as all callers.
10108         (windows_delete_thread): Likewise.
10109         (fake_create_process): Update call to windows_add_thread.
10110         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10111         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10112         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10113         call to windows_delete_thread.
10114
10115 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10116
10117         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10118
10119 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10120
10121         * symfile.c (find_separate_debug_file): Use canonical path of
10122         sysroot with child_path instead of gdb_sysroot if it is valid.
10123
10124 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10125
10126         * symfile.c (find_separate_debug_file): Use child_path to
10127         determine if an object file is under a sysroot.
10128
10129 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10130
10131         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10132         unittests/child-path-selftests.c.
10133         * common/pathstuff.c (child_path): New function.
10134         * common/pathstuff.h (child_path): New prototype.
10135         * unittests/child-path-selftests.c: New file.
10136
10137 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10138
10139         * symfile.c (find_separate_debug_file): Look for separate debug
10140         files in debug directories under the sysroot.
10141
10142 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10143
10144         * symtab.h (struct minimal_symbol data_p): New const method.
10145         (struct minimal_symbol text_p): Likewise.
10146         * symtab.c (output_source_filename): Use file name style
10147         to print file name.
10148         (print_symbol_info): Likewise.
10149         (print_msymbol_info): Use address style to print addresses.
10150         Use function name style to print executable text symbols.
10151         (expand_symtab_containing_pc): Use data_p.
10152         (find_pc_sect_compunit_symtab): Likewise.
10153
10154 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10155
10156         * breakpoint.c (describe_other_breakpoints): Use address style
10157         to print addresses.
10158         (say_where): Likewise.
10159
10160 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10161
10162         * ada-typeprint.c (print_func_type): Print function name
10163         style to print function name.
10164         * c-typeprint.c (c_print_type_1): Likewise.
10165
10166 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10167
10168         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10169         for execve.
10170
10171 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10172
10173         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10174         type_stack.
10175
10176 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10177
10178         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10179         TYPE_CODE_REF types.
10180
10181 2019-02-08  Jim Wilson  <jimw@sifive.com>
10182
10183         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10184         (riscv_linux_fregset): New.
10185         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10186
10187 2019-02-07  Tom Tromey  <tom@tromey.com>
10188
10189         * thread.c (thread_cancel_execution_command): Update.
10190         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10191         methods.
10192         (struct thread_fsm_ops): Remove.
10193         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10194         (thread_fsm_should_stop, thread_fsm_return_value)
10195         (thread_fsm_set_finished, thread_fsm_finished_p)
10196         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10197         Don't declare.
10198         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10199         * infrun.c (clear_proceed_status_thread)
10200         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10201         (print_stop_event): Update.
10202         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10203         Add constructor.
10204         (step_command_fsm_ops): Remove.
10205         (new_step_command_fsm): Remove.
10206         (step_1): Update.
10207         (step_command_fsm::should_stop): Rename from
10208         step_command_fsm_should_stop.
10209         (step_command_fsm::clean_up): Rename from
10210         step_command_fsm_clean_up.
10211         (step_command_fsm::do_async_reply_reason): Rename from
10212         step_command_fsm_async_reply_reason.
10213         (struct until_next_fsm): Inherit from thread_fsm.  Add
10214         constructor.
10215         (until_next_fsm_ops): Remove.
10216         (new_until_next_fsm): Remove.
10217         (until_next_fsm::should_stop): Rename from
10218         until_next_fsm_should_stop.
10219         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10220         (until_next_fsm::do_async_reply_reason): Rename from
10221         until_next_fsm_async_reply_reason.
10222         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10223         constructor.  Change type of breakpoint.
10224         (finish_command_fsm_ops): Remove.
10225         (new_finish_command_fsm): Remove.
10226         (finish_command_fsm::should_stop): Rename from
10227         finish_command_fsm_should_stop.
10228         (finish_command_fsm::clean_up): Rename from
10229         finish_command_fsm_clean_up.
10230         (finish_command_fsm::return_value): Rename from
10231         finish_command_fsm_return_value.
10232         (finish_command_fsm::do_async_reply_reason): Rename from
10233         finish_command_fsm_async_reply_reason.
10234         (finish_command): Update.
10235         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10236         Add constructor.
10237         (call_thread_fsm_ops): Remove.
10238         (call_thread_fsm::call_thread_fsm): Rename from
10239         new_call_thread_fsm.
10240         (call_thread_fsm::should_stop): Rename from
10241         call_thread_fsm_should_stop.
10242         (call_thread_fsm::should_notify_stop): Rename from
10243         call_thread_fsm_should_notify_stop.
10244         (run_inferior_call, call_function_by_hand_dummy): Update.
10245         * cli/cli-interp.c (should_print_stop_to_console): Update.
10246         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10247         Add constructor.  Change type of location_breakpoint,
10248         caller_breakpoint.
10249         (until_break_fsm_ops): Remove.
10250         (new_until_break_fsm): Remove.
10251         (until_break_fsm::should_stop): Rename from
10252         until_break_fsm_should_stop.
10253         (until_break_fsm::clean_up): Rename from
10254         until_break_fsm_clean_up.
10255         (until_break_fsm::do_async_reply_reason): Rename from
10256         until_break_fsm_async_reply_reason.
10257         (until_break_command): Update.
10258         * thread-fsm.c: Remove.
10259         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10260
10261 2019-02-07  Tom Tromey  <tom@tromey.com>
10262
10263         * yy-remap.h: Add include guard.
10264         * xtensa-tdep.h: Add include guard.
10265         * xcoffread.h: Rename include guard.
10266         * varobj-iter.h: Add include guard.
10267         * tui/tui.h: Rename include guard.
10268         * tui/tui-winsource.h: Rename include guard.
10269         * tui/tui-wingeneral.h: Rename include guard.
10270         * tui/tui-windata.h: Rename include guard.
10271         * tui/tui-win.h: Rename include guard.
10272         * tui/tui-stack.h: Rename include guard.
10273         * tui/tui-source.h: Rename include guard.
10274         * tui/tui-regs.h: Rename include guard.
10275         * tui/tui-out.h: Rename include guard.
10276         * tui/tui-layout.h: Rename include guard.
10277         * tui/tui-io.h: Rename include guard.
10278         * tui/tui-hooks.h: Rename include guard.
10279         * tui/tui-file.h: Rename include guard.
10280         * tui/tui-disasm.h: Rename include guard.
10281         * tui/tui-data.h: Rename include guard.
10282         * tui/tui-command.h: Rename include guard.
10283         * tic6x-tdep.h: Add include guard.
10284         * target/waitstatus.h: Rename include guard.
10285         * target/wait.h: Rename include guard.
10286         * target/target.h: Rename include guard.
10287         * target/resume.h: Rename include guard.
10288         * target-float.h: Rename include guard.
10289         * stabsread.h: Add include guard.
10290         * rs6000-tdep.h: Add include guard.
10291         * riscv-fbsd-tdep.h: Add include guard.
10292         * regformats/regdef.h: Rename include guard.
10293         * record.h: Rename include guard.
10294         * python/python.h: Rename include guard.
10295         * python/python-internal.h: Rename include guard.
10296         * python/py-stopevent.h: Rename include guard.
10297         * python/py-ref.h: Rename include guard.
10298         * python/py-record.h: Rename include guard.
10299         * python/py-record-full.h: Rename include guard.
10300         * python/py-record-btrace.h: Rename include guard.
10301         * python/py-instruction.h: Rename include guard.
10302         * python/py-events.h: Rename include guard.
10303         * python/py-event.h: Rename include guard.
10304         * procfs.h: Add include guard.
10305         * proc-utils.h: Add include guard.
10306         * p-lang.h: Add include guard.
10307         * or1k-tdep.h: Rename include guard.
10308         * observable.h: Rename include guard.
10309         * nto-tdep.h: Rename include guard.
10310         * nat/x86-linux.h: Rename include guard.
10311         * nat/x86-linux-dregs.h: Rename include guard.
10312         * nat/x86-gcc-cpuid.h: Add include guard.
10313         * nat/x86-dregs.h: Rename include guard.
10314         * nat/x86-cpuid.h: Rename include guard.
10315         * nat/ppc-linux.h: Rename include guard.
10316         * nat/mips-linux-watch.h: Rename include guard.
10317         * nat/linux-waitpid.h: Rename include guard.
10318         * nat/linux-ptrace.h: Rename include guard.
10319         * nat/linux-procfs.h: Rename include guard.
10320         * nat/linux-osdata.h: Rename include guard.
10321         * nat/linux-nat.h: Rename include guard.
10322         * nat/linux-namespaces.h: Rename include guard.
10323         * nat/linux-btrace.h: Rename include guard.
10324         * nat/glibc_thread_db.h: Rename include guard.
10325         * nat/gdb_thread_db.h: Rename include guard.
10326         * nat/gdb_ptrace.h: Rename include guard.
10327         * nat/fork-inferior.h: Rename include guard.
10328         * nat/amd64-linux-siginfo.h: Rename include guard.
10329         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10330         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10331         * nat/aarch64-linux.h: Rename include guard.
10332         * nat/aarch64-linux-hw-point.h: Rename include guard.
10333         * mn10300-tdep.h: Add include guard.
10334         * mips-linux-tdep.h: Add include guard.
10335         * mi/mi-parse.h: Rename include guard.
10336         * mi/mi-out.h: Rename include guard.
10337         * mi/mi-main.h: Rename include guard.
10338         * mi/mi-interp.h: Rename include guard.
10339         * mi/mi-getopt.h: Rename include guard.
10340         * mi/mi-console.h: Rename include guard.
10341         * mi/mi-common.h: Rename include guard.
10342         * mi/mi-cmds.h: Rename include guard.
10343         * mi/mi-cmd-break.h: Rename include guard.
10344         * m2-lang.h: Add include guard.
10345         * location.h: Rename include guard.
10346         * linux-record.h: Rename include guard.
10347         * linux-nat.h: Add include guard.
10348         * linux-fork.h: Add include guard.
10349         * i386-darwin-tdep.h: Rename include guard.
10350         * hppa-linux-offsets.h: Add include guard.
10351         * guile/guile.h: Rename include guard.
10352         * guile/guile-internal.h: Rename include guard.
10353         * gnu-nat.h: Rename include guard.
10354         * gdb-stabs.h: Rename include guard.
10355         * frv-tdep.h: Add include guard.
10356         * f-lang.h: Add include guard.
10357         * event-loop.h: Add include guard.
10358         * darwin-nat.h: Rename include guard.
10359         * cp-abi.h: Rename include guard.
10360         * config/sparc/nm-sol2.h: Rename include guard.
10361         * config/nm-nto.h: Rename include guard.
10362         * config/nm-linux.h: Add include guard.
10363         * config/i386/nm-i386gnu.h: Rename include guard.
10364         * config/djgpp/nl_types.h: Rename include guard.
10365         * config/djgpp/langinfo.h: Rename include guard.
10366         * compile/gcc-cp-plugin.h: Add include guard.
10367         * compile/gcc-c-plugin.h: Add include guard.
10368         * compile/compile.h: Rename include guard.
10369         * compile/compile-object-run.h: Rename include guard.
10370         * compile/compile-object-load.h: Rename include guard.
10371         * compile/compile-internal.h: Rename include guard.
10372         * compile/compile-cplus.h: Rename include guard.
10373         * compile/compile-c.h: Rename include guard.
10374         * common/xml-utils.h: Rename include guard.
10375         * common/x86-xstate.h: Rename include guard.
10376         * common/version.h: Rename include guard.
10377         * common/vec.h: Rename include guard.
10378         * common/tdesc.h: Rename include guard.
10379         * common/selftest.h: Rename include guard.
10380         * common/scoped_restore.h: Rename include guard.
10381         * common/scoped_mmap.h: Rename include guard.
10382         * common/scoped_fd.h: Rename include guard.
10383         * common/safe-iterator.h: Rename include guard.
10384         * common/run-time-clock.h: Rename include guard.
10385         * common/refcounted-object.h: Rename include guard.
10386         * common/queue.h: Rename include guard.
10387         * common/ptid.h: Rename include guard.
10388         * common/print-utils.h: Rename include guard.
10389         * common/preprocessor.h: Rename include guard.
10390         * common/pathstuff.h: Rename include guard.
10391         * common/observable.h: Rename include guard.
10392         * common/netstuff.h: Rename include guard.
10393         * common/job-control.h: Rename include guard.
10394         * common/host-defs.h: Rename include guard.
10395         * common/gdb_wait.h: Rename include guard.
10396         * common/gdb_vecs.h: Rename include guard.
10397         * common/gdb_unlinker.h: Rename include guard.
10398         * common/gdb_unique_ptr.h: Rename include guard.
10399         * common/gdb_tilde_expand.h: Rename include guard.
10400         * common/gdb_sys_time.h: Rename include guard.
10401         * common/gdb_string_view.h: Rename include guard.
10402         * common/gdb_splay_tree.h: Rename include guard.
10403         * common/gdb_setjmp.h: Rename include guard.
10404         * common/gdb_ref_ptr.h: Rename include guard.
10405         * common/gdb_optional.h: Rename include guard.
10406         * common/gdb_locale.h: Rename include guard.
10407         * common/gdb_assert.h: Rename include guard.
10408         * common/filtered-iterator.h: Rename include guard.
10409         * common/filestuff.h: Rename include guard.
10410         * common/fileio.h: Rename include guard.
10411         * common/environ.h: Rename include guard.
10412         * common/common-utils.h: Rename include guard.
10413         * common/common-types.h: Rename include guard.
10414         * common/common-regcache.h: Rename include guard.
10415         * common/common-inferior.h: Rename include guard.
10416         * common/common-gdbthread.h: Rename include guard.
10417         * common/common-exceptions.h: Rename include guard.
10418         * common/common-defs.h: Rename include guard.
10419         * common/common-debug.h: Rename include guard.
10420         * common/cleanups.h: Rename include guard.
10421         * common/buffer.h: Rename include guard.
10422         * common/btrace-common.h: Rename include guard.
10423         * common/break-common.h: Rename include guard.
10424         * cli/cli-utils.h: Rename include guard.
10425         * cli/cli-style.h: Rename include guard.
10426         * cli/cli-setshow.h: Rename include guard.
10427         * cli/cli-script.h: Rename include guard.
10428         * cli/cli-interp.h: Rename include guard.
10429         * cli/cli-decode.h: Rename include guard.
10430         * cli/cli-cmds.h: Rename include guard.
10431         * charset-list.h: Add include guard.
10432         * buildsym-legacy.h: Rename include guard.
10433         * bfin-tdep.h: Add include guard.
10434         * ax.h: Rename include guard.
10435         * arm-linux-tdep.h: Add include guard.
10436         * arm-fbsd-tdep.h: Add include guard.
10437         * arch/xtensa.h: Rename include guard.
10438         * arch/tic6x.h: Add include guard.
10439         * arch/i386.h: Add include guard.
10440         * arch/arm.h: Rename include guard.
10441         * arch/arm-linux.h: Rename include guard.
10442         * arch/arm-get-next-pcs.h: Rename include guard.
10443         * arch/amd64.h: Add include guard.
10444         * arch/aarch64-insn.h: Rename include guard.
10445         * arch-utils.h: Rename include guard.
10446         * annotate.h: Add include guard.
10447         * amd64-darwin-tdep.h: Rename include guard.
10448         * aarch64-linux-tdep.h: Add include guard.
10449         * aarch64-fbsd-tdep.h: Add include guard.
10450         * aarch32-linux-nat.h: Add include guard.
10451
10452 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10453
10454         * macrotab.c (macro_define_internal): New function that
10455         factorizes macro_define_object_internal and macro_define_function
10456         code.
10457         (macro_define_object_internal): Use macro_define_internal.
10458         (macro_define_function): Likewise.
10459
10460 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10461
10462         * macrocmd.c (extract_identifier): Return
10463         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10464         callers.
10465
10466 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10467
10468         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10469
10470 2019-02-05  Tom Tromey  <tom@tromey.com>
10471
10472         * target.c (target_stack::unpush): Move assertion earlier.
10473
10474 2019-01-30  Tom Tromey  <tom@tromey.com>
10475
10476         PR python/23615:
10477         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10478         (gdbpy_parse_and_eval): Likewise.
10479         * python/python-internal.h (gdbpy_allow_threads): New class.
10480
10481 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10482
10483         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10484         (aarch64_fbsd_fpregmap): Move earlier.
10485         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10486         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10487         instead of individual calls to trad_frame_set_reg_addr.
10488         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10489         earlier.
10490         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10491         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10492         instead of individual calls to trad_frame_set_reg_addr.
10493
10494 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10495
10496         * CONTRIBUTE: Replace contribution list with wiki link.
10497
10498 2019-01-25  Tom Tromey  <tom@tromey.com>
10499
10500         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10501
10502 2019-01-25  Tom Tromey  <tom@tromey.com>
10503
10504         * xtensa-linux-nat.c: Fix common/ includes.
10505         * xml-support.h: Fix common/ includes.
10506         * xml-support.c: Fix common/ includes.
10507         * x86-linux-nat.c: Fix common/ includes.
10508         * windows-nat.c: Fix common/ includes.
10509         * varobj.h: Fix common/ includes.
10510         * varobj.c: Fix common/ includes.
10511         * value.c: Fix common/ includes.
10512         * valops.c: Fix common/ includes.
10513         * utils.c: Fix common/ includes.
10514         * unittests/xml-utils-selftests.c: Fix common/ includes.
10515         * unittests/utils-selftests.c: Fix common/ includes.
10516         * unittests/unpack-selftests.c: Fix common/ includes.
10517         * unittests/tracepoint-selftests.c: Fix common/ includes.
10518         * unittests/style-selftests.c: Fix common/ includes.
10519         * unittests/string_view-selftests.c: Fix common/ includes.
10520         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10521         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10522         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10523         * unittests/rsp-low-selftests.c: Fix common/ includes.
10524         * unittests/parse-connection-spec-selftests.c: Fix common/
10525         includes.
10526         * unittests/optional-selftests.c: Fix common/ includes.
10527         * unittests/offset-type-selftests.c: Fix common/ includes.
10528         * unittests/observable-selftests.c: Fix common/ includes.
10529         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10530         * unittests/memrange-selftests.c: Fix common/ includes.
10531         * unittests/memory-map-selftests.c: Fix common/ includes.
10532         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10533         * unittests/function-view-selftests.c: Fix common/ includes.
10534         * unittests/environ-selftests.c: Fix common/ includes.
10535         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10536         * unittests/common-utils-selftests.c: Fix common/ includes.
10537         * unittests/cli-utils-selftests.c: Fix common/ includes.
10538         * unittests/array-view-selftests.c: Fix common/ includes.
10539         * ui-file.c: Fix common/ includes.
10540         * tui/tui-io.c: Fix common/ includes.
10541         * tracepoint.h: Fix common/ includes.
10542         * tracepoint.c: Fix common/ includes.
10543         * tracefile-tfile.c: Fix common/ includes.
10544         * top.h: Fix common/ includes.
10545         * top.c: Fix common/ includes.
10546         * thread.c: Fix common/ includes.
10547         * target/waitstatus.h: Fix common/ includes.
10548         * target/waitstatus.c: Fix common/ includes.
10549         * target.h: Fix common/ includes.
10550         * target.c: Fix common/ includes.
10551         * target-memory.c: Fix common/ includes.
10552         * target-descriptions.c: Fix common/ includes.
10553         * symtab.h: Fix common/ includes.
10554         * symfile.c: Fix common/ includes.
10555         * stap-probe.c: Fix common/ includes.
10556         * spu-linux-nat.c: Fix common/ includes.
10557         * sparc-nat.c: Fix common/ includes.
10558         * source.c: Fix common/ includes.
10559         * solib.c: Fix common/ includes.
10560         * solib-target.c: Fix common/ includes.
10561         * ser-unix.c: Fix common/ includes.
10562         * ser-tcp.c: Fix common/ includes.
10563         * ser-pipe.c: Fix common/ includes.
10564         * ser-base.c: Fix common/ includes.
10565         * selftest-arch.c: Fix common/ includes.
10566         * s12z-tdep.c: Fix common/ includes.
10567         * rust-exp.y: Fix common/ includes.
10568         * rs6000-aix-tdep.c: Fix common/ includes.
10569         * riscv-tdep.c: Fix common/ includes.
10570         * remote.c: Fix common/ includes.
10571         * remote-notif.h: Fix common/ includes.
10572         * remote-fileio.h: Fix common/ includes.
10573         * remote-fileio.c: Fix common/ includes.
10574         * regcache.h: Fix common/ includes.
10575         * regcache.c: Fix common/ includes.
10576         * record-btrace.c: Fix common/ includes.
10577         * python/python.c: Fix common/ includes.
10578         * python/py-type.c: Fix common/ includes.
10579         * python/py-inferior.c: Fix common/ includes.
10580         * progspace.h: Fix common/ includes.
10581         * producer.c: Fix common/ includes.
10582         * procfs.c: Fix common/ includes.
10583         * proc-api.c: Fix common/ includes.
10584         * printcmd.c: Fix common/ includes.
10585         * ppc-linux-nat.c: Fix common/ includes.
10586         * parser-defs.h: Fix common/ includes.
10587         * osdata.c: Fix common/ includes.
10588         * obsd-nat.c: Fix common/ includes.
10589         * nat/x86-linux.c: Fix common/ includes.
10590         * nat/x86-linux-dregs.c: Fix common/ includes.
10591         * nat/x86-dregs.h: Fix common/ includes.
10592         * nat/x86-dregs.c: Fix common/ includes.
10593         * nat/ppc-linux.c: Fix common/ includes.
10594         * nat/mips-linux-watch.h: Fix common/ includes.
10595         * nat/mips-linux-watch.c: Fix common/ includes.
10596         * nat/linux-waitpid.c: Fix common/ includes.
10597         * nat/linux-ptrace.h: Fix common/ includes.
10598         * nat/linux-ptrace.c: Fix common/ includes.
10599         * nat/linux-procfs.c: Fix common/ includes.
10600         * nat/linux-personality.c: Fix common/ includes.
10601         * nat/linux-osdata.c: Fix common/ includes.
10602         * nat/linux-namespaces.c: Fix common/ includes.
10603         * nat/linux-btrace.h: Fix common/ includes.
10604         * nat/linux-btrace.c: Fix common/ includes.
10605         * nat/fork-inferior.c: Fix common/ includes.
10606         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10607         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10608         * nat/aarch64-linux.c: Fix common/ includes.
10609         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10610         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10611         * namespace.h: Fix common/ includes.
10612         * mips-linux-tdep.c: Fix common/ includes.
10613         * minsyms.c: Fix common/ includes.
10614         * mi/mi-parse.h: Fix common/ includes.
10615         * mi/mi-main.c: Fix common/ includes.
10616         * mi/mi-cmd-env.c: Fix common/ includes.
10617         * memrange.h: Fix common/ includes.
10618         * memattr.c: Fix common/ includes.
10619         * maint.h: Fix common/ includes.
10620         * maint.c: Fix common/ includes.
10621         * main.c: Fix common/ includes.
10622         * machoread.c: Fix common/ includes.
10623         * location.c: Fix common/ includes.
10624         * linux-thread-db.c: Fix common/ includes.
10625         * linux-nat.c: Fix common/ includes.
10626         * linux-fork.c: Fix common/ includes.
10627         * inline-frame.c: Fix common/ includes.
10628         * infrun.c: Fix common/ includes.
10629         * inflow.c: Fix common/ includes.
10630         * inferior.h: Fix common/ includes.
10631         * inferior.c: Fix common/ includes.
10632         * infcmd.c: Fix common/ includes.
10633         * inf-ptrace.c: Fix common/ includes.
10634         * inf-child.c: Fix common/ includes.
10635         * ia64-linux-nat.c: Fix common/ includes.
10636         * i387-tdep.c: Fix common/ includes.
10637         * i386-tdep.c: Fix common/ includes.
10638         * i386-linux-tdep.c: Fix common/ includes.
10639         * i386-linux-nat.c: Fix common/ includes.
10640         * i386-go32-tdep.c: Fix common/ includes.
10641         * i386-fbsd-tdep.c: Fix common/ includes.
10642         * i386-fbsd-nat.c: Fix common/ includes.
10643         * guile/scm-type.c: Fix common/ includes.
10644         * guile/guile.c: Fix common/ includes.
10645         * go32-nat.c: Fix common/ includes.
10646         * gnu-nat.c: Fix common/ includes.
10647         * gdbthread.h: Fix common/ includes.
10648         * gdbarch-selftests.c: Fix common/ includes.
10649         * gdb_usleep.c: Fix common/ includes.
10650         * gdb_select.h: Fix common/ includes.
10651         * gdb_bfd.c: Fix common/ includes.
10652         * gcore.c: Fix common/ includes.
10653         * fork-child.c: Fix common/ includes.
10654         * findvar.c: Fix common/ includes.
10655         * fbsd-nat.c: Fix common/ includes.
10656         * event-top.c: Fix common/ includes.
10657         * event-loop.c: Fix common/ includes.
10658         * dwarf2read.c: Fix common/ includes.
10659         * dwarf2loc.c: Fix common/ includes.
10660         * dwarf2-frame.c: Fix common/ includes.
10661         * dwarf-index-cache.c: Fix common/ includes.
10662         * dtrace-probe.c: Fix common/ includes.
10663         * disasm-selftests.c: Fix common/ includes.
10664         * defs.h: Fix common/ includes.
10665         * csky-tdep.c: Fix common/ includes.
10666         * cp-valprint.c: Fix common/ includes.
10667         * cp-support.h: Fix common/ includes.
10668         * cp-support.c: Fix common/ includes.
10669         * corelow.c: Fix common/ includes.
10670         * completer.h: Fix common/ includes.
10671         * completer.c: Fix common/ includes.
10672         * compile/compile.c: Fix common/ includes.
10673         * compile/compile-loc2c.c: Fix common/ includes.
10674         * compile/compile-cplus-types.c: Fix common/ includes.
10675         * compile/compile-cplus-symbols.c: Fix common/ includes.
10676         * command.h: Fix common/ includes.
10677         * cli/cli-dump.c: Fix common/ includes.
10678         * cli/cli-cmds.c: Fix common/ includes.
10679         * charset.c: Fix common/ includes.
10680         * build-id.c: Fix common/ includes.
10681         * btrace.h: Fix common/ includes.
10682         * btrace.c: Fix common/ includes.
10683         * breakpoint.h: Fix common/ includes.
10684         * breakpoint.c: Fix common/ includes.
10685         * ax.h:
10686         (enum agent_op): Fix common/ includes.
10687         * ax-general.c (struct aop_map): Fix common/ includes.
10688         * ax-gdb.c: Fix common/ includes.
10689         * auxv.c: Fix common/ includes.
10690         * auto-load.c: Fix common/ includes.
10691         * arm-tdep.c: Fix common/ includes.
10692         * arch/riscv.c: Fix common/ includes.
10693         * arch/ppc-linux-common.c: Fix common/ includes.
10694         * arch/i386.c: Fix common/ includes.
10695         * arch/arm.c: Fix common/ includes.
10696         * arch/arm-linux.c: Fix common/ includes.
10697         * arch/arm-get-next-pcs.c: Fix common/ includes.
10698         * arch/amd64.c: Fix common/ includes.
10699         * arch/aarch64.c: Fix common/ includes.
10700         * arch/aarch64-insn.c: Fix common/ includes.
10701         * arch-utils.c: Fix common/ includes.
10702         * amd64-windows-tdep.c: Fix common/ includes.
10703         * amd64-tdep.c: Fix common/ includes.
10704         * amd64-sol2-tdep.c: Fix common/ includes.
10705         * amd64-obsd-tdep.c: Fix common/ includes.
10706         * amd64-nbsd-tdep.c: Fix common/ includes.
10707         * amd64-linux-tdep.c: Fix common/ includes.
10708         * amd64-linux-nat.c: Fix common/ includes.
10709         * amd64-fbsd-tdep.c: Fix common/ includes.
10710         * amd64-fbsd-nat.c: Fix common/ includes.
10711         * amd64-dicos-tdep.c: Fix common/ includes.
10712         * amd64-darwin-tdep.c: Fix common/ includes.
10713         * agent.c: Fix common/ includes.
10714         * ada-lang.h: Fix common/ includes.
10715         * ada-lang.c: Fix common/ includes.
10716         * aarch64-tdep.c: Fix common/ includes.
10717
10718 2019-01-25  Tom Tromey  <tom@tromey.com>
10719
10720         * common/create-version.sh: Use common/version.h.
10721
10722 2019-01-24  Pedro Alves  <palves@redhat.com>
10723
10724         * infrun.c (signal_stop, signal_print, signal_program)
10725         (signal_catch, signal_pass): Now arrays instead of pointers.
10726         (update_signals_program_target, do_target_resume)
10727         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10728         * linux-nat.c (linux_nat_target::pass_signals)
10729         (linux_nat_target::create_inferior, linux_nat_target::attach):
10730         Adjust.
10731         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10732         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10733         * procfs.c (procfs_target::pass_signals): Adjust.
10734         * record-full.c (record_full_target::resume): Adjust.
10735         * remote.c (remote_target::pass_signals)
10736         (remote_target::program_signals): Adjust.
10737         * target-debug.h (target_debug_print_signals): Now takes a
10738         gdb::array_view as parameter.  Adjust.
10739         * target.h (target_ops) <pass_signals, program_signals>: Replace
10740         pointer and length parameters with gdb::array_view.
10741         (target_pass_signals, target_program_signals): Likewise.
10742         * target-delegates.c: Regenerate.
10743
10744 2019-01-24  Pedro Alves  <palves@redhat.com>
10745
10746         * common/forward-scope-exit.h
10747         (forward_scope_exit::forward_scope_exit): Pass arguments to
10748         m_bind_function directly, instead of creating a std::bind and
10749         copying that.
10750
10751 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10752
10753         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10754         for static members.
10755         (pass_in_v_vfp_candidate): Likewise.
10756
10757 2019-01-23  Tom Tromey  <tom@tromey.com>
10758             Pedro Alves  <palves@redhat.com>
10759
10760         * regcache.c (class regcache_invalidator): Remove.
10761         (regcache::raw_write): Use make_scope_exit.
10762
10763 2019-01-23  Tom Tromey  <tom@tromey.com>
10764
10765         * ui-out.h (class ui_out_emit_type): Update comment.
10766
10767 2019-01-23  Tom Tromey  <tom@tromey.com>
10768
10769         * infrun.c (fetch_inferior_event): Update comment.
10770
10771 2019-01-23  Tom Tromey  <tom@tromey.com>
10772             Pedro Alves  <palves@redhat.com>
10773
10774         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10775         parameter.
10776         (fetch_inferior_event): Use SCOPE_EXIT.
10777
10778
10779 2019-01-23  Tom Tromey  <tom@tromey.com>
10780             Pedro Alves  <palves@redhat.com>
10781
10782         * infrun.c (disable_thread_events): Delete.
10783         (stop_all_threads): Use SCOPE_EXIT.
10784
10785 2019-01-23  Tom Tromey  <tom@tromey.com>
10786             Pedro Alves  <palves@redhat.com>
10787
10788         * symfile.c: Include forward-scope-exit.h.
10789         (clear_symtab_users_cleanup): Replace forward declaration with
10790         a FORWARD_SCOPE_EXIT.
10791         (syms_from_objfile_1): Use the forward_scope_exit and
10792         gdb::optional instead of cleanup_function.
10793         (reread_symbols): Use the forward_scope_exit instead of
10794         cleanup_function.
10795         (clear_symtab_users_cleanup): Remove function.
10796
10797 2019-01-23  Tom Tromey  <tom@tromey.com>
10798             Pedro Alves  <palves@redhat.com>
10799
10800         * linux-nat.c: Include scope-exit.h.
10801         (cleanup_target_stop): Remove.
10802         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10803         SCOPE_EXIT.
10804
10805 2019-01-23  Tom Tromey  <tom@tromey.com>
10806             Pedro Alves  <palves@redhat.com>
10807
10808         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10809         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10810
10811 2019-01-23  Tom Tromey  <tom@tromey.com>
10812             Andrew Burgess  <andrew.burgess@embecosm.com>
10813             Pedro Alves  <palves@redhat.com>
10814
10815         * infrun.c (fetch_inferior_event): Use scope_exit.
10816         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10817         * top.c (execute_command): Use scope_exit.
10818         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10819         * utils.c (do_bpstat_clear_actions_cleanup)
10820         (make_bpstat_clear_actions_cleanup): Remove.
10821
10822 2019-01-23  Tom Tromey  <tom@tromey.com>
10823             Pedro Alves  <palves@redhat.com>
10824
10825         * infrun.c: Include "common/scope-exit.h"
10826         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10827         (wait_for_inferior): Use SCOPE_EXIT.
10828         (fetch_inferior_event): Use scope_exit.
10829
10830 2019-01-23  Tom Tromey  <tom@tromey.com>
10831             Pedro Alves  <palves@redhat.com>
10832
10833         * breakpoint.c (create_breakpoint): Remove cleanup.
10834
10835 2019-01-23  Tom Tromey  <tom@tromey.com>
10836             Andrew Burgess  <andrew.burgess@embecosm.com>
10837             Pedro Alves  <palves@redhat.com>
10838
10839 2019-01-23  Pedro Alves  <palves@redhat.com>
10840
10841         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10842
10843 2019-01-23  Pedro Alves  <palves@redhat.com>
10844             Andrew Burgess  <andrew.burgess@embecosm.com>
10845
10846         * gdbthread.h: Include "common/forward-scope-exit.h".
10847         (scoped_finish_thread_state): Redefine custom class in terms of
10848         forward_scope_exit.
10849
10850 2019-01-23  Pedro Alves  <palves@redhat.com>
10851             Andrew Burgess  <andrew.burgess@embecosm.com>
10852
10853         * common/forward-scope-exit.h: New file.
10854
10855 2019-01-23  Pedro Alves  <palves@redhat.com>
10856             Andrew Burgess  <andrew.burgess@embecosm.com>
10857             Tom Tromey  <tom@tromey.com>
10858
10859         * common/scope-exit.h: New file.
10860
10861 2019-01-23  Pedro Alves  <palves@redhat.com>
10862
10863         * common/preprocessor.h (ESC): Rename to ...
10864         (ESC_PARENS): ... this.
10865         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10866         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10867
10868 2019-01-23  Tom Tromey  <tom@tromey.com>
10869
10870         * language.h (class scoped_switch_to_sym_language_if_auto):
10871         Initialize m_lang in both cases.
10872
10873 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10874
10875         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10876         with XCNEW.
10877
10878 2019-01-22  Tom Tromey  <tom@tromey.com>
10879
10880         * corelow.c: Do not include sys/file.h.
10881
10882 2019-01-22  Tom Tromey  <tom@tromey.com>
10883
10884         * tui/tui-wingeneral.h: Include gdb_curses.h.
10885
10886 2019-01-22  Tom Tromey  <tom@tromey.com>
10887
10888         * source-cache.h (class source_cache) <get_source_lines,
10889         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10890
10891 2019-01-22  Tom Tromey  <tom@tromey.com>
10892
10893         * remote-fileio.h (struct remote_target): Declare.
10894
10895 2019-01-22  Tom Tromey  <tom@tromey.com>
10896
10897         * python/py-arch.c: Do not include py-ref.h.
10898         * python/py-bpevent.c: Do not include py-ref.h.
10899         * python/py-cmd.c: Do not include py-ref.h.
10900         * python/py-continueevent.c: Do not include py-ref.h.
10901         * python/py-event.h: Do not include py-ref.h.
10902         * python/py-evtregistry.c: Do not include py-ref.h.
10903         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10904         * python/py-frame.c: Do not include py-ref.h.
10905         * python/py-framefilter.c: Do not include py-ref.h.
10906         * python/py-function.c: Do not include py-ref.h.
10907         * python/py-infevents.c: Do not include py-ref.h.
10908         * python/py-linetable.c: Do not include py-ref.h.
10909         * python/py-objfile.c: Do not include py-ref.h.
10910         * python/py-param.c: Do not include py-ref.h.
10911         * python/py-prettyprint.c: Do not include py-ref.h.
10912         * python/py-progspace.c: Do not include py-ref.h.
10913         * python/py-symbol.c: Do not include py-ref.h.
10914         * python/py-symtab.c: Do not include py-ref.h.
10915         * python/py-type.c: Do not include py-ref.h.
10916         * python/py-unwind.c: Do not include py-ref.h.
10917         * python/py-utils.c: Do not include py-ref.h.
10918         * python/py-value.c: Do not include py-ref.h.
10919         * python/py-varobj.c: Do not include py-ref.h.
10920         * python/py-xmethods.c: Do not include py-ref.h.
10921         * python/python.c: Do not include py-ref.h.
10922         * varobj.c: Do not include py-ref.h.
10923
10924 2019-01-22  Tom Tromey  <tom@tromey.com>
10925
10926         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10927         keyword for bcache.
10928
10929 2019-01-22  Tom Tromey  <tom@tromey.com>
10930
10931         * compile/compile-cplus-types.c: Remove a comment by #include.
10932
10933 2019-01-22  Tom Tromey  <tom@tromey.com>
10934
10935         * compile/gcc-c-plugin.h: Include compile-internal.h.
10936
10937 2019-01-22  Tom Tromey  <tom@tromey.com>
10938
10939         * stabsread.c (EXTERN): Do not define.
10940         (symnum, next_symbol_text_func, processing_gcc_compilation)
10941         (within_function, global_sym_chain, global_stabs)
10942         (previous_stab_code, this_object_header_files)
10943         (n_this_object_header_files)
10944         (n_allocated_this_object_header_files): Define.
10945         * stabsread.h (EXTERN): Never define.  Use "extern".
10946
10947 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10948
10949         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10950         history_value.
10951
10952 2019-01-21  Tom Tromey  <tom@tromey.com>
10953
10954         * ui-out.c: Fix includes.
10955         * tui/tui-source.c: Fix includes.
10956         * target.c: Fix includes.
10957         * remote.c: Fix includes.
10958         * regcache.c: Fix includes.
10959         * python/py-block.c: Fix includes.
10960         * printcmd.c: Fix includes.
10961         * or1k-tdep.c: Fix includes.
10962         * mi/mi-main.c: Fix includes.
10963         * m32r-tdep.c: Fix includes.
10964         * csky-tdep.c: Fix includes.
10965         * compile/compile-cplus-types.c: Fix includes.
10966         * cli/cli-interp.c: Fix includes.
10967
10968 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10969
10970         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10971         for padding.
10972
10973 2019-01-16  Tom Tromey  <tom@tromey.com>
10974
10975         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10976         earlier.
10977         (struct objfile) <msymbols_range>: Move from top level.
10978         <msymbols>: New method.
10979         (class objfile_msymbols): Remove.
10980         * symtab.c (default_collect_symbol_completion_matches_break_on):
10981         Update.
10982         * symmisc.c (dump_msymbols): Update.
10983         * stabsread.c (scan_file_globals): Update.
10984         * objc-lang.c (info_selectors_command, info_classes_command)
10985         (find_methods): Update.
10986         * minsyms.c (find_solib_trampoline_target): Update.
10987         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10988         * coffread.c (coff_symfile_read): Update.
10989         * ada-lang.c (ada_lookup_simple_minsym)
10990         (ada_collect_symbol_completion_matches): Update.
10991
10992 2019-01-16  Tom Tromey  <tom@tromey.com>
10993
10994         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10995         type.  Remove no-argument constructor.
10996         <iterator::operator++>: Simplify.
10997         <begin>: Update.
10998         <end>: Use minimal_symbol_count.
10999
11000 2019-01-16  Tom Tromey  <tom@tromey.com>
11001
11002         * objfiles.h (struct objfile) <psymtabs>: New method.
11003         (class objfile_psymtabs): Remove.
11004         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11005         typedef.
11006         <range>: New method.
11007         (require_partial_symbols): Change return type.
11008         * psymtab.c (require_partial_symbols)
11009         (psym_expand_symtabs_matching): Update.
11010         * mdebugread.c (parse_partial_symbols): Update.
11011         * dbxread.c (dbx_end_psymtab): Update.
11012
11013 2019-01-15  Tom Tromey  <tom@tromey.com>
11014
11015         * symtab.c (lookup_objfile_from_block)
11016         (lookup_symbol_in_objfile_symtabs)
11017         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11018         (find_line_symtab, info_sources_command)
11019         (default_collect_symbol_completion_matches_break_on)
11020         (make_source_files_completion_list): Update.
11021         * symmisc.c (print_objfile_statistics, dump_objfile)
11022         (maintenance_print_symbols, maintenance_info_symtabs)
11023         (maintenance_check_symtabs, maintenance_info_line_tables):
11024         Update.
11025         * source.c (select_source_symtab)
11026         (forget_cached_source_info_for_objfile): Update.
11027         * objfiles.h (class objfile_compunits): Remove.
11028         (struct objfile) <compunits_range>: New typedef.
11029         (compunits): New method.
11030         * objfiles.c (objfile_relocate1): Update.
11031         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11032         * maint.c (count_symtabs_and_blocks): Update.
11033         * linespec.c (iterate_over_all_matching_symtabs): Update.
11034         * cp-support.c (add_symbol_overload_list_qualified): Update.
11035         * coffread.c (coff_symtab_read): Update.
11036         * ada-lang.c (add_nonlocal_symbols)
11037         (ada_collect_symbol_completion_matches)
11038         (ada_add_global_exceptions): Update.
11039
11040 2019-01-15  Tom Tromey  <tom@tromey.com>
11041
11042         * progspace.h (program_space) <objfiles_safe_range>: New
11043         typedef.
11044         <objfiles_safe>: New method.
11045         * objfiles.h (class all_objfiles_safe): Remove.
11046         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11047         * jit.c (jit_inferior_exit_hook): Update.
11048
11049 2019-01-17  Tom Tromey  <tom@tromey.com>
11050
11051         * progspace.h (program_space) <objfiles_range>: New typedef.
11052         <objfiles>: New method.
11053         <objfiles_head>: Rename from objfiles.
11054         (object_files): Update.
11055         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11056         * guile/scm-pretty-print.c
11057         (ppscm_find_pretty_printer_from_objfiles): Update.
11058         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11059         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11060         Update.
11061         * python/py-progspace.c (pspy_get_objfiles): Update.
11062         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11063         Update.
11064         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11065         (objfpy_lookup_objfile_by_build_id): Update.
11066         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11067         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11068         Update.
11069         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11070         (expand_symtab_containing_pc, lookup_objfile_from_block)
11071         (lookup_static_symbol, basic_lookup_transparent_type)
11072         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11073         (find_line_symtab, info_sources_command)
11074         (default_collect_symbol_completion_matches_break_on)
11075         (make_source_files_completion_list, find_main_name): Update.
11076         * symmisc.c (print_symbol_bcache_statistics)
11077         (print_objfile_statistics, maintenance_print_symbols)
11078         (maintenance_print_msymbols, maintenance_print_objfiles)
11079         (maintenance_info_symtabs, maintenance_check_symtabs)
11080         (maintenance_expand_symtabs, maintenance_info_line_tables):
11081         Update.
11082         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11083         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11084         (map_overlay_command, unmap_overlay_command)
11085         (simple_overlay_update, expand_symtabs_matching)
11086         (map_symbol_filenames): Update.
11087         * symfile-debug.c (set_debug_symfile): Update.
11088         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11089         Update.
11090         * source.c (select_source_symtab, forget_cached_source_info):
11091         Update.
11092         * solib.c (solib_read_symbols): Update.
11093         * solib-spu.c (append_ocl_sos): Update.
11094         * psymtab.c (maintenance_print_psymbols)
11095         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11096         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11097         * printcmd.c (info_symbol_command): Update.
11098         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11099         Update.
11100         * objfiles.h (class all_objfiles): Remove.
11101         * objfiles.c (have_partial_symbols, have_full_symbols)
11102         (have_minimal_symbols, qsort_cmp, update_section_map)
11103         (shared_objfile_contains_address_p)
11104         (default_iterate_over_objfiles_in_search_order): Update.
11105         * objc-lang.c (info_selectors_command, info_classes_command)
11106         (find_methods): Update.
11107         * minsyms.c (find_solib_trampoline_target): Update.
11108         * maint.c (maintenance_info_sections)
11109         (maintenance_translate_address, count_symtabs_and_blocks):
11110         Update.
11111         * main.c (captured_main_1): Update.
11112         * linux-thread-db.c (try_thread_db_load_from_pdir)
11113         (has_libpthread): Update.
11114         * linespec.c (iterate_over_all_matching_symtabs)
11115         (search_minsyms_for_name): Update.
11116         * jit.c (jit_find_objf_with_entry_addr): Update.
11117         * hppa-tdep.c (find_unwind_entry)
11118         (hppa_lookup_stub_minimal_symbol): Update.
11119         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11120         Update.
11121         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11122         (elf_gnu_ifunc_resolve_by_got): Update.
11123         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11124         * dwarf-index-write.c (save_gdb_index_command): Update.
11125         * cp-support.c (add_symbol_overload_list_qualified): Update.
11126         * breakpoint.c (create_overlay_event_breakpoint)
11127         (create_longjmp_master_breakpoint)
11128         (create_std_terminate_master_breakpoint)
11129         (create_exception_master_breakpoint): Update.
11130         * blockframe.c (find_pc_partial_function): Update.
11131         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11132         (ada_collect_symbol_completion_matches)
11133         (ada_add_global_exceptions): Update.
11134
11135 2019-01-17  Tom Tromey  <tom@tromey.com>
11136
11137         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11138         declare VEC.
11139         (solib_target_parse_libraries): Change return type.
11140         (library_list_start_segment, library_list_start_section)
11141         (library_list_end_library, library_list_start_library); Update.
11142         (solib_target_free_library_list): Remove.
11143         (solib_target_parse_libraries): Remove cleanup.  Change return
11144         type.
11145         (solib_target_current_sos): Update.
11146
11147 2019-01-17  Tom Tromey  <tromey@bapiya>
11148
11149         * valprint.c: Replace "the the" with "the".
11150         * symtab.c: Replace "the the" with "the".
11151         * solib.c: Replace "the the" with "the".
11152         * solib-dsbt.c: Replace "the the" with "the".
11153         * linespec.c: Replace "the the" with "the".
11154         * dwarf2loc.h: Replace "the the" with "the".
11155         * amd64-windows-tdep.c: Replace "the the" with "the".
11156         * aarch64-tdep.c: Replace "the the" with "the".
11157
11158 2019-01-16  Keith Seitz  <keiths@redhat.com>
11159
11160         PR gdb/23773
11161         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11162         <builder>: Rename to ..
11163         <m_builder>: ... this and make private.
11164         (dwarf2_cu::get_builder): New method.  Change all users of
11165         `builder' to use this method.
11166         (dwarf2_start_symtab): Move to ...
11167         (dwarf2_cu::start_symtab): ... here.  Update all callers
11168         (setup_type_unit_groups): Move to ...
11169         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11170         callers.
11171         (dwarf2_cu::reset_builder): New method.
11172         (process_full_compunit, process_full_type_unit): Use
11173         dwarf2_cu::reset_builder.
11174         (follow_die_offset): Record the ancestor CU if it is different
11175         from the followed DIE's CU.
11176         (follow_die_sig_1): Likewise.
11177
11178 2019-01-15  Tom Tromey  <tom@tromey.com>
11179
11180         * remote.c (class remote_state) <buf>: Now a char_vector.
11181         <buf_size>: Remove.
11182         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11183         parameter.
11184         (remote_target::getpkt_or_notif_sane_1)
11185         (remote_target::getpkt_sane)
11186         (remote_target::getpkt_or_notif_sane): Likewise.
11187         (class remote_target) <putpkt>: New overload.
11188         (remote_target::read_frame): Change type of "buf_p".  Remove
11189         sizeof_p parameter.
11190         (packet_ok): New overload.
11191         (packet_check_result): New overload.
11192         Update all uses.
11193
11194 2019-01-14  Tom Tromey  <tom@tromey.com>
11195
11196         * remote-notif.c (handle_notification, remote_notif_ack)
11197         (remote_notif_parse): Make "buf" const.
11198         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11199         const.
11200         (remote_notif_parse, remote_notif_ack, handle_notification):
11201         Likewise.
11202         * remote.c (remote_notif_stop_parse): Make "buf" const.
11203         (remote_target::remote_parse_stop_reply): Make "buf" const.
11204         (remote_notif_stop_ack): Make "buf" const.
11205
11206 2019-01-14  Tom Tromey  <tom@tromey.com>
11207
11208         * remote.c (remote_console_output): Make parameter const.
11209
11210 2019-01-14  Tom Tromey  <tom@tromey.com>
11211
11212         * target-debug.h (target_debug_print_signals): Constify.
11213         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11214         * procfs.c (procfs_target::pass_signals): Update.
11215         * linux-nat.c (linux_nat_target::pass_signals): Update.
11216         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11217         * target-delegates.c: Rebuild.
11218         * remote.c (remote_target::program_signals): Update.
11219         (remote_target::pass_signals): Update.
11220         * target.c (target_pass_signals): Constify argument.
11221         (target_program_signals): Likewise.
11222         * target.h (struct target_ops) <pass_signals, program_signals>:
11223         Constify argument.
11224         (target_pass_signals, target_program_signals): Constify argument.
11225
11226 2019-01-14  Tom Tromey  <tom@tromey.com>
11227
11228         PR tui/28819:
11229         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11230
11231 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11232
11233         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11234         field.
11235         * rs6000-tdep.c: Include reggroups.h.
11236         (IS_V_ALIAS_PSEUDOREG): Define.
11237         (rs6000_register_name): Return names for the "vX" aliases.
11238         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11239         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11240         aliases.  Call default_register_reggroup_p for all other
11241         pseudo-registers.
11242         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11243         New functions.
11244         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11245         Handle "vX" aliases.
11246         (v_alias_pseudo_register_collect): New function.
11247         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11248         (rs6000_gdbarch_init): Initialize "vX" aliases as
11249         pseudo-registers.  Restore registration of
11250         rs6000_pseudo_register_reggroup_p with
11251         set_tdesc_pseudo_register_reggroup_p.
11252
11253 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11254
11255         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11256         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11257         set_gdbarch_num_pseudo_regs.
11258
11259 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11260
11261         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11262         Remove arg prefixname, add do_set and do_show.
11263         Add member functions set_list and show_list.
11264         * cli/cli-style.c (class cli_style_option): Update accordingly.
11265         (style_set_list): Move to file scope.
11266         (style_show_list): Likewise.
11267         (set_style): Call help_list.
11268         (show_style): Call cmd_show_list.
11269         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11270         Update to use the new macro.
11271
11272 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11273
11274         * ada-lang.c (_initialize_ada_language): Expand the help text
11275         for the "catch exception" command.
11276
11277 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11278
11279         * symtab.c (matching_obj_sections): Initialize obj,
11280         declare it closer to its usage.
11281
11282 2019-01-10  Tom Tromey  <tom@tromey.com>
11283
11284         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11285         (basic_inf_threads_range): Remove.
11286         (inf_threads_range, inf_non_exited_threads_range)
11287         (safe_inf_threads_range): Use next_adapter.
11288
11289 2019-01-10  Keith Seitz  <keiths@redhat.com>
11290
11291         PR gdb/23712
11292         PR symtab/23010
11293         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11294         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11295
11296 2019-01-10  Keith Seitz  <keiths@redhat.com>
11297
11298         PR gdb/23712
11299         PR symtab/23010
11300         * dictionary.c (pending_to_vector): Remove.
11301         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11302         Remove _1 suffix, replacing functions of the same name.  Update
11303         all callers.
11304         (dict_create_hashed, dict_create_hashed_expandable)
11305         (dict_create_linear, dict_create_linear_expandable, dict_free)
11306         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11307         Make functions static.
11308
11309 2019-01-10  Keith Seitz  <keiths@redhat.com>
11310
11311         PR gdb/23712
11312         PR symtab/23010
11313         * dictionary.h (struct dictionary): Replace declaration with
11314         multidictionary.
11315         (dict_create_hashed, dict_create_hashed_expandable)
11316         (dict_create_linear, dict_create_linear_expandable)
11317         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11318         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11319         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11320         taking multidictionary argument.
11321         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11322         * block.h (struct block) <dict>: Change to multidictionary
11323         and rename `multidict'.
11324         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11325         symmisc.c: Update all dictionary references to multidictionary.
11326
11327 2019-01-10  Keith Seitz  <keiths@redhat.com>
11328
11329         PR gdb/23712
11330         PR symtab/23010
11331         * dictionary.c: Include unordered_map.
11332         (pending_to_vector): New function.
11333         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11334         Rewrite the non-"_1" functions to take vector instead
11335         of linked list.
11336         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11337         "new" _1 versions of the same name.
11338         (multidictionary): Define.
11339         (std::hash<enum language): New definition.
11340         (collate_pending_symbols_by_language, mdict_create_hashed)
11341         (mdict_create_hashed_expandable, mdict_create_linear)
11342         (mdict_create_linear_expandable, mdict_free)
11343         (find_language_dictionary, create_new_language_dictionary)
11344         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11345         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11346         (mdict_size, mdict_empty): New functions.
11347         * dictionary.h (mdict_iterator): Define.
11348
11349 2019-01-10  Pedro Alves  <palves@redhat.com>
11350
11351         * breakpoint.c (read_uploaded_action)
11352         (create_tracepoint_from_upload): Adjust to use
11353         gdb::unique_xmalloc_ptr.
11354         * ctf.c (ctf_write_uploaded_tp):
11355         (SET_ARRAY_FIELD): Use emplace_back.
11356         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11357         * tracefile-tfile.c (tfile_write_uploaded_tp):
11358         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11359         gdb::unique_xmalloc_ptr.
11360         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11361         at_string, cond_string, cmd_strings>: Replace char pointers
11362         with gdb::unique_xmalloc_ptr.
11363
11364 2019-01-10  Pedro Alves  <palves@redhat.com>
11365
11366         * solib-target.c (library_list_start_library): Don't xstrdup name.
11367
11368 2019-01-10  Pedro Alves  <palves@redhat.com>
11369
11370         * mdebugread.c (parse_partial_symbols): Use
11371         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11372
11373 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11374
11375         * linux-fork.c (scoped_switch_fork_info)
11376         <~scoped_switch_fork_info>: Fix incorrect variable name.
11377
11378 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11379
11380         * linux-fork.c (scoped_switch_fork_info)
11381         <scoped_switch_fork_info>: Make explicit.
11382         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11383
11384 2019-01-10  Tom Tromey  <tom@tromey.com>
11385
11386         * objfiles.h (objfile::reset_psymtabs): Update.
11387         * objfiles.c (objfile::objfile): Update.
11388         * psymtab.h (psymtab_storage::obstack): Update.
11389         (psymtab_storage::m_obstack): Use gdb::optional.
11390         (class psymtab_storage): Update comment.  Remove objfile
11391         parameter.
11392         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11393
11394 2019-01-10  Tom Tromey  <tom@tromey.com>
11395
11396         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11397         <free_psymtabs>: Now private.
11398         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11399         (allocate_psymtab): Use new method.
11400
11401 2019-01-10  Tom Tromey  <tom@tromey.com>
11402
11403         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11404         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11405         * mdebugread.c (parse_partial_symbols): Use
11406         allocate_dependencies.
11407         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11408         allocate_dependencies.
11409         (process_psymtab_comp_unit_reader)
11410         (build_type_psymtab_dependencies): Likewise.
11411         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11412
11413 2019-01-10  Tom Tromey  <tom@tromey.com>
11414
11415         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11416         PSYMBOL_SET_LANGUAGE.
11417         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11418
11419 2019-01-10  Tom Tromey  <tom@tromey.com>
11420
11421         * psymtab.h (psymtab_storage::obstack): New method.
11422         <m_obstack>: Rename from obstack; now private.
11423         * psymtab.c (psymtab_storage): Update.
11424         * dwarf2read.c (create_addrmap_from_index)
11425         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11426         Update.
11427
11428 2019-01-10  Tom Tromey  <tom@tromey.com>
11429
11430         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11431         * objfiles.h (objfile::reset_psymtabs): New method.
11432
11433 2019-01-10  Tom Tromey  <tom@tromey.com>
11434
11435         * symmisc.c (print_symbol_bcache_statistics): Update.
11436         (print_objfile_statistics): Update.
11437         * symfile.c (reread_symbols): Update.
11438         * psymtab.h (class psymtab_storage): New.
11439         * psymtab.c (psymtab_storage): New constructor.
11440         (~psymtab_storage): New destructor.
11441         (require_partial_symbols): Update.
11442         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11443         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11444         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11445         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11446         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11447         (start_psymtab_common, end_psymtab_common)
11448         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11449         (allocate_psymtab): Update.
11450         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11451         Update.
11452         (dump_psymtab_addrmap, maintenance_print_psymbols)
11453         (maintenance_check_psymtabs): Update.
11454         (class objfile_psymtabs): Move to objfiles.h.
11455         * psympriv.h (discard_psymtab): Now inline.
11456         (psymtab_discarder::psymtab_discarder): Update.
11457         (psymtab_discarder::~psymtab_discarder): Update.
11458         (ALL_OBJFILE_PSYMTABS): Rewrite.
11459         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11460         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11461         Remove fields.
11462         <partial_symtabs>: New field.
11463         (class objfile_psymtabs): Move from psymtab.h.  Update.
11464         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11465         psymbol_cache.
11466         (objfile::~objfile): Don't destroy psymbol_cache.
11467         * mdebugread.c (parse_partial_symbols): Update.
11468         * dwarf2read.c (create_addrmap_from_index)
11469         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11470         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11471         (add_partial_subprogram, dwarf2_ranges_read): Update.
11472         * dwarf-index-write.c (write_address_map)
11473         (write_one_signatured_type, recursively_write_psymbols)
11474         (class debug_names, class debug_names, write_psymtabs_to_index):
11475         Update.
11476
11477 2019-01-10  Tom Tromey  <tom@tromey.com>
11478
11479         * symtab.h (SYMBOL_SET_NAMES): Update.
11480         (symbol_set_names): Update.
11481         (MSYMBOL_SET_NAMES): Update.
11482         * symtab.c (symbol_set_names): Change argument to be an
11483         objfile_per_bfd_storage.
11484         * psymtab.c (add_psymbol_to_bcache): Update.
11485         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11486
11487 2019-01-10  Tom Tromey  <tom@tromey.com>
11488
11489         * symtab.c (create_demangled_names_hash): Change argument to be an
11490         objfile_per_bfd_storage.
11491         (symbol_set_names): Update.
11492
11493 2019-01-10  Tom Tromey  <tom@tromey.com>
11494
11495         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11496         init_psymbol_list.
11497         * psymtab.c (init_psymbol_list): Do nothing if already called.
11498         * psympriv.h (init_psymbol_list): Add comment.
11499         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11500         init_psymbol_list.
11501         * dbxread.c (dbx_symfile_read): Unconditionally call
11502         init_psymbol_list.
11503
11504 2019-01-10  Tom Tromey  <tom@tromey.com>
11505
11506         * xcoffread.c (scan_xcoff_symtab): Update.
11507         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11508         "where".
11509         * mdebugread.c (parse_partial_symbols)
11510         (handle_psymbol_enumerators): Update.
11511         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11512         * dbxread.c (read_dbx_symtab): Update.
11513         * psympriv.h (psymbol_placement): New enum.
11514         (add_psymbol_to_list): Update.
11515
11516 2019-01-10  Tom Tromey  <tom@tromey.com>
11517
11518         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11519         static_psymbols parameters.
11520         (scan_xcoff_symtab): Update.
11521         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11522         static_psymbols parameters.
11523         * psympriv.h (start_psymtab_common): Update.
11524         * mdebugread.c (parse_partial_symbols): Update.
11525         * dwarf2read.c (create_partial_symtab): Update.
11526         * dbxread.c (read_dbx_symtab): Update.
11527         (start_psymtab): Remove global_psymbols and static_psymbols
11528         parameters.
11529
11530 2019-01-10  Tom Tromey  <tom@tromey.com>
11531
11532         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11533         * psymtab.c (allocate_psymtab): Add comment.
11534         * psympriv.h (allocate_psymtab): Add comment.
11535         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11536         initializations.
11537         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11538
11539 2019-01-10  Tom Tromey  <tom@tromey.com>
11540
11541         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11542         Don't declare.
11543         * mipsread.c: Include mdebugread.h.
11544         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11545         Declare.
11546         * elfread.c: Include mdebugread.h.
11547
11548 2019-01-09  Tom Tromey  <tom@tromey.com>
11549
11550         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11551         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11552         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11553         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11554         (psym_lookup_symbol, psym_find_last_source_symtab)
11555         (psym_forget_cached_source_info, psym_print_stats)
11556         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11557         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11558         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11559         (psym_find_compunit_symtab_by_address)
11560         (maintenance_print_psymbols, maintenance_info_psymtabs)
11561         (maintenance_check_psymtabs): Use ranged for.
11562         * psymtab.h (class objfile_psymtabs): New.
11563         (require_partial_symbols): Return objfile_psymtabs.
11564         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11565
11566 2019-01-09  Tom Tromey  <tom@tromey.com>
11567
11568         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11569         (find_pc_mapped_section, list_overlays_command)
11570         (map_overlay_command, unmap_overlay_command)
11571         (simple_overlay_update): Use all_objfiles.
11572         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11573         * printcmd.c (info_symbol_command): Use all_objfiles.
11574         * objfiles.h (ALL_OBJSECTIONS): Remove.
11575         * maint.c (maintenance_translate_address): Use all_objfiles.
11576         * gcore.c (gcore_create_callback): Use all_objfiles.
11577         (objfile_find_memory_regions): Likewise.
11578
11579 2019-01-09  Tom Tromey  <tom@tromey.com>
11580
11581         * symtab.c (find_line_symtab, info_sources_command)
11582         (make_source_files_completion_list): Use objfile_compunits.
11583         * source.c (select_source_symtab): Use objfile_compunits.
11584         * objfiles.h (struct objfile): Update comment.
11585         (ALL_OBJFILES): Remove.
11586         (ALL_FILETABS): Remove.
11587         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11588         objfile_compunits.
11589
11590 2019-01-09  Tom Tromey  <tom@tromey.com>
11591
11592         * symmisc.c (print_objfile_statistics, dump_objfile)
11593         (maintenance_print_symbols): Use compunit_filetabs.
11594         * source.c (forget_cached_source_info_for_objfile): Use
11595         compunit_filetabs.
11596         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11597         (ALL_FILETABS): Use compunit_filetabs.
11598         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11599         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11600
11601 2019-01-09  Tom Tromey  <tom@tromey.com>
11602
11603         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11604         (compunit_filetabs): New.
11605         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11606         compunit_filetabs.
11607         (info_sources_command, make_source_files_completion_list): Remove
11608         declaration.
11609         * symmisc.c (print_objfile_statistics, dump_objfile)
11610         (maintenance_print_symbols): Remove declaration.
11611         (maintenance_info_symtabs): Use compunit_filetabs.
11612         (maintenance_info_line_tables): Likewise.
11613         * source.c (select_source_symtab): Change local variable name.
11614         (forget_cached_source_info_for_objfile): Remove declaration.
11615         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11616         * objfiles.c (objfile_relocate1): Remove declaration.
11617         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11618         declaration.
11619         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11620         * coffread.c (coff_symtab_read): Remove declaration.
11621         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11622         compunit_filetabs.
11623
11624 2019-01-09  Tom Tromey  <tom@tromey.com>
11625
11626         * symtab.c (lookup_objfile_from_block)
11627         (find_pc_sect_compunit_symtab, search_symbols)
11628         (default_collect_symbol_completion_matches_break_on): Use
11629         objfile_compunits.
11630         * objfiles.h (ALL_COMPUNITS): Remove.
11631         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11632         * cp-support.c (add_symbol_overload_list_qualified): Use
11633         objfile_compunits.
11634         * ada-lang.c (ada_collect_symbol_completion_matches)
11635         (ada_add_global_exceptions): Use objfile_compunits.
11636
11637 2019-01-09  Tom Tromey  <tom@tromey.com>
11638
11639         * source.c (select_source_symtab)
11640         (forget_cached_source_info_for_objfile): Remove declaration.
11641         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11642         declaration.
11643         * maint.c (count_symtabs_and_blocks): Remove declaration.
11644         * cp-support.c (add_symbol_overload_list_qualified): Remove
11645         declaration.
11646         * coffread.c (coff_symtab_read): Remove declaration.
11647         * symtab.c (lookup_symbol_in_objfile_symtabs)
11648         (basic_lookup_transparent_type_1): Use objfile_compunits.
11649         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11650         (info_sources_command, search_symbols)
11651         (default_collect_symbol_completion_matches_break_on)
11652         (make_source_files_completion_list): Remove declaration.
11653         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11654         (ada_collect_symbol_completion_matches)
11655         (ada_add_global_exceptions): Remove declaration.
11656         * linespec.c (iterate_over_all_matching_symtabs): Use
11657         objfile_compunits.
11658         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11659         (class objfile_compunits): New.
11660         (ALL_COMPUNITS): Use objfile_compunits.
11661         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11662         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11663         objfile_compunits.
11664         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11665
11666 2019-01-09  Tom Tromey  <tom@tromey.com>
11667
11668         * symtab.c (search_symbols)
11669         (default_collect_symbol_completion_matches_break_on): Use
11670         objfile_msymbols.
11671         * ada-lang.c (ada_lookup_simple_minsym)
11672         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11673         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11674         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11675         objfile_msymbols.
11676         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11677         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11678         * objc-lang.c (find_methods): Use objfile_msymbols.
11679         (info_selectors_command, info_classes_command): Likewise.
11680         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11681         * objfiles.h (class objfile_msymbols): New.
11682         (ALL_OBJFILE_MSYMBOLS): Remove.
11683         (ALL_MSYMBOLS): Remove.
11684
11685 2019-01-09  Tom Tromey  <tom@tromey.com>
11686
11687         * common/next-iterator.h (next_adapter): Add Iterator template
11688         parameter.
11689         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11690         (class all_objfiles_safe): New.
11691         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11692         * objfiles.c (put_objfile_before): Update comment.
11693         (add_separate_debug_objfile): Likewise.
11694         (free_all_objfiles): Use all_objfiles_safe.
11695         (objfile_purge_solibs): Likewise.
11696
11697 2019-01-09  Tom Tromey  <tom@tromey.com>
11698
11699         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11700         (expand_symtab_containing_pc, lookup_static_symbol)
11701         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11702         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11703         all_objfiles.
11704         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11705         * breakpoint.c (create_overlay_event_breakpoint)
11706         (create_longjmp_master_breakpoint)
11707         (create_std_terminate_master_breakpoint)
11708         (create_exception_master_breakpoint): Use all_objfiles.
11709         * linux-thread-db.c (try_thread_db_load_from_pdir)
11710         (has_libpthread): Use all_objfiles.
11711         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11712         * linespec.c (iterate_over_all_matching_symtabs)
11713         (search_minsyms_for_name): Use all_objfiles.
11714         * maint.c (maintenance_info_sections): Use all_objfiles.
11715         * main.c (captured_main_1): Use all_objfiles.
11716         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11717         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11718         * guile/scm-pretty-print.c
11719         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11720         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11721         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11722         (maintenance_print_msymbols): Use all_objfiles.
11723         * source.c (select_source_symtab): Use all_objfiles.
11724         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11725         * symfile.c (remove_symbol_file_command)
11726         (expand_symtabs_matching, map_symbol_filenames): Use
11727         all_objfiles.
11728         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11729         all_objfiles.
11730         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11731         * objc-lang.c (find_methods): Use all_objfiles.
11732         * objfiles.c (have_partial_symbols, have_full_symbols)
11733         (have_minimal_symbols, qsort_cmp)
11734         (default_iterate_over_objfiles_in_search_order): Use
11735         all_objfiles.
11736         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11737         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11738         (maintenance_check_psymtabs): Use all_objfiles.
11739         (ALL_PSYMTABS): Remove.
11740         * compile/compile-object-run.c (do_module_cleanup): Use
11741         all_objfiles.
11742         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11743         * cp-support.c (add_symbol_overload_list_qualified): Use
11744         all_objfiles.
11745         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11746         Use all_objfiles.
11747         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11748         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11749         all_objfiles.
11750         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11751         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11752         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11753         Uses all_objfiles.
11754         * solib.c (solib_read_symbols): Use all_objfiles
11755
11756 2019-01-09  Tom Tromey  <tom@tromey.com>
11757
11758         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11759         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11760         all_objfiles.
11761         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11762         * symmisc.c (print_symbol_bcache_statistics)
11763         (print_objfile_statistics, maintenance_print_objfiles)
11764         (maintenance_info_symtabs, maintenance_check_symtabs)
11765         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11766         all_objfiles.
11767         * source.c (forget_cached_source_info): Use all_objfiles.
11768         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11769         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11770         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11771         * objfiles.c (update_section_map): Use all_objfiles.
11772         (shared_objfile_contains_address_p): Likewise.
11773         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11774         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11775
11776 2019-01-09  Tom Tromey  <tom@tromey.com>
11777
11778         * common/next-iterator.h: New file.
11779         * objfiles.h (class all_objfiles): New.
11780         (struct objfile_iterator): New.
11781
11782 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11783
11784         * NEWS: Move the description of the changed "frame", "select-frame",
11785          and "info frame" commands to the Changed commands section.
11786
11787 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11788
11789         * gdbtypes.c (check_stub_method_group): Remove handling of old
11790         mangling schemes.
11791         * linespec.c (find_methods): Likewise.
11792         * stabsread.c (read_member_functions): Likewise.
11793         * valops.c (search_struct_method): Likewise.
11794         (value_struct_elt_for_reference): Likewise.
11795         * NEWS: Mention this change.
11796
11797 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11798
11799         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11800         print_source_lines.
11801         * source.c (print_source_lines_base): Update line number check.
11802         (print_source_lines): New function.
11803         (source_lines_range::source_lines_range): New function.
11804         * source.h (class source_lines_range): New class.
11805         (print_source_lines): New declaration.
11806
11807 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11808
11809         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11810
11811 2019-01-08  Tom Tromey  <tom@tromey.com>
11812             Simon Marchi  <simon.marchi@ericsson.com>
11813
11814         PR gdb/24060
11815         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11816         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11817         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11818         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11819         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11820         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11821
11822 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11823
11824         * source.c (select_source_symtab): Move header comment to
11825         declaration in source.h.
11826         (forget_cached_source_info_for_objfile): Likewise.
11827         (forget_cached_source_info): Likewise.
11828         (identify_source_line): Likewise.
11829         * source.h (identify_source_line): Move declaration from symtab.h
11830         and add comment from source.c
11831         (print_source_lines): Likewise.
11832         (forget_cached_source_info_for_objfile): Likewise.
11833         (forget_cached_source_info): Likewise.
11834         (select_source_symtab): Likewise.
11835         (enum print_source_lines_flag): Move definition from symtab.h.
11836         * symtab.h (identify_source_line): Move declaration to source.h.
11837         (print_source_lines): Likewise.
11838         (forget_cached_source_info_for_objfile): Likewise.
11839         (forget_cached_source_info): Likewise.
11840         (select_source_symtab): Likewise.
11841         (enum print_source_lines_flag): Move definition to source.h.
11842         * tui/tui-hooks.c: Add 'source.h' include.
11843
11844 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11845
11846         * source.c (print_source_lines_base): Handle requests to print
11847         reverse line number sequences, and guard against empty lines
11848         string.
11849
11850 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11851
11852         * source.c (print_source_lines_base): Fix skip of '\r' if next
11853         character is '\n'.
11854
11855 2019-01-06  Tom Tromey  <tom@tromey.com>
11856
11857         * c-exp.y (struct c_parse_state) <macro_original_text,
11858         expansion_obstack>: New member.
11859         (macro_original_text, expansion_obstack): Remove globals.
11860         (scan_macro_expansion, scanning_macro_expansion)
11861         (finished_macro_expansion): Update.
11862         (scan_macro_cleanup): Remove.
11863         (yylex, c_parse): Update.
11864
11865 2019-01-06  Tom Tromey  <tom@tromey.com>
11866
11867         * c-exp.y (struct c_parse_state) <strings>: New member.
11868         (operator_stoken): Update.
11869
11870 2019-01-06  Tom Tromey  <tom@tromey.com>
11871
11872         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11873         (union type_stack_elt) <typelist_val>: Now a pointer to
11874         std::vector.
11875         (type_stack_cleanup): Don't declare.
11876         (push_typelist): Update.
11877         * parse.c (pop_typelist): Return a std::vector.
11878         (push_typelist): Take a std::vector.
11879         (follow_types): Update.  Do not free args.
11880         (type_stack_cleanup): Remove.
11881         * c-exp.y (struct c_parse_state): New.
11882         (cpstate): New global.
11883         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11884         (nonempty_typelist): Update.
11885         (func_mod): Create a new vector.
11886         (c_parse): Create a c_parse_state.
11887         (check_parameter_typelist): Do not delete params.
11888         (function_method): Update.  Do not delete type_list.
11889
11890 2019-01-06  Tom Tromey  <tom@tromey.com>
11891
11892         PR gdb/28155:
11893         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11894         check_typedef.
11895         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11896         (print_return_value): Likewise.
11897
11898 2019-01-05  Tom Tromey  <tom@tromey.com>
11899
11900         * contrib/cleanup_check.py: Remove.
11901         * contrib/gcc-with-excheck: Remove.
11902         * contrib/exsummary.py: Remove.
11903         * contrib/excheck.py: Remove.
11904
11905 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11906
11907         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11908         NULL. Initialize tpprev to NULL instead of assigning it
11909         to NULL on the next statement.
11910         * windows-nat.c (windows_delete_thread): Remove check for
11911         main_thread_id before printing thread exit notifications.
11912         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11913         Remove thread ID check against main_thread_id.
11914         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11915         windows_delete_thread.
11916         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11917
11918 2019-01-04  Tom Tromey  <tom@tromey.com>
11919
11920         * compile/compile.c (_initialize_compile): Use upper case for
11921         metasyntactic variables.
11922         * symmisc.c (_initialize_symmisc): Use upper case for
11923         metasyntactic variables.
11924         * psymtab.c (_initialize_psymtab): Use upper case for
11925         metasyntactic variables.
11926         * demangle.c (demangle_command): Use upper case for metasyntactic
11927         variables.
11928         (_initialize_demangler): Likewise.
11929         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11930         variables.
11931
11932 2019-01-03  Tom Tromey  <tom@tromey.com>
11933
11934         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11935
11936 2019-01-03  Tom Tromey  <tom@tromey.com>
11937
11938         * python/py-symtab.c (salpy_str): Update.
11939         (struct salpy_sal_object) <symtab>: Now a PyObject.
11940         (salpy_dealloc): Update.
11941         (del_objfile_sal): Use gdbpy_ref.
11942
11943 2019-01-03  Tom Tromey  <tom@tromey.com>
11944
11945         * python/py-type.c (convert_field): Use new_reference.  Return
11946         gdbpy_ref.
11947         (make_fielditem): Return gdbpy_ref.
11948         (typy_fields): Update.
11949         (typy_getitem): Update.
11950         (field_name): Return gdbpy_ref.  Use new_reference.
11951         (typy_iterator_iternext): Update.
11952
11953 2019-01-03  Tom Tromey  <tom@tromey.com>
11954
11955         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11956
11957 2019-01-03  Tom Tromey  <tom@tromey.com>
11958
11959         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11960         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11961         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11962         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11963         (pspy_set_type_printers): Likewise.
11964         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11965         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11966         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11967         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11968         (objfpy_set_type_printers): Likewise.
11969
11970 2019-01-03  Tom Tromey  <tom@tromey.com>
11971
11972         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11973         (gdbpy_print_stack): Use gdbpy_err_fetch.
11974         * python/python-internal.h (class gdbpy_err_fetch): New class.
11975         (class gdbpy_enter) <m_error_type, m_error_value,
11976         m_error_traceback>: Remove.
11977         <m_error>: New member.
11978         (gdbpy_exception_to_string): Don't declare.
11979         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11980         * python/py-value.c (convert_value_from_python): Use
11981         gdbpy_err_fetch.
11982         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11983         gdbpy_exception_to_string.
11984         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11985         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11986         gdbpy_err_fetch.
11987
11988 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11989
11990         * linux-nat.c (delete_lwp_cleanup): Delete.
11991         (struct lwp_deleter): New struct.
11992         (lwp_info_up): New typedef.
11993         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11994         lwp_info_up.
11995
11996 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11997
11998         * linux-fork.c (class scoped_switch_fork_info): New class.
11999         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12000
12001 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12002
12003         * valops.c (find_overload_match): Remove use of null_cleanup, and
12004         calls to do_cleanups.
12005
12006 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12007
12008         * compile/compile-cplus-types.c
12009         (compile_cplus_instance::decl_name): Handle changes to
12010         cp_func_name.
12011         * cp-support.c (cp_func_name): Update header comment, update
12012         return type.
12013         * cp-support.h (cp_func_name): Update return type in declaration.
12014         * valops.c (find_overload_match): Move temp_func local to top
12015         level of function and change its type.  Use temp_func to hold and
12016         delete temporary string obtained from cp_func_name.
12017
12018 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12019
12020         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12021         gdb::char_vector, remove cleanup, and update uses of `msg`.
12022
12023 2019-01-03  Jim Wilson  <jimw@sifive.com>
12024
12025         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12026
12027 2019-01-02  Tom Tromey  <tom@tromey.com>
12028
12029         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12030         (tdesc_parse_xml): Remove cleanups.
12031         * target-descriptions.h (make_cleanup_free_target_description):
12032         Don't declare.
12033         (target_desc_deleter): New struct.
12034         (target_desc_up): New typedef.
12035         * target-descriptions.c (target_desc_deleter::operator()): Rename
12036         from free_target_description.
12037         (make_cleanup_free_target_description): Remove.
12038
12039 2019-01-02  Tom Tromey  <tom@tromey.com>
12040
12041         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12042         constructor, destructor.
12043         (linespec_parser): Remove typedef.
12044         (~linespec_parser): Rename from linespec_parser_delete.
12045         (linespec_lex_to_end, linespec_complete_label)
12046         (linespec_complete): Update.
12047         (decode_line_full): Remove cleanups.
12048         (decode_line_1): Update.
12049
12050 2019-01-02  Tom Tromey  <tom@tromey.com>
12051
12052         * python/python-internal.h (inferior_to_inferior_object): Change
12053         return type.
12054         * python/py-exitedevent.c (create_exited_event_object): Update.
12055         * python/py-inferior.c (inferior_to_inferior_object): Return
12056         gdbpy_ref.
12057         (python_new_inferior, python_inferior_deleted)
12058         (thread_to_thread_object, delete_thread_object)
12059         (build_inferior_list, gdbpy_selected_inferior): Update.
12060         * python/py-infthread.c (create_thread_object): Update.  Also fail
12061         if inferior_to_inferior_object fails.
12062
12063 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12064
12065         * inferior.h (class inferior) <displaced_step_state>: New field.
12066         * infrun.h (struct displaced_step_state): Move here from
12067         infrun.c.  Initialize fields, add constructor.
12068         <inf>: Remove field.
12069         <reset>: New method.
12070         * infrun.c (struct displaced_step_inferior_state): Move to
12071         infrun.h.
12072         (displaced_step_inferior_states): Remove.
12073         (get_displaced_stepping_state): Adust.
12074         (displaced_step_in_progress_any_inferior): Adjust.
12075         (displaced_step_in_progress_thread): Adjust.
12076         (displaced_step_in_progress): Adjust.
12077         (add_displaced_stepping_state): Remove.
12078         (get_displaced_step_closure_by_addr): Adjust.
12079         (remove_displaced_stepping_state): Remove.
12080         (infrun_inferior_exit): Call displaced_step_state.reset.
12081         (use_displaced_stepping): Don't check for NULL.
12082         (displaced_step_prepare_throw): Call
12083         get_displaced_stepping_state.
12084         (displaced_step_fixup): Don't check for NULL.
12085         (prepare_for_detach): Don't check for NULL.
12086
12087 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12088
12089         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12090          in case of call that did not complete.
12091
12092 2019-01-02  Andrey Utkin  <autkin@undo.io>
12093
12094         * symfile.c (find_separate_debug_file): Fix search of debug files for
12095         remote debuggee.
12096
12097 2019-01-02  Tom Tromey  <tom@tromey.com>
12098
12099         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12100         indentation.
12101         * python/py-frame.c (frapy_older): Remove cast.
12102         (frapy_newer): Likewise.
12103         * python/py-breakpoint.c (local_setattro): Remove cast.
12104         * python/py-arch.c (archpy_name): Remove local variable.
12105         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12106
12107 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12108
12109         * unittests/basic_string_view/element_access/char/empty.cc:
12110         Fix year range in copyright header.
12111
12112 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12113
12114         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12115         Delete.
12116         <operator==>: Update with for removed field.
12117         <hash>: Likewise.
12118         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12119         <isa_features>: ...this.
12120         <abi_features>: New field.
12121         (riscv_isa_flen): Update comment.
12122         (riscv_abi_xlen): New declaration.
12123         (riscv_abi_flen): New declaration.
12124         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12125         isa_features.
12126         (riscv_abi_xlen): New function.
12127         (riscv_isa_flen): Update to get answer from isa_features.
12128         (riscv_abi_flen): New function.
12129         (riscv_has_fp_abi): Update to get answer from abi_features.
12130         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12131         xlen and flen.
12132         (riscv_call_info) <xlen, flen>: Update comment.
12133         (riscv_call_arg_struct): Remove invalid assertions
12134         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12135         is removed.
12136         (riscv_gdbarch_init): Gather isa features and abi features
12137         separately, ensure both match on the gdbarch when reusing an old
12138         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12139         a target with 64-bit float hardware.
12140
12141 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12142
12143         * source.c (search_command_helper): Stop reverse search
12144         when line 1 has been searched.
12145
12146 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12147
12148         * record-full.c (record_full_base_target::close): Rewrite
12149         record_full_core_buf_list free logic.
12150
12151 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12152
12153         * break-catch-syscall.c (print_one_catch_syscall): xfree
12154         the last text.
12155
12156 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12157
12158         * top.c (print_gdb_version): Update Copyright year in version
12159         message.
12160
12161 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12162
12163         Update copyright year range in all GDB files.
12164
12165 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12166
12167         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12168
12169 For older changes see ChangeLog-2018.
12170 \f
12171 Local Variables:
12172 mode: change-log
12173 left-margin: 8
12174 fill-column: 74
12175 version-control: never
12176 coding: utf-8
12177 End:
12178