ld TDIRS substitution
[external/binutils.git] / gdb / ChangeLog
1 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4         target types of size 96-bits, add some additional comments, and
5         check that the builtin type we found was the correct size.
6
7 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8
9         * utils.c (prompt_for_continue): Don't restore the styling at the
10         end, as applied_style has the wrong value.  This fixes styling in
11         long lists of file names that are interrupted by the "Continue?"
12         prompt.
13
14 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
15
16         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
17         * c-lang.c (c_language_defn): Likewise.
18         (cplus_language_defn): Likewise.
19         (asm_language_defn): Likewise.
20         (minimal_language_defn): Likewise.
21         * d-lang.c (d_language_defn): Likewise.
22         * f-lang.c (f_language_defn): Likewise.
23         * go-lang.c (go_language_defn): Likewise.
24         * language.c (unknown_language_defn): Likewise.
25         (auto_language_defn): Likewise.
26         * language.h (struct language_defn): Remove la_magic field.
27         (LANG_MAGIC): Delete.
28         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
29         * objc-lang.c (objc_language_defn): Likewise.
30         * opencl-lang.c (opencl_language_defn): Likewise.
31         * p-lang.c (pascal_language_defn): Likewise.
32         * rust-lang.c (rust_language_defn): Likewise.
33
34 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
35
36         * riscv-tdep.c (riscv_type_align): New function.
37         (riscv_type_alignment): Delete.
38         (riscv_arg_location): Use 'type_align'.
39         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
40
41 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
42
43         * gdbtypes.c (type_align): A struct with no non-static fields also
44         has alignment of 1.
45
46 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
47
48         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
49         component to 0.
50         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
51         member.
52         (riscv_struct_info::analyse): New implementation using new
53         analyse_inner member function.
54         (riscv_struct_info::field_offset): New member function.
55         (riscv_struct_info::m_offsets): New member variable.
56         (riscv_struct_info::analyse_inner): New private member function,
57         takes the old implementation of riscv_struct_info::analyse but
58         extended to track field offsets.
59         (riscv_call_arg_struct): Update the struct folding special cases
60         to handle cases where empty C++ structs, which are non-zero
61         length, are found.
62         (riscv_arg_location): Initialise the length of each location, a
63         non-zero length now indicates the location is in use.
64         (riscv_push_dummy_call): Allow for the first location having a
65         non-zero offset when setting up arguments.
66         (riscv_return_value): Likewise, but for return values.
67
68 2019-04-11  Tom Tromey  <tromey@adacore.com>
69
70         * utils.c (internal_vproblem): Make "msg" const.
71
72 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
73
74         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
75         * trad-frame.c (trad_frame_reset_saved_regs): New function.
76         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
77         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
78
79 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
80
81         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
82         function.
83         (fill_gregset): Call amd64_linux_collect_native_gregset instead
84         of amd64_collect_native_gregset.
85         (amd64_linux_nat_target::store_registers): Likewise.
86
87 2019-04-10  Tom Tromey  <tom@tromey.com>
88
89         * symtab.c (lookup_global_symbol_from_objfile)
90         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
91         * objfiles.h (class separate_debug_iterator): New.
92         (class separate_debug_range): New.
93         (struct objfile) <separate_debug_objfiles>: New method.
94         (objfile_separate_debug_iterate): Don't declare.
95         * objfiles.c (separate_debug_iterator::operator++): Rename from
96         objfile_separate_debug_iterate.
97         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
98         iterator.
99         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
100         iterator.
101
102 2019-04-10  Tom Tromey  <tom@tromey.com>
103
104         * symfile.c (reread_symbols): Remove old comment.
105         * objfiles.c (free_all_objfiles): Fix a typo.
106
107 2019-04-10  Tom Tromey  <tom@tromey.com>
108
109         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
110         * minsyms.c (lookup_minimal_symbol): Use foreach.
111         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
112         (lookup_minimal_symbol_solib_trampoline): Likewise.
113         * symfile.c (reread_symbols): Use foreach.
114
115 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
116             Tom Tromey  <tromey@adacore.com>
117
118         PR rust/24414:
119         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
120         (rust_lex_int_test): Change "value" to be LONGEST.
121         (rust_lex_tests): Add test for long integer literal.
122
123 2019-04-09  Tom Tromey  <tromey@adacore.com>
124
125         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
126         to bool.
127         (extended_remote_target::attach): Update.
128         (remote_target::remote_notice_new_inferior): Update.
129         (remote_target::add_current_inferior_and_thread): Update.
130         * inferior.c (exit_inferior_1): Use "false".
131         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
132
133 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
134
135         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
136         the "start" command.
137
138 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
139
140         * python/py-inferior.c (infpy_thread_from_thread_handle):
141         Adjust comments to reflect renaming of thread_from_thread_handle
142         to thread_from_handle.  Adjust keywords.  Fix type error message.
143         (inferior_object_methods): Add thread_from_handle.  Retain
144         thread_from_thread_handle, but mark it as deprecated.
145
146 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
147
148         * gdbthread.h (find_thread_by_handle): Revise declaration.
149         * thread.c (find_thread_by_handle): Likewise.  Adjust
150         implementation too.
151         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
152         support for buffer objects as handles.
153
154 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
155
156         * python/py-infthread.c (thpy_thread_handle): New function.
157         (thread_object_methods): Register thpy_thread_handle.
158
159 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
160
161         * gdbthread.h (thread_to_thread_handle): Declare.
162         * thread.c (gdbtypes.h): Include.
163         (thread_to_thread_handle): New function.
164
165         * target.h (struct target_ops): Add thread_info_to_thread_handle.
166         (target_thread_info_to_thread_handle): Declare.
167         * target.c (target_thread_info_to_thread_handle): New function.
168         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
169         * target-delegates.c: Regenerate.
170
171         * linux-thread-db.c (class thread_db_target): Add method
172         thread_info_to_thread_handle.
173         (thread_db_target::thread_info_to_thread_handle): Define.
174         * remote.c (class remote_target): Add new method
175         thread_info_to_thread_handle.
176         (remote_target::thread_info_to_thread_handle): Define.
177
178 2019-04-08  Pedro Alves  <palves@redhat.com>
179
180         * common/common-exceptions.c (throw_exception): Don't create
181         named object to throw; throw directly.
182         (throw_it): Likewise.  Don't initialize gdb_exception::message
183         here, with new; pass FMT and AP to the ctor instead.
184         * common/common-exceptions.h: Include <string>.
185         (gdb_exception::gdb_exception(enum return_reason, enum errors,
186         const char *, va_list)): New ctor.  Use std::make_shared.
187         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
188         errors)): Delete.
189         (gdb_exception_error::gdb_exception_error(enum errors, const char
190         *, va_list)): New.
191         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
192         Add assertion.
193         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
194         errors)): Delete.
195         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
196         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
197         Add assertion.
198
199 2019-04-08  Tom Tromey  <tom@tromey.com>
200
201         * valops.c (value_rtti_indirect_type): Replace throw_exception
202         with throw.
203         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
204         with throw.
205         * thread.c (thr_try_catch_cmd): Replace throw_exception with
206         throw.
207         * target.c (target_translate_tls_address): Replace throw_exception
208         with throw.
209         * stack.c (frame_apply_command_count): Replace throw_exception
210         with throw.
211         * solib-spu.c (append_ocl_sos): Replace throw_exception with
212         throw.
213         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
214         with throw.
215         * rs6000-tdep.c (rs6000_frame_cache)
216         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
217         * remote.c: Replace throw_exception with throw.
218         * record-full.c (record_full_message, record_full_wait_1)
219         (record_full_restore): Replace throw_exception with throw.
220         * record-btrace.c:
221         (get_thread_current_frame_id, record_btrace_start_replaying)
222         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
223         (cmd_record_btrace_start): Replace throw_exception with throw.
224         * parse.c (parse_exp_in_context_1): Replace throw_exception with
225         throw.
226         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
227         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
228         * linespec.c:
229         (find_linespec_symbols): Replace throw_exception with throw.
230         * infrun.c (displaced_step_prepare, resume): Replace
231         throw_exception with throw.
232         * infcmd.c (post_create_inferior): Replace throw_exception with
233         throw.
234         * inf-loop.c (inferior_event_handler): Replace throw_exception
235         with throw.
236         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
237         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
238         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
239         (get_prev_frame_always, get_frame_pc_if_available)
240         (get_frame_address_in_block_if_available, get_frame_language):
241         Replace throw_exception with throw.
242         * frame-unwind.c (frame_unwind_try_unwinder): Replace
243         throw_exception with throw.
244         * eval.c (fetch_subexp_value, evaluate_var_value)
245         (evaluate_funcall, evaluate_subexp_standard): Replace
246         throw_exception with throw.
247         * dwarf2loc.c (call_site_find_chain)
248         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
249         Replace throw_exception with throw.
250         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
251         with throw.
252         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
253         throw.
254         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
255         * completer.c (complete_line_internal): Replace throw_exception
256         with throw.
257         * compile/compile-object-run.c (compile_object_run): Replace
258         throw_exception with throw.
259         * cli/cli-script.c (process_next_line): Replace throw_exception
260         with throw.
261         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
262         (btrace_enable, btrace_maint_update_pt_packets): Replace
263         throw_exception with throw.
264         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
265         throw_exception with throw.
266         * break-catch-throw.c (re_set_exception_catchpoint): Replace
267         throw_exception with throw.
268         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
269         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
270         * aarch64-tdep.c (aarch64_make_prologue_cache)
271         (aarch64_make_stub_cache): Replace throw_exception with throw.
272
273 2019-04-08  Tom Tromey  <tom@tromey.com>
274
275         * common/common-exceptions.c (throw_exception): Rename from
276         throw_exception_cxx.  Remove old copy.  Make argument const.
277         (throw_it): Create and throw exception objects directly.
278         * common/common-exceptions.h (throw_exception): Make argument
279         const.
280         (struct gdb_exception_error): Add constructor.
281         (struct gdb_exception_quit): Add constructor.
282
283 2019-04-08  Tom Tromey  <tom@tromey.com>
284
285         * common/common-exceptions.h (exception_rethrow): Don't declare.
286         (TRY_SJLJ): Update comment.
287         (TRY, CATCH, END_CATCH): Remove.
288         * common/common-exceptions.c (exception_rethrow): Remove.
289
290 2019-04-08  Tom Tromey  <tom@tromey.com>
291
292         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
293         Remove.
294         (gdb_exception_error): Rename from
295         gdb_exception_RETURN_MASK_ERROR.
296         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
297         (gdb_quit_bad_alloc): Update.
298         * aarch64-tdep.c: Update.
299         * ada-lang.c: Update.
300         * ada-typeprint.c: Update.
301         * ada-valprint.c: Update.
302         * amd64-tdep.c: Update.
303         * arch-utils.c: Update.
304         * break-catch-throw.c: Update.
305         * breakpoint.c: Update.
306         * btrace.c: Update.
307         * c-varobj.c: Update.
308         * cli/cli-cmds.c: Update.
309         * cli/cli-interp.c: Update.
310         * cli/cli-script.c: Update.
311         * common/common-exceptions.c: Update.
312         * common/new-op.c: Update.
313         * common/selftest.c: Update.
314         * compile/compile-c-symbols.c: Update.
315         * compile/compile-cplus-symbols.c: Update.
316         * compile/compile-object-load.c: Update.
317         * compile/compile-object-run.c: Update.
318         * completer.c: Update.
319         * corelow.c: Update.
320         * cp-abi.c: Update.
321         * cp-support.c: Update.
322         * cp-valprint.c: Update.
323         * darwin-nat.c: Update.
324         * disasm-selftests.c: Update.
325         * dtrace-probe.c: Update.
326         * dwarf-index-cache.c: Update.
327         * dwarf-index-write.c: Update.
328         * dwarf2-frame-tailcall.c: Update.
329         * dwarf2-frame.c: Update.
330         * dwarf2loc.c: Update.
331         * dwarf2read.c: Update.
332         * eval.c: Update.
333         * event-loop.c: Update.
334         * event-top.c: Update.
335         * exec.c: Update.
336         * f-valprint.c: Update.
337         * fbsd-tdep.c: Update.
338         * frame-unwind.c: Update.
339         * frame.c: Update.
340         * gdbtypes.c: Update.
341         * gnu-v3-abi.c: Update.
342         * guile/guile-internal.h: Update.
343         * guile/scm-block.c: Update.
344         * guile/scm-breakpoint.c: Update.
345         * guile/scm-cmd.c: Update.
346         * guile/scm-disasm.c: Update.
347         * guile/scm-frame.c: Update.
348         * guile/scm-lazy-string.c: Update.
349         * guile/scm-math.c: Update.
350         * guile/scm-param.c: Update.
351         * guile/scm-ports.c: Update.
352         * guile/scm-pretty-print.c: Update.
353         * guile/scm-symbol.c: Update.
354         * guile/scm-symtab.c: Update.
355         * guile/scm-type.c: Update.
356         * guile/scm-value.c: Update.
357         * i386-linux-tdep.c: Update.
358         * i386-tdep.c: Update.
359         * inf-loop.c: Update.
360         * infcall.c: Update.
361         * infcmd.c: Update.
362         * infrun.c: Update.
363         * jit.c: Update.
364         * language.c: Update.
365         * linespec.c: Update.
366         * linux-fork.c: Update.
367         * linux-nat.c: Update.
368         * linux-tdep.c: Update.
369         * linux-thread-db.c: Update.
370         * main.c: Update.
371         * mi/mi-cmd-break.c: Update.
372         * mi/mi-cmd-stack.c: Update.
373         * mi/mi-interp.c: Update.
374         * mi/mi-main.c: Update.
375         * objc-lang.c: Update.
376         * p-valprint.c: Update.
377         * parse.c: Update.
378         * ppc-linux-tdep.c: Update.
379         * printcmd.c: Update.
380         * python/py-arch.c: Update.
381         * python/py-breakpoint.c: Update.
382         * python/py-cmd.c: Update.
383         * python/py-finishbreakpoint.c: Update.
384         * python/py-frame.c: Update.
385         * python/py-framefilter.c: Update.
386         * python/py-gdb-readline.c: Update.
387         * python/py-inferior.c: Update.
388         * python/py-infthread.c: Update.
389         * python/py-lazy-string.c: Update.
390         * python/py-linetable.c: Update.
391         * python/py-objfile.c: Update.
392         * python/py-param.c: Update.
393         * python/py-prettyprint.c: Update.
394         * python/py-progspace.c: Update.
395         * python/py-record-btrace.c: Update.
396         * python/py-record.c: Update.
397         * python/py-symbol.c: Update.
398         * python/py-type.c: Update.
399         * python/py-unwind.c: Update.
400         * python/py-utils.c: Update.
401         * python/py-value.c: Update.
402         * python/python.c: Update.
403         * record-btrace.c: Update.
404         * record-full.c: Update.
405         * remote-fileio.c: Update.
406         * remote.c: Update.
407         * riscv-tdep.c: Update.
408         * rs6000-aix-tdep.c: Update.
409         * rs6000-tdep.c: Update.
410         * rust-exp.y: Update.
411         * rust-lang.c: Update.
412         * s390-tdep.c: Update.
413         * selftest-arch.c: Update.
414         * solib-dsbt.c: Update.
415         * solib-frv.c: Update.
416         * solib-spu.c: Update.
417         * solib-svr4.c: Update.
418         * solib.c: Update.
419         * sparc64-linux-tdep.c: Update.
420         * stack.c: Update.
421         * symfile-mem.c: Update.
422         * symmisc.c: Update.
423         * target.c: Update.
424         * thread.c: Update.
425         * top.c: Update.
426         * tracefile-tfile.c: Update.
427         * tui/tui.c: Update.
428         * typeprint.c: Update.
429         * unittests/cli-utils-selftests.c: Update.
430         * unittests/parse-connection-spec-selftests.c: Update.
431         * valops.c: Update.
432         * valprint.c: Update.
433         * value.c: Update.
434         * varobj.c: Update.
435         * windows-nat.c: Update.
436         * x86-linux-nat.c: Update.
437         * xml-support.c: Update.
438
439 2019-04-08  Tom Tromey  <tom@tromey.com>
440
441         * xml-support.c: Use C++ exception handling.
442         * x86-linux-nat.c: Use C++ exception handling.
443         * windows-nat.c: Use C++ exception handling.
444         * varobj.c: Use C++ exception handling.
445         * value.c: Use C++ exception handling.
446         * valprint.c: Use C++ exception handling.
447         * valops.c: Use C++ exception handling.
448         * unittests/parse-connection-spec-selftests.c: Use C++ exception
449         handling.
450         * unittests/cli-utils-selftests.c: Use C++ exception handling.
451         * typeprint.c: Use C++ exception handling.
452         * tui/tui.c: Use C++ exception handling.
453         * tracefile-tfile.c: Use C++ exception handling.
454         * top.c: Use C++ exception handling.
455         * thread.c: Use C++ exception handling.
456         * target.c: Use C++ exception handling.
457         * symmisc.c: Use C++ exception handling.
458         * symfile-mem.c: Use C++ exception handling.
459         * stack.c: Use C++ exception handling.
460         * sparc64-linux-tdep.c: Use C++ exception handling.
461         * solib.c: Use C++ exception handling.
462         * solib-svr4.c: Use C++ exception handling.
463         * solib-spu.c: Use C++ exception handling.
464         * solib-frv.c: Use C++ exception handling.
465         * solib-dsbt.c: Use C++ exception handling.
466         * selftest-arch.c: Use C++ exception handling.
467         * s390-tdep.c: Use C++ exception handling.
468         * rust-lang.c: Use C++ exception handling.
469         * rust-exp.y: Use C++ exception handling.
470         * rs6000-tdep.c: Use C++ exception handling.
471         * rs6000-aix-tdep.c: Use C++ exception handling.
472         * riscv-tdep.c: Use C++ exception handling.
473         * remote.c: Use C++ exception handling.
474         * remote-fileio.c: Use C++ exception handling.
475         * record-full.c: Use C++ exception handling.
476         * record-btrace.c: Use C++ exception handling.
477         * python/python.c: Use C++ exception handling.
478         * python/py-value.c: Use C++ exception handling.
479         * python/py-utils.c: Use C++ exception handling.
480         * python/py-unwind.c: Use C++ exception handling.
481         * python/py-type.c: Use C++ exception handling.
482         * python/py-symbol.c: Use C++ exception handling.
483         * python/py-record.c: Use C++ exception handling.
484         * python/py-record-btrace.c: Use C++ exception handling.
485         * python/py-progspace.c: Use C++ exception handling.
486         * python/py-prettyprint.c: Use C++ exception handling.
487         * python/py-param.c: Use C++ exception handling.
488         * python/py-objfile.c: Use C++ exception handling.
489         * python/py-linetable.c: Use C++ exception handling.
490         * python/py-lazy-string.c: Use C++ exception handling.
491         * python/py-infthread.c: Use C++ exception handling.
492         * python/py-inferior.c: Use C++ exception handling.
493         * python/py-gdb-readline.c: Use C++ exception handling.
494         * python/py-framefilter.c: Use C++ exception handling.
495         * python/py-frame.c: Use C++ exception handling.
496         * python/py-finishbreakpoint.c: Use C++ exception handling.
497         * python/py-cmd.c: Use C++ exception handling.
498         * python/py-breakpoint.c: Use C++ exception handling.
499         * python/py-arch.c: Use C++ exception handling.
500         * printcmd.c: Use C++ exception handling.
501         * ppc-linux-tdep.c: Use C++ exception handling.
502         * parse.c: Use C++ exception handling.
503         * p-valprint.c: Use C++ exception handling.
504         * objc-lang.c: Use C++ exception handling.
505         * mi/mi-main.c: Use C++ exception handling.
506         * mi/mi-interp.c: Use C++ exception handling.
507         * mi/mi-cmd-stack.c: Use C++ exception handling.
508         * mi/mi-cmd-break.c: Use C++ exception handling.
509         * main.c: Use C++ exception handling.
510         * linux-thread-db.c: Use C++ exception handling.
511         * linux-tdep.c: Use C++ exception handling.
512         * linux-nat.c: Use C++ exception handling.
513         * linux-fork.c: Use C++ exception handling.
514         * linespec.c: Use C++ exception handling.
515         * language.c: Use C++ exception handling.
516         * jit.c: Use C++ exception handling.
517         * infrun.c: Use C++ exception handling.
518         * infcmd.c: Use C++ exception handling.
519         * infcall.c: Use C++ exception handling.
520         * inf-loop.c: Use C++ exception handling.
521         * i386-tdep.c: Use C++ exception handling.
522         * i386-linux-tdep.c: Use C++ exception handling.
523         * guile/scm-value.c: Use C++ exception handling.
524         * guile/scm-type.c: Use C++ exception handling.
525         * guile/scm-symtab.c: Use C++ exception handling.
526         * guile/scm-symbol.c: Use C++ exception handling.
527         * guile/scm-pretty-print.c: Use C++ exception handling.
528         * guile/scm-ports.c: Use C++ exception handling.
529         * guile/scm-param.c: Use C++ exception handling.
530         * guile/scm-math.c: Use C++ exception handling.
531         * guile/scm-lazy-string.c: Use C++ exception handling.
532         * guile/scm-frame.c: Use C++ exception handling.
533         * guile/scm-disasm.c: Use C++ exception handling.
534         * guile/scm-cmd.c: Use C++ exception handling.
535         * guile/scm-breakpoint.c: Use C++ exception handling.
536         * guile/scm-block.c: Use C++ exception handling.
537         * guile/guile-internal.h: Use C++ exception handling.
538         * gnu-v3-abi.c: Use C++ exception handling.
539         * gdbtypes.c: Use C++ exception handling.
540         * frame.c: Use C++ exception handling.
541         * frame-unwind.c: Use C++ exception handling.
542         * fbsd-tdep.c: Use C++ exception handling.
543         * f-valprint.c: Use C++ exception handling.
544         * exec.c: Use C++ exception handling.
545         * event-top.c: Use C++ exception handling.
546         * event-loop.c: Use C++ exception handling.
547         * eval.c: Use C++ exception handling.
548         * dwarf2read.c: Use C++ exception handling.
549         * dwarf2loc.c: Use C++ exception handling.
550         * dwarf2-frame.c: Use C++ exception handling.
551         * dwarf2-frame-tailcall.c: Use C++ exception handling.
552         * dwarf-index-write.c: Use C++ exception handling.
553         * dwarf-index-cache.c: Use C++ exception handling.
554         * dtrace-probe.c: Use C++ exception handling.
555         * disasm-selftests.c: Use C++ exception handling.
556         * darwin-nat.c: Use C++ exception handling.
557         * cp-valprint.c: Use C++ exception handling.
558         * cp-support.c: Use C++ exception handling.
559         * cp-abi.c: Use C++ exception handling.
560         * corelow.c: Use C++ exception handling.
561         * completer.c: Use C++ exception handling.
562         * compile/compile-object-run.c: Use C++ exception handling.
563         * compile/compile-object-load.c: Use C++ exception handling.
564         * compile/compile-cplus-symbols.c: Use C++ exception handling.
565         * compile/compile-c-symbols.c: Use C++ exception handling.
566         * common/selftest.c: Use C++ exception handling.
567         * common/new-op.c: Use C++ exception handling.
568         * cli/cli-script.c: Use C++ exception handling.
569         * cli/cli-interp.c: Use C++ exception handling.
570         * cli/cli-cmds.c: Use C++ exception handling.
571         * c-varobj.c: Use C++ exception handling.
572         * btrace.c: Use C++ exception handling.
573         * breakpoint.c: Use C++ exception handling.
574         * break-catch-throw.c: Use C++ exception handling.
575         * arch-utils.c: Use C++ exception handling.
576         * amd64-tdep.c: Use C++ exception handling.
577         * ada-valprint.c: Use C++ exception handling.
578         * ada-typeprint.c: Use C++ exception handling.
579         * ada-lang.c: Use C++ exception handling.
580         * aarch64-tdep.c: Use C++ exception handling.
581
582 2019-04-08  Tom Tromey  <tom@tromey.com>
583
584         * xml-support.c (gdb_xml_parser::parse): Update.
585         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
586         * value.c (show_convenience): Update.
587         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
588         (test_parse_flags_qcs): Update.
589         * thread.c (thr_try_catch_cmd): Update.
590         * target.c (target_translate_tls_address): Update.
591         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
592         (info_frame_command_core, frame_apply_command_count): Update.
593         * rust-exp.y (rust_lex_exception_test): Update.
594         * riscv-tdep.c (riscv_print_one_register_info): Update.
595         * remote.c (remote_target::enable_btrace): Update.
596         * record-btrace.c (record_btrace_enable_warn): Update.
597         * python/py-utils.c (gdbpy_convert_exception): Update.
598         * printcmd.c (do_one_display, print_variable_and_value): Update.
599         * mi/mi-main.c (mi_print_exception): Update.
600         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
601         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
602         * linux-nat.c (linux_nat_target::attach): Update.
603         * linux-fork.c (class scoped_switch_fork_info): Update.
604         * infrun.c (displaced_step_prepare): Update.
605         * infcall.c (call_function_by_hand_dummy): Update.
606         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
607         * gnu-v3-abi.c (print_one_vtable): Update.
608         * frame.c (get_prev_frame_always): Update.
609         * f-valprint.c (info_common_command_for_block): Update.
610         * exec.c (try_open_exec_file): Update.
611         * exceptions.c (print_exception, exception_print)
612         (exception_fprintf, exception_print_same): Update.
613         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
614         * dwarf-index-cache.c (index_cache::store)
615         (index_cache::lookup_gdb_index): Update.
616         * darwin-nat.c (maybe_cache_shell): Update.
617         * cp-valprint.c (cp_print_value_fields): Update.
618         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
619         (gcc_cplus_symbol_address): Update.
620         * compile/compile-c-symbols.c (gcc_convert_symbol)
621         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
622         * common/selftest.c: Update.
623         * common/common-exceptions.h (struct gdb_exception) <message>: Now
624         a std::string.
625         (exception_try_scope_entry, exception_try_scope_exit): Don't
626         declare.
627         (struct exception_try_scope): Remove.
628         (TRY): Don't use exception_try_scope.
629         (struct gdb_exception): Add constructor, operator=.
630         <what>: New method.
631         (struct gdb_exception_RETURN_MASK_ALL)
632         (struct gdb_exception_RETURN_MASK_ERROR)
633         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
634         (struct gdb_quit_bad_alloc): Update.
635         * common/common-exceptions.c (exception_none): Change
636         initializer.
637         (struct catcher) <state, exception>: Initialize inline.
638         <prev>: Remove member.
639         (current_catcher): Remove.
640         (catchers): New global.
641         (exceptions_state_mc_init): Simplify.
642         (catcher_pop): Remove.
643         (exceptions_state_mc, exceptions_state_mc_catch): Update.
644         (try_scope_depth, exception_try_scope_entry)
645         (exception_try_scope_exit): Remove.
646         (throw_exception_sjlj): Update.
647         (exception_messages, exception_messages_size): Remove.
648         (throw_it): Simplify.
649         (gdb_exception_sliced_copy): Remove.
650         (throw_exception_cxx): Update.
651         * cli/cli-script.c (script_from_file): Update.
652         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
653         Update.
654         * ada-valprint.c (ada_val_print): Update.
655         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
656         (create_excep_cond_exprs): Update.
657
658 2019-04-08  Tom Tromey  <tom@tromey.com>
659
660         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
661         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
662         (TRY, CATCH, END_CATCH): Remove some definitions.
663         * common/common-exceptions.c: Don't use GDB_XCPT.
664         (catcher_list_size): Remove.
665         (throw_exception, throw_it): Simplify.
666
667 2019-04-05  Tom Tromey  <tom@tromey.com>
668
669         Revert the header-sorting patch.
670         * ft32-tdep.c: Revert.
671         * frv-tdep.c: Revert.
672         * frv-linux-tdep.c: Revert.
673         * frame.c: Revert.
674         * frame-unwind.c: Revert.
675         * frame-base.c: Revert.
676         * fork-child.c: Revert.
677         * findvar.c: Revert.
678         * findcmd.c: Revert.
679         * filesystem.c: Revert.
680         * filename-seen-cache.h: Revert.
681         * filename-seen-cache.c: Revert.
682         * fbsd-tdep.c: Revert.
683         * fbsd-nat.h: Revert.
684         * fbsd-nat.c: Revert.
685         * f-valprint.c: Revert.
686         * f-typeprint.c: Revert.
687         * f-lang.c: Revert.
688         * extension.h: Revert.
689         * extension.c: Revert.
690         * extension-priv.h: Revert.
691         * expprint.c: Revert.
692         * exec.h: Revert.
693         * exec.c: Revert.
694         * exceptions.c: Revert.
695         * event-top.c: Revert.
696         * event-loop.c: Revert.
697         * eval.c: Revert.
698         * elfread.c: Revert.
699         * dwarf2read.h: Revert.
700         * dwarf2read.c: Revert.
701         * dwarf2loc.c: Revert.
702         * dwarf2expr.h: Revert.
703         * dwarf2expr.c: Revert.
704         * dwarf2-frame.c: Revert.
705         * dwarf2-frame-tailcall.c: Revert.
706         * dwarf-index-write.h: Revert.
707         * dwarf-index-write.c: Revert.
708         * dwarf-index-common.c: Revert.
709         * dwarf-index-cache.h: Revert.
710         * dwarf-index-cache.c: Revert.
711         * dummy-frame.c: Revert.
712         * dtrace-probe.c: Revert.
713         * disasm.h: Revert.
714         * disasm.c: Revert.
715         * disasm-selftests.c: Revert.
716         * dictionary.c: Revert.
717         * dicos-tdep.c: Revert.
718         * demangle.c: Revert.
719         * dcache.h: Revert.
720         * dcache.c: Revert.
721         * darwin-nat.h: Revert.
722         * darwin-nat.c: Revert.
723         * darwin-nat-info.c: Revert.
724         * d-valprint.c: Revert.
725         * d-namespace.c: Revert.
726         * d-lang.c: Revert.
727         * ctf.c: Revert.
728         * csky-tdep.c: Revert.
729         * csky-linux-tdep.c: Revert.
730         * cris-tdep.c: Revert.
731         * cris-linux-tdep.c: Revert.
732         * cp-valprint.c: Revert.
733         * cp-support.c: Revert.
734         * cp-namespace.c: Revert.
735         * cp-abi.c: Revert.
736         * corelow.c: Revert.
737         * corefile.c: Revert.
738         * continuations.c: Revert.
739         * completer.h: Revert.
740         * completer.c: Revert.
741         * complaints.c: Revert.
742         * coffread.c: Revert.
743         * coff-pe-read.c: Revert.
744         * cli-out.h: Revert.
745         * cli-out.c: Revert.
746         * charset.c: Revert.
747         * c-varobj.c: Revert.
748         * c-valprint.c: Revert.
749         * c-typeprint.c: Revert.
750         * c-lang.c: Revert.
751         * buildsym.c: Revert.
752         * buildsym-legacy.c: Revert.
753         * build-id.h: Revert.
754         * build-id.c: Revert.
755         * btrace.c: Revert.
756         * bsd-uthread.c: Revert.
757         * breakpoint.h: Revert.
758         * breakpoint.c: Revert.
759         * break-catch-throw.c: Revert.
760         * break-catch-syscall.c: Revert.
761         * break-catch-sig.c: Revert.
762         * blockframe.c: Revert.
763         * block.c: Revert.
764         * bfin-tdep.c: Revert.
765         * bfin-linux-tdep.c: Revert.
766         * bfd-target.c: Revert.
767         * bcache.c: Revert.
768         * ax-general.c: Revert.
769         * ax-gdb.h: Revert.
770         * ax-gdb.c: Revert.
771         * avr-tdep.c: Revert.
772         * auxv.c: Revert.
773         * auto-load.c: Revert.
774         * arm-wince-tdep.c: Revert.
775         * arm-tdep.c: Revert.
776         * arm-symbian-tdep.c: Revert.
777         * arm-pikeos-tdep.c: Revert.
778         * arm-obsd-tdep.c: Revert.
779         * arm-nbsd-tdep.c: Revert.
780         * arm-nbsd-nat.c: Revert.
781         * arm-linux-tdep.c: Revert.
782         * arm-linux-nat.c: Revert.
783         * arm-fbsd-tdep.c: Revert.
784         * arm-fbsd-nat.c: Revert.
785         * arm-bsd-tdep.c: Revert.
786         * arch-utils.c: Revert.
787         * arc-tdep.c: Revert.
788         * arc-newlib-tdep.c: Revert.
789         * annotate.h: Revert.
790         * annotate.c: Revert.
791         * amd64-windows-tdep.c: Revert.
792         * amd64-windows-nat.c: Revert.
793         * amd64-tdep.c: Revert.
794         * amd64-sol2-tdep.c: Revert.
795         * amd64-obsd-tdep.c: Revert.
796         * amd64-obsd-nat.c: Revert.
797         * amd64-nbsd-tdep.c: Revert.
798         * amd64-nbsd-nat.c: Revert.
799         * amd64-nat.c: Revert.
800         * amd64-linux-tdep.c: Revert.
801         * amd64-linux-nat.c: Revert.
802         * amd64-fbsd-tdep.c: Revert.
803         * amd64-fbsd-nat.c: Revert.
804         * amd64-dicos-tdep.c: Revert.
805         * amd64-darwin-tdep.c: Revert.
806         * amd64-bsd-nat.c: Revert.
807         * alpha-tdep.c: Revert.
808         * alpha-obsd-tdep.c: Revert.
809         * alpha-nbsd-tdep.c: Revert.
810         * alpha-mdebug-tdep.c: Revert.
811         * alpha-linux-tdep.c: Revert.
812         * alpha-linux-nat.c: Revert.
813         * alpha-bsd-tdep.c: Revert.
814         * alpha-bsd-nat.c: Revert.
815         * aix-thread.c: Revert.
816         * agent.c: Revert.
817         * addrmap.c: Revert.
818         * ada-varobj.c: Revert.
819         * ada-valprint.c: Revert.
820         * ada-typeprint.c: Revert.
821         * ada-tasks.c: Revert.
822         * ada-lang.c: Revert.
823         * aarch64-tdep.c: Revert.
824         * aarch64-ravenscar-thread.c: Revert.
825         * aarch64-newlib-tdep.c: Revert.
826         * aarch64-linux-tdep.c: Revert.
827         * aarch64-linux-nat.c: Revert.
828         * aarch64-fbsd-tdep.c: Revert.
829         * aarch64-fbsd-nat.c: Revert.
830         * aarch32-linux-nat.c: Revert.
831
832 2019-04-05  Tom Tromey  <tom@tromey.com>
833
834         * ft32-tdep.c: Sort headers.
835         * frv-tdep.c: Sort headers.
836         * frv-linux-tdep.c: Sort headers.
837         * frame.c: Sort headers.
838         * frame-unwind.c: Sort headers.
839         * frame-base.c: Sort headers.
840         * fork-child.c: Sort headers.
841         * findvar.c: Sort headers.
842         * findcmd.c: Sort headers.
843         * filesystem.c: Sort headers.
844         * filename-seen-cache.h: Sort headers.
845         * filename-seen-cache.c: Sort headers.
846         * fbsd-tdep.c: Sort headers.
847         * fbsd-nat.h: Sort headers.
848         * fbsd-nat.c: Sort headers.
849         * f-valprint.c: Sort headers.
850         * f-typeprint.c: Sort headers.
851         * f-lang.c: Sort headers.
852         * extension.h: Sort headers.
853         * extension.c: Sort headers.
854         * extension-priv.h: Sort headers.
855         * expprint.c: Sort headers.
856         * exec.h: Sort headers.
857         * exec.c: Sort headers.
858         * exceptions.c: Sort headers.
859         * event-top.c: Sort headers.
860         * event-loop.c: Sort headers.
861         * eval.c: Sort headers.
862         * elfread.c: Sort headers.
863         * dwarf2read.h: Sort headers.
864         * dwarf2read.c: Sort headers.
865         * dwarf2loc.c: Sort headers.
866         * dwarf2expr.h: Sort headers.
867         * dwarf2expr.c: Sort headers.
868         * dwarf2-frame.c: Sort headers.
869         * dwarf2-frame-tailcall.c: Sort headers.
870         * dwarf-index-write.h: Sort headers.
871         * dwarf-index-write.c: Sort headers.
872         * dwarf-index-common.c: Sort headers.
873         * dwarf-index-cache.h: Sort headers.
874         * dwarf-index-cache.c: Sort headers.
875         * dummy-frame.c: Sort headers.
876         * dtrace-probe.c: Sort headers.
877         * disasm.h: Sort headers.
878         * disasm.c: Sort headers.
879         * disasm-selftests.c: Sort headers.
880         * dictionary.c: Sort headers.
881         * dicos-tdep.c: Sort headers.
882         * demangle.c: Sort headers.
883         * dcache.h: Sort headers.
884         * dcache.c: Sort headers.
885         * darwin-nat.h: Sort headers.
886         * darwin-nat.c: Sort headers.
887         * darwin-nat-info.c: Sort headers.
888         * d-valprint.c: Sort headers.
889         * d-namespace.c: Sort headers.
890         * d-lang.c: Sort headers.
891         * ctf.c: Sort headers.
892         * csky-tdep.c: Sort headers.
893         * csky-linux-tdep.c: Sort headers.
894         * cris-tdep.c: Sort headers.
895         * cris-linux-tdep.c: Sort headers.
896         * cp-valprint.c: Sort headers.
897         * cp-support.c: Sort headers.
898         * cp-namespace.c: Sort headers.
899         * cp-abi.c: Sort headers.
900         * corelow.c: Sort headers.
901         * corefile.c: Sort headers.
902         * continuations.c: Sort headers.
903         * completer.h: Sort headers.
904         * completer.c: Sort headers.
905         * complaints.c: Sort headers.
906         * coffread.c: Sort headers.
907         * coff-pe-read.c: Sort headers.
908         * cli-out.h: Sort headers.
909         * cli-out.c: Sort headers.
910         * charset.c: Sort headers.
911         * c-varobj.c: Sort headers.
912         * c-valprint.c: Sort headers.
913         * c-typeprint.c: Sort headers.
914         * c-lang.c: Sort headers.
915         * buildsym.c: Sort headers.
916         * buildsym-legacy.c: Sort headers.
917         * build-id.h: Sort headers.
918         * build-id.c: Sort headers.
919         * btrace.c: Sort headers.
920         * bsd-uthread.c: Sort headers.
921         * breakpoint.h: Sort headers.
922         * breakpoint.c: Sort headers.
923         * break-catch-throw.c: Sort headers.
924         * break-catch-syscall.c: Sort headers.
925         * break-catch-sig.c: Sort headers.
926         * blockframe.c: Sort headers.
927         * block.c: Sort headers.
928         * bfin-tdep.c: Sort headers.
929         * bfin-linux-tdep.c: Sort headers.
930         * bfd-target.c: Sort headers.
931         * bcache.c: Sort headers.
932         * ax-general.c: Sort headers.
933         * ax-gdb.h: Sort headers.
934         * ax-gdb.c: Sort headers.
935         * avr-tdep.c: Sort headers.
936         * auxv.c: Sort headers.
937         * auto-load.c: Sort headers.
938         * arm-wince-tdep.c: Sort headers.
939         * arm-tdep.c: Sort headers.
940         * arm-symbian-tdep.c: Sort headers.
941         * arm-pikeos-tdep.c: Sort headers.
942         * arm-obsd-tdep.c: Sort headers.
943         * arm-nbsd-tdep.c: Sort headers.
944         * arm-nbsd-nat.c: Sort headers.
945         * arm-linux-tdep.c: Sort headers.
946         * arm-linux-nat.c: Sort headers.
947         * arm-fbsd-tdep.c: Sort headers.
948         * arm-fbsd-nat.c: Sort headers.
949         * arm-bsd-tdep.c: Sort headers.
950         * arch-utils.c: Sort headers.
951         * arc-tdep.c: Sort headers.
952         * arc-newlib-tdep.c: Sort headers.
953         * annotate.h: Sort headers.
954         * annotate.c: Sort headers.
955         * amd64-windows-tdep.c: Sort headers.
956         * amd64-windows-nat.c: Sort headers.
957         * amd64-tdep.c: Sort headers.
958         * amd64-sol2-tdep.c: Sort headers.
959         * amd64-obsd-tdep.c: Sort headers.
960         * amd64-obsd-nat.c: Sort headers.
961         * amd64-nbsd-tdep.c: Sort headers.
962         * amd64-nbsd-nat.c: Sort headers.
963         * amd64-nat.c: Sort headers.
964         * amd64-linux-tdep.c: Sort headers.
965         * amd64-linux-nat.c: Sort headers.
966         * amd64-fbsd-tdep.c: Sort headers.
967         * amd64-fbsd-nat.c: Sort headers.
968         * amd64-dicos-tdep.c: Sort headers.
969         * amd64-darwin-tdep.c: Sort headers.
970         * amd64-bsd-nat.c: Sort headers.
971         * alpha-tdep.c: Sort headers.
972         * alpha-obsd-tdep.c: Sort headers.
973         * alpha-nbsd-tdep.c: Sort headers.
974         * alpha-mdebug-tdep.c: Sort headers.
975         * alpha-linux-tdep.c: Sort headers.
976         * alpha-linux-nat.c: Sort headers.
977         * alpha-bsd-tdep.c: Sort headers.
978         * alpha-bsd-nat.c: Sort headers.
979         * aix-thread.c: Sort headers.
980         * agent.c: Sort headers.
981         * addrmap.c: Sort headers.
982         * ada-varobj.c: Sort headers.
983         * ada-valprint.c: Sort headers.
984         * ada-typeprint.c: Sort headers.
985         * ada-tasks.c: Sort headers.
986         * ada-lang.c: Sort headers.
987         * aarch64-tdep.c: Sort headers.
988         * aarch64-ravenscar-thread.c: Sort headers.
989         * aarch64-newlib-tdep.c: Sort headers.
990         * aarch64-linux-tdep.c: Sort headers.
991         * aarch64-linux-nat.c: Sort headers.
992         * aarch64-fbsd-tdep.c: Sort headers.
993         * aarch64-fbsd-nat.c: Sort headers.
994         * aarch32-linux-nat.c: Sort headers.
995
996 2019-04-04  Tom Tromey  <tom@tromey.com>
997
998         * varobj.c (varobj_create): Update.
999         * rust-exp.y (struct rust_parser) <update_innermost_block,
1000         lookup_symbol>: New methods.
1001         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1002         Rename.
1003         (rust_parser::rust_lookup_type)
1004         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1005         * printcmd.c (display_command, do_one_display): Update.
1006         * parser-defs.h (struct parser_state) <parser_state>: Add
1007         "tracker" parameter.
1008         (block_tracker): New member.
1009         (class innermost_block_tracker) <innermost_block_tracker>: Add
1010         "types" parameter.
1011         <reset>: Remove method.
1012         (innermost_block): Don't declare.
1013         (null_post_parser): Update.
1014         * parse.c (innermost_block): Remove global.
1015         (write_dollar_variable): Update.
1016         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1017         Remove "tracker_types" parameter.
1018         (parse_expression): Add "tracker" parameter.
1019         (parse_expression_for_completion): Update.
1020         (null_post_parser): Add "tracker" parameter.
1021         * p-exp.y: Update rules.
1022         * m2-exp.y: Update rules.
1023         * language.h (struct language_defn) <la_post_parser>: Add
1024         "tracker" parameter.
1025         * go-exp.y: Update rules.
1026         * f-exp.y: Update rules.
1027         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1028         parameter.
1029         * d-exp.y: Update rules.
1030         * c-exp.y: Update rules.
1031         * breakpoint.c (set_breakpoint_condition): Create an
1032         innermost_block_tracker.
1033         (watch_command_1): Likewise.
1034         * ada-lang.c (resolve): Add "tracker" parameter.
1035         (resolve_subexp): Likewise.
1036         * ada-exp.y (write_var_from_sym): Update.
1037
1038 2019-04-04  Tom Tromey  <tom@tromey.com>
1039
1040         * type-stack.h: New file.
1041         * type-stack.c: New file.
1042         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1043         type-stack.h.
1044         (insert_into_type_stack, insert_type, push_type, push_type_int)
1045         (insert_type_address_space, pop_type, pop_type_int)
1046         (pop_typelist, pop_type_stack, append_type_stack)
1047         (push_type_stack, get_type_stack, push_typelist)
1048         (follow_type_instance_flags, follow_types): Don't declare.
1049         * parse.c (type_stack): Remove global.
1050         (parse_exp_in_context): Update.
1051         (insert_into_type_stack, insert_type, push_type, push_type_int)
1052         (insert_type_address_space, pop_type, pop_type_int)
1053         (pop_typelist, pop_type_stack, append_type_stack)
1054         (push_type_stack, get_type_stack, push_typelist)
1055         (follow_type_instance_flags, follow_types): Remove (moved to
1056         type-stack.c).
1057         * f-exp.y (type_stack): New global.
1058         Update rules.
1059         (push_kind_type, f_parse): Update.
1060         * d-exp.y (type_stack): New global.
1061         Update rules.
1062         (d_parse): Update.
1063         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1064         Update rules.
1065         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1066         (HFILES_NO_SRCDIR): Add type-stack.h.
1067
1068 2019-04-04  Tom Tromey  <tom@tromey.com>
1069
1070         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1071         (rust_parser::convert_ast_to_expression, rust_parse)
1072         (rust_lex_test_completion, rust_lex_tests): Update.
1073         * parser-defs.h (struct expr_completion_state): New.
1074         (struct parser_state) <parser_state>: Add completion parameter.
1075         <mark_struct_expression, mark_completion_tag>: New methods.
1076         <parse_completion, m_completion_state>: New members.
1077         (prefixify_expression, null_post_parser): Update.
1078         (mark_struct_expression, mark_completion_tag): Don't declare.
1079         * parse.c (parse_completion, expout_last_struct)
1080         (expout_tag_completion_type, expout_completion_name): Remove
1081         globals.
1082         (parser_state::mark_struct_expression)
1083         (parser_state::mark_completion_tag): Now methods.
1084         (prefixify_expression): Add last_struct parameter.
1085         (prefixify_subexp): Likewise.
1086         (parse_exp_1): Update.
1087         (parse_exp_in_context): Add cstate parameter.  Update.
1088         (parse_expression_for_completion): Create an
1089         expr_completion_state.
1090         (null_post_parser): Add "completion" parameter.
1091         * p-exp.y: Update rules.
1092         (yylex): Update.
1093         * language.h (struct language_defn) <la_post_parser>: Add
1094         "completing" parameter.
1095         * go-exp.y: Update rules.
1096         (lex_one_token): Update.
1097         * expression.h (parse_completion): Don't declare.
1098         * d-exp.y: Update rules.
1099         (lex_one_token): Update rules.
1100         * c-exp.y: Update rules.
1101         (lex_one_token): Update.
1102         * ada-lang.c (resolve): Add "parse_completion" parameter.
1103         (resolve_subexp): Likewise.
1104         (ada_resolve_function): Likewise.
1105
1106 2019-04-04  Tom Tromey  <tom@tromey.com>
1107
1108         * parser-defs.h (struct parser_state) <start_arglist,
1109         end_arglist>: New methods.
1110         <arglist_len, m_funcall_chain>: New members.
1111         (arglist_len, start_arglist, end_arglist): Don't declare.
1112         * parse.c (arglist_len, funcall_chain): Remove global.
1113         (start_arglist, end_arglist): Remove functions.
1114         (parse_exp_in_context): Update.
1115         * p-exp.y: Update rules.
1116         * m2-exp.y: Update rules.
1117         * go-exp.y: Update rules.
1118         * f-exp.y: Update rules.
1119         * d-exp.y: Update rules.
1120         * c-exp.y: Update rules.
1121
1122 2019-04-04  Tom Tromey  <tom@tromey.com>
1123
1124         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1125         lex_operator, push_back>: New methods.
1126         Update all rules.
1127         (rust_parser::lex_hex, lex_escape): Rename and update.
1128         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1129         (rust_parser::lex_operator): Rename and update.
1130         (rust_parser::lex_number, rustyylex, rustyyerror)
1131         (rust_lex_test_init, rust_lex_test_sequence)
1132         (rust_lex_test_push_back, rust_lex_tests): Update.
1133         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1134         parameter.
1135         <lexptr, prev_lexptr>: New members.
1136         (lexptr, prev_lexptr): Don't declare.
1137         * parse.c (lexptr, prev_lexptr): Remove globals.
1138         (parse_exp_in_context): Update.
1139         * p-exp.y (yylex, yyerror): Update.
1140         * m2-exp.y (parse_number, yylex, yyerror): Update.
1141         * go-exp.y (lex_one_token, yyerror): Update.
1142         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1143         * d-exp.y (lex_one_token, yyerror): Update.
1144         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1145         (lex_one_token, yyerror): Update.
1146         * ada-lex.l (YY_INPUT): Update.
1147         (rewind_to_char): Update.
1148         * ada-exp.y (yyerror): Update.
1149
1150 2019-04-04  Tom Tromey  <tom@tromey.com>
1151
1152         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1153         * parser-defs.h (struct parser_state) <parser_state>: Add new
1154         parameter.
1155         <comma_terminates>: New member.
1156         (comma_terminates): Don't declare global.
1157         * parse.c (comma_terminates): Remove global.
1158         (parse_exp_in_context): Update.
1159         * p-exp.y (yylex): Update.
1160         * m2-exp.y (yylex): Update.
1161         * go-exp.y (lex_one_token): Update.
1162         * f-exp.y (yylex): Update.
1163         * d-exp.y (lex_one_token): Update.
1164         * c-exp.y (lex_one_token): Update.
1165         * ada-lex.l: Update.
1166
1167 2019-04-04  Tom Tromey  <tom@tromey.com>
1168
1169         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1170         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1171         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1172         * parser-defs.h (paren_depth): Don't declare.
1173         * parse.c (paren_depth): Remove global.
1174         (parse_exp_in_context): Update.
1175         * p-exp.y (paren_depth): New global.
1176         (pascal_parse): Initialize it.
1177         * m2-exp.y (paren_depth): New global.
1178         (m2_parse): Initialize it.
1179         * go-exp.y (paren_depth): New global.
1180         (go_parse): Initialize it.
1181         * f-exp.y (paren_depth): New global.
1182         (f_parse): Initialize it.
1183         * d-exp.y (paren_depth): New global.
1184         (d_parse): Initialize it.
1185         * c-exp.y (paren_depth): New global.
1186         (c_parse): Initialize it.
1187         * ada-lex.l (paren_depth): New global.
1188         (lexer_init): Initialize it.
1189
1190 2019-04-04  Tom Tromey  <tom@tromey.com>
1191
1192         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1193         (rust_parser::convert_ast_to_type)
1194         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1195         * parser-defs.h (struct parser_state) <parser_state>: Add
1196         parameters.  Initialize new members.
1197         <expression_context_block, expression_context_pc>: New members.
1198         * parse.c (expression_context_block, expression_context_pc):
1199         Remove globals.
1200         (parse_exp_in_context): Update.
1201         * p-exp.y: Update all rules.
1202         (yylex): Update.
1203         * m2-exp.y: Update all rules.
1204         (yylex): Update.
1205         * go-exp.y (yylex): Update.
1206         * f-exp.y (yylex): Update.
1207         * d-exp.y: Update all rules.
1208         (yylex): Update.
1209         * c-exp.y: Update all rules.
1210         (lex_one_token, classify_name, yylex, c_parse): Update.
1211         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1212
1213 2019-04-04  Tom Tromey  <tom@tromey.com>
1214
1215         * gdbarch.h, gdbarch.c: Rebuild.
1216         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1217         * stap-probe.h: 
1218         (struct stap_parse_info): Replace "parser_state" with
1219         "expr_builder".
1220         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1221         (parser_state): New class.
1222         * parse.c (expr_builder): Rename.
1223         (expr_builder::release): Rename.
1224         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1225         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1226         (write_exp_elt_longcst, write_exp_elt_floatcst)
1227         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1228         (write_exp_string_vector, write_exp_bitstring)
1229         (write_exp_msymbol, mark_struct_expression)
1230         (write_dollar_variable)
1231         (insert_type_address_space, increase_expout_size): Replace
1232         "parser_state" with "expr_builder".
1233         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1234         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1235         "parser_state" with "expr_builder".
1236
1237 2019-04-04  Tom Tromey  <tom@tromey.com>
1238
1239         * rust-exp.y: Replace "parse_language" with method call.
1240         * p-exp.y: 
1241         (yylex): Replace "parse_language" with method call.
1242         * m2-exp.y: 
1243         (yylex): Replace "parse_language" with method call.
1244         * go-exp.y (classify_name): Replace "parse_language" with method
1245         call.
1246         * f-exp.y (yylex): Replace "parse_language" with method call.
1247         * d-exp.y (lex_one_token): Replace "parse_language" with method
1248         call.
1249         * c-exp.y: 
1250         (lex_one_token, classify_name, yylex): Replace "parse_language"
1251         with method call.
1252         * ada-exp.y (find_primitive_type, type_char)
1253         (type_system_address): Replace "parse_language" with method call.
1254
1255 2019-04-04  Tom Tromey  <tom@tromey.com>
1256
1257         * rust-exp.y: Replace "parse_gdbarch" with method call.
1258         * parse.c (write_dollar_variable, insert_type_address_space):
1259         Replace "parse_gdbarch" with method call.
1260         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1261         call.
1262         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1263         call.
1264         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1265         "parse_gdbarch" with method call.
1266         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1267         with method call.
1268         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1269         "parse_gdbarch" with method call.
1270         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1271         "parse_gdbarch" with method call.
1272         * c-exp.y (parse_type, parse_number, classify_name): Replace
1273         "parse_gdbarch" with method call.
1274         * ada-lex.l: Replace "parse_gdbarch" with method call.
1275         * ada-exp.y (parse_type, find_primitive_type, type_char)
1276         (type_system_address): Replace "parse_gdbarch" with method call.
1277
1278 2019-04-04  Tom Tromey  <tom@tromey.com>
1279
1280         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1281         * stap-probe.c (stap_parse_argument): Update.
1282         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1283         initial_size parameter.
1284         * rust-exp.y (rust_lex_tests): Update.
1285         * parse.c (parser_state): Update.
1286         (parse_exp_in_context): Update.
1287         * parser-defs.h (struct parser_state) <parser_state>: Remove
1288         "initial_size" parameter.
1289
1290 2019-04-04  Tom Tromey  <tom@tromey.com>
1291
1292         * parser-defs.h (increase_expout_size): Don't declare.
1293         * parse.c (increase_expout_size): Now static.
1294
1295 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1296
1297         * gnu-nat.c (gnu_nat_target::wait): Fix
1298         target_waitstatus_to_string call.
1299
1300 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * eval.c (evaluate_subexp_standard): Handle internal functions
1303         during Fortran function call handling.
1304
1305 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * NEWS: Mention new internal functions.
1308         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1309         (read_base_type): Use dwarf2_init_complex_target_type.
1310         * value.c (creal_internal_fn): New function.
1311         (cimag_internal_fn): New function.
1312         (_initialize_values): Register new internal functions.
1313
1314 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1315
1316         * infrun.c (stop_all_threads): If debug_infrun, always
1317         trace the wait status after wait_one, using
1318         target_waitstatus_to_string and target_pid_to_str.
1319         (handle_inferior_event): Replace various trace of
1320         wait status kind by a single trace.
1321         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1322         wait status kind image by target_waitstatus_to_string.
1323         * target/waitstatus.c (target_waitstatus_to_string): Fix
1324         obsolete comment.
1325
1326 2019-04-01  Tom Tromey  <tromey@adacore.com>
1327
1328         PR symtab/23331:
1329         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1330
1331 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1332             Pedro Alves  <palves@redhat.com>
1333
1334         * top.c (quit_force): Call 'finalize_values'.
1335         * value.c (finalize_values): New function.
1336         * value.h (finalize_values): Declare.
1337
1338 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1339
1340         * NEWS: Announce $_gdb_major and $_gdb_minor.
1341
1342         * top.c (init_gdb_version_vars): New function.
1343         (gdb_init): Call init_gdb_version_vars.
1344
1345 2019-03-29  Tom Tromey  <tromey@adacore.com>
1346
1347         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1348         help text.  Remove dead code.
1349
1350 2019-03-29  Keith Seitz  <keiths@redhat.com>
1351
1352         From Siddhesh Poyarekar:
1353         * f-lang.h (f77_get_upperbound): Return LONGEST.
1354         (f77_get_lowerbound): Likewise.
1355         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1356         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1357         print them.
1358         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1359         plongest to format print it.
1360         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1361         (f77_get_upperbound): Likewise.
1362         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1363         LOWER_BOUND to LONGEST.
1364         (f77_create_arrayprint_offset_tbl): Likewise.
1365
1366 2019-03-29  Keith Seitz  <keiths@redhat.com>
1367
1368         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1369         %s/pulongest for TYPE_LENGTH instead of %d in format
1370         strings.
1371         * ada-typerint.c (ada_print_type): Likewise.
1372         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1373         * compile/compile-c-support.c (generate_register_struct): Likewise.
1374         * gdbtypes.c (recursive_dump_type): Likewise.
1375         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1376         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1377         instead of %d in format strings.
1378         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1379         to std::min to ULONGEST.
1380         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1381         instead of %d in format strings.
1382         * tracepoint.c (info_scope_command): Likewise.
1383         * typeprint.c (print_offset_data::update)
1384         (print_offset_data::finish): Likewise.
1385         * xtensa-tdep.c (xtensa_store_return_value)
1386         (xtensa_push_dummy_call): Likewise.
1387
1388 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1389
1390         * windows-nat.c (display_selector): Fixed format specifications
1391         for 64-bit Cygwin.
1392
1393 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1394
1395         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1396
1397 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1398
1399         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1400         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1401         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1402         (nios2_linux_init_abi): Install it.
1403
1404 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1405
1406         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1407
1408 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1409
1410         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1411
1412 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1413             Tom Tromey  <tromey@adacore.com>
1414
1415         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1416
1417 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1418
1419         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1420         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1421         method to compute the bounds of range types. Also print "[evaluated]"
1422         if the bounds' values come from a dynamic evaluation.
1423
1424 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1425
1426         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1427         whitespace when pretty printing is on.
1428
1429 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1430
1431         * ppc-linux-nat.c: Add include.
1432
1433 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1434
1435         * NEWS: Mention AArch64 Pointer Authentication.
1436
1437 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1438
1439         * arm-linux-nat.c: Add include.
1440
1441 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1442
1443         * source-cache.c (source_cache::get_source_lines): Re-read
1444         fullname after calling open_source_file.
1445
1446 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1447
1448         * NEWS: Mention TLS support for FreeBSD.
1449
1450 2019-03-25  Tom Tromey  <tromey@adacore.com>
1451
1452         * minsyms.c (BUNCH_SIZE): Update comment.
1453         (~minimal_symbol_reader): Remove old comment.
1454         (compact_minimal_symbols): Update comment.
1455         (minimal_symbol_reader::install): Remove old comment.  Update
1456         other comments.
1457
1458 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1459
1460         * s390-linux-nat.c: Add include.
1461
1462 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1463
1464         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1465         Call linux_get_hwcap.
1466         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1467         Likewise.
1468         (aarch64_linux_get_hwcap): Remove function.
1469         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1470         declaration.
1471         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1472         linux_get_hwcap.
1473         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1474         * linux-tdep.c (linux_get_hwcap): Add function.
1475         (linux_get_hwcap2): Likewise.
1476         * linux-tdep.h (linux_get_hwcap): Add declaration.
1477         (linux_get_hwcap2): Likewise.
1478         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1479         (ppc_linux_get_hwcap2): Likewise.
1480         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1481         linux_get_hwcap.
1482         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1483         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1484         (ppc_linux_nat_target::read_description): Likewise.
1485         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1486         * s390-linux-nat.c: Likewise.
1487         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1488
1489 2019-03-24  Tom Tromey  <tom@tromey.com>
1490
1491         * ada-lang.c (standard_lookup): Simplify initialization.
1492         (ada_lookup_symbol_nonlocal): Simplify return.
1493         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1494         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1495         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1496         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1497         initialization.
1498         * solib.c (solib_global_lookup): Simplify.
1499         * symtab.c (null_block_symbol): Remove.
1500         (symbol_cache_lookup): Simplify returns.
1501         (lookup_language_this): Simplify returns.
1502         (lookup_symbol_aux): Simplify return.
1503         (lookup_local_symbol): Simplify returns.
1504         (lookup_global_symbol_from_objfile): Simplify return.
1505         (lookup_symbol_in_objfile_symtabs)
1506         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1507         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1508         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1509         * cp-namespace.c (cp_lookup_bare_symbol)
1510         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1511         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1512         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1513         (cp_lookup_symbol_via_imports): Simplify initialization.
1514         (find_symbol_in_baseclass): Likewise.
1515         * symtab.h (null_block_symbol): Remove.
1516         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1517         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1518         (d_lookup_symbol_module): Likewise.
1519         (find_symbol_in_baseclass): Simplify initialization.
1520
1521 2019-03-24  Tom Tromey  <tom@tromey.com>
1522
1523         * expression.h: Don't include symtab.h.
1524         (struct block): Forward declare.
1525
1526 2019-03-24  Tom Tromey  <tom@tromey.com>
1527
1528         * c-exp.y (typebase): Remove casts.
1529         * gdbtypes.c (lookup_unsigned_typename, )
1530         (lookup_signed_typename): Remove cast.
1531         * eval.c (parse_to_comma_and_eval): Remove cast.
1532         * parse.c (write_dollar_variable): Remove cast.
1533         * block.h (struct block) <superblock>: Now const.
1534         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1535         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1536         (map_block): Make "block" const.
1537         * symfile.h (struct quick_symbol_functions)
1538         <map_matching_symbols>: Constify block argument to "callback".
1539         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1540         const.
1541         (find_pc_sect_compunit_symtab): Make "b" const.
1542         (find_symbol_at_address): Likewise.
1543         (search_symbols): Likewise.
1544         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1545         (dw2_debug_names_lookup_symbol): Likewise.
1546         (dw2_map_matching_symbols): Update.
1547         * p-valprint.c (pascal_val_print): Remove "block".
1548         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1549         (aux_add_nonlocal_symbols): Make "block" const.
1550         (resolve_subexp): Remove cast.
1551         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1552         const.
1553         (iterate_over_file_blocks): Likewise.
1554         * f-exp.y (%union) <bval>: Remove.
1555         * coffread.c (patch_opaque_types): Make "b" const.
1556         * spu-tdep.c (spu_catch_start): Make "block" const.
1557         * c-valprint.c (print_unpacked_pointer): Remove "block".
1558         * symmisc.c (dump_symtab_1): Make "b" const.
1559         (block_depth): Make "block" const.
1560         * d-exp.y (%union) <bval>: Remove.
1561         * cp-support.h (cp_lookup_rtti_type): Update.
1562         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1563         * psymtab.c (psym_lookup_symbol): Make "block" const.
1564         (maintenance_check_psymtabs): Make "b" const.
1565         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1566         (enumerate_locals, enumerate_args): Update.
1567         * python/py-symtab.c (stpy_global_block): Make "block" const.
1568         (stpy_static_block): Likewise.
1569         * inline-frame.c (block_starting_point_at): Make "new_block"
1570         const.
1571         * block.c (find_block_in_blockvector): Make return type const.
1572         (blockvector_for_pc_sect): Make "b" const.
1573         (find_block_in_blockvector): Make "b" const.
1574
1575 2019-03-23  Tom Tromey  <tom@tromey.com>
1576
1577         * varobj.c (varobj_create): Update.
1578         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1579         * printcmd.c (display_command, do_one_display): Don't reset
1580         innermost_block.
1581         * parser-defs.h (enum innermost_block_tracker_type): Move to
1582         expression.h.
1583         (innermost_block): Update comment.
1584         * parse.c (parse_exp_1): Add tracker_types parameter.
1585         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1586         tracker_types parameter.  Reset innermost_block.
1587         (parse_exp_in_context): Remove.
1588         (parse_expression_for_completion): Update.
1589         * objfiles.c (~objfile): Don't reset expression_context_block or
1590         innermost_block.
1591         * expression.h (enum innermost_block_tracker_type): Move from
1592         parser-defs.h.
1593         (parse_exp_1): Add tracker_types parameter.
1594         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1595         reset innermost_block.
1596
1597 2019-03-23  Tom Tromey  <tom@tromey.com>
1598
1599         * objfiles.h: Include bcache.h.
1600
1601 2019-03-23  Tom Tromey  <tom@tromey.com>
1602
1603         * linespec.c (get_current_search_block): Use
1604         scoped_restore_current_language.
1605         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1606
1607 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1608             Jiong Wang  <jiong.wang@arm.com>
1609
1610         * aarch64-linux-tdep.c
1611         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1612         section.
1613         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1614
1615 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1616             Jiong Wang  <jiong.wang@arm.com>
1617
1618         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1619         instructions.
1620         (aarch64_analyze_prologue_test): Add PACIASP test.
1621         (aarch64_prologue_prev_register): Unmask PC value.
1622
1623 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1624             Jiong Wang  <jiong.wang@arm.com>
1625
1626         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1627         (aarch64_dwarf2_prev_register): Unmask PC value.
1628         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1629         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1630         DW_CFA_AARCH64_negate_ra_state.
1631         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1632
1633 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1634             Jiong Wang  <jiong.wang@arm.com>
1635
1636         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1637         registers.
1638         (aarch64_pseudo_register_name): Likewise.
1639         (aarch64_pseudo_register_type): Likewise.
1640         (aarch64_pseudo_register_reggroup_p): Likewise.
1641         (aarch64_gdbarch_init): Add pauth registers.
1642         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1643         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1644         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1645         (struct gdbarch_tdep): Add regnum for ra_state.
1646
1647 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1648             Jiong Wang  <jiong.wang@arm.com>
1649
1650         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1651
1652 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1653             Jiong Wang  <jiong.wang@arm.com>
1654
1655         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1656         function.
1657         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1658         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1659         (aarch64_gdbarch_init): Add puth registers.
1660         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1661         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1662         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1663
1664 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1665             Jiong Wang  <jiong.wang@arm.com>
1666
1667         * aarch64-linux-nat.c
1668         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1669         * aarch64-linux-tdep.c
1670         (aarch64_linux_core_read_description): Likewise.
1671         (aarch64_linux_get_hwcap): New function.
1672         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1673         (aarch64_linux_get_hwcap): New declaration.
1674
1675 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1676             Jiong Wang  <jiong.wang@arm.com>
1677
1678         * aarch64-linux-nat.c
1679         (aarch64_linux_nat_target::read_description): Add pauth param.
1680         * aarch64-linux-tdep.c
1681         (aarch64_linux_core_read_description): Likewise.
1682         * aarch64-tdep.c (struct target_desc): Add in pauth.
1683         (aarch64_read_description): Add pauth param.
1684         (aarch64_gdbarch_init): Likewise.
1685         * aarch64-tdep.h (aarch64_read_description): Likewise.
1686         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1687         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1688         * features/Makefile: Add new files.
1689         * features/aarch64-pauth.c: New file.
1690         * features/aarch64-pauth.xml: New file.
1691
1692 2019-03-20  Tom Tromey  <tromey@adacore.com>
1693
1694         * infrun.c (handle_inferior_event): Rename from
1695         handle_inferior_event_1.  Create a scoped_value_mark.
1696         (handle_inferior_event): Remove.
1697
1698 2019-03-19  Tom Tromey  <tromey@adacore.com>
1699
1700         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1701         * infrun.h (print_stop_event): Add "displays" parameter.
1702         * infrun.c (print_stop_event): Add "displays" parameter.
1703
1704 2019-03-19  Pedro Alves  <palves@redhat.com>
1705
1706         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1707         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1708         to -1.  Fix TABs vs spaces.
1709         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1710         * tui/tui-out.h (tui_ui_out) Add intro comments.
1711         <m_line, m_start_of_line>: In-class initialize, and add describing
1712         comment.
1713
1714 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1715
1716         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1717         variable names.
1718         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1719
1720 2019-03-18  Pedro Alves  <palves@redhat.com>
1721             Eli Zaretskii <eliz@gnu.org>
1722
1723         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1724         m_line and m_start_of_line.
1725
1726 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1727
1728         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1729         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1730         it returns a newline.  This fixes a regression in TU mode, whereby
1731         the next line is output on the same screen line as the user input.
1732
1733 2019-03-18  Tom Tromey  <tromey@adacore.com>
1734
1735         * minsyms.c (minimal_symbol_reader::install): Remove call to
1736         obstack_blank.
1737
1738 2019-03-18  Pedro Alves  <palves@redhat.com>
1739
1740         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1741         New globals.
1742         (apply_style): New, factored out from ...
1743         (apply_ansi_escape): ... this.  Handle reverse video mode.
1744         (tui_set_reverse_mode): New function.
1745         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1746         * tui/tui-winsource.c (tui_show_source_line): Use
1747         tui_set_reverse_mode instead of setting A_STANDOUT.
1748         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1749         New setter methods.
1750
1751 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1752
1753         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1754         Handle tabs.
1755
1756 2019-03-18  Tom Tromey  <tromey@adacore.com>
1757
1758         * ada-lang.c (empty_array): Add "high" parameter.
1759         (ada_evaluate_subexp): Update.
1760
1761 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1762
1763         * unittests/string_view-selftests.c: Define
1764         _initialize_string_view_selftests unconditionally.
1765
1766 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1767
1768         PR gdb/24350
1769         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1770
1771 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1772
1773         PR gdb/24351
1774         * windows-nat.c (display_selector): Fix format specifiers.
1775
1776 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1777
1778         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1779         tui_refill_source_window instead of tui_refresh_win, to update the
1780         current execution line.  This fixes redisplay of the current line
1781         when stepping through the code with "next" or "step".
1782
1783 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1784
1785         * source-cache.c (source_cache::get_source_lines): Call
1786         find_source_lines to initialize s->nlines.  This fixes vertical
1787         scrolling of TUI source window when the DOWN arrow is pressed.
1788
1789 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1790
1791         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1792         linux-thread-db.c (_initialize_thread_db): Likewise.
1793
1794 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1795
1796         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1797         wclrtoeol in tui_show_source_line".  This reverts changes made in
1798         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1799
1800 2019-03-15  Tom Tromey  <tom@tromey.com>
1801
1802         * symtab.h (struct minimal_symbol): Derive from
1803         general_symbol_info.
1804         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1805         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1806         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1807         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1808         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1809         (MSYMBOL_SEARCH_NAME): Update.
1810         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1811         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1812         * minsyms.c (minimal_symbol_reader::record_full): Update.
1813
1814 2019-03-15  Tom Tromey  <tom@tromey.com>
1815
1816         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1817
1818 2019-03-15  Tom Tromey  <tom@tromey.com>
1819
1820         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1821         unique_xmalloc_ptr.
1822         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1823         Update.
1824         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1825         (build_minimal_symbol_hash_tables)
1826         (minimal_symbol_reader::install): Update.
1827
1828 2019-03-15  Tom Tromey  <tom@tromey.com>
1829
1830         * symtab.c (create_demangled_names_hash): Update.
1831         (symbol_set_names): Update.
1832         * objfiles.h (struct objfile_per_bfd_storage)
1833         <demangled_names_hash>: Now an htab_up.
1834         * objfiles.c (objfile_per_bfd_storage): Simplify.
1835
1836 2019-03-15  Tom Tromey  <tom@tromey.com>
1837
1838         * objfiles.h (struct objfile_per_bfd_storage): Declare
1839         destructor.
1840         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1841         New.
1842         (get_objfile_bfd_data): Use new.  Don't initialize
1843         language_of_main.
1844         (free_objfile_per_bfd_storage): Remove.
1845         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1846
1847 2019-03-15  Tom Tromey  <tom@tromey.com>
1848
1849         * symfile.c (reread_symbols): Update.
1850         * objfiles.c (objfile::objfile): Update.
1851         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1852         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1853         comment.
1854         (minimal_symbol_reader::install): Update.
1855         (terminate_minimal_symbol_table): Remove.
1856         * jit.c (jit_object_close_impl): Update.
1857
1858 2019-03-15  Tom Tromey  <tom@tromey.com>
1859
1860         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1861         initializations.
1862
1863 2019-03-15  Tom Tromey  <tom@tromey.com>
1864
1865         * objfiles.h (struct objfile_per_bfd_storage)
1866         <demangled_hash_languages>: Now a bitset.
1867         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1868         (lookup_minimal_symbol): Update.
1869
1870 2019-03-15  Tom Tromey  <tom@tromey.com>
1871
1872         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1873         Don't return the symbol.
1874         * coffread.c (record_minimal_symbol): Use record_full.
1875
1876 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1877
1878         The MS-Windows port of ncurses fails to switch to a color pair if
1879         one or both of the colors are the implicit default colors.  This
1880         change records the default colors when TUI is initialized, and
1881         then specifies them explicitly when a color pair uses the default
1882         colors.  This allows color styling in TUI mode on MS-Windows.
1883
1884         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1885         ncurses_norm_attr.
1886         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1887         colors in ncurses_norm_attr.
1888         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1889         "none", replace it with the default color recorded in
1890         ncurses_norm_attr.
1891
1892 2019-03-14  Tom Tromey  <tromey@adacore.com>
1893
1894         * source-cache.h (class source_cache) <get_source_lines>: Return
1895         std::string.
1896         * source-cache.c (source_cache::extract_lines): Handle case where
1897         first_pos==npos.  Return std::string.
1898         (source_cache::get_source_lines): Update.
1899
1900 2019-03-14  Tom Tromey  <tromey@adacore.com>
1901
1902         * NEWS: Add item for "style sources" commands.
1903         * source-cache.c (source_cache::get_source_lines): Check
1904         source_styling.
1905         * cli/cli-style.c (source_styling): New global.
1906         (_initialize_cli_style): Add "style sources" commands.
1907         (show_style_sources): New function.
1908         * cli/cli-style.h (source_styling): Declare.
1909
1910 2019-03-14  Pedro Alves  <palves@redhat.com>
1911             Tom Tromey  <tromey@adacore.com>
1912
1913         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1914         * tui/tui-winsource.c (tui_refill_source_window): New function,
1915         from...
1916         (tui_horizontal_source_scroll): ... here.  Move some logic.
1917         * cli/cli-style.c (set_style_enabled): Notify new observable.
1918         * tui/tui-hooks.c (tui_redisplay_source): New function.
1919         (tui_attach_detach_observers): Attach or detach
1920         tui_redisplay_source.
1921         * observable.h (source_styling_changed): New observable.
1922         * observable.c: Define source_styling_changed observable.
1923
1924 2019-03-13  Tom Tromey  <tromey@adacore.com>
1925
1926         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1927         (i386_gnu_nat_target::store_registers): Update.
1928         * target-debug.h (target_debug_print_std_string): New macro.
1929         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1930         * windows-tdep.c (display_one_tib): Update.
1931         * tui/tui-stack.c (tui_make_status_line): Update.
1932         * top.c (print_inferior_quit_action): Update.
1933         * thread.c (thr_try_catch_cmd): Update.
1934         (add_thread_with_info): Update.
1935         (thread_target_id_str): Update.
1936         (thr_try_catch_cmd): Update.
1937         (thread_command): Update.
1938         (thread_find_command): Update.
1939         * record-btrace.c (record_btrace_target::info_record)
1940         (record_btrace_resume_thread, record_btrace_target::resume)
1941         (record_btrace_cancel_resume, record_btrace_step_thread)
1942         (record_btrace_target::wait, record_btrace_target::wait)
1943         (record_btrace_target::wait, record_btrace_target::stop): Update.
1944         * progspace.c (print_program_space): Update.
1945         * process-stratum-target.c
1946         (process_stratum_target::thread_address_space): Update.
1947         * linux-fork.c (linux_fork_mourn_inferior)
1948         (detach_checkpoint_command, info_checkpoints_command)
1949         (linux_fork_context): Update.
1950         (linux_fork_detach): Update.
1951         (class scoped_switch_fork_info): Update.
1952         (delete_checkpoint_command): Update.
1953         * infrun.c (follow_fork_inferior): Update.
1954         (follow_fork_inferior): Update.
1955         (proceed_after_vfork_done): Update.
1956         (handle_vfork_child_exec_or_exit): Update.
1957         (follow_exec): Update.
1958         (displaced_step_prepare_throw): Update.
1959         (displaced_step_restore): Update.
1960         (start_step_over): Update.
1961         (resume_1): Update.
1962         (clear_proceed_status_thread): Update.
1963         (proceed): Update.
1964         (print_target_wait_results): Update.
1965         (do_target_wait): Update.
1966         (context_switch): Update.
1967         (stop_all_threads): Update.
1968         (restart_threads): Update.
1969         (finish_step_over): Update.
1970         (handle_signal_stop): Update.
1971         (switch_back_to_stepped_thread): Update.
1972         (keep_going_pass_signal): Update.
1973         (print_exited_reason): Update.
1974         (normal_stop): Update.
1975         * inferior.c (inferior_pid_to_str): Change return type.
1976         (print_selected_inferior): Update.
1977         (add_inferior): Update.
1978         (detach_inferior): Update.
1979         * dummy-frame.c (fprint_dummy_frames): Update.
1980         * dcache.c (dcache_info_1): Update.
1981         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1982         (btrace_fetch, btrace_clear): Update.
1983         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1984         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1985         type.
1986         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1987         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1988         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1989         * gdbarch.c, gdbarch.h: Rebuild.
1990         * gdbarch.sh (core_pid_to_str): Change return type.
1991         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1992         return type.
1993         (windows_nat_target::pid_to_str): Change return type.
1994         (windows_delete_thread): Update.
1995         (windows_nat_target::attach): Update.
1996         (windows_nat_target::files_info): Update.
1997         * target-delegates.c: Rebuild.
1998         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1999         return type.
2000         (sol_thread_target::pid_to_str): Change return type.
2001         * remote.c (class remote_target) <pid_to_str>: Change return
2002         type.
2003         (remote_target::pid_to_str): Change return type.
2004         (extended_remote_target::attach, remote_target::remote_stop_ns)
2005         (remote_target::remote_notif_remove_queued_reply)
2006         (remote_target::push_stop_reply, remote_target::disable_btrace):
2007         Update.
2008         (extended_remote_target::attach): Update.
2009         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2010         type.
2011         (gdbsim_target::pid_to_str): Change return type.
2012         * ravenscar-thread.c (struct ravenscar_thread_target)
2013         <pid_to_str>: Change return type.
2014         (ravenscar_thread_target::pid_to_str): Change return type.
2015         * procfs.c (class procfs_target) <pid_to_str>: Change return
2016         type.
2017         (procfs_target::pid_to_str): Change return type.
2018         (procfs_target::attach): Update.
2019         (procfs_target::detach): Update.
2020         (procfs_target::fetch_registers): Update.
2021         (procfs_target::store_registers): Update.
2022         (procfs_target::wait): Update.
2023         (procfs_target::files_info): Update.
2024         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2025         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2026         return type.
2027         (nto_procfs_target::pid_to_str): Change return type.
2028         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2029         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2030         return type.
2031         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2032         (exit_lwp): Update.
2033         (attach_proc_task_lwp_callback, get_detach_signal)
2034         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2035         (linux_nat_target::resume, wait_lwp, stop_callback)
2036         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2037         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2038         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2039         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2040         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2041         type.
2042         (inf_ptrace_target::attach): Update.
2043         (inf_ptrace_target::files_info): Update.
2044         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2045         type.
2046         (go32_nat_target::pid_to_str): Change return type.
2047         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2048         (gnu_nat_target::wait): Update.
2049         (gnu_nat_target::wait): Update.
2050         (gnu_nat_target::resume): Update.
2051         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2052         (fbsd_nat_target::wait): Update.
2053         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2054         type.
2055         (darwin_nat_target::attach): Update.
2056         * corelow.c (class core_target) <pid_to_str>: Change return type.
2057         (core_target::pid_to_str): Change return type.
2058         * target.c (normal_pid_to_str): Change return type.
2059         (default_pid_to_str): Likewise.
2060         (target_pid_to_str): Change return type.
2061         (target_translate_tls_address): Update.
2062         (target_announce_detach): Update.
2063         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2064         return type.
2065         (bsd_uthread_target::pid_to_str): Change return type.
2066         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2067         type.
2068         (bsd_kvm_target::pid_to_str): Change return type.
2069         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2070         return type.
2071         (aix_thread_target::pid_to_str): Change return type.
2072         * target.h (struct target_ops) <pid_to_str>: Change return type.
2073         (target_pid_to_str, normal_pid_to_str): Likewise.
2074         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2075         type.
2076         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2077         type.
2078         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2079         return type.
2080         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2081         type.
2082         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2083         type.
2084         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2085         return type.
2086
2087 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2088
2089         * NEWS: Mention that the new default MI version is 3.  Mention
2090         changes to the output of commands and events that deal with
2091         multi-location breakpoints.
2092         * breakpoint.c: Include "mi/mi-out.h".
2093         (print_one_breakpoint): Change output syntax if using MI version
2094         >= 3.
2095         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2096         New.
2097         (mi_multi_location_breakpoint_output_fixed): New.
2098         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2099         (mi_cmd_fix_multi_location_breakpoint_output): New.
2100         (mi_multi_location_breakpoint_output_fixed): New.
2101         * mi/mi-cmds.c (mi_cmds): Register command
2102         -fix-multi-location-breakpoint-output.
2103         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2104         interpreter "mi".
2105
2106 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2107
2108         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2109         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2110         instantiate mi_ui_out based on interpreter name.
2111         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2112         * mi/mi-main.c (mi_load_progress): Likewise.
2113
2114 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2115
2116         * NEWS: Combine separate "New targets" sections for 8.3.
2117
2118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2119
2120         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2121         (ppcfbsd_init_abi): Install gdbarch
2122         "fetch_tls_load_module_address" and "get_thread_local_address"
2123         methods.
2124
2125 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2126
2127         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2128         (riscv_fbsd_init_abi): Install gdbarch
2129         "fetch_tls_load_module_address" and "get_thread_local_address"
2130         methods.
2131
2132 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2133
2134         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2135         (i386fbsd_init_abi): Install gdbarch
2136         "fetch_tls_load_module_address" and "get_thread_local_address"
2137         methods.
2138
2139 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2140
2141         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2142         (amd64fbsd_init_abi): Install gdbarch
2143         "fetch_tls_load_module_address" and "get_thread_local_address"
2144         methods.
2145
2146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2147
2148         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2149         (struct fbsd_pspace_data): New type.
2150         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2151         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2152         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2153         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2154         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2155
2156 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2157
2158         * gdbtypes.c (lookup_struct_elt): New function.
2159         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2160         * gdbtypes.h (struct struct_elt): New type.
2161         (lookup_struct_elt): New prototype.
2162
2163 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2164
2165         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2166         remove disabled code block.
2167
2168 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2169
2170         * gdbarch.sh (get_thread_local_address): New method.
2171         * gdbarch.h, gdbarch.c: Regenerate.
2172         * target.c (target_translate_tls_address): Use
2173         gdbarch_get_thread_local_address if present instead of
2174         target::get_thread_local_address.
2175
2176 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2177
2178         * target.h (target::get_thread_local_address): Update comment.
2179
2180 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2181
2182         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2183         objfile->separate_debug_objfile_backlink if not NULL.
2184
2185 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2186
2187         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2188         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2189         (amd64bsd_store_inferior_registers): Likewise.
2190         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2191         Enable segment base registers.
2192         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2193         PT_GETFSBASE and PT_GETGSBASE.
2194         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2195         PT_SETGSBASE.
2196         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2197         segment base registers.
2198         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2199
2200 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2201
2202         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2203         Update calls to i386_target_description to add 'segments'
2204         parameter.
2205         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2206         add segment base registers.
2207         * arch/i386.c (i386_create_target_description): Add 'segments'
2208         parameter to enable segment base registers.
2209         * arch/i386.h (i386_create_target_description): Likewise.
2210         * features/i386/32bit-segments.xml: New file.
2211         * features/i386/32bit-segments.c: Generate.
2212         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2213         call to i386_target_description to add 'segments' parameter.
2214         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2215         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2216         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2217         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2218         if feature is present.
2219         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2220         Add 'segments' parameter to call to i386_target_description.
2221         (i386_target_description): Add 'segments' parameter to enable
2222         segment base registers.
2223         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2224         to call to i386_target_description.
2225         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2226         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2227         Define I386_NUM_REGS.
2228         (i386_target_description): Add 'segments' parameter to enable
2229         segment base registers.
2230
2231 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2232
2233         PR/24325
2234         * source-cache.c: #undef open and close, to avoid unresolved
2235         externals during linking.
2236
2237 2019-03-12  Tom Tromey  <tromey@adacore.com>
2238
2239         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2240         const.  Add initializers.
2241         (_initialize_remote): Don't initialize ptid globals.
2242
2243 2019-03-12  Pedro Alves  <palves@redhat.com>
2244
2245         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2246
2247 2019-03-12  Pedro Alves  <palves@redhat.com>
2248
2249         * cp-name-parser.y (main): Remove unused 'len' variable.
2250
2251 2019-03-12  Tom Tromey  <tromey@adacore.com>
2252
2253         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2254         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2255
2256 2019-03-12  Tom Tromey  <tromey@adacore.com>
2257
2258         * linux-nat.c (iterate_over_lwps): Update.
2259         (stop_callback): Remove parameter.
2260         (stop_wait_callback, detach_callback, resume_set_callback)
2261         (select_singlestep_lwp_callback, set_ignore_sigint)
2262         (status_callback, resumed_callback, resume_clear_callback)
2263         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2264         data parameter.
2265         (linux_nat_target::detach, linux_nat_target::resume)
2266         (linux_stop_and_wait_all_lwps, select_event_lwp)
2267         (linux_nat_filter_event, linux_nat_wait_1)
2268         (linux_nat_target::kill, linux_nat_target::stop)
2269         (linux_nat_target::stop): Update.
2270         (linux_nat_resume_callback): Change type.
2271         (resume_stopped_resumed_lwps, count_events_callback)
2272         (select_event_lwp_callback): Likewise.
2273         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2274         * arm-linux-nat.c (struct update_registers_data): Remove.
2275         (update_registers_callback): Change type.
2276         (arm_linux_insert_hw_breakpoint1): Update.
2277         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2278         parameter.
2279         (x86_linux_dr_set_addr): Update.
2280         (x86_linux_dr_set_control): Update.
2281         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2282         (iterate_over_lwps): Use gdb::function_view.
2283         * nat/aarch64-linux-hw-point.c (struct
2284         aarch64_dr_update_callback_param): Remove.
2285         (debug_reg_change_callback): Change type.
2286         (aarch64_notify_debug_reg_change): Update.
2287         * s390-linux-nat.c (s390_refresh_per_info): Update.
2288
2289 2019-03-11  Tom Tromey  <tromey@adacore.com>
2290
2291         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2292         redundant assignment to "this_cu".
2293
2294 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2295
2296         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2297
2298 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2299
2300         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2301         from...
2302         (rank_one_type): ... this.
2303
2304 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2305
2306         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2307         from...
2308         (rank_one_type): ... this.
2309
2310 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2311
2312         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2313         from...
2314         (rank_one_type): ... this.
2315
2316 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2317
2318         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2319         from...
2320         (rank_one_type): ... this.
2321
2322 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2323
2324         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2325         from...
2326         (rank_one_type): ... this.
2327
2328 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2329
2330         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2331         from...
2332         (rank_one_type): ... this.
2333
2334 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2335
2336         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2337         from...
2338         (rank_one_type): ... this.
2339
2340 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2341
2342         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2343         from...
2344         (rank_one_type): ... this.
2345
2346 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2347
2348         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2349         from...
2350         (rank_one_type): ... this.
2351
2352 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2353
2354         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2355         from...
2356         (rank_one_type): ... this.
2357
2358 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2359
2360         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2361         from...
2362         (rank_one_type): ... this.
2363
2364 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2365
2366         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2367         from...
2368         (rank_one_type): ... this.
2369
2370 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2371
2372         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2373         inferior-events' shows the example events.
2374
2375 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2376
2377         Support styling on native MS-Windows console
2378
2379         PR/24315
2380         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2381         on MS-Windows if $TERM is not defined.
2382
2383         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2384
2385         * posix-hdep.c (gdb_console_fputs):
2386         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2387         functions.
2388         * ui-file.h (gdb_console_fputs): Add prototype.
2389
2390         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2391         back to fputs only if the former returns zero.
2392
2393 2019-03-07  Tom Tromey  <tom@tromey.com>
2394
2395         * symmisc.c (print_symbol_bcache_statistics): Update.
2396         (print_objfile_statistics): Update.
2397         * symfile.c (allocate_symtab): Update.
2398         * stabsread.c: Don't include bcache.h.
2399         * psymtab.h (struct psymbol_bcache): Don't declare.
2400         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2401         (psymbol_bcache_init, psymbol_bcache_free)
2402         (psymbol_bcache_get_bcache): Don't declare.
2403         * psymtab.c (struct psymbol_bcache): Remove.
2404         (psymtab_storage::psymtab_storage): Update.
2405         (psymtab_storage::~psymtab_storage): Update.
2406         (psymbol_bcache_init, psymbol_bcache_free)
2407         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2408         (add_psymbol_to_bcache): Update.
2409         (allocate_psymtab): Update.
2410         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2411         macro_cache>: No longer pointers.
2412         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2413         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2414         * macrotab.c (macro_bcache): Update.
2415         * macroexp.c: Don't include bcache.h.
2416         * gdbtypes.c (check_types_worklist): Update.
2417         (types_deeply_equal): Remove TRY/CATCH.  Update.
2418         * elfread.c (elf_symtab_read): Update.
2419         * dwarf2read.c: Don't include bcache.h.
2420         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2421         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2422         (print_bcache_statistics, bcache_memory_used): Don't declare.
2423         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2424         methods.  Rename all data members.
2425         * bcache.c (struct bcache): Move to bcache.h.
2426         (bcache::expand_hash_table): Rename from expand_hash_table.
2427         (bcache): Remove.
2428         (bcache::insert): Rename from bcache_full.
2429         (bcache::compare): Rename from bcache_compare.
2430         (bcache_xmalloc): Remove.
2431         (bcache::~bcache): Rename from bcache_xfree.
2432         (bcache::print_statistics): Rename from print_bcache_statistics.
2433         (bcache::memory_used): Rename from bcache_memory_used.
2434
2435 2019-03-07  Pedro Alves  <palves@redhat.com>
2436
2437         * infrun.c (normal_stop): Also check for
2438         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2439
2440 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2441
2442         * f-lang.c (value_from_host_double): Moved to...
2443         * value.c (value_from_host_double): ...here.
2444         * value.h (value_from_host_double): Declare.
2445         * guile/scm-math.c (vlscm_convert_typed_number): Use
2446         value_from_host_double.
2447         (vlscm_convert_number): Likewise.
2448         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2449         * python/py-value.c (convert_value_from_python): Likewise.
2450
2451 2019-03-06  Tom Tromey  <tom@tromey.com>
2452
2453         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2454
2455 2019-03-06  Tom Tromey  <tom@tromey.com>
2456
2457         * utils.h (free_current_contents): Don't declare.
2458         * utils.c (free_current_contents): Remove.
2459
2460 2019-03-06  Tom Tromey  <tom@tromey.com>
2461
2462         * top.c (quit_force): Update.
2463         * main.c (captured_command_loop): Update.
2464         * common/new-op.c (operator new): Update.
2465         * common/common-exceptions.c (struct catcher)
2466         <save_cleanup_chain>: Remove member.
2467         (exceptions_state_mc_init): Update.
2468         (exception_try_scope_entry): Return nullptr.
2469         (exception_try_scope_exit, exception_rethrow)
2470         (throw_exception_sjlj, throw_exception_cxx): Update.
2471         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2472         (all_cleanups, do_cleanups, discard_cleanups)
2473         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2474         (restore_cleanups, restore_final_cleanups): Don't declare.
2475         (do_final_cleanups): Remove parameter.
2476         * common/cleanups.c (cleanup_chain, make_cleanup)
2477         (make_cleanup_dtor, all_cleanups, do_cleanups)
2478         (discard_my_cleanups, discard_cleanups)
2479         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2480         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2481         (null_cleanup): Remove.
2482         (do_final_cleanups): Remove parameter.
2483
2484 2019-03-06  Tom Tromey  <tom@tromey.com>
2485
2486         * remote.c (remote_target::remote_parse_stop_reply): Use
2487         unique_xmalloc_ptr.
2488
2489 2019-03-06  Tom Tromey  <tom@tromey.com>
2490
2491         * stabsread.c (struct stabs_field_info): Rename from field_info.
2492         <list, fnlist>: Add initializers.
2493         <obstack>: New member.
2494         (read_member_functions, read_struct_fields, read_baseclasses):
2495         Allocate on obstack.  Don't use cleanups.
2496         (read_one_struct_field, read_member_functions, read_struct_fields)
2497         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2498         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2499         (read_struct_type): Update.
2500
2501 2019-03-06  Tom Tromey  <tom@tromey.com>
2502
2503         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2504         * common/filestuff.h (make_cleanup_close): Don't declare.
2505         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2506         Remove.
2507
2508 2019-03-06  Tom Tromey  <tom@tromey.com>
2509
2510         * solib-aix.c: Use make_scope_exit.
2511
2512 2019-03-06  Tom Tromey  <tom@tromey.com>
2513
2514         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2515         Use make_scope_exit.
2516
2517 2019-03-06  Tom Tromey  <tom@tromey.com>
2518
2519         * solib-svr4.c (disable_probes_interface): Remove parameter.
2520         (svr4_handle_solib_event): Use make_scope_exit.
2521
2522 2019-03-06  Tom Tromey  <tom@tromey.com>
2523
2524         * remote.c (struct stop_reply_deleter): Remove.
2525         (stop_reply_up): Update.
2526         (struct stop_reply): Derive from notif_event.  Don't typedef.
2527         <regcache>: Now a std::vector.
2528         (stop_reply_xfree): Remove.
2529         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2530         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2531         (remote_target::discard_pending_stop_replies): Use delete.
2532         (remote_target::remote_parse_stop_reply): Update.
2533         (remote_target::process_stop_reply): Update.
2534         * remote-notif.h (struct notif_event): Add virtual destructor.
2535         Remove "dtr" member.
2536         (struct notif_client) <alloc_event>: Return a unique_ptr.
2537         (notif_event_xfree): Don't declare.
2538         (notif_event_up): New typedef.
2539         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2540         (notif_event_xfree, do_notif_event_xfree): Remove.
2541         (remote_notif_state_xfree): Update.
2542
2543 2019-03-06  Tom Tromey  <tom@tromey.com>
2544
2545         * infrun.c (displaced_step_clear_cleanup): Now a
2546         forward_scope_exit type.
2547         (displaced_step_prepare_throw): Update.
2548         (displaced_step_fixup): Update.
2549
2550 2019-03-06  Tom Tromey  <tom@tromey.com>
2551
2552         * inferior.h (class inferior): Update comment.
2553         * gdbthread.h (class thread_info): Update comment.
2554
2555 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2556             Tom Tromey  <tom@tromey.com>
2557
2558         * stabsread.h (struct stab_section_list): Remove.
2559         (coffstab_build_psymtabs): Update.
2560         * dbxread.c (symbuf_sections): Now a std::vector.
2561         (sect_idx): New global.
2562         (fill_symbuf): Update.
2563         (coffstab_build_psymtabs): Change type of stabsects parameter.
2564         Update.
2565         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2566         std::vector.
2567         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2568         (coff_locate_sections): Update.
2569         (coff_symfile_read): Remove cleanups.  Update.
2570         (init_stringtab): Add storage parameter.
2571         (free_stringtab, free_stringtab_cleanup): Remove.
2572         (init_lineno): Add storage parameter.
2573         (free_linetab, free_linetab_cleanup): Remove.
2574
2575 2019-03-06  Pedro Alves  <palves@redhat.com>
2576
2577         * linux-fork.c (fork_info::clobber_regs): Delete.
2578         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2579         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2580         comment.  Adjust.
2581         (scoped_switch_fork_info::scoped_switch_fork_info)
2582         (checkpoint_command, linux_fork_context): Adjust
2583         fork_save_infrun_state calls.
2584
2585 2019-03-06  Pedro Alves  <palves@redhat.com>
2586
2587         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2588         (inf_has_multiple_threads): Return 'bool' and rewrite using
2589         inferior_info::threads().
2590
2591 2019-03-06  Pedro Alves  <palves@redhat.com>
2592
2593         * linux-fork.c: Include <list>.
2594         (fork_list): Now a std::list instance.
2595         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2596         (forks_exist_p, find_last_fork): Adjust.
2597         (new_fork): Delete.
2598         (one_fork_p): New.
2599         (add_fork): Adjust.
2600         (free_fork): Delete, folded into fork_info::~fork_info().
2601         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2602         Adjust.
2603         (init_fork_list): Delete.
2604         (linux_fork_killall, linux_fork_mourn_inferior)
2605         (linux_fork_detach, info_checkpoints_command): Adjust.
2606         (_initialize_linux_fork): No longer call init_fork_list.
2607
2608 2019-03-06  Pedro Alves  <palves@redhat.com>
2609
2610         * linux-fork.c (new_fork): New, split out of ...
2611         (add_fork): ... this.  Return void.  Move "first fork" special
2612         case from here, to ...
2613         (checkpoint_command): ... here.
2614         * linux-linux.h (add_fork): Return void.
2615
2616 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2617
2618         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2619
2620 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2621             Chris January  <chris.january@arm.com>
2622             David Lecomber  <david.lecomber@arm.com>
2623
2624         * f-exp.y: New token, UNOP_INTRINSIC.
2625         (exp): New pattern using UNOP_INTRINSIC token.
2626         (f77_keywords): Add 'abs' keyword.
2627         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2628         (value_from_host_double): New function.
2629         (evaluate_subexp_f): Support UNOP_ABS.
2630
2631 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2632
2633         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2634         types.
2635
2636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2637
2638         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2639         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2640         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2641
2642 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2643
2644         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2645
2646 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2647             Chris January  <chris.january@arm.com>
2648
2649         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2650         * f-exp.y: Define 'KIND' token.
2651         (exp): New pattern for KIND expressions.
2652         (ptype): Handle types with a kind extension.
2653         (direct_abs_decl): Extend to spot kind extensions.
2654         (f77_keywords): Add 'kind' to the list.
2655         (push_kind_type): New function.
2656         (convert_to_kind_type): New function.
2657         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2658         * parse.c (operator_length_standard): Likewise.
2659         * parser-defs.h (enum type_pieces): Add tp_kind.
2660         * std-operator.def: Add UNOP_KIND.
2661
2662 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2663
2664         * f-exp.y (f_parse): Set yydebug.
2665
2666 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2667
2668         * f-lang.c (evaluate_subexp_f): New function.
2669         (exp_descriptor_f): New global.
2670         (f_language_defn): Use exp_descriptor_f instead of
2671         exp_descriptor_standard.
2672
2673 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2674
2675         * f-exp.y (struct token): Add comments.
2676         (dot_ops): Remove uppercase versions and the end marker.
2677         (f77_keywords): Likewise.
2678         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2679         entries in the dot_ops array are case insensitive, and use
2680         strncasecmp to compare strings.  Also some whitespace cleanup in
2681         this area.  Similar for the f77_keywords array, except entries in
2682         this list might be case sensitive.
2683
2684 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2685
2686         * f-exp.y (struct f77_boolean_val): Add comments.
2687         (boolean_values): Remove uppercase versions, and end marker.
2688         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2689         and use strncasecmp to achieve case insensitivity.  Additionally,
2690         perform whitespace cleanup around this code.
2691
2692 2019-03-06  Tom Tromey  <tromey@adacore.com>
2693
2694         * remote-sim.c (gdbsim_target_open): Use result of
2695         gdb_argv::release.
2696
2697 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2698         Dirk Schubert  <dirk.schubert@arm.com>
2699         Chris January  <chris.january@arm.com>
2700
2701         * eval.c (evaluate_subexp_standard): Call Fortran argument
2702         wrapping logic.
2703         * f-lang.c (struct value): A value which can be passed into a
2704         Fortran function call.
2705         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2706         where appropriate.
2707         (struct type): Value ready for a Fortran function call.
2708         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2709         is needed.
2710         * f-lang.h (fortran_argument_convert): Declaration.
2711         (fortran_preserve_arg_pointer): Declaration.
2712         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2713
2714 2019-03-05  Tom Tromey  <tromey@adacore.com>
2715
2716         * python/py-prettyprint.c (print_string_repr): Remove #if.
2717         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2718
2719 2019-03-05  Tom Tromey  <tromey@adacore.com>
2720
2721         * target.c (the_dummy_target): Move later.  Change type to
2722         "dummy_target".
2723         (initialize_targets): Don't initialize the_dummy_target.
2724
2725 2019-03-05  Tom Tromey  <tromey@adacore.com>
2726
2727         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2728         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2729
2730 2019-03-05  Tom Tromey  <tromey@adacore.com>
2731
2732         * windows-nat.c (windows_nat_target::attach)
2733         (windows_nat_target::detach): Don't call gdb_flush.
2734         * valprint.c (generic_val_print, val_print, val_print_string):
2735         Don't call gdb_flush.
2736         * utils.c (defaulted_query): Don't call gdb_flush.
2737         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2738         * target.c (target_announce_detach): Don't call gdb_flush.
2739         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2740         * remote.c (extended_remote_target::attach): Don't call
2741         gdb_flush.
2742         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2743         * printcmd.c (do_examine): Don't call gdb_flush.
2744         (info_display_command): Don't call gdb_flush.
2745         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2746         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2747         * memattr.c (info_mem_command): Don't call gdb_flush.
2748         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2749         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2750         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2751         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2752         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2753         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2754         (gnu_nat_target::detach): Don't call gdb_flush.
2755         * f-valprint.c (f_val_print): Don't call gdb_flush.
2756         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2757         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2758         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2759         gdb_flush.
2760         * c-valprint.c (c_val_print): Don't call gdb_flush.
2761         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2762
2763 2019-03-05  Tom Tromey  <tromey@adacore.com>
2764
2765         * varobj.c (update_dynamic_varobj_children): Update.
2766         (install_default_visualizer): Use reset, not release.
2767         * value.c (set_internalvar): Update.
2768         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2769         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2770         ATTRIBUTE_UNUSED_RESULT.
2771
2772 2019-03-05  Tom Tromey  <tromey@adacore.com>
2773
2774         * remote.c (class scoped_remote_fd) <release>: Add
2775         ATTRIBUTE_UNUSED_RESULT.
2776
2777 2019-03-05  Tom Tromey  <tromey@adacore.com>
2778
2779         * macroexp.c (struct macro_buffer) <release>: Add
2780         ATTRIBUTE_UNUSED_RESULT.
2781
2782 2019-03-05  Tom Tromey  <tromey@adacore.com>
2783
2784         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2785         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2786         ATTRIBUTE_UNUSED_RESULT.
2787
2788 2019-03-05  Tom Tromey  <tromey@adacore.com>
2789
2790         * common/scoped_fd.h (class scoped_fd) <release>: Add
2791         ATTRIBUTE_UNUSED_RESULT.
2792
2793 2019-03-05  Tom Tromey  <tromey@adacore.com>
2794
2795         * parser-defs.h (struct parser_state) <release>: Add
2796         ATTRIBUTE_UNUSED_RESULT.
2797
2798 2019-03-05  Tom Tromey  <tromey@adacore.com>
2799
2800         * utils.h (class gdb_argv) <release>: Add
2801         ATTRIBUTE_UNUSED_RESULT.
2802         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2803
2804 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2805
2806         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2807         for-loop range, to avoid compiler warnings.
2808
2809         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2810         avoid compiler warnings about unused variables.
2811
2812         * NEWS: Mention end of support for native debugging on MS-Windows
2813         before XP.
2814
2815         PR gdb/24292
2816         * common/netstuff.c:
2817         * gdbserver/gdbreplay.c
2818         * gdbserver/remote-utils.c:
2819         * ser-tcp.c:
2820         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2821         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2822         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2823         'getaddrinfo' and 'freeaddrinfo' were not available before
2824         Windows XP, and mingw.org's MinGW headers by default define
2825         _WIN32_WINNT to 0x500.
2826
2827 2019-03-01  Gary Benson <gbenson@redhat.com>
2828
2829         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2830
2831 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2832             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2833
2834         PR gdb/8527
2835         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2836         set_sigint_trap, clear_sigint_trap.
2837
2838 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2839
2840         * target.c (target_detach): Clear the regcache and the
2841         frame cache.
2842
2843 2019-02-27  Pedro Alves  <palves@redhat.com>
2844
2845         * utils.c (set_screen_size): When we cap the height/width sizes,
2846         tweak the corresponding command variable to show "unlimited":
2847
2848 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2849             Pedro Alves  <palves@redhat.com>
2850
2851         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2852         before calling rl_set_screen_size.
2853
2854 2019-02-27  Tom Tromey  <tromey@adacore.com>
2855
2856         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2857         define.
2858         * python/py-value.c: Remove Python 2.4 workaround.
2859         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2860         workaround.
2861         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2862         Python 2.4 workaround.
2863         * python/python-internal.h: Remove Python 2.4 comment.
2864         (Py_ssize_t): Don't define.
2865         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2866         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2867         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2868         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2869         * python/python.c (do_start_initialization): Remove Python 2.4
2870         workaround.
2871         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2872         (print_children): Remove Python 2.4 workaround.
2873         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2874         workaround.
2875         (CHARBUFFERPROC_NAME): Remove.
2876         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2877         Python 2.4 workaround.
2878
2879 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2880
2881         * NEWS: Note minimum Python version.
2882
2883 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2884
2885         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2886         code from these functions.  Remove corresponding ifdefs.  Use
2887         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2888         Remove gotos and target of gotos.
2889         (infpy_search_memory): Likewise.
2890
2891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2892
2893         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2894         (hppa_gdbarch_init): Don't register deleted functions with
2895         gdbarch.
2896
2897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2898
2899         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2900         (h8300_unwind_sp): Delete.
2901         (h8300_dummy_id): Delete.
2902         (h8300_gdbarch_init): Don't register deleted functions with
2903         gdbarch.
2904
2905 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2906
2907         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2908         (ft32_unwind_pc): Delete.
2909         (ft32_unwind_sp): Delete.
2910         (ft32_gdbarch_init): Don't register deleted functions with
2911         gdbarch.
2912
2913 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2914
2915         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2916         (frv_unwind_pc): Delete.
2917         (frv_unwind_sp): Delete.
2918         (frv_gdbarch_init): Don't register deleted functions with
2919         gdbarch.
2920
2921 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2922
2923         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2924         (riscv_unwind_pc): Delete.
2925         (riscv_unwind_sp): Delete.
2926         (riscv_gdbarch_init): Don't register deleted functions with
2927         gdbarch.
2928
2929 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2930
2931         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2932         (csky_unwind_pc): Delete.
2933         (csky_unwind_sp): Delete.
2934         (csky_gdbarch_init): Don't register deleted functions with
2935         gdbarch.
2936
2937 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2938
2939         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2940         (cris_unwind_pc): Delete.
2941         (cris_unwind_sp): Delete.
2942         (cris_gdbarch_init): Don't register deleted functions with
2943         gdbarch.
2944
2945 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2946
2947         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2948         (bfin_unwind_pc): Delete.
2949         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2950
2951 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2952
2953         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2954         (arm_unwind_pc): Delete.
2955         (arm_unwind_sp): Delete.
2956         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2957
2958 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2959
2960         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2961         (arc_unwind_pc): Delete.
2962         (arc_unwind_sp): Delete.
2963         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2964
2965 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2966
2967         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2968         (alpha_unwind_pc): Delete.
2969         (alpha_gdbarch_init): Don't register deleted functions with
2970         gdbarch.
2971
2972 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2973
2974         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2975         (aarch64_unwind_pc): Delete.
2976         (aarch64_unwind_sp): Delete.
2977         (aarch64_gdbarch_init): Don't register deleted functions with
2978         gdbarch.
2979
2980 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2981
2982         * gdbtypes.c (type_align): Don't consider static members when
2983         computing structure alignment.
2984
2985 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2986
2987         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2988         return 0 for other types.
2989         * arch-utils.c (default_type_align): Always return 0.
2990         * gdbarch.h: Regenerate.
2991         * gdbarch.sh (type_align): Extend comment.
2992         * gdbtypes.c (type_align): Add additional comments, always call
2993         gdbarch_type_align before applying the default rules.
2994         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2995         generic code will then apply a suitable default.
2996         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2997         types, return 0 for other types.
2998
2999 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3000
3001         * NEWS: Create a new section for the next release branch.
3002         Rename the section of the current branch, now that it has
3003         been cut.
3004
3005 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3006
3007         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3008         * version.in: Bump version to 8.3.50.DATE-git.
3009
3010 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3011
3012         * aix-thread.c (ptid_cmp): Remove unused variable.
3013         (get_signaled_thread): Likewise.
3014         (store_regs_user_thread): Likewise.
3015         (store_regs_kernel_thread): Likewise.
3016         (fetch_regs_kernel_thread): Remove shadowed variable.
3017
3018 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3019
3020         * features/riscv/32bit-cpu.xml: Add register numbers.
3021         * features/riscv/32bit-fpu.c: Regenerate.
3022         * features/riscv/32bit-fpu.xml: Add register numbers.
3023         * features/riscv/64bit-cpu.xml: Add register numbers.
3024         * features/riscv/64bit-fpu.c: Regenerate.
3025         * features/riscv/64bit-fpu.xml: Add register numbers.
3026
3027 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3028
3029         * NEWS: Mention two argument form of gdb.Value constructor.
3030         * python/py-value.c (convert_buffer_and_type_to_value): New
3031         function.
3032         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3033         Add support for handling an optional second argument.  Call
3034         convert_buffer_and_type_to_value as appropriate.
3035         * python/python-internal.h (Py_buffer_deleter): New struct.
3036         (Py_buffer_up): New typedef.
3037
3038 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3039
3040         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3041         instead of releasing ownership.
3042
3043 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3044
3045         * dwarf2read.c (open_and_init_dwp_file): Call
3046         elf_numsections instead of bfd_count_sections to initialize
3047         dwp_file->num_sections.
3048
3049 2019-02-25  Tom Tromey  <tromey@adacore.com>
3050
3051         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3052
3053 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3054
3055         * gcore.in: Add '--readnever' option when invoking GDB.
3056
3057 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3058
3059         * MAINTAINERS: Update my email address.
3060
3061 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3062
3063         * build-id.c (build_id_to_debug_bfd_1): New function.
3064         (build_id_to_debug_bfd): Look for separate debug file in
3065         sysroot.
3066
3067 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3068
3069         * gdbarch.sh: Update the copyright year range that is placed into
3070         generated files.
3071
3072 2019-02-22  Keith Seitz  <keiths@redhat.com>
3073
3074         PR symtab/23853
3075         * linespec.c (create_sals_line_offset): Search for the default
3076         symtab's filename instead of its fullname.
3077
3078 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3079
3080         * NEWS: Update style defaults.
3081
3082 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3083
3084         * main.c (captured_main_1): Disable styling in batch mode.
3085
3086 2019-02-20  Tom Tromey  <tom@tromey.com>
3087
3088         * symtab.c (symtab_symbol_info): Fix typos.
3089
3090 2019-02-20  Tom Tromey  <tromey@adacore.com>
3091
3092         * findcmd.c (_initialize_mem_search): Use upper case for
3093         metasyntactic variables.
3094
3095 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3096
3097         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3098         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3099
3100 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3101
3102         * top.h (source_file_name): Change to std::string.
3103         * top.c (source_file_name): Likewise.
3104         (command_line_input): Adjust.
3105         * cli/cli-script.c (script_from_file): Adjust.
3106
3107 2019-02-19  Tom Tromey  <tromey@adacore.com>
3108
3109         * ravenscar-thread.c
3110         (ravenscar_thread_target::update_thread_list): Don't call
3111         ada_build_task_list.
3112         * ada-lang.h (ada_build_task_list): Don't declare.
3113         * ada-tasks.c (struct ada_tasks_inferior_data)
3114         <task_list_valid_p>: Now bool.
3115         (read_known_tasks, ada_task_list_changed)
3116         (ada_tasks_invalidate_inferior_data): Update.
3117         (read_known_tasks_array): Return bool.
3118         (read_known_tasks_list): Likewise.
3119         (read_known_tasks): Return void.
3120         (ada_build_task_list): Now static.
3121
3122 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3123
3124         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3125         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3126
3127 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3128
3129         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3130         variant for ada_tasks_pspace_data_handle and
3131         ada_tasks_inferior_data_handle.
3132         (ada_tasks_pspace_data_cleanup): New function.
3133         (ada_tasks_inferior_data_cleanup): New function.
3134
3135 2019-02-17  Tom Tromey  <tom@tromey.com>
3136
3137         * macrotab.h (macro_source_fullname): Return a std::string.
3138         * macrotab.c (macro_include, check_for_redefinition)
3139         (macro_undef, macro_lookup_definition, foreach_macro)
3140         (foreach_macro_in_scope): Update.
3141         (macro_source_fullname): Return a std::string.
3142         * macrocmd.c (show_pp_source_pos): Update.
3143
3144 2019-02-17  Tom Tromey  <tom@tromey.com>
3145
3146         * macrocmd.c (show_pp_source_pos): Style the file names.
3147
3148 2019-02-17  Tom Tromey  <tom@tromey.com>
3149
3150         PR tui/24197:
3151         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3152
3153 2019-02-17  Tom Tromey  <tom@tromey.com>
3154
3155         * ada-lang.c (user_select_syms): Use filtered printing.
3156         * utils.c (wrap_style): New global.
3157         (desired_style): Remove.
3158         (emit_style_escape): Add stream parameter.
3159         (set_output_style, reset_terminal_style, prompt_for_continue):
3160         Update.
3161         (flush_wrap_buffer): Only flush gdb_stdout.
3162         (wrap_here): Set wrap_style.
3163         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3164         treat escape sequences as a character.  Change when wrap buffer is
3165         flushed.
3166         (fputs_styled): Do not set the output style when the default is
3167         requested.
3168         * ui-style.h (struct ui_file_style) <is_default>: New method.
3169         * source.c (print_source_lines_base): Emit escape sequences in one
3170         piece.
3171
3172 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3173
3174         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3175         integers and enumeration types.
3176
3177 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3178
3179         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3180         instead of lookup_symbol_in_language
3181         (do_exact_match): New function.
3182         (ada_get_symbol_name_matcher): Return do_exact_match when
3183         doing a verbatim match.
3184
3185 2019-02-15  Tom Tromey  <tromey@adacore.com>
3186
3187         * ravenscar-thread.c (ravenscar_thread_target::resume)
3188         (ravenscar_thread_target::wait): Special case wildcard requests.
3189
3190 2019-02-15  Tom Tromey  <tromey@adacore.com>
3191
3192         * ravenscar-thread.c (base_ptid): Remove.
3193         (struct ravenscar_thread_target) <close>: New method.
3194         <m_base_ptid>: New member.
3195         <update_inferior_ptid, active_task, task_is_currently_active,
3196         runtime_initialized>: Declare methods.
3197         <ravenscar_thread_target>: Add constructor.
3198         (ravenscar_thread_target::task_is_currently_active)
3199         (ravenscar_thread_target::update_inferior_ptid)
3200         (ravenscar_runtime_initialized): Rename.  Now methods.
3201         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3202         (ravenscar_thread_target::update_thread_list): Update.
3203         (ravenscar_thread_target::active_task): Now method.
3204         (ravenscar_thread_target::store_registers)
3205         (ravenscar_thread_target::prepare_to_store)
3206         (ravenscar_thread_target::prepare_to_store)
3207         (ravenscar_thread_target::mourn_inferior): Update.
3208         (ravenscar_inferior_created): Use "new" to create target.
3209         (ravenscar_thread_target::get_ada_task_ptid): Update.
3210         (_initialize_ravenscar): Don't initialize base_ptid.
3211         (ravenscar_ops): Remove global.
3212
3213 2019-02-15  Tom Tromey  <tromey@adacore.com>
3214
3215         * target.h (push_target): Declare new overload.
3216         * target.c (push_target): New overload, taking an rvalue reference.
3217         * remote.c (remote_target::open_1): Use push_target overload.
3218         * corelow.c (core_target_open): Use push_target overload.
3219
3220 2019-02-15  Tom Tromey  <tromey@adacore.com>
3221
3222         * ravenscar-thread.c (is_ravenscar_task)
3223         (ravenscar_task_is_currently_active): Return bool.
3224         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3225         (_initialize_ravenscar): Remove "(void)".
3226         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3227         Return bool.
3228
3229 2019-02-15  Tom Tromey  <tromey@adacore.com>
3230
3231         * ravenscar-thread.c (ravenscar_runtime_initializer)
3232         (has_ravenscar_runtime, get_running_thread_id)
3233         (ravenscar_thread_target::resume): Fix indentation.
3234
3235 2019-02-15  Tom Tromey  <tromey@adacore.com>
3236
3237         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3238         from ravenscar_arch_ops.
3239         (sparc_ravenscar_ops::fetch_registers)
3240         (sparc_ravenscar_ops::store_registers): Now methods.
3241         (sparc_ravenscar_prepare_to_store): Remove.
3242         (sparc_ravenscar_ops): Redefine.
3243         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3244         methods and destructor.  Remove members.
3245         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3246         (ravenscar_thread_target::store_registers)
3247         (ravenscar_thread_target::prepare_to_store): Update.
3248         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3249         Remove.
3250         (struct ppc_ravenscar_powerpc_ops): Derive from
3251         ravenscar_arch_ops.
3252         (ppc_ravenscar_powerpc_ops::fetch_registers)
3253         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3254         (ppc_ravenscar_powerpc_ops): Redefine.
3255         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3256         (ppc_ravenscar_e500_ops::fetch_registers)
3257         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3258         (ppc_ravenscar_e500_ops): Redefine.
3259         * aarch64-ravenscar-thread.c
3260         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3261         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3262         (aarch64_ravenscar_fetch_registers)
3263         (aarch64_ravenscar_store_registers): Now methods.
3264         (aarch64_ravenscar_ops): Redefine.
3265
3266 2019-02-15  Tom Tromey  <tromey@adacore.com>
3267
3268         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3269         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3270         (ravenscar_thread_target::stopped_by_watchpoint)
3271         (ravenscar_thread_target::stopped_data_address)
3272         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3273
3274 2019-02-15  Tom Tromey  <tromey@adacore.com>
3275
3276         * ravenscar-thread.c: Fix some typos.
3277
3278 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3279             Tom Tromey  <tromey@adacore.com>
3280
3281         * ada-lang.c (ada_exception_sal): Change addr_string to a
3282         std::string.
3283         (create_ada_exception_catchpoint): Update.
3284
3285 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3286             Tom Tromey  <tromey@adacore.com>
3287
3288         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3289         (bp_location_ops): Remove.
3290         (base_breakpoint_allocate_location): Update.
3291         (free_bp_location): Update.
3292         * ada-lang.c (class ada_catchpoint_location)
3293         <ada_catchpoint_location>: Remove ops parameter.
3294         (ada_catchpoint_location_dtor): Remove.
3295         (ada_catchpoint_location_ops): Remove.
3296         (allocate_location_exception): Update.
3297         * breakpoint.h (struct bp_location_ops): Remove.
3298         (class bp_location) <bp_location>: Remove bp_location_ops
3299         parameter.
3300         <~bp_location>: Add destructor.
3301         <ops>: Remove.
3302
3303 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3304             Pedro Alves  <palves@redhat.com>
3305
3306         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3307         'PATH_MAX'.
3308
3309 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3310             Samuel Thibault  <samuel.thibault@gnu.org>
3311             Thomas Schwinge  <thomas@codesourcery.com>
3312
3313         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3314         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3315
3316 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3317
3318         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3319         (check_empty): Use "const char *".
3320
3321         * gnu-nat.c (gnu_nat_target::detach): Instead of
3322         'detach_inferior (pid)' call
3323         'detach_inferior (find_inferior_pid (pid))'.
3324
3325         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3326         'nat/fork-inferior.o'.
3327         * gnu-nat.c: #include "nat/fork-inferior.h".
3328
3329         * gnu-nat.c (gnu_nat_target::detach): Instead of
3330         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3331         * gnu-nat.h: #include "inf-child.h".
3332         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3333         'i386_gnu_nat_target::fetch_registers'.
3334         (gnu_store_registers): Rename/move to
3335         'i386_gnu_nat_target::store_registers'.
3336
3337         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3338         * gnu-nat.h (mach_thread_info): New function.
3339         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3340
3341         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3342
3343 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3344
3345         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3346
3347 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3348
3349         * windows-nat.c (windows_add_thread): Add new parameter
3350         "main_thread_p" with default value set to false.  Update
3351         function documentation as well as all callers.
3352         (windows_delete_thread): Likewise.
3353         (fake_create_process): Update call to windows_add_thread.
3354         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3355         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3356         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3357         call to windows_delete_thread.
3358
3359 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3360
3361         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3362
3363 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3364
3365         * symfile.c (find_separate_debug_file): Use canonical path of
3366         sysroot with child_path instead of gdb_sysroot if it is valid.
3367
3368 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3369
3370         * symfile.c (find_separate_debug_file): Use child_path to
3371         determine if an object file is under a sysroot.
3372
3373 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3374
3375         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3376         unittests/child-path-selftests.c.
3377         * common/pathstuff.c (child_path): New function.
3378         * common/pathstuff.h (child_path): New prototype.
3379         * unittests/child-path-selftests.c: New file.
3380
3381 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3382
3383         * symfile.c (find_separate_debug_file): Look for separate debug
3384         files in debug directories under the sysroot.
3385
3386 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3387
3388         * symtab.h (struct minimal_symbol data_p): New const method.
3389         (struct minimal_symbol text_p): Likewise.
3390         * symtab.c (output_source_filename): Use file name style
3391         to print file name.
3392         (print_symbol_info): Likewise.
3393         (print_msymbol_info): Use address style to print addresses.
3394         Use function name style to print executable text symbols.
3395         (expand_symtab_containing_pc): Use data_p.
3396         (find_pc_sect_compunit_symtab): Likewise.
3397
3398 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3399
3400         * breakpoint.c (describe_other_breakpoints): Use address style
3401         to print addresses.
3402         (say_where): Likewise.
3403
3404 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3405
3406         * ada-typeprint.c (print_func_type): Print function name
3407         style to print function name.
3408         * c-typeprint.c (c_print_type_1): Likewise.
3409
3410 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3411
3412         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3413         for execve.
3414
3415 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3416
3417         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3418         type_stack.
3419
3420 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3421
3422         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3423         TYPE_CODE_REF types.
3424
3425 2019-02-08  Jim Wilson  <jimw@sifive.com>
3426
3427         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3428         (riscv_linux_fregset): New.
3429         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3430
3431 2019-02-07  Tom Tromey  <tom@tromey.com>
3432
3433         * thread.c (thread_cancel_execution_command): Update.
3434         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3435         methods.
3436         (struct thread_fsm_ops): Remove.
3437         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3438         (thread_fsm_should_stop, thread_fsm_return_value)
3439         (thread_fsm_set_finished, thread_fsm_finished_p)
3440         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3441         Don't declare.
3442         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3443         * infrun.c (clear_proceed_status_thread)
3444         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3445         (print_stop_event): Update.
3446         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3447         Add constructor.
3448         (step_command_fsm_ops): Remove.
3449         (new_step_command_fsm): Remove.
3450         (step_1): Update.
3451         (step_command_fsm::should_stop): Rename from
3452         step_command_fsm_should_stop.
3453         (step_command_fsm::clean_up): Rename from
3454         step_command_fsm_clean_up.
3455         (step_command_fsm::do_async_reply_reason): Rename from
3456         step_command_fsm_async_reply_reason.
3457         (struct until_next_fsm): Inherit from thread_fsm.  Add
3458         constructor.
3459         (until_next_fsm_ops): Remove.
3460         (new_until_next_fsm): Remove.
3461         (until_next_fsm::should_stop): Rename from
3462         until_next_fsm_should_stop.
3463         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3464         (until_next_fsm::do_async_reply_reason): Rename from
3465         until_next_fsm_async_reply_reason.
3466         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3467         constructor.  Change type of breakpoint.
3468         (finish_command_fsm_ops): Remove.
3469         (new_finish_command_fsm): Remove.
3470         (finish_command_fsm::should_stop): Rename from
3471         finish_command_fsm_should_stop.
3472         (finish_command_fsm::clean_up): Rename from
3473         finish_command_fsm_clean_up.
3474         (finish_command_fsm::return_value): Rename from
3475         finish_command_fsm_return_value.
3476         (finish_command_fsm::do_async_reply_reason): Rename from
3477         finish_command_fsm_async_reply_reason.
3478         (finish_command): Update.
3479         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3480         Add constructor.
3481         (call_thread_fsm_ops): Remove.
3482         (call_thread_fsm::call_thread_fsm): Rename from
3483         new_call_thread_fsm.
3484         (call_thread_fsm::should_stop): Rename from
3485         call_thread_fsm_should_stop.
3486         (call_thread_fsm::should_notify_stop): Rename from
3487         call_thread_fsm_should_notify_stop.
3488         (run_inferior_call, call_function_by_hand_dummy): Update.
3489         * cli/cli-interp.c (should_print_stop_to_console): Update.
3490         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3491         Add constructor.  Change type of location_breakpoint,
3492         caller_breakpoint.
3493         (until_break_fsm_ops): Remove.
3494         (new_until_break_fsm): Remove.
3495         (until_break_fsm::should_stop): Rename from
3496         until_break_fsm_should_stop.
3497         (until_break_fsm::clean_up): Rename from
3498         until_break_fsm_clean_up.
3499         (until_break_fsm::do_async_reply_reason): Rename from
3500         until_break_fsm_async_reply_reason.
3501         (until_break_command): Update.
3502         * thread-fsm.c: Remove.
3503         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3504
3505 2019-02-07  Tom Tromey  <tom@tromey.com>
3506
3507         * yy-remap.h: Add include guard.
3508         * xtensa-tdep.h: Add include guard.
3509         * xcoffread.h: Rename include guard.
3510         * varobj-iter.h: Add include guard.
3511         * tui/tui.h: Rename include guard.
3512         * tui/tui-winsource.h: Rename include guard.
3513         * tui/tui-wingeneral.h: Rename include guard.
3514         * tui/tui-windata.h: Rename include guard.
3515         * tui/tui-win.h: Rename include guard.
3516         * tui/tui-stack.h: Rename include guard.
3517         * tui/tui-source.h: Rename include guard.
3518         * tui/tui-regs.h: Rename include guard.
3519         * tui/tui-out.h: Rename include guard.
3520         * tui/tui-layout.h: Rename include guard.
3521         * tui/tui-io.h: Rename include guard.
3522         * tui/tui-hooks.h: Rename include guard.
3523         * tui/tui-file.h: Rename include guard.
3524         * tui/tui-disasm.h: Rename include guard.
3525         * tui/tui-data.h: Rename include guard.
3526         * tui/tui-command.h: Rename include guard.
3527         * tic6x-tdep.h: Add include guard.
3528         * target/waitstatus.h: Rename include guard.
3529         * target/wait.h: Rename include guard.
3530         * target/target.h: Rename include guard.
3531         * target/resume.h: Rename include guard.
3532         * target-float.h: Rename include guard.
3533         * stabsread.h: Add include guard.
3534         * rs6000-tdep.h: Add include guard.
3535         * riscv-fbsd-tdep.h: Add include guard.
3536         * regformats/regdef.h: Rename include guard.
3537         * record.h: Rename include guard.
3538         * python/python.h: Rename include guard.
3539         * python/python-internal.h: Rename include guard.
3540         * python/py-stopevent.h: Rename include guard.
3541         * python/py-ref.h: Rename include guard.
3542         * python/py-record.h: Rename include guard.
3543         * python/py-record-full.h: Rename include guard.
3544         * python/py-record-btrace.h: Rename include guard.
3545         * python/py-instruction.h: Rename include guard.
3546         * python/py-events.h: Rename include guard.
3547         * python/py-event.h: Rename include guard.
3548         * procfs.h: Add include guard.
3549         * proc-utils.h: Add include guard.
3550         * p-lang.h: Add include guard.
3551         * or1k-tdep.h: Rename include guard.
3552         * observable.h: Rename include guard.
3553         * nto-tdep.h: Rename include guard.
3554         * nat/x86-linux.h: Rename include guard.
3555         * nat/x86-linux-dregs.h: Rename include guard.
3556         * nat/x86-gcc-cpuid.h: Add include guard.
3557         * nat/x86-dregs.h: Rename include guard.
3558         * nat/x86-cpuid.h: Rename include guard.
3559         * nat/ppc-linux.h: Rename include guard.
3560         * nat/mips-linux-watch.h: Rename include guard.
3561         * nat/linux-waitpid.h: Rename include guard.
3562         * nat/linux-ptrace.h: Rename include guard.
3563         * nat/linux-procfs.h: Rename include guard.
3564         * nat/linux-osdata.h: Rename include guard.
3565         * nat/linux-nat.h: Rename include guard.
3566         * nat/linux-namespaces.h: Rename include guard.
3567         * nat/linux-btrace.h: Rename include guard.
3568         * nat/glibc_thread_db.h: Rename include guard.
3569         * nat/gdb_thread_db.h: Rename include guard.
3570         * nat/gdb_ptrace.h: Rename include guard.
3571         * nat/fork-inferior.h: Rename include guard.
3572         * nat/amd64-linux-siginfo.h: Rename include guard.
3573         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3574         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3575         * nat/aarch64-linux.h: Rename include guard.
3576         * nat/aarch64-linux-hw-point.h: Rename include guard.
3577         * mn10300-tdep.h: Add include guard.
3578         * mips-linux-tdep.h: Add include guard.
3579         * mi/mi-parse.h: Rename include guard.
3580         * mi/mi-out.h: Rename include guard.
3581         * mi/mi-main.h: Rename include guard.
3582         * mi/mi-interp.h: Rename include guard.
3583         * mi/mi-getopt.h: Rename include guard.
3584         * mi/mi-console.h: Rename include guard.
3585         * mi/mi-common.h: Rename include guard.
3586         * mi/mi-cmds.h: Rename include guard.
3587         * mi/mi-cmd-break.h: Rename include guard.
3588         * m2-lang.h: Add include guard.
3589         * location.h: Rename include guard.
3590         * linux-record.h: Rename include guard.
3591         * linux-nat.h: Add include guard.
3592         * linux-fork.h: Add include guard.
3593         * i386-darwin-tdep.h: Rename include guard.
3594         * hppa-linux-offsets.h: Add include guard.
3595         * guile/guile.h: Rename include guard.
3596         * guile/guile-internal.h: Rename include guard.
3597         * gnu-nat.h: Rename include guard.
3598         * gdb-stabs.h: Rename include guard.
3599         * frv-tdep.h: Add include guard.
3600         * f-lang.h: Add include guard.
3601         * event-loop.h: Add include guard.
3602         * darwin-nat.h: Rename include guard.
3603         * cp-abi.h: Rename include guard.
3604         * config/sparc/nm-sol2.h: Rename include guard.
3605         * config/nm-nto.h: Rename include guard.
3606         * config/nm-linux.h: Add include guard.
3607         * config/i386/nm-i386gnu.h: Rename include guard.
3608         * config/djgpp/nl_types.h: Rename include guard.
3609         * config/djgpp/langinfo.h: Rename include guard.
3610         * compile/gcc-cp-plugin.h: Add include guard.
3611         * compile/gcc-c-plugin.h: Add include guard.
3612         * compile/compile.h: Rename include guard.
3613         * compile/compile-object-run.h: Rename include guard.
3614         * compile/compile-object-load.h: Rename include guard.
3615         * compile/compile-internal.h: Rename include guard.
3616         * compile/compile-cplus.h: Rename include guard.
3617         * compile/compile-c.h: Rename include guard.
3618         * common/xml-utils.h: Rename include guard.
3619         * common/x86-xstate.h: Rename include guard.
3620         * common/version.h: Rename include guard.
3621         * common/vec.h: Rename include guard.
3622         * common/tdesc.h: Rename include guard.
3623         * common/selftest.h: Rename include guard.
3624         * common/scoped_restore.h: Rename include guard.
3625         * common/scoped_mmap.h: Rename include guard.
3626         * common/scoped_fd.h: Rename include guard.
3627         * common/safe-iterator.h: Rename include guard.
3628         * common/run-time-clock.h: Rename include guard.
3629         * common/refcounted-object.h: Rename include guard.
3630         * common/queue.h: Rename include guard.
3631         * common/ptid.h: Rename include guard.
3632         * common/print-utils.h: Rename include guard.
3633         * common/preprocessor.h: Rename include guard.
3634         * common/pathstuff.h: Rename include guard.
3635         * common/observable.h: Rename include guard.
3636         * common/netstuff.h: Rename include guard.
3637         * common/job-control.h: Rename include guard.
3638         * common/host-defs.h: Rename include guard.
3639         * common/gdb_wait.h: Rename include guard.
3640         * common/gdb_vecs.h: Rename include guard.
3641         * common/gdb_unlinker.h: Rename include guard.
3642         * common/gdb_unique_ptr.h: Rename include guard.
3643         * common/gdb_tilde_expand.h: Rename include guard.
3644         * common/gdb_sys_time.h: Rename include guard.
3645         * common/gdb_string_view.h: Rename include guard.
3646         * common/gdb_splay_tree.h: Rename include guard.
3647         * common/gdb_setjmp.h: Rename include guard.
3648         * common/gdb_ref_ptr.h: Rename include guard.
3649         * common/gdb_optional.h: Rename include guard.
3650         * common/gdb_locale.h: Rename include guard.
3651         * common/gdb_assert.h: Rename include guard.
3652         * common/filtered-iterator.h: Rename include guard.
3653         * common/filestuff.h: Rename include guard.
3654         * common/fileio.h: Rename include guard.
3655         * common/environ.h: Rename include guard.
3656         * common/common-utils.h: Rename include guard.
3657         * common/common-types.h: Rename include guard.
3658         * common/common-regcache.h: Rename include guard.
3659         * common/common-inferior.h: Rename include guard.
3660         * common/common-gdbthread.h: Rename include guard.
3661         * common/common-exceptions.h: Rename include guard.
3662         * common/common-defs.h: Rename include guard.
3663         * common/common-debug.h: Rename include guard.
3664         * common/cleanups.h: Rename include guard.
3665         * common/buffer.h: Rename include guard.
3666         * common/btrace-common.h: Rename include guard.
3667         * common/break-common.h: Rename include guard.
3668         * cli/cli-utils.h: Rename include guard.
3669         * cli/cli-style.h: Rename include guard.
3670         * cli/cli-setshow.h: Rename include guard.
3671         * cli/cli-script.h: Rename include guard.
3672         * cli/cli-interp.h: Rename include guard.
3673         * cli/cli-decode.h: Rename include guard.
3674         * cli/cli-cmds.h: Rename include guard.
3675         * charset-list.h: Add include guard.
3676         * buildsym-legacy.h: Rename include guard.
3677         * bfin-tdep.h: Add include guard.
3678         * ax.h: Rename include guard.
3679         * arm-linux-tdep.h: Add include guard.
3680         * arm-fbsd-tdep.h: Add include guard.
3681         * arch/xtensa.h: Rename include guard.
3682         * arch/tic6x.h: Add include guard.
3683         * arch/i386.h: Add include guard.
3684         * arch/arm.h: Rename include guard.
3685         * arch/arm-linux.h: Rename include guard.
3686         * arch/arm-get-next-pcs.h: Rename include guard.
3687         * arch/amd64.h: Add include guard.
3688         * arch/aarch64-insn.h: Rename include guard.
3689         * arch-utils.h: Rename include guard.
3690         * annotate.h: Add include guard.
3691         * amd64-darwin-tdep.h: Rename include guard.
3692         * aarch64-linux-tdep.h: Add include guard.
3693         * aarch64-fbsd-tdep.h: Add include guard.
3694         * aarch32-linux-nat.h: Add include guard.
3695
3696 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3697
3698         * macrotab.c (macro_define_internal): New function that
3699         factorizes macro_define_object_internal and macro_define_function
3700         code.
3701         (macro_define_object_internal): Use macro_define_internal.
3702         (macro_define_function): Likewise.
3703
3704 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3705
3706         * macrocmd.c (extract_identifier): Return
3707         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3708         callers.
3709
3710 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3711
3712         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3713
3714 2019-02-05  Tom Tromey  <tom@tromey.com>
3715
3716         * target.c (target_stack::unpush): Move assertion earlier.
3717
3718 2019-01-30  Tom Tromey  <tom@tromey.com>
3719
3720         PR python/23615:
3721         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3722         (gdbpy_parse_and_eval): Likewise.
3723         * python/python-internal.h (gdbpy_allow_threads): New class.
3724
3725 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3726
3727         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3728         (aarch64_fbsd_fpregmap): Move earlier.
3729         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3730         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3731         instead of individual calls to trad_frame_set_reg_addr.
3732         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3733         earlier.
3734         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3735         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3736         instead of individual calls to trad_frame_set_reg_addr.
3737
3738 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3739
3740         * CONTRIBUTE: Replace contribution list with wiki link.
3741
3742 2019-01-25  Tom Tromey  <tom@tromey.com>
3743
3744         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3745
3746 2019-01-25  Tom Tromey  <tom@tromey.com>
3747
3748         * xtensa-linux-nat.c: Fix common/ includes.
3749         * xml-support.h: Fix common/ includes.
3750         * xml-support.c: Fix common/ includes.
3751         * x86-linux-nat.c: Fix common/ includes.
3752         * windows-nat.c: Fix common/ includes.
3753         * varobj.h: Fix common/ includes.
3754         * varobj.c: Fix common/ includes.
3755         * value.c: Fix common/ includes.
3756         * valops.c: Fix common/ includes.
3757         * utils.c: Fix common/ includes.
3758         * unittests/xml-utils-selftests.c: Fix common/ includes.
3759         * unittests/utils-selftests.c: Fix common/ includes.
3760         * unittests/unpack-selftests.c: Fix common/ includes.
3761         * unittests/tracepoint-selftests.c: Fix common/ includes.
3762         * unittests/style-selftests.c: Fix common/ includes.
3763         * unittests/string_view-selftests.c: Fix common/ includes.
3764         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3765         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3766         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3767         * unittests/rsp-low-selftests.c: Fix common/ includes.
3768         * unittests/parse-connection-spec-selftests.c: Fix common/
3769         includes.
3770         * unittests/optional-selftests.c: Fix common/ includes.
3771         * unittests/offset-type-selftests.c: Fix common/ includes.
3772         * unittests/observable-selftests.c: Fix common/ includes.
3773         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3774         * unittests/memrange-selftests.c: Fix common/ includes.
3775         * unittests/memory-map-selftests.c: Fix common/ includes.
3776         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3777         * unittests/function-view-selftests.c: Fix common/ includes.
3778         * unittests/environ-selftests.c: Fix common/ includes.
3779         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3780         * unittests/common-utils-selftests.c: Fix common/ includes.
3781         * unittests/cli-utils-selftests.c: Fix common/ includes.
3782         * unittests/array-view-selftests.c: Fix common/ includes.
3783         * ui-file.c: Fix common/ includes.
3784         * tui/tui-io.c: Fix common/ includes.
3785         * tracepoint.h: Fix common/ includes.
3786         * tracepoint.c: Fix common/ includes.
3787         * tracefile-tfile.c: Fix common/ includes.
3788         * top.h: Fix common/ includes.
3789         * top.c: Fix common/ includes.
3790         * thread.c: Fix common/ includes.
3791         * target/waitstatus.h: Fix common/ includes.
3792         * target/waitstatus.c: Fix common/ includes.
3793         * target.h: Fix common/ includes.
3794         * target.c: Fix common/ includes.
3795         * target-memory.c: Fix common/ includes.
3796         * target-descriptions.c: Fix common/ includes.
3797         * symtab.h: Fix common/ includes.
3798         * symfile.c: Fix common/ includes.
3799         * stap-probe.c: Fix common/ includes.
3800         * spu-linux-nat.c: Fix common/ includes.
3801         * sparc-nat.c: Fix common/ includes.
3802         * source.c: Fix common/ includes.
3803         * solib.c: Fix common/ includes.
3804         * solib-target.c: Fix common/ includes.
3805         * ser-unix.c: Fix common/ includes.
3806         * ser-tcp.c: Fix common/ includes.
3807         * ser-pipe.c: Fix common/ includes.
3808         * ser-base.c: Fix common/ includes.
3809         * selftest-arch.c: Fix common/ includes.
3810         * s12z-tdep.c: Fix common/ includes.
3811         * rust-exp.y: Fix common/ includes.
3812         * rs6000-aix-tdep.c: Fix common/ includes.
3813         * riscv-tdep.c: Fix common/ includes.
3814         * remote.c: Fix common/ includes.
3815         * remote-notif.h: Fix common/ includes.
3816         * remote-fileio.h: Fix common/ includes.
3817         * remote-fileio.c: Fix common/ includes.
3818         * regcache.h: Fix common/ includes.
3819         * regcache.c: Fix common/ includes.
3820         * record-btrace.c: Fix common/ includes.
3821         * python/python.c: Fix common/ includes.
3822         * python/py-type.c: Fix common/ includes.
3823         * python/py-inferior.c: Fix common/ includes.
3824         * progspace.h: Fix common/ includes.
3825         * producer.c: Fix common/ includes.
3826         * procfs.c: Fix common/ includes.
3827         * proc-api.c: Fix common/ includes.
3828         * printcmd.c: Fix common/ includes.
3829         * ppc-linux-nat.c: Fix common/ includes.
3830         * parser-defs.h: Fix common/ includes.
3831         * osdata.c: Fix common/ includes.
3832         * obsd-nat.c: Fix common/ includes.
3833         * nat/x86-linux.c: Fix common/ includes.
3834         * nat/x86-linux-dregs.c: Fix common/ includes.
3835         * nat/x86-dregs.h: Fix common/ includes.
3836         * nat/x86-dregs.c: Fix common/ includes.
3837         * nat/ppc-linux.c: Fix common/ includes.
3838         * nat/mips-linux-watch.h: Fix common/ includes.
3839         * nat/mips-linux-watch.c: Fix common/ includes.
3840         * nat/linux-waitpid.c: Fix common/ includes.
3841         * nat/linux-ptrace.h: Fix common/ includes.
3842         * nat/linux-ptrace.c: Fix common/ includes.
3843         * nat/linux-procfs.c: Fix common/ includes.
3844         * nat/linux-personality.c: Fix common/ includes.
3845         * nat/linux-osdata.c: Fix common/ includes.
3846         * nat/linux-namespaces.c: Fix common/ includes.
3847         * nat/linux-btrace.h: Fix common/ includes.
3848         * nat/linux-btrace.c: Fix common/ includes.
3849         * nat/fork-inferior.c: Fix common/ includes.
3850         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3851         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3852         * nat/aarch64-linux.c: Fix common/ includes.
3853         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3854         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3855         * namespace.h: Fix common/ includes.
3856         * mips-linux-tdep.c: Fix common/ includes.
3857         * minsyms.c: Fix common/ includes.
3858         * mi/mi-parse.h: Fix common/ includes.
3859         * mi/mi-main.c: Fix common/ includes.
3860         * mi/mi-cmd-env.c: Fix common/ includes.
3861         * memrange.h: Fix common/ includes.
3862         * memattr.c: Fix common/ includes.
3863         * maint.h: Fix common/ includes.
3864         * maint.c: Fix common/ includes.
3865         * main.c: Fix common/ includes.
3866         * machoread.c: Fix common/ includes.
3867         * location.c: Fix common/ includes.
3868         * linux-thread-db.c: Fix common/ includes.
3869         * linux-nat.c: Fix common/ includes.
3870         * linux-fork.c: Fix common/ includes.
3871         * inline-frame.c: Fix common/ includes.
3872         * infrun.c: Fix common/ includes.
3873         * inflow.c: Fix common/ includes.
3874         * inferior.h: Fix common/ includes.
3875         * inferior.c: Fix common/ includes.
3876         * infcmd.c: Fix common/ includes.
3877         * inf-ptrace.c: Fix common/ includes.
3878         * inf-child.c: Fix common/ includes.
3879         * ia64-linux-nat.c: Fix common/ includes.
3880         * i387-tdep.c: Fix common/ includes.
3881         * i386-tdep.c: Fix common/ includes.
3882         * i386-linux-tdep.c: Fix common/ includes.
3883         * i386-linux-nat.c: Fix common/ includes.
3884         * i386-go32-tdep.c: Fix common/ includes.
3885         * i386-fbsd-tdep.c: Fix common/ includes.
3886         * i386-fbsd-nat.c: Fix common/ includes.
3887         * guile/scm-type.c: Fix common/ includes.
3888         * guile/guile.c: Fix common/ includes.
3889         * go32-nat.c: Fix common/ includes.
3890         * gnu-nat.c: Fix common/ includes.
3891         * gdbthread.h: Fix common/ includes.
3892         * gdbarch-selftests.c: Fix common/ includes.
3893         * gdb_usleep.c: Fix common/ includes.
3894         * gdb_select.h: Fix common/ includes.
3895         * gdb_bfd.c: Fix common/ includes.
3896         * gcore.c: Fix common/ includes.
3897         * fork-child.c: Fix common/ includes.
3898         * findvar.c: Fix common/ includes.
3899         * fbsd-nat.c: Fix common/ includes.
3900         * event-top.c: Fix common/ includes.
3901         * event-loop.c: Fix common/ includes.
3902         * dwarf2read.c: Fix common/ includes.
3903         * dwarf2loc.c: Fix common/ includes.
3904         * dwarf2-frame.c: Fix common/ includes.
3905         * dwarf-index-cache.c: Fix common/ includes.
3906         * dtrace-probe.c: Fix common/ includes.
3907         * disasm-selftests.c: Fix common/ includes.
3908         * defs.h: Fix common/ includes.
3909         * csky-tdep.c: Fix common/ includes.
3910         * cp-valprint.c: Fix common/ includes.
3911         * cp-support.h: Fix common/ includes.
3912         * cp-support.c: Fix common/ includes.
3913         * corelow.c: Fix common/ includes.
3914         * completer.h: Fix common/ includes.
3915         * completer.c: Fix common/ includes.
3916         * compile/compile.c: Fix common/ includes.
3917         * compile/compile-loc2c.c: Fix common/ includes.
3918         * compile/compile-cplus-types.c: Fix common/ includes.
3919         * compile/compile-cplus-symbols.c: Fix common/ includes.
3920         * command.h: Fix common/ includes.
3921         * cli/cli-dump.c: Fix common/ includes.
3922         * cli/cli-cmds.c: Fix common/ includes.
3923         * charset.c: Fix common/ includes.
3924         * build-id.c: Fix common/ includes.
3925         * btrace.h: Fix common/ includes.
3926         * btrace.c: Fix common/ includes.
3927         * breakpoint.h: Fix common/ includes.
3928         * breakpoint.c: Fix common/ includes.
3929         * ax.h: 
3930         (enum agent_op): Fix common/ includes.
3931         * ax-general.c (struct aop_map): Fix common/ includes.
3932         * ax-gdb.c: Fix common/ includes.
3933         * auxv.c: Fix common/ includes.
3934         * auto-load.c: Fix common/ includes.
3935         * arm-tdep.c: Fix common/ includes.
3936         * arch/riscv.c: Fix common/ includes.
3937         * arch/ppc-linux-common.c: Fix common/ includes.
3938         * arch/i386.c: Fix common/ includes.
3939         * arch/arm.c: Fix common/ includes.
3940         * arch/arm-linux.c: Fix common/ includes.
3941         * arch/arm-get-next-pcs.c: Fix common/ includes.
3942         * arch/amd64.c: Fix common/ includes.
3943         * arch/aarch64.c: Fix common/ includes.
3944         * arch/aarch64-insn.c: Fix common/ includes.
3945         * arch-utils.c: Fix common/ includes.
3946         * amd64-windows-tdep.c: Fix common/ includes.
3947         * amd64-tdep.c: Fix common/ includes.
3948         * amd64-sol2-tdep.c: Fix common/ includes.
3949         * amd64-obsd-tdep.c: Fix common/ includes.
3950         * amd64-nbsd-tdep.c: Fix common/ includes.
3951         * amd64-linux-tdep.c: Fix common/ includes.
3952         * amd64-linux-nat.c: Fix common/ includes.
3953         * amd64-fbsd-tdep.c: Fix common/ includes.
3954         * amd64-fbsd-nat.c: Fix common/ includes.
3955         * amd64-dicos-tdep.c: Fix common/ includes.
3956         * amd64-darwin-tdep.c: Fix common/ includes.
3957         * agent.c: Fix common/ includes.
3958         * ada-lang.h: Fix common/ includes.
3959         * ada-lang.c: Fix common/ includes.
3960         * aarch64-tdep.c: Fix common/ includes.
3961
3962 2019-01-25  Tom Tromey  <tom@tromey.com>
3963
3964         * common/create-version.sh: Use common/version.h.
3965
3966 2019-01-24  Pedro Alves  <palves@redhat.com>
3967
3968         * infrun.c (signal_stop, signal_print, signal_program)
3969         (signal_catch, signal_pass): Now arrays instead of pointers.
3970         (update_signals_program_target, do_target_resume)
3971         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3972         * linux-nat.c (linux_nat_target::pass_signals)
3973         (linux_nat_target::create_inferior, linux_nat_target::attach):
3974         Adjust.
3975         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3976         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3977         * procfs.c (procfs_target::pass_signals): Adjust.
3978         * record-full.c (record_full_target::resume): Adjust.
3979         * remote.c (remote_target::pass_signals)
3980         (remote_target::program_signals): Adjust.
3981         * target-debug.h (target_debug_print_signals): Now takes a
3982         gdb::array_view as parameter.  Adjust.
3983         * target.h (target_ops) <pass_signals, program_signals>: Replace
3984         pointer and length parameters with gdb::array_view.
3985         (target_pass_signals, target_program_signals): Likewise.
3986         * target-delegates.c: Regenerate.
3987
3988 2019-01-24  Pedro Alves  <palves@redhat.com>
3989
3990         * common/forward-scope-exit.h
3991         (forward_scope_exit::forward_scope_exit): Pass arguments to
3992         m_bind_function directly, instead of creating a std::bind and
3993         copying that.
3994
3995 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3996
3997         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3998         for static members.
3999         (pass_in_v_vfp_candidate): Likewise.
4000
4001 2019-01-23  Tom Tromey  <tom@tromey.com>
4002             Pedro Alves  <palves@redhat.com>
4003
4004         * regcache.c (class regcache_invalidator): Remove.
4005         (regcache::raw_write): Use make_scope_exit.
4006
4007 2019-01-23  Tom Tromey  <tom@tromey.com>
4008
4009         * ui-out.h (class ui_out_emit_type): Update comment.
4010
4011 2019-01-23  Tom Tromey  <tom@tromey.com>
4012
4013         * infrun.c (fetch_inferior_event): Update comment.
4014
4015 2019-01-23  Tom Tromey  <tom@tromey.com>
4016             Pedro Alves  <palves@redhat.com>
4017
4018         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4019         parameter.
4020         (fetch_inferior_event): Use SCOPE_EXIT.
4021
4022
4023 2019-01-23  Tom Tromey  <tom@tromey.com>
4024             Pedro Alves  <palves@redhat.com>
4025
4026         * infrun.c (disable_thread_events): Delete.
4027         (stop_all_threads): Use SCOPE_EXIT.
4028
4029 2019-01-23  Tom Tromey  <tom@tromey.com>
4030             Pedro Alves  <palves@redhat.com>
4031
4032         * symfile.c: Include forward-scope-exit.h.
4033         (clear_symtab_users_cleanup): Replace forward declaration with
4034         a FORWARD_SCOPE_EXIT.
4035         (syms_from_objfile_1): Use the forward_scope_exit and
4036         gdb::optional instead of cleanup_function.
4037         (reread_symbols): Use the forward_scope_exit instead of
4038         cleanup_function.
4039         (clear_symtab_users_cleanup): Remove function.
4040
4041 2019-01-23  Tom Tromey  <tom@tromey.com>
4042             Pedro Alves  <palves@redhat.com>
4043
4044         * linux-nat.c: Include scope-exit.h.
4045         (cleanup_target_stop): Remove.
4046         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4047         SCOPE_EXIT.
4048
4049 2019-01-23  Tom Tromey  <tom@tromey.com>
4050             Pedro Alves  <palves@redhat.com>
4051
4052         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4053         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4054
4055 2019-01-23  Tom Tromey  <tom@tromey.com>
4056             Andrew Burgess  <andrew.burgess@embecosm.com>
4057             Pedro Alves  <palves@redhat.com>
4058
4059         * infrun.c (fetch_inferior_event): Use scope_exit.
4060         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4061         * top.c (execute_command): Use scope_exit.
4062         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4063         * utils.c (do_bpstat_clear_actions_cleanup)
4064         (make_bpstat_clear_actions_cleanup): Remove.
4065
4066 2019-01-23  Tom Tromey  <tom@tromey.com>
4067             Pedro Alves  <palves@redhat.com>
4068
4069         * infrun.c: Include "common/scope-exit.h"
4070         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4071         (wait_for_inferior): Use SCOPE_EXIT.
4072         (fetch_inferior_event): Use scope_exit.
4073
4074 2019-01-23  Tom Tromey  <tom@tromey.com>
4075             Pedro Alves  <palves@redhat.com>
4076
4077         * breakpoint.c (create_breakpoint): Remove cleanup.
4078
4079 2019-01-23  Tom Tromey  <tom@tromey.com>
4080             Andrew Burgess  <andrew.burgess@embecosm.com>
4081             Pedro Alves  <palves@redhat.com>
4082
4083 2019-01-23  Pedro Alves  <palves@redhat.com>
4084
4085         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4086
4087 2019-01-23  Pedro Alves  <palves@redhat.com>
4088             Andrew Burgess  <andrew.burgess@embecosm.com>
4089
4090         * gdbthread.h: Include "common/forward-scope-exit.h".
4091         (scoped_finish_thread_state): Redefine custom class in terms of
4092         forward_scope_exit.
4093
4094 2019-01-23  Pedro Alves  <palves@redhat.com>
4095             Andrew Burgess  <andrew.burgess@embecosm.com>
4096
4097         * common/forward-scope-exit.h: New file.
4098
4099 2019-01-23  Pedro Alves  <palves@redhat.com>
4100             Andrew Burgess  <andrew.burgess@embecosm.com>
4101             Tom Tromey  <tom@tromey.com>
4102
4103         * common/scope-exit.h: New file.
4104
4105 2019-01-23  Pedro Alves  <palves@redhat.com>
4106
4107         * common/preprocessor.h (ESC): Rename to ...
4108         (ESC_PARENS): ... this.
4109         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4110         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4111
4112 2019-01-23  Tom Tromey  <tom@tromey.com>
4113
4114         * language.h (class scoped_switch_to_sym_language_if_auto):
4115         Initialize m_lang in both cases.
4116
4117 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4118
4119         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4120         with XCNEW.
4121
4122 2019-01-22  Tom Tromey  <tom@tromey.com>
4123
4124         * corelow.c: Do not include sys/file.h.
4125
4126 2019-01-22  Tom Tromey  <tom@tromey.com>
4127
4128         * tui/tui-wingeneral.h: Include gdb_curses.h.
4129
4130 2019-01-22  Tom Tromey  <tom@tromey.com>
4131
4132         * source-cache.h (class source_cache) <get_source_lines,
4133         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4134
4135 2019-01-22  Tom Tromey  <tom@tromey.com>
4136
4137         * remote-fileio.h (struct remote_target): Declare.
4138
4139 2019-01-22  Tom Tromey  <tom@tromey.com>
4140
4141         * python/py-arch.c: Do not include py-ref.h.
4142         * python/py-bpevent.c: Do not include py-ref.h.
4143         * python/py-cmd.c: Do not include py-ref.h.
4144         * python/py-continueevent.c: Do not include py-ref.h.
4145         * python/py-event.h: Do not include py-ref.h.
4146         * python/py-evtregistry.c: Do not include py-ref.h.
4147         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4148         * python/py-frame.c: Do not include py-ref.h.
4149         * python/py-framefilter.c: Do not include py-ref.h.
4150         * python/py-function.c: Do not include py-ref.h.
4151         * python/py-infevents.c: Do not include py-ref.h.
4152         * python/py-linetable.c: Do not include py-ref.h.
4153         * python/py-objfile.c: Do not include py-ref.h.
4154         * python/py-param.c: Do not include py-ref.h.
4155         * python/py-prettyprint.c: Do not include py-ref.h.
4156         * python/py-progspace.c: Do not include py-ref.h.
4157         * python/py-symbol.c: Do not include py-ref.h.
4158         * python/py-symtab.c: Do not include py-ref.h.
4159         * python/py-type.c: Do not include py-ref.h.
4160         * python/py-unwind.c: Do not include py-ref.h.
4161         * python/py-utils.c: Do not include py-ref.h.
4162         * python/py-value.c: Do not include py-ref.h.
4163         * python/py-varobj.c: Do not include py-ref.h.
4164         * python/py-xmethods.c: Do not include py-ref.h.
4165         * python/python.c: Do not include py-ref.h.
4166         * varobj.c: Do not include py-ref.h.
4167
4168 2019-01-22  Tom Tromey  <tom@tromey.com>
4169
4170         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4171         keyword for bcache.
4172
4173 2019-01-22  Tom Tromey  <tom@tromey.com>
4174
4175         * compile/compile-cplus-types.c: Remove a comment by #include.
4176
4177 2019-01-22  Tom Tromey  <tom@tromey.com>
4178
4179         * compile/gcc-c-plugin.h: Include compile-internal.h.
4180
4181 2019-01-22  Tom Tromey  <tom@tromey.com>
4182
4183         * stabsread.c (EXTERN): Do not define.
4184         (symnum, next_symbol_text_func, processing_gcc_compilation)
4185         (within_function, global_sym_chain, global_stabs)
4186         (previous_stab_code, this_object_header_files)
4187         (n_this_object_header_files)
4188         (n_allocated_this_object_header_files): Define.
4189         * stabsread.h (EXTERN): Never define.  Use "extern".
4190
4191 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4192
4193         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4194         history_value.
4195
4196 2019-01-21  Tom Tromey  <tom@tromey.com>
4197
4198         * ui-out.c: Fix includes.
4199         * tui/tui-source.c: Fix includes.
4200         * target.c: Fix includes.
4201         * remote.c: Fix includes.
4202         * regcache.c: Fix includes.
4203         * python/py-block.c: Fix includes.
4204         * printcmd.c: Fix includes.
4205         * or1k-tdep.c: Fix includes.
4206         * mi/mi-main.c: Fix includes.
4207         * m32r-tdep.c: Fix includes.
4208         * csky-tdep.c: Fix includes.
4209         * compile/compile-cplus-types.c: Fix includes.
4210         * cli/cli-interp.c: Fix includes.
4211
4212 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4213
4214         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4215         for padding.
4216
4217 2019-01-16  Tom Tromey  <tom@tromey.com>
4218
4219         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4220         earlier.
4221         (struct objfile) <msymbols_range>: Move from top level.
4222         <msymbols>: New method.
4223         (class objfile_msymbols): Remove.
4224         * symtab.c (default_collect_symbol_completion_matches_break_on):
4225         Update.
4226         * symmisc.c (dump_msymbols): Update.
4227         * stabsread.c (scan_file_globals): Update.
4228         * objc-lang.c (info_selectors_command, info_classes_command)
4229         (find_methods): Update.
4230         * minsyms.c (find_solib_trampoline_target): Update.
4231         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4232         * coffread.c (coff_symfile_read): Update.
4233         * ada-lang.c (ada_lookup_simple_minsym)
4234         (ada_collect_symbol_completion_matches): Update.
4235
4236 2019-01-16  Tom Tromey  <tom@tromey.com>
4237
4238         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4239         type.  Remove no-argument constructor.
4240         <iterator::operator++>: Simplify.
4241         <begin>: Update.
4242         <end>: Use minimal_symbol_count.
4243
4244 2019-01-16  Tom Tromey  <tom@tromey.com>
4245
4246         * objfiles.h (struct objfile) <psymtabs>: New method.
4247         (class objfile_psymtabs): Remove.
4248         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4249         typedef.
4250         <range>: New method.
4251         (require_partial_symbols): Change return type.
4252         * psymtab.c (require_partial_symbols)
4253         (psym_expand_symtabs_matching): Update.
4254         * mdebugread.c (parse_partial_symbols): Update.
4255         * dbxread.c (dbx_end_psymtab): Update.
4256
4257 2019-01-15  Tom Tromey  <tom@tromey.com>
4258
4259         * symtab.c (lookup_objfile_from_block)
4260         (lookup_symbol_in_objfile_symtabs)
4261         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4262         (find_line_symtab, info_sources_command)
4263         (default_collect_symbol_completion_matches_break_on)
4264         (make_source_files_completion_list): Update.
4265         * symmisc.c (print_objfile_statistics, dump_objfile)
4266         (maintenance_print_symbols, maintenance_info_symtabs)
4267         (maintenance_check_symtabs, maintenance_info_line_tables):
4268         Update.
4269         * source.c (select_source_symtab)
4270         (forget_cached_source_info_for_objfile): Update.
4271         * objfiles.h (class objfile_compunits): Remove.
4272         (struct objfile) <compunits_range>: New typedef.
4273         (compunits): New method.
4274         * objfiles.c (objfile_relocate1): Update.
4275         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4276         * maint.c (count_symtabs_and_blocks): Update.
4277         * linespec.c (iterate_over_all_matching_symtabs): Update.
4278         * cp-support.c (add_symbol_overload_list_qualified): Update.
4279         * coffread.c (coff_symtab_read): Update.
4280         * ada-lang.c (add_nonlocal_symbols)
4281         (ada_collect_symbol_completion_matches)
4282         (ada_add_global_exceptions): Update.
4283
4284 2019-01-15  Tom Tromey  <tom@tromey.com>
4285
4286         * progspace.h (program_space) <objfiles_safe_range>: New
4287         typedef.
4288         <objfiles_safe>: New method.
4289         * objfiles.h (class all_objfiles_safe): Remove.
4290         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4291         * jit.c (jit_inferior_exit_hook): Update.
4292
4293 2019-01-17  Tom Tromey  <tom@tromey.com>
4294
4295         * progspace.h (program_space) <objfiles_range>: New typedef.
4296         <objfiles>: New method.
4297         <objfiles_head>: Rename from objfiles.
4298         (object_files): Update.
4299         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4300         * guile/scm-pretty-print.c
4301         (ppscm_find_pretty_printer_from_objfiles): Update.
4302         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4303         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4304         Update.
4305         * python/py-progspace.c (pspy_get_objfiles): Update.
4306         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4307         Update.
4308         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4309         (objfpy_lookup_objfile_by_build_id): Update.
4310         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4311         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4312         Update.
4313         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4314         (expand_symtab_containing_pc, lookup_objfile_from_block)
4315         (lookup_static_symbol, basic_lookup_transparent_type)
4316         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4317         (find_line_symtab, info_sources_command)
4318         (default_collect_symbol_completion_matches_break_on)
4319         (make_source_files_completion_list, find_main_name): Update.
4320         * symmisc.c (print_symbol_bcache_statistics)
4321         (print_objfile_statistics, maintenance_print_symbols)
4322         (maintenance_print_msymbols, maintenance_print_objfiles)
4323         (maintenance_info_symtabs, maintenance_check_symtabs)
4324         (maintenance_expand_symtabs, maintenance_info_line_tables):
4325         Update.
4326         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4327         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4328         (map_overlay_command, unmap_overlay_command)
4329         (simple_overlay_update, expand_symtabs_matching)
4330         (map_symbol_filenames): Update.
4331         * symfile-debug.c (set_debug_symfile): Update.
4332         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4333         Update.
4334         * source.c (select_source_symtab, forget_cached_source_info):
4335         Update.
4336         * solib.c (solib_read_symbols): Update.
4337         * solib-spu.c (append_ocl_sos): Update.
4338         * psymtab.c (maintenance_print_psymbols)
4339         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4340         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4341         * printcmd.c (info_symbol_command): Update.
4342         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4343         Update.
4344         * objfiles.h (class all_objfiles): Remove.
4345         * objfiles.c (have_partial_symbols, have_full_symbols)
4346         (have_minimal_symbols, qsort_cmp, update_section_map)
4347         (shared_objfile_contains_address_p)
4348         (default_iterate_over_objfiles_in_search_order): Update.
4349         * objc-lang.c (info_selectors_command, info_classes_command)
4350         (find_methods): Update.
4351         * minsyms.c (find_solib_trampoline_target): Update.
4352         * maint.c (maintenance_info_sections)
4353         (maintenance_translate_address, count_symtabs_and_blocks):
4354         Update.
4355         * main.c (captured_main_1): Update.
4356         * linux-thread-db.c (try_thread_db_load_from_pdir)
4357         (has_libpthread): Update.
4358         * linespec.c (iterate_over_all_matching_symtabs)
4359         (search_minsyms_for_name): Update.
4360         * jit.c (jit_find_objf_with_entry_addr): Update.
4361         * hppa-tdep.c (find_unwind_entry)
4362         (hppa_lookup_stub_minimal_symbol): Update.
4363         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4364         Update.
4365         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4366         (elf_gnu_ifunc_resolve_by_got): Update.
4367         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4368         * dwarf-index-write.c (save_gdb_index_command): Update.
4369         * cp-support.c (add_symbol_overload_list_qualified): Update.
4370         * breakpoint.c (create_overlay_event_breakpoint)
4371         (create_longjmp_master_breakpoint)
4372         (create_std_terminate_master_breakpoint)
4373         (create_exception_master_breakpoint): Update.
4374         * blockframe.c (find_pc_partial_function): Update.
4375         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4376         (ada_collect_symbol_completion_matches)
4377         (ada_add_global_exceptions): Update.
4378
4379 2019-01-17  Tom Tromey  <tom@tromey.com>
4380
4381         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4382         declare VEC.
4383         (solib_target_parse_libraries): Change return type.
4384         (library_list_start_segment, library_list_start_section)
4385         (library_list_end_library, library_list_start_library); Update.
4386         (solib_target_free_library_list): Remove.
4387         (solib_target_parse_libraries): Remove cleanup.  Change return
4388         type.
4389         (solib_target_current_sos): Update.
4390
4391 2019-01-17  Tom Tromey  <tromey@bapiya>
4392
4393         * valprint.c: Replace "the the" with "the".
4394         * symtab.c: Replace "the the" with "the".
4395         * solib.c: Replace "the the" with "the".
4396         * solib-dsbt.c: Replace "the the" with "the".
4397         * linespec.c: Replace "the the" with "the".
4398         * dwarf2loc.h: Replace "the the" with "the".
4399         * amd64-windows-tdep.c: Replace "the the" with "the".
4400         * aarch64-tdep.c: Replace "the the" with "the".
4401
4402 2019-01-16  Keith Seitz  <keiths@redhat.com>
4403
4404         PR gdb/23773
4405         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4406         <builder>: Rename to ..
4407         <m_builder>: ... this and make private.
4408         (dwarf2_cu::get_builder): New method.  Change all users of
4409         `builder' to use this method.
4410         (dwarf2_start_symtab): Move to ...
4411         (dwarf2_cu::start_symtab): ... here.  Update all callers
4412         (setup_type_unit_groups): Move to ...
4413         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4414         callers.
4415         (dwarf2_cu::reset_builder): New method.
4416         (process_full_compunit, process_full_type_unit): Use
4417         dwarf2_cu::reset_builder.
4418         (follow_die_offset): Record the ancestor CU if it is different
4419         from the followed DIE's CU.
4420         (follow_die_sig_1): Likewise.
4421
4422 2019-01-15  Tom Tromey  <tom@tromey.com>
4423
4424         * remote.c (class remote_state) <buf>: Now a char_vector.
4425         <buf_size>: Remove.
4426         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4427         parameter.
4428         (remote_target::getpkt_or_notif_sane_1)
4429         (remote_target::getpkt_sane)
4430         (remote_target::getpkt_or_notif_sane): Likewise.
4431         (class remote_target) <putpkt>: New overload.
4432         (remote_target::read_frame): Change type of "buf_p".  Remove
4433         sizeof_p parameter.
4434         (packet_ok): New overload.
4435         (packet_check_result): New overload.
4436         Update all uses.
4437
4438 2019-01-14  Tom Tromey  <tom@tromey.com>
4439
4440         * remote-notif.c (handle_notification, remote_notif_ack)
4441         (remote_notif_parse): Make "buf" const.
4442         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4443         const.
4444         (remote_notif_parse, remote_notif_ack, handle_notification):
4445         Likewise.
4446         * remote.c (remote_notif_stop_parse): Make "buf" const.
4447         (remote_target::remote_parse_stop_reply): Make "buf" const.
4448         (remote_notif_stop_ack): Make "buf" const.
4449
4450 2019-01-14  Tom Tromey  <tom@tromey.com>
4451
4452         * remote.c (remote_console_output): Make parameter const.
4453
4454 2019-01-14  Tom Tromey  <tom@tromey.com>
4455
4456         * target-debug.h (target_debug_print_signals): Constify.
4457         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4458         * procfs.c (procfs_target::pass_signals): Update.
4459         * linux-nat.c (linux_nat_target::pass_signals): Update.
4460         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4461         * target-delegates.c: Rebuild.
4462         * remote.c (remote_target::program_signals): Update.
4463         (remote_target::pass_signals): Update.
4464         * target.c (target_pass_signals): Constify argument.
4465         (target_program_signals): Likewise.
4466         * target.h (struct target_ops) <pass_signals, program_signals>:
4467         Constify argument.
4468         (target_pass_signals, target_program_signals): Constify argument.
4469
4470 2019-01-14  Tom Tromey  <tom@tromey.com>
4471
4472         PR tui/28819:
4473         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4474
4475 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4476
4477         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4478         field.
4479         * rs6000-tdep.c: Include reggroups.h.
4480         (IS_V_ALIAS_PSEUDOREG): Define.
4481         (rs6000_register_name): Return names for the "vX" aliases.
4482         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4483         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4484         aliases.  Call default_register_reggroup_p for all other
4485         pseudo-registers.
4486         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4487         New functions.
4488         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4489         Handle "vX" aliases.
4490         (v_alias_pseudo_register_collect): New function.
4491         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4492         (rs6000_gdbarch_init): Initialize "vX" aliases as
4493         pseudo-registers.  Restore registration of
4494         rs6000_pseudo_register_reggroup_p with
4495         set_tdesc_pseudo_register_reggroup_p.
4496
4497 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4498
4499         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4500         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4501         set_gdbarch_num_pseudo_regs.
4502
4503 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4504
4505         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4506         Remove arg prefixname, add do_set and do_show.
4507         Add member functions set_list and show_list.
4508         * cli/cli-style.c (class cli_style_option): Update accordingly.
4509         (style_set_list): Move to file scope.
4510         (style_show_list): Likewise.
4511         (set_style): Call help_list.
4512         (show_style): Call cmd_show_list.
4513         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4514         Update to use the new macro.
4515
4516 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4517
4518         * ada-lang.c (_initialize_ada_language): Expand the help text
4519         for the "catch exception" command.
4520
4521 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4522
4523         * symtab.c (matching_obj_sections): Initialize obj,
4524         declare it closer to its usage.
4525
4526 2019-01-10  Tom Tromey  <tom@tromey.com>
4527
4528         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4529         (basic_inf_threads_range): Remove.
4530         (inf_threads_range, inf_non_exited_threads_range)
4531         (safe_inf_threads_range): Use next_adapter.
4532
4533 2019-01-10  Keith Seitz  <keiths@redhat.com>
4534
4535         PR gdb/23712
4536         PR symtab/23010
4537         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4538         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4539
4540 2019-01-10  Keith Seitz  <keiths@redhat.com>
4541
4542         PR gdb/23712
4543         PR symtab/23010
4544         * dictionary.c (pending_to_vector): Remove.
4545         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4546         Remove _1 suffix, replacing functions of the same name.  Update
4547         all callers.
4548         (dict_create_hashed, dict_create_hashed_expandable)
4549         (dict_create_linear, dict_create_linear_expandable, dict_free)
4550         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4551         Make functions static.
4552
4553 2019-01-10  Keith Seitz  <keiths@redhat.com>
4554
4555         PR gdb/23712
4556         PR symtab/23010
4557         * dictionary.h (struct dictionary): Replace declaration with
4558         multidictionary.
4559         (dict_create_hashed, dict_create_hashed_expandable)
4560         (dict_create_linear, dict_create_linear_expandable)
4561         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4562         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4563         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4564         taking multidictionary argument.
4565         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4566         * block.h (struct block) <dict>: Change to multidictionary
4567         and rename `multidict'.
4568         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4569         symmisc.c: Update all dictionary references to multidictionary.
4570
4571 2019-01-10  Keith Seitz  <keiths@redhat.com>
4572
4573         PR gdb/23712
4574         PR symtab/23010
4575         * dictionary.c: Include unordered_map.
4576         (pending_to_vector): New function.
4577         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4578         Rewrite the non-"_1" functions to take vector instead
4579         of linked list.
4580         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4581         "new" _1 versions of the same name.
4582         (multidictionary): Define.
4583         (std::hash<enum language): New definition.
4584         (collate_pending_symbols_by_language, mdict_create_hashed)
4585         (mdict_create_hashed_expandable, mdict_create_linear)
4586         (mdict_create_linear_expandable, mdict_free)
4587         (find_language_dictionary, create_new_language_dictionary)
4588         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4589         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4590         (mdict_size, mdict_empty): New functions.
4591         * dictionary.h (mdict_iterator): Define.
4592
4593 2019-01-10  Pedro Alves  <palves@redhat.com>
4594
4595         * breakpoint.c (read_uploaded_action)
4596         (create_tracepoint_from_upload): Adjust to use
4597         gdb::unique_xmalloc_ptr.
4598         * ctf.c (ctf_write_uploaded_tp):
4599         (SET_ARRAY_FIELD): Use emplace_back.
4600         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4601         * tracefile-tfile.c (tfile_write_uploaded_tp):
4602         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4603         gdb::unique_xmalloc_ptr.
4604         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4605         at_string, cond_string, cmd_strings>: Replace char pointers
4606         with gdb::unique_xmalloc_ptr.
4607
4608 2019-01-10  Pedro Alves  <palves@redhat.com>
4609
4610         * solib-target.c (library_list_start_library): Don't xstrdup name.
4611
4612 2019-01-10  Pedro Alves  <palves@redhat.com>
4613
4614         * mdebugread.c (parse_partial_symbols): Use
4615         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4616
4617 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * linux-fork.c (scoped_switch_fork_info)
4620         <~scoped_switch_fork_info>: Fix incorrect variable name.
4621
4622 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4623
4624         * linux-fork.c (scoped_switch_fork_info)
4625         <scoped_switch_fork_info>: Make explicit.
4626         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4627
4628 2019-01-10  Tom Tromey  <tom@tromey.com>
4629
4630         * objfiles.h (objfile::reset_psymtabs): Update.
4631         * objfiles.c (objfile::objfile): Update.
4632         * psymtab.h (psymtab_storage::obstack): Update.
4633         (psymtab_storage::m_obstack): Use gdb::optional.
4634         (class psymtab_storage): Update comment.  Remove objfile
4635         parameter.
4636         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4637
4638 2019-01-10  Tom Tromey  <tom@tromey.com>
4639
4640         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4641         <free_psymtabs>: Now private.
4642         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4643         (allocate_psymtab): Use new method.
4644
4645 2019-01-10  Tom Tromey  <tom@tromey.com>
4646
4647         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4648         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4649         * mdebugread.c (parse_partial_symbols): Use
4650         allocate_dependencies.
4651         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4652         allocate_dependencies.
4653         (process_psymtab_comp_unit_reader)
4654         (build_type_psymtab_dependencies): Likewise.
4655         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4656
4657 2019-01-10  Tom Tromey  <tom@tromey.com>
4658
4659         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4660         PSYMBOL_SET_LANGUAGE.
4661         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4662
4663 2019-01-10  Tom Tromey  <tom@tromey.com>
4664
4665         * psymtab.h (psymtab_storage::obstack): New method.
4666         <m_obstack>: Rename from obstack; now private.
4667         * psymtab.c (psymtab_storage): Update.
4668         * dwarf2read.c (create_addrmap_from_index)
4669         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4670         Update.
4671
4672 2019-01-10  Tom Tromey  <tom@tromey.com>
4673
4674         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4675         * objfiles.h (objfile::reset_psymtabs): New method.
4676
4677 2019-01-10  Tom Tromey  <tom@tromey.com>
4678
4679         * symmisc.c (print_symbol_bcache_statistics): Update.
4680         (print_objfile_statistics): Update.
4681         * symfile.c (reread_symbols): Update.
4682         * psymtab.h (class psymtab_storage): New.
4683         * psymtab.c (psymtab_storage): New constructor.
4684         (~psymtab_storage): New destructor.
4685         (require_partial_symbols): Update.
4686         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4687         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4688         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4689         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4690         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4691         (start_psymtab_common, end_psymtab_common)
4692         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4693         (allocate_psymtab): Update.
4694         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4695         Update.
4696         (dump_psymtab_addrmap, maintenance_print_psymbols)
4697         (maintenance_check_psymtabs): Update.
4698         (class objfile_psymtabs): Move to objfiles.h.
4699         * psympriv.h (discard_psymtab): Now inline.
4700         (psymtab_discarder::psymtab_discarder): Update.
4701         (psymtab_discarder::~psymtab_discarder): Update.
4702         (ALL_OBJFILE_PSYMTABS): Rewrite.
4703         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4704         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4705         Remove fields.
4706         <partial_symtabs>: New field.
4707         (class objfile_psymtabs): Move from psymtab.h.  Update.
4708         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4709         psymbol_cache.
4710         (objfile::~objfile): Don't destroy psymbol_cache.
4711         * mdebugread.c (parse_partial_symbols): Update.
4712         * dwarf2read.c (create_addrmap_from_index)
4713         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4714         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4715         (add_partial_subprogram, dwarf2_ranges_read): Update.
4716         * dwarf-index-write.c (write_address_map)
4717         (write_one_signatured_type, recursively_write_psymbols)
4718         (class debug_names, class debug_names, write_psymtabs_to_index):
4719         Update.
4720
4721 2019-01-10  Tom Tromey  <tom@tromey.com>
4722
4723         * symtab.h (SYMBOL_SET_NAMES): Update.
4724         (symbol_set_names): Update.
4725         (MSYMBOL_SET_NAMES): Update.
4726         * symtab.c (symbol_set_names): Change argument to be an
4727         objfile_per_bfd_storage.
4728         * psymtab.c (add_psymbol_to_bcache): Update.
4729         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4730
4731 2019-01-10  Tom Tromey  <tom@tromey.com>
4732
4733         * symtab.c (create_demangled_names_hash): Change argument to be an
4734         objfile_per_bfd_storage.
4735         (symbol_set_names): Update.
4736
4737 2019-01-10  Tom Tromey  <tom@tromey.com>
4738
4739         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4740         init_psymbol_list.
4741         * psymtab.c (init_psymbol_list): Do nothing if already called.
4742         * psympriv.h (init_psymbol_list): Add comment.
4743         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4744         init_psymbol_list.
4745         * dbxread.c (dbx_symfile_read): Unconditionally call
4746         init_psymbol_list.
4747
4748 2019-01-10  Tom Tromey  <tom@tromey.com>
4749
4750         * xcoffread.c (scan_xcoff_symtab): Update.
4751         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4752         "where".
4753         * mdebugread.c (parse_partial_symbols)
4754         (handle_psymbol_enumerators): Update.
4755         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4756         * dbxread.c (read_dbx_symtab): Update.
4757         * psympriv.h (psymbol_placement): New enum.
4758         (add_psymbol_to_list): Update.
4759
4760 2019-01-10  Tom Tromey  <tom@tromey.com>
4761
4762         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4763         static_psymbols parameters.
4764         (scan_xcoff_symtab): Update.
4765         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4766         static_psymbols parameters.
4767         * psympriv.h (start_psymtab_common): Update.
4768         * mdebugread.c (parse_partial_symbols): Update.
4769         * dwarf2read.c (create_partial_symtab): Update.
4770         * dbxread.c (read_dbx_symtab): Update.
4771         (start_psymtab): Remove global_psymbols and static_psymbols
4772         parameters.
4773
4774 2019-01-10  Tom Tromey  <tom@tromey.com>
4775
4776         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4777         * psymtab.c (allocate_psymtab): Add comment.
4778         * psympriv.h (allocate_psymtab): Add comment.
4779         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4780         initializations.
4781         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4782
4783 2019-01-10  Tom Tromey  <tom@tromey.com>
4784
4785         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4786         Don't declare.
4787         * mipsread.c: Include mdebugread.h.
4788         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4789         Declare.
4790         * elfread.c: Include mdebugread.h.
4791
4792 2019-01-09  Tom Tromey  <tom@tromey.com>
4793
4794         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4795         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4796         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4797         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4798         (psym_lookup_symbol, psym_find_last_source_symtab)
4799         (psym_forget_cached_source_info, psym_print_stats)
4800         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4801         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4802         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4803         (psym_find_compunit_symtab_by_address)
4804         (maintenance_print_psymbols, maintenance_info_psymtabs)
4805         (maintenance_check_psymtabs): Use ranged for.
4806         * psymtab.h (class objfile_psymtabs): New.
4807         (require_partial_symbols): Return objfile_psymtabs.
4808         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4809
4810 2019-01-09  Tom Tromey  <tom@tromey.com>
4811
4812         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4813         (find_pc_mapped_section, list_overlays_command)
4814         (map_overlay_command, unmap_overlay_command)
4815         (simple_overlay_update): Use all_objfiles.
4816         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4817         * printcmd.c (info_symbol_command): Use all_objfiles.
4818         * objfiles.h (ALL_OBJSECTIONS): Remove.
4819         * maint.c (maintenance_translate_address): Use all_objfiles.
4820         * gcore.c (gcore_create_callback): Use all_objfiles.
4821         (objfile_find_memory_regions): Likewise.
4822
4823 2019-01-09  Tom Tromey  <tom@tromey.com>
4824
4825         * symtab.c (find_line_symtab, info_sources_command)
4826         (make_source_files_completion_list): Use objfile_compunits.
4827         * source.c (select_source_symtab): Use objfile_compunits.
4828         * objfiles.h (struct objfile): Update comment.
4829         (ALL_OBJFILES): Remove.
4830         (ALL_FILETABS): Remove.
4831         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4832         objfile_compunits.
4833
4834 2019-01-09  Tom Tromey  <tom@tromey.com>
4835
4836         * symmisc.c (print_objfile_statistics, dump_objfile)
4837         (maintenance_print_symbols): Use compunit_filetabs.
4838         * source.c (forget_cached_source_info_for_objfile): Use
4839         compunit_filetabs.
4840         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4841         (ALL_FILETABS): Use compunit_filetabs.
4842         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4843         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4844
4845 2019-01-09  Tom Tromey  <tom@tromey.com>
4846
4847         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4848         (compunit_filetabs): New.
4849         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4850         compunit_filetabs.
4851         (info_sources_command, make_source_files_completion_list): Remove
4852         declaration.
4853         * symmisc.c (print_objfile_statistics, dump_objfile)
4854         (maintenance_print_symbols): Remove declaration.
4855         (maintenance_info_symtabs): Use compunit_filetabs.
4856         (maintenance_info_line_tables): Likewise.
4857         * source.c (select_source_symtab): Change local variable name.
4858         (forget_cached_source_info_for_objfile): Remove declaration.
4859         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4860         * objfiles.c (objfile_relocate1): Remove declaration.
4861         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4862         declaration.
4863         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4864         * coffread.c (coff_symtab_read): Remove declaration.
4865         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4866         compunit_filetabs.
4867
4868 2019-01-09  Tom Tromey  <tom@tromey.com>
4869
4870         * symtab.c (lookup_objfile_from_block)
4871         (find_pc_sect_compunit_symtab, search_symbols)
4872         (default_collect_symbol_completion_matches_break_on): Use
4873         objfile_compunits.
4874         * objfiles.h (ALL_COMPUNITS): Remove.
4875         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4876         * cp-support.c (add_symbol_overload_list_qualified): Use
4877         objfile_compunits.
4878         * ada-lang.c (ada_collect_symbol_completion_matches)
4879         (ada_add_global_exceptions): Use objfile_compunits.
4880
4881 2019-01-09  Tom Tromey  <tom@tromey.com>
4882
4883         * source.c (select_source_symtab)
4884         (forget_cached_source_info_for_objfile): Remove declaration.
4885         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4886         declaration.
4887         * maint.c (count_symtabs_and_blocks): Remove declaration.
4888         * cp-support.c (add_symbol_overload_list_qualified): Remove
4889         declaration.
4890         * coffread.c (coff_symtab_read): Remove declaration.
4891         * symtab.c (lookup_symbol_in_objfile_symtabs)
4892         (basic_lookup_transparent_type_1): Use objfile_compunits.
4893         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4894         (info_sources_command, search_symbols)
4895         (default_collect_symbol_completion_matches_break_on)
4896         (make_source_files_completion_list): Remove declaration.
4897         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4898         (ada_collect_symbol_completion_matches)
4899         (ada_add_global_exceptions): Remove declaration.
4900         * linespec.c (iterate_over_all_matching_symtabs): Use
4901         objfile_compunits.
4902         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4903         (class objfile_compunits): New.
4904         (ALL_COMPUNITS): Use objfile_compunits.
4905         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4906         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4907         objfile_compunits.
4908         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4909
4910 2019-01-09  Tom Tromey  <tom@tromey.com>
4911
4912         * symtab.c (search_symbols)
4913         (default_collect_symbol_completion_matches_break_on): Use
4914         objfile_msymbols.
4915         * ada-lang.c (ada_lookup_simple_minsym)
4916         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4917         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4918         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4919         objfile_msymbols.
4920         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4921         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4922         * objc-lang.c (find_methods): Use objfile_msymbols.
4923         (info_selectors_command, info_classes_command): Likewise.
4924         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4925         * objfiles.h (class objfile_msymbols): New.
4926         (ALL_OBJFILE_MSYMBOLS): Remove.
4927         (ALL_MSYMBOLS): Remove.
4928
4929 2019-01-09  Tom Tromey  <tom@tromey.com>
4930
4931         * common/next-iterator.h (next_adapter): Add Iterator template
4932         parameter.
4933         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4934         (class all_objfiles_safe): New.
4935         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4936         * objfiles.c (put_objfile_before): Update comment.
4937         (add_separate_debug_objfile): Likewise.
4938         (free_all_objfiles): Use all_objfiles_safe.
4939         (objfile_purge_solibs): Likewise.
4940
4941 2019-01-09  Tom Tromey  <tom@tromey.com>
4942
4943         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4944         (expand_symtab_containing_pc, lookup_static_symbol)
4945         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4946         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4947         all_objfiles.
4948         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4949         * breakpoint.c (create_overlay_event_breakpoint)
4950         (create_longjmp_master_breakpoint)
4951         (create_std_terminate_master_breakpoint)
4952         (create_exception_master_breakpoint): Use all_objfiles.
4953         * linux-thread-db.c (try_thread_db_load_from_pdir)
4954         (has_libpthread): Use all_objfiles.
4955         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4956         * linespec.c (iterate_over_all_matching_symtabs)
4957         (search_minsyms_for_name): Use all_objfiles.
4958         * maint.c (maintenance_info_sections): Use all_objfiles.
4959         * main.c (captured_main_1): Use all_objfiles.
4960         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4961         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4962         * guile/scm-pretty-print.c
4963         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4964         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4965         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4966         (maintenance_print_msymbols): Use all_objfiles.
4967         * source.c (select_source_symtab): Use all_objfiles.
4968         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4969         * symfile.c (remove_symbol_file_command)
4970         (expand_symtabs_matching, map_symbol_filenames): Use
4971         all_objfiles.
4972         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4973         all_objfiles.
4974         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4975         * objc-lang.c (find_methods): Use all_objfiles.
4976         * objfiles.c (have_partial_symbols, have_full_symbols)
4977         (have_minimal_symbols, qsort_cmp)
4978         (default_iterate_over_objfiles_in_search_order): Use
4979         all_objfiles.
4980         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4981         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4982         (maintenance_check_psymtabs): Use all_objfiles.
4983         (ALL_PSYMTABS): Remove.
4984         * compile/compile-object-run.c (do_module_cleanup): Use
4985         all_objfiles.
4986         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4987         * cp-support.c (add_symbol_overload_list_qualified): Use
4988         all_objfiles.
4989         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4990         Use all_objfiles.
4991         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4992         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4993         all_objfiles.
4994         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4995         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4996         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4997         Uses all_objfiles.
4998         * solib.c (solib_read_symbols): Use all_objfiles
4999
5000 2019-01-09  Tom Tromey  <tom@tromey.com>
5001
5002         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5003         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5004         all_objfiles.
5005         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5006         * symmisc.c (print_symbol_bcache_statistics)
5007         (print_objfile_statistics, maintenance_print_objfiles)
5008         (maintenance_info_symtabs, maintenance_check_symtabs)
5009         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5010         all_objfiles.
5011         * source.c (forget_cached_source_info): Use all_objfiles.
5012         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5013         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5014         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5015         * objfiles.c (update_section_map): Use all_objfiles.
5016         (shared_objfile_contains_address_p): Likewise.
5017         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5018         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5019
5020 2019-01-09  Tom Tromey  <tom@tromey.com>
5021
5022         * common/next-iterator.h: New file.
5023         * objfiles.h (class all_objfiles): New.
5024         (struct objfile_iterator): New.
5025
5026 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5027
5028         * NEWS: Move the description of the changed "frame", "select-frame",
5029          and "info frame" commands to the Changed commands section.
5030
5031 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5032
5033         * gdbtypes.c (check_stub_method_group): Remove handling of old
5034         mangling schemes.
5035         * linespec.c (find_methods): Likewise.
5036         * stabsread.c (read_member_functions): Likewise.
5037         * valops.c (search_struct_method): Likewise.
5038         (value_struct_elt_for_reference): Likewise.
5039         * NEWS: Mention this change.
5040
5041 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5044         print_source_lines.
5045         * source.c (print_source_lines_base): Update line number check.
5046         (print_source_lines): New function.
5047         (source_lines_range::source_lines_range): New function.
5048         * source.h (class source_lines_range): New class.
5049         (print_source_lines): New declaration.
5050
5051 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5052
5053         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5054
5055 2019-01-08  Tom Tromey  <tom@tromey.com>
5056             Simon Marchi  <simon.marchi@ericsson.com>
5057
5058         PR gdb/24060
5059         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5060         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5061         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5062         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5063         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5064         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5065
5066 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5067
5068         * source.c (select_source_symtab): Move header comment to
5069         declaration in source.h.
5070         (forget_cached_source_info_for_objfile): Likewise.
5071         (forget_cached_source_info): Likewise.
5072         (identify_source_line): Likewise.
5073         * source.h (identify_source_line): Move declaration from symtab.h
5074         and add comment from source.c
5075         (print_source_lines): Likewise.
5076         (forget_cached_source_info_for_objfile): Likewise.
5077         (forget_cached_source_info): Likewise.
5078         (select_source_symtab): Likewise.
5079         (enum print_source_lines_flag): Move definition from symtab.h.
5080         * symtab.h (identify_source_line): Move declaration to source.h.
5081         (print_source_lines): Likewise.
5082         (forget_cached_source_info_for_objfile): Likewise.
5083         (forget_cached_source_info): Likewise.
5084         (select_source_symtab): Likewise.
5085         (enum print_source_lines_flag): Move definition to source.h.
5086         * tui/tui-hooks.c: Add 'source.h' include.
5087
5088 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         * source.c (print_source_lines_base): Handle requests to print
5091         reverse line number sequences, and guard against empty lines
5092         string.
5093
5094 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5095
5096         * source.c (print_source_lines_base): Fix skip of '\r' if next
5097         character is '\n'.
5098
5099 2019-01-06  Tom Tromey  <tom@tromey.com>
5100
5101         * c-exp.y (struct c_parse_state) <macro_original_text,
5102         expansion_obstack>: New member.
5103         (macro_original_text, expansion_obstack): Remove globals.
5104         (scan_macro_expansion, scanning_macro_expansion)
5105         (finished_macro_expansion): Update.
5106         (scan_macro_cleanup): Remove.
5107         (yylex, c_parse): Update.
5108
5109 2019-01-06  Tom Tromey  <tom@tromey.com>
5110
5111         * c-exp.y (struct c_parse_state) <strings>: New member.
5112         (operator_stoken): Update.
5113
5114 2019-01-06  Tom Tromey  <tom@tromey.com>
5115
5116         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5117         (union type_stack_elt) <typelist_val>: Now a pointer to
5118         std::vector.
5119         (type_stack_cleanup): Don't declare.
5120         (push_typelist): Update.
5121         * parse.c (pop_typelist): Return a std::vector.
5122         (push_typelist): Take a std::vector.
5123         (follow_types): Update.  Do not free args.
5124         (type_stack_cleanup): Remove.
5125         * c-exp.y (struct c_parse_state): New.
5126         (cpstate): New global.
5127         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5128         (nonempty_typelist): Update.
5129         (func_mod): Create a new vector.
5130         (c_parse): Create a c_parse_state.
5131         (check_parameter_typelist): Do not delete params.
5132         (function_method): Update.  Do not delete type_list.
5133
5134 2019-01-06  Tom Tromey  <tom@tromey.com>
5135
5136         PR gdb/28155:
5137         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5138         check_typedef.
5139         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5140         (print_return_value): Likewise.
5141
5142 2019-01-05  Tom Tromey  <tom@tromey.com>
5143
5144         * contrib/cleanup_check.py: Remove.
5145         * contrib/gcc-with-excheck: Remove.
5146         * contrib/exsummary.py: Remove.
5147         * contrib/excheck.py: Remove.
5148
5149 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5150
5151         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5152         NULL. Initialize tpprev to NULL instead of assigning it
5153         to NULL on the next statement.
5154         * windows-nat.c (windows_delete_thread): Remove check for
5155         main_thread_id before printing thread exit notifications.
5156         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5157         Remove thread ID check against main_thread_id.
5158         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5159         windows_delete_thread.
5160         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5161
5162 2019-01-04  Tom Tromey  <tom@tromey.com>
5163
5164         * compile/compile.c (_initialize_compile): Use upper case for
5165         metasyntactic variables.
5166         * symmisc.c (_initialize_symmisc): Use upper case for
5167         metasyntactic variables.
5168         * psymtab.c (_initialize_psymtab): Use upper case for
5169         metasyntactic variables.
5170         * demangle.c (demangle_command): Use upper case for metasyntactic
5171         variables.
5172         (_initialize_demangler): Likewise.
5173         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5174         variables.
5175
5176 2019-01-03  Tom Tromey  <tom@tromey.com>
5177
5178         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5179
5180 2019-01-03  Tom Tromey  <tom@tromey.com>
5181
5182         * python/py-symtab.c (salpy_str): Update.
5183         (struct salpy_sal_object) <symtab>: Now a PyObject.
5184         (salpy_dealloc): Update.
5185         (del_objfile_sal): Use gdbpy_ref.
5186
5187 2019-01-03  Tom Tromey  <tom@tromey.com>
5188
5189         * python/py-type.c (convert_field): Use new_reference.  Return
5190         gdbpy_ref.
5191         (make_fielditem): Return gdbpy_ref.
5192         (typy_fields): Update.
5193         (typy_getitem): Update.
5194         (field_name): Return gdbpy_ref.  Use new_reference.
5195         (typy_iterator_iternext): Update.
5196
5197 2019-01-03  Tom Tromey  <tom@tromey.com>
5198
5199         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5200
5201 2019-01-03  Tom Tromey  <tom@tromey.com>
5202
5203         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5204         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5205         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5206         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5207         (pspy_set_type_printers): Likewise.
5208         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5209         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5210         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5211         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5212         (objfpy_set_type_printers): Likewise.
5213
5214 2019-01-03  Tom Tromey  <tom@tromey.com>
5215
5216         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5217         (gdbpy_print_stack): Use gdbpy_err_fetch.
5218         * python/python-internal.h (class gdbpy_err_fetch): New class.
5219         (class gdbpy_enter) <m_error_type, m_error_value,
5220         m_error_traceback>: Remove.
5221         <m_error>: New member.
5222         (gdbpy_exception_to_string): Don't declare.
5223         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5224         * python/py-value.c (convert_value_from_python): Use
5225         gdbpy_err_fetch.
5226         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5227         gdbpy_exception_to_string.
5228         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5229         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5230         gdbpy_err_fetch.
5231
5232 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5233
5234         * linux-nat.c (delete_lwp_cleanup): Delete.
5235         (struct lwp_deleter): New struct.
5236         (lwp_info_up): New typedef.
5237         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5238         lwp_info_up.
5239
5240 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5241
5242         * linux-fork.c (class scoped_switch_fork_info): New class.
5243         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5244
5245 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5246
5247         * valops.c (find_overload_match): Remove use of null_cleanup, and
5248         calls to do_cleanups.
5249
5250 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5251
5252         * compile/compile-cplus-types.c
5253         (compile_cplus_instance::decl_name): Handle changes to
5254         cp_func_name.
5255         * cp-support.c (cp_func_name): Update header comment, update
5256         return type.
5257         * cp-support.h (cp_func_name): Update return type in declaration.
5258         * valops.c (find_overload_match): Move temp_func local to top
5259         level of function and change its type.  Use temp_func to hold and
5260         delete temporary string obtained from cp_func_name.
5261
5262 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5263
5264         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5265         gdb::char_vector, remove cleanup, and update uses of `msg`.
5266
5267 2019-01-03  Jim Wilson  <jimw@sifive.com>
5268
5269         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5270
5271 2019-01-02  Tom Tromey  <tom@tromey.com>
5272
5273         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5274         (tdesc_parse_xml): Remove cleanups.
5275         * target-descriptions.h (make_cleanup_free_target_description):
5276         Don't declare.
5277         (target_desc_deleter): New struct.
5278         (target_desc_up): New typedef.
5279         * target-descriptions.c (target_desc_deleter::operator()): Rename
5280         from free_target_description.
5281         (make_cleanup_free_target_description): Remove.
5282
5283 2019-01-02  Tom Tromey  <tom@tromey.com>
5284
5285         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5286         constructor, destructor.
5287         (linespec_parser): Remove typedef.
5288         (~linespec_parser): Rename from linespec_parser_delete.
5289         (linespec_lex_to_end, linespec_complete_label)
5290         (linespec_complete): Update.
5291         (decode_line_full): Remove cleanups.
5292         (decode_line_1): Update.
5293
5294 2019-01-02  Tom Tromey  <tom@tromey.com>
5295
5296         * python/python-internal.h (inferior_to_inferior_object): Change
5297         return type.
5298         * python/py-exitedevent.c (create_exited_event_object): Update.
5299         * python/py-inferior.c (inferior_to_inferior_object): Return
5300         gdbpy_ref.
5301         (python_new_inferior, python_inferior_deleted)
5302         (thread_to_thread_object, delete_thread_object)
5303         (build_inferior_list, gdbpy_selected_inferior): Update.
5304         * python/py-infthread.c (create_thread_object): Update.  Also fail
5305         if inferior_to_inferior_object fails.
5306
5307 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5308
5309         * inferior.h (class inferior) <displaced_step_state>: New field.
5310         * infrun.h (struct displaced_step_state): Move here from
5311         infrun.c.  Initialize fields, add constructor.
5312         <inf>: Remove field.
5313         <reset>: New method.
5314         * infrun.c (struct displaced_step_inferior_state): Move to
5315         infrun.h.
5316         (displaced_step_inferior_states): Remove.
5317         (get_displaced_stepping_state): Adust.
5318         (displaced_step_in_progress_any_inferior): Adjust.
5319         (displaced_step_in_progress_thread): Adjust.
5320         (displaced_step_in_progress): Adjust.
5321         (add_displaced_stepping_state): Remove.
5322         (get_displaced_step_closure_by_addr): Adjust.
5323         (remove_displaced_stepping_state): Remove.
5324         (infrun_inferior_exit): Call displaced_step_state.reset.
5325         (use_displaced_stepping): Don't check for NULL.
5326         (displaced_step_prepare_throw): Call
5327         get_displaced_stepping_state.
5328         (displaced_step_fixup): Don't check for NULL.
5329         (prepare_for_detach): Don't check for NULL.
5330
5331 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5332
5333         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5334          in case of call that did not complete.
5335
5336 2019-01-02  Andrey Utkin  <autkin@undo.io>
5337
5338         * symfile.c (find_separate_debug_file): Fix search of debug files for
5339         remote debuggee.
5340
5341 2019-01-02  Tom Tromey  <tom@tromey.com>
5342
5343         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5344         indentation.
5345         * python/py-frame.c (frapy_older): Remove cast.
5346         (frapy_newer): Likewise.
5347         * python/py-breakpoint.c (local_setattro): Remove cast.
5348         * python/py-arch.c (archpy_name): Remove local variable.
5349         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5350
5351 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5352
5353         * unittests/basic_string_view/element_access/char/empty.cc:
5354         Fix year range in copyright header.
5355
5356 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5359         Delete.
5360         <operator==>: Update with for removed field.
5361         <hash>: Likewise.
5362         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5363         <isa_features>: ...this.
5364         <abi_features>: New field.
5365         (riscv_isa_flen): Update comment.
5366         (riscv_abi_xlen): New declaration.
5367         (riscv_abi_flen): New declaration.
5368         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5369         isa_features.
5370         (riscv_abi_xlen): New function.
5371         (riscv_isa_flen): Update to get answer from isa_features.
5372         (riscv_abi_flen): New function.
5373         (riscv_has_fp_abi): Update to get answer from abi_features.
5374         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5375         xlen and flen.
5376         (riscv_call_info) <xlen, flen>: Update comment.
5377         (riscv_call_arg_struct): Remove invalid assertions
5378         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5379         is removed.
5380         (riscv_gdbarch_init): Gather isa features and abi features
5381         separately, ensure both match on the gdbarch when reusing an old
5382         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5383         a target with 64-bit float hardware.
5384
5385 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5386
5387         * source.c (search_command_helper): Stop reverse search
5388         when line 1 has been searched.
5389
5390 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5391
5392         * record-full.c (record_full_base_target::close): Rewrite
5393         record_full_core_buf_list free logic.
5394
5395 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5396
5397         * break-catch-syscall.c (print_one_catch_syscall): xfree
5398         the last text.
5399
5400 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5401
5402         * top.c (print_gdb_version): Update Copyright year in version
5403         message.
5404
5405 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5406
5407         Update copyright year range in all GDB files.
5408
5409 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5410
5411         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5412
5413 For older changes see ChangeLog-2018.
5414 \f
5415 Local Variables:
5416 mode: change-log
5417 left-margin: 8
5418 fill-column: 74
5419 version-control: never
5420 coding: utf-8
5421 End:
5422