gdb/ChangeLog

   1 2019-01-16  Tom Tromey  <tom@tromey.com>
   2
   3         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
   4         earlier.
   5         (struct objfile) <msymbols_range>: Move from top level.
   6         <msymbols>: New method.
   7         (class objfile_msymbols): Remove.
   8         * symtab.c (default_collect_symbol_completion_matches_break_on):
   9         Update.
  10         * symmisc.c (dump_msymbols): Update.
  11         * stabsread.c (scan_file_globals): Update.
  12         * objc-lang.c (info_selectors_command, info_classes_command)
  13         (find_methods): Update.
  14         * minsyms.c (find_solib_trampoline_target): Update.
  15         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
  16         * coffread.c (coff_symfile_read): Update.
  17         * ada-lang.c (ada_lookup_simple_minsym)
  18         (ada_collect_symbol_completion_matches): Update.
  19
  20 2019-01-16  Tom Tromey  <tom@tromey.com>
  21
  22         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
  23         type.  Remove no-argument constructor.
  24         <iterator::operator++>: Simplify.
  25         <begin>: Update.
  26         <end>: Use minimal_symbol_count.
  27
  28 2019-01-16  Tom Tromey  <tom@tromey.com>
  29
  30         * objfiles.h (struct objfile) <psymtabs>: New method.
  31         (class objfile_psymtabs): Remove.
  32         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
  33         typedef.
  34         <range>: New method.
  35         (require_partial_symbols): Change return type.
  36         * psymtab.c (require_partial_symbols)
  37         (psym_expand_symtabs_matching): Update.
  38         * mdebugread.c (parse_partial_symbols): Update.
  39         * dbxread.c (dbx_end_psymtab): Update.
  40
  41 2019-01-15  Tom Tromey  <tom@tromey.com>
  42
  43         * symtab.c (lookup_objfile_from_block)
  44         (lookup_symbol_in_objfile_symtabs)
  45         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
  46         (find_line_symtab, info_sources_command)
  47         (default_collect_symbol_completion_matches_break_on)
  48         (make_source_files_completion_list): Update.
  49         * symmisc.c (print_objfile_statistics, dump_objfile)
  50         (maintenance_print_symbols, maintenance_info_symtabs)
  51         (maintenance_check_symtabs, maintenance_info_line_tables):
  52         Update.
  53         * source.c (select_source_symtab)
  54         (forget_cached_source_info_for_objfile): Update.
  55         * objfiles.h (class objfile_compunits): Remove.
  56         (struct objfile) <compunits_range>: New typedef.
  57         (compunits): New method.
  58         * objfiles.c (objfile_relocate1): Update.
  59         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  60         * maint.c (count_symtabs_and_blocks): Update.
  61         * linespec.c (iterate_over_all_matching_symtabs): Update.
  62         * cp-support.c (add_symbol_overload_list_qualified): Update.
  63         * coffread.c (coff_symtab_read): Update.
  64         * ada-lang.c (add_nonlocal_symbols)
  65         (ada_collect_symbol_completion_matches)
  66         (ada_add_global_exceptions): Update.
  67
  68 2019-01-15  Tom Tromey  <tom@tromey.com>
  69
  70         * progspace.h (program_space) <objfiles_safe_range>: New
  71         typedef.
  72         <objfiles_safe>: New method.
  73         * objfiles.h (class all_objfiles_safe): Remove.
  74         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
  75         * jit.c (jit_inferior_exit_hook): Update.
  76
  77 2019-01-17  Tom Tromey  <tom@tromey.com>
  78
  79         * progspace.h (program_space) <objfiles_range>: New typedef.
  80         <objfiles>: New method.
  81         <objfiles_head>: Rename from objfiles.
  82         (object_files): Update.
  83         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
  84         * guile/scm-pretty-print.c
  85         (ppscm_find_pretty_printer_from_objfiles): Update.
  86         * guile/scm-objfile.c (gdbscm_objfiles): Update.
  87         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
  88         Update.
  89         * python/py-progspace.c (pspy_get_objfiles): Update.
  90         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
  91         Update.
  92         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
  93         (objfpy_lookup_objfile_by_build_id): Update.
  94         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  95         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
  96         Update.
  97         * symtab.c (iterate_over_symtabs, matching_obj_sections)
  98         (expand_symtab_containing_pc, lookup_objfile_from_block)
  99         (lookup_static_symbol, basic_lookup_transparent_type)
 100         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 101         (find_line_symtab, info_sources_command)
 102         (default_collect_symbol_completion_matches_break_on)
 103         (make_source_files_completion_list, find_main_name): Update.
 104         * symmisc.c (print_symbol_bcache_statistics)
 105         (print_objfile_statistics, maintenance_print_symbols)
 106         (maintenance_print_msymbols, maintenance_print_objfiles)
 107         (maintenance_info_symtabs, maintenance_check_symtabs)
 108         (maintenance_expand_symtabs, maintenance_info_line_tables):
 109         Update.
 110         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 111         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 112         (map_overlay_command, unmap_overlay_command)
 113         (simple_overlay_update, expand_symtabs_matching)
 114         (map_symbol_filenames): Update.
 115         * symfile-debug.c (set_debug_symfile): Update.
 116         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 117         Update.
 118         * source.c (select_source_symtab, forget_cached_source_info):
 119         Update.
 120         * solib.c (solib_read_symbols): Update.
 121         * solib-spu.c (append_ocl_sos): Update.
 122         * psymtab.c (maintenance_print_psymbols)
 123         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 124         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 125         * printcmd.c (info_symbol_command): Update.
 126         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 127         Update.
 128         * objfiles.h (class all_objfiles): Remove.
 129         * objfiles.c (have_partial_symbols, have_full_symbols)
 130         (have_minimal_symbols, qsort_cmp, update_section_map)
 131         (shared_objfile_contains_address_p)
 132         (default_iterate_over_objfiles_in_search_order): Update.
 133         * objc-lang.c (info_selectors_command, info_classes_command)
 134         (find_methods): Update.
 135         * minsyms.c (find_solib_trampoline_target): Update.
 136         * maint.c (maintenance_info_sections)
 137         (maintenance_translate_address, count_symtabs_and_blocks):
 138         Update.
 139         * main.c (captured_main_1): Update.
 140         * linux-thread-db.c (try_thread_db_load_from_pdir)
 141         (has_libpthread): Update.
 142         * linespec.c (iterate_over_all_matching_symtabs)
 143         (search_minsyms_for_name): Update.
 144         * jit.c (jit_find_objf_with_entry_addr): Update.
 145         * hppa-tdep.c (find_unwind_entry)
 146         (hppa_lookup_stub_minimal_symbol): Update.
 147         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 148         Update.
 149         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 150         (elf_gnu_ifunc_resolve_by_got): Update.
 151         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 152         * dwarf-index-write.c (save_gdb_index_command): Update.
 153         * cp-support.c (add_symbol_overload_list_qualified): Update.
 154         * breakpoint.c (create_overlay_event_breakpoint)
 155         (create_longjmp_master_breakpoint)
 156         (create_std_terminate_master_breakpoint)
 157         (create_exception_master_breakpoint): Update.
 158         * blockframe.c (find_pc_partial_function): Update.
 159         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 160         (ada_collect_symbol_completion_matches)
 161         (ada_add_global_exceptions): Update.
 162
 163 2019-01-17  Tom Tromey  <tom@tromey.com>
 164
 165         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 166         declare VEC.
 167         (solib_target_parse_libraries): Change return type.
 168         (library_list_start_segment, library_list_start_section)
 169         (library_list_end_library, library_list_start_library); Update.
 170         (solib_target_free_library_list): Remove.
 171         (solib_target_parse_libraries): Remove cleanup.  Change return
 172         type.
 173         (solib_target_current_sos): Update.
 174
 175 2019-01-17  Tom Tromey  <tromey@bapiya>
 176
 177         * valprint.c: Replace "the the" with "the".
 178         * symtab.c: Replace "the the" with "the".
 179         * solib.c: Replace "the the" with "the".
 180         * solib-dsbt.c: Replace "the the" with "the".
 181         * linespec.c: Replace "the the" with "the".
 182         * dwarf2loc.h: Replace "the the" with "the".
 183         * amd64-windows-tdep.c: Replace "the the" with "the".
 184         * aarch64-tdep.c: Replace "the the" with "the".
 185
 186 2019-01-16  Keith Seitz  <keiths@redhat.com>
 187
 188         PR gdb/23773
 189         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 190         <builder>: Rename to ..
 191         <m_builder>: ... this and make private.
 192         (dwarf2_cu::get_builder): New method.  Change all users of
 193         `builder' to use this method.
 194         (dwarf2_start_symtab): Move to ...
 195         (dwarf2_cu::start_symtab): ... here.  Update all callers
 196         (setup_type_unit_groups): Move to ...
 197         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 198         callers.
 199         (dwarf2_cu::reset_builder): New method.
 200         (process_full_compunit, process_full_type_unit): Use
 201         dwarf2_cu::reset_builder.
 202         (follow_die_offset): Record the ancestor CU if it is different
 203         from the followed DIE's CU.
 204         (follow_die_sig_1): Likewise.
 205
 206 2019-01-15  Tom Tromey  <tom@tromey.com>
 207
 208         * remote.c (class remote_state) <buf>: Now a char_vector.
 209         <buf_size>: Remove.
 210         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 211         parameter.
 212         (remote_target::getpkt_or_notif_sane_1)
 213         (remote_target::getpkt_sane)
 214         (remote_target::getpkt_or_notif_sane): Likewise.
 215         (class remote_target) <putpkt>: New overload.
 216         (remote_target::read_frame): Change type of "buf_p".  Remove
 217         sizeof_p parameter.
 218         (packet_ok): New overload.
 219         (packet_check_result): New overload.
 220         Update all uses.
 221
 222 2019-01-14  Tom Tromey  <tom@tromey.com>
 223
 224         * remote-notif.c (handle_notification, remote_notif_ack)
 225         (remote_notif_parse): Make "buf" const.
 226         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 227         const.
 228         (remote_notif_parse, remote_notif_ack, handle_notification):
 229         Likewise.
 230         * remote.c (remote_notif_stop_parse): Make "buf" const.
 231         (remote_target::remote_parse_stop_reply): Make "buf" const.
 232         (remote_notif_stop_ack): Make "buf" const.
 233
 234 2019-01-14  Tom Tromey  <tom@tromey.com>
 235
 236         * remote.c (remote_console_output): Make parameter const.
 237
 238 2019-01-14  Tom Tromey  <tom@tromey.com>
 239
 240         * target-debug.h (target_debug_print_signals): Constify.
 241         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 242         * procfs.c (procfs_target::pass_signals): Update.
 243         * linux-nat.c (linux_nat_target::pass_signals): Update.
 244         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 245         * target-delegates.c: Rebuild.
 246         * remote.c (remote_target::program_signals): Update.
 247         (remote_target::pass_signals): Update.
 248         * target.c (target_pass_signals): Constify argument.
 249         (target_program_signals): Likewise.
 250         * target.h (struct target_ops) <pass_signals, program_signals>:
 251         Constify argument.
 252         (target_pass_signals, target_program_signals): Constify argument.
 253
 254 2019-01-14  Tom Tromey  <tom@tromey.com>
 255
 256         PR tui/28819:
 257         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 258
 259 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 260
 261         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 262         field.
 263         * rs6000-tdep.c: Include reggroups.h.
 264         (IS_V_ALIAS_PSEUDOREG): Define.
 265         (rs6000_register_name): Return names for the "vX" aliases.
 266         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 267         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 268         aliases.  Call default_register_reggroup_p for all other
 269         pseudo-registers.
 270         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 271         New functions.
 272         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 273         Handle "vX" aliases.
 274         (v_alias_pseudo_register_collect): New function.
 275         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 276         (rs6000_gdbarch_init): Initialize "vX" aliases as
 277         pseudo-registers.  Restore registration of
 278         rs6000_pseudo_register_reggroup_p with
 279         set_tdesc_pseudo_register_reggroup_p.
 280
 281 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 282
 283         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 284         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 285         set_gdbarch_num_pseudo_regs.
 286
 287 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 288
 289         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 290         Remove arg prefixname, add do_set and do_show.
 291         Add member functions set_list and show_list.
 292         * cli/cli-style.c (class cli_style_option): Update accordingly.
 293         (style_set_list): Move to file scope.
 294         (style_show_list): Likewise.
 295         (set_style): Call help_list.
 296         (show_style): Call cmd_show_list.
 297         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 298         Update to use the new macro.
 299
 300 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 301
 302         * ada-lang.c (_initialize_ada_language): Expand the help text
 303         for the "catch exception" command.
 304
 305 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 306
 307         * symtab.c (matching_obj_sections): Initialize obj,
 308         declare it closer to its usage.
 309
 310 2019-01-10  Tom Tromey  <tom@tromey.com>
 311
 312         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 313         (basic_inf_threads_range): Remove.
 314         (inf_threads_range, inf_non_exited_threads_range)
 315         (safe_inf_threads_range): Use next_adapter.
 316
 317 2019-01-10  Keith Seitz  <keiths@redhat.com>
 318
 319         PR gdb/23712
 320         PR symtab/23010
 321         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 322         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 323
 324 2019-01-10  Keith Seitz  <keiths@redhat.com>
 325
 326         PR gdb/23712
 327         PR symtab/23010
 328         * dictionary.c (pending_to_vector): Remove.
 329         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 330         Remove _1 suffix, replacing functions of the same name.  Update
 331         all callers.
 332         (dict_create_hashed, dict_create_hashed_expandable)
 333         (dict_create_linear, dict_create_linear_expandable, dict_free)
 334         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 335         Make functions static.
 336
 337 2019-01-10  Keith Seitz  <keiths@redhat.com>
 338
 339         PR gdb/23712
 340         PR symtab/23010
 341         * dictionary.h (struct dictionary): Replace declaration with
 342         multidictionary.
 343         (dict_create_hashed, dict_create_hashed_expandable)
 344         (dict_create_linear, dict_create_linear_expandable)
 345         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 346         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 347         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 348         taking multidictionary argument.
 349         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 350         * block.h (struct block) <dict>: Change to multidictionary
 351         and rename `multidict'.
 352         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 353         symmisc.c: Update all dictionary references to multidictionary.
 354
 355 2019-01-10  Keith Seitz  <keiths@redhat.com>
 356
 357         PR gdb/23712
 358         PR symtab/23010
 359         * dictionary.c: Include unordered_map.
 360         (pending_to_vector): New function.
 361         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 362         Rewrite the non-"_1" functions to take vector instead
 363         of linked list.
 364         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 365         "new" _1 versions of the same name.
 366         (multidictionary): Define.
 367         (std::hash<enum language): New definition.
 368         (collate_pending_symbols_by_language, mdict_create_hashed)
 369         (mdict_create_hashed_expandable, mdict_create_linear)
 370         (mdict_create_linear_expandable, mdict_free)
 371         (find_language_dictionary, create_new_language_dictionary)
 372         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 373         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 374         (mdict_size, mdict_empty): New functions.
 375         * dictionary.h (mdict_iterator): Define.
 376
 377 2019-01-10  Pedro Alves  <palves@redhat.com>
 378
 379         * breakpoint.c (read_uploaded_action)
 380         (create_tracepoint_from_upload): Adjust to use
 381         gdb::unique_xmalloc_ptr.
 382         * ctf.c (ctf_write_uploaded_tp):
 383         (SET_ARRAY_FIELD): Use emplace_back.
 384         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 385         * tracefile-tfile.c (tfile_write_uploaded_tp):
 386         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 387         gdb::unique_xmalloc_ptr.
 388         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 389         at_string, cond_string, cmd_strings>: Replace char pointers
 390         with gdb::unique_xmalloc_ptr.
 391
 392 2019-01-10  Pedro Alves  <palves@redhat.com>
 393
 394         * solib-target.c (library_list_start_library): Don't xstrdup name.
 395
 396 2019-01-10  Pedro Alves  <palves@redhat.com>
 397
 398         * mdebugread.c (parse_partial_symbols): Use
 399         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 400
 401 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 402
 403         * linux-fork.c (scoped_switch_fork_info)
 404         <~scoped_switch_fork_info>: Fix incorrect variable name.
 405
 406 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 407
 408         * linux-fork.c (scoped_switch_fork_info)
 409         <scoped_switch_fork_info>: Make explicit.
 410         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 411
 412 2019-01-10  Tom Tromey  <tom@tromey.com>
 413
 414         * objfiles.h (objfile::reset_psymtabs): Update.
 415         * objfiles.c (objfile::objfile): Update.
 416         * psymtab.h (psymtab_storage::obstack): Update.
 417         (psymtab_storage::m_obstack): Use gdb::optional.
 418         (class psymtab_storage): Update comment.  Remove objfile
 419         parameter.
 420         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 421
 422 2019-01-10  Tom Tromey  <tom@tromey.com>
 423
 424         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 425         <free_psymtabs>: Now private.
 426         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 427         (allocate_psymtab): Use new method.
 428
 429 2019-01-10  Tom Tromey  <tom@tromey.com>
 430
 431         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 432         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 433         * mdebugread.c (parse_partial_symbols): Use
 434         allocate_dependencies.
 435         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 436         allocate_dependencies.
 437         (process_psymtab_comp_unit_reader)
 438         (build_type_psymtab_dependencies): Likewise.
 439         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 440
 441 2019-01-10  Tom Tromey  <tom@tromey.com>
 442
 443         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 444         PSYMBOL_SET_LANGUAGE.
 445         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 446
 447 2019-01-10  Tom Tromey  <tom@tromey.com>
 448
 449         * psymtab.h (psymtab_storage::obstack): New method.
 450         <m_obstack>: Rename from obstack; now private.
 451         * psymtab.c (psymtab_storage): Update.
 452         * dwarf2read.c (create_addrmap_from_index)
 453         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 454         Update.
 455
 456 2019-01-10  Tom Tromey  <tom@tromey.com>
 457
 458         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 459         * objfiles.h (objfile::reset_psymtabs): New method.
 460
 461 2019-01-10  Tom Tromey  <tom@tromey.com>
 462
 463         * symmisc.c (print_symbol_bcache_statistics): Update.
 464         (print_objfile_statistics): Update.
 465         * symfile.c (reread_symbols): Update.
 466         * psymtab.h (class psymtab_storage): New.
 467         * psymtab.c (psymtab_storage): New constructor.
 468         (~psymtab_storage): New destructor.
 469         (require_partial_symbols): Update.
 470         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 471         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 472         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 473         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 474         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 475         (start_psymtab_common, end_psymtab_common)
 476         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 477         (allocate_psymtab): Update.
 478         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 479         Update.
 480         (dump_psymtab_addrmap, maintenance_print_psymbols)
 481         (maintenance_check_psymtabs): Update.
 482         (class objfile_psymtabs): Move to objfiles.h.
 483         * psympriv.h (discard_psymtab): Now inline.
 484         (psymtab_discarder::psymtab_discarder): Update.
 485         (psymtab_discarder::~psymtab_discarder): Update.
 486         (ALL_OBJFILE_PSYMTABS): Rewrite.
 487         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 488         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 489         Remove fields.
 490         <partial_symtabs>: New field.
 491         (class objfile_psymtabs): Move from psymtab.h.  Update.
 492         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 493         psymbol_cache.
 494         (objfile::~objfile): Don't destroy psymbol_cache.
 495         * mdebugread.c (parse_partial_symbols): Update.
 496         * dwarf2read.c (create_addrmap_from_index)
 497         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 498         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 499         (add_partial_subprogram, dwarf2_ranges_read): Update.
 500         * dwarf-index-write.c (write_address_map)
 501         (write_one_signatured_type, recursively_write_psymbols)
 502         (class debug_names, class debug_names, write_psymtabs_to_index):
 503         Update.
 504
 505 2019-01-10  Tom Tromey  <tom@tromey.com>
 506
 507         * symtab.h (SYMBOL_SET_NAMES): Update.
 508         (symbol_set_names): Update.
 509         (MSYMBOL_SET_NAMES): Update.
 510         * symtab.c (symbol_set_names): Change argument to be an
 511         objfile_per_bfd_storage.
 512         * psymtab.c (add_psymbol_to_bcache): Update.
 513         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 514
 515 2019-01-10  Tom Tromey  <tom@tromey.com>
 516
 517         * symtab.c (create_demangled_names_hash): Change argument to be an
 518         objfile_per_bfd_storage.
 519         (symbol_set_names): Update.
 520
 521 2019-01-10  Tom Tromey  <tom@tromey.com>
 522
 523         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 524         init_psymbol_list.
 525         * psymtab.c (init_psymbol_list): Do nothing if already called.
 526         * psympriv.h (init_psymbol_list): Add comment.
 527         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 528         init_psymbol_list.
 529         * dbxread.c (dbx_symfile_read): Unconditionally call
 530         init_psymbol_list.
 531
 532 2019-01-10  Tom Tromey  <tom@tromey.com>
 533
 534         * xcoffread.c (scan_xcoff_symtab): Update.
 535         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 536         "where".
 537         * mdebugread.c (parse_partial_symbols)
 538         (handle_psymbol_enumerators): Update.
 539         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 540         * dbxread.c (read_dbx_symtab): Update.
 541         * psympriv.h (psymbol_placement): New enum.
 542         (add_psymbol_to_list): Update.
 543
 544 2019-01-10  Tom Tromey  <tom@tromey.com>
 545
 546         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 547         static_psymbols parameters.
 548         (scan_xcoff_symtab): Update.
 549         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 550         static_psymbols parameters.
 551         * psympriv.h (start_psymtab_common): Update.
 552         * mdebugread.c (parse_partial_symbols): Update.
 553         * dwarf2read.c (create_partial_symtab): Update.
 554         * dbxread.c (read_dbx_symtab): Update.
 555         (start_psymtab): Remove global_psymbols and static_psymbols
 556         parameters.
 557
 558 2019-01-10  Tom Tromey  <tom@tromey.com>
 559
 560         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 561         * psymtab.c (allocate_psymtab): Add comment.
 562         * psympriv.h (allocate_psymtab): Add comment.
 563         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 564         initializations.
 565         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 566
 567 2019-01-10  Tom Tromey  <tom@tromey.com>
 568
 569         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 570         Don't declare.
 571         * mipsread.c: Include mdebugread.h.
 572         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 573         Declare.
 574         * elfread.c: Include mdebugread.h.
 575
 576 2019-01-09  Tom Tromey  <tom@tromey.com>
 577
 578         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 579         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 580         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 581         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 582         (psym_lookup_symbol, psym_find_last_source_symtab)
 583         (psym_forget_cached_source_info, psym_print_stats)
 584         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 585         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 586         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 587         (psym_find_compunit_symtab_by_address)
 588         (maintenance_print_psymbols, maintenance_info_psymtabs)
 589         (maintenance_check_psymtabs): Use ranged for.
 590         * psymtab.h (class objfile_psymtabs): New.
 591         (require_partial_symbols): Return objfile_psymtabs.
 592         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 593
 594 2019-01-09  Tom Tromey  <tom@tromey.com>
 595
 596         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 597         (find_pc_mapped_section, list_overlays_command)
 598         (map_overlay_command, unmap_overlay_command)
 599         (simple_overlay_update): Use all_objfiles.
 600         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 601         * printcmd.c (info_symbol_command): Use all_objfiles.
 602         * objfiles.h (ALL_OBJSECTIONS): Remove.
 603         * maint.c (maintenance_translate_address): Use all_objfiles.
 604         * gcore.c (gcore_create_callback): Use all_objfiles.
 605         (objfile_find_memory_regions): Likewise.
 606
 607 2019-01-09  Tom Tromey  <tom@tromey.com>
 608
 609         * symtab.c (find_line_symtab, info_sources_command)
 610         (make_source_files_completion_list): Use objfile_compunits.
 611         * source.c (select_source_symtab): Use objfile_compunits.
 612         * objfiles.h (struct objfile): Update comment.
 613         (ALL_OBJFILES): Remove.
 614         (ALL_FILETABS): Remove.
 615         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 616         objfile_compunits.
 617
 618 2019-01-09  Tom Tromey  <tom@tromey.com>
 619
 620         * symmisc.c (print_objfile_statistics, dump_objfile)
 621         (maintenance_print_symbols): Use compunit_filetabs.
 622         * source.c (forget_cached_source_info_for_objfile): Use
 623         compunit_filetabs.
 624         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 625         (ALL_FILETABS): Use compunit_filetabs.
 626         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 627         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 628
 629 2019-01-09  Tom Tromey  <tom@tromey.com>
 630
 631         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 632         (compunit_filetabs): New.
 633         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 634         compunit_filetabs.
 635         (info_sources_command, make_source_files_completion_list): Remove
 636         declaration.
 637         * symmisc.c (print_objfile_statistics, dump_objfile)
 638         (maintenance_print_symbols): Remove declaration.
 639         (maintenance_info_symtabs): Use compunit_filetabs.
 640         (maintenance_info_line_tables): Likewise.
 641         * source.c (select_source_symtab): Change local variable name.
 642         (forget_cached_source_info_for_objfile): Remove declaration.
 643         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 644         * objfiles.c (objfile_relocate1): Remove declaration.
 645         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 646         declaration.
 647         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 648         * coffread.c (coff_symtab_read): Remove declaration.
 649         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 650         compunit_filetabs.
 651
 652 2019-01-09  Tom Tromey  <tom@tromey.com>
 653
 654         * symtab.c (lookup_objfile_from_block)
 655         (find_pc_sect_compunit_symtab, search_symbols)
 656         (default_collect_symbol_completion_matches_break_on): Use
 657         objfile_compunits.
 658         * objfiles.h (ALL_COMPUNITS): Remove.
 659         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 660         * cp-support.c (add_symbol_overload_list_qualified): Use
 661         objfile_compunits.
 662         * ada-lang.c (ada_collect_symbol_completion_matches)
 663         (ada_add_global_exceptions): Use objfile_compunits.
 664
 665 2019-01-09  Tom Tromey  <tom@tromey.com>
 666
 667         * source.c (select_source_symtab)
 668         (forget_cached_source_info_for_objfile): Remove declaration.
 669         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 670         declaration.
 671         * maint.c (count_symtabs_and_blocks): Remove declaration.
 672         * cp-support.c (add_symbol_overload_list_qualified): Remove
 673         declaration.
 674         * coffread.c (coff_symtab_read): Remove declaration.
 675         * symtab.c (lookup_symbol_in_objfile_symtabs)
 676         (basic_lookup_transparent_type_1): Use objfile_compunits.
 677         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 678         (info_sources_command, search_symbols)
 679         (default_collect_symbol_completion_matches_break_on)
 680         (make_source_files_completion_list): Remove declaration.
 681         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 682         (ada_collect_symbol_completion_matches)
 683         (ada_add_global_exceptions): Remove declaration.
 684         * linespec.c (iterate_over_all_matching_symtabs): Use
 685         objfile_compunits.
 686         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 687         (class objfile_compunits): New.
 688         (ALL_COMPUNITS): Use objfile_compunits.
 689         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 690         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 691         objfile_compunits.
 692         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 693
 694 2019-01-09  Tom Tromey  <tom@tromey.com>
 695
 696         * symtab.c (search_symbols)
 697         (default_collect_symbol_completion_matches_break_on): Use
 698         objfile_msymbols.
 699         * ada-lang.c (ada_lookup_simple_minsym)
 700         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 701         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 702         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 703         objfile_msymbols.
 704         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 705         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 706         * objc-lang.c (find_methods): Use objfile_msymbols.
 707         (info_selectors_command, info_classes_command): Likewise.
 708         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 709         * objfiles.h (class objfile_msymbols): New.
 710         (ALL_OBJFILE_MSYMBOLS): Remove.
 711         (ALL_MSYMBOLS): Remove.
 712
 713 2019-01-09  Tom Tromey  <tom@tromey.com>
 714
 715         * common/next-iterator.h (next_adapter): Add Iterator template
 716         parameter.
 717         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 718         (class all_objfiles_safe): New.
 719         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 720         * objfiles.c (put_objfile_before): Update comment.
 721         (add_separate_debug_objfile): Likewise.
 722         (free_all_objfiles): Use all_objfiles_safe.
 723         (objfile_purge_solibs): Likewise.
 724
 725 2019-01-09  Tom Tromey  <tom@tromey.com>
 726
 727         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 728         (expand_symtab_containing_pc, lookup_static_symbol)
 729         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 730         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 731         all_objfiles.
 732         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 733         * breakpoint.c (create_overlay_event_breakpoint)
 734         (create_longjmp_master_breakpoint)
 735         (create_std_terminate_master_breakpoint)
 736         (create_exception_master_breakpoint): Use all_objfiles.
 737         * linux-thread-db.c (try_thread_db_load_from_pdir)
 738         (has_libpthread): Use all_objfiles.
 739         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 740         * linespec.c (iterate_over_all_matching_symtabs)
 741         (search_minsyms_for_name): Use all_objfiles.
 742         * maint.c (maintenance_info_sections): Use all_objfiles.
 743         * main.c (captured_main_1): Use all_objfiles.
 744         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 745         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 746         * guile/scm-pretty-print.c
 747         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 748         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 749         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 750         (maintenance_print_msymbols): Use all_objfiles.
 751         * source.c (select_source_symtab): Use all_objfiles.
 752         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 753         * symfile.c (remove_symbol_file_command)
 754         (expand_symtabs_matching, map_symbol_filenames): Use
 755         all_objfiles.
 756         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 757         all_objfiles.
 758         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 759         * objc-lang.c (find_methods): Use all_objfiles.
 760         * objfiles.c (have_partial_symbols, have_full_symbols)
 761         (have_minimal_symbols, qsort_cmp)
 762         (default_iterate_over_objfiles_in_search_order): Use
 763         all_objfiles.
 764         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 765         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 766         (maintenance_check_psymtabs): Use all_objfiles.
 767         (ALL_PSYMTABS): Remove.
 768         * compile/compile-object-run.c (do_module_cleanup): Use
 769         all_objfiles.
 770         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 771         * cp-support.c (add_symbol_overload_list_qualified): Use
 772         all_objfiles.
 773         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 774         Use all_objfiles.
 775         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 776         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 777         all_objfiles.
 778         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 779         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 780         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 781         Uses all_objfiles.
 782         * solib.c (solib_read_symbols): Use all_objfiles
 783
 784 2019-01-09  Tom Tromey  <tom@tromey.com>
 785
 786         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 787         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 788         all_objfiles.
 789         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 790         * symmisc.c (print_symbol_bcache_statistics)
 791         (print_objfile_statistics, maintenance_print_objfiles)
 792         (maintenance_info_symtabs, maintenance_check_symtabs)
 793         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 794         all_objfiles.
 795         * source.c (forget_cached_source_info): Use all_objfiles.
 796         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 797         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 798         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 799         * objfiles.c (update_section_map): Use all_objfiles.
 800         (shared_objfile_contains_address_p): Likewise.
 801         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 802         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 803
 804 2019-01-09  Tom Tromey  <tom@tromey.com>
 805
 806         * common/next-iterator.h: New file.
 807         * objfiles.h (class all_objfiles): New.
 808         (struct objfile_iterator): New.
 809
 810 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 811
 812         * NEWS: Move the description of the changed "frame", "select-frame",
 813          and "info frame" commands to the Changed commands section.
 814
 815 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 816
 817         * gdbtypes.c (check_stub_method_group): Remove handling of old
 818         mangling schemes.
 819         * linespec.c (find_methods): Likewise.
 820         * stabsread.c (read_member_functions): Likewise.
 821         * valops.c (search_struct_method): Likewise.
 822         (value_struct_elt_for_reference): Likewise.
 823         * NEWS: Mention this change.
 824
 825 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 826
 827         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 828         print_source_lines.
 829         * source.c (print_source_lines_base): Update line number check.
 830         (print_source_lines): New function.
 831         (source_lines_range::source_lines_range): New function.
 832         * source.h (class source_lines_range): New class.
 833         (print_source_lines): New declaration.
 834
 835 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 836
 837         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 838
 839 2019-01-08  Tom Tromey  <tom@tromey.com>
 840             Simon Marchi  <simon.marchi@ericsson.com>
 841
 842         PR gdb/24060
 843         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 844         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 845         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 846         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 847         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 848         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 849
 850 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 851
 852         * source.c (select_source_symtab): Move header comment to
 853         declaration in source.h.
 854         (forget_cached_source_info_for_objfile): Likewise.
 855         (forget_cached_source_info): Likewise.
 856         (identify_source_line): Likewise.
 857         * source.h (identify_source_line): Move declaration from symtab.h
 858         and add comment from source.c
 859         (print_source_lines): Likewise.
 860         (forget_cached_source_info_for_objfile): Likewise.
 861         (forget_cached_source_info): Likewise.
 862         (select_source_symtab): Likewise.
 863         (enum print_source_lines_flag): Move definition from symtab.h.
 864         * symtab.h (identify_source_line): Move declaration to source.h.
 865         (print_source_lines): Likewise.
 866         (forget_cached_source_info_for_objfile): Likewise.
 867         (forget_cached_source_info): Likewise.
 868         (select_source_symtab): Likewise.
 869         (enum print_source_lines_flag): Move definition to source.h.
 870         * tui/tui-hooks.c: Add 'source.h' include.
 871
 872 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 873
 874         * source.c (print_source_lines_base): Handle requests to print
 875         reverse line number sequences, and guard against empty lines
 876         string.
 877
 878 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 879
 880         * source.c (print_source_lines_base): Fix skip of '\r' if next
 881         character is '\n'.
 882
 883 2019-01-06  Tom Tromey  <tom@tromey.com>
 884
 885         * c-exp.y (struct c_parse_state) <macro_original_text,
 886         expansion_obstack>: New member.
 887         (macro_original_text, expansion_obstack): Remove globals.
 888         (scan_macro_expansion, scanning_macro_expansion)
 889         (finished_macro_expansion): Update.
 890         (scan_macro_cleanup): Remove.
 891         (yylex, c_parse): Update.
 892
 893 2019-01-06  Tom Tromey  <tom@tromey.com>
 894
 895         * c-exp.y (struct c_parse_state) <strings>: New member.
 896         (operator_stoken): Update.
 897
 898 2019-01-06  Tom Tromey  <tom@tromey.com>
 899
 900         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 901         (union type_stack_elt) <typelist_val>: Now a pointer to
 902         std::vector.
 903         (type_stack_cleanup): Don't declare.
 904         (push_typelist): Update.
 905         * parse.c (pop_typelist): Return a std::vector.
 906         (push_typelist): Take a std::vector.
 907         (follow_types): Update.  Do not free args.
 908         (type_stack_cleanup): Remove.
 909         * c-exp.y (struct c_parse_state): New.
 910         (cpstate): New global.
 911         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 912         (nonempty_typelist): Update.
 913         (func_mod): Create a new vector.
 914         (c_parse): Create a c_parse_state.
 915         (check_parameter_typelist): Do not delete params.
 916         (function_method): Update.  Do not delete type_list.
 917
 918 2019-01-06  Tom Tromey  <tom@tromey.com>
 919
 920         PR gdb/28155:
 921         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 922         check_typedef.
 923         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 924         (print_return_value): Likewise.
 925
 926 2019-01-05  Tom Tromey  <tom@tromey.com>
 927
 928         * contrib/cleanup_check.py: Remove.
 929         * contrib/gcc-with-excheck: Remove.
 930         * contrib/exsummary.py: Remove.
 931         * contrib/excheck.py: Remove.
 932
 933 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 934
 935         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 936         NULL. Initialize tpprev to NULL instead of assigning it
 937         to NULL on the next statement.
 938         * windows-nat.c (windows_delete_thread): Remove check for
 939         main_thread_id before printing thread exit notifications.
 940         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 941         Remove thread ID check against main_thread_id.
 942         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 943         windows_delete_thread.
 944         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 945
 946 2019-01-04  Tom Tromey  <tom@tromey.com>
 947
 948         * compile/compile.c (_initialize_compile): Use upper case for
 949         metasyntactic variables.
 950         * symmisc.c (_initialize_symmisc): Use upper case for
 951         metasyntactic variables.
 952         * psymtab.c (_initialize_psymtab): Use upper case for
 953         metasyntactic variables.
 954         * demangle.c (demangle_command): Use upper case for metasyntactic
 955         variables.
 956         (_initialize_demangler): Likewise.
 957         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 958         variables.
 959
 960 2019-01-03  Tom Tromey  <tom@tromey.com>
 961
 962         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 963
 964 2019-01-03  Tom Tromey  <tom@tromey.com>
 965
 966         * python/py-symtab.c (salpy_str): Update.
 967         (struct salpy_sal_object) <symtab>: Now a PyObject.
 968         (salpy_dealloc): Update.
 969         (del_objfile_sal): Use gdbpy_ref.
 970
 971 2019-01-03  Tom Tromey  <tom@tromey.com>
 972
 973         * python/py-type.c (convert_field): Use new_reference.  Return
 974         gdbpy_ref.
 975         (make_fielditem): Return gdbpy_ref.
 976         (typy_fields): Update.
 977         (typy_getitem): Update.
 978         (field_name): Return gdbpy_ref.  Use new_reference.
 979         (typy_iterator_iternext): Update.
 980
 981 2019-01-03  Tom Tromey  <tom@tromey.com>
 982
 983         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 984
 985 2019-01-03  Tom Tromey  <tom@tromey.com>
 986
 987         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 988         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 989         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 990         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 991         (pspy_set_type_printers): Likewise.
 992         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 993         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 994         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 995         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 996         (objfpy_set_type_printers): Likewise.
 997
 998 2019-01-03  Tom Tromey  <tom@tromey.com>
 999
1000         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1001         (gdbpy_print_stack): Use gdbpy_err_fetch.
1002         * python/python-internal.h (class gdbpy_err_fetch): New class.
1003         (class gdbpy_enter) <m_error_type, m_error_value,
1004         m_error_traceback>: Remove.
1005         <m_error>: New member.
1006         (gdbpy_exception_to_string): Don't declare.
1007         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1008         * python/py-value.c (convert_value_from_python): Use
1009         gdbpy_err_fetch.
1010         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1011         gdbpy_exception_to_string.
1012         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1013         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1014         gdbpy_err_fetch.
1015
1016 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * linux-nat.c (delete_lwp_cleanup): Delete.
1019         (struct lwp_deleter): New struct.
1020         (lwp_info_up): New typedef.
1021         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1022         lwp_info_up.
1023
1024 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * linux-fork.c (class scoped_switch_fork_info): New class.
1027         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1028
1029 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * valops.c (find_overload_match): Remove use of null_cleanup, and
1032         calls to do_cleanups.
1033
1034 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1035
1036         * compile/compile-cplus-types.c
1037         (compile_cplus_instance::decl_name): Handle changes to
1038         cp_func_name.
1039         * cp-support.c (cp_func_name): Update header comment, update
1040         return type.
1041         * cp-support.h (cp_func_name): Update return type in declaration.
1042         * valops.c (find_overload_match): Move temp_func local to top
1043         level of function and change its type.  Use temp_func to hold and
1044         delete temporary string obtained from cp_func_name.
1045
1046 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1049         gdb::char_vector, remove cleanup, and update uses of `msg`.
1050
1051 2019-01-03  Jim Wilson  <jimw@sifive.com>
1052
1053         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1054
1055 2019-01-02  Tom Tromey  <tom@tromey.com>
1056
1057         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1058         (tdesc_parse_xml): Remove cleanups.
1059         * target-descriptions.h (make_cleanup_free_target_description):
1060         Don't declare.
1061         (target_desc_deleter): New struct.
1062         (target_desc_up): New typedef.
1063         * target-descriptions.c (target_desc_deleter::operator()): Rename
1064         from free_target_description.
1065         (make_cleanup_free_target_description): Remove.
1066
1067 2019-01-02  Tom Tromey  <tom@tromey.com>
1068
1069         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1070         constructor, destructor.
1071         (linespec_parser): Remove typedef.
1072         (~linespec_parser): Rename from linespec_parser_delete.
1073         (linespec_lex_to_end, linespec_complete_label)
1074         (linespec_complete): Update.
1075         (decode_line_full): Remove cleanups.
1076         (decode_line_1): Update.
1077
1078 2019-01-02  Tom Tromey  <tom@tromey.com>
1079
1080         * python/python-internal.h (inferior_to_inferior_object): Change
1081         return type.
1082         * python/py-exitedevent.c (create_exited_event_object): Update.
1083         * python/py-inferior.c (inferior_to_inferior_object): Return
1084         gdbpy_ref.
1085         (python_new_inferior, python_inferior_deleted)
1086         (thread_to_thread_object, delete_thread_object)
1087         (build_inferior_list, gdbpy_selected_inferior): Update.
1088         * python/py-infthread.c (create_thread_object): Update.  Also fail
1089         if inferior_to_inferior_object fails.
1090
1091 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1092
1093         * inferior.h (class inferior) <displaced_step_state>: New field.
1094         * infrun.h (struct displaced_step_state): Move here from
1095         infrun.c.  Initialize fields, add constructor.
1096         <inf>: Remove field.
1097         <reset>: New method.
1098         * infrun.c (struct displaced_step_inferior_state): Move to
1099         infrun.h.
1100         (displaced_step_inferior_states): Remove.
1101         (get_displaced_stepping_state): Adust.
1102         (displaced_step_in_progress_any_inferior): Adjust.
1103         (displaced_step_in_progress_thread): Adjust.
1104         (displaced_step_in_progress): Adjust.
1105         (add_displaced_stepping_state): Remove.
1106         (get_displaced_step_closure_by_addr): Adjust.
1107         (remove_displaced_stepping_state): Remove.
1108         (infrun_inferior_exit): Call displaced_step_state.reset.
1109         (use_displaced_stepping): Don't check for NULL.
1110         (displaced_step_prepare_throw): Call
1111         get_displaced_stepping_state.
1112         (displaced_step_fixup): Don't check for NULL.
1113         (prepare_for_detach): Don't check for NULL.
1114
1115 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1116
1117         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1118          in case of call that did not complete.
1119
1120 2019-01-02  Andrey Utkin  <autkin@undo.io>
1121
1122         * symfile.c (find_separate_debug_file): Fix search of debug files for
1123         remote debuggee.
1124
1125 2019-01-02  Tom Tromey  <tom@tromey.com>
1126
1127         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1128         indentation.
1129         * python/py-frame.c (frapy_older): Remove cast.
1130         (frapy_newer): Likewise.
1131         * python/py-breakpoint.c (local_setattro): Remove cast.
1132         * python/py-arch.c (archpy_name): Remove local variable.
1133         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1134
1135 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1136
1137         * unittests/basic_string_view/element_access/char/empty.cc:
1138         Fix year range in copyright header.
1139
1140 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1141
1142         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1143         Delete.
1144         <operator==>: Update with for removed field.
1145         <hash>: Likewise.
1146         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1147         <isa_features>: ...this.
1148         <abi_features>: New field.
1149         (riscv_isa_flen): Update comment.
1150         (riscv_abi_xlen): New declaration.
1151         (riscv_abi_flen): New declaration.
1152         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1153         isa_features.
1154         (riscv_abi_xlen): New function.
1155         (riscv_isa_flen): Update to get answer from isa_features.
1156         (riscv_abi_flen): New function.
1157         (riscv_has_fp_abi): Update to get answer from abi_features.
1158         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1159         xlen and flen.
1160         (riscv_call_info) <xlen, flen>: Update comment.
1161         (riscv_call_arg_struct): Remove invalid assertions
1162         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1163         is removed.
1164         (riscv_gdbarch_init): Gather isa features and abi features
1165         separately, ensure both match on the gdbarch when reusing an old
1166         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1167         a target with 64-bit float hardware.
1168
1169 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1170
1171         * source.c (search_command_helper): Stop reverse search
1172         when line 1 has been searched.
1173
1174 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1175
1176         * record-full.c (record_full_base_target::close): Rewrite
1177         record_full_core_buf_list free logic.
1178
1179 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1180
1181         * break-catch-syscall.c (print_one_catch_syscall): xfree
1182         the last text.
1183
1184 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1185
1186         * top.c (print_gdb_version): Update Copyright year in version
1187         message.
1188
1189 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1190
1191         Update copyright year range in all GDB files.
1192
1193 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1194
1195         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1196
1197 For older changes see ChangeLog-2018.
1198 \f
1199 Local Variables:
1200 mode: change-log
1201 left-margin: 8
1202 fill-column: 74
1203 version-control: never
1204 coding: utf-8
1205 End:
1206