gdb/ChangeLog

   1 2019-08-13  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_source_window_base)
   4         <show_exec_info_content>: Declare.
   5         (tui_show_exec_info_content): Don't declare.
   6         * tui/tui-winsource.c
   7         (tui_source_window_base::show_exec_info_content): Rename from
   8         tui_show_exec_info_content.
   9         (tui_source_window_base::update_exec_info): Update.
  10
  11 2019-08-13  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
  14         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
  15         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
  16         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
  17         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
  18         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
  19         ... here.
  20
  21 2019-08-13  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-winsource.h (struct tui_source_window_base)
  24         <update_exec_info>: Declare.
  25         (tui_update_exec_info): Don't declare.
  26         * tui/tui-winsource.c (tui_update_source_window_as_is)
  27         (tui_source_window_base::refresh_all)
  28         (tui_update_all_breakpoint_info): Update.
  29         (tui_source_window_base::update_exec_info): Rename from
  30         tui_update_exec_info.
  31         * tui/tui-stack.c (tui_show_frame_info): Update.
  32
  33 2019-08-13  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-winsource.h (struct tui_source_window_base)
  36         <set_exec_info_content>: Declare.
  37         (tui_set_exec_info_content): Don't declare.
  38         * tui/tui-winsource.c
  39         (tui_source_window_base::set_exec_info_content): Rename from
  40         tui_set_exec_info_content.
  41         (tui_update_exec_info): Update.
  42
  43 2019-08-13  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-winsource.h (struct tui_source_window_base)
  46         <show_source_content>: Declare.
  47         (tui_show_source_content): Don't declare.
  48         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  49         (tui_source_window_base::show_source_content): Rename from
  50         tui_show_source_content.
  51         (tui_source_window_base::refresh_all): Update.
  52         * tui/tui-layout.c (show_source_disasm_command)
  53         (show_source_or_disasm_and_command): Update.
  54
  55 2019-08-13  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-winsource.c (tui_erase_source_content)
  58         (tui_show_source_content, tui_source_window_base::refresh_all):
  59         Update.
  60         * tui/tui-wingeneral.h
  61         (tui_check_and_display_highlight_if_needed): Don't declare.
  62         * tui/tui-wingeneral.c
  63         (tui_win_info::check_and_display_highlight_if_needed): Rename from
  64         check_and_display_highlight_if_needed.
  65         * tui/tui-win.c (tui_rehighlight_all)
  66         (tui_win_info::make_visible_with_new_height): Update.
  67         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  68         (tui_data_window::erase_data_content)
  69         (tui_data_window::display_all_data): Update.
  70         * tui/tui-data.h (struct tui_win_info)
  71         <check_and_display_highlight_if_needed>: Declare.
  72
  73 2019-08-13  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-win.c (tui_resize_all): Call
  76         tui_delete_invisible_windows.
  77         * tui/tui-layout.c (show_layout): Call
  78         tui_delete_invisible_windows.
  79         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
  80         * tui/tui-data.c (tui_delete_invisible_windows): New function.
  81
  82 2019-08-13  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
  85         tui_add_win_to_layout.
  86
  87 2019-08-13  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-layout.h (tui_default_win_height): Don't declare.
  90         * tui/tui-layout.c (tui_default_win_height): Now static.
  91
  92 2019-08-13  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-layout.c (show_layout): Unify all layout cases into a
  95         single switch.
  96         (show_source_disasm_command, show_source_or_disasm_and_command):
  97         Don't check current layout.
  98
  99 2019-08-13  Tom Tromey  <tom@tromey.com>
 100
 101         * tui/tui-wingeneral.c (make_all_visible): Remove.
 102         (tui_make_all_invisible): Simplify.
 103         * tui/tui-layout.c (tui_make_all_invisible): Move from
 104         tui-wingeneral.c; simplify.
 105         (show_layout): Hoist call to tui_make_all_invisible.
 106         (show_data): Don't call tui_make_all_invisible.
 107
 108 2019-08-13  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 111         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 112
 113 2019-08-13  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 116         tui-data.c.
 117         (show_source_disasm_command, show_data)
 118         (show_source_or_disasm_and_command): Don't use
 119         tui_set_current_layout_to.
 120         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 121         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 122         tui-layout.c.
 123         (tui_set_current_layout_to): Remove.
 124
 125 2019-08-13  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-layout.c (tui_set_layout): Update.
 128         * tui/tui-data.h (struct tui_layout_def): Remove.
 129         (tui_layout_def): Don't declare.
 130         * tui/tui-data.c (layout_def): Remove.
 131         (tui_layout_def): Remove.
 132
 133 2019-08-13  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-winsource.h (struct tui_source_window_base)
 136         <clear_detail>: No longer "override".
 137         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 138         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 139         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 140         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 141         Remove.
 142         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 143
 144 2019-08-13  Tom Tromey  <tromey@adacore.com>
 145
 146         * tracepoint.c: Don't include readline.h or history.h.
 147
 148 2019-08-12  Tom Tromey  <tom@tromey.com>
 149
 150         * configure: Rebuild.
 151         * configure.ac: Check for readline 7.
 152         * NEWS: Mention readline 7 requirement.
 153         * README: Update.
 154
 155 2019-08-12  Tom Tromey  <tom@tromey.com>
 156
 157         * mingw-hdep.c (gdb_select): Remove readline hack.
 158
 159 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 160
 161         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 162         when the function fails.
 163
 164 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 165
 166         * s390-tdep.c (s390_type_align): New function.
 167         (s390_gdbarch_init): Set it as type_align gdbarch method.
 168
 169 2019-08-09  Tom de Vries  <tdevries@suse.de>
 170
 171         PR gdb/24591
 172         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 173         pc_low with relocation offset.
 174
 175 2019-08-07  Tom Tromey  <tromey@adacore.com>
 176
 177         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 178         (print_frame_args): Update.
 179         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 180         Update.
 181         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 182         * frame.h (struct frame_arg): Add initializers.
 183         <error>: Now a unique_xmalloc_ptr.
 184
 185 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 186
 187         * NEWS: Expand the Pointer Authentication entry.
 188         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 189         (aarch64_frame_unmask_lr): ... to this.
 190         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 191         Call aarch64_frame_unmask_lr.
 192         * frame.c (struct frame_info): Add "masked" variable.
 193         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 194         (fprint_frame): Check for masked pc.
 195         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 196         declarations.
 197         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 198         * stack.c (print_frame): Check for masked pc.
 199
 200 2019-08-06  Tom Tromey  <tom@tromey.com>
 201
 202         * stabsread.c (patch_block_stabs, read_one_struct_field)
 203         (read_enum_type): Use obstack_strndup.
 204         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 205         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 206         * dwarf2read.c (guess_full_die_structure_name)
 207         (anonymous_struct_prefix): Use obstack_strndup.
 208         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 209         * c-exp.y (yylex): Use obstack_strndup.
 210         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 211         (write_var_or_type): Use obstack_strndup.
 212
 213 2019-08-06  Tom Tromey  <tom@tromey.com>
 214
 215         * symfile.c (reread_symbols): Use obstack_strdup.
 216         * stabsread.c (read_type): Use obstack_strdup.
 217         * gdb_obstack.h (obstack_strdup): New overload.
 218         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 219         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 220         (dwarf2_canonicalize_name): Use obstack_strdup.
 221         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 222         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 223         Use obstack_strdup.
 224
 225 2019-08-06  Tom Tromey  <tom@tromey.com>
 226
 227         * gdb_obstack.h (obstack_strdup): Define.
 228         * gdb_obstack.c (obstack_strdup): Don't define.
 229
 230 2019-08-06  Tom Tromey  <tom@tromey.com>
 231
 232         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 233         obstack_strdup.
 234         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 235         obstack_strdup.
 236         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 237         * stabsread.c (common_block_start): Use obstack_strdup.
 238         * objfiles.c (set_objfile_main_name, objfile): Use
 239         obstack_strdup.
 240         * namespace.c (add_using_directive): Use obstack_strdup.
 241         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 242         * jit.c (finalize_symtab): Use obstack_strdup.
 243         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 244         (guess_partial_die_structure_name, partial_die_info::fixup)
 245         (dwarf2_name): Use obstack_strdup.
 246         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 247         obstack_strdup.
 248         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 249         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 250         obstack_strdup.
 251         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 252
 253 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 254
 255         * unittests/help-doc-selftests.c: New file.
 256         * Makefile.in: Add the new file.
 257
 258 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 259
 260         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 261         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 262         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 263         the trailing '.' is not output, and the first character is uppercased.
 264         (print_help_for_command): Update call to print_doc_line.
 265         (print_doc_of_command): Likewise.
 266         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 267         * cli/cli-option.c (append_indented_doc): Do not append newline.
 268         (build_help_option): Append newline after first appended_indented_doc
 269         only if a second call is done.
 270         (build_help): Append 2 new lines before each option, except the first
 271         one.
 272         * compile/compile.c (_initialize_compile): Add new lines after
 273         %OPTIONS%, when not at the end of the help.
 274         Change help doc or code
 275         producing the help doc to respect the invariants.
 276         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 277         Also removed the new line after 'Options:', as all other commands
 278         do not put an empty line between 'Options:' and the first option.
 279         * printcmd.c (_initialize_printcmd): Likewise.
 280         * stack.c (_initialize_stack): Likewise.
 281         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 282         incorrectly telling COMMAND is optional.
 283         * ada-lang.c (_initialize_ada_language): Change help doc or code
 284         producing the help doc to respect the invariants.
 285         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 286         * breakpoint.c (_initialize_breakpoint): Likewise.
 287         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 288         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 289         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 290         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 291         _initialize_cli_style): Likewise.
 292         * corelow.c (core_target_info): Likewise.
 293         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 294         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 295         * filesystem.c (_initialize_filesystem): Likewise.
 296         * frame.c (_initialize_frame): Likewise.
 297         * gnu-nat.c (add_task_commands): Likewise.
 298         * infcall.c (_initialize_infcall): Likewise.
 299         * infcmd.c (_initialize_infcmd): Likewise.
 300         * interps.c (_initialize_interpreter): Likewise.
 301         * language.c (_initialize_language): Likewise.
 302         * linux-fork.c (_initialize_linux_fork): Likewise.
 303         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 304         * maint.c (_initialize_maint_cmds): Likewise.
 305         * memattr.c (_initialize_mem): Likewise.
 306         * printcmd.c (_initialize_printcmd): Likewise.
 307         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 308         _RegEx): Likewise.
 309         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 310         * record-btrace.c (_initialize_record_btrace): Likewise.
 311         * record-full.c (_initialize_record_full): Likewise.
 312         * record.c (_initialize_record): Likewise.
 313         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 314         * regcache.c (_initialize_regcache): Likewise.
 315         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 316         _initialize_remote): Likewise.
 317         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 318         * serial.c (_initialize_serial): Likewise.
 319         * skip.c (_initialize_step_skip): Likewise.
 320         * source.c (_initialize_source): Likewise.
 321         * stack.c (_initialize_stack): Likewise.
 322         * symfile.c (_initialize_symfile): Likewise.
 323         * symtab.c (_initialize_symtab): Likewise.
 324         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 325         * top.c (init_main): Likewise.
 326         * tracefile-tfile.c (tfile_target_info): Likewise.
 327         * tracepoint.c (_initialize_tracepoint): Likewise.
 328         * tui/tui-win.c (_initialize_tui_win): Likewise.
 329         * utils.c (add_internal_problem_command): Likewise.
 330         * valprint.c (value_print_option_defs): Likewise.
 331
 332 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 333
 334         PR build/24886
 335         * configure.ac: Drop enable-libmcheck support.
 336         * configure, config.in: Rebuild.
 337         * libmcheck.m4: Remove.
 338         * acinclude.m4: Don't include it.
 339         * Makefile.in: Don't distribute it.
 340         * top.c (print_gdb_configuration): Don't mention it.
 341
 342 2019-08-06  Tom Tromey  <tom@tromey.com>
 343
 344         * utils.c (set_output_style): Sometimes pass stream to
 345         emit_style_escape.
 346         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 347         * record-btrace.c (btrace_insn_history): Update.
 348         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 349         method.
 350         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 351         Update initializers.
 352         <m_uiout>: New field.
 353         <m_di>: Move lower.
 354         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 355         Remove "uiout" parameter.
 356         (dump_insns): Update.
 357         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 358         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 359
 360 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 361
 362         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 363         (error_in_psymtab_expansion): Likewise.
 364         (lookup_symbol_via_quick_fns): Likewise.
 365         (basic_lookup_transparent_type_quick): Likewise.
 366         (basic_lookup_transparent_type_1): Likewise.
 367
 368 2019-08-06  Tom Tromey  <tromey@adacore.com>
 369
 370         * source.c (last_source_error): Now bool.
 371         (print_source_lines_base): Make "noprint" bool.  Only open
 372         source file when last_source_visited changes.
 373
 374 2019-08-06  Tom Tromey  <tromey@adacore.com>
 375
 376         * annotate.c (annotate_source_line): Use g_source_cache.
 377         * source-cache.c (source_cache::get_plain_source_lines): Change
 378         parameters.  Populate m_offset_cache.
 379         (source_cache::ensure): New method.
 380         (source_cache::get_line_charpos): New method.
 381         (extract_lines): Move lower.  Change parameters.
 382         (source_cache::get_source_lines): Move lower.
 383         * source-cache.h (class source_cache): Update comment.
 384         <get_line_charpos>: New method.
 385         <get_source_lines>: Update comment.
 386         <clear>: Clear m_offset_cache.
 387         <get_plain_source_lines>: Change parameters.
 388         <ensure>: New method
 389         <m_offset_cache>: New member.
 390         * source.c (forget_cached_source_info_for_objfile): Update.
 391         (info_source_command): Use g_source_cache.
 392         (find_source_lines, open_source_file_with_line_charpos): Remove.
 393         (print_source_lines_base, search_command_helper): Use g_source_cache.
 394         * source.h (open_source_file_with_line_charpos): Don't declare.
 395         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 396         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 397         Use g_source_cache.
 398
 399 2019-08-06  Tom Tromey  <tromey@adacore.com>
 400
 401         * source-cache.c (source_cache::get_plain_source_lines):
 402         Remove "first_line" and "last_line" parameters.
 403         (source_cache::get_source_lines): Cache plain text.
 404         * source-cache.h (class source_cache)
 405         <get_plain_source_lines>: Update.
 406
 407 2019-08-06  Tom Tromey  <tromey@adacore.com>
 408
 409         * source-cache.c (extract_lines): No longer a method.
 410         Changed type of parameter.  Include final newline.
 411         (selftests::extract_lines_test): New function.
 412         (_initialize_source_cache): Likewise.
 413         * source-cache.h (class source_cache)
 414         <extract_lines>: Don't declare.
 415
 416 2019-08-06  Tom Tromey  <tromey@adacore.com>
 417
 418         * breakpoint.c (init_breakpoint_sal): Update.
 419         (breakpoint): Update.
 420         * breakpoint.h (struct breakpoint) <filter>: Now a
 421         unique_xmalloc_ptr.
 422
 423 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 424
 425         * NEWS: Mention dictionary access on blocks.
 426         * python/py-block.c (blpy_getitem): New function.
 427         (block_object_as_mapping): New struct.
 428         (block_object_type): Use new struct for tp_as_mapping field.
 429
 430 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 431
 432         * objfiles.h (objfile): Add a comment describing partial symbols.
 433
 434 2019-08-05  Tom Tromey  <tromey@adacore.com>
 435
 436         * compile/compile.c (_initialize_compile): Use _(), not N_().
 437         * thread.c (_initialize_thread): Use _(), not N_().
 438         * stack.c (_initialize_stack): Use _(), not N_().
 439         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 440
 441 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 442
 443         * dwarf2read.c (struct dw2_symtab_iterator):
 444         <want_specific_block>: Remove.
 445         <block_index>: Change type to gdb::optional.
 446         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 447         change type of BLOCK_INDEX parameter to gdb::optional.
 448         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 449         (dw2_lookup_symbol): Don't pass argument for
 450         WANT_SPECIFIC_BLOCK.
 451         (dw2_expand_symtabs_for_function): Don't pass argument for
 452         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 453         (class dw2_debug_names_iterator)
 454         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 455         parameter, change BLOCK_INDEX type to gdb::optional.
 456         <m_want_specific_block>: Remove.
 457         <m_block_index>: Change type to gdb::optional.
 458         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 459         gdb::optional.  Re-write in function of gdb::optional.
 460         (dw2_debug_names_lookup_symbol): Don't pass argument for
 461         WANT_SPECIFIC_BLOCK.
 462         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 463         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 464         BLOCK_INDEX.
 465
 466 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 467
 468         * NEWS: Mention changes to "info sources" command.
 469
 470 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 471
 472         * symtab.c (filename_partial_match_opts): New struct type.
 473         (struct output_source_filename_data): New members
 474         regexp, c_regexp, partial_match.
 475         (output_source_filename): Use new members to decide to print file.
 476         (info_sources_option_defs): New variable.
 477         (make_info_sources_options_def_group, print_info_sources_header,
 478         info_sources_command_completer):
 479         New functions.
 480         (info_sources_command): Read new optional arguments.
 481         (_initialize_symtab): Update info sources help.
 482
 483 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 484
 485         * ada-lang.c (exception_support_info_v0): Renamed from...
 486         (default_exception_support_info): ... this.  Create new
 487         definition for v1.
 488         (ada_has_this_exception_support): Look up catch_handlers_sym.
 489         (ada_exception_support_info_sniffer): Try v0 after default.
 490
 491 2019-08-01  Tom Tromey  <tromey@adacore.com>
 492
 493         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 494         gdbarch.h.
 495
 496 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 497
 498         * s12z-tdep.c: Fix include path for s12z-opc.h.
 499
 500 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 501
 502         * NEWS: Require GNU make 3.82.
 503
 504 2019-07-16  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 507         declare.
 508
 509 2019-07-30  Tom Tromey  <tromey@adacore.com>
 510
 511         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 512
 513 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 514
 515         * printcmd.c (print_address_symbolic): Print negative offsets.
 516         (build_address_symbolic): Force signed arithmetic when computing
 517         offset.
 518
 519 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 520
 521         PR/24474: Add a function to lookup static variables.
 522         * NEWS: Mention this new function.
 523         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 524         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 525         * python/python.c (python_GdbMethods): Add new function.
 526
 527 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 528
 529         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 530         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 531         (objfpy_lookup_static_symbol): New function.
 532         (objfile_object_methods): Add new functions.
 533
 534 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 535
 536         * NEWS: Mention 'set|show print frame-info'.  Mention new
 537         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 538         backtrace argument.  Mention that python frame filtering code
 539         is now consistent with what 'backtrace' command prints.
 540
 541 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 542
 543         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 544         comments.
 545         (print_frame_info_auto, print_frame_info_source_line,
 546         print_frame_info_location, print_frame_info_source_and_location,
 547         print_frame_info_location_and_address, print_frame_info_short_location):
 548         New declarations.
 549         (struct frame_print_options): New member print_frame_info.
 550         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 551         * stack.h (get_user_print_what_frame_info): New declaration.
 552         (frame_show_address): New declaration.
 553         * stack.c (print_frame_arguments_choices): New value 'presence'.
 554         (print_frame_info_auto, print_frame_info_source_line,
 555         print_frame_info_location, print_frame_info_source_and_location,
 556         print_frame_info_location_and_address, print_frame_info_short_location,
 557         print_frame_info_choices, print_frame_info_print_what): New definitions.
 558         (print_frame_args): Only print dots for args if print frame-arguments
 559         is 'presence'.
 560         (frame_print_option_defs): New element for "frame-info".
 561         (get_user_print_what_frame_info): New function.
 562         (frame_show_address): Make non static.  Move comment to stack.h.
 563         (print_frame_info_to_print_what): New function.
 564         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 565         to decide what to print.
 566         (backtrace_command_1): Handle the new print_frame_arguments_presence
 567         value.
 568         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 569         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 570         (py_print_frame): In non-mi mode, use LOCATION as default for
 571         print_what, similarly to frame information printed directly by
 572         backtrace command. Handle frame-info user option in non MI mode.
 573
 574 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 575
 576         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 577         Add case for debugging 32-bit target on 64-bit host.  Revise
 578         comment.
 579
 580 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 581
 582         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 583         instead of find_function_entry_range_from_pc.
 584
 585 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 586
 587         * stack.c (find_frame_funname): Remove code which preferred
 588         minsym over symtab sym in "certain pathological cases".
 589
 590         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 591         parameter.  Change type of "do_demangle" to bool.
 592         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 593         Pass suitable "prefer_sym_over_minsym" flag to
 594         build_address_symbolic().  Don't output "+" for negative offsets.
 595         * printcmd.c (print_address_symbolic): Update invocation of
 596         build_address_symbolic to include a "prefer_sym_over_minsym"
 597         flag.
 598         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 599         Restrict cases in which use of minimal symbol is preferred to that
 600         of a found symbol.  Update comments.
 601
 602         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 603         for entry pc when entry pc is out of range for that FDE.
 604
 605 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 606
 607         PR gdb/24839:
 608         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 609         type.
 610
 611 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 612
 613         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 614         this function's Python signature.
 615
 616
 617 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 618
 619         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 620         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 621         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 622         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 623         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 624
 625
 626 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 627
 628         * h8300-tdep.c (h8300_register_name_common): New.
 629         h8300_register_name): Use h8300_register_name_common.
 630         (h8300s_register_name): Likewise.
 631         (h8300sx_register_name): Likewise.
 632         (h8300h_register_nam): New.
 633         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 634
 635
 636 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 637
 638         * arm-tdep.c (arm_skip_cmse_entry): New function.
 639         (arm_is_sgstubs_section): New function.
 640         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 641
 642 2019-07-22  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 645         Don't self-assign.
 646
 647 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 648
 649         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 650         type_print.
 651
 652 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 653
 654         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 655         so that GDB doesn't match any msymbols when searching in the
 656         TYPES_DOMAIN.
 657         (print_symbol_info): Print using typedef_print or type_print based
 658         on the type of the symbol.  Add updated FIXME comment moved from...
 659         (_initialize_symtab): ... move and update FIXME comment to above.
 660
 661 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 662
 663         * NEWS: Mention adding -q option to "info types".
 664         * symtab.c (struct info_types_options): New struct.
 665         (info_types_options_defs): New variable.
 666         (make_info_types_options_def_group): New function.
 667         (info_types_command): Use gdb::option framework to parse options.
 668         (info_types_command_completer): New function.
 669         (_initialize_symtab): Extend the help text on "info types" and
 670         register command completer.
 671
 672 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 673
 674         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 675         (lookup_symbol_in_objfile): Change int to block_enum and add a
 676         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 677
 678 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 679
 680         * MAINTAINERS (Write After Approval): Add self.
 681
 682 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 683
 684         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 685         instruction to the dummy code region.
 686
 687 2019-07-19  Tom Tromey  <tromey@adacore.com>
 688
 689         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 690         (ARGSUSED, PARAMS, __func__): Remove rules.
 691
 692 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 693
 694         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 695         * features/arm/arm-with-iwmmxt.c: Remove.
 696         * features/arm/arm-with-iwmmxt.xml: Remove.
 697         * features/arm/arm-with-m-fpa-layout.c: Remove.
 698         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 699         * features/arm/arm-with-m-vfp-d16.c: Remove.
 700         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 701         * features/arm/arm-with-m.c: Remove.
 702         * features/arm/arm-with-m.xml: Remove.
 703         * features/arm/arm-with-neon.c: Remove.
 704         * features/arm/arm-with-neon.xml: Remove.
 705         * features/arm/arm-with-vfpv2.c: Remove.
 706         * features/arm/arm-with-vfpv2.xml: Remove.
 707         * features/arm/arm-with-vfpv3.c: Remove.
 708         * features/arm/arm-with-vfpv3.xml: Remove.
 709
 710 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 711
 712         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 713
 714 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 715
 716         * arch/aarch32.c (aarch32_create_target_description): Create
 717         target descriptions using features.
 718         * arch/arm.c (arm_create_target_description)
 719         (arm_create_mprofile_target_description): Likewise.
 720         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 721
 722 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 723
 724         * Makefile.in: Add new files.
 725         * aarch32-tdep.c: New file.
 726         * aarch32-tdep.h: New file.
 727         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 728         Call aarch32_read_description.
 729         * arch/aarch32.c: New file.
 730         * arch/aarch32.h: New file.
 731         * arch/arm.c (arm_create_target_description)
 732         (arm_create_mprofile_target_description): New function.
 733         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 734         (arm_create_target_description)
 735         (arm_create_mprofile_target_description): New declaration.
 736         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 737         read_description functions.
 738         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 739         Likewise.
 740         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 741         * arm-tdep.c (tdesc_arm_list): New variable.
 742         (arm_register_g_packet_guesses): Call create description functions.
 743         (arm_read_description) (arm_read_mprofile_description): New
 744         function.
 745         * arm-tdep.h (arm_read_description)
 746         (arm_read_mprofile_description): Add declaration.
 747         * configure.tgt: Add new files.
 748
 749 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 750
 751         * top.c (new_ui_command): Open specified terminal just once.
 752
 753 2019-07-18  Tom Tromey  <tromey@adacore.com>
 754
 755         * symtab.c (main_name): Constify return type.
 756         * symfile.c (set_initial_language): Update.
 757         * symtab.h (main_name): Constify return type.
 758
 759 2019-07-17  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-winsource.c (tui_update_source_window)
 762         (tui_update_source_window_as_is)
 763         (tui_update_source_windows_with_line): Remove return.
 764         * tui/tui-disasm.c (tui_show_disassem)
 765         (tui_show_disassem_and_update_source): Remove return.
 766         * tui/tui.c (tui_reset): Remove return.
 767         * tui/tui-wingeneral.c
 768         (tui_check_and_display_highlight_if_needed): Remove return.
 769
 770 2019-07-17  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 773
 774 2019-07-17  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-winsource.h (struct tui_exec_info_window)
 777         (struct tui_source_window_base): Move from tui-data.h.
 778         * tui/tui-winsource.c: Move many method definitions from
 779         elsewhere.  Remove "structuring" comments.
 780         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 781         (tui_source_window_base::refresh_window): Move to
 782         tui-winsource.c.
 783         * tui/tui-win.c (tui_source_window_base::refresh_all)
 784         (tui_source_window_base::update_tab_width)
 785         (tui_source_window_base::set_new_height)
 786         (tui_source_window_base::do_make_visible_with_new_height): Move to
 787         tui-winsource.c.
 788         * tui/tui-source.h: Update.
 789         * tui/tui-source.c (tui_source_window_base::reset): Move to
 790         tui-winsource.c.
 791         * tui/tui-disasm.h: Update.
 792         * tui/tui-data.h (struct tui_exec_info_window): Move to
 793         tui-winsource.h.
 794         (struct tui_source_window_base): Likewise.
 795         * tui/tui-data.c (tui_source_window_base::clear_detail)
 796         (tui_source_window_base, ~tui_source_window_base): Move to
 797         tui-winsource.c.
 798
 799 2019-07-17  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-win.c (tui_resize_all)
 802         (tui_source_window_base::update_tab_width)
 803         (tui_adjust_win_heights): Update.
 804         (tui_win_info::make_invisible_and_set_new_height): Rename from
 805         make_invisible_and_set_new_height.
 806         * tui/tui-data.h (struct tui_win_info)
 807         <make_invisible_and_set_new_height>: New method.
 808
 809 2019-07-17  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui.c: Update.
 812         * tui/tui-source.h (struct tui_source_window): Move from
 813         tui-data.h.
 814         * tui/tui-layout.c: Update.
 815         * tui/tui-disasm.c: Update.
 816         * tui/tui-data.h (struct tui_source_window): Move to
 817         tui-source.h.
 818
 819 2019-07-17  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 822         tui-data.h.
 823         * tui/tui-data.h (struct tui_disasm_window): Move to
 824         tui-disasm.h.
 825
 826 2019-07-17  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-regs.h (struct tui_data_item_window): Move from
 829         tui-data.h.
 830         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 831         * tui/tui-data.h (struct tui_data_item_window): Move to
 832         tui-regs.h.
 833         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 834
 835 2019-07-17  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui.c: Update.
 838         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 839         (tui_cmd_window::max_height): Move to tui-command.c.
 840         * tui/tui-layout.c: Update.
 841         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 842         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 843         tui-command.c.
 844         * tui/tui-command.h (struct tui_cmd_window): Move from
 845         tui-data.h.
 846         * tui/tui-command.c: Remove "structuring" comments.
 847         (tui_cmd_window::clear_detail)
 848         (tui_cmd_window::do_make_visible_with_new_height)
 849         (tui_cmd_window::max_height): Move from elsewhere.
 850
 851 2019-07-17  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 854         Now static.
 855         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 856         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 857
 858 2019-07-17  Tom Tromey  <tom@tromey.com>
 859
 860         * tui/tui.c: Update.
 861         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 862         tui-regs.c.
 863         * tui/tui-windata.h: Remove file.
 864         * tui/tui-windata.c: Remove file.
 865         * tui/tui-win.c (tui_data_window::set_new_height)
 866         (tui_data_window::do_make_visible_with_new_height): Move to
 867         tui-regs.c.
 868         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 869         * tui/tui-regs.c: Remove "structuring" comments.
 870         (tui_data_window::first_data_item_displayed)
 871         (tui_data_window::delete_data_content_windows)
 872         (tui_data_window::erase_data_content)
 873         (tui_data_window::display_all_data)
 874         (tui_data_window::refresh_all)
 875         (tui_data_window::do_scroll_vertical)
 876         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 877         (tui_data_window::do_make_visible_with_new_height)
 878         (tui_data_window::refresh_window): Move from elsewhere.
 879         (_initialize_tui_regs): Move to end of file.
 880         * tui/tui-layout.c: Update.
 881         * tui/tui-hooks.c: Update.
 882         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 883         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 884         tui-regs.c.
 885         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 886
 887 2019-07-17  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 890         seen.
 891
 892 2019-07-17  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-win.c (tui_source_window_base::set_new_height)
 895         (tui_source_window_base::do_make_visible_with_new_height): Use
 896         m_has_locator field directly.
 897         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 898         method.
 899         (struct tui_source_window_base) <has_locator>: Likewise.
 900
 901 2019-07-17  Tom Tromey  <tom@tromey.com>
 902
 903         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 904         Don't declare.
 905         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 906         Remove.
 907         * tui/tui-win.c (tui_source_window_base::set_new_height)
 908         (tui_source_window_base::set_new_height)
 909         (make_invisible_and_set_new_height)
 910         (tui_source_window_base::do_make_visible_with_new_height)
 911         (tui_source_window_base::do_make_visible_with_new_height):
 912         Update.
 913         * tui/tui-layout.c (show_source_disasm_command, show_data)
 914         (show_source_or_disasm_and_command): Update.
 915         * tui/tui-layout.c (show_layout): Update.
 916
 917 2019-07-17  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-layout.c (make_data_window): Remove.
 920         (show_data): Unify creation and re-initialization cases.
 921
 922 2019-07-17  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-layout.c (make_source_window, make_disasm_window):
 925         Remove.
 926         (show_data): Unify creation and re-initialization cases.
 927
 928 2019-07-17  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-layout.c (make_command_window): Remove.
 931         (show_source_disasm_command, show_source_or_disasm_and_command):
 932         Unify creation and re-initialization cases.
 933
 934 2019-07-17  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 937         creation and re-initialization cases.
 938
 939 2019-07-17  Tom Tromey  <tom@tromey.com>
 940
 941         * tui/tui-regs.c (tui_get_register): Return void.
 942
 943 2019-07-17  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 946         Simplify.
 947
 948 2019-07-17  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 951         resetting.
 952
 953 2019-07-17  Tom Tromey  <tom@tromey.com>
 954
 955         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 956         * tui/tui-regs.c (tui_reg_layout): New function.
 957         (tui_show_registers, tui_reg_command): Use it.
 958         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 959         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 960         parameters.
 961         (tui_layout_command): Remove.
 962
 963 2019-07-17  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-layout.h (tui/tui-layout): Return void.
 966         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 967
 968 2019-07-17  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-layout.c (show_source_disasm_command, show_data):
 971         Update.
 972         (reset_locator): Remove.
 973         (show_source_or_disasm_and_command): Update.
 974
 975 2019-07-17  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-source.c (tui_source_window_base::reset): Remove
 978         win_type parameter.
 979         * tui/tui-layout.c (make_command_window, make_source_window)
 980         (make_disasm_window, make_data_window)
 981         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 982         (reset_locator, show_source_or_disasm_and_command): Update.
 983         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 984         win_type parameter.
 985         (struct tui_source_window_base) <reset>: Likewise.
 986
 987 2019-07-17  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-layout.c (show_source_disasm_command): Use
 990         reset_locator.
 991         (reset_locator): New function.
 992         (init_and_make_win): Remove.
 993         (show_source_or_disasm_and_command): Use reset_locator.
 994
 995 2019-07-17  Tom Tromey  <tom@tromey.com>
 996
 997         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 998         condition.
 999         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1000         Remove condition.
1001         * tui/tui-source.c (tui_source_window_base::reset): New method.
1002         * tui/tui-layout.c (make_command_window): Don't call
1003         init_and_make_win.
1004         (make_source_window, make_disasm_window): Don't call
1005         make_source_or_disasm_window.
1006         (make_data_window): Don't call init_and_make_win.  Change calling
1007         convention.
1008         (show_source_disasm_command, show_data): Simplify.
1009         (make_source_or_disasm_window): Remove.
1010         (show_source_or_disasm_and_command): Simplify.
1011         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1012         (struct tui_source_window_base) <reset>: Likewise.
1013         <execution_info>: Remove initializer.
1014         * tui/tui-data.c (tui_source_window_base): Initialize
1015         execution_info.
1016
1017 2019-07-17  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1020         variable.
1021
1022 2019-07-17  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui.c (tui_rl_other_window): Update.
1025         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1026         superclass method first.  Always iterate over regs_content.
1027         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1028         method.
1029         * tui/tui-win.c (tui_set_focus_command): Update.
1030
1031 2019-07-17  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-win.c (tui_set_focus_command): Rename from
1034         tui_set_focus.  Call tui_enable.
1035         (tui_set_focus_command): Remove.
1036
1037 2019-07-17  Tom Tromey  <tom@tromey.com>
1038
1039         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1040         refresh_window.
1041         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1042         touchwin.
1043         (tui_data_window::refresh_window): Call refresh_window on data
1044         items.  Always call superclass refresh_window.
1045         (tui_win_info::refresh): Remove.
1046         (tui_source_window_base::refresh_window): Update.
1047         (tui_refresh_all): Update.
1048         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1049         refresh_window.
1050         (show_source_or_disasm_and_command): Likewise.
1051         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1052         (struct tui_source_window_base) <refresh>: Likewise.
1053
1054 2019-07-17  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-winsource.c (tui_clear_source_content)
1057         (tui_show_source_content): Update.
1058         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1059         whether content is empty.
1060         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1061         Remove.
1062
1063 2019-07-17  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1066         window's contents.
1067         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1068         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1069
1070 2019-07-17  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1073         (struct tui_data_item_window): Update.
1074
1075 2019-07-17  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1078         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1079         defines.
1080
1081 2019-07-17  Tom Tromey  <tom@tromey.com>
1082
1083         * tui/tui-winsource.h (tui_erase_source_content)
1084         (tui_clear_source_content): Remove "display_prompt" parameter.
1085         * tui/tui-winsource.c (tui_update_source_window_as_is)
1086         (tui_update_source_windows_with_addr): Update.
1087         (tui_clear_source_content): Remove "display_prompt" parameter.
1088         (tui_erase_source_content): Likewise.  Simplify.
1089         (tui_show_source_content): Update.
1090         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1091         * tui/tui-stack.c (tui_show_frame_info): Update.
1092         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1093         Remove defines.
1094
1095 2019-07-17  Tom Tromey  <tom@tromey.com>
1096
1097         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1098         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1099         parameter.
1100         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1101         parameter.
1102
1103 2019-07-17  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-winsource.c (tui_clear_source_content)
1106         (tui_show_source_content, tui_show_exec_info_content)
1107         (tui_clear_exec_info_content): Update.
1108         * tui/tui-stack.c (tui_show_locator_content): Update.
1109         (tui_show_frame_info): Update.
1110         * tui/tui-source.h (tui_source_window): Don't declare.
1111         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1112         from tui_source_is_displayed.
1113         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1114         Remove field.
1115         (struct tui_source_window_base) <content_in_use>: New field.  Now
1116         bool.
1117         (struct tui_source_window) <showing_source_p>: New method.
1118         (TUI_SRC_WIN): Change cast.
1119         * tui/tui-data.c (tui_initialize_static_data): Update.
1120
1121 2019-07-17  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1124         location_matches_p.
1125         * tui/tui-source.c (tui_source_window::location_matches_p): New
1126         method.
1127         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1128         method.
1129         * tui/tui-data.h (struct tui_source_window_base)
1130         <location_matches_p>: New method.
1131         (struct tui_source_window, struct tui_disasm_window)
1132         <location_matches_p>: Likewise.
1133
1134 2019-07-17  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-win.c (tui_set_win_height_command): Rename from
1137         tui_set_win_height.
1138         (tui_set_win_height_command): Remove.
1139
1140 2019-07-17  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-source.c (tui_source_window): New constructor.  Add
1143         observer.
1144         (~tui_source_window): New destructor.
1145         (tui_source_window::style_changed): New method.
1146         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1147         (tui_attach_detach_observers): Update.
1148         * tui/tui-data.h (struct tui_source_window): Make constructor not
1149         inline.  Add destructor.
1150         (struct tui_source_window) <style_changed>: New method.
1151         <m_observable>: New member.
1152
1153 2019-07-17  Tom Tromey  <tom@tromey.com>
1154
1155         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1156         * tui/tui-win.c (tui_resize_all): Fix typo.
1157
1158 2019-07-17  Tom Tromey  <tom@tromey.com>
1159
1160         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1161         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1162         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1163         * tui/tui-win.c (window_name_completer): Use foreach.
1164         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1165         (update_tab_width): Likewise.
1166         * tui/tui-layout.c (show_layout): Update.
1167         * tui/tui-data.h (class tui_window_iterator): New.
1168         (struct all_tui_windows): New.
1169         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1170
1171 2019-07-17  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1174         parameter.  Don't reference globals.
1175         (tui_reg_command): Update.
1176
1177 2019-07-17  Tom Tromey  <tom@tromey.com>
1178
1179         * tui/tui-regs.c (tui_show_registers): Simplify.
1180
1181 2019-07-17  Tom Tromey  <tom@tromey.com>
1182
1183         * tui/tui-regs.c (tui_show_registers): Update.
1184         (tui_show_register_group): Add win_info parameter.
1185
1186 2019-07-17  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1189         Rename from tui_display_reg_element_at_line.
1190         (tui_data_window::display_registers_from_line): Update.
1191         * tui/tui-data.h (struct tui_data_window)
1192         <display_reg_element_at_line>: New method.
1193
1194 2019-07-17  Tom Tromey  <tom@tromey.com>
1195
1196         * tui/tui-regs.h (tui_display_registers_from)
1197         (tui_display_registers_from_line): Don't declare.
1198         * tui/tui-windata.c (tui_data_window::display_all_data)
1199         (tui_data_window::refresh_all)
1200         (tui_data_window::do_scroll_vertical): Update.
1201         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1202         from tui_display_registers_from.
1203         (tui_display_reg_element_at_line): Update.
1204         (tui_data_window::display_registers_from_line): Rename from
1205         tui_display_registers_from_line.
1206         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1207         display_registers_from_line>: New methods.
1208
1209 2019-07-17  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1212         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1213         from tui_erase_data_content.
1214         (tui_data_window::display_all_data)
1215         (tui_data_window::refresh_all)
1216         (tui_data_window::do_scroll_vertical): Update.
1217         * tui/tui-regs.c (tui_show_registers): Update.
1218         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1219         New method.
1220
1221 2019-07-17  Tom Tromey  <tom@tromey.com>
1222
1223         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1224         declare.
1225         * tui/tui-windata.c
1226         (tui_data_window::delete_data_content_windows): Rename from
1227         tui_delete_data_content_windows.
1228         (tui_data_window::display_all_data)
1229         (tui_data_window::do_scroll_vertical): Update.
1230         * tui/tui-data.h (struct tui_data_window)
1231         <delete_data_content_windows>: New method.
1232
1233 2019-07-17  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1236         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1237
1238 2019-07-17  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1241         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1242         from tui_display_all_data.
1243         * tui/tui-win.c
1244         (tui_data_window::do_make_visible_with_new_height): Update.
1245         * tui/tui-regs.c (tui_show_registers): Update.
1246         * tui/tui-layout.c (tui_set_layout): Update.
1247         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1248         method.
1249
1250 2019-07-17  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1253         * tui/tui-windata.c (tui_display_data_from): Remove.
1254         (tui_data_window::refresh_all): Update.
1255
1256 2019-07-17  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1259         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1260         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1261         tui_display_registers_from_line.
1262         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1263         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1264         "force_display" parameter.
1265
1266 2019-07-17  Tom Tromey  <tom@tromey.com>
1267
1268         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1269         declare.
1270         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1271         Rename from tui_first_reg_element_no_inline.
1272         (tui_display_reg_element_at_line)
1273         (tui_display_registers_from_line): Update.
1274         * tui/tui-data.h (struct tui_data_window)
1275         <first_reg_element_no_inline>: New method.
1276
1277 2019-07-17  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui-windata.c (tui_display_data_from)
1280         (tui_data_window::do_scroll_vertical): Update.
1281         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1282         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1283         Rename from tui_line_from_reg_element_no.
1284         (tui_display_registers_from_line): Update.
1285         * tui/tui-data.h (struct tui_data_window)
1286         <line_from_reg_element_no>: New method.
1287
1288 2019-07-17  Tom Tromey  <tom@tromey.com>
1289
1290         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1291         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1292         tui_last_regs_line_no.
1293         (tui_display_reg_element_at_line)
1294         (tui_display_registers_from_line): Update.
1295         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1296         method.
1297
1298 2019-07-17  Tom Tromey  <tom@tromey.com>
1299
1300         PR tui/24722:
1301         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1302         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1303         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1304         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1305         (tui_update_breakpoint_info): Likewise.
1306         * tui/tui-hooks.c (tui_event_create_breakpoint)
1307         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1308         Update.
1309
1310 2019-07-17  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1313
1314 2019-07-17  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-winsource.c (tui_update_source_window_as_is)
1317         (tui_update_source_windows_with_addr): Update.
1318         * tui/tui-source.h (tui_set_source_content)
1319         (tui_show_symtab_source): Add "win_info" parameter.
1320         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1321         parameter.
1322         (tui_show_symtab_source): Likewise.
1323
1324 2019-07-17  Tom Tromey  <tom@tromey.com>
1325
1326         * tui/tui-wingeneral.c
1327         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1328
1329 2019-07-17  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1332         (struct tui_cmd_window) <can_scroll>: New method.
1333         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1334         method.
1335
1336 2019-07-17  Tom Tromey  <tromey@adacore.com>
1337
1338         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1339         do_field_signed>: Rename.  Change type of "value".
1340         * ui-out.c (ui_out::field_signed): Rename from field_int.
1341         Change type of "value".
1342         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1343         type of "value".
1344         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1345         do_field_int.  Change type of "value".
1346         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1347         do_field_int.  Change type of "value".
1348         * tracepoint.c (trace_status_mi, tfind_1)
1349         (print_one_static_tracepoint_marker): Update.
1350         * thread.c (print_thread_info_1, print_selected_thread_frame):
1351         Update.
1352         * stack.c (print_frame, print_frame_info): Update.
1353         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1354         Update.
1355         * source.c (print_source_lines_base): Update.
1356         * skip.c (info_skip_command): Update.
1357         * record-btrace.c (btrace_ui_out_decode_error)
1358         (btrace_call_history_src_line): Update.
1359         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1360         Update.
1361         * progspace.c (print_program_space): Update.
1362         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1363         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1364         do_field_int.  Change type of "value".
1365         * mi/mi-out.c (mi_ui_out::do_table_begin)
1366         (mi_ui_out::do_table_header): Update.
1367         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1368         type of "value".
1369         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1370         (mi_cmd_data_list_changed_registers, output_register)
1371         (mi_cmd_data_read_memory, mi_load_progress)
1372         (mi_cmd_trace_frame_collected): Update.
1373         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1374         Update.
1375         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1376         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1377         (mi_cmd_var_list_children, varobj_update_one): Update.
1378         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1379         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1380         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1381         * inferior.c (print_inferior): Update.
1382         * gdb_bfd.c (print_one_bfd): Update.
1383         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1384         Update.
1385         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1386         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1387         do_field_int.  Change type of "value".
1388         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1389         do_field_int.  Change type of "value".
1390         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1391         (print_one_breakpoint_location, print_it_catch_fork)
1392         (print_one_catch_fork, print_it_catch_vfork)
1393         (print_one_catch_vfork, print_it_catch_solib)
1394         (print_it_catch_exec, print_it_ranged_breakpoint)
1395         (print_mention_watchpoint, print_mention_masked_watchpoint)
1396         (bkpt_print_it, update_static_tracepoint): Update.
1397         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1398         * break-catch-syscall.c (print_it_catch_syscall): Update.
1399         * ada-tasks.c (print_ada_task_info): Update.
1400         * ada-lang.c (print_it_exception, print_mention_exception):
1401         Update.
1402
1403 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1404
1405         PR breakpoints/24541
1406         * gdbarch.c: Regenerate.
1407         * gdbarch.h: Regenerate.
1408         * gdbarch.sh: Adjust return type and parameter types for
1409         'stap_adjust_register'.
1410         (i386_stap_adjust_register): Adjust signature and return new
1411         register name.
1412         * stap-probe.c (stap_parse_register_operand): Adjust use of
1413         'gdbarch_stap_adjust_register'.
1414
1415 2019-07-17  Tom Tromey  <tromey@adacore.com>
1416
1417         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1418         declare VEC.
1419         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1420         std::vector.
1421         (struct s390_process_info): Add initializers.
1422         (s390_add_process): Use new.
1423         (s390_linux_nat_target::low_forget_process): Use delete.
1424         (s390_linux_nat_target::low_new_fork)
1425         (s390_linux_nat_target::stopped_by_watchpoint)
1426         (s390_linux_nat_target::low_prepare_to_resume)
1427         (s390_linux_nat_target::insert_watchpoint)
1428         (s390_linux_nat_target::insert_hw_breakpoint)
1429         (s390_linux_nat_target::remove_watchpoint)
1430         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1431
1432 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1433
1434         * aarch64-fbsd-nat.c: Include regcache.h.
1435         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1436         argument.
1437         (aarch64_fbsd_nat_target::fetch_registers)
1438         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1439         variable.
1440         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1441
1442 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1443
1444         * fbsd-nat.c: Include gdbarch.h.
1445
1446 2019-07-15  Tom Tromey  <tromey@adacore.com>
1447
1448         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1449
1450 2019-07-15  Tom Tromey  <tromey@adacore.com>
1451
1452         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1453         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1454         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1455         * cli-out.c (cli_ui_out::do_field_int): New method.
1456         * ui-out.c (ui_out::field_unsigned): New method.
1457         * symfile.c (generic_load): Use field_unsigned.
1458         (print_transfer_performance): Likewise.
1459         * record-btrace.c (ui_out_field_uint): Remove.
1460         (btrace_call_history_insn_range, btrace_call_history): Use
1461         field_unsigned.
1462         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1463         field_unsigned.
1464         * ui-out.h (class ui_out) <field_unsigned>: New method.
1465         <do_field_unsigned>: Likewise.
1466
1467 2019-07-15  Tom Tromey  <tromey@adacore.com>
1468
1469         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1470         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1471         * target.c (flash_erase_command): Use field_string.
1472         * infrun.c (print_signal_received_reason): Use field_string.
1473         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1474         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1475         field_string.
1476         * ada-tasks.c (print_ada_task_info): Use field_string.
1477
1478 2019-07-15  Tom Tromey  <tromey@adacore.com>
1479
1480         * target.c (flash_erase_command): Use field_core_addr.
1481         * symfile.c (generic_load): Use field_core_addr.
1482         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1483         Use field_core_addr.
1484         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1485         field_core_addr.
1486
1487 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1488
1489         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1490         value if its desired type is smaller than a CORE_ADDR and signed.
1491
1492 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1493
1494         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1495         of changes to field names, and use new is_reference field to
1496         decide if a property is a reference or not.
1497         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1498         field.
1499         (struct dwarf2_property_baton): Update header comment, rename
1500         'referenced_type' to 'property_type' and update comments.
1501         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1502         default property type, store in property baton, update to take
1503         accound of renamed field.
1504         (read_func_scope): Update call to attr_to_dynamic_prop.
1505         (read_array_type): Likewise.
1506         (dwarf2_per_cu_addr_sized_int_type): New function.
1507         (read_subrange_index_type): Move type finding code to
1508         dwarf2_per_cu_addr_sized_int_type.
1509         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1510         (dwarf2_per_cu_addr_type): New function.
1511         (set_die_type): Update calls to attr_to_dynamic_prop.
1512
1513 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1514
1515         * dwarf2read.c (read_subrange_index_type): New function.
1516         (read_subrange_type): Move code into new function and call it.
1517         * gdbtypes.c (create_range_type): Add some asserts.
1518
1519 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1520
1521         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1522         update return statements.
1523         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1524         declaration, and update comment to match.
1525         * gdbtypes.c (resolve_dynamic_array): Update call to
1526         dwarf2_evaluate_property to match new return type.
1527
1528 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1529
1530         * valarith.c (value_subscripted_rvalue): Change lowerbound
1531         parameter type from int to LONGEST.
1532         * value.h (value_subscripted_rvalue): Likewise in declaration.
1533
1534 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1535
1536         * cli/cli-utils.c (info_print_command_completer): New function.
1537         * cli/cli-utils.h: Add 'completer.h' include, and forward
1538         declaration for 'struct cmd_list_element'.
1539         (info_print_command_completer): Declare.
1540         * stack.c (_initialize_stack): Add completer for 'info locals' and
1541         'info args'.
1542         * symtab.c (_initialize_symtab): Add completer for 'info
1543         variables' and 'info functions'.
1544         * NEWS: Mention completion for additional info commands.
1545
1546 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1547
1548         * cli/cli-utils.c (extract_info_print_args): Delete.
1549         (extract_arg_maybe_quoted): Delete.
1550         (info_print_options_defs): New variable.
1551         (make_info_print_options_def_group): New function.
1552         (extract_info_print_options): Define new function.
1553         * cli/cli-utils.h (extract_info_print_args): Delete.
1554         (struct info_print_options): New structure.
1555         (extract_info_print_options): Declare new function.
1556         * stack.c (info_locals_command): Update to use new
1557         extract_info_print_options, also add a header comment.
1558         (info_args_command): Likewise.
1559         * symtab.c (info_variables_command): Likewise.
1560         (info_functions_command): Likewise.
1561
1562 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1563
1564         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1565         to extract string arguments.
1566         * common/common-utils.c (extract_string_maybe_quoted): New function.
1567         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1568
1569 2019-07-11  Tom Tromey  <tromey@adacore.com>
1570
1571         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1572         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1573         * top.h (gdbinit): Don't declare.
1574         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1575         into...
1576         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1577         * top.c (gdb_init): Don't call init_cli_cmds.
1578         (gdbinit): Remove.
1579         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1580
1581 2019-07-11  Tom Tromey  <tromey@adacore.com>
1582
1583         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1584         after it has been moved.
1585
1586 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1587
1588         * valops.c (value_must_coerce_to_target): Change return type to
1589         bool.
1590         * value.h (value_must_coerce_to_target): Likewise.
1591
1592 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1593
1594         * breakpoint.c (is_hardware_watchpoint): Remove
1595         forward-declaration.
1596         (is_masked_watchpoint): Change return type to bool.
1597         (is_tracepoint): Likewise.
1598         (is_breakpoint): Likewise.
1599         (is_hardware_watchpoint): Likewise.
1600         (is_watchpoint): Likewise.
1601         (is_no_memory_software_watchpoint): Likewise.
1602         (is_catchpoint): Likewise.
1603         (breakpoint_1): Make FILTER parameter's return type bool.
1604         is_masked_watchpoint): Change return type to bool.
1605         (save_breakpoints): Make FILTER parameter's return type bool.
1606         * breakpoint.h (is_breakpoint): Change return type to bool.
1607         (is_watchpoint): Likewise.
1608         (is_catchpoint): Likewise.
1609         (is_tracepoint): Likewise.
1610
1611 2019-07-10  Tom Tromey  <tom@tromey.com>
1612
1613         * defs.h: Don't include gdbarch.h.
1614         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1615         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1616         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1617         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1618         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1619         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1620         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1621         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1622         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1623         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1624         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1625         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1626         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1627         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1628         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1629         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1630         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1631         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1632         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1633         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1634         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1635         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1636         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1637         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1638         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1639         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1640         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1641
1642 2019-07-10  Tom Tromey  <tromey@adacore.com>
1643
1644         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1645         * breakpoint.c (init_ada_exception_breakpoint): Register as
1646         bp_catchpoint.
1647         (print_one_breakpoint_location, print_one_breakpoint): Use
1648         is_ada_exception_catchpoint.
1649         * ada-lang.c (class ada_catchpoint_location): Pass
1650         bp_loc_software_breakpoint to bp_location constructor.
1651         (is_ada_exception_catchpoint): New function.
1652
1653 2019-07-10  Tom Tromey  <tromey@adacore.com>
1654
1655         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1656         VEC.
1657         (struct arm_exidx_entry): New method operator<.
1658         (struct arm_exidx_data) <section_maps>: Change type.
1659         (arm_exidx_data_free): Remove.
1660         (arm_exidx_data_key): Change type.  Move lower.
1661         (arm_exidx_new_objfile): Update.
1662         (arm_compare_exidx_entries): Remove.
1663         (arm_find_exidx_entry, _initialize_arm_tdep)
1664
1665 2019-07-10  Tom Tromey  <tromey@adacore.com>
1666
1667         * solib-spu.c (ocl_program_data_key): Change type.
1668         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1669         Update.
1670
1671 2019-07-10  Tom Tromey  <tromey@adacore.com>
1672
1673         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1674         (struct solib_aix_inferior_data) <library_list>: Change type.
1675         (solib_aix_inferior_data_handle): Change type.
1676         (get_solib_aix_inferior_data): Update.
1677         (solib_aix_free_library_list): Remove.
1678         (library_list_start_library): Update.
1679         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1680         return type.
1681         (solib_aix_get_library_list)
1682         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1683         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1684
1685 2019-07-10  Tom Tromey  <tromey@adacore.com>
1686
1687         * solib-dsbt.c (struct dsbt_info): Add initializers.
1688         (solib_dsbt_pspace_data): Change type.
1689         (dsbt_pspace_data_cleanup): Remove.
1690         (get_dsbt_info, _initialize_dsbt_solib): Update.
1691
1692 2019-07-10  Tom Tromey  <tromey@adacore.com>
1693
1694         * spu-tdep.c (spu_overlay_data): Change type.
1695         (spu_get_overlay_table, spu_overlay_new_objfile)
1696         (_initialize_spu_tdep): Update.
1697
1698 2019-07-10  Tom Tromey  <tromey@adacore.com>
1699
1700         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1701         destructor.
1702         (dbx_objfile_data_key): Change type and declare later.
1703         (DBX_SYMFILE_INFO): Rewrite.
1704         * dbxread.c (dbx_objfile_data_key): Change type.
1705         (dbx_symfile_init): Update.
1706         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1707         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1708         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1709
1710 2019-07-10  Tom Tromey  <tromey@adacore.com>
1711
1712         * jit.c (jit_program_space_key): Change type.  Move lower.
1713         (get_jit_program_space_data): Update.
1714         (jit_program_space_data_cleanup): Remove.
1715         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1716         Update.
1717         (struct jit_program_space_data): Add initializers.
1718
1719 2019-07-10  Tom Tromey  <tromey@adacore.com>
1720
1721         * solib-darwin.c (struct darwin_info): Add initializers.
1722         (solib_darwin_pspace_data): Change type.
1723         (darwin_pspace_data_cleanup): Remove.
1724         (get_darwin_info, _initialize_darwin_solib): Update.
1725
1726 2019-07-10  Tom Tromey  <tromey@adacore.com>
1727
1728         * remote-sim.c (struct sim_inferior_data): Add initializers,
1729         constructor, and destructor.
1730         (sim_inferior_data_key): Change type.  Move lower.
1731         (check_for_duplicate_sim_descriptor): Update.
1732         (get_sim_inferior_data): Use new.  Update.
1733         (~sim_inferior_data_cleanup): Rename from
1734         sim_inferior_data_cleanup.  Simplify.
1735         (gdbsim_close_inferior, simulator_command)
1736         (sim_command_completer, _initialize_remote_sim): Update.
1737         (next_pid, INITIAL_PID): Move earlier.
1738
1739 2019-07-10  Tom Tromey  <tromey@adacore.com>
1740
1741         * python/python-internal.h (create_thread_object): Return
1742         gdbpy_ref.
1743         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1744         * python/py-inferior.c (struct threadlist_entry): Add
1745         constructor.
1746         <thread_obj>: Now a gdbpy_ref.
1747         (thread_to_thread_object): Update.
1748         (add_thread_object): Use new.
1749         (delete_thread_object): Use delete.
1750         (infpy_threads): Update.
1751         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1752         GIL.
1753
1754 2019-07-10  Tom Tromey  <tromey@adacore.com>
1755
1756         * valops.c (value_cast): Specialize error message for Ada.
1757
1758 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1759
1760         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1761
1762 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1763
1764         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1765         bpstat_should_step): Return bool, adjust comments.
1766         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1767         bpstat_should_step): Likewise.
1768
1769 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1770
1771         * features/Makefile: Use feature target descriptions for Arm.
1772         * features/arm/arm-core.c: Generate new file.
1773         * features/arm/arm-fpa.c: Likewise.
1774         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1775         * features/arm/arm-m-profile.c: Likewise.
1776         * features/arm/arm-vfpv2.c: Likewise.
1777         * features/arm/arm-vfpv3.c: Likewise.
1778         * features/arm/xscale-iwmmxt.c: Likewise.
1779         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1780
1781 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1782
1783         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1784         ptrace earlier.
1785
1786 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1787
1788         * features/aarch64-pauth.c: Regenerate.
1789
1790 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1791
1792         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1793         bool.
1794         (bpstat_what): Use false instead of 0.
1795
1796 2019-07-09  Pedro Alves  <palves@redhat.com>
1797
1798         * break-catch-throw.c (is_exception_catchpoint): New.
1799         * breakpoint.c (print_one_breakpoint_location): New parameter
1800         'raw_loc'.  Handle it.  Use
1801         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1802         looking at the breakpoint's type.
1803         (print_one_breakpoint): If handling "maint info breakpoints", also
1804         print locations of exception catchpoints.
1805         * breakpoint.h (is_exception_catchpoint): Declare.
1806
1807 2019-07-09  Pedro Alves  <palves@redhat.com>
1808
1809         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1810         "addr" field.
1811         (allocate_location_exception_catchpoint): New.
1812         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1813         (initialize_throw_catchpoint_ops): Install
1814         allocate_location_exception_catchpoint as allocate_location
1815         method.
1816         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1817         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1818         bp_loc_other.
1819         (breakpoint_address_is_meaningful): Delete.
1820         (bl_address_is_meaningful): New.
1821         (breakpoint_locations_match): Adjust comment.
1822         (bp_location_from_bp_type): New, factored out of...
1823         (bp_location::bp_location(breakpoint *)): ... this.
1824         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1825         factored out of...
1826         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1827         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1828         breakpoint_address_is_meaningful.
1829         (bp_locations_compare): Adjust comment.
1830         (update_global_location_list): Use bl_address_is_meaningful
1831         instead of breakpoint_address_is_meaningful.
1832         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1833         explicit.
1834         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1835         * python/py-breakpoint.c (bppy_get_location): No longer check
1836         whether location is null.
1837
1838 2019-07-09  Pedro Alves  <palves@redhat.com>
1839
1840         PR c++/15468
1841         * breakpoint.c (print_one_breakpoint_location): Remove
1842         single-location assert.
1843
1844 2019-07-09  Tom Tromey  <tom@tromey.com>
1845
1846         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1847         * configure: Rebuild.
1848         * configure.ac: Change common to gdbsupport.
1849         * gdbsupport: Rename from common.
1850         * acinclude.m4: Change common to gdbsupport.
1851         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1852         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1853         gdbsupport.
1854         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1855         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1856         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1857         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1858         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1859         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1860         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1861         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1862         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1863         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1864         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1865         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1866         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1867         coff-pe-read.c, command.h, compile/compile-c-support.c,
1868         compile/compile-c.h, compile/compile-cplus-symbols.c,
1869         compile/compile-cplus-types.c, compile/compile-cplus.h,
1870         compile/compile-loc2c.c, compile/compile.c, completer.c,
1871         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1872         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1873         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1874         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1875         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1876         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1877         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1878         features/aarch64-core.c, features/aarch64-fpu.c,
1879         features/aarch64-pauth.c, features/aarch64-sve.c,
1880         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1881         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1882         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1883         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1884         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1885         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1886         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1887         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1888         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1889         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1890         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1891         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1892         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1893         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1894         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1895         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1896         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1897         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1898         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1899         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1900         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1901         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1902         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1903         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1904         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1905         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1906         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1907         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1908         minsyms.c, mips-linux-tdep.c, namespace.h,
1909         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1910         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1911         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1912         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1913         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1914         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1915         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1916         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1917         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1918         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1919         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1920         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1921         procfs.c, producer.c, progspace.h, psymtab.h,
1922         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1923         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1924         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1925         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1926         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1927         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1928         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1929         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1930         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1931         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1932         target-memory.c, target.c, target.h, target/waitstatus.c,
1933         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1934         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1935         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1936         unittests/array-view-selftests.c,
1937         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1938         unittests/common-utils-selftests.c,
1939         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1940         unittests/format_pieces-selftests.c,
1941         unittests/function-view-selftests.c,
1942         unittests/lookup_name_info-selftests.c,
1943         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1944         unittests/mkdir-recursive-selftests.c,
1945         unittests/observable-selftests.c,
1946         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1947         unittests/parse-connection-spec-selftests.c,
1948         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1949         unittests/scoped_fd-selftests.c,
1950         unittests/scoped_mmap-selftests.c,
1951         unittests/scoped_restore-selftests.c,
1952         unittests/string_view-selftests.c, unittests/style-selftests.c,
1953         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1954         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1955         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1956         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1957         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1958         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1959
1960 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1961
1962         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1963         bool value.
1964         (decode_digits_ordinary): Set explicit_line field in sal.
1965         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1966         symtab_and_line that was set on an explicit line number in
1967         assembler code.  Do always update the recorded symtab and line if
1968         we do skip the prologue.
1969
1970 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * breakpoint.c (set_breakpoint_location_function): Remove
1973         explicit_loc parameter.
1974         (momentary_breakpoint_from_master): Update call to
1975         set_breakpoint_location_function.
1976         (add_location_to_breakpoint): Likewise.
1977
1978 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1979
1980         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1981         required features based on default bfd type when no specific bfd
1982         is present.
1983
1984 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1985
1986         * NEWS: Mention that GDB printf and eval commands can now print
1987         C-style and Ada-style convenience var strings without
1988         calling the inferior.
1989         * printcmd.c (printf_c_string): Locally print GDB internal var
1990         instead of transiting via the inferior.
1991         (printf_wide_c_string): Likewise.
1992
1993 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1994
1995         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1996
1997 2019-07-04  Tom Tromey  <tom@tromey.com>
1998
1999         PR tui/24724:
2000         * tui/tui-winsource.c (tui_clear_source_content): Update.
2001         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2002         (tui_update_breakpoint_info): Update.
2003         (tui_set_exec_info_content): Update.
2004         * tui/tui-source.c (tui_set_source_content_nil): Update.
2005         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2006         has_break.
2007         * tui/tui-data.h (enum tui_bp_flag): New.
2008         (tui_bp_flags): New enum flags type.
2009         (struct tui_source_element) <break_mode>: Change type.  Rename
2010         from has_break.
2011         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2012         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2013         constants.
2014         * tui/tui-winsource.h: Fix comment.
2015
2016 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2017
2018         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2019         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2020         (store_fpregs_to_thread)
2021         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2022         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2023         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2024         (IWMMXT_REGS_SIZE): Add define.
2025         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2026         (fetch_vfp_regs, store_vfp_regs)
2027         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2028         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2029
2030 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2031
2032         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2033         defines.
2034         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2035         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2036         (ARM_INT_REGISTER_SIZE): ...to this.
2037         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2038         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2039         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2040         (arm_linux_collect_gregset, supply_nwfpe_register)
2041         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2042         defines.
2043         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2044         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2045         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2046         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2047         (arm_return_in_memory, arm_store_return_value)
2048         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2049         (arm_record_ld_st_multiple): Likewise.
2050         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2051         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2052
2053 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2054
2055         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2056         AARCH64_DISPLACED_MODIFIED_INSNS.
2057         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2058         (aarch64_displaced_step_copy_insn): Likewise.
2059         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2060         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2061         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2062         ARM_DISPLACED_MODIFIED_INSNS.
2063         * arm-tdep.c (arm_gdbarch_init): Likewise.
2064         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2065         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2066         (struct arm_displaced_step_closure): Use
2067         ARM_DISPLACED_MODIFIED_INSNS.
2068
2069 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2070
2071         * features/Makefile: Remove unused xml files.
2072         * features/aarch64.xml: Remove.
2073         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2074         * features/i386/amd64-avx-avx512.xml: Remove.
2075         * features/i386/amd64-avx-linux.xml: Remove.
2076         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2077         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2078         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2079         * features/i386/amd64-avx-mpx.xml: Remove.
2080         * features/i386/amd64-avx.xml: Remove.
2081         * features/i386/amd64-linux.xml: Remove.
2082         * features/i386/amd64-mpx-linux.xml: Remove.
2083         * features/i386/amd64-mpx.xml: Remove.
2084         * features/i386/amd64.xml: Remove.
2085         * features/i386/i386-avx-avx512-linux.xml: Remove.
2086         * features/i386/i386-avx-avx512.xml: Remove.
2087         * features/i386/i386-avx-linux.xml: Remove.
2088         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2089         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2090         * features/i386/i386-avx-mpx-linux.xml: Remove.
2091         * features/i386/i386-avx-mpx.xml: Remove.
2092         * features/i386/i386-avx.xml: Remove.
2093         * features/i386/i386-linux.xml: Remove.
2094         * features/i386/i386-mmx-linux.xml: Remove.
2095         * features/i386/i386-mmx.xml: Remove.
2096         * features/i386/i386-mpx-linux.xml: Remove.
2097         * features/i386/i386-mpx.xml: Remove.
2098         * features/i386/i386.xml: Remove.
2099         * features/i386/x32-avx-avx512-linux.xml: Remove.
2100         * features/i386/x32-avx-linux.xml: Remove.
2101         * features/i386/x32-linux.xml: Remove.
2102
2103 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2104
2105         * regformats/aarch64.dat: Remove.
2106         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2107         * regformats/i386/amd64-avx-linux.dat: Remove.
2108         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2109         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2110         * regformats/i386/amd64-linux.dat: Remove.
2111         * regformats/i386/amd64-mpx-linux.dat: Remove.
2112         * regformats/i386/amd64.dat: Remove.
2113         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2114         * regformats/i386/i386-avx-linux.dat: Remove.
2115         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2116         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2117         * regformats/i386/i386-linux.dat: Remove.
2118         * regformats/i386/i386-mmx-linux.dat: Remove.
2119         * regformats/i386/i386-mpx-linux.dat: Remove.
2120         * regformats/i386/i386.dat: Remove.
2121         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2122         * regformats/i386/x32-avx-linux.dat: Remove.
2123         * regformats/i386/x32-linux.dat: Remove.
2124
2125 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2126
2127         * aarch64-tdep.c: Remove xml self tests.
2128         * amd64-linux-tdep.c: Likewise.
2129         * amd64-tdep.c: Likewise.
2130         * i386-linux-tdep.c: Likewise.
2131         * i386-tdep.c: Likewise.
2132
2133 2019-07-03  Pedro Alves  <palves@redhat.com>
2134
2135         PR cli/24732
2136         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2137         (pipe_cmd_option_defs): New.
2138         (make_pipe_cmd_options_def_group): New.
2139         (pipe_command): Use gdb::option::process_options.
2140         (pipe_command_completer): New function.
2141         (_initialize_cli_cmds): Install completer for "pipe" command.
2142
2143 2019-07-03  Pedro Alves  <palves@redhat.com>
2144
2145         * cli/cli-option.c (union option_value) <string>: New field.
2146         (struct option_def_and_value): Add ctor, move ctor, dtor and
2147         use DISABLE_COPY_AND_ASSIGN.
2148         (option_def_and_value::clear_value): New.
2149         (parse_option, save_option_value_in_ctx, get_val_type_str)
2150         (add_setshow_cmds_for_options): Handle var_string.
2151         * cli-option.h (union option_def::var_address) <string>: New
2152         field.
2153         (struct string_option_def): New.
2154         * maint-test-options.c (struct test_options_opts): Add default
2155         ctor and use DISABLE_COPY_AND_ASSIGN.
2156         <string_opt>: New field.
2157         (test_options_opts::~test_options_opts): New.
2158         (test_options_opts::dump): Also dump "-string".
2159         (test_options_option_defs): Install "string.
2160
2161 2019-07-03  Pedro Alves  <palves@redhat.com>
2162
2163         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2164         option_value with a null enumeration.
2165         (complete_options): Save the option values in the context.
2166         (save_option_value_in_ctx): New, factored out from ...
2167         (process_options): ... here.
2168         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2169         of the function.
2170         * maint-test-options.c (test_options_opts::dump): New, factored
2171         out from ...
2172         (maintenance_test_options_command_mode): ... here.
2173         (maintenance_test_options_command_completion_result): Delete.
2174         (maintenance_test_options_command_completion_text): Update
2175         comment.
2176         (maintenance_show_test_options_completion_result): Change
2177         prototype.  Just print
2178         maintenance_test_options_command_completion_text.
2179         (save_completion_result): New.
2180         (maintenance_test_options_completer_mode): Pass options context to
2181         complete_options, and then save a dump.
2182         (_initialize_maint_test_options): Use add_cmd to install "maint
2183         show test-options-completion-result".
2184
2185 2019-07-03  Pedro Alves  <palves@redhat.com>
2186
2187         * NEWS (New commands): Mention "with" and "maint with".
2188         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2189         (with_command, with_command_completer): New.
2190         (pipe_command): Adjust to new repeat_previous
2191         interface.
2192         (_initialize_cli_cmds): Install the "with" command and its "w"
2193         alias.
2194         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2195         declarations.
2196         * cli/cli-setshow.c (parse_cli_var_uinteger)
2197         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2198         argument strings for all var_types.
2199         (get_setshow_command_value_string): New, factored out from ...
2200         (do_show_command): ... this.
2201         * cli/cli-setshow.h: Include <string>.
2202         (get_setshow_command_value_string): Declare.
2203         * command.h (repeat_previous): Now returns const char *.  Adjust
2204         comment.
2205         * maint.c: Include "cli/cli-cmds.h".
2206         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2207         (_initialize_maint_cmds): Register the "maintenance with" command.
2208         * top.c (repeat_previous): Move bits from pipe_command here:
2209         Return the saved command line, if any; error out if there's no
2210         command to relaunch.
2211
2212 2019-07-03  Pedro Alves  <palves@redhat.com>
2213
2214         * NEWS (New commands): Mention "maint set/show test-settings"
2215         instead of "maint test-settings".
2216         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2217         (maintenance_test_settings_set_list): Rename to ...
2218         (maintenance_set_test_settings_list): ... this.
2219         (maintenance_test_settings_show_list): Rename to  ...
2220         (maintenance_show_test_settings_list): ... this.
2221         (maintenance_test_settings_cmd): Delete.
2222         (maintenance_test_settings_set_cmd): ...
2223         (maintenance_set_test_settings_cmd): ... this.
2224         (maintenance_test_settings_show_cmd): ...
2225         (maintenance_show_test_settings_cmd): ... this.
2226         (maintenance_test_settings_show_value_cmd):
2227         (maintenance_show_test_settings_value_cmd): ... this.
2228         (_initialize_maint_test_settings): No longer install the "maint
2229         test-settings" prefix command.  Rename "maint test-settings set"
2230         to "maint set test-settings", and "maint test-settings show" to
2231         "maint show test-settings".  Adjust all subcommands.
2232
2233 2019-07-03  Pedro Alves  <palves@redhat.com>
2234
2235         * maint-test-settings.c: Fix file's intro comment.  Replace all
2236         references to "test-options" with references to "test-settings",
2237         in comments.
2238
2239 2019-07-03  Pedro Alves  <palves@redhat.com>
2240
2241         * maint-test-settings.c (maintenance_test_settings_xxx)
2242         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2243         New.
2244         (maintenance_test_settings_enums): Use them.
2245         (maintenance_test_settings_enum): Default to
2246         maintenance_test_settings_xxx.
2247         (_initialize_maint_test_settings): Initialize
2248         MAINTENANCE_TEST_SETTINGS_FILENAME.
2249
2250 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2251
2252         * breakpoint.h (remove_breakpoints_inf): Change return type to
2253         void, move function documentation here.
2254         * breakpoint.c (remove_breakpoints_inf): Change return type to
2255         void, move function documentation to header.
2256
2257 2019-07-02  Pedro Alves  <palves@redhat.com>
2258
2259         * NEWS (Completion improvements): Mention "info threads".
2260         * thread.c (struct info_threads_opts, info_threads_option_defs)
2261         (make_info_threads_options_def_group): New.
2262         (info_threads_command): Use gdb::option::process_options.
2263         (info_threads_command_completer): New.
2264         (_initialize_thread): Use gdb::option::build_help to build the
2265         help text for "info threads".
2266
2267 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2268
2269         * defs.h (generic_load): Move from here...
2270         * symfile.h (generic_load): ... to here.  Rename name parameter
2271         to args.
2272         * symfile.c (generic_load): Add comment.
2273
2274 2019-07-01  Tom Tromey  <tromey@adacore.com>
2275
2276         * dwarf2read.c
2277         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2278         declaration of without_params.  Fix formatting.
2279
2280 2019-07-01  Tom Tromey  <tromey@adacore.com>
2281
2282         * ada-exp.y (find_primitive_type): Update.
2283         * ada-lang.h (ada_lookup_symbol): Update.
2284         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2285         parameter.
2286         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2287
2288 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2289
2290         PR breakpoints/24541
2291         * gdbarch.c: Regenerate.
2292         * gdbarch.h: Regenerate.
2293         * gdbarch.sh: Add 'stap_adjust_register'.
2294         * i386-tdep.c: Include '<unordered_set>'.
2295         (i386_stap_adjust_register): New function.
2296         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2297         * stap-probe.c (stap_parse_register_operand): Call
2298         'gdbarch_stap_adjust_register'.
2299
2300 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2301
2302         PR python/24742
2303         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2304         * python/python.c (do_start_initialization): Use 'xmalloc'
2305         instead of 'PyMem_Malloc'.
2306
2307 2019-06-28  Tom Tromey  <tromey@adacore.com>
2308
2309         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2310         for Ada.
2311
2312 2019-06-27  Tom Tromey  <tromey@adacore.com>
2313
2314         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2315         objfile_key.
2316         (arm_find_mapping_symbol, arm_record_special_symbol)
2317         (_initialize_arm_tdep): Update.
2318         (arm_objfile_data_free): Remove.
2319
2320 2019-06-27  Tom Tromey  <tromey@adacore.com>
2321
2322         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2323         to cp_print_static_field.
2324
2325 2019-06-26  Tom Tromey  <tromey@adacore.com>
2326
2327         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2328         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2329         declare.
2330
2331 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2332
2333         * features/aarch64-core.c (create_feature_aarch64_core):
2334         Regenerate.
2335         * features/aarch64-core.xml: Add cpsr flags.
2336
2337 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2338
2339         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2340         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2341
2342 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2343
2344         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2345         field.
2346         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2347         use.
2348         (arm_record_special_symbol): Don't insert new symbol in sorted
2349         position, push it at the end.
2350
2351 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2352
2353         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2354         (arm_mapping_symbol_s): Remove.
2355         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2356         (arm_mapping_symbol_vec): New typedef.
2357         (struct arm_per_objfile): Add constructor.
2358         <section_maps>: Change type to
2359         std::unique_ptr<arm_mapping_symbol_vec[]>.
2360         (arm_compare_mapping_symbols): Remove.
2361         (arm_find_mapping_symbol): Adjust to section_maps type change.
2362         (arm_objfile_data_free): Call delete on arm_per_objfile.
2363         (arm_record_special_symbol): Adjust to section_maps type change.
2364         Allocate arm_per_objfile with new.
2365
2366 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2367
2368         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2369         with the command prefix.
2370
2371 2019-06-25  Tom Tromey  <tom@tromey.com>
2372
2373         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2374         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2375
2376 2019-06-25  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2379         type.
2380         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2381         protected.
2382
2383 2019-06-25  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-winsource.c
2386         (tui_source_window_base::set_is_exec_point_at): Add check against
2387         LOA_ADDRESS.
2388
2389 2019-06-25  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-source.c (tui_set_source_content): Don't check before
2392         xfree.
2393         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2394
2395 2019-06-25  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-winsource.h (tui_update_source_window_as_is)
2398         (tui_alloc_source_buffer, tui_line_is_displayed)
2399         (tui_addr_is_displayed): Change type of win_info.
2400         * tui/tui-winsource.c (tui_update_source_window_as_is)
2401         (tui_clear_source_content, tui_show_source_line)
2402         (tui_show_source_content, tui_source_window_base::refill)
2403         (tui_source_window_base::set_is_exec_point_at)
2404         (tui_source_window_base::set_is_exec_point_at)
2405         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2406         (tui_alloc_source_buffer, tui_line_is_displayed)
2407         (tui_addr_is_displayed): Change type of win_info.  Update.
2408         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2409         (tui_source_window_base::do_make_visible_with_new_height):
2410         Update.
2411         * tui/tui-source.c (tui_set_source_content)
2412         (tui_set_source_content_nil)
2413         (tui_source_window::do_scroll_vertical): Update.
2414         * tui/tui-layout.c (show_layout): Update.
2415         * tui/tui-disasm.c (tui_set_disassem_content)
2416         (tui_disasm_window::do_scroll_vertical): Update.
2417         * tui/tui-data.h (tui_win_content): Remove.
2418         (struct tui_gen_win_info) <content, content_size>: Remove.
2419         (struct tui_source_element): Add initializers and destructor.
2420         (union tui_which_element, struct tui_win_element): Remove.
2421         (struct tui_source_window_base) <content>: New field.
2422         (struct tui_data_window): Remove destructor.
2423         (tui_alloc_content, tui_free_win_content)
2424         (tui_free_all_source_wins_content): Don't declare.
2425         * tui/tui-data.c (tui_initialize_static_data): Update.
2426         (init_content_element, tui_alloc_content): Remove.
2427         (~tui_gen_win_info): Update.
2428         (~tui_data_window, tui_free_all_source_wins_content)
2429         (tui_free_win_content, free_content, free_content_elements):
2430         Remove.
2431
2432 2019-06-25  Tom Tromey  <tom@tromey.com>
2433
2434         * tui/tui-winsource.h (tui_clear_source_content)
2435         (tui_erase_source_content, tui_show_source_content): Change type
2436         of win_info.
2437         * tui/tui-winsource.c (tui_clear_source_content)
2438         (tui_erase_source_content, tui_show_source_content): Change type
2439         of win_info.
2440         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2441         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2442         win_info.
2443         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2444         win_info.
2445         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2446
2447 2019-06-25  Tom Tromey  <tom@tromey.com>
2448
2449         * tui/tui-winsource.c (tui_clear_source_content)
2450         (tui_source_window_base::set_is_exec_point_at): Update.
2451         * tui/tui-source.c (tui_set_source_content_nil): Update.
2452         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2453         a bool.
2454         * tui/tui-data.c (init_content_element): Update.
2455
2456 2019-06-25  Tom Tromey  <tom@tromey.com>
2457
2458         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2459         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2460         * tui/tui-layout.c (init_and_make_win): Update.
2461         * tui/tui.h (enum tui_win_type): Update.
2462         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2463         tui_win_is_auxillary.
2464         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2465         tui_win_is_auxillary.
2466
2467 2019-06-25  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2470         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2471         (tui_delete_data_content_windows, tui_display_all_data)
2472         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2473         Update.
2474         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2475         * tui/tui-regs.c (tui_last_regs_line_no)
2476         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2477         (tui_show_registers): Update.
2478         (tui_show_register_group): Return void.  Update.
2479         (tui_display_registers_from, tui_display_reg_element_at_line)
2480         (tui_display_registers_from_line, tui_check_register_values):
2481         Update.
2482         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2483         member.
2484         (struct tui_data_window) <regs_content>: Now a std::vector.
2485         <regs_content_count>: Remove.
2486         (tui_add_content_elements, tui_free_data_content): Don't declare.
2487         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2488         (init_content_element): Remove DATA_WIN case.  Add assert.
2489         (tui_add_content_elements): Remove.
2490         (tui_data_window): Update.
2491         (tui_free_data_content): Remove.
2492         (free_content_elements): Remove DATA_WIN case.
2493
2494 2019-06-25  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-data.c (tui_data_item_window): Update.
2497         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2498         * tui/tui-windata.c (tui_display_all_data)
2499         (tui_display_data_from_line): Update.
2500         (tui_check_data_values): Remove.
2501         * tui/tui-regs.c (tui_show_register_group)
2502         (tui_display_reg_element_at_line): Update.
2503         * tui/tui-hooks.c (tui_register_changed)
2504         (tui_refresh_frame_and_register_information): Call
2505         tui_check_register_values.
2506         * tui/tui-data.h (struct tui_data_window) <data_content,
2507         data_content_count, data_type>: Remove.
2508         (enum tui_data_type): Remove.
2509
2510         * tui/tui-data.c (tui_data_window::clear_detail)
2511         (~tui_data_window): Update.
2512
2513 2019-06-25  Tom Tromey  <tom@tromey.com>
2514
2515         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2516         declare.
2517         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2518         Rename from tui_first_data_item_displayed.  Update.
2519         (tui_data_window::refresh_all)
2520         (tui_data_window::do_scroll_vertical): Update.
2521         * tui/tui-data.h (struct tui_data_window)
2522         <first_data_item_displayed>: Declare new method.
2523
2524 2019-06-25  Tom Tromey  <tom@tromey.com>
2525
2526         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2527         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2528         contents...
2529         (tui_initialize_static_data): ...here.
2530
2531 2019-06-25  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2534         (tui_display_registers_from, tui_check_register_values): Update.
2535         (tui_display_register): Remove win_info parameter; update.
2536         (tui_get_register): Change type of parameters.
2537         * tui/tui-data.h (struct tui_data_element): Remove.
2538         (union tui_which_element) <data>: Remove.
2539         <data_window>: Change type.
2540         (struct tui_data_item_window): New.
2541         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2542         case.  Add assert.
2543         (~tui_data_item_window): New destructor.
2544         (free_content_elements): Remove DATA_ITEM_WIN case.
2545
2546 2019-06-25  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2549         Remove.
2550
2551 2019-06-25  Tom Tromey  <tom@tromey.com>
2552
2553         * tui/tui-data.h (struct tui_command_element): Remove.
2554         (union tui_which_element) <command>: Remove.
2555         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2556         assert.
2557         (free_content_elements): Remove CMD_WIN case.
2558
2559 2019-06-25  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-layout.c (tui_set_layout): Update.
2562         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2563         * tui/tui-data.c (layout_def): Update.
2564
2565 2019-06-25  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2568         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2569         (tui_source_window_base::set_new_height): Update.
2570         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2571         Update.
2572         (tui_set_locator_fullname, tui_set_locator_info)
2573         (tui_show_frame_info): Update.
2574         * tui/tui-source.c (tui_set_source_content)
2575         (tui_source_is_displayed): Update.
2576         * tui/tui-layout.c (show_source_disasm_command, show_data)
2577         (show_source_or_disasm_and_command): Update.
2578         * tui/tui-disasm.c (tui_set_disassem_content)
2579         (tui_get_begin_asm_address): Update.
2580         * tui/tui-data.h (struct tui_locator_element): Remove.
2581         (union tui_which_element) <locator>: Remove.
2582         (struct tui_locator_window): New.
2583         (tui_locator_win_info_ptr): Change return type.
2584         * tui/tui-data.c (_locator): Change type.
2585         (tui_locator_win_info_ptr): Change return type.
2586         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2587         (tui_alloc_content): Add assert.
2588
2589 2019-06-25  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-winsource.c
2592         (tui_exec_info_window::maybe_allocate_content): New method.
2593         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2594         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2595         (make_source_or_disasm_window): Add cast.
2596         * tui/tui-data.h (union tui_which_element) <simple_string>:
2597         Remove.
2598         (struct tui_source_info): New.
2599         (struct tui_source_window_base) <execution_info>: Change type.
2600         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2601         case, and add assert.
2602         (tui_alloc_content): Add assert.
2603
2604 2019-06-25  Tom Tromey  <tom@tromey.com>
2605
2606         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2607         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2608         * tui/tui-data.c (tui_alloc_win_info): Remove.
2609
2610 2019-06-25  Tom Tromey  <tom@tromey.com>
2611
2612         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2613         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2614         can_highlight.
2615
2616 2019-06-25  Tom Tromey  <tom@tromey.com>
2617
2618         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2619         make_visible_with_new_height method.
2620         (tui_win_info::make_visible_with_new_height): New method.
2621         (tui_source_window_base::do_make_visible_with_new_height)
2622         (tui_data_window::do_make_visible_with_new_height)
2623         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2624         (make_visible_with_new_height): Remove.
2625         (tui_resize_all, tui_adjust_win_heights): Use
2626         make_visible_with_new_height method.
2627         * tui/tui-data.h (struct tui_win_info)
2628         <do_make_visible_with_new_height, make_visible_with_new_height>:
2629         New methods.
2630         (struct tui_source_window_base, struct tui_data_window)
2631         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2632         methods.
2633
2634 2019-06-25  Tom Tromey  <tom@tromey.com>
2635
2636         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2637         method.
2638         (update_tab_width): Call update_tab_width method.
2639         * tui/tui-data.h (struct tui_win_info)
2640         (struct tui_source_window_base) <update_tab_width>: New methods.
2641
2642 2019-06-25  Tom Tromey  <tom@tromey.com>
2643
2644         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2645         parameter.
2646         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2647         parameter.
2648         (tui_gen_win_info::make_visible): Update.
2649         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2650         parameter.
2651         * tui/tui-data.h (enum tui_box): New enum.
2652         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2653
2654 2019-06-25  Tom Tromey  <tom@tromey.com>
2655
2656         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2657         init_and_make_win for EXEC_INFO_WIN.
2658         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2659         longer inline.
2660         (struct tui_win_info) <~tui_win_info>: Inline.
2661         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2662         Don't declare.
2663         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2664         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2665         Remove.
2666         (tui_initialize_static_data): Update.
2667         (~tui_gen_win_info): Handle more cleanup here.
2668         (~tui_source_window_base): Delete "execution_info".
2669         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2670
2671 2019-06-25  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-layout.c (make_command_window): Don't set
2674         can_highlight.
2675         (show_source_disasm_command): Call the reset method.
2676         (show_data): Don't set can_highlight.  Call the reset method.
2677         (tui_gen_win_info::reset): Rename from init_gen_win_info
2678         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2679         (show_source_or_disasm_and_command): Call the reset method.
2680         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2681         (struct tui_cmd_window): Set can_highlight.
2682
2683 2019-06-25  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2686         from make_visible.
2687         (tui_make_visible, tui_make_invisible): Rewrite.
2688         (tui_win_info::make_visible): Remove.
2689         (tui_source_window_base::make_visible): Update.
2690         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2691         method.  Moved from...
2692         (struct tui_win_info) <make_visible>: ...here.
2693
2694 2019-06-25  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-winsource.c
2697         (tui_source_window_base::do_scroll_horizontal): Remove direction
2698         parameter.
2699         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2700         direction parameter.
2701         * tui/tui-win.c (tui_win_info::forward_scroll)
2702         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2703         (tui_win_info::right_scroll): Update.
2704         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2705         direction parameter.
2706         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2707         direction parameter.
2708         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2709         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2710         Remove direction parameter.
2711         (struct tui_source_window_base, struct tui_source_window)
2712         (struct tui_disasm_window, struct tui_data_window)
2713         (struct tui_cmd_window): Update.
2714
2715 2019-06-25  Tom Tromey  <tom@tromey.com>
2716
2717         * tui/tui-winsource.h (tui_set_exec_info_content)
2718         (tui_show_exec_info_content, tui_erase_exec_info_content)
2719         (tui_clear_exec_info_content, tui_update_exec_info): Change
2720         argument to tui_source_window_base.
2721         * tui/tui-winsource.c (tui_set_exec_info_content)
2722         (tui_show_exec_info_content, tui_erase_exec_info_content)
2723         (tui_clear_exec_info_content, tui_update_exec_info): Change
2724         argument to tui_source_window_base.
2725
2726 2019-06-25  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2729         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2730
2731 2019-06-25  Tom Tromey  <tom@tromey.com>
2732
2733         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2734         check.
2735
2736 2019-06-25  Tom Tromey  <tom@tromey.com>
2737
2738         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2739         type to void.
2740         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2741         type to void.
2742         * tui/tui-source.c (tui_set_source_content): Update.
2743         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2744
2745 2019-06-25  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-win.c (window_name_completer, tui_set_focus)
2748         (tui_all_windows_info): Use name method.
2749         * tui/tui-data.h (struct tui_gen_win_info)
2750         (struct tui_source_window, struct tui_disasm_window)
2751         (struct tui_data_window, struct tui_cmd_window) <name>: New
2752         method.
2753         (tui_win_name): Don't declare.
2754         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2755         (tui_win_name): Remove.
2756
2757 2019-06-25  Tom Tromey  <tom@tromey.com>
2758
2759         * tui/tui-winsource.h (tui_update_source_window)
2760         (tui_update_source_window_as_is): Change parameter type.
2761         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2762         to be a tui_source_window_base.
2763         (tui_update_source_window_as_is): Likewise.
2764         * tui/tui-win.c (make_visible_with_new_height): Update.
2765
2766 2019-06-25  Tom Tromey  <tom@tromey.com>
2767
2768         * tui/tui-winsource.c (tui_erase_source_content)
2769         (tui_show_source_content, tui_show_exec_info_content)
2770         (tui_erase_exec_info_content): Use refresh_window method.
2771         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2772         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2773         from tui_refresh_win.
2774         (tui_data_window::refresh_window): New method.
2775         (tui_win_info::refresh, tui_source_window_base::refresh)
2776         (tui_refresh_all): Use refresh_window method.
2777         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2778         method.
2779         * tui/tui-regs.c (tui_display_register): Call refresh_window
2780         method.
2781         * tui/tui-layout.c (show_source_disasm_command)
2782         (show_source_or_disasm_and_command): Call refresh_window method.
2783         * tui/tui-data.h (struct tui_gen_win_info)
2784         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2785         New method.
2786
2787 2019-06-25  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui.c (tui_rl_other_window, tui_enable)
2790         (tui_is_window_visible, tui_get_command_dimension): Update.
2791         * tui/tui-winsource.c (tui_update_source_window_as_is)
2792         (tui_clear_source_content, tui_erase_source_content)
2793         (tui_show_source_line, tui_source_window_base::refill)
2794         (tui_source_window_base::do_scroll_horizontal)
2795         (tui_source_window_base::set_is_exec_point_at)
2796         (tui_update_breakpoint_info, tui_set_exec_info_content)
2797         (tui_alloc_source_buffer, tui_line_is_displayed)
2798         (tui_addr_is_displayed): Update.
2799         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2800         (tui_check_and_display_highlight_if_needed)
2801         (tui_win_info::make_visible, tui_win_info::refresh)
2802         (tui_refresh_all): Update.
2803         * tui/tui-windata.c (tui_first_data_item_displayed)
2804         (tui_delete_data_content_windows, tui_erase_data_content)
2805         (tui_display_all_data, tui_data_window::refresh_all)
2806         (tui_check_data_values): Update.
2807         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2808         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2809         (tui_win_info::backward_scroll, tui_refresh_all_win)
2810         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2811         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2812         (tui_source_window_base::set_new_height)
2813         (tui_data_window::set_new_height)
2814         (make_invisible_and_set_new_height)
2815         (make_visible_with_new_height, new_height_ok)
2816         (parse_scrolling_args): Update.
2817         * tui/tui-stack.c (tui_show_frame_info): Update.
2818         * tui/tui-source.c (tui_set_source_content)
2819         (tui_set_source_content_nil, tui_source_is_displayed)
2820         (tui_source_window::do_scroll_vertical): Update.
2821         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2822         (tui_display_registers_from, tui_display_reg_element_at_line)
2823         (tui_check_register_values, tui_reg_command): Update.
2824         * tui/tui-layout.c (tui_default_win_height)
2825         (show_source_disasm_command, show_data, init_and_make_win)
2826         (show_source_or_disasm_and_command): Update.
2827         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2828         (tui_redisplay_readline, tui_mld_flush)
2829         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2830         (tui_getc): Update.
2831         * tui/tui-disasm.c (tui_set_disassem_content)
2832         (tui_disasm_window::do_scroll_vertical): Update.
2833         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2834         Now virtual.
2835         (struct tui_win_info): Derive from tui_gen_win_info.
2836         <~tui_win_info>: Mark as override.
2837         <generic>: Remove member.
2838         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2839         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2840         (~tui_data_window, ~tui_win_info)
2841         (tui_free_all_source_wins_content): Update.
2842         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2843
2844 2019-06-25  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-layout.c (init_and_make_win): Use new.
2847         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2848         destructor, initializers.
2849         (tui_alloc_generic_win_info): Don't declare.
2850         * tui/tui-data.c (_locator): Add argument to constructor.
2851         (source_win, disasm_win): New globals.
2852         (exec_info): Remove.
2853         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2854         Update.
2855         (tui_alloc_generic_win_info): Remove.
2856         (init_content_element): Use new.
2857         (tui_win_info::tui_win_info): Update.
2858         (free_content_elements) <case DATA_WIN>: Use delete.
2859
2860 2019-06-25  Tom Tromey  <tom@tromey.com>
2861
2862         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2863         * tui/tui-windata.c (tui_first_data_item_displayed)
2864         (tui_delete_data_content_windows): Update.
2865         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2866         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2867         (tui_display_registers_from, tui_check_register_values): Update.
2868         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2869         pointer.
2870         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2871         window.
2872         (tui_free_data_content): Update.
2873         (free_content_elements) <case DATA_WIN>: Free the window.
2874
2875 2019-06-25  Tom Tromey  <tom@tromey.com>
2876
2877         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2878         Update.
2879         * tui/tui-layout.c (make_command_window)
2880         (show_source_disasm_command, show_data, init_and_make_win)
2881         (show_source_or_disasm_and_command): Update.
2882         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2883         method.
2884         <can_highight, is_highlighted>: Now bool.
2885         (tui_set_win_highlight): Don't declare.
2886         * tui/tui-data.c (tui_set_win_highlight): Remove.
2887
2888 2019-06-25  Tom Tromey  <tom@tromey.com>
2889
2890         * tui/tui-wingeneral.c (make_visible): Remove check of window
2891         type.
2892
2893 2019-06-25  Tom Tromey  <tom@tromey.com>
2894
2895         * tui/tui-win.c (tui_win_info::max_height)
2896         (tui_cmd_window::max_height): New methods.
2897         (new_height_ok): Call max_height.
2898         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2899         <max_height>: New method.
2900
2901 2019-06-25  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-win.c (tui_source_window_base::set_new_height)
2904         (tui_data_window::set_new_height): New methods.
2905         (make_invisible_and_set_new_height): Call set_new_height method.
2906         * tui/tui-data.h (struct tui_win_info)
2907         (struct tui_source_window_base, struct tui_data_window)
2908         <set_new_height>: New method.
2909
2910 2019-06-25  Tom Tromey  <tom@tromey.com>
2911
2912         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2913         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2914         tui_refresh_data_win.
2915         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2916         method.
2917         (tui_refresh_all_win): Call the refresh_all method.
2918         (tui_set_focus): Likewise.
2919         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2920         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2921         Likewise.
2922
2923 2019-06-25  Tom Tromey  <tom@tromey.com>
2924
2925         * tui/tui-winsource.h (tui_refill_source_window)
2926         (tui_set_is_exec_point_at): Don't declare.
2927         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2928         (tui_source_window_base::refill): Rename from
2929         tui_refill_source_window.
2930         (tui_source_window_base::do_scroll_horizontal): Update.
2931         (tui_source_window_base::set_is_exec_point_at): Rename from
2932         tui_set_is_exec_point_at.
2933         (tui_update_all_breakpoint_info): Update.
2934         * tui/tui-stack.c (tui_show_frame_info): Update.
2935         * tui/tui-layout.c (show_data): Add cast.
2936         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2937         * tui/tui-data.h (struct tui_source_window_base) <refill,
2938         set_is_exec_point_at>: New methods.
2939         (tui_source_windows, tui_add_to_source_windows): Update types.
2940         (tui_add_to_source_windows): Remove redundant declaration.
2941         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2942         (tui_source_windows): Change return type.
2943         (tui_clear_source_windows_detail): Update.
2944         (tui_add_to_source_windows): Change type of parameter.
2945         (tui_free_all_source_wins_content): Update.
2946
2947 2019-06-25  Tom Tromey  <tom@tromey.com>
2948
2949         * tui/tui-wingeneral.c (tui_win_info::refresh)
2950         (tui_source_window_base::refresh): New methods.
2951         (tui_refresh_all): Call the refresh method.
2952         * tui/tui-data.h (struct tui_win_info)
2953         (struct tui_source_window_base) <refresh>: New method.
2954
2955 2019-06-25  Tom Tromey  <tom@tromey.com>
2956
2957         * tui/tui.h (tui_is_window_visible): Return bool.
2958         * tui/tui.c (tui_is_window_visible): Return bool.
2959         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2960         (tui_make_visible, tui_make_invisible)
2961         (tui_win_info::make_visible)
2962         (tui_source_window_base::make_visible, make_all_visible)
2963         (tui_make_all_visible, tui_make_all_invisible): Update.
2964         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2965         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2966         bool.
2967         (struct tui_win_info, struct tui_source_window_base)
2968         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2969         * tui/tui-data.c (tui_init_generic_part): Update.
2970
2971 2019-06-25  Tom Tromey  <tom@tromey.com>
2972
2973         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2974         (tui_source_window_base::make_visible): New methods.
2975         (make_all_visible): Make method call.
2976         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2977         (struct tui_source_window_base, struct tui_cmd_window): Override
2978         make_visible.
2979         (tui_win_is_source_type): Don't declare.
2980         * tui/tui-data.c (tui_win_is_source_type): Remove.
2981
2982 2019-06-25  Tom Tromey  <tom@tromey.com>
2983
2984         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2985         NULL check.
2986
2987 2019-06-25  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2990         Inline constructor.  Add initializers for members.
2991         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2992         constructors; now inline in class.
2993
2994 2019-06-25  Tom Tromey  <tom@tromey.com>
2995
2996         * tui/tui-regs.c (tui_show_registers): Update.
2997         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2998         bool.
2999         * tui/tui-data.c (tui_data_window::clear_detail)
3000         (tui_data_window): Update.
3001
3002 2019-06-25  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-windata.c (tui_display_all_data)
3005         (tui_display_data_from_line, tui_display_data_from)
3006         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3007         Update.
3008         * tui/tui-regs.c (tui_last_regs_line_no)
3009         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3010         (tui_show_registers, tui_show_register_group)
3011         (tui_display_registers_from, tui_display_reg_element_at_line)
3012         (tui_display_registers_from_line, tui_check_register_values)
3013         (tui_reg_next, tui_reg_prev): Update.
3014         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3015         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3016         tui_data_window.
3017         (struct tui_win_info) <detail>: Remove.  Add new fields from
3018         tui_data_info.
3019         (TUI_DATA_WIN): Add cast.
3020         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3021         (~tui_data_window): Simplify.
3022
3023 2019-06-25  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-layout.c (show_source_disasm_command)
3026         (show_source_or_disasm_and_command): Update.
3027         * tui/tui-io.c (update_cmdwin_start_line)
3028         (tui_redisplay_readline): Update.
3029         * tui/tui-data.h (struct tui_command_info): Remove.
3030         (struct tui_win_info) <detail>: Remove command_info member.
3031         (struct tui_data_window) <start_line>: New member, from
3032         tui_command_info.
3033         (TUI_CMD_WIN): Add casts.
3034
3035 2019-06-25  Tom Tromey  <tom@tromey.com>
3036
3037         * tui/tui-winsource.c (tui_update_source_window)
3038         (tui_refill_source_window)
3039         (tui_source_window_base::do_scroll_horizontal)
3040         (tui_update_breakpoint_info, tui_set_exec_info_content)
3041         (tui_show_exec_info_content, tui_erase_exec_info_content)
3042         (tui_clear_exec_info_content): Update.
3043         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3044         Update.
3045         * tui/tui-win.c (make_invisible_and_set_new_height)
3046         (make_visible_with_new_height): Update.
3047         * tui/tui-source.c (tui_set_source_content)
3048         (tui_show_symtab_source): Update.
3049         * tui/tui-layout.c (extract_display_start_addr)
3050         (show_source_disasm_command, show_data)
3051         (make_source_or_disasm_window)
3052         (show_source_or_disasm_and_command): Update.
3053         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3054         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3055         "gdbarch".
3056         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3057         to tui_source_window_base.
3058         (struct tui_win_info) <detail>: Remove source_info member.
3059         (struct tui_source_window_base) <has_locator>: Inline.
3060         Move contents from tui_source_info; rename has_locator member to
3061         m_has_locator.
3062         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3063         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3064         header file.
3065         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3066         Simplify.
3067         (tui_free_all_source_wins_content): Cast to
3068         tui_source_window_base.
3069
3070 2019-06-25  Tom Tromey  <tom@tromey.com>
3071
3072         * tui/tui-win.c (make_invisible_and_set_new_height)
3073         (make_visible_with_new_height): Call has_locator method.
3074         * tui/tui-layout.c (show_source_disasm_command, show_data)
3075         (show_source_or_disasm_and_command): Update for bool change.
3076         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3077         (tui_win_info) <has_locator>: New method.
3078         (struct tui_source_window_base) <has_locator>: New method.
3079         (tui_win_has_locator): Don't declare.
3080         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3081         from tui_win_has_locator.
3082         (tui_source_window_base): Use false, not FALSE.
3083
3084 2019-06-25  Tom Tromey  <tom@tromey.com>
3085
3086         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3087         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3088         clear_detail method directly.
3089         (tui_clear_win_detail): Remove.
3090
3091 2019-06-25  Tom Tromey  <tom@tromey.com>
3092
3093         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3094         "this", not TUI_DISASM_WIN.
3095
3096 2019-06-25  Tom Tromey  <tom@tromey.com>
3097
3098         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3099         declare.
3100         * tui/tui-winsource.c
3101         (tui_source_window_base::do_scroll_horizontal): Rename from
3102         tui_horizontal_source_scroll.
3103         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3104         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3105         from tui_vertical_data_scroll.
3106         * tui/tui-win.h (tui_scroll): Don't declare.
3107         * tui/tui-win.c (tui_win_info::forward_scroll)
3108         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3109         (tui_win_info::right_scroll): Rename and update.
3110         (tui_scroll_forward_command, tui_scroll_backward_command)
3111         (tui_scroll_left_command, tui_scroll_right_command): Update.
3112         (tui_scroll): Remove.
3113         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3114         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3115         from tui_vertical_source_scroll.
3116         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3117         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3118         from tui_vertical_disassem_scroll.
3119         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3120         do_scroll_horizontal>: New methods.
3121         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3122         Likewise.
3123         (struct tui_source_window_base): Add do_scroll_horizontal.
3124         (struct tui_source_window, struct tui_disasm_window): Add
3125         do_scroll_vertical.
3126         (struct tui_data_window, struct tui_cmd_window): Add
3127         do_scroll_horizontal and do_scroll_vertical.
3128         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3129
3130 2019-06-25  Tom Tromey  <tom@tromey.com>
3131
3132         * tui/tui-data.h (struct tui_source_window_base): New struct.
3133         (struct tui_source_window): Derive from tui_source_window_base.
3134         (struct tui_disasm_window): New struct.
3135         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3136         from tui_source_window::clear_detail.
3137         (tui_source_window_base): Rename from tui_source_window.
3138         (~tui_source_window_base): Rename from ~tui_source_window.
3139         (tui_alloc_win_info): Create a tui_disasm_window.
3140
3141 2019-06-25  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-data.h (struct tui_source_window)
3144         (struct tui_data_window): Declare destructors.
3145         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3146         destructors.
3147         (tui_win_info): Simplify.
3148
3149 2019-06-25  Tom Tromey  <tom@tromey.com>
3150
3151         * tui/tui-winsource.c (tui_display_main)
3152         (tui_update_source_windows_with_addr)
3153         (tui_update_all_breakpoint_info): Update.
3154         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3155         (new_height_ok, parse_scrolling_args): Update.
3156         * tui/tui-stack.c (tui_show_frame_info): Update.
3157         * tui/tui-data.h (struct tui_list): Remove.
3158         (tui_source_windows): Return a reference to a std::vector.
3159         * tui/tui-data.c (source_windows): Now a std::vector.
3160         (tui_source_windows): Change return type.
3161         (tui_clear_source_windows): Rewrite.
3162         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3163         (tui_free_all_source_wins_content): Rewrite.
3164
3165 2019-06-25  Tom Tromey  <tom@tromey.com>
3166
3167         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3168         (struct tui_data_window, struct tui_cmd_window): Declare
3169         clear_detail method.
3170         * tui/tui-data.c (tui_source_window::clear_detail)
3171         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3172         methods.
3173         (tui_clear_win_detail): Simplify.
3174
3175 2019-06-25  Tom Tromey  <tom@tromey.com>
3176
3177         * tui/tui-layout.c (make_source_window, make_disasm_window)
3178         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3179         Return the new window.
3180         (show_source_disasm_command, show_data)
3181         (show_source_or_disasm_and_command): Update.
3182
3183 2019-06-25  Tom Tromey  <tom@tromey.com>
3184
3185         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3186         parameter.  Return the new window.
3187         (show_source_disasm_command): Update and remove NULL check.
3188         (show_source_or_disasm_and_command): Update.
3189
3190 2019-06-25  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3193
3194 2019-06-25  Tom Tromey  <tom@tromey.com>
3195
3196         * tui/tui-data.h (struct tui_win_info): Make constructor
3197         protected.  Make destructor virtual.  Add initializers.
3198         (tui_source_window, tui_data_window, tui_cmd_window): New
3199         classes.
3200         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3201         constructor.  Add "type" parameter.
3202         (tui_source_window, tui_data_window, tui_cmd_window): New
3203         constructors.
3204         (tui_alloc_win_info): Instantiate the appropriate subclass.
3205
3206 2019-06-25  Tom Tromey  <tom@tromey.com>
3207
3208         * tui/tui-win.c (tui_resize_all): Use delete.
3209         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3210         destructor.
3211         (tui_free_window): Don't declare.
3212         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3213         Update.
3214
3215 2019-06-25  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-data.h (struct tui_win_info): Add constructor.
3218         * tui/tui-data.c (tui_alloc_win_info): Use new.
3219         (tui_free_window): Use delete.
3220
3221 2019-06-22  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3224         declare.
3225         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3226
3227 2019-06-22  Tom Tromey  <tom@tromey.com>
3228
3229         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3230         declare.
3231         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3232
3233 2019-06-22  Tom de Vries  <tdevries@suse.de>
3234
3235         * dwarf2read.c (create_addrmap_from_aranges)
3236         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3237         instead of '%zu'.
3238
3239 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3240
3241         * dwarf2read.h (dwarf2_section_info_def): Remove.
3242         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3243         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3244         std::vector<dwarf2_section_info>.
3245         (struct dwo_file) <~dwo_file>: Remove.
3246         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3247         types field.
3248         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3249         (dwarf2_read_debug_names): Likewise.
3250         (create_debug_types_hash_table): Change parameter type to
3251         array_view, adjust code accordingly.
3252         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3253         (partial_die_info::fixup): Likewise.
3254         (determine_prefix): Likewise.
3255         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3256
3257 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3258
3259         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3260         gdb_bfd_ref_ptr.
3261         <~dwo_file>: Remove call to gdb_bfd_unref.
3262         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3263         gdb_bfd_ref_ptr::get.
3264
3265 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3266
3267         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3268         type to htab_up.
3269         * dwarf2read.c (struct dwo_file): Initialize fields.
3270         <~dwo_file>: New.
3271         (free_dwo_file): Remove, move content to ~dwo_file.
3272         (struct dwo_file_deleter): Remove.
3273         (dwo_file_up>: Remove custom deleter.
3274         (free_dwo_files): Remove.
3275         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3276         dwo_files.
3277         (process_skeletonless_type_units): Call unique_ptr::get.
3278         (allocate_dwo_file_hash_table): Add deleter to created hash
3279         table.  Change return type to htab_up.
3280         (lookup_dwo_file_slot): Don't memset dwo_file, call
3281         unique_ptr::get.
3282         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3283         (create_dwo_unit_in_dwp_v2): Likewise.
3284         (open_and_init_dwo_file): Likewise.
3285         (free_dwo_file_from_slot): Remove.
3286
3287 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3288
3289         * dwarf2read.h (struct dwarf2_section_info) <readin,
3290         is_virtual>: Change type to bool.
3291         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3292         true instead of 1.
3293
3294 2019-06-19  Tom Tromey  <tom@tromey.com>
3295
3296         * tui/tui-data.h (tui_init_content_element): Don't declare.
3297
3298 2019-06-19  Tom Tromey  <tom@tromey.com>
3299
3300         * tui/tui-data.h (tui_init_win_info): Don't declare.
3301
3302 2019-06-19  Tom de Vries  <tdevries@suse.de>
3303
3304         * dwarf2read.h (abstract_to_concrete): Change type to
3305         std::unordered_map<sect_offset, std::vector<sect_offset>,
3306         gdb::hash_enum<sect_offset>>.
3307
3308 2019-06-19  Tom Tromey  <tromey@adacore.com>
3309
3310         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3311         EVAL_AVOID_SIDE_EFFECTS specially.
3312
3313 2019-06-19  Tom Tromey  <tromey@adacore.com>
3314
3315         * source-cache.c (highlighter): New global.
3316         (source_cache::get_source_lines): Create a highlighter on demand.
3317
3318 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3319
3320         * defs.h (deprecated_interactive_hook): Delete declaration.
3321         * interps.c (clear_interpreter_hooks): Remove use of
3322         deprecated_interactive_hook.
3323         * top.c (deprecated_interactive_hook): Delete definition.
3324         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3325
3326 2019-06-18  Tom de Vries  <tdevries@suse.de>
3327
3328         PR gdb/24515
3329         * dwarf2read.h (abstract_to_concrete): Change type from
3330         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3331         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3332         * dwarf2read.c (read_variable): Update.
3333         (dwarf2_fetch_die_loc_sect_off): Update.
3334
3335 2019-06-17  Tom de Vries  <tdevries@suse.de>
3336
3337         PR gdb/24617
3338         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3339         accessing parent[parent_len - 1].
3340
3341 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3342
3343         PR gdb/24364
3344         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3345         call dtrace_process_dof with NULL dof.
3346
3347 2019-06-16  Tom de Vries  <tdevries@suse.de>
3348
3349         PR gdb/24445
3350         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3351
3352 2019-06-16  Tom Tromey  <tom@tromey.com>
3353
3354         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3355         (make_all_visible): Use address of member.
3356
3357 2019-06-16  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3360         (tui_free_window, free_content, free_content_elements): Remove
3361         unnecessary cast.
3362         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3363         cast.
3364         * tui/tui-regs.c (tui_show_register_group)
3365         (tui_display_registers_from, tui_display_reg_element_at_line):
3366         Remove unnecessary cast.
3367
3368 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3369
3370         * linux-nat.c (normal_mask): Delete.
3371         (_initialize_linux_nat): Don't initialise normal_mask.
3372
3373 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3374
3375         PR gdb/24445
3376         * dwarf-index-write.h (write_psymtabs_to_index): Add
3377         dwz_basename parameter.
3378         * dwarf-index-write.c (write_gdbindex): Move file writing to
3379         write_gdbindex_1.  Change return type void.
3380         (assert_file_size): Move up, remove filename parameter.
3381         (write_gdbindex_1): New function.
3382         (write_debug_names): Change return type to void, call
3383         assert_file_size.
3384         (struct index_wip_file): New struct.
3385         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3386         file logic to index_wip_file.  Write index for dwz file if
3387         needed.
3388         (save_gdb_index_command): Pass basename of dwz file, if present.
3389         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3390         build-id of dwz file, if present.
3391         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3392         (dwarf2_get_dwz_file): Likewise.
3393         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3394         (dwarf2_get_dwz_file): Likewise.
3395
3396 2019-06-16  Tom Tromey  <tom@tromey.com>
3397
3398         * coffread.c (process_coff_symbol): Use xstrdup.
3399         * value.c (create_internalvar): Use xstrdup.
3400
3401 2019-06-16  Tom Tromey  <tom@tromey.com>
3402
3403         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3404         * breakpoint.c (stopin_command, stopat_command)
3405         (until_break_command, decode_location_default): Remove unnecessary
3406         cast.
3407         * utils.c (subset_compare): Remove unnecessary cast.
3408         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3409         cast.
3410         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3411         cast.
3412         * infcmd.c (path_command): Remove unnecessary cast.
3413         * coffread.c (decode_type): Remove unnecessary cast.
3414         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3415         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3416         * tui/tui-stack.c (tui_show_locator_content)
3417         (tui_show_frame_info): Remove unnecessary cast.
3418         * tui/tui-win.c (tui_scroll_forward_command)
3419         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3420         (parse_scrolling_args): Remove unnecessary cast.
3421         * tui/tui-data.c (init_win_info, tui_del_window)
3422         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3423         (free_content_elements): Remove unnecessary cast.
3424         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3425         unnecessary cast.
3426         * tui/tui-source.c (tui_set_source_content)
3427         (tui_vertical_source_scroll): Remove unnecessary cast.
3428         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3429         cast.
3430         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3431         * tui/tui-regs.c (tui_display_registers_from)
3432         (tui_display_register): Remove unnecessary cast.
3433         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3434         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3435         (make_visible): Remove unnecessary cast.
3436         * tui/tui-winsource.c (tui_erase_source_content)
3437         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3438         unnecessary cast.
3439         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3440         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3441         * stabsread.c (read_type, read_array_type, read_range_type):
3442         Remove unnecessary cast.
3443         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3444         (parse_symbol, parse_type, upgrade_type, parse_external)
3445         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3446         unnecessary cast.
3447         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3448
3449 2019-06-16  Tom Tromey  <tom@tromey.com>
3450
3451         * tui/tui-data.c (tui_alloc_generic_win_info)
3452         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3453         checks.
3454
3455 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3456             Andrew Burgess  <andrew.burgess@embecosm.com>
3457
3458         * f-typeprint.c (f_print_type): Don't return early for not
3459         associated or not allocated types.
3460         (f_type_print_varspec_suffix): Add print_rank parameter and print
3461         ranks of array types in case they dangling.
3462         (f_type_print_base): Add print_rank parameter.
3463
3464 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3465
3466         * NEWS: Mention new MI commands.
3467         * break-catch-throw.c (enum exception_event_kind): Move to
3468         breakpoint.h.
3469         (print_mention_exception_catchpoint): Output text as a single
3470         message.
3471         (catch_exception_command_1): Rename to...
3472         (catch_exception_event): ...this, make non-static, update header
3473         command, and change some parameter types.
3474         (catch_catch_command): Update for changes to
3475         catch_exception_command_1.
3476         (catch_throw_command): Likewise.
3477         (catch_rethrow_command): Likewise.
3478         * breakpoint.c (enum exception_event_kind): Delete.
3479         * breakpoint.h (enum exception_event_kind): Moved here from
3480         break-catch-throw.c.
3481         (catch_exception_event): Declare.
3482         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3483         (mi_cmd_catch_throw): New function.
3484         (mi_cmd_catch_rethrow): New function.
3485         (mi_cmd_catch_catch): New function.
3486         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3487         'catch-catch' entries.
3488         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3489         (mi_cmd_catch_rethrow): Declare.
3490         (mi_cmd_catch_catch): Declare.
3491
3492 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3493
3494         * annotate.c (annotate_source_line): Change return type to void,
3495         update implementation to match.
3496         * annotate.h (annotate_source_line): Change return type to void,
3497         update header comment.
3498         * stack.c (print_frame_info): Don't change what frame information
3499         is printed based on whether annotations are on or not.
3500
3501 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3502
3503         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3504         (annotate_source): Make static.
3505         (annotate_source_line): Moved from source.c and renamed from
3506         identify_source_line.  Update the return type.
3507         * annotate.h (annotate_source): Delete declaration.
3508         (annotate_source_line): Declaration moved from source.h, and
3509         renamed from identify_source_line.  Return type updated.
3510         * source.c (identify_source_line): Moved to annotate.c and renamed
3511         to annotate_source_line.
3512         (info_line_command): Remove check of annotation_level.
3513         * source.h (identify_source_line): Move declaration to annotate.h
3514         and rename to annotate_source_line.
3515         * stack.c: Add 'annotate.h' include.
3516         (print_frame_info): Remove check of annotation_level before
3517         calling annotate_source_line.
3518
3519 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3520
3521         * source-cache.c (source_cache::get_plain_source_lines): Use
3522         open_source_file_with_line_charpos instead of just
3523         open_source_file, remove call to find_source_lines.
3524         (source_cache::get_source_lines): Likewise.
3525         * source.c (find_source_lines): Make static.
3526         (get_filename_and_charpos): Renamed into...
3527         (open_source_file_with_line_charpos): ..this along with changes to
3528         return a scoped_fd, and some other minor clean ups.
3529         (identify_source_line): Use open_source_file_with_line_charpos.
3530         (search_command_helper): Use open_source_file_with_line_charpos
3531         instead of just open_source_file, remove call to
3532         find_source_lines.
3533         * source.h (open_source_file_with_line_charpos): Declare new
3534         function.
3535         (find_source_lines): Delete declaration.
3536
3537 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * source.c (get_filename_and_charpos): Remove fullname
3540         parameter.
3541         (identify_source_line): Update call to get_filename_and_charpos.
3542
3543 2019-06-14  Tom Tromey  <tromey@adacore.com>
3544
3545         PR gdb/24502:
3546         * ui-style.h (skip_ansi_escape): Update comment.
3547         * ui-file.h (class no_terminal_escape_file): New class.
3548         * ui-file.c (no_terminal_escape_file::write)
3549         (no_terminal_escape_file::puts): New methods.
3550         * cli/cli-logging.c (handle_redirections): Use
3551         no_terminal_escape_file.
3552
3553 2019-06-14  Tom Tromey  <tromey@adacore.com>
3554
3555         * NEWS: Move convenience variable news above Python news.
3556
3557 2019-06-14  Tom Tromey  <tom@tromey.com>
3558
3559         * gnulib: Move directory to top-level.
3560         * configure.ac: Don't configure gnulib.
3561         * configure: Rebuild.
3562         * common/common-defs.h: Use new path to gnulib.
3563         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3564         (GNULIB_H): Remove.
3565         (INCGNU): Look in new gnulib location.
3566         (HFILES_NO_SRCDIR): Remove gnulib files.
3567         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3568         (generated_files): Remove GNULIB_H.
3569         ($(LIBGNU), all-lib): Remove targets.
3570         (distclean): Don't mention GNULIB_BUILDDIR.
3571         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3572
3573 2019-06-14  Tom Tromey  <tromey@adacore.com>
3574
3575         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3576         Warn if symbol file does not provide any symbols.
3577
3578 2019-06-14  Tom Tromey  <tromey@adacore.com>
3579
3580         * source.c (find_and_open_source): Respect basenames_may_differ.
3581
3582 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * annotate.c (annotate_breakpoints_invalid): Make use of
3585         scoped_restore_terminal_state.
3586         (annotate_frames_invalid): Likewise.
3587
3588 2019-06-14  Tom Tromey  <tromey@adacore.com>
3589
3590         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3591         allow assignment to an internalvar.
3592
3593 2019-06-14  Tom Tromey  <tromey@adacore.com>
3594
3595         * ada-lex.l: Allow "_" in attribute names.
3596
3597 2019-06-14  Tom Tromey  <tromey@adacore.com>
3598
3599         PR gdb/24653:
3600         * regcache.c (registers_changed): Don't call alloca.
3601         * top.c (execute_command): Don't call alloca.
3602
3603 2019-06-13  Pedro Alves  <palves@redhat.com>
3604
3605         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3606         'expression'.  When parsing an expression, error out if there's
3607         junk after "unlimited".
3608         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3609         (do_set_command): Adjust calls to is_unlimited_literal.
3610
3611 2019-06-13  Pedro Alves  <palves@redhat.com>
3612
3613         * compile/compile.c (make_compile_options_def_group): Add braces
3614         around array_view initializer.
3615         * thread.c (make_thread_apply_all_options_def_group)
3616         (make_thread_apply_all_options_def_group): Likewise.
3617
3618 2019-06-13  Pedro Alves  <palves@redhat.com>
3619
3620         * NEWS (New commands): Mention "maint test-options
3621         require-delimiter", "maint test-options unknown-is-error", "maint
3622         test-options unknown-is-operand" and "maint show
3623         test-options-completion-result".
3624         (New command options, command completion): New section.
3625         (Completion improvements): New section.
3626         Mention that you can abbreviate "unlimited".
3627
3628 2019-06-13  Pedro Alves  <palves@redhat.com>
3629
3630         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3631         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3632         * unittests/cli-utils-selftests.c (test_parse_flags)
3633         (test_parse_flags_qcs): Delete.
3634         (test_cli_utils): Don't call deleted functions.
3635
3636 2019-06-13  Pedro Alves  <palves@redhat.com>
3637
3638         * thread.c: Include "cli/cli-option.h".
3639         (tp_array_compar_ascending): Global.
3640         (tp_array_compar): Delete function.
3641         (tp_array_compar_ascending, tp_array_compar_descending): New
3642         functions.
3643         (ascending_option_def, qcs_flag_option_def)
3644         (thr_qcs_flags_option_defs)
3645         (make_thread_apply_all_options_def_group)
3646         (make_thread_apply_options_def_group): New.
3647         (thread_apply_all_command): Use gdb::option::process_options.
3648         (thread_apply_command_completer)
3649         (thread_apply_all_command_completer): New.
3650         (thread_apply_command): Use gdb::option::process_options.
3651         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3652         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3653         to generate help text of "thread apply".  Adjust "taas"'s help.
3654         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3655         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3656
3657 2019-06-13  Pedro Alves  <palves@redhat.com>
3658
3659         * thread.c (thread_apply_command): Check for invalid TID with
3660         isdigit instead of !isalpha.
3661
3662 2019-06-13  Pedro Alves  <palves@redhat.com>
3663
3664         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3665         (validate_flags_qcs): New.
3666         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3667         (validate_flags_qcs): Declare.
3668         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3669         (make_frame_apply_options_def_group): New.
3670         (frame_apply_command_count): Process options with
3671         gdb::option::process_options.
3672         (frame_apply_completer): New.
3673         (frame_apply_level_completer, frame_apply_all_completer)
3674         (frame_apply_completer): New.
3675         (_initialize_stack): Update help of "frame apply", "frame apply
3676         level", "frame apply all" and "faas" to mention supported options
3677         and install command completers.
3678         * stack.h (frame_apply_all_completer): Declare.
3679         * thread.c: Include "stack.h".
3680         (tfaas_command): Add "--".
3681         (_initialize_thread): Update help "tfaas" to mention supported
3682         options and install command completer.
3683
3684 2019-06-13  Pedro Alves  <palves@redhat.com>
3685
3686         * completer.c (complete_nested_command_line): New.
3687         (gdb_completion_word_break_characters_throw): Add assertion.
3688         * completer.h (complete_nested_command_line): Declare.
3689
3690 2019-06-13  Pedro Alves  <palves@redhat.com>
3691
3692         * stack.c (parse_backtrace_qualifiers): New.
3693         (backtrace_command): Use it.
3694         (backtrace_command_completer): Complete on qualifiers.
3695
3696 2019-06-13  Pedro Alves  <palves@redhat.com>
3697
3698         * frame.c: Include "cli/cli-option.h.
3699         (user_set_backtrace_options): New.
3700         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3701         Delete.
3702         (get_prev_frame): Adjust.
3703         (boolean_option_def, uinteger_option_def)
3704         (set_backtrace_option_defs): New.
3705         (_initialize_frame): Adjust and use
3706         gdb::option::add_setshow_cmds_for_options to install "set
3707         backtrace past-main" and "set backtrace past-entry".
3708         * frame.h: Include "cli/cli-option.h".
3709         (struct frame_print_options): Forward declare.
3710         (print_frame_arguments_all, print_frame_arguments_scalars)
3711         (print_frame_arguments_none): Declare.
3712         (print_entry_values): Delete declaration.
3713         (struct frame_print_options, user_frame_print_options): New.
3714         (struct set_backtrace_options): New.
3715         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3716         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3717         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3718         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3719         (list_args_or_locals): Add frame_print_options parameter.
3720         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3721         * python/py-framefilter.c (enumerate_args): Pass down
3722         USER_FRAME_PRINT_OPTIONS.
3723         * stack.c: Include "cli/cli-option.h".
3724         (print_frame_arguments_all, print_frame_arguments_scalars)
3725         (print_frame_arguments_none): Declare.
3726         (print_raw_frame_arguments, print_entry_values): Delete.
3727         (user_frame_print_options): New.
3728         (boolean_option_def, enum_option_def, frame_print_option_defs):
3729         New.
3730         (struct backtrace_cmd_options): New.
3731         (bt_flag_option_def): New.
3732         (backtrace_command_option_defs): New.
3733         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3734         (print_frame_arg, read_frame_arg, print_frame_args)
3735         (print_frame_info, print_frame): Add frame_print_options parameter
3736         and use it.
3737         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3738         (backtrace_command_1): Add frame_print_options and
3739         backtrace_cmd_options parameters and use them.
3740         (make_backtrace_options_def_group): New.
3741         (backtrace_command): Process command options with
3742         gdb::option::process_options.
3743         (backtrace_command_completer): New.
3744         (_initialize_stack): Extend "backtrace"'s help to mention
3745         supported options.  Install completer for "backtrace".
3746         Install some settings commands with add_setshow_cmds_for_options.
3747
3748 2019-06-13  Pedro Alves  <palves@redhat.com>
3749
3750         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3751         and that "set/show print raw frame-arguments" are now deprecated.
3752
3753         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3754         command.
3755         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3756         * stack.c (_initialize_stack): Install "set/show print
3757         raw-frame-arguments", and deprecate "set/show print raw
3758         frame-arguments".
3759         * valprint.c (_initialize_valprint): Deprecate "set/show print
3760         raw".
3761
3762 2019-06-13  Pedro Alves  <palves@redhat.com>
3763
3764         * compile/compile.c (struct compile_options): New.
3765         (compile_flag_option_def, compile_command_option_defs)
3766         (make_compile_options_def_group): New.
3767         (compile_file_command): Handle options with
3768         gdb::option::process_options.
3769         (compile_file_command_completer): New function.
3770         (compile_code_command): Handle options with
3771         gdb::option::process_options.
3772         (compile_code_command_completer): New function.
3773         (_initialize_compiler): Install completers for "compile code" and
3774         "compile file".  Mention available options in "compile code" and
3775         "compile code"'s help.
3776         * completer.c (advance_to_completion_word): New, factored out from
3777         ...
3778         (advance_to_expression_complete_word_point): ... this.
3779         (advance_to_filename_complete_word_point): New.
3780         * completer.h (advance_to_filename_complete_word_point): New
3781         declaration.
3782
3783 2019-06-13  Pedro Alves  <palves@redhat.com>
3784
3785         * compile/compile.c: Include "cli/cli-option.h".
3786         (compile_print_value): Scope data pointer is now a
3787         value_print_options pointer; adjust.
3788         (compile_print_command): Process options.  Scope data pointer is
3789         now a value_print_options pointer; adjust.
3790         (_initialize_compile): Update "compile print"'s help to include
3791         supported options.  Install a completer for "compile print".
3792         * cp-valprint.c (show_vtblprint, show_objectprint)
3793         (show_static_field_print): Delete.
3794         (_initialize_cp_valprint): Don't install "set print
3795         static-members", "set print vtbl", "set print object" here.
3796         * printcmd.c: Include "cli/cli-option.h" and
3797         "common/gdb_optional.h".
3798         (print_command_parse_format): Rework to fill in a
3799         value_print_options instead of a format_data.
3800         (print_value): Change parameter type from format_data pointer to
3801         value_print_options reference.  Adjust.
3802         (print_command_1): Process options.  Adjust to pass down a
3803         value_print_options.
3804         (print_command_completer): New.
3805         (_initialize_printcmd): Install print_command_completer as
3806         handle_brkchars completer for the "print" command.  Update
3807         "print"'s help to include supported options.
3808         * valprint.c: Include "cli/cli-option.h".
3809         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3810         here from cp-valprint.c.
3811         (boolean_option_def, uinteger_option_def)
3812         (value_print_option_defs, make_value_print_options_def_group):
3813         New.  Use gdb::option::add_setshow_cmds_for_options to install
3814         "set print elements", "set print null-stop", "set print repeats",
3815         "set print pretty", "set print union", "set print array", "set
3816         print address", "set print symbol", "set print array-indexes".
3817         * valprint.h: Include <string> and "cli/cli-option.h".
3818         (make_value_print_options_def_group): Declare.
3819         (print_value): Change parameter type from format_data pointer to
3820         value_print_options reference.
3821         (print_command_completer): Declare.
3822
3823 2019-06-13  Pedro Alves  <palves@redhat.com>
3824
3825         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3826         (COMMON_SFILES): Add maint-test-settings.c.
3827         * cli/cli-decode.c (boolean_enums): New global, factored out from
3828         ...
3829         (add_setshow_boolean_cmd): ... here.
3830         * cli/cli-decode.h (boolean_enums): Declare.
3831         * cli/cli-option.c: New file.
3832         * cli/cli-option.h: New file.
3833         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3834         factored out from ...
3835         (parse_cli_boolean_value(const char *)): ... this.
3836         (is_unlimited_literal): Change parameter type to pointer to
3837         pointer.  Adjust and advance ARG pointer.
3838         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3839         (parse_cli_var_enum): New, factored out from ...
3840         (do_set_command): ... this.  Adjust.
3841         * cli/cli-setshow.h (parse_cli_boolean_value)
3842         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3843         (parse_cli_var_enum): Declare.
3844         * cli/cli-utils.c: Include "cli/cli-option.h".
3845         (get_ulongest): New.
3846         * cli/cli-utils.h (get_ulongest): Declare.
3847         (check_for_argument): New overloads.
3848         * maint-test-options.c: New file.
3849
3850 2019-06-13  Pedro Alves  <palves@redhat.com>
3851
3852         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3853         parse a range if "-" is at the end of the string.
3854
3855 2019-06-13  Pedro Alves  <palves@redhat.com>
3856
3857         * cli/cli-setshow.c (parse_auto_binary_operation)
3858         (parse_cli_boolean_value): Don't allow "o".
3859
3860 2019-06-13  Pedro Alves  <palves@redhat.com>
3861
3862         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3863         * NEWS: Mention maint test-settings KIND.
3864         * maint-test-settings.c: New file.
3865
3866 2019-06-13  Pedro Alves  <palves@redhat.com>
3867
3868         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3869         completer.
3870         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3871         "set" completers.
3872
3873 2019-06-13  Pedro Alves  <palves@redhat.com>
3874
3875         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3876         after item.
3877
3878 2019-06-13  Pedro Alves  <palves@redhat.com>
3879
3880         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3881
3882 2019-06-13  Pedro Alves <palves@redhat.com>
3883
3884         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3885         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3886         call.
3887         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3888         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3889         calls.
3890         (check_for_argument): Skip spaces after argument.
3891
3892 2019-06-13  Pedro Alves  <palves@redhat.com>
3893
3894         * thread.c (thread_apply_command): Adjust TID parsing.
3895         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3896         detected before end of string.
3897         (tid_is_in_list): Error out if LIST is invalid.
3898
3899 2019-06-13  Pedro Alves  <palves@redhat.com>
3900
3901         * completer.c (complete_line_internal_1): Rewind completion word
3902         point.
3903         (completion_tracker::advance_custom_word_point_by): Change
3904         parameter type to int.
3905         * completer.h (completion_tracker::advance_custom_word_point_by):
3906         Likewise.
3907
3908 2019-06-13  Pedro Alves  <palves@redhat.com>
3909
3910         * completer.c (advance_to_completion_word): Handle delimiters.
3911
3912 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3913
3914         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3915
3916 2019-06-11  Tom Tromey  <tom@tromey.com>
3917
3918         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3919         (xmalloc_failed): Move to alloc.c.
3920         * alloc.c: New file.
3921         * Makefile.in (COMMON_SFILES): Add alloc.c.
3922
3923 2019-06-11  Tom Tromey  <tom@tromey.com>
3924
3925         * nat/linux-waitpid.c: Don't include server.h.
3926         (linux_debug): Remove.
3927         (my_waitpid): Update.
3928
3929 2019-06-11  Tom Tromey  <tromey@adacore.com>
3930
3931         * infcall.c (_initialize_infcall): Remove trailing newline from
3932         help.
3933         * user-regs.c (_initialize_user_regs): Remove trailing newline
3934         from help.
3935         * typeprint.c (_initialize_typeprint): Remove trailing newline
3936         from help.
3937         * reverse.c (_initialize_reverse): Remove trailing newlines from
3938         help.
3939         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3940         from help.
3941         * language.c (add_set_language_command): Remove trailing newline
3942         from help.
3943         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3944         help.
3945         * disasm.c (_initialize_disasm): Remove trailing newline from
3946         help.
3947         * top.c (init_main): Remove trailing newline from help.
3948         * interps.c (_initialize_interpreter): Remove trailing newline
3949         from help.
3950         * btrace.c (_initialize_btrace): Remove trailing newlines from
3951         help.
3952         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3953         from help.
3954         * python/python.c (_initialize_python): Remove trailing newline
3955         from help.
3956         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3957         help.
3958         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3959         from help.  Reformat some text.
3960         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3961         from help.
3962         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3963         newline from help.
3964
3965 2019-06-11  Tom Tromey  <tromey@adacore.com>
3966
3967         * darwin-nat.c (darwin_decode_exception_message)
3968         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3969
3970 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3971
3972         * valops.c (value_slice): Check for not allocated or not
3973         associated values.
3974
3975 2019-06-10  Tom de Vries  <tdevries@suse.de>
3976
3977         PR gdb/24618
3978         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3979         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3980         invalid.
3981
3982 2019-06-10  Tom de Vries  <tdevries@suse.de>
3983
3984         PR gdb/24611
3985         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3986         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3987
3988 2019-06-10  Tom de Vries  <tdevries@suse.de>
3989
3990         PR symtab/24545
3991         * symtab.c (struct demangled_name_entry): Add language field.
3992         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3993         static minimal symbol".  Set and use language field.
3994
3995 2019-06-10  Tom Tromey  <tromey@adacore.com>
3996
3997         * ada-lang.c (_initialize_ada_language): Update help text.
3998
3999 2019-06-10  Tom Tromey  <tromey@adacore.com>
4000
4001         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4002         with a newline.
4003         * guile/guile.c (handle_boot_error): Don't end warning with a
4004         newline.
4005         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4006         warning with a newline.
4007         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4008         newline.
4009         (s12z_frame_cache): Likewise.
4010         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4011         a newline.
4012         * solib-svr4.c (disable_probes_interface): Don't end warning with
4013         a newline.
4014         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4015         newline.
4016         * python/python.c (do_finish_initialization): Don't end warning
4017         with a newline.
4018
4019 2019-06-10  Tom Tromey  <tom@tromey.com>
4020
4021         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4022         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4023         gdbpy_enter.
4024
4025 2019-06-10  Tom Tromey  <tromey@adacore.com>
4026
4027         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4028         data.
4029         (elf_new_init): Don't call stabsread_new_init.
4030         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4031         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4032         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4033
4034 2019-06-10  Tom de Vries  <tdevries@suse.de>
4035
4036         PR symtab/16264
4037         PR symtab/24517
4038         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4039
4040 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4041
4042         * source.c (find_and_open_source): Also rewrite relative file
4043         names.
4044
4045 2019-04-26  Amos Bird  <amosbird@gmail.com>
4046
4047         * annotate.c (annotate_thread_exited): Add "thread-exited"
4048         annotation.
4049
4050 2019-06-06  Tom Tromey  <tromey@adacore.com>
4051
4052         * maint.h (class scoped_command_stats): Use
4053         DISABLE_COPY_AND_ASSIGN.
4054         <print_time>: New method.
4055         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4056         print_time.
4057         (scoped_command_stats::print_time): New method.
4058
4059 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4060
4061         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4062         instructions of lengths 6 or 8 bytes.
4063
4064 2019-06-04  Pedro Alves  <palves@redhat.com>
4065
4066         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4067
4068         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4069         * breakpoint.c (condition_completer): Likewise.
4070         * cli/cli-dump.c (scan_expression): Likewise.
4071         * common/filestuff.c (mkdir_recursive): Likewise.
4072         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4073         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4074         (gdb_abspath): Likewise.
4075         * compile/compile-cplus-types.c
4076         (compile_cplus_instance::decl_name): Likewise.
4077         * completer.c (complete_explicit_location):
4078         (signal_completer, reg_or_group_completer_1): Likewise.
4079         * cp-support.c (cp_remove_params_if_any): Likewise.
4080         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4081         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4082         * infcmd.c (strip_bg_char): Likewise.
4083         * linespec.c (copy_token_string): Likewise.
4084         * mi/mi-main.c (output_cores): Likewise.
4085         * psymtab.c (psymtab_search_name):
4086         * symfile.c (test_set_ext_lang_command): Likewise.
4087         * target.c (target_fileio_read_stralloc): Likewise.
4088         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4089         * value.c (complete_internalvar): Likewise.
4090
4091 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4092
4093         Add objfile property to gdb.Type.
4094         * NEWS: Mention Python API addition.
4095         * python/py-type.c (typy_get_objfile): New method.
4096
4097 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4098
4099         * NEWS: Mention the new set|show style [title|highlight].
4100         Mention changes to "show style", "help" and "apropos".
4101
4102 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4103
4104         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4105         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4106         instead of print_help_for_command.
4107         (print_doc_of_command): New function.
4108         (help_list): Add 'apropos -v word' suggestion.
4109         (print_help_for_command): Style the command name using title style.
4110         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4111         (_initialize_cli_cmds): Describe -v in apropos_command help.
4112
4113 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4114
4115         * cli/cli-style.h (cli_style_option): Add name in constructor,
4116         add m_name class member, add constructor with intensity,
4117         add name class function.
4118         (cli_style_option::add_setshow_commands): Remove name argument.
4119         (highlight_style, title_style): New styles.
4120         * cli/cli-style.c (do_show): New function that shows a style
4121         characteristic styling the style name with itself.
4122         (set_style_name): New function.
4123         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4124         Update all callers according to the changes in cli/cli-style.h.
4125         * utils.h (fputs_highlighted): New function.
4126         * utils.c (fputs_highlighted): Likewise.
4127
4128 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4129
4130         * NEWS: Mention new pipe command and new convenience variables.
4131
4132 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4133
4134         * cli/cli-cmds.c (pipe_command): New function.
4135         (_initialize_cli_cmds): Call add_com for pipe_command.
4136         Define | as an alias for pipe.
4137         (exit_status_set_internal_vars): New function.
4138         (shell_escape): Call exit_status_set_internal_vars.
4139         cli/cli-decode.c (find_command_name_length): Recognize | as
4140         a single character command.
4141
4142 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4143
4144         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4145         top.c (execute_command_to_ui_file): New function, mostly a copy
4146         of execute_command_to_string.
4147         (execute_command_to_string): Implement by calling
4148         execute_command_to_ui_file.
4149
4150 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4151
4152         * top.h (saved_command_line): Remove declaration.
4153         * top.c (previous_saved_command_line, previous_repeat_arguments):
4154         New variables.
4155         (saved_command_line): Make static, define together with other
4156         'repeat variables'.
4157         (dont_repeat): Clear repeat_arguments.
4158         (repeat_previous, get_saved_command_line, save_command_line):
4159         New functions.
4160         (gdb_init): Initialize saved_command_line
4161         and previous_saved_command_line.
4162         * main.c (captured_main_1): Remove saved_command_line initialization.
4163         * event-top.c (handle_line_of_input): Update to use
4164         the new 'repeat' related functions instead of direct access to
4165         saved_command_line.
4166         * command.h (repeat_previous, get_saved_command_line,
4167         save_command_line): New declarations.
4168         (dont_repeat): Add comment.
4169
4170 2019-05-30  Tom Tromey  <tromey@adacore.com>
4171
4172         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4173         Fix comment.
4174         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4175
4176 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4177
4178         PR cli/24587
4179         * completer.c (complete): Initialize variable word.
4180
4181 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4182
4183         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4184         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4185         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4186         'body' is NULL to the outter 'if', protecting the '!is_define'
4187         situation as well.
4188
4189 2019-05-29  Tom Tromey  <tromey@adacore.com>
4190
4191         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4192         (dwarf_unknown): New function.
4193         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4194         (dwarf_type_encoding_name): Use dwarf_unknown.
4195
4196 2019-05-29  Tom Tromey  <tromey@adacore.com>
4197
4198         PR c++/20020:
4199         * cp-valprint.c (cp_print_value_fields): Call
4200         cp_print_static_field inside "try".
4201
4202 2019-05-29  Tom Tromey  <tromey@adacore.com>
4203
4204         * inflow.c (struct terminal_info): Add default operator=.
4205         * configure: Rebuild.
4206         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4207         -Wdeprecated-copy-dtor, -Wredundant-move.
4208
4209 2019-05-29  Tom Tromey  <tromey@adacore.com>
4210
4211         * NEWS: Add entry.
4212         * infcmd.c (print_return_value_1): Handle finish_print
4213         option.
4214         (show_print_finish): New function.
4215         (_initialize_infcmd): Add "set/show print finish" commands.
4216         * valprint.c (user_print_options): Initialize new member.
4217         * valprint.h (struct value_print_options) <finish_print>: New
4218         member.
4219
4220 2019-05-28  Tom Tromey  <tromey@adacore.com>
4221
4222         * ada-lang.c (ada_remove_Xbn_suffix)
4223         (find_old_style_renaming_symbol)
4224         (parse_old_style_renaming): Remove.
4225         (ada_find_renaming_symbol): Don't call
4226         find_old_style_renaming_symbol.
4227         (ada_is_renaming_symbol): Rename from
4228         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4229         bool.  Now static.
4230         (ada_read_var_value): Update and simplify.
4231         * ada-exp.y (write_var_or_type): Remove old code.
4232
4233 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4234
4235         * event-top.c: Remove include comment.
4236         * inflow.c (class scoped_ignore_sigttou): Move from here...
4237         * inflow.h (class scoped_ignore_sigttou): ...to here.
4238         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4239         * top.c:  Remove include comment.
4240
4241 2019-05-27  Tom Tromey  <tom@tromey.com>
4242
4243         * NEWS: Fix typo.
4244
4245 2019-05-22  Tom Tromey  <tromey@adacore.com>
4246
4247         * target.c (target_follow_exec): Constify parameter.
4248         * target-delegates.c: Rebuild.
4249         * remote.c (remote_target::follow_exec): Constify parameter.
4250         * infrun.c (follow_exec): Constify parameter.
4251         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4252         (target_follow_exec): Likewise.
4253
4254 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4255
4256         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4257         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4258
4259 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4260
4261         * NEWS: Add debugredirect and testsuite sections.
4262
4263 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4264
4265         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4266         target descriptions using exclusively floating point register name
4267         aliases.
4268
4269 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4270
4271         PR gdb/18644:
4272         * f-lang.c (build_fortran_types): Handle the case where
4273         gdbarch_floatformat_for_type returns a nullptr.
4274
4275 2019-05-21  Tom de Vries  <tdevries@suse.de>
4276
4277         PR cli/24587
4278         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4279
4280 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4281
4282         PR gdb/18644:
4283         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4284         16-byte floats.
4285         * i386-tdep.c (i386_floatformat_for_type): Use
4286         floatformats_ia64_quad for the 16-byte floating point component
4287         within a fortran 32-byte complex number.
4288
4289 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4290
4291         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4292         delete default constructor.
4293         (find_partial_die): Update to return const struct.
4294         (partial_die_parent_scope): Move variable declaration into scope
4295         of its use and change its type to auto.
4296         (guess_partial_die_structure_name): Likewise.
4297         (partial_die_info::fixup): Likewise.
4298
4299 2019-05-17  Tom Tromey  <tromey@adacore.com>
4300
4301         * source.c (find_and_open_source): Remove cast.
4302
4303 2019-05-17  Tom Tromey  <tromey@adacore.com>
4304
4305         * annotate.c (annotate_source): Make "filename" const.
4306         * annotate.h (annotate_source): Use const.
4307
4308 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4309
4310         * disasm.c (set_disassembler_options): Send errors to stderr.
4311
4312 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4313
4314         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4315         (cli_interp_base::set_logging): Check debug_redirect.
4316         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4317         * cli/cli-logging.c (debug_redirect): Add static variable.
4318         (pop_output_files): Add default param.
4319         (handle_redirections): Print debug setting.
4320         (show_logging_command): Likewise.
4321         (_initialize_cli_logging): Add debugredirect command.
4322         * interps.c (current_interp_set_logging): Add debug_redirect
4323         parameter.
4324         * interps.h (set_logging): Add debug_redirect parameter.
4325         (current_interp_set_logging): Likewise.
4326         * mi/mi-common.h: Likewise.
4327         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4328
4329 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4330             Tom Tromey  <tromey@adacore.com>
4331
4332         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4333         directly.
4334         * cli/cli-interp.h (make_logging_output): Remove declaration.
4335         * cli/cli-logging.c (make_logging_output): Remove function.
4336         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4337         directly.
4338         * ui-file.c (tee_file::tee_file): Remove bools.
4339         (tee_file::~tee_file): Remove deletes.
4340         * ui-file.h (tee_file): Remove bools.
4341
4342 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4343
4344         * mi/mi-cmds.h (mi_cmd_complete): New function.
4345         * mi/mi-main.c (mi_cmd_complete): Likewise.
4346         * mi/mi-cmds.c: Define new MI command -complete.
4347         * NEWS: Mention new -complete command.
4348
4349 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4350
4351         * completer.h (complete): New function.
4352         * completer.c (complete): Likewise.
4353         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4354         function defined in completer.h.
4355
4356 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4357
4358         * MAINTAINERS (Write After Approval): Add myself.
4359
4360 2019-05-17  Tom de Vries  <tdevries@suse.de>
4361
4362         PR gdb/24094
4363         * dwarf2read.c (struct cu_partial_die_info): New struct.
4364         (find_partial_die): Return cu_partial_die_info.
4365         (partial_die_parent_scope, guess_partial_die_structure_name)
4366         (partial_die_info::fixup): Handle new return type of find_partial_die.
4367
4368 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4369
4370         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4371         "std::string", simplifying the algorithm.
4372
4373 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4374
4375         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4376         (stap_static_probe_ops::get_probes): Likewise.
4377
4378 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4379
4380         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4381         '-')" and "else if".
4382         (stap_parse_single_operand): Join checks for
4383         "gdbarch_stap_parse_special_token_p" and
4384         "gdbarch_stap_parse_special_token" in the same "if" statement.
4385         Invert check when verifying for operation on register
4386         displacement.
4387
4388 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4389
4390         * stap-probe.c (stap_get_opcode): Update comment.
4391         (stap_get_expected_argument_type): Likewise.
4392         (handle_stap_probe): Likewise.
4393
4394 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4395
4396         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4397         return type to 'bool'.  Adjust comment.  Use 'bool' when
4398         appropriate.
4399         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4400         * stap-probe.c (stap_parse_argument_1): Likewise.
4401         (stap_is_operator): Likewise.
4402         (stap_is_generic_prefix): Likewise.
4403         (stap_is_register_prefix): Likewise.
4404         (stap_is_register_indirection_prefix): Likewise.
4405         (stap_is_integer_prefix): Likewise.
4406         (stap_generic_check_suffix): Likewise.
4407         (stap_check_integer_suffix): Likewise.
4408         (stap_check_register_suffix): Likewise.
4409         (stap_check_register_indirection_suffix): Likewise.
4410         (stap_parse_register_operand): Likewise.
4411         (stap_parse_single_operand): Likewise.
4412         (stap_parse_argument_1): Likewise.
4413         (stap_probe::get_argument_count): Likewise.
4414         (stap_is_operator): Likewise.
4415
4416 2019-05-16  Tom Tromey  <tromey@adacore.com>
4417
4418         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4419         keyword to foreach.
4420
4421 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4422
4423         * linux-thread-db.c (try_thread_db_load_1): Change return type
4424         to bool.
4425         (try_thread_db_load): Likewise.
4426         (try_thread_db_load_from_pdir_1): Likewise.
4427         (try_thread_db_load_from_pdir): Likewise.
4428         (try_thread_db_load_from_sdir): Likewise.
4429         (try_thread_db_load_from_dir): Likewise.
4430         (thread_db_load_search): Likewise.
4431         (has_libpthread): Likewise.
4432         (thread_db_load): Likewise.
4433
4434 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4435
4436         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4437         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4438         NULL, and complain/return if that's the case.
4439
4440 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4441
4442         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4443         (advance, posn, abstract_read_memory): New functions.
4444         [struct mem_read_abstraction]: New struct.
4445         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4446
4447 2019-05-14  Tom Tromey  <tromey@adacore.com>
4448
4449         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4450         value is not lval_memory.
4451
4452 2019-05-14  Tom Tromey  <tromey@adacore.com>
4453
4454         * solib.c (info_sharedlibrary_command): Style the file name.
4455
4456 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4457
4458         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4459         (aarch64_vnv_type): Likewise.
4460         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4461         * common/tdesc.c: Likewise.
4462         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4463         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4464         * features/aarch64-fpu.xml: Add ieee half view.
4465         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4466         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4467         * gdbtypes.h (struct builtin_type): Likewise.
4468         (struct objfile_type): Likewise.
4469
4470 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4471
4472         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4473         typo.
4474         * location.h (string_to_event_location): Likewise.
4475
4476 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4477
4478         GDB 8.3 released.
4479
4480 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4481
4482         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4483         New variable declaration.
4484         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4485         New variable.
4486         (print_one_breakpoint): Use ui_out::test_flags and new global
4487         variable to compute use_fixed_output.
4488         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4489         Remove.
4490         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4491         (mi_multi_location_breakpoint_output_fixed): Remove.
4492         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4493         new variable.
4494         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4495         fix_multi_location_breakpoint_output flag if version >= 3.
4496         * ui-out.h (enum ui_out_flag)
4497         <fix_multi_location_breakpoint_output>: New enumerator.
4498
4499 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4500
4501         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4502
4503 2019-05-10  Tom Tromey  <tromey@adacore.com>
4504
4505         * ada-lang.c (catch_ada_completer): New function.
4506         (_initialize_ada_language): Use it.
4507
4508 2019-05-10  Tom Tromey  <tromey@adacore.com>
4509
4510         * thread.c (print_thread_info): Make "requested_threads" const.
4511         * gdbthread.h (print_thread_info): Make "requested_threads"
4512         const.
4513         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4514         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4515
4516 2019-05-08  Tom Tromey  <tom@tromey.com>
4517
4518         * gdbtypes.c (objfile_type_data): Change type.
4519         (objfile_type, _initialize_gdbtypes): Update.
4520
4521 2019-05-08  Tom Tromey  <tom@tromey.com>
4522
4523         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4524         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4525         (_initialize_dwarf2_frame): Update.
4526
4527 2019-05-08  Tom Tromey  <tom@tromey.com>
4528
4529         * objc-lang.c (objc_objfile_data): Change type.
4530         (find_methods): Update.
4531         (_initialize_objc_lang): Remove.
4532
4533 2019-05-08  Tom Tromey  <tom@tromey.com>
4534
4535         * stabsread.c (rs6000_builtin_type_data): Change type.
4536         (rs6000_builtin_type, _initialize_stabsread): Update.
4537
4538 2019-05-08  Tom Tromey  <tom@tromey.com>
4539
4540         * mips-tdep.c (mips_pdr_data): Remove.
4541         (_initialize_mips_tdep): Update.
4542
4543 2019-05-08  Tom Tromey  <tom@tromey.com>
4544
4545         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4546         (hppa_init_objfile_priv_data, read_unwind_info)
4547         (find_unwind_entry, _initialize_hppa_tdep): Update.
4548
4549 2019-05-08  Tom Tromey  <tom@tromey.com>
4550
4551         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4552         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4553         on obstack.
4554         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4555
4556 2019-05-08  Tom Tromey  <tom@tromey.com>
4557
4558         * mdebugread.c (basic_type_data): Change type.
4559         (basic_type, _initialize_mdebugread): Update.
4560
4561 2019-05-08  Tom Tromey  <tom@tromey.com>
4562
4563         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4564
4565 2019-05-08  Tom Tromey  <tom@tromey.com>
4566
4567         * nto-tdep.c (nto_inferior_data_reg): Change type.
4568         (nto_inferior_data): Update.
4569         (nto_inferior_data_cleanup, nto_new_inferior_data)
4570         (_initialize_nto_tdep): Remove.
4571         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4572
4573 2019-05-08  Tom Tromey  <tom@tromey.com>
4574
4575         * ada-lang.c (struct ada_inferior_data): Add initializers.
4576         (ada_inferior_data): Change type.
4577         (ada_inferior_data_cleanup): Remove.
4578         (get_ada_inferior_data, ada_inferior_exit)
4579         (struct ada_pspace_data): Add initializers, destructor.
4580         (ada_pspace_data_handle): Change type.
4581         (get_ada_pspace_data): Update.
4582         (ada_pspace_data_cleanup): Remove.
4583
4584 2019-05-08  Tom Tromey  <tom@tromey.com>
4585
4586         * coffread.c (struct coff_symfile_info): Add initializers.
4587         (coff_objfile_data_key): Move lower.  Change type.
4588         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4589         Update.
4590         (coff_free_info): Remove.
4591
4592 2019-05-08  Tom Tromey  <tom@tromey.com>
4593
4594         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4595         (fbsd_pspace_data_handle): Move lower.  Change type.
4596         (get_fbsd_pspace_data): Update.
4597         (fbsd_pspace_data_cleanup): Remove.
4598         (_initialize_fbsd_tdep): Update.
4599
4600 2019-05-08  Tom Tromey  <tom@tromey.com>
4601
4602         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4603         (get_ada_tasks_pspace_data): Update.
4604         (ada_tasks_pspace_data_cleanup): Remove.
4605         (_initialize_tasks): Update.
4606         (ada_tasks_inferior_data_handle): Change type.
4607         (get_ada_tasks_inferior_data): Update.
4608         (ada_tasks_inferior_data_cleanup): Remove.
4609         (struct ada_tasks_pspace_data): Add initializers.
4610
4611 2019-05-08  Tom Tromey  <tom@tromey.com>
4612
4613         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4614         * symfile-debug.c (debug_sym_get_probes): Change type.
4615         * stap-probe.c (handle_stap_probe):
4616         (stap_static_probe_ops::get_probes): Change type.
4617         * probe.h (class static_probe_ops) <get_probes>: Change type.
4618         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4619         (parse_probes_in_pspace): Update.
4620         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4621         Update.
4622         (any_static_probe_ops::get_probes): Change type.
4623         * elfread.c (elfread_data): New typedef.
4624         (probe_key): Change type.
4625         (elf_get_probes): Likewise.  Update.
4626         (probe_key_free): Remove.
4627         (_initialize_elfread): Update.
4628         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4629         Change type.
4630         (dtrace_process_dof_probe, dtrace_process_dof)
4631         (dtrace_static_probe_ops::get_probe): Change type.
4632
4633 2019-05-08  Tom Tromey  <tom@tromey.com>
4634
4635         * xcoffread.c (struct xcoff_symfile_info): Rename from
4636         coff_symfile_info.  Add initializers.
4637         (xcoff_objfile_data_key): Move lower.  Change type.
4638         (XCOFF_DATA): Rewrite.
4639         (xcoff_free_info): Remove.
4640         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4641         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4642         (xcoff_initial_scan): Update.
4643
4644 2019-05-08  Tom Tromey  <tom@tromey.com>
4645
4646         * solib-svr4.c (struct svr4_info): Add initializers and
4647         destructor.
4648         <probes_table>: Now an htab_up.
4649         (solib_svr4_pspace_data): Change type.
4650         (free_probes_table): Simplify.
4651         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4652         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4653         (probes_table_remove_objfile_probes, register_solib_event_probe)
4654         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4655         (_initialize_svr4_solib): Update.
4656
4657 2019-05-08  Tom Tromey  <tom@tromey.com>
4658
4659         * remote.c (remote_pspace_data): Change type.
4660         (remote_pspace_data_cleanup): Remove.
4661         (get_remote_exec_file, set_pspace_remote_exec_file)
4662         (_initialize_remote): Update.
4663
4664 2019-05-08  Tom Tromey  <tom@tromey.com>
4665
4666         * breakpoint.c (breakpoint_objfile_key): Change type.
4667         (get_breakpoint_objfile_data): Update.
4668         (free_breakpoint_objfile_data): Remove.
4669         (_initialize_breakpoint): Update.
4670
4671 2019-05-08  Tom Tromey  <tom@tromey.com>
4672
4673         * linux-tdep.c (struct linux_info): Add initializers.
4674         (linux_inferior_data): Move.  Change type.
4675         (invalidate_linux_cache_inf): Update.
4676         (linux_inferior_data_cleanup): Remove.
4677         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4678
4679 2019-05-08  Tom Tromey  <tom@tromey.com>
4680
4681         * auxv.c (auxv_inferior_data): Move.  Change type.
4682         (auxv_inferior_data_cleanup): Remove.
4683         (invalidate_auxv_cache_inf): Rewrite.
4684         (get_auxv_inferior_data, _initialize_auxv): Update.
4685
4686 2019-05-08  Tom Tromey  <tom@tromey.com>
4687
4688         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4689         (symfile_debug_objfile_data_key): Change type.
4690         (symfile_debug_installed, debug_qf_has_symbols)
4691         (debug_qf_find_last_source_symtab)
4692         (debug_qf_forget_cached_source_info)
4693         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4694         (debug_qf_print_stats, debug_qf_dump)
4695         (debug_qf_expand_symtabs_for_function)
4696         (debug_qf_expand_all_symtabs)
4697         (debug_qf_expand_symtabs_with_fullname)
4698         (debug_qf_map_matching_symbols)
4699         (debug_qf_expand_symtabs_matching)
4700         (debug_qf_find_pc_sect_compunit_symtab)
4701         (debug_qf_map_symbol_filenames)
4702         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4703         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4704         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4705         (debug_sym_read_linetable, debug_sym_relocate): Update.
4706         (symfile_debug_free_objfile): Remove.
4707         (install_symfile_debug_logging, _initialize_symfile_debug):
4708         Update.
4709
4710 2019-05-08  Tom Tromey  <tom@tromey.com>
4711
4712         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4713         allocate_on_obstack.
4714         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4715         (get_dwarf2_per_objfile): Update.
4716         (set_dwarf2_per_objfile): Remove.
4717         (dwarf2_has_info, dwarf2_get_section_info): Update.
4718         (dwarf2_free_objfile): Remove.
4719         (_initialize_dwarf2_read): Update.
4720
4721 2019-05-08  Tom Tromey  <tom@tromey.com>
4722
4723         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4724         initializers.
4725         <unsupported_script_warning_printed,
4726         script_not_found_warning_printed>: Now bool.
4727         (auto_load_pspace_data): Change type.
4728         (~auto_load_pspace_info): Rename from
4729         auto_load_pspace_data_cleanup.
4730         (get_auto_load_pspace_data, init_loaded_scripts_info)
4731         (clear_section_scripts, maybe_print_unsupported_script_warning)
4732         (maybe_print_script_not_found_warning, _initialize_auto_load):
4733         Update.
4734
4735 2019-05-08  Tom Tromey  <tom@tromey.com>
4736
4737         * objfiles.c (objfile_pspace_info): Add destructor and
4738         initializers.
4739         (objfiles_pspace_data): Change type.
4740         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4741         (get_objfile_pspace_data): Update.
4742         (objfiles_bfd_data): Change type.
4743         (get_objfile_bfd_data): Update.
4744         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4745
4746 2019-05-08  Tom Tromey  <tom@tromey.com>
4747
4748         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4749         Change type.
4750         (get_catch_syscall_inferior_data): Update.
4751         (catch_syscall_inferior_data_cleanup): Remove.
4752         (_initialize_break_catch_syscall): Update.
4753
4754 2019-05-08  Tom Tromey  <tom@tromey.com>
4755
4756         * inflow.c (struct terminal_info): Add destructor and
4757         initializers.
4758         (inflow_inferior_data): Change type.
4759         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4760         (get_inflow_inferior_data, inflow_inferior_exit)
4761         (swap_terminal_info, _initialize_inflow): Update.
4762
4763 2019-05-08  Tom Tromey  <tom@tromey.com>
4764
4765         * target-dcache.c (target_dcache_cleanup): Remove.
4766         (target_dcache_aspace_key): Change type.
4767         (target_dcache_init_p, target_dcache_invalidate)
4768         (target_dcache_get, target_dcache_get_or_init)
4769         (_initialize_target_dcache): Update.
4770         * dcache.h (struct dcache_deleter): New.
4771
4772 2019-05-08  Tom Tromey  <tom@tromey.com>
4773
4774         * symtab.c (struct symbol_cache): Add destructor and
4775         initializers.
4776         (symbol_cache_key): Move.  Change type.
4777         (make_symbol_cache, free_symbol_cache): Remove.
4778         (get_symbol_cache): Update.
4779         (symbol_cache_cleanup): Remove.
4780         (ALL_PSPACES, symbol_cache_flush)
4781         (maintenance_print_symbol_cache)
4782         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4783         Update.
4784
4785 2019-05-08  Tom Tromey  <tom@tromey.com>
4786
4787         * symtab.c (struct main_info): Add destructor and initializers.
4788         (main_progspace_key): Move.  Change type.
4789         (get_main_info): Update.
4790         (main_info_cleanup): Remove.
4791         (_initialize_symtab): Update.
4792
4793 2019-05-08  Tom Tromey  <tom@tromey.com>
4794
4795         * registry.h (DECLARE_REGISTRY): Define the _key class.
4796
4797 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4798
4799         * NEWS: Merge two 'New commands' sections.
4800
4801 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4802
4803         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4804         parameter and use Ada language definition instead.
4805         (ada_val_print_ptr): Remove unused language parameter.
4806         (ada_val_print_num): Remove language parameter and use Ada language
4807         definition instead.
4808         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4809         parameter.
4810         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4811         parameter and use Ada language definition instead.
4812         (ada_val_print_1): Update all ada_val_print_xxx calls.
4813         Remove language parameter.
4814         (ada_val_print): Update ada_val_print_1 call.
4815
4816 2019-05-08  Tom Tromey  <tromey@adacore.com>
4817
4818         * remote.c (remote_hw_watchpoint_limit)
4819         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4820         Now static.
4821
4822 2019-05-08  Tom Tromey  <tromey@adacore.com>
4823
4824         * maint.c (_initialize_maint_cmds): Move initialization code to
4825         remote.c.
4826         (watchdog, show_watchdog): Move to remote.c.
4827         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4828         "watchdog" static.
4829         (_initialize_remote): Move initialization code from maint.c.
4830         * defs.h (watchdog): Don't declare.
4831
4832 2019-05-08  Tom Tromey  <tromey@adacore.com>
4833
4834         * tui/tui-interp.c: Include main.h.
4835         * interps.c: Include main.h.
4836         * main.h (interpreter_p): Declare.
4837         * defs.h (interpreter_p): Don't declare.
4838
4839 2019-05-08  Tom Tromey  <tromey@adacore.com>
4840
4841         * dwarf2loc.c: Include dwarf2read.h.
4842         * defs.h (read_unsigned_leb128): Don't declare.
4843         * dwarf2read.h (read_unsigned_leb128): Declare.
4844
4845 2019-05-08  Tom Tromey  <tromey@adacore.com>
4846
4847         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4848         method.
4849
4850 2019-05-08  Tom Tromey  <tromey@adacore.com>
4851
4852         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4853         when no wrap column is set.
4854
4855 2019-05-08  Tom Tromey  <tromey@adacore.com>
4856
4857         * c-lang.c (c_get_string): Handle non-C-style arrays.
4858
4859 2019-05-08  Tom Tromey  <tromey@adacore.com>
4860
4861         * typeprint.c (print_offset_data::update): Print the bit offset,
4862         not the number of bits remaining.
4863
4864 2019-05-08  Tom Tromey  <tromey@adacore.com>
4865
4866         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4867         padding at end of comment.
4868
4869 2019-05-08  Tom Tromey  <tromey@adacore.com>
4870
4871         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4872         Compare main types.
4873
4874 2019-05-06  Tom Tromey  <tom@tromey.com>
4875
4876         * common/scoped_mmap.c: Include common-defs.h.
4877         * common/scoped_mmap.h: Don't include config.h.
4878
4879 2019-05-04  Tom Tromey  <tom@tromey.com>
4880
4881         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4882         (struct aarch64_call_info): Add initializers.
4883         <si>: Now a std::vector.
4884         (pass_on_stack, aarch64_push_dummy_call): Update.
4885
4886 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4887             Tom Tromey  <tom@tromey.com>
4888
4889         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4890         (ppc_threads): Now a std::vector.  Now static.
4891         (hwdebug_find_thread_points_by_tid)
4892         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4893         Update.
4894
4895 2019-05-04  Tom Tromey  <tom@tromey.com>
4896
4897         * arc-tdep.c (arc_tdesc_init): Return bool.
4898
4899 2019-05-04  Tom Tromey  <tom@tromey.com>
4900
4901         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4902         Use gdb_assert_not_reached.
4903
4904 2019-05-04  Tom Tromey  <tom@tromey.com>
4905
4906         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4907         "false".
4908
4909 2019-05-04  Tom Tromey  <tom@tromey.com>
4910
4911         * arc-tdep.c (arc_tdesc_init): Use bool.
4912
4913 2019-05-04  Tom Tromey  <tom@tromey.com>
4914
4915         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4916
4917 2019-05-04  Tom Tromey  <tom@tromey.com>
4918
4919         * cli/cli-cmds.c (valid_command_p): Return bool.
4920
4921 2019-05-04  Tom Tromey  <tom@tromey.com>
4922
4923         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4924         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4925
4926 2019-05-04  Raul Tambre  <raul@tambre.ee>
4927
4928         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4929         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4930         operator for comparison.
4931
4932 2019-05-04  Tom Tromey  <tom@tromey.com>
4933
4934         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4935         (lookup_partial_symbol, print_partial_symbols)
4936         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4937         (psymbol_compare): Update.
4938         (add_psymbol_to_bcache): Clear the entire psymbol.
4939         (maintenance_check_psymtabs): Update.
4940         * psympriv.h (struct partial_symbol): Don't derive from
4941         general_symbol_info.
4942         <obj_section, unrelocated_address, address,
4943         set_unrelocated_address>: Update.
4944         <ginfo>: New member.
4945         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4946         (debug_names::write_psymbols): Update.
4947
4948 2019-05-04  Tom de Vries  <tdevries@suse.de>
4949
4950         * contrib/cc-with-tweaks.sh: Support -n arg.
4951
4952 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4953
4954         * corelow.c (core_target::detach): Ensure frame cache and
4955         register caches are cleared.
4956         inferior.c (exit_inferior_1): Likewise.
4957
4958 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4959             Tom Tromey  <tom@tromey.com>
4960
4961         * dictionary.c (collate_pending_symbols_by_language): Remove
4962         "struct" from foreach.
4963         * symtab.c (lookup_global_symbol_from_objfile)
4964         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4965         foreach.
4966         * ser-tcp.c (net_open): Remove "struct" from foreach.
4967         * objfiles.c (objfile_relocate, objfile_rebase)
4968         (objfile_has_symbols): Remove "struct" from foreach.
4969         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4970         from foreach.
4971         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4972         foreach.
4973         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4974         "struct" from foreach.
4975         * ada-lang.c (create_excep_cond_exprs)
4976         (ada_exception_catchpoint_cond_string): Remove "struct" from
4977         foreach.
4978
4979 2019-05-03  Tom Tromey  <tromey@adacore.com>
4980
4981         * ada-exp.y (convert_char_literal): Check suffix of each
4982         enumerator.
4983
4984 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4985
4986         PR ada/21406:
4987         * ada-exp.y (yywrap): Don't define.
4988         * ada-lex.l (%option): Add noyywrap
4989         (yywrap): Remove.
4990
4991 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4992
4993         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4994         _WIN32_WINNT to the XP level, unless already defined to a higher
4995         level.
4996
4997         * unittests/parse-connection-spec-selftests.c:
4998         * ser-tcp.c:
4999         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5000         override.
5001
5002         * symfile.c (find_separate_debug_file): Remove colon from the
5003         drive spec of DOS/Windows file names of the target, so that the
5004         file name produced from DEBUGDIR and the target's directory will
5005         be valid on DOS/Windows systems.
5006
5007 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5008
5009         * rust-lang.c (val_print_struct): Handle printing structures
5010         containing strings.
5011
5012 2019-05-02  Tom Tromey  <tromey@adacore.com>
5013
5014         * valarith.c (_initialize_valarith): Remove.
5015
5016 2019-05-01  Tom Tromey  <tromey@adacore.com>
5017
5018         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5019         bitfields.
5020
5021 2019-05-01  Tom Tromey  <tromey@adacore.com>
5022
5023         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5024         for big-endian copies.
5025
5026 2019-04-30  Ali Tamur  <tamur@google.com>
5027         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5028         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5029         (read_3_bytes): New function.
5030
5031 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5032
5033         * windows-nat.c (main_thread_id): Delete.
5034         (handle_output_debug_string): Replace main_thread_id by
5035         current_event.dwThreadId.
5036         (fake_create_process): Likewise.
5037         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5038         Do not set main_thread_id.
5039         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5040         current_event.dwThreadId.
5041         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5042
5043 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5044
5045         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5046         Use current_event.dwThreadId instead of main_thread_id.
5047
5048 2019-04-30  Tom Tromey  <tromey@adacore.com>
5049
5050         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5051         (create_excep_cond_exprs): Iterate over program spaces.
5052         (ada_exception_catchpoint_cond_string): Examine all minimal
5053         symbols for exception types.
5054
5055 2019-04-30  Tom Tromey  <tromey@adacore.com>
5056
5057         PR c++/24470:
5058         * dwarf2read.c (process_structure_scope): Handle case where type
5059         has template parameters but no symbol was created.
5060
5061 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5062             Chris January  <chris.january@arm.com>
5063
5064         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5065         qualifier.
5066         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5067
5068 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5069
5070         * f-typeprint.c (f_print_type): Update rules for printing
5071         whitespace.
5072         (f_type_print_varspec_suffix): Likewise.
5073
5074 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5075             Chris January  <chris.january@arm.com>
5076
5077         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5078         function arguments.
5079
5080 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5081
5082         * f-lang.c (build_fortran_types): Change name of void type to
5083         lower case.
5084         * f-typeprint.c (f_type_print_base): Print the name of the void
5085         type, rather than a fixed string.
5086         * f-valprint.c (f_decorations): Use lower case void string.
5087
5088 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5089             Chris January  <chris.january@arm.com>
5090
5091         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5092         types for Fortran.
5093
5094 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5095             Chris January  <chris.january@arm.com>
5096             David Lecomber  <david.lecomber@arm.com>
5097
5098         * f-exp.y (BINOP_INTRINSIC): New token.
5099         (exp): New parser rule handling BINOP_INTRINSIC.
5100         (f77_keywords): Add new builtin procedures.
5101         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5102         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5103         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5104         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5105         (print_unop_subexp_f): New function.
5106         (print_binop_subexp_f): New function.
5107         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5108         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5109         (dump_subexp_body_f): Likewise.
5110         (operator_check_f): Likewise.
5111         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5112         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5113
5114 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5115
5116         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5117         UNOP_KIND.
5118         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5119         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5120         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5121         (operator_length_f): New fuction.
5122         (print_subexp_f): New function.
5123         (op_name_f): New function.
5124         (dump_subexp_body_f): New function.
5125         (operator_check_f): New function.
5126         (exp_descriptor_f): Replace standard expression handling functions
5127         with new functions.
5128         * gdb/fortran-operator.def: New file.
5129         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5130         * gdb/std-operator.def: Remove UNOP_KIND.
5131
5132 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5133
5134         * std-operator.def: Remove unbalanced, stray double quote
5135         character.
5136
5137 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5138             Chris January  <chris.january@arm.com>
5139             Daniel Everett  <daniel.everett@arm.com>
5140             Nick Forrington  <nick.forrington@arm.com>
5141             Richard Bunt  <richard.bunt@arm.com>
5142
5143         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5144         of depth when printing anonymous structs or unions.
5145         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5146         Don't print either the top-level value, or the children if the
5147         max-depth is exceeded.
5148         (ppscm_print_children): When printing the key of a map, allow one
5149         extra level of depth.
5150         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5151         print either the top-level value, or the children if the max-depth
5152         is exceeded.
5153         (print_children): When printing the key of a map, allow one extra
5154         level of depth.
5155         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5156         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5157         (user_print_options): Initialise max_depth field.
5158         (val_print_scalar_or_string_type_p): New function.
5159         (val_print): Check to see if the max depth has been reached.
5160         (val_print_check_max_depth): Define new function.
5161         (show_print_max_depth): New function.
5162         (_initialize_valprint): Add 'print max-depth' option.
5163         * valprint.h (struct value_print_options) <max_depth>: New field.
5164         (val_print_check_max_depth): Declare new function.
5165         * NEWS: Document new feature.
5166
5167 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5168
5169         * ada-lang.c (ada_language_defn): Initialise new field.
5170         * c-lang.c (c_is_string_type_p): New function.
5171         (c_language_defn): Initialise new field.
5172         (cplus_language_defn): Initialise new field.
5173         (asm_language_defn): Initialise new field.
5174         (minimal_language_defn): Initialise new field.
5175         * c-lang.h (c_is_string_type_p): Declare new function.
5176         * d-lang.c (d_language_defn): Initialise new field.
5177         * f-lang.c (f_is_string_type_p): New function.
5178         (f_language_defn): Initialise new field.
5179         * go-lang.c (go_is_string_type_p): New function.
5180         (go_language_defn): Initialise new field.
5181         * language.c (default_is_string_type_p): New function.
5182         (unknown_language_defn): Initialise new field.
5183         (auto_language_defn): Initialise new field.
5184         * language.h (struct language_defn) <la_is_string_type_p>: New
5185         member variable.
5186         (default_is_string_type_p): Declare new function.
5187         * m2-lang.c (m2_language_defn): Initialise new field.
5188         * objc-lang.c (objc_language_defn): Initialise new field.
5189         * opencl-lang.c (opencl_language_defn): Initialise new field.
5190         * p-lang.c (pascal_is_string_type_p): New function.
5191         (pascal_language_defn): Initialise new field.
5192         * rust-lang.c (rust_is_string_type_p): New function.
5193         (rust_language_defn): Initialise new field.
5194
5195 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5196
5197         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5198         New field.
5199         * ada-lang.c (ada_language_defn): Initialise new field.
5200         * c-lang.c (c_language_defn): Likewise.
5201         (cplus_language_defn): Likewise.
5202         (asm_language_defn): Likewise.
5203         (minimal_language_defn): Likewise.
5204         * d-lang.c (d_language_defn): Likewise.
5205         * f-lang.c (f_language_defn): Likewise.
5206         * go-lang.c (go_language_defn): Likewise.
5207         * language.c (unknown_language_defn): Likewise.
5208         (auto_language_defn): Likewise.
5209         * m2-lang.c (m2_language_defn): Likewise.
5210         * objc-lang.c (objc_language_defn): Likewise.
5211         * opencl-lang.c (opencl_language_defn): Likewise.
5212         * p-lang.c (pascal_language_defn): Likewise.
5213         * rust-lang.c (rust_language_defn): Likewise.
5214
5215 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5216
5217         * ada-lang.c (ada_is_character_type): Change return type to bool.
5218         (ada_is_string_type): Likewise.
5219         * ada-lang.h (ada_is_character_type): Update declaration
5220         (ada_is_string_type): Likewise.
5221
5222 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5223
5224         Support style in 'frame|thread apply'
5225
5226         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5227         * record.c (record_start, record_stop): Update callers of
5228         execute_command_to_string with false.
5229         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5230         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5231         methods.
5232         (class string_file): New constructor with term_out parameter.
5233         Override methods term_out and can_emit_style_escape.  New member
5234         term_out.
5235         (class stdio_file): Override can_emit_style_escape.
5236         (class tee_file): Override term_out and can_emit_style_escape.
5237         * utils.h (can_emit_style_escape): Remove.
5238         * utils.c (can_emit_style_escape): Likewise.
5239         Update all callers of can_emit_style_escape (SOMESTREAM) to
5240         SOMESTREAM->can_emit_style_escape.
5241         * source-cache.c (source_cache::get_source_lines): Likewise.
5242         * stack.c (frame_apply_command_count): Call execute_command_to_string
5243         passing the term_out characteristic of the current gdb_stdout.
5244         * thread.c (thr_try_catch_cmd): Likewise.
5245         * top.c (execute_command_to_string): pass term_out parameter
5246         to construct the string_file for the command output.
5247         * ui-file.c (term_cli_styling): New function (most code moved
5248         from utils.c can_emit_style_escape).
5249         (string_file::string_file, string_file::can_emit_style_escape,
5250         stdio_file::can_emit_style_escape, tee_file::term_out,
5251         tee_file::can_emit_style_escape): New functions.
5252
5253 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5254
5255         * NEWS: Mention the new set|show may-call-functions.
5256         * infcall.c (may_call_functions_p): New variable.
5257         (show_may_call_functions_p): New function.
5258         (call_function_by_hand_dummy): Throws an error if not
5259         may-call-functions.
5260         (_initialize_infcall): Call add_setshow_boolean_cmd for
5261         may-call-functions.
5262
5263 2019-04-25  Keith Seitz  <keiths@redhat.com>
5264
5265         PR c++/24367
5266         * cp-support.c (inspect_type): Don't attempt substitutions
5267         of symbol with the same name.
5268
5269 2019-04-25  Tom Tromey  <tromey@adacore.com>
5270
5271         PR gdb/24475:
5272         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5273         static.
5274
5275 2019-04-25  Tom Tromey  <tromey@adacore.com>
5276
5277         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5278         rvalue reference.
5279         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5280         (gdb_xml_parser::parse): Use std::move.
5281         * python/python-internal.h (gdbpy_convert_exception): Take a const
5282         reference.
5283         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5284         std::move.
5285         * python/py-utils.c (gdbpy_convert_exception): Take a const
5286         reference.
5287         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5288         Use std::move.
5289         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5290         Use std::move.
5291         * mi/mi-main.c (mi_print_exception): Take a const reference.
5292         * main.c (handle_command_errors): Take a const reference.
5293         * linespec.c (parse_linespec): Use std::move.
5294         * infcall.c (run_inferior_call): Use std::move.
5295         (call_function_by_hand_dummy): Use std::move.
5296         * exec.c (try_open_exec_file): Use std::move.
5297         * exceptions.h (exception_print, exception_fprintf)
5298         (exception_print_same): Update.
5299         * exceptions.c (print_exception, exception_print)
5300         (exception_fprintf, exception_print_same): Change parameters to
5301         const reference.
5302         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5303         * common/new-op.c: Use std::move.
5304         * common/common-exceptions.h (struct gdb_exception): Add move
5305         constructor.
5306         (struct gdb_exception_error, struct gdb_exception_quit, struct
5307         gdb_quit_bad_alloc): Change constructor to move constructor.
5308         (throw_exception): Change parameter to rvalue reference.
5309         * common/common-exceptions.c (throw_exception): Take rvalue
5310         reference.
5311         * cli/cli-interp.c (safe_execute_command): Use std::move.
5312         * breakpoint.c (insert_bp_location, location_to_sals): Use
5313         std::move.
5314
5315 2019-04-25  Tom Tromey  <tromey@adacore.com>
5316
5317         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5318         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5319         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5320         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5321         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5322         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5323         guile/scm-value.c: Use unpack.
5324         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5325         gdbscm_gdb_exception.
5326         (gdbscm_throw_gdb_exception): Likewise.
5327         (struct gdbscm_gdb_exception): New.
5328         (unpack): New function.
5329         (gdbscm_wrap): Use unpack.
5330
5331 2019-04-25  Tom Tromey  <tromey@adacore.com>
5332
5333         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5334         (gdb_rl_callback_handler): Use std::move.
5335         * common/common-exceptions.h (struct gdb_exception): Add move
5336         assignment operator.
5337         (throw_exception_sjlj): Change "exception" to const reference.
5338         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5339         (throw_exception_sjlj): Change "exception" to const reference.
5340
5341 2019-04-25  Tom Tromey  <tromey@adacore.com>
5342
5343         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5344         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5345         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5346         Update.
5347         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5348         Update.
5349         * mi/mi-interp.c (mi_interp::exec): Update.
5350         * linespec.c (parse_linespec): Update.
5351         * infcall.c (run_inferior_call): Update.
5352         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5353         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5354         (gdbscm_lookup_global_symbol): Update.
5355         * guile/scm-param.c (gdbscm_parameter_value): Update.
5356         * guile/scm-frame.c (gdbscm_frame_read_register)
5357         (gdbscm_frame_read_var): Update.
5358         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5359         * exec.c (try_open_exec_file): Update.
5360         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5361         (gdb_rl_callback_handler): Update.
5362         * common/common-exceptions.h (exception_none): Don't declare.
5363         * common/common-exceptions.c (exception_none): Don't define.
5364         (struct catcher) <exception>: Update.
5365         * cli/cli-interp.c (safe_execute_command): Update.
5366         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5367
5368 2019-04-25  Ali Tamur  <tamur@google.com>
5369
5370         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5371         (read_attribute_value): Likewise.
5372         (dwarf2_read_addr_index): Update comment.
5373         (read_str_index): Add DW_FORM_strx.
5374         (dwarf2_string_attr): Likewise.
5375         (dwarf2_const_value_attr): Likewise.
5376         (dump_die_shallow): Likewise.
5377         (dwarf2_fetch_constant_bytes): Likewise.
5378         (skip_form_bytes): Likewise.
5379         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5380
5381 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5382
5383         PR corefiles/11608
5384         PR corefiles/18187
5385         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5386         OFFSET.  Verify if current mapping contains an ELF header.
5387         (linux_find_memory_regions_full): Adjust call to
5388         dump_mapping_p.
5389
5390 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5391             Kang Li <kanglictf@gmail.com>
5392
5393         PR gdb/21600
5394
5395         * dwarf2-frame.c (read_initial_length): Be consistent about using
5396         unsigned representation of length.
5397         (decode_frame_entry_1): Likewise.  Check for wraparound of
5398         end pointer as well as buffer overflow.
5399
5400 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5401
5402         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5403         "vq".
5404
5405 2019-04-24  Tom Tromey  <tromey@adacore.com>
5406
5407         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5408
5409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5410
5411         * s12z-tdep.c (s12z_unwind_pc): Delete.
5412         (s12z_unwind_sp): Delete.
5413         (s12z_gdbarch_init): Don't register deleted functions with
5414         gdbarch.
5415
5416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5417
5418         * rl78-tdep.c (rl78_unwind_sp): Delete.
5419         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5420
5421 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5422
5423         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5424         (xstormy16_unwind_pc): Delete.
5425         (xstormy16_dummy_id): Delete.
5426         (xstormy16_gdbarch_init): Don't register deleted functions with
5427         gdbarch.
5428
5429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5430
5431         * vax-tdep.c (vax_unwind_pc): Delete.
5432         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5433
5434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5435
5436         * v850-tdep.c (v850_unwind_sp): Delete.
5437         (v850_unwind_pc): Delete.
5438         (v850_dummy_id): Delete.
5439         (v850_gdbarch_init): Don't register deleted functions with
5440         gdbarch.
5441
5442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5443
5444         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5445         (tilegx_unwind_pc): Delete.
5446         (tilegx_unwind_dummy_id): Delete.
5447         (tilegx_gdbarch_init): Don't register deleted functions with
5448         gdbarch.
5449
5450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5451
5452         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5453         (tic6x_dummy_id): Delete.
5454         (tic6x_gdbarch_init): Don't register deleted functions with
5455         gdbarch.
5456
5457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5458
5459         * sparc-tdep.c (sparc_unwind_pc): Delete.
5460         (sparc32_gdbarch_init): Don't register deleted function with
5461         gdbarch.
5462
5463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5464
5465         * sh-tdep.c (sh_unwind_sp): Delete.
5466         (sh_unwind_pc): Delete.
5467         (sh_dummy_id): Delete.
5468         (sh_gdbarch_init): Don't register deleted functions with
5469         gdbarch.
5470
5471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5472
5473         * score-tdep.c (score_unwind_sp): Delete.
5474         (score_unwind_pc): Delete.
5475         (score_dummy_id): Delete.
5476         (score_gdbarch_init): Don't register deleted functions with
5477         gdbarch.
5478
5479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5480
5481         * rx-tdep.c (rx_unwind_pc): Delete.
5482         (rx_unwind_sp): Delete.
5483         (rx_dummy_id): Delete.
5484         (rx_gdbarch_init): Don't register deleted functions with
5485         gdbarch.  Update comment.
5486
5487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5488
5489         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5490         (rs6000_dummy_id): Delete.
5491         (rs6000_gdbarch_init): Don't register deleted functions with
5492         gdbarch.
5493
5494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5495
5496         * or1k-tdep.c (or1k_dummy_id): Delete.
5497         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5498
5499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5500
5501         * nios2-tdep.c (nios2_dummy_id): Delete.
5502         (nios2_unwind_sp): Delete.
5503         (nios2_gdbarch_init): Don't register deleted functions with
5504         gdbarch.
5505
5506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5507
5508         * nds32-tdep.c (nds32_dummy_id): Delete.
5509         (nds32_unwind_pc): Delete.
5510         (nds32_unwind_sp): Delete.
5511         (nds32_gdbarch_init): Don't register deleted functions with
5512         gdbarch.
5513
5514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5515
5516         * msp430-tdep.c (msp430_unwind_pc): Delete.
5517         (msp430_unwind_sp): Delete.
5518         (msp430_dummy_id): Delete.
5519         (msp430_gdbarch_init): Don't register deleted functions with
5520         gdbarch.
5521
5522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5523
5524         * moxie-tdep.c (moxie_unwind_sp): Delete.
5525         (moxie_unwind_pc): Delete.
5526         (moxie_dummy_id): Delete.
5527         (moxie_gdbarch_init): Don't register deleted functions with
5528         gdbarch.
5529
5530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5531
5532         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5533         (mn10300_unwind_pc): Delete.
5534         (mn10300_unwind_sp): Delete.
5535         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5536         mn10300_unwind_sp.
5537         (mn10300_frame_unwind_init): Don't register deleted functions with
5538         gdbarch.
5539
5540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5541
5542         * mep-tdep.c (mep_unwind_pc): Delete.
5543         (mep_unwind_sp): Delete.
5544         (mep_dummy_id): Delete.
5545         (mep_gdbarch_init): Don't register deleted functions with
5546         gdbarch.
5547
5548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5549
5550         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5551         (m68hc11_unwind_sp): Delete.
5552         (m68hc11_gdbarch_init): Don't register deleted functions with
5553         gdbarch.
5554
5555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5556
5557         * m32r-tdep.c (m32r_unwind_sp): Delete.
5558         (m32r_unwind_pc): Delete.
5559         (m32r_dummy_id): Delete.
5560         (m32r_gdbarch_init): Don't register deleted functions with
5561         gdbarch.
5562
5563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5564
5565         * m32c-tdep.c (m32c_unwind_pc): Delete.
5566         (m32c_unwind_sp): Delete.
5567         (m32c_dummy_id): Delete.
5568         (m32c_gdbarch_init): Don't register deleted functions with
5569         gdbarch.
5570
5571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5572
5573         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5574         (lm32_unwind_pc): Delete.
5575         (lm32_dummy_id): Delete.
5576         (lm32_gdbarch_init): Don't register deleted functions with
5577         gdbarch.
5578
5579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5580
5581         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5582         (iq2000_unwind_pc): Delete.
5583         (iq2000_dummy_id): Delete.
5584         (iq2000_gdbarch_init): Don't register deleted functions with
5585         gdbarch.
5586
5587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5588
5589         * nds32-tdep.c (nds32_type_align): Delete.
5590         (nds32_push_dummy_call): Use type_align instead.
5591
5592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5593
5594         * arm-tdep.c (arm_type_align): Only handle vector override case.
5595         (arm_push_dummy_call): Use type_align.
5596         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5597
5598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5599
5600         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5601         case.
5602         (pass_on_stack): Use type_align.
5603         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5604         function.
5605
5606 2019-04-23  Tom Tromey  <tromey@adacore.com>
5607
5608         * dwarf2read.c (line_header::file_name_at): Remove unused
5609         overload.
5610
5611 2019-04-23  Tom de Vries  <tdevries@suse.de>
5612
5613         PR gdb/24438
5614         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5615         invocation.
5616
5617
5618 2019-03-27  Ali Tamur  <tamur@google.com>
5619
5620         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5621         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5622         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5623         (dwarf_expr_context::get_addr_index): Likewise
5624         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5625         (symbol_needs_eval_context::get_addr_index): Likewise
5626         (disassemble_dwarf_expression): Add DW_OP_addrx
5627         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5628         (read_cutu_die_from_dwo): Update comment
5629         (skip_one_die): Add DW_FORM_addrx
5630         (read_attribute_value): Likewise
5631         (var_decode_location): Add DW_OP_addrx
5632         (dwarf2_const_value_attr): Add DW_FORM_addrx
5633         (dump_die_shallow): Likewise
5634         (dwarf2_fetch_constant_bytes): Likewise
5635         (decode_locdesc): Add DW_OP_addrx
5636         (skip_form_bytes): Add DW_FORM_addrx
5637
5638 2019-04-22  Ali Tamur  <tamur@google.com>
5639
5640         * MAINTAINERS (Write After Approval): Add self.
5641
5642 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5643
5644         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5645         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5646         (open_symbol_file_object): Likewise.
5647         (svr4_default_sos): Add info parameter.
5648         (svr4_read_so_list): Likewise.
5649         (svr4_current_sos_direct): Adjust functions calls to pass down
5650         info.
5651         (svr4_current_sos_1): Add info parameter.
5652         (svr4_current_sos): Call get_svr4_info, pass info down to
5653         svr4_current_sos_1.
5654         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5655         get_svr4_info.
5656         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5657         get_svr4_info.
5658         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5659         to get_svr4_info.
5660         (probes_table_remove_objfile_probes): Likewise.
5661         (register_solib_event_probe): Add info parameter.
5662         (solist_update_incremental): Pass info parameter down to
5663         svr4_read_so_list.
5664         (disable_probes_interface): Add info parameter.
5665         (svr4_handle_solib_event): Pass current_program_space to
5666         get_svr4_info.  Adjust disable_probes_interface cleanup.
5667         (svr4_create_probe_breakpoints): Add info parameter, pass it
5668         down to register_solib_event_probe.
5669         (svr4_create_solib_event_breakpoints): Add info parameter,
5670         pass it down to svr4_create_probe_breakpoints.
5671         (enable_break): Pass info down to
5672         svr4_create_solib_event_breakpoints.
5673         (svr4_solib_create_inferior_hook): Pass current_program_space to
5674         get_svr4_info.
5675         (svr4_clear_solib): Likewise.
5676
5677 2019-04-22  Pedro Alves  <palves@redhat.com>
5678
5679         * solib-svr4.c (svr4_free_objfile_observer): New.
5680         (probe_and_action::objfile): New field.
5681         (probes_table_htab_remove_objfile_probes)
5682         (probes_table_remove_objfile_probes): New functions.
5683         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5684         in the new probe_and_action.  Don't store the probe in 'lookup'.
5685         (svr4_create_probe_breakpoints): Pass objfile to
5686         register_solib_event_probe.
5687         (_initialize_svr4_solib): Register a free_objfile observer.
5688
5689 2019-04-19  Tom Tromey  <tom@tromey.com>
5690
5691         * common/queue.h: Remove.
5692
5693 2019-04-19  Tom Tromey  <tom@tromey.com>
5694
5695         * event-loop.c: Don't include "common/queue.h".
5696
5697 2019-04-19  Tom Tromey  <tom@tromey.com>
5698
5699         * remote.c (remote_target): Use delete.
5700         * remote-notif.h: Include <list>, not "common/queue.h".
5701         (notif_client_p): Remove typedef.
5702         (remote_notif_state): Add constructor, destructor, initializer.
5703         <notif_queue>: Now a std::list.
5704         (remote_notif_state_xfree): Don't declare.
5705         * remote-notif.c (remote_notif_process, handle_notification)
5706         (remote_notif_state_allocate): Update.
5707         (~remote_notif_state): Rename from remote_notif_state_xfree.
5708
5709 2019-04-19  Tom Tromey  <tom@tromey.com>
5710
5711         * symfile.c (reread_symbols): Update.
5712         * objfiles.c (objfile_register_static_link)
5713         (objfile_lookup_static_link): Update
5714         (~objfile) Don't delete static_links.
5715         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5716
5717 2019-04-19  Tom Tromey  <tom@tromey.com>
5718
5719         * type-stack.h (struct type_stack) <insert>: Constify string.
5720         * type-stack.c (type_stack::insert): Constify string.
5721         * gdbtypes.h (lookup_template_type): Update.
5722         (address_space_name_to_int): Update.
5723         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5724         const.
5725         (lookup_template_type): Make name const.
5726         * c-exp.y: Update rules.
5727         (lex_one_token, classify_name, classify_inner_name)
5728         (c_print_token): Update.
5729         * p-exp.y: Update rules.
5730         (yylex): Update.
5731         * f-exp.y: Update rules.
5732         (yylex): Update.
5733         * d-exp.y: Update rules.
5734         (lex_one_token, classify_name, classify_inner_name): Update.
5735         * parse.c (write_dollar_variable, copy_name): Return std::string.
5736         * parser-defs.h (copy_name): Change return type.
5737         * m2-exp.y: Update rules.
5738         (yylex): Update.
5739         * go-exp.y (lex_one_token): Update.
5740         Update rules.
5741         (classify_unsafe_function, classify_packaged_name)
5742         (classify_name, yylex): Update.
5743
5744 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5745
5746         * configure.ac: add --enable-source-highlight switch.
5747         * configure: Regenerate.
5748         * top.c (print_gdb_version): plumb --enable-source-highlight
5749         status to "show configuration".
5750
5751 2019-04-19  Tom Tromey  <tromey@adacore.com>
5752
5753         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5754         Check ADA_TYPE_P.
5755         (empty_record, ada_template_to_fixed_record_type_1)
5756         (template_to_static_fixed_type)
5757         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5758         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5759         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5760         macros.
5761
5762 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5763
5764         PR symtab/24423:
5765         * source.c (print_source_lines_base): Advance "iter" when a
5766         control character is seen.
5767
5768 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5769
5770         * inferior.h (struct infcall_suspend_state_deleter):
5771         Catch exception in destructor to avoid crash.
5772
5773 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5774
5775         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5776         close to the add_com "shell".
5777
5778 2019-04-18  Tom Tromey  <tromey@adacore.com>
5779
5780         * process-stratum-target.h (class process_stratum_target)
5781         <stratum>: Add "final".
5782
5783 2019-04-17  Tom Tromey  <tromey@adacore.com>
5784
5785         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5786         against nullptr before use.
5787
5788 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5789
5790         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5791
5792 2019-04-17  Jim Wilson  <jimw@sifive.com>
5793             Andrew Burgess  <andrew.burgess@embecosm.com>
5794
5795         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5796         code read might fail, assume 4-byte breakpoint in that case.
5797
5798 2019-04-15  Leszek Swirski  <leszeks@google.com>
5799
5800         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5801         rather than a hand-rolled POD check when checking for forced MEMORY
5802         classification.
5803
5804 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5805
5806         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5807         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5808         function.
5809         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5810         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5811         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5812         declaration.
5813
5814 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5815
5816         * aarch64-linux-nat.c
5817         (aarch64_linux_nat_target::thread_architecture): Add override.
5818         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5819         each VQ.
5820
5821 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5822
5823         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5824
5825 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5826
5827         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5828         target types of size 96-bits, add some additional comments, and
5829         check that the builtin type we found was the correct size.
5830
5831 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5832
5833         * utils.c (prompt_for_continue): Don't restore the styling at the
5834         end, as applied_style has the wrong value.  This fixes styling in
5835         long lists of file names that are interrupted by the "Continue?"
5836         prompt.
5837
5838 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5839
5840         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5841         * c-lang.c (c_language_defn): Likewise.
5842         (cplus_language_defn): Likewise.
5843         (asm_language_defn): Likewise.
5844         (minimal_language_defn): Likewise.
5845         * d-lang.c (d_language_defn): Likewise.
5846         * f-lang.c (f_language_defn): Likewise.
5847         * go-lang.c (go_language_defn): Likewise.
5848         * language.c (unknown_language_defn): Likewise.
5849         (auto_language_defn): Likewise.
5850         * language.h (struct language_defn): Remove la_magic field.
5851         (LANG_MAGIC): Delete.
5852         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5853         * objc-lang.c (objc_language_defn): Likewise.
5854         * opencl-lang.c (opencl_language_defn): Likewise.
5855         * p-lang.c (pascal_language_defn): Likewise.
5856         * rust-lang.c (rust_language_defn): Likewise.
5857
5858 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5859
5860         * riscv-tdep.c (riscv_type_align): New function.
5861         (riscv_type_alignment): Delete.
5862         (riscv_arg_location): Use 'type_align'.
5863         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5864
5865 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5866
5867         * gdbtypes.c (type_align): A struct with no non-static fields also
5868         has alignment of 1.
5869
5870 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5871
5872         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5873         component to 0.
5874         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5875         member.
5876         (riscv_struct_info::analyse): New implementation using new
5877         analyse_inner member function.
5878         (riscv_struct_info::field_offset): New member function.
5879         (riscv_struct_info::m_offsets): New member variable.
5880         (riscv_struct_info::analyse_inner): New private member function,
5881         takes the old implementation of riscv_struct_info::analyse but
5882         extended to track field offsets.
5883         (riscv_call_arg_struct): Update the struct folding special cases
5884         to handle cases where empty C++ structs, which are non-zero
5885         length, are found.
5886         (riscv_arg_location): Initialise the length of each location, a
5887         non-zero length now indicates the location is in use.
5888         (riscv_push_dummy_call): Allow for the first location having a
5889         non-zero offset when setting up arguments.
5890         (riscv_return_value): Likewise, but for return values.
5891
5892 2019-04-11  Tom Tromey  <tromey@adacore.com>
5893
5894         * utils.c (internal_vproblem): Make "msg" const.
5895
5896 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5897
5898         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5899         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5900         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5901         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5902
5903 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5904
5905         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5906         function.
5907         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5908         of amd64_collect_native_gregset.
5909         (amd64_linux_nat_target::store_registers): Likewise.
5910
5911 2019-04-10  Tom Tromey  <tom@tromey.com>
5912
5913         * symtab.c (lookup_global_symbol_from_objfile)
5914         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5915         * objfiles.h (class separate_debug_iterator): New.
5916         (class separate_debug_range): New.
5917         (struct objfile) <separate_debug_objfiles>: New method.
5918         (objfile_separate_debug_iterate): Don't declare.
5919         * objfiles.c (separate_debug_iterator::operator++): Rename from
5920         objfile_separate_debug_iterate.
5921         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5922         iterator.
5923         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5924         iterator.
5925
5926 2019-04-10  Tom Tromey  <tom@tromey.com>
5927
5928         * symfile.c (reread_symbols): Remove old comment.
5929         * objfiles.c (free_all_objfiles): Fix a typo.
5930
5931 2019-04-10  Tom Tromey  <tom@tromey.com>
5932
5933         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5934         * minsyms.c (lookup_minimal_symbol): Use foreach.
5935         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5936         (lookup_minimal_symbol_solib_trampoline): Likewise.
5937         * symfile.c (reread_symbols): Use foreach.
5938
5939 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5940             Tom Tromey  <tromey@adacore.com>
5941
5942         PR rust/24414:
5943         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5944         (rust_lex_int_test): Change "value" to be LONGEST.
5945         (rust_lex_tests): Add test for long integer literal.
5946
5947 2019-04-09  Tom Tromey  <tromey@adacore.com>
5948
5949         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5950         to bool.
5951         (extended_remote_target::attach): Update.
5952         (remote_target::remote_notice_new_inferior): Update.
5953         (remote_target::add_current_inferior_and_thread): Update.
5954         * inferior.c (exit_inferior_1): Use "false".
5955         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5956
5957 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5958
5959         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5960         the "start" command.
5961
5962 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5963
5964         * python/py-inferior.c (infpy_thread_from_thread_handle):
5965         Adjust comments to reflect renaming of thread_from_thread_handle
5966         to thread_from_handle.  Adjust keywords.  Fix type error message.
5967         (inferior_object_methods): Add thread_from_handle.  Retain
5968         thread_from_thread_handle, but mark it as deprecated.
5969
5970 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5971
5972         * gdbthread.h (find_thread_by_handle): Revise declaration.
5973         * thread.c (find_thread_by_handle): Likewise.  Adjust
5974         implementation too.
5975         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5976         support for buffer objects as handles.
5977
5978 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5979
5980         * python/py-infthread.c (thpy_thread_handle): New function.
5981         (thread_object_methods): Register thpy_thread_handle.
5982
5983 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5984
5985         * gdbthread.h (thread_to_thread_handle): Declare.
5986         * thread.c (gdbtypes.h): Include.
5987         (thread_to_thread_handle): New function.
5988
5989         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5990         (target_thread_info_to_thread_handle): Declare.
5991         * target.c (target_thread_info_to_thread_handle): New function.
5992         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5993         * target-delegates.c: Regenerate.
5994
5995         * linux-thread-db.c (class thread_db_target): Add method
5996         thread_info_to_thread_handle.
5997         (thread_db_target::thread_info_to_thread_handle): Define.
5998         * remote.c (class remote_target): Add new method
5999         thread_info_to_thread_handle.
6000         (remote_target::thread_info_to_thread_handle): Define.
6001
6002 2019-04-08  Pedro Alves  <palves@redhat.com>
6003
6004         * common/common-exceptions.c (throw_exception): Don't create
6005         named object to throw; throw directly.
6006         (throw_it): Likewise.  Don't initialize gdb_exception::message
6007         here, with new; pass FMT and AP to the ctor instead.
6008         * common/common-exceptions.h: Include <string>.
6009         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6010         const char *, va_list)): New ctor.  Use std::make_shared.
6011         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6012         errors)): Delete.
6013         (gdb_exception_error::gdb_exception_error(enum errors, const char
6014         *, va_list)): New.
6015         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6016         Add assertion.
6017         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6018         errors)): Delete.
6019         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6020         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6021         Add assertion.
6022
6023 2019-04-08  Tom Tromey  <tom@tromey.com>
6024
6025         * valops.c (value_rtti_indirect_type): Replace throw_exception
6026         with throw.
6027         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6028         with throw.
6029         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6030         throw.
6031         * target.c (target_translate_tls_address): Replace throw_exception
6032         with throw.
6033         * stack.c (frame_apply_command_count): Replace throw_exception
6034         with throw.
6035         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6036         throw.
6037         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6038         with throw.
6039         * rs6000-tdep.c (rs6000_frame_cache)
6040         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6041         * remote.c: Replace throw_exception with throw.
6042         * record-full.c (record_full_message, record_full_wait_1)
6043         (record_full_restore): Replace throw_exception with throw.
6044         * record-btrace.c:
6045         (get_thread_current_frame_id, record_btrace_start_replaying)
6046         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6047         (cmd_record_btrace_start): Replace throw_exception with throw.
6048         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6049         throw.
6050         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6051         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6052         * linespec.c:
6053         (find_linespec_symbols): Replace throw_exception with throw.
6054         * infrun.c (displaced_step_prepare, resume): Replace
6055         throw_exception with throw.
6056         * infcmd.c (post_create_inferior): Replace throw_exception with
6057         throw.
6058         * inf-loop.c (inferior_event_handler): Replace throw_exception
6059         with throw.
6060         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6061         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6062         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6063         (get_prev_frame_always, get_frame_pc_if_available)
6064         (get_frame_address_in_block_if_available, get_frame_language):
6065         Replace throw_exception with throw.
6066         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6067         throw_exception with throw.
6068         * eval.c (fetch_subexp_value, evaluate_var_value)
6069         (evaluate_funcall, evaluate_subexp_standard): Replace
6070         throw_exception with throw.
6071         * dwarf2loc.c (call_site_find_chain)
6072         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6073         Replace throw_exception with throw.
6074         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6075         with throw.
6076         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6077         throw.
6078         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6079         * completer.c (complete_line_internal): Replace throw_exception
6080         with throw.
6081         * compile/compile-object-run.c (compile_object_run): Replace
6082         throw_exception with throw.
6083         * cli/cli-script.c (process_next_line): Replace throw_exception
6084         with throw.
6085         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6086         (btrace_enable, btrace_maint_update_pt_packets): Replace
6087         throw_exception with throw.
6088         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6089         throw_exception with throw.
6090         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6091         throw_exception with throw.
6092         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6093         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6094         * aarch64-tdep.c (aarch64_make_prologue_cache)
6095         (aarch64_make_stub_cache): Replace throw_exception with throw.
6096
6097 2019-04-08  Tom Tromey  <tom@tromey.com>
6098
6099         * common/common-exceptions.c (throw_exception): Rename from
6100         throw_exception_cxx.  Remove old copy.  Make argument const.
6101         (throw_it): Create and throw exception objects directly.
6102         * common/common-exceptions.h (throw_exception): Make argument
6103         const.
6104         (struct gdb_exception_error): Add constructor.
6105         (struct gdb_exception_quit): Add constructor.
6106
6107 2019-04-08  Tom Tromey  <tom@tromey.com>
6108
6109         * common/common-exceptions.h (exception_rethrow): Don't declare.
6110         (TRY_SJLJ): Update comment.
6111         (TRY, CATCH, END_CATCH): Remove.
6112         * common/common-exceptions.c (exception_rethrow): Remove.
6113
6114 2019-04-08  Tom Tromey  <tom@tromey.com>
6115
6116         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6117         Remove.
6118         (gdb_exception_error): Rename from
6119         gdb_exception_RETURN_MASK_ERROR.
6120         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6121         (gdb_quit_bad_alloc): Update.
6122         * aarch64-tdep.c: Update.
6123         * ada-lang.c: Update.
6124         * ada-typeprint.c: Update.
6125         * ada-valprint.c: Update.
6126         * amd64-tdep.c: Update.
6127         * arch-utils.c: Update.
6128         * break-catch-throw.c: Update.
6129         * breakpoint.c: Update.
6130         * btrace.c: Update.
6131         * c-varobj.c: Update.
6132         * cli/cli-cmds.c: Update.
6133         * cli/cli-interp.c: Update.
6134         * cli/cli-script.c: Update.
6135         * common/common-exceptions.c: Update.
6136         * common/new-op.c: Update.
6137         * common/selftest.c: Update.
6138         * compile/compile-c-symbols.c: Update.
6139         * compile/compile-cplus-symbols.c: Update.
6140         * compile/compile-object-load.c: Update.
6141         * compile/compile-object-run.c: Update.
6142         * completer.c: Update.
6143         * corelow.c: Update.
6144         * cp-abi.c: Update.
6145         * cp-support.c: Update.
6146         * cp-valprint.c: Update.
6147         * darwin-nat.c: Update.
6148         * disasm-selftests.c: Update.
6149         * dtrace-probe.c: Update.
6150         * dwarf-index-cache.c: Update.
6151         * dwarf-index-write.c: Update.
6152         * dwarf2-frame-tailcall.c: Update.
6153         * dwarf2-frame.c: Update.
6154         * dwarf2loc.c: Update.
6155         * dwarf2read.c: Update.
6156         * eval.c: Update.
6157         * event-loop.c: Update.
6158         * event-top.c: Update.
6159         * exec.c: Update.
6160         * f-valprint.c: Update.
6161         * fbsd-tdep.c: Update.
6162         * frame-unwind.c: Update.
6163         * frame.c: Update.
6164         * gdbtypes.c: Update.
6165         * gnu-v3-abi.c: Update.
6166         * guile/guile-internal.h: Update.
6167         * guile/scm-block.c: Update.
6168         * guile/scm-breakpoint.c: Update.
6169         * guile/scm-cmd.c: Update.
6170         * guile/scm-disasm.c: Update.
6171         * guile/scm-frame.c: Update.
6172         * guile/scm-lazy-string.c: Update.
6173         * guile/scm-math.c: Update.
6174         * guile/scm-param.c: Update.
6175         * guile/scm-ports.c: Update.
6176         * guile/scm-pretty-print.c: Update.
6177         * guile/scm-symbol.c: Update.
6178         * guile/scm-symtab.c: Update.
6179         * guile/scm-type.c: Update.
6180         * guile/scm-value.c: Update.
6181         * i386-linux-tdep.c: Update.
6182         * i386-tdep.c: Update.
6183         * inf-loop.c: Update.
6184         * infcall.c: Update.
6185         * infcmd.c: Update.
6186         * infrun.c: Update.
6187         * jit.c: Update.
6188         * language.c: Update.
6189         * linespec.c: Update.
6190         * linux-fork.c: Update.
6191         * linux-nat.c: Update.
6192         * linux-tdep.c: Update.
6193         * linux-thread-db.c: Update.
6194         * main.c: Update.
6195         * mi/mi-cmd-break.c: Update.
6196         * mi/mi-cmd-stack.c: Update.
6197         * mi/mi-interp.c: Update.
6198         * mi/mi-main.c: Update.
6199         * objc-lang.c: Update.
6200         * p-valprint.c: Update.
6201         * parse.c: Update.
6202         * ppc-linux-tdep.c: Update.
6203         * printcmd.c: Update.
6204         * python/py-arch.c: Update.
6205         * python/py-breakpoint.c: Update.
6206         * python/py-cmd.c: Update.
6207         * python/py-finishbreakpoint.c: Update.
6208         * python/py-frame.c: Update.
6209         * python/py-framefilter.c: Update.
6210         * python/py-gdb-readline.c: Update.
6211         * python/py-inferior.c: Update.
6212         * python/py-infthread.c: Update.
6213         * python/py-lazy-string.c: Update.
6214         * python/py-linetable.c: Update.
6215         * python/py-objfile.c: Update.
6216         * python/py-param.c: Update.
6217         * python/py-prettyprint.c: Update.
6218         * python/py-progspace.c: Update.
6219         * python/py-record-btrace.c: Update.
6220         * python/py-record.c: Update.
6221         * python/py-symbol.c: Update.
6222         * python/py-type.c: Update.
6223         * python/py-unwind.c: Update.
6224         * python/py-utils.c: Update.
6225         * python/py-value.c: Update.
6226         * python/python.c: Update.
6227         * record-btrace.c: Update.
6228         * record-full.c: Update.
6229         * remote-fileio.c: Update.
6230         * remote.c: Update.
6231         * riscv-tdep.c: Update.
6232         * rs6000-aix-tdep.c: Update.
6233         * rs6000-tdep.c: Update.
6234         * rust-exp.y: Update.
6235         * rust-lang.c: Update.
6236         * s390-tdep.c: Update.
6237         * selftest-arch.c: Update.
6238         * solib-dsbt.c: Update.
6239         * solib-frv.c: Update.
6240         * solib-spu.c: Update.
6241         * solib-svr4.c: Update.
6242         * solib.c: Update.
6243         * sparc64-linux-tdep.c: Update.
6244         * stack.c: Update.
6245         * symfile-mem.c: Update.
6246         * symmisc.c: Update.
6247         * target.c: Update.
6248         * thread.c: Update.
6249         * top.c: Update.
6250         * tracefile-tfile.c: Update.
6251         * tui/tui.c: Update.
6252         * typeprint.c: Update.
6253         * unittests/cli-utils-selftests.c: Update.
6254         * unittests/parse-connection-spec-selftests.c: Update.
6255         * valops.c: Update.
6256         * valprint.c: Update.
6257         * value.c: Update.
6258         * varobj.c: Update.
6259         * windows-nat.c: Update.
6260         * x86-linux-nat.c: Update.
6261         * xml-support.c: Update.
6262
6263 2019-04-08  Tom Tromey  <tom@tromey.com>
6264
6265         * xml-support.c: Use C++ exception handling.
6266         * x86-linux-nat.c: Use C++ exception handling.
6267         * windows-nat.c: Use C++ exception handling.
6268         * varobj.c: Use C++ exception handling.
6269         * value.c: Use C++ exception handling.
6270         * valprint.c: Use C++ exception handling.
6271         * valops.c: Use C++ exception handling.
6272         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6273         handling.
6274         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6275         * typeprint.c: Use C++ exception handling.
6276         * tui/tui.c: Use C++ exception handling.
6277         * tracefile-tfile.c: Use C++ exception handling.
6278         * top.c: Use C++ exception handling.
6279         * thread.c: Use C++ exception handling.
6280         * target.c: Use C++ exception handling.
6281         * symmisc.c: Use C++ exception handling.
6282         * symfile-mem.c: Use C++ exception handling.
6283         * stack.c: Use C++ exception handling.
6284         * sparc64-linux-tdep.c: Use C++ exception handling.
6285         * solib.c: Use C++ exception handling.
6286         * solib-svr4.c: Use C++ exception handling.
6287         * solib-spu.c: Use C++ exception handling.
6288         * solib-frv.c: Use C++ exception handling.
6289         * solib-dsbt.c: Use C++ exception handling.
6290         * selftest-arch.c: Use C++ exception handling.
6291         * s390-tdep.c: Use C++ exception handling.
6292         * rust-lang.c: Use C++ exception handling.
6293         * rust-exp.y: Use C++ exception handling.
6294         * rs6000-tdep.c: Use C++ exception handling.
6295         * rs6000-aix-tdep.c: Use C++ exception handling.
6296         * riscv-tdep.c: Use C++ exception handling.
6297         * remote.c: Use C++ exception handling.
6298         * remote-fileio.c: Use C++ exception handling.
6299         * record-full.c: Use C++ exception handling.
6300         * record-btrace.c: Use C++ exception handling.
6301         * python/python.c: Use C++ exception handling.
6302         * python/py-value.c: Use C++ exception handling.
6303         * python/py-utils.c: Use C++ exception handling.
6304         * python/py-unwind.c: Use C++ exception handling.
6305         * python/py-type.c: Use C++ exception handling.
6306         * python/py-symbol.c: Use C++ exception handling.
6307         * python/py-record.c: Use C++ exception handling.
6308         * python/py-record-btrace.c: Use C++ exception handling.
6309         * python/py-progspace.c: Use C++ exception handling.
6310         * python/py-prettyprint.c: Use C++ exception handling.
6311         * python/py-param.c: Use C++ exception handling.
6312         * python/py-objfile.c: Use C++ exception handling.
6313         * python/py-linetable.c: Use C++ exception handling.
6314         * python/py-lazy-string.c: Use C++ exception handling.
6315         * python/py-infthread.c: Use C++ exception handling.
6316         * python/py-inferior.c: Use C++ exception handling.
6317         * python/py-gdb-readline.c: Use C++ exception handling.
6318         * python/py-framefilter.c: Use C++ exception handling.
6319         * python/py-frame.c: Use C++ exception handling.
6320         * python/py-finishbreakpoint.c: Use C++ exception handling.
6321         * python/py-cmd.c: Use C++ exception handling.
6322         * python/py-breakpoint.c: Use C++ exception handling.
6323         * python/py-arch.c: Use C++ exception handling.
6324         * printcmd.c: Use C++ exception handling.
6325         * ppc-linux-tdep.c: Use C++ exception handling.
6326         * parse.c: Use C++ exception handling.
6327         * p-valprint.c: Use C++ exception handling.
6328         * objc-lang.c: Use C++ exception handling.
6329         * mi/mi-main.c: Use C++ exception handling.
6330         * mi/mi-interp.c: Use C++ exception handling.
6331         * mi/mi-cmd-stack.c: Use C++ exception handling.
6332         * mi/mi-cmd-break.c: Use C++ exception handling.
6333         * main.c: Use C++ exception handling.
6334         * linux-thread-db.c: Use C++ exception handling.
6335         * linux-tdep.c: Use C++ exception handling.
6336         * linux-nat.c: Use C++ exception handling.
6337         * linux-fork.c: Use C++ exception handling.
6338         * linespec.c: Use C++ exception handling.
6339         * language.c: Use C++ exception handling.
6340         * jit.c: Use C++ exception handling.
6341         * infrun.c: Use C++ exception handling.
6342         * infcmd.c: Use C++ exception handling.
6343         * infcall.c: Use C++ exception handling.
6344         * inf-loop.c: Use C++ exception handling.
6345         * i386-tdep.c: Use C++ exception handling.
6346         * i386-linux-tdep.c: Use C++ exception handling.
6347         * guile/scm-value.c: Use C++ exception handling.
6348         * guile/scm-type.c: Use C++ exception handling.
6349         * guile/scm-symtab.c: Use C++ exception handling.
6350         * guile/scm-symbol.c: Use C++ exception handling.
6351         * guile/scm-pretty-print.c: Use C++ exception handling.
6352         * guile/scm-ports.c: Use C++ exception handling.
6353         * guile/scm-param.c: Use C++ exception handling.
6354         * guile/scm-math.c: Use C++ exception handling.
6355         * guile/scm-lazy-string.c: Use C++ exception handling.
6356         * guile/scm-frame.c: Use C++ exception handling.
6357         * guile/scm-disasm.c: Use C++ exception handling.
6358         * guile/scm-cmd.c: Use C++ exception handling.
6359         * guile/scm-breakpoint.c: Use C++ exception handling.
6360         * guile/scm-block.c: Use C++ exception handling.
6361         * guile/guile-internal.h: Use C++ exception handling.
6362         * gnu-v3-abi.c: Use C++ exception handling.
6363         * gdbtypes.c: Use C++ exception handling.
6364         * frame.c: Use C++ exception handling.
6365         * frame-unwind.c: Use C++ exception handling.
6366         * fbsd-tdep.c: Use C++ exception handling.
6367         * f-valprint.c: Use C++ exception handling.
6368         * exec.c: Use C++ exception handling.
6369         * event-top.c: Use C++ exception handling.
6370         * event-loop.c: Use C++ exception handling.
6371         * eval.c: Use C++ exception handling.
6372         * dwarf2read.c: Use C++ exception handling.
6373         * dwarf2loc.c: Use C++ exception handling.
6374         * dwarf2-frame.c: Use C++ exception handling.
6375         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6376         * dwarf-index-write.c: Use C++ exception handling.
6377         * dwarf-index-cache.c: Use C++ exception handling.
6378         * dtrace-probe.c: Use C++ exception handling.
6379         * disasm-selftests.c: Use C++ exception handling.
6380         * darwin-nat.c: Use C++ exception handling.
6381         * cp-valprint.c: Use C++ exception handling.
6382         * cp-support.c: Use C++ exception handling.
6383         * cp-abi.c: Use C++ exception handling.
6384         * corelow.c: Use C++ exception handling.
6385         * completer.c: Use C++ exception handling.
6386         * compile/compile-object-run.c: Use C++ exception handling.
6387         * compile/compile-object-load.c: Use C++ exception handling.
6388         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6389         * compile/compile-c-symbols.c: Use C++ exception handling.
6390         * common/selftest.c: Use C++ exception handling.
6391         * common/new-op.c: Use C++ exception handling.
6392         * cli/cli-script.c: Use C++ exception handling.
6393         * cli/cli-interp.c: Use C++ exception handling.
6394         * cli/cli-cmds.c: Use C++ exception handling.
6395         * c-varobj.c: Use C++ exception handling.
6396         * btrace.c: Use C++ exception handling.
6397         * breakpoint.c: Use C++ exception handling.
6398         * break-catch-throw.c: Use C++ exception handling.
6399         * arch-utils.c: Use C++ exception handling.
6400         * amd64-tdep.c: Use C++ exception handling.
6401         * ada-valprint.c: Use C++ exception handling.
6402         * ada-typeprint.c: Use C++ exception handling.
6403         * ada-lang.c: Use C++ exception handling.
6404         * aarch64-tdep.c: Use C++ exception handling.
6405
6406 2019-04-08  Tom Tromey  <tom@tromey.com>
6407
6408         * xml-support.c (gdb_xml_parser::parse): Update.
6409         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6410         * value.c (show_convenience): Update.
6411         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6412         (test_parse_flags_qcs): Update.
6413         * thread.c (thr_try_catch_cmd): Update.
6414         * target.c (target_translate_tls_address): Update.
6415         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6416         (info_frame_command_core, frame_apply_command_count): Update.
6417         * rust-exp.y (rust_lex_exception_test): Update.
6418         * riscv-tdep.c (riscv_print_one_register_info): Update.
6419         * remote.c (remote_target::enable_btrace): Update.
6420         * record-btrace.c (record_btrace_enable_warn): Update.
6421         * python/py-utils.c (gdbpy_convert_exception): Update.
6422         * printcmd.c (do_one_display, print_variable_and_value): Update.
6423         * mi/mi-main.c (mi_print_exception): Update.
6424         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6425         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6426         * linux-nat.c (linux_nat_target::attach): Update.
6427         * linux-fork.c (class scoped_switch_fork_info): Update.
6428         * infrun.c (displaced_step_prepare): Update.
6429         * infcall.c (call_function_by_hand_dummy): Update.
6430         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6431         * gnu-v3-abi.c (print_one_vtable): Update.
6432         * frame.c (get_prev_frame_always): Update.
6433         * f-valprint.c (info_common_command_for_block): Update.
6434         * exec.c (try_open_exec_file): Update.
6435         * exceptions.c (print_exception, exception_print)
6436         (exception_fprintf, exception_print_same): Update.
6437         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6438         * dwarf-index-cache.c (index_cache::store)
6439         (index_cache::lookup_gdb_index): Update.
6440         * darwin-nat.c (maybe_cache_shell): Update.
6441         * cp-valprint.c (cp_print_value_fields): Update.
6442         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6443         (gcc_cplus_symbol_address): Update.
6444         * compile/compile-c-symbols.c (gcc_convert_symbol)
6445         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6446         * common/selftest.c: Update.
6447         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6448         a std::string.
6449         (exception_try_scope_entry, exception_try_scope_exit): Don't
6450         declare.
6451         (struct exception_try_scope): Remove.
6452         (TRY): Don't use exception_try_scope.
6453         (struct gdb_exception): Add constructor, operator=.
6454         <what>: New method.
6455         (struct gdb_exception_RETURN_MASK_ALL)
6456         (struct gdb_exception_RETURN_MASK_ERROR)
6457         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6458         (struct gdb_quit_bad_alloc): Update.
6459         * common/common-exceptions.c (exception_none): Change
6460         initializer.
6461         (struct catcher) <state, exception>: Initialize inline.
6462         <prev>: Remove member.
6463         (current_catcher): Remove.
6464         (catchers): New global.
6465         (exceptions_state_mc_init): Simplify.
6466         (catcher_pop): Remove.
6467         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6468         (try_scope_depth, exception_try_scope_entry)
6469         (exception_try_scope_exit): Remove.
6470         (throw_exception_sjlj): Update.
6471         (exception_messages, exception_messages_size): Remove.
6472         (throw_it): Simplify.
6473         (gdb_exception_sliced_copy): Remove.
6474         (throw_exception_cxx): Update.
6475         * cli/cli-script.c (script_from_file): Update.
6476         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6477         Update.
6478         * ada-valprint.c (ada_val_print): Update.
6479         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6480         (create_excep_cond_exprs): Update.
6481
6482 2019-04-08  Tom Tromey  <tom@tromey.com>
6483
6484         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6485         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6486         (TRY, CATCH, END_CATCH): Remove some definitions.
6487         * common/common-exceptions.c: Don't use GDB_XCPT.
6488         (catcher_list_size): Remove.
6489         (throw_exception, throw_it): Simplify.
6490
6491 2019-04-05  Tom Tromey  <tom@tromey.com>
6492
6493         Revert the header-sorting patch.
6494         * ft32-tdep.c: Revert.
6495         * frv-tdep.c: Revert.
6496         * frv-linux-tdep.c: Revert.
6497         * frame.c: Revert.
6498         * frame-unwind.c: Revert.
6499         * frame-base.c: Revert.
6500         * fork-child.c: Revert.
6501         * findvar.c: Revert.
6502         * findcmd.c: Revert.
6503         * filesystem.c: Revert.
6504         * filename-seen-cache.h: Revert.
6505         * filename-seen-cache.c: Revert.
6506         * fbsd-tdep.c: Revert.
6507         * fbsd-nat.h: Revert.
6508         * fbsd-nat.c: Revert.
6509         * f-valprint.c: Revert.
6510         * f-typeprint.c: Revert.
6511         * f-lang.c: Revert.
6512         * extension.h: Revert.
6513         * extension.c: Revert.
6514         * extension-priv.h: Revert.
6515         * expprint.c: Revert.
6516         * exec.h: Revert.
6517         * exec.c: Revert.
6518         * exceptions.c: Revert.
6519         * event-top.c: Revert.
6520         * event-loop.c: Revert.
6521         * eval.c: Revert.
6522         * elfread.c: Revert.
6523         * dwarf2read.h: Revert.
6524         * dwarf2read.c: Revert.
6525         * dwarf2loc.c: Revert.
6526         * dwarf2expr.h: Revert.
6527         * dwarf2expr.c: Revert.
6528         * dwarf2-frame.c: Revert.
6529         * dwarf2-frame-tailcall.c: Revert.
6530         * dwarf-index-write.h: Revert.
6531         * dwarf-index-write.c: Revert.
6532         * dwarf-index-common.c: Revert.
6533         * dwarf-index-cache.h: Revert.
6534         * dwarf-index-cache.c: Revert.
6535         * dummy-frame.c: Revert.
6536         * dtrace-probe.c: Revert.
6537         * disasm.h: Revert.
6538         * disasm.c: Revert.
6539         * disasm-selftests.c: Revert.
6540         * dictionary.c: Revert.
6541         * dicos-tdep.c: Revert.
6542         * demangle.c: Revert.
6543         * dcache.h: Revert.
6544         * dcache.c: Revert.
6545         * darwin-nat.h: Revert.
6546         * darwin-nat.c: Revert.
6547         * darwin-nat-info.c: Revert.
6548         * d-valprint.c: Revert.
6549         * d-namespace.c: Revert.
6550         * d-lang.c: Revert.
6551         * ctf.c: Revert.
6552         * csky-tdep.c: Revert.
6553         * csky-linux-tdep.c: Revert.
6554         * cris-tdep.c: Revert.
6555         * cris-linux-tdep.c: Revert.
6556         * cp-valprint.c: Revert.
6557         * cp-support.c: Revert.
6558         * cp-namespace.c: Revert.
6559         * cp-abi.c: Revert.
6560         * corelow.c: Revert.
6561         * corefile.c: Revert.
6562         * continuations.c: Revert.
6563         * completer.h: Revert.
6564         * completer.c: Revert.
6565         * complaints.c: Revert.
6566         * coffread.c: Revert.
6567         * coff-pe-read.c: Revert.
6568         * cli-out.h: Revert.
6569         * cli-out.c: Revert.
6570         * charset.c: Revert.
6571         * c-varobj.c: Revert.
6572         * c-valprint.c: Revert.
6573         * c-typeprint.c: Revert.
6574         * c-lang.c: Revert.
6575         * buildsym.c: Revert.
6576         * buildsym-legacy.c: Revert.
6577         * build-id.h: Revert.
6578         * build-id.c: Revert.
6579         * btrace.c: Revert.
6580         * bsd-uthread.c: Revert.
6581         * breakpoint.h: Revert.
6582         * breakpoint.c: Revert.
6583         * break-catch-throw.c: Revert.
6584         * break-catch-syscall.c: Revert.
6585         * break-catch-sig.c: Revert.
6586         * blockframe.c: Revert.
6587         * block.c: Revert.
6588         * bfin-tdep.c: Revert.
6589         * bfin-linux-tdep.c: Revert.
6590         * bfd-target.c: Revert.
6591         * bcache.c: Revert.
6592         * ax-general.c: Revert.
6593         * ax-gdb.h: Revert.
6594         * ax-gdb.c: Revert.
6595         * avr-tdep.c: Revert.
6596         * auxv.c: Revert.
6597         * auto-load.c: Revert.
6598         * arm-wince-tdep.c: Revert.
6599         * arm-tdep.c: Revert.
6600         * arm-symbian-tdep.c: Revert.
6601         * arm-pikeos-tdep.c: Revert.
6602         * arm-obsd-tdep.c: Revert.
6603         * arm-nbsd-tdep.c: Revert.
6604         * arm-nbsd-nat.c: Revert.
6605         * arm-linux-tdep.c: Revert.
6606         * arm-linux-nat.c: Revert.
6607         * arm-fbsd-tdep.c: Revert.
6608         * arm-fbsd-nat.c: Revert.
6609         * arm-bsd-tdep.c: Revert.
6610         * arch-utils.c: Revert.
6611         * arc-tdep.c: Revert.
6612         * arc-newlib-tdep.c: Revert.
6613         * annotate.h: Revert.
6614         * annotate.c: Revert.
6615         * amd64-windows-tdep.c: Revert.
6616         * amd64-windows-nat.c: Revert.
6617         * amd64-tdep.c: Revert.
6618         * amd64-sol2-tdep.c: Revert.
6619         * amd64-obsd-tdep.c: Revert.
6620         * amd64-obsd-nat.c: Revert.
6621         * amd64-nbsd-tdep.c: Revert.
6622         * amd64-nbsd-nat.c: Revert.
6623         * amd64-nat.c: Revert.
6624         * amd64-linux-tdep.c: Revert.
6625         * amd64-linux-nat.c: Revert.
6626         * amd64-fbsd-tdep.c: Revert.
6627         * amd64-fbsd-nat.c: Revert.
6628         * amd64-dicos-tdep.c: Revert.
6629         * amd64-darwin-tdep.c: Revert.
6630         * amd64-bsd-nat.c: Revert.
6631         * alpha-tdep.c: Revert.
6632         * alpha-obsd-tdep.c: Revert.
6633         * alpha-nbsd-tdep.c: Revert.
6634         * alpha-mdebug-tdep.c: Revert.
6635         * alpha-linux-tdep.c: Revert.
6636         * alpha-linux-nat.c: Revert.
6637         * alpha-bsd-tdep.c: Revert.
6638         * alpha-bsd-nat.c: Revert.
6639         * aix-thread.c: Revert.
6640         * agent.c: Revert.
6641         * addrmap.c: Revert.
6642         * ada-varobj.c: Revert.
6643         * ada-valprint.c: Revert.
6644         * ada-typeprint.c: Revert.
6645         * ada-tasks.c: Revert.
6646         * ada-lang.c: Revert.
6647         * aarch64-tdep.c: Revert.
6648         * aarch64-ravenscar-thread.c: Revert.
6649         * aarch64-newlib-tdep.c: Revert.
6650         * aarch64-linux-tdep.c: Revert.
6651         * aarch64-linux-nat.c: Revert.
6652         * aarch64-fbsd-tdep.c: Revert.
6653         * aarch64-fbsd-nat.c: Revert.
6654         * aarch32-linux-nat.c: Revert.
6655
6656 2019-04-05  Tom Tromey  <tom@tromey.com>
6657
6658         * ft32-tdep.c: Sort headers.
6659         * frv-tdep.c: Sort headers.
6660         * frv-linux-tdep.c: Sort headers.
6661         * frame.c: Sort headers.
6662         * frame-unwind.c: Sort headers.
6663         * frame-base.c: Sort headers.
6664         * fork-child.c: Sort headers.
6665         * findvar.c: Sort headers.
6666         * findcmd.c: Sort headers.
6667         * filesystem.c: Sort headers.
6668         * filename-seen-cache.h: Sort headers.
6669         * filename-seen-cache.c: Sort headers.
6670         * fbsd-tdep.c: Sort headers.
6671         * fbsd-nat.h: Sort headers.
6672         * fbsd-nat.c: Sort headers.
6673         * f-valprint.c: Sort headers.
6674         * f-typeprint.c: Sort headers.
6675         * f-lang.c: Sort headers.
6676         * extension.h: Sort headers.
6677         * extension.c: Sort headers.
6678         * extension-priv.h: Sort headers.
6679         * expprint.c: Sort headers.
6680         * exec.h: Sort headers.
6681         * exec.c: Sort headers.
6682         * exceptions.c: Sort headers.
6683         * event-top.c: Sort headers.
6684         * event-loop.c: Sort headers.
6685         * eval.c: Sort headers.
6686         * elfread.c: Sort headers.
6687         * dwarf2read.h: Sort headers.
6688         * dwarf2read.c: Sort headers.
6689         * dwarf2loc.c: Sort headers.
6690         * dwarf2expr.h: Sort headers.
6691         * dwarf2expr.c: Sort headers.
6692         * dwarf2-frame.c: Sort headers.
6693         * dwarf2-frame-tailcall.c: Sort headers.
6694         * dwarf-index-write.h: Sort headers.
6695         * dwarf-index-write.c: Sort headers.
6696         * dwarf-index-common.c: Sort headers.
6697         * dwarf-index-cache.h: Sort headers.
6698         * dwarf-index-cache.c: Sort headers.
6699         * dummy-frame.c: Sort headers.
6700         * dtrace-probe.c: Sort headers.
6701         * disasm.h: Sort headers.
6702         * disasm.c: Sort headers.
6703         * disasm-selftests.c: Sort headers.
6704         * dictionary.c: Sort headers.
6705         * dicos-tdep.c: Sort headers.
6706         * demangle.c: Sort headers.
6707         * dcache.h: Sort headers.
6708         * dcache.c: Sort headers.
6709         * darwin-nat.h: Sort headers.
6710         * darwin-nat.c: Sort headers.
6711         * darwin-nat-info.c: Sort headers.
6712         * d-valprint.c: Sort headers.
6713         * d-namespace.c: Sort headers.
6714         * d-lang.c: Sort headers.
6715         * ctf.c: Sort headers.
6716         * csky-tdep.c: Sort headers.
6717         * csky-linux-tdep.c: Sort headers.
6718         * cris-tdep.c: Sort headers.
6719         * cris-linux-tdep.c: Sort headers.
6720         * cp-valprint.c: Sort headers.
6721         * cp-support.c: Sort headers.
6722         * cp-namespace.c: Sort headers.
6723         * cp-abi.c: Sort headers.
6724         * corelow.c: Sort headers.
6725         * corefile.c: Sort headers.
6726         * continuations.c: Sort headers.
6727         * completer.h: Sort headers.
6728         * completer.c: Sort headers.
6729         * complaints.c: Sort headers.
6730         * coffread.c: Sort headers.
6731         * coff-pe-read.c: Sort headers.
6732         * cli-out.h: Sort headers.
6733         * cli-out.c: Sort headers.
6734         * charset.c: Sort headers.
6735         * c-varobj.c: Sort headers.
6736         * c-valprint.c: Sort headers.
6737         * c-typeprint.c: Sort headers.
6738         * c-lang.c: Sort headers.
6739         * buildsym.c: Sort headers.
6740         * buildsym-legacy.c: Sort headers.
6741         * build-id.h: Sort headers.
6742         * build-id.c: Sort headers.
6743         * btrace.c: Sort headers.
6744         * bsd-uthread.c: Sort headers.
6745         * breakpoint.h: Sort headers.
6746         * breakpoint.c: Sort headers.
6747         * break-catch-throw.c: Sort headers.
6748         * break-catch-syscall.c: Sort headers.
6749         * break-catch-sig.c: Sort headers.
6750         * blockframe.c: Sort headers.
6751         * block.c: Sort headers.
6752         * bfin-tdep.c: Sort headers.
6753         * bfin-linux-tdep.c: Sort headers.
6754         * bfd-target.c: Sort headers.
6755         * bcache.c: Sort headers.
6756         * ax-general.c: Sort headers.
6757         * ax-gdb.h: Sort headers.
6758         * ax-gdb.c: Sort headers.
6759         * avr-tdep.c: Sort headers.
6760         * auxv.c: Sort headers.
6761         * auto-load.c: Sort headers.
6762         * arm-wince-tdep.c: Sort headers.
6763         * arm-tdep.c: Sort headers.
6764         * arm-symbian-tdep.c: Sort headers.
6765         * arm-pikeos-tdep.c: Sort headers.
6766         * arm-obsd-tdep.c: Sort headers.
6767         * arm-nbsd-tdep.c: Sort headers.
6768         * arm-nbsd-nat.c: Sort headers.
6769         * arm-linux-tdep.c: Sort headers.
6770         * arm-linux-nat.c: Sort headers.
6771         * arm-fbsd-tdep.c: Sort headers.
6772         * arm-fbsd-nat.c: Sort headers.
6773         * arm-bsd-tdep.c: Sort headers.
6774         * arch-utils.c: Sort headers.
6775         * arc-tdep.c: Sort headers.
6776         * arc-newlib-tdep.c: Sort headers.
6777         * annotate.h: Sort headers.
6778         * annotate.c: Sort headers.
6779         * amd64-windows-tdep.c: Sort headers.
6780         * amd64-windows-nat.c: Sort headers.
6781         * amd64-tdep.c: Sort headers.
6782         * amd64-sol2-tdep.c: Sort headers.
6783         * amd64-obsd-tdep.c: Sort headers.
6784         * amd64-obsd-nat.c: Sort headers.
6785         * amd64-nbsd-tdep.c: Sort headers.
6786         * amd64-nbsd-nat.c: Sort headers.
6787         * amd64-nat.c: Sort headers.
6788         * amd64-linux-tdep.c: Sort headers.
6789         * amd64-linux-nat.c: Sort headers.
6790         * amd64-fbsd-tdep.c: Sort headers.
6791         * amd64-fbsd-nat.c: Sort headers.
6792         * amd64-dicos-tdep.c: Sort headers.
6793         * amd64-darwin-tdep.c: Sort headers.
6794         * amd64-bsd-nat.c: Sort headers.
6795         * alpha-tdep.c: Sort headers.
6796         * alpha-obsd-tdep.c: Sort headers.
6797         * alpha-nbsd-tdep.c: Sort headers.
6798         * alpha-mdebug-tdep.c: Sort headers.
6799         * alpha-linux-tdep.c: Sort headers.
6800         * alpha-linux-nat.c: Sort headers.
6801         * alpha-bsd-tdep.c: Sort headers.
6802         * alpha-bsd-nat.c: Sort headers.
6803         * aix-thread.c: Sort headers.
6804         * agent.c: Sort headers.
6805         * addrmap.c: Sort headers.
6806         * ada-varobj.c: Sort headers.
6807         * ada-valprint.c: Sort headers.
6808         * ada-typeprint.c: Sort headers.
6809         * ada-tasks.c: Sort headers.
6810         * ada-lang.c: Sort headers.
6811         * aarch64-tdep.c: Sort headers.
6812         * aarch64-ravenscar-thread.c: Sort headers.
6813         * aarch64-newlib-tdep.c: Sort headers.
6814         * aarch64-linux-tdep.c: Sort headers.
6815         * aarch64-linux-nat.c: Sort headers.
6816         * aarch64-fbsd-tdep.c: Sort headers.
6817         * aarch64-fbsd-nat.c: Sort headers.
6818         * aarch32-linux-nat.c: Sort headers.
6819
6820 2019-04-04  Tom Tromey  <tom@tromey.com>
6821
6822         * varobj.c (varobj_create): Update.
6823         * rust-exp.y (struct rust_parser) <update_innermost_block,
6824         lookup_symbol>: New methods.
6825         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6826         Rename.
6827         (rust_parser::rust_lookup_type)
6828         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6829         * printcmd.c (display_command, do_one_display): Update.
6830         * parser-defs.h (struct parser_state) <parser_state>: Add
6831         "tracker" parameter.
6832         (block_tracker): New member.
6833         (class innermost_block_tracker) <innermost_block_tracker>: Add
6834         "types" parameter.
6835         <reset>: Remove method.
6836         (innermost_block): Don't declare.
6837         (null_post_parser): Update.
6838         * parse.c (innermost_block): Remove global.
6839         (write_dollar_variable): Update.
6840         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6841         Remove "tracker_types" parameter.
6842         (parse_expression): Add "tracker" parameter.
6843         (parse_expression_for_completion): Update.
6844         (null_post_parser): Add "tracker" parameter.
6845         * p-exp.y: Update rules.
6846         * m2-exp.y: Update rules.
6847         * language.h (struct language_defn) <la_post_parser>: Add
6848         "tracker" parameter.
6849         * go-exp.y: Update rules.
6850         * f-exp.y: Update rules.
6851         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6852         parameter.
6853         * d-exp.y: Update rules.
6854         * c-exp.y: Update rules.
6855         * breakpoint.c (set_breakpoint_condition): Create an
6856         innermost_block_tracker.
6857         (watch_command_1): Likewise.
6858         * ada-lang.c (resolve): Add "tracker" parameter.
6859         (resolve_subexp): Likewise.
6860         * ada-exp.y (write_var_from_sym): Update.
6861
6862 2019-04-04  Tom Tromey  <tom@tromey.com>
6863
6864         * type-stack.h: New file.
6865         * type-stack.c: New file.
6866         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6867         type-stack.h.
6868         (insert_into_type_stack, insert_type, push_type, push_type_int)
6869         (insert_type_address_space, pop_type, pop_type_int)
6870         (pop_typelist, pop_type_stack, append_type_stack)
6871         (push_type_stack, get_type_stack, push_typelist)
6872         (follow_type_instance_flags, follow_types): Don't declare.
6873         * parse.c (type_stack): Remove global.
6874         (parse_exp_in_context): Update.
6875         (insert_into_type_stack, insert_type, push_type, push_type_int)
6876         (insert_type_address_space, pop_type, pop_type_int)
6877         (pop_typelist, pop_type_stack, append_type_stack)
6878         (push_type_stack, get_type_stack, push_typelist)
6879         (follow_type_instance_flags, follow_types): Remove (moved to
6880         type-stack.c).
6881         * f-exp.y (type_stack): New global.
6882         Update rules.
6883         (push_kind_type, f_parse): Update.
6884         * d-exp.y (type_stack): New global.
6885         Update rules.
6886         (d_parse): Update.
6887         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6888         Update rules.
6889         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6890         (HFILES_NO_SRCDIR): Add type-stack.h.
6891
6892 2019-04-04  Tom Tromey  <tom@tromey.com>
6893
6894         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6895         (rust_parser::convert_ast_to_expression, rust_parse)
6896         (rust_lex_test_completion, rust_lex_tests): Update.
6897         * parser-defs.h (struct expr_completion_state): New.
6898         (struct parser_state) <parser_state>: Add completion parameter.
6899         <mark_struct_expression, mark_completion_tag>: New methods.
6900         <parse_completion, m_completion_state>: New members.
6901         (prefixify_expression, null_post_parser): Update.
6902         (mark_struct_expression, mark_completion_tag): Don't declare.
6903         * parse.c (parse_completion, expout_last_struct)
6904         (expout_tag_completion_type, expout_completion_name): Remove
6905         globals.
6906         (parser_state::mark_struct_expression)
6907         (parser_state::mark_completion_tag): Now methods.
6908         (prefixify_expression): Add last_struct parameter.
6909         (prefixify_subexp): Likewise.
6910         (parse_exp_1): Update.
6911         (parse_exp_in_context): Add cstate parameter.  Update.
6912         (parse_expression_for_completion): Create an
6913         expr_completion_state.
6914         (null_post_parser): Add "completion" parameter.
6915         * p-exp.y: Update rules.
6916         (yylex): Update.
6917         * language.h (struct language_defn) <la_post_parser>: Add
6918         "completing" parameter.
6919         * go-exp.y: Update rules.
6920         (lex_one_token): Update.
6921         * expression.h (parse_completion): Don't declare.
6922         * d-exp.y: Update rules.
6923         (lex_one_token): Update rules.
6924         * c-exp.y: Update rules.
6925         (lex_one_token): Update.
6926         * ada-lang.c (resolve): Add "parse_completion" parameter.
6927         (resolve_subexp): Likewise.
6928         (ada_resolve_function): Likewise.
6929
6930 2019-04-04  Tom Tromey  <tom@tromey.com>
6931
6932         * parser-defs.h (struct parser_state) <start_arglist,
6933         end_arglist>: New methods.
6934         <arglist_len, m_funcall_chain>: New members.
6935         (arglist_len, start_arglist, end_arglist): Don't declare.
6936         * parse.c (arglist_len, funcall_chain): Remove global.
6937         (start_arglist, end_arglist): Remove functions.
6938         (parse_exp_in_context): Update.
6939         * p-exp.y: Update rules.
6940         * m2-exp.y: Update rules.
6941         * go-exp.y: Update rules.
6942         * f-exp.y: Update rules.
6943         * d-exp.y: Update rules.
6944         * c-exp.y: Update rules.
6945
6946 2019-04-04  Tom Tromey  <tom@tromey.com>
6947
6948         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6949         lex_operator, push_back>: New methods.
6950         Update all rules.
6951         (rust_parser::lex_hex, lex_escape): Rename and update.
6952         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6953         (rust_parser::lex_operator): Rename and update.
6954         (rust_parser::lex_number, rustyylex, rustyyerror)
6955         (rust_lex_test_init, rust_lex_test_sequence)
6956         (rust_lex_test_push_back, rust_lex_tests): Update.
6957         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6958         parameter.
6959         <lexptr, prev_lexptr>: New members.
6960         (lexptr, prev_lexptr): Don't declare.
6961         * parse.c (lexptr, prev_lexptr): Remove globals.
6962         (parse_exp_in_context): Update.
6963         * p-exp.y (yylex, yyerror): Update.
6964         * m2-exp.y (parse_number, yylex, yyerror): Update.
6965         * go-exp.y (lex_one_token, yyerror): Update.
6966         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6967         * d-exp.y (lex_one_token, yyerror): Update.
6968         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6969         (lex_one_token, yyerror): Update.
6970         * ada-lex.l (YY_INPUT): Update.
6971         (rewind_to_char): Update.
6972         * ada-exp.y (yyerror): Update.
6973
6974 2019-04-04  Tom Tromey  <tom@tromey.com>
6975
6976         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6977         * parser-defs.h (struct parser_state) <parser_state>: Add new
6978         parameter.
6979         <comma_terminates>: New member.
6980         (comma_terminates): Don't declare global.
6981         * parse.c (comma_terminates): Remove global.
6982         (parse_exp_in_context): Update.
6983         * p-exp.y (yylex): Update.
6984         * m2-exp.y (yylex): Update.
6985         * go-exp.y (lex_one_token): Update.
6986         * f-exp.y (yylex): Update.
6987         * d-exp.y (lex_one_token): Update.
6988         * c-exp.y (lex_one_token): Update.
6989         * ada-lex.l: Update.
6990
6991 2019-04-04  Tom Tromey  <tom@tromey.com>
6992
6993         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6994         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6995         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6996         * parser-defs.h (paren_depth): Don't declare.
6997         * parse.c (paren_depth): Remove global.
6998         (parse_exp_in_context): Update.
6999         * p-exp.y (paren_depth): New global.
7000         (pascal_parse): Initialize it.
7001         * m2-exp.y (paren_depth): New global.
7002         (m2_parse): Initialize it.
7003         * go-exp.y (paren_depth): New global.
7004         (go_parse): Initialize it.
7005         * f-exp.y (paren_depth): New global.
7006         (f_parse): Initialize it.
7007         * d-exp.y (paren_depth): New global.
7008         (d_parse): Initialize it.
7009         * c-exp.y (paren_depth): New global.
7010         (c_parse): Initialize it.
7011         * ada-lex.l (paren_depth): New global.
7012         (lexer_init): Initialize it.
7013
7014 2019-04-04  Tom Tromey  <tom@tromey.com>
7015
7016         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7017         (rust_parser::convert_ast_to_type)
7018         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7019         * parser-defs.h (struct parser_state) <parser_state>: Add
7020         parameters.  Initialize new members.
7021         <expression_context_block, expression_context_pc>: New members.
7022         * parse.c (expression_context_block, expression_context_pc):
7023         Remove globals.
7024         (parse_exp_in_context): Update.
7025         * p-exp.y: Update all rules.
7026         (yylex): Update.
7027         * m2-exp.y: Update all rules.
7028         (yylex): Update.
7029         * go-exp.y (yylex): Update.
7030         * f-exp.y (yylex): Update.
7031         * d-exp.y: Update all rules.
7032         (yylex): Update.
7033         * c-exp.y: Update all rules.
7034         (lex_one_token, classify_name, yylex, c_parse): Update.
7035         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7036
7037 2019-04-04  Tom Tromey  <tom@tromey.com>
7038
7039         * gdbarch.h, gdbarch.c: Rebuild.
7040         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7041         * stap-probe.h:
7042         (struct stap_parse_info): Replace "parser_state" with
7043         "expr_builder".
7044         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7045         (parser_state): New class.
7046         * parse.c (expr_builder): Rename.
7047         (expr_builder::release): Rename.
7048         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7049         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7050         (write_exp_elt_longcst, write_exp_elt_floatcst)
7051         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7052         (write_exp_string_vector, write_exp_bitstring)
7053         (write_exp_msymbol, mark_struct_expression)
7054         (write_dollar_variable)
7055         (insert_type_address_space, increase_expout_size): Replace
7056         "parser_state" with "expr_builder".
7057         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7058         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7059         "parser_state" with "expr_builder".
7060
7061 2019-04-04  Tom Tromey  <tom@tromey.com>
7062
7063         * rust-exp.y: Replace "parse_language" with method call.
7064         * p-exp.y:
7065         (yylex): Replace "parse_language" with method call.
7066         * m2-exp.y:
7067         (yylex): Replace "parse_language" with method call.
7068         * go-exp.y (classify_name): Replace "parse_language" with method
7069         call.
7070         * f-exp.y (yylex): Replace "parse_language" with method call.
7071         * d-exp.y (lex_one_token): Replace "parse_language" with method
7072         call.
7073         * c-exp.y:
7074         (lex_one_token, classify_name, yylex): Replace "parse_language"
7075         with method call.
7076         * ada-exp.y (find_primitive_type, type_char)
7077         (type_system_address): Replace "parse_language" with method call.
7078
7079 2019-04-04  Tom Tromey  <tom@tromey.com>
7080
7081         * rust-exp.y: Replace "parse_gdbarch" with method call.
7082         * parse.c (write_dollar_variable, insert_type_address_space):
7083         Replace "parse_gdbarch" with method call.
7084         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7085         call.
7086         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7087         call.
7088         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7089         "parse_gdbarch" with method call.
7090         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7091         with method call.
7092         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7093         "parse_gdbarch" with method call.
7094         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7095         "parse_gdbarch" with method call.
7096         * c-exp.y (parse_type, parse_number, classify_name): Replace
7097         "parse_gdbarch" with method call.
7098         * ada-lex.l: Replace "parse_gdbarch" with method call.
7099         * ada-exp.y (parse_type, find_primitive_type, type_char)
7100         (type_system_address): Replace "parse_gdbarch" with method call.
7101
7102 2019-04-04  Tom Tromey  <tom@tromey.com>
7103
7104         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7105         * stap-probe.c (stap_parse_argument): Update.
7106         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7107         initial_size parameter.
7108         * rust-exp.y (rust_lex_tests): Update.
7109         * parse.c (parser_state): Update.
7110         (parse_exp_in_context): Update.
7111         * parser-defs.h (struct parser_state) <parser_state>: Remove
7112         "initial_size" parameter.
7113
7114 2019-04-04  Tom Tromey  <tom@tromey.com>
7115
7116         * parser-defs.h (increase_expout_size): Don't declare.
7117         * parse.c (increase_expout_size): Now static.
7118
7119 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7120
7121         * gnu-nat.c (gnu_nat_target::wait): Fix
7122         target_waitstatus_to_string call.
7123
7124 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7125
7126         * eval.c (evaluate_subexp_standard): Handle internal functions
7127         during Fortran function call handling.
7128
7129 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7130
7131         * NEWS: Mention new internal functions.
7132         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7133         (read_base_type): Use dwarf2_init_complex_target_type.
7134         * value.c (creal_internal_fn): New function.
7135         (cimag_internal_fn): New function.
7136         (_initialize_values): Register new internal functions.
7137
7138 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7139
7140         * infrun.c (stop_all_threads): If debug_infrun, always
7141         trace the wait status after wait_one, using
7142         target_waitstatus_to_string and target_pid_to_str.
7143         (handle_inferior_event): Replace various trace of
7144         wait status kind by a single trace.
7145         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7146         wait status kind image by target_waitstatus_to_string.
7147         * target/waitstatus.c (target_waitstatus_to_string): Fix
7148         obsolete comment.
7149
7150 2019-04-01  Tom Tromey  <tromey@adacore.com>
7151
7152         PR symtab/23331:
7153         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7154
7155 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7156             Pedro Alves  <palves@redhat.com>
7157
7158         * top.c (quit_force): Call 'finalize_values'.
7159         * value.c (finalize_values): New function.
7160         * value.h (finalize_values): Declare.
7161
7162 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7163
7164         * NEWS: Announce $_gdb_major and $_gdb_minor.
7165
7166         * top.c (init_gdb_version_vars): New function.
7167         (gdb_init): Call init_gdb_version_vars.
7168
7169 2019-03-29  Tom Tromey  <tromey@adacore.com>
7170
7171         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7172         help text.  Remove dead code.
7173
7174 2019-03-29  Keith Seitz  <keiths@redhat.com>
7175
7176         From Siddhesh Poyarekar:
7177         * f-lang.h (f77_get_upperbound): Return LONGEST.
7178         (f77_get_lowerbound): Likewise.
7179         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7180         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7181         print them.
7182         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7183         plongest to format print it.
7184         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7185         (f77_get_upperbound): Likewise.
7186         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7187         LOWER_BOUND to LONGEST.
7188         (f77_create_arrayprint_offset_tbl): Likewise.
7189
7190 2019-03-29  Keith Seitz  <keiths@redhat.com>
7191
7192         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7193         %s/pulongest for TYPE_LENGTH instead of %d in format
7194         strings.
7195         * ada-typerint.c (ada_print_type): Likewise.
7196         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7197         * compile/compile-c-support.c (generate_register_struct): Likewise.
7198         * gdbtypes.c (recursive_dump_type): Likewise.
7199         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7200         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7201         instead of %d in format strings.
7202         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7203         to std::min to ULONGEST.
7204         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7205         instead of %d in format strings.
7206         * tracepoint.c (info_scope_command): Likewise.
7207         * typeprint.c (print_offset_data::update)
7208         (print_offset_data::finish): Likewise.
7209         * xtensa-tdep.c (xtensa_store_return_value)
7210         (xtensa_push_dummy_call): Likewise.
7211
7212 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7213
7214         * windows-nat.c (display_selector): Fixed format specifications
7215         for 64-bit Cygwin.
7216
7217 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7218
7219         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7220
7221 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7222
7223         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7224         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7225         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7226         (nios2_linux_init_abi): Install it.
7227
7228 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7229
7230         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7231
7232 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7233
7234         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7235
7236 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7237             Tom Tromey  <tromey@adacore.com>
7238
7239         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7240
7241 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7242
7243         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7244         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7245         method to compute the bounds of range types. Also print "[evaluated]"
7246         if the bounds' values come from a dynamic evaluation.
7247
7248 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7249
7250         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7251         whitespace when pretty printing is on.
7252
7253 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7254
7255         * ppc-linux-nat.c: Add include.
7256
7257 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7258
7259         * NEWS: Mention AArch64 Pointer Authentication.
7260
7261 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7262
7263         * arm-linux-nat.c: Add include.
7264
7265 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7266
7267         * source-cache.c (source_cache::get_source_lines): Re-read
7268         fullname after calling open_source_file.
7269
7270 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7271
7272         * NEWS: Mention TLS support for FreeBSD.
7273
7274 2019-03-25  Tom Tromey  <tromey@adacore.com>
7275
7276         * minsyms.c (BUNCH_SIZE): Update comment.
7277         (~minimal_symbol_reader): Remove old comment.
7278         (compact_minimal_symbols): Update comment.
7279         (minimal_symbol_reader::install): Remove old comment.  Update
7280         other comments.
7281
7282 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7283
7284         * s390-linux-nat.c: Add include.
7285
7286 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7287
7288         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7289         Call linux_get_hwcap.
7290         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7291         Likewise.
7292         (aarch64_linux_get_hwcap): Remove function.
7293         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7294         declaration.
7295         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7296         linux_get_hwcap.
7297         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7298         * linux-tdep.c (linux_get_hwcap): Add function.
7299         (linux_get_hwcap2): Likewise.
7300         * linux-tdep.h (linux_get_hwcap): Add declaration.
7301         (linux_get_hwcap2): Likewise.
7302         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7303         (ppc_linux_get_hwcap2): Likewise.
7304         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7305         linux_get_hwcap.
7306         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7307         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7308         (ppc_linux_nat_target::read_description): Likewise.
7309         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7310         * s390-linux-nat.c: Likewise.
7311         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7312
7313 2019-03-24  Tom Tromey  <tom@tromey.com>
7314
7315         * ada-lang.c (standard_lookup): Simplify initialization.
7316         (ada_lookup_symbol_nonlocal): Simplify return.
7317         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7318         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7319         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7320         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7321         initialization.
7322         * solib.c (solib_global_lookup): Simplify.
7323         * symtab.c (null_block_symbol): Remove.
7324         (symbol_cache_lookup): Simplify returns.
7325         (lookup_language_this): Simplify returns.
7326         (lookup_symbol_aux): Simplify return.
7327         (lookup_local_symbol): Simplify returns.
7328         (lookup_global_symbol_from_objfile): Simplify return.
7329         (lookup_symbol_in_objfile_symtabs)
7330         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7331         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7332         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7333         * cp-namespace.c (cp_lookup_bare_symbol)
7334         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7335         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7336         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7337         (cp_lookup_symbol_via_imports): Simplify initialization.
7338         (find_symbol_in_baseclass): Likewise.
7339         * symtab.h (null_block_symbol): Remove.
7340         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7341         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7342         (d_lookup_symbol_module): Likewise.
7343         (find_symbol_in_baseclass): Simplify initialization.
7344
7345 2019-03-24  Tom Tromey  <tom@tromey.com>
7346
7347         * expression.h: Don't include symtab.h.
7348         (struct block): Forward declare.
7349
7350 2019-03-24  Tom Tromey  <tom@tromey.com>
7351
7352         * c-exp.y (typebase): Remove casts.
7353         * gdbtypes.c (lookup_unsigned_typename, )
7354         (lookup_signed_typename): Remove cast.
7355         * eval.c (parse_to_comma_and_eval): Remove cast.
7356         * parse.c (write_dollar_variable): Remove cast.
7357         * block.h (struct block) <superblock>: Now const.
7358         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7359         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7360         (map_block): Make "block" const.
7361         * symfile.h (struct quick_symbol_functions)
7362         <map_matching_symbols>: Constify block argument to "callback".
7363         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7364         const.
7365         (find_pc_sect_compunit_symtab): Make "b" const.
7366         (find_symbol_at_address): Likewise.
7367         (search_symbols): Likewise.
7368         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7369         (dw2_debug_names_lookup_symbol): Likewise.
7370         (dw2_map_matching_symbols): Update.
7371         * p-valprint.c (pascal_val_print): Remove "block".
7372         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7373         (aux_add_nonlocal_symbols): Make "block" const.
7374         (resolve_subexp): Remove cast.
7375         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7376         const.
7377         (iterate_over_file_blocks): Likewise.
7378         * f-exp.y (%union) <bval>: Remove.
7379         * coffread.c (patch_opaque_types): Make "b" const.
7380         * spu-tdep.c (spu_catch_start): Make "block" const.
7381         * c-valprint.c (print_unpacked_pointer): Remove "block".
7382         * symmisc.c (dump_symtab_1): Make "b" const.
7383         (block_depth): Make "block" const.
7384         * d-exp.y (%union) <bval>: Remove.
7385         * cp-support.h (cp_lookup_rtti_type): Update.
7386         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7387         * psymtab.c (psym_lookup_symbol): Make "block" const.
7388         (maintenance_check_psymtabs): Make "b" const.
7389         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7390         (enumerate_locals, enumerate_args): Update.
7391         * python/py-symtab.c (stpy_global_block): Make "block" const.
7392         (stpy_static_block): Likewise.
7393         * inline-frame.c (block_starting_point_at): Make "new_block"
7394         const.
7395         * block.c (find_block_in_blockvector): Make return type const.
7396         (blockvector_for_pc_sect): Make "b" const.
7397         (find_block_in_blockvector): Make "b" const.
7398
7399 2019-03-23  Tom Tromey  <tom@tromey.com>
7400
7401         * varobj.c (varobj_create): Update.
7402         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7403         * printcmd.c (display_command, do_one_display): Don't reset
7404         innermost_block.
7405         * parser-defs.h (enum innermost_block_tracker_type): Move to
7406         expression.h.
7407         (innermost_block): Update comment.
7408         * parse.c (parse_exp_1): Add tracker_types parameter.
7409         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7410         tracker_types parameter.  Reset innermost_block.
7411         (parse_exp_in_context): Remove.
7412         (parse_expression_for_completion): Update.
7413         * objfiles.c (~objfile): Don't reset expression_context_block or
7414         innermost_block.
7415         * expression.h (enum innermost_block_tracker_type): Move from
7416         parser-defs.h.
7417         (parse_exp_1): Add tracker_types parameter.
7418         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7419         reset innermost_block.
7420
7421 2019-03-23  Tom Tromey  <tom@tromey.com>
7422
7423         * objfiles.h: Include bcache.h.
7424
7425 2019-03-23  Tom Tromey  <tom@tromey.com>
7426
7427         * linespec.c (get_current_search_block): Use
7428         scoped_restore_current_language.
7429         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7430
7431 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7432             Jiong Wang  <jiong.wang@arm.com>
7433
7434         * aarch64-linux-tdep.c
7435         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7436         section.
7437         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7438
7439 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7440             Jiong Wang  <jiong.wang@arm.com>
7441
7442         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7443         instructions.
7444         (aarch64_analyze_prologue_test): Add PACIASP test.
7445         (aarch64_prologue_prev_register): Unmask PC value.
7446
7447 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7448             Jiong Wang  <jiong.wang@arm.com>
7449
7450         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7451         (aarch64_dwarf2_prev_register): Unmask PC value.
7452         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7453         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7454         DW_CFA_AARCH64_negate_ra_state.
7455         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7456
7457 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7458             Jiong Wang  <jiong.wang@arm.com>
7459
7460         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7461         registers.
7462         (aarch64_pseudo_register_name): Likewise.
7463         (aarch64_pseudo_register_type): Likewise.
7464         (aarch64_pseudo_register_reggroup_p): Likewise.
7465         (aarch64_gdbarch_init): Add pauth registers.
7466         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7467         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7468         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7469         (struct gdbarch_tdep): Add regnum for ra_state.
7470
7471 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7472             Jiong Wang  <jiong.wang@arm.com>
7473
7474         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7475
7476 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7477             Jiong Wang  <jiong.wang@arm.com>
7478
7479         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7480         function.
7481         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7482         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7483         (aarch64_gdbarch_init): Add puth registers.
7484         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7485         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7486         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7487
7488 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7489             Jiong Wang  <jiong.wang@arm.com>
7490
7491         * aarch64-linux-nat.c
7492         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7493         * aarch64-linux-tdep.c
7494         (aarch64_linux_core_read_description): Likewise.
7495         (aarch64_linux_get_hwcap): New function.
7496         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7497         (aarch64_linux_get_hwcap): New declaration.
7498
7499 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7500             Jiong Wang  <jiong.wang@arm.com>
7501
7502         * aarch64-linux-nat.c
7503         (aarch64_linux_nat_target::read_description): Add pauth param.
7504         * aarch64-linux-tdep.c
7505         (aarch64_linux_core_read_description): Likewise.
7506         * aarch64-tdep.c (struct target_desc): Add in pauth.
7507         (aarch64_read_description): Add pauth param.
7508         (aarch64_gdbarch_init): Likewise.
7509         * aarch64-tdep.h (aarch64_read_description): Likewise.
7510         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7511         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7512         * features/Makefile: Add new files.
7513         * features/aarch64-pauth.c: New file.
7514         * features/aarch64-pauth.xml: New file.
7515
7516 2019-03-20  Tom Tromey  <tromey@adacore.com>
7517
7518         * infrun.c (handle_inferior_event): Rename from
7519         handle_inferior_event_1.  Create a scoped_value_mark.
7520         (handle_inferior_event): Remove.
7521
7522 2019-03-19  Tom Tromey  <tromey@adacore.com>
7523
7524         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7525         * infrun.h (print_stop_event): Add "displays" parameter.
7526         * infrun.c (print_stop_event): Add "displays" parameter.
7527
7528 2019-03-19  Pedro Alves  <palves@redhat.com>
7529
7530         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7531         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7532         to -1.  Fix TABs vs spaces.
7533         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7534         * tui/tui-out.h (tui_ui_out) Add intro comments.
7535         <m_line, m_start_of_line>: In-class initialize, and add describing
7536         comment.
7537
7538 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7539
7540         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7541         variable names.
7542         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7543
7544 2019-03-18  Pedro Alves  <palves@redhat.com>
7545             Eli Zaretskii <eliz@gnu.org>
7546
7547         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7548         m_line and m_start_of_line.
7549
7550 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7551
7552         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7553         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7554         it returns a newline.  This fixes a regression in TU mode, whereby
7555         the next line is output on the same screen line as the user input.
7556
7557 2019-03-18  Tom Tromey  <tromey@adacore.com>
7558
7559         * minsyms.c (minimal_symbol_reader::install): Remove call to
7560         obstack_blank.
7561
7562 2019-03-18  Pedro Alves  <palves@redhat.com>
7563
7564         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7565         New globals.
7566         (apply_style): New, factored out from ...
7567         (apply_ansi_escape): ... this.  Handle reverse video mode.
7568         (tui_set_reverse_mode): New function.
7569         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7570         * tui/tui-winsource.c (tui_show_source_line): Use
7571         tui_set_reverse_mode instead of setting A_STANDOUT.
7572         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7573         New setter methods.
7574
7575 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7576
7577         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7578         Handle tabs.
7579
7580 2019-03-18  Tom Tromey  <tromey@adacore.com>
7581
7582         * ada-lang.c (empty_array): Add "high" parameter.
7583         (ada_evaluate_subexp): Update.
7584
7585 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7586
7587         * unittests/string_view-selftests.c: Define
7588         _initialize_string_view_selftests unconditionally.
7589
7590 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7591
7592         PR gdb/24350
7593         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7594
7595 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7596
7597         PR gdb/24351
7598         * windows-nat.c (display_selector): Fix format specifiers.
7599
7600 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7601
7602         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7603         tui_refill_source_window instead of tui_refresh_win, to update the
7604         current execution line.  This fixes redisplay of the current line
7605         when stepping through the code with "next" or "step".
7606
7607 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7608
7609         * source-cache.c (source_cache::get_source_lines): Call
7610         find_source_lines to initialize s->nlines.  This fixes vertical
7611         scrolling of TUI source window when the DOWN arrow is pressed.
7612
7613 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7614
7615         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7616         linux-thread-db.c (_initialize_thread_db): Likewise.
7617
7618 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7619
7620         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7621         wclrtoeol in tui_show_source_line".  This reverts changes made in
7622         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7623
7624 2019-03-15  Tom Tromey  <tom@tromey.com>
7625
7626         * symtab.h (struct minimal_symbol): Derive from
7627         general_symbol_info.
7628         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7629         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7630         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7631         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7632         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7633         (MSYMBOL_SEARCH_NAME): Update.
7634         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7635         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7636         * minsyms.c (minimal_symbol_reader::record_full): Update.
7637
7638 2019-03-15  Tom Tromey  <tom@tromey.com>
7639
7640         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7641
7642 2019-03-15  Tom Tromey  <tom@tromey.com>
7643
7644         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7645         unique_xmalloc_ptr.
7646         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7647         Update.
7648         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7649         (build_minimal_symbol_hash_tables)
7650         (minimal_symbol_reader::install): Update.
7651
7652 2019-03-15  Tom Tromey  <tom@tromey.com>
7653
7654         * symtab.c (create_demangled_names_hash): Update.
7655         (symbol_set_names): Update.
7656         * objfiles.h (struct objfile_per_bfd_storage)
7657         <demangled_names_hash>: Now an htab_up.
7658         * objfiles.c (objfile_per_bfd_storage): Simplify.
7659
7660 2019-03-15  Tom Tromey  <tom@tromey.com>
7661
7662         * objfiles.h (struct objfile_per_bfd_storage): Declare
7663         destructor.
7664         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7665         New.
7666         (get_objfile_bfd_data): Use new.  Don't initialize
7667         language_of_main.
7668         (free_objfile_per_bfd_storage): Remove.
7669         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7670
7671 2019-03-15  Tom Tromey  <tom@tromey.com>
7672
7673         * symfile.c (reread_symbols): Update.
7674         * objfiles.c (objfile::objfile): Update.
7675         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7676         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7677         comment.
7678         (minimal_symbol_reader::install): Update.
7679         (terminate_minimal_symbol_table): Remove.
7680         * jit.c (jit_object_close_impl): Update.
7681
7682 2019-03-15  Tom Tromey  <tom@tromey.com>
7683
7684         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7685         initializations.
7686
7687 2019-03-15  Tom Tromey  <tom@tromey.com>
7688
7689         * objfiles.h (struct objfile_per_bfd_storage)
7690         <demangled_hash_languages>: Now a bitset.
7691         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7692         (lookup_minimal_symbol): Update.
7693
7694 2019-03-15  Tom Tromey  <tom@tromey.com>
7695
7696         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7697         Don't return the symbol.
7698         * coffread.c (record_minimal_symbol): Use record_full.
7699
7700 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7701
7702         The MS-Windows port of ncurses fails to switch to a color pair if
7703         one or both of the colors are the implicit default colors.  This
7704         change records the default colors when TUI is initialized, and
7705         then specifies them explicitly when a color pair uses the default
7706         colors.  This allows color styling in TUI mode on MS-Windows.
7707
7708         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7709         ncurses_norm_attr.
7710         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7711         colors in ncurses_norm_attr.
7712         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7713         "none", replace it with the default color recorded in
7714         ncurses_norm_attr.
7715
7716 2019-03-14  Tom Tromey  <tromey@adacore.com>
7717
7718         * source-cache.h (class source_cache) <get_source_lines>: Return
7719         std::string.
7720         * source-cache.c (source_cache::extract_lines): Handle case where
7721         first_pos==npos.  Return std::string.
7722         (source_cache::get_source_lines): Update.
7723
7724 2019-03-14  Tom Tromey  <tromey@adacore.com>
7725
7726         * NEWS: Add item for "style sources" commands.
7727         * source-cache.c (source_cache::get_source_lines): Check
7728         source_styling.
7729         * cli/cli-style.c (source_styling): New global.
7730         (_initialize_cli_style): Add "style sources" commands.
7731         (show_style_sources): New function.
7732         * cli/cli-style.h (source_styling): Declare.
7733
7734 2019-03-14  Pedro Alves  <palves@redhat.com>
7735             Tom Tromey  <tromey@adacore.com>
7736
7737         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7738         * tui/tui-winsource.c (tui_refill_source_window): New function,
7739         from...
7740         (tui_horizontal_source_scroll): ... here.  Move some logic.
7741         * cli/cli-style.c (set_style_enabled): Notify new observable.
7742         * tui/tui-hooks.c (tui_redisplay_source): New function.
7743         (tui_attach_detach_observers): Attach or detach
7744         tui_redisplay_source.
7745         * observable.h (source_styling_changed): New observable.
7746         * observable.c: Define source_styling_changed observable.
7747
7748 2019-03-13  Tom Tromey  <tromey@adacore.com>
7749
7750         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7751         (i386_gnu_nat_target::store_registers): Update.
7752         * target-debug.h (target_debug_print_std_string): New macro.
7753         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7754         * windows-tdep.c (display_one_tib): Update.
7755         * tui/tui-stack.c (tui_make_status_line): Update.
7756         * top.c (print_inferior_quit_action): Update.
7757         * thread.c (thr_try_catch_cmd): Update.
7758         (add_thread_with_info): Update.
7759         (thread_target_id_str): Update.
7760         (thr_try_catch_cmd): Update.
7761         (thread_command): Update.
7762         (thread_find_command): Update.
7763         * record-btrace.c (record_btrace_target::info_record)
7764         (record_btrace_resume_thread, record_btrace_target::resume)
7765         (record_btrace_cancel_resume, record_btrace_step_thread)
7766         (record_btrace_target::wait, record_btrace_target::wait)
7767         (record_btrace_target::wait, record_btrace_target::stop): Update.
7768         * progspace.c (print_program_space): Update.
7769         * process-stratum-target.c
7770         (process_stratum_target::thread_address_space): Update.
7771         * linux-fork.c (linux_fork_mourn_inferior)
7772         (detach_checkpoint_command, info_checkpoints_command)
7773         (linux_fork_context): Update.
7774         (linux_fork_detach): Update.
7775         (class scoped_switch_fork_info): Update.
7776         (delete_checkpoint_command): Update.
7777         * infrun.c (follow_fork_inferior): Update.
7778         (follow_fork_inferior): Update.
7779         (proceed_after_vfork_done): Update.
7780         (handle_vfork_child_exec_or_exit): Update.
7781         (follow_exec): Update.
7782         (displaced_step_prepare_throw): Update.
7783         (displaced_step_restore): Update.
7784         (start_step_over): Update.
7785         (resume_1): Update.
7786         (clear_proceed_status_thread): Update.
7787         (proceed): Update.
7788         (print_target_wait_results): Update.
7789         (do_target_wait): Update.
7790         (context_switch): Update.
7791         (stop_all_threads): Update.
7792         (restart_threads): Update.
7793         (finish_step_over): Update.
7794         (handle_signal_stop): Update.
7795         (switch_back_to_stepped_thread): Update.
7796         (keep_going_pass_signal): Update.
7797         (print_exited_reason): Update.
7798         (normal_stop): Update.
7799         * inferior.c (inferior_pid_to_str): Change return type.
7800         (print_selected_inferior): Update.
7801         (add_inferior): Update.
7802         (detach_inferior): Update.
7803         * dummy-frame.c (fprint_dummy_frames): Update.
7804         * dcache.c (dcache_info_1): Update.
7805         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7806         (btrace_fetch, btrace_clear): Update.
7807         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7808         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7809         type.
7810         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7811         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7812         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7813         * gdbarch.c, gdbarch.h: Rebuild.
7814         * gdbarch.sh (core_pid_to_str): Change return type.
7815         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7816         return type.
7817         (windows_nat_target::pid_to_str): Change return type.
7818         (windows_delete_thread): Update.
7819         (windows_nat_target::attach): Update.
7820         (windows_nat_target::files_info): Update.
7821         * target-delegates.c: Rebuild.
7822         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7823         return type.
7824         (sol_thread_target::pid_to_str): Change return type.
7825         * remote.c (class remote_target) <pid_to_str>: Change return
7826         type.
7827         (remote_target::pid_to_str): Change return type.
7828         (extended_remote_target::attach, remote_target::remote_stop_ns)
7829         (remote_target::remote_notif_remove_queued_reply)
7830         (remote_target::push_stop_reply, remote_target::disable_btrace):
7831         Update.
7832         (extended_remote_target::attach): Update.
7833         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7834         type.
7835         (gdbsim_target::pid_to_str): Change return type.
7836         * ravenscar-thread.c (struct ravenscar_thread_target)
7837         <pid_to_str>: Change return type.
7838         (ravenscar_thread_target::pid_to_str): Change return type.
7839         * procfs.c (class procfs_target) <pid_to_str>: Change return
7840         type.
7841         (procfs_target::pid_to_str): Change return type.
7842         (procfs_target::attach): Update.
7843         (procfs_target::detach): Update.
7844         (procfs_target::fetch_registers): Update.
7845         (procfs_target::store_registers): Update.
7846         (procfs_target::wait): Update.
7847         (procfs_target::files_info): Update.
7848         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7849         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7850         return type.
7851         (nto_procfs_target::pid_to_str): Change return type.
7852         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7853         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7854         return type.
7855         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7856         (exit_lwp): Update.
7857         (attach_proc_task_lwp_callback, get_detach_signal)
7858         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7859         (linux_nat_target::resume, wait_lwp, stop_callback)
7860         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7861         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7862         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7863         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7864         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7865         type.
7866         (inf_ptrace_target::attach): Update.
7867         (inf_ptrace_target::files_info): Update.
7868         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7869         type.
7870         (go32_nat_target::pid_to_str): Change return type.
7871         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7872         (gnu_nat_target::wait): Update.
7873         (gnu_nat_target::wait): Update.
7874         (gnu_nat_target::resume): Update.
7875         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7876         (fbsd_nat_target::wait): Update.
7877         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7878         type.
7879         (darwin_nat_target::attach): Update.
7880         * corelow.c (class core_target) <pid_to_str>: Change return type.
7881         (core_target::pid_to_str): Change return type.
7882         * target.c (normal_pid_to_str): Change return type.
7883         (default_pid_to_str): Likewise.
7884         (target_pid_to_str): Change return type.
7885         (target_translate_tls_address): Update.
7886         (target_announce_detach): Update.
7887         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7888         return type.
7889         (bsd_uthread_target::pid_to_str): Change return type.
7890         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7891         type.
7892         (bsd_kvm_target::pid_to_str): Change return type.
7893         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7894         return type.
7895         (aix_thread_target::pid_to_str): Change return type.
7896         * target.h (struct target_ops) <pid_to_str>: Change return type.
7897         (target_pid_to_str, normal_pid_to_str): Likewise.
7898         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7899         type.
7900         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7901         type.
7902         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7903         return type.
7904         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7905         type.
7906         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7907         type.
7908         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7909         return type.
7910
7911 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7912
7913         * NEWS: Mention that the new default MI version is 3.  Mention
7914         changes to the output of commands and events that deal with
7915         multi-location breakpoints.
7916         * breakpoint.c: Include "mi/mi-out.h".
7917         (print_one_breakpoint): Change output syntax if using MI version
7918         >= 3.
7919         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7920         New.
7921         (mi_multi_location_breakpoint_output_fixed): New.
7922         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7923         (mi_cmd_fix_multi_location_breakpoint_output): New.
7924         (mi_multi_location_breakpoint_output_fixed): New.
7925         * mi/mi-cmds.c (mi_cmds): Register command
7926         -fix-multi-location-breakpoint-output.
7927         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7928         interpreter "mi".
7929
7930 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7931
7932         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7933         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7934         instantiate mi_ui_out based on interpreter name.
7935         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7936         * mi/mi-main.c (mi_load_progress): Likewise.
7937
7938 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7939
7940         * NEWS: Combine separate "New targets" sections for 8.3.
7941
7942 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7943
7944         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7945         (ppcfbsd_init_abi): Install gdbarch
7946         "fetch_tls_load_module_address" and "get_thread_local_address"
7947         methods.
7948
7949 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7950
7951         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7952         (riscv_fbsd_init_abi): Install gdbarch
7953         "fetch_tls_load_module_address" and "get_thread_local_address"
7954         methods.
7955
7956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7957
7958         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7959         (i386fbsd_init_abi): Install gdbarch
7960         "fetch_tls_load_module_address" and "get_thread_local_address"
7961         methods.
7962
7963 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7964
7965         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7966         (amd64fbsd_init_abi): Install gdbarch
7967         "fetch_tls_load_module_address" and "get_thread_local_address"
7968         methods.
7969
7970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7971
7972         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7973         (struct fbsd_pspace_data): New type.
7974         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7975         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7976         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7977         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7978         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7979
7980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7981
7982         * gdbtypes.c (lookup_struct_elt): New function.
7983         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7984         * gdbtypes.h (struct struct_elt): New type.
7985         (lookup_struct_elt): New prototype.
7986
7987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7988
7989         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7990         remove disabled code block.
7991
7992 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7993
7994         * gdbarch.sh (get_thread_local_address): New method.
7995         * gdbarch.h, gdbarch.c: Regenerate.
7996         * target.c (target_translate_tls_address): Use
7997         gdbarch_get_thread_local_address if present instead of
7998         target::get_thread_local_address.
7999
8000 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8001
8002         * target.h (target::get_thread_local_address): Update comment.
8003
8004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8005
8006         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8007         objfile->separate_debug_objfile_backlink if not NULL.
8008
8009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8010
8011         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8012         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8013         (amd64bsd_store_inferior_registers): Likewise.
8014         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8015         Enable segment base registers.
8016         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8017         PT_GETFSBASE and PT_GETGSBASE.
8018         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8019         PT_SETGSBASE.
8020         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8021         segment base registers.
8022         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8023
8024 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8025
8026         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8027         Update calls to i386_target_description to add 'segments'
8028         parameter.
8029         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8030         add segment base registers.
8031         * arch/i386.c (i386_create_target_description): Add 'segments'
8032         parameter to enable segment base registers.
8033         * arch/i386.h (i386_create_target_description): Likewise.
8034         * features/i386/32bit-segments.xml: New file.
8035         * features/i386/32bit-segments.c: Generate.
8036         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8037         call to i386_target_description to add 'segments' parameter.
8038         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8039         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8040         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8041         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8042         if feature is present.
8043         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8044         Add 'segments' parameter to call to i386_target_description.
8045         (i386_target_description): Add 'segments' parameter to enable
8046         segment base registers.
8047         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8048         to call to i386_target_description.
8049         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8050         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8051         Define I386_NUM_REGS.
8052         (i386_target_description): Add 'segments' parameter to enable
8053         segment base registers.
8054
8055 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8056
8057         PR/24325
8058         * source-cache.c: #undef open and close, to avoid unresolved
8059         externals during linking.
8060
8061 2019-03-12  Tom Tromey  <tromey@adacore.com>
8062
8063         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8064         const.  Add initializers.
8065         (_initialize_remote): Don't initialize ptid globals.
8066
8067 2019-03-12  Pedro Alves  <palves@redhat.com>
8068
8069         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8070
8071 2019-03-12  Pedro Alves  <palves@redhat.com>
8072
8073         * cp-name-parser.y (main): Remove unused 'len' variable.
8074
8075 2019-03-12  Tom Tromey  <tromey@adacore.com>
8076
8077         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8078         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8079
8080 2019-03-12  Tom Tromey  <tromey@adacore.com>
8081
8082         * linux-nat.c (iterate_over_lwps): Update.
8083         (stop_callback): Remove parameter.
8084         (stop_wait_callback, detach_callback, resume_set_callback)
8085         (select_singlestep_lwp_callback, set_ignore_sigint)
8086         (status_callback, resumed_callback, resume_clear_callback)
8087         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8088         data parameter.
8089         (linux_nat_target::detach, linux_nat_target::resume)
8090         (linux_stop_and_wait_all_lwps, select_event_lwp)
8091         (linux_nat_filter_event, linux_nat_wait_1)
8092         (linux_nat_target::kill, linux_nat_target::stop)
8093         (linux_nat_target::stop): Update.
8094         (linux_nat_resume_callback): Change type.
8095         (resume_stopped_resumed_lwps, count_events_callback)
8096         (select_event_lwp_callback): Likewise.
8097         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8098         * arm-linux-nat.c (struct update_registers_data): Remove.
8099         (update_registers_callback): Change type.
8100         (arm_linux_insert_hw_breakpoint1): Update.
8101         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8102         parameter.
8103         (x86_linux_dr_set_addr): Update.
8104         (x86_linux_dr_set_control): Update.
8105         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8106         (iterate_over_lwps): Use gdb::function_view.
8107         * nat/aarch64-linux-hw-point.c (struct
8108         aarch64_dr_update_callback_param): Remove.
8109         (debug_reg_change_callback): Change type.
8110         (aarch64_notify_debug_reg_change): Update.
8111         * s390-linux-nat.c (s390_refresh_per_info): Update.
8112
8113 2019-03-11  Tom Tromey  <tromey@adacore.com>
8114
8115         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8116         redundant assignment to "this_cu".
8117
8118 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8119
8120         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8121
8122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8123
8124         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8125         from...
8126         (rank_one_type): ... this.
8127
8128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8129
8130         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8131         from...
8132         (rank_one_type): ... this.
8133
8134 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8135
8136         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8137         from...
8138         (rank_one_type): ... this.
8139
8140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8141
8142         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8143         from...
8144         (rank_one_type): ... this.
8145
8146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8147
8148         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8149         from...
8150         (rank_one_type): ... this.
8151
8152 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8153
8154         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8155         from...
8156         (rank_one_type): ... this.
8157
8158 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8159
8160         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8161         from...
8162         (rank_one_type): ... this.
8163
8164 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8165
8166         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8167         from...
8168         (rank_one_type): ... this.
8169
8170 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8171
8172         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8173         from...
8174         (rank_one_type): ... this.
8175
8176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8177
8178         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8179         from...
8180         (rank_one_type): ... this.
8181
8182 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8183
8184         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8185         from...
8186         (rank_one_type): ... this.
8187
8188 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8189
8190         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8191         from...
8192         (rank_one_type): ... this.
8193
8194 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8195
8196         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8197         inferior-events' shows the example events.
8198
8199 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8200
8201         Support styling on native MS-Windows console
8202
8203         PR/24315
8204         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8205         on MS-Windows if $TERM is not defined.
8206
8207         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8208
8209         * posix-hdep.c (gdb_console_fputs):
8210         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8211         functions.
8212         * ui-file.h (gdb_console_fputs): Add prototype.
8213
8214         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8215         back to fputs only if the former returns zero.
8216
8217 2019-03-07  Tom Tromey  <tom@tromey.com>
8218
8219         * symmisc.c (print_symbol_bcache_statistics): Update.
8220         (print_objfile_statistics): Update.
8221         * symfile.c (allocate_symtab): Update.
8222         * stabsread.c: Don't include bcache.h.
8223         * psymtab.h (struct psymbol_bcache): Don't declare.
8224         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8225         (psymbol_bcache_init, psymbol_bcache_free)
8226         (psymbol_bcache_get_bcache): Don't declare.
8227         * psymtab.c (struct psymbol_bcache): Remove.
8228         (psymtab_storage::psymtab_storage): Update.
8229         (psymtab_storage::~psymtab_storage): Update.
8230         (psymbol_bcache_init, psymbol_bcache_free)
8231         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8232         (add_psymbol_to_bcache): Update.
8233         (allocate_psymtab): Update.
8234         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8235         macro_cache>: No longer pointers.
8236         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8237         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8238         * macrotab.c (macro_bcache): Update.
8239         * macroexp.c: Don't include bcache.h.
8240         * gdbtypes.c (check_types_worklist): Update.
8241         (types_deeply_equal): Remove TRY/CATCH.  Update.
8242         * elfread.c (elf_symtab_read): Update.
8243         * dwarf2read.c: Don't include bcache.h.
8244         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8245         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8246         (print_bcache_statistics, bcache_memory_used): Don't declare.
8247         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8248         methods.  Rename all data members.
8249         * bcache.c (struct bcache): Move to bcache.h.
8250         (bcache::expand_hash_table): Rename from expand_hash_table.
8251         (bcache): Remove.
8252         (bcache::insert): Rename from bcache_full.
8253         (bcache::compare): Rename from bcache_compare.
8254         (bcache_xmalloc): Remove.
8255         (bcache::~bcache): Rename from bcache_xfree.
8256         (bcache::print_statistics): Rename from print_bcache_statistics.
8257         (bcache::memory_used): Rename from bcache_memory_used.
8258
8259 2019-03-07  Pedro Alves  <palves@redhat.com>
8260
8261         * infrun.c (normal_stop): Also check for
8262         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8263
8264 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8265
8266         * f-lang.c (value_from_host_double): Moved to...
8267         * value.c (value_from_host_double): ...here.
8268         * value.h (value_from_host_double): Declare.
8269         * guile/scm-math.c (vlscm_convert_typed_number): Use
8270         value_from_host_double.
8271         (vlscm_convert_number): Likewise.
8272         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8273         * python/py-value.c (convert_value_from_python): Likewise.
8274
8275 2019-03-06  Tom Tromey  <tom@tromey.com>
8276
8277         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8278
8279 2019-03-06  Tom Tromey  <tom@tromey.com>
8280
8281         * utils.h (free_current_contents): Don't declare.
8282         * utils.c (free_current_contents): Remove.
8283
8284 2019-03-06  Tom Tromey  <tom@tromey.com>
8285
8286         * top.c (quit_force): Update.
8287         * main.c (captured_command_loop): Update.
8288         * common/new-op.c (operator new): Update.
8289         * common/common-exceptions.c (struct catcher)
8290         <save_cleanup_chain>: Remove member.
8291         (exceptions_state_mc_init): Update.
8292         (exception_try_scope_entry): Return nullptr.
8293         (exception_try_scope_exit, exception_rethrow)
8294         (throw_exception_sjlj, throw_exception_cxx): Update.
8295         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8296         (all_cleanups, do_cleanups, discard_cleanups)
8297         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8298         (restore_cleanups, restore_final_cleanups): Don't declare.
8299         (do_final_cleanups): Remove parameter.
8300         * common/cleanups.c (cleanup_chain, make_cleanup)
8301         (make_cleanup_dtor, all_cleanups, do_cleanups)
8302         (discard_my_cleanups, discard_cleanups)
8303         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8304         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8305         (null_cleanup): Remove.
8306         (do_final_cleanups): Remove parameter.
8307
8308 2019-03-06  Tom Tromey  <tom@tromey.com>
8309
8310         * remote.c (remote_target::remote_parse_stop_reply): Use
8311         unique_xmalloc_ptr.
8312
8313 2019-03-06  Tom Tromey  <tom@tromey.com>
8314
8315         * stabsread.c (struct stabs_field_info): Rename from field_info.
8316         <list, fnlist>: Add initializers.
8317         <obstack>: New member.
8318         (read_member_functions, read_struct_fields, read_baseclasses):
8319         Allocate on obstack.  Don't use cleanups.
8320         (read_one_struct_field, read_member_functions, read_struct_fields)
8321         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8322         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8323         (read_struct_type): Update.
8324
8325 2019-03-06  Tom Tromey  <tom@tromey.com>
8326
8327         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8328         * common/filestuff.h (make_cleanup_close): Don't declare.
8329         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8330         Remove.
8331
8332 2019-03-06  Tom Tromey  <tom@tromey.com>
8333
8334         * solib-aix.c: Use make_scope_exit.
8335
8336 2019-03-06  Tom Tromey  <tom@tromey.com>
8337
8338         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8339         Use make_scope_exit.
8340
8341 2019-03-06  Tom Tromey  <tom@tromey.com>
8342
8343         * solib-svr4.c (disable_probes_interface): Remove parameter.
8344         (svr4_handle_solib_event): Use make_scope_exit.
8345
8346 2019-03-06  Tom Tromey  <tom@tromey.com>
8347
8348         * remote.c (struct stop_reply_deleter): Remove.
8349         (stop_reply_up): Update.
8350         (struct stop_reply): Derive from notif_event.  Don't typedef.
8351         <regcache>: Now a std::vector.
8352         (stop_reply_xfree): Remove.
8353         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8354         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8355         (remote_target::discard_pending_stop_replies): Use delete.
8356         (remote_target::remote_parse_stop_reply): Update.
8357         (remote_target::process_stop_reply): Update.
8358         * remote-notif.h (struct notif_event): Add virtual destructor.
8359         Remove "dtr" member.
8360         (struct notif_client) <alloc_event>: Return a unique_ptr.
8361         (notif_event_xfree): Don't declare.
8362         (notif_event_up): New typedef.
8363         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8364         (notif_event_xfree, do_notif_event_xfree): Remove.
8365         (remote_notif_state_xfree): Update.
8366
8367 2019-03-06  Tom Tromey  <tom@tromey.com>
8368
8369         * infrun.c (displaced_step_clear_cleanup): Now a
8370         forward_scope_exit type.
8371         (displaced_step_prepare_throw): Update.
8372         (displaced_step_fixup): Update.
8373
8374 2019-03-06  Tom Tromey  <tom@tromey.com>
8375
8376         * inferior.h (class inferior): Update comment.
8377         * gdbthread.h (class thread_info): Update comment.
8378
8379 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8380             Tom Tromey  <tom@tromey.com>
8381
8382         * stabsread.h (struct stab_section_list): Remove.
8383         (coffstab_build_psymtabs): Update.
8384         * dbxread.c (symbuf_sections): Now a std::vector.
8385         (sect_idx): New global.
8386         (fill_symbuf): Update.
8387         (coffstab_build_psymtabs): Change type of stabsects parameter.
8388         Update.
8389         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8390         std::vector.
8391         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8392         (coff_locate_sections): Update.
8393         (coff_symfile_read): Remove cleanups.  Update.
8394         (init_stringtab): Add storage parameter.
8395         (free_stringtab, free_stringtab_cleanup): Remove.
8396         (init_lineno): Add storage parameter.
8397         (free_linetab, free_linetab_cleanup): Remove.
8398
8399 2019-03-06  Pedro Alves  <palves@redhat.com>
8400
8401         * linux-fork.c (fork_info::clobber_regs): Delete.
8402         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8403         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8404         comment.  Adjust.
8405         (scoped_switch_fork_info::scoped_switch_fork_info)
8406         (checkpoint_command, linux_fork_context): Adjust
8407         fork_save_infrun_state calls.
8408
8409 2019-03-06  Pedro Alves  <palves@redhat.com>
8410
8411         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8412         (inf_has_multiple_threads): Return 'bool' and rewrite using
8413         inferior_info::threads().
8414
8415 2019-03-06  Pedro Alves  <palves@redhat.com>
8416
8417         * linux-fork.c: Include <list>.
8418         (fork_list): Now a std::list instance.
8419         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8420         (forks_exist_p, find_last_fork): Adjust.
8421         (new_fork): Delete.
8422         (one_fork_p): New.
8423         (add_fork): Adjust.
8424         (free_fork): Delete, folded into fork_info::~fork_info().
8425         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8426         Adjust.
8427         (init_fork_list): Delete.
8428         (linux_fork_killall, linux_fork_mourn_inferior)
8429         (linux_fork_detach, info_checkpoints_command): Adjust.
8430         (_initialize_linux_fork): No longer call init_fork_list.
8431
8432 2019-03-06  Pedro Alves  <palves@redhat.com>
8433
8434         * linux-fork.c (new_fork): New, split out of ...
8435         (add_fork): ... this.  Return void.  Move "first fork" special
8436         case from here, to ...
8437         (checkpoint_command): ... here.
8438         * linux-linux.h (add_fork): Return void.
8439
8440 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8441
8442         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8443
8444 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8445             Chris January  <chris.january@arm.com>
8446             David Lecomber  <david.lecomber@arm.com>
8447
8448         * f-exp.y: New token, UNOP_INTRINSIC.
8449         (exp): New pattern using UNOP_INTRINSIC token.
8450         (f77_keywords): Add 'abs' keyword.
8451         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8452         (value_from_host_double): New function.
8453         (evaluate_subexp_f): Support UNOP_ABS.
8454
8455 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8456
8457         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8458         types.
8459
8460 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8461
8462         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8463         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8464         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8465
8466 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8467
8468         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8469
8470 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8471             Chris January  <chris.january@arm.com>
8472
8473         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8474         * f-exp.y: Define 'KIND' token.
8475         (exp): New pattern for KIND expressions.
8476         (ptype): Handle types with a kind extension.
8477         (direct_abs_decl): Extend to spot kind extensions.
8478         (f77_keywords): Add 'kind' to the list.
8479         (push_kind_type): New function.
8480         (convert_to_kind_type): New function.
8481         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8482         * parse.c (operator_length_standard): Likewise.
8483         * parser-defs.h (enum type_pieces): Add tp_kind.
8484         * std-operator.def: Add UNOP_KIND.
8485
8486 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8487
8488         * f-exp.y (f_parse): Set yydebug.
8489
8490 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8491
8492         * f-lang.c (evaluate_subexp_f): New function.
8493         (exp_descriptor_f): New global.
8494         (f_language_defn): Use exp_descriptor_f instead of
8495         exp_descriptor_standard.
8496
8497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8498
8499         * f-exp.y (struct token): Add comments.
8500         (dot_ops): Remove uppercase versions and the end marker.
8501         (f77_keywords): Likewise.
8502         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8503         entries in the dot_ops array are case insensitive, and use
8504         strncasecmp to compare strings.  Also some whitespace cleanup in
8505         this area.  Similar for the f77_keywords array, except entries in
8506         this list might be case sensitive.
8507
8508 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8509
8510         * f-exp.y (struct f77_boolean_val): Add comments.
8511         (boolean_values): Remove uppercase versions, and end marker.
8512         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8513         and use strncasecmp to achieve case insensitivity.  Additionally,
8514         perform whitespace cleanup around this code.
8515
8516 2019-03-06  Tom Tromey  <tromey@adacore.com>
8517
8518         * remote-sim.c (gdbsim_target_open): Use result of
8519         gdb_argv::release.
8520
8521 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8522         Dirk Schubert  <dirk.schubert@arm.com>
8523         Chris January  <chris.january@arm.com>
8524
8525         * eval.c (evaluate_subexp_standard): Call Fortran argument
8526         wrapping logic.
8527         * f-lang.c (struct value): A value which can be passed into a
8528         Fortran function call.
8529         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8530         where appropriate.
8531         (struct type): Value ready for a Fortran function call.
8532         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8533         is needed.
8534         * f-lang.h (fortran_argument_convert): Declaration.
8535         (fortran_preserve_arg_pointer): Declaration.
8536         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8537
8538 2019-03-05  Tom Tromey  <tromey@adacore.com>
8539
8540         * python/py-prettyprint.c (print_string_repr): Remove #if.
8541         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8542
8543 2019-03-05  Tom Tromey  <tromey@adacore.com>
8544
8545         * target.c (the_dummy_target): Move later.  Change type to
8546         "dummy_target".
8547         (initialize_targets): Don't initialize the_dummy_target.
8548
8549 2019-03-05  Tom Tromey  <tromey@adacore.com>
8550
8551         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8552         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8553
8554 2019-03-05  Tom Tromey  <tromey@adacore.com>
8555
8556         * windows-nat.c (windows_nat_target::attach)
8557         (windows_nat_target::detach): Don't call gdb_flush.
8558         * valprint.c (generic_val_print, val_print, val_print_string):
8559         Don't call gdb_flush.
8560         * utils.c (defaulted_query): Don't call gdb_flush.
8561         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8562         * target.c (target_announce_detach): Don't call gdb_flush.
8563         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8564         * remote.c (extended_remote_target::attach): Don't call
8565         gdb_flush.
8566         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8567         * printcmd.c (do_examine): Don't call gdb_flush.
8568         (info_display_command): Don't call gdb_flush.
8569         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8570         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8571         * memattr.c (info_mem_command): Don't call gdb_flush.
8572         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8573         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8574         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8575         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8576         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8577         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8578         (gnu_nat_target::detach): Don't call gdb_flush.
8579         * f-valprint.c (f_val_print): Don't call gdb_flush.
8580         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8581         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8582         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8583         gdb_flush.
8584         * c-valprint.c (c_val_print): Don't call gdb_flush.
8585         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8586
8587 2019-03-05  Tom Tromey  <tromey@adacore.com>
8588
8589         * varobj.c (update_dynamic_varobj_children): Update.
8590         (install_default_visualizer): Use reset, not release.
8591         * value.c (set_internalvar): Update.
8592         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8593         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8594         ATTRIBUTE_UNUSED_RESULT.
8595
8596 2019-03-05  Tom Tromey  <tromey@adacore.com>
8597
8598         * remote.c (class scoped_remote_fd) <release>: Add
8599         ATTRIBUTE_UNUSED_RESULT.
8600
8601 2019-03-05  Tom Tromey  <tromey@adacore.com>
8602
8603         * macroexp.c (struct macro_buffer) <release>: Add
8604         ATTRIBUTE_UNUSED_RESULT.
8605
8606 2019-03-05  Tom Tromey  <tromey@adacore.com>
8607
8608         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8609         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8610         ATTRIBUTE_UNUSED_RESULT.
8611
8612 2019-03-05  Tom Tromey  <tromey@adacore.com>
8613
8614         * common/scoped_fd.h (class scoped_fd) <release>: Add
8615         ATTRIBUTE_UNUSED_RESULT.
8616
8617 2019-03-05  Tom Tromey  <tromey@adacore.com>
8618
8619         * parser-defs.h (struct parser_state) <release>: Add
8620         ATTRIBUTE_UNUSED_RESULT.
8621
8622 2019-03-05  Tom Tromey  <tromey@adacore.com>
8623
8624         * utils.h (class gdb_argv) <release>: Add
8625         ATTRIBUTE_UNUSED_RESULT.
8626         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8627
8628 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8629
8630         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8631         for-loop range, to avoid compiler warnings.
8632
8633         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8634         avoid compiler warnings about unused variables.
8635
8636         * NEWS: Mention end of support for native debugging on MS-Windows
8637         before XP.
8638
8639         PR gdb/24292
8640         * common/netstuff.c:
8641         * gdbserver/gdbreplay.c
8642         * gdbserver/remote-utils.c:
8643         * ser-tcp.c:
8644         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8645         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8646         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8647         'getaddrinfo' and 'freeaddrinfo' were not available before
8648         Windows XP, and mingw.org's MinGW headers by default define
8649         _WIN32_WINNT to 0x500.
8650
8651 2019-03-01  Gary Benson <gbenson@redhat.com>
8652
8653         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8654
8655 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8656             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8657
8658         PR gdb/8527
8659         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8660         set_sigint_trap, clear_sigint_trap.
8661
8662 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8663
8664         * target.c (target_detach): Clear the regcache and the
8665         frame cache.
8666
8667 2019-02-27  Pedro Alves  <palves@redhat.com>
8668
8669         * utils.c (set_screen_size): When we cap the height/width sizes,
8670         tweak the corresponding command variable to show "unlimited":
8671
8672 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8673             Pedro Alves  <palves@redhat.com>
8674
8675         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8676         before calling rl_set_screen_size.
8677
8678 2019-02-27  Tom Tromey  <tromey@adacore.com>
8679
8680         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8681         define.
8682         * python/py-value.c: Remove Python 2.4 workaround.
8683         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8684         workaround.
8685         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8686         Python 2.4 workaround.
8687         * python/python-internal.h: Remove Python 2.4 comment.
8688         (Py_ssize_t): Don't define.
8689         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8690         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8691         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8692         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8693         * python/python.c (do_start_initialization): Remove Python 2.4
8694         workaround.
8695         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8696         (print_children): Remove Python 2.4 workaround.
8697         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8698         workaround.
8699         (CHARBUFFERPROC_NAME): Remove.
8700         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8701         Python 2.4 workaround.
8702
8703 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8704
8705         * NEWS: Note minimum Python version.
8706
8707 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8708
8709         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8710         code from these functions.  Remove corresponding ifdefs.  Use
8711         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8712         Remove gotos and target of gotos.
8713         (infpy_search_memory): Likewise.
8714
8715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8716
8717         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8718         (hppa_gdbarch_init): Don't register deleted functions with
8719         gdbarch.
8720
8721 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8722
8723         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8724         (h8300_unwind_sp): Delete.
8725         (h8300_dummy_id): Delete.
8726         (h8300_gdbarch_init): Don't register deleted functions with
8727         gdbarch.
8728
8729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8730
8731         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8732         (ft32_unwind_pc): Delete.
8733         (ft32_unwind_sp): Delete.
8734         (ft32_gdbarch_init): Don't register deleted functions with
8735         gdbarch.
8736
8737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8738
8739         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8740         (frv_unwind_pc): Delete.
8741         (frv_unwind_sp): Delete.
8742         (frv_gdbarch_init): Don't register deleted functions with
8743         gdbarch.
8744
8745 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8746
8747         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8748         (riscv_unwind_pc): Delete.
8749         (riscv_unwind_sp): Delete.
8750         (riscv_gdbarch_init): Don't register deleted functions with
8751         gdbarch.
8752
8753 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8754
8755         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8756         (csky_unwind_pc): Delete.
8757         (csky_unwind_sp): Delete.
8758         (csky_gdbarch_init): Don't register deleted functions with
8759         gdbarch.
8760
8761 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8762
8763         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8764         (cris_unwind_pc): Delete.
8765         (cris_unwind_sp): Delete.
8766         (cris_gdbarch_init): Don't register deleted functions with
8767         gdbarch.
8768
8769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8770
8771         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8772         (bfin_unwind_pc): Delete.
8773         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8774
8775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8776
8777         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8778         (arm_unwind_pc): Delete.
8779         (arm_unwind_sp): Delete.
8780         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8781
8782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8783
8784         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8785         (arc_unwind_pc): Delete.
8786         (arc_unwind_sp): Delete.
8787         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8788
8789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8790
8791         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8792         (alpha_unwind_pc): Delete.
8793         (alpha_gdbarch_init): Don't register deleted functions with
8794         gdbarch.
8795
8796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8797
8798         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8799         (aarch64_unwind_pc): Delete.
8800         (aarch64_unwind_sp): Delete.
8801         (aarch64_gdbarch_init): Don't register deleted functions with
8802         gdbarch.
8803
8804 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8805
8806         * gdbtypes.c (type_align): Don't consider static members when
8807         computing structure alignment.
8808
8809 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8810
8811         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8812         return 0 for other types.
8813         * arch-utils.c (default_type_align): Always return 0.
8814         * gdbarch.h: Regenerate.
8815         * gdbarch.sh (type_align): Extend comment.
8816         * gdbtypes.c (type_align): Add additional comments, always call
8817         gdbarch_type_align before applying the default rules.
8818         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8819         generic code will then apply a suitable default.
8820         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8821         types, return 0 for other types.
8822
8823 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8824
8825         * NEWS: Create a new section for the next release branch.
8826         Rename the section of the current branch, now that it has
8827         been cut.
8828
8829 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8830
8831         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8832         * version.in: Bump version to 8.3.50.DATE-git.
8833
8834 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8835
8836         * aix-thread.c (ptid_cmp): Remove unused variable.
8837         (get_signaled_thread): Likewise.
8838         (store_regs_user_thread): Likewise.
8839         (store_regs_kernel_thread): Likewise.
8840         (fetch_regs_kernel_thread): Remove shadowed variable.
8841
8842 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8843
8844         * features/riscv/32bit-cpu.xml: Add register numbers.
8845         * features/riscv/32bit-fpu.c: Regenerate.
8846         * features/riscv/32bit-fpu.xml: Add register numbers.
8847         * features/riscv/64bit-cpu.xml: Add register numbers.
8848         * features/riscv/64bit-fpu.c: Regenerate.
8849         * features/riscv/64bit-fpu.xml: Add register numbers.
8850
8851 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8852
8853         * NEWS: Mention two argument form of gdb.Value constructor.
8854         * python/py-value.c (convert_buffer_and_type_to_value): New
8855         function.
8856         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8857         Add support for handling an optional second argument.  Call
8858         convert_buffer_and_type_to_value as appropriate.
8859         * python/python-internal.h (Py_buffer_deleter): New struct.
8860         (Py_buffer_up): New typedef.
8861
8862 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8863
8864         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8865         instead of releasing ownership.
8866
8867 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8868
8869         * dwarf2read.c (open_and_init_dwp_file): Call
8870         elf_numsections instead of bfd_count_sections to initialize
8871         dwp_file->num_sections.
8872
8873 2019-02-25  Tom Tromey  <tromey@adacore.com>
8874
8875         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8876
8877 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8878
8879         * gcore.in: Add '--readnever' option when invoking GDB.
8880
8881 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8882
8883         * MAINTAINERS: Update my email address.
8884
8885 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8886
8887         * build-id.c (build_id_to_debug_bfd_1): New function.
8888         (build_id_to_debug_bfd): Look for separate debug file in
8889         sysroot.
8890
8891 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8892
8893         * gdbarch.sh: Update the copyright year range that is placed into
8894         generated files.
8895
8896 2019-02-22  Keith Seitz  <keiths@redhat.com>
8897
8898         PR symtab/23853
8899         * linespec.c (create_sals_line_offset): Search for the default
8900         symtab's filename instead of its fullname.
8901
8902 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8903
8904         * NEWS: Update style defaults.
8905
8906 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8907
8908         * main.c (captured_main_1): Disable styling in batch mode.
8909
8910 2019-02-20  Tom Tromey  <tom@tromey.com>
8911
8912         * symtab.c (symtab_symbol_info): Fix typos.
8913
8914 2019-02-20  Tom Tromey  <tromey@adacore.com>
8915
8916         * findcmd.c (_initialize_mem_search): Use upper case for
8917         metasyntactic variables.
8918
8919 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8920
8921         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8922         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8923
8924 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8925
8926         * top.h (source_file_name): Change to std::string.
8927         * top.c (source_file_name): Likewise.
8928         (command_line_input): Adjust.
8929         * cli/cli-script.c (script_from_file): Adjust.
8930
8931 2019-02-19  Tom Tromey  <tromey@adacore.com>
8932
8933         * ravenscar-thread.c
8934         (ravenscar_thread_target::update_thread_list): Don't call
8935         ada_build_task_list.
8936         * ada-lang.h (ada_build_task_list): Don't declare.
8937         * ada-tasks.c (struct ada_tasks_inferior_data)
8938         <task_list_valid_p>: Now bool.
8939         (read_known_tasks, ada_task_list_changed)
8940         (ada_tasks_invalidate_inferior_data): Update.
8941         (read_known_tasks_array): Return bool.
8942         (read_known_tasks_list): Likewise.
8943         (read_known_tasks): Return void.
8944         (ada_build_task_list): Now static.
8945
8946 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8947
8948         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8949         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8950
8951 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8952
8953         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8954         variant for ada_tasks_pspace_data_handle and
8955         ada_tasks_inferior_data_handle.
8956         (ada_tasks_pspace_data_cleanup): New function.
8957         (ada_tasks_inferior_data_cleanup): New function.
8958
8959 2019-02-17  Tom Tromey  <tom@tromey.com>
8960
8961         * macrotab.h (macro_source_fullname): Return a std::string.
8962         * macrotab.c (macro_include, check_for_redefinition)
8963         (macro_undef, macro_lookup_definition, foreach_macro)
8964         (foreach_macro_in_scope): Update.
8965         (macro_source_fullname): Return a std::string.
8966         * macrocmd.c (show_pp_source_pos): Update.
8967
8968 2019-02-17  Tom Tromey  <tom@tromey.com>
8969
8970         * macrocmd.c (show_pp_source_pos): Style the file names.
8971
8972 2019-02-17  Tom Tromey  <tom@tromey.com>
8973
8974         PR tui/24197:
8975         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8976
8977 2019-02-17  Tom Tromey  <tom@tromey.com>
8978
8979         * ada-lang.c (user_select_syms): Use filtered printing.
8980         * utils.c (wrap_style): New global.
8981         (desired_style): Remove.
8982         (emit_style_escape): Add stream parameter.
8983         (set_output_style, reset_terminal_style, prompt_for_continue):
8984         Update.
8985         (flush_wrap_buffer): Only flush gdb_stdout.
8986         (wrap_here): Set wrap_style.
8987         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8988         treat escape sequences as a character.  Change when wrap buffer is
8989         flushed.
8990         (fputs_styled): Do not set the output style when the default is
8991         requested.
8992         * ui-style.h (struct ui_file_style) <is_default>: New method.
8993         * source.c (print_source_lines_base): Emit escape sequences in one
8994         piece.
8995
8996 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8997
8998         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8999         integers and enumeration types.
9000
9001 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9002
9003         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9004         instead of lookup_symbol_in_language
9005         (do_exact_match): New function.
9006         (ada_get_symbol_name_matcher): Return do_exact_match when
9007         doing a verbatim match.
9008
9009 2019-02-15  Tom Tromey  <tromey@adacore.com>
9010
9011         * ravenscar-thread.c (ravenscar_thread_target::resume)
9012         (ravenscar_thread_target::wait): Special case wildcard requests.
9013
9014 2019-02-15  Tom Tromey  <tromey@adacore.com>
9015
9016         * ravenscar-thread.c (base_ptid): Remove.
9017         (struct ravenscar_thread_target) <close>: New method.
9018         <m_base_ptid>: New member.
9019         <update_inferior_ptid, active_task, task_is_currently_active,
9020         runtime_initialized>: Declare methods.
9021         <ravenscar_thread_target>: Add constructor.
9022         (ravenscar_thread_target::task_is_currently_active)
9023         (ravenscar_thread_target::update_inferior_ptid)
9024         (ravenscar_runtime_initialized): Rename.  Now methods.
9025         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9026         (ravenscar_thread_target::update_thread_list): Update.
9027         (ravenscar_thread_target::active_task): Now method.
9028         (ravenscar_thread_target::store_registers)
9029         (ravenscar_thread_target::prepare_to_store)
9030         (ravenscar_thread_target::prepare_to_store)
9031         (ravenscar_thread_target::mourn_inferior): Update.
9032         (ravenscar_inferior_created): Use "new" to create target.
9033         (ravenscar_thread_target::get_ada_task_ptid): Update.
9034         (_initialize_ravenscar): Don't initialize base_ptid.
9035         (ravenscar_ops): Remove global.
9036
9037 2019-02-15  Tom Tromey  <tromey@adacore.com>
9038
9039         * target.h (push_target): Declare new overload.
9040         * target.c (push_target): New overload, taking an rvalue reference.
9041         * remote.c (remote_target::open_1): Use push_target overload.
9042         * corelow.c (core_target_open): Use push_target overload.
9043
9044 2019-02-15  Tom Tromey  <tromey@adacore.com>
9045
9046         * ravenscar-thread.c (is_ravenscar_task)
9047         (ravenscar_task_is_currently_active): Return bool.
9048         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9049         (_initialize_ravenscar): Remove "(void)".
9050         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9051         Return bool.
9052
9053 2019-02-15  Tom Tromey  <tromey@adacore.com>
9054
9055         * ravenscar-thread.c (ravenscar_runtime_initializer)
9056         (has_ravenscar_runtime, get_running_thread_id)
9057         (ravenscar_thread_target::resume): Fix indentation.
9058
9059 2019-02-15  Tom Tromey  <tromey@adacore.com>
9060
9061         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9062         from ravenscar_arch_ops.
9063         (sparc_ravenscar_ops::fetch_registers)
9064         (sparc_ravenscar_ops::store_registers): Now methods.
9065         (sparc_ravenscar_prepare_to_store): Remove.
9066         (sparc_ravenscar_ops): Redefine.
9067         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9068         methods and destructor.  Remove members.
9069         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9070         (ravenscar_thread_target::store_registers)
9071         (ravenscar_thread_target::prepare_to_store): Update.
9072         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9073         Remove.
9074         (struct ppc_ravenscar_powerpc_ops): Derive from
9075         ravenscar_arch_ops.
9076         (ppc_ravenscar_powerpc_ops::fetch_registers)
9077         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9078         (ppc_ravenscar_powerpc_ops): Redefine.
9079         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9080         (ppc_ravenscar_e500_ops::fetch_registers)
9081         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9082         (ppc_ravenscar_e500_ops): Redefine.
9083         * aarch64-ravenscar-thread.c
9084         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9085         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9086         (aarch64_ravenscar_fetch_registers)
9087         (aarch64_ravenscar_store_registers): Now methods.
9088         (aarch64_ravenscar_ops): Redefine.
9089
9090 2019-02-15  Tom Tromey  <tromey@adacore.com>
9091
9092         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9093         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9094         (ravenscar_thread_target::stopped_by_watchpoint)
9095         (ravenscar_thread_target::stopped_data_address)
9096         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9097
9098 2019-02-15  Tom Tromey  <tromey@adacore.com>
9099
9100         * ravenscar-thread.c: Fix some typos.
9101
9102 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9103             Tom Tromey  <tromey@adacore.com>
9104
9105         * ada-lang.c (ada_exception_sal): Change addr_string to a
9106         std::string.
9107         (create_ada_exception_catchpoint): Update.
9108
9109 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9110             Tom Tromey  <tromey@adacore.com>
9111
9112         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9113         (bp_location_ops): Remove.
9114         (base_breakpoint_allocate_location): Update.
9115         (free_bp_location): Update.
9116         * ada-lang.c (class ada_catchpoint_location)
9117         <ada_catchpoint_location>: Remove ops parameter.
9118         (ada_catchpoint_location_dtor): Remove.
9119         (ada_catchpoint_location_ops): Remove.
9120         (allocate_location_exception): Update.
9121         * breakpoint.h (struct bp_location_ops): Remove.
9122         (class bp_location) <bp_location>: Remove bp_location_ops
9123         parameter.
9124         <~bp_location>: Add destructor.
9125         <ops>: Remove.
9126
9127 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9128             Pedro Alves  <palves@redhat.com>
9129
9130         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9131         'PATH_MAX'.
9132
9133 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9134             Samuel Thibault  <samuel.thibault@gnu.org>
9135             Thomas Schwinge  <thomas@codesourcery.com>
9136
9137         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9138         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9139
9140 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9141
9142         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9143         (check_empty): Use "const char *".
9144
9145         * gnu-nat.c (gnu_nat_target::detach): Instead of
9146         'detach_inferior (pid)' call
9147         'detach_inferior (find_inferior_pid (pid))'.
9148
9149         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9150         'nat/fork-inferior.o'.
9151         * gnu-nat.c: #include "nat/fork-inferior.h".
9152
9153         * gnu-nat.c (gnu_nat_target::detach): Instead of
9154         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9155         * gnu-nat.h: #include "inf-child.h".
9156         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9157         'i386_gnu_nat_target::fetch_registers'.
9158         (gnu_store_registers): Rename/move to
9159         'i386_gnu_nat_target::store_registers'.
9160
9161         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9162         * gnu-nat.h (mach_thread_info): New function.
9163         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9164
9165         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9166
9167 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9168
9169         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9170
9171 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9172
9173         * windows-nat.c (windows_add_thread): Add new parameter
9174         "main_thread_p" with default value set to false.  Update
9175         function documentation as well as all callers.
9176         (windows_delete_thread): Likewise.
9177         (fake_create_process): Update call to windows_add_thread.
9178         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9179         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9180         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9181         call to windows_delete_thread.
9182
9183 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9184
9185         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9186
9187 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9188
9189         * symfile.c (find_separate_debug_file): Use canonical path of
9190         sysroot with child_path instead of gdb_sysroot if it is valid.
9191
9192 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9193
9194         * symfile.c (find_separate_debug_file): Use child_path to
9195         determine if an object file is under a sysroot.
9196
9197 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9198
9199         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9200         unittests/child-path-selftests.c.
9201         * common/pathstuff.c (child_path): New function.
9202         * common/pathstuff.h (child_path): New prototype.
9203         * unittests/child-path-selftests.c: New file.
9204
9205 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9206
9207         * symfile.c (find_separate_debug_file): Look for separate debug
9208         files in debug directories under the sysroot.
9209
9210 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9211
9212         * symtab.h (struct minimal_symbol data_p): New const method.
9213         (struct minimal_symbol text_p): Likewise.
9214         * symtab.c (output_source_filename): Use file name style
9215         to print file name.
9216         (print_symbol_info): Likewise.
9217         (print_msymbol_info): Use address style to print addresses.
9218         Use function name style to print executable text symbols.
9219         (expand_symtab_containing_pc): Use data_p.
9220         (find_pc_sect_compunit_symtab): Likewise.
9221
9222 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9223
9224         * breakpoint.c (describe_other_breakpoints): Use address style
9225         to print addresses.
9226         (say_where): Likewise.
9227
9228 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9229
9230         * ada-typeprint.c (print_func_type): Print function name
9231         style to print function name.
9232         * c-typeprint.c (c_print_type_1): Likewise.
9233
9234 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9235
9236         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9237         for execve.
9238
9239 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9240
9241         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9242         type_stack.
9243
9244 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9245
9246         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9247         TYPE_CODE_REF types.
9248
9249 2019-02-08  Jim Wilson  <jimw@sifive.com>
9250
9251         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9252         (riscv_linux_fregset): New.
9253         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9254
9255 2019-02-07  Tom Tromey  <tom@tromey.com>
9256
9257         * thread.c (thread_cancel_execution_command): Update.
9258         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9259         methods.
9260         (struct thread_fsm_ops): Remove.
9261         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9262         (thread_fsm_should_stop, thread_fsm_return_value)
9263         (thread_fsm_set_finished, thread_fsm_finished_p)
9264         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9265         Don't declare.
9266         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9267         * infrun.c (clear_proceed_status_thread)
9268         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9269         (print_stop_event): Update.
9270         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9271         Add constructor.
9272         (step_command_fsm_ops): Remove.
9273         (new_step_command_fsm): Remove.
9274         (step_1): Update.
9275         (step_command_fsm::should_stop): Rename from
9276         step_command_fsm_should_stop.
9277         (step_command_fsm::clean_up): Rename from
9278         step_command_fsm_clean_up.
9279         (step_command_fsm::do_async_reply_reason): Rename from
9280         step_command_fsm_async_reply_reason.
9281         (struct until_next_fsm): Inherit from thread_fsm.  Add
9282         constructor.
9283         (until_next_fsm_ops): Remove.
9284         (new_until_next_fsm): Remove.
9285         (until_next_fsm::should_stop): Rename from
9286         until_next_fsm_should_stop.
9287         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9288         (until_next_fsm::do_async_reply_reason): Rename from
9289         until_next_fsm_async_reply_reason.
9290         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9291         constructor.  Change type of breakpoint.
9292         (finish_command_fsm_ops): Remove.
9293         (new_finish_command_fsm): Remove.
9294         (finish_command_fsm::should_stop): Rename from
9295         finish_command_fsm_should_stop.
9296         (finish_command_fsm::clean_up): Rename from
9297         finish_command_fsm_clean_up.
9298         (finish_command_fsm::return_value): Rename from
9299         finish_command_fsm_return_value.
9300         (finish_command_fsm::do_async_reply_reason): Rename from
9301         finish_command_fsm_async_reply_reason.
9302         (finish_command): Update.
9303         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9304         Add constructor.
9305         (call_thread_fsm_ops): Remove.
9306         (call_thread_fsm::call_thread_fsm): Rename from
9307         new_call_thread_fsm.
9308         (call_thread_fsm::should_stop): Rename from
9309         call_thread_fsm_should_stop.
9310         (call_thread_fsm::should_notify_stop): Rename from
9311         call_thread_fsm_should_notify_stop.
9312         (run_inferior_call, call_function_by_hand_dummy): Update.
9313         * cli/cli-interp.c (should_print_stop_to_console): Update.
9314         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9315         Add constructor.  Change type of location_breakpoint,
9316         caller_breakpoint.
9317         (until_break_fsm_ops): Remove.
9318         (new_until_break_fsm): Remove.
9319         (until_break_fsm::should_stop): Rename from
9320         until_break_fsm_should_stop.
9321         (until_break_fsm::clean_up): Rename from
9322         until_break_fsm_clean_up.
9323         (until_break_fsm::do_async_reply_reason): Rename from
9324         until_break_fsm_async_reply_reason.
9325         (until_break_command): Update.
9326         * thread-fsm.c: Remove.
9327         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9328
9329 2019-02-07  Tom Tromey  <tom@tromey.com>
9330
9331         * yy-remap.h: Add include guard.
9332         * xtensa-tdep.h: Add include guard.
9333         * xcoffread.h: Rename include guard.
9334         * varobj-iter.h: Add include guard.
9335         * tui/tui.h: Rename include guard.
9336         * tui/tui-winsource.h: Rename include guard.
9337         * tui/tui-wingeneral.h: Rename include guard.
9338         * tui/tui-windata.h: Rename include guard.
9339         * tui/tui-win.h: Rename include guard.
9340         * tui/tui-stack.h: Rename include guard.
9341         * tui/tui-source.h: Rename include guard.
9342         * tui/tui-regs.h: Rename include guard.
9343         * tui/tui-out.h: Rename include guard.
9344         * tui/tui-layout.h: Rename include guard.
9345         * tui/tui-io.h: Rename include guard.
9346         * tui/tui-hooks.h: Rename include guard.
9347         * tui/tui-file.h: Rename include guard.
9348         * tui/tui-disasm.h: Rename include guard.
9349         * tui/tui-data.h: Rename include guard.
9350         * tui/tui-command.h: Rename include guard.
9351         * tic6x-tdep.h: Add include guard.
9352         * target/waitstatus.h: Rename include guard.
9353         * target/wait.h: Rename include guard.
9354         * target/target.h: Rename include guard.
9355         * target/resume.h: Rename include guard.
9356         * target-float.h: Rename include guard.
9357         * stabsread.h: Add include guard.
9358         * rs6000-tdep.h: Add include guard.
9359         * riscv-fbsd-tdep.h: Add include guard.
9360         * regformats/regdef.h: Rename include guard.
9361         * record.h: Rename include guard.
9362         * python/python.h: Rename include guard.
9363         * python/python-internal.h: Rename include guard.
9364         * python/py-stopevent.h: Rename include guard.
9365         * python/py-ref.h: Rename include guard.
9366         * python/py-record.h: Rename include guard.
9367         * python/py-record-full.h: Rename include guard.
9368         * python/py-record-btrace.h: Rename include guard.
9369         * python/py-instruction.h: Rename include guard.
9370         * python/py-events.h: Rename include guard.
9371         * python/py-event.h: Rename include guard.
9372         * procfs.h: Add include guard.
9373         * proc-utils.h: Add include guard.
9374         * p-lang.h: Add include guard.
9375         * or1k-tdep.h: Rename include guard.
9376         * observable.h: Rename include guard.
9377         * nto-tdep.h: Rename include guard.
9378         * nat/x86-linux.h: Rename include guard.
9379         * nat/x86-linux-dregs.h: Rename include guard.
9380         * nat/x86-gcc-cpuid.h: Add include guard.
9381         * nat/x86-dregs.h: Rename include guard.
9382         * nat/x86-cpuid.h: Rename include guard.
9383         * nat/ppc-linux.h: Rename include guard.
9384         * nat/mips-linux-watch.h: Rename include guard.
9385         * nat/linux-waitpid.h: Rename include guard.
9386         * nat/linux-ptrace.h: Rename include guard.
9387         * nat/linux-procfs.h: Rename include guard.
9388         * nat/linux-osdata.h: Rename include guard.
9389         * nat/linux-nat.h: Rename include guard.
9390         * nat/linux-namespaces.h: Rename include guard.
9391         * nat/linux-btrace.h: Rename include guard.
9392         * nat/glibc_thread_db.h: Rename include guard.
9393         * nat/gdb_thread_db.h: Rename include guard.
9394         * nat/gdb_ptrace.h: Rename include guard.
9395         * nat/fork-inferior.h: Rename include guard.
9396         * nat/amd64-linux-siginfo.h: Rename include guard.
9397         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9398         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9399         * nat/aarch64-linux.h: Rename include guard.
9400         * nat/aarch64-linux-hw-point.h: Rename include guard.
9401         * mn10300-tdep.h: Add include guard.
9402         * mips-linux-tdep.h: Add include guard.
9403         * mi/mi-parse.h: Rename include guard.
9404         * mi/mi-out.h: Rename include guard.
9405         * mi/mi-main.h: Rename include guard.
9406         * mi/mi-interp.h: Rename include guard.
9407         * mi/mi-getopt.h: Rename include guard.
9408         * mi/mi-console.h: Rename include guard.
9409         * mi/mi-common.h: Rename include guard.
9410         * mi/mi-cmds.h: Rename include guard.
9411         * mi/mi-cmd-break.h: Rename include guard.
9412         * m2-lang.h: Add include guard.
9413         * location.h: Rename include guard.
9414         * linux-record.h: Rename include guard.
9415         * linux-nat.h: Add include guard.
9416         * linux-fork.h: Add include guard.
9417         * i386-darwin-tdep.h: Rename include guard.
9418         * hppa-linux-offsets.h: Add include guard.
9419         * guile/guile.h: Rename include guard.
9420         * guile/guile-internal.h: Rename include guard.
9421         * gnu-nat.h: Rename include guard.
9422         * gdb-stabs.h: Rename include guard.
9423         * frv-tdep.h: Add include guard.
9424         * f-lang.h: Add include guard.
9425         * event-loop.h: Add include guard.
9426         * darwin-nat.h: Rename include guard.
9427         * cp-abi.h: Rename include guard.
9428         * config/sparc/nm-sol2.h: Rename include guard.
9429         * config/nm-nto.h: Rename include guard.
9430         * config/nm-linux.h: Add include guard.
9431         * config/i386/nm-i386gnu.h: Rename include guard.
9432         * config/djgpp/nl_types.h: Rename include guard.
9433         * config/djgpp/langinfo.h: Rename include guard.
9434         * compile/gcc-cp-plugin.h: Add include guard.
9435         * compile/gcc-c-plugin.h: Add include guard.
9436         * compile/compile.h: Rename include guard.
9437         * compile/compile-object-run.h: Rename include guard.
9438         * compile/compile-object-load.h: Rename include guard.
9439         * compile/compile-internal.h: Rename include guard.
9440         * compile/compile-cplus.h: Rename include guard.
9441         * compile/compile-c.h: Rename include guard.
9442         * common/xml-utils.h: Rename include guard.
9443         * common/x86-xstate.h: Rename include guard.
9444         * common/version.h: Rename include guard.
9445         * common/vec.h: Rename include guard.
9446         * common/tdesc.h: Rename include guard.
9447         * common/selftest.h: Rename include guard.
9448         * common/scoped_restore.h: Rename include guard.
9449         * common/scoped_mmap.h: Rename include guard.
9450         * common/scoped_fd.h: Rename include guard.
9451         * common/safe-iterator.h: Rename include guard.
9452         * common/run-time-clock.h: Rename include guard.
9453         * common/refcounted-object.h: Rename include guard.
9454         * common/queue.h: Rename include guard.
9455         * common/ptid.h: Rename include guard.
9456         * common/print-utils.h: Rename include guard.
9457         * common/preprocessor.h: Rename include guard.
9458         * common/pathstuff.h: Rename include guard.
9459         * common/observable.h: Rename include guard.
9460         * common/netstuff.h: Rename include guard.
9461         * common/job-control.h: Rename include guard.
9462         * common/host-defs.h: Rename include guard.
9463         * common/gdb_wait.h: Rename include guard.
9464         * common/gdb_vecs.h: Rename include guard.
9465         * common/gdb_unlinker.h: Rename include guard.
9466         * common/gdb_unique_ptr.h: Rename include guard.
9467         * common/gdb_tilde_expand.h: Rename include guard.
9468         * common/gdb_sys_time.h: Rename include guard.
9469         * common/gdb_string_view.h: Rename include guard.
9470         * common/gdb_splay_tree.h: Rename include guard.
9471         * common/gdb_setjmp.h: Rename include guard.
9472         * common/gdb_ref_ptr.h: Rename include guard.
9473         * common/gdb_optional.h: Rename include guard.
9474         * common/gdb_locale.h: Rename include guard.
9475         * common/gdb_assert.h: Rename include guard.
9476         * common/filtered-iterator.h: Rename include guard.
9477         * common/filestuff.h: Rename include guard.
9478         * common/fileio.h: Rename include guard.
9479         * common/environ.h: Rename include guard.
9480         * common/common-utils.h: Rename include guard.
9481         * common/common-types.h: Rename include guard.
9482         * common/common-regcache.h: Rename include guard.
9483         * common/common-inferior.h: Rename include guard.
9484         * common/common-gdbthread.h: Rename include guard.
9485         * common/common-exceptions.h: Rename include guard.
9486         * common/common-defs.h: Rename include guard.
9487         * common/common-debug.h: Rename include guard.
9488         * common/cleanups.h: Rename include guard.
9489         * common/buffer.h: Rename include guard.
9490         * common/btrace-common.h: Rename include guard.
9491         * common/break-common.h: Rename include guard.
9492         * cli/cli-utils.h: Rename include guard.
9493         * cli/cli-style.h: Rename include guard.
9494         * cli/cli-setshow.h: Rename include guard.
9495         * cli/cli-script.h: Rename include guard.
9496         * cli/cli-interp.h: Rename include guard.
9497         * cli/cli-decode.h: Rename include guard.
9498         * cli/cli-cmds.h: Rename include guard.
9499         * charset-list.h: Add include guard.
9500         * buildsym-legacy.h: Rename include guard.
9501         * bfin-tdep.h: Add include guard.
9502         * ax.h: Rename include guard.
9503         * arm-linux-tdep.h: Add include guard.
9504         * arm-fbsd-tdep.h: Add include guard.
9505         * arch/xtensa.h: Rename include guard.
9506         * arch/tic6x.h: Add include guard.
9507         * arch/i386.h: Add include guard.
9508         * arch/arm.h: Rename include guard.
9509         * arch/arm-linux.h: Rename include guard.
9510         * arch/arm-get-next-pcs.h: Rename include guard.
9511         * arch/amd64.h: Add include guard.
9512         * arch/aarch64-insn.h: Rename include guard.
9513         * arch-utils.h: Rename include guard.
9514         * annotate.h: Add include guard.
9515         * amd64-darwin-tdep.h: Rename include guard.
9516         * aarch64-linux-tdep.h: Add include guard.
9517         * aarch64-fbsd-tdep.h: Add include guard.
9518         * aarch32-linux-nat.h: Add include guard.
9519
9520 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9521
9522         * macrotab.c (macro_define_internal): New function that
9523         factorizes macro_define_object_internal and macro_define_function
9524         code.
9525         (macro_define_object_internal): Use macro_define_internal.
9526         (macro_define_function): Likewise.
9527
9528 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9529
9530         * macrocmd.c (extract_identifier): Return
9531         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9532         callers.
9533
9534 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9535
9536         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9537
9538 2019-02-05  Tom Tromey  <tom@tromey.com>
9539
9540         * target.c (target_stack::unpush): Move assertion earlier.
9541
9542 2019-01-30  Tom Tromey  <tom@tromey.com>
9543
9544         PR python/23615:
9545         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9546         (gdbpy_parse_and_eval): Likewise.
9547         * python/python-internal.h (gdbpy_allow_threads): New class.
9548
9549 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9550
9551         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9552         (aarch64_fbsd_fpregmap): Move earlier.
9553         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9554         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9555         instead of individual calls to trad_frame_set_reg_addr.
9556         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9557         earlier.
9558         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9559         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9560         instead of individual calls to trad_frame_set_reg_addr.
9561
9562 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9563
9564         * CONTRIBUTE: Replace contribution list with wiki link.
9565
9566 2019-01-25  Tom Tromey  <tom@tromey.com>
9567
9568         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9569
9570 2019-01-25  Tom Tromey  <tom@tromey.com>
9571
9572         * xtensa-linux-nat.c: Fix common/ includes.
9573         * xml-support.h: Fix common/ includes.
9574         * xml-support.c: Fix common/ includes.
9575         * x86-linux-nat.c: Fix common/ includes.
9576         * windows-nat.c: Fix common/ includes.
9577         * varobj.h: Fix common/ includes.
9578         * varobj.c: Fix common/ includes.
9579         * value.c: Fix common/ includes.
9580         * valops.c: Fix common/ includes.
9581         * utils.c: Fix common/ includes.
9582         * unittests/xml-utils-selftests.c: Fix common/ includes.
9583         * unittests/utils-selftests.c: Fix common/ includes.
9584         * unittests/unpack-selftests.c: Fix common/ includes.
9585         * unittests/tracepoint-selftests.c: Fix common/ includes.
9586         * unittests/style-selftests.c: Fix common/ includes.
9587         * unittests/string_view-selftests.c: Fix common/ includes.
9588         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9589         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9590         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9591         * unittests/rsp-low-selftests.c: Fix common/ includes.
9592         * unittests/parse-connection-spec-selftests.c: Fix common/
9593         includes.
9594         * unittests/optional-selftests.c: Fix common/ includes.
9595         * unittests/offset-type-selftests.c: Fix common/ includes.
9596         * unittests/observable-selftests.c: Fix common/ includes.
9597         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9598         * unittests/memrange-selftests.c: Fix common/ includes.
9599         * unittests/memory-map-selftests.c: Fix common/ includes.
9600         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9601         * unittests/function-view-selftests.c: Fix common/ includes.
9602         * unittests/environ-selftests.c: Fix common/ includes.
9603         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9604         * unittests/common-utils-selftests.c: Fix common/ includes.
9605         * unittests/cli-utils-selftests.c: Fix common/ includes.
9606         * unittests/array-view-selftests.c: Fix common/ includes.
9607         * ui-file.c: Fix common/ includes.
9608         * tui/tui-io.c: Fix common/ includes.
9609         * tracepoint.h: Fix common/ includes.
9610         * tracepoint.c: Fix common/ includes.
9611         * tracefile-tfile.c: Fix common/ includes.
9612         * top.h: Fix common/ includes.
9613         * top.c: Fix common/ includes.
9614         * thread.c: Fix common/ includes.
9615         * target/waitstatus.h: Fix common/ includes.
9616         * target/waitstatus.c: Fix common/ includes.
9617         * target.h: Fix common/ includes.
9618         * target.c: Fix common/ includes.
9619         * target-memory.c: Fix common/ includes.
9620         * target-descriptions.c: Fix common/ includes.
9621         * symtab.h: Fix common/ includes.
9622         * symfile.c: Fix common/ includes.
9623         * stap-probe.c: Fix common/ includes.
9624         * spu-linux-nat.c: Fix common/ includes.
9625         * sparc-nat.c: Fix common/ includes.
9626         * source.c: Fix common/ includes.
9627         * solib.c: Fix common/ includes.
9628         * solib-target.c: Fix common/ includes.
9629         * ser-unix.c: Fix common/ includes.
9630         * ser-tcp.c: Fix common/ includes.
9631         * ser-pipe.c: Fix common/ includes.
9632         * ser-base.c: Fix common/ includes.
9633         * selftest-arch.c: Fix common/ includes.
9634         * s12z-tdep.c: Fix common/ includes.
9635         * rust-exp.y: Fix common/ includes.
9636         * rs6000-aix-tdep.c: Fix common/ includes.
9637         * riscv-tdep.c: Fix common/ includes.
9638         * remote.c: Fix common/ includes.
9639         * remote-notif.h: Fix common/ includes.
9640         * remote-fileio.h: Fix common/ includes.
9641         * remote-fileio.c: Fix common/ includes.
9642         * regcache.h: Fix common/ includes.
9643         * regcache.c: Fix common/ includes.
9644         * record-btrace.c: Fix common/ includes.
9645         * python/python.c: Fix common/ includes.
9646         * python/py-type.c: Fix common/ includes.
9647         * python/py-inferior.c: Fix common/ includes.
9648         * progspace.h: Fix common/ includes.
9649         * producer.c: Fix common/ includes.
9650         * procfs.c: Fix common/ includes.
9651         * proc-api.c: Fix common/ includes.
9652         * printcmd.c: Fix common/ includes.
9653         * ppc-linux-nat.c: Fix common/ includes.
9654         * parser-defs.h: Fix common/ includes.
9655         * osdata.c: Fix common/ includes.
9656         * obsd-nat.c: Fix common/ includes.
9657         * nat/x86-linux.c: Fix common/ includes.
9658         * nat/x86-linux-dregs.c: Fix common/ includes.
9659         * nat/x86-dregs.h: Fix common/ includes.
9660         * nat/x86-dregs.c: Fix common/ includes.
9661         * nat/ppc-linux.c: Fix common/ includes.
9662         * nat/mips-linux-watch.h: Fix common/ includes.
9663         * nat/mips-linux-watch.c: Fix common/ includes.
9664         * nat/linux-waitpid.c: Fix common/ includes.
9665         * nat/linux-ptrace.h: Fix common/ includes.
9666         * nat/linux-ptrace.c: Fix common/ includes.
9667         * nat/linux-procfs.c: Fix common/ includes.
9668         * nat/linux-personality.c: Fix common/ includes.
9669         * nat/linux-osdata.c: Fix common/ includes.
9670         * nat/linux-namespaces.c: Fix common/ includes.
9671         * nat/linux-btrace.h: Fix common/ includes.
9672         * nat/linux-btrace.c: Fix common/ includes.
9673         * nat/fork-inferior.c: Fix common/ includes.
9674         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9675         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9676         * nat/aarch64-linux.c: Fix common/ includes.
9677         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9678         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9679         * namespace.h: Fix common/ includes.
9680         * mips-linux-tdep.c: Fix common/ includes.
9681         * minsyms.c: Fix common/ includes.
9682         * mi/mi-parse.h: Fix common/ includes.
9683         * mi/mi-main.c: Fix common/ includes.
9684         * mi/mi-cmd-env.c: Fix common/ includes.
9685         * memrange.h: Fix common/ includes.
9686         * memattr.c: Fix common/ includes.
9687         * maint.h: Fix common/ includes.
9688         * maint.c: Fix common/ includes.
9689         * main.c: Fix common/ includes.
9690         * machoread.c: Fix common/ includes.
9691         * location.c: Fix common/ includes.
9692         * linux-thread-db.c: Fix common/ includes.
9693         * linux-nat.c: Fix common/ includes.
9694         * linux-fork.c: Fix common/ includes.
9695         * inline-frame.c: Fix common/ includes.
9696         * infrun.c: Fix common/ includes.
9697         * inflow.c: Fix common/ includes.
9698         * inferior.h: Fix common/ includes.
9699         * inferior.c: Fix common/ includes.
9700         * infcmd.c: Fix common/ includes.
9701         * inf-ptrace.c: Fix common/ includes.
9702         * inf-child.c: Fix common/ includes.
9703         * ia64-linux-nat.c: Fix common/ includes.
9704         * i387-tdep.c: Fix common/ includes.
9705         * i386-tdep.c: Fix common/ includes.
9706         * i386-linux-tdep.c: Fix common/ includes.
9707         * i386-linux-nat.c: Fix common/ includes.
9708         * i386-go32-tdep.c: Fix common/ includes.
9709         * i386-fbsd-tdep.c: Fix common/ includes.
9710         * i386-fbsd-nat.c: Fix common/ includes.
9711         * guile/scm-type.c: Fix common/ includes.
9712         * guile/guile.c: Fix common/ includes.
9713         * go32-nat.c: Fix common/ includes.
9714         * gnu-nat.c: Fix common/ includes.
9715         * gdbthread.h: Fix common/ includes.
9716         * gdbarch-selftests.c: Fix common/ includes.
9717         * gdb_usleep.c: Fix common/ includes.
9718         * gdb_select.h: Fix common/ includes.
9719         * gdb_bfd.c: Fix common/ includes.
9720         * gcore.c: Fix common/ includes.
9721         * fork-child.c: Fix common/ includes.
9722         * findvar.c: Fix common/ includes.
9723         * fbsd-nat.c: Fix common/ includes.
9724         * event-top.c: Fix common/ includes.
9725         * event-loop.c: Fix common/ includes.
9726         * dwarf2read.c: Fix common/ includes.
9727         * dwarf2loc.c: Fix common/ includes.
9728         * dwarf2-frame.c: Fix common/ includes.
9729         * dwarf-index-cache.c: Fix common/ includes.
9730         * dtrace-probe.c: Fix common/ includes.
9731         * disasm-selftests.c: Fix common/ includes.
9732         * defs.h: Fix common/ includes.
9733         * csky-tdep.c: Fix common/ includes.
9734         * cp-valprint.c: Fix common/ includes.
9735         * cp-support.h: Fix common/ includes.
9736         * cp-support.c: Fix common/ includes.
9737         * corelow.c: Fix common/ includes.
9738         * completer.h: Fix common/ includes.
9739         * completer.c: Fix common/ includes.
9740         * compile/compile.c: Fix common/ includes.
9741         * compile/compile-loc2c.c: Fix common/ includes.
9742         * compile/compile-cplus-types.c: Fix common/ includes.
9743         * compile/compile-cplus-symbols.c: Fix common/ includes.
9744         * command.h: Fix common/ includes.
9745         * cli/cli-dump.c: Fix common/ includes.
9746         * cli/cli-cmds.c: Fix common/ includes.
9747         * charset.c: Fix common/ includes.
9748         * build-id.c: Fix common/ includes.
9749         * btrace.h: Fix common/ includes.
9750         * btrace.c: Fix common/ includes.
9751         * breakpoint.h: Fix common/ includes.
9752         * breakpoint.c: Fix common/ includes.
9753         * ax.h:
9754         (enum agent_op): Fix common/ includes.
9755         * ax-general.c (struct aop_map): Fix common/ includes.
9756         * ax-gdb.c: Fix common/ includes.
9757         * auxv.c: Fix common/ includes.
9758         * auto-load.c: Fix common/ includes.
9759         * arm-tdep.c: Fix common/ includes.
9760         * arch/riscv.c: Fix common/ includes.
9761         * arch/ppc-linux-common.c: Fix common/ includes.
9762         * arch/i386.c: Fix common/ includes.
9763         * arch/arm.c: Fix common/ includes.
9764         * arch/arm-linux.c: Fix common/ includes.
9765         * arch/arm-get-next-pcs.c: Fix common/ includes.
9766         * arch/amd64.c: Fix common/ includes.
9767         * arch/aarch64.c: Fix common/ includes.
9768         * arch/aarch64-insn.c: Fix common/ includes.
9769         * arch-utils.c: Fix common/ includes.
9770         * amd64-windows-tdep.c: Fix common/ includes.
9771         * amd64-tdep.c: Fix common/ includes.
9772         * amd64-sol2-tdep.c: Fix common/ includes.
9773         * amd64-obsd-tdep.c: Fix common/ includes.
9774         * amd64-nbsd-tdep.c: Fix common/ includes.
9775         * amd64-linux-tdep.c: Fix common/ includes.
9776         * amd64-linux-nat.c: Fix common/ includes.
9777         * amd64-fbsd-tdep.c: Fix common/ includes.
9778         * amd64-fbsd-nat.c: Fix common/ includes.
9779         * amd64-dicos-tdep.c: Fix common/ includes.
9780         * amd64-darwin-tdep.c: Fix common/ includes.
9781         * agent.c: Fix common/ includes.
9782         * ada-lang.h: Fix common/ includes.
9783         * ada-lang.c: Fix common/ includes.
9784         * aarch64-tdep.c: Fix common/ includes.
9785
9786 2019-01-25  Tom Tromey  <tom@tromey.com>
9787
9788         * common/create-version.sh: Use common/version.h.
9789
9790 2019-01-24  Pedro Alves  <palves@redhat.com>
9791
9792         * infrun.c (signal_stop, signal_print, signal_program)
9793         (signal_catch, signal_pass): Now arrays instead of pointers.
9794         (update_signals_program_target, do_target_resume)
9795         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9796         * linux-nat.c (linux_nat_target::pass_signals)
9797         (linux_nat_target::create_inferior, linux_nat_target::attach):
9798         Adjust.
9799         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9800         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9801         * procfs.c (procfs_target::pass_signals): Adjust.
9802         * record-full.c (record_full_target::resume): Adjust.
9803         * remote.c (remote_target::pass_signals)
9804         (remote_target::program_signals): Adjust.
9805         * target-debug.h (target_debug_print_signals): Now takes a
9806         gdb::array_view as parameter.  Adjust.
9807         * target.h (target_ops) <pass_signals, program_signals>: Replace
9808         pointer and length parameters with gdb::array_view.
9809         (target_pass_signals, target_program_signals): Likewise.
9810         * target-delegates.c: Regenerate.
9811
9812 2019-01-24  Pedro Alves  <palves@redhat.com>
9813
9814         * common/forward-scope-exit.h
9815         (forward_scope_exit::forward_scope_exit): Pass arguments to
9816         m_bind_function directly, instead of creating a std::bind and
9817         copying that.
9818
9819 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9820
9821         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9822         for static members.
9823         (pass_in_v_vfp_candidate): Likewise.
9824
9825 2019-01-23  Tom Tromey  <tom@tromey.com>
9826             Pedro Alves  <palves@redhat.com>
9827
9828         * regcache.c (class regcache_invalidator): Remove.
9829         (regcache::raw_write): Use make_scope_exit.
9830
9831 2019-01-23  Tom Tromey  <tom@tromey.com>
9832
9833         * ui-out.h (class ui_out_emit_type): Update comment.
9834
9835 2019-01-23  Tom Tromey  <tom@tromey.com>
9836
9837         * infrun.c (fetch_inferior_event): Update comment.
9838
9839 2019-01-23  Tom Tromey  <tom@tromey.com>
9840             Pedro Alves  <palves@redhat.com>
9841
9842         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9843         parameter.
9844         (fetch_inferior_event): Use SCOPE_EXIT.
9845
9846
9847 2019-01-23  Tom Tromey  <tom@tromey.com>
9848             Pedro Alves  <palves@redhat.com>
9849
9850         * infrun.c (disable_thread_events): Delete.
9851         (stop_all_threads): Use SCOPE_EXIT.
9852
9853 2019-01-23  Tom Tromey  <tom@tromey.com>
9854             Pedro Alves  <palves@redhat.com>
9855
9856         * symfile.c: Include forward-scope-exit.h.
9857         (clear_symtab_users_cleanup): Replace forward declaration with
9858         a FORWARD_SCOPE_EXIT.
9859         (syms_from_objfile_1): Use the forward_scope_exit and
9860         gdb::optional instead of cleanup_function.
9861         (reread_symbols): Use the forward_scope_exit instead of
9862         cleanup_function.
9863         (clear_symtab_users_cleanup): Remove function.
9864
9865 2019-01-23  Tom Tromey  <tom@tromey.com>
9866             Pedro Alves  <palves@redhat.com>
9867
9868         * linux-nat.c: Include scope-exit.h.
9869         (cleanup_target_stop): Remove.
9870         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9871         SCOPE_EXIT.
9872
9873 2019-01-23  Tom Tromey  <tom@tromey.com>
9874             Pedro Alves  <palves@redhat.com>
9875
9876         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9877         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9878
9879 2019-01-23  Tom Tromey  <tom@tromey.com>
9880             Andrew Burgess  <andrew.burgess@embecosm.com>
9881             Pedro Alves  <palves@redhat.com>
9882
9883         * infrun.c (fetch_inferior_event): Use scope_exit.
9884         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9885         * top.c (execute_command): Use scope_exit.
9886         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9887         * utils.c (do_bpstat_clear_actions_cleanup)
9888         (make_bpstat_clear_actions_cleanup): Remove.
9889
9890 2019-01-23  Tom Tromey  <tom@tromey.com>
9891             Pedro Alves  <palves@redhat.com>
9892
9893         * infrun.c: Include "common/scope-exit.h"
9894         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9895         (wait_for_inferior): Use SCOPE_EXIT.
9896         (fetch_inferior_event): Use scope_exit.
9897
9898 2019-01-23  Tom Tromey  <tom@tromey.com>
9899             Pedro Alves  <palves@redhat.com>
9900
9901         * breakpoint.c (create_breakpoint): Remove cleanup.
9902
9903 2019-01-23  Tom Tromey  <tom@tromey.com>
9904             Andrew Burgess  <andrew.burgess@embecosm.com>
9905             Pedro Alves  <palves@redhat.com>
9906
9907 2019-01-23  Pedro Alves  <palves@redhat.com>
9908
9909         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9910
9911 2019-01-23  Pedro Alves  <palves@redhat.com>
9912             Andrew Burgess  <andrew.burgess@embecosm.com>
9913
9914         * gdbthread.h: Include "common/forward-scope-exit.h".
9915         (scoped_finish_thread_state): Redefine custom class in terms of
9916         forward_scope_exit.
9917
9918 2019-01-23  Pedro Alves  <palves@redhat.com>
9919             Andrew Burgess  <andrew.burgess@embecosm.com>
9920
9921         * common/forward-scope-exit.h: New file.
9922
9923 2019-01-23  Pedro Alves  <palves@redhat.com>
9924             Andrew Burgess  <andrew.burgess@embecosm.com>
9925             Tom Tromey  <tom@tromey.com>
9926
9927         * common/scope-exit.h: New file.
9928
9929 2019-01-23  Pedro Alves  <palves@redhat.com>
9930
9931         * common/preprocessor.h (ESC): Rename to ...
9932         (ESC_PARENS): ... this.
9933         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9934         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9935
9936 2019-01-23  Tom Tromey  <tom@tromey.com>
9937
9938         * language.h (class scoped_switch_to_sym_language_if_auto):
9939         Initialize m_lang in both cases.
9940
9941 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9942
9943         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9944         with XCNEW.
9945
9946 2019-01-22  Tom Tromey  <tom@tromey.com>
9947
9948         * corelow.c: Do not include sys/file.h.
9949
9950 2019-01-22  Tom Tromey  <tom@tromey.com>
9951
9952         * tui/tui-wingeneral.h: Include gdb_curses.h.
9953
9954 2019-01-22  Tom Tromey  <tom@tromey.com>
9955
9956         * source-cache.h (class source_cache) <get_source_lines,
9957         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9958
9959 2019-01-22  Tom Tromey  <tom@tromey.com>
9960
9961         * remote-fileio.h (struct remote_target): Declare.
9962
9963 2019-01-22  Tom Tromey  <tom@tromey.com>
9964
9965         * python/py-arch.c: Do not include py-ref.h.
9966         * python/py-bpevent.c: Do not include py-ref.h.
9967         * python/py-cmd.c: Do not include py-ref.h.
9968         * python/py-continueevent.c: Do not include py-ref.h.
9969         * python/py-event.h: Do not include py-ref.h.
9970         * python/py-evtregistry.c: Do not include py-ref.h.
9971         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9972         * python/py-frame.c: Do not include py-ref.h.
9973         * python/py-framefilter.c: Do not include py-ref.h.
9974         * python/py-function.c: Do not include py-ref.h.
9975         * python/py-infevents.c: Do not include py-ref.h.
9976         * python/py-linetable.c: Do not include py-ref.h.
9977         * python/py-objfile.c: Do not include py-ref.h.
9978         * python/py-param.c: Do not include py-ref.h.
9979         * python/py-prettyprint.c: Do not include py-ref.h.
9980         * python/py-progspace.c: Do not include py-ref.h.
9981         * python/py-symbol.c: Do not include py-ref.h.
9982         * python/py-symtab.c: Do not include py-ref.h.
9983         * python/py-type.c: Do not include py-ref.h.
9984         * python/py-unwind.c: Do not include py-ref.h.
9985         * python/py-utils.c: Do not include py-ref.h.
9986         * python/py-value.c: Do not include py-ref.h.
9987         * python/py-varobj.c: Do not include py-ref.h.
9988         * python/py-xmethods.c: Do not include py-ref.h.
9989         * python/python.c: Do not include py-ref.h.
9990         * varobj.c: Do not include py-ref.h.
9991
9992 2019-01-22  Tom Tromey  <tom@tromey.com>
9993
9994         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9995         keyword for bcache.
9996
9997 2019-01-22  Tom Tromey  <tom@tromey.com>
9998
9999         * compile/compile-cplus-types.c: Remove a comment by #include.
10000
10001 2019-01-22  Tom Tromey  <tom@tromey.com>
10002
10003         * compile/gcc-c-plugin.h: Include compile-internal.h.
10004
10005 2019-01-22  Tom Tromey  <tom@tromey.com>
10006
10007         * stabsread.c (EXTERN): Do not define.
10008         (symnum, next_symbol_text_func, processing_gcc_compilation)
10009         (within_function, global_sym_chain, global_stabs)
10010         (previous_stab_code, this_object_header_files)
10011         (n_this_object_header_files)
10012         (n_allocated_this_object_header_files): Define.
10013         * stabsread.h (EXTERN): Never define.  Use "extern".
10014
10015 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10016
10017         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10018         history_value.
10019
10020 2019-01-21  Tom Tromey  <tom@tromey.com>
10021
10022         * ui-out.c: Fix includes.
10023         * tui/tui-source.c: Fix includes.
10024         * target.c: Fix includes.
10025         * remote.c: Fix includes.
10026         * regcache.c: Fix includes.
10027         * python/py-block.c: Fix includes.
10028         * printcmd.c: Fix includes.
10029         * or1k-tdep.c: Fix includes.
10030         * mi/mi-main.c: Fix includes.
10031         * m32r-tdep.c: Fix includes.
10032         * csky-tdep.c: Fix includes.
10033         * compile/compile-cplus-types.c: Fix includes.
10034         * cli/cli-interp.c: Fix includes.
10035
10036 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10037
10038         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10039         for padding.
10040
10041 2019-01-16  Tom Tromey  <tom@tromey.com>
10042
10043         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10044         earlier.
10045         (struct objfile) <msymbols_range>: Move from top level.
10046         <msymbols>: New method.
10047         (class objfile_msymbols): Remove.
10048         * symtab.c (default_collect_symbol_completion_matches_break_on):
10049         Update.
10050         * symmisc.c (dump_msymbols): Update.
10051         * stabsread.c (scan_file_globals): Update.
10052         * objc-lang.c (info_selectors_command, info_classes_command)
10053         (find_methods): Update.
10054         * minsyms.c (find_solib_trampoline_target): Update.
10055         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10056         * coffread.c (coff_symfile_read): Update.
10057         * ada-lang.c (ada_lookup_simple_minsym)
10058         (ada_collect_symbol_completion_matches): Update.
10059
10060 2019-01-16  Tom Tromey  <tom@tromey.com>
10061
10062         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10063         type.  Remove no-argument constructor.
10064         <iterator::operator++>: Simplify.
10065         <begin>: Update.
10066         <end>: Use minimal_symbol_count.
10067
10068 2019-01-16  Tom Tromey  <tom@tromey.com>
10069
10070         * objfiles.h (struct objfile) <psymtabs>: New method.
10071         (class objfile_psymtabs): Remove.
10072         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10073         typedef.
10074         <range>: New method.
10075         (require_partial_symbols): Change return type.
10076         * psymtab.c (require_partial_symbols)
10077         (psym_expand_symtabs_matching): Update.
10078         * mdebugread.c (parse_partial_symbols): Update.
10079         * dbxread.c (dbx_end_psymtab): Update.
10080
10081 2019-01-15  Tom Tromey  <tom@tromey.com>
10082
10083         * symtab.c (lookup_objfile_from_block)
10084         (lookup_symbol_in_objfile_symtabs)
10085         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10086         (find_line_symtab, info_sources_command)
10087         (default_collect_symbol_completion_matches_break_on)
10088         (make_source_files_completion_list): Update.
10089         * symmisc.c (print_objfile_statistics, dump_objfile)
10090         (maintenance_print_symbols, maintenance_info_symtabs)
10091         (maintenance_check_symtabs, maintenance_info_line_tables):
10092         Update.
10093         * source.c (select_source_symtab)
10094         (forget_cached_source_info_for_objfile): Update.
10095         * objfiles.h (class objfile_compunits): Remove.
10096         (struct objfile) <compunits_range>: New typedef.
10097         (compunits): New method.
10098         * objfiles.c (objfile_relocate1): Update.
10099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10100         * maint.c (count_symtabs_and_blocks): Update.
10101         * linespec.c (iterate_over_all_matching_symtabs): Update.
10102         * cp-support.c (add_symbol_overload_list_qualified): Update.
10103         * coffread.c (coff_symtab_read): Update.
10104         * ada-lang.c (add_nonlocal_symbols)
10105         (ada_collect_symbol_completion_matches)
10106         (ada_add_global_exceptions): Update.
10107
10108 2019-01-15  Tom Tromey  <tom@tromey.com>
10109
10110         * progspace.h (program_space) <objfiles_safe_range>: New
10111         typedef.
10112         <objfiles_safe>: New method.
10113         * objfiles.h (class all_objfiles_safe): Remove.
10114         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10115         * jit.c (jit_inferior_exit_hook): Update.
10116
10117 2019-01-17  Tom Tromey  <tom@tromey.com>
10118
10119         * progspace.h (program_space) <objfiles_range>: New typedef.
10120         <objfiles>: New method.
10121         <objfiles_head>: Rename from objfiles.
10122         (object_files): Update.
10123         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10124         * guile/scm-pretty-print.c
10125         (ppscm_find_pretty_printer_from_objfiles): Update.
10126         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10127         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10128         Update.
10129         * python/py-progspace.c (pspy_get_objfiles): Update.
10130         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10131         Update.
10132         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10133         (objfpy_lookup_objfile_by_build_id): Update.
10134         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10135         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10136         Update.
10137         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10138         (expand_symtab_containing_pc, lookup_objfile_from_block)
10139         (lookup_static_symbol, basic_lookup_transparent_type)
10140         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10141         (find_line_symtab, info_sources_command)
10142         (default_collect_symbol_completion_matches_break_on)
10143         (make_source_files_completion_list, find_main_name): Update.
10144         * symmisc.c (print_symbol_bcache_statistics)
10145         (print_objfile_statistics, maintenance_print_symbols)
10146         (maintenance_print_msymbols, maintenance_print_objfiles)
10147         (maintenance_info_symtabs, maintenance_check_symtabs)
10148         (maintenance_expand_symtabs, maintenance_info_line_tables):
10149         Update.
10150         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10151         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10152         (map_overlay_command, unmap_overlay_command)
10153         (simple_overlay_update, expand_symtabs_matching)
10154         (map_symbol_filenames): Update.
10155         * symfile-debug.c (set_debug_symfile): Update.
10156         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10157         Update.
10158         * source.c (select_source_symtab, forget_cached_source_info):
10159         Update.
10160         * solib.c (solib_read_symbols): Update.
10161         * solib-spu.c (append_ocl_sos): Update.
10162         * psymtab.c (maintenance_print_psymbols)
10163         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10164         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10165         * printcmd.c (info_symbol_command): Update.
10166         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10167         Update.
10168         * objfiles.h (class all_objfiles): Remove.
10169         * objfiles.c (have_partial_symbols, have_full_symbols)
10170         (have_minimal_symbols, qsort_cmp, update_section_map)
10171         (shared_objfile_contains_address_p)
10172         (default_iterate_over_objfiles_in_search_order): Update.
10173         * objc-lang.c (info_selectors_command, info_classes_command)
10174         (find_methods): Update.
10175         * minsyms.c (find_solib_trampoline_target): Update.
10176         * maint.c (maintenance_info_sections)
10177         (maintenance_translate_address, count_symtabs_and_blocks):
10178         Update.
10179         * main.c (captured_main_1): Update.
10180         * linux-thread-db.c (try_thread_db_load_from_pdir)
10181         (has_libpthread): Update.
10182         * linespec.c (iterate_over_all_matching_symtabs)
10183         (search_minsyms_for_name): Update.
10184         * jit.c (jit_find_objf_with_entry_addr): Update.
10185         * hppa-tdep.c (find_unwind_entry)
10186         (hppa_lookup_stub_minimal_symbol): Update.
10187         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10188         Update.
10189         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10190         (elf_gnu_ifunc_resolve_by_got): Update.
10191         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10192         * dwarf-index-write.c (save_gdb_index_command): Update.
10193         * cp-support.c (add_symbol_overload_list_qualified): Update.
10194         * breakpoint.c (create_overlay_event_breakpoint)
10195         (create_longjmp_master_breakpoint)
10196         (create_std_terminate_master_breakpoint)
10197         (create_exception_master_breakpoint): Update.
10198         * blockframe.c (find_pc_partial_function): Update.
10199         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10200         (ada_collect_symbol_completion_matches)
10201         (ada_add_global_exceptions): Update.
10202
10203 2019-01-17  Tom Tromey  <tom@tromey.com>
10204
10205         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10206         declare VEC.
10207         (solib_target_parse_libraries): Change return type.
10208         (library_list_start_segment, library_list_start_section)
10209         (library_list_end_library, library_list_start_library); Update.
10210         (solib_target_free_library_list): Remove.
10211         (solib_target_parse_libraries): Remove cleanup.  Change return
10212         type.
10213         (solib_target_current_sos): Update.
10214
10215 2019-01-17  Tom Tromey  <tromey@bapiya>
10216
10217         * valprint.c: Replace "the the" with "the".
10218         * symtab.c: Replace "the the" with "the".
10219         * solib.c: Replace "the the" with "the".
10220         * solib-dsbt.c: Replace "the the" with "the".
10221         * linespec.c: Replace "the the" with "the".
10222         * dwarf2loc.h: Replace "the the" with "the".
10223         * amd64-windows-tdep.c: Replace "the the" with "the".
10224         * aarch64-tdep.c: Replace "the the" with "the".
10225
10226 2019-01-16  Keith Seitz  <keiths@redhat.com>
10227
10228         PR gdb/23773
10229         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10230         <builder>: Rename to ..
10231         <m_builder>: ... this and make private.
10232         (dwarf2_cu::get_builder): New method.  Change all users of
10233         `builder' to use this method.
10234         (dwarf2_start_symtab): Move to ...
10235         (dwarf2_cu::start_symtab): ... here.  Update all callers
10236         (setup_type_unit_groups): Move to ...
10237         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10238         callers.
10239         (dwarf2_cu::reset_builder): New method.
10240         (process_full_compunit, process_full_type_unit): Use
10241         dwarf2_cu::reset_builder.
10242         (follow_die_offset): Record the ancestor CU if it is different
10243         from the followed DIE's CU.
10244         (follow_die_sig_1): Likewise.
10245
10246 2019-01-15  Tom Tromey  <tom@tromey.com>
10247
10248         * remote.c (class remote_state) <buf>: Now a char_vector.
10249         <buf_size>: Remove.
10250         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10251         parameter.
10252         (remote_target::getpkt_or_notif_sane_1)
10253         (remote_target::getpkt_sane)
10254         (remote_target::getpkt_or_notif_sane): Likewise.
10255         (class remote_target) <putpkt>: New overload.
10256         (remote_target::read_frame): Change type of "buf_p".  Remove
10257         sizeof_p parameter.
10258         (packet_ok): New overload.
10259         (packet_check_result): New overload.
10260         Update all uses.
10261
10262 2019-01-14  Tom Tromey  <tom@tromey.com>
10263
10264         * remote-notif.c (handle_notification, remote_notif_ack)
10265         (remote_notif_parse): Make "buf" const.
10266         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10267         const.
10268         (remote_notif_parse, remote_notif_ack, handle_notification):
10269         Likewise.
10270         * remote.c (remote_notif_stop_parse): Make "buf" const.
10271         (remote_target::remote_parse_stop_reply): Make "buf" const.
10272         (remote_notif_stop_ack): Make "buf" const.
10273
10274 2019-01-14  Tom Tromey  <tom@tromey.com>
10275
10276         * remote.c (remote_console_output): Make parameter const.
10277
10278 2019-01-14  Tom Tromey  <tom@tromey.com>
10279
10280         * target-debug.h (target_debug_print_signals): Constify.
10281         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10282         * procfs.c (procfs_target::pass_signals): Update.
10283         * linux-nat.c (linux_nat_target::pass_signals): Update.
10284         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10285         * target-delegates.c: Rebuild.
10286         * remote.c (remote_target::program_signals): Update.
10287         (remote_target::pass_signals): Update.
10288         * target.c (target_pass_signals): Constify argument.
10289         (target_program_signals): Likewise.
10290         * target.h (struct target_ops) <pass_signals, program_signals>:
10291         Constify argument.
10292         (target_pass_signals, target_program_signals): Constify argument.
10293
10294 2019-01-14  Tom Tromey  <tom@tromey.com>
10295
10296         PR tui/28819:
10297         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10298
10299 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10300
10301         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10302         field.
10303         * rs6000-tdep.c: Include reggroups.h.
10304         (IS_V_ALIAS_PSEUDOREG): Define.
10305         (rs6000_register_name): Return names for the "vX" aliases.
10306         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10307         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10308         aliases.  Call default_register_reggroup_p for all other
10309         pseudo-registers.
10310         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10311         New functions.
10312         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10313         Handle "vX" aliases.
10314         (v_alias_pseudo_register_collect): New function.
10315         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10316         (rs6000_gdbarch_init): Initialize "vX" aliases as
10317         pseudo-registers.  Restore registration of
10318         rs6000_pseudo_register_reggroup_p with
10319         set_tdesc_pseudo_register_reggroup_p.
10320
10321 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10322
10323         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10324         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10325         set_gdbarch_num_pseudo_regs.
10326
10327 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10328
10329         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10330         Remove arg prefixname, add do_set and do_show.
10331         Add member functions set_list and show_list.
10332         * cli/cli-style.c (class cli_style_option): Update accordingly.
10333         (style_set_list): Move to file scope.
10334         (style_show_list): Likewise.
10335         (set_style): Call help_list.
10336         (show_style): Call cmd_show_list.
10337         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10338         Update to use the new macro.
10339
10340 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10341
10342         * ada-lang.c (_initialize_ada_language): Expand the help text
10343         for the "catch exception" command.
10344
10345 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10346
10347         * symtab.c (matching_obj_sections): Initialize obj,
10348         declare it closer to its usage.
10349
10350 2019-01-10  Tom Tromey  <tom@tromey.com>
10351
10352         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10353         (basic_inf_threads_range): Remove.
10354         (inf_threads_range, inf_non_exited_threads_range)
10355         (safe_inf_threads_range): Use next_adapter.
10356
10357 2019-01-10  Keith Seitz  <keiths@redhat.com>
10358
10359         PR gdb/23712
10360         PR symtab/23010
10361         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10362         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10363
10364 2019-01-10  Keith Seitz  <keiths@redhat.com>
10365
10366         PR gdb/23712
10367         PR symtab/23010
10368         * dictionary.c (pending_to_vector): Remove.
10369         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10370         Remove _1 suffix, replacing functions of the same name.  Update
10371         all callers.
10372         (dict_create_hashed, dict_create_hashed_expandable)
10373         (dict_create_linear, dict_create_linear_expandable, dict_free)
10374         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10375         Make functions static.
10376
10377 2019-01-10  Keith Seitz  <keiths@redhat.com>
10378
10379         PR gdb/23712
10380         PR symtab/23010
10381         * dictionary.h (struct dictionary): Replace declaration with
10382         multidictionary.
10383         (dict_create_hashed, dict_create_hashed_expandable)
10384         (dict_create_linear, dict_create_linear_expandable)
10385         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10386         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10387         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10388         taking multidictionary argument.
10389         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10390         * block.h (struct block) <dict>: Change to multidictionary
10391         and rename `multidict'.
10392         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10393         symmisc.c: Update all dictionary references to multidictionary.
10394
10395 2019-01-10  Keith Seitz  <keiths@redhat.com>
10396
10397         PR gdb/23712
10398         PR symtab/23010
10399         * dictionary.c: Include unordered_map.
10400         (pending_to_vector): New function.
10401         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10402         Rewrite the non-"_1" functions to take vector instead
10403         of linked list.
10404         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10405         "new" _1 versions of the same name.
10406         (multidictionary): Define.
10407         (std::hash<enum language): New definition.
10408         (collate_pending_symbols_by_language, mdict_create_hashed)
10409         (mdict_create_hashed_expandable, mdict_create_linear)
10410         (mdict_create_linear_expandable, mdict_free)
10411         (find_language_dictionary, create_new_language_dictionary)
10412         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10413         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10414         (mdict_size, mdict_empty): New functions.
10415         * dictionary.h (mdict_iterator): Define.
10416
10417 2019-01-10  Pedro Alves  <palves@redhat.com>
10418
10419         * breakpoint.c (read_uploaded_action)
10420         (create_tracepoint_from_upload): Adjust to use
10421         gdb::unique_xmalloc_ptr.
10422         * ctf.c (ctf_write_uploaded_tp):
10423         (SET_ARRAY_FIELD): Use emplace_back.
10424         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10425         * tracefile-tfile.c (tfile_write_uploaded_tp):
10426         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10427         gdb::unique_xmalloc_ptr.
10428         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10429         at_string, cond_string, cmd_strings>: Replace char pointers
10430         with gdb::unique_xmalloc_ptr.
10431
10432 2019-01-10  Pedro Alves  <palves@redhat.com>
10433
10434         * solib-target.c (library_list_start_library): Don't xstrdup name.
10435
10436 2019-01-10  Pedro Alves  <palves@redhat.com>
10437
10438         * mdebugread.c (parse_partial_symbols): Use
10439         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10440
10441 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10442
10443         * linux-fork.c (scoped_switch_fork_info)
10444         <~scoped_switch_fork_info>: Fix incorrect variable name.
10445
10446 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10447
10448         * linux-fork.c (scoped_switch_fork_info)
10449         <scoped_switch_fork_info>: Make explicit.
10450         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10451
10452 2019-01-10  Tom Tromey  <tom@tromey.com>
10453
10454         * objfiles.h (objfile::reset_psymtabs): Update.
10455         * objfiles.c (objfile::objfile): Update.
10456         * psymtab.h (psymtab_storage::obstack): Update.
10457         (psymtab_storage::m_obstack): Use gdb::optional.
10458         (class psymtab_storage): Update comment.  Remove objfile
10459         parameter.
10460         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10461
10462 2019-01-10  Tom Tromey  <tom@tromey.com>
10463
10464         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10465         <free_psymtabs>: Now private.
10466         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10467         (allocate_psymtab): Use new method.
10468
10469 2019-01-10  Tom Tromey  <tom@tromey.com>
10470
10471         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10472         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10473         * mdebugread.c (parse_partial_symbols): Use
10474         allocate_dependencies.
10475         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10476         allocate_dependencies.
10477         (process_psymtab_comp_unit_reader)
10478         (build_type_psymtab_dependencies): Likewise.
10479         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10480
10481 2019-01-10  Tom Tromey  <tom@tromey.com>
10482
10483         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10484         PSYMBOL_SET_LANGUAGE.
10485         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10486
10487 2019-01-10  Tom Tromey  <tom@tromey.com>
10488
10489         * psymtab.h (psymtab_storage::obstack): New method.
10490         <m_obstack>: Rename from obstack; now private.
10491         * psymtab.c (psymtab_storage): Update.
10492         * dwarf2read.c (create_addrmap_from_index)
10493         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10494         Update.
10495
10496 2019-01-10  Tom Tromey  <tom@tromey.com>
10497
10498         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10499         * objfiles.h (objfile::reset_psymtabs): New method.
10500
10501 2019-01-10  Tom Tromey  <tom@tromey.com>
10502
10503         * symmisc.c (print_symbol_bcache_statistics): Update.
10504         (print_objfile_statistics): Update.
10505         * symfile.c (reread_symbols): Update.
10506         * psymtab.h (class psymtab_storage): New.
10507         * psymtab.c (psymtab_storage): New constructor.
10508         (~psymtab_storage): New destructor.
10509         (require_partial_symbols): Update.
10510         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10511         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10512         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10513         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10514         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10515         (start_psymtab_common, end_psymtab_common)
10516         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10517         (allocate_psymtab): Update.
10518         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10519         Update.
10520         (dump_psymtab_addrmap, maintenance_print_psymbols)
10521         (maintenance_check_psymtabs): Update.
10522         (class objfile_psymtabs): Move to objfiles.h.
10523         * psympriv.h (discard_psymtab): Now inline.
10524         (psymtab_discarder::psymtab_discarder): Update.
10525         (psymtab_discarder::~psymtab_discarder): Update.
10526         (ALL_OBJFILE_PSYMTABS): Rewrite.
10527         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10528         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10529         Remove fields.
10530         <partial_symtabs>: New field.
10531         (class objfile_psymtabs): Move from psymtab.h.  Update.
10532         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10533         psymbol_cache.
10534         (objfile::~objfile): Don't destroy psymbol_cache.
10535         * mdebugread.c (parse_partial_symbols): Update.
10536         * dwarf2read.c (create_addrmap_from_index)
10537         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10538         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10539         (add_partial_subprogram, dwarf2_ranges_read): Update.
10540         * dwarf-index-write.c (write_address_map)
10541         (write_one_signatured_type, recursively_write_psymbols)
10542         (class debug_names, class debug_names, write_psymtabs_to_index):
10543         Update.
10544
10545 2019-01-10  Tom Tromey  <tom@tromey.com>
10546
10547         * symtab.h (SYMBOL_SET_NAMES): Update.
10548         (symbol_set_names): Update.
10549         (MSYMBOL_SET_NAMES): Update.
10550         * symtab.c (symbol_set_names): Change argument to be an
10551         objfile_per_bfd_storage.
10552         * psymtab.c (add_psymbol_to_bcache): Update.
10553         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10554
10555 2019-01-10  Tom Tromey  <tom@tromey.com>
10556
10557         * symtab.c (create_demangled_names_hash): Change argument to be an
10558         objfile_per_bfd_storage.
10559         (symbol_set_names): Update.
10560
10561 2019-01-10  Tom Tromey  <tom@tromey.com>
10562
10563         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10564         init_psymbol_list.
10565         * psymtab.c (init_psymbol_list): Do nothing if already called.
10566         * psympriv.h (init_psymbol_list): Add comment.
10567         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10568         init_psymbol_list.
10569         * dbxread.c (dbx_symfile_read): Unconditionally call
10570         init_psymbol_list.
10571
10572 2019-01-10  Tom Tromey  <tom@tromey.com>
10573
10574         * xcoffread.c (scan_xcoff_symtab): Update.
10575         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10576         "where".
10577         * mdebugread.c (parse_partial_symbols)
10578         (handle_psymbol_enumerators): Update.
10579         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10580         * dbxread.c (read_dbx_symtab): Update.
10581         * psympriv.h (psymbol_placement): New enum.
10582         (add_psymbol_to_list): Update.
10583
10584 2019-01-10  Tom Tromey  <tom@tromey.com>
10585
10586         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10587         static_psymbols parameters.
10588         (scan_xcoff_symtab): Update.
10589         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10590         static_psymbols parameters.
10591         * psympriv.h (start_psymtab_common): Update.
10592         * mdebugread.c (parse_partial_symbols): Update.
10593         * dwarf2read.c (create_partial_symtab): Update.
10594         * dbxread.c (read_dbx_symtab): Update.
10595         (start_psymtab): Remove global_psymbols and static_psymbols
10596         parameters.
10597
10598 2019-01-10  Tom Tromey  <tom@tromey.com>
10599
10600         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10601         * psymtab.c (allocate_psymtab): Add comment.
10602         * psympriv.h (allocate_psymtab): Add comment.
10603         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10604         initializations.
10605         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10606
10607 2019-01-10  Tom Tromey  <tom@tromey.com>
10608
10609         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10610         Don't declare.
10611         * mipsread.c: Include mdebugread.h.
10612         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10613         Declare.
10614         * elfread.c: Include mdebugread.h.
10615
10616 2019-01-09  Tom Tromey  <tom@tromey.com>
10617
10618         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10619         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10620         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10621         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10622         (psym_lookup_symbol, psym_find_last_source_symtab)
10623         (psym_forget_cached_source_info, psym_print_stats)
10624         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10625         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10626         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10627         (psym_find_compunit_symtab_by_address)
10628         (maintenance_print_psymbols, maintenance_info_psymtabs)
10629         (maintenance_check_psymtabs): Use ranged for.
10630         * psymtab.h (class objfile_psymtabs): New.
10631         (require_partial_symbols): Return objfile_psymtabs.
10632         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10633
10634 2019-01-09  Tom Tromey  <tom@tromey.com>
10635
10636         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10637         (find_pc_mapped_section, list_overlays_command)
10638         (map_overlay_command, unmap_overlay_command)
10639         (simple_overlay_update): Use all_objfiles.
10640         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10641         * printcmd.c (info_symbol_command): Use all_objfiles.
10642         * objfiles.h (ALL_OBJSECTIONS): Remove.
10643         * maint.c (maintenance_translate_address): Use all_objfiles.
10644         * gcore.c (gcore_create_callback): Use all_objfiles.
10645         (objfile_find_memory_regions): Likewise.
10646
10647 2019-01-09  Tom Tromey  <tom@tromey.com>
10648
10649         * symtab.c (find_line_symtab, info_sources_command)
10650         (make_source_files_completion_list): Use objfile_compunits.
10651         * source.c (select_source_symtab): Use objfile_compunits.
10652         * objfiles.h (struct objfile): Update comment.
10653         (ALL_OBJFILES): Remove.
10654         (ALL_FILETABS): Remove.
10655         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10656         objfile_compunits.
10657
10658 2019-01-09  Tom Tromey  <tom@tromey.com>
10659
10660         * symmisc.c (print_objfile_statistics, dump_objfile)
10661         (maintenance_print_symbols): Use compunit_filetabs.
10662         * source.c (forget_cached_source_info_for_objfile): Use
10663         compunit_filetabs.
10664         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10665         (ALL_FILETABS): Use compunit_filetabs.
10666         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10667         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10668
10669 2019-01-09  Tom Tromey  <tom@tromey.com>
10670
10671         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10672         (compunit_filetabs): New.
10673         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10674         compunit_filetabs.
10675         (info_sources_command, make_source_files_completion_list): Remove
10676         declaration.
10677         * symmisc.c (print_objfile_statistics, dump_objfile)
10678         (maintenance_print_symbols): Remove declaration.
10679         (maintenance_info_symtabs): Use compunit_filetabs.
10680         (maintenance_info_line_tables): Likewise.
10681         * source.c (select_source_symtab): Change local variable name.
10682         (forget_cached_source_info_for_objfile): Remove declaration.
10683         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10684         * objfiles.c (objfile_relocate1): Remove declaration.
10685         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10686         declaration.
10687         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10688         * coffread.c (coff_symtab_read): Remove declaration.
10689         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10690         compunit_filetabs.
10691
10692 2019-01-09  Tom Tromey  <tom@tromey.com>
10693
10694         * symtab.c (lookup_objfile_from_block)
10695         (find_pc_sect_compunit_symtab, search_symbols)
10696         (default_collect_symbol_completion_matches_break_on): Use
10697         objfile_compunits.
10698         * objfiles.h (ALL_COMPUNITS): Remove.
10699         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10700         * cp-support.c (add_symbol_overload_list_qualified): Use
10701         objfile_compunits.
10702         * ada-lang.c (ada_collect_symbol_completion_matches)
10703         (ada_add_global_exceptions): Use objfile_compunits.
10704
10705 2019-01-09  Tom Tromey  <tom@tromey.com>
10706
10707         * source.c (select_source_symtab)
10708         (forget_cached_source_info_for_objfile): Remove declaration.
10709         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10710         declaration.
10711         * maint.c (count_symtabs_and_blocks): Remove declaration.
10712         * cp-support.c (add_symbol_overload_list_qualified): Remove
10713         declaration.
10714         * coffread.c (coff_symtab_read): Remove declaration.
10715         * symtab.c (lookup_symbol_in_objfile_symtabs)
10716         (basic_lookup_transparent_type_1): Use objfile_compunits.
10717         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10718         (info_sources_command, search_symbols)
10719         (default_collect_symbol_completion_matches_break_on)
10720         (make_source_files_completion_list): Remove declaration.
10721         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10722         (ada_collect_symbol_completion_matches)
10723         (ada_add_global_exceptions): Remove declaration.
10724         * linespec.c (iterate_over_all_matching_symtabs): Use
10725         objfile_compunits.
10726         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10727         (class objfile_compunits): New.
10728         (ALL_COMPUNITS): Use objfile_compunits.
10729         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10730         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10731         objfile_compunits.
10732         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10733
10734 2019-01-09  Tom Tromey  <tom@tromey.com>
10735
10736         * symtab.c (search_symbols)
10737         (default_collect_symbol_completion_matches_break_on): Use
10738         objfile_msymbols.
10739         * ada-lang.c (ada_lookup_simple_minsym)
10740         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10741         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10742         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10743         objfile_msymbols.
10744         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10745         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10746         * objc-lang.c (find_methods): Use objfile_msymbols.
10747         (info_selectors_command, info_classes_command): Likewise.
10748         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10749         * objfiles.h (class objfile_msymbols): New.
10750         (ALL_OBJFILE_MSYMBOLS): Remove.
10751         (ALL_MSYMBOLS): Remove.
10752
10753 2019-01-09  Tom Tromey  <tom@tromey.com>
10754
10755         * common/next-iterator.h (next_adapter): Add Iterator template
10756         parameter.
10757         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10758         (class all_objfiles_safe): New.
10759         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10760         * objfiles.c (put_objfile_before): Update comment.
10761         (add_separate_debug_objfile): Likewise.
10762         (free_all_objfiles): Use all_objfiles_safe.
10763         (objfile_purge_solibs): Likewise.
10764
10765 2019-01-09  Tom Tromey  <tom@tromey.com>
10766
10767         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10768         (expand_symtab_containing_pc, lookup_static_symbol)
10769         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10770         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10771         all_objfiles.
10772         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10773         * breakpoint.c (create_overlay_event_breakpoint)
10774         (create_longjmp_master_breakpoint)
10775         (create_std_terminate_master_breakpoint)
10776         (create_exception_master_breakpoint): Use all_objfiles.
10777         * linux-thread-db.c (try_thread_db_load_from_pdir)
10778         (has_libpthread): Use all_objfiles.
10779         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10780         * linespec.c (iterate_over_all_matching_symtabs)
10781         (search_minsyms_for_name): Use all_objfiles.
10782         * maint.c (maintenance_info_sections): Use all_objfiles.
10783         * main.c (captured_main_1): Use all_objfiles.
10784         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10785         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10786         * guile/scm-pretty-print.c
10787         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10788         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10789         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10790         (maintenance_print_msymbols): Use all_objfiles.
10791         * source.c (select_source_symtab): Use all_objfiles.
10792         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10793         * symfile.c (remove_symbol_file_command)
10794         (expand_symtabs_matching, map_symbol_filenames): Use
10795         all_objfiles.
10796         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10797         all_objfiles.
10798         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10799         * objc-lang.c (find_methods): Use all_objfiles.
10800         * objfiles.c (have_partial_symbols, have_full_symbols)
10801         (have_minimal_symbols, qsort_cmp)
10802         (default_iterate_over_objfiles_in_search_order): Use
10803         all_objfiles.
10804         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10805         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10806         (maintenance_check_psymtabs): Use all_objfiles.
10807         (ALL_PSYMTABS): Remove.
10808         * compile/compile-object-run.c (do_module_cleanup): Use
10809         all_objfiles.
10810         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10811         * cp-support.c (add_symbol_overload_list_qualified): Use
10812         all_objfiles.
10813         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10814         Use all_objfiles.
10815         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10816         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10817         all_objfiles.
10818         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10819         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10820         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10821         Uses all_objfiles.
10822         * solib.c (solib_read_symbols): Use all_objfiles
10823
10824 2019-01-09  Tom Tromey  <tom@tromey.com>
10825
10826         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10827         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10828         all_objfiles.
10829         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10830         * symmisc.c (print_symbol_bcache_statistics)
10831         (print_objfile_statistics, maintenance_print_objfiles)
10832         (maintenance_info_symtabs, maintenance_check_symtabs)
10833         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10834         all_objfiles.
10835         * source.c (forget_cached_source_info): Use all_objfiles.
10836         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10837         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10838         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10839         * objfiles.c (update_section_map): Use all_objfiles.
10840         (shared_objfile_contains_address_p): Likewise.
10841         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10842         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10843
10844 2019-01-09  Tom Tromey  <tom@tromey.com>
10845
10846         * common/next-iterator.h: New file.
10847         * objfiles.h (class all_objfiles): New.
10848         (struct objfile_iterator): New.
10849
10850 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10851
10852         * NEWS: Move the description of the changed "frame", "select-frame",
10853          and "info frame" commands to the Changed commands section.
10854
10855 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10856
10857         * gdbtypes.c (check_stub_method_group): Remove handling of old
10858         mangling schemes.
10859         * linespec.c (find_methods): Likewise.
10860         * stabsread.c (read_member_functions): Likewise.
10861         * valops.c (search_struct_method): Likewise.
10862         (value_struct_elt_for_reference): Likewise.
10863         * NEWS: Mention this change.
10864
10865 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10866
10867         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10868         print_source_lines.
10869         * source.c (print_source_lines_base): Update line number check.
10870         (print_source_lines): New function.
10871         (source_lines_range::source_lines_range): New function.
10872         * source.h (class source_lines_range): New class.
10873         (print_source_lines): New declaration.
10874
10875 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10876
10877         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10878
10879 2019-01-08  Tom Tromey  <tom@tromey.com>
10880             Simon Marchi  <simon.marchi@ericsson.com>
10881
10882         PR gdb/24060
10883         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10884         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10885         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10886         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10887         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10888         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10889
10890 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10891
10892         * source.c (select_source_symtab): Move header comment to
10893         declaration in source.h.
10894         (forget_cached_source_info_for_objfile): Likewise.
10895         (forget_cached_source_info): Likewise.
10896         (identify_source_line): Likewise.
10897         * source.h (identify_source_line): Move declaration from symtab.h
10898         and add comment from source.c
10899         (print_source_lines): Likewise.
10900         (forget_cached_source_info_for_objfile): Likewise.
10901         (forget_cached_source_info): Likewise.
10902         (select_source_symtab): Likewise.
10903         (enum print_source_lines_flag): Move definition from symtab.h.
10904         * symtab.h (identify_source_line): Move declaration to source.h.
10905         (print_source_lines): Likewise.
10906         (forget_cached_source_info_for_objfile): Likewise.
10907         (forget_cached_source_info): Likewise.
10908         (select_source_symtab): Likewise.
10909         (enum print_source_lines_flag): Move definition to source.h.
10910         * tui/tui-hooks.c: Add 'source.h' include.
10911
10912 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10913
10914         * source.c (print_source_lines_base): Handle requests to print
10915         reverse line number sequences, and guard against empty lines
10916         string.
10917
10918 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10919
10920         * source.c (print_source_lines_base): Fix skip of '\r' if next
10921         character is '\n'.
10922
10923 2019-01-06  Tom Tromey  <tom@tromey.com>
10924
10925         * c-exp.y (struct c_parse_state) <macro_original_text,
10926         expansion_obstack>: New member.
10927         (macro_original_text, expansion_obstack): Remove globals.
10928         (scan_macro_expansion, scanning_macro_expansion)
10929         (finished_macro_expansion): Update.
10930         (scan_macro_cleanup): Remove.
10931         (yylex, c_parse): Update.
10932
10933 2019-01-06  Tom Tromey  <tom@tromey.com>
10934
10935         * c-exp.y (struct c_parse_state) <strings>: New member.
10936         (operator_stoken): Update.
10937
10938 2019-01-06  Tom Tromey  <tom@tromey.com>
10939
10940         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10941         (union type_stack_elt) <typelist_val>: Now a pointer to
10942         std::vector.
10943         (type_stack_cleanup): Don't declare.
10944         (push_typelist): Update.
10945         * parse.c (pop_typelist): Return a std::vector.
10946         (push_typelist): Take a std::vector.
10947         (follow_types): Update.  Do not free args.
10948         (type_stack_cleanup): Remove.
10949         * c-exp.y (struct c_parse_state): New.
10950         (cpstate): New global.
10951         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10952         (nonempty_typelist): Update.
10953         (func_mod): Create a new vector.
10954         (c_parse): Create a c_parse_state.
10955         (check_parameter_typelist): Do not delete params.
10956         (function_method): Update.  Do not delete type_list.
10957
10958 2019-01-06  Tom Tromey  <tom@tromey.com>
10959
10960         PR gdb/28155:
10961         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10962         check_typedef.
10963         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10964         (print_return_value): Likewise.
10965
10966 2019-01-05  Tom Tromey  <tom@tromey.com>
10967
10968         * contrib/cleanup_check.py: Remove.
10969         * contrib/gcc-with-excheck: Remove.
10970         * contrib/exsummary.py: Remove.
10971         * contrib/excheck.py: Remove.
10972
10973 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10974
10975         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10976         NULL. Initialize tpprev to NULL instead of assigning it
10977         to NULL on the next statement.
10978         * windows-nat.c (windows_delete_thread): Remove check for
10979         main_thread_id before printing thread exit notifications.
10980         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10981         Remove thread ID check against main_thread_id.
10982         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10983         windows_delete_thread.
10984         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10985
10986 2019-01-04  Tom Tromey  <tom@tromey.com>
10987
10988         * compile/compile.c (_initialize_compile): Use upper case for
10989         metasyntactic variables.
10990         * symmisc.c (_initialize_symmisc): Use upper case for
10991         metasyntactic variables.
10992         * psymtab.c (_initialize_psymtab): Use upper case for
10993         metasyntactic variables.
10994         * demangle.c (demangle_command): Use upper case for metasyntactic
10995         variables.
10996         (_initialize_demangler): Likewise.
10997         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10998         variables.
10999
11000 2019-01-03  Tom Tromey  <tom@tromey.com>
11001
11002         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11003
11004 2019-01-03  Tom Tromey  <tom@tromey.com>
11005
11006         * python/py-symtab.c (salpy_str): Update.
11007         (struct salpy_sal_object) <symtab>: Now a PyObject.
11008         (salpy_dealloc): Update.
11009         (del_objfile_sal): Use gdbpy_ref.
11010
11011 2019-01-03  Tom Tromey  <tom@tromey.com>
11012
11013         * python/py-type.c (convert_field): Use new_reference.  Return
11014         gdbpy_ref.
11015         (make_fielditem): Return gdbpy_ref.
11016         (typy_fields): Update.
11017         (typy_getitem): Update.
11018         (field_name): Return gdbpy_ref.  Use new_reference.
11019         (typy_iterator_iternext): Update.
11020
11021 2019-01-03  Tom Tromey  <tom@tromey.com>
11022
11023         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11024
11025 2019-01-03  Tom Tromey  <tom@tromey.com>
11026
11027         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11028         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11029         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11030         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11031         (pspy_set_type_printers): Likewise.
11032         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11033         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11034         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11035         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11036         (objfpy_set_type_printers): Likewise.
11037
11038 2019-01-03  Tom Tromey  <tom@tromey.com>
11039
11040         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11041         (gdbpy_print_stack): Use gdbpy_err_fetch.
11042         * python/python-internal.h (class gdbpy_err_fetch): New class.
11043         (class gdbpy_enter) <m_error_type, m_error_value,
11044         m_error_traceback>: Remove.
11045         <m_error>: New member.
11046         (gdbpy_exception_to_string): Don't declare.
11047         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11048         * python/py-value.c (convert_value_from_python): Use
11049         gdbpy_err_fetch.
11050         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11051         gdbpy_exception_to_string.
11052         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11053         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11054         gdbpy_err_fetch.
11055
11056 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11057
11058         * linux-nat.c (delete_lwp_cleanup): Delete.
11059         (struct lwp_deleter): New struct.
11060         (lwp_info_up): New typedef.
11061         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11062         lwp_info_up.
11063
11064 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11065
11066         * linux-fork.c (class scoped_switch_fork_info): New class.
11067         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11068
11069 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11070
11071         * valops.c (find_overload_match): Remove use of null_cleanup, and
11072         calls to do_cleanups.
11073
11074 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11075
11076         * compile/compile-cplus-types.c
11077         (compile_cplus_instance::decl_name): Handle changes to
11078         cp_func_name.
11079         * cp-support.c (cp_func_name): Update header comment, update
11080         return type.
11081         * cp-support.h (cp_func_name): Update return type in declaration.
11082         * valops.c (find_overload_match): Move temp_func local to top
11083         level of function and change its type.  Use temp_func to hold and
11084         delete temporary string obtained from cp_func_name.
11085
11086 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11087
11088         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11089         gdb::char_vector, remove cleanup, and update uses of `msg`.
11090
11091 2019-01-03  Jim Wilson  <jimw@sifive.com>
11092
11093         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11094
11095 2019-01-02  Tom Tromey  <tom@tromey.com>
11096
11097         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11098         (tdesc_parse_xml): Remove cleanups.
11099         * target-descriptions.h (make_cleanup_free_target_description):
11100         Don't declare.
11101         (target_desc_deleter): New struct.
11102         (target_desc_up): New typedef.
11103         * target-descriptions.c (target_desc_deleter::operator()): Rename
11104         from free_target_description.
11105         (make_cleanup_free_target_description): Remove.
11106
11107 2019-01-02  Tom Tromey  <tom@tromey.com>
11108
11109         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11110         constructor, destructor.
11111         (linespec_parser): Remove typedef.
11112         (~linespec_parser): Rename from linespec_parser_delete.
11113         (linespec_lex_to_end, linespec_complete_label)
11114         (linespec_complete): Update.
11115         (decode_line_full): Remove cleanups.
11116         (decode_line_1): Update.
11117
11118 2019-01-02  Tom Tromey  <tom@tromey.com>
11119
11120         * python/python-internal.h (inferior_to_inferior_object): Change
11121         return type.
11122         * python/py-exitedevent.c (create_exited_event_object): Update.
11123         * python/py-inferior.c (inferior_to_inferior_object): Return
11124         gdbpy_ref.
11125         (python_new_inferior, python_inferior_deleted)
11126         (thread_to_thread_object, delete_thread_object)
11127         (build_inferior_list, gdbpy_selected_inferior): Update.
11128         * python/py-infthread.c (create_thread_object): Update.  Also fail
11129         if inferior_to_inferior_object fails.
11130
11131 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11132
11133         * inferior.h (class inferior) <displaced_step_state>: New field.
11134         * infrun.h (struct displaced_step_state): Move here from
11135         infrun.c.  Initialize fields, add constructor.
11136         <inf>: Remove field.
11137         <reset>: New method.
11138         * infrun.c (struct displaced_step_inferior_state): Move to
11139         infrun.h.
11140         (displaced_step_inferior_states): Remove.
11141         (get_displaced_stepping_state): Adust.
11142         (displaced_step_in_progress_any_inferior): Adjust.
11143         (displaced_step_in_progress_thread): Adjust.
11144         (displaced_step_in_progress): Adjust.
11145         (add_displaced_stepping_state): Remove.
11146         (get_displaced_step_closure_by_addr): Adjust.
11147         (remove_displaced_stepping_state): Remove.
11148         (infrun_inferior_exit): Call displaced_step_state.reset.
11149         (use_displaced_stepping): Don't check for NULL.
11150         (displaced_step_prepare_throw): Call
11151         get_displaced_stepping_state.
11152         (displaced_step_fixup): Don't check for NULL.
11153         (prepare_for_detach): Don't check for NULL.
11154
11155 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11156
11157         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11158          in case of call that did not complete.
11159
11160 2019-01-02  Andrey Utkin  <autkin@undo.io>
11161
11162         * symfile.c (find_separate_debug_file): Fix search of debug files for
11163         remote debuggee.
11164
11165 2019-01-02  Tom Tromey  <tom@tromey.com>
11166
11167         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11168         indentation.
11169         * python/py-frame.c (frapy_older): Remove cast.
11170         (frapy_newer): Likewise.
11171         * python/py-breakpoint.c (local_setattro): Remove cast.
11172         * python/py-arch.c (archpy_name): Remove local variable.
11173         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11174
11175 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11176
11177         * unittests/basic_string_view/element_access/char/empty.cc:
11178         Fix year range in copyright header.
11179
11180 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11181
11182         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11183         Delete.
11184         <operator==>: Update with for removed field.
11185         <hash>: Likewise.
11186         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11187         <isa_features>: ...this.
11188         <abi_features>: New field.
11189         (riscv_isa_flen): Update comment.
11190         (riscv_abi_xlen): New declaration.
11191         (riscv_abi_flen): New declaration.
11192         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11193         isa_features.
11194         (riscv_abi_xlen): New function.
11195         (riscv_isa_flen): Update to get answer from isa_features.
11196         (riscv_abi_flen): New function.
11197         (riscv_has_fp_abi): Update to get answer from abi_features.
11198         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11199         xlen and flen.
11200         (riscv_call_info) <xlen, flen>: Update comment.
11201         (riscv_call_arg_struct): Remove invalid assertions
11202         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11203         is removed.
11204         (riscv_gdbarch_init): Gather isa features and abi features
11205         separately, ensure both match on the gdbarch when reusing an old
11206         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11207         a target with 64-bit float hardware.
11208
11209 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11210
11211         * source.c (search_command_helper): Stop reverse search
11212         when line 1 has been searched.
11213
11214 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11215
11216         * record-full.c (record_full_base_target::close): Rewrite
11217         record_full_core_buf_list free logic.
11218
11219 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11220
11221         * break-catch-syscall.c (print_one_catch_syscall): xfree
11222         the last text.
11223
11224 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11225
11226         * top.c (print_gdb_version): Update Copyright year in version
11227         message.
11228
11229 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11230
11231         Update copyright year range in all GDB files.
11232
11233 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11234
11235         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11236
11237 For older changes see ChangeLog-2018.
11238 \f
11239 Local Variables:
11240 mode: change-log
11241 left-margin: 8
11242 fill-column: 74
11243 version-control: never
11244 coding: utf-8
11245 End:
11246