gdb/fortran: Add new function to evaluate Fortran expressions
[external/binutils.git] / gdb / ChangeLog
1 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * f-lang.c (evaluate_subexp_f): New function.
4         (exp_descriptor_f): New global.
5         (f_language_defn): Use exp_descriptor_f instead of
6         exp_descriptor_standard.
7
8 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9
10         * f-exp.y (struct token): Add comments.
11         (dot_ops): Remove uppercase versions and the end marker.
12         (f77_keywords): Likewise.
13         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14         entries in the dot_ops array are case insensitive, and use
15         strncasecmp to compare strings.  Also some whitespace cleanup in
16         this area.  Similar for the f77_keywords array, except entries in
17         this list might be case sensitive.
18
19 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
20
21         * f-exp.y (struct f77_boolean_val): Add comments.
22         (boolean_values): Remove uppercase versions, and end marker.
23         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
24         and use strncasecmp to achieve case insensitivity.  Additionally,
25         perform whitespace cleanup around this code.
26
27 2019-03-06  Tom Tromey  <tromey@adacore.com>
28
29         * remote-sim.c (gdbsim_target_open): Use result of
30         gdb_argv::release.
31
32 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
33         Dirk Schubert  <dirk.schubert@arm.com>
34         Chris January  <chris.january@arm.com>
35
36         * eval.c (evaluate_subexp_standard): Call Fortran argument
37         wrapping logic.
38         * f-lang.c (struct value): A value which can be passed into a
39         Fortran function call.
40         (fortran_argument_convert): Wrap Fortran arguments in a pointer
41         where appropriate.
42         (struct type): Value ready for a Fortran function call.
43         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
44         is needed.
45         * f-lang.h (fortran_argument_convert): Declaration.
46         (fortran_preserve_arg_pointer): Declaration.
47         * infcall.c (value_arg_coerce): Call Fortran argument logic.
48
49 2019-03-05  Tom Tromey  <tromey@adacore.com>
50
51         * python/py-prettyprint.c (print_string_repr): Remove #if.
52         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
53
54 2019-03-05  Tom Tromey  <tromey@adacore.com>
55
56         * target.c (the_dummy_target): Move later.  Change type to
57         "dummy_target".
58         (initialize_targets): Don't initialize the_dummy_target.
59
60 2019-03-05  Tom Tromey  <tromey@adacore.com>
61
62         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
63         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
64
65 2019-03-05  Tom Tromey  <tromey@adacore.com>
66
67         * windows-nat.c (windows_nat_target::attach)
68         (windows_nat_target::detach): Don't call gdb_flush.
69         * valprint.c (generic_val_print, val_print, val_print_string):
70         Don't call gdb_flush.
71         * utils.c (defaulted_query): Don't call gdb_flush.
72         * typeprint.c (print_type_scalar): Don't call gdb_flush.
73         * target.c (target_announce_detach): Don't call gdb_flush.
74         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
75         * remote.c (extended_remote_target::attach): Don't call
76         gdb_flush.
77         * procfs.c (procfs_target::detach): Don't call gdb_flush.
78         * printcmd.c (do_examine): Don't call gdb_flush.
79         (info_display_command): Don't call gdb_flush.
80         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
81         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
82         * memattr.c (info_mem_command): Don't call gdb_flush.
83         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
84         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
85         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
86         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
87         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
88         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
89         (gnu_nat_target::detach): Don't call gdb_flush.
90         * f-valprint.c (f_val_print): Don't call gdb_flush.
91         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
92         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
93         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
94         gdb_flush.
95         * c-valprint.c (c_val_print): Don't call gdb_flush.
96         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
97
98 2019-03-05  Tom Tromey  <tromey@adacore.com>
99
100         * varobj.c (update_dynamic_varobj_children): Update.
101         (install_default_visualizer): Use reset, not release.
102         * value.c (set_internalvar): Update.
103         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
104         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
105         ATTRIBUTE_UNUSED_RESULT.
106
107 2019-03-05  Tom Tromey  <tromey@adacore.com>
108
109         * remote.c (class scoped_remote_fd) <release>: Add
110         ATTRIBUTE_UNUSED_RESULT.
111
112 2019-03-05  Tom Tromey  <tromey@adacore.com>
113
114         * macroexp.c (struct macro_buffer) <release>: Add
115         ATTRIBUTE_UNUSED_RESULT.
116
117 2019-03-05  Tom Tromey  <tromey@adacore.com>
118
119         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
120         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
121         ATTRIBUTE_UNUSED_RESULT.
122
123 2019-03-05  Tom Tromey  <tromey@adacore.com>
124
125         * common/scoped_fd.h (class scoped_fd) <release>: Add
126         ATTRIBUTE_UNUSED_RESULT.
127
128 2019-03-05  Tom Tromey  <tromey@adacore.com>
129
130         * parser-defs.h (struct parser_state) <release>: Add
131         ATTRIBUTE_UNUSED_RESULT.
132
133 2019-03-05  Tom Tromey  <tromey@adacore.com>
134
135         * utils.h (class gdb_argv) <release>: Add
136         ATTRIBUTE_UNUSED_RESULT.
137         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
138
139 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
140
141         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
142         for-loop range, to avoid compiler warnings.
143
144         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
145         avoid compiler warnings about unused variables.
146
147         * NEWS: Mention end of support for native debugging on MS-Windows
148         before XP.
149
150         PR gdb/24292
151         * common/netstuff.c:
152         * gdbserver/gdbreplay.c
153         * gdbserver/remote-utils.c:
154         * ser-tcp.c:
155         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
156         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
157         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
158         'getaddrinfo' and 'freeaddrinfo' were not available before
159         Windows XP, and mingw.org's MinGW headers by default define
160         _WIN32_WINNT to 0x500.
161
162 2019-03-01  Gary Benson <gbenson@redhat.com>
163
164         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
165
166 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
167             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
168
169         PR gdb/8527
170         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
171         set_sigint_trap, clear_sigint_trap.
172
173 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
174
175         * target.c (target_detach): Clear the regcache and the
176         frame cache.
177
178 2019-02-27  Pedro Alves  <palves@redhat.com>
179
180         * utils.c (set_screen_size): When we cap the height/width sizes,
181         tweak the corresponding command variable to show "unlimited":
182
183 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
184             Pedro Alves  <palves@redhat.com>
185
186         * utils.c (set_screen_size): Reduce "infinite" rows and columns
187         before calling rl_set_screen_size.
188
189 2019-02-27  Tom Tromey  <tromey@adacore.com>
190
191         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
192         define.
193         * python/py-value.c: Remove Python 2.4 workaround.
194         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
195         workaround.
196         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
197         Python 2.4 workaround.
198         * python/python-internal.h: Remove Python 2.4 comment.
199         (Py_ssize_t): Don't define.
200         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
201         (gdb_Py_DECREF): Remove Python 2.4 workaround.
202         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
203         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
204         * python/python.c (do_start_initialization): Remove Python 2.4
205         workaround.
206         * python/py-prettyprint.c (class dummy_python_frame): Remove.
207         (print_children): Remove Python 2.4 workaround.
208         * python/py-inferior.c (buffer_procs): Remove Python 2.4
209         workaround.
210         (CHARBUFFERPROC_NAME): Remove.
211         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
212         Python 2.4 workaround.
213
214 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
215
216         * NEWS: Note minimum Python version.
217
218 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
219
220         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
221         code from these functions.  Remove corresponding ifdefs.  Use
222         Py_buffer_up instead of explicit calls to PyBuffer_Release.
223         Remove gotos and target of gotos.
224         (infpy_search_memory): Likewise.
225
226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
227
228         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
229         (hppa_gdbarch_init): Don't register deleted functions with
230         gdbarch.
231
232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
233
234         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
235         (h8300_unwind_sp): Delete.
236         (h8300_dummy_id): Delete.
237         (h8300_gdbarch_init): Don't register deleted functions with
238         gdbarch.
239
240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
241
242         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
243         (ft32_unwind_pc): Delete.
244         (ft32_unwind_sp): Delete.
245         (ft32_gdbarch_init): Don't register deleted functions with
246         gdbarch.
247
248 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
249
250         * gdb/frv-tdep.c (frv_dummy_id): Delete.
251         (frv_unwind_pc): Delete.
252         (frv_unwind_sp): Delete.
253         (frv_gdbarch_init): Don't register deleted functions with
254         gdbarch.
255
256 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
257
258         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
259         (riscv_unwind_pc): Delete.
260         (riscv_unwind_sp): Delete.
261         (riscv_gdbarch_init): Don't register deleted functions with
262         gdbarch.
263
264 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
265
266         * gdb/csky-tdep.c (csky_dummy_id): Delete.
267         (csky_unwind_pc): Delete.
268         (csky_unwind_sp): Delete.
269         (csky_gdbarch_init): Don't register deleted functions with
270         gdbarch.
271
272 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
273
274         * gdb/cris-tdep.c (cris_dummy_id): Delete.
275         (cris_unwind_pc): Delete.
276         (cris_unwind_sp): Delete.
277         (cris_gdbarch_init): Don't register deleted functions with
278         gdbarch.
279
280 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
281
282         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
283         (bfin_unwind_pc): Delete.
284         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
285
286 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
287
288         * gdb/arm-tdep.c (arm_dummy_id): Delete.
289         (arm_unwind_pc): Delete.
290         (arm_unwind_sp): Delete.
291         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
292
293 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
294
295         * gdb/arc-tdep.c (arc_dummy_id): Delete.
296         (arc_unwind_pc): Delete.
297         (arc_unwind_sp): Delete.
298         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
299
300 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
301
302         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
303         (alpha_unwind_pc): Delete.
304         (alpha_gdbarch_init): Don't register deleted functions with
305         gdbarch.
306
307 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
308
309         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
310         (aarch64_unwind_pc): Delete.
311         (aarch64_unwind_sp): Delete.
312         (aarch64_gdbarch_init): Don't register deleted functions with
313         gdbarch.
314
315 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
316
317         * gdbtypes.c (type_align): Don't consider static members when
318         computing structure alignment.
319
320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
321
322         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
323         return 0 for other types.
324         * arch-utils.c (default_type_align): Always return 0.
325         * gdbarch.h: Regenerate.
326         * gdbarch.sh (type_align): Extend comment.
327         * gdbtypes.c (type_align): Add additional comments, always call
328         gdbarch_type_align before applying the default rules.
329         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
330         generic code will then apply a suitable default.
331         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
332         types, return 0 for other types.
333
334 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
335
336         * NEWS: Create a new section for the next release branch.
337         Rename the section of the current branch, now that it has
338         been cut.
339
340 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
341
342         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
343         * version.in: Bump version to 8.3.50.DATE-git.
344
345 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
346
347         * aix-thread.c (ptid_cmp): Remove unused variable.
348         (get_signaled_thread): Likewise.
349         (store_regs_user_thread): Likewise.
350         (store_regs_kernel_thread): Likewise.
351         (fetch_regs_kernel_thread): Remove shadowed variable.
352
353 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
354
355         * features/riscv/32bit-cpu.xml: Add register numbers.
356         * features/riscv/32bit-fpu.c: Regenerate.
357         * features/riscv/32bit-fpu.xml: Add register numbers.
358         * features/riscv/64bit-cpu.xml: Add register numbers.
359         * features/riscv/64bit-fpu.c: Regenerate.
360         * features/riscv/64bit-fpu.xml: Add register numbers.
361
362 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
363
364         * NEWS: Mention two argument form of gdb.Value constructor.
365         * python/py-value.c (convert_buffer_and_type_to_value): New
366         function.
367         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
368         Add support for handling an optional second argument.  Call
369         convert_buffer_and_type_to_value as appropriate.
370         * python/python-internal.h (Py_buffer_deleter): New struct.
371         (Py_buffer_up): New typedef.
372
373 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
374
375         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
376         instead of releasing ownership.
377
378 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
379
380         * dwarf2read.c (open_and_init_dwp_file): Call
381         elf_numsections instead of bfd_count_sections to initialize
382         dwp_file->num_sections.
383
384 2019-02-25  Tom Tromey  <tromey@adacore.com>
385
386         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
387
388 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
389
390         * gcore.in: Add '--readnever' option when invoking GDB.
391
392 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
393
394         * MAINTAINERS: Update my email address.
395
396 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
397
398         * build-id.c (build_id_to_debug_bfd_1): New function.
399         (build_id_to_debug_bfd): Look for separate debug file in
400         sysroot.
401
402 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
403
404         * gdbarch.sh: Update the copyright year range that is placed into
405         generated files.
406
407 2019-02-22  Keith Seitz  <keiths@redhat.com>
408
409         PR symtab/23853
410         * linespec.c (create_sals_line_offset): Search for the default
411         symtab's filename instead of its fullname.
412
413 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
414
415         * NEWS: Update style defaults.
416
417 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
418
419         * main.c (captured_main_1): Disable styling in batch mode.
420
421 2019-02-20  Tom Tromey  <tom@tromey.com>
422
423         * symtab.c (symtab_symbol_info): Fix typos.
424
425 2019-02-20  Tom Tromey  <tromey@adacore.com>
426
427         * findcmd.c (_initialize_mem_search): Use upper case for
428         metasyntactic variables.
429
430 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
431
432         * aarch64-tdep.c (aarch64_add_reggroups): New function.
433         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
434
435 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
436
437         * top.h (source_file_name): Change to std::string.
438         * top.c (source_file_name): Likewise.
439         (command_line_input): Adjust.
440         * cli/cli-script.c (script_from_file): Adjust.
441
442 2019-02-19  Tom Tromey  <tromey@adacore.com>
443
444         * ravenscar-thread.c
445         (ravenscar_thread_target::update_thread_list): Don't call
446         ada_build_task_list.
447         * ada-lang.h (ada_build_task_list): Don't declare.
448         * ada-tasks.c (struct ada_tasks_inferior_data)
449         <task_list_valid_p>: Now bool.
450         (read_known_tasks, ada_task_list_changed)
451         (ada_tasks_invalidate_inferior_data): Update.
452         (read_known_tasks_array): Return bool.
453         (read_known_tasks_list): Likewise.
454         (read_known_tasks): Return void.
455         (ada_build_task_list): Now static.
456
457 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
458
459         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
460         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
461
462 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
463
464         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
465         variant for ada_tasks_pspace_data_handle and
466         ada_tasks_inferior_data_handle.
467         (ada_tasks_pspace_data_cleanup): New function.
468         (ada_tasks_inferior_data_cleanup): New function.
469
470 2019-02-17  Tom Tromey  <tom@tromey.com>
471
472         * macrotab.h (macro_source_fullname): Return a std::string.
473         * macrotab.c (macro_include, check_for_redefinition)
474         (macro_undef, macro_lookup_definition, foreach_macro)
475         (foreach_macro_in_scope): Update.
476         (macro_source_fullname): Return a std::string.
477         * macrocmd.c (show_pp_source_pos): Update.
478
479 2019-02-17  Tom Tromey  <tom@tromey.com>
480
481         * macrocmd.c (show_pp_source_pos): Style the file names.
482
483 2019-02-17  Tom Tromey  <tom@tromey.com>
484
485         PR tui/24197:
486         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
487
488 2019-02-17  Tom Tromey  <tom@tromey.com>
489
490         * ada-lang.c (user_select_syms): Use filtered printing.
491         * utils.c (wrap_style): New global.
492         (desired_style): Remove.
493         (emit_style_escape): Add stream parameter.
494         (set_output_style, reset_terminal_style, prompt_for_continue):
495         Update.
496         (flush_wrap_buffer): Only flush gdb_stdout.
497         (wrap_here): Set wrap_style.
498         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
499         treat escape sequences as a character.  Change when wrap buffer is
500         flushed.
501         (fputs_styled): Do not set the output style when the default is
502         requested.
503         * ui-style.h (struct ui_file_style) <is_default>: New method.
504         * source.c (print_source_lines_base): Emit escape sequences in one
505         piece.
506
507 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
508
509         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
510         integers and enumeration types.
511
512 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
513
514         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
515         instead of lookup_symbol_in_language
516         (do_exact_match): New function.
517         (ada_get_symbol_name_matcher): Return do_exact_match when
518         doing a verbatim match.
519
520 2019-02-15  Tom Tromey  <tromey@adacore.com>
521
522         * ravenscar-thread.c (ravenscar_thread_target::resume)
523         (ravenscar_thread_target::wait): Special case wildcard requests.
524
525 2019-02-15  Tom Tromey  <tromey@adacore.com>
526
527         * ravenscar-thread.c (base_ptid): Remove.
528         (struct ravenscar_thread_target) <close>: New method.
529         <m_base_ptid>: New member.
530         <update_inferior_ptid, active_task, task_is_currently_active,
531         runtime_initialized>: Declare methods.
532         <ravenscar_thread_target>: Add constructor.
533         (ravenscar_thread_target::task_is_currently_active)
534         (ravenscar_thread_target::update_inferior_ptid)
535         (ravenscar_runtime_initialized): Rename.  Now methods.
536         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
537         (ravenscar_thread_target::update_thread_list): Update.
538         (ravenscar_thread_target::active_task): Now method.
539         (ravenscar_thread_target::store_registers)
540         (ravenscar_thread_target::prepare_to_store)
541         (ravenscar_thread_target::prepare_to_store)
542         (ravenscar_thread_target::mourn_inferior): Update.
543         (ravenscar_inferior_created): Use "new" to create target.
544         (ravenscar_thread_target::get_ada_task_ptid): Update.
545         (_initialize_ravenscar): Don't initialize base_ptid.
546         (ravenscar_ops): Remove global.
547
548 2019-02-15  Tom Tromey  <tromey@adacore.com>
549
550         * target.h (push_target): Declare new overload.
551         * target.c (push_target): New overload, taking an rvalue reference.
552         * remote.c (remote_target::open_1): Use push_target overload.
553         * corelow.c (core_target_open): Use push_target overload.
554
555 2019-02-15  Tom Tromey  <tromey@adacore.com>
556
557         * ravenscar-thread.c (is_ravenscar_task)
558         (ravenscar_task_is_currently_active): Return bool.
559         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
560         (_initialize_ravenscar): Remove "(void)".
561         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
562         Return bool.
563
564 2019-02-15  Tom Tromey  <tromey@adacore.com>
565
566         * ravenscar-thread.c (ravenscar_runtime_initializer)
567         (has_ravenscar_runtime, get_running_thread_id)
568         (ravenscar_thread_target::resume): Fix indentation.
569
570 2019-02-15  Tom Tromey  <tromey@adacore.com>
571
572         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
573         from ravenscar_arch_ops.
574         (sparc_ravenscar_ops::fetch_registers)
575         (sparc_ravenscar_ops::store_registers): Now methods.
576         (sparc_ravenscar_prepare_to_store): Remove.
577         (sparc_ravenscar_ops): Redefine.
578         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
579         methods and destructor.  Remove members.
580         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
581         (ravenscar_thread_target::store_registers)
582         (ravenscar_thread_target::prepare_to_store): Update.
583         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
584         Remove.
585         (struct ppc_ravenscar_powerpc_ops): Derive from
586         ravenscar_arch_ops.
587         (ppc_ravenscar_powerpc_ops::fetch_registers)
588         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
589         (ppc_ravenscar_powerpc_ops): Redefine.
590         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
591         (ppc_ravenscar_e500_ops::fetch_registers)
592         (ppc_ravenscar_e500_ops::store_registers): Now methods.
593         (ppc_ravenscar_e500_ops): Redefine.
594         * aarch64-ravenscar-thread.c
595         (aarch64_ravenscar_generic_prepare_to_store): Remove.
596         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
597         (aarch64_ravenscar_fetch_registers)
598         (aarch64_ravenscar_store_registers): Now methods.
599         (aarch64_ravenscar_ops): Redefine.
600
601 2019-02-15  Tom Tromey  <tromey@adacore.com>
602
603         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
604         (ravenscar_thread_target::stopped_by_hw_breakpoint)
605         (ravenscar_thread_target::stopped_by_watchpoint)
606         (ravenscar_thread_target::stopped_data_address)
607         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
608
609 2019-02-15  Tom Tromey  <tromey@adacore.com>
610
611         * ravenscar-thread.c: Fix some typos.
612
613 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
614             Tom Tromey  <tromey@adacore.com>
615
616         * ada-lang.c (ada_exception_sal): Change addr_string to a
617         std::string.
618         (create_ada_exception_catchpoint): Update.
619
620 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
621             Tom Tromey  <tromey@adacore.com>
622
623         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
624         (bp_location_ops): Remove.
625         (base_breakpoint_allocate_location): Update.
626         (free_bp_location): Update.
627         * ada-lang.c (class ada_catchpoint_location)
628         <ada_catchpoint_location>: Remove ops parameter.
629         (ada_catchpoint_location_dtor): Remove.
630         (ada_catchpoint_location_ops): Remove.
631         (allocate_location_exception): Update.
632         * breakpoint.h (struct bp_location_ops): Remove.
633         (class bp_location) <bp_location>: Remove bp_location_ops
634         parameter.
635         <~bp_location>: Add destructor.
636         <ops>: Remove.
637
638 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
639             Pedro Alves  <palves@redhat.com>
640
641         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
642         'PATH_MAX'.
643
644 2019-02-14  David Michael  <fedora.dm0@gmail.com>
645             Samuel Thibault  <samuel.thibault@gnu.org>
646             Thomas Schwinge  <thomas@codesourcery.com>
647
648         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
649         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
650
651 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
652
653         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
654         (check_empty): Use "const char *".
655
656         * gnu-nat.c (gnu_nat_target::detach): Instead of
657         'detach_inferior (pid)' call
658         'detach_inferior (find_inferior_pid (pid))'.
659
660         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
661         'nat/fork-inferior.o'.
662         * gnu-nat.c: #include "nat/fork-inferior.h".
663
664         * gnu-nat.c (gnu_nat_target::detach): Instead of
665         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
666         * gnu-nat.h: #include "inf-child.h".
667         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
668         'i386_gnu_nat_target::fetch_registers'.
669         (gnu_store_registers): Rename/move to
670         'i386_gnu_nat_target::store_registers'.
671
672         * config/i386/nm-i386gnu.h: Don't "#include" any files.
673         * gnu-nat.h (mach_thread_info): New function.
674         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
675
676         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
677
678 2019-02-14  Frederic Konrad  <konrad@adacore.com>
679
680         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
681
682 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
683
684         * windows-nat.c (windows_add_thread): Add new parameter
685         "main_thread_p" with default value set to false.  Update
686         function documentation as well as all callers.
687         (windows_delete_thread): Likewise.
688         (fake_create_process): Update call to windows_add_thread.
689         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
690         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
691         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
692         call to windows_delete_thread.
693
694 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
695
696         * MAINTAINERS: Add Andrew Burgess as global maintainer.
697
698 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
699
700         * symfile.c (find_separate_debug_file): Use canonical path of
701         sysroot with child_path instead of gdb_sysroot if it is valid.
702
703 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
704
705         * symfile.c (find_separate_debug_file): Use child_path to
706         determine if an object file is under a sysroot.
707
708 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
709
710         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
711         unittests/child-path-selftests.c.
712         * common/pathstuff.c (child_path): New function.
713         * common/pathstuff.h (child_path): New prototype.
714         * unittests/child-path-selftests.c: New file.
715
716 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
717
718         * symfile.c (find_separate_debug_file): Look for separate debug
719         files in debug directories under the sysroot.
720
721 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
722
723         * symtab.h (struct minimal_symbol data_p): New const method.
724         (struct minimal_symbol text_p): Likewise.
725         * symtab.c (output_source_filename): Use file name style
726         to print file name.
727         (print_symbol_info): Likewise.
728         (print_msymbol_info): Use address style to print addresses.
729         Use function name style to print executable text symbols.
730         (expand_symtab_containing_pc): Use data_p.
731         (find_pc_sect_compunit_symtab): Likewise.
732
733 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
734
735         * breakpoint.c (describe_other_breakpoints): Use address style
736         to print addresses.
737         (say_where): Likewise.
738
739 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
740
741         * ada-typeprint.c (print_func_type): Print function name
742         style to print function name.
743         * c-typeprint.c (c_print_type_1): Likewise.
744
745 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
746
747         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
748         for execve.
749
750 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
751
752         * c-exp.y (direct_abs_decl): Use emplace_back to record the
753         type_stack.
754
755 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
756
757         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
758         TYPE_CODE_REF types.
759
760 2019-02-08  Jim Wilson  <jimw@sifive.com>
761
762         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
763         (riscv_linux_fregset): New.
764         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
765
766 2019-02-07  Tom Tromey  <tom@tromey.com>
767
768         * thread.c (thread_cancel_execution_command): Update.
769         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
770         methods.
771         (struct thread_fsm_ops): Remove.
772         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
773         (thread_fsm_should_stop, thread_fsm_return_value)
774         (thread_fsm_set_finished, thread_fsm_finished_p)
775         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
776         Don't declare.
777         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
778         * infrun.c (clear_proceed_status_thread)
779         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
780         (print_stop_event): Update.
781         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
782         Add constructor.
783         (step_command_fsm_ops): Remove.
784         (new_step_command_fsm): Remove.
785         (step_1): Update.
786         (step_command_fsm::should_stop): Rename from
787         step_command_fsm_should_stop.
788         (step_command_fsm::clean_up): Rename from
789         step_command_fsm_clean_up.
790         (step_command_fsm::do_async_reply_reason): Rename from
791         step_command_fsm_async_reply_reason.
792         (struct until_next_fsm): Inherit from thread_fsm.  Add
793         constructor.
794         (until_next_fsm_ops): Remove.
795         (new_until_next_fsm): Remove.
796         (until_next_fsm::should_stop): Rename from
797         until_next_fsm_should_stop.
798         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
799         (until_next_fsm::do_async_reply_reason): Rename from
800         until_next_fsm_async_reply_reason.
801         (struct finish_command_fsm): Inherit from thread_fsm.  Add
802         constructor.  Change type of breakpoint.
803         (finish_command_fsm_ops): Remove.
804         (new_finish_command_fsm): Remove.
805         (finish_command_fsm::should_stop): Rename from
806         finish_command_fsm_should_stop.
807         (finish_command_fsm::clean_up): Rename from
808         finish_command_fsm_clean_up.
809         (finish_command_fsm::return_value): Rename from
810         finish_command_fsm_return_value.
811         (finish_command_fsm::do_async_reply_reason): Rename from
812         finish_command_fsm_async_reply_reason.
813         (finish_command): Update.
814         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
815         Add constructor.
816         (call_thread_fsm_ops): Remove.
817         (call_thread_fsm::call_thread_fsm): Rename from
818         new_call_thread_fsm.
819         (call_thread_fsm::should_stop): Rename from
820         call_thread_fsm_should_stop.
821         (call_thread_fsm::should_notify_stop): Rename from
822         call_thread_fsm_should_notify_stop.
823         (run_inferior_call, call_function_by_hand_dummy): Update.
824         * cli/cli-interp.c (should_print_stop_to_console): Update.
825         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
826         Add constructor.  Change type of location_breakpoint,
827         caller_breakpoint.
828         (until_break_fsm_ops): Remove.
829         (new_until_break_fsm): Remove.
830         (until_break_fsm::should_stop): Rename from
831         until_break_fsm_should_stop.
832         (until_break_fsm::clean_up): Rename from
833         until_break_fsm_clean_up.
834         (until_break_fsm::do_async_reply_reason): Rename from
835         until_break_fsm_async_reply_reason.
836         (until_break_command): Update.
837         * thread-fsm.c: Remove.
838         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
839
840 2019-02-07  Tom Tromey  <tom@tromey.com>
841
842         * yy-remap.h: Add include guard.
843         * xtensa-tdep.h: Add include guard.
844         * xcoffread.h: Rename include guard.
845         * varobj-iter.h: Add include guard.
846         * tui/tui.h: Rename include guard.
847         * tui/tui-winsource.h: Rename include guard.
848         * tui/tui-wingeneral.h: Rename include guard.
849         * tui/tui-windata.h: Rename include guard.
850         * tui/tui-win.h: Rename include guard.
851         * tui/tui-stack.h: Rename include guard.
852         * tui/tui-source.h: Rename include guard.
853         * tui/tui-regs.h: Rename include guard.
854         * tui/tui-out.h: Rename include guard.
855         * tui/tui-layout.h: Rename include guard.
856         * tui/tui-io.h: Rename include guard.
857         * tui/tui-hooks.h: Rename include guard.
858         * tui/tui-file.h: Rename include guard.
859         * tui/tui-disasm.h: Rename include guard.
860         * tui/tui-data.h: Rename include guard.
861         * tui/tui-command.h: Rename include guard.
862         * tic6x-tdep.h: Add include guard.
863         * target/waitstatus.h: Rename include guard.
864         * target/wait.h: Rename include guard.
865         * target/target.h: Rename include guard.
866         * target/resume.h: Rename include guard.
867         * target-float.h: Rename include guard.
868         * stabsread.h: Add include guard.
869         * rs6000-tdep.h: Add include guard.
870         * riscv-fbsd-tdep.h: Add include guard.
871         * regformats/regdef.h: Rename include guard.
872         * record.h: Rename include guard.
873         * python/python.h: Rename include guard.
874         * python/python-internal.h: Rename include guard.
875         * python/py-stopevent.h: Rename include guard.
876         * python/py-ref.h: Rename include guard.
877         * python/py-record.h: Rename include guard.
878         * python/py-record-full.h: Rename include guard.
879         * python/py-record-btrace.h: Rename include guard.
880         * python/py-instruction.h: Rename include guard.
881         * python/py-events.h: Rename include guard.
882         * python/py-event.h: Rename include guard.
883         * procfs.h: Add include guard.
884         * proc-utils.h: Add include guard.
885         * p-lang.h: Add include guard.
886         * or1k-tdep.h: Rename include guard.
887         * observable.h: Rename include guard.
888         * nto-tdep.h: Rename include guard.
889         * nat/x86-linux.h: Rename include guard.
890         * nat/x86-linux-dregs.h: Rename include guard.
891         * nat/x86-gcc-cpuid.h: Add include guard.
892         * nat/x86-dregs.h: Rename include guard.
893         * nat/x86-cpuid.h: Rename include guard.
894         * nat/ppc-linux.h: Rename include guard.
895         * nat/mips-linux-watch.h: Rename include guard.
896         * nat/linux-waitpid.h: Rename include guard.
897         * nat/linux-ptrace.h: Rename include guard.
898         * nat/linux-procfs.h: Rename include guard.
899         * nat/linux-osdata.h: Rename include guard.
900         * nat/linux-nat.h: Rename include guard.
901         * nat/linux-namespaces.h: Rename include guard.
902         * nat/linux-btrace.h: Rename include guard.
903         * nat/glibc_thread_db.h: Rename include guard.
904         * nat/gdb_thread_db.h: Rename include guard.
905         * nat/gdb_ptrace.h: Rename include guard.
906         * nat/fork-inferior.h: Rename include guard.
907         * nat/amd64-linux-siginfo.h: Rename include guard.
908         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
909         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
910         * nat/aarch64-linux.h: Rename include guard.
911         * nat/aarch64-linux-hw-point.h: Rename include guard.
912         * mn10300-tdep.h: Add include guard.
913         * mips-linux-tdep.h: Add include guard.
914         * mi/mi-parse.h: Rename include guard.
915         * mi/mi-out.h: Rename include guard.
916         * mi/mi-main.h: Rename include guard.
917         * mi/mi-interp.h: Rename include guard.
918         * mi/mi-getopt.h: Rename include guard.
919         * mi/mi-console.h: Rename include guard.
920         * mi/mi-common.h: Rename include guard.
921         * mi/mi-cmds.h: Rename include guard.
922         * mi/mi-cmd-break.h: Rename include guard.
923         * m2-lang.h: Add include guard.
924         * location.h: Rename include guard.
925         * linux-record.h: Rename include guard.
926         * linux-nat.h: Add include guard.
927         * linux-fork.h: Add include guard.
928         * i386-darwin-tdep.h: Rename include guard.
929         * hppa-linux-offsets.h: Add include guard.
930         * guile/guile.h: Rename include guard.
931         * guile/guile-internal.h: Rename include guard.
932         * gnu-nat.h: Rename include guard.
933         * gdb-stabs.h: Rename include guard.
934         * frv-tdep.h: Add include guard.
935         * f-lang.h: Add include guard.
936         * event-loop.h: Add include guard.
937         * darwin-nat.h: Rename include guard.
938         * cp-abi.h: Rename include guard.
939         * config/sparc/nm-sol2.h: Rename include guard.
940         * config/nm-nto.h: Rename include guard.
941         * config/nm-linux.h: Add include guard.
942         * config/i386/nm-i386gnu.h: Rename include guard.
943         * config/djgpp/nl_types.h: Rename include guard.
944         * config/djgpp/langinfo.h: Rename include guard.
945         * compile/gcc-cp-plugin.h: Add include guard.
946         * compile/gcc-c-plugin.h: Add include guard.
947         * compile/compile.h: Rename include guard.
948         * compile/compile-object-run.h: Rename include guard.
949         * compile/compile-object-load.h: Rename include guard.
950         * compile/compile-internal.h: Rename include guard.
951         * compile/compile-cplus.h: Rename include guard.
952         * compile/compile-c.h: Rename include guard.
953         * common/xml-utils.h: Rename include guard.
954         * common/x86-xstate.h: Rename include guard.
955         * common/version.h: Rename include guard.
956         * common/vec.h: Rename include guard.
957         * common/tdesc.h: Rename include guard.
958         * common/selftest.h: Rename include guard.
959         * common/scoped_restore.h: Rename include guard.
960         * common/scoped_mmap.h: Rename include guard.
961         * common/scoped_fd.h: Rename include guard.
962         * common/safe-iterator.h: Rename include guard.
963         * common/run-time-clock.h: Rename include guard.
964         * common/refcounted-object.h: Rename include guard.
965         * common/queue.h: Rename include guard.
966         * common/ptid.h: Rename include guard.
967         * common/print-utils.h: Rename include guard.
968         * common/preprocessor.h: Rename include guard.
969         * common/pathstuff.h: Rename include guard.
970         * common/observable.h: Rename include guard.
971         * common/netstuff.h: Rename include guard.
972         * common/job-control.h: Rename include guard.
973         * common/host-defs.h: Rename include guard.
974         * common/gdb_wait.h: Rename include guard.
975         * common/gdb_vecs.h: Rename include guard.
976         * common/gdb_unlinker.h: Rename include guard.
977         * common/gdb_unique_ptr.h: Rename include guard.
978         * common/gdb_tilde_expand.h: Rename include guard.
979         * common/gdb_sys_time.h: Rename include guard.
980         * common/gdb_string_view.h: Rename include guard.
981         * common/gdb_splay_tree.h: Rename include guard.
982         * common/gdb_setjmp.h: Rename include guard.
983         * common/gdb_ref_ptr.h: Rename include guard.
984         * common/gdb_optional.h: Rename include guard.
985         * common/gdb_locale.h: Rename include guard.
986         * common/gdb_assert.h: Rename include guard.
987         * common/filtered-iterator.h: Rename include guard.
988         * common/filestuff.h: Rename include guard.
989         * common/fileio.h: Rename include guard.
990         * common/environ.h: Rename include guard.
991         * common/common-utils.h: Rename include guard.
992         * common/common-types.h: Rename include guard.
993         * common/common-regcache.h: Rename include guard.
994         * common/common-inferior.h: Rename include guard.
995         * common/common-gdbthread.h: Rename include guard.
996         * common/common-exceptions.h: Rename include guard.
997         * common/common-defs.h: Rename include guard.
998         * common/common-debug.h: Rename include guard.
999         * common/cleanups.h: Rename include guard.
1000         * common/buffer.h: Rename include guard.
1001         * common/btrace-common.h: Rename include guard.
1002         * common/break-common.h: Rename include guard.
1003         * cli/cli-utils.h: Rename include guard.
1004         * cli/cli-style.h: Rename include guard.
1005         * cli/cli-setshow.h: Rename include guard.
1006         * cli/cli-script.h: Rename include guard.
1007         * cli/cli-interp.h: Rename include guard.
1008         * cli/cli-decode.h: Rename include guard.
1009         * cli/cli-cmds.h: Rename include guard.
1010         * charset-list.h: Add include guard.
1011         * buildsym-legacy.h: Rename include guard.
1012         * bfin-tdep.h: Add include guard.
1013         * ax.h: Rename include guard.
1014         * arm-linux-tdep.h: Add include guard.
1015         * arm-fbsd-tdep.h: Add include guard.
1016         * arch/xtensa.h: Rename include guard.
1017         * arch/tic6x.h: Add include guard.
1018         * arch/i386.h: Add include guard.
1019         * arch/arm.h: Rename include guard.
1020         * arch/arm-linux.h: Rename include guard.
1021         * arch/arm-get-next-pcs.h: Rename include guard.
1022         * arch/amd64.h: Add include guard.
1023         * arch/aarch64-insn.h: Rename include guard.
1024         * arch-utils.h: Rename include guard.
1025         * annotate.h: Add include guard.
1026         * amd64-darwin-tdep.h: Rename include guard.
1027         * aarch64-linux-tdep.h: Add include guard.
1028         * aarch64-fbsd-tdep.h: Add include guard.
1029         * aarch32-linux-nat.h: Add include guard.
1030
1031 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1032
1033         * macrotab.c (macro_define_internal): New function that
1034         factorizes macro_define_object_internal and macro_define_function
1035         code.
1036         (macro_define_object_internal): Use macro_define_internal.
1037         (macro_define_function): Likewise.
1038
1039 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1040
1041         * macrocmd.c (extract_identifier): Return
1042         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1043         callers.
1044
1045 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1046
1047         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1048
1049 2019-02-05  Tom Tromey  <tom@tromey.com>
1050
1051         * target.c (target_stack::unpush): Move assertion earlier.
1052
1053 2019-01-30  Tom Tromey  <tom@tromey.com>
1054
1055         PR python/23615:
1056         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1057         (gdbpy_parse_and_eval): Likewise.
1058         * python/python-internal.h (gdbpy_allow_threads): New class.
1059
1060 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1061
1062         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1063         (aarch64_fbsd_fpregmap): Move earlier.
1064         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1065         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1066         instead of individual calls to trad_frame_set_reg_addr.
1067         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1068         earlier.
1069         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1070         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1071         instead of individual calls to trad_frame_set_reg_addr.
1072
1073 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1074
1075         * CONTRIBUTE: Replace contribution list with wiki link.
1076
1077 2019-01-25  Tom Tromey  <tom@tromey.com>
1078
1079         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1080
1081 2019-01-25  Tom Tromey  <tom@tromey.com>
1082
1083         * xtensa-linux-nat.c: Fix common/ includes.
1084         * xml-support.h: Fix common/ includes.
1085         * xml-support.c: Fix common/ includes.
1086         * x86-linux-nat.c: Fix common/ includes.
1087         * windows-nat.c: Fix common/ includes.
1088         * varobj.h: Fix common/ includes.
1089         * varobj.c: Fix common/ includes.
1090         * value.c: Fix common/ includes.
1091         * valops.c: Fix common/ includes.
1092         * utils.c: Fix common/ includes.
1093         * unittests/xml-utils-selftests.c: Fix common/ includes.
1094         * unittests/utils-selftests.c: Fix common/ includes.
1095         * unittests/unpack-selftests.c: Fix common/ includes.
1096         * unittests/tracepoint-selftests.c: Fix common/ includes.
1097         * unittests/style-selftests.c: Fix common/ includes.
1098         * unittests/string_view-selftests.c: Fix common/ includes.
1099         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1100         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1101         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1102         * unittests/rsp-low-selftests.c: Fix common/ includes.
1103         * unittests/parse-connection-spec-selftests.c: Fix common/
1104         includes.
1105         * unittests/optional-selftests.c: Fix common/ includes.
1106         * unittests/offset-type-selftests.c: Fix common/ includes.
1107         * unittests/observable-selftests.c: Fix common/ includes.
1108         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1109         * unittests/memrange-selftests.c: Fix common/ includes.
1110         * unittests/memory-map-selftests.c: Fix common/ includes.
1111         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1112         * unittests/function-view-selftests.c: Fix common/ includes.
1113         * unittests/environ-selftests.c: Fix common/ includes.
1114         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1115         * unittests/common-utils-selftests.c: Fix common/ includes.
1116         * unittests/cli-utils-selftests.c: Fix common/ includes.
1117         * unittests/array-view-selftests.c: Fix common/ includes.
1118         * ui-file.c: Fix common/ includes.
1119         * tui/tui-io.c: Fix common/ includes.
1120         * tracepoint.h: Fix common/ includes.
1121         * tracepoint.c: Fix common/ includes.
1122         * tracefile-tfile.c: Fix common/ includes.
1123         * top.h: Fix common/ includes.
1124         * top.c: Fix common/ includes.
1125         * thread.c: Fix common/ includes.
1126         * target/waitstatus.h: Fix common/ includes.
1127         * target/waitstatus.c: Fix common/ includes.
1128         * target.h: Fix common/ includes.
1129         * target.c: Fix common/ includes.
1130         * target-memory.c: Fix common/ includes.
1131         * target-descriptions.c: Fix common/ includes.
1132         * symtab.h: Fix common/ includes.
1133         * symfile.c: Fix common/ includes.
1134         * stap-probe.c: Fix common/ includes.
1135         * spu-linux-nat.c: Fix common/ includes.
1136         * sparc-nat.c: Fix common/ includes.
1137         * source.c: Fix common/ includes.
1138         * solib.c: Fix common/ includes.
1139         * solib-target.c: Fix common/ includes.
1140         * ser-unix.c: Fix common/ includes.
1141         * ser-tcp.c: Fix common/ includes.
1142         * ser-pipe.c: Fix common/ includes.
1143         * ser-base.c: Fix common/ includes.
1144         * selftest-arch.c: Fix common/ includes.
1145         * s12z-tdep.c: Fix common/ includes.
1146         * rust-exp.y: Fix common/ includes.
1147         * rs6000-aix-tdep.c: Fix common/ includes.
1148         * riscv-tdep.c: Fix common/ includes.
1149         * remote.c: Fix common/ includes.
1150         * remote-notif.h: Fix common/ includes.
1151         * remote-fileio.h: Fix common/ includes.
1152         * remote-fileio.c: Fix common/ includes.
1153         * regcache.h: Fix common/ includes.
1154         * regcache.c: Fix common/ includes.
1155         * record-btrace.c: Fix common/ includes.
1156         * python/python.c: Fix common/ includes.
1157         * python/py-type.c: Fix common/ includes.
1158         * python/py-inferior.c: Fix common/ includes.
1159         * progspace.h: Fix common/ includes.
1160         * producer.c: Fix common/ includes.
1161         * procfs.c: Fix common/ includes.
1162         * proc-api.c: Fix common/ includes.
1163         * printcmd.c: Fix common/ includes.
1164         * ppc-linux-nat.c: Fix common/ includes.
1165         * parser-defs.h: Fix common/ includes.
1166         * osdata.c: Fix common/ includes.
1167         * obsd-nat.c: Fix common/ includes.
1168         * nat/x86-linux.c: Fix common/ includes.
1169         * nat/x86-linux-dregs.c: Fix common/ includes.
1170         * nat/x86-dregs.h: Fix common/ includes.
1171         * nat/x86-dregs.c: Fix common/ includes.
1172         * nat/ppc-linux.c: Fix common/ includes.
1173         * nat/mips-linux-watch.h: Fix common/ includes.
1174         * nat/mips-linux-watch.c: Fix common/ includes.
1175         * nat/linux-waitpid.c: Fix common/ includes.
1176         * nat/linux-ptrace.h: Fix common/ includes.
1177         * nat/linux-ptrace.c: Fix common/ includes.
1178         * nat/linux-procfs.c: Fix common/ includes.
1179         * nat/linux-personality.c: Fix common/ includes.
1180         * nat/linux-osdata.c: Fix common/ includes.
1181         * nat/linux-namespaces.c: Fix common/ includes.
1182         * nat/linux-btrace.h: Fix common/ includes.
1183         * nat/linux-btrace.c: Fix common/ includes.
1184         * nat/fork-inferior.c: Fix common/ includes.
1185         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1186         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1187         * nat/aarch64-linux.c: Fix common/ includes.
1188         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1189         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1190         * namespace.h: Fix common/ includes.
1191         * mips-linux-tdep.c: Fix common/ includes.
1192         * minsyms.c: Fix common/ includes.
1193         * mi/mi-parse.h: Fix common/ includes.
1194         * mi/mi-main.c: Fix common/ includes.
1195         * mi/mi-cmd-env.c: Fix common/ includes.
1196         * memrange.h: Fix common/ includes.
1197         * memattr.c: Fix common/ includes.
1198         * maint.h: Fix common/ includes.
1199         * maint.c: Fix common/ includes.
1200         * main.c: Fix common/ includes.
1201         * machoread.c: Fix common/ includes.
1202         * location.c: Fix common/ includes.
1203         * linux-thread-db.c: Fix common/ includes.
1204         * linux-nat.c: Fix common/ includes.
1205         * linux-fork.c: Fix common/ includes.
1206         * inline-frame.c: Fix common/ includes.
1207         * infrun.c: Fix common/ includes.
1208         * inflow.c: Fix common/ includes.
1209         * inferior.h: Fix common/ includes.
1210         * inferior.c: Fix common/ includes.
1211         * infcmd.c: Fix common/ includes.
1212         * inf-ptrace.c: Fix common/ includes.
1213         * inf-child.c: Fix common/ includes.
1214         * ia64-linux-nat.c: Fix common/ includes.
1215         * i387-tdep.c: Fix common/ includes.
1216         * i386-tdep.c: Fix common/ includes.
1217         * i386-linux-tdep.c: Fix common/ includes.
1218         * i386-linux-nat.c: Fix common/ includes.
1219         * i386-go32-tdep.c: Fix common/ includes.
1220         * i386-fbsd-tdep.c: Fix common/ includes.
1221         * i386-fbsd-nat.c: Fix common/ includes.
1222         * guile/scm-type.c: Fix common/ includes.
1223         * guile/guile.c: Fix common/ includes.
1224         * go32-nat.c: Fix common/ includes.
1225         * gnu-nat.c: Fix common/ includes.
1226         * gdbthread.h: Fix common/ includes.
1227         * gdbarch-selftests.c: Fix common/ includes.
1228         * gdb_usleep.c: Fix common/ includes.
1229         * gdb_select.h: Fix common/ includes.
1230         * gdb_bfd.c: Fix common/ includes.
1231         * gcore.c: Fix common/ includes.
1232         * fork-child.c: Fix common/ includes.
1233         * findvar.c: Fix common/ includes.
1234         * fbsd-nat.c: Fix common/ includes.
1235         * event-top.c: Fix common/ includes.
1236         * event-loop.c: Fix common/ includes.
1237         * dwarf2read.c: Fix common/ includes.
1238         * dwarf2loc.c: Fix common/ includes.
1239         * dwarf2-frame.c: Fix common/ includes.
1240         * dwarf-index-cache.c: Fix common/ includes.
1241         * dtrace-probe.c: Fix common/ includes.
1242         * disasm-selftests.c: Fix common/ includes.
1243         * defs.h: Fix common/ includes.
1244         * csky-tdep.c: Fix common/ includes.
1245         * cp-valprint.c: Fix common/ includes.
1246         * cp-support.h: Fix common/ includes.
1247         * cp-support.c: Fix common/ includes.
1248         * corelow.c: Fix common/ includes.
1249         * completer.h: Fix common/ includes.
1250         * completer.c: Fix common/ includes.
1251         * compile/compile.c: Fix common/ includes.
1252         * compile/compile-loc2c.c: Fix common/ includes.
1253         * compile/compile-cplus-types.c: Fix common/ includes.
1254         * compile/compile-cplus-symbols.c: Fix common/ includes.
1255         * command.h: Fix common/ includes.
1256         * cli/cli-dump.c: Fix common/ includes.
1257         * cli/cli-cmds.c: Fix common/ includes.
1258         * charset.c: Fix common/ includes.
1259         * build-id.c: Fix common/ includes.
1260         * btrace.h: Fix common/ includes.
1261         * btrace.c: Fix common/ includes.
1262         * breakpoint.h: Fix common/ includes.
1263         * breakpoint.c: Fix common/ includes.
1264         * ax.h: 
1265         (enum agent_op): Fix common/ includes.
1266         * ax-general.c (struct aop_map): Fix common/ includes.
1267         * ax-gdb.c: Fix common/ includes.
1268         * auxv.c: Fix common/ includes.
1269         * auto-load.c: Fix common/ includes.
1270         * arm-tdep.c: Fix common/ includes.
1271         * arch/riscv.c: Fix common/ includes.
1272         * arch/ppc-linux-common.c: Fix common/ includes.
1273         * arch/i386.c: Fix common/ includes.
1274         * arch/arm.c: Fix common/ includes.
1275         * arch/arm-linux.c: Fix common/ includes.
1276         * arch/arm-get-next-pcs.c: Fix common/ includes.
1277         * arch/amd64.c: Fix common/ includes.
1278         * arch/aarch64.c: Fix common/ includes.
1279         * arch/aarch64-insn.c: Fix common/ includes.
1280         * arch-utils.c: Fix common/ includes.
1281         * amd64-windows-tdep.c: Fix common/ includes.
1282         * amd64-tdep.c: Fix common/ includes.
1283         * amd64-sol2-tdep.c: Fix common/ includes.
1284         * amd64-obsd-tdep.c: Fix common/ includes.
1285         * amd64-nbsd-tdep.c: Fix common/ includes.
1286         * amd64-linux-tdep.c: Fix common/ includes.
1287         * amd64-linux-nat.c: Fix common/ includes.
1288         * amd64-fbsd-tdep.c: Fix common/ includes.
1289         * amd64-fbsd-nat.c: Fix common/ includes.
1290         * amd64-dicos-tdep.c: Fix common/ includes.
1291         * amd64-darwin-tdep.c: Fix common/ includes.
1292         * agent.c: Fix common/ includes.
1293         * ada-lang.h: Fix common/ includes.
1294         * ada-lang.c: Fix common/ includes.
1295         * aarch64-tdep.c: Fix common/ includes.
1296
1297 2019-01-25  Tom Tromey  <tom@tromey.com>
1298
1299         * common/create-version.sh: Use common/version.h.
1300
1301 2019-01-24  Pedro Alves  <palves@redhat.com>
1302
1303         * infrun.c (signal_stop, signal_print, signal_program)
1304         (signal_catch, signal_pass): Now arrays instead of pointers.
1305         (update_signals_program_target, do_target_resume)
1306         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1307         * linux-nat.c (linux_nat_target::pass_signals)
1308         (linux_nat_target::create_inferior, linux_nat_target::attach):
1309         Adjust.
1310         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1311         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1312         * procfs.c (procfs_target::pass_signals): Adjust.
1313         * record-full.c (record_full_target::resume): Adjust.
1314         * remote.c (remote_target::pass_signals)
1315         (remote_target::program_signals): Adjust.
1316         * target-debug.h (target_debug_print_signals): Now takes a
1317         gdb::array_view as parameter.  Adjust.
1318         * target.h (target_ops) <pass_signals, program_signals>: Replace
1319         pointer and length parameters with gdb::array_view.
1320         (target_pass_signals, target_program_signals): Likewise.
1321         * target-delegates.c: Regenerate.
1322
1323 2019-01-24  Pedro Alves  <palves@redhat.com>
1324
1325         * common/forward-scope-exit.h
1326         (forward_scope_exit::forward_scope_exit): Pass arguments to
1327         m_bind_function directly, instead of creating a std::bind and
1328         copying that.
1329
1330 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1331
1332         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1333         for static members.
1334         (pass_in_v_vfp_candidate): Likewise.
1335
1336 2019-01-23  Tom Tromey  <tom@tromey.com>
1337             Pedro Alves  <palves@redhat.com>
1338
1339         * regcache.c (class regcache_invalidator): Remove.
1340         (regcache::raw_write): Use make_scope_exit.
1341
1342 2019-01-23  Tom Tromey  <tom@tromey.com>
1343
1344         * ui-out.h (class ui_out_emit_type): Update comment.
1345
1346 2019-01-23  Tom Tromey  <tom@tromey.com>
1347
1348         * infrun.c (fetch_inferior_event): Update comment.
1349
1350 2019-01-23  Tom Tromey  <tom@tromey.com>
1351             Pedro Alves  <palves@redhat.com>
1352
1353         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1354         parameter.
1355         (fetch_inferior_event): Use SCOPE_EXIT.
1356
1357
1358 2019-01-23  Tom Tromey  <tom@tromey.com>
1359             Pedro Alves  <palves@redhat.com>
1360
1361         * infrun.c (disable_thread_events): Delete.
1362         (stop_all_threads): Use SCOPE_EXIT.
1363
1364 2019-01-23  Tom Tromey  <tom@tromey.com>
1365             Pedro Alves  <palves@redhat.com>
1366
1367         * symfile.c: Include forward-scope-exit.h.
1368         (clear_symtab_users_cleanup): Replace forward declaration with
1369         a FORWARD_SCOPE_EXIT.
1370         (syms_from_objfile_1): Use the forward_scope_exit and
1371         gdb::optional instead of cleanup_function.
1372         (reread_symbols): Use the forward_scope_exit instead of
1373         cleanup_function.
1374         (clear_symtab_users_cleanup): Remove function.
1375
1376 2019-01-23  Tom Tromey  <tom@tromey.com>
1377             Pedro Alves  <palves@redhat.com>
1378
1379         * linux-nat.c: Include scope-exit.h.
1380         (cleanup_target_stop): Remove.
1381         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1382         SCOPE_EXIT.
1383
1384 2019-01-23  Tom Tromey  <tom@tromey.com>
1385             Pedro Alves  <palves@redhat.com>
1386
1387         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1388         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1389
1390 2019-01-23  Tom Tromey  <tom@tromey.com>
1391             Andrew Burgess  <andrew.burgess@embecosm.com>
1392             Pedro Alves  <palves@redhat.com>
1393
1394         * infrun.c (fetch_inferior_event): Use scope_exit.
1395         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1396         * top.c (execute_command): Use scope_exit.
1397         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1398         * utils.c (do_bpstat_clear_actions_cleanup)
1399         (make_bpstat_clear_actions_cleanup): Remove.
1400
1401 2019-01-23  Tom Tromey  <tom@tromey.com>
1402             Pedro Alves  <palves@redhat.com>
1403
1404         * infrun.c: Include "common/scope-exit.h"
1405         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1406         (wait_for_inferior): Use SCOPE_EXIT.
1407         (fetch_inferior_event): Use scope_exit.
1408
1409 2019-01-23  Tom Tromey  <tom@tromey.com>
1410             Pedro Alves  <palves@redhat.com>
1411
1412         * breakpoint.c (create_breakpoint): Remove cleanup.
1413
1414 2019-01-23  Tom Tromey  <tom@tromey.com>
1415             Andrew Burgess  <andrew.burgess@embecosm.com>
1416             Pedro Alves  <palves@redhat.com>
1417
1418 2019-01-23  Pedro Alves  <palves@redhat.com>
1419
1420         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1421
1422 2019-01-23  Pedro Alves  <palves@redhat.com>
1423             Andrew Burgess  <andrew.burgess@embecosm.com>
1424
1425         * gdbthread.h: Include "common/forward-scope-exit.h".
1426         (scoped_finish_thread_state): Redefine custom class in terms of
1427         forward_scope_exit.
1428
1429 2019-01-23  Pedro Alves  <palves@redhat.com>
1430             Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * common/forward-scope-exit.h: New file.
1433
1434 2019-01-23  Pedro Alves  <palves@redhat.com>
1435             Andrew Burgess  <andrew.burgess@embecosm.com>
1436             Tom Tromey  <tom@tromey.com>
1437
1438         * common/scope-exit.h: New file.
1439
1440 2019-01-23  Pedro Alves  <palves@redhat.com>
1441
1442         * common/preprocessor.h (ESC): Rename to ...
1443         (ESC_PARENS): ... this.
1444         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1445         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1446
1447 2019-01-23  Tom Tromey  <tom@tromey.com>
1448
1449         * language.h (class scoped_switch_to_sym_language_if_auto):
1450         Initialize m_lang in both cases.
1451
1452 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1453
1454         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1455         with XCNEW.
1456
1457 2019-01-22  Tom Tromey  <tom@tromey.com>
1458
1459         * corelow.c: Do not include sys/file.h.
1460
1461 2019-01-22  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-wingeneral.h: Include gdb_curses.h.
1464
1465 2019-01-22  Tom Tromey  <tom@tromey.com>
1466
1467         * source-cache.h (class source_cache) <get_source_lines,
1468         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1469
1470 2019-01-22  Tom Tromey  <tom@tromey.com>
1471
1472         * remote-fileio.h (struct remote_target): Declare.
1473
1474 2019-01-22  Tom Tromey  <tom@tromey.com>
1475
1476         * python/py-arch.c: Do not include py-ref.h.
1477         * python/py-bpevent.c: Do not include py-ref.h.
1478         * python/py-cmd.c: Do not include py-ref.h.
1479         * python/py-continueevent.c: Do not include py-ref.h.
1480         * python/py-event.h: Do not include py-ref.h.
1481         * python/py-evtregistry.c: Do not include py-ref.h.
1482         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1483         * python/py-frame.c: Do not include py-ref.h.
1484         * python/py-framefilter.c: Do not include py-ref.h.
1485         * python/py-function.c: Do not include py-ref.h.
1486         * python/py-infevents.c: Do not include py-ref.h.
1487         * python/py-linetable.c: Do not include py-ref.h.
1488         * python/py-objfile.c: Do not include py-ref.h.
1489         * python/py-param.c: Do not include py-ref.h.
1490         * python/py-prettyprint.c: Do not include py-ref.h.
1491         * python/py-progspace.c: Do not include py-ref.h.
1492         * python/py-symbol.c: Do not include py-ref.h.
1493         * python/py-symtab.c: Do not include py-ref.h.
1494         * python/py-type.c: Do not include py-ref.h.
1495         * python/py-unwind.c: Do not include py-ref.h.
1496         * python/py-utils.c: Do not include py-ref.h.
1497         * python/py-value.c: Do not include py-ref.h.
1498         * python/py-varobj.c: Do not include py-ref.h.
1499         * python/py-xmethods.c: Do not include py-ref.h.
1500         * python/python.c: Do not include py-ref.h.
1501         * varobj.c: Do not include py-ref.h.
1502
1503 2019-01-22  Tom Tromey  <tom@tromey.com>
1504
1505         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1506         keyword for bcache.
1507
1508 2019-01-22  Tom Tromey  <tom@tromey.com>
1509
1510         * compile/compile-cplus-types.c: Remove a comment by #include.
1511
1512 2019-01-22  Tom Tromey  <tom@tromey.com>
1513
1514         * compile/gcc-c-plugin.h: Include compile-internal.h.
1515
1516 2019-01-22  Tom Tromey  <tom@tromey.com>
1517
1518         * stabsread.c (EXTERN): Do not define.
1519         (symnum, next_symbol_text_func, processing_gcc_compilation)
1520         (within_function, global_sym_chain, global_stabs)
1521         (previous_stab_code, this_object_header_files)
1522         (n_this_object_header_files)
1523         (n_allocated_this_object_header_files): Define.
1524         * stabsread.h (EXTERN): Never define.  Use "extern".
1525
1526 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1527
1528         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1529         history_value.
1530
1531 2019-01-21  Tom Tromey  <tom@tromey.com>
1532
1533         * ui-out.c: Fix includes.
1534         * tui/tui-source.c: Fix includes.
1535         * target.c: Fix includes.
1536         * remote.c: Fix includes.
1537         * regcache.c: Fix includes.
1538         * python/py-block.c: Fix includes.
1539         * printcmd.c: Fix includes.
1540         * or1k-tdep.c: Fix includes.
1541         * mi/mi-main.c: Fix includes.
1542         * m32r-tdep.c: Fix includes.
1543         * csky-tdep.c: Fix includes.
1544         * compile/compile-cplus-types.c: Fix includes.
1545         * cli/cli-interp.c: Fix includes.
1546
1547 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1548
1549         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1550         for padding.
1551
1552 2019-01-16  Tom Tromey  <tom@tromey.com>
1553
1554         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1555         earlier.
1556         (struct objfile) <msymbols_range>: Move from top level.
1557         <msymbols>: New method.
1558         (class objfile_msymbols): Remove.
1559         * symtab.c (default_collect_symbol_completion_matches_break_on):
1560         Update.
1561         * symmisc.c (dump_msymbols): Update.
1562         * stabsread.c (scan_file_globals): Update.
1563         * objc-lang.c (info_selectors_command, info_classes_command)
1564         (find_methods): Update.
1565         * minsyms.c (find_solib_trampoline_target): Update.
1566         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1567         * coffread.c (coff_symfile_read): Update.
1568         * ada-lang.c (ada_lookup_simple_minsym)
1569         (ada_collect_symbol_completion_matches): Update.
1570
1571 2019-01-16  Tom Tromey  <tom@tromey.com>
1572
1573         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1574         type.  Remove no-argument constructor.
1575         <iterator::operator++>: Simplify.
1576         <begin>: Update.
1577         <end>: Use minimal_symbol_count.
1578
1579 2019-01-16  Tom Tromey  <tom@tromey.com>
1580
1581         * objfiles.h (struct objfile) <psymtabs>: New method.
1582         (class objfile_psymtabs): Remove.
1583         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1584         typedef.
1585         <range>: New method.
1586         (require_partial_symbols): Change return type.
1587         * psymtab.c (require_partial_symbols)
1588         (psym_expand_symtabs_matching): Update.
1589         * mdebugread.c (parse_partial_symbols): Update.
1590         * dbxread.c (dbx_end_psymtab): Update.
1591
1592 2019-01-15  Tom Tromey  <tom@tromey.com>
1593
1594         * symtab.c (lookup_objfile_from_block)
1595         (lookup_symbol_in_objfile_symtabs)
1596         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1597         (find_line_symtab, info_sources_command)
1598         (default_collect_symbol_completion_matches_break_on)
1599         (make_source_files_completion_list): Update.
1600         * symmisc.c (print_objfile_statistics, dump_objfile)
1601         (maintenance_print_symbols, maintenance_info_symtabs)
1602         (maintenance_check_symtabs, maintenance_info_line_tables):
1603         Update.
1604         * source.c (select_source_symtab)
1605         (forget_cached_source_info_for_objfile): Update.
1606         * objfiles.h (class objfile_compunits): Remove.
1607         (struct objfile) <compunits_range>: New typedef.
1608         (compunits): New method.
1609         * objfiles.c (objfile_relocate1): Update.
1610         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1611         * maint.c (count_symtabs_and_blocks): Update.
1612         * linespec.c (iterate_over_all_matching_symtabs): Update.
1613         * cp-support.c (add_symbol_overload_list_qualified): Update.
1614         * coffread.c (coff_symtab_read): Update.
1615         * ada-lang.c (add_nonlocal_symbols)
1616         (ada_collect_symbol_completion_matches)
1617         (ada_add_global_exceptions): Update.
1618
1619 2019-01-15  Tom Tromey  <tom@tromey.com>
1620
1621         * progspace.h (program_space) <objfiles_safe_range>: New
1622         typedef.
1623         <objfiles_safe>: New method.
1624         * objfiles.h (class all_objfiles_safe): Remove.
1625         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1626         * jit.c (jit_inferior_exit_hook): Update.
1627
1628 2019-01-17  Tom Tromey  <tom@tromey.com>
1629
1630         * progspace.h (program_space) <objfiles_range>: New typedef.
1631         <objfiles>: New method.
1632         <objfiles_head>: Rename from objfiles.
1633         (object_files): Update.
1634         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1635         * guile/scm-pretty-print.c
1636         (ppscm_find_pretty_printer_from_objfiles): Update.
1637         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1638         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1639         Update.
1640         * python/py-progspace.c (pspy_get_objfiles): Update.
1641         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1642         Update.
1643         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1644         (objfpy_lookup_objfile_by_build_id): Update.
1645         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1646         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1647         Update.
1648         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1649         (expand_symtab_containing_pc, lookup_objfile_from_block)
1650         (lookup_static_symbol, basic_lookup_transparent_type)
1651         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1652         (find_line_symtab, info_sources_command)
1653         (default_collect_symbol_completion_matches_break_on)
1654         (make_source_files_completion_list, find_main_name): Update.
1655         * symmisc.c (print_symbol_bcache_statistics)
1656         (print_objfile_statistics, maintenance_print_symbols)
1657         (maintenance_print_msymbols, maintenance_print_objfiles)
1658         (maintenance_info_symtabs, maintenance_check_symtabs)
1659         (maintenance_expand_symtabs, maintenance_info_line_tables):
1660         Update.
1661         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1662         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1663         (map_overlay_command, unmap_overlay_command)
1664         (simple_overlay_update, expand_symtabs_matching)
1665         (map_symbol_filenames): Update.
1666         * symfile-debug.c (set_debug_symfile): Update.
1667         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1668         Update.
1669         * source.c (select_source_symtab, forget_cached_source_info):
1670         Update.
1671         * solib.c (solib_read_symbols): Update.
1672         * solib-spu.c (append_ocl_sos): Update.
1673         * psymtab.c (maintenance_print_psymbols)
1674         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1675         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1676         * printcmd.c (info_symbol_command): Update.
1677         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1678         Update.
1679         * objfiles.h (class all_objfiles): Remove.
1680         * objfiles.c (have_partial_symbols, have_full_symbols)
1681         (have_minimal_symbols, qsort_cmp, update_section_map)
1682         (shared_objfile_contains_address_p)
1683         (default_iterate_over_objfiles_in_search_order): Update.
1684         * objc-lang.c (info_selectors_command, info_classes_command)
1685         (find_methods): Update.
1686         * minsyms.c (find_solib_trampoline_target): Update.
1687         * maint.c (maintenance_info_sections)
1688         (maintenance_translate_address, count_symtabs_and_blocks):
1689         Update.
1690         * main.c (captured_main_1): Update.
1691         * linux-thread-db.c (try_thread_db_load_from_pdir)
1692         (has_libpthread): Update.
1693         * linespec.c (iterate_over_all_matching_symtabs)
1694         (search_minsyms_for_name): Update.
1695         * jit.c (jit_find_objf_with_entry_addr): Update.
1696         * hppa-tdep.c (find_unwind_entry)
1697         (hppa_lookup_stub_minimal_symbol): Update.
1698         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1699         Update.
1700         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1701         (elf_gnu_ifunc_resolve_by_got): Update.
1702         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1703         * dwarf-index-write.c (save_gdb_index_command): Update.
1704         * cp-support.c (add_symbol_overload_list_qualified): Update.
1705         * breakpoint.c (create_overlay_event_breakpoint)
1706         (create_longjmp_master_breakpoint)
1707         (create_std_terminate_master_breakpoint)
1708         (create_exception_master_breakpoint): Update.
1709         * blockframe.c (find_pc_partial_function): Update.
1710         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1711         (ada_collect_symbol_completion_matches)
1712         (ada_add_global_exceptions): Update.
1713
1714 2019-01-17  Tom Tromey  <tom@tromey.com>
1715
1716         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1717         declare VEC.
1718         (solib_target_parse_libraries): Change return type.
1719         (library_list_start_segment, library_list_start_section)
1720         (library_list_end_library, library_list_start_library); Update.
1721         (solib_target_free_library_list): Remove.
1722         (solib_target_parse_libraries): Remove cleanup.  Change return
1723         type.
1724         (solib_target_current_sos): Update.
1725
1726 2019-01-17  Tom Tromey  <tromey@bapiya>
1727
1728         * valprint.c: Replace "the the" with "the".
1729         * symtab.c: Replace "the the" with "the".
1730         * solib.c: Replace "the the" with "the".
1731         * solib-dsbt.c: Replace "the the" with "the".
1732         * linespec.c: Replace "the the" with "the".
1733         * dwarf2loc.h: Replace "the the" with "the".
1734         * amd64-windows-tdep.c: Replace "the the" with "the".
1735         * aarch64-tdep.c: Replace "the the" with "the".
1736
1737 2019-01-16  Keith Seitz  <keiths@redhat.com>
1738
1739         PR gdb/23773
1740         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1741         <builder>: Rename to ..
1742         <m_builder>: ... this and make private.
1743         (dwarf2_cu::get_builder): New method.  Change all users of
1744         `builder' to use this method.
1745         (dwarf2_start_symtab): Move to ...
1746         (dwarf2_cu::start_symtab): ... here.  Update all callers
1747         (setup_type_unit_groups): Move to ...
1748         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1749         callers.
1750         (dwarf2_cu::reset_builder): New method.
1751         (process_full_compunit, process_full_type_unit): Use
1752         dwarf2_cu::reset_builder.
1753         (follow_die_offset): Record the ancestor CU if it is different
1754         from the followed DIE's CU.
1755         (follow_die_sig_1): Likewise.
1756
1757 2019-01-15  Tom Tromey  <tom@tromey.com>
1758
1759         * remote.c (class remote_state) <buf>: Now a char_vector.
1760         <buf_size>: Remove.
1761         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1762         parameter.
1763         (remote_target::getpkt_or_notif_sane_1)
1764         (remote_target::getpkt_sane)
1765         (remote_target::getpkt_or_notif_sane): Likewise.
1766         (class remote_target) <putpkt>: New overload.
1767         (remote_target::read_frame): Change type of "buf_p".  Remove
1768         sizeof_p parameter.
1769         (packet_ok): New overload.
1770         (packet_check_result): New overload.
1771         Update all uses.
1772
1773 2019-01-14  Tom Tromey  <tom@tromey.com>
1774
1775         * remote-notif.c (handle_notification, remote_notif_ack)
1776         (remote_notif_parse): Make "buf" const.
1777         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1778         const.
1779         (remote_notif_parse, remote_notif_ack, handle_notification):
1780         Likewise.
1781         * remote.c (remote_notif_stop_parse): Make "buf" const.
1782         (remote_target::remote_parse_stop_reply): Make "buf" const.
1783         (remote_notif_stop_ack): Make "buf" const.
1784
1785 2019-01-14  Tom Tromey  <tom@tromey.com>
1786
1787         * remote.c (remote_console_output): Make parameter const.
1788
1789 2019-01-14  Tom Tromey  <tom@tromey.com>
1790
1791         * target-debug.h (target_debug_print_signals): Constify.
1792         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1793         * procfs.c (procfs_target::pass_signals): Update.
1794         * linux-nat.c (linux_nat_target::pass_signals): Update.
1795         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1796         * target-delegates.c: Rebuild.
1797         * remote.c (remote_target::program_signals): Update.
1798         (remote_target::pass_signals): Update.
1799         * target.c (target_pass_signals): Constify argument.
1800         (target_program_signals): Likewise.
1801         * target.h (struct target_ops) <pass_signals, program_signals>:
1802         Constify argument.
1803         (target_pass_signals, target_program_signals): Constify argument.
1804
1805 2019-01-14  Tom Tromey  <tom@tromey.com>
1806
1807         PR tui/28819:
1808         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1809
1810 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1811
1812         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1813         field.
1814         * rs6000-tdep.c: Include reggroups.h.
1815         (IS_V_ALIAS_PSEUDOREG): Define.
1816         (rs6000_register_name): Return names for the "vX" aliases.
1817         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1818         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1819         aliases.  Call default_register_reggroup_p for all other
1820         pseudo-registers.
1821         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1822         New functions.
1823         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1824         Handle "vX" aliases.
1825         (v_alias_pseudo_register_collect): New function.
1826         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1827         (rs6000_gdbarch_init): Initialize "vX" aliases as
1828         pseudo-registers.  Restore registration of
1829         rs6000_pseudo_register_reggroup_p with
1830         set_tdesc_pseudo_register_reggroup_p.
1831
1832 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1833
1834         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1835         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1836         set_gdbarch_num_pseudo_regs.
1837
1838 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1839
1840         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1841         Remove arg prefixname, add do_set and do_show.
1842         Add member functions set_list and show_list.
1843         * cli/cli-style.c (class cli_style_option): Update accordingly.
1844         (style_set_list): Move to file scope.
1845         (style_show_list): Likewise.
1846         (set_style): Call help_list.
1847         (show_style): Call cmd_show_list.
1848         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1849         Update to use the new macro.
1850
1851 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1852
1853         * ada-lang.c (_initialize_ada_language): Expand the help text
1854         for the "catch exception" command.
1855
1856 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1857
1858         * symtab.c (matching_obj_sections): Initialize obj,
1859         declare it closer to its usage.
1860
1861 2019-01-10  Tom Tromey  <tom@tromey.com>
1862
1863         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1864         (basic_inf_threads_range): Remove.
1865         (inf_threads_range, inf_non_exited_threads_range)
1866         (safe_inf_threads_range): Use next_adapter.
1867
1868 2019-01-10  Keith Seitz  <keiths@redhat.com>
1869
1870         PR gdb/23712
1871         PR symtab/23010
1872         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1873         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1874
1875 2019-01-10  Keith Seitz  <keiths@redhat.com>
1876
1877         PR gdb/23712
1878         PR symtab/23010
1879         * dictionary.c (pending_to_vector): Remove.
1880         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1881         Remove _1 suffix, replacing functions of the same name.  Update
1882         all callers.
1883         (dict_create_hashed, dict_create_hashed_expandable)
1884         (dict_create_linear, dict_create_linear_expandable, dict_free)
1885         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1886         Make functions static.
1887
1888 2019-01-10  Keith Seitz  <keiths@redhat.com>
1889
1890         PR gdb/23712
1891         PR symtab/23010
1892         * dictionary.h (struct dictionary): Replace declaration with
1893         multidictionary.
1894         (dict_create_hashed, dict_create_hashed_expandable)
1895         (dict_create_linear, dict_create_linear_expandable)
1896         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1897         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1898         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1899         taking multidictionary argument.
1900         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1901         * block.h (struct block) <dict>: Change to multidictionary
1902         and rename `multidict'.
1903         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1904         symmisc.c: Update all dictionary references to multidictionary.
1905
1906 2019-01-10  Keith Seitz  <keiths@redhat.com>
1907
1908         PR gdb/23712
1909         PR symtab/23010
1910         * dictionary.c: Include unordered_map.
1911         (pending_to_vector): New function.
1912         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1913         Rewrite the non-"_1" functions to take vector instead
1914         of linked list.
1915         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1916         "new" _1 versions of the same name.
1917         (multidictionary): Define.
1918         (std::hash<enum language): New definition.
1919         (collate_pending_symbols_by_language, mdict_create_hashed)
1920         (mdict_create_hashed_expandable, mdict_create_linear)
1921         (mdict_create_linear_expandable, mdict_free)
1922         (find_language_dictionary, create_new_language_dictionary)
1923         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1924         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1925         (mdict_size, mdict_empty): New functions.
1926         * dictionary.h (mdict_iterator): Define.
1927
1928 2019-01-10  Pedro Alves  <palves@redhat.com>
1929
1930         * breakpoint.c (read_uploaded_action)
1931         (create_tracepoint_from_upload): Adjust to use
1932         gdb::unique_xmalloc_ptr.
1933         * ctf.c (ctf_write_uploaded_tp):
1934         (SET_ARRAY_FIELD): Use emplace_back.
1935         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1936         * tracefile-tfile.c (tfile_write_uploaded_tp):
1937         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1938         gdb::unique_xmalloc_ptr.
1939         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1940         at_string, cond_string, cmd_strings>: Replace char pointers
1941         with gdb::unique_xmalloc_ptr.
1942
1943 2019-01-10  Pedro Alves  <palves@redhat.com>
1944
1945         * solib-target.c (library_list_start_library): Don't xstrdup name.
1946
1947 2019-01-10  Pedro Alves  <palves@redhat.com>
1948
1949         * mdebugread.c (parse_partial_symbols): Use
1950         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1951
1952 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1953
1954         * linux-fork.c (scoped_switch_fork_info)
1955         <~scoped_switch_fork_info>: Fix incorrect variable name.
1956
1957 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1958
1959         * linux-fork.c (scoped_switch_fork_info)
1960         <scoped_switch_fork_info>: Make explicit.
1961         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1962
1963 2019-01-10  Tom Tromey  <tom@tromey.com>
1964
1965         * objfiles.h (objfile::reset_psymtabs): Update.
1966         * objfiles.c (objfile::objfile): Update.
1967         * psymtab.h (psymtab_storage::obstack): Update.
1968         (psymtab_storage::m_obstack): Use gdb::optional.
1969         (class psymtab_storage): Update comment.  Remove objfile
1970         parameter.
1971         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1972
1973 2019-01-10  Tom Tromey  <tom@tromey.com>
1974
1975         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1976         <free_psymtabs>: Now private.
1977         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1978         (allocate_psymtab): Use new method.
1979
1980 2019-01-10  Tom Tromey  <tom@tromey.com>
1981
1982         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1983         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1984         * mdebugread.c (parse_partial_symbols): Use
1985         allocate_dependencies.
1986         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1987         allocate_dependencies.
1988         (process_psymtab_comp_unit_reader)
1989         (build_type_psymtab_dependencies): Likewise.
1990         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1991
1992 2019-01-10  Tom Tromey  <tom@tromey.com>
1993
1994         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1995         PSYMBOL_SET_LANGUAGE.
1996         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1997
1998 2019-01-10  Tom Tromey  <tom@tromey.com>
1999
2000         * psymtab.h (psymtab_storage::obstack): New method.
2001         <m_obstack>: Rename from obstack; now private.
2002         * psymtab.c (psymtab_storage): Update.
2003         * dwarf2read.c (create_addrmap_from_index)
2004         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2005         Update.
2006
2007 2019-01-10  Tom Tromey  <tom@tromey.com>
2008
2009         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2010         * objfiles.h (objfile::reset_psymtabs): New method.
2011
2012 2019-01-10  Tom Tromey  <tom@tromey.com>
2013
2014         * symmisc.c (print_symbol_bcache_statistics): Update.
2015         (print_objfile_statistics): Update.
2016         * symfile.c (reread_symbols): Update.
2017         * psymtab.h (class psymtab_storage): New.
2018         * psymtab.c (psymtab_storage): New constructor.
2019         (~psymtab_storage): New destructor.
2020         (require_partial_symbols): Update.
2021         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2022         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2023         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2024         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2025         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2026         (start_psymtab_common, end_psymtab_common)
2027         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2028         (allocate_psymtab): Update.
2029         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2030         Update.
2031         (dump_psymtab_addrmap, maintenance_print_psymbols)
2032         (maintenance_check_psymtabs): Update.
2033         (class objfile_psymtabs): Move to objfiles.h.
2034         * psympriv.h (discard_psymtab): Now inline.
2035         (psymtab_discarder::psymtab_discarder): Update.
2036         (psymtab_discarder::~psymtab_discarder): Update.
2037         (ALL_OBJFILE_PSYMTABS): Rewrite.
2038         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2039         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2040         Remove fields.
2041         <partial_symtabs>: New field.
2042         (class objfile_psymtabs): Move from psymtab.h.  Update.
2043         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2044         psymbol_cache.
2045         (objfile::~objfile): Don't destroy psymbol_cache.
2046         * mdebugread.c (parse_partial_symbols): Update.
2047         * dwarf2read.c (create_addrmap_from_index)
2048         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2049         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2050         (add_partial_subprogram, dwarf2_ranges_read): Update.
2051         * dwarf-index-write.c (write_address_map)
2052         (write_one_signatured_type, recursively_write_psymbols)
2053         (class debug_names, class debug_names, write_psymtabs_to_index):
2054         Update.
2055
2056 2019-01-10  Tom Tromey  <tom@tromey.com>
2057
2058         * symtab.h (SYMBOL_SET_NAMES): Update.
2059         (symbol_set_names): Update.
2060         (MSYMBOL_SET_NAMES): Update.
2061         * symtab.c (symbol_set_names): Change argument to be an
2062         objfile_per_bfd_storage.
2063         * psymtab.c (add_psymbol_to_bcache): Update.
2064         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2065
2066 2019-01-10  Tom Tromey  <tom@tromey.com>
2067
2068         * symtab.c (create_demangled_names_hash): Change argument to be an
2069         objfile_per_bfd_storage.
2070         (symbol_set_names): Update.
2071
2072 2019-01-10  Tom Tromey  <tom@tromey.com>
2073
2074         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2075         init_psymbol_list.
2076         * psymtab.c (init_psymbol_list): Do nothing if already called.
2077         * psympriv.h (init_psymbol_list): Add comment.
2078         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2079         init_psymbol_list.
2080         * dbxread.c (dbx_symfile_read): Unconditionally call
2081         init_psymbol_list.
2082
2083 2019-01-10  Tom Tromey  <tom@tromey.com>
2084
2085         * xcoffread.c (scan_xcoff_symtab): Update.
2086         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2087         "where".
2088         * mdebugread.c (parse_partial_symbols)
2089         (handle_psymbol_enumerators): Update.
2090         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2091         * dbxread.c (read_dbx_symtab): Update.
2092         * psympriv.h (psymbol_placement): New enum.
2093         (add_psymbol_to_list): Update.
2094
2095 2019-01-10  Tom Tromey  <tom@tromey.com>
2096
2097         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2098         static_psymbols parameters.
2099         (scan_xcoff_symtab): Update.
2100         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2101         static_psymbols parameters.
2102         * psympriv.h (start_psymtab_common): Update.
2103         * mdebugread.c (parse_partial_symbols): Update.
2104         * dwarf2read.c (create_partial_symtab): Update.
2105         * dbxread.c (read_dbx_symtab): Update.
2106         (start_psymtab): Remove global_psymbols and static_psymbols
2107         parameters.
2108
2109 2019-01-10  Tom Tromey  <tom@tromey.com>
2110
2111         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2112         * psymtab.c (allocate_psymtab): Add comment.
2113         * psympriv.h (allocate_psymtab): Add comment.
2114         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2115         initializations.
2116         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2117
2118 2019-01-10  Tom Tromey  <tom@tromey.com>
2119
2120         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2121         Don't declare.
2122         * mipsread.c: Include mdebugread.h.
2123         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2124         Declare.
2125         * elfread.c: Include mdebugread.h.
2126
2127 2019-01-09  Tom Tromey  <tom@tromey.com>
2128
2129         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2130         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2131         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2132         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2133         (psym_lookup_symbol, psym_find_last_source_symtab)
2134         (psym_forget_cached_source_info, psym_print_stats)
2135         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2136         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2137         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2138         (psym_find_compunit_symtab_by_address)
2139         (maintenance_print_psymbols, maintenance_info_psymtabs)
2140         (maintenance_check_psymtabs): Use ranged for.
2141         * psymtab.h (class objfile_psymtabs): New.
2142         (require_partial_symbols): Return objfile_psymtabs.
2143         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2144
2145 2019-01-09  Tom Tromey  <tom@tromey.com>
2146
2147         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2148         (find_pc_mapped_section, list_overlays_command)
2149         (map_overlay_command, unmap_overlay_command)
2150         (simple_overlay_update): Use all_objfiles.
2151         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2152         * printcmd.c (info_symbol_command): Use all_objfiles.
2153         * objfiles.h (ALL_OBJSECTIONS): Remove.
2154         * maint.c (maintenance_translate_address): Use all_objfiles.
2155         * gcore.c (gcore_create_callback): Use all_objfiles.
2156         (objfile_find_memory_regions): Likewise.
2157
2158 2019-01-09  Tom Tromey  <tom@tromey.com>
2159
2160         * symtab.c (find_line_symtab, info_sources_command)
2161         (make_source_files_completion_list): Use objfile_compunits.
2162         * source.c (select_source_symtab): Use objfile_compunits.
2163         * objfiles.h (struct objfile): Update comment.
2164         (ALL_OBJFILES): Remove.
2165         (ALL_FILETABS): Remove.
2166         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2167         objfile_compunits.
2168
2169 2019-01-09  Tom Tromey  <tom@tromey.com>
2170
2171         * symmisc.c (print_objfile_statistics, dump_objfile)
2172         (maintenance_print_symbols): Use compunit_filetabs.
2173         * source.c (forget_cached_source_info_for_objfile): Use
2174         compunit_filetabs.
2175         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2176         (ALL_FILETABS): Use compunit_filetabs.
2177         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2178         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2179
2180 2019-01-09  Tom Tromey  <tom@tromey.com>
2181
2182         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2183         (compunit_filetabs): New.
2184         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2185         compunit_filetabs.
2186         (info_sources_command, make_source_files_completion_list): Remove
2187         declaration.
2188         * symmisc.c (print_objfile_statistics, dump_objfile)
2189         (maintenance_print_symbols): Remove declaration.
2190         (maintenance_info_symtabs): Use compunit_filetabs.
2191         (maintenance_info_line_tables): Likewise.
2192         * source.c (select_source_symtab): Change local variable name.
2193         (forget_cached_source_info_for_objfile): Remove declaration.
2194         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2195         * objfiles.c (objfile_relocate1): Remove declaration.
2196         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2197         declaration.
2198         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2199         * coffread.c (coff_symtab_read): Remove declaration.
2200         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2201         compunit_filetabs.
2202
2203 2019-01-09  Tom Tromey  <tom@tromey.com>
2204
2205         * symtab.c (lookup_objfile_from_block)
2206         (find_pc_sect_compunit_symtab, search_symbols)
2207         (default_collect_symbol_completion_matches_break_on): Use
2208         objfile_compunits.
2209         * objfiles.h (ALL_COMPUNITS): Remove.
2210         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2211         * cp-support.c (add_symbol_overload_list_qualified): Use
2212         objfile_compunits.
2213         * ada-lang.c (ada_collect_symbol_completion_matches)
2214         (ada_add_global_exceptions): Use objfile_compunits.
2215
2216 2019-01-09  Tom Tromey  <tom@tromey.com>
2217
2218         * source.c (select_source_symtab)
2219         (forget_cached_source_info_for_objfile): Remove declaration.
2220         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2221         declaration.
2222         * maint.c (count_symtabs_and_blocks): Remove declaration.
2223         * cp-support.c (add_symbol_overload_list_qualified): Remove
2224         declaration.
2225         * coffread.c (coff_symtab_read): Remove declaration.
2226         * symtab.c (lookup_symbol_in_objfile_symtabs)
2227         (basic_lookup_transparent_type_1): Use objfile_compunits.
2228         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2229         (info_sources_command, search_symbols)
2230         (default_collect_symbol_completion_matches_break_on)
2231         (make_source_files_completion_list): Remove declaration.
2232         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2233         (ada_collect_symbol_completion_matches)
2234         (ada_add_global_exceptions): Remove declaration.
2235         * linespec.c (iterate_over_all_matching_symtabs): Use
2236         objfile_compunits.
2237         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2238         (class objfile_compunits): New.
2239         (ALL_COMPUNITS): Use objfile_compunits.
2240         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2241         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2242         objfile_compunits.
2243         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2244
2245 2019-01-09  Tom Tromey  <tom@tromey.com>
2246
2247         * symtab.c (search_symbols)
2248         (default_collect_symbol_completion_matches_break_on): Use
2249         objfile_msymbols.
2250         * ada-lang.c (ada_lookup_simple_minsym)
2251         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2252         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2253         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2254         objfile_msymbols.
2255         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2256         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2257         * objc-lang.c (find_methods): Use objfile_msymbols.
2258         (info_selectors_command, info_classes_command): Likewise.
2259         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2260         * objfiles.h (class objfile_msymbols): New.
2261         (ALL_OBJFILE_MSYMBOLS): Remove.
2262         (ALL_MSYMBOLS): Remove.
2263
2264 2019-01-09  Tom Tromey  <tom@tromey.com>
2265
2266         * common/next-iterator.h (next_adapter): Add Iterator template
2267         parameter.
2268         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2269         (class all_objfiles_safe): New.
2270         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2271         * objfiles.c (put_objfile_before): Update comment.
2272         (add_separate_debug_objfile): Likewise.
2273         (free_all_objfiles): Use all_objfiles_safe.
2274         (objfile_purge_solibs): Likewise.
2275
2276 2019-01-09  Tom Tromey  <tom@tromey.com>
2277
2278         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2279         (expand_symtab_containing_pc, lookup_static_symbol)
2280         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2281         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2282         all_objfiles.
2283         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2284         * breakpoint.c (create_overlay_event_breakpoint)
2285         (create_longjmp_master_breakpoint)
2286         (create_std_terminate_master_breakpoint)
2287         (create_exception_master_breakpoint): Use all_objfiles.
2288         * linux-thread-db.c (try_thread_db_load_from_pdir)
2289         (has_libpthread): Use all_objfiles.
2290         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2291         * linespec.c (iterate_over_all_matching_symtabs)
2292         (search_minsyms_for_name): Use all_objfiles.
2293         * maint.c (maintenance_info_sections): Use all_objfiles.
2294         * main.c (captured_main_1): Use all_objfiles.
2295         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2296         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2297         * guile/scm-pretty-print.c
2298         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2299         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2300         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2301         (maintenance_print_msymbols): Use all_objfiles.
2302         * source.c (select_source_symtab): Use all_objfiles.
2303         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2304         * symfile.c (remove_symbol_file_command)
2305         (expand_symtabs_matching, map_symbol_filenames): Use
2306         all_objfiles.
2307         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2308         all_objfiles.
2309         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2310         * objc-lang.c (find_methods): Use all_objfiles.
2311         * objfiles.c (have_partial_symbols, have_full_symbols)
2312         (have_minimal_symbols, qsort_cmp)
2313         (default_iterate_over_objfiles_in_search_order): Use
2314         all_objfiles.
2315         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2316         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2317         (maintenance_check_psymtabs): Use all_objfiles.
2318         (ALL_PSYMTABS): Remove.
2319         * compile/compile-object-run.c (do_module_cleanup): Use
2320         all_objfiles.
2321         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2322         * cp-support.c (add_symbol_overload_list_qualified): Use
2323         all_objfiles.
2324         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2325         Use all_objfiles.
2326         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2327         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2328         all_objfiles.
2329         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2330         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2331         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2332         Uses all_objfiles.
2333         * solib.c (solib_read_symbols): Use all_objfiles
2334
2335 2019-01-09  Tom Tromey  <tom@tromey.com>
2336
2337         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2338         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2339         all_objfiles.
2340         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2341         * symmisc.c (print_symbol_bcache_statistics)
2342         (print_objfile_statistics, maintenance_print_objfiles)
2343         (maintenance_info_symtabs, maintenance_check_symtabs)
2344         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2345         all_objfiles.
2346         * source.c (forget_cached_source_info): Use all_objfiles.
2347         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2348         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2349         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2350         * objfiles.c (update_section_map): Use all_objfiles.
2351         (shared_objfile_contains_address_p): Likewise.
2352         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2353         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2354
2355 2019-01-09  Tom Tromey  <tom@tromey.com>
2356
2357         * common/next-iterator.h: New file.
2358         * objfiles.h (class all_objfiles): New.
2359         (struct objfile_iterator): New.
2360
2361 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2362
2363         * NEWS: Move the description of the changed "frame", "select-frame",
2364          and "info frame" commands to the Changed commands section.
2365
2366 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2367
2368         * gdbtypes.c (check_stub_method_group): Remove handling of old
2369         mangling schemes.
2370         * linespec.c (find_methods): Likewise.
2371         * stabsread.c (read_member_functions): Likewise.
2372         * valops.c (search_struct_method): Likewise.
2373         (value_struct_elt_for_reference): Likewise.
2374         * NEWS: Mention this change.
2375
2376 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2377
2378         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2379         print_source_lines.
2380         * source.c (print_source_lines_base): Update line number check.
2381         (print_source_lines): New function.
2382         (source_lines_range::source_lines_range): New function.
2383         * source.h (class source_lines_range): New class.
2384         (print_source_lines): New declaration.
2385
2386 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2387
2388         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2389
2390 2019-01-08  Tom Tromey  <tom@tromey.com>
2391             Simon Marchi  <simon.marchi@ericsson.com>
2392
2393         PR gdb/24060
2394         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2395         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2396         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2397         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2398         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2399         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2400
2401 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2402
2403         * source.c (select_source_symtab): Move header comment to
2404         declaration in source.h.
2405         (forget_cached_source_info_for_objfile): Likewise.
2406         (forget_cached_source_info): Likewise.
2407         (identify_source_line): Likewise.
2408         * source.h (identify_source_line): Move declaration from symtab.h
2409         and add comment from source.c
2410         (print_source_lines): Likewise.
2411         (forget_cached_source_info_for_objfile): Likewise.
2412         (forget_cached_source_info): Likewise.
2413         (select_source_symtab): Likewise.
2414         (enum print_source_lines_flag): Move definition from symtab.h.
2415         * symtab.h (identify_source_line): Move declaration to source.h.
2416         (print_source_lines): Likewise.
2417         (forget_cached_source_info_for_objfile): Likewise.
2418         (forget_cached_source_info): Likewise.
2419         (select_source_symtab): Likewise.
2420         (enum print_source_lines_flag): Move definition to source.h.
2421         * tui/tui-hooks.c: Add 'source.h' include.
2422
2423 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * source.c (print_source_lines_base): Handle requests to print
2426         reverse line number sequences, and guard against empty lines
2427         string.
2428
2429 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2430
2431         * source.c (print_source_lines_base): Fix skip of '\r' if next
2432         character is '\n'.
2433
2434 2019-01-06  Tom Tromey  <tom@tromey.com>
2435
2436         * c-exp.y (struct c_parse_state) <macro_original_text,
2437         expansion_obstack>: New member.
2438         (macro_original_text, expansion_obstack): Remove globals.
2439         (scan_macro_expansion, scanning_macro_expansion)
2440         (finished_macro_expansion): Update.
2441         (scan_macro_cleanup): Remove.
2442         (yylex, c_parse): Update.
2443
2444 2019-01-06  Tom Tromey  <tom@tromey.com>
2445
2446         * c-exp.y (struct c_parse_state) <strings>: New member.
2447         (operator_stoken): Update.
2448
2449 2019-01-06  Tom Tromey  <tom@tromey.com>
2450
2451         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2452         (union type_stack_elt) <typelist_val>: Now a pointer to
2453         std::vector.
2454         (type_stack_cleanup): Don't declare.
2455         (push_typelist): Update.
2456         * parse.c (pop_typelist): Return a std::vector.
2457         (push_typelist): Take a std::vector.
2458         (follow_types): Update.  Do not free args.
2459         (type_stack_cleanup): Remove.
2460         * c-exp.y (struct c_parse_state): New.
2461         (cpstate): New global.
2462         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2463         (nonempty_typelist): Update.
2464         (func_mod): Create a new vector.
2465         (c_parse): Create a c_parse_state.
2466         (check_parameter_typelist): Do not delete params.
2467         (function_method): Update.  Do not delete type_list.
2468
2469 2019-01-06  Tom Tromey  <tom@tromey.com>
2470
2471         PR gdb/28155:
2472         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2473         check_typedef.
2474         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2475         (print_return_value): Likewise.
2476
2477 2019-01-05  Tom Tromey  <tom@tromey.com>
2478
2479         * contrib/cleanup_check.py: Remove.
2480         * contrib/gcc-with-excheck: Remove.
2481         * contrib/exsummary.py: Remove.
2482         * contrib/excheck.py: Remove.
2483
2484 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2485
2486         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2487         NULL. Initialize tpprev to NULL instead of assigning it
2488         to NULL on the next statement.
2489         * windows-nat.c (windows_delete_thread): Remove check for
2490         main_thread_id before printing thread exit notifications.
2491         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2492         Remove thread ID check against main_thread_id.
2493         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2494         windows_delete_thread.
2495         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2496
2497 2019-01-04  Tom Tromey  <tom@tromey.com>
2498
2499         * compile/compile.c (_initialize_compile): Use upper case for
2500         metasyntactic variables.
2501         * symmisc.c (_initialize_symmisc): Use upper case for
2502         metasyntactic variables.
2503         * psymtab.c (_initialize_psymtab): Use upper case for
2504         metasyntactic variables.
2505         * demangle.c (demangle_command): Use upper case for metasyntactic
2506         variables.
2507         (_initialize_demangler): Likewise.
2508         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2509         variables.
2510
2511 2019-01-03  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2514
2515 2019-01-03  Tom Tromey  <tom@tromey.com>
2516
2517         * python/py-symtab.c (salpy_str): Update.
2518         (struct salpy_sal_object) <symtab>: Now a PyObject.
2519         (salpy_dealloc): Update.
2520         (del_objfile_sal): Use gdbpy_ref.
2521
2522 2019-01-03  Tom Tromey  <tom@tromey.com>
2523
2524         * python/py-type.c (convert_field): Use new_reference.  Return
2525         gdbpy_ref.
2526         (make_fielditem): Return gdbpy_ref.
2527         (typy_fields): Update.
2528         (typy_getitem): Update.
2529         (field_name): Return gdbpy_ref.  Use new_reference.
2530         (typy_iterator_iternext): Update.
2531
2532 2019-01-03  Tom Tromey  <tom@tromey.com>
2533
2534         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2535
2536 2019-01-03  Tom Tromey  <tom@tromey.com>
2537
2538         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2539         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2540         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2541         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2542         (pspy_set_type_printers): Likewise.
2543         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2544         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2545         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2546         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2547         (objfpy_set_type_printers): Likewise.
2548
2549 2019-01-03  Tom Tromey  <tom@tromey.com>
2550
2551         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2552         (gdbpy_print_stack): Use gdbpy_err_fetch.
2553         * python/python-internal.h (class gdbpy_err_fetch): New class.
2554         (class gdbpy_enter) <m_error_type, m_error_value,
2555         m_error_traceback>: Remove.
2556         <m_error>: New member.
2557         (gdbpy_exception_to_string): Don't declare.
2558         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2559         * python/py-value.c (convert_value_from_python): Use
2560         gdbpy_err_fetch.
2561         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2562         gdbpy_exception_to_string.
2563         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2564         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2565         gdbpy_err_fetch.
2566
2567 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2568
2569         * linux-nat.c (delete_lwp_cleanup): Delete.
2570         (struct lwp_deleter): New struct.
2571         (lwp_info_up): New typedef.
2572         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2573         lwp_info_up.
2574
2575 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2576
2577         * linux-fork.c (class scoped_switch_fork_info): New class.
2578         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2579
2580 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2581
2582         * valops.c (find_overload_match): Remove use of null_cleanup, and
2583         calls to do_cleanups.
2584
2585 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2586
2587         * compile/compile-cplus-types.c
2588         (compile_cplus_instance::decl_name): Handle changes to
2589         cp_func_name.
2590         * cp-support.c (cp_func_name): Update header comment, update
2591         return type.
2592         * cp-support.h (cp_func_name): Update return type in declaration.
2593         * valops.c (find_overload_match): Move temp_func local to top
2594         level of function and change its type.  Use temp_func to hold and
2595         delete temporary string obtained from cp_func_name.
2596
2597 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2598
2599         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2600         gdb::char_vector, remove cleanup, and update uses of `msg`.
2601
2602 2019-01-03  Jim Wilson  <jimw@sifive.com>
2603
2604         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2605
2606 2019-01-02  Tom Tromey  <tom@tromey.com>
2607
2608         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2609         (tdesc_parse_xml): Remove cleanups.
2610         * target-descriptions.h (make_cleanup_free_target_description):
2611         Don't declare.
2612         (target_desc_deleter): New struct.
2613         (target_desc_up): New typedef.
2614         * target-descriptions.c (target_desc_deleter::operator()): Rename
2615         from free_target_description.
2616         (make_cleanup_free_target_description): Remove.
2617
2618 2019-01-02  Tom Tromey  <tom@tromey.com>
2619
2620         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2621         constructor, destructor.
2622         (linespec_parser): Remove typedef.
2623         (~linespec_parser): Rename from linespec_parser_delete.
2624         (linespec_lex_to_end, linespec_complete_label)
2625         (linespec_complete): Update.
2626         (decode_line_full): Remove cleanups.
2627         (decode_line_1): Update.
2628
2629 2019-01-02  Tom Tromey  <tom@tromey.com>
2630
2631         * python/python-internal.h (inferior_to_inferior_object): Change
2632         return type.
2633         * python/py-exitedevent.c (create_exited_event_object): Update.
2634         * python/py-inferior.c (inferior_to_inferior_object): Return
2635         gdbpy_ref.
2636         (python_new_inferior, python_inferior_deleted)
2637         (thread_to_thread_object, delete_thread_object)
2638         (build_inferior_list, gdbpy_selected_inferior): Update.
2639         * python/py-infthread.c (create_thread_object): Update.  Also fail
2640         if inferior_to_inferior_object fails.
2641
2642 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2643
2644         * inferior.h (class inferior) <displaced_step_state>: New field.
2645         * infrun.h (struct displaced_step_state): Move here from
2646         infrun.c.  Initialize fields, add constructor.
2647         <inf>: Remove field.
2648         <reset>: New method.
2649         * infrun.c (struct displaced_step_inferior_state): Move to
2650         infrun.h.
2651         (displaced_step_inferior_states): Remove.
2652         (get_displaced_stepping_state): Adust.
2653         (displaced_step_in_progress_any_inferior): Adjust.
2654         (displaced_step_in_progress_thread): Adjust.
2655         (displaced_step_in_progress): Adjust.
2656         (add_displaced_stepping_state): Remove.
2657         (get_displaced_step_closure_by_addr): Adjust.
2658         (remove_displaced_stepping_state): Remove.
2659         (infrun_inferior_exit): Call displaced_step_state.reset.
2660         (use_displaced_stepping): Don't check for NULL.
2661         (displaced_step_prepare_throw): Call
2662         get_displaced_stepping_state.
2663         (displaced_step_fixup): Don't check for NULL.
2664         (prepare_for_detach): Don't check for NULL.
2665
2666 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2667
2668         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2669          in case of call that did not complete.
2670
2671 2019-01-02  Andrey Utkin  <autkin@undo.io>
2672
2673         * symfile.c (find_separate_debug_file): Fix search of debug files for
2674         remote debuggee.
2675
2676 2019-01-02  Tom Tromey  <tom@tromey.com>
2677
2678         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2679         indentation.
2680         * python/py-frame.c (frapy_older): Remove cast.
2681         (frapy_newer): Likewise.
2682         * python/py-breakpoint.c (local_setattro): Remove cast.
2683         * python/py-arch.c (archpy_name): Remove local variable.
2684         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2685
2686 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2687
2688         * unittests/basic_string_view/element_access/char/empty.cc:
2689         Fix year range in copyright header.
2690
2691 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2694         Delete.
2695         <operator==>: Update with for removed field.
2696         <hash>: Likewise.
2697         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2698         <isa_features>: ...this.
2699         <abi_features>: New field.
2700         (riscv_isa_flen): Update comment.
2701         (riscv_abi_xlen): New declaration.
2702         (riscv_abi_flen): New declaration.
2703         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2704         isa_features.
2705         (riscv_abi_xlen): New function.
2706         (riscv_isa_flen): Update to get answer from isa_features.
2707         (riscv_abi_flen): New function.
2708         (riscv_has_fp_abi): Update to get answer from abi_features.
2709         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2710         xlen and flen.
2711         (riscv_call_info) <xlen, flen>: Update comment.
2712         (riscv_call_arg_struct): Remove invalid assertions
2713         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2714         is removed.
2715         (riscv_gdbarch_init): Gather isa features and abi features
2716         separately, ensure both match on the gdbarch when reusing an old
2717         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2718         a target with 64-bit float hardware.
2719
2720 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2721
2722         * source.c (search_command_helper): Stop reverse search
2723         when line 1 has been searched.
2724
2725 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2726
2727         * record-full.c (record_full_base_target::close): Rewrite
2728         record_full_core_buf_list free logic.
2729
2730 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2731
2732         * break-catch-syscall.c (print_one_catch_syscall): xfree
2733         the last text.
2734
2735 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2736
2737         * top.c (print_gdb_version): Update Copyright year in version
2738         message.
2739
2740 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2741
2742         Update copyright year range in all GDB files.
2743
2744 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2745
2746         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2747
2748 For older changes see ChangeLog-2018.
2749 \f
2750 Local Variables:
2751 mode: change-log
2752 left-margin: 8
2753 fill-column: 74
2754 version-control: never
2755 coding: utf-8
2756 End:
2757