gdb/ChangeLog

   1 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
   2
   3         PR cli/24587
   4         * completer.c (complete): Initialize variable word.
   5
   6 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
   7
   8         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
   9         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
  10         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
  11         'body' is NULL to the outter 'if', protecting the '!is_define'
  12         situation as well.
  13
  14 2019-05-29  Tom Tromey  <tromey@adacore.com>
  15
  16         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
  17         (dwarf_unknown): New function.
  18         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
  19         (dwarf_type_encoding_name): Use dwarf_unknown.
  20
  21 2019-05-29  Tom Tromey  <tromey@adacore.com>
  22
  23         PR c++/20020:
  24         * cp-valprint.c (cp_print_value_fields): Call
  25         cp_print_static_field inside "try".
  26
  27 2019-05-29  Tom Tromey  <tromey@adacore.com>
  28
  29         * inflow.c (struct terminal_info): Add default operator=.
  30         * configure: Rebuild.
  31         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
  32         -Wdeprecated-copy-dtor, -Wredundant-move.
  33
  34 2019-05-29  Tom Tromey  <tromey@adacore.com>
  35
  36         * NEWS: Add entry.
  37         * infcmd.c (print_return_value_1): Handle finish_print
  38         option.
  39         (show_print_finish): New function.
  40         (_initialize_infcmd): Add "set/show print finish" commands.
  41         * valprint.c (user_print_options): Initialize new member.
  42         * valprint.h (struct value_print_options) <finish_print>: New
  43         member.
  44
  45 2019-05-28  Tom Tromey  <tromey@adacore.com>
  46
  47         * ada-lang.c (ada_remove_Xbn_suffix)
  48         (find_old_style_renaming_symbol)
  49         (parse_old_style_renaming): Remove.
  50         (ada_find_renaming_symbol): Don't call
  51         find_old_style_renaming_symbol.
  52         (ada_is_renaming_symbol): Rename from
  53         ada_find_renaming_symbol.  Remove "block" parameter.  Return
  54         bool.  Now static.
  55         (ada_read_var_value): Update and simplify.
  56         * ada-exp.y (write_var_or_type): Remove old code.
  57
  58 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
  59
  60         * event-top.c: Remove include comment.
  61         * inflow.c (class scoped_ignore_sigttou): Move from here...
  62         * inflow.h (class scoped_ignore_sigttou): ...to here.
  63         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
  64         * top.c:  Remove include comment.
  65
  66 2019-05-27  Tom Tromey  <tom@tromey.com>
  67
  68         * NEWS: Fix typo.
  69
  70 2019-05-22  Tom Tromey  <tromey@adacore.com>
  71
  72         * target.c (target_follow_exec): Constify parameter.
  73         * target-delegates.c: Rebuild.
  74         * remote.c (remote_target::follow_exec): Constify parameter.
  75         * infrun.c (follow_exec): Constify parameter.
  76         * target.h (struct target_ops) <follow_exec>: Constify parameter.
  77         (target_follow_exec): Likewise.
  78
  79 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  80
  81         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
  82         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
  83
  84 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  85
  86         * NEWS: Add debugredirect and testsuite sections.
  87
  88 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
  89
  90         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
  91         target descriptions using exclusively floating point register name
  92         aliases.
  93
  94 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  95
  96         PR gdb/18644:
  97         * f-lang.c (build_fortran_types): Handle the case where
  98         gdbarch_floatformat_for_type returns a nullptr.
  99
 100 2019-05-21  Tom de Vries  <tdevries@suse.de>
 101
 102         PR cli/24587
 103         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 104
 105 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 106
 107         PR gdb/18644:
 108         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 109         16-byte floats.
 110         * i386-tdep.c (i386_floatformat_for_type): Use
 111         floatformats_ia64_quad for the 16-byte floating point component
 112         within a fortran 32-byte complex number.
 113
 114 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 115
 116         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 117         delete default constructor.
 118         (find_partial_die): Update to return const struct.
 119         (partial_die_parent_scope): Move variable declaration into scope
 120         of its use and change its type to auto.
 121         (guess_partial_die_structure_name): Likewise.
 122         (partial_die_info::fixup): Likewise.
 123
 124 2019-05-17  Tom Tromey  <tromey@adacore.com>
 125
 126         * source.c (find_and_open_source): Remove cast.
 127
 128 2019-05-17  Tom Tromey  <tromey@adacore.com>
 129
 130         * annotate.c (annotate_source): Make "filename" const.
 131         * annotate.h (annotate_source): Use const.
 132
 133 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 134
 135         * disasm.c (set_disassembler_options): Send errors to stderr.
 136
 137 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 138
 139         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 140         (cli_interp_base::set_logging): Check debug_redirect.
 141         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 142         * cli/cli-logging.c (debug_redirect): Add static variable.
 143         (pop_output_files): Add default param.
 144         (handle_redirections): Print debug setting.
 145         (show_logging_command): Likewise.
 146         (_initialize_cli_logging): Add debugredirect command.
 147         * interps.c (current_interp_set_logging): Add debug_redirect
 148         parameter.
 149         * interps.h (set_logging): Add debug_redirect parameter.
 150         (current_interp_set_logging): Likewise.
 151         * mi/mi-common.h: Likewise.
 152         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 153
 154 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 155             Tom Tromey  <tromey@adacore.com>
 156
 157         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 158         directly.
 159         * cli/cli-interp.h (make_logging_output): Remove declaration.
 160         * cli/cli-logging.c (make_logging_output): Remove function.
 161         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 162         directly.
 163         * ui-file.c (tee_file::tee_file): Remove bools.
 164         (tee_file::~tee_file): Remove deletes.
 165         * ui-file.h (tee_file): Remove bools.
 166
 167 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 168
 169         * mi/mi-cmds.h (mi_cmd_complete): New function.
 170         * mi/mi-main.c (mi_cmd_complete): Likewise.
 171         * mi/mi-cmds.c: Define new MI command -complete.
 172         * NEWS: Mention new -complete command.
 173
 174 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 175
 176         * completer.h (complete): New function.
 177         * completer.c (complete): Likewise.
 178         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 179         function defined in completer.h.
 180
 181 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 182
 183        * MAINTAINERS (Write After Approval): Add myself.
 184
 185 2019-05-17  Tom de Vries  <tdevries@suse.de>
 186
 187         PR gdb/24094
 188         * dwarf2read.c (struct cu_partial_die_info): New struct.
 189         (find_partial_die): Return cu_partial_die_info.
 190         (partial_die_parent_scope, guess_partial_die_structure_name)
 191         (partial_die_info::fixup): Handle new return type of find_partial_die.
 192
 193 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 194
 195         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 196         "std::string", simplifying the algorithm.
 197
 198 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 199
 200         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 201         (stap_static_probe_ops::get_probes): Likewise.
 202
 203 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 204
 205         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 206         '-')" and "else if".
 207         (stap_parse_single_operand): Join checks for
 208         "gdbarch_stap_parse_special_token_p" and
 209         "gdbarch_stap_parse_special_token" in the same "if" statement.
 210         Invert check when verifying for operation on register
 211         displacement.
 212
 213 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 214
 215         * stap-probe.c (stap_get_opcode): Update comment.
 216         (stap_get_expected_argument_type): Likewise.
 217         (handle_stap_probe): Likewise.
 218
 219 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 220
 221         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 222         return type to 'bool'.  Adjust comment.  Use 'bool' when
 223         appropriate.
 224         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 225         * stap-probe.c (stap_parse_argument_1): Likewise.
 226         (stap_is_operator): Likewise.
 227         (stap_is_generic_prefix): Likewise.
 228         (stap_is_register_prefix): Likewise.
 229         (stap_is_register_indirection_prefix): Likewise.
 230         (stap_is_integer_prefix): Likewise.
 231         (stap_generic_check_suffix): Likewise.
 232         (stap_check_integer_suffix): Likewise.
 233         (stap_check_register_suffix): Likewise.
 234         (stap_check_register_indirection_suffix): Likewise.
 235         (stap_parse_register_operand): Likewise.
 236         (stap_parse_single_operand): Likewise.
 237         (stap_parse_argument_1): Likewise.
 238         (stap_probe::get_argument_count): Likewise.
 239         (stap_is_operator): Likewise.
 240
 241 2019-05-16  Tom Tromey  <tromey@adacore.com>
 242
 243         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 244         keyword to foreach.
 245
 246 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 247
 248         * linux-thread-db.c (try_thread_db_load_1): Change return type
 249         to bool.
 250         (try_thread_db_load): Likewise.
 251         (try_thread_db_load_from_pdir_1): Likewise.
 252         (try_thread_db_load_from_pdir): Likewise.
 253         (try_thread_db_load_from_sdir): Likewise.
 254         (try_thread_db_load_from_dir): Likewise.
 255         (thread_db_load_search): Likewise.
 256         (has_libpthread): Likewise.
 257         (thread_db_load): Likewise.
 258
 259 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 260
 261         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 262         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 263         NULL, and complain/return if that's the case.
 264
 265 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 266
 267         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 268         (advance, posn, abstract_read_memory): New functions.
 269         [struct mem_read_abstraction]: New struct.
 270         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 271
 272 2019-05-14  Tom Tromey  <tromey@adacore.com>
 273
 274         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 275         value is not lval_memory.
 276
 277 2019-05-14  Tom Tromey  <tromey@adacore.com>
 278
 279         * solib.c (info_sharedlibrary_command): Style the file name.
 280
 281 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 282
 283         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 284         (aarch64_vnv_type): Likewise.
 285         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 286         * common/tdesc.c: Likewise.
 287         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 288         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 289         * features/aarch64-fpu.xml: Add ieee half view.
 290         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 291         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 292         * gdbtypes.h (struct builtin_type): Likewise.
 293         (struct objfile_type): Likewise.
 294
 295 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 296
 297         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 298         typo.
 299         * location.h (string_to_event_location): Likewise.
 300
 301 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 302
 303         GDB 8.3 released.
 304
 305 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 306
 307         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 308         New variable declaration.
 309         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 310         New variable.
 311         (print_one_breakpoint): Use ui_out::test_flags and new global
 312         variable to compute use_fixed_output.
 313         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 314         Remove.
 315         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 316         (mi_multi_location_breakpoint_output_fixed): Remove.
 317         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 318         new variable.
 319         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 320         fix_multi_location_breakpoint_output flag if version >= 3.
 321         * ui-out.h (enum ui_out_flag)
 322         <fix_multi_location_breakpoint_output>: New enumerator.
 323
 324 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 325
 326         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 327
 328 2019-05-10  Tom Tromey  <tromey@adacore.com>
 329
 330         * ada-lang.c (catch_ada_completer): New function.
 331         (_initialize_ada_language): Use it.
 332
 333 2019-05-10  Tom Tromey  <tromey@adacore.com>
 334
 335         * thread.c (print_thread_info): Make "requested_threads" const.
 336         * gdbthread.h (print_thread_info): Make "requested_threads"
 337         const.
 338         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 339         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 340
 341 2019-05-08  Tom Tromey  <tom@tromey.com>
 342
 343         * gdbtypes.c (objfile_type_data): Change type.
 344         (objfile_type, _initialize_gdbtypes): Update.
 345
 346 2019-05-08  Tom Tromey  <tom@tromey.com>
 347
 348         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 349         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 350         (_initialize_dwarf2_frame): Update.
 351
 352 2019-05-08  Tom Tromey  <tom@tromey.com>
 353
 354         * objc-lang.c (objc_objfile_data): Change type.
 355         (find_methods): Update.
 356         (_initialize_objc_lang): Remove.
 357
 358 2019-05-08  Tom Tromey  <tom@tromey.com>
 359
 360         * stabsread.c (rs6000_builtin_type_data): Change type.
 361         (rs6000_builtin_type, _initialize_stabsread): Update.
 362
 363 2019-05-08  Tom Tromey  <tom@tromey.com>
 364
 365         * mips-tdep.c (mips_pdr_data): Remove.
 366         (_initialize_mips_tdep): Update.
 367
 368 2019-05-08  Tom Tromey  <tom@tromey.com>
 369
 370         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 371         (hppa_init_objfile_priv_data, read_unwind_info)
 372         (find_unwind_entry, _initialize_hppa_tdep): Update.
 373
 374 2019-05-08  Tom Tromey  <tom@tromey.com>
 375
 376         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 377         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 378         on obstack.
 379         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 380
 381 2019-05-08  Tom Tromey  <tom@tromey.com>
 382
 383         * mdebugread.c (basic_type_data): Change type.
 384         (basic_type, _initialize_mdebugread): Update.
 385
 386 2019-05-08  Tom Tromey  <tom@tromey.com>
 387
 388         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 389
 390 2019-05-08  Tom Tromey  <tom@tromey.com>
 391
 392         * nto-tdep.c (nto_inferior_data_reg): Change type.
 393         (nto_inferior_data): Update.
 394         (nto_inferior_data_cleanup, nto_new_inferior_data)
 395         (_initialize_nto_tdep): Remove.
 396         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 397
 398 2019-05-08  Tom Tromey  <tom@tromey.com>
 399
 400         * ada-lang.c (struct ada_inferior_data): Add initializers.
 401         (ada_inferior_data): Change type.
 402         (ada_inferior_data_cleanup): Remove.
 403         (get_ada_inferior_data, ada_inferior_exit)
 404         (struct ada_pspace_data): Add initializers, destructor.
 405         (ada_pspace_data_handle): Change type.
 406         (get_ada_pspace_data): Update.
 407         (ada_pspace_data_cleanup): Remove.
 408
 409 2019-05-08  Tom Tromey  <tom@tromey.com>
 410
 411         * coffread.c (struct coff_symfile_info): Add initializers.
 412         (coff_objfile_data_key): Move lower.  Change type.
 413         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 414         Update.
 415         (coff_free_info): Remove.
 416
 417 2019-05-08  Tom Tromey  <tom@tromey.com>
 418
 419         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 420         (fbsd_pspace_data_handle): Move lower.  Change type.
 421         (get_fbsd_pspace_data): Update.
 422         (fbsd_pspace_data_cleanup): Remove.
 423         (_initialize_fbsd_tdep): Update.
 424
 425 2019-05-08  Tom Tromey  <tom@tromey.com>
 426
 427         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 428         (get_ada_tasks_pspace_data): Update.
 429         (ada_tasks_pspace_data_cleanup): Remove.
 430         (_initialize_tasks): Update.
 431         (ada_tasks_inferior_data_handle): Change type.
 432         (get_ada_tasks_inferior_data): Update.
 433         (ada_tasks_inferior_data_cleanup): Remove.
 434         (struct ada_tasks_pspace_data): Add initializers.
 435
 436 2019-05-08  Tom Tromey  <tom@tromey.com>
 437
 438         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 439         * symfile-debug.c (debug_sym_get_probes): Change type.
 440         * stap-probe.c (handle_stap_probe):
 441         (stap_static_probe_ops::get_probes): Change type.
 442         * probe.h (class static_probe_ops) <get_probes>: Change type.
 443         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 444         (parse_probes_in_pspace): Update.
 445         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 446         Update.
 447         (any_static_probe_ops::get_probes): Change type.
 448         * elfread.c (elfread_data): New typedef.
 449         (probe_key): Change type.
 450         (elf_get_probes): Likewise.  Update.
 451         (probe_key_free): Remove.
 452         (_initialize_elfread): Update.
 453         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 454         Change type.
 455         (dtrace_process_dof_probe, dtrace_process_dof)
 456         (dtrace_static_probe_ops::get_probe): Change type.
 457
 458 2019-05-08  Tom Tromey  <tom@tromey.com>
 459
 460         * xcoffread.c (struct xcoff_symfile_info): Rename from
 461         coff_symfile_info.  Add initializers.
 462         (xcoff_objfile_data_key): Move lower.  Change type.
 463         (XCOFF_DATA): Rewrite.
 464         (xcoff_free_info): Remove.
 465         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 466         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 467         (xcoff_initial_scan): Update.
 468
 469 2019-05-08  Tom Tromey  <tom@tromey.com>
 470
 471         * solib-svr4.c (struct svr4_info): Add initializers and
 472         destructor.
 473         <probes_table>: Now an htab_up.
 474         (solib_svr4_pspace_data): Change type.
 475         (free_probes_table): Simplify.
 476         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 477         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 478         (probes_table_remove_objfile_probes, register_solib_event_probe)
 479         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 480         (_initialize_svr4_solib): Update.
 481
 482 2019-05-08  Tom Tromey  <tom@tromey.com>
 483
 484         * remote.c (remote_pspace_data): Change type.
 485         (remote_pspace_data_cleanup): Remove.
 486         (get_remote_exec_file, set_pspace_remote_exec_file)
 487         (_initialize_remote): Update.
 488
 489 2019-05-08  Tom Tromey  <tom@tromey.com>
 490
 491         * breakpoint.c (breakpoint_objfile_key): Change type.
 492         (get_breakpoint_objfile_data): Update.
 493         (free_breakpoint_objfile_data): Remove.
 494         (_initialize_breakpoint): Update.
 495
 496 2019-05-08  Tom Tromey  <tom@tromey.com>
 497
 498         * linux-tdep.c (struct linux_info): Add initializers.
 499         (linux_inferior_data): Move.  Change type.
 500         (invalidate_linux_cache_inf): Update.
 501         (linux_inferior_data_cleanup): Remove.
 502         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 503
 504 2019-05-08  Tom Tromey  <tom@tromey.com>
 505
 506         * auxv.c (auxv_inferior_data): Move.  Change type.
 507         (auxv_inferior_data_cleanup): Remove.
 508         (invalidate_auxv_cache_inf): Rewrite.
 509         (get_auxv_inferior_data, _initialize_auxv): Update.
 510
 511 2019-05-08  Tom Tromey  <tom@tromey.com>
 512
 513         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 514         (symfile_debug_objfile_data_key): Change type.
 515         (symfile_debug_installed, debug_qf_has_symbols)
 516         (debug_qf_find_last_source_symtab)
 517         (debug_qf_forget_cached_source_info)
 518         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 519         (debug_qf_print_stats, debug_qf_dump)
 520         (debug_qf_expand_symtabs_for_function)
 521         (debug_qf_expand_all_symtabs)
 522         (debug_qf_expand_symtabs_with_fullname)
 523         (debug_qf_map_matching_symbols)
 524         (debug_qf_expand_symtabs_matching)
 525         (debug_qf_find_pc_sect_compunit_symtab)
 526         (debug_qf_map_symbol_filenames)
 527         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 528         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 529         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 530         (debug_sym_read_linetable, debug_sym_relocate): Update.
 531         (symfile_debug_free_objfile): Remove.
 532         (install_symfile_debug_logging, _initialize_symfile_debug):
 533         Update.
 534
 535 2019-05-08  Tom Tromey  <tom@tromey.com>
 536
 537         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 538         allocate_on_obstack.
 539         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 540         (get_dwarf2_per_objfile): Update.
 541         (set_dwarf2_per_objfile): Remove.
 542         (dwarf2_has_info, dwarf2_get_section_info): Update.
 543         (dwarf2_free_objfile): Remove.
 544         (_initialize_dwarf2_read): Update.
 545
 546 2019-05-08  Tom Tromey  <tom@tromey.com>
 547
 548         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 549         initializers.
 550         <unsupported_script_warning_printed,
 551         script_not_found_warning_printed>: Now bool.
 552         (auto_load_pspace_data): Change type.
 553         (~auto_load_pspace_info): Rename from
 554         auto_load_pspace_data_cleanup.
 555         (get_auto_load_pspace_data, init_loaded_scripts_info)
 556         (clear_section_scripts, maybe_print_unsupported_script_warning)
 557         (maybe_print_script_not_found_warning, _initialize_auto_load):
 558         Update.
 559
 560 2019-05-08  Tom Tromey  <tom@tromey.com>
 561
 562         * objfiles.c (objfile_pspace_info): Add destructor and
 563         initializers.
 564         (objfiles_pspace_data): Change type.
 565         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 566         (get_objfile_pspace_data): Update.
 567         (objfiles_bfd_data): Change type.
 568         (get_objfile_bfd_data): Update.
 569         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 570
 571 2019-05-08  Tom Tromey  <tom@tromey.com>
 572
 573         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 574         Change type.
 575         (get_catch_syscall_inferior_data): Update.
 576         (catch_syscall_inferior_data_cleanup): Remove.
 577         (_initialize_break_catch_syscall): Update.
 578
 579 2019-05-08  Tom Tromey  <tom@tromey.com>
 580
 581         * inflow.c (struct terminal_info): Add destructor and
 582         initializers.
 583         (inflow_inferior_data): Change type.
 584         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 585         (get_inflow_inferior_data, inflow_inferior_exit)
 586         (swap_terminal_info, _initialize_inflow): Update.
 587
 588 2019-05-08  Tom Tromey  <tom@tromey.com>
 589
 590         * target-dcache.c (target_dcache_cleanup): Remove.
 591         (target_dcache_aspace_key): Change type.
 592         (target_dcache_init_p, target_dcache_invalidate)
 593         (target_dcache_get, target_dcache_get_or_init)
 594         (_initialize_target_dcache): Update.
 595         * dcache.h (struct dcache_deleter): New.
 596
 597 2019-05-08  Tom Tromey  <tom@tromey.com>
 598
 599         * symtab.c (struct symbol_cache): Add destructor and
 600         initializers.
 601         (symbol_cache_key): Move.  Change type.
 602         (make_symbol_cache, free_symbol_cache): Remove.
 603         (get_symbol_cache): Update.
 604         (symbol_cache_cleanup): Remove.
 605         (ALL_PSPACES, symbol_cache_flush)
 606         (maintenance_print_symbol_cache)
 607         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 608         Update.
 609
 610 2019-05-08  Tom Tromey  <tom@tromey.com>
 611
 612         * symtab.c (struct main_info): Add destructor and initializers.
 613         (main_progspace_key): Move.  Change type.
 614         (get_main_info): Update.
 615         (main_info_cleanup): Remove.
 616         (_initialize_symtab): Update.
 617
 618 2019-05-08  Tom Tromey  <tom@tromey.com>
 619
 620         * registry.h (DECLARE_REGISTRY): Define the _key class.
 621
 622 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 623
 624         * NEWS: Merge two 'New commands' sections.
 625
 626 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 627
 628         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 629         parameter and use Ada language definition instead.
 630         (ada_val_print_ptr): Remove unused language parameter.
 631         (ada_val_print_num): Remove language parameter and use Ada language
 632         definition instead.
 633         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 634         parameter.
 635         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 636         parameter and use Ada language definition instead.
 637         (ada_val_print_1): Update all ada_val_print_xxx calls.
 638         Remove language parameter.
 639         (ada_val_print): Update ada_val_print_1 call.
 640
 641 2019-05-08  Tom Tromey  <tromey@adacore.com>
 642
 643         * remote.c (remote_hw_watchpoint_limit)
 644         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 645         Now static.
 646
 647 2019-05-08  Tom Tromey  <tromey@adacore.com>
 648
 649         * maint.c (_initialize_maint_cmds): Move initialization code to
 650         remote.c.
 651         (watchdog, show_watchdog): Move to remote.c.
 652         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 653         "watchdog" static.
 654         (_initialize_remote): Move initialization code from maint.c.
 655         * defs.h (watchdog): Don't declare.
 656
 657 2019-05-08  Tom Tromey  <tromey@adacore.com>
 658
 659         * tui/tui-interp.c: Include main.h.
 660         * interps.c: Include main.h.
 661         * main.h (interpreter_p): Declare.
 662         * defs.h (interpreter_p): Don't declare.
 663
 664 2019-05-08  Tom Tromey  <tromey@adacore.com>
 665
 666         * dwarf2loc.c: Include dwarf2read.h.
 667         * defs.h (read_unsigned_leb128): Don't declare.
 668         * dwarf2read.h (read_unsigned_leb128): Declare.
 669
 670 2019-05-08  Tom Tromey  <tromey@adacore.com>
 671
 672         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 673         method.
 674
 675 2019-05-08  Tom Tromey  <tromey@adacore.com>
 676
 677         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 678         when no wrap column is set.
 679
 680 2019-05-08  Tom Tromey  <tromey@adacore.com>
 681
 682         * c-lang.c (c_get_string): Handle non-C-style arrays.
 683
 684 2019-05-08  Tom Tromey  <tromey@adacore.com>
 685
 686         * typeprint.c (print_offset_data::update): Print the bit offset,
 687         not the number of bits remaining.
 688
 689 2019-05-08  Tom Tromey  <tromey@adacore.com>
 690
 691         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 692         padding at end of comment.
 693
 694 2019-05-08  Tom Tromey  <tromey@adacore.com>
 695
 696         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 697         Compare main types.
 698
 699 2019-05-06  Tom Tromey  <tom@tromey.com>
 700
 701         * common/scoped_mmap.c: Include common-defs.h.
 702         * common/scoped_mmap.h: Don't include config.h.
 703
 704 2019-05-04  Tom Tromey  <tom@tromey.com>
 705
 706         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 707         (struct aarch64_call_info): Add initializers.
 708         <si>: Now a std::vector.
 709         (pass_on_stack, aarch64_push_dummy_call): Update.
 710
 711 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 712             Tom Tromey  <tom@tromey.com>
 713
 714         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 715         (ppc_threads): Now a std::vector.  Now static.
 716         (hwdebug_find_thread_points_by_tid)
 717         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 718         Update.
 719
 720 2019-05-04  Tom Tromey  <tom@tromey.com>
 721
 722         * arc-tdep.c (arc_tdesc_init): Return bool.
 723
 724 2019-05-04  Tom Tromey  <tom@tromey.com>
 725
 726         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 727         Use gdb_assert_not_reached.
 728
 729 2019-05-04  Tom Tromey  <tom@tromey.com>
 730
 731         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 732         "false".
 733
 734 2019-05-04  Tom Tromey  <tom@tromey.com>
 735
 736         * arc-tdep.c (arc_tdesc_init): Use bool.
 737
 738 2019-05-04  Tom Tromey  <tom@tromey.com>
 739
 740         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 741
 742 2019-05-04  Tom Tromey  <tom@tromey.com>
 743
 744         * cli/cli-cmds.c (valid_command_p): Return bool.
 745
 746 2019-05-04  Tom Tromey  <tom@tromey.com>
 747
 748         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 749         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 750
 751 2019-05-04  Raul Tambre  <raul@tambre.ee>
 752
 753         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 754         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 755         operator for comparison.
 756
 757 2019-05-04  Tom Tromey  <tom@tromey.com>
 758
 759         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 760         (lookup_partial_symbol, print_partial_symbols)
 761         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 762         (psymbol_compare): Update.
 763         (add_psymbol_to_bcache): Clear the entire psymbol.
 764         (maintenance_check_psymtabs): Update.
 765         * psympriv.h (struct partial_symbol): Don't derive from
 766         general_symbol_info.
 767         <obj_section, unrelocated_address, address,
 768         set_unrelocated_address>: Update.
 769         <ginfo>: New member.
 770         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 771         (debug_names::write_psymbols): Update.
 772
 773 2019-05-04  Tom de Vries  <tdevries@suse.de>
 774
 775         * contrib/cc-with-tweaks.sh: Support -n arg.
 776
 777 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 778
 779         * corelow.c (core_target::detach): Ensure frame cache and
 780         register caches are cleared.
 781         inferior.c (exit_inferior_1): Likewise.
 782
 783 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 784             Tom Tromey  <tom@tromey.com>
 785
 786         * dictionary.c (collate_pending_symbols_by_language): Remove
 787         "struct" from foreach.
 788         * symtab.c (lookup_global_symbol_from_objfile)
 789         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 790         foreach.
 791         * ser-tcp.c (net_open): Remove "struct" from foreach.
 792         * objfiles.c (objfile_relocate, objfile_rebase)
 793         (objfile_has_symbols): Remove "struct" from foreach.
 794         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 795         from foreach.
 796         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 797         foreach.
 798         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 799         "struct" from foreach.
 800         * ada-lang.c (create_excep_cond_exprs)
 801         (ada_exception_catchpoint_cond_string): Remove "struct" from
 802         foreach.
 803
 804 2019-05-03  Tom Tromey  <tromey@adacore.com>
 805
 806         * ada-exp.y (convert_char_literal): Check suffix of each
 807         enumerator.
 808
 809 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 810
 811         PR ada/21406:
 812         * ada-exp.y (yywrap): Don't define.
 813         * ada-lex.l (%option): Add noyywrap
 814         (yywrap): Remove.
 815
 816 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 817
 818         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 819         _WIN32_WINNT to the XP level, unless already defined to a higher
 820         level.
 821
 822         * unittests/parse-connection-spec-selftests.c:
 823         * ser-tcp.c:
 824         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 825         override.
 826
 827         * symfile.c (find_separate_debug_file): Remove colon from the
 828         drive spec of DOS/Windows file names of the target, so that the
 829         file name produced from DEBUGDIR and the target's directory will
 830         be valid on DOS/Windows systems.
 831
 832 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 833
 834         * rust-lang.c (val_print_struct): Handle printing structures
 835         containing strings.
 836
 837 2019-05-02  Tom Tromey  <tromey@adacore.com>
 838
 839         * valarith.c (_initialize_valarith): Remove.
 840
 841 2019-05-01  Tom Tromey  <tromey@adacore.com>
 842
 843         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 844         bitfields.
 845
 846 2019-05-01  Tom Tromey  <tromey@adacore.com>
 847
 848         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 849         for big-endian copies.
 850
 851 2019-04-30  Ali Tamur  <tamur@google.com>
 852         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 853         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 854         (read_3_bytes): New function.
 855
 856 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 857
 858         * windows-nat.c (main_thread_id): Delete.
 859         (handle_output_debug_string): Replace main_thread_id by
 860         current_event.dwThreadId.
 861         (fake_create_process): Likewise.
 862         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 863         Do not set main_thread_id.
 864         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 865         current_event.dwThreadId.
 866         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 867
 868 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 869
 870         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 871         Use current_event.dwThreadId instead of main_thread_id.
 872
 873 2019-04-30  Tom Tromey  <tromey@adacore.com>
 874
 875         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 876         (create_excep_cond_exprs): Iterate over program spaces.
 877         (ada_exception_catchpoint_cond_string): Examine all minimal
 878         symbols for exception types.
 879
 880 2019-04-30  Tom Tromey  <tromey@adacore.com>
 881
 882         PR c++/24470:
 883         * dwarf2read.c (process_structure_scope): Handle case where type
 884         has template parameters but no symbol was created.
 885
 886 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 887             Chris January  <chris.january@arm.com>
 888
 889         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 890         qualifier.
 891         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 892
 893 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * f-typeprint.c (f_print_type): Update rules for printing
 896         whitespace.
 897         (f_type_print_varspec_suffix): Likewise.
 898
 899 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 900             Chris January  <chris.january@arm.com>
 901
 902         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 903         function arguments.
 904
 905 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * f-lang.c (build_fortran_types): Change name of void type to
 908         lower case.
 909         * f-typeprint.c (f_type_print_base): Print the name of the void
 910         type, rather than a fixed string.
 911         * f-valprint.c (f_decorations): Use lower case void string.
 912
 913 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 914             Chris January  <chris.january@arm.com>
 915
 916         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 917         types for Fortran.
 918
 919 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 920             Chris January  <chris.january@arm.com>
 921             David Lecomber  <david.lecomber@arm.com>
 922
 923         * f-exp.y (BINOP_INTRINSIC): New token.
 924         (exp): New parser rule handling BINOP_INTRINSIC.
 925         (f77_keywords): Add new builtin procedures.
 926         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 927         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 928         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 929         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 930         (print_unop_subexp_f): New function.
 931         (print_binop_subexp_f): New function.
 932         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 933         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 934         (dump_subexp_body_f): Likewise.
 935         (operator_check_f): Likewise.
 936         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 937         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 938
 939 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 942         UNOP_KIND.
 943         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 944         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 945         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 946         (operator_length_f): New fuction.
 947         (print_subexp_f): New function.
 948         (op_name_f): New function.
 949         (dump_subexp_body_f): New function.
 950         (operator_check_f): New function.
 951         (exp_descriptor_f): Replace standard expression handling functions
 952         with new functions.
 953         * gdb/fortran-operator.def: New file.
 954         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 955         * gdb/std-operator.def: Remove UNOP_KIND.
 956
 957 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 958
 959         * std-operator.def: Remove unbalanced, stray double quote
 960         character.
 961
 962 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 963             Chris January  <chris.january@arm.com>
 964             Daniel Everett  <daniel.everett@arm.com>
 965             Nick Forrington  <nick.forrington@arm.com>
 966             Richard Bunt  <richard.bunt@arm.com>
 967
 968         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 969         of depth when printing anonymous structs or unions.
 970         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 971         Don't print either the top-level value, or the children if the
 972         max-depth is exceeded.
 973         (ppscm_print_children): When printing the key of a map, allow one
 974         extra level of depth.
 975         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 976         print either the top-level value, or the children if the max-depth
 977         is exceeded.
 978         (print_children): When printing the key of a map, allow one extra
 979         level of depth.
 980         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 981         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 982         (user_print_options): Initialise max_depth field.
 983         (val_print_scalar_or_string_type_p): New function.
 984         (val_print): Check to see if the max depth has been reached.
 985         (val_print_check_max_depth): Define new function.
 986         (show_print_max_depth): New function.
 987         (_initialize_valprint): Add 'print max-depth' option.
 988         * valprint.h (struct value_print_options) <max_depth>: New field.
 989         (val_print_check_max_depth): Declare new function.
 990         * NEWS: Document new feature.
 991
 992 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 993
 994         * ada-lang.c (ada_language_defn): Initialise new field.
 995         * c-lang.c (c_is_string_type_p): New function.
 996         (c_language_defn): Initialise new field.
 997         (cplus_language_defn): Initialise new field.
 998         (asm_language_defn): Initialise new field.
 999         (minimal_language_defn): Initialise new field.
1000         * c-lang.h (c_is_string_type_p): Declare new function.
1001         * d-lang.c (d_language_defn): Initialise new field.
1002         * f-lang.c (f_is_string_type_p): New function.
1003         (f_language_defn): Initialise new field.
1004         * go-lang.c (go_is_string_type_p): New function.
1005         (go_language_defn): Initialise new field.
1006         * language.c (default_is_string_type_p): New function.
1007         (unknown_language_defn): Initialise new field.
1008         (auto_language_defn): Initialise new field.
1009         * language.h (struct language_defn) <la_is_string_type_p>: New
1010         member variable.
1011         (default_is_string_type_p): Declare new function.
1012         * m2-lang.c (m2_language_defn): Initialise new field.
1013         * objc-lang.c (objc_language_defn): Initialise new field.
1014         * opencl-lang.c (opencl_language_defn): Initialise new field.
1015         * p-lang.c (pascal_is_string_type_p): New function.
1016         (pascal_language_defn): Initialise new field.
1017         * rust-lang.c (rust_is_string_type_p): New function.
1018         (rust_language_defn): Initialise new field.
1019
1020 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1021
1022         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1023         New field.
1024         * ada-lang.c (ada_language_defn): Initialise new field.
1025         * c-lang.c (c_language_defn): Likewise.
1026         (cplus_language_defn): Likewise.
1027         (asm_language_defn): Likewise.
1028         (minimal_language_defn): Likewise.
1029         * d-lang.c (d_language_defn): Likewise.
1030         * f-lang.c (f_language_defn): Likewise.
1031         * go-lang.c (go_language_defn): Likewise.
1032         * language.c (unknown_language_defn): Likewise.
1033         (auto_language_defn): Likewise.
1034         * m2-lang.c (m2_language_defn): Likewise.
1035         * objc-lang.c (objc_language_defn): Likewise.
1036         * opencl-lang.c (opencl_language_defn): Likewise.
1037         * p-lang.c (pascal_language_defn): Likewise.
1038         * rust-lang.c (rust_language_defn): Likewise.
1039
1040 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * ada-lang.c (ada_is_character_type): Change return type to bool.
1043         (ada_is_string_type): Likewise.
1044         * ada-lang.h (ada_is_character_type): Update declaration
1045         (ada_is_string_type): Likewise.
1046
1047 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1048
1049         Support style in 'frame|thread apply'
1050
1051         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1052         * record.c (record_start, record_stop): Update callers of
1053         execute_command_to_string with false.
1054         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1055         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1056         methods.
1057         (class string_file): New constructor with term_out parameter.
1058         Override methods term_out and can_emit_style_escape.  New member
1059         term_out.
1060         (class stdio_file): Override can_emit_style_escape.
1061         (class tee_file): Override term_out and can_emit_style_escape.
1062         * utils.h (can_emit_style_escape): Remove.
1063         * utils.c (can_emit_style_escape): Likewise.
1064         Update all callers of can_emit_style_escape (SOMESTREAM) to
1065         SOMESTREAM->can_emit_style_escape.
1066         * source-cache.c (source_cache::get_source_lines): Likewise.
1067         * stack.c (frame_apply_command_count): Call execute_command_to_string
1068         passing the term_out characteristic of the current gdb_stdout.
1069         * thread.c (thr_try_catch_cmd): Likewise.
1070         * top.c (execute_command_to_string): pass term_out parameter
1071         to construct the string_file for the command output.
1072         * ui-file.c (term_cli_styling): New function (most code moved
1073         from utils.c can_emit_style_escape).
1074         (string_file::string_file, string_file::can_emit_style_escape,
1075         stdio_file::can_emit_style_escape, tee_file::term_out,
1076         tee_file::can_emit_style_escape): New functions.
1077
1078 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1079
1080         * NEWS: Mention the new set|show may-call-functions.
1081         * infcall.c (may_call_functions_p): New variable.
1082         (show_may_call_functions_p): New function.
1083         (call_function_by_hand_dummy): Throws an error if not
1084         may-call-functions.
1085         (_initialize_infcall): Call add_setshow_boolean_cmd for
1086         may-call-functions.
1087
1088 2019-04-25  Keith Seitz  <keiths@redhat.com>
1089
1090         PR c++/24367
1091         * cp-support.c (inspect_type): Don't attempt substitutions
1092         of symbol with the same name.
1093
1094 2019-04-25  Tom Tromey  <tromey@adacore.com>
1095
1096         PR gdb/24475:
1097         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1098         static.
1099
1100 2019-04-25  Tom Tromey  <tromey@adacore.com>
1101
1102         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1103         rvalue reference.
1104         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1105         (gdb_xml_parser::parse): Use std::move.
1106         * python/python-internal.h (gdbpy_convert_exception): Take a const
1107         reference.
1108         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1109         std::move.
1110         * python/py-utils.c (gdbpy_convert_exception): Take a const
1111         reference.
1112         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1113         Use std::move.
1114         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1115         Use std::move.
1116         * mi/mi-main.c (mi_print_exception): Take a const reference.
1117         * main.c (handle_command_errors): Take a const reference.
1118         * linespec.c (parse_linespec): Use std::move.
1119         * infcall.c (run_inferior_call): Use std::move.
1120         (call_function_by_hand_dummy): Use std::move.
1121         * exec.c (try_open_exec_file): Use std::move.
1122         * exceptions.h (exception_print, exception_fprintf)
1123         (exception_print_same): Update.
1124         * exceptions.c (print_exception, exception_print)
1125         (exception_fprintf, exception_print_same): Change parameters to
1126         const reference.
1127         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1128         * common/new-op.c: Use std::move.
1129         * common/common-exceptions.h (struct gdb_exception): Add move
1130         constructor.
1131         (struct gdb_exception_error, struct gdb_exception_quit, struct
1132         gdb_quit_bad_alloc): Change constructor to move constructor.
1133         (throw_exception): Change parameter to rvalue reference.
1134         * common/common-exceptions.c (throw_exception): Take rvalue
1135         reference.
1136         * cli/cli-interp.c (safe_execute_command): Use std::move.
1137         * breakpoint.c (insert_bp_location, location_to_sals): Use
1138         std::move.
1139
1140 2019-04-25  Tom Tromey  <tromey@adacore.com>
1141
1142         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1143         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1144         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1145         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1146         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1147         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1148         guile/scm-value.c: Use unpack.
1149         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1150         gdbscm_gdb_exception.
1151         (gdbscm_throw_gdb_exception): Likewise.
1152         (struct gdbscm_gdb_exception): New.
1153         (unpack): New function.
1154         (gdbscm_wrap): Use unpack.
1155
1156 2019-04-25  Tom Tromey  <tromey@adacore.com>
1157
1158         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1159         (gdb_rl_callback_handler): Use std::move.
1160         * common/common-exceptions.h (struct gdb_exception): Add move
1161         assignment operator.
1162         (throw_exception_sjlj): Change "exception" to const reference.
1163         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1164         (throw_exception_sjlj): Change "exception" to const reference.
1165
1166 2019-04-25  Tom Tromey  <tromey@adacore.com>
1167
1168         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1169         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1170         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1171         Update.
1172         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1173         Update.
1174         * mi/mi-interp.c (mi_interp::exec): Update.
1175         * linespec.c (parse_linespec): Update.
1176         * infcall.c (run_inferior_call): Update.
1177         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1178         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1179         (gdbscm_lookup_global_symbol): Update.
1180         * guile/scm-param.c (gdbscm_parameter_value): Update.
1181         * guile/scm-frame.c (gdbscm_frame_read_register)
1182         (gdbscm_frame_read_var): Update.
1183         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1184         * exec.c (try_open_exec_file): Update.
1185         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1186         (gdb_rl_callback_handler): Update.
1187         * common/common-exceptions.h (exception_none): Don't declare.
1188         * common/common-exceptions.c (exception_none): Don't define.
1189         (struct catcher) <exception>: Update.
1190         * cli/cli-interp.c (safe_execute_command): Update.
1191         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1192
1193 2019-04-25  Ali Tamur  <tamur@google.com>
1194
1195         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1196         (read_attribute_value): Likewise.
1197         (dwarf2_read_addr_index): Update comment.
1198         (read_str_index): Add DW_FORM_strx.
1199         (dwarf2_string_attr): Likewise.
1200         (dwarf2_const_value_attr): Likewise.
1201         (dump_die_shallow): Likewise.
1202         (dwarf2_fetch_constant_bytes): Likewise.
1203         (skip_form_bytes): Likewise.
1204         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1205
1206 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1207
1208         PR corefiles/11608
1209         PR corefiles/18187
1210         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1211         OFFSET.  Verify if current mapping contains an ELF header.
1212         (linux_find_memory_regions_full): Adjust call to
1213         dump_mapping_p.
1214
1215 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1216             Kang Li <kanglictf@gmail.com>
1217
1218         PR gdb/21600
1219
1220         * dwarf2-frame.c (read_initial_length): Be consistent about using
1221         unsigned representation of length.
1222         (decode_frame_entry_1): Likewise.  Check for wraparound of
1223         end pointer as well as buffer overflow.
1224
1225 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1226
1227         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1228         "vq".
1229
1230 2019-04-24  Tom Tromey  <tromey@adacore.com>
1231
1232         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1233
1234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * s12z-tdep.c (s12z_unwind_pc): Delete.
1237         (s12z_unwind_sp): Delete.
1238         (s12z_gdbarch_init): Don't register deleted functions with
1239         gdbarch.
1240
1241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * rl78-tdep.c (rl78_unwind_sp): Delete.
1244         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1245
1246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1249         (xstormy16_unwind_pc): Delete.
1250         (xstormy16_dummy_id): Delete.
1251         (xstormy16_gdbarch_init): Don't register deleted functions with
1252         gdbarch.
1253
1254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1255
1256         * vax-tdep.c (vax_unwind_pc): Delete.
1257         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1258
1259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1260
1261         * v850-tdep.c (v850_unwind_sp): Delete.
1262         (v850_unwind_pc): Delete.
1263         (v850_dummy_id): Delete.
1264         (v850_gdbarch_init): Don't register deleted functions with
1265         gdbarch.
1266
1267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1268
1269         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1270         (tilegx_unwind_pc): Delete.
1271         (tilegx_unwind_dummy_id): Delete.
1272         (tilegx_gdbarch_init): Don't register deleted functions with
1273         gdbarch.
1274
1275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1276
1277         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1278         (tic6x_dummy_id): Delete.
1279         (tic6x_gdbarch_init): Don't register deleted functions with
1280         gdbarch.
1281
1282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1283
1284         * sparc-tdep.c (sparc_unwind_pc): Delete.
1285         (sparc32_gdbarch_init): Don't register deleted function with
1286         gdbarch.
1287
1288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         * sh-tdep.c (sh_unwind_sp): Delete.
1291         (sh_unwind_pc): Delete.
1292         (sh_dummy_id): Delete.
1293         (sh_gdbarch_init): Don't register deleted functions with
1294         gdbarch.
1295
1296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1297
1298         * score-tdep.c (score_unwind_sp): Delete.
1299         (score_unwind_pc): Delete.
1300         (score_dummy_id): Delete.
1301         (score_gdbarch_init): Don't register deleted functions with
1302         gdbarch.
1303
1304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1305
1306         * rx-tdep.c (rx_unwind_pc): Delete.
1307         (rx_unwind_sp): Delete.
1308         (rx_dummy_id): Delete.
1309         (rx_gdbarch_init): Don't register deleted functions with
1310         gdbarch.  Update comment.
1311
1312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1313
1314         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1315         (rs6000_dummy_id): Delete.
1316         (rs6000_gdbarch_init): Don't register deleted functions with
1317         gdbarch.
1318
1319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * or1k-tdep.c (or1k_dummy_id): Delete.
1322         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1323
1324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * nios2-tdep.c (nios2_dummy_id): Delete.
1327         (nios2_unwind_sp): Delete.
1328         (nios2_gdbarch_init): Don't register deleted functions with
1329         gdbarch.
1330
1331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1332
1333         * nds32-tdep.c (nds32_dummy_id): Delete.
1334         (nds32_unwind_pc): Delete.
1335         (nds32_unwind_sp): Delete.
1336         (nds32_gdbarch_init): Don't register deleted functions with
1337         gdbarch.
1338
1339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1340
1341         * msp430-tdep.c (msp430_unwind_pc): Delete.
1342         (msp430_unwind_sp): Delete.
1343         (msp430_dummy_id): Delete.
1344         (msp430_gdbarch_init): Don't register deleted functions with
1345         gdbarch.
1346
1347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * moxie-tdep.c (moxie_unwind_sp): Delete.
1350         (moxie_unwind_pc): Delete.
1351         (moxie_dummy_id): Delete.
1352         (moxie_gdbarch_init): Don't register deleted functions with
1353         gdbarch.
1354
1355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1356
1357         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1358         (mn10300_unwind_pc): Delete.
1359         (mn10300_unwind_sp): Delete.
1360         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1361         mn10300_unwind_sp.
1362         (mn10300_frame_unwind_init): Don't register deleted functions with
1363         gdbarch.
1364
1365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1366
1367         * mep-tdep.c (mep_unwind_pc): Delete.
1368         (mep_unwind_sp): Delete.
1369         (mep_dummy_id): Delete.
1370         (mep_gdbarch_init): Don't register deleted functions with
1371         gdbarch.
1372
1373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1374
1375         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1376         (m68hc11_unwind_sp): Delete.
1377         (m68hc11_gdbarch_init): Don't register deleted functions with
1378         gdbarch.
1379
1380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * m32r-tdep.c (m32r_unwind_sp): Delete.
1383         (m32r_unwind_pc): Delete.
1384         (m32r_dummy_id): Delete.
1385         (m32r_gdbarch_init): Don't register deleted functions with
1386         gdbarch.
1387
1388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1389
1390         * m32c-tdep.c (m32c_unwind_pc): Delete.
1391         (m32c_unwind_sp): Delete.
1392         (m32c_dummy_id): Delete.
1393         (m32c_gdbarch_init): Don't register deleted functions with
1394         gdbarch.
1395
1396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1397
1398         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1399         (lm32_unwind_pc): Delete.
1400         (lm32_dummy_id): Delete.
1401         (lm32_gdbarch_init): Don't register deleted functions with
1402         gdbarch.
1403
1404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1405
1406         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1407         (iq2000_unwind_pc): Delete.
1408         (iq2000_dummy_id): Delete.
1409         (iq2000_gdbarch_init): Don't register deleted functions with
1410         gdbarch.
1411
1412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1413
1414         * nds32-tdep.c (nds32_type_align): Delete.
1415         (nds32_push_dummy_call): Use type_align instead.
1416
1417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1418
1419         * arm-tdep.c (arm_type_align): Only handle vector override case.
1420         (arm_push_dummy_call): Use type_align.
1421         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1422
1423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1424
1425         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1426         case.
1427         (pass_on_stack): Use type_align.
1428         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1429         function.
1430
1431 2019-04-23  Tom Tromey  <tromey@adacore.com>
1432
1433         * dwarf2read.c (line_header::file_name_at): Remove unused
1434         overload.
1435
1436 2019-04-23  Tom de Vries  <tdevries@suse.de>
1437
1438         PR gdb/24438
1439         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1440         invocation.
1441
1442
1443 2019-03-27  Ali Tamur  <tamur@google.com>
1444
1445         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1446         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1447         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1448         (dwarf_expr_context::get_addr_index): Likewise
1449         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1450         (symbol_needs_eval_context::get_addr_index): Likewise
1451         (disassemble_dwarf_expression): Add DW_OP_addrx
1452         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1453         (read_cutu_die_from_dwo): Update comment
1454         (skip_one_die): Add DW_FORM_addrx
1455         (read_attribute_value): Likewise
1456         (var_decode_location): Add DW_OP_addrx
1457         (dwarf2_const_value_attr): Add DW_FORM_addrx
1458         (dump_die_shallow): Likewise
1459         (dwarf2_fetch_constant_bytes): Likewise
1460         (decode_locdesc): Add DW_OP_addrx
1461         (skip_form_bytes): Add DW_FORM_addrx
1462
1463 2019-04-22  Ali Tamur  <tamur@google.com>
1464
1465         * MAINTAINERS (Write After Approval): Add self.
1466
1467 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1468
1469         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1470         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1471         (open_symbol_file_object): Likewise.
1472         (svr4_default_sos): Add info parameter.
1473         (svr4_read_so_list): Likewise.
1474         (svr4_current_sos_direct): Adjust functions calls to pass down
1475         info.
1476         (svr4_current_sos_1): Add info parameter.
1477         (svr4_current_sos): Call get_svr4_info, pass info down to
1478         svr4_current_sos_1.
1479         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1480         get_svr4_info.
1481         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1482         get_svr4_info.
1483         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1484         to get_svr4_info.
1485         (probes_table_remove_objfile_probes): Likewise.
1486         (register_solib_event_probe): Add info parameter.
1487         (solist_update_incremental): Pass info parameter down to
1488         svr4_read_so_list.
1489         (disable_probes_interface): Add info parameter.
1490         (svr4_handle_solib_event): Pass current_program_space to
1491         get_svr4_info.  Adjust disable_probes_interface cleanup.
1492         (svr4_create_probe_breakpoints): Add info parameter, pass it
1493         down to register_solib_event_probe.
1494         (svr4_create_solib_event_breakpoints): Add info parameter,
1495         pass it down to svr4_create_probe_breakpoints.
1496         (enable_break): Pass info down to
1497         svr4_create_solib_event_breakpoints.
1498         (svr4_solib_create_inferior_hook): Pass current_program_space to
1499         get_svr4_info.
1500         (svr4_clear_solib): Likewise.
1501
1502 2019-04-22  Pedro Alves  <palves@redhat.com>
1503
1504         * solib-svr4.c (svr4_free_objfile_observer): New.
1505         (probe_and_action::objfile): New field.
1506         (probes_table_htab_remove_objfile_probes)
1507         (probes_table_remove_objfile_probes): New functions.
1508         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1509         in the new probe_and_action.  Don't store the probe in 'lookup'.
1510         (svr4_create_probe_breakpoints): Pass objfile to
1511         register_solib_event_probe.
1512         (_initialize_svr4_solib): Register a free_objfile observer.
1513
1514 2019-04-19  Tom Tromey  <tom@tromey.com>
1515
1516         * common/queue.h: Remove.
1517
1518 2019-04-19  Tom Tromey  <tom@tromey.com>
1519
1520         * event-loop.c: Don't include "common/queue.h".
1521
1522 2019-04-19  Tom Tromey  <tom@tromey.com>
1523
1524         * remote.c (remote_target): Use delete.
1525         * remote-notif.h: Include <list>, not "common/queue.h".
1526         (notif_client_p): Remove typedef.
1527         (remote_notif_state): Add constructor, destructor, initializer.
1528         <notif_queue>: Now a std::list.
1529         (remote_notif_state_xfree): Don't declare.
1530         * remote-notif.c (remote_notif_process, handle_notification)
1531         (remote_notif_state_allocate): Update.
1532         (~remote_notif_state): Rename from remote_notif_state_xfree.
1533
1534 2019-04-19  Tom Tromey  <tom@tromey.com>
1535
1536         * symfile.c (reread_symbols): Update.
1537         * objfiles.c (objfile_register_static_link)
1538         (objfile_lookup_static_link): Update
1539         (~objfile) Don't delete static_links.
1540         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1541
1542 2019-04-19  Tom Tromey  <tom@tromey.com>
1543
1544         * type-stack.h (struct type_stack) <insert>: Constify string.
1545         * type-stack.c (type_stack::insert): Constify string.
1546         * gdbtypes.h (lookup_template_type): Update.
1547         (address_space_name_to_int): Update.
1548         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1549         const.
1550         (lookup_template_type): Make name const.
1551         * c-exp.y: Update rules.
1552         (lex_one_token, classify_name, classify_inner_name)
1553         (c_print_token): Update.
1554         * p-exp.y: Update rules.
1555         (yylex): Update.
1556         * f-exp.y: Update rules.
1557         (yylex): Update.
1558         * d-exp.y: Update rules.
1559         (lex_one_token, classify_name, classify_inner_name): Update.
1560         * parse.c (write_dollar_variable, copy_name): Return std::string.
1561         * parser-defs.h (copy_name): Change return type.
1562         * m2-exp.y: Update rules.
1563         (yylex): Update.
1564         * go-exp.y (lex_one_token): Update.
1565         Update rules.
1566         (classify_unsafe_function, classify_packaged_name)
1567         (classify_name, yylex): Update.
1568
1569 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1570
1571         * configure.ac: add --enable-source-highlight switch.
1572         * configure: Regenerate.
1573         * top.c (print_gdb_version): plumb --enable-source-highlight
1574         status to "show configuration".
1575
1576 2019-04-19  Tom Tromey  <tromey@adacore.com>
1577
1578         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1579         Check ADA_TYPE_P.
1580         (empty_record, ada_template_to_fixed_record_type_1)
1581         (template_to_static_fixed_type)
1582         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1583         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1584         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1585         macros.
1586
1587 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1588
1589         PR symtab/24423:
1590         * source.c (print_source_lines_base): Advance "iter" when a
1591         control character is seen.
1592
1593 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1594
1595         * inferior.h (struct infcall_suspend_state_deleter):
1596         Catch exception in destructor to avoid crash.
1597
1598 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1599
1600         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1601         close to the add_com "shell".
1602
1603 2019-04-18  Tom Tromey  <tromey@adacore.com>
1604
1605         * process-stratum-target.h (class process_stratum_target)
1606         <stratum>: Add "final".
1607
1608 2019-04-17  Tom Tromey  <tromey@adacore.com>
1609
1610         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1611         against nullptr before use.
1612
1613 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1614
1615         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1616
1617 2019-04-17  Jim Wilson  <jimw@sifive.com>
1618             Andrew Burgess  <andrew.burgess@embecosm.com>
1619
1620         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1621         code read might fail, assume 4-byte breakpoint in that case.
1622
1623 2019-04-15  Leszek Swirski  <leszeks@google.com>
1624
1625         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1626         rather than a hand-rolled POD check when checking for forced MEMORY
1627         classification.
1628
1629 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1630
1631         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1632         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1633         function.
1634         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1635         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1636         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1637         declaration.
1638
1639 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1640
1641         * aarch64-linux-nat.c
1642         (aarch64_linux_nat_target::thread_architecture): Add override.
1643         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1644         each VQ.
1645
1646 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1647
1648         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1649
1650 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1651
1652         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1653         target types of size 96-bits, add some additional comments, and
1654         check that the builtin type we found was the correct size.
1655
1656 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1657
1658         * utils.c (prompt_for_continue): Don't restore the styling at the
1659         end, as applied_style has the wrong value.  This fixes styling in
1660         long lists of file names that are interrupted by the "Continue?"
1661         prompt.
1662
1663 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1664
1665         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1666         * c-lang.c (c_language_defn): Likewise.
1667         (cplus_language_defn): Likewise.
1668         (asm_language_defn): Likewise.
1669         (minimal_language_defn): Likewise.
1670         * d-lang.c (d_language_defn): Likewise.
1671         * f-lang.c (f_language_defn): Likewise.
1672         * go-lang.c (go_language_defn): Likewise.
1673         * language.c (unknown_language_defn): Likewise.
1674         (auto_language_defn): Likewise.
1675         * language.h (struct language_defn): Remove la_magic field.
1676         (LANG_MAGIC): Delete.
1677         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1678         * objc-lang.c (objc_language_defn): Likewise.
1679         * opencl-lang.c (opencl_language_defn): Likewise.
1680         * p-lang.c (pascal_language_defn): Likewise.
1681         * rust-lang.c (rust_language_defn): Likewise.
1682
1683 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1684
1685         * riscv-tdep.c (riscv_type_align): New function.
1686         (riscv_type_alignment): Delete.
1687         (riscv_arg_location): Use 'type_align'.
1688         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1689
1690 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1691
1692         * gdbtypes.c (type_align): A struct with no non-static fields also
1693         has alignment of 1.
1694
1695 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1696
1697         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1698         component to 0.
1699         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1700         member.
1701         (riscv_struct_info::analyse): New implementation using new
1702         analyse_inner member function.
1703         (riscv_struct_info::field_offset): New member function.
1704         (riscv_struct_info::m_offsets): New member variable.
1705         (riscv_struct_info::analyse_inner): New private member function,
1706         takes the old implementation of riscv_struct_info::analyse but
1707         extended to track field offsets.
1708         (riscv_call_arg_struct): Update the struct folding special cases
1709         to handle cases where empty C++ structs, which are non-zero
1710         length, are found.
1711         (riscv_arg_location): Initialise the length of each location, a
1712         non-zero length now indicates the location is in use.
1713         (riscv_push_dummy_call): Allow for the first location having a
1714         non-zero offset when setting up arguments.
1715         (riscv_return_value): Likewise, but for return values.
1716
1717 2019-04-11  Tom Tromey  <tromey@adacore.com>
1718
1719         * utils.c (internal_vproblem): Make "msg" const.
1720
1721 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1722
1723         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1724         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1725         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1726         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1727
1728 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1729
1730         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1731         function.
1732         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1733         of amd64_collect_native_gregset.
1734         (amd64_linux_nat_target::store_registers): Likewise.
1735
1736 2019-04-10  Tom Tromey  <tom@tromey.com>
1737
1738         * symtab.c (lookup_global_symbol_from_objfile)
1739         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1740         * objfiles.h (class separate_debug_iterator): New.
1741         (class separate_debug_range): New.
1742         (struct objfile) <separate_debug_objfiles>: New method.
1743         (objfile_separate_debug_iterate): Don't declare.
1744         * objfiles.c (separate_debug_iterator::operator++): Rename from
1745         objfile_separate_debug_iterate.
1746         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1747         iterator.
1748         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1749         iterator.
1750
1751 2019-04-10  Tom Tromey  <tom@tromey.com>
1752
1753         * symfile.c (reread_symbols): Remove old comment.
1754         * objfiles.c (free_all_objfiles): Fix a typo.
1755
1756 2019-04-10  Tom Tromey  <tom@tromey.com>
1757
1758         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1759         * minsyms.c (lookup_minimal_symbol): Use foreach.
1760         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1761         (lookup_minimal_symbol_solib_trampoline): Likewise.
1762         * symfile.c (reread_symbols): Use foreach.
1763
1764 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1765             Tom Tromey  <tromey@adacore.com>
1766
1767         PR rust/24414:
1768         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1769         (rust_lex_int_test): Change "value" to be LONGEST.
1770         (rust_lex_tests): Add test for long integer literal.
1771
1772 2019-04-09  Tom Tromey  <tromey@adacore.com>
1773
1774         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1775         to bool.
1776         (extended_remote_target::attach): Update.
1777         (remote_target::remote_notice_new_inferior): Update.
1778         (remote_target::add_current_inferior_and_thread): Update.
1779         * inferior.c (exit_inferior_1): Use "false".
1780         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1781
1782 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1783
1784         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1785         the "start" command.
1786
1787 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1788
1789         * python/py-inferior.c (infpy_thread_from_thread_handle):
1790         Adjust comments to reflect renaming of thread_from_thread_handle
1791         to thread_from_handle.  Adjust keywords.  Fix type error message.
1792         (inferior_object_methods): Add thread_from_handle.  Retain
1793         thread_from_thread_handle, but mark it as deprecated.
1794
1795 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1796
1797         * gdbthread.h (find_thread_by_handle): Revise declaration.
1798         * thread.c (find_thread_by_handle): Likewise.  Adjust
1799         implementation too.
1800         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1801         support for buffer objects as handles.
1802
1803 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1804
1805         * python/py-infthread.c (thpy_thread_handle): New function.
1806         (thread_object_methods): Register thpy_thread_handle.
1807
1808 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1809
1810         * gdbthread.h (thread_to_thread_handle): Declare.
1811         * thread.c (gdbtypes.h): Include.
1812         (thread_to_thread_handle): New function.
1813
1814         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1815         (target_thread_info_to_thread_handle): Declare.
1816         * target.c (target_thread_info_to_thread_handle): New function.
1817         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1818         * target-delegates.c: Regenerate.
1819
1820         * linux-thread-db.c (class thread_db_target): Add method
1821         thread_info_to_thread_handle.
1822         (thread_db_target::thread_info_to_thread_handle): Define.
1823         * remote.c (class remote_target): Add new method
1824         thread_info_to_thread_handle.
1825         (remote_target::thread_info_to_thread_handle): Define.
1826
1827 2019-04-08  Pedro Alves  <palves@redhat.com>
1828
1829         * common/common-exceptions.c (throw_exception): Don't create
1830         named object to throw; throw directly.
1831         (throw_it): Likewise.  Don't initialize gdb_exception::message
1832         here, with new; pass FMT and AP to the ctor instead.
1833         * common/common-exceptions.h: Include <string>.
1834         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1835         const char *, va_list)): New ctor.  Use std::make_shared.
1836         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1837         errors)): Delete.
1838         (gdb_exception_error::gdb_exception_error(enum errors, const char
1839         *, va_list)): New.
1840         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1841         Add assertion.
1842         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1843         errors)): Delete.
1844         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1845         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1846         Add assertion.
1847
1848 2019-04-08  Tom Tromey  <tom@tromey.com>
1849
1850         * valops.c (value_rtti_indirect_type): Replace throw_exception
1851         with throw.
1852         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1853         with throw.
1854         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1855         throw.
1856         * target.c (target_translate_tls_address): Replace throw_exception
1857         with throw.
1858         * stack.c (frame_apply_command_count): Replace throw_exception
1859         with throw.
1860         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1861         throw.
1862         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1863         with throw.
1864         * rs6000-tdep.c (rs6000_frame_cache)
1865         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1866         * remote.c: Replace throw_exception with throw.
1867         * record-full.c (record_full_message, record_full_wait_1)
1868         (record_full_restore): Replace throw_exception with throw.
1869         * record-btrace.c:
1870         (get_thread_current_frame_id, record_btrace_start_replaying)
1871         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1872         (cmd_record_btrace_start): Replace throw_exception with throw.
1873         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1874         throw.
1875         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1876         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1877         * linespec.c:
1878         (find_linespec_symbols): Replace throw_exception with throw.
1879         * infrun.c (displaced_step_prepare, resume): Replace
1880         throw_exception with throw.
1881         * infcmd.c (post_create_inferior): Replace throw_exception with
1882         throw.
1883         * inf-loop.c (inferior_event_handler): Replace throw_exception
1884         with throw.
1885         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1886         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1887         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1888         (get_prev_frame_always, get_frame_pc_if_available)
1889         (get_frame_address_in_block_if_available, get_frame_language):
1890         Replace throw_exception with throw.
1891         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1892         throw_exception with throw.
1893         * eval.c (fetch_subexp_value, evaluate_var_value)
1894         (evaluate_funcall, evaluate_subexp_standard): Replace
1895         throw_exception with throw.
1896         * dwarf2loc.c (call_site_find_chain)
1897         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1898         Replace throw_exception with throw.
1899         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1900         with throw.
1901         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1902         throw.
1903         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1904         * completer.c (complete_line_internal): Replace throw_exception
1905         with throw.
1906         * compile/compile-object-run.c (compile_object_run): Replace
1907         throw_exception with throw.
1908         * cli/cli-script.c (process_next_line): Replace throw_exception
1909         with throw.
1910         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1911         (btrace_enable, btrace_maint_update_pt_packets): Replace
1912         throw_exception with throw.
1913         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1914         throw_exception with throw.
1915         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1916         throw_exception with throw.
1917         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1918         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1919         * aarch64-tdep.c (aarch64_make_prologue_cache)
1920         (aarch64_make_stub_cache): Replace throw_exception with throw.
1921
1922 2019-04-08  Tom Tromey  <tom@tromey.com>
1923
1924         * common/common-exceptions.c (throw_exception): Rename from
1925         throw_exception_cxx.  Remove old copy.  Make argument const.
1926         (throw_it): Create and throw exception objects directly.
1927         * common/common-exceptions.h (throw_exception): Make argument
1928         const.
1929         (struct gdb_exception_error): Add constructor.
1930         (struct gdb_exception_quit): Add constructor.
1931
1932 2019-04-08  Tom Tromey  <tom@tromey.com>
1933
1934         * common/common-exceptions.h (exception_rethrow): Don't declare.
1935         (TRY_SJLJ): Update comment.
1936         (TRY, CATCH, END_CATCH): Remove.
1937         * common/common-exceptions.c (exception_rethrow): Remove.
1938
1939 2019-04-08  Tom Tromey  <tom@tromey.com>
1940
1941         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1942         Remove.
1943         (gdb_exception_error): Rename from
1944         gdb_exception_RETURN_MASK_ERROR.
1945         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1946         (gdb_quit_bad_alloc): Update.
1947         * aarch64-tdep.c: Update.
1948         * ada-lang.c: Update.
1949         * ada-typeprint.c: Update.
1950         * ada-valprint.c: Update.
1951         * amd64-tdep.c: Update.
1952         * arch-utils.c: Update.
1953         * break-catch-throw.c: Update.
1954         * breakpoint.c: Update.
1955         * btrace.c: Update.
1956         * c-varobj.c: Update.
1957         * cli/cli-cmds.c: Update.
1958         * cli/cli-interp.c: Update.
1959         * cli/cli-script.c: Update.
1960         * common/common-exceptions.c: Update.
1961         * common/new-op.c: Update.
1962         * common/selftest.c: Update.
1963         * compile/compile-c-symbols.c: Update.
1964         * compile/compile-cplus-symbols.c: Update.
1965         * compile/compile-object-load.c: Update.
1966         * compile/compile-object-run.c: Update.
1967         * completer.c: Update.
1968         * corelow.c: Update.
1969         * cp-abi.c: Update.
1970         * cp-support.c: Update.
1971         * cp-valprint.c: Update.
1972         * darwin-nat.c: Update.
1973         * disasm-selftests.c: Update.
1974         * dtrace-probe.c: Update.
1975         * dwarf-index-cache.c: Update.
1976         * dwarf-index-write.c: Update.
1977         * dwarf2-frame-tailcall.c: Update.
1978         * dwarf2-frame.c: Update.
1979         * dwarf2loc.c: Update.
1980         * dwarf2read.c: Update.
1981         * eval.c: Update.
1982         * event-loop.c: Update.
1983         * event-top.c: Update.
1984         * exec.c: Update.
1985         * f-valprint.c: Update.
1986         * fbsd-tdep.c: Update.
1987         * frame-unwind.c: Update.
1988         * frame.c: Update.
1989         * gdbtypes.c: Update.
1990         * gnu-v3-abi.c: Update.
1991         * guile/guile-internal.h: Update.
1992         * guile/scm-block.c: Update.
1993         * guile/scm-breakpoint.c: Update.
1994         * guile/scm-cmd.c: Update.
1995         * guile/scm-disasm.c: Update.
1996         * guile/scm-frame.c: Update.
1997         * guile/scm-lazy-string.c: Update.
1998         * guile/scm-math.c: Update.
1999         * guile/scm-param.c: Update.
2000         * guile/scm-ports.c: Update.
2001         * guile/scm-pretty-print.c: Update.
2002         * guile/scm-symbol.c: Update.
2003         * guile/scm-symtab.c: Update.
2004         * guile/scm-type.c: Update.
2005         * guile/scm-value.c: Update.
2006         * i386-linux-tdep.c: Update.
2007         * i386-tdep.c: Update.
2008         * inf-loop.c: Update.
2009         * infcall.c: Update.
2010         * infcmd.c: Update.
2011         * infrun.c: Update.
2012         * jit.c: Update.
2013         * language.c: Update.
2014         * linespec.c: Update.
2015         * linux-fork.c: Update.
2016         * linux-nat.c: Update.
2017         * linux-tdep.c: Update.
2018         * linux-thread-db.c: Update.
2019         * main.c: Update.
2020         * mi/mi-cmd-break.c: Update.
2021         * mi/mi-cmd-stack.c: Update.
2022         * mi/mi-interp.c: Update.
2023         * mi/mi-main.c: Update.
2024         * objc-lang.c: Update.
2025         * p-valprint.c: Update.
2026         * parse.c: Update.
2027         * ppc-linux-tdep.c: Update.
2028         * printcmd.c: Update.
2029         * python/py-arch.c: Update.
2030         * python/py-breakpoint.c: Update.
2031         * python/py-cmd.c: Update.
2032         * python/py-finishbreakpoint.c: Update.
2033         * python/py-frame.c: Update.
2034         * python/py-framefilter.c: Update.
2035         * python/py-gdb-readline.c: Update.
2036         * python/py-inferior.c: Update.
2037         * python/py-infthread.c: Update.
2038         * python/py-lazy-string.c: Update.
2039         * python/py-linetable.c: Update.
2040         * python/py-objfile.c: Update.
2041         * python/py-param.c: Update.
2042         * python/py-prettyprint.c: Update.
2043         * python/py-progspace.c: Update.
2044         * python/py-record-btrace.c: Update.
2045         * python/py-record.c: Update.
2046         * python/py-symbol.c: Update.
2047         * python/py-type.c: Update.
2048         * python/py-unwind.c: Update.
2049         * python/py-utils.c: Update.
2050         * python/py-value.c: Update.
2051         * python/python.c: Update.
2052         * record-btrace.c: Update.
2053         * record-full.c: Update.
2054         * remote-fileio.c: Update.
2055         * remote.c: Update.
2056         * riscv-tdep.c: Update.
2057         * rs6000-aix-tdep.c: Update.
2058         * rs6000-tdep.c: Update.
2059         * rust-exp.y: Update.
2060         * rust-lang.c: Update.
2061         * s390-tdep.c: Update.
2062         * selftest-arch.c: Update.
2063         * solib-dsbt.c: Update.
2064         * solib-frv.c: Update.
2065         * solib-spu.c: Update.
2066         * solib-svr4.c: Update.
2067         * solib.c: Update.
2068         * sparc64-linux-tdep.c: Update.
2069         * stack.c: Update.
2070         * symfile-mem.c: Update.
2071         * symmisc.c: Update.
2072         * target.c: Update.
2073         * thread.c: Update.
2074         * top.c: Update.
2075         * tracefile-tfile.c: Update.
2076         * tui/tui.c: Update.
2077         * typeprint.c: Update.
2078         * unittests/cli-utils-selftests.c: Update.
2079         * unittests/parse-connection-spec-selftests.c: Update.
2080         * valops.c: Update.
2081         * valprint.c: Update.
2082         * value.c: Update.
2083         * varobj.c: Update.
2084         * windows-nat.c: Update.
2085         * x86-linux-nat.c: Update.
2086         * xml-support.c: Update.
2087
2088 2019-04-08  Tom Tromey  <tom@tromey.com>
2089
2090         * xml-support.c: Use C++ exception handling.
2091         * x86-linux-nat.c: Use C++ exception handling.
2092         * windows-nat.c: Use C++ exception handling.
2093         * varobj.c: Use C++ exception handling.
2094         * value.c: Use C++ exception handling.
2095         * valprint.c: Use C++ exception handling.
2096         * valops.c: Use C++ exception handling.
2097         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2098         handling.
2099         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2100         * typeprint.c: Use C++ exception handling.
2101         * tui/tui.c: Use C++ exception handling.
2102         * tracefile-tfile.c: Use C++ exception handling.
2103         * top.c: Use C++ exception handling.
2104         * thread.c: Use C++ exception handling.
2105         * target.c: Use C++ exception handling.
2106         * symmisc.c: Use C++ exception handling.
2107         * symfile-mem.c: Use C++ exception handling.
2108         * stack.c: Use C++ exception handling.
2109         * sparc64-linux-tdep.c: Use C++ exception handling.
2110         * solib.c: Use C++ exception handling.
2111         * solib-svr4.c: Use C++ exception handling.
2112         * solib-spu.c: Use C++ exception handling.
2113         * solib-frv.c: Use C++ exception handling.
2114         * solib-dsbt.c: Use C++ exception handling.
2115         * selftest-arch.c: Use C++ exception handling.
2116         * s390-tdep.c: Use C++ exception handling.
2117         * rust-lang.c: Use C++ exception handling.
2118         * rust-exp.y: Use C++ exception handling.
2119         * rs6000-tdep.c: Use C++ exception handling.
2120         * rs6000-aix-tdep.c: Use C++ exception handling.
2121         * riscv-tdep.c: Use C++ exception handling.
2122         * remote.c: Use C++ exception handling.
2123         * remote-fileio.c: Use C++ exception handling.
2124         * record-full.c: Use C++ exception handling.
2125         * record-btrace.c: Use C++ exception handling.
2126         * python/python.c: Use C++ exception handling.
2127         * python/py-value.c: Use C++ exception handling.
2128         * python/py-utils.c: Use C++ exception handling.
2129         * python/py-unwind.c: Use C++ exception handling.
2130         * python/py-type.c: Use C++ exception handling.
2131         * python/py-symbol.c: Use C++ exception handling.
2132         * python/py-record.c: Use C++ exception handling.
2133         * python/py-record-btrace.c: Use C++ exception handling.
2134         * python/py-progspace.c: Use C++ exception handling.
2135         * python/py-prettyprint.c: Use C++ exception handling.
2136         * python/py-param.c: Use C++ exception handling.
2137         * python/py-objfile.c: Use C++ exception handling.
2138         * python/py-linetable.c: Use C++ exception handling.
2139         * python/py-lazy-string.c: Use C++ exception handling.
2140         * python/py-infthread.c: Use C++ exception handling.
2141         * python/py-inferior.c: Use C++ exception handling.
2142         * python/py-gdb-readline.c: Use C++ exception handling.
2143         * python/py-framefilter.c: Use C++ exception handling.
2144         * python/py-frame.c: Use C++ exception handling.
2145         * python/py-finishbreakpoint.c: Use C++ exception handling.
2146         * python/py-cmd.c: Use C++ exception handling.
2147         * python/py-breakpoint.c: Use C++ exception handling.
2148         * python/py-arch.c: Use C++ exception handling.
2149         * printcmd.c: Use C++ exception handling.
2150         * ppc-linux-tdep.c: Use C++ exception handling.
2151         * parse.c: Use C++ exception handling.
2152         * p-valprint.c: Use C++ exception handling.
2153         * objc-lang.c: Use C++ exception handling.
2154         * mi/mi-main.c: Use C++ exception handling.
2155         * mi/mi-interp.c: Use C++ exception handling.
2156         * mi/mi-cmd-stack.c: Use C++ exception handling.
2157         * mi/mi-cmd-break.c: Use C++ exception handling.
2158         * main.c: Use C++ exception handling.
2159         * linux-thread-db.c: Use C++ exception handling.
2160         * linux-tdep.c: Use C++ exception handling.
2161         * linux-nat.c: Use C++ exception handling.
2162         * linux-fork.c: Use C++ exception handling.
2163         * linespec.c: Use C++ exception handling.
2164         * language.c: Use C++ exception handling.
2165         * jit.c: Use C++ exception handling.
2166         * infrun.c: Use C++ exception handling.
2167         * infcmd.c: Use C++ exception handling.
2168         * infcall.c: Use C++ exception handling.
2169         * inf-loop.c: Use C++ exception handling.
2170         * i386-tdep.c: Use C++ exception handling.
2171         * i386-linux-tdep.c: Use C++ exception handling.
2172         * guile/scm-value.c: Use C++ exception handling.
2173         * guile/scm-type.c: Use C++ exception handling.
2174         * guile/scm-symtab.c: Use C++ exception handling.
2175         * guile/scm-symbol.c: Use C++ exception handling.
2176         * guile/scm-pretty-print.c: Use C++ exception handling.
2177         * guile/scm-ports.c: Use C++ exception handling.
2178         * guile/scm-param.c: Use C++ exception handling.
2179         * guile/scm-math.c: Use C++ exception handling.
2180         * guile/scm-lazy-string.c: Use C++ exception handling.
2181         * guile/scm-frame.c: Use C++ exception handling.
2182         * guile/scm-disasm.c: Use C++ exception handling.
2183         * guile/scm-cmd.c: Use C++ exception handling.
2184         * guile/scm-breakpoint.c: Use C++ exception handling.
2185         * guile/scm-block.c: Use C++ exception handling.
2186         * guile/guile-internal.h: Use C++ exception handling.
2187         * gnu-v3-abi.c: Use C++ exception handling.
2188         * gdbtypes.c: Use C++ exception handling.
2189         * frame.c: Use C++ exception handling.
2190         * frame-unwind.c: Use C++ exception handling.
2191         * fbsd-tdep.c: Use C++ exception handling.
2192         * f-valprint.c: Use C++ exception handling.
2193         * exec.c: Use C++ exception handling.
2194         * event-top.c: Use C++ exception handling.
2195         * event-loop.c: Use C++ exception handling.
2196         * eval.c: Use C++ exception handling.
2197         * dwarf2read.c: Use C++ exception handling.
2198         * dwarf2loc.c: Use C++ exception handling.
2199         * dwarf2-frame.c: Use C++ exception handling.
2200         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2201         * dwarf-index-write.c: Use C++ exception handling.
2202         * dwarf-index-cache.c: Use C++ exception handling.
2203         * dtrace-probe.c: Use C++ exception handling.
2204         * disasm-selftests.c: Use C++ exception handling.
2205         * darwin-nat.c: Use C++ exception handling.
2206         * cp-valprint.c: Use C++ exception handling.
2207         * cp-support.c: Use C++ exception handling.
2208         * cp-abi.c: Use C++ exception handling.
2209         * corelow.c: Use C++ exception handling.
2210         * completer.c: Use C++ exception handling.
2211         * compile/compile-object-run.c: Use C++ exception handling.
2212         * compile/compile-object-load.c: Use C++ exception handling.
2213         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2214         * compile/compile-c-symbols.c: Use C++ exception handling.
2215         * common/selftest.c: Use C++ exception handling.
2216         * common/new-op.c: Use C++ exception handling.
2217         * cli/cli-script.c: Use C++ exception handling.
2218         * cli/cli-interp.c: Use C++ exception handling.
2219         * cli/cli-cmds.c: Use C++ exception handling.
2220         * c-varobj.c: Use C++ exception handling.
2221         * btrace.c: Use C++ exception handling.
2222         * breakpoint.c: Use C++ exception handling.
2223         * break-catch-throw.c: Use C++ exception handling.
2224         * arch-utils.c: Use C++ exception handling.
2225         * amd64-tdep.c: Use C++ exception handling.
2226         * ada-valprint.c: Use C++ exception handling.
2227         * ada-typeprint.c: Use C++ exception handling.
2228         * ada-lang.c: Use C++ exception handling.
2229         * aarch64-tdep.c: Use C++ exception handling.
2230
2231 2019-04-08  Tom Tromey  <tom@tromey.com>
2232
2233         * xml-support.c (gdb_xml_parser::parse): Update.
2234         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2235         * value.c (show_convenience): Update.
2236         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2237         (test_parse_flags_qcs): Update.
2238         * thread.c (thr_try_catch_cmd): Update.
2239         * target.c (target_translate_tls_address): Update.
2240         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2241         (info_frame_command_core, frame_apply_command_count): Update.
2242         * rust-exp.y (rust_lex_exception_test): Update.
2243         * riscv-tdep.c (riscv_print_one_register_info): Update.
2244         * remote.c (remote_target::enable_btrace): Update.
2245         * record-btrace.c (record_btrace_enable_warn): Update.
2246         * python/py-utils.c (gdbpy_convert_exception): Update.
2247         * printcmd.c (do_one_display, print_variable_and_value): Update.
2248         * mi/mi-main.c (mi_print_exception): Update.
2249         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2250         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2251         * linux-nat.c (linux_nat_target::attach): Update.
2252         * linux-fork.c (class scoped_switch_fork_info): Update.
2253         * infrun.c (displaced_step_prepare): Update.
2254         * infcall.c (call_function_by_hand_dummy): Update.
2255         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2256         * gnu-v3-abi.c (print_one_vtable): Update.
2257         * frame.c (get_prev_frame_always): Update.
2258         * f-valprint.c (info_common_command_for_block): Update.
2259         * exec.c (try_open_exec_file): Update.
2260         * exceptions.c (print_exception, exception_print)
2261         (exception_fprintf, exception_print_same): Update.
2262         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2263         * dwarf-index-cache.c (index_cache::store)
2264         (index_cache::lookup_gdb_index): Update.
2265         * darwin-nat.c (maybe_cache_shell): Update.
2266         * cp-valprint.c (cp_print_value_fields): Update.
2267         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2268         (gcc_cplus_symbol_address): Update.
2269         * compile/compile-c-symbols.c (gcc_convert_symbol)
2270         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2271         * common/selftest.c: Update.
2272         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2273         a std::string.
2274         (exception_try_scope_entry, exception_try_scope_exit): Don't
2275         declare.
2276         (struct exception_try_scope): Remove.
2277         (TRY): Don't use exception_try_scope.
2278         (struct gdb_exception): Add constructor, operator=.
2279         <what>: New method.
2280         (struct gdb_exception_RETURN_MASK_ALL)
2281         (struct gdb_exception_RETURN_MASK_ERROR)
2282         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2283         (struct gdb_quit_bad_alloc): Update.
2284         * common/common-exceptions.c (exception_none): Change
2285         initializer.
2286         (struct catcher) <state, exception>: Initialize inline.
2287         <prev>: Remove member.
2288         (current_catcher): Remove.
2289         (catchers): New global.
2290         (exceptions_state_mc_init): Simplify.
2291         (catcher_pop): Remove.
2292         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2293         (try_scope_depth, exception_try_scope_entry)
2294         (exception_try_scope_exit): Remove.
2295         (throw_exception_sjlj): Update.
2296         (exception_messages, exception_messages_size): Remove.
2297         (throw_it): Simplify.
2298         (gdb_exception_sliced_copy): Remove.
2299         (throw_exception_cxx): Update.
2300         * cli/cli-script.c (script_from_file): Update.
2301         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2302         Update.
2303         * ada-valprint.c (ada_val_print): Update.
2304         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2305         (create_excep_cond_exprs): Update.
2306
2307 2019-04-08  Tom Tromey  <tom@tromey.com>
2308
2309         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2310         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2311         (TRY, CATCH, END_CATCH): Remove some definitions.
2312         * common/common-exceptions.c: Don't use GDB_XCPT.
2313         (catcher_list_size): Remove.
2314         (throw_exception, throw_it): Simplify.
2315
2316 2019-04-05  Tom Tromey  <tom@tromey.com>
2317
2318         Revert the header-sorting patch.
2319         * ft32-tdep.c: Revert.
2320         * frv-tdep.c: Revert.
2321         * frv-linux-tdep.c: Revert.
2322         * frame.c: Revert.
2323         * frame-unwind.c: Revert.
2324         * frame-base.c: Revert.
2325         * fork-child.c: Revert.
2326         * findvar.c: Revert.
2327         * findcmd.c: Revert.
2328         * filesystem.c: Revert.
2329         * filename-seen-cache.h: Revert.
2330         * filename-seen-cache.c: Revert.
2331         * fbsd-tdep.c: Revert.
2332         * fbsd-nat.h: Revert.
2333         * fbsd-nat.c: Revert.
2334         * f-valprint.c: Revert.
2335         * f-typeprint.c: Revert.
2336         * f-lang.c: Revert.
2337         * extension.h: Revert.
2338         * extension.c: Revert.
2339         * extension-priv.h: Revert.
2340         * expprint.c: Revert.
2341         * exec.h: Revert.
2342         * exec.c: Revert.
2343         * exceptions.c: Revert.
2344         * event-top.c: Revert.
2345         * event-loop.c: Revert.
2346         * eval.c: Revert.
2347         * elfread.c: Revert.
2348         * dwarf2read.h: Revert.
2349         * dwarf2read.c: Revert.
2350         * dwarf2loc.c: Revert.
2351         * dwarf2expr.h: Revert.
2352         * dwarf2expr.c: Revert.
2353         * dwarf2-frame.c: Revert.
2354         * dwarf2-frame-tailcall.c: Revert.
2355         * dwarf-index-write.h: Revert.
2356         * dwarf-index-write.c: Revert.
2357         * dwarf-index-common.c: Revert.
2358         * dwarf-index-cache.h: Revert.
2359         * dwarf-index-cache.c: Revert.
2360         * dummy-frame.c: Revert.
2361         * dtrace-probe.c: Revert.
2362         * disasm.h: Revert.
2363         * disasm.c: Revert.
2364         * disasm-selftests.c: Revert.
2365         * dictionary.c: Revert.
2366         * dicos-tdep.c: Revert.
2367         * demangle.c: Revert.
2368         * dcache.h: Revert.
2369         * dcache.c: Revert.
2370         * darwin-nat.h: Revert.
2371         * darwin-nat.c: Revert.
2372         * darwin-nat-info.c: Revert.
2373         * d-valprint.c: Revert.
2374         * d-namespace.c: Revert.
2375         * d-lang.c: Revert.
2376         * ctf.c: Revert.
2377         * csky-tdep.c: Revert.
2378         * csky-linux-tdep.c: Revert.
2379         * cris-tdep.c: Revert.
2380         * cris-linux-tdep.c: Revert.
2381         * cp-valprint.c: Revert.
2382         * cp-support.c: Revert.
2383         * cp-namespace.c: Revert.
2384         * cp-abi.c: Revert.
2385         * corelow.c: Revert.
2386         * corefile.c: Revert.
2387         * continuations.c: Revert.
2388         * completer.h: Revert.
2389         * completer.c: Revert.
2390         * complaints.c: Revert.
2391         * coffread.c: Revert.
2392         * coff-pe-read.c: Revert.
2393         * cli-out.h: Revert.
2394         * cli-out.c: Revert.
2395         * charset.c: Revert.
2396         * c-varobj.c: Revert.
2397         * c-valprint.c: Revert.
2398         * c-typeprint.c: Revert.
2399         * c-lang.c: Revert.
2400         * buildsym.c: Revert.
2401         * buildsym-legacy.c: Revert.
2402         * build-id.h: Revert.
2403         * build-id.c: Revert.
2404         * btrace.c: Revert.
2405         * bsd-uthread.c: Revert.
2406         * breakpoint.h: Revert.
2407         * breakpoint.c: Revert.
2408         * break-catch-throw.c: Revert.
2409         * break-catch-syscall.c: Revert.
2410         * break-catch-sig.c: Revert.
2411         * blockframe.c: Revert.
2412         * block.c: Revert.
2413         * bfin-tdep.c: Revert.
2414         * bfin-linux-tdep.c: Revert.
2415         * bfd-target.c: Revert.
2416         * bcache.c: Revert.
2417         * ax-general.c: Revert.
2418         * ax-gdb.h: Revert.
2419         * ax-gdb.c: Revert.
2420         * avr-tdep.c: Revert.
2421         * auxv.c: Revert.
2422         * auto-load.c: Revert.
2423         * arm-wince-tdep.c: Revert.
2424         * arm-tdep.c: Revert.
2425         * arm-symbian-tdep.c: Revert.
2426         * arm-pikeos-tdep.c: Revert.
2427         * arm-obsd-tdep.c: Revert.
2428         * arm-nbsd-tdep.c: Revert.
2429         * arm-nbsd-nat.c: Revert.
2430         * arm-linux-tdep.c: Revert.
2431         * arm-linux-nat.c: Revert.
2432         * arm-fbsd-tdep.c: Revert.
2433         * arm-fbsd-nat.c: Revert.
2434         * arm-bsd-tdep.c: Revert.
2435         * arch-utils.c: Revert.
2436         * arc-tdep.c: Revert.
2437         * arc-newlib-tdep.c: Revert.
2438         * annotate.h: Revert.
2439         * annotate.c: Revert.
2440         * amd64-windows-tdep.c: Revert.
2441         * amd64-windows-nat.c: Revert.
2442         * amd64-tdep.c: Revert.
2443         * amd64-sol2-tdep.c: Revert.
2444         * amd64-obsd-tdep.c: Revert.
2445         * amd64-obsd-nat.c: Revert.
2446         * amd64-nbsd-tdep.c: Revert.
2447         * amd64-nbsd-nat.c: Revert.
2448         * amd64-nat.c: Revert.
2449         * amd64-linux-tdep.c: Revert.
2450         * amd64-linux-nat.c: Revert.
2451         * amd64-fbsd-tdep.c: Revert.
2452         * amd64-fbsd-nat.c: Revert.
2453         * amd64-dicos-tdep.c: Revert.
2454         * amd64-darwin-tdep.c: Revert.
2455         * amd64-bsd-nat.c: Revert.
2456         * alpha-tdep.c: Revert.
2457         * alpha-obsd-tdep.c: Revert.
2458         * alpha-nbsd-tdep.c: Revert.
2459         * alpha-mdebug-tdep.c: Revert.
2460         * alpha-linux-tdep.c: Revert.
2461         * alpha-linux-nat.c: Revert.
2462         * alpha-bsd-tdep.c: Revert.
2463         * alpha-bsd-nat.c: Revert.
2464         * aix-thread.c: Revert.
2465         * agent.c: Revert.
2466         * addrmap.c: Revert.
2467         * ada-varobj.c: Revert.
2468         * ada-valprint.c: Revert.
2469         * ada-typeprint.c: Revert.
2470         * ada-tasks.c: Revert.
2471         * ada-lang.c: Revert.
2472         * aarch64-tdep.c: Revert.
2473         * aarch64-ravenscar-thread.c: Revert.
2474         * aarch64-newlib-tdep.c: Revert.
2475         * aarch64-linux-tdep.c: Revert.
2476         * aarch64-linux-nat.c: Revert.
2477         * aarch64-fbsd-tdep.c: Revert.
2478         * aarch64-fbsd-nat.c: Revert.
2479         * aarch32-linux-nat.c: Revert.
2480
2481 2019-04-05  Tom Tromey  <tom@tromey.com>
2482
2483         * ft32-tdep.c: Sort headers.
2484         * frv-tdep.c: Sort headers.
2485         * frv-linux-tdep.c: Sort headers.
2486         * frame.c: Sort headers.
2487         * frame-unwind.c: Sort headers.
2488         * frame-base.c: Sort headers.
2489         * fork-child.c: Sort headers.
2490         * findvar.c: Sort headers.
2491         * findcmd.c: Sort headers.
2492         * filesystem.c: Sort headers.
2493         * filename-seen-cache.h: Sort headers.
2494         * filename-seen-cache.c: Sort headers.
2495         * fbsd-tdep.c: Sort headers.
2496         * fbsd-nat.h: Sort headers.
2497         * fbsd-nat.c: Sort headers.
2498         * f-valprint.c: Sort headers.
2499         * f-typeprint.c: Sort headers.
2500         * f-lang.c: Sort headers.
2501         * extension.h: Sort headers.
2502         * extension.c: Sort headers.
2503         * extension-priv.h: Sort headers.
2504         * expprint.c: Sort headers.
2505         * exec.h: Sort headers.
2506         * exec.c: Sort headers.
2507         * exceptions.c: Sort headers.
2508         * event-top.c: Sort headers.
2509         * event-loop.c: Sort headers.
2510         * eval.c: Sort headers.
2511         * elfread.c: Sort headers.
2512         * dwarf2read.h: Sort headers.
2513         * dwarf2read.c: Sort headers.
2514         * dwarf2loc.c: Sort headers.
2515         * dwarf2expr.h: Sort headers.
2516         * dwarf2expr.c: Sort headers.
2517         * dwarf2-frame.c: Sort headers.
2518         * dwarf2-frame-tailcall.c: Sort headers.
2519         * dwarf-index-write.h: Sort headers.
2520         * dwarf-index-write.c: Sort headers.
2521         * dwarf-index-common.c: Sort headers.
2522         * dwarf-index-cache.h: Sort headers.
2523         * dwarf-index-cache.c: Sort headers.
2524         * dummy-frame.c: Sort headers.
2525         * dtrace-probe.c: Sort headers.
2526         * disasm.h: Sort headers.
2527         * disasm.c: Sort headers.
2528         * disasm-selftests.c: Sort headers.
2529         * dictionary.c: Sort headers.
2530         * dicos-tdep.c: Sort headers.
2531         * demangle.c: Sort headers.
2532         * dcache.h: Sort headers.
2533         * dcache.c: Sort headers.
2534         * darwin-nat.h: Sort headers.
2535         * darwin-nat.c: Sort headers.
2536         * darwin-nat-info.c: Sort headers.
2537         * d-valprint.c: Sort headers.
2538         * d-namespace.c: Sort headers.
2539         * d-lang.c: Sort headers.
2540         * ctf.c: Sort headers.
2541         * csky-tdep.c: Sort headers.
2542         * csky-linux-tdep.c: Sort headers.
2543         * cris-tdep.c: Sort headers.
2544         * cris-linux-tdep.c: Sort headers.
2545         * cp-valprint.c: Sort headers.
2546         * cp-support.c: Sort headers.
2547         * cp-namespace.c: Sort headers.
2548         * cp-abi.c: Sort headers.
2549         * corelow.c: Sort headers.
2550         * corefile.c: Sort headers.
2551         * continuations.c: Sort headers.
2552         * completer.h: Sort headers.
2553         * completer.c: Sort headers.
2554         * complaints.c: Sort headers.
2555         * coffread.c: Sort headers.
2556         * coff-pe-read.c: Sort headers.
2557         * cli-out.h: Sort headers.
2558         * cli-out.c: Sort headers.
2559         * charset.c: Sort headers.
2560         * c-varobj.c: Sort headers.
2561         * c-valprint.c: Sort headers.
2562         * c-typeprint.c: Sort headers.
2563         * c-lang.c: Sort headers.
2564         * buildsym.c: Sort headers.
2565         * buildsym-legacy.c: Sort headers.
2566         * build-id.h: Sort headers.
2567         * build-id.c: Sort headers.
2568         * btrace.c: Sort headers.
2569         * bsd-uthread.c: Sort headers.
2570         * breakpoint.h: Sort headers.
2571         * breakpoint.c: Sort headers.
2572         * break-catch-throw.c: Sort headers.
2573         * break-catch-syscall.c: Sort headers.
2574         * break-catch-sig.c: Sort headers.
2575         * blockframe.c: Sort headers.
2576         * block.c: Sort headers.
2577         * bfin-tdep.c: Sort headers.
2578         * bfin-linux-tdep.c: Sort headers.
2579         * bfd-target.c: Sort headers.
2580         * bcache.c: Sort headers.
2581         * ax-general.c: Sort headers.
2582         * ax-gdb.h: Sort headers.
2583         * ax-gdb.c: Sort headers.
2584         * avr-tdep.c: Sort headers.
2585         * auxv.c: Sort headers.
2586         * auto-load.c: Sort headers.
2587         * arm-wince-tdep.c: Sort headers.
2588         * arm-tdep.c: Sort headers.
2589         * arm-symbian-tdep.c: Sort headers.
2590         * arm-pikeos-tdep.c: Sort headers.
2591         * arm-obsd-tdep.c: Sort headers.
2592         * arm-nbsd-tdep.c: Sort headers.
2593         * arm-nbsd-nat.c: Sort headers.
2594         * arm-linux-tdep.c: Sort headers.
2595         * arm-linux-nat.c: Sort headers.
2596         * arm-fbsd-tdep.c: Sort headers.
2597         * arm-fbsd-nat.c: Sort headers.
2598         * arm-bsd-tdep.c: Sort headers.
2599         * arch-utils.c: Sort headers.
2600         * arc-tdep.c: Sort headers.
2601         * arc-newlib-tdep.c: Sort headers.
2602         * annotate.h: Sort headers.
2603         * annotate.c: Sort headers.
2604         * amd64-windows-tdep.c: Sort headers.
2605         * amd64-windows-nat.c: Sort headers.
2606         * amd64-tdep.c: Sort headers.
2607         * amd64-sol2-tdep.c: Sort headers.
2608         * amd64-obsd-tdep.c: Sort headers.
2609         * amd64-obsd-nat.c: Sort headers.
2610         * amd64-nbsd-tdep.c: Sort headers.
2611         * amd64-nbsd-nat.c: Sort headers.
2612         * amd64-nat.c: Sort headers.
2613         * amd64-linux-tdep.c: Sort headers.
2614         * amd64-linux-nat.c: Sort headers.
2615         * amd64-fbsd-tdep.c: Sort headers.
2616         * amd64-fbsd-nat.c: Sort headers.
2617         * amd64-dicos-tdep.c: Sort headers.
2618         * amd64-darwin-tdep.c: Sort headers.
2619         * amd64-bsd-nat.c: Sort headers.
2620         * alpha-tdep.c: Sort headers.
2621         * alpha-obsd-tdep.c: Sort headers.
2622         * alpha-nbsd-tdep.c: Sort headers.
2623         * alpha-mdebug-tdep.c: Sort headers.
2624         * alpha-linux-tdep.c: Sort headers.
2625         * alpha-linux-nat.c: Sort headers.
2626         * alpha-bsd-tdep.c: Sort headers.
2627         * alpha-bsd-nat.c: Sort headers.
2628         * aix-thread.c: Sort headers.
2629         * agent.c: Sort headers.
2630         * addrmap.c: Sort headers.
2631         * ada-varobj.c: Sort headers.
2632         * ada-valprint.c: Sort headers.
2633         * ada-typeprint.c: Sort headers.
2634         * ada-tasks.c: Sort headers.
2635         * ada-lang.c: Sort headers.
2636         * aarch64-tdep.c: Sort headers.
2637         * aarch64-ravenscar-thread.c: Sort headers.
2638         * aarch64-newlib-tdep.c: Sort headers.
2639         * aarch64-linux-tdep.c: Sort headers.
2640         * aarch64-linux-nat.c: Sort headers.
2641         * aarch64-fbsd-tdep.c: Sort headers.
2642         * aarch64-fbsd-nat.c: Sort headers.
2643         * aarch32-linux-nat.c: Sort headers.
2644
2645 2019-04-04  Tom Tromey  <tom@tromey.com>
2646
2647         * varobj.c (varobj_create): Update.
2648         * rust-exp.y (struct rust_parser) <update_innermost_block,
2649         lookup_symbol>: New methods.
2650         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2651         Rename.
2652         (rust_parser::rust_lookup_type)
2653         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2654         * printcmd.c (display_command, do_one_display): Update.
2655         * parser-defs.h (struct parser_state) <parser_state>: Add
2656         "tracker" parameter.
2657         (block_tracker): New member.
2658         (class innermost_block_tracker) <innermost_block_tracker>: Add
2659         "types" parameter.
2660         <reset>: Remove method.
2661         (innermost_block): Don't declare.
2662         (null_post_parser): Update.
2663         * parse.c (innermost_block): Remove global.
2664         (write_dollar_variable): Update.
2665         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2666         Remove "tracker_types" parameter.
2667         (parse_expression): Add "tracker" parameter.
2668         (parse_expression_for_completion): Update.
2669         (null_post_parser): Add "tracker" parameter.
2670         * p-exp.y: Update rules.
2671         * m2-exp.y: Update rules.
2672         * language.h (struct language_defn) <la_post_parser>: Add
2673         "tracker" parameter.
2674         * go-exp.y: Update rules.
2675         * f-exp.y: Update rules.
2676         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2677         parameter.
2678         * d-exp.y: Update rules.
2679         * c-exp.y: Update rules.
2680         * breakpoint.c (set_breakpoint_condition): Create an
2681         innermost_block_tracker.
2682         (watch_command_1): Likewise.
2683         * ada-lang.c (resolve): Add "tracker" parameter.
2684         (resolve_subexp): Likewise.
2685         * ada-exp.y (write_var_from_sym): Update.
2686
2687 2019-04-04  Tom Tromey  <tom@tromey.com>
2688
2689         * type-stack.h: New file.
2690         * type-stack.c: New file.
2691         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2692         type-stack.h.
2693         (insert_into_type_stack, insert_type, push_type, push_type_int)
2694         (insert_type_address_space, pop_type, pop_type_int)
2695         (pop_typelist, pop_type_stack, append_type_stack)
2696         (push_type_stack, get_type_stack, push_typelist)
2697         (follow_type_instance_flags, follow_types): Don't declare.
2698         * parse.c (type_stack): Remove global.
2699         (parse_exp_in_context): Update.
2700         (insert_into_type_stack, insert_type, push_type, push_type_int)
2701         (insert_type_address_space, pop_type, pop_type_int)
2702         (pop_typelist, pop_type_stack, append_type_stack)
2703         (push_type_stack, get_type_stack, push_typelist)
2704         (follow_type_instance_flags, follow_types): Remove (moved to
2705         type-stack.c).
2706         * f-exp.y (type_stack): New global.
2707         Update rules.
2708         (push_kind_type, f_parse): Update.
2709         * d-exp.y (type_stack): New global.
2710         Update rules.
2711         (d_parse): Update.
2712         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2713         Update rules.
2714         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2715         (HFILES_NO_SRCDIR): Add type-stack.h.
2716
2717 2019-04-04  Tom Tromey  <tom@tromey.com>
2718
2719         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2720         (rust_parser::convert_ast_to_expression, rust_parse)
2721         (rust_lex_test_completion, rust_lex_tests): Update.
2722         * parser-defs.h (struct expr_completion_state): New.
2723         (struct parser_state) <parser_state>: Add completion parameter.
2724         <mark_struct_expression, mark_completion_tag>: New methods.
2725         <parse_completion, m_completion_state>: New members.
2726         (prefixify_expression, null_post_parser): Update.
2727         (mark_struct_expression, mark_completion_tag): Don't declare.
2728         * parse.c (parse_completion, expout_last_struct)
2729         (expout_tag_completion_type, expout_completion_name): Remove
2730         globals.
2731         (parser_state::mark_struct_expression)
2732         (parser_state::mark_completion_tag): Now methods.
2733         (prefixify_expression): Add last_struct parameter.
2734         (prefixify_subexp): Likewise.
2735         (parse_exp_1): Update.
2736         (parse_exp_in_context): Add cstate parameter.  Update.
2737         (parse_expression_for_completion): Create an
2738         expr_completion_state.
2739         (null_post_parser): Add "completion" parameter.
2740         * p-exp.y: Update rules.
2741         (yylex): Update.
2742         * language.h (struct language_defn) <la_post_parser>: Add
2743         "completing" parameter.
2744         * go-exp.y: Update rules.
2745         (lex_one_token): Update.
2746         * expression.h (parse_completion): Don't declare.
2747         * d-exp.y: Update rules.
2748         (lex_one_token): Update rules.
2749         * c-exp.y: Update rules.
2750         (lex_one_token): Update.
2751         * ada-lang.c (resolve): Add "parse_completion" parameter.
2752         (resolve_subexp): Likewise.
2753         (ada_resolve_function): Likewise.
2754
2755 2019-04-04  Tom Tromey  <tom@tromey.com>
2756
2757         * parser-defs.h (struct parser_state) <start_arglist,
2758         end_arglist>: New methods.
2759         <arglist_len, m_funcall_chain>: New members.
2760         (arglist_len, start_arglist, end_arglist): Don't declare.
2761         * parse.c (arglist_len, funcall_chain): Remove global.
2762         (start_arglist, end_arglist): Remove functions.
2763         (parse_exp_in_context): Update.
2764         * p-exp.y: Update rules.
2765         * m2-exp.y: Update rules.
2766         * go-exp.y: Update rules.
2767         * f-exp.y: Update rules.
2768         * d-exp.y: Update rules.
2769         * c-exp.y: Update rules.
2770
2771 2019-04-04  Tom Tromey  <tom@tromey.com>
2772
2773         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2774         lex_operator, push_back>: New methods.
2775         Update all rules.
2776         (rust_parser::lex_hex, lex_escape): Rename and update.
2777         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2778         (rust_parser::lex_operator): Rename and update.
2779         (rust_parser::lex_number, rustyylex, rustyyerror)
2780         (rust_lex_test_init, rust_lex_test_sequence)
2781         (rust_lex_test_push_back, rust_lex_tests): Update.
2782         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2783         parameter.
2784         <lexptr, prev_lexptr>: New members.
2785         (lexptr, prev_lexptr): Don't declare.
2786         * parse.c (lexptr, prev_lexptr): Remove globals.
2787         (parse_exp_in_context): Update.
2788         * p-exp.y (yylex, yyerror): Update.
2789         * m2-exp.y (parse_number, yylex, yyerror): Update.
2790         * go-exp.y (lex_one_token, yyerror): Update.
2791         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2792         * d-exp.y (lex_one_token, yyerror): Update.
2793         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2794         (lex_one_token, yyerror): Update.
2795         * ada-lex.l (YY_INPUT): Update.
2796         (rewind_to_char): Update.
2797         * ada-exp.y (yyerror): Update.
2798
2799 2019-04-04  Tom Tromey  <tom@tromey.com>
2800
2801         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2802         * parser-defs.h (struct parser_state) <parser_state>: Add new
2803         parameter.
2804         <comma_terminates>: New member.
2805         (comma_terminates): Don't declare global.
2806         * parse.c (comma_terminates): Remove global.
2807         (parse_exp_in_context): Update.
2808         * p-exp.y (yylex): Update.
2809         * m2-exp.y (yylex): Update.
2810         * go-exp.y (lex_one_token): Update.
2811         * f-exp.y (yylex): Update.
2812         * d-exp.y (lex_one_token): Update.
2813         * c-exp.y (lex_one_token): Update.
2814         * ada-lex.l: Update.
2815
2816 2019-04-04  Tom Tromey  <tom@tromey.com>
2817
2818         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2819         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2820         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2821         * parser-defs.h (paren_depth): Don't declare.
2822         * parse.c (paren_depth): Remove global.
2823         (parse_exp_in_context): Update.
2824         * p-exp.y (paren_depth): New global.
2825         (pascal_parse): Initialize it.
2826         * m2-exp.y (paren_depth): New global.
2827         (m2_parse): Initialize it.
2828         * go-exp.y (paren_depth): New global.
2829         (go_parse): Initialize it.
2830         * f-exp.y (paren_depth): New global.
2831         (f_parse): Initialize it.
2832         * d-exp.y (paren_depth): New global.
2833         (d_parse): Initialize it.
2834         * c-exp.y (paren_depth): New global.
2835         (c_parse): Initialize it.
2836         * ada-lex.l (paren_depth): New global.
2837         (lexer_init): Initialize it.
2838
2839 2019-04-04  Tom Tromey  <tom@tromey.com>
2840
2841         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2842         (rust_parser::convert_ast_to_type)
2843         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2844         * parser-defs.h (struct parser_state) <parser_state>: Add
2845         parameters.  Initialize new members.
2846         <expression_context_block, expression_context_pc>: New members.
2847         * parse.c (expression_context_block, expression_context_pc):
2848         Remove globals.
2849         (parse_exp_in_context): Update.
2850         * p-exp.y: Update all rules.
2851         (yylex): Update.
2852         * m2-exp.y: Update all rules.
2853         (yylex): Update.
2854         * go-exp.y (yylex): Update.
2855         * f-exp.y (yylex): Update.
2856         * d-exp.y: Update all rules.
2857         (yylex): Update.
2858         * c-exp.y: Update all rules.
2859         (lex_one_token, classify_name, yylex, c_parse): Update.
2860         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2861
2862 2019-04-04  Tom Tromey  <tom@tromey.com>
2863
2864         * gdbarch.h, gdbarch.c: Rebuild.
2865         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2866         * stap-probe.h:
2867         (struct stap_parse_info): Replace "parser_state" with
2868         "expr_builder".
2869         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2870         (parser_state): New class.
2871         * parse.c (expr_builder): Rename.
2872         (expr_builder::release): Rename.
2873         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2874         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2875         (write_exp_elt_longcst, write_exp_elt_floatcst)
2876         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2877         (write_exp_string_vector, write_exp_bitstring)
2878         (write_exp_msymbol, mark_struct_expression)
2879         (write_dollar_variable)
2880         (insert_type_address_space, increase_expout_size): Replace
2881         "parser_state" with "expr_builder".
2882         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2883         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2884         "parser_state" with "expr_builder".
2885
2886 2019-04-04  Tom Tromey  <tom@tromey.com>
2887
2888         * rust-exp.y: Replace "parse_language" with method call.
2889         * p-exp.y:
2890         (yylex): Replace "parse_language" with method call.
2891         * m2-exp.y:
2892         (yylex): Replace "parse_language" with method call.
2893         * go-exp.y (classify_name): Replace "parse_language" with method
2894         call.
2895         * f-exp.y (yylex): Replace "parse_language" with method call.
2896         * d-exp.y (lex_one_token): Replace "parse_language" with method
2897         call.
2898         * c-exp.y:
2899         (lex_one_token, classify_name, yylex): Replace "parse_language"
2900         with method call.
2901         * ada-exp.y (find_primitive_type, type_char)
2902         (type_system_address): Replace "parse_language" with method call.
2903
2904 2019-04-04  Tom Tromey  <tom@tromey.com>
2905
2906         * rust-exp.y: Replace "parse_gdbarch" with method call.
2907         * parse.c (write_dollar_variable, insert_type_address_space):
2908         Replace "parse_gdbarch" with method call.
2909         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2910         call.
2911         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2912         call.
2913         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2914         "parse_gdbarch" with method call.
2915         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2916         with method call.
2917         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2918         "parse_gdbarch" with method call.
2919         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2920         "parse_gdbarch" with method call.
2921         * c-exp.y (parse_type, parse_number, classify_name): Replace
2922         "parse_gdbarch" with method call.
2923         * ada-lex.l: Replace "parse_gdbarch" with method call.
2924         * ada-exp.y (parse_type, find_primitive_type, type_char)
2925         (type_system_address): Replace "parse_gdbarch" with method call.
2926
2927 2019-04-04  Tom Tromey  <tom@tromey.com>
2928
2929         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2930         * stap-probe.c (stap_parse_argument): Update.
2931         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2932         initial_size parameter.
2933         * rust-exp.y (rust_lex_tests): Update.
2934         * parse.c (parser_state): Update.
2935         (parse_exp_in_context): Update.
2936         * parser-defs.h (struct parser_state) <parser_state>: Remove
2937         "initial_size" parameter.
2938
2939 2019-04-04  Tom Tromey  <tom@tromey.com>
2940
2941         * parser-defs.h (increase_expout_size): Don't declare.
2942         * parse.c (increase_expout_size): Now static.
2943
2944 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2945
2946         * gnu-nat.c (gnu_nat_target::wait): Fix
2947         target_waitstatus_to_string call.
2948
2949 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * eval.c (evaluate_subexp_standard): Handle internal functions
2952         during Fortran function call handling.
2953
2954 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2955
2956         * NEWS: Mention new internal functions.
2957         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2958         (read_base_type): Use dwarf2_init_complex_target_type.
2959         * value.c (creal_internal_fn): New function.
2960         (cimag_internal_fn): New function.
2961         (_initialize_values): Register new internal functions.
2962
2963 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2964
2965         * infrun.c (stop_all_threads): If debug_infrun, always
2966         trace the wait status after wait_one, using
2967         target_waitstatus_to_string and target_pid_to_str.
2968         (handle_inferior_event): Replace various trace of
2969         wait status kind by a single trace.
2970         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2971         wait status kind image by target_waitstatus_to_string.
2972         * target/waitstatus.c (target_waitstatus_to_string): Fix
2973         obsolete comment.
2974
2975 2019-04-01  Tom Tromey  <tromey@adacore.com>
2976
2977         PR symtab/23331:
2978         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2979
2980 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2981             Pedro Alves  <palves@redhat.com>
2982
2983         * top.c (quit_force): Call 'finalize_values'.
2984         * value.c (finalize_values): New function.
2985         * value.h (finalize_values): Declare.
2986
2987 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2988
2989         * NEWS: Announce $_gdb_major and $_gdb_minor.
2990
2991         * top.c (init_gdb_version_vars): New function.
2992         (gdb_init): Call init_gdb_version_vars.
2993
2994 2019-03-29  Tom Tromey  <tromey@adacore.com>
2995
2996         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2997         help text.  Remove dead code.
2998
2999 2019-03-29  Keith Seitz  <keiths@redhat.com>
3000
3001         From Siddhesh Poyarekar:
3002         * f-lang.h (f77_get_upperbound): Return LONGEST.
3003         (f77_get_lowerbound): Likewise.
3004         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3005         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3006         print them.
3007         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3008         plongest to format print it.
3009         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3010         (f77_get_upperbound): Likewise.
3011         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3012         LOWER_BOUND to LONGEST.
3013         (f77_create_arrayprint_offset_tbl): Likewise.
3014
3015 2019-03-29  Keith Seitz  <keiths@redhat.com>
3016
3017         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3018         %s/pulongest for TYPE_LENGTH instead of %d in format
3019         strings.
3020         * ada-typerint.c (ada_print_type): Likewise.
3021         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3022         * compile/compile-c-support.c (generate_register_struct): Likewise.
3023         * gdbtypes.c (recursive_dump_type): Likewise.
3024         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3025         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3026         instead of %d in format strings.
3027         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3028         to std::min to ULONGEST.
3029         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3030         instead of %d in format strings.
3031         * tracepoint.c (info_scope_command): Likewise.
3032         * typeprint.c (print_offset_data::update)
3033         (print_offset_data::finish): Likewise.
3034         * xtensa-tdep.c (xtensa_store_return_value)
3035         (xtensa_push_dummy_call): Likewise.
3036
3037 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3038
3039         * windows-nat.c (display_selector): Fixed format specifications
3040         for 64-bit Cygwin.
3041
3042 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3043
3044         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3045
3046 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3047
3048         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3049         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3050         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3051         (nios2_linux_init_abi): Install it.
3052
3053 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3054
3055         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3056
3057 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3058
3059         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3060
3061 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3062             Tom Tromey  <tromey@adacore.com>
3063
3064         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3065
3066 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3067
3068         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3069         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3070         method to compute the bounds of range types. Also print "[evaluated]"
3071         if the bounds' values come from a dynamic evaluation.
3072
3073 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3074
3075         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3076         whitespace when pretty printing is on.
3077
3078 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3079
3080         * ppc-linux-nat.c: Add include.
3081
3082 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3083
3084         * NEWS: Mention AArch64 Pointer Authentication.
3085
3086 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3087
3088         * arm-linux-nat.c: Add include.
3089
3090 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3091
3092         * source-cache.c (source_cache::get_source_lines): Re-read
3093         fullname after calling open_source_file.
3094
3095 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3096
3097         * NEWS: Mention TLS support for FreeBSD.
3098
3099 2019-03-25  Tom Tromey  <tromey@adacore.com>
3100
3101         * minsyms.c (BUNCH_SIZE): Update comment.
3102         (~minimal_symbol_reader): Remove old comment.
3103         (compact_minimal_symbols): Update comment.
3104         (minimal_symbol_reader::install): Remove old comment.  Update
3105         other comments.
3106
3107 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3108
3109         * s390-linux-nat.c: Add include.
3110
3111 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3112
3113         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3114         Call linux_get_hwcap.
3115         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3116         Likewise.
3117         (aarch64_linux_get_hwcap): Remove function.
3118         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3119         declaration.
3120         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3121         linux_get_hwcap.
3122         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3123         * linux-tdep.c (linux_get_hwcap): Add function.
3124         (linux_get_hwcap2): Likewise.
3125         * linux-tdep.h (linux_get_hwcap): Add declaration.
3126         (linux_get_hwcap2): Likewise.
3127         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3128         (ppc_linux_get_hwcap2): Likewise.
3129         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3130         linux_get_hwcap.
3131         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3132         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3133         (ppc_linux_nat_target::read_description): Likewise.
3134         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3135         * s390-linux-nat.c: Likewise.
3136         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3137
3138 2019-03-24  Tom Tromey  <tom@tromey.com>
3139
3140         * ada-lang.c (standard_lookup): Simplify initialization.
3141         (ada_lookup_symbol_nonlocal): Simplify return.
3142         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3143         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3144         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3145         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3146         initialization.
3147         * solib.c (solib_global_lookup): Simplify.
3148         * symtab.c (null_block_symbol): Remove.
3149         (symbol_cache_lookup): Simplify returns.
3150         (lookup_language_this): Simplify returns.
3151         (lookup_symbol_aux): Simplify return.
3152         (lookup_local_symbol): Simplify returns.
3153         (lookup_global_symbol_from_objfile): Simplify return.
3154         (lookup_symbol_in_objfile_symtabs)
3155         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3156         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3157         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3158         * cp-namespace.c (cp_lookup_bare_symbol)
3159         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3160         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3161         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3162         (cp_lookup_symbol_via_imports): Simplify initialization.
3163         (find_symbol_in_baseclass): Likewise.
3164         * symtab.h (null_block_symbol): Remove.
3165         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3166         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3167         (d_lookup_symbol_module): Likewise.
3168         (find_symbol_in_baseclass): Simplify initialization.
3169
3170 2019-03-24  Tom Tromey  <tom@tromey.com>
3171
3172         * expression.h: Don't include symtab.h.
3173         (struct block): Forward declare.
3174
3175 2019-03-24  Tom Tromey  <tom@tromey.com>
3176
3177         * c-exp.y (typebase): Remove casts.
3178         * gdbtypes.c (lookup_unsigned_typename, )
3179         (lookup_signed_typename): Remove cast.
3180         * eval.c (parse_to_comma_and_eval): Remove cast.
3181         * parse.c (write_dollar_variable): Remove cast.
3182         * block.h (struct block) <superblock>: Now const.
3183         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3184         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3185         (map_block): Make "block" const.
3186         * symfile.h (struct quick_symbol_functions)
3187         <map_matching_symbols>: Constify block argument to "callback".
3188         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3189         const.
3190         (find_pc_sect_compunit_symtab): Make "b" const.
3191         (find_symbol_at_address): Likewise.
3192         (search_symbols): Likewise.
3193         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3194         (dw2_debug_names_lookup_symbol): Likewise.
3195         (dw2_map_matching_symbols): Update.
3196         * p-valprint.c (pascal_val_print): Remove "block".
3197         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3198         (aux_add_nonlocal_symbols): Make "block" const.
3199         (resolve_subexp): Remove cast.
3200         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3201         const.
3202         (iterate_over_file_blocks): Likewise.
3203         * f-exp.y (%union) <bval>: Remove.
3204         * coffread.c (patch_opaque_types): Make "b" const.
3205         * spu-tdep.c (spu_catch_start): Make "block" const.
3206         * c-valprint.c (print_unpacked_pointer): Remove "block".
3207         * symmisc.c (dump_symtab_1): Make "b" const.
3208         (block_depth): Make "block" const.
3209         * d-exp.y (%union) <bval>: Remove.
3210         * cp-support.h (cp_lookup_rtti_type): Update.
3211         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3212         * psymtab.c (psym_lookup_symbol): Make "block" const.
3213         (maintenance_check_psymtabs): Make "b" const.
3214         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3215         (enumerate_locals, enumerate_args): Update.
3216         * python/py-symtab.c (stpy_global_block): Make "block" const.
3217         (stpy_static_block): Likewise.
3218         * inline-frame.c (block_starting_point_at): Make "new_block"
3219         const.
3220         * block.c (find_block_in_blockvector): Make return type const.
3221         (blockvector_for_pc_sect): Make "b" const.
3222         (find_block_in_blockvector): Make "b" const.
3223
3224 2019-03-23  Tom Tromey  <tom@tromey.com>
3225
3226         * varobj.c (varobj_create): Update.
3227         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3228         * printcmd.c (display_command, do_one_display): Don't reset
3229         innermost_block.
3230         * parser-defs.h (enum innermost_block_tracker_type): Move to
3231         expression.h.
3232         (innermost_block): Update comment.
3233         * parse.c (parse_exp_1): Add tracker_types parameter.
3234         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3235         tracker_types parameter.  Reset innermost_block.
3236         (parse_exp_in_context): Remove.
3237         (parse_expression_for_completion): Update.
3238         * objfiles.c (~objfile): Don't reset expression_context_block or
3239         innermost_block.
3240         * expression.h (enum innermost_block_tracker_type): Move from
3241         parser-defs.h.
3242         (parse_exp_1): Add tracker_types parameter.
3243         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3244         reset innermost_block.
3245
3246 2019-03-23  Tom Tromey  <tom@tromey.com>
3247
3248         * objfiles.h: Include bcache.h.
3249
3250 2019-03-23  Tom Tromey  <tom@tromey.com>
3251
3252         * linespec.c (get_current_search_block): Use
3253         scoped_restore_current_language.
3254         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3255
3256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3257             Jiong Wang  <jiong.wang@arm.com>
3258
3259         * aarch64-linux-tdep.c
3260         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3261         section.
3262         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3263
3264 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3265             Jiong Wang  <jiong.wang@arm.com>
3266
3267         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3268         instructions.
3269         (aarch64_analyze_prologue_test): Add PACIASP test.
3270         (aarch64_prologue_prev_register): Unmask PC value.
3271
3272 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3273             Jiong Wang  <jiong.wang@arm.com>
3274
3275         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3276         (aarch64_dwarf2_prev_register): Unmask PC value.
3277         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3278         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3279         DW_CFA_AARCH64_negate_ra_state.
3280         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3281
3282 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3283             Jiong Wang  <jiong.wang@arm.com>
3284
3285         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3286         registers.
3287         (aarch64_pseudo_register_name): Likewise.
3288         (aarch64_pseudo_register_type): Likewise.
3289         (aarch64_pseudo_register_reggroup_p): Likewise.
3290         (aarch64_gdbarch_init): Add pauth registers.
3291         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3292         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3293         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3294         (struct gdbarch_tdep): Add regnum for ra_state.
3295
3296 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3297             Jiong Wang  <jiong.wang@arm.com>
3298
3299         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3300
3301 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3302             Jiong Wang  <jiong.wang@arm.com>
3303
3304         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3305         function.
3306         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3307         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3308         (aarch64_gdbarch_init): Add puth registers.
3309         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3310         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3311         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3312
3313 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3314             Jiong Wang  <jiong.wang@arm.com>
3315
3316         * aarch64-linux-nat.c
3317         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3318         * aarch64-linux-tdep.c
3319         (aarch64_linux_core_read_description): Likewise.
3320         (aarch64_linux_get_hwcap): New function.
3321         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3322         (aarch64_linux_get_hwcap): New declaration.
3323
3324 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3325             Jiong Wang  <jiong.wang@arm.com>
3326
3327         * aarch64-linux-nat.c
3328         (aarch64_linux_nat_target::read_description): Add pauth param.
3329         * aarch64-linux-tdep.c
3330         (aarch64_linux_core_read_description): Likewise.
3331         * aarch64-tdep.c (struct target_desc): Add in pauth.
3332         (aarch64_read_description): Add pauth param.
3333         (aarch64_gdbarch_init): Likewise.
3334         * aarch64-tdep.h (aarch64_read_description): Likewise.
3335         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3336         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3337         * features/Makefile: Add new files.
3338         * features/aarch64-pauth.c: New file.
3339         * features/aarch64-pauth.xml: New file.
3340
3341 2019-03-20  Tom Tromey  <tromey@adacore.com>
3342
3343         * infrun.c (handle_inferior_event): Rename from
3344         handle_inferior_event_1.  Create a scoped_value_mark.
3345         (handle_inferior_event): Remove.
3346
3347 2019-03-19  Tom Tromey  <tromey@adacore.com>
3348
3349         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3350         * infrun.h (print_stop_event): Add "displays" parameter.
3351         * infrun.c (print_stop_event): Add "displays" parameter.
3352
3353 2019-03-19  Pedro Alves  <palves@redhat.com>
3354
3355         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3356         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3357         to -1.  Fix TABs vs spaces.
3358         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3359         * tui/tui-out.h (tui_ui_out) Add intro comments.
3360         <m_line, m_start_of_line>: In-class initialize, and add describing
3361         comment.
3362
3363 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3364
3365         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3366         variable names.
3367         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3368
3369 2019-03-18  Pedro Alves  <palves@redhat.com>
3370             Eli Zaretskii <eliz@gnu.org>
3371
3372         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3373         m_line and m_start_of_line.
3374
3375 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3376
3377         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3378         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3379         it returns a newline.  This fixes a regression in TU mode, whereby
3380         the next line is output on the same screen line as the user input.
3381
3382 2019-03-18  Tom Tromey  <tromey@adacore.com>
3383
3384         * minsyms.c (minimal_symbol_reader::install): Remove call to
3385         obstack_blank.
3386
3387 2019-03-18  Pedro Alves  <palves@redhat.com>
3388
3389         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3390         New globals.
3391         (apply_style): New, factored out from ...
3392         (apply_ansi_escape): ... this.  Handle reverse video mode.
3393         (tui_set_reverse_mode): New function.
3394         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3395         * tui/tui-winsource.c (tui_show_source_line): Use
3396         tui_set_reverse_mode instead of setting A_STANDOUT.
3397         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3398         New setter methods.
3399
3400 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3401
3402         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3403         Handle tabs.
3404
3405 2019-03-18  Tom Tromey  <tromey@adacore.com>
3406
3407         * ada-lang.c (empty_array): Add "high" parameter.
3408         (ada_evaluate_subexp): Update.
3409
3410 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3411
3412         * unittests/string_view-selftests.c: Define
3413         _initialize_string_view_selftests unconditionally.
3414
3415 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3416
3417         PR gdb/24350
3418         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3419
3420 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3421
3422         PR gdb/24351
3423         * windows-nat.c (display_selector): Fix format specifiers.
3424
3425 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3426
3427         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3428         tui_refill_source_window instead of tui_refresh_win, to update the
3429         current execution line.  This fixes redisplay of the current line
3430         when stepping through the code with "next" or "step".
3431
3432 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3433
3434         * source-cache.c (source_cache::get_source_lines): Call
3435         find_source_lines to initialize s->nlines.  This fixes vertical
3436         scrolling of TUI source window when the DOWN arrow is pressed.
3437
3438 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3439
3440         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3441         linux-thread-db.c (_initialize_thread_db): Likewise.
3442
3443 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3444
3445         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3446         wclrtoeol in tui_show_source_line".  This reverts changes made in
3447         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3448
3449 2019-03-15  Tom Tromey  <tom@tromey.com>
3450
3451         * symtab.h (struct minimal_symbol): Derive from
3452         general_symbol_info.
3453         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3454         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3455         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3456         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3457         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3458         (MSYMBOL_SEARCH_NAME): Update.
3459         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3460         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3461         * minsyms.c (minimal_symbol_reader::record_full): Update.
3462
3463 2019-03-15  Tom Tromey  <tom@tromey.com>
3464
3465         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3466
3467 2019-03-15  Tom Tromey  <tom@tromey.com>
3468
3469         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3470         unique_xmalloc_ptr.
3471         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3472         Update.
3473         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3474         (build_minimal_symbol_hash_tables)
3475         (minimal_symbol_reader::install): Update.
3476
3477 2019-03-15  Tom Tromey  <tom@tromey.com>
3478
3479         * symtab.c (create_demangled_names_hash): Update.
3480         (symbol_set_names): Update.
3481         * objfiles.h (struct objfile_per_bfd_storage)
3482         <demangled_names_hash>: Now an htab_up.
3483         * objfiles.c (objfile_per_bfd_storage): Simplify.
3484
3485 2019-03-15  Tom Tromey  <tom@tromey.com>
3486
3487         * objfiles.h (struct objfile_per_bfd_storage): Declare
3488         destructor.
3489         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3490         New.
3491         (get_objfile_bfd_data): Use new.  Don't initialize
3492         language_of_main.
3493         (free_objfile_per_bfd_storage): Remove.
3494         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3495
3496 2019-03-15  Tom Tromey  <tom@tromey.com>
3497
3498         * symfile.c (reread_symbols): Update.
3499         * objfiles.c (objfile::objfile): Update.
3500         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3501         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3502         comment.
3503         (minimal_symbol_reader::install): Update.
3504         (terminate_minimal_symbol_table): Remove.
3505         * jit.c (jit_object_close_impl): Update.
3506
3507 2019-03-15  Tom Tromey  <tom@tromey.com>
3508
3509         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3510         initializations.
3511
3512 2019-03-15  Tom Tromey  <tom@tromey.com>
3513
3514         * objfiles.h (struct objfile_per_bfd_storage)
3515         <demangled_hash_languages>: Now a bitset.
3516         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3517         (lookup_minimal_symbol): Update.
3518
3519 2019-03-15  Tom Tromey  <tom@tromey.com>
3520
3521         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3522         Don't return the symbol.
3523         * coffread.c (record_minimal_symbol): Use record_full.
3524
3525 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3526
3527         The MS-Windows port of ncurses fails to switch to a color pair if
3528         one or both of the colors are the implicit default colors.  This
3529         change records the default colors when TUI is initialized, and
3530         then specifies them explicitly when a color pair uses the default
3531         colors.  This allows color styling in TUI mode on MS-Windows.
3532
3533         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3534         ncurses_norm_attr.
3535         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3536         colors in ncurses_norm_attr.
3537         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3538         "none", replace it with the default color recorded in
3539         ncurses_norm_attr.
3540
3541 2019-03-14  Tom Tromey  <tromey@adacore.com>
3542
3543         * source-cache.h (class source_cache) <get_source_lines>: Return
3544         std::string.
3545         * source-cache.c (source_cache::extract_lines): Handle case where
3546         first_pos==npos.  Return std::string.
3547         (source_cache::get_source_lines): Update.
3548
3549 2019-03-14  Tom Tromey  <tromey@adacore.com>
3550
3551         * NEWS: Add item for "style sources" commands.
3552         * source-cache.c (source_cache::get_source_lines): Check
3553         source_styling.
3554         * cli/cli-style.c (source_styling): New global.
3555         (_initialize_cli_style): Add "style sources" commands.
3556         (show_style_sources): New function.
3557         * cli/cli-style.h (source_styling): Declare.
3558
3559 2019-03-14  Pedro Alves  <palves@redhat.com>
3560             Tom Tromey  <tromey@adacore.com>
3561
3562         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3563         * tui/tui-winsource.c (tui_refill_source_window): New function,
3564         from...
3565         (tui_horizontal_source_scroll): ... here.  Move some logic.
3566         * cli/cli-style.c (set_style_enabled): Notify new observable.
3567         * tui/tui-hooks.c (tui_redisplay_source): New function.
3568         (tui_attach_detach_observers): Attach or detach
3569         tui_redisplay_source.
3570         * observable.h (source_styling_changed): New observable.
3571         * observable.c: Define source_styling_changed observable.
3572
3573 2019-03-13  Tom Tromey  <tromey@adacore.com>
3574
3575         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3576         (i386_gnu_nat_target::store_registers): Update.
3577         * target-debug.h (target_debug_print_std_string): New macro.
3578         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3579         * windows-tdep.c (display_one_tib): Update.
3580         * tui/tui-stack.c (tui_make_status_line): Update.
3581         * top.c (print_inferior_quit_action): Update.
3582         * thread.c (thr_try_catch_cmd): Update.
3583         (add_thread_with_info): Update.
3584         (thread_target_id_str): Update.
3585         (thr_try_catch_cmd): Update.
3586         (thread_command): Update.
3587         (thread_find_command): Update.
3588         * record-btrace.c (record_btrace_target::info_record)
3589         (record_btrace_resume_thread, record_btrace_target::resume)
3590         (record_btrace_cancel_resume, record_btrace_step_thread)
3591         (record_btrace_target::wait, record_btrace_target::wait)
3592         (record_btrace_target::wait, record_btrace_target::stop): Update.
3593         * progspace.c (print_program_space): Update.
3594         * process-stratum-target.c
3595         (process_stratum_target::thread_address_space): Update.
3596         * linux-fork.c (linux_fork_mourn_inferior)
3597         (detach_checkpoint_command, info_checkpoints_command)
3598         (linux_fork_context): Update.
3599         (linux_fork_detach): Update.
3600         (class scoped_switch_fork_info): Update.
3601         (delete_checkpoint_command): Update.
3602         * infrun.c (follow_fork_inferior): Update.
3603         (follow_fork_inferior): Update.
3604         (proceed_after_vfork_done): Update.
3605         (handle_vfork_child_exec_or_exit): Update.
3606         (follow_exec): Update.
3607         (displaced_step_prepare_throw): Update.
3608         (displaced_step_restore): Update.
3609         (start_step_over): Update.
3610         (resume_1): Update.
3611         (clear_proceed_status_thread): Update.
3612         (proceed): Update.
3613         (print_target_wait_results): Update.
3614         (do_target_wait): Update.
3615         (context_switch): Update.
3616         (stop_all_threads): Update.
3617         (restart_threads): Update.
3618         (finish_step_over): Update.
3619         (handle_signal_stop): Update.
3620         (switch_back_to_stepped_thread): Update.
3621         (keep_going_pass_signal): Update.
3622         (print_exited_reason): Update.
3623         (normal_stop): Update.
3624         * inferior.c (inferior_pid_to_str): Change return type.
3625         (print_selected_inferior): Update.
3626         (add_inferior): Update.
3627         (detach_inferior): Update.
3628         * dummy-frame.c (fprint_dummy_frames): Update.
3629         * dcache.c (dcache_info_1): Update.
3630         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3631         (btrace_fetch, btrace_clear): Update.
3632         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3633         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3634         type.
3635         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3636         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3637         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3638         * gdbarch.c, gdbarch.h: Rebuild.
3639         * gdbarch.sh (core_pid_to_str): Change return type.
3640         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3641         return type.
3642         (windows_nat_target::pid_to_str): Change return type.
3643         (windows_delete_thread): Update.
3644         (windows_nat_target::attach): Update.
3645         (windows_nat_target::files_info): Update.
3646         * target-delegates.c: Rebuild.
3647         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3648         return type.
3649         (sol_thread_target::pid_to_str): Change return type.
3650         * remote.c (class remote_target) <pid_to_str>: Change return
3651         type.
3652         (remote_target::pid_to_str): Change return type.
3653         (extended_remote_target::attach, remote_target::remote_stop_ns)
3654         (remote_target::remote_notif_remove_queued_reply)
3655         (remote_target::push_stop_reply, remote_target::disable_btrace):
3656         Update.
3657         (extended_remote_target::attach): Update.
3658         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3659         type.
3660         (gdbsim_target::pid_to_str): Change return type.
3661         * ravenscar-thread.c (struct ravenscar_thread_target)
3662         <pid_to_str>: Change return type.
3663         (ravenscar_thread_target::pid_to_str): Change return type.
3664         * procfs.c (class procfs_target) <pid_to_str>: Change return
3665         type.
3666         (procfs_target::pid_to_str): Change return type.
3667         (procfs_target::attach): Update.
3668         (procfs_target::detach): Update.
3669         (procfs_target::fetch_registers): Update.
3670         (procfs_target::store_registers): Update.
3671         (procfs_target::wait): Update.
3672         (procfs_target::files_info): Update.
3673         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3674         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3675         return type.
3676         (nto_procfs_target::pid_to_str): Change return type.
3677         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3678         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3679         return type.
3680         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3681         (exit_lwp): Update.
3682         (attach_proc_task_lwp_callback, get_detach_signal)
3683         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3684         (linux_nat_target::resume, wait_lwp, stop_callback)
3685         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3686         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3687         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3688         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3689         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3690         type.
3691         (inf_ptrace_target::attach): Update.
3692         (inf_ptrace_target::files_info): Update.
3693         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3694         type.
3695         (go32_nat_target::pid_to_str): Change return type.
3696         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3697         (gnu_nat_target::wait): Update.
3698         (gnu_nat_target::wait): Update.
3699         (gnu_nat_target::resume): Update.
3700         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3701         (fbsd_nat_target::wait): Update.
3702         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3703         type.
3704         (darwin_nat_target::attach): Update.
3705         * corelow.c (class core_target) <pid_to_str>: Change return type.
3706         (core_target::pid_to_str): Change return type.
3707         * target.c (normal_pid_to_str): Change return type.
3708         (default_pid_to_str): Likewise.
3709         (target_pid_to_str): Change return type.
3710         (target_translate_tls_address): Update.
3711         (target_announce_detach): Update.
3712         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3713         return type.
3714         (bsd_uthread_target::pid_to_str): Change return type.
3715         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3716         type.
3717         (bsd_kvm_target::pid_to_str): Change return type.
3718         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3719         return type.
3720         (aix_thread_target::pid_to_str): Change return type.
3721         * target.h (struct target_ops) <pid_to_str>: Change return type.
3722         (target_pid_to_str, normal_pid_to_str): Likewise.
3723         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3724         type.
3725         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3726         type.
3727         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3728         return type.
3729         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3730         type.
3731         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3732         type.
3733         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3734         return type.
3735
3736 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3737
3738         * NEWS: Mention that the new default MI version is 3.  Mention
3739         changes to the output of commands and events that deal with
3740         multi-location breakpoints.
3741         * breakpoint.c: Include "mi/mi-out.h".
3742         (print_one_breakpoint): Change output syntax if using MI version
3743         >= 3.
3744         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3745         New.
3746         (mi_multi_location_breakpoint_output_fixed): New.
3747         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3748         (mi_cmd_fix_multi_location_breakpoint_output): New.
3749         (mi_multi_location_breakpoint_output_fixed): New.
3750         * mi/mi-cmds.c (mi_cmds): Register command
3751         -fix-multi-location-breakpoint-output.
3752         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3753         interpreter "mi".
3754
3755 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3756
3757         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3758         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3759         instantiate mi_ui_out based on interpreter name.
3760         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3761         * mi/mi-main.c (mi_load_progress): Likewise.
3762
3763 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3764
3765         * NEWS: Combine separate "New targets" sections for 8.3.
3766
3767 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3768
3769         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3770         (ppcfbsd_init_abi): Install gdbarch
3771         "fetch_tls_load_module_address" and "get_thread_local_address"
3772         methods.
3773
3774 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3775
3776         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3777         (riscv_fbsd_init_abi): Install gdbarch
3778         "fetch_tls_load_module_address" and "get_thread_local_address"
3779         methods.
3780
3781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3782
3783         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3784         (i386fbsd_init_abi): Install gdbarch
3785         "fetch_tls_load_module_address" and "get_thread_local_address"
3786         methods.
3787
3788 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3789
3790         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3791         (amd64fbsd_init_abi): Install gdbarch
3792         "fetch_tls_load_module_address" and "get_thread_local_address"
3793         methods.
3794
3795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3796
3797         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3798         (struct fbsd_pspace_data): New type.
3799         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3800         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3801         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3802         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3803         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3804
3805 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3806
3807         * gdbtypes.c (lookup_struct_elt): New function.
3808         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3809         * gdbtypes.h (struct struct_elt): New type.
3810         (lookup_struct_elt): New prototype.
3811
3812 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3813
3814         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3815         remove disabled code block.
3816
3817 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3818
3819         * gdbarch.sh (get_thread_local_address): New method.
3820         * gdbarch.h, gdbarch.c: Regenerate.
3821         * target.c (target_translate_tls_address): Use
3822         gdbarch_get_thread_local_address if present instead of
3823         target::get_thread_local_address.
3824
3825 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3826
3827         * target.h (target::get_thread_local_address): Update comment.
3828
3829 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3830
3831         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3832         objfile->separate_debug_objfile_backlink if not NULL.
3833
3834 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3835
3836         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3837         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3838         (amd64bsd_store_inferior_registers): Likewise.
3839         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3840         Enable segment base registers.
3841         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3842         PT_GETFSBASE and PT_GETGSBASE.
3843         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3844         PT_SETGSBASE.
3845         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3846         segment base registers.
3847         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3848
3849 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3850
3851         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3852         Update calls to i386_target_description to add 'segments'
3853         parameter.
3854         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3855         add segment base registers.
3856         * arch/i386.c (i386_create_target_description): Add 'segments'
3857         parameter to enable segment base registers.
3858         * arch/i386.h (i386_create_target_description): Likewise.
3859         * features/i386/32bit-segments.xml: New file.
3860         * features/i386/32bit-segments.c: Generate.
3861         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3862         call to i386_target_description to add 'segments' parameter.
3863         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3864         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3865         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3866         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3867         if feature is present.
3868         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3869         Add 'segments' parameter to call to i386_target_description.
3870         (i386_target_description): Add 'segments' parameter to enable
3871         segment base registers.
3872         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3873         to call to i386_target_description.
3874         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3875         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3876         Define I386_NUM_REGS.
3877         (i386_target_description): Add 'segments' parameter to enable
3878         segment base registers.
3879
3880 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3881
3882         PR/24325
3883         * source-cache.c: #undef open and close, to avoid unresolved
3884         externals during linking.
3885
3886 2019-03-12  Tom Tromey  <tromey@adacore.com>
3887
3888         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3889         const.  Add initializers.
3890         (_initialize_remote): Don't initialize ptid globals.
3891
3892 2019-03-12  Pedro Alves  <palves@redhat.com>
3893
3894         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3895
3896 2019-03-12  Pedro Alves  <palves@redhat.com>
3897
3898         * cp-name-parser.y (main): Remove unused 'len' variable.
3899
3900 2019-03-12  Tom Tromey  <tromey@adacore.com>
3901
3902         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3903         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3904
3905 2019-03-12  Tom Tromey  <tromey@adacore.com>
3906
3907         * linux-nat.c (iterate_over_lwps): Update.
3908         (stop_callback): Remove parameter.
3909         (stop_wait_callback, detach_callback, resume_set_callback)
3910         (select_singlestep_lwp_callback, set_ignore_sigint)
3911         (status_callback, resumed_callback, resume_clear_callback)
3912         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3913         data parameter.
3914         (linux_nat_target::detach, linux_nat_target::resume)
3915         (linux_stop_and_wait_all_lwps, select_event_lwp)
3916         (linux_nat_filter_event, linux_nat_wait_1)
3917         (linux_nat_target::kill, linux_nat_target::stop)
3918         (linux_nat_target::stop): Update.
3919         (linux_nat_resume_callback): Change type.
3920         (resume_stopped_resumed_lwps, count_events_callback)
3921         (select_event_lwp_callback): Likewise.
3922         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3923         * arm-linux-nat.c (struct update_registers_data): Remove.
3924         (update_registers_callback): Change type.
3925         (arm_linux_insert_hw_breakpoint1): Update.
3926         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3927         parameter.
3928         (x86_linux_dr_set_addr): Update.
3929         (x86_linux_dr_set_control): Update.
3930         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3931         (iterate_over_lwps): Use gdb::function_view.
3932         * nat/aarch64-linux-hw-point.c (struct
3933         aarch64_dr_update_callback_param): Remove.
3934         (debug_reg_change_callback): Change type.
3935         (aarch64_notify_debug_reg_change): Update.
3936         * s390-linux-nat.c (s390_refresh_per_info): Update.
3937
3938 2019-03-11  Tom Tromey  <tromey@adacore.com>
3939
3940         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3941         redundant assignment to "this_cu".
3942
3943 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3944
3945         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3946
3947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3948
3949         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3950         from...
3951         (rank_one_type): ... this.
3952
3953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3954
3955         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3956         from...
3957         (rank_one_type): ... this.
3958
3959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3960
3961         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3962         from...
3963         (rank_one_type): ... this.
3964
3965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3966
3967         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3968         from...
3969         (rank_one_type): ... this.
3970
3971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3972
3973         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3974         from...
3975         (rank_one_type): ... this.
3976
3977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3978
3979         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3980         from...
3981         (rank_one_type): ... this.
3982
3983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3984
3985         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3986         from...
3987         (rank_one_type): ... this.
3988
3989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3990
3991         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3992         from...
3993         (rank_one_type): ... this.
3994
3995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3996
3997         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3998         from...
3999         (rank_one_type): ... this.
4000
4001 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4002
4003         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4004         from...
4005         (rank_one_type): ... this.
4006
4007 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4008
4009         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4010         from...
4011         (rank_one_type): ... this.
4012
4013 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4014
4015         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4016         from...
4017         (rank_one_type): ... this.
4018
4019 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4020
4021         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4022         inferior-events' shows the example events.
4023
4024 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4025
4026         Support styling on native MS-Windows console
4027
4028         PR/24315
4029         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4030         on MS-Windows if $TERM is not defined.
4031
4032         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4033
4034         * posix-hdep.c (gdb_console_fputs):
4035         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4036         functions.
4037         * ui-file.h (gdb_console_fputs): Add prototype.
4038
4039         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4040         back to fputs only if the former returns zero.
4041
4042 2019-03-07  Tom Tromey  <tom@tromey.com>
4043
4044         * symmisc.c (print_symbol_bcache_statistics): Update.
4045         (print_objfile_statistics): Update.
4046         * symfile.c (allocate_symtab): Update.
4047         * stabsread.c: Don't include bcache.h.
4048         * psymtab.h (struct psymbol_bcache): Don't declare.
4049         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4050         (psymbol_bcache_init, psymbol_bcache_free)
4051         (psymbol_bcache_get_bcache): Don't declare.
4052         * psymtab.c (struct psymbol_bcache): Remove.
4053         (psymtab_storage::psymtab_storage): Update.
4054         (psymtab_storage::~psymtab_storage): Update.
4055         (psymbol_bcache_init, psymbol_bcache_free)
4056         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4057         (add_psymbol_to_bcache): Update.
4058         (allocate_psymtab): Update.
4059         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4060         macro_cache>: No longer pointers.
4061         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4062         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4063         * macrotab.c (macro_bcache): Update.
4064         * macroexp.c: Don't include bcache.h.
4065         * gdbtypes.c (check_types_worklist): Update.
4066         (types_deeply_equal): Remove TRY/CATCH.  Update.
4067         * elfread.c (elf_symtab_read): Update.
4068         * dwarf2read.c: Don't include bcache.h.
4069         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4070         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4071         (print_bcache_statistics, bcache_memory_used): Don't declare.
4072         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4073         methods.  Rename all data members.
4074         * bcache.c (struct bcache): Move to bcache.h.
4075         (bcache::expand_hash_table): Rename from expand_hash_table.
4076         (bcache): Remove.
4077         (bcache::insert): Rename from bcache_full.
4078         (bcache::compare): Rename from bcache_compare.
4079         (bcache_xmalloc): Remove.
4080         (bcache::~bcache): Rename from bcache_xfree.
4081         (bcache::print_statistics): Rename from print_bcache_statistics.
4082         (bcache::memory_used): Rename from bcache_memory_used.
4083
4084 2019-03-07  Pedro Alves  <palves@redhat.com>
4085
4086         * infrun.c (normal_stop): Also check for
4087         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4088
4089 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4090
4091         * f-lang.c (value_from_host_double): Moved to...
4092         * value.c (value_from_host_double): ...here.
4093         * value.h (value_from_host_double): Declare.
4094         * guile/scm-math.c (vlscm_convert_typed_number): Use
4095         value_from_host_double.
4096         (vlscm_convert_number): Likewise.
4097         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4098         * python/py-value.c (convert_value_from_python): Likewise.
4099
4100 2019-03-06  Tom Tromey  <tom@tromey.com>
4101
4102         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4103
4104 2019-03-06  Tom Tromey  <tom@tromey.com>
4105
4106         * utils.h (free_current_contents): Don't declare.
4107         * utils.c (free_current_contents): Remove.
4108
4109 2019-03-06  Tom Tromey  <tom@tromey.com>
4110
4111         * top.c (quit_force): Update.
4112         * main.c (captured_command_loop): Update.
4113         * common/new-op.c (operator new): Update.
4114         * common/common-exceptions.c (struct catcher)
4115         <save_cleanup_chain>: Remove member.
4116         (exceptions_state_mc_init): Update.
4117         (exception_try_scope_entry): Return nullptr.
4118         (exception_try_scope_exit, exception_rethrow)
4119         (throw_exception_sjlj, throw_exception_cxx): Update.
4120         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4121         (all_cleanups, do_cleanups, discard_cleanups)
4122         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4123         (restore_cleanups, restore_final_cleanups): Don't declare.
4124         (do_final_cleanups): Remove parameter.
4125         * common/cleanups.c (cleanup_chain, make_cleanup)
4126         (make_cleanup_dtor, all_cleanups, do_cleanups)
4127         (discard_my_cleanups, discard_cleanups)
4128         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4129         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4130         (null_cleanup): Remove.
4131         (do_final_cleanups): Remove parameter.
4132
4133 2019-03-06  Tom Tromey  <tom@tromey.com>
4134
4135         * remote.c (remote_target::remote_parse_stop_reply): Use
4136         unique_xmalloc_ptr.
4137
4138 2019-03-06  Tom Tromey  <tom@tromey.com>
4139
4140         * stabsread.c (struct stabs_field_info): Rename from field_info.
4141         <list, fnlist>: Add initializers.
4142         <obstack>: New member.
4143         (read_member_functions, read_struct_fields, read_baseclasses):
4144         Allocate on obstack.  Don't use cleanups.
4145         (read_one_struct_field, read_member_functions, read_struct_fields)
4146         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4147         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4148         (read_struct_type): Update.
4149
4150 2019-03-06  Tom Tromey  <tom@tromey.com>
4151
4152         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4153         * common/filestuff.h (make_cleanup_close): Don't declare.
4154         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4155         Remove.
4156
4157 2019-03-06  Tom Tromey  <tom@tromey.com>
4158
4159         * solib-aix.c: Use make_scope_exit.
4160
4161 2019-03-06  Tom Tromey  <tom@tromey.com>
4162
4163         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4164         Use make_scope_exit.
4165
4166 2019-03-06  Tom Tromey  <tom@tromey.com>
4167
4168         * solib-svr4.c (disable_probes_interface): Remove parameter.
4169         (svr4_handle_solib_event): Use make_scope_exit.
4170
4171 2019-03-06  Tom Tromey  <tom@tromey.com>
4172
4173         * remote.c (struct stop_reply_deleter): Remove.
4174         (stop_reply_up): Update.
4175         (struct stop_reply): Derive from notif_event.  Don't typedef.
4176         <regcache>: Now a std::vector.
4177         (stop_reply_xfree): Remove.
4178         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4179         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4180         (remote_target::discard_pending_stop_replies): Use delete.
4181         (remote_target::remote_parse_stop_reply): Update.
4182         (remote_target::process_stop_reply): Update.
4183         * remote-notif.h (struct notif_event): Add virtual destructor.
4184         Remove "dtr" member.
4185         (struct notif_client) <alloc_event>: Return a unique_ptr.
4186         (notif_event_xfree): Don't declare.
4187         (notif_event_up): New typedef.
4188         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4189         (notif_event_xfree, do_notif_event_xfree): Remove.
4190         (remote_notif_state_xfree): Update.
4191
4192 2019-03-06  Tom Tromey  <tom@tromey.com>
4193
4194         * infrun.c (displaced_step_clear_cleanup): Now a
4195         forward_scope_exit type.
4196         (displaced_step_prepare_throw): Update.
4197         (displaced_step_fixup): Update.
4198
4199 2019-03-06  Tom Tromey  <tom@tromey.com>
4200
4201         * inferior.h (class inferior): Update comment.
4202         * gdbthread.h (class thread_info): Update comment.
4203
4204 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4205             Tom Tromey  <tom@tromey.com>
4206
4207         * stabsread.h (struct stab_section_list): Remove.
4208         (coffstab_build_psymtabs): Update.
4209         * dbxread.c (symbuf_sections): Now a std::vector.
4210         (sect_idx): New global.
4211         (fill_symbuf): Update.
4212         (coffstab_build_psymtabs): Change type of stabsects parameter.
4213         Update.
4214         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4215         std::vector.
4216         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4217         (coff_locate_sections): Update.
4218         (coff_symfile_read): Remove cleanups.  Update.
4219         (init_stringtab): Add storage parameter.
4220         (free_stringtab, free_stringtab_cleanup): Remove.
4221         (init_lineno): Add storage parameter.
4222         (free_linetab, free_linetab_cleanup): Remove.
4223
4224 2019-03-06  Pedro Alves  <palves@redhat.com>
4225
4226         * linux-fork.c (fork_info::clobber_regs): Delete.
4227         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4228         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4229         comment.  Adjust.
4230         (scoped_switch_fork_info::scoped_switch_fork_info)
4231         (checkpoint_command, linux_fork_context): Adjust
4232         fork_save_infrun_state calls.
4233
4234 2019-03-06  Pedro Alves  <palves@redhat.com>
4235
4236         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4237         (inf_has_multiple_threads): Return 'bool' and rewrite using
4238         inferior_info::threads().
4239
4240 2019-03-06  Pedro Alves  <palves@redhat.com>
4241
4242         * linux-fork.c: Include <list>.
4243         (fork_list): Now a std::list instance.
4244         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4245         (forks_exist_p, find_last_fork): Adjust.
4246         (new_fork): Delete.
4247         (one_fork_p): New.
4248         (add_fork): Adjust.
4249         (free_fork): Delete, folded into fork_info::~fork_info().
4250         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4251         Adjust.
4252         (init_fork_list): Delete.
4253         (linux_fork_killall, linux_fork_mourn_inferior)
4254         (linux_fork_detach, info_checkpoints_command): Adjust.
4255         (_initialize_linux_fork): No longer call init_fork_list.
4256
4257 2019-03-06  Pedro Alves  <palves@redhat.com>
4258
4259         * linux-fork.c (new_fork): New, split out of ...
4260         (add_fork): ... this.  Return void.  Move "first fork" special
4261         case from here, to ...
4262         (checkpoint_command): ... here.
4263         * linux-linux.h (add_fork): Return void.
4264
4265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4266
4267         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4268
4269 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4270             Chris January  <chris.january@arm.com>
4271             David Lecomber  <david.lecomber@arm.com>
4272
4273         * f-exp.y: New token, UNOP_INTRINSIC.
4274         (exp): New pattern using UNOP_INTRINSIC token.
4275         (f77_keywords): Add 'abs' keyword.
4276         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4277         (value_from_host_double): New function.
4278         (evaluate_subexp_f): Support UNOP_ABS.
4279
4280 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4281
4282         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4283         types.
4284
4285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4286
4287         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4288         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4289         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4290
4291 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4292
4293         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4294
4295 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4296             Chris January  <chris.january@arm.com>
4297
4298         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4299         * f-exp.y: Define 'KIND' token.
4300         (exp): New pattern for KIND expressions.
4301         (ptype): Handle types with a kind extension.
4302         (direct_abs_decl): Extend to spot kind extensions.
4303         (f77_keywords): Add 'kind' to the list.
4304         (push_kind_type): New function.
4305         (convert_to_kind_type): New function.
4306         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4307         * parse.c (operator_length_standard): Likewise.
4308         * parser-defs.h (enum type_pieces): Add tp_kind.
4309         * std-operator.def: Add UNOP_KIND.
4310
4311 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4312
4313         * f-exp.y (f_parse): Set yydebug.
4314
4315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4316
4317         * f-lang.c (evaluate_subexp_f): New function.
4318         (exp_descriptor_f): New global.
4319         (f_language_defn): Use exp_descriptor_f instead of
4320         exp_descriptor_standard.
4321
4322 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         * f-exp.y (struct token): Add comments.
4325         (dot_ops): Remove uppercase versions and the end marker.
4326         (f77_keywords): Likewise.
4327         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4328         entries in the dot_ops array are case insensitive, and use
4329         strncasecmp to compare strings.  Also some whitespace cleanup in
4330         this area.  Similar for the f77_keywords array, except entries in
4331         this list might be case sensitive.
4332
4333 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4334
4335         * f-exp.y (struct f77_boolean_val): Add comments.
4336         (boolean_values): Remove uppercase versions, and end marker.
4337         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4338         and use strncasecmp to achieve case insensitivity.  Additionally,
4339         perform whitespace cleanup around this code.
4340
4341 2019-03-06  Tom Tromey  <tromey@adacore.com>
4342
4343         * remote-sim.c (gdbsim_target_open): Use result of
4344         gdb_argv::release.
4345
4346 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4347         Dirk Schubert  <dirk.schubert@arm.com>
4348         Chris January  <chris.january@arm.com>
4349
4350         * eval.c (evaluate_subexp_standard): Call Fortran argument
4351         wrapping logic.
4352         * f-lang.c (struct value): A value which can be passed into a
4353         Fortran function call.
4354         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4355         where appropriate.
4356         (struct type): Value ready for a Fortran function call.
4357         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4358         is needed.
4359         * f-lang.h (fortran_argument_convert): Declaration.
4360         (fortran_preserve_arg_pointer): Declaration.
4361         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4362
4363 2019-03-05  Tom Tromey  <tromey@adacore.com>
4364
4365         * python/py-prettyprint.c (print_string_repr): Remove #if.
4366         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4367
4368 2019-03-05  Tom Tromey  <tromey@adacore.com>
4369
4370         * target.c (the_dummy_target): Move later.  Change type to
4371         "dummy_target".
4372         (initialize_targets): Don't initialize the_dummy_target.
4373
4374 2019-03-05  Tom Tromey  <tromey@adacore.com>
4375
4376         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4377         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4378
4379 2019-03-05  Tom Tromey  <tromey@adacore.com>
4380
4381         * windows-nat.c (windows_nat_target::attach)
4382         (windows_nat_target::detach): Don't call gdb_flush.
4383         * valprint.c (generic_val_print, val_print, val_print_string):
4384         Don't call gdb_flush.
4385         * utils.c (defaulted_query): Don't call gdb_flush.
4386         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4387         * target.c (target_announce_detach): Don't call gdb_flush.
4388         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4389         * remote.c (extended_remote_target::attach): Don't call
4390         gdb_flush.
4391         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4392         * printcmd.c (do_examine): Don't call gdb_flush.
4393         (info_display_command): Don't call gdb_flush.
4394         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4395         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4396         * memattr.c (info_mem_command): Don't call gdb_flush.
4397         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4398         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4399         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4400         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4401         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4402         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4403         (gnu_nat_target::detach): Don't call gdb_flush.
4404         * f-valprint.c (f_val_print): Don't call gdb_flush.
4405         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4406         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4407         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4408         gdb_flush.
4409         * c-valprint.c (c_val_print): Don't call gdb_flush.
4410         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4411
4412 2019-03-05  Tom Tromey  <tromey@adacore.com>
4413
4414         * varobj.c (update_dynamic_varobj_children): Update.
4415         (install_default_visualizer): Use reset, not release.
4416         * value.c (set_internalvar): Update.
4417         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4418         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4419         ATTRIBUTE_UNUSED_RESULT.
4420
4421 2019-03-05  Tom Tromey  <tromey@adacore.com>
4422
4423         * remote.c (class scoped_remote_fd) <release>: Add
4424         ATTRIBUTE_UNUSED_RESULT.
4425
4426 2019-03-05  Tom Tromey  <tromey@adacore.com>
4427
4428         * macroexp.c (struct macro_buffer) <release>: Add
4429         ATTRIBUTE_UNUSED_RESULT.
4430
4431 2019-03-05  Tom Tromey  <tromey@adacore.com>
4432
4433         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4434         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4435         ATTRIBUTE_UNUSED_RESULT.
4436
4437 2019-03-05  Tom Tromey  <tromey@adacore.com>
4438
4439         * common/scoped_fd.h (class scoped_fd) <release>: Add
4440         ATTRIBUTE_UNUSED_RESULT.
4441
4442 2019-03-05  Tom Tromey  <tromey@adacore.com>
4443
4444         * parser-defs.h (struct parser_state) <release>: Add
4445         ATTRIBUTE_UNUSED_RESULT.
4446
4447 2019-03-05  Tom Tromey  <tromey@adacore.com>
4448
4449         * utils.h (class gdb_argv) <release>: Add
4450         ATTRIBUTE_UNUSED_RESULT.
4451         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4452
4453 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4454
4455         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4456         for-loop range, to avoid compiler warnings.
4457
4458         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4459         avoid compiler warnings about unused variables.
4460
4461         * NEWS: Mention end of support for native debugging on MS-Windows
4462         before XP.
4463
4464         PR gdb/24292
4465         * common/netstuff.c:
4466         * gdbserver/gdbreplay.c
4467         * gdbserver/remote-utils.c:
4468         * ser-tcp.c:
4469         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4470         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4471         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4472         'getaddrinfo' and 'freeaddrinfo' were not available before
4473         Windows XP, and mingw.org's MinGW headers by default define
4474         _WIN32_WINNT to 0x500.
4475
4476 2019-03-01  Gary Benson <gbenson@redhat.com>
4477
4478         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4479
4480 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4481             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4482
4483         PR gdb/8527
4484         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4485         set_sigint_trap, clear_sigint_trap.
4486
4487 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4488
4489         * target.c (target_detach): Clear the regcache and the
4490         frame cache.
4491
4492 2019-02-27  Pedro Alves  <palves@redhat.com>
4493
4494         * utils.c (set_screen_size): When we cap the height/width sizes,
4495         tweak the corresponding command variable to show "unlimited":
4496
4497 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4498             Pedro Alves  <palves@redhat.com>
4499
4500         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4501         before calling rl_set_screen_size.
4502
4503 2019-02-27  Tom Tromey  <tromey@adacore.com>
4504
4505         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4506         define.
4507         * python/py-value.c: Remove Python 2.4 workaround.
4508         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4509         workaround.
4510         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4511         Python 2.4 workaround.
4512         * python/python-internal.h: Remove Python 2.4 comment.
4513         (Py_ssize_t): Don't define.
4514         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4515         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4516         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4517         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4518         * python/python.c (do_start_initialization): Remove Python 2.4
4519         workaround.
4520         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4521         (print_children): Remove Python 2.4 workaround.
4522         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4523         workaround.
4524         (CHARBUFFERPROC_NAME): Remove.
4525         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4526         Python 2.4 workaround.
4527
4528 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4529
4530         * NEWS: Note minimum Python version.
4531
4532 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4533
4534         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4535         code from these functions.  Remove corresponding ifdefs.  Use
4536         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4537         Remove gotos and target of gotos.
4538         (infpy_search_memory): Likewise.
4539
4540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4541
4542         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4543         (hppa_gdbarch_init): Don't register deleted functions with
4544         gdbarch.
4545
4546 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4547
4548         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4549         (h8300_unwind_sp): Delete.
4550         (h8300_dummy_id): Delete.
4551         (h8300_gdbarch_init): Don't register deleted functions with
4552         gdbarch.
4553
4554 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4555
4556         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4557         (ft32_unwind_pc): Delete.
4558         (ft32_unwind_sp): Delete.
4559         (ft32_gdbarch_init): Don't register deleted functions with
4560         gdbarch.
4561
4562 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4563
4564         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4565         (frv_unwind_pc): Delete.
4566         (frv_unwind_sp): Delete.
4567         (frv_gdbarch_init): Don't register deleted functions with
4568         gdbarch.
4569
4570 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4571
4572         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4573         (riscv_unwind_pc): Delete.
4574         (riscv_unwind_sp): Delete.
4575         (riscv_gdbarch_init): Don't register deleted functions with
4576         gdbarch.
4577
4578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4579
4580         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4581         (csky_unwind_pc): Delete.
4582         (csky_unwind_sp): Delete.
4583         (csky_gdbarch_init): Don't register deleted functions with
4584         gdbarch.
4585
4586 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4587
4588         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4589         (cris_unwind_pc): Delete.
4590         (cris_unwind_sp): Delete.
4591         (cris_gdbarch_init): Don't register deleted functions with
4592         gdbarch.
4593
4594 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4595
4596         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4597         (bfin_unwind_pc): Delete.
4598         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4599
4600 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4601
4602         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4603         (arm_unwind_pc): Delete.
4604         (arm_unwind_sp): Delete.
4605         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4606
4607 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4608
4609         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4610         (arc_unwind_pc): Delete.
4611         (arc_unwind_sp): Delete.
4612         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4613
4614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4615
4616         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4617         (alpha_unwind_pc): Delete.
4618         (alpha_gdbarch_init): Don't register deleted functions with
4619         gdbarch.
4620
4621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4622
4623         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4624         (aarch64_unwind_pc): Delete.
4625         (aarch64_unwind_sp): Delete.
4626         (aarch64_gdbarch_init): Don't register deleted functions with
4627         gdbarch.
4628
4629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4630
4631         * gdbtypes.c (type_align): Don't consider static members when
4632         computing structure alignment.
4633
4634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4635
4636         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4637         return 0 for other types.
4638         * arch-utils.c (default_type_align): Always return 0.
4639         * gdbarch.h: Regenerate.
4640         * gdbarch.sh (type_align): Extend comment.
4641         * gdbtypes.c (type_align): Add additional comments, always call
4642         gdbarch_type_align before applying the default rules.
4643         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4644         generic code will then apply a suitable default.
4645         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4646         types, return 0 for other types.
4647
4648 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4649
4650         * NEWS: Create a new section for the next release branch.
4651         Rename the section of the current branch, now that it has
4652         been cut.
4653
4654 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4655
4656         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4657         * version.in: Bump version to 8.3.50.DATE-git.
4658
4659 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4660
4661         * aix-thread.c (ptid_cmp): Remove unused variable.
4662         (get_signaled_thread): Likewise.
4663         (store_regs_user_thread): Likewise.
4664         (store_regs_kernel_thread): Likewise.
4665         (fetch_regs_kernel_thread): Remove shadowed variable.
4666
4667 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4668
4669         * features/riscv/32bit-cpu.xml: Add register numbers.
4670         * features/riscv/32bit-fpu.c: Regenerate.
4671         * features/riscv/32bit-fpu.xml: Add register numbers.
4672         * features/riscv/64bit-cpu.xml: Add register numbers.
4673         * features/riscv/64bit-fpu.c: Regenerate.
4674         * features/riscv/64bit-fpu.xml: Add register numbers.
4675
4676 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4677
4678         * NEWS: Mention two argument form of gdb.Value constructor.
4679         * python/py-value.c (convert_buffer_and_type_to_value): New
4680         function.
4681         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4682         Add support for handling an optional second argument.  Call
4683         convert_buffer_and_type_to_value as appropriate.
4684         * python/python-internal.h (Py_buffer_deleter): New struct.
4685         (Py_buffer_up): New typedef.
4686
4687 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4688
4689         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4690         instead of releasing ownership.
4691
4692 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4693
4694         * dwarf2read.c (open_and_init_dwp_file): Call
4695         elf_numsections instead of bfd_count_sections to initialize
4696         dwp_file->num_sections.
4697
4698 2019-02-25  Tom Tromey  <tromey@adacore.com>
4699
4700         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4701
4702 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4703
4704         * gcore.in: Add '--readnever' option when invoking GDB.
4705
4706 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4707
4708         * MAINTAINERS: Update my email address.
4709
4710 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4711
4712         * build-id.c (build_id_to_debug_bfd_1): New function.
4713         (build_id_to_debug_bfd): Look for separate debug file in
4714         sysroot.
4715
4716 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4717
4718         * gdbarch.sh: Update the copyright year range that is placed into
4719         generated files.
4720
4721 2019-02-22  Keith Seitz  <keiths@redhat.com>
4722
4723         PR symtab/23853
4724         * linespec.c (create_sals_line_offset): Search for the default
4725         symtab's filename instead of its fullname.
4726
4727 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4728
4729         * NEWS: Update style defaults.
4730
4731 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4732
4733         * main.c (captured_main_1): Disable styling in batch mode.
4734
4735 2019-02-20  Tom Tromey  <tom@tromey.com>
4736
4737         * symtab.c (symtab_symbol_info): Fix typos.
4738
4739 2019-02-20  Tom Tromey  <tromey@adacore.com>
4740
4741         * findcmd.c (_initialize_mem_search): Use upper case for
4742         metasyntactic variables.
4743
4744 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4745
4746         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4747         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4748
4749 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4750
4751         * top.h (source_file_name): Change to std::string.
4752         * top.c (source_file_name): Likewise.
4753         (command_line_input): Adjust.
4754         * cli/cli-script.c (script_from_file): Adjust.
4755
4756 2019-02-19  Tom Tromey  <tromey@adacore.com>
4757
4758         * ravenscar-thread.c
4759         (ravenscar_thread_target::update_thread_list): Don't call
4760         ada_build_task_list.
4761         * ada-lang.h (ada_build_task_list): Don't declare.
4762         * ada-tasks.c (struct ada_tasks_inferior_data)
4763         <task_list_valid_p>: Now bool.
4764         (read_known_tasks, ada_task_list_changed)
4765         (ada_tasks_invalidate_inferior_data): Update.
4766         (read_known_tasks_array): Return bool.
4767         (read_known_tasks_list): Likewise.
4768         (read_known_tasks): Return void.
4769         (ada_build_task_list): Now static.
4770
4771 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4772
4773         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4774         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4775
4776 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4777
4778         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4779         variant for ada_tasks_pspace_data_handle and
4780         ada_tasks_inferior_data_handle.
4781         (ada_tasks_pspace_data_cleanup): New function.
4782         (ada_tasks_inferior_data_cleanup): New function.
4783
4784 2019-02-17  Tom Tromey  <tom@tromey.com>
4785
4786         * macrotab.h (macro_source_fullname): Return a std::string.
4787         * macrotab.c (macro_include, check_for_redefinition)
4788         (macro_undef, macro_lookup_definition, foreach_macro)
4789         (foreach_macro_in_scope): Update.
4790         (macro_source_fullname): Return a std::string.
4791         * macrocmd.c (show_pp_source_pos): Update.
4792
4793 2019-02-17  Tom Tromey  <tom@tromey.com>
4794
4795         * macrocmd.c (show_pp_source_pos): Style the file names.
4796
4797 2019-02-17  Tom Tromey  <tom@tromey.com>
4798
4799         PR tui/24197:
4800         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4801
4802 2019-02-17  Tom Tromey  <tom@tromey.com>
4803
4804         * ada-lang.c (user_select_syms): Use filtered printing.
4805         * utils.c (wrap_style): New global.
4806         (desired_style): Remove.
4807         (emit_style_escape): Add stream parameter.
4808         (set_output_style, reset_terminal_style, prompt_for_continue):
4809         Update.
4810         (flush_wrap_buffer): Only flush gdb_stdout.
4811         (wrap_here): Set wrap_style.
4812         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4813         treat escape sequences as a character.  Change when wrap buffer is
4814         flushed.
4815         (fputs_styled): Do not set the output style when the default is
4816         requested.
4817         * ui-style.h (struct ui_file_style) <is_default>: New method.
4818         * source.c (print_source_lines_base): Emit escape sequences in one
4819         piece.
4820
4821 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4822
4823         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4824         integers and enumeration types.
4825
4826 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4827
4828         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4829         instead of lookup_symbol_in_language
4830         (do_exact_match): New function.
4831         (ada_get_symbol_name_matcher): Return do_exact_match when
4832         doing a verbatim match.
4833
4834 2019-02-15  Tom Tromey  <tromey@adacore.com>
4835
4836         * ravenscar-thread.c (ravenscar_thread_target::resume)
4837         (ravenscar_thread_target::wait): Special case wildcard requests.
4838
4839 2019-02-15  Tom Tromey  <tromey@adacore.com>
4840
4841         * ravenscar-thread.c (base_ptid): Remove.
4842         (struct ravenscar_thread_target) <close>: New method.
4843         <m_base_ptid>: New member.
4844         <update_inferior_ptid, active_task, task_is_currently_active,
4845         runtime_initialized>: Declare methods.
4846         <ravenscar_thread_target>: Add constructor.
4847         (ravenscar_thread_target::task_is_currently_active)
4848         (ravenscar_thread_target::update_inferior_ptid)
4849         (ravenscar_runtime_initialized): Rename.  Now methods.
4850         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4851         (ravenscar_thread_target::update_thread_list): Update.
4852         (ravenscar_thread_target::active_task): Now method.
4853         (ravenscar_thread_target::store_registers)
4854         (ravenscar_thread_target::prepare_to_store)
4855         (ravenscar_thread_target::prepare_to_store)
4856         (ravenscar_thread_target::mourn_inferior): Update.
4857         (ravenscar_inferior_created): Use "new" to create target.
4858         (ravenscar_thread_target::get_ada_task_ptid): Update.
4859         (_initialize_ravenscar): Don't initialize base_ptid.
4860         (ravenscar_ops): Remove global.
4861
4862 2019-02-15  Tom Tromey  <tromey@adacore.com>
4863
4864         * target.h (push_target): Declare new overload.
4865         * target.c (push_target): New overload, taking an rvalue reference.
4866         * remote.c (remote_target::open_1): Use push_target overload.
4867         * corelow.c (core_target_open): Use push_target overload.
4868
4869 2019-02-15  Tom Tromey  <tromey@adacore.com>
4870
4871         * ravenscar-thread.c (is_ravenscar_task)
4872         (ravenscar_task_is_currently_active): Return bool.
4873         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4874         (_initialize_ravenscar): Remove "(void)".
4875         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4876         Return bool.
4877
4878 2019-02-15  Tom Tromey  <tromey@adacore.com>
4879
4880         * ravenscar-thread.c (ravenscar_runtime_initializer)
4881         (has_ravenscar_runtime, get_running_thread_id)
4882         (ravenscar_thread_target::resume): Fix indentation.
4883
4884 2019-02-15  Tom Tromey  <tromey@adacore.com>
4885
4886         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4887         from ravenscar_arch_ops.
4888         (sparc_ravenscar_ops::fetch_registers)
4889         (sparc_ravenscar_ops::store_registers): Now methods.
4890         (sparc_ravenscar_prepare_to_store): Remove.
4891         (sparc_ravenscar_ops): Redefine.
4892         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4893         methods and destructor.  Remove members.
4894         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4895         (ravenscar_thread_target::store_registers)
4896         (ravenscar_thread_target::prepare_to_store): Update.
4897         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4898         Remove.
4899         (struct ppc_ravenscar_powerpc_ops): Derive from
4900         ravenscar_arch_ops.
4901         (ppc_ravenscar_powerpc_ops::fetch_registers)
4902         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4903         (ppc_ravenscar_powerpc_ops): Redefine.
4904         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4905         (ppc_ravenscar_e500_ops::fetch_registers)
4906         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4907         (ppc_ravenscar_e500_ops): Redefine.
4908         * aarch64-ravenscar-thread.c
4909         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4910         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4911         (aarch64_ravenscar_fetch_registers)
4912         (aarch64_ravenscar_store_registers): Now methods.
4913         (aarch64_ravenscar_ops): Redefine.
4914
4915 2019-02-15  Tom Tromey  <tromey@adacore.com>
4916
4917         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4918         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4919         (ravenscar_thread_target::stopped_by_watchpoint)
4920         (ravenscar_thread_target::stopped_data_address)
4921         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4922
4923 2019-02-15  Tom Tromey  <tromey@adacore.com>
4924
4925         * ravenscar-thread.c: Fix some typos.
4926
4927 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4928             Tom Tromey  <tromey@adacore.com>
4929
4930         * ada-lang.c (ada_exception_sal): Change addr_string to a
4931         std::string.
4932         (create_ada_exception_catchpoint): Update.
4933
4934 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4935             Tom Tromey  <tromey@adacore.com>
4936
4937         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4938         (bp_location_ops): Remove.
4939         (base_breakpoint_allocate_location): Update.
4940         (free_bp_location): Update.
4941         * ada-lang.c (class ada_catchpoint_location)
4942         <ada_catchpoint_location>: Remove ops parameter.
4943         (ada_catchpoint_location_dtor): Remove.
4944         (ada_catchpoint_location_ops): Remove.
4945         (allocate_location_exception): Update.
4946         * breakpoint.h (struct bp_location_ops): Remove.
4947         (class bp_location) <bp_location>: Remove bp_location_ops
4948         parameter.
4949         <~bp_location>: Add destructor.
4950         <ops>: Remove.
4951
4952 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4953             Pedro Alves  <palves@redhat.com>
4954
4955         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4956         'PATH_MAX'.
4957
4958 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4959             Samuel Thibault  <samuel.thibault@gnu.org>
4960             Thomas Schwinge  <thomas@codesourcery.com>
4961
4962         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4963         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4964
4965 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4966
4967         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4968         (check_empty): Use "const char *".
4969
4970         * gnu-nat.c (gnu_nat_target::detach): Instead of
4971         'detach_inferior (pid)' call
4972         'detach_inferior (find_inferior_pid (pid))'.
4973
4974         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4975         'nat/fork-inferior.o'.
4976         * gnu-nat.c: #include "nat/fork-inferior.h".
4977
4978         * gnu-nat.c (gnu_nat_target::detach): Instead of
4979         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4980         * gnu-nat.h: #include "inf-child.h".
4981         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4982         'i386_gnu_nat_target::fetch_registers'.
4983         (gnu_store_registers): Rename/move to
4984         'i386_gnu_nat_target::store_registers'.
4985
4986         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4987         * gnu-nat.h (mach_thread_info): New function.
4988         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4989
4990         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4991
4992 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4993
4994         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4995
4996 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4997
4998         * windows-nat.c (windows_add_thread): Add new parameter
4999         "main_thread_p" with default value set to false.  Update
5000         function documentation as well as all callers.
5001         (windows_delete_thread): Likewise.
5002         (fake_create_process): Update call to windows_add_thread.
5003         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5004         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5005         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5006         call to windows_delete_thread.
5007
5008 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5009
5010         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5011
5012 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5013
5014         * symfile.c (find_separate_debug_file): Use canonical path of
5015         sysroot with child_path instead of gdb_sysroot if it is valid.
5016
5017 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5018
5019         * symfile.c (find_separate_debug_file): Use child_path to
5020         determine if an object file is under a sysroot.
5021
5022 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5023
5024         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5025         unittests/child-path-selftests.c.
5026         * common/pathstuff.c (child_path): New function.
5027         * common/pathstuff.h (child_path): New prototype.
5028         * unittests/child-path-selftests.c: New file.
5029
5030 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5031
5032         * symfile.c (find_separate_debug_file): Look for separate debug
5033         files in debug directories under the sysroot.
5034
5035 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5036
5037         * symtab.h (struct minimal_symbol data_p): New const method.
5038         (struct minimal_symbol text_p): Likewise.
5039         * symtab.c (output_source_filename): Use file name style
5040         to print file name.
5041         (print_symbol_info): Likewise.
5042         (print_msymbol_info): Use address style to print addresses.
5043         Use function name style to print executable text symbols.
5044         (expand_symtab_containing_pc): Use data_p.
5045         (find_pc_sect_compunit_symtab): Likewise.
5046
5047 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5048
5049         * breakpoint.c (describe_other_breakpoints): Use address style
5050         to print addresses.
5051         (say_where): Likewise.
5052
5053 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5054
5055         * ada-typeprint.c (print_func_type): Print function name
5056         style to print function name.
5057         * c-typeprint.c (c_print_type_1): Likewise.
5058
5059 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5060
5061         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5062         for execve.
5063
5064 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5065
5066         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5067         type_stack.
5068
5069 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5070
5071         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5072         TYPE_CODE_REF types.
5073
5074 2019-02-08  Jim Wilson  <jimw@sifive.com>
5075
5076         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5077         (riscv_linux_fregset): New.
5078         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5079
5080 2019-02-07  Tom Tromey  <tom@tromey.com>
5081
5082         * thread.c (thread_cancel_execution_command): Update.
5083         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5084         methods.
5085         (struct thread_fsm_ops): Remove.
5086         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5087         (thread_fsm_should_stop, thread_fsm_return_value)
5088         (thread_fsm_set_finished, thread_fsm_finished_p)
5089         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5090         Don't declare.
5091         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5092         * infrun.c (clear_proceed_status_thread)
5093         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5094         (print_stop_event): Update.
5095         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5096         Add constructor.
5097         (step_command_fsm_ops): Remove.
5098         (new_step_command_fsm): Remove.
5099         (step_1): Update.
5100         (step_command_fsm::should_stop): Rename from
5101         step_command_fsm_should_stop.
5102         (step_command_fsm::clean_up): Rename from
5103         step_command_fsm_clean_up.
5104         (step_command_fsm::do_async_reply_reason): Rename from
5105         step_command_fsm_async_reply_reason.
5106         (struct until_next_fsm): Inherit from thread_fsm.  Add
5107         constructor.
5108         (until_next_fsm_ops): Remove.
5109         (new_until_next_fsm): Remove.
5110         (until_next_fsm::should_stop): Rename from
5111         until_next_fsm_should_stop.
5112         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5113         (until_next_fsm::do_async_reply_reason): Rename from
5114         until_next_fsm_async_reply_reason.
5115         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5116         constructor.  Change type of breakpoint.
5117         (finish_command_fsm_ops): Remove.
5118         (new_finish_command_fsm): Remove.
5119         (finish_command_fsm::should_stop): Rename from
5120         finish_command_fsm_should_stop.
5121         (finish_command_fsm::clean_up): Rename from
5122         finish_command_fsm_clean_up.
5123         (finish_command_fsm::return_value): Rename from
5124         finish_command_fsm_return_value.
5125         (finish_command_fsm::do_async_reply_reason): Rename from
5126         finish_command_fsm_async_reply_reason.
5127         (finish_command): Update.
5128         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5129         Add constructor.
5130         (call_thread_fsm_ops): Remove.
5131         (call_thread_fsm::call_thread_fsm): Rename from
5132         new_call_thread_fsm.
5133         (call_thread_fsm::should_stop): Rename from
5134         call_thread_fsm_should_stop.
5135         (call_thread_fsm::should_notify_stop): Rename from
5136         call_thread_fsm_should_notify_stop.
5137         (run_inferior_call, call_function_by_hand_dummy): Update.
5138         * cli/cli-interp.c (should_print_stop_to_console): Update.
5139         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5140         Add constructor.  Change type of location_breakpoint,
5141         caller_breakpoint.
5142         (until_break_fsm_ops): Remove.
5143         (new_until_break_fsm): Remove.
5144         (until_break_fsm::should_stop): Rename from
5145         until_break_fsm_should_stop.
5146         (until_break_fsm::clean_up): Rename from
5147         until_break_fsm_clean_up.
5148         (until_break_fsm::do_async_reply_reason): Rename from
5149         until_break_fsm_async_reply_reason.
5150         (until_break_command): Update.
5151         * thread-fsm.c: Remove.
5152         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5153
5154 2019-02-07  Tom Tromey  <tom@tromey.com>
5155
5156         * yy-remap.h: Add include guard.
5157         * xtensa-tdep.h: Add include guard.
5158         * xcoffread.h: Rename include guard.
5159         * varobj-iter.h: Add include guard.
5160         * tui/tui.h: Rename include guard.
5161         * tui/tui-winsource.h: Rename include guard.
5162         * tui/tui-wingeneral.h: Rename include guard.
5163         * tui/tui-windata.h: Rename include guard.
5164         * tui/tui-win.h: Rename include guard.
5165         * tui/tui-stack.h: Rename include guard.
5166         * tui/tui-source.h: Rename include guard.
5167         * tui/tui-regs.h: Rename include guard.
5168         * tui/tui-out.h: Rename include guard.
5169         * tui/tui-layout.h: Rename include guard.
5170         * tui/tui-io.h: Rename include guard.
5171         * tui/tui-hooks.h: Rename include guard.
5172         * tui/tui-file.h: Rename include guard.
5173         * tui/tui-disasm.h: Rename include guard.
5174         * tui/tui-data.h: Rename include guard.
5175         * tui/tui-command.h: Rename include guard.
5176         * tic6x-tdep.h: Add include guard.
5177         * target/waitstatus.h: Rename include guard.
5178         * target/wait.h: Rename include guard.
5179         * target/target.h: Rename include guard.
5180         * target/resume.h: Rename include guard.
5181         * target-float.h: Rename include guard.
5182         * stabsread.h: Add include guard.
5183         * rs6000-tdep.h: Add include guard.
5184         * riscv-fbsd-tdep.h: Add include guard.
5185         * regformats/regdef.h: Rename include guard.
5186         * record.h: Rename include guard.
5187         * python/python.h: Rename include guard.
5188         * python/python-internal.h: Rename include guard.
5189         * python/py-stopevent.h: Rename include guard.
5190         * python/py-ref.h: Rename include guard.
5191         * python/py-record.h: Rename include guard.
5192         * python/py-record-full.h: Rename include guard.
5193         * python/py-record-btrace.h: Rename include guard.
5194         * python/py-instruction.h: Rename include guard.
5195         * python/py-events.h: Rename include guard.
5196         * python/py-event.h: Rename include guard.
5197         * procfs.h: Add include guard.
5198         * proc-utils.h: Add include guard.
5199         * p-lang.h: Add include guard.
5200         * or1k-tdep.h: Rename include guard.
5201         * observable.h: Rename include guard.
5202         * nto-tdep.h: Rename include guard.
5203         * nat/x86-linux.h: Rename include guard.
5204         * nat/x86-linux-dregs.h: Rename include guard.
5205         * nat/x86-gcc-cpuid.h: Add include guard.
5206         * nat/x86-dregs.h: Rename include guard.
5207         * nat/x86-cpuid.h: Rename include guard.
5208         * nat/ppc-linux.h: Rename include guard.
5209         * nat/mips-linux-watch.h: Rename include guard.
5210         * nat/linux-waitpid.h: Rename include guard.
5211         * nat/linux-ptrace.h: Rename include guard.
5212         * nat/linux-procfs.h: Rename include guard.
5213         * nat/linux-osdata.h: Rename include guard.
5214         * nat/linux-nat.h: Rename include guard.
5215         * nat/linux-namespaces.h: Rename include guard.
5216         * nat/linux-btrace.h: Rename include guard.
5217         * nat/glibc_thread_db.h: Rename include guard.
5218         * nat/gdb_thread_db.h: Rename include guard.
5219         * nat/gdb_ptrace.h: Rename include guard.
5220         * nat/fork-inferior.h: Rename include guard.
5221         * nat/amd64-linux-siginfo.h: Rename include guard.
5222         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5223         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5224         * nat/aarch64-linux.h: Rename include guard.
5225         * nat/aarch64-linux-hw-point.h: Rename include guard.
5226         * mn10300-tdep.h: Add include guard.
5227         * mips-linux-tdep.h: Add include guard.
5228         * mi/mi-parse.h: Rename include guard.
5229         * mi/mi-out.h: Rename include guard.
5230         * mi/mi-main.h: Rename include guard.
5231         * mi/mi-interp.h: Rename include guard.
5232         * mi/mi-getopt.h: Rename include guard.
5233         * mi/mi-console.h: Rename include guard.
5234         * mi/mi-common.h: Rename include guard.
5235         * mi/mi-cmds.h: Rename include guard.
5236         * mi/mi-cmd-break.h: Rename include guard.
5237         * m2-lang.h: Add include guard.
5238         * location.h: Rename include guard.
5239         * linux-record.h: Rename include guard.
5240         * linux-nat.h: Add include guard.
5241         * linux-fork.h: Add include guard.
5242         * i386-darwin-tdep.h: Rename include guard.
5243         * hppa-linux-offsets.h: Add include guard.
5244         * guile/guile.h: Rename include guard.
5245         * guile/guile-internal.h: Rename include guard.
5246         * gnu-nat.h: Rename include guard.
5247         * gdb-stabs.h: Rename include guard.
5248         * frv-tdep.h: Add include guard.
5249         * f-lang.h: Add include guard.
5250         * event-loop.h: Add include guard.
5251         * darwin-nat.h: Rename include guard.
5252         * cp-abi.h: Rename include guard.
5253         * config/sparc/nm-sol2.h: Rename include guard.
5254         * config/nm-nto.h: Rename include guard.
5255         * config/nm-linux.h: Add include guard.
5256         * config/i386/nm-i386gnu.h: Rename include guard.
5257         * config/djgpp/nl_types.h: Rename include guard.
5258         * config/djgpp/langinfo.h: Rename include guard.
5259         * compile/gcc-cp-plugin.h: Add include guard.
5260         * compile/gcc-c-plugin.h: Add include guard.
5261         * compile/compile.h: Rename include guard.
5262         * compile/compile-object-run.h: Rename include guard.
5263         * compile/compile-object-load.h: Rename include guard.
5264         * compile/compile-internal.h: Rename include guard.
5265         * compile/compile-cplus.h: Rename include guard.
5266         * compile/compile-c.h: Rename include guard.
5267         * common/xml-utils.h: Rename include guard.
5268         * common/x86-xstate.h: Rename include guard.
5269         * common/version.h: Rename include guard.
5270         * common/vec.h: Rename include guard.
5271         * common/tdesc.h: Rename include guard.
5272         * common/selftest.h: Rename include guard.
5273         * common/scoped_restore.h: Rename include guard.
5274         * common/scoped_mmap.h: Rename include guard.
5275         * common/scoped_fd.h: Rename include guard.
5276         * common/safe-iterator.h: Rename include guard.
5277         * common/run-time-clock.h: Rename include guard.
5278         * common/refcounted-object.h: Rename include guard.
5279         * common/queue.h: Rename include guard.
5280         * common/ptid.h: Rename include guard.
5281         * common/print-utils.h: Rename include guard.
5282         * common/preprocessor.h: Rename include guard.
5283         * common/pathstuff.h: Rename include guard.
5284         * common/observable.h: Rename include guard.
5285         * common/netstuff.h: Rename include guard.
5286         * common/job-control.h: Rename include guard.
5287         * common/host-defs.h: Rename include guard.
5288         * common/gdb_wait.h: Rename include guard.
5289         * common/gdb_vecs.h: Rename include guard.
5290         * common/gdb_unlinker.h: Rename include guard.
5291         * common/gdb_unique_ptr.h: Rename include guard.
5292         * common/gdb_tilde_expand.h: Rename include guard.
5293         * common/gdb_sys_time.h: Rename include guard.
5294         * common/gdb_string_view.h: Rename include guard.
5295         * common/gdb_splay_tree.h: Rename include guard.
5296         * common/gdb_setjmp.h: Rename include guard.
5297         * common/gdb_ref_ptr.h: Rename include guard.
5298         * common/gdb_optional.h: Rename include guard.
5299         * common/gdb_locale.h: Rename include guard.
5300         * common/gdb_assert.h: Rename include guard.
5301         * common/filtered-iterator.h: Rename include guard.
5302         * common/filestuff.h: Rename include guard.
5303         * common/fileio.h: Rename include guard.
5304         * common/environ.h: Rename include guard.
5305         * common/common-utils.h: Rename include guard.
5306         * common/common-types.h: Rename include guard.
5307         * common/common-regcache.h: Rename include guard.
5308         * common/common-inferior.h: Rename include guard.
5309         * common/common-gdbthread.h: Rename include guard.
5310         * common/common-exceptions.h: Rename include guard.
5311         * common/common-defs.h: Rename include guard.
5312         * common/common-debug.h: Rename include guard.
5313         * common/cleanups.h: Rename include guard.
5314         * common/buffer.h: Rename include guard.
5315         * common/btrace-common.h: Rename include guard.
5316         * common/break-common.h: Rename include guard.
5317         * cli/cli-utils.h: Rename include guard.
5318         * cli/cli-style.h: Rename include guard.
5319         * cli/cli-setshow.h: Rename include guard.
5320         * cli/cli-script.h: Rename include guard.
5321         * cli/cli-interp.h: Rename include guard.
5322         * cli/cli-decode.h: Rename include guard.
5323         * cli/cli-cmds.h: Rename include guard.
5324         * charset-list.h: Add include guard.
5325         * buildsym-legacy.h: Rename include guard.
5326         * bfin-tdep.h: Add include guard.
5327         * ax.h: Rename include guard.
5328         * arm-linux-tdep.h: Add include guard.
5329         * arm-fbsd-tdep.h: Add include guard.
5330         * arch/xtensa.h: Rename include guard.
5331         * arch/tic6x.h: Add include guard.
5332         * arch/i386.h: Add include guard.
5333         * arch/arm.h: Rename include guard.
5334         * arch/arm-linux.h: Rename include guard.
5335         * arch/arm-get-next-pcs.h: Rename include guard.
5336         * arch/amd64.h: Add include guard.
5337         * arch/aarch64-insn.h: Rename include guard.
5338         * arch-utils.h: Rename include guard.
5339         * annotate.h: Add include guard.
5340         * amd64-darwin-tdep.h: Rename include guard.
5341         * aarch64-linux-tdep.h: Add include guard.
5342         * aarch64-fbsd-tdep.h: Add include guard.
5343         * aarch32-linux-nat.h: Add include guard.
5344
5345 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5346
5347         * macrotab.c (macro_define_internal): New function that
5348         factorizes macro_define_object_internal and macro_define_function
5349         code.
5350         (macro_define_object_internal): Use macro_define_internal.
5351         (macro_define_function): Likewise.
5352
5353 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5354
5355         * macrocmd.c (extract_identifier): Return
5356         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5357         callers.
5358
5359 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5360
5361         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5362
5363 2019-02-05  Tom Tromey  <tom@tromey.com>
5364
5365         * target.c (target_stack::unpush): Move assertion earlier.
5366
5367 2019-01-30  Tom Tromey  <tom@tromey.com>
5368
5369         PR python/23615:
5370         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5371         (gdbpy_parse_and_eval): Likewise.
5372         * python/python-internal.h (gdbpy_allow_threads): New class.
5373
5374 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5375
5376         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5377         (aarch64_fbsd_fpregmap): Move earlier.
5378         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5379         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5380         instead of individual calls to trad_frame_set_reg_addr.
5381         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5382         earlier.
5383         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5384         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5385         instead of individual calls to trad_frame_set_reg_addr.
5386
5387 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5388
5389         * CONTRIBUTE: Replace contribution list with wiki link.
5390
5391 2019-01-25  Tom Tromey  <tom@tromey.com>
5392
5393         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5394
5395 2019-01-25  Tom Tromey  <tom@tromey.com>
5396
5397         * xtensa-linux-nat.c: Fix common/ includes.
5398         * xml-support.h: Fix common/ includes.
5399         * xml-support.c: Fix common/ includes.
5400         * x86-linux-nat.c: Fix common/ includes.
5401         * windows-nat.c: Fix common/ includes.
5402         * varobj.h: Fix common/ includes.
5403         * varobj.c: Fix common/ includes.
5404         * value.c: Fix common/ includes.
5405         * valops.c: Fix common/ includes.
5406         * utils.c: Fix common/ includes.
5407         * unittests/xml-utils-selftests.c: Fix common/ includes.
5408         * unittests/utils-selftests.c: Fix common/ includes.
5409         * unittests/unpack-selftests.c: Fix common/ includes.
5410         * unittests/tracepoint-selftests.c: Fix common/ includes.
5411         * unittests/style-selftests.c: Fix common/ includes.
5412         * unittests/string_view-selftests.c: Fix common/ includes.
5413         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5414         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5415         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5416         * unittests/rsp-low-selftests.c: Fix common/ includes.
5417         * unittests/parse-connection-spec-selftests.c: Fix common/
5418         includes.
5419         * unittests/optional-selftests.c: Fix common/ includes.
5420         * unittests/offset-type-selftests.c: Fix common/ includes.
5421         * unittests/observable-selftests.c: Fix common/ includes.
5422         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5423         * unittests/memrange-selftests.c: Fix common/ includes.
5424         * unittests/memory-map-selftests.c: Fix common/ includes.
5425         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5426         * unittests/function-view-selftests.c: Fix common/ includes.
5427         * unittests/environ-selftests.c: Fix common/ includes.
5428         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5429         * unittests/common-utils-selftests.c: Fix common/ includes.
5430         * unittests/cli-utils-selftests.c: Fix common/ includes.
5431         * unittests/array-view-selftests.c: Fix common/ includes.
5432         * ui-file.c: Fix common/ includes.
5433         * tui/tui-io.c: Fix common/ includes.
5434         * tracepoint.h: Fix common/ includes.
5435         * tracepoint.c: Fix common/ includes.
5436         * tracefile-tfile.c: Fix common/ includes.
5437         * top.h: Fix common/ includes.
5438         * top.c: Fix common/ includes.
5439         * thread.c: Fix common/ includes.
5440         * target/waitstatus.h: Fix common/ includes.
5441         * target/waitstatus.c: Fix common/ includes.
5442         * target.h: Fix common/ includes.
5443         * target.c: Fix common/ includes.
5444         * target-memory.c: Fix common/ includes.
5445         * target-descriptions.c: Fix common/ includes.
5446         * symtab.h: Fix common/ includes.
5447         * symfile.c: Fix common/ includes.
5448         * stap-probe.c: Fix common/ includes.
5449         * spu-linux-nat.c: Fix common/ includes.
5450         * sparc-nat.c: Fix common/ includes.
5451         * source.c: Fix common/ includes.
5452         * solib.c: Fix common/ includes.
5453         * solib-target.c: Fix common/ includes.
5454         * ser-unix.c: Fix common/ includes.
5455         * ser-tcp.c: Fix common/ includes.
5456         * ser-pipe.c: Fix common/ includes.
5457         * ser-base.c: Fix common/ includes.
5458         * selftest-arch.c: Fix common/ includes.
5459         * s12z-tdep.c: Fix common/ includes.
5460         * rust-exp.y: Fix common/ includes.
5461         * rs6000-aix-tdep.c: Fix common/ includes.
5462         * riscv-tdep.c: Fix common/ includes.
5463         * remote.c: Fix common/ includes.
5464         * remote-notif.h: Fix common/ includes.
5465         * remote-fileio.h: Fix common/ includes.
5466         * remote-fileio.c: Fix common/ includes.
5467         * regcache.h: Fix common/ includes.
5468         * regcache.c: Fix common/ includes.
5469         * record-btrace.c: Fix common/ includes.
5470         * python/python.c: Fix common/ includes.
5471         * python/py-type.c: Fix common/ includes.
5472         * python/py-inferior.c: Fix common/ includes.
5473         * progspace.h: Fix common/ includes.
5474         * producer.c: Fix common/ includes.
5475         * procfs.c: Fix common/ includes.
5476         * proc-api.c: Fix common/ includes.
5477         * printcmd.c: Fix common/ includes.
5478         * ppc-linux-nat.c: Fix common/ includes.
5479         * parser-defs.h: Fix common/ includes.
5480         * osdata.c: Fix common/ includes.
5481         * obsd-nat.c: Fix common/ includes.
5482         * nat/x86-linux.c: Fix common/ includes.
5483         * nat/x86-linux-dregs.c: Fix common/ includes.
5484         * nat/x86-dregs.h: Fix common/ includes.
5485         * nat/x86-dregs.c: Fix common/ includes.
5486         * nat/ppc-linux.c: Fix common/ includes.
5487         * nat/mips-linux-watch.h: Fix common/ includes.
5488         * nat/mips-linux-watch.c: Fix common/ includes.
5489         * nat/linux-waitpid.c: Fix common/ includes.
5490         * nat/linux-ptrace.h: Fix common/ includes.
5491         * nat/linux-ptrace.c: Fix common/ includes.
5492         * nat/linux-procfs.c: Fix common/ includes.
5493         * nat/linux-personality.c: Fix common/ includes.
5494         * nat/linux-osdata.c: Fix common/ includes.
5495         * nat/linux-namespaces.c: Fix common/ includes.
5496         * nat/linux-btrace.h: Fix common/ includes.
5497         * nat/linux-btrace.c: Fix common/ includes.
5498         * nat/fork-inferior.c: Fix common/ includes.
5499         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5500         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5501         * nat/aarch64-linux.c: Fix common/ includes.
5502         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5503         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5504         * namespace.h: Fix common/ includes.
5505         * mips-linux-tdep.c: Fix common/ includes.
5506         * minsyms.c: Fix common/ includes.
5507         * mi/mi-parse.h: Fix common/ includes.
5508         * mi/mi-main.c: Fix common/ includes.
5509         * mi/mi-cmd-env.c: Fix common/ includes.
5510         * memrange.h: Fix common/ includes.
5511         * memattr.c: Fix common/ includes.
5512         * maint.h: Fix common/ includes.
5513         * maint.c: Fix common/ includes.
5514         * main.c: Fix common/ includes.
5515         * machoread.c: Fix common/ includes.
5516         * location.c: Fix common/ includes.
5517         * linux-thread-db.c: Fix common/ includes.
5518         * linux-nat.c: Fix common/ includes.
5519         * linux-fork.c: Fix common/ includes.
5520         * inline-frame.c: Fix common/ includes.
5521         * infrun.c: Fix common/ includes.
5522         * inflow.c: Fix common/ includes.
5523         * inferior.h: Fix common/ includes.
5524         * inferior.c: Fix common/ includes.
5525         * infcmd.c: Fix common/ includes.
5526         * inf-ptrace.c: Fix common/ includes.
5527         * inf-child.c: Fix common/ includes.
5528         * ia64-linux-nat.c: Fix common/ includes.
5529         * i387-tdep.c: Fix common/ includes.
5530         * i386-tdep.c: Fix common/ includes.
5531         * i386-linux-tdep.c: Fix common/ includes.
5532         * i386-linux-nat.c: Fix common/ includes.
5533         * i386-go32-tdep.c: Fix common/ includes.
5534         * i386-fbsd-tdep.c: Fix common/ includes.
5535         * i386-fbsd-nat.c: Fix common/ includes.
5536         * guile/scm-type.c: Fix common/ includes.
5537         * guile/guile.c: Fix common/ includes.
5538         * go32-nat.c: Fix common/ includes.
5539         * gnu-nat.c: Fix common/ includes.
5540         * gdbthread.h: Fix common/ includes.
5541         * gdbarch-selftests.c: Fix common/ includes.
5542         * gdb_usleep.c: Fix common/ includes.
5543         * gdb_select.h: Fix common/ includes.
5544         * gdb_bfd.c: Fix common/ includes.
5545         * gcore.c: Fix common/ includes.
5546         * fork-child.c: Fix common/ includes.
5547         * findvar.c: Fix common/ includes.
5548         * fbsd-nat.c: Fix common/ includes.
5549         * event-top.c: Fix common/ includes.
5550         * event-loop.c: Fix common/ includes.
5551         * dwarf2read.c: Fix common/ includes.
5552         * dwarf2loc.c: Fix common/ includes.
5553         * dwarf2-frame.c: Fix common/ includes.
5554         * dwarf-index-cache.c: Fix common/ includes.
5555         * dtrace-probe.c: Fix common/ includes.
5556         * disasm-selftests.c: Fix common/ includes.
5557         * defs.h: Fix common/ includes.
5558         * csky-tdep.c: Fix common/ includes.
5559         * cp-valprint.c: Fix common/ includes.
5560         * cp-support.h: Fix common/ includes.
5561         * cp-support.c: Fix common/ includes.
5562         * corelow.c: Fix common/ includes.
5563         * completer.h: Fix common/ includes.
5564         * completer.c: Fix common/ includes.
5565         * compile/compile.c: Fix common/ includes.
5566         * compile/compile-loc2c.c: Fix common/ includes.
5567         * compile/compile-cplus-types.c: Fix common/ includes.
5568         * compile/compile-cplus-symbols.c: Fix common/ includes.
5569         * command.h: Fix common/ includes.
5570         * cli/cli-dump.c: Fix common/ includes.
5571         * cli/cli-cmds.c: Fix common/ includes.
5572         * charset.c: Fix common/ includes.
5573         * build-id.c: Fix common/ includes.
5574         * btrace.h: Fix common/ includes.
5575         * btrace.c: Fix common/ includes.
5576         * breakpoint.h: Fix common/ includes.
5577         * breakpoint.c: Fix common/ includes.
5578         * ax.h:
5579         (enum agent_op): Fix common/ includes.
5580         * ax-general.c (struct aop_map): Fix common/ includes.
5581         * ax-gdb.c: Fix common/ includes.
5582         * auxv.c: Fix common/ includes.
5583         * auto-load.c: Fix common/ includes.
5584         * arm-tdep.c: Fix common/ includes.
5585         * arch/riscv.c: Fix common/ includes.
5586         * arch/ppc-linux-common.c: Fix common/ includes.
5587         * arch/i386.c: Fix common/ includes.
5588         * arch/arm.c: Fix common/ includes.
5589         * arch/arm-linux.c: Fix common/ includes.
5590         * arch/arm-get-next-pcs.c: Fix common/ includes.
5591         * arch/amd64.c: Fix common/ includes.
5592         * arch/aarch64.c: Fix common/ includes.
5593         * arch/aarch64-insn.c: Fix common/ includes.
5594         * arch-utils.c: Fix common/ includes.
5595         * amd64-windows-tdep.c: Fix common/ includes.
5596         * amd64-tdep.c: Fix common/ includes.
5597         * amd64-sol2-tdep.c: Fix common/ includes.
5598         * amd64-obsd-tdep.c: Fix common/ includes.
5599         * amd64-nbsd-tdep.c: Fix common/ includes.
5600         * amd64-linux-tdep.c: Fix common/ includes.
5601         * amd64-linux-nat.c: Fix common/ includes.
5602         * amd64-fbsd-tdep.c: Fix common/ includes.
5603         * amd64-fbsd-nat.c: Fix common/ includes.
5604         * amd64-dicos-tdep.c: Fix common/ includes.
5605         * amd64-darwin-tdep.c: Fix common/ includes.
5606         * agent.c: Fix common/ includes.
5607         * ada-lang.h: Fix common/ includes.
5608         * ada-lang.c: Fix common/ includes.
5609         * aarch64-tdep.c: Fix common/ includes.
5610
5611 2019-01-25  Tom Tromey  <tom@tromey.com>
5612
5613         * common/create-version.sh: Use common/version.h.
5614
5615 2019-01-24  Pedro Alves  <palves@redhat.com>
5616
5617         * infrun.c (signal_stop, signal_print, signal_program)
5618         (signal_catch, signal_pass): Now arrays instead of pointers.
5619         (update_signals_program_target, do_target_resume)
5620         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5621         * linux-nat.c (linux_nat_target::pass_signals)
5622         (linux_nat_target::create_inferior, linux_nat_target::attach):
5623         Adjust.
5624         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5625         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5626         * procfs.c (procfs_target::pass_signals): Adjust.
5627         * record-full.c (record_full_target::resume): Adjust.
5628         * remote.c (remote_target::pass_signals)
5629         (remote_target::program_signals): Adjust.
5630         * target-debug.h (target_debug_print_signals): Now takes a
5631         gdb::array_view as parameter.  Adjust.
5632         * target.h (target_ops) <pass_signals, program_signals>: Replace
5633         pointer and length parameters with gdb::array_view.
5634         (target_pass_signals, target_program_signals): Likewise.
5635         * target-delegates.c: Regenerate.
5636
5637 2019-01-24  Pedro Alves  <palves@redhat.com>
5638
5639         * common/forward-scope-exit.h
5640         (forward_scope_exit::forward_scope_exit): Pass arguments to
5641         m_bind_function directly, instead of creating a std::bind and
5642         copying that.
5643
5644 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5645
5646         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5647         for static members.
5648         (pass_in_v_vfp_candidate): Likewise.
5649
5650 2019-01-23  Tom Tromey  <tom@tromey.com>
5651             Pedro Alves  <palves@redhat.com>
5652
5653         * regcache.c (class regcache_invalidator): Remove.
5654         (regcache::raw_write): Use make_scope_exit.
5655
5656 2019-01-23  Tom Tromey  <tom@tromey.com>
5657
5658         * ui-out.h (class ui_out_emit_type): Update comment.
5659
5660 2019-01-23  Tom Tromey  <tom@tromey.com>
5661
5662         * infrun.c (fetch_inferior_event): Update comment.
5663
5664 2019-01-23  Tom Tromey  <tom@tromey.com>
5665             Pedro Alves  <palves@redhat.com>
5666
5667         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5668         parameter.
5669         (fetch_inferior_event): Use SCOPE_EXIT.
5670
5671
5672 2019-01-23  Tom Tromey  <tom@tromey.com>
5673             Pedro Alves  <palves@redhat.com>
5674
5675         * infrun.c (disable_thread_events): Delete.
5676         (stop_all_threads): Use SCOPE_EXIT.
5677
5678 2019-01-23  Tom Tromey  <tom@tromey.com>
5679             Pedro Alves  <palves@redhat.com>
5680
5681         * symfile.c: Include forward-scope-exit.h.
5682         (clear_symtab_users_cleanup): Replace forward declaration with
5683         a FORWARD_SCOPE_EXIT.
5684         (syms_from_objfile_1): Use the forward_scope_exit and
5685         gdb::optional instead of cleanup_function.
5686         (reread_symbols): Use the forward_scope_exit instead of
5687         cleanup_function.
5688         (clear_symtab_users_cleanup): Remove function.
5689
5690 2019-01-23  Tom Tromey  <tom@tromey.com>
5691             Pedro Alves  <palves@redhat.com>
5692
5693         * linux-nat.c: Include scope-exit.h.
5694         (cleanup_target_stop): Remove.
5695         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5696         SCOPE_EXIT.
5697
5698 2019-01-23  Tom Tromey  <tom@tromey.com>
5699             Pedro Alves  <palves@redhat.com>
5700
5701         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5702         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5703
5704 2019-01-23  Tom Tromey  <tom@tromey.com>
5705             Andrew Burgess  <andrew.burgess@embecosm.com>
5706             Pedro Alves  <palves@redhat.com>
5707
5708         * infrun.c (fetch_inferior_event): Use scope_exit.
5709         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5710         * top.c (execute_command): Use scope_exit.
5711         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5712         * utils.c (do_bpstat_clear_actions_cleanup)
5713         (make_bpstat_clear_actions_cleanup): Remove.
5714
5715 2019-01-23  Tom Tromey  <tom@tromey.com>
5716             Pedro Alves  <palves@redhat.com>
5717
5718         * infrun.c: Include "common/scope-exit.h"
5719         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5720         (wait_for_inferior): Use SCOPE_EXIT.
5721         (fetch_inferior_event): Use scope_exit.
5722
5723 2019-01-23  Tom Tromey  <tom@tromey.com>
5724             Pedro Alves  <palves@redhat.com>
5725
5726         * breakpoint.c (create_breakpoint): Remove cleanup.
5727
5728 2019-01-23  Tom Tromey  <tom@tromey.com>
5729             Andrew Burgess  <andrew.burgess@embecosm.com>
5730             Pedro Alves  <palves@redhat.com>
5731
5732 2019-01-23  Pedro Alves  <palves@redhat.com>
5733
5734         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5735
5736 2019-01-23  Pedro Alves  <palves@redhat.com>
5737             Andrew Burgess  <andrew.burgess@embecosm.com>
5738
5739         * gdbthread.h: Include "common/forward-scope-exit.h".
5740         (scoped_finish_thread_state): Redefine custom class in terms of
5741         forward_scope_exit.
5742
5743 2019-01-23  Pedro Alves  <palves@redhat.com>
5744             Andrew Burgess  <andrew.burgess@embecosm.com>
5745
5746         * common/forward-scope-exit.h: New file.
5747
5748 2019-01-23  Pedro Alves  <palves@redhat.com>
5749             Andrew Burgess  <andrew.burgess@embecosm.com>
5750             Tom Tromey  <tom@tromey.com>
5751
5752         * common/scope-exit.h: New file.
5753
5754 2019-01-23  Pedro Alves  <palves@redhat.com>
5755
5756         * common/preprocessor.h (ESC): Rename to ...
5757         (ESC_PARENS): ... this.
5758         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5759         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5760
5761 2019-01-23  Tom Tromey  <tom@tromey.com>
5762
5763         * language.h (class scoped_switch_to_sym_language_if_auto):
5764         Initialize m_lang in both cases.
5765
5766 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5767
5768         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5769         with XCNEW.
5770
5771 2019-01-22  Tom Tromey  <tom@tromey.com>
5772
5773         * corelow.c: Do not include sys/file.h.
5774
5775 2019-01-22  Tom Tromey  <tom@tromey.com>
5776
5777         * tui/tui-wingeneral.h: Include gdb_curses.h.
5778
5779 2019-01-22  Tom Tromey  <tom@tromey.com>
5780
5781         * source-cache.h (class source_cache) <get_source_lines,
5782         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5783
5784 2019-01-22  Tom Tromey  <tom@tromey.com>
5785
5786         * remote-fileio.h (struct remote_target): Declare.
5787
5788 2019-01-22  Tom Tromey  <tom@tromey.com>
5789
5790         * python/py-arch.c: Do not include py-ref.h.
5791         * python/py-bpevent.c: Do not include py-ref.h.
5792         * python/py-cmd.c: Do not include py-ref.h.
5793         * python/py-continueevent.c: Do not include py-ref.h.
5794         * python/py-event.h: Do not include py-ref.h.
5795         * python/py-evtregistry.c: Do not include py-ref.h.
5796         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5797         * python/py-frame.c: Do not include py-ref.h.
5798         * python/py-framefilter.c: Do not include py-ref.h.
5799         * python/py-function.c: Do not include py-ref.h.
5800         * python/py-infevents.c: Do not include py-ref.h.
5801         * python/py-linetable.c: Do not include py-ref.h.
5802         * python/py-objfile.c: Do not include py-ref.h.
5803         * python/py-param.c: Do not include py-ref.h.
5804         * python/py-prettyprint.c: Do not include py-ref.h.
5805         * python/py-progspace.c: Do not include py-ref.h.
5806         * python/py-symbol.c: Do not include py-ref.h.
5807         * python/py-symtab.c: Do not include py-ref.h.
5808         * python/py-type.c: Do not include py-ref.h.
5809         * python/py-unwind.c: Do not include py-ref.h.
5810         * python/py-utils.c: Do not include py-ref.h.
5811         * python/py-value.c: Do not include py-ref.h.
5812         * python/py-varobj.c: Do not include py-ref.h.
5813         * python/py-xmethods.c: Do not include py-ref.h.
5814         * python/python.c: Do not include py-ref.h.
5815         * varobj.c: Do not include py-ref.h.
5816
5817 2019-01-22  Tom Tromey  <tom@tromey.com>
5818
5819         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5820         keyword for bcache.
5821
5822 2019-01-22  Tom Tromey  <tom@tromey.com>
5823
5824         * compile/compile-cplus-types.c: Remove a comment by #include.
5825
5826 2019-01-22  Tom Tromey  <tom@tromey.com>
5827
5828         * compile/gcc-c-plugin.h: Include compile-internal.h.
5829
5830 2019-01-22  Tom Tromey  <tom@tromey.com>
5831
5832         * stabsread.c (EXTERN): Do not define.
5833         (symnum, next_symbol_text_func, processing_gcc_compilation)
5834         (within_function, global_sym_chain, global_stabs)
5835         (previous_stab_code, this_object_header_files)
5836         (n_this_object_header_files)
5837         (n_allocated_this_object_header_files): Define.
5838         * stabsread.h (EXTERN): Never define.  Use "extern".
5839
5840 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5841
5842         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5843         history_value.
5844
5845 2019-01-21  Tom Tromey  <tom@tromey.com>
5846
5847         * ui-out.c: Fix includes.
5848         * tui/tui-source.c: Fix includes.
5849         * target.c: Fix includes.
5850         * remote.c: Fix includes.
5851         * regcache.c: Fix includes.
5852         * python/py-block.c: Fix includes.
5853         * printcmd.c: Fix includes.
5854         * or1k-tdep.c: Fix includes.
5855         * mi/mi-main.c: Fix includes.
5856         * m32r-tdep.c: Fix includes.
5857         * csky-tdep.c: Fix includes.
5858         * compile/compile-cplus-types.c: Fix includes.
5859         * cli/cli-interp.c: Fix includes.
5860
5861 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5862
5863         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5864         for padding.
5865
5866 2019-01-16  Tom Tromey  <tom@tromey.com>
5867
5868         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5869         earlier.
5870         (struct objfile) <msymbols_range>: Move from top level.
5871         <msymbols>: New method.
5872         (class objfile_msymbols): Remove.
5873         * symtab.c (default_collect_symbol_completion_matches_break_on):
5874         Update.
5875         * symmisc.c (dump_msymbols): Update.
5876         * stabsread.c (scan_file_globals): Update.
5877         * objc-lang.c (info_selectors_command, info_classes_command)
5878         (find_methods): Update.
5879         * minsyms.c (find_solib_trampoline_target): Update.
5880         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5881         * coffread.c (coff_symfile_read): Update.
5882         * ada-lang.c (ada_lookup_simple_minsym)
5883         (ada_collect_symbol_completion_matches): Update.
5884
5885 2019-01-16  Tom Tromey  <tom@tromey.com>
5886
5887         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5888         type.  Remove no-argument constructor.
5889         <iterator::operator++>: Simplify.
5890         <begin>: Update.
5891         <end>: Use minimal_symbol_count.
5892
5893 2019-01-16  Tom Tromey  <tom@tromey.com>
5894
5895         * objfiles.h (struct objfile) <psymtabs>: New method.
5896         (class objfile_psymtabs): Remove.
5897         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5898         typedef.
5899         <range>: New method.
5900         (require_partial_symbols): Change return type.
5901         * psymtab.c (require_partial_symbols)
5902         (psym_expand_symtabs_matching): Update.
5903         * mdebugread.c (parse_partial_symbols): Update.
5904         * dbxread.c (dbx_end_psymtab): Update.
5905
5906 2019-01-15  Tom Tromey  <tom@tromey.com>
5907
5908         * symtab.c (lookup_objfile_from_block)
5909         (lookup_symbol_in_objfile_symtabs)
5910         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5911         (find_line_symtab, info_sources_command)
5912         (default_collect_symbol_completion_matches_break_on)
5913         (make_source_files_completion_list): Update.
5914         * symmisc.c (print_objfile_statistics, dump_objfile)
5915         (maintenance_print_symbols, maintenance_info_symtabs)
5916         (maintenance_check_symtabs, maintenance_info_line_tables):
5917         Update.
5918         * source.c (select_source_symtab)
5919         (forget_cached_source_info_for_objfile): Update.
5920         * objfiles.h (class objfile_compunits): Remove.
5921         (struct objfile) <compunits_range>: New typedef.
5922         (compunits): New method.
5923         * objfiles.c (objfile_relocate1): Update.
5924         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5925         * maint.c (count_symtabs_and_blocks): Update.
5926         * linespec.c (iterate_over_all_matching_symtabs): Update.
5927         * cp-support.c (add_symbol_overload_list_qualified): Update.
5928         * coffread.c (coff_symtab_read): Update.
5929         * ada-lang.c (add_nonlocal_symbols)
5930         (ada_collect_symbol_completion_matches)
5931         (ada_add_global_exceptions): Update.
5932
5933 2019-01-15  Tom Tromey  <tom@tromey.com>
5934
5935         * progspace.h (program_space) <objfiles_safe_range>: New
5936         typedef.
5937         <objfiles_safe>: New method.
5938         * objfiles.h (class all_objfiles_safe): Remove.
5939         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5940         * jit.c (jit_inferior_exit_hook): Update.
5941
5942 2019-01-17  Tom Tromey  <tom@tromey.com>
5943
5944         * progspace.h (program_space) <objfiles_range>: New typedef.
5945         <objfiles>: New method.
5946         <objfiles_head>: Rename from objfiles.
5947         (object_files): Update.
5948         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5949         * guile/scm-pretty-print.c
5950         (ppscm_find_pretty_printer_from_objfiles): Update.
5951         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5952         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5953         Update.
5954         * python/py-progspace.c (pspy_get_objfiles): Update.
5955         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5956         Update.
5957         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5958         (objfpy_lookup_objfile_by_build_id): Update.
5959         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5960         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5961         Update.
5962         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5963         (expand_symtab_containing_pc, lookup_objfile_from_block)
5964         (lookup_static_symbol, basic_lookup_transparent_type)
5965         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5966         (find_line_symtab, info_sources_command)
5967         (default_collect_symbol_completion_matches_break_on)
5968         (make_source_files_completion_list, find_main_name): Update.
5969         * symmisc.c (print_symbol_bcache_statistics)
5970         (print_objfile_statistics, maintenance_print_symbols)
5971         (maintenance_print_msymbols, maintenance_print_objfiles)
5972         (maintenance_info_symtabs, maintenance_check_symtabs)
5973         (maintenance_expand_symtabs, maintenance_info_line_tables):
5974         Update.
5975         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5976         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5977         (map_overlay_command, unmap_overlay_command)
5978         (simple_overlay_update, expand_symtabs_matching)
5979         (map_symbol_filenames): Update.
5980         * symfile-debug.c (set_debug_symfile): Update.
5981         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5982         Update.
5983         * source.c (select_source_symtab, forget_cached_source_info):
5984         Update.
5985         * solib.c (solib_read_symbols): Update.
5986         * solib-spu.c (append_ocl_sos): Update.
5987         * psymtab.c (maintenance_print_psymbols)
5988         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5989         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5990         * printcmd.c (info_symbol_command): Update.
5991         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5992         Update.
5993         * objfiles.h (class all_objfiles): Remove.
5994         * objfiles.c (have_partial_symbols, have_full_symbols)
5995         (have_minimal_symbols, qsort_cmp, update_section_map)
5996         (shared_objfile_contains_address_p)
5997         (default_iterate_over_objfiles_in_search_order): Update.
5998         * objc-lang.c (info_selectors_command, info_classes_command)
5999         (find_methods): Update.
6000         * minsyms.c (find_solib_trampoline_target): Update.
6001         * maint.c (maintenance_info_sections)
6002         (maintenance_translate_address, count_symtabs_and_blocks):
6003         Update.
6004         * main.c (captured_main_1): Update.
6005         * linux-thread-db.c (try_thread_db_load_from_pdir)
6006         (has_libpthread): Update.
6007         * linespec.c (iterate_over_all_matching_symtabs)
6008         (search_minsyms_for_name): Update.
6009         * jit.c (jit_find_objf_with_entry_addr): Update.
6010         * hppa-tdep.c (find_unwind_entry)
6011         (hppa_lookup_stub_minimal_symbol): Update.
6012         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6013         Update.
6014         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6015         (elf_gnu_ifunc_resolve_by_got): Update.
6016         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6017         * dwarf-index-write.c (save_gdb_index_command): Update.
6018         * cp-support.c (add_symbol_overload_list_qualified): Update.
6019         * breakpoint.c (create_overlay_event_breakpoint)
6020         (create_longjmp_master_breakpoint)
6021         (create_std_terminate_master_breakpoint)
6022         (create_exception_master_breakpoint): Update.
6023         * blockframe.c (find_pc_partial_function): Update.
6024         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6025         (ada_collect_symbol_completion_matches)
6026         (ada_add_global_exceptions): Update.
6027
6028 2019-01-17  Tom Tromey  <tom@tromey.com>
6029
6030         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6031         declare VEC.
6032         (solib_target_parse_libraries): Change return type.
6033         (library_list_start_segment, library_list_start_section)
6034         (library_list_end_library, library_list_start_library); Update.
6035         (solib_target_free_library_list): Remove.
6036         (solib_target_parse_libraries): Remove cleanup.  Change return
6037         type.
6038         (solib_target_current_sos): Update.
6039
6040 2019-01-17  Tom Tromey  <tromey@bapiya>
6041
6042         * valprint.c: Replace "the the" with "the".
6043         * symtab.c: Replace "the the" with "the".
6044         * solib.c: Replace "the the" with "the".
6045         * solib-dsbt.c: Replace "the the" with "the".
6046         * linespec.c: Replace "the the" with "the".
6047         * dwarf2loc.h: Replace "the the" with "the".
6048         * amd64-windows-tdep.c: Replace "the the" with "the".
6049         * aarch64-tdep.c: Replace "the the" with "the".
6050
6051 2019-01-16  Keith Seitz  <keiths@redhat.com>
6052
6053         PR gdb/23773
6054         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6055         <builder>: Rename to ..
6056         <m_builder>: ... this and make private.
6057         (dwarf2_cu::get_builder): New method.  Change all users of
6058         `builder' to use this method.
6059         (dwarf2_start_symtab): Move to ...
6060         (dwarf2_cu::start_symtab): ... here.  Update all callers
6061         (setup_type_unit_groups): Move to ...
6062         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6063         callers.
6064         (dwarf2_cu::reset_builder): New method.
6065         (process_full_compunit, process_full_type_unit): Use
6066         dwarf2_cu::reset_builder.
6067         (follow_die_offset): Record the ancestor CU if it is different
6068         from the followed DIE's CU.
6069         (follow_die_sig_1): Likewise.
6070
6071 2019-01-15  Tom Tromey  <tom@tromey.com>
6072
6073         * remote.c (class remote_state) <buf>: Now a char_vector.
6074         <buf_size>: Remove.
6075         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6076         parameter.
6077         (remote_target::getpkt_or_notif_sane_1)
6078         (remote_target::getpkt_sane)
6079         (remote_target::getpkt_or_notif_sane): Likewise.
6080         (class remote_target) <putpkt>: New overload.
6081         (remote_target::read_frame): Change type of "buf_p".  Remove
6082         sizeof_p parameter.
6083         (packet_ok): New overload.
6084         (packet_check_result): New overload.
6085         Update all uses.
6086
6087 2019-01-14  Tom Tromey  <tom@tromey.com>
6088
6089         * remote-notif.c (handle_notification, remote_notif_ack)
6090         (remote_notif_parse): Make "buf" const.
6091         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6092         const.
6093         (remote_notif_parse, remote_notif_ack, handle_notification):
6094         Likewise.
6095         * remote.c (remote_notif_stop_parse): Make "buf" const.
6096         (remote_target::remote_parse_stop_reply): Make "buf" const.
6097         (remote_notif_stop_ack): Make "buf" const.
6098
6099 2019-01-14  Tom Tromey  <tom@tromey.com>
6100
6101         * remote.c (remote_console_output): Make parameter const.
6102
6103 2019-01-14  Tom Tromey  <tom@tromey.com>
6104
6105         * target-debug.h (target_debug_print_signals): Constify.
6106         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6107         * procfs.c (procfs_target::pass_signals): Update.
6108         * linux-nat.c (linux_nat_target::pass_signals): Update.
6109         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6110         * target-delegates.c: Rebuild.
6111         * remote.c (remote_target::program_signals): Update.
6112         (remote_target::pass_signals): Update.
6113         * target.c (target_pass_signals): Constify argument.
6114         (target_program_signals): Likewise.
6115         * target.h (struct target_ops) <pass_signals, program_signals>:
6116         Constify argument.
6117         (target_pass_signals, target_program_signals): Constify argument.
6118
6119 2019-01-14  Tom Tromey  <tom@tromey.com>
6120
6121         PR tui/28819:
6122         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6123
6124 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6125
6126         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6127         field.
6128         * rs6000-tdep.c: Include reggroups.h.
6129         (IS_V_ALIAS_PSEUDOREG): Define.
6130         (rs6000_register_name): Return names for the "vX" aliases.
6131         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6132         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6133         aliases.  Call default_register_reggroup_p for all other
6134         pseudo-registers.
6135         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6136         New functions.
6137         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6138         Handle "vX" aliases.
6139         (v_alias_pseudo_register_collect): New function.
6140         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6141         (rs6000_gdbarch_init): Initialize "vX" aliases as
6142         pseudo-registers.  Restore registration of
6143         rs6000_pseudo_register_reggroup_p with
6144         set_tdesc_pseudo_register_reggroup_p.
6145
6146 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6147
6148         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6149         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6150         set_gdbarch_num_pseudo_regs.
6151
6152 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6153
6154         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6155         Remove arg prefixname, add do_set and do_show.
6156         Add member functions set_list and show_list.
6157         * cli/cli-style.c (class cli_style_option): Update accordingly.
6158         (style_set_list): Move to file scope.
6159         (style_show_list): Likewise.
6160         (set_style): Call help_list.
6161         (show_style): Call cmd_show_list.
6162         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6163         Update to use the new macro.
6164
6165 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6166
6167         * ada-lang.c (_initialize_ada_language): Expand the help text
6168         for the "catch exception" command.
6169
6170 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6171
6172         * symtab.c (matching_obj_sections): Initialize obj,
6173         declare it closer to its usage.
6174
6175 2019-01-10  Tom Tromey  <tom@tromey.com>
6176
6177         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6178         (basic_inf_threads_range): Remove.
6179         (inf_threads_range, inf_non_exited_threads_range)
6180         (safe_inf_threads_range): Use next_adapter.
6181
6182 2019-01-10  Keith Seitz  <keiths@redhat.com>
6183
6184         PR gdb/23712
6185         PR symtab/23010
6186         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6187         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6188
6189 2019-01-10  Keith Seitz  <keiths@redhat.com>
6190
6191         PR gdb/23712
6192         PR symtab/23010
6193         * dictionary.c (pending_to_vector): Remove.
6194         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6195         Remove _1 suffix, replacing functions of the same name.  Update
6196         all callers.
6197         (dict_create_hashed, dict_create_hashed_expandable)
6198         (dict_create_linear, dict_create_linear_expandable, dict_free)
6199         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6200         Make functions static.
6201
6202 2019-01-10  Keith Seitz  <keiths@redhat.com>
6203
6204         PR gdb/23712
6205         PR symtab/23010
6206         * dictionary.h (struct dictionary): Replace declaration with
6207         multidictionary.
6208         (dict_create_hashed, dict_create_hashed_expandable)
6209         (dict_create_linear, dict_create_linear_expandable)
6210         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6211         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6212         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6213         taking multidictionary argument.
6214         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6215         * block.h (struct block) <dict>: Change to multidictionary
6216         and rename `multidict'.
6217         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6218         symmisc.c: Update all dictionary references to multidictionary.
6219
6220 2019-01-10  Keith Seitz  <keiths@redhat.com>
6221
6222         PR gdb/23712
6223         PR symtab/23010
6224         * dictionary.c: Include unordered_map.
6225         (pending_to_vector): New function.
6226         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6227         Rewrite the non-"_1" functions to take vector instead
6228         of linked list.
6229         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6230         "new" _1 versions of the same name.
6231         (multidictionary): Define.
6232         (std::hash<enum language): New definition.
6233         (collate_pending_symbols_by_language, mdict_create_hashed)
6234         (mdict_create_hashed_expandable, mdict_create_linear)
6235         (mdict_create_linear_expandable, mdict_free)
6236         (find_language_dictionary, create_new_language_dictionary)
6237         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6238         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6239         (mdict_size, mdict_empty): New functions.
6240         * dictionary.h (mdict_iterator): Define.
6241
6242 2019-01-10  Pedro Alves  <palves@redhat.com>
6243
6244         * breakpoint.c (read_uploaded_action)
6245         (create_tracepoint_from_upload): Adjust to use
6246         gdb::unique_xmalloc_ptr.
6247         * ctf.c (ctf_write_uploaded_tp):
6248         (SET_ARRAY_FIELD): Use emplace_back.
6249         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6250         * tracefile-tfile.c (tfile_write_uploaded_tp):
6251         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6252         gdb::unique_xmalloc_ptr.
6253         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6254         at_string, cond_string, cmd_strings>: Replace char pointers
6255         with gdb::unique_xmalloc_ptr.
6256
6257 2019-01-10  Pedro Alves  <palves@redhat.com>
6258
6259         * solib-target.c (library_list_start_library): Don't xstrdup name.
6260
6261 2019-01-10  Pedro Alves  <palves@redhat.com>
6262
6263         * mdebugread.c (parse_partial_symbols): Use
6264         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6265
6266 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6267
6268         * linux-fork.c (scoped_switch_fork_info)
6269         <~scoped_switch_fork_info>: Fix incorrect variable name.
6270
6271 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6272
6273         * linux-fork.c (scoped_switch_fork_info)
6274         <scoped_switch_fork_info>: Make explicit.
6275         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6276
6277 2019-01-10  Tom Tromey  <tom@tromey.com>
6278
6279         * objfiles.h (objfile::reset_psymtabs): Update.
6280         * objfiles.c (objfile::objfile): Update.
6281         * psymtab.h (psymtab_storage::obstack): Update.
6282         (psymtab_storage::m_obstack): Use gdb::optional.
6283         (class psymtab_storage): Update comment.  Remove objfile
6284         parameter.
6285         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6286
6287 2019-01-10  Tom Tromey  <tom@tromey.com>
6288
6289         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6290         <free_psymtabs>: Now private.
6291         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6292         (allocate_psymtab): Use new method.
6293
6294 2019-01-10  Tom Tromey  <tom@tromey.com>
6295
6296         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6297         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6298         * mdebugread.c (parse_partial_symbols): Use
6299         allocate_dependencies.
6300         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6301         allocate_dependencies.
6302         (process_psymtab_comp_unit_reader)
6303         (build_type_psymtab_dependencies): Likewise.
6304         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6305
6306 2019-01-10  Tom Tromey  <tom@tromey.com>
6307
6308         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6309         PSYMBOL_SET_LANGUAGE.
6310         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6311
6312 2019-01-10  Tom Tromey  <tom@tromey.com>
6313
6314         * psymtab.h (psymtab_storage::obstack): New method.
6315         <m_obstack>: Rename from obstack; now private.
6316         * psymtab.c (psymtab_storage): Update.
6317         * dwarf2read.c (create_addrmap_from_index)
6318         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6319         Update.
6320
6321 2019-01-10  Tom Tromey  <tom@tromey.com>
6322
6323         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6324         * objfiles.h (objfile::reset_psymtabs): New method.
6325
6326 2019-01-10  Tom Tromey  <tom@tromey.com>
6327
6328         * symmisc.c (print_symbol_bcache_statistics): Update.
6329         (print_objfile_statistics): Update.
6330         * symfile.c (reread_symbols): Update.
6331         * psymtab.h (class psymtab_storage): New.
6332         * psymtab.c (psymtab_storage): New constructor.
6333         (~psymtab_storage): New destructor.
6334         (require_partial_symbols): Update.
6335         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6336         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6337         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6338         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6339         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6340         (start_psymtab_common, end_psymtab_common)
6341         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6342         (allocate_psymtab): Update.
6343         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6344         Update.
6345         (dump_psymtab_addrmap, maintenance_print_psymbols)
6346         (maintenance_check_psymtabs): Update.
6347         (class objfile_psymtabs): Move to objfiles.h.
6348         * psympriv.h (discard_psymtab): Now inline.
6349         (psymtab_discarder::psymtab_discarder): Update.
6350         (psymtab_discarder::~psymtab_discarder): Update.
6351         (ALL_OBJFILE_PSYMTABS): Rewrite.
6352         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6353         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6354         Remove fields.
6355         <partial_symtabs>: New field.
6356         (class objfile_psymtabs): Move from psymtab.h.  Update.
6357         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6358         psymbol_cache.
6359         (objfile::~objfile): Don't destroy psymbol_cache.
6360         * mdebugread.c (parse_partial_symbols): Update.
6361         * dwarf2read.c (create_addrmap_from_index)
6362         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6363         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6364         (add_partial_subprogram, dwarf2_ranges_read): Update.
6365         * dwarf-index-write.c (write_address_map)
6366         (write_one_signatured_type, recursively_write_psymbols)
6367         (class debug_names, class debug_names, write_psymtabs_to_index):
6368         Update.
6369
6370 2019-01-10  Tom Tromey  <tom@tromey.com>
6371
6372         * symtab.h (SYMBOL_SET_NAMES): Update.
6373         (symbol_set_names): Update.
6374         (MSYMBOL_SET_NAMES): Update.
6375         * symtab.c (symbol_set_names): Change argument to be an
6376         objfile_per_bfd_storage.
6377         * psymtab.c (add_psymbol_to_bcache): Update.
6378         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6379
6380 2019-01-10  Tom Tromey  <tom@tromey.com>
6381
6382         * symtab.c (create_demangled_names_hash): Change argument to be an
6383         objfile_per_bfd_storage.
6384         (symbol_set_names): Update.
6385
6386 2019-01-10  Tom Tromey  <tom@tromey.com>
6387
6388         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6389         init_psymbol_list.
6390         * psymtab.c (init_psymbol_list): Do nothing if already called.
6391         * psympriv.h (init_psymbol_list): Add comment.
6392         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6393         init_psymbol_list.
6394         * dbxread.c (dbx_symfile_read): Unconditionally call
6395         init_psymbol_list.
6396
6397 2019-01-10  Tom Tromey  <tom@tromey.com>
6398
6399         * xcoffread.c (scan_xcoff_symtab): Update.
6400         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6401         "where".
6402         * mdebugread.c (parse_partial_symbols)
6403         (handle_psymbol_enumerators): Update.
6404         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6405         * dbxread.c (read_dbx_symtab): Update.
6406         * psympriv.h (psymbol_placement): New enum.
6407         (add_psymbol_to_list): Update.
6408
6409 2019-01-10  Tom Tromey  <tom@tromey.com>
6410
6411         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6412         static_psymbols parameters.
6413         (scan_xcoff_symtab): Update.
6414         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6415         static_psymbols parameters.
6416         * psympriv.h (start_psymtab_common): Update.
6417         * mdebugread.c (parse_partial_symbols): Update.
6418         * dwarf2read.c (create_partial_symtab): Update.
6419         * dbxread.c (read_dbx_symtab): Update.
6420         (start_psymtab): Remove global_psymbols and static_psymbols
6421         parameters.
6422
6423 2019-01-10  Tom Tromey  <tom@tromey.com>
6424
6425         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6426         * psymtab.c (allocate_psymtab): Add comment.
6427         * psympriv.h (allocate_psymtab): Add comment.
6428         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6429         initializations.
6430         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6431
6432 2019-01-10  Tom Tromey  <tom@tromey.com>
6433
6434         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6435         Don't declare.
6436         * mipsread.c: Include mdebugread.h.
6437         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6438         Declare.
6439         * elfread.c: Include mdebugread.h.
6440
6441 2019-01-09  Tom Tromey  <tom@tromey.com>
6442
6443         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6444         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6445         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6446         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6447         (psym_lookup_symbol, psym_find_last_source_symtab)
6448         (psym_forget_cached_source_info, psym_print_stats)
6449         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6450         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6451         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6452         (psym_find_compunit_symtab_by_address)
6453         (maintenance_print_psymbols, maintenance_info_psymtabs)
6454         (maintenance_check_psymtabs): Use ranged for.
6455         * psymtab.h (class objfile_psymtabs): New.
6456         (require_partial_symbols): Return objfile_psymtabs.
6457         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6458
6459 2019-01-09  Tom Tromey  <tom@tromey.com>
6460
6461         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6462         (find_pc_mapped_section, list_overlays_command)
6463         (map_overlay_command, unmap_overlay_command)
6464         (simple_overlay_update): Use all_objfiles.
6465         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6466         * printcmd.c (info_symbol_command): Use all_objfiles.
6467         * objfiles.h (ALL_OBJSECTIONS): Remove.
6468         * maint.c (maintenance_translate_address): Use all_objfiles.
6469         * gcore.c (gcore_create_callback): Use all_objfiles.
6470         (objfile_find_memory_regions): Likewise.
6471
6472 2019-01-09  Tom Tromey  <tom@tromey.com>
6473
6474         * symtab.c (find_line_symtab, info_sources_command)
6475         (make_source_files_completion_list): Use objfile_compunits.
6476         * source.c (select_source_symtab): Use objfile_compunits.
6477         * objfiles.h (struct objfile): Update comment.
6478         (ALL_OBJFILES): Remove.
6479         (ALL_FILETABS): Remove.
6480         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6481         objfile_compunits.
6482
6483 2019-01-09  Tom Tromey  <tom@tromey.com>
6484
6485         * symmisc.c (print_objfile_statistics, dump_objfile)
6486         (maintenance_print_symbols): Use compunit_filetabs.
6487         * source.c (forget_cached_source_info_for_objfile): Use
6488         compunit_filetabs.
6489         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6490         (ALL_FILETABS): Use compunit_filetabs.
6491         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6492         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6493
6494 2019-01-09  Tom Tromey  <tom@tromey.com>
6495
6496         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6497         (compunit_filetabs): New.
6498         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6499         compunit_filetabs.
6500         (info_sources_command, make_source_files_completion_list): Remove
6501         declaration.
6502         * symmisc.c (print_objfile_statistics, dump_objfile)
6503         (maintenance_print_symbols): Remove declaration.
6504         (maintenance_info_symtabs): Use compunit_filetabs.
6505         (maintenance_info_line_tables): Likewise.
6506         * source.c (select_source_symtab): Change local variable name.
6507         (forget_cached_source_info_for_objfile): Remove declaration.
6508         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6509         * objfiles.c (objfile_relocate1): Remove declaration.
6510         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6511         declaration.
6512         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6513         * coffread.c (coff_symtab_read): Remove declaration.
6514         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6515         compunit_filetabs.
6516
6517 2019-01-09  Tom Tromey  <tom@tromey.com>
6518
6519         * symtab.c (lookup_objfile_from_block)
6520         (find_pc_sect_compunit_symtab, search_symbols)
6521         (default_collect_symbol_completion_matches_break_on): Use
6522         objfile_compunits.
6523         * objfiles.h (ALL_COMPUNITS): Remove.
6524         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6525         * cp-support.c (add_symbol_overload_list_qualified): Use
6526         objfile_compunits.
6527         * ada-lang.c (ada_collect_symbol_completion_matches)
6528         (ada_add_global_exceptions): Use objfile_compunits.
6529
6530 2019-01-09  Tom Tromey  <tom@tromey.com>
6531
6532         * source.c (select_source_symtab)
6533         (forget_cached_source_info_for_objfile): Remove declaration.
6534         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6535         declaration.
6536         * maint.c (count_symtabs_and_blocks): Remove declaration.
6537         * cp-support.c (add_symbol_overload_list_qualified): Remove
6538         declaration.
6539         * coffread.c (coff_symtab_read): Remove declaration.
6540         * symtab.c (lookup_symbol_in_objfile_symtabs)
6541         (basic_lookup_transparent_type_1): Use objfile_compunits.
6542         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6543         (info_sources_command, search_symbols)
6544         (default_collect_symbol_completion_matches_break_on)
6545         (make_source_files_completion_list): Remove declaration.
6546         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6547         (ada_collect_symbol_completion_matches)
6548         (ada_add_global_exceptions): Remove declaration.
6549         * linespec.c (iterate_over_all_matching_symtabs): Use
6550         objfile_compunits.
6551         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6552         (class objfile_compunits): New.
6553         (ALL_COMPUNITS): Use objfile_compunits.
6554         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6555         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6556         objfile_compunits.
6557         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6558
6559 2019-01-09  Tom Tromey  <tom@tromey.com>
6560
6561         * symtab.c (search_symbols)
6562         (default_collect_symbol_completion_matches_break_on): Use
6563         objfile_msymbols.
6564         * ada-lang.c (ada_lookup_simple_minsym)
6565         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6566         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6567         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6568         objfile_msymbols.
6569         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6570         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6571         * objc-lang.c (find_methods): Use objfile_msymbols.
6572         (info_selectors_command, info_classes_command): Likewise.
6573         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6574         * objfiles.h (class objfile_msymbols): New.
6575         (ALL_OBJFILE_MSYMBOLS): Remove.
6576         (ALL_MSYMBOLS): Remove.
6577
6578 2019-01-09  Tom Tromey  <tom@tromey.com>
6579
6580         * common/next-iterator.h (next_adapter): Add Iterator template
6581         parameter.
6582         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6583         (class all_objfiles_safe): New.
6584         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6585         * objfiles.c (put_objfile_before): Update comment.
6586         (add_separate_debug_objfile): Likewise.
6587         (free_all_objfiles): Use all_objfiles_safe.
6588         (objfile_purge_solibs): Likewise.
6589
6590 2019-01-09  Tom Tromey  <tom@tromey.com>
6591
6592         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6593         (expand_symtab_containing_pc, lookup_static_symbol)
6594         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6595         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6596         all_objfiles.
6597         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6598         * breakpoint.c (create_overlay_event_breakpoint)
6599         (create_longjmp_master_breakpoint)
6600         (create_std_terminate_master_breakpoint)
6601         (create_exception_master_breakpoint): Use all_objfiles.
6602         * linux-thread-db.c (try_thread_db_load_from_pdir)
6603         (has_libpthread): Use all_objfiles.
6604         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6605         * linespec.c (iterate_over_all_matching_symtabs)
6606         (search_minsyms_for_name): Use all_objfiles.
6607         * maint.c (maintenance_info_sections): Use all_objfiles.
6608         * main.c (captured_main_1): Use all_objfiles.
6609         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6610         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6611         * guile/scm-pretty-print.c
6612         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6613         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6614         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6615         (maintenance_print_msymbols): Use all_objfiles.
6616         * source.c (select_source_symtab): Use all_objfiles.
6617         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6618         * symfile.c (remove_symbol_file_command)
6619         (expand_symtabs_matching, map_symbol_filenames): Use
6620         all_objfiles.
6621         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6622         all_objfiles.
6623         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6624         * objc-lang.c (find_methods): Use all_objfiles.
6625         * objfiles.c (have_partial_symbols, have_full_symbols)
6626         (have_minimal_symbols, qsort_cmp)
6627         (default_iterate_over_objfiles_in_search_order): Use
6628         all_objfiles.
6629         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6630         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6631         (maintenance_check_psymtabs): Use all_objfiles.
6632         (ALL_PSYMTABS): Remove.
6633         * compile/compile-object-run.c (do_module_cleanup): Use
6634         all_objfiles.
6635         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6636         * cp-support.c (add_symbol_overload_list_qualified): Use
6637         all_objfiles.
6638         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6639         Use all_objfiles.
6640         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6641         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6642         all_objfiles.
6643         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6644         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6645         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6646         Uses all_objfiles.
6647         * solib.c (solib_read_symbols): Use all_objfiles
6648
6649 2019-01-09  Tom Tromey  <tom@tromey.com>
6650
6651         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6652         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6653         all_objfiles.
6654         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6655         * symmisc.c (print_symbol_bcache_statistics)
6656         (print_objfile_statistics, maintenance_print_objfiles)
6657         (maintenance_info_symtabs, maintenance_check_symtabs)
6658         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6659         all_objfiles.
6660         * source.c (forget_cached_source_info): Use all_objfiles.
6661         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6662         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6663         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6664         * objfiles.c (update_section_map): Use all_objfiles.
6665         (shared_objfile_contains_address_p): Likewise.
6666         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6667         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6668
6669 2019-01-09  Tom Tromey  <tom@tromey.com>
6670
6671         * common/next-iterator.h: New file.
6672         * objfiles.h (class all_objfiles): New.
6673         (struct objfile_iterator): New.
6674
6675 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6676
6677         * NEWS: Move the description of the changed "frame", "select-frame",
6678          and "info frame" commands to the Changed commands section.
6679
6680 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6681
6682         * gdbtypes.c (check_stub_method_group): Remove handling of old
6683         mangling schemes.
6684         * linespec.c (find_methods): Likewise.
6685         * stabsread.c (read_member_functions): Likewise.
6686         * valops.c (search_struct_method): Likewise.
6687         (value_struct_elt_for_reference): Likewise.
6688         * NEWS: Mention this change.
6689
6690 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6691
6692         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6693         print_source_lines.
6694         * source.c (print_source_lines_base): Update line number check.
6695         (print_source_lines): New function.
6696         (source_lines_range::source_lines_range): New function.
6697         * source.h (class source_lines_range): New class.
6698         (print_source_lines): New declaration.
6699
6700 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6701
6702         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6703
6704 2019-01-08  Tom Tromey  <tom@tromey.com>
6705             Simon Marchi  <simon.marchi@ericsson.com>
6706
6707         PR gdb/24060
6708         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6709         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6710         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6711         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6712         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6713         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6714
6715 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6716
6717         * source.c (select_source_symtab): Move header comment to
6718         declaration in source.h.
6719         (forget_cached_source_info_for_objfile): Likewise.
6720         (forget_cached_source_info): Likewise.
6721         (identify_source_line): Likewise.
6722         * source.h (identify_source_line): Move declaration from symtab.h
6723         and add comment from source.c
6724         (print_source_lines): Likewise.
6725         (forget_cached_source_info_for_objfile): Likewise.
6726         (forget_cached_source_info): Likewise.
6727         (select_source_symtab): Likewise.
6728         (enum print_source_lines_flag): Move definition from symtab.h.
6729         * symtab.h (identify_source_line): Move declaration to source.h.
6730         (print_source_lines): Likewise.
6731         (forget_cached_source_info_for_objfile): Likewise.
6732         (forget_cached_source_info): Likewise.
6733         (select_source_symtab): Likewise.
6734         (enum print_source_lines_flag): Move definition to source.h.
6735         * tui/tui-hooks.c: Add 'source.h' include.
6736
6737 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6738
6739         * source.c (print_source_lines_base): Handle requests to print
6740         reverse line number sequences, and guard against empty lines
6741         string.
6742
6743 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6744
6745         * source.c (print_source_lines_base): Fix skip of '\r' if next
6746         character is '\n'.
6747
6748 2019-01-06  Tom Tromey  <tom@tromey.com>
6749
6750         * c-exp.y (struct c_parse_state) <macro_original_text,
6751         expansion_obstack>: New member.
6752         (macro_original_text, expansion_obstack): Remove globals.
6753         (scan_macro_expansion, scanning_macro_expansion)
6754         (finished_macro_expansion): Update.
6755         (scan_macro_cleanup): Remove.
6756         (yylex, c_parse): Update.
6757
6758 2019-01-06  Tom Tromey  <tom@tromey.com>
6759
6760         * c-exp.y (struct c_parse_state) <strings>: New member.
6761         (operator_stoken): Update.
6762
6763 2019-01-06  Tom Tromey  <tom@tromey.com>
6764
6765         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6766         (union type_stack_elt) <typelist_val>: Now a pointer to
6767         std::vector.
6768         (type_stack_cleanup): Don't declare.
6769         (push_typelist): Update.
6770         * parse.c (pop_typelist): Return a std::vector.
6771         (push_typelist): Take a std::vector.
6772         (follow_types): Update.  Do not free args.
6773         (type_stack_cleanup): Remove.
6774         * c-exp.y (struct c_parse_state): New.
6775         (cpstate): New global.
6776         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6777         (nonempty_typelist): Update.
6778         (func_mod): Create a new vector.
6779         (c_parse): Create a c_parse_state.
6780         (check_parameter_typelist): Do not delete params.
6781         (function_method): Update.  Do not delete type_list.
6782
6783 2019-01-06  Tom Tromey  <tom@tromey.com>
6784
6785         PR gdb/28155:
6786         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6787         check_typedef.
6788         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6789         (print_return_value): Likewise.
6790
6791 2019-01-05  Tom Tromey  <tom@tromey.com>
6792
6793         * contrib/cleanup_check.py: Remove.
6794         * contrib/gcc-with-excheck: Remove.
6795         * contrib/exsummary.py: Remove.
6796         * contrib/excheck.py: Remove.
6797
6798 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6799
6800         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6801         NULL. Initialize tpprev to NULL instead of assigning it
6802         to NULL on the next statement.
6803         * windows-nat.c (windows_delete_thread): Remove check for
6804         main_thread_id before printing thread exit notifications.
6805         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6806         Remove thread ID check against main_thread_id.
6807         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6808         windows_delete_thread.
6809         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6810
6811 2019-01-04  Tom Tromey  <tom@tromey.com>
6812
6813         * compile/compile.c (_initialize_compile): Use upper case for
6814         metasyntactic variables.
6815         * symmisc.c (_initialize_symmisc): Use upper case for
6816         metasyntactic variables.
6817         * psymtab.c (_initialize_psymtab): Use upper case for
6818         metasyntactic variables.
6819         * demangle.c (demangle_command): Use upper case for metasyntactic
6820         variables.
6821         (_initialize_demangler): Likewise.
6822         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6823         variables.
6824
6825 2019-01-03  Tom Tromey  <tom@tromey.com>
6826
6827         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6828
6829 2019-01-03  Tom Tromey  <tom@tromey.com>
6830
6831         * python/py-symtab.c (salpy_str): Update.
6832         (struct salpy_sal_object) <symtab>: Now a PyObject.
6833         (salpy_dealloc): Update.
6834         (del_objfile_sal): Use gdbpy_ref.
6835
6836 2019-01-03  Tom Tromey  <tom@tromey.com>
6837
6838         * python/py-type.c (convert_field): Use new_reference.  Return
6839         gdbpy_ref.
6840         (make_fielditem): Return gdbpy_ref.
6841         (typy_fields): Update.
6842         (typy_getitem): Update.
6843         (field_name): Return gdbpy_ref.  Use new_reference.
6844         (typy_iterator_iternext): Update.
6845
6846 2019-01-03  Tom Tromey  <tom@tromey.com>
6847
6848         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6849
6850 2019-01-03  Tom Tromey  <tom@tromey.com>
6851
6852         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6853         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6854         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6855         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6856         (pspy_set_type_printers): Likewise.
6857         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6858         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6859         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6860         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6861         (objfpy_set_type_printers): Likewise.
6862
6863 2019-01-03  Tom Tromey  <tom@tromey.com>
6864
6865         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6866         (gdbpy_print_stack): Use gdbpy_err_fetch.
6867         * python/python-internal.h (class gdbpy_err_fetch): New class.
6868         (class gdbpy_enter) <m_error_type, m_error_value,
6869         m_error_traceback>: Remove.
6870         <m_error>: New member.
6871         (gdbpy_exception_to_string): Don't declare.
6872         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6873         * python/py-value.c (convert_value_from_python): Use
6874         gdbpy_err_fetch.
6875         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6876         gdbpy_exception_to_string.
6877         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6878         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6879         gdbpy_err_fetch.
6880
6881 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6882
6883         * linux-nat.c (delete_lwp_cleanup): Delete.
6884         (struct lwp_deleter): New struct.
6885         (lwp_info_up): New typedef.
6886         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6887         lwp_info_up.
6888
6889 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6890
6891         * linux-fork.c (class scoped_switch_fork_info): New class.
6892         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6893
6894 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6895
6896         * valops.c (find_overload_match): Remove use of null_cleanup, and
6897         calls to do_cleanups.
6898
6899 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6900
6901         * compile/compile-cplus-types.c
6902         (compile_cplus_instance::decl_name): Handle changes to
6903         cp_func_name.
6904         * cp-support.c (cp_func_name): Update header comment, update
6905         return type.
6906         * cp-support.h (cp_func_name): Update return type in declaration.
6907         * valops.c (find_overload_match): Move temp_func local to top
6908         level of function and change its type.  Use temp_func to hold and
6909         delete temporary string obtained from cp_func_name.
6910
6911 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6912
6913         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6914         gdb::char_vector, remove cleanup, and update uses of `msg`.
6915
6916 2019-01-03  Jim Wilson  <jimw@sifive.com>
6917
6918         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6919
6920 2019-01-02  Tom Tromey  <tom@tromey.com>
6921
6922         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6923         (tdesc_parse_xml): Remove cleanups.
6924         * target-descriptions.h (make_cleanup_free_target_description):
6925         Don't declare.
6926         (target_desc_deleter): New struct.
6927         (target_desc_up): New typedef.
6928         * target-descriptions.c (target_desc_deleter::operator()): Rename
6929         from free_target_description.
6930         (make_cleanup_free_target_description): Remove.
6931
6932 2019-01-02  Tom Tromey  <tom@tromey.com>
6933
6934         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6935         constructor, destructor.
6936         (linespec_parser): Remove typedef.
6937         (~linespec_parser): Rename from linespec_parser_delete.
6938         (linespec_lex_to_end, linespec_complete_label)
6939         (linespec_complete): Update.
6940         (decode_line_full): Remove cleanups.
6941         (decode_line_1): Update.
6942
6943 2019-01-02  Tom Tromey  <tom@tromey.com>
6944
6945         * python/python-internal.h (inferior_to_inferior_object): Change
6946         return type.
6947         * python/py-exitedevent.c (create_exited_event_object): Update.
6948         * python/py-inferior.c (inferior_to_inferior_object): Return
6949         gdbpy_ref.
6950         (python_new_inferior, python_inferior_deleted)
6951         (thread_to_thread_object, delete_thread_object)
6952         (build_inferior_list, gdbpy_selected_inferior): Update.
6953         * python/py-infthread.c (create_thread_object): Update.  Also fail
6954         if inferior_to_inferior_object fails.
6955
6956 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6957
6958         * inferior.h (class inferior) <displaced_step_state>: New field.
6959         * infrun.h (struct displaced_step_state): Move here from
6960         infrun.c.  Initialize fields, add constructor.
6961         <inf>: Remove field.
6962         <reset>: New method.
6963         * infrun.c (struct displaced_step_inferior_state): Move to
6964         infrun.h.
6965         (displaced_step_inferior_states): Remove.
6966         (get_displaced_stepping_state): Adust.
6967         (displaced_step_in_progress_any_inferior): Adjust.
6968         (displaced_step_in_progress_thread): Adjust.
6969         (displaced_step_in_progress): Adjust.
6970         (add_displaced_stepping_state): Remove.
6971         (get_displaced_step_closure_by_addr): Adjust.
6972         (remove_displaced_stepping_state): Remove.
6973         (infrun_inferior_exit): Call displaced_step_state.reset.
6974         (use_displaced_stepping): Don't check for NULL.
6975         (displaced_step_prepare_throw): Call
6976         get_displaced_stepping_state.
6977         (displaced_step_fixup): Don't check for NULL.
6978         (prepare_for_detach): Don't check for NULL.
6979
6980 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6981
6982         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6983          in case of call that did not complete.
6984
6985 2019-01-02  Andrey Utkin  <autkin@undo.io>
6986
6987         * symfile.c (find_separate_debug_file): Fix search of debug files for
6988         remote debuggee.
6989
6990 2019-01-02  Tom Tromey  <tom@tromey.com>
6991
6992         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6993         indentation.
6994         * python/py-frame.c (frapy_older): Remove cast.
6995         (frapy_newer): Likewise.
6996         * python/py-breakpoint.c (local_setattro): Remove cast.
6997         * python/py-arch.c (archpy_name): Remove local variable.
6998         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6999
7000 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7001
7002         * unittests/basic_string_view/element_access/char/empty.cc:
7003         Fix year range in copyright header.
7004
7005 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7006
7007         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7008         Delete.
7009         <operator==>: Update with for removed field.
7010         <hash>: Likewise.
7011         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7012         <isa_features>: ...this.
7013         <abi_features>: New field.
7014         (riscv_isa_flen): Update comment.
7015         (riscv_abi_xlen): New declaration.
7016         (riscv_abi_flen): New declaration.
7017         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7018         isa_features.
7019         (riscv_abi_xlen): New function.
7020         (riscv_isa_flen): Update to get answer from isa_features.
7021         (riscv_abi_flen): New function.
7022         (riscv_has_fp_abi): Update to get answer from abi_features.
7023         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7024         xlen and flen.
7025         (riscv_call_info) <xlen, flen>: Update comment.
7026         (riscv_call_arg_struct): Remove invalid assertions
7027         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7028         is removed.
7029         (riscv_gdbarch_init): Gather isa features and abi features
7030         separately, ensure both match on the gdbarch when reusing an old
7031         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7032         a target with 64-bit float hardware.
7033
7034 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7035
7036         * source.c (search_command_helper): Stop reverse search
7037         when line 1 has been searched.
7038
7039 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7040
7041         * record-full.c (record_full_base_target::close): Rewrite
7042         record_full_core_buf_list free logic.
7043
7044 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7045
7046         * break-catch-syscall.c (print_one_catch_syscall): xfree
7047         the last text.
7048
7049 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7050
7051         * top.c (print_gdb_version): Update Copyright year in version
7052         message.
7053
7054 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7055
7056         Update copyright year range in all GDB files.
7057
7058 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7059
7060         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7061
7062 For older changes see ChangeLog-2018.
7063 \f
7064 Local Variables:
7065 mode: change-log
7066 left-margin: 8
7067 fill-column: 74
7068 version-control: never
7069 coding: utf-8
7070 End:
7071