gdb/ChangeLog

   1 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * dwarf2read.h (dwarf2_section_info_def): Remove.
   4         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
   5         * dwarf2read.c (struct dwo_sections) <types>: Change type to
   6         std::vector<dwarf2_section_info>.
   7         (struct dwo_file) <~dwo_file>: Remove.
   8         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
   9         types field.
  10         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
  11         (dwarf2_read_debug_names): Likewise.
  12         (create_debug_types_hash_table): Change parameter type to
  13         array_view, adjust code accordingly.
  14         (dwarf2_locate_dwo_sections): Adjust to std::vector.
  15         (partial_die_info::fixup): Likewise.
  16         (determine_prefix): Likewise.
  17         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
  18
  19 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  20
  21         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
  22         gdb_bfd_ref_ptr.
  23         <~dwo_file>: Remove call to gdb_bfd_unref.
  24         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
  25         gdb_bfd_ref_ptr::get.
  26
  27 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  28
  29         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
  30         type to htab_up.
  31         * dwarf2read.c (struct dwo_file): Initialize fields.
  32         <~dwo_file>: New.
  33         (free_dwo_file): Remove, move content to ~dwo_file.
  34         (struct dwo_file_deleter): Remove.
  35         (dwo_file_up>: Remove custom deleter.
  36         (free_dwo_files): Remove.
  37         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
  38         dwo_files.
  39         (process_skeletonless_type_units): Call unique_ptr::get.
  40         (allocate_dwo_file_hash_table): Add deleter to created hash
  41         table.  Change return type to htab_up.
  42         (lookup_dwo_file_slot): Don't memset dwo_file, call
  43         unique_ptr::get.
  44         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
  45         (create_dwo_unit_in_dwp_v2): Likewise.
  46         (open_and_init_dwo_file): Likewise.
  47         (free_dwo_file_from_slot): Remove.
  48
  49 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  50
  51         * dwarf2read.h (struct dwarf2_section_info) <readin,
  52         is_virtual>: Change type to bool.
  53         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
  54         true instead of 1.
  55
  56 2019-06-19  Tom Tromey  <tom@tromey.com>
  57
  58         * tui/tui-data.h (tui_init_content_element): Don't declare.
  59
  60 2019-06-19  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-data.h (tui_init_win_info): Don't declare.
  63
  64 2019-06-19  Tom de Vries  <tdevries@suse.de>
  65
  66         * dwarf2read.h (abstract_to_concrete): Change type to
  67         std::unordered_map<sect_offset, std::vector<sect_offset>,
  68         gdb::hash_enum<sect_offset>>.
  69
  70 2019-06-19  Tom Tromey  <tromey@adacore.com>
  71
  72         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
  73         EVAL_AVOID_SIDE_EFFECTS specially.
  74
  75 2019-06-19  Tom Tromey  <tromey@adacore.com>
  76
  77         * source-cache.c (highlighter): New global.
  78         (source_cache::get_source_lines): Create a highlighter on demand.
  79
  80 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  81
  82         * defs.h (deprecated_interactive_hook): Delete declaration.
  83         * interps.c (clear_interpreter_hooks): Remove use of
  84         deprecated_interactive_hook.
  85         * top.c (deprecated_interactive_hook): Delete definition.
  86         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
  87
  88 2019-06-18  Tom de Vries  <tdevries@suse.de>
  89
  90         PR gdb/24515
  91         * dwarf2read.h (abstract_to_concrete): Change type from
  92         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
  93         std::unordered_map<sect_offset, std::vector<sect_offset>>.
  94         * dwarf2read.c (read_variable): Update.
  95         (dwarf2_fetch_die_loc_sect_off): Update.
  96
  97 2019-06-17  Tom de Vries  <tdevries@suse.de>
  98
  99         PR gdb/24617
 100         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 101         accessing parent[parent_len - 1].
 102
 103 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 104
 105         PR gdb/24364
 106         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 107         call dtrace_process_dof with NULL dof.
 108
 109 2019-06-16  Tom de Vries  <tdevries@suse.de>
 110
 111         PR gdb/24445
 112         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 113
 114 2019-06-16  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 117         (make_all_visible): Use address of member.
 118
 119 2019-06-16  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 122         (tui_free_window, free_content, free_content_elements): Remove
 123         unnecessary cast.
 124         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 125         cast.
 126         * tui/tui-regs.c (tui_show_register_group)
 127         (tui_display_registers_from, tui_display_reg_element_at_line):
 128         Remove unnecessary cast.
 129
 130 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 131
 132         * linux-nat.c (normal_mask): Delete.
 133         (_initialize_linux_nat): Don't initialise normal_mask.
 134
 135 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 136
 137         PR gdb/24445
 138         * dwarf-index-write.h (write_psymtabs_to_index): Add
 139         dwz_basename parameter.
 140         * dwarf-index-write.c (write_gdbindex): Move file writing to
 141         write_gdbindex_1.  Change return type void.
 142         (assert_file_size): Move up, remove filename parameter.
 143         (write_gdbindex_1): New function.
 144         (write_debug_names): Change return type to void, call
 145         assert_file_size.
 146         (struct index_wip_file): New struct.
 147         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 148         file logic to index_wip_file.  Write index for dwz file if
 149         needed.
 150         (save_gdb_index_command): Pass basename of dwz file, if present.
 151         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 152         build-id of dwz file, if present.
 153         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 154         (dwarf2_get_dwz_file): Likewise.
 155         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 156         (dwarf2_get_dwz_file): Likewise.
 157
 158 2019-06-16  Tom Tromey  <tom@tromey.com>
 159
 160         * coffread.c (process_coff_symbol): Use xstrdup.
 161         * value.c (create_internalvar): Use xstrdup.
 162
 163 2019-06-16  Tom Tromey  <tom@tromey.com>
 164
 165         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 166         * breakpoint.c (stopin_command, stopat_command)
 167         (until_break_command, decode_location_default): Remove unnecessary
 168         cast.
 169         * utils.c (subset_compare): Remove unnecessary cast.
 170         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 171         cast.
 172         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 173         cast.
 174         * infcmd.c (path_command): Remove unnecessary cast.
 175         * coffread.c (decode_type): Remove unnecessary cast.
 176         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 177         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 178         * tui/tui-stack.c (tui_show_locator_content)
 179         (tui_show_frame_info): Remove unnecessary cast.
 180         * tui/tui-win.c (tui_scroll_forward_command)
 181         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 182         (parse_scrolling_args): Remove unnecessary cast.
 183         * tui/tui-data.c (init_win_info, tui_del_window)
 184         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 185         (free_content_elements): Remove unnecessary cast.
 186         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 187         unnecessary cast.
 188         * tui/tui-source.c (tui_set_source_content)
 189         (tui_vertical_source_scroll): Remove unnecessary cast.
 190         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 191         cast.
 192         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 193         * tui/tui-regs.c (tui_display_registers_from)
 194         (tui_display_register): Remove unnecessary cast.
 195         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 196         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 197         (make_visible): Remove unnecessary cast.
 198         * tui/tui-winsource.c (tui_erase_source_content)
 199         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 200         unnecessary cast.
 201         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 202         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 203         * stabsread.c (read_type, read_array_type, read_range_type):
 204         Remove unnecessary cast.
 205         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 206         (parse_symbol, parse_type, upgrade_type, parse_external)
 207         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 208         unnecessary cast.
 209         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 210
 211 2019-06-16  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-data.c (tui_alloc_generic_win_info)
 214         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 215         checks.
 216
 217 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 218             Andrew Burgess  <andrew.burgess@embecosm.com>
 219
 220         * f-typeprint.c (f_print_type): Don't return early for not
 221         associated or not allocated types.
 222         (f_type_print_varspec_suffix): Add print_rank parameter and print
 223         ranks of array types in case they dangling.
 224         (f_type_print_base): Add print_rank parameter.
 225
 226 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 227
 228         * NEWS: Mention new MI commands.
 229         * break-catch-throw.c (enum exception_event_kind): Move to
 230         breakpoint.h.
 231         (print_mention_exception_catchpoint): Output text as a single
 232         message.
 233         (catch_exception_command_1): Rename to...
 234         (catch_exception_event): ...this, make non-static, update header
 235         command, and change some parameter types.
 236         (catch_catch_command): Update for changes to
 237         catch_exception_command_1.
 238         (catch_throw_command): Likewise.
 239         (catch_rethrow_command): Likewise.
 240         * breakpoint.c (enum exception_event_kind): Delete.
 241         * breakpoint.h (enum exception_event_kind): Moved here from
 242         break-catch-throw.c.
 243         (catch_exception_event): Declare.
 244         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 245         (mi_cmd_catch_throw): New function.
 246         (mi_cmd_catch_rethrow): New function.
 247         (mi_cmd_catch_catch): New function.
 248         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 249         'catch-catch' entries.
 250         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 251         (mi_cmd_catch_rethrow): Declare.
 252         (mi_cmd_catch_catch): Declare.
 253
 254 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 255
 256         * annotate.c (annotate_source_line): Change return type to void,
 257         update implementation to match.
 258         * annotate.h (annotate_source_line): Change return type to void,
 259         update header comment.
 260         * stack.c (print_frame_info): Don't change what frame information
 261         is printed based on whether annotations are on or not.
 262
 263 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 264
 265         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 266         (annotate_source): Make static.
 267         (annotate_source_line): Moved from source.c and renamed from
 268         identify_source_line.  Update the return type.
 269         * annotate.h (annotate_source): Delete declaration.
 270         (annotate_source_line): Declaration moved from source.h, and
 271         renamed from identify_source_line.  Return type updated.
 272         * source.c (identify_source_line): Moved to annotate.c and renamed
 273         to annotate_source_line.
 274         (info_line_command): Remove check of annotation_level.
 275         * source.h (identify_source_line): Move declaration to annotate.h
 276         and rename to annotate_source_line.
 277         * stack.c: Add 'annotate.h' include.
 278         (print_frame_info): Remove check of annotation_level before
 279         calling annotate_source_line.
 280
 281 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 282
 283         * source-cache.c (source_cache::get_plain_source_lines): Use
 284         open_source_file_with_line_charpos instead of just
 285         open_source_file, remove call to find_source_lines.
 286         (source_cache::get_source_lines): Likewise.
 287         * source.c (find_source_lines): Make static.
 288         (get_filename_and_charpos): Renamed into...
 289         (open_source_file_with_line_charpos): ..this along with changes to
 290         return a scoped_fd, and some other minor clean ups.
 291         (identify_source_line): Use open_source_file_with_line_charpos.
 292         (search_command_helper): Use open_source_file_with_line_charpos
 293         instead of just open_source_file, remove call to
 294         find_source_lines.
 295         * source.h (open_source_file_with_line_charpos): Declare new
 296         function.
 297         (find_source_lines): Delete declaration.
 298
 299 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 300
 301         * source.c (get_filename_and_charpos): Remove fullname
 302         parameter.
 303         (identify_source_line): Update call to get_filename_and_charpos.
 304
 305 2019-06-14  Tom Tromey  <tromey@adacore.com>
 306
 307         PR gdb/24502:
 308         * ui-style.h (skip_ansi_escape): Update comment.
 309         * ui-file.h (class no_terminal_escape_file): New class.
 310         * ui-file.c (no_terminal_escape_file::write)
 311         (no_terminal_escape_file::puts): New methods.
 312         * cli/cli-logging.c (handle_redirections): Use
 313         no_terminal_escape_file.
 314
 315 2019-06-14  Tom Tromey  <tromey@adacore.com>
 316
 317         * NEWS: Move convenience variable news above Python news.
 318
 319 2019-06-14  Tom Tromey  <tom@tromey.com>
 320
 321         * gnulib: Move directory to top-level.
 322         * configure.ac: Don't configure gnulib.
 323         * configure: Rebuild.
 324         * common/common-defs.h: Use new path to gnulib.
 325         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 326         (GNULIB_H): Remove.
 327         (INCGNU): Look in new gnulib location.
 328         (HFILES_NO_SRCDIR): Remove gnulib files.
 329         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 330         (generated_files): Remove GNULIB_H.
 331         ($(LIBGNU), all-lib): Remove targets.
 332         (distclean): Don't mention GNULIB_BUILDDIR.
 333         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 334
 335 2019-06-14  Tom Tromey  <tromey@adacore.com>
 336
 337         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 338         Warn if symbol file does not provide any symbols.
 339
 340 2019-06-14  Tom Tromey  <tromey@adacore.com>
 341
 342         * source.c (find_and_open_source): Respect basenames_may_differ.
 343
 344 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 345
 346         * annotate.c (annotate_breakpoints_invalid): Make use of
 347         scoped_restore_terminal_state.
 348         (annotate_frames_invalid): Likewise.
 349
 350 2019-06-14  Tom Tromey  <tromey@adacore.com>
 351
 352         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 353         allow assignment to an internalvar.
 354
 355 2019-06-14  Tom Tromey  <tromey@adacore.com>
 356
 357         * ada-lex.l: Allow "_" in attribute names.
 358
 359 2019-06-14  Tom Tromey  <tromey@adacore.com>
 360
 361         PR gdb/24653:
 362         * regcache.c (registers_changed): Don't call alloca.
 363         * top.c (execute_command): Don't call alloca.
 364
 365 2019-06-13  Pedro Alves  <palves@redhat.com>
 366
 367         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 368         'expression'.  When parsing an expression, error out if there's
 369         junk after "unlimited".
 370         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 371         (do_set_command): Adjust calls to is_unlimited_literal.
 372
 373 2019-06-13  Pedro Alves  <palves@redhat.com>
 374
 375         * compile/compile.c (make_compile_options_def_group): Add braces
 376         around array_view initializer.
 377         * thread.c (make_thread_apply_all_options_def_group)
 378         (make_thread_apply_all_options_def_group): Likewise.
 379
 380 2019-06-13  Pedro Alves  <palves@redhat.com>
 381
 382         * NEWS (New commands): Mention "maint test-options
 383         require-delimiter", "maint test-options unknown-is-error", "maint
 384         test-options unknown-is-operand" and "maint show
 385         test-options-completion-result".
 386         (New command options, command completion): New section.
 387         (Completion improvements): New section.
 388         Mention that you can abbreviate "unlimited".
 389
 390 2019-06-13  Pedro Alves  <palves@redhat.com>
 391
 392         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 393         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 394         * unittests/cli-utils-selftests.c (test_parse_flags)
 395         (test_parse_flags_qcs): Delete.
 396         (test_cli_utils): Don't call deleted functions.
 397
 398 2019-06-13  Pedro Alves  <palves@redhat.com>
 399
 400         * thread.c: Include "cli/cli-option.h".
 401         (tp_array_compar_ascending): Global.
 402         (tp_array_compar): Delete function.
 403         (tp_array_compar_ascending, tp_array_compar_descending): New
 404         functions.
 405         (ascending_option_def, qcs_flag_option_def)
 406         (thr_qcs_flags_option_defs)
 407         (make_thread_apply_all_options_def_group)
 408         (make_thread_apply_options_def_group): New.
 409         (thread_apply_all_command): Use gdb::option::process_options.
 410         (thread_apply_command_completer)
 411         (thread_apply_all_command_completer): New.
 412         (thread_apply_command): Use gdb::option::process_options.
 413         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 414         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 415         to generate help text of "thread apply".  Adjust "taas"'s help.
 416         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 417         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 418
 419 2019-06-13  Pedro Alves  <palves@redhat.com>
 420
 421         * thread.c (thread_apply_command): Check for invalid TID with
 422         isdigit instead of !isalpha.
 423
 424 2019-06-13  Pedro Alves  <palves@redhat.com>
 425
 426         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 427         (validate_flags_qcs): New.
 428         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 429         (validate_flags_qcs): Declare.
 430         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 431         (make_frame_apply_options_def_group): New.
 432         (frame_apply_command_count): Process options with
 433         gdb::option::process_options.
 434         (frame_apply_completer): New.
 435         (frame_apply_level_completer, frame_apply_all_completer)
 436         (frame_apply_completer): New.
 437         (_initialize_stack): Update help of "frame apply", "frame apply
 438         level", "frame apply all" and "faas" to mention supported options
 439         and install command completers.
 440         * stack.h (frame_apply_all_completer): Declare.
 441         * thread.c: Include "stack.h".
 442         (tfaas_command): Add "--".
 443         (_initialize_thread): Update help "tfaas" to mention supported
 444         options and install command completer.
 445
 446 2019-06-13  Pedro Alves  <palves@redhat.com>
 447
 448         * completer.c (complete_nested_command_line): New.
 449         (gdb_completion_word_break_characters_throw): Add assertion.
 450         * completer.h (complete_nested_command_line): Declare.
 451
 452 2019-06-13  Pedro Alves  <palves@redhat.com>
 453
 454         * stack.c (parse_backtrace_qualifiers): New.
 455         (backtrace_command): Use it.
 456         (backtrace_command_completer): Complete on qualifiers.
 457
 458 2019-06-13  Pedro Alves  <palves@redhat.com>
 459
 460         * frame.c: Include "cli/cli-option.h.
 461         (user_set_backtrace_options): New.
 462         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 463         Delete.
 464         (get_prev_frame): Adjust.
 465         (boolean_option_def, uinteger_option_def)
 466         (set_backtrace_option_defs): New.
 467         (_initialize_frame): Adjust and use
 468         gdb::option::add_setshow_cmds_for_options to install "set
 469         backtrace past-main" and "set backtrace past-entry".
 470         * frame.h: Include "cli/cli-option.h".
 471         (struct frame_print_options): Forward declare.
 472         (print_frame_arguments_all, print_frame_arguments_scalars)
 473         (print_frame_arguments_none): Declare.
 474         (print_entry_values): Delete declaration.
 475         (struct frame_print_options, user_frame_print_options): New.
 476         (struct set_backtrace_options): New.
 477         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 478         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 479         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 480         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 481         (list_args_or_locals): Add frame_print_options parameter.
 482         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 483         * python/py-framefilter.c (enumerate_args): Pass down
 484         USER_FRAME_PRINT_OPTIONS.
 485         * stack.c: Include "cli/cli-option.h".
 486         (print_frame_arguments_all, print_frame_arguments_scalars)
 487         (print_frame_arguments_none): Declare.
 488         (print_raw_frame_arguments, print_entry_values): Delete.
 489         (user_frame_print_options): New.
 490         (boolean_option_def, enum_option_def, frame_print_option_defs):
 491         New.
 492         (struct backtrace_cmd_options): New.
 493         (bt_flag_option_def): New.
 494         (backtrace_command_option_defs): New.
 495         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 496         (print_frame_arg, read_frame_arg, print_frame_args)
 497         (print_frame_info, print_frame): Add frame_print_options parameter
 498         and use it.
 499         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 500         (backtrace_command_1): Add frame_print_options and
 501         backtrace_cmd_options parameters and use them.
 502         (make_backtrace_options_def_group): New.
 503         (backtrace_command): Process command options with
 504         gdb::option::process_options.
 505         (backtrace_command_completer): New.
 506         (_initialize_stack): Extend "backtrace"'s help to mention
 507         supported options.  Install completer for "backtrace".
 508         Install some settings commands with add_setshow_cmds_for_options.
 509
 510 2019-06-13  Pedro Alves  <palves@redhat.com>
 511
 512         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 513         and that "set/show print raw frame-arguments" are now deprecated.
 514
 515         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 516         command.
 517         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 518         * stack.c (_initialize_stack): Install "set/show print
 519         raw-frame-arguments", and deprecate "set/show print raw
 520         frame-arguments".
 521         * valprint.c (_initialize_valprint): Deprecate "set/show print
 522         raw".
 523
 524 2019-06-13  Pedro Alves  <palves@redhat.com>
 525
 526         * compile/compile.c (struct compile_options): New.
 527         (compile_flag_option_def, compile_command_option_defs)
 528         (make_compile_options_def_group): New.
 529         (compile_file_command): Handle options with
 530         gdb::option::process_options.
 531         (compile_file_command_completer): New function.
 532         (compile_code_command): Handle options with
 533         gdb::option::process_options.
 534         (compile_code_command_completer): New function.
 535         (_initialize_compiler): Install completers for "compile code" and
 536         "compile file".  Mention available options in "compile code" and
 537         "compile code"'s help.
 538         * completer.c (advance_to_completion_word): New, factored out from
 539         ...
 540         (advance_to_expression_complete_word_point): ... this.
 541         (advance_to_filename_complete_word_point): New.
 542         * completer.h (advance_to_filename_complete_word_point): New
 543         declaration.
 544
 545 2019-06-13  Pedro Alves  <palves@redhat.com>
 546
 547         * compile/compile.c: Include "cli/cli-option.h".
 548         (compile_print_value): Scope data pointer is now a
 549         value_print_options pointer; adjust.
 550         (compile_print_command): Process options.  Scope data pointer is
 551         now a value_print_options pointer; adjust.
 552         (_initialize_compile): Update "compile print"'s help to include
 553         supported options.  Install a completer for "compile print".
 554         * cp-valprint.c (show_vtblprint, show_objectprint)
 555         (show_static_field_print): Delete.
 556         (_initialize_cp_valprint): Don't install "set print
 557         static-members", "set print vtbl", "set print object" here.
 558         * printcmd.c: Include "cli/cli-option.h" and
 559         "common/gdb_optional.h".
 560         (print_command_parse_format): Rework to fill in a
 561         value_print_options instead of a format_data.
 562         (print_value): Change parameter type from format_data pointer to
 563         value_print_options reference.  Adjust.
 564         (print_command_1): Process options.  Adjust to pass down a
 565         value_print_options.
 566         (print_command_completer): New.
 567         (_initialize_printcmd): Install print_command_completer as
 568         handle_brkchars completer for the "print" command.  Update
 569         "print"'s help to include supported options.
 570         * valprint.c: Include "cli/cli-option.h".
 571         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 572         here from cp-valprint.c.
 573         (boolean_option_def, uinteger_option_def)
 574         (value_print_option_defs, make_value_print_options_def_group):
 575         New.  Use gdb::option::add_setshow_cmds_for_options to install
 576         "set print elements", "set print null-stop", "set print repeats",
 577         "set print pretty", "set print union", "set print array", "set
 578         print address", "set print symbol", "set print array-indexes".
 579         * valprint.h: Include <string> and "cli/cli-option.h".
 580         (make_value_print_options_def_group): Declare.
 581         (print_value): Change parameter type from format_data pointer to
 582         value_print_options reference.
 583         (print_command_completer): Declare.
 584
 585 2019-06-13  Pedro Alves  <palves@redhat.com>
 586
 587         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 588         (COMMON_SFILES): Add maint-test-settings.c.
 589         * cli/cli-decode.c (boolean_enums): New global, factored out from
 590         ...
 591         (add_setshow_boolean_cmd): ... here.
 592         * cli/cli-decode.h (boolean_enums): Declare.
 593         * cli/cli-option.c: New file.
 594         * cli/cli-option.h: New file.
 595         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 596         factored out from ...
 597         (parse_cli_boolean_value(const char *)): ... this.
 598         (is_unlimited_literal): Change parameter type to pointer to
 599         pointer.  Adjust and advance ARG pointer.
 600         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 601         (parse_cli_var_enum): New, factored out from ...
 602         (do_set_command): ... this.  Adjust.
 603         * cli/cli-setshow.h (parse_cli_boolean_value)
 604         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 605         (parse_cli_var_enum): Declare.
 606         * cli/cli-utils.c: Include "cli/cli-option.h".
 607         (get_ulongest): New.
 608         * cli/cli-utils.h (get_ulongest): Declare.
 609         (check_for_argument): New overloads.
 610         * maint-test-options.c: New file.
 611
 612 2019-06-13  Pedro Alves  <palves@redhat.com>
 613
 614         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 615         parse a range if "-" is at the end of the string.
 616
 617 2019-06-13  Pedro Alves  <palves@redhat.com>
 618
 619         * cli/cli-setshow.c (parse_auto_binary_operation)
 620         (parse_cli_boolean_value): Don't allow "o".
 621
 622 2019-06-13  Pedro Alves  <palves@redhat.com>
 623
 624         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 625         * NEWS: Mention maint test-settings KIND.
 626         * maint-test-settings.c: New file.
 627
 628 2019-06-13  Pedro Alves  <palves@redhat.com>
 629
 630         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 631         completer.
 632         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 633         "set" completers.
 634
 635 2019-06-13  Pedro Alves  <palves@redhat.com>
 636
 637         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 638         after item.
 639
 640 2019-06-13  Pedro Alves  <palves@redhat.com>
 641
 642         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 643
 644 2019-06-13  Pedro Alves <palves@redhat.com>
 645
 646         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 647         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 648         call.
 649         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 650         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 651         calls.
 652         (check_for_argument): Skip spaces after argument.
 653
 654 2019-06-13  Pedro Alves  <palves@redhat.com>
 655
 656         * thread.c (thread_apply_command): Adjust TID parsing.
 657         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 658         detected before end of string.
 659         (tid_is_in_list): Error out if LIST is invalid.
 660
 661 2019-06-13  Pedro Alves  <palves@redhat.com>
 662
 663         * completer.c (complete_line_internal_1): Rewind completion word
 664         point.
 665         (completion_tracker::advance_custom_word_point_by): Change
 666         parameter type to int.
 667         * completer.h (completion_tracker::advance_custom_word_point_by):
 668         Likewise.
 669
 670 2019-06-13  Pedro Alves  <palves@redhat.com>
 671
 672         * completer.c (advance_to_completion_word): Handle delimiters.
 673
 674 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 675
 676         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 677
 678 2019-06-11  Tom Tromey  <tom@tromey.com>
 679
 680         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 681         (xmalloc_failed): Move to alloc.c.
 682         * alloc.c: New file.
 683         * Makefile.in (COMMON_SFILES): Add alloc.c.
 684
 685 2019-06-11  Tom Tromey  <tom@tromey.com>
 686
 687         * nat/linux-waitpid.c: Don't include server.h.
 688         (linux_debug): Remove.
 689         (my_waitpid): Update.
 690
 691 2019-06-11  Tom Tromey  <tromey@adacore.com>
 692
 693         * infcall.c (_initialize_infcall): Remove trailing newline from
 694         help.
 695         * user-regs.c (_initialize_user_regs): Remove trailing newline
 696         from help.
 697         * typeprint.c (_initialize_typeprint): Remove trailing newline
 698         from help.
 699         * reverse.c (_initialize_reverse): Remove trailing newlines from
 700         help.
 701         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 702         from help.
 703         * language.c (add_set_language_command): Remove trailing newline
 704         from help.
 705         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 706         help.
 707         * disasm.c (_initialize_disasm): Remove trailing newline from
 708         help.
 709         * top.c (init_main): Remove trailing newline from help.
 710         * interps.c (_initialize_interpreter): Remove trailing newline
 711         from help.
 712         * btrace.c (_initialize_btrace): Remove trailing newlines from
 713         help.
 714         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 715         from help.
 716         * python/python.c (_initialize_python): Remove trailing newline
 717         from help.
 718         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 719         help.
 720         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 721         from help.  Reformat some text.
 722         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 723         from help.
 724         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 725         newline from help.
 726
 727 2019-06-11  Tom Tromey  <tromey@adacore.com>
 728
 729         * darwin-nat.c (darwin_decode_exception_message)
 730         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 731
 732 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 733
 734         * valops.c (value_slice): Check for not allocated or not
 735         associated values.
 736
 737 2019-06-10  Tom de Vries  <tdevries@suse.de>
 738
 739         PR gdb/24618
 740         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 741         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 742         invalid.
 743
 744 2019-06-10  Tom de Vries  <tdevries@suse.de>
 745
 746         PR gdb/24611
 747         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 748         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 749
 750 2019-06-10  Tom de Vries  <tdevries@suse.de>
 751
 752         PR symtab/24545
 753         * symtab.c (struct demangled_name_entry): Add language field.
 754         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 755         static minimal symbol".  Set and use language field.
 756
 757 2019-06-10  Tom Tromey  <tromey@adacore.com>
 758
 759         * ada-lang.c (_initialize_ada_language): Update help text.
 760
 761 2019-06-10  Tom Tromey  <tromey@adacore.com>
 762
 763         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 764         with a newline.
 765         * guile/guile.c (handle_boot_error): Don't end warning with a
 766         newline.
 767         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 768         warning with a newline.
 769         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 770         newline.
 771         (s12z_frame_cache): Likewise.
 772         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 773         a newline.
 774         * solib-svr4.c (disable_probes_interface): Don't end warning with
 775         a newline.
 776         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 777         newline.
 778         * python/python.c (do_finish_initialization): Don't end warning
 779         with a newline.
 780
 781 2019-06-10  Tom Tromey  <tom@tromey.com>
 782
 783         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 784         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 785         gdbpy_enter.
 786
 787 2019-06-10  Tom Tromey  <tromey@adacore.com>
 788
 789         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 790         data.
 791         (elf_new_init): Don't call stabsread_new_init.
 792         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 793         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 794         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 795
 796 2019-06-10  Tom de Vries  <tdevries@suse.de>
 797
 798         PR symtab/16264
 799         PR symtab/24517
 800         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 801
 802 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 803
 804         * source.c (find_and_open_source): Also rewrite relative file
 805         names.
 806
 807 2019-04-26  Amos Bird  <amosbird@gmail.com>
 808
 809         * annotate.c (annotate_thread_exited): Add "thread-exited"
 810         annotation.
 811
 812 2019-06-06  Tom Tromey  <tromey@adacore.com>
 813
 814         * maint.h (class scoped_command_stats): Use
 815         DISABLE_COPY_AND_ASSIGN.
 816         <print_time>: New method.
 817         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 818         print_time.
 819         (scoped_command_stats::print_time): New method.
 820
 821 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 824         instructions of lengths 6 or 8 bytes.
 825
 826 2019-06-04  Pedro Alves  <palves@redhat.com>
 827
 828         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 829
 830         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 831         * breakpoint.c (condition_completer): Likewise.
 832         * cli/cli-dump.c (scan_expression): Likewise.
 833         * common/filestuff.c (mkdir_recursive): Likewise.
 834         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 835         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 836         (gdb_abspath): Likewise.
 837         * compile/compile-cplus-types.c
 838         (compile_cplus_instance::decl_name): Likewise.
 839         * completer.c (complete_explicit_location):
 840         (signal_completer, reg_or_group_completer_1): Likewise.
 841         * cp-support.c (cp_remove_params_if_any): Likewise.
 842         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 843         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 844         * infcmd.c (strip_bg_char): Likewise.
 845         * linespec.c (copy_token_string): Likewise.
 846         * mi/mi-main.c (output_cores): Likewise.
 847         * psymtab.c (psymtab_search_name):
 848         * symfile.c (test_set_ext_lang_command): Likewise.
 849         * target.c (target_fileio_read_stralloc): Likewise.
 850         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 851         * value.c (complete_internalvar): Likewise.
 852
 853 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 854
 855         Add objfile property to gdb.Type.
 856         * NEWS: Mention Python API addition.
 857         * python/py-type.c (typy_get_objfile): New method.
 858
 859 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 860
 861         * NEWS: Mention the new set|show style [title|highlight].
 862         Mention changes to "show style", "help" and "apropos".
 863
 864 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 865
 866         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 867         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 868         instead of print_help_for_command.
 869         (print_doc_of_command): New function.
 870         (help_list): Add 'apropos -v word' suggestion.
 871         (print_help_for_command): Style the command name using title style.
 872         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 873         (_initialize_cli_cmds): Describe -v in apropos_command help.
 874
 875 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 876
 877         * cli/cli-style.h (cli_style_option): Add name in constructor,
 878         add m_name class member, add constructor with intensity,
 879         add name class function.
 880         (cli_style_option::add_setshow_commands): Remove name argument.
 881         (highlight_style, title_style): New styles.
 882         * cli/cli-style.c (do_show): New function that shows a style
 883         characteristic styling the style name with itself.
 884         (set_style_name): New function.
 885         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 886         Update all callers according to the changes in cli/cli-style.h.
 887         * utils.h (fputs_highlighted): New function.
 888         * utils.c (fputs_highlighted): Likewise.
 889
 890 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 891
 892         * NEWS: Mention new pipe command and new convenience variables.
 893
 894 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 895
 896         * cli/cli-cmds.c (pipe_command): New function.
 897         (_initialize_cli_cmds): Call add_com for pipe_command.
 898         Define | as an alias for pipe.
 899         (exit_status_set_internal_vars): New function.
 900         (shell_escape): Call exit_status_set_internal_vars.
 901         cli/cli-decode.c (find_command_name_length): Recognize | as
 902         a single character command.
 903
 904 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 905
 906         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 907         top.c (execute_command_to_ui_file): New function, mostly a copy
 908         of execute_command_to_string.
 909         (execute_command_to_string): Implement by calling
 910         execute_command_to_ui_file.
 911
 912 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 913
 914         * top.h (saved_command_line): Remove declaration.
 915         * top.c (previous_saved_command_line, previous_repeat_arguments):
 916         New variables.
 917         (saved_command_line): Make static, define together with other
 918         'repeat variables'.
 919         (dont_repeat): Clear repeat_arguments.
 920         (repeat_previous, get_saved_command_line, save_command_line):
 921         New functions.
 922         (gdb_init): Initialize saved_command_line
 923         and previous_saved_command_line.
 924         * main.c (captured_main_1): Remove saved_command_line initialization.
 925         * event-top.c (handle_line_of_input): Update to use
 926         the new 'repeat' related functions instead of direct access to
 927         saved_command_line.
 928         * command.h (repeat_previous, get_saved_command_line,
 929         save_command_line): New declarations.
 930         (dont_repeat): Add comment.
 931
 932 2019-05-30  Tom Tromey  <tromey@adacore.com>
 933
 934         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 935         Fix comment.
 936         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 937
 938 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 939
 940         PR cli/24587
 941         * completer.c (complete): Initialize variable word.
 942
 943 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 944
 945         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 946         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 947         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 948         'body' is NULL to the outter 'if', protecting the '!is_define'
 949         situation as well.
 950
 951 2019-05-29  Tom Tromey  <tromey@adacore.com>
 952
 953         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 954         (dwarf_unknown): New function.
 955         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 956         (dwarf_type_encoding_name): Use dwarf_unknown.
 957
 958 2019-05-29  Tom Tromey  <tromey@adacore.com>
 959
 960         PR c++/20020:
 961         * cp-valprint.c (cp_print_value_fields): Call
 962         cp_print_static_field inside "try".
 963
 964 2019-05-29  Tom Tromey  <tromey@adacore.com>
 965
 966         * inflow.c (struct terminal_info): Add default operator=.
 967         * configure: Rebuild.
 968         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 969         -Wdeprecated-copy-dtor, -Wredundant-move.
 970
 971 2019-05-29  Tom Tromey  <tromey@adacore.com>
 972
 973         * NEWS: Add entry.
 974         * infcmd.c (print_return_value_1): Handle finish_print
 975         option.
 976         (show_print_finish): New function.
 977         (_initialize_infcmd): Add "set/show print finish" commands.
 978         * valprint.c (user_print_options): Initialize new member.
 979         * valprint.h (struct value_print_options) <finish_print>: New
 980         member.
 981
 982 2019-05-28  Tom Tromey  <tromey@adacore.com>
 983
 984         * ada-lang.c (ada_remove_Xbn_suffix)
 985         (find_old_style_renaming_symbol)
 986         (parse_old_style_renaming): Remove.
 987         (ada_find_renaming_symbol): Don't call
 988         find_old_style_renaming_symbol.
 989         (ada_is_renaming_symbol): Rename from
 990         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 991         bool.  Now static.
 992         (ada_read_var_value): Update and simplify.
 993         * ada-exp.y (write_var_or_type): Remove old code.
 994
 995 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 996
 997         * event-top.c: Remove include comment.
 998         * inflow.c (class scoped_ignore_sigttou): Move from here...
 999         * inflow.h (class scoped_ignore_sigttou): ...to here.
1000         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1001         * top.c:  Remove include comment.
1002
1003 2019-05-27  Tom Tromey  <tom@tromey.com>
1004
1005         * NEWS: Fix typo.
1006
1007 2019-05-22  Tom Tromey  <tromey@adacore.com>
1008
1009         * target.c (target_follow_exec): Constify parameter.
1010         * target-delegates.c: Rebuild.
1011         * remote.c (remote_target::follow_exec): Constify parameter.
1012         * infrun.c (follow_exec): Constify parameter.
1013         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1014         (target_follow_exec): Likewise.
1015
1016 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1017
1018         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1019         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1020
1021 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1022
1023         * NEWS: Add debugredirect and testsuite sections.
1024
1025 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1026
1027         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1028         target descriptions using exclusively floating point register name
1029         aliases.
1030
1031 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         PR gdb/18644:
1034         * f-lang.c (build_fortran_types): Handle the case where
1035         gdbarch_floatformat_for_type returns a nullptr.
1036
1037 2019-05-21  Tom de Vries  <tdevries@suse.de>
1038
1039         PR cli/24587
1040         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1041
1042 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1043
1044         PR gdb/18644:
1045         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1046         16-byte floats.
1047         * i386-tdep.c (i386_floatformat_for_type): Use
1048         floatformats_ia64_quad for the 16-byte floating point component
1049         within a fortran 32-byte complex number.
1050
1051 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1052
1053         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1054         delete default constructor.
1055         (find_partial_die): Update to return const struct.
1056         (partial_die_parent_scope): Move variable declaration into scope
1057         of its use and change its type to auto.
1058         (guess_partial_die_structure_name): Likewise.
1059         (partial_die_info::fixup): Likewise.
1060
1061 2019-05-17  Tom Tromey  <tromey@adacore.com>
1062
1063         * source.c (find_and_open_source): Remove cast.
1064
1065 2019-05-17  Tom Tromey  <tromey@adacore.com>
1066
1067         * annotate.c (annotate_source): Make "filename" const.
1068         * annotate.h (annotate_source): Use const.
1069
1070 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1071
1072         * disasm.c (set_disassembler_options): Send errors to stderr.
1073
1074 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1075
1076         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1077         (cli_interp_base::set_logging): Check debug_redirect.
1078         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1079         * cli/cli-logging.c (debug_redirect): Add static variable.
1080         (pop_output_files): Add default param.
1081         (handle_redirections): Print debug setting.
1082         (show_logging_command): Likewise.
1083         (_initialize_cli_logging): Add debugredirect command.
1084         * interps.c (current_interp_set_logging): Add debug_redirect
1085         parameter.
1086         * interps.h (set_logging): Add debug_redirect parameter.
1087         (current_interp_set_logging): Likewise.
1088         * mi/mi-common.h: Likewise.
1089         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1090
1091 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1092             Tom Tromey  <tromey@adacore.com>
1093
1094         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1095         directly.
1096         * cli/cli-interp.h (make_logging_output): Remove declaration.
1097         * cli/cli-logging.c (make_logging_output): Remove function.
1098         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1099         directly.
1100         * ui-file.c (tee_file::tee_file): Remove bools.
1101         (tee_file::~tee_file): Remove deletes.
1102         * ui-file.h (tee_file): Remove bools.
1103
1104 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1105
1106         * mi/mi-cmds.h (mi_cmd_complete): New function.
1107         * mi/mi-main.c (mi_cmd_complete): Likewise.
1108         * mi/mi-cmds.c: Define new MI command -complete.
1109         * NEWS: Mention new -complete command.
1110
1111 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1112
1113         * completer.h (complete): New function.
1114         * completer.c (complete): Likewise.
1115         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1116         function defined in completer.h.
1117
1118 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1119
1120         * MAINTAINERS (Write After Approval): Add myself.
1121
1122 2019-05-17  Tom de Vries  <tdevries@suse.de>
1123
1124         PR gdb/24094
1125         * dwarf2read.c (struct cu_partial_die_info): New struct.
1126         (find_partial_die): Return cu_partial_die_info.
1127         (partial_die_parent_scope, guess_partial_die_structure_name)
1128         (partial_die_info::fixup): Handle new return type of find_partial_die.
1129
1130 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1131
1132         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1133         "std::string", simplifying the algorithm.
1134
1135 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1136
1137         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1138         (stap_static_probe_ops::get_probes): Likewise.
1139
1140 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1141
1142         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1143         '-')" and "else if".
1144         (stap_parse_single_operand): Join checks for
1145         "gdbarch_stap_parse_special_token_p" and
1146         "gdbarch_stap_parse_special_token" in the same "if" statement.
1147         Invert check when verifying for operation on register
1148         displacement.
1149
1150 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1151
1152         * stap-probe.c (stap_get_opcode): Update comment.
1153         (stap_get_expected_argument_type): Likewise.
1154         (handle_stap_probe): Likewise.
1155
1156 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1157
1158         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1159         return type to 'bool'.  Adjust comment.  Use 'bool' when
1160         appropriate.
1161         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1162         * stap-probe.c (stap_parse_argument_1): Likewise.
1163         (stap_is_operator): Likewise.
1164         (stap_is_generic_prefix): Likewise.
1165         (stap_is_register_prefix): Likewise.
1166         (stap_is_register_indirection_prefix): Likewise.
1167         (stap_is_integer_prefix): Likewise.
1168         (stap_generic_check_suffix): Likewise.
1169         (stap_check_integer_suffix): Likewise.
1170         (stap_check_register_suffix): Likewise.
1171         (stap_check_register_indirection_suffix): Likewise.
1172         (stap_parse_register_operand): Likewise.
1173         (stap_parse_single_operand): Likewise.
1174         (stap_parse_argument_1): Likewise.
1175         (stap_probe::get_argument_count): Likewise.
1176         (stap_is_operator): Likewise.
1177
1178 2019-05-16  Tom Tromey  <tromey@adacore.com>
1179
1180         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1181         keyword to foreach.
1182
1183 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1184
1185         * linux-thread-db.c (try_thread_db_load_1): Change return type
1186         to bool.
1187         (try_thread_db_load): Likewise.
1188         (try_thread_db_load_from_pdir_1): Likewise.
1189         (try_thread_db_load_from_pdir): Likewise.
1190         (try_thread_db_load_from_sdir): Likewise.
1191         (try_thread_db_load_from_dir): Likewise.
1192         (thread_db_load_search): Likewise.
1193         (has_libpthread): Likewise.
1194         (thread_db_load): Likewise.
1195
1196 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1197
1198         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1199         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1200         NULL, and complain/return if that's the case.
1201
1202 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1203
1204         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1205         (advance, posn, abstract_read_memory): New functions.
1206         [struct mem_read_abstraction]: New struct.
1207         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1208
1209 2019-05-14  Tom Tromey  <tromey@adacore.com>
1210
1211         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1212         value is not lval_memory.
1213
1214 2019-05-14  Tom Tromey  <tromey@adacore.com>
1215
1216         * solib.c (info_sharedlibrary_command): Style the file name.
1217
1218 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1219
1220         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1221         (aarch64_vnv_type): Likewise.
1222         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1223         * common/tdesc.c: Likewise.
1224         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1225         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1226         * features/aarch64-fpu.xml: Add ieee half view.
1227         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1228         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1229         * gdbtypes.h (struct builtin_type): Likewise.
1230         (struct objfile_type): Likewise.
1231
1232 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1233
1234         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1235         typo.
1236         * location.h (string_to_event_location): Likewise.
1237
1238 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1239
1240         GDB 8.3 released.
1241
1242 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1243
1244         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1245         New variable declaration.
1246         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1247         New variable.
1248         (print_one_breakpoint): Use ui_out::test_flags and new global
1249         variable to compute use_fixed_output.
1250         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1251         Remove.
1252         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1253         (mi_multi_location_breakpoint_output_fixed): Remove.
1254         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1255         new variable.
1256         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1257         fix_multi_location_breakpoint_output flag if version >= 3.
1258         * ui-out.h (enum ui_out_flag)
1259         <fix_multi_location_breakpoint_output>: New enumerator.
1260
1261 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1262
1263         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1264
1265 2019-05-10  Tom Tromey  <tromey@adacore.com>
1266
1267         * ada-lang.c (catch_ada_completer): New function.
1268         (_initialize_ada_language): Use it.
1269
1270 2019-05-10  Tom Tromey  <tromey@adacore.com>
1271
1272         * thread.c (print_thread_info): Make "requested_threads" const.
1273         * gdbthread.h (print_thread_info): Make "requested_threads"
1274         const.
1275         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1276         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1277
1278 2019-05-08  Tom Tromey  <tom@tromey.com>
1279
1280         * gdbtypes.c (objfile_type_data): Change type.
1281         (objfile_type, _initialize_gdbtypes): Update.
1282
1283 2019-05-08  Tom Tromey  <tom@tromey.com>
1284
1285         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1286         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1287         (_initialize_dwarf2_frame): Update.
1288
1289 2019-05-08  Tom Tromey  <tom@tromey.com>
1290
1291         * objc-lang.c (objc_objfile_data): Change type.
1292         (find_methods): Update.
1293         (_initialize_objc_lang): Remove.
1294
1295 2019-05-08  Tom Tromey  <tom@tromey.com>
1296
1297         * stabsread.c (rs6000_builtin_type_data): Change type.
1298         (rs6000_builtin_type, _initialize_stabsread): Update.
1299
1300 2019-05-08  Tom Tromey  <tom@tromey.com>
1301
1302         * mips-tdep.c (mips_pdr_data): Remove.
1303         (_initialize_mips_tdep): Update.
1304
1305 2019-05-08  Tom Tromey  <tom@tromey.com>
1306
1307         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1308         (hppa_init_objfile_priv_data, read_unwind_info)
1309         (find_unwind_entry, _initialize_hppa_tdep): Update.
1310
1311 2019-05-08  Tom Tromey  <tom@tromey.com>
1312
1313         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1314         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1315         on obstack.
1316         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1317
1318 2019-05-08  Tom Tromey  <tom@tromey.com>
1319
1320         * mdebugread.c (basic_type_data): Change type.
1321         (basic_type, _initialize_mdebugread): Update.
1322
1323 2019-05-08  Tom Tromey  <tom@tromey.com>
1324
1325         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1326
1327 2019-05-08  Tom Tromey  <tom@tromey.com>
1328
1329         * nto-tdep.c (nto_inferior_data_reg): Change type.
1330         (nto_inferior_data): Update.
1331         (nto_inferior_data_cleanup, nto_new_inferior_data)
1332         (_initialize_nto_tdep): Remove.
1333         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1334
1335 2019-05-08  Tom Tromey  <tom@tromey.com>
1336
1337         * ada-lang.c (struct ada_inferior_data): Add initializers.
1338         (ada_inferior_data): Change type.
1339         (ada_inferior_data_cleanup): Remove.
1340         (get_ada_inferior_data, ada_inferior_exit)
1341         (struct ada_pspace_data): Add initializers, destructor.
1342         (ada_pspace_data_handle): Change type.
1343         (get_ada_pspace_data): Update.
1344         (ada_pspace_data_cleanup): Remove.
1345
1346 2019-05-08  Tom Tromey  <tom@tromey.com>
1347
1348         * coffread.c (struct coff_symfile_info): Add initializers.
1349         (coff_objfile_data_key): Move lower.  Change type.
1350         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1351         Update.
1352         (coff_free_info): Remove.
1353
1354 2019-05-08  Tom Tromey  <tom@tromey.com>
1355
1356         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1357         (fbsd_pspace_data_handle): Move lower.  Change type.
1358         (get_fbsd_pspace_data): Update.
1359         (fbsd_pspace_data_cleanup): Remove.
1360         (_initialize_fbsd_tdep): Update.
1361
1362 2019-05-08  Tom Tromey  <tom@tromey.com>
1363
1364         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1365         (get_ada_tasks_pspace_data): Update.
1366         (ada_tasks_pspace_data_cleanup): Remove.
1367         (_initialize_tasks): Update.
1368         (ada_tasks_inferior_data_handle): Change type.
1369         (get_ada_tasks_inferior_data): Update.
1370         (ada_tasks_inferior_data_cleanup): Remove.
1371         (struct ada_tasks_pspace_data): Add initializers.
1372
1373 2019-05-08  Tom Tromey  <tom@tromey.com>
1374
1375         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1376         * symfile-debug.c (debug_sym_get_probes): Change type.
1377         * stap-probe.c (handle_stap_probe):
1378         (stap_static_probe_ops::get_probes): Change type.
1379         * probe.h (class static_probe_ops) <get_probes>: Change type.
1380         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1381         (parse_probes_in_pspace): Update.
1382         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1383         Update.
1384         (any_static_probe_ops::get_probes): Change type.
1385         * elfread.c (elfread_data): New typedef.
1386         (probe_key): Change type.
1387         (elf_get_probes): Likewise.  Update.
1388         (probe_key_free): Remove.
1389         (_initialize_elfread): Update.
1390         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1391         Change type.
1392         (dtrace_process_dof_probe, dtrace_process_dof)
1393         (dtrace_static_probe_ops::get_probe): Change type.
1394
1395 2019-05-08  Tom Tromey  <tom@tromey.com>
1396
1397         * xcoffread.c (struct xcoff_symfile_info): Rename from
1398         coff_symfile_info.  Add initializers.
1399         (xcoff_objfile_data_key): Move lower.  Change type.
1400         (XCOFF_DATA): Rewrite.
1401         (xcoff_free_info): Remove.
1402         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1403         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1404         (xcoff_initial_scan): Update.
1405
1406 2019-05-08  Tom Tromey  <tom@tromey.com>
1407
1408         * solib-svr4.c (struct svr4_info): Add initializers and
1409         destructor.
1410         <probes_table>: Now an htab_up.
1411         (solib_svr4_pspace_data): Change type.
1412         (free_probes_table): Simplify.
1413         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1414         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1415         (probes_table_remove_objfile_probes, register_solib_event_probe)
1416         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1417         (_initialize_svr4_solib): Update.
1418
1419 2019-05-08  Tom Tromey  <tom@tromey.com>
1420
1421         * remote.c (remote_pspace_data): Change type.
1422         (remote_pspace_data_cleanup): Remove.
1423         (get_remote_exec_file, set_pspace_remote_exec_file)
1424         (_initialize_remote): Update.
1425
1426 2019-05-08  Tom Tromey  <tom@tromey.com>
1427
1428         * breakpoint.c (breakpoint_objfile_key): Change type.
1429         (get_breakpoint_objfile_data): Update.
1430         (free_breakpoint_objfile_data): Remove.
1431         (_initialize_breakpoint): Update.
1432
1433 2019-05-08  Tom Tromey  <tom@tromey.com>
1434
1435         * linux-tdep.c (struct linux_info): Add initializers.
1436         (linux_inferior_data): Move.  Change type.
1437         (invalidate_linux_cache_inf): Update.
1438         (linux_inferior_data_cleanup): Remove.
1439         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1440
1441 2019-05-08  Tom Tromey  <tom@tromey.com>
1442
1443         * auxv.c (auxv_inferior_data): Move.  Change type.
1444         (auxv_inferior_data_cleanup): Remove.
1445         (invalidate_auxv_cache_inf): Rewrite.
1446         (get_auxv_inferior_data, _initialize_auxv): Update.
1447
1448 2019-05-08  Tom Tromey  <tom@tromey.com>
1449
1450         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1451         (symfile_debug_objfile_data_key): Change type.
1452         (symfile_debug_installed, debug_qf_has_symbols)
1453         (debug_qf_find_last_source_symtab)
1454         (debug_qf_forget_cached_source_info)
1455         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1456         (debug_qf_print_stats, debug_qf_dump)
1457         (debug_qf_expand_symtabs_for_function)
1458         (debug_qf_expand_all_symtabs)
1459         (debug_qf_expand_symtabs_with_fullname)
1460         (debug_qf_map_matching_symbols)
1461         (debug_qf_expand_symtabs_matching)
1462         (debug_qf_find_pc_sect_compunit_symtab)
1463         (debug_qf_map_symbol_filenames)
1464         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1465         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1466         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1467         (debug_sym_read_linetable, debug_sym_relocate): Update.
1468         (symfile_debug_free_objfile): Remove.
1469         (install_symfile_debug_logging, _initialize_symfile_debug):
1470         Update.
1471
1472 2019-05-08  Tom Tromey  <tom@tromey.com>
1473
1474         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1475         allocate_on_obstack.
1476         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1477         (get_dwarf2_per_objfile): Update.
1478         (set_dwarf2_per_objfile): Remove.
1479         (dwarf2_has_info, dwarf2_get_section_info): Update.
1480         (dwarf2_free_objfile): Remove.
1481         (_initialize_dwarf2_read): Update.
1482
1483 2019-05-08  Tom Tromey  <tom@tromey.com>
1484
1485         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1486         initializers.
1487         <unsupported_script_warning_printed,
1488         script_not_found_warning_printed>: Now bool.
1489         (auto_load_pspace_data): Change type.
1490         (~auto_load_pspace_info): Rename from
1491         auto_load_pspace_data_cleanup.
1492         (get_auto_load_pspace_data, init_loaded_scripts_info)
1493         (clear_section_scripts, maybe_print_unsupported_script_warning)
1494         (maybe_print_script_not_found_warning, _initialize_auto_load):
1495         Update.
1496
1497 2019-05-08  Tom Tromey  <tom@tromey.com>
1498
1499         * objfiles.c (objfile_pspace_info): Add destructor and
1500         initializers.
1501         (objfiles_pspace_data): Change type.
1502         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1503         (get_objfile_pspace_data): Update.
1504         (objfiles_bfd_data): Change type.
1505         (get_objfile_bfd_data): Update.
1506         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1507
1508 2019-05-08  Tom Tromey  <tom@tromey.com>
1509
1510         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1511         Change type.
1512         (get_catch_syscall_inferior_data): Update.
1513         (catch_syscall_inferior_data_cleanup): Remove.
1514         (_initialize_break_catch_syscall): Update.
1515
1516 2019-05-08  Tom Tromey  <tom@tromey.com>
1517
1518         * inflow.c (struct terminal_info): Add destructor and
1519         initializers.
1520         (inflow_inferior_data): Change type.
1521         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1522         (get_inflow_inferior_data, inflow_inferior_exit)
1523         (swap_terminal_info, _initialize_inflow): Update.
1524
1525 2019-05-08  Tom Tromey  <tom@tromey.com>
1526
1527         * target-dcache.c (target_dcache_cleanup): Remove.
1528         (target_dcache_aspace_key): Change type.
1529         (target_dcache_init_p, target_dcache_invalidate)
1530         (target_dcache_get, target_dcache_get_or_init)
1531         (_initialize_target_dcache): Update.
1532         * dcache.h (struct dcache_deleter): New.
1533
1534 2019-05-08  Tom Tromey  <tom@tromey.com>
1535
1536         * symtab.c (struct symbol_cache): Add destructor and
1537         initializers.
1538         (symbol_cache_key): Move.  Change type.
1539         (make_symbol_cache, free_symbol_cache): Remove.
1540         (get_symbol_cache): Update.
1541         (symbol_cache_cleanup): Remove.
1542         (ALL_PSPACES, symbol_cache_flush)
1543         (maintenance_print_symbol_cache)
1544         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1545         Update.
1546
1547 2019-05-08  Tom Tromey  <tom@tromey.com>
1548
1549         * symtab.c (struct main_info): Add destructor and initializers.
1550         (main_progspace_key): Move.  Change type.
1551         (get_main_info): Update.
1552         (main_info_cleanup): Remove.
1553         (_initialize_symtab): Update.
1554
1555 2019-05-08  Tom Tromey  <tom@tromey.com>
1556
1557         * registry.h (DECLARE_REGISTRY): Define the _key class.
1558
1559 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1560
1561         * NEWS: Merge two 'New commands' sections.
1562
1563 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1564
1565         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1566         parameter and use Ada language definition instead.
1567         (ada_val_print_ptr): Remove unused language parameter.
1568         (ada_val_print_num): Remove language parameter and use Ada language
1569         definition instead.
1570         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1571         parameter.
1572         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1573         parameter and use Ada language definition instead.
1574         (ada_val_print_1): Update all ada_val_print_xxx calls.
1575         Remove language parameter.
1576         (ada_val_print): Update ada_val_print_1 call.
1577
1578 2019-05-08  Tom Tromey  <tromey@adacore.com>
1579
1580         * remote.c (remote_hw_watchpoint_limit)
1581         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1582         Now static.
1583
1584 2019-05-08  Tom Tromey  <tromey@adacore.com>
1585
1586         * maint.c (_initialize_maint_cmds): Move initialization code to
1587         remote.c.
1588         (watchdog, show_watchdog): Move to remote.c.
1589         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1590         "watchdog" static.
1591         (_initialize_remote): Move initialization code from maint.c.
1592         * defs.h (watchdog): Don't declare.
1593
1594 2019-05-08  Tom Tromey  <tromey@adacore.com>
1595
1596         * tui/tui-interp.c: Include main.h.
1597         * interps.c: Include main.h.
1598         * main.h (interpreter_p): Declare.
1599         * defs.h (interpreter_p): Don't declare.
1600
1601 2019-05-08  Tom Tromey  <tromey@adacore.com>
1602
1603         * dwarf2loc.c: Include dwarf2read.h.
1604         * defs.h (read_unsigned_leb128): Don't declare.
1605         * dwarf2read.h (read_unsigned_leb128): Declare.
1606
1607 2019-05-08  Tom Tromey  <tromey@adacore.com>
1608
1609         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1610         method.
1611
1612 2019-05-08  Tom Tromey  <tromey@adacore.com>
1613
1614         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1615         when no wrap column is set.
1616
1617 2019-05-08  Tom Tromey  <tromey@adacore.com>
1618
1619         * c-lang.c (c_get_string): Handle non-C-style arrays.
1620
1621 2019-05-08  Tom Tromey  <tromey@adacore.com>
1622
1623         * typeprint.c (print_offset_data::update): Print the bit offset,
1624         not the number of bits remaining.
1625
1626 2019-05-08  Tom Tromey  <tromey@adacore.com>
1627
1628         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1629         padding at end of comment.
1630
1631 2019-05-08  Tom Tromey  <tromey@adacore.com>
1632
1633         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1634         Compare main types.
1635
1636 2019-05-06  Tom Tromey  <tom@tromey.com>
1637
1638         * common/scoped_mmap.c: Include common-defs.h.
1639         * common/scoped_mmap.h: Don't include config.h.
1640
1641 2019-05-04  Tom Tromey  <tom@tromey.com>
1642
1643         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1644         (struct aarch64_call_info): Add initializers.
1645         <si>: Now a std::vector.
1646         (pass_on_stack, aarch64_push_dummy_call): Update.
1647
1648 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1649             Tom Tromey  <tom@tromey.com>
1650
1651         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1652         (ppc_threads): Now a std::vector.  Now static.
1653         (hwdebug_find_thread_points_by_tid)
1654         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1655         Update.
1656
1657 2019-05-04  Tom Tromey  <tom@tromey.com>
1658
1659         * arc-tdep.c (arc_tdesc_init): Return bool.
1660
1661 2019-05-04  Tom Tromey  <tom@tromey.com>
1662
1663         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1664         Use gdb_assert_not_reached.
1665
1666 2019-05-04  Tom Tromey  <tom@tromey.com>
1667
1668         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1669         "false".
1670
1671 2019-05-04  Tom Tromey  <tom@tromey.com>
1672
1673         * arc-tdep.c (arc_tdesc_init): Use bool.
1674
1675 2019-05-04  Tom Tromey  <tom@tromey.com>
1676
1677         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1678
1679 2019-05-04  Tom Tromey  <tom@tromey.com>
1680
1681         * cli/cli-cmds.c (valid_command_p): Return bool.
1682
1683 2019-05-04  Tom Tromey  <tom@tromey.com>
1684
1685         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1686         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1687
1688 2019-05-04  Raul Tambre  <raul@tambre.ee>
1689
1690         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1691         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1692         operator for comparison.
1693
1694 2019-05-04  Tom Tromey  <tom@tromey.com>
1695
1696         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1697         (lookup_partial_symbol, print_partial_symbols)
1698         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1699         (psymbol_compare): Update.
1700         (add_psymbol_to_bcache): Clear the entire psymbol.
1701         (maintenance_check_psymtabs): Update.
1702         * psympriv.h (struct partial_symbol): Don't derive from
1703         general_symbol_info.
1704         <obj_section, unrelocated_address, address,
1705         set_unrelocated_address>: Update.
1706         <ginfo>: New member.
1707         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1708         (debug_names::write_psymbols): Update.
1709
1710 2019-05-04  Tom de Vries  <tdevries@suse.de>
1711
1712         * contrib/cc-with-tweaks.sh: Support -n arg.
1713
1714 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1715
1716         * corelow.c (core_target::detach): Ensure frame cache and
1717         register caches are cleared.
1718         inferior.c (exit_inferior_1): Likewise.
1719
1720 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1721             Tom Tromey  <tom@tromey.com>
1722
1723         * dictionary.c (collate_pending_symbols_by_language): Remove
1724         "struct" from foreach.
1725         * symtab.c (lookup_global_symbol_from_objfile)
1726         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1727         foreach.
1728         * ser-tcp.c (net_open): Remove "struct" from foreach.
1729         * objfiles.c (objfile_relocate, objfile_rebase)
1730         (objfile_has_symbols): Remove "struct" from foreach.
1731         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1732         from foreach.
1733         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1734         foreach.
1735         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1736         "struct" from foreach.
1737         * ada-lang.c (create_excep_cond_exprs)
1738         (ada_exception_catchpoint_cond_string): Remove "struct" from
1739         foreach.
1740
1741 2019-05-03  Tom Tromey  <tromey@adacore.com>
1742
1743         * ada-exp.y (convert_char_literal): Check suffix of each
1744         enumerator.
1745
1746 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1747
1748         PR ada/21406:
1749         * ada-exp.y (yywrap): Don't define.
1750         * ada-lex.l (%option): Add noyywrap
1751         (yywrap): Remove.
1752
1753 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1754
1755         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1756         _WIN32_WINNT to the XP level, unless already defined to a higher
1757         level.
1758
1759         * unittests/parse-connection-spec-selftests.c:
1760         * ser-tcp.c:
1761         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1762         override.
1763
1764         * symfile.c (find_separate_debug_file): Remove colon from the
1765         drive spec of DOS/Windows file names of the target, so that the
1766         file name produced from DEBUGDIR and the target's directory will
1767         be valid on DOS/Windows systems.
1768
1769 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1770
1771         * rust-lang.c (val_print_struct): Handle printing structures
1772         containing strings.
1773
1774 2019-05-02  Tom Tromey  <tromey@adacore.com>
1775
1776         * valarith.c (_initialize_valarith): Remove.
1777
1778 2019-05-01  Tom Tromey  <tromey@adacore.com>
1779
1780         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1781         bitfields.
1782
1783 2019-05-01  Tom Tromey  <tromey@adacore.com>
1784
1785         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1786         for big-endian copies.
1787
1788 2019-04-30  Ali Tamur  <tamur@google.com>
1789         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1790         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1791         (read_3_bytes): New function.
1792
1793 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1794
1795         * windows-nat.c (main_thread_id): Delete.
1796         (handle_output_debug_string): Replace main_thread_id by
1797         current_event.dwThreadId.
1798         (fake_create_process): Likewise.
1799         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1800         Do not set main_thread_id.
1801         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1802         current_event.dwThreadId.
1803         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1804
1805 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1806
1807         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1808         Use current_event.dwThreadId instead of main_thread_id.
1809
1810 2019-04-30  Tom Tromey  <tromey@adacore.com>
1811
1812         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1813         (create_excep_cond_exprs): Iterate over program spaces.
1814         (ada_exception_catchpoint_cond_string): Examine all minimal
1815         symbols for exception types.
1816
1817 2019-04-30  Tom Tromey  <tromey@adacore.com>
1818
1819         PR c++/24470:
1820         * dwarf2read.c (process_structure_scope): Handle case where type
1821         has template parameters but no symbol was created.
1822
1823 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1824             Chris January  <chris.january@arm.com>
1825
1826         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1827         qualifier.
1828         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1829
1830 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1831
1832         * f-typeprint.c (f_print_type): Update rules for printing
1833         whitespace.
1834         (f_type_print_varspec_suffix): Likewise.
1835
1836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1837             Chris January  <chris.january@arm.com>
1838
1839         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1840         function arguments.
1841
1842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1843
1844         * f-lang.c (build_fortran_types): Change name of void type to
1845         lower case.
1846         * f-typeprint.c (f_type_print_base): Print the name of the void
1847         type, rather than a fixed string.
1848         * f-valprint.c (f_decorations): Use lower case void string.
1849
1850 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1851             Chris January  <chris.january@arm.com>
1852
1853         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1854         types for Fortran.
1855
1856 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1857             Chris January  <chris.january@arm.com>
1858             David Lecomber  <david.lecomber@arm.com>
1859
1860         * f-exp.y (BINOP_INTRINSIC): New token.
1861         (exp): New parser rule handling BINOP_INTRINSIC.
1862         (f77_keywords): Add new builtin procedures.
1863         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1864         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1865         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1866         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1867         (print_unop_subexp_f): New function.
1868         (print_binop_subexp_f): New function.
1869         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1870         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1871         (dump_subexp_body_f): Likewise.
1872         (operator_check_f): Likewise.
1873         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1874         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1875
1876 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1877
1878         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1879         UNOP_KIND.
1880         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1881         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1882         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1883         (operator_length_f): New fuction.
1884         (print_subexp_f): New function.
1885         (op_name_f): New function.
1886         (dump_subexp_body_f): New function.
1887         (operator_check_f): New function.
1888         (exp_descriptor_f): Replace standard expression handling functions
1889         with new functions.
1890         * gdb/fortran-operator.def: New file.
1891         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1892         * gdb/std-operator.def: Remove UNOP_KIND.
1893
1894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * std-operator.def: Remove unbalanced, stray double quote
1897         character.
1898
1899 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1900             Chris January  <chris.january@arm.com>
1901             Daniel Everett  <daniel.everett@arm.com>
1902             Nick Forrington  <nick.forrington@arm.com>
1903             Richard Bunt  <richard.bunt@arm.com>
1904
1905         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1906         of depth when printing anonymous structs or unions.
1907         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1908         Don't print either the top-level value, or the children if the
1909         max-depth is exceeded.
1910         (ppscm_print_children): When printing the key of a map, allow one
1911         extra level of depth.
1912         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1913         print either the top-level value, or the children if the max-depth
1914         is exceeded.
1915         (print_children): When printing the key of a map, allow one extra
1916         level of depth.
1917         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1918         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1919         (user_print_options): Initialise max_depth field.
1920         (val_print_scalar_or_string_type_p): New function.
1921         (val_print): Check to see if the max depth has been reached.
1922         (val_print_check_max_depth): Define new function.
1923         (show_print_max_depth): New function.
1924         (_initialize_valprint): Add 'print max-depth' option.
1925         * valprint.h (struct value_print_options) <max_depth>: New field.
1926         (val_print_check_max_depth): Declare new function.
1927         * NEWS: Document new feature.
1928
1929 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1930
1931         * ada-lang.c (ada_language_defn): Initialise new field.
1932         * c-lang.c (c_is_string_type_p): New function.
1933         (c_language_defn): Initialise new field.
1934         (cplus_language_defn): Initialise new field.
1935         (asm_language_defn): Initialise new field.
1936         (minimal_language_defn): Initialise new field.
1937         * c-lang.h (c_is_string_type_p): Declare new function.
1938         * d-lang.c (d_language_defn): Initialise new field.
1939         * f-lang.c (f_is_string_type_p): New function.
1940         (f_language_defn): Initialise new field.
1941         * go-lang.c (go_is_string_type_p): New function.
1942         (go_language_defn): Initialise new field.
1943         * language.c (default_is_string_type_p): New function.
1944         (unknown_language_defn): Initialise new field.
1945         (auto_language_defn): Initialise new field.
1946         * language.h (struct language_defn) <la_is_string_type_p>: New
1947         member variable.
1948         (default_is_string_type_p): Declare new function.
1949         * m2-lang.c (m2_language_defn): Initialise new field.
1950         * objc-lang.c (objc_language_defn): Initialise new field.
1951         * opencl-lang.c (opencl_language_defn): Initialise new field.
1952         * p-lang.c (pascal_is_string_type_p): New function.
1953         (pascal_language_defn): Initialise new field.
1954         * rust-lang.c (rust_is_string_type_p): New function.
1955         (rust_language_defn): Initialise new field.
1956
1957 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1958
1959         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1960         New field.
1961         * ada-lang.c (ada_language_defn): Initialise new field.
1962         * c-lang.c (c_language_defn): Likewise.
1963         (cplus_language_defn): Likewise.
1964         (asm_language_defn): Likewise.
1965         (minimal_language_defn): Likewise.
1966         * d-lang.c (d_language_defn): Likewise.
1967         * f-lang.c (f_language_defn): Likewise.
1968         * go-lang.c (go_language_defn): Likewise.
1969         * language.c (unknown_language_defn): Likewise.
1970         (auto_language_defn): Likewise.
1971         * m2-lang.c (m2_language_defn): Likewise.
1972         * objc-lang.c (objc_language_defn): Likewise.
1973         * opencl-lang.c (opencl_language_defn): Likewise.
1974         * p-lang.c (pascal_language_defn): Likewise.
1975         * rust-lang.c (rust_language_defn): Likewise.
1976
1977 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1978
1979         * ada-lang.c (ada_is_character_type): Change return type to bool.
1980         (ada_is_string_type): Likewise.
1981         * ada-lang.h (ada_is_character_type): Update declaration
1982         (ada_is_string_type): Likewise.
1983
1984 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1985
1986         Support style in 'frame|thread apply'
1987
1988         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1989         * record.c (record_start, record_stop): Update callers of
1990         execute_command_to_string with false.
1991         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1992         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1993         methods.
1994         (class string_file): New constructor with term_out parameter.
1995         Override methods term_out and can_emit_style_escape.  New member
1996         term_out.
1997         (class stdio_file): Override can_emit_style_escape.
1998         (class tee_file): Override term_out and can_emit_style_escape.
1999         * utils.h (can_emit_style_escape): Remove.
2000         * utils.c (can_emit_style_escape): Likewise.
2001         Update all callers of can_emit_style_escape (SOMESTREAM) to
2002         SOMESTREAM->can_emit_style_escape.
2003         * source-cache.c (source_cache::get_source_lines): Likewise.
2004         * stack.c (frame_apply_command_count): Call execute_command_to_string
2005         passing the term_out characteristic of the current gdb_stdout.
2006         * thread.c (thr_try_catch_cmd): Likewise.
2007         * top.c (execute_command_to_string): pass term_out parameter
2008         to construct the string_file for the command output.
2009         * ui-file.c (term_cli_styling): New function (most code moved
2010         from utils.c can_emit_style_escape).
2011         (string_file::string_file, string_file::can_emit_style_escape,
2012         stdio_file::can_emit_style_escape, tee_file::term_out,
2013         tee_file::can_emit_style_escape): New functions.
2014
2015 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2016
2017         * NEWS: Mention the new set|show may-call-functions.
2018         * infcall.c (may_call_functions_p): New variable.
2019         (show_may_call_functions_p): New function.
2020         (call_function_by_hand_dummy): Throws an error if not
2021         may-call-functions.
2022         (_initialize_infcall): Call add_setshow_boolean_cmd for
2023         may-call-functions.
2024
2025 2019-04-25  Keith Seitz  <keiths@redhat.com>
2026
2027         PR c++/24367
2028         * cp-support.c (inspect_type): Don't attempt substitutions
2029         of symbol with the same name.
2030
2031 2019-04-25  Tom Tromey  <tromey@adacore.com>
2032
2033         PR gdb/24475:
2034         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2035         static.
2036
2037 2019-04-25  Tom Tromey  <tromey@adacore.com>
2038
2039         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2040         rvalue reference.
2041         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2042         (gdb_xml_parser::parse): Use std::move.
2043         * python/python-internal.h (gdbpy_convert_exception): Take a const
2044         reference.
2045         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2046         std::move.
2047         * python/py-utils.c (gdbpy_convert_exception): Take a const
2048         reference.
2049         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2050         Use std::move.
2051         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2052         Use std::move.
2053         * mi/mi-main.c (mi_print_exception): Take a const reference.
2054         * main.c (handle_command_errors): Take a const reference.
2055         * linespec.c (parse_linespec): Use std::move.
2056         * infcall.c (run_inferior_call): Use std::move.
2057         (call_function_by_hand_dummy): Use std::move.
2058         * exec.c (try_open_exec_file): Use std::move.
2059         * exceptions.h (exception_print, exception_fprintf)
2060         (exception_print_same): Update.
2061         * exceptions.c (print_exception, exception_print)
2062         (exception_fprintf, exception_print_same): Change parameters to
2063         const reference.
2064         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2065         * common/new-op.c: Use std::move.
2066         * common/common-exceptions.h (struct gdb_exception): Add move
2067         constructor.
2068         (struct gdb_exception_error, struct gdb_exception_quit, struct
2069         gdb_quit_bad_alloc): Change constructor to move constructor.
2070         (throw_exception): Change parameter to rvalue reference.
2071         * common/common-exceptions.c (throw_exception): Take rvalue
2072         reference.
2073         * cli/cli-interp.c (safe_execute_command): Use std::move.
2074         * breakpoint.c (insert_bp_location, location_to_sals): Use
2075         std::move.
2076
2077 2019-04-25  Tom Tromey  <tromey@adacore.com>
2078
2079         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2080         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2081         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2082         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2083         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2084         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2085         guile/scm-value.c: Use unpack.
2086         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2087         gdbscm_gdb_exception.
2088         (gdbscm_throw_gdb_exception): Likewise.
2089         (struct gdbscm_gdb_exception): New.
2090         (unpack): New function.
2091         (gdbscm_wrap): Use unpack.
2092
2093 2019-04-25  Tom Tromey  <tromey@adacore.com>
2094
2095         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2096         (gdb_rl_callback_handler): Use std::move.
2097         * common/common-exceptions.h (struct gdb_exception): Add move
2098         assignment operator.
2099         (throw_exception_sjlj): Change "exception" to const reference.
2100         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2101         (throw_exception_sjlj): Change "exception" to const reference.
2102
2103 2019-04-25  Tom Tromey  <tromey@adacore.com>
2104
2105         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2106         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2107         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2108         Update.
2109         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2110         Update.
2111         * mi/mi-interp.c (mi_interp::exec): Update.
2112         * linespec.c (parse_linespec): Update.
2113         * infcall.c (run_inferior_call): Update.
2114         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2115         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2116         (gdbscm_lookup_global_symbol): Update.
2117         * guile/scm-param.c (gdbscm_parameter_value): Update.
2118         * guile/scm-frame.c (gdbscm_frame_read_register)
2119         (gdbscm_frame_read_var): Update.
2120         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2121         * exec.c (try_open_exec_file): Update.
2122         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2123         (gdb_rl_callback_handler): Update.
2124         * common/common-exceptions.h (exception_none): Don't declare.
2125         * common/common-exceptions.c (exception_none): Don't define.
2126         (struct catcher) <exception>: Update.
2127         * cli/cli-interp.c (safe_execute_command): Update.
2128         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2129
2130 2019-04-25  Ali Tamur  <tamur@google.com>
2131
2132         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2133         (read_attribute_value): Likewise.
2134         (dwarf2_read_addr_index): Update comment.
2135         (read_str_index): Add DW_FORM_strx.
2136         (dwarf2_string_attr): Likewise.
2137         (dwarf2_const_value_attr): Likewise.
2138         (dump_die_shallow): Likewise.
2139         (dwarf2_fetch_constant_bytes): Likewise.
2140         (skip_form_bytes): Likewise.
2141         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2142
2143 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2144
2145         PR corefiles/11608
2146         PR corefiles/18187
2147         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2148         OFFSET.  Verify if current mapping contains an ELF header.
2149         (linux_find_memory_regions_full): Adjust call to
2150         dump_mapping_p.
2151
2152 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2153             Kang Li <kanglictf@gmail.com>
2154
2155         PR gdb/21600
2156
2157         * dwarf2-frame.c (read_initial_length): Be consistent about using
2158         unsigned representation of length.
2159         (decode_frame_entry_1): Likewise.  Check for wraparound of
2160         end pointer as well as buffer overflow.
2161
2162 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2163
2164         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2165         "vq".
2166
2167 2019-04-24  Tom Tromey  <tromey@adacore.com>
2168
2169         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2170
2171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2172
2173         * s12z-tdep.c (s12z_unwind_pc): Delete.
2174         (s12z_unwind_sp): Delete.
2175         (s12z_gdbarch_init): Don't register deleted functions with
2176         gdbarch.
2177
2178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * rl78-tdep.c (rl78_unwind_sp): Delete.
2181         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2182
2183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2186         (xstormy16_unwind_pc): Delete.
2187         (xstormy16_dummy_id): Delete.
2188         (xstormy16_gdbarch_init): Don't register deleted functions with
2189         gdbarch.
2190
2191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2192
2193         * vax-tdep.c (vax_unwind_pc): Delete.
2194         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2195
2196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2197
2198         * v850-tdep.c (v850_unwind_sp): Delete.
2199         (v850_unwind_pc): Delete.
2200         (v850_dummy_id): Delete.
2201         (v850_gdbarch_init): Don't register deleted functions with
2202         gdbarch.
2203
2204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2205
2206         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2207         (tilegx_unwind_pc): Delete.
2208         (tilegx_unwind_dummy_id): Delete.
2209         (tilegx_gdbarch_init): Don't register deleted functions with
2210         gdbarch.
2211
2212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2213
2214         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2215         (tic6x_dummy_id): Delete.
2216         (tic6x_gdbarch_init): Don't register deleted functions with
2217         gdbarch.
2218
2219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2220
2221         * sparc-tdep.c (sparc_unwind_pc): Delete.
2222         (sparc32_gdbarch_init): Don't register deleted function with
2223         gdbarch.
2224
2225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2226
2227         * sh-tdep.c (sh_unwind_sp): Delete.
2228         (sh_unwind_pc): Delete.
2229         (sh_dummy_id): Delete.
2230         (sh_gdbarch_init): Don't register deleted functions with
2231         gdbarch.
2232
2233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2234
2235         * score-tdep.c (score_unwind_sp): Delete.
2236         (score_unwind_pc): Delete.
2237         (score_dummy_id): Delete.
2238         (score_gdbarch_init): Don't register deleted functions with
2239         gdbarch.
2240
2241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2242
2243         * rx-tdep.c (rx_unwind_pc): Delete.
2244         (rx_unwind_sp): Delete.
2245         (rx_dummy_id): Delete.
2246         (rx_gdbarch_init): Don't register deleted functions with
2247         gdbarch.  Update comment.
2248
2249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2250
2251         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2252         (rs6000_dummy_id): Delete.
2253         (rs6000_gdbarch_init): Don't register deleted functions with
2254         gdbarch.
2255
2256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2257
2258         * or1k-tdep.c (or1k_dummy_id): Delete.
2259         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2260
2261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * nios2-tdep.c (nios2_dummy_id): Delete.
2264         (nios2_unwind_sp): Delete.
2265         (nios2_gdbarch_init): Don't register deleted functions with
2266         gdbarch.
2267
2268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2269
2270         * nds32-tdep.c (nds32_dummy_id): Delete.
2271         (nds32_unwind_pc): Delete.
2272         (nds32_unwind_sp): Delete.
2273         (nds32_gdbarch_init): Don't register deleted functions with
2274         gdbarch.
2275
2276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2277
2278         * msp430-tdep.c (msp430_unwind_pc): Delete.
2279         (msp430_unwind_sp): Delete.
2280         (msp430_dummy_id): Delete.
2281         (msp430_gdbarch_init): Don't register deleted functions with
2282         gdbarch.
2283
2284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         * moxie-tdep.c (moxie_unwind_sp): Delete.
2287         (moxie_unwind_pc): Delete.
2288         (moxie_dummy_id): Delete.
2289         (moxie_gdbarch_init): Don't register deleted functions with
2290         gdbarch.
2291
2292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2293
2294         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2295         (mn10300_unwind_pc): Delete.
2296         (mn10300_unwind_sp): Delete.
2297         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2298         mn10300_unwind_sp.
2299         (mn10300_frame_unwind_init): Don't register deleted functions with
2300         gdbarch.
2301
2302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2303
2304         * mep-tdep.c (mep_unwind_pc): Delete.
2305         (mep_unwind_sp): Delete.
2306         (mep_dummy_id): Delete.
2307         (mep_gdbarch_init): Don't register deleted functions with
2308         gdbarch.
2309
2310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2311
2312         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2313         (m68hc11_unwind_sp): Delete.
2314         (m68hc11_gdbarch_init): Don't register deleted functions with
2315         gdbarch.
2316
2317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2318
2319         * m32r-tdep.c (m32r_unwind_sp): Delete.
2320         (m32r_unwind_pc): Delete.
2321         (m32r_dummy_id): Delete.
2322         (m32r_gdbarch_init): Don't register deleted functions with
2323         gdbarch.
2324
2325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2326
2327         * m32c-tdep.c (m32c_unwind_pc): Delete.
2328         (m32c_unwind_sp): Delete.
2329         (m32c_dummy_id): Delete.
2330         (m32c_gdbarch_init): Don't register deleted functions with
2331         gdbarch.
2332
2333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2334
2335         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2336         (lm32_unwind_pc): Delete.
2337         (lm32_dummy_id): Delete.
2338         (lm32_gdbarch_init): Don't register deleted functions with
2339         gdbarch.
2340
2341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2342
2343         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2344         (iq2000_unwind_pc): Delete.
2345         (iq2000_dummy_id): Delete.
2346         (iq2000_gdbarch_init): Don't register deleted functions with
2347         gdbarch.
2348
2349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2350
2351         * nds32-tdep.c (nds32_type_align): Delete.
2352         (nds32_push_dummy_call): Use type_align instead.
2353
2354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * arm-tdep.c (arm_type_align): Only handle vector override case.
2357         (arm_push_dummy_call): Use type_align.
2358         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2359
2360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2361
2362         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2363         case.
2364         (pass_on_stack): Use type_align.
2365         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2366         function.
2367
2368 2019-04-23  Tom Tromey  <tromey@adacore.com>
2369
2370         * dwarf2read.c (line_header::file_name_at): Remove unused
2371         overload.
2372
2373 2019-04-23  Tom de Vries  <tdevries@suse.de>
2374
2375         PR gdb/24438
2376         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2377         invocation.
2378
2379
2380 2019-03-27  Ali Tamur  <tamur@google.com>
2381
2382         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2383         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2384         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2385         (dwarf_expr_context::get_addr_index): Likewise
2386         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2387         (symbol_needs_eval_context::get_addr_index): Likewise
2388         (disassemble_dwarf_expression): Add DW_OP_addrx
2389         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2390         (read_cutu_die_from_dwo): Update comment
2391         (skip_one_die): Add DW_FORM_addrx
2392         (read_attribute_value): Likewise
2393         (var_decode_location): Add DW_OP_addrx
2394         (dwarf2_const_value_attr): Add DW_FORM_addrx
2395         (dump_die_shallow): Likewise
2396         (dwarf2_fetch_constant_bytes): Likewise
2397         (decode_locdesc): Add DW_OP_addrx
2398         (skip_form_bytes): Add DW_FORM_addrx
2399
2400 2019-04-22  Ali Tamur  <tamur@google.com>
2401
2402         * MAINTAINERS (Write After Approval): Add self.
2403
2404 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2405
2406         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2407         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2408         (open_symbol_file_object): Likewise.
2409         (svr4_default_sos): Add info parameter.
2410         (svr4_read_so_list): Likewise.
2411         (svr4_current_sos_direct): Adjust functions calls to pass down
2412         info.
2413         (svr4_current_sos_1): Add info parameter.
2414         (svr4_current_sos): Call get_svr4_info, pass info down to
2415         svr4_current_sos_1.
2416         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2417         get_svr4_info.
2418         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2419         get_svr4_info.
2420         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2421         to get_svr4_info.
2422         (probes_table_remove_objfile_probes): Likewise.
2423         (register_solib_event_probe): Add info parameter.
2424         (solist_update_incremental): Pass info parameter down to
2425         svr4_read_so_list.
2426         (disable_probes_interface): Add info parameter.
2427         (svr4_handle_solib_event): Pass current_program_space to
2428         get_svr4_info.  Adjust disable_probes_interface cleanup.
2429         (svr4_create_probe_breakpoints): Add info parameter, pass it
2430         down to register_solib_event_probe.
2431         (svr4_create_solib_event_breakpoints): Add info parameter,
2432         pass it down to svr4_create_probe_breakpoints.
2433         (enable_break): Pass info down to
2434         svr4_create_solib_event_breakpoints.
2435         (svr4_solib_create_inferior_hook): Pass current_program_space to
2436         get_svr4_info.
2437         (svr4_clear_solib): Likewise.
2438
2439 2019-04-22  Pedro Alves  <palves@redhat.com>
2440
2441         * solib-svr4.c (svr4_free_objfile_observer): New.
2442         (probe_and_action::objfile): New field.
2443         (probes_table_htab_remove_objfile_probes)
2444         (probes_table_remove_objfile_probes): New functions.
2445         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2446         in the new probe_and_action.  Don't store the probe in 'lookup'.
2447         (svr4_create_probe_breakpoints): Pass objfile to
2448         register_solib_event_probe.
2449         (_initialize_svr4_solib): Register a free_objfile observer.
2450
2451 2019-04-19  Tom Tromey  <tom@tromey.com>
2452
2453         * common/queue.h: Remove.
2454
2455 2019-04-19  Tom Tromey  <tom@tromey.com>
2456
2457         * event-loop.c: Don't include "common/queue.h".
2458
2459 2019-04-19  Tom Tromey  <tom@tromey.com>
2460
2461         * remote.c (remote_target): Use delete.
2462         * remote-notif.h: Include <list>, not "common/queue.h".
2463         (notif_client_p): Remove typedef.
2464         (remote_notif_state): Add constructor, destructor, initializer.
2465         <notif_queue>: Now a std::list.
2466         (remote_notif_state_xfree): Don't declare.
2467         * remote-notif.c (remote_notif_process, handle_notification)
2468         (remote_notif_state_allocate): Update.
2469         (~remote_notif_state): Rename from remote_notif_state_xfree.
2470
2471 2019-04-19  Tom Tromey  <tom@tromey.com>
2472
2473         * symfile.c (reread_symbols): Update.
2474         * objfiles.c (objfile_register_static_link)
2475         (objfile_lookup_static_link): Update
2476         (~objfile) Don't delete static_links.
2477         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2478
2479 2019-04-19  Tom Tromey  <tom@tromey.com>
2480
2481         * type-stack.h (struct type_stack) <insert>: Constify string.
2482         * type-stack.c (type_stack::insert): Constify string.
2483         * gdbtypes.h (lookup_template_type): Update.
2484         (address_space_name_to_int): Update.
2485         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2486         const.
2487         (lookup_template_type): Make name const.
2488         * c-exp.y: Update rules.
2489         (lex_one_token, classify_name, classify_inner_name)
2490         (c_print_token): Update.
2491         * p-exp.y: Update rules.
2492         (yylex): Update.
2493         * f-exp.y: Update rules.
2494         (yylex): Update.
2495         * d-exp.y: Update rules.
2496         (lex_one_token, classify_name, classify_inner_name): Update.
2497         * parse.c (write_dollar_variable, copy_name): Return std::string.
2498         * parser-defs.h (copy_name): Change return type.
2499         * m2-exp.y: Update rules.
2500         (yylex): Update.
2501         * go-exp.y (lex_one_token): Update.
2502         Update rules.
2503         (classify_unsafe_function, classify_packaged_name)
2504         (classify_name, yylex): Update.
2505
2506 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2507
2508         * configure.ac: add --enable-source-highlight switch.
2509         * configure: Regenerate.
2510         * top.c (print_gdb_version): plumb --enable-source-highlight
2511         status to "show configuration".
2512
2513 2019-04-19  Tom Tromey  <tromey@adacore.com>
2514
2515         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2516         Check ADA_TYPE_P.
2517         (empty_record, ada_template_to_fixed_record_type_1)
2518         (template_to_static_fixed_type)
2519         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2520         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2521         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2522         macros.
2523
2524 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2525
2526         PR symtab/24423:
2527         * source.c (print_source_lines_base): Advance "iter" when a
2528         control character is seen.
2529
2530 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2531
2532         * inferior.h (struct infcall_suspend_state_deleter):
2533         Catch exception in destructor to avoid crash.
2534
2535 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2536
2537         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2538         close to the add_com "shell".
2539
2540 2019-04-18  Tom Tromey  <tromey@adacore.com>
2541
2542         * process-stratum-target.h (class process_stratum_target)
2543         <stratum>: Add "final".
2544
2545 2019-04-17  Tom Tromey  <tromey@adacore.com>
2546
2547         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2548         against nullptr before use.
2549
2550 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2551
2552         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2553
2554 2019-04-17  Jim Wilson  <jimw@sifive.com>
2555             Andrew Burgess  <andrew.burgess@embecosm.com>
2556
2557         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2558         code read might fail, assume 4-byte breakpoint in that case.
2559
2560 2019-04-15  Leszek Swirski  <leszeks@google.com>
2561
2562         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2563         rather than a hand-rolled POD check when checking for forced MEMORY
2564         classification.
2565
2566 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2567
2568         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2569         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2570         function.
2571         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2572         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2573         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2574         declaration.
2575
2576 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2577
2578         * aarch64-linux-nat.c
2579         (aarch64_linux_nat_target::thread_architecture): Add override.
2580         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2581         each VQ.
2582
2583 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2584
2585         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2586
2587 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2588
2589         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2590         target types of size 96-bits, add some additional comments, and
2591         check that the builtin type we found was the correct size.
2592
2593 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2594
2595         * utils.c (prompt_for_continue): Don't restore the styling at the
2596         end, as applied_style has the wrong value.  This fixes styling in
2597         long lists of file names that are interrupted by the "Continue?"
2598         prompt.
2599
2600 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2601
2602         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2603         * c-lang.c (c_language_defn): Likewise.
2604         (cplus_language_defn): Likewise.
2605         (asm_language_defn): Likewise.
2606         (minimal_language_defn): Likewise.
2607         * d-lang.c (d_language_defn): Likewise.
2608         * f-lang.c (f_language_defn): Likewise.
2609         * go-lang.c (go_language_defn): Likewise.
2610         * language.c (unknown_language_defn): Likewise.
2611         (auto_language_defn): Likewise.
2612         * language.h (struct language_defn): Remove la_magic field.
2613         (LANG_MAGIC): Delete.
2614         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2615         * objc-lang.c (objc_language_defn): Likewise.
2616         * opencl-lang.c (opencl_language_defn): Likewise.
2617         * p-lang.c (pascal_language_defn): Likewise.
2618         * rust-lang.c (rust_language_defn): Likewise.
2619
2620 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2621
2622         * riscv-tdep.c (riscv_type_align): New function.
2623         (riscv_type_alignment): Delete.
2624         (riscv_arg_location): Use 'type_align'.
2625         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2626
2627 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2628
2629         * gdbtypes.c (type_align): A struct with no non-static fields also
2630         has alignment of 1.
2631
2632 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2633
2634         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2635         component to 0.
2636         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2637         member.
2638         (riscv_struct_info::analyse): New implementation using new
2639         analyse_inner member function.
2640         (riscv_struct_info::field_offset): New member function.
2641         (riscv_struct_info::m_offsets): New member variable.
2642         (riscv_struct_info::analyse_inner): New private member function,
2643         takes the old implementation of riscv_struct_info::analyse but
2644         extended to track field offsets.
2645         (riscv_call_arg_struct): Update the struct folding special cases
2646         to handle cases where empty C++ structs, which are non-zero
2647         length, are found.
2648         (riscv_arg_location): Initialise the length of each location, a
2649         non-zero length now indicates the location is in use.
2650         (riscv_push_dummy_call): Allow for the first location having a
2651         non-zero offset when setting up arguments.
2652         (riscv_return_value): Likewise, but for return values.
2653
2654 2019-04-11  Tom Tromey  <tromey@adacore.com>
2655
2656         * utils.c (internal_vproblem): Make "msg" const.
2657
2658 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2659
2660         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2661         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2662         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2663         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2664
2665 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2666
2667         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2668         function.
2669         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2670         of amd64_collect_native_gregset.
2671         (amd64_linux_nat_target::store_registers): Likewise.
2672
2673 2019-04-10  Tom Tromey  <tom@tromey.com>
2674
2675         * symtab.c (lookup_global_symbol_from_objfile)
2676         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2677         * objfiles.h (class separate_debug_iterator): New.
2678         (class separate_debug_range): New.
2679         (struct objfile) <separate_debug_objfiles>: New method.
2680         (objfile_separate_debug_iterate): Don't declare.
2681         * objfiles.c (separate_debug_iterator::operator++): Rename from
2682         objfile_separate_debug_iterate.
2683         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2684         iterator.
2685         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2686         iterator.
2687
2688 2019-04-10  Tom Tromey  <tom@tromey.com>
2689
2690         * symfile.c (reread_symbols): Remove old comment.
2691         * objfiles.c (free_all_objfiles): Fix a typo.
2692
2693 2019-04-10  Tom Tromey  <tom@tromey.com>
2694
2695         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2696         * minsyms.c (lookup_minimal_symbol): Use foreach.
2697         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2698         (lookup_minimal_symbol_solib_trampoline): Likewise.
2699         * symfile.c (reread_symbols): Use foreach.
2700
2701 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2702             Tom Tromey  <tromey@adacore.com>
2703
2704         PR rust/24414:
2705         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2706         (rust_lex_int_test): Change "value" to be LONGEST.
2707         (rust_lex_tests): Add test for long integer literal.
2708
2709 2019-04-09  Tom Tromey  <tromey@adacore.com>
2710
2711         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2712         to bool.
2713         (extended_remote_target::attach): Update.
2714         (remote_target::remote_notice_new_inferior): Update.
2715         (remote_target::add_current_inferior_and_thread): Update.
2716         * inferior.c (exit_inferior_1): Use "false".
2717         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2718
2719 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2720
2721         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2722         the "start" command.
2723
2724 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2725
2726         * python/py-inferior.c (infpy_thread_from_thread_handle):
2727         Adjust comments to reflect renaming of thread_from_thread_handle
2728         to thread_from_handle.  Adjust keywords.  Fix type error message.
2729         (inferior_object_methods): Add thread_from_handle.  Retain
2730         thread_from_thread_handle, but mark it as deprecated.
2731
2732 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2733
2734         * gdbthread.h (find_thread_by_handle): Revise declaration.
2735         * thread.c (find_thread_by_handle): Likewise.  Adjust
2736         implementation too.
2737         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2738         support for buffer objects as handles.
2739
2740 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2741
2742         * python/py-infthread.c (thpy_thread_handle): New function.
2743         (thread_object_methods): Register thpy_thread_handle.
2744
2745 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2746
2747         * gdbthread.h (thread_to_thread_handle): Declare.
2748         * thread.c (gdbtypes.h): Include.
2749         (thread_to_thread_handle): New function.
2750
2751         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2752         (target_thread_info_to_thread_handle): Declare.
2753         * target.c (target_thread_info_to_thread_handle): New function.
2754         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2755         * target-delegates.c: Regenerate.
2756
2757         * linux-thread-db.c (class thread_db_target): Add method
2758         thread_info_to_thread_handle.
2759         (thread_db_target::thread_info_to_thread_handle): Define.
2760         * remote.c (class remote_target): Add new method
2761         thread_info_to_thread_handle.
2762         (remote_target::thread_info_to_thread_handle): Define.
2763
2764 2019-04-08  Pedro Alves  <palves@redhat.com>
2765
2766         * common/common-exceptions.c (throw_exception): Don't create
2767         named object to throw; throw directly.
2768         (throw_it): Likewise.  Don't initialize gdb_exception::message
2769         here, with new; pass FMT and AP to the ctor instead.
2770         * common/common-exceptions.h: Include <string>.
2771         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2772         const char *, va_list)): New ctor.  Use std::make_shared.
2773         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2774         errors)): Delete.
2775         (gdb_exception_error::gdb_exception_error(enum errors, const char
2776         *, va_list)): New.
2777         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2778         Add assertion.
2779         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2780         errors)): Delete.
2781         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2782         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2783         Add assertion.
2784
2785 2019-04-08  Tom Tromey  <tom@tromey.com>
2786
2787         * valops.c (value_rtti_indirect_type): Replace throw_exception
2788         with throw.
2789         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2790         with throw.
2791         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2792         throw.
2793         * target.c (target_translate_tls_address): Replace throw_exception
2794         with throw.
2795         * stack.c (frame_apply_command_count): Replace throw_exception
2796         with throw.
2797         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2798         throw.
2799         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2800         with throw.
2801         * rs6000-tdep.c (rs6000_frame_cache)
2802         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2803         * remote.c: Replace throw_exception with throw.
2804         * record-full.c (record_full_message, record_full_wait_1)
2805         (record_full_restore): Replace throw_exception with throw.
2806         * record-btrace.c:
2807         (get_thread_current_frame_id, record_btrace_start_replaying)
2808         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2809         (cmd_record_btrace_start): Replace throw_exception with throw.
2810         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2811         throw.
2812         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2813         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2814         * linespec.c:
2815         (find_linespec_symbols): Replace throw_exception with throw.
2816         * infrun.c (displaced_step_prepare, resume): Replace
2817         throw_exception with throw.
2818         * infcmd.c (post_create_inferior): Replace throw_exception with
2819         throw.
2820         * inf-loop.c (inferior_event_handler): Replace throw_exception
2821         with throw.
2822         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2823         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2824         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2825         (get_prev_frame_always, get_frame_pc_if_available)
2826         (get_frame_address_in_block_if_available, get_frame_language):
2827         Replace throw_exception with throw.
2828         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2829         throw_exception with throw.
2830         * eval.c (fetch_subexp_value, evaluate_var_value)
2831         (evaluate_funcall, evaluate_subexp_standard): Replace
2832         throw_exception with throw.
2833         * dwarf2loc.c (call_site_find_chain)
2834         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2835         Replace throw_exception with throw.
2836         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2837         with throw.
2838         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2839         throw.
2840         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2841         * completer.c (complete_line_internal): Replace throw_exception
2842         with throw.
2843         * compile/compile-object-run.c (compile_object_run): Replace
2844         throw_exception with throw.
2845         * cli/cli-script.c (process_next_line): Replace throw_exception
2846         with throw.
2847         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2848         (btrace_enable, btrace_maint_update_pt_packets): Replace
2849         throw_exception with throw.
2850         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2851         throw_exception with throw.
2852         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2853         throw_exception with throw.
2854         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2855         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2856         * aarch64-tdep.c (aarch64_make_prologue_cache)
2857         (aarch64_make_stub_cache): Replace throw_exception with throw.
2858
2859 2019-04-08  Tom Tromey  <tom@tromey.com>
2860
2861         * common/common-exceptions.c (throw_exception): Rename from
2862         throw_exception_cxx.  Remove old copy.  Make argument const.
2863         (throw_it): Create and throw exception objects directly.
2864         * common/common-exceptions.h (throw_exception): Make argument
2865         const.
2866         (struct gdb_exception_error): Add constructor.
2867         (struct gdb_exception_quit): Add constructor.
2868
2869 2019-04-08  Tom Tromey  <tom@tromey.com>
2870
2871         * common/common-exceptions.h (exception_rethrow): Don't declare.
2872         (TRY_SJLJ): Update comment.
2873         (TRY, CATCH, END_CATCH): Remove.
2874         * common/common-exceptions.c (exception_rethrow): Remove.
2875
2876 2019-04-08  Tom Tromey  <tom@tromey.com>
2877
2878         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2879         Remove.
2880         (gdb_exception_error): Rename from
2881         gdb_exception_RETURN_MASK_ERROR.
2882         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2883         (gdb_quit_bad_alloc): Update.
2884         * aarch64-tdep.c: Update.
2885         * ada-lang.c: Update.
2886         * ada-typeprint.c: Update.
2887         * ada-valprint.c: Update.
2888         * amd64-tdep.c: Update.
2889         * arch-utils.c: Update.
2890         * break-catch-throw.c: Update.
2891         * breakpoint.c: Update.
2892         * btrace.c: Update.
2893         * c-varobj.c: Update.
2894         * cli/cli-cmds.c: Update.
2895         * cli/cli-interp.c: Update.
2896         * cli/cli-script.c: Update.
2897         * common/common-exceptions.c: Update.
2898         * common/new-op.c: Update.
2899         * common/selftest.c: Update.
2900         * compile/compile-c-symbols.c: Update.
2901         * compile/compile-cplus-symbols.c: Update.
2902         * compile/compile-object-load.c: Update.
2903         * compile/compile-object-run.c: Update.
2904         * completer.c: Update.
2905         * corelow.c: Update.
2906         * cp-abi.c: Update.
2907         * cp-support.c: Update.
2908         * cp-valprint.c: Update.
2909         * darwin-nat.c: Update.
2910         * disasm-selftests.c: Update.
2911         * dtrace-probe.c: Update.
2912         * dwarf-index-cache.c: Update.
2913         * dwarf-index-write.c: Update.
2914         * dwarf2-frame-tailcall.c: Update.
2915         * dwarf2-frame.c: Update.
2916         * dwarf2loc.c: Update.
2917         * dwarf2read.c: Update.
2918         * eval.c: Update.
2919         * event-loop.c: Update.
2920         * event-top.c: Update.
2921         * exec.c: Update.
2922         * f-valprint.c: Update.
2923         * fbsd-tdep.c: Update.
2924         * frame-unwind.c: Update.
2925         * frame.c: Update.
2926         * gdbtypes.c: Update.
2927         * gnu-v3-abi.c: Update.
2928         * guile/guile-internal.h: Update.
2929         * guile/scm-block.c: Update.
2930         * guile/scm-breakpoint.c: Update.
2931         * guile/scm-cmd.c: Update.
2932         * guile/scm-disasm.c: Update.
2933         * guile/scm-frame.c: Update.
2934         * guile/scm-lazy-string.c: Update.
2935         * guile/scm-math.c: Update.
2936         * guile/scm-param.c: Update.
2937         * guile/scm-ports.c: Update.
2938         * guile/scm-pretty-print.c: Update.
2939         * guile/scm-symbol.c: Update.
2940         * guile/scm-symtab.c: Update.
2941         * guile/scm-type.c: Update.
2942         * guile/scm-value.c: Update.
2943         * i386-linux-tdep.c: Update.
2944         * i386-tdep.c: Update.
2945         * inf-loop.c: Update.
2946         * infcall.c: Update.
2947         * infcmd.c: Update.
2948         * infrun.c: Update.
2949         * jit.c: Update.
2950         * language.c: Update.
2951         * linespec.c: Update.
2952         * linux-fork.c: Update.
2953         * linux-nat.c: Update.
2954         * linux-tdep.c: Update.
2955         * linux-thread-db.c: Update.
2956         * main.c: Update.
2957         * mi/mi-cmd-break.c: Update.
2958         * mi/mi-cmd-stack.c: Update.
2959         * mi/mi-interp.c: Update.
2960         * mi/mi-main.c: Update.
2961         * objc-lang.c: Update.
2962         * p-valprint.c: Update.
2963         * parse.c: Update.
2964         * ppc-linux-tdep.c: Update.
2965         * printcmd.c: Update.
2966         * python/py-arch.c: Update.
2967         * python/py-breakpoint.c: Update.
2968         * python/py-cmd.c: Update.
2969         * python/py-finishbreakpoint.c: Update.
2970         * python/py-frame.c: Update.
2971         * python/py-framefilter.c: Update.
2972         * python/py-gdb-readline.c: Update.
2973         * python/py-inferior.c: Update.
2974         * python/py-infthread.c: Update.
2975         * python/py-lazy-string.c: Update.
2976         * python/py-linetable.c: Update.
2977         * python/py-objfile.c: Update.
2978         * python/py-param.c: Update.
2979         * python/py-prettyprint.c: Update.
2980         * python/py-progspace.c: Update.
2981         * python/py-record-btrace.c: Update.
2982         * python/py-record.c: Update.
2983         * python/py-symbol.c: Update.
2984         * python/py-type.c: Update.
2985         * python/py-unwind.c: Update.
2986         * python/py-utils.c: Update.
2987         * python/py-value.c: Update.
2988         * python/python.c: Update.
2989         * record-btrace.c: Update.
2990         * record-full.c: Update.
2991         * remote-fileio.c: Update.
2992         * remote.c: Update.
2993         * riscv-tdep.c: Update.
2994         * rs6000-aix-tdep.c: Update.
2995         * rs6000-tdep.c: Update.
2996         * rust-exp.y: Update.
2997         * rust-lang.c: Update.
2998         * s390-tdep.c: Update.
2999         * selftest-arch.c: Update.
3000         * solib-dsbt.c: Update.
3001         * solib-frv.c: Update.
3002         * solib-spu.c: Update.
3003         * solib-svr4.c: Update.
3004         * solib.c: Update.
3005         * sparc64-linux-tdep.c: Update.
3006         * stack.c: Update.
3007         * symfile-mem.c: Update.
3008         * symmisc.c: Update.
3009         * target.c: Update.
3010         * thread.c: Update.
3011         * top.c: Update.
3012         * tracefile-tfile.c: Update.
3013         * tui/tui.c: Update.
3014         * typeprint.c: Update.
3015         * unittests/cli-utils-selftests.c: Update.
3016         * unittests/parse-connection-spec-selftests.c: Update.
3017         * valops.c: Update.
3018         * valprint.c: Update.
3019         * value.c: Update.
3020         * varobj.c: Update.
3021         * windows-nat.c: Update.
3022         * x86-linux-nat.c: Update.
3023         * xml-support.c: Update.
3024
3025 2019-04-08  Tom Tromey  <tom@tromey.com>
3026
3027         * xml-support.c: Use C++ exception handling.
3028         * x86-linux-nat.c: Use C++ exception handling.
3029         * windows-nat.c: Use C++ exception handling.
3030         * varobj.c: Use C++ exception handling.
3031         * value.c: Use C++ exception handling.
3032         * valprint.c: Use C++ exception handling.
3033         * valops.c: Use C++ exception handling.
3034         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3035         handling.
3036         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3037         * typeprint.c: Use C++ exception handling.
3038         * tui/tui.c: Use C++ exception handling.
3039         * tracefile-tfile.c: Use C++ exception handling.
3040         * top.c: Use C++ exception handling.
3041         * thread.c: Use C++ exception handling.
3042         * target.c: Use C++ exception handling.
3043         * symmisc.c: Use C++ exception handling.
3044         * symfile-mem.c: Use C++ exception handling.
3045         * stack.c: Use C++ exception handling.
3046         * sparc64-linux-tdep.c: Use C++ exception handling.
3047         * solib.c: Use C++ exception handling.
3048         * solib-svr4.c: Use C++ exception handling.
3049         * solib-spu.c: Use C++ exception handling.
3050         * solib-frv.c: Use C++ exception handling.
3051         * solib-dsbt.c: Use C++ exception handling.
3052         * selftest-arch.c: Use C++ exception handling.
3053         * s390-tdep.c: Use C++ exception handling.
3054         * rust-lang.c: Use C++ exception handling.
3055         * rust-exp.y: Use C++ exception handling.
3056         * rs6000-tdep.c: Use C++ exception handling.
3057         * rs6000-aix-tdep.c: Use C++ exception handling.
3058         * riscv-tdep.c: Use C++ exception handling.
3059         * remote.c: Use C++ exception handling.
3060         * remote-fileio.c: Use C++ exception handling.
3061         * record-full.c: Use C++ exception handling.
3062         * record-btrace.c: Use C++ exception handling.
3063         * python/python.c: Use C++ exception handling.
3064         * python/py-value.c: Use C++ exception handling.
3065         * python/py-utils.c: Use C++ exception handling.
3066         * python/py-unwind.c: Use C++ exception handling.
3067         * python/py-type.c: Use C++ exception handling.
3068         * python/py-symbol.c: Use C++ exception handling.
3069         * python/py-record.c: Use C++ exception handling.
3070         * python/py-record-btrace.c: Use C++ exception handling.
3071         * python/py-progspace.c: Use C++ exception handling.
3072         * python/py-prettyprint.c: Use C++ exception handling.
3073         * python/py-param.c: Use C++ exception handling.
3074         * python/py-objfile.c: Use C++ exception handling.
3075         * python/py-linetable.c: Use C++ exception handling.
3076         * python/py-lazy-string.c: Use C++ exception handling.
3077         * python/py-infthread.c: Use C++ exception handling.
3078         * python/py-inferior.c: Use C++ exception handling.
3079         * python/py-gdb-readline.c: Use C++ exception handling.
3080         * python/py-framefilter.c: Use C++ exception handling.
3081         * python/py-frame.c: Use C++ exception handling.
3082         * python/py-finishbreakpoint.c: Use C++ exception handling.
3083         * python/py-cmd.c: Use C++ exception handling.
3084         * python/py-breakpoint.c: Use C++ exception handling.
3085         * python/py-arch.c: Use C++ exception handling.
3086         * printcmd.c: Use C++ exception handling.
3087         * ppc-linux-tdep.c: Use C++ exception handling.
3088         * parse.c: Use C++ exception handling.
3089         * p-valprint.c: Use C++ exception handling.
3090         * objc-lang.c: Use C++ exception handling.
3091         * mi/mi-main.c: Use C++ exception handling.
3092         * mi/mi-interp.c: Use C++ exception handling.
3093         * mi/mi-cmd-stack.c: Use C++ exception handling.
3094         * mi/mi-cmd-break.c: Use C++ exception handling.
3095         * main.c: Use C++ exception handling.
3096         * linux-thread-db.c: Use C++ exception handling.
3097         * linux-tdep.c: Use C++ exception handling.
3098         * linux-nat.c: Use C++ exception handling.
3099         * linux-fork.c: Use C++ exception handling.
3100         * linespec.c: Use C++ exception handling.
3101         * language.c: Use C++ exception handling.
3102         * jit.c: Use C++ exception handling.
3103         * infrun.c: Use C++ exception handling.
3104         * infcmd.c: Use C++ exception handling.
3105         * infcall.c: Use C++ exception handling.
3106         * inf-loop.c: Use C++ exception handling.
3107         * i386-tdep.c: Use C++ exception handling.
3108         * i386-linux-tdep.c: Use C++ exception handling.
3109         * guile/scm-value.c: Use C++ exception handling.
3110         * guile/scm-type.c: Use C++ exception handling.
3111         * guile/scm-symtab.c: Use C++ exception handling.
3112         * guile/scm-symbol.c: Use C++ exception handling.
3113         * guile/scm-pretty-print.c: Use C++ exception handling.
3114         * guile/scm-ports.c: Use C++ exception handling.
3115         * guile/scm-param.c: Use C++ exception handling.
3116         * guile/scm-math.c: Use C++ exception handling.
3117         * guile/scm-lazy-string.c: Use C++ exception handling.
3118         * guile/scm-frame.c: Use C++ exception handling.
3119         * guile/scm-disasm.c: Use C++ exception handling.
3120         * guile/scm-cmd.c: Use C++ exception handling.
3121         * guile/scm-breakpoint.c: Use C++ exception handling.
3122         * guile/scm-block.c: Use C++ exception handling.
3123         * guile/guile-internal.h: Use C++ exception handling.
3124         * gnu-v3-abi.c: Use C++ exception handling.
3125         * gdbtypes.c: Use C++ exception handling.
3126         * frame.c: Use C++ exception handling.
3127         * frame-unwind.c: Use C++ exception handling.
3128         * fbsd-tdep.c: Use C++ exception handling.
3129         * f-valprint.c: Use C++ exception handling.
3130         * exec.c: Use C++ exception handling.
3131         * event-top.c: Use C++ exception handling.
3132         * event-loop.c: Use C++ exception handling.
3133         * eval.c: Use C++ exception handling.
3134         * dwarf2read.c: Use C++ exception handling.
3135         * dwarf2loc.c: Use C++ exception handling.
3136         * dwarf2-frame.c: Use C++ exception handling.
3137         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3138         * dwarf-index-write.c: Use C++ exception handling.
3139         * dwarf-index-cache.c: Use C++ exception handling.
3140         * dtrace-probe.c: Use C++ exception handling.
3141         * disasm-selftests.c: Use C++ exception handling.
3142         * darwin-nat.c: Use C++ exception handling.
3143         * cp-valprint.c: Use C++ exception handling.
3144         * cp-support.c: Use C++ exception handling.
3145         * cp-abi.c: Use C++ exception handling.
3146         * corelow.c: Use C++ exception handling.
3147         * completer.c: Use C++ exception handling.
3148         * compile/compile-object-run.c: Use C++ exception handling.
3149         * compile/compile-object-load.c: Use C++ exception handling.
3150         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3151         * compile/compile-c-symbols.c: Use C++ exception handling.
3152         * common/selftest.c: Use C++ exception handling.
3153         * common/new-op.c: Use C++ exception handling.
3154         * cli/cli-script.c: Use C++ exception handling.
3155         * cli/cli-interp.c: Use C++ exception handling.
3156         * cli/cli-cmds.c: Use C++ exception handling.
3157         * c-varobj.c: Use C++ exception handling.
3158         * btrace.c: Use C++ exception handling.
3159         * breakpoint.c: Use C++ exception handling.
3160         * break-catch-throw.c: Use C++ exception handling.
3161         * arch-utils.c: Use C++ exception handling.
3162         * amd64-tdep.c: Use C++ exception handling.
3163         * ada-valprint.c: Use C++ exception handling.
3164         * ada-typeprint.c: Use C++ exception handling.
3165         * ada-lang.c: Use C++ exception handling.
3166         * aarch64-tdep.c: Use C++ exception handling.
3167
3168 2019-04-08  Tom Tromey  <tom@tromey.com>
3169
3170         * xml-support.c (gdb_xml_parser::parse): Update.
3171         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3172         * value.c (show_convenience): Update.
3173         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3174         (test_parse_flags_qcs): Update.
3175         * thread.c (thr_try_catch_cmd): Update.
3176         * target.c (target_translate_tls_address): Update.
3177         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3178         (info_frame_command_core, frame_apply_command_count): Update.
3179         * rust-exp.y (rust_lex_exception_test): Update.
3180         * riscv-tdep.c (riscv_print_one_register_info): Update.
3181         * remote.c (remote_target::enable_btrace): Update.
3182         * record-btrace.c (record_btrace_enable_warn): Update.
3183         * python/py-utils.c (gdbpy_convert_exception): Update.
3184         * printcmd.c (do_one_display, print_variable_and_value): Update.
3185         * mi/mi-main.c (mi_print_exception): Update.
3186         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3187         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3188         * linux-nat.c (linux_nat_target::attach): Update.
3189         * linux-fork.c (class scoped_switch_fork_info): Update.
3190         * infrun.c (displaced_step_prepare): Update.
3191         * infcall.c (call_function_by_hand_dummy): Update.
3192         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3193         * gnu-v3-abi.c (print_one_vtable): Update.
3194         * frame.c (get_prev_frame_always): Update.
3195         * f-valprint.c (info_common_command_for_block): Update.
3196         * exec.c (try_open_exec_file): Update.
3197         * exceptions.c (print_exception, exception_print)
3198         (exception_fprintf, exception_print_same): Update.
3199         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3200         * dwarf-index-cache.c (index_cache::store)
3201         (index_cache::lookup_gdb_index): Update.
3202         * darwin-nat.c (maybe_cache_shell): Update.
3203         * cp-valprint.c (cp_print_value_fields): Update.
3204         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3205         (gcc_cplus_symbol_address): Update.
3206         * compile/compile-c-symbols.c (gcc_convert_symbol)
3207         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3208         * common/selftest.c: Update.
3209         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3210         a std::string.
3211         (exception_try_scope_entry, exception_try_scope_exit): Don't
3212         declare.
3213         (struct exception_try_scope): Remove.
3214         (TRY): Don't use exception_try_scope.
3215         (struct gdb_exception): Add constructor, operator=.
3216         <what>: New method.
3217         (struct gdb_exception_RETURN_MASK_ALL)
3218         (struct gdb_exception_RETURN_MASK_ERROR)
3219         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3220         (struct gdb_quit_bad_alloc): Update.
3221         * common/common-exceptions.c (exception_none): Change
3222         initializer.
3223         (struct catcher) <state, exception>: Initialize inline.
3224         <prev>: Remove member.
3225         (current_catcher): Remove.
3226         (catchers): New global.
3227         (exceptions_state_mc_init): Simplify.
3228         (catcher_pop): Remove.
3229         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3230         (try_scope_depth, exception_try_scope_entry)
3231         (exception_try_scope_exit): Remove.
3232         (throw_exception_sjlj): Update.
3233         (exception_messages, exception_messages_size): Remove.
3234         (throw_it): Simplify.
3235         (gdb_exception_sliced_copy): Remove.
3236         (throw_exception_cxx): Update.
3237         * cli/cli-script.c (script_from_file): Update.
3238         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3239         Update.
3240         * ada-valprint.c (ada_val_print): Update.
3241         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3242         (create_excep_cond_exprs): Update.
3243
3244 2019-04-08  Tom Tromey  <tom@tromey.com>
3245
3246         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3247         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3248         (TRY, CATCH, END_CATCH): Remove some definitions.
3249         * common/common-exceptions.c: Don't use GDB_XCPT.
3250         (catcher_list_size): Remove.
3251         (throw_exception, throw_it): Simplify.
3252
3253 2019-04-05  Tom Tromey  <tom@tromey.com>
3254
3255         Revert the header-sorting patch.
3256         * ft32-tdep.c: Revert.
3257         * frv-tdep.c: Revert.
3258         * frv-linux-tdep.c: Revert.
3259         * frame.c: Revert.
3260         * frame-unwind.c: Revert.
3261         * frame-base.c: Revert.
3262         * fork-child.c: Revert.
3263         * findvar.c: Revert.
3264         * findcmd.c: Revert.
3265         * filesystem.c: Revert.
3266         * filename-seen-cache.h: Revert.
3267         * filename-seen-cache.c: Revert.
3268         * fbsd-tdep.c: Revert.
3269         * fbsd-nat.h: Revert.
3270         * fbsd-nat.c: Revert.
3271         * f-valprint.c: Revert.
3272         * f-typeprint.c: Revert.
3273         * f-lang.c: Revert.
3274         * extension.h: Revert.
3275         * extension.c: Revert.
3276         * extension-priv.h: Revert.
3277         * expprint.c: Revert.
3278         * exec.h: Revert.
3279         * exec.c: Revert.
3280         * exceptions.c: Revert.
3281         * event-top.c: Revert.
3282         * event-loop.c: Revert.
3283         * eval.c: Revert.
3284         * elfread.c: Revert.
3285         * dwarf2read.h: Revert.
3286         * dwarf2read.c: Revert.
3287         * dwarf2loc.c: Revert.
3288         * dwarf2expr.h: Revert.
3289         * dwarf2expr.c: Revert.
3290         * dwarf2-frame.c: Revert.
3291         * dwarf2-frame-tailcall.c: Revert.
3292         * dwarf-index-write.h: Revert.
3293         * dwarf-index-write.c: Revert.
3294         * dwarf-index-common.c: Revert.
3295         * dwarf-index-cache.h: Revert.
3296         * dwarf-index-cache.c: Revert.
3297         * dummy-frame.c: Revert.
3298         * dtrace-probe.c: Revert.
3299         * disasm.h: Revert.
3300         * disasm.c: Revert.
3301         * disasm-selftests.c: Revert.
3302         * dictionary.c: Revert.
3303         * dicos-tdep.c: Revert.
3304         * demangle.c: Revert.
3305         * dcache.h: Revert.
3306         * dcache.c: Revert.
3307         * darwin-nat.h: Revert.
3308         * darwin-nat.c: Revert.
3309         * darwin-nat-info.c: Revert.
3310         * d-valprint.c: Revert.
3311         * d-namespace.c: Revert.
3312         * d-lang.c: Revert.
3313         * ctf.c: Revert.
3314         * csky-tdep.c: Revert.
3315         * csky-linux-tdep.c: Revert.
3316         * cris-tdep.c: Revert.
3317         * cris-linux-tdep.c: Revert.
3318         * cp-valprint.c: Revert.
3319         * cp-support.c: Revert.
3320         * cp-namespace.c: Revert.
3321         * cp-abi.c: Revert.
3322         * corelow.c: Revert.
3323         * corefile.c: Revert.
3324         * continuations.c: Revert.
3325         * completer.h: Revert.
3326         * completer.c: Revert.
3327         * complaints.c: Revert.
3328         * coffread.c: Revert.
3329         * coff-pe-read.c: Revert.
3330         * cli-out.h: Revert.
3331         * cli-out.c: Revert.
3332         * charset.c: Revert.
3333         * c-varobj.c: Revert.
3334         * c-valprint.c: Revert.
3335         * c-typeprint.c: Revert.
3336         * c-lang.c: Revert.
3337         * buildsym.c: Revert.
3338         * buildsym-legacy.c: Revert.
3339         * build-id.h: Revert.
3340         * build-id.c: Revert.
3341         * btrace.c: Revert.
3342         * bsd-uthread.c: Revert.
3343         * breakpoint.h: Revert.
3344         * breakpoint.c: Revert.
3345         * break-catch-throw.c: Revert.
3346         * break-catch-syscall.c: Revert.
3347         * break-catch-sig.c: Revert.
3348         * blockframe.c: Revert.
3349         * block.c: Revert.
3350         * bfin-tdep.c: Revert.
3351         * bfin-linux-tdep.c: Revert.
3352         * bfd-target.c: Revert.
3353         * bcache.c: Revert.
3354         * ax-general.c: Revert.
3355         * ax-gdb.h: Revert.
3356         * ax-gdb.c: Revert.
3357         * avr-tdep.c: Revert.
3358         * auxv.c: Revert.
3359         * auto-load.c: Revert.
3360         * arm-wince-tdep.c: Revert.
3361         * arm-tdep.c: Revert.
3362         * arm-symbian-tdep.c: Revert.
3363         * arm-pikeos-tdep.c: Revert.
3364         * arm-obsd-tdep.c: Revert.
3365         * arm-nbsd-tdep.c: Revert.
3366         * arm-nbsd-nat.c: Revert.
3367         * arm-linux-tdep.c: Revert.
3368         * arm-linux-nat.c: Revert.
3369         * arm-fbsd-tdep.c: Revert.
3370         * arm-fbsd-nat.c: Revert.
3371         * arm-bsd-tdep.c: Revert.
3372         * arch-utils.c: Revert.
3373         * arc-tdep.c: Revert.
3374         * arc-newlib-tdep.c: Revert.
3375         * annotate.h: Revert.
3376         * annotate.c: Revert.
3377         * amd64-windows-tdep.c: Revert.
3378         * amd64-windows-nat.c: Revert.
3379         * amd64-tdep.c: Revert.
3380         * amd64-sol2-tdep.c: Revert.
3381         * amd64-obsd-tdep.c: Revert.
3382         * amd64-obsd-nat.c: Revert.
3383         * amd64-nbsd-tdep.c: Revert.
3384         * amd64-nbsd-nat.c: Revert.
3385         * amd64-nat.c: Revert.
3386         * amd64-linux-tdep.c: Revert.
3387         * amd64-linux-nat.c: Revert.
3388         * amd64-fbsd-tdep.c: Revert.
3389         * amd64-fbsd-nat.c: Revert.
3390         * amd64-dicos-tdep.c: Revert.
3391         * amd64-darwin-tdep.c: Revert.
3392         * amd64-bsd-nat.c: Revert.
3393         * alpha-tdep.c: Revert.
3394         * alpha-obsd-tdep.c: Revert.
3395         * alpha-nbsd-tdep.c: Revert.
3396         * alpha-mdebug-tdep.c: Revert.
3397         * alpha-linux-tdep.c: Revert.
3398         * alpha-linux-nat.c: Revert.
3399         * alpha-bsd-tdep.c: Revert.
3400         * alpha-bsd-nat.c: Revert.
3401         * aix-thread.c: Revert.
3402         * agent.c: Revert.
3403         * addrmap.c: Revert.
3404         * ada-varobj.c: Revert.
3405         * ada-valprint.c: Revert.
3406         * ada-typeprint.c: Revert.
3407         * ada-tasks.c: Revert.
3408         * ada-lang.c: Revert.
3409         * aarch64-tdep.c: Revert.
3410         * aarch64-ravenscar-thread.c: Revert.
3411         * aarch64-newlib-tdep.c: Revert.
3412         * aarch64-linux-tdep.c: Revert.
3413         * aarch64-linux-nat.c: Revert.
3414         * aarch64-fbsd-tdep.c: Revert.
3415         * aarch64-fbsd-nat.c: Revert.
3416         * aarch32-linux-nat.c: Revert.
3417
3418 2019-04-05  Tom Tromey  <tom@tromey.com>
3419
3420         * ft32-tdep.c: Sort headers.
3421         * frv-tdep.c: Sort headers.
3422         * frv-linux-tdep.c: Sort headers.
3423         * frame.c: Sort headers.
3424         * frame-unwind.c: Sort headers.
3425         * frame-base.c: Sort headers.
3426         * fork-child.c: Sort headers.
3427         * findvar.c: Sort headers.
3428         * findcmd.c: Sort headers.
3429         * filesystem.c: Sort headers.
3430         * filename-seen-cache.h: Sort headers.
3431         * filename-seen-cache.c: Sort headers.
3432         * fbsd-tdep.c: Sort headers.
3433         * fbsd-nat.h: Sort headers.
3434         * fbsd-nat.c: Sort headers.
3435         * f-valprint.c: Sort headers.
3436         * f-typeprint.c: Sort headers.
3437         * f-lang.c: Sort headers.
3438         * extension.h: Sort headers.
3439         * extension.c: Sort headers.
3440         * extension-priv.h: Sort headers.
3441         * expprint.c: Sort headers.
3442         * exec.h: Sort headers.
3443         * exec.c: Sort headers.
3444         * exceptions.c: Sort headers.
3445         * event-top.c: Sort headers.
3446         * event-loop.c: Sort headers.
3447         * eval.c: Sort headers.
3448         * elfread.c: Sort headers.
3449         * dwarf2read.h: Sort headers.
3450         * dwarf2read.c: Sort headers.
3451         * dwarf2loc.c: Sort headers.
3452         * dwarf2expr.h: Sort headers.
3453         * dwarf2expr.c: Sort headers.
3454         * dwarf2-frame.c: Sort headers.
3455         * dwarf2-frame-tailcall.c: Sort headers.
3456         * dwarf-index-write.h: Sort headers.
3457         * dwarf-index-write.c: Sort headers.
3458         * dwarf-index-common.c: Sort headers.
3459         * dwarf-index-cache.h: Sort headers.
3460         * dwarf-index-cache.c: Sort headers.
3461         * dummy-frame.c: Sort headers.
3462         * dtrace-probe.c: Sort headers.
3463         * disasm.h: Sort headers.
3464         * disasm.c: Sort headers.
3465         * disasm-selftests.c: Sort headers.
3466         * dictionary.c: Sort headers.
3467         * dicos-tdep.c: Sort headers.
3468         * demangle.c: Sort headers.
3469         * dcache.h: Sort headers.
3470         * dcache.c: Sort headers.
3471         * darwin-nat.h: Sort headers.
3472         * darwin-nat.c: Sort headers.
3473         * darwin-nat-info.c: Sort headers.
3474         * d-valprint.c: Sort headers.
3475         * d-namespace.c: Sort headers.
3476         * d-lang.c: Sort headers.
3477         * ctf.c: Sort headers.
3478         * csky-tdep.c: Sort headers.
3479         * csky-linux-tdep.c: Sort headers.
3480         * cris-tdep.c: Sort headers.
3481         * cris-linux-tdep.c: Sort headers.
3482         * cp-valprint.c: Sort headers.
3483         * cp-support.c: Sort headers.
3484         * cp-namespace.c: Sort headers.
3485         * cp-abi.c: Sort headers.
3486         * corelow.c: Sort headers.
3487         * corefile.c: Sort headers.
3488         * continuations.c: Sort headers.
3489         * completer.h: Sort headers.
3490         * completer.c: Sort headers.
3491         * complaints.c: Sort headers.
3492         * coffread.c: Sort headers.
3493         * coff-pe-read.c: Sort headers.
3494         * cli-out.h: Sort headers.
3495         * cli-out.c: Sort headers.
3496         * charset.c: Sort headers.
3497         * c-varobj.c: Sort headers.
3498         * c-valprint.c: Sort headers.
3499         * c-typeprint.c: Sort headers.
3500         * c-lang.c: Sort headers.
3501         * buildsym.c: Sort headers.
3502         * buildsym-legacy.c: Sort headers.
3503         * build-id.h: Sort headers.
3504         * build-id.c: Sort headers.
3505         * btrace.c: Sort headers.
3506         * bsd-uthread.c: Sort headers.
3507         * breakpoint.h: Sort headers.
3508         * breakpoint.c: Sort headers.
3509         * break-catch-throw.c: Sort headers.
3510         * break-catch-syscall.c: Sort headers.
3511         * break-catch-sig.c: Sort headers.
3512         * blockframe.c: Sort headers.
3513         * block.c: Sort headers.
3514         * bfin-tdep.c: Sort headers.
3515         * bfin-linux-tdep.c: Sort headers.
3516         * bfd-target.c: Sort headers.
3517         * bcache.c: Sort headers.
3518         * ax-general.c: Sort headers.
3519         * ax-gdb.h: Sort headers.
3520         * ax-gdb.c: Sort headers.
3521         * avr-tdep.c: Sort headers.
3522         * auxv.c: Sort headers.
3523         * auto-load.c: Sort headers.
3524         * arm-wince-tdep.c: Sort headers.
3525         * arm-tdep.c: Sort headers.
3526         * arm-symbian-tdep.c: Sort headers.
3527         * arm-pikeos-tdep.c: Sort headers.
3528         * arm-obsd-tdep.c: Sort headers.
3529         * arm-nbsd-tdep.c: Sort headers.
3530         * arm-nbsd-nat.c: Sort headers.
3531         * arm-linux-tdep.c: Sort headers.
3532         * arm-linux-nat.c: Sort headers.
3533         * arm-fbsd-tdep.c: Sort headers.
3534         * arm-fbsd-nat.c: Sort headers.
3535         * arm-bsd-tdep.c: Sort headers.
3536         * arch-utils.c: Sort headers.
3537         * arc-tdep.c: Sort headers.
3538         * arc-newlib-tdep.c: Sort headers.
3539         * annotate.h: Sort headers.
3540         * annotate.c: Sort headers.
3541         * amd64-windows-tdep.c: Sort headers.
3542         * amd64-windows-nat.c: Sort headers.
3543         * amd64-tdep.c: Sort headers.
3544         * amd64-sol2-tdep.c: Sort headers.
3545         * amd64-obsd-tdep.c: Sort headers.
3546         * amd64-obsd-nat.c: Sort headers.
3547         * amd64-nbsd-tdep.c: Sort headers.
3548         * amd64-nbsd-nat.c: Sort headers.
3549         * amd64-nat.c: Sort headers.
3550         * amd64-linux-tdep.c: Sort headers.
3551         * amd64-linux-nat.c: Sort headers.
3552         * amd64-fbsd-tdep.c: Sort headers.
3553         * amd64-fbsd-nat.c: Sort headers.
3554         * amd64-dicos-tdep.c: Sort headers.
3555         * amd64-darwin-tdep.c: Sort headers.
3556         * amd64-bsd-nat.c: Sort headers.
3557         * alpha-tdep.c: Sort headers.
3558         * alpha-obsd-tdep.c: Sort headers.
3559         * alpha-nbsd-tdep.c: Sort headers.
3560         * alpha-mdebug-tdep.c: Sort headers.
3561         * alpha-linux-tdep.c: Sort headers.
3562         * alpha-linux-nat.c: Sort headers.
3563         * alpha-bsd-tdep.c: Sort headers.
3564         * alpha-bsd-nat.c: Sort headers.
3565         * aix-thread.c: Sort headers.
3566         * agent.c: Sort headers.
3567         * addrmap.c: Sort headers.
3568         * ada-varobj.c: Sort headers.
3569         * ada-valprint.c: Sort headers.
3570         * ada-typeprint.c: Sort headers.
3571         * ada-tasks.c: Sort headers.
3572         * ada-lang.c: Sort headers.
3573         * aarch64-tdep.c: Sort headers.
3574         * aarch64-ravenscar-thread.c: Sort headers.
3575         * aarch64-newlib-tdep.c: Sort headers.
3576         * aarch64-linux-tdep.c: Sort headers.
3577         * aarch64-linux-nat.c: Sort headers.
3578         * aarch64-fbsd-tdep.c: Sort headers.
3579         * aarch64-fbsd-nat.c: Sort headers.
3580         * aarch32-linux-nat.c: Sort headers.
3581
3582 2019-04-04  Tom Tromey  <tom@tromey.com>
3583
3584         * varobj.c (varobj_create): Update.
3585         * rust-exp.y (struct rust_parser) <update_innermost_block,
3586         lookup_symbol>: New methods.
3587         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3588         Rename.
3589         (rust_parser::rust_lookup_type)
3590         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3591         * printcmd.c (display_command, do_one_display): Update.
3592         * parser-defs.h (struct parser_state) <parser_state>: Add
3593         "tracker" parameter.
3594         (block_tracker): New member.
3595         (class innermost_block_tracker) <innermost_block_tracker>: Add
3596         "types" parameter.
3597         <reset>: Remove method.
3598         (innermost_block): Don't declare.
3599         (null_post_parser): Update.
3600         * parse.c (innermost_block): Remove global.
3601         (write_dollar_variable): Update.
3602         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3603         Remove "tracker_types" parameter.
3604         (parse_expression): Add "tracker" parameter.
3605         (parse_expression_for_completion): Update.
3606         (null_post_parser): Add "tracker" parameter.
3607         * p-exp.y: Update rules.
3608         * m2-exp.y: Update rules.
3609         * language.h (struct language_defn) <la_post_parser>: Add
3610         "tracker" parameter.
3611         * go-exp.y: Update rules.
3612         * f-exp.y: Update rules.
3613         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3614         parameter.
3615         * d-exp.y: Update rules.
3616         * c-exp.y: Update rules.
3617         * breakpoint.c (set_breakpoint_condition): Create an
3618         innermost_block_tracker.
3619         (watch_command_1): Likewise.
3620         * ada-lang.c (resolve): Add "tracker" parameter.
3621         (resolve_subexp): Likewise.
3622         * ada-exp.y (write_var_from_sym): Update.
3623
3624 2019-04-04  Tom Tromey  <tom@tromey.com>
3625
3626         * type-stack.h: New file.
3627         * type-stack.c: New file.
3628         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3629         type-stack.h.
3630         (insert_into_type_stack, insert_type, push_type, push_type_int)
3631         (insert_type_address_space, pop_type, pop_type_int)
3632         (pop_typelist, pop_type_stack, append_type_stack)
3633         (push_type_stack, get_type_stack, push_typelist)
3634         (follow_type_instance_flags, follow_types): Don't declare.
3635         * parse.c (type_stack): Remove global.
3636         (parse_exp_in_context): Update.
3637         (insert_into_type_stack, insert_type, push_type, push_type_int)
3638         (insert_type_address_space, pop_type, pop_type_int)
3639         (pop_typelist, pop_type_stack, append_type_stack)
3640         (push_type_stack, get_type_stack, push_typelist)
3641         (follow_type_instance_flags, follow_types): Remove (moved to
3642         type-stack.c).
3643         * f-exp.y (type_stack): New global.
3644         Update rules.
3645         (push_kind_type, f_parse): Update.
3646         * d-exp.y (type_stack): New global.
3647         Update rules.
3648         (d_parse): Update.
3649         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3650         Update rules.
3651         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3652         (HFILES_NO_SRCDIR): Add type-stack.h.
3653
3654 2019-04-04  Tom Tromey  <tom@tromey.com>
3655
3656         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3657         (rust_parser::convert_ast_to_expression, rust_parse)
3658         (rust_lex_test_completion, rust_lex_tests): Update.
3659         * parser-defs.h (struct expr_completion_state): New.
3660         (struct parser_state) <parser_state>: Add completion parameter.
3661         <mark_struct_expression, mark_completion_tag>: New methods.
3662         <parse_completion, m_completion_state>: New members.
3663         (prefixify_expression, null_post_parser): Update.
3664         (mark_struct_expression, mark_completion_tag): Don't declare.
3665         * parse.c (parse_completion, expout_last_struct)
3666         (expout_tag_completion_type, expout_completion_name): Remove
3667         globals.
3668         (parser_state::mark_struct_expression)
3669         (parser_state::mark_completion_tag): Now methods.
3670         (prefixify_expression): Add last_struct parameter.
3671         (prefixify_subexp): Likewise.
3672         (parse_exp_1): Update.
3673         (parse_exp_in_context): Add cstate parameter.  Update.
3674         (parse_expression_for_completion): Create an
3675         expr_completion_state.
3676         (null_post_parser): Add "completion" parameter.
3677         * p-exp.y: Update rules.
3678         (yylex): Update.
3679         * language.h (struct language_defn) <la_post_parser>: Add
3680         "completing" parameter.
3681         * go-exp.y: Update rules.
3682         (lex_one_token): Update.
3683         * expression.h (parse_completion): Don't declare.
3684         * d-exp.y: Update rules.
3685         (lex_one_token): Update rules.
3686         * c-exp.y: Update rules.
3687         (lex_one_token): Update.
3688         * ada-lang.c (resolve): Add "parse_completion" parameter.
3689         (resolve_subexp): Likewise.
3690         (ada_resolve_function): Likewise.
3691
3692 2019-04-04  Tom Tromey  <tom@tromey.com>
3693
3694         * parser-defs.h (struct parser_state) <start_arglist,
3695         end_arglist>: New methods.
3696         <arglist_len, m_funcall_chain>: New members.
3697         (arglist_len, start_arglist, end_arglist): Don't declare.
3698         * parse.c (arglist_len, funcall_chain): Remove global.
3699         (start_arglist, end_arglist): Remove functions.
3700         (parse_exp_in_context): Update.
3701         * p-exp.y: Update rules.
3702         * m2-exp.y: Update rules.
3703         * go-exp.y: Update rules.
3704         * f-exp.y: Update rules.
3705         * d-exp.y: Update rules.
3706         * c-exp.y: Update rules.
3707
3708 2019-04-04  Tom Tromey  <tom@tromey.com>
3709
3710         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3711         lex_operator, push_back>: New methods.
3712         Update all rules.
3713         (rust_parser::lex_hex, lex_escape): Rename and update.
3714         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3715         (rust_parser::lex_operator): Rename and update.
3716         (rust_parser::lex_number, rustyylex, rustyyerror)
3717         (rust_lex_test_init, rust_lex_test_sequence)
3718         (rust_lex_test_push_back, rust_lex_tests): Update.
3719         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3720         parameter.
3721         <lexptr, prev_lexptr>: New members.
3722         (lexptr, prev_lexptr): Don't declare.
3723         * parse.c (lexptr, prev_lexptr): Remove globals.
3724         (parse_exp_in_context): Update.
3725         * p-exp.y (yylex, yyerror): Update.
3726         * m2-exp.y (parse_number, yylex, yyerror): Update.
3727         * go-exp.y (lex_one_token, yyerror): Update.
3728         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3729         * d-exp.y (lex_one_token, yyerror): Update.
3730         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3731         (lex_one_token, yyerror): Update.
3732         * ada-lex.l (YY_INPUT): Update.
3733         (rewind_to_char): Update.
3734         * ada-exp.y (yyerror): Update.
3735
3736 2019-04-04  Tom Tromey  <tom@tromey.com>
3737
3738         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3739         * parser-defs.h (struct parser_state) <parser_state>: Add new
3740         parameter.
3741         <comma_terminates>: New member.
3742         (comma_terminates): Don't declare global.
3743         * parse.c (comma_terminates): Remove global.
3744         (parse_exp_in_context): Update.
3745         * p-exp.y (yylex): Update.
3746         * m2-exp.y (yylex): Update.
3747         * go-exp.y (lex_one_token): Update.
3748         * f-exp.y (yylex): Update.
3749         * d-exp.y (lex_one_token): Update.
3750         * c-exp.y (lex_one_token): Update.
3751         * ada-lex.l: Update.
3752
3753 2019-04-04  Tom Tromey  <tom@tromey.com>
3754
3755         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3756         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3757         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3758         * parser-defs.h (paren_depth): Don't declare.
3759         * parse.c (paren_depth): Remove global.
3760         (parse_exp_in_context): Update.
3761         * p-exp.y (paren_depth): New global.
3762         (pascal_parse): Initialize it.
3763         * m2-exp.y (paren_depth): New global.
3764         (m2_parse): Initialize it.
3765         * go-exp.y (paren_depth): New global.
3766         (go_parse): Initialize it.
3767         * f-exp.y (paren_depth): New global.
3768         (f_parse): Initialize it.
3769         * d-exp.y (paren_depth): New global.
3770         (d_parse): Initialize it.
3771         * c-exp.y (paren_depth): New global.
3772         (c_parse): Initialize it.
3773         * ada-lex.l (paren_depth): New global.
3774         (lexer_init): Initialize it.
3775
3776 2019-04-04  Tom Tromey  <tom@tromey.com>
3777
3778         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3779         (rust_parser::convert_ast_to_type)
3780         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3781         * parser-defs.h (struct parser_state) <parser_state>: Add
3782         parameters.  Initialize new members.
3783         <expression_context_block, expression_context_pc>: New members.
3784         * parse.c (expression_context_block, expression_context_pc):
3785         Remove globals.
3786         (parse_exp_in_context): Update.
3787         * p-exp.y: Update all rules.
3788         (yylex): Update.
3789         * m2-exp.y: Update all rules.
3790         (yylex): Update.
3791         * go-exp.y (yylex): Update.
3792         * f-exp.y (yylex): Update.
3793         * d-exp.y: Update all rules.
3794         (yylex): Update.
3795         * c-exp.y: Update all rules.
3796         (lex_one_token, classify_name, yylex, c_parse): Update.
3797         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3798
3799 2019-04-04  Tom Tromey  <tom@tromey.com>
3800
3801         * gdbarch.h, gdbarch.c: Rebuild.
3802         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3803         * stap-probe.h:
3804         (struct stap_parse_info): Replace "parser_state" with
3805         "expr_builder".
3806         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3807         (parser_state): New class.
3808         * parse.c (expr_builder): Rename.
3809         (expr_builder::release): Rename.
3810         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3811         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3812         (write_exp_elt_longcst, write_exp_elt_floatcst)
3813         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3814         (write_exp_string_vector, write_exp_bitstring)
3815         (write_exp_msymbol, mark_struct_expression)
3816         (write_dollar_variable)
3817         (insert_type_address_space, increase_expout_size): Replace
3818         "parser_state" with "expr_builder".
3819         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3820         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3821         "parser_state" with "expr_builder".
3822
3823 2019-04-04  Tom Tromey  <tom@tromey.com>
3824
3825         * rust-exp.y: Replace "parse_language" with method call.
3826         * p-exp.y:
3827         (yylex): Replace "parse_language" with method call.
3828         * m2-exp.y:
3829         (yylex): Replace "parse_language" with method call.
3830         * go-exp.y (classify_name): Replace "parse_language" with method
3831         call.
3832         * f-exp.y (yylex): Replace "parse_language" with method call.
3833         * d-exp.y (lex_one_token): Replace "parse_language" with method
3834         call.
3835         * c-exp.y:
3836         (lex_one_token, classify_name, yylex): Replace "parse_language"
3837         with method call.
3838         * ada-exp.y (find_primitive_type, type_char)
3839         (type_system_address): Replace "parse_language" with method call.
3840
3841 2019-04-04  Tom Tromey  <tom@tromey.com>
3842
3843         * rust-exp.y: Replace "parse_gdbarch" with method call.
3844         * parse.c (write_dollar_variable, insert_type_address_space):
3845         Replace "parse_gdbarch" with method call.
3846         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3847         call.
3848         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3849         call.
3850         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3851         "parse_gdbarch" with method call.
3852         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3853         with method call.
3854         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3855         "parse_gdbarch" with method call.
3856         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3857         "parse_gdbarch" with method call.
3858         * c-exp.y (parse_type, parse_number, classify_name): Replace
3859         "parse_gdbarch" with method call.
3860         * ada-lex.l: Replace "parse_gdbarch" with method call.
3861         * ada-exp.y (parse_type, find_primitive_type, type_char)
3862         (type_system_address): Replace "parse_gdbarch" with method call.
3863
3864 2019-04-04  Tom Tromey  <tom@tromey.com>
3865
3866         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3867         * stap-probe.c (stap_parse_argument): Update.
3868         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3869         initial_size parameter.
3870         * rust-exp.y (rust_lex_tests): Update.
3871         * parse.c (parser_state): Update.
3872         (parse_exp_in_context): Update.
3873         * parser-defs.h (struct parser_state) <parser_state>: Remove
3874         "initial_size" parameter.
3875
3876 2019-04-04  Tom Tromey  <tom@tromey.com>
3877
3878         * parser-defs.h (increase_expout_size): Don't declare.
3879         * parse.c (increase_expout_size): Now static.
3880
3881 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3882
3883         * gnu-nat.c (gnu_nat_target::wait): Fix
3884         target_waitstatus_to_string call.
3885
3886 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3887
3888         * eval.c (evaluate_subexp_standard): Handle internal functions
3889         during Fortran function call handling.
3890
3891 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * NEWS: Mention new internal functions.
3894         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3895         (read_base_type): Use dwarf2_init_complex_target_type.
3896         * value.c (creal_internal_fn): New function.
3897         (cimag_internal_fn): New function.
3898         (_initialize_values): Register new internal functions.
3899
3900 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3901
3902         * infrun.c (stop_all_threads): If debug_infrun, always
3903         trace the wait status after wait_one, using
3904         target_waitstatus_to_string and target_pid_to_str.
3905         (handle_inferior_event): Replace various trace of
3906         wait status kind by a single trace.
3907         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3908         wait status kind image by target_waitstatus_to_string.
3909         * target/waitstatus.c (target_waitstatus_to_string): Fix
3910         obsolete comment.
3911
3912 2019-04-01  Tom Tromey  <tromey@adacore.com>
3913
3914         PR symtab/23331:
3915         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3916
3917 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3918             Pedro Alves  <palves@redhat.com>
3919
3920         * top.c (quit_force): Call 'finalize_values'.
3921         * value.c (finalize_values): New function.
3922         * value.h (finalize_values): Declare.
3923
3924 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3925
3926         * NEWS: Announce $_gdb_major and $_gdb_minor.
3927
3928         * top.c (init_gdb_version_vars): New function.
3929         (gdb_init): Call init_gdb_version_vars.
3930
3931 2019-03-29  Tom Tromey  <tromey@adacore.com>
3932
3933         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3934         help text.  Remove dead code.
3935
3936 2019-03-29  Keith Seitz  <keiths@redhat.com>
3937
3938         From Siddhesh Poyarekar:
3939         * f-lang.h (f77_get_upperbound): Return LONGEST.
3940         (f77_get_lowerbound): Likewise.
3941         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3942         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3943         print them.
3944         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3945         plongest to format print it.
3946         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3947         (f77_get_upperbound): Likewise.
3948         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3949         LOWER_BOUND to LONGEST.
3950         (f77_create_arrayprint_offset_tbl): Likewise.
3951
3952 2019-03-29  Keith Seitz  <keiths@redhat.com>
3953
3954         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3955         %s/pulongest for TYPE_LENGTH instead of %d in format
3956         strings.
3957         * ada-typerint.c (ada_print_type): Likewise.
3958         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3959         * compile/compile-c-support.c (generate_register_struct): Likewise.
3960         * gdbtypes.c (recursive_dump_type): Likewise.
3961         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3962         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3963         instead of %d in format strings.
3964         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3965         to std::min to ULONGEST.
3966         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3967         instead of %d in format strings.
3968         * tracepoint.c (info_scope_command): Likewise.
3969         * typeprint.c (print_offset_data::update)
3970         (print_offset_data::finish): Likewise.
3971         * xtensa-tdep.c (xtensa_store_return_value)
3972         (xtensa_push_dummy_call): Likewise.
3973
3974 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3975
3976         * windows-nat.c (display_selector): Fixed format specifications
3977         for 64-bit Cygwin.
3978
3979 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3980
3981         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3982
3983 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3984
3985         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3986         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3987         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3988         (nios2_linux_init_abi): Install it.
3989
3990 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3991
3992         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3993
3994 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3995
3996         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3997
3998 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3999             Tom Tromey  <tromey@adacore.com>
4000
4001         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4002
4003 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4004
4005         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4006         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4007         method to compute the bounds of range types. Also print "[evaluated]"
4008         if the bounds' values come from a dynamic evaluation.
4009
4010 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4011
4012         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4013         whitespace when pretty printing is on.
4014
4015 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4016
4017         * ppc-linux-nat.c: Add include.
4018
4019 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4020
4021         * NEWS: Mention AArch64 Pointer Authentication.
4022
4023 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4024
4025         * arm-linux-nat.c: Add include.
4026
4027 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4028
4029         * source-cache.c (source_cache::get_source_lines): Re-read
4030         fullname after calling open_source_file.
4031
4032 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4033
4034         * NEWS: Mention TLS support for FreeBSD.
4035
4036 2019-03-25  Tom Tromey  <tromey@adacore.com>
4037
4038         * minsyms.c (BUNCH_SIZE): Update comment.
4039         (~minimal_symbol_reader): Remove old comment.
4040         (compact_minimal_symbols): Update comment.
4041         (minimal_symbol_reader::install): Remove old comment.  Update
4042         other comments.
4043
4044 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4045
4046         * s390-linux-nat.c: Add include.
4047
4048 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4049
4050         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4051         Call linux_get_hwcap.
4052         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4053         Likewise.
4054         (aarch64_linux_get_hwcap): Remove function.
4055         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4056         declaration.
4057         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4058         linux_get_hwcap.
4059         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4060         * linux-tdep.c (linux_get_hwcap): Add function.
4061         (linux_get_hwcap2): Likewise.
4062         * linux-tdep.h (linux_get_hwcap): Add declaration.
4063         (linux_get_hwcap2): Likewise.
4064         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4065         (ppc_linux_get_hwcap2): Likewise.
4066         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4067         linux_get_hwcap.
4068         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4069         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4070         (ppc_linux_nat_target::read_description): Likewise.
4071         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4072         * s390-linux-nat.c: Likewise.
4073         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4074
4075 2019-03-24  Tom Tromey  <tom@tromey.com>
4076
4077         * ada-lang.c (standard_lookup): Simplify initialization.
4078         (ada_lookup_symbol_nonlocal): Simplify return.
4079         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4080         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4081         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4082         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4083         initialization.
4084         * solib.c (solib_global_lookup): Simplify.
4085         * symtab.c (null_block_symbol): Remove.
4086         (symbol_cache_lookup): Simplify returns.
4087         (lookup_language_this): Simplify returns.
4088         (lookup_symbol_aux): Simplify return.
4089         (lookup_local_symbol): Simplify returns.
4090         (lookup_global_symbol_from_objfile): Simplify return.
4091         (lookup_symbol_in_objfile_symtabs)
4092         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4093         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4094         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4095         * cp-namespace.c (cp_lookup_bare_symbol)
4096         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4097         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4098         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4099         (cp_lookup_symbol_via_imports): Simplify initialization.
4100         (find_symbol_in_baseclass): Likewise.
4101         * symtab.h (null_block_symbol): Remove.
4102         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4103         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4104         (d_lookup_symbol_module): Likewise.
4105         (find_symbol_in_baseclass): Simplify initialization.
4106
4107 2019-03-24  Tom Tromey  <tom@tromey.com>
4108
4109         * expression.h: Don't include symtab.h.
4110         (struct block): Forward declare.
4111
4112 2019-03-24  Tom Tromey  <tom@tromey.com>
4113
4114         * c-exp.y (typebase): Remove casts.
4115         * gdbtypes.c (lookup_unsigned_typename, )
4116         (lookup_signed_typename): Remove cast.
4117         * eval.c (parse_to_comma_and_eval): Remove cast.
4118         * parse.c (write_dollar_variable): Remove cast.
4119         * block.h (struct block) <superblock>: Now const.
4120         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4121         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4122         (map_block): Make "block" const.
4123         * symfile.h (struct quick_symbol_functions)
4124         <map_matching_symbols>: Constify block argument to "callback".
4125         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4126         const.
4127         (find_pc_sect_compunit_symtab): Make "b" const.
4128         (find_symbol_at_address): Likewise.
4129         (search_symbols): Likewise.
4130         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4131         (dw2_debug_names_lookup_symbol): Likewise.
4132         (dw2_map_matching_symbols): Update.
4133         * p-valprint.c (pascal_val_print): Remove "block".
4134         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4135         (aux_add_nonlocal_symbols): Make "block" const.
4136         (resolve_subexp): Remove cast.
4137         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4138         const.
4139         (iterate_over_file_blocks): Likewise.
4140         * f-exp.y (%union) <bval>: Remove.
4141         * coffread.c (patch_opaque_types): Make "b" const.
4142         * spu-tdep.c (spu_catch_start): Make "block" const.
4143         * c-valprint.c (print_unpacked_pointer): Remove "block".
4144         * symmisc.c (dump_symtab_1): Make "b" const.
4145         (block_depth): Make "block" const.
4146         * d-exp.y (%union) <bval>: Remove.
4147         * cp-support.h (cp_lookup_rtti_type): Update.
4148         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4149         * psymtab.c (psym_lookup_symbol): Make "block" const.
4150         (maintenance_check_psymtabs): Make "b" const.
4151         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4152         (enumerate_locals, enumerate_args): Update.
4153         * python/py-symtab.c (stpy_global_block): Make "block" const.
4154         (stpy_static_block): Likewise.
4155         * inline-frame.c (block_starting_point_at): Make "new_block"
4156         const.
4157         * block.c (find_block_in_blockvector): Make return type const.
4158         (blockvector_for_pc_sect): Make "b" const.
4159         (find_block_in_blockvector): Make "b" const.
4160
4161 2019-03-23  Tom Tromey  <tom@tromey.com>
4162
4163         * varobj.c (varobj_create): Update.
4164         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4165         * printcmd.c (display_command, do_one_display): Don't reset
4166         innermost_block.
4167         * parser-defs.h (enum innermost_block_tracker_type): Move to
4168         expression.h.
4169         (innermost_block): Update comment.
4170         * parse.c (parse_exp_1): Add tracker_types parameter.
4171         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4172         tracker_types parameter.  Reset innermost_block.
4173         (parse_exp_in_context): Remove.
4174         (parse_expression_for_completion): Update.
4175         * objfiles.c (~objfile): Don't reset expression_context_block or
4176         innermost_block.
4177         * expression.h (enum innermost_block_tracker_type): Move from
4178         parser-defs.h.
4179         (parse_exp_1): Add tracker_types parameter.
4180         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4181         reset innermost_block.
4182
4183 2019-03-23  Tom Tromey  <tom@tromey.com>
4184
4185         * objfiles.h: Include bcache.h.
4186
4187 2019-03-23  Tom Tromey  <tom@tromey.com>
4188
4189         * linespec.c (get_current_search_block): Use
4190         scoped_restore_current_language.
4191         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4192
4193 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4194             Jiong Wang  <jiong.wang@arm.com>
4195
4196         * aarch64-linux-tdep.c
4197         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4198         section.
4199         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4200
4201 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4202             Jiong Wang  <jiong.wang@arm.com>
4203
4204         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4205         instructions.
4206         (aarch64_analyze_prologue_test): Add PACIASP test.
4207         (aarch64_prologue_prev_register): Unmask PC value.
4208
4209 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4210             Jiong Wang  <jiong.wang@arm.com>
4211
4212         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4213         (aarch64_dwarf2_prev_register): Unmask PC value.
4214         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4215         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4216         DW_CFA_AARCH64_negate_ra_state.
4217         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4218
4219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4220             Jiong Wang  <jiong.wang@arm.com>
4221
4222         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4223         registers.
4224         (aarch64_pseudo_register_name): Likewise.
4225         (aarch64_pseudo_register_type): Likewise.
4226         (aarch64_pseudo_register_reggroup_p): Likewise.
4227         (aarch64_gdbarch_init): Add pauth registers.
4228         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4229         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4230         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4231         (struct gdbarch_tdep): Add regnum for ra_state.
4232
4233 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4234             Jiong Wang  <jiong.wang@arm.com>
4235
4236         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4237
4238 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4239             Jiong Wang  <jiong.wang@arm.com>
4240
4241         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4242         function.
4243         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4244         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4245         (aarch64_gdbarch_init): Add puth registers.
4246         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4247         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4248         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4249
4250 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4251             Jiong Wang  <jiong.wang@arm.com>
4252
4253         * aarch64-linux-nat.c
4254         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4255         * aarch64-linux-tdep.c
4256         (aarch64_linux_core_read_description): Likewise.
4257         (aarch64_linux_get_hwcap): New function.
4258         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4259         (aarch64_linux_get_hwcap): New declaration.
4260
4261 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4262             Jiong Wang  <jiong.wang@arm.com>
4263
4264         * aarch64-linux-nat.c
4265         (aarch64_linux_nat_target::read_description): Add pauth param.
4266         * aarch64-linux-tdep.c
4267         (aarch64_linux_core_read_description): Likewise.
4268         * aarch64-tdep.c (struct target_desc): Add in pauth.
4269         (aarch64_read_description): Add pauth param.
4270         (aarch64_gdbarch_init): Likewise.
4271         * aarch64-tdep.h (aarch64_read_description): Likewise.
4272         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4273         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4274         * features/Makefile: Add new files.
4275         * features/aarch64-pauth.c: New file.
4276         * features/aarch64-pauth.xml: New file.
4277
4278 2019-03-20  Tom Tromey  <tromey@adacore.com>
4279
4280         * infrun.c (handle_inferior_event): Rename from
4281         handle_inferior_event_1.  Create a scoped_value_mark.
4282         (handle_inferior_event): Remove.
4283
4284 2019-03-19  Tom Tromey  <tromey@adacore.com>
4285
4286         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4287         * infrun.h (print_stop_event): Add "displays" parameter.
4288         * infrun.c (print_stop_event): Add "displays" parameter.
4289
4290 2019-03-19  Pedro Alves  <palves@redhat.com>
4291
4292         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4293         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4294         to -1.  Fix TABs vs spaces.
4295         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4296         * tui/tui-out.h (tui_ui_out) Add intro comments.
4297         <m_line, m_start_of_line>: In-class initialize, and add describing
4298         comment.
4299
4300 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4301
4302         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4303         variable names.
4304         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4305
4306 2019-03-18  Pedro Alves  <palves@redhat.com>
4307             Eli Zaretskii <eliz@gnu.org>
4308
4309         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4310         m_line and m_start_of_line.
4311
4312 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4313
4314         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4315         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4316         it returns a newline.  This fixes a regression in TU mode, whereby
4317         the next line is output on the same screen line as the user input.
4318
4319 2019-03-18  Tom Tromey  <tromey@adacore.com>
4320
4321         * minsyms.c (minimal_symbol_reader::install): Remove call to
4322         obstack_blank.
4323
4324 2019-03-18  Pedro Alves  <palves@redhat.com>
4325
4326         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4327         New globals.
4328         (apply_style): New, factored out from ...
4329         (apply_ansi_escape): ... this.  Handle reverse video mode.
4330         (tui_set_reverse_mode): New function.
4331         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4332         * tui/tui-winsource.c (tui_show_source_line): Use
4333         tui_set_reverse_mode instead of setting A_STANDOUT.
4334         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4335         New setter methods.
4336
4337 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4338
4339         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4340         Handle tabs.
4341
4342 2019-03-18  Tom Tromey  <tromey@adacore.com>
4343
4344         * ada-lang.c (empty_array): Add "high" parameter.
4345         (ada_evaluate_subexp): Update.
4346
4347 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4348
4349         * unittests/string_view-selftests.c: Define
4350         _initialize_string_view_selftests unconditionally.
4351
4352 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4353
4354         PR gdb/24350
4355         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4356
4357 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4358
4359         PR gdb/24351
4360         * windows-nat.c (display_selector): Fix format specifiers.
4361
4362 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4363
4364         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4365         tui_refill_source_window instead of tui_refresh_win, to update the
4366         current execution line.  This fixes redisplay of the current line
4367         when stepping through the code with "next" or "step".
4368
4369 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4370
4371         * source-cache.c (source_cache::get_source_lines): Call
4372         find_source_lines to initialize s->nlines.  This fixes vertical
4373         scrolling of TUI source window when the DOWN arrow is pressed.
4374
4375 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4376
4377         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4378         linux-thread-db.c (_initialize_thread_db): Likewise.
4379
4380 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4381
4382         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4383         wclrtoeol in tui_show_source_line".  This reverts changes made in
4384         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4385
4386 2019-03-15  Tom Tromey  <tom@tromey.com>
4387
4388         * symtab.h (struct minimal_symbol): Derive from
4389         general_symbol_info.
4390         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4391         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4392         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4393         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4394         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4395         (MSYMBOL_SEARCH_NAME): Update.
4396         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4397         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4398         * minsyms.c (minimal_symbol_reader::record_full): Update.
4399
4400 2019-03-15  Tom Tromey  <tom@tromey.com>
4401
4402         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4403
4404 2019-03-15  Tom Tromey  <tom@tromey.com>
4405
4406         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4407         unique_xmalloc_ptr.
4408         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4409         Update.
4410         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4411         (build_minimal_symbol_hash_tables)
4412         (minimal_symbol_reader::install): Update.
4413
4414 2019-03-15  Tom Tromey  <tom@tromey.com>
4415
4416         * symtab.c (create_demangled_names_hash): Update.
4417         (symbol_set_names): Update.
4418         * objfiles.h (struct objfile_per_bfd_storage)
4419         <demangled_names_hash>: Now an htab_up.
4420         * objfiles.c (objfile_per_bfd_storage): Simplify.
4421
4422 2019-03-15  Tom Tromey  <tom@tromey.com>
4423
4424         * objfiles.h (struct objfile_per_bfd_storage): Declare
4425         destructor.
4426         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4427         New.
4428         (get_objfile_bfd_data): Use new.  Don't initialize
4429         language_of_main.
4430         (free_objfile_per_bfd_storage): Remove.
4431         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4432
4433 2019-03-15  Tom Tromey  <tom@tromey.com>
4434
4435         * symfile.c (reread_symbols): Update.
4436         * objfiles.c (objfile::objfile): Update.
4437         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4438         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4439         comment.
4440         (minimal_symbol_reader::install): Update.
4441         (terminate_minimal_symbol_table): Remove.
4442         * jit.c (jit_object_close_impl): Update.
4443
4444 2019-03-15  Tom Tromey  <tom@tromey.com>
4445
4446         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4447         initializations.
4448
4449 2019-03-15  Tom Tromey  <tom@tromey.com>
4450
4451         * objfiles.h (struct objfile_per_bfd_storage)
4452         <demangled_hash_languages>: Now a bitset.
4453         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4454         (lookup_minimal_symbol): Update.
4455
4456 2019-03-15  Tom Tromey  <tom@tromey.com>
4457
4458         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4459         Don't return the symbol.
4460         * coffread.c (record_minimal_symbol): Use record_full.
4461
4462 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4463
4464         The MS-Windows port of ncurses fails to switch to a color pair if
4465         one or both of the colors are the implicit default colors.  This
4466         change records the default colors when TUI is initialized, and
4467         then specifies them explicitly when a color pair uses the default
4468         colors.  This allows color styling in TUI mode on MS-Windows.
4469
4470         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4471         ncurses_norm_attr.
4472         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4473         colors in ncurses_norm_attr.
4474         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4475         "none", replace it with the default color recorded in
4476         ncurses_norm_attr.
4477
4478 2019-03-14  Tom Tromey  <tromey@adacore.com>
4479
4480         * source-cache.h (class source_cache) <get_source_lines>: Return
4481         std::string.
4482         * source-cache.c (source_cache::extract_lines): Handle case where
4483         first_pos==npos.  Return std::string.
4484         (source_cache::get_source_lines): Update.
4485
4486 2019-03-14  Tom Tromey  <tromey@adacore.com>
4487
4488         * NEWS: Add item for "style sources" commands.
4489         * source-cache.c (source_cache::get_source_lines): Check
4490         source_styling.
4491         * cli/cli-style.c (source_styling): New global.
4492         (_initialize_cli_style): Add "style sources" commands.
4493         (show_style_sources): New function.
4494         * cli/cli-style.h (source_styling): Declare.
4495
4496 2019-03-14  Pedro Alves  <palves@redhat.com>
4497             Tom Tromey  <tromey@adacore.com>
4498
4499         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4500         * tui/tui-winsource.c (tui_refill_source_window): New function,
4501         from...
4502         (tui_horizontal_source_scroll): ... here.  Move some logic.
4503         * cli/cli-style.c (set_style_enabled): Notify new observable.
4504         * tui/tui-hooks.c (tui_redisplay_source): New function.
4505         (tui_attach_detach_observers): Attach or detach
4506         tui_redisplay_source.
4507         * observable.h (source_styling_changed): New observable.
4508         * observable.c: Define source_styling_changed observable.
4509
4510 2019-03-13  Tom Tromey  <tromey@adacore.com>
4511
4512         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4513         (i386_gnu_nat_target::store_registers): Update.
4514         * target-debug.h (target_debug_print_std_string): New macro.
4515         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4516         * windows-tdep.c (display_one_tib): Update.
4517         * tui/tui-stack.c (tui_make_status_line): Update.
4518         * top.c (print_inferior_quit_action): Update.
4519         * thread.c (thr_try_catch_cmd): Update.
4520         (add_thread_with_info): Update.
4521         (thread_target_id_str): Update.
4522         (thr_try_catch_cmd): Update.
4523         (thread_command): Update.
4524         (thread_find_command): Update.
4525         * record-btrace.c (record_btrace_target::info_record)
4526         (record_btrace_resume_thread, record_btrace_target::resume)
4527         (record_btrace_cancel_resume, record_btrace_step_thread)
4528         (record_btrace_target::wait, record_btrace_target::wait)
4529         (record_btrace_target::wait, record_btrace_target::stop): Update.
4530         * progspace.c (print_program_space): Update.
4531         * process-stratum-target.c
4532         (process_stratum_target::thread_address_space): Update.
4533         * linux-fork.c (linux_fork_mourn_inferior)
4534         (detach_checkpoint_command, info_checkpoints_command)
4535         (linux_fork_context): Update.
4536         (linux_fork_detach): Update.
4537         (class scoped_switch_fork_info): Update.
4538         (delete_checkpoint_command): Update.
4539         * infrun.c (follow_fork_inferior): Update.
4540         (follow_fork_inferior): Update.
4541         (proceed_after_vfork_done): Update.
4542         (handle_vfork_child_exec_or_exit): Update.
4543         (follow_exec): Update.
4544         (displaced_step_prepare_throw): Update.
4545         (displaced_step_restore): Update.
4546         (start_step_over): Update.
4547         (resume_1): Update.
4548         (clear_proceed_status_thread): Update.
4549         (proceed): Update.
4550         (print_target_wait_results): Update.
4551         (do_target_wait): Update.
4552         (context_switch): Update.
4553         (stop_all_threads): Update.
4554         (restart_threads): Update.
4555         (finish_step_over): Update.
4556         (handle_signal_stop): Update.
4557         (switch_back_to_stepped_thread): Update.
4558         (keep_going_pass_signal): Update.
4559         (print_exited_reason): Update.
4560         (normal_stop): Update.
4561         * inferior.c (inferior_pid_to_str): Change return type.
4562         (print_selected_inferior): Update.
4563         (add_inferior): Update.
4564         (detach_inferior): Update.
4565         * dummy-frame.c (fprint_dummy_frames): Update.
4566         * dcache.c (dcache_info_1): Update.
4567         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4568         (btrace_fetch, btrace_clear): Update.
4569         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4570         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4571         type.
4572         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4573         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4574         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4575         * gdbarch.c, gdbarch.h: Rebuild.
4576         * gdbarch.sh (core_pid_to_str): Change return type.
4577         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4578         return type.
4579         (windows_nat_target::pid_to_str): Change return type.
4580         (windows_delete_thread): Update.
4581         (windows_nat_target::attach): Update.
4582         (windows_nat_target::files_info): Update.
4583         * target-delegates.c: Rebuild.
4584         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4585         return type.
4586         (sol_thread_target::pid_to_str): Change return type.
4587         * remote.c (class remote_target) <pid_to_str>: Change return
4588         type.
4589         (remote_target::pid_to_str): Change return type.
4590         (extended_remote_target::attach, remote_target::remote_stop_ns)
4591         (remote_target::remote_notif_remove_queued_reply)
4592         (remote_target::push_stop_reply, remote_target::disable_btrace):
4593         Update.
4594         (extended_remote_target::attach): Update.
4595         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4596         type.
4597         (gdbsim_target::pid_to_str): Change return type.
4598         * ravenscar-thread.c (struct ravenscar_thread_target)
4599         <pid_to_str>: Change return type.
4600         (ravenscar_thread_target::pid_to_str): Change return type.
4601         * procfs.c (class procfs_target) <pid_to_str>: Change return
4602         type.
4603         (procfs_target::pid_to_str): Change return type.
4604         (procfs_target::attach): Update.
4605         (procfs_target::detach): Update.
4606         (procfs_target::fetch_registers): Update.
4607         (procfs_target::store_registers): Update.
4608         (procfs_target::wait): Update.
4609         (procfs_target::files_info): Update.
4610         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4611         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4612         return type.
4613         (nto_procfs_target::pid_to_str): Change return type.
4614         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4615         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4616         return type.
4617         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4618         (exit_lwp): Update.
4619         (attach_proc_task_lwp_callback, get_detach_signal)
4620         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4621         (linux_nat_target::resume, wait_lwp, stop_callback)
4622         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4623         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4624         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4625         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4626         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4627         type.
4628         (inf_ptrace_target::attach): Update.
4629         (inf_ptrace_target::files_info): Update.
4630         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4631         type.
4632         (go32_nat_target::pid_to_str): Change return type.
4633         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4634         (gnu_nat_target::wait): Update.
4635         (gnu_nat_target::wait): Update.
4636         (gnu_nat_target::resume): Update.
4637         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4638         (fbsd_nat_target::wait): Update.
4639         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4640         type.
4641         (darwin_nat_target::attach): Update.
4642         * corelow.c (class core_target) <pid_to_str>: Change return type.
4643         (core_target::pid_to_str): Change return type.
4644         * target.c (normal_pid_to_str): Change return type.
4645         (default_pid_to_str): Likewise.
4646         (target_pid_to_str): Change return type.
4647         (target_translate_tls_address): Update.
4648         (target_announce_detach): Update.
4649         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4650         return type.
4651         (bsd_uthread_target::pid_to_str): Change return type.
4652         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4653         type.
4654         (bsd_kvm_target::pid_to_str): Change return type.
4655         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4656         return type.
4657         (aix_thread_target::pid_to_str): Change return type.
4658         * target.h (struct target_ops) <pid_to_str>: Change return type.
4659         (target_pid_to_str, normal_pid_to_str): Likewise.
4660         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4661         type.
4662         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4663         type.
4664         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4665         return type.
4666         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4667         type.
4668         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4669         type.
4670         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4671         return type.
4672
4673 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4674
4675         * NEWS: Mention that the new default MI version is 3.  Mention
4676         changes to the output of commands and events that deal with
4677         multi-location breakpoints.
4678         * breakpoint.c: Include "mi/mi-out.h".
4679         (print_one_breakpoint): Change output syntax if using MI version
4680         >= 3.
4681         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4682         New.
4683         (mi_multi_location_breakpoint_output_fixed): New.
4684         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4685         (mi_cmd_fix_multi_location_breakpoint_output): New.
4686         (mi_multi_location_breakpoint_output_fixed): New.
4687         * mi/mi-cmds.c (mi_cmds): Register command
4688         -fix-multi-location-breakpoint-output.
4689         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4690         interpreter "mi".
4691
4692 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4693
4694         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4695         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4696         instantiate mi_ui_out based on interpreter name.
4697         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4698         * mi/mi-main.c (mi_load_progress): Likewise.
4699
4700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4701
4702         * NEWS: Combine separate "New targets" sections for 8.3.
4703
4704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4705
4706         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4707         (ppcfbsd_init_abi): Install gdbarch
4708         "fetch_tls_load_module_address" and "get_thread_local_address"
4709         methods.
4710
4711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4712
4713         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4714         (riscv_fbsd_init_abi): Install gdbarch
4715         "fetch_tls_load_module_address" and "get_thread_local_address"
4716         methods.
4717
4718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4719
4720         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4721         (i386fbsd_init_abi): Install gdbarch
4722         "fetch_tls_load_module_address" and "get_thread_local_address"
4723         methods.
4724
4725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4726
4727         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4728         (amd64fbsd_init_abi): Install gdbarch
4729         "fetch_tls_load_module_address" and "get_thread_local_address"
4730         methods.
4731
4732 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4733
4734         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4735         (struct fbsd_pspace_data): New type.
4736         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4737         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4738         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4739         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4740         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4741
4742 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4743
4744         * gdbtypes.c (lookup_struct_elt): New function.
4745         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4746         * gdbtypes.h (struct struct_elt): New type.
4747         (lookup_struct_elt): New prototype.
4748
4749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4750
4751         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4752         remove disabled code block.
4753
4754 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4755
4756         * gdbarch.sh (get_thread_local_address): New method.
4757         * gdbarch.h, gdbarch.c: Regenerate.
4758         * target.c (target_translate_tls_address): Use
4759         gdbarch_get_thread_local_address if present instead of
4760         target::get_thread_local_address.
4761
4762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4763
4764         * target.h (target::get_thread_local_address): Update comment.
4765
4766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4767
4768         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4769         objfile->separate_debug_objfile_backlink if not NULL.
4770
4771 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4772
4773         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4774         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4775         (amd64bsd_store_inferior_registers): Likewise.
4776         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4777         Enable segment base registers.
4778         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4779         PT_GETFSBASE and PT_GETGSBASE.
4780         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4781         PT_SETGSBASE.
4782         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4783         segment base registers.
4784         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4785
4786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4787
4788         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4789         Update calls to i386_target_description to add 'segments'
4790         parameter.
4791         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4792         add segment base registers.
4793         * arch/i386.c (i386_create_target_description): Add 'segments'
4794         parameter to enable segment base registers.
4795         * arch/i386.h (i386_create_target_description): Likewise.
4796         * features/i386/32bit-segments.xml: New file.
4797         * features/i386/32bit-segments.c: Generate.
4798         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4799         call to i386_target_description to add 'segments' parameter.
4800         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4801         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4802         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4803         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4804         if feature is present.
4805         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4806         Add 'segments' parameter to call to i386_target_description.
4807         (i386_target_description): Add 'segments' parameter to enable
4808         segment base registers.
4809         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4810         to call to i386_target_description.
4811         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4812         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4813         Define I386_NUM_REGS.
4814         (i386_target_description): Add 'segments' parameter to enable
4815         segment base registers.
4816
4817 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4818
4819         PR/24325
4820         * source-cache.c: #undef open and close, to avoid unresolved
4821         externals during linking.
4822
4823 2019-03-12  Tom Tromey  <tromey@adacore.com>
4824
4825         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4826         const.  Add initializers.
4827         (_initialize_remote): Don't initialize ptid globals.
4828
4829 2019-03-12  Pedro Alves  <palves@redhat.com>
4830
4831         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4832
4833 2019-03-12  Pedro Alves  <palves@redhat.com>
4834
4835         * cp-name-parser.y (main): Remove unused 'len' variable.
4836
4837 2019-03-12  Tom Tromey  <tromey@adacore.com>
4838
4839         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4840         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4841
4842 2019-03-12  Tom Tromey  <tromey@adacore.com>
4843
4844         * linux-nat.c (iterate_over_lwps): Update.
4845         (stop_callback): Remove parameter.
4846         (stop_wait_callback, detach_callback, resume_set_callback)
4847         (select_singlestep_lwp_callback, set_ignore_sigint)
4848         (status_callback, resumed_callback, resume_clear_callback)
4849         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4850         data parameter.
4851         (linux_nat_target::detach, linux_nat_target::resume)
4852         (linux_stop_and_wait_all_lwps, select_event_lwp)
4853         (linux_nat_filter_event, linux_nat_wait_1)
4854         (linux_nat_target::kill, linux_nat_target::stop)
4855         (linux_nat_target::stop): Update.
4856         (linux_nat_resume_callback): Change type.
4857         (resume_stopped_resumed_lwps, count_events_callback)
4858         (select_event_lwp_callback): Likewise.
4859         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4860         * arm-linux-nat.c (struct update_registers_data): Remove.
4861         (update_registers_callback): Change type.
4862         (arm_linux_insert_hw_breakpoint1): Update.
4863         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4864         parameter.
4865         (x86_linux_dr_set_addr): Update.
4866         (x86_linux_dr_set_control): Update.
4867         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4868         (iterate_over_lwps): Use gdb::function_view.
4869         * nat/aarch64-linux-hw-point.c (struct
4870         aarch64_dr_update_callback_param): Remove.
4871         (debug_reg_change_callback): Change type.
4872         (aarch64_notify_debug_reg_change): Update.
4873         * s390-linux-nat.c (s390_refresh_per_info): Update.
4874
4875 2019-03-11  Tom Tromey  <tromey@adacore.com>
4876
4877         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4878         redundant assignment to "this_cu".
4879
4880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4881
4882         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4883
4884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4885
4886         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4887         from...
4888         (rank_one_type): ... this.
4889
4890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4891
4892         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4893         from...
4894         (rank_one_type): ... this.
4895
4896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4897
4898         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4899         from...
4900         (rank_one_type): ... this.
4901
4902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4903
4904         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4905         from...
4906         (rank_one_type): ... this.
4907
4908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4909
4910         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4911         from...
4912         (rank_one_type): ... this.
4913
4914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4915
4916         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4917         from...
4918         (rank_one_type): ... this.
4919
4920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4921
4922         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4923         from...
4924         (rank_one_type): ... this.
4925
4926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4927
4928         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4929         from...
4930         (rank_one_type): ... this.
4931
4932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4933
4934         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4935         from...
4936         (rank_one_type): ... this.
4937
4938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4939
4940         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4941         from...
4942         (rank_one_type): ... this.
4943
4944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4945
4946         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4947         from...
4948         (rank_one_type): ... this.
4949
4950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4951
4952         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4953         from...
4954         (rank_one_type): ... this.
4955
4956 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4957
4958         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4959         inferior-events' shows the example events.
4960
4961 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4962
4963         Support styling on native MS-Windows console
4964
4965         PR/24315
4966         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4967         on MS-Windows if $TERM is not defined.
4968
4969         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4970
4971         * posix-hdep.c (gdb_console_fputs):
4972         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4973         functions.
4974         * ui-file.h (gdb_console_fputs): Add prototype.
4975
4976         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4977         back to fputs only if the former returns zero.
4978
4979 2019-03-07  Tom Tromey  <tom@tromey.com>
4980
4981         * symmisc.c (print_symbol_bcache_statistics): Update.
4982         (print_objfile_statistics): Update.
4983         * symfile.c (allocate_symtab): Update.
4984         * stabsread.c: Don't include bcache.h.
4985         * psymtab.h (struct psymbol_bcache): Don't declare.
4986         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4987         (psymbol_bcache_init, psymbol_bcache_free)
4988         (psymbol_bcache_get_bcache): Don't declare.
4989         * psymtab.c (struct psymbol_bcache): Remove.
4990         (psymtab_storage::psymtab_storage): Update.
4991         (psymtab_storage::~psymtab_storage): Update.
4992         (psymbol_bcache_init, psymbol_bcache_free)
4993         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4994         (add_psymbol_to_bcache): Update.
4995         (allocate_psymtab): Update.
4996         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4997         macro_cache>: No longer pointers.
4998         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4999         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5000         * macrotab.c (macro_bcache): Update.
5001         * macroexp.c: Don't include bcache.h.
5002         * gdbtypes.c (check_types_worklist): Update.
5003         (types_deeply_equal): Remove TRY/CATCH.  Update.
5004         * elfread.c (elf_symtab_read): Update.
5005         * dwarf2read.c: Don't include bcache.h.
5006         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5007         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5008         (print_bcache_statistics, bcache_memory_used): Don't declare.
5009         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5010         methods.  Rename all data members.
5011         * bcache.c (struct bcache): Move to bcache.h.
5012         (bcache::expand_hash_table): Rename from expand_hash_table.
5013         (bcache): Remove.
5014         (bcache::insert): Rename from bcache_full.
5015         (bcache::compare): Rename from bcache_compare.
5016         (bcache_xmalloc): Remove.
5017         (bcache::~bcache): Rename from bcache_xfree.
5018         (bcache::print_statistics): Rename from print_bcache_statistics.
5019         (bcache::memory_used): Rename from bcache_memory_used.
5020
5021 2019-03-07  Pedro Alves  <palves@redhat.com>
5022
5023         * infrun.c (normal_stop): Also check for
5024         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5025
5026 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5027
5028         * f-lang.c (value_from_host_double): Moved to...
5029         * value.c (value_from_host_double): ...here.
5030         * value.h (value_from_host_double): Declare.
5031         * guile/scm-math.c (vlscm_convert_typed_number): Use
5032         value_from_host_double.
5033         (vlscm_convert_number): Likewise.
5034         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5035         * python/py-value.c (convert_value_from_python): Likewise.
5036
5037 2019-03-06  Tom Tromey  <tom@tromey.com>
5038
5039         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5040
5041 2019-03-06  Tom Tromey  <tom@tromey.com>
5042
5043         * utils.h (free_current_contents): Don't declare.
5044         * utils.c (free_current_contents): Remove.
5045
5046 2019-03-06  Tom Tromey  <tom@tromey.com>
5047
5048         * top.c (quit_force): Update.
5049         * main.c (captured_command_loop): Update.
5050         * common/new-op.c (operator new): Update.
5051         * common/common-exceptions.c (struct catcher)
5052         <save_cleanup_chain>: Remove member.
5053         (exceptions_state_mc_init): Update.
5054         (exception_try_scope_entry): Return nullptr.
5055         (exception_try_scope_exit, exception_rethrow)
5056         (throw_exception_sjlj, throw_exception_cxx): Update.
5057         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5058         (all_cleanups, do_cleanups, discard_cleanups)
5059         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5060         (restore_cleanups, restore_final_cleanups): Don't declare.
5061         (do_final_cleanups): Remove parameter.
5062         * common/cleanups.c (cleanup_chain, make_cleanup)
5063         (make_cleanup_dtor, all_cleanups, do_cleanups)
5064         (discard_my_cleanups, discard_cleanups)
5065         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5066         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5067         (null_cleanup): Remove.
5068         (do_final_cleanups): Remove parameter.
5069
5070 2019-03-06  Tom Tromey  <tom@tromey.com>
5071
5072         * remote.c (remote_target::remote_parse_stop_reply): Use
5073         unique_xmalloc_ptr.
5074
5075 2019-03-06  Tom Tromey  <tom@tromey.com>
5076
5077         * stabsread.c (struct stabs_field_info): Rename from field_info.
5078         <list, fnlist>: Add initializers.
5079         <obstack>: New member.
5080         (read_member_functions, read_struct_fields, read_baseclasses):
5081         Allocate on obstack.  Don't use cleanups.
5082         (read_one_struct_field, read_member_functions, read_struct_fields)
5083         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5084         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5085         (read_struct_type): Update.
5086
5087 2019-03-06  Tom Tromey  <tom@tromey.com>
5088
5089         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5090         * common/filestuff.h (make_cleanup_close): Don't declare.
5091         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5092         Remove.
5093
5094 2019-03-06  Tom Tromey  <tom@tromey.com>
5095
5096         * solib-aix.c: Use make_scope_exit.
5097
5098 2019-03-06  Tom Tromey  <tom@tromey.com>
5099
5100         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5101         Use make_scope_exit.
5102
5103 2019-03-06  Tom Tromey  <tom@tromey.com>
5104
5105         * solib-svr4.c (disable_probes_interface): Remove parameter.
5106         (svr4_handle_solib_event): Use make_scope_exit.
5107
5108 2019-03-06  Tom Tromey  <tom@tromey.com>
5109
5110         * remote.c (struct stop_reply_deleter): Remove.
5111         (stop_reply_up): Update.
5112         (struct stop_reply): Derive from notif_event.  Don't typedef.
5113         <regcache>: Now a std::vector.
5114         (stop_reply_xfree): Remove.
5115         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5116         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5117         (remote_target::discard_pending_stop_replies): Use delete.
5118         (remote_target::remote_parse_stop_reply): Update.
5119         (remote_target::process_stop_reply): Update.
5120         * remote-notif.h (struct notif_event): Add virtual destructor.
5121         Remove "dtr" member.
5122         (struct notif_client) <alloc_event>: Return a unique_ptr.
5123         (notif_event_xfree): Don't declare.
5124         (notif_event_up): New typedef.
5125         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5126         (notif_event_xfree, do_notif_event_xfree): Remove.
5127         (remote_notif_state_xfree): Update.
5128
5129 2019-03-06  Tom Tromey  <tom@tromey.com>
5130
5131         * infrun.c (displaced_step_clear_cleanup): Now a
5132         forward_scope_exit type.
5133         (displaced_step_prepare_throw): Update.
5134         (displaced_step_fixup): Update.
5135
5136 2019-03-06  Tom Tromey  <tom@tromey.com>
5137
5138         * inferior.h (class inferior): Update comment.
5139         * gdbthread.h (class thread_info): Update comment.
5140
5141 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5142             Tom Tromey  <tom@tromey.com>
5143
5144         * stabsread.h (struct stab_section_list): Remove.
5145         (coffstab_build_psymtabs): Update.
5146         * dbxread.c (symbuf_sections): Now a std::vector.
5147         (sect_idx): New global.
5148         (fill_symbuf): Update.
5149         (coffstab_build_psymtabs): Change type of stabsects parameter.
5150         Update.
5151         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5152         std::vector.
5153         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5154         (coff_locate_sections): Update.
5155         (coff_symfile_read): Remove cleanups.  Update.
5156         (init_stringtab): Add storage parameter.
5157         (free_stringtab, free_stringtab_cleanup): Remove.
5158         (init_lineno): Add storage parameter.
5159         (free_linetab, free_linetab_cleanup): Remove.
5160
5161 2019-03-06  Pedro Alves  <palves@redhat.com>
5162
5163         * linux-fork.c (fork_info::clobber_regs): Delete.
5164         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5165         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5166         comment.  Adjust.
5167         (scoped_switch_fork_info::scoped_switch_fork_info)
5168         (checkpoint_command, linux_fork_context): Adjust
5169         fork_save_infrun_state calls.
5170
5171 2019-03-06  Pedro Alves  <palves@redhat.com>
5172
5173         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5174         (inf_has_multiple_threads): Return 'bool' and rewrite using
5175         inferior_info::threads().
5176
5177 2019-03-06  Pedro Alves  <palves@redhat.com>
5178
5179         * linux-fork.c: Include <list>.
5180         (fork_list): Now a std::list instance.
5181         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5182         (forks_exist_p, find_last_fork): Adjust.
5183         (new_fork): Delete.
5184         (one_fork_p): New.
5185         (add_fork): Adjust.
5186         (free_fork): Delete, folded into fork_info::~fork_info().
5187         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5188         Adjust.
5189         (init_fork_list): Delete.
5190         (linux_fork_killall, linux_fork_mourn_inferior)
5191         (linux_fork_detach, info_checkpoints_command): Adjust.
5192         (_initialize_linux_fork): No longer call init_fork_list.
5193
5194 2019-03-06  Pedro Alves  <palves@redhat.com>
5195
5196         * linux-fork.c (new_fork): New, split out of ...
5197         (add_fork): ... this.  Return void.  Move "first fork" special
5198         case from here, to ...
5199         (checkpoint_command): ... here.
5200         * linux-linux.h (add_fork): Return void.
5201
5202 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5203
5204         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5205
5206 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5207             Chris January  <chris.january@arm.com>
5208             David Lecomber  <david.lecomber@arm.com>
5209
5210         * f-exp.y: New token, UNOP_INTRINSIC.
5211         (exp): New pattern using UNOP_INTRINSIC token.
5212         (f77_keywords): Add 'abs' keyword.
5213         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5214         (value_from_host_double): New function.
5215         (evaluate_subexp_f): Support UNOP_ABS.
5216
5217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5220         types.
5221
5222 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5223
5224         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5225         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5226         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5227
5228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5229
5230         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5231
5232 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5233             Chris January  <chris.january@arm.com>
5234
5235         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5236         * f-exp.y: Define 'KIND' token.
5237         (exp): New pattern for KIND expressions.
5238         (ptype): Handle types with a kind extension.
5239         (direct_abs_decl): Extend to spot kind extensions.
5240         (f77_keywords): Add 'kind' to the list.
5241         (push_kind_type): New function.
5242         (convert_to_kind_type): New function.
5243         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5244         * parse.c (operator_length_standard): Likewise.
5245         * parser-defs.h (enum type_pieces): Add tp_kind.
5246         * std-operator.def: Add UNOP_KIND.
5247
5248 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5249
5250         * f-exp.y (f_parse): Set yydebug.
5251
5252 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5253
5254         * f-lang.c (evaluate_subexp_f): New function.
5255         (exp_descriptor_f): New global.
5256         (f_language_defn): Use exp_descriptor_f instead of
5257         exp_descriptor_standard.
5258
5259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5260
5261         * f-exp.y (struct token): Add comments.
5262         (dot_ops): Remove uppercase versions and the end marker.
5263         (f77_keywords): Likewise.
5264         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5265         entries in the dot_ops array are case insensitive, and use
5266         strncasecmp to compare strings.  Also some whitespace cleanup in
5267         this area.  Similar for the f77_keywords array, except entries in
5268         this list might be case sensitive.
5269
5270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5271
5272         * f-exp.y (struct f77_boolean_val): Add comments.
5273         (boolean_values): Remove uppercase versions, and end marker.
5274         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5275         and use strncasecmp to achieve case insensitivity.  Additionally,
5276         perform whitespace cleanup around this code.
5277
5278 2019-03-06  Tom Tromey  <tromey@adacore.com>
5279
5280         * remote-sim.c (gdbsim_target_open): Use result of
5281         gdb_argv::release.
5282
5283 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5284         Dirk Schubert  <dirk.schubert@arm.com>
5285         Chris January  <chris.january@arm.com>
5286
5287         * eval.c (evaluate_subexp_standard): Call Fortran argument
5288         wrapping logic.
5289         * f-lang.c (struct value): A value which can be passed into a
5290         Fortran function call.
5291         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5292         where appropriate.
5293         (struct type): Value ready for a Fortran function call.
5294         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5295         is needed.
5296         * f-lang.h (fortran_argument_convert): Declaration.
5297         (fortran_preserve_arg_pointer): Declaration.
5298         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5299
5300 2019-03-05  Tom Tromey  <tromey@adacore.com>
5301
5302         * python/py-prettyprint.c (print_string_repr): Remove #if.
5303         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5304
5305 2019-03-05  Tom Tromey  <tromey@adacore.com>
5306
5307         * target.c (the_dummy_target): Move later.  Change type to
5308         "dummy_target".
5309         (initialize_targets): Don't initialize the_dummy_target.
5310
5311 2019-03-05  Tom Tromey  <tromey@adacore.com>
5312
5313         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5314         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5315
5316 2019-03-05  Tom Tromey  <tromey@adacore.com>
5317
5318         * windows-nat.c (windows_nat_target::attach)
5319         (windows_nat_target::detach): Don't call gdb_flush.
5320         * valprint.c (generic_val_print, val_print, val_print_string):
5321         Don't call gdb_flush.
5322         * utils.c (defaulted_query): Don't call gdb_flush.
5323         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5324         * target.c (target_announce_detach): Don't call gdb_flush.
5325         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5326         * remote.c (extended_remote_target::attach): Don't call
5327         gdb_flush.
5328         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5329         * printcmd.c (do_examine): Don't call gdb_flush.
5330         (info_display_command): Don't call gdb_flush.
5331         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5332         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5333         * memattr.c (info_mem_command): Don't call gdb_flush.
5334         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5335         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5336         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5337         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5338         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5339         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5340         (gnu_nat_target::detach): Don't call gdb_flush.
5341         * f-valprint.c (f_val_print): Don't call gdb_flush.
5342         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5343         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5344         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5345         gdb_flush.
5346         * c-valprint.c (c_val_print): Don't call gdb_flush.
5347         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5348
5349 2019-03-05  Tom Tromey  <tromey@adacore.com>
5350
5351         * varobj.c (update_dynamic_varobj_children): Update.
5352         (install_default_visualizer): Use reset, not release.
5353         * value.c (set_internalvar): Update.
5354         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5355         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5356         ATTRIBUTE_UNUSED_RESULT.
5357
5358 2019-03-05  Tom Tromey  <tromey@adacore.com>
5359
5360         * remote.c (class scoped_remote_fd) <release>: Add
5361         ATTRIBUTE_UNUSED_RESULT.
5362
5363 2019-03-05  Tom Tromey  <tromey@adacore.com>
5364
5365         * macroexp.c (struct macro_buffer) <release>: Add
5366         ATTRIBUTE_UNUSED_RESULT.
5367
5368 2019-03-05  Tom Tromey  <tromey@adacore.com>
5369
5370         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5371         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5372         ATTRIBUTE_UNUSED_RESULT.
5373
5374 2019-03-05  Tom Tromey  <tromey@adacore.com>
5375
5376         * common/scoped_fd.h (class scoped_fd) <release>: Add
5377         ATTRIBUTE_UNUSED_RESULT.
5378
5379 2019-03-05  Tom Tromey  <tromey@adacore.com>
5380
5381         * parser-defs.h (struct parser_state) <release>: Add
5382         ATTRIBUTE_UNUSED_RESULT.
5383
5384 2019-03-05  Tom Tromey  <tromey@adacore.com>
5385
5386         * utils.h (class gdb_argv) <release>: Add
5387         ATTRIBUTE_UNUSED_RESULT.
5388         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5389
5390 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5391
5392         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5393         for-loop range, to avoid compiler warnings.
5394
5395         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5396         avoid compiler warnings about unused variables.
5397
5398         * NEWS: Mention end of support for native debugging on MS-Windows
5399         before XP.
5400
5401         PR gdb/24292
5402         * common/netstuff.c:
5403         * gdbserver/gdbreplay.c
5404         * gdbserver/remote-utils.c:
5405         * ser-tcp.c:
5406         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5407         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5408         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5409         'getaddrinfo' and 'freeaddrinfo' were not available before
5410         Windows XP, and mingw.org's MinGW headers by default define
5411         _WIN32_WINNT to 0x500.
5412
5413 2019-03-01  Gary Benson <gbenson@redhat.com>
5414
5415         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5416
5417 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5418             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5419
5420         PR gdb/8527
5421         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5422         set_sigint_trap, clear_sigint_trap.
5423
5424 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5425
5426         * target.c (target_detach): Clear the regcache and the
5427         frame cache.
5428
5429 2019-02-27  Pedro Alves  <palves@redhat.com>
5430
5431         * utils.c (set_screen_size): When we cap the height/width sizes,
5432         tweak the corresponding command variable to show "unlimited":
5433
5434 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5435             Pedro Alves  <palves@redhat.com>
5436
5437         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5438         before calling rl_set_screen_size.
5439
5440 2019-02-27  Tom Tromey  <tromey@adacore.com>
5441
5442         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5443         define.
5444         * python/py-value.c: Remove Python 2.4 workaround.
5445         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5446         workaround.
5447         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5448         Python 2.4 workaround.
5449         * python/python-internal.h: Remove Python 2.4 comment.
5450         (Py_ssize_t): Don't define.
5451         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5452         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5453         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5454         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5455         * python/python.c (do_start_initialization): Remove Python 2.4
5456         workaround.
5457         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5458         (print_children): Remove Python 2.4 workaround.
5459         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5460         workaround.
5461         (CHARBUFFERPROC_NAME): Remove.
5462         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5463         Python 2.4 workaround.
5464
5465 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5466
5467         * NEWS: Note minimum Python version.
5468
5469 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5470
5471         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5472         code from these functions.  Remove corresponding ifdefs.  Use
5473         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5474         Remove gotos and target of gotos.
5475         (infpy_search_memory): Likewise.
5476
5477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5478
5479         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5480         (hppa_gdbarch_init): Don't register deleted functions with
5481         gdbarch.
5482
5483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5486         (h8300_unwind_sp): Delete.
5487         (h8300_dummy_id): Delete.
5488         (h8300_gdbarch_init): Don't register deleted functions with
5489         gdbarch.
5490
5491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5492
5493         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5494         (ft32_unwind_pc): Delete.
5495         (ft32_unwind_sp): Delete.
5496         (ft32_gdbarch_init): Don't register deleted functions with
5497         gdbarch.
5498
5499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5500
5501         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5502         (frv_unwind_pc): Delete.
5503         (frv_unwind_sp): Delete.
5504         (frv_gdbarch_init): Don't register deleted functions with
5505         gdbarch.
5506
5507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5508
5509         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5510         (riscv_unwind_pc): Delete.
5511         (riscv_unwind_sp): Delete.
5512         (riscv_gdbarch_init): Don't register deleted functions with
5513         gdbarch.
5514
5515 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5516
5517         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5518         (csky_unwind_pc): Delete.
5519         (csky_unwind_sp): Delete.
5520         (csky_gdbarch_init): Don't register deleted functions with
5521         gdbarch.
5522
5523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5524
5525         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5526         (cris_unwind_pc): Delete.
5527         (cris_unwind_sp): Delete.
5528         (cris_gdbarch_init): Don't register deleted functions with
5529         gdbarch.
5530
5531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5532
5533         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5534         (bfin_unwind_pc): Delete.
5535         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5536
5537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5538
5539         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5540         (arm_unwind_pc): Delete.
5541         (arm_unwind_sp): Delete.
5542         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5543
5544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5545
5546         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5547         (arc_unwind_pc): Delete.
5548         (arc_unwind_sp): Delete.
5549         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5550
5551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5552
5553         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5554         (alpha_unwind_pc): Delete.
5555         (alpha_gdbarch_init): Don't register deleted functions with
5556         gdbarch.
5557
5558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5559
5560         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5561         (aarch64_unwind_pc): Delete.
5562         (aarch64_unwind_sp): Delete.
5563         (aarch64_gdbarch_init): Don't register deleted functions with
5564         gdbarch.
5565
5566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5567
5568         * gdbtypes.c (type_align): Don't consider static members when
5569         computing structure alignment.
5570
5571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5572
5573         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5574         return 0 for other types.
5575         * arch-utils.c (default_type_align): Always return 0.
5576         * gdbarch.h: Regenerate.
5577         * gdbarch.sh (type_align): Extend comment.
5578         * gdbtypes.c (type_align): Add additional comments, always call
5579         gdbarch_type_align before applying the default rules.
5580         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5581         generic code will then apply a suitable default.
5582         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5583         types, return 0 for other types.
5584
5585 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5586
5587         * NEWS: Create a new section for the next release branch.
5588         Rename the section of the current branch, now that it has
5589         been cut.
5590
5591 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5592
5593         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5594         * version.in: Bump version to 8.3.50.DATE-git.
5595
5596 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5597
5598         * aix-thread.c (ptid_cmp): Remove unused variable.
5599         (get_signaled_thread): Likewise.
5600         (store_regs_user_thread): Likewise.
5601         (store_regs_kernel_thread): Likewise.
5602         (fetch_regs_kernel_thread): Remove shadowed variable.
5603
5604 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5605
5606         * features/riscv/32bit-cpu.xml: Add register numbers.
5607         * features/riscv/32bit-fpu.c: Regenerate.
5608         * features/riscv/32bit-fpu.xml: Add register numbers.
5609         * features/riscv/64bit-cpu.xml: Add register numbers.
5610         * features/riscv/64bit-fpu.c: Regenerate.
5611         * features/riscv/64bit-fpu.xml: Add register numbers.
5612
5613 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5614
5615         * NEWS: Mention two argument form of gdb.Value constructor.
5616         * python/py-value.c (convert_buffer_and_type_to_value): New
5617         function.
5618         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5619         Add support for handling an optional second argument.  Call
5620         convert_buffer_and_type_to_value as appropriate.
5621         * python/python-internal.h (Py_buffer_deleter): New struct.
5622         (Py_buffer_up): New typedef.
5623
5624 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5625
5626         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5627         instead of releasing ownership.
5628
5629 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5630
5631         * dwarf2read.c (open_and_init_dwp_file): Call
5632         elf_numsections instead of bfd_count_sections to initialize
5633         dwp_file->num_sections.
5634
5635 2019-02-25  Tom Tromey  <tromey@adacore.com>
5636
5637         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5638
5639 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5640
5641         * gcore.in: Add '--readnever' option when invoking GDB.
5642
5643 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5644
5645         * MAINTAINERS: Update my email address.
5646
5647 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5648
5649         * build-id.c (build_id_to_debug_bfd_1): New function.
5650         (build_id_to_debug_bfd): Look for separate debug file in
5651         sysroot.
5652
5653 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5654
5655         * gdbarch.sh: Update the copyright year range that is placed into
5656         generated files.
5657
5658 2019-02-22  Keith Seitz  <keiths@redhat.com>
5659
5660         PR symtab/23853
5661         * linespec.c (create_sals_line_offset): Search for the default
5662         symtab's filename instead of its fullname.
5663
5664 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5665
5666         * NEWS: Update style defaults.
5667
5668 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5669
5670         * main.c (captured_main_1): Disable styling in batch mode.
5671
5672 2019-02-20  Tom Tromey  <tom@tromey.com>
5673
5674         * symtab.c (symtab_symbol_info): Fix typos.
5675
5676 2019-02-20  Tom Tromey  <tromey@adacore.com>
5677
5678         * findcmd.c (_initialize_mem_search): Use upper case for
5679         metasyntactic variables.
5680
5681 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5682
5683         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5684         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5685
5686 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5687
5688         * top.h (source_file_name): Change to std::string.
5689         * top.c (source_file_name): Likewise.
5690         (command_line_input): Adjust.
5691         * cli/cli-script.c (script_from_file): Adjust.
5692
5693 2019-02-19  Tom Tromey  <tromey@adacore.com>
5694
5695         * ravenscar-thread.c
5696         (ravenscar_thread_target::update_thread_list): Don't call
5697         ada_build_task_list.
5698         * ada-lang.h (ada_build_task_list): Don't declare.
5699         * ada-tasks.c (struct ada_tasks_inferior_data)
5700         <task_list_valid_p>: Now bool.
5701         (read_known_tasks, ada_task_list_changed)
5702         (ada_tasks_invalidate_inferior_data): Update.
5703         (read_known_tasks_array): Return bool.
5704         (read_known_tasks_list): Likewise.
5705         (read_known_tasks): Return void.
5706         (ada_build_task_list): Now static.
5707
5708 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5709
5710         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5711         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5712
5713 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5714
5715         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5716         variant for ada_tasks_pspace_data_handle and
5717         ada_tasks_inferior_data_handle.
5718         (ada_tasks_pspace_data_cleanup): New function.
5719         (ada_tasks_inferior_data_cleanup): New function.
5720
5721 2019-02-17  Tom Tromey  <tom@tromey.com>
5722
5723         * macrotab.h (macro_source_fullname): Return a std::string.
5724         * macrotab.c (macro_include, check_for_redefinition)
5725         (macro_undef, macro_lookup_definition, foreach_macro)
5726         (foreach_macro_in_scope): Update.
5727         (macro_source_fullname): Return a std::string.
5728         * macrocmd.c (show_pp_source_pos): Update.
5729
5730 2019-02-17  Tom Tromey  <tom@tromey.com>
5731
5732         * macrocmd.c (show_pp_source_pos): Style the file names.
5733
5734 2019-02-17  Tom Tromey  <tom@tromey.com>
5735
5736         PR tui/24197:
5737         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5738
5739 2019-02-17  Tom Tromey  <tom@tromey.com>
5740
5741         * ada-lang.c (user_select_syms): Use filtered printing.
5742         * utils.c (wrap_style): New global.
5743         (desired_style): Remove.
5744         (emit_style_escape): Add stream parameter.
5745         (set_output_style, reset_terminal_style, prompt_for_continue):
5746         Update.
5747         (flush_wrap_buffer): Only flush gdb_stdout.
5748         (wrap_here): Set wrap_style.
5749         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5750         treat escape sequences as a character.  Change when wrap buffer is
5751         flushed.
5752         (fputs_styled): Do not set the output style when the default is
5753         requested.
5754         * ui-style.h (struct ui_file_style) <is_default>: New method.
5755         * source.c (print_source_lines_base): Emit escape sequences in one
5756         piece.
5757
5758 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5759
5760         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5761         integers and enumeration types.
5762
5763 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5764
5765         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5766         instead of lookup_symbol_in_language
5767         (do_exact_match): New function.
5768         (ada_get_symbol_name_matcher): Return do_exact_match when
5769         doing a verbatim match.
5770
5771 2019-02-15  Tom Tromey  <tromey@adacore.com>
5772
5773         * ravenscar-thread.c (ravenscar_thread_target::resume)
5774         (ravenscar_thread_target::wait): Special case wildcard requests.
5775
5776 2019-02-15  Tom Tromey  <tromey@adacore.com>
5777
5778         * ravenscar-thread.c (base_ptid): Remove.
5779         (struct ravenscar_thread_target) <close>: New method.
5780         <m_base_ptid>: New member.
5781         <update_inferior_ptid, active_task, task_is_currently_active,
5782         runtime_initialized>: Declare methods.
5783         <ravenscar_thread_target>: Add constructor.
5784         (ravenscar_thread_target::task_is_currently_active)
5785         (ravenscar_thread_target::update_inferior_ptid)
5786         (ravenscar_runtime_initialized): Rename.  Now methods.
5787         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5788         (ravenscar_thread_target::update_thread_list): Update.
5789         (ravenscar_thread_target::active_task): Now method.
5790         (ravenscar_thread_target::store_registers)
5791         (ravenscar_thread_target::prepare_to_store)
5792         (ravenscar_thread_target::prepare_to_store)
5793         (ravenscar_thread_target::mourn_inferior): Update.
5794         (ravenscar_inferior_created): Use "new" to create target.
5795         (ravenscar_thread_target::get_ada_task_ptid): Update.
5796         (_initialize_ravenscar): Don't initialize base_ptid.
5797         (ravenscar_ops): Remove global.
5798
5799 2019-02-15  Tom Tromey  <tromey@adacore.com>
5800
5801         * target.h (push_target): Declare new overload.
5802         * target.c (push_target): New overload, taking an rvalue reference.
5803         * remote.c (remote_target::open_1): Use push_target overload.
5804         * corelow.c (core_target_open): Use push_target overload.
5805
5806 2019-02-15  Tom Tromey  <tromey@adacore.com>
5807
5808         * ravenscar-thread.c (is_ravenscar_task)
5809         (ravenscar_task_is_currently_active): Return bool.
5810         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5811         (_initialize_ravenscar): Remove "(void)".
5812         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5813         Return bool.
5814
5815 2019-02-15  Tom Tromey  <tromey@adacore.com>
5816
5817         * ravenscar-thread.c (ravenscar_runtime_initializer)
5818         (has_ravenscar_runtime, get_running_thread_id)
5819         (ravenscar_thread_target::resume): Fix indentation.
5820
5821 2019-02-15  Tom Tromey  <tromey@adacore.com>
5822
5823         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5824         from ravenscar_arch_ops.
5825         (sparc_ravenscar_ops::fetch_registers)
5826         (sparc_ravenscar_ops::store_registers): Now methods.
5827         (sparc_ravenscar_prepare_to_store): Remove.
5828         (sparc_ravenscar_ops): Redefine.
5829         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5830         methods and destructor.  Remove members.
5831         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5832         (ravenscar_thread_target::store_registers)
5833         (ravenscar_thread_target::prepare_to_store): Update.
5834         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5835         Remove.
5836         (struct ppc_ravenscar_powerpc_ops): Derive from
5837         ravenscar_arch_ops.
5838         (ppc_ravenscar_powerpc_ops::fetch_registers)
5839         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5840         (ppc_ravenscar_powerpc_ops): Redefine.
5841         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5842         (ppc_ravenscar_e500_ops::fetch_registers)
5843         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5844         (ppc_ravenscar_e500_ops): Redefine.
5845         * aarch64-ravenscar-thread.c
5846         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5847         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5848         (aarch64_ravenscar_fetch_registers)
5849         (aarch64_ravenscar_store_registers): Now methods.
5850         (aarch64_ravenscar_ops): Redefine.
5851
5852 2019-02-15  Tom Tromey  <tromey@adacore.com>
5853
5854         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5855         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5856         (ravenscar_thread_target::stopped_by_watchpoint)
5857         (ravenscar_thread_target::stopped_data_address)
5858         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5859
5860 2019-02-15  Tom Tromey  <tromey@adacore.com>
5861
5862         * ravenscar-thread.c: Fix some typos.
5863
5864 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5865             Tom Tromey  <tromey@adacore.com>
5866
5867         * ada-lang.c (ada_exception_sal): Change addr_string to a
5868         std::string.
5869         (create_ada_exception_catchpoint): Update.
5870
5871 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5872             Tom Tromey  <tromey@adacore.com>
5873
5874         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5875         (bp_location_ops): Remove.
5876         (base_breakpoint_allocate_location): Update.
5877         (free_bp_location): Update.
5878         * ada-lang.c (class ada_catchpoint_location)
5879         <ada_catchpoint_location>: Remove ops parameter.
5880         (ada_catchpoint_location_dtor): Remove.
5881         (ada_catchpoint_location_ops): Remove.
5882         (allocate_location_exception): Update.
5883         * breakpoint.h (struct bp_location_ops): Remove.
5884         (class bp_location) <bp_location>: Remove bp_location_ops
5885         parameter.
5886         <~bp_location>: Add destructor.
5887         <ops>: Remove.
5888
5889 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5890             Pedro Alves  <palves@redhat.com>
5891
5892         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5893         'PATH_MAX'.
5894
5895 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5896             Samuel Thibault  <samuel.thibault@gnu.org>
5897             Thomas Schwinge  <thomas@codesourcery.com>
5898
5899         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5900         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5901
5902 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5903
5904         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5905         (check_empty): Use "const char *".
5906
5907         * gnu-nat.c (gnu_nat_target::detach): Instead of
5908         'detach_inferior (pid)' call
5909         'detach_inferior (find_inferior_pid (pid))'.
5910
5911         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5912         'nat/fork-inferior.o'.
5913         * gnu-nat.c: #include "nat/fork-inferior.h".
5914
5915         * gnu-nat.c (gnu_nat_target::detach): Instead of
5916         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5917         * gnu-nat.h: #include "inf-child.h".
5918         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5919         'i386_gnu_nat_target::fetch_registers'.
5920         (gnu_store_registers): Rename/move to
5921         'i386_gnu_nat_target::store_registers'.
5922
5923         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5924         * gnu-nat.h (mach_thread_info): New function.
5925         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5926
5927         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5928
5929 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5930
5931         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5932
5933 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5934
5935         * windows-nat.c (windows_add_thread): Add new parameter
5936         "main_thread_p" with default value set to false.  Update
5937         function documentation as well as all callers.
5938         (windows_delete_thread): Likewise.
5939         (fake_create_process): Update call to windows_add_thread.
5940         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5941         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5942         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5943         call to windows_delete_thread.
5944
5945 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5946
5947         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5948
5949 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5950
5951         * symfile.c (find_separate_debug_file): Use canonical path of
5952         sysroot with child_path instead of gdb_sysroot if it is valid.
5953
5954 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5955
5956         * symfile.c (find_separate_debug_file): Use child_path to
5957         determine if an object file is under a sysroot.
5958
5959 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5960
5961         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5962         unittests/child-path-selftests.c.
5963         * common/pathstuff.c (child_path): New function.
5964         * common/pathstuff.h (child_path): New prototype.
5965         * unittests/child-path-selftests.c: New file.
5966
5967 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5968
5969         * symfile.c (find_separate_debug_file): Look for separate debug
5970         files in debug directories under the sysroot.
5971
5972 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5973
5974         * symtab.h (struct minimal_symbol data_p): New const method.
5975         (struct minimal_symbol text_p): Likewise.
5976         * symtab.c (output_source_filename): Use file name style
5977         to print file name.
5978         (print_symbol_info): Likewise.
5979         (print_msymbol_info): Use address style to print addresses.
5980         Use function name style to print executable text symbols.
5981         (expand_symtab_containing_pc): Use data_p.
5982         (find_pc_sect_compunit_symtab): Likewise.
5983
5984 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5985
5986         * breakpoint.c (describe_other_breakpoints): Use address style
5987         to print addresses.
5988         (say_where): Likewise.
5989
5990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5991
5992         * ada-typeprint.c (print_func_type): Print function name
5993         style to print function name.
5994         * c-typeprint.c (c_print_type_1): Likewise.
5995
5996 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5997
5998         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5999         for execve.
6000
6001 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6002
6003         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6004         type_stack.
6005
6006 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6007
6008         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6009         TYPE_CODE_REF types.
6010
6011 2019-02-08  Jim Wilson  <jimw@sifive.com>
6012
6013         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6014         (riscv_linux_fregset): New.
6015         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6016
6017 2019-02-07  Tom Tromey  <tom@tromey.com>
6018
6019         * thread.c (thread_cancel_execution_command): Update.
6020         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6021         methods.
6022         (struct thread_fsm_ops): Remove.
6023         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6024         (thread_fsm_should_stop, thread_fsm_return_value)
6025         (thread_fsm_set_finished, thread_fsm_finished_p)
6026         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6027         Don't declare.
6028         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6029         * infrun.c (clear_proceed_status_thread)
6030         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6031         (print_stop_event): Update.
6032         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6033         Add constructor.
6034         (step_command_fsm_ops): Remove.
6035         (new_step_command_fsm): Remove.
6036         (step_1): Update.
6037         (step_command_fsm::should_stop): Rename from
6038         step_command_fsm_should_stop.
6039         (step_command_fsm::clean_up): Rename from
6040         step_command_fsm_clean_up.
6041         (step_command_fsm::do_async_reply_reason): Rename from
6042         step_command_fsm_async_reply_reason.
6043         (struct until_next_fsm): Inherit from thread_fsm.  Add
6044         constructor.
6045         (until_next_fsm_ops): Remove.
6046         (new_until_next_fsm): Remove.
6047         (until_next_fsm::should_stop): Rename from
6048         until_next_fsm_should_stop.
6049         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6050         (until_next_fsm::do_async_reply_reason): Rename from
6051         until_next_fsm_async_reply_reason.
6052         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6053         constructor.  Change type of breakpoint.
6054         (finish_command_fsm_ops): Remove.
6055         (new_finish_command_fsm): Remove.
6056         (finish_command_fsm::should_stop): Rename from
6057         finish_command_fsm_should_stop.
6058         (finish_command_fsm::clean_up): Rename from
6059         finish_command_fsm_clean_up.
6060         (finish_command_fsm::return_value): Rename from
6061         finish_command_fsm_return_value.
6062         (finish_command_fsm::do_async_reply_reason): Rename from
6063         finish_command_fsm_async_reply_reason.
6064         (finish_command): Update.
6065         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6066         Add constructor.
6067         (call_thread_fsm_ops): Remove.
6068         (call_thread_fsm::call_thread_fsm): Rename from
6069         new_call_thread_fsm.
6070         (call_thread_fsm::should_stop): Rename from
6071         call_thread_fsm_should_stop.
6072         (call_thread_fsm::should_notify_stop): Rename from
6073         call_thread_fsm_should_notify_stop.
6074         (run_inferior_call, call_function_by_hand_dummy): Update.
6075         * cli/cli-interp.c (should_print_stop_to_console): Update.
6076         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6077         Add constructor.  Change type of location_breakpoint,
6078         caller_breakpoint.
6079         (until_break_fsm_ops): Remove.
6080         (new_until_break_fsm): Remove.
6081         (until_break_fsm::should_stop): Rename from
6082         until_break_fsm_should_stop.
6083         (until_break_fsm::clean_up): Rename from
6084         until_break_fsm_clean_up.
6085         (until_break_fsm::do_async_reply_reason): Rename from
6086         until_break_fsm_async_reply_reason.
6087         (until_break_command): Update.
6088         * thread-fsm.c: Remove.
6089         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6090
6091 2019-02-07  Tom Tromey  <tom@tromey.com>
6092
6093         * yy-remap.h: Add include guard.
6094         * xtensa-tdep.h: Add include guard.
6095         * xcoffread.h: Rename include guard.
6096         * varobj-iter.h: Add include guard.
6097         * tui/tui.h: Rename include guard.
6098         * tui/tui-winsource.h: Rename include guard.
6099         * tui/tui-wingeneral.h: Rename include guard.
6100         * tui/tui-windata.h: Rename include guard.
6101         * tui/tui-win.h: Rename include guard.
6102         * tui/tui-stack.h: Rename include guard.
6103         * tui/tui-source.h: Rename include guard.
6104         * tui/tui-regs.h: Rename include guard.
6105         * tui/tui-out.h: Rename include guard.
6106         * tui/tui-layout.h: Rename include guard.
6107         * tui/tui-io.h: Rename include guard.
6108         * tui/tui-hooks.h: Rename include guard.
6109         * tui/tui-file.h: Rename include guard.
6110         * tui/tui-disasm.h: Rename include guard.
6111         * tui/tui-data.h: Rename include guard.
6112         * tui/tui-command.h: Rename include guard.
6113         * tic6x-tdep.h: Add include guard.
6114         * target/waitstatus.h: Rename include guard.
6115         * target/wait.h: Rename include guard.
6116         * target/target.h: Rename include guard.
6117         * target/resume.h: Rename include guard.
6118         * target-float.h: Rename include guard.
6119         * stabsread.h: Add include guard.
6120         * rs6000-tdep.h: Add include guard.
6121         * riscv-fbsd-tdep.h: Add include guard.
6122         * regformats/regdef.h: Rename include guard.
6123         * record.h: Rename include guard.
6124         * python/python.h: Rename include guard.
6125         * python/python-internal.h: Rename include guard.
6126         * python/py-stopevent.h: Rename include guard.
6127         * python/py-ref.h: Rename include guard.
6128         * python/py-record.h: Rename include guard.
6129         * python/py-record-full.h: Rename include guard.
6130         * python/py-record-btrace.h: Rename include guard.
6131         * python/py-instruction.h: Rename include guard.
6132         * python/py-events.h: Rename include guard.
6133         * python/py-event.h: Rename include guard.
6134         * procfs.h: Add include guard.
6135         * proc-utils.h: Add include guard.
6136         * p-lang.h: Add include guard.
6137         * or1k-tdep.h: Rename include guard.
6138         * observable.h: Rename include guard.
6139         * nto-tdep.h: Rename include guard.
6140         * nat/x86-linux.h: Rename include guard.
6141         * nat/x86-linux-dregs.h: Rename include guard.
6142         * nat/x86-gcc-cpuid.h: Add include guard.
6143         * nat/x86-dregs.h: Rename include guard.
6144         * nat/x86-cpuid.h: Rename include guard.
6145         * nat/ppc-linux.h: Rename include guard.
6146         * nat/mips-linux-watch.h: Rename include guard.
6147         * nat/linux-waitpid.h: Rename include guard.
6148         * nat/linux-ptrace.h: Rename include guard.
6149         * nat/linux-procfs.h: Rename include guard.
6150         * nat/linux-osdata.h: Rename include guard.
6151         * nat/linux-nat.h: Rename include guard.
6152         * nat/linux-namespaces.h: Rename include guard.
6153         * nat/linux-btrace.h: Rename include guard.
6154         * nat/glibc_thread_db.h: Rename include guard.
6155         * nat/gdb_thread_db.h: Rename include guard.
6156         * nat/gdb_ptrace.h: Rename include guard.
6157         * nat/fork-inferior.h: Rename include guard.
6158         * nat/amd64-linux-siginfo.h: Rename include guard.
6159         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6160         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6161         * nat/aarch64-linux.h: Rename include guard.
6162         * nat/aarch64-linux-hw-point.h: Rename include guard.
6163         * mn10300-tdep.h: Add include guard.
6164         * mips-linux-tdep.h: Add include guard.
6165         * mi/mi-parse.h: Rename include guard.
6166         * mi/mi-out.h: Rename include guard.
6167         * mi/mi-main.h: Rename include guard.
6168         * mi/mi-interp.h: Rename include guard.
6169         * mi/mi-getopt.h: Rename include guard.
6170         * mi/mi-console.h: Rename include guard.
6171         * mi/mi-common.h: Rename include guard.
6172         * mi/mi-cmds.h: Rename include guard.
6173         * mi/mi-cmd-break.h: Rename include guard.
6174         * m2-lang.h: Add include guard.
6175         * location.h: Rename include guard.
6176         * linux-record.h: Rename include guard.
6177         * linux-nat.h: Add include guard.
6178         * linux-fork.h: Add include guard.
6179         * i386-darwin-tdep.h: Rename include guard.
6180         * hppa-linux-offsets.h: Add include guard.
6181         * guile/guile.h: Rename include guard.
6182         * guile/guile-internal.h: Rename include guard.
6183         * gnu-nat.h: Rename include guard.
6184         * gdb-stabs.h: Rename include guard.
6185         * frv-tdep.h: Add include guard.
6186         * f-lang.h: Add include guard.
6187         * event-loop.h: Add include guard.
6188         * darwin-nat.h: Rename include guard.
6189         * cp-abi.h: Rename include guard.
6190         * config/sparc/nm-sol2.h: Rename include guard.
6191         * config/nm-nto.h: Rename include guard.
6192         * config/nm-linux.h: Add include guard.
6193         * config/i386/nm-i386gnu.h: Rename include guard.
6194         * config/djgpp/nl_types.h: Rename include guard.
6195         * config/djgpp/langinfo.h: Rename include guard.
6196         * compile/gcc-cp-plugin.h: Add include guard.
6197         * compile/gcc-c-plugin.h: Add include guard.
6198         * compile/compile.h: Rename include guard.
6199         * compile/compile-object-run.h: Rename include guard.
6200         * compile/compile-object-load.h: Rename include guard.
6201         * compile/compile-internal.h: Rename include guard.
6202         * compile/compile-cplus.h: Rename include guard.
6203         * compile/compile-c.h: Rename include guard.
6204         * common/xml-utils.h: Rename include guard.
6205         * common/x86-xstate.h: Rename include guard.
6206         * common/version.h: Rename include guard.
6207         * common/vec.h: Rename include guard.
6208         * common/tdesc.h: Rename include guard.
6209         * common/selftest.h: Rename include guard.
6210         * common/scoped_restore.h: Rename include guard.
6211         * common/scoped_mmap.h: Rename include guard.
6212         * common/scoped_fd.h: Rename include guard.
6213         * common/safe-iterator.h: Rename include guard.
6214         * common/run-time-clock.h: Rename include guard.
6215         * common/refcounted-object.h: Rename include guard.
6216         * common/queue.h: Rename include guard.
6217         * common/ptid.h: Rename include guard.
6218         * common/print-utils.h: Rename include guard.
6219         * common/preprocessor.h: Rename include guard.
6220         * common/pathstuff.h: Rename include guard.
6221         * common/observable.h: Rename include guard.
6222         * common/netstuff.h: Rename include guard.
6223         * common/job-control.h: Rename include guard.
6224         * common/host-defs.h: Rename include guard.
6225         * common/gdb_wait.h: Rename include guard.
6226         * common/gdb_vecs.h: Rename include guard.
6227         * common/gdb_unlinker.h: Rename include guard.
6228         * common/gdb_unique_ptr.h: Rename include guard.
6229         * common/gdb_tilde_expand.h: Rename include guard.
6230         * common/gdb_sys_time.h: Rename include guard.
6231         * common/gdb_string_view.h: Rename include guard.
6232         * common/gdb_splay_tree.h: Rename include guard.
6233         * common/gdb_setjmp.h: Rename include guard.
6234         * common/gdb_ref_ptr.h: Rename include guard.
6235         * common/gdb_optional.h: Rename include guard.
6236         * common/gdb_locale.h: Rename include guard.
6237         * common/gdb_assert.h: Rename include guard.
6238         * common/filtered-iterator.h: Rename include guard.
6239         * common/filestuff.h: Rename include guard.
6240         * common/fileio.h: Rename include guard.
6241         * common/environ.h: Rename include guard.
6242         * common/common-utils.h: Rename include guard.
6243         * common/common-types.h: Rename include guard.
6244         * common/common-regcache.h: Rename include guard.
6245         * common/common-inferior.h: Rename include guard.
6246         * common/common-gdbthread.h: Rename include guard.
6247         * common/common-exceptions.h: Rename include guard.
6248         * common/common-defs.h: Rename include guard.
6249         * common/common-debug.h: Rename include guard.
6250         * common/cleanups.h: Rename include guard.
6251         * common/buffer.h: Rename include guard.
6252         * common/btrace-common.h: Rename include guard.
6253         * common/break-common.h: Rename include guard.
6254         * cli/cli-utils.h: Rename include guard.
6255         * cli/cli-style.h: Rename include guard.
6256         * cli/cli-setshow.h: Rename include guard.
6257         * cli/cli-script.h: Rename include guard.
6258         * cli/cli-interp.h: Rename include guard.
6259         * cli/cli-decode.h: Rename include guard.
6260         * cli/cli-cmds.h: Rename include guard.
6261         * charset-list.h: Add include guard.
6262         * buildsym-legacy.h: Rename include guard.
6263         * bfin-tdep.h: Add include guard.
6264         * ax.h: Rename include guard.
6265         * arm-linux-tdep.h: Add include guard.
6266         * arm-fbsd-tdep.h: Add include guard.
6267         * arch/xtensa.h: Rename include guard.
6268         * arch/tic6x.h: Add include guard.
6269         * arch/i386.h: Add include guard.
6270         * arch/arm.h: Rename include guard.
6271         * arch/arm-linux.h: Rename include guard.
6272         * arch/arm-get-next-pcs.h: Rename include guard.
6273         * arch/amd64.h: Add include guard.
6274         * arch/aarch64-insn.h: Rename include guard.
6275         * arch-utils.h: Rename include guard.
6276         * annotate.h: Add include guard.
6277         * amd64-darwin-tdep.h: Rename include guard.
6278         * aarch64-linux-tdep.h: Add include guard.
6279         * aarch64-fbsd-tdep.h: Add include guard.
6280         * aarch32-linux-nat.h: Add include guard.
6281
6282 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6283
6284         * macrotab.c (macro_define_internal): New function that
6285         factorizes macro_define_object_internal and macro_define_function
6286         code.
6287         (macro_define_object_internal): Use macro_define_internal.
6288         (macro_define_function): Likewise.
6289
6290 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6291
6292         * macrocmd.c (extract_identifier): Return
6293         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6294         callers.
6295
6296 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6297
6298         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6299
6300 2019-02-05  Tom Tromey  <tom@tromey.com>
6301
6302         * target.c (target_stack::unpush): Move assertion earlier.
6303
6304 2019-01-30  Tom Tromey  <tom@tromey.com>
6305
6306         PR python/23615:
6307         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6308         (gdbpy_parse_and_eval): Likewise.
6309         * python/python-internal.h (gdbpy_allow_threads): New class.
6310
6311 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6312
6313         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6314         (aarch64_fbsd_fpregmap): Move earlier.
6315         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6316         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6317         instead of individual calls to trad_frame_set_reg_addr.
6318         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6319         earlier.
6320         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6321         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6322         instead of individual calls to trad_frame_set_reg_addr.
6323
6324 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6325
6326         * CONTRIBUTE: Replace contribution list with wiki link.
6327
6328 2019-01-25  Tom Tromey  <tom@tromey.com>
6329
6330         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6331
6332 2019-01-25  Tom Tromey  <tom@tromey.com>
6333
6334         * xtensa-linux-nat.c: Fix common/ includes.
6335         * xml-support.h: Fix common/ includes.
6336         * xml-support.c: Fix common/ includes.
6337         * x86-linux-nat.c: Fix common/ includes.
6338         * windows-nat.c: Fix common/ includes.
6339         * varobj.h: Fix common/ includes.
6340         * varobj.c: Fix common/ includes.
6341         * value.c: Fix common/ includes.
6342         * valops.c: Fix common/ includes.
6343         * utils.c: Fix common/ includes.
6344         * unittests/xml-utils-selftests.c: Fix common/ includes.
6345         * unittests/utils-selftests.c: Fix common/ includes.
6346         * unittests/unpack-selftests.c: Fix common/ includes.
6347         * unittests/tracepoint-selftests.c: Fix common/ includes.
6348         * unittests/style-selftests.c: Fix common/ includes.
6349         * unittests/string_view-selftests.c: Fix common/ includes.
6350         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6351         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6352         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6353         * unittests/rsp-low-selftests.c: Fix common/ includes.
6354         * unittests/parse-connection-spec-selftests.c: Fix common/
6355         includes.
6356         * unittests/optional-selftests.c: Fix common/ includes.
6357         * unittests/offset-type-selftests.c: Fix common/ includes.
6358         * unittests/observable-selftests.c: Fix common/ includes.
6359         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6360         * unittests/memrange-selftests.c: Fix common/ includes.
6361         * unittests/memory-map-selftests.c: Fix common/ includes.
6362         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6363         * unittests/function-view-selftests.c: Fix common/ includes.
6364         * unittests/environ-selftests.c: Fix common/ includes.
6365         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6366         * unittests/common-utils-selftests.c: Fix common/ includes.
6367         * unittests/cli-utils-selftests.c: Fix common/ includes.
6368         * unittests/array-view-selftests.c: Fix common/ includes.
6369         * ui-file.c: Fix common/ includes.
6370         * tui/tui-io.c: Fix common/ includes.
6371         * tracepoint.h: Fix common/ includes.
6372         * tracepoint.c: Fix common/ includes.
6373         * tracefile-tfile.c: Fix common/ includes.
6374         * top.h: Fix common/ includes.
6375         * top.c: Fix common/ includes.
6376         * thread.c: Fix common/ includes.
6377         * target/waitstatus.h: Fix common/ includes.
6378         * target/waitstatus.c: Fix common/ includes.
6379         * target.h: Fix common/ includes.
6380         * target.c: Fix common/ includes.
6381         * target-memory.c: Fix common/ includes.
6382         * target-descriptions.c: Fix common/ includes.
6383         * symtab.h: Fix common/ includes.
6384         * symfile.c: Fix common/ includes.
6385         * stap-probe.c: Fix common/ includes.
6386         * spu-linux-nat.c: Fix common/ includes.
6387         * sparc-nat.c: Fix common/ includes.
6388         * source.c: Fix common/ includes.
6389         * solib.c: Fix common/ includes.
6390         * solib-target.c: Fix common/ includes.
6391         * ser-unix.c: Fix common/ includes.
6392         * ser-tcp.c: Fix common/ includes.
6393         * ser-pipe.c: Fix common/ includes.
6394         * ser-base.c: Fix common/ includes.
6395         * selftest-arch.c: Fix common/ includes.
6396         * s12z-tdep.c: Fix common/ includes.
6397         * rust-exp.y: Fix common/ includes.
6398         * rs6000-aix-tdep.c: Fix common/ includes.
6399         * riscv-tdep.c: Fix common/ includes.
6400         * remote.c: Fix common/ includes.
6401         * remote-notif.h: Fix common/ includes.
6402         * remote-fileio.h: Fix common/ includes.
6403         * remote-fileio.c: Fix common/ includes.
6404         * regcache.h: Fix common/ includes.
6405         * regcache.c: Fix common/ includes.
6406         * record-btrace.c: Fix common/ includes.
6407         * python/python.c: Fix common/ includes.
6408         * python/py-type.c: Fix common/ includes.
6409         * python/py-inferior.c: Fix common/ includes.
6410         * progspace.h: Fix common/ includes.
6411         * producer.c: Fix common/ includes.
6412         * procfs.c: Fix common/ includes.
6413         * proc-api.c: Fix common/ includes.
6414         * printcmd.c: Fix common/ includes.
6415         * ppc-linux-nat.c: Fix common/ includes.
6416         * parser-defs.h: Fix common/ includes.
6417         * osdata.c: Fix common/ includes.
6418         * obsd-nat.c: Fix common/ includes.
6419         * nat/x86-linux.c: Fix common/ includes.
6420         * nat/x86-linux-dregs.c: Fix common/ includes.
6421         * nat/x86-dregs.h: Fix common/ includes.
6422         * nat/x86-dregs.c: Fix common/ includes.
6423         * nat/ppc-linux.c: Fix common/ includes.
6424         * nat/mips-linux-watch.h: Fix common/ includes.
6425         * nat/mips-linux-watch.c: Fix common/ includes.
6426         * nat/linux-waitpid.c: Fix common/ includes.
6427         * nat/linux-ptrace.h: Fix common/ includes.
6428         * nat/linux-ptrace.c: Fix common/ includes.
6429         * nat/linux-procfs.c: Fix common/ includes.
6430         * nat/linux-personality.c: Fix common/ includes.
6431         * nat/linux-osdata.c: Fix common/ includes.
6432         * nat/linux-namespaces.c: Fix common/ includes.
6433         * nat/linux-btrace.h: Fix common/ includes.
6434         * nat/linux-btrace.c: Fix common/ includes.
6435         * nat/fork-inferior.c: Fix common/ includes.
6436         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6437         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6438         * nat/aarch64-linux.c: Fix common/ includes.
6439         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6440         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6441         * namespace.h: Fix common/ includes.
6442         * mips-linux-tdep.c: Fix common/ includes.
6443         * minsyms.c: Fix common/ includes.
6444         * mi/mi-parse.h: Fix common/ includes.
6445         * mi/mi-main.c: Fix common/ includes.
6446         * mi/mi-cmd-env.c: Fix common/ includes.
6447         * memrange.h: Fix common/ includes.
6448         * memattr.c: Fix common/ includes.
6449         * maint.h: Fix common/ includes.
6450         * maint.c: Fix common/ includes.
6451         * main.c: Fix common/ includes.
6452         * machoread.c: Fix common/ includes.
6453         * location.c: Fix common/ includes.
6454         * linux-thread-db.c: Fix common/ includes.
6455         * linux-nat.c: Fix common/ includes.
6456         * linux-fork.c: Fix common/ includes.
6457         * inline-frame.c: Fix common/ includes.
6458         * infrun.c: Fix common/ includes.
6459         * inflow.c: Fix common/ includes.
6460         * inferior.h: Fix common/ includes.
6461         * inferior.c: Fix common/ includes.
6462         * infcmd.c: Fix common/ includes.
6463         * inf-ptrace.c: Fix common/ includes.
6464         * inf-child.c: Fix common/ includes.
6465         * ia64-linux-nat.c: Fix common/ includes.
6466         * i387-tdep.c: Fix common/ includes.
6467         * i386-tdep.c: Fix common/ includes.
6468         * i386-linux-tdep.c: Fix common/ includes.
6469         * i386-linux-nat.c: Fix common/ includes.
6470         * i386-go32-tdep.c: Fix common/ includes.
6471         * i386-fbsd-tdep.c: Fix common/ includes.
6472         * i386-fbsd-nat.c: Fix common/ includes.
6473         * guile/scm-type.c: Fix common/ includes.
6474         * guile/guile.c: Fix common/ includes.
6475         * go32-nat.c: Fix common/ includes.
6476         * gnu-nat.c: Fix common/ includes.
6477         * gdbthread.h: Fix common/ includes.
6478         * gdbarch-selftests.c: Fix common/ includes.
6479         * gdb_usleep.c: Fix common/ includes.
6480         * gdb_select.h: Fix common/ includes.
6481         * gdb_bfd.c: Fix common/ includes.
6482         * gcore.c: Fix common/ includes.
6483         * fork-child.c: Fix common/ includes.
6484         * findvar.c: Fix common/ includes.
6485         * fbsd-nat.c: Fix common/ includes.
6486         * event-top.c: Fix common/ includes.
6487         * event-loop.c: Fix common/ includes.
6488         * dwarf2read.c: Fix common/ includes.
6489         * dwarf2loc.c: Fix common/ includes.
6490         * dwarf2-frame.c: Fix common/ includes.
6491         * dwarf-index-cache.c: Fix common/ includes.
6492         * dtrace-probe.c: Fix common/ includes.
6493         * disasm-selftests.c: Fix common/ includes.
6494         * defs.h: Fix common/ includes.
6495         * csky-tdep.c: Fix common/ includes.
6496         * cp-valprint.c: Fix common/ includes.
6497         * cp-support.h: Fix common/ includes.
6498         * cp-support.c: Fix common/ includes.
6499         * corelow.c: Fix common/ includes.
6500         * completer.h: Fix common/ includes.
6501         * completer.c: Fix common/ includes.
6502         * compile/compile.c: Fix common/ includes.
6503         * compile/compile-loc2c.c: Fix common/ includes.
6504         * compile/compile-cplus-types.c: Fix common/ includes.
6505         * compile/compile-cplus-symbols.c: Fix common/ includes.
6506         * command.h: Fix common/ includes.
6507         * cli/cli-dump.c: Fix common/ includes.
6508         * cli/cli-cmds.c: Fix common/ includes.
6509         * charset.c: Fix common/ includes.
6510         * build-id.c: Fix common/ includes.
6511         * btrace.h: Fix common/ includes.
6512         * btrace.c: Fix common/ includes.
6513         * breakpoint.h: Fix common/ includes.
6514         * breakpoint.c: Fix common/ includes.
6515         * ax.h:
6516         (enum agent_op): Fix common/ includes.
6517         * ax-general.c (struct aop_map): Fix common/ includes.
6518         * ax-gdb.c: Fix common/ includes.
6519         * auxv.c: Fix common/ includes.
6520         * auto-load.c: Fix common/ includes.
6521         * arm-tdep.c: Fix common/ includes.
6522         * arch/riscv.c: Fix common/ includes.
6523         * arch/ppc-linux-common.c: Fix common/ includes.
6524         * arch/i386.c: Fix common/ includes.
6525         * arch/arm.c: Fix common/ includes.
6526         * arch/arm-linux.c: Fix common/ includes.
6527         * arch/arm-get-next-pcs.c: Fix common/ includes.
6528         * arch/amd64.c: Fix common/ includes.
6529         * arch/aarch64.c: Fix common/ includes.
6530         * arch/aarch64-insn.c: Fix common/ includes.
6531         * arch-utils.c: Fix common/ includes.
6532         * amd64-windows-tdep.c: Fix common/ includes.
6533         * amd64-tdep.c: Fix common/ includes.
6534         * amd64-sol2-tdep.c: Fix common/ includes.
6535         * amd64-obsd-tdep.c: Fix common/ includes.
6536         * amd64-nbsd-tdep.c: Fix common/ includes.
6537         * amd64-linux-tdep.c: Fix common/ includes.
6538         * amd64-linux-nat.c: Fix common/ includes.
6539         * amd64-fbsd-tdep.c: Fix common/ includes.
6540         * amd64-fbsd-nat.c: Fix common/ includes.
6541         * amd64-dicos-tdep.c: Fix common/ includes.
6542         * amd64-darwin-tdep.c: Fix common/ includes.
6543         * agent.c: Fix common/ includes.
6544         * ada-lang.h: Fix common/ includes.
6545         * ada-lang.c: Fix common/ includes.
6546         * aarch64-tdep.c: Fix common/ includes.
6547
6548 2019-01-25  Tom Tromey  <tom@tromey.com>
6549
6550         * common/create-version.sh: Use common/version.h.
6551
6552 2019-01-24  Pedro Alves  <palves@redhat.com>
6553
6554         * infrun.c (signal_stop, signal_print, signal_program)
6555         (signal_catch, signal_pass): Now arrays instead of pointers.
6556         (update_signals_program_target, do_target_resume)
6557         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6558         * linux-nat.c (linux_nat_target::pass_signals)
6559         (linux_nat_target::create_inferior, linux_nat_target::attach):
6560         Adjust.
6561         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6562         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6563         * procfs.c (procfs_target::pass_signals): Adjust.
6564         * record-full.c (record_full_target::resume): Adjust.
6565         * remote.c (remote_target::pass_signals)
6566         (remote_target::program_signals): Adjust.
6567         * target-debug.h (target_debug_print_signals): Now takes a
6568         gdb::array_view as parameter.  Adjust.
6569         * target.h (target_ops) <pass_signals, program_signals>: Replace
6570         pointer and length parameters with gdb::array_view.
6571         (target_pass_signals, target_program_signals): Likewise.
6572         * target-delegates.c: Regenerate.
6573
6574 2019-01-24  Pedro Alves  <palves@redhat.com>
6575
6576         * common/forward-scope-exit.h
6577         (forward_scope_exit::forward_scope_exit): Pass arguments to
6578         m_bind_function directly, instead of creating a std::bind and
6579         copying that.
6580
6581 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6582
6583         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6584         for static members.
6585         (pass_in_v_vfp_candidate): Likewise.
6586
6587 2019-01-23  Tom Tromey  <tom@tromey.com>
6588             Pedro Alves  <palves@redhat.com>
6589
6590         * regcache.c (class regcache_invalidator): Remove.
6591         (regcache::raw_write): Use make_scope_exit.
6592
6593 2019-01-23  Tom Tromey  <tom@tromey.com>
6594
6595         * ui-out.h (class ui_out_emit_type): Update comment.
6596
6597 2019-01-23  Tom Tromey  <tom@tromey.com>
6598
6599         * infrun.c (fetch_inferior_event): Update comment.
6600
6601 2019-01-23  Tom Tromey  <tom@tromey.com>
6602             Pedro Alves  <palves@redhat.com>
6603
6604         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6605         parameter.
6606         (fetch_inferior_event): Use SCOPE_EXIT.
6607
6608
6609 2019-01-23  Tom Tromey  <tom@tromey.com>
6610             Pedro Alves  <palves@redhat.com>
6611
6612         * infrun.c (disable_thread_events): Delete.
6613         (stop_all_threads): Use SCOPE_EXIT.
6614
6615 2019-01-23  Tom Tromey  <tom@tromey.com>
6616             Pedro Alves  <palves@redhat.com>
6617
6618         * symfile.c: Include forward-scope-exit.h.
6619         (clear_symtab_users_cleanup): Replace forward declaration with
6620         a FORWARD_SCOPE_EXIT.
6621         (syms_from_objfile_1): Use the forward_scope_exit and
6622         gdb::optional instead of cleanup_function.
6623         (reread_symbols): Use the forward_scope_exit instead of
6624         cleanup_function.
6625         (clear_symtab_users_cleanup): Remove function.
6626
6627 2019-01-23  Tom Tromey  <tom@tromey.com>
6628             Pedro Alves  <palves@redhat.com>
6629
6630         * linux-nat.c: Include scope-exit.h.
6631         (cleanup_target_stop): Remove.
6632         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6633         SCOPE_EXIT.
6634
6635 2019-01-23  Tom Tromey  <tom@tromey.com>
6636             Pedro Alves  <palves@redhat.com>
6637
6638         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6639         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6640
6641 2019-01-23  Tom Tromey  <tom@tromey.com>
6642             Andrew Burgess  <andrew.burgess@embecosm.com>
6643             Pedro Alves  <palves@redhat.com>
6644
6645         * infrun.c (fetch_inferior_event): Use scope_exit.
6646         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6647         * top.c (execute_command): Use scope_exit.
6648         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6649         * utils.c (do_bpstat_clear_actions_cleanup)
6650         (make_bpstat_clear_actions_cleanup): Remove.
6651
6652 2019-01-23  Tom Tromey  <tom@tromey.com>
6653             Pedro Alves  <palves@redhat.com>
6654
6655         * infrun.c: Include "common/scope-exit.h"
6656         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6657         (wait_for_inferior): Use SCOPE_EXIT.
6658         (fetch_inferior_event): Use scope_exit.
6659
6660 2019-01-23  Tom Tromey  <tom@tromey.com>
6661             Pedro Alves  <palves@redhat.com>
6662
6663         * breakpoint.c (create_breakpoint): Remove cleanup.
6664
6665 2019-01-23  Tom Tromey  <tom@tromey.com>
6666             Andrew Burgess  <andrew.burgess@embecosm.com>
6667             Pedro Alves  <palves@redhat.com>
6668
6669 2019-01-23  Pedro Alves  <palves@redhat.com>
6670
6671         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6672
6673 2019-01-23  Pedro Alves  <palves@redhat.com>
6674             Andrew Burgess  <andrew.burgess@embecosm.com>
6675
6676         * gdbthread.h: Include "common/forward-scope-exit.h".
6677         (scoped_finish_thread_state): Redefine custom class in terms of
6678         forward_scope_exit.
6679
6680 2019-01-23  Pedro Alves  <palves@redhat.com>
6681             Andrew Burgess  <andrew.burgess@embecosm.com>
6682
6683         * common/forward-scope-exit.h: New file.
6684
6685 2019-01-23  Pedro Alves  <palves@redhat.com>
6686             Andrew Burgess  <andrew.burgess@embecosm.com>
6687             Tom Tromey  <tom@tromey.com>
6688
6689         * common/scope-exit.h: New file.
6690
6691 2019-01-23  Pedro Alves  <palves@redhat.com>
6692
6693         * common/preprocessor.h (ESC): Rename to ...
6694         (ESC_PARENS): ... this.
6695         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6696         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6697
6698 2019-01-23  Tom Tromey  <tom@tromey.com>
6699
6700         * language.h (class scoped_switch_to_sym_language_if_auto):
6701         Initialize m_lang in both cases.
6702
6703 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6704
6705         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6706         with XCNEW.
6707
6708 2019-01-22  Tom Tromey  <tom@tromey.com>
6709
6710         * corelow.c: Do not include sys/file.h.
6711
6712 2019-01-22  Tom Tromey  <tom@tromey.com>
6713
6714         * tui/tui-wingeneral.h: Include gdb_curses.h.
6715
6716 2019-01-22  Tom Tromey  <tom@tromey.com>
6717
6718         * source-cache.h (class source_cache) <get_source_lines,
6719         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6720
6721 2019-01-22  Tom Tromey  <tom@tromey.com>
6722
6723         * remote-fileio.h (struct remote_target): Declare.
6724
6725 2019-01-22  Tom Tromey  <tom@tromey.com>
6726
6727         * python/py-arch.c: Do not include py-ref.h.
6728         * python/py-bpevent.c: Do not include py-ref.h.
6729         * python/py-cmd.c: Do not include py-ref.h.
6730         * python/py-continueevent.c: Do not include py-ref.h.
6731         * python/py-event.h: Do not include py-ref.h.
6732         * python/py-evtregistry.c: Do not include py-ref.h.
6733         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6734         * python/py-frame.c: Do not include py-ref.h.
6735         * python/py-framefilter.c: Do not include py-ref.h.
6736         * python/py-function.c: Do not include py-ref.h.
6737         * python/py-infevents.c: Do not include py-ref.h.
6738         * python/py-linetable.c: Do not include py-ref.h.
6739         * python/py-objfile.c: Do not include py-ref.h.
6740         * python/py-param.c: Do not include py-ref.h.
6741         * python/py-prettyprint.c: Do not include py-ref.h.
6742         * python/py-progspace.c: Do not include py-ref.h.
6743         * python/py-symbol.c: Do not include py-ref.h.
6744         * python/py-symtab.c: Do not include py-ref.h.
6745         * python/py-type.c: Do not include py-ref.h.
6746         * python/py-unwind.c: Do not include py-ref.h.
6747         * python/py-utils.c: Do not include py-ref.h.
6748         * python/py-value.c: Do not include py-ref.h.
6749         * python/py-varobj.c: Do not include py-ref.h.
6750         * python/py-xmethods.c: Do not include py-ref.h.
6751         * python/python.c: Do not include py-ref.h.
6752         * varobj.c: Do not include py-ref.h.
6753
6754 2019-01-22  Tom Tromey  <tom@tromey.com>
6755
6756         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6757         keyword for bcache.
6758
6759 2019-01-22  Tom Tromey  <tom@tromey.com>
6760
6761         * compile/compile-cplus-types.c: Remove a comment by #include.
6762
6763 2019-01-22  Tom Tromey  <tom@tromey.com>
6764
6765         * compile/gcc-c-plugin.h: Include compile-internal.h.
6766
6767 2019-01-22  Tom Tromey  <tom@tromey.com>
6768
6769         * stabsread.c (EXTERN): Do not define.
6770         (symnum, next_symbol_text_func, processing_gcc_compilation)
6771         (within_function, global_sym_chain, global_stabs)
6772         (previous_stab_code, this_object_header_files)
6773         (n_this_object_header_files)
6774         (n_allocated_this_object_header_files): Define.
6775         * stabsread.h (EXTERN): Never define.  Use "extern".
6776
6777 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6778
6779         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6780         history_value.
6781
6782 2019-01-21  Tom Tromey  <tom@tromey.com>
6783
6784         * ui-out.c: Fix includes.
6785         * tui/tui-source.c: Fix includes.
6786         * target.c: Fix includes.
6787         * remote.c: Fix includes.
6788         * regcache.c: Fix includes.
6789         * python/py-block.c: Fix includes.
6790         * printcmd.c: Fix includes.
6791         * or1k-tdep.c: Fix includes.
6792         * mi/mi-main.c: Fix includes.
6793         * m32r-tdep.c: Fix includes.
6794         * csky-tdep.c: Fix includes.
6795         * compile/compile-cplus-types.c: Fix includes.
6796         * cli/cli-interp.c: Fix includes.
6797
6798 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6799
6800         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6801         for padding.
6802
6803 2019-01-16  Tom Tromey  <tom@tromey.com>
6804
6805         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6806         earlier.
6807         (struct objfile) <msymbols_range>: Move from top level.
6808         <msymbols>: New method.
6809         (class objfile_msymbols): Remove.
6810         * symtab.c (default_collect_symbol_completion_matches_break_on):
6811         Update.
6812         * symmisc.c (dump_msymbols): Update.
6813         * stabsread.c (scan_file_globals): Update.
6814         * objc-lang.c (info_selectors_command, info_classes_command)
6815         (find_methods): Update.
6816         * minsyms.c (find_solib_trampoline_target): Update.
6817         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6818         * coffread.c (coff_symfile_read): Update.
6819         * ada-lang.c (ada_lookup_simple_minsym)
6820         (ada_collect_symbol_completion_matches): Update.
6821
6822 2019-01-16  Tom Tromey  <tom@tromey.com>
6823
6824         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6825         type.  Remove no-argument constructor.
6826         <iterator::operator++>: Simplify.
6827         <begin>: Update.
6828         <end>: Use minimal_symbol_count.
6829
6830 2019-01-16  Tom Tromey  <tom@tromey.com>
6831
6832         * objfiles.h (struct objfile) <psymtabs>: New method.
6833         (class objfile_psymtabs): Remove.
6834         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6835         typedef.
6836         <range>: New method.
6837         (require_partial_symbols): Change return type.
6838         * psymtab.c (require_partial_symbols)
6839         (psym_expand_symtabs_matching): Update.
6840         * mdebugread.c (parse_partial_symbols): Update.
6841         * dbxread.c (dbx_end_psymtab): Update.
6842
6843 2019-01-15  Tom Tromey  <tom@tromey.com>
6844
6845         * symtab.c (lookup_objfile_from_block)
6846         (lookup_symbol_in_objfile_symtabs)
6847         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6848         (find_line_symtab, info_sources_command)
6849         (default_collect_symbol_completion_matches_break_on)
6850         (make_source_files_completion_list): Update.
6851         * symmisc.c (print_objfile_statistics, dump_objfile)
6852         (maintenance_print_symbols, maintenance_info_symtabs)
6853         (maintenance_check_symtabs, maintenance_info_line_tables):
6854         Update.
6855         * source.c (select_source_symtab)
6856         (forget_cached_source_info_for_objfile): Update.
6857         * objfiles.h (class objfile_compunits): Remove.
6858         (struct objfile) <compunits_range>: New typedef.
6859         (compunits): New method.
6860         * objfiles.c (objfile_relocate1): Update.
6861         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6862         * maint.c (count_symtabs_and_blocks): Update.
6863         * linespec.c (iterate_over_all_matching_symtabs): Update.
6864         * cp-support.c (add_symbol_overload_list_qualified): Update.
6865         * coffread.c (coff_symtab_read): Update.
6866         * ada-lang.c (add_nonlocal_symbols)
6867         (ada_collect_symbol_completion_matches)
6868         (ada_add_global_exceptions): Update.
6869
6870 2019-01-15  Tom Tromey  <tom@tromey.com>
6871
6872         * progspace.h (program_space) <objfiles_safe_range>: New
6873         typedef.
6874         <objfiles_safe>: New method.
6875         * objfiles.h (class all_objfiles_safe): Remove.
6876         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6877         * jit.c (jit_inferior_exit_hook): Update.
6878
6879 2019-01-17  Tom Tromey  <tom@tromey.com>
6880
6881         * progspace.h (program_space) <objfiles_range>: New typedef.
6882         <objfiles>: New method.
6883         <objfiles_head>: Rename from objfiles.
6884         (object_files): Update.
6885         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6886         * guile/scm-pretty-print.c
6887         (ppscm_find_pretty_printer_from_objfiles): Update.
6888         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6889         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6890         Update.
6891         * python/py-progspace.c (pspy_get_objfiles): Update.
6892         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6893         Update.
6894         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6895         (objfpy_lookup_objfile_by_build_id): Update.
6896         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6897         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6898         Update.
6899         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6900         (expand_symtab_containing_pc, lookup_objfile_from_block)
6901         (lookup_static_symbol, basic_lookup_transparent_type)
6902         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6903         (find_line_symtab, info_sources_command)
6904         (default_collect_symbol_completion_matches_break_on)
6905         (make_source_files_completion_list, find_main_name): Update.
6906         * symmisc.c (print_symbol_bcache_statistics)
6907         (print_objfile_statistics, maintenance_print_symbols)
6908         (maintenance_print_msymbols, maintenance_print_objfiles)
6909         (maintenance_info_symtabs, maintenance_check_symtabs)
6910         (maintenance_expand_symtabs, maintenance_info_line_tables):
6911         Update.
6912         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6913         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6914         (map_overlay_command, unmap_overlay_command)
6915         (simple_overlay_update, expand_symtabs_matching)
6916         (map_symbol_filenames): Update.
6917         * symfile-debug.c (set_debug_symfile): Update.
6918         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6919         Update.
6920         * source.c (select_source_symtab, forget_cached_source_info):
6921         Update.
6922         * solib.c (solib_read_symbols): Update.
6923         * solib-spu.c (append_ocl_sos): Update.
6924         * psymtab.c (maintenance_print_psymbols)
6925         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6926         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6927         * printcmd.c (info_symbol_command): Update.
6928         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6929         Update.
6930         * objfiles.h (class all_objfiles): Remove.
6931         * objfiles.c (have_partial_symbols, have_full_symbols)
6932         (have_minimal_symbols, qsort_cmp, update_section_map)
6933         (shared_objfile_contains_address_p)
6934         (default_iterate_over_objfiles_in_search_order): Update.
6935         * objc-lang.c (info_selectors_command, info_classes_command)
6936         (find_methods): Update.
6937         * minsyms.c (find_solib_trampoline_target): Update.
6938         * maint.c (maintenance_info_sections)
6939         (maintenance_translate_address, count_symtabs_and_blocks):
6940         Update.
6941         * main.c (captured_main_1): Update.
6942         * linux-thread-db.c (try_thread_db_load_from_pdir)
6943         (has_libpthread): Update.
6944         * linespec.c (iterate_over_all_matching_symtabs)
6945         (search_minsyms_for_name): Update.
6946         * jit.c (jit_find_objf_with_entry_addr): Update.
6947         * hppa-tdep.c (find_unwind_entry)
6948         (hppa_lookup_stub_minimal_symbol): Update.
6949         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6950         Update.
6951         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6952         (elf_gnu_ifunc_resolve_by_got): Update.
6953         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6954         * dwarf-index-write.c (save_gdb_index_command): Update.
6955         * cp-support.c (add_symbol_overload_list_qualified): Update.
6956         * breakpoint.c (create_overlay_event_breakpoint)
6957         (create_longjmp_master_breakpoint)
6958         (create_std_terminate_master_breakpoint)
6959         (create_exception_master_breakpoint): Update.
6960         * blockframe.c (find_pc_partial_function): Update.
6961         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6962         (ada_collect_symbol_completion_matches)
6963         (ada_add_global_exceptions): Update.
6964
6965 2019-01-17  Tom Tromey  <tom@tromey.com>
6966
6967         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6968         declare VEC.
6969         (solib_target_parse_libraries): Change return type.
6970         (library_list_start_segment, library_list_start_section)
6971         (library_list_end_library, library_list_start_library); Update.
6972         (solib_target_free_library_list): Remove.
6973         (solib_target_parse_libraries): Remove cleanup.  Change return
6974         type.
6975         (solib_target_current_sos): Update.
6976
6977 2019-01-17  Tom Tromey  <tromey@bapiya>
6978
6979         * valprint.c: Replace "the the" with "the".
6980         * symtab.c: Replace "the the" with "the".
6981         * solib.c: Replace "the the" with "the".
6982         * solib-dsbt.c: Replace "the the" with "the".
6983         * linespec.c: Replace "the the" with "the".
6984         * dwarf2loc.h: Replace "the the" with "the".
6985         * amd64-windows-tdep.c: Replace "the the" with "the".
6986         * aarch64-tdep.c: Replace "the the" with "the".
6987
6988 2019-01-16  Keith Seitz  <keiths@redhat.com>
6989
6990         PR gdb/23773
6991         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6992         <builder>: Rename to ..
6993         <m_builder>: ... this and make private.
6994         (dwarf2_cu::get_builder): New method.  Change all users of
6995         `builder' to use this method.
6996         (dwarf2_start_symtab): Move to ...
6997         (dwarf2_cu::start_symtab): ... here.  Update all callers
6998         (setup_type_unit_groups): Move to ...
6999         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7000         callers.
7001         (dwarf2_cu::reset_builder): New method.
7002         (process_full_compunit, process_full_type_unit): Use
7003         dwarf2_cu::reset_builder.
7004         (follow_die_offset): Record the ancestor CU if it is different
7005         from the followed DIE's CU.
7006         (follow_die_sig_1): Likewise.
7007
7008 2019-01-15  Tom Tromey  <tom@tromey.com>
7009
7010         * remote.c (class remote_state) <buf>: Now a char_vector.
7011         <buf_size>: Remove.
7012         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7013         parameter.
7014         (remote_target::getpkt_or_notif_sane_1)
7015         (remote_target::getpkt_sane)
7016         (remote_target::getpkt_or_notif_sane): Likewise.
7017         (class remote_target) <putpkt>: New overload.
7018         (remote_target::read_frame): Change type of "buf_p".  Remove
7019         sizeof_p parameter.
7020         (packet_ok): New overload.
7021         (packet_check_result): New overload.
7022         Update all uses.
7023
7024 2019-01-14  Tom Tromey  <tom@tromey.com>
7025
7026         * remote-notif.c (handle_notification, remote_notif_ack)
7027         (remote_notif_parse): Make "buf" const.
7028         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7029         const.
7030         (remote_notif_parse, remote_notif_ack, handle_notification):
7031         Likewise.
7032         * remote.c (remote_notif_stop_parse): Make "buf" const.
7033         (remote_target::remote_parse_stop_reply): Make "buf" const.
7034         (remote_notif_stop_ack): Make "buf" const.
7035
7036 2019-01-14  Tom Tromey  <tom@tromey.com>
7037
7038         * remote.c (remote_console_output): Make parameter const.
7039
7040 2019-01-14  Tom Tromey  <tom@tromey.com>
7041
7042         * target-debug.h (target_debug_print_signals): Constify.
7043         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7044         * procfs.c (procfs_target::pass_signals): Update.
7045         * linux-nat.c (linux_nat_target::pass_signals): Update.
7046         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7047         * target-delegates.c: Rebuild.
7048         * remote.c (remote_target::program_signals): Update.
7049         (remote_target::pass_signals): Update.
7050         * target.c (target_pass_signals): Constify argument.
7051         (target_program_signals): Likewise.
7052         * target.h (struct target_ops) <pass_signals, program_signals>:
7053         Constify argument.
7054         (target_pass_signals, target_program_signals): Constify argument.
7055
7056 2019-01-14  Tom Tromey  <tom@tromey.com>
7057
7058         PR tui/28819:
7059         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7060
7061 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7062
7063         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7064         field.
7065         * rs6000-tdep.c: Include reggroups.h.
7066         (IS_V_ALIAS_PSEUDOREG): Define.
7067         (rs6000_register_name): Return names for the "vX" aliases.
7068         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7069         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7070         aliases.  Call default_register_reggroup_p for all other
7071         pseudo-registers.
7072         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7073         New functions.
7074         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7075         Handle "vX" aliases.
7076         (v_alias_pseudo_register_collect): New function.
7077         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7078         (rs6000_gdbarch_init): Initialize "vX" aliases as
7079         pseudo-registers.  Restore registration of
7080         rs6000_pseudo_register_reggroup_p with
7081         set_tdesc_pseudo_register_reggroup_p.
7082
7083 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7084
7085         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7086         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7087         set_gdbarch_num_pseudo_regs.
7088
7089 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7090
7091         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7092         Remove arg prefixname, add do_set and do_show.
7093         Add member functions set_list and show_list.
7094         * cli/cli-style.c (class cli_style_option): Update accordingly.
7095         (style_set_list): Move to file scope.
7096         (style_show_list): Likewise.
7097         (set_style): Call help_list.
7098         (show_style): Call cmd_show_list.
7099         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7100         Update to use the new macro.
7101
7102 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7103
7104         * ada-lang.c (_initialize_ada_language): Expand the help text
7105         for the "catch exception" command.
7106
7107 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7108
7109         * symtab.c (matching_obj_sections): Initialize obj,
7110         declare it closer to its usage.
7111
7112 2019-01-10  Tom Tromey  <tom@tromey.com>
7113
7114         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7115         (basic_inf_threads_range): Remove.
7116         (inf_threads_range, inf_non_exited_threads_range)
7117         (safe_inf_threads_range): Use next_adapter.
7118
7119 2019-01-10  Keith Seitz  <keiths@redhat.com>
7120
7121         PR gdb/23712
7122         PR symtab/23010
7123         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7124         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7125
7126 2019-01-10  Keith Seitz  <keiths@redhat.com>
7127
7128         PR gdb/23712
7129         PR symtab/23010
7130         * dictionary.c (pending_to_vector): Remove.
7131         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7132         Remove _1 suffix, replacing functions of the same name.  Update
7133         all callers.
7134         (dict_create_hashed, dict_create_hashed_expandable)
7135         (dict_create_linear, dict_create_linear_expandable, dict_free)
7136         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7137         Make functions static.
7138
7139 2019-01-10  Keith Seitz  <keiths@redhat.com>
7140
7141         PR gdb/23712
7142         PR symtab/23010
7143         * dictionary.h (struct dictionary): Replace declaration with
7144         multidictionary.
7145         (dict_create_hashed, dict_create_hashed_expandable)
7146         (dict_create_linear, dict_create_linear_expandable)
7147         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7148         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7149         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7150         taking multidictionary argument.
7151         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7152         * block.h (struct block) <dict>: Change to multidictionary
7153         and rename `multidict'.
7154         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7155         symmisc.c: Update all dictionary references to multidictionary.
7156
7157 2019-01-10  Keith Seitz  <keiths@redhat.com>
7158
7159         PR gdb/23712
7160         PR symtab/23010
7161         * dictionary.c: Include unordered_map.
7162         (pending_to_vector): New function.
7163         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7164         Rewrite the non-"_1" functions to take vector instead
7165         of linked list.
7166         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7167         "new" _1 versions of the same name.
7168         (multidictionary): Define.
7169         (std::hash<enum language): New definition.
7170         (collate_pending_symbols_by_language, mdict_create_hashed)
7171         (mdict_create_hashed_expandable, mdict_create_linear)
7172         (mdict_create_linear_expandable, mdict_free)
7173         (find_language_dictionary, create_new_language_dictionary)
7174         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7175         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7176         (mdict_size, mdict_empty): New functions.
7177         * dictionary.h (mdict_iterator): Define.
7178
7179 2019-01-10  Pedro Alves  <palves@redhat.com>
7180
7181         * breakpoint.c (read_uploaded_action)
7182         (create_tracepoint_from_upload): Adjust to use
7183         gdb::unique_xmalloc_ptr.
7184         * ctf.c (ctf_write_uploaded_tp):
7185         (SET_ARRAY_FIELD): Use emplace_back.
7186         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7187         * tracefile-tfile.c (tfile_write_uploaded_tp):
7188         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7189         gdb::unique_xmalloc_ptr.
7190         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7191         at_string, cond_string, cmd_strings>: Replace char pointers
7192         with gdb::unique_xmalloc_ptr.
7193
7194 2019-01-10  Pedro Alves  <palves@redhat.com>
7195
7196         * solib-target.c (library_list_start_library): Don't xstrdup name.
7197
7198 2019-01-10  Pedro Alves  <palves@redhat.com>
7199
7200         * mdebugread.c (parse_partial_symbols): Use
7201         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7202
7203 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7204
7205         * linux-fork.c (scoped_switch_fork_info)
7206         <~scoped_switch_fork_info>: Fix incorrect variable name.
7207
7208 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7209
7210         * linux-fork.c (scoped_switch_fork_info)
7211         <scoped_switch_fork_info>: Make explicit.
7212         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7213
7214 2019-01-10  Tom Tromey  <tom@tromey.com>
7215
7216         * objfiles.h (objfile::reset_psymtabs): Update.
7217         * objfiles.c (objfile::objfile): Update.
7218         * psymtab.h (psymtab_storage::obstack): Update.
7219         (psymtab_storage::m_obstack): Use gdb::optional.
7220         (class psymtab_storage): Update comment.  Remove objfile
7221         parameter.
7222         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7223
7224 2019-01-10  Tom Tromey  <tom@tromey.com>
7225
7226         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7227         <free_psymtabs>: Now private.
7228         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7229         (allocate_psymtab): Use new method.
7230
7231 2019-01-10  Tom Tromey  <tom@tromey.com>
7232
7233         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7234         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7235         * mdebugread.c (parse_partial_symbols): Use
7236         allocate_dependencies.
7237         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7238         allocate_dependencies.
7239         (process_psymtab_comp_unit_reader)
7240         (build_type_psymtab_dependencies): Likewise.
7241         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7242
7243 2019-01-10  Tom Tromey  <tom@tromey.com>
7244
7245         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7246         PSYMBOL_SET_LANGUAGE.
7247         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7248
7249 2019-01-10  Tom Tromey  <tom@tromey.com>
7250
7251         * psymtab.h (psymtab_storage::obstack): New method.
7252         <m_obstack>: Rename from obstack; now private.
7253         * psymtab.c (psymtab_storage): Update.
7254         * dwarf2read.c (create_addrmap_from_index)
7255         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7256         Update.
7257
7258 2019-01-10  Tom Tromey  <tom@tromey.com>
7259
7260         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7261         * objfiles.h (objfile::reset_psymtabs): New method.
7262
7263 2019-01-10  Tom Tromey  <tom@tromey.com>
7264
7265         * symmisc.c (print_symbol_bcache_statistics): Update.
7266         (print_objfile_statistics): Update.
7267         * symfile.c (reread_symbols): Update.
7268         * psymtab.h (class psymtab_storage): New.
7269         * psymtab.c (psymtab_storage): New constructor.
7270         (~psymtab_storage): New destructor.
7271         (require_partial_symbols): Update.
7272         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7273         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7274         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7275         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7276         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7277         (start_psymtab_common, end_psymtab_common)
7278         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7279         (allocate_psymtab): Update.
7280         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7281         Update.
7282         (dump_psymtab_addrmap, maintenance_print_psymbols)
7283         (maintenance_check_psymtabs): Update.
7284         (class objfile_psymtabs): Move to objfiles.h.
7285         * psympriv.h (discard_psymtab): Now inline.
7286         (psymtab_discarder::psymtab_discarder): Update.
7287         (psymtab_discarder::~psymtab_discarder): Update.
7288         (ALL_OBJFILE_PSYMTABS): Rewrite.
7289         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7290         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7291         Remove fields.
7292         <partial_symtabs>: New field.
7293         (class objfile_psymtabs): Move from psymtab.h.  Update.
7294         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7295         psymbol_cache.
7296         (objfile::~objfile): Don't destroy psymbol_cache.
7297         * mdebugread.c (parse_partial_symbols): Update.
7298         * dwarf2read.c (create_addrmap_from_index)
7299         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7300         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7301         (add_partial_subprogram, dwarf2_ranges_read): Update.
7302         * dwarf-index-write.c (write_address_map)
7303         (write_one_signatured_type, recursively_write_psymbols)
7304         (class debug_names, class debug_names, write_psymtabs_to_index):
7305         Update.
7306
7307 2019-01-10  Tom Tromey  <tom@tromey.com>
7308
7309         * symtab.h (SYMBOL_SET_NAMES): Update.
7310         (symbol_set_names): Update.
7311         (MSYMBOL_SET_NAMES): Update.
7312         * symtab.c (symbol_set_names): Change argument to be an
7313         objfile_per_bfd_storage.
7314         * psymtab.c (add_psymbol_to_bcache): Update.
7315         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7316
7317 2019-01-10  Tom Tromey  <tom@tromey.com>
7318
7319         * symtab.c (create_demangled_names_hash): Change argument to be an
7320         objfile_per_bfd_storage.
7321         (symbol_set_names): Update.
7322
7323 2019-01-10  Tom Tromey  <tom@tromey.com>
7324
7325         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7326         init_psymbol_list.
7327         * psymtab.c (init_psymbol_list): Do nothing if already called.
7328         * psympriv.h (init_psymbol_list): Add comment.
7329         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7330         init_psymbol_list.
7331         * dbxread.c (dbx_symfile_read): Unconditionally call
7332         init_psymbol_list.
7333
7334 2019-01-10  Tom Tromey  <tom@tromey.com>
7335
7336         * xcoffread.c (scan_xcoff_symtab): Update.
7337         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7338         "where".
7339         * mdebugread.c (parse_partial_symbols)
7340         (handle_psymbol_enumerators): Update.
7341         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7342         * dbxread.c (read_dbx_symtab): Update.
7343         * psympriv.h (psymbol_placement): New enum.
7344         (add_psymbol_to_list): Update.
7345
7346 2019-01-10  Tom Tromey  <tom@tromey.com>
7347
7348         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7349         static_psymbols parameters.
7350         (scan_xcoff_symtab): Update.
7351         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7352         static_psymbols parameters.
7353         * psympriv.h (start_psymtab_common): Update.
7354         * mdebugread.c (parse_partial_symbols): Update.
7355         * dwarf2read.c (create_partial_symtab): Update.
7356         * dbxread.c (read_dbx_symtab): Update.
7357         (start_psymtab): Remove global_psymbols and static_psymbols
7358         parameters.
7359
7360 2019-01-10  Tom Tromey  <tom@tromey.com>
7361
7362         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7363         * psymtab.c (allocate_psymtab): Add comment.
7364         * psympriv.h (allocate_psymtab): Add comment.
7365         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7366         initializations.
7367         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7368
7369 2019-01-10  Tom Tromey  <tom@tromey.com>
7370
7371         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7372         Don't declare.
7373         * mipsread.c: Include mdebugread.h.
7374         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7375         Declare.
7376         * elfread.c: Include mdebugread.h.
7377
7378 2019-01-09  Tom Tromey  <tom@tromey.com>
7379
7380         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7381         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7382         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7383         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7384         (psym_lookup_symbol, psym_find_last_source_symtab)
7385         (psym_forget_cached_source_info, psym_print_stats)
7386         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7387         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7388         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7389         (psym_find_compunit_symtab_by_address)
7390         (maintenance_print_psymbols, maintenance_info_psymtabs)
7391         (maintenance_check_psymtabs): Use ranged for.
7392         * psymtab.h (class objfile_psymtabs): New.
7393         (require_partial_symbols): Return objfile_psymtabs.
7394         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7395
7396 2019-01-09  Tom Tromey  <tom@tromey.com>
7397
7398         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7399         (find_pc_mapped_section, list_overlays_command)
7400         (map_overlay_command, unmap_overlay_command)
7401         (simple_overlay_update): Use all_objfiles.
7402         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7403         * printcmd.c (info_symbol_command): Use all_objfiles.
7404         * objfiles.h (ALL_OBJSECTIONS): Remove.
7405         * maint.c (maintenance_translate_address): Use all_objfiles.
7406         * gcore.c (gcore_create_callback): Use all_objfiles.
7407         (objfile_find_memory_regions): Likewise.
7408
7409 2019-01-09  Tom Tromey  <tom@tromey.com>
7410
7411         * symtab.c (find_line_symtab, info_sources_command)
7412         (make_source_files_completion_list): Use objfile_compunits.
7413         * source.c (select_source_symtab): Use objfile_compunits.
7414         * objfiles.h (struct objfile): Update comment.
7415         (ALL_OBJFILES): Remove.
7416         (ALL_FILETABS): Remove.
7417         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7418         objfile_compunits.
7419
7420 2019-01-09  Tom Tromey  <tom@tromey.com>
7421
7422         * symmisc.c (print_objfile_statistics, dump_objfile)
7423         (maintenance_print_symbols): Use compunit_filetabs.
7424         * source.c (forget_cached_source_info_for_objfile): Use
7425         compunit_filetabs.
7426         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7427         (ALL_FILETABS): Use compunit_filetabs.
7428         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7429         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7430
7431 2019-01-09  Tom Tromey  <tom@tromey.com>
7432
7433         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7434         (compunit_filetabs): New.
7435         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7436         compunit_filetabs.
7437         (info_sources_command, make_source_files_completion_list): Remove
7438         declaration.
7439         * symmisc.c (print_objfile_statistics, dump_objfile)
7440         (maintenance_print_symbols): Remove declaration.
7441         (maintenance_info_symtabs): Use compunit_filetabs.
7442         (maintenance_info_line_tables): Likewise.
7443         * source.c (select_source_symtab): Change local variable name.
7444         (forget_cached_source_info_for_objfile): Remove declaration.
7445         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7446         * objfiles.c (objfile_relocate1): Remove declaration.
7447         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7448         declaration.
7449         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7450         * coffread.c (coff_symtab_read): Remove declaration.
7451         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7452         compunit_filetabs.
7453
7454 2019-01-09  Tom Tromey  <tom@tromey.com>
7455
7456         * symtab.c (lookup_objfile_from_block)
7457         (find_pc_sect_compunit_symtab, search_symbols)
7458         (default_collect_symbol_completion_matches_break_on): Use
7459         objfile_compunits.
7460         * objfiles.h (ALL_COMPUNITS): Remove.
7461         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7462         * cp-support.c (add_symbol_overload_list_qualified): Use
7463         objfile_compunits.
7464         * ada-lang.c (ada_collect_symbol_completion_matches)
7465         (ada_add_global_exceptions): Use objfile_compunits.
7466
7467 2019-01-09  Tom Tromey  <tom@tromey.com>
7468
7469         * source.c (select_source_symtab)
7470         (forget_cached_source_info_for_objfile): Remove declaration.
7471         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7472         declaration.
7473         * maint.c (count_symtabs_and_blocks): Remove declaration.
7474         * cp-support.c (add_symbol_overload_list_qualified): Remove
7475         declaration.
7476         * coffread.c (coff_symtab_read): Remove declaration.
7477         * symtab.c (lookup_symbol_in_objfile_symtabs)
7478         (basic_lookup_transparent_type_1): Use objfile_compunits.
7479         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7480         (info_sources_command, search_symbols)
7481         (default_collect_symbol_completion_matches_break_on)
7482         (make_source_files_completion_list): Remove declaration.
7483         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7484         (ada_collect_symbol_completion_matches)
7485         (ada_add_global_exceptions): Remove declaration.
7486         * linespec.c (iterate_over_all_matching_symtabs): Use
7487         objfile_compunits.
7488         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7489         (class objfile_compunits): New.
7490         (ALL_COMPUNITS): Use objfile_compunits.
7491         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7492         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7493         objfile_compunits.
7494         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7495
7496 2019-01-09  Tom Tromey  <tom@tromey.com>
7497
7498         * symtab.c (search_symbols)
7499         (default_collect_symbol_completion_matches_break_on): Use
7500         objfile_msymbols.
7501         * ada-lang.c (ada_lookup_simple_minsym)
7502         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7503         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7504         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7505         objfile_msymbols.
7506         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7507         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7508         * objc-lang.c (find_methods): Use objfile_msymbols.
7509         (info_selectors_command, info_classes_command): Likewise.
7510         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7511         * objfiles.h (class objfile_msymbols): New.
7512         (ALL_OBJFILE_MSYMBOLS): Remove.
7513         (ALL_MSYMBOLS): Remove.
7514
7515 2019-01-09  Tom Tromey  <tom@tromey.com>
7516
7517         * common/next-iterator.h (next_adapter): Add Iterator template
7518         parameter.
7519         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7520         (class all_objfiles_safe): New.
7521         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7522         * objfiles.c (put_objfile_before): Update comment.
7523         (add_separate_debug_objfile): Likewise.
7524         (free_all_objfiles): Use all_objfiles_safe.
7525         (objfile_purge_solibs): Likewise.
7526
7527 2019-01-09  Tom Tromey  <tom@tromey.com>
7528
7529         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7530         (expand_symtab_containing_pc, lookup_static_symbol)
7531         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7532         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7533         all_objfiles.
7534         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7535         * breakpoint.c (create_overlay_event_breakpoint)
7536         (create_longjmp_master_breakpoint)
7537         (create_std_terminate_master_breakpoint)
7538         (create_exception_master_breakpoint): Use all_objfiles.
7539         * linux-thread-db.c (try_thread_db_load_from_pdir)
7540         (has_libpthread): Use all_objfiles.
7541         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7542         * linespec.c (iterate_over_all_matching_symtabs)
7543         (search_minsyms_for_name): Use all_objfiles.
7544         * maint.c (maintenance_info_sections): Use all_objfiles.
7545         * main.c (captured_main_1): Use all_objfiles.
7546         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7547         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7548         * guile/scm-pretty-print.c
7549         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7550         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7551         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7552         (maintenance_print_msymbols): Use all_objfiles.
7553         * source.c (select_source_symtab): Use all_objfiles.
7554         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7555         * symfile.c (remove_symbol_file_command)
7556         (expand_symtabs_matching, map_symbol_filenames): Use
7557         all_objfiles.
7558         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7559         all_objfiles.
7560         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7561         * objc-lang.c (find_methods): Use all_objfiles.
7562         * objfiles.c (have_partial_symbols, have_full_symbols)
7563         (have_minimal_symbols, qsort_cmp)
7564         (default_iterate_over_objfiles_in_search_order): Use
7565         all_objfiles.
7566         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7567         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7568         (maintenance_check_psymtabs): Use all_objfiles.
7569         (ALL_PSYMTABS): Remove.
7570         * compile/compile-object-run.c (do_module_cleanup): Use
7571         all_objfiles.
7572         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7573         * cp-support.c (add_symbol_overload_list_qualified): Use
7574         all_objfiles.
7575         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7576         Use all_objfiles.
7577         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7578         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7579         all_objfiles.
7580         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7581         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7582         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7583         Uses all_objfiles.
7584         * solib.c (solib_read_symbols): Use all_objfiles
7585
7586 2019-01-09  Tom Tromey  <tom@tromey.com>
7587
7588         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7589         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7590         all_objfiles.
7591         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7592         * symmisc.c (print_symbol_bcache_statistics)
7593         (print_objfile_statistics, maintenance_print_objfiles)
7594         (maintenance_info_symtabs, maintenance_check_symtabs)
7595         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7596         all_objfiles.
7597         * source.c (forget_cached_source_info): Use all_objfiles.
7598         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7599         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7600         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7601         * objfiles.c (update_section_map): Use all_objfiles.
7602         (shared_objfile_contains_address_p): Likewise.
7603         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7604         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7605
7606 2019-01-09  Tom Tromey  <tom@tromey.com>
7607
7608         * common/next-iterator.h: New file.
7609         * objfiles.h (class all_objfiles): New.
7610         (struct objfile_iterator): New.
7611
7612 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7613
7614         * NEWS: Move the description of the changed "frame", "select-frame",
7615          and "info frame" commands to the Changed commands section.
7616
7617 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7618
7619         * gdbtypes.c (check_stub_method_group): Remove handling of old
7620         mangling schemes.
7621         * linespec.c (find_methods): Likewise.
7622         * stabsread.c (read_member_functions): Likewise.
7623         * valops.c (search_struct_method): Likewise.
7624         (value_struct_elt_for_reference): Likewise.
7625         * NEWS: Mention this change.
7626
7627 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7628
7629         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7630         print_source_lines.
7631         * source.c (print_source_lines_base): Update line number check.
7632         (print_source_lines): New function.
7633         (source_lines_range::source_lines_range): New function.
7634         * source.h (class source_lines_range): New class.
7635         (print_source_lines): New declaration.
7636
7637 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7638
7639         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7640
7641 2019-01-08  Tom Tromey  <tom@tromey.com>
7642             Simon Marchi  <simon.marchi@ericsson.com>
7643
7644         PR gdb/24060
7645         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7646         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7647         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7648         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7649         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7650         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7651
7652 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7653
7654         * source.c (select_source_symtab): Move header comment to
7655         declaration in source.h.
7656         (forget_cached_source_info_for_objfile): Likewise.
7657         (forget_cached_source_info): Likewise.
7658         (identify_source_line): Likewise.
7659         * source.h (identify_source_line): Move declaration from symtab.h
7660         and add comment from source.c
7661         (print_source_lines): Likewise.
7662         (forget_cached_source_info_for_objfile): Likewise.
7663         (forget_cached_source_info): Likewise.
7664         (select_source_symtab): Likewise.
7665         (enum print_source_lines_flag): Move definition from symtab.h.
7666         * symtab.h (identify_source_line): Move declaration to source.h.
7667         (print_source_lines): Likewise.
7668         (forget_cached_source_info_for_objfile): Likewise.
7669         (forget_cached_source_info): Likewise.
7670         (select_source_symtab): Likewise.
7671         (enum print_source_lines_flag): Move definition to source.h.
7672         * tui/tui-hooks.c: Add 'source.h' include.
7673
7674 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7675
7676         * source.c (print_source_lines_base): Handle requests to print
7677         reverse line number sequences, and guard against empty lines
7678         string.
7679
7680 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7681
7682         * source.c (print_source_lines_base): Fix skip of '\r' if next
7683         character is '\n'.
7684
7685 2019-01-06  Tom Tromey  <tom@tromey.com>
7686
7687         * c-exp.y (struct c_parse_state) <macro_original_text,
7688         expansion_obstack>: New member.
7689         (macro_original_text, expansion_obstack): Remove globals.
7690         (scan_macro_expansion, scanning_macro_expansion)
7691         (finished_macro_expansion): Update.
7692         (scan_macro_cleanup): Remove.
7693         (yylex, c_parse): Update.
7694
7695 2019-01-06  Tom Tromey  <tom@tromey.com>
7696
7697         * c-exp.y (struct c_parse_state) <strings>: New member.
7698         (operator_stoken): Update.
7699
7700 2019-01-06  Tom Tromey  <tom@tromey.com>
7701
7702         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7703         (union type_stack_elt) <typelist_val>: Now a pointer to
7704         std::vector.
7705         (type_stack_cleanup): Don't declare.
7706         (push_typelist): Update.
7707         * parse.c (pop_typelist): Return a std::vector.
7708         (push_typelist): Take a std::vector.
7709         (follow_types): Update.  Do not free args.
7710         (type_stack_cleanup): Remove.
7711         * c-exp.y (struct c_parse_state): New.
7712         (cpstate): New global.
7713         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7714         (nonempty_typelist): Update.
7715         (func_mod): Create a new vector.
7716         (c_parse): Create a c_parse_state.
7717         (check_parameter_typelist): Do not delete params.
7718         (function_method): Update.  Do not delete type_list.
7719
7720 2019-01-06  Tom Tromey  <tom@tromey.com>
7721
7722         PR gdb/28155:
7723         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7724         check_typedef.
7725         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7726         (print_return_value): Likewise.
7727
7728 2019-01-05  Tom Tromey  <tom@tromey.com>
7729
7730         * contrib/cleanup_check.py: Remove.
7731         * contrib/gcc-with-excheck: Remove.
7732         * contrib/exsummary.py: Remove.
7733         * contrib/excheck.py: Remove.
7734
7735 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7736
7737         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7738         NULL. Initialize tpprev to NULL instead of assigning it
7739         to NULL on the next statement.
7740         * windows-nat.c (windows_delete_thread): Remove check for
7741         main_thread_id before printing thread exit notifications.
7742         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7743         Remove thread ID check against main_thread_id.
7744         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7745         windows_delete_thread.
7746         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7747
7748 2019-01-04  Tom Tromey  <tom@tromey.com>
7749
7750         * compile/compile.c (_initialize_compile): Use upper case for
7751         metasyntactic variables.
7752         * symmisc.c (_initialize_symmisc): Use upper case for
7753         metasyntactic variables.
7754         * psymtab.c (_initialize_psymtab): Use upper case for
7755         metasyntactic variables.
7756         * demangle.c (demangle_command): Use upper case for metasyntactic
7757         variables.
7758         (_initialize_demangler): Likewise.
7759         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7760         variables.
7761
7762 2019-01-03  Tom Tromey  <tom@tromey.com>
7763
7764         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7765
7766 2019-01-03  Tom Tromey  <tom@tromey.com>
7767
7768         * python/py-symtab.c (salpy_str): Update.
7769         (struct salpy_sal_object) <symtab>: Now a PyObject.
7770         (salpy_dealloc): Update.
7771         (del_objfile_sal): Use gdbpy_ref.
7772
7773 2019-01-03  Tom Tromey  <tom@tromey.com>
7774
7775         * python/py-type.c (convert_field): Use new_reference.  Return
7776         gdbpy_ref.
7777         (make_fielditem): Return gdbpy_ref.
7778         (typy_fields): Update.
7779         (typy_getitem): Update.
7780         (field_name): Return gdbpy_ref.  Use new_reference.
7781         (typy_iterator_iternext): Update.
7782
7783 2019-01-03  Tom Tromey  <tom@tromey.com>
7784
7785         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7786
7787 2019-01-03  Tom Tromey  <tom@tromey.com>
7788
7789         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7790         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7791         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7792         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7793         (pspy_set_type_printers): Likewise.
7794         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7795         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7796         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7797         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7798         (objfpy_set_type_printers): Likewise.
7799
7800 2019-01-03  Tom Tromey  <tom@tromey.com>
7801
7802         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7803         (gdbpy_print_stack): Use gdbpy_err_fetch.
7804         * python/python-internal.h (class gdbpy_err_fetch): New class.
7805         (class gdbpy_enter) <m_error_type, m_error_value,
7806         m_error_traceback>: Remove.
7807         <m_error>: New member.
7808         (gdbpy_exception_to_string): Don't declare.
7809         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7810         * python/py-value.c (convert_value_from_python): Use
7811         gdbpy_err_fetch.
7812         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7813         gdbpy_exception_to_string.
7814         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7815         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7816         gdbpy_err_fetch.
7817
7818 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7819
7820         * linux-nat.c (delete_lwp_cleanup): Delete.
7821         (struct lwp_deleter): New struct.
7822         (lwp_info_up): New typedef.
7823         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7824         lwp_info_up.
7825
7826 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7827
7828         * linux-fork.c (class scoped_switch_fork_info): New class.
7829         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7830
7831 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7832
7833         * valops.c (find_overload_match): Remove use of null_cleanup, and
7834         calls to do_cleanups.
7835
7836 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7837
7838         * compile/compile-cplus-types.c
7839         (compile_cplus_instance::decl_name): Handle changes to
7840         cp_func_name.
7841         * cp-support.c (cp_func_name): Update header comment, update
7842         return type.
7843         * cp-support.h (cp_func_name): Update return type in declaration.
7844         * valops.c (find_overload_match): Move temp_func local to top
7845         level of function and change its type.  Use temp_func to hold and
7846         delete temporary string obtained from cp_func_name.
7847
7848 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7849
7850         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7851         gdb::char_vector, remove cleanup, and update uses of `msg`.
7852
7853 2019-01-03  Jim Wilson  <jimw@sifive.com>
7854
7855         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7856
7857 2019-01-02  Tom Tromey  <tom@tromey.com>
7858
7859         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7860         (tdesc_parse_xml): Remove cleanups.
7861         * target-descriptions.h (make_cleanup_free_target_description):
7862         Don't declare.
7863         (target_desc_deleter): New struct.
7864         (target_desc_up): New typedef.
7865         * target-descriptions.c (target_desc_deleter::operator()): Rename
7866         from free_target_description.
7867         (make_cleanup_free_target_description): Remove.
7868
7869 2019-01-02  Tom Tromey  <tom@tromey.com>
7870
7871         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7872         constructor, destructor.
7873         (linespec_parser): Remove typedef.
7874         (~linespec_parser): Rename from linespec_parser_delete.
7875         (linespec_lex_to_end, linespec_complete_label)
7876         (linespec_complete): Update.
7877         (decode_line_full): Remove cleanups.
7878         (decode_line_1): Update.
7879
7880 2019-01-02  Tom Tromey  <tom@tromey.com>
7881
7882         * python/python-internal.h (inferior_to_inferior_object): Change
7883         return type.
7884         * python/py-exitedevent.c (create_exited_event_object): Update.
7885         * python/py-inferior.c (inferior_to_inferior_object): Return
7886         gdbpy_ref.
7887         (python_new_inferior, python_inferior_deleted)
7888         (thread_to_thread_object, delete_thread_object)
7889         (build_inferior_list, gdbpy_selected_inferior): Update.
7890         * python/py-infthread.c (create_thread_object): Update.  Also fail
7891         if inferior_to_inferior_object fails.
7892
7893 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7894
7895         * inferior.h (class inferior) <displaced_step_state>: New field.
7896         * infrun.h (struct displaced_step_state): Move here from
7897         infrun.c.  Initialize fields, add constructor.
7898         <inf>: Remove field.
7899         <reset>: New method.
7900         * infrun.c (struct displaced_step_inferior_state): Move to
7901         infrun.h.
7902         (displaced_step_inferior_states): Remove.
7903         (get_displaced_stepping_state): Adust.
7904         (displaced_step_in_progress_any_inferior): Adjust.
7905         (displaced_step_in_progress_thread): Adjust.
7906         (displaced_step_in_progress): Adjust.
7907         (add_displaced_stepping_state): Remove.
7908         (get_displaced_step_closure_by_addr): Adjust.
7909         (remove_displaced_stepping_state): Remove.
7910         (infrun_inferior_exit): Call displaced_step_state.reset.
7911         (use_displaced_stepping): Don't check for NULL.
7912         (displaced_step_prepare_throw): Call
7913         get_displaced_stepping_state.
7914         (displaced_step_fixup): Don't check for NULL.
7915         (prepare_for_detach): Don't check for NULL.
7916
7917 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7918
7919         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7920          in case of call that did not complete.
7921
7922 2019-01-02  Andrey Utkin  <autkin@undo.io>
7923
7924         * symfile.c (find_separate_debug_file): Fix search of debug files for
7925         remote debuggee.
7926
7927 2019-01-02  Tom Tromey  <tom@tromey.com>
7928
7929         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7930         indentation.
7931         * python/py-frame.c (frapy_older): Remove cast.
7932         (frapy_newer): Likewise.
7933         * python/py-breakpoint.c (local_setattro): Remove cast.
7934         * python/py-arch.c (archpy_name): Remove local variable.
7935         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7936
7937 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7938
7939         * unittests/basic_string_view/element_access/char/empty.cc:
7940         Fix year range in copyright header.
7941
7942 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7943
7944         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7945         Delete.
7946         <operator==>: Update with for removed field.
7947         <hash>: Likewise.
7948         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7949         <isa_features>: ...this.
7950         <abi_features>: New field.
7951         (riscv_isa_flen): Update comment.
7952         (riscv_abi_xlen): New declaration.
7953         (riscv_abi_flen): New declaration.
7954         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7955         isa_features.
7956         (riscv_abi_xlen): New function.
7957         (riscv_isa_flen): Update to get answer from isa_features.
7958         (riscv_abi_flen): New function.
7959         (riscv_has_fp_abi): Update to get answer from abi_features.
7960         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7961         xlen and flen.
7962         (riscv_call_info) <xlen, flen>: Update comment.
7963         (riscv_call_arg_struct): Remove invalid assertions
7964         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7965         is removed.
7966         (riscv_gdbarch_init): Gather isa features and abi features
7967         separately, ensure both match on the gdbarch when reusing an old
7968         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7969         a target with 64-bit float hardware.
7970
7971 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7972
7973         * source.c (search_command_helper): Stop reverse search
7974         when line 1 has been searched.
7975
7976 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7977
7978         * record-full.c (record_full_base_target::close): Rewrite
7979         record_full_core_buf_list free logic.
7980
7981 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7982
7983         * break-catch-syscall.c (print_one_catch_syscall): xfree
7984         the last text.
7985
7986 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7987
7988         * top.c (print_gdb_version): Update Copyright year in version
7989         message.
7990
7991 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7992
7993         Update copyright year range in all GDB files.
7994
7995 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7996
7997         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7998
7999 For older changes see ChangeLog-2018.
8000 \f
8001 Local Variables:
8002 mode: change-log
8003 left-margin: 8
8004 fill-column: 74
8005 version-control: never
8006 coding: utf-8
8007 End:
8008